{"action":"created","comment":{"url":"https://api.github.com/repos/apple/swift/pulls/comments/58163609","id":58163609,"diff_hunk":"@@ -0,0 +1,50 @@\n+//===--- Subprocess.cpp - Subprocess Stubs --------------------------------===//\n+//\n+// This source file is part of the Swift.org open source project\n+//\n+// Copyright (c) 2014 - 2016 Apple Inc. and the Swift project authors\n+// Licensed under Apache License v2.0 with Runtime Library Exception\n+//\n+// See http://swift.org/LICENSE.txt for license information\n+// See http://swift.org/CONTRIBUTORS.txt for the list of Swift project authors\n+//\n+//===----------------------------------------------------------------------===//\n+\n+#include <spawn.h>\n+#include <sys/types.h>\n+#if defined(__APPLE__)\n+#include <crt_externs.h> // for _NSGetEnviron\n+#endif\n+\n+int swift_posix_spawn_file_actions_init(\n+    posix_spawn_file_actions_t *file_actions) {\n+  return posix_spawn_file_actions_init(file_actions);\n+}\n+\n+int swift_posix_spawn_file_actions_destroy(\n+    posix_spawn_file_actions_t *file_actions) {\n+  return posix_spawn_file_actions_destroy(file_actions);\n+}\n+\n+int swift_posix_spawn_file_actions_addclose(\n+    posix_spawn_file_actions_t *file_actions, int filedes) {\n+  return posix_spawn_file_actions_addclose(file_actions, filedes);\n+}\n+\n+int swift_posix_spawn_file_actions_adddup2(\n+    posix_spawn_file_actions_t *file_actions, int filedes, int newfiledes) {\n+  return posix_spawn_file_actions_adddup2(file_actions, filedes, newfiledes);\n+}\n+\n+int swift_posix_spawn(pid_t *__restrict pid, const char * __restrict path,\n+                      const posix_spawn_file_actions_t *file_actions,\n+                      const posix_spawnattr_t *__restrict attrp,\n+                      char *const argv[__restrict],\n+                      char *const envp[__restrict]) {\n+  return posix_spawn(pid, path, file_actions, attrp, argv, envp);\n+}\n+\n+#if defined(__APPLE__)\n+char ***swift__NSGetEnviron(void) { return _NSGetEnviron(); }","path":"stdlib/private/SwiftPrivateLibcExtras/Subprocess.c","position":48,"original_position":48,"commit_id":"44c0dbd560de699b2370724994fee839519317cb","original_commit_id":"44c0dbd560de699b2370724994fee839519317cb","user":{"login":"compnerd","id":63311,"avatar_url":"https://avatars.githubusercontent.com/u/63311?v=3","gravatar_id":"","url":"https://api.github.com/users/compnerd","html_url":"https://github.com/compnerd","followers_url":"https://api.github.com/users/compnerd/followers","following_url":"https://api.github.com/users/compnerd/following{/other_user}","gists_url":"https://api.github.com/users/compnerd/gists{/gist_id}","starred_url":"https://api.github.com/users/compnerd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/compnerd/subscriptions","organizations_url":"https://api.github.com/users/compnerd/orgs","repos_url":"https://api.github.com/users/compnerd/repos","events_url":"https://api.github.com/users/compnerd/events{/privacy}","received_events_url":"https://api.github.com/users/compnerd/received_events","type":"User","site_admin":false},"body":"I based the name off of that pattern: [swift_][_NSGetEnviron].  What would be a better name for this?","created_at":"2016-04-01T05:26:15Z","updated_at":"2016-04-01T05:26:15Z","html_url":"https://github.com/apple/swift/pull/2006#discussion_r58163609","pull_request_url":"https://api.github.com/repos/apple/swift/pulls/2006","_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/comments/58163609"},"html":{"href":"https://github.com/apple/swift/pull/2006#discussion_r58163609"},"pull_request":{"href":"https://api.github.com/repos/apple/swift/pulls/2006"}}},"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/2006","id":64896237,"html_url":"https://github.com/apple/swift/pull/2006","diff_url":"https://github.com/apple/swift/pull/2006.diff","patch_url":"https://github.com/apple/swift/pull/2006.patch","issue_url":"https://api.github.com/repos/apple/swift/issues/2006","number":2006,"state":"open","locked":false,"title":"stdlib: use stubs for unit tests as well","user":{"login":"compnerd","id":63311,"avatar_url":"https://avatars.githubusercontent.com/u/63311?v=3","gravatar_id":"","url":"https://api.github.com/users/compnerd","html_url":"https://github.com/compnerd","followers_url":"https://api.github.com/users/compnerd/followers","following_url":"https://api.github.com/users/compnerd/following{/other_user}","gists_url":"https://api.github.com/users/compnerd/gists{/gist_id}","starred_url":"https://api.github.com/users/compnerd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/compnerd/subscriptions","organizations_url":"https://api.github.com/users/compnerd/orgs","repos_url":"https://api.github.com/users/compnerd/repos","events_url":"https://api.github.com/users/compnerd/events{/privacy}","received_events_url":"https://api.github.com/users/compnerd/received_events","type":"User","site_admin":false},"body":"<!-- Please complete this template before creating pull request. -->\r\n#### What's in this pull request?\r\n<!-- Description about pull request. -->\r\n\r\n#### Resolved bug number: ([SR-](https://bugs.swift.org/browse/SR-))\r\n<!-- If this pull request resolves any bugs from Swift bug tracker -->\r\n\r\n* * * *\r\n\r\n<!-- This selection should only be completed by Swift admin -->\r\nBefore merging this pull request to apple/swift repository:\r\n- [ ] Test pull request on Swift continuous integration.\r\n\r\n<details>\r\n  <summary>Triggering Swift CI</summary>\r\n\r\nThe swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:\r\n\r\n**Smoke Testing**\r\n\r\n        Platform     | Comment\r\n        ------------ | -------------\r\n        All supported platforms     | @swift-ci Please smoke test\r\n        OS X platform               | @swift-ci Please smoke test OS X platform\r\n        Linux platform              | @swift-ci Please smoke test Linux platform\r\n\r\n **Validation Testing**\r\n\r\n        Platform     | Comment\r\n        ------------ | -------------\r\n        All supported platforms     | @swift-ci Please test\r\n        OS X platform               | @swift-ci Please test OS X platform\r\n        Linux platform              | @swift-ci Please test Linux platform\r\n\r\nNote: Only members of the Apple organization can trigger swift-ci.\r\n</details>\r\n<!-- Thank you for your contribution to Swift! -->\r\n\r\nThis unifies the behaviour for imports across the private libc extras and the\r\npublic libc shims.","created_at":"2016-04-01T05:09:09Z","updated_at":"2016-04-01T05:26:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0766e0d766eca274f16efb390014db2b997327b7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift/pulls/2006/commits","review_comments_url":"https://api.github.com/repos/apple/swift/pulls/2006/comments","review_comment_url":"https://api.github.com/repos/apple/swift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift/issues/2006/comments","statuses_url":"https://api.github.com/repos/apple/swift/statuses/44c0dbd560de699b2370724994fee839519317cb","head":{"label":"compnerd:unit-test-shims","ref":"unit-test-shims","sha":"44c0dbd560de699b2370724994fee839519317cb","user":{"login":"compnerd","id":63311,"avatar_url":"https://avatars.githubusercontent.com/u/63311?v=3","gravatar_id":"","url":"https://api.github.com/users/compnerd","html_url":"https://github.com/compnerd","followers_url":"https://api.github.com/users/compnerd/followers","following_url":"https://api.github.com/users/compnerd/following{/other_user}","gists_url":"https://api.github.com/users/compnerd/gists{/gist_id}","starred_url":"https://api.github.com/users/compnerd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/compnerd/subscriptions","organizations_url":"https://api.github.com/users/compnerd/orgs","repos_url":"https://api.github.com/users/compnerd/repos","events_url":"https://api.github.com/users/compnerd/events{/privacy}","received_events_url":"https://api.github.com/users/compnerd/received_events","type":"User","site_admin":false},"repo":{"id":47945459,"name":"apple-swift","full_name":"compnerd/apple-swift","owner":{"login":"compnerd","id":63311,"avatar_url":"https://avatars.githubusercontent.com/u/63311?v=3","gravatar_id":"","url":"https://api.github.com/users/compnerd","html_url":"https://github.com/compnerd","followers_url":"https://api.github.com/users/compnerd/followers","following_url":"https://api.github.com/users/compnerd/following{/other_user}","gists_url":"https://api.github.com/users/compnerd/gists{/gist_id}","starred_url":"https://api.github.com/users/compnerd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/compnerd/subscriptions","organizations_url":"https://api.github.com/users/compnerd/orgs","repos_url":"https://api.github.com/users/compnerd/repos","events_url":"https://api.github.com/users/compnerd/events{/privacy}","received_events_url":"https://api.github.com/users/compnerd/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/compnerd/apple-swift","description":"The Swift Programming Language","fork":true,"url":"https://api.github.com/repos/compnerd/apple-swift","forks_url":"https://api.github.com/repos/compnerd/apple-swift/forks","keys_url":"https://api.github.com/repos/compnerd/apple-swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/compnerd/apple-swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/compnerd/apple-swift/teams","hooks_url":"https://api.github.com/repos/compnerd/apple-swift/hooks","issue_events_url":"https://api.github.com/repos/compnerd/apple-swift/issues/events{/number}","events_url":"https://api.github.com/repos/compnerd/apple-swift/events","assignees_url":"https://api.github.com/repos/compnerd/apple-swift/assignees{/user}","branches_url":"https://api.github.com/repos/compnerd/apple-swift/branches{/branch}","tags_url":"https://api.github.com/repos/compnerd/apple-swift/tags","blobs_url":"https://api.github.com/repos/compnerd/apple-swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/compnerd/apple-swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/compnerd/apple-swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/compnerd/apple-swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/compnerd/apple-swift/statuses/{sha}","languages_url":"https://api.github.com/repos/compnerd/apple-swift/languages","stargazers_url":"https://api.github.com/repos/compnerd/apple-swift/stargazers","contributors_url":"https://api.github.com/repos/compnerd/apple-swift/contributors","subscribers_url":"https://api.github.com/repos/compnerd/apple-swift/subscribers","subscription_url":"https://api.github.com/repos/compnerd/apple-swift/subscription","commits_url":"https://api.github.com/repos/compnerd/apple-swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/compnerd/apple-swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/compnerd/apple-swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/compnerd/apple-swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/compnerd/apple-swift/contents/{+path}","compare_url":"https://api.github.com/repos/compnerd/apple-swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/compnerd/apple-swift/merges","archive_url":"https://api.github.com/repos/compnerd/apple-swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/compnerd/apple-swift/downloads","issues_url":"https://api.github.com/repos/compnerd/apple-swift/issues{/number}","pulls_url":"https://api.github.com/repos/compnerd/apple-swift/pulls{/number}","milestones_url":"https://api.github.com/repos/compnerd/apple-swift/milestones{/number}","notifications_url":"https://api.github.com/repos/compnerd/apple-swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/compnerd/apple-swift/labels{/name}","releases_url":"https://api.github.com/repos/compnerd/apple-swift/releases{/id}","deployments_url":"https://api.github.com/repos/compnerd/apple-swift/deployments","created_at":"2015-12-14T01:38:31Z","updated_at":"2016-03-08T18:32:13Z","pushed_at":"2016-04-01T05:12:21Z","git_url":"git://github.com/compnerd/apple-swift.git","ssh_url":"git@github.com:compnerd/apple-swift.git","clone_url":"https://github.com/compnerd/apple-swift.git","svn_url":"https://github.com/compnerd/apple-swift","homepage":"https://swift.org/","size":83814,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apple:master","ref":"master","sha":"d163e8431b730d1d362460fceb6a1b90ef0e915b","user":{"login":"apple","id":10639145,"avatar_url":"https://avatars.githubusercontent.com/u/10639145?v=3","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":44838949,"name":"swift","full_name":"apple/swift","owner":{"login":"apple","id":10639145,"avatar_url":"https://avatars.githubusercontent.com/u/10639145?v=3","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apple/swift","description":"The Swift Programming Language","fork":false,"url":"https://api.github.com/repos/apple/swift","forks_url":"https://api.github.com/repos/apple/swift/forks","keys_url":"https://api.github.com/repos/apple/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift/teams","hooks_url":"https://api.github.com/repos/apple/swift/hooks","issue_events_url":"https://api.github.com/repos/apple/swift/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift/events","assignees_url":"https://api.github.com/repos/apple/swift/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift/tags","blobs_url":"https://api.github.com/repos/apple/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift/languages","stargazers_url":"https://api.github.com/repos/apple/swift/stargazers","contributors_url":"https://api.github.com/repos/apple/swift/contributors","subscribers_url":"https://api.github.com/repos/apple/swift/subscribers","subscription_url":"https://api.github.com/repos/apple/swift/subscription","commits_url":"https://api.github.com/repos/apple/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift/merges","archive_url":"https://api.github.com/repos/apple/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift/downloads","issues_url":"https://api.github.com/repos/apple/swift/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift/deployments","created_at":"2015-10-23T21:15:07Z","updated_at":"2016-04-01T05:13:18Z","pushed_at":"2016-04-01T05:22:49Z","git_url":"git://github.com/apple/swift.git","ssh_url":"git@github.com:apple/swift.git","clone_url":"https://github.com/apple/swift.git","svn_url":"https://github.com/apple/swift","homepage":"https://swift.org/","size":116593,"stargazers_count":28224,"watchers_count":28224,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3716,"mirror_url":null,"open_issues_count":74,"forks":3716,"open_issues":74,"watchers":28224,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/2006"},"html":{"href":"https://github.com/apple/swift/pull/2006"},"issue":{"href":"https://api.github.com/repos/apple/swift/issues/2006"},"comments":{"href":"https://api.github.com/repos/apple/swift/issues/2006/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift/pulls/2006/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift/pulls/2006/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift/statuses/44c0dbd560de699b2370724994fee839519317cb"}}}}