{"action":"created","comment":{"url":"https://api.github.com/repos/videojs/videojs-contrib-media-sources/pulls/comments/50178761","id":50178761,"diff_hunk":"@@ -8,35 +8,27 @@\n  * transmuxer running inside of a WebWorker by exposing a simple\n  * message-based interface to a Transmuxer object.\n  */\n-var\n-  muxjs = {},\n-  transmuxer,\n-  initOptions = {};\n-\n-importScripts('../node_modules/mux.js/lib/utils/stream.js');\n-importScripts('../node_modules/mux.js/lib/utils/exp-golomb.js');\n-importScripts('../node_modules/mux.js/lib/mp4/mp4-generator.js');\n-importScripts('../node_modules/mux.js/lib/codecs/aac.js');\n-importScripts('../node_modules/mux.js/lib/codecs/h264.js');\n-importScripts('../node_modules/mux.js/lib/m2ts/m2ts.js');\n-importScripts('../node_modules/mux.js/lib/m2ts/caption-stream.js');\n-importScripts('../node_modules/mux.js/lib/m2ts/metadata-stream.js');\n-importScripts('../node_modules/mux.js/lib/mp4/transmuxer.js');\n+let muxjs = require('mux.js');\n+let gTransmuxer;\n+let initOptions = {};\n \n /**\n  * wireTransmuxerEvents\n  * Re-emits tranmsuxer events by converting them into messages to the\n  * world outside the worker\n  */\n-var wireTransmuxerEvents = function (transmuxer) {\n-  transmuxer.on('data', function (segment) {\n-    // transfer ownership of the underlying ArrayBuffer instead of doing a copy to save memory\n+const wireTransmuxerEvents = function(transmuxer) {\n+  transmuxer.on('data', function(segment) {\n+    // transfer ownership of the underlying ArrayBuffer\n+    // instead of doing a copy to save memory\n     // ArrayBuffers are transferable but generic TypedArrays are not\n+    /* eslint-disable max-len */\n     // see https://developer.mozilla.org/en-US/docs/Web/API/Web_Workers_API/Using_web_workers#Passing_data_by_transferring_ownership_(transferable_objects)\n+    /* eslint-enable max-len */","path":"src/transmuxer-worker.js","position":37,"original_position":37,"commit_id":"5411207acad8faf8a0a93f0695f7b9f02e1bc5f1","original_commit_id":"5411207acad8faf8a0a93f0695f7b9f02e1bc5f1","user":{"login":"BrandonOCasey","id":2381475,"avatar_url":"https://avatars.githubusercontent.com/u/2381475?v=3","gravatar_id":"","url":"https://api.github.com/users/BrandonOCasey","html_url":"https://github.com/BrandonOCasey","followers_url":"https://api.github.com/users/BrandonOCasey/followers","following_url":"https://api.github.com/users/BrandonOCasey/following{/other_user}","gists_url":"https://api.github.com/users/BrandonOCasey/gists{/gist_id}","starred_url":"https://api.github.com/users/BrandonOCasey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BrandonOCasey/subscriptions","organizations_url":"https://api.github.com/users/BrandonOCasey/orgs","repos_url":"https://api.github.com/users/BrandonOCasey/repos","events_url":"https://api.github.com/users/BrandonOCasey/events{/privacy}","received_events_url":"https://api.github.com/users/BrandonOCasey/received_events","type":"User","site_admin":false},"body":"do we want to be warned about stuff that does not matter every time we lint though? Link shortener would also work","created_at":"2016-01-19T21:32:22Z","updated_at":"2016-01-19T21:32:22Z","html_url":"https://github.com/videojs/videojs-contrib-media-sources/pull/64#discussion_r50178761","pull_request_url":"https://api.github.com/repos/videojs/videojs-contrib-media-sources/pulls/64","_links":{"self":{"href":"https://api.github.com/repos/videojs/videojs-contrib-media-sources/pulls/comments/50178761"},"html":{"href":"https://github.com/videojs/videojs-contrib-media-sources/pull/64#discussion_r50178761"},"pull_request":{"href":"https://api.github.com/repos/videojs/videojs-contrib-media-sources/pulls/64"}}},"pull_request":{"url":"https://api.github.com/repos/videojs/videojs-contrib-media-sources/pulls/64","id":56183761,"html_url":"https://github.com/videojs/videojs-contrib-media-sources/pull/64","diff_url":"https://github.com/videojs/videojs-contrib-media-sources/pull/64.diff","patch_url":"https://github.com/videojs/videojs-contrib-media-sources/pull/64.patch","issue_url":"https://api.github.com/repos/videojs/videojs-contrib-media-sources/issues/64","number":64,"state":"open","locked":false,"title":"browserifiy, pluginifiy, and nodeifiy media-sources","user":{"login":"BrandonOCasey","id":2381475,"avatar_url":"https://avatars.githubusercontent.com/u/2381475?v=3","gravatar_id":"","url":"https://api.github.com/users/BrandonOCasey","html_url":"https://github.com/BrandonOCasey","followers_url":"https://api.github.com/users/BrandonOCasey/followers","following_url":"https://api.github.com/users/BrandonOCasey/following{/other_user}","gists_url":"https://api.github.com/users/BrandonOCasey/gists{/gist_id}","starred_url":"https://api.github.com/users/BrandonOCasey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BrandonOCasey/subscriptions","organizations_url":"https://api.github.com/users/BrandonOCasey/orgs","repos_url":"https://api.github.com/users/BrandonOCasey/repos","events_url":"https://api.github.com/users/BrandonOCasey/events{/privacy}","received_events_url":"https://api.github.com/users/BrandonOCasey/received_events","type":"User","site_admin":false},"body":"changed everything to es6, split files up, uses new generator conversions\r\nexample now follows standards and works\r\nadded build step for example, and got example working for real\r\nnow following the vjs standards\r\nfixed a lint error with the example\r\nmoved the example to its own folder and browserfied it\r\nconverted files to use node style, added browserify to grunt build, added browserify to karma unit tests\r\nupdated readme to point to new example location\r\nchanged everything to es6, split files up, uses new generator conversions\r\nexample now follows standards and works\r\nadded build step for example, and got example working for real\r\nnow following the vjs standards\r\nfixed a lint error with the example\r\nmerging recent changes from master\r\nfixing the readme\r\nTerminate any sourcebuffer's web workers when closing the media source\r\nMerge pull request #62 from imbcmdth/terminator\r\nspecify the babelify transform so that browserify can require us from other modules\r\nverify that the plugin is registed for a sanity check\r\nfixed function scopes\r\nignore example modifications\r\nignore example during linting\r\nfixing lint errors in plugin\r\nignore safari tests did not work in it before\r\nmerged in web worker termination changes, and test","created_at":"2016-01-15T15:39:51Z","updated_at":"2016-01-19T21:32:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"236e0b1bf648fe50e01c5c65e4f5f8543213dfa3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/videojs/videojs-contrib-media-sources/pulls/64/commits","review_comments_url":"https://api.github.com/repos/videojs/videojs-contrib-media-sources/pulls/64/comments","review_comment_url":"https://api.github.com/repos/videojs/videojs-contrib-media-sources/pulls/comments{/number}","comments_url":"https://api.github.com/repos/videojs/videojs-contrib-media-sources/issues/64/comments","statuses_url":"https://api.github.com/repos/videojs/videojs-contrib-media-sources/statuses/5411207acad8faf8a0a93f0695f7b9f02e1bc5f1","head":{"label":"BrandonOCasey:browserify-squash","ref":"browserify-squash","sha":"5411207acad8faf8a0a93f0695f7b9f02e1bc5f1","user":{"login":"BrandonOCasey","id":2381475,"avatar_url":"https://avatars.githubusercontent.com/u/2381475?v=3","gravatar_id":"","url":"https://api.github.com/users/BrandonOCasey","html_url":"https://github.com/BrandonOCasey","followers_url":"https://api.github.com/users/BrandonOCasey/followers","following_url":"https://api.github.com/users/BrandonOCasey/following{/other_user}","gists_url":"https://api.github.com/users/BrandonOCasey/gists{/gist_id}","starred_url":"https://api.github.com/users/BrandonOCasey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BrandonOCasey/subscriptions","organizations_url":"https://api.github.com/users/BrandonOCasey/orgs","repos_url":"https://api.github.com/users/BrandonOCasey/repos","events_url":"https://api.github.com/users/BrandonOCasey/events{/privacy}","received_events_url":"https://api.github.com/users/BrandonOCasey/received_events","type":"User","site_admin":false},"repo":{"id":48180235,"name":"videojs-contrib-media-sources","full_name":"BrandonOCasey/videojs-contrib-media-sources","owner":{"login":"BrandonOCasey","id":2381475,"avatar_url":"https://avatars.githubusercontent.com/u/2381475?v=3","gravatar_id":"","url":"https://api.github.com/users/BrandonOCasey","html_url":"https://github.com/BrandonOCasey","followers_url":"https://api.github.com/users/BrandonOCasey/followers","following_url":"https://api.github.com/users/BrandonOCasey/following{/other_user}","gists_url":"https://api.github.com/users/BrandonOCasey/gists{/gist_id}","starred_url":"https://api.github.com/users/BrandonOCasey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BrandonOCasey/subscriptions","organizations_url":"https://api.github.com/users/BrandonOCasey/orgs","repos_url":"https://api.github.com/users/BrandonOCasey/repos","events_url":"https://api.github.com/users/BrandonOCasey/events{/privacy}","received_events_url":"https://api.github.com/users/BrandonOCasey/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/BrandonOCasey/videojs-contrib-media-sources","description":"Code for working with the media source extensions API and video.js","fork":true,"url":"https://api.github.com/repos/BrandonOCasey/videojs-contrib-media-sources","forks_url":"https://api.github.com/repos/BrandonOCasey/videojs-contrib-media-sources/forks","keys_url":"https://api.github.com/repos/BrandonOCasey/videojs-contrib-media-sources/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BrandonOCasey/videojs-contrib-media-sources/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BrandonOCasey/videojs-contrib-media-sources/teams","hooks_url":"https://api.github.com/repos/BrandonOCasey/videojs-contrib-media-sources/hooks","issue_events_url":"https://api.github.com/repos/BrandonOCasey/videojs-contrib-media-sources/issues/events{/number}","events_url":"https://api.github.com/repos/BrandonOCasey/videojs-contrib-media-sources/events","assignees_url":"https://api.github.com/repos/BrandonOCasey/videojs-contrib-media-sources/assignees{/user}","branches_url":"https://api.github.com/repos/BrandonOCasey/videojs-contrib-media-sources/branches{/branch}","tags_url":"https://api.github.com/repos/BrandonOCasey/videojs-contrib-media-sources/tags","blobs_url":"https://api.github.com/repos/BrandonOCasey/videojs-contrib-media-sources/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BrandonOCasey/videojs-contrib-media-sources/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BrandonOCasey/videojs-contrib-media-sources/git/refs{/sha}","trees_url":"https://api.github.com/repos/BrandonOCasey/videojs-contrib-media-sources/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BrandonOCasey/videojs-contrib-media-sources/statuses/{sha}","languages_url":"https://api.github.com/repos/BrandonOCasey/videojs-contrib-media-sources/languages","stargazers_url":"https://api.github.com/repos/BrandonOCasey/videojs-contrib-media-sources/stargazers","contributors_url":"https://api.github.com/repos/BrandonOCasey/videojs-contrib-media-sources/contributors","subscribers_url":"https://api.github.com/repos/BrandonOCasey/videojs-contrib-media-sources/subscribers","subscription_url":"https://api.github.com/repos/BrandonOCasey/videojs-contrib-media-sources/subscription","commits_url":"https://api.github.com/repos/BrandonOCasey/videojs-contrib-media-sources/commits{/sha}","git_commits_url":"https://api.github.com/repos/BrandonOCasey/videojs-contrib-media-sources/git/commits{/sha}","comments_url":"https://api.github.com/repos/BrandonOCasey/videojs-contrib-media-sources/comments{/number}","issue_comment_url":"https://api.github.com/repos/BrandonOCasey/videojs-contrib-media-sources/issues/comments{/number}","contents_url":"https://api.github.com/repos/BrandonOCasey/videojs-contrib-media-sources/contents/{+path}","compare_url":"https://api.github.com/repos/BrandonOCasey/videojs-contrib-media-sources/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BrandonOCasey/videojs-contrib-media-sources/merges","archive_url":"https://api.github.com/repos/BrandonOCasey/videojs-contrib-media-sources/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BrandonOCasey/videojs-contrib-media-sources/downloads","issues_url":"https://api.github.com/repos/BrandonOCasey/videojs-contrib-media-sources/issues{/number}","pulls_url":"https://api.github.com/repos/BrandonOCasey/videojs-contrib-media-sources/pulls{/number}","milestones_url":"https://api.github.com/repos/BrandonOCasey/videojs-contrib-media-sources/milestones{/number}","notifications_url":"https://api.github.com/repos/BrandonOCasey/videojs-contrib-media-sources/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BrandonOCasey/videojs-contrib-media-sources/labels{/name}","releases_url":"https://api.github.com/repos/BrandonOCasey/videojs-contrib-media-sources/releases{/id}","created_at":"2015-12-17T14:52:55Z","updated_at":"2016-01-13T16:30:13Z","pushed_at":"2016-01-18T19:26:41Z","git_url":"git://github.com/BrandonOCasey/videojs-contrib-media-sources.git","ssh_url":"git@github.com:BrandonOCasey/videojs-contrib-media-sources.git","clone_url":"https://github.com/BrandonOCasey/videojs-contrib-media-sources.git","svn_url":"https://github.com/BrandonOCasey/videojs-contrib-media-sources","homepage":null,"size":658,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"videojs:master","ref":"master","sha":"e941e7d0787fe14a5da3f3319d56472c9118b02b","user":{"login":"videojs","id":3287189,"avatar_url":"https://avatars.githubusercontent.com/u/3287189?v=3","gravatar_id":"","url":"https://api.github.com/users/videojs","html_url":"https://github.com/videojs","followers_url":"https://api.github.com/users/videojs/followers","following_url":"https://api.github.com/users/videojs/following{/other_user}","gists_url":"https://api.github.com/users/videojs/gists{/gist_id}","starred_url":"https://api.github.com/users/videojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/videojs/subscriptions","organizations_url":"https://api.github.com/users/videojs/orgs","repos_url":"https://api.github.com/users/videojs/repos","events_url":"https://api.github.com/users/videojs/events{/privacy}","received_events_url":"https://api.github.com/users/videojs/received_events","type":"Organization","site_admin":false},"repo":{"id":13849292,"name":"videojs-contrib-media-sources","full_name":"videojs/videojs-contrib-media-sources","owner":{"login":"videojs","id":3287189,"avatar_url":"https://avatars.githubusercontent.com/u/3287189?v=3","gravatar_id":"","url":"https://api.github.com/users/videojs","html_url":"https://github.com/videojs","followers_url":"https://api.github.com/users/videojs/followers","following_url":"https://api.github.com/users/videojs/following{/other_user}","gists_url":"https://api.github.com/users/videojs/gists{/gist_id}","starred_url":"https://api.github.com/users/videojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/videojs/subscriptions","organizations_url":"https://api.github.com/users/videojs/orgs","repos_url":"https://api.github.com/users/videojs/repos","events_url":"https://api.github.com/users/videojs/events{/privacy}","received_events_url":"https://api.github.com/users/videojs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/videojs/videojs-contrib-media-sources","description":"Code for working with the media source extensions API and video.js","fork":false,"url":"https://api.github.com/repos/videojs/videojs-contrib-media-sources","forks_url":"https://api.github.com/repos/videojs/videojs-contrib-media-sources/forks","keys_url":"https://api.github.com/repos/videojs/videojs-contrib-media-sources/keys{/key_id}","collaborators_url":"https://api.github.com/repos/videojs/videojs-contrib-media-sources/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/videojs/videojs-contrib-media-sources/teams","hooks_url":"https://api.github.com/repos/videojs/videojs-contrib-media-sources/hooks","issue_events_url":"https://api.github.com/repos/videojs/videojs-contrib-media-sources/issues/events{/number}","events_url":"https://api.github.com/repos/videojs/videojs-contrib-media-sources/events","assignees_url":"https://api.github.com/repos/videojs/videojs-contrib-media-sources/assignees{/user}","branches_url":"https://api.github.com/repos/videojs/videojs-contrib-media-sources/branches{/branch}","tags_url":"https://api.github.com/repos/videojs/videojs-contrib-media-sources/tags","blobs_url":"https://api.github.com/repos/videojs/videojs-contrib-media-sources/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/videojs/videojs-contrib-media-sources/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/videojs/videojs-contrib-media-sources/git/refs{/sha}","trees_url":"https://api.github.com/repos/videojs/videojs-contrib-media-sources/git/trees{/sha}","statuses_url":"https://api.github.com/repos/videojs/videojs-contrib-media-sources/statuses/{sha}","languages_url":"https://api.github.com/repos/videojs/videojs-contrib-media-sources/languages","stargazers_url":"https://api.github.com/repos/videojs/videojs-contrib-media-sources/stargazers","contributors_url":"https://api.github.com/repos/videojs/videojs-contrib-media-sources/contributors","subscribers_url":"https://api.github.com/repos/videojs/videojs-contrib-media-sources/subscribers","subscription_url":"https://api.github.com/repos/videojs/videojs-contrib-media-sources/subscription","commits_url":"https://api.github.com/repos/videojs/videojs-contrib-media-sources/commits{/sha}","git_commits_url":"https://api.github.com/repos/videojs/videojs-contrib-media-sources/git/commits{/sha}","comments_url":"https://api.github.com/repos/videojs/videojs-contrib-media-sources/comments{/number}","issue_comment_url":"https://api.github.com/repos/videojs/videojs-contrib-media-sources/issues/comments{/number}","contents_url":"https://api.github.com/repos/videojs/videojs-contrib-media-sources/contents/{+path}","compare_url":"https://api.github.com/repos/videojs/videojs-contrib-media-sources/compare/{base}...{head}","merges_url":"https://api.github.com/repos/videojs/videojs-contrib-media-sources/merges","archive_url":"https://api.github.com/repos/videojs/videojs-contrib-media-sources/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/videojs/videojs-contrib-media-sources/downloads","issues_url":"https://api.github.com/repos/videojs/videojs-contrib-media-sources/issues{/number}","pulls_url":"https://api.github.com/repos/videojs/videojs-contrib-media-sources/pulls{/number}","milestones_url":"https://api.github.com/repos/videojs/videojs-contrib-media-sources/milestones{/number}","notifications_url":"https://api.github.com/repos/videojs/videojs-contrib-media-sources/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/videojs/videojs-contrib-media-sources/labels{/name}","releases_url":"https://api.github.com/repos/videojs/videojs-contrib-media-sources/releases{/id}","created_at":"2013-10-25T02:01:24Z","updated_at":"2016-01-16T00:51:51Z","pushed_at":"2016-01-18T22:27:14Z","git_url":"git://github.com/videojs/videojs-contrib-media-sources.git","ssh_url":"git@github.com:videojs/videojs-contrib-media-sources.git","clone_url":"https://github.com/videojs/videojs-contrib-media-sources.git","svn_url":"https://github.com/videojs/videojs-contrib-media-sources","homepage":null,"size":756,"stargazers_count":67,"watchers_count":67,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":65,"mirror_url":null,"open_issues_count":12,"forks":65,"open_issues":12,"watchers":67,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/videojs/videojs-contrib-media-sources/pulls/64"},"html":{"href":"https://github.com/videojs/videojs-contrib-media-sources/pull/64"},"issue":{"href":"https://api.github.com/repos/videojs/videojs-contrib-media-sources/issues/64"},"comments":{"href":"https://api.github.com/repos/videojs/videojs-contrib-media-sources/issues/64/comments"},"review_comments":{"href":"https://api.github.com/repos/videojs/videojs-contrib-media-sources/pulls/64/comments"},"review_comment":{"href":"https://api.github.com/repos/videojs/videojs-contrib-media-sources/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/videojs/videojs-contrib-media-sources/pulls/64/commits"},"statuses":{"href":"https://api.github.com/repos/videojs/videojs-contrib-media-sources/statuses/5411207acad8faf8a0a93f0695f7b9f02e1bc5f1"}}}}