{"action":"closed","issue":{"url":"https://api.github.com/repos/bluepill-rb/bluepill/issues/38","repository_url":"https://api.github.com/repos/bluepill-rb/bluepill","labels_url":"https://api.github.com/repos/bluepill-rb/bluepill/issues/38/labels{/name}","comments_url":"https://api.github.com/repos/bluepill-rb/bluepill/issues/38/comments","events_url":"https://api.github.com/repos/bluepill-rb/bluepill/issues/38/events","html_url":"https://github.com/bluepill-rb/bluepill/issues/38","id":107395740,"number":38,"title":"TypeError: No implicit conversion of false into Integer","user":{"login":"redox","id":29529,"avatar_url":"https://avatars.githubusercontent.com/u/29529?v=3","gravatar_id":"","url":"https://api.github.com/users/redox","html_url":"https://github.com/redox","followers_url":"https://api.github.com/users/redox/followers","following_url":"https://api.github.com/users/redox/following{/other_user}","gists_url":"https://api.github.com/users/redox/gists{/gist_id}","starred_url":"https://api.github.com/users/redox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redox/subscriptions","organizations_url":"https://api.github.com/users/redox/orgs","repos_url":"https://api.github.com/users/redox/repos","events_url":"https://api.github.com/users/redox/events{/privacy}","received_events_url":"https://api.github.com/users/redox/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-09-20T14:37:43Z","updated_at":"2016-06-19T13:27:28Z","closed_at":"2016-06-19T13:27:28Z","body":"I get the follow error when trying to start/quit a bluepill process that is not yet running yet.\r\n\r\n```\r\n /somewhere/shared/bundle/ruby/2.1.0/gems/bluepill-0.0.70/lib/bluepill/system.rb:23:in `kill' : no implicit conversion of false into Integer (TypeError)\r\n from /somewhere/shared/bundle/ruby/2.1.0/gems/bluepill-0.0.70/lib/bluepill/system.rb:23:in `pid_alive?'\r\n from /somewhere/shared/bundle/ruby/2.1.0/gems/bluepill-0.0.70/lib/bluepill/controller.rb:89:in `block in cleanup_bluepill_directory'\r\n from /somewhere/shared/bundle/ruby/2.1.0/gems/bluepill-0.0.70/lib/bluepill/controller.rb:87:in `each'\r\n from /somewhere/shared/bundle/ruby/2.1.0/gems/bluepill-0.0.70/lib/bluepill/controller.rb:87:in `cleanup_bluepill_directory'\r\n from /somewhere/shared/bundle/ruby/2.1.0/gems/bluepill-0.0.70/lib/bluepill/controller.rb:15:in `initialize'\r\n from /somewhere/shared/bundle/ruby/2.1.0/gems/bluepill-0.0.70/bin/bluepill:77:in `new'\r\n from /somewhere/shared/bundle/ruby/2.1.0/gems/bluepill-0.0.70/bin/bluepill:77:in `<top (required)>'\r\n from /somewhere/shared/bundle/ruby/2.1.0/bin/bluepill:23:in `load'\r\n from /somewhere/shared/bundle/ruby/2.1.0/bin/bluepill:23:in `<main>'\r\n```\r\n\r\nReading the code, I assume the following test `next if pid || System.pid_alive?(pid)` (https://github.com/bluepill-rb/bluepill/blob/master/lib/bluepill/controller.rb#L89) should rather use `&&` then `||`, right? -> otherwise we're potentially calling `pid_alive?` with `false` :/\r\n\r\n(Using bluepill 0.70 & ruby 2.1)"}}
{"actor":{"display_login":"akzhan"}}