{"action":"created","comment":{"url":"https://api.github.com/repos/Tribler/dispersy/pulls/comments/67333754","id":67333754,"diff_hunk":"@@ -99,15 +102,17 @@ def dispersy_enable_candidate_walker_responses(self):\n                               destination)\n \n             # node receives missing identity\n-            _, message = node.receive_message(names=[u\"dispersy-missing-identity\"]).next()\n+            # TODO(Laurens): can you call a .next on this?\n+            received_messsage = yield node.receive_message(names=[u\"dispersy-missing-identity\"])\n+            _, message = received_messsage.next()\n             self.assertEqual(message.payload.mid, node.my_member.mid)\n \n-            packet = node.fetch_packets([u\"dispersy-identity\", ], node.my_member.mid)[0]\n-            node.send_packet(packet, destination)\n+            packet = yield node.fetch_packets([u\"dispersy-identity\", ], node.my_member.mid)[0]","path":"tests/test_bootstrap.py","position":53,"original_position":53,"commit_id":"086eb632a10dba6606dcae9099d7cac092e72e4a","original_commit_id":"086eb632a10dba6606dcae9099d7cac092e72e4a","user":{"login":"lfdversluis","id":3618917,"avatar_url":"https://avatars.githubusercontent.com/u/3618917?v=3","gravatar_id":"","url":"https://api.github.com/users/lfdversluis","html_url":"https://github.com/lfdversluis","followers_url":"https://api.github.com/users/lfdversluis/followers","following_url":"https://api.github.com/users/lfdversluis/following{/other_user}","gists_url":"https://api.github.com/users/lfdversluis/gists{/gist_id}","starred_url":"https://api.github.com/users/lfdversluis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lfdversluis/subscriptions","organizations_url":"https://api.github.com/users/lfdversluis/orgs","repos_url":"https://api.github.com/users/lfdversluis/repos","events_url":"https://api.github.com/users/lfdversluis/events{/privacy}","received_events_url":"https://api.github.com/users/lfdversluis/received_events","type":"User","site_admin":false},"body":"Cannot call [0] on this yet.","created_at":"2016-06-16T12:18:09Z","updated_at":"2016-06-16T12:18:09Z","html_url":"https://github.com/Tribler/dispersy/pull/481#discussion_r67333754","pull_request_url":"https://api.github.com/repos/Tribler/dispersy/pulls/481","_links":{"self":{"href":"https://api.github.com/repos/Tribler/dispersy/pulls/comments/67333754"},"html":{"href":"https://github.com/Tribler/dispersy/pull/481#discussion_r67333754"},"pull_request":{"href":"https://api.github.com/repos/Tribler/dispersy/pulls/481"}}},"pull_request":{"url":"https://api.github.com/repos/Tribler/dispersy/pulls/481","id":71367401,"html_url":"https://github.com/Tribler/dispersy/pull/481","diff_url":"https://github.com/Tribler/dispersy/pull/481.diff","patch_url":"https://github.com/Tribler/dispersy/pull/481.patch","issue_url":"https://api.github.com/repos/Tribler/dispersy/issues/481","number":481,"state":"open","locked":false,"title":"WIP: Storm db manager","user":{"login":"lfdversluis","id":3618917,"avatar_url":"https://avatars.githubusercontent.com/u/3618917?v=3","gravatar_id":"","url":"https://api.github.com/users/lfdversluis","html_url":"https://github.com/lfdversluis","followers_url":"https://api.github.com/users/lfdversluis/followers","following_url":"https://api.github.com/users/lfdversluis/following{/other_user}","gists_url":"https://api.github.com/users/lfdversluis/gists{/gist_id}","starred_url":"https://api.github.com/users/lfdversluis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lfdversluis/subscriptions","organizations_url":"https://api.github.com/users/lfdversluis/orgs","repos_url":"https://api.github.com/users/lfdversluis/repos","events_url":"https://api.github.com/users/lfdversluis/events{/privacy}","received_events_url":"https://api.github.com/users/lfdversluis/received_events","type":"User","site_admin":false},"body":"I open this PR so people can view the progress on this work and provide **feedback and or suggestions**.\r\n\r\nThis will become the database manager used in Tribler/Dispersy to do IO on a separate thread to gain performance.\r\n\r\nAdds the Storm DB manager (feature).\r\nAdds **9** tests\r\n\r\n# Refactoring progress:\r\n\r\n| File  | Uses Stormdb? (Synchronous and blocking)   | \r\n|---|---|\r\n| `dispersy.py` | √  |\r\n| `community.py` | √  |\r\n| `multichain DB` | x | \r\n| `DispersyDatabase` | √ | \r\n| `statistics.py` | √ | \r\n| `node.py` | √ | \r\n| `test_classification.py` | √ |\r\n| `test_sync.py` | √ |\r\n| `test_undo.py` | √ \r\n| `tracker/community.py` | √ |\r\n| `database.py` | √ |\r\n\r\n| Database function | Returning deferred ? | Running on threadpool ?\r\n|---|---|---|\r\n| `execute` | x | x |\r\n| `execute_many` | x | x |\r\n| `insert` | x | x |\r\n| `fetchone` | x | x |\r\n| `fetchall` | √ | x |\r\n| `executescript` | x | x |\r\n| `insert_many` | √ | x |\r\n| `delete` | x | x |\r\n| `count` | x | x |\r\n| `tracker/community.py` | x | x |","created_at":"2016-05-25T10:35:05Z","updated_at":"2016-06-16T12:18:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bea8680fc7ba4a362602789e04ed8911d0c5872a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Tribler/dispersy/pulls/481/commits","review_comments_url":"https://api.github.com/repos/Tribler/dispersy/pulls/481/comments","review_comment_url":"https://api.github.com/repos/Tribler/dispersy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Tribler/dispersy/issues/481/comments","statuses_url":"https://api.github.com/repos/Tribler/dispersy/statuses/086eb632a10dba6606dcae9099d7cac092e72e4a","head":{"label":"lfdversluis:storm-db-manager","ref":"storm-db-manager","sha":"086eb632a10dba6606dcae9099d7cac092e72e4a","user":{"login":"lfdversluis","id":3618917,"avatar_url":"https://avatars.githubusercontent.com/u/3618917?v=3","gravatar_id":"","url":"https://api.github.com/users/lfdversluis","html_url":"https://github.com/lfdversluis","followers_url":"https://api.github.com/users/lfdversluis/followers","following_url":"https://api.github.com/users/lfdversluis/following{/other_user}","gists_url":"https://api.github.com/users/lfdversluis/gists{/gist_id}","starred_url":"https://api.github.com/users/lfdversluis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lfdversluis/subscriptions","organizations_url":"https://api.github.com/users/lfdversluis/orgs","repos_url":"https://api.github.com/users/lfdversluis/repos","events_url":"https://api.github.com/users/lfdversluis/events{/privacy}","received_events_url":"https://api.github.com/users/lfdversluis/received_events","type":"User","site_admin":false},"repo":{"id":57133105,"name":"dispersy","full_name":"lfdversluis/dispersy","owner":{"login":"lfdversluis","id":3618917,"avatar_url":"https://avatars.githubusercontent.com/u/3618917?v=3","gravatar_id":"","url":"https://api.github.com/users/lfdversluis","html_url":"https://github.com/lfdversluis","followers_url":"https://api.github.com/users/lfdversluis/followers","following_url":"https://api.github.com/users/lfdversluis/following{/other_user}","gists_url":"https://api.github.com/users/lfdversluis/gists{/gist_id}","starred_url":"https://api.github.com/users/lfdversluis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lfdversluis/subscriptions","organizations_url":"https://api.github.com/users/lfdversluis/orgs","repos_url":"https://api.github.com/users/lfdversluis/repos","events_url":"https://api.github.com/users/lfdversluis/events{/privacy}","received_events_url":"https://api.github.com/users/lfdversluis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lfdversluis/dispersy","description":"The elastic database system. A database designed for P2P-like scenarios, where potentially millions of computers send database updates around.","fork":true,"url":"https://api.github.com/repos/lfdversluis/dispersy","forks_url":"https://api.github.com/repos/lfdversluis/dispersy/forks","keys_url":"https://api.github.com/repos/lfdversluis/dispersy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lfdversluis/dispersy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lfdversluis/dispersy/teams","hooks_url":"https://api.github.com/repos/lfdversluis/dispersy/hooks","issue_events_url":"https://api.github.com/repos/lfdversluis/dispersy/issues/events{/number}","events_url":"https://api.github.com/repos/lfdversluis/dispersy/events","assignees_url":"https://api.github.com/repos/lfdversluis/dispersy/assignees{/user}","branches_url":"https://api.github.com/repos/lfdversluis/dispersy/branches{/branch}","tags_url":"https://api.github.com/repos/lfdversluis/dispersy/tags","blobs_url":"https://api.github.com/repos/lfdversluis/dispersy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lfdversluis/dispersy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lfdversluis/dispersy/git/refs{/sha}","trees_url":"https://api.github.com/repos/lfdversluis/dispersy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lfdversluis/dispersy/statuses/{sha}","languages_url":"https://api.github.com/repos/lfdversluis/dispersy/languages","stargazers_url":"https://api.github.com/repos/lfdversluis/dispersy/stargazers","contributors_url":"https://api.github.com/repos/lfdversluis/dispersy/contributors","subscribers_url":"https://api.github.com/repos/lfdversluis/dispersy/subscribers","subscription_url":"https://api.github.com/repos/lfdversluis/dispersy/subscription","commits_url":"https://api.github.com/repos/lfdversluis/dispersy/commits{/sha}","git_commits_url":"https://api.github.com/repos/lfdversluis/dispersy/git/commits{/sha}","comments_url":"https://api.github.com/repos/lfdversluis/dispersy/comments{/number}","issue_comment_url":"https://api.github.com/repos/lfdversluis/dispersy/issues/comments{/number}","contents_url":"https://api.github.com/repos/lfdversluis/dispersy/contents/{+path}","compare_url":"https://api.github.com/repos/lfdversluis/dispersy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lfdversluis/dispersy/merges","archive_url":"https://api.github.com/repos/lfdversluis/dispersy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lfdversluis/dispersy/downloads","issues_url":"https://api.github.com/repos/lfdversluis/dispersy/issues{/number}","pulls_url":"https://api.github.com/repos/lfdversluis/dispersy/pulls{/number}","milestones_url":"https://api.github.com/repos/lfdversluis/dispersy/milestones{/number}","notifications_url":"https://api.github.com/repos/lfdversluis/dispersy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lfdversluis/dispersy/labels{/name}","releases_url":"https://api.github.com/repos/lfdversluis/dispersy/releases{/id}","deployments_url":"https://api.github.com/repos/lfdversluis/dispersy/deployments","created_at":"2016-04-26T14:03:23Z","updated_at":"2016-04-26T14:03:24Z","pushed_at":"2016-06-15T13:14:47Z","git_url":"git://github.com/lfdversluis/dispersy.git","ssh_url":"git@github.com:lfdversluis/dispersy.git","clone_url":"https://github.com/lfdversluis/dispersy.git","svn_url":"https://github.com/lfdversluis/dispersy","homepage":"http://www.tribler.org","size":7805,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"devel"}},"base":{"label":"Tribler:devel","ref":"devel","sha":"6c2026fd6d1b25544b677d81ca841a9ed4a3fd7e","user":{"login":"Tribler","id":2913489,"avatar_url":"https://avatars.githubusercontent.com/u/2913489?v=3","gravatar_id":"","url":"https://api.github.com/users/Tribler","html_url":"https://github.com/Tribler","followers_url":"https://api.github.com/users/Tribler/followers","following_url":"https://api.github.com/users/Tribler/following{/other_user}","gists_url":"https://api.github.com/users/Tribler/gists{/gist_id}","starred_url":"https://api.github.com/users/Tribler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tribler/subscriptions","organizations_url":"https://api.github.com/users/Tribler/orgs","repos_url":"https://api.github.com/users/Tribler/repos","events_url":"https://api.github.com/users/Tribler/events{/privacy}","received_events_url":"https://api.github.com/users/Tribler/received_events","type":"Organization","site_admin":false},"repo":{"id":8432681,"name":"dispersy","full_name":"Tribler/dispersy","owner":{"login":"Tribler","id":2913489,"avatar_url":"https://avatars.githubusercontent.com/u/2913489?v=3","gravatar_id":"","url":"https://api.github.com/users/Tribler","html_url":"https://github.com/Tribler","followers_url":"https://api.github.com/users/Tribler/followers","following_url":"https://api.github.com/users/Tribler/following{/other_user}","gists_url":"https://api.github.com/users/Tribler/gists{/gist_id}","starred_url":"https://api.github.com/users/Tribler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tribler/subscriptions","organizations_url":"https://api.github.com/users/Tribler/orgs","repos_url":"https://api.github.com/users/Tribler/repos","events_url":"https://api.github.com/users/Tribler/events{/privacy}","received_events_url":"https://api.github.com/users/Tribler/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Tribler/dispersy","description":"The elastic database system. A database designed for P2P-like scenarios, where potentially millions of computers send database updates around.","fork":false,"url":"https://api.github.com/repos/Tribler/dispersy","forks_url":"https://api.github.com/repos/Tribler/dispersy/forks","keys_url":"https://api.github.com/repos/Tribler/dispersy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Tribler/dispersy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Tribler/dispersy/teams","hooks_url":"https://api.github.com/repos/Tribler/dispersy/hooks","issue_events_url":"https://api.github.com/repos/Tribler/dispersy/issues/events{/number}","events_url":"https://api.github.com/repos/Tribler/dispersy/events","assignees_url":"https://api.github.com/repos/Tribler/dispersy/assignees{/user}","branches_url":"https://api.github.com/repos/Tribler/dispersy/branches{/branch}","tags_url":"https://api.github.com/repos/Tribler/dispersy/tags","blobs_url":"https://api.github.com/repos/Tribler/dispersy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Tribler/dispersy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Tribler/dispersy/git/refs{/sha}","trees_url":"https://api.github.com/repos/Tribler/dispersy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Tribler/dispersy/statuses/{sha}","languages_url":"https://api.github.com/repos/Tribler/dispersy/languages","stargazers_url":"https://api.github.com/repos/Tribler/dispersy/stargazers","contributors_url":"https://api.github.com/repos/Tribler/dispersy/contributors","subscribers_url":"https://api.github.com/repos/Tribler/dispersy/subscribers","subscription_url":"https://api.github.com/repos/Tribler/dispersy/subscription","commits_url":"https://api.github.com/repos/Tribler/dispersy/commits{/sha}","git_commits_url":"https://api.github.com/repos/Tribler/dispersy/git/commits{/sha}","comments_url":"https://api.github.com/repos/Tribler/dispersy/comments{/number}","issue_comment_url":"https://api.github.com/repos/Tribler/dispersy/issues/comments{/number}","contents_url":"https://api.github.com/repos/Tribler/dispersy/contents/{+path}","compare_url":"https://api.github.com/repos/Tribler/dispersy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Tribler/dispersy/merges","archive_url":"https://api.github.com/repos/Tribler/dispersy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Tribler/dispersy/downloads","issues_url":"https://api.github.com/repos/Tribler/dispersy/issues{/number}","pulls_url":"https://api.github.com/repos/Tribler/dispersy/pulls{/number}","milestones_url":"https://api.github.com/repos/Tribler/dispersy/milestones{/number}","notifications_url":"https://api.github.com/repos/Tribler/dispersy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Tribler/dispersy/labels{/name}","releases_url":"https://api.github.com/repos/Tribler/dispersy/releases{/id}","deployments_url":"https://api.github.com/repos/Tribler/dispersy/deployments","created_at":"2013-02-26T13:10:21Z","updated_at":"2016-04-24T19:50:48Z","pushed_at":"2016-06-16T12:17:11Z","git_url":"git://github.com/Tribler/dispersy.git","ssh_url":"git@github.com:Tribler/dispersy.git","clone_url":"https://github.com/Tribler/dispersy.git","svn_url":"https://github.com/Tribler/dispersy","homepage":"http://www.tribler.org","size":8977,"stargazers_count":42,"watchers_count":42,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"open_issues_count":45,"forks":28,"open_issues":45,"watchers":42,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/Tribler/dispersy/pulls/481"},"html":{"href":"https://github.com/Tribler/dispersy/pull/481"},"issue":{"href":"https://api.github.com/repos/Tribler/dispersy/issues/481"},"comments":{"href":"https://api.github.com/repos/Tribler/dispersy/issues/481/comments"},"review_comments":{"href":"https://api.github.com/repos/Tribler/dispersy/pulls/481/comments"},"review_comment":{"href":"https://api.github.com/repos/Tribler/dispersy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Tribler/dispersy/pulls/481/commits"},"statuses":{"href":"https://api.github.com/repos/Tribler/dispersy/statuses/086eb632a10dba6606dcae9099d7cac092e72e4a"}}}}
{"actor":{"display_login":"lfdversluis"}}