{"action":"created","comment":{"url":"https://api.github.com/repos/angular/angular/pulls/comments/73449607","id":73449607,"diff_hunk":"@@ -9,12 +9,16 @@ import {XHR} from '@angular/compiler';\n import {Injectable} from '@angular/core';\n \n import {isPresent} from '../facade/lang';\n-import {PromiseCompleter} from '../facade/promise';\n \n @Injectable()\n export class XHRImpl extends XHR {\n   get(url: string): Promise<string> {\n-    var completer: PromiseCompleter<string> = new PromiseCompleter<any>();\n+    var resolve: (result: any) => void;\n+    var reject: (error: any) => void;\n+    var promise = new Promise((res, rej) => {","path":"modules/@angular/platform-browser-dynamic/src/xhr/xhr_impl.ts","position":null,"original_position":12,"commit_id":"628e3d03e7913d63e54c190ef883de12f92f8364","original_commit_id":"628e3d03e7913d63e54c190ef883de12f92f8364","user":{"login":"vicb","id":248818,"avatar_url":"https://avatars.githubusercontent.com/u/248818?v=3","gravatar_id":"","url":"https://api.github.com/users/vicb","html_url":"https://github.com/vicb","followers_url":"https://api.github.com/users/vicb/followers","following_url":"https://api.github.com/users/vicb/following{/other_user}","gists_url":"https://api.github.com/users/vicb/gists{/gist_id}","starred_url":"https://api.github.com/users/vicb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vicb/subscriptions","organizations_url":"https://api.github.com/users/vicb/orgs","repos_url":"https://api.github.com/users/vicb/repos","events_url":"https://api.github.com/users/vicb/events{/privacy}","received_events_url":"https://api.github.com/users/vicb/received_events","type":"User","site_admin":false},"body":"const","created_at":"2016-08-04T01:18:46Z","updated_at":"2016-08-04T01:18:46Z","html_url":"https://github.com/angular/angular/pull/10484#discussion_r73449607","pull_request_url":"https://api.github.com/repos/angular/angular/pulls/10484","_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/comments/73449607"},"html":{"href":"https://github.com/angular/angular/pull/10484#discussion_r73449607"},"pull_request":{"href":"https://api.github.com/repos/angular/angular/pulls/10484"}}},"pull_request":{"url":"https://api.github.com/repos/angular/angular/pulls/10484","id":79991745,"html_url":"https://github.com/angular/angular/pull/10484","diff_url":"https://github.com/angular/angular/pull/10484.diff","patch_url":"https://github.com/angular/angular/pull/10484.patch","issue_url":"https://api.github.com/repos/angular/angular/issues/10484","number":10484,"state":"open","locked":false,"title":"chore(facade): remove most facade/async functions","user":{"login":"jasonchoimtt","id":9285108,"avatar_url":"https://avatars.githubusercontent.com/u/9285108?v=3","gravatar_id":"","url":"https://api.github.com/users/jasonchoimtt","html_url":"https://github.com/jasonchoimtt","followers_url":"https://api.github.com/users/jasonchoimtt/followers","following_url":"https://api.github.com/users/jasonchoimtt/following{/other_user}","gists_url":"https://api.github.com/users/jasonchoimtt/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonchoimtt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonchoimtt/subscriptions","organizations_url":"https://api.github.com/users/jasonchoimtt/orgs","repos_url":"https://api.github.com/users/jasonchoimtt/repos","events_url":"https://api.github.com/users/jasonchoimtt/events{/privacy}","received_events_url":"https://api.github.com/users/jasonchoimtt/received_events","type":"User","site_admin":false},"body":"Mainly please review:\r\n- chore(facade): remove most facade/async functions\r\n- remove async uses in playground\r\n- remove async uses in benchpress\r\n- remove async uses in @angular\r\n- chore(facade): cleanup unnecessary steps in async\r\n\r\nWe should probably squash all above into 1-2 commits.\r\n\r\nBlocked by #10479\r\n\r\n**Please check if the PR fulfills these requirements**\r\n- The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit-message-format\r\n- Tests for the changes have been added (for bug fixes / features)\r\n- Docs have been added / updated (for bug fixes / features)\r\n\r\n\r\n**What kind of change does this PR introduce?** (check one with \"x\")\r\n```\r\nRefactoring (no functional changes, no api changes)\r\n```\r\n\r\n**Does this PR introduce a breaking change?** (check one with \"x\")\r\n```\r\nNo\r\n```","created_at":"2016-08-03T22:41:56Z","updated_at":"2016-08-04T01:18:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"38325ea4c2902252b5e9791ae51f6738673c5ac9","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/angular/angular/pulls/10484/commits","review_comments_url":"https://api.github.com/repos/angular/angular/pulls/10484/comments","review_comment_url":"https://api.github.com/repos/angular/angular/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/angular/issues/10484/comments","statuses_url":"https://api.github.com/repos/angular/angular/statuses/628e3d03e7913d63e54c190ef883de12f92f8364","head":{"label":"jasonchoimtt:remove_facade_b2","ref":"remove_facade_b2","sha":"628e3d03e7913d63e54c190ef883de12f92f8364","user":{"login":"jasonchoimtt","id":9285108,"avatar_url":"https://avatars.githubusercontent.com/u/9285108?v=3","gravatar_id":"","url":"https://api.github.com/users/jasonchoimtt","html_url":"https://github.com/jasonchoimtt","followers_url":"https://api.github.com/users/jasonchoimtt/followers","following_url":"https://api.github.com/users/jasonchoimtt/following{/other_user}","gists_url":"https://api.github.com/users/jasonchoimtt/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonchoimtt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonchoimtt/subscriptions","organizations_url":"https://api.github.com/users/jasonchoimtt/orgs","repos_url":"https://api.github.com/users/jasonchoimtt/repos","events_url":"https://api.github.com/users/jasonchoimtt/events{/privacy}","received_events_url":"https://api.github.com/users/jasonchoimtt/received_events","type":"User","site_admin":false},"repo":{"id":61740843,"name":"angular","full_name":"jasonchoimtt/angular","owner":{"login":"jasonchoimtt","id":9285108,"avatar_url":"https://avatars.githubusercontent.com/u/9285108?v=3","gravatar_id":"","url":"https://api.github.com/users/jasonchoimtt","html_url":"https://github.com/jasonchoimtt","followers_url":"https://api.github.com/users/jasonchoimtt/followers","following_url":"https://api.github.com/users/jasonchoimtt/following{/other_user}","gists_url":"https://api.github.com/users/jasonchoimtt/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonchoimtt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonchoimtt/subscriptions","organizations_url":"https://api.github.com/users/jasonchoimtt/orgs","repos_url":"https://api.github.com/users/jasonchoimtt/repos","events_url":"https://api.github.com/users/jasonchoimtt/events{/privacy}","received_events_url":"https://api.github.com/users/jasonchoimtt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jasonchoimtt/angular","description":"","fork":true,"url":"https://api.github.com/repos/jasonchoimtt/angular","forks_url":"https://api.github.com/repos/jasonchoimtt/angular/forks","keys_url":"https://api.github.com/repos/jasonchoimtt/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jasonchoimtt/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jasonchoimtt/angular/teams","hooks_url":"https://api.github.com/repos/jasonchoimtt/angular/hooks","issue_events_url":"https://api.github.com/repos/jasonchoimtt/angular/issues/events{/number}","events_url":"https://api.github.com/repos/jasonchoimtt/angular/events","assignees_url":"https://api.github.com/repos/jasonchoimtt/angular/assignees{/user}","branches_url":"https://api.github.com/repos/jasonchoimtt/angular/branches{/branch}","tags_url":"https://api.github.com/repos/jasonchoimtt/angular/tags","blobs_url":"https://api.github.com/repos/jasonchoimtt/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jasonchoimtt/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jasonchoimtt/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/jasonchoimtt/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jasonchoimtt/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/jasonchoimtt/angular/languages","stargazers_url":"https://api.github.com/repos/jasonchoimtt/angular/stargazers","contributors_url":"https://api.github.com/repos/jasonchoimtt/angular/contributors","subscribers_url":"https://api.github.com/repos/jasonchoimtt/angular/subscribers","subscription_url":"https://api.github.com/repos/jasonchoimtt/angular/subscription","commits_url":"https://api.github.com/repos/jasonchoimtt/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/jasonchoimtt/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/jasonchoimtt/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/jasonchoimtt/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/jasonchoimtt/angular/contents/{+path}","compare_url":"https://api.github.com/repos/jasonchoimtt/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jasonchoimtt/angular/merges","archive_url":"https://api.github.com/repos/jasonchoimtt/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jasonchoimtt/angular/downloads","issues_url":"https://api.github.com/repos/jasonchoimtt/angular/issues{/number}","pulls_url":"https://api.github.com/repos/jasonchoimtt/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/jasonchoimtt/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/jasonchoimtt/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jasonchoimtt/angular/labels{/name}","releases_url":"https://api.github.com/repos/jasonchoimtt/angular/releases{/id}","deployments_url":"https://api.github.com/repos/jasonchoimtt/angular/deployments","created_at":"2016-06-22T18:08:24Z","updated_at":"2016-06-22T18:08:44Z","pushed_at":"2016-08-04T01:01:30Z","git_url":"git://github.com/jasonchoimtt/angular.git","ssh_url":"git@github.com:jasonchoimtt/angular.git","clone_url":"https://github.com/jasonchoimtt/angular.git","svn_url":"https://github.com/jasonchoimtt/angular","homepage":"https://angular.io","size":401900,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"6195a45ae2b1a187527a10c0b2982220c40148ba","user":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":24195339,"name":"angular","full_name":"angular/angular","owner":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/angular","description":"","fork":false,"url":"https://api.github.com/repos/angular/angular","forks_url":"https://api.github.com/repos/angular/angular/forks","keys_url":"https://api.github.com/repos/angular/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/angular/teams","hooks_url":"https://api.github.com/repos/angular/angular/hooks","issue_events_url":"https://api.github.com/repos/angular/angular/issues/events{/number}","events_url":"https://api.github.com/repos/angular/angular/events","assignees_url":"https://api.github.com/repos/angular/angular/assignees{/user}","branches_url":"https://api.github.com/repos/angular/angular/branches{/branch}","tags_url":"https://api.github.com/repos/angular/angular/tags","blobs_url":"https://api.github.com/repos/angular/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/angular/languages","stargazers_url":"https://api.github.com/repos/angular/angular/stargazers","contributors_url":"https://api.github.com/repos/angular/angular/contributors","subscribers_url":"https://api.github.com/repos/angular/angular/subscribers","subscription_url":"https://api.github.com/repos/angular/angular/subscription","commits_url":"https://api.github.com/repos/angular/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/angular/contents/{+path}","compare_url":"https://api.github.com/repos/angular/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/angular/merges","archive_url":"https://api.github.com/repos/angular/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/angular/downloads","issues_url":"https://api.github.com/repos/angular/angular/issues{/number}","pulls_url":"https://api.github.com/repos/angular/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/angular/labels{/name}","releases_url":"https://api.github.com/repos/angular/angular/releases{/id}","deployments_url":"https://api.github.com/repos/angular/angular/deployments","created_at":"2014-09-18T16:12:01Z","updated_at":"2016-08-04T00:59:06Z","pushed_at":"2016-08-04T01:10:00Z","git_url":"git://github.com/angular/angular.git","ssh_url":"git@github.com:angular/angular.git","clone_url":"https://github.com/angular/angular.git","svn_url":"https://github.com/angular/angular","homepage":"https://angular.io","size":642793,"stargazers_count":14514,"watchers_count":14514,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3726,"mirror_url":null,"open_issues_count":1198,"forks":3726,"open_issues":1198,"watchers":14514,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/10484"},"html":{"href":"https://github.com/angular/angular/pull/10484"},"issue":{"href":"https://api.github.com/repos/angular/angular/issues/10484"},"comments":{"href":"https://api.github.com/repos/angular/angular/issues/10484/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/angular/pulls/10484/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/angular/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/angular/pulls/10484/commits"},"statuses":{"href":"https://api.github.com/repos/angular/angular/statuses/628e3d03e7913d63e54c190ef883de12f92f8364"}}}}
{"actor":{"display_login":"vicb"}}