{"action":"created","comment":{"url":"https://api.github.com/repos/fantasyland/fantasy-land/pulls/comments/62430174","id":62430174,"diff_hunk":"@@ -394,10 +396,71 @@ The `extract` method takes no arguments:\n     1. `v` must have the same type that `f` returns in `extend`.\n \n \n+### Bifunctor\n \n+A value that implements the Bifunctor specification must also implement\n+the Functor specification.\n \n+A value which satisfies the specification of a Bifunctor does not need to\n+implement:\n+\n+* Functor's `map`; derivable as `f => this.bimap(a => a, f)`\n+\n+1. `p.bimap(a => a, b => b)` is equivalent to `p` (identity)\n+2. `p.bimap(a => f(g(a)), b => h(i(b))` is equivalent to `p.bimap(g, i).bimap(f, h)` (composition)\n+\n+#### `bimap` method\n+\n+A value which has a Bifunctor must provide an `bimap` method. The `bimap`\n+method takes two arguments:\n+\n+    c.bimap(f, g)\n+\n+1. `f` must be a function which returns a value\n+\n+    1. If `f` is not a function, the behaviour of `bimap` is unspecified.\n+    2. `f` can return any value.\n+\n+2. `g` must be a function which returns a value\n+\n+    1. If `g` is not a function, the behaviour of `bimap` is unspecified.\n+    2. `g` can return any value.\n+\n+3. `bimap` must return a value of the same Bifunctor.\n+\n+\n+### Profunctor\n+\n+A value that implements the Profunctor specification must also implement\n+the Functor specification.\n+\n+A value which satisfies the specification of a Profunctor does not need to\n+implement:\n+\n+* Functor's `map`; derivable as `f => this.promap(a => a, f)`","path":"README.md","position":54,"original_position":54,"commit_id":"cf17c9bbbc9ac66dbf2658e8182d64ba2e44f984","original_commit_id":"cf17c9bbbc9ac66dbf2658e8182d64ba2e44f984","user":{"login":"rpominov","id":825702,"avatar_url":"https://avatars.githubusercontent.com/u/825702?v=3","gravatar_id":"","url":"https://api.github.com/users/rpominov","html_url":"https://github.com/rpominov","followers_url":"https://api.github.com/users/rpominov/followers","following_url":"https://api.github.com/users/rpominov/following{/other_user}","gists_url":"https://api.github.com/users/rpominov/gists{/gist_id}","starred_url":"https://api.github.com/users/rpominov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpominov/subscriptions","organizations_url":"https://api.github.com/users/rpominov/orgs","repos_url":"https://api.github.com/users/rpominov/repos","events_url":"https://api.github.com/users/rpominov/events{/privacy}","received_events_url":"https://api.github.com/users/rpominov/received_events","type":"User","site_admin":false},"body":"`this` works differently in arrow functions, we need to use `function` here.\r\n\r\nOtherwise everything looks good to me now.","created_at":"2016-05-08T10:55:24Z","updated_at":"2016-05-08T10:55:24Z","html_url":"https://github.com/fantasyland/fantasy-land/pull/137#discussion_r62430174","pull_request_url":"https://api.github.com/repos/fantasyland/fantasy-land/pulls/137","_links":{"self":{"href":"https://api.github.com/repos/fantasyland/fantasy-land/pulls/comments/62430174"},"html":{"href":"https://github.com/fantasyland/fantasy-land/pull/137#discussion_r62430174"},"pull_request":{"href":"https://api.github.com/repos/fantasyland/fantasy-land/pulls/137"}}},"pull_request":{"url":"https://api.github.com/repos/fantasyland/fantasy-land/pulls/137","id":69240131,"html_url":"https://github.com/fantasyland/fantasy-land/pull/137","diff_url":"https://github.com/fantasyland/fantasy-land/pull/137.diff","patch_url":"https://github.com/fantasyland/fantasy-land/pull/137.patch","issue_url":"https://api.github.com/repos/fantasyland/fantasy-land/issues/137","number":137,"state":"open","locked":false,"title":"Profunctor and bifunctor specification","user":{"login":"scott-christopher","id":8951601,"avatar_url":"https://avatars.githubusercontent.com/u/8951601?v=3","gravatar_id":"","url":"https://api.github.com/users/scott-christopher","html_url":"https://github.com/scott-christopher","followers_url":"https://api.github.com/users/scott-christopher/followers","following_url":"https://api.github.com/users/scott-christopher/following{/other_user}","gists_url":"https://api.github.com/users/scott-christopher/gists{/gist_id}","starred_url":"https://api.github.com/users/scott-christopher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scott-christopher/subscriptions","organizations_url":"https://api.github.com/users/scott-christopher/orgs","repos_url":"https://api.github.com/users/scott-christopher/repos","events_url":"https://api.github.com/users/scott-christopher/events{/privacy}","received_events_url":"https://api.github.com/users/scott-christopher/received_events","type":"User","site_admin":false},"body":"A slight variation of the profunctor and bifunctor specs raised in #124, removing the mention of `lmap` and renaming `dimap` to `promap`.\r\n","created_at":"2016-05-07T11:19:23Z","updated_at":"2016-05-08T10:55:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"efcbe201ef0e3f057127e5e78ba51dbf90325769","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/fantasyland/fantasy-land/pulls/137/commits","review_comments_url":"https://api.github.com/repos/fantasyland/fantasy-land/pulls/137/comments","review_comment_url":"https://api.github.com/repos/fantasyland/fantasy-land/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fantasyland/fantasy-land/issues/137/comments","statuses_url":"https://api.github.com/repos/fantasyland/fantasy-land/statuses/cf17c9bbbc9ac66dbf2658e8182d64ba2e44f984","head":{"label":"scott-christopher:profunctor-bifunctor","ref":"profunctor-bifunctor","sha":"cf17c9bbbc9ac66dbf2658e8182d64ba2e44f984","user":{"login":"scott-christopher","id":8951601,"avatar_url":"https://avatars.githubusercontent.com/u/8951601?v=3","gravatar_id":"","url":"https://api.github.com/users/scott-christopher","html_url":"https://github.com/scott-christopher","followers_url":"https://api.github.com/users/scott-christopher/followers","following_url":"https://api.github.com/users/scott-christopher/following{/other_user}","gists_url":"https://api.github.com/users/scott-christopher/gists{/gist_id}","starred_url":"https://api.github.com/users/scott-christopher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scott-christopher/subscriptions","organizations_url":"https://api.github.com/users/scott-christopher/orgs","repos_url":"https://api.github.com/users/scott-christopher/repos","events_url":"https://api.github.com/users/scott-christopher/events{/privacy}","received_events_url":"https://api.github.com/users/scott-christopher/received_events","type":"User","site_admin":false},"repo":{"id":36202759,"name":"fantasy-land","full_name":"scott-christopher/fantasy-land","owner":{"login":"scott-christopher","id":8951601,"avatar_url":"https://avatars.githubusercontent.com/u/8951601?v=3","gravatar_id":"","url":"https://api.github.com/users/scott-christopher","html_url":"https://github.com/scott-christopher","followers_url":"https://api.github.com/users/scott-christopher/followers","following_url":"https://api.github.com/users/scott-christopher/following{/other_user}","gists_url":"https://api.github.com/users/scott-christopher/gists{/gist_id}","starred_url":"https://api.github.com/users/scott-christopher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scott-christopher/subscriptions","organizations_url":"https://api.github.com/users/scott-christopher/orgs","repos_url":"https://api.github.com/users/scott-christopher/repos","events_url":"https://api.github.com/users/scott-christopher/events{/privacy}","received_events_url":"https://api.github.com/users/scott-christopher/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/scott-christopher/fantasy-land","description":"Specification for interoperability of common algebraic structures in JavaScript","fork":true,"url":"https://api.github.com/repos/scott-christopher/fantasy-land","forks_url":"https://api.github.com/repos/scott-christopher/fantasy-land/forks","keys_url":"https://api.github.com/repos/scott-christopher/fantasy-land/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scott-christopher/fantasy-land/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scott-christopher/fantasy-land/teams","hooks_url":"https://api.github.com/repos/scott-christopher/fantasy-land/hooks","issue_events_url":"https://api.github.com/repos/scott-christopher/fantasy-land/issues/events{/number}","events_url":"https://api.github.com/repos/scott-christopher/fantasy-land/events","assignees_url":"https://api.github.com/repos/scott-christopher/fantasy-land/assignees{/user}","branches_url":"https://api.github.com/repos/scott-christopher/fantasy-land/branches{/branch}","tags_url":"https://api.github.com/repos/scott-christopher/fantasy-land/tags","blobs_url":"https://api.github.com/repos/scott-christopher/fantasy-land/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scott-christopher/fantasy-land/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scott-christopher/fantasy-land/git/refs{/sha}","trees_url":"https://api.github.com/repos/scott-christopher/fantasy-land/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scott-christopher/fantasy-land/statuses/{sha}","languages_url":"https://api.github.com/repos/scott-christopher/fantasy-land/languages","stargazers_url":"https://api.github.com/repos/scott-christopher/fantasy-land/stargazers","contributors_url":"https://api.github.com/repos/scott-christopher/fantasy-land/contributors","subscribers_url":"https://api.github.com/repos/scott-christopher/fantasy-land/subscribers","subscription_url":"https://api.github.com/repos/scott-christopher/fantasy-land/subscription","commits_url":"https://api.github.com/repos/scott-christopher/fantasy-land/commits{/sha}","git_commits_url":"https://api.github.com/repos/scott-christopher/fantasy-land/git/commits{/sha}","comments_url":"https://api.github.com/repos/scott-christopher/fantasy-land/comments{/number}","issue_comment_url":"https://api.github.com/repos/scott-christopher/fantasy-land/issues/comments{/number}","contents_url":"https://api.github.com/repos/scott-christopher/fantasy-land/contents/{+path}","compare_url":"https://api.github.com/repos/scott-christopher/fantasy-land/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scott-christopher/fantasy-land/merges","archive_url":"https://api.github.com/repos/scott-christopher/fantasy-land/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scott-christopher/fantasy-land/downloads","issues_url":"https://api.github.com/repos/scott-christopher/fantasy-land/issues{/number}","pulls_url":"https://api.github.com/repos/scott-christopher/fantasy-land/pulls{/number}","milestones_url":"https://api.github.com/repos/scott-christopher/fantasy-land/milestones{/number}","notifications_url":"https://api.github.com/repos/scott-christopher/fantasy-land/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scott-christopher/fantasy-land/labels{/name}","releases_url":"https://api.github.com/repos/scott-christopher/fantasy-land/releases{/id}","deployments_url":"https://api.github.com/repos/scott-christopher/fantasy-land/deployments","created_at":"2015-05-25T01:24:07Z","updated_at":"2015-05-25T01:24:09Z","pushed_at":"2016-05-07T22:28:54Z","git_url":"git://github.com/scott-christopher/fantasy-land.git","ssh_url":"git@github.com:scott-christopher/fantasy-land.git","clone_url":"https://github.com/scott-christopher/fantasy-land.git","svn_url":"https://github.com/scott-christopher/fantasy-land","homepage":null,"size":147,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fantasyland:master","ref":"master","sha":"97bb7089ace6eb114d587d2dfbfd84094fe39128","user":{"login":"fantasyland","id":5853271,"avatar_url":"https://avatars.githubusercontent.com/u/5853271?v=3","gravatar_id":"","url":"https://api.github.com/users/fantasyland","html_url":"https://github.com/fantasyland","followers_url":"https://api.github.com/users/fantasyland/followers","following_url":"https://api.github.com/users/fantasyland/following{/other_user}","gists_url":"https://api.github.com/users/fantasyland/gists{/gist_id}","starred_url":"https://api.github.com/users/fantasyland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fantasyland/subscriptions","organizations_url":"https://api.github.com/users/fantasyland/orgs","repos_url":"https://api.github.com/users/fantasyland/repos","events_url":"https://api.github.com/users/fantasyland/events{/privacy}","received_events_url":"https://api.github.com/users/fantasyland/received_events","type":"Organization","site_admin":false},"repo":{"id":9385519,"name":"fantasy-land","full_name":"fantasyland/fantasy-land","owner":{"login":"fantasyland","id":5853271,"avatar_url":"https://avatars.githubusercontent.com/u/5853271?v=3","gravatar_id":"","url":"https://api.github.com/users/fantasyland","html_url":"https://github.com/fantasyland","followers_url":"https://api.github.com/users/fantasyland/followers","following_url":"https://api.github.com/users/fantasyland/following{/other_user}","gists_url":"https://api.github.com/users/fantasyland/gists{/gist_id}","starred_url":"https://api.github.com/users/fantasyland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fantasyland/subscriptions","organizations_url":"https://api.github.com/users/fantasyland/orgs","repos_url":"https://api.github.com/users/fantasyland/repos","events_url":"https://api.github.com/users/fantasyland/events{/privacy}","received_events_url":"https://api.github.com/users/fantasyland/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fantasyland/fantasy-land","description":"Specification for interoperability of common algebraic structures in JavaScript","fork":false,"url":"https://api.github.com/repos/fantasyland/fantasy-land","forks_url":"https://api.github.com/repos/fantasyland/fantasy-land/forks","keys_url":"https://api.github.com/repos/fantasyland/fantasy-land/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fantasyland/fantasy-land/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fantasyland/fantasy-land/teams","hooks_url":"https://api.github.com/repos/fantasyland/fantasy-land/hooks","issue_events_url":"https://api.github.com/repos/fantasyland/fantasy-land/issues/events{/number}","events_url":"https://api.github.com/repos/fantasyland/fantasy-land/events","assignees_url":"https://api.github.com/repos/fantasyland/fantasy-land/assignees{/user}","branches_url":"https://api.github.com/repos/fantasyland/fantasy-land/branches{/branch}","tags_url":"https://api.github.com/repos/fantasyland/fantasy-land/tags","blobs_url":"https://api.github.com/repos/fantasyland/fantasy-land/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fantasyland/fantasy-land/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fantasyland/fantasy-land/git/refs{/sha}","trees_url":"https://api.github.com/repos/fantasyland/fantasy-land/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fantasyland/fantasy-land/statuses/{sha}","languages_url":"https://api.github.com/repos/fantasyland/fantasy-land/languages","stargazers_url":"https://api.github.com/repos/fantasyland/fantasy-land/stargazers","contributors_url":"https://api.github.com/repos/fantasyland/fantasy-land/contributors","subscribers_url":"https://api.github.com/repos/fantasyland/fantasy-land/subscribers","subscription_url":"https://api.github.com/repos/fantasyland/fantasy-land/subscription","commits_url":"https://api.github.com/repos/fantasyland/fantasy-land/commits{/sha}","git_commits_url":"https://api.github.com/repos/fantasyland/fantasy-land/git/commits{/sha}","comments_url":"https://api.github.com/repos/fantasyland/fantasy-land/comments{/number}","issue_comment_url":"https://api.github.com/repos/fantasyland/fantasy-land/issues/comments{/number}","contents_url":"https://api.github.com/repos/fantasyland/fantasy-land/contents/{+path}","compare_url":"https://api.github.com/repos/fantasyland/fantasy-land/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fantasyland/fantasy-land/merges","archive_url":"https://api.github.com/repos/fantasyland/fantasy-land/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fantasyland/fantasy-land/downloads","issues_url":"https://api.github.com/repos/fantasyland/fantasy-land/issues{/number}","pulls_url":"https://api.github.com/repos/fantasyland/fantasy-land/pulls{/number}","milestones_url":"https://api.github.com/repos/fantasyland/fantasy-land/milestones{/number}","notifications_url":"https://api.github.com/repos/fantasyland/fantasy-land/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fantasyland/fantasy-land/labels{/name}","releases_url":"https://api.github.com/repos/fantasyland/fantasy-land/releases{/id}","deployments_url":"https://api.github.com/repos/fantasyland/fantasy-land/deployments","created_at":"2013-04-12T03:10:22Z","updated_at":"2016-05-08T06:43:56Z","pushed_at":"2016-05-07T22:28:54Z","git_url":"git://github.com/fantasyland/fantasy-land.git","ssh_url":"git@github.com:fantasyland/fantasy-land.git","clone_url":"https://github.com/fantasyland/fantasy-land.git","svn_url":"https://github.com/fantasyland/fantasy-land","homepage":null,"size":203,"stargazers_count":1601,"watchers_count":1601,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":75,"mirror_url":null,"open_issues_count":23,"forks":75,"open_issues":23,"watchers":1601,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fantasyland/fantasy-land/pulls/137"},"html":{"href":"https://github.com/fantasyland/fantasy-land/pull/137"},"issue":{"href":"https://api.github.com/repos/fantasyland/fantasy-land/issues/137"},"comments":{"href":"https://api.github.com/repos/fantasyland/fantasy-land/issues/137/comments"},"review_comments":{"href":"https://api.github.com/repos/fantasyland/fantasy-land/pulls/137/comments"},"review_comment":{"href":"https://api.github.com/repos/fantasyland/fantasy-land/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fantasyland/fantasy-land/pulls/137/commits"},"statuses":{"href":"https://api.github.com/repos/fantasyland/fantasy-land/statuses/cf17c9bbbc9ac66dbf2658e8182d64ba2e44f984"}}}}