{"action":"created","comment":{"url":"https://api.github.com/repos/kite-project/hope/pulls/comments/49746096","id":49746096,"diff_hunk":"@@ -27,6 +27,13 @@ fxosComponent.register('hope-tab-list', {\n \n     // Events\n     scheduler.attachDirect(this.els.inner, 'scroll', this.onScroll);\n+    this.els.inner.addEventListener('scrollend', (evt) => {\n+      // We detach the direct block to flush the scheduler queue then re-attach it\n+      scheduler.detachDirect(this.els.inner, 'scroll', this.onScroll);\n+      setTimeout(() => {\n+        scheduler.attachDirect(this.els.inner, 'scroll', this.onScroll);\n+      });\n+    });","path":"lib/hope-tab-list.js","position":10,"original_position":10,"commit_id":"46105151c63464fc3156da1cb681fa4044ba5055","original_commit_id":"46105151c63464fc3156da1cb681fa4044ba5055","user":{"login":"etiennesegonzac","id":105194,"avatar_url":"https://avatars.githubusercontent.com/u/105194?v=3","gravatar_id":"","url":"https://api.github.com/users/etiennesegonzac","html_url":"https://github.com/etiennesegonzac","followers_url":"https://api.github.com/users/etiennesegonzac/followers","following_url":"https://api.github.com/users/etiennesegonzac/following{/other_user}","gists_url":"https://api.github.com/users/etiennesegonzac/gists{/gist_id}","starred_url":"https://api.github.com/users/etiennesegonzac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etiennesegonzac/subscriptions","organizations_url":"https://api.github.com/users/etiennesegonzac/orgs","repos_url":"https://api.github.com/users/etiennesegonzac/repos","events_url":"https://api.github.com/users/etiennesegonzac/events{/privacy}","received_events_url":"https://api.github.com/users/etiennesegonzac/received_events","type":"User","site_admin":false},"body":"I'm going back and forth on this one.\r\n\r\nBasically the scheduler protects interaction with a \"timeout window\". If we don't get a new event for 350ms we stop protecting and flush.\r\nBut if the direct block is detached we flush right away.\r\nThis works very well for cases where you attach a direct block on touchmove when the touchstart comes in, and detach it when the touchend comes.\r\n\r\nI'm trying to reproduce the same but it's a bit awkward because we don't have a scrollstart event.","created_at":"2016-01-14T16:14:54Z","updated_at":"2016-01-14T16:14:54Z","html_url":"https://github.com/kite-project/hope/pull/28#discussion_r49746096","pull_request_url":"https://api.github.com/repos/kite-project/hope/pulls/28","_links":{"self":{"href":"https://api.github.com/repos/kite-project/hope/pulls/comments/49746096"},"html":{"href":"https://github.com/kite-project/hope/pull/28#discussion_r49746096"},"pull_request":{"href":"https://api.github.com/repos/kite-project/hope/pulls/28"}}},"pull_request":{"url":"https://api.github.com/repos/kite-project/hope/pulls/28","id":55906685,"html_url":"https://github.com/kite-project/hope/pull/28","diff_url":"https://github.com/kite-project/hope/pull/28.diff","patch_url":"https://github.com/kite-project/hope/pull/28.patch","issue_url":"https://api.github.com/repos/kite-project/hope/issues/28","number":28,"state":"open","locked":false,"title":"WIP - Testing scrollend.","user":{"login":"etiennesegonzac","id":105194,"avatar_url":"https://avatars.githubusercontent.com/u/105194?v=3","gravatar_id":"","url":"https://api.github.com/users/etiennesegonzac","html_url":"https://github.com/etiennesegonzac","followers_url":"https://api.github.com/users/etiennesegonzac/followers","following_url":"https://api.github.com/users/etiennesegonzac/following{/other_user}","gists_url":"https://api.github.com/users/etiennesegonzac/gists{/gist_id}","starred_url":"https://api.github.com/users/etiennesegonzac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etiennesegonzac/subscriptions","organizations_url":"https://api.github.com/users/etiennesegonzac/orgs","repos_url":"https://api.github.com/users/etiennesegonzac/repos","events_url":"https://api.github.com/users/etiennesegonzac/events{/privacy}","received_events_url":"https://api.github.com/users/etiennesegonzac/received_events","type":"User","site_admin":false},"body":"Its pretty cool :) And would surely help with the URL bar!\r\n\r\nMaybe we need a way to detect the availability and shim it otherwise.\r\n\r\nJust opening the PR to get the conversation going.","created_at":"2016-01-13T14:51:44Z","updated_at":"2016-01-14T16:14:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"29cf838d6d17f797da6f7be90447e841eb6d0f04","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/kite-project/hope/pulls/28/commits","review_comments_url":"https://api.github.com/repos/kite-project/hope/pulls/28/comments","review_comment_url":"https://api.github.com/repos/kite-project/hope/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kite-project/hope/issues/28/comments","statuses_url":"https://api.github.com/repos/kite-project/hope/statuses/46105151c63464fc3156da1cb681fa4044ba5055","head":{"label":"kite-project:scrollend-test","ref":"scrollend-test","sha":"46105151c63464fc3156da1cb681fa4044ba5055","user":{"login":"kite-project","id":16602163,"avatar_url":"https://avatars.githubusercontent.com/u/16602163?v=3","gravatar_id":"","url":"https://api.github.com/users/kite-project","html_url":"https://github.com/kite-project","followers_url":"https://api.github.com/users/kite-project/followers","following_url":"https://api.github.com/users/kite-project/following{/other_user}","gists_url":"https://api.github.com/users/kite-project/gists{/gist_id}","starred_url":"https://api.github.com/users/kite-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kite-project/subscriptions","organizations_url":"https://api.github.com/users/kite-project/orgs","repos_url":"https://api.github.com/users/kite-project/repos","events_url":"https://api.github.com/users/kite-project/events{/privacy}","received_events_url":"https://api.github.com/users/kite-project/received_events","type":"Organization","site_admin":false},"repo":{"id":44190723,"name":"hope","full_name":"kite-project/hope","owner":{"login":"kite-project","id":16602163,"avatar_url":"https://avatars.githubusercontent.com/u/16602163?v=3","gravatar_id":"","url":"https://api.github.com/users/kite-project","html_url":"https://github.com/kite-project","followers_url":"https://api.github.com/users/kite-project/followers","following_url":"https://api.github.com/users/kite-project/following{/other_user}","gists_url":"https://api.github.com/users/kite-project/gists{/gist_id}","starred_url":"https://api.github.com/users/kite-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kite-project/subscriptions","organizations_url":"https://api.github.com/users/kite-project/orgs","repos_url":"https://api.github.com/users/kite-project/repos","events_url":"https://api.github.com/users/kite-project/events{/privacy}","received_events_url":"https://api.github.com/users/kite-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kite-project/hope","description":"A new web experience for your B2G and Android devices.","fork":false,"url":"https://api.github.com/repos/kite-project/hope","forks_url":"https://api.github.com/repos/kite-project/hope/forks","keys_url":"https://api.github.com/repos/kite-project/hope/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kite-project/hope/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kite-project/hope/teams","hooks_url":"https://api.github.com/repos/kite-project/hope/hooks","issue_events_url":"https://api.github.com/repos/kite-project/hope/issues/events{/number}","events_url":"https://api.github.com/repos/kite-project/hope/events","assignees_url":"https://api.github.com/repos/kite-project/hope/assignees{/user}","branches_url":"https://api.github.com/repos/kite-project/hope/branches{/branch}","tags_url":"https://api.github.com/repos/kite-project/hope/tags","blobs_url":"https://api.github.com/repos/kite-project/hope/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kite-project/hope/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kite-project/hope/git/refs{/sha}","trees_url":"https://api.github.com/repos/kite-project/hope/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kite-project/hope/statuses/{sha}","languages_url":"https://api.github.com/repos/kite-project/hope/languages","stargazers_url":"https://api.github.com/repos/kite-project/hope/stargazers","contributors_url":"https://api.github.com/repos/kite-project/hope/contributors","subscribers_url":"https://api.github.com/repos/kite-project/hope/subscribers","subscription_url":"https://api.github.com/repos/kite-project/hope/subscription","commits_url":"https://api.github.com/repos/kite-project/hope/commits{/sha}","git_commits_url":"https://api.github.com/repos/kite-project/hope/git/commits{/sha}","comments_url":"https://api.github.com/repos/kite-project/hope/comments{/number}","issue_comment_url":"https://api.github.com/repos/kite-project/hope/issues/comments{/number}","contents_url":"https://api.github.com/repos/kite-project/hope/contents/{+path}","compare_url":"https://api.github.com/repos/kite-project/hope/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kite-project/hope/merges","archive_url":"https://api.github.com/repos/kite-project/hope/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kite-project/hope/downloads","issues_url":"https://api.github.com/repos/kite-project/hope/issues{/number}","pulls_url":"https://api.github.com/repos/kite-project/hope/pulls{/number}","milestones_url":"https://api.github.com/repos/kite-project/hope/milestones{/number}","notifications_url":"https://api.github.com/repos/kite-project/hope/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kite-project/hope/labels{/name}","releases_url":"https://api.github.com/repos/kite-project/hope/releases{/id}","created_at":"2015-10-13T16:45:15Z","updated_at":"2016-01-12T09:57:33Z","pushed_at":"2016-01-14T15:53:58Z","git_url":"git://github.com/kite-project/hope.git","ssh_url":"git@github.com:kite-project/hope.git","clone_url":"https://github.com/kite-project/hope.git","svn_url":"https://github.com/kite-project/hope","homepage":"","size":15937,"stargazers_count":7,"watchers_count":7,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":12,"forks":2,"open_issues":12,"watchers":7,"default_branch":"master"}},"base":{"label":"kite-project:master","ref":"master","sha":"fdac873f6bced9febb6abd873f879b5cd2965751","user":{"login":"kite-project","id":16602163,"avatar_url":"https://avatars.githubusercontent.com/u/16602163?v=3","gravatar_id":"","url":"https://api.github.com/users/kite-project","html_url":"https://github.com/kite-project","followers_url":"https://api.github.com/users/kite-project/followers","following_url":"https://api.github.com/users/kite-project/following{/other_user}","gists_url":"https://api.github.com/users/kite-project/gists{/gist_id}","starred_url":"https://api.github.com/users/kite-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kite-project/subscriptions","organizations_url":"https://api.github.com/users/kite-project/orgs","repos_url":"https://api.github.com/users/kite-project/repos","events_url":"https://api.github.com/users/kite-project/events{/privacy}","received_events_url":"https://api.github.com/users/kite-project/received_events","type":"Organization","site_admin":false},"repo":{"id":44190723,"name":"hope","full_name":"kite-project/hope","owner":{"login":"kite-project","id":16602163,"avatar_url":"https://avatars.githubusercontent.com/u/16602163?v=3","gravatar_id":"","url":"https://api.github.com/users/kite-project","html_url":"https://github.com/kite-project","followers_url":"https://api.github.com/users/kite-project/followers","following_url":"https://api.github.com/users/kite-project/following{/other_user}","gists_url":"https://api.github.com/users/kite-project/gists{/gist_id}","starred_url":"https://api.github.com/users/kite-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kite-project/subscriptions","organizations_url":"https://api.github.com/users/kite-project/orgs","repos_url":"https://api.github.com/users/kite-project/repos","events_url":"https://api.github.com/users/kite-project/events{/privacy}","received_events_url":"https://api.github.com/users/kite-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kite-project/hope","description":"A new web experience for your B2G and Android devices.","fork":false,"url":"https://api.github.com/repos/kite-project/hope","forks_url":"https://api.github.com/repos/kite-project/hope/forks","keys_url":"https://api.github.com/repos/kite-project/hope/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kite-project/hope/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kite-project/hope/teams","hooks_url":"https://api.github.com/repos/kite-project/hope/hooks","issue_events_url":"https://api.github.com/repos/kite-project/hope/issues/events{/number}","events_url":"https://api.github.com/repos/kite-project/hope/events","assignees_url":"https://api.github.com/repos/kite-project/hope/assignees{/user}","branches_url":"https://api.github.com/repos/kite-project/hope/branches{/branch}","tags_url":"https://api.github.com/repos/kite-project/hope/tags","blobs_url":"https://api.github.com/repos/kite-project/hope/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kite-project/hope/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kite-project/hope/git/refs{/sha}","trees_url":"https://api.github.com/repos/kite-project/hope/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kite-project/hope/statuses/{sha}","languages_url":"https://api.github.com/repos/kite-project/hope/languages","stargazers_url":"https://api.github.com/repos/kite-project/hope/stargazers","contributors_url":"https://api.github.com/repos/kite-project/hope/contributors","subscribers_url":"https://api.github.com/repos/kite-project/hope/subscribers","subscription_url":"https://api.github.com/repos/kite-project/hope/subscription","commits_url":"https://api.github.com/repos/kite-project/hope/commits{/sha}","git_commits_url":"https://api.github.com/repos/kite-project/hope/git/commits{/sha}","comments_url":"https://api.github.com/repos/kite-project/hope/comments{/number}","issue_comment_url":"https://api.github.com/repos/kite-project/hope/issues/comments{/number}","contents_url":"https://api.github.com/repos/kite-project/hope/contents/{+path}","compare_url":"https://api.github.com/repos/kite-project/hope/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kite-project/hope/merges","archive_url":"https://api.github.com/repos/kite-project/hope/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kite-project/hope/downloads","issues_url":"https://api.github.com/repos/kite-project/hope/issues{/number}","pulls_url":"https://api.github.com/repos/kite-project/hope/pulls{/number}","milestones_url":"https://api.github.com/repos/kite-project/hope/milestones{/number}","notifications_url":"https://api.github.com/repos/kite-project/hope/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kite-project/hope/labels{/name}","releases_url":"https://api.github.com/repos/kite-project/hope/releases{/id}","created_at":"2015-10-13T16:45:15Z","updated_at":"2016-01-12T09:57:33Z","pushed_at":"2016-01-14T15:53:58Z","git_url":"git://github.com/kite-project/hope.git","ssh_url":"git@github.com:kite-project/hope.git","clone_url":"https://github.com/kite-project/hope.git","svn_url":"https://github.com/kite-project/hope","homepage":"","size":15937,"stargazers_count":7,"watchers_count":7,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":12,"forks":2,"open_issues":12,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kite-project/hope/pulls/28"},"html":{"href":"https://github.com/kite-project/hope/pull/28"},"issue":{"href":"https://api.github.com/repos/kite-project/hope/issues/28"},"comments":{"href":"https://api.github.com/repos/kite-project/hope/issues/28/comments"},"review_comments":{"href":"https://api.github.com/repos/kite-project/hope/pulls/28/comments"},"review_comment":{"href":"https://api.github.com/repos/kite-project/hope/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kite-project/hope/pulls/28/commits"},"statuses":{"href":"https://api.github.com/repos/kite-project/hope/statuses/46105151c63464fc3156da1cb681fa4044ba5055"}}}}