{"action":"created","comment":{"url":"https://api.github.com/repos/symengine/symengine/pulls/comments/72043287","id":72043287,"diff_hunk":"@@ -434,6 +457,50 @@ GaloisFieldDict::gf_frobenius_map(const GaloisFieldDict &g,\n     return out;\n }\n \n+std::pair<GaloisFieldDict, GaloisFieldDict> GaloisFieldDict::gf_trace_map(\n+    const GaloisFieldDict &a, const GaloisFieldDict &b,\n+    const GaloisFieldDict &c, const integer_class &n) const\n+{\n+    auto n_val = mp_get_si(n);","path":"symengine/fields.cpp","position":38,"original_position":38,"commit_id":"5617b0d54f374e776251c5ff76eba9fa0ea9b6af","original_commit_id":"5617b0d54f374e776251c5ff76eba9fa0ea9b6af","user":{"login":"isuruf","id":5234427,"avatar_url":"https://avatars.githubusercontent.com/u/5234427?v=3","gravatar_id":"","url":"https://api.github.com/users/isuruf","html_url":"https://github.com/isuruf","followers_url":"https://api.github.com/users/isuruf/followers","following_url":"https://api.github.com/users/isuruf/following{/other_user}","gists_url":"https://api.github.com/users/isuruf/gists{/gist_id}","starred_url":"https://api.github.com/users/isuruf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isuruf/subscriptions","organizations_url":"https://api.github.com/users/isuruf/orgs","repos_url":"https://api.github.com/users/isuruf/repos","events_url":"https://api.github.com/users/isuruf/events{/privacy}","received_events_url":"https://api.github.com/users/isuruf/received_events","type":"User","site_admin":false},"body":"What is `n`? Does it fit inside a `long`? If so, why not use a `long`?","created_at":"2016-07-25T10:46:36Z","updated_at":"2016-07-25T10:46:36Z","html_url":"https://github.com/symengine/symengine/pull/1045#discussion_r72043287","pull_request_url":"https://api.github.com/repos/symengine/symengine/pulls/1045","_links":{"self":{"href":"https://api.github.com/repos/symengine/symengine/pulls/comments/72043287"},"html":{"href":"https://github.com/symengine/symengine/pull/1045#discussion_r72043287"},"pull_request":{"href":"https://api.github.com/repos/symengine/symengine/pulls/1045"}}},"pull_request":{"url":"https://api.github.com/repos/symengine/symengine/pulls/1045","id":78597406,"html_url":"https://github.com/symengine/symengine/pull/1045","diff_url":"https://github.com/symengine/symengine/pull/1045.diff","patch_url":"https://github.com/symengine/symengine/pull/1045.patch","issue_url":"https://api.github.com/repos/symengine/symengine/issues/1045","number":1045,"state":"open","locked":false,"title":"Shoup's algorithm for Factorization in finite field","user":{"login":"nishnik","id":9252491,"avatar_url":"https://avatars.githubusercontent.com/u/9252491?v=3","gravatar_id":"","url":"https://api.github.com/users/nishnik","html_url":"https://github.com/nishnik","followers_url":"https://api.github.com/users/nishnik/followers","following_url":"https://api.github.com/users/nishnik/following{/other_user}","gists_url":"https://api.github.com/users/nishnik/gists{/gist_id}","starred_url":"https://api.github.com/users/nishnik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nishnik/subscriptions","organizations_url":"https://api.github.com/users/nishnik/orgs","repos_url":"https://api.github.com/users/nishnik/repos","events_url":"https://api.github.com/users/nishnik/events{/privacy}","received_events_url":"https://api.github.com/users/nishnik/received_events","type":"User","site_admin":false},"body":"It is faster than Zassenhaus's when `modulo_` is large.","created_at":"2016-07-24T12:44:18Z","updated_at":"2016-07-25T10:46:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2de35c3f11a1dddadc845d760c7f7077f955ab53","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/symengine/symengine/pulls/1045/commits","review_comments_url":"https://api.github.com/repos/symengine/symengine/pulls/1045/comments","review_comment_url":"https://api.github.com/repos/symengine/symengine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symengine/symengine/issues/1045/comments","statuses_url":"https://api.github.com/repos/symengine/symengine/statuses/5617b0d54f374e776251c5ff76eba9fa0ea9b6af","head":{"label":"nishnik:shoup_factor","ref":"shoup_factor","sha":"5617b0d54f374e776251c5ff76eba9fa0ea9b6af","user":{"login":"nishnik","id":9252491,"avatar_url":"https://avatars.githubusercontent.com/u/9252491?v=3","gravatar_id":"","url":"https://api.github.com/users/nishnik","html_url":"https://github.com/nishnik","followers_url":"https://api.github.com/users/nishnik/followers","following_url":"https://api.github.com/users/nishnik/following{/other_user}","gists_url":"https://api.github.com/users/nishnik/gists{/gist_id}","starred_url":"https://api.github.com/users/nishnik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nishnik/subscriptions","organizations_url":"https://api.github.com/users/nishnik/orgs","repos_url":"https://api.github.com/users/nishnik/repos","events_url":"https://api.github.com/users/nishnik/events{/privacy}","received_events_url":"https://api.github.com/users/nishnik/received_events","type":"User","site_admin":false},"repo":{"id":51446468,"name":"symengine","full_name":"nishnik/symengine","owner":{"login":"nishnik","id":9252491,"avatar_url":"https://avatars.githubusercontent.com/u/9252491?v=3","gravatar_id":"","url":"https://api.github.com/users/nishnik","html_url":"https://github.com/nishnik","followers_url":"https://api.github.com/users/nishnik/followers","following_url":"https://api.github.com/users/nishnik/following{/other_user}","gists_url":"https://api.github.com/users/nishnik/gists{/gist_id}","starred_url":"https://api.github.com/users/nishnik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nishnik/subscriptions","organizations_url":"https://api.github.com/users/nishnik/orgs","repos_url":"https://api.github.com/users/nishnik/repos","events_url":"https://api.github.com/users/nishnik/events{/privacy}","received_events_url":"https://api.github.com/users/nishnik/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nishnik/symengine","description":"SymEngine is a fast symbolic manipulation library, written in C++","fork":true,"url":"https://api.github.com/repos/nishnik/symengine","forks_url":"https://api.github.com/repos/nishnik/symengine/forks","keys_url":"https://api.github.com/repos/nishnik/symengine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nishnik/symengine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nishnik/symengine/teams","hooks_url":"https://api.github.com/repos/nishnik/symengine/hooks","issue_events_url":"https://api.github.com/repos/nishnik/symengine/issues/events{/number}","events_url":"https://api.github.com/repos/nishnik/symengine/events","assignees_url":"https://api.github.com/repos/nishnik/symengine/assignees{/user}","branches_url":"https://api.github.com/repos/nishnik/symengine/branches{/branch}","tags_url":"https://api.github.com/repos/nishnik/symengine/tags","blobs_url":"https://api.github.com/repos/nishnik/symengine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nishnik/symengine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nishnik/symengine/git/refs{/sha}","trees_url":"https://api.github.com/repos/nishnik/symengine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nishnik/symengine/statuses/{sha}","languages_url":"https://api.github.com/repos/nishnik/symengine/languages","stargazers_url":"https://api.github.com/repos/nishnik/symengine/stargazers","contributors_url":"https://api.github.com/repos/nishnik/symengine/contributors","subscribers_url":"https://api.github.com/repos/nishnik/symengine/subscribers","subscription_url":"https://api.github.com/repos/nishnik/symengine/subscription","commits_url":"https://api.github.com/repos/nishnik/symengine/commits{/sha}","git_commits_url":"https://api.github.com/repos/nishnik/symengine/git/commits{/sha}","comments_url":"https://api.github.com/repos/nishnik/symengine/comments{/number}","issue_comment_url":"https://api.github.com/repos/nishnik/symengine/issues/comments{/number}","contents_url":"https://api.github.com/repos/nishnik/symengine/contents/{+path}","compare_url":"https://api.github.com/repos/nishnik/symengine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nishnik/symengine/merges","archive_url":"https://api.github.com/repos/nishnik/symengine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nishnik/symengine/downloads","issues_url":"https://api.github.com/repos/nishnik/symengine/issues{/number}","pulls_url":"https://api.github.com/repos/nishnik/symengine/pulls{/number}","milestones_url":"https://api.github.com/repos/nishnik/symengine/milestones{/number}","notifications_url":"https://api.github.com/repos/nishnik/symengine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nishnik/symengine/labels{/name}","releases_url":"https://api.github.com/repos/nishnik/symengine/releases{/id}","deployments_url":"https://api.github.com/repos/nishnik/symengine/deployments","created_at":"2016-02-10T14:35:30Z","updated_at":"2016-02-10T14:35:32Z","pushed_at":"2016-07-24T13:37:38Z","git_url":"git://github.com/nishnik/symengine.git","ssh_url":"git@github.com:nishnik/symengine.git","clone_url":"https://github.com/nishnik/symengine.git","svn_url":"https://github.com/nishnik/symengine","homepage":"http://sympy.org","size":5970,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"symengine:master","ref":"master","sha":"42cc57d9780a9125b4db41aec8a32202eb38ec47","user":{"login":"symengine","id":11509221,"avatar_url":"https://avatars.githubusercontent.com/u/11509221?v=3","gravatar_id":"","url":"https://api.github.com/users/symengine","html_url":"https://github.com/symengine","followers_url":"https://api.github.com/users/symengine/followers","following_url":"https://api.github.com/users/symengine/following{/other_user}","gists_url":"https://api.github.com/users/symengine/gists{/gist_id}","starred_url":"https://api.github.com/users/symengine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symengine/subscriptions","organizations_url":"https://api.github.com/users/symengine/orgs","repos_url":"https://api.github.com/users/symengine/repos","events_url":"https://api.github.com/users/symengine/events{/privacy}","received_events_url":"https://api.github.com/users/symengine/received_events","type":"Organization","site_admin":false},"repo":{"id":42376,"name":"symengine","full_name":"symengine/symengine","owner":{"login":"symengine","id":11509221,"avatar_url":"https://avatars.githubusercontent.com/u/11509221?v=3","gravatar_id":"","url":"https://api.github.com/users/symengine","html_url":"https://github.com/symengine","followers_url":"https://api.github.com/users/symengine/followers","following_url":"https://api.github.com/users/symengine/following{/other_user}","gists_url":"https://api.github.com/users/symengine/gists{/gist_id}","starred_url":"https://api.github.com/users/symengine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symengine/subscriptions","organizations_url":"https://api.github.com/users/symengine/orgs","repos_url":"https://api.github.com/users/symengine/repos","events_url":"https://api.github.com/users/symengine/events{/privacy}","received_events_url":"https://api.github.com/users/symengine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symengine/symengine","description":"SymEngine is a fast symbolic manipulation library, written in C++","fork":false,"url":"https://api.github.com/repos/symengine/symengine","forks_url":"https://api.github.com/repos/symengine/symengine/forks","keys_url":"https://api.github.com/repos/symengine/symengine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symengine/symengine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symengine/symengine/teams","hooks_url":"https://api.github.com/repos/symengine/symengine/hooks","issue_events_url":"https://api.github.com/repos/symengine/symengine/issues/events{/number}","events_url":"https://api.github.com/repos/symengine/symengine/events","assignees_url":"https://api.github.com/repos/symengine/symengine/assignees{/user}","branches_url":"https://api.github.com/repos/symengine/symengine/branches{/branch}","tags_url":"https://api.github.com/repos/symengine/symengine/tags","blobs_url":"https://api.github.com/repos/symengine/symengine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symengine/symengine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symengine/symengine/git/refs{/sha}","trees_url":"https://api.github.com/repos/symengine/symengine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symengine/symengine/statuses/{sha}","languages_url":"https://api.github.com/repos/symengine/symengine/languages","stargazers_url":"https://api.github.com/repos/symengine/symengine/stargazers","contributors_url":"https://api.github.com/repos/symengine/symengine/contributors","subscribers_url":"https://api.github.com/repos/symengine/symengine/subscribers","subscription_url":"https://api.github.com/repos/symengine/symengine/subscription","commits_url":"https://api.github.com/repos/symengine/symengine/commits{/sha}","git_commits_url":"https://api.github.com/repos/symengine/symengine/git/commits{/sha}","comments_url":"https://api.github.com/repos/symengine/symengine/comments{/number}","issue_comment_url":"https://api.github.com/repos/symengine/symengine/issues/comments{/number}","contents_url":"https://api.github.com/repos/symengine/symengine/contents/{+path}","compare_url":"https://api.github.com/repos/symengine/symengine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symengine/symengine/merges","archive_url":"https://api.github.com/repos/symengine/symengine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symengine/symengine/downloads","issues_url":"https://api.github.com/repos/symengine/symengine/issues{/number}","pulls_url":"https://api.github.com/repos/symengine/symengine/pulls{/number}","milestones_url":"https://api.github.com/repos/symengine/symengine/milestones{/number}","notifications_url":"https://api.github.com/repos/symengine/symengine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symengine/symengine/labels{/name}","releases_url":"https://api.github.com/repos/symengine/symengine/releases{/id}","deployments_url":"https://api.github.com/repos/symengine/symengine/deployments","created_at":"2008-08-13T18:40:14Z","updated_at":"2016-07-22T20:30:58Z","pushed_at":"2016-07-24T12:44:19Z","git_url":"git://github.com/symengine/symengine.git","ssh_url":"git@github.com:symengine/symengine.git","clone_url":"https://github.com/symengine/symengine.git","svn_url":"https://github.com/symengine/symengine","homepage":"http://sympy.org","size":37628,"stargazers_count":161,"watchers_count":161,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":112,"mirror_url":null,"open_issues_count":112,"forks":112,"open_issues":112,"watchers":161,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symengine/symengine/pulls/1045"},"html":{"href":"https://github.com/symengine/symengine/pull/1045"},"issue":{"href":"https://api.github.com/repos/symengine/symengine/issues/1045"},"comments":{"href":"https://api.github.com/repos/symengine/symengine/issues/1045/comments"},"review_comments":{"href":"https://api.github.com/repos/symengine/symengine/pulls/1045/comments"},"review_comment":{"href":"https://api.github.com/repos/symengine/symengine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symengine/symengine/pulls/1045/commits"},"statuses":{"href":"https://api.github.com/repos/symengine/symengine/statuses/5617b0d54f374e776251c5ff76eba9fa0ea9b6af"}}}}
{"actor":{"display_login":"isuruf"}}