{"action":"created","issue":{"url":"https://api.github.com/repos/saltstack/salt/issues/34702","repository_url":"https://api.github.com/repos/saltstack/salt","labels_url":"https://api.github.com/repos/saltstack/salt/issues/34702/labels{/name}","comments_url":"https://api.github.com/repos/saltstack/salt/issues/34702/comments","events_url":"https://api.github.com/repos/saltstack/salt/issues/34702/events","html_url":"https://github.com/saltstack/salt/pull/34702","id":165864113,"number":34702,"title":"Fixed dockerng.list_tags","user":{"login":"farcaller","id":693,"avatar_url":"https://avatars.githubusercontent.com/u/693?v=3","gravatar_id":"","url":"https://api.github.com/users/farcaller","html_url":"https://github.com/farcaller","followers_url":"https://api.github.com/users/farcaller/followers","following_url":"https://api.github.com/users/farcaller/following{/other_user}","gists_url":"https://api.github.com/users/farcaller/gists{/gist_id}","starred_url":"https://api.github.com/users/farcaller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/farcaller/subscriptions","organizations_url":"https://api.github.com/users/farcaller/orgs","repos_url":"https://api.github.com/users/farcaller/repos","events_url":"https://api.github.com/users/farcaller/events{/privacy}","received_events_url":"https://api.github.com/users/farcaller/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-07-15T19:49:38Z","updated_at":"2016-07-30T05:08:58Z","closed_at":"2016-07-15T20:50:35Z","pull_request":{"url":"https://api.github.com/repos/saltstack/salt/pulls/34702","html_url":"https://github.com/saltstack/salt/pull/34702","diff_url":"https://github.com/saltstack/salt/pull/34702.diff","patch_url":"https://github.com/saltstack/salt/pull/34702.patch"},"body":"### What does this PR do?\r\n\r\nFixes a bug in dockerng module crashing when an image doesn't have tags.\r\n\r\n### Previous Behavior\r\n\r\n```\r\n$ docker pull registry/image:latest\r\n...\r\n# update the image in the registry\r\n$ docker pull registry/image:latest\r\n... # pulls new image\r\n$ docker images\r\nREPOSITORY                          TAG                 IMAGE ID            CREATED              SIZE\r\nregistry/image               latest              b510b2249009        About a minute ago   33.23 MB\r\nregistry/image               <none>              888075fb7fb6        About an hour ago    33.23 MB\r\n```\r\n\r\n```\r\n     Comment: An exception occurred in this state: Traceback (most recent call last):\r\n                File \"/var/tmp/.prod_0615df_salt/py2/salt/state.py\", line 1723, in call\r\n                  **cdata['kwargs'])\r\n                File \"/var/tmp/.prod_0615df_salt/py2/salt/loader.py\", line 1650, in wrapper\r\n                  return f(*args, **kwargs)\r\n                File \"/var/tmp/.prod_0615df_salt/py2/salt/states/dockerng.py\", line 1519, in running\r\n                  if image not in __salt__['dockerng.list_tags']():\r\n                File \"/var/tmp/.prod_0615df_salt/py2/salt/modules/dockerng.py\", line 2240, in list_tags\r\n                  for repo_tag in item.get('RepoTags', []):\r\n              TypeError: 'NoneType' object is not iterable\r\n```\r\n\r\n### Tests written?\r\n\r\nNo\r\n"},"comment":{"url":"https://api.github.com/repos/saltstack/salt/issues/comments/236343397","html_url":"https://github.com/saltstack/salt/pull/34702#issuecomment-236343397","issue_url":"https://api.github.com/repos/saltstack/salt/issues/34702","id":236343397,"user":{"login":"hjc1710","id":1062500,"avatar_url":"https://avatars.githubusercontent.com/u/1062500?v=3","gravatar_id":"","url":"https://api.github.com/users/hjc1710","html_url":"https://github.com/hjc1710","followers_url":"https://api.github.com/users/hjc1710/followers","following_url":"https://api.github.com/users/hjc1710/following{/other_user}","gists_url":"https://api.github.com/users/hjc1710/gists{/gist_id}","starred_url":"https://api.github.com/users/hjc1710/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hjc1710/subscriptions","organizations_url":"https://api.github.com/users/hjc1710/orgs","repos_url":"https://api.github.com/users/hjc1710/repos","events_url":"https://api.github.com/users/hjc1710/events{/privacy}","received_events_url":"https://api.github.com/users/hjc1710/received_events","type":"User","site_admin":false},"created_at":"2016-07-30T05:08:58Z","updated_at":"2016-07-30T05:08:58Z","body":"This affects more than just `dockerng.list_tags`, I had this cause `dockerng.image_present` to fail =/.\r\n\r\nAny ETA on when this will get released as a bugfix for `2016.3`?\r\n\r\nFor those who run into this issue, tagging the images missing tags will fix it:\r\n\r\n```sh\r\nhjc1710@app-int01:/opt/app$ sudo salt-call  state.highstate\r\n# fails with the above error\r\nhjc1710@app-int01:/opt/app$ docker images\r\nREPOSITORY    TAG                 IMAGE ID            CREATED             SIZE\r\ncroscon/app   int                 26ad75aa118b        29 minutes ago      1.86 GB\r\ncroscon/app   <none>              57c6e7e2d3ae        10 hours ago        1.859 GB\r\n...\r\nhjc1710@app-int01:/opt/app$ docker tag 57c6e7e2d3ae croscon/app:flkasd\r\nhjc1710@app-int01:/opt/app$ sudo salt-call  state.highstate\r\n# proceeds to now work; clean up tags\r\n```"}}
{"actor":{"display_login":"hjc1710"}}