{"action":"created","issue":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/4960","repository_url":"https://api.github.com/repos/cockroachdb/cockroach","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/4960/labels{/name}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/4960/comments","events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/4960/events","html_url":"https://github.com/cockroachdb/cockroach/pull/4960","id":139128700,"number":4960,"title":"storage: Expose replicated-only distinction in replicaDataIterator","user":{"login":"nvanbenschoten","id":5438456,"avatar_url":"https://avatars.githubusercontent.com/u/5438456?v=3","gravatar_id":"","url":"https://api.github.com/users/nvanbenschoten","html_url":"https://github.com/nvanbenschoten","followers_url":"https://api.github.com/users/nvanbenschoten/followers","following_url":"https://api.github.com/users/nvanbenschoten/following{/other_user}","gists_url":"https://api.github.com/users/nvanbenschoten/gists{/gist_id}","starred_url":"https://api.github.com/users/nvanbenschoten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nvanbenschoten/subscriptions","organizations_url":"https://api.github.com/users/nvanbenschoten/orgs","repos_url":"https://api.github.com/users/nvanbenschoten/repos","events_url":"https://api.github.com/users/nvanbenschoten/events{/privacy}","received_events_url":"https://api.github.com/users/nvanbenschoten/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/cockroachdb/cockroach/labels/cleanup","name":"cleanup","color":"fef2c0"}],"state":"open","locked":false,"assignee":{"login":"bdarnell","id":160562,"avatar_url":"https://avatars.githubusercontent.com/u/160562?v=3","gravatar_id":"","url":"https://api.github.com/users/bdarnell","html_url":"https://github.com/bdarnell","followers_url":"https://api.github.com/users/bdarnell/followers","following_url":"https://api.github.com/users/bdarnell/following{/other_user}","gists_url":"https://api.github.com/users/bdarnell/gists{/gist_id}","starred_url":"https://api.github.com/users/bdarnell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdarnell/subscriptions","organizations_url":"https://api.github.com/users/bdarnell/orgs","repos_url":"https://api.github.com/users/bdarnell/repos","events_url":"https://api.github.com/users/bdarnell/events{/privacy}","received_events_url":"https://api.github.com/users/bdarnell/received_events","type":"User","site_admin":false},"milestone":null,"comments":3,"created_at":"2016-03-07T23:41:26Z","updated_at":"2016-03-09T20:40:54Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/4960","html_url":"https://github.com/cockroachdb/cockroach/pull/4960","diff_url":"https://github.com/cockroachdb/cockroach/pull/4960.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/4960.patch"},"body":"Fixes #4572.\r\n\r\nThis is a WIP. Is it safe to not delete any of the unreplicated data\r\nin `applySnapshot`?\n\n<!-- Reviewable:start -->\n[<img src=\"https://reviewable.io/review_button.svg\" height=\"40\" alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/cockroachdb/cockroach/4960)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments/194498006","html_url":"https://github.com/cockroachdb/cockroach/pull/4960#issuecomment-194498006","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/4960","id":194498006,"user":{"login":"nvanbenschoten","id":5438456,"avatar_url":"https://avatars.githubusercontent.com/u/5438456?v=3","gravatar_id":"","url":"https://api.github.com/users/nvanbenschoten","html_url":"https://github.com/nvanbenschoten","followers_url":"https://api.github.com/users/nvanbenschoten/followers","following_url":"https://api.github.com/users/nvanbenschoten/following{/other_user}","gists_url":"https://api.github.com/users/nvanbenschoten/gists{/gist_id}","starred_url":"https://api.github.com/users/nvanbenschoten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nvanbenschoten/subscriptions","organizations_url":"https://api.github.com/users/nvanbenschoten/orgs","repos_url":"https://api.github.com/users/nvanbenschoten/repos","events_url":"https://api.github.com/users/nvanbenschoten/events{/privacy}","received_events_url":"https://api.github.com/users/nvanbenschoten/received_events","type":"User","site_admin":false},"created_at":"2016-03-09T20:40:54Z","updated_at":"2016-03-09T20:40:54Z","body":"Based off of what I'm seeing right now, it looks like more than just the raft log between firstIndex and appliedIndex needs to be transferred for the \"requested entry at index\" to be is unavailable. The only way I have been able to get the tests to pass is to load the Raft Log entries using `r.Entries(r.firstIndex, r.appliedIndex+1)` or to pass unreplicated data in the snapshot KV pairs as we were doing before. I'm not sure why the `appliedIndex` needs to be incremented, but I'm wondering if that means we're counting ourselves. Do you have any idea what could be causing this, and if incrementing the index is correct or a hack that shouldnt be working?"}}