{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/pulls/comments/83672333","pull_request_review_id":4499125,"id":83672333,"diff_hunk":"@@ -34,6 +34,18 @@ def setUp(self):\n         self.mock_logger, self.script_type)\n \n   @mock.patch('google_compute_engine.metadata_scripts.script_retriever.subprocess.check_call')\n+  def testDownloadGsNoExec(self, mock_call):\n+    mock_call.side_effect = subprocess.CalledProcessError('foo', 'bar')\n+    gs_url = 'gs://fake/url'\n+    self.assertIsNone(self.retriever._DownloadGsUrl(gs_url, self.dest_dir))\n+    mock_call.assert_called_once_with(","path":"google_compute_engine/metadata_scripts/tests/script_retriever_test.py","position":23,"original_position":23,"commit_id":"285da8291e8c7de7a6eeebeb1b0b5f30d7d0d982","original_commit_id":"285da8291e8c7de7a6eeebeb1b0b5f30d7d0d982","user":{"login":"illfelder","id":1766378,"avatar_url":"https://avatars.githubusercontent.com/u/1766378?v=3","gravatar_id":"","url":"https://api.github.com/users/illfelder","html_url":"https://github.com/illfelder","followers_url":"https://api.github.com/users/illfelder/followers","following_url":"https://api.github.com/users/illfelder/following{/other_user}","gists_url":"https://api.github.com/users/illfelder/gists{/gist_id}","starred_url":"https://api.github.com/users/illfelder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/illfelder/subscriptions","organizations_url":"https://api.github.com/users/illfelder/orgs","repos_url":"https://api.github.com/users/illfelder/repos","events_url":"https://api.github.com/users/illfelder/events{/privacy}","received_events_url":"https://api.github.com/users/illfelder/received_events","type":"User","site_admin":false},"body":"    mock_call.assert_called_once_with(\r\n        ['which', 'gsutil'], stdout=subprocess.PIPE, stderr=subprocess.PIPE)","created_at":"2016-10-17T15:44:26Z","updated_at":"2016-10-17T15:45:02Z","html_url":"https://github.com/GoogleCloudPlatform/compute-image-packages/pull/346#discussion_r83672333","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/pulls/346","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/pulls/comments/83672333"},"html":{"href":"https://github.com/GoogleCloudPlatform/compute-image-packages/pull/346#discussion_r83672333"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/pulls/346"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/pulls/346","id":89413302,"html_url":"https://github.com/GoogleCloudPlatform/compute-image-packages/pull/346","diff_url":"https://github.com/GoogleCloudPlatform/compute-image-packages/pull/346.diff","patch_url":"https://github.com/GoogleCloudPlatform/compute-image-packages/pull/346.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/issues/346","number":346,"state":"open","locked":false,"title":"Check for existence of external executable","user":{"login":"rjschwei","id":1087183,"avatar_url":"https://avatars.githubusercontent.com/u/1087183?v=3","gravatar_id":"","url":"https://api.github.com/users/rjschwei","html_url":"https://github.com/rjschwei","followers_url":"https://api.github.com/users/rjschwei/followers","following_url":"https://api.github.com/users/rjschwei/following{/other_user}","gists_url":"https://api.github.com/users/rjschwei/gists{/gist_id}","starred_url":"https://api.github.com/users/rjschwei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjschwei/subscriptions","organizations_url":"https://api.github.com/users/rjschwei/orgs","repos_url":"https://api.github.com/users/rjschwei/repos","events_url":"https://api.github.com/users/rjschwei/events{/privacy}","received_events_url":"https://api.github.com/users/rjschwei/received_events","type":"User","site_admin":false},"body":"  + With the check we can exit early and provide a message to the user\r\n    that the executable is missing, rather than having the information about\r\n    the missing executable intermingled with a failed call thereof. Last\r\n    but not least it avoids the message that indicates that a download is\r\n    being attempted, which could lead to confusion.","created_at":"2016-10-14T16:19:49Z","updated_at":"2016-10-17T15:45:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3ef1091de51b661a66896ccba5ddbaec4f041eca","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/pulls/346/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/pulls/346/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/issues/346/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/statuses/285da8291e8c7de7a6eeebeb1b0b5f30d7d0d982","head":{"label":"rjschwei:noCallMissingExec","ref":"noCallMissingExec","sha":"285da8291e8c7de7a6eeebeb1b0b5f30d7d0d982","user":{"login":"rjschwei","id":1087183,"avatar_url":"https://avatars.githubusercontent.com/u/1087183?v=3","gravatar_id":"","url":"https://api.github.com/users/rjschwei","html_url":"https://github.com/rjschwei","followers_url":"https://api.github.com/users/rjschwei/followers","following_url":"https://api.github.com/users/rjschwei/following{/other_user}","gists_url":"https://api.github.com/users/rjschwei/gists{/gist_id}","starred_url":"https://api.github.com/users/rjschwei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjschwei/subscriptions","organizations_url":"https://api.github.com/users/rjschwei/orgs","repos_url":"https://api.github.com/users/rjschwei/repos","events_url":"https://api.github.com/users/rjschwei/events{/privacy}","received_events_url":"https://api.github.com/users/rjschwei/received_events","type":"User","site_admin":false},"repo":{"id":13155629,"name":"compute-image-packages","full_name":"rjschwei/compute-image-packages","owner":{"login":"rjschwei","id":1087183,"avatar_url":"https://avatars.githubusercontent.com/u/1087183?v=3","gravatar_id":"","url":"https://api.github.com/users/rjschwei","html_url":"https://github.com/rjschwei","followers_url":"https://api.github.com/users/rjschwei/followers","following_url":"https://api.github.com/users/rjschwei/following{/other_user}","gists_url":"https://api.github.com/users/rjschwei/gists{/gist_id}","starred_url":"https://api.github.com/users/rjschwei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjschwei/subscriptions","organizations_url":"https://api.github.com/users/rjschwei/orgs","repos_url":"https://api.github.com/users/rjschwei/repos","events_url":"https://api.github.com/users/rjschwei/events{/privacy}","received_events_url":"https://api.github.com/users/rjschwei/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rjschwei/compute-image-packages","description":"Scripts and tools for Google Compute Engine images.","fork":true,"url":"https://api.github.com/repos/rjschwei/compute-image-packages","forks_url":"https://api.github.com/repos/rjschwei/compute-image-packages/forks","keys_url":"https://api.github.com/repos/rjschwei/compute-image-packages/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rjschwei/compute-image-packages/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rjschwei/compute-image-packages/teams","hooks_url":"https://api.github.com/repos/rjschwei/compute-image-packages/hooks","issue_events_url":"https://api.github.com/repos/rjschwei/compute-image-packages/issues/events{/number}","events_url":"https://api.github.com/repos/rjschwei/compute-image-packages/events","assignees_url":"https://api.github.com/repos/rjschwei/compute-image-packages/assignees{/user}","branches_url":"https://api.github.com/repos/rjschwei/compute-image-packages/branches{/branch}","tags_url":"https://api.github.com/repos/rjschwei/compute-image-packages/tags","blobs_url":"https://api.github.com/repos/rjschwei/compute-image-packages/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rjschwei/compute-image-packages/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rjschwei/compute-image-packages/git/refs{/sha}","trees_url":"https://api.github.com/repos/rjschwei/compute-image-packages/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rjschwei/compute-image-packages/statuses/{sha}","languages_url":"https://api.github.com/repos/rjschwei/compute-image-packages/languages","stargazers_url":"https://api.github.com/repos/rjschwei/compute-image-packages/stargazers","contributors_url":"https://api.github.com/repos/rjschwei/compute-image-packages/contributors","subscribers_url":"https://api.github.com/repos/rjschwei/compute-image-packages/subscribers","subscription_url":"https://api.github.com/repos/rjschwei/compute-image-packages/subscription","commits_url":"https://api.github.com/repos/rjschwei/compute-image-packages/commits{/sha}","git_commits_url":"https://api.github.com/repos/rjschwei/compute-image-packages/git/commits{/sha}","comments_url":"https://api.github.com/repos/rjschwei/compute-image-packages/comments{/number}","issue_comment_url":"https://api.github.com/repos/rjschwei/compute-image-packages/issues/comments{/number}","contents_url":"https://api.github.com/repos/rjschwei/compute-image-packages/contents/{+path}","compare_url":"https://api.github.com/repos/rjschwei/compute-image-packages/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rjschwei/compute-image-packages/merges","archive_url":"https://api.github.com/repos/rjschwei/compute-image-packages/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rjschwei/compute-image-packages/downloads","issues_url":"https://api.github.com/repos/rjschwei/compute-image-packages/issues{/number}","pulls_url":"https://api.github.com/repos/rjschwei/compute-image-packages/pulls{/number}","milestones_url":"https://api.github.com/repos/rjschwei/compute-image-packages/milestones{/number}","notifications_url":"https://api.github.com/repos/rjschwei/compute-image-packages/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rjschwei/compute-image-packages/labels{/name}","releases_url":"https://api.github.com/repos/rjschwei/compute-image-packages/releases{/id}","deployments_url":"https://api.github.com/repos/rjschwei/compute-image-packages/deployments","created_at":"2013-09-27T16:38:52Z","updated_at":"2014-12-12T18:58:06Z","pushed_at":"2016-10-17T15:03:47Z","git_url":"git://github.com/rjschwei/compute-image-packages.git","ssh_url":"git@github.com:rjschwei/compute-image-packages.git","clone_url":"https://github.com/rjschwei/compute-image-packages.git","svn_url":"https://github.com/rjschwei/compute-image-packages","homepage":null,"size":786,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"14a50a6217a39e1f50f2ebade802cf76500a673a","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":11852493,"name":"compute-image-packages","full_name":"GoogleCloudPlatform/compute-image-packages","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/compute-image-packages","description":"Scripts and tools for Google Compute Engine Linux images.","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/deployments","created_at":"2013-08-02T20:52:04Z","updated_at":"2016-10-11T21:51:08Z","pushed_at":"2016-10-17T15:03:47Z","git_url":"git://github.com/GoogleCloudPlatform/compute-image-packages.git","ssh_url":"git@github.com:GoogleCloudPlatform/compute-image-packages.git","clone_url":"https://github.com/GoogleCloudPlatform/compute-image-packages.git","svn_url":"https://github.com/GoogleCloudPlatform/compute-image-packages","homepage":"","size":998,"stargazers_count":154,"watchers_count":154,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":130,"mirror_url":null,"open_issues_count":9,"forks":130,"open_issues":9,"watchers":154,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/pulls/346"},"html":{"href":"https://github.com/GoogleCloudPlatform/compute-image-packages/pull/346"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/issues/346"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/issues/346/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/pulls/346/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/pulls/346/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/statuses/285da8291e8c7de7a6eeebeb1b0b5f30d7d0d982"}}}}
{"actor":{"display_login":"illfelder"}}