{"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/78081288","id":78081288,"diff_hunk":"@@ -9,4 +9,4 @@ object:\n     description: \n   fields:\n   - rel5:\n-      value: \"/System/event_handlers/event_action_refresh?target=src_ems_cluster\"\n+      value: \"/System/event_handlers/event_action_refresh?target=src_vm\"","path":"db/fixtures/ae_datastore/ManageIQ/System/Event/EmsEvent/RHEVM.class/user_add_vm.yaml","position":5,"original_position":5,"commit_id":"cfcdff31acb482ebd34b5dd3dff7b5afb0370761","original_commit_id":"cfcdff31acb482ebd34b5dd3dff7b5afb0370761","user":{"login":"agrare","id":12851112,"avatar_url":"https://avatars.githubusercontent.com/u/12851112?v=3","gravatar_id":"","url":"https://api.github.com/users/agrare","html_url":"https://github.com/agrare","followers_url":"https://api.github.com/users/agrare/followers","following_url":"https://api.github.com/users/agrare/following{/other_user}","gists_url":"https://api.github.com/users/agrare/gists{/gist_id}","starred_url":"https://api.github.com/users/agrare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agrare/subscriptions","organizations_url":"https://api.github.com/users/agrare/orgs","repos_url":"https://api.github.com/users/agrare/repos","events_url":"https://api.github.com/users/agrare/events{/privacy}","received_events_url":"https://api.github.com/users/agrare/received_events","type":"User","site_admin":false},"body":"So instead of calling `event_action_refresh` here and having to do some special casing in the event catcher ([here](https://github.com/ManageIQ/manageiq/pull/10934/files#diff-9577813285f39dac068a42c586e9d7f1R45)) a better approach would be to create a new method like `event_action_new_vm`\r\n\r\nYou'll need a builtin automate method similar to [miq_event_action_refresh](https://github.com/ManageIQ/manageiq/blob/master/lib/miq_automation_engine/engine/miq_ae_builtin_method.rb#L109) and an EmsEvent method similar to [refresh](https://github.com/ManageIQ/manageiq/blob/master/app/models/ems_event/automate.rb#L5) which puts a `new_vm` action on the queue for the `Refresh Worker`.  This way creating the VM record is done by the `Refresh Worker`","created_at":"2016-09-08T20:19:56Z","updated_at":"2016-09-08T20:19:56Z","html_url":"https://github.com/ManageIQ/manageiq/pull/10934#discussion_r78081288","pull_request_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/10934","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/78081288"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/10934#discussion_r78081288"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/10934"}}},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/10934","id":83612583,"html_url":"https://github.com/ManageIQ/manageiq/pull/10934","diff_url":"https://github.com/ManageIQ/manageiq/pull/10934.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/10934.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/10934","number":10934,"state":"open","locked":false,"title":"Changing refresh target for vm creation","user":{"login":"pkliczewski","id":1384786,"avatar_url":"https://avatars.githubusercontent.com/u/1384786?v=3","gravatar_id":"","url":"https://api.github.com/users/pkliczewski","html_url":"https://github.com/pkliczewski","followers_url":"https://api.github.com/users/pkliczewski/followers","following_url":"https://api.github.com/users/pkliczewski/following{/other_user}","gists_url":"https://api.github.com/users/pkliczewski/gists{/gist_id}","starred_url":"https://api.github.com/users/pkliczewski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkliczewski/subscriptions","organizations_url":"https://api.github.com/users/pkliczewski/orgs","repos_url":"https://api.github.com/users/pkliczewski/repos","events_url":"https://api.github.com/users/pkliczewski/events{/privacy}","received_events_url":"https://api.github.com/users/pkliczewski/received_events","type":"User","site_admin":false},"body":"This PR improves performance of RHEV provider when new vm is created and fixes:\r\n\r\nhttps://bugzilla.redhat.com/1069707","created_at":"2016-09-01T11:05:52Z","updated_at":"2016-09-08T20:19:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"453226238312446990d20b6ef10a462a72d14337","assignee":{"login":"agrare","id":12851112,"avatar_url":"https://avatars.githubusercontent.com/u/12851112?v=3","gravatar_id":"","url":"https://api.github.com/users/agrare","html_url":"https://github.com/agrare","followers_url":"https://api.github.com/users/agrare/followers","following_url":"https://api.github.com/users/agrare/following{/other_user}","gists_url":"https://api.github.com/users/agrare/gists{/gist_id}","starred_url":"https://api.github.com/users/agrare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agrare/subscriptions","organizations_url":"https://api.github.com/users/agrare/orgs","repos_url":"https://api.github.com/users/agrare/repos","events_url":"https://api.github.com/users/agrare/events{/privacy}","received_events_url":"https://api.github.com/users/agrare/received_events","type":"User","site_admin":false},"assignees":[{"login":"agrare","id":12851112,"avatar_url":"https://avatars.githubusercontent.com/u/12851112?v=3","gravatar_id":"","url":"https://api.github.com/users/agrare","html_url":"https://github.com/agrare","followers_url":"https://api.github.com/users/agrare/followers","following_url":"https://api.github.com/users/agrare/following{/other_user}","gists_url":"https://api.github.com/users/agrare/gists{/gist_id}","starred_url":"https://api.github.com/users/agrare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agrare/subscriptions","organizations_url":"https://api.github.com/users/agrare/orgs","repos_url":"https://api.github.com/users/agrare/repos","events_url":"https://api.github.com/users/agrare/events{/privacy}","received_events_url":"https://api.github.com/users/agrare/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/10934/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/10934/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/10934/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/cfcdff31acb482ebd34b5dd3dff7b5afb0370761","head":{"label":"pkliczewski:master","ref":"master","sha":"cfcdff31acb482ebd34b5dd3dff7b5afb0370761","user":{"login":"pkliczewski","id":1384786,"avatar_url":"https://avatars.githubusercontent.com/u/1384786?v=3","gravatar_id":"","url":"https://api.github.com/users/pkliczewski","html_url":"https://github.com/pkliczewski","followers_url":"https://api.github.com/users/pkliczewski/followers","following_url":"https://api.github.com/users/pkliczewski/following{/other_user}","gists_url":"https://api.github.com/users/pkliczewski/gists{/gist_id}","starred_url":"https://api.github.com/users/pkliczewski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkliczewski/subscriptions","organizations_url":"https://api.github.com/users/pkliczewski/orgs","repos_url":"https://api.github.com/users/pkliczewski/repos","events_url":"https://api.github.com/users/pkliczewski/events{/privacy}","received_events_url":"https://api.github.com/users/pkliczewski/received_events","type":"User","site_admin":false},"repo":{"id":52615153,"name":"manageiq","full_name":"pkliczewski/manageiq","owner":{"login":"pkliczewski","id":1384786,"avatar_url":"https://avatars.githubusercontent.com/u/1384786?v=3","gravatar_id":"","url":"https://api.github.com/users/pkliczewski","html_url":"https://github.com/pkliczewski","followers_url":"https://api.github.com/users/pkliczewski/followers","following_url":"https://api.github.com/users/pkliczewski/following{/other_user}","gists_url":"https://api.github.com/users/pkliczewski/gists{/gist_id}","starred_url":"https://api.github.com/users/pkliczewski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkliczewski/subscriptions","organizations_url":"https://api.github.com/users/pkliczewski/orgs","repos_url":"https://api.github.com/users/pkliczewski/repos","events_url":"https://api.github.com/users/pkliczewski/events{/privacy}","received_events_url":"https://api.github.com/users/pkliczewski/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pkliczewski/manageiq","description":"ManageIQ Cloud Management Platform","fork":true,"url":"https://api.github.com/repos/pkliczewski/manageiq","forks_url":"https://api.github.com/repos/pkliczewski/manageiq/forks","keys_url":"https://api.github.com/repos/pkliczewski/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pkliczewski/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pkliczewski/manageiq/teams","hooks_url":"https://api.github.com/repos/pkliczewski/manageiq/hooks","issue_events_url":"https://api.github.com/repos/pkliczewski/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/pkliczewski/manageiq/events","assignees_url":"https://api.github.com/repos/pkliczewski/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/pkliczewski/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/pkliczewski/manageiq/tags","blobs_url":"https://api.github.com/repos/pkliczewski/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pkliczewski/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pkliczewski/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/pkliczewski/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pkliczewski/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/pkliczewski/manageiq/languages","stargazers_url":"https://api.github.com/repos/pkliczewski/manageiq/stargazers","contributors_url":"https://api.github.com/repos/pkliczewski/manageiq/contributors","subscribers_url":"https://api.github.com/repos/pkliczewski/manageiq/subscribers","subscription_url":"https://api.github.com/repos/pkliczewski/manageiq/subscription","commits_url":"https://api.github.com/repos/pkliczewski/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/pkliczewski/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/pkliczewski/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/pkliczewski/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/pkliczewski/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/pkliczewski/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pkliczewski/manageiq/merges","archive_url":"https://api.github.com/repos/pkliczewski/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pkliczewski/manageiq/downloads","issues_url":"https://api.github.com/repos/pkliczewski/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/pkliczewski/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/pkliczewski/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/pkliczewski/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pkliczewski/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/pkliczewski/manageiq/releases{/id}","deployments_url":"https://api.github.com/repos/pkliczewski/manageiq/deployments","created_at":"2016-02-26T15:55:23Z","updated_at":"2016-02-26T15:55:40Z","pushed_at":"2016-09-08T09:33:28Z","git_url":"git://github.com/pkliczewski/manageiq.git","ssh_url":"git@github.com:pkliczewski/manageiq.git","clone_url":"https://github.com/pkliczewski/manageiq.git","svn_url":"https://github.com/pkliczewski/manageiq","homepage":"manageiq.org","size":156832,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"c1d085606be1a644899fb82b249ac3e2e915aaaf","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":20789757,"name":"manageiq","full_name":"ManageIQ/manageiq","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq","description":"ManageIQ Open-Source Management Platform","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq","forks_url":"https://api.github.com/repos/ManageIQ/manageiq/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq/releases{/id}","deployments_url":"https://api.github.com/repos/ManageIQ/manageiq/deployments","created_at":"2014-06-13T02:31:26Z","updated_at":"2016-09-05T07:03:33Z","pushed_at":"2016-09-08T19:54:37Z","git_url":"git://github.com/ManageIQ/manageiq.git","ssh_url":"git@github.com:ManageIQ/manageiq.git","clone_url":"https://github.com/ManageIQ/manageiq.git","svn_url":"https://github.com/ManageIQ/manageiq","homepage":"manageiq.org","size":200295,"stargazers_count":314,"watchers_count":314,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":346,"mirror_url":null,"open_issues_count":827,"forks":346,"open_issues":827,"watchers":314,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/10934"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/10934"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/10934"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/10934/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/10934/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/10934/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq/statuses/cfcdff31acb482ebd34b5dd3dff7b5afb0370761"}}}}
{"actor":{"display_login":"agrare"}}