{"action":"created","comment":{"url":"https://api.github.com/repos/callemall/material-ui/pulls/comments/90705333","pull_request_review_id":11225459,"id":90705333,"diff_hunk":"@@ -221,6 +235,15 @@ export default class RadioGroup extends Component {\n         onBlur={this.handleBlur}\n       >\n         {Children.map(children, (child, index) => {\n+          const { muiName } = child.type;\n+          if (muiName === 'FormLabel') {\n+            return cloneElement(child, {\n+              error,\n+              required,","path":"src/Radio/RadioGroup.js","position":64,"original_position":64,"commit_id":"0cd97b921cc62ba2633de1b3733542fc0b578b37","original_commit_id":"0cd97b921cc62ba2633de1b3733542fc0b578b37","user":{"login":"oliviertassinari","id":3165635,"avatar_url":"https://avatars.githubusercontent.com/u/3165635?v=3","gravatar_id":"","url":"https://api.github.com/users/oliviertassinari","html_url":"https://github.com/oliviertassinari","followers_url":"https://api.github.com/users/oliviertassinari/followers","following_url":"https://api.github.com/users/oliviertassinari/following{/other_user}","gists_url":"https://api.github.com/users/oliviertassinari/gists{/gist_id}","starred_url":"https://api.github.com/users/oliviertassinari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oliviertassinari/subscriptions","organizations_url":"https://api.github.com/users/oliviertassinari/orgs","repos_url":"https://api.github.com/users/oliviertassinari/repos","events_url":"https://api.github.com/users/oliviertassinari/events{/privacy}","received_events_url":"https://api.github.com/users/oliviertassinari/received_events","type":"User","site_admin":false},"body":"You can see me coming. We had the same discussion on the `TextField` component regarding who should have the `required` responsibility between `FormLabel ` and `RadioGroup`. It's convenient at the top level but requires to pass it down.\r\n\r\nI would rather be coherent on that point and follow the `TextFieldLabel`.","created_at":"2016-12-02T19:33:37Z","updated_at":"2016-12-02T19:34:41Z","html_url":"https://github.com/callemall/material-ui/pull/5703#discussion_r90705333","pull_request_url":"https://api.github.com/repos/callemall/material-ui/pulls/5703","_links":{"self":{"href":"https://api.github.com/repos/callemall/material-ui/pulls/comments/90705333"},"html":{"href":"https://github.com/callemall/material-ui/pull/5703#discussion_r90705333"},"pull_request":{"href":"https://api.github.com/repos/callemall/material-ui/pulls/5703"}}},"pull_request":{"url":"https://api.github.com/repos/callemall/material-ui/pulls/5703","id":96186142,"html_url":"https://github.com/callemall/material-ui/pull/5703","diff_url":"https://github.com/callemall/material-ui/pull/5703.diff","patch_url":"https://github.com/callemall/material-ui/pull/5703.patch","issue_url":"https://api.github.com/repos/callemall/material-ui/issues/5703","number":5703,"state":"open","locked":false,"title":"[next][FormLabel] implement generic form label and modify RadioGroup ","user":{"login":"rosskevin","id":136564,"avatar_url":"https://avatars.githubusercontent.com/u/136564?v=3","gravatar_id":"","url":"https://api.github.com/users/rosskevin","html_url":"https://github.com/rosskevin","followers_url":"https://api.github.com/users/rosskevin/followers","following_url":"https://api.github.com/users/rosskevin/following{/other_user}","gists_url":"https://api.github.com/users/rosskevin/gists{/gist_id}","starred_url":"https://api.github.com/users/rosskevin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rosskevin/subscriptions","organizations_url":"https://api.github.com/users/rosskevin/orgs","repos_url":"https://api.github.com/users/rosskevin/repos","events_url":"https://api.github.com/users/rosskevin/events{/privacy}","received_events_url":"https://api.github.com/users/rosskevin/received_events","type":"User","site_admin":false},"body":"### Description\r\n- Implement `FormLabel` for general use in forms.  \r\n- Make `RadioGroup` `FormLabel` aware and implement `required` and `error` states\r\n- Update the `RadioGroup` demo\r\n- Add regression tests\r\n\r\n### Checklist\r\n- [x] PR has tests / docs demo, and is linted.\r\n- [x] Commit and PR titles begin with [ComponentName], and are in imperative form: \"[Component] Fix leaky abstraction\".\r\n- [x] Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).\r\n\r\n","created_at":"2016-12-01T22:43:52Z","updated_at":"2016-12-02T19:49:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a85cae1a2111a86b64321ebfdcccc6b38767e129","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/callemall/material-ui/pulls/5703/commits","review_comments_url":"https://api.github.com/repos/callemall/material-ui/pulls/5703/comments","review_comment_url":"https://api.github.com/repos/callemall/material-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/callemall/material-ui/issues/5703/comments","statuses_url":"https://api.github.com/repos/callemall/material-ui/statuses/0cd97b921cc62ba2633de1b3733542fc0b578b37","head":{"label":"alienfast:form-label","ref":"form-label","sha":"0cd97b921cc62ba2633de1b3733542fc0b578b37","user":{"login":"alienfast","id":5007255,"avatar_url":"https://avatars.githubusercontent.com/u/5007255?v=3","gravatar_id":"","url":"https://api.github.com/users/alienfast","html_url":"https://github.com/alienfast","followers_url":"https://api.github.com/users/alienfast/followers","following_url":"https://api.github.com/users/alienfast/following{/other_user}","gists_url":"https://api.github.com/users/alienfast/gists{/gist_id}","starred_url":"https://api.github.com/users/alienfast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alienfast/subscriptions","organizations_url":"https://api.github.com/users/alienfast/orgs","repos_url":"https://api.github.com/users/alienfast/repos","events_url":"https://api.github.com/users/alienfast/events{/privacy}","received_events_url":"https://api.github.com/users/alienfast/received_events","type":"Organization","site_admin":false},"repo":{"id":74066846,"name":"material-ui","full_name":"alienfast/material-ui","owner":{"login":"alienfast","id":5007255,"avatar_url":"https://avatars.githubusercontent.com/u/5007255?v=3","gravatar_id":"","url":"https://api.github.com/users/alienfast","html_url":"https://github.com/alienfast","followers_url":"https://api.github.com/users/alienfast/followers","following_url":"https://api.github.com/users/alienfast/following{/other_user}","gists_url":"https://api.github.com/users/alienfast/gists{/gist_id}","starred_url":"https://api.github.com/users/alienfast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alienfast/subscriptions","organizations_url":"https://api.github.com/users/alienfast/orgs","repos_url":"https://api.github.com/users/alienfast/repos","events_url":"https://api.github.com/users/alienfast/events{/privacy}","received_events_url":"https://api.github.com/users/alienfast/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alienfast/material-ui","description":"React Components that Implement Google's Material Design.","fork":true,"url":"https://api.github.com/repos/alienfast/material-ui","forks_url":"https://api.github.com/repos/alienfast/material-ui/forks","keys_url":"https://api.github.com/repos/alienfast/material-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alienfast/material-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alienfast/material-ui/teams","hooks_url":"https://api.github.com/repos/alienfast/material-ui/hooks","issue_events_url":"https://api.github.com/repos/alienfast/material-ui/issues/events{/number}","events_url":"https://api.github.com/repos/alienfast/material-ui/events","assignees_url":"https://api.github.com/repos/alienfast/material-ui/assignees{/user}","branches_url":"https://api.github.com/repos/alienfast/material-ui/branches{/branch}","tags_url":"https://api.github.com/repos/alienfast/material-ui/tags","blobs_url":"https://api.github.com/repos/alienfast/material-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alienfast/material-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alienfast/material-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/alienfast/material-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alienfast/material-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/alienfast/material-ui/languages","stargazers_url":"https://api.github.com/repos/alienfast/material-ui/stargazers","contributors_url":"https://api.github.com/repos/alienfast/material-ui/contributors","subscribers_url":"https://api.github.com/repos/alienfast/material-ui/subscribers","subscription_url":"https://api.github.com/repos/alienfast/material-ui/subscription","commits_url":"https://api.github.com/repos/alienfast/material-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/alienfast/material-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/alienfast/material-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/alienfast/material-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/alienfast/material-ui/contents/{+path}","compare_url":"https://api.github.com/repos/alienfast/material-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alienfast/material-ui/merges","archive_url":"https://api.github.com/repos/alienfast/material-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alienfast/material-ui/downloads","issues_url":"https://api.github.com/repos/alienfast/material-ui/issues{/number}","pulls_url":"https://api.github.com/repos/alienfast/material-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/alienfast/material-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/alienfast/material-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alienfast/material-ui/labels{/name}","releases_url":"https://api.github.com/repos/alienfast/material-ui/releases{/id}","deployments_url":"https://api.github.com/repos/alienfast/material-ui/deployments","created_at":"2016-11-17T20:57:49Z","updated_at":"2016-11-17T20:57:53Z","pushed_at":"2016-12-02T19:02:49Z","git_url":"git://github.com/alienfast/material-ui.git","ssh_url":"git@github.com:alienfast/material-ui.git","clone_url":"https://github.com/alienfast/material-ui.git","svn_url":"https://github.com/alienfast/material-ui","homepage":"http://www.material-ui.com","size":76685,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"callemall:next","ref":"next","sha":"3fb4cfa0998ecf679a391f14f6ea0c6e88eeaadf","user":{"login":"callemall","id":1262264,"avatar_url":"https://avatars.githubusercontent.com/u/1262264?v=3","gravatar_id":"","url":"https://api.github.com/users/callemall","html_url":"https://github.com/callemall","followers_url":"https://api.github.com/users/callemall/followers","following_url":"https://api.github.com/users/callemall/following{/other_user}","gists_url":"https://api.github.com/users/callemall/gists{/gist_id}","starred_url":"https://api.github.com/users/callemall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/callemall/subscriptions","organizations_url":"https://api.github.com/users/callemall/orgs","repos_url":"https://api.github.com/users/callemall/repos","events_url":"https://api.github.com/users/callemall/events{/privacy}","received_events_url":"https://api.github.com/users/callemall/received_events","type":"Organization","site_admin":false},"repo":{"id":23083156,"name":"material-ui","full_name":"callemall/material-ui","owner":{"login":"callemall","id":1262264,"avatar_url":"https://avatars.githubusercontent.com/u/1262264?v=3","gravatar_id":"","url":"https://api.github.com/users/callemall","html_url":"https://github.com/callemall","followers_url":"https://api.github.com/users/callemall/followers","following_url":"https://api.github.com/users/callemall/following{/other_user}","gists_url":"https://api.github.com/users/callemall/gists{/gist_id}","starred_url":"https://api.github.com/users/callemall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/callemall/subscriptions","organizations_url":"https://api.github.com/users/callemall/orgs","repos_url":"https://api.github.com/users/callemall/repos","events_url":"https://api.github.com/users/callemall/events{/privacy}","received_events_url":"https://api.github.com/users/callemall/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/callemall/material-ui","description":"React Components that Implement Google's Material Design.","fork":false,"url":"https://api.github.com/repos/callemall/material-ui","forks_url":"https://api.github.com/repos/callemall/material-ui/forks","keys_url":"https://api.github.com/repos/callemall/material-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/callemall/material-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/callemall/material-ui/teams","hooks_url":"https://api.github.com/repos/callemall/material-ui/hooks","issue_events_url":"https://api.github.com/repos/callemall/material-ui/issues/events{/number}","events_url":"https://api.github.com/repos/callemall/material-ui/events","assignees_url":"https://api.github.com/repos/callemall/material-ui/assignees{/user}","branches_url":"https://api.github.com/repos/callemall/material-ui/branches{/branch}","tags_url":"https://api.github.com/repos/callemall/material-ui/tags","blobs_url":"https://api.github.com/repos/callemall/material-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/callemall/material-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/callemall/material-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/callemall/material-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/callemall/material-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/callemall/material-ui/languages","stargazers_url":"https://api.github.com/repos/callemall/material-ui/stargazers","contributors_url":"https://api.github.com/repos/callemall/material-ui/contributors","subscribers_url":"https://api.github.com/repos/callemall/material-ui/subscribers","subscription_url":"https://api.github.com/repos/callemall/material-ui/subscription","commits_url":"https://api.github.com/repos/callemall/material-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/callemall/material-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/callemall/material-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/callemall/material-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/callemall/material-ui/contents/{+path}","compare_url":"https://api.github.com/repos/callemall/material-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/callemall/material-ui/merges","archive_url":"https://api.github.com/repos/callemall/material-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/callemall/material-ui/downloads","issues_url":"https://api.github.com/repos/callemall/material-ui/issues{/number}","pulls_url":"https://api.github.com/repos/callemall/material-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/callemall/material-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/callemall/material-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/callemall/material-ui/labels{/name}","releases_url":"https://api.github.com/repos/callemall/material-ui/releases{/id}","deployments_url":"https://api.github.com/repos/callemall/material-ui/deployments","created_at":"2014-08-18T19:11:54Z","updated_at":"2016-12-02T18:24:41Z","pushed_at":"2016-12-02T19:24:02Z","git_url":"git://github.com/callemall/material-ui.git","ssh_url":"git@github.com:callemall/material-ui.git","clone_url":"https://github.com/callemall/material-ui.git","svn_url":"https://github.com/callemall/material-ui","homepage":"http://www.material-ui.com","size":85441,"stargazers_count":21441,"watchers_count":21441,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3834,"mirror_url":null,"open_issues_count":663,"forks":3834,"open_issues":663,"watchers":21441,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/callemall/material-ui/pulls/5703"},"html":{"href":"https://github.com/callemall/material-ui/pull/5703"},"issue":{"href":"https://api.github.com/repos/callemall/material-ui/issues/5703"},"comments":{"href":"https://api.github.com/repos/callemall/material-ui/issues/5703/comments"},"review_comments":{"href":"https://api.github.com/repos/callemall/material-ui/pulls/5703/comments"},"review_comment":{"href":"https://api.github.com/repos/callemall/material-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/callemall/material-ui/pulls/5703/commits"},"statuses":{"href":"https://api.github.com/repos/callemall/material-ui/statuses/0cd97b921cc62ba2633de1b3733542fc0b578b37"}}}}
{"actor":{"display_login":"oliviertassinari"}}