{"action":"opened","number":2,"pull_request":{"url":"https://api.github.com/repos/KES777/mojo/pulls/2","id":82735636,"html_url":"https://github.com/KES777/mojo/pull/2","diff_url":"https://github.com/KES777/mojo/pull/2.diff","patch_url":"https://github.com/KES777/mojo/pull/2.patch","issue_url":"https://api.github.com/repos/KES777/mojo/issues/2","number":2,"state":"open","locked":false,"title":"Do not pass globals as arguments. They may be clobbered","user":{"login":"KES777","id":799021,"avatar_url":"https://avatars.githubusercontent.com/u/799021?v=3","gravatar_id":"","url":"https://api.github.com/users/KES777","html_url":"https://github.com/KES777","followers_url":"https://api.github.com/users/KES777/followers","following_url":"https://api.github.com/users/KES777/following{/other_user}","gists_url":"https://api.github.com/users/KES777/gists{/gist_id}","starred_url":"https://api.github.com/users/KES777/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KES777/subscriptions","organizations_url":"https://api.github.com/users/KES777/orgs","repos_url":"https://api.github.com/users/KES777/repos","events_url":"https://api.github.com/users/KES777/events{/privacy}","received_events_url":"https://api.github.com/users/KES777/received_events","type":"User","site_admin":false},"body":"### Summary\r\nError is clobbered before we process it\r\n\r\n### Motivation\r\nArguments to functions are just aliases. When we process error we should copy $@ as soon as possible. When we pass $@ as argument we may implicitly loose its value\r\n\r\n### References\r\n\r\nsub test {\r\n\t$@ =  'Oops';\r\n\tmy( $x ) =  @_;\r\n\tprint $x; # Oops\r\n}\r\n$@ =  'Exception';\r\ntest( $@ );","created_at":"2016-08-25T14:57:42Z","updated_at":"2016-08-25T14:57:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/KES777/mojo/pulls/2/commits","review_comments_url":"https://api.github.com/repos/KES777/mojo/pulls/2/comments","review_comment_url":"https://api.github.com/repos/KES777/mojo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/KES777/mojo/issues/2/comments","statuses_url":"https://api.github.com/repos/KES777/mojo/statuses/f31284ced613a41815648792ba9ff7123fbfc2b0","head":{"label":"KES777:do_not_pass_globals_as_arguments2","ref":"do_not_pass_globals_as_arguments2","sha":"f31284ced613a41815648792ba9ff7123fbfc2b0","user":{"login":"KES777","id":799021,"avatar_url":"https://avatars.githubusercontent.com/u/799021?v=3","gravatar_id":"","url":"https://api.github.com/users/KES777","html_url":"https://github.com/KES777","followers_url":"https://api.github.com/users/KES777/followers","following_url":"https://api.github.com/users/KES777/following{/other_user}","gists_url":"https://api.github.com/users/KES777/gists{/gist_id}","starred_url":"https://api.github.com/users/KES777/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KES777/subscriptions","organizations_url":"https://api.github.com/users/KES777/orgs","repos_url":"https://api.github.com/users/KES777/repos","events_url":"https://api.github.com/users/KES777/events{/privacy}","received_events_url":"https://api.github.com/users/KES777/received_events","type":"User","site_admin":false},"repo":{"id":45236620,"name":"mojo","full_name":"KES777/mojo","owner":{"login":"KES777","id":799021,"avatar_url":"https://avatars.githubusercontent.com/u/799021?v=3","gravatar_id":"","url":"https://api.github.com/users/KES777","html_url":"https://github.com/KES777","followers_url":"https://api.github.com/users/KES777/followers","following_url":"https://api.github.com/users/KES777/following{/other_user}","gists_url":"https://api.github.com/users/KES777/gists{/gist_id}","starred_url":"https://api.github.com/users/KES777/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KES777/subscriptions","organizations_url":"https://api.github.com/users/KES777/orgs","repos_url":"https://api.github.com/users/KES777/repos","events_url":"https://api.github.com/users/KES777/events{/privacy}","received_events_url":"https://api.github.com/users/KES777/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/KES777/mojo","description":"Mojolicious - Perl real-time web framework","fork":true,"url":"https://api.github.com/repos/KES777/mojo","forks_url":"https://api.github.com/repos/KES777/mojo/forks","keys_url":"https://api.github.com/repos/KES777/mojo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KES777/mojo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KES777/mojo/teams","hooks_url":"https://api.github.com/repos/KES777/mojo/hooks","issue_events_url":"https://api.github.com/repos/KES777/mojo/issues/events{/number}","events_url":"https://api.github.com/repos/KES777/mojo/events","assignees_url":"https://api.github.com/repos/KES777/mojo/assignees{/user}","branches_url":"https://api.github.com/repos/KES777/mojo/branches{/branch}","tags_url":"https://api.github.com/repos/KES777/mojo/tags","blobs_url":"https://api.github.com/repos/KES777/mojo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KES777/mojo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KES777/mojo/git/refs{/sha}","trees_url":"https://api.github.com/repos/KES777/mojo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KES777/mojo/statuses/{sha}","languages_url":"https://api.github.com/repos/KES777/mojo/languages","stargazers_url":"https://api.github.com/repos/KES777/mojo/stargazers","contributors_url":"https://api.github.com/repos/KES777/mojo/contributors","subscribers_url":"https://api.github.com/repos/KES777/mojo/subscribers","subscription_url":"https://api.github.com/repos/KES777/mojo/subscription","commits_url":"https://api.github.com/repos/KES777/mojo/commits{/sha}","git_commits_url":"https://api.github.com/repos/KES777/mojo/git/commits{/sha}","comments_url":"https://api.github.com/repos/KES777/mojo/comments{/number}","issue_comment_url":"https://api.github.com/repos/KES777/mojo/issues/comments{/number}","contents_url":"https://api.github.com/repos/KES777/mojo/contents/{+path}","compare_url":"https://api.github.com/repos/KES777/mojo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KES777/mojo/merges","archive_url":"https://api.github.com/repos/KES777/mojo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KES777/mojo/downloads","issues_url":"https://api.github.com/repos/KES777/mojo/issues{/number}","pulls_url":"https://api.github.com/repos/KES777/mojo/pulls{/number}","milestones_url":"https://api.github.com/repos/KES777/mojo/milestones{/number}","notifications_url":"https://api.github.com/repos/KES777/mojo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KES777/mojo/labels{/name}","releases_url":"https://api.github.com/repos/KES777/mojo/releases{/id}","deployments_url":"https://api.github.com/repos/KES777/mojo/deployments","created_at":"2015-10-30T07:50:42Z","updated_at":"2016-02-17T07:31:10Z","pushed_at":"2016-08-25T14:57:43Z","git_url":"git://github.com/KES777/mojo.git","ssh_url":"git@github.com:KES777/mojo.git","clone_url":"https://github.com/KES777/mojo.git","svn_url":"https://github.com/KES777/mojo","homepage":"http://mojolicio.us","size":23187,"stargazers_count":0,"watchers_count":0,"language":"Perl","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"KES777:master","ref":"master","sha":"1d1e77598183925afb208c0ca26c2afa1542db4a","user":{"login":"KES777","id":799021,"avatar_url":"https://avatars.githubusercontent.com/u/799021?v=3","gravatar_id":"","url":"https://api.github.com/users/KES777","html_url":"https://github.com/KES777","followers_url":"https://api.github.com/users/KES777/followers","following_url":"https://api.github.com/users/KES777/following{/other_user}","gists_url":"https://api.github.com/users/KES777/gists{/gist_id}","starred_url":"https://api.github.com/users/KES777/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KES777/subscriptions","organizations_url":"https://api.github.com/users/KES777/orgs","repos_url":"https://api.github.com/users/KES777/repos","events_url":"https://api.github.com/users/KES777/events{/privacy}","received_events_url":"https://api.github.com/users/KES777/received_events","type":"User","site_admin":false},"repo":{"id":45236620,"name":"mojo","full_name":"KES777/mojo","owner":{"login":"KES777","id":799021,"avatar_url":"https://avatars.githubusercontent.com/u/799021?v=3","gravatar_id":"","url":"https://api.github.com/users/KES777","html_url":"https://github.com/KES777","followers_url":"https://api.github.com/users/KES777/followers","following_url":"https://api.github.com/users/KES777/following{/other_user}","gists_url":"https://api.github.com/users/KES777/gists{/gist_id}","starred_url":"https://api.github.com/users/KES777/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KES777/subscriptions","organizations_url":"https://api.github.com/users/KES777/orgs","repos_url":"https://api.github.com/users/KES777/repos","events_url":"https://api.github.com/users/KES777/events{/privacy}","received_events_url":"https://api.github.com/users/KES777/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/KES777/mojo","description":"Mojolicious - Perl real-time web framework","fork":true,"url":"https://api.github.com/repos/KES777/mojo","forks_url":"https://api.github.com/repos/KES777/mojo/forks","keys_url":"https://api.github.com/repos/KES777/mojo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KES777/mojo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KES777/mojo/teams","hooks_url":"https://api.github.com/repos/KES777/mojo/hooks","issue_events_url":"https://api.github.com/repos/KES777/mojo/issues/events{/number}","events_url":"https://api.github.com/repos/KES777/mojo/events","assignees_url":"https://api.github.com/repos/KES777/mojo/assignees{/user}","branches_url":"https://api.github.com/repos/KES777/mojo/branches{/branch}","tags_url":"https://api.github.com/repos/KES777/mojo/tags","blobs_url":"https://api.github.com/repos/KES777/mojo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KES777/mojo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KES777/mojo/git/refs{/sha}","trees_url":"https://api.github.com/repos/KES777/mojo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KES777/mojo/statuses/{sha}","languages_url":"https://api.github.com/repos/KES777/mojo/languages","stargazers_url":"https://api.github.com/repos/KES777/mojo/stargazers","contributors_url":"https://api.github.com/repos/KES777/mojo/contributors","subscribers_url":"https://api.github.com/repos/KES777/mojo/subscribers","subscription_url":"https://api.github.com/repos/KES777/mojo/subscription","commits_url":"https://api.github.com/repos/KES777/mojo/commits{/sha}","git_commits_url":"https://api.github.com/repos/KES777/mojo/git/commits{/sha}","comments_url":"https://api.github.com/repos/KES777/mojo/comments{/number}","issue_comment_url":"https://api.github.com/repos/KES777/mojo/issues/comments{/number}","contents_url":"https://api.github.com/repos/KES777/mojo/contents/{+path}","compare_url":"https://api.github.com/repos/KES777/mojo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KES777/mojo/merges","archive_url":"https://api.github.com/repos/KES777/mojo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KES777/mojo/downloads","issues_url":"https://api.github.com/repos/KES777/mojo/issues{/number}","pulls_url":"https://api.github.com/repos/KES777/mojo/pulls{/number}","milestones_url":"https://api.github.com/repos/KES777/mojo/milestones{/number}","notifications_url":"https://api.github.com/repos/KES777/mojo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KES777/mojo/labels{/name}","releases_url":"https://api.github.com/repos/KES777/mojo/releases{/id}","deployments_url":"https://api.github.com/repos/KES777/mojo/deployments","created_at":"2015-10-30T07:50:42Z","updated_at":"2016-02-17T07:31:10Z","pushed_at":"2016-08-25T14:57:43Z","git_url":"git://github.com/KES777/mojo.git","ssh_url":"git@github.com:KES777/mojo.git","clone_url":"https://github.com/KES777/mojo.git","svn_url":"https://github.com/KES777/mojo","homepage":"http://mojolicio.us","size":23187,"stargazers_count":0,"watchers_count":0,"language":"Perl","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/KES777/mojo/pulls/2"},"html":{"href":"https://github.com/KES777/mojo/pull/2"},"issue":{"href":"https://api.github.com/repos/KES777/mojo/issues/2"},"comments":{"href":"https://api.github.com/repos/KES777/mojo/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/KES777/mojo/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/KES777/mojo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/KES777/mojo/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/KES777/mojo/statuses/f31284ced613a41815648792ba9ff7123fbfc2b0"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":5,"deletions":4,"changed_files":4}}
{"actor":{"display_login":"KES777"}}