{"action":"created","comment":{"url":"https://api.github.com/repos/google/trillian/pulls/comments/77805547","id":77805547,"diff_hunk":"@@ -0,0 +1,13 @@\n+package testonly\n+\n+import (\n+\t\"github.com/google/trillian/storage\"\n+)\n+\n+func MustCreateNodeIDForTreeCoords(depth, index int64, maxBitLen int) storage.NodeID {","path":"testonly/nodes.go","position":7,"original_position":7,"commit_id":"6e104e1891b9df9e5db51309b07f6400687a5c95","original_commit_id":"6e104e1891b9df9e5db51309b07f6400687a5c95","user":{"login":"taknira","id":5446167,"avatar_url":"https://avatars.githubusercontent.com/u/5446167?v=3","gravatar_id":"","url":"https://api.github.com/users/taknira","html_url":"https://github.com/taknira","followers_url":"https://api.github.com/users/taknira/followers","following_url":"https://api.github.com/users/taknira/following{/other_user}","gists_url":"https://api.github.com/users/taknira/gists{/gist_id}","starred_url":"https://api.github.com/users/taknira/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taknira/subscriptions","organizations_url":"https://api.github.com/users/taknira/orgs","repos_url":"https://api.github.com/users/taknira/repos","events_url":"https://api.github.com/users/taknira/events{/privacy}","received_events_url":"https://api.github.com/users/taknira/received_events","type":"User","site_admin":false},"body":"Small consistency thing - in definition of NewNodeIDForTreeCoords the third param is called 'maxTreeDepth', maybe use that here too?","created_at":"2016-09-07T11:40:11Z","updated_at":"2016-09-07T11:40:11Z","html_url":"https://github.com/google/trillian/pull/146#discussion_r77805547","pull_request_url":"https://api.github.com/repos/google/trillian/pulls/146","_links":{"self":{"href":"https://api.github.com/repos/google/trillian/pulls/comments/77805547"},"html":{"href":"https://github.com/google/trillian/pull/146#discussion_r77805547"},"pull_request":{"href":"https://api.github.com/repos/google/trillian/pulls/146"}}},"pull_request":{"url":"https://api.github.com/repos/google/trillian/pulls/146","id":84157775,"html_url":"https://github.com/google/trillian/pull/146","diff_url":"https://github.com/google/trillian/pull/146.diff","patch_url":"https://github.com/google/trillian/pull/146.patch","issue_url":"https://api.github.com/repos/google/trillian/issues/146","number":146,"state":"open","locked":false,"title":"Log tree grows upwards","user":{"login":"AlCutter","id":7648032,"avatar_url":"https://avatars.githubusercontent.com/u/7648032?v=3","gravatar_id":"","url":"https://api.github.com/users/AlCutter","html_url":"https://github.com/AlCutter","followers_url":"https://api.github.com/users/AlCutter/followers","following_url":"https://api.github.com/users/AlCutter/following{/other_user}","gists_url":"https://api.github.com/users/AlCutter/gists{/gist_id}","starred_url":"https://api.github.com/users/AlCutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlCutter/subscriptions","organizations_url":"https://api.github.com/users/AlCutter/orgs","repos_url":"https://api.github.com/users/AlCutter/repos","events_url":"https://api.github.com/users/AlCutter/events{/privacy}","received_events_url":"https://api.github.com/users/AlCutter/received_events","type":"User","site_admin":false},"body":"Fixes a mismatch between the storage layer and the Log merkle calculations.","created_at":"2016-09-06T16:51:30Z","updated_at":"2016-09-07T11:40:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7fdc04534cbaa033ba7e481affe44bd405ce4d1c","assignee":{"login":"taknira","id":5446167,"avatar_url":"https://avatars.githubusercontent.com/u/5446167?v=3","gravatar_id":"","url":"https://api.github.com/users/taknira","html_url":"https://github.com/taknira","followers_url":"https://api.github.com/users/taknira/followers","following_url":"https://api.github.com/users/taknira/following{/other_user}","gists_url":"https://api.github.com/users/taknira/gists{/gist_id}","starred_url":"https://api.github.com/users/taknira/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taknira/subscriptions","organizations_url":"https://api.github.com/users/taknira/orgs","repos_url":"https://api.github.com/users/taknira/repos","events_url":"https://api.github.com/users/taknira/events{/privacy}","received_events_url":"https://api.github.com/users/taknira/received_events","type":"User","site_admin":false},"assignees":[{"login":"taknira","id":5446167,"avatar_url":"https://avatars.githubusercontent.com/u/5446167?v=3","gravatar_id":"","url":"https://api.github.com/users/taknira","html_url":"https://github.com/taknira","followers_url":"https://api.github.com/users/taknira/followers","following_url":"https://api.github.com/users/taknira/following{/other_user}","gists_url":"https://api.github.com/users/taknira/gists{/gist_id}","starred_url":"https://api.github.com/users/taknira/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taknira/subscriptions","organizations_url":"https://api.github.com/users/taknira/orgs","repos_url":"https://api.github.com/users/taknira/repos","events_url":"https://api.github.com/users/taknira/events{/privacy}","received_events_url":"https://api.github.com/users/taknira/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/google/trillian/milestones/6","html_url":"https://github.com/google/trillian/milestones/Log%20M4","labels_url":"https://api.github.com/repos/google/trillian/milestones/6/labels","id":1947286,"number":6,"title":"Log M4","description":"Provisional: Add integration tests. Split generic / application STHs. Add better tests for proofs.","creator":{"login":"Martin2112","id":13366863,"avatar_url":"https://avatars.githubusercontent.com/u/13366863?v=3","gravatar_id":"","url":"https://api.github.com/users/Martin2112","html_url":"https://github.com/Martin2112","followers_url":"https://api.github.com/users/Martin2112/followers","following_url":"https://api.github.com/users/Martin2112/following{/other_user}","gists_url":"https://api.github.com/users/Martin2112/gists{/gist_id}","starred_url":"https://api.github.com/users/Martin2112/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Martin2112/subscriptions","organizations_url":"https://api.github.com/users/Martin2112/orgs","repos_url":"https://api.github.com/users/Martin2112/repos","events_url":"https://api.github.com/users/Martin2112/events{/privacy}","received_events_url":"https://api.github.com/users/Martin2112/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":5,"state":"open","created_at":"2016-08-17T12:29:40Z","updated_at":"2016-09-06T16:51:30Z","due_on":"2016-09-30T00:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/google/trillian/pulls/146/commits","review_comments_url":"https://api.github.com/repos/google/trillian/pulls/146/comments","review_comment_url":"https://api.github.com/repos/google/trillian/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/trillian/issues/146/comments","statuses_url":"https://api.github.com/repos/google/trillian/statuses/6e104e1891b9df9e5db51309b07f6400687a5c95","head":{"label":"AlCutter:log_tree_grows_upwards","ref":"log_tree_grows_upwards","sha":"6e104e1891b9df9e5db51309b07f6400687a5c95","user":{"login":"AlCutter","id":7648032,"avatar_url":"https://avatars.githubusercontent.com/u/7648032?v=3","gravatar_id":"","url":"https://api.github.com/users/AlCutter","html_url":"https://github.com/AlCutter","followers_url":"https://api.github.com/users/AlCutter/followers","following_url":"https://api.github.com/users/AlCutter/following{/other_user}","gists_url":"https://api.github.com/users/AlCutter/gists{/gist_id}","starred_url":"https://api.github.com/users/AlCutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlCutter/subscriptions","organizations_url":"https://api.github.com/users/AlCutter/orgs","repos_url":"https://api.github.com/users/AlCutter/repos","events_url":"https://api.github.com/users/AlCutter/events{/privacy}","received_events_url":"https://api.github.com/users/AlCutter/received_events","type":"User","site_admin":false},"repo":{"id":60775946,"name":"trillian","full_name":"AlCutter/trillian","owner":{"login":"AlCutter","id":7648032,"avatar_url":"https://avatars.githubusercontent.com/u/7648032?v=3","gravatar_id":"","url":"https://api.github.com/users/AlCutter","html_url":"https://github.com/AlCutter","followers_url":"https://api.github.com/users/AlCutter/followers","following_url":"https://api.github.com/users/AlCutter/following{/other_user}","gists_url":"https://api.github.com/users/AlCutter/gists{/gist_id}","starred_url":"https://api.github.com/users/AlCutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlCutter/subscriptions","organizations_url":"https://api.github.com/users/AlCutter/orgs","repos_url":"https://api.github.com/users/AlCutter/repos","events_url":"https://api.github.com/users/AlCutter/events{/privacy}","received_events_url":"https://api.github.com/users/AlCutter/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AlCutter/trillian","description":null,"fork":true,"url":"https://api.github.com/repos/AlCutter/trillian","forks_url":"https://api.github.com/repos/AlCutter/trillian/forks","keys_url":"https://api.github.com/repos/AlCutter/trillian/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AlCutter/trillian/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AlCutter/trillian/teams","hooks_url":"https://api.github.com/repos/AlCutter/trillian/hooks","issue_events_url":"https://api.github.com/repos/AlCutter/trillian/issues/events{/number}","events_url":"https://api.github.com/repos/AlCutter/trillian/events","assignees_url":"https://api.github.com/repos/AlCutter/trillian/assignees{/user}","branches_url":"https://api.github.com/repos/AlCutter/trillian/branches{/branch}","tags_url":"https://api.github.com/repos/AlCutter/trillian/tags","blobs_url":"https://api.github.com/repos/AlCutter/trillian/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AlCutter/trillian/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AlCutter/trillian/git/refs{/sha}","trees_url":"https://api.github.com/repos/AlCutter/trillian/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AlCutter/trillian/statuses/{sha}","languages_url":"https://api.github.com/repos/AlCutter/trillian/languages","stargazers_url":"https://api.github.com/repos/AlCutter/trillian/stargazers","contributors_url":"https://api.github.com/repos/AlCutter/trillian/contributors","subscribers_url":"https://api.github.com/repos/AlCutter/trillian/subscribers","subscription_url":"https://api.github.com/repos/AlCutter/trillian/subscription","commits_url":"https://api.github.com/repos/AlCutter/trillian/commits{/sha}","git_commits_url":"https://api.github.com/repos/AlCutter/trillian/git/commits{/sha}","comments_url":"https://api.github.com/repos/AlCutter/trillian/comments{/number}","issue_comment_url":"https://api.github.com/repos/AlCutter/trillian/issues/comments{/number}","contents_url":"https://api.github.com/repos/AlCutter/trillian/contents/{+path}","compare_url":"https://api.github.com/repos/AlCutter/trillian/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AlCutter/trillian/merges","archive_url":"https://api.github.com/repos/AlCutter/trillian/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AlCutter/trillian/downloads","issues_url":"https://api.github.com/repos/AlCutter/trillian/issues{/number}","pulls_url":"https://api.github.com/repos/AlCutter/trillian/pulls{/number}","milestones_url":"https://api.github.com/repos/AlCutter/trillian/milestones{/number}","notifications_url":"https://api.github.com/repos/AlCutter/trillian/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AlCutter/trillian/labels{/name}","releases_url":"https://api.github.com/repos/AlCutter/trillian/releases{/id}","deployments_url":"https://api.github.com/repos/AlCutter/trillian/deployments","created_at":"2016-06-09T13:14:33Z","updated_at":"2016-06-09T13:16:40Z","pushed_at":"2016-09-06T17:04:04Z","git_url":"git://github.com/AlCutter/trillian.git","ssh_url":"git@github.com:AlCutter/trillian.git","clone_url":"https://github.com/AlCutter/trillian.git","svn_url":"https://github.com/AlCutter/trillian","homepage":null,"size":974,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"4a9ca6f0ef08373482362ce8993b8c2a857956d5","user":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":58654489,"name":"trillian","full_name":"google/trillian","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/trillian","description":null,"fork":false,"url":"https://api.github.com/repos/google/trillian","forks_url":"https://api.github.com/repos/google/trillian/forks","keys_url":"https://api.github.com/repos/google/trillian/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/trillian/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/trillian/teams","hooks_url":"https://api.github.com/repos/google/trillian/hooks","issue_events_url":"https://api.github.com/repos/google/trillian/issues/events{/number}","events_url":"https://api.github.com/repos/google/trillian/events","assignees_url":"https://api.github.com/repos/google/trillian/assignees{/user}","branches_url":"https://api.github.com/repos/google/trillian/branches{/branch}","tags_url":"https://api.github.com/repos/google/trillian/tags","blobs_url":"https://api.github.com/repos/google/trillian/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/trillian/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/trillian/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/trillian/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/trillian/statuses/{sha}","languages_url":"https://api.github.com/repos/google/trillian/languages","stargazers_url":"https://api.github.com/repos/google/trillian/stargazers","contributors_url":"https://api.github.com/repos/google/trillian/contributors","subscribers_url":"https://api.github.com/repos/google/trillian/subscribers","subscription_url":"https://api.github.com/repos/google/trillian/subscription","commits_url":"https://api.github.com/repos/google/trillian/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/trillian/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/trillian/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/trillian/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/trillian/contents/{+path}","compare_url":"https://api.github.com/repos/google/trillian/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/trillian/merges","archive_url":"https://api.github.com/repos/google/trillian/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/trillian/downloads","issues_url":"https://api.github.com/repos/google/trillian/issues{/number}","pulls_url":"https://api.github.com/repos/google/trillian/pulls{/number}","milestones_url":"https://api.github.com/repos/google/trillian/milestones{/number}","notifications_url":"https://api.github.com/repos/google/trillian/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/trillian/labels{/name}","releases_url":"https://api.github.com/repos/google/trillian/releases{/id}","deployments_url":"https://api.github.com/repos/google/trillian/deployments","created_at":"2016-05-12T15:37:35Z","updated_at":"2016-09-01T15:15:07Z","pushed_at":"2016-09-06T17:04:04Z","git_url":"git://github.com/google/trillian.git","ssh_url":"git@github.com:google/trillian.git","clone_url":"https://github.com/google/trillian.git","svn_url":"https://github.com/google/trillian","homepage":null,"size":1138,"stargazers_count":76,"watchers_count":76,"language":"Go","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":12,"forks":6,"open_issues":12,"watchers":76,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/trillian/pulls/146"},"html":{"href":"https://github.com/google/trillian/pull/146"},"issue":{"href":"https://api.github.com/repos/google/trillian/issues/146"},"comments":{"href":"https://api.github.com/repos/google/trillian/issues/146/comments"},"review_comments":{"href":"https://api.github.com/repos/google/trillian/pulls/146/comments"},"review_comment":{"href":"https://api.github.com/repos/google/trillian/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/trillian/pulls/146/commits"},"statuses":{"href":"https://api.github.com/repos/google/trillian/statuses/6e104e1891b9df9e5db51309b07f6400687a5c95"}}}}
{"actor":{"display_login":"taknira"}}