{"action":"closed","issue":{"url":"https://api.github.com/repos/driftyco/ionic/issues/7091","repository_url":"https://api.github.com/repos/driftyco/ionic","labels_url":"https://api.github.com/repos/driftyco/ionic/issues/7091/labels{/name}","comments_url":"https://api.github.com/repos/driftyco/ionic/issues/7091/comments","events_url":"https://api.github.com/repos/driftyco/ionic/issues/7091/events","html_url":"https://github.com/driftyco/ionic/issues/7091","id":162646073,"number":7091,"title":"gulp build issues","user":{"login":"ratt","id":223557,"avatar_url":"https://avatars.githubusercontent.com/u/223557?v=3","gravatar_id":"","url":"https://api.github.com/users/ratt","html_url":"https://github.com/ratt","followers_url":"https://api.github.com/users/ratt/followers","following_url":"https://api.github.com/users/ratt/following{/other_user}","gists_url":"https://api.github.com/users/ratt/gists{/gist_id}","starred_url":"https://api.github.com/users/ratt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ratt/subscriptions","organizations_url":"https://api.github.com/users/ratt/orgs","repos_url":"https://api.github.com/users/ratt/repos","events_url":"https://api.github.com/users/ratt/events{/privacy}","received_events_url":"https://api.github.com/users/ratt/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/driftyco/ionic/labels/build","name":"build","color":"bfd4f2"},{"url":"https://api.github.com/repos/driftyco/ionic/labels/v2","name":"v2","color":"313744"}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2016-06-28T09:51:49Z","updated_at":"2016-06-29T16:53:08Z","closed_at":"2016-06-29T16:53:08Z","body":"Upgrading to beta10 and gulp is not building the app.bundle.js \r\nIf we run the exact same code in beta9 the file is correctly created. \r\n\r\nI have traced it to do with \"ionic-gulp-browserify-typescript\"\r\n\r\nIf there is an error in your typescript EG: \r\nTypeScript error: /app/pages/home/home.ts(25,42): Error TS2304: Cannot find name 'cordova'.\r\n\r\nWe are using the current ionic-native file plugin so we have to access \"cordova.file.applicationDirectory\" directly. \r\n\r\nSo when running ionic serve, no error seems to be returned apart from the warnings generated by the TypeScript error: (these have always been there prior to beta 10) the JS is not correctly compiled to /build/js/app.bundle.js \r\n\r\nIf we open \"ionic-gulp-browserify-typescript/index.js\" and comment line 29 \r\n\r\n```\r\nonError: function(err){\r\n    console.error(err.toString());\r\n//    this.emit('end');\r\n},\r\n```\r\n\r\nThe app still shows the errors on the console but correctly creates the /build/js/app.bundle.js\r\n\r\n"}}
{"actor":{"display_login":"jgw96"}}