{"action":"created","comment":{"url":"https://api.github.com/repos/apereo/cas/pulls/comments/82776441","pull_request_review_id":3659237,"id":82776441,"diff_hunk":"@@ -170,7 +170,8 @@ private void configureSamlClient(final Map<String, String> properties) {\n         properties.put(PropertiesConfigFactory.SAML_SERVICE_PROVIDER_ENTITY_ID,\n                 casProperties.getAuthn().getPac4j().getSaml().getServiceProviderEntityId());\n         properties.put(PropertiesConfigFactory.SAML_SERVICE_PROVIDER_METADATA_PATH,\n-                casProperties.getAuthn().getPac4j().getSaml().getServiceProviderEntityId());\n+                casProperties.getAuthn().getPac4j().getSaml().getServiceProviderMetadataPath());\n+        properties.put(PropertiesConfigFactory.SAML_DESTINATION_BINDING_TYPE, \"urn:oasis:names:tc:SAML:2.0:bindings:HTTP-Redirect\");","path":"support/cas-server-support-pac4j/src/main/java/org/apereo/cas/support/pac4j/config/Pac4jConfiguration.java","position":15,"original_position":15,"commit_id":"489c335b6ed28abb45db53cd8412c9a00ec76dda","original_commit_id":"489c335b6ed28abb45db53cd8412c9a00ec76dda","user":{"login":"mmoayyed","id":1205228,"avatar_url":"https://avatars.githubusercontent.com/u/1205228?v=3","gravatar_id":"","url":"https://api.github.com/users/mmoayyed","html_url":"https://github.com/mmoayyed","followers_url":"https://api.github.com/users/mmoayyed/followers","following_url":"https://api.github.com/users/mmoayyed/following{/other_user}","gists_url":"https://api.github.com/users/mmoayyed/gists{/gist_id}","starred_url":"https://api.github.com/users/mmoayyed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmoayyed/subscriptions","organizations_url":"https://api.github.com/users/mmoayyed/orgs","repos_url":"https://api.github.com/users/mmoayyed/repos","events_url":"https://api.github.com/users/mmoayyed/events{/privacy}","received_events_url":"https://api.github.com/users/mmoayyed/received_events","type":"User","site_admin":false},"body":"In any case, no big deal.","created_at":"2016-10-11T11:54:47Z","updated_at":"2016-10-11T11:54:48Z","html_url":"https://github.com/apereo/cas/pull/2035#discussion_r82776441","pull_request_url":"https://api.github.com/repos/apereo/cas/pulls/2035","_links":{"self":{"href":"https://api.github.com/repos/apereo/cas/pulls/comments/82776441"},"html":{"href":"https://github.com/apereo/cas/pull/2035#discussion_r82776441"},"pull_request":{"href":"https://api.github.com/repos/apereo/cas/pulls/2035"}}},"pull_request":{"url":"https://api.github.com/repos/apereo/cas/pulls/2035","id":88801710,"html_url":"https://github.com/apereo/cas/pull/2035","diff_url":"https://github.com/apereo/cas/pull/2035.diff","patch_url":"https://github.com/apereo/cas/pull/2035.patch","issue_url":"https://api.github.com/repos/apereo/cas/issues/2035","number":2035,"state":"open","locked":false,"title":"SAML authentication delegation is broken","user":{"login":"leleuj","id":1038508,"avatar_url":"https://avatars.githubusercontent.com/u/1038508?v=3","gravatar_id":"","url":"https://api.github.com/users/leleuj","html_url":"https://github.com/leleuj","followers_url":"https://api.github.com/users/leleuj/followers","following_url":"https://api.github.com/users/leleuj/following{/other_user}","gists_url":"https://api.github.com/users/leleuj/gists{/gist_id}","starred_url":"https://api.github.com/users/leleuj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leleuj/subscriptions","organizations_url":"https://api.github.com/users/leleuj/orgs","repos_url":"https://api.github.com/users/leleuj/repos","events_url":"https://api.github.com/users/leleuj/events{/privacy}","received_events_url":"https://api.github.com/users/leleuj/received_events","type":"User","site_admin":false},"body":"Closes #2020 ","created_at":"2016-10-11T09:46:07Z","updated_at":"2016-10-11T11:54:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"faf989fb5a4913d23cb137434b2a57989e9f2dc9","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/apereo/cas/milestones/15","html_url":"https://github.com/apereo/cas/milestones/5.0.0","labels_url":"https://api.github.com/repos/apereo/cas/milestones/15/labels","id":1349862,"number":15,"title":"5.0.0","description":"Major release: General Availability (Stable)","creator":{"login":"mmoayyed","id":1205228,"avatar_url":"https://avatars.githubusercontent.com/u/1205228?v=3","gravatar_id":"","url":"https://api.github.com/users/mmoayyed","html_url":"https://github.com/mmoayyed","followers_url":"https://api.github.com/users/mmoayyed/followers","following_url":"https://api.github.com/users/mmoayyed/following{/other_user}","gists_url":"https://api.github.com/users/mmoayyed/gists{/gist_id}","starred_url":"https://api.github.com/users/mmoayyed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmoayyed/subscriptions","organizations_url":"https://api.github.com/users/mmoayyed/orgs","repos_url":"https://api.github.com/users/mmoayyed/repos","events_url":"https://api.github.com/users/mmoayyed/events{/privacy}","received_events_url":"https://api.github.com/users/mmoayyed/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":130,"state":"open","created_at":"2015-10-12T01:28:38Z","updated_at":"2016-10-11T10:13:34Z","due_on":"2016-10-17T00:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/apereo/cas/pulls/2035/commits","review_comments_url":"https://api.github.com/repos/apereo/cas/pulls/2035/comments","review_comment_url":"https://api.github.com/repos/apereo/cas/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apereo/cas/issues/2035/comments","statuses_url":"https://api.github.com/repos/apereo/cas/statuses/489c335b6ed28abb45db53cd8412c9a00ec76dda","head":{"label":"leleuj:cas-2020","ref":"cas-2020","sha":"489c335b6ed28abb45db53cd8412c9a00ec76dda","user":{"login":"leleuj","id":1038508,"avatar_url":"https://avatars.githubusercontent.com/u/1038508?v=3","gravatar_id":"","url":"https://api.github.com/users/leleuj","html_url":"https://github.com/leleuj","followers_url":"https://api.github.com/users/leleuj/followers","following_url":"https://api.github.com/users/leleuj/following{/other_user}","gists_url":"https://api.github.com/users/leleuj/gists{/gist_id}","starred_url":"https://api.github.com/users/leleuj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leleuj/subscriptions","organizations_url":"https://api.github.com/users/leleuj/orgs","repos_url":"https://api.github.com/users/leleuj/repos","events_url":"https://api.github.com/users/leleuj/events{/privacy}","received_events_url":"https://api.github.com/users/leleuj/received_events","type":"User","site_admin":false},"repo":{"id":68681012,"name":"cas","full_name":"leleuj/cas","owner":{"login":"leleuj","id":1038508,"avatar_url":"https://avatars.githubusercontent.com/u/1038508?v=3","gravatar_id":"","url":"https://api.github.com/users/leleuj","html_url":"https://github.com/leleuj","followers_url":"https://api.github.com/users/leleuj/followers","following_url":"https://api.github.com/users/leleuj/following{/other_user}","gists_url":"https://api.github.com/users/leleuj/gists{/gist_id}","starred_url":"https://api.github.com/users/leleuj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leleuj/subscriptions","organizations_url":"https://api.github.com/users/leleuj/orgs","repos_url":"https://api.github.com/users/leleuj/repos","events_url":"https://api.github.com/users/leleuj/events{/privacy}","received_events_url":"https://api.github.com/users/leleuj/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/leleuj/cas","description":"Apereo CAS - Enterprise Single Sign On for all","fork":true,"url":"https://api.github.com/repos/leleuj/cas","forks_url":"https://api.github.com/repos/leleuj/cas/forks","keys_url":"https://api.github.com/repos/leleuj/cas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/leleuj/cas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/leleuj/cas/teams","hooks_url":"https://api.github.com/repos/leleuj/cas/hooks","issue_events_url":"https://api.github.com/repos/leleuj/cas/issues/events{/number}","events_url":"https://api.github.com/repos/leleuj/cas/events","assignees_url":"https://api.github.com/repos/leleuj/cas/assignees{/user}","branches_url":"https://api.github.com/repos/leleuj/cas/branches{/branch}","tags_url":"https://api.github.com/repos/leleuj/cas/tags","blobs_url":"https://api.github.com/repos/leleuj/cas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/leleuj/cas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/leleuj/cas/git/refs{/sha}","trees_url":"https://api.github.com/repos/leleuj/cas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/leleuj/cas/statuses/{sha}","languages_url":"https://api.github.com/repos/leleuj/cas/languages","stargazers_url":"https://api.github.com/repos/leleuj/cas/stargazers","contributors_url":"https://api.github.com/repos/leleuj/cas/contributors","subscribers_url":"https://api.github.com/repos/leleuj/cas/subscribers","subscription_url":"https://api.github.com/repos/leleuj/cas/subscription","commits_url":"https://api.github.com/repos/leleuj/cas/commits{/sha}","git_commits_url":"https://api.github.com/repos/leleuj/cas/git/commits{/sha}","comments_url":"https://api.github.com/repos/leleuj/cas/comments{/number}","issue_comment_url":"https://api.github.com/repos/leleuj/cas/issues/comments{/number}","contents_url":"https://api.github.com/repos/leleuj/cas/contents/{+path}","compare_url":"https://api.github.com/repos/leleuj/cas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/leleuj/cas/merges","archive_url":"https://api.github.com/repos/leleuj/cas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/leleuj/cas/downloads","issues_url":"https://api.github.com/repos/leleuj/cas/issues{/number}","pulls_url":"https://api.github.com/repos/leleuj/cas/pulls{/number}","milestones_url":"https://api.github.com/repos/leleuj/cas/milestones{/number}","notifications_url":"https://api.github.com/repos/leleuj/cas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/leleuj/cas/labels{/name}","releases_url":"https://api.github.com/repos/leleuj/cas/releases{/id}","deployments_url":"https://api.github.com/repos/leleuj/cas/deployments","created_at":"2016-09-20T06:27:08Z","updated_at":"2016-09-20T06:27:24Z","pushed_at":"2016-10-11T09:45:35Z","git_url":"git://github.com/leleuj/cas.git","ssh_url":"git@github.com:leleuj/cas.git","clone_url":"https://github.com/leleuj/cas.git","svn_url":"https://github.com/leleuj/cas","homepage":"https://apereo.github.io/cas/","size":1250609,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apereo:master","ref":"master","sha":"8f12d581befc1f72721227fa58375818cfcf71ec","user":{"login":"apereo","id":4679233,"avatar_url":"https://avatars.githubusercontent.com/u/4679233?v=3","gravatar_id":"","url":"https://api.github.com/users/apereo","html_url":"https://github.com/apereo","followers_url":"https://api.github.com/users/apereo/followers","following_url":"https://api.github.com/users/apereo/following{/other_user}","gists_url":"https://api.github.com/users/apereo/gists{/gist_id}","starred_url":"https://api.github.com/users/apereo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apereo/subscriptions","organizations_url":"https://api.github.com/users/apereo/orgs","repos_url":"https://api.github.com/users/apereo/repos","events_url":"https://api.github.com/users/apereo/events{/privacy}","received_events_url":"https://api.github.com/users/apereo/received_events","type":"Organization","site_admin":false},"repo":{"id":2352744,"name":"cas","full_name":"apereo/cas","owner":{"login":"apereo","id":4679233,"avatar_url":"https://avatars.githubusercontent.com/u/4679233?v=3","gravatar_id":"","url":"https://api.github.com/users/apereo","html_url":"https://github.com/apereo","followers_url":"https://api.github.com/users/apereo/followers","following_url":"https://api.github.com/users/apereo/following{/other_user}","gists_url":"https://api.github.com/users/apereo/gists{/gist_id}","starred_url":"https://api.github.com/users/apereo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apereo/subscriptions","organizations_url":"https://api.github.com/users/apereo/orgs","repos_url":"https://api.github.com/users/apereo/repos","events_url":"https://api.github.com/users/apereo/events{/privacy}","received_events_url":"https://api.github.com/users/apereo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apereo/cas","description":"Apereo CAS - Enterprise Single Sign On for all","fork":false,"url":"https://api.github.com/repos/apereo/cas","forks_url":"https://api.github.com/repos/apereo/cas/forks","keys_url":"https://api.github.com/repos/apereo/cas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apereo/cas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apereo/cas/teams","hooks_url":"https://api.github.com/repos/apereo/cas/hooks","issue_events_url":"https://api.github.com/repos/apereo/cas/issues/events{/number}","events_url":"https://api.github.com/repos/apereo/cas/events","assignees_url":"https://api.github.com/repos/apereo/cas/assignees{/user}","branches_url":"https://api.github.com/repos/apereo/cas/branches{/branch}","tags_url":"https://api.github.com/repos/apereo/cas/tags","blobs_url":"https://api.github.com/repos/apereo/cas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apereo/cas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apereo/cas/git/refs{/sha}","trees_url":"https://api.github.com/repos/apereo/cas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apereo/cas/statuses/{sha}","languages_url":"https://api.github.com/repos/apereo/cas/languages","stargazers_url":"https://api.github.com/repos/apereo/cas/stargazers","contributors_url":"https://api.github.com/repos/apereo/cas/contributors","subscribers_url":"https://api.github.com/repos/apereo/cas/subscribers","subscription_url":"https://api.github.com/repos/apereo/cas/subscription","commits_url":"https://api.github.com/repos/apereo/cas/commits{/sha}","git_commits_url":"https://api.github.com/repos/apereo/cas/git/commits{/sha}","comments_url":"https://api.github.com/repos/apereo/cas/comments{/number}","issue_comment_url":"https://api.github.com/repos/apereo/cas/issues/comments{/number}","contents_url":"https://api.github.com/repos/apereo/cas/contents/{+path}","compare_url":"https://api.github.com/repos/apereo/cas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apereo/cas/merges","archive_url":"https://api.github.com/repos/apereo/cas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apereo/cas/downloads","issues_url":"https://api.github.com/repos/apereo/cas/issues{/number}","pulls_url":"https://api.github.com/repos/apereo/cas/pulls{/number}","milestones_url":"https://api.github.com/repos/apereo/cas/milestones{/number}","notifications_url":"https://api.github.com/repos/apereo/cas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apereo/cas/labels{/name}","releases_url":"https://api.github.com/repos/apereo/cas/releases{/id}","deployments_url":"https://api.github.com/repos/apereo/cas/deployments","created_at":"2011-09-09T01:36:42Z","updated_at":"2016-10-11T11:33:18Z","pushed_at":"2016-10-11T09:46:07Z","git_url":"git://github.com/apereo/cas.git","ssh_url":"git@github.com:apereo/cas.git","clone_url":"https://github.com/apereo/cas.git","svn_url":"https://github.com/apereo/cas","homepage":"https://apereo.github.io/cas/","size":1308295,"stargazers_count":1833,"watchers_count":1833,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1199,"mirror_url":null,"open_issues_count":22,"forks":1199,"open_issues":22,"watchers":1833,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apereo/cas/pulls/2035"},"html":{"href":"https://github.com/apereo/cas/pull/2035"},"issue":{"href":"https://api.github.com/repos/apereo/cas/issues/2035"},"comments":{"href":"https://api.github.com/repos/apereo/cas/issues/2035/comments"},"review_comments":{"href":"https://api.github.com/repos/apereo/cas/pulls/2035/comments"},"review_comment":{"href":"https://api.github.com/repos/apereo/cas/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apereo/cas/pulls/2035/commits"},"statuses":{"href":"https://api.github.com/repos/apereo/cas/statuses/489c335b6ed28abb45db53cd8412c9a00ec76dda"}}}}
{"actor":{"display_login":"mmoayyed"}}