{"action":"created","issue":{"url":"https://api.github.com/repos/appc/spec/issues/609","repository_url":"https://api.github.com/repos/appc/spec","labels_url":"https://api.github.com/repos/appc/spec/issues/609/labels{/name}","comments_url":"https://api.github.com/repos/appc/spec/issues/609/comments","events_url":"https://api.github.com/repos/appc/spec/issues/609/events","html_url":"https://github.com/appc/spec/issues/609","id":156284459,"number":609,"title":"HTTP_PROXY support broken by --insecure-options=all","user":{"login":"alban","id":27575,"avatar_url":"https://avatars.githubusercontent.com/u/27575?v=3","gravatar_id":"","url":"https://api.github.com/users/alban","html_url":"https://github.com/alban","followers_url":"https://api.github.com/users/alban/followers","following_url":"https://api.github.com/users/alban/following{/other_user}","gists_url":"https://api.github.com/users/alban/gists{/gist_id}","starred_url":"https://api.github.com/users/alban/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alban/subscriptions","organizations_url":"https://api.github.com/users/alban/orgs","repos_url":"https://api.github.com/users/alban/repos","events_url":"https://api.github.com/users/alban/events{/privacy}","received_events_url":"https://api.github.com/users/alban/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2016-05-23T13:45:54Z","updated_at":"2016-05-31T11:50:45Z","closed_at":null,"body":"Capturing https://github.com/coreos/rkt/issues/2590#issuecomment-220983720:\r\n\r\n> From the logs, HTTP_PROXY is used by the discovery but not for the download itself.\r\n> \r\n> ```\r\n> $ git grep ProxyFromEnvironment\r\n> Godeps/_workspace/src/github.com/appc/spec/discovery/http.go:           Proxy: > http.ProxyFromEnvironment,\r\n> ```\r\n> \r\n> It seems that the `--insecure-options=all` breaks the proxy feature there:\r\n> https://github.com/appc/spec/blob/master/discovery/http.go#L69\r\n> \r\n> ```\r\n> \tClientInsecureTLS = &http.Client{\r\n> \t\tTransport: &tInsecureTLS,\r\n> \t}\r\n> ```\r\n> \r\n> The http.Transport is overwritten without the proxy.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/appc/spec/issues/comments/222666147","html_url":"https://github.com/appc/spec/issues/609#issuecomment-222666147","issue_url":"https://api.github.com/repos/appc/spec/issues/609","id":222666147,"user":{"login":"krnowak","id":96081,"avatar_url":"https://avatars.githubusercontent.com/u/96081?v=3","gravatar_id":"","url":"https://api.github.com/users/krnowak","html_url":"https://github.com/krnowak","followers_url":"https://api.github.com/users/krnowak/followers","following_url":"https://api.github.com/users/krnowak/following{/other_user}","gists_url":"https://api.github.com/users/krnowak/gists{/gist_id}","starred_url":"https://api.github.com/users/krnowak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krnowak/subscriptions","organizations_url":"https://api.github.com/users/krnowak/orgs","repos_url":"https://api.github.com/users/krnowak/repos","events_url":"https://api.github.com/users/krnowak/events{/privacy}","received_events_url":"https://api.github.com/users/krnowak/received_events","type":"User","site_admin":false},"created_at":"2016-05-31T11:50:45Z","updated_at":"2016-05-31T11:50:45Z","body":"@jell: The proxy support is in transport itself, see https://golang.org/src/net/http/transport.go#L33 (the `Proxy` member of the transport). So in this case, the `tInsecureTLS` variable should ideally be a copy of `http.DefaultTransport` with its `TLSClientConfig` updated to have the `InsecureSkipVerify` field set to true.\r\n\r\nI'm not entirely sure if this is the case here, because we set the `Proxy` field of our transport to `http.ProxyFromEnvironment`, see https://github.com/appc/spec/blob/master/discovery/http.go#L57."}}
{"actor":{"display_login":"krnowak"}}