{"action":"created","issue":{"url":"https://api.github.com/repos/whatwg/html/issues/612","repository_url":"https://api.github.com/repos/whatwg/html","labels_url":"https://api.github.com/repos/whatwg/html/issues/612/labels{/name}","comments_url":"https://api.github.com/repos/whatwg/html/issues/612/comments","events_url":"https://api.github.com/repos/whatwg/html/issues/612/events","html_url":"https://github.com/whatwg/html/pull/612","id":130819164,"number":612,"title":"add Dockerfile for local viewing of build output","user":{"login":"defunctzombie","id":84792,"avatar_url":"https://avatars.githubusercontent.com/u/84792?v=3","gravatar_id":"","url":"https://api.github.com/users/defunctzombie","html_url":"https://github.com/defunctzombie","followers_url":"https://api.github.com/users/defunctzombie/followers","following_url":"https://api.github.com/users/defunctzombie/following{/other_user}","gists_url":"https://api.github.com/users/defunctzombie/gists{/gist_id}","starred_url":"https://api.github.com/users/defunctzombie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/defunctzombie/subscriptions","organizations_url":"https://api.github.com/users/defunctzombie/orgs","repos_url":"https://api.github.com/users/defunctzombie/repos","events_url":"https://api.github.com/users/defunctzombie/events{/privacy}","received_events_url":"https://api.github.com/users/defunctzombie/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":15,"created_at":"2016-02-02T21:16:08Z","updated_at":"2016-02-05T05:33:46Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/whatwg/html/pulls/612","html_url":"https://github.com/whatwg/html/pull/612","diff_url":"https://github.com/whatwg/html/pull/612.diff","patch_url":"https://github.com/whatwg/html/pull/612.patch"},"body":"This continues the work first described in https://github.com/whatwg/html-build/issues/55\r\n\r\nAs stated before, the steps to use this dockerfile are as follows:\r\n\r\n1. Clone the git@github.com:defunctzombie/html.git repo (again doesn't matter where)\r\n1. In the cloned directory run `docker build -t whatwg-html .`\r\n1. run `docker run --rm -it -p 8080:80 whatwg-html`\r\n\r\nThis Dockerfile will setup all of the required build tools (including wattsi) and then build the local changes to the html spec files.\r\n\r\nI won't repeat my previous comments but many of them are still relevant and can be found here:\r\nhttps://github.com/whatwg/html-build/issues/55#issuecomment-174147376\r\n\r\nAdditionally, I agree with the sentiment here (https://github.com/whatwg/html-build/pull/63) and here (https://github.com/whatwg/html-build/issues/62) that the build script needlessly reaches out to the internet to build when you could instead pre-download many of those items earlier in the Dockerfile (like wattsi) so that the actual build is fast. Your build script would better be served as two scripts: 1) fetch and prepare the system dependencies 2) do the actual build using only local files.\r\n\r\nI will also recommend here again (I think I did it in an earlier comment on the other issue) that the build repo be de-commissioned and those files moved into a support folder under this repo. I already ran into nice little gotcha because of things like this (https://github.com/whatwg/html-build/commit/ba7553bf832a39d4a0c18bae0804560e1b2e74c5). Fortunately, this Dockerfile now pins the specific wattsi repo version and html-build repo version to avoid this in the future but really the build repo is heavily coupled to this repo from what I can tell.\r\n\r\nAnyhow, this Dockerfile is a good first pass at the problem and can likely be a starting point which serves the primary needs first outlined in wanting to have a dockerfile."},"comment":{"url":"https://api.github.com/repos/whatwg/html/issues/comments/180206876","html_url":"https://github.com/whatwg/html/pull/612#issuecomment-180206876","issue_url":"https://api.github.com/repos/whatwg/html/issues/612","id":180206876,"user":{"login":"defunctzombie","id":84792,"avatar_url":"https://avatars.githubusercontent.com/u/84792?v=3","gravatar_id":"","url":"https://api.github.com/users/defunctzombie","html_url":"https://github.com/defunctzombie","followers_url":"https://api.github.com/users/defunctzombie/followers","following_url":"https://api.github.com/users/defunctzombie/following{/other_user}","gists_url":"https://api.github.com/users/defunctzombie/gists{/gist_id}","starred_url":"https://api.github.com/users/defunctzombie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/defunctzombie/subscriptions","organizations_url":"https://api.github.com/users/defunctzombie/orgs","repos_url":"https://api.github.com/users/defunctzombie/repos","events_url":"https://api.github.com/users/defunctzombie/events{/privacy}","received_events_url":"https://api.github.com/users/defunctzombie/received_events","type":"User","site_admin":false},"created_at":"2016-02-05T05:33:45Z","updated_at":"2016-02-05T05:33:45Z","body":"What is the issue with adding back the git reset I had in the Dockerfile?\nSeems like a simple solution to this version problem without\nover-engineering a new hack.\n\nOn Thursday, February 4, 2016, Philip Jägenstedt <notifications@github.com>\nwrote:\n\n> I don't think correlating the commit times would be robust, sometimes\n> commits are pushed as-is with old committer dates (and author dates,\n> obviously).\n>\n> Since it has to be an association of the type \"this html commit can be\n> built using this html-build commit\", it has to be tracked in the html repo,\n> or a third repo with commit-to-commit mapping. That sounds a bit crazy,\n> merging the repos seems less bad, then.\n>\n> We also have the wattsi dependency, of course. Could be tracked with a\n> DEPS file I suppose.\n>\n> Or we only care about all three masters working together and say that\n> https://html.spec.whatwg.org/commit-snapshots/862c8b1bff2a62c0eb471ff636676a044eeef6ec\n> will suffice for older commits?\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/whatwg/html/pull/612#issuecomment-180206116>.\n>\n"}}