{"action":"created","comment":{"url":"https://api.github.com/repos/jenkinsci/support-core-plugin/pulls/comments/81225375","pull_request_review_id":2221792,"id":81225375,"diff_hunk":"@@ -668,6 +672,28 @@ public void onOnline(Computer c, TaskListener listener) throws IOException, Inte\n                         \"Could not install root log handler on node: \" + c.getName(), e);\n             }\n         }\n+\n+        @Override\n+        public void onOffline(@Nonnull Computer c, @CheckForNull OfflineCause cause) {\n+            if (Boolean.getBoolean(SupportPlugin.class.getCanonicalName() + \".generateOnOfflineNode\")) {","path":"src/main/java/com/cloudbees/jenkins/support/SupportPlugin.java","position":32,"original_position":32,"commit_id":"9ff1b497b5415676a034ea94a3f05be1b8a51ab4","original_commit_id":"9ff1b497b5415676a034ea94a3f05be1b8a51ab4","user":{"login":"batmat","id":223853,"avatar_url":"https://avatars.githubusercontent.com/u/223853?v=3","gravatar_id":"","url":"https://api.github.com/users/batmat","html_url":"https://github.com/batmat","followers_url":"https://api.github.com/users/batmat/followers","following_url":"https://api.github.com/users/batmat/following{/other_user}","gists_url":"https://api.github.com/users/batmat/gists{/gist_id}","starred_url":"https://api.github.com/users/batmat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/batmat/subscriptions","organizations_url":"https://api.github.com/users/batmat/orgs","repos_url":"https://api.github.com/users/batmat/repos","events_url":"https://api.github.com/users/batmat/events{/privacy}","received_events_url":"https://api.github.com/users/batmat/received_events","type":"User","site_admin":false},"body":"Somehow NIT: Though in that case `SupportPlugin.class.getCanonicalName()` will yield the same result as getName(), I'd use getName() since pretty much every calls with that pattern in the core use getName().","created_at":"2016-09-29T20:20:21Z","updated_at":"2016-09-29T20:28:55Z","html_url":"https://github.com/jenkinsci/support-core-plugin/pull/75#discussion_r81225375","pull_request_url":"https://api.github.com/repos/jenkinsci/support-core-plugin/pulls/75","_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/support-core-plugin/pulls/comments/81225375"},"html":{"href":"https://github.com/jenkinsci/support-core-plugin/pull/75#discussion_r81225375"},"pull_request":{"href":"https://api.github.com/repos/jenkinsci/support-core-plugin/pulls/75"}}},"pull_request":{"url":"https://api.github.com/repos/jenkinsci/support-core-plugin/pulls/75","id":87181450,"html_url":"https://github.com/jenkinsci/support-core-plugin/pull/75","diff_url":"https://github.com/jenkinsci/support-core-plugin/pull/75.diff","patch_url":"https://github.com/jenkinsci/support-core-plugin/pull/75.patch","issue_url":"https://api.github.com/repos/jenkinsci/support-core-plugin/issues/75","number":75,"state":"open","locked":false,"title":"Optional parameter to generate a support bundle when a node goes offline","user":{"login":"christ66","id":1302212,"avatar_url":"https://avatars.githubusercontent.com/u/1302212?v=3","gravatar_id":"","url":"https://api.github.com/users/christ66","html_url":"https://github.com/christ66","followers_url":"https://api.github.com/users/christ66/followers","following_url":"https://api.github.com/users/christ66/following{/other_user}","gists_url":"https://api.github.com/users/christ66/gists{/gist_id}","starred_url":"https://api.github.com/users/christ66/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christ66/subscriptions","organizations_url":"https://api.github.com/users/christ66/orgs","repos_url":"https://api.github.com/users/christ66/repos","events_url":"https://api.github.com/users/christ66/events{/privacy}","received_events_url":"https://api.github.com/users/christ66/received_events","type":"User","site_admin":false},"body":"@reviewbybees esp. @oleg-nenashev ","created_at":"2016-09-28T19:10:17Z","updated_at":"2016-09-29T20:28:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ee65fe2da2e1e8029df4930bf0fbe9bb703937ad","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/jenkinsci/support-core-plugin/pulls/75/commits","review_comments_url":"https://api.github.com/repos/jenkinsci/support-core-plugin/pulls/75/comments","review_comment_url":"https://api.github.com/repos/jenkinsci/support-core-plugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jenkinsci/support-core-plugin/issues/75/comments","statuses_url":"https://api.github.com/repos/jenkinsci/support-core-plugin/statuses/9ff1b497b5415676a034ea94a3f05be1b8a51ab4","head":{"label":"christ66:onoffline","ref":"onoffline","sha":"9ff1b497b5415676a034ea94a3f05be1b8a51ab4","user":{"login":"christ66","id":1302212,"avatar_url":"https://avatars.githubusercontent.com/u/1302212?v=3","gravatar_id":"","url":"https://api.github.com/users/christ66","html_url":"https://github.com/christ66","followers_url":"https://api.github.com/users/christ66/followers","following_url":"https://api.github.com/users/christ66/following{/other_user}","gists_url":"https://api.github.com/users/christ66/gists{/gist_id}","starred_url":"https://api.github.com/users/christ66/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christ66/subscriptions","organizations_url":"https://api.github.com/users/christ66/orgs","repos_url":"https://api.github.com/users/christ66/repos","events_url":"https://api.github.com/users/christ66/events{/privacy}","received_events_url":"https://api.github.com/users/christ66/received_events","type":"User","site_admin":false},"repo":{"id":17503354,"name":"support-core-plugin","full_name":"christ66/support-core-plugin","owner":{"login":"christ66","id":1302212,"avatar_url":"https://avatars.githubusercontent.com/u/1302212?v=3","gravatar_id":"","url":"https://api.github.com/users/christ66","html_url":"https://github.com/christ66","followers_url":"https://api.github.com/users/christ66/followers","following_url":"https://api.github.com/users/christ66/following{/other_user}","gists_url":"https://api.github.com/users/christ66/gists{/gist_id}","starred_url":"https://api.github.com/users/christ66/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christ66/subscriptions","organizations_url":"https://api.github.com/users/christ66/orgs","repos_url":"https://api.github.com/users/christ66/repos","events_url":"https://api.github.com/users/christ66/events{/privacy}","received_events_url":"https://api.github.com/users/christ66/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/christ66/support-core-plugin","description":"","fork":true,"url":"https://api.github.com/repos/christ66/support-core-plugin","forks_url":"https://api.github.com/repos/christ66/support-core-plugin/forks","keys_url":"https://api.github.com/repos/christ66/support-core-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/christ66/support-core-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/christ66/support-core-plugin/teams","hooks_url":"https://api.github.com/repos/christ66/support-core-plugin/hooks","issue_events_url":"https://api.github.com/repos/christ66/support-core-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/christ66/support-core-plugin/events","assignees_url":"https://api.github.com/repos/christ66/support-core-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/christ66/support-core-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/christ66/support-core-plugin/tags","blobs_url":"https://api.github.com/repos/christ66/support-core-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/christ66/support-core-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/christ66/support-core-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/christ66/support-core-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/christ66/support-core-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/christ66/support-core-plugin/languages","stargazers_url":"https://api.github.com/repos/christ66/support-core-plugin/stargazers","contributors_url":"https://api.github.com/repos/christ66/support-core-plugin/contributors","subscribers_url":"https://api.github.com/repos/christ66/support-core-plugin/subscribers","subscription_url":"https://api.github.com/repos/christ66/support-core-plugin/subscription","commits_url":"https://api.github.com/repos/christ66/support-core-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/christ66/support-core-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/christ66/support-core-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/christ66/support-core-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/christ66/support-core-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/christ66/support-core-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/christ66/support-core-plugin/merges","archive_url":"https://api.github.com/repos/christ66/support-core-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/christ66/support-core-plugin/downloads","issues_url":"https://api.github.com/repos/christ66/support-core-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/christ66/support-core-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/christ66/support-core-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/christ66/support-core-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/christ66/support-core-plugin/labels{/name}","releases_url":"https://api.github.com/repos/christ66/support-core-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/christ66/support-core-plugin/deployments","created_at":"2014-03-07T05:03:31Z","updated_at":"2016-01-28T21:00:28Z","pushed_at":"2016-09-29T20:10:09Z","git_url":"git://github.com/christ66/support-core-plugin.git","ssh_url":"git@github.com:christ66/support-core-plugin.git","clone_url":"https://github.com/christ66/support-core-plugin.git","svn_url":"https://github.com/christ66/support-core-plugin","homepage":"","size":636,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jenkinsci:master","ref":"master","sha":"b7e93c47bf09d9f92291c75d789ee2f39dcd034e","user":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"repo":{"id":13830109,"name":"support-core-plugin","full_name":"jenkinsci/support-core-plugin","owner":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jenkinsci/support-core-plugin","description":"","fork":false,"url":"https://api.github.com/repos/jenkinsci/support-core-plugin","forks_url":"https://api.github.com/repos/jenkinsci/support-core-plugin/forks","keys_url":"https://api.github.com/repos/jenkinsci/support-core-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jenkinsci/support-core-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jenkinsci/support-core-plugin/teams","hooks_url":"https://api.github.com/repos/jenkinsci/support-core-plugin/hooks","issue_events_url":"https://api.github.com/repos/jenkinsci/support-core-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/jenkinsci/support-core-plugin/events","assignees_url":"https://api.github.com/repos/jenkinsci/support-core-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/jenkinsci/support-core-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/jenkinsci/support-core-plugin/tags","blobs_url":"https://api.github.com/repos/jenkinsci/support-core-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jenkinsci/support-core-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jenkinsci/support-core-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/jenkinsci/support-core-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jenkinsci/support-core-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/jenkinsci/support-core-plugin/languages","stargazers_url":"https://api.github.com/repos/jenkinsci/support-core-plugin/stargazers","contributors_url":"https://api.github.com/repos/jenkinsci/support-core-plugin/contributors","subscribers_url":"https://api.github.com/repos/jenkinsci/support-core-plugin/subscribers","subscription_url":"https://api.github.com/repos/jenkinsci/support-core-plugin/subscription","commits_url":"https://api.github.com/repos/jenkinsci/support-core-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/jenkinsci/support-core-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/jenkinsci/support-core-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/jenkinsci/support-core-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/jenkinsci/support-core-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/jenkinsci/support-core-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jenkinsci/support-core-plugin/merges","archive_url":"https://api.github.com/repos/jenkinsci/support-core-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jenkinsci/support-core-plugin/downloads","issues_url":"https://api.github.com/repos/jenkinsci/support-core-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/jenkinsci/support-core-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/jenkinsci/support-core-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/jenkinsci/support-core-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jenkinsci/support-core-plugin/labels{/name}","releases_url":"https://api.github.com/repos/jenkinsci/support-core-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/jenkinsci/support-core-plugin/deployments","created_at":"2013-10-24T11:18:45Z","updated_at":"2016-08-18T04:29:58Z","pushed_at":"2016-09-29T20:10:10Z","git_url":"git://github.com/jenkinsci/support-core-plugin.git","ssh_url":"git@github.com:jenkinsci/support-core-plugin.git","clone_url":"https://github.com/jenkinsci/support-core-plugin.git","svn_url":"https://github.com/jenkinsci/support-core-plugin","homepage":"https://wiki.jenkins-ci.org/display/JENKINS/Support+Core+Plugin","size":961,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":23,"mirror_url":null,"open_issues_count":6,"forks":23,"open_issues":6,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/support-core-plugin/pulls/75"},"html":{"href":"https://github.com/jenkinsci/support-core-plugin/pull/75"},"issue":{"href":"https://api.github.com/repos/jenkinsci/support-core-plugin/issues/75"},"comments":{"href":"https://api.github.com/repos/jenkinsci/support-core-plugin/issues/75/comments"},"review_comments":{"href":"https://api.github.com/repos/jenkinsci/support-core-plugin/pulls/75/comments"},"review_comment":{"href":"https://api.github.com/repos/jenkinsci/support-core-plugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jenkinsci/support-core-plugin/pulls/75/commits"},"statuses":{"href":"https://api.github.com/repos/jenkinsci/support-core-plugin/statuses/9ff1b497b5415676a034ea94a3f05be1b8a51ab4"}}}}
{"actor":{"display_login":"batmat"}}