{"action":"created","comment":{"url":"https://api.github.com/repos/yiisoft/yii2/pulls/comments/86367122","pull_request_review_id":7024629,"id":86367122,"diff_hunk":"@@ -65,13 +65,40 @@ class StringValidator extends Validator\n      */\n     public $encoding;\n \n+    /**\n+     * @inheritdoc\n+     */\n+    public function initDefaultMessages()","path":"framework/validators/StringValidator.php","position":7,"original_position":7,"commit_id":"04557bbf9be3a2db24b8eab0d368b4ac05db2b6b","original_commit_id":"04557bbf9be3a2db24b8eab0d368b4ac05db2b6b","user":{"login":"cebe","id":189796,"avatar_url":"https://avatars.githubusercontent.com/u/189796?v=3","gravatar_id":"","url":"https://api.github.com/users/cebe","html_url":"https://github.com/cebe","followers_url":"https://api.github.com/users/cebe/followers","following_url":"https://api.github.com/users/cebe/following{/other_user}","gists_url":"https://api.github.com/users/cebe/gists{/gist_id}","starred_url":"https://api.github.com/users/cebe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cebe/subscriptions","organizations_url":"https://api.github.com/users/cebe/orgs","repos_url":"https://api.github.com/users/cebe/repos","events_url":"https://api.github.com/users/cebe/events{/privacy}","received_events_url":"https://api.github.com/users/cebe/received_events","type":"User","site_admin":false},"body":"should be protected.","created_at":"2016-11-03T15:16:15Z","updated_at":"2016-11-03T15:17:27Z","html_url":"https://github.com/yiisoft/yii2/pull/12871#discussion_r86367122","pull_request_url":"https://api.github.com/repos/yiisoft/yii2/pulls/12871","_links":{"self":{"href":"https://api.github.com/repos/yiisoft/yii2/pulls/comments/86367122"},"html":{"href":"https://github.com/yiisoft/yii2/pull/12871#discussion_r86367122"},"pull_request":{"href":"https://api.github.com/repos/yiisoft/yii2/pulls/12871"}}},"pull_request":{"url":"https://api.github.com/repos/yiisoft/yii2/pulls/12871","id":91483815,"html_url":"https://github.com/yiisoft/yii2/pull/12871","diff_url":"https://github.com/yiisoft/yii2/pull/12871.diff","patch_url":"https://github.com/yiisoft/yii2/pull/12871.patch","issue_url":"https://api.github.com/repos/yiisoft/yii2/issues/12871","number":12871,"state":"open","locked":false,"title":"Simplify validators","user":{"login":"Faryshta","id":2029247,"avatar_url":"https://avatars.githubusercontent.com/u/2029247?v=3","gravatar_id":"","url":"https://api.github.com/users/Faryshta","html_url":"https://github.com/Faryshta","followers_url":"https://api.github.com/users/Faryshta/followers","following_url":"https://api.github.com/users/Faryshta/following{/other_user}","gists_url":"https://api.github.com/users/Faryshta/gists{/gist_id}","starred_url":"https://api.github.com/users/Faryshta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Faryshta/subscriptions","organizations_url":"https://api.github.com/users/Faryshta/orgs","repos_url":"https://api.github.com/users/Faryshta/repos","events_url":"https://api.github.com/users/Faryshta/events{/privacy}","received_events_url":"https://api.github.com/users/Faryshta/received_events","type":"User","site_admin":false},"body":"| Q | A |\n| --- | --- |\n| Is bugfix? | no |\n| New feature? | yes |\n| Breaks BC? | no |\n| Tests pass? | yes |\n\nStringHelper got two new methods, the validators got some simplificated code.\n","created_at":"2016-10-29T09:07:28Z","updated_at":"2016-11-03T15:17:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a15a9303ddc990d071b7f60b7af819b37b38b8ae","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/yiisoft/yii2/pulls/12871/commits","review_comments_url":"https://api.github.com/repos/yiisoft/yii2/pulls/12871/comments","review_comment_url":"https://api.github.com/repos/yiisoft/yii2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yiisoft/yii2/issues/12871/comments","statuses_url":"https://api.github.com/repos/yiisoft/yii2/statuses/04557bbf9be3a2db24b8eab0d368b4ac05db2b6b","head":{"label":"Faryshta:simplifyValidators","ref":"simplifyValidators","sha":"04557bbf9be3a2db24b8eab0d368b4ac05db2b6b","user":{"login":"Faryshta","id":2029247,"avatar_url":"https://avatars.githubusercontent.com/u/2029247?v=3","gravatar_id":"","url":"https://api.github.com/users/Faryshta","html_url":"https://github.com/Faryshta","followers_url":"https://api.github.com/users/Faryshta/followers","following_url":"https://api.github.com/users/Faryshta/following{/other_user}","gists_url":"https://api.github.com/users/Faryshta/gists{/gist_id}","starred_url":"https://api.github.com/users/Faryshta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Faryshta/subscriptions","organizations_url":"https://api.github.com/users/Faryshta/orgs","repos_url":"https://api.github.com/users/Faryshta/repos","events_url":"https://api.github.com/users/Faryshta/events{/privacy}","received_events_url":"https://api.github.com/users/Faryshta/received_events","type":"User","site_admin":false},"repo":{"id":24853652,"name":"yii2","full_name":"Faryshta/yii2","owner":{"login":"Faryshta","id":2029247,"avatar_url":"https://avatars.githubusercontent.com/u/2029247?v=3","gravatar_id":"","url":"https://api.github.com/users/Faryshta","html_url":"https://github.com/Faryshta","followers_url":"https://api.github.com/users/Faryshta/followers","following_url":"https://api.github.com/users/Faryshta/following{/other_user}","gists_url":"https://api.github.com/users/Faryshta/gists{/gist_id}","starred_url":"https://api.github.com/users/Faryshta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Faryshta/subscriptions","organizations_url":"https://api.github.com/users/Faryshta/orgs","repos_url":"https://api.github.com/users/Faryshta/repos","events_url":"https://api.github.com/users/Faryshta/events{/privacy}","received_events_url":"https://api.github.com/users/Faryshta/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Faryshta/yii2","description":"Yii 2 framework main development repo","fork":true,"url":"https://api.github.com/repos/Faryshta/yii2","forks_url":"https://api.github.com/repos/Faryshta/yii2/forks","keys_url":"https://api.github.com/repos/Faryshta/yii2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Faryshta/yii2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Faryshta/yii2/teams","hooks_url":"https://api.github.com/repos/Faryshta/yii2/hooks","issue_events_url":"https://api.github.com/repos/Faryshta/yii2/issues/events{/number}","events_url":"https://api.github.com/repos/Faryshta/yii2/events","assignees_url":"https://api.github.com/repos/Faryshta/yii2/assignees{/user}","branches_url":"https://api.github.com/repos/Faryshta/yii2/branches{/branch}","tags_url":"https://api.github.com/repos/Faryshta/yii2/tags","blobs_url":"https://api.github.com/repos/Faryshta/yii2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Faryshta/yii2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Faryshta/yii2/git/refs{/sha}","trees_url":"https://api.github.com/repos/Faryshta/yii2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Faryshta/yii2/statuses/{sha}","languages_url":"https://api.github.com/repos/Faryshta/yii2/languages","stargazers_url":"https://api.github.com/repos/Faryshta/yii2/stargazers","contributors_url":"https://api.github.com/repos/Faryshta/yii2/contributors","subscribers_url":"https://api.github.com/repos/Faryshta/yii2/subscribers","subscription_url":"https://api.github.com/repos/Faryshta/yii2/subscription","commits_url":"https://api.github.com/repos/Faryshta/yii2/commits{/sha}","git_commits_url":"https://api.github.com/repos/Faryshta/yii2/git/commits{/sha}","comments_url":"https://api.github.com/repos/Faryshta/yii2/comments{/number}","issue_comment_url":"https://api.github.com/repos/Faryshta/yii2/issues/comments{/number}","contents_url":"https://api.github.com/repos/Faryshta/yii2/contents/{+path}","compare_url":"https://api.github.com/repos/Faryshta/yii2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Faryshta/yii2/merges","archive_url":"https://api.github.com/repos/Faryshta/yii2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Faryshta/yii2/downloads","issues_url":"https://api.github.com/repos/Faryshta/yii2/issues{/number}","pulls_url":"https://api.github.com/repos/Faryshta/yii2/pulls{/number}","milestones_url":"https://api.github.com/repos/Faryshta/yii2/milestones{/number}","notifications_url":"https://api.github.com/repos/Faryshta/yii2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Faryshta/yii2/labels{/name}","releases_url":"https://api.github.com/repos/Faryshta/yii2/releases{/id}","deployments_url":"https://api.github.com/repos/Faryshta/yii2/deployments","created_at":"2014-10-06T16:15:53Z","updated_at":"2016-04-06T00:06:57Z","pushed_at":"2016-11-03T00:14:01Z","git_url":"git://github.com/Faryshta/yii2.git","ssh_url":"git@github.com:Faryshta/yii2.git","clone_url":"https://github.com/Faryshta/yii2.git","svn_url":"https://github.com/Faryshta/yii2","homepage":"http://www.yiiframework.com","size":40254,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"yiisoft:master","ref":"master","sha":"2ab41948a8efcaea7042b1ef965fb55563b417c6","user":{"login":"yiisoft","id":993323,"avatar_url":"https://avatars.githubusercontent.com/u/993323?v=3","gravatar_id":"","url":"https://api.github.com/users/yiisoft","html_url":"https://github.com/yiisoft","followers_url":"https://api.github.com/users/yiisoft/followers","following_url":"https://api.github.com/users/yiisoft/following{/other_user}","gists_url":"https://api.github.com/users/yiisoft/gists{/gist_id}","starred_url":"https://api.github.com/users/yiisoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yiisoft/subscriptions","organizations_url":"https://api.github.com/users/yiisoft/orgs","repos_url":"https://api.github.com/users/yiisoft/repos","events_url":"https://api.github.com/users/yiisoft/events{/privacy}","received_events_url":"https://api.github.com/users/yiisoft/received_events","type":"Organization","site_admin":false},"repo":{"id":3431193,"name":"yii2","full_name":"yiisoft/yii2","owner":{"login":"yiisoft","id":993323,"avatar_url":"https://avatars.githubusercontent.com/u/993323?v=3","gravatar_id":"","url":"https://api.github.com/users/yiisoft","html_url":"https://github.com/yiisoft","followers_url":"https://api.github.com/users/yiisoft/followers","following_url":"https://api.github.com/users/yiisoft/following{/other_user}","gists_url":"https://api.github.com/users/yiisoft/gists{/gist_id}","starred_url":"https://api.github.com/users/yiisoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yiisoft/subscriptions","organizations_url":"https://api.github.com/users/yiisoft/orgs","repos_url":"https://api.github.com/users/yiisoft/repos","events_url":"https://api.github.com/users/yiisoft/events{/privacy}","received_events_url":"https://api.github.com/users/yiisoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yiisoft/yii2","description":"Yii 2 framework main development repo","fork":false,"url":"https://api.github.com/repos/yiisoft/yii2","forks_url":"https://api.github.com/repos/yiisoft/yii2/forks","keys_url":"https://api.github.com/repos/yiisoft/yii2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yiisoft/yii2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yiisoft/yii2/teams","hooks_url":"https://api.github.com/repos/yiisoft/yii2/hooks","issue_events_url":"https://api.github.com/repos/yiisoft/yii2/issues/events{/number}","events_url":"https://api.github.com/repos/yiisoft/yii2/events","assignees_url":"https://api.github.com/repos/yiisoft/yii2/assignees{/user}","branches_url":"https://api.github.com/repos/yiisoft/yii2/branches{/branch}","tags_url":"https://api.github.com/repos/yiisoft/yii2/tags","blobs_url":"https://api.github.com/repos/yiisoft/yii2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yiisoft/yii2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yiisoft/yii2/git/refs{/sha}","trees_url":"https://api.github.com/repos/yiisoft/yii2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yiisoft/yii2/statuses/{sha}","languages_url":"https://api.github.com/repos/yiisoft/yii2/languages","stargazers_url":"https://api.github.com/repos/yiisoft/yii2/stargazers","contributors_url":"https://api.github.com/repos/yiisoft/yii2/contributors","subscribers_url":"https://api.github.com/repos/yiisoft/yii2/subscribers","subscription_url":"https://api.github.com/repos/yiisoft/yii2/subscription","commits_url":"https://api.github.com/repos/yiisoft/yii2/commits{/sha}","git_commits_url":"https://api.github.com/repos/yiisoft/yii2/git/commits{/sha}","comments_url":"https://api.github.com/repos/yiisoft/yii2/comments{/number}","issue_comment_url":"https://api.github.com/repos/yiisoft/yii2/issues/comments{/number}","contents_url":"https://api.github.com/repos/yiisoft/yii2/contents/{+path}","compare_url":"https://api.github.com/repos/yiisoft/yii2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yiisoft/yii2/merges","archive_url":"https://api.github.com/repos/yiisoft/yii2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yiisoft/yii2/downloads","issues_url":"https://api.github.com/repos/yiisoft/yii2/issues{/number}","pulls_url":"https://api.github.com/repos/yiisoft/yii2/pulls{/number}","milestones_url":"https://api.github.com/repos/yiisoft/yii2/milestones{/number}","notifications_url":"https://api.github.com/repos/yiisoft/yii2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yiisoft/yii2/labels{/name}","releases_url":"https://api.github.com/repos/yiisoft/yii2/releases{/id}","deployments_url":"https://api.github.com/repos/yiisoft/yii2/deployments","created_at":"2012-02-13T15:32:36Z","updated_at":"2016-11-03T15:16:35Z","pushed_at":"2016-11-03T15:17:10Z","git_url":"git://github.com/yiisoft/yii2.git","ssh_url":"git@github.com:yiisoft/yii2.git","clone_url":"https://github.com/yiisoft/yii2.git","svn_url":"https://github.com/yiisoft/yii2","homepage":"http://www.yiiframework.com","size":64785,"stargazers_count":9014,"watchers_count":9014,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5235,"mirror_url":null,"open_issues_count":873,"forks":5235,"open_issues":873,"watchers":9014,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yiisoft/yii2/pulls/12871"},"html":{"href":"https://github.com/yiisoft/yii2/pull/12871"},"issue":{"href":"https://api.github.com/repos/yiisoft/yii2/issues/12871"},"comments":{"href":"https://api.github.com/repos/yiisoft/yii2/issues/12871/comments"},"review_comments":{"href":"https://api.github.com/repos/yiisoft/yii2/pulls/12871/comments"},"review_comment":{"href":"https://api.github.com/repos/yiisoft/yii2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yiisoft/yii2/pulls/12871/commits"},"statuses":{"href":"https://api.github.com/repos/yiisoft/yii2/statuses/04557bbf9be3a2db24b8eab0d368b4ac05db2b6b"}}}}
{"actor":{"display_login":"cebe"}}