{"action":"created","comment":{"url":"https://api.github.com/repos/opencontainers/runc/pulls/comments/91545186","pull_request_review_id":12055012,"id":91545186,"diff_hunk":"@@ -94,6 +94,9 @@ func getDevices(path string) ([]*configs.Device, error) {\n \t\t\tif err == ErrNotADevice {\n \t\t\t\tcontinue\n \t\t\t}\n+\t\t\tif os.IsNotExist(err) {","path":"libcontainer/devices/devices_unix.go","position":4,"original_position":4,"commit_id":"8f55948aa5c97472c4a8ef6664b10ed662ce1df5","original_commit_id":"8f55948aa5c97472c4a8ef6664b10ed662ce1df5","user":{"login":"rhatdan","id":2000835,"avatar_url":"https://avatars.githubusercontent.com/u/2000835?v=3","gravatar_id":"","url":"https://api.github.com/users/rhatdan","html_url":"https://github.com/rhatdan","followers_url":"https://api.github.com/users/rhatdan/followers","following_url":"https://api.github.com/users/rhatdan/following{/other_user}","gists_url":"https://api.github.com/users/rhatdan/gists{/gist_id}","starred_url":"https://api.github.com/users/rhatdan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhatdan/subscriptions","organizations_url":"https://api.github.com/users/rhatdan/orgs","repos_url":"https://api.github.com/users/rhatdan/repos","events_url":"https://api.github.com/users/rhatdan/events{/privacy}","received_events_url":"https://api.github.com/users/rhatdan/received_events","type":"User","site_admin":false},"body":"I am fine with your patch, I just wanted to suggest an alternative.  Either way we need to fix this race.","created_at":"2016-12-08T16:08:50Z","updated_at":"2016-12-08T16:08:50Z","html_url":"https://github.com/opencontainers/runc/pull/1217#discussion_r91545186","pull_request_url":"https://api.github.com/repos/opencontainers/runc/pulls/1217","_links":{"self":{"href":"https://api.github.com/repos/opencontainers/runc/pulls/comments/91545186"},"html":{"href":"https://github.com/opencontainers/runc/pull/1217#discussion_r91545186"},"pull_request":{"href":"https://api.github.com/repos/opencontainers/runc/pulls/1217"}}},"pull_request":{"url":"https://api.github.com/repos/opencontainers/runc/pulls/1217","id":96987890,"html_url":"https://github.com/opencontainers/runc/pull/1217","diff_url":"https://github.com/opencontainers/runc/pull/1217.diff","patch_url":"https://github.com/opencontainers/runc/pull/1217.patch","issue_url":"https://api.github.com/repos/opencontainers/runc/issues/1217","number":1217,"state":"open","locked":false,"title":"Don't add device to list if it doesn't exist anymore","user":{"login":"mrunalp","id":53798,"avatar_url":"https://avatars.githubusercontent.com/u/53798?v=3","gravatar_id":"","url":"https://api.github.com/users/mrunalp","html_url":"https://github.com/mrunalp","followers_url":"https://api.github.com/users/mrunalp/followers","following_url":"https://api.github.com/users/mrunalp/following{/other_user}","gists_url":"https://api.github.com/users/mrunalp/gists{/gist_id}","starred_url":"https://api.github.com/users/mrunalp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrunalp/subscriptions","organizations_url":"https://api.github.com/users/mrunalp/orgs","repos_url":"https://api.github.com/users/mrunalp/repos","events_url":"https://api.github.com/users/mrunalp/events{/privacy}","received_events_url":"https://api.github.com/users/mrunalp/received_events","type":"User","site_admin":false},"body":"Fix a race where a device is first seen while walking /dev but has disappeared by the time we stat it. This is seen in environments where lots of privileged containers are launched/deleted rapidly with devicemapper as storage driver as lots of device mapper devices are created/deleted.\r\n\r\nSigned-off-by: Mrunal Patel <mrunalp@gmail.com>","created_at":"2016-12-07T19:12:54Z","updated_at":"2016-12-08T16:08:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ec0ebbd00ac2cd9ad1bb2462ad91d0ff275b2815","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/opencontainers/runc/pulls/1217/commits","review_comments_url":"https://api.github.com/repos/opencontainers/runc/pulls/1217/comments","review_comment_url":"https://api.github.com/repos/opencontainers/runc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opencontainers/runc/issues/1217/comments","statuses_url":"https://api.github.com/repos/opencontainers/runc/statuses/8f55948aa5c97472c4a8ef6664b10ed662ce1df5","head":{"label":"mrunalp:device_list_fix","ref":"device_list_fix","sha":"8f55948aa5c97472c4a8ef6664b10ed662ce1df5","user":{"login":"mrunalp","id":53798,"avatar_url":"https://avatars.githubusercontent.com/u/53798?v=3","gravatar_id":"","url":"https://api.github.com/users/mrunalp","html_url":"https://github.com/mrunalp","followers_url":"https://api.github.com/users/mrunalp/followers","following_url":"https://api.github.com/users/mrunalp/following{/other_user}","gists_url":"https://api.github.com/users/mrunalp/gists{/gist_id}","starred_url":"https://api.github.com/users/mrunalp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrunalp/subscriptions","organizations_url":"https://api.github.com/users/mrunalp/orgs","repos_url":"https://api.github.com/users/mrunalp/repos","events_url":"https://api.github.com/users/mrunalp/events{/privacy}","received_events_url":"https://api.github.com/users/mrunalp/received_events","type":"User","site_admin":false},"repo":{"id":38133127,"name":"runc","full_name":"mrunalp/runc","owner":{"login":"mrunalp","id":53798,"avatar_url":"https://avatars.githubusercontent.com/u/53798?v=3","gravatar_id":"","url":"https://api.github.com/users/mrunalp","html_url":"https://github.com/mrunalp","followers_url":"https://api.github.com/users/mrunalp/followers","following_url":"https://api.github.com/users/mrunalp/following{/other_user}","gists_url":"https://api.github.com/users/mrunalp/gists{/gist_id}","starred_url":"https://api.github.com/users/mrunalp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrunalp/subscriptions","organizations_url":"https://api.github.com/users/mrunalp/orgs","repos_url":"https://api.github.com/users/mrunalp/repos","events_url":"https://api.github.com/users/mrunalp/events{/privacy}","received_events_url":"https://api.github.com/users/mrunalp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mrunalp/runc","description":"runc container cli tools","fork":true,"url":"https://api.github.com/repos/mrunalp/runc","forks_url":"https://api.github.com/repos/mrunalp/runc/forks","keys_url":"https://api.github.com/repos/mrunalp/runc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mrunalp/runc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mrunalp/runc/teams","hooks_url":"https://api.github.com/repos/mrunalp/runc/hooks","issue_events_url":"https://api.github.com/repos/mrunalp/runc/issues/events{/number}","events_url":"https://api.github.com/repos/mrunalp/runc/events","assignees_url":"https://api.github.com/repos/mrunalp/runc/assignees{/user}","branches_url":"https://api.github.com/repos/mrunalp/runc/branches{/branch}","tags_url":"https://api.github.com/repos/mrunalp/runc/tags","blobs_url":"https://api.github.com/repos/mrunalp/runc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mrunalp/runc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mrunalp/runc/git/refs{/sha}","trees_url":"https://api.github.com/repos/mrunalp/runc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mrunalp/runc/statuses/{sha}","languages_url":"https://api.github.com/repos/mrunalp/runc/languages","stargazers_url":"https://api.github.com/repos/mrunalp/runc/stargazers","contributors_url":"https://api.github.com/repos/mrunalp/runc/contributors","subscribers_url":"https://api.github.com/repos/mrunalp/runc/subscribers","subscription_url":"https://api.github.com/repos/mrunalp/runc/subscription","commits_url":"https://api.github.com/repos/mrunalp/runc/commits{/sha}","git_commits_url":"https://api.github.com/repos/mrunalp/runc/git/commits{/sha}","comments_url":"https://api.github.com/repos/mrunalp/runc/comments{/number}","issue_comment_url":"https://api.github.com/repos/mrunalp/runc/issues/comments{/number}","contents_url":"https://api.github.com/repos/mrunalp/runc/contents/{+path}","compare_url":"https://api.github.com/repos/mrunalp/runc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mrunalp/runc/merges","archive_url":"https://api.github.com/repos/mrunalp/runc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mrunalp/runc/downloads","issues_url":"https://api.github.com/repos/mrunalp/runc/issues{/number}","pulls_url":"https://api.github.com/repos/mrunalp/runc/pulls{/number}","milestones_url":"https://api.github.com/repos/mrunalp/runc/milestones{/number}","notifications_url":"https://api.github.com/repos/mrunalp/runc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mrunalp/runc/labels{/name}","releases_url":"https://api.github.com/repos/mrunalp/runc/releases{/id}","deployments_url":"https://api.github.com/repos/mrunalp/runc/deployments","created_at":"2015-06-26T20:51:43Z","updated_at":"2015-06-26T20:51:44Z","pushed_at":"2016-12-07T19:08:43Z","git_url":"git://github.com/mrunalp/runc.git","ssh_url":"git@github.com:mrunalp/runc.git","clone_url":"https://github.com/mrunalp/runc.git","svn_url":"https://github.com/mrunalp/runc","homepage":"","size":3986,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"opencontainers:master","ref":"master","sha":"47ea5c75ebeb40a317d2cfa95f9c3536c00c1eea","user":{"login":"opencontainers","id":12563465,"avatar_url":"https://avatars.githubusercontent.com/u/12563465?v=3","gravatar_id":"","url":"https://api.github.com/users/opencontainers","html_url":"https://github.com/opencontainers","followers_url":"https://api.github.com/users/opencontainers/followers","following_url":"https://api.github.com/users/opencontainers/following{/other_user}","gists_url":"https://api.github.com/users/opencontainers/gists{/gist_id}","starred_url":"https://api.github.com/users/opencontainers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opencontainers/subscriptions","organizations_url":"https://api.github.com/users/opencontainers/orgs","repos_url":"https://api.github.com/users/opencontainers/repos","events_url":"https://api.github.com/users/opencontainers/events{/privacy}","received_events_url":"https://api.github.com/users/opencontainers/received_events","type":"Organization","site_admin":false},"repo":{"id":36960321,"name":"runc","full_name":"opencontainers/runc","owner":{"login":"opencontainers","id":12563465,"avatar_url":"https://avatars.githubusercontent.com/u/12563465?v=3","gravatar_id":"","url":"https://api.github.com/users/opencontainers","html_url":"https://github.com/opencontainers","followers_url":"https://api.github.com/users/opencontainers/followers","following_url":"https://api.github.com/users/opencontainers/following{/other_user}","gists_url":"https://api.github.com/users/opencontainers/gists{/gist_id}","starred_url":"https://api.github.com/users/opencontainers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opencontainers/subscriptions","organizations_url":"https://api.github.com/users/opencontainers/orgs","repos_url":"https://api.github.com/users/opencontainers/repos","events_url":"https://api.github.com/users/opencontainers/events{/privacy}","received_events_url":"https://api.github.com/users/opencontainers/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opencontainers/runc","description":"CLI tool for spawning and running containers according to the OCI specification","fork":false,"url":"https://api.github.com/repos/opencontainers/runc","forks_url":"https://api.github.com/repos/opencontainers/runc/forks","keys_url":"https://api.github.com/repos/opencontainers/runc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opencontainers/runc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opencontainers/runc/teams","hooks_url":"https://api.github.com/repos/opencontainers/runc/hooks","issue_events_url":"https://api.github.com/repos/opencontainers/runc/issues/events{/number}","events_url":"https://api.github.com/repos/opencontainers/runc/events","assignees_url":"https://api.github.com/repos/opencontainers/runc/assignees{/user}","branches_url":"https://api.github.com/repos/opencontainers/runc/branches{/branch}","tags_url":"https://api.github.com/repos/opencontainers/runc/tags","blobs_url":"https://api.github.com/repos/opencontainers/runc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opencontainers/runc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opencontainers/runc/git/refs{/sha}","trees_url":"https://api.github.com/repos/opencontainers/runc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opencontainers/runc/statuses/{sha}","languages_url":"https://api.github.com/repos/opencontainers/runc/languages","stargazers_url":"https://api.github.com/repos/opencontainers/runc/stargazers","contributors_url":"https://api.github.com/repos/opencontainers/runc/contributors","subscribers_url":"https://api.github.com/repos/opencontainers/runc/subscribers","subscription_url":"https://api.github.com/repos/opencontainers/runc/subscription","commits_url":"https://api.github.com/repos/opencontainers/runc/commits{/sha}","git_commits_url":"https://api.github.com/repos/opencontainers/runc/git/commits{/sha}","comments_url":"https://api.github.com/repos/opencontainers/runc/comments{/number}","issue_comment_url":"https://api.github.com/repos/opencontainers/runc/issues/comments{/number}","contents_url":"https://api.github.com/repos/opencontainers/runc/contents/{+path}","compare_url":"https://api.github.com/repos/opencontainers/runc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opencontainers/runc/merges","archive_url":"https://api.github.com/repos/opencontainers/runc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opencontainers/runc/downloads","issues_url":"https://api.github.com/repos/opencontainers/runc/issues{/number}","pulls_url":"https://api.github.com/repos/opencontainers/runc/pulls{/number}","milestones_url":"https://api.github.com/repos/opencontainers/runc/milestones{/number}","notifications_url":"https://api.github.com/repos/opencontainers/runc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opencontainers/runc/labels{/name}","releases_url":"https://api.github.com/repos/opencontainers/runc/releases{/id}","deployments_url":"https://api.github.com/repos/opencontainers/runc/deployments","created_at":"2015-06-05T23:30:45Z","updated_at":"2016-12-08T04:36:55Z","pushed_at":"2016-12-08T15:16:59Z","git_url":"git://github.com/opencontainers/runc.git","ssh_url":"git@github.com:opencontainers/runc.git","clone_url":"https://github.com/opencontainers/runc.git","svn_url":"https://github.com/opencontainers/runc","homepage":"https://www.opencontainers.org/","size":6728,"stargazers_count":3342,"watchers_count":3342,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":503,"mirror_url":null,"open_issues_count":98,"forks":503,"open_issues":98,"watchers":3342,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opencontainers/runc/pulls/1217"},"html":{"href":"https://github.com/opencontainers/runc/pull/1217"},"issue":{"href":"https://api.github.com/repos/opencontainers/runc/issues/1217"},"comments":{"href":"https://api.github.com/repos/opencontainers/runc/issues/1217/comments"},"review_comments":{"href":"https://api.github.com/repos/opencontainers/runc/pulls/1217/comments"},"review_comment":{"href":"https://api.github.com/repos/opencontainers/runc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opencontainers/runc/pulls/1217/commits"},"statuses":{"href":"https://api.github.com/repos/opencontainers/runc/statuses/8f55948aa5c97472c4a8ef6664b10ed662ce1df5"}}}}
{"actor":{"display_login":"rhatdan"}}