{"action":"created","comment":{"url":"https://api.github.com/repos/CiscoDevNet/ydk-gen/pulls/comments/66156443","id":66156443,"diff_hunk":"@@ -0,0 +1,150 @@\n+#  ----------------------------------------------------------------\n+# Copyright 2016 Cisco Systems\n+#\n+# Licensed under the Apache License, Version 2.0 (the \"License\");\n+# you may not use this file except in compliance with the License.\n+# You may obtain a copy of the License at\n+#\n+#    http://www.apache.org/licenses/LICENSE-2.0\n+#\n+# Unless required by applicable law or agreed to in writing, software\n+# distributed under the License is distributed on an \"AS IS\" BASIS,\n+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+# See the License for the specific language governing permissions and\n+# limitations under the License.\n+# ------------------------------------------------------------------\n+\n+import ydk.types as ytypes\n+import unittest\n+\n+from ydk.services import CRUDService\n+from ydk.models.ydktest import ydktest_sanity as ysanity\n+from ydk.models.ydktest import ydktest_sanity_types as ysanity_types\n+from ydk.providers import NetconfServiceProvider\n+from ydk.types import Empty, DELETE, Decimal64\n+from tests.compare import is_equal\n+from ydk.errors import YPYError, YPYModelError\n+\n+from ydk.models.ydktest.ydktest_sanity import YdkEnumTestEnum, YdkEnumIntTestEnum\n+\n+class SanityTest(unittest.TestCase):\n+\n+    @classmethod\n+    def setUpClass(self):\n+        self.ncc = NetconfServiceProvider(address='127.0.0.1',\n+            username='admin', password='admin', port=12022)\n+        self.crud = CRUDService()\n+\n+    @classmethod\n+    def tearDownClass(self):\n+        self.ncc.close()\n+\n+    def setUp(self):\n+        print \"\\nIn method\", self._testMethodName\n+        runner = ysanity.Runner()\n+        self.crud.delete(self.ncc, runner)\n+\n+    def tearDown(self):\n+        runner = ysanity.Runner()\n+        self.crud.delete(self.ncc, runner)\n+\n+    def _create_runner(self):\n+        runner = ysanity.Runner()\n+        runner.ytypes = runner.Ytypes()\n+        runner.ytypes.built_in_t = runner.ytypes.BuiltInT()\n+\n+        return runner\n+\n+    def test_int8_invalid(self):\n+        runner = self._create_runner()\n+        runner.ytypes.built_in_t.number8 = 8.5\n+        # self.crud.create(self.ncc, runner)","path":"sdk/python/tests/test_sanity_errors.py","position":61,"original_position":61,"commit_id":"86d951bfa211e43d0842d951048a1ad72e2dede8","original_commit_id":"86d951bfa211e43d0842d951048a1ad72e2dede8","user":{"login":"abhikeshav","id":17089095,"avatar_url":"https://avatars.githubusercontent.com/u/17089095?v=3","gravatar_id":"","url":"https://api.github.com/users/abhikeshav","html_url":"https://github.com/abhikeshav","followers_url":"https://api.github.com/users/abhikeshav/followers","following_url":"https://api.github.com/users/abhikeshav/following{/other_user}","gists_url":"https://api.github.com/users/abhikeshav/gists{/gist_id}","starred_url":"https://api.github.com/users/abhikeshav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abhikeshav/subscriptions","organizations_url":"https://api.github.com/users/abhikeshav/orgs","repos_url":"https://api.github.com/users/abhikeshav/repos","events_url":"https://api.github.com/users/abhikeshav/events{/privacy}","received_events_url":"https://api.github.com/users/abhikeshav/received_events","type":"User","site_admin":false},"body":"Can these commented lines be removed?","created_at":"2016-06-07T21:29:08Z","updated_at":"2016-06-07T21:29:08Z","html_url":"https://github.com/CiscoDevNet/ydk-gen/pull/147#discussion_r66156443","pull_request_url":"https://api.github.com/repos/CiscoDevNet/ydk-gen/pulls/147","_links":{"self":{"href":"https://api.github.com/repos/CiscoDevNet/ydk-gen/pulls/comments/66156443"},"html":{"href":"https://github.com/CiscoDevNet/ydk-gen/pull/147#discussion_r66156443"},"pull_request":{"href":"https://api.github.com/repos/CiscoDevNet/ydk-gen/pulls/147"}}},"pull_request":{"url":"https://api.github.com/repos/CiscoDevNet/ydk-gen/pulls/147","id":72949777,"html_url":"https://github.com/CiscoDevNet/ydk-gen/pull/147","diff_url":"https://github.com/CiscoDevNet/ydk-gen/pull/147.diff","patch_url":"https://github.com/CiscoDevNet/ydk-gen/pull/147.patch","issue_url":"https://api.github.com/repos/CiscoDevNet/ydk-gen/issues/147","number":147,"state":"open","locked":false,"title":"improved error hierarchy","user":{"login":"ylil93","id":5758180,"avatar_url":"https://avatars.githubusercontent.com/u/5758180?v=3","gravatar_id":"","url":"https://api.github.com/users/ylil93","html_url":"https://github.com/ylil93","followers_url":"https://api.github.com/users/ylil93/followers","following_url":"https://api.github.com/users/ylil93/following{/other_user}","gists_url":"https://api.github.com/users/ylil93/gists{/gist_id}","starred_url":"https://api.github.com/users/ylil93/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ylil93/subscriptions","organizations_url":"https://api.github.com/users/ylil93/orgs","repos_url":"https://api.github.com/users/ylil93/repos","events_url":"https://api.github.com/users/ylil93/events{/privacy}","received_events_url":"https://api.github.com/users/ylil93/received_events","type":"User","site_admin":false},"body":"- YPYDataValidation renamed to YPYModelError\r\n- introduced YPYServiceError, YPYServiceProviderError\r\n- updated error messaging/raised errors","created_at":"2016-06-07T21:15:31Z","updated_at":"2016-06-07T21:29:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"022a70661510e446fe9e6fa6742a9cee4a0ed824","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/CiscoDevNet/ydk-gen/pulls/147/commits","review_comments_url":"https://api.github.com/repos/CiscoDevNet/ydk-gen/pulls/147/comments","review_comment_url":"https://api.github.com/repos/CiscoDevNet/ydk-gen/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CiscoDevNet/ydk-gen/issues/147/comments","statuses_url":"https://api.github.com/repos/CiscoDevNet/ydk-gen/statuses/86d951bfa211e43d0842d951048a1ad72e2dede8","head":{"label":"ylil93:master","ref":"master","sha":"86d951bfa211e43d0842d951048a1ad72e2dede8","user":{"login":"ylil93","id":5758180,"avatar_url":"https://avatars.githubusercontent.com/u/5758180?v=3","gravatar_id":"","url":"https://api.github.com/users/ylil93","html_url":"https://github.com/ylil93","followers_url":"https://api.github.com/users/ylil93/followers","following_url":"https://api.github.com/users/ylil93/following{/other_user}","gists_url":"https://api.github.com/users/ylil93/gists{/gist_id}","starred_url":"https://api.github.com/users/ylil93/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ylil93/subscriptions","organizations_url":"https://api.github.com/users/ylil93/orgs","repos_url":"https://api.github.com/users/ylil93/repos","events_url":"https://api.github.com/users/ylil93/events{/privacy}","received_events_url":"https://api.github.com/users/ylil93/received_events","type":"User","site_admin":false},"repo":{"id":57067769,"name":"ydk-gen","full_name":"ylil93/ydk-gen","owner":{"login":"ylil93","id":5758180,"avatar_url":"https://avatars.githubusercontent.com/u/5758180?v=3","gravatar_id":"","url":"https://api.github.com/users/ylil93","html_url":"https://github.com/ylil93","followers_url":"https://api.github.com/users/ylil93/followers","following_url":"https://api.github.com/users/ylil93/following{/other_user}","gists_url":"https://api.github.com/users/ylil93/gists{/gist_id}","starred_url":"https://api.github.com/users/ylil93/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ylil93/subscriptions","organizations_url":"https://api.github.com/users/ylil93/orgs","repos_url":"https://api.github.com/users/ylil93/repos","events_url":"https://api.github.com/users/ylil93/events{/privacy}","received_events_url":"https://api.github.com/users/ylil93/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ylil93/ydk-gen","description":"Extensions to pyang for generating code from yang models.","fork":true,"url":"https://api.github.com/repos/ylil93/ydk-gen","forks_url":"https://api.github.com/repos/ylil93/ydk-gen/forks","keys_url":"https://api.github.com/repos/ylil93/ydk-gen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ylil93/ydk-gen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ylil93/ydk-gen/teams","hooks_url":"https://api.github.com/repos/ylil93/ydk-gen/hooks","issue_events_url":"https://api.github.com/repos/ylil93/ydk-gen/issues/events{/number}","events_url":"https://api.github.com/repos/ylil93/ydk-gen/events","assignees_url":"https://api.github.com/repos/ylil93/ydk-gen/assignees{/user}","branches_url":"https://api.github.com/repos/ylil93/ydk-gen/branches{/branch}","tags_url":"https://api.github.com/repos/ylil93/ydk-gen/tags","blobs_url":"https://api.github.com/repos/ylil93/ydk-gen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ylil93/ydk-gen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ylil93/ydk-gen/git/refs{/sha}","trees_url":"https://api.github.com/repos/ylil93/ydk-gen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ylil93/ydk-gen/statuses/{sha}","languages_url":"https://api.github.com/repos/ylil93/ydk-gen/languages","stargazers_url":"https://api.github.com/repos/ylil93/ydk-gen/stargazers","contributors_url":"https://api.github.com/repos/ylil93/ydk-gen/contributors","subscribers_url":"https://api.github.com/repos/ylil93/ydk-gen/subscribers","subscription_url":"https://api.github.com/repos/ylil93/ydk-gen/subscription","commits_url":"https://api.github.com/repos/ylil93/ydk-gen/commits{/sha}","git_commits_url":"https://api.github.com/repos/ylil93/ydk-gen/git/commits{/sha}","comments_url":"https://api.github.com/repos/ylil93/ydk-gen/comments{/number}","issue_comment_url":"https://api.github.com/repos/ylil93/ydk-gen/issues/comments{/number}","contents_url":"https://api.github.com/repos/ylil93/ydk-gen/contents/{+path}","compare_url":"https://api.github.com/repos/ylil93/ydk-gen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ylil93/ydk-gen/merges","archive_url":"https://api.github.com/repos/ylil93/ydk-gen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ylil93/ydk-gen/downloads","issues_url":"https://api.github.com/repos/ylil93/ydk-gen/issues{/number}","pulls_url":"https://api.github.com/repos/ylil93/ydk-gen/pulls{/number}","milestones_url":"https://api.github.com/repos/ylil93/ydk-gen/milestones{/number}","notifications_url":"https://api.github.com/repos/ylil93/ydk-gen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ylil93/ydk-gen/labels{/name}","releases_url":"https://api.github.com/repos/ylil93/ydk-gen/releases{/id}","deployments_url":"https://api.github.com/repos/ylil93/ydk-gen/deployments","created_at":"2016-04-25T18:57:04Z","updated_at":"2016-04-25T18:57:05Z","pushed_at":"2016-06-07T21:12:53Z","git_url":"git://github.com/ylil93/ydk-gen.git","ssh_url":"git@github.com:ylil93/ydk-gen.git","clone_url":"https://github.com/ylil93/ydk-gen.git","svn_url":"https://github.com/ylil93/ydk-gen","homepage":null,"size":563,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"CiscoDevNet:master","ref":"master","sha":"b035cf1312842762de63aef924f42a8a72d5f60c","user":{"login":"CiscoDevNet","id":8827988,"avatar_url":"https://avatars.githubusercontent.com/u/8827988?v=3","gravatar_id":"","url":"https://api.github.com/users/CiscoDevNet","html_url":"https://github.com/CiscoDevNet","followers_url":"https://api.github.com/users/CiscoDevNet/followers","following_url":"https://api.github.com/users/CiscoDevNet/following{/other_user}","gists_url":"https://api.github.com/users/CiscoDevNet/gists{/gist_id}","starred_url":"https://api.github.com/users/CiscoDevNet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CiscoDevNet/subscriptions","organizations_url":"https://api.github.com/users/CiscoDevNet/orgs","repos_url":"https://api.github.com/users/CiscoDevNet/repos","events_url":"https://api.github.com/users/CiscoDevNet/events{/privacy}","received_events_url":"https://api.github.com/users/CiscoDevNet/received_events","type":"Organization","site_admin":false},"repo":{"id":53680541,"name":"ydk-gen","full_name":"CiscoDevNet/ydk-gen","owner":{"login":"CiscoDevNet","id":8827988,"avatar_url":"https://avatars.githubusercontent.com/u/8827988?v=3","gravatar_id":"","url":"https://api.github.com/users/CiscoDevNet","html_url":"https://github.com/CiscoDevNet","followers_url":"https://api.github.com/users/CiscoDevNet/followers","following_url":"https://api.github.com/users/CiscoDevNet/following{/other_user}","gists_url":"https://api.github.com/users/CiscoDevNet/gists{/gist_id}","starred_url":"https://api.github.com/users/CiscoDevNet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CiscoDevNet/subscriptions","organizations_url":"https://api.github.com/users/CiscoDevNet/orgs","repos_url":"https://api.github.com/users/CiscoDevNet/repos","events_url":"https://api.github.com/users/CiscoDevNet/events{/privacy}","received_events_url":"https://api.github.com/users/CiscoDevNet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CiscoDevNet/ydk-gen","description":"Extensions to pyang for generating code from yang models.","fork":false,"url":"https://api.github.com/repos/CiscoDevNet/ydk-gen","forks_url":"https://api.github.com/repos/CiscoDevNet/ydk-gen/forks","keys_url":"https://api.github.com/repos/CiscoDevNet/ydk-gen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CiscoDevNet/ydk-gen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CiscoDevNet/ydk-gen/teams","hooks_url":"https://api.github.com/repos/CiscoDevNet/ydk-gen/hooks","issue_events_url":"https://api.github.com/repos/CiscoDevNet/ydk-gen/issues/events{/number}","events_url":"https://api.github.com/repos/CiscoDevNet/ydk-gen/events","assignees_url":"https://api.github.com/repos/CiscoDevNet/ydk-gen/assignees{/user}","branches_url":"https://api.github.com/repos/CiscoDevNet/ydk-gen/branches{/branch}","tags_url":"https://api.github.com/repos/CiscoDevNet/ydk-gen/tags","blobs_url":"https://api.github.com/repos/CiscoDevNet/ydk-gen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CiscoDevNet/ydk-gen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CiscoDevNet/ydk-gen/git/refs{/sha}","trees_url":"https://api.github.com/repos/CiscoDevNet/ydk-gen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CiscoDevNet/ydk-gen/statuses/{sha}","languages_url":"https://api.github.com/repos/CiscoDevNet/ydk-gen/languages","stargazers_url":"https://api.github.com/repos/CiscoDevNet/ydk-gen/stargazers","contributors_url":"https://api.github.com/repos/CiscoDevNet/ydk-gen/contributors","subscribers_url":"https://api.github.com/repos/CiscoDevNet/ydk-gen/subscribers","subscription_url":"https://api.github.com/repos/CiscoDevNet/ydk-gen/subscription","commits_url":"https://api.github.com/repos/CiscoDevNet/ydk-gen/commits{/sha}","git_commits_url":"https://api.github.com/repos/CiscoDevNet/ydk-gen/git/commits{/sha}","comments_url":"https://api.github.com/repos/CiscoDevNet/ydk-gen/comments{/number}","issue_comment_url":"https://api.github.com/repos/CiscoDevNet/ydk-gen/issues/comments{/number}","contents_url":"https://api.github.com/repos/CiscoDevNet/ydk-gen/contents/{+path}","compare_url":"https://api.github.com/repos/CiscoDevNet/ydk-gen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CiscoDevNet/ydk-gen/merges","archive_url":"https://api.github.com/repos/CiscoDevNet/ydk-gen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CiscoDevNet/ydk-gen/downloads","issues_url":"https://api.github.com/repos/CiscoDevNet/ydk-gen/issues{/number}","pulls_url":"https://api.github.com/repos/CiscoDevNet/ydk-gen/pulls{/number}","milestones_url":"https://api.github.com/repos/CiscoDevNet/ydk-gen/milestones{/number}","notifications_url":"https://api.github.com/repos/CiscoDevNet/ydk-gen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CiscoDevNet/ydk-gen/labels{/name}","releases_url":"https://api.github.com/repos/CiscoDevNet/ydk-gen/releases{/id}","deployments_url":"https://api.github.com/repos/CiscoDevNet/ydk-gen/deployments","created_at":"2016-03-11T16:27:20Z","updated_at":"2016-06-07T16:04:49Z","pushed_at":"2016-06-07T21:15:31Z","git_url":"git://github.com/CiscoDevNet/ydk-gen.git","ssh_url":"git@github.com:CiscoDevNet/ydk-gen.git","clone_url":"https://github.com/CiscoDevNet/ydk-gen.git","svn_url":"https://github.com/CiscoDevNet/ydk-gen","homepage":null,"size":578,"stargazers_count":12,"watchers_count":12,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":38,"forks":11,"open_issues":38,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CiscoDevNet/ydk-gen/pulls/147"},"html":{"href":"https://github.com/CiscoDevNet/ydk-gen/pull/147"},"issue":{"href":"https://api.github.com/repos/CiscoDevNet/ydk-gen/issues/147"},"comments":{"href":"https://api.github.com/repos/CiscoDevNet/ydk-gen/issues/147/comments"},"review_comments":{"href":"https://api.github.com/repos/CiscoDevNet/ydk-gen/pulls/147/comments"},"review_comment":{"href":"https://api.github.com/repos/CiscoDevNet/ydk-gen/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CiscoDevNet/ydk-gen/pulls/147/commits"},"statuses":{"href":"https://api.github.com/repos/CiscoDevNet/ydk-gen/statuses/86d951bfa211e43d0842d951048a1ad72e2dede8"}}}}
{"actor":{"display_login":"abhikeshav"}}