{"action":"created","issue":{"url":"https://api.github.com/repos/pithos/pithos/issues/292","repository_url":"https://api.github.com/repos/pithos/pithos","labels_url":"https://api.github.com/repos/pithos/pithos/issues/292/labels{/name}","comments_url":"https://api.github.com/repos/pithos/pithos/issues/292/comments","events_url":"https://api.github.com/repos/pithos/pithos/issues/292/events","html_url":"https://github.com/pithos/pithos/issues/292","id":148940304,"number":292,"title":"Proper Ad support","user":{"login":"JasonLG1979","id":6667703,"avatar_url":"https://avatars.githubusercontent.com/u/6667703?v=3","gravatar_id":"","url":"https://api.github.com/users/JasonLG1979","html_url":"https://github.com/JasonLG1979","followers_url":"https://api.github.com/users/JasonLG1979/followers","following_url":"https://api.github.com/users/JasonLG1979/following{/other_user}","gists_url":"https://api.github.com/users/JasonLG1979/gists{/gist_id}","starred_url":"https://api.github.com/users/JasonLG1979/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JasonLG1979/subscriptions","organizations_url":"https://api.github.com/users/JasonLG1979/orgs","repos_url":"https://api.github.com/users/JasonLG1979/repos","events_url":"https://api.github.com/users/JasonLG1979/events{/privacy}","received_events_url":"https://api.github.com/users/JasonLG1979/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/pithos/pithos/labels/discussion","name":"discussion","color":"bfe5bf"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":24,"created_at":"2016-04-17T10:46:34Z","updated_at":"2016-07-27T11:03:41Z","closed_at":null,"body":"Reading up on the docs and poking though pandora.py I believe I've come up with proper ad support for Pithos. Turns out we were skipping ads all alone. Every playlist for free users contains a \"song\" that just contains an adToken. We were skipping it by checking for 'songName' in the playlist values.\r\n\r\nProper ad support has it's pluses and minuses.\r\n\r\nOn the plus side you can actually see ads in the playlist before they play, we would be supporting Pandora's revenue stream(no Pandora, no Pithos) since the ads can be \"registered\" so Pandora knows you heard them and hopefully as a side effect of that we could get less ads masquerading as songs.\r\n\r\nOn the minus side it would probably mean more ads for free users(Pandora One users never get ads). As I said before so far in my tests there's been an ad in just about every playlist.(so every 5th track), although there's still nothing to stop people from skipping them if they want.\r\n\r\nHere's a screenshot of an upcoming ad in the playlist of my testing free account.\r\n \r\n![screenshot from 2016-04-17 05-28-21](https://cloud.githubusercontent.com/assets/6667703/14586485/4ddc1c0a-045f-11e6-9d2b-ff9805fab680.png)\r\n   "},"comment":{"url":"https://api.github.com/repos/pithos/pithos/issues/comments/235554407","html_url":"https://github.com/pithos/pithos/issues/292#issuecomment-235554407","issue_url":"https://api.github.com/repos/pithos/pithos/issues/292","id":235554407,"user":{"login":"JasonLG1979","id":6667703,"avatar_url":"https://avatars.githubusercontent.com/u/6667703?v=3","gravatar_id":"","url":"https://api.github.com/users/JasonLG1979","html_url":"https://github.com/JasonLG1979","followers_url":"https://api.github.com/users/JasonLG1979/followers","following_url":"https://api.github.com/users/JasonLG1979/following{/other_user}","gists_url":"https://api.github.com/users/JasonLG1979/gists{/gist_id}","starred_url":"https://api.github.com/users/JasonLG1979/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JasonLG1979/subscriptions","organizations_url":"https://api.github.com/users/JasonLG1979/orgs","repos_url":"https://api.github.com/users/JasonLG1979/repos","events_url":"https://api.github.com/users/JasonLG1979/events{/privacy}","received_events_url":"https://api.github.com/users/JasonLG1979/received_events","type":"User","site_admin":false},"created_at":"2016-07-27T11:03:41Z","updated_at":"2016-07-27T11:03:41Z","body":"You're the one that keeps bringing up politics and religion for some reason?.. It not about my views it's about trying to do things properly from a technical stand point(use the the API correctly as we can) and a ethical point of view(very basically skipping ads is stealing you can paint it how you like and call it what you want but it's taking the service without paying for it.)"}}
{"actor":{"display_login":"JasonLG1979"}}