{"action":"created","comment":{"url":"https://api.github.com/repos/nunit/nunit/pulls/comments/94254962","pull_request_review_id":14786276,"id":94254962,"diff_hunk":"@@ -124,20 +124,25 @@ public ITest Build(string assemblyName, IDictionary<string, object> options)\n \n         private TestSuite Build(Assembly assembly, string assemblyPath, IDictionary<string, object> options)\n         {\n-            TestSuite testAssembly = null;\n-\n             try\n             {\n-                if (options.ContainsKey(FrameworkPackageSettings.DefaultTestNamePattern))\n-                    TestNameGenerator.DefaultTestNamePattern = options[FrameworkPackageSettings.DefaultTestNamePattern] as string;\n+                var testNamePattern = GetValueOrDefault(options, FrameworkPackageSettings.DefaultTestNamePattern) as string;\n+                if (testNamePattern != null) TestNameGenerator.DefaultTestNamePattern = testNamePattern;","path":"src/NUnitFramework/framework/Api/DefaultTestAssemblyBuilder.cs","position":11,"original_position":11,"commit_id":"0426e4c30290d270918fe952a49bf509ff923025","original_commit_id":"0426e4c30290d270918fe952a49bf509ff923025","user":{"login":"CharliePoole","id":2678661,"avatar_url":"https://avatars.githubusercontent.com/u/2678661?v=3","gravatar_id":"","url":"https://api.github.com/users/CharliePoole","html_url":"https://github.com/CharliePoole","followers_url":"https://api.github.com/users/CharliePoole/followers","following_url":"https://api.github.com/users/CharliePoole/following{/other_user}","gists_url":"https://api.github.com/users/CharliePoole/gists{/gist_id}","starred_url":"https://api.github.com/users/CharliePoole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CharliePoole/subscriptions","organizations_url":"https://api.github.com/users/CharliePoole/orgs","repos_url":"https://api.github.com/users/CharliePoole/repos","events_url":"https://api.github.com/users/CharliePoole/events{/privacy}","received_events_url":"https://api.github.com/users/CharliePoole/received_events","type":"User","site_admin":false},"body":"Please don't arbitrarily change code that isn't relevant to the thing you are working on based on personal stylistic preferences.","created_at":"2016-12-30T20:09:21Z","updated_at":"2016-12-30T20:41:44Z","html_url":"https://github.com/nunit/nunit/pull/1942#discussion_r94254962","pull_request_url":"https://api.github.com/repos/nunit/nunit/pulls/1942","_links":{"self":{"href":"https://api.github.com/repos/nunit/nunit/pulls/comments/94254962"},"html":{"href":"https://github.com/nunit/nunit/pull/1942#discussion_r94254962"},"pull_request":{"href":"https://api.github.com/repos/nunit/nunit/pulls/1942"}}},"pull_request":{"url":"https://api.github.com/repos/nunit/nunit/pulls/1942","id":99597156,"html_url":"https://github.com/nunit/nunit/pull/1942","diff_url":"https://github.com/nunit/nunit/pull/1942.diff","patch_url":"https://github.com/nunit/nunit/pull/1942.patch","issue_url":"https://api.github.com/repos/nunit/nunit/issues/1942","number":1942,"state":"open","locked":false,"title":"Test parameter parsing out of framework","user":{"login":"jnm2","id":8040367,"avatar_url":"https://avatars.githubusercontent.com/u/8040367?v=3","gravatar_id":"","url":"https://api.github.com/users/jnm2","html_url":"https://github.com/jnm2","followers_url":"https://api.github.com/users/jnm2/followers","following_url":"https://api.github.com/users/jnm2/following{/other_user}","gists_url":"https://api.github.com/users/jnm2/gists{/gist_id}","starred_url":"https://api.github.com/users/jnm2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnm2/subscriptions","organizations_url":"https://api.github.com/users/jnm2/orgs","repos_url":"https://api.github.com/users/jnm2/repos","events_url":"https://api.github.com/users/jnm2/events{/privacy}","received_events_url":"https://api.github.com/users/jnm2/received_events","type":"User","site_admin":false},"body":"Umbrella: https://github.com/nunit/nunit/issues/1941","created_at":"2016-12-28T22:00:36Z","updated_at":"2016-12-30T20:41:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d9b7e2d5f6ad39e953921e20808c694925fd18af","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/nunit/nunit/pulls/1942/commits","review_comments_url":"https://api.github.com/repos/nunit/nunit/pulls/1942/comments","review_comment_url":"https://api.github.com/repos/nunit/nunit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nunit/nunit/issues/1942/comments","statuses_url":"https://api.github.com/repos/nunit/nunit/statuses/0426e4c30290d270918fe952a49bf509ff923025","head":{"label":"jnm2:testparam-parsing-out-of-framework","ref":"testparam-parsing-out-of-framework","sha":"0426e4c30290d270918fe952a49bf509ff923025","user":{"login":"jnm2","id":8040367,"avatar_url":"https://avatars.githubusercontent.com/u/8040367?v=3","gravatar_id":"","url":"https://api.github.com/users/jnm2","html_url":"https://github.com/jnm2","followers_url":"https://api.github.com/users/jnm2/followers","following_url":"https://api.github.com/users/jnm2/following{/other_user}","gists_url":"https://api.github.com/users/jnm2/gists{/gist_id}","starred_url":"https://api.github.com/users/jnm2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnm2/subscriptions","organizations_url":"https://api.github.com/users/jnm2/orgs","repos_url":"https://api.github.com/users/jnm2/repos","events_url":"https://api.github.com/users/jnm2/events{/privacy}","received_events_url":"https://api.github.com/users/jnm2/received_events","type":"User","site_admin":false},"repo":{"id":66736829,"name":"nunit","full_name":"jnm2/nunit","owner":{"login":"jnm2","id":8040367,"avatar_url":"https://avatars.githubusercontent.com/u/8040367?v=3","gravatar_id":"","url":"https://api.github.com/users/jnm2","html_url":"https://github.com/jnm2","followers_url":"https://api.github.com/users/jnm2/followers","following_url":"https://api.github.com/users/jnm2/following{/other_user}","gists_url":"https://api.github.com/users/jnm2/gists{/gist_id}","starred_url":"https://api.github.com/users/jnm2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnm2/subscriptions","organizations_url":"https://api.github.com/users/jnm2/orgs","repos_url":"https://api.github.com/users/jnm2/repos","events_url":"https://api.github.com/users/jnm2/events{/privacy}","received_events_url":"https://api.github.com/users/jnm2/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jnm2/nunit","description":"NUnit 3.0 Framework","fork":true,"url":"https://api.github.com/repos/jnm2/nunit","forks_url":"https://api.github.com/repos/jnm2/nunit/forks","keys_url":"https://api.github.com/repos/jnm2/nunit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jnm2/nunit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jnm2/nunit/teams","hooks_url":"https://api.github.com/repos/jnm2/nunit/hooks","issue_events_url":"https://api.github.com/repos/jnm2/nunit/issues/events{/number}","events_url":"https://api.github.com/repos/jnm2/nunit/events","assignees_url":"https://api.github.com/repos/jnm2/nunit/assignees{/user}","branches_url":"https://api.github.com/repos/jnm2/nunit/branches{/branch}","tags_url":"https://api.github.com/repos/jnm2/nunit/tags","blobs_url":"https://api.github.com/repos/jnm2/nunit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jnm2/nunit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jnm2/nunit/git/refs{/sha}","trees_url":"https://api.github.com/repos/jnm2/nunit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jnm2/nunit/statuses/{sha}","languages_url":"https://api.github.com/repos/jnm2/nunit/languages","stargazers_url":"https://api.github.com/repos/jnm2/nunit/stargazers","contributors_url":"https://api.github.com/repos/jnm2/nunit/contributors","subscribers_url":"https://api.github.com/repos/jnm2/nunit/subscribers","subscription_url":"https://api.github.com/repos/jnm2/nunit/subscription","commits_url":"https://api.github.com/repos/jnm2/nunit/commits{/sha}","git_commits_url":"https://api.github.com/repos/jnm2/nunit/git/commits{/sha}","comments_url":"https://api.github.com/repos/jnm2/nunit/comments{/number}","issue_comment_url":"https://api.github.com/repos/jnm2/nunit/issues/comments{/number}","contents_url":"https://api.github.com/repos/jnm2/nunit/contents/{+path}","compare_url":"https://api.github.com/repos/jnm2/nunit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jnm2/nunit/merges","archive_url":"https://api.github.com/repos/jnm2/nunit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jnm2/nunit/downloads","issues_url":"https://api.github.com/repos/jnm2/nunit/issues{/number}","pulls_url":"https://api.github.com/repos/jnm2/nunit/pulls{/number}","milestones_url":"https://api.github.com/repos/jnm2/nunit/milestones{/number}","notifications_url":"https://api.github.com/repos/jnm2/nunit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jnm2/nunit/labels{/name}","releases_url":"https://api.github.com/repos/jnm2/nunit/releases{/id}","deployments_url":"https://api.github.com/repos/jnm2/nunit/deployments","created_at":"2016-08-27T21:43:24Z","updated_at":"2016-11-21T22:23:55Z","pushed_at":"2016-12-28T18:54:35Z","git_url":"git://github.com/jnm2/nunit.git","ssh_url":"git@github.com:jnm2/nunit.git","clone_url":"https://github.com/jnm2/nunit.git","svn_url":"https://github.com/jnm2/nunit","homepage":"http://www.nunit.org/","size":31274,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"testparam-parsing-out-of-framework"}},"base":{"label":"nunit:master","ref":"master","sha":"d01935d8620f8f125bd1a77f89cb1fc8fd370910","user":{"login":"nunit","id":2678858,"avatar_url":"https://avatars.githubusercontent.com/u/2678858?v=3","gravatar_id":"","url":"https://api.github.com/users/nunit","html_url":"https://github.com/nunit","followers_url":"https://api.github.com/users/nunit/followers","following_url":"https://api.github.com/users/nunit/following{/other_user}","gists_url":"https://api.github.com/users/nunit/gists{/gist_id}","starred_url":"https://api.github.com/users/nunit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nunit/subscriptions","organizations_url":"https://api.github.com/users/nunit/orgs","repos_url":"https://api.github.com/users/nunit/repos","events_url":"https://api.github.com/users/nunit/events{/privacy}","received_events_url":"https://api.github.com/users/nunit/received_events","type":"Organization","site_admin":false},"repo":{"id":13692183,"name":"nunit","full_name":"nunit/nunit","owner":{"login":"nunit","id":2678858,"avatar_url":"https://avatars.githubusercontent.com/u/2678858?v=3","gravatar_id":"","url":"https://api.github.com/users/nunit","html_url":"https://github.com/nunit","followers_url":"https://api.github.com/users/nunit/followers","following_url":"https://api.github.com/users/nunit/following{/other_user}","gists_url":"https://api.github.com/users/nunit/gists{/gist_id}","starred_url":"https://api.github.com/users/nunit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nunit/subscriptions","organizations_url":"https://api.github.com/users/nunit/orgs","repos_url":"https://api.github.com/users/nunit/repos","events_url":"https://api.github.com/users/nunit/events{/privacy}","received_events_url":"https://api.github.com/users/nunit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nunit/nunit","description":"NUnit 3.0 Framework","fork":false,"url":"https://api.github.com/repos/nunit/nunit","forks_url":"https://api.github.com/repos/nunit/nunit/forks","keys_url":"https://api.github.com/repos/nunit/nunit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nunit/nunit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nunit/nunit/teams","hooks_url":"https://api.github.com/repos/nunit/nunit/hooks","issue_events_url":"https://api.github.com/repos/nunit/nunit/issues/events{/number}","events_url":"https://api.github.com/repos/nunit/nunit/events","assignees_url":"https://api.github.com/repos/nunit/nunit/assignees{/user}","branches_url":"https://api.github.com/repos/nunit/nunit/branches{/branch}","tags_url":"https://api.github.com/repos/nunit/nunit/tags","blobs_url":"https://api.github.com/repos/nunit/nunit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nunit/nunit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nunit/nunit/git/refs{/sha}","trees_url":"https://api.github.com/repos/nunit/nunit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nunit/nunit/statuses/{sha}","languages_url":"https://api.github.com/repos/nunit/nunit/languages","stargazers_url":"https://api.github.com/repos/nunit/nunit/stargazers","contributors_url":"https://api.github.com/repos/nunit/nunit/contributors","subscribers_url":"https://api.github.com/repos/nunit/nunit/subscribers","subscription_url":"https://api.github.com/repos/nunit/nunit/subscription","commits_url":"https://api.github.com/repos/nunit/nunit/commits{/sha}","git_commits_url":"https://api.github.com/repos/nunit/nunit/git/commits{/sha}","comments_url":"https://api.github.com/repos/nunit/nunit/comments{/number}","issue_comment_url":"https://api.github.com/repos/nunit/nunit/issues/comments{/number}","contents_url":"https://api.github.com/repos/nunit/nunit/contents/{+path}","compare_url":"https://api.github.com/repos/nunit/nunit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nunit/nunit/merges","archive_url":"https://api.github.com/repos/nunit/nunit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nunit/nunit/downloads","issues_url":"https://api.github.com/repos/nunit/nunit/issues{/number}","pulls_url":"https://api.github.com/repos/nunit/nunit/pulls{/number}","milestones_url":"https://api.github.com/repos/nunit/nunit/milestones{/number}","notifications_url":"https://api.github.com/repos/nunit/nunit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nunit/nunit/labels{/name}","releases_url":"https://api.github.com/repos/nunit/nunit/releases{/id}","deployments_url":"https://api.github.com/repos/nunit/nunit/deployments","created_at":"2013-10-18T23:43:29Z","updated_at":"2016-12-30T17:45:43Z","pushed_at":"2016-12-29T18:26:36Z","git_url":"git://github.com/nunit/nunit.git","ssh_url":"git@github.com:nunit/nunit.git","clone_url":"https://github.com/nunit/nunit.git","svn_url":"https://github.com/nunit/nunit","homepage":"http://www.nunit.org/","size":32097,"stargazers_count":839,"watchers_count":839,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":321,"mirror_url":null,"open_issues_count":211,"forks":321,"open_issues":211,"watchers":839,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nunit/nunit/pulls/1942"},"html":{"href":"https://github.com/nunit/nunit/pull/1942"},"issue":{"href":"https://api.github.com/repos/nunit/nunit/issues/1942"},"comments":{"href":"https://api.github.com/repos/nunit/nunit/issues/1942/comments"},"review_comments":{"href":"https://api.github.com/repos/nunit/nunit/pulls/1942/comments"},"review_comment":{"href":"https://api.github.com/repos/nunit/nunit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nunit/nunit/pulls/1942/commits"},"statuses":{"href":"https://api.github.com/repos/nunit/nunit/statuses/0426e4c30290d270918fe952a49bf509ff923025"}}}}
{"actor":{"display_login":"CharliePoole"}}