{"action":"created","issue":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/12516","repository_url":"https://api.github.com/repos/joomla/joomla-cms","labels_url":"https://api.github.com/repos/joomla/joomla-cms/issues/12516/labels{/name}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/12516/comments","events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/12516/events","html_url":"https://github.com/joomla/joomla-cms/pull/12516","id":184640281,"number":12516,"title":"[4.0] [WIP] Restructure Voting Plugin Integration","user":{"login":"mbabker","id":368545,"avatar_url":"https://avatars.githubusercontent.com/u/368545?v=3","gravatar_id":"","url":"https://api.github.com/users/mbabker","html_url":"https://github.com/mbabker","followers_url":"https://api.github.com/users/mbabker/followers","following_url":"https://api.github.com/users/mbabker/following{/other_user}","gists_url":"https://api.github.com/users/mbabker/gists{/gist_id}","starred_url":"https://api.github.com/users/mbabker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbabker/subscriptions","organizations_url":"https://api.github.com/users/mbabker/orgs","repos_url":"https://api.github.com/users/mbabker/repos","events_url":"https://api.github.com/users/mbabker/events{/privacy}","received_events_url":"https://api.github.com/users/mbabker/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/joomla/joomla-cms/labels/PR-4.0-dev","name":"PR-4.0-dev","color":"ededed"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-10-22T16:41:12Z","updated_at":"2016-10-22T16:55:36Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/12516","html_url":"https://github.com/joomla/joomla-cms/pull/12516","diff_url":"https://github.com/joomla/joomla-cms/pull/12516.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/12516.patch"},"body":"Pull Request for Issue #12331.\r\n\r\n### Summary of Changes\r\n\r\nMove the voting integration for com_content to be completely within the plugin\r\n\r\n- Parameters for the component config, article editor, and menu item views are all moved to the plugin and added via `onContentPrepareForm`\r\n- The controller and model tasks to save the vote are moved into the plugin to be used with com_ajax\r\n\r\n### Testing Instructions\r\n\r\nN/A yet, this is not yet in a working state because of one of the two TODO items below\r\n\r\n### Documentation Changes Required\r\n\r\nDocument the removed methods from the component\r\n\r\n### TODO Items\r\n\r\n- [x] Remove join for voting data from models (I started to do this and move it to `onContentPrepare` but this breaks the existing `onContentBeforeDisplay` event)\r\n- [ ] Wire in the AJAX submission part of this (the PHP code is done, just need to write the JavaScript to handle it)"},"comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments/255539989","html_url":"https://github.com/joomla/joomla-cms/pull/12516#issuecomment-255539989","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/12516","id":255539989,"user":{"login":"mbabker","id":368545,"avatar_url":"https://avatars.githubusercontent.com/u/368545?v=3","gravatar_id":"","url":"https://api.github.com/users/mbabker","html_url":"https://github.com/mbabker","followers_url":"https://api.github.com/users/mbabker/followers","following_url":"https://api.github.com/users/mbabker/following{/other_user}","gists_url":"https://api.github.com/users/mbabker/gists{/gist_id}","starred_url":"https://api.github.com/users/mbabker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbabker/subscriptions","organizations_url":"https://api.github.com/users/mbabker/orgs","repos_url":"https://api.github.com/users/mbabker/repos","events_url":"https://api.github.com/users/mbabker/events{/privacy}","received_events_url":"https://api.github.com/users/mbabker/received_events","type":"User","site_admin":false},"created_at":"2016-10-22T16:55:36Z","updated_at":"2016-10-22T16:55:36Z","body":"Query part was me messing stuff up.  That's handled now.  Just need to do the JavaScript."}}
{"actor":{"display_login":"mbabker"}}