{"action":"created","issue":{"url":"https://api.github.com/repos/ksss/digest-murmurhash/issues/3","repository_url":"https://api.github.com/repos/ksss/digest-murmurhash","labels_url":"https://api.github.com/repos/ksss/digest-murmurhash/issues/3/labels{/name}","comments_url":"https://api.github.com/repos/ksss/digest-murmurhash/issues/3/comments","events_url":"https://api.github.com/repos/ksss/digest-murmurhash/issues/3/events","html_url":"https://github.com/ksss/digest-murmurhash/issues/3","id":198137737,"number":3,"title":"Support for seed > 4 characters","user":{"login":"maksimf","id":860283,"avatar_url":"https://avatars.githubusercontent.com/u/860283?v=3","gravatar_id":"","url":"https://api.github.com/users/maksimf","html_url":"https://github.com/maksimf","followers_url":"https://api.github.com/users/maksimf/followers","following_url":"https://api.github.com/users/maksimf/following{/other_user}","gists_url":"https://api.github.com/users/maksimf/gists{/gist_id}","starred_url":"https://api.github.com/users/maksimf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maksimf/subscriptions","organizations_url":"https://api.github.com/users/maksimf/orgs","repos_url":"https://api.github.com/users/maksimf/repos","events_url":"https://api.github.com/users/maksimf/events{/privacy}","received_events_url":"https://api.github.com/users/maksimf/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-12-30T11:42:59Z","updated_at":"2016-12-30T13:56:14Z","closed_at":null,"body":"Now if I try to pass seed longer than 4 characters I get an `ArgumentError`:\r\n\r\n```ruby\r\nDigest::MurmurHash3_x86_32.rawdigest('foo', '1234567') \r\n# => ArgumentError: seed string should be 4 length\r\n```\r\n\r\nMoreover, I think that passing `Fixnum` as a seed should be supported as well:\r\n\r\n```ruby\r\nDigest::MurmurHash3_x86_32.rawdigest('qwe', 1234)\r\n# => TypeError: no implicit conversion of Fixnum into String\r\n```"},"comment":{"url":"https://api.github.com/repos/ksss/digest-murmurhash/issues/comments/269774223","html_url":"https://github.com/ksss/digest-murmurhash/issues/3#issuecomment-269774223","issue_url":"https://api.github.com/repos/ksss/digest-murmurhash/issues/3","id":269774223,"user":{"login":"ksss","id":935310,"avatar_url":"https://avatars.githubusercontent.com/u/935310?v=3","gravatar_id":"","url":"https://api.github.com/users/ksss","html_url":"https://github.com/ksss","followers_url":"https://api.github.com/users/ksss/followers","following_url":"https://api.github.com/users/ksss/following{/other_user}","gists_url":"https://api.github.com/users/ksss/gists{/gist_id}","starred_url":"https://api.github.com/users/ksss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ksss/subscriptions","organizations_url":"https://api.github.com/users/ksss/orgs","repos_url":"https://api.github.com/users/ksss/repos","events_url":"https://api.github.com/users/ksss/events{/privacy}","received_events_url":"https://api.github.com/users/ksss/received_events","type":"User","site_admin":false},"created_at":"2016-12-30T13:56:14Z","updated_at":"2016-12-30T13:56:14Z","body":"Thank you for using this gem :)\r\n\r\nI think it is useful when seed value have itself fit `uint32_t` or `uint64_t`\r\nLet me think about in this case\r\n\r\n```rb\r\nDigest::MurmurHash3_x86_32.rawdigest('qwe', 12345678901234567890)\r\n#=> cast to uint32_t? or raise error?\r\n```\r\n\r\n- Cast: I think it's too implicit. Which is endian?\r\n- Error: I think it's not usefull\r\n\r\nSo, I don't have good ideas\r\n\r\n---\r\n\r\nI recommend like this if you want to use a number.\r\n\r\n```rb\r\nDigest::MurmurHash3_x86_32.rawdigest('qwe', [1234].pack(\"L\"))\r\n=> 3180601568\r\n```"}}
{"actor":{"display_login":"ksss"}}