{"action":"created","comment":{"url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/pulls/comments/87633880","pull_request_review_id":8242101,"id":87633880,"diff_hunk":"@@ -109,51 +112,57 @@ namespace zkclient{\n \n \tvoid ZkClientDn::registerDataNode() {\n \t\t// TODO: Consider using startup time of the DN along with the ip and port\n-\t\t// TODO: Handle error\n-\n \t\tint error_code;\n-        bool exists;\n+\t\tbool exists;\n \n-        std::string id = build_datanode_id(data_node_id);\n-        // TODO: Add a watcher on the health node\n+\t\tstd::string id = build_datanode_id(data_node_id);\n+\t\t// TODO: Add a watcher on the health node\n \t\tif (zk->exists(HEALTH_BACKSLASH + id, exists, error_code)) {","path":"zookeeper/source/zk_dn_client.cc","position":143,"original_position":126,"commit_id":"c0c0273002b3759a57e85f87223d8ab6bee2918b","original_commit_id":"b84b574d24eb38930d23bca41ad8e0b3b5fedb50","user":{"login":"agardella","id":6759648,"avatar_url":"https://avatars.githubusercontent.com/u/6759648?v=3","gravatar_id":"","url":"https://api.github.com/users/agardella","html_url":"https://github.com/agardella","followers_url":"https://api.github.com/users/agardella/followers","following_url":"https://api.github.com/users/agardella/following{/other_user}","gists_url":"https://api.github.com/users/agardella/gists{/gist_id}","starred_url":"https://api.github.com/users/agardella/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agardella/subscriptions","organizations_url":"https://api.github.com/users/agardella/orgs","repos_url":"https://api.github.com/users/agardella/repos","events_url":"https://api.github.com/users/agardella/events{/privacy}","received_events_url":"https://api.github.com/users/agardella/received_events","type":"User","site_admin":false},"body":"Fixed","created_at":"2016-11-11T18:24:33Z","updated_at":"2016-11-11T18:24:33Z","html_url":"https://github.com/Rice-Comp413-2016/RDFS/pull/49#discussion_r87633880","pull_request_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/pulls/49","_links":{"self":{"href":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/pulls/comments/87633880"},"html":{"href":"https://github.com/Rice-Comp413-2016/RDFS/pull/49#discussion_r87633880"},"pull_request":{"href":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/pulls/49"}}},"pull_request":{"url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/pulls/49","id":93045140,"html_url":"https://github.com/Rice-Comp413-2016/RDFS/pull/49","diff_url":"https://github.com/Rice-Comp413-2016/RDFS/pull/49.diff","patch_url":"https://github.com/Rice-Comp413-2016/RDFS/pull/49.patch","issue_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/issues/49","number":49,"state":"open","locked":false,"title":"Zk dn client","user":{"login":"agardella","id":6759648,"avatar_url":"https://avatars.githubusercontent.com/u/6759648?v=3","gravatar_id":"","url":"https://api.github.com/users/agardella","html_url":"https://github.com/agardella","followers_url":"https://api.github.com/users/agardella/followers","following_url":"https://api.github.com/users/agardella/following{/other_user}","gists_url":"https://api.github.com/users/agardella/gists{/gist_id}","starred_url":"https://api.github.com/users/agardella/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agardella/subscriptions","organizations_url":"https://api.github.com/users/agardella/orgs","repos_url":"https://api.github.com/users/agardella/repos","events_url":"https://api.github.com/users/agardella/events{/privacy}","received_events_url":"https://api.github.com/users/agardella/received_events","type":"User","site_admin":false},"body":"Now writes the block size to /health/<datanode_id>/blocks/<block_uuid>\r\n@captain695 @cburk @nichhk \r\nDon't delete the branch after merging","created_at":"2016-11-09T21:48:26Z","updated_at":"2016-11-11T18:24:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6b9024922b896487caa8e19d0220d7b09a7e7bdd","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/pulls/49/commits","review_comments_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/pulls/49/comments","review_comment_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/issues/49/comments","statuses_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/statuses/c0c0273002b3759a57e85f87223d8ab6bee2918b","head":{"label":"Rice-Comp413-2016:zk-dn-client","ref":"zk-dn-client","sha":"c0c0273002b3759a57e85f87223d8ab6bee2918b","user":{"login":"Rice-Comp413-2016","id":21268758,"avatar_url":"https://avatars.githubusercontent.com/u/21268758?v=3","gravatar_id":"","url":"https://api.github.com/users/Rice-Comp413-2016","html_url":"https://github.com/Rice-Comp413-2016","followers_url":"https://api.github.com/users/Rice-Comp413-2016/followers","following_url":"https://api.github.com/users/Rice-Comp413-2016/following{/other_user}","gists_url":"https://api.github.com/users/Rice-Comp413-2016/gists{/gist_id}","starred_url":"https://api.github.com/users/Rice-Comp413-2016/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rice-Comp413-2016/subscriptions","organizations_url":"https://api.github.com/users/Rice-Comp413-2016/orgs","repos_url":"https://api.github.com/users/Rice-Comp413-2016/repos","events_url":"https://api.github.com/users/Rice-Comp413-2016/events{/privacy}","received_events_url":"https://api.github.com/users/Rice-Comp413-2016/received_events","type":"Organization","site_admin":false},"repo":{"id":66678304,"name":"RDFS","full_name":"Rice-Comp413-2016/RDFS","owner":{"login":"Rice-Comp413-2016","id":21268758,"avatar_url":"https://avatars.githubusercontent.com/u/21268758?v=3","gravatar_id":"","url":"https://api.github.com/users/Rice-Comp413-2016","html_url":"https://github.com/Rice-Comp413-2016","followers_url":"https://api.github.com/users/Rice-Comp413-2016/followers","following_url":"https://api.github.com/users/Rice-Comp413-2016/following{/other_user}","gists_url":"https://api.github.com/users/Rice-Comp413-2016/gists{/gist_id}","starred_url":"https://api.github.com/users/Rice-Comp413-2016/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rice-Comp413-2016/subscriptions","organizations_url":"https://api.github.com/users/Rice-Comp413-2016/orgs","repos_url":"https://api.github.com/users/Rice-Comp413-2016/repos","events_url":"https://api.github.com/users/Rice-Comp413-2016/events{/privacy}","received_events_url":"https://api.github.com/users/Rice-Comp413-2016/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Rice-Comp413-2016/RDFS","description":"The Rice Comp413 class (2016-2017) implementation of HDFS. (This will eventually be put under an open source license, which one TBD).","fork":false,"url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS","forks_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/forks","keys_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/teams","hooks_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/hooks","issue_events_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/issues/events{/number}","events_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/events","assignees_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/assignees{/user}","branches_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/branches{/branch}","tags_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/tags","blobs_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/git/refs{/sha}","trees_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/statuses/{sha}","languages_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/languages","stargazers_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/stargazers","contributors_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/contributors","subscribers_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/subscribers","subscription_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/subscription","commits_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/commits{/sha}","git_commits_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/git/commits{/sha}","comments_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/comments{/number}","issue_comment_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/issues/comments{/number}","contents_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/contents/{+path}","compare_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/merges","archive_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/downloads","issues_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/issues{/number}","pulls_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/pulls{/number}","milestones_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/milestones{/number}","notifications_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/labels{/name}","releases_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/releases{/id}","deployments_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/deployments","created_at":"2016-08-26T20:46:18Z","updated_at":"2016-10-05T20:44:06Z","pushed_at":"2016-11-11T17:56:32Z","git_url":"git://github.com/Rice-Comp413-2016/RDFS.git","ssh_url":"git@github.com:Rice-Comp413-2016/RDFS.git","clone_url":"https://github.com/Rice-Comp413-2016/RDFS.git","svn_url":"https://github.com/Rice-Comp413-2016/RDFS","homepage":"","size":1143,"stargazers_count":1,"watchers_count":1,"language":"Protocol Buffer","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":14,"forks":1,"open_issues":14,"watchers":1,"default_branch":"master"}},"base":{"label":"Rice-Comp413-2016:develop","ref":"develop","sha":"1f413e799f2502c96be47a1f04b7900187a140a9","user":{"login":"Rice-Comp413-2016","id":21268758,"avatar_url":"https://avatars.githubusercontent.com/u/21268758?v=3","gravatar_id":"","url":"https://api.github.com/users/Rice-Comp413-2016","html_url":"https://github.com/Rice-Comp413-2016","followers_url":"https://api.github.com/users/Rice-Comp413-2016/followers","following_url":"https://api.github.com/users/Rice-Comp413-2016/following{/other_user}","gists_url":"https://api.github.com/users/Rice-Comp413-2016/gists{/gist_id}","starred_url":"https://api.github.com/users/Rice-Comp413-2016/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rice-Comp413-2016/subscriptions","organizations_url":"https://api.github.com/users/Rice-Comp413-2016/orgs","repos_url":"https://api.github.com/users/Rice-Comp413-2016/repos","events_url":"https://api.github.com/users/Rice-Comp413-2016/events{/privacy}","received_events_url":"https://api.github.com/users/Rice-Comp413-2016/received_events","type":"Organization","site_admin":false},"repo":{"id":66678304,"name":"RDFS","full_name":"Rice-Comp413-2016/RDFS","owner":{"login":"Rice-Comp413-2016","id":21268758,"avatar_url":"https://avatars.githubusercontent.com/u/21268758?v=3","gravatar_id":"","url":"https://api.github.com/users/Rice-Comp413-2016","html_url":"https://github.com/Rice-Comp413-2016","followers_url":"https://api.github.com/users/Rice-Comp413-2016/followers","following_url":"https://api.github.com/users/Rice-Comp413-2016/following{/other_user}","gists_url":"https://api.github.com/users/Rice-Comp413-2016/gists{/gist_id}","starred_url":"https://api.github.com/users/Rice-Comp413-2016/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rice-Comp413-2016/subscriptions","organizations_url":"https://api.github.com/users/Rice-Comp413-2016/orgs","repos_url":"https://api.github.com/users/Rice-Comp413-2016/repos","events_url":"https://api.github.com/users/Rice-Comp413-2016/events{/privacy}","received_events_url":"https://api.github.com/users/Rice-Comp413-2016/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Rice-Comp413-2016/RDFS","description":"The Rice Comp413 class (2016-2017) implementation of HDFS. (This will eventually be put under an open source license, which one TBD).","fork":false,"url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS","forks_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/forks","keys_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/teams","hooks_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/hooks","issue_events_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/issues/events{/number}","events_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/events","assignees_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/assignees{/user}","branches_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/branches{/branch}","tags_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/tags","blobs_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/git/refs{/sha}","trees_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/statuses/{sha}","languages_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/languages","stargazers_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/stargazers","contributors_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/contributors","subscribers_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/subscribers","subscription_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/subscription","commits_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/commits{/sha}","git_commits_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/git/commits{/sha}","comments_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/comments{/number}","issue_comment_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/issues/comments{/number}","contents_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/contents/{+path}","compare_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/merges","archive_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/downloads","issues_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/issues{/number}","pulls_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/pulls{/number}","milestones_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/milestones{/number}","notifications_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/labels{/name}","releases_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/releases{/id}","deployments_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/deployments","created_at":"2016-08-26T20:46:18Z","updated_at":"2016-10-05T20:44:06Z","pushed_at":"2016-11-11T17:56:32Z","git_url":"git://github.com/Rice-Comp413-2016/RDFS.git","ssh_url":"git@github.com:Rice-Comp413-2016/RDFS.git","clone_url":"https://github.com/Rice-Comp413-2016/RDFS.git","svn_url":"https://github.com/Rice-Comp413-2016/RDFS","homepage":"","size":1143,"stargazers_count":1,"watchers_count":1,"language":"Protocol Buffer","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":14,"forks":1,"open_issues":14,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/pulls/49"},"html":{"href":"https://github.com/Rice-Comp413-2016/RDFS/pull/49"},"issue":{"href":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/issues/49"},"comments":{"href":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/issues/49/comments"},"review_comments":{"href":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/pulls/49/comments"},"review_comment":{"href":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/pulls/49/commits"},"statuses":{"href":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/statuses/c0c0273002b3759a57e85f87223d8ab6bee2918b"}}}}
{"actor":{"display_login":"agardella"}}