{"action":"created","issue":{"url":"https://api.github.com/repos/playframework/playframework/issues/6691","repository_url":"https://api.github.com/repos/playframework/playframework","labels_url":"https://api.github.com/repos/playframework/playframework/issues/6691/labels{/name}","comments_url":"https://api.github.com/repos/playframework/playframework/issues/6691/comments","events_url":"https://api.github.com/repos/playframework/playframework/issues/6691/events","html_url":"https://github.com/playframework/playframework/pull/6691","id":186912316,"number":6691,"title":"Upgrade to Scala 2.12","user":{"login":"wsargent","id":71236,"avatar_url":"https://avatars.githubusercontent.com/u/71236?v=3","gravatar_id":"","url":"https://api.github.com/users/wsargent","html_url":"https://github.com/wsargent","followers_url":"https://api.github.com/users/wsargent/followers","following_url":"https://api.github.com/users/wsargent/following{/other_user}","gists_url":"https://api.github.com/users/wsargent/gists{/gist_id}","starred_url":"https://api.github.com/users/wsargent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wsargent/subscriptions","organizations_url":"https://api.github.com/users/wsargent/orgs","repos_url":"https://api.github.com/users/wsargent/repos","events_url":"https://api.github.com/users/wsargent/events{/privacy}","received_events_url":"https://api.github.com/users/wsargent/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-11-02T20:33:21Z","updated_at":"2016-11-10T09:13:24Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/playframework/playframework/pulls/6691","html_url":"https://github.com/playframework/playframework/pull/6691","diff_url":"https://github.com/playframework/playframework/pull/6691.diff","patch_url":"https://github.com/playframework/playframework/pull/6691.patch"},"body":"Sets up a Play version that works against 2.12.0 by default and does a cross-build to 2.11.8.\r\n\r\nAll the dependencies have been worked through, so if this builds, we should be good."},"comment":{"url":"https://api.github.com/repos/playframework/playframework/issues/comments/259638730","html_url":"https://github.com/playframework/playframework/pull/6691#issuecomment-259638730","issue_url":"https://api.github.com/repos/playframework/playframework/issues/6691","id":259638730,"user":{"login":"schmitch","id":1641401,"avatar_url":"https://avatars.githubusercontent.com/u/1641401?v=3","gravatar_id":"","url":"https://api.github.com/users/schmitch","html_url":"https://github.com/schmitch","followers_url":"https://api.github.com/users/schmitch/followers","following_url":"https://api.github.com/users/schmitch/following{/other_user}","gists_url":"https://api.github.com/users/schmitch/gists{/gist_id}","starred_url":"https://api.github.com/users/schmitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schmitch/subscriptions","organizations_url":"https://api.github.com/users/schmitch/orgs","repos_url":"https://api.github.com/users/schmitch/repos","events_url":"https://api.github.com/users/schmitch/events{/privacy}","received_events_url":"https://api.github.com/users/schmitch/received_events","type":"User","site_admin":false},"created_at":"2016-11-10T09:13:24Z","updated_at":"2016-11-10T09:13:24Z","body":"Actually scripted tests will now only run on 2.12 and the normal tests won't actually cross-build as it seems? we might need to adjust the travis build file.\r\n\r\nAlso scripted tests fail, two of them are easy to fix:\r\n\r\nFix for the scripted tests:\r\n```\r\ndiff --git a/framework/src/sbt-plugin/src/sbt-test/routes-compiler-plugin/injected-routes-compilation/app/controllers/Application.scala b/framework/src/sbt-plugin/src/sbt-test/routes-compiler-plugin/injected-routes-compilation/app/controllers/Application.scala\r\nindex 5e97254..6e6a816 100644\r\n--- a/framework/src/sbt-plugin/src/sbt-test/routes-compiler-plugin/injected-routes-compilation/app/controllers/Application.scala\r\n+++ b/framework/src/sbt-plugin/src/sbt-test/routes-compiler-plugin/injected-routes-compilation/app/controllers/Application.scala\r\n@@ -4,7 +4,7 @@\r\n package controllers\r\n \r\n import play.api.mvc._\r\n-import scala.collection.JavaConversions._\r\n+import scala.collection.JavaConverters._\r\n import javax.inject.Inject\r\n \r\n class Application @Inject() (c: ControllerComponents) extends AbstractController(c) {\r\n@@ -36,7 +36,7 @@ class Application @Inject() (c: ControllerComponents) extends AbstractController\r\n     Ok(`b[]`mkString(\",\") + \" \" + `b%%`)\r\n   }\r\n   def takeJavaList(x: java.util.List[Integer]) = Action {\r\n-    Ok(x.mkString(\",\"))\r\n+    Ok(x.asScala.mkString(\",\"))\r\n   }\r\n   def urlcoding(dynamic: String, static: String, query: String) = Action {\r\n     Ok(s\"dynamic=$dynamic static=$static query=$query\")\r\ndiff --git a/framework/src/sbt-plugin/src/sbt-test/routes-compiler-plugin/routes-compilation/app/controllers/Application.scala b/framework/src/sbt-plugin/src/sbt-test/routes-compiler-plugin/routes-compilation/app/controllers/Application.scala\r\nindex 40cd0b0..8ce048f 100644\r\n--- a/framework/src/sbt-plugin/src/sbt-test/routes-compiler-plugin/routes-compilation/app/controllers/Application.scala\r\n+++ b/framework/src/sbt-plugin/src/sbt-test/routes-compiler-plugin/routes-compilation/app/controllers/Application.scala\r\n@@ -5,7 +5,7 @@ package controllers\r\n \r\n import play.api.mvc._\r\n import javax.inject.Inject\r\n-import scala.collection.JavaConversions._\r\n+import scala.collection.JavaConverters._\r\n \r\n class Application @Inject() (c: ControllerComponents) extends AbstractController(c) {\r\n   def index = Action {\r\n@@ -30,7 +30,7 @@ class Application @Inject() (c: ControllerComponents) extends AbstractController\r\n     Ok(x.mkString(\",\"))\r\n   }\r\n   def takeJavaList(x: java.util.List[Integer]) = Action {\r\n-    Ok(x.mkString(\",\"))\r\n+    Ok(x.asScala.mkString(\",\"))\r\n   }\r\n   def urlcoding(dynamic: String, static: String, query: String) = Action {\r\n     Ok(s\"dynamic=$dynamic static=$static query=$query\")\r\n```\r\n\r\nafter that we get a really strange failure of akka-http-server: \r\n`[error] (Play-Akka-Http-Server-Experimental/*:scripted) java.lang.NoSuchMethodError: scala.Predef$.refArrayOps([Ljava/lang/Object;)Lscala/collection/mutable/ArrayOps;`\r\nwith a stack trace that is hard to guess."}}
{"actor":{"display_login":"schmitch"}}