{"action":"created","issue":{"url":"https://api.github.com/repos/ilastik/pgmlink/issues/2","repository_url":"https://api.github.com/repos/ilastik/pgmlink","labels_url":"https://api.github.com/repos/ilastik/pgmlink/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/ilastik/pgmlink/issues/2/comments","events_url":"https://api.github.com/repos/ilastik/pgmlink/issues/2/events","html_url":"https://github.com/ilastik/pgmlink/pull/2","id":144974051,"number":2,"title":"MSVC fixes","user":{"login":"ukoethe","id":897680,"avatar_url":"https://avatars.githubusercontent.com/u/897680?v=3","gravatar_id":"","url":"https://api.github.com/users/ukoethe","html_url":"https://github.com/ukoethe","followers_url":"https://api.github.com/users/ukoethe/followers","following_url":"https://api.github.com/users/ukoethe/following{/other_user}","gists_url":"https://api.github.com/users/ukoethe/gists{/gist_id}","starred_url":"https://api.github.com/users/ukoethe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ukoethe/subscriptions","organizations_url":"https://api.github.com/users/ukoethe/orgs","repos_url":"https://api.github.com/users/ukoethe/repos","events_url":"https://api.github.com/users/ukoethe/events{/privacy}","received_events_url":"https://api.github.com/users/ukoethe/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-03-31T17:58:57Z","updated_at":"2016-04-22T12:28:27Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ilastik/pgmlink/pulls/2","html_url":"https://github.com/ilastik/pgmlink/pull/2","diff_url":"https://github.com/ilastik/pgmlink/pull/2.diff","patch_url":"https://github.com/ilastik/pgmlink/pull/2.patch"},"body":"First set of MSVC fixes. Remaining problems:\r\n\r\n* Initializer lists are unsupported by Visual Studio 2012 (the current ilastik compiler on Windows). You must remove all of them. Here is a not necessarily complete list: `featurestore.cpp` line 75, `higher_order_features.cpp` lines 217, 218, 224, `tracking.cpp` line 959\r\n* `IsCompleteType<T>` does not compile if `T` is an incomplete type.\r\n* `MoveEnergy::operator ()` is most certainly wrong -- I added `assert(false)` to make sure that this is never executed. Please check what the function was supposed to do and correct. Note that `std::inner_product` is unsupported on Visual Studio 2012.\r\n* `constrackinginferencemodel.cpp`, line 343: `>` is undefined for bool\r\n* `hypotheses.cpp`, line 69:\r\n```\r\n binary '=' : no operator found which takes a right-hand operand of\r\n type 'std::vector<_Ty>' (or there is no acceptable conversion)\r\n          with \r\n              _Ty=size_t\r\n          and\r\n              _Ty=unsigned long\r\n```\r\n\r\nI didn't get far enough to check for missing `PGMLINK_EXPORT`. \r\n\r\nI've seen many functions that take 10 or more parameters (up to maybe 20). This is **extremely bad design**."},"comment":{"url":"https://api.github.com/repos/ilastik/pgmlink/issues/comments/213404340","html_url":"https://github.com/ilastik/pgmlink/pull/2#issuecomment-213404340","issue_url":"https://api.github.com/repos/ilastik/pgmlink/issues/2","id":213404340,"user":{"login":"ilastikdev","id":9413215,"avatar_url":"https://avatars.githubusercontent.com/u/9413215?v=3","gravatar_id":"","url":"https://api.github.com/users/ilastikdev","html_url":"https://github.com/ilastikdev","followers_url":"https://api.github.com/users/ilastikdev/followers","following_url":"https://api.github.com/users/ilastikdev/following{/other_user}","gists_url":"https://api.github.com/users/ilastikdev/gists{/gist_id}","starred_url":"https://api.github.com/users/ilastikdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilastikdev/subscriptions","organizations_url":"https://api.github.com/users/ilastikdev/orgs","repos_url":"https://api.github.com/users/ilastikdev/repos","events_url":"https://api.github.com/users/ilastikdev/events{/privacy}","received_events_url":"https://api.github.com/users/ilastikdev/received_events","type":"User","site_admin":false},"created_at":"2016-04-22T12:28:27Z","updated_at":"2016-04-22T12:28:27Z","body":"\"IsCompleteType<T> does not compile...\" on MS VS 2012; it  is from opengm.\r\n\r\nPull learning-experimental from\r\nhttps://github.com/ilastikdev/opengm-1"}}