{"action":"created","comment":{"url":"https://api.github.com/repos/druid-io/druid/pulls/comments/68114607","id":68114607,"diff_hunk":"@@ -68,20 +71,20 @@ protected void map(\n       try {\n         inputRow = parseInputRow(value, parser);\n       }\n-      catch (Exception e) {\n-        if (config.isIgnoreInvalidRows()) {\n+      catch (ParseException e) {\n+        if (reportParseExceptions) {\n+          throw e;\n+        } else {","path":"indexing-hadoop/src/main/java/io/druid/indexer/HadoopDruidIndexerMapper.java","position":33,"original_position":33,"commit_id":"f0490a2c79682bcea9103262941672cda85d16e1","original_commit_id":"f0490a2c79682bcea9103262941672cda85d16e1","user":{"login":"drcrallen","id":8213081,"avatar_url":"https://avatars.githubusercontent.com/u/8213081?v=3","gravatar_id":"","url":"https://api.github.com/users/drcrallen","html_url":"https://github.com/drcrallen","followers_url":"https://api.github.com/users/drcrallen/followers","following_url":"https://api.github.com/users/drcrallen/following{/other_user}","gists_url":"https://api.github.com/users/drcrallen/gists{/gist_id}","starred_url":"https://api.github.com/users/drcrallen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drcrallen/subscriptions","organizations_url":"https://api.github.com/users/drcrallen/orgs","repos_url":"https://api.github.com/users/drcrallen/repos","events_url":"https://api.github.com/users/drcrallen/events{/privacy}","received_events_url":"https://api.github.com/users/drcrallen/received_events","type":"User","site_admin":false},"body":"You can get rid of the nesting in an else here","created_at":"2016-06-22T19:01:27Z","updated_at":"2016-06-22T19:01:27Z","html_url":"https://github.com/druid-io/druid/pull/3171#discussion_r68114607","pull_request_url":"https://api.github.com/repos/druid-io/druid/pulls/3171","_links":{"self":{"href":"https://api.github.com/repos/druid-io/druid/pulls/comments/68114607"},"html":{"href":"https://github.com/druid-io/druid/pull/3171#discussion_r68114607"},"pull_request":{"href":"https://api.github.com/repos/druid-io/druid/pulls/3171"}}},"pull_request":{"url":"https://api.github.com/repos/druid-io/druid/pulls/3171","id":74813292,"html_url":"https://github.com/druid-io/druid/pull/3171","diff_url":"https://github.com/druid-io/druid/pull/3171.diff","patch_url":"https://github.com/druid-io/druid/pull/3171.patch","issue_url":"https://api.github.com/repos/druid-io/druid/issues/3171","number":3171,"state":"open","locked":false,"title":"Better handling for parseExceptions","user":{"login":"nishantmonu51","id":5023786,"avatar_url":"https://avatars.githubusercontent.com/u/5023786?v=3","gravatar_id":"","url":"https://api.github.com/users/nishantmonu51","html_url":"https://github.com/nishantmonu51","followers_url":"https://api.github.com/users/nishantmonu51/followers","following_url":"https://api.github.com/users/nishantmonu51/following{/other_user}","gists_url":"https://api.github.com/users/nishantmonu51/gists{/gist_id}","starred_url":"https://api.github.com/users/nishantmonu51/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nishantmonu51/subscriptions","organizations_url":"https://api.github.com/users/nishantmonu51/orgs","repos_url":"https://api.github.com/users/nishantmonu51/repos","events_url":"https://api.github.com/users/nishantmonu51/events{/privacy}","received_events_url":"https://api.github.com/users/nishantmonu51/received_events","type":"User","site_admin":false},"body":"Issue reported here - \nhttps://groups.google.com/d/msgid/druid-development/220cbbfe-a469-4d4c-b473-14e650dafba5%40googlegroups.com","created_at":"2016-06-22T16:14:21Z","updated_at":"2016-06-22T19:01:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"922eb2bddebcdbf022c6bcfea268e7eb776f5775","assignee":null,"milestone":{"url":"https://api.github.com/repos/druid-io/druid/milestones/20","html_url":"https://github.com/druid-io/druid/milestones/0.9.2","labels_url":"https://api.github.com/repos/druid-io/druid/milestones/20/labels","id":1571409,"number":20,"title":"0.9.2","description":"","creator":{"login":"fjy","id":428325,"avatar_url":"https://avatars.githubusercontent.com/u/428325?v=3","gravatar_id":"","url":"https://api.github.com/users/fjy","html_url":"https://github.com/fjy","followers_url":"https://api.github.com/users/fjy/followers","following_url":"https://api.github.com/users/fjy/following{/other_user}","gists_url":"https://api.github.com/users/fjy/gists{/gist_id}","starred_url":"https://api.github.com/users/fjy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fjy/subscriptions","organizations_url":"https://api.github.com/users/fjy/orgs","repos_url":"https://api.github.com/users/fjy/repos","events_url":"https://api.github.com/users/fjy/events{/privacy}","received_events_url":"https://api.github.com/users/fjy/received_events","type":"User","site_admin":false},"open_issues":30,"closed_issues":23,"state":"open","created_at":"2016-02-08T22:01:21Z","updated_at":"2016-06-22T16:32:30Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/druid-io/druid/pulls/3171/commits","review_comments_url":"https://api.github.com/repos/druid-io/druid/pulls/3171/comments","review_comment_url":"https://api.github.com/repos/druid-io/druid/pulls/comments{/number}","comments_url":"https://api.github.com/repos/druid-io/druid/issues/3171/comments","statuses_url":"https://api.github.com/repos/druid-io/druid/statuses/f0490a2c79682bcea9103262941672cda85d16e1","head":{"label":"nishantmonu51:fix-ignoreInvalidRows","ref":"fix-ignoreInvalidRows","sha":"f0490a2c79682bcea9103262941672cda85d16e1","user":{"login":"nishantmonu51","id":5023786,"avatar_url":"https://avatars.githubusercontent.com/u/5023786?v=3","gravatar_id":"","url":"https://api.github.com/users/nishantmonu51","html_url":"https://github.com/nishantmonu51","followers_url":"https://api.github.com/users/nishantmonu51/followers","following_url":"https://api.github.com/users/nishantmonu51/following{/other_user}","gists_url":"https://api.github.com/users/nishantmonu51/gists{/gist_id}","starred_url":"https://api.github.com/users/nishantmonu51/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nishantmonu51/subscriptions","organizations_url":"https://api.github.com/users/nishantmonu51/orgs","repos_url":"https://api.github.com/users/nishantmonu51/repos","events_url":"https://api.github.com/users/nishantmonu51/events{/privacy}","received_events_url":"https://api.github.com/users/nishantmonu51/received_events","type":"User","site_admin":false},"repo":{"id":30287395,"name":"druid","full_name":"nishantmonu51/druid","owner":{"login":"nishantmonu51","id":5023786,"avatar_url":"https://avatars.githubusercontent.com/u/5023786?v=3","gravatar_id":"","url":"https://api.github.com/users/nishantmonu51","html_url":"https://github.com/nishantmonu51","followers_url":"https://api.github.com/users/nishantmonu51/followers","following_url":"https://api.github.com/users/nishantmonu51/following{/other_user}","gists_url":"https://api.github.com/users/nishantmonu51/gists{/gist_id}","starred_url":"https://api.github.com/users/nishantmonu51/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nishantmonu51/subscriptions","organizations_url":"https://api.github.com/users/nishantmonu51/orgs","repos_url":"https://api.github.com/users/nishantmonu51/repos","events_url":"https://api.github.com/users/nishantmonu51/events{/privacy}","received_events_url":"https://api.github.com/users/nishantmonu51/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nishantmonu51/druid","description":"Real²time Exploratory Analytics on Large Datasets","fork":true,"url":"https://api.github.com/repos/nishantmonu51/druid","forks_url":"https://api.github.com/repos/nishantmonu51/druid/forks","keys_url":"https://api.github.com/repos/nishantmonu51/druid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nishantmonu51/druid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nishantmonu51/druid/teams","hooks_url":"https://api.github.com/repos/nishantmonu51/druid/hooks","issue_events_url":"https://api.github.com/repos/nishantmonu51/druid/issues/events{/number}","events_url":"https://api.github.com/repos/nishantmonu51/druid/events","assignees_url":"https://api.github.com/repos/nishantmonu51/druid/assignees{/user}","branches_url":"https://api.github.com/repos/nishantmonu51/druid/branches{/branch}","tags_url":"https://api.github.com/repos/nishantmonu51/druid/tags","blobs_url":"https://api.github.com/repos/nishantmonu51/druid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nishantmonu51/druid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nishantmonu51/druid/git/refs{/sha}","trees_url":"https://api.github.com/repos/nishantmonu51/druid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nishantmonu51/druid/statuses/{sha}","languages_url":"https://api.github.com/repos/nishantmonu51/druid/languages","stargazers_url":"https://api.github.com/repos/nishantmonu51/druid/stargazers","contributors_url":"https://api.github.com/repos/nishantmonu51/druid/contributors","subscribers_url":"https://api.github.com/repos/nishantmonu51/druid/subscribers","subscription_url":"https://api.github.com/repos/nishantmonu51/druid/subscription","commits_url":"https://api.github.com/repos/nishantmonu51/druid/commits{/sha}","git_commits_url":"https://api.github.com/repos/nishantmonu51/druid/git/commits{/sha}","comments_url":"https://api.github.com/repos/nishantmonu51/druid/comments{/number}","issue_comment_url":"https://api.github.com/repos/nishantmonu51/druid/issues/comments{/number}","contents_url":"https://api.github.com/repos/nishantmonu51/druid/contents/{+path}","compare_url":"https://api.github.com/repos/nishantmonu51/druid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nishantmonu51/druid/merges","archive_url":"https://api.github.com/repos/nishantmonu51/druid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nishantmonu51/druid/downloads","issues_url":"https://api.github.com/repos/nishantmonu51/druid/issues{/number}","pulls_url":"https://api.github.com/repos/nishantmonu51/druid/pulls{/number}","milestones_url":"https://api.github.com/repos/nishantmonu51/druid/milestones{/number}","notifications_url":"https://api.github.com/repos/nishantmonu51/druid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nishantmonu51/druid/labels{/name}","releases_url":"https://api.github.com/repos/nishantmonu51/druid/releases{/id}","deployments_url":"https://api.github.com/repos/nishantmonu51/druid/deployments","created_at":"2015-02-04T07:42:09Z","updated_at":"2016-05-30T13:28:55Z","pushed_at":"2016-06-22T18:44:11Z","git_url":"git://github.com/nishantmonu51/druid.git","ssh_url":"git@github.com:nishantmonu51/druid.git","clone_url":"https://github.com/nishantmonu51/druid.git","svn_url":"https://github.com/nishantmonu51/druid","homepage":"http://druid.io","size":106621,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"druid-io:master","ref":"master","sha":"f46ad9a4cb9aa6d768b7ffc9fc5bdc6358ede748","user":{"login":"druid-io","id":4203474,"avatar_url":"https://avatars.githubusercontent.com/u/4203474?v=3","gravatar_id":"","url":"https://api.github.com/users/druid-io","html_url":"https://github.com/druid-io","followers_url":"https://api.github.com/users/druid-io/followers","following_url":"https://api.github.com/users/druid-io/following{/other_user}","gists_url":"https://api.github.com/users/druid-io/gists{/gist_id}","starred_url":"https://api.github.com/users/druid-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/druid-io/subscriptions","organizations_url":"https://api.github.com/users/druid-io/orgs","repos_url":"https://api.github.com/users/druid-io/repos","events_url":"https://api.github.com/users/druid-io/events{/privacy}","received_events_url":"https://api.github.com/users/druid-io/received_events","type":"Organization","site_admin":false},"repo":{"id":6358188,"name":"druid","full_name":"druid-io/druid","owner":{"login":"druid-io","id":4203474,"avatar_url":"https://avatars.githubusercontent.com/u/4203474?v=3","gravatar_id":"","url":"https://api.github.com/users/druid-io","html_url":"https://github.com/druid-io","followers_url":"https://api.github.com/users/druid-io/followers","following_url":"https://api.github.com/users/druid-io/following{/other_user}","gists_url":"https://api.github.com/users/druid-io/gists{/gist_id}","starred_url":"https://api.github.com/users/druid-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/druid-io/subscriptions","organizations_url":"https://api.github.com/users/druid-io/orgs","repos_url":"https://api.github.com/users/druid-io/repos","events_url":"https://api.github.com/users/druid-io/events{/privacy}","received_events_url":"https://api.github.com/users/druid-io/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/druid-io/druid","description":"Column oriented distributed data store ideal for powering interactive applications","fork":false,"url":"https://api.github.com/repos/druid-io/druid","forks_url":"https://api.github.com/repos/druid-io/druid/forks","keys_url":"https://api.github.com/repos/druid-io/druid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/druid-io/druid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/druid-io/druid/teams","hooks_url":"https://api.github.com/repos/druid-io/druid/hooks","issue_events_url":"https://api.github.com/repos/druid-io/druid/issues/events{/number}","events_url":"https://api.github.com/repos/druid-io/druid/events","assignees_url":"https://api.github.com/repos/druid-io/druid/assignees{/user}","branches_url":"https://api.github.com/repos/druid-io/druid/branches{/branch}","tags_url":"https://api.github.com/repos/druid-io/druid/tags","blobs_url":"https://api.github.com/repos/druid-io/druid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/druid-io/druid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/druid-io/druid/git/refs{/sha}","trees_url":"https://api.github.com/repos/druid-io/druid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/druid-io/druid/statuses/{sha}","languages_url":"https://api.github.com/repos/druid-io/druid/languages","stargazers_url":"https://api.github.com/repos/druid-io/druid/stargazers","contributors_url":"https://api.github.com/repos/druid-io/druid/contributors","subscribers_url":"https://api.github.com/repos/druid-io/druid/subscribers","subscription_url":"https://api.github.com/repos/druid-io/druid/subscription","commits_url":"https://api.github.com/repos/druid-io/druid/commits{/sha}","git_commits_url":"https://api.github.com/repos/druid-io/druid/git/commits{/sha}","comments_url":"https://api.github.com/repos/druid-io/druid/comments{/number}","issue_comment_url":"https://api.github.com/repos/druid-io/druid/issues/comments{/number}","contents_url":"https://api.github.com/repos/druid-io/druid/contents/{+path}","compare_url":"https://api.github.com/repos/druid-io/druid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/druid-io/druid/merges","archive_url":"https://api.github.com/repos/druid-io/druid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/druid-io/druid/downloads","issues_url":"https://api.github.com/repos/druid-io/druid/issues{/number}","pulls_url":"https://api.github.com/repos/druid-io/druid/pulls{/number}","milestones_url":"https://api.github.com/repos/druid-io/druid/milestones{/number}","notifications_url":"https://api.github.com/repos/druid-io/druid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/druid-io/druid/labels{/name}","releases_url":"https://api.github.com/repos/druid-io/druid/releases{/id}","deployments_url":"https://api.github.com/repos/druid-io/druid/deployments","created_at":"2012-10-23T19:08:07Z","updated_at":"2016-06-22T12:36:17Z","pushed_at":"2016-06-22T18:44:11Z","git_url":"git://github.com/druid-io/druid.git","ssh_url":"git@github.com:druid-io/druid.git","clone_url":"https://github.com/druid-io/druid.git","svn_url":"https://github.com/druid-io/druid","homepage":"http://druid.io","size":151492,"stargazers_count":3372,"watchers_count":3372,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":759,"mirror_url":null,"open_issues_count":472,"forks":759,"open_issues":472,"watchers":3372,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/druid-io/druid/pulls/3171"},"html":{"href":"https://github.com/druid-io/druid/pull/3171"},"issue":{"href":"https://api.github.com/repos/druid-io/druid/issues/3171"},"comments":{"href":"https://api.github.com/repos/druid-io/druid/issues/3171/comments"},"review_comments":{"href":"https://api.github.com/repos/druid-io/druid/pulls/3171/comments"},"review_comment":{"href":"https://api.github.com/repos/druid-io/druid/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/druid-io/druid/pulls/3171/commits"},"statuses":{"href":"https://api.github.com/repos/druid-io/druid/statuses/f0490a2c79682bcea9103262941672cda85d16e1"}}}}
{"actor":{"display_login":"drcrallen"}}