{"action":"created","comment":{"url":"https://api.github.com/repos/apache/kafka/pulls/comments/69305222","id":69305222,"diff_hunk":"@@ -0,0 +1,58 @@\n+/**\n+ * Licensed to the Apache Software Foundation (ASF) under one or more\n+ * contributor license agreements.  See the NOTICE file distributed with\n+ * this work for additional information regarding copyright ownership.\n+ * The ASF licenses this file to You under the Apache License, Version 2.0\n+ * (the \"License\"); you may not use this file except in compliance with\n+ * the License.  You may obtain a copy of the License at\n+ * <p>\n+ * http://www.apache.org/licenses/LICENSE-2.0\n+ * <p>\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+package org.apache.kafka.streams.state;\n+\n+import org.apache.kafka.streams.processor.ProcessorContext;\n+import org.apache.kafka.streams.processor.StateStore;\n+\n+public class NoOpWindowStore implements ReadOnlyWindowStore, StateStore {\n+\n+    @Override\n+    public String name() {\n+        return null;","path":"streams/src/test/java/org/apache/kafka/streams/state/NoOpWindowStore.java","position":26,"original_position":26,"commit_id":"188c72fee397f17f9930164ecf4c588d8b6cf21e","original_commit_id":"188c72fee397f17f9930164ecf4c588d8b6cf21e","user":{"login":"miguno","id":294849,"avatar_url":"https://avatars.githubusercontent.com/u/294849?v=3","gravatar_id":"","url":"https://api.github.com/users/miguno","html_url":"https://github.com/miguno","followers_url":"https://api.github.com/users/miguno/followers","following_url":"https://api.github.com/users/miguno/following{/other_user}","gists_url":"https://api.github.com/users/miguno/gists{/gist_id}","starred_url":"https://api.github.com/users/miguno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miguno/subscriptions","organizations_url":"https://api.github.com/users/miguno/orgs","repos_url":"https://api.github.com/users/miguno/repos","events_url":"https://api.github.com/users/miguno/events{/privacy}","received_events_url":"https://api.github.com/users/miguno/received_events","type":"User","site_admin":false},"body":"I know it's a test class, but IIRC a state store name must not be null? (I might be wrong.)","created_at":"2016-07-01T14:13:03Z","updated_at":"2016-07-01T14:13:03Z","html_url":"https://github.com/apache/kafka/pull/1565#discussion_r69305222","pull_request_url":"https://api.github.com/repos/apache/kafka/pulls/1565","_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments/69305222"},"html":{"href":"https://github.com/apache/kafka/pull/1565#discussion_r69305222"},"pull_request":{"href":"https://api.github.com/repos/apache/kafka/pulls/1565"}}},"pull_request":{"url":"https://api.github.com/repos/apache/kafka/pulls/1565","id":75455829,"html_url":"https://github.com/apache/kafka/pull/1565","diff_url":"https://github.com/apache/kafka/pull/1565.diff","patch_url":"https://github.com/apache/kafka/pull/1565.patch","issue_url":"https://api.github.com/repos/apache/kafka/issues/1565","number":1565,"state":"open","locked":false,"title":"KAFKA-3912: Query local state stores","user":{"login":"dguy","id":54829,"avatar_url":"https://avatars.githubusercontent.com/u/54829?v=3","gravatar_id":"","url":"https://api.github.com/users/dguy","html_url":"https://github.com/dguy","followers_url":"https://api.github.com/users/dguy/followers","following_url":"https://api.github.com/users/dguy/following{/other_user}","gists_url":"https://api.github.com/users/dguy/gists{/gist_id}","starred_url":"https://api.github.com/users/dguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dguy/subscriptions","organizations_url":"https://api.github.com/users/dguy/orgs","repos_url":"https://api.github.com/users/dguy/repos","events_url":"https://api.github.com/users/dguy/events{/privacy}","received_events_url":"https://api.github.com/users/dguy/received_events","type":"User","site_admin":false},"body":"@guozhangwang @enothereska please review","created_at":"2016-06-28T10:45:24Z","updated_at":"2016-07-01T14:13:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"632e86ee0fddebb4af07a518bb8491db94504a35","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/kafka/pulls/1565/commits","review_comments_url":"https://api.github.com/repos/apache/kafka/pulls/1565/comments","review_comment_url":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/kafka/issues/1565/comments","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/188c72fee397f17f9930164ecf4c588d8b6cf21e","head":{"label":"dguy:kafka-3912","ref":"kafka-3912","sha":"188c72fee397f17f9930164ecf4c588d8b6cf21e","user":{"login":"dguy","id":54829,"avatar_url":"https://avatars.githubusercontent.com/u/54829?v=3","gravatar_id":"","url":"https://api.github.com/users/dguy","html_url":"https://github.com/dguy","followers_url":"https://api.github.com/users/dguy/followers","following_url":"https://api.github.com/users/dguy/following{/other_user}","gists_url":"https://api.github.com/users/dguy/gists{/gist_id}","starred_url":"https://api.github.com/users/dguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dguy/subscriptions","organizations_url":"https://api.github.com/users/dguy/orgs","repos_url":"https://api.github.com/users/dguy/repos","events_url":"https://api.github.com/users/dguy/events{/privacy}","received_events_url":"https://api.github.com/users/dguy/received_events","type":"User","site_admin":false},"repo":{"id":56393114,"name":"kafka","full_name":"dguy/kafka","owner":{"login":"dguy","id":54829,"avatar_url":"https://avatars.githubusercontent.com/u/54829?v=3","gravatar_id":"","url":"https://api.github.com/users/dguy","html_url":"https://github.com/dguy","followers_url":"https://api.github.com/users/dguy/followers","following_url":"https://api.github.com/users/dguy/following{/other_user}","gists_url":"https://api.github.com/users/dguy/gists{/gist_id}","starred_url":"https://api.github.com/users/dguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dguy/subscriptions","organizations_url":"https://api.github.com/users/dguy/orgs","repos_url":"https://api.github.com/users/dguy/repos","events_url":"https://api.github.com/users/dguy/events{/privacy}","received_events_url":"https://api.github.com/users/dguy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dguy/kafka","description":"Mirror of Apache Kafka","fork":true,"url":"https://api.github.com/repos/dguy/kafka","forks_url":"https://api.github.com/repos/dguy/kafka/forks","keys_url":"https://api.github.com/repos/dguy/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dguy/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dguy/kafka/teams","hooks_url":"https://api.github.com/repos/dguy/kafka/hooks","issue_events_url":"https://api.github.com/repos/dguy/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/dguy/kafka/events","assignees_url":"https://api.github.com/repos/dguy/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/dguy/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/dguy/kafka/tags","blobs_url":"https://api.github.com/repos/dguy/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dguy/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dguy/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/dguy/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dguy/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/dguy/kafka/languages","stargazers_url":"https://api.github.com/repos/dguy/kafka/stargazers","contributors_url":"https://api.github.com/repos/dguy/kafka/contributors","subscribers_url":"https://api.github.com/repos/dguy/kafka/subscribers","subscription_url":"https://api.github.com/repos/dguy/kafka/subscription","commits_url":"https://api.github.com/repos/dguy/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/dguy/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/dguy/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/dguy/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/dguy/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/dguy/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dguy/kafka/merges","archive_url":"https://api.github.com/repos/dguy/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dguy/kafka/downloads","issues_url":"https://api.github.com/repos/dguy/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/dguy/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/dguy/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/dguy/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dguy/kafka/labels{/name}","releases_url":"https://api.github.com/repos/dguy/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/dguy/kafka/deployments","created_at":"2016-04-16T16:12:53Z","updated_at":"2016-04-16T16:12:57Z","pushed_at":"2016-07-01T11:29:46Z","git_url":"git://github.com/dguy/kafka.git","ssh_url":"git@github.com:dguy/kafka.git","clone_url":"https://github.com/dguy/kafka.git","svn_url":"https://github.com/dguy/kafka","homepage":null,"size":32592,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"trunk"}},"base":{"label":"apache:trunk","ref":"trunk","sha":"10abe858bd892863f1d01c29bfb6d0f4206de2d3","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":2211243,"name":"kafka","full_name":"apache/kafka","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/kafka","description":"Mirror of Apache Kafka","fork":false,"url":"https://api.github.com/repos/apache/kafka","forks_url":"https://api.github.com/repos/apache/kafka/forks","keys_url":"https://api.github.com/repos/apache/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/kafka/teams","hooks_url":"https://api.github.com/repos/apache/kafka/hooks","issue_events_url":"https://api.github.com/repos/apache/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/apache/kafka/events","assignees_url":"https://api.github.com/repos/apache/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/apache/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/apache/kafka/tags","blobs_url":"https://api.github.com/repos/apache/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/kafka/languages","stargazers_url":"https://api.github.com/repos/apache/kafka/stargazers","contributors_url":"https://api.github.com/repos/apache/kafka/contributors","subscribers_url":"https://api.github.com/repos/apache/kafka/subscribers","subscription_url":"https://api.github.com/repos/apache/kafka/subscription","commits_url":"https://api.github.com/repos/apache/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/apache/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/kafka/merges","archive_url":"https://api.github.com/repos/apache/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/kafka/downloads","issues_url":"https://api.github.com/repos/apache/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/apache/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/kafka/labels{/name}","releases_url":"https://api.github.com/repos/apache/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/apache/kafka/deployments","created_at":"2011-08-15T18:06:16Z","updated_at":"2016-07-01T11:15:37Z","pushed_at":"2016-07-01T13:40:49Z","git_url":"git://github.com/apache/kafka.git","ssh_url":"git@github.com:apache/kafka.git","clone_url":"https://github.com/apache/kafka.git","svn_url":"https://github.com/apache/kafka","homepage":null,"size":44494,"stargazers_count":3357,"watchers_count":3357,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2058,"mirror_url":"git://git.apache.org/kafka.git","open_issues_count":209,"forks":2058,"open_issues":209,"watchers":3357,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/1565"},"html":{"href":"https://github.com/apache/kafka/pull/1565"},"issue":{"href":"https://api.github.com/repos/apache/kafka/issues/1565"},"comments":{"href":"https://api.github.com/repos/apache/kafka/issues/1565/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/kafka/pulls/1565/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/kafka/pulls/1565/commits"},"statuses":{"href":"https://api.github.com/repos/apache/kafka/statuses/188c72fee397f17f9930164ecf4c588d8b6cf21e"}}}}
{"actor":{"display_login":"miguno"}}