{"action":"created","comment":{"url":"https://api.github.com/repos/aspnet/JavaScriptServices/pulls/comments/84686126","pull_request_review_id":5442248,"id":84686126,"diff_hunk":"@@ -0,0 +1,16 @@\n+<!DOCTYPE html>\n+<html>\n+    <head>\n+        <meta charset=\"utf-8\" />\n+        <meta name=\"viewport\" content=\"width=device-width, initial-scale=1.0\" />\n+        <title>@ViewData[\"Title\"] - Aurelia</title>\n+        <base href=\"/\" />\n+    </head>\n+    <body aurelia-app=\"boot\">","path":"templates/AureliaSpa/Views/Shared/_Layout.cshtml","position":9,"original_position":9,"commit_id":"fe5059cddf60468e431ce62520783f502f7e56e3","original_commit_id":"fe5059cddf60468e431ce62520783f502f7e56e3","user":{"login":"SteveSandersonMS","id":1101362,"avatar_url":"https://avatars.githubusercontent.com/u/1101362?v=3","gravatar_id":"","url":"https://api.github.com/users/SteveSandersonMS","html_url":"https://github.com/SteveSandersonMS","followers_url":"https://api.github.com/users/SteveSandersonMS/followers","following_url":"https://api.github.com/users/SteveSandersonMS/following{/other_user}","gists_url":"https://api.github.com/users/SteveSandersonMS/gists{/gist_id}","starred_url":"https://api.github.com/users/SteveSandersonMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SteveSandersonMS/subscriptions","organizations_url":"https://api.github.com/users/SteveSandersonMS/orgs","repos_url":"https://api.github.com/users/SteveSandersonMS/repos","events_url":"https://api.github.com/users/SteveSandersonMS/events{/privacy}","received_events_url":"https://api.github.com/users/SteveSandersonMS/received_events","type":"User","site_admin":false},"body":"Even if this is needed, could you move it into `Views/Home/Index.cshtml`, since it's only that one view that really needs to start up the Aurelia app?","created_at":"2016-10-24T13:26:04Z","updated_at":"2016-10-24T13:26:04Z","html_url":"https://github.com/aspnet/JavaScriptServices/pull/398#discussion_r84686126","pull_request_url":"https://api.github.com/repos/aspnet/JavaScriptServices/pulls/398","_links":{"self":{"href":"https://api.github.com/repos/aspnet/JavaScriptServices/pulls/comments/84686126"},"html":{"href":"https://github.com/aspnet/JavaScriptServices/pull/398#discussion_r84686126"},"pull_request":{"href":"https://api.github.com/repos/aspnet/JavaScriptServices/pulls/398"}}},"pull_request":{"url":"https://api.github.com/repos/aspnet/JavaScriptServices/pulls/398","id":90486238,"html_url":"https://github.com/aspnet/JavaScriptServices/pull/398","diff_url":"https://github.com/aspnet/JavaScriptServices/pull/398.diff","patch_url":"https://github.com/aspnet/JavaScriptServices/pull/398.patch","issue_url":"https://api.github.com/repos/aspnet/JavaScriptServices/issues/398","number":398,"state":"open","locked":false,"title":"Add AureliaSpa template","user":{"login":"kmkatsma","id":22487466,"avatar_url":"https://avatars.githubusercontent.com/u/22487466?v=3","gravatar_id":"","url":"https://api.github.com/users/kmkatsma","html_url":"https://github.com/kmkatsma","followers_url":"https://api.github.com/users/kmkatsma/followers","following_url":"https://api.github.com/users/kmkatsma/following{/other_user}","gists_url":"https://api.github.com/users/kmkatsma/gists{/gist_id}","starred_url":"https://api.github.com/users/kmkatsma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kmkatsma/subscriptions","organizations_url":"https://api.github.com/users/kmkatsma/orgs","repos_url":"https://api.github.com/users/kmkatsma/repos","events_url":"https://api.github.com/users/kmkatsma/events{/privacy}","received_events_url":"https://api.github.com/users/kmkatsma/received_events","type":"User","site_admin":false},"body":"This PR adds a new AureliaSpa folder to the existing templates folder.\r\n\r\nMade attempts to be as consistent as possible with existing templates, but this does follow different webpack template build process - it uses a single webpack config utilizing the AureliaWebpackPlugin.  However, I tried to keep the WebPack configuration consistent with the configurations that exist in official Aurelia webpack skeletons, except EasyWebpack has been removed for closer match to the existing webpack templates in this repo.\r\n\r\nOther things of note with regard to comparison with other templates:\r\n1. The nav css had to be modified to deal with the default class added by aurelia to elements (perhaps there is another way).\r\n2. The menu is build dynamically, instead of statically\r\n3. Single boot file, given no server side rendering\r\n4. The fetchdata.ts has some typings overrides added specifically to deal with some current issues in \"official\" typings files\r\n\r\n@SteveSandersonMS, @MarkPieszak, @EisenbergEffect ","created_at":"2016-10-22T15:57:50Z","updated_at":"2016-10-24T13:31:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"63d6b06d61c83d60814031ef86004807ebf55760","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/aspnet/JavaScriptServices/pulls/398/commits","review_comments_url":"https://api.github.com/repos/aspnet/JavaScriptServices/pulls/398/comments","review_comment_url":"https://api.github.com/repos/aspnet/JavaScriptServices/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aspnet/JavaScriptServices/issues/398/comments","statuses_url":"https://api.github.com/repos/aspnet/JavaScriptServices/statuses/fe5059cddf60468e431ce62520783f502f7e56e3","head":{"label":"kmkatsma:dev","ref":"dev","sha":"fe5059cddf60468e431ce62520783f502f7e56e3","user":{"login":"kmkatsma","id":22487466,"avatar_url":"https://avatars.githubusercontent.com/u/22487466?v=3","gravatar_id":"","url":"https://api.github.com/users/kmkatsma","html_url":"https://github.com/kmkatsma","followers_url":"https://api.github.com/users/kmkatsma/followers","following_url":"https://api.github.com/users/kmkatsma/following{/other_user}","gists_url":"https://api.github.com/users/kmkatsma/gists{/gist_id}","starred_url":"https://api.github.com/users/kmkatsma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kmkatsma/subscriptions","organizations_url":"https://api.github.com/users/kmkatsma/orgs","repos_url":"https://api.github.com/users/kmkatsma/repos","events_url":"https://api.github.com/users/kmkatsma/events{/privacy}","received_events_url":"https://api.github.com/users/kmkatsma/received_events","type":"User","site_admin":false},"repo":{"id":70426240,"name":"JavaScriptServices","full_name":"kmkatsma/JavaScriptServices","owner":{"login":"kmkatsma","id":22487466,"avatar_url":"https://avatars.githubusercontent.com/u/22487466?v=3","gravatar_id":"","url":"https://api.github.com/users/kmkatsma","html_url":"https://github.com/kmkatsma","followers_url":"https://api.github.com/users/kmkatsma/followers","following_url":"https://api.github.com/users/kmkatsma/following{/other_user}","gists_url":"https://api.github.com/users/kmkatsma/gists{/gist_id}","starred_url":"https://api.github.com/users/kmkatsma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kmkatsma/subscriptions","organizations_url":"https://api.github.com/users/kmkatsma/orgs","repos_url":"https://api.github.com/users/kmkatsma/repos","events_url":"https://api.github.com/users/kmkatsma/events{/privacy}","received_events_url":"https://api.github.com/users/kmkatsma/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kmkatsma/JavaScriptServices","description":"Microsoft ASP.NET Core JavaScript Services","fork":true,"url":"https://api.github.com/repos/kmkatsma/JavaScriptServices","forks_url":"https://api.github.com/repos/kmkatsma/JavaScriptServices/forks","keys_url":"https://api.github.com/repos/kmkatsma/JavaScriptServices/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kmkatsma/JavaScriptServices/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kmkatsma/JavaScriptServices/teams","hooks_url":"https://api.github.com/repos/kmkatsma/JavaScriptServices/hooks","issue_events_url":"https://api.github.com/repos/kmkatsma/JavaScriptServices/issues/events{/number}","events_url":"https://api.github.com/repos/kmkatsma/JavaScriptServices/events","assignees_url":"https://api.github.com/repos/kmkatsma/JavaScriptServices/assignees{/user}","branches_url":"https://api.github.com/repos/kmkatsma/JavaScriptServices/branches{/branch}","tags_url":"https://api.github.com/repos/kmkatsma/JavaScriptServices/tags","blobs_url":"https://api.github.com/repos/kmkatsma/JavaScriptServices/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kmkatsma/JavaScriptServices/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kmkatsma/JavaScriptServices/git/refs{/sha}","trees_url":"https://api.github.com/repos/kmkatsma/JavaScriptServices/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kmkatsma/JavaScriptServices/statuses/{sha}","languages_url":"https://api.github.com/repos/kmkatsma/JavaScriptServices/languages","stargazers_url":"https://api.github.com/repos/kmkatsma/JavaScriptServices/stargazers","contributors_url":"https://api.github.com/repos/kmkatsma/JavaScriptServices/contributors","subscribers_url":"https://api.github.com/repos/kmkatsma/JavaScriptServices/subscribers","subscription_url":"https://api.github.com/repos/kmkatsma/JavaScriptServices/subscription","commits_url":"https://api.github.com/repos/kmkatsma/JavaScriptServices/commits{/sha}","git_commits_url":"https://api.github.com/repos/kmkatsma/JavaScriptServices/git/commits{/sha}","comments_url":"https://api.github.com/repos/kmkatsma/JavaScriptServices/comments{/number}","issue_comment_url":"https://api.github.com/repos/kmkatsma/JavaScriptServices/issues/comments{/number}","contents_url":"https://api.github.com/repos/kmkatsma/JavaScriptServices/contents/{+path}","compare_url":"https://api.github.com/repos/kmkatsma/JavaScriptServices/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kmkatsma/JavaScriptServices/merges","archive_url":"https://api.github.com/repos/kmkatsma/JavaScriptServices/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kmkatsma/JavaScriptServices/downloads","issues_url":"https://api.github.com/repos/kmkatsma/JavaScriptServices/issues{/number}","pulls_url":"https://api.github.com/repos/kmkatsma/JavaScriptServices/pulls{/number}","milestones_url":"https://api.github.com/repos/kmkatsma/JavaScriptServices/milestones{/number}","notifications_url":"https://api.github.com/repos/kmkatsma/JavaScriptServices/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kmkatsma/JavaScriptServices/labels{/name}","releases_url":"https://api.github.com/repos/kmkatsma/JavaScriptServices/releases{/id}","deployments_url":"https://api.github.com/repos/kmkatsma/JavaScriptServices/deployments","created_at":"2016-10-09T19:42:14Z","updated_at":"2016-10-09T19:42:16Z","pushed_at":"2016-10-23T16:05:09Z","git_url":"git://github.com/kmkatsma/JavaScriptServices.git","ssh_url":"git@github.com:kmkatsma/JavaScriptServices.git","clone_url":"https://github.com/kmkatsma/JavaScriptServices.git","svn_url":"https://github.com/kmkatsma/JavaScriptServices","homepage":"","size":5204,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"aspnet:dev","ref":"dev","sha":"d858c09b7b614a0f33138e7341a20d4af49464b4","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":45365298,"name":"JavaScriptServices","full_name":"aspnet/JavaScriptServices","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/JavaScriptServices","description":"Microsoft ASP.NET Core JavaScript Services","fork":false,"url":"https://api.github.com/repos/aspnet/JavaScriptServices","forks_url":"https://api.github.com/repos/aspnet/JavaScriptServices/forks","keys_url":"https://api.github.com/repos/aspnet/JavaScriptServices/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/JavaScriptServices/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/JavaScriptServices/teams","hooks_url":"https://api.github.com/repos/aspnet/JavaScriptServices/hooks","issue_events_url":"https://api.github.com/repos/aspnet/JavaScriptServices/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/JavaScriptServices/events","assignees_url":"https://api.github.com/repos/aspnet/JavaScriptServices/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/JavaScriptServices/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/JavaScriptServices/tags","blobs_url":"https://api.github.com/repos/aspnet/JavaScriptServices/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/JavaScriptServices/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/JavaScriptServices/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/JavaScriptServices/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/JavaScriptServices/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/JavaScriptServices/languages","stargazers_url":"https://api.github.com/repos/aspnet/JavaScriptServices/stargazers","contributors_url":"https://api.github.com/repos/aspnet/JavaScriptServices/contributors","subscribers_url":"https://api.github.com/repos/aspnet/JavaScriptServices/subscribers","subscription_url":"https://api.github.com/repos/aspnet/JavaScriptServices/subscription","commits_url":"https://api.github.com/repos/aspnet/JavaScriptServices/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/JavaScriptServices/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/JavaScriptServices/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/JavaScriptServices/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/JavaScriptServices/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/JavaScriptServices/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/JavaScriptServices/merges","archive_url":"https://api.github.com/repos/aspnet/JavaScriptServices/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/JavaScriptServices/downloads","issues_url":"https://api.github.com/repos/aspnet/JavaScriptServices/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/JavaScriptServices/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/JavaScriptServices/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/JavaScriptServices/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/JavaScriptServices/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/JavaScriptServices/releases{/id}","deployments_url":"https://api.github.com/repos/aspnet/JavaScriptServices/deployments","created_at":"2015-11-02T01:24:11Z","updated_at":"2016-10-24T10:30:32Z","pushed_at":"2016-10-24T09:20:01Z","git_url":"git://github.com/aspnet/JavaScriptServices.git","ssh_url":"git@github.com:aspnet/JavaScriptServices.git","clone_url":"https://github.com/aspnet/JavaScriptServices.git","svn_url":"https://github.com/aspnet/JavaScriptServices","homepage":"","size":6271,"stargazers_count":1012,"watchers_count":1012,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":160,"mirror_url":null,"open_issues_count":19,"forks":160,"open_issues":19,"watchers":1012,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/aspnet/JavaScriptServices/pulls/398"},"html":{"href":"https://github.com/aspnet/JavaScriptServices/pull/398"},"issue":{"href":"https://api.github.com/repos/aspnet/JavaScriptServices/issues/398"},"comments":{"href":"https://api.github.com/repos/aspnet/JavaScriptServices/issues/398/comments"},"review_comments":{"href":"https://api.github.com/repos/aspnet/JavaScriptServices/pulls/398/comments"},"review_comment":{"href":"https://api.github.com/repos/aspnet/JavaScriptServices/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aspnet/JavaScriptServices/pulls/398/commits"},"statuses":{"href":"https://api.github.com/repos/aspnet/JavaScriptServices/statuses/fe5059cddf60468e431ce62520783f502f7e56e3"}}}}
{"actor":{"display_login":"SteveSandersonMS"}}