{"action":"created","comment":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/74587128","id":74587128,"diff_hunk":"@@ -27,38 +28,14 @@\n #include \"DolphinWX/X11Utils.h\"\n #endif\n \n-static const wxLanguage language_ids[] = {\n-    wxLANGUAGE_DEFAULT,\n-\n-    wxLANGUAGE_MALAY,\n-    wxLANGUAGE_CATALAN,\n-    wxLANGUAGE_CZECH,\n-    wxLANGUAGE_DANISH,\n-    wxLANGUAGE_GERMAN,\n-    wxLANGUAGE_ENGLISH,\n-    wxLANGUAGE_SPANISH,\n-    wxLANGUAGE_FRENCH,\n-    wxLANGUAGE_CROATIAN,\n-    wxLANGUAGE_ITALIAN,\n-    wxLANGUAGE_HUNGARIAN,\n-    wxLANGUAGE_DUTCH,\n-    wxLANGUAGE_NORWEGIAN_BOKMAL,\n-    wxLANGUAGE_POLISH,\n-    wxLANGUAGE_PORTUGUESE,\n-    wxLANGUAGE_PORTUGUESE_BRAZILIAN,\n-    wxLANGUAGE_ROMANIAN,\n-    wxLANGUAGE_SERBIAN,\n-    wxLANGUAGE_SWEDISH,\n-    wxLANGUAGE_TURKISH,\n-\n-    wxLANGUAGE_GREEK,\n-    wxLANGUAGE_RUSSIAN,\n-    wxLANGUAGE_ARABIC,\n-    wxLANGUAGE_FARSI,\n-    wxLANGUAGE_KOREAN,\n-    wxLANGUAGE_JAPANESE,\n-    wxLANGUAGE_CHINESE_SIMPLIFIED,\n-    wxLANGUAGE_CHINESE_TRADITIONAL,\n+static const std::string language_ids[] = {\n+    \"\",\n+\n+    \"ms\", \"ca\", \"cs\",    \"da\", \"de\", \"en\", \"es\",    \"fr\",    \"hr\", \"it\", \"hu\", \"nl\",\n+    \"nb\",  // wxWidgets won't accept \"no\"\n+    \"pl\", \"pt\", \"pt_BR\", \"ro\", \"sr\", \"sv\", \"tr\",\n+\n+    \"el\", \"ru\", \"ar\",    \"fa\", \"ko\", \"ja\", \"zh_CN\", \"zh_TW\",","path":"Source/Core/DolphinWX/Config/InterfaceConfigPane.cpp","position":51,"original_position":51,"commit_id":"70fe5260c2eb35329b1a3ae0b046443789350f0b","original_commit_id":"70fe5260c2eb35329b1a3ae0b046443789350f0b","user":{"login":"JosJuice","id":6716818,"avatar_url":"https://avatars.githubusercontent.com/u/6716818?v=3","gravatar_id":"","url":"https://api.github.com/users/JosJuice","html_url":"https://github.com/JosJuice","followers_url":"https://api.github.com/users/JosJuice/followers","following_url":"https://api.github.com/users/JosJuice/following{/other_user}","gists_url":"https://api.github.com/users/JosJuice/gists{/gist_id}","starred_url":"https://api.github.com/users/JosJuice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JosJuice/subscriptions","organizations_url":"https://api.github.com/users/JosJuice/orgs","repos_url":"https://api.github.com/users/JosJuice/repos","events_url":"https://api.github.com/users/JosJuice/events{/privacy}","received_events_url":"https://api.github.com/users/JosJuice/received_events","type":"User","site_admin":false},"body":"To clarify, I can force things into separate lines by inserting an empty line between them, but everything else I do is enforced by `clang-format`. I wanted to make it look like it looked before my commit, or possibly put more than one per line, but not with this strange spacing. The reason we get it is because `clang-format` wants to align the strings so that the n'th string on each line starts at the same column as the n'th string of all other lines.","created_at":"2016-08-12T13:08:02Z","updated_at":"2016-08-12T13:08:02Z","html_url":"https://github.com/dolphin-emu/dolphin/pull/4117#discussion_r74587128","pull_request_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/4117","_links":{"self":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/74587128"},"html":{"href":"https://github.com/dolphin-emu/dolphin/pull/4117#discussion_r74587128"},"pull_request":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/4117"}}},"pull_request":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/4117","id":81109383,"html_url":"https://github.com/dolphin-emu/dolphin/pull/4117","diff_url":"https://github.com/dolphin-emu/dolphin/pull/4117.diff","patch_url":"https://github.com/dolphin-emu/dolphin/pull/4117.patch","issue_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/4117","number":4117,"state":"open","locked":false,"title":"Save GUI language as string instead of wxLanguage enum","user":{"login":"JosJuice","id":6716818,"avatar_url":"https://avatars.githubusercontent.com/u/6716818?v=3","gravatar_id":"","url":"https://api.github.com/users/JosJuice","html_url":"https://github.com/JosJuice","followers_url":"https://api.github.com/users/JosJuice/followers","following_url":"https://api.github.com/users/JosJuice/following{/other_user}","gists_url":"https://api.github.com/users/JosJuice/gists{/gist_id}","starred_url":"https://api.github.com/users/JosJuice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JosJuice/subscriptions","organizations_url":"https://api.github.com/users/JosJuice/orgs","repos_url":"https://api.github.com/users/JosJuice/repos","events_url":"https://api.github.com/users/JosJuice/events{/privacy}","received_events_url":"https://api.github.com/users/JosJuice/received_events","type":"User","site_admin":false},"body":"When 5.0-211 updated wxWidgets to 3.1.0, some entries in the wxLanguage enum were moved and added, changing the wxLanguage values. Because we save Dolphin's interface language to disk as a wxLanguage, the language you have set will mean something different depending on whether you have the updated wx version or not. For instance, setting the language to English with the updated version and then using an older version will make Dolphin use Dutch. Because we can't rely on the enum anymore, I'm replacing the \"Language\" setting with a \"LanguageCode\" setting that uses standard ISO 639 codes.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/dolphin-emu/dolphin/4117)\n<!-- Reviewable:end -->\n","created_at":"2016-08-12T12:12:04Z","updated_at":"2016-08-12T13:08:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8f054cb13b49d9dba55884a199aab6ad663531a9","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/4117/commits","review_comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/4117/comments","review_comment_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/4117/comments","statuses_url":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/70fe5260c2eb35329b1a3ae0b046443789350f0b","head":{"label":"JosJuice:wx-language-code","ref":"wx-language-code","sha":"70fe5260c2eb35329b1a3ae0b046443789350f0b","user":{"login":"JosJuice","id":6716818,"avatar_url":"https://avatars.githubusercontent.com/u/6716818?v=3","gravatar_id":"","url":"https://api.github.com/users/JosJuice","html_url":"https://github.com/JosJuice","followers_url":"https://api.github.com/users/JosJuice/followers","following_url":"https://api.github.com/users/JosJuice/following{/other_user}","gists_url":"https://api.github.com/users/JosJuice/gists{/gist_id}","starred_url":"https://api.github.com/users/JosJuice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JosJuice/subscriptions","organizations_url":"https://api.github.com/users/JosJuice/orgs","repos_url":"https://api.github.com/users/JosJuice/repos","events_url":"https://api.github.com/users/JosJuice/events{/privacy}","received_events_url":"https://api.github.com/users/JosJuice/received_events","type":"User","site_admin":false},"repo":{"id":26057138,"name":"dolphin","full_name":"JosJuice/dolphin","owner":{"login":"JosJuice","id":6716818,"avatar_url":"https://avatars.githubusercontent.com/u/6716818?v=3","gravatar_id":"","url":"https://api.github.com/users/JosJuice","html_url":"https://github.com/JosJuice","followers_url":"https://api.github.com/users/JosJuice/followers","following_url":"https://api.github.com/users/JosJuice/following{/other_user}","gists_url":"https://api.github.com/users/JosJuice/gists{/gist_id}","starred_url":"https://api.github.com/users/JosJuice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JosJuice/subscriptions","organizations_url":"https://api.github.com/users/JosJuice/orgs","repos_url":"https://api.github.com/users/JosJuice/repos","events_url":"https://api.github.com/users/JosJuice/events{/privacy}","received_events_url":"https://api.github.com/users/JosJuice/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JosJuice/dolphin","description":"Dolphin is a GameCube/Wii emulator, allowing you to play games for these two platforms on PC, with improvements.","fork":true,"url":"https://api.github.com/repos/JosJuice/dolphin","forks_url":"https://api.github.com/repos/JosJuice/dolphin/forks","keys_url":"https://api.github.com/repos/JosJuice/dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JosJuice/dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JosJuice/dolphin/teams","hooks_url":"https://api.github.com/repos/JosJuice/dolphin/hooks","issue_events_url":"https://api.github.com/repos/JosJuice/dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/JosJuice/dolphin/events","assignees_url":"https://api.github.com/repos/JosJuice/dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/JosJuice/dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/JosJuice/dolphin/tags","blobs_url":"https://api.github.com/repos/JosJuice/dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JosJuice/dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JosJuice/dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/JosJuice/dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JosJuice/dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/JosJuice/dolphin/languages","stargazers_url":"https://api.github.com/repos/JosJuice/dolphin/stargazers","contributors_url":"https://api.github.com/repos/JosJuice/dolphin/contributors","subscribers_url":"https://api.github.com/repos/JosJuice/dolphin/subscribers","subscription_url":"https://api.github.com/repos/JosJuice/dolphin/subscription","commits_url":"https://api.github.com/repos/JosJuice/dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/JosJuice/dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/JosJuice/dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/JosJuice/dolphin/issues/comments{/number}","contents_url":"https://api.github.com/repos/JosJuice/dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/JosJuice/dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JosJuice/dolphin/merges","archive_url":"https://api.github.com/repos/JosJuice/dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JosJuice/dolphin/downloads","issues_url":"https://api.github.com/repos/JosJuice/dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/JosJuice/dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/JosJuice/dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/JosJuice/dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JosJuice/dolphin/labels{/name}","releases_url":"https://api.github.com/repos/JosJuice/dolphin/releases{/id}","deployments_url":"https://api.github.com/repos/JosJuice/dolphin/deployments","created_at":"2014-11-01T17:12:40Z","updated_at":"2016-01-19T12:12:07Z","pushed_at":"2016-08-12T12:22:34Z","git_url":"git://github.com/JosJuice/dolphin.git","ssh_url":"git@github.com:JosJuice/dolphin.git","clone_url":"https://github.com/JosJuice/dolphin.git","svn_url":"https://github.com/JosJuice/dolphin","homepage":null,"size":261882,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"dolphin-emu:master","ref":"master","sha":"0bd5db3e05706950a62c164745497f9cd51402eb","user":{"login":"dolphin-emu","id":5050316,"avatar_url":"https://avatars.githubusercontent.com/u/5050316?v=3","gravatar_id":"","url":"https://api.github.com/users/dolphin-emu","html_url":"https://github.com/dolphin-emu","followers_url":"https://api.github.com/users/dolphin-emu/followers","following_url":"https://api.github.com/users/dolphin-emu/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu/orgs","repos_url":"https://api.github.com/users/dolphin-emu/repos","events_url":"https://api.github.com/users/dolphin-emu/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu/received_events","type":"Organization","site_admin":false},"repo":{"id":11577304,"name":"dolphin","full_name":"dolphin-emu/dolphin","owner":{"login":"dolphin-emu","id":5050316,"avatar_url":"https://avatars.githubusercontent.com/u/5050316?v=3","gravatar_id":"","url":"https://api.github.com/users/dolphin-emu","html_url":"https://github.com/dolphin-emu","followers_url":"https://api.github.com/users/dolphin-emu/followers","following_url":"https://api.github.com/users/dolphin-emu/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu/orgs","repos_url":"https://api.github.com/users/dolphin-emu/repos","events_url":"https://api.github.com/users/dolphin-emu/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dolphin-emu/dolphin","description":"Dolphin is a GameCube / Wii emulator, allowing you to play games for these two platforms on PC with improvements.","fork":false,"url":"https://api.github.com/repos/dolphin-emu/dolphin","forks_url":"https://api.github.com/repos/dolphin-emu/dolphin/forks","keys_url":"https://api.github.com/repos/dolphin-emu/dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dolphin-emu/dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dolphin-emu/dolphin/teams","hooks_url":"https://api.github.com/repos/dolphin-emu/dolphin/hooks","issue_events_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/dolphin-emu/dolphin/events","assignees_url":"https://api.github.com/repos/dolphin-emu/dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/dolphin-emu/dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/dolphin-emu/dolphin/tags","blobs_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/dolphin-emu/dolphin/languages","stargazers_url":"https://api.github.com/repos/dolphin-emu/dolphin/stargazers","contributors_url":"https://api.github.com/repos/dolphin-emu/dolphin/contributors","subscribers_url":"https://api.github.com/repos/dolphin-emu/dolphin/subscribers","subscription_url":"https://api.github.com/repos/dolphin-emu/dolphin/subscription","commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/comments{/number}","contents_url":"https://api.github.com/repos/dolphin-emu/dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/dolphin-emu/dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dolphin-emu/dolphin/merges","archive_url":"https://api.github.com/repos/dolphin-emu/dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dolphin-emu/dolphin/downloads","issues_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/dolphin-emu/dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/dolphin-emu/dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dolphin-emu/dolphin/labels{/name}","releases_url":"https://api.github.com/repos/dolphin-emu/dolphin/releases{/id}","deployments_url":"https://api.github.com/repos/dolphin-emu/dolphin/deployments","created_at":"2013-07-22T09:07:57Z","updated_at":"2016-08-12T01:18:15Z","pushed_at":"2016-08-12T12:57:35Z","git_url":"git://github.com/dolphin-emu/dolphin.git","ssh_url":"git@github.com:dolphin-emu/dolphin.git","clone_url":"https://github.com/dolphin-emu/dolphin.git","svn_url":"https://github.com/dolphin-emu/dolphin","homepage":"https://dolphin-emu.org/","size":324181,"stargazers_count":2584,"watchers_count":2584,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":714,"mirror_url":null,"open_issues_count":127,"forks":714,"open_issues":127,"watchers":2584,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/4117"},"html":{"href":"https://github.com/dolphin-emu/dolphin/pull/4117"},"issue":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/issues/4117"},"comments":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/issues/4117/comments"},"review_comments":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/4117/comments"},"review_comment":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/4117/commits"},"statuses":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/70fe5260c2eb35329b1a3ae0b046443789350f0b"}}}}
{"actor":{"display_login":"JosJuice"}}