{"action":"created","comment":{"url":"https://api.github.com/repos/collectd/collectd/pulls/comments/91747748","pull_request_review_id":12259528,"id":91747748,"diff_hunk":"@@ -201,15 +201,19 @@ See also: http://dpdk.org/doc/guides/prog_guide/multi_proc_support.html\n  *  Generate the build script as specified below. (i.e. run `build.sh`).\n  *  Configure collectd with the DPDK shared library:\n \n-        ./configure --with-libdpdk=/usr\n+        ./configure LIBDPDK_CPPFLAGS=\"-I/usr/include/dpdk\" LIBDPDK_LDFLAGS=\"-L/usr/lib\"\n+\n+**Note:** Modify these flags according to specific environment setup.\n+LIBDPDK_CPPFLAGS should contain path to dpdk headers and  LIBDPDK_LDFLAGS should\n+point out to dpdk libraries location.\n \n ### Build with the static DPDK library\n \n To configure collectd with the DPDK static library:\n \n  *  Run *configure* with the following CFLAGS:\n \n-        ./configure --with-libdpdk=/usr CFLAGS=\" -lpthread -Wl,--whole-archive -Wl,-ldpdk -Wl,-lm -Wl,-lrt -Wl,-lpcap -Wl,-ldl -Wl,--no-whole-archive\"\n+        ./configure LIBDPDK_CPPFLAGS=\"-I/usr/include/dpdk\" LIBDPDK_LDFLAGS=\"-L/usr/lib\" CFLAGS=\" -lpthread -Wl,--whole-archive -Wl,-ldpdk -Wl,-lm -Wl,-lrt -Wl,-lpcap -Wl,-ldl -Wl,--no-whole-archive\"\n \n  *  Make sure that dpdk and dpdkstat are enabled in the *configure* output.","path":"docs/BUILD.dpdkstat.md","position":20,"original_position":20,"commit_id":"d00322d2d3bd87ac263740984dc2bfb690596429","original_commit_id":"d00322d2d3bd87ac263740984dc2bfb690596429","user":{"login":"rubenk","id":47338,"avatar_url":"https://avatars.githubusercontent.com/u/47338?v=3","gravatar_id":"","url":"https://api.github.com/users/rubenk","html_url":"https://github.com/rubenk","followers_url":"https://api.github.com/users/rubenk/followers","following_url":"https://api.github.com/users/rubenk/following{/other_user}","gists_url":"https://api.github.com/users/rubenk/gists{/gist_id}","starred_url":"https://api.github.com/users/rubenk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubenk/subscriptions","organizations_url":"https://api.github.com/users/rubenk/orgs","repos_url":"https://api.github.com/users/rubenk/repos","events_url":"https://api.github.com/users/rubenk/events{/privacy}","received_events_url":"https://api.github.com/users/rubenk/received_events","type":"User","site_admin":false},"body":"libdpdk, might be nice to fix this too.","created_at":"2016-12-09T16:28:13Z","updated_at":"2016-12-09T16:28:13Z","html_url":"https://github.com/collectd/collectd/pull/2095#discussion_r91747748","pull_request_url":"https://api.github.com/repos/collectd/collectd/pulls/2095","_links":{"self":{"href":"https://api.github.com/repos/collectd/collectd/pulls/comments/91747748"},"html":{"href":"https://github.com/collectd/collectd/pull/2095#discussion_r91747748"},"pull_request":{"href":"https://api.github.com/repos/collectd/collectd/pulls/2095"}}},"pull_request":{"url":"https://api.github.com/repos/collectd/collectd/pulls/2095","id":97336342,"html_url":"https://github.com/collectd/collectd/pull/2095","diff_url":"https://github.com/collectd/collectd/pull/2095.diff","patch_url":"https://github.com/collectd/collectd/pull/2095.patch","issue_url":"https://api.github.com/repos/collectd/collectd/issues/2095","number":2095,"state":"open","locked":false,"title":"dpdkstat plugin rework","user":{"login":"krzysztofx","id":22101129,"avatar_url":"https://avatars.githubusercontent.com/u/22101129?v=3","gravatar_id":"","url":"https://api.github.com/users/krzysztofx","html_url":"https://github.com/krzysztofx","followers_url":"https://api.github.com/users/krzysztofx/followers","following_url":"https://api.github.com/users/krzysztofx/following{/other_user}","gists_url":"https://api.github.com/users/krzysztofx/gists{/gist_id}","starred_url":"https://api.github.com/users/krzysztofx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krzysztofx/subscriptions","organizations_url":"https://api.github.com/users/krzysztofx/orgs","repos_url":"https://api.github.com/users/krzysztofx/repos","events_url":"https://api.github.com/users/krzysztofx/events{/privacy}","received_events_url":"https://api.github.com/users/krzysztofx/received_events","type":"User","site_admin":false},"body":"This patch contains rework of existing dpdkstat plugin. Changes are focused on\r\nextracting common dpdk related features into utils file that could be reused by\r\nother DPDK plugins. Also some related structural changes are introduced.\r\n\r\nList of changes:\r\n- introduction of new utils_dpdk.c that handles child process spawning,\r\n  and terminating, messaging between parent and child, DPDK configuration\r\n  and initialization and DPDK commands execution\r\n- DPDK EAL specific options put into separate subsection of\r\n  dpdkstat configuration\r\n- documentation update\r\n\r\nThose changes are preparatory steps for upstreaming dpdkevent plugin\r\nthat is going to collect DPDK ports and logical cores status info.\r\n\r\nSigned-off-by: Krzysztof Matczak <krzysztofx.matczak@intel.com>","created_at":"2016-12-09T16:16:47Z","updated_at":"2016-12-09T16:28:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e27076b2487987f5bfa9d0cb4fd7e5a21d3978d6","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/collectd/collectd/pulls/2095/commits","review_comments_url":"https://api.github.com/repos/collectd/collectd/pulls/2095/comments","review_comment_url":"https://api.github.com/repos/collectd/collectd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/collectd/collectd/issues/2095/comments","statuses_url":"https://api.github.com/repos/collectd/collectd/statuses/d00322d2d3bd87ac263740984dc2bfb690596429","head":{"label":"maryamtahhan:dpdkstat_utils_rework","ref":"dpdkstat_utils_rework","sha":"d00322d2d3bd87ac263740984dc2bfb690596429","user":{"login":"maryamtahhan","id":5012288,"avatar_url":"https://avatars.githubusercontent.com/u/5012288?v=3","gravatar_id":"","url":"https://api.github.com/users/maryamtahhan","html_url":"https://github.com/maryamtahhan","followers_url":"https://api.github.com/users/maryamtahhan/followers","following_url":"https://api.github.com/users/maryamtahhan/following{/other_user}","gists_url":"https://api.github.com/users/maryamtahhan/gists{/gist_id}","starred_url":"https://api.github.com/users/maryamtahhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maryamtahhan/subscriptions","organizations_url":"https://api.github.com/users/maryamtahhan/orgs","repos_url":"https://api.github.com/users/maryamtahhan/repos","events_url":"https://api.github.com/users/maryamtahhan/events{/privacy}","received_events_url":"https://api.github.com/users/maryamtahhan/received_events","type":"User","site_admin":false},"repo":{"id":55240614,"name":"collectd","full_name":"maryamtahhan/collectd","owner":{"login":"maryamtahhan","id":5012288,"avatar_url":"https://avatars.githubusercontent.com/u/5012288?v=3","gravatar_id":"","url":"https://api.github.com/users/maryamtahhan","html_url":"https://github.com/maryamtahhan","followers_url":"https://api.github.com/users/maryamtahhan/followers","following_url":"https://api.github.com/users/maryamtahhan/following{/other_user}","gists_url":"https://api.github.com/users/maryamtahhan/gists{/gist_id}","starred_url":"https://api.github.com/users/maryamtahhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maryamtahhan/subscriptions","organizations_url":"https://api.github.com/users/maryamtahhan/orgs","repos_url":"https://api.github.com/users/maryamtahhan/repos","events_url":"https://api.github.com/users/maryamtahhan/events{/privacy}","received_events_url":"https://api.github.com/users/maryamtahhan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/maryamtahhan/collectd","description":"The system statistics collection daemon - repo for new features to be merged into mainline collectd. Mirror of the canonical repository (updated automatically). Please send Pull Requests here!","fork":true,"url":"https://api.github.com/repos/maryamtahhan/collectd","forks_url":"https://api.github.com/repos/maryamtahhan/collectd/forks","keys_url":"https://api.github.com/repos/maryamtahhan/collectd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/maryamtahhan/collectd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/maryamtahhan/collectd/teams","hooks_url":"https://api.github.com/repos/maryamtahhan/collectd/hooks","issue_events_url":"https://api.github.com/repos/maryamtahhan/collectd/issues/events{/number}","events_url":"https://api.github.com/repos/maryamtahhan/collectd/events","assignees_url":"https://api.github.com/repos/maryamtahhan/collectd/assignees{/user}","branches_url":"https://api.github.com/repos/maryamtahhan/collectd/branches{/branch}","tags_url":"https://api.github.com/repos/maryamtahhan/collectd/tags","blobs_url":"https://api.github.com/repos/maryamtahhan/collectd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/maryamtahhan/collectd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/maryamtahhan/collectd/git/refs{/sha}","trees_url":"https://api.github.com/repos/maryamtahhan/collectd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/maryamtahhan/collectd/statuses/{sha}","languages_url":"https://api.github.com/repos/maryamtahhan/collectd/languages","stargazers_url":"https://api.github.com/repos/maryamtahhan/collectd/stargazers","contributors_url":"https://api.github.com/repos/maryamtahhan/collectd/contributors","subscribers_url":"https://api.github.com/repos/maryamtahhan/collectd/subscribers","subscription_url":"https://api.github.com/repos/maryamtahhan/collectd/subscription","commits_url":"https://api.github.com/repos/maryamtahhan/collectd/commits{/sha}","git_commits_url":"https://api.github.com/repos/maryamtahhan/collectd/git/commits{/sha}","comments_url":"https://api.github.com/repos/maryamtahhan/collectd/comments{/number}","issue_comment_url":"https://api.github.com/repos/maryamtahhan/collectd/issues/comments{/number}","contents_url":"https://api.github.com/repos/maryamtahhan/collectd/contents/{+path}","compare_url":"https://api.github.com/repos/maryamtahhan/collectd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/maryamtahhan/collectd/merges","archive_url":"https://api.github.com/repos/maryamtahhan/collectd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/maryamtahhan/collectd/downloads","issues_url":"https://api.github.com/repos/maryamtahhan/collectd/issues{/number}","pulls_url":"https://api.github.com/repos/maryamtahhan/collectd/pulls{/number}","milestones_url":"https://api.github.com/repos/maryamtahhan/collectd/milestones{/number}","notifications_url":"https://api.github.com/repos/maryamtahhan/collectd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/maryamtahhan/collectd/labels{/name}","releases_url":"https://api.github.com/repos/maryamtahhan/collectd/releases{/id}","deployments_url":"https://api.github.com/repos/maryamtahhan/collectd/deployments","created_at":"2016-04-01T15:03:06Z","updated_at":"2016-10-28T10:08:29Z","pushed_at":"2016-12-09T15:57:11Z","git_url":"git://github.com/maryamtahhan/collectd.git","ssh_url":"git@github.com:maryamtahhan/collectd.git","clone_url":"https://github.com/maryamtahhan/collectd.git","svn_url":"https://github.com/maryamtahhan/collectd","homepage":"http://collectd.org/","size":16701,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"collectd:master","ref":"master","sha":"7d38f289053cc7907e18026519fb37b29f3a45a4","user":{"login":"collectd","id":1027481,"avatar_url":"https://avatars.githubusercontent.com/u/1027481?v=3","gravatar_id":"","url":"https://api.github.com/users/collectd","html_url":"https://github.com/collectd","followers_url":"https://api.github.com/users/collectd/followers","following_url":"https://api.github.com/users/collectd/following{/other_user}","gists_url":"https://api.github.com/users/collectd/gists{/gist_id}","starred_url":"https://api.github.com/users/collectd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/collectd/subscriptions","organizations_url":"https://api.github.com/users/collectd/orgs","repos_url":"https://api.github.com/users/collectd/repos","events_url":"https://api.github.com/users/collectd/events{/privacy}","received_events_url":"https://api.github.com/users/collectd/received_events","type":"Organization","site_admin":false},"repo":{"id":3208640,"name":"collectd","full_name":"collectd/collectd","owner":{"login":"collectd","id":1027481,"avatar_url":"https://avatars.githubusercontent.com/u/1027481?v=3","gravatar_id":"","url":"https://api.github.com/users/collectd","html_url":"https://github.com/collectd","followers_url":"https://api.github.com/users/collectd/followers","following_url":"https://api.github.com/users/collectd/following{/other_user}","gists_url":"https://api.github.com/users/collectd/gists{/gist_id}","starred_url":"https://api.github.com/users/collectd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/collectd/subscriptions","organizations_url":"https://api.github.com/users/collectd/orgs","repos_url":"https://api.github.com/users/collectd/repos","events_url":"https://api.github.com/users/collectd/events{/privacy}","received_events_url":"https://api.github.com/users/collectd/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/collectd/collectd","description":"The system statistics collection daemon. Please send Pull Requests here!","fork":false,"url":"https://api.github.com/repos/collectd/collectd","forks_url":"https://api.github.com/repos/collectd/collectd/forks","keys_url":"https://api.github.com/repos/collectd/collectd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/collectd/collectd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/collectd/collectd/teams","hooks_url":"https://api.github.com/repos/collectd/collectd/hooks","issue_events_url":"https://api.github.com/repos/collectd/collectd/issues/events{/number}","events_url":"https://api.github.com/repos/collectd/collectd/events","assignees_url":"https://api.github.com/repos/collectd/collectd/assignees{/user}","branches_url":"https://api.github.com/repos/collectd/collectd/branches{/branch}","tags_url":"https://api.github.com/repos/collectd/collectd/tags","blobs_url":"https://api.github.com/repos/collectd/collectd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/collectd/collectd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/collectd/collectd/git/refs{/sha}","trees_url":"https://api.github.com/repos/collectd/collectd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/collectd/collectd/statuses/{sha}","languages_url":"https://api.github.com/repos/collectd/collectd/languages","stargazers_url":"https://api.github.com/repos/collectd/collectd/stargazers","contributors_url":"https://api.github.com/repos/collectd/collectd/contributors","subscribers_url":"https://api.github.com/repos/collectd/collectd/subscribers","subscription_url":"https://api.github.com/repos/collectd/collectd/subscription","commits_url":"https://api.github.com/repos/collectd/collectd/commits{/sha}","git_commits_url":"https://api.github.com/repos/collectd/collectd/git/commits{/sha}","comments_url":"https://api.github.com/repos/collectd/collectd/comments{/number}","issue_comment_url":"https://api.github.com/repos/collectd/collectd/issues/comments{/number}","contents_url":"https://api.github.com/repos/collectd/collectd/contents/{+path}","compare_url":"https://api.github.com/repos/collectd/collectd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/collectd/collectd/merges","archive_url":"https://api.github.com/repos/collectd/collectd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/collectd/collectd/downloads","issues_url":"https://api.github.com/repos/collectd/collectd/issues{/number}","pulls_url":"https://api.github.com/repos/collectd/collectd/pulls{/number}","milestones_url":"https://api.github.com/repos/collectd/collectd/milestones{/number}","notifications_url":"https://api.github.com/repos/collectd/collectd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/collectd/collectd/labels{/name}","releases_url":"https://api.github.com/repos/collectd/collectd/releases{/id}","deployments_url":"https://api.github.com/repos/collectd/collectd/deployments","created_at":"2012-01-18T13:07:51Z","updated_at":"2016-12-07T09:38:36Z","pushed_at":"2016-12-09T16:21:20Z","git_url":"git://github.com/collectd/collectd.git","ssh_url":"git@github.com:collectd/collectd.git","clone_url":"https://github.com/collectd/collectd.git","svn_url":"https://github.com/collectd/collectd","homepage":"http://collectd.org/","size":36659,"stargazers_count":1364,"watchers_count":1364,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":762,"mirror_url":null,"open_issues_count":315,"forks":762,"open_issues":315,"watchers":1364,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/collectd/collectd/pulls/2095"},"html":{"href":"https://github.com/collectd/collectd/pull/2095"},"issue":{"href":"https://api.github.com/repos/collectd/collectd/issues/2095"},"comments":{"href":"https://api.github.com/repos/collectd/collectd/issues/2095/comments"},"review_comments":{"href":"https://api.github.com/repos/collectd/collectd/pulls/2095/comments"},"review_comment":{"href":"https://api.github.com/repos/collectd/collectd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/collectd/collectd/pulls/2095/commits"},"statuses":{"href":"https://api.github.com/repos/collectd/collectd/statuses/d00322d2d3bd87ac263740984dc2bfb690596429"}}}}
{"actor":{"display_login":"rubenk"}}