{"action":"created","issue":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/17749","repository_url":"https://api.github.com/repos/NixOS/nixpkgs","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/17749/labels{/name}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/17749/comments","events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/17749/events","html_url":"https://github.com/NixOS/nixpkgs/pull/17749","id":171139416,"number":17749,"title":"wrapPythonProgram: use site.addsitedir instead of PYTHONPATH","user":{"login":"abbradar","id":1174810,"avatar_url":"https://avatars.githubusercontent.com/u/1174810?v=3","gravatar_id":"","url":"https://api.github.com/users/abbradar","html_url":"https://github.com/abbradar","followers_url":"https://api.github.com/users/abbradar/followers","following_url":"https://api.github.com/users/abbradar/following{/other_user}","gists_url":"https://api.github.com/users/abbradar/gists{/gist_id}","starred_url":"https://api.github.com/users/abbradar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abbradar/subscriptions","organizations_url":"https://api.github.com/users/abbradar/orgs","repos_url":"https://api.github.com/users/abbradar/repos","events_url":"https://api.github.com/users/abbradar/events{/privacy}","received_events_url":"https://api.github.com/users/abbradar/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/0.kind:%20bug","name":"0.kind: bug","color":"84b6eb"},{"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/1.severity:%20mass-rebuild","name":"1.severity: mass-rebuild","color":"e11d21"},{"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/6.topic:%20python","name":"6.topic: python","color":"fef2c0"}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":54,"created_at":"2016-08-15T09:43:02Z","updated_at":"2016-09-16T16:41:12Z","closed_at":"2016-08-19T21:44:38Z","pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/17749","html_url":"https://github.com/NixOS/nixpkgs/pull/17749","diff_url":"https://github.com/NixOS/nixpkgs/pull/17749.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/17749.patch"},"body":"###### Motivation for this change\r\n\r\nConsider two applications, \"a\" and \"b\". \"a\" uses Python 2.7 and enum34, which exports `enum` module. It calls \"b\" via exec, which uses Python 3.5. In this Python there's its own `enum` module, but it's overridden by enum34 because it's in `PYTHONPATH`. As a result `enum` module doesn't work and there are weird errors.\r\n\r\nReal life example: `gajim` calls `qutebrowser` to open an URL, which crashes instead.\r\n\r\nI don't know any better solution to this problem than the proposed patch. It looks good to me but it can potentially break some workflows which somehow rely on `PYTHONPATH` postfixes.\r\n\r\n###### Things done\r\n\r\n- [ ] Tested using sandboxing\r\n  ([nix.useChroot](http://nixos.org/nixos/manual/options.html#opt-nix.useChroot) on NixOS,\r\n    or option `build-use-chroot` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file)\r\n    on non-NixOS)\r\n- Built on platform(s)\r\n   - [ ] NixOS\r\n   - [ ] OS X\r\n   - [ ] Linux\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [ ] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\n\r\ncc @domenkozar "},"comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments/247648708","html_url":"https://github.com/NixOS/nixpkgs/pull/17749#issuecomment-247648708","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/17749","id":247648708,"user":{"login":"abbradar","id":1174810,"avatar_url":"https://avatars.githubusercontent.com/u/1174810?v=3","gravatar_id":"","url":"https://api.github.com/users/abbradar","html_url":"https://github.com/abbradar","followers_url":"https://api.github.com/users/abbradar/followers","following_url":"https://api.github.com/users/abbradar/following{/other_user}","gists_url":"https://api.github.com/users/abbradar/gists{/gist_id}","starred_url":"https://api.github.com/users/abbradar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abbradar/subscriptions","organizations_url":"https://api.github.com/users/abbradar/orgs","repos_url":"https://api.github.com/users/abbradar/repos","events_url":"https://api.github.com/users/abbradar/events{/privacy}","received_events_url":"https://api.github.com/users/abbradar/received_events","type":"User","site_admin":false},"created_at":"2016-09-16T16:41:12Z","updated_at":"2016-09-16T16:41:12Z","body":"@domenkozar Again, this is _already_ in 16.09 -- see also for example https://github.com/NixOS/nixpkgs/commit/db31282f087f4100e7d7845f34ce888c42ac6fd3 (notice `16.09-beta` tag)."}}
{"actor":{"display_login":"abbradar"}}