{"action":"created","comment":{"url":"https://api.github.com/repos/fabric8io-images/s2i/pulls/comments/82762383","pull_request_review_id":3644220,"id":82762383,"diff_hunk":"@@ -1,8 +1,5 @@\n #!/bin/sh","path":"java/templates/jolokia-opts","position":1,"original_position":1,"commit_id":"74380f0c67eacae4a1800bbd9a91a80399f71a5f","original_commit_id":"74380f0c67eacae4a1800bbd9a91a80399f71a5f","user":{"login":"rhuss","id":99080,"avatar_url":"https://avatars.githubusercontent.com/u/99080?v=3","gravatar_id":"","url":"https://api.github.com/users/rhuss","html_url":"https://github.com/rhuss","followers_url":"https://api.github.com/users/rhuss/followers","following_url":"https://api.github.com/users/rhuss/following{/other_user}","gists_url":"https://api.github.com/users/rhuss/gists{/gist_id}","starred_url":"https://api.github.com/users/rhuss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhuss/subscriptions","organizations_url":"https://api.github.com/users/rhuss/orgs","repos_url":"https://api.github.com/users/rhuss/repos","events_url":"https://api.github.com/users/rhuss/events{/privacy}","received_events_url":"https://api.github.com/users/rhuss/received_events","type":"User","site_admin":false},"body":"I'm a bit confused, why jolokia-opts is included in the template directory as its origin is from `agent-bond` where it is [maintained](https://github.com/fabric8io/agent-bond/blob/master/fish-pepper/jolokia/fp-files/jolokia-opts) and then included via the block in [fish-pepper.yml](https://github.com/fabric8io-images/s2i/blob/master/java/fish-pepper.yml#L16). \r\n\r\nTo resolve this, one of the following should be done:\r\n\r\n* Either remove the block reference in fish-pepper.yml and remove the reference to jolokia.opts in the [Dockerfile template](https://github.com/fabric8io-images/s2i/blob/master/java/templates/Dockerfile#L46-L49). \r\n* Or update [jolokia-opts](https://github.com/fabric8io/agent-bond/blob/master/fish-pepper/jolokia/fp-files/jolokia-opts) in agent-bond to be more universal, allowing to write out the property to a file as done here.\r\n\r\nI'd prefer the latter option has it then could be reused by other images as well. Also, I would simply prepare the argument string and split it on ',' or the other way round: Create a line-by-line string and split on new line (probably safer w.r.t to escaped commas e.g. in the cert's subject name).\r\n\r\nbtw, I'm not sure why it works currently, but I guess the template files are copied over the files coming from the external block later.","created_at":"2016-10-11T10:09:32Z","updated_at":"2016-10-11T10:17:40Z","html_url":"https://github.com/fabric8io-images/s2i/pull/35#discussion_r82762383","pull_request_url":"https://api.github.com/repos/fabric8io-images/s2i/pulls/35","_links":{"self":{"href":"https://api.github.com/repos/fabric8io-images/s2i/pulls/comments/82762383"},"html":{"href":"https://github.com/fabric8io-images/s2i/pull/35#discussion_r82762383"},"pull_request":{"href":"https://api.github.com/repos/fabric8io-images/s2i/pulls/35"}}},"pull_request":{"url":"https://api.github.com/repos/fabric8io-images/s2i/pulls/35","id":88706133,"html_url":"https://github.com/fabric8io-images/s2i/pull/35","diff_url":"https://github.com/fabric8io-images/s2i/pull/35.diff","patch_url":"https://github.com/fabric8io-images/s2i/pull/35.patch","issue_url":"https://api.github.com/repos/fabric8io-images/s2i/issues/35","number":35,"state":"open","locked":false,"title":"Write all jolokia options to the /deployments/jolokia.properties file…","user":{"login":"chirino","id":103255,"avatar_url":"https://avatars.githubusercontent.com/u/103255?v=3","gravatar_id":"","url":"https://api.github.com/users/chirino","html_url":"https://github.com/chirino","followers_url":"https://api.github.com/users/chirino/followers","following_url":"https://api.github.com/users/chirino/following{/other_user}","gists_url":"https://api.github.com/users/chirino/gists{/gist_id}","starred_url":"https://api.github.com/users/chirino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chirino/subscriptions","organizations_url":"https://api.github.com/users/chirino/orgs","repos_url":"https://api.github.com/users/chirino/repos","events_url":"https://api.github.com/users/chirino/events{/privacy}","received_events_url":"https://api.github.com/users/chirino/received_events","type":"User","site_admin":false},"body":"… instead of adding them to the Java command line since those could include sensitive info like basic auth passwords. related to OSFUSE-109","created_at":"2016-10-10T18:04:48Z","updated_at":"2016-10-11T10:17:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"baae6a9752d5c63e6409999f0a1efe8789c4c4c7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/fabric8io-images/s2i/pulls/35/commits","review_comments_url":"https://api.github.com/repos/fabric8io-images/s2i/pulls/35/comments","review_comment_url":"https://api.github.com/repos/fabric8io-images/s2i/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fabric8io-images/s2i/issues/35/comments","statuses_url":"https://api.github.com/repos/fabric8io-images/s2i/statuses/74380f0c67eacae4a1800bbd9a91a80399f71a5f","head":{"label":"chirino:OSFUSE-109","ref":"OSFUSE-109","sha":"74380f0c67eacae4a1800bbd9a91a80399f71a5f","user":{"login":"chirino","id":103255,"avatar_url":"https://avatars.githubusercontent.com/u/103255?v=3","gravatar_id":"","url":"https://api.github.com/users/chirino","html_url":"https://github.com/chirino","followers_url":"https://api.github.com/users/chirino/followers","following_url":"https://api.github.com/users/chirino/following{/other_user}","gists_url":"https://api.github.com/users/chirino/gists{/gist_id}","starred_url":"https://api.github.com/users/chirino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chirino/subscriptions","organizations_url":"https://api.github.com/users/chirino/orgs","repos_url":"https://api.github.com/users/chirino/repos","events_url":"https://api.github.com/users/chirino/events{/privacy}","received_events_url":"https://api.github.com/users/chirino/received_events","type":"User","site_admin":false},"repo":{"id":63247529,"name":"s2i","full_name":"chirino/s2i","owner":{"login":"chirino","id":103255,"avatar_url":"https://avatars.githubusercontent.com/u/103255?v=3","gravatar_id":"","url":"https://api.github.com/users/chirino","html_url":"https://github.com/chirino","followers_url":"https://api.github.com/users/chirino/followers","following_url":"https://api.github.com/users/chirino/following{/other_user}","gists_url":"https://api.github.com/users/chirino/gists{/gist_id}","starred_url":"https://api.github.com/users/chirino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chirino/subscriptions","organizations_url":"https://api.github.com/users/chirino/orgs","repos_url":"https://api.github.com/users/chirino/repos","events_url":"https://api.github.com/users/chirino/events{/privacy}","received_events_url":"https://api.github.com/users/chirino/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chirino/s2i","description":"OpenShift S2I images for Java and Karaf applications","fork":true,"url":"https://api.github.com/repos/chirino/s2i","forks_url":"https://api.github.com/repos/chirino/s2i/forks","keys_url":"https://api.github.com/repos/chirino/s2i/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chirino/s2i/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chirino/s2i/teams","hooks_url":"https://api.github.com/repos/chirino/s2i/hooks","issue_events_url":"https://api.github.com/repos/chirino/s2i/issues/events{/number}","events_url":"https://api.github.com/repos/chirino/s2i/events","assignees_url":"https://api.github.com/repos/chirino/s2i/assignees{/user}","branches_url":"https://api.github.com/repos/chirino/s2i/branches{/branch}","tags_url":"https://api.github.com/repos/chirino/s2i/tags","blobs_url":"https://api.github.com/repos/chirino/s2i/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chirino/s2i/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chirino/s2i/git/refs{/sha}","trees_url":"https://api.github.com/repos/chirino/s2i/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chirino/s2i/statuses/{sha}","languages_url":"https://api.github.com/repos/chirino/s2i/languages","stargazers_url":"https://api.github.com/repos/chirino/s2i/stargazers","contributors_url":"https://api.github.com/repos/chirino/s2i/contributors","subscribers_url":"https://api.github.com/repos/chirino/s2i/subscribers","subscription_url":"https://api.github.com/repos/chirino/s2i/subscription","commits_url":"https://api.github.com/repos/chirino/s2i/commits{/sha}","git_commits_url":"https://api.github.com/repos/chirino/s2i/git/commits{/sha}","comments_url":"https://api.github.com/repos/chirino/s2i/comments{/number}","issue_comment_url":"https://api.github.com/repos/chirino/s2i/issues/comments{/number}","contents_url":"https://api.github.com/repos/chirino/s2i/contents/{+path}","compare_url":"https://api.github.com/repos/chirino/s2i/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chirino/s2i/merges","archive_url":"https://api.github.com/repos/chirino/s2i/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chirino/s2i/downloads","issues_url":"https://api.github.com/repos/chirino/s2i/issues{/number}","pulls_url":"https://api.github.com/repos/chirino/s2i/pulls{/number}","milestones_url":"https://api.github.com/repos/chirino/s2i/milestones{/number}","notifications_url":"https://api.github.com/repos/chirino/s2i/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chirino/s2i/labels{/name}","releases_url":"https://api.github.com/repos/chirino/s2i/releases{/id}","deployments_url":"https://api.github.com/repos/chirino/s2i/deployments","created_at":"2016-07-13T13:21:19Z","updated_at":"2016-07-13T13:21:20Z","pushed_at":"2016-10-10T18:04:32Z","git_url":"git://github.com/chirino/s2i.git","ssh_url":"git@github.com:chirino/s2i.git","clone_url":"https://github.com/chirino/s2i.git","svn_url":"https://github.com/chirino/s2i","homepage":null,"size":8008,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fabric8io-images:master","ref":"master","sha":"570d4e45d441a08367abe7482b3d9efe008c8bea","user":{"login":"fabric8io-images","id":15142647,"avatar_url":"https://avatars.githubusercontent.com/u/15142647?v=3","gravatar_id":"","url":"https://api.github.com/users/fabric8io-images","html_url":"https://github.com/fabric8io-images","followers_url":"https://api.github.com/users/fabric8io-images/followers","following_url":"https://api.github.com/users/fabric8io-images/following{/other_user}","gists_url":"https://api.github.com/users/fabric8io-images/gists{/gist_id}","starred_url":"https://api.github.com/users/fabric8io-images/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabric8io-images/subscriptions","organizations_url":"https://api.github.com/users/fabric8io-images/orgs","repos_url":"https://api.github.com/users/fabric8io-images/repos","events_url":"https://api.github.com/users/fabric8io-images/events{/privacy}","received_events_url":"https://api.github.com/users/fabric8io-images/received_events","type":"Organization","site_admin":false},"repo":{"id":44367597,"name":"s2i","full_name":"fabric8io-images/s2i","owner":{"login":"fabric8io-images","id":15142647,"avatar_url":"https://avatars.githubusercontent.com/u/15142647?v=3","gravatar_id":"","url":"https://api.github.com/users/fabric8io-images","html_url":"https://github.com/fabric8io-images","followers_url":"https://api.github.com/users/fabric8io-images/followers","following_url":"https://api.github.com/users/fabric8io-images/following{/other_user}","gists_url":"https://api.github.com/users/fabric8io-images/gists{/gist_id}","starred_url":"https://api.github.com/users/fabric8io-images/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabric8io-images/subscriptions","organizations_url":"https://api.github.com/users/fabric8io-images/orgs","repos_url":"https://api.github.com/users/fabric8io-images/repos","events_url":"https://api.github.com/users/fabric8io-images/events{/privacy}","received_events_url":"https://api.github.com/users/fabric8io-images/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fabric8io-images/s2i","description":"OpenShift S2I images for Java and Karaf applications","fork":false,"url":"https://api.github.com/repos/fabric8io-images/s2i","forks_url":"https://api.github.com/repos/fabric8io-images/s2i/forks","keys_url":"https://api.github.com/repos/fabric8io-images/s2i/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fabric8io-images/s2i/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fabric8io-images/s2i/teams","hooks_url":"https://api.github.com/repos/fabric8io-images/s2i/hooks","issue_events_url":"https://api.github.com/repos/fabric8io-images/s2i/issues/events{/number}","events_url":"https://api.github.com/repos/fabric8io-images/s2i/events","assignees_url":"https://api.github.com/repos/fabric8io-images/s2i/assignees{/user}","branches_url":"https://api.github.com/repos/fabric8io-images/s2i/branches{/branch}","tags_url":"https://api.github.com/repos/fabric8io-images/s2i/tags","blobs_url":"https://api.github.com/repos/fabric8io-images/s2i/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fabric8io-images/s2i/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fabric8io-images/s2i/git/refs{/sha}","trees_url":"https://api.github.com/repos/fabric8io-images/s2i/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fabric8io-images/s2i/statuses/{sha}","languages_url":"https://api.github.com/repos/fabric8io-images/s2i/languages","stargazers_url":"https://api.github.com/repos/fabric8io-images/s2i/stargazers","contributors_url":"https://api.github.com/repos/fabric8io-images/s2i/contributors","subscribers_url":"https://api.github.com/repos/fabric8io-images/s2i/subscribers","subscription_url":"https://api.github.com/repos/fabric8io-images/s2i/subscription","commits_url":"https://api.github.com/repos/fabric8io-images/s2i/commits{/sha}","git_commits_url":"https://api.github.com/repos/fabric8io-images/s2i/git/commits{/sha}","comments_url":"https://api.github.com/repos/fabric8io-images/s2i/comments{/number}","issue_comment_url":"https://api.github.com/repos/fabric8io-images/s2i/issues/comments{/number}","contents_url":"https://api.github.com/repos/fabric8io-images/s2i/contents/{+path}","compare_url":"https://api.github.com/repos/fabric8io-images/s2i/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fabric8io-images/s2i/merges","archive_url":"https://api.github.com/repos/fabric8io-images/s2i/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fabric8io-images/s2i/downloads","issues_url":"https://api.github.com/repos/fabric8io-images/s2i/issues{/number}","pulls_url":"https://api.github.com/repos/fabric8io-images/s2i/pulls{/number}","milestones_url":"https://api.github.com/repos/fabric8io-images/s2i/milestones{/number}","notifications_url":"https://api.github.com/repos/fabric8io-images/s2i/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fabric8io-images/s2i/labels{/name}","releases_url":"https://api.github.com/repos/fabric8io-images/s2i/releases{/id}","deployments_url":"https://api.github.com/repos/fabric8io-images/s2i/deployments","created_at":"2015-10-16T06:51:54Z","updated_at":"2016-07-22T06:30:17Z","pushed_at":"2016-10-10T18:10:34Z","git_url":"git://github.com/fabric8io-images/s2i.git","ssh_url":"git@github.com:fabric8io-images/s2i.git","clone_url":"https://github.com/fabric8io-images/s2i.git","svn_url":"https://github.com/fabric8io-images/s2i","homepage":null,"size":8014,"stargazers_count":2,"watchers_count":2,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"open_issues_count":4,"forks":21,"open_issues":4,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fabric8io-images/s2i/pulls/35"},"html":{"href":"https://github.com/fabric8io-images/s2i/pull/35"},"issue":{"href":"https://api.github.com/repos/fabric8io-images/s2i/issues/35"},"comments":{"href":"https://api.github.com/repos/fabric8io-images/s2i/issues/35/comments"},"review_comments":{"href":"https://api.github.com/repos/fabric8io-images/s2i/pulls/35/comments"},"review_comment":{"href":"https://api.github.com/repos/fabric8io-images/s2i/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fabric8io-images/s2i/pulls/35/commits"},"statuses":{"href":"https://api.github.com/repos/fabric8io-images/s2i/statuses/74380f0c67eacae4a1800bbd9a91a80399f71a5f"}}}}
{"actor":{"display_login":"rhuss"}}