{"action":"created","comment":{"url":"https://api.github.com/repos/apache/kafka/pulls/comments/68100285","id":68100285,"diff_hunk":"@@ -18,55 +18,74 @@\n package org.apache.kafka.connect.sink;\n \n import org.apache.kafka.common.annotation.InterfaceStability;\n+import org.apache.kafka.common.record.TimestampType;\n import org.apache.kafka.connect.connector.ConnectRecord;\n import org.apache.kafka.connect.data.Schema;\n \n /**\n  * SinkRecord is a {@link ConnectRecord} that has been read from Kafka and includes the kafkaOffset of\n  * the record in the Kafka topic-partition in addition to the standard fields. This information\n  * should be used by the SinkTask to coordinate kafkaOffset commits.\n+ *\n+ * It also includes the {@link TimestampType}, which may be {@link TimestampType#NO_TIMESTAMP_TYPE}, and the relevant\n+ * timestamp.\n  */\n @InterfaceStability.Unstable\n public class SinkRecord extends ConnectRecord {\n     private final long kafkaOffset;\n+    private final TimestampType timestampType;\n \n-    public SinkRecord(String topic, int partition, Schema keySchema, Object key, Schema valueSchema, Object value, long kafkaOffset) {\n-        super(topic, partition, keySchema, key, valueSchema, value);\n+    public SinkRecord(String topic, int partition,\n+                      Schema keySchema, Object key,\n+                      Schema valueSchema, Object value,\n+                      long kafkaOffset, long timestamp, TimestampType timestampType) {\n+        super(topic, partition, keySchema, key, valueSchema, value, timestamp);\n         this.kafkaOffset = kafkaOffset;\n+        this.timestampType = timestampType;\n     }\n \n     public long kafkaOffset() {\n         return kafkaOffset;\n     }\n \n+    public TimestampType timestampType() {\n+        return timestampType;\n+    }\n+\n     @Override\n     public boolean equals(Object o) {\n-        if (this == o)\n+        if (this == o) {","path":"connect/api/src/main/java/org/apache/kafka/connect/sink/SinkRecord.java","position":43,"original_position":43,"commit_id":"0f0baba3bb87c2fc3c0cdfd1cee84a87414a3a11","original_commit_id":"0f0baba3bb87c2fc3c0cdfd1cee84a87414a3a11","user":{"login":"shikhar","id":74267,"avatar_url":"https://avatars.githubusercontent.com/u/74267?v=3","gravatar_id":"","url":"https://api.github.com/users/shikhar","html_url":"https://github.com/shikhar","followers_url":"https://api.github.com/users/shikhar/followers","following_url":"https://api.github.com/users/shikhar/following{/other_user}","gists_url":"https://api.github.com/users/shikhar/gists{/gist_id}","starred_url":"https://api.github.com/users/shikhar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shikhar/subscriptions","organizations_url":"https://api.github.com/users/shikhar/orgs","repos_url":"https://api.github.com/users/shikhar/repos","events_url":"https://api.github.com/users/shikhar/events{/privacy}","received_events_url":"https://api.github.com/users/shikhar/received_events","type":"User","site_admin":false},"body":"Ah this is probably because I regenerated equals/hashCode/toString. Will fix.","created_at":"2016-06-22T17:45:14Z","updated_at":"2016-06-22T17:45:14Z","html_url":"https://github.com/apache/kafka/pull/1537#discussion_r68100285","pull_request_url":"https://api.github.com/repos/apache/kafka/pulls/1537","_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments/68100285"},"html":{"href":"https://github.com/apache/kafka/pull/1537#discussion_r68100285"},"pull_request":{"href":"https://api.github.com/repos/apache/kafka/pulls/1537"}}},"pull_request":{"url":"https://api.github.com/repos/apache/kafka/pulls/1537","id":74708631,"html_url":"https://github.com/apache/kafka/pull/1537","diff_url":"https://github.com/apache/kafka/pull/1537.diff","patch_url":"https://github.com/apache/kafka/pull/1537.patch","issue_url":"https://api.github.com/repos/apache/kafka/issues/1537","number":1537,"state":"open","locked":false,"title":"KAFKA-3846: include timestamp in Connect record types","user":{"login":"shikhar","id":74267,"avatar_url":"https://avatars.githubusercontent.com/u/74267?v=3","gravatar_id":"","url":"https://api.github.com/users/shikhar","html_url":"https://github.com/shikhar","followers_url":"https://api.github.com/users/shikhar/followers","following_url":"https://api.github.com/users/shikhar/following{/other_user}","gists_url":"https://api.github.com/users/shikhar/gists{/gist_id}","starred_url":"https://api.github.com/users/shikhar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shikhar/subscriptions","organizations_url":"https://api.github.com/users/shikhar/orgs","repos_url":"https://api.github.com/users/shikhar/repos","events_url":"https://api.github.com/users/shikhar/events{/privacy}","received_events_url":"https://api.github.com/users/shikhar/received_events","type":"User","site_admin":false},"body":"KIP to come","created_at":"2016-06-22T00:44:44Z","updated_at":"2016-06-22T17:45:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"af9f6a09fa8ecf6f32632c836657dfc3c38f6b3c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/kafka/pulls/1537/commits","review_comments_url":"https://api.github.com/repos/apache/kafka/pulls/1537/comments","review_comment_url":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/kafka/issues/1537/comments","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/0f0baba3bb87c2fc3c0cdfd1cee84a87414a3a11","head":{"label":"shikhar:kafka-3846","ref":"kafka-3846","sha":"0f0baba3bb87c2fc3c0cdfd1cee84a87414a3a11","user":{"login":"shikhar","id":74267,"avatar_url":"https://avatars.githubusercontent.com/u/74267?v=3","gravatar_id":"","url":"https://api.github.com/users/shikhar","html_url":"https://github.com/shikhar","followers_url":"https://api.github.com/users/shikhar/followers","following_url":"https://api.github.com/users/shikhar/following{/other_user}","gists_url":"https://api.github.com/users/shikhar/gists{/gist_id}","starred_url":"https://api.github.com/users/shikhar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shikhar/subscriptions","organizations_url":"https://api.github.com/users/shikhar/orgs","repos_url":"https://api.github.com/users/shikhar/repos","events_url":"https://api.github.com/users/shikhar/events{/privacy}","received_events_url":"https://api.github.com/users/shikhar/received_events","type":"User","site_admin":false},"repo":{"id":59165469,"name":"kafka","full_name":"shikhar/kafka","owner":{"login":"shikhar","id":74267,"avatar_url":"https://avatars.githubusercontent.com/u/74267?v=3","gravatar_id":"","url":"https://api.github.com/users/shikhar","html_url":"https://github.com/shikhar","followers_url":"https://api.github.com/users/shikhar/followers","following_url":"https://api.github.com/users/shikhar/following{/other_user}","gists_url":"https://api.github.com/users/shikhar/gists{/gist_id}","starred_url":"https://api.github.com/users/shikhar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shikhar/subscriptions","organizations_url":"https://api.github.com/users/shikhar/orgs","repos_url":"https://api.github.com/users/shikhar/repos","events_url":"https://api.github.com/users/shikhar/events{/privacy}","received_events_url":"https://api.github.com/users/shikhar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shikhar/kafka","description":"Mirror of Apache Kafka","fork":true,"url":"https://api.github.com/repos/shikhar/kafka","forks_url":"https://api.github.com/repos/shikhar/kafka/forks","keys_url":"https://api.github.com/repos/shikhar/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shikhar/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shikhar/kafka/teams","hooks_url":"https://api.github.com/repos/shikhar/kafka/hooks","issue_events_url":"https://api.github.com/repos/shikhar/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/shikhar/kafka/events","assignees_url":"https://api.github.com/repos/shikhar/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/shikhar/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/shikhar/kafka/tags","blobs_url":"https://api.github.com/repos/shikhar/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shikhar/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shikhar/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/shikhar/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shikhar/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/shikhar/kafka/languages","stargazers_url":"https://api.github.com/repos/shikhar/kafka/stargazers","contributors_url":"https://api.github.com/repos/shikhar/kafka/contributors","subscribers_url":"https://api.github.com/repos/shikhar/kafka/subscribers","subscription_url":"https://api.github.com/repos/shikhar/kafka/subscription","commits_url":"https://api.github.com/repos/shikhar/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/shikhar/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/shikhar/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/shikhar/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/shikhar/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/shikhar/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shikhar/kafka/merges","archive_url":"https://api.github.com/repos/shikhar/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shikhar/kafka/downloads","issues_url":"https://api.github.com/repos/shikhar/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/shikhar/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/shikhar/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/shikhar/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shikhar/kafka/labels{/name}","releases_url":"https://api.github.com/repos/shikhar/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/shikhar/kafka/deployments","created_at":"2016-05-19T01:58:21Z","updated_at":"2016-05-19T01:58:25Z","pushed_at":"2016-06-22T00:46:34Z","git_url":"git://github.com/shikhar/kafka.git","ssh_url":"git@github.com:shikhar/kafka.git","clone_url":"https://github.com/shikhar/kafka.git","svn_url":"https://github.com/shikhar/kafka","homepage":null,"size":32392,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"trunk"}},"base":{"label":"apache:trunk","ref":"trunk","sha":"8b7dce87a744837e5b3bba41b3e3c4c408c78b7f","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":2211243,"name":"kafka","full_name":"apache/kafka","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/kafka","description":"Mirror of Apache Kafka","fork":false,"url":"https://api.github.com/repos/apache/kafka","forks_url":"https://api.github.com/repos/apache/kafka/forks","keys_url":"https://api.github.com/repos/apache/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/kafka/teams","hooks_url":"https://api.github.com/repos/apache/kafka/hooks","issue_events_url":"https://api.github.com/repos/apache/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/apache/kafka/events","assignees_url":"https://api.github.com/repos/apache/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/apache/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/apache/kafka/tags","blobs_url":"https://api.github.com/repos/apache/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/kafka/languages","stargazers_url":"https://api.github.com/repos/apache/kafka/stargazers","contributors_url":"https://api.github.com/repos/apache/kafka/contributors","subscribers_url":"https://api.github.com/repos/apache/kafka/subscribers","subscription_url":"https://api.github.com/repos/apache/kafka/subscription","commits_url":"https://api.github.com/repos/apache/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/apache/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/kafka/merges","archive_url":"https://api.github.com/repos/apache/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/kafka/downloads","issues_url":"https://api.github.com/repos/apache/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/apache/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/kafka/labels{/name}","releases_url":"https://api.github.com/repos/apache/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/apache/kafka/deployments","created_at":"2011-08-15T18:06:16Z","updated_at":"2016-06-22T10:20:08Z","pushed_at":"2016-06-22T17:41:13Z","git_url":"git://github.com/apache/kafka.git","ssh_url":"git@github.com:apache/kafka.git","clone_url":"https://github.com/apache/kafka.git","svn_url":"https://github.com/apache/kafka","homepage":null,"size":44200,"stargazers_count":3296,"watchers_count":3296,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2036,"mirror_url":"git://git.apache.org/kafka.git","open_issues_count":196,"forks":2036,"open_issues":196,"watchers":3296,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/1537"},"html":{"href":"https://github.com/apache/kafka/pull/1537"},"issue":{"href":"https://api.github.com/repos/apache/kafka/issues/1537"},"comments":{"href":"https://api.github.com/repos/apache/kafka/issues/1537/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/kafka/pulls/1537/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/kafka/pulls/1537/commits"},"statuses":{"href":"https://api.github.com/repos/apache/kafka/statuses/0f0baba3bb87c2fc3c0cdfd1cee84a87414a3a11"}}}}
{"actor":{"display_login":"shikhar"}}