{"action":"created","issue":{"url":"https://api.github.com/repos/tud-zih-energy/libadapt/issues/1","repository_url":"https://api.github.com/repos/tud-zih-energy/libadapt","labels_url":"https://api.github.com/repos/tud-zih-energy/libadapt/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/tud-zih-energy/libadapt/issues/1/comments","events_url":"https://api.github.com/repos/tud-zih-energy/libadapt/issues/1/events","html_url":"https://github.com/tud-zih-energy/libadapt/pull/1","id":139356307,"number":1,"title":"New commets and code clean up","user":{"login":"sven5s","id":17566357,"avatar_url":"https://avatars.githubusercontent.com/u/17566357?v=3","gravatar_id":"","url":"https://api.github.com/users/sven5s","html_url":"https://github.com/sven5s","followers_url":"https://api.github.com/users/sven5s/followers","following_url":"https://api.github.com/users/sven5s/following{/other_user}","gists_url":"https://api.github.com/users/sven5s/gists{/gist_id}","starred_url":"https://api.github.com/users/sven5s/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sven5s/subscriptions","organizations_url":"https://api.github.com/users/sven5s/orgs","repos_url":"https://api.github.com/users/sven5s/repos","events_url":"https://api.github.com/users/sven5s/events{/privacy}","received_events_url":"https://api.github.com/users/sven5s/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2016-03-08T18:32:08Z","updated_at":"2016-04-04T10:35:14Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/tud-zih-energy/libadapt/pulls/1","html_url":"https://github.com/tud-zih-energy/libadapt/pull/1","diff_url":"https://github.com/tud-zih-energy/libadapt/pull/1.diff","patch_url":"https://github.com/tud-zih-energy/libadapt/pull/1.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/tud-zih-energy/libadapt/issues/comments/205234823","html_url":"https://github.com/tud-zih-energy/libadapt/pull/1#issuecomment-205234823","issue_url":"https://api.github.com/repos/tud-zih-energy/libadapt/issues/1","id":205234823,"user":{"login":"devreal","id":10974502,"avatar_url":"https://avatars.githubusercontent.com/u/10974502?v=3","gravatar_id":"","url":"https://api.github.com/users/devreal","html_url":"https://github.com/devreal","followers_url":"https://api.github.com/users/devreal/followers","following_url":"https://api.github.com/users/devreal/following{/other_user}","gists_url":"https://api.github.com/users/devreal/gists{/gist_id}","starred_url":"https://api.github.com/users/devreal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devreal/subscriptions","organizations_url":"https://api.github.com/users/devreal/orgs","repos_url":"https://api.github.com/users/devreal/repos","events_url":"https://api.github.com/users/devreal/events{/privacy}","received_events_url":"https://api.github.com/users/devreal/received_events","type":"User","site_admin":false},"created_at":"2016-04-04T10:35:14Z","updated_at":"2016-04-04T10:35:14Z","body":"@sven5s: I wasn't aware of the different types. You are right, it's hard to do in plain C then. \r\n\r\nStill, I would strongly suggest to change the macros such that they do not implicitly reference variables that are not in the scope of the macro. This might have unintended side-effects and is bad for re-usability, i.e., I cannot use this macro on a variable that is not named \"current\" and it might actually free a global variable \"current\" that I accidentally introduced... Passing all outside variables to the macro as an argument makes it more intuitive and safe to use.  "}}