{"action":"created","comment":{"url":"https://api.github.com/repos/ccnmtl/mediathread/pulls/comments/94137378","pull_request_review_id":14668099,"id":94137378,"diff_hunk":"@@ -256,9 +256,9 @@ CollectionWidget.prototype.mapEvents = function() {\n                 success: function(json, textStatus, xhr) {\n                     self.signalInsert(assetId, json.annotation.id);\n                     self.$modal.modal('hide');\n-                    return;\n                 }\n             });\n+            return;","path":"media/js/app/assetmgr/collectionwidget.js","position":7,"original_position":7,"commit_id":"79e0cd2c40424ee91334542616a08e7dd8f2edcf","original_commit_id":"79e0cd2c40424ee91334542616a08e7dd8f2edcf","user":{"login":"sdreher","id":141369,"avatar_url":"https://avatars.githubusercontent.com/u/141369?v=3","gravatar_id":"","url":"https://api.github.com/users/sdreher","html_url":"https://github.com/sdreher","followers_url":"https://api.github.com/users/sdreher/followers","following_url":"https://api.github.com/users/sdreher/following{/other_user}","gists_url":"https://api.github.com/users/sdreher/gists{/gist_id}","starred_url":"https://api.github.com/users/sdreher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdreher/subscriptions","organizations_url":"https://api.github.com/users/sdreher/orgs","repos_url":"https://api.github.com/users/sdreher/repos","events_url":"https://api.github.com/users/sdreher/events{/privacy}","received_events_url":"https://api.github.com/users/sdreher/received_events","type":"User","site_admin":false},"body":"The return at Ln. 261 is needed to prevent the code from falling into the next bit of logic and creating a global annotation when one already exists. Noting though - the return at Ln 276 is unneeded and can be removed. I'll do a PR to fix that. Thanks for the close review.","created_at":"2016-12-29T13:51:00Z","updated_at":"2016-12-29T13:51:01Z","html_url":"https://github.com/ccnmtl/mediathread/pull/1101#discussion_r94137378","pull_request_url":"https://api.github.com/repos/ccnmtl/mediathread/pulls/1101","_links":{"self":{"href":"https://api.github.com/repos/ccnmtl/mediathread/pulls/comments/94137378"},"html":{"href":"https://github.com/ccnmtl/mediathread/pull/1101#discussion_r94137378"},"pull_request":{"href":"https://api.github.com/repos/ccnmtl/mediathread/pulls/1101"}}},"pull_request":{"url":"https://api.github.com/repos/ccnmtl/mediathread/pulls/1101","id":99594453,"html_url":"https://github.com/ccnmtl/mediathread/pull/1101","diff_url":"https://github.com/ccnmtl/mediathread/pull/1101.diff","patch_url":"https://github.com/ccnmtl/mediathread/pull/1101.patch","issue_url":"https://api.github.com/repos/ccnmtl/mediathread/issues/1101","number":1101,"state":"closed","locked":false,"title":"CollectionWidget: simplify save signal","user":{"login":"sdreher","id":141369,"avatar_url":"https://avatars.githubusercontent.com/u/141369?v=3","gravatar_id":"","url":"https://api.github.com/users/sdreher","html_url":"https://github.com/sdreher","followers_url":"https://api.github.com/users/sdreher/followers","following_url":"https://api.github.com/users/sdreher/following{/other_user}","gists_url":"https://api.github.com/users/sdreher/gists{/gist_id}","starred_url":"https://api.github.com/users/sdreher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdreher/subscriptions","organizations_url":"https://api.github.com/users/sdreher/orgs","repos_url":"https://api.github.com/users/sdreher/repos","events_url":"https://api.github.com/users/sdreher/events{/privacy}","received_events_url":"https://api.github.com/users/sdreher/received_events","type":"User","site_admin":false},"body":"Just send over assetId & annotationId on save. \r\n\r\nThis PR is related to this one: https://github.com/ccnmtl/juxtapose/pull/195","created_at":"2016-12-28T21:28:39Z","updated_at":"2016-12-29T13:51:01Z","closed_at":"2016-12-29T04:35:43Z","merged_at":"2016-12-29T04:35:43Z","merge_commit_sha":"16c16a7ed592cf811549ff3941b6e976bd5b70b4","assignee":{"login":"nikolas","id":59292,"avatar_url":"https://avatars.githubusercontent.com/u/59292?v=3","gravatar_id":"","url":"https://api.github.com/users/nikolas","html_url":"https://github.com/nikolas","followers_url":"https://api.github.com/users/nikolas/followers","following_url":"https://api.github.com/users/nikolas/following{/other_user}","gists_url":"https://api.github.com/users/nikolas/gists{/gist_id}","starred_url":"https://api.github.com/users/nikolas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikolas/subscriptions","organizations_url":"https://api.github.com/users/nikolas/orgs","repos_url":"https://api.github.com/users/nikolas/repos","events_url":"https://api.github.com/users/nikolas/events{/privacy}","received_events_url":"https://api.github.com/users/nikolas/received_events","type":"User","site_admin":false},"assignees":[{"login":"nikolas","id":59292,"avatar_url":"https://avatars.githubusercontent.com/u/59292?v=3","gravatar_id":"","url":"https://api.github.com/users/nikolas","html_url":"https://github.com/nikolas","followers_url":"https://api.github.com/users/nikolas/followers","following_url":"https://api.github.com/users/nikolas/following{/other_user}","gists_url":"https://api.github.com/users/nikolas/gists{/gist_id}","starred_url":"https://api.github.com/users/nikolas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikolas/subscriptions","organizations_url":"https://api.github.com/users/nikolas/orgs","repos_url":"https://api.github.com/users/nikolas/repos","events_url":"https://api.github.com/users/nikolas/events{/privacy}","received_events_url":"https://api.github.com/users/nikolas/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ccnmtl/mediathread/pulls/1101/commits","review_comments_url":"https://api.github.com/repos/ccnmtl/mediathread/pulls/1101/comments","review_comment_url":"https://api.github.com/repos/ccnmtl/mediathread/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ccnmtl/mediathread/issues/1101/comments","statuses_url":"https://api.github.com/repos/ccnmtl/mediathread/statuses/79e0cd2c40424ee91334542616a08e7dd8f2edcf","head":{"label":"ccnmtl:spine-select","ref":"spine-select","sha":"79e0cd2c40424ee91334542616a08e7dd8f2edcf","user":{"login":"ccnmtl","id":52456,"avatar_url":"https://avatars.githubusercontent.com/u/52456?v=3","gravatar_id":"","url":"https://api.github.com/users/ccnmtl","html_url":"https://github.com/ccnmtl","followers_url":"https://api.github.com/users/ccnmtl/followers","following_url":"https://api.github.com/users/ccnmtl/following{/other_user}","gists_url":"https://api.github.com/users/ccnmtl/gists{/gist_id}","starred_url":"https://api.github.com/users/ccnmtl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ccnmtl/subscriptions","organizations_url":"https://api.github.com/users/ccnmtl/orgs","repos_url":"https://api.github.com/users/ccnmtl/repos","events_url":"https://api.github.com/users/ccnmtl/events{/privacy}","received_events_url":"https://api.github.com/users/ccnmtl/received_events","type":"Organization","site_admin":false},"repo":{"id":461209,"name":"mediathread","full_name":"ccnmtl/mediathread","owner":{"login":"ccnmtl","id":52456,"avatar_url":"https://avatars.githubusercontent.com/u/52456?v=3","gravatar_id":"","url":"https://api.github.com/users/ccnmtl","html_url":"https://github.com/ccnmtl","followers_url":"https://api.github.com/users/ccnmtl/followers","following_url":"https://api.github.com/users/ccnmtl/following{/other_user}","gists_url":"https://api.github.com/users/ccnmtl/gists{/gist_id}","starred_url":"https://api.github.com/users/ccnmtl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ccnmtl/subscriptions","organizations_url":"https://api.github.com/users/ccnmtl/orgs","repos_url":"https://api.github.com/users/ccnmtl/repos","events_url":"https://api.github.com/users/ccnmtl/events{/privacy}","received_events_url":"https://api.github.com/users/ccnmtl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ccnmtl/mediathread","description":"Django site for multimedia annotations facilitating collaboration on video and image analysis. Developed at the Columbia Center for New Media Teaching and Learning","fork":false,"url":"https://api.github.com/repos/ccnmtl/mediathread","forks_url":"https://api.github.com/repos/ccnmtl/mediathread/forks","keys_url":"https://api.github.com/repos/ccnmtl/mediathread/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ccnmtl/mediathread/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ccnmtl/mediathread/teams","hooks_url":"https://api.github.com/repos/ccnmtl/mediathread/hooks","issue_events_url":"https://api.github.com/repos/ccnmtl/mediathread/issues/events{/number}","events_url":"https://api.github.com/repos/ccnmtl/mediathread/events","assignees_url":"https://api.github.com/repos/ccnmtl/mediathread/assignees{/user}","branches_url":"https://api.github.com/repos/ccnmtl/mediathread/branches{/branch}","tags_url":"https://api.github.com/repos/ccnmtl/mediathread/tags","blobs_url":"https://api.github.com/repos/ccnmtl/mediathread/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ccnmtl/mediathread/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ccnmtl/mediathread/git/refs{/sha}","trees_url":"https://api.github.com/repos/ccnmtl/mediathread/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ccnmtl/mediathread/statuses/{sha}","languages_url":"https://api.github.com/repos/ccnmtl/mediathread/languages","stargazers_url":"https://api.github.com/repos/ccnmtl/mediathread/stargazers","contributors_url":"https://api.github.com/repos/ccnmtl/mediathread/contributors","subscribers_url":"https://api.github.com/repos/ccnmtl/mediathread/subscribers","subscription_url":"https://api.github.com/repos/ccnmtl/mediathread/subscription","commits_url":"https://api.github.com/repos/ccnmtl/mediathread/commits{/sha}","git_commits_url":"https://api.github.com/repos/ccnmtl/mediathread/git/commits{/sha}","comments_url":"https://api.github.com/repos/ccnmtl/mediathread/comments{/number}","issue_comment_url":"https://api.github.com/repos/ccnmtl/mediathread/issues/comments{/number}","contents_url":"https://api.github.com/repos/ccnmtl/mediathread/contents/{+path}","compare_url":"https://api.github.com/repos/ccnmtl/mediathread/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ccnmtl/mediathread/merges","archive_url":"https://api.github.com/repos/ccnmtl/mediathread/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ccnmtl/mediathread/downloads","issues_url":"https://api.github.com/repos/ccnmtl/mediathread/issues{/number}","pulls_url":"https://api.github.com/repos/ccnmtl/mediathread/pulls{/number}","milestones_url":"https://api.github.com/repos/ccnmtl/mediathread/milestones{/number}","notifications_url":"https://api.github.com/repos/ccnmtl/mediathread/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ccnmtl/mediathread/labels{/name}","releases_url":"https://api.github.com/repos/ccnmtl/mediathread/releases{/id}","deployments_url":"https://api.github.com/repos/ccnmtl/mediathread/deployments","created_at":"2010-01-06T20:45:48Z","updated_at":"2016-11-15T22:18:40Z","pushed_at":"2016-12-29T04:35:45Z","git_url":"git://github.com/ccnmtl/mediathread.git","ssh_url":"git@github.com:ccnmtl/mediathread.git","clone_url":"https://github.com/ccnmtl/mediathread.git","svn_url":"https://github.com/ccnmtl/mediathread","homepage":"http://mediathread.info/","size":291682,"stargazers_count":57,"watchers_count":57,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":28,"mirror_url":null,"open_issues_count":1,"forks":28,"open_issues":1,"watchers":57,"default_branch":"master"}},"base":{"label":"ccnmtl:master","ref":"master","sha":"5646dc6fa4486926c158e507ca7980838f979746","user":{"login":"ccnmtl","id":52456,"avatar_url":"https://avatars.githubusercontent.com/u/52456?v=3","gravatar_id":"","url":"https://api.github.com/users/ccnmtl","html_url":"https://github.com/ccnmtl","followers_url":"https://api.github.com/users/ccnmtl/followers","following_url":"https://api.github.com/users/ccnmtl/following{/other_user}","gists_url":"https://api.github.com/users/ccnmtl/gists{/gist_id}","starred_url":"https://api.github.com/users/ccnmtl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ccnmtl/subscriptions","organizations_url":"https://api.github.com/users/ccnmtl/orgs","repos_url":"https://api.github.com/users/ccnmtl/repos","events_url":"https://api.github.com/users/ccnmtl/events{/privacy}","received_events_url":"https://api.github.com/users/ccnmtl/received_events","type":"Organization","site_admin":false},"repo":{"id":461209,"name":"mediathread","full_name":"ccnmtl/mediathread","owner":{"login":"ccnmtl","id":52456,"avatar_url":"https://avatars.githubusercontent.com/u/52456?v=3","gravatar_id":"","url":"https://api.github.com/users/ccnmtl","html_url":"https://github.com/ccnmtl","followers_url":"https://api.github.com/users/ccnmtl/followers","following_url":"https://api.github.com/users/ccnmtl/following{/other_user}","gists_url":"https://api.github.com/users/ccnmtl/gists{/gist_id}","starred_url":"https://api.github.com/users/ccnmtl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ccnmtl/subscriptions","organizations_url":"https://api.github.com/users/ccnmtl/orgs","repos_url":"https://api.github.com/users/ccnmtl/repos","events_url":"https://api.github.com/users/ccnmtl/events{/privacy}","received_events_url":"https://api.github.com/users/ccnmtl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ccnmtl/mediathread","description":"Django site for multimedia annotations facilitating collaboration on video and image analysis. Developed at the Columbia Center for New Media Teaching and Learning","fork":false,"url":"https://api.github.com/repos/ccnmtl/mediathread","forks_url":"https://api.github.com/repos/ccnmtl/mediathread/forks","keys_url":"https://api.github.com/repos/ccnmtl/mediathread/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ccnmtl/mediathread/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ccnmtl/mediathread/teams","hooks_url":"https://api.github.com/repos/ccnmtl/mediathread/hooks","issue_events_url":"https://api.github.com/repos/ccnmtl/mediathread/issues/events{/number}","events_url":"https://api.github.com/repos/ccnmtl/mediathread/events","assignees_url":"https://api.github.com/repos/ccnmtl/mediathread/assignees{/user}","branches_url":"https://api.github.com/repos/ccnmtl/mediathread/branches{/branch}","tags_url":"https://api.github.com/repos/ccnmtl/mediathread/tags","blobs_url":"https://api.github.com/repos/ccnmtl/mediathread/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ccnmtl/mediathread/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ccnmtl/mediathread/git/refs{/sha}","trees_url":"https://api.github.com/repos/ccnmtl/mediathread/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ccnmtl/mediathread/statuses/{sha}","languages_url":"https://api.github.com/repos/ccnmtl/mediathread/languages","stargazers_url":"https://api.github.com/repos/ccnmtl/mediathread/stargazers","contributors_url":"https://api.github.com/repos/ccnmtl/mediathread/contributors","subscribers_url":"https://api.github.com/repos/ccnmtl/mediathread/subscribers","subscription_url":"https://api.github.com/repos/ccnmtl/mediathread/subscription","commits_url":"https://api.github.com/repos/ccnmtl/mediathread/commits{/sha}","git_commits_url":"https://api.github.com/repos/ccnmtl/mediathread/git/commits{/sha}","comments_url":"https://api.github.com/repos/ccnmtl/mediathread/comments{/number}","issue_comment_url":"https://api.github.com/repos/ccnmtl/mediathread/issues/comments{/number}","contents_url":"https://api.github.com/repos/ccnmtl/mediathread/contents/{+path}","compare_url":"https://api.github.com/repos/ccnmtl/mediathread/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ccnmtl/mediathread/merges","archive_url":"https://api.github.com/repos/ccnmtl/mediathread/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ccnmtl/mediathread/downloads","issues_url":"https://api.github.com/repos/ccnmtl/mediathread/issues{/number}","pulls_url":"https://api.github.com/repos/ccnmtl/mediathread/pulls{/number}","milestones_url":"https://api.github.com/repos/ccnmtl/mediathread/milestones{/number}","notifications_url":"https://api.github.com/repos/ccnmtl/mediathread/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ccnmtl/mediathread/labels{/name}","releases_url":"https://api.github.com/repos/ccnmtl/mediathread/releases{/id}","deployments_url":"https://api.github.com/repos/ccnmtl/mediathread/deployments","created_at":"2010-01-06T20:45:48Z","updated_at":"2016-11-15T22:18:40Z","pushed_at":"2016-12-29T04:35:45Z","git_url":"git://github.com/ccnmtl/mediathread.git","ssh_url":"git@github.com:ccnmtl/mediathread.git","clone_url":"https://github.com/ccnmtl/mediathread.git","svn_url":"https://github.com/ccnmtl/mediathread","homepage":"http://mediathread.info/","size":291682,"stargazers_count":57,"watchers_count":57,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":28,"mirror_url":null,"open_issues_count":1,"forks":28,"open_issues":1,"watchers":57,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ccnmtl/mediathread/pulls/1101"},"html":{"href":"https://github.com/ccnmtl/mediathread/pull/1101"},"issue":{"href":"https://api.github.com/repos/ccnmtl/mediathread/issues/1101"},"comments":{"href":"https://api.github.com/repos/ccnmtl/mediathread/issues/1101/comments"},"review_comments":{"href":"https://api.github.com/repos/ccnmtl/mediathread/pulls/1101/comments"},"review_comment":{"href":"https://api.github.com/repos/ccnmtl/mediathread/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ccnmtl/mediathread/pulls/1101/commits"},"statuses":{"href":"https://api.github.com/repos/ccnmtl/mediathread/statuses/79e0cd2c40424ee91334542616a08e7dd8f2edcf"}}}}
{"actor":{"display_login":"sdreher"}}