{"action":"created","issue":{"url":"https://api.github.com/repos/CS111C-META-FALL-2016/LabD-Team1/issues/19","repository_url":"https://api.github.com/repos/CS111C-META-FALL-2016/LabD-Team1","labels_url":"https://api.github.com/repos/CS111C-META-FALL-2016/LabD-Team1/issues/19/labels{/name}","comments_url":"https://api.github.com/repos/CS111C-META-FALL-2016/LabD-Team1/issues/19/comments","events_url":"https://api.github.com/repos/CS111C-META-FALL-2016/LabD-Team1/issues/19/events","html_url":"https://github.com/CS111C-META-FALL-2016/LabD-Team1/issues/19","id":181434322,"number":19,"title":"Inheritance for getters and setters","user":{"login":"alternatebow","id":17015472,"avatar_url":"https://avatars.githubusercontent.com/u/17015472?v=3","gravatar_id":"","url":"https://api.github.com/users/alternatebow","html_url":"https://github.com/alternatebow","followers_url":"https://api.github.com/users/alternatebow/followers","following_url":"https://api.github.com/users/alternatebow/following{/other_user}","gists_url":"https://api.github.com/users/alternatebow/gists{/gist_id}","starred_url":"https://api.github.com/users/alternatebow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alternatebow/subscriptions","organizations_url":"https://api.github.com/users/alternatebow/orgs","repos_url":"https://api.github.com/users/alternatebow/repos","events_url":"https://api.github.com/users/alternatebow/events{/privacy}","received_events_url":"https://api.github.com/users/alternatebow/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-10-06T14:41:18Z","updated_at":"2016-10-06T22:50:18Z","closed_at":null,"body":"Um... so just out of curiosity, I noticed that the getters and setters for each 'shape' class are really similar. So that kind of made me wonder why instead of making GraphicShape an interface, we didn't make it a class and just inherit the getters/setters? This would have eliminated the need to implement them. "},"comment":{"url":"https://api.github.com/repos/CS111C-META-FALL-2016/LabD-Team1/issues/comments/252110260","html_url":"https://github.com/CS111C-META-FALL-2016/LabD-Team1/issues/19#issuecomment-252110260","issue_url":"https://api.github.com/repos/CS111C-META-FALL-2016/LabD-Team1/issues/19","id":252110260,"user":{"login":"karlnicholas","id":2110283,"avatar_url":"https://avatars.githubusercontent.com/u/2110283?v=3","gravatar_id":"","url":"https://api.github.com/users/karlnicholas","html_url":"https://github.com/karlnicholas","followers_url":"https://api.github.com/users/karlnicholas/followers","following_url":"https://api.github.com/users/karlnicholas/following{/other_user}","gists_url":"https://api.github.com/users/karlnicholas/gists{/gist_id}","starred_url":"https://api.github.com/users/karlnicholas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karlnicholas/subscriptions","organizations_url":"https://api.github.com/users/karlnicholas/orgs","repos_url":"https://api.github.com/users/karlnicholas/repos","events_url":"https://api.github.com/users/karlnicholas/events{/privacy}","received_events_url":"https://api.github.com/users/karlnicholas/received_events","type":"User","site_admin":false},"created_at":"2016-10-06T22:50:18Z","updated_at":"2016-10-06T22:50:18Z","body":"The vertix arrays should be left in the individual graphics classes because each they can be handled differently. For example the GraphicsPolygon uses the arrays in the Polygon class as storage and so only constructs temporary method variables, while the other graphics classes store them in the classes instance variables and retrieve them from there. Look closely at line 22 and 22 in GraphicsPolygon and you'll see what I mean. It is different from say lines 26, 27 in the GraphicsCircles class which uses a class variable. Short of it is that\r\n\r\n\tpublic int[] getXPoints();\r\n\tpublic int[] getYPoints();\r\n\tpublic void setVertixShape(int i, GraphicShape p);\r\n\r\nshould not be moved into the GraphicsBaseclass"}}
{"actor":{"display_login":"karlnicholas"}}