{"action":"created","comment":{"url":"https://api.github.com/repos/exodev/kernel/pulls/comments/87989259","pull_request_review_id":8576503,"id":87989259,"diff_hunk":"@@ -632,6 +634,10 @@ public boolean isStarted()\n    @Override\n    public void start()\n    {\n+      if(!initialized_) {\n+        initialized_ = true;\n+        super.start(true);","path":"exo.kernel.container/src/main/java/org/exoplatform/container/PortalContainer.java","position":15,"original_position":15,"commit_id":"24cfa7e6854db8d386aa508610927fbf51b6ac10","original_commit_id":"24cfa7e6854db8d386aa508610927fbf51b6ac10","user":{"login":"thomasdelhomenie","id":342645,"avatar_url":"https://avatars.githubusercontent.com/u/342645?v=3","gravatar_id":"","url":"https://api.github.com/users/thomasdelhomenie","html_url":"https://github.com/thomasdelhomenie","followers_url":"https://api.github.com/users/thomasdelhomenie/followers","following_url":"https://api.github.com/users/thomasdelhomenie/following{/other_user}","gists_url":"https://api.github.com/users/thomasdelhomenie/gists{/gist_id}","starred_url":"https://api.github.com/users/thomasdelhomenie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomasdelhomenie/subscriptions","organizations_url":"https://api.github.com/users/thomasdelhomenie/orgs","repos_url":"https://api.github.com/users/thomasdelhomenie/repos","events_url":"https://api.github.com/users/thomasdelhomenie/events{/privacy}","received_events_url":"https://api.github.com/users/thomasdelhomenie/received_events","type":"User","site_admin":false},"body":"If initialized_ is false, the super.start method will be called twice. Cannot it be a problem ? Why is this change needed ?","created_at":"2016-11-15T10:37:42Z","updated_at":"2016-11-15T10:37:42Z","html_url":"https://github.com/exodev/kernel/pull/9#discussion_r87989259","pull_request_url":"https://api.github.com/repos/exodev/kernel/pulls/9","_links":{"self":{"href":"https://api.github.com/repos/exodev/kernel/pulls/comments/87989259"},"html":{"href":"https://github.com/exodev/kernel/pull/9#discussion_r87989259"},"pull_request":{"href":"https://api.github.com/repos/exodev/kernel/pulls/9"}}},"pull_request":{"url":"https://api.github.com/repos/exodev/kernel/pulls/9","id":93374407,"html_url":"https://github.com/exodev/kernel/pull/9","diff_url":"https://github.com/exodev/kernel/pull/9.diff","patch_url":"https://github.com/exodev/kernel/pull/9.patch","issue_url":"https://api.github.com/repos/exodev/kernel/issues/9","number":9,"state":"open","locked":false,"title":"PLF-6880 Allow to add Container Lifecycle listeners to PortalContaine…","user":{"login":"boubaker","id":594824,"avatar_url":"https://avatars.githubusercontent.com/u/594824?v=3","gravatar_id":"","url":"https://api.github.com/users/boubaker","html_url":"https://github.com/boubaker","followers_url":"https://api.github.com/users/boubaker/followers","following_url":"https://api.github.com/users/boubaker/following{/other_user}","gists_url":"https://api.github.com/users/boubaker/gists{/gist_id}","starred_url":"https://api.github.com/users/boubaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boubaker/subscriptions","organizations_url":"https://api.github.com/users/boubaker/orgs","repos_url":"https://api.github.com/users/boubaker/repos","events_url":"https://api.github.com/users/boubaker/events{/privacy}","received_events_url":"https://api.github.com/users/boubaker/received_events","type":"User","site_admin":false},"body":"…r as for RootContainer","created_at":"2016-11-11T18:14:29Z","updated_at":"2016-11-15T10:37:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cee152ab8227e1d56a8c942311ce65ed5e8d41f6","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/exodev/kernel/pulls/9/commits","review_comments_url":"https://api.github.com/repos/exodev/kernel/pulls/9/comments","review_comment_url":"https://api.github.com/repos/exodev/kernel/pulls/comments{/number}","comments_url":"https://api.github.com/repos/exodev/kernel/issues/9/comments","statuses_url":"https://api.github.com/repos/exodev/kernel/statuses/24cfa7e6854db8d386aa508610927fbf51b6ac10","head":{"label":"exodev:fix/PLF-6880","ref":"fix/PLF-6880","sha":"24cfa7e6854db8d386aa508610927fbf51b6ac10","user":{"login":"exodev","id":1606522,"avatar_url":"https://avatars.githubusercontent.com/u/1606522?v=3","gravatar_id":"","url":"https://api.github.com/users/exodev","html_url":"https://github.com/exodev","followers_url":"https://api.github.com/users/exodev/followers","following_url":"https://api.github.com/users/exodev/following{/other_user}","gists_url":"https://api.github.com/users/exodev/gists{/gist_id}","starred_url":"https://api.github.com/users/exodev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exodev/subscriptions","organizations_url":"https://api.github.com/users/exodev/orgs","repos_url":"https://api.github.com/users/exodev/repos","events_url":"https://api.github.com/users/exodev/events{/privacy}","received_events_url":"https://api.github.com/users/exodev/received_events","type":"Organization","site_admin":false},"repo":{"id":4003282,"name":"kernel","full_name":"exodev/kernel","owner":{"login":"exodev","id":1606522,"avatar_url":"https://avatars.githubusercontent.com/u/1606522?v=3","gravatar_id":"","url":"https://api.github.com/users/exodev","html_url":"https://github.com/exodev","followers_url":"https://api.github.com/users/exodev/followers","following_url":"https://api.github.com/users/exodev/following{/other_user}","gists_url":"https://api.github.com/users/exodev/gists{/gist_id}","starred_url":"https://api.github.com/users/exodev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exodev/subscriptions","organizations_url":"https://api.github.com/users/exodev/orgs","repos_url":"https://api.github.com/users/exodev/repos","events_url":"https://api.github.com/users/exodev/events{/privacy}","received_events_url":"https://api.github.com/users/exodev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/exodev/kernel","description":"eXo Kernel","fork":true,"url":"https://api.github.com/repos/exodev/kernel","forks_url":"https://api.github.com/repos/exodev/kernel/forks","keys_url":"https://api.github.com/repos/exodev/kernel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/exodev/kernel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/exodev/kernel/teams","hooks_url":"https://api.github.com/repos/exodev/kernel/hooks","issue_events_url":"https://api.github.com/repos/exodev/kernel/issues/events{/number}","events_url":"https://api.github.com/repos/exodev/kernel/events","assignees_url":"https://api.github.com/repos/exodev/kernel/assignees{/user}","branches_url":"https://api.github.com/repos/exodev/kernel/branches{/branch}","tags_url":"https://api.github.com/repos/exodev/kernel/tags","blobs_url":"https://api.github.com/repos/exodev/kernel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/exodev/kernel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/exodev/kernel/git/refs{/sha}","trees_url":"https://api.github.com/repos/exodev/kernel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/exodev/kernel/statuses/{sha}","languages_url":"https://api.github.com/repos/exodev/kernel/languages","stargazers_url":"https://api.github.com/repos/exodev/kernel/stargazers","contributors_url":"https://api.github.com/repos/exodev/kernel/contributors","subscribers_url":"https://api.github.com/repos/exodev/kernel/subscribers","subscription_url":"https://api.github.com/repos/exodev/kernel/subscription","commits_url":"https://api.github.com/repos/exodev/kernel/commits{/sha}","git_commits_url":"https://api.github.com/repos/exodev/kernel/git/commits{/sha}","comments_url":"https://api.github.com/repos/exodev/kernel/comments{/number}","issue_comment_url":"https://api.github.com/repos/exodev/kernel/issues/comments{/number}","contents_url":"https://api.github.com/repos/exodev/kernel/contents/{+path}","compare_url":"https://api.github.com/repos/exodev/kernel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/exodev/kernel/merges","archive_url":"https://api.github.com/repos/exodev/kernel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/exodev/kernel/downloads","issues_url":"https://api.github.com/repos/exodev/kernel/issues{/number}","pulls_url":"https://api.github.com/repos/exodev/kernel/pulls{/number}","milestones_url":"https://api.github.com/repos/exodev/kernel/milestones{/number}","notifications_url":"https://api.github.com/repos/exodev/kernel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/exodev/kernel/labels{/name}","releases_url":"https://api.github.com/repos/exodev/kernel/releases{/id}","deployments_url":"https://api.github.com/repos/exodev/kernel/deployments","created_at":"2012-04-12T09:43:59Z","updated_at":"2016-09-13T12:54:12Z","pushed_at":"2016-11-11T18:14:29Z","git_url":"git://github.com/exodev/kernel.git","ssh_url":"git@github.com:exodev/kernel.git","clone_url":"https://github.com/exodev/kernel.git","svn_url":"https://github.com/exodev/kernel","homepage":null,"size":4507,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":1,"forks":4,"open_issues":1,"watchers":0,"default_branch":"develop"}},"base":{"label":"exodev:develop","ref":"develop","sha":"5735d4d85fb8eafa1e8e8fb5df295a4404340643","user":{"login":"exodev","id":1606522,"avatar_url":"https://avatars.githubusercontent.com/u/1606522?v=3","gravatar_id":"","url":"https://api.github.com/users/exodev","html_url":"https://github.com/exodev","followers_url":"https://api.github.com/users/exodev/followers","following_url":"https://api.github.com/users/exodev/following{/other_user}","gists_url":"https://api.github.com/users/exodev/gists{/gist_id}","starred_url":"https://api.github.com/users/exodev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exodev/subscriptions","organizations_url":"https://api.github.com/users/exodev/orgs","repos_url":"https://api.github.com/users/exodev/repos","events_url":"https://api.github.com/users/exodev/events{/privacy}","received_events_url":"https://api.github.com/users/exodev/received_events","type":"Organization","site_admin":false},"repo":{"id":4003282,"name":"kernel","full_name":"exodev/kernel","owner":{"login":"exodev","id":1606522,"avatar_url":"https://avatars.githubusercontent.com/u/1606522?v=3","gravatar_id":"","url":"https://api.github.com/users/exodev","html_url":"https://github.com/exodev","followers_url":"https://api.github.com/users/exodev/followers","following_url":"https://api.github.com/users/exodev/following{/other_user}","gists_url":"https://api.github.com/users/exodev/gists{/gist_id}","starred_url":"https://api.github.com/users/exodev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exodev/subscriptions","organizations_url":"https://api.github.com/users/exodev/orgs","repos_url":"https://api.github.com/users/exodev/repos","events_url":"https://api.github.com/users/exodev/events{/privacy}","received_events_url":"https://api.github.com/users/exodev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/exodev/kernel","description":"eXo Kernel","fork":true,"url":"https://api.github.com/repos/exodev/kernel","forks_url":"https://api.github.com/repos/exodev/kernel/forks","keys_url":"https://api.github.com/repos/exodev/kernel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/exodev/kernel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/exodev/kernel/teams","hooks_url":"https://api.github.com/repos/exodev/kernel/hooks","issue_events_url":"https://api.github.com/repos/exodev/kernel/issues/events{/number}","events_url":"https://api.github.com/repos/exodev/kernel/events","assignees_url":"https://api.github.com/repos/exodev/kernel/assignees{/user}","branches_url":"https://api.github.com/repos/exodev/kernel/branches{/branch}","tags_url":"https://api.github.com/repos/exodev/kernel/tags","blobs_url":"https://api.github.com/repos/exodev/kernel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/exodev/kernel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/exodev/kernel/git/refs{/sha}","trees_url":"https://api.github.com/repos/exodev/kernel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/exodev/kernel/statuses/{sha}","languages_url":"https://api.github.com/repos/exodev/kernel/languages","stargazers_url":"https://api.github.com/repos/exodev/kernel/stargazers","contributors_url":"https://api.github.com/repos/exodev/kernel/contributors","subscribers_url":"https://api.github.com/repos/exodev/kernel/subscribers","subscription_url":"https://api.github.com/repos/exodev/kernel/subscription","commits_url":"https://api.github.com/repos/exodev/kernel/commits{/sha}","git_commits_url":"https://api.github.com/repos/exodev/kernel/git/commits{/sha}","comments_url":"https://api.github.com/repos/exodev/kernel/comments{/number}","issue_comment_url":"https://api.github.com/repos/exodev/kernel/issues/comments{/number}","contents_url":"https://api.github.com/repos/exodev/kernel/contents/{+path}","compare_url":"https://api.github.com/repos/exodev/kernel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/exodev/kernel/merges","archive_url":"https://api.github.com/repos/exodev/kernel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/exodev/kernel/downloads","issues_url":"https://api.github.com/repos/exodev/kernel/issues{/number}","pulls_url":"https://api.github.com/repos/exodev/kernel/pulls{/number}","milestones_url":"https://api.github.com/repos/exodev/kernel/milestones{/number}","notifications_url":"https://api.github.com/repos/exodev/kernel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/exodev/kernel/labels{/name}","releases_url":"https://api.github.com/repos/exodev/kernel/releases{/id}","deployments_url":"https://api.github.com/repos/exodev/kernel/deployments","created_at":"2012-04-12T09:43:59Z","updated_at":"2016-09-13T12:54:12Z","pushed_at":"2016-11-11T18:14:29Z","git_url":"git://github.com/exodev/kernel.git","ssh_url":"git@github.com:exodev/kernel.git","clone_url":"https://github.com/exodev/kernel.git","svn_url":"https://github.com/exodev/kernel","homepage":null,"size":4507,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":1,"forks":4,"open_issues":1,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/exodev/kernel/pulls/9"},"html":{"href":"https://github.com/exodev/kernel/pull/9"},"issue":{"href":"https://api.github.com/repos/exodev/kernel/issues/9"},"comments":{"href":"https://api.github.com/repos/exodev/kernel/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/exodev/kernel/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/exodev/kernel/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/exodev/kernel/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/exodev/kernel/statuses/24cfa7e6854db8d386aa508610927fbf51b6ac10"}}}}
{"actor":{"display_login":"thomasdelhomenie"}}