{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/91780113","pull_request_review_id":12292736,"id":91780113,"diff_hunk":"@@ -245,13 +251,27 @@ If in doubt, you can always ask for guidance in the Pull Request or on\n Feel free to post a comment in the Pull Request to ping reviewers if you are\n awaiting an answer on something.\n \n+Notes: if the reviewer mentions *nits* in their comments, that stands for\n+\"requests for small changes that are not essential\". Usually these nits are","path":"CONTRIBUTING.md","position":18,"original_position":18,"commit_id":"c4ff0324290e44ff57e501754c5ed9761792bf62","original_commit_id":"c4ff0324290e44ff57e501754c5ed9761792bf62","user":{"login":"mscdex","id":54666,"avatar_url":"https://avatars.githubusercontent.com/u/54666?v=3","gravatar_id":"","url":"https://api.github.com/users/mscdex","html_url":"https://github.com/mscdex","followers_url":"https://api.github.com/users/mscdex/followers","following_url":"https://api.github.com/users/mscdex/following{/other_user}","gists_url":"https://api.github.com/users/mscdex/gists{/gist_id}","starred_url":"https://api.github.com/users/mscdex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mscdex/subscriptions","organizations_url":"https://api.github.com/users/mscdex/orgs","repos_url":"https://api.github.com/users/mscdex/repos","events_url":"https://api.github.com/users/mscdex/events{/privacy}","received_events_url":"https://api.github.com/users/mscdex/received_events","type":"User","site_admin":false},"body":"I'm not sure the description is quite accurate. IMHO nits are just minor issues, whether the changes needed to address the minor issue are large or small is irrelevant. For example, comment typos for a PR that changes code would probably be considered a nit especially because comments don't affect the code, but it could be there are a lot of typos to fix or just one.","created_at":"2016-12-09T19:35:05Z","updated_at":"2016-12-09T19:35:06Z","html_url":"https://github.com/nodejs/node/pull/10202#discussion_r91780113","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/10202","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/91780113"},"html":{"href":"https://github.com/nodejs/node/pull/10202#discussion_r91780113"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/10202"}}},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/10202","id":97364668,"html_url":"https://github.com/nodejs/node/pull/10202","diff_url":"https://github.com/nodejs/node/pull/10202.diff","patch_url":"https://github.com/nodejs/node/pull/10202.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/10202","number":10202,"state":"open","locked":false,"title":"doc: clarify the review and landing process","user":{"login":"joyeecheung","id":4299420,"avatar_url":"https://avatars.githubusercontent.com/u/4299420?v=3","gravatar_id":"","url":"https://api.github.com/users/joyeecheung","html_url":"https://github.com/joyeecheung","followers_url":"https://api.github.com/users/joyeecheung/followers","following_url":"https://api.github.com/users/joyeecheung/following{/other_user}","gists_url":"https://api.github.com/users/joyeecheung/gists{/gist_id}","starred_url":"https://api.github.com/users/joyeecheung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joyeecheung/subscriptions","organizations_url":"https://api.github.com/users/joyeecheung/orgs","repos_url":"https://api.github.com/users/joyeecheung/repos","events_url":"https://api.github.com/users/joyeecheung/events{/privacy}","received_events_url":"https://api.github.com/users/joyeecheung/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you for your pull request. Please review below requirements.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] documentation is changed or added\r\n- [x] commit message follows commit guidelines\r\n\r\n##### Affected core subsystem(s)\r\n<!-- Provide affected core subsystem(s) (like doc, cluster, crypto, etc). -->\r\n\r\ndoc\r\n\r\n##### Description of change\r\n<!-- Provide a description of the change below this comment. -->\r\n\r\nA few process-related details are only explained in the onboarding guide and the collaborator's guide. Mentioning them in the contributing guide as well can avoid confusions to new contributors.\r\nThis is based on my previous experience, but I am still a new contributor myself, so feel free to correct me if my understanding is not the case!\r\n\r\n* Explains what \"nits\" stand for\r\n* Explains commit squashing\r\n* Mention the CI run\r\n* Mention the mandatory 48/72 hours wait\r\n\r\nRef: https://github.com/nodejs/node/pull/10151\r\n","created_at":"2016-12-09T19:19:45Z","updated_at":"2016-12-09T19:35:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"939b46f60bf8e13d993f760255aa7c61035efc26","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/10202/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/10202/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/10202/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/c4ff0324290e44ff57e501754c5ed9761792bf62","head":{"label":"joyeecheung:contributing-guide","ref":"contributing-guide","sha":"c4ff0324290e44ff57e501754c5ed9761792bf62","user":{"login":"joyeecheung","id":4299420,"avatar_url":"https://avatars.githubusercontent.com/u/4299420?v=3","gravatar_id":"","url":"https://api.github.com/users/joyeecheung","html_url":"https://github.com/joyeecheung","followers_url":"https://api.github.com/users/joyeecheung/followers","following_url":"https://api.github.com/users/joyeecheung/following{/other_user}","gists_url":"https://api.github.com/users/joyeecheung/gists{/gist_id}","starred_url":"https://api.github.com/users/joyeecheung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joyeecheung/subscriptions","organizations_url":"https://api.github.com/users/joyeecheung/orgs","repos_url":"https://api.github.com/users/joyeecheung/repos","events_url":"https://api.github.com/users/joyeecheung/events{/privacy}","received_events_url":"https://api.github.com/users/joyeecheung/received_events","type":"User","site_admin":false},"repo":{"id":75291879,"name":"node","full_name":"joyeecheung/node","owner":{"login":"joyeecheung","id":4299420,"avatar_url":"https://avatars.githubusercontent.com/u/4299420?v=3","gravatar_id":"","url":"https://api.github.com/users/joyeecheung","html_url":"https://github.com/joyeecheung","followers_url":"https://api.github.com/users/joyeecheung/followers","following_url":"https://api.github.com/users/joyeecheung/following{/other_user}","gists_url":"https://api.github.com/users/joyeecheung/gists{/gist_id}","starred_url":"https://api.github.com/users/joyeecheung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joyeecheung/subscriptions","organizations_url":"https://api.github.com/users/joyeecheung/orgs","repos_url":"https://api.github.com/users/joyeecheung/repos","events_url":"https://api.github.com/users/joyeecheung/events{/privacy}","received_events_url":"https://api.github.com/users/joyeecheung/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/joyeecheung/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":true,"url":"https://api.github.com/repos/joyeecheung/node","forks_url":"https://api.github.com/repos/joyeecheung/node/forks","keys_url":"https://api.github.com/repos/joyeecheung/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joyeecheung/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joyeecheung/node/teams","hooks_url":"https://api.github.com/repos/joyeecheung/node/hooks","issue_events_url":"https://api.github.com/repos/joyeecheung/node/issues/events{/number}","events_url":"https://api.github.com/repos/joyeecheung/node/events","assignees_url":"https://api.github.com/repos/joyeecheung/node/assignees{/user}","branches_url":"https://api.github.com/repos/joyeecheung/node/branches{/branch}","tags_url":"https://api.github.com/repos/joyeecheung/node/tags","blobs_url":"https://api.github.com/repos/joyeecheung/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joyeecheung/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joyeecheung/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/joyeecheung/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joyeecheung/node/statuses/{sha}","languages_url":"https://api.github.com/repos/joyeecheung/node/languages","stargazers_url":"https://api.github.com/repos/joyeecheung/node/stargazers","contributors_url":"https://api.github.com/repos/joyeecheung/node/contributors","subscribers_url":"https://api.github.com/repos/joyeecheung/node/subscribers","subscription_url":"https://api.github.com/repos/joyeecheung/node/subscription","commits_url":"https://api.github.com/repos/joyeecheung/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/joyeecheung/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/joyeecheung/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/joyeecheung/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/joyeecheung/node/contents/{+path}","compare_url":"https://api.github.com/repos/joyeecheung/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joyeecheung/node/merges","archive_url":"https://api.github.com/repos/joyeecheung/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joyeecheung/node/downloads","issues_url":"https://api.github.com/repos/joyeecheung/node/issues{/number}","pulls_url":"https://api.github.com/repos/joyeecheung/node/pulls{/number}","milestones_url":"https://api.github.com/repos/joyeecheung/node/milestones{/number}","notifications_url":"https://api.github.com/repos/joyeecheung/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joyeecheung/node/labels{/name}","releases_url":"https://api.github.com/repos/joyeecheung/node/releases{/id}","deployments_url":"https://api.github.com/repos/joyeecheung/node/deployments","created_at":"2016-12-01T12:47:03Z","updated_at":"2016-12-01T12:47:27Z","pushed_at":"2016-12-09T19:22:05Z","git_url":"git://github.com/joyeecheung/node.git","ssh_url":"git@github.com:joyeecheung/node.git","clone_url":"https://github.com/joyeecheung/node.git","svn_url":"https://github.com/joyeecheung/node","homepage":"https://nodejs.org","size":249104,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"d8c7534fcd46283e52c8c9324d11390c6218b809","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2016-12-09T19:09:13Z","pushed_at":"2016-12-09T19:27:04Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":377913,"stargazers_count":29688,"watchers_count":29688,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5305,"mirror_url":null,"open_issues_count":1024,"forks":5305,"open_issues":1024,"watchers":29688,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/10202"},"html":{"href":"https://github.com/nodejs/node/pull/10202"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/10202"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/10202/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/10202/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/10202/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/c4ff0324290e44ff57e501754c5ed9761792bf62"}}}}
{"actor":{"display_login":"mscdex"}}