{"action":"created","issue":{"url":"https://api.github.com/repos/tinderjs/tinder-desktop/issues/4","repository_url":"https://api.github.com/repos/tinderjs/tinder-desktop","labels_url":"https://api.github.com/repos/tinderjs/tinder-desktop/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/tinderjs/tinder-desktop/issues/4/comments","events_url":"https://api.github.com/repos/tinderjs/tinder-desktop/issues/4/events","html_url":"https://github.com/tinderjs/tinder-desktop/issues/4","id":141018390,"number":4,"title":"Discussion [Future of Tinder-desktop GUI]","user":{"login":"mrmayfield","id":7200471,"avatar_url":"https://avatars.githubusercontent.com/u/7200471?v=3","gravatar_id":"","url":"https://api.github.com/users/mrmayfield","html_url":"https://github.com/mrmayfield","followers_url":"https://api.github.com/users/mrmayfield/followers","following_url":"https://api.github.com/users/mrmayfield/following{/other_user}","gists_url":"https://api.github.com/users/mrmayfield/gists{/gist_id}","starred_url":"https://api.github.com/users/mrmayfield/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrmayfield/subscriptions","organizations_url":"https://api.github.com/users/mrmayfield/orgs","repos_url":"https://api.github.com/users/mrmayfield/repos","events_url":"https://api.github.com/users/mrmayfield/events{/privacy}","received_events_url":"https://api.github.com/users/mrmayfield/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2016-03-15T15:56:59Z","updated_at":"2016-03-15T16:33:56Z","closed_at":null,"body":"Hey @SaturnusDJ ,\r\n\r\nLet's use this issue to discuss the design decisions broadly of tinder-desktop.\r\n\r\nI've checked out your pull requests and haven't pulled it. For one, there are a couple issues, like the zip file being committed to source, if I was to merge this PR I would ask you to do things like remove that zip file first.\r\n\r\nThe other is I'm not totally sure exactly what has changed and I've noticed a 'bug' or two as well. \r\n![screen shot 2016-03-15 at 9 45 24 am](https://cloud.githubusercontent.com/assets/7200471/13783969/177f6602-ea93-11e5-9153-530d50dd29db.png)\r\n\r\nFor example, you can see the text profile isn't being displayed properly (it's not centered). There's also little issues like inline CSS being used (harder to maintain).\r\n\r\nhttps://github.com/tinderjs/tinder-desktop/pull/1/files#diff-c5ccb23a8eb2fc0c7e51b595a2eae347R112\r\n\r\nFor me to accept all the frontend changes, I would first like to know what each of them does. There's a few ways we could do this:\r\n1) You could post screenshots like you did with that one screenshot, which was immensely helpful for me\r\n2) We could go over it with a screensharing program and you could explain them to me\r\n3) We could go through it line by line through the PR and see what is going on\r\n\r\nThe other thing is that in regards to the GUI, I think we should only change things if we see a definite benefit to the change. For example, changing the settings to a gear button, it's mostly a matter of opinion on if that is a change we would like (personally, I like it) but unless we've identified something as an issue that needs to be fixed, we should probably open a discussion on the GUI features that we're noticing as subpar and that we would like to fix before we go in and change them.\r\n\r\nEverything make sense? Also, in more broad frontend strategic views, I'm wondering if we should make this app a fullscreen application. For example, one of  the things that I don't like is that on the messages page the photo for the matches are so small it's very hard to see what they look like. For me, that's a design error that we should address, perhaps by making it fullscreen. \r\n\r\n![screen shot 2016-03-15 at 9 55 50 am](https://cloud.githubusercontent.com/assets/7200471/13784259/2aaa11ea-ea94-11e5-8abb-95454ef7484b.png)\r\n![screen shot 2016-03-15 at 9 55 29 am](https://cloud.githubusercontent.com/assets/7200471/13784260/2b08eb8e-ea94-11e5-8570-8551a771cf84.png)\r\n\r\nHere's the comparable sizes on WhatsApp and Facebook Messenger, and it could be argued having a larger size on Tinder is even more important because of how you don't know the people very well and how important appearance is. Let me know what you think. :)\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/tinderjs/tinder-desktop/issues/comments/196910647","html_url":"https://github.com/tinderjs/tinder-desktop/issues/4#issuecomment-196910647","issue_url":"https://api.github.com/repos/tinderjs/tinder-desktop/issues/4","id":196910647,"user":{"login":"SaturnusDJ","id":14320018,"avatar_url":"https://avatars.githubusercontent.com/u/14320018?v=3","gravatar_id":"","url":"https://api.github.com/users/SaturnusDJ","html_url":"https://github.com/SaturnusDJ","followers_url":"https://api.github.com/users/SaturnusDJ/followers","following_url":"https://api.github.com/users/SaturnusDJ/following{/other_user}","gists_url":"https://api.github.com/users/SaturnusDJ/gists{/gist_id}","starred_url":"https://api.github.com/users/SaturnusDJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SaturnusDJ/subscriptions","organizations_url":"https://api.github.com/users/SaturnusDJ/orgs","repos_url":"https://api.github.com/users/SaturnusDJ/repos","events_url":"https://api.github.com/users/SaturnusDJ/events{/privacy}","received_events_url":"https://api.github.com/users/SaturnusDJ/received_events","type":"User","site_admin":false},"created_at":"2016-03-15T16:33:56Z","updated_at":"2016-03-15T16:33:56Z","body":"Hi @mrmayfield \r\n\r\nYes I can remove the unnecessary files when the moment is there. Don't know how to exclude them from pull, that would be easier.\r\n\r\nThe profile text was centered, I changed it to be aligned left so it would look more like tinder-mobile. Your screenshot clearly shows the disadvantage. I can change it back to be centered. A better solution, in my opinion, would be to still align left but center the whole text area and limit it's width to approximately the size of picture above to keep it readable.\r\n\r\nThe inline was done on purpose because I don't like the solution. It's about undo-swipe. The position of this object should be relative to the picture stack but I don't know how to code it yet. I can put it in .css with comment.\r\n\r\nConcerning the changes. Do you want to know every single line or more the general ideas?\r\n\r\nI like to optimize/improve GUI, but of course that's my opinion. Continuously improving is something I really like and keeps me going, but I understand some boundaries are needed.\r\n\r\nFullscreen as option is okay with me, forcing fullscreen I don't like. I always use Tinder next to browsing, etc, etc.\r\n\r\nMaybe we can make profile pictures in messages screen hoverable. You don't like to open the profiles? That's what I do when really wanting to look up pictures.\r\nWhat I already did was using the native size for the big pictures, so they became sharper (300 -> 320px)."}}