{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/origin-aggregated-logging/pulls/comments/58861840","id":58861840,"diff_hunk":"@@ -0,0 +1,53 @@\n+#!/bin/bash\n+\n+# This script builds and pushes a release to DockerHub.\n+\n+set -o errexit\n+set -o nounset\n+set -o pipefail\n+\n+OS_ROOT=$(dirname \"${BASH_SOURCE}\")/..\n+source \"${OS_ROOT}/hack/common.sh\"\n+\n+# Go to the top of the tree.\n+cd \"${OS_ROOT}\"\n+\n+if [[ -z \"${OS_TAG}\" ]]; then\n+  echo \"You must specify the OS_TAG variable as the name of the tag to create, e.g. 'v1.0.1'.\"\n+  exit 1\n+fi\n+tag=\"${OS_TAG}\"\n+\n+if [[ \"$(git name-rev --name-only --tags HEAD)\" != \"${tag}^0\" ]]; then\n+  if git rev-parse -q --short \"${tag}\" &>/dev/null; then\n+    echo \"Tag ${tag} already exists\"\n+    exit 1\n+  else\n+    git tag \"${tag}\" -a -m \"${tag}\" HEAD\n+  fi\n+fi\n+\n+function removeimage() {\n+  for i in $@; do\n+    if docker inspect $i &>/dev/null; then\n+      docker rmi $i\n+    fi\n+    if docker inspect docker.io/$i &>/dev/null; then\n+      docker rmi docker.io/$i\n+    fi\n+  done\n+}\n+\n+removeimage openshift/origin centos openshift/base-centos7","path":"hack/release.sh","position":41,"original_position":41,"commit_id":"0967bef54d1338f27e4d2251fa157137010e9ba2","original_commit_id":"0967bef54d1338f27e4d2251fa157137010e9ba2","user":{"login":"jcantrill","id":4548408,"avatar_url":"https://avatars.githubusercontent.com/u/4548408?v=3","gravatar_id":"","url":"https://api.github.com/users/jcantrill","html_url":"https://github.com/jcantrill","followers_url":"https://api.github.com/users/jcantrill/followers","following_url":"https://api.github.com/users/jcantrill/following{/other_user}","gists_url":"https://api.github.com/users/jcantrill/gists{/gist_id}","starred_url":"https://api.github.com/users/jcantrill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcantrill/subscriptions","organizations_url":"https://api.github.com/users/jcantrill/orgs","repos_url":"https://api.github.com/users/jcantrill/repos","events_url":"https://api.github.com/users/jcantrill/events{/privacy}","received_events_url":"https://api.github.com/users/jcantrill/received_events","type":"User","site_admin":false},"body":"As long as we can parameterize the Dockerfile to use a base image of our choosing does it need to move to origin?  That is possible right?","created_at":"2016-04-07T12:24:29Z","updated_at":"2016-04-07T12:24:29Z","html_url":"https://github.com/openshift/origin-aggregated-logging/pull/110#discussion_r58861840","pull_request_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/pulls/110","_links":{"self":{"href":"https://api.github.com/repos/openshift/origin-aggregated-logging/pulls/comments/58861840"},"html":{"href":"https://github.com/openshift/origin-aggregated-logging/pull/110#discussion_r58861840"},"pull_request":{"href":"https://api.github.com/repos/openshift/origin-aggregated-logging/pulls/110"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/origin-aggregated-logging/pulls/110","id":65365164,"html_url":"https://github.com/openshift/origin-aggregated-logging/pull/110","diff_url":"https://github.com/openshift/origin-aggregated-logging/pull/110.diff","patch_url":"https://github.com/openshift/origin-aggregated-logging/pull/110.patch","issue_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/issues/110","number":110,"state":"open","locked":false,"title":"fix build-images script for origin release process","user":{"login":"jcantrill","id":4548408,"avatar_url":"https://avatars.githubusercontent.com/u/4548408?v=3","gravatar_id":"","url":"https://api.github.com/users/jcantrill","html_url":"https://github.com/jcantrill","followers_url":"https://api.github.com/users/jcantrill/followers","following_url":"https://api.github.com/users/jcantrill/following{/other_user}","gists_url":"https://api.github.com/users/jcantrill/gists{/gist_id}","starred_url":"https://api.github.com/users/jcantrill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcantrill/subscriptions","organizations_url":"https://api.github.com/users/jcantrill/orgs","repos_url":"https://api.github.com/users/jcantrill/repos","events_url":"https://api.github.com/users/jcantrill/events{/privacy}","received_events_url":"https://api.github.com/users/jcantrill/received_events","type":"User","site_admin":false},"body":"cc @richm @sosiouxme  Updates to allow the origin release build to call our build script with a desired version for tagging.","created_at":"2016-04-05T20:01:04Z","updated_at":"2016-04-07T12:24:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bbff5f64e0b23c8ce953794bfb029a48e42c25b8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/pulls/110/commits","review_comments_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/pulls/110/comments","review_comment_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/issues/110/comments","statuses_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/statuses/0967bef54d1338f27e4d2251fa157137010e9ba2","head":{"label":"jcantrill:update_build_image_script","ref":"update_build_image_script","sha":"0967bef54d1338f27e4d2251fa157137010e9ba2","user":{"login":"jcantrill","id":4548408,"avatar_url":"https://avatars.githubusercontent.com/u/4548408?v=3","gravatar_id":"","url":"https://api.github.com/users/jcantrill","html_url":"https://github.com/jcantrill","followers_url":"https://api.github.com/users/jcantrill/followers","following_url":"https://api.github.com/users/jcantrill/following{/other_user}","gists_url":"https://api.github.com/users/jcantrill/gists{/gist_id}","starred_url":"https://api.github.com/users/jcantrill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcantrill/subscriptions","organizations_url":"https://api.github.com/users/jcantrill/orgs","repos_url":"https://api.github.com/users/jcantrill/repos","events_url":"https://api.github.com/users/jcantrill/events{/privacy}","received_events_url":"https://api.github.com/users/jcantrill/received_events","type":"User","site_admin":false},"repo":{"id":42534471,"name":"origin-aggregated-logging","full_name":"jcantrill/origin-aggregated-logging","owner":{"login":"jcantrill","id":4548408,"avatar_url":"https://avatars.githubusercontent.com/u/4548408?v=3","gravatar_id":"","url":"https://api.github.com/users/jcantrill","html_url":"https://github.com/jcantrill","followers_url":"https://api.github.com/users/jcantrill/followers","following_url":"https://api.github.com/users/jcantrill/following{/other_user}","gists_url":"https://api.github.com/users/jcantrill/gists{/gist_id}","starred_url":"https://api.github.com/users/jcantrill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcantrill/subscriptions","organizations_url":"https://api.github.com/users/jcantrill/orgs","repos_url":"https://api.github.com/users/jcantrill/repos","events_url":"https://api.github.com/users/jcantrill/events{/privacy}","received_events_url":"https://api.github.com/users/jcantrill/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jcantrill/origin-aggregated-logging","description":"","fork":true,"url":"https://api.github.com/repos/jcantrill/origin-aggregated-logging","forks_url":"https://api.github.com/repos/jcantrill/origin-aggregated-logging/forks","keys_url":"https://api.github.com/repos/jcantrill/origin-aggregated-logging/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jcantrill/origin-aggregated-logging/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jcantrill/origin-aggregated-logging/teams","hooks_url":"https://api.github.com/repos/jcantrill/origin-aggregated-logging/hooks","issue_events_url":"https://api.github.com/repos/jcantrill/origin-aggregated-logging/issues/events{/number}","events_url":"https://api.github.com/repos/jcantrill/origin-aggregated-logging/events","assignees_url":"https://api.github.com/repos/jcantrill/origin-aggregated-logging/assignees{/user}","branches_url":"https://api.github.com/repos/jcantrill/origin-aggregated-logging/branches{/branch}","tags_url":"https://api.github.com/repos/jcantrill/origin-aggregated-logging/tags","blobs_url":"https://api.github.com/repos/jcantrill/origin-aggregated-logging/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jcantrill/origin-aggregated-logging/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jcantrill/origin-aggregated-logging/git/refs{/sha}","trees_url":"https://api.github.com/repos/jcantrill/origin-aggregated-logging/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jcantrill/origin-aggregated-logging/statuses/{sha}","languages_url":"https://api.github.com/repos/jcantrill/origin-aggregated-logging/languages","stargazers_url":"https://api.github.com/repos/jcantrill/origin-aggregated-logging/stargazers","contributors_url":"https://api.github.com/repos/jcantrill/origin-aggregated-logging/contributors","subscribers_url":"https://api.github.com/repos/jcantrill/origin-aggregated-logging/subscribers","subscription_url":"https://api.github.com/repos/jcantrill/origin-aggregated-logging/subscription","commits_url":"https://api.github.com/repos/jcantrill/origin-aggregated-logging/commits{/sha}","git_commits_url":"https://api.github.com/repos/jcantrill/origin-aggregated-logging/git/commits{/sha}","comments_url":"https://api.github.com/repos/jcantrill/origin-aggregated-logging/comments{/number}","issue_comment_url":"https://api.github.com/repos/jcantrill/origin-aggregated-logging/issues/comments{/number}","contents_url":"https://api.github.com/repos/jcantrill/origin-aggregated-logging/contents/{+path}","compare_url":"https://api.github.com/repos/jcantrill/origin-aggregated-logging/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jcantrill/origin-aggregated-logging/merges","archive_url":"https://api.github.com/repos/jcantrill/origin-aggregated-logging/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jcantrill/origin-aggregated-logging/downloads","issues_url":"https://api.github.com/repos/jcantrill/origin-aggregated-logging/issues{/number}","pulls_url":"https://api.github.com/repos/jcantrill/origin-aggregated-logging/pulls{/number}","milestones_url":"https://api.github.com/repos/jcantrill/origin-aggregated-logging/milestones{/number}","notifications_url":"https://api.github.com/repos/jcantrill/origin-aggregated-logging/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jcantrill/origin-aggregated-logging/labels{/name}","releases_url":"https://api.github.com/repos/jcantrill/origin-aggregated-logging/releases{/id}","deployments_url":"https://api.github.com/repos/jcantrill/origin-aggregated-logging/deployments","created_at":"2015-09-15T17:17:48Z","updated_at":"2016-04-05T19:26:33Z","pushed_at":"2016-04-06T20:45:55Z","git_url":"git://github.com/jcantrill/origin-aggregated-logging.git","ssh_url":"git@github.com:jcantrill/origin-aggregated-logging.git","clone_url":"https://github.com/jcantrill/origin-aggregated-logging.git","svn_url":"https://github.com/jcantrill/origin-aggregated-logging","homepage":null,"size":225,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"03d20f10ecbc004d1e40fbdd71a979e319e48702","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":42467822,"name":"origin-aggregated-logging","full_name":"openshift/origin-aggregated-logging","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin-aggregated-logging","description":"","fork":false,"url":"https://api.github.com/repos/openshift/origin-aggregated-logging","forks_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/forks","keys_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/teams","hooks_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/events","assignees_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/tags","blobs_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/languages","stargazers_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/subscription","commits_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/merges","archive_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/downloads","issues_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/deployments","created_at":"2015-09-14T18:14:19Z","updated_at":"2016-03-21T15:09:43Z","pushed_at":"2016-04-06T21:23:34Z","git_url":"git://github.com/openshift/origin-aggregated-logging.git","ssh_url":"git@github.com:openshift/origin-aggregated-logging.git","clone_url":"https://github.com/openshift/origin-aggregated-logging.git","svn_url":"https://github.com/openshift/origin-aggregated-logging","homepage":null,"size":237,"stargazers_count":5,"watchers_count":5,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":22,"forks":17,"open_issues":22,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin-aggregated-logging/pulls/110"},"html":{"href":"https://github.com/openshift/origin-aggregated-logging/pull/110"},"issue":{"href":"https://api.github.com/repos/openshift/origin-aggregated-logging/issues/110"},"comments":{"href":"https://api.github.com/repos/openshift/origin-aggregated-logging/issues/110/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin-aggregated-logging/pulls/110/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin-aggregated-logging/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin-aggregated-logging/pulls/110/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin-aggregated-logging/statuses/0967bef54d1338f27e4d2251fa157137010e9ba2"}}}}