{"action":"closed","number":2737,"pull_request":{"url":"https://api.github.com/repos/rust-lang/cargo/pulls/2737","id":71221263,"html_url":"https://github.com/rust-lang/cargo/pull/2737","diff_url":"https://github.com/rust-lang/cargo/pull/2737.diff","patch_url":"https://github.com/rust-lang/cargo/pull/2737.patch","issue_url":"https://api.github.com/repos/rust-lang/cargo/issues/2737","number":2737,"state":"closed","locked":false,"title":"Hash url serialization to ensure hash stability","user":{"login":"aidanhs","id":1050652,"avatar_url":"https://avatars.githubusercontent.com/u/1050652?v=3","gravatar_id":"","url":"https://api.github.com/users/aidanhs","html_url":"https://github.com/aidanhs","followers_url":"https://api.github.com/users/aidanhs/followers","following_url":"https://api.github.com/users/aidanhs/following{/other_user}","gists_url":"https://api.github.com/users/aidanhs/gists{/gist_id}","starred_url":"https://api.github.com/users/aidanhs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aidanhs/subscriptions","organizations_url":"https://api.github.com/users/aidanhs/orgs","repos_url":"https://api.github.com/users/aidanhs/repos","events_url":"https://api.github.com/users/aidanhs/events{/privacy}","received_events_url":"https://api.github.com/users/aidanhs/received_events","type":"User","site_admin":false},"body":"`as_str` is documented to return the serialization of a url (http://servo.github.io/rust-url/url/struct.Url.html#method.as_str).\r\nThe serialization of a url has a spec (https://url.spec.whatwg.org/#url-serializing).\r\n\r\nHashing the serialization of a url insulates cargo against possible decisions to alter how rust-url does hashing (I've observed it happening twice). Note that rust-url happens to do this internally (but is not guaranteed to in future) and so this change doesn't actually have any effect on hash values.\r\n\r\nr? @alexcrichton \r\n\r\nCloses #1710","created_at":"2016-05-24T13:37:38Z","updated_at":"2016-05-24T20:03:40Z","closed_at":"2016-05-24T20:03:40Z","merged_at":"2016-05-24T20:03:40Z","merge_commit_sha":"b691f1e4c5dd7449c3ab3cf1da3a061a2f3d5599","assignee":{"login":"alexcrichton","id":64996,"avatar_url":"https://avatars.githubusercontent.com/u/64996?v=3","gravatar_id":"","url":"https://api.github.com/users/alexcrichton","html_url":"https://github.com/alexcrichton","followers_url":"https://api.github.com/users/alexcrichton/followers","following_url":"https://api.github.com/users/alexcrichton/following{/other_user}","gists_url":"https://api.github.com/users/alexcrichton/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcrichton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcrichton/subscriptions","organizations_url":"https://api.github.com/users/alexcrichton/orgs","repos_url":"https://api.github.com/users/alexcrichton/repos","events_url":"https://api.github.com/users/alexcrichton/events{/privacy}","received_events_url":"https://api.github.com/users/alexcrichton/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/cargo/pulls/2737/commits","review_comments_url":"https://api.github.com/repos/rust-lang/cargo/pulls/2737/comments","review_comment_url":"https://api.github.com/repos/rust-lang/cargo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang/cargo/issues/2737/comments","statuses_url":"https://api.github.com/repos/rust-lang/cargo/statuses/b691f1e4c5dd7449c3ab3cf1da3a061a2f3d5599","head":{"label":"aidanhs:aphs-hash-url-serialization","ref":"aphs-hash-url-serialization","sha":"b691f1e4c5dd7449c3ab3cf1da3a061a2f3d5599","user":{"login":"aidanhs","id":1050652,"avatar_url":"https://avatars.githubusercontent.com/u/1050652?v=3","gravatar_id":"","url":"https://api.github.com/users/aidanhs","html_url":"https://github.com/aidanhs","followers_url":"https://api.github.com/users/aidanhs/followers","following_url":"https://api.github.com/users/aidanhs/following{/other_user}","gists_url":"https://api.github.com/users/aidanhs/gists{/gist_id}","starred_url":"https://api.github.com/users/aidanhs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aidanhs/subscriptions","organizations_url":"https://api.github.com/users/aidanhs/orgs","repos_url":"https://api.github.com/users/aidanhs/repos","events_url":"https://api.github.com/users/aidanhs/events{/privacy}","received_events_url":"https://api.github.com/users/aidanhs/received_events","type":"User","site_admin":false},"repo":{"id":57219863,"name":"cargo","full_name":"aidanhs/cargo","owner":{"login":"aidanhs","id":1050652,"avatar_url":"https://avatars.githubusercontent.com/u/1050652?v=3","gravatar_id":"","url":"https://api.github.com/users/aidanhs","html_url":"https://github.com/aidanhs","followers_url":"https://api.github.com/users/aidanhs/followers","following_url":"https://api.github.com/users/aidanhs/following{/other_user}","gists_url":"https://api.github.com/users/aidanhs/gists{/gist_id}","starred_url":"https://api.github.com/users/aidanhs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aidanhs/subscriptions","organizations_url":"https://api.github.com/users/aidanhs/orgs","repos_url":"https://api.github.com/users/aidanhs/repos","events_url":"https://api.github.com/users/aidanhs/events{/privacy}","received_events_url":"https://api.github.com/users/aidanhs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aidanhs/cargo","description":"The Rust package manager","fork":true,"url":"https://api.github.com/repos/aidanhs/cargo","forks_url":"https://api.github.com/repos/aidanhs/cargo/forks","keys_url":"https://api.github.com/repos/aidanhs/cargo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aidanhs/cargo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aidanhs/cargo/teams","hooks_url":"https://api.github.com/repos/aidanhs/cargo/hooks","issue_events_url":"https://api.github.com/repos/aidanhs/cargo/issues/events{/number}","events_url":"https://api.github.com/repos/aidanhs/cargo/events","assignees_url":"https://api.github.com/repos/aidanhs/cargo/assignees{/user}","branches_url":"https://api.github.com/repos/aidanhs/cargo/branches{/branch}","tags_url":"https://api.github.com/repos/aidanhs/cargo/tags","blobs_url":"https://api.github.com/repos/aidanhs/cargo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aidanhs/cargo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aidanhs/cargo/git/refs{/sha}","trees_url":"https://api.github.com/repos/aidanhs/cargo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aidanhs/cargo/statuses/{sha}","languages_url":"https://api.github.com/repos/aidanhs/cargo/languages","stargazers_url":"https://api.github.com/repos/aidanhs/cargo/stargazers","contributors_url":"https://api.github.com/repos/aidanhs/cargo/contributors","subscribers_url":"https://api.github.com/repos/aidanhs/cargo/subscribers","subscription_url":"https://api.github.com/repos/aidanhs/cargo/subscription","commits_url":"https://api.github.com/repos/aidanhs/cargo/commits{/sha}","git_commits_url":"https://api.github.com/repos/aidanhs/cargo/git/commits{/sha}","comments_url":"https://api.github.com/repos/aidanhs/cargo/comments{/number}","issue_comment_url":"https://api.github.com/repos/aidanhs/cargo/issues/comments{/number}","contents_url":"https://api.github.com/repos/aidanhs/cargo/contents/{+path}","compare_url":"https://api.github.com/repos/aidanhs/cargo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aidanhs/cargo/merges","archive_url":"https://api.github.com/repos/aidanhs/cargo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aidanhs/cargo/downloads","issues_url":"https://api.github.com/repos/aidanhs/cargo/issues{/number}","pulls_url":"https://api.github.com/repos/aidanhs/cargo/pulls{/number}","milestones_url":"https://api.github.com/repos/aidanhs/cargo/milestones{/number}","notifications_url":"https://api.github.com/repos/aidanhs/cargo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aidanhs/cargo/labels{/name}","releases_url":"https://api.github.com/repos/aidanhs/cargo/releases{/id}","deployments_url":"https://api.github.com/repos/aidanhs/cargo/deployments","created_at":"2016-04-27T14:27:27Z","updated_at":"2016-04-27T14:27:30Z","pushed_at":"2016-05-24T18:29:24Z","git_url":"git://github.com/aidanhs/cargo.git","ssh_url":"git@github.com:aidanhs/cargo.git","clone_url":"https://github.com/aidanhs/cargo.git","svn_url":"https://github.com/aidanhs/cargo","homepage":"http://crates.io/","size":10615,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"ca743f3118532e7fc5f74938801ebac369665c89","user":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":17420913,"name":"cargo","full_name":"rust-lang/cargo","owner":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/cargo","description":"The Rust package manager","fork":false,"url":"https://api.github.com/repos/rust-lang/cargo","forks_url":"https://api.github.com/repos/rust-lang/cargo/forks","keys_url":"https://api.github.com/repos/rust-lang/cargo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/cargo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/cargo/teams","hooks_url":"https://api.github.com/repos/rust-lang/cargo/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/cargo/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/cargo/events","assignees_url":"https://api.github.com/repos/rust-lang/cargo/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/cargo/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/cargo/tags","blobs_url":"https://api.github.com/repos/rust-lang/cargo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/cargo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/cargo/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/cargo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/cargo/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/cargo/languages","stargazers_url":"https://api.github.com/repos/rust-lang/cargo/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/cargo/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/cargo/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/cargo/subscription","commits_url":"https://api.github.com/repos/rust-lang/cargo/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/cargo/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/cargo/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/cargo/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang/cargo/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/cargo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/cargo/merges","archive_url":"https://api.github.com/repos/rust-lang/cargo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/cargo/downloads","issues_url":"https://api.github.com/repos/rust-lang/cargo/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/cargo/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/cargo/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/cargo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/cargo/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/cargo/releases{/id}","deployments_url":"https://api.github.com/repos/rust-lang/cargo/deployments","created_at":"2014-03-04T23:20:42Z","updated_at":"2016-05-24T02:13:14Z","pushed_at":"2016-05-24T20:03:39Z","git_url":"git://github.com/rust-lang/cargo.git","ssh_url":"git@github.com:rust-lang/cargo.git","clone_url":"https://github.com/rust-lang/cargo.git","svn_url":"https://github.com/rust-lang/cargo","homepage":"http://crates.io/","size":61092,"stargazers_count":1642,"watchers_count":1642,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":380,"mirror_url":null,"open_issues_count":297,"forks":380,"open_issues":297,"watchers":1642,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/cargo/pulls/2737"},"html":{"href":"https://github.com/rust-lang/cargo/pull/2737"},"issue":{"href":"https://api.github.com/repos/rust-lang/cargo/issues/2737"},"comments":{"href":"https://api.github.com/repos/rust-lang/cargo/issues/2737/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/cargo/pulls/2737/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/cargo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/cargo/pulls/2737/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/cargo/statuses/b691f1e4c5dd7449c3ab3cf1da3a061a2f3d5599"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"bors","id":3372342,"avatar_url":"https://avatars.githubusercontent.com/u/3372342?v=3","gravatar_id":"","url":"https://api.github.com/users/bors","html_url":"https://github.com/bors","followers_url":"https://api.github.com/users/bors/followers","following_url":"https://api.github.com/users/bors/following{/other_user}","gists_url":"https://api.github.com/users/bors/gists{/gist_id}","starred_url":"https://api.github.com/users/bors/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bors/subscriptions","organizations_url":"https://api.github.com/users/bors/orgs","repos_url":"https://api.github.com/users/bors/repos","events_url":"https://api.github.com/users/bors/events{/privacy}","received_events_url":"https://api.github.com/users/bors/received_events","type":"User","site_admin":false},"comments":5,"review_comments":0,"commits":1,"additions":5,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"bors"}}