{"action":"created","comment":{"url":"https://api.github.com/repos/addtea/dragonslave/pulls/comments/67461138","id":67461138,"diff_hunk":"@@ -0,0 +1,29 @@\n+#pragma once\n+\n+#include <map>\n+#include <vector>\n+#include \"event_listener.hpp\"\n+\n+namespace dragonslave {\n+\n+\n+class EventBase\n+{\n+};\n+\n+\n+class EventTarget","path":"inc/event_target.hpp","position":15,"original_position":15,"commit_id":"27460ce4ba171e63174567292f1514feb63d2e44","original_commit_id":"27460ce4ba171e63174567292f1514feb63d2e44","user":{"login":"eugeneyche","id":4590728,"avatar_url":"https://avatars.githubusercontent.com/u/4590728?v=3","gravatar_id":"","url":"https://api.github.com/users/eugeneyche","html_url":"https://github.com/eugeneyche","followers_url":"https://api.github.com/users/eugeneyche/followers","following_url":"https://api.github.com/users/eugeneyche/following{/other_user}","gists_url":"https://api.github.com/users/eugeneyche/gists{/gist_id}","starred_url":"https://api.github.com/users/eugeneyche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugeneyche/subscriptions","organizations_url":"https://api.github.com/users/eugeneyche/orgs","repos_url":"https://api.github.com/users/eugeneyche/repos","events_url":"https://api.github.com/users/eugeneyche/events{/privacy}","received_events_url":"https://api.github.com/users/eugeneyche/received_events","type":"User","site_admin":false},"body":"EventTarget should only emit a single type of event. I think it's safe to put the templating here.","created_at":"2016-06-17T05:06:59Z","updated_at":"2016-06-17T05:06:59Z","html_url":"https://github.com/addtea/dragonslave/pull/7#discussion_r67461138","pull_request_url":"https://api.github.com/repos/addtea/dragonslave/pulls/7","_links":{"self":{"href":"https://api.github.com/repos/addtea/dragonslave/pulls/comments/67461138"},"html":{"href":"https://github.com/addtea/dragonslave/pull/7#discussion_r67461138"},"pull_request":{"href":"https://api.github.com/repos/addtea/dragonslave/pulls/7"}}},"pull_request":{"url":"https://api.github.com/repos/addtea/dragonslave/pulls/7","id":74188984,"html_url":"https://github.com/addtea/dragonslave/pull/7","diff_url":"https://github.com/addtea/dragonslave/pull/7.diff","patch_url":"https://github.com/addtea/dragonslave/pull/7.patch","issue_url":"https://api.github.com/repos/addtea/dragonslave/issues/7","number":7,"state":"open","locked":false,"title":"EventTarget class","user":{"login":"jytang","id":5395665,"avatar_url":"https://avatars.githubusercontent.com/u/5395665?v=3","gravatar_id":"","url":"https://api.github.com/users/jytang","html_url":"https://github.com/jytang","followers_url":"https://api.github.com/users/jytang/followers","following_url":"https://api.github.com/users/jytang/following{/other_user}","gists_url":"https://api.github.com/users/jytang/gists{/gist_id}","starred_url":"https://api.github.com/users/jytang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jytang/subscriptions","organizations_url":"https://api.github.com/users/jytang/orgs","repos_url":"https://api.github.com/users/jytang/repos","events_url":"https://api.github.com/users/jytang/events{/privacy}","received_events_url":"https://api.github.com/users/jytang/received_events","type":"User","site_admin":false},"body":"Not sure how to set this up...``listeners`` cannot be a member template so I created some EventBase class. Really unfamiliar with templates haha. Help me Eugene.","created_at":"2016-06-17T04:57:55Z","updated_at":"2016-06-17T05:06:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b9d0696701e925d83c6c15e568dcc9522a6fd19e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/addtea/dragonslave/pulls/7/commits","review_comments_url":"https://api.github.com/repos/addtea/dragonslave/pulls/7/comments","review_comment_url":"https://api.github.com/repos/addtea/dragonslave/pulls/comments{/number}","comments_url":"https://api.github.com/repos/addtea/dragonslave/issues/7/comments","statuses_url":"https://api.github.com/repos/addtea/dragonslave/statuses/27460ce4ba171e63174567292f1514feb63d2e44","head":{"label":"addtea:event_target","ref":"event_target","sha":"27460ce4ba171e63174567292f1514feb63d2e44","user":{"login":"addtea","id":15083091,"avatar_url":"https://avatars.githubusercontent.com/u/15083091?v=3","gravatar_id":"","url":"https://api.github.com/users/addtea","html_url":"https://github.com/addtea","followers_url":"https://api.github.com/users/addtea/followers","following_url":"https://api.github.com/users/addtea/following{/other_user}","gists_url":"https://api.github.com/users/addtea/gists{/gist_id}","starred_url":"https://api.github.com/users/addtea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/addtea/subscriptions","organizations_url":"https://api.github.com/users/addtea/orgs","repos_url":"https://api.github.com/users/addtea/repos","events_url":"https://api.github.com/users/addtea/events{/privacy}","received_events_url":"https://api.github.com/users/addtea/received_events","type":"User","site_admin":false},"repo":{"id":61250546,"name":"dragonslave","full_name":"addtea/dragonslave","owner":{"login":"addtea","id":15083091,"avatar_url":"https://avatars.githubusercontent.com/u/15083091?v=3","gravatar_id":"","url":"https://api.github.com/users/addtea","html_url":"https://github.com/addtea","followers_url":"https://api.github.com/users/addtea/followers","following_url":"https://api.github.com/users/addtea/following{/other_user}","gists_url":"https://api.github.com/users/addtea/gists{/gist_id}","starred_url":"https://api.github.com/users/addtea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/addtea/subscriptions","organizations_url":"https://api.github.com/users/addtea/orgs","repos_url":"https://api.github.com/users/addtea/repos","events_url":"https://api.github.com/users/addtea/events{/privacy}","received_events_url":"https://api.github.com/users/addtea/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/addtea/dragonslave","description":"lina!!!","fork":false,"url":"https://api.github.com/repos/addtea/dragonslave","forks_url":"https://api.github.com/repos/addtea/dragonslave/forks","keys_url":"https://api.github.com/repos/addtea/dragonslave/keys{/key_id}","collaborators_url":"https://api.github.com/repos/addtea/dragonslave/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/addtea/dragonslave/teams","hooks_url":"https://api.github.com/repos/addtea/dragonslave/hooks","issue_events_url":"https://api.github.com/repos/addtea/dragonslave/issues/events{/number}","events_url":"https://api.github.com/repos/addtea/dragonslave/events","assignees_url":"https://api.github.com/repos/addtea/dragonslave/assignees{/user}","branches_url":"https://api.github.com/repos/addtea/dragonslave/branches{/branch}","tags_url":"https://api.github.com/repos/addtea/dragonslave/tags","blobs_url":"https://api.github.com/repos/addtea/dragonslave/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/addtea/dragonslave/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/addtea/dragonslave/git/refs{/sha}","trees_url":"https://api.github.com/repos/addtea/dragonslave/git/trees{/sha}","statuses_url":"https://api.github.com/repos/addtea/dragonslave/statuses/{sha}","languages_url":"https://api.github.com/repos/addtea/dragonslave/languages","stargazers_url":"https://api.github.com/repos/addtea/dragonslave/stargazers","contributors_url":"https://api.github.com/repos/addtea/dragonslave/contributors","subscribers_url":"https://api.github.com/repos/addtea/dragonslave/subscribers","subscription_url":"https://api.github.com/repos/addtea/dragonslave/subscription","commits_url":"https://api.github.com/repos/addtea/dragonslave/commits{/sha}","git_commits_url":"https://api.github.com/repos/addtea/dragonslave/git/commits{/sha}","comments_url":"https://api.github.com/repos/addtea/dragonslave/comments{/number}","issue_comment_url":"https://api.github.com/repos/addtea/dragonslave/issues/comments{/number}","contents_url":"https://api.github.com/repos/addtea/dragonslave/contents/{+path}","compare_url":"https://api.github.com/repos/addtea/dragonslave/compare/{base}...{head}","merges_url":"https://api.github.com/repos/addtea/dragonslave/merges","archive_url":"https://api.github.com/repos/addtea/dragonslave/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/addtea/dragonslave/downloads","issues_url":"https://api.github.com/repos/addtea/dragonslave/issues{/number}","pulls_url":"https://api.github.com/repos/addtea/dragonslave/pulls{/number}","milestones_url":"https://api.github.com/repos/addtea/dragonslave/milestones{/number}","notifications_url":"https://api.github.com/repos/addtea/dragonslave/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/addtea/dragonslave/labels{/name}","releases_url":"https://api.github.com/repos/addtea/dragonslave/releases{/id}","deployments_url":"https://api.github.com/repos/addtea/dragonslave/deployments","created_at":"2016-06-16T00:44:50Z","updated_at":"2016-06-16T05:09:02Z","pushed_at":"2016-06-17T05:05:15Z","git_url":"git://github.com/addtea/dragonslave.git","ssh_url":"git@github.com:addtea/dragonslave.git","clone_url":"https://github.com/addtea/dragonslave.git","svn_url":"https://github.com/addtea/dragonslave","homepage":null,"size":15,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":0,"default_branch":"master"}},"base":{"label":"addtea:master","ref":"master","sha":"2cb65f2467e25e9c14408f31059403e5beb80706","user":{"login":"addtea","id":15083091,"avatar_url":"https://avatars.githubusercontent.com/u/15083091?v=3","gravatar_id":"","url":"https://api.github.com/users/addtea","html_url":"https://github.com/addtea","followers_url":"https://api.github.com/users/addtea/followers","following_url":"https://api.github.com/users/addtea/following{/other_user}","gists_url":"https://api.github.com/users/addtea/gists{/gist_id}","starred_url":"https://api.github.com/users/addtea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/addtea/subscriptions","organizations_url":"https://api.github.com/users/addtea/orgs","repos_url":"https://api.github.com/users/addtea/repos","events_url":"https://api.github.com/users/addtea/events{/privacy}","received_events_url":"https://api.github.com/users/addtea/received_events","type":"User","site_admin":false},"repo":{"id":61250546,"name":"dragonslave","full_name":"addtea/dragonslave","owner":{"login":"addtea","id":15083091,"avatar_url":"https://avatars.githubusercontent.com/u/15083091?v=3","gravatar_id":"","url":"https://api.github.com/users/addtea","html_url":"https://github.com/addtea","followers_url":"https://api.github.com/users/addtea/followers","following_url":"https://api.github.com/users/addtea/following{/other_user}","gists_url":"https://api.github.com/users/addtea/gists{/gist_id}","starred_url":"https://api.github.com/users/addtea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/addtea/subscriptions","organizations_url":"https://api.github.com/users/addtea/orgs","repos_url":"https://api.github.com/users/addtea/repos","events_url":"https://api.github.com/users/addtea/events{/privacy}","received_events_url":"https://api.github.com/users/addtea/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/addtea/dragonslave","description":"lina!!!","fork":false,"url":"https://api.github.com/repos/addtea/dragonslave","forks_url":"https://api.github.com/repos/addtea/dragonslave/forks","keys_url":"https://api.github.com/repos/addtea/dragonslave/keys{/key_id}","collaborators_url":"https://api.github.com/repos/addtea/dragonslave/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/addtea/dragonslave/teams","hooks_url":"https://api.github.com/repos/addtea/dragonslave/hooks","issue_events_url":"https://api.github.com/repos/addtea/dragonslave/issues/events{/number}","events_url":"https://api.github.com/repos/addtea/dragonslave/events","assignees_url":"https://api.github.com/repos/addtea/dragonslave/assignees{/user}","branches_url":"https://api.github.com/repos/addtea/dragonslave/branches{/branch}","tags_url":"https://api.github.com/repos/addtea/dragonslave/tags","blobs_url":"https://api.github.com/repos/addtea/dragonslave/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/addtea/dragonslave/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/addtea/dragonslave/git/refs{/sha}","trees_url":"https://api.github.com/repos/addtea/dragonslave/git/trees{/sha}","statuses_url":"https://api.github.com/repos/addtea/dragonslave/statuses/{sha}","languages_url":"https://api.github.com/repos/addtea/dragonslave/languages","stargazers_url":"https://api.github.com/repos/addtea/dragonslave/stargazers","contributors_url":"https://api.github.com/repos/addtea/dragonslave/contributors","subscribers_url":"https://api.github.com/repos/addtea/dragonslave/subscribers","subscription_url":"https://api.github.com/repos/addtea/dragonslave/subscription","commits_url":"https://api.github.com/repos/addtea/dragonslave/commits{/sha}","git_commits_url":"https://api.github.com/repos/addtea/dragonslave/git/commits{/sha}","comments_url":"https://api.github.com/repos/addtea/dragonslave/comments{/number}","issue_comment_url":"https://api.github.com/repos/addtea/dragonslave/issues/comments{/number}","contents_url":"https://api.github.com/repos/addtea/dragonslave/contents/{+path}","compare_url":"https://api.github.com/repos/addtea/dragonslave/compare/{base}...{head}","merges_url":"https://api.github.com/repos/addtea/dragonslave/merges","archive_url":"https://api.github.com/repos/addtea/dragonslave/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/addtea/dragonslave/downloads","issues_url":"https://api.github.com/repos/addtea/dragonslave/issues{/number}","pulls_url":"https://api.github.com/repos/addtea/dragonslave/pulls{/number}","milestones_url":"https://api.github.com/repos/addtea/dragonslave/milestones{/number}","notifications_url":"https://api.github.com/repos/addtea/dragonslave/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/addtea/dragonslave/labels{/name}","releases_url":"https://api.github.com/repos/addtea/dragonslave/releases{/id}","deployments_url":"https://api.github.com/repos/addtea/dragonslave/deployments","created_at":"2016-06-16T00:44:50Z","updated_at":"2016-06-16T05:09:02Z","pushed_at":"2016-06-17T05:05:15Z","git_url":"git://github.com/addtea/dragonslave.git","ssh_url":"git@github.com:addtea/dragonslave.git","clone_url":"https://github.com/addtea/dragonslave.git","svn_url":"https://github.com/addtea/dragonslave","homepage":null,"size":15,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/addtea/dragonslave/pulls/7"},"html":{"href":"https://github.com/addtea/dragonslave/pull/7"},"issue":{"href":"https://api.github.com/repos/addtea/dragonslave/issues/7"},"comments":{"href":"https://api.github.com/repos/addtea/dragonslave/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/addtea/dragonslave/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/addtea/dragonslave/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/addtea/dragonslave/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/addtea/dragonslave/statuses/27460ce4ba171e63174567292f1514feb63d2e44"}}}}
{"actor":{"display_login":"eugeneyche"}}