{"action":"created","comment":{"url":"https://api.github.com/repos/prestodb/presto/pulls/comments/60831893","id":60831893,"diff_hunk":"@@ -1108,30 +1068,31 @@ public void createView(ConnectorSession session, SchemaTableName viewName, Strin\n                 .put(PRESTO_VIEW_FLAG, \"true\")\n                 .build();\n \n-        FieldSchema dummyColumn = new FieldSchema(\"dummy\", STRING_TYPE_NAME, null);\n-\n-        StorageDescriptor sd = new StorageDescriptor();\n-        sd.setCols(ImmutableList.of(dummyColumn));\n-        sd.setSerdeInfo(new SerDeInfo());\n-\n-        Table table = new Table();\n-        table.setDbName(viewName.getSchemaName());\n-        table.setTableName(viewName.getTableName());\n-        table.setOwner(session.getUser());\n-        table.setTableType(TableType.VIRTUAL_VIEW.name());\n-        table.setParameters(properties);\n-        table.setViewOriginalText(encodeViewData(viewData));\n-        table.setViewExpandedText(\"/* Presto View */\");\n-        table.setSd(sd);\n-\n+        FieldSchema dummyColumn = new FieldSchema(\"dummy\", HIVE_STRING, Optional.empty());\n         PrivilegeGrantInfo allPrivileges = new PrivilegeGrantInfo(\"all\", 0, session.getUser(), PrincipalType.USER, true);\n-        table.setPrivileges(new PrincipalPrivilegeSet(\n+\n+        Table.Builder tableBuilder = new Table.Builder()","path":"presto-hive/src/main/java/com/facebook/presto/hive/HiveMetadata.java","position":389,"original_position":389,"commit_id":"8d1c18c40175943800dde7777e60241077c40d1f","original_commit_id":"8d1c18c40175943800dde7777e60241077c40d1f","user":{"login":"dain","id":58298,"avatar_url":"https://avatars.githubusercontent.com/u/58298?v=3","gravatar_id":"","url":"https://api.github.com/users/dain","html_url":"https://github.com/dain","followers_url":"https://api.github.com/users/dain/followers","following_url":"https://api.github.com/users/dain/following{/other_user}","gists_url":"https://api.github.com/users/dain/gists{/gist_id}","starred_url":"https://api.github.com/users/dain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dain/subscriptions","organizations_url":"https://api.github.com/users/dain/orgs","repos_url":"https://api.github.com/users/dain/repos","events_url":"https://api.github.com/users/dain/events{/privacy}","received_events_url":"https://api.github.com/users/dain/received_events","type":"User","site_admin":false},"body":"I prefer builders to have a static `builder()` method instead of a public constructor","created_at":"2016-04-23T17:30:55Z","updated_at":"2016-04-23T17:30:55Z","html_url":"https://github.com/prestodb/presto/pull/4878#discussion_r60831893","pull_request_url":"https://api.github.com/repos/prestodb/presto/pulls/4878","_links":{"self":{"href":"https://api.github.com/repos/prestodb/presto/pulls/comments/60831893"},"html":{"href":"https://github.com/prestodb/presto/pull/4878#discussion_r60831893"},"pull_request":{"href":"https://api.github.com/repos/prestodb/presto/pulls/4878"}}},"pull_request":{"url":"https://api.github.com/repos/prestodb/presto/pulls/4878","id":64187605,"html_url":"https://github.com/prestodb/presto/pull/4878","diff_url":"https://github.com/prestodb/presto/pull/4878.diff","patch_url":"https://github.com/prestodb/presto/pull/4878.patch","issue_url":"https://api.github.com/repos/prestodb/presto/issues/4878","number":4878,"state":"open","locked":false,"title":"Use new classes to represent Hive metastore entities","user":{"login":"haozhun","id":2020503,"avatar_url":"https://avatars.githubusercontent.com/u/2020503?v=3","gravatar_id":"","url":"https://api.github.com/users/haozhun","html_url":"https://github.com/haozhun","followers_url":"https://api.github.com/users/haozhun/followers","following_url":"https://api.github.com/users/haozhun/following{/other_user}","gists_url":"https://api.github.com/users/haozhun/gists{/gist_id}","starred_url":"https://api.github.com/users/haozhun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haozhun/subscriptions","organizations_url":"https://api.github.com/users/haozhun/orgs","repos_url":"https://api.github.com/users/haozhun/repos","events_url":"https://api.github.com/users/haozhun/events{/privacy}","received_events_url":"https://api.github.com/users/haozhun/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-03-25T17:47:44Z","updated_at":"2016-04-23T17:30:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d2f808aeabbecebab2df968fc0dd7e1c8847e896","assignee":{"login":"electrum","id":9230,"avatar_url":"https://avatars.githubusercontent.com/u/9230?v=3","gravatar_id":"","url":"https://api.github.com/users/electrum","html_url":"https://github.com/electrum","followers_url":"https://api.github.com/users/electrum/followers","following_url":"https://api.github.com/users/electrum/following{/other_user}","gists_url":"https://api.github.com/users/electrum/gists{/gist_id}","starred_url":"https://api.github.com/users/electrum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electrum/subscriptions","organizations_url":"https://api.github.com/users/electrum/orgs","repos_url":"https://api.github.com/users/electrum/repos","events_url":"https://api.github.com/users/electrum/events{/privacy}","received_events_url":"https://api.github.com/users/electrum/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/prestodb/presto/pulls/4878/commits","review_comments_url":"https://api.github.com/repos/prestodb/presto/pulls/4878/comments","review_comment_url":"https://api.github.com/repos/prestodb/presto/pulls/comments{/number}","comments_url":"https://api.github.com/repos/prestodb/presto/issues/4878/comments","statuses_url":"https://api.github.com/repos/prestodb/presto/statuses/8d1c18c40175943800dde7777e60241077c40d1f","head":{"label":"haozhun:metastore","ref":"metastore","sha":"8d1c18c40175943800dde7777e60241077c40d1f","user":{"login":"haozhun","id":2020503,"avatar_url":"https://avatars.githubusercontent.com/u/2020503?v=3","gravatar_id":"","url":"https://api.github.com/users/haozhun","html_url":"https://github.com/haozhun","followers_url":"https://api.github.com/users/haozhun/followers","following_url":"https://api.github.com/users/haozhun/following{/other_user}","gists_url":"https://api.github.com/users/haozhun/gists{/gist_id}","starred_url":"https://api.github.com/users/haozhun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haozhun/subscriptions","organizations_url":"https://api.github.com/users/haozhun/orgs","repos_url":"https://api.github.com/users/haozhun/repos","events_url":"https://api.github.com/users/haozhun/events{/privacy}","received_events_url":"https://api.github.com/users/haozhun/received_events","type":"User","site_admin":false},"repo":{"id":31032158,"name":"presto","full_name":"haozhun/presto","owner":{"login":"haozhun","id":2020503,"avatar_url":"https://avatars.githubusercontent.com/u/2020503?v=3","gravatar_id":"","url":"https://api.github.com/users/haozhun","html_url":"https://github.com/haozhun","followers_url":"https://api.github.com/users/haozhun/followers","following_url":"https://api.github.com/users/haozhun/following{/other_user}","gists_url":"https://api.github.com/users/haozhun/gists{/gist_id}","starred_url":"https://api.github.com/users/haozhun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haozhun/subscriptions","organizations_url":"https://api.github.com/users/haozhun/orgs","repos_url":"https://api.github.com/users/haozhun/repos","events_url":"https://api.github.com/users/haozhun/events{/privacy}","received_events_url":"https://api.github.com/users/haozhun/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/haozhun/presto","description":"Distributed SQL query engine for running interactive analytic queries against big data sources.","fork":true,"url":"https://api.github.com/repos/haozhun/presto","forks_url":"https://api.github.com/repos/haozhun/presto/forks","keys_url":"https://api.github.com/repos/haozhun/presto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/haozhun/presto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/haozhun/presto/teams","hooks_url":"https://api.github.com/repos/haozhun/presto/hooks","issue_events_url":"https://api.github.com/repos/haozhun/presto/issues/events{/number}","events_url":"https://api.github.com/repos/haozhun/presto/events","assignees_url":"https://api.github.com/repos/haozhun/presto/assignees{/user}","branches_url":"https://api.github.com/repos/haozhun/presto/branches{/branch}","tags_url":"https://api.github.com/repos/haozhun/presto/tags","blobs_url":"https://api.github.com/repos/haozhun/presto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/haozhun/presto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/haozhun/presto/git/refs{/sha}","trees_url":"https://api.github.com/repos/haozhun/presto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/haozhun/presto/statuses/{sha}","languages_url":"https://api.github.com/repos/haozhun/presto/languages","stargazers_url":"https://api.github.com/repos/haozhun/presto/stargazers","contributors_url":"https://api.github.com/repos/haozhun/presto/contributors","subscribers_url":"https://api.github.com/repos/haozhun/presto/subscribers","subscription_url":"https://api.github.com/repos/haozhun/presto/subscription","commits_url":"https://api.github.com/repos/haozhun/presto/commits{/sha}","git_commits_url":"https://api.github.com/repos/haozhun/presto/git/commits{/sha}","comments_url":"https://api.github.com/repos/haozhun/presto/comments{/number}","issue_comment_url":"https://api.github.com/repos/haozhun/presto/issues/comments{/number}","contents_url":"https://api.github.com/repos/haozhun/presto/contents/{+path}","compare_url":"https://api.github.com/repos/haozhun/presto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/haozhun/presto/merges","archive_url":"https://api.github.com/repos/haozhun/presto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/haozhun/presto/downloads","issues_url":"https://api.github.com/repos/haozhun/presto/issues{/number}","pulls_url":"https://api.github.com/repos/haozhun/presto/pulls{/number}","milestones_url":"https://api.github.com/repos/haozhun/presto/milestones{/number}","notifications_url":"https://api.github.com/repos/haozhun/presto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/haozhun/presto/labels{/name}","releases_url":"https://api.github.com/repos/haozhun/presto/releases{/id}","deployments_url":"https://api.github.com/repos/haozhun/presto/deployments","created_at":"2015-02-19T19:19:31Z","updated_at":"2016-03-18T00:24:46Z","pushed_at":"2016-04-21T01:29:43Z","git_url":"git://github.com/haozhun/presto.git","ssh_url":"git@github.com:haozhun/presto.git","clone_url":"https://github.com/haozhun/presto.git","svn_url":"https://github.com/haozhun/presto","homepage":"https://prestodb.io","size":52724,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"prestodb:master","ref":"master","sha":"1cdb276eccf6e40bda70153d2ccd65aa5aacfe7a","user":{"login":"prestodb","id":6882181,"avatar_url":"https://avatars.githubusercontent.com/u/6882181?v=3","gravatar_id":"","url":"https://api.github.com/users/prestodb","html_url":"https://github.com/prestodb","followers_url":"https://api.github.com/users/prestodb/followers","following_url":"https://api.github.com/users/prestodb/following{/other_user}","gists_url":"https://api.github.com/users/prestodb/gists{/gist_id}","starred_url":"https://api.github.com/users/prestodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prestodb/subscriptions","organizations_url":"https://api.github.com/users/prestodb/orgs","repos_url":"https://api.github.com/users/prestodb/repos","events_url":"https://api.github.com/users/prestodb/events{/privacy}","received_events_url":"https://api.github.com/users/prestodb/received_events","type":"Organization","site_admin":false},"repo":{"id":5349565,"name":"presto","full_name":"prestodb/presto","owner":{"login":"prestodb","id":6882181,"avatar_url":"https://avatars.githubusercontent.com/u/6882181?v=3","gravatar_id":"","url":"https://api.github.com/users/prestodb","html_url":"https://github.com/prestodb","followers_url":"https://api.github.com/users/prestodb/followers","following_url":"https://api.github.com/users/prestodb/following{/other_user}","gists_url":"https://api.github.com/users/prestodb/gists{/gist_id}","starred_url":"https://api.github.com/users/prestodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prestodb/subscriptions","organizations_url":"https://api.github.com/users/prestodb/orgs","repos_url":"https://api.github.com/users/prestodb/repos","events_url":"https://api.github.com/users/prestodb/events{/privacy}","received_events_url":"https://api.github.com/users/prestodb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/prestodb/presto","description":"Distributed SQL query engine for big data","fork":false,"url":"https://api.github.com/repos/prestodb/presto","forks_url":"https://api.github.com/repos/prestodb/presto/forks","keys_url":"https://api.github.com/repos/prestodb/presto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prestodb/presto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prestodb/presto/teams","hooks_url":"https://api.github.com/repos/prestodb/presto/hooks","issue_events_url":"https://api.github.com/repos/prestodb/presto/issues/events{/number}","events_url":"https://api.github.com/repos/prestodb/presto/events","assignees_url":"https://api.github.com/repos/prestodb/presto/assignees{/user}","branches_url":"https://api.github.com/repos/prestodb/presto/branches{/branch}","tags_url":"https://api.github.com/repos/prestodb/presto/tags","blobs_url":"https://api.github.com/repos/prestodb/presto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prestodb/presto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prestodb/presto/git/refs{/sha}","trees_url":"https://api.github.com/repos/prestodb/presto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prestodb/presto/statuses/{sha}","languages_url":"https://api.github.com/repos/prestodb/presto/languages","stargazers_url":"https://api.github.com/repos/prestodb/presto/stargazers","contributors_url":"https://api.github.com/repos/prestodb/presto/contributors","subscribers_url":"https://api.github.com/repos/prestodb/presto/subscribers","subscription_url":"https://api.github.com/repos/prestodb/presto/subscription","commits_url":"https://api.github.com/repos/prestodb/presto/commits{/sha}","git_commits_url":"https://api.github.com/repos/prestodb/presto/git/commits{/sha}","comments_url":"https://api.github.com/repos/prestodb/presto/comments{/number}","issue_comment_url":"https://api.github.com/repos/prestodb/presto/issues/comments{/number}","contents_url":"https://api.github.com/repos/prestodb/presto/contents/{+path}","compare_url":"https://api.github.com/repos/prestodb/presto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prestodb/presto/merges","archive_url":"https://api.github.com/repos/prestodb/presto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prestodb/presto/downloads","issues_url":"https://api.github.com/repos/prestodb/presto/issues{/number}","pulls_url":"https://api.github.com/repos/prestodb/presto/pulls{/number}","milestones_url":"https://api.github.com/repos/prestodb/presto/milestones{/number}","notifications_url":"https://api.github.com/repos/prestodb/presto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prestodb/presto/labels{/name}","releases_url":"https://api.github.com/repos/prestodb/presto/releases{/id}","deployments_url":"https://api.github.com/repos/prestodb/presto/deployments","created_at":"2012-08-09T01:03:37Z","updated_at":"2016-04-23T15:35:52Z","pushed_at":"2016-04-23T17:24:14Z","git_url":"git://github.com/prestodb/presto.git","ssh_url":"git@github.com:prestodb/presto.git","clone_url":"https://github.com/prestodb/presto.git","svn_url":"https://github.com/prestodb/presto","homepage":"https://prestodb.io","size":148666,"stargazers_count":4686,"watchers_count":4686,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1357,"mirror_url":null,"open_issues_count":560,"forks":1357,"open_issues":560,"watchers":4686,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/prestodb/presto/pulls/4878"},"html":{"href":"https://github.com/prestodb/presto/pull/4878"},"issue":{"href":"https://api.github.com/repos/prestodb/presto/issues/4878"},"comments":{"href":"https://api.github.com/repos/prestodb/presto/issues/4878/comments"},"review_comments":{"href":"https://api.github.com/repos/prestodb/presto/pulls/4878/comments"},"review_comment":{"href":"https://api.github.com/repos/prestodb/presto/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/prestodb/presto/pulls/4878/commits"},"statuses":{"href":"https://api.github.com/repos/prestodb/presto/statuses/8d1c18c40175943800dde7777e60241077c40d1f"}}}}