{"action":"created","comment":{"url":"https://api.github.com/repos/cBioPortal/cbioportal/pulls/comments/71717035","id":71717035,"diff_hunk":"@@ -212,6 +127,13 @@\n     <maven.build.timestamp.format>yyyyMMdd-HHmm</maven.build.timestamp.format>\n     <jacoco-maven-plugin.version>0.7.6.201602180812</jacoco-maven-plugin.version>\n     <mockito.version>1.10.19</mockito.version>\n+    \n+    <final.war.name>cbioportal-${project.version}</final.war.name>\n+\n+\t<db.test.driver>com.mysql.jdbc.Driver</db.test.driver>\n+\t<db.test.url>jdbc:mysql://127.0.0.1:3306/cgds_test</db.test.url>\n+    <db.test.username>cbioportal</db.test.username>\n+    <db.test.password>cbioportal</db.test.password>","path":"pom.xml","position":108,"original_position":108,"commit_id":"bc9dcb8fb25051300cb5af6f53f9831091dd26e8","original_commit_id":"bc9dcb8fb25051300cb5af6f53f9831091dd26e8","user":{"login":"morungos","id":442090,"avatar_url":"https://avatars.githubusercontent.com/u/442090?v=3","gravatar_id":"","url":"https://api.github.com/users/morungos","html_url":"https://github.com/morungos","followers_url":"https://api.github.com/users/morungos/followers","following_url":"https://api.github.com/users/morungos/following{/other_user}","gists_url":"https://api.github.com/users/morungos/gists{/gist_id}","starred_url":"https://api.github.com/users/morungos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/morungos/subscriptions","organizations_url":"https://api.github.com/users/morungos/orgs","repos_url":"https://api.github.com/users/morungos/repos","events_url":"https://api.github.com/users/morungos/events{/privacy}","received_events_url":"https://api.github.com/users/morungos/received_events","type":"User","site_admin":false},"body":"Excellent, I'll modify. This just makes it that much easier for others to change and override. ","created_at":"2016-07-21T14:35:25Z","updated_at":"2016-07-21T14:35:25Z","html_url":"https://github.com/cBioPortal/cbioportal/pull/1517#discussion_r71717035","pull_request_url":"https://api.github.com/repos/cBioPortal/cbioportal/pulls/1517","_links":{"self":{"href":"https://api.github.com/repos/cBioPortal/cbioportal/pulls/comments/71717035"},"html":{"href":"https://github.com/cBioPortal/cbioportal/pull/1517#discussion_r71717035"},"pull_request":{"href":"https://api.github.com/repos/cBioPortal/cbioportal/pulls/1517"}}},"pull_request":{"url":"https://api.github.com/repos/cBioPortal/cbioportal/pulls/1517","id":78197676,"html_url":"https://github.com/cBioPortal/cbioportal/pull/1517","diff_url":"https://github.com/cBioPortal/cbioportal/pull/1517.diff","patch_url":"https://github.com/cBioPortal/cbioportal/pull/1517.patch","issue_url":"https://api.github.com/repos/cBioPortal/cbioportal/issues/1517","number":1517,"state":"open","locked":false,"title":"Debloating lite","user":{"login":"morungos","id":442090,"avatar_url":"https://avatars.githubusercontent.com/u/442090?v=3","gravatar_id":"","url":"https://api.github.com/users/morungos","html_url":"https://github.com/morungos","followers_url":"https://api.github.com/users/morungos/followers","following_url":"https://api.github.com/users/morungos/following{/other_user}","gists_url":"https://api.github.com/users/morungos/gists{/gist_id}","starred_url":"https://api.github.com/users/morungos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/morungos/subscriptions","organizations_url":"https://api.github.com/users/morungos/orgs","repos_url":"https://api.github.com/users/morungos/repos","events_url":"https://api.github.com/users/morungos/events{/privacy}","received_events_url":"https://api.github.com/users/morungos/received_events","type":"User","site_admin":false},"body":"# What? Why?\r\nFix #948 and #1508.\r\n\r\nChanges proposed in this pull request:\r\n- Add a new scripts component which is shaded and contains a runnable core\r\n- Removed shading from core and business\r\n- Changed the output war name to include a version\r\n- Resolved the SLF4J duplications\r\n\r\n# Checks\r\n- [ ] Runs on Heroku.\r\n- [x] Single commit and [No merge commits](http://nathanleclaire.com/blog/2014/09/14/dont-be-scared-of-git-rebase/)\r\n- [ ] Make sure your commit messages end with a Signed-off-by string (this line\r\n  can be automatically added by git if you run the `git-commit` command with\r\n  the `-s` option)\r\n- [ ] If this is a feature, the PR is to rc. If this is a bug fix, the PR is to\r\n  hotfix.\r\n\r\n# Any screenshots or GIFs?\r\nIf this is a new visual feature please add a before/after screenshot or gif\r\nhere with e.g. [GifGrabber](http://www.gifgrabber.com/).\r\n\r\n# Notify reviewers\r\nIf your pull request involves changes to an existing file, one or more of the\r\npeople that edited before you might be good candidates to review it. Please use\r\n`git blame <filename>` to determine that and notify them here. Otherwise notify\r\neverybody in the core team:\r\n@cBioPortal/core-developers\r\n","created_at":"2016-07-20T18:40:19Z","updated_at":"2016-07-21T14:35:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b3150eeaae7ff8a25608b6c034399db639ba5620","assignee":{"login":"morungos","id":442090,"avatar_url":"https://avatars.githubusercontent.com/u/442090?v=3","gravatar_id":"","url":"https://api.github.com/users/morungos","html_url":"https://github.com/morungos","followers_url":"https://api.github.com/users/morungos/followers","following_url":"https://api.github.com/users/morungos/following{/other_user}","gists_url":"https://api.github.com/users/morungos/gists{/gist_id}","starred_url":"https://api.github.com/users/morungos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/morungos/subscriptions","organizations_url":"https://api.github.com/users/morungos/orgs","repos_url":"https://api.github.com/users/morungos/repos","events_url":"https://api.github.com/users/morungos/events{/privacy}","received_events_url":"https://api.github.com/users/morungos/received_events","type":"User","site_admin":false},"assignees":[{"login":"morungos","id":442090,"avatar_url":"https://avatars.githubusercontent.com/u/442090?v=3","gravatar_id":"","url":"https://api.github.com/users/morungos","html_url":"https://github.com/morungos","followers_url":"https://api.github.com/users/morungos/followers","following_url":"https://api.github.com/users/morungos/following{/other_user}","gists_url":"https://api.github.com/users/morungos/gists{/gist_id}","starred_url":"https://api.github.com/users/morungos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/morungos/subscriptions","organizations_url":"https://api.github.com/users/morungos/orgs","repos_url":"https://api.github.com/users/morungos/repos","events_url":"https://api.github.com/users/morungos/events{/privacy}","received_events_url":"https://api.github.com/users/morungos/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/cBioPortal/cbioportal/pulls/1517/commits","review_comments_url":"https://api.github.com/repos/cBioPortal/cbioportal/pulls/1517/comments","review_comment_url":"https://api.github.com/repos/cBioPortal/cbioportal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cBioPortal/cbioportal/issues/1517/comments","statuses_url":"https://api.github.com/repos/cBioPortal/cbioportal/statuses/bc9dcb8fb25051300cb5af6f53f9831091dd26e8","head":{"label":"pughlab:debloating-lite","ref":"debloating-lite","sha":"bc9dcb8fb25051300cb5af6f53f9831091dd26e8","user":{"login":"pughlab","id":11860818,"avatar_url":"https://avatars.githubusercontent.com/u/11860818?v=3","gravatar_id":"","url":"https://api.github.com/users/pughlab","html_url":"https://github.com/pughlab","followers_url":"https://api.github.com/users/pughlab/followers","following_url":"https://api.github.com/users/pughlab/following{/other_user}","gists_url":"https://api.github.com/users/pughlab/gists{/gist_id}","starred_url":"https://api.github.com/users/pughlab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pughlab/subscriptions","organizations_url":"https://api.github.com/users/pughlab/orgs","repos_url":"https://api.github.com/users/pughlab/repos","events_url":"https://api.github.com/users/pughlab/events{/privacy}","received_events_url":"https://api.github.com/users/pughlab/received_events","type":"Organization","site_admin":false},"repo":{"id":54500676,"name":"cbioportal","full_name":"pughlab/cbioportal","owner":{"login":"pughlab","id":11860818,"avatar_url":"https://avatars.githubusercontent.com/u/11860818?v=3","gravatar_id":"","url":"https://api.github.com/users/pughlab","html_url":"https://github.com/pughlab","followers_url":"https://api.github.com/users/pughlab/followers","following_url":"https://api.github.com/users/pughlab/following{/other_user}","gists_url":"https://api.github.com/users/pughlab/gists{/gist_id}","starred_url":"https://api.github.com/users/pughlab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pughlab/subscriptions","organizations_url":"https://api.github.com/users/pughlab/orgs","repos_url":"https://api.github.com/users/pughlab/repos","events_url":"https://api.github.com/users/pughlab/events{/privacy}","received_events_url":"https://api.github.com/users/pughlab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pughlab/cbioportal","description":"","fork":true,"url":"https://api.github.com/repos/pughlab/cbioportal","forks_url":"https://api.github.com/repos/pughlab/cbioportal/forks","keys_url":"https://api.github.com/repos/pughlab/cbioportal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pughlab/cbioportal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pughlab/cbioportal/teams","hooks_url":"https://api.github.com/repos/pughlab/cbioportal/hooks","issue_events_url":"https://api.github.com/repos/pughlab/cbioportal/issues/events{/number}","events_url":"https://api.github.com/repos/pughlab/cbioportal/events","assignees_url":"https://api.github.com/repos/pughlab/cbioportal/assignees{/user}","branches_url":"https://api.github.com/repos/pughlab/cbioportal/branches{/branch}","tags_url":"https://api.github.com/repos/pughlab/cbioportal/tags","blobs_url":"https://api.github.com/repos/pughlab/cbioportal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pughlab/cbioportal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pughlab/cbioportal/git/refs{/sha}","trees_url":"https://api.github.com/repos/pughlab/cbioportal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pughlab/cbioportal/statuses/{sha}","languages_url":"https://api.github.com/repos/pughlab/cbioportal/languages","stargazers_url":"https://api.github.com/repos/pughlab/cbioportal/stargazers","contributors_url":"https://api.github.com/repos/pughlab/cbioportal/contributors","subscribers_url":"https://api.github.com/repos/pughlab/cbioportal/subscribers","subscription_url":"https://api.github.com/repos/pughlab/cbioportal/subscription","commits_url":"https://api.github.com/repos/pughlab/cbioportal/commits{/sha}","git_commits_url":"https://api.github.com/repos/pughlab/cbioportal/git/commits{/sha}","comments_url":"https://api.github.com/repos/pughlab/cbioportal/comments{/number}","issue_comment_url":"https://api.github.com/repos/pughlab/cbioportal/issues/comments{/number}","contents_url":"https://api.github.com/repos/pughlab/cbioportal/contents/{+path}","compare_url":"https://api.github.com/repos/pughlab/cbioportal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pughlab/cbioportal/merges","archive_url":"https://api.github.com/repos/pughlab/cbioportal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pughlab/cbioportal/downloads","issues_url":"https://api.github.com/repos/pughlab/cbioportal/issues{/number}","pulls_url":"https://api.github.com/repos/pughlab/cbioportal/pulls{/number}","milestones_url":"https://api.github.com/repos/pughlab/cbioportal/milestones{/number}","notifications_url":"https://api.github.com/repos/pughlab/cbioportal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pughlab/cbioportal/labels{/name}","releases_url":"https://api.github.com/repos/pughlab/cbioportal/releases{/id}","deployments_url":"https://api.github.com/repos/pughlab/cbioportal/deployments","created_at":"2016-03-22T18:52:10Z","updated_at":"2016-06-21T20:50:21Z","pushed_at":"2016-07-20T18:39:44Z","git_url":"git://github.com/pughlab/cbioportal.git","ssh_url":"git@github.com:pughlab/cbioportal.git","clone_url":"https://github.com/pughlab/cbioportal.git","svn_url":"https://github.com/pughlab/cbioportal","homepage":null,"size":168482,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"branded-uhn-deployment"}},"base":{"label":"cBioPortal:rc","ref":"rc","sha":"c0804a05693392f1372613cdfee513e3bb83c31c","user":{"login":"cBioPortal","id":9876251,"avatar_url":"https://avatars.githubusercontent.com/u/9876251?v=3","gravatar_id":"","url":"https://api.github.com/users/cBioPortal","html_url":"https://github.com/cBioPortal","followers_url":"https://api.github.com/users/cBioPortal/followers","following_url":"https://api.github.com/users/cBioPortal/following{/other_user}","gists_url":"https://api.github.com/users/cBioPortal/gists{/gist_id}","starred_url":"https://api.github.com/users/cBioPortal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cBioPortal/subscriptions","organizations_url":"https://api.github.com/users/cBioPortal/orgs","repos_url":"https://api.github.com/users/cBioPortal/repos","events_url":"https://api.github.com/users/cBioPortal/events{/privacy}","received_events_url":"https://api.github.com/users/cBioPortal/received_events","type":"Organization","site_admin":false},"repo":{"id":32481543,"name":"cbioportal","full_name":"cBioPortal/cbioportal","owner":{"login":"cBioPortal","id":9876251,"avatar_url":"https://avatars.githubusercontent.com/u/9876251?v=3","gravatar_id":"","url":"https://api.github.com/users/cBioPortal","html_url":"https://github.com/cBioPortal","followers_url":"https://api.github.com/users/cBioPortal/followers","following_url":"https://api.github.com/users/cBioPortal/following{/other_user}","gists_url":"https://api.github.com/users/cBioPortal/gists{/gist_id}","starred_url":"https://api.github.com/users/cBioPortal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cBioPortal/subscriptions","organizations_url":"https://api.github.com/users/cBioPortal/orgs","repos_url":"https://api.github.com/users/cBioPortal/repos","events_url":"https://api.github.com/users/cBioPortal/events{/privacy}","received_events_url":"https://api.github.com/users/cBioPortal/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cBioPortal/cbioportal","description":"cBioPortal for Cancer Genomics","fork":false,"url":"https://api.github.com/repos/cBioPortal/cbioportal","forks_url":"https://api.github.com/repos/cBioPortal/cbioportal/forks","keys_url":"https://api.github.com/repos/cBioPortal/cbioportal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cBioPortal/cbioportal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cBioPortal/cbioportal/teams","hooks_url":"https://api.github.com/repos/cBioPortal/cbioportal/hooks","issue_events_url":"https://api.github.com/repos/cBioPortal/cbioportal/issues/events{/number}","events_url":"https://api.github.com/repos/cBioPortal/cbioportal/events","assignees_url":"https://api.github.com/repos/cBioPortal/cbioportal/assignees{/user}","branches_url":"https://api.github.com/repos/cBioPortal/cbioportal/branches{/branch}","tags_url":"https://api.github.com/repos/cBioPortal/cbioportal/tags","blobs_url":"https://api.github.com/repos/cBioPortal/cbioportal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cBioPortal/cbioportal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cBioPortal/cbioportal/git/refs{/sha}","trees_url":"https://api.github.com/repos/cBioPortal/cbioportal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cBioPortal/cbioportal/statuses/{sha}","languages_url":"https://api.github.com/repos/cBioPortal/cbioportal/languages","stargazers_url":"https://api.github.com/repos/cBioPortal/cbioportal/stargazers","contributors_url":"https://api.github.com/repos/cBioPortal/cbioportal/contributors","subscribers_url":"https://api.github.com/repos/cBioPortal/cbioportal/subscribers","subscription_url":"https://api.github.com/repos/cBioPortal/cbioportal/subscription","commits_url":"https://api.github.com/repos/cBioPortal/cbioportal/commits{/sha}","git_commits_url":"https://api.github.com/repos/cBioPortal/cbioportal/git/commits{/sha}","comments_url":"https://api.github.com/repos/cBioPortal/cbioportal/comments{/number}","issue_comment_url":"https://api.github.com/repos/cBioPortal/cbioportal/issues/comments{/number}","contents_url":"https://api.github.com/repos/cBioPortal/cbioportal/contents/{+path}","compare_url":"https://api.github.com/repos/cBioPortal/cbioportal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cBioPortal/cbioportal/merges","archive_url":"https://api.github.com/repos/cBioPortal/cbioportal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cBioPortal/cbioportal/downloads","issues_url":"https://api.github.com/repos/cBioPortal/cbioportal/issues{/number}","pulls_url":"https://api.github.com/repos/cBioPortal/cbioportal/pulls{/number}","milestones_url":"https://api.github.com/repos/cBioPortal/cbioportal/milestones{/number}","notifications_url":"https://api.github.com/repos/cBioPortal/cbioportal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cBioPortal/cbioportal/labels{/name}","releases_url":"https://api.github.com/repos/cBioPortal/cbioportal/releases{/id}","deployments_url":"https://api.github.com/repos/cBioPortal/cbioportal/deployments","created_at":"2015-03-18T20:09:09Z","updated_at":"2016-07-13T06:33:04Z","pushed_at":"2016-07-21T14:03:27Z","git_url":"git://github.com/cBioPortal/cbioportal.git","ssh_url":"git@github.com:cBioPortal/cbioportal.git","clone_url":"https://github.com/cBioPortal/cbioportal.git","svn_url":"https://github.com/cBioPortal/cbioportal","homepage":"http://cbioportal.org","size":198502,"stargazers_count":63,"watchers_count":63,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":91,"mirror_url":null,"open_issues_count":318,"forks":91,"open_issues":318,"watchers":63,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cBioPortal/cbioportal/pulls/1517"},"html":{"href":"https://github.com/cBioPortal/cbioportal/pull/1517"},"issue":{"href":"https://api.github.com/repos/cBioPortal/cbioportal/issues/1517"},"comments":{"href":"https://api.github.com/repos/cBioPortal/cbioportal/issues/1517/comments"},"review_comments":{"href":"https://api.github.com/repos/cBioPortal/cbioportal/pulls/1517/comments"},"review_comment":{"href":"https://api.github.com/repos/cBioPortal/cbioportal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cBioPortal/cbioportal/pulls/1517/commits"},"statuses":{"href":"https://api.github.com/repos/cBioPortal/cbioportal/statuses/bc9dcb8fb25051300cb5af6f53f9831091dd26e8"}}}}
{"actor":{"display_login":"morungos"}}