{"action":"created","issue":{"url":"https://api.github.com/repos/Sirupsen/logrus/issues/384","repository_url":"https://api.github.com/repos/Sirupsen/logrus","labels_url":"https://api.github.com/repos/Sirupsen/logrus/issues/384/labels{/name}","comments_url":"https://api.github.com/repos/Sirupsen/logrus/issues/384/comments","events_url":"https://api.github.com/repos/Sirupsen/logrus/issues/384/events","html_url":"https://github.com/Sirupsen/logrus/pull/384","id":166124988,"number":384,"title":"Renaming upper-case 'Sirupsen' to 'sirupsen'","user":{"login":"mnzt","id":10098811,"avatar_url":"https://avatars.githubusercontent.com/u/10098811?v=3","gravatar_id":"","url":"https://api.github.com/users/mnzt","html_url":"https://github.com/mnzt","followers_url":"https://api.github.com/users/mnzt/followers","following_url":"https://api.github.com/users/mnzt/following{/other_user}","gists_url":"https://api.github.com/users/mnzt/gists{/gist_id}","starred_url":"https://api.github.com/users/mnzt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mnzt/subscriptions","organizations_url":"https://api.github.com/users/mnzt/orgs","repos_url":"https://api.github.com/users/mnzt/repos","events_url":"https://api.github.com/users/mnzt/events{/privacy}","received_events_url":"https://api.github.com/users/mnzt/received_events","type":"User","site_admin":false},"labels":[{"id":414988107,"url":"https://api.github.com/repos/Sirupsen/logrus/labels/needs-passing-tests","name":"needs-passing-tests","color":"b60205","default":false}],"state":"open","locked":false,"assignee":{"login":"aarongreenlee","id":264508,"avatar_url":"https://avatars.githubusercontent.com/u/264508?v=3","gravatar_id":"","url":"https://api.github.com/users/aarongreenlee","html_url":"https://github.com/aarongreenlee","followers_url":"https://api.github.com/users/aarongreenlee/followers","following_url":"https://api.github.com/users/aarongreenlee/following{/other_user}","gists_url":"https://api.github.com/users/aarongreenlee/gists{/gist_id}","starred_url":"https://api.github.com/users/aarongreenlee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aarongreenlee/subscriptions","organizations_url":"https://api.github.com/users/aarongreenlee/orgs","repos_url":"https://api.github.com/users/aarongreenlee/repos","events_url":"https://api.github.com/users/aarongreenlee/events{/privacy}","received_events_url":"https://api.github.com/users/aarongreenlee/received_events","type":"User","site_admin":false},"assignees":[{"login":"aarongreenlee","id":264508,"avatar_url":"https://avatars.githubusercontent.com/u/264508?v=3","gravatar_id":"","url":"https://api.github.com/users/aarongreenlee","html_url":"https://github.com/aarongreenlee","followers_url":"https://api.github.com/users/aarongreenlee/followers","following_url":"https://api.github.com/users/aarongreenlee/following{/other_user}","gists_url":"https://api.github.com/users/aarongreenlee/gists{/gist_id}","starred_url":"https://api.github.com/users/aarongreenlee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aarongreenlee/subscriptions","organizations_url":"https://api.github.com/users/aarongreenlee/orgs","repos_url":"https://api.github.com/users/aarongreenlee/repos","events_url":"https://api.github.com/users/aarongreenlee/events{/privacy}","received_events_url":"https://api.github.com/users/aarongreenlee/received_events","type":"User","site_admin":false}],"milestone":null,"comments":8,"created_at":"2016-07-18T15:42:25Z","updated_at":"2016-11-18T19:53:06Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Sirupsen/logrus/pulls/384","html_url":"https://github.com/Sirupsen/logrus/pull/384","diff_url":"https://github.com/Sirupsen/logrus/pull/384.diff","patch_url":"https://github.com/Sirupsen/logrus/pull/384.patch"},"body":"The reason for this is that most other packages use lower-case naming conventions.\n\nThe vendoring tool I use (GB) is case sensitive, and can become a massive pain in the :peach: when Logrus is the only package with an upper-case name (as most other packages are in lower case, following https://blog.golang.org/package-names) - this often leads to build failures.\n\n> Why don't you just vendor it in lower case?\n\nBecause Logrus has itself as an internal dependency, it vendors two folders, `Sirupsen/logrus` and `sirupsen/logrus`.\n"},"comment":{"url":"https://api.github.com/repos/Sirupsen/logrus/issues/comments/261625963","html_url":"https://github.com/Sirupsen/logrus/pull/384#issuecomment-261625963","issue_url":"https://api.github.com/repos/Sirupsen/logrus/issues/384","id":261625963,"user":{"login":"stevvooe","id":120601,"avatar_url":"https://avatars.githubusercontent.com/u/120601?v=3","gravatar_id":"","url":"https://api.github.com/users/stevvooe","html_url":"https://github.com/stevvooe","followers_url":"https://api.github.com/users/stevvooe/followers","following_url":"https://api.github.com/users/stevvooe/following{/other_user}","gists_url":"https://api.github.com/users/stevvooe/gists{/gist_id}","starred_url":"https://api.github.com/users/stevvooe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevvooe/subscriptions","organizations_url":"https://api.github.com/users/stevvooe/orgs","repos_url":"https://api.github.com/users/stevvooe/repos","events_url":"https://api.github.com/users/stevvooe/events{/privacy}","received_events_url":"https://api.github.com/users/stevvooe/received_events","type":"User","site_admin":false},"created_at":"2016-11-18T19:53:06Z","updated_at":"2016-11-18T19:53:06Z","body":"@Sirupsen When this package changes to `github.com/sirupsen/logrus`, won't the builds fail if the only thing found in GOPATH is `github.com/Sirupsen/logrus` on a case sensitive filesystem?\r\n\r\nFor the most part, I am not against this change. If we are willing to risk possible breakage, it is for the better."}}
{"actor":{"display_login":"stevvooe"}}