{"action":"closed","number":843,"pull_request":{"url":"https://api.github.com/repos/mhan810/liferay-portal/pulls/843","id":53981554,"html_url":"https://github.com/mhan810/liferay-portal/pull/843","diff_url":"https://github.com/mhan810/liferay-portal/pull/843.diff","patch_url":"https://github.com/mhan810/liferay-portal/pull/843.patch","issue_url":"https://api.github.com/repos/mhan810/liferay-portal/issues/843","number":843,"state":"closed","locked":false,"title":"LPS-43624 Fix: Search not hiding Calendar Events from Users without permissions","user":{"login":"arboliveira","id":859765,"avatar_url":"https://avatars.githubusercontent.com/u/859765?v=3","gravatar_id":"","url":"https://api.github.com/users/arboliveira","html_url":"https://github.com/arboliveira","followers_url":"https://api.github.com/users/arboliveira/followers","following_url":"https://api.github.com/users/arboliveira/following{/other_user}","gists_url":"https://api.github.com/users/arboliveira/gists{/gist_id}","starred_url":"https://api.github.com/users/arboliveira/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arboliveira/subscriptions","organizations_url":"https://api.github.com/users/arboliveira/orgs","repos_url":"https://api.github.com/users/arboliveira/repos","events_url":"https://api.github.com/users/arboliveira/events{/privacy}","received_events_url":"https://api.github.com/users/arboliveira/received_events","type":"User","site_admin":false},"body":"Hi Mike, to get the whole context please read Adam's comprehensive explanation:  https://github.com/brandizzi/liferay-portal/commit/12044ab32500aab88a46e587118d7086637bf2f9#commitcomment-14693061\r\n\r\nThe CalendarBookingIndexer related commits all look good to me. I'm not too familiar with DefaultSearchResultPermissionFilter though, not feeling confident enough to assess overall impact of https://github.com/brandizzi/liferay-portal/commit/12044ab32500aab88a46e587118d7086637bf2f9#diff-40ee20608ee53c59ff077ccaac8da16bL108. Can you take a final look?\r\n\r\nThanks!\r\n","created_at":"2015-12-17T14:22:33Z","updated_at":"2016-01-07T21:13:36Z","closed_at":"2016-01-07T21:13:36Z","merged_at":null,"merge_commit_sha":"0a4b1101ce159c86c3826b827482faf2fad79c41","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mhan810/liferay-portal/pulls/843/commits","review_comments_url":"https://api.github.com/repos/mhan810/liferay-portal/pulls/843/comments","review_comment_url":"https://api.github.com/repos/mhan810/liferay-portal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mhan810/liferay-portal/issues/843/comments","statuses_url":"https://api.github.com/repos/mhan810/liferay-portal/statuses/48bb0bb8ac7a07f37ca40f9705268937aa2d5116","head":{"label":"arboliveira:pr-75-LPS-43624-isPermissionAware-vs-CalendarBookingIndexer","ref":"pr-75-LPS-43624-isPermissionAware-vs-CalendarBookingIndexer","sha":"48bb0bb8ac7a07f37ca40f9705268937aa2d5116","user":{"login":"arboliveira","id":859765,"avatar_url":"https://avatars.githubusercontent.com/u/859765?v=3","gravatar_id":"","url":"https://api.github.com/users/arboliveira","html_url":"https://github.com/arboliveira","followers_url":"https://api.github.com/users/arboliveira/followers","following_url":"https://api.github.com/users/arboliveira/following{/other_user}","gists_url":"https://api.github.com/users/arboliveira/gists{/gist_id}","starred_url":"https://api.github.com/users/arboliveira/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arboliveira/subscriptions","organizations_url":"https://api.github.com/users/arboliveira/orgs","repos_url":"https://api.github.com/users/arboliveira/repos","events_url":"https://api.github.com/users/arboliveira/events{/privacy}","received_events_url":"https://api.github.com/users/arboliveira/received_events","type":"User","site_admin":false},"repo":{"id":16181718,"name":"liferay-portal","full_name":"arboliveira/liferay-portal","owner":{"login":"arboliveira","id":859765,"avatar_url":"https://avatars.githubusercontent.com/u/859765?v=3","gravatar_id":"","url":"https://api.github.com/users/arboliveira","html_url":"https://github.com/arboliveira","followers_url":"https://api.github.com/users/arboliveira/followers","following_url":"https://api.github.com/users/arboliveira/following{/other_user}","gists_url":"https://api.github.com/users/arboliveira/gists{/gist_id}","starred_url":"https://api.github.com/users/arboliveira/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arboliveira/subscriptions","organizations_url":"https://api.github.com/users/arboliveira/orgs","repos_url":"https://api.github.com/users/arboliveira/repos","events_url":"https://api.github.com/users/arboliveira/events{/privacy}","received_events_url":"https://api.github.com/users/arboliveira/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/arboliveira/liferay-portal","description":"","fork":true,"url":"https://api.github.com/repos/arboliveira/liferay-portal","forks_url":"https://api.github.com/repos/arboliveira/liferay-portal/forks","keys_url":"https://api.github.com/repos/arboliveira/liferay-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arboliveira/liferay-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arboliveira/liferay-portal/teams","hooks_url":"https://api.github.com/repos/arboliveira/liferay-portal/hooks","issue_events_url":"https://api.github.com/repos/arboliveira/liferay-portal/issues/events{/number}","events_url":"https://api.github.com/repos/arboliveira/liferay-portal/events","assignees_url":"https://api.github.com/repos/arboliveira/liferay-portal/assignees{/user}","branches_url":"https://api.github.com/repos/arboliveira/liferay-portal/branches{/branch}","tags_url":"https://api.github.com/repos/arboliveira/liferay-portal/tags","blobs_url":"https://api.github.com/repos/arboliveira/liferay-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arboliveira/liferay-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arboliveira/liferay-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/arboliveira/liferay-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arboliveira/liferay-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/arboliveira/liferay-portal/languages","stargazers_url":"https://api.github.com/repos/arboliveira/liferay-portal/stargazers","contributors_url":"https://api.github.com/repos/arboliveira/liferay-portal/contributors","subscribers_url":"https://api.github.com/repos/arboliveira/liferay-portal/subscribers","subscription_url":"https://api.github.com/repos/arboliveira/liferay-portal/subscription","commits_url":"https://api.github.com/repos/arboliveira/liferay-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/arboliveira/liferay-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/arboliveira/liferay-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/arboliveira/liferay-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/arboliveira/liferay-portal/contents/{+path}","compare_url":"https://api.github.com/repos/arboliveira/liferay-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arboliveira/liferay-portal/merges","archive_url":"https://api.github.com/repos/arboliveira/liferay-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arboliveira/liferay-portal/downloads","issues_url":"https://api.github.com/repos/arboliveira/liferay-portal/issues{/number}","pulls_url":"https://api.github.com/repos/arboliveira/liferay-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/arboliveira/liferay-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/arboliveira/liferay-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arboliveira/liferay-portal/labels{/name}","releases_url":"https://api.github.com/repos/arboliveira/liferay-portal/releases{/id}","created_at":"2014-01-23T18:41:27Z","updated_at":"2015-05-07T22:50:40Z","pushed_at":"2016-01-07T17:45:09Z","git_url":"git://github.com/arboliveira/liferay-portal.git","ssh_url":"git@github.com:arboliveira/liferay-portal.git","clone_url":"https://github.com/arboliveira/liferay-portal.git","svn_url":"https://github.com/arboliveira/liferay-portal","homepage":"http://liferay.com","size":5546435,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":12,"forks":0,"open_issues":12,"watchers":0,"default_branch":"master"}},"base":{"label":"mhan810:master","ref":"master","sha":"5b8a15594832df665ef9b4c6a75da49e05e19c2d","user":{"login":"mhan810","id":597924,"avatar_url":"https://avatars.githubusercontent.com/u/597924?v=3","gravatar_id":"","url":"https://api.github.com/users/mhan810","html_url":"https://github.com/mhan810","followers_url":"https://api.github.com/users/mhan810/followers","following_url":"https://api.github.com/users/mhan810/following{/other_user}","gists_url":"https://api.github.com/users/mhan810/gists{/gist_id}","starred_url":"https://api.github.com/users/mhan810/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhan810/subscriptions","organizations_url":"https://api.github.com/users/mhan810/orgs","repos_url":"https://api.github.com/users/mhan810/repos","events_url":"https://api.github.com/users/mhan810/events{/privacy}","received_events_url":"https://api.github.com/users/mhan810/received_events","type":"User","site_admin":false},"repo":{"id":1925095,"name":"liferay-portal","full_name":"mhan810/liferay-portal","owner":{"login":"mhan810","id":597924,"avatar_url":"https://avatars.githubusercontent.com/u/597924?v=3","gravatar_id":"","url":"https://api.github.com/users/mhan810","html_url":"https://github.com/mhan810","followers_url":"https://api.github.com/users/mhan810/followers","following_url":"https://api.github.com/users/mhan810/following{/other_user}","gists_url":"https://api.github.com/users/mhan810/gists{/gist_id}","starred_url":"https://api.github.com/users/mhan810/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhan810/subscriptions","organizations_url":"https://api.github.com/users/mhan810/orgs","repos_url":"https://api.github.com/users/mhan810/repos","events_url":"https://api.github.com/users/mhan810/events{/privacy}","received_events_url":"https://api.github.com/users/mhan810/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mhan810/liferay-portal","description":"","fork":true,"url":"https://api.github.com/repos/mhan810/liferay-portal","forks_url":"https://api.github.com/repos/mhan810/liferay-portal/forks","keys_url":"https://api.github.com/repos/mhan810/liferay-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mhan810/liferay-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mhan810/liferay-portal/teams","hooks_url":"https://api.github.com/repos/mhan810/liferay-portal/hooks","issue_events_url":"https://api.github.com/repos/mhan810/liferay-portal/issues/events{/number}","events_url":"https://api.github.com/repos/mhan810/liferay-portal/events","assignees_url":"https://api.github.com/repos/mhan810/liferay-portal/assignees{/user}","branches_url":"https://api.github.com/repos/mhan810/liferay-portal/branches{/branch}","tags_url":"https://api.github.com/repos/mhan810/liferay-portal/tags","blobs_url":"https://api.github.com/repos/mhan810/liferay-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mhan810/liferay-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mhan810/liferay-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/mhan810/liferay-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mhan810/liferay-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/mhan810/liferay-portal/languages","stargazers_url":"https://api.github.com/repos/mhan810/liferay-portal/stargazers","contributors_url":"https://api.github.com/repos/mhan810/liferay-portal/contributors","subscribers_url":"https://api.github.com/repos/mhan810/liferay-portal/subscribers","subscription_url":"https://api.github.com/repos/mhan810/liferay-portal/subscription","commits_url":"https://api.github.com/repos/mhan810/liferay-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/mhan810/liferay-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/mhan810/liferay-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/mhan810/liferay-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/mhan810/liferay-portal/contents/{+path}","compare_url":"https://api.github.com/repos/mhan810/liferay-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mhan810/liferay-portal/merges","archive_url":"https://api.github.com/repos/mhan810/liferay-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mhan810/liferay-portal/downloads","issues_url":"https://api.github.com/repos/mhan810/liferay-portal/issues{/number}","pulls_url":"https://api.github.com/repos/mhan810/liferay-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/mhan810/liferay-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/mhan810/liferay-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mhan810/liferay-portal/labels{/name}","releases_url":"https://api.github.com/repos/mhan810/liferay-portal/releases{/id}","created_at":"2011-06-20T18:34:54Z","updated_at":"2015-10-02T21:32:56Z","pushed_at":"2016-01-07T21:07:32Z","git_url":"git://github.com/mhan810/liferay-portal.git","ssh_url":"git@github.com:mhan810/liferay-portal.git","clone_url":"https://github.com/mhan810/liferay-portal.git","svn_url":"https://github.com/mhan810/liferay-portal","homepage":"http://liferay.com","size":5533954,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":7,"forks":0,"open_issues":7,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mhan810/liferay-portal/pulls/843"},"html":{"href":"https://github.com/mhan810/liferay-portal/pull/843"},"issue":{"href":"https://api.github.com/repos/mhan810/liferay-portal/issues/843"},"comments":{"href":"https://api.github.com/repos/mhan810/liferay-portal/issues/843/comments"},"review_comments":{"href":"https://api.github.com/repos/mhan810/liferay-portal/pulls/843/comments"},"review_comment":{"href":"https://api.github.com/repos/mhan810/liferay-portal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mhan810/liferay-portal/pulls/843/commits"},"statuses":{"href":"https://api.github.com/repos/mhan810/liferay-portal/statuses/48bb0bb8ac7a07f37ca40f9705268937aa2d5116"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":2,"review_comments":0,"commits":244,"additions":2365,"deletions":1215,"changed_files":931}}