{"action":"closed","issue":{"url":"https://api.github.com/repos/ibm-js/delite/issues/439","repository_url":"https://api.github.com/repos/ibm-js/delite","labels_url":"https://api.github.com/repos/ibm-js/delite/issues/439/labels{/name}","comments_url":"https://api.github.com/repos/ibm-js/delite/issues/439/comments","events_url":"https://api.github.com/repos/ibm-js/delite/issues/439/events","html_url":"https://github.com/ibm-js/delite/issues/439","id":139899935,"number":439,"title":"on() should consistently report ESC key as \"Escape\"","user":{"login":"wkeese","id":69599,"avatar_url":"https://avatars.githubusercontent.com/u/69599?v=3","gravatar_id":"","url":"https://api.github.com/users/wkeese","html_url":"https://github.com/wkeese","followers_url":"https://api.github.com/users/wkeese/followers","following_url":"https://api.github.com/users/wkeese/following{/other_user}","gists_url":"https://api.github.com/users/wkeese/gists{/gist_id}","starred_url":"https://api.github.com/users/wkeese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wkeese/subscriptions","organizations_url":"https://api.github.com/users/wkeese/orgs","repos_url":"https://api.github.com/users/wkeese/repos","events_url":"https://api.github.com/users/wkeese/events{/privacy}","received_events_url":"https://api.github.com/users/wkeese/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ibm-js/delite/labels/bug","name":"bug","color":"fc2929"}],"state":"closed","locked":false,"assignee":{"login":"wkeese","id":69599,"avatar_url":"https://avatars.githubusercontent.com/u/69599?v=3","gravatar_id":"","url":"https://api.github.com/users/wkeese","html_url":"https://github.com/wkeese","followers_url":"https://api.github.com/users/wkeese/followers","following_url":"https://api.github.com/users/wkeese/following{/other_user}","gists_url":"https://api.github.com/users/wkeese/gists{/gist_id}","starred_url":"https://api.github.com/users/wkeese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wkeese/subscriptions","organizations_url":"https://api.github.com/users/wkeese/orgs","repos_url":"https://api.github.com/users/wkeese/repos","events_url":"https://api.github.com/users/wkeese/events{/privacy}","received_events_url":"https://api.github.com/users/wkeese/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/ibm-js/delite/milestones/19","html_url":"https://github.com/ibm-js/delite/milestones/0.8.2","labels_url":"https://api.github.com/repos/ibm-js/delite/milestones/19/labels","id":1591954,"number":19,"title":"0.8.2","description":"Fix template build regression and a few other critical bugs.","creator":{"login":"wkeese","id":69599,"avatar_url":"https://avatars.githubusercontent.com/u/69599?v=3","gravatar_id":"","url":"https://api.github.com/users/wkeese","html_url":"https://github.com/wkeese","followers_url":"https://api.github.com/users/wkeese/followers","following_url":"https://api.github.com/users/wkeese/following{/other_user}","gists_url":"https://api.github.com/users/wkeese/gists{/gist_id}","starred_url":"https://api.github.com/users/wkeese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wkeese/subscriptions","organizations_url":"https://api.github.com/users/wkeese/orgs","repos_url":"https://api.github.com/users/wkeese/repos","events_url":"https://api.github.com/users/wkeese/events{/privacy}","received_events_url":"https://api.github.com/users/wkeese/received_events","type":"User","site_admin":false},"open_issues":0,"closed_issues":2,"state":"open","created_at":"2016-02-18T23:47:59Z","updated_at":"2016-03-10T14:53:20Z","due_on":"2016-03-14T15:00:00Z","closed_at":null},"comments":0,"created_at":"2016-03-10T14:18:27Z","updated_at":"2016-03-10T14:53:20Z","closed_at":"2016-03-10T14:53:20Z","body":"On Firefox delite/on reports the ESC key as \"Escape\", but on Chrome it's reported as \"Esc\".   This leads to various issues such as popups not closing correctly.   I think in the past everyone reported it as \"Esc\" but according to https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/key (and IIUC https://www.w3.org/TR/uievents/#fixed-virtual-key-codes) it should be reported as \"Escape\".\r\n\r\nSee delite/tests/functional/HasDropDown.html or deliteful/samples/Combobox.js.   Tab to the \"show menu - ltr\" button (or the Combobox), press the down arrow, and then press ESC.  The dropdown should close.  It works on Chrome, but not on Firefox.\r\n\r\nThere's actually a functional test to make sure this works, in deliteful/tests/functional/Combobox.js:\r\n\r\n```\r\n// Similar to native select, ESCAPE also closes and validates the popup\r\n.pressKeys(keys.ESCAPE)\r\n```\r\n\r\nI guess either it's currently failing on firefox, or it's not getting run on firefox.\r\n"}}