{"action":"closed","number":906,"pull_request":{"url":"https://api.github.com/repos/getgrav/grav/pulls/906","id":74034239,"html_url":"https://github.com/getgrav/grav/pull/906","diff_url":"https://github.com/getgrav/grav/pull/906.diff","patch_url":"https://github.com/getgrav/grav/pull/906.patch","issue_url":"https://api.github.com/repos/getgrav/grav/issues/906","number":906,"state":"closed","locked":false,"title":"Respect `enable_asset_timestamp` settings for pipelined Assets","user":{"login":"Sommerregen","id":9073307,"avatar_url":"https://avatars.githubusercontent.com/u/9073307?v=3","gravatar_id":"","url":"https://api.github.com/users/Sommerregen","html_url":"https://github.com/Sommerregen","followers_url":"https://api.github.com/users/Sommerregen/followers","following_url":"https://api.github.com/users/Sommerregen/following{/other_user}","gists_url":"https://api.github.com/users/Sommerregen/gists{/gist_id}","starred_url":"https://api.github.com/users/Sommerregen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sommerregen/subscriptions","organizations_url":"https://api.github.com/users/Sommerregen/orgs","repos_url":"https://api.github.com/users/Sommerregen/repos","events_url":"https://api.github.com/users/Sommerregen/events{/privacy}","received_events_url":"https://api.github.com/users/Sommerregen/received_events","type":"User","site_admin":false},"body":"I don't know if this is intentional, but the enabled `enable_asset_timestamp` settings is not respected for pipelined assets. Even if I disable this setting the cache key is always added.\r\n\r\nI know why the cache key should be present due to browser cache invalidation of changes. However what I don't understand is then, why this setting currently only affects non-pipelined assets (see e.g. [Assets.php#L556](https://github.com/Sommerregen/grav/blob/4cec9851a1f51d78894ee2b5cab28570a3e343e8/system/src/Grav/Common/Assets.php#L556)).\r\n\r\nThis PR is for the lazy-man. Instead of opening an issue we can discuss it here or if this behavior is intentional, feel free to close it.","created_at":"2016-06-16T07:32:33Z","updated_at":"2016-06-16T21:02:58Z","closed_at":"2016-06-16T21:02:58Z","merged_at":"2016-06-16T21:02:58Z","merge_commit_sha":"59bbaa5f33f63319c858c407b1a5c4c67aa72c36","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/getgrav/grav/pulls/906/commits","review_comments_url":"https://api.github.com/repos/getgrav/grav/pulls/906/comments","review_comment_url":"https://api.github.com/repos/getgrav/grav/pulls/comments{/number}","comments_url":"https://api.github.com/repos/getgrav/grav/issues/906/comments","statuses_url":"https://api.github.com/repos/getgrav/grav/statuses/96f08913b49371204de1a8fd1f1ec76f3f5fc11d","head":{"label":"Sommerregen:patch-6","ref":"patch-6","sha":"96f08913b49371204de1a8fd1f1ec76f3f5fc11d","user":{"login":"Sommerregen","id":9073307,"avatar_url":"https://avatars.githubusercontent.com/u/9073307?v=3","gravatar_id":"","url":"https://api.github.com/users/Sommerregen","html_url":"https://github.com/Sommerregen","followers_url":"https://api.github.com/users/Sommerregen/followers","following_url":"https://api.github.com/users/Sommerregen/following{/other_user}","gists_url":"https://api.github.com/users/Sommerregen/gists{/gist_id}","starred_url":"https://api.github.com/users/Sommerregen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sommerregen/subscriptions","organizations_url":"https://api.github.com/users/Sommerregen/orgs","repos_url":"https://api.github.com/users/Sommerregen/repos","events_url":"https://api.github.com/users/Sommerregen/events{/privacy}","received_events_url":"https://api.github.com/users/Sommerregen/received_events","type":"User","site_admin":false},"repo":{"id":30023768,"name":"grav","full_name":"Sommerregen/grav","owner":{"login":"Sommerregen","id":9073307,"avatar_url":"https://avatars.githubusercontent.com/u/9073307?v=3","gravatar_id":"","url":"https://api.github.com/users/Sommerregen","html_url":"https://github.com/Sommerregen","followers_url":"https://api.github.com/users/Sommerregen/followers","following_url":"https://api.github.com/users/Sommerregen/following{/other_user}","gists_url":"https://api.github.com/users/Sommerregen/gists{/gist_id}","starred_url":"https://api.github.com/users/Sommerregen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sommerregen/subscriptions","organizations_url":"https://api.github.com/users/Sommerregen/orgs","repos_url":"https://api.github.com/users/Sommerregen/repos","events_url":"https://api.github.com/users/Sommerregen/events{/privacy}","received_events_url":"https://api.github.com/users/Sommerregen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Sommerregen/grav","description":"Modern, Crazy Fast, Ridiculously Easy and Amazingly Powerful Flat-File CMS","fork":true,"url":"https://api.github.com/repos/Sommerregen/grav","forks_url":"https://api.github.com/repos/Sommerregen/grav/forks","keys_url":"https://api.github.com/repos/Sommerregen/grav/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Sommerregen/grav/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Sommerregen/grav/teams","hooks_url":"https://api.github.com/repos/Sommerregen/grav/hooks","issue_events_url":"https://api.github.com/repos/Sommerregen/grav/issues/events{/number}","events_url":"https://api.github.com/repos/Sommerregen/grav/events","assignees_url":"https://api.github.com/repos/Sommerregen/grav/assignees{/user}","branches_url":"https://api.github.com/repos/Sommerregen/grav/branches{/branch}","tags_url":"https://api.github.com/repos/Sommerregen/grav/tags","blobs_url":"https://api.github.com/repos/Sommerregen/grav/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Sommerregen/grav/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Sommerregen/grav/git/refs{/sha}","trees_url":"https://api.github.com/repos/Sommerregen/grav/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Sommerregen/grav/statuses/{sha}","languages_url":"https://api.github.com/repos/Sommerregen/grav/languages","stargazers_url":"https://api.github.com/repos/Sommerregen/grav/stargazers","contributors_url":"https://api.github.com/repos/Sommerregen/grav/contributors","subscribers_url":"https://api.github.com/repos/Sommerregen/grav/subscribers","subscription_url":"https://api.github.com/repos/Sommerregen/grav/subscription","commits_url":"https://api.github.com/repos/Sommerregen/grav/commits{/sha}","git_commits_url":"https://api.github.com/repos/Sommerregen/grav/git/commits{/sha}","comments_url":"https://api.github.com/repos/Sommerregen/grav/comments{/number}","issue_comment_url":"https://api.github.com/repos/Sommerregen/grav/issues/comments{/number}","contents_url":"https://api.github.com/repos/Sommerregen/grav/contents/{+path}","compare_url":"https://api.github.com/repos/Sommerregen/grav/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Sommerregen/grav/merges","archive_url":"https://api.github.com/repos/Sommerregen/grav/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Sommerregen/grav/downloads","issues_url":"https://api.github.com/repos/Sommerregen/grav/issues{/number}","pulls_url":"https://api.github.com/repos/Sommerregen/grav/pulls{/number}","milestones_url":"https://api.github.com/repos/Sommerregen/grav/milestones{/number}","notifications_url":"https://api.github.com/repos/Sommerregen/grav/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Sommerregen/grav/labels{/name}","releases_url":"https://api.github.com/repos/Sommerregen/grav/releases{/id}","deployments_url":"https://api.github.com/repos/Sommerregen/grav/deployments","created_at":"2015-01-29T14:31:43Z","updated_at":"2015-07-01T05:18:18Z","pushed_at":"2016-06-16T20:03:17Z","git_url":"git://github.com/Sommerregen/grav.git","ssh_url":"git@github.com:Sommerregen/grav.git","clone_url":"https://github.com/Sommerregen/grav.git","svn_url":"https://github.com/Sommerregen/grav","homepage":"http://getgrav.org","size":7661,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"develop"}},"base":{"label":"getgrav:develop","ref":"develop","sha":"f845943c47f41445e6f865cb483eb9a3aaf068f4","user":{"login":"getgrav","id":8237355,"avatar_url":"https://avatars.githubusercontent.com/u/8237355?v=3","gravatar_id":"","url":"https://api.github.com/users/getgrav","html_url":"https://github.com/getgrav","followers_url":"https://api.github.com/users/getgrav/followers","following_url":"https://api.github.com/users/getgrav/following{/other_user}","gists_url":"https://api.github.com/users/getgrav/gists{/gist_id}","starred_url":"https://api.github.com/users/getgrav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getgrav/subscriptions","organizations_url":"https://api.github.com/users/getgrav/orgs","repos_url":"https://api.github.com/users/getgrav/repos","events_url":"https://api.github.com/users/getgrav/events{/privacy}","received_events_url":"https://api.github.com/users/getgrav/received_events","type":"Organization","site_admin":false},"repo":{"id":22553797,"name":"grav","full_name":"getgrav/grav","owner":{"login":"getgrav","id":8237355,"avatar_url":"https://avatars.githubusercontent.com/u/8237355?v=3","gravatar_id":"","url":"https://api.github.com/users/getgrav","html_url":"https://github.com/getgrav","followers_url":"https://api.github.com/users/getgrav/followers","following_url":"https://api.github.com/users/getgrav/following{/other_user}","gists_url":"https://api.github.com/users/getgrav/gists{/gist_id}","starred_url":"https://api.github.com/users/getgrav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getgrav/subscriptions","organizations_url":"https://api.github.com/users/getgrav/orgs","repos_url":"https://api.github.com/users/getgrav/repos","events_url":"https://api.github.com/users/getgrav/events{/privacy}","received_events_url":"https://api.github.com/users/getgrav/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/getgrav/grav","description":"Modern, Crazy Fast, Ridiculously Easy and Amazingly Powerful Flat-File CMS","fork":false,"url":"https://api.github.com/repos/getgrav/grav","forks_url":"https://api.github.com/repos/getgrav/grav/forks","keys_url":"https://api.github.com/repos/getgrav/grav/keys{/key_id}","collaborators_url":"https://api.github.com/repos/getgrav/grav/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/getgrav/grav/teams","hooks_url":"https://api.github.com/repos/getgrav/grav/hooks","issue_events_url":"https://api.github.com/repos/getgrav/grav/issues/events{/number}","events_url":"https://api.github.com/repos/getgrav/grav/events","assignees_url":"https://api.github.com/repos/getgrav/grav/assignees{/user}","branches_url":"https://api.github.com/repos/getgrav/grav/branches{/branch}","tags_url":"https://api.github.com/repos/getgrav/grav/tags","blobs_url":"https://api.github.com/repos/getgrav/grav/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/getgrav/grav/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/getgrav/grav/git/refs{/sha}","trees_url":"https://api.github.com/repos/getgrav/grav/git/trees{/sha}","statuses_url":"https://api.github.com/repos/getgrav/grav/statuses/{sha}","languages_url":"https://api.github.com/repos/getgrav/grav/languages","stargazers_url":"https://api.github.com/repos/getgrav/grav/stargazers","contributors_url":"https://api.github.com/repos/getgrav/grav/contributors","subscribers_url":"https://api.github.com/repos/getgrav/grav/subscribers","subscription_url":"https://api.github.com/repos/getgrav/grav/subscription","commits_url":"https://api.github.com/repos/getgrav/grav/commits{/sha}","git_commits_url":"https://api.github.com/repos/getgrav/grav/git/commits{/sha}","comments_url":"https://api.github.com/repos/getgrav/grav/comments{/number}","issue_comment_url":"https://api.github.com/repos/getgrav/grav/issues/comments{/number}","contents_url":"https://api.github.com/repos/getgrav/grav/contents/{+path}","compare_url":"https://api.github.com/repos/getgrav/grav/compare/{base}...{head}","merges_url":"https://api.github.com/repos/getgrav/grav/merges","archive_url":"https://api.github.com/repos/getgrav/grav/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/getgrav/grav/downloads","issues_url":"https://api.github.com/repos/getgrav/grav/issues{/number}","pulls_url":"https://api.github.com/repos/getgrav/grav/pulls{/number}","milestones_url":"https://api.github.com/repos/getgrav/grav/milestones{/number}","notifications_url":"https://api.github.com/repos/getgrav/grav/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/getgrav/grav/labels{/name}","releases_url":"https://api.github.com/repos/getgrav/grav/releases{/id}","deployments_url":"https://api.github.com/repos/getgrav/grav/deployments","created_at":"2014-08-02T18:29:10Z","updated_at":"2016-06-16T12:45:27Z","pushed_at":"2016-06-16T21:02:58Z","git_url":"git://github.com/getgrav/grav.git","ssh_url":"git@github.com:getgrav/grav.git","clone_url":"https://github.com/getgrav/grav.git","svn_url":"https://github.com/getgrav/grav","homepage":"http://getgrav.org","size":12042,"stargazers_count":4505,"watchers_count":4505,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":382,"mirror_url":null,"open_issues_count":39,"forks":382,"open_issues":39,"watchers":4505,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/getgrav/grav/pulls/906"},"html":{"href":"https://github.com/getgrav/grav/pull/906"},"issue":{"href":"https://api.github.com/repos/getgrav/grav/issues/906"},"comments":{"href":"https://api.github.com/repos/getgrav/grav/issues/906/comments"},"review_comments":{"href":"https://api.github.com/repos/getgrav/grav/pulls/906/comments"},"review_comment":{"href":"https://api.github.com/repos/getgrav/grav/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/getgrav/grav/pulls/906/commits"},"statuses":{"href":"https://api.github.com/repos/getgrav/grav/statuses/96f08913b49371204de1a8fd1f1ec76f3f5fc11d"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"rhukster","id":1084697,"avatar_url":"https://avatars.githubusercontent.com/u/1084697?v=3","gravatar_id":"","url":"https://api.github.com/users/rhukster","html_url":"https://github.com/rhukster","followers_url":"https://api.github.com/users/rhukster/followers","following_url":"https://api.github.com/users/rhukster/following{/other_user}","gists_url":"https://api.github.com/users/rhukster/gists{/gist_id}","starred_url":"https://api.github.com/users/rhukster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhukster/subscriptions","organizations_url":"https://api.github.com/users/rhukster/orgs","repos_url":"https://api.github.com/users/rhukster/repos","events_url":"https://api.github.com/users/rhukster/events{/privacy}","received_events_url":"https://api.github.com/users/rhukster/received_events","type":"User","site_admin":false},"comments":5,"review_comments":0,"commits":3,"additions":8,"deletions":14,"changed_files":1}}
{"actor":{"display_login":"rhukster"}}