{"action":"opened","number":5834,"pull_request":{"url":"https://api.github.com/repos/sequelize/sequelize/pulls/5834","id":68572929,"html_url":"https://github.com/sequelize/sequelize/pull/5834","diff_url":"https://github.com/sequelize/sequelize/pull/5834.diff","patch_url":"https://github.com/sequelize/sequelize/pull/5834.patch","issue_url":"https://api.github.com/repos/sequelize/sequelize/issues/5834","number":5834,"state":"open","locked":false,"title":"Fixing associations doc","user":{"login":"gtelljohann","id":8798097,"avatar_url":"https://avatars.githubusercontent.com/u/8798097?v=3","gravatar_id":"","url":"https://api.github.com/users/gtelljohann","html_url":"https://github.com/gtelljohann","followers_url":"https://api.github.com/users/gtelljohann/followers","following_url":"https://api.github.com/users/gtelljohann/following{/other_user}","gists_url":"https://api.github.com/users/gtelljohann/gists{/gist_id}","starred_url":"https://api.github.com/users/gtelljohann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gtelljohann/subscriptions","organizations_url":"https://api.github.com/users/gtelljohann/orgs","repos_url":"https://api.github.com/users/gtelljohann/repos","events_url":"https://api.github.com/users/gtelljohann/events{/privacy}","received_events_url":"https://api.github.com/users/gtelljohann/received_events","type":"User","site_admin":false},"body":"I'm not positive that this was what was intended originally, but as it currently is, this code snippet isn't valid javascript.  I was able to find no example of `through` taking anything other than a string, but it does seem like `attributes` and `where` can both go in `include`, so I assume that this is the right way.  This also makes sense given the context of the example.","created_at":"2016-05-02T15:09:32Z","updated_at":"2016-05-02T15:09:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sequelize/sequelize/pulls/5834/commits","review_comments_url":"https://api.github.com/repos/sequelize/sequelize/pulls/5834/comments","review_comment_url":"https://api.github.com/repos/sequelize/sequelize/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sequelize/sequelize/issues/5834/comments","statuses_url":"https://api.github.com/repos/sequelize/sequelize/statuses/b8c71990751ca970a5f597995e90fe1310fee1b6","head":{"label":"gtelljohann:master","ref":"master","sha":"b8c71990751ca970a5f597995e90fe1310fee1b6","user":{"login":"gtelljohann","id":8798097,"avatar_url":"https://avatars.githubusercontent.com/u/8798097?v=3","gravatar_id":"","url":"https://api.github.com/users/gtelljohann","html_url":"https://github.com/gtelljohann","followers_url":"https://api.github.com/users/gtelljohann/followers","following_url":"https://api.github.com/users/gtelljohann/following{/other_user}","gists_url":"https://api.github.com/users/gtelljohann/gists{/gist_id}","starred_url":"https://api.github.com/users/gtelljohann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gtelljohann/subscriptions","organizations_url":"https://api.github.com/users/gtelljohann/orgs","repos_url":"https://api.github.com/users/gtelljohann/repos","events_url":"https://api.github.com/users/gtelljohann/events{/privacy}","received_events_url":"https://api.github.com/users/gtelljohann/received_events","type":"User","site_admin":false},"repo":{"id":57897682,"name":"sequelize","full_name":"gtelljohann/sequelize","owner":{"login":"gtelljohann","id":8798097,"avatar_url":"https://avatars.githubusercontent.com/u/8798097?v=3","gravatar_id":"","url":"https://api.github.com/users/gtelljohann","html_url":"https://github.com/gtelljohann","followers_url":"https://api.github.com/users/gtelljohann/followers","following_url":"https://api.github.com/users/gtelljohann/following{/other_user}","gists_url":"https://api.github.com/users/gtelljohann/gists{/gist_id}","starred_url":"https://api.github.com/users/gtelljohann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gtelljohann/subscriptions","organizations_url":"https://api.github.com/users/gtelljohann/orgs","repos_url":"https://api.github.com/users/gtelljohann/repos","events_url":"https://api.github.com/users/gtelljohann/events{/privacy}","received_events_url":"https://api.github.com/users/gtelljohann/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gtelljohann/sequelize","description":"Sequelize is an easy-to-use multi sql dialect ORM for Node.js & io.js. It currently supports MySQL, MariaDB, SQLite, PostgreSQL and MSSQL.","fork":true,"url":"https://api.github.com/repos/gtelljohann/sequelize","forks_url":"https://api.github.com/repos/gtelljohann/sequelize/forks","keys_url":"https://api.github.com/repos/gtelljohann/sequelize/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gtelljohann/sequelize/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gtelljohann/sequelize/teams","hooks_url":"https://api.github.com/repos/gtelljohann/sequelize/hooks","issue_events_url":"https://api.github.com/repos/gtelljohann/sequelize/issues/events{/number}","events_url":"https://api.github.com/repos/gtelljohann/sequelize/events","assignees_url":"https://api.github.com/repos/gtelljohann/sequelize/assignees{/user}","branches_url":"https://api.github.com/repos/gtelljohann/sequelize/branches{/branch}","tags_url":"https://api.github.com/repos/gtelljohann/sequelize/tags","blobs_url":"https://api.github.com/repos/gtelljohann/sequelize/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gtelljohann/sequelize/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gtelljohann/sequelize/git/refs{/sha}","trees_url":"https://api.github.com/repos/gtelljohann/sequelize/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gtelljohann/sequelize/statuses/{sha}","languages_url":"https://api.github.com/repos/gtelljohann/sequelize/languages","stargazers_url":"https://api.github.com/repos/gtelljohann/sequelize/stargazers","contributors_url":"https://api.github.com/repos/gtelljohann/sequelize/contributors","subscribers_url":"https://api.github.com/repos/gtelljohann/sequelize/subscribers","subscription_url":"https://api.github.com/repos/gtelljohann/sequelize/subscription","commits_url":"https://api.github.com/repos/gtelljohann/sequelize/commits{/sha}","git_commits_url":"https://api.github.com/repos/gtelljohann/sequelize/git/commits{/sha}","comments_url":"https://api.github.com/repos/gtelljohann/sequelize/comments{/number}","issue_comment_url":"https://api.github.com/repos/gtelljohann/sequelize/issues/comments{/number}","contents_url":"https://api.github.com/repos/gtelljohann/sequelize/contents/{+path}","compare_url":"https://api.github.com/repos/gtelljohann/sequelize/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gtelljohann/sequelize/merges","archive_url":"https://api.github.com/repos/gtelljohann/sequelize/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gtelljohann/sequelize/downloads","issues_url":"https://api.github.com/repos/gtelljohann/sequelize/issues{/number}","pulls_url":"https://api.github.com/repos/gtelljohann/sequelize/pulls{/number}","milestones_url":"https://api.github.com/repos/gtelljohann/sequelize/milestones{/number}","notifications_url":"https://api.github.com/repos/gtelljohann/sequelize/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gtelljohann/sequelize/labels{/name}","releases_url":"https://api.github.com/repos/gtelljohann/sequelize/releases{/id}","deployments_url":"https://api.github.com/repos/gtelljohann/sequelize/deployments","created_at":"2016-05-02T14:54:39Z","updated_at":"2016-05-02T14:54:45Z","pushed_at":"2016-05-02T15:07:45Z","git_url":"git://github.com/gtelljohann/sequelize.git","ssh_url":"git@github.com:gtelljohann/sequelize.git","clone_url":"https://github.com/gtelljohann/sequelize.git","svn_url":"https://github.com/gtelljohann/sequelize","homepage":"http://sequelizejs.com","size":17292,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sequelize:master","ref":"master","sha":"fb4d5a95972bec82979b7ab826e2eb9e29a3522a","user":{"login":"sequelize","id":3591786,"avatar_url":"https://avatars.githubusercontent.com/u/3591786?v=3","gravatar_id":"","url":"https://api.github.com/users/sequelize","html_url":"https://github.com/sequelize","followers_url":"https://api.github.com/users/sequelize/followers","following_url":"https://api.github.com/users/sequelize/following{/other_user}","gists_url":"https://api.github.com/users/sequelize/gists{/gist_id}","starred_url":"https://api.github.com/users/sequelize/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sequelize/subscriptions","organizations_url":"https://api.github.com/users/sequelize/orgs","repos_url":"https://api.github.com/users/sequelize/repos","events_url":"https://api.github.com/users/sequelize/events{/privacy}","received_events_url":"https://api.github.com/users/sequelize/received_events","type":"Organization","site_admin":false},"repo":{"id":790359,"name":"sequelize","full_name":"sequelize/sequelize","owner":{"login":"sequelize","id":3591786,"avatar_url":"https://avatars.githubusercontent.com/u/3591786?v=3","gravatar_id":"","url":"https://api.github.com/users/sequelize","html_url":"https://github.com/sequelize","followers_url":"https://api.github.com/users/sequelize/followers","following_url":"https://api.github.com/users/sequelize/following{/other_user}","gists_url":"https://api.github.com/users/sequelize/gists{/gist_id}","starred_url":"https://api.github.com/users/sequelize/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sequelize/subscriptions","organizations_url":"https://api.github.com/users/sequelize/orgs","repos_url":"https://api.github.com/users/sequelize/repos","events_url":"https://api.github.com/users/sequelize/events{/privacy}","received_events_url":"https://api.github.com/users/sequelize/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sequelize/sequelize","description":"Sequelize is an easy-to-use multi sql dialect ORM for Node.js & io.js. It currently supports MySQL, MariaDB, SQLite, PostgreSQL and MSSQL.","fork":false,"url":"https://api.github.com/repos/sequelize/sequelize","forks_url":"https://api.github.com/repos/sequelize/sequelize/forks","keys_url":"https://api.github.com/repos/sequelize/sequelize/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sequelize/sequelize/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sequelize/sequelize/teams","hooks_url":"https://api.github.com/repos/sequelize/sequelize/hooks","issue_events_url":"https://api.github.com/repos/sequelize/sequelize/issues/events{/number}","events_url":"https://api.github.com/repos/sequelize/sequelize/events","assignees_url":"https://api.github.com/repos/sequelize/sequelize/assignees{/user}","branches_url":"https://api.github.com/repos/sequelize/sequelize/branches{/branch}","tags_url":"https://api.github.com/repos/sequelize/sequelize/tags","blobs_url":"https://api.github.com/repos/sequelize/sequelize/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sequelize/sequelize/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sequelize/sequelize/git/refs{/sha}","trees_url":"https://api.github.com/repos/sequelize/sequelize/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sequelize/sequelize/statuses/{sha}","languages_url":"https://api.github.com/repos/sequelize/sequelize/languages","stargazers_url":"https://api.github.com/repos/sequelize/sequelize/stargazers","contributors_url":"https://api.github.com/repos/sequelize/sequelize/contributors","subscribers_url":"https://api.github.com/repos/sequelize/sequelize/subscribers","subscription_url":"https://api.github.com/repos/sequelize/sequelize/subscription","commits_url":"https://api.github.com/repos/sequelize/sequelize/commits{/sha}","git_commits_url":"https://api.github.com/repos/sequelize/sequelize/git/commits{/sha}","comments_url":"https://api.github.com/repos/sequelize/sequelize/comments{/number}","issue_comment_url":"https://api.github.com/repos/sequelize/sequelize/issues/comments{/number}","contents_url":"https://api.github.com/repos/sequelize/sequelize/contents/{+path}","compare_url":"https://api.github.com/repos/sequelize/sequelize/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sequelize/sequelize/merges","archive_url":"https://api.github.com/repos/sequelize/sequelize/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sequelize/sequelize/downloads","issues_url":"https://api.github.com/repos/sequelize/sequelize/issues{/number}","pulls_url":"https://api.github.com/repos/sequelize/sequelize/pulls{/number}","milestones_url":"https://api.github.com/repos/sequelize/sequelize/milestones{/number}","notifications_url":"https://api.github.com/repos/sequelize/sequelize/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sequelize/sequelize/labels{/name}","releases_url":"https://api.github.com/repos/sequelize/sequelize/releases{/id}","deployments_url":"https://api.github.com/repos/sequelize/sequelize/deployments","created_at":"2010-07-22T07:11:11Z","updated_at":"2016-05-02T14:42:26Z","pushed_at":"2016-05-02T09:32:36Z","git_url":"git://github.com/sequelize/sequelize.git","ssh_url":"git@github.com:sequelize/sequelize.git","clone_url":"https://github.com/sequelize/sequelize.git","svn_url":"https://github.com/sequelize/sequelize","homepage":"http://sequelizejs.com","size":53417,"stargazers_count":6391,"watchers_count":6391,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1349,"mirror_url":null,"open_issues_count":710,"forks":1349,"open_issues":710,"watchers":6391,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sequelize/sequelize/pulls/5834"},"html":{"href":"https://github.com/sequelize/sequelize/pull/5834"},"issue":{"href":"https://api.github.com/repos/sequelize/sequelize/issues/5834"},"comments":{"href":"https://api.github.com/repos/sequelize/sequelize/issues/5834/comments"},"review_comments":{"href":"https://api.github.com/repos/sequelize/sequelize/pulls/5834/comments"},"review_comment":{"href":"https://api.github.com/repos/sequelize/sequelize/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sequelize/sequelize/pulls/5834/commits"},"statuses":{"href":"https://api.github.com/repos/sequelize/sequelize/statuses/b8c71990751ca970a5f597995e90fe1310fee1b6"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":3,"deletions":4,"changed_files":1}}