{"action":"closed","number":10034,"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/10034","id":78843738,"html_url":"https://github.com/openshift/origin/pull/10034","diff_url":"https://github.com/openshift/origin/pull/10034.diff","patch_url":"https://github.com/openshift/origin/pull/10034.patch","issue_url":"https://api.github.com/repos/openshift/origin/issues/10034","number":10034,"state":"closed","locked":false,"title":"Use client interface for DCReaper","user":{"login":"mdalstein","id":20173489,"avatar_url":"https://avatars.githubusercontent.com/u/20173489?v=3","gravatar_id":"","url":"https://api.github.com/users/mdalstein","html_url":"https://github.com/mdalstein","followers_url":"https://api.github.com/users/mdalstein/followers","following_url":"https://api.github.com/users/mdalstein/following{/other_user}","gists_url":"https://api.github.com/users/mdalstein/gists{/gist_id}","starred_url":"https://api.github.com/users/mdalstein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdalstein/subscriptions","organizations_url":"https://api.github.com/users/mdalstein/orgs","repos_url":"https://api.github.com/users/mdalstein/repos","events_url":"https://api.github.com/users/mdalstein/events{/privacy}","received_events_url":"https://api.github.com/users/mdalstein/received_events","type":"User","site_admin":false},"body":"This PR aims at aligning the openshift DeploymentConfig Reaper method signature to the [kubernetes ReplicationController Reaper](https://github.com/openshift/origin/blob/v1.3.0-alpha.2/Godeps/_workspace/src/k8s.io/kubernetes/pkg/kubectl/stop.go#L91) already using a client interface.\r\n\r\nThe goal is not only to be consistent with k8s but also to enable unit testing of the DCReaper through fake clients, which is not possible as of today.\r\n\r\n@sdminonne , @kargakis : FYI","created_at":"2016-07-26T12:36:45Z","updated_at":"2016-07-27T12:56:08Z","closed_at":"2016-07-27T12:56:08Z","merged_at":"2016-07-27T12:56:08Z","merge_commit_sha":"6c631f833f3685fa57f12ba5cc575e1f56692e19","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin/pulls/10034/commits","review_comments_url":"https://api.github.com/repos/openshift/origin/pulls/10034/comments","review_comment_url":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin/issues/10034/comments","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/a292d35b7686ce6f83e86ea6390e69432037f99c","head":{"label":"mdalstein:interfaceInAPI","ref":"interfaceInAPI","sha":"a292d35b7686ce6f83e86ea6390e69432037f99c","user":{"login":"mdalstein","id":20173489,"avatar_url":"https://avatars.githubusercontent.com/u/20173489?v=3","gravatar_id":"","url":"https://api.github.com/users/mdalstein","html_url":"https://github.com/mdalstein","followers_url":"https://api.github.com/users/mdalstein/followers","following_url":"https://api.github.com/users/mdalstein/following{/other_user}","gists_url":"https://api.github.com/users/mdalstein/gists{/gist_id}","starred_url":"https://api.github.com/users/mdalstein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdalstein/subscriptions","organizations_url":"https://api.github.com/users/mdalstein/orgs","repos_url":"https://api.github.com/users/mdalstein/repos","events_url":"https://api.github.com/users/mdalstein/events{/privacy}","received_events_url":"https://api.github.com/users/mdalstein/received_events","type":"User","site_admin":false},"repo":{"id":64143315,"name":"origin","full_name":"mdalstein/origin","owner":{"login":"mdalstein","id":20173489,"avatar_url":"https://avatars.githubusercontent.com/u/20173489?v=3","gravatar_id":"","url":"https://api.github.com/users/mdalstein","html_url":"https://github.com/mdalstein","followers_url":"https://api.github.com/users/mdalstein/followers","following_url":"https://api.github.com/users/mdalstein/following{/other_user}","gists_url":"https://api.github.com/users/mdalstein/gists{/gist_id}","starred_url":"https://api.github.com/users/mdalstein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdalstein/subscriptions","organizations_url":"https://api.github.com/users/mdalstein/orgs","repos_url":"https://api.github.com/users/mdalstein/repos","events_url":"https://api.github.com/users/mdalstein/events{/privacy}","received_events_url":"https://api.github.com/users/mdalstein/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mdalstein/origin","description":"Enterprise-Ready Kubernetes for Developers","fork":true,"url":"https://api.github.com/repos/mdalstein/origin","forks_url":"https://api.github.com/repos/mdalstein/origin/forks","keys_url":"https://api.github.com/repos/mdalstein/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mdalstein/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mdalstein/origin/teams","hooks_url":"https://api.github.com/repos/mdalstein/origin/hooks","issue_events_url":"https://api.github.com/repos/mdalstein/origin/issues/events{/number}","events_url":"https://api.github.com/repos/mdalstein/origin/events","assignees_url":"https://api.github.com/repos/mdalstein/origin/assignees{/user}","branches_url":"https://api.github.com/repos/mdalstein/origin/branches{/branch}","tags_url":"https://api.github.com/repos/mdalstein/origin/tags","blobs_url":"https://api.github.com/repos/mdalstein/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mdalstein/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mdalstein/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/mdalstein/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mdalstein/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/mdalstein/origin/languages","stargazers_url":"https://api.github.com/repos/mdalstein/origin/stargazers","contributors_url":"https://api.github.com/repos/mdalstein/origin/contributors","subscribers_url":"https://api.github.com/repos/mdalstein/origin/subscribers","subscription_url":"https://api.github.com/repos/mdalstein/origin/subscription","commits_url":"https://api.github.com/repos/mdalstein/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/mdalstein/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/mdalstein/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/mdalstein/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/mdalstein/origin/contents/{+path}","compare_url":"https://api.github.com/repos/mdalstein/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mdalstein/origin/merges","archive_url":"https://api.github.com/repos/mdalstein/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mdalstein/origin/downloads","issues_url":"https://api.github.com/repos/mdalstein/origin/issues{/number}","pulls_url":"https://api.github.com/repos/mdalstein/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/mdalstein/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/mdalstein/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mdalstein/origin/labels{/name}","releases_url":"https://api.github.com/repos/mdalstein/origin/releases{/id}","deployments_url":"https://api.github.com/repos/mdalstein/origin/deployments","created_at":"2016-07-25T14:52:52Z","updated_at":"2016-07-25T14:53:01Z","pushed_at":"2016-07-26T11:59:22Z","git_url":"git://github.com/mdalstein/origin.git","ssh_url":"git@github.com:mdalstein/origin.git","clone_url":"https://github.com/mdalstein/origin.git","svn_url":"https://github.com/mdalstein/origin","homepage":"http://www.openshift.org","size":302101,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"970b73a3592e5beba7f6ea05da6b47407466b0c2","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":22442668,"name":"origin","full_name":"openshift/origin","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin","description":"Enterprise-Ready Kubernetes for Developers","fork":false,"url":"https://api.github.com/repos/openshift/origin","forks_url":"https://api.github.com/repos/openshift/origin/forks","keys_url":"https://api.github.com/repos/openshift/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin/teams","hooks_url":"https://api.github.com/repos/openshift/origin/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin/events","assignees_url":"https://api.github.com/repos/openshift/origin/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin/tags","blobs_url":"https://api.github.com/repos/openshift/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin/languages","stargazers_url":"https://api.github.com/repos/openshift/origin/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin/subscription","commits_url":"https://api.github.com/repos/openshift/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin/merges","archive_url":"https://api.github.com/repos/openshift/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin/downloads","issues_url":"https://api.github.com/repos/openshift/origin/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/origin/deployments","created_at":"2014-07-30T20:04:05Z","updated_at":"2016-07-27T12:53:14Z","pushed_at":"2016-07-27T12:56:08Z","git_url":"git://github.com/openshift/origin.git","ssh_url":"git@github.com:openshift/origin.git","clone_url":"https://github.com/openshift/origin.git","svn_url":"https://github.com/openshift/origin","homepage":"http://www.openshift.org","size":552076,"stargazers_count":1517,"watchers_count":1517,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":910,"mirror_url":null,"open_issues_count":1088,"forks":910,"open_issues":1088,"watchers":1517,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/10034"},"html":{"href":"https://github.com/openshift/origin/pull/10034"},"issue":{"href":"https://api.github.com/repos/openshift/origin/issues/10034"},"comments":{"href":"https://api.github.com/repos/openshift/origin/issues/10034/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin/pulls/10034/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin/pulls/10034/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin/statuses/a292d35b7686ce6f83e86ea6390e69432037f99c"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"openshift-bot","id":1779249,"avatar_url":"https://avatars.githubusercontent.com/u/1779249?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift-bot","html_url":"https://github.com/openshift-bot","followers_url":"https://api.github.com/users/openshift-bot/followers","following_url":"https://api.github.com/users/openshift-bot/following{/other_user}","gists_url":"https://api.github.com/users/openshift-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift-bot/subscriptions","organizations_url":"https://api.github.com/users/openshift-bot/orgs","repos_url":"https://api.github.com/users/openshift-bot/repos","events_url":"https://api.github.com/users/openshift-bot/events{/privacy}","received_events_url":"https://api.github.com/users/openshift-bot/received_events","type":"User","site_admin":false},"comments":8,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"openshift-bot"}}