{"action":"created","issue":{"url":"https://api.github.com/repos/metabase/metabase/issues/3013","repository_url":"https://api.github.com/repos/metabase/metabase","labels_url":"https://api.github.com/repos/metabase/metabase/issues/3013/labels{/name}","comments_url":"https://api.github.com/repos/metabase/metabase/issues/3013/comments","events_url":"https://api.github.com/repos/metabase/metabase/issues/3013/events","html_url":"https://github.com/metabase/metabase/issues/3013","id":167427164,"number":3013,"title":"not all modals respond to click out or esc key close fn calls.","user":{"login":"kdoh","id":5248953,"avatar_url":"https://avatars.githubusercontent.com/u/5248953?v=3","gravatar_id":"","url":"https://api.github.com/users/kdoh","html_url":"https://github.com/kdoh","followers_url":"https://api.github.com/users/kdoh/followers","following_url":"https://api.github.com/users/kdoh/following{/other_user}","gists_url":"https://api.github.com/users/kdoh/gists{/gist_id}","starred_url":"https://api.github.com/users/kdoh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kdoh/subscriptions","organizations_url":"https://api.github.com/users/kdoh/orgs","repos_url":"https://api.github.com/users/kdoh/repos","events_url":"https://api.github.com/users/kdoh/events{/privacy}","received_events_url":"https://api.github.com/users/kdoh/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/metabase/metabase/labels/UX","name":"UX","color":"BBA8ED"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-07-25T17:57:46Z","updated_at":"2016-07-28T03:34:59Z","closed_at":null,"body":"in working on #3008 I noticed that some modals aren't properly closing when expected when events from the ``OnClickOutsideWrapper`` are called. One note, this seems specific to modals and not popovers.\r\n\r\na partial list so far:\r\n\r\n- [ ] user edit modal in admin\r\n- [ ] post save \"would you like to add this to a dashboard\"\r\n- [ ] add to dashboard modal\r\n- [ ] about metabase\r\n\r\n... more to come"},"comment":{"url":"https://api.github.com/repos/metabase/metabase/issues/comments/235792041","html_url":"https://github.com/metabase/metabase/issues/3013#issuecomment-235792041","issue_url":"https://api.github.com/repos/metabase/metabase/issues/3013","id":235792041,"user":{"login":"tlrobinson","id":18193,"avatar_url":"https://avatars.githubusercontent.com/u/18193?v=3","gravatar_id":"","url":"https://api.github.com/users/tlrobinson","html_url":"https://github.com/tlrobinson","followers_url":"https://api.github.com/users/tlrobinson/followers","following_url":"https://api.github.com/users/tlrobinson/following{/other_user}","gists_url":"https://api.github.com/users/tlrobinson/gists{/gist_id}","starred_url":"https://api.github.com/users/tlrobinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tlrobinson/subscriptions","organizations_url":"https://api.github.com/users/tlrobinson/orgs","repos_url":"https://api.github.com/users/tlrobinson/repos","events_url":"https://api.github.com/users/tlrobinson/events{/privacy}","received_events_url":"https://api.github.com/users/tlrobinson/received_events","type":"User","site_admin":false},"created_at":"2016-07-28T03:34:59Z","updated_at":"2016-07-28T03:34:59Z","body":"This is due to not providing an `onClose` prop to those modals. When you use `ModalWithTrigger` or `PopoverWithTrigger` that is handled for you, but not when you use `Modal` or `Popover` directly."}}
{"actor":{"display_login":"tlrobinson"}}