{"action":"created","comment":{"url":"https://api.github.com/repos/spring-projects/spring-boot/pulls/comments/74701745","id":74701745,"diff_hunk":"@@ -58,6 +66,7 @@ public int run(boolean waitForProcess, String... args) throws IOException {\n \tprotected int run(boolean waitForProcess, Collection<String> args)\n \t\t\tthrows IOException {\n \t\tProcessBuilder builder = new ProcessBuilder(this.command);\n+\t\tbuilder.directory(workingDirectory);","path":"spring-boot-tools/spring-boot-loader-tools/src/main/java/org/springframework/boot/loader/tools/RunProcess.java","position":32,"original_position":32,"commit_id":"2066495cab89d3fff767a792bbd386b32e53a8d8","original_commit_id":"2066495cab89d3fff767a792bbd386b32e53a8d8","user":{"login":"snicoll","id":490484,"avatar_url":"https://avatars.githubusercontent.com/u/490484?v=3","gravatar_id":"","url":"https://api.github.com/users/snicoll","html_url":"https://github.com/snicoll","followers_url":"https://api.github.com/users/snicoll/followers","following_url":"https://api.github.com/users/snicoll/following{/other_user}","gists_url":"https://api.github.com/users/snicoll/gists{/gist_id}","starred_url":"https://api.github.com/users/snicoll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snicoll/subscriptions","organizations_url":"https://api.github.com/users/snicoll/orgs","repos_url":"https://api.github.com/users/snicoll/repos","events_url":"https://api.github.com/users/snicoll/events{/privacy}","received_events_url":"https://api.github.com/users/snicoll/received_events","type":"User","site_admin":false},"body":"Now that I've looked at the javadoc of `ProcessBuillder#directory` I take it back: it is very explicit about the semantic of `null` there so I'd keep it like that. I'd add a javadoc on the constructor to reflect that information (but I can take care of that myself when I merge).\r\n\r\nFeel free to update this PR, just push an additional commit on your branch (or preferably, rebase + push force)","created_at":"2016-08-14T13:31:49Z","updated_at":"2016-08-14T13:31:49Z","html_url":"https://github.com/spring-projects/spring-boot/pull/6645#discussion_r74701745","pull_request_url":"https://api.github.com/repos/spring-projects/spring-boot/pulls/6645","_links":{"self":{"href":"https://api.github.com/repos/spring-projects/spring-boot/pulls/comments/74701745"},"html":{"href":"https://github.com/spring-projects/spring-boot/pull/6645#discussion_r74701745"},"pull_request":{"href":"https://api.github.com/repos/spring-projects/spring-boot/pulls/6645"}}},"pull_request":{"url":"https://api.github.com/repos/spring-projects/spring-boot/pulls/6645","id":81224261,"html_url":"https://github.com/spring-projects/spring-boot/pull/6645","diff_url":"https://github.com/spring-projects/spring-boot/pull/6645.diff","patch_url":"https://github.com/spring-projects/spring-boot/pull/6645.patch","issue_url":"https://api.github.com/repos/spring-projects/spring-boot/issues/6645","number":6645,"state":"open","locked":false,"title":"Add working directory configuration option for Maven plugin run/start","user":{"login":"plamentotev","id":12773485,"avatar_url":"https://avatars.githubusercontent.com/u/12773485?v=3","gravatar_id":"","url":"https://api.github.com/users/plamentotev","html_url":"https://github.com/plamentotev","followers_url":"https://api.github.com/users/plamentotev/followers","following_url":"https://api.github.com/users/plamentotev/following{/other_user}","gists_url":"https://api.github.com/users/plamentotev/gists{/gist_id}","starred_url":"https://api.github.com/users/plamentotev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plamentotev/subscriptions","organizations_url":"https://api.github.com/users/plamentotev/orgs","repos_url":"https://api.github.com/users/plamentotev/repos","events_url":"https://api.github.com/users/plamentotev/events{/privacy}","received_events_url":"https://api.github.com/users/plamentotev/received_events","type":"User","site_admin":false},"body":"Add configuration option that specifies the working directory of the application ran by Maven plugin's run/start goals.\r\n\r\nSee #6243 ","created_at":"2016-08-13T19:35:38Z","updated_at":"2016-08-14T13:31:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5cf88c146c418e6f5c1a16b65d7848452907f163","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/spring-projects/spring-boot/pulls/6645/commits","review_comments_url":"https://api.github.com/repos/spring-projects/spring-boot/pulls/6645/comments","review_comment_url":"https://api.github.com/repos/spring-projects/spring-boot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spring-projects/spring-boot/issues/6645/comments","statuses_url":"https://api.github.com/repos/spring-projects/spring-boot/statuses/2066495cab89d3fff767a792bbd386b32e53a8d8","head":{"label":"plamentotev:maven-run-work-dir","ref":"maven-run-work-dir","sha":"2066495cab89d3fff767a792bbd386b32e53a8d8","user":{"login":"plamentotev","id":12773485,"avatar_url":"https://avatars.githubusercontent.com/u/12773485?v=3","gravatar_id":"","url":"https://api.github.com/users/plamentotev","html_url":"https://github.com/plamentotev","followers_url":"https://api.github.com/users/plamentotev/followers","following_url":"https://api.github.com/users/plamentotev/following{/other_user}","gists_url":"https://api.github.com/users/plamentotev/gists{/gist_id}","starred_url":"https://api.github.com/users/plamentotev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plamentotev/subscriptions","organizations_url":"https://api.github.com/users/plamentotev/orgs","repos_url":"https://api.github.com/users/plamentotev/repos","events_url":"https://api.github.com/users/plamentotev/events{/privacy}","received_events_url":"https://api.github.com/users/plamentotev/received_events","type":"User","site_admin":false},"repo":{"id":58217617,"name":"spring-boot","full_name":"plamentotev/spring-boot","owner":{"login":"plamentotev","id":12773485,"avatar_url":"https://avatars.githubusercontent.com/u/12773485?v=3","gravatar_id":"","url":"https://api.github.com/users/plamentotev","html_url":"https://github.com/plamentotev","followers_url":"https://api.github.com/users/plamentotev/followers","following_url":"https://api.github.com/users/plamentotev/following{/other_user}","gists_url":"https://api.github.com/users/plamentotev/gists{/gist_id}","starred_url":"https://api.github.com/users/plamentotev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plamentotev/subscriptions","organizations_url":"https://api.github.com/users/plamentotev/orgs","repos_url":"https://api.github.com/users/plamentotev/repos","events_url":"https://api.github.com/users/plamentotev/events{/privacy}","received_events_url":"https://api.github.com/users/plamentotev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/plamentotev/spring-boot","description":"Spring Boot","fork":true,"url":"https://api.github.com/repos/plamentotev/spring-boot","forks_url":"https://api.github.com/repos/plamentotev/spring-boot/forks","keys_url":"https://api.github.com/repos/plamentotev/spring-boot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/plamentotev/spring-boot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/plamentotev/spring-boot/teams","hooks_url":"https://api.github.com/repos/plamentotev/spring-boot/hooks","issue_events_url":"https://api.github.com/repos/plamentotev/spring-boot/issues/events{/number}","events_url":"https://api.github.com/repos/plamentotev/spring-boot/events","assignees_url":"https://api.github.com/repos/plamentotev/spring-boot/assignees{/user}","branches_url":"https://api.github.com/repos/plamentotev/spring-boot/branches{/branch}","tags_url":"https://api.github.com/repos/plamentotev/spring-boot/tags","blobs_url":"https://api.github.com/repos/plamentotev/spring-boot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/plamentotev/spring-boot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/plamentotev/spring-boot/git/refs{/sha}","trees_url":"https://api.github.com/repos/plamentotev/spring-boot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/plamentotev/spring-boot/statuses/{sha}","languages_url":"https://api.github.com/repos/plamentotev/spring-boot/languages","stargazers_url":"https://api.github.com/repos/plamentotev/spring-boot/stargazers","contributors_url":"https://api.github.com/repos/plamentotev/spring-boot/contributors","subscribers_url":"https://api.github.com/repos/plamentotev/spring-boot/subscribers","subscription_url":"https://api.github.com/repos/plamentotev/spring-boot/subscription","commits_url":"https://api.github.com/repos/plamentotev/spring-boot/commits{/sha}","git_commits_url":"https://api.github.com/repos/plamentotev/spring-boot/git/commits{/sha}","comments_url":"https://api.github.com/repos/plamentotev/spring-boot/comments{/number}","issue_comment_url":"https://api.github.com/repos/plamentotev/spring-boot/issues/comments{/number}","contents_url":"https://api.github.com/repos/plamentotev/spring-boot/contents/{+path}","compare_url":"https://api.github.com/repos/plamentotev/spring-boot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/plamentotev/spring-boot/merges","archive_url":"https://api.github.com/repos/plamentotev/spring-boot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/plamentotev/spring-boot/downloads","issues_url":"https://api.github.com/repos/plamentotev/spring-boot/issues{/number}","pulls_url":"https://api.github.com/repos/plamentotev/spring-boot/pulls{/number}","milestones_url":"https://api.github.com/repos/plamentotev/spring-boot/milestones{/number}","notifications_url":"https://api.github.com/repos/plamentotev/spring-boot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/plamentotev/spring-boot/labels{/name}","releases_url":"https://api.github.com/repos/plamentotev/spring-boot/releases{/id}","deployments_url":"https://api.github.com/repos/plamentotev/spring-boot/deployments","created_at":"2016-05-06T15:42:58Z","updated_at":"2016-05-06T15:43:14Z","pushed_at":"2016-08-13T19:33:49Z","git_url":"git://github.com/plamentotev/spring-boot.git","ssh_url":"git@github.com:plamentotev/spring-boot.git","clone_url":"https://github.com/plamentotev/spring-boot.git","svn_url":"https://github.com/plamentotev/spring-boot","homepage":"http://projects.spring.io/spring-boot","size":38691,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spring-projects:master","ref":"master","sha":"2d1e85c2fcccd95cf7938442e673edc6ad775c1d","user":{"login":"spring-projects","id":317776,"avatar_url":"https://avatars.githubusercontent.com/u/317776?v=3","gravatar_id":"","url":"https://api.github.com/users/spring-projects","html_url":"https://github.com/spring-projects","followers_url":"https://api.github.com/users/spring-projects/followers","following_url":"https://api.github.com/users/spring-projects/following{/other_user}","gists_url":"https://api.github.com/users/spring-projects/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-projects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-projects/subscriptions","organizations_url":"https://api.github.com/users/spring-projects/orgs","repos_url":"https://api.github.com/users/spring-projects/repos","events_url":"https://api.github.com/users/spring-projects/events{/privacy}","received_events_url":"https://api.github.com/users/spring-projects/received_events","type":"Organization","site_admin":false},"repo":{"id":6296790,"name":"spring-boot","full_name":"spring-projects/spring-boot","owner":{"login":"spring-projects","id":317776,"avatar_url":"https://avatars.githubusercontent.com/u/317776?v=3","gravatar_id":"","url":"https://api.github.com/users/spring-projects","html_url":"https://github.com/spring-projects","followers_url":"https://api.github.com/users/spring-projects/followers","following_url":"https://api.github.com/users/spring-projects/following{/other_user}","gists_url":"https://api.github.com/users/spring-projects/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-projects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-projects/subscriptions","organizations_url":"https://api.github.com/users/spring-projects/orgs","repos_url":"https://api.github.com/users/spring-projects/repos","events_url":"https://api.github.com/users/spring-projects/events{/privacy}","received_events_url":"https://api.github.com/users/spring-projects/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spring-projects/spring-boot","description":"Spring Boot","fork":false,"url":"https://api.github.com/repos/spring-projects/spring-boot","forks_url":"https://api.github.com/repos/spring-projects/spring-boot/forks","keys_url":"https://api.github.com/repos/spring-projects/spring-boot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spring-projects/spring-boot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spring-projects/spring-boot/teams","hooks_url":"https://api.github.com/repos/spring-projects/spring-boot/hooks","issue_events_url":"https://api.github.com/repos/spring-projects/spring-boot/issues/events{/number}","events_url":"https://api.github.com/repos/spring-projects/spring-boot/events","assignees_url":"https://api.github.com/repos/spring-projects/spring-boot/assignees{/user}","branches_url":"https://api.github.com/repos/spring-projects/spring-boot/branches{/branch}","tags_url":"https://api.github.com/repos/spring-projects/spring-boot/tags","blobs_url":"https://api.github.com/repos/spring-projects/spring-boot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spring-projects/spring-boot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spring-projects/spring-boot/git/refs{/sha}","trees_url":"https://api.github.com/repos/spring-projects/spring-boot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spring-projects/spring-boot/statuses/{sha}","languages_url":"https://api.github.com/repos/spring-projects/spring-boot/languages","stargazers_url":"https://api.github.com/repos/spring-projects/spring-boot/stargazers","contributors_url":"https://api.github.com/repos/spring-projects/spring-boot/contributors","subscribers_url":"https://api.github.com/repos/spring-projects/spring-boot/subscribers","subscription_url":"https://api.github.com/repos/spring-projects/spring-boot/subscription","commits_url":"https://api.github.com/repos/spring-projects/spring-boot/commits{/sha}","git_commits_url":"https://api.github.com/repos/spring-projects/spring-boot/git/commits{/sha}","comments_url":"https://api.github.com/repos/spring-projects/spring-boot/comments{/number}","issue_comment_url":"https://api.github.com/repos/spring-projects/spring-boot/issues/comments{/number}","contents_url":"https://api.github.com/repos/spring-projects/spring-boot/contents/{+path}","compare_url":"https://api.github.com/repos/spring-projects/spring-boot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spring-projects/spring-boot/merges","archive_url":"https://api.github.com/repos/spring-projects/spring-boot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spring-projects/spring-boot/downloads","issues_url":"https://api.github.com/repos/spring-projects/spring-boot/issues{/number}","pulls_url":"https://api.github.com/repos/spring-projects/spring-boot/pulls{/number}","milestones_url":"https://api.github.com/repos/spring-projects/spring-boot/milestones{/number}","notifications_url":"https://api.github.com/repos/spring-projects/spring-boot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spring-projects/spring-boot/labels{/name}","releases_url":"https://api.github.com/repos/spring-projects/spring-boot/releases{/id}","deployments_url":"https://api.github.com/repos/spring-projects/spring-boot/deployments","created_at":"2012-10-19T15:02:57Z","updated_at":"2016-08-14T13:02:03Z","pushed_at":"2016-08-14T06:07:44Z","git_url":"git://github.com/spring-projects/spring-boot.git","ssh_url":"git@github.com:spring-projects/spring-boot.git","clone_url":"https://github.com/spring-projects/spring-boot.git","svn_url":"https://github.com/spring-projects/spring-boot","homepage":"http://projects.spring.io/spring-boot","size":50296,"stargazers_count":6822,"watchers_count":6822,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6703,"mirror_url":null,"open_issues_count":571,"forks":6703,"open_issues":571,"watchers":6822,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spring-projects/spring-boot/pulls/6645"},"html":{"href":"https://github.com/spring-projects/spring-boot/pull/6645"},"issue":{"href":"https://api.github.com/repos/spring-projects/spring-boot/issues/6645"},"comments":{"href":"https://api.github.com/repos/spring-projects/spring-boot/issues/6645/comments"},"review_comments":{"href":"https://api.github.com/repos/spring-projects/spring-boot/pulls/6645/comments"},"review_comment":{"href":"https://api.github.com/repos/spring-projects/spring-boot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spring-projects/spring-boot/pulls/6645/commits"},"statuses":{"href":"https://api.github.com/repos/spring-projects/spring-boot/statuses/2066495cab89d3fff767a792bbd386b32e53a8d8"}}}}
{"actor":{"display_login":"snicoll"}}