{"action":"created","comment":{"url":"https://api.github.com/repos/conan-io/conan/pulls/comments/50661336","id":50661336,"diff_hunk":"@@ -183,28 +183,41 @@ class QmakeGenerator(Generator):\n     def content(self):\n         deps = DepsCppQmake(self._deps_build_info)\n \n-        template = ('# package{dep} \\n\\n'\n-                    'INCLUDEPATH += {deps.include_paths}\\n'\n-                    'LIBS += {deps.lib_paths}\\n'\n-                    'BINDIRS += {deps.bin_paths}\\n'\n-                    'LIBS += {deps.libs}\\n'\n-                    'DEFINES += {deps.defines}\\n'\n-                    'QMAKE_CXXFLAGS += {deps.cppflags}\\n'\n-                    'QMAKE_CFLAGS += {deps.cflags}\\n'\n-                    'QMAKE_LFLAGS += {deps.sharedlinkflags}\\n'\n-                    'QMAKE_LFLAGS += {deps.exelinkflags}\\n')\n-\n+        template = ('CONAN_INCLUDEPATH{dep_name} += {deps.include_paths}\\n'\n+                    'CONAN_LIBS{dep_name} += {deps.lib_paths}\\n'\n+                    'CONAN_BINDIRS{dep_name} += {deps.bin_paths}\\n'\n+                    'CONAN_LIBS{dep_name} += {deps.libs}\\n'\n+                    'CONAN_DEFINES{dep_name} += {deps.defines}\\n'\n+                    'CONAN_QMAKE_CXXFLAGS{dep_name} += {deps.cppflags}\\n'\n+                    'CONAN_QMAKE_CFLAGS{dep_name} += {deps.cflags}\\n'\n+                    'CONAN_QMAKE_LFLAGS{dep_name} += {deps.sharedlinkflags}\\n'\n+                    'CONAN_QMAKE_LFLAGS{dep_name} += {deps.exelinkflags}\\n')\n         sections = []\n-        all_flags = template.format(dep=\"\", deps=deps)\n+        template_all = template\n+        all_flags = template_all.format(dep_name=\"\", deps=deps)\n         sections.append(all_flags)\n-        template_deps = template + 'ROOTPATH{dep} = {deps.rootpath}\\n\\n'\n+        \n+        template_deps = template + 'CONAN_ROOTPATH{dep_name} = {deps.rootpath}\\n'","path":"conans/client/generators.py","position":31,"original_position":31,"commit_id":"4c7eb8a19b23ba2a17e9b34608ac7f8a3a3e739c","original_commit_id":"4c7eb8a19b23ba2a17e9b34608ac7f8a3a3e739c","user":{"login":"lasote","id":3807515,"avatar_url":"https://avatars.githubusercontent.com/u/3807515?v=3","gravatar_id":"","url":"https://api.github.com/users/lasote","html_url":"https://github.com/lasote","followers_url":"https://api.github.com/users/lasote/followers","following_url":"https://api.github.com/users/lasote/following{/other_user}","gists_url":"https://api.github.com/users/lasote/gists{/gist_id}","starred_url":"https://api.github.com/users/lasote/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lasote/subscriptions","organizations_url":"https://api.github.com/users/lasote/orgs","repos_url":"https://api.github.com/users/lasote/repos","events_url":"https://api.github.com/users/lasote/events{/privacy}","received_events_url":"https://api.github.com/users/lasote/received_events","type":"User","site_admin":false},"body":"In CMake generator its called CONAN_{dep}_ROOT. It's better to keep the same name.","created_at":"2016-01-25T07:48:05Z","updated_at":"2016-01-25T07:48:05Z","html_url":"https://github.com/conan-io/conan/pull/107#discussion_r50661336","pull_request_url":"https://api.github.com/repos/conan-io/conan/pulls/107","_links":{"self":{"href":"https://api.github.com/repos/conan-io/conan/pulls/comments/50661336"},"html":{"href":"https://github.com/conan-io/conan/pull/107#discussion_r50661336"},"pull_request":{"href":"https://api.github.com/repos/conan-io/conan/pulls/107"}}},"pull_request":{"url":"https://api.github.com/repos/conan-io/conan/pulls/107","id":56618931,"html_url":"https://github.com/conan-io/conan/pull/107","diff_url":"https://github.com/conan-io/conan/pull/107.diff","patch_url":"https://github.com/conan-io/conan/pull/107.patch","issue_url":"https://api.github.com/repos/conan-io/conan/issues/107","number":107,"state":"open","locked":false,"title":"Make qmake generator similar to CMake generator","user":{"login":"dragly","id":220658,"avatar_url":"https://avatars.githubusercontent.com/u/220658?v=3","gravatar_id":"","url":"https://api.github.com/users/dragly","html_url":"https://github.com/dragly","followers_url":"https://api.github.com/users/dragly/followers","following_url":"https://api.github.com/users/dragly/following{/other_user}","gists_url":"https://api.github.com/users/dragly/gists{/gist_id}","starred_url":"https://api.github.com/users/dragly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dragly/subscriptions","organizations_url":"https://api.github.com/users/dragly/orgs","repos_url":"https://api.github.com/users/dragly/repos","events_url":"https://api.github.com/users/dragly/events{/privacy}","received_events_url":"https://api.github.com/users/dragly/received_events","type":"User","site_admin":false},"body":"The current implementation of the qmake generator appends variables such as INCLUDEPATH twice for each included library by an oversight on my part. This commit fixes that.\r\n\r\nIn addition it makes the qmake generator behave more like the CMake generator. It now creates library-specific variables for things such as INCLUDEPATH, LIBS, etc., such as CONAN_INCLUDEPATH_POCO.\r\n\r\nFurther, you now have to explicitly specify that you want the basic setup, just like the CMake generator:\r\n\r\n```\r\nCONFIG += conan_basic_setup\r\ninclude(conanbuildinfo.pri)\r\n```\r\n\r\nThis allows the inclusion of conanbuildinfo if you wish to access the above mentioned library-specific variables without automatically cluttering the global INCLUDEPATH, LIBS, etc..","created_at":"2016-01-20T15:03:11Z","updated_at":"2016-01-25T07:48:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"123a5a9152ba8f99613488045f7fddeb52bc2b91","assignee":null,"milestone":{"url":"https://api.github.com/repos/conan-io/conan/milestones/3","html_url":"https://github.com/conan-io/conan/milestones/0.7","labels_url":"https://api.github.com/repos/conan-io/conan/milestones/3/labels","id":1506873,"number":3,"title":"0.7","description":null,"creator":{"login":"memsharded","id":15367152,"avatar_url":"https://avatars.githubusercontent.com/u/15367152?v=3","gravatar_id":"","url":"https://api.github.com/users/memsharded","html_url":"https://github.com/memsharded","followers_url":"https://api.github.com/users/memsharded/followers","following_url":"https://api.github.com/users/memsharded/following{/other_user}","gists_url":"https://api.github.com/users/memsharded/gists{/gist_id}","starred_url":"https://api.github.com/users/memsharded/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/memsharded/subscriptions","organizations_url":"https://api.github.com/users/memsharded/orgs","repos_url":"https://api.github.com/users/memsharded/repos","events_url":"https://api.github.com/users/memsharded/events{/privacy}","received_events_url":"https://api.github.com/users/memsharded/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":0,"state":"open","created_at":"2016-01-14T13:13:46Z","updated_at":"2016-01-21T15:03:23Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/conan-io/conan/pulls/107/commits","review_comments_url":"https://api.github.com/repos/conan-io/conan/pulls/107/comments","review_comment_url":"https://api.github.com/repos/conan-io/conan/pulls/comments{/number}","comments_url":"https://api.github.com/repos/conan-io/conan/issues/107/comments","statuses_url":"https://api.github.com/repos/conan-io/conan/statuses/4c7eb8a19b23ba2a17e9b34608ac7f8a3a3e739c","head":{"label":"dragly:qmake_like_cmake","ref":"qmake_like_cmake","sha":"4c7eb8a19b23ba2a17e9b34608ac7f8a3a3e739c","user":{"login":"dragly","id":220658,"avatar_url":"https://avatars.githubusercontent.com/u/220658?v=3","gravatar_id":"","url":"https://api.github.com/users/dragly","html_url":"https://github.com/dragly","followers_url":"https://api.github.com/users/dragly/followers","following_url":"https://api.github.com/users/dragly/following{/other_user}","gists_url":"https://api.github.com/users/dragly/gists{/gist_id}","starred_url":"https://api.github.com/users/dragly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dragly/subscriptions","organizations_url":"https://api.github.com/users/dragly/orgs","repos_url":"https://api.github.com/users/dragly/repos","events_url":"https://api.github.com/users/dragly/events{/privacy}","received_events_url":"https://api.github.com/users/dragly/received_events","type":"User","site_admin":false},"repo":{"id":48114654,"name":"conan","full_name":"dragly/conan","owner":{"login":"dragly","id":220658,"avatar_url":"https://avatars.githubusercontent.com/u/220658?v=3","gravatar_id":"","url":"https://api.github.com/users/dragly","html_url":"https://github.com/dragly","followers_url":"https://api.github.com/users/dragly/followers","following_url":"https://api.github.com/users/dragly/following{/other_user}","gists_url":"https://api.github.com/users/dragly/gists{/gist_id}","starred_url":"https://api.github.com/users/dragly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dragly/subscriptions","organizations_url":"https://api.github.com/users/dragly/orgs","repos_url":"https://api.github.com/users/dragly/repos","events_url":"https://api.github.com/users/dragly/events{/privacy}","received_events_url":"https://api.github.com/users/dragly/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dragly/conan","description":"Conan.io - The open-source C/C++ package manager","fork":true,"url":"https://api.github.com/repos/dragly/conan","forks_url":"https://api.github.com/repos/dragly/conan/forks","keys_url":"https://api.github.com/repos/dragly/conan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dragly/conan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dragly/conan/teams","hooks_url":"https://api.github.com/repos/dragly/conan/hooks","issue_events_url":"https://api.github.com/repos/dragly/conan/issues/events{/number}","events_url":"https://api.github.com/repos/dragly/conan/events","assignees_url":"https://api.github.com/repos/dragly/conan/assignees{/user}","branches_url":"https://api.github.com/repos/dragly/conan/branches{/branch}","tags_url":"https://api.github.com/repos/dragly/conan/tags","blobs_url":"https://api.github.com/repos/dragly/conan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dragly/conan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dragly/conan/git/refs{/sha}","trees_url":"https://api.github.com/repos/dragly/conan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dragly/conan/statuses/{sha}","languages_url":"https://api.github.com/repos/dragly/conan/languages","stargazers_url":"https://api.github.com/repos/dragly/conan/stargazers","contributors_url":"https://api.github.com/repos/dragly/conan/contributors","subscribers_url":"https://api.github.com/repos/dragly/conan/subscribers","subscription_url":"https://api.github.com/repos/dragly/conan/subscription","commits_url":"https://api.github.com/repos/dragly/conan/commits{/sha}","git_commits_url":"https://api.github.com/repos/dragly/conan/git/commits{/sha}","comments_url":"https://api.github.com/repos/dragly/conan/comments{/number}","issue_comment_url":"https://api.github.com/repos/dragly/conan/issues/comments{/number}","contents_url":"https://api.github.com/repos/dragly/conan/contents/{+path}","compare_url":"https://api.github.com/repos/dragly/conan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dragly/conan/merges","archive_url":"https://api.github.com/repos/dragly/conan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dragly/conan/downloads","issues_url":"https://api.github.com/repos/dragly/conan/issues{/number}","pulls_url":"https://api.github.com/repos/dragly/conan/pulls{/number}","milestones_url":"https://api.github.com/repos/dragly/conan/milestones{/number}","notifications_url":"https://api.github.com/repos/dragly/conan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dragly/conan/labels{/name}","releases_url":"https://api.github.com/repos/dragly/conan/releases{/id}","deployments_url":"https://api.github.com/repos/dragly/conan/deployments","created_at":"2015-12-16T14:20:10Z","updated_at":"2016-01-14T23:23:36Z","pushed_at":"2016-01-20T16:26:34Z","git_url":"git://github.com/dragly/conan.git","ssh_url":"git@github.com:dragly/conan.git","clone_url":"https://github.com/dragly/conan.git","svn_url":"https://github.com/dragly/conan","homepage":"https://conan.io","size":477,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"conan-io:develop","ref":"develop","sha":"f2a36d1d8684a336e56c30419ef5a868077f4429","user":{"login":"conan-io","id":15212165,"avatar_url":"https://avatars.githubusercontent.com/u/15212165?v=3","gravatar_id":"","url":"https://api.github.com/users/conan-io","html_url":"https://github.com/conan-io","followers_url":"https://api.github.com/users/conan-io/followers","following_url":"https://api.github.com/users/conan-io/following{/other_user}","gists_url":"https://api.github.com/users/conan-io/gists{/gist_id}","starred_url":"https://api.github.com/users/conan-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/conan-io/subscriptions","organizations_url":"https://api.github.com/users/conan-io/orgs","repos_url":"https://api.github.com/users/conan-io/repos","events_url":"https://api.github.com/users/conan-io/events{/privacy}","received_events_url":"https://api.github.com/users/conan-io/received_events","type":"Organization","site_admin":false},"repo":{"id":47190624,"name":"conan","full_name":"conan-io/conan","owner":{"login":"conan-io","id":15212165,"avatar_url":"https://avatars.githubusercontent.com/u/15212165?v=3","gravatar_id":"","url":"https://api.github.com/users/conan-io","html_url":"https://github.com/conan-io","followers_url":"https://api.github.com/users/conan-io/followers","following_url":"https://api.github.com/users/conan-io/following{/other_user}","gists_url":"https://api.github.com/users/conan-io/gists{/gist_id}","starred_url":"https://api.github.com/users/conan-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/conan-io/subscriptions","organizations_url":"https://api.github.com/users/conan-io/orgs","repos_url":"https://api.github.com/users/conan-io/repos","events_url":"https://api.github.com/users/conan-io/events{/privacy}","received_events_url":"https://api.github.com/users/conan-io/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/conan-io/conan","description":"Conan.io - The open-source C/C++ package manager","fork":false,"url":"https://api.github.com/repos/conan-io/conan","forks_url":"https://api.github.com/repos/conan-io/conan/forks","keys_url":"https://api.github.com/repos/conan-io/conan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/conan-io/conan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/conan-io/conan/teams","hooks_url":"https://api.github.com/repos/conan-io/conan/hooks","issue_events_url":"https://api.github.com/repos/conan-io/conan/issues/events{/number}","events_url":"https://api.github.com/repos/conan-io/conan/events","assignees_url":"https://api.github.com/repos/conan-io/conan/assignees{/user}","branches_url":"https://api.github.com/repos/conan-io/conan/branches{/branch}","tags_url":"https://api.github.com/repos/conan-io/conan/tags","blobs_url":"https://api.github.com/repos/conan-io/conan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/conan-io/conan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/conan-io/conan/git/refs{/sha}","trees_url":"https://api.github.com/repos/conan-io/conan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/conan-io/conan/statuses/{sha}","languages_url":"https://api.github.com/repos/conan-io/conan/languages","stargazers_url":"https://api.github.com/repos/conan-io/conan/stargazers","contributors_url":"https://api.github.com/repos/conan-io/conan/contributors","subscribers_url":"https://api.github.com/repos/conan-io/conan/subscribers","subscription_url":"https://api.github.com/repos/conan-io/conan/subscription","commits_url":"https://api.github.com/repos/conan-io/conan/commits{/sha}","git_commits_url":"https://api.github.com/repos/conan-io/conan/git/commits{/sha}","comments_url":"https://api.github.com/repos/conan-io/conan/comments{/number}","issue_comment_url":"https://api.github.com/repos/conan-io/conan/issues/comments{/number}","contents_url":"https://api.github.com/repos/conan-io/conan/contents/{+path}","compare_url":"https://api.github.com/repos/conan-io/conan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/conan-io/conan/merges","archive_url":"https://api.github.com/repos/conan-io/conan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/conan-io/conan/downloads","issues_url":"https://api.github.com/repos/conan-io/conan/issues{/number}","pulls_url":"https://api.github.com/repos/conan-io/conan/pulls{/number}","milestones_url":"https://api.github.com/repos/conan-io/conan/milestones{/number}","notifications_url":"https://api.github.com/repos/conan-io/conan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/conan-io/conan/labels{/name}","releases_url":"https://api.github.com/repos/conan-io/conan/releases{/id}","deployments_url":"https://api.github.com/repos/conan-io/conan/deployments","created_at":"2015-12-01T13:17:02Z","updated_at":"2016-01-21T19:39:24Z","pushed_at":"2016-01-25T07:35:04Z","git_url":"git://github.com/conan-io/conan.git","ssh_url":"git@github.com:conan-io/conan.git","clone_url":"https://github.com/conan-io/conan.git","svn_url":"https://github.com/conan-io/conan","homepage":"https://conan.io","size":497,"stargazers_count":233,"watchers_count":233,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"open_issues_count":37,"forks":24,"open_issues":37,"watchers":233,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/conan-io/conan/pulls/107"},"html":{"href":"https://github.com/conan-io/conan/pull/107"},"issue":{"href":"https://api.github.com/repos/conan-io/conan/issues/107"},"comments":{"href":"https://api.github.com/repos/conan-io/conan/issues/107/comments"},"review_comments":{"href":"https://api.github.com/repos/conan-io/conan/pulls/107/comments"},"review_comment":{"href":"https://api.github.com/repos/conan-io/conan/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/conan-io/conan/pulls/107/commits"},"statuses":{"href":"https://api.github.com/repos/conan-io/conan/statuses/4c7eb8a19b23ba2a17e9b34608ac7f8a3a3e739c"}}}}