{"action":"created","comment":{"url":"https://api.github.com/repos/google/material-design-lite/pulls/comments/67598432","id":67598432,"diff_hunk":"@@ -14,292 +14,186 @@\n  * limitations under the License.\n  */\n \n-@import \"../variables\";\n-@import \"../mixins\";\n-\n-// The button component. Defaults to a flat button.\n .mdl-button {\n-  background: transparent;\n+  min-height: 36px;\n   border: none;\n-  border-radius: $button-border-radius;\n-  color: $button-secondary-color;\n+  min-width: 88px;\n   position: relative;\n-  height: $button-height;\n-  margin: 0;\n-  min-width: $button-min-width;\n-  padding: 0 $button-padding;\n-  display: inline-block;\n-  @include typo-button();\n+  color: rgb(0, 0, 0);\n+  background: transparent;\n+  border-radius: 2px;\n+  /*\n+  Add 6 top and bottom padding.\n+  Provides 12 total for a 48px high touch area.\n+  */\n+  padding: 6px 16px;\n+  font-family: $performance-font;\n+  font-weight: 500;\n+  text-transform: uppercase;\n+  display: inline-flex;\n+  font-size: 0.875rem;","path":"src/button/_button.scss","position":41,"original_position":41,"commit_id":"dccf6eb8619b1de402f0e006882af67f06e2249a","original_commit_id":"dccf6eb8619b1de402f0e006882af67f06e2249a","user":{"login":"Garbee","id":868301,"avatar_url":"https://avatars.githubusercontent.com/u/868301?v=3","gravatar_id":"","url":"https://api.github.com/users/Garbee","html_url":"https://github.com/Garbee","followers_url":"https://api.github.com/users/Garbee/followers","following_url":"https://api.github.com/users/Garbee/following{/other_user}","gists_url":"https://api.github.com/users/Garbee/gists{/gist_id}","starred_url":"https://api.github.com/users/Garbee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Garbee/subscriptions","organizations_url":"https://api.github.com/users/Garbee/orgs","repos_url":"https://api.github.com/users/Garbee/repos","events_url":"https://api.github.com/users/Garbee/events{/privacy}","received_events_url":"https://api.github.com/users/Garbee/received_events","type":"User","site_admin":false},"body":"Let's do the comment for any rem calcs. That way we aren't relying on more preprocessing tooling. If we do got to another processor, we want to minimize what we do so everything can eventually \"just ship\", so that's the way to go.","created_at":"2016-06-18T09:38:48Z","updated_at":"2016-06-18T09:38:48Z","html_url":"https://github.com/google/material-design-lite/pull/4410#discussion_r67598432","pull_request_url":"https://api.github.com/repos/google/material-design-lite/pulls/4410","_links":{"self":{"href":"https://api.github.com/repos/google/material-design-lite/pulls/comments/67598432"},"html":{"href":"https://github.com/google/material-design-lite/pull/4410#discussion_r67598432"},"pull_request":{"href":"https://api.github.com/repos/google/material-design-lite/pulls/4410"}}},"pull_request":{"url":"https://api.github.com/repos/google/material-design-lite/pulls/4410","id":72955395,"html_url":"https://github.com/google/material-design-lite/pull/4410","diff_url":"https://github.com/google/material-design-lite/pull/4410.diff","patch_url":"https://github.com/google/material-design-lite/pull/4410.patch","issue_url":"https://api.github.com/repos/google/material-design-lite/issues/4410","number":4410,"state":"open","locked":false,"title":"Initial button split","user":{"login":"Garbee","id":868301,"avatar_url":"https://avatars.githubusercontent.com/u/868301?v=3","gravatar_id":"","url":"https://api.github.com/users/Garbee","html_url":"https://github.com/Garbee","followers_url":"https://api.github.com/users/Garbee/followers","following_url":"https://api.github.com/users/Garbee/following{/other_user}","gists_url":"https://api.github.com/users/Garbee/gists{/gist_id}","starred_url":"https://api.github.com/users/Garbee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Garbee/subscriptions","organizations_url":"https://api.github.com/users/Garbee/orgs","repos_url":"https://api.github.com/users/Garbee/repos","events_url":"https://api.github.com/users/Garbee/events{/privacy}","received_events_url":"https://api.github.com/users/Garbee/received_events","type":"User","site_admin":false},"body":"This is the initial pass at upgrading buttons and splitting into `button` and `fab` components.\r\n\r\n* Separated into `button` and `fab` components.\r\n* Removed button JS component\r\n* Dumped ripple things until we redo that component on its own.\r\n* `:focus:not(:active)` selector removed, not sure what use-case that was there to solve. Will add back in if the existing solution doesn't cover why it existed.\r\n* Updated snippets in button component to reflect current state.\r\n* Did not touch `_variables.scss` to remove unused variables. Since I'm not sure where else things may come into play and get used I'm willing to just leave them and dump as much of the file as we can at once.","created_at":"2016-06-07T21:55:15Z","updated_at":"2016-06-18T09:38:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"44c3cf774cdf953c96ede6631f9a1b058594a47e","assignee":null,"milestone":{"url":"https://api.github.com/repos/google/material-design-lite/milestones/6","html_url":"https://github.com/google/material-design-lite/milestones/V2","labels_url":"https://api.github.com/repos/google/material-design-lite/milestones/6/labels","id":1235462,"number":6,"title":"V2","description":"","creator":{"login":"addyosmani","id":110953,"avatar_url":"https://avatars.githubusercontent.com/u/110953?v=3","gravatar_id":"","url":"https://api.github.com/users/addyosmani","html_url":"https://github.com/addyosmani","followers_url":"https://api.github.com/users/addyosmani/followers","following_url":"https://api.github.com/users/addyosmani/following{/other_user}","gists_url":"https://api.github.com/users/addyosmani/gists{/gist_id}","starred_url":"https://api.github.com/users/addyosmani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/addyosmani/subscriptions","organizations_url":"https://api.github.com/users/addyosmani/orgs","repos_url":"https://api.github.com/users/addyosmani/repos","events_url":"https://api.github.com/users/addyosmani/events{/privacy}","received_events_url":"https://api.github.com/users/addyosmani/received_events","type":"User","site_admin":false},"open_issues":70,"closed_issues":19,"state":"open","created_at":"2015-07-31T17:16:39Z","updated_at":"2016-06-13T16:34:15Z","due_on":"2021-05-13T04:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/google/material-design-lite/pulls/4410/commits","review_comments_url":"https://api.github.com/repos/google/material-design-lite/pulls/4410/comments","review_comment_url":"https://api.github.com/repos/google/material-design-lite/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/material-design-lite/issues/4410/comments","statuses_url":"https://api.github.com/repos/google/material-design-lite/statuses/dccf6eb8619b1de402f0e006882af67f06e2249a","head":{"label":"google:garbee/buttons","ref":"garbee/buttons","sha":"dccf6eb8619b1de402f0e006882af67f06e2249a","user":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":29268051,"name":"material-design-lite","full_name":"google/material-design-lite","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/material-design-lite","description":"Material Design Components in HTML/CSS/JS","fork":false,"url":"https://api.github.com/repos/google/material-design-lite","forks_url":"https://api.github.com/repos/google/material-design-lite/forks","keys_url":"https://api.github.com/repos/google/material-design-lite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/material-design-lite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/material-design-lite/teams","hooks_url":"https://api.github.com/repos/google/material-design-lite/hooks","issue_events_url":"https://api.github.com/repos/google/material-design-lite/issues/events{/number}","events_url":"https://api.github.com/repos/google/material-design-lite/events","assignees_url":"https://api.github.com/repos/google/material-design-lite/assignees{/user}","branches_url":"https://api.github.com/repos/google/material-design-lite/branches{/branch}","tags_url":"https://api.github.com/repos/google/material-design-lite/tags","blobs_url":"https://api.github.com/repos/google/material-design-lite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/material-design-lite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/material-design-lite/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/material-design-lite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/material-design-lite/statuses/{sha}","languages_url":"https://api.github.com/repos/google/material-design-lite/languages","stargazers_url":"https://api.github.com/repos/google/material-design-lite/stargazers","contributors_url":"https://api.github.com/repos/google/material-design-lite/contributors","subscribers_url":"https://api.github.com/repos/google/material-design-lite/subscribers","subscription_url":"https://api.github.com/repos/google/material-design-lite/subscription","commits_url":"https://api.github.com/repos/google/material-design-lite/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/material-design-lite/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/material-design-lite/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/material-design-lite/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/material-design-lite/contents/{+path}","compare_url":"https://api.github.com/repos/google/material-design-lite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/material-design-lite/merges","archive_url":"https://api.github.com/repos/google/material-design-lite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/material-design-lite/downloads","issues_url":"https://api.github.com/repos/google/material-design-lite/issues{/number}","pulls_url":"https://api.github.com/repos/google/material-design-lite/pulls{/number}","milestones_url":"https://api.github.com/repos/google/material-design-lite/milestones{/number}","notifications_url":"https://api.github.com/repos/google/material-design-lite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/material-design-lite/labels{/name}","releases_url":"https://api.github.com/repos/google/material-design-lite/releases{/id}","deployments_url":"https://api.github.com/repos/google/material-design-lite/deployments","created_at":"2015-01-14T22:01:33Z","updated_at":"2016-06-18T07:21:45Z","pushed_at":"2016-06-17T17:26:44Z","git_url":"git://github.com/google/material-design-lite.git","ssh_url":"git@github.com:google/material-design-lite.git","clone_url":"https://github.com/google/material-design-lite.git","svn_url":"https://github.com/google/material-design-lite","homepage":"http://getmdl.io","size":61466,"stargazers_count":21452,"watchers_count":21452,"language":"HTML","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":3480,"mirror_url":null,"open_issues_count":403,"forks":3480,"open_issues":403,"watchers":21452,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"0e882804633a4b1ff34a0ac021b97da7015afd4a","user":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":29268051,"name":"material-design-lite","full_name":"google/material-design-lite","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/material-design-lite","description":"Material Design Components in HTML/CSS/JS","fork":false,"url":"https://api.github.com/repos/google/material-design-lite","forks_url":"https://api.github.com/repos/google/material-design-lite/forks","keys_url":"https://api.github.com/repos/google/material-design-lite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/material-design-lite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/material-design-lite/teams","hooks_url":"https://api.github.com/repos/google/material-design-lite/hooks","issue_events_url":"https://api.github.com/repos/google/material-design-lite/issues/events{/number}","events_url":"https://api.github.com/repos/google/material-design-lite/events","assignees_url":"https://api.github.com/repos/google/material-design-lite/assignees{/user}","branches_url":"https://api.github.com/repos/google/material-design-lite/branches{/branch}","tags_url":"https://api.github.com/repos/google/material-design-lite/tags","blobs_url":"https://api.github.com/repos/google/material-design-lite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/material-design-lite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/material-design-lite/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/material-design-lite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/material-design-lite/statuses/{sha}","languages_url":"https://api.github.com/repos/google/material-design-lite/languages","stargazers_url":"https://api.github.com/repos/google/material-design-lite/stargazers","contributors_url":"https://api.github.com/repos/google/material-design-lite/contributors","subscribers_url":"https://api.github.com/repos/google/material-design-lite/subscribers","subscription_url":"https://api.github.com/repos/google/material-design-lite/subscription","commits_url":"https://api.github.com/repos/google/material-design-lite/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/material-design-lite/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/material-design-lite/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/material-design-lite/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/material-design-lite/contents/{+path}","compare_url":"https://api.github.com/repos/google/material-design-lite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/material-design-lite/merges","archive_url":"https://api.github.com/repos/google/material-design-lite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/material-design-lite/downloads","issues_url":"https://api.github.com/repos/google/material-design-lite/issues{/number}","pulls_url":"https://api.github.com/repos/google/material-design-lite/pulls{/number}","milestones_url":"https://api.github.com/repos/google/material-design-lite/milestones{/number}","notifications_url":"https://api.github.com/repos/google/material-design-lite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/material-design-lite/labels{/name}","releases_url":"https://api.github.com/repos/google/material-design-lite/releases{/id}","deployments_url":"https://api.github.com/repos/google/material-design-lite/deployments","created_at":"2015-01-14T22:01:33Z","updated_at":"2016-06-18T07:21:45Z","pushed_at":"2016-06-17T17:26:44Z","git_url":"git://github.com/google/material-design-lite.git","ssh_url":"git@github.com:google/material-design-lite.git","clone_url":"https://github.com/google/material-design-lite.git","svn_url":"https://github.com/google/material-design-lite","homepage":"http://getmdl.io","size":61466,"stargazers_count":21452,"watchers_count":21452,"language":"HTML","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":3480,"mirror_url":null,"open_issues_count":403,"forks":3480,"open_issues":403,"watchers":21452,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/material-design-lite/pulls/4410"},"html":{"href":"https://github.com/google/material-design-lite/pull/4410"},"issue":{"href":"https://api.github.com/repos/google/material-design-lite/issues/4410"},"comments":{"href":"https://api.github.com/repos/google/material-design-lite/issues/4410/comments"},"review_comments":{"href":"https://api.github.com/repos/google/material-design-lite/pulls/4410/comments"},"review_comment":{"href":"https://api.github.com/repos/google/material-design-lite/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/material-design-lite/pulls/4410/commits"},"statuses":{"href":"https://api.github.com/repos/google/material-design-lite/statuses/dccf6eb8619b1de402f0e006882af67f06e2249a"}}}}
{"actor":{"display_login":"Garbee"}}