{"action":"opened","number":2442,"pull_request":{"url":"https://api.github.com/repos/doctrine/dbal/pulls/2442","id":76583892,"html_url":"https://github.com/doctrine/dbal/pull/2442","diff_url":"https://github.com/doctrine/dbal/pull/2442.diff","patch_url":"https://github.com/doctrine/dbal/pull/2442.patch","issue_url":"https://api.github.com/repos/doctrine/dbal/issues/2442","number":2442,"state":"open","locked":false,"title":"Escape identifiers in metadata SQL properly when used as string literal","user":{"login":"deeky666","id":1411514,"avatar_url":"https://avatars.githubusercontent.com/u/1411514?v=3","gravatar_id":"","url":"https://api.github.com/users/deeky666","html_url":"https://github.com/deeky666","followers_url":"https://api.github.com/users/deeky666/followers","following_url":"https://api.github.com/users/deeky666/following{/other_user}","gists_url":"https://api.github.com/users/deeky666/gists{/gist_id}","starred_url":"https://api.github.com/users/deeky666/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deeky666/subscriptions","organizations_url":"https://api.github.com/users/deeky666/orgs","repos_url":"https://api.github.com/users/deeky666/repos","events_url":"https://api.github.com/users/deeky666/events{/privacy}","received_events_url":"https://api.github.com/users/deeky666/received_events","type":"User","site_admin":false},"body":"Closes #2436\r\n\r\n@Ocramius I tried to write tests but neither of my approaches felt right. First I tried to `assertContains()` the resulting SQL but that is not applicable to all platforms and methods as the given identifiers to escape are not always used as string literals (heavily depends on the platform's SQL statement) or are not even used at all. Then I tried to write functional tests but that is problematic, too as I cannot test the `$database` identifiers properly on all platforms because that involves creating a database (which is heavy and not supported on all platforms) with escape characters in the name.\r\n\r\nAny idea what test to write here or should we take it \"as is\"?","created_at":"2016-07-07T12:07:13Z","updated_at":"2016-07-07T12:07:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/doctrine/dbal/milestones/50","html_url":"https://github.com/doctrine/dbal/milestones/2.5.5","labels_url":"https://api.github.com/repos/doctrine/dbal/milestones/50/labels","id":1486000,"number":50,"title":"2.5.5","description":"","creator":{"login":"Ocramius","id":154256,"avatar_url":"https://avatars.githubusercontent.com/u/154256?v=3","gravatar_id":"","url":"https://api.github.com/users/Ocramius","html_url":"https://github.com/Ocramius","followers_url":"https://api.github.com/users/Ocramius/followers","following_url":"https://api.github.com/users/Ocramius/following{/other_user}","gists_url":"https://api.github.com/users/Ocramius/gists{/gist_id}","starred_url":"https://api.github.com/users/Ocramius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ocramius/subscriptions","organizations_url":"https://api.github.com/users/Ocramius/orgs","repos_url":"https://api.github.com/users/Ocramius/repos","events_url":"https://api.github.com/users/Ocramius/events{/privacy}","received_events_url":"https://api.github.com/users/Ocramius/received_events","type":"User","site_admin":false},"open_issues":18,"closed_issues":21,"state":"open","created_at":"2016-01-05T21:59:07Z","updated_at":"2016-07-07T12:07:13Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/doctrine/dbal/pulls/2442/commits","review_comments_url":"https://api.github.com/repos/doctrine/dbal/pulls/2442/comments","review_comment_url":"https://api.github.com/repos/doctrine/dbal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/doctrine/dbal/issues/2442/comments","statuses_url":"https://api.github.com/repos/doctrine/dbal/statuses/71cd9d82938e35f9a26d763e0e5c8e64b9013cf6","head":{"label":"deeky666:DBAL-2436","ref":"DBAL-2436","sha":"71cd9d82938e35f9a26d763e0e5c8e64b9013cf6","user":{"login":"deeky666","id":1411514,"avatar_url":"https://avatars.githubusercontent.com/u/1411514?v=3","gravatar_id":"","url":"https://api.github.com/users/deeky666","html_url":"https://github.com/deeky666","followers_url":"https://api.github.com/users/deeky666/followers","following_url":"https://api.github.com/users/deeky666/following{/other_user}","gists_url":"https://api.github.com/users/deeky666/gists{/gist_id}","starred_url":"https://api.github.com/users/deeky666/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deeky666/subscriptions","organizations_url":"https://api.github.com/users/deeky666/orgs","repos_url":"https://api.github.com/users/deeky666/repos","events_url":"https://api.github.com/users/deeky666/events{/privacy}","received_events_url":"https://api.github.com/users/deeky666/received_events","type":"User","site_admin":false},"repo":{"id":7823057,"name":"dbal","full_name":"deeky666/dbal","owner":{"login":"deeky666","id":1411514,"avatar_url":"https://avatars.githubusercontent.com/u/1411514?v=3","gravatar_id":"","url":"https://api.github.com/users/deeky666","html_url":"https://github.com/deeky666","followers_url":"https://api.github.com/users/deeky666/followers","following_url":"https://api.github.com/users/deeky666/following{/other_user}","gists_url":"https://api.github.com/users/deeky666/gists{/gist_id}","starred_url":"https://api.github.com/users/deeky666/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deeky666/subscriptions","organizations_url":"https://api.github.com/users/deeky666/orgs","repos_url":"https://api.github.com/users/deeky666/repos","events_url":"https://api.github.com/users/deeky666/events{/privacy}","received_events_url":"https://api.github.com/users/deeky666/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/deeky666/dbal","description":"Doctrine Database Abstraction Layer","fork":true,"url":"https://api.github.com/repos/deeky666/dbal","forks_url":"https://api.github.com/repos/deeky666/dbal/forks","keys_url":"https://api.github.com/repos/deeky666/dbal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/deeky666/dbal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/deeky666/dbal/teams","hooks_url":"https://api.github.com/repos/deeky666/dbal/hooks","issue_events_url":"https://api.github.com/repos/deeky666/dbal/issues/events{/number}","events_url":"https://api.github.com/repos/deeky666/dbal/events","assignees_url":"https://api.github.com/repos/deeky666/dbal/assignees{/user}","branches_url":"https://api.github.com/repos/deeky666/dbal/branches{/branch}","tags_url":"https://api.github.com/repos/deeky666/dbal/tags","blobs_url":"https://api.github.com/repos/deeky666/dbal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/deeky666/dbal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/deeky666/dbal/git/refs{/sha}","trees_url":"https://api.github.com/repos/deeky666/dbal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/deeky666/dbal/statuses/{sha}","languages_url":"https://api.github.com/repos/deeky666/dbal/languages","stargazers_url":"https://api.github.com/repos/deeky666/dbal/stargazers","contributors_url":"https://api.github.com/repos/deeky666/dbal/contributors","subscribers_url":"https://api.github.com/repos/deeky666/dbal/subscribers","subscription_url":"https://api.github.com/repos/deeky666/dbal/subscription","commits_url":"https://api.github.com/repos/deeky666/dbal/commits{/sha}","git_commits_url":"https://api.github.com/repos/deeky666/dbal/git/commits{/sha}","comments_url":"https://api.github.com/repos/deeky666/dbal/comments{/number}","issue_comment_url":"https://api.github.com/repos/deeky666/dbal/issues/comments{/number}","contents_url":"https://api.github.com/repos/deeky666/dbal/contents/{+path}","compare_url":"https://api.github.com/repos/deeky666/dbal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/deeky666/dbal/merges","archive_url":"https://api.github.com/repos/deeky666/dbal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/deeky666/dbal/downloads","issues_url":"https://api.github.com/repos/deeky666/dbal/issues{/number}","pulls_url":"https://api.github.com/repos/deeky666/dbal/pulls{/number}","milestones_url":"https://api.github.com/repos/deeky666/dbal/milestones{/number}","notifications_url":"https://api.github.com/repos/deeky666/dbal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/deeky666/dbal/labels{/name}","releases_url":"https://api.github.com/repos/deeky666/dbal/releases{/id}","deployments_url":"https://api.github.com/repos/deeky666/dbal/deployments","created_at":"2013-01-25T15:47:53Z","updated_at":"2015-05-06T10:36:12Z","pushed_at":"2016-07-07T12:07:08Z","git_url":"git://github.com/deeky666/dbal.git","ssh_url":"git@github.com:deeky666/dbal.git","clone_url":"https://github.com/deeky666/dbal.git","svn_url":"https://github.com/deeky666/dbal","homepage":"http://www.doctrine-project.org/projects/dbal","size":24176,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"doctrine:master","ref":"master","sha":"69b57859c8674f2c8ba3798a2541ac18128a0bdb","user":{"login":"doctrine","id":209254,"avatar_url":"https://avatars.githubusercontent.com/u/209254?v=3","gravatar_id":"","url":"https://api.github.com/users/doctrine","html_url":"https://github.com/doctrine","followers_url":"https://api.github.com/users/doctrine/followers","following_url":"https://api.github.com/users/doctrine/following{/other_user}","gists_url":"https://api.github.com/users/doctrine/gists{/gist_id}","starred_url":"https://api.github.com/users/doctrine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doctrine/subscriptions","organizations_url":"https://api.github.com/users/doctrine/orgs","repos_url":"https://api.github.com/users/doctrine/repos","events_url":"https://api.github.com/users/doctrine/events{/privacy}","received_events_url":"https://api.github.com/users/doctrine/received_events","type":"Organization","site_admin":false},"repo":{"id":677464,"name":"dbal","full_name":"doctrine/dbal","owner":{"login":"doctrine","id":209254,"avatar_url":"https://avatars.githubusercontent.com/u/209254?v=3","gravatar_id":"","url":"https://api.github.com/users/doctrine","html_url":"https://github.com/doctrine","followers_url":"https://api.github.com/users/doctrine/followers","following_url":"https://api.github.com/users/doctrine/following{/other_user}","gists_url":"https://api.github.com/users/doctrine/gists{/gist_id}","starred_url":"https://api.github.com/users/doctrine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doctrine/subscriptions","organizations_url":"https://api.github.com/users/doctrine/orgs","repos_url":"https://api.github.com/users/doctrine/repos","events_url":"https://api.github.com/users/doctrine/events{/privacy}","received_events_url":"https://api.github.com/users/doctrine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/doctrine/dbal","description":"Doctrine Database Abstraction Layer","fork":false,"url":"https://api.github.com/repos/doctrine/dbal","forks_url":"https://api.github.com/repos/doctrine/dbal/forks","keys_url":"https://api.github.com/repos/doctrine/dbal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/doctrine/dbal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/doctrine/dbal/teams","hooks_url":"https://api.github.com/repos/doctrine/dbal/hooks","issue_events_url":"https://api.github.com/repos/doctrine/dbal/issues/events{/number}","events_url":"https://api.github.com/repos/doctrine/dbal/events","assignees_url":"https://api.github.com/repos/doctrine/dbal/assignees{/user}","branches_url":"https://api.github.com/repos/doctrine/dbal/branches{/branch}","tags_url":"https://api.github.com/repos/doctrine/dbal/tags","blobs_url":"https://api.github.com/repos/doctrine/dbal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/doctrine/dbal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/doctrine/dbal/git/refs{/sha}","trees_url":"https://api.github.com/repos/doctrine/dbal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/doctrine/dbal/statuses/{sha}","languages_url":"https://api.github.com/repos/doctrine/dbal/languages","stargazers_url":"https://api.github.com/repos/doctrine/dbal/stargazers","contributors_url":"https://api.github.com/repos/doctrine/dbal/contributors","subscribers_url":"https://api.github.com/repos/doctrine/dbal/subscribers","subscription_url":"https://api.github.com/repos/doctrine/dbal/subscription","commits_url":"https://api.github.com/repos/doctrine/dbal/commits{/sha}","git_commits_url":"https://api.github.com/repos/doctrine/dbal/git/commits{/sha}","comments_url":"https://api.github.com/repos/doctrine/dbal/comments{/number}","issue_comment_url":"https://api.github.com/repos/doctrine/dbal/issues/comments{/number}","contents_url":"https://api.github.com/repos/doctrine/dbal/contents/{+path}","compare_url":"https://api.github.com/repos/doctrine/dbal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/doctrine/dbal/merges","archive_url":"https://api.github.com/repos/doctrine/dbal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/doctrine/dbal/downloads","issues_url":"https://api.github.com/repos/doctrine/dbal/issues{/number}","pulls_url":"https://api.github.com/repos/doctrine/dbal/pulls{/number}","milestones_url":"https://api.github.com/repos/doctrine/dbal/milestones{/number}","notifications_url":"https://api.github.com/repos/doctrine/dbal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/doctrine/dbal/labels{/name}","releases_url":"https://api.github.com/repos/doctrine/dbal/releases{/id}","deployments_url":"https://api.github.com/repos/doctrine/dbal/deployments","created_at":"2010-05-20T17:01:42Z","updated_at":"2016-07-06T20:12:29Z","pushed_at":"2016-07-07T12:07:14Z","git_url":"git://github.com/doctrine/dbal.git","ssh_url":"git@github.com:doctrine/dbal.git","clone_url":"https://github.com/doctrine/dbal.git","svn_url":"https://github.com/doctrine/dbal","homepage":"http://www.doctrine-project.org/projects/dbal","size":27508,"stargazers_count":762,"watchers_count":762,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":644,"mirror_url":null,"open_issues_count":288,"forks":644,"open_issues":288,"watchers":762,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/doctrine/dbal/pulls/2442"},"html":{"href":"https://github.com/doctrine/dbal/pull/2442"},"issue":{"href":"https://api.github.com/repos/doctrine/dbal/issues/2442"},"comments":{"href":"https://api.github.com/repos/doctrine/dbal/issues/2442/comments"},"review_comments":{"href":"https://api.github.com/repos/doctrine/dbal/pulls/2442/comments"},"review_comment":{"href":"https://api.github.com/repos/doctrine/dbal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/doctrine/dbal/pulls/2442/commits"},"statuses":{"href":"https://api.github.com/repos/doctrine/dbal/statuses/71cd9d82938e35f9a26d763e0e5c8e64b9013cf6"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":101,"deletions":34,"changed_files":8}}
{"actor":{"display_login":"deeky666"}}