{"action":"closed","number":10013,"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/10013","id":96134658,"html_url":"https://github.com/nodejs/node/pull/10013","diff_url":"https://github.com/nodejs/node/pull/10013.diff","patch_url":"https://github.com/nodejs/node/pull/10013.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/10013","number":10013,"state":"closed","locked":false,"title":"test: update test-tls-alert-handling.js","user":{"login":"paulcamantigue","id":1848673,"avatar_url":"https://avatars.githubusercontent.com/u/1848673?v=3","gravatar_id":"","url":"https://api.github.com/users/paulcamantigue","html_url":"https://github.com/paulcamantigue","followers_url":"https://api.github.com/users/paulcamantigue/followers","following_url":"https://api.github.com/users/paulcamantigue/following{/other_user}","gists_url":"https://api.github.com/users/paulcamantigue/gists{/gist_id}","starred_url":"https://api.github.com/users/paulcamantigue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulcamantigue/subscriptions","organizations_url":"https://api.github.com/users/paulcamantigue/orgs","repos_url":"https://api.github.com/users/paulcamantigue/repos","events_url":"https://api.github.com/users/paulcamantigue/events{/privacy}","received_events_url":"https://api.github.com/users/paulcamantigue/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you for your pull request. Please review below requirements.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j8 test` (UNIX), or `vcbuild test nosign` (Windows) passes\r\n- [x] commit message follows commit guidelines\r\n\r\n##### Affected core subsystem(s)\r\ntest\r\n\r\n##### Description of change\r\n\r\n* var —> const / let\r\n* common.mustCall(*, n) for functions that need to be called exactly n\r\ntimes","created_at":"2016-12-01T17:32:25Z","updated_at":"2017-01-01T03:43:20Z","closed_at":"2017-01-01T03:43:20Z","merged_at":null,"merge_commit_sha":"c696f0f27258553947c1df144c28f998cfeb63e3","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/10013/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/10013/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/10013/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/303088628f0665fd589dfe190ed792f393ab03c9","head":{"label":"paulcamantigue:update-test-parallel-tls-alert-handling","ref":"update-test-parallel-tls-alert-handling","sha":"303088628f0665fd589dfe190ed792f393ab03c9","user":{"login":"paulcamantigue","id":1848673,"avatar_url":"https://avatars.githubusercontent.com/u/1848673?v=3","gravatar_id":"","url":"https://api.github.com/users/paulcamantigue","html_url":"https://github.com/paulcamantigue","followers_url":"https://api.github.com/users/paulcamantigue/followers","following_url":"https://api.github.com/users/paulcamantigue/following{/other_user}","gists_url":"https://api.github.com/users/paulcamantigue/gists{/gist_id}","starred_url":"https://api.github.com/users/paulcamantigue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulcamantigue/subscriptions","organizations_url":"https://api.github.com/users/paulcamantigue/orgs","repos_url":"https://api.github.com/users/paulcamantigue/repos","events_url":"https://api.github.com/users/paulcamantigue/events{/privacy}","received_events_url":"https://api.github.com/users/paulcamantigue/received_events","type":"User","site_admin":false},"repo":{"id":75315125,"name":"node","full_name":"paulcamantigue/node","owner":{"login":"paulcamantigue","id":1848673,"avatar_url":"https://avatars.githubusercontent.com/u/1848673?v=3","gravatar_id":"","url":"https://api.github.com/users/paulcamantigue","html_url":"https://github.com/paulcamantigue","followers_url":"https://api.github.com/users/paulcamantigue/followers","following_url":"https://api.github.com/users/paulcamantigue/following{/other_user}","gists_url":"https://api.github.com/users/paulcamantigue/gists{/gist_id}","starred_url":"https://api.github.com/users/paulcamantigue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulcamantigue/subscriptions","organizations_url":"https://api.github.com/users/paulcamantigue/orgs","repos_url":"https://api.github.com/users/paulcamantigue/repos","events_url":"https://api.github.com/users/paulcamantigue/events{/privacy}","received_events_url":"https://api.github.com/users/paulcamantigue/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/paulcamantigue/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":true,"url":"https://api.github.com/repos/paulcamantigue/node","forks_url":"https://api.github.com/repos/paulcamantigue/node/forks","keys_url":"https://api.github.com/repos/paulcamantigue/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paulcamantigue/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paulcamantigue/node/teams","hooks_url":"https://api.github.com/repos/paulcamantigue/node/hooks","issue_events_url":"https://api.github.com/repos/paulcamantigue/node/issues/events{/number}","events_url":"https://api.github.com/repos/paulcamantigue/node/events","assignees_url":"https://api.github.com/repos/paulcamantigue/node/assignees{/user}","branches_url":"https://api.github.com/repos/paulcamantigue/node/branches{/branch}","tags_url":"https://api.github.com/repos/paulcamantigue/node/tags","blobs_url":"https://api.github.com/repos/paulcamantigue/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paulcamantigue/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paulcamantigue/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/paulcamantigue/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paulcamantigue/node/statuses/{sha}","languages_url":"https://api.github.com/repos/paulcamantigue/node/languages","stargazers_url":"https://api.github.com/repos/paulcamantigue/node/stargazers","contributors_url":"https://api.github.com/repos/paulcamantigue/node/contributors","subscribers_url":"https://api.github.com/repos/paulcamantigue/node/subscribers","subscription_url":"https://api.github.com/repos/paulcamantigue/node/subscription","commits_url":"https://api.github.com/repos/paulcamantigue/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/paulcamantigue/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/paulcamantigue/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/paulcamantigue/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/paulcamantigue/node/contents/{+path}","compare_url":"https://api.github.com/repos/paulcamantigue/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paulcamantigue/node/merges","archive_url":"https://api.github.com/repos/paulcamantigue/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paulcamantigue/node/downloads","issues_url":"https://api.github.com/repos/paulcamantigue/node/issues{/number}","pulls_url":"https://api.github.com/repos/paulcamantigue/node/pulls{/number}","milestones_url":"https://api.github.com/repos/paulcamantigue/node/milestones{/number}","notifications_url":"https://api.github.com/repos/paulcamantigue/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paulcamantigue/node/labels{/name}","releases_url":"https://api.github.com/repos/paulcamantigue/node/releases{/id}","deployments_url":"https://api.github.com/repos/paulcamantigue/node/deployments","created_at":"2016-12-01T17:16:02Z","updated_at":"2016-12-01T17:16:28Z","pushed_at":"2016-12-01T17:42:23Z","git_url":"git://github.com/paulcamantigue/node.git","ssh_url":"git@github.com:paulcamantigue/node.git","clone_url":"https://github.com/paulcamantigue/node.git","svn_url":"https://github.com/paulcamantigue/node","homepage":"https://nodejs.org","size":247159,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"ca82f72b31dda754693d4e008ed7bafda7dcea31","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2017-01-01T02:22:59Z","pushed_at":"2017-01-01T02:53:29Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":250582,"stargazers_count":30266,"watchers_count":30266,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5452,"mirror_url":null,"open_issues_count":1017,"forks":5452,"open_issues":1017,"watchers":30266,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/10013"},"html":{"href":"https://github.com/nodejs/node/pull/10013"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/10013"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/10013/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/10013/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/10013/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/303088628f0665fd589dfe190ed792f393ab03c9"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":4,"review_comments":6,"maintainer_can_modify":false,"commits":1,"additions":16,"deletions":17,"changed_files":1}}
{"actor":{"display_login":"Trott"}}