{"action":"created","comment":{"url":"https://api.github.com/repos/astropy/astropy/pulls/comments/70823552","id":70823552,"diff_hunk":"@@ -312,6 +312,9 @@ def convolve_fft(array, kernel, boundary='fill', fill_value=0, crop=True,\n         256.\n     quiet : bool, optional\n         Silence warning message about NaN interpolation\n+    normalized_epsilon: float, optional\n+        The upper limit on the deviation of the kernel sum with respect to unity.\n+        Will be checked only if normalize_kernel is False.","path":"astropy/convolution/convolve.py","position":17,"original_position":17,"commit_id":"1f3b9a6d7b394ea2a28dc7948032172dd4db5f10","original_commit_id":"1f3b9a6d7b394ea2a28dc7948032172dd4db5f10","user":{"login":"pllim","id":2090236,"avatar_url":"https://avatars.githubusercontent.com/u/2090236?v=3","gravatar_id":"","url":"https://api.github.com/users/pllim","html_url":"https://github.com/pllim","followers_url":"https://api.github.com/users/pllim/followers","following_url":"https://api.github.com/users/pllim/following{/other_user}","gists_url":"https://api.github.com/users/pllim/gists{/gist_id}","starred_url":"https://api.github.com/users/pllim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pllim/subscriptions","organizations_url":"https://api.github.com/users/pllim/orgs","repos_url":"https://api.github.com/users/pllim/repos","events_url":"https://api.github.com/users/pllim/events{/privacy}","received_events_url":"https://api.github.com/users/pllim/received_events","type":"User","site_admin":false},"body":"This is more of an API change.","created_at":"2016-07-14T15:11:22Z","updated_at":"2016-07-14T15:11:22Z","html_url":"https://github.com/astropy/astropy/pull/5177#discussion_r70823552","pull_request_url":"https://api.github.com/repos/astropy/astropy/pulls/5177","_links":{"self":{"href":"https://api.github.com/repos/astropy/astropy/pulls/comments/70823552"},"html":{"href":"https://github.com/astropy/astropy/pull/5177#discussion_r70823552"},"pull_request":{"href":"https://api.github.com/repos/astropy/astropy/pulls/5177"}}},"pull_request":{"url":"https://api.github.com/repos/astropy/astropy/pulls/5177","id":77467570,"html_url":"https://github.com/astropy/astropy/pull/5177","diff_url":"https://github.com/astropy/astropy/pull/5177.diff","patch_url":"https://github.com/astropy/astropy/pull/5177.patch","issue_url":"https://api.github.com/repos/astropy/astropy/issues/5177","number":5177,"state":"open","locked":false,"title":"Added normalized_epsilon as a parameter to convolve_fft","user":{"login":"samverstocken","id":8166580,"avatar_url":"https://avatars.githubusercontent.com/u/8166580?v=3","gravatar_id":"","url":"https://api.github.com/users/samverstocken","html_url":"https://github.com/samverstocken","followers_url":"https://api.github.com/users/samverstocken/followers","following_url":"https://api.github.com/users/samverstocken/following{/other_user}","gists_url":"https://api.github.com/users/samverstocken/gists{/gist_id}","starred_url":"https://api.github.com/users/samverstocken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samverstocken/subscriptions","organizations_url":"https://api.github.com/users/samverstocken/orgs","repos_url":"https://api.github.com/users/samverstocken/repos","events_url":"https://api.github.com/users/samverstocken/events{/privacy}","received_events_url":"https://api.github.com/users/samverstocken/received_events","type":"User","site_admin":false},"body":"This allows the user of convolve_fft to choose the upper limit of deviation between the kernel sum and unity, so that it can for example be adjusted for the specific floating-point precision of the kernel array","created_at":"2016-07-14T14:40:06Z","updated_at":"2016-07-14T15:11:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a0777556d872e5dc8b257b6471580e385251fdd1","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/astropy/astropy/milestones/38","html_url":"https://github.com/astropy/astropy/milestones/v1.3.0","labels_url":"https://api.github.com/repos/astropy/astropy/milestones/38/labels","id":1761583,"number":38,"title":"v1.3.0","description":"","creator":{"login":"eteq","id":346587,"avatar_url":"https://avatars.githubusercontent.com/u/346587?v=3","gravatar_id":"","url":"https://api.github.com/users/eteq","html_url":"https://github.com/eteq","followers_url":"https://api.github.com/users/eteq/followers","following_url":"https://api.github.com/users/eteq/following{/other_user}","gists_url":"https://api.github.com/users/eteq/gists{/gist_id}","starred_url":"https://api.github.com/users/eteq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eteq/subscriptions","organizations_url":"https://api.github.com/users/eteq/orgs","repos_url":"https://api.github.com/users/eteq/repos","events_url":"https://api.github.com/users/eteq/events{/privacy}","received_events_url":"https://api.github.com/users/eteq/received_events","type":"User","site_admin":false},"open_issues":19,"closed_issues":22,"state":"open","created_at":"2016-05-12T04:39:02Z","updated_at":"2016-07-14T14:57:47Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/astropy/astropy/pulls/5177/commits","review_comments_url":"https://api.github.com/repos/astropy/astropy/pulls/5177/comments","review_comment_url":"https://api.github.com/repos/astropy/astropy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/astropy/astropy/issues/5177/comments","statuses_url":"https://api.github.com/repos/astropy/astropy/statuses/1f3b9a6d7b394ea2a28dc7948032172dd4db5f10","head":{"label":"samverstocken:convolve_fft_epsilon","ref":"convolve_fft_epsilon","sha":"1f3b9a6d7b394ea2a28dc7948032172dd4db5f10","user":{"login":"samverstocken","id":8166580,"avatar_url":"https://avatars.githubusercontent.com/u/8166580?v=3","gravatar_id":"","url":"https://api.github.com/users/samverstocken","html_url":"https://github.com/samverstocken","followers_url":"https://api.github.com/users/samverstocken/followers","following_url":"https://api.github.com/users/samverstocken/following{/other_user}","gists_url":"https://api.github.com/users/samverstocken/gists{/gist_id}","starred_url":"https://api.github.com/users/samverstocken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samverstocken/subscriptions","organizations_url":"https://api.github.com/users/samverstocken/orgs","repos_url":"https://api.github.com/users/samverstocken/repos","events_url":"https://api.github.com/users/samverstocken/events{/privacy}","received_events_url":"https://api.github.com/users/samverstocken/received_events","type":"User","site_admin":false},"repo":{"id":63342898,"name":"astropy","full_name":"samverstocken/astropy","owner":{"login":"samverstocken","id":8166580,"avatar_url":"https://avatars.githubusercontent.com/u/8166580?v=3","gravatar_id":"","url":"https://api.github.com/users/samverstocken","html_url":"https://github.com/samverstocken","followers_url":"https://api.github.com/users/samverstocken/followers","following_url":"https://api.github.com/users/samverstocken/following{/other_user}","gists_url":"https://api.github.com/users/samverstocken/gists{/gist_id}","starred_url":"https://api.github.com/users/samverstocken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samverstocken/subscriptions","organizations_url":"https://api.github.com/users/samverstocken/orgs","repos_url":"https://api.github.com/users/samverstocken/repos","events_url":"https://api.github.com/users/samverstocken/events{/privacy}","received_events_url":"https://api.github.com/users/samverstocken/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/samverstocken/astropy","description":"Repository for the Astropy core package","fork":true,"url":"https://api.github.com/repos/samverstocken/astropy","forks_url":"https://api.github.com/repos/samverstocken/astropy/forks","keys_url":"https://api.github.com/repos/samverstocken/astropy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/samverstocken/astropy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/samverstocken/astropy/teams","hooks_url":"https://api.github.com/repos/samverstocken/astropy/hooks","issue_events_url":"https://api.github.com/repos/samverstocken/astropy/issues/events{/number}","events_url":"https://api.github.com/repos/samverstocken/astropy/events","assignees_url":"https://api.github.com/repos/samverstocken/astropy/assignees{/user}","branches_url":"https://api.github.com/repos/samverstocken/astropy/branches{/branch}","tags_url":"https://api.github.com/repos/samverstocken/astropy/tags","blobs_url":"https://api.github.com/repos/samverstocken/astropy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/samverstocken/astropy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/samverstocken/astropy/git/refs{/sha}","trees_url":"https://api.github.com/repos/samverstocken/astropy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/samverstocken/astropy/statuses/{sha}","languages_url":"https://api.github.com/repos/samverstocken/astropy/languages","stargazers_url":"https://api.github.com/repos/samverstocken/astropy/stargazers","contributors_url":"https://api.github.com/repos/samverstocken/astropy/contributors","subscribers_url":"https://api.github.com/repos/samverstocken/astropy/subscribers","subscription_url":"https://api.github.com/repos/samverstocken/astropy/subscription","commits_url":"https://api.github.com/repos/samverstocken/astropy/commits{/sha}","git_commits_url":"https://api.github.com/repos/samverstocken/astropy/git/commits{/sha}","comments_url":"https://api.github.com/repos/samverstocken/astropy/comments{/number}","issue_comment_url":"https://api.github.com/repos/samverstocken/astropy/issues/comments{/number}","contents_url":"https://api.github.com/repos/samverstocken/astropy/contents/{+path}","compare_url":"https://api.github.com/repos/samverstocken/astropy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/samverstocken/astropy/merges","archive_url":"https://api.github.com/repos/samverstocken/astropy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/samverstocken/astropy/downloads","issues_url":"https://api.github.com/repos/samverstocken/astropy/issues{/number}","pulls_url":"https://api.github.com/repos/samverstocken/astropy/pulls{/number}","milestones_url":"https://api.github.com/repos/samverstocken/astropy/milestones{/number}","notifications_url":"https://api.github.com/repos/samverstocken/astropy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/samverstocken/astropy/labels{/name}","releases_url":"https://api.github.com/repos/samverstocken/astropy/releases{/id}","deployments_url":"https://api.github.com/repos/samverstocken/astropy/deployments","created_at":"2016-07-14T14:21:43Z","updated_at":"2016-07-14T14:21:49Z","pushed_at":"2016-07-14T14:36:26Z","git_url":"git://github.com/samverstocken/astropy.git","ssh_url":"git@github.com:samverstocken/astropy.git","clone_url":"https://github.com/samverstocken/astropy.git","svn_url":"https://github.com/samverstocken/astropy","homepage":"www.astropy.org","size":68403,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"astropy:master","ref":"master","sha":"9ca9e9b3b4b5b23975f0b8d1c4aa016eb4246eb6","user":{"login":"astropy","id":847984,"avatar_url":"https://avatars.githubusercontent.com/u/847984?v=3","gravatar_id":"","url":"https://api.github.com/users/astropy","html_url":"https://github.com/astropy","followers_url":"https://api.github.com/users/astropy/followers","following_url":"https://api.github.com/users/astropy/following{/other_user}","gists_url":"https://api.github.com/users/astropy/gists{/gist_id}","starred_url":"https://api.github.com/users/astropy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astropy/subscriptions","organizations_url":"https://api.github.com/users/astropy/orgs","repos_url":"https://api.github.com/users/astropy/repos","events_url":"https://api.github.com/users/astropy/events{/privacy}","received_events_url":"https://api.github.com/users/astropy/received_events","type":"Organization","site_admin":false},"repo":{"id":2081289,"name":"astropy","full_name":"astropy/astropy","owner":{"login":"astropy","id":847984,"avatar_url":"https://avatars.githubusercontent.com/u/847984?v=3","gravatar_id":"","url":"https://api.github.com/users/astropy","html_url":"https://github.com/astropy","followers_url":"https://api.github.com/users/astropy/followers","following_url":"https://api.github.com/users/astropy/following{/other_user}","gists_url":"https://api.github.com/users/astropy/gists{/gist_id}","starred_url":"https://api.github.com/users/astropy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astropy/subscriptions","organizations_url":"https://api.github.com/users/astropy/orgs","repos_url":"https://api.github.com/users/astropy/repos","events_url":"https://api.github.com/users/astropy/events{/privacy}","received_events_url":"https://api.github.com/users/astropy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/astropy/astropy","description":"Repository for the Astropy core package","fork":false,"url":"https://api.github.com/repos/astropy/astropy","forks_url":"https://api.github.com/repos/astropy/astropy/forks","keys_url":"https://api.github.com/repos/astropy/astropy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/astropy/astropy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/astropy/astropy/teams","hooks_url":"https://api.github.com/repos/astropy/astropy/hooks","issue_events_url":"https://api.github.com/repos/astropy/astropy/issues/events{/number}","events_url":"https://api.github.com/repos/astropy/astropy/events","assignees_url":"https://api.github.com/repos/astropy/astropy/assignees{/user}","branches_url":"https://api.github.com/repos/astropy/astropy/branches{/branch}","tags_url":"https://api.github.com/repos/astropy/astropy/tags","blobs_url":"https://api.github.com/repos/astropy/astropy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/astropy/astropy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/astropy/astropy/git/refs{/sha}","trees_url":"https://api.github.com/repos/astropy/astropy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/astropy/astropy/statuses/{sha}","languages_url":"https://api.github.com/repos/astropy/astropy/languages","stargazers_url":"https://api.github.com/repos/astropy/astropy/stargazers","contributors_url":"https://api.github.com/repos/astropy/astropy/contributors","subscribers_url":"https://api.github.com/repos/astropy/astropy/subscribers","subscription_url":"https://api.github.com/repos/astropy/astropy/subscription","commits_url":"https://api.github.com/repos/astropy/astropy/commits{/sha}","git_commits_url":"https://api.github.com/repos/astropy/astropy/git/commits{/sha}","comments_url":"https://api.github.com/repos/astropy/astropy/comments{/number}","issue_comment_url":"https://api.github.com/repos/astropy/astropy/issues/comments{/number}","contents_url":"https://api.github.com/repos/astropy/astropy/contents/{+path}","compare_url":"https://api.github.com/repos/astropy/astropy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/astropy/astropy/merges","archive_url":"https://api.github.com/repos/astropy/astropy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/astropy/astropy/downloads","issues_url":"https://api.github.com/repos/astropy/astropy/issues{/number}","pulls_url":"https://api.github.com/repos/astropy/astropy/pulls{/number}","milestones_url":"https://api.github.com/repos/astropy/astropy/milestones{/number}","notifications_url":"https://api.github.com/repos/astropy/astropy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/astropy/astropy/labels{/name}","releases_url":"https://api.github.com/repos/astropy/astropy/releases{/id}","deployments_url":"https://api.github.com/repos/astropy/astropy/deployments","created_at":"2011-07-21T01:33:49Z","updated_at":"2016-07-14T14:21:41Z","pushed_at":"2016-07-14T14:40:06Z","git_url":"git://github.com/astropy/astropy.git","ssh_url":"git@github.com:astropy/astropy.git","clone_url":"https://github.com/astropy/astropy.git","svn_url":"https://github.com/astropy/astropy","homepage":"www.astropy.org","size":68403,"stargazers_count":889,"watchers_count":889,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":566,"mirror_url":null,"open_issues_count":741,"forks":566,"open_issues":741,"watchers":889,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/astropy/astropy/pulls/5177"},"html":{"href":"https://github.com/astropy/astropy/pull/5177"},"issue":{"href":"https://api.github.com/repos/astropy/astropy/issues/5177"},"comments":{"href":"https://api.github.com/repos/astropy/astropy/issues/5177/comments"},"review_comments":{"href":"https://api.github.com/repos/astropy/astropy/pulls/5177/comments"},"review_comment":{"href":"https://api.github.com/repos/astropy/astropy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/astropy/astropy/pulls/5177/commits"},"statuses":{"href":"https://api.github.com/repos/astropy/astropy/statuses/1f3b9a6d7b394ea2a28dc7948032172dd4db5f10"}}}}
{"actor":{"display_login":"pllim"}}