{"action":"opened","number":188,"pull_request":{"url":"https://api.github.com/repos/trustedsec/ptf/pulls/188","id":78728660,"html_url":"https://github.com/trustedsec/ptf/pull/188","diff_url":"https://github.com/trustedsec/ptf/pull/188.diff","patch_url":"https://github.com/trustedsec/ptf/pull/188.patch","issue_url":"https://api.github.com/repos/trustedsec/ptf/issues/188","number":188,"state":"open","locked":false,"title":"check to see if install_location has files to determine if git pull should be run.","user":{"login":"jaredhaight","id":1220886,"avatar_url":"https://avatars.githubusercontent.com/u/1220886?v=3","gravatar_id":"","url":"https://api.github.com/users/jaredhaight","html_url":"https://github.com/jaredhaight","followers_url":"https://api.github.com/users/jaredhaight/followers","following_url":"https://api.github.com/users/jaredhaight/following{/other_user}","gists_url":"https://api.github.com/users/jaredhaight/gists{/gist_id}","starred_url":"https://api.github.com/users/jaredhaight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaredhaight/subscriptions","organizations_url":"https://api.github.com/users/jaredhaight/orgs","repos_url":"https://api.github.com/users/jaredhaight/repos","events_url":"https://api.github.com/users/jaredhaight/events{/privacy}","received_events_url":"https://api.github.com/users/jaredhaight/received_events","type":"User","site_admin":false},"body":"There's an issue with [the recent check to see if a programs folder exists](https://github.com/trustedsec/ptf/blob/master/src/framework.py#L377) to determine if \"git pull\" or \"git clone\" should be run.  [The step above that](https://github.com/trustedsec/ptf/blob/master/src/framework.py#L369) creates the folder for the program, so the check is always going to be true, essentially breaking new installs for tools when using git.\r\n\r\nThis PR fixes this by changing the check to use `os.listdir` instead of `os.path.isdir`. os.listdir will return false if the directory is empty (and true if it is not). ","created_at":"2016-07-25T18:27:25Z","updated_at":"2016-07-25T18:27:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/trustedsec/ptf/pulls/188/commits","review_comments_url":"https://api.github.com/repos/trustedsec/ptf/pulls/188/comments","review_comment_url":"https://api.github.com/repos/trustedsec/ptf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/trustedsec/ptf/issues/188/comments","statuses_url":"https://api.github.com/repos/trustedsec/ptf/statuses/f71129662cbd5698bb20488e57fd1616e0e25173","head":{"label":"jaredhaight:fix-git-pull","ref":"fix-git-pull","sha":"f71129662cbd5698bb20488e57fd1616e0e25173","user":{"login":"jaredhaight","id":1220886,"avatar_url":"https://avatars.githubusercontent.com/u/1220886?v=3","gravatar_id":"","url":"https://api.github.com/users/jaredhaight","html_url":"https://github.com/jaredhaight","followers_url":"https://api.github.com/users/jaredhaight/followers","following_url":"https://api.github.com/users/jaredhaight/following{/other_user}","gists_url":"https://api.github.com/users/jaredhaight/gists{/gist_id}","starred_url":"https://api.github.com/users/jaredhaight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaredhaight/subscriptions","organizations_url":"https://api.github.com/users/jaredhaight/orgs","repos_url":"https://api.github.com/users/jaredhaight/repos","events_url":"https://api.github.com/users/jaredhaight/events{/privacy}","received_events_url":"https://api.github.com/users/jaredhaight/received_events","type":"User","site_admin":false},"repo":{"id":40273589,"name":"ptf","full_name":"jaredhaight/ptf","owner":{"login":"jaredhaight","id":1220886,"avatar_url":"https://avatars.githubusercontent.com/u/1220886?v=3","gravatar_id":"","url":"https://api.github.com/users/jaredhaight","html_url":"https://github.com/jaredhaight","followers_url":"https://api.github.com/users/jaredhaight/followers","following_url":"https://api.github.com/users/jaredhaight/following{/other_user}","gists_url":"https://api.github.com/users/jaredhaight/gists{/gist_id}","starred_url":"https://api.github.com/users/jaredhaight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaredhaight/subscriptions","organizations_url":"https://api.github.com/users/jaredhaight/orgs","repos_url":"https://api.github.com/users/jaredhaight/repos","events_url":"https://api.github.com/users/jaredhaight/events{/privacy}","received_events_url":"https://api.github.com/users/jaredhaight/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jaredhaight/ptf","description":"The Penetration Testers Framework (PTF) is a way for modular support for up-to-date tools.","fork":true,"url":"https://api.github.com/repos/jaredhaight/ptf","forks_url":"https://api.github.com/repos/jaredhaight/ptf/forks","keys_url":"https://api.github.com/repos/jaredhaight/ptf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jaredhaight/ptf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jaredhaight/ptf/teams","hooks_url":"https://api.github.com/repos/jaredhaight/ptf/hooks","issue_events_url":"https://api.github.com/repos/jaredhaight/ptf/issues/events{/number}","events_url":"https://api.github.com/repos/jaredhaight/ptf/events","assignees_url":"https://api.github.com/repos/jaredhaight/ptf/assignees{/user}","branches_url":"https://api.github.com/repos/jaredhaight/ptf/branches{/branch}","tags_url":"https://api.github.com/repos/jaredhaight/ptf/tags","blobs_url":"https://api.github.com/repos/jaredhaight/ptf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jaredhaight/ptf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jaredhaight/ptf/git/refs{/sha}","trees_url":"https://api.github.com/repos/jaredhaight/ptf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jaredhaight/ptf/statuses/{sha}","languages_url":"https://api.github.com/repos/jaredhaight/ptf/languages","stargazers_url":"https://api.github.com/repos/jaredhaight/ptf/stargazers","contributors_url":"https://api.github.com/repos/jaredhaight/ptf/contributors","subscribers_url":"https://api.github.com/repos/jaredhaight/ptf/subscribers","subscription_url":"https://api.github.com/repos/jaredhaight/ptf/subscription","commits_url":"https://api.github.com/repos/jaredhaight/ptf/commits{/sha}","git_commits_url":"https://api.github.com/repos/jaredhaight/ptf/git/commits{/sha}","comments_url":"https://api.github.com/repos/jaredhaight/ptf/comments{/number}","issue_comment_url":"https://api.github.com/repos/jaredhaight/ptf/issues/comments{/number}","contents_url":"https://api.github.com/repos/jaredhaight/ptf/contents/{+path}","compare_url":"https://api.github.com/repos/jaredhaight/ptf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jaredhaight/ptf/merges","archive_url":"https://api.github.com/repos/jaredhaight/ptf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jaredhaight/ptf/downloads","issues_url":"https://api.github.com/repos/jaredhaight/ptf/issues{/number}","pulls_url":"https://api.github.com/repos/jaredhaight/ptf/pulls{/number}","milestones_url":"https://api.github.com/repos/jaredhaight/ptf/milestones{/number}","notifications_url":"https://api.github.com/repos/jaredhaight/ptf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jaredhaight/ptf/labels{/name}","releases_url":"https://api.github.com/repos/jaredhaight/ptf/releases{/id}","deployments_url":"https://api.github.com/repos/jaredhaight/ptf/deployments","created_at":"2015-08-05T23:22:16Z","updated_at":"2015-08-05T23:22:16Z","pushed_at":"2016-07-25T18:12:19Z","git_url":"git://github.com/jaredhaight/ptf.git","ssh_url":"git@github.com:jaredhaight/ptf.git","clone_url":"https://github.com/jaredhaight/ptf.git","svn_url":"https://github.com/jaredhaight/ptf","homepage":null,"size":334,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"trustedsec:master","ref":"master","sha":"571d0a10a64a7b7799263cde0806d798c748fb3e","user":{"login":"trustedsec","id":3160808,"avatar_url":"https://avatars.githubusercontent.com/u/3160808?v=3","gravatar_id":"","url":"https://api.github.com/users/trustedsec","html_url":"https://github.com/trustedsec","followers_url":"https://api.github.com/users/trustedsec/followers","following_url":"https://api.github.com/users/trustedsec/following{/other_user}","gists_url":"https://api.github.com/users/trustedsec/gists{/gist_id}","starred_url":"https://api.github.com/users/trustedsec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trustedsec/subscriptions","organizations_url":"https://api.github.com/users/trustedsec/orgs","repos_url":"https://api.github.com/users/trustedsec/repos","events_url":"https://api.github.com/users/trustedsec/events{/privacy}","received_events_url":"https://api.github.com/users/trustedsec/received_events","type":"User","site_admin":false},"repo":{"id":35505904,"name":"ptf","full_name":"trustedsec/ptf","owner":{"login":"trustedsec","id":3160808,"avatar_url":"https://avatars.githubusercontent.com/u/3160808?v=3","gravatar_id":"","url":"https://api.github.com/users/trustedsec","html_url":"https://github.com/trustedsec","followers_url":"https://api.github.com/users/trustedsec/followers","following_url":"https://api.github.com/users/trustedsec/following{/other_user}","gists_url":"https://api.github.com/users/trustedsec/gists{/gist_id}","starred_url":"https://api.github.com/users/trustedsec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trustedsec/subscriptions","organizations_url":"https://api.github.com/users/trustedsec/orgs","repos_url":"https://api.github.com/users/trustedsec/repos","events_url":"https://api.github.com/users/trustedsec/events{/privacy}","received_events_url":"https://api.github.com/users/trustedsec/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/trustedsec/ptf","description":"The Penetration Testers Framework (PTF) is a way for modular support for up-to-date tools.","fork":false,"url":"https://api.github.com/repos/trustedsec/ptf","forks_url":"https://api.github.com/repos/trustedsec/ptf/forks","keys_url":"https://api.github.com/repos/trustedsec/ptf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/trustedsec/ptf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/trustedsec/ptf/teams","hooks_url":"https://api.github.com/repos/trustedsec/ptf/hooks","issue_events_url":"https://api.github.com/repos/trustedsec/ptf/issues/events{/number}","events_url":"https://api.github.com/repos/trustedsec/ptf/events","assignees_url":"https://api.github.com/repos/trustedsec/ptf/assignees{/user}","branches_url":"https://api.github.com/repos/trustedsec/ptf/branches{/branch}","tags_url":"https://api.github.com/repos/trustedsec/ptf/tags","blobs_url":"https://api.github.com/repos/trustedsec/ptf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/trustedsec/ptf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/trustedsec/ptf/git/refs{/sha}","trees_url":"https://api.github.com/repos/trustedsec/ptf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/trustedsec/ptf/statuses/{sha}","languages_url":"https://api.github.com/repos/trustedsec/ptf/languages","stargazers_url":"https://api.github.com/repos/trustedsec/ptf/stargazers","contributors_url":"https://api.github.com/repos/trustedsec/ptf/contributors","subscribers_url":"https://api.github.com/repos/trustedsec/ptf/subscribers","subscription_url":"https://api.github.com/repos/trustedsec/ptf/subscription","commits_url":"https://api.github.com/repos/trustedsec/ptf/commits{/sha}","git_commits_url":"https://api.github.com/repos/trustedsec/ptf/git/commits{/sha}","comments_url":"https://api.github.com/repos/trustedsec/ptf/comments{/number}","issue_comment_url":"https://api.github.com/repos/trustedsec/ptf/issues/comments{/number}","contents_url":"https://api.github.com/repos/trustedsec/ptf/contents/{+path}","compare_url":"https://api.github.com/repos/trustedsec/ptf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/trustedsec/ptf/merges","archive_url":"https://api.github.com/repos/trustedsec/ptf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/trustedsec/ptf/downloads","issues_url":"https://api.github.com/repos/trustedsec/ptf/issues{/number}","pulls_url":"https://api.github.com/repos/trustedsec/ptf/pulls{/number}","milestones_url":"https://api.github.com/repos/trustedsec/ptf/milestones{/number}","notifications_url":"https://api.github.com/repos/trustedsec/ptf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/trustedsec/ptf/labels{/name}","releases_url":"https://api.github.com/repos/trustedsec/ptf/releases{/id}","deployments_url":"https://api.github.com/repos/trustedsec/ptf/deployments","created_at":"2015-05-12T18:37:25Z","updated_at":"2016-07-25T14:43:22Z","pushed_at":"2016-07-24T22:33:41Z","git_url":"git://github.com/trustedsec/ptf.git","ssh_url":"git@github.com:trustedsec/ptf.git","clone_url":"https://github.com/trustedsec/ptf.git","svn_url":"https://github.com/trustedsec/ptf","homepage":null,"size":725,"stargazers_count":640,"watchers_count":640,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":210,"mirror_url":null,"open_issues_count":1,"forks":210,"open_issues":1,"watchers":640,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/trustedsec/ptf/pulls/188"},"html":{"href":"https://github.com/trustedsec/ptf/pull/188"},"issue":{"href":"https://api.github.com/repos/trustedsec/ptf/issues/188"},"comments":{"href":"https://api.github.com/repos/trustedsec/ptf/issues/188/comments"},"review_comments":{"href":"https://api.github.com/repos/trustedsec/ptf/pulls/188/comments"},"review_comment":{"href":"https://api.github.com/repos/trustedsec/ptf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/trustedsec/ptf/pulls/188/commits"},"statuses":{"href":"https://api.github.com/repos/trustedsec/ptf/statuses/f71129662cbd5698bb20488e57fd1616e0e25173"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":2,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"jaredhaight"}}