{"action":"opened","issue":{"url":"https://api.github.com/repos/twstrike/coyim/issues/281","repository_url":"https://api.github.com/repos/twstrike/coyim","labels_url":"https://api.github.com/repos/twstrike/coyim/issues/281/labels{/name}","comments_url":"https://api.github.com/repos/twstrike/coyim/issues/281/comments","events_url":"https://api.github.com/repos/twstrike/coyim/issues/281/events","html_url":"https://github.com/twstrike/coyim/issues/281","id":142218801,"number":281,"title":"Tests currently fail","user":{"login":"xSmurf","id":525356,"avatar_url":"https://avatars.githubusercontent.com/u/525356?v=3","gravatar_id":"","url":"https://api.github.com/users/xSmurf","html_url":"https://github.com/xSmurf","followers_url":"https://api.github.com/users/xSmurf/followers","following_url":"https://api.github.com/users/xSmurf/following{/other_user}","gists_url":"https://api.github.com/users/xSmurf/gists{/gist_id}","starred_url":"https://api.github.com/users/xSmurf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xSmurf/subscriptions","organizations_url":"https://api.github.com/users/xSmurf/orgs","repos_url":"https://api.github.com/users/xSmurf/repos","events_url":"https://api.github.com/users/xSmurf/events{/privacy}","received_events_url":"https://api.github.com/users/xSmurf/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2016-03-20T23:07:22Z","updated_at":"2016-03-20T23:07:22Z","closed_at":null,"body":"We were going to make a new package for SubgraphOS and realized that some tests are currently failing:\r\n\r\n```\r\n.../src/github.com/twstrike/coyim$ go test ./...\r\nok  \tgithub.com/twstrike/coyim\t0.024s\r\nok  \tgithub.com/twstrike/coyim/cli\t0.007s\r\n?   \tgithub.com/twstrike/coyim/cli/terminal\t[no test files]\r\n?   \tgithub.com/twstrike/coyim/cli/terminal/real\t[no test files]\r\nok  \tgithub.com/twstrike/coyim/client\t0.009s\r\nok  \tgithub.com/twstrike/coyim/config\t4.377s\r\nok  \tgithub.com/twstrike/coyim/config/importer\t0.808s\r\n?   \tgithub.com/twstrike/coyim/digests\t[no test files]\r\nok  \tgithub.com/twstrike/coyim/event\t0.013s\r\nok  \tgithub.com/twstrike/coyim/gui\t0.079s\r\n?   \tgithub.com/twstrike/coyim/gui/definitions\t[no test files]\r\nok  \tgithub.com/twstrike/coyim/i18n\t0.003s\r\nok  \tgithub.com/twstrike/coyim/net\t0.213s\r\nok  \tgithub.com/twstrike/coyim/roster\t0.025s\r\nok  \tgithub.com/twstrike/coyim/sasl\t0.016s\r\nok  \tgithub.com/twstrike/coyim/sasl/digestmd5\t0.014s\r\nok  \tgithub.com/twstrike/coyim/sasl/plain\t0.003s\r\nok  \tgithub.com/twstrike/coyim/sasl/scram\t0.012s\r\nok  \tgithub.com/twstrike/coyim/servers\t0.003s\r\nok  \tgithub.com/twstrike/coyim/session\t1.021s\r\n?   \tgithub.com/twstrike/coyim/session/access\t[no test files]\r\n?   \tgithub.com/twstrike/coyim/session/events\t[no test files]\r\n?   \tgithub.com/twstrike/coyim/session/mock\t[no test files]\r\n?   \tgithub.com/twstrike/coyim/tls\t[no test files]\r\nok  \tgithub.com/twstrike/coyim/ui\t0.019s\r\n\r\n----------------------------------------------------------------------\r\nFAIL: connection_test.go:519: ConnectionXmppSuite.Test_Dial_failsWhenStartingAHandshake\r\n\r\nconnection_test.go:564:\r\n    c.Assert(string(rw.write), Equals, \"\"+\r\n        \"<?xml version='1.0'?><stream:stream to='domain' xmlns='jabber:client' xmlns:stream='http://etherx.jabber.org/streams' version='1.0'>\\n\"+\r\n        \"<starttls xmlns='urn:ietf:params:xml:ns:xmpp-tls'/>\\x16\\x03\\x01\\x00\\x8a\\x01\\x00\\x00\\x86\\x03\\x03\\x00\\x01\\x02\\x03\\x04\\x05\\x06\\a\\b\\t\\n\"+\r\n        \"\\v\\f\\r\\x0e\\x0f\\x10\\x11\\x12\\x13\\x14\\x15\\x16\\x17\\x18\\x19\\x1a\\x1b\\x1c\\x1d\\x1e\\x1f\\x00\\x00\\x18\\xc0/\\xc0+\\xc00\\xc0,\\xc0\\x13\\xc0\\t\\xc0\\x14\\xc0\\n\"+\r\n        \"\\x00/\\x005\\xc0\\x12\\x00\\n\"+\r\n        \"\\x01\\x00\\x00E\\x00\\x00\\x00\\v\\x00\\t\\x00\\x00\\x06domain\\x00\\x05\\x00\\x05\\x01\\x00\\x00\\x00\\x00\\x00\\n\"+\r\n        \"\\x00\\b\\x00\\x06\\x00\\x17\\x00\\x18\\x00\\x19\\x00\\v\\x00\\x02\\x01\\x00\\x00\\r\\x00\\x0e\\x00\\f\\x04\\x01\\x04\\x03\\x05\\x01\\x05\\x03\\x02\\x01\\x02\\x03\\xff\\x01\\x00\\x01\\x00\\x00\\x12\\x00\\x00\",\r\n    )\r\n... obtained string = \"\" +\r\n...     \"<?xml version='1.0'?><stream:stream to='domain' xmlns='jabber:client' xmlns:stream='http://etherx.jabber.org/streams' version='1.0'>\\n\" +\r\n...     \"<starttls xmlns='urn:ietf:params:xml:ns:xmpp-tls'/>\\x16\\x03\\x01\\x00\\x8e\\x01\\x00\\x00\\x8a\\x03\\x03\\x00\\x01\\x02\\x03\\x04\\x05\\x06\\a\\b\\t\\n\" +\r\n...     \"\\v\\f\\r\\x0e\\x0f\\x10\\x11\\x12\\x13\\x14\\x15\\x16\\x17\\x18\\x19\\x1a\\x1b\\x1c\\x1d\\x1e\\x1f\\x00\\x00\\x1c\\xc0/\\xc0+\\xc00\\xc0,\\xc0\\x13\\xc0\\t\\xc0\\x14\\xc0\\n\" +\r\n...     \"\\x00\\x9c\\x00\\x9d\\x00/\\x005\\xc0\\x12\\x00\\n\" +\r\n...     \"\\x01\\x00\\x00E\\x00\\x00\\x00\\v\\x00\\t\\x00\\x00\\x06domain\\x00\\x05\\x00\\x05\\x01\\x00\\x00\\x00\\x00\\x00\\n\" +\r\n...     \"\\x00\\b\\x00\\x06\\x00\\x17\\x00\\x18\\x00\\x19\\x00\\v\\x00\\x02\\x01\\x00\\x00\\r\\x00\\x0e\\x00\\f\\x04\\x01\\x04\\x03\\x05\\x01\\x05\\x03\\x02\\x01\\x02\\x03\\xff\\x01\\x00\\x01\\x00\\x00\\x12\\x00\\x00\"\r\n... expected string = \"\" +\r\n...     \"<?xml version='1.0'?><stream:stream to='domain' xmlns='jabber:client' xmlns:stream='http://etherx.jabber.org/streams' version='1.0'>\\n\" +\r\n...     \"<starttls xmlns='urn:ietf:params:xml:ns:xmpp-tls'/>\\x16\\x03\\x01\\x00\\x8a\\x01\\x00\\x00\\x86\\x03\\x03\\x00\\x01\\x02\\x03\\x04\\x05\\x06\\a\\b\\t\\n\" +\r\n...     \"\\v\\f\\r\\x0e\\x0f\\x10\\x11\\x12\\x13\\x14\\x15\\x16\\x17\\x18\\x19\\x1a\\x1b\\x1c\\x1d\\x1e\\x1f\\x00\\x00\\x18\\xc0/\\xc0+\\xc00\\xc0,\\xc0\\x13\\xc0\\t\\xc0\\x14\\xc0\\n\" +\r\n...     \"\\x00/\\x005\\xc0\\x12\\x00\\n\" +\r\n...     \"\\x01\\x00\\x00E\\x00\\x00\\x00\\v\\x00\\t\\x00\\x00\\x06domain\\x00\\x05\\x00\\x05\\x01\\x00\\x00\\x00\\x00\\x00\\n\" +\r\n...     \"\\x00\\b\\x00\\x06\\x00\\x17\\x00\\x18\\x00\\x19\\x00\\v\\x00\\x02\\x01\\x00\\x00\\r\\x00\\x0e\\x00\\f\\x04\\x01\\x04\\x03\\x05\\x01\\x05\\x03\\x02\\x01\\x02\\x03\\xff\\x01\\x00\\x01\\x00\\x00\\x12\\x00\\x00\"\r\n\r\n\r\n----------------------------------------------------------------------\r\nFAIL: connection_test.go:1085: ConnectionXmppSuite.Test_Dial_worksIfTheHandshakeSucceeds\r\n\r\nconnection_test.go:1108:\r\n    c.Assert(err, Equals, io.EOF)\r\n... obtained *errors.errorString = &errors.errorString{s:\"tls: server's Finished message was incorrect\"} (\"tls: server's Finished message was incorrect\")\r\n... expected *errors.errorString = &errors.errorString{s:\"EOF\"} (\"EOF\")\r\n\r\n\r\n----------------------------------------------------------------------\r\nFAIL: connection_test.go:1136: ConnectionXmppSuite.Test_Dial_worksIfTheHandshakeSucceedsButFailsOnInvalidCertHash\r\n\r\nconnection_test.go:1159:\r\n    c.Assert(err.Error(), Equals, \"tls: server certificate does not match expected hash (got: 2300818fdc977ce5eb357694d421e47869a952990bc3230ef6aca2bb6ee6f00b, want: 6161616161)\")\r\n... obtained string = \"tls: server's Finished message was incorrect\"\r\n... expected string = \"tls: server certificate does not match expected hash (got: 2300818fdc977ce5eb357694d421e47869a952990bc3230ef6aca2bb6ee6f00b, want: 6161616161)\"\r\n\r\n\r\n----------------------------------------------------------------------\r\nFAIL: connection_test.go:1162: ConnectionXmppSuite.Test_Dial_worksIfTheHandshakeSucceedsButSucceedsOnValidCertHash\r\n\r\nconnection_test.go:1185:\r\n    c.Assert(err, Equals, io.EOF)\r\n... obtained *errors.errorString = &errors.errorString{s:\"tls: server's Finished message was incorrect\"} (\"tls: server's Finished message was incorrect\")\r\n... expected *errors.errorString = &errors.errorString{s:\"EOF\"} (\"EOF\")\r\n\r\n2016/03/20 23:06:16 xmpp: sending closing stream tag\r\n2016/03/20 23:06:16 xmpp: TCP closed\r\n2016/03/20 23:06:16 xmpp: received closing stream tag\r\nOOPS: 124 passed, 4 FAILED\r\n--- FAIL: Test (0.18s)\r\nFAIL\r\nFAIL\tgithub.com/twstrike/coyim/xmpp\t0.194s\r\n?   \tgithub.com/twstrike/coyim/xmpp/data\t[no test files]\r\n?   \tgithub.com/twstrike/coyim/xmpp/errors\t[no test files]\r\n?   \tgithub.com/twstrike/coyim/xmpp/interfaces\t[no test files]\r\nok  \tgithub.com/twstrike/coyim/xmpp/utils\t0.018s\r\n\r\n```\r\n\r\nOn top of my head and speaking through my hat, this looks related to the new invalid certificate support."}}