{"action":"created","issue":{"url":"https://api.github.com/repos/Homebrew/ruby-macho/issues/34","repository_url":"https://api.github.com/repos/Homebrew/ruby-macho","labels_url":"https://api.github.com/repos/Homebrew/ruby-macho/issues/34/labels{/name}","comments_url":"https://api.github.com/repos/Homebrew/ruby-macho/issues/34/comments","events_url":"https://api.github.com/repos/Homebrew/ruby-macho/issues/34/events","html_url":"https://github.com/Homebrew/ruby-macho/pull/34","id":162755099,"number":34,"title":"LCStr: Refactor and simplify","user":{"login":"UniqMartin","id":11892150,"avatar_url":"https://avatars.githubusercontent.com/u/11892150?v=3","gravatar_id":"","url":"https://api.github.com/users/UniqMartin","html_url":"https://github.com/UniqMartin","followers_url":"https://api.github.com/users/UniqMartin/followers","following_url":"https://api.github.com/users/UniqMartin/following{/other_user}","gists_url":"https://api.github.com/users/UniqMartin/gists{/gist_id}","starred_url":"https://api.github.com/users/UniqMartin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UniqMartin/subscriptions","organizations_url":"https://api.github.com/users/UniqMartin/orgs","repos_url":"https://api.github.com/users/UniqMartin/repos","events_url":"https://api.github.com/users/UniqMartin/events{/privacy}","received_events_url":"https://api.github.com/users/UniqMartin/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Homebrew/ruby-macho/labels/enhancement","name":"enhancement","color":"84b6eb"},{"url":"https://api.github.com/repos/Homebrew/ruby-macho/labels/optimization","name":"optimization","color":"fef2c0"}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-06-28T18:33:22Z","updated_at":"2016-06-28T21:59:08Z","closed_at":"2016-06-28T19:33:12Z","pull_request":{"url":"https://api.github.com/repos/Homebrew/ruby-macho/pulls/34","html_url":"https://github.com/Homebrew/ruby-macho/pull/34","diff_url":"https://github.com/Homebrew/ruby-macho/pull/34.diff","patch_url":"https://github.com/Homebrew/ruby-macho/pull/34.patch"},"body":"- Drop constructor argument `raw_data` as it is redundant and the data can be obtained from the load command via `lc.view.raw_data` (and adapt related load commands accordingly).\r\n- Use intermediate variables to shorten overly long line.\r\n- Avoid storing constructor arguments in instance variables if they are not going to be referenced later (`@raw_data` and `@lc`).\r\n- Improve names of instance variables.\r\n\r\n@woodruffw Sorry that this is somewhat interfering with #33 where you add new load commands that also use `LCStr` (but obviously still using the three-argument constructor)."},"comment":{"url":"https://api.github.com/repos/Homebrew/ruby-macho/issues/comments/229197141","html_url":"https://github.com/Homebrew/ruby-macho/pull/34#issuecomment-229197141","issue_url":"https://api.github.com/repos/Homebrew/ruby-macho/issues/34","id":229197141,"user":{"login":"woodruffw","id":3059210,"avatar_url":"https://avatars.githubusercontent.com/u/3059210?v=3","gravatar_id":"","url":"https://api.github.com/users/woodruffw","html_url":"https://github.com/woodruffw","followers_url":"https://api.github.com/users/woodruffw/followers","following_url":"https://api.github.com/users/woodruffw/following{/other_user}","gists_url":"https://api.github.com/users/woodruffw/gists{/gist_id}","starred_url":"https://api.github.com/users/woodruffw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/woodruffw/subscriptions","organizations_url":"https://api.github.com/users/woodruffw/orgs","repos_url":"https://api.github.com/users/woodruffw/repos","events_url":"https://api.github.com/users/woodruffw/events{/privacy}","received_events_url":"https://api.github.com/users/woodruffw/received_events","type":"User","site_admin":false},"created_at":"2016-06-28T21:59:08Z","updated_at":"2016-06-28T21:59:08Z","body":"Whoops. I'll remember that for future merges. I keep flipping it back to regular merge as a force of habit..."}}
{"actor":{"display_login":"woodruffw"}}