{"action":"created","comment":{"url":"https://api.github.com/repos/angular/angular/pulls/comments/61696429","id":61696429,"diff_hunk":"@@ -14,7 +14,8 @@ export interface CompilerInterface {\n   readConfiguration(\n       project: string,\n       basePath: string): {parsed: ts.ParsedCommandLine, ngOptions: AngularCompilerOptions};","path":"tools/compiler_cli/src/tsc.ts","position":12,"original_position":12,"commit_id":"c5f9a4022fd68f67917594ce3fcc9f6909225335","original_commit_id":"c5f9a4022fd68f67917594ce3fcc9f6909225335","user":{"login":"mprobst","id":7208,"avatar_url":"https://avatars.githubusercontent.com/u/7208?v=3","gravatar_id":"","url":"https://api.github.com/users/mprobst","html_url":"https://github.com/mprobst","followers_url":"https://api.github.com/users/mprobst/followers","following_url":"https://api.github.com/users/mprobst/following{/other_user}","gists_url":"https://api.github.com/users/mprobst/gists{/gist_id}","starred_url":"https://api.github.com/users/mprobst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mprobst/subscriptions","organizations_url":"https://api.github.com/users/mprobst/orgs","repos_url":"https://api.github.com/users/mprobst/repos","events_url":"https://api.github.com/users/mprobst/events{/privacy}","received_events_url":"https://api.github.com/users/mprobst/received_events","type":"User","site_admin":false},"body":"can't we take basePath from the tsconfig options?","created_at":"2016-05-02T00:49:06Z","updated_at":"2016-05-02T00:49:06Z","html_url":"https://github.com/angular/angular/pull/8375#discussion_r61696429","pull_request_url":"https://api.github.com/repos/angular/angular/pulls/8375","_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/comments/61696429"},"html":{"href":"https://github.com/angular/angular/pull/8375#discussion_r61696429"},"pull_request":{"href":"https://api.github.com/repos/angular/angular/pulls/8375"}}},"pull_request":{"url":"https://api.github.com/repos/angular/angular/pulls/8375","id":68506833,"html_url":"https://github.com/angular/angular/pull/8375","diff_url":"https://github.com/angular/angular/pull/8375.diff","patch_url":"https://github.com/angular/angular/pull/8375.patch","issue_url":"https://api.github.com/repos/angular/angular/issues/8375","number":8375,"state":"open","locked":false,"title":"Add metadata.json emit","user":{"login":"alexeagle","id":47395,"avatar_url":"https://avatars.githubusercontent.com/u/47395?v=3","gravatar_id":"","url":"https://api.github.com/users/alexeagle","html_url":"https://github.com/alexeagle","followers_url":"https://api.github.com/users/alexeagle/followers","following_url":"https://api.github.com/users/alexeagle/following{/other_user}","gists_url":"https://api.github.com/users/alexeagle/gists{/gist_id}","starred_url":"https://api.github.com/users/alexeagle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexeagle/subscriptions","organizations_url":"https://api.github.com/users/alexeagle/orgs","repos_url":"https://api.github.com/users/alexeagle/repos","events_url":"https://api.github.com/users/alexeagle/events{/privacy}","received_events_url":"https://api.github.com/users/alexeagle/received_events","type":"User","site_admin":false},"body":"note, the first commit is already in another PR that should merge first.","created_at":"2016-05-01T20:48:52Z","updated_at":"2016-05-02T00:49:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"92f553a2ab53b17313c26ff6292b06e5ea79e122","assignee":{"login":"tbosch","id":690815,"avatar_url":"https://avatars.githubusercontent.com/u/690815?v=3","gravatar_id":"","url":"https://api.github.com/users/tbosch","html_url":"https://github.com/tbosch","followers_url":"https://api.github.com/users/tbosch/followers","following_url":"https://api.github.com/users/tbosch/following{/other_user}","gists_url":"https://api.github.com/users/tbosch/gists{/gist_id}","starred_url":"https://api.github.com/users/tbosch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbosch/subscriptions","organizations_url":"https://api.github.com/users/tbosch/orgs","repos_url":"https://api.github.com/users/tbosch/repos","events_url":"https://api.github.com/users/tbosch/events{/privacy}","received_events_url":"https://api.github.com/users/tbosch/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/angular/angular/pulls/8375/commits","review_comments_url":"https://api.github.com/repos/angular/angular/pulls/8375/comments","review_comment_url":"https://api.github.com/repos/angular/angular/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/angular/issues/8375/comments","statuses_url":"https://api.github.com/repos/angular/angular/statuses/c5f9a4022fd68f67917594ce3fcc9f6909225335","head":{"label":"alexeagle:compiler2","ref":"compiler2","sha":"c5f9a4022fd68f67917594ce3fcc9f6909225335","user":{"login":"alexeagle","id":47395,"avatar_url":"https://avatars.githubusercontent.com/u/47395?v=3","gravatar_id":"","url":"https://api.github.com/users/alexeagle","html_url":"https://github.com/alexeagle","followers_url":"https://api.github.com/users/alexeagle/followers","following_url":"https://api.github.com/users/alexeagle/following{/other_user}","gists_url":"https://api.github.com/users/alexeagle/gists{/gist_id}","starred_url":"https://api.github.com/users/alexeagle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexeagle/subscriptions","organizations_url":"https://api.github.com/users/alexeagle/orgs","repos_url":"https://api.github.com/users/alexeagle/repos","events_url":"https://api.github.com/users/alexeagle/events{/privacy}","received_events_url":"https://api.github.com/users/alexeagle/received_events","type":"User","site_admin":false},"repo":{"id":30215210,"name":"angular","full_name":"alexeagle/angular","owner":{"login":"alexeagle","id":47395,"avatar_url":"https://avatars.githubusercontent.com/u/47395?v=3","gravatar_id":"","url":"https://api.github.com/users/alexeagle","html_url":"https://github.com/alexeagle","followers_url":"https://api.github.com/users/alexeagle/followers","following_url":"https://api.github.com/users/alexeagle/following{/other_user}","gists_url":"https://api.github.com/users/alexeagle/gists{/gist_id}","starred_url":"https://api.github.com/users/alexeagle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexeagle/subscriptions","organizations_url":"https://api.github.com/users/alexeagle/orgs","repos_url":"https://api.github.com/users/alexeagle/repos","events_url":"https://api.github.com/users/alexeagle/events{/privacy}","received_events_url":"https://api.github.com/users/alexeagle/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alexeagle/angular","description":"","fork":true,"url":"https://api.github.com/repos/alexeagle/angular","forks_url":"https://api.github.com/repos/alexeagle/angular/forks","keys_url":"https://api.github.com/repos/alexeagle/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alexeagle/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alexeagle/angular/teams","hooks_url":"https://api.github.com/repos/alexeagle/angular/hooks","issue_events_url":"https://api.github.com/repos/alexeagle/angular/issues/events{/number}","events_url":"https://api.github.com/repos/alexeagle/angular/events","assignees_url":"https://api.github.com/repos/alexeagle/angular/assignees{/user}","branches_url":"https://api.github.com/repos/alexeagle/angular/branches{/branch}","tags_url":"https://api.github.com/repos/alexeagle/angular/tags","blobs_url":"https://api.github.com/repos/alexeagle/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alexeagle/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alexeagle/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/alexeagle/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alexeagle/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/alexeagle/angular/languages","stargazers_url":"https://api.github.com/repos/alexeagle/angular/stargazers","contributors_url":"https://api.github.com/repos/alexeagle/angular/contributors","subscribers_url":"https://api.github.com/repos/alexeagle/angular/subscribers","subscription_url":"https://api.github.com/repos/alexeagle/angular/subscription","commits_url":"https://api.github.com/repos/alexeagle/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/alexeagle/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/alexeagle/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/alexeagle/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/alexeagle/angular/contents/{+path}","compare_url":"https://api.github.com/repos/alexeagle/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alexeagle/angular/merges","archive_url":"https://api.github.com/repos/alexeagle/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alexeagle/angular/downloads","issues_url":"https://api.github.com/repos/alexeagle/angular/issues{/number}","pulls_url":"https://api.github.com/repos/alexeagle/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/alexeagle/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/alexeagle/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alexeagle/angular/labels{/name}","releases_url":"https://api.github.com/repos/alexeagle/angular/releases{/id}","deployments_url":"https://api.github.com/repos/alexeagle/angular/deployments","created_at":"2015-02-02T23:49:55Z","updated_at":"2016-01-15T21:33:18Z","pushed_at":"2016-05-02T00:34:31Z","git_url":"git://github.com/alexeagle/angular.git","ssh_url":"git@github.com:alexeagle/angular.git","clone_url":"https://github.com/alexeagle/angular.git","svn_url":"https://github.com/alexeagle/angular","homepage":null,"size":153835,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"ca13f1c0248598f66fbb20125e2400920ddd02e2","user":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":24195339,"name":"angular","full_name":"angular/angular","owner":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/angular","description":"","fork":false,"url":"https://api.github.com/repos/angular/angular","forks_url":"https://api.github.com/repos/angular/angular/forks","keys_url":"https://api.github.com/repos/angular/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/angular/teams","hooks_url":"https://api.github.com/repos/angular/angular/hooks","issue_events_url":"https://api.github.com/repos/angular/angular/issues/events{/number}","events_url":"https://api.github.com/repos/angular/angular/events","assignees_url":"https://api.github.com/repos/angular/angular/assignees{/user}","branches_url":"https://api.github.com/repos/angular/angular/branches{/branch}","tags_url":"https://api.github.com/repos/angular/angular/tags","blobs_url":"https://api.github.com/repos/angular/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/angular/languages","stargazers_url":"https://api.github.com/repos/angular/angular/stargazers","contributors_url":"https://api.github.com/repos/angular/angular/contributors","subscribers_url":"https://api.github.com/repos/angular/angular/subscribers","subscription_url":"https://api.github.com/repos/angular/angular/subscription","commits_url":"https://api.github.com/repos/angular/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/angular/contents/{+path}","compare_url":"https://api.github.com/repos/angular/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/angular/merges","archive_url":"https://api.github.com/repos/angular/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/angular/downloads","issues_url":"https://api.github.com/repos/angular/angular/issues{/number}","pulls_url":"https://api.github.com/repos/angular/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/angular/labels{/name}","releases_url":"https://api.github.com/repos/angular/angular/releases{/id}","deployments_url":"https://api.github.com/repos/angular/angular/deployments","created_at":"2014-09-18T16:12:01Z","updated_at":"2016-05-02T00:46:09Z","pushed_at":"2016-05-02T00:37:49Z","git_url":"git://github.com/angular/angular.git","ssh_url":"git@github.com:angular/angular.git","clone_url":"https://github.com/angular/angular.git","svn_url":"https://github.com/angular/angular","homepage":"https://angular.io","size":584726,"stargazers_count":11193,"watchers_count":11193,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2946,"mirror_url":null,"open_issues_count":1540,"forks":2946,"open_issues":1540,"watchers":11193,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/8375"},"html":{"href":"https://github.com/angular/angular/pull/8375"},"issue":{"href":"https://api.github.com/repos/angular/angular/issues/8375"},"comments":{"href":"https://api.github.com/repos/angular/angular/issues/8375/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/angular/pulls/8375/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/angular/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/angular/pulls/8375/commits"},"statuses":{"href":"https://api.github.com/repos/angular/angular/statuses/c5f9a4022fd68f67917594ce3fcc9f6909225335"}}}}