{"action":"created","issue":{"url":"https://api.github.com/repos/open-source-economics/OG-USA/issues/231","repository_url":"https://api.github.com/repos/open-source-economics/OG-USA","labels_url":"https://api.github.com/repos/open-source-economics/OG-USA/issues/231/labels{/name}","comments_url":"https://api.github.com/repos/open-source-economics/OG-USA/issues/231/comments","events_url":"https://api.github.com/repos/open-source-economics/OG-USA/issues/231/events","html_url":"https://github.com/open-source-economics/OG-USA/pull/231","id":169118225,"number":231,"title":"Allow OG-USA to take general S and J","user":{"login":"rickecon","id":4317690,"avatar_url":"https://avatars.githubusercontent.com/u/4317690?v=3","gravatar_id":"","url":"https://api.github.com/users/rickecon","html_url":"https://github.com/rickecon","followers_url":"https://api.github.com/users/rickecon/followers","following_url":"https://api.github.com/users/rickecon/following{/other_user}","gists_url":"https://api.github.com/users/rickecon/gists{/gist_id}","starred_url":"https://api.github.com/users/rickecon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rickecon/subscriptions","organizations_url":"https://api.github.com/users/rickecon/orgs","repos_url":"https://api.github.com/users/rickecon/repos","events_url":"https://api.github.com/users/rickecon/events{/privacy}","received_events_url":"https://api.github.com/users/rickecon/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2016-08-03T12:21:15Z","updated_at":"2016-08-03T17:32:07Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/open-source-economics/OG-USA/pulls/231","html_url":"https://github.com/open-source-economics/OG-USA/pull/231","diff_url":"https://github.com/open-source-economics/OG-USA/pull/231.diff","patch_url":"https://github.com/open-source-economics/OG-USA/pull/231.patch"},"body":"This PR allows OG-USA to take general S and J. I have tested this on both the steady-state and time path computations for (S=30, J=2) and for (S=80, J=7) and it works perfectly except for the error in the last period resource constraint (1e-03). We think we know what this problem is (nonconvex tax functions) and will remedy it with a different PR.\r\n\r\nThe steady-state will compute with S=20 and J=1. I assume that fully general S and J would compute if we adjusted our starting values. Most of the changes in this PR were to income.py."},"comment":{"url":"https://api.github.com/repos/open-source-economics/OG-USA/issues/comments/237308323","html_url":"https://github.com/open-source-economics/OG-USA/pull/231#issuecomment-237308323","issue_url":"https://api.github.com/repos/open-source-economics/OG-USA/issues/231","id":237308323,"user":{"login":"talumbau","id":1891418,"avatar_url":"https://avatars.githubusercontent.com/u/1891418?v=3","gravatar_id":"","url":"https://api.github.com/users/talumbau","html_url":"https://github.com/talumbau","followers_url":"https://api.github.com/users/talumbau/followers","following_url":"https://api.github.com/users/talumbau/following{/other_user}","gists_url":"https://api.github.com/users/talumbau/gists{/gist_id}","starred_url":"https://api.github.com/users/talumbau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/talumbau/subscriptions","organizations_url":"https://api.github.com/users/talumbau/orgs","repos_url":"https://api.github.com/users/talumbau/repos","events_url":"https://api.github.com/users/talumbau/events{/privacy}","received_events_url":"https://api.github.com/users/talumbau/received_events","type":"User","site_admin":false},"created_at":"2016-08-03T17:32:07Z","updated_at":"2016-08-03T17:32:07Z","body":"I took a quick look. At least one error is that the code is attempting to create matplotlib figures during a test. The Travis CI environment is not set up to draw these figures so it gets an error. Does it make sense to modify the code so that you can have a flag that turns on drawing the plots but it is off by default (or the other way around and we can modify the tests)?"}}
{"actor":{"display_login":"talumbau"}}