{"action":"created","issue":{"url":"https://api.github.com/repos/mesosphere/marathon-lb/issues/172","repository_url":"https://api.github.com/repos/mesosphere/marathon-lb","labels_url":"https://api.github.com/repos/mesosphere/marathon-lb/issues/172/labels{/name}","comments_url":"https://api.github.com/repos/mesosphere/marathon-lb/issues/172/comments","events_url":"https://api.github.com/repos/mesosphere/marathon-lb/issues/172/events","html_url":"https://github.com/mesosphere/marathon-lb/pull/172","id":151402837,"number":172,"title":"Allow to specify multiple certs in Docker ENV","user":{"login":"lloesche","id":2124094,"avatar_url":"https://avatars.githubusercontent.com/u/2124094?v=3","gravatar_id":"","url":"https://api.github.com/users/lloesche","html_url":"https://github.com/lloesche","followers_url":"https://api.github.com/users/lloesche/followers","following_url":"https://api.github.com/users/lloesche/following{/other_user}","gists_url":"https://api.github.com/users/lloesche/gists{/gist_id}","starred_url":"https://api.github.com/users/lloesche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lloesche/subscriptions","organizations_url":"https://api.github.com/users/lloesche/orgs","repos_url":"https://api.github.com/users/lloesche/repos","events_url":"https://api.github.com/users/lloesche/events{/privacy}","received_events_url":"https://api.github.com/users/lloesche/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-04-27T14:39:33Z","updated_at":"2016-04-27T17:24:36Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mesosphere/marathon-lb/pulls/172","html_url":"https://github.com/mesosphere/marathon-lb/pull/172","diff_url":"https://github.com/mesosphere/marathon-lb/pull/172.diff","patch_url":"https://github.com/mesosphere/marathon-lb/pull/172.patch"},"body":"This is the same PR as https://github.com/mesosphere/marathon-lb/pull/169 with a fix for the issue reported in https://github.com/mesosphere/marathon-lb/pull/170 as well as a fix for the situation where `--ssl-certs` would be passed to `marathon_lb.py` twice.\r\n\r\nThis should now allow any combination of passing certificates either on the commandline and/or as ENV vars or not at all resulting in the self-signed cert being generated.\r\n\r\nAlso moved the loop that looks for additional certificates (`$HAPROXY_SSL_CERT0` - `$HAPROXY_SSL_CERT100`) into the if check for `$HAPROXY_SSL_CERT` since it doesn't make any sense to have a system with user provided as well as a self signed certificate. This way a user has to explicitly set `$HAPROXY_SSL_CERT` for his first certificate and only then can add additional certs using `$HAPROXY_SSL_CERT0..`\r\n\r\nI also fixed a bug where `echo \"Define $PORTS with a comma-separated list of ports to which HAProxy binds\"` would try to expand `$PORTS` instead of printing it."},"comment":{"url":"https://api.github.com/repos/mesosphere/marathon-lb/issues/comments/215159124","html_url":"https://github.com/mesosphere/marathon-lb/pull/172#issuecomment-215159124","issue_url":"https://api.github.com/repos/mesosphere/marathon-lb/issues/172","id":215159124,"user":{"login":"lloesche","id":2124094,"avatar_url":"https://avatars.githubusercontent.com/u/2124094?v=3","gravatar_id":"","url":"https://api.github.com/users/lloesche","html_url":"https://github.com/lloesche","followers_url":"https://api.github.com/users/lloesche/followers","following_url":"https://api.github.com/users/lloesche/following{/other_user}","gists_url":"https://api.github.com/users/lloesche/gists{/gist_id}","starred_url":"https://api.github.com/users/lloesche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lloesche/subscriptions","organizations_url":"https://api.github.com/users/lloesche/orgs","repos_url":"https://api.github.com/users/lloesche/repos","events_url":"https://api.github.com/users/lloesche/events{/privacy}","received_events_url":"https://api.github.com/users/lloesche/received_events","type":"User","site_admin":false},"created_at":"2016-04-27T17:24:36Z","updated_at":"2016-04-27T17:24:36Z","body":"True though looking at marathon_lb.py our little Cabo servicerouter proof of concept hack has grown into quite the monster over the past two years. So rewriting it in Python is not a guarantee it's going to be more maintainable :smile:\r\nThe entire project could use some refactoring and architecture love."}}