{"action":"created","comment":{"url":"https://api.github.com/repos/openmicroscopy/omero-marshal/pulls/comments/78023634","id":78023634,"diff_hunk":"@@ -0,0 +1,44 @@\n+#!/usr/bin/env python\n+# -*- coding: utf-8 -*-\n+#\n+# Copyright (c) 2015 Glencoe Software, Inc. All rights reserved.\n+#\n+# This software is distributed under the terms described by the LICENCE file\n+# you can find at the root of the distribution bundle.\n+# If the file is missing please request a copy by contacting\n+# jason@glencoesoftware.com.\n+#\n+\n+from ... import SCHEMA_VERSION\n+from .annotation import Encoder\n+try:","path":"omero_marshal/encode/encoders/transform.py","position":14,"original_position":14,"commit_id":"e76f65da1161b5d84e148ebb7bd1f05521e9eca3","original_commit_id":"e76f65da1161b5d84e148ebb7bd1f05521e9eca3","user":{"login":"chris-allan","id":487082,"avatar_url":"https://avatars.githubusercontent.com/u/487082?v=3","gravatar_id":"","url":"https://api.github.com/users/chris-allan","html_url":"https://github.com/chris-allan","followers_url":"https://api.github.com/users/chris-allan/followers","following_url":"https://api.github.com/users/chris-allan/following{/other_user}","gists_url":"https://api.github.com/users/chris-allan/gists{/gist_id}","starred_url":"https://api.github.com/users/chris-allan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chris-allan/subscriptions","organizations_url":"https://api.github.com/users/chris-allan/orgs","repos_url":"https://api.github.com/users/chris-allan/repos","events_url":"https://api.github.com/users/chris-allan/events{/privacy}","received_events_url":"https://api.github.com/users/chris-allan/received_events","type":"User","site_admin":false},"body":"As above, let's explicitly comment why we are doing this.","created_at":"2016-09-08T14:59:19Z","updated_at":"2016-09-08T14:59:19Z","html_url":"https://github.com/openmicroscopy/omero-marshal/pull/20#discussion_r78023634","pull_request_url":"https://api.github.com/repos/openmicroscopy/omero-marshal/pulls/20","_links":{"self":{"href":"https://api.github.com/repos/openmicroscopy/omero-marshal/pulls/comments/78023634"},"html":{"href":"https://github.com/openmicroscopy/omero-marshal/pull/20#discussion_r78023634"},"pull_request":{"href":"https://api.github.com/repos/openmicroscopy/omero-marshal/pulls/20"}}},"pull_request":{"url":"https://api.github.com/repos/openmicroscopy/omero-marshal/pulls/20","id":84147863,"html_url":"https://github.com/openmicroscopy/omero-marshal/pull/20","diff_url":"https://github.com/openmicroscopy/omero-marshal/pull/20.diff","patch_url":"https://github.com/openmicroscopy/omero-marshal/pull/20.patch","issue_url":"https://api.github.com/repos/openmicroscopy/omero-marshal/issues/20","number":20,"state":"open","locked":false,"title":"Transform encoder/decoder migration","user":{"login":"sbesson","id":1355463,"avatar_url":"https://avatars.githubusercontent.com/u/1355463?v=3","gravatar_id":"","url":"https://api.github.com/users/sbesson","html_url":"https://github.com/sbesson","followers_url":"https://api.github.com/users/sbesson/followers","following_url":"https://api.github.com/users/sbesson/following{/other_user}","gists_url":"https://api.github.com/users/sbesson/gists{/gist_id}","starred_url":"https://api.github.com/users/sbesson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbesson/subscriptions","organizations_url":"https://api.github.com/users/sbesson/orgs","repos_url":"https://api.github.com/users/sbesson/repos","events_url":"https://api.github.com/users/sbesson/events{/privacy}","received_events_url":"https://api.github.com/users/sbesson/received_events","type":"User","site_admin":false},"body":"This PR follows up on the RFE mentioned in https://github.com/openmicroscopy/omero-marshal/pull/12#issuecomment-243673798.\r\n\r\nAs `AffineTransformI` is now a proper OMERO object, it makes sense to maintain a dedicated set of encoder/decoder classes and update the shape encoder/decoder logic to delegate to these classes like we do elsewhere - see the ROI encoders/decoders for instance.\r\n\r\nAn additional complication with the transforms is the fact that these objects are introduced in OMERO 5.3+. In OMERO 5.1 and 5.2, OMERO transforms are simple string attributes. As we do not want encoder/decoder classes associated with the base `string` class, the proposal of  this PR is to:\r\n- define transform encoder/decoder classes for the 2016-06 schema and onwards\r\n- modify the top-level `__init__.py` logic to handle conditional imports by catching `ImportError` and skip modules when OMERO objects can not be imported.\r\n\r\nThe implications of catching `ImportError` should certainly be considered while reviewing this PR. The tests should remain green for all versions of OMERO.","created_at":"2016-09-06T15:50:37Z","updated_at":"2016-09-08T14:59:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"80cde4390d00877f96339d85e4ea4f1c9c6144ce","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/openmicroscopy/omero-marshal/pulls/20/commits","review_comments_url":"https://api.github.com/repos/openmicroscopy/omero-marshal/pulls/20/comments","review_comment_url":"https://api.github.com/repos/openmicroscopy/omero-marshal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openmicroscopy/omero-marshal/issues/20/comments","statuses_url":"https://api.github.com/repos/openmicroscopy/omero-marshal/statuses/e76f65da1161b5d84e148ebb7bd1f05521e9eca3","head":{"label":"sbesson:transform_cleanup","ref":"transform_cleanup","sha":"e76f65da1161b5d84e148ebb7bd1f05521e9eca3","user":{"login":"sbesson","id":1355463,"avatar_url":"https://avatars.githubusercontent.com/u/1355463?v=3","gravatar_id":"","url":"https://api.github.com/users/sbesson","html_url":"https://github.com/sbesson","followers_url":"https://api.github.com/users/sbesson/followers","following_url":"https://api.github.com/users/sbesson/following{/other_user}","gists_url":"https://api.github.com/users/sbesson/gists{/gist_id}","starred_url":"https://api.github.com/users/sbesson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbesson/subscriptions","organizations_url":"https://api.github.com/users/sbesson/orgs","repos_url":"https://api.github.com/users/sbesson/repos","events_url":"https://api.github.com/users/sbesson/events{/privacy}","received_events_url":"https://api.github.com/users/sbesson/received_events","type":"User","site_admin":false},"repo":{"id":51870205,"name":"omero-marshal","full_name":"sbesson/omero-marshal","owner":{"login":"sbesson","id":1355463,"avatar_url":"https://avatars.githubusercontent.com/u/1355463?v=3","gravatar_id":"","url":"https://api.github.com/users/sbesson","html_url":"https://github.com/sbesson","followers_url":"https://api.github.com/users/sbesson/followers","following_url":"https://api.github.com/users/sbesson/following{/other_user}","gists_url":"https://api.github.com/users/sbesson/gists{/gist_id}","starred_url":"https://api.github.com/users/sbesson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbesson/subscriptions","organizations_url":"https://api.github.com/users/sbesson/orgs","repos_url":"https://api.github.com/users/sbesson/repos","events_url":"https://api.github.com/users/sbesson/events{/privacy}","received_events_url":"https://api.github.com/users/sbesson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sbesson/omero-marshal","description":"OMERO marshalling infrastructure","fork":true,"url":"https://api.github.com/repos/sbesson/omero-marshal","forks_url":"https://api.github.com/repos/sbesson/omero-marshal/forks","keys_url":"https://api.github.com/repos/sbesson/omero-marshal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sbesson/omero-marshal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sbesson/omero-marshal/teams","hooks_url":"https://api.github.com/repos/sbesson/omero-marshal/hooks","issue_events_url":"https://api.github.com/repos/sbesson/omero-marshal/issues/events{/number}","events_url":"https://api.github.com/repos/sbesson/omero-marshal/events","assignees_url":"https://api.github.com/repos/sbesson/omero-marshal/assignees{/user}","branches_url":"https://api.github.com/repos/sbesson/omero-marshal/branches{/branch}","tags_url":"https://api.github.com/repos/sbesson/omero-marshal/tags","blobs_url":"https://api.github.com/repos/sbesson/omero-marshal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sbesson/omero-marshal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sbesson/omero-marshal/git/refs{/sha}","trees_url":"https://api.github.com/repos/sbesson/omero-marshal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sbesson/omero-marshal/statuses/{sha}","languages_url":"https://api.github.com/repos/sbesson/omero-marshal/languages","stargazers_url":"https://api.github.com/repos/sbesson/omero-marshal/stargazers","contributors_url":"https://api.github.com/repos/sbesson/omero-marshal/contributors","subscribers_url":"https://api.github.com/repos/sbesson/omero-marshal/subscribers","subscription_url":"https://api.github.com/repos/sbesson/omero-marshal/subscription","commits_url":"https://api.github.com/repos/sbesson/omero-marshal/commits{/sha}","git_commits_url":"https://api.github.com/repos/sbesson/omero-marshal/git/commits{/sha}","comments_url":"https://api.github.com/repos/sbesson/omero-marshal/comments{/number}","issue_comment_url":"https://api.github.com/repos/sbesson/omero-marshal/issues/comments{/number}","contents_url":"https://api.github.com/repos/sbesson/omero-marshal/contents/{+path}","compare_url":"https://api.github.com/repos/sbesson/omero-marshal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sbesson/omero-marshal/merges","archive_url":"https://api.github.com/repos/sbesson/omero-marshal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sbesson/omero-marshal/downloads","issues_url":"https://api.github.com/repos/sbesson/omero-marshal/issues{/number}","pulls_url":"https://api.github.com/repos/sbesson/omero-marshal/pulls{/number}","milestones_url":"https://api.github.com/repos/sbesson/omero-marshal/milestones{/number}","notifications_url":"https://api.github.com/repos/sbesson/omero-marshal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sbesson/omero-marshal/labels{/name}","releases_url":"https://api.github.com/repos/sbesson/omero-marshal/releases{/id}","deployments_url":"https://api.github.com/repos/sbesson/omero-marshal/deployments","created_at":"2016-02-16T21:06:15Z","updated_at":"2016-02-16T21:06:15Z","pushed_at":"2016-09-08T14:49:20Z","git_url":"git://github.com/sbesson/omero-marshal.git","ssh_url":"git@github.com:sbesson/omero-marshal.git","clone_url":"https://github.com/sbesson/omero-marshal.git","svn_url":"https://github.com/sbesson/omero-marshal","homepage":null,"size":171,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openmicroscopy:master","ref":"master","sha":"4b528fdf17e9748f6317a7bead9345f7974c5e52","user":{"login":"openmicroscopy","id":975861,"avatar_url":"https://avatars.githubusercontent.com/u/975861?v=3","gravatar_id":"","url":"https://api.github.com/users/openmicroscopy","html_url":"https://github.com/openmicroscopy","followers_url":"https://api.github.com/users/openmicroscopy/followers","following_url":"https://api.github.com/users/openmicroscopy/following{/other_user}","gists_url":"https://api.github.com/users/openmicroscopy/gists{/gist_id}","starred_url":"https://api.github.com/users/openmicroscopy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openmicroscopy/subscriptions","organizations_url":"https://api.github.com/users/openmicroscopy/orgs","repos_url":"https://api.github.com/users/openmicroscopy/repos","events_url":"https://api.github.com/users/openmicroscopy/events{/privacy}","received_events_url":"https://api.github.com/users/openmicroscopy/received_events","type":"Organization","site_admin":false},"repo":{"id":44605466,"name":"omero-marshal","full_name":"openmicroscopy/omero-marshal","owner":{"login":"openmicroscopy","id":975861,"avatar_url":"https://avatars.githubusercontent.com/u/975861?v=3","gravatar_id":"","url":"https://api.github.com/users/openmicroscopy","html_url":"https://github.com/openmicroscopy","followers_url":"https://api.github.com/users/openmicroscopy/followers","following_url":"https://api.github.com/users/openmicroscopy/following{/other_user}","gists_url":"https://api.github.com/users/openmicroscopy/gists{/gist_id}","starred_url":"https://api.github.com/users/openmicroscopy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openmicroscopy/subscriptions","organizations_url":"https://api.github.com/users/openmicroscopy/orgs","repos_url":"https://api.github.com/users/openmicroscopy/repos","events_url":"https://api.github.com/users/openmicroscopy/events{/privacy}","received_events_url":"https://api.github.com/users/openmicroscopy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openmicroscopy/omero-marshal","description":"OMERO marshalling infrastructure","fork":false,"url":"https://api.github.com/repos/openmicroscopy/omero-marshal","forks_url":"https://api.github.com/repos/openmicroscopy/omero-marshal/forks","keys_url":"https://api.github.com/repos/openmicroscopy/omero-marshal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openmicroscopy/omero-marshal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openmicroscopy/omero-marshal/teams","hooks_url":"https://api.github.com/repos/openmicroscopy/omero-marshal/hooks","issue_events_url":"https://api.github.com/repos/openmicroscopy/omero-marshal/issues/events{/number}","events_url":"https://api.github.com/repos/openmicroscopy/omero-marshal/events","assignees_url":"https://api.github.com/repos/openmicroscopy/omero-marshal/assignees{/user}","branches_url":"https://api.github.com/repos/openmicroscopy/omero-marshal/branches{/branch}","tags_url":"https://api.github.com/repos/openmicroscopy/omero-marshal/tags","blobs_url":"https://api.github.com/repos/openmicroscopy/omero-marshal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openmicroscopy/omero-marshal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openmicroscopy/omero-marshal/git/refs{/sha}","trees_url":"https://api.github.com/repos/openmicroscopy/omero-marshal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openmicroscopy/omero-marshal/statuses/{sha}","languages_url":"https://api.github.com/repos/openmicroscopy/omero-marshal/languages","stargazers_url":"https://api.github.com/repos/openmicroscopy/omero-marshal/stargazers","contributors_url":"https://api.github.com/repos/openmicroscopy/omero-marshal/contributors","subscribers_url":"https://api.github.com/repos/openmicroscopy/omero-marshal/subscribers","subscription_url":"https://api.github.com/repos/openmicroscopy/omero-marshal/subscription","commits_url":"https://api.github.com/repos/openmicroscopy/omero-marshal/commits{/sha}","git_commits_url":"https://api.github.com/repos/openmicroscopy/omero-marshal/git/commits{/sha}","comments_url":"https://api.github.com/repos/openmicroscopy/omero-marshal/comments{/number}","issue_comment_url":"https://api.github.com/repos/openmicroscopy/omero-marshal/issues/comments{/number}","contents_url":"https://api.github.com/repos/openmicroscopy/omero-marshal/contents/{+path}","compare_url":"https://api.github.com/repos/openmicroscopy/omero-marshal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openmicroscopy/omero-marshal/merges","archive_url":"https://api.github.com/repos/openmicroscopy/omero-marshal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openmicroscopy/omero-marshal/downloads","issues_url":"https://api.github.com/repos/openmicroscopy/omero-marshal/issues{/number}","pulls_url":"https://api.github.com/repos/openmicroscopy/omero-marshal/pulls{/number}","milestones_url":"https://api.github.com/repos/openmicroscopy/omero-marshal/milestones{/number}","notifications_url":"https://api.github.com/repos/openmicroscopy/omero-marshal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openmicroscopy/omero-marshal/labels{/name}","releases_url":"https://api.github.com/repos/openmicroscopy/omero-marshal/releases{/id}","deployments_url":"https://api.github.com/repos/openmicroscopy/omero-marshal/deployments","created_at":"2015-10-20T12:43:20Z","updated_at":"2016-02-12T11:37:34Z","pushed_at":"2016-09-08T14:49:22Z","git_url":"git://github.com/openmicroscopy/omero-marshal.git","ssh_url":"git@github.com:openmicroscopy/omero-marshal.git","clone_url":"https://github.com/openmicroscopy/omero-marshal.git","svn_url":"https://github.com/openmicroscopy/omero-marshal","homepage":null,"size":168,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":4,"forks":7,"open_issues":4,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openmicroscopy/omero-marshal/pulls/20"},"html":{"href":"https://github.com/openmicroscopy/omero-marshal/pull/20"},"issue":{"href":"https://api.github.com/repos/openmicroscopy/omero-marshal/issues/20"},"comments":{"href":"https://api.github.com/repos/openmicroscopy/omero-marshal/issues/20/comments"},"review_comments":{"href":"https://api.github.com/repos/openmicroscopy/omero-marshal/pulls/20/comments"},"review_comment":{"href":"https://api.github.com/repos/openmicroscopy/omero-marshal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openmicroscopy/omero-marshal/pulls/20/commits"},"statuses":{"href":"https://api.github.com/repos/openmicroscopy/omero-marshal/statuses/e76f65da1161b5d84e148ebb7bd1f05521e9eca3"}}}}
{"actor":{"display_login":"chris-allan"}}