{"action":"created","comment":{"url":"https://api.github.com/repos/ceph/ceph/pulls/comments/69520312","id":69520312,"diff_hunk":"@@ -1498,7 +1532,23 @@ def create_partition(self, uuid, name, size=0, num=0):\n         if num == 0:\n             num = get_free_partition_index(dev=self.path)\n         if size > 0:\n-            new = '--new={num}:0:+{size}M'.format(num=num, size=size)","path":"src/ceph-disk/ceph_disk/main.py","position":66,"original_position":66,"commit_id":"a12c540748a491711cef03e68d74b74e16f72a86","original_commit_id":"a12c540748a491711cef03e68d74b74e16f72a86","user":{"login":"dachary","id":433594,"avatar_url":"https://avatars.githubusercontent.com/u/433594?v=3","gravatar_id":"","url":"https://api.github.com/users/dachary","html_url":"https://github.com/dachary","followers_url":"https://api.github.com/users/dachary/followers","following_url":"https://api.github.com/users/dachary/following{/other_user}","gists_url":"https://api.github.com/users/dachary/gists{/gist_id}","starred_url":"https://api.github.com/users/dachary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dachary/subscriptions","organizations_url":"https://api.github.com/users/dachary/orgs","repos_url":"https://api.github.com/users/dachary/repos","events_url":"https://api.github.com/users/dachary/events{/privacy}","received_events_url":"https://api.github.com/users/dachary/received_events","type":"User","site_admin":false},"body":"could you make this valuable change into a separate commit ?","created_at":"2016-07-05T07:57:19Z","updated_at":"2016-07-05T07:57:19Z","html_url":"https://github.com/ceph/ceph/pull/10135#discussion_r69520312","pull_request_url":"https://api.github.com/repos/ceph/ceph/pulls/10135","_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments/69520312"},"html":{"href":"https://github.com/ceph/ceph/pull/10135#discussion_r69520312"},"pull_request":{"href":"https://api.github.com/repos/ceph/ceph/pulls/10135"}}},"pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/10135","id":76228147,"html_url":"https://github.com/ceph/ceph/pull/10135","diff_url":"https://github.com/ceph/ceph/pull/10135.diff","patch_url":"https://github.com/ceph/ceph/pull/10135.patch","issue_url":"https://api.github.com/repos/ceph/ceph/issues/10135","number":10135,"state":"open","locked":false,"title":"ceph-disk: support creating block.db and block.wal with customized size for bluestore","user":{"login":"david-z","id":7971140,"avatar_url":"https://avatars.githubusercontent.com/u/7971140?v=3","gravatar_id":"","url":"https://api.github.com/users/david-z","html_url":"https://github.com/david-z","followers_url":"https://api.github.com/users/david-z/followers","following_url":"https://api.github.com/users/david-z/following{/other_user}","gists_url":"https://api.github.com/users/david-z/gists{/gist_id}","starred_url":"https://api.github.com/users/david-z/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/david-z/subscriptions","organizations_url":"https://api.github.com/users/david-z/orgs","repos_url":"https://api.github.com/users/david-z/repos","events_url":"https://api.github.com/users/david-z/events{/privacy}","received_events_url":"https://api.github.com/users/david-z/received_events","type":"User","site_admin":false},"body":"Within this PR, ceph-disk can create block.db and block.wal with customized size for bluestore now.\r\n\r\nFor example:\r\n\r\nceph.conf has:\r\n```\r\n[global]\r\nbluestore fsck on mount = true\r\nbluestore block db size = 67108864\r\nbluestore block wal size = 134217728\r\nbluestore block size = 5368709120\r\nosd objectstore = bluestore\r\n```\r\n\r\n```\r\nsudo ceph-disk prepare --bluestore /dev/sdb\r\n```\r\nThis will create 4 partitions on sdb as follows, then 'block.db' will symlink to partition 2, 'block.wal' will symlink to partition 3, 'block' will symlink to partition 4.\r\n\r\n```\r\nsudo sgdisk -p /dev/sdb\r\n...\r\nNumber  Start (sector)    End (sector)  Size       Code  Name\r\n   1            2048          206847   100.0 MiB   FFFF  ceph data\r\n   2          206848          337919   64.0 MiB    FFFF  ceph block.db\r\n   3          337920          600063   128.0 MiB   FFFF  ceph block.wal\r\n   4          600064        11085823   5.0 GiB     FFFF  ceph block\r\n```\r\n\r\n```\r\nsudo ceph-disk prepare --bluestore /dev/sdb \"\" /dev/sdc /dev/sdc\r\n```\r\nThis will create 2 partitions on sdb and 2 partitions on sdc, then 'block.db' will symlink to partition 1 of sdc, 'block.wal' will symlink to partition 2 of sdc, 'block' will symlink to partition 2 of sdb.\r\n\r\n\r\n```\r\nsudo ceph-disk prepare --bluestore /dev/sdb \"\" /dev/sdc1 /dev/sdd1\r\n```\r\nThis will create 2 partitions on sdb if sdc1 and sdd1 was existed before, then 'block.db' will symlink to sdc1, 'block.wal' will symlink to partition 1 of sdd1, 'block' will symlink to partition 2 of sdb.\r\n\r\n\r\nSigned-off-by: Zhi Zhang <zhangz.david@outlook.com>","created_at":"2016-07-05T07:23:22Z","updated_at":"2016-07-05T07:57:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"346954784674357a37c57b259c2cebe3f42ed078","assignee":{"login":"dachary","id":433594,"avatar_url":"https://avatars.githubusercontent.com/u/433594?v=3","gravatar_id":"","url":"https://api.github.com/users/dachary","html_url":"https://github.com/dachary","followers_url":"https://api.github.com/users/dachary/followers","following_url":"https://api.github.com/users/dachary/following{/other_user}","gists_url":"https://api.github.com/users/dachary/gists{/gist_id}","starred_url":"https://api.github.com/users/dachary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dachary/subscriptions","organizations_url":"https://api.github.com/users/dachary/orgs","repos_url":"https://api.github.com/users/dachary/repos","events_url":"https://api.github.com/users/dachary/events{/privacy}","received_events_url":"https://api.github.com/users/dachary/received_events","type":"User","site_admin":false},"assignees":[{"login":"dachary","id":433594,"avatar_url":"https://avatars.githubusercontent.com/u/433594?v=3","gravatar_id":"","url":"https://api.github.com/users/dachary","html_url":"https://github.com/dachary","followers_url":"https://api.github.com/users/dachary/followers","following_url":"https://api.github.com/users/dachary/following{/other_user}","gists_url":"https://api.github.com/users/dachary/gists{/gist_id}","starred_url":"https://api.github.com/users/dachary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dachary/subscriptions","organizations_url":"https://api.github.com/users/dachary/orgs","repos_url":"https://api.github.com/users/dachary/repos","events_url":"https://api.github.com/users/dachary/events{/privacy}","received_events_url":"https://api.github.com/users/dachary/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ceph/ceph/pulls/10135/commits","review_comments_url":"https://api.github.com/repos/ceph/ceph/pulls/10135/comments","review_comment_url":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/10135/comments","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/a12c540748a491711cef03e68d74b74e16f72a86","head":{"label":"david-z:wip-enhance-ceph-disk-bluestore","ref":"wip-enhance-ceph-disk-bluestore","sha":"a12c540748a491711cef03e68d74b74e16f72a86","user":{"login":"david-z","id":7971140,"avatar_url":"https://avatars.githubusercontent.com/u/7971140?v=3","gravatar_id":"","url":"https://api.github.com/users/david-z","html_url":"https://github.com/david-z","followers_url":"https://api.github.com/users/david-z/followers","following_url":"https://api.github.com/users/david-z/following{/other_user}","gists_url":"https://api.github.com/users/david-z/gists{/gist_id}","starred_url":"https://api.github.com/users/david-z/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/david-z/subscriptions","organizations_url":"https://api.github.com/users/david-z/orgs","repos_url":"https://api.github.com/users/david-z/repos","events_url":"https://api.github.com/users/david-z/events{/privacy}","received_events_url":"https://api.github.com/users/david-z/received_events","type":"User","site_admin":false},"repo":{"id":39481075,"name":"ceph","full_name":"david-z/ceph","owner":{"login":"david-z","id":7971140,"avatar_url":"https://avatars.githubusercontent.com/u/7971140?v=3","gravatar_id":"","url":"https://api.github.com/users/david-z","html_url":"https://github.com/david-z","followers_url":"https://api.github.com/users/david-z/followers","following_url":"https://api.github.com/users/david-z/following{/other_user}","gists_url":"https://api.github.com/users/david-z/gists{/gist_id}","starred_url":"https://api.github.com/users/david-z/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/david-z/subscriptions","organizations_url":"https://api.github.com/users/david-z/orgs","repos_url":"https://api.github.com/users/david-z/repos","events_url":"https://api.github.com/users/david-z/events{/privacy}","received_events_url":"https://api.github.com/users/david-z/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/david-z/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":true,"url":"https://api.github.com/repos/david-z/ceph","forks_url":"https://api.github.com/repos/david-z/ceph/forks","keys_url":"https://api.github.com/repos/david-z/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/david-z/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/david-z/ceph/teams","hooks_url":"https://api.github.com/repos/david-z/ceph/hooks","issue_events_url":"https://api.github.com/repos/david-z/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/david-z/ceph/events","assignees_url":"https://api.github.com/repos/david-z/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/david-z/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/david-z/ceph/tags","blobs_url":"https://api.github.com/repos/david-z/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/david-z/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/david-z/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/david-z/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/david-z/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/david-z/ceph/languages","stargazers_url":"https://api.github.com/repos/david-z/ceph/stargazers","contributors_url":"https://api.github.com/repos/david-z/ceph/contributors","subscribers_url":"https://api.github.com/repos/david-z/ceph/subscribers","subscription_url":"https://api.github.com/repos/david-z/ceph/subscription","commits_url":"https://api.github.com/repos/david-z/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/david-z/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/david-z/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/david-z/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/david-z/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/david-z/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/david-z/ceph/merges","archive_url":"https://api.github.com/repos/david-z/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/david-z/ceph/downloads","issues_url":"https://api.github.com/repos/david-z/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/david-z/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/david-z/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/david-z/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/david-z/ceph/labels{/name}","releases_url":"https://api.github.com/repos/david-z/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/david-z/ceph/deployments","created_at":"2015-07-22T02:30:11Z","updated_at":"2016-03-16T02:36:53Z","pushed_at":"2016-07-05T06:56:36Z","git_url":"git://github.com/david-z/ceph.git","ssh_url":"git@github.com:david-z/ceph.git","clone_url":"https://github.com/david-z/ceph.git","svn_url":"https://github.com/david-z/ceph","homepage":"http://ceph.com","size":166398,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"ceph:master","ref":"master","sha":"5485296a3da76259abf44c6a44a0d698ca8cb185","user":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":2310495,"name":"ceph","full_name":"ceph/ceph","owner":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ceph/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":false,"url":"https://api.github.com/repos/ceph/ceph","forks_url":"https://api.github.com/repos/ceph/ceph/forks","keys_url":"https://api.github.com/repos/ceph/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph/teams","hooks_url":"https://api.github.com/repos/ceph/ceph/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph/events","assignees_url":"https://api.github.com/repos/ceph/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph/tags","blobs_url":"https://api.github.com/repos/ceph/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph/subscription","commits_url":"https://api.github.com/repos/ceph/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph/merges","archive_url":"https://api.github.com/repos/ceph/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph/downloads","issues_url":"https://api.github.com/repos/ceph/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/ceph/ceph/deployments","created_at":"2011-09-01T21:41:26Z","updated_at":"2016-07-05T07:48:14Z","pushed_at":"2016-07-05T07:28:34Z","git_url":"git://github.com/ceph/ceph.git","ssh_url":"git@github.com:ceph/ceph.git","clone_url":"https://github.com/ceph/ceph.git","svn_url":"https://github.com/ceph/ceph","homepage":"http://ceph.com","size":224951,"stargazers_count":2278,"watchers_count":2278,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1353,"mirror_url":null,"open_issues_count":451,"forks":1353,"open_issues":451,"watchers":2278,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/10135"},"html":{"href":"https://github.com/ceph/ceph/pull/10135"},"issue":{"href":"https://api.github.com/repos/ceph/ceph/issues/10135"},"comments":{"href":"https://api.github.com/repos/ceph/ceph/issues/10135/comments"},"review_comments":{"href":"https://api.github.com/repos/ceph/ceph/pulls/10135/comments"},"review_comment":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ceph/ceph/pulls/10135/commits"},"statuses":{"href":"https://api.github.com/repos/ceph/ceph/statuses/a12c540748a491711cef03e68d74b74e16f72a86"}}}}
{"actor":{"display_login":"dachary"}}