{"action":"opened","number":11,"pull_request":{"url":"https://api.github.com/repos/scalingdata/sarama/pulls/11","id":98461042,"html_url":"https://github.com/scalingdata/sarama/pull/11","diff_url":"https://github.com/scalingdata/sarama/pull/11.diff","patch_url":"https://github.com/scalingdata/sarama/pull/11.patch","issue_url":"https://api.github.com/repos/scalingdata/sarama/issues/11","number":11,"state":"open","locked":false,"title":"Client can't recover from broker outages","user":{"login":"alanctgardner","id":3100188,"avatar_url":"https://avatars.githubusercontent.com/u/3100188?v=3","gravatar_id":"","url":"https://api.github.com/users/alanctgardner","html_url":"https://github.com/alanctgardner","followers_url":"https://api.github.com/users/alanctgardner/followers","following_url":"https://api.github.com/users/alanctgardner/following{/other_user}","gists_url":"https://api.github.com/users/alanctgardner/gists{/gist_id}","starred_url":"https://api.github.com/users/alanctgardner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alanctgardner/subscriptions","organizations_url":"https://api.github.com/users/alanctgardner/orgs","repos_url":"https://api.github.com/users/alanctgardner/repos","events_url":"https://api.github.com/users/alanctgardner/events{/privacy}","received_events_url":"https://api.github.com/users/alanctgardner/received_events","type":"User","site_admin":false},"body":"This adds a bunch of useful logging to understand how brokers are penalized. \r\n\r\nThe root cause was:\r\n- `waitForSingleConnection` only uses the list of seed brokers\r\n- in `tryRefreshMetadata` if `waitForSingleConnection` fails, we short-circuit the whole method, which means we never call `resurrectDeadBrokers`\r\n\r\nOn a heavily loaded producer there was a race condition where the set of seed brokers could be empty, and all the calls to `tryRefreshMetadata` would fail forever. The solution was to ensure we always resurrect the seed brokers if the broker list becomes empty.","created_at":"2016-12-18T00:59:28Z","updated_at":"2016-12-18T00:59:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/scalingdata/sarama/pulls/11/commits","review_comments_url":"https://api.github.com/repos/scalingdata/sarama/pulls/11/comments","review_comment_url":"https://api.github.com/repos/scalingdata/sarama/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scalingdata/sarama/issues/11/comments","statuses_url":"https://api.github.com/repos/scalingdata/sarama/statuses/d245b6ab6ad137a1925db40469821607025c3ba6","head":{"label":"scalingdata:exp/loss-of-connectivity","ref":"exp/loss-of-connectivity","sha":"d245b6ab6ad137a1925db40469821607025c3ba6","user":{"login":"scalingdata","id":6448302,"avatar_url":"https://avatars.githubusercontent.com/u/6448302?v=3","gravatar_id":"","url":"https://api.github.com/users/scalingdata","html_url":"https://github.com/scalingdata","followers_url":"https://api.github.com/users/scalingdata/followers","following_url":"https://api.github.com/users/scalingdata/following{/other_user}","gists_url":"https://api.github.com/users/scalingdata/gists{/gist_id}","starred_url":"https://api.github.com/users/scalingdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scalingdata/subscriptions","organizations_url":"https://api.github.com/users/scalingdata/orgs","repos_url":"https://api.github.com/users/scalingdata/repos","events_url":"https://api.github.com/users/scalingdata/events{/privacy}","received_events_url":"https://api.github.com/users/scalingdata/received_events","type":"Organization","site_admin":false},"repo":{"id":22360341,"name":"sarama","full_name":"scalingdata/sarama","owner":{"login":"scalingdata","id":6448302,"avatar_url":"https://avatars.githubusercontent.com/u/6448302?v=3","gravatar_id":"","url":"https://api.github.com/users/scalingdata","html_url":"https://github.com/scalingdata","followers_url":"https://api.github.com/users/scalingdata/followers","following_url":"https://api.github.com/users/scalingdata/following{/other_user}","gists_url":"https://api.github.com/users/scalingdata/gists{/gist_id}","starred_url":"https://api.github.com/users/scalingdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scalingdata/subscriptions","organizations_url":"https://api.github.com/users/scalingdata/orgs","repos_url":"https://api.github.com/users/scalingdata/repos","events_url":"https://api.github.com/users/scalingdata/events{/privacy}","received_events_url":"https://api.github.com/users/scalingdata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scalingdata/sarama","description":"Sarama is a Go library for Apache Kafka 0.8 ","fork":true,"url":"https://api.github.com/repos/scalingdata/sarama","forks_url":"https://api.github.com/repos/scalingdata/sarama/forks","keys_url":"https://api.github.com/repos/scalingdata/sarama/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scalingdata/sarama/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scalingdata/sarama/teams","hooks_url":"https://api.github.com/repos/scalingdata/sarama/hooks","issue_events_url":"https://api.github.com/repos/scalingdata/sarama/issues/events{/number}","events_url":"https://api.github.com/repos/scalingdata/sarama/events","assignees_url":"https://api.github.com/repos/scalingdata/sarama/assignees{/user}","branches_url":"https://api.github.com/repos/scalingdata/sarama/branches{/branch}","tags_url":"https://api.github.com/repos/scalingdata/sarama/tags","blobs_url":"https://api.github.com/repos/scalingdata/sarama/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scalingdata/sarama/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scalingdata/sarama/git/refs{/sha}","trees_url":"https://api.github.com/repos/scalingdata/sarama/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scalingdata/sarama/statuses/{sha}","languages_url":"https://api.github.com/repos/scalingdata/sarama/languages","stargazers_url":"https://api.github.com/repos/scalingdata/sarama/stargazers","contributors_url":"https://api.github.com/repos/scalingdata/sarama/contributors","subscribers_url":"https://api.github.com/repos/scalingdata/sarama/subscribers","subscription_url":"https://api.github.com/repos/scalingdata/sarama/subscription","commits_url":"https://api.github.com/repos/scalingdata/sarama/commits{/sha}","git_commits_url":"https://api.github.com/repos/scalingdata/sarama/git/commits{/sha}","comments_url":"https://api.github.com/repos/scalingdata/sarama/comments{/number}","issue_comment_url":"https://api.github.com/repos/scalingdata/sarama/issues/comments{/number}","contents_url":"https://api.github.com/repos/scalingdata/sarama/contents/{+path}","compare_url":"https://api.github.com/repos/scalingdata/sarama/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scalingdata/sarama/merges","archive_url":"https://api.github.com/repos/scalingdata/sarama/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scalingdata/sarama/downloads","issues_url":"https://api.github.com/repos/scalingdata/sarama/issues{/number}","pulls_url":"https://api.github.com/repos/scalingdata/sarama/pulls{/number}","milestones_url":"https://api.github.com/repos/scalingdata/sarama/milestones{/number}","notifications_url":"https://api.github.com/repos/scalingdata/sarama/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scalingdata/sarama/labels{/name}","releases_url":"https://api.github.com/repos/scalingdata/sarama/releases{/id}","deployments_url":"https://api.github.com/repos/scalingdata/sarama/deployments","created_at":"2014-07-28T22:37:57Z","updated_at":"2016-02-25T22:22:29Z","pushed_at":"2016-12-18T00:53:58Z","git_url":"git://github.com/scalingdata/sarama.git","ssh_url":"git@github.com:scalingdata/sarama.git","clone_url":"https://github.com/scalingdata/sarama.git","svn_url":"https://github.com/scalingdata/sarama","homepage":"http://shopify.github.io/sarama","size":1750,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"scalingdata:master","ref":"master","sha":"9016c6fb9d3239e34339dfff470780b8b1490c39","user":{"login":"scalingdata","id":6448302,"avatar_url":"https://avatars.githubusercontent.com/u/6448302?v=3","gravatar_id":"","url":"https://api.github.com/users/scalingdata","html_url":"https://github.com/scalingdata","followers_url":"https://api.github.com/users/scalingdata/followers","following_url":"https://api.github.com/users/scalingdata/following{/other_user}","gists_url":"https://api.github.com/users/scalingdata/gists{/gist_id}","starred_url":"https://api.github.com/users/scalingdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scalingdata/subscriptions","organizations_url":"https://api.github.com/users/scalingdata/orgs","repos_url":"https://api.github.com/users/scalingdata/repos","events_url":"https://api.github.com/users/scalingdata/events{/privacy}","received_events_url":"https://api.github.com/users/scalingdata/received_events","type":"Organization","site_admin":false},"repo":{"id":22360341,"name":"sarama","full_name":"scalingdata/sarama","owner":{"login":"scalingdata","id":6448302,"avatar_url":"https://avatars.githubusercontent.com/u/6448302?v=3","gravatar_id":"","url":"https://api.github.com/users/scalingdata","html_url":"https://github.com/scalingdata","followers_url":"https://api.github.com/users/scalingdata/followers","following_url":"https://api.github.com/users/scalingdata/following{/other_user}","gists_url":"https://api.github.com/users/scalingdata/gists{/gist_id}","starred_url":"https://api.github.com/users/scalingdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scalingdata/subscriptions","organizations_url":"https://api.github.com/users/scalingdata/orgs","repos_url":"https://api.github.com/users/scalingdata/repos","events_url":"https://api.github.com/users/scalingdata/events{/privacy}","received_events_url":"https://api.github.com/users/scalingdata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scalingdata/sarama","description":"Sarama is a Go library for Apache Kafka 0.8 ","fork":true,"url":"https://api.github.com/repos/scalingdata/sarama","forks_url":"https://api.github.com/repos/scalingdata/sarama/forks","keys_url":"https://api.github.com/repos/scalingdata/sarama/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scalingdata/sarama/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scalingdata/sarama/teams","hooks_url":"https://api.github.com/repos/scalingdata/sarama/hooks","issue_events_url":"https://api.github.com/repos/scalingdata/sarama/issues/events{/number}","events_url":"https://api.github.com/repos/scalingdata/sarama/events","assignees_url":"https://api.github.com/repos/scalingdata/sarama/assignees{/user}","branches_url":"https://api.github.com/repos/scalingdata/sarama/branches{/branch}","tags_url":"https://api.github.com/repos/scalingdata/sarama/tags","blobs_url":"https://api.github.com/repos/scalingdata/sarama/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scalingdata/sarama/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scalingdata/sarama/git/refs{/sha}","trees_url":"https://api.github.com/repos/scalingdata/sarama/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scalingdata/sarama/statuses/{sha}","languages_url":"https://api.github.com/repos/scalingdata/sarama/languages","stargazers_url":"https://api.github.com/repos/scalingdata/sarama/stargazers","contributors_url":"https://api.github.com/repos/scalingdata/sarama/contributors","subscribers_url":"https://api.github.com/repos/scalingdata/sarama/subscribers","subscription_url":"https://api.github.com/repos/scalingdata/sarama/subscription","commits_url":"https://api.github.com/repos/scalingdata/sarama/commits{/sha}","git_commits_url":"https://api.github.com/repos/scalingdata/sarama/git/commits{/sha}","comments_url":"https://api.github.com/repos/scalingdata/sarama/comments{/number}","issue_comment_url":"https://api.github.com/repos/scalingdata/sarama/issues/comments{/number}","contents_url":"https://api.github.com/repos/scalingdata/sarama/contents/{+path}","compare_url":"https://api.github.com/repos/scalingdata/sarama/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scalingdata/sarama/merges","archive_url":"https://api.github.com/repos/scalingdata/sarama/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scalingdata/sarama/downloads","issues_url":"https://api.github.com/repos/scalingdata/sarama/issues{/number}","pulls_url":"https://api.github.com/repos/scalingdata/sarama/pulls{/number}","milestones_url":"https://api.github.com/repos/scalingdata/sarama/milestones{/number}","notifications_url":"https://api.github.com/repos/scalingdata/sarama/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scalingdata/sarama/labels{/name}","releases_url":"https://api.github.com/repos/scalingdata/sarama/releases{/id}","deployments_url":"https://api.github.com/repos/scalingdata/sarama/deployments","created_at":"2014-07-28T22:37:57Z","updated_at":"2016-02-25T22:22:29Z","pushed_at":"2016-12-18T00:53:58Z","git_url":"git://github.com/scalingdata/sarama.git","ssh_url":"git@github.com:scalingdata/sarama.git","clone_url":"https://github.com/scalingdata/sarama.git","svn_url":"https://github.com/scalingdata/sarama","homepage":"http://shopify.github.io/sarama","size":1750,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scalingdata/sarama/pulls/11"},"html":{"href":"https://github.com/scalingdata/sarama/pull/11"},"issue":{"href":"https://api.github.com/repos/scalingdata/sarama/issues/11"},"comments":{"href":"https://api.github.com/repos/scalingdata/sarama/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/scalingdata/sarama/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/scalingdata/sarama/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scalingdata/sarama/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/scalingdata/sarama/statuses/d245b6ab6ad137a1925db40469821607025c3ba6"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":10,"deletions":5,"changed_files":3}}
{"actor":{"display_login":"alanctgardner"}}