{"action":"created","comment":{"url":"https://api.github.com/repos/typesafehub/conductr-cli/pulls/comments/86290310","pull_request_review_id":6954537,"id":86290310,"diff_hunk":"@@ -283,7 +283,7 @@ def build_parser(dcos_mode):\n \n def get_cli_parameters(args):\n     parameters = ['']\n-    if not args.dcos_mode:\n+    if not vars(args).get('dcos_mode'):","path":"conductr_cli/conduct_main.py","position":5,"original_position":5,"commit_id":"5e9acb9bff9747e4cc306746134f205f22462326","original_commit_id":"5e9acb9bff9747e4cc306746134f205f22462326","user":{"login":"huntc","id":694893,"avatar_url":"https://avatars.githubusercontent.com/u/694893?v=3","gravatar_id":"","url":"https://api.github.com/users/huntc","html_url":"https://github.com/huntc","followers_url":"https://api.github.com/users/huntc/followers","following_url":"https://api.github.com/users/huntc/following{/other_user}","gists_url":"https://api.github.com/users/huntc/gists{/gist_id}","starred_url":"https://api.github.com/users/huntc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huntc/subscriptions","organizations_url":"https://api.github.com/users/huntc/orgs","repos_url":"https://api.github.com/users/huntc/repos","events_url":"https://api.github.com/users/huntc/events{/privacy}","received_events_url":"https://api.github.com/users/huntc/received_events","type":"User","site_admin":false},"body":"dcos_mode should always be set. It is a bug if not. ","created_at":"2016-11-03T06:19:58Z","updated_at":"2016-11-03T06:20:13Z","html_url":"https://github.com/typesafehub/conductr-cli/pull/181#discussion_r86290310","pull_request_url":"https://api.github.com/repos/typesafehub/conductr-cli/pulls/181","_links":{"self":{"href":"https://api.github.com/repos/typesafehub/conductr-cli/pulls/comments/86290310"},"html":{"href":"https://github.com/typesafehub/conductr-cli/pull/181#discussion_r86290310"},"pull_request":{"href":"https://api.github.com/repos/typesafehub/conductr-cli/pulls/181"}}},"pull_request":{"url":"https://api.github.com/repos/typesafehub/conductr-cli/pulls/181","id":92094454,"html_url":"https://github.com/typesafehub/conductr-cli/pull/181","diff_url":"https://github.com/typesafehub/conductr-cli/pull/181.diff","patch_url":"https://github.com/typesafehub/conductr-cli/pull/181.patch","issue_url":"https://api.github.com/repos/typesafehub/conductr-cli/issues/181","number":181,"state":"open","locked":false,"title":"WIP - DON'T MERGE - Various fixes in preparation for ConductR 2.0.0-RC1","user":{"login":"fsat","id":1665611,"avatar_url":"https://avatars.githubusercontent.com/u/1665611?v=3","gravatar_id":"","url":"https://api.github.com/users/fsat","html_url":"https://github.com/fsat","followers_url":"https://api.github.com/users/fsat/followers","following_url":"https://api.github.com/users/fsat/following{/other_user}","gists_url":"https://api.github.com/users/fsat/gists{/gist_id}","starred_url":"https://api.github.com/users/fsat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fsat/subscriptions","organizations_url":"https://api.github.com/users/fsat/orgs","repos_url":"https://api.github.com/users/fsat/repos","events_url":"https://api.github.com/users/fsat/events{/privacy}","received_events_url":"https://api.github.com/users/fsat/received_events","type":"User","site_admin":false},"body":"- Fix conduct version failing with object missing dcos_mode. This fixes issue https://github.com/typesafehub/conductr-cli/issues/179","created_at":"2016-11-03T04:10:22Z","updated_at":"2016-11-03T06:20:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a46a0b42e662602deb5706975a71272d8f4f7644","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/typesafehub/conductr-cli/pulls/181/commits","review_comments_url":"https://api.github.com/repos/typesafehub/conductr-cli/pulls/181/comments","review_comment_url":"https://api.github.com/repos/typesafehub/conductr-cli/pulls/comments{/number}","comments_url":"https://api.github.com/repos/typesafehub/conductr-cli/issues/181/comments","statuses_url":"https://api.github.com/repos/typesafehub/conductr-cli/statuses/5e9acb9bff9747e4cc306746134f205f22462326","head":{"label":"fsat:2.0.0-rc1-fixes","ref":"2.0.0-rc1-fixes","sha":"5e9acb9bff9747e4cc306746134f205f22462326","user":{"login":"fsat","id":1665611,"avatar_url":"https://avatars.githubusercontent.com/u/1665611?v=3","gravatar_id":"","url":"https://api.github.com/users/fsat","html_url":"https://github.com/fsat","followers_url":"https://api.github.com/users/fsat/followers","following_url":"https://api.github.com/users/fsat/following{/other_user}","gists_url":"https://api.github.com/users/fsat/gists{/gist_id}","starred_url":"https://api.github.com/users/fsat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fsat/subscriptions","organizations_url":"https://api.github.com/users/fsat/orgs","repos_url":"https://api.github.com/users/fsat/repos","events_url":"https://api.github.com/users/fsat/events{/privacy}","received_events_url":"https://api.github.com/users/fsat/received_events","type":"User","site_admin":false},"repo":{"id":39754747,"name":"conductr-cli","full_name":"fsat/conductr-cli","owner":{"login":"fsat","id":1665611,"avatar_url":"https://avatars.githubusercontent.com/u/1665611?v=3","gravatar_id":"","url":"https://api.github.com/users/fsat","html_url":"https://github.com/fsat","followers_url":"https://api.github.com/users/fsat/followers","following_url":"https://api.github.com/users/fsat/following{/other_user}","gists_url":"https://api.github.com/users/fsat/gists{/gist_id}","starred_url":"https://api.github.com/users/fsat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fsat/subscriptions","organizations_url":"https://api.github.com/users/fsat/orgs","repos_url":"https://api.github.com/users/fsat/repos","events_url":"https://api.github.com/users/fsat/events{/privacy}","received_events_url":"https://api.github.com/users/fsat/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fsat/conductr-cli","description":"CLI for Typesafe ConductR","fork":true,"url":"https://api.github.com/repos/fsat/conductr-cli","forks_url":"https://api.github.com/repos/fsat/conductr-cli/forks","keys_url":"https://api.github.com/repos/fsat/conductr-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fsat/conductr-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fsat/conductr-cli/teams","hooks_url":"https://api.github.com/repos/fsat/conductr-cli/hooks","issue_events_url":"https://api.github.com/repos/fsat/conductr-cli/issues/events{/number}","events_url":"https://api.github.com/repos/fsat/conductr-cli/events","assignees_url":"https://api.github.com/repos/fsat/conductr-cli/assignees{/user}","branches_url":"https://api.github.com/repos/fsat/conductr-cli/branches{/branch}","tags_url":"https://api.github.com/repos/fsat/conductr-cli/tags","blobs_url":"https://api.github.com/repos/fsat/conductr-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fsat/conductr-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fsat/conductr-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/fsat/conductr-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fsat/conductr-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/fsat/conductr-cli/languages","stargazers_url":"https://api.github.com/repos/fsat/conductr-cli/stargazers","contributors_url":"https://api.github.com/repos/fsat/conductr-cli/contributors","subscribers_url":"https://api.github.com/repos/fsat/conductr-cli/subscribers","subscription_url":"https://api.github.com/repos/fsat/conductr-cli/subscription","commits_url":"https://api.github.com/repos/fsat/conductr-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/fsat/conductr-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/fsat/conductr-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/fsat/conductr-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/fsat/conductr-cli/contents/{+path}","compare_url":"https://api.github.com/repos/fsat/conductr-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fsat/conductr-cli/merges","archive_url":"https://api.github.com/repos/fsat/conductr-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fsat/conductr-cli/downloads","issues_url":"https://api.github.com/repos/fsat/conductr-cli/issues{/number}","pulls_url":"https://api.github.com/repos/fsat/conductr-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/fsat/conductr-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/fsat/conductr-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fsat/conductr-cli/labels{/name}","releases_url":"https://api.github.com/repos/fsat/conductr-cli/releases{/id}","deployments_url":"https://api.github.com/repos/fsat/conductr-cli/deployments","created_at":"2015-07-27T04:16:40Z","updated_at":"2016-02-19T06:18:57Z","pushed_at":"2016-11-03T05:38:57Z","git_url":"git://github.com/fsat/conductr-cli.git","ssh_url":"git@github.com:fsat/conductr-cli.git","clone_url":"https://github.com/fsat/conductr-cli.git","svn_url":"https://github.com/fsat/conductr-cli","homepage":"","size":528,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"typesafehub:master","ref":"master","sha":"d3c2073970ceecfb9c335d4d989ff8512073c019","user":{"login":"typesafehub","id":784923,"avatar_url":"https://avatars.githubusercontent.com/u/784923?v=3","gravatar_id":"","url":"https://api.github.com/users/typesafehub","html_url":"https://github.com/typesafehub","followers_url":"https://api.github.com/users/typesafehub/followers","following_url":"https://api.github.com/users/typesafehub/following{/other_user}","gists_url":"https://api.github.com/users/typesafehub/gists{/gist_id}","starred_url":"https://api.github.com/users/typesafehub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/typesafehub/subscriptions","organizations_url":"https://api.github.com/users/typesafehub/orgs","repos_url":"https://api.github.com/users/typesafehub/repos","events_url":"https://api.github.com/users/typesafehub/events{/privacy}","received_events_url":"https://api.github.com/users/typesafehub/received_events","type":"Organization","site_admin":false},"repo":{"id":28919275,"name":"conductr-cli","full_name":"typesafehub/conductr-cli","owner":{"login":"typesafehub","id":784923,"avatar_url":"https://avatars.githubusercontent.com/u/784923?v=3","gravatar_id":"","url":"https://api.github.com/users/typesafehub","html_url":"https://github.com/typesafehub","followers_url":"https://api.github.com/users/typesafehub/followers","following_url":"https://api.github.com/users/typesafehub/following{/other_user}","gists_url":"https://api.github.com/users/typesafehub/gists{/gist_id}","starred_url":"https://api.github.com/users/typesafehub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/typesafehub/subscriptions","organizations_url":"https://api.github.com/users/typesafehub/orgs","repos_url":"https://api.github.com/users/typesafehub/repos","events_url":"https://api.github.com/users/typesafehub/events{/privacy}","received_events_url":"https://api.github.com/users/typesafehub/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/typesafehub/conductr-cli","description":"CLI for Typesafe ConductR","fork":false,"url":"https://api.github.com/repos/typesafehub/conductr-cli","forks_url":"https://api.github.com/repos/typesafehub/conductr-cli/forks","keys_url":"https://api.github.com/repos/typesafehub/conductr-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/typesafehub/conductr-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/typesafehub/conductr-cli/teams","hooks_url":"https://api.github.com/repos/typesafehub/conductr-cli/hooks","issue_events_url":"https://api.github.com/repos/typesafehub/conductr-cli/issues/events{/number}","events_url":"https://api.github.com/repos/typesafehub/conductr-cli/events","assignees_url":"https://api.github.com/repos/typesafehub/conductr-cli/assignees{/user}","branches_url":"https://api.github.com/repos/typesafehub/conductr-cli/branches{/branch}","tags_url":"https://api.github.com/repos/typesafehub/conductr-cli/tags","blobs_url":"https://api.github.com/repos/typesafehub/conductr-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/typesafehub/conductr-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/typesafehub/conductr-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/typesafehub/conductr-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/typesafehub/conductr-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/typesafehub/conductr-cli/languages","stargazers_url":"https://api.github.com/repos/typesafehub/conductr-cli/stargazers","contributors_url":"https://api.github.com/repos/typesafehub/conductr-cli/contributors","subscribers_url":"https://api.github.com/repos/typesafehub/conductr-cli/subscribers","subscription_url":"https://api.github.com/repos/typesafehub/conductr-cli/subscription","commits_url":"https://api.github.com/repos/typesafehub/conductr-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/typesafehub/conductr-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/typesafehub/conductr-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/typesafehub/conductr-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/typesafehub/conductr-cli/contents/{+path}","compare_url":"https://api.github.com/repos/typesafehub/conductr-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/typesafehub/conductr-cli/merges","archive_url":"https://api.github.com/repos/typesafehub/conductr-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/typesafehub/conductr-cli/downloads","issues_url":"https://api.github.com/repos/typesafehub/conductr-cli/issues{/number}","pulls_url":"https://api.github.com/repos/typesafehub/conductr-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/typesafehub/conductr-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/typesafehub/conductr-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/typesafehub/conductr-cli/labels{/name}","releases_url":"https://api.github.com/repos/typesafehub/conductr-cli/releases{/id}","deployments_url":"https://api.github.com/repos/typesafehub/conductr-cli/deployments","created_at":"2015-01-07T15:04:13Z","updated_at":"2016-10-27T06:25:03Z","pushed_at":"2016-11-03T05:38:58Z","git_url":"git://github.com/typesafehub/conductr-cli.git","ssh_url":"git@github.com:typesafehub/conductr-cli.git","clone_url":"https://github.com/typesafehub/conductr-cli.git","svn_url":"https://github.com/typesafehub/conductr-cli","homepage":"","size":496,"stargazers_count":12,"watchers_count":12,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":24,"forks":11,"open_issues":24,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/typesafehub/conductr-cli/pulls/181"},"html":{"href":"https://github.com/typesafehub/conductr-cli/pull/181"},"issue":{"href":"https://api.github.com/repos/typesafehub/conductr-cli/issues/181"},"comments":{"href":"https://api.github.com/repos/typesafehub/conductr-cli/issues/181/comments"},"review_comments":{"href":"https://api.github.com/repos/typesafehub/conductr-cli/pulls/181/comments"},"review_comment":{"href":"https://api.github.com/repos/typesafehub/conductr-cli/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/typesafehub/conductr-cli/pulls/181/commits"},"statuses":{"href":"https://api.github.com/repos/typesafehub/conductr-cli/statuses/5e9acb9bff9747e4cc306746134f205f22462326"}}}}
{"actor":{"display_login":"huntc"}}