{"action":"created","issue":{"url":"https://api.github.com/repos/lale-help/lale-help/issues/122","repository_url":"https://api.github.com/repos/lale-help/lale-help","labels_url":"https://api.github.com/repos/lale-help/lale-help/issues/122/labels{/name}","comments_url":"https://api.github.com/repos/lale-help/lale-help/issues/122/comments","events_url":"https://api.github.com/repos/lale-help/lale-help/issues/122/events","html_url":"https://github.com/lale-help/lale-help/issues/122","id":131588638,"number":122,"title":"Route new member signup to admin for approval","user":{"login":"dottorer","id":14217285,"avatar_url":"https://avatars.githubusercontent.com/u/14217285?v=3","gravatar_id":"","url":"https://api.github.com/users/dottorer","html_url":"https://github.com/dottorer","followers_url":"https://api.github.com/users/dottorer/followers","following_url":"https://api.github.com/users/dottorer/following{/other_user}","gists_url":"https://api.github.com/users/dottorer/gists{/gist_id}","starred_url":"https://api.github.com/users/dottorer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dottorer/subscriptions","organizations_url":"https://api.github.com/users/dottorer/orgs","repos_url":"https://api.github.com/users/dottorer/repos","events_url":"https://api.github.com/users/dottorer/events{/privacy}","received_events_url":"https://api.github.com/users/dottorer/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/lale-help/lale-help/labels/priority:high","name":"priority:high","color":"e11d21"}],"state":"open","locked":false,"assignee":{"login":"phillipoertel","id":5188,"avatar_url":"https://avatars.githubusercontent.com/u/5188?v=3","gravatar_id":"","url":"https://api.github.com/users/phillipoertel","html_url":"https://github.com/phillipoertel","followers_url":"https://api.github.com/users/phillipoertel/followers","following_url":"https://api.github.com/users/phillipoertel/following{/other_user}","gists_url":"https://api.github.com/users/phillipoertel/gists{/gist_id}","starred_url":"https://api.github.com/users/phillipoertel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phillipoertel/subscriptions","organizations_url":"https://api.github.com/users/phillipoertel/orgs","repos_url":"https://api.github.com/users/phillipoertel/repos","events_url":"https://api.github.com/users/phillipoertel/events{/privacy}","received_events_url":"https://api.github.com/users/phillipoertel/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/lale-help/lale-help/milestones/4","html_url":"https://github.com/lale-help/lale-help/milestones/mvp2","labels_url":"https://api.github.com/repos/lale-help/lale-help/milestones/4/labels","id":1541389,"number":4,"title":"mvp2","description":"Next iteration of the platform including features that did not make mvp1. Target end of March.","creator":{"login":"dottorer","id":14217285,"avatar_url":"https://avatars.githubusercontent.com/u/14217285?v=3","gravatar_id":"","url":"https://api.github.com/users/dottorer","html_url":"https://github.com/dottorer","followers_url":"https://api.github.com/users/dottorer/followers","following_url":"https://api.github.com/users/dottorer/following{/other_user}","gists_url":"https://api.github.com/users/dottorer/gists{/gist_id}","starred_url":"https://api.github.com/users/dottorer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dottorer/subscriptions","organizations_url":"https://api.github.com/users/dottorer/orgs","repos_url":"https://api.github.com/users/dottorer/repos","events_url":"https://api.github.com/users/dottorer/events{/privacy}","received_events_url":"https://api.github.com/users/dottorer/received_events","type":"User","site_admin":false},"open_issues":16,"closed_issues":2,"state":"open","created_at":"2016-01-25T12:12:49Z","updated_at":"2016-03-07T10:16:49Z","due_on":"2016-03-30T22:00:00Z","closed_at":null},"comments":7,"created_at":"2016-02-05T08:54:47Z","updated_at":"2016-03-08T16:17:25Z","closed_at":null,"body":"Once we open up the platform for anyone who discovers a circle to sign up /this is our goal!), we need to ensure that the administrator (a) knows about it and (b) has the option to activate the account. We need to make this optional and add a flag on the circle definition for 'new helpers require approval'. \r\n\r\nIf approval is mandated, this requires a new workflow whereby the newly signed up helper first receives an email saying his registration is being processed by the circle admin. Then we need to alert the admin to look at his list of pending registrations and approve (1-click). Once approved the new member gets an email notification that she can now sign in and use the system. \r\n\r\nUntil that point, the new helper is a pending helper. Pending helpers can not log in to the system; when trying they will be presented with a screen telling them their request is pending. Once approved, they receive an email that they can now login."},"comment":{"url":"https://api.github.com/repos/lale-help/lale-help/issues/comments/193844857","html_url":"https://github.com/lale-help/lale-help/issues/122#issuecomment-193844857","issue_url":"https://api.github.com/repos/lale-help/lale-help/issues/122","id":193844857,"user":{"login":"phillipoertel","id":5188,"avatar_url":"https://avatars.githubusercontent.com/u/5188?v=3","gravatar_id":"","url":"https://api.github.com/users/phillipoertel","html_url":"https://github.com/phillipoertel","followers_url":"https://api.github.com/users/phillipoertel/followers","following_url":"https://api.github.com/users/phillipoertel/following{/other_user}","gists_url":"https://api.github.com/users/phillipoertel/gists{/gist_id}","starred_url":"https://api.github.com/users/phillipoertel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phillipoertel/subscriptions","organizations_url":"https://api.github.com/users/phillipoertel/orgs","repos_url":"https://api.github.com/users/phillipoertel/repos","events_url":"https://api.github.com/users/phillipoertel/events{/privacy}","received_events_url":"https://api.github.com/users/phillipoertel/received_events","type":"User","site_admin":false},"created_at":"2016-03-08T16:17:25Z","updated_at":"2016-03-08T16:17:25Z","body":"Feedback by @dottorer (will be in English again next time ;-))\r\n\r\n1. Es läuft schon alles echt rund - well done! Keine hard stops bisher.\r\n2. in der 'your request is being reviewed' page sind oben rechts links zu 'Angemeldet als XYZ' und 'Helferkreis KH' und Abmelden. die aber alle nichts bringen. Den Link zum HK und Abmelden sollten wir wegmachen. Weniger ist mehr.\r\n3. Wenn es pending requests gibt ,zeigen wir in der leftnav die (1). Das ist super. Wenn man aber die 'Verwaltung' aufmacht, weiss man nicht mehr, in welchem Tab man was tun muss. Vielleicht können wir hinter 'Invite helpers' ein 'Invite helpers*' in the tab name machen oder einen roten Punkt oder badge mit (1). Kommt ja häufig vor im UX.\r\n4. Die Email muss ich besser betiteln, denn der button sagt 'Approve' was nach auto-approve sich anhört. Besser ist hier 'Review pending request'. Mach ich gleich.\r\n5. NIT: wenn der request approved ist, verschwindet er sehr elegant aus dem grid. Aber in der leftnav ist noch die (1), die mit dem nächstne refresh weg ist. Falls man das gleich glatt machen möchte.\r\n6. in der 'Join' page ist der 'other helpers can see my profile' check nicht abgefragt. Der default ist Yes und Helfer können sich dann im System später mehr abschotten. Ich frage mich, ob wir so durchkommen oder den flag gleich zeigen müssen. Sollten wir besprechen...\r\n7. Der tab extended settings sollte als zweites nach basic settings kommen."}}