{"action":"created","comment":{"url":"https://api.github.com/repos/samselikoff/ember-cli-mirage/pulls/comments/77292414","id":77292414,"diff_hunk":"@@ -221,6 +223,7 @@ class Model {\n \n     // Define the getter/setter\n     Object.defineProperty(this, attr, {\n+      configurable: true,","path":"addon/orm/model.js","position":13,"original_position":13,"commit_id":"06447c3afa768aeefc9c1936e8a40fe51510a6c1","original_commit_id":"06447c3afa768aeefc9c1936e8a40fe51510a6c1","user":{"login":"samselikoff","id":2922250,"avatar_url":"https://avatars.githubusercontent.com/u/2922250?v=3","gravatar_id":"","url":"https://api.github.com/users/samselikoff","html_url":"https://github.com/samselikoff","followers_url":"https://api.github.com/users/samselikoff/followers","following_url":"https://api.github.com/users/samselikoff/following{/other_user}","gists_url":"https://api.github.com/users/samselikoff/gists{/gist_id}","starred_url":"https://api.github.com/users/samselikoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samselikoff/subscriptions","organizations_url":"https://api.github.com/users/samselikoff/orgs","repos_url":"https://api.github.com/users/samselikoff/repos","events_url":"https://api.github.com/users/samselikoff/events{/privacy}","received_events_url":"https://api.github.com/users/samselikoff/received_events","type":"User","site_admin":false},"body":"let's drop this and change line 215 from \r\n\r\n```js\r\nif (this[attr] !== undefined) {\r\n  return;\r\n}\r\n```\r\n\r\nto\r\n\r\n```js\r\nif (this.hasOwnProperty(attr)) {\r\n  return;\r\n}\r\n```","created_at":"2016-09-02T04:42:24Z","updated_at":"2016-09-02T04:42:24Z","html_url":"https://github.com/samselikoff/ember-cli-mirage/pull/846#discussion_r77292414","pull_request_url":"https://api.github.com/repos/samselikoff/ember-cli-mirage/pulls/846","_links":{"self":{"href":"https://api.github.com/repos/samselikoff/ember-cli-mirage/pulls/comments/77292414"},"html":{"href":"https://github.com/samselikoff/ember-cli-mirage/pull/846#discussion_r77292414"},"pull_request":{"href":"https://api.github.com/repos/samselikoff/ember-cli-mirage/pulls/846"}}},"pull_request":{"url":"https://api.github.com/repos/samselikoff/ember-cli-mirage/pulls/846","id":82379700,"html_url":"https://github.com/samselikoff/ember-cli-mirage/pull/846","diff_url":"https://github.com/samselikoff/ember-cli-mirage/pull/846.diff","patch_url":"https://github.com/samselikoff/ember-cli-mirage/pull/846.patch","issue_url":"https://api.github.com/repos/samselikoff/ember-cli-mirage/issues/846","number":846,"state":"open","locked":false,"title":"Allow new attributes to be defined in #update","user":{"login":"Leooo","id":2422936,"avatar_url":"https://avatars.githubusercontent.com/u/2422936?v=3","gravatar_id":"","url":"https://api.github.com/users/Leooo","html_url":"https://github.com/Leooo","followers_url":"https://api.github.com/users/Leooo/followers","following_url":"https://api.github.com/users/Leooo/following{/other_user}","gists_url":"https://api.github.com/users/Leooo/gists{/gist_id}","starred_url":"https://api.github.com/users/Leooo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Leooo/subscriptions","organizations_url":"https://api.github.com/users/Leooo/orgs","repos_url":"https://api.github.com/users/Leooo/repos","events_url":"https://api.github.com/users/Leooo/events{/privacy}","received_events_url":"https://api.github.com/users/Leooo/received_events","type":"User","site_admin":false},"body":"right now `model.update('status', true)` is not working, as only the `model.status` field is updated, and not `model.attrs.status` (which is the field used in the `save()` method: `this._schema.db[collection].update(this.attrs.id, this.attrs);`).","created_at":"2016-08-23T14:50:42Z","updated_at":"2016-09-02T04:42:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1b29ce39b05f7e190428accb35e17434c6788200","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/samselikoff/ember-cli-mirage/pulls/846/commits","review_comments_url":"https://api.github.com/repos/samselikoff/ember-cli-mirage/pulls/846/comments","review_comment_url":"https://api.github.com/repos/samselikoff/ember-cli-mirage/pulls/comments{/number}","comments_url":"https://api.github.com/repos/samselikoff/ember-cli-mirage/issues/846/comments","statuses_url":"https://api.github.com/repos/samselikoff/ember-cli-mirage/statuses/06447c3afa768aeefc9c1936e8a40fe51510a6c1","head":{"label":"Leooo:master","ref":"master","sha":"06447c3afa768aeefc9c1936e8a40fe51510a6c1","user":{"login":"Leooo","id":2422936,"avatar_url":"https://avatars.githubusercontent.com/u/2422936?v=3","gravatar_id":"","url":"https://api.github.com/users/Leooo","html_url":"https://github.com/Leooo","followers_url":"https://api.github.com/users/Leooo/followers","following_url":"https://api.github.com/users/Leooo/following{/other_user}","gists_url":"https://api.github.com/users/Leooo/gists{/gist_id}","starred_url":"https://api.github.com/users/Leooo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Leooo/subscriptions","organizations_url":"https://api.github.com/users/Leooo/orgs","repos_url":"https://api.github.com/users/Leooo/repos","events_url":"https://api.github.com/users/Leooo/events{/privacy}","received_events_url":"https://api.github.com/users/Leooo/received_events","type":"User","site_admin":false},"repo":{"id":66375348,"name":"ember-cli-mirage","full_name":"Leooo/ember-cli-mirage","owner":{"login":"Leooo","id":2422936,"avatar_url":"https://avatars.githubusercontent.com/u/2422936?v=3","gravatar_id":"","url":"https://api.github.com/users/Leooo","html_url":"https://github.com/Leooo","followers_url":"https://api.github.com/users/Leooo/followers","following_url":"https://api.github.com/users/Leooo/following{/other_user}","gists_url":"https://api.github.com/users/Leooo/gists{/gist_id}","starred_url":"https://api.github.com/users/Leooo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Leooo/subscriptions","organizations_url":"https://api.github.com/users/Leooo/orgs","repos_url":"https://api.github.com/users/Leooo/repos","events_url":"https://api.github.com/users/Leooo/events{/privacy}","received_events_url":"https://api.github.com/users/Leooo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Leooo/ember-cli-mirage","description":"A client-side mock server to develop, test and prototype your app","fork":true,"url":"https://api.github.com/repos/Leooo/ember-cli-mirage","forks_url":"https://api.github.com/repos/Leooo/ember-cli-mirage/forks","keys_url":"https://api.github.com/repos/Leooo/ember-cli-mirage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Leooo/ember-cli-mirage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Leooo/ember-cli-mirage/teams","hooks_url":"https://api.github.com/repos/Leooo/ember-cli-mirage/hooks","issue_events_url":"https://api.github.com/repos/Leooo/ember-cli-mirage/issues/events{/number}","events_url":"https://api.github.com/repos/Leooo/ember-cli-mirage/events","assignees_url":"https://api.github.com/repos/Leooo/ember-cli-mirage/assignees{/user}","branches_url":"https://api.github.com/repos/Leooo/ember-cli-mirage/branches{/branch}","tags_url":"https://api.github.com/repos/Leooo/ember-cli-mirage/tags","blobs_url":"https://api.github.com/repos/Leooo/ember-cli-mirage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Leooo/ember-cli-mirage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Leooo/ember-cli-mirage/git/refs{/sha}","trees_url":"https://api.github.com/repos/Leooo/ember-cli-mirage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Leooo/ember-cli-mirage/statuses/{sha}","languages_url":"https://api.github.com/repos/Leooo/ember-cli-mirage/languages","stargazers_url":"https://api.github.com/repos/Leooo/ember-cli-mirage/stargazers","contributors_url":"https://api.github.com/repos/Leooo/ember-cli-mirage/contributors","subscribers_url":"https://api.github.com/repos/Leooo/ember-cli-mirage/subscribers","subscription_url":"https://api.github.com/repos/Leooo/ember-cli-mirage/subscription","commits_url":"https://api.github.com/repos/Leooo/ember-cli-mirage/commits{/sha}","git_commits_url":"https://api.github.com/repos/Leooo/ember-cli-mirage/git/commits{/sha}","comments_url":"https://api.github.com/repos/Leooo/ember-cli-mirage/comments{/number}","issue_comment_url":"https://api.github.com/repos/Leooo/ember-cli-mirage/issues/comments{/number}","contents_url":"https://api.github.com/repos/Leooo/ember-cli-mirage/contents/{+path}","compare_url":"https://api.github.com/repos/Leooo/ember-cli-mirage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Leooo/ember-cli-mirage/merges","archive_url":"https://api.github.com/repos/Leooo/ember-cli-mirage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Leooo/ember-cli-mirage/downloads","issues_url":"https://api.github.com/repos/Leooo/ember-cli-mirage/issues{/number}","pulls_url":"https://api.github.com/repos/Leooo/ember-cli-mirage/pulls{/number}","milestones_url":"https://api.github.com/repos/Leooo/ember-cli-mirage/milestones{/number}","notifications_url":"https://api.github.com/repos/Leooo/ember-cli-mirage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Leooo/ember-cli-mirage/labels{/name}","releases_url":"https://api.github.com/repos/Leooo/ember-cli-mirage/releases{/id}","deployments_url":"https://api.github.com/repos/Leooo/ember-cli-mirage/deployments","created_at":"2016-08-23T14:38:25Z","updated_at":"2016-08-23T14:38:27Z","pushed_at":"2016-08-30T17:15:19Z","git_url":"git://github.com/Leooo/ember-cli-mirage.git","ssh_url":"git@github.com:Leooo/ember-cli-mirage.git","clone_url":"https://github.com/Leooo/ember-cli-mirage.git","svn_url":"https://github.com/Leooo/ember-cli-mirage","homepage":"http://ember-cli-mirage.com/","size":1570,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"samselikoff:master","ref":"master","sha":"216250b8d6c8530474edb7440697c8de2efdd359","user":{"login":"samselikoff","id":2922250,"avatar_url":"https://avatars.githubusercontent.com/u/2922250?v=3","gravatar_id":"","url":"https://api.github.com/users/samselikoff","html_url":"https://github.com/samselikoff","followers_url":"https://api.github.com/users/samselikoff/followers","following_url":"https://api.github.com/users/samselikoff/following{/other_user}","gists_url":"https://api.github.com/users/samselikoff/gists{/gist_id}","starred_url":"https://api.github.com/users/samselikoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samselikoff/subscriptions","organizations_url":"https://api.github.com/users/samselikoff/orgs","repos_url":"https://api.github.com/users/samselikoff/repos","events_url":"https://api.github.com/users/samselikoff/events{/privacy}","received_events_url":"https://api.github.com/users/samselikoff/received_events","type":"User","site_admin":false},"repo":{"id":29990778,"name":"ember-cli-mirage","full_name":"samselikoff/ember-cli-mirage","owner":{"login":"samselikoff","id":2922250,"avatar_url":"https://avatars.githubusercontent.com/u/2922250?v=3","gravatar_id":"","url":"https://api.github.com/users/samselikoff","html_url":"https://github.com/samselikoff","followers_url":"https://api.github.com/users/samselikoff/followers","following_url":"https://api.github.com/users/samselikoff/following{/other_user}","gists_url":"https://api.github.com/users/samselikoff/gists{/gist_id}","starred_url":"https://api.github.com/users/samselikoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samselikoff/subscriptions","organizations_url":"https://api.github.com/users/samselikoff/orgs","repos_url":"https://api.github.com/users/samselikoff/repos","events_url":"https://api.github.com/users/samselikoff/events{/privacy}","received_events_url":"https://api.github.com/users/samselikoff/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/samselikoff/ember-cli-mirage","description":"A client-side mock server to develop, test and prototype your app","fork":false,"url":"https://api.github.com/repos/samselikoff/ember-cli-mirage","forks_url":"https://api.github.com/repos/samselikoff/ember-cli-mirage/forks","keys_url":"https://api.github.com/repos/samselikoff/ember-cli-mirage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/samselikoff/ember-cli-mirage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/samselikoff/ember-cli-mirage/teams","hooks_url":"https://api.github.com/repos/samselikoff/ember-cli-mirage/hooks","issue_events_url":"https://api.github.com/repos/samselikoff/ember-cli-mirage/issues/events{/number}","events_url":"https://api.github.com/repos/samselikoff/ember-cli-mirage/events","assignees_url":"https://api.github.com/repos/samselikoff/ember-cli-mirage/assignees{/user}","branches_url":"https://api.github.com/repos/samselikoff/ember-cli-mirage/branches{/branch}","tags_url":"https://api.github.com/repos/samselikoff/ember-cli-mirage/tags","blobs_url":"https://api.github.com/repos/samselikoff/ember-cli-mirage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/samselikoff/ember-cli-mirage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/samselikoff/ember-cli-mirage/git/refs{/sha}","trees_url":"https://api.github.com/repos/samselikoff/ember-cli-mirage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/samselikoff/ember-cli-mirage/statuses/{sha}","languages_url":"https://api.github.com/repos/samselikoff/ember-cli-mirage/languages","stargazers_url":"https://api.github.com/repos/samselikoff/ember-cli-mirage/stargazers","contributors_url":"https://api.github.com/repos/samselikoff/ember-cli-mirage/contributors","subscribers_url":"https://api.github.com/repos/samselikoff/ember-cli-mirage/subscribers","subscription_url":"https://api.github.com/repos/samselikoff/ember-cli-mirage/subscription","commits_url":"https://api.github.com/repos/samselikoff/ember-cli-mirage/commits{/sha}","git_commits_url":"https://api.github.com/repos/samselikoff/ember-cli-mirage/git/commits{/sha}","comments_url":"https://api.github.com/repos/samselikoff/ember-cli-mirage/comments{/number}","issue_comment_url":"https://api.github.com/repos/samselikoff/ember-cli-mirage/issues/comments{/number}","contents_url":"https://api.github.com/repos/samselikoff/ember-cli-mirage/contents/{+path}","compare_url":"https://api.github.com/repos/samselikoff/ember-cli-mirage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/samselikoff/ember-cli-mirage/merges","archive_url":"https://api.github.com/repos/samselikoff/ember-cli-mirage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/samselikoff/ember-cli-mirage/downloads","issues_url":"https://api.github.com/repos/samselikoff/ember-cli-mirage/issues{/number}","pulls_url":"https://api.github.com/repos/samselikoff/ember-cli-mirage/pulls{/number}","milestones_url":"https://api.github.com/repos/samselikoff/ember-cli-mirage/milestones{/number}","notifications_url":"https://api.github.com/repos/samselikoff/ember-cli-mirage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/samselikoff/ember-cli-mirage/labels{/name}","releases_url":"https://api.github.com/repos/samselikoff/ember-cli-mirage/releases{/id}","deployments_url":"https://api.github.com/repos/samselikoff/ember-cli-mirage/deployments","created_at":"2015-01-28T22:08:26Z","updated_at":"2016-08-30T17:10:28Z","pushed_at":"2016-09-01T21:47:42Z","git_url":"git://github.com/samselikoff/ember-cli-mirage.git","ssh_url":"git@github.com:samselikoff/ember-cli-mirage.git","clone_url":"https://github.com/samselikoff/ember-cli-mirage.git","svn_url":"https://github.com/samselikoff/ember-cli-mirage","homepage":"http://ember-cli-mirage.com/","size":2032,"stargazers_count":597,"watchers_count":597,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":218,"mirror_url":null,"open_issues_count":163,"forks":218,"open_issues":163,"watchers":597,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/samselikoff/ember-cli-mirage/pulls/846"},"html":{"href":"https://github.com/samselikoff/ember-cli-mirage/pull/846"},"issue":{"href":"https://api.github.com/repos/samselikoff/ember-cli-mirage/issues/846"},"comments":{"href":"https://api.github.com/repos/samselikoff/ember-cli-mirage/issues/846/comments"},"review_comments":{"href":"https://api.github.com/repos/samselikoff/ember-cli-mirage/pulls/846/comments"},"review_comment":{"href":"https://api.github.com/repos/samselikoff/ember-cli-mirage/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/samselikoff/ember-cli-mirage/pulls/846/commits"},"statuses":{"href":"https://api.github.com/repos/samselikoff/ember-cli-mirage/statuses/06447c3afa768aeefc9c1936e8a40fe51510a6c1"}}}}
{"actor":{"display_login":"samselikoff"}}