{"action":"created","issue":{"url":"https://api.github.com/repos/Particular/NServiceBus/issues/3973","repository_url":"https://api.github.com/repos/Particular/NServiceBus","labels_url":"https://api.github.com/repos/Particular/NServiceBus/issues/3973/labels{/name}","comments_url":"https://api.github.com/repos/Particular/NServiceBus/issues/3973/comments","events_url":"https://api.github.com/repos/Particular/NServiceBus/issues/3973/events","html_url":"https://github.com/Particular/NServiceBus/issues/3973","id":167586051,"number":3973,"title":"Reveal intent and improve discoverability by renaming ForwardReceivedMessagesTo and SendFailedMessagesTo","user":{"login":"ramonsmits","id":152998,"avatar_url":"https://avatars.githubusercontent.com/u/152998?v=3","gravatar_id":"","url":"https://api.github.com/users/ramonsmits","html_url":"https://github.com/ramonsmits","followers_url":"https://api.github.com/users/ramonsmits/followers","following_url":"https://api.github.com/users/ramonsmits/following{/other_user}","gists_url":"https://api.github.com/users/ramonsmits/gists{/gist_id}","starred_url":"https://api.github.com/users/ramonsmits/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ramonsmits/subscriptions","organizations_url":"https://api.github.com/users/ramonsmits/orgs","repos_url":"https://api.github.com/users/ramonsmits/repos","events_url":"https://api.github.com/users/ramonsmits/events{/privacy}","received_events_url":"https://api.github.com/users/ramonsmits/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-07-26T11:36:47Z","updated_at":"2016-07-26T11:57:15Z","closed_at":null,"body":"Rename `endpointConfiguration.ForwardReceivedMessagesTo(string)` and / or `endpointConfiguration.SendFailedMessagesTo(string)`\r\n\r\nCurrent:\r\n\r\n```c#\r\ncfg.ForwardReceivedMessagesTo(\"audit\");\r\ncfg.SendFailedMessagesTo(\"error\");\r\n```\r\n\r\nI wondered why these are not named similarly as their behavior is both about forwarding a message.\r\n\r\n```c#\r\ncfg.ForwardReceivedMessagesTo(\"audit\");\r\ncfg.ForwardFailedMessagesTo(\"error\");\r\n```\r\n\r\nAnd while at it I wondered why we do not differentiate between *Completed* and *Failed*. The name *ForwardReceivedMessagesTo* suggests that the message is always forwarded no matter the outcome.\r\n\r\nThe following names would make the intent more visible and also makes there more discoverable.\r\n\r\n```c#\r\ncfg.ForwardCompletedMessagesTo(\"audit\");\r\ncfg.ForwardFailedMessagesTo(\"error\");\r\n```\r\n\r\n@danielmarbach mentioned that there has been a discussion about these methods in the past but I couldn't find it in Slack / GitHub.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/Particular/NServiceBus/issues/comments/235246545","html_url":"https://github.com/Particular/NServiceBus/issues/3973#issuecomment-235246545","issue_url":"https://api.github.com/repos/Particular/NServiceBus/issues/3973","id":235246545,"user":{"login":"timbussmann","id":3524870,"avatar_url":"https://avatars.githubusercontent.com/u/3524870?v=3","gravatar_id":"","url":"https://api.github.com/users/timbussmann","html_url":"https://github.com/timbussmann","followers_url":"https://api.github.com/users/timbussmann/followers","following_url":"https://api.github.com/users/timbussmann/following{/other_user}","gists_url":"https://api.github.com/users/timbussmann/gists{/gist_id}","starred_url":"https://api.github.com/users/timbussmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timbussmann/subscriptions","organizations_url":"https://api.github.com/users/timbussmann/orgs","repos_url":"https://api.github.com/users/timbussmann/repos","events_url":"https://api.github.com/users/timbussmann/events{/privacy}","received_events_url":"https://api.github.com/users/timbussmann/received_events","type":"User","site_admin":false},"created_at":"2016-07-26T11:57:15Z","updated_at":"2016-07-26T11:57:15Z","body":"btw. :+1: on aligning naming, but as @danielmarbach pointed out, I already suggested to make the error-queue a default value instead of always forcing the user to configure one."}}
{"actor":{"display_login":"timbussmann"}}