{"action":"created","issue":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/10547","repository_url":"https://api.github.com/repos/joomla/joomla-cms","labels_url":"https://api.github.com/repos/joomla/joomla-cms/issues/10547/labels{/name}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/10547/comments","events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/10547/events","html_url":"https://github.com/joomla/joomla-cms/pull/10547","id":155572471,"number":10547,"title":"[com_menus] menus acl: don't allow to delete if user doesn't have permission to delete in that menu type","user":{"login":"andrepereiradasilva","id":9630530,"avatar_url":"https://avatars.githubusercontent.com/u/9630530?v=3","gravatar_id":"","url":"https://api.github.com/users/andrepereiradasilva","html_url":"https://github.com/andrepereiradasilva","followers_url":"https://api.github.com/users/andrepereiradasilva/followers","following_url":"https://api.github.com/users/andrepereiradasilva/following{/other_user}","gists_url":"https://api.github.com/users/andrepereiradasilva/gists{/gist_id}","starred_url":"https://api.github.com/users/andrepereiradasilva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrepereiradasilva/subscriptions","organizations_url":"https://api.github.com/users/andrepereiradasilva/orgs","repos_url":"https://api.github.com/users/andrepereiradasilva/repos","events_url":"https://api.github.com/users/andrepereiradasilva/events{/privacy}","received_events_url":"https://api.github.com/users/andrepereiradasilva/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/joomla/joomla-cms/labels/PR-staging","name":"PR-staging","color":"c7def8"}],"state":"closed","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/joomla/joomla-cms/milestones/12","html_url":"https://github.com/joomla/joomla-cms/milestones/Joomla%203.6.0","labels_url":"https://api.github.com/repos/joomla/joomla-cms/milestones/12/labels","id":1360635,"number":12,"title":"Joomla 3.6.0","description":"","creator":{"login":"roland-d","id":359377,"avatar_url":"https://avatars.githubusercontent.com/u/359377?v=3","gravatar_id":"","url":"https://api.github.com/users/roland-d","html_url":"https://github.com/roland-d","followers_url":"https://api.github.com/users/roland-d/followers","following_url":"https://api.github.com/users/roland-d/following{/other_user}","gists_url":"https://api.github.com/users/roland-d/gists{/gist_id}","starred_url":"https://api.github.com/users/roland-d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roland-d/subscriptions","organizations_url":"https://api.github.com/users/roland-d/orgs","repos_url":"https://api.github.com/users/roland-d/repos","events_url":"https://api.github.com/users/roland-d/events{/privacy}","received_events_url":"https://api.github.com/users/roland-d/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":651,"state":"open","created_at":"2015-10-17T07:57:38Z","updated_at":"2016-05-28T09:38:12Z","due_on":null,"closed_at":null},"comments":14,"created_at":"2016-05-18T18:38:51Z","updated_at":"2016-05-28T09:38:18Z","closed_at":"2016-05-28T09:38:12Z","pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/10547","html_url":"https://github.com/joomla/joomla-cms/pull/10547","diff_url":"https://github.com/joomla/joomla-cms/pull/10547.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/10547.patch"},"body":"#### Summary of Changes\r\n\r\nSome ACL in the menus list view aren't working quite right:\r\n- If the user can't delete a particular menu type or is menu items it shouldn't be allowed to delete the menu type.\r\n\r\n#### Testing Instructions\r\n1. Create a user groups \"testgroup\" (child of \"Administrator\" user group)\r\n\r\n2. Go to Menus -> Manager, create a \"menu-dont-delete\" menu type and set the \"testgroup\" group to have no permission (Denied) to \"Delete\"\r\n\r\n3. Create a user \"testuser\" and add it only to \"testgroup\"\r\n\r\n4. Open a new private browser window and login to backend with \"testuser\".\r\n\r\n5. Go to menu Menus -> Manage\r\n\r\n6. Try to delete the \"menu-dont-delete\". The menu is deleted!\r\n \r\n It shouldn't since you removed that permission in \"2.\"\r\n\r\n7. Apply patch. Repeat step 2. and 6. all good, a error message will appear.\r\n You can also try with several menus at the same time.\r\n\r\n@bembelimen @infograf768 please test"},"comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments/222299706","html_url":"https://github.com/joomla/joomla-cms/pull/10547#issuecomment-222299706","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/10547","id":222299706,"user":{"login":"roland-d","id":359377,"avatar_url":"https://avatars.githubusercontent.com/u/359377?v=3","gravatar_id":"","url":"https://api.github.com/users/roland-d","html_url":"https://github.com/roland-d","followers_url":"https://api.github.com/users/roland-d/followers","following_url":"https://api.github.com/users/roland-d/following{/other_user}","gists_url":"https://api.github.com/users/roland-d/gists{/gist_id}","starred_url":"https://api.github.com/users/roland-d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roland-d/subscriptions","organizations_url":"https://api.github.com/users/roland-d/orgs","repos_url":"https://api.github.com/users/roland-d/repos","events_url":"https://api.github.com/users/roland-d/events{/privacy}","received_events_url":"https://api.github.com/users/roland-d/received_events","type":"User","site_admin":false},"created_at":"2016-05-28T09:38:18Z","updated_at":"2016-05-28T09:38:18Z","body":"Thanks everybody"}}
{"actor":{"display_login":"roland-d"}}