{"action":"created","issue":{"url":"https://api.github.com/repos/EricssonResearch/openwebrtc-ios-sdk/issues/75","repository_url":"https://api.github.com/repos/EricssonResearch/openwebrtc-ios-sdk","labels_url":"https://api.github.com/repos/EricssonResearch/openwebrtc-ios-sdk/issues/75/labels{/name}","comments_url":"https://api.github.com/repos/EricssonResearch/openwebrtc-ios-sdk/issues/75/comments","events_url":"https://api.github.com/repos/EricssonResearch/openwebrtc-ios-sdk/issues/75/events","html_url":"https://github.com/EricssonResearch/openwebrtc-ios-sdk/issues/75","id":166761803,"number":75,"title":"\"WARNING! Could not find source with name\" [...] When App language is changed","user":{"login":"mgross-letsdev","id":3718449,"avatar_url":"https://avatars.githubusercontent.com/u/3718449?v=3","gravatar_id":"","url":"https://api.github.com/users/mgross-letsdev","html_url":"https://github.com/mgross-letsdev","followers_url":"https://api.github.com/users/mgross-letsdev/followers","following_url":"https://api.github.com/users/mgross-letsdev/following{/other_user}","gists_url":"https://api.github.com/users/mgross-letsdev/gists{/gist_id}","starred_url":"https://api.github.com/users/mgross-letsdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgross-letsdev/subscriptions","organizations_url":"https://api.github.com/users/mgross-letsdev/orgs","repos_url":"https://api.github.com/users/mgross-letsdev/repos","events_url":"https://api.github.com/users/mgross-letsdev/events{/privacy}","received_events_url":"https://api.github.com/users/mgross-letsdev/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-07-21T08:14:06Z","updated_at":"2016-07-21T11:05:15Z","closed_at":null,"body":"Hey,\r\n\r\nwhen I change my App language from 'EN' to e.g. 'DE' the camera source names are not 'Front camera\" and 'Back Camera', but now 'Frontkamera' and 'Rückkamera'. \r\n\r\nThis will lead to an error like: '[OpenWebRTCNativeHandler] WARNING! Could not find source with name Back Camera'.\r\nBecause the source name is in german but expected in english.\r\n\r\nSo I want to change the ' got_local_sources(GList *sources)' method in 'OpenWebRTCNativeHandler' to use some kind of ID for the camera sources or anything other instead of the localized name string. \r\n\r\nHow can I achieve that? \r\n\r\nThanks"},"comment":{"url":"https://api.github.com/repos/EricssonResearch/openwebrtc-ios-sdk/issues/comments/234223152","html_url":"https://github.com/EricssonResearch/openwebrtc-ios-sdk/issues/75#issuecomment-234223152","issue_url":"https://api.github.com/repos/EricssonResearch/openwebrtc-ios-sdk/issues/75","id":234223152,"user":{"login":"mgross-letsdev","id":3718449,"avatar_url":"https://avatars.githubusercontent.com/u/3718449?v=3","gravatar_id":"","url":"https://api.github.com/users/mgross-letsdev","html_url":"https://github.com/mgross-letsdev","followers_url":"https://api.github.com/users/mgross-letsdev/followers","following_url":"https://api.github.com/users/mgross-letsdev/following{/other_user}","gists_url":"https://api.github.com/users/mgross-letsdev/gists{/gist_id}","starred_url":"https://api.github.com/users/mgross-letsdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgross-letsdev/subscriptions","organizations_url":"https://api.github.com/users/mgross-letsdev/orgs","repos_url":"https://api.github.com/users/mgross-letsdev/repos","events_url":"https://api.github.com/users/mgross-letsdev/events{/privacy}","received_events_url":"https://api.github.com/users/mgross-letsdev/received_events","type":"User","site_admin":false},"created_at":"2016-07-21T11:05:15Z","updated_at":"2016-07-21T11:05:15Z","body":"There are a few lines where the camera name is hardcoded! So they must be fixed with the localized camera name value.\r\n\r\nE.g. at `static gchar *expectedCameraName = \"Back Camera\";` in OpenWebRTCNativeHandler.m.\r\n\r\nI did not solved it yet, because there are encoding problems with non-latin characters in the camera name value. So I will try to hash the string do avoid this.\r\n\r\nI will still leave this issue open, because this hard coded camera names should still be changed to some kind of ID or cameraPosition value. "}}
{"actor":{"display_login":"mgross-letsdev"}}