{"action":"opened","issue":{"url":"https://api.github.com/repos/thaliproject/Thali_CordovaPlugin/issues/1628","repository_url":"https://api.github.com/repos/thaliproject/Thali_CordovaPlugin","labels_url":"https://api.github.com/repos/thaliproject/Thali_CordovaPlugin/issues/1628/labels{/name}","comments_url":"https://api.github.com/repos/thaliproject/Thali_CordovaPlugin/issues/1628/comments","events_url":"https://api.github.com/repos/thaliproject/Thali_CordovaPlugin/issues/1628/events","html_url":"https://github.com/thaliproject/Thali_CordovaPlugin/issues/1628","id":194728838,"number":1628,"title":"thaliWifiInfrastructure.startUpdateAdvertisingAndListening should not restart the SSDN server","user":{"login":"yaronyg","id":1480964,"avatar_url":"https://avatars.githubusercontent.com/u/1480964?v=3","gravatar_id":"","url":"https://api.github.com/users/yaronyg","html_url":"https://github.com/yaronyg","followers_url":"https://api.github.com/users/yaronyg/followers","following_url":"https://api.github.com/users/yaronyg/following{/other_user}","gists_url":"https://api.github.com/users/yaronyg/gists{/gist_id}","starred_url":"https://api.github.com/users/yaronyg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yaronyg/subscriptions","organizations_url":"https://api.github.com/users/yaronyg/orgs","repos_url":"https://api.github.com/users/yaronyg/repos","events_url":"https://api.github.com/users/yaronyg/events{/privacy}","received_events_url":"https://api.github.com/users/yaronyg/received_events","type":"User","site_admin":false},"labels":[{"id":456371126,"url":"https://api.github.com/repos/thaliproject/Thali_CordovaPlugin/labels/enhancement","name":"enhancement","color":"d35400","default":true},{"id":434595116,"url":"https://api.github.com/repos/thaliproject/Thali_CordovaPlugin/labels/Node","name":"Node","color":"2c3e50","default":false}],"state":"open","locked":false,"assignee":{"login":"chapko","id":437950,"avatar_url":"https://avatars.githubusercontent.com/u/437950?v=3","gravatar_id":"","url":"https://api.github.com/users/chapko","html_url":"https://github.com/chapko","followers_url":"https://api.github.com/users/chapko/followers","following_url":"https://api.github.com/users/chapko/following{/other_user}","gists_url":"https://api.github.com/users/chapko/gists{/gist_id}","starred_url":"https://api.github.com/users/chapko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chapko/subscriptions","organizations_url":"https://api.github.com/users/chapko/orgs","repos_url":"https://api.github.com/users/chapko/repos","events_url":"https://api.github.com/users/chapko/events{/privacy}","received_events_url":"https://api.github.com/users/chapko/received_events","type":"User","site_admin":false},"assignees":[{"login":"chapko","id":437950,"avatar_url":"https://avatars.githubusercontent.com/u/437950?v=3","gravatar_id":"","url":"https://api.github.com/users/chapko","html_url":"https://github.com/chapko","followers_url":"https://api.github.com/users/chapko/followers","following_url":"https://api.github.com/users/chapko/following{/other_user}","gists_url":"https://api.github.com/users/chapko/gists{/gist_id}","starred_url":"https://api.github.com/users/chapko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chapko/subscriptions","organizations_url":"https://api.github.com/users/chapko/orgs","repos_url":"https://api.github.com/users/chapko/repos","events_url":"https://api.github.com/users/chapko/events{/privacy}","received_events_url":"https://api.github.com/users/chapko/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2016-12-10T00:22:41Z","updated_at":"2016-12-10T00:22:41Z","closed_at":null,"body":"## The Problem\r\n\r\nIn our original design every time a Wifi Client changed generation we would publish a brand new USN. We did this for security reasons. This meant that every time we changed the generation we had to issue a bye bye for the previous USN to make sure nobody wasted any more time on it. But now we keep a UUID and just encode the generation into the USN. So this means that we don't need to keep starting and stopping the SSDP server just to get a bye bye for the old USN. All of our code now understands that the USN encodes a UUID and a generation so when a new generation comes out everyone knows what to do.\r\n\r\n## The Solution\r\n\r\n- [ ] thaliWifiInfrastructure.startUpdateAdvertisingAndListening - Replace [this code](https://github.com/thaliproject/Thali_CordovaPlugin/blob/93b6eb1c41f8ae4eafbe3254c1aeb12fc8386f1c/thali/NextGeneration/thaliWifiInfrastructure.js#L521-L529) with just a call to self._server.setUSN(usn);\r\n- [ ] Make sure the previous correctly updates the advertised USNs (it should but we need to test). E.g. that once we just call setUSN the server correctly changes future advertisements.\r\n- [ ] Fix any tests that were expecting to get a byebye whenever the USN changes."}}
{"actor":{"display_login":"yaronyg"}}