{"action":"created","issue":{"url":"https://api.github.com/repos/Pylons/webob/issues/274","repository_url":"https://api.github.com/repos/Pylons/webob","labels_url":"https://api.github.com/repos/Pylons/webob/issues/274/labels{/name}","comments_url":"https://api.github.com/repos/Pylons/webob/issues/274/comments","events_url":"https://api.github.com/repos/Pylons/webob/issues/274/events","html_url":"https://github.com/Pylons/webob/pull/274","id":177803079,"number":274,"title":"request: read body from file if the method is DELETE","user":{"login":"jd","id":2644,"avatar_url":"https://avatars.githubusercontent.com/u/2644?v=3","gravatar_id":"","url":"https://api.github.com/users/jd","html_url":"https://github.com/jd","followers_url":"https://api.github.com/users/jd/followers","following_url":"https://api.github.com/users/jd/following{/other_user}","gists_url":"https://api.github.com/users/jd/gists{/gist_id}","starred_url":"https://api.github.com/users/jd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jd/subscriptions","organizations_url":"https://api.github.com/users/jd/orgs","repos_url":"https://api.github.com/users/jd/repos","events_url":"https://api.github.com/users/jd/events{/privacy}","received_events_url":"https://api.github.com/users/jd/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-09-19T14:39:15Z","updated_at":"2016-09-19T14:54:26Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Pylons/webob/pulls/274","html_url":"https://github.com/Pylons/webob/pull/274","diff_url":"https://github.com/Pylons/webob/pull/274.diff","patch_url":"https://github.com/Pylons/webob/pull/274.patch"},"body":"Currently Request.from_file ignore the body of a request if the method is\nDELETE. This fixes that by using the dictionary we have to know if a request\nmight have a body or not."},"comment":{"url":"https://api.github.com/repos/Pylons/webob/issues/comments/248016657","html_url":"https://github.com/Pylons/webob/pull/274#issuecomment-248016657","issue_url":"https://api.github.com/repos/Pylons/webob/issues/274","id":248016657,"user":{"login":"mmerickel","id":487237,"avatar_url":"https://avatars.githubusercontent.com/u/487237?v=3","gravatar_id":"","url":"https://api.github.com/users/mmerickel","html_url":"https://github.com/mmerickel","followers_url":"https://api.github.com/users/mmerickel/followers","following_url":"https://api.github.com/users/mmerickel/following{/other_user}","gists_url":"https://api.github.com/users/mmerickel/gists{/gist_id}","starred_url":"https://api.github.com/users/mmerickel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmerickel/subscriptions","organizations_url":"https://api.github.com/users/mmerickel/orgs","repos_url":"https://api.github.com/users/mmerickel/repos","events_url":"https://api.github.com/users/mmerickel/events{/privacy}","received_events_url":"https://api.github.com/users/mmerickel/received_events","type":"User","site_admin":false},"created_at":"2016-09-19T14:54:26Z","updated_at":"2016-09-19T14:54:26Z","body":"As far as I can tell an HTTP DELETE with a body is unspecified and is not supported by many clients [1]. Also you changed some code in webob that explicitly forbade having a body for a DELETE in the `http_method_probably_has_body` dict. Here is the commit[2] where this logic was added to webob and it states that HTTP DELETE bodies have no defined meaning and thus are ignored in webob.\r\n\r\nThis PR changes some fundamental parts of the request processing by modifying `http_method_probably_has_body`, and the only justification here is to allow `Request.from_file` to work, which isn't part of webob's hot route. I simply don't see a very compelling reason to change this.\r\n\r\n[1] http://stackoverflow.com/questions/299628/is-an-entity-body-allowed-for-an-http-delete-request\r\n[2] https://github.com/Pylons/webob/commit/ee7f027e25418d3de99f7da9cdfe91306a0a87da"}}
{"actor":{"display_login":"mmerickel"}}