{"action":"created","issue":{"url":"https://api.github.com/repos/tmux/tmux/issues/524","repository_url":"https://api.github.com/repos/tmux/tmux","labels_url":"https://api.github.com/repos/tmux/tmux/issues/524/labels{/name}","comments_url":"https://api.github.com/repos/tmux/tmux/issues/524/comments","events_url":"https://api.github.com/repos/tmux/tmux/issues/524/events","html_url":"https://github.com/tmux/tmux/pull/524","id":173956129,"number":524,"title":"use utf8proc on platforms with broken wcwidth","user":{"login":"joshuarubin","id":194275,"avatar_url":"https://avatars.githubusercontent.com/u/194275?v=3","gravatar_id":"","url":"https://api.github.com/users/joshuarubin","html_url":"https://github.com/joshuarubin","followers_url":"https://api.github.com/users/joshuarubin/followers","following_url":"https://api.github.com/users/joshuarubin/following{/other_user}","gists_url":"https://api.github.com/users/joshuarubin/gists{/gist_id}","starred_url":"https://api.github.com/users/joshuarubin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshuarubin/subscriptions","organizations_url":"https://api.github.com/users/joshuarubin/orgs","repos_url":"https://api.github.com/users/joshuarubin/repos","events_url":"https://api.github.com/users/joshuarubin/events{/privacy}","received_events_url":"https://api.github.com/users/joshuarubin/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-08-30T08:13:47Z","updated_at":"2016-08-30T17:11:13Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/tmux/tmux/pulls/524","html_url":"https://github.com/tmux/tmux/pull/524","diff_url":"https://github.com/tmux/tmux/pull/524.diff","patch_url":"https://github.com/tmux/tmux/pull/524.patch"},"body":"As discussed in #515, this fixes rendering issues on platforms with broken `wcwidth` implementations (primarily mac) by using utf8proc.\r\n\r\nThe version of `utf8proc_data.c` differs slightly from the one in the utf8proc project as described in JuliaLang/utf8proc#83.\r\n\r\nThe difference only ensures that certain characters have width 1 (instead of 2), which means that it is no less correct than the current case of setting a width of 1 whenever `wcwidth` returns `-1`. In most cases, it should be correct much more of the time.\r\n\r\nAs/if the upstream data file is updated, I will update this pull request, or make a new one as necessary."},"comment":{"url":"https://api.github.com/repos/tmux/tmux/issues/comments/243510528","html_url":"https://github.com/tmux/tmux/pull/524#issuecomment-243510528","issue_url":"https://api.github.com/repos/tmux/tmux/issues/524","id":243510528,"user":{"login":"joshuarubin","id":194275,"avatar_url":"https://avatars.githubusercontent.com/u/194275?v=3","gravatar_id":"","url":"https://api.github.com/users/joshuarubin","html_url":"https://github.com/joshuarubin","followers_url":"https://api.github.com/users/joshuarubin/followers","following_url":"https://api.github.com/users/joshuarubin/following{/other_user}","gists_url":"https://api.github.com/users/joshuarubin/gists{/gist_id}","starred_url":"https://api.github.com/users/joshuarubin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshuarubin/subscriptions","organizations_url":"https://api.github.com/users/joshuarubin/orgs","repos_url":"https://api.github.com/users/joshuarubin/repos","events_url":"https://api.github.com/users/joshuarubin/events{/privacy}","received_events_url":"https://api.github.com/users/joshuarubin/received_events","type":"User","site_admin":false},"created_at":"2016-08-30T17:11:13Z","updated_at":"2016-08-30T17:11:13Z","body":"BTW, `utf8.c` is unchanged from `master` and utf8proc is good enough IMO with the minor changes I made (so that emoji and \"private use characters\" are considered width 1). There is still a corner case of some characters returning width 2 when they should return 1, but that is now in the hands of the utf8proc team and my PR there."}}
{"actor":{"display_login":"joshuarubin"}}