{"action":"created","issue":{"url":"https://api.github.com/repos/uWebSockets/uWebSockets/issues/301","repository_url":"https://api.github.com/repos/uWebSockets/uWebSockets","labels_url":"https://api.github.com/repos/uWebSockets/uWebSockets/issues/301/labels{/name}","comments_url":"https://api.github.com/repos/uWebSockets/uWebSockets/issues/301/comments","events_url":"https://api.github.com/repos/uWebSockets/uWebSockets/issues/301/events","html_url":"https://github.com/uWebSockets/uWebSockets/issues/301","id":183378489,"number":301,"title":"Socket.IO wsEngine 'uWebSockets'","user":{"login":"leonard-sxy","id":18049879,"avatar_url":"https://avatars.githubusercontent.com/u/18049879?v=3","gravatar_id":"","url":"https://api.github.com/users/leonard-sxy","html_url":"https://github.com/leonard-sxy","followers_url":"https://api.github.com/users/leonard-sxy/followers","following_url":"https://api.github.com/users/leonard-sxy/following{/other_user}","gists_url":"https://api.github.com/users/leonard-sxy/gists{/gist_id}","starred_url":"https://api.github.com/users/leonard-sxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leonard-sxy/subscriptions","organizations_url":"https://api.github.com/users/leonard-sxy/orgs","repos_url":"https://api.github.com/users/leonard-sxy/repos","events_url":"https://api.github.com/users/leonard-sxy/events{/privacy}","received_events_url":"https://api.github.com/users/leonard-sxy/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2016-10-17T10:21:51Z","updated_at":"2016-10-17T16:37:50Z","closed_at":null,"body":"Thanks for the great job.  I am using uWebSockets in the below way:\r\n```\r\nconst io = require('socket.io')(8080, {\r\n\tserveClient: true,\r\n\tpath: '/socket.io',\r\n\tpingTimeout: 60000,\r\n\tpingInterval: 25000,\r\n\tmaxHttpBufferSize: 10E7,\r\n\ttransports: ['websocket'],\r\n\tallowUpgrades: true,\r\n\tperMessageDeflate: {\r\n\t\tthreshold: 1024\r\n\t},\r\n\thttpCompression: {\r\n\t\tthreshold: 1024\r\n\t},\r\n\tcookie: false,\r\n\tcookiePath: false,\r\n\twsEngine: 'uws'\r\n});\r\n\r\nio.engine.ws = new (require('uws').Server)({\r\n    noServer: true,\r\n    perMessageDeflate: false\r\n});\r\n```\r\n\r\nAnd I checked how engine.io constructed the WebSocketServer by using **ws**:\r\n```\r\nthis.ws = new WebSocketServer({\r\n      noServer: true,\r\n      clientTracking: false,\r\n      perMessageDeflate: this.perMessageDeflate,\r\n      maxPayload: this.maxHttpBufferSize\r\n});\r\n```\r\n\r\nSo I want to know since I passed in **_perMessageDeflate: false_**, how uWebSockets will deal with this options and other options, and what are the others potential problems? Thanks"},"comment":{"url":"https://api.github.com/repos/uWebSockets/uWebSockets/issues/comments/254261402","html_url":"https://github.com/uWebSockets/uWebSockets/issues/301#issuecomment-254261402","issue_url":"https://api.github.com/repos/uWebSockets/uWebSockets/issues/301","id":254261402,"user":{"login":"leonard-sxy","id":18049879,"avatar_url":"https://avatars.githubusercontent.com/u/18049879?v=3","gravatar_id":"","url":"https://api.github.com/users/leonard-sxy","html_url":"https://github.com/leonard-sxy","followers_url":"https://api.github.com/users/leonard-sxy/followers","following_url":"https://api.github.com/users/leonard-sxy/following{/other_user}","gists_url":"https://api.github.com/users/leonard-sxy/gists{/gist_id}","starred_url":"https://api.github.com/users/leonard-sxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leonard-sxy/subscriptions","organizations_url":"https://api.github.com/users/leonard-sxy/orgs","repos_url":"https://api.github.com/users/leonard-sxy/repos","events_url":"https://api.github.com/users/leonard-sxy/events{/privacy}","received_events_url":"https://api.github.com/users/leonard-sxy/received_events","type":"User","site_admin":false},"created_at":"2016-10-17T16:37:50Z","updated_at":"2016-10-17T16:37:50Z","body":"@alexhultman thanks a lot, guess u can close this issue, will try to fully switch to uWebSockets."}}
{"actor":{"display_login":"leonard-sxy"}}