{"action":"created","comment":{"url":"https://api.github.com/repos/splicemachine/spliceengine/pulls/comments/82038300","pull_request_review_id":2973605,"id":82038300,"diff_hunk":"@@ -180,6 +188,14 @@ void checkPreference() {\n         }\n     }\n \n+    /* ****************************************************************************************************************/\n+    /*private helper methods*/\n+    @SuppressWarnings(\"SimplifiableIfStatement\") //the logic is clearer this way, without a performance penalty\n+    private boolean shouldBeNull(String value,boolean wasQuoted){","path":"splice_machine/src/main/java/com/splicemachine/derby/stream/function/AbstractFileFunction.java","position":122,"original_position":122,"commit_id":"d8649fc657c046b1a666ae9def7660a3a0d310d3","original_commit_id":"d8649fc657c046b1a666ae9def7660a3a0d310d3","user":{"login":"snowspeeder","id":529863,"avatar_url":"https://avatars.githubusercontent.com/u/529863?v=3","gravatar_id":"","url":"https://api.github.com/users/snowspeeder","html_url":"https://github.com/snowspeeder","followers_url":"https://api.github.com/users/snowspeeder/followers","following_url":"https://api.github.com/users/snowspeeder/following{/other_user}","gists_url":"https://api.github.com/users/snowspeeder/gists{/gist_id}","starred_url":"https://api.github.com/users/snowspeeder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snowspeeder/subscriptions","organizations_url":"https://api.github.com/users/snowspeeder/orgs","repos_url":"https://api.github.com/users/snowspeeder/repos","events_url":"https://api.github.com/users/snowspeeder/events{/privacy}","received_events_url":"https://api.github.com/users/snowspeeder/received_events","type":"User","site_admin":false},"body":"add static?","created_at":"2016-10-05T18:25:21Z","updated_at":"2016-10-05T18:25:21Z","html_url":"https://github.com/splicemachine/spliceengine/pull/198#discussion_r82038300","pull_request_url":"https://api.github.com/repos/splicemachine/spliceengine/pulls/198","_links":{"self":{"href":"https://api.github.com/repos/splicemachine/spliceengine/pulls/comments/82038300"},"html":{"href":"https://github.com/splicemachine/spliceengine/pull/198#discussion_r82038300"},"pull_request":{"href":"https://api.github.com/repos/splicemachine/spliceengine/pulls/198"}}},"pull_request":{"url":"https://api.github.com/repos/splicemachine/spliceengine/pulls/198","id":88089720,"html_url":"https://github.com/splicemachine/spliceengine/pull/198","diff_url":"https://github.com/splicemachine/spliceengine/pull/198.diff","patch_url":"https://github.com/splicemachine/spliceengine/pull/198.patch","issue_url":"https://api.github.com/repos/splicemachine/spliceengine/issues/198","number":198,"state":"open","locked":false,"title":"SPLICE-983: Carrying defaults through imports.","user":{"login":"scottfines","id":371216,"avatar_url":"https://avatars.githubusercontent.com/u/371216?v=3","gravatar_id":"","url":"https://api.github.com/users/scottfines","html_url":"https://github.com/scottfines","followers_url":"https://api.github.com/users/scottfines/followers","following_url":"https://api.github.com/users/scottfines/following{/other_user}","gists_url":"https://api.github.com/users/scottfines/gists{/gist_id}","starred_url":"https://api.github.com/users/scottfines/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scottfines/subscriptions","organizations_url":"https://api.github.com/users/scottfines/orgs","repos_url":"https://api.github.com/users/scottfines/repos","events_url":"https://api.github.com/users/scottfines/events{/privacy}","received_events_url":"https://api.github.com/users/scottfines/received_events","type":"User","site_admin":false},"body":"2.0 version of SPLICE-983 fix.\r\n\r\nIt turns out, Imports are really just inserts over subselects; to\r\nsupport default value during the import, we can just re-write the import\r\nSQL clauses to include a case statement which replaces null entries with\r\ndefault values.\r\n\r\nHowever, in order to support this case statement effectively, we also\r\nneed to make sure that we properly treat NULL strings within the parsing\r\nstage. Per customer request, we treat null, NULL, nUll, etc. as actually\r\nbeing null; we treat \"null\" as the string 'null'.\r\n\r\nAn IT was added to confirm overall behavior.\r\n\r\nConflicts:\r\n\tsplice_machine/src/main/java/com/splicemachine/derby/stream/function/FileFunction.java\r\n\tsplice_machine/src/main/java/com/splicemachine/derby/stream/function/StreamFileFunction.java","created_at":"2016-10-05T14:33:05Z","updated_at":"2016-10-05T18:25:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8e82ba3a29550d06b77d968f85947afa823c8bcb","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/splicemachine/spliceengine/pulls/198/commits","review_comments_url":"https://api.github.com/repos/splicemachine/spliceengine/pulls/198/comments","review_comment_url":"https://api.github.com/repos/splicemachine/spliceengine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/splicemachine/spliceengine/issues/198/comments","statuses_url":"https://api.github.com/repos/splicemachine/spliceengine/statuses/d8649fc657c046b1a666ae9def7660a3a0d310d3","head":{"label":"splicemachine:SPLICE-983-2","ref":"SPLICE-983-2","sha":"d8649fc657c046b1a666ae9def7660a3a0d310d3","user":{"login":"splicemachine","id":3579368,"avatar_url":"https://avatars.githubusercontent.com/u/3579368?v=3","gravatar_id":"","url":"https://api.github.com/users/splicemachine","html_url":"https://github.com/splicemachine","followers_url":"https://api.github.com/users/splicemachine/followers","following_url":"https://api.github.com/users/splicemachine/following{/other_user}","gists_url":"https://api.github.com/users/splicemachine/gists{/gist_id}","starred_url":"https://api.github.com/users/splicemachine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/splicemachine/subscriptions","organizations_url":"https://api.github.com/users/splicemachine/orgs","repos_url":"https://api.github.com/users/splicemachine/repos","events_url":"https://api.github.com/users/splicemachine/events{/privacy}","received_events_url":"https://api.github.com/users/splicemachine/received_events","type":"Organization","site_admin":false},"repo":{"id":8582237,"name":"spliceengine","full_name":"splicemachine/spliceengine","owner":{"login":"splicemachine","id":3579368,"avatar_url":"https://avatars.githubusercontent.com/u/3579368?v=3","gravatar_id":"","url":"https://api.github.com/users/splicemachine","html_url":"https://github.com/splicemachine","followers_url":"https://api.github.com/users/splicemachine/followers","following_url":"https://api.github.com/users/splicemachine/following{/other_user}","gists_url":"https://api.github.com/users/splicemachine/gists{/gist_id}","starred_url":"https://api.github.com/users/splicemachine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/splicemachine/subscriptions","organizations_url":"https://api.github.com/users/splicemachine/orgs","repos_url":"https://api.github.com/users/splicemachine/repos","events_url":"https://api.github.com/users/splicemachine/events{/privacy}","received_events_url":"https://api.github.com/users/splicemachine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/splicemachine/spliceengine","description":"The SpliceSQL Engine","fork":false,"url":"https://api.github.com/repos/splicemachine/spliceengine","forks_url":"https://api.github.com/repos/splicemachine/spliceengine/forks","keys_url":"https://api.github.com/repos/splicemachine/spliceengine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/splicemachine/spliceengine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/splicemachine/spliceengine/teams","hooks_url":"https://api.github.com/repos/splicemachine/spliceengine/hooks","issue_events_url":"https://api.github.com/repos/splicemachine/spliceengine/issues/events{/number}","events_url":"https://api.github.com/repos/splicemachine/spliceengine/events","assignees_url":"https://api.github.com/repos/splicemachine/spliceengine/assignees{/user}","branches_url":"https://api.github.com/repos/splicemachine/spliceengine/branches{/branch}","tags_url":"https://api.github.com/repos/splicemachine/spliceengine/tags","blobs_url":"https://api.github.com/repos/splicemachine/spliceengine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/splicemachine/spliceengine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/splicemachine/spliceengine/git/refs{/sha}","trees_url":"https://api.github.com/repos/splicemachine/spliceengine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/splicemachine/spliceengine/statuses/{sha}","languages_url":"https://api.github.com/repos/splicemachine/spliceengine/languages","stargazers_url":"https://api.github.com/repos/splicemachine/spliceengine/stargazers","contributors_url":"https://api.github.com/repos/splicemachine/spliceengine/contributors","subscribers_url":"https://api.github.com/repos/splicemachine/spliceengine/subscribers","subscription_url":"https://api.github.com/repos/splicemachine/spliceengine/subscription","commits_url":"https://api.github.com/repos/splicemachine/spliceengine/commits{/sha}","git_commits_url":"https://api.github.com/repos/splicemachine/spliceengine/git/commits{/sha}","comments_url":"https://api.github.com/repos/splicemachine/spliceengine/comments{/number}","issue_comment_url":"https://api.github.com/repos/splicemachine/spliceengine/issues/comments{/number}","contents_url":"https://api.github.com/repos/splicemachine/spliceengine/contents/{+path}","compare_url":"https://api.github.com/repos/splicemachine/spliceengine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/splicemachine/spliceengine/merges","archive_url":"https://api.github.com/repos/splicemachine/spliceengine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/splicemachine/spliceengine/downloads","issues_url":"https://api.github.com/repos/splicemachine/spliceengine/issues{/number}","pulls_url":"https://api.github.com/repos/splicemachine/spliceengine/pulls{/number}","milestones_url":"https://api.github.com/repos/splicemachine/spliceengine/milestones{/number}","notifications_url":"https://api.github.com/repos/splicemachine/spliceengine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/splicemachine/spliceengine/labels{/name}","releases_url":"https://api.github.com/repos/splicemachine/spliceengine/releases{/id}","deployments_url":"https://api.github.com/repos/splicemachine/spliceengine/deployments","created_at":"2013-03-05T15:07:56Z","updated_at":"2016-09-27T21:06:38Z","pushed_at":"2016-10-05T14:33:05Z","git_url":"git://github.com/splicemachine/spliceengine.git","ssh_url":"git@github.com:splicemachine/spliceengine.git","clone_url":"https://github.com/splicemachine/spliceengine.git","svn_url":"https://github.com/splicemachine/spliceengine","homepage":null,"size":207774,"stargazers_count":43,"watchers_count":43,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":6,"forks":11,"open_issues":6,"watchers":43,"default_branch":"master"}},"base":{"label":"splicemachine:branch-2.0","ref":"branch-2.0","sha":"ca430d435f6d6428741544eb0c6bdece368dcf5c","user":{"login":"splicemachine","id":3579368,"avatar_url":"https://avatars.githubusercontent.com/u/3579368?v=3","gravatar_id":"","url":"https://api.github.com/users/splicemachine","html_url":"https://github.com/splicemachine","followers_url":"https://api.github.com/users/splicemachine/followers","following_url":"https://api.github.com/users/splicemachine/following{/other_user}","gists_url":"https://api.github.com/users/splicemachine/gists{/gist_id}","starred_url":"https://api.github.com/users/splicemachine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/splicemachine/subscriptions","organizations_url":"https://api.github.com/users/splicemachine/orgs","repos_url":"https://api.github.com/users/splicemachine/repos","events_url":"https://api.github.com/users/splicemachine/events{/privacy}","received_events_url":"https://api.github.com/users/splicemachine/received_events","type":"Organization","site_admin":false},"repo":{"id":8582237,"name":"spliceengine","full_name":"splicemachine/spliceengine","owner":{"login":"splicemachine","id":3579368,"avatar_url":"https://avatars.githubusercontent.com/u/3579368?v=3","gravatar_id":"","url":"https://api.github.com/users/splicemachine","html_url":"https://github.com/splicemachine","followers_url":"https://api.github.com/users/splicemachine/followers","following_url":"https://api.github.com/users/splicemachine/following{/other_user}","gists_url":"https://api.github.com/users/splicemachine/gists{/gist_id}","starred_url":"https://api.github.com/users/splicemachine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/splicemachine/subscriptions","organizations_url":"https://api.github.com/users/splicemachine/orgs","repos_url":"https://api.github.com/users/splicemachine/repos","events_url":"https://api.github.com/users/splicemachine/events{/privacy}","received_events_url":"https://api.github.com/users/splicemachine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/splicemachine/spliceengine","description":"The SpliceSQL Engine","fork":false,"url":"https://api.github.com/repos/splicemachine/spliceengine","forks_url":"https://api.github.com/repos/splicemachine/spliceengine/forks","keys_url":"https://api.github.com/repos/splicemachine/spliceengine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/splicemachine/spliceengine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/splicemachine/spliceengine/teams","hooks_url":"https://api.github.com/repos/splicemachine/spliceengine/hooks","issue_events_url":"https://api.github.com/repos/splicemachine/spliceengine/issues/events{/number}","events_url":"https://api.github.com/repos/splicemachine/spliceengine/events","assignees_url":"https://api.github.com/repos/splicemachine/spliceengine/assignees{/user}","branches_url":"https://api.github.com/repos/splicemachine/spliceengine/branches{/branch}","tags_url":"https://api.github.com/repos/splicemachine/spliceengine/tags","blobs_url":"https://api.github.com/repos/splicemachine/spliceengine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/splicemachine/spliceengine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/splicemachine/spliceengine/git/refs{/sha}","trees_url":"https://api.github.com/repos/splicemachine/spliceengine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/splicemachine/spliceengine/statuses/{sha}","languages_url":"https://api.github.com/repos/splicemachine/spliceengine/languages","stargazers_url":"https://api.github.com/repos/splicemachine/spliceengine/stargazers","contributors_url":"https://api.github.com/repos/splicemachine/spliceengine/contributors","subscribers_url":"https://api.github.com/repos/splicemachine/spliceengine/subscribers","subscription_url":"https://api.github.com/repos/splicemachine/spliceengine/subscription","commits_url":"https://api.github.com/repos/splicemachine/spliceengine/commits{/sha}","git_commits_url":"https://api.github.com/repos/splicemachine/spliceengine/git/commits{/sha}","comments_url":"https://api.github.com/repos/splicemachine/spliceengine/comments{/number}","issue_comment_url":"https://api.github.com/repos/splicemachine/spliceengine/issues/comments{/number}","contents_url":"https://api.github.com/repos/splicemachine/spliceengine/contents/{+path}","compare_url":"https://api.github.com/repos/splicemachine/spliceengine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/splicemachine/spliceengine/merges","archive_url":"https://api.github.com/repos/splicemachine/spliceengine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/splicemachine/spliceengine/downloads","issues_url":"https://api.github.com/repos/splicemachine/spliceengine/issues{/number}","pulls_url":"https://api.github.com/repos/splicemachine/spliceengine/pulls{/number}","milestones_url":"https://api.github.com/repos/splicemachine/spliceengine/milestones{/number}","notifications_url":"https://api.github.com/repos/splicemachine/spliceengine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/splicemachine/spliceengine/labels{/name}","releases_url":"https://api.github.com/repos/splicemachine/spliceengine/releases{/id}","deployments_url":"https://api.github.com/repos/splicemachine/spliceengine/deployments","created_at":"2013-03-05T15:07:56Z","updated_at":"2016-09-27T21:06:38Z","pushed_at":"2016-10-05T14:33:05Z","git_url":"git://github.com/splicemachine/spliceengine.git","ssh_url":"git@github.com:splicemachine/spliceengine.git","clone_url":"https://github.com/splicemachine/spliceengine.git","svn_url":"https://github.com/splicemachine/spliceengine","homepage":null,"size":207774,"stargazers_count":43,"watchers_count":43,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":6,"forks":11,"open_issues":6,"watchers":43,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/splicemachine/spliceengine/pulls/198"},"html":{"href":"https://github.com/splicemachine/spliceengine/pull/198"},"issue":{"href":"https://api.github.com/repos/splicemachine/spliceengine/issues/198"},"comments":{"href":"https://api.github.com/repos/splicemachine/spliceengine/issues/198/comments"},"review_comments":{"href":"https://api.github.com/repos/splicemachine/spliceengine/pulls/198/comments"},"review_comment":{"href":"https://api.github.com/repos/splicemachine/spliceengine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/splicemachine/spliceengine/pulls/198/commits"},"statuses":{"href":"https://api.github.com/repos/splicemachine/spliceengine/statuses/d8649fc657c046b1a666ae9def7660a3a0d310d3"}}}}
{"actor":{"display_login":"snowspeeder"}}