{"action":"created","issue":{"url":"https://api.github.com/repos/openshift/origin/issues/9678","repository_url":"https://api.github.com/repos/openshift/origin","labels_url":"https://api.github.com/repos/openshift/origin/issues/9678/labels{/name}","comments_url":"https://api.github.com/repos/openshift/origin/issues/9678/comments","events_url":"https://api.github.com/repos/openshift/origin/issues/9678/events","html_url":"https://github.com/openshift/origin/pull/9678","id":163467589,"number":9678,"title":"better warning for users when the buildconfig is of type binary","user":{"login":"bparees","id":4974046,"avatar_url":"https://avatars.githubusercontent.com/u/4974046?v=3","gravatar_id":"","url":"https://api.github.com/users/bparees","html_url":"https://github.com/bparees","followers_url":"https://api.github.com/users/bparees/followers","following_url":"https://api.github.com/users/bparees/following{/other_user}","gists_url":"https://api.github.com/users/bparees/gists{/gist_id}","starred_url":"https://api.github.com/users/bparees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bparees/subscriptions","organizations_url":"https://api.github.com/users/bparees/orgs","repos_url":"https://api.github.com/users/bparees/repos","events_url":"https://api.github.com/users/bparees/events{/privacy}","received_events_url":"https://api.github.com/users/bparees/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-07-01T20:20:12Z","updated_at":"2016-07-01T21:30:38Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/9678","html_url":"https://github.com/openshift/origin/pull/9678","diff_url":"https://github.com/openshift/origin/pull/9678.diff","patch_url":"https://github.com/openshift/origin/pull/9678.patch"},"body":"also remove some dead code\r\nalso properly parse git urls so we recognize when the\r\nbuildconfig we created really is/isn't binary.\r\n\r\noutput for binary docker type build:\r\n```\r\n$ oc new-app . --dry-run\r\n--> Found Docker image 2a332da (4 weeks old) from Docker Hub for \"centos\"\r\n\r\n    * An image stream will be created as \"centos:latest\" that will track the source image\r\n    * A Docker build using binary input will be created\r\n      * The resulting image will be pushed to image stream \"centos:latest\"\r\n      * Use 'start-build --from-dir=DIR' to trigger a new build\r\n      * WARNING: a binary build was created, you must specify --from-dir/--from-file/--from-repo when starting builds\r\n    * This image will be deployed in deployment config \"centos\"\r\n    * The image does not expose any ports - if you want to load balance or send traffic to this component\r\n      you will need to create a service with 'expose dc/centos --port=[port]' later\r\n    * WARNING: Image \"centos\" runs as the 'root' user which may not be permitted by your cluster administrator\r\n\r\n--> Creating resources with label app=centos ...\r\n    imagestream \"centos\" created\r\n    buildconfig \"centos\" created\r\n    deploymentconfig \"centos\" created\r\n--> Success (DRY RUN)\r\n```\r\noutput for non-binary docker-type build:\r\n```\r\n$ oc new-app . --dry-run\r\n--> Found Docker image 2a332da (4 weeks old) from Docker Hub for \"centos\"\r\n\r\n    * An image stream will be created as \"centos:latest\" that will track the source image\r\n    * A Docker build using source code from https://github.com/openshift/ruby-hello-world#master will be created\r\n      * The resulting image will be pushed to image stream \"ruby-hello-world:latest\"\r\n      * Every time \"centos:latest\" changes a new build will be triggered\r\n    * This image will be deployed in deployment config \"ruby-hello-world\"\r\n    * The image does not expose any ports - if you want to load balance or send traffic to this component\r\n      you will need to create a service with 'expose dc/ruby-hello-world --port=[port]' later\r\n    * WARNING: Image \"centos\" runs as the 'root' user which may not be permitted by your cluster administrator\r\n\r\n--> Creating resources with label app=ruby-hello-world ...\r\n    imagestream \"centos\" created\r\n    imagestream \"ruby-hello-world\" created\r\n    buildconfig \"ruby-hello-world\" created\r\n    deploymentconfig \"ruby-hello-world\" created\r\n--> Success (DRY RUN)\r\n```\r\n\r\noutput for binary source build:\r\n```\r\n$ oc new-app . --dry-run\r\n--> Found image 0736ebc (10 days old) in image stream \"nodejs\" in project \"openshift\" under tag \"0.10\" for \"nodejs\"\r\n\r\n    Node.js 0.10 \r\n    ------------ \r\n    Platform for building and running Node.js 0.10 applications\r\n\r\n    Tags: builder, nodejs, nodejs010\r\n\r\n    * The source repository appears to match: nodejs\r\n    * A source build using binary input will be created\r\n      * The resulting image will be pushed to image stream \"nodejs:latest\"\r\n      * Use 'start-build --from-dir=DIR' to trigger a new build\r\n      * WARNING: a binary build was created, you must specify --from-dir/--from-file/--from-repo when starting builds\r\n    * This image will be deployed in deployment config \"nodejs\"\r\n    * Port 8080/tcp will be load balanced by service \"nodejs\"\r\n      * Other containers can access this service through the hostname \"nodejs\"\r\n\r\n--> Creating resources with label app=nodejs ...\r\n    imagestream \"nodejs\" created\r\n    buildconfig \"nodejs\" created\r\n    deploymentconfig \"nodejs\" created\r\n    service \"nodejs\" created\r\n--> Success (DRY RUN)\r\n```\r\n\r\noutput for non-binary source build:\r\n```\r\n$ oc new-app . --dry-run\r\n--> Found image 0736ebc (10 days old) in image stream \"nodejs\" in project \"openshift\" under tag \"0.10\" for \"nodejs\"\r\n\r\n    Node.js 0.10 \r\n    ------------ \r\n    Platform for building and running Node.js 0.10 applications\r\n\r\n    Tags: builder, nodejs, nodejs010\r\n\r\n    * The source repository appears to match: nodejs\r\n    * A source build using source code from ssh://git@github.com/bparees/nodejs-ex.git#master will be created\r\n      * The resulting image will be pushed to image stream \"nodejs-ex:latest\"\r\n      * Use 'start-build to trigger a new build\r\n    * This image will be deployed in deployment config \"nodejs-ex\"\r\n    * Port 8080/tcp will be load balanced by service \"nodejs-ex\"\r\n      * Other containers can access this service through the hostname \"nodejs-ex\"\r\n\r\n--> Creating resources with label app=nodejs-ex ...\r\n    imagestream \"nodejs-ex\" created\r\n    buildconfig \"nodejs-ex\" created\r\n    deploymentconfig \"nodejs-ex\" created\r\n    service \"nodejs-ex\" created\r\n--> Success (DRY RUN)\r\n```\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/openshift/origin/issues/comments/230051532","html_url":"https://github.com/openshift/origin/pull/9678#issuecomment-230051532","issue_url":"https://api.github.com/repos/openshift/origin/issues/9678","id":230051532,"user":{"login":"openshift-bot","id":1779249,"avatar_url":"https://avatars.githubusercontent.com/u/1779249?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift-bot","html_url":"https://github.com/openshift-bot","followers_url":"https://api.github.com/users/openshift-bot/followers","following_url":"https://api.github.com/users/openshift-bot/following{/other_user}","gists_url":"https://api.github.com/users/openshift-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift-bot/subscriptions","organizations_url":"https://api.github.com/users/openshift-bot/orgs","repos_url":"https://api.github.com/users/openshift-bot/repos","events_url":"https://api.github.com/users/openshift-bot/events{/privacy}","received_events_url":"https://api.github.com/users/openshift-bot/received_events","type":"User","site_admin":false},"created_at":"2016-07-01T21:30:38Z","updated_at":"2016-07-01T21:30:38Z","body":"continuous-integration/openshift-jenkins/merge Evaluating for testing"}}
{"actor":{"display_login":"openshift-bot"}}