{"action":"closed","issue":{"url":"https://api.github.com/repos/phoebe-project/phoebe2/issues/95","repository_url":"https://api.github.com/repos/phoebe-project/phoebe2","labels_url":"https://api.github.com/repos/phoebe-project/phoebe2/issues/95/labels{/name}","comments_url":"https://api.github.com/repos/phoebe-project/phoebe2/issues/95/comments","events_url":"https://api.github.com/repos/phoebe-project/phoebe2/issues/95/events","html_url":"https://github.com/phoebe-project/phoebe2/issues/95","id":177010445,"number":95,"title":"reflection_method","user":{"login":"kecnry","id":877591,"avatar_url":"https://avatars.githubusercontent.com/u/877591?v=3","gravatar_id":"","url":"https://api.github.com/users/kecnry","html_url":"https://github.com/kecnry","followers_url":"https://api.github.com/users/kecnry/followers","following_url":"https://api.github.com/users/kecnry/following{/other_user}","gists_url":"https://api.github.com/users/kecnry/gists{/gist_id}","starred_url":"https://api.github.com/users/kecnry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kecnry/subscriptions","organizations_url":"https://api.github.com/users/kecnry/orgs","repos_url":"https://api.github.com/users/kecnry/repos","events_url":"https://api.github.com/users/kecnry/events{/privacy}","received_events_url":"https://api.github.com/users/kecnry/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/phoebe-project/phoebe2/labels/feature","name":"feature","color":"0e8a16"}],"state":"closed","locked":false,"assignee":{"login":"kecnry","id":877591,"avatar_url":"https://avatars.githubusercontent.com/u/877591?v=3","gravatar_id":"","url":"https://api.github.com/users/kecnry","html_url":"https://github.com/kecnry","followers_url":"https://api.github.com/users/kecnry/followers","following_url":"https://api.github.com/users/kecnry/following{/other_user}","gists_url":"https://api.github.com/users/kecnry/gists{/gist_id}","starred_url":"https://api.github.com/users/kecnry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kecnry/subscriptions","organizations_url":"https://api.github.com/users/kecnry/orgs","repos_url":"https://api.github.com/users/kecnry/repos","events_url":"https://api.github.com/users/kecnry/events{/privacy}","received_events_url":"https://api.github.com/users/kecnry/received_events","type":"User","site_admin":false},"assignees":[{"login":"kecnry","id":877591,"avatar_url":"https://avatars.githubusercontent.com/u/877591?v=3","gravatar_id":"","url":"https://api.github.com/users/kecnry","html_url":"https://github.com/kecnry","followers_url":"https://api.github.com/users/kecnry/followers","following_url":"https://api.github.com/users/kecnry/following{/other_user}","gists_url":"https://api.github.com/users/kecnry/gists{/gist_id}","starred_url":"https://api.github.com/users/kecnry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kecnry/subscriptions","organizations_url":"https://api.github.com/users/kecnry/orgs","repos_url":"https://api.github.com/users/kecnry/repos","events_url":"https://api.github.com/users/kecnry/events{/privacy}","received_events_url":"https://api.github.com/users/kecnry/received_events","type":"User","site_admin":false},{"login":"horvatm","id":20442652,"avatar_url":"https://avatars.githubusercontent.com/u/20442652?v=3","gravatar_id":"","url":"https://api.github.com/users/horvatm","html_url":"https://github.com/horvatm","followers_url":"https://api.github.com/users/horvatm/followers","following_url":"https://api.github.com/users/horvatm/following{/other_user}","gists_url":"https://api.github.com/users/horvatm/gists{/gist_id}","starred_url":"https://api.github.com/users/horvatm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/horvatm/subscriptions","organizations_url":"https://api.github.com/users/horvatm/orgs","repos_url":"https://api.github.com/users/horvatm/repos","events_url":"https://api.github.com/users/horvatm/events{/privacy}","received_events_url":"https://api.github.com/users/horvatm/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/phoebe-project/phoebe2/milestones/1","html_url":"https://github.com/phoebe-project/phoebe2/milestones/2.0b","labels_url":"https://api.github.com/repos/phoebe-project/phoebe2/milestones/1/labels","id":1956038,"number":1,"title":"2.0b","description":"beta release of PHOEBE 2.0 - paper submission targeted for September 21.","creator":{"login":"kecnry","id":877591,"avatar_url":"https://avatars.githubusercontent.com/u/877591?v=3","gravatar_id":"","url":"https://api.github.com/users/kecnry","html_url":"https://github.com/kecnry","followers_url":"https://api.github.com/users/kecnry/followers","following_url":"https://api.github.com/users/kecnry/following{/other_user}","gists_url":"https://api.github.com/users/kecnry/gists{/gist_id}","starred_url":"https://api.github.com/users/kecnry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kecnry/subscriptions","organizations_url":"https://api.github.com/users/kecnry/orgs","repos_url":"https://api.github.com/users/kecnry/repos","events_url":"https://api.github.com/users/kecnry/events{/privacy}","received_events_url":"https://api.github.com/users/kecnry/received_events","type":"User","site_admin":false},"open_issues":22,"closed_issues":26,"state":"open","created_at":"2016-08-22T18:58:06Z","updated_at":"2016-09-17T14:55:55Z","due_on":"2016-09-21T00:00:00Z","closed_at":null},"comments":1,"created_at":"2016-09-14T20:22:24Z","updated_at":"2016-09-17T14:55:55Z","closed_at":"2016-09-17T14:55:55Z","body":"If there is a possibility of supporting multiple different methods for reflection (even if not ready to be included in 2.0b), we should switch from a bool parameter (refl) to a choice parameter (reflection_method) in time for the beta release or at least by 2.0 to avoid backwards compatibility issues down the road.\r\n\r\nProposed change:\r\nrefl = True/False -> reflection_method = \\['none', 'wilson', 'horvat'\\] (with 'horvat' perhaps moved to developer mode if not included in the paper)\r\n\r\nSee also #17 for a similar decision to be made with boosting/beaming.\r\n\r\n---------------------\r\n\r\nThis also affects (again) the name of the \"albedo\" parameters.\r\n\r\nCurrently we have (required to sum to 1 by a constraint):\r\n* frac_lost_bol\r\n* frac_refl_bol\r\n* frac_heating_bol (unsupported in 2.0b)\r\n* frac_scattering_bol (unsupported in 2.0b)\r\n\r\nbut this is confusing, because reflection_method will affect both frac_refl and frac_heating (by necessity as they must be handled in parallel).  This will also cause problems when we need to split heating into different types of redistribution.\r\n\r\n**alternative 1**:\r\n* frac_lost_bol\r\n* frac_refl_noredist_bol\r\n* frac_refl_localredist_bol\r\n* frac_refl_horizredist_bol\r\n* frac_refl_globalredist_bol\r\n* frac_scattering_bol\r\n\r\nHere this is clear that reflection_method affects **all** reflection, whether redistribution occurs or not.\r\n\r\n**alternative 2**:\r\n* frac_lost_bol\r\n* frac_refl_bol\r\n  * frac_refl_noredist_bol\r\n  * frac_refl_localredist_bol\r\n  * frac_refl_horizredist_bol\r\n  * frac_refl_globalredist_bol\r\n* frac_scattering\r\n\r\nThis option is nice because it allows you to set the ratios in a tree structure by defining what ratio goes to *all* reflection and then breaking down that contribution... but makes for a mess in parameter names.\r\n\r\n**alternative 3**:\r\n* frac_lost_bol\r\n* frac_refl_bol\r\n* frac_reflredist_bol\r\n* frac_scattering_bol\r\n\r\nwith compute options:\r\n* reflection_method = ['none', 'wilson' , 'horvat']\r\n* redistribution_method = ['local', 'horizontal', 'global']\r\n\r\nThis is perhaps the simplest option, but will **not** allow including multiple types of redistribution simultaneously.\r\n\r\n--------------------\r\n\r\nWe don't need to decide on all the redistribution/heating names yet, but it would be a good idea to think ahead so that we don't need to change the name of the 'frac_refl_bol' parameter when we get around to implementing redistribution/heating.\r\n"}}
{"actor":{"display_login":"kecnry"}}