{"action":"created","issue":{"url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/2087","repository_url":"https://api.github.com/repos/Homebrew/homebrew-core","labels_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/2087/labels{/name}","comments_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/2087/comments","events_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/2087/events","html_url":"https://github.com/Homebrew/homebrew-core/pull/2087","id":160979422,"number":2087,"title":"qt5 5.7.0","user":{"login":"LRFLEW","id":607715,"avatar_url":"https://avatars.githubusercontent.com/u/607715?v=3","gravatar_id":"","url":"https://api.github.com/users/LRFLEW","html_url":"https://github.com/LRFLEW","followers_url":"https://api.github.com/users/LRFLEW/followers","following_url":"https://api.github.com/users/LRFLEW/following{/other_user}","gists_url":"https://api.github.com/users/LRFLEW/gists{/gist_id}","starred_url":"https://api.github.com/users/LRFLEW/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LRFLEW/subscriptions","organizations_url":"https://api.github.com/users/LRFLEW/orgs","repos_url":"https://api.github.com/users/LRFLEW/repos","events_url":"https://api.github.com/users/LRFLEW/events{/privacy}","received_events_url":"https://api.github.com/users/LRFLEW/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Homebrew/homebrew-core/labels/in%20progress","name":"in progress","color":"ededed"}],"state":"open","locked":false,"assignee":{"login":"DomT4","id":6998367,"avatar_url":"https://avatars.githubusercontent.com/u/6998367?v=3","gravatar_id":"","url":"https://api.github.com/users/DomT4","html_url":"https://github.com/DomT4","followers_url":"https://api.github.com/users/DomT4/followers","following_url":"https://api.github.com/users/DomT4/following{/other_user}","gists_url":"https://api.github.com/users/DomT4/gists{/gist_id}","starred_url":"https://api.github.com/users/DomT4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DomT4/subscriptions","organizations_url":"https://api.github.com/users/DomT4/orgs","repos_url":"https://api.github.com/users/DomT4/repos","events_url":"https://api.github.com/users/DomT4/events{/privacy}","received_events_url":"https://api.github.com/users/DomT4/received_events","type":"User","site_admin":false},"assignees":[{"login":"DomT4","id":6998367,"avatar_url":"https://avatars.githubusercontent.com/u/6998367?v=3","gravatar_id":"","url":"https://api.github.com/users/DomT4","html_url":"https://github.com/DomT4","followers_url":"https://api.github.com/users/DomT4/followers","following_url":"https://api.github.com/users/DomT4/following{/other_user}","gists_url":"https://api.github.com/users/DomT4/gists{/gist_id}","starred_url":"https://api.github.com/users/DomT4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DomT4/subscriptions","organizations_url":"https://api.github.com/users/DomT4/orgs","repos_url":"https://api.github.com/users/DomT4/repos","events_url":"https://api.github.com/users/DomT4/events{/privacy}","received_events_url":"https://api.github.com/users/DomT4/received_events","type":"User","site_admin":false},{"login":"UniqMartin","id":11892150,"avatar_url":"https://avatars.githubusercontent.com/u/11892150?v=3","gravatar_id":"","url":"https://api.github.com/users/UniqMartin","html_url":"https://github.com/UniqMartin","followers_url":"https://api.github.com/users/UniqMartin/followers","following_url":"https://api.github.com/users/UniqMartin/following{/other_user}","gists_url":"https://api.github.com/users/UniqMartin/gists{/gist_id}","starred_url":"https://api.github.com/users/UniqMartin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UniqMartin/subscriptions","organizations_url":"https://api.github.com/users/UniqMartin/orgs","repos_url":"https://api.github.com/users/UniqMartin/repos","events_url":"https://api.github.com/users/UniqMartin/events{/privacy}","received_events_url":"https://api.github.com/users/UniqMartin/received_events","type":"User","site_admin":false}],"milestone":null,"comments":21,"created_at":"2016-06-17T21:35:46Z","updated_at":"2016-06-30T19:38:36Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/2087","html_url":"https://github.com/Homebrew/homebrew-core/pull/2087","diff_url":"https://github.com/Homebrew/homebrew-core/pull/2087.diff","patch_url":"https://github.com/Homebrew/homebrew-core/pull/2087.patch"},"body":"- [x] Have you followed the guidelines in our [Contributing](https://github.com/Homebrew/homebrew-core/blob/master/.github/CONTRIBUTING.md) document?\r\n- [x] Have you checked to ensure there aren't other open [Pull Requests](https://github.com/Homebrew/homebrew-core/pulls) for the same formula update/change?\r\n- [x] Have you built your formula locally prior to submission with `brew install <formula>` (where `<formula>` is the name of the formula you're submitting)?\r\n- [x] Does your submission pass `brew audit --strict --online <formula>` (after doing `brew install <formula>`)?\r\n\r\n-----\r\n\r\nI know that major version changes to qt5 have been more involved in the past, such as Homebrew/legacy-homebrew#50234. However, I saw that there was no open PR for this, so I went ahead and made one."},"comment":{"url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/comments/229766032","html_url":"https://github.com/Homebrew/homebrew-core/pull/2087#issuecomment-229766032","issue_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/2087","id":229766032,"user":{"login":"UniqMartin","id":11892150,"avatar_url":"https://avatars.githubusercontent.com/u/11892150?v=3","gravatar_id":"","url":"https://api.github.com/users/UniqMartin","html_url":"https://github.com/UniqMartin","followers_url":"https://api.github.com/users/UniqMartin/followers","following_url":"https://api.github.com/users/UniqMartin/following{/other_user}","gists_url":"https://api.github.com/users/UniqMartin/gists{/gist_id}","starred_url":"https://api.github.com/users/UniqMartin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UniqMartin/subscriptions","organizations_url":"https://api.github.com/users/UniqMartin/orgs","repos_url":"https://api.github.com/users/UniqMartin/repos","events_url":"https://api.github.com/users/UniqMartin/events{/privacy}","received_events_url":"https://api.github.com/users/UniqMartin/received_events","type":"User","site_admin":false},"created_at":"2016-06-30T19:38:36Z","updated_at":"2016-06-30T19:38:36Z","body":"> FWIW, [this change](https://codereview.qt-project.org/#/c/151109/4//ALL,unified) mentions it needs SDK 10.10*.3* or later - I only can see it's using 10.10 from the build log, maybe with an older patch version?\r\n\r\n@The-Compiler Thanks for finding this and for investigating this further! This commit pretty much explains it all. So the bottom line is that the QtWebEngine module cannot be built with an SDK prior to 10.10.3, meaning this automatically excludes OS X 10.9 as the latest officially supported Xcode is 6.2.\r\n\r\nThe saddening part is that this nontrivial change to the build requirements isn't documented anywhere (as far as I can see), neither in [the documentation you pointed out](http://doc.qt.io/qt-5/qtwebengine-platform-notes.html#os-x) nor the [Qt 5.7.0 Change Files](https://wiki.qt.io/Qt_5.7.0_Change_Files).\r\n\r\nBuilding on a newer machine (but with a deployment target of 10.9) and then using this is theoretically possible, but doesn't work with our CI setup. Modifying the Xcode that we use on our 10.9 CI is not an option (and not practical either), as that could create more trouble for other formulae and will only help with the bottles, but 10.9 users building from source (with Xcode 6.2) would still be left out.\r\n\r\nI'm currently seeing these options:\r\n\r\n1. Delay shipping Qt 5.7.0 until macOS 10.12 Sierra has been released. At this point we no longer care about OS X 10.9 and stop providing bottles for it anyway. (This is at least practical in the sense that Qt 5.6 is a long-term release and will receive future updates.)\r\n\r\n2. Ship Qt 5.7.0 now, but live with the problem that the 10.9 bottle will provide an inferior experience, namely the missing QtWebEngine module and related modules. (This sounds problematic as it is likely to create confusion for users and thus additional support burden for us. And it impacts all other formulae that depend on Qt 5 and might be depending on QtWebEngine.)\r\n\r\n3. Ship Qt 5.7.0 now, but raise the minimum required OS X version to 10.10. (This provides a more consistent user experience, but will be annoying to those who want other bits of Qt and don't necessarily require the QtWebEngine module. We'd also have to figure out how to deal with this situation in all formulae that depend on Qt 5.)\r\n\r\nIf I had to order these options by preference, that would be: 1, 3, 2. @DomT4 What are your thoughts on the situation and the options we have here? Any other options that I'm overlooking?"}}
{"actor":{"display_login":"UniqMartin"}}