{"action":"created","comment":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/comments/52572418","id":52572418,"diff_hunk":"@@ -20,20 +20,34 @@\n \n ALL_SYSTEMS = ['lms', 'studio']\n COFFEE_DIRS = ['lms', 'cms', 'common']\n+\n # A list of directories.  Each will be paired with a sibling /css directory.\n COMMON_SASS_DIRECTORIES = [\n-    path(\"common/static/sass\"),\n+    (path(\"common/static/sass\"), path(\"common/static/css\"))\n+]\n+COMMON_SASS_LOOKUP_DIRECTORIES = [\n+    'common/static',\n+    'common/static/sass'\n ]\n+\n LMS_SASS_DIRECTORIES = [\n-    path(\"lms/static/sass\"),\n-    path(\"lms/static/themed_sass\"),\n-    path(\"lms/static/certificates/sass\"),\n+    (path(\"lms/static/sass\"), path(\"lms/static/css\")),\n+    (path(\"lms/static/themed_sass\"), \"\"),\n+    (path(\"lms/static/certificates/sass\"), path(\"lms/static/certificates/css\")),\n+]\n+LMS_SASS_LOOKUP_DIRECTORIES = [\n+    path(\"lms/static/sass/partials\"),\n ]\n+\n CMS_SASS_DIRECTORIES = [\n-    path(\"cms/static/sass\"),\n+    (path(\"cms/static/sass\"), path(\"cms/static/css\")),\n+]\n+CMS_SASS_LOOKUP_DIRECTORIES = [\n+    path(\"cms/static/sass/partials\"),\n ]\n+\n THEME_SASS_DIRECTORIES = []\n-SASS_LOAD_PATHS = ['common/static', 'common/static/sass']\n+THEME_SASS_LOOKUP_DIRECTORIES = []","path":"pavelib/assets.py","position":37,"original_position":37,"commit_id":"98dd913bad15196843384196d93960873029b480","original_commit_id":"98dd913bad15196843384196d93960873029b480","user":{"login":"mtyaka","id":32585,"avatar_url":"https://avatars.githubusercontent.com/u/32585?v=3","gravatar_id":"","url":"https://api.github.com/users/mtyaka","html_url":"https://github.com/mtyaka","followers_url":"https://api.github.com/users/mtyaka/followers","following_url":"https://api.github.com/users/mtyaka/following{/other_user}","gists_url":"https://api.github.com/users/mtyaka/gists{/gist_id}","starred_url":"https://api.github.com/users/mtyaka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtyaka/subscriptions","organizations_url":"https://api.github.com/users/mtyaka/orgs","repos_url":"https://api.github.com/users/mtyaka/repos","events_url":"https://api.github.com/users/mtyaka/events{/privacy}","received_events_url":"https://api.github.com/users/mtyaka/received_events","type":"User","site_admin":false},"body":"I think we'll have to split `THEME_SASS_DIRECTORIES` into `THEME_LMS_SASS_DIRECTORIES` and `THEME_CMS_SASS_DIRECTORIES`; and `THEME_SASS_LOOKUP_DIRECTORIES` into `THEME_SASS_LMS_LOOKUP_DIRECTORIES` and `THEME_SASS_CMS_LOOKUP_DIRECTORIES`.\r\n\r\nCurrently it doesn't matter much because most of the time we compile all sass files in a single command (`systems` equals `ALL_SYSTEMS`), but if we decide to move more sass files to the `partials` directory, we will quickly start to get name clashes between partials in the lms partials folder and partials in the cms partials folder, so it will be important to compile lms and cms sass in two separate commands.","created_at":"2016-02-11T08:17:57Z","updated_at":"2016-02-11T08:17:57Z","html_url":"https://github.com/edx/edx-platform/pull/11476#discussion_r52572418","pull_request_url":"https://api.github.com/repos/edx/edx-platform/pulls/11476","_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments/52572418"},"html":{"href":"https://github.com/edx/edx-platform/pull/11476#discussion_r52572418"},"pull_request":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/11476"}}},"pull_request":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/11476","id":58716070,"html_url":"https://github.com/edx/edx-platform/pull/11476","diff_url":"https://github.com/edx/edx-platform/pull/11476.diff","patch_url":"https://github.com/edx/edx-platform/pull/11476.patch","issue_url":"https://api.github.com/repos/edx/edx-platform/issues/11476","number":11476,"state":"open","locked":false,"title":"(WIP) - WL-299: Updates sass compilation path so that scss in themes overrides lms/cms's sass files","user":{"login":"saleem-latif","id":7114956,"avatar_url":"https://avatars.githubusercontent.com/u/7114956?v=3","gravatar_id":"","url":"https://api.github.com/users/saleem-latif","html_url":"https://github.com/saleem-latif","followers_url":"https://api.github.com/users/saleem-latif/followers","following_url":"https://api.github.com/users/saleem-latif/following{/other_user}","gists_url":"https://api.github.com/users/saleem-latif/gists{/gist_id}","starred_url":"https://api.github.com/users/saleem-latif/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saleem-latif/subscriptions","organizations_url":"https://api.github.com/users/saleem-latif/orgs","repos_url":"https://api.github.com/users/saleem-latif/repos","events_url":"https://api.github.com/users/saleem-latif/events{/privacy}","received_events_url":"https://api.github.com/users/saleem-latif/received_events","type":"User","site_admin":false},"body":"Hi @mattdrayer , @andy-armstrong, @mtyaka , @ziafazal , @benpatterson \r\n\r\nKindly review this PR and share your thoughts on these changes for [WL-299](https://openedx.atlassian.net/browse/WL-299). \r\n\r\n__Note:__\r\nSince, sass first looks at its current path to resolve `@import` so, We decided to move sass files, that comprehensive theme will be able to override, to partials directory. I have only moved  `base/_variables.scss` to partials dir, if this change set looks good than also share your thoughts on what other sass files should be moved to partials dir.\r\n\r\n__Description of [WL-299] (https://openedx.atlassian.net/browse/WL-299):__\r\nCurrently the behavior of static files and templates overriding in comprehensive theming is that if we place a file named same as it is placed in lms it will override the lms static/template file.\r\nWe want to apply the same override pattern for sass files, see the discussion here and here for some insight.\r\n__Acceptance Criteria:__\r\n\r\n1. If I place a file named base/_variables.scss inside edx-platform/themes/stanford/lms/static/sass/partials/ than it should override all the definitions from base/_variables.scss present in edx-platform/lms/static/sass/partials/\r\n\r\nfor more information regarding implementation details look at the comments on [WL-299] (https://openedx.atlassian.net/browse/WL-299)","created_at":"2016-02-09T08:14:00Z","updated_at":"2016-02-11T08:17:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e0fa6a50fa2467c47f6a36039d2af96f47c66371","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/edx/edx-platform/pulls/11476/commits","review_comments_url":"https://api.github.com/repos/edx/edx-platform/pulls/11476/comments","review_comment_url":"https://api.github.com/repos/edx/edx-platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/edx/edx-platform/issues/11476/comments","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/98dd913bad15196843384196d93960873029b480","head":{"label":"edx:saleem-latif/WL-299","ref":"saleem-latif/WL-299","sha":"98dd913bad15196843384196d93960873029b480","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":10391073,"name":"edx-platform","full_name":"edx/edx-platform","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-platform","description":"The Open edX platform, the software that powers edX!","fork":false,"url":"https://api.github.com/repos/edx/edx-platform","forks_url":"https://api.github.com/repos/edx/edx-platform/forks","keys_url":"https://api.github.com/repos/edx/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-platform/teams","hooks_url":"https://api.github.com/repos/edx/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-platform/events","assignees_url":"https://api.github.com/repos/edx/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-platform/tags","blobs_url":"https://api.github.com/repos/edx/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-platform/languages","stargazers_url":"https://api.github.com/repos/edx/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-platform/subscription","commits_url":"https://api.github.com/repos/edx/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-platform/merges","archive_url":"https://api.github.com/repos/edx/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-platform/downloads","issues_url":"https://api.github.com/repos/edx/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-platform/releases{/id}","deployments_url":"https://api.github.com/repos/edx/edx-platform/deployments","created_at":"2013-05-30T20:20:38Z","updated_at":"2016-02-10T21:40:08Z","pushed_at":"2016-02-11T07:46:33Z","git_url":"git://github.com/edx/edx-platform.git","ssh_url":"git@github.com:edx/edx-platform.git","clone_url":"https://github.com/edx/edx-platform.git","svn_url":"https://github.com/edx/edx-platform","homepage":"http://open.edx.org/","size":682922,"stargazers_count":2381,"watchers_count":2381,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1452,"mirror_url":null,"open_issues_count":151,"forks":1452,"open_issues":151,"watchers":2381,"default_branch":"master"}},"base":{"label":"edx:master","ref":"master","sha":"cf5dc1075f203fdf36c50c5214b5733d89737cab","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":10391073,"name":"edx-platform","full_name":"edx/edx-platform","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-platform","description":"The Open edX platform, the software that powers edX!","fork":false,"url":"https://api.github.com/repos/edx/edx-platform","forks_url":"https://api.github.com/repos/edx/edx-platform/forks","keys_url":"https://api.github.com/repos/edx/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-platform/teams","hooks_url":"https://api.github.com/repos/edx/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-platform/events","assignees_url":"https://api.github.com/repos/edx/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-platform/tags","blobs_url":"https://api.github.com/repos/edx/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-platform/languages","stargazers_url":"https://api.github.com/repos/edx/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-platform/subscription","commits_url":"https://api.github.com/repos/edx/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-platform/merges","archive_url":"https://api.github.com/repos/edx/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-platform/downloads","issues_url":"https://api.github.com/repos/edx/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-platform/releases{/id}","deployments_url":"https://api.github.com/repos/edx/edx-platform/deployments","created_at":"2013-05-30T20:20:38Z","updated_at":"2016-02-10T21:40:08Z","pushed_at":"2016-02-11T07:46:33Z","git_url":"git://github.com/edx/edx-platform.git","ssh_url":"git@github.com:edx/edx-platform.git","clone_url":"https://github.com/edx/edx-platform.git","svn_url":"https://github.com/edx/edx-platform","homepage":"http://open.edx.org/","size":682922,"stargazers_count":2381,"watchers_count":2381,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1452,"mirror_url":null,"open_issues_count":151,"forks":1452,"open_issues":151,"watchers":2381,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/11476"},"html":{"href":"https://github.com/edx/edx-platform/pull/11476"},"issue":{"href":"https://api.github.com/repos/edx/edx-platform/issues/11476"},"comments":{"href":"https://api.github.com/repos/edx/edx-platform/issues/11476/comments"},"review_comments":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/11476/comments"},"review_comment":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/11476/commits"},"statuses":{"href":"https://api.github.com/repos/edx/edx-platform/statuses/98dd913bad15196843384196d93960873029b480"}}}}