{"action":"created","issue":{"url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/4005","repository_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium","labels_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/4005/labels{/name}","comments_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/4005/comments","events_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/4005/events","html_url":"https://github.com/AnalyticalGraphicsInc/cesium/pull/4005","id":158772344,"number":4005,"title":"Entity Shadows","user":{"login":"lilleyse","id":915398,"avatar_url":"https://avatars.githubusercontent.com/u/915398?v=3","gravatar_id":"","url":"https://api.github.com/users/lilleyse","html_url":"https://github.com/lilleyse","followers_url":"https://api.github.com/users/lilleyse/followers","following_url":"https://api.github.com/users/lilleyse/following{/other_user}","gists_url":"https://api.github.com/users/lilleyse/gists{/gist_id}","starred_url":"https://api.github.com/users/lilleyse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lilleyse/subscriptions","organizations_url":"https://api.github.com/users/lilleyse/orgs","repos_url":"https://api.github.com/users/lilleyse/repos","events_url":"https://api.github.com/users/lilleyse/events{/privacy}","received_events_url":"https://api.github.com/users/lilleyse/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/labels/next%20release","name":"next release","color":"e10c02"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":34,"created_at":"2016-06-06T20:53:33Z","updated_at":"2016-08-03T18:19:10Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/4005","html_url":"https://github.com/AnalyticalGraphicsInc/cesium/pull/4005","diff_url":"https://github.com/AnalyticalGraphicsInc/cesium/pull/4005.diff","patch_url":"https://github.com/AnalyticalGraphicsInc/cesium/pull/4005.patch"},"body":"For #2594 \r\nContinuation of https://github.com/AnalyticalGraphicsInc/cesium/pull/3928 now that the `shadows` branch is gone.\r\n\r\n> I added castShadows and receiveShadows properties to all the applicable entity types. It supports changing these properties at runtime. Batching based on shadows is handled in GeometryVisualizer. Each batch, besides the dynamic batch, is now an array of 4 batches (cast+receive, cast, receive, none). This was the cleanest solution for now, but could get unwieldy if we continue to add more bucket types. I tried and gave up on a unified solution for batching so that we wouldn't need StaticOutlineGeometryBatch, StaticGeometryColorBatch, and in StaticGeometryPerMaterialBatch. Maybe this is worth revisiting in a future rewrite.\r\n\r\nWe talked about potentially using just `shadows` instead of `castShadows` and `receiveShadows`.\r\n\r\n* [x] Deprecate `castShadows` and `receiveShadows`\r\n* [x] Performance testing"},"comment":{"url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/comments/237323313","html_url":"https://github.com/AnalyticalGraphicsInc/cesium/pull/4005#issuecomment-237323313","issue_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/4005","id":237323313,"user":{"login":"lilleyse","id":915398,"avatar_url":"https://avatars.githubusercontent.com/u/915398?v=3","gravatar_id":"","url":"https://api.github.com/users/lilleyse","html_url":"https://github.com/lilleyse","followers_url":"https://api.github.com/users/lilleyse/followers","following_url":"https://api.github.com/users/lilleyse/following{/other_user}","gists_url":"https://api.github.com/users/lilleyse/gists{/gist_id}","starred_url":"https://api.github.com/users/lilleyse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lilleyse/subscriptions","organizations_url":"https://api.github.com/users/lilleyse/orgs","repos_url":"https://api.github.com/users/lilleyse/repos","events_url":"https://api.github.com/users/lilleyse/events{/privacy}","received_events_url":"https://api.github.com/users/lilleyse/received_events","type":"User","site_admin":false},"created_at":"2016-08-03T18:19:10Z","updated_at":"2016-08-03T18:19:10Z","body":"This is also noticeable in the `3D Models` demo. @tfili the commit is https://github.com/AnalyticalGraphicsInc/cesium/commit/934828e1d74e3383f9925c39fb9cf9c35822781e when something changed.\r\n\r\nThe correct start view changed to the one below:\r\n![capture](https://cloud.githubusercontent.com/assets/915398/17376753/f405c78c-5984-11e6-849d-012ce037d8d1.JPG)\r\n![capture2](https://cloud.githubusercontent.com/assets/915398/17376755/f4093cb4-5984-11e6-809d-ad34f737f4d3.JPG)\r\n"}}
{"actor":{"display_login":"lilleyse"}}