{"action":"created","issue":{"url":"https://api.github.com/repos/rhinstaller/anaconda/issues/483","labels_url":"https://api.github.com/repos/rhinstaller/anaconda/issues/483/labels{/name}","comments_url":"https://api.github.com/repos/rhinstaller/anaconda/issues/483/comments","events_url":"https://api.github.com/repos/rhinstaller/anaconda/issues/483/events","html_url":"https://github.com/rhinstaller/anaconda/pull/483","id":126876229,"number":483,"title":"Enable multiselection in Custom spoke","user":{"login":"jkonecny12","id":1643889,"avatar_url":"https://avatars.githubusercontent.com/u/1643889?v=3","gravatar_id":"","url":"https://api.github.com/users/jkonecny12","html_url":"https://github.com/jkonecny12","followers_url":"https://api.github.com/users/jkonecny12/followers","following_url":"https://api.github.com/users/jkonecny12/following{/other_user}","gists_url":"https://api.github.com/users/jkonecny12/gists{/gist_id}","starred_url":"https://api.github.com/users/jkonecny12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkonecny12/subscriptions","organizations_url":"https://api.github.com/users/jkonecny12/orgs","repos_url":"https://api.github.com/users/jkonecny12/repos","events_url":"https://api.github.com/users/jkonecny12/events{/privacy}","received_events_url":"https://api.github.com/users/jkonecny12/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/rhinstaller/anaconda/labels/master","name":"master","color":"5319e7"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-01-15T13:52:06Z","updated_at":"2016-01-20T15:48:15Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/rhinstaller/anaconda/pulls/483","html_url":"https://github.com/rhinstaller/anaconda/pull/483","diff_url":"https://github.com/rhinstaller/anaconda/pull/483.diff","patch_url":"https://github.com/rhinstaller/anaconda/pull/483.patch"},"body":"This series of commits should add multiselection feature to Anaconda.\r\n\r\nIt supports multiselection when holding CTRL and SHIFT keys and clicking by mouse. I do not support item selection by keyboard but I think it don't work before too, so no difference here.\r\n\r\nIn these commits I have changed MountpointSelector.[c/h] so new AnacondaWidgets package is mandatory to work with this Custom spoke. \r\n\r\nI have a question should I increment AnacondaWidgets version or this is done by someone after some time? Also ``gi.require_version()`` for Widgets should be changed after the version increment.\r\n\r\nHere you found screenshots:\r\nhttps://jkonecny.fedorapeople.org/redhat/screenshots/multiselection/\r\n\r\n*Resolved: 1265620*"},"comment":{"url":"https://api.github.com/repos/rhinstaller/anaconda/issues/comments/173245180","html_url":"https://github.com/rhinstaller/anaconda/pull/483#issuecomment-173245180","issue_url":"https://api.github.com/repos/rhinstaller/anaconda/issues/483","id":173245180,"user":{"login":"clumens","id":6717690,"avatar_url":"https://avatars.githubusercontent.com/u/6717690?v=3","gravatar_id":"","url":"https://api.github.com/users/clumens","html_url":"https://github.com/clumens","followers_url":"https://api.github.com/users/clumens/followers","following_url":"https://api.github.com/users/clumens/following{/other_user}","gists_url":"https://api.github.com/users/clumens/gists{/gist_id}","starred_url":"https://api.github.com/users/clumens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clumens/subscriptions","organizations_url":"https://api.github.com/users/clumens/orgs","repos_url":"https://api.github.com/users/clumens/repos","events_url":"https://api.github.com/users/clumens/events{/privacy}","received_events_url":"https://api.github.com/users/clumens/received_events","type":"User","site_admin":false},"created_at":"2016-01-20T15:48:15Z","updated_at":"2016-01-20T15:48:15Z","body":"I have two UI concerns.\r\n\r\n(1) The sentence \"You can't edit device in multiselection mode.\" uses jargon that I don't think we should expect the user to understand.  I think a better sentence might be something like \"You can't edit a mount point when you have more than one selected.\"  That's more in line with other text we display on that screen and is clearer what the problem is.\r\n\r\n(2) I'm not sure the \"(1/3)\" text showing how many devices are selected is at all clear.  I missed it the first time through the screenshots, and it was only when I saw the patch adding it that I noticed.  My first question would be:  Do we definitely need to display this information?  Did you find it to be confusing or misleading without knowing how many devices were selected in each?  If so, perhaps adding a small string underneath the name of the OS of the format \"X of Y mount points selected\" might be clearer."}}