{"action":"created","comment":{"url":"https://api.github.com/repos/docker/docker/pulls/comments/72514581","id":72514581,"diff_hunk":"@@ -1,21 +1,541 @@\n <!--[metadata]>\n +++\n-title = \"Network configuration\"\n-description = \"Docker networking feature is introduced\"\n-keywords = [\"network, networking, bridge, docker,  documentation\"]\n+aliases=[\n+\"/engine/userguide/networking/dockernetworks\"\n+]\n+title = \"Docker container networking\"\n+description = \"How do we connect docker containers within and across hosts ?\"\n+keywords = [\"Examples, Usage, network, docker, documentation, user guide, multihost, cluster\"]\n [menu.main]\n-identifier=\"smn_networking\"\n-parent= \"engine_guide\"\n-weight=7\n+parent = \"smn_networking\"\n+weight = -5\n +++\n <![end-metadata]-->\n \n-# Docker networks feature overview\n+# Understand Docker container networks\n \n-This sections explains how to use the Docker networks feature. This feature allows users to define their own networks and connect containers to them. Using this feature you can create a network on a single host or a network that spans across multiple hosts.\n+To build web applications that act in concert but do so securely, use the Docker\n+networks feature. Networks, by definition, provide complete isolation for\n+containers. So, it is important to have control over the networks your","path":"docs/userguide/networking/index.md","position":27,"original_position":27,"commit_id":"f67ea38dfea4a7a38c0c7130f3f8c7ef5102c175","original_commit_id":"f67ea38dfea4a7a38c0c7130f3f8c7ef5102c175","user":{"login":"diogomonica","id":55332,"avatar_url":"https://avatars.githubusercontent.com/u/55332?v=3","gravatar_id":"","url":"https://api.github.com/users/diogomonica","html_url":"https://github.com/diogomonica","followers_url":"https://api.github.com/users/diogomonica/followers","following_url":"https://api.github.com/users/diogomonica/following{/other_user}","gists_url":"https://api.github.com/users/diogomonica/gists{/gist_id}","starred_url":"https://api.github.com/users/diogomonica/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diogomonica/subscriptions","organizations_url":"https://api.github.com/users/diogomonica/orgs","repos_url":"https://api.github.com/users/diogomonica/repos","events_url":"https://api.github.com/users/diogomonica/events{/privacy}","received_events_url":"https://api.github.com/users/diogomonica/received_events","type":"User","site_admin":false},"body":"I don't understand the logic leap from \"they provide complete isolation\" to \"so it is important to have control over them\"","created_at":"2016-07-27T20:16:56Z","updated_at":"2016-07-27T20:16:56Z","html_url":"https://github.com/docker/docker/pull/25135#discussion_r72514581","pull_request_url":"https://api.github.com/repos/docker/docker/pulls/25135","_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/comments/72514581"},"html":{"href":"https://github.com/docker/docker/pull/25135#discussion_r72514581"},"pull_request":{"href":"https://api.github.com/repos/docker/docker/pulls/25135"}}},"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/25135","id":79065147,"html_url":"https://github.com/docker/docker/pull/25135","diff_url":"https://github.com/docker/docker/pull/25135.diff","patch_url":"https://github.com/docker/docker/pull/25135.patch","issue_url":"https://api.github.com/repos/docker/docker/issues/25135","number":25135,"state":"open","locked":false,"title":"add overlay networking security model node","user":{"login":"sfsmithcha","id":2415653,"avatar_url":"https://avatars.githubusercontent.com/u/2415653?v=3","gravatar_id":"","url":"https://api.github.com/users/sfsmithcha","html_url":"https://github.com/sfsmithcha","followers_url":"https://api.github.com/users/sfsmithcha/followers","following_url":"https://api.github.com/users/sfsmithcha/following{/other_user}","gists_url":"https://api.github.com/users/sfsmithcha/gists{/gist_id}","starred_url":"https://api.github.com/users/sfsmithcha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sfsmithcha/subscriptions","organizations_url":"https://api.github.com/users/sfsmithcha/orgs","repos_url":"https://api.github.com/users/sfsmithcha/repos","events_url":"https://api.github.com/users/sfsmithcha/events{/privacy}","received_events_url":"https://api.github.com/users/sfsmithcha/received_events","type":"User","site_admin":false},"body":"Describes the overlay network security model for swarm mode. Also updates the networking user guide to use the new menu.md/index.md model\r\n\r\nSigned-off-by: Charles Smith <charles.smith@docker.com>","created_at":"2016-07-27T17:32:49Z","updated_at":"2016-07-27T20:16:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"debf98892a52147deb094ed474be4e4a690cfa44","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/docker/docker/pulls/25135/commits","review_comments_url":"https://api.github.com/repos/docker/docker/pulls/25135/comments","review_comment_url":"https://api.github.com/repos/docker/docker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/docker/issues/25135/comments","statuses_url":"https://api.github.com/repos/docker/docker/statuses/f67ea38dfea4a7a38c0c7130f3f8c7ef5102c175","head":{"label":"sfsmithcha:add_overlay_networking_note","ref":"add_overlay_networking_note","sha":"f67ea38dfea4a7a38c0c7130f3f8c7ef5102c175","user":{"login":"sfsmithcha","id":2415653,"avatar_url":"https://avatars.githubusercontent.com/u/2415653?v=3","gravatar_id":"","url":"https://api.github.com/users/sfsmithcha","html_url":"https://github.com/sfsmithcha","followers_url":"https://api.github.com/users/sfsmithcha/followers","following_url":"https://api.github.com/users/sfsmithcha/following{/other_user}","gists_url":"https://api.github.com/users/sfsmithcha/gists{/gist_id}","starred_url":"https://api.github.com/users/sfsmithcha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sfsmithcha/subscriptions","organizations_url":"https://api.github.com/users/sfsmithcha/orgs","repos_url":"https://api.github.com/users/sfsmithcha/repos","events_url":"https://api.github.com/users/sfsmithcha/events{/privacy}","received_events_url":"https://api.github.com/users/sfsmithcha/received_events","type":"User","site_admin":false},"repo":{"id":55171255,"name":"docker","full_name":"sfsmithcha/docker","owner":{"login":"sfsmithcha","id":2415653,"avatar_url":"https://avatars.githubusercontent.com/u/2415653?v=3","gravatar_id":"","url":"https://api.github.com/users/sfsmithcha","html_url":"https://github.com/sfsmithcha","followers_url":"https://api.github.com/users/sfsmithcha/followers","following_url":"https://api.github.com/users/sfsmithcha/following{/other_user}","gists_url":"https://api.github.com/users/sfsmithcha/gists{/gist_id}","starred_url":"https://api.github.com/users/sfsmithcha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sfsmithcha/subscriptions","organizations_url":"https://api.github.com/users/sfsmithcha/orgs","repos_url":"https://api.github.com/users/sfsmithcha/repos","events_url":"https://api.github.com/users/sfsmithcha/events{/privacy}","received_events_url":"https://api.github.com/users/sfsmithcha/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sfsmithcha/docker","description":"Docker - the open-source application container engine","fork":true,"url":"https://api.github.com/repos/sfsmithcha/docker","forks_url":"https://api.github.com/repos/sfsmithcha/docker/forks","keys_url":"https://api.github.com/repos/sfsmithcha/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sfsmithcha/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sfsmithcha/docker/teams","hooks_url":"https://api.github.com/repos/sfsmithcha/docker/hooks","issue_events_url":"https://api.github.com/repos/sfsmithcha/docker/issues/events{/number}","events_url":"https://api.github.com/repos/sfsmithcha/docker/events","assignees_url":"https://api.github.com/repos/sfsmithcha/docker/assignees{/user}","branches_url":"https://api.github.com/repos/sfsmithcha/docker/branches{/branch}","tags_url":"https://api.github.com/repos/sfsmithcha/docker/tags","blobs_url":"https://api.github.com/repos/sfsmithcha/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sfsmithcha/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sfsmithcha/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/sfsmithcha/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sfsmithcha/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/sfsmithcha/docker/languages","stargazers_url":"https://api.github.com/repos/sfsmithcha/docker/stargazers","contributors_url":"https://api.github.com/repos/sfsmithcha/docker/contributors","subscribers_url":"https://api.github.com/repos/sfsmithcha/docker/subscribers","subscription_url":"https://api.github.com/repos/sfsmithcha/docker/subscription","commits_url":"https://api.github.com/repos/sfsmithcha/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/sfsmithcha/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/sfsmithcha/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/sfsmithcha/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/sfsmithcha/docker/contents/{+path}","compare_url":"https://api.github.com/repos/sfsmithcha/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sfsmithcha/docker/merges","archive_url":"https://api.github.com/repos/sfsmithcha/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sfsmithcha/docker/downloads","issues_url":"https://api.github.com/repos/sfsmithcha/docker/issues{/number}","pulls_url":"https://api.github.com/repos/sfsmithcha/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/sfsmithcha/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/sfsmithcha/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sfsmithcha/docker/labels{/name}","releases_url":"https://api.github.com/repos/sfsmithcha/docker/releases{/id}","deployments_url":"https://api.github.com/repos/sfsmithcha/docker/deployments","created_at":"2016-03-31T17:50:02Z","updated_at":"2016-03-31T17:50:14Z","pushed_at":"2016-07-27T18:20:24Z","git_url":"git://github.com/sfsmithcha/docker.git","ssh_url":"git@github.com:sfsmithcha/docker.git","clone_url":"https://github.com/sfsmithcha/docker.git","svn_url":"https://github.com/sfsmithcha/docker","homepage":"http://www.docker.com","size":96806,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"b90f6d780a4b24bcd877505d177593dd5af8107d","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":7691631,"name":"docker","full_name":"docker/docker","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/docker","description":"Docker - the open-source application container engine","fork":false,"url":"https://api.github.com/repos/docker/docker","forks_url":"https://api.github.com/repos/docker/docker/forks","keys_url":"https://api.github.com/repos/docker/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/docker/teams","hooks_url":"https://api.github.com/repos/docker/docker/hooks","issue_events_url":"https://api.github.com/repos/docker/docker/issues/events{/number}","events_url":"https://api.github.com/repos/docker/docker/events","assignees_url":"https://api.github.com/repos/docker/docker/assignees{/user}","branches_url":"https://api.github.com/repos/docker/docker/branches{/branch}","tags_url":"https://api.github.com/repos/docker/docker/tags","blobs_url":"https://api.github.com/repos/docker/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/docker/languages","stargazers_url":"https://api.github.com/repos/docker/docker/stargazers","contributors_url":"https://api.github.com/repos/docker/docker/contributors","subscribers_url":"https://api.github.com/repos/docker/docker/subscribers","subscription_url":"https://api.github.com/repos/docker/docker/subscription","commits_url":"https://api.github.com/repos/docker/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/docker/contents/{+path}","compare_url":"https://api.github.com/repos/docker/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/docker/merges","archive_url":"https://api.github.com/repos/docker/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/docker/downloads","issues_url":"https://api.github.com/repos/docker/docker/issues{/number}","pulls_url":"https://api.github.com/repos/docker/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/docker/labels{/name}","releases_url":"https://api.github.com/repos/docker/docker/releases{/id}","deployments_url":"https://api.github.com/repos/docker/docker/deployments","created_at":"2013-01-18T18:10:57Z","updated_at":"2016-07-27T19:12:51Z","pushed_at":"2016-07-27T19:45:33Z","git_url":"git://github.com/docker/docker.git","ssh_url":"git@github.com:docker/docker.git","clone_url":"https://github.com/docker/docker.git","svn_url":"https://github.com/docker/docker","homepage":"http://www.docker.com","size":203839,"stargazers_count":33423,"watchers_count":33423,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9704,"mirror_url":null,"open_issues_count":2080,"forks":9704,"open_issues":2080,"watchers":33423,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/25135"},"html":{"href":"https://github.com/docker/docker/pull/25135"},"issue":{"href":"https://api.github.com/repos/docker/docker/issues/25135"},"comments":{"href":"https://api.github.com/repos/docker/docker/issues/25135/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/docker/pulls/25135/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/docker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/docker/pulls/25135/commits"},"statuses":{"href":"https://api.github.com/repos/docker/docker/statuses/f67ea38dfea4a7a38c0c7130f3f8c7ef5102c175"}}}}
{"actor":{"display_login":"diogomonica"}}