{"action":"created","comment":{"url":"https://api.github.com/repos/buildbot/buildbot/pulls/comments/82502704","pull_request_review_id":3408602,"id":82502704,"diff_hunk":"@@ -14,14 +14,14 @@\n # Copyright Buildbot Team Members\n # Portions Copyright 2013 Bad Dog Consulting\n import re\n-from types import StringType\n \n from future.utils import string_types\n from twisted.internet import defer\n from twisted.python import log\n \n from buildbot import config\n from buildbot import interfaces\n+from buildbot import util","path":"master/buildbot/steps/source/p4.py","position":12,"original_position":12,"commit_id":"e969ddcd847b3d94c31d3fd4467ec7f146ad62c8","original_commit_id":"e969ddcd847b3d94c31d3fd4467ec7f146ad62c8","user":{"login":"sa2ajj","id":447092,"avatar_url":"https://avatars.githubusercontent.com/u/447092?v=3","gravatar_id":"","url":"https://api.github.com/users/sa2ajj","html_url":"https://github.com/sa2ajj","followers_url":"https://api.github.com/users/sa2ajj/followers","following_url":"https://api.github.com/users/sa2ajj/following{/other_user}","gists_url":"https://api.github.com/users/sa2ajj/gists{/gist_id}","starred_url":"https://api.github.com/users/sa2ajj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sa2ajj/subscriptions","organizations_url":"https://api.github.com/users/sa2ajj/orgs","repos_url":"https://api.github.com/users/sa2ajj/repos","events_url":"https://api.github.com/users/sa2ajj/events{/privacy}","received_events_url":"https://api.github.com/users/sa2ajj/received_events","type":"User","site_admin":false},"body":"`util` goes at the end of the import list.","created_at":"2016-10-08T13:39:35Z","updated_at":"2016-10-08T13:40:23Z","html_url":"https://github.com/buildbot/buildbot/pull/2388#discussion_r82502704","pull_request_url":"https://api.github.com/repos/buildbot/buildbot/pulls/2388","_links":{"self":{"href":"https://api.github.com/repos/buildbot/buildbot/pulls/comments/82502704"},"html":{"href":"https://github.com/buildbot/buildbot/pull/2388#discussion_r82502704"},"pull_request":{"href":"https://api.github.com/repos/buildbot/buildbot/pulls/2388"}}},"pull_request":{"url":"https://api.github.com/repos/buildbot/buildbot/pulls/2388","id":83901810,"html_url":"https://github.com/buildbot/buildbot/pull/2388","diff_url":"https://github.com/buildbot/buildbot/pull/2388.diff","patch_url":"https://github.com/buildbot/buildbot/pull/2388.patch","issue_url":"https://api.github.com/repos/buildbot/buildbot/issues/2388","number":2388,"state":"open","locked":false,"title":"Remove types.StringTypes which is gone in Python 3","user":{"login":"rodrigc","id":1895943,"avatar_url":"https://avatars.githubusercontent.com/u/1895943?v=3","gravatar_id":"","url":"https://api.github.com/users/rodrigc","html_url":"https://github.com/rodrigc","followers_url":"https://api.github.com/users/rodrigc/followers","following_url":"https://api.github.com/users/rodrigc/following{/other_user}","gists_url":"https://api.github.com/users/rodrigc/gists{/gist_id}","starred_url":"https://api.github.com/users/rodrigc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rodrigc/subscriptions","organizations_url":"https://api.github.com/users/rodrigc/orgs","repos_url":"https://api.github.com/users/rodrigc/repos","events_url":"https://api.github.com/users/rodrigc/events{/privacy}","received_events_url":"https://api.github.com/users/rodrigc/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-09-03T18:03:50Z","updated_at":"2016-10-08T13:40:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9f60f65ea0746f2d3abe5bc585db3cebfcc43df6","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/buildbot/buildbot/pulls/2388/commits","review_comments_url":"https://api.github.com/repos/buildbot/buildbot/pulls/2388/comments","review_comment_url":"https://api.github.com/repos/buildbot/buildbot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/buildbot/buildbot/issues/2388/comments","statuses_url":"https://api.github.com/repos/buildbot/buildbot/statuses/e969ddcd847b3d94c31d3fd4467ec7f146ad62c8","head":{"label":"rodrigc:stringtype","ref":"stringtype","sha":"e969ddcd847b3d94c31d3fd4467ec7f146ad62c8","user":{"login":"rodrigc","id":1895943,"avatar_url":"https://avatars.githubusercontent.com/u/1895943?v=3","gravatar_id":"","url":"https://api.github.com/users/rodrigc","html_url":"https://github.com/rodrigc","followers_url":"https://api.github.com/users/rodrigc/followers","following_url":"https://api.github.com/users/rodrigc/following{/other_user}","gists_url":"https://api.github.com/users/rodrigc/gists{/gist_id}","starred_url":"https://api.github.com/users/rodrigc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rodrigc/subscriptions","organizations_url":"https://api.github.com/users/rodrigc/orgs","repos_url":"https://api.github.com/users/rodrigc/repos","events_url":"https://api.github.com/users/rodrigc/events{/privacy}","received_events_url":"https://api.github.com/users/rodrigc/received_events","type":"User","site_admin":false},"repo":{"id":66556283,"name":"buildbot","full_name":"rodrigc/buildbot","owner":{"login":"rodrigc","id":1895943,"avatar_url":"https://avatars.githubusercontent.com/u/1895943?v=3","gravatar_id":"","url":"https://api.github.com/users/rodrigc","html_url":"https://github.com/rodrigc","followers_url":"https://api.github.com/users/rodrigc/followers","following_url":"https://api.github.com/users/rodrigc/following{/other_user}","gists_url":"https://api.github.com/users/rodrigc/gists{/gist_id}","starred_url":"https://api.github.com/users/rodrigc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rodrigc/subscriptions","organizations_url":"https://api.github.com/users/rodrigc/orgs","repos_url":"https://api.github.com/users/rodrigc/repos","events_url":"https://api.github.com/users/rodrigc/events{/privacy}","received_events_url":"https://api.github.com/users/rodrigc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rodrigc/buildbot","description":"Python-based continuous integration testing framework; your pull requests are more than welcome!","fork":true,"url":"https://api.github.com/repos/rodrigc/buildbot","forks_url":"https://api.github.com/repos/rodrigc/buildbot/forks","keys_url":"https://api.github.com/repos/rodrigc/buildbot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rodrigc/buildbot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rodrigc/buildbot/teams","hooks_url":"https://api.github.com/repos/rodrigc/buildbot/hooks","issue_events_url":"https://api.github.com/repos/rodrigc/buildbot/issues/events{/number}","events_url":"https://api.github.com/repos/rodrigc/buildbot/events","assignees_url":"https://api.github.com/repos/rodrigc/buildbot/assignees{/user}","branches_url":"https://api.github.com/repos/rodrigc/buildbot/branches{/branch}","tags_url":"https://api.github.com/repos/rodrigc/buildbot/tags","blobs_url":"https://api.github.com/repos/rodrigc/buildbot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rodrigc/buildbot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rodrigc/buildbot/git/refs{/sha}","trees_url":"https://api.github.com/repos/rodrigc/buildbot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rodrigc/buildbot/statuses/{sha}","languages_url":"https://api.github.com/repos/rodrigc/buildbot/languages","stargazers_url":"https://api.github.com/repos/rodrigc/buildbot/stargazers","contributors_url":"https://api.github.com/repos/rodrigc/buildbot/contributors","subscribers_url":"https://api.github.com/repos/rodrigc/buildbot/subscribers","subscription_url":"https://api.github.com/repos/rodrigc/buildbot/subscription","commits_url":"https://api.github.com/repos/rodrigc/buildbot/commits{/sha}","git_commits_url":"https://api.github.com/repos/rodrigc/buildbot/git/commits{/sha}","comments_url":"https://api.github.com/repos/rodrigc/buildbot/comments{/number}","issue_comment_url":"https://api.github.com/repos/rodrigc/buildbot/issues/comments{/number}","contents_url":"https://api.github.com/repos/rodrigc/buildbot/contents/{+path}","compare_url":"https://api.github.com/repos/rodrigc/buildbot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rodrigc/buildbot/merges","archive_url":"https://api.github.com/repos/rodrigc/buildbot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rodrigc/buildbot/downloads","issues_url":"https://api.github.com/repos/rodrigc/buildbot/issues{/number}","pulls_url":"https://api.github.com/repos/rodrigc/buildbot/pulls{/number}","milestones_url":"https://api.github.com/repos/rodrigc/buildbot/milestones{/number}","notifications_url":"https://api.github.com/repos/rodrigc/buildbot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rodrigc/buildbot/labels{/name}","releases_url":"https://api.github.com/repos/rodrigc/buildbot/releases{/id}","deployments_url":"https://api.github.com/repos/rodrigc/buildbot/deployments","created_at":"2016-08-25T12:32:30Z","updated_at":"2016-08-25T12:32:35Z","pushed_at":"2016-10-04T21:48:32Z","git_url":"git://github.com/rodrigc/buildbot.git","ssh_url":"git@github.com:rodrigc/buildbot.git","clone_url":"https://github.com/rodrigc/buildbot.git","svn_url":"https://github.com/rodrigc/buildbot","homepage":"http://buildbot.net","size":41018,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"buildbot:master","ref":"master","sha":"de883d525a3987bd6eb0cf14e95cb4fe8fc1cdf4","user":{"login":"buildbot","id":324515,"avatar_url":"https://avatars.githubusercontent.com/u/324515?v=3","gravatar_id":"","url":"https://api.github.com/users/buildbot","html_url":"https://github.com/buildbot","followers_url":"https://api.github.com/users/buildbot/followers","following_url":"https://api.github.com/users/buildbot/following{/other_user}","gists_url":"https://api.github.com/users/buildbot/gists{/gist_id}","starred_url":"https://api.github.com/users/buildbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buildbot/subscriptions","organizations_url":"https://api.github.com/users/buildbot/orgs","repos_url":"https://api.github.com/users/buildbot/repos","events_url":"https://api.github.com/users/buildbot/events{/privacy}","received_events_url":"https://api.github.com/users/buildbot/received_events","type":"Organization","site_admin":false},"repo":{"id":760165,"name":"buildbot","full_name":"buildbot/buildbot","owner":{"login":"buildbot","id":324515,"avatar_url":"https://avatars.githubusercontent.com/u/324515?v=3","gravatar_id":"","url":"https://api.github.com/users/buildbot","html_url":"https://github.com/buildbot","followers_url":"https://api.github.com/users/buildbot/followers","following_url":"https://api.github.com/users/buildbot/following{/other_user}","gists_url":"https://api.github.com/users/buildbot/gists{/gist_id}","starred_url":"https://api.github.com/users/buildbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buildbot/subscriptions","organizations_url":"https://api.github.com/users/buildbot/orgs","repos_url":"https://api.github.com/users/buildbot/repos","events_url":"https://api.github.com/users/buildbot/events{/privacy}","received_events_url":"https://api.github.com/users/buildbot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/buildbot/buildbot","description":"Python-based continuous integration testing framework; your pull requests are more than welcome!","fork":false,"url":"https://api.github.com/repos/buildbot/buildbot","forks_url":"https://api.github.com/repos/buildbot/buildbot/forks","keys_url":"https://api.github.com/repos/buildbot/buildbot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/buildbot/buildbot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/buildbot/buildbot/teams","hooks_url":"https://api.github.com/repos/buildbot/buildbot/hooks","issue_events_url":"https://api.github.com/repos/buildbot/buildbot/issues/events{/number}","events_url":"https://api.github.com/repos/buildbot/buildbot/events","assignees_url":"https://api.github.com/repos/buildbot/buildbot/assignees{/user}","branches_url":"https://api.github.com/repos/buildbot/buildbot/branches{/branch}","tags_url":"https://api.github.com/repos/buildbot/buildbot/tags","blobs_url":"https://api.github.com/repos/buildbot/buildbot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/buildbot/buildbot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/buildbot/buildbot/git/refs{/sha}","trees_url":"https://api.github.com/repos/buildbot/buildbot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/buildbot/buildbot/statuses/{sha}","languages_url":"https://api.github.com/repos/buildbot/buildbot/languages","stargazers_url":"https://api.github.com/repos/buildbot/buildbot/stargazers","contributors_url":"https://api.github.com/repos/buildbot/buildbot/contributors","subscribers_url":"https://api.github.com/repos/buildbot/buildbot/subscribers","subscription_url":"https://api.github.com/repos/buildbot/buildbot/subscription","commits_url":"https://api.github.com/repos/buildbot/buildbot/commits{/sha}","git_commits_url":"https://api.github.com/repos/buildbot/buildbot/git/commits{/sha}","comments_url":"https://api.github.com/repos/buildbot/buildbot/comments{/number}","issue_comment_url":"https://api.github.com/repos/buildbot/buildbot/issues/comments{/number}","contents_url":"https://api.github.com/repos/buildbot/buildbot/contents/{+path}","compare_url":"https://api.github.com/repos/buildbot/buildbot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/buildbot/buildbot/merges","archive_url":"https://api.github.com/repos/buildbot/buildbot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/buildbot/buildbot/downloads","issues_url":"https://api.github.com/repos/buildbot/buildbot/issues{/number}","pulls_url":"https://api.github.com/repos/buildbot/buildbot/pulls{/number}","milestones_url":"https://api.github.com/repos/buildbot/buildbot/milestones{/number}","notifications_url":"https://api.github.com/repos/buildbot/buildbot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/buildbot/buildbot/labels{/name}","releases_url":"https://api.github.com/repos/buildbot/buildbot/releases{/id}","deployments_url":"https://api.github.com/repos/buildbot/buildbot/deployments","created_at":"2010-07-06T17:56:53Z","updated_at":"2016-10-07T16:37:31Z","pushed_at":"2016-10-07T16:19:54Z","git_url":"git://github.com/buildbot/buildbot.git","ssh_url":"git@github.com:buildbot/buildbot.git","clone_url":"https://github.com/buildbot/buildbot.git","svn_url":"https://github.com/buildbot/buildbot","homepage":"http://buildbot.net","size":90464,"stargazers_count":2378,"watchers_count":2378,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":965,"mirror_url":null,"open_issues_count":13,"forks":965,"open_issues":13,"watchers":2378,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/buildbot/buildbot/pulls/2388"},"html":{"href":"https://github.com/buildbot/buildbot/pull/2388"},"issue":{"href":"https://api.github.com/repos/buildbot/buildbot/issues/2388"},"comments":{"href":"https://api.github.com/repos/buildbot/buildbot/issues/2388/comments"},"review_comments":{"href":"https://api.github.com/repos/buildbot/buildbot/pulls/2388/comments"},"review_comment":{"href":"https://api.github.com/repos/buildbot/buildbot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/buildbot/buildbot/pulls/2388/commits"},"statuses":{"href":"https://api.github.com/repos/buildbot/buildbot/statuses/e969ddcd847b3d94c31d3fd4467ec7f146ad62c8"}}}}
{"actor":{"display_login":"sa2ajj"}}