{"action":"created","comment":{"url":"https://api.github.com/repos/coreos/rkt/pulls/comments/57718783","id":57718783,"diff_hunk":"@@ -914,8 +915,8 @@ func (p *pod) getContainerPID1() (pid int, err error) {\n \t\t\treturn -1, err\n \t\t}\n \n-\t\tif !os.IsNotExist(err) || !p.isRunning() {\n-\t\t\treturn -1, err\n+\t\tif !p.isRunning() {\n+\t\t\treturn -1, fmt.Errorf(\"pod %v is not running after refreshState()\", p.uuid)","path":"rkt/pods.go","position":26,"original_position":26,"commit_id":"047fa8de9cb0bc0900154c9a702f8cbeab11c5e2","original_commit_id":"047fa8de9cb0bc0900154c9a702f8cbeab11c5e2","user":{"login":"alban","id":27575,"avatar_url":"https://avatars.githubusercontent.com/u/27575?v=3","gravatar_id":"","url":"https://api.github.com/users/alban","html_url":"https://github.com/alban","followers_url":"https://api.github.com/users/alban/followers","following_url":"https://api.github.com/users/alban/following{/other_user}","gists_url":"https://api.github.com/users/alban/gists{/gist_id}","starred_url":"https://api.github.com/users/alban/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alban/subscriptions","organizations_url":"https://api.github.com/users/alban/orgs","repos_url":"https://api.github.com/users/alban/repos","events_url":"https://api.github.com/users/alban/events{/privacy}","received_events_url":"https://api.github.com/users/alban/received_events","type":"User","site_admin":false},"body":"\"after refreshState()\"  is an implementation detail. Can you remove it from the message?\r\n\r\n> pod %v is not running anymore\r\n\r\nIf it is called from rkt/enter.go:runEnter, it would be:\r\n\r\n> unable to determine the pid for pod %q: pod %v is not running anymore\r\n","created_at":"2016-03-29T13:04:51Z","updated_at":"2016-03-29T13:04:51Z","html_url":"https://github.com/coreos/rkt/pull/2332#discussion_r57718783","pull_request_url":"https://api.github.com/repos/coreos/rkt/pulls/2332","_links":{"self":{"href":"https://api.github.com/repos/coreos/rkt/pulls/comments/57718783"},"html":{"href":"https://github.com/coreos/rkt/pull/2332#discussion_r57718783"},"pull_request":{"href":"https://api.github.com/repos/coreos/rkt/pulls/2332"}}},"pull_request":{"url":"https://api.github.com/repos/coreos/rkt/pulls/2332","id":64230880,"html_url":"https://github.com/coreos/rkt/pull/2332","diff_url":"https://github.com/coreos/rkt/pull/2332.diff","patch_url":"https://github.com/coreos/rkt/pull/2332.patch","issue_url":"https://api.github.com/repos/coreos/rkt/issues/2332","number":2332,"state":"open","locked":false,"title":"rkt/pods.go: Fix a bug in getContainerPID1().","user":{"login":"yifan-gu","id":3278588,"avatar_url":"https://avatars.githubusercontent.com/u/3278588?v=3","gravatar_id":"","url":"https://api.github.com/users/yifan-gu","html_url":"https://github.com/yifan-gu","followers_url":"https://api.github.com/users/yifan-gu/followers","following_url":"https://api.github.com/users/yifan-gu/following{/other_user}","gists_url":"https://api.github.com/users/yifan-gu/gists{/gist_id}","starred_url":"https://api.github.com/users/yifan-gu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yifan-gu/subscriptions","organizations_url":"https://api.github.com/users/yifan-gu/orgs","repos_url":"https://api.github.com/users/yifan-gu/repos","events_url":"https://api.github.com/users/yifan-gu/events{/privacy}","received_events_url":"https://api.github.com/users/yifan-gu/received_events","type":"User","site_admin":false},"body":"If 'getChildPID()' returns an 'ErrChildNotReady' error,\r\nthen the variable 'err' will be set to nil, which causes the last\r\nIf statement's condition to be true, and returns '-1, nil'.\r\n\r\n\r\ncc @alban @iaguis @sjpotter ","created_at":"2016-03-26T06:38:45Z","updated_at":"2016-03-29T13:04:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2125afd0d814474019d6a0ae1bb5cced60f0c653","assignee":{"login":"alban","id":27575,"avatar_url":"https://avatars.githubusercontent.com/u/27575?v=3","gravatar_id":"","url":"https://api.github.com/users/alban","html_url":"https://github.com/alban","followers_url":"https://api.github.com/users/alban/followers","following_url":"https://api.github.com/users/alban/following{/other_user}","gists_url":"https://api.github.com/users/alban/gists{/gist_id}","starred_url":"https://api.github.com/users/alban/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alban/subscriptions","organizations_url":"https://api.github.com/users/alban/orgs","repos_url":"https://api.github.com/users/alban/repos","events_url":"https://api.github.com/users/alban/events{/privacy}","received_events_url":"https://api.github.com/users/alban/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/coreos/rkt/milestones/33","html_url":"https://github.com/coreos/rkt/milestones/v1.3.0","labels_url":"https://api.github.com/repos/coreos/rkt/milestones/33/labels","id":1563286,"number":33,"title":"v1.3.0","description":"","creator":{"login":"jonboulle","id":2601015,"avatar_url":"https://avatars.githubusercontent.com/u/2601015?v=3","gravatar_id":"","url":"https://api.github.com/users/jonboulle","html_url":"https://github.com/jonboulle","followers_url":"https://api.github.com/users/jonboulle/followers","following_url":"https://api.github.com/users/jonboulle/following{/other_user}","gists_url":"https://api.github.com/users/jonboulle/gists{/gist_id}","starred_url":"https://api.github.com/users/jonboulle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonboulle/subscriptions","organizations_url":"https://api.github.com/users/jonboulle/orgs","repos_url":"https://api.github.com/users/jonboulle/repos","events_url":"https://api.github.com/users/jonboulle/events{/privacy}","received_events_url":"https://api.github.com/users/jonboulle/received_events","type":"User","site_admin":false},"open_issues":67,"closed_issues":8,"state":"open","created_at":"2016-02-04T13:49:12Z","updated_at":"2016-03-29T11:36:11Z","due_on":"2016-03-30T22:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/coreos/rkt/pulls/2332/commits","review_comments_url":"https://api.github.com/repos/coreos/rkt/pulls/2332/comments","review_comment_url":"https://api.github.com/repos/coreos/rkt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coreos/rkt/issues/2332/comments","statuses_url":"https://api.github.com/repos/coreos/rkt/statuses/047fa8de9cb0bc0900154c9a702f8cbeab11c5e2","head":{"label":"yifan-gu:fix_getContainerPID1","ref":"fix_getContainerPID1","sha":"047fa8de9cb0bc0900154c9a702f8cbeab11c5e2","user":{"login":"yifan-gu","id":3278588,"avatar_url":"https://avatars.githubusercontent.com/u/3278588?v=3","gravatar_id":"","url":"https://api.github.com/users/yifan-gu","html_url":"https://github.com/yifan-gu","followers_url":"https://api.github.com/users/yifan-gu/followers","following_url":"https://api.github.com/users/yifan-gu/following{/other_user}","gists_url":"https://api.github.com/users/yifan-gu/gists{/gist_id}","starred_url":"https://api.github.com/users/yifan-gu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yifan-gu/subscriptions","organizations_url":"https://api.github.com/users/yifan-gu/orgs","repos_url":"https://api.github.com/users/yifan-gu/repos","events_url":"https://api.github.com/users/yifan-gu/events{/privacy}","received_events_url":"https://api.github.com/users/yifan-gu/received_events","type":"User","site_admin":false},"repo":{"id":31437138,"name":"rocket","full_name":"yifan-gu/rocket","owner":{"login":"yifan-gu","id":3278588,"avatar_url":"https://avatars.githubusercontent.com/u/3278588?v=3","gravatar_id":"","url":"https://api.github.com/users/yifan-gu","html_url":"https://github.com/yifan-gu","followers_url":"https://api.github.com/users/yifan-gu/followers","following_url":"https://api.github.com/users/yifan-gu/following{/other_user}","gists_url":"https://api.github.com/users/yifan-gu/gists{/gist_id}","starred_url":"https://api.github.com/users/yifan-gu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yifan-gu/subscriptions","organizations_url":"https://api.github.com/users/yifan-gu/orgs","repos_url":"https://api.github.com/users/yifan-gu/repos","events_url":"https://api.github.com/users/yifan-gu/events{/privacy}","received_events_url":"https://api.github.com/users/yifan-gu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yifan-gu/rocket","description":"App Container runtime","fork":true,"url":"https://api.github.com/repos/yifan-gu/rocket","forks_url":"https://api.github.com/repos/yifan-gu/rocket/forks","keys_url":"https://api.github.com/repos/yifan-gu/rocket/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yifan-gu/rocket/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yifan-gu/rocket/teams","hooks_url":"https://api.github.com/repos/yifan-gu/rocket/hooks","issue_events_url":"https://api.github.com/repos/yifan-gu/rocket/issues/events{/number}","events_url":"https://api.github.com/repos/yifan-gu/rocket/events","assignees_url":"https://api.github.com/repos/yifan-gu/rocket/assignees{/user}","branches_url":"https://api.github.com/repos/yifan-gu/rocket/branches{/branch}","tags_url":"https://api.github.com/repos/yifan-gu/rocket/tags","blobs_url":"https://api.github.com/repos/yifan-gu/rocket/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yifan-gu/rocket/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yifan-gu/rocket/git/refs{/sha}","trees_url":"https://api.github.com/repos/yifan-gu/rocket/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yifan-gu/rocket/statuses/{sha}","languages_url":"https://api.github.com/repos/yifan-gu/rocket/languages","stargazers_url":"https://api.github.com/repos/yifan-gu/rocket/stargazers","contributors_url":"https://api.github.com/repos/yifan-gu/rocket/contributors","subscribers_url":"https://api.github.com/repos/yifan-gu/rocket/subscribers","subscription_url":"https://api.github.com/repos/yifan-gu/rocket/subscription","commits_url":"https://api.github.com/repos/yifan-gu/rocket/commits{/sha}","git_commits_url":"https://api.github.com/repos/yifan-gu/rocket/git/commits{/sha}","comments_url":"https://api.github.com/repos/yifan-gu/rocket/comments{/number}","issue_comment_url":"https://api.github.com/repos/yifan-gu/rocket/issues/comments{/number}","contents_url":"https://api.github.com/repos/yifan-gu/rocket/contents/{+path}","compare_url":"https://api.github.com/repos/yifan-gu/rocket/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yifan-gu/rocket/merges","archive_url":"https://api.github.com/repos/yifan-gu/rocket/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yifan-gu/rocket/downloads","issues_url":"https://api.github.com/repos/yifan-gu/rocket/issues{/number}","pulls_url":"https://api.github.com/repos/yifan-gu/rocket/pulls{/number}","milestones_url":"https://api.github.com/repos/yifan-gu/rocket/milestones{/number}","notifications_url":"https://api.github.com/repos/yifan-gu/rocket/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yifan-gu/rocket/labels{/name}","releases_url":"https://api.github.com/repos/yifan-gu/rocket/releases{/id}","deployments_url":"https://api.github.com/repos/yifan-gu/rocket/deployments","created_at":"2015-02-27T20:12:42Z","updated_at":"2015-04-01T01:18:09Z","pushed_at":"2016-03-28T22:50:36Z","git_url":"git://github.com/yifan-gu/rocket.git","ssh_url":"git@github.com:yifan-gu/rocket.git","clone_url":"https://github.com/yifan-gu/rocket.git","svn_url":"https://github.com/yifan-gu/rocket","homepage":"","size":19413,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"coreos:master","ref":"master","sha":"e56895779706097a5fdfc7099003d105cc325638","user":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"repo":{"id":26509369,"name":"rkt","full_name":"coreos/rkt","owner":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coreos/rkt","description":"rkt is an App Container runtime for Linux","fork":false,"url":"https://api.github.com/repos/coreos/rkt","forks_url":"https://api.github.com/repos/coreos/rkt/forks","keys_url":"https://api.github.com/repos/coreos/rkt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coreos/rkt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coreos/rkt/teams","hooks_url":"https://api.github.com/repos/coreos/rkt/hooks","issue_events_url":"https://api.github.com/repos/coreos/rkt/issues/events{/number}","events_url":"https://api.github.com/repos/coreos/rkt/events","assignees_url":"https://api.github.com/repos/coreos/rkt/assignees{/user}","branches_url":"https://api.github.com/repos/coreos/rkt/branches{/branch}","tags_url":"https://api.github.com/repos/coreos/rkt/tags","blobs_url":"https://api.github.com/repos/coreos/rkt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coreos/rkt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coreos/rkt/git/refs{/sha}","trees_url":"https://api.github.com/repos/coreos/rkt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coreos/rkt/statuses/{sha}","languages_url":"https://api.github.com/repos/coreos/rkt/languages","stargazers_url":"https://api.github.com/repos/coreos/rkt/stargazers","contributors_url":"https://api.github.com/repos/coreos/rkt/contributors","subscribers_url":"https://api.github.com/repos/coreos/rkt/subscribers","subscription_url":"https://api.github.com/repos/coreos/rkt/subscription","commits_url":"https://api.github.com/repos/coreos/rkt/commits{/sha}","git_commits_url":"https://api.github.com/repos/coreos/rkt/git/commits{/sha}","comments_url":"https://api.github.com/repos/coreos/rkt/comments{/number}","issue_comment_url":"https://api.github.com/repos/coreos/rkt/issues/comments{/number}","contents_url":"https://api.github.com/repos/coreos/rkt/contents/{+path}","compare_url":"https://api.github.com/repos/coreos/rkt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coreos/rkt/merges","archive_url":"https://api.github.com/repos/coreos/rkt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coreos/rkt/downloads","issues_url":"https://api.github.com/repos/coreos/rkt/issues{/number}","pulls_url":"https://api.github.com/repos/coreos/rkt/pulls{/number}","milestones_url":"https://api.github.com/repos/coreos/rkt/milestones{/number}","notifications_url":"https://api.github.com/repos/coreos/rkt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coreos/rkt/labels{/name}","releases_url":"https://api.github.com/repos/coreos/rkt/releases{/id}","deployments_url":"https://api.github.com/repos/coreos/rkt/deployments","created_at":"2014-11-11T23:13:18Z","updated_at":"2016-03-29T09:50:38Z","pushed_at":"2016-03-29T12:16:08Z","git_url":"git://github.com/coreos/rkt.git","ssh_url":"git@github.com:coreos/rkt.git","clone_url":"https://github.com/coreos/rkt.git","svn_url":"https://github.com/coreos/rkt","homepage":"","size":25771,"stargazers_count":5354,"watchers_count":5354,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":484,"mirror_url":null,"open_issues_count":267,"forks":484,"open_issues":267,"watchers":5354,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coreos/rkt/pulls/2332"},"html":{"href":"https://github.com/coreos/rkt/pull/2332"},"issue":{"href":"https://api.github.com/repos/coreos/rkt/issues/2332"},"comments":{"href":"https://api.github.com/repos/coreos/rkt/issues/2332/comments"},"review_comments":{"href":"https://api.github.com/repos/coreos/rkt/pulls/2332/comments"},"review_comment":{"href":"https://api.github.com/repos/coreos/rkt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coreos/rkt/pulls/2332/commits"},"statuses":{"href":"https://api.github.com/repos/coreos/rkt/statuses/047fa8de9cb0bc0900154c9a702f8cbeab11c5e2"}}}}