{"action":"created","comment":{"url":"https://api.github.com/repos/vrk-kpa/e-identification-proxy-service/pulls/comments/63828061","id":63828061,"diff_hunk":"@@ -92,30 +92,35 @@ public String getLevelOfAssurance(String relyingParty) {\n         }\n         return null;\n     }\n-    \n-    public AuthMethod getAuthenticationMethodTypeByUrl(String authMethdUrl) {\n-        if ( approvedAuthenticationProviders.getAuthMethodByProvider(authMethdUrl) != null) {\n-            return AuthMethod.valueOf(approvedAuthenticationProviders.getAuthMethodByProvider(authMethdUrl));\n-        } \n+\n+    public AuthMethod getAuthenticationMethodByAuthContextUrl(String authContextUrl) {\n+        if (approvedAuthenticationProviders.getAuthMethodByAuthProviderAuthContextUrl(authContextUrl) != null) {\n+            return AuthMethod.valueOf(approvedAuthenticationProviders.getAuthMethodByAuthProviderAuthContextUrl(authContextUrl));\n+        }\n         return null;\n     }\n-    \n-    public String getAuthenticationProviderFromClassRef(String authMethdUrl) {\n-        if ( approvedAuthenticationProviders.getAuthMethodByProvider(authMethdUrl) != null) {\n-            return approvedAuthenticationProviders.getAuthProviderUrl(authMethdUrl);\n-        } \n-        return null;\n+\n+    public String getAuthProviderEntityIdByAuthContextUrl(String authContextUrl) {\n+        return approvedAuthenticationProviders.getDbEntityIdAuthContextUrlByAuthProviderAuthContextUrl(authContextUrl);\n     }\n-    \n+\n     public String getAuthenticationMethodsByRelyingParty(String relyingParty) {\n         if (serviceProviderMetaDataCache.containsKey(relyingParty)) {\n-            if ( serviceProviderMetaDataCache.get(relyingParty).getAttributeLevelOfAssurance() != null ) {\n+            if (serviceProviderMetaDataCache.get(relyingParty).getAttributeLevelOfAssurance() != null ) {\n                 return serviceProviderMetaDataCache.get(relyingParty).getAttributeLevelOfAssurance();\n-            } \n+            }\n         }\n         return null;\n     }\n-    \n+\n+    public boolean isVtjVerificationRequired(String relyingParty) throws Exception {\n+        if (StringUtils.isNotBlank(relyingParty) && serviceProviderMetaDataCache.containsKey(relyingParty)) {\n+            return serviceProviderMetaDataCache.get(relyingParty).isVtjVerificationRequired();\n+        } else {\n+            logger.error(\"Error finding requested relying party: \" + relyingParty + \" for vtj verification requirement check\");\n+            throw new Exception();","path":"src/main/java/fi/vm/kapa/identification/proxy/service/MetadataService.java","position":65,"original_position":65,"commit_id":"6beb899717bdbc3a5c1e78cdda3893bff3ed8dd0","original_commit_id":"6beb899717bdbc3a5c1e78cdda3893bff3ed8dd0","user":{"login":"jpoikela","id":96626,"avatar_url":"https://avatars.githubusercontent.com/u/96626?v=3","gravatar_id":"","url":"https://api.github.com/users/jpoikela","html_url":"https://github.com/jpoikela","followers_url":"https://api.github.com/users/jpoikela/followers","following_url":"https://api.github.com/users/jpoikela/following{/other_user}","gists_url":"https://api.github.com/users/jpoikela/gists{/gist_id}","starred_url":"https://api.github.com/users/jpoikela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpoikela/subscriptions","organizations_url":"https://api.github.com/users/jpoikela/orgs","repos_url":"https://api.github.com/users/jpoikela/repos","events_url":"https://api.github.com/users/jpoikela/events{/privacy}","received_events_url":"https://api.github.com/users/jpoikela/received_events","type":"User","site_admin":false},"body":"liian geneerinen... edes tuo virhe-teksti mukaan","created_at":"2016-05-19T06:29:39Z","updated_at":"2016-05-19T06:29:39Z","html_url":"https://github.com/vrk-kpa/e-identification-proxy-service/pull/6#discussion_r63828061","pull_request_url":"https://api.github.com/repos/vrk-kpa/e-identification-proxy-service/pulls/6","_links":{"self":{"href":"https://api.github.com/repos/vrk-kpa/e-identification-proxy-service/pulls/comments/63828061"},"html":{"href":"https://github.com/vrk-kpa/e-identification-proxy-service/pull/6#discussion_r63828061"},"pull_request":{"href":"https://api.github.com/repos/vrk-kpa/e-identification-proxy-service/pulls/6"}}},"pull_request":{"url":"https://api.github.com/repos/vrk-kpa/e-identification-proxy-service/pulls/6","id":70508638,"html_url":"https://github.com/vrk-kpa/e-identification-proxy-service/pull/6","diff_url":"https://github.com/vrk-kpa/e-identification-proxy-service/pull/6.diff","patch_url":"https://github.com/vrk-kpa/e-identification-proxy-service/pull/6.patch","issue_url":"https://api.github.com/repos/vrk-kpa/e-identification-proxy-service/issues/6","number":6,"state":"open","locked":false,"title":"Kapa 1119","user":{"login":"oj5","id":3582082,"avatar_url":"https://avatars.githubusercontent.com/u/3582082?v=3","gravatar_id":"","url":"https://api.github.com/users/oj5","html_url":"https://github.com/oj5","followers_url":"https://api.github.com/users/oj5/followers","following_url":"https://api.github.com/users/oj5/following{/other_user}","gists_url":"https://api.github.com/users/oj5/gists{/gist_id}","starred_url":"https://api.github.com/users/oj5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oj5/subscriptions","organizations_url":"https://api.github.com/users/oj5/orgs","repos_url":"https://api.github.com/users/oj5/repos","events_url":"https://api.github.com/users/oj5/events{/privacy}","received_events_url":"https://api.github.com/users/oj5/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-05-18T11:07:59Z","updated_at":"2016-05-19T06:29:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0ac93949e1a4494cbfed56d424842bd398ec933e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/vrk-kpa/e-identification-proxy-service/pulls/6/commits","review_comments_url":"https://api.github.com/repos/vrk-kpa/e-identification-proxy-service/pulls/6/comments","review_comment_url":"https://api.github.com/repos/vrk-kpa/e-identification-proxy-service/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vrk-kpa/e-identification-proxy-service/issues/6/comments","statuses_url":"https://api.github.com/repos/vrk-kpa/e-identification-proxy-service/statuses/6beb899717bdbc3a5c1e78cdda3893bff3ed8dd0","head":{"label":"vrk-kpa:KAPA-1119","ref":"KAPA-1119","sha":"6beb899717bdbc3a5c1e78cdda3893bff3ed8dd0","user":{"login":"vrk-kpa","id":11345641,"avatar_url":"https://avatars.githubusercontent.com/u/11345641?v=3","gravatar_id":"","url":"https://api.github.com/users/vrk-kpa","html_url":"https://github.com/vrk-kpa","followers_url":"https://api.github.com/users/vrk-kpa/followers","following_url":"https://api.github.com/users/vrk-kpa/following{/other_user}","gists_url":"https://api.github.com/users/vrk-kpa/gists{/gist_id}","starred_url":"https://api.github.com/users/vrk-kpa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vrk-kpa/subscriptions","organizations_url":"https://api.github.com/users/vrk-kpa/orgs","repos_url":"https://api.github.com/users/vrk-kpa/repos","events_url":"https://api.github.com/users/vrk-kpa/events{/privacy}","received_events_url":"https://api.github.com/users/vrk-kpa/received_events","type":"Organization","site_admin":false},"repo":{"id":31949315,"name":"e-identification-proxy-service","full_name":"vrk-kpa/e-identification-proxy-service","owner":{"login":"vrk-kpa","id":11345641,"avatar_url":"https://avatars.githubusercontent.com/u/11345641?v=3","gravatar_id":"","url":"https://api.github.com/users/vrk-kpa","html_url":"https://github.com/vrk-kpa","followers_url":"https://api.github.com/users/vrk-kpa/followers","following_url":"https://api.github.com/users/vrk-kpa/following{/other_user}","gists_url":"https://api.github.com/users/vrk-kpa/gists{/gist_id}","starred_url":"https://api.github.com/users/vrk-kpa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vrk-kpa/subscriptions","organizations_url":"https://api.github.com/users/vrk-kpa/orgs","repos_url":"https://api.github.com/users/vrk-kpa/repos","events_url":"https://api.github.com/users/vrk-kpa/events{/privacy}","received_events_url":"https://api.github.com/users/vrk-kpa/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vrk-kpa/e-identification-proxy-service","description":"E-Identification session building backend component","fork":false,"url":"https://api.github.com/repos/vrk-kpa/e-identification-proxy-service","forks_url":"https://api.github.com/repos/vrk-kpa/e-identification-proxy-service/forks","keys_url":"https://api.github.com/repos/vrk-kpa/e-identification-proxy-service/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vrk-kpa/e-identification-proxy-service/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vrk-kpa/e-identification-proxy-service/teams","hooks_url":"https://api.github.com/repos/vrk-kpa/e-identification-proxy-service/hooks","issue_events_url":"https://api.github.com/repos/vrk-kpa/e-identification-proxy-service/issues/events{/number}","events_url":"https://api.github.com/repos/vrk-kpa/e-identification-proxy-service/events","assignees_url":"https://api.github.com/repos/vrk-kpa/e-identification-proxy-service/assignees{/user}","branches_url":"https://api.github.com/repos/vrk-kpa/e-identification-proxy-service/branches{/branch}","tags_url":"https://api.github.com/repos/vrk-kpa/e-identification-proxy-service/tags","blobs_url":"https://api.github.com/repos/vrk-kpa/e-identification-proxy-service/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vrk-kpa/e-identification-proxy-service/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vrk-kpa/e-identification-proxy-service/git/refs{/sha}","trees_url":"https://api.github.com/repos/vrk-kpa/e-identification-proxy-service/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vrk-kpa/e-identification-proxy-service/statuses/{sha}","languages_url":"https://api.github.com/repos/vrk-kpa/e-identification-proxy-service/languages","stargazers_url":"https://api.github.com/repos/vrk-kpa/e-identification-proxy-service/stargazers","contributors_url":"https://api.github.com/repos/vrk-kpa/e-identification-proxy-service/contributors","subscribers_url":"https://api.github.com/repos/vrk-kpa/e-identification-proxy-service/subscribers","subscription_url":"https://api.github.com/repos/vrk-kpa/e-identification-proxy-service/subscription","commits_url":"https://api.github.com/repos/vrk-kpa/e-identification-proxy-service/commits{/sha}","git_commits_url":"https://api.github.com/repos/vrk-kpa/e-identification-proxy-service/git/commits{/sha}","comments_url":"https://api.github.com/repos/vrk-kpa/e-identification-proxy-service/comments{/number}","issue_comment_url":"https://api.github.com/repos/vrk-kpa/e-identification-proxy-service/issues/comments{/number}","contents_url":"https://api.github.com/repos/vrk-kpa/e-identification-proxy-service/contents/{+path}","compare_url":"https://api.github.com/repos/vrk-kpa/e-identification-proxy-service/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vrk-kpa/e-identification-proxy-service/merges","archive_url":"https://api.github.com/repos/vrk-kpa/e-identification-proxy-service/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vrk-kpa/e-identification-proxy-service/downloads","issues_url":"https://api.github.com/repos/vrk-kpa/e-identification-proxy-service/issues{/number}","pulls_url":"https://api.github.com/repos/vrk-kpa/e-identification-proxy-service/pulls{/number}","milestones_url":"https://api.github.com/repos/vrk-kpa/e-identification-proxy-service/milestones{/number}","notifications_url":"https://api.github.com/repos/vrk-kpa/e-identification-proxy-service/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vrk-kpa/e-identification-proxy-service/labels{/name}","releases_url":"https://api.github.com/repos/vrk-kpa/e-identification-proxy-service/releases{/id}","deployments_url":"https://api.github.com/repos/vrk-kpa/e-identification-proxy-service/deployments","created_at":"2015-03-10T09:39:32Z","updated_at":"2016-01-20T12:31:33Z","pushed_at":"2016-05-18T11:08:00Z","git_url":"git://github.com/vrk-kpa/e-identification-proxy-service.git","ssh_url":"git@github.com:vrk-kpa/e-identification-proxy-service.git","clone_url":"https://github.com/vrk-kpa/e-identification-proxy-service.git","svn_url":"https://github.com/vrk-kpa/e-identification-proxy-service","homepage":null,"size":315,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":3,"default_branch":"develop"}},"base":{"label":"vrk-kpa:develop","ref":"develop","sha":"95299c646bc3a09c5525385be3481ae65625c015","user":{"login":"vrk-kpa","id":11345641,"avatar_url":"https://avatars.githubusercontent.com/u/11345641?v=3","gravatar_id":"","url":"https://api.github.com/users/vrk-kpa","html_url":"https://github.com/vrk-kpa","followers_url":"https://api.github.com/users/vrk-kpa/followers","following_url":"https://api.github.com/users/vrk-kpa/following{/other_user}","gists_url":"https://api.github.com/users/vrk-kpa/gists{/gist_id}","starred_url":"https://api.github.com/users/vrk-kpa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vrk-kpa/subscriptions","organizations_url":"https://api.github.com/users/vrk-kpa/orgs","repos_url":"https://api.github.com/users/vrk-kpa/repos","events_url":"https://api.github.com/users/vrk-kpa/events{/privacy}","received_events_url":"https://api.github.com/users/vrk-kpa/received_events","type":"Organization","site_admin":false},"repo":{"id":31949315,"name":"e-identification-proxy-service","full_name":"vrk-kpa/e-identification-proxy-service","owner":{"login":"vrk-kpa","id":11345641,"avatar_url":"https://avatars.githubusercontent.com/u/11345641?v=3","gravatar_id":"","url":"https://api.github.com/users/vrk-kpa","html_url":"https://github.com/vrk-kpa","followers_url":"https://api.github.com/users/vrk-kpa/followers","following_url":"https://api.github.com/users/vrk-kpa/following{/other_user}","gists_url":"https://api.github.com/users/vrk-kpa/gists{/gist_id}","starred_url":"https://api.github.com/users/vrk-kpa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vrk-kpa/subscriptions","organizations_url":"https://api.github.com/users/vrk-kpa/orgs","repos_url":"https://api.github.com/users/vrk-kpa/repos","events_url":"https://api.github.com/users/vrk-kpa/events{/privacy}","received_events_url":"https://api.github.com/users/vrk-kpa/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vrk-kpa/e-identification-proxy-service","description":"E-Identification session building backend component","fork":false,"url":"https://api.github.com/repos/vrk-kpa/e-identification-proxy-service","forks_url":"https://api.github.com/repos/vrk-kpa/e-identification-proxy-service/forks","keys_url":"https://api.github.com/repos/vrk-kpa/e-identification-proxy-service/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vrk-kpa/e-identification-proxy-service/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vrk-kpa/e-identification-proxy-service/teams","hooks_url":"https://api.github.com/repos/vrk-kpa/e-identification-proxy-service/hooks","issue_events_url":"https://api.github.com/repos/vrk-kpa/e-identification-proxy-service/issues/events{/number}","events_url":"https://api.github.com/repos/vrk-kpa/e-identification-proxy-service/events","assignees_url":"https://api.github.com/repos/vrk-kpa/e-identification-proxy-service/assignees{/user}","branches_url":"https://api.github.com/repos/vrk-kpa/e-identification-proxy-service/branches{/branch}","tags_url":"https://api.github.com/repos/vrk-kpa/e-identification-proxy-service/tags","blobs_url":"https://api.github.com/repos/vrk-kpa/e-identification-proxy-service/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vrk-kpa/e-identification-proxy-service/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vrk-kpa/e-identification-proxy-service/git/refs{/sha}","trees_url":"https://api.github.com/repos/vrk-kpa/e-identification-proxy-service/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vrk-kpa/e-identification-proxy-service/statuses/{sha}","languages_url":"https://api.github.com/repos/vrk-kpa/e-identification-proxy-service/languages","stargazers_url":"https://api.github.com/repos/vrk-kpa/e-identification-proxy-service/stargazers","contributors_url":"https://api.github.com/repos/vrk-kpa/e-identification-proxy-service/contributors","subscribers_url":"https://api.github.com/repos/vrk-kpa/e-identification-proxy-service/subscribers","subscription_url":"https://api.github.com/repos/vrk-kpa/e-identification-proxy-service/subscription","commits_url":"https://api.github.com/repos/vrk-kpa/e-identification-proxy-service/commits{/sha}","git_commits_url":"https://api.github.com/repos/vrk-kpa/e-identification-proxy-service/git/commits{/sha}","comments_url":"https://api.github.com/repos/vrk-kpa/e-identification-proxy-service/comments{/number}","issue_comment_url":"https://api.github.com/repos/vrk-kpa/e-identification-proxy-service/issues/comments{/number}","contents_url":"https://api.github.com/repos/vrk-kpa/e-identification-proxy-service/contents/{+path}","compare_url":"https://api.github.com/repos/vrk-kpa/e-identification-proxy-service/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vrk-kpa/e-identification-proxy-service/merges","archive_url":"https://api.github.com/repos/vrk-kpa/e-identification-proxy-service/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vrk-kpa/e-identification-proxy-service/downloads","issues_url":"https://api.github.com/repos/vrk-kpa/e-identification-proxy-service/issues{/number}","pulls_url":"https://api.github.com/repos/vrk-kpa/e-identification-proxy-service/pulls{/number}","milestones_url":"https://api.github.com/repos/vrk-kpa/e-identification-proxy-service/milestones{/number}","notifications_url":"https://api.github.com/repos/vrk-kpa/e-identification-proxy-service/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vrk-kpa/e-identification-proxy-service/labels{/name}","releases_url":"https://api.github.com/repos/vrk-kpa/e-identification-proxy-service/releases{/id}","deployments_url":"https://api.github.com/repos/vrk-kpa/e-identification-proxy-service/deployments","created_at":"2015-03-10T09:39:32Z","updated_at":"2016-01-20T12:31:33Z","pushed_at":"2016-05-18T11:08:00Z","git_url":"git://github.com/vrk-kpa/e-identification-proxy-service.git","ssh_url":"git@github.com:vrk-kpa/e-identification-proxy-service.git","clone_url":"https://github.com/vrk-kpa/e-identification-proxy-service.git","svn_url":"https://github.com/vrk-kpa/e-identification-proxy-service","homepage":null,"size":315,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":3,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/vrk-kpa/e-identification-proxy-service/pulls/6"},"html":{"href":"https://github.com/vrk-kpa/e-identification-proxy-service/pull/6"},"issue":{"href":"https://api.github.com/repos/vrk-kpa/e-identification-proxy-service/issues/6"},"comments":{"href":"https://api.github.com/repos/vrk-kpa/e-identification-proxy-service/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/vrk-kpa/e-identification-proxy-service/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/vrk-kpa/e-identification-proxy-service/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vrk-kpa/e-identification-proxy-service/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/vrk-kpa/e-identification-proxy-service/statuses/6beb899717bdbc3a5c1e78cdda3893bff3ed8dd0"}}}}