{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/comments/78816626","id":78816626,"diff_hunk":"@@ -8310,6 +8327,16 @@ namespace Js\n             return false;\n         }\n \n+     \tbool evictCachedType = true;\n+        if (DynamicType::Is(type->GetTypeId()))\n+        {\n+            DynamicType* dynamicType = static_cast<DynamicType*>(type);\n+            if ((dynamicType->GetTypeHandler()->IsSimpleDictionaryTypeHandler() || dynamicType->GetTypeHandler()->IsDictionaryTypeHandler()) &&","path":"lib/Runtime/Language/JavascriptOperators.cpp","position":56,"original_position":56,"commit_id":"bcc0eea8486c1d93f26a2984a26ec70c818b2139","original_commit_id":"bcc0eea8486c1d93f26a2984a26ec70c818b2139","user":{"login":"rajatd","id":15348123,"avatar_url":"https://avatars.githubusercontent.com/u/15348123?v=3","gravatar_id":"","url":"https://api.github.com/users/rajatd","html_url":"https://github.com/rajatd","followers_url":"https://api.github.com/users/rajatd/followers","following_url":"https://api.github.com/users/rajatd/following{/other_user}","gists_url":"https://api.github.com/users/rajatd/gists{/gist_id}","starred_url":"https://api.github.com/users/rajatd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rajatd/subscriptions","organizations_url":"https://api.github.com/users/rajatd/orgs","repos_url":"https://api.github.com/users/rajatd/repos","events_url":"https://api.github.com/users/rajatd/events{/privacy}","received_events_url":"https://api.github.com/users/rajatd/received_events","type":"User","site_admin":false},"body":"Because a type with a path type handler may start off as non-shared but is definitely shareable. Didn't want to evict such types\r\n\r\n---\r\nIn reply to: [78785136](https://github.com/Microsoft/ChakraCore/pull/1542#discussion_r78785136) [](ancestors = 78785136)","created_at":"2016-09-14T19:09:59Z","updated_at":"2016-09-14T19:09:59Z","html_url":"https://github.com/Microsoft/ChakraCore/pull/1542#discussion_r78816626","pull_request_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/1542","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/comments/78816626"},"html":{"href":"https://github.com/Microsoft/ChakraCore/pull/1542#discussion_r78816626"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/1542"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/1542","id":84167629,"html_url":"https://github.com/Microsoft/ChakraCore/pull/1542","diff_url":"https://github.com/Microsoft/ChakraCore/pull/1542.diff","patch_url":"https://github.com/Microsoft/ChakraCore/pull/1542.patch","issue_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/1542","number":1542,"state":"open","locked":false,"title":"Delete property optimizations","user":{"login":"rajatd","id":15348123,"avatar_url":"https://avatars.githubusercontent.com/u/15348123?v=3","gravatar_id":"","url":"https://api.github.com/users/rajatd","html_url":"https://github.com/rajatd","followers_url":"https://api.github.com/users/rajatd/followers","following_url":"https://api.github.com/users/rajatd/following{/other_user}","gists_url":"https://api.github.com/users/rajatd/gists{/gist_id}","starred_url":"https://api.github.com/users/rajatd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rajatd/subscriptions","organizations_url":"https://api.github.com/users/rajatd/orgs","repos_url":"https://api.github.com/users/rajatd/repos","events_url":"https://api.github.com/users/rajatd/events{/privacy}","received_events_url":"https://api.github.com/users/rajatd/received_events","type":"User","site_admin":false},"body":"A couple of optimizations for deleting a property on an object.\r\n\r\n1. When we delete a property, we change the type of the object to invalidate any caches which may have cached its type. We don't have to change the type if it wasn't cached anywhere.\r\n\r\n2. For objects that have SimpleDictionary or Dictionary Type Handlers, we have the capability of looking up a property descriptor from the property name itself. However, currently we first lookup the property record for the property in the property map and use the record to look up the descriptor. Getting rid of the intermediate step of property record lookup if we have the property name (delete obj[prop])","created_at":"2016-09-06T17:58:25Z","updated_at":"2016-09-14T19:09:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ec4b8b62d6a132b97cdae8a1f25bc2ff7fe314b6","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/1542/commits","review_comments_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/1542/comments","review_comment_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/1542/comments","statuses_url":"https://api.github.com/repos/Microsoft/ChakraCore/statuses/bcc0eea8486c1d93f26a2984a26ec70c818b2139","head":{"label":"rajatd:deleteProp","ref":"deleteProp","sha":"bcc0eea8486c1d93f26a2984a26ec70c818b2139","user":{"login":"rajatd","id":15348123,"avatar_url":"https://avatars.githubusercontent.com/u/15348123?v=3","gravatar_id":"","url":"https://api.github.com/users/rajatd","html_url":"https://github.com/rajatd","followers_url":"https://api.github.com/users/rajatd/followers","following_url":"https://api.github.com/users/rajatd/following{/other_user}","gists_url":"https://api.github.com/users/rajatd/gists{/gist_id}","starred_url":"https://api.github.com/users/rajatd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rajatd/subscriptions","organizations_url":"https://api.github.com/users/rajatd/orgs","repos_url":"https://api.github.com/users/rajatd/repos","events_url":"https://api.github.com/users/rajatd/events{/privacy}","received_events_url":"https://api.github.com/users/rajatd/received_events","type":"User","site_admin":false},"repo":{"id":49607902,"name":"ChakraCore","full_name":"rajatd/ChakraCore","owner":{"login":"rajatd","id":15348123,"avatar_url":"https://avatars.githubusercontent.com/u/15348123?v=3","gravatar_id":"","url":"https://api.github.com/users/rajatd","html_url":"https://github.com/rajatd","followers_url":"https://api.github.com/users/rajatd/followers","following_url":"https://api.github.com/users/rajatd/following{/other_user}","gists_url":"https://api.github.com/users/rajatd/gists{/gist_id}","starred_url":"https://api.github.com/users/rajatd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rajatd/subscriptions","organizations_url":"https://api.github.com/users/rajatd/orgs","repos_url":"https://api.github.com/users/rajatd/repos","events_url":"https://api.github.com/users/rajatd/events{/privacy}","received_events_url":"https://api.github.com/users/rajatd/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rajatd/ChakraCore","description":"ChakraCore is the core part of the Chakra Javascript engine that powers Microsoft Edge","fork":true,"url":"https://api.github.com/repos/rajatd/ChakraCore","forks_url":"https://api.github.com/repos/rajatd/ChakraCore/forks","keys_url":"https://api.github.com/repos/rajatd/ChakraCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rajatd/ChakraCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rajatd/ChakraCore/teams","hooks_url":"https://api.github.com/repos/rajatd/ChakraCore/hooks","issue_events_url":"https://api.github.com/repos/rajatd/ChakraCore/issues/events{/number}","events_url":"https://api.github.com/repos/rajatd/ChakraCore/events","assignees_url":"https://api.github.com/repos/rajatd/ChakraCore/assignees{/user}","branches_url":"https://api.github.com/repos/rajatd/ChakraCore/branches{/branch}","tags_url":"https://api.github.com/repos/rajatd/ChakraCore/tags","blobs_url":"https://api.github.com/repos/rajatd/ChakraCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rajatd/ChakraCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rajatd/ChakraCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/rajatd/ChakraCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rajatd/ChakraCore/statuses/{sha}","languages_url":"https://api.github.com/repos/rajatd/ChakraCore/languages","stargazers_url":"https://api.github.com/repos/rajatd/ChakraCore/stargazers","contributors_url":"https://api.github.com/repos/rajatd/ChakraCore/contributors","subscribers_url":"https://api.github.com/repos/rajatd/ChakraCore/subscribers","subscription_url":"https://api.github.com/repos/rajatd/ChakraCore/subscription","commits_url":"https://api.github.com/repos/rajatd/ChakraCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/rajatd/ChakraCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/rajatd/ChakraCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/rajatd/ChakraCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/rajatd/ChakraCore/contents/{+path}","compare_url":"https://api.github.com/repos/rajatd/ChakraCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rajatd/ChakraCore/merges","archive_url":"https://api.github.com/repos/rajatd/ChakraCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rajatd/ChakraCore/downloads","issues_url":"https://api.github.com/repos/rajatd/ChakraCore/issues{/number}","pulls_url":"https://api.github.com/repos/rajatd/ChakraCore/pulls{/number}","milestones_url":"https://api.github.com/repos/rajatd/ChakraCore/milestones{/number}","notifications_url":"https://api.github.com/repos/rajatd/ChakraCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rajatd/ChakraCore/labels{/name}","releases_url":"https://api.github.com/repos/rajatd/ChakraCore/releases{/id}","deployments_url":"https://api.github.com/repos/rajatd/ChakraCore/deployments","created_at":"2016-01-13T23:02:12Z","updated_at":"2016-01-13T23:02:28Z","pushed_at":"2016-09-14T18:26:27Z","git_url":"git://github.com/rajatd/ChakraCore.git","ssh_url":"git@github.com:rajatd/ChakraCore.git","clone_url":"https://github.com/rajatd/ChakraCore.git","svn_url":"https://github.com/rajatd/ChakraCore","homepage":null,"size":35551,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"1f1164cd1bd38f91c2c42b1d10e16f8b9aa6a5b4","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":49086513,"name":"ChakraCore","full_name":"Microsoft/ChakraCore","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/ChakraCore","description":"ChakraCore is the core part of the Chakra Javascript engine that powers Microsoft Edge","fork":false,"url":"https://api.github.com/repos/Microsoft/ChakraCore","forks_url":"https://api.github.com/repos/Microsoft/ChakraCore/forks","keys_url":"https://api.github.com/repos/Microsoft/ChakraCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/ChakraCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/ChakraCore/teams","hooks_url":"https://api.github.com/repos/Microsoft/ChakraCore/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/ChakraCore/events","assignees_url":"https://api.github.com/repos/Microsoft/ChakraCore/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/ChakraCore/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/ChakraCore/tags","blobs_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/ChakraCore/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/ChakraCore/languages","stargazers_url":"https://api.github.com/repos/Microsoft/ChakraCore/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/ChakraCore/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/ChakraCore/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/ChakraCore/subscription","commits_url":"https://api.github.com/repos/Microsoft/ChakraCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/ChakraCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/ChakraCore/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/ChakraCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/ChakraCore/merges","archive_url":"https://api.github.com/repos/Microsoft/ChakraCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/ChakraCore/downloads","issues_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/ChakraCore/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/ChakraCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/ChakraCore/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/ChakraCore/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/ChakraCore/deployments","created_at":"2016-01-05T19:05:31Z","updated_at":"2016-09-14T18:11:32Z","pushed_at":"2016-09-14T18:26:28Z","git_url":"git://github.com/Microsoft/ChakraCore.git","ssh_url":"git@github.com:Microsoft/ChakraCore.git","clone_url":"https://github.com/Microsoft/ChakraCore.git","svn_url":"https://github.com/Microsoft/ChakraCore","homepage":null,"size":51212,"stargazers_count":5637,"watchers_count":5637,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":621,"mirror_url":null,"open_issues_count":159,"forks":621,"open_issues":159,"watchers":5637,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/1542"},"html":{"href":"https://github.com/Microsoft/ChakraCore/pull/1542"},"issue":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/issues/1542"},"comments":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/issues/1542/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/1542/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/1542/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/statuses/bcc0eea8486c1d93f26a2984a26ec70c818b2139"}}}}
{"actor":{"display_login":"rajatd"}}