{"action":"created","comment":{"url":"https://api.github.com/repos/projecthydra/curation_concerns/pulls/comments/64460311","id":64460311,"diff_hunk":"@@ -101,8 +101,11 @@ def resource_types_config\n       copy_file \"config/authorities/resource_types.yml\", \"config/authorities/resource_types.yml\"\n     end\n \n-    def simple_form_bootstrap\n-      generate 'simple_form:install --bootstrap'","path":"lib/generators/curation_concerns/install_generator.rb","position":14,"original_position":14,"commit_id":"bc894a73e24353e2e8fab843261995f0d1a15035","original_commit_id":"bc894a73e24353e2e8fab843261995f0d1a15035","user":{"login":"justcolin","id":11234702,"avatar_url":"https://avatars.githubusercontent.com/u/11234702?v=3","gravatar_id":"","url":"https://api.github.com/users/justcolin","html_url":"https://github.com/justcolin","followers_url":"https://api.github.com/users/justcolin/followers","following_url":"https://api.github.com/users/justcolin/following{/other_user}","gists_url":"https://api.github.com/users/justcolin/gists{/gist_id}","starred_url":"https://api.github.com/users/justcolin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justcolin/subscriptions","organizations_url":"https://api.github.com/users/justcolin/orgs","repos_url":"https://api.github.com/users/justcolin/repos","events_url":"https://api.github.com/users/justcolin/events{/privacy}","received_events_url":"https://api.github.com/users/justcolin/received_events","type":"User","site_admin":false},"body":"I am okay with either option. @jcoyne asked me to remove this line, so what is the majority opinion? @mjgiarlo, @cam156, etc?","created_at":"2016-05-24T19:40:58Z","updated_at":"2016-05-24T19:40:58Z","html_url":"https://github.com/projecthydra/curation_concerns/pull/811#discussion_r64460311","pull_request_url":"https://api.github.com/repos/projecthydra/curation_concerns/pulls/811","_links":{"self":{"href":"https://api.github.com/repos/projecthydra/curation_concerns/pulls/comments/64460311"},"html":{"href":"https://github.com/projecthydra/curation_concerns/pull/811#discussion_r64460311"},"pull_request":{"href":"https://api.github.com/repos/projecthydra/curation_concerns/pulls/811"}}},"pull_request":{"url":"https://api.github.com/repos/projecthydra/curation_concerns/pulls/811","id":71082168,"html_url":"https://github.com/projecthydra/curation_concerns/pull/811","diff_url":"https://github.com/projecthydra/curation_concerns/pull/811.diff","patch_url":"https://github.com/projecthydra/curation_concerns/pull/811.patch","issue_url":"https://api.github.com/repos/projecthydra/curation_concerns/issues/811","number":811,"state":"open","locked":false,"title":"Change help text to always be visible","user":{"login":"justcolin","id":11234702,"avatar_url":"https://avatars.githubusercontent.com/u/11234702?v=3","gravatar_id":"","url":"https://api.github.com/users/justcolin","html_url":"https://github.com/justcolin","followers_url":"https://api.github.com/users/justcolin/followers","following_url":"https://api.github.com/users/justcolin/following{/other_user}","gists_url":"https://api.github.com/users/justcolin/gists{/gist_id}","starred_url":"https://api.github.com/users/justcolin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justcolin/subscriptions","organizations_url":"https://api.github.com/users/justcolin/orgs","repos_url":"https://api.github.com/users/justcolin/repos","events_url":"https://api.github.com/users/justcolin/events{/privacy}","received_events_url":"https://api.github.com/users/justcolin/received_events","type":"User","site_admin":false},"body":"Partially fixes #777, related to projecthydra/sufia#2003\r\n\r\nHelp text is now directly rendered to the page instead of being hidden behind a button/pop-up. This gets rid of a number of accessibility problems and simplifies the UI code.\r\n\r\nThe implementation ended up just involving the removal the custom code that was rendering the help buttons. After that, `simple_form`'s default rendering took over. The only problem was that the help text was being rendered after the input field, so a generator has been added to overwrite the default `simple_form` config files. All that this overwrite does is create identical initializers to what `simple_form` generates except the order of a couple of elements is flipped around. By just using the `simple_form` initializers users who want to customize things can use the `simple_form` DSL to make changes instead of overriding CC code.\r\n\r\nThe Visibility field will need to be cleaned up a bit now that all of that text is visible, but I have another pull request to take care of that. There is also probably some more code that can be removed, and I am investigating that now. I also have an upcoming pull request for Sufia which will help this CC change work better in Sufia.\r\n\r\nChanges proposed in this pull request:\r\n* Delete custom help button generation code\r\n* Add generator to create config files to make sure the help text is rendered how we want it and that it is easy to overwrite\r\n* Remove old tests related to help button (no tests are needed for the new code since that would just be testing that `simple_form` works)\r\n\r\n@projecthydra/sufia-code-reviewers","created_at":"2016-05-23T16:47:16Z","updated_at":"2016-05-24T19:40:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eb54216aa64753c43860093a49d2a092d8a5dd6b","assignee":{"login":"justcolin","id":11234702,"avatar_url":"https://avatars.githubusercontent.com/u/11234702?v=3","gravatar_id":"","url":"https://api.github.com/users/justcolin","html_url":"https://github.com/justcolin","followers_url":"https://api.github.com/users/justcolin/followers","following_url":"https://api.github.com/users/justcolin/following{/other_user}","gists_url":"https://api.github.com/users/justcolin/gists{/gist_id}","starred_url":"https://api.github.com/users/justcolin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justcolin/subscriptions","organizations_url":"https://api.github.com/users/justcolin/orgs","repos_url":"https://api.github.com/users/justcolin/repos","events_url":"https://api.github.com/users/justcolin/events{/privacy}","received_events_url":"https://api.github.com/users/justcolin/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/projecthydra/curation_concerns/milestones/4","html_url":"https://github.com/projecthydra/curation_concerns/milestones/v1.0.0","labels_url":"https://api.github.com/repos/projecthydra/curation_concerns/milestones/4/labels","id":1764989,"number":4,"title":"v1.0.0","description":"","creator":{"login":"jcoyne","id":92044,"avatar_url":"https://avatars.githubusercontent.com/u/92044?v=3","gravatar_id":"","url":"https://api.github.com/users/jcoyne","html_url":"https://github.com/jcoyne","followers_url":"https://api.github.com/users/jcoyne/followers","following_url":"https://api.github.com/users/jcoyne/following{/other_user}","gists_url":"https://api.github.com/users/jcoyne/gists{/gist_id}","starred_url":"https://api.github.com/users/jcoyne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcoyne/subscriptions","organizations_url":"https://api.github.com/users/jcoyne/orgs","repos_url":"https://api.github.com/users/jcoyne/repos","events_url":"https://api.github.com/users/jcoyne/events{/privacy}","received_events_url":"https://api.github.com/users/jcoyne/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":8,"state":"open","created_at":"2016-05-13T15:21:50Z","updated_at":"2016-05-24T03:03:01Z","due_on":"2016-05-31T05:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/projecthydra/curation_concerns/pulls/811/commits","review_comments_url":"https://api.github.com/repos/projecthydra/curation_concerns/pulls/811/comments","review_comment_url":"https://api.github.com/repos/projecthydra/curation_concerns/pulls/comments{/number}","comments_url":"https://api.github.com/repos/projecthydra/curation_concerns/issues/811/comments","statuses_url":"https://api.github.com/repos/projecthydra/curation_concerns/statuses/bc894a73e24353e2e8fab843261995f0d1a15035","head":{"label":"projecthydra:improved_help_text","ref":"improved_help_text","sha":"bc894a73e24353e2e8fab843261995f0d1a15035","user":{"login":"projecthydra","id":109426,"avatar_url":"https://avatars.githubusercontent.com/u/109426?v=3","gravatar_id":"","url":"https://api.github.com/users/projecthydra","html_url":"https://github.com/projecthydra","followers_url":"https://api.github.com/users/projecthydra/followers","following_url":"https://api.github.com/users/projecthydra/following{/other_user}","gists_url":"https://api.github.com/users/projecthydra/gists{/gist_id}","starred_url":"https://api.github.com/users/projecthydra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projecthydra/subscriptions","organizations_url":"https://api.github.com/users/projecthydra/orgs","repos_url":"https://api.github.com/users/projecthydra/repos","events_url":"https://api.github.com/users/projecthydra/events{/privacy}","received_events_url":"https://api.github.com/users/projecthydra/received_events","type":"Organization","site_admin":false},"repo":{"id":35563024,"name":"curation_concerns","full_name":"projecthydra/curation_concerns","owner":{"login":"projecthydra","id":109426,"avatar_url":"https://avatars.githubusercontent.com/u/109426?v=3","gravatar_id":"","url":"https://api.github.com/users/projecthydra","html_url":"https://github.com/projecthydra","followers_url":"https://api.github.com/users/projecthydra/followers","following_url":"https://api.github.com/users/projecthydra/following{/other_user}","gists_url":"https://api.github.com/users/projecthydra/gists{/gist_id}","starred_url":"https://api.github.com/users/projecthydra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projecthydra/subscriptions","organizations_url":"https://api.github.com/users/projecthydra/orgs","repos_url":"https://api.github.com/users/projecthydra/repos","events_url":"https://api.github.com/users/projecthydra/events{/privacy}","received_events_url":"https://api.github.com/users/projecthydra/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/projecthydra/curation_concerns","description":"A Hydra-based Rails Engine that extends an application, adding the ability to Create, Read, Update and Destroy (CRUD) objects (based on Hydra::Works) and providing a generator for defining object types with custom workflows, views, access controls, etc.","fork":false,"url":"https://api.github.com/repos/projecthydra/curation_concerns","forks_url":"https://api.github.com/repos/projecthydra/curation_concerns/forks","keys_url":"https://api.github.com/repos/projecthydra/curation_concerns/keys{/key_id}","collaborators_url":"https://api.github.com/repos/projecthydra/curation_concerns/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/projecthydra/curation_concerns/teams","hooks_url":"https://api.github.com/repos/projecthydra/curation_concerns/hooks","issue_events_url":"https://api.github.com/repos/projecthydra/curation_concerns/issues/events{/number}","events_url":"https://api.github.com/repos/projecthydra/curation_concerns/events","assignees_url":"https://api.github.com/repos/projecthydra/curation_concerns/assignees{/user}","branches_url":"https://api.github.com/repos/projecthydra/curation_concerns/branches{/branch}","tags_url":"https://api.github.com/repos/projecthydra/curation_concerns/tags","blobs_url":"https://api.github.com/repos/projecthydra/curation_concerns/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/projecthydra/curation_concerns/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/projecthydra/curation_concerns/git/refs{/sha}","trees_url":"https://api.github.com/repos/projecthydra/curation_concerns/git/trees{/sha}","statuses_url":"https://api.github.com/repos/projecthydra/curation_concerns/statuses/{sha}","languages_url":"https://api.github.com/repos/projecthydra/curation_concerns/languages","stargazers_url":"https://api.github.com/repos/projecthydra/curation_concerns/stargazers","contributors_url":"https://api.github.com/repos/projecthydra/curation_concerns/contributors","subscribers_url":"https://api.github.com/repos/projecthydra/curation_concerns/subscribers","subscription_url":"https://api.github.com/repos/projecthydra/curation_concerns/subscription","commits_url":"https://api.github.com/repos/projecthydra/curation_concerns/commits{/sha}","git_commits_url":"https://api.github.com/repos/projecthydra/curation_concerns/git/commits{/sha}","comments_url":"https://api.github.com/repos/projecthydra/curation_concerns/comments{/number}","issue_comment_url":"https://api.github.com/repos/projecthydra/curation_concerns/issues/comments{/number}","contents_url":"https://api.github.com/repos/projecthydra/curation_concerns/contents/{+path}","compare_url":"https://api.github.com/repos/projecthydra/curation_concerns/compare/{base}...{head}","merges_url":"https://api.github.com/repos/projecthydra/curation_concerns/merges","archive_url":"https://api.github.com/repos/projecthydra/curation_concerns/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/projecthydra/curation_concerns/downloads","issues_url":"https://api.github.com/repos/projecthydra/curation_concerns/issues{/number}","pulls_url":"https://api.github.com/repos/projecthydra/curation_concerns/pulls{/number}","milestones_url":"https://api.github.com/repos/projecthydra/curation_concerns/milestones{/number}","notifications_url":"https://api.github.com/repos/projecthydra/curation_concerns/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/projecthydra/curation_concerns/labels{/name}","releases_url":"https://api.github.com/repos/projecthydra/curation_concerns/releases{/id}","deployments_url":"https://api.github.com/repos/projecthydra/curation_concerns/deployments","created_at":"2015-05-13T17:17:45Z","updated_at":"2016-05-18T18:17:01Z","pushed_at":"2016-05-24T19:02:11Z","git_url":"git://github.com/projecthydra/curation_concerns.git","ssh_url":"git@github.com:projecthydra/curation_concerns.git","clone_url":"https://github.com/projecthydra/curation_concerns.git","svn_url":"https://github.com/projecthydra/curation_concerns","homepage":"","size":4128,"stargazers_count":8,"watchers_count":8,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":42,"forks":15,"open_issues":42,"watchers":8,"default_branch":"master"}},"base":{"label":"projecthydra:master","ref":"master","sha":"45b72d3ec254cc911e81e886d84b2f66f0217130","user":{"login":"projecthydra","id":109426,"avatar_url":"https://avatars.githubusercontent.com/u/109426?v=3","gravatar_id":"","url":"https://api.github.com/users/projecthydra","html_url":"https://github.com/projecthydra","followers_url":"https://api.github.com/users/projecthydra/followers","following_url":"https://api.github.com/users/projecthydra/following{/other_user}","gists_url":"https://api.github.com/users/projecthydra/gists{/gist_id}","starred_url":"https://api.github.com/users/projecthydra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projecthydra/subscriptions","organizations_url":"https://api.github.com/users/projecthydra/orgs","repos_url":"https://api.github.com/users/projecthydra/repos","events_url":"https://api.github.com/users/projecthydra/events{/privacy}","received_events_url":"https://api.github.com/users/projecthydra/received_events","type":"Organization","site_admin":false},"repo":{"id":35563024,"name":"curation_concerns","full_name":"projecthydra/curation_concerns","owner":{"login":"projecthydra","id":109426,"avatar_url":"https://avatars.githubusercontent.com/u/109426?v=3","gravatar_id":"","url":"https://api.github.com/users/projecthydra","html_url":"https://github.com/projecthydra","followers_url":"https://api.github.com/users/projecthydra/followers","following_url":"https://api.github.com/users/projecthydra/following{/other_user}","gists_url":"https://api.github.com/users/projecthydra/gists{/gist_id}","starred_url":"https://api.github.com/users/projecthydra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projecthydra/subscriptions","organizations_url":"https://api.github.com/users/projecthydra/orgs","repos_url":"https://api.github.com/users/projecthydra/repos","events_url":"https://api.github.com/users/projecthydra/events{/privacy}","received_events_url":"https://api.github.com/users/projecthydra/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/projecthydra/curation_concerns","description":"A Hydra-based Rails Engine that extends an application, adding the ability to Create, Read, Update and Destroy (CRUD) objects (based on Hydra::Works) and providing a generator for defining object types with custom workflows, views, access controls, etc.","fork":false,"url":"https://api.github.com/repos/projecthydra/curation_concerns","forks_url":"https://api.github.com/repos/projecthydra/curation_concerns/forks","keys_url":"https://api.github.com/repos/projecthydra/curation_concerns/keys{/key_id}","collaborators_url":"https://api.github.com/repos/projecthydra/curation_concerns/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/projecthydra/curation_concerns/teams","hooks_url":"https://api.github.com/repos/projecthydra/curation_concerns/hooks","issue_events_url":"https://api.github.com/repos/projecthydra/curation_concerns/issues/events{/number}","events_url":"https://api.github.com/repos/projecthydra/curation_concerns/events","assignees_url":"https://api.github.com/repos/projecthydra/curation_concerns/assignees{/user}","branches_url":"https://api.github.com/repos/projecthydra/curation_concerns/branches{/branch}","tags_url":"https://api.github.com/repos/projecthydra/curation_concerns/tags","blobs_url":"https://api.github.com/repos/projecthydra/curation_concerns/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/projecthydra/curation_concerns/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/projecthydra/curation_concerns/git/refs{/sha}","trees_url":"https://api.github.com/repos/projecthydra/curation_concerns/git/trees{/sha}","statuses_url":"https://api.github.com/repos/projecthydra/curation_concerns/statuses/{sha}","languages_url":"https://api.github.com/repos/projecthydra/curation_concerns/languages","stargazers_url":"https://api.github.com/repos/projecthydra/curation_concerns/stargazers","contributors_url":"https://api.github.com/repos/projecthydra/curation_concerns/contributors","subscribers_url":"https://api.github.com/repos/projecthydra/curation_concerns/subscribers","subscription_url":"https://api.github.com/repos/projecthydra/curation_concerns/subscription","commits_url":"https://api.github.com/repos/projecthydra/curation_concerns/commits{/sha}","git_commits_url":"https://api.github.com/repos/projecthydra/curation_concerns/git/commits{/sha}","comments_url":"https://api.github.com/repos/projecthydra/curation_concerns/comments{/number}","issue_comment_url":"https://api.github.com/repos/projecthydra/curation_concerns/issues/comments{/number}","contents_url":"https://api.github.com/repos/projecthydra/curation_concerns/contents/{+path}","compare_url":"https://api.github.com/repos/projecthydra/curation_concerns/compare/{base}...{head}","merges_url":"https://api.github.com/repos/projecthydra/curation_concerns/merges","archive_url":"https://api.github.com/repos/projecthydra/curation_concerns/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/projecthydra/curation_concerns/downloads","issues_url":"https://api.github.com/repos/projecthydra/curation_concerns/issues{/number}","pulls_url":"https://api.github.com/repos/projecthydra/curation_concerns/pulls{/number}","milestones_url":"https://api.github.com/repos/projecthydra/curation_concerns/milestones{/number}","notifications_url":"https://api.github.com/repos/projecthydra/curation_concerns/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/projecthydra/curation_concerns/labels{/name}","releases_url":"https://api.github.com/repos/projecthydra/curation_concerns/releases{/id}","deployments_url":"https://api.github.com/repos/projecthydra/curation_concerns/deployments","created_at":"2015-05-13T17:17:45Z","updated_at":"2016-05-18T18:17:01Z","pushed_at":"2016-05-24T19:02:11Z","git_url":"git://github.com/projecthydra/curation_concerns.git","ssh_url":"git@github.com:projecthydra/curation_concerns.git","clone_url":"https://github.com/projecthydra/curation_concerns.git","svn_url":"https://github.com/projecthydra/curation_concerns","homepage":"","size":4128,"stargazers_count":8,"watchers_count":8,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":42,"forks":15,"open_issues":42,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/projecthydra/curation_concerns/pulls/811"},"html":{"href":"https://github.com/projecthydra/curation_concerns/pull/811"},"issue":{"href":"https://api.github.com/repos/projecthydra/curation_concerns/issues/811"},"comments":{"href":"https://api.github.com/repos/projecthydra/curation_concerns/issues/811/comments"},"review_comments":{"href":"https://api.github.com/repos/projecthydra/curation_concerns/pulls/811/comments"},"review_comment":{"href":"https://api.github.com/repos/projecthydra/curation_concerns/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/projecthydra/curation_concerns/pulls/811/commits"},"statuses":{"href":"https://api.github.com/repos/projecthydra/curation_concerns/statuses/bc894a73e24353e2e8fab843261995f0d1a15035"}}}}
{"actor":{"display_login":"justcolin"}}