{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/35144","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/35144/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/35144/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/35144/events","html_url":"https://github.com/kubernetes/kubernetes/pull/35144","id":184030079,"number":35144,"title":"New command: \"kubeadm generate-token\"","user":{"login":"pipejakob","id":1605981,"avatar_url":"https://avatars.githubusercontent.com/u/1605981?v=3","gravatar_id":"","url":"https://api.github.com/users/pipejakob","html_url":"https://github.com/pipejakob","followers_url":"https://api.github.com/users/pipejakob/followers","following_url":"https://api.github.com/users/pipejakob/following{/other_user}","gists_url":"https://api.github.com/users/pipejakob/gists{/gist_id}","starred_url":"https://api.github.com/users/pipejakob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pipejakob/subscriptions","organizations_url":"https://api.github.com/users/pipejakob/orgs","repos_url":"https://api.github.com/users/pipejakob/repos","events_url":"https://api.github.com/users/pipejakob/events{/privacy}","received_events_url":"https://api.github.com/users/pipejakob/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cla:%20yes","name":"cla: yes","color":"bfe5bf"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-label-needed","name":"release-note-label-needed","color":"db5a64"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/M","name":"size/M","color":"eebb00"}],"state":"open","locked":false,"assignee":{"login":"luxas","id":5442475,"avatar_url":"https://avatars.githubusercontent.com/u/5442475?v=3","gravatar_id":"","url":"https://api.github.com/users/luxas","html_url":"https://github.com/luxas","followers_url":"https://api.github.com/users/luxas/followers","following_url":"https://api.github.com/users/luxas/following{/other_user}","gists_url":"https://api.github.com/users/luxas/gists{/gist_id}","starred_url":"https://api.github.com/users/luxas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luxas/subscriptions","organizations_url":"https://api.github.com/users/luxas/orgs","repos_url":"https://api.github.com/users/luxas/repos","events_url":"https://api.github.com/users/luxas/events{/privacy}","received_events_url":"https://api.github.com/users/luxas/received_events","type":"User","site_admin":false},"assignees":[{"login":"luxas","id":5442475,"avatar_url":"https://avatars.githubusercontent.com/u/5442475?v=3","gravatar_id":"","url":"https://api.github.com/users/luxas","html_url":"https://github.com/luxas","followers_url":"https://api.github.com/users/luxas/followers","following_url":"https://api.github.com/users/luxas/following{/other_user}","gists_url":"https://api.github.com/users/luxas/gists{/gist_id}","starred_url":"https://api.github.com/users/luxas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luxas/subscriptions","organizations_url":"https://api.github.com/users/luxas/orgs","repos_url":"https://api.github.com/users/luxas/repos","events_url":"https://api.github.com/users/luxas/events{/privacy}","received_events_url":"https://api.github.com/users/luxas/received_events","type":"User","site_admin":false}],"milestone":null,"comments":4,"created_at":"2016-10-19T17:49:13Z","updated_at":"2016-10-19T18:22:42Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/35144","html_url":"https://github.com/kubernetes/kubernetes/pull/35144","diff_url":"https://github.com/kubernetes/kubernetes/pull/35144.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/35144.patch"},"body":"As part of #33930, this PR adds a new top-level command to kubeadm to just generate a token for use with the init/join commands. Otherwise, users are left to either figure out how to generate a token on their own, or let `kubeadm init` generate a token, capture and parse the output, and then use that token for `kubeadm join`.\r\n\r\nAt this point, I was hoping for feedback on the CLI experience, and then I can add tests. I spoke with @mikedanese and he didn't like the original propose of `kubeadm util generate-token`, so here are the runners up:\r\n\r\n    $ kubeadm generate-token          # <--- current implementation\r\n    $ kubeadm generate token          # in case kubeadm might generate other things in the future?\r\n    $ kubeadm init --generate-token   # possibly as a subcommand of an existing one\r\n\r\nCurrently, the output is simply the token on one line without any padding/formatting:\r\n\r\n    $ kubeadm generate-token\r\n    1087fd.722b60cdd39b1a5f\r\n\r\nCC: @kubernetes/sig-cluster-lifecycle \r\n\r\n**Release note**:\r\n<!--  Steps to write your release note:\r\n1. Use the release-note-* labels to set the release note state (if you have access) \r\n2. Enter your extended release note in the below block; leaving it blank means using the PR title as the release note. If no release note is required, just write `NONE`. \r\n-->\r\n```release-note\r\nNew kubeadm command: generate-token\r\n```\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.kubernetes.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.kubernetes.io/reviews/kubernetes/kubernetes/35144)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/254898406","html_url":"https://github.com/kubernetes/kubernetes/pull/35144#issuecomment-254898406","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/35144","id":254898406,"user":{"login":"pipejakob","id":1605981,"avatar_url":"https://avatars.githubusercontent.com/u/1605981?v=3","gravatar_id":"","url":"https://api.github.com/users/pipejakob","html_url":"https://github.com/pipejakob","followers_url":"https://api.github.com/users/pipejakob/followers","following_url":"https://api.github.com/users/pipejakob/following{/other_user}","gists_url":"https://api.github.com/users/pipejakob/gists{/gist_id}","starred_url":"https://api.github.com/users/pipejakob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pipejakob/subscriptions","organizations_url":"https://api.github.com/users/pipejakob/orgs","repos_url":"https://api.github.com/users/pipejakob/repos","events_url":"https://api.github.com/users/pipejakob/events{/privacy}","received_events_url":"https://api.github.com/users/pipejakob/received_events","type":"User","site_admin":false},"created_at":"2016-10-19T18:22:42Z","updated_at":"2016-10-19T18:22:42Z","body":"@dgoodwin Great suggestion, that seems a lot cleaner. I'll try to get up to speed on that proposal.\r\n\r\n@pires Yup, I was just trying to get early feedback on the CLI experience at this point, since any changes there would require refactoring the code (and hence the tests). Let me know if there's a better way to signal \"I'm looking for early feedback, but I know this commit isn't actually ready to be merged.\" I'll try to make that even more explicit in the future. And don't worry, we're on the same page: tests are good. Kubeadm could use a lot more of them, and I'll try to do my part :-)."}}
{"actor":{"display_login":"pipejakob"}}