{"action":"created","issue":{"url":"https://api.github.com/repos/ruflin/Elastica/issues/1002","labels_url":"https://api.github.com/repos/ruflin/Elastica/issues/1002/labels{/name}","comments_url":"https://api.github.com/repos/ruflin/Elastica/issues/1002/comments","events_url":"https://api.github.com/repos/ruflin/Elastica/issues/1002/events","html_url":"https://github.com/ruflin/Elastica/pull/1002","id":120580709,"number":1002,"title":"Fix codecov accuracy","user":{"login":"JustinHook","id":195578,"avatar_url":"https://avatars.githubusercontent.com/u/195578?v=3","gravatar_id":"","url":"https://api.github.com/users/JustinHook","html_url":"https://github.com/JustinHook","followers_url":"https://api.github.com/users/JustinHook/followers","following_url":"https://api.github.com/users/JustinHook/following{/other_user}","gists_url":"https://api.github.com/users/JustinHook/gists{/gist_id}","starred_url":"https://api.github.com/users/JustinHook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JustinHook/subscriptions","organizations_url":"https://api.github.com/users/JustinHook/orgs","repos_url":"https://api.github.com/users/JustinHook/repos","events_url":"https://api.github.com/users/JustinHook/events{/privacy}","received_events_url":"https://api.github.com/users/JustinHook/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":24,"created_at":"2015-12-05T19:11:55Z","updated_at":"2016-01-11T08:13:28Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ruflin/Elastica/pulls/1002","html_url":"https://github.com/ruflin/Elastica/pull/1002","diff_url":"https://github.com/ruflin/Elastica/pull/1002.diff","patch_url":"https://github.com/ruflin/Elastica/pull/1002.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/ruflin/Elastica/issues/comments/170460657","html_url":"https://github.com/ruflin/Elastica/pull/1002#issuecomment-170460657","issue_url":"https://api.github.com/repos/ruflin/Elastica/issues/1002","id":170460657,"user":{"login":"stevepeak","id":2041757,"avatar_url":"https://avatars.githubusercontent.com/u/2041757?v=3","gravatar_id":"","url":"https://api.github.com/users/stevepeak","html_url":"https://github.com/stevepeak","followers_url":"https://api.github.com/users/stevepeak/followers","following_url":"https://api.github.com/users/stevepeak/following{/other_user}","gists_url":"https://api.github.com/users/stevepeak/gists{/gist_id}","starred_url":"https://api.github.com/users/stevepeak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevepeak/subscriptions","organizations_url":"https://api.github.com/users/stevepeak/orgs","repos_url":"https://api.github.com/users/stevepeak/repos","events_url":"https://api.github.com/users/stevepeak/events{/privacy}","received_events_url":"https://api.github.com/users/stevepeak/received_events","type":"User","site_admin":false},"created_at":"2016-01-11T08:13:28Z","updated_at":"2016-01-11T08:13:28Z","body":"The difference are these strange lines like [64 here](https://codecov.io/github/ruflin/Elastica/lib/Elastica/Rescore/Query.php?ref=2b4eb2c1731c7c2d8f4dbc5e5b08818dd4f6c3ce#l-64) \r\n\r\nWe try to fix issues like these, [as seen here](https://github.com/codecov/codecov-bash/blob/ad3f2f5b548dbf16685fbaaf1954e75c9706ab0d/codecov#L655-L656).\r\n\r\nI looks like my method here is not properly finding the fixes. I'll need to make adjustments to the bash uploader to fix this. In this commit: https://github.com/codecov/codecov-bash/commit/bf76161cd12f869be742e27bc00d7f570d663a37\r\n\r\n------\r\n\r\nHowever, with all this being sad. The question remains: why was line 64 not covered? If you review the reports below you will find that Codecov is reporting properly. The commit 2b4eb2c indeed expresses line 64 as not covered (keep in mind that I am aware of this issue with php coverage reports and have adjusted our process to fix these issues above).\r\n\r\n```\r\nFri Jan 08 09:30:48 UTC 2016 : INFO, {\"commit\": \"2b4eb2c\", \"id\": \"5fc05f92-16f3-4feb-ac49-0f7a25250aa3\", \"method\": \"POST\", \"ms\": \"254\", \"reason\": \"OK\", \"reportid\": \"upload:131927:2b4eb2c1731c7c2d8f4dbc5e5b08818dd4f6c3ce:2024.3:2279:1452245448.46\", \"service\": \"github\", \"size\": 0.0, \"slug\": \"ruflin/Elastica\", \"speed\": 14, \"status\": 200, \"url\": \"/upload/v3?package=bash-5ca7b8c&branch=master&commit=2b4eb2c1731c7c2d8f4dbc5e5b08818dd4f6c3ce&build=2024.3&build_url=&slug=ruflin/Elastica&service=travis-org&pr=false&job=101017757\"} 200 Context\r\n\r\n\r\nSun Jan 10 21:18:19 UTC 2016 : INFO, {\"commit\": \"19aa1e2\", \"id\": \"980f3520-c2bb-4e2b-bda0-91bc9873323e\", \"method\": \"POST\", \"ms\": \"222\", \"reason\": \"OK\", \"reportid\": \"upload:131927:19aa1e23ed5424469e6a99fb2e483b20e59c3ccb:2025.3:7203:1452460699.96\", \"service\": \"github\", \"size\": 0.0, \"slug\": \"ruflin/Elastica\", \"speed\": 10, \"status\": 200, \"url\": \"/upload/v3?package=bash-5ca7b8c&branch=master&commit=19aa1e23ed5424469e6a99fb2e483b20e59c3ccb&build=2025.3&build_url=&slug=ruflin/Elastica&service=travis-org&pr=1002&job=101462751\"} 200 Context\r\n```\r\n\r\n- Raw upload for [2b4eb2c]( https://codecov.s3.amazonaws.com/repos/EC55CECE92D7A61E808BB6F114878128/uploads/upload:131927:2b4eb2c1731c7c2d8f4dbc5e5b08818dd4f6c3ce:2024.3:2279:1452245448.46.txt)\r\n- Raw upload for [19aa1e2](https://codecov.s3.amazonaws.com/repos/EC55CECE92D7A61E808BB6F114878128/uploads/upload:131927:19aa1e23ed5424469e6a99fb2e483b20e59c3ccb:2025.3:7203:1452460699.96.txt)\r\n\r\n> PS access to these raw uploads  and logs are in our next major release"}}