{"action":"created","comment":{"url":"https://api.github.com/repos/hyperoslo/Spots/pulls/comments/81329382","pull_request_review_id":2317007,"id":81329382,"diff_hunk":"@@ -0,0 +1,12 @@\n+import UIKit\n+\n+extension UIViewController {","path":"Sources/iOS/Extensions/UIViewController+Extensions.swift","position":3,"original_position":3,"commit_id":"b441ce8bca7a9cb94b914180f7c7b6fe2658169c","original_commit_id":"b441ce8bca7a9cb94b914180f7c7b6fe2658169c","user":{"login":"onmyway133","id":2284279,"avatar_url":"https://avatars.githubusercontent.com/u/2284279?v=3","gravatar_id":"","url":"https://api.github.com/users/onmyway133","html_url":"https://github.com/onmyway133","followers_url":"https://api.github.com/users/onmyway133/followers","following_url":"https://api.github.com/users/onmyway133/following{/other_user}","gists_url":"https://api.github.com/users/onmyway133/gists{/gist_id}","starred_url":"https://api.github.com/users/onmyway133/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onmyway133/subscriptions","organizations_url":"https://api.github.com/users/onmyway133/orgs","repos_url":"https://api.github.com/users/onmyway133/repos","events_url":"https://api.github.com/users/onmyway133/events{/privacy}","received_events_url":"https://api.github.com/users/onmyway133/received_events","type":"User","site_admin":false},"body":"Oh ja, it should be for `SpotsController`","created_at":"2016-09-30T12:30:24Z","updated_at":"2016-09-30T12:30:24Z","html_url":"https://github.com/hyperoslo/Spots/pull/322#discussion_r81329382","pull_request_url":"https://api.github.com/repos/hyperoslo/Spots/pulls/322","_links":{"self":{"href":"https://api.github.com/repos/hyperoslo/Spots/pulls/comments/81329382"},"html":{"href":"https://github.com/hyperoslo/Spots/pull/322#discussion_r81329382"},"pull_request":{"href":"https://api.github.com/repos/hyperoslo/Spots/pulls/322"}}},"pull_request":{"url":"https://api.github.com/repos/hyperoslo/Spots/pulls/322","id":87480625,"html_url":"https://github.com/hyperoslo/Spots/pull/322","diff_url":"https://github.com/hyperoslo/Spots/pull/322.diff","patch_url":"https://github.com/hyperoslo/Spots/pull/322.patch","issue_url":"https://api.github.com/repos/hyperoslo/Spots/issues/322","number":322,"state":"open","locked":false,"title":"Check for auto rotation","user":{"login":"onmyway133","id":2284279,"avatar_url":"https://avatars.githubusercontent.com/u/2284279?v=3","gravatar_id":"","url":"https://api.github.com/users/onmyway133","html_url":"https://github.com/onmyway133","followers_url":"https://api.github.com/users/onmyway133/followers","following_url":"https://api.github.com/users/onmyway133/following{/other_user}","gists_url":"https://api.github.com/users/onmyway133/gists{/gist_id}","starred_url":"https://api.github.com/users/onmyway133/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onmyway133/subscriptions","organizations_url":"https://api.github.com/users/onmyway133/orgs","repos_url":"https://api.github.com/users/onmyway133/repos","events_url":"https://api.github.com/users/onmyway133/events{/privacy}","received_events_url":"https://api.github.com/users/onmyway133/received_events","type":"User","site_admin":false},"body":"As a follow up to https://github.com/hyperoslo/Spots/pull/286. There is an edge case like this\r\n\r\n- Present a video player as modal\r\n- At the end of video end, rotate to landscape\r\n\r\nAt that time `viewWillTransitionToSize` is called and `presentedViewController` is nil too, and also checking for `presentedViewController` is not ideal. \r\n\r\nThis fixes it by checking for `shouldAutorotate` throughout the parent view controller chain","created_at":"2016-09-30T11:55:41Z","updated_at":"2016-09-30T12:30:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b0922dd9994894db4ca0c6554ace19a1dc440227","assignee":{"login":"zenangst","id":57446,"avatar_url":"https://avatars.githubusercontent.com/u/57446?v=3","gravatar_id":"","url":"https://api.github.com/users/zenangst","html_url":"https://github.com/zenangst","followers_url":"https://api.github.com/users/zenangst/followers","following_url":"https://api.github.com/users/zenangst/following{/other_user}","gists_url":"https://api.github.com/users/zenangst/gists{/gist_id}","starred_url":"https://api.github.com/users/zenangst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zenangst/subscriptions","organizations_url":"https://api.github.com/users/zenangst/orgs","repos_url":"https://api.github.com/users/zenangst/repos","events_url":"https://api.github.com/users/zenangst/events{/privacy}","received_events_url":"https://api.github.com/users/zenangst/received_events","type":"User","site_admin":false},"assignees":[{"login":"zenangst","id":57446,"avatar_url":"https://avatars.githubusercontent.com/u/57446?v=3","gravatar_id":"","url":"https://api.github.com/users/zenangst","html_url":"https://github.com/zenangst","followers_url":"https://api.github.com/users/zenangst/followers","following_url":"https://api.github.com/users/zenangst/following{/other_user}","gists_url":"https://api.github.com/users/zenangst/gists{/gist_id}","starred_url":"https://api.github.com/users/zenangst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zenangst/subscriptions","organizations_url":"https://api.github.com/users/zenangst/orgs","repos_url":"https://api.github.com/users/zenangst/repos","events_url":"https://api.github.com/users/zenangst/events{/privacy}","received_events_url":"https://api.github.com/users/zenangst/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/hyperoslo/Spots/pulls/322/commits","review_comments_url":"https://api.github.com/repos/hyperoslo/Spots/pulls/322/comments","review_comment_url":"https://api.github.com/repos/hyperoslo/Spots/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hyperoslo/Spots/issues/322/comments","statuses_url":"https://api.github.com/repos/hyperoslo/Spots/statuses/b441ce8bca7a9cb94b914180f7c7b6fe2658169c","head":{"label":"hyperoslo:fix/orientation","ref":"fix/orientation","sha":"b441ce8bca7a9cb94b914180f7c7b6fe2658169c","user":{"login":"hyperoslo","id":1340892,"avatar_url":"https://avatars.githubusercontent.com/u/1340892?v=3","gravatar_id":"","url":"https://api.github.com/users/hyperoslo","html_url":"https://github.com/hyperoslo","followers_url":"https://api.github.com/users/hyperoslo/followers","following_url":"https://api.github.com/users/hyperoslo/following{/other_user}","gists_url":"https://api.github.com/users/hyperoslo/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperoslo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperoslo/subscriptions","organizations_url":"https://api.github.com/users/hyperoslo/orgs","repos_url":"https://api.github.com/users/hyperoslo/repos","events_url":"https://api.github.com/users/hyperoslo/events{/privacy}","received_events_url":"https://api.github.com/users/hyperoslo/received_events","type":"Organization","site_admin":false},"repo":{"id":43603611,"name":"Spots","full_name":"hyperoslo/Spots","owner":{"login":"hyperoslo","id":1340892,"avatar_url":"https://avatars.githubusercontent.com/u/1340892?v=3","gravatar_id":"","url":"https://api.github.com/users/hyperoslo","html_url":"https://github.com/hyperoslo","followers_url":"https://api.github.com/users/hyperoslo/followers","following_url":"https://api.github.com/users/hyperoslo/following{/other_user}","gists_url":"https://api.github.com/users/hyperoslo/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperoslo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperoslo/subscriptions","organizations_url":"https://api.github.com/users/hyperoslo/orgs","repos_url":"https://api.github.com/users/hyperoslo/repos","events_url":"https://api.github.com/users/hyperoslo/events{/privacy}","received_events_url":"https://api.github.com/users/hyperoslo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hyperoslo/Spots","description":":bamboo: Spots is a view controller framework that makes your setup and future development blazingly fast.","fork":false,"url":"https://api.github.com/repos/hyperoslo/Spots","forks_url":"https://api.github.com/repos/hyperoslo/Spots/forks","keys_url":"https://api.github.com/repos/hyperoslo/Spots/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hyperoslo/Spots/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hyperoslo/Spots/teams","hooks_url":"https://api.github.com/repos/hyperoslo/Spots/hooks","issue_events_url":"https://api.github.com/repos/hyperoslo/Spots/issues/events{/number}","events_url":"https://api.github.com/repos/hyperoslo/Spots/events","assignees_url":"https://api.github.com/repos/hyperoslo/Spots/assignees{/user}","branches_url":"https://api.github.com/repos/hyperoslo/Spots/branches{/branch}","tags_url":"https://api.github.com/repos/hyperoslo/Spots/tags","blobs_url":"https://api.github.com/repos/hyperoslo/Spots/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hyperoslo/Spots/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hyperoslo/Spots/git/refs{/sha}","trees_url":"https://api.github.com/repos/hyperoslo/Spots/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hyperoslo/Spots/statuses/{sha}","languages_url":"https://api.github.com/repos/hyperoslo/Spots/languages","stargazers_url":"https://api.github.com/repos/hyperoslo/Spots/stargazers","contributors_url":"https://api.github.com/repos/hyperoslo/Spots/contributors","subscribers_url":"https://api.github.com/repos/hyperoslo/Spots/subscribers","subscription_url":"https://api.github.com/repos/hyperoslo/Spots/subscription","commits_url":"https://api.github.com/repos/hyperoslo/Spots/commits{/sha}","git_commits_url":"https://api.github.com/repos/hyperoslo/Spots/git/commits{/sha}","comments_url":"https://api.github.com/repos/hyperoslo/Spots/comments{/number}","issue_comment_url":"https://api.github.com/repos/hyperoslo/Spots/issues/comments{/number}","contents_url":"https://api.github.com/repos/hyperoslo/Spots/contents/{+path}","compare_url":"https://api.github.com/repos/hyperoslo/Spots/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hyperoslo/Spots/merges","archive_url":"https://api.github.com/repos/hyperoslo/Spots/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hyperoslo/Spots/downloads","issues_url":"https://api.github.com/repos/hyperoslo/Spots/issues{/number}","pulls_url":"https://api.github.com/repos/hyperoslo/Spots/pulls{/number}","milestones_url":"https://api.github.com/repos/hyperoslo/Spots/milestones{/number}","notifications_url":"https://api.github.com/repos/hyperoslo/Spots/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hyperoslo/Spots/labels{/name}","releases_url":"https://api.github.com/repos/hyperoslo/Spots/releases{/id}","deployments_url":"https://api.github.com/repos/hyperoslo/Spots/deployments","created_at":"2015-10-03T15:28:33Z","updated_at":"2016-09-30T07:15:42Z","pushed_at":"2016-09-30T11:55:41Z","git_url":"git://github.com/hyperoslo/Spots.git","ssh_url":"git@github.com:hyperoslo/Spots.git","clone_url":"https://github.com/hyperoslo/Spots.git","svn_url":"https://github.com/hyperoslo/Spots","homepage":"","size":30705,"stargazers_count":533,"watchers_count":533,"language":"Swift","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":24,"mirror_url":null,"open_issues_count":7,"forks":24,"open_issues":7,"watchers":533,"default_branch":"master"}},"base":{"label":"hyperoslo:master","ref":"master","sha":"a6d84288099b8773d5af5ad96d5535e37330982d","user":{"login":"hyperoslo","id":1340892,"avatar_url":"https://avatars.githubusercontent.com/u/1340892?v=3","gravatar_id":"","url":"https://api.github.com/users/hyperoslo","html_url":"https://github.com/hyperoslo","followers_url":"https://api.github.com/users/hyperoslo/followers","following_url":"https://api.github.com/users/hyperoslo/following{/other_user}","gists_url":"https://api.github.com/users/hyperoslo/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperoslo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperoslo/subscriptions","organizations_url":"https://api.github.com/users/hyperoslo/orgs","repos_url":"https://api.github.com/users/hyperoslo/repos","events_url":"https://api.github.com/users/hyperoslo/events{/privacy}","received_events_url":"https://api.github.com/users/hyperoslo/received_events","type":"Organization","site_admin":false},"repo":{"id":43603611,"name":"Spots","full_name":"hyperoslo/Spots","owner":{"login":"hyperoslo","id":1340892,"avatar_url":"https://avatars.githubusercontent.com/u/1340892?v=3","gravatar_id":"","url":"https://api.github.com/users/hyperoslo","html_url":"https://github.com/hyperoslo","followers_url":"https://api.github.com/users/hyperoslo/followers","following_url":"https://api.github.com/users/hyperoslo/following{/other_user}","gists_url":"https://api.github.com/users/hyperoslo/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperoslo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperoslo/subscriptions","organizations_url":"https://api.github.com/users/hyperoslo/orgs","repos_url":"https://api.github.com/users/hyperoslo/repos","events_url":"https://api.github.com/users/hyperoslo/events{/privacy}","received_events_url":"https://api.github.com/users/hyperoslo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hyperoslo/Spots","description":":bamboo: Spots is a view controller framework that makes your setup and future development blazingly fast.","fork":false,"url":"https://api.github.com/repos/hyperoslo/Spots","forks_url":"https://api.github.com/repos/hyperoslo/Spots/forks","keys_url":"https://api.github.com/repos/hyperoslo/Spots/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hyperoslo/Spots/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hyperoslo/Spots/teams","hooks_url":"https://api.github.com/repos/hyperoslo/Spots/hooks","issue_events_url":"https://api.github.com/repos/hyperoslo/Spots/issues/events{/number}","events_url":"https://api.github.com/repos/hyperoslo/Spots/events","assignees_url":"https://api.github.com/repos/hyperoslo/Spots/assignees{/user}","branches_url":"https://api.github.com/repos/hyperoslo/Spots/branches{/branch}","tags_url":"https://api.github.com/repos/hyperoslo/Spots/tags","blobs_url":"https://api.github.com/repos/hyperoslo/Spots/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hyperoslo/Spots/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hyperoslo/Spots/git/refs{/sha}","trees_url":"https://api.github.com/repos/hyperoslo/Spots/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hyperoslo/Spots/statuses/{sha}","languages_url":"https://api.github.com/repos/hyperoslo/Spots/languages","stargazers_url":"https://api.github.com/repos/hyperoslo/Spots/stargazers","contributors_url":"https://api.github.com/repos/hyperoslo/Spots/contributors","subscribers_url":"https://api.github.com/repos/hyperoslo/Spots/subscribers","subscription_url":"https://api.github.com/repos/hyperoslo/Spots/subscription","commits_url":"https://api.github.com/repos/hyperoslo/Spots/commits{/sha}","git_commits_url":"https://api.github.com/repos/hyperoslo/Spots/git/commits{/sha}","comments_url":"https://api.github.com/repos/hyperoslo/Spots/comments{/number}","issue_comment_url":"https://api.github.com/repos/hyperoslo/Spots/issues/comments{/number}","contents_url":"https://api.github.com/repos/hyperoslo/Spots/contents/{+path}","compare_url":"https://api.github.com/repos/hyperoslo/Spots/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hyperoslo/Spots/merges","archive_url":"https://api.github.com/repos/hyperoslo/Spots/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hyperoslo/Spots/downloads","issues_url":"https://api.github.com/repos/hyperoslo/Spots/issues{/number}","pulls_url":"https://api.github.com/repos/hyperoslo/Spots/pulls{/number}","milestones_url":"https://api.github.com/repos/hyperoslo/Spots/milestones{/number}","notifications_url":"https://api.github.com/repos/hyperoslo/Spots/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hyperoslo/Spots/labels{/name}","releases_url":"https://api.github.com/repos/hyperoslo/Spots/releases{/id}","deployments_url":"https://api.github.com/repos/hyperoslo/Spots/deployments","created_at":"2015-10-03T15:28:33Z","updated_at":"2016-09-30T07:15:42Z","pushed_at":"2016-09-30T11:55:41Z","git_url":"git://github.com/hyperoslo/Spots.git","ssh_url":"git@github.com:hyperoslo/Spots.git","clone_url":"https://github.com/hyperoslo/Spots.git","svn_url":"https://github.com/hyperoslo/Spots","homepage":"","size":30705,"stargazers_count":533,"watchers_count":533,"language":"Swift","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":24,"mirror_url":null,"open_issues_count":7,"forks":24,"open_issues":7,"watchers":533,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hyperoslo/Spots/pulls/322"},"html":{"href":"https://github.com/hyperoslo/Spots/pull/322"},"issue":{"href":"https://api.github.com/repos/hyperoslo/Spots/issues/322"},"comments":{"href":"https://api.github.com/repos/hyperoslo/Spots/issues/322/comments"},"review_comments":{"href":"https://api.github.com/repos/hyperoslo/Spots/pulls/322/comments"},"review_comment":{"href":"https://api.github.com/repos/hyperoslo/Spots/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hyperoslo/Spots/pulls/322/commits"},"statuses":{"href":"https://api.github.com/repos/hyperoslo/Spots/statuses/b441ce8bca7a9cb94b914180f7c7b6fe2658169c"}}}}
{"actor":{"display_login":"onmyway133"}}