{"action":"created","comment":{"url":"https://api.github.com/repos/linkedin/ambry/pulls/comments/63129046","id":63129046,"diff_hunk":"@@ -116,6 +121,39 @@ private NettyServer getNettyServer(Properties properties)\n     RestRequestHandler requestHandler = new MockRestRequestResponseHandler();\n     PublicAccessLogger publicAccessLogger = new PublicAccessLogger(new String[]{}, new String[]{});\n     RestServerState restServerState = new RestServerState(\"/healthCheck\");\n-    return new NettyServer(nettyConfig, nettyMetrics, requestHandler, publicAccessLogger, restServerState);\n+    return new NettyServer(nettyConfig, nettyMetrics,\n+        initializeChannelHandlers(nettyMetrics, nettyConfig, requestHandler, publicAccessLogger, restServerState));\n+  }\n+\n+  /**\n+   * Initialize the {@link ChannelHandler}s to be used in the netty pipeline\n+   * @param nettyConfig the {@link NettyConfig} instance that defines the configuration parameters for the NettyServer.","path":"ambry-rest/src/test/java/com.github.ambry.rest/NettyServerTest.java","position":24,"original_position":24,"commit_id":"18f194bb6a15f8273e6b4f16965b8ec48b8f8095","original_commit_id":"18f194bb6a15f8273e6b4f16965b8ec48b8f8095","user":{"login":"pnarayanan","id":1454915,"avatar_url":"https://avatars.githubusercontent.com/u/1454915?v=3","gravatar_id":"","url":"https://api.github.com/users/pnarayanan","html_url":"https://github.com/pnarayanan","followers_url":"https://api.github.com/users/pnarayanan/followers","following_url":"https://api.github.com/users/pnarayanan/following{/other_user}","gists_url":"https://api.github.com/users/pnarayanan/gists{/gist_id}","starred_url":"https://api.github.com/users/pnarayanan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pnarayanan/subscriptions","organizations_url":"https://api.github.com/users/pnarayanan/orgs","repos_url":"https://api.github.com/users/pnarayanan/repos","events_url":"https://api.github.com/users/pnarayanan/events{/privacy}","received_events_url":"https://api.github.com/users/pnarayanan/received_events","type":"User","site_admin":false},"body":"reorder.","created_at":"2016-05-13T03:26:32Z","updated_at":"2016-05-13T03:26:32Z","html_url":"https://github.com/linkedin/ambry/pull/293#discussion_r63129046","pull_request_url":"https://api.github.com/repos/linkedin/ambry/pulls/293","_links":{"self":{"href":"https://api.github.com/repos/linkedin/ambry/pulls/comments/63129046"},"html":{"href":"https://github.com/linkedin/ambry/pull/293#discussion_r63129046"},"pull_request":{"href":"https://api.github.com/repos/linkedin/ambry/pulls/293"}}},"pull_request":{"url":"https://api.github.com/repos/linkedin/ambry/pulls/293","id":69914433,"html_url":"https://github.com/linkedin/ambry/pull/293","diff_url":"https://github.com/linkedin/ambry/pull/293.diff","patch_url":"https://github.com/linkedin/ambry/pull/293.patch","issue_url":"https://api.github.com/repos/linkedin/ambry/issues/293","number":293,"state":"open","locked":false,"title":"Abstracting the creation of netty channel handlers","user":{"login":"nsivabalan","id":513218,"avatar_url":"https://avatars.githubusercontent.com/u/513218?v=3","gravatar_id":"","url":"https://api.github.com/users/nsivabalan","html_url":"https://github.com/nsivabalan","followers_url":"https://api.github.com/users/nsivabalan/followers","following_url":"https://api.github.com/users/nsivabalan/following{/other_user}","gists_url":"https://api.github.com/users/nsivabalan/gists{/gist_id}","starred_url":"https://api.github.com/users/nsivabalan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nsivabalan/subscriptions","organizations_url":"https://api.github.com/users/nsivabalan/orgs","repos_url":"https://api.github.com/users/nsivabalan/repos","events_url":"https://api.github.com/users/nsivabalan/events{/privacy}","received_events_url":"https://api.github.com/users/nsivabalan/received_events","type":"User","site_admin":false},"body":"Creation of handlers was hardcoded in NettyServer. This patch abstracts it in the NettyServerFactory so that any other implementation of NioServer have the flexibility to define their own handlers.\r\n\r\nSLA: 5 mins\r\nReviewers: Priyesh, Ming","created_at":"2016-05-12T22:02:10Z","updated_at":"2016-05-13T03:26:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1a83b9fe46dd417ed20c708cb27aa386a237437c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/linkedin/ambry/pulls/293/commits","review_comments_url":"https://api.github.com/repos/linkedin/ambry/pulls/293/comments","review_comment_url":"https://api.github.com/repos/linkedin/ambry/pulls/comments{/number}","comments_url":"https://api.github.com/repos/linkedin/ambry/issues/293/comments","statuses_url":"https://api.github.com/repos/linkedin/ambry/statuses/18f194bb6a15f8273e6b4f16965b8ec48b8f8095","head":{"label":"nsivabalan:ChannelPipelineFactory","ref":"ChannelPipelineFactory","sha":"18f194bb6a15f8273e6b4f16965b8ec48b8f8095","user":{"login":"nsivabalan","id":513218,"avatar_url":"https://avatars.githubusercontent.com/u/513218?v=3","gravatar_id":"","url":"https://api.github.com/users/nsivabalan","html_url":"https://github.com/nsivabalan","followers_url":"https://api.github.com/users/nsivabalan/followers","following_url":"https://api.github.com/users/nsivabalan/following{/other_user}","gists_url":"https://api.github.com/users/nsivabalan/gists{/gist_id}","starred_url":"https://api.github.com/users/nsivabalan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nsivabalan/subscriptions","organizations_url":"https://api.github.com/users/nsivabalan/orgs","repos_url":"https://api.github.com/users/nsivabalan/repos","events_url":"https://api.github.com/users/nsivabalan/events{/privacy}","received_events_url":"https://api.github.com/users/nsivabalan/received_events","type":"User","site_admin":false},"repo":{"id":20119917,"name":"ambry","full_name":"nsivabalan/ambry","owner":{"login":"nsivabalan","id":513218,"avatar_url":"https://avatars.githubusercontent.com/u/513218?v=3","gravatar_id":"","url":"https://api.github.com/users/nsivabalan","html_url":"https://github.com/nsivabalan","followers_url":"https://api.github.com/users/nsivabalan/followers","following_url":"https://api.github.com/users/nsivabalan/following{/other_user}","gists_url":"https://api.github.com/users/nsivabalan/gists{/gist_id}","starred_url":"https://api.github.com/users/nsivabalan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nsivabalan/subscriptions","organizations_url":"https://api.github.com/users/nsivabalan/orgs","repos_url":"https://api.github.com/users/nsivabalan/repos","events_url":"https://api.github.com/users/nsivabalan/events{/privacy}","received_events_url":"https://api.github.com/users/nsivabalan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nsivabalan/ambry","description":"Immutable blob store","fork":true,"url":"https://api.github.com/repos/nsivabalan/ambry","forks_url":"https://api.github.com/repos/nsivabalan/ambry/forks","keys_url":"https://api.github.com/repos/nsivabalan/ambry/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nsivabalan/ambry/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nsivabalan/ambry/teams","hooks_url":"https://api.github.com/repos/nsivabalan/ambry/hooks","issue_events_url":"https://api.github.com/repos/nsivabalan/ambry/issues/events{/number}","events_url":"https://api.github.com/repos/nsivabalan/ambry/events","assignees_url":"https://api.github.com/repos/nsivabalan/ambry/assignees{/user}","branches_url":"https://api.github.com/repos/nsivabalan/ambry/branches{/branch}","tags_url":"https://api.github.com/repos/nsivabalan/ambry/tags","blobs_url":"https://api.github.com/repos/nsivabalan/ambry/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nsivabalan/ambry/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nsivabalan/ambry/git/refs{/sha}","trees_url":"https://api.github.com/repos/nsivabalan/ambry/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nsivabalan/ambry/statuses/{sha}","languages_url":"https://api.github.com/repos/nsivabalan/ambry/languages","stargazers_url":"https://api.github.com/repos/nsivabalan/ambry/stargazers","contributors_url":"https://api.github.com/repos/nsivabalan/ambry/contributors","subscribers_url":"https://api.github.com/repos/nsivabalan/ambry/subscribers","subscription_url":"https://api.github.com/repos/nsivabalan/ambry/subscription","commits_url":"https://api.github.com/repos/nsivabalan/ambry/commits{/sha}","git_commits_url":"https://api.github.com/repos/nsivabalan/ambry/git/commits{/sha}","comments_url":"https://api.github.com/repos/nsivabalan/ambry/comments{/number}","issue_comment_url":"https://api.github.com/repos/nsivabalan/ambry/issues/comments{/number}","contents_url":"https://api.github.com/repos/nsivabalan/ambry/contents/{+path}","compare_url":"https://api.github.com/repos/nsivabalan/ambry/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nsivabalan/ambry/merges","archive_url":"https://api.github.com/repos/nsivabalan/ambry/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nsivabalan/ambry/downloads","issues_url":"https://api.github.com/repos/nsivabalan/ambry/issues{/number}","pulls_url":"https://api.github.com/repos/nsivabalan/ambry/pulls{/number}","milestones_url":"https://api.github.com/repos/nsivabalan/ambry/milestones{/number}","notifications_url":"https://api.github.com/repos/nsivabalan/ambry/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nsivabalan/ambry/labels{/name}","releases_url":"https://api.github.com/repos/nsivabalan/ambry/releases{/id}","deployments_url":"https://api.github.com/repos/nsivabalan/ambry/deployments","created_at":"2014-05-24T02:15:09Z","updated_at":"2016-05-04T20:45:58Z","pushed_at":"2016-05-13T00:56:25Z","git_url":"git://github.com/nsivabalan/ambry.git","ssh_url":"git@github.com:nsivabalan/ambry.git","clone_url":"https://github.com/nsivabalan/ambry.git","svn_url":"https://github.com/nsivabalan/ambry","homepage":null,"size":6629,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"linkedin:master","ref":"master","sha":"cffb9b9ea7feedc93df2be113b2972d3a511b01b","user":{"login":"linkedin","id":357098,"avatar_url":"https://avatars.githubusercontent.com/u/357098?v=3","gravatar_id":"","url":"https://api.github.com/users/linkedin","html_url":"https://github.com/linkedin","followers_url":"https://api.github.com/users/linkedin/followers","following_url":"https://api.github.com/users/linkedin/following{/other_user}","gists_url":"https://api.github.com/users/linkedin/gists{/gist_id}","starred_url":"https://api.github.com/users/linkedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkedin/subscriptions","organizations_url":"https://api.github.com/users/linkedin/orgs","repos_url":"https://api.github.com/users/linkedin/repos","events_url":"https://api.github.com/users/linkedin/events{/privacy}","received_events_url":"https://api.github.com/users/linkedin/received_events","type":"Organization","site_admin":false},"repo":{"id":13870893,"name":"ambry","full_name":"linkedin/ambry","owner":{"login":"linkedin","id":357098,"avatar_url":"https://avatars.githubusercontent.com/u/357098?v=3","gravatar_id":"","url":"https://api.github.com/users/linkedin","html_url":"https://github.com/linkedin","followers_url":"https://api.github.com/users/linkedin/followers","following_url":"https://api.github.com/users/linkedin/following{/other_user}","gists_url":"https://api.github.com/users/linkedin/gists{/gist_id}","starred_url":"https://api.github.com/users/linkedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkedin/subscriptions","organizations_url":"https://api.github.com/users/linkedin/orgs","repos_url":"https://api.github.com/users/linkedin/repos","events_url":"https://api.github.com/users/linkedin/events{/privacy}","received_events_url":"https://api.github.com/users/linkedin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/linkedin/ambry","description":"Distributed object store","fork":false,"url":"https://api.github.com/repos/linkedin/ambry","forks_url":"https://api.github.com/repos/linkedin/ambry/forks","keys_url":"https://api.github.com/repos/linkedin/ambry/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linkedin/ambry/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linkedin/ambry/teams","hooks_url":"https://api.github.com/repos/linkedin/ambry/hooks","issue_events_url":"https://api.github.com/repos/linkedin/ambry/issues/events{/number}","events_url":"https://api.github.com/repos/linkedin/ambry/events","assignees_url":"https://api.github.com/repos/linkedin/ambry/assignees{/user}","branches_url":"https://api.github.com/repos/linkedin/ambry/branches{/branch}","tags_url":"https://api.github.com/repos/linkedin/ambry/tags","blobs_url":"https://api.github.com/repos/linkedin/ambry/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linkedin/ambry/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linkedin/ambry/git/refs{/sha}","trees_url":"https://api.github.com/repos/linkedin/ambry/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linkedin/ambry/statuses/{sha}","languages_url":"https://api.github.com/repos/linkedin/ambry/languages","stargazers_url":"https://api.github.com/repos/linkedin/ambry/stargazers","contributors_url":"https://api.github.com/repos/linkedin/ambry/contributors","subscribers_url":"https://api.github.com/repos/linkedin/ambry/subscribers","subscription_url":"https://api.github.com/repos/linkedin/ambry/subscription","commits_url":"https://api.github.com/repos/linkedin/ambry/commits{/sha}","git_commits_url":"https://api.github.com/repos/linkedin/ambry/git/commits{/sha}","comments_url":"https://api.github.com/repos/linkedin/ambry/comments{/number}","issue_comment_url":"https://api.github.com/repos/linkedin/ambry/issues/comments{/number}","contents_url":"https://api.github.com/repos/linkedin/ambry/contents/{+path}","compare_url":"https://api.github.com/repos/linkedin/ambry/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linkedin/ambry/merges","archive_url":"https://api.github.com/repos/linkedin/ambry/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linkedin/ambry/downloads","issues_url":"https://api.github.com/repos/linkedin/ambry/issues{/number}","pulls_url":"https://api.github.com/repos/linkedin/ambry/pulls{/number}","milestones_url":"https://api.github.com/repos/linkedin/ambry/milestones{/number}","notifications_url":"https://api.github.com/repos/linkedin/ambry/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linkedin/ambry/labels{/name}","releases_url":"https://api.github.com/repos/linkedin/ambry/releases{/id}","deployments_url":"https://api.github.com/repos/linkedin/ambry/deployments","created_at":"2013-10-25T20:04:54Z","updated_at":"2016-05-04T20:25:45Z","pushed_at":"2016-05-13T00:57:08Z","git_url":"git://github.com/linkedin/ambry.git","ssh_url":"git@github.com:linkedin/ambry.git","clone_url":"https://github.com/linkedin/ambry.git","svn_url":"https://github.com/linkedin/ambry","homepage":"https://github.com/linkedin/ambry/wiki","size":6899,"stargazers_count":11,"watchers_count":11,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":8,"forks":1,"open_issues":8,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/linkedin/ambry/pulls/293"},"html":{"href":"https://github.com/linkedin/ambry/pull/293"},"issue":{"href":"https://api.github.com/repos/linkedin/ambry/issues/293"},"comments":{"href":"https://api.github.com/repos/linkedin/ambry/issues/293/comments"},"review_comments":{"href":"https://api.github.com/repos/linkedin/ambry/pulls/293/comments"},"review_comment":{"href":"https://api.github.com/repos/linkedin/ambry/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/linkedin/ambry/pulls/293/commits"},"statuses":{"href":"https://api.github.com/repos/linkedin/ambry/statuses/18f194bb6a15f8273e6b4f16965b8ec48b8f8095"}}}}