{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/67460632","id":67460632,"diff_hunk":"@@ -0,0 +1,94 @@\n+/*\n+ * Licensed to the Apache Software Foundation (ASF) under one or more\n+ * contributor license agreements.  See the NOTICE file distributed with\n+ * this work for additional information regarding copyright ownership.\n+ * The ASF licenses this file to You under the Apache License, Version 2.0\n+ * (the \"License\"); you may not use this file except in compliance with\n+ * the License.  You may obtain a copy of the License at\n+ *\n+ *    http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+package org.apache.spark.sql.execution.command\n+\n+import org.apache.spark.sql.{AnalysisException, Row, SparkSession}\n+import org.apache.spark.sql.catalyst.analysis.{FunctionRegistry, UnresolvedAttribute}\n+import org.apache.spark.sql.catalyst.expressions._\n+\n+/**\n+ * This class provides arguments and body expression of the macro.\n+ */\n+case class MacroFunctionWrapper(arguments: Seq[AttributeReference], body: Expression)\n+\n+/**\n+ * The DDL command that creates a macro.\n+ * To create a temporary macro, the syntax of using this command in SQL is:\n+ * {{{\n+ *    CREATE TEMPORARY MACRO macro_name([col_name col_type, ...]) expression;\n+ * }}}\n+ */\n+case class CreateMacroCommand(macroName: String, macroFunction: MacroFunctionWrapper)\n+  extends RunnableCommand {\n+\n+  override def run(sparkSession: SparkSession): Seq[Row] = {\n+    val catalog = sparkSession.sessionState.catalog\n+    val inputSet = AttributeSet(macroFunction.arguments)","path":"sql/core/src/main/scala/org/apache/spark/sql/execution/command/macros.scala","position":41,"original_position":41,"commit_id":"0b93636c941fd3093ba9b93e49e75211aa077c90","original_commit_id":"0b93636c941fd3093ba9b93e49e75211aa077c90","user":{"login":"hvanhovell","id":9616802,"avatar_url":"https://avatars.githubusercontent.com/u/9616802?v=3","gravatar_id":"","url":"https://api.github.com/users/hvanhovell","html_url":"https://github.com/hvanhovell","followers_url":"https://api.github.com/users/hvanhovell/followers","following_url":"https://api.github.com/users/hvanhovell/following{/other_user}","gists_url":"https://api.github.com/users/hvanhovell/gists{/gist_id}","starred_url":"https://api.github.com/users/hvanhovell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hvanhovell/subscriptions","organizations_url":"https://api.github.com/users/hvanhovell/orgs","repos_url":"https://api.github.com/users/hvanhovell/repos","events_url":"https://api.github.com/users/hvanhovell/events{/privacy}","received_events_url":"https://api.github.com/users/hvanhovell/received_events","type":"User","site_admin":false},"body":"not needed","created_at":"2016-06-17T04:54:25Z","updated_at":"2016-06-17T04:54:25Z","html_url":"https://github.com/apache/spark/pull/13706#discussion_r67460632","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/13706","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/67460632"},"html":{"href":"https://github.com/apache/spark/pull/13706#discussion_r67460632"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/13706"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/13706","id":74099373,"html_url":"https://github.com/apache/spark/pull/13706","diff_url":"https://github.com/apache/spark/pull/13706.diff","patch_url":"https://github.com/apache/spark/pull/13706.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/13706","number":13706,"state":"open","locked":false,"title":"[SPARK-15988] [SQL] Implement DDL commands: Create/Drop temporary macro","user":{"login":"lianhuiwang","id":545478,"avatar_url":"https://avatars.githubusercontent.com/u/545478?v=3","gravatar_id":"","url":"https://api.github.com/users/lianhuiwang","html_url":"https://github.com/lianhuiwang","followers_url":"https://api.github.com/users/lianhuiwang/followers","following_url":"https://api.github.com/users/lianhuiwang/following{/other_user}","gists_url":"https://api.github.com/users/lianhuiwang/gists{/gist_id}","starred_url":"https://api.github.com/users/lianhuiwang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lianhuiwang/subscriptions","organizations_url":"https://api.github.com/users/lianhuiwang/orgs","repos_url":"https://api.github.com/users/lianhuiwang/repos","events_url":"https://api.github.com/users/lianhuiwang/events{/privacy}","received_events_url":"https://api.github.com/users/lianhuiwang/received_events","type":"User","site_admin":false},"body":"## What changes were proposed in this pull request?\r\nIn https://issues.apache.org/jira/browse/HIVE-2655, Hive have implemented Create/Drop temporary macro. So This PR adds the support of native DDL commands to create and drop temporary macro for SparkSQL.\r\ntemporary macro can be considered as a special temporary function that has a FunctionBuilder that transform macro function into expression that can be directly calculated.\r\n\r\n## How was this patch tested?\r\nadd unit tests","created_at":"2016-06-16T15:17:05Z","updated_at":"2016-06-17T04:54:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f37055a781cd21c7da43bf96c23f6e4255f9893a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/13706/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/13706/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/13706/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/0b93636c941fd3093ba9b93e49e75211aa077c90","head":{"label":"lianhuiwang:macro","ref":"macro","sha":"0b93636c941fd3093ba9b93e49e75211aa077c90","user":{"login":"lianhuiwang","id":545478,"avatar_url":"https://avatars.githubusercontent.com/u/545478?v=3","gravatar_id":"","url":"https://api.github.com/users/lianhuiwang","html_url":"https://github.com/lianhuiwang","followers_url":"https://api.github.com/users/lianhuiwang/followers","following_url":"https://api.github.com/users/lianhuiwang/following{/other_user}","gists_url":"https://api.github.com/users/lianhuiwang/gists{/gist_id}","starred_url":"https://api.github.com/users/lianhuiwang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lianhuiwang/subscriptions","organizations_url":"https://api.github.com/users/lianhuiwang/orgs","repos_url":"https://api.github.com/users/lianhuiwang/repos","events_url":"https://api.github.com/users/lianhuiwang/events{/privacy}","received_events_url":"https://api.github.com/users/lianhuiwang/received_events","type":"User","site_admin":false},"repo":{"id":20906966,"name":"spark","full_name":"lianhuiwang/spark","owner":{"login":"lianhuiwang","id":545478,"avatar_url":"https://avatars.githubusercontent.com/u/545478?v=3","gravatar_id":"","url":"https://api.github.com/users/lianhuiwang","html_url":"https://github.com/lianhuiwang","followers_url":"https://api.github.com/users/lianhuiwang/followers","following_url":"https://api.github.com/users/lianhuiwang/following{/other_user}","gists_url":"https://api.github.com/users/lianhuiwang/gists{/gist_id}","starred_url":"https://api.github.com/users/lianhuiwang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lianhuiwang/subscriptions","organizations_url":"https://api.github.com/users/lianhuiwang/orgs","repos_url":"https://api.github.com/users/lianhuiwang/repos","events_url":"https://api.github.com/users/lianhuiwang/events{/privacy}","received_events_url":"https://api.github.com/users/lianhuiwang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lianhuiwang/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/lianhuiwang/spark","forks_url":"https://api.github.com/repos/lianhuiwang/spark/forks","keys_url":"https://api.github.com/repos/lianhuiwang/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lianhuiwang/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lianhuiwang/spark/teams","hooks_url":"https://api.github.com/repos/lianhuiwang/spark/hooks","issue_events_url":"https://api.github.com/repos/lianhuiwang/spark/issues/events{/number}","events_url":"https://api.github.com/repos/lianhuiwang/spark/events","assignees_url":"https://api.github.com/repos/lianhuiwang/spark/assignees{/user}","branches_url":"https://api.github.com/repos/lianhuiwang/spark/branches{/branch}","tags_url":"https://api.github.com/repos/lianhuiwang/spark/tags","blobs_url":"https://api.github.com/repos/lianhuiwang/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lianhuiwang/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lianhuiwang/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/lianhuiwang/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lianhuiwang/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/lianhuiwang/spark/languages","stargazers_url":"https://api.github.com/repos/lianhuiwang/spark/stargazers","contributors_url":"https://api.github.com/repos/lianhuiwang/spark/contributors","subscribers_url":"https://api.github.com/repos/lianhuiwang/spark/subscribers","subscription_url":"https://api.github.com/repos/lianhuiwang/spark/subscription","commits_url":"https://api.github.com/repos/lianhuiwang/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/lianhuiwang/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/lianhuiwang/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/lianhuiwang/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/lianhuiwang/spark/contents/{+path}","compare_url":"https://api.github.com/repos/lianhuiwang/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lianhuiwang/spark/merges","archive_url":"https://api.github.com/repos/lianhuiwang/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lianhuiwang/spark/downloads","issues_url":"https://api.github.com/repos/lianhuiwang/spark/issues{/number}","pulls_url":"https://api.github.com/repos/lianhuiwang/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/lianhuiwang/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/lianhuiwang/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lianhuiwang/spark/labels{/name}","releases_url":"https://api.github.com/repos/lianhuiwang/spark/releases{/id}","deployments_url":"https://api.github.com/repos/lianhuiwang/spark/deployments","created_at":"2014-06-17T02:01:23Z","updated_at":"2016-06-03T07:29:47Z","pushed_at":"2016-06-16T18:00:23Z","git_url":"git://github.com/lianhuiwang/spark.git","ssh_url":"git@github.com:lianhuiwang/spark.git","clone_url":"https://github.com/lianhuiwang/spark.git","svn_url":"https://github.com/lianhuiwang/spark","homepage":null,"size":179338,"stargazers_count":1,"watchers_count":1,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"7c6c6926376c93acc42dd56a399d816f4838f28c","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","deployments_url":"https://api.github.com/repos/apache/spark/deployments","created_at":"2014-02-25T08:00:08Z","updated_at":"2016-06-17T01:53:19Z","pushed_at":"2016-06-17T04:48:38Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":497507,"stargazers_count":8952,"watchers_count":8952,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8315,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":377,"forks":8315,"open_issues":377,"watchers":8952,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/13706"},"html":{"href":"https://github.com/apache/spark/pull/13706"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/13706"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/13706/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/13706/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/13706/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/0b93636c941fd3093ba9b93e49e75211aa077c90"}}}}
{"actor":{"display_login":"hvanhovell"}}