{"action":"created","issue":{"url":"https://api.github.com/repos/apache/spark/issues/16319","repository_url":"https://api.github.com/repos/apache/spark","labels_url":"https://api.github.com/repos/apache/spark/issues/16319/labels{/name}","comments_url":"https://api.github.com/repos/apache/spark/issues/16319/comments","events_url":"https://api.github.com/repos/apache/spark/issues/16319/events","html_url":"https://github.com/apache/spark/pull/16319","id":196161418,"number":16319,"title":"[SPARK-18699] SQL - parsing CSV should return null for certain numeric …","user":{"login":"kubatyszko","id":826814,"avatar_url":"https://avatars.githubusercontent.com/u/826814?v=3","gravatar_id":"","url":"https://api.github.com/users/kubatyszko","html_url":"https://github.com/kubatyszko","followers_url":"https://api.github.com/users/kubatyszko/followers","following_url":"https://api.github.com/users/kubatyszko/following{/other_user}","gists_url":"https://api.github.com/users/kubatyszko/gists{/gist_id}","starred_url":"https://api.github.com/users/kubatyszko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubatyszko/subscriptions","organizations_url":"https://api.github.com/users/kubatyszko/orgs","repos_url":"https://api.github.com/users/kubatyszko/repos","events_url":"https://api.github.com/users/kubatyszko/events{/privacy}","received_events_url":"https://api.github.com/users/kubatyszko/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-12-16T21:48:05Z","updated_at":"2016-12-17T05:04:20Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/16319","html_url":"https://github.com/apache/spark/pull/16319","diff_url":"https://github.com/apache/spark/pull/16319.diff","patch_url":"https://github.com/apache/spark/pull/16319.patch"},"body":"## What changes were proposed in this pull request?\r\n\r\nCSV parser changes allowing parsing of numeric fields to fail and return null in such case.\r\nIn conjunction with \"nullValue\" option that may be used elsewhere this allows handling of certain csv sources that may use empty string as indication of null in one column and another specific value indicating null in another.\r\n\r\nCurrently the option \"nullValue\" can only be provided once and we can't assume that a data source won't have a single \"null\" indicator.\r\n\r\nThis problem is very similar to the one discussed here: https://github.com/databricks/spark-csv/issues/239\r\n\r\nSargis Dudaklayan and Kuba Tyszko - Zest Finance\r\n\r\n## How was this patch tested?\r\n\r\nThe patch was tested using freshly compiled spark version 2.0.1 on a sample data source that has \"null\" values in 2 columns, one specified as \"NA\" and set using nullValue and another column with \"\" indicating no integer value.\r\n\r\nPlease review http://spark.apache.org/contributing.html before opening a pull request.\r\n"},"comment":{"url":"https://api.github.com/repos/apache/spark/issues/comments/267743795","html_url":"https://github.com/apache/spark/pull/16319#issuecomment-267743795","issue_url":"https://api.github.com/repos/apache/spark/issues/16319","id":267743795,"user":{"login":"maropu","id":692303,"avatar_url":"https://avatars.githubusercontent.com/u/692303?v=3","gravatar_id":"","url":"https://api.github.com/users/maropu","html_url":"https://github.com/maropu","followers_url":"https://api.github.com/users/maropu/followers","following_url":"https://api.github.com/users/maropu/following{/other_user}","gists_url":"https://api.github.com/users/maropu/gists{/gist_id}","starred_url":"https://api.github.com/users/maropu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maropu/subscriptions","organizations_url":"https://api.github.com/users/maropu/orgs","repos_url":"https://api.github.com/users/maropu/repos","events_url":"https://api.github.com/users/maropu/events{/privacy}","received_events_url":"https://api.github.com/users/maropu/received_events","type":"User","site_admin":false},"created_at":"2016-12-17T05:04:20Z","updated_at":"2016-12-17T05:04:20Z","body":"@HyukjinKwon Thanks for your pinging! I left some comments."}}
{"actor":{"display_login":"maropu"}}