{"action":"created","issue":{"url":"https://api.github.com/repos/sarbbottam/eslint-find-rules/issues/202","repository_url":"https://api.github.com/repos/sarbbottam/eslint-find-rules","labels_url":"https://api.github.com/repos/sarbbottam/eslint-find-rules/issues/202/labels{/name}","comments_url":"https://api.github.com/repos/sarbbottam/eslint-find-rules/issues/202/comments","events_url":"https://api.github.com/repos/sarbbottam/eslint-find-rules/issues/202/events","html_url":"https://github.com/sarbbottam/eslint-find-rules/issues/202","id":186330456,"number":202,"title":"auto-merge and semantic release","user":{"login":"sarbbottam","id":949380,"avatar_url":"https://avatars.githubusercontent.com/u/949380?v=3","gravatar_id":"","url":"https://api.github.com/users/sarbbottam","html_url":"https://github.com/sarbbottam","followers_url":"https://api.github.com/users/sarbbottam/followers","following_url":"https://api.github.com/users/sarbbottam/following{/other_user}","gists_url":"https://api.github.com/users/sarbbottam/gists{/gist_id}","starred_url":"https://api.github.com/users/sarbbottam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarbbottam/subscriptions","organizations_url":"https://api.github.com/users/sarbbottam/orgs","repos_url":"https://api.github.com/users/sarbbottam/repos","events_url":"https://api.github.com/users/sarbbottam/events{/privacy}","received_events_url":"https://api.github.com/users/sarbbottam/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":12,"created_at":"2016-10-31T16:29:06Z","updated_at":"2016-11-03T17:37:30Z","closed_at":"2016-11-03T17:37:30Z","body":">@sarbbottam: Please don't approve it via GitHub means, otherwise, the PR will get merged\r\n\r\n>@ljharb: @sarbbottam i'd strongly caution against automerging on PR approval; i don't even think semantic-release is a safe idea.\r\n\r\n>@sarbbottam:@ljharb I guess I was wrong about auto-merging. It is not enabled. I had to merge #199 by myself.\r\n\r\n>>I'd strongly caution against auto-merging on PR approval; \r\n\r\n>Agreed\r\n\r\n>>semantic-release\r\n\r\n>Yea, it could be problematic sometimes, but has its benefits too. I am a bit biased but would be OK to let it go, if we all think so.\r\n\r\n>@ta2edchimp: So, is it safe to approve the requested changes? (I never worked with the review feature before ...)\r\n\r\n>>Re: auto merge on review approval\r\n\r\n>Can we assure this is not activated?\r\n\r\n>>Re: semantic release\r\n\r\n>Besides \"spamming\" with updates when lots of PRs would get merged within a short period of time, I see no problem in having automatic releases for this tool. But this is something we should discuss / evaluate in a separate issue."},"comment":{"url":"https://api.github.com/repos/sarbbottam/eslint-find-rules/issues/comments/258217198","html_url":"https://github.com/sarbbottam/eslint-find-rules/issues/202#issuecomment-258217198","issue_url":"https://api.github.com/repos/sarbbottam/eslint-find-rules/issues/202","id":258217198,"user":{"login":"sarbbottam","id":949380,"avatar_url":"https://avatars.githubusercontent.com/u/949380?v=3","gravatar_id":"","url":"https://api.github.com/users/sarbbottam","html_url":"https://github.com/sarbbottam","followers_url":"https://api.github.com/users/sarbbottam/followers","following_url":"https://api.github.com/users/sarbbottam/following{/other_user}","gists_url":"https://api.github.com/users/sarbbottam/gists{/gist_id}","starred_url":"https://api.github.com/users/sarbbottam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarbbottam/subscriptions","organizations_url":"https://api.github.com/users/sarbbottam/orgs","repos_url":"https://api.github.com/users/sarbbottam/repos","events_url":"https://api.github.com/users/sarbbottam/events{/privacy}","received_events_url":"https://api.github.com/users/sarbbottam/received_events","type":"User","site_admin":false},"created_at":"2016-11-03T17:37:30Z","updated_at":"2016-11-03T17:37:30Z","body":"@ta2edchimp you already have the publish rights. I added @ljharb too.\r\n\r\nI will raise a PR to take out `semantic-release` and add  [standard-version](https://github.com/conventional-changelog/standard-version) to the workflow (needs to be manually executed).\r\n\r\nClosing this ticket as we are good on the discussed approach. Please feel free to open the ticket should we need any further discussion."}}
{"actor":{"display_login":"sarbbottam"}}