{"action":"created","comment":{"url":"https://api.github.com/repos/w3c/webrtc-pc/pulls/comments/66972507","id":66972507,"diff_hunk":"@@ -3885,19 +3901,48 @@ <h2 id=\"sec.cert-mgmt\">Certificate Management</h2>\n                   </ul>\n                 </li>\n                 <li>\n-                  <p>If <var>sender</var> was left unset by the previous step,\n-                  create a new <code><a>RTCRtpTransceiver</a></code> with\n-                  <code>sender.track</code> set to <var>track</var>, add it to\n-                  <var>connection</var>'s set of transceivers.</p>\n-                  <p>Let <var>sender</var> be the\n-                  <code><a>RTCRtpSender</a></code> object associated with the\n-                  newly created <code><a>RTCRtpTransceiver</a></code>.</p>\n-                  <p>The initial value of an\n-                  <code><a>RTCRtpTransceiver</a></code>'s <code><a data-for=\n-                  \"RTCRtpTransceiver\">mid</a></code> attribute is null. Setting\n-                  a new <code><a>RTCSessionDescription</a></code> may change it\n-                  to a non-null value, as defined in <span data-jsep=\n-                  \"processing-a-local-desc processing-a-remote-desc\">[[!JSEP]]</span>.</p>\n+                  <p>If <var>sender</var> was set by the previous step, run the\n+                  following steps to use that sender:</p>\n+                  <ol>\n+                    <li>\n+                      <p>Set <var>sender.track</var> to <var>track</var>.</p>\n+                    </li>\n+                    <li>\n+                      <p>Set <var>sender</var>'s\n+                      [[<a>associated MediaStreams</a>]] to\n+                      <var>streams</var>.</p>\n+                    </li>\n+                    <li>\n+                      <p>Enable sending direction on the <code>\n+                      <a>RTCRtpTransceiver</a></code> associated with\n+                      <var>sender</var>.</p>\n+                    </li>\n+                  </ol>\n+                </li>\n+                <li>\n+                  <p>If <var>sender</var> is still unset (no sender could be\n+                  matched above), run the following steps:</p>","path":"webrtc.html","position":60,"original_position":60,"commit_id":"2852f0b3515acacdf80a6b125f96e5d2fa3ea608","original_commit_id":"2852f0b3515acacdf80a6b125f96e5d2fa3ea608","user":{"login":"jan-ivar","id":3136226,"avatar_url":"https://avatars.githubusercontent.com/u/3136226?v=3","gravatar_id":"","url":"https://api.github.com/users/jan-ivar","html_url":"https://github.com/jan-ivar","followers_url":"https://api.github.com/users/jan-ivar/followers","following_url":"https://api.github.com/users/jan-ivar/following{/other_user}","gists_url":"https://api.github.com/users/jan-ivar/gists{/gist_id}","starred_url":"https://api.github.com/users/jan-ivar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jan-ivar/subscriptions","organizations_url":"https://api.github.com/users/jan-ivar/orgs","repos_url":"https://api.github.com/users/jan-ivar/repos","events_url":"https://api.github.com/users/jan-ivar/events{/privacy}","received_events_url":"https://api.github.com/users/jan-ivar/received_events","type":"User","site_admin":false},"body":"*If* sender *is `null`, run the following steps:*","created_at":"2016-06-14T13:46:50Z","updated_at":"2016-06-14T13:46:50Z","html_url":"https://github.com/w3c/webrtc-pc/pull/702#discussion_r66972507","pull_request_url":"https://api.github.com/repos/w3c/webrtc-pc/pulls/702","_links":{"self":{"href":"https://api.github.com/repos/w3c/webrtc-pc/pulls/comments/66972507"},"html":{"href":"https://github.com/w3c/webrtc-pc/pull/702#discussion_r66972507"},"pull_request":{"href":"https://api.github.com/repos/w3c/webrtc-pc/pulls/702"}}},"pull_request":{"url":"https://api.github.com/repos/w3c/webrtc-pc/pulls/702","id":73689530,"html_url":"https://github.com/w3c/webrtc-pc/pull/702","diff_url":"https://github.com/w3c/webrtc-pc/pull/702.diff","patch_url":"https://github.com/w3c/webrtc-pc/pull/702.patch","issue_url":"https://api.github.com/repos/w3c/webrtc-pc/issues/702","number":702,"state":"open","locked":false,"title":"Define how to create RTCRtpSender/Receiver/Transceiver and let addTrack use them","user":{"login":"adam-be","id":1233205,"avatar_url":"https://avatars.githubusercontent.com/u/1233205?v=3","gravatar_id":"","url":"https://api.github.com/users/adam-be","html_url":"https://github.com/adam-be","followers_url":"https://api.github.com/users/adam-be/followers","following_url":"https://api.github.com/users/adam-be/following{/other_user}","gists_url":"https://api.github.com/users/adam-be/gists{/gist_id}","starred_url":"https://api.github.com/users/adam-be/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adam-be/subscriptions","organizations_url":"https://api.github.com/users/adam-be/orgs","repos_url":"https://api.github.com/users/adam-be/repos","events_url":"https://api.github.com/users/adam-be/events{/privacy}","received_events_url":"https://api.github.com/users/adam-be/received_events","type":"User","site_admin":false},"body":"Fixes: #369\r\n\r\nThis change adds steps to:\r\n* create an RTCRtpSender with a track and streams\r\n* create an RTCRtpReceiver with a kind (and id)\r\n* create an RTCRtpTransceiver with a sender and a receiver\r\n\r\naddTrack() uses these steps to create a new RTCRtpTransceiver (with a sender) if no existing sender could be matched. It also adds some text about configuring a matched sender (transceiver). The steps above can easily be extended to support the remote media case as well, for example by adding an mid \"argument\" to the 'create an RTCRtpTransceiver' steps.\r\n\r\nRendered preview: http://rawgit.com/adam-be/webrtc-pc/create-rtp-stuff/webrtc.html#dom-rtcpeerconnection-addtrack","created_at":"2016-06-14T07:04:54Z","updated_at":"2016-06-14T13:46:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7b91a427f6c04c92bedb8d610123253351723b2f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/w3c/webrtc-pc/pulls/702/commits","review_comments_url":"https://api.github.com/repos/w3c/webrtc-pc/pulls/702/comments","review_comment_url":"https://api.github.com/repos/w3c/webrtc-pc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/w3c/webrtc-pc/issues/702/comments","statuses_url":"https://api.github.com/repos/w3c/webrtc-pc/statuses/2852f0b3515acacdf80a6b125f96e5d2fa3ea608","head":{"label":"adam-be:create-rtp-stuff","ref":"create-rtp-stuff","sha":"2852f0b3515acacdf80a6b125f96e5d2fa3ea608","user":{"login":"adam-be","id":1233205,"avatar_url":"https://avatars.githubusercontent.com/u/1233205?v=3","gravatar_id":"","url":"https://api.github.com/users/adam-be","html_url":"https://github.com/adam-be","followers_url":"https://api.github.com/users/adam-be/followers","following_url":"https://api.github.com/users/adam-be/following{/other_user}","gists_url":"https://api.github.com/users/adam-be/gists{/gist_id}","starred_url":"https://api.github.com/users/adam-be/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adam-be/subscriptions","organizations_url":"https://api.github.com/users/adam-be/orgs","repos_url":"https://api.github.com/users/adam-be/repos","events_url":"https://api.github.com/users/adam-be/events{/privacy}","received_events_url":"https://api.github.com/users/adam-be/received_events","type":"User","site_admin":false},"repo":{"id":25730074,"name":"webrtc-pc","full_name":"adam-be/webrtc-pc","owner":{"login":"adam-be","id":1233205,"avatar_url":"https://avatars.githubusercontent.com/u/1233205?v=3","gravatar_id":"","url":"https://api.github.com/users/adam-be","html_url":"https://github.com/adam-be","followers_url":"https://api.github.com/users/adam-be/followers","following_url":"https://api.github.com/users/adam-be/following{/other_user}","gists_url":"https://api.github.com/users/adam-be/gists{/gist_id}","starred_url":"https://api.github.com/users/adam-be/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adam-be/subscriptions","organizations_url":"https://api.github.com/users/adam-be/orgs","repos_url":"https://api.github.com/users/adam-be/repos","events_url":"https://api.github.com/users/adam-be/events{/privacy}","received_events_url":"https://api.github.com/users/adam-be/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/adam-be/webrtc-pc","description":"WebRTC 1.0 API","fork":true,"url":"https://api.github.com/repos/adam-be/webrtc-pc","forks_url":"https://api.github.com/repos/adam-be/webrtc-pc/forks","keys_url":"https://api.github.com/repos/adam-be/webrtc-pc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adam-be/webrtc-pc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adam-be/webrtc-pc/teams","hooks_url":"https://api.github.com/repos/adam-be/webrtc-pc/hooks","issue_events_url":"https://api.github.com/repos/adam-be/webrtc-pc/issues/events{/number}","events_url":"https://api.github.com/repos/adam-be/webrtc-pc/events","assignees_url":"https://api.github.com/repos/adam-be/webrtc-pc/assignees{/user}","branches_url":"https://api.github.com/repos/adam-be/webrtc-pc/branches{/branch}","tags_url":"https://api.github.com/repos/adam-be/webrtc-pc/tags","blobs_url":"https://api.github.com/repos/adam-be/webrtc-pc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adam-be/webrtc-pc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adam-be/webrtc-pc/git/refs{/sha}","trees_url":"https://api.github.com/repos/adam-be/webrtc-pc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adam-be/webrtc-pc/statuses/{sha}","languages_url":"https://api.github.com/repos/adam-be/webrtc-pc/languages","stargazers_url":"https://api.github.com/repos/adam-be/webrtc-pc/stargazers","contributors_url":"https://api.github.com/repos/adam-be/webrtc-pc/contributors","subscribers_url":"https://api.github.com/repos/adam-be/webrtc-pc/subscribers","subscription_url":"https://api.github.com/repos/adam-be/webrtc-pc/subscription","commits_url":"https://api.github.com/repos/adam-be/webrtc-pc/commits{/sha}","git_commits_url":"https://api.github.com/repos/adam-be/webrtc-pc/git/commits{/sha}","comments_url":"https://api.github.com/repos/adam-be/webrtc-pc/comments{/number}","issue_comment_url":"https://api.github.com/repos/adam-be/webrtc-pc/issues/comments{/number}","contents_url":"https://api.github.com/repos/adam-be/webrtc-pc/contents/{+path}","compare_url":"https://api.github.com/repos/adam-be/webrtc-pc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adam-be/webrtc-pc/merges","archive_url":"https://api.github.com/repos/adam-be/webrtc-pc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adam-be/webrtc-pc/downloads","issues_url":"https://api.github.com/repos/adam-be/webrtc-pc/issues{/number}","pulls_url":"https://api.github.com/repos/adam-be/webrtc-pc/pulls{/number}","milestones_url":"https://api.github.com/repos/adam-be/webrtc-pc/milestones{/number}","notifications_url":"https://api.github.com/repos/adam-be/webrtc-pc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adam-be/webrtc-pc/labels{/name}","releases_url":"https://api.github.com/repos/adam-be/webrtc-pc/releases{/id}","deployments_url":"https://api.github.com/repos/adam-be/webrtc-pc/deployments","created_at":"2014-10-25T12:03:40Z","updated_at":"2014-10-07T10:20:34Z","pushed_at":"2016-06-14T08:52:15Z","git_url":"git://github.com/adam-be/webrtc-pc.git","ssh_url":"git@github.com:adam-be/webrtc-pc.git","clone_url":"https://github.com/adam-be/webrtc-pc.git","svn_url":"https://github.com/adam-be/webrtc-pc","homepage":null,"size":15565,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"w3c:master","ref":"master","sha":"b0f89800eccae41c9e9f7def5f74a6c7af70ee36","user":{"login":"w3c","id":379216,"avatar_url":"https://avatars.githubusercontent.com/u/379216?v=3","gravatar_id":"","url":"https://api.github.com/users/w3c","html_url":"https://github.com/w3c","followers_url":"https://api.github.com/users/w3c/followers","following_url":"https://api.github.com/users/w3c/following{/other_user}","gists_url":"https://api.github.com/users/w3c/gists{/gist_id}","starred_url":"https://api.github.com/users/w3c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w3c/subscriptions","organizations_url":"https://api.github.com/users/w3c/orgs","repos_url":"https://api.github.com/users/w3c/repos","events_url":"https://api.github.com/users/w3c/events{/privacy}","received_events_url":"https://api.github.com/users/w3c/received_events","type":"Organization","site_admin":false},"repo":{"id":23384500,"name":"webrtc-pc","full_name":"w3c/webrtc-pc","owner":{"login":"w3c","id":379216,"avatar_url":"https://avatars.githubusercontent.com/u/379216?v=3","gravatar_id":"","url":"https://api.github.com/users/w3c","html_url":"https://github.com/w3c","followers_url":"https://api.github.com/users/w3c/followers","following_url":"https://api.github.com/users/w3c/following{/other_user}","gists_url":"https://api.github.com/users/w3c/gists{/gist_id}","starred_url":"https://api.github.com/users/w3c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w3c/subscriptions","organizations_url":"https://api.github.com/users/w3c/orgs","repos_url":"https://api.github.com/users/w3c/repos","events_url":"https://api.github.com/users/w3c/events{/privacy}","received_events_url":"https://api.github.com/users/w3c/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/w3c/webrtc-pc","description":"WebRTC 1.0 API","fork":false,"url":"https://api.github.com/repos/w3c/webrtc-pc","forks_url":"https://api.github.com/repos/w3c/webrtc-pc/forks","keys_url":"https://api.github.com/repos/w3c/webrtc-pc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/w3c/webrtc-pc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/w3c/webrtc-pc/teams","hooks_url":"https://api.github.com/repos/w3c/webrtc-pc/hooks","issue_events_url":"https://api.github.com/repos/w3c/webrtc-pc/issues/events{/number}","events_url":"https://api.github.com/repos/w3c/webrtc-pc/events","assignees_url":"https://api.github.com/repos/w3c/webrtc-pc/assignees{/user}","branches_url":"https://api.github.com/repos/w3c/webrtc-pc/branches{/branch}","tags_url":"https://api.github.com/repos/w3c/webrtc-pc/tags","blobs_url":"https://api.github.com/repos/w3c/webrtc-pc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/w3c/webrtc-pc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/w3c/webrtc-pc/git/refs{/sha}","trees_url":"https://api.github.com/repos/w3c/webrtc-pc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/w3c/webrtc-pc/statuses/{sha}","languages_url":"https://api.github.com/repos/w3c/webrtc-pc/languages","stargazers_url":"https://api.github.com/repos/w3c/webrtc-pc/stargazers","contributors_url":"https://api.github.com/repos/w3c/webrtc-pc/contributors","subscribers_url":"https://api.github.com/repos/w3c/webrtc-pc/subscribers","subscription_url":"https://api.github.com/repos/w3c/webrtc-pc/subscription","commits_url":"https://api.github.com/repos/w3c/webrtc-pc/commits{/sha}","git_commits_url":"https://api.github.com/repos/w3c/webrtc-pc/git/commits{/sha}","comments_url":"https://api.github.com/repos/w3c/webrtc-pc/comments{/number}","issue_comment_url":"https://api.github.com/repos/w3c/webrtc-pc/issues/comments{/number}","contents_url":"https://api.github.com/repos/w3c/webrtc-pc/contents/{+path}","compare_url":"https://api.github.com/repos/w3c/webrtc-pc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/w3c/webrtc-pc/merges","archive_url":"https://api.github.com/repos/w3c/webrtc-pc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/w3c/webrtc-pc/downloads","issues_url":"https://api.github.com/repos/w3c/webrtc-pc/issues{/number}","pulls_url":"https://api.github.com/repos/w3c/webrtc-pc/pulls{/number}","milestones_url":"https://api.github.com/repos/w3c/webrtc-pc/milestones{/number}","notifications_url":"https://api.github.com/repos/w3c/webrtc-pc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/w3c/webrtc-pc/labels{/name}","releases_url":"https://api.github.com/repos/w3c/webrtc-pc/releases{/id}","deployments_url":"https://api.github.com/repos/w3c/webrtc-pc/deployments","created_at":"2014-08-27T09:39:00Z","updated_at":"2016-06-13T19:00:22Z","pushed_at":"2016-06-14T08:54:21Z","git_url":"git://github.com/w3c/webrtc-pc.git","ssh_url":"git@github.com:w3c/webrtc-pc.git","clone_url":"https://github.com/w3c/webrtc-pc.git","svn_url":"https://github.com/w3c/webrtc-pc","homepage":null,"size":17414,"stargazers_count":85,"watchers_count":85,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":41,"mirror_url":null,"open_issues_count":49,"forks":41,"open_issues":49,"watchers":85,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/w3c/webrtc-pc/pulls/702"},"html":{"href":"https://github.com/w3c/webrtc-pc/pull/702"},"issue":{"href":"https://api.github.com/repos/w3c/webrtc-pc/issues/702"},"comments":{"href":"https://api.github.com/repos/w3c/webrtc-pc/issues/702/comments"},"review_comments":{"href":"https://api.github.com/repos/w3c/webrtc-pc/pulls/702/comments"},"review_comment":{"href":"https://api.github.com/repos/w3c/webrtc-pc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/w3c/webrtc-pc/pulls/702/commits"},"statuses":{"href":"https://api.github.com/repos/w3c/webrtc-pc/statuses/2852f0b3515acacdf80a6b125f96e5d2fa3ea608"}}}}
{"actor":{"display_login":"jan-ivar"}}