{"action":"created","issue":{"url":"https://api.github.com/repos/lyft/envoy/issues/98","repository_url":"https://api.github.com/repos/lyft/envoy","labels_url":"https://api.github.com/repos/lyft/envoy/issues/98/labels{/name}","comments_url":"https://api.github.com/repos/lyft/envoy/issues/98/comments","events_url":"https://api.github.com/repos/lyft/envoy/issues/98/events","html_url":"https://github.com/lyft/envoy/pull/98","id":178997232,"number":98,"title":"Lightstep gPRC generation for tracing *NOT YET FOR REVIEW*","user":{"login":"RomanDzhabarov","id":15094284,"avatar_url":"https://avatars.githubusercontent.com/u/15094284?v=3","gravatar_id":"","url":"https://api.github.com/users/RomanDzhabarov","html_url":"https://github.com/RomanDzhabarov","followers_url":"https://api.github.com/users/RomanDzhabarov/followers","following_url":"https://api.github.com/users/RomanDzhabarov/following{/other_user}","gists_url":"https://api.github.com/users/RomanDzhabarov/gists{/gist_id}","starred_url":"https://api.github.com/users/RomanDzhabarov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RomanDzhabarov/subscriptions","organizations_url":"https://api.github.com/users/RomanDzhabarov/orgs","repos_url":"https://api.github.com/users/RomanDzhabarov/repos","events_url":"https://api.github.com/users/RomanDzhabarov/events{/privacy}","received_events_url":"https://api.github.com/users/RomanDzhabarov/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-09-24T00:04:17Z","updated_at":"2016-09-27T15:46:52Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/lyft/envoy/pulls/98","html_url":"https://github.com/lyft/envoy/pull/98","diff_url":"https://github.com/lyft/envoy/pull/98.diff","patch_url":"https://github.com/lyft/envoy/pull/98.patch"},"body":"Most of the parts are there, there are few things missing:\r\n0) Figure out build failure in public\r\n1) New code needs test coverage\r\n\r\n2) Right now we make gRPC call only when buffer is full, for the first iteration I'd like to keep it this way, but we might need flush thread to flush traces for low rps services"},"comment":{"url":"https://api.github.com/repos/lyft/envoy/issues/comments/249906402","html_url":"https://github.com/lyft/envoy/pull/98#issuecomment-249906402","issue_url":"https://api.github.com/repos/lyft/envoy/issues/98","id":249906402,"user":{"login":"mattklein123","id":6305260,"avatar_url":"https://avatars.githubusercontent.com/u/6305260?v=3","gravatar_id":"","url":"https://api.github.com/users/mattklein123","html_url":"https://github.com/mattklein123","followers_url":"https://api.github.com/users/mattklein123/followers","following_url":"https://api.github.com/users/mattklein123/following{/other_user}","gists_url":"https://api.github.com/users/mattklein123/gists{/gist_id}","starred_url":"https://api.github.com/users/mattklein123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattklein123/subscriptions","organizations_url":"https://api.github.com/users/mattklein123/orgs","repos_url":"https://api.github.com/users/mattklein123/repos","events_url":"https://api.github.com/users/mattklein123/events{/privacy}","received_events_url":"https://api.github.com/users/mattklein123/received_events","type":"User","site_admin":false},"created_at":"2016-09-27T15:46:52Z","updated_at":"2016-09-27T15:46:52Z","body":"@RomanDzhabarov there are some more nits and a bunch of things to clean up (which you probably already know about) but in general looks like the right direction. I will wait until you have it more complete with tests then will look again. "}}
{"actor":{"display_login":"mattklein123"}}