{"action":"created","issue":{"url":"https://api.github.com/repos/apache/flink/issues/1536","labels_url":"https://api.github.com/repos/apache/flink/issues/1536/labels{/name}","comments_url":"https://api.github.com/repos/apache/flink/issues/1536/comments","events_url":"https://api.github.com/repos/apache/flink/issues/1536/events","html_url":"https://github.com/apache/flink/pull/1536","id":127906997,"number":1536,"title":"[FLINK-2021] Rework examples to use ParameterTool (K-Means)","user":{"login":"stefanobaghino","id":1374489,"avatar_url":"https://avatars.githubusercontent.com/u/1374489?v=3","gravatar_id":"","url":"https://api.github.com/users/stefanobaghino","html_url":"https://github.com/stefanobaghino","followers_url":"https://api.github.com/users/stefanobaghino/followers","following_url":"https://api.github.com/users/stefanobaghino/following{/other_user}","gists_url":"https://api.github.com/users/stefanobaghino/gists{/gist_id}","starred_url":"https://api.github.com/users/stefanobaghino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefanobaghino/subscriptions","organizations_url":"https://api.github.com/users/stefanobaghino/orgs","repos_url":"https://api.github.com/users/stefanobaghino/repos","events_url":"https://api.github.com/users/stefanobaghino/events{/privacy}","received_events_url":"https://api.github.com/users/stefanobaghino/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-01-21T11:47:43Z","updated_at":"2016-01-21T15:47:56Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/flink/pulls/1536","html_url":"https://github.com/apache/flink/pull/1536","diff_url":"https://github.com/apache/flink/pull/1536.diff","patch_url":"https://github.com/apache/flink/pull/1536.patch"},"body":"I've reworked the K-Means examples in Java and Scala to get a feeling of what it would mean on the whole examples code base. Just a remark: I've caught the `RequiredParametersException` on the requirements application but not on their definition because I've felt the errors are different in nature (the application depends on user input while the definition should be somehow caught sooner — it would be great to have a way to catch it at compile-time)."},"comment":{"url":"https://api.github.com/repos/apache/flink/issues/comments/173612372","html_url":"https://github.com/apache/flink/pull/1536#issuecomment-173612372","issue_url":"https://api.github.com/repos/apache/flink/issues/1536","id":173612372,"user":{"login":"uce","id":1756620,"avatar_url":"https://avatars.githubusercontent.com/u/1756620?v=3","gravatar_id":"","url":"https://api.github.com/users/uce","html_url":"https://github.com/uce","followers_url":"https://api.github.com/users/uce/followers","following_url":"https://api.github.com/users/uce/following{/other_user}","gists_url":"https://api.github.com/users/uce/gists{/gist_id}","starred_url":"https://api.github.com/users/uce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uce/subscriptions","organizations_url":"https://api.github.com/users/uce/orgs","repos_url":"https://api.github.com/users/uce/repos","events_url":"https://api.github.com/users/uce/events{/privacy}","received_events_url":"https://api.github.com/users/uce/received_events","type":"User","site_admin":false},"created_at":"2016-01-21T15:47:56Z","updated_at":"2016-01-21T15:47:56Z","body":"Nice to see it reworked. Thanks for the contribution. I think Robert raises a good point with the readability improvements though. I would be in favour of Robert's take on the ParameterTool. ;)"}}