{"action":"created","comment":{"url":"https://api.github.com/repos/LLNL/RAJA/pulls/comments/92483563","pull_request_review_id":13000251,"id":92483563,"diff_hunk":"@@ -0,0 +1,85 @@\n+macro(raja_add_executable)\n+\n+  set(options )\n+  set(singleValueArgs NAME)\n+  set(multiValueArgs SOURCES DEPENDS_ON)\n+\n+  cmake_parse_arguments(arg\n+    \"${options}\" \"${singleValueArgs}\" \"${multiValueArgs}\" ${ARGN})\n+\n+  if (RAJA_ENABLE_CUDA) \n+    if (RAJA_ENABLE_CLANG_CUDA) \n+      add_executable(${arg_NAME} ${arg_SOURCES})\n+      target_compile_options(${arg_NAME} PRIVATE \n+        -x cuda --cuda-gpu-arch=sm_35 --cuda-path=${CUDA_TOOLKIT_ROOT_DIR})\n+      target_include_directories(${arg_NAME} \n+        PUBLIC ${EXPT_CUDA_INCLUDE_LOCATION})\n+      target_link_libraries(${arg_NAME} ${CUDA_LIBRARIES} RAJA ${arg_DEPENDS_ON})\n+    else ()\n+      set_source_files_properties(\n+        ${arg_SOURCES}\n+        PROPERTIES\n+        CUDA_SOURCE_PROPERTY_FORMAT OBJ)\n+      cuda_add_executable(${arg_NAME} ${arg_SOURCES})\n+      target_link_libraries(${arg_NAME} RAJA ${arg_DEPENDS_ON})\n+    endif()\n+  else ()\n+    add_executable(${arg_NAME} ${arg_DEPENDS_ON})\n+    target_link_libraries(${arg_NAME} RAJA ${arg_DEPENDS_ON})\n+  endif()\n+endmacro(raja_add_executable)\n+\n+macro(raja_add_library)\n+  set(options )\n+  set(singleValueArgs NAME)\n+  set(multiValueArgs SOURCES DEPENDS_ON)\n+\n+  cmake_parse_arguments(arg\n+    \"${options}\" \"${singleValueArgs}\" \"${multiValueArgs}\" ${ARGN})\n+\n+  if (RAJA_ENABLE_CUDA)\n+    if (RAJA_ENABLE_CLANG_CUDA)\n+\n+      add_library(${arg_NAME} ${arg_SOURCES})\n+      target_compile_options(${arg_NAME} PRIVATE \n+        -x cuda --cuda-gpu-arch=sm_35 --cuda-path=${CUDA_TOOLKIT_ROOT_DIR})","path":"cmake/RAJAMacros.cmake","position":45,"original_position":45,"commit_id":"29211af20a565fae32f447c2573665d7334282be","original_commit_id":"29211af20a565fae32f447c2573665d7334282be","user":{"login":"davidbeckingsale","id":334483,"avatar_url":"https://avatars.githubusercontent.com/u/334483?v=3","gravatar_id":"","url":"https://api.github.com/users/davidbeckingsale","html_url":"https://github.com/davidbeckingsale","followers_url":"https://api.github.com/users/davidbeckingsale/followers","following_url":"https://api.github.com/users/davidbeckingsale/following{/other_user}","gists_url":"https://api.github.com/users/davidbeckingsale/gists{/gist_id}","starred_url":"https://api.github.com/users/davidbeckingsale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidbeckingsale/subscriptions","organizations_url":"https://api.github.com/users/davidbeckingsale/orgs","repos_url":"https://api.github.com/users/davidbeckingsale/repos","events_url":"https://api.github.com/users/davidbeckingsale/events{/privacy}","received_events_url":"https://api.github.com/users/davidbeckingsale/received_events","type":"User","site_admin":false},"body":"👍 ","created_at":"2016-12-14T20:36:32Z","updated_at":"2016-12-14T20:36:32Z","html_url":"https://github.com/LLNL/RAJA/pull/136#discussion_r92483563","pull_request_url":"https://api.github.com/repos/LLNL/RAJA/pulls/136","_links":{"self":{"href":"https://api.github.com/repos/LLNL/RAJA/pulls/comments/92483563"},"html":{"href":"https://github.com/LLNL/RAJA/pull/136#discussion_r92483563"},"pull_request":{"href":"https://api.github.com/repos/LLNL/RAJA/pulls/136"}}},"pull_request":{"url":"https://api.github.com/repos/LLNL/RAJA/pulls/136","id":90706268,"html_url":"https://github.com/LLNL/RAJA/pull/136","diff_url":"https://github.com/LLNL/RAJA/pull/136.diff","patch_url":"https://github.com/LLNL/RAJA/pull/136.patch","issue_url":"https://api.github.com/repos/LLNL/RAJA/issues/136","number":136,"state":"open","locked":false,"title":"Initial commit of clang CUDA support","user":{"login":"davidbeckingsale","id":334483,"avatar_url":"https://avatars.githubusercontent.com/u/334483?v=3","gravatar_id":"","url":"https://api.github.com/users/davidbeckingsale","html_url":"https://github.com/davidbeckingsale","followers_url":"https://api.github.com/users/davidbeckingsale/followers","following_url":"https://api.github.com/users/davidbeckingsale/following{/other_user}","gists_url":"https://api.github.com/users/davidbeckingsale/gists{/gist_id}","starred_url":"https://api.github.com/users/davidbeckingsale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidbeckingsale/subscriptions","organizations_url":"https://api.github.com/users/davidbeckingsale/orgs","repos_url":"https://api.github.com/users/davidbeckingsale/repos","events_url":"https://api.github.com/users/davidbeckingsale/events{/privacy}","received_events_url":"https://api.github.com/users/davidbeckingsale/received_events","type":"User","site_admin":false},"body":"This commit adds support for building with Clang CUDA, but with some caveats:\n1. `RAJA_ENABLE_SCAN` has been added to allow us to conditionally disable scans. We were running into issues building thrust code with clang.\n2. Code compiled with `RAJA_ENABLE_NESTED` (e.g. the nested unit test) doesn't work. There is an error in the index calculations through the ForallN execution policies.\n\nTo build, just pass `-DRAJA_ENABLE_CLANG_CUDA=On -DRAJA_ENABLE_SCAN=Off` to the cmake line, specifying a new build of clang as the C and C++ compiler.\n","created_at":"2016-10-24T22:36:13Z","updated_at":"2016-12-14T20:36:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b98d761ca254d7ece4619b33c3e7bab263067b92","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/LLNL/RAJA/pulls/136/commits","review_comments_url":"https://api.github.com/repos/LLNL/RAJA/pulls/136/comments","review_comment_url":"https://api.github.com/repos/LLNL/RAJA/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LLNL/RAJA/issues/136/comments","statuses_url":"https://api.github.com/repos/LLNL/RAJA/statuses/29211af20a565fae32f447c2573665d7334282be","head":{"label":"LLNL:feature/clang-cuda","ref":"feature/clang-cuda","sha":"29211af20a565fae32f447c2573665d7334282be","user":{"login":"LLNL","id":5921419,"avatar_url":"https://avatars.githubusercontent.com/u/5921419?v=3","gravatar_id":"","url":"https://api.github.com/users/LLNL","html_url":"https://github.com/LLNL","followers_url":"https://api.github.com/users/LLNL/followers","following_url":"https://api.github.com/users/LLNL/following{/other_user}","gists_url":"https://api.github.com/users/LLNL/gists{/gist_id}","starred_url":"https://api.github.com/users/LLNL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LLNL/subscriptions","organizations_url":"https://api.github.com/users/LLNL/orgs","repos_url":"https://api.github.com/users/LLNL/repos","events_url":"https://api.github.com/users/LLNL/events{/privacy}","received_events_url":"https://api.github.com/users/LLNL/received_events","type":"Organization","site_admin":false},"repo":{"id":57340960,"name":"RAJA","full_name":"LLNL/RAJA","owner":{"login":"LLNL","id":5921419,"avatar_url":"https://avatars.githubusercontent.com/u/5921419?v=3","gravatar_id":"","url":"https://api.github.com/users/LLNL","html_url":"https://github.com/LLNL","followers_url":"https://api.github.com/users/LLNL/followers","following_url":"https://api.github.com/users/LLNL/following{/other_user}","gists_url":"https://api.github.com/users/LLNL/gists{/gist_id}","starred_url":"https://api.github.com/users/LLNL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LLNL/subscriptions","organizations_url":"https://api.github.com/users/LLNL/orgs","repos_url":"https://api.github.com/users/LLNL/repos","events_url":"https://api.github.com/users/LLNL/events{/privacy}","received_events_url":"https://api.github.com/users/LLNL/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LLNL/RAJA","description":"RAJA Performance Portability Layer","fork":false,"url":"https://api.github.com/repos/LLNL/RAJA","forks_url":"https://api.github.com/repos/LLNL/RAJA/forks","keys_url":"https://api.github.com/repos/LLNL/RAJA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LLNL/RAJA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LLNL/RAJA/teams","hooks_url":"https://api.github.com/repos/LLNL/RAJA/hooks","issue_events_url":"https://api.github.com/repos/LLNL/RAJA/issues/events{/number}","events_url":"https://api.github.com/repos/LLNL/RAJA/events","assignees_url":"https://api.github.com/repos/LLNL/RAJA/assignees{/user}","branches_url":"https://api.github.com/repos/LLNL/RAJA/branches{/branch}","tags_url":"https://api.github.com/repos/LLNL/RAJA/tags","blobs_url":"https://api.github.com/repos/LLNL/RAJA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LLNL/RAJA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LLNL/RAJA/git/refs{/sha}","trees_url":"https://api.github.com/repos/LLNL/RAJA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LLNL/RAJA/statuses/{sha}","languages_url":"https://api.github.com/repos/LLNL/RAJA/languages","stargazers_url":"https://api.github.com/repos/LLNL/RAJA/stargazers","contributors_url":"https://api.github.com/repos/LLNL/RAJA/contributors","subscribers_url":"https://api.github.com/repos/LLNL/RAJA/subscribers","subscription_url":"https://api.github.com/repos/LLNL/RAJA/subscription","commits_url":"https://api.github.com/repos/LLNL/RAJA/commits{/sha}","git_commits_url":"https://api.github.com/repos/LLNL/RAJA/git/commits{/sha}","comments_url":"https://api.github.com/repos/LLNL/RAJA/comments{/number}","issue_comment_url":"https://api.github.com/repos/LLNL/RAJA/issues/comments{/number}","contents_url":"https://api.github.com/repos/LLNL/RAJA/contents/{+path}","compare_url":"https://api.github.com/repos/LLNL/RAJA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LLNL/RAJA/merges","archive_url":"https://api.github.com/repos/LLNL/RAJA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LLNL/RAJA/downloads","issues_url":"https://api.github.com/repos/LLNL/RAJA/issues{/number}","pulls_url":"https://api.github.com/repos/LLNL/RAJA/pulls{/number}","milestones_url":"https://api.github.com/repos/LLNL/RAJA/milestones{/number}","notifications_url":"https://api.github.com/repos/LLNL/RAJA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LLNL/RAJA/labels{/name}","releases_url":"https://api.github.com/repos/LLNL/RAJA/releases{/id}","deployments_url":"https://api.github.com/repos/LLNL/RAJA/deployments","created_at":"2016-04-28T23:46:22Z","updated_at":"2016-12-05T10:44:12Z","pushed_at":"2016-12-14T20:25:11Z","git_url":"git://github.com/LLNL/RAJA.git","ssh_url":"git@github.com:LLNL/RAJA.git","clone_url":"https://github.com/LLNL/RAJA.git","svn_url":"https://github.com/LLNL/RAJA","homepage":null,"size":13616,"stargazers_count":29,"watchers_count":29,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":12,"mirror_url":null,"open_issues_count":50,"forks":12,"open_issues":50,"watchers":29,"default_branch":"master"}},"base":{"label":"LLNL:develop","ref":"develop","sha":"7f55d9dc106b7fcbe4f5d9a0a38fe86c06d619f3","user":{"login":"LLNL","id":5921419,"avatar_url":"https://avatars.githubusercontent.com/u/5921419?v=3","gravatar_id":"","url":"https://api.github.com/users/LLNL","html_url":"https://github.com/LLNL","followers_url":"https://api.github.com/users/LLNL/followers","following_url":"https://api.github.com/users/LLNL/following{/other_user}","gists_url":"https://api.github.com/users/LLNL/gists{/gist_id}","starred_url":"https://api.github.com/users/LLNL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LLNL/subscriptions","organizations_url":"https://api.github.com/users/LLNL/orgs","repos_url":"https://api.github.com/users/LLNL/repos","events_url":"https://api.github.com/users/LLNL/events{/privacy}","received_events_url":"https://api.github.com/users/LLNL/received_events","type":"Organization","site_admin":false},"repo":{"id":57340960,"name":"RAJA","full_name":"LLNL/RAJA","owner":{"login":"LLNL","id":5921419,"avatar_url":"https://avatars.githubusercontent.com/u/5921419?v=3","gravatar_id":"","url":"https://api.github.com/users/LLNL","html_url":"https://github.com/LLNL","followers_url":"https://api.github.com/users/LLNL/followers","following_url":"https://api.github.com/users/LLNL/following{/other_user}","gists_url":"https://api.github.com/users/LLNL/gists{/gist_id}","starred_url":"https://api.github.com/users/LLNL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LLNL/subscriptions","organizations_url":"https://api.github.com/users/LLNL/orgs","repos_url":"https://api.github.com/users/LLNL/repos","events_url":"https://api.github.com/users/LLNL/events{/privacy}","received_events_url":"https://api.github.com/users/LLNL/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LLNL/RAJA","description":"RAJA Performance Portability Layer","fork":false,"url":"https://api.github.com/repos/LLNL/RAJA","forks_url":"https://api.github.com/repos/LLNL/RAJA/forks","keys_url":"https://api.github.com/repos/LLNL/RAJA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LLNL/RAJA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LLNL/RAJA/teams","hooks_url":"https://api.github.com/repos/LLNL/RAJA/hooks","issue_events_url":"https://api.github.com/repos/LLNL/RAJA/issues/events{/number}","events_url":"https://api.github.com/repos/LLNL/RAJA/events","assignees_url":"https://api.github.com/repos/LLNL/RAJA/assignees{/user}","branches_url":"https://api.github.com/repos/LLNL/RAJA/branches{/branch}","tags_url":"https://api.github.com/repos/LLNL/RAJA/tags","blobs_url":"https://api.github.com/repos/LLNL/RAJA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LLNL/RAJA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LLNL/RAJA/git/refs{/sha}","trees_url":"https://api.github.com/repos/LLNL/RAJA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LLNL/RAJA/statuses/{sha}","languages_url":"https://api.github.com/repos/LLNL/RAJA/languages","stargazers_url":"https://api.github.com/repos/LLNL/RAJA/stargazers","contributors_url":"https://api.github.com/repos/LLNL/RAJA/contributors","subscribers_url":"https://api.github.com/repos/LLNL/RAJA/subscribers","subscription_url":"https://api.github.com/repos/LLNL/RAJA/subscription","commits_url":"https://api.github.com/repos/LLNL/RAJA/commits{/sha}","git_commits_url":"https://api.github.com/repos/LLNL/RAJA/git/commits{/sha}","comments_url":"https://api.github.com/repos/LLNL/RAJA/comments{/number}","issue_comment_url":"https://api.github.com/repos/LLNL/RAJA/issues/comments{/number}","contents_url":"https://api.github.com/repos/LLNL/RAJA/contents/{+path}","compare_url":"https://api.github.com/repos/LLNL/RAJA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LLNL/RAJA/merges","archive_url":"https://api.github.com/repos/LLNL/RAJA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LLNL/RAJA/downloads","issues_url":"https://api.github.com/repos/LLNL/RAJA/issues{/number}","pulls_url":"https://api.github.com/repos/LLNL/RAJA/pulls{/number}","milestones_url":"https://api.github.com/repos/LLNL/RAJA/milestones{/number}","notifications_url":"https://api.github.com/repos/LLNL/RAJA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LLNL/RAJA/labels{/name}","releases_url":"https://api.github.com/repos/LLNL/RAJA/releases{/id}","deployments_url":"https://api.github.com/repos/LLNL/RAJA/deployments","created_at":"2016-04-28T23:46:22Z","updated_at":"2016-12-05T10:44:12Z","pushed_at":"2016-12-14T20:25:11Z","git_url":"git://github.com/LLNL/RAJA.git","ssh_url":"git@github.com:LLNL/RAJA.git","clone_url":"https://github.com/LLNL/RAJA.git","svn_url":"https://github.com/LLNL/RAJA","homepage":null,"size":13616,"stargazers_count":29,"watchers_count":29,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":12,"mirror_url":null,"open_issues_count":50,"forks":12,"open_issues":50,"watchers":29,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/LLNL/RAJA/pulls/136"},"html":{"href":"https://github.com/LLNL/RAJA/pull/136"},"issue":{"href":"https://api.github.com/repos/LLNL/RAJA/issues/136"},"comments":{"href":"https://api.github.com/repos/LLNL/RAJA/issues/136/comments"},"review_comments":{"href":"https://api.github.com/repos/LLNL/RAJA/pulls/136/comments"},"review_comment":{"href":"https://api.github.com/repos/LLNL/RAJA/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LLNL/RAJA/pulls/136/commits"},"statuses":{"href":"https://api.github.com/repos/LLNL/RAJA/statuses/29211af20a565fae32f447c2573665d7334282be"}}}}
{"actor":{"display_login":"davidbeckingsale"}}