{"action":"closed","number":28,"pull_request":{"url":"https://api.github.com/repos/Datomic/simulant/pulls/28","id":57133990,"html_url":"https://github.com/Datomic/simulant/pull/28","diff_url":"https://github.com/Datomic/simulant/pull/28.diff","patch_url":"https://github.com/Datomic/simulant/pull/28.patch","issue_url":"https://api.github.com/repos/Datomic/simulant/issues/28","number":28,"state":"closed","locked":false,"title":"Add HTTP client library","user":{"login":"daemianmack","id":24476,"avatar_url":"https://avatars.githubusercontent.com/u/24476?v=3","gravatar_id":"","url":"https://api.github.com/users/daemianmack","html_url":"https://github.com/daemianmack","followers_url":"https://api.github.com/users/daemianmack/followers","following_url":"https://api.github.com/users/daemianmack/following{/other_user}","gists_url":"https://api.github.com/users/daemianmack/gists{/gist_id}","starred_url":"https://api.github.com/users/daemianmack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daemianmack/subscriptions","organizations_url":"https://api.github.com/users/daemianmack/orgs","repos_url":"https://api.github.com/users/daemianmack/repos","events_url":"https://api.github.com/users/daemianmack/events{/privacy}","received_events_url":"https://api.github.com/users/daemianmack/received_events","type":"User","site_admin":false},"body":"This PR depends on [PR 25](https://github.com/Datomic/simulant/pull/25).\r\n\r\n#### Concerns purportedly addressed herein\r\n##### General facilities\r\n- The `simulant.http` namespace provides direct access to a bare-bones HTTP client.\r\n- The `simulant.client` namespace provides a number of individual middlewares as well as a composed stack of them in `simulant.client/create`.\r\n- All middleware should be optional, and composing application-specific middleware stacks should be straight-forward.\r\n\r\n##### HTTP logging middleware\r\n- `simulant.client/wrap-action-log`\r\n- Action-logs the HTTP request and response.\r\n- Logging can be opted out of via a `:skip-logging?` key on the request.\r\n\r\n##### Retry middleware\r\n- `simulant.client/wrap-retries`\r\n- Retries are opt-in and controlled via a `:retry` key on the request.\r\n- Retries are logged by virtue of the middleware wrapping `wrap-action-log` in the provided middleware stack (`simulant.client/create`). More could be done to formalize the logging, but I felt this was an acceptable first cut.\r\n\r\n##### Exception-handling middleware\r\n- `simulant.client/wrap-exceptions`\r\n- Default success predicate checks for any status code in the 200 range.\r\n- Default success predicate can be replaced via a `:success-pred` key on the request.\r\n\r\n\r\n#### Concerns unaddressed\r\n- Docs/examples?\r\n- Should `simulant.http/keyword->content-type` be enriched?\r\n","created_at":"2016-01-25T21:33:59Z","updated_at":"2016-01-28T18:57:36Z","closed_at":"2016-01-28T18:57:36Z","merged_at":"2016-01-28T18:57:36Z","merge_commit_sha":"925eca80b13f871ea8b42601e9ffca089d6b576c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Datomic/simulant/pulls/28/commits","review_comments_url":"https://api.github.com/repos/Datomic/simulant/pulls/28/comments","review_comment_url":"https://api.github.com/repos/Datomic/simulant/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Datomic/simulant/issues/28/comments","statuses_url":"https://api.github.com/repos/Datomic/simulant/statuses/f5eb27df4781facde898d86ca7dfb38e63971991","head":{"label":"daemianmack:http-client","ref":"http-client","sha":"f5eb27df4781facde898d86ca7dfb38e63971991","user":{"login":"daemianmack","id":24476,"avatar_url":"https://avatars.githubusercontent.com/u/24476?v=3","gravatar_id":"","url":"https://api.github.com/users/daemianmack","html_url":"https://github.com/daemianmack","followers_url":"https://api.github.com/users/daemianmack/followers","following_url":"https://api.github.com/users/daemianmack/following{/other_user}","gists_url":"https://api.github.com/users/daemianmack/gists{/gist_id}","starred_url":"https://api.github.com/users/daemianmack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daemianmack/subscriptions","organizations_url":"https://api.github.com/users/daemianmack/orgs","repos_url":"https://api.github.com/users/daemianmack/repos","events_url":"https://api.github.com/users/daemianmack/events{/privacy}","received_events_url":"https://api.github.com/users/daemianmack/received_events","type":"User","site_admin":false},"repo":{"id":50131782,"name":"simulant","full_name":"daemianmack/simulant","owner":{"login":"daemianmack","id":24476,"avatar_url":"https://avatars.githubusercontent.com/u/24476?v=3","gravatar_id":"","url":"https://api.github.com/users/daemianmack","html_url":"https://github.com/daemianmack","followers_url":"https://api.github.com/users/daemianmack/followers","following_url":"https://api.github.com/users/daemianmack/following{/other_user}","gists_url":"https://api.github.com/users/daemianmack/gists{/gist_id}","starred_url":"https://api.github.com/users/daemianmack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daemianmack/subscriptions","organizations_url":"https://api.github.com/users/daemianmack/orgs","repos_url":"https://api.github.com/users/daemianmack/repos","events_url":"https://api.github.com/users/daemianmack/events{/privacy}","received_events_url":"https://api.github.com/users/daemianmack/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/daemianmack/simulant","description":"","fork":true,"url":"https://api.github.com/repos/daemianmack/simulant","forks_url":"https://api.github.com/repos/daemianmack/simulant/forks","keys_url":"https://api.github.com/repos/daemianmack/simulant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/daemianmack/simulant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/daemianmack/simulant/teams","hooks_url":"https://api.github.com/repos/daemianmack/simulant/hooks","issue_events_url":"https://api.github.com/repos/daemianmack/simulant/issues/events{/number}","events_url":"https://api.github.com/repos/daemianmack/simulant/events","assignees_url":"https://api.github.com/repos/daemianmack/simulant/assignees{/user}","branches_url":"https://api.github.com/repos/daemianmack/simulant/branches{/branch}","tags_url":"https://api.github.com/repos/daemianmack/simulant/tags","blobs_url":"https://api.github.com/repos/daemianmack/simulant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/daemianmack/simulant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/daemianmack/simulant/git/refs{/sha}","trees_url":"https://api.github.com/repos/daemianmack/simulant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/daemianmack/simulant/statuses/{sha}","languages_url":"https://api.github.com/repos/daemianmack/simulant/languages","stargazers_url":"https://api.github.com/repos/daemianmack/simulant/stargazers","contributors_url":"https://api.github.com/repos/daemianmack/simulant/contributors","subscribers_url":"https://api.github.com/repos/daemianmack/simulant/subscribers","subscription_url":"https://api.github.com/repos/daemianmack/simulant/subscription","commits_url":"https://api.github.com/repos/daemianmack/simulant/commits{/sha}","git_commits_url":"https://api.github.com/repos/daemianmack/simulant/git/commits{/sha}","comments_url":"https://api.github.com/repos/daemianmack/simulant/comments{/number}","issue_comment_url":"https://api.github.com/repos/daemianmack/simulant/issues/comments{/number}","contents_url":"https://api.github.com/repos/daemianmack/simulant/contents/{+path}","compare_url":"https://api.github.com/repos/daemianmack/simulant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/daemianmack/simulant/merges","archive_url":"https://api.github.com/repos/daemianmack/simulant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/daemianmack/simulant/downloads","issues_url":"https://api.github.com/repos/daemianmack/simulant/issues{/number}","pulls_url":"https://api.github.com/repos/daemianmack/simulant/pulls{/number}","milestones_url":"https://api.github.com/repos/daemianmack/simulant/milestones{/number}","notifications_url":"https://api.github.com/repos/daemianmack/simulant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/daemianmack/simulant/labels{/name}","releases_url":"https://api.github.com/repos/daemianmack/simulant/releases{/id}","deployments_url":"https://api.github.com/repos/daemianmack/simulant/deployments","created_at":"2016-01-21T19:36:41Z","updated_at":"2016-01-21T19:36:42Z","pushed_at":"2016-01-28T18:48:00Z","git_url":"git://github.com/daemianmack/simulant.git","ssh_url":"git@github.com:daemianmack/simulant.git","clone_url":"https://github.com/daemianmack/simulant.git","svn_url":"https://github.com/daemianmack/simulant","homepage":null,"size":128,"stargazers_count":0,"watchers_count":0,"language":"Clojure","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Datomic:steps-and-sequencing","ref":"steps-and-sequencing","sha":"c34cc2eadcf17a8d717917109ec6b14c7ce65a5c","user":{"login":"Datomic","id":1478702,"avatar_url":"https://avatars.githubusercontent.com/u/1478702?v=3","gravatar_id":"","url":"https://api.github.com/users/Datomic","html_url":"https://github.com/Datomic","followers_url":"https://api.github.com/users/Datomic/followers","following_url":"https://api.github.com/users/Datomic/following{/other_user}","gists_url":"https://api.github.com/users/Datomic/gists{/gist_id}","starred_url":"https://api.github.com/users/Datomic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Datomic/subscriptions","organizations_url":"https://api.github.com/users/Datomic/orgs","repos_url":"https://api.github.com/users/Datomic/repos","events_url":"https://api.github.com/users/Datomic/events{/privacy}","received_events_url":"https://api.github.com/users/Datomic/received_events","type":"Organization","site_admin":false},"repo":{"id":6416972,"name":"simulant","full_name":"Datomic/simulant","owner":{"login":"Datomic","id":1478702,"avatar_url":"https://avatars.githubusercontent.com/u/1478702?v=3","gravatar_id":"","url":"https://api.github.com/users/Datomic","html_url":"https://github.com/Datomic","followers_url":"https://api.github.com/users/Datomic/followers","following_url":"https://api.github.com/users/Datomic/following{/other_user}","gists_url":"https://api.github.com/users/Datomic/gists{/gist_id}","starred_url":"https://api.github.com/users/Datomic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Datomic/subscriptions","organizations_url":"https://api.github.com/users/Datomic/orgs","repos_url":"https://api.github.com/users/Datomic/repos","events_url":"https://api.github.com/users/Datomic/events{/privacy}","received_events_url":"https://api.github.com/users/Datomic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Datomic/simulant","description":"","fork":false,"url":"https://api.github.com/repos/Datomic/simulant","forks_url":"https://api.github.com/repos/Datomic/simulant/forks","keys_url":"https://api.github.com/repos/Datomic/simulant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Datomic/simulant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Datomic/simulant/teams","hooks_url":"https://api.github.com/repos/Datomic/simulant/hooks","issue_events_url":"https://api.github.com/repos/Datomic/simulant/issues/events{/number}","events_url":"https://api.github.com/repos/Datomic/simulant/events","assignees_url":"https://api.github.com/repos/Datomic/simulant/assignees{/user}","branches_url":"https://api.github.com/repos/Datomic/simulant/branches{/branch}","tags_url":"https://api.github.com/repos/Datomic/simulant/tags","blobs_url":"https://api.github.com/repos/Datomic/simulant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Datomic/simulant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Datomic/simulant/git/refs{/sha}","trees_url":"https://api.github.com/repos/Datomic/simulant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Datomic/simulant/statuses/{sha}","languages_url":"https://api.github.com/repos/Datomic/simulant/languages","stargazers_url":"https://api.github.com/repos/Datomic/simulant/stargazers","contributors_url":"https://api.github.com/repos/Datomic/simulant/contributors","subscribers_url":"https://api.github.com/repos/Datomic/simulant/subscribers","subscription_url":"https://api.github.com/repos/Datomic/simulant/subscription","commits_url":"https://api.github.com/repos/Datomic/simulant/commits{/sha}","git_commits_url":"https://api.github.com/repos/Datomic/simulant/git/commits{/sha}","comments_url":"https://api.github.com/repos/Datomic/simulant/comments{/number}","issue_comment_url":"https://api.github.com/repos/Datomic/simulant/issues/comments{/number}","contents_url":"https://api.github.com/repos/Datomic/simulant/contents/{+path}","compare_url":"https://api.github.com/repos/Datomic/simulant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Datomic/simulant/merges","archive_url":"https://api.github.com/repos/Datomic/simulant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Datomic/simulant/downloads","issues_url":"https://api.github.com/repos/Datomic/simulant/issues{/number}","pulls_url":"https://api.github.com/repos/Datomic/simulant/pulls{/number}","milestones_url":"https://api.github.com/repos/Datomic/simulant/milestones{/number}","notifications_url":"https://api.github.com/repos/Datomic/simulant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Datomic/simulant/labels{/name}","releases_url":"https://api.github.com/repos/Datomic/simulant/releases{/id}","deployments_url":"https://api.github.com/repos/Datomic/simulant/deployments","created_at":"2012-10-27T12:57:34Z","updated_at":"2016-01-27T08:53:52Z","pushed_at":"2016-01-28T18:57:36Z","git_url":"git://github.com/Datomic/simulant.git","ssh_url":"git@github.com:Datomic/simulant.git","clone_url":"https://github.com/Datomic/simulant.git","svn_url":"https://github.com/Datomic/simulant","homepage":null,"size":132,"stargazers_count":260,"watchers_count":260,"language":"Clojure","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"open_issues_count":4,"forks":22,"open_issues":4,"watchers":260,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Datomic/simulant/pulls/28"},"html":{"href":"https://github.com/Datomic/simulant/pull/28"},"issue":{"href":"https://api.github.com/repos/Datomic/simulant/issues/28"},"comments":{"href":"https://api.github.com/repos/Datomic/simulant/issues/28/comments"},"review_comments":{"href":"https://api.github.com/repos/Datomic/simulant/pulls/28/comments"},"review_comment":{"href":"https://api.github.com/repos/Datomic/simulant/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Datomic/simulant/pulls/28/commits"},"statuses":{"href":"https://api.github.com/repos/Datomic/simulant/statuses/f5eb27df4781facde898d86ca7dfb38e63971991"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"mtnygard","id":116714,"avatar_url":"https://avatars.githubusercontent.com/u/116714?v=3","gravatar_id":"","url":"https://api.github.com/users/mtnygard","html_url":"https://github.com/mtnygard","followers_url":"https://api.github.com/users/mtnygard/followers","following_url":"https://api.github.com/users/mtnygard/following{/other_user}","gists_url":"https://api.github.com/users/mtnygard/gists{/gist_id}","starred_url":"https://api.github.com/users/mtnygard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtnygard/subscriptions","organizations_url":"https://api.github.com/users/mtnygard/orgs","repos_url":"https://api.github.com/users/mtnygard/repos","events_url":"https://api.github.com/users/mtnygard/events{/privacy}","received_events_url":"https://api.github.com/users/mtnygard/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":3,"additions":335,"deletions":1,"changed_files":4}}