{"push_id":1002263719,"size":40,"distinct_size":40,"ref":"refs/heads/inkedit","head":"b5fa041458f80883a5bba0065f2445368b33efa1","before":"a8626527a62dd2f3e651eee3b6ca92ae4d1bcd23","commits":[{"sha":"209cb4ec42ec60d3a7ebb4395d585133af336303","author":{"email":"fd4c965c24d66fe735cb85ca5a97b0672dcae74f@wxwidgets.org","name":"Vadim Zeitlin"},"message":"Detect attempts to catch wxEVT_TEXT_ENTER without wxTE_PROCESS_ENTER\n\nThis is never going to work, so complain about trying to do it to help with\ncatching this bug.\n\nThis is possible thanks to the new OnDynamicBind() method invoked whenever a\ndynamic event handler is bound to a control, so this doesn't detect all\npossible occurrences of the bug (such as specifying the handler in a static\nevent table or in a validator), but it's still better than nothing.\n\nIn the future OnDynamicBind() should be extended for other invalid calls, e.g.\nbinding a handler for wxEVT_TEXT_ENTER to a non-text control shouldn't work\nneither, ideally.","distinct":true,"url":"https://api.github.com/repos/dconnet/wxWidgets/commits/209cb4ec42ec60d3a7ebb4395d585133af336303"},{"sha":"ba9edeef5ed16972bca702916744e0ac0b7e2e8b","author":{"email":"fd4c965c24d66fe735cb85ca5a97b0672dcae74f@wxwidgets.org","name":"Vadim Zeitlin"},"message":"Allow custom handling of Enter/Tab with modifiers in wxDataViewCtrl\n\nWhile Enter and Tab on their own should be used to finish cell editing, the\ncell editor itself may want to process key combinations involving these keys\nwith modifiers, e.g. Shift-Enter, so don't intercept those in at least the\ngeneric version of wxDataViewCtrl to allow catching them in the editor.","distinct":true,"url":"https://api.github.com/repos/dconnet/wxWidgets/commits/ba9edeef5ed16972bca702916744e0ac0b7e2e8b"},{"sha":"e796abe10c9abb4ed5f79a55c3b95daf16be6517","author":{"email":"fd4c965c24d66fe735cb85ca5a97b0672dcae74f@wxwidgets.org","name":"Vadim Zeitlin"},"message":"Replace wxTextCtrl::MSWWindowProc() with MSWHandleMessage()\n\nOverride newer and more flexible virtual method: this doesn't change anything\nyet but will allow to provide default handling for some messages in a single\noverridden method in the future commits, when it would have required to also\noverride MSWDefWindowProc() with the old method.","distinct":true,"url":"https://api.github.com/repos/dconnet/wxWidgets/commits/e796abe10c9abb4ed5f79a55c3b95daf16be6517"},{"sha":"f46e2fdcf576ffdbf19ea9668e61bd8edf961aeb","author":{"email":"fd4c965c24d66fe735cb85ca5a97b0672dcae74f@wxwidgets.org","name":"Vadim Zeitlin"},"message":"No changes, just replace a useless comment with a more helpful one\n\nDon't describe in English what the next line of code does, which is useless,\nbut rather explain why do we do this.","distinct":true,"url":"https://api.github.com/repos/dconnet/wxWidgets/commits/f46e2fdcf576ffdbf19ea9668e61bd8edf961aeb"},{"sha":"b21591e8b8e8cbee85070ee1952df1426d8079d8","author":{"email":"fd4c965c24d66fe735cb85ca5a97b0672dcae74f@wxwidgets.org","name":"Vadim Zeitlin"},"message":"Factor out methods for clicking the default button in wxMSW\n\nThis will make it possible to reproduce the default \"Enter\" key functionality\nfrom elsewhere.\n\nAlmost no changes yet, the only minor change is that we now wouldn't try to\n\"click\" any windows using DLGC_DEFPUSHBUTTON dialog code but which are not\nreally buttons -- but then this shouldn't ever happen anyhow.","distinct":true,"url":"https://api.github.com/repos/dconnet/wxWidgets/commits/b21591e8b8e8cbee85070ee1952df1426d8079d8"},{"sha":"634c49447031ecb2e171df1f22026244c94091c6","author":{"email":"fd4c965c24d66fe735cb85ca5a97b0672dcae74f@wxwidgets.org","name":"Vadim Zeitlin"},"message":"Fix skipping the event in wxEVT_TEXT_ENTER handler in wxMSW\n\nSkipping the event is supposed to have the same effect as not handling the\nevent at all, but in wxMSW wxTE_PROCESS_ENTER style must be specified for a\nwxEVT_TEXT_ENTER handler to be executed at all and if this style is used, then\nthe default handling in MSWProcessMessage() which normally happens before\ncalling the handler doesn't take place at all.\n\nWork around this by explicitly performing the default \"Enter\" key action if\nthe event generated by it wasn't handled to make wxMSW behaviour more\nintuitive.","distinct":true,"url":"https://api.github.com/repos/dconnet/wxWidgets/commits/634c49447031ecb2e171df1f22026244c94091c6"},{"sha":"02bc96dd58b4162f863a7381f0ff86c4d38e708e","author":{"email":"fd4c965c24d66fe735cb85ca5a97b0672dcae74f@wxwidgets.org","name":"Vadim Zeitlin"},"message":"Just simplify wxPoint/wxSize creation from wxRect\n\nUse the existing wxRect::Get{Position,Size}() methods instead of explicitly\ncreating the objects from the wxRect components, this is simpler and more\nreadable.\n\nNo real changes.","distinct":true,"url":"https://api.github.com/repos/dconnet/wxWidgets/commits/02bc96dd58b4162f863a7381f0ff86c4d38e708e"},{"sha":"d465d3397eca56ab15ef401e6703933fcfbdbcc3","author":{"email":"fd4c965c24d66fe735cb85ca5a97b0672dcae74f@wxwidgets.org","name":"Vadim Zeitlin"},"message":"Always delete the editor when finishing editing in wxDataViewCtrl\n\nWe need to delete the editor control even if GetValueFromEditorCtrl() failed\nas otherwise we're never going to be able to edit another item again, at least\nwith the GTK native implementation, which does nothing when starting to edit\nan item if an editor control already exists.","distinct":true,"url":"https://api.github.com/repos/dconnet/wxWidgets/commits/d465d3397eca56ab15ef401e6703933fcfbdbcc3"},{"sha":"752f38191fef47786389614e228ad23ca9104f3d","author":{"email":"fd4c965c24d66fe735cb85ca5a97b0672dcae74f@wxwidgets.org","name":"Vadim Zeitlin"},"message":"Factor out wxDataViewRendererBase::NotifyEditingStarted()\n\nReuse the same code from the generic and native GTK and OS X implementations\nof wxDataViewCtrl instead of triplicating it.\n\nThis fixes a small discrepancy between the wxOSX version, which didn't see the\nmodel pointer correctly in the generated event, and all the others, but mainly\npaves way for future improvements.","distinct":true,"url":"https://api.github.com/repos/dconnet/wxWidgets/commits/752f38191fef47786389614e228ad23ca9104f3d"},{"sha":"a60703e2d942824359e4722244cb64cc1b0bdbff","author":{"email":"fd4c965c24d66fe735cb85ca5a97b0672dcae74f@wxwidgets.org","name":"Vadim Zeitlin"},"message":"Fix duplicate wxEVT_DATAVIEW_ITEM_EDITING_STARTED under GTK\n\nWhen using a custom renderer, wxEVT_DATAVIEW_ITEM_EDITING_STARTED was sent\ntwice: once from the generic base class StartEditing() and another time from\nthe GTK-specific \"editing_started\" signal handler. And we must send it from\nthe latter, because otherwise no event would be generated at all for the\nstandard renderers (i.e. text cells) for which we don't call StartEditing()\nourselves, so don't call it from the former and instead generate the event by\nexplicitly calling NotifyEditingStarted() after calling StartEditing() in the\ngeneric version (as for wxOSX version, it doesn't use StartEditing() at all\nand so doesn't need to be changed).","distinct":true,"url":"https://api.github.com/repos/dconnet/wxWidgets/commits/a60703e2d942824359e4722244cb64cc1b0bdbff"},{"sha":"aaba656f030b9e8c77435faaac5cf4b58b112dd6","author":{"email":"fd4c965c24d66fe735cb85ca5a97b0672dcae74f@wxwidgets.org","name":"Vadim Zeitlin"},"message":"Test custom editor in the dataview sample\n\nShow how to create and use a custom editor in the custom renderer.","distinct":true,"url":"https://api.github.com/repos/dconnet/wxWidgets/commits/aaba656f030b9e8c77435faaac5cf4b58b112dd6"},{"sha":"5a6d9f6c8ecd530065d1066c9a38580ca0ffbb67","author":{"email":"fd4c965c24d66fe735cb85ca5a97b0672dcae74f@wxwidgets.org","name":"Vadim Zeitlin"},"message":"Fix editing items with custom renderers in wxGTK wxDataViewCtrl\n\nCall FinishEditing() when the cell is done being edited instead of sending\nwxEVT_DATAVIEW_ITEM_EDITING_DONE event manually from wxGTK code.\n\nThis fixes the bug with not being able to edit an item the second time if the\neditor was dismissed by GTK+ itself and not by our own code (which already did\ncall FinishEditing()) as the old editor still remained alive because\nDestroyEditControl(), usually called from FinishEditing(), wasn't executed.\n\nIt also removes code duplication and avoids the need to keep a global\ns_user_data pointer as the item currently being edited is already stored in\nwxDataViewRenderer anyhow.","distinct":true,"url":"https://api.github.com/repos/dconnet/wxWidgets/commits/5a6d9f6c8ecd530065d1066c9a38580ca0ffbb67"},{"sha":"efa0770171451b0abfb92dc3af8fa7476bbb8837","author":{"email":"fd4c965c24d66fe735cb85ca5a97b0672dcae74f@wxwidgets.org","name":"Vadim Zeitlin"},"message":"Reset the wxDataViewItem being edited once it's not edited any more\n\nNo real changes, just some cleanup to ensure that the item being edited stored\nin wxDataViewRendererBase never refers to an item which is not, actually,\nbeing edited any longer.","distinct":true,"url":"https://api.github.com/repos/dconnet/wxWidgets/commits/efa0770171451b0abfb92dc3af8fa7476bbb8837"},{"sha":"a47fcdbae3fffdf6bcdf895b1094245ff069ecbb","author":{"email":"fd4c965c24d66fe735cb85ca5a97b0672dcae74f@wxwidgets.org","name":"Vadim Zeitlin"},"message":"Fix harmless deprecation warning for g_type_init() in drawing test\n\nSame as 3dde6ec2feb2bb34a5ee95bcac44c91c2525a54a.","distinct":true,"url":"https://api.github.com/repos/dconnet/wxWidgets/commits/a47fcdbae3fffdf6bcdf895b1094245ff069ecbb"},{"sha":"53a0a18e41326e5218110e2d1663baeb99d9fdcb","author":{"email":"fd4c965c24d66fe735cb85ca5a97b0672dcae74f@wxwidgets.org","name":"Vadim Zeitlin"},"message":"Avoid gcc deprecation warnings for wxNORMAL in the tests\n\nWe use wxNORMAL intentionally to test for its support, so we're not interested\nin deprecation warnings about it.","distinct":true,"url":"https://api.github.com/repos/dconnet/wxWidgets/commits/53a0a18e41326e5218110e2d1663baeb99d9fdcb"},{"sha":"585f497713209ad5c5c1f35bddc56d74a2dada3f","author":{"email":"fd4c965c24d66fe735cb85ca5a97b0672dcae74f@wxwidgets.org","name":"Vadim Zeitlin"},"message":"Fix ellipsization unit test when using pixel scaling\n\nWhen pixel doubling is in use, e.g. when using GTK+ 2 on high DPI displays,\nthe width of a single TAB can be greater than the hardcoded 50 width in the\ntest, which resulted in test failures.\n\nBase the widths on the average character width to make sure we can always\nellipsize.","distinct":true,"url":"https://api.github.com/repos/dconnet/wxWidgets/commits/585f497713209ad5c5c1f35bddc56d74a2dada3f"},{"sha":"22bad6e7163e463435a20cfa2c809664755e5e7c","author":{"email":"2dcb7a800fd59735edd7961ebbf495e3ff0ff7b4@users.noreply.github.com","name":"Paul Cornett"},"message":"Avoid comparing address of reference to NULL\n\nAs GCC 6 points out, the compiler is free to assume a reference is never\nnull, and remove such a check","distinct":true,"url":"https://api.github.com/repos/dconnet/wxWidgets/commits/22bad6e7163e463435a20cfa2c809664755e5e7c"},{"sha":"29734e10ef20344d0586a4119346507b66a736fe","author":{"email":"fd4c965c24d66fe735cb85ca5a97b0672dcae74f@wxwidgets.org","name":"Vadim Zeitlin"},"message":"Fix return type of wxListCtrl::EnableCheckboxes() in the documentation\n\nIt returns bool, not void.","distinct":true,"url":"https://api.github.com/repos/dconnet/wxWidgets/commits/29734e10ef20344d0586a4119346507b66a736fe"},{"sha":"6a45a52f5fd93f62cc23f73dcd999b5a9b138f5e","author":{"email":"a49af8e07d37d6a8c35a1044b81012f9b33b442e@wp.pl","name":"Artur Wieczorek"},"message":"Fixed rescaling wxBitmap.\n\nCreate rescaled wxBitmap with the same colour depth as the source bitmap.","distinct":true,"url":"https://api.github.com/repos/dconnet/wxWidgets/commits/6a45a52f5fd93f62cc23f73dcd999b5a9b138f5e"},{"sha":"8828b39435d22f950f8809d81cf6b4216b06a6c6","author":{"email":"fd4c965c24d66fe735cb85ca5a97b0672dcae74f@wxwidgets.org","name":"Vadim Zeitlin"},"message":"Fix assertion in the HtmlParser unit test case\n\nUse wxHtmlWinParser instead of wxHtmlParser which can't be actually used\nwithout being initialized with the tag handlers (it's not clear whether this\nis really intentional...).","distinct":true,"url":"https://api.github.com/repos/dconnet/wxWidgets/commits/8828b39435d22f950f8809d81cf6b4216b06a6c6"}]}