{"action":"created","comment":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/88562383","pull_request_review_id":9133911,"id":88562383,"diff_hunk":"@@ -142,10 +142,12 @@ def _kl_divergence(params, P, degrees_of_freedom, n_samples, n_components,\n \n     # Q is a heavy-tailed distribution: Student's t-distribution\n     n = pdist(X_embedded, \"sqeuclidean\")\n-    n += 1.","path":"sklearn/manifold/t_sne.py","position":4,"original_position":4,"commit_id":"46dd13ec262e44b5fb8f5cf131b8242c093f6827","original_commit_id":"cf788f143fc8f6240ef91eb087c375a6de2bd54f","user":{"login":"AlexanderFabisch","id":869592,"avatar_url":"https://avatars.githubusercontent.com/u/869592?v=3","gravatar_id":"","url":"https://api.github.com/users/AlexanderFabisch","html_url":"https://github.com/AlexanderFabisch","followers_url":"https://api.github.com/users/AlexanderFabisch/followers","following_url":"https://api.github.com/users/AlexanderFabisch/following{/other_user}","gists_url":"https://api.github.com/users/AlexanderFabisch/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexanderFabisch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexanderFabisch/subscriptions","organizations_url":"https://api.github.com/users/AlexanderFabisch/orgs","repos_url":"https://api.github.com/users/AlexanderFabisch/repos","events_url":"https://api.github.com/users/AlexanderFabisch/events{/privacy}","received_events_url":"https://api.github.com/users/AlexanderFabisch/received_events","type":"User","site_admin":false},"body":"By the way, yes you are correct about the wrong order of dividing by alpha and adding 1. Probably nobody used n_components > 2 before. :) We need some kind of unit test for that. In the best case we would compare the numerical and the analytical gradient.","created_at":"2016-11-17T22:33:01Z","updated_at":"2016-11-17T22:33:01Z","html_url":"https://github.com/scikit-learn/scikit-learn/pull/7885#discussion_r88562383","pull_request_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/7885","_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/88562383"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/7885#discussion_r88562383"},"pull_request":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/7885"}}},"pull_request":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/7885","id":93881888,"html_url":"https://github.com/scikit-learn/scikit-learn/pull/7885","diff_url":"https://github.com/scikit-learn/scikit-learn/pull/7885.diff","patch_url":"https://github.com/scikit-learn/scikit-learn/pull/7885.patch","issue_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/7885","number":7885,"state":"open","locked":false,"title":"[WIP] Fixes bugs in t-SNE argument passing, and a bug with running using n dfs","user":{"login":"artcg","id":952771,"avatar_url":"https://avatars.githubusercontent.com/u/952771?v=3","gravatar_id":"","url":"https://api.github.com/users/artcg","html_url":"https://github.com/artcg","followers_url":"https://api.github.com/users/artcg/followers","following_url":"https://api.github.com/users/artcg/following{/other_user}","gists_url":"https://api.github.com/users/artcg/gists{/gist_id}","starred_url":"https://api.github.com/users/artcg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artcg/subscriptions","organizations_url":"https://api.github.com/users/artcg/orgs","repos_url":"https://api.github.com/users/artcg/repos","events_url":"https://api.github.com/users/artcg/events{/privacy}","received_events_url":"https://api.github.com/users/artcg/received_events","type":"User","site_admin":false},"body":"#### What does this implement/fix? Explain your changes.\r\n1. There was a bug in the implementation of t-SNE with n degrees of freedom for the 'exact' method.\r\n\r\n2. There was a bug where some arguments were not being passed in t-SNE\r\n\r\n3. I added support for a trefoil knot generator\r\n\r\n4. I changed a couple default arguments for t-SNE\r\n(Details given in the commit message)\r\n\r\n\r\n#### Any other comments?\r\n\r\nPlease let me know if you have any questions about the changes!\r\n","created_at":"2016-11-16T00:58:43Z","updated_at":"2016-11-17T22:33:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e3496c2e304454875c25acf627e84cd5774e7ed1","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/7885/commits","review_comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/7885/comments","review_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/7885/comments","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/46dd13ec262e44b5fb8f5cf131b8242c093f6827","head":{"label":"artcg:tsne","ref":"tsne","sha":"46dd13ec262e44b5fb8f5cf131b8242c093f6827","user":{"login":"artcg","id":952771,"avatar_url":"https://avatars.githubusercontent.com/u/952771?v=3","gravatar_id":"","url":"https://api.github.com/users/artcg","html_url":"https://github.com/artcg","followers_url":"https://api.github.com/users/artcg/followers","following_url":"https://api.github.com/users/artcg/following{/other_user}","gists_url":"https://api.github.com/users/artcg/gists{/gist_id}","starred_url":"https://api.github.com/users/artcg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artcg/subscriptions","organizations_url":"https://api.github.com/users/artcg/orgs","repos_url":"https://api.github.com/users/artcg/repos","events_url":"https://api.github.com/users/artcg/events{/privacy}","received_events_url":"https://api.github.com/users/artcg/received_events","type":"User","site_admin":false},"repo":{"id":73858866,"name":"scikit-learn","full_name":"artcg/scikit-learn","owner":{"login":"artcg","id":952771,"avatar_url":"https://avatars.githubusercontent.com/u/952771?v=3","gravatar_id":"","url":"https://api.github.com/users/artcg","html_url":"https://github.com/artcg","followers_url":"https://api.github.com/users/artcg/followers","following_url":"https://api.github.com/users/artcg/following{/other_user}","gists_url":"https://api.github.com/users/artcg/gists{/gist_id}","starred_url":"https://api.github.com/users/artcg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artcg/subscriptions","organizations_url":"https://api.github.com/users/artcg/orgs","repos_url":"https://api.github.com/users/artcg/repos","events_url":"https://api.github.com/users/artcg/events{/privacy}","received_events_url":"https://api.github.com/users/artcg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/artcg/scikit-learn","description":"scikit-learn: machine learning in Python","fork":true,"url":"https://api.github.com/repos/artcg/scikit-learn","forks_url":"https://api.github.com/repos/artcg/scikit-learn/forks","keys_url":"https://api.github.com/repos/artcg/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/artcg/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/artcg/scikit-learn/teams","hooks_url":"https://api.github.com/repos/artcg/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/artcg/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/artcg/scikit-learn/events","assignees_url":"https://api.github.com/repos/artcg/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/artcg/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/artcg/scikit-learn/tags","blobs_url":"https://api.github.com/repos/artcg/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/artcg/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/artcg/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/artcg/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/artcg/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/artcg/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/artcg/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/artcg/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/artcg/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/artcg/scikit-learn/subscription","commits_url":"https://api.github.com/repos/artcg/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/artcg/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/artcg/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/artcg/scikit-learn/issues/comments{/number}","contents_url":"https://api.github.com/repos/artcg/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/artcg/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/artcg/scikit-learn/merges","archive_url":"https://api.github.com/repos/artcg/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/artcg/scikit-learn/downloads","issues_url":"https://api.github.com/repos/artcg/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/artcg/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/artcg/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/artcg/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/artcg/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/artcg/scikit-learn/releases{/id}","deployments_url":"https://api.github.com/repos/artcg/scikit-learn/deployments","created_at":"2016-11-15T21:57:41Z","updated_at":"2016-11-15T21:57:50Z","pushed_at":"2016-11-16T15:34:35Z","git_url":"git://github.com/artcg/scikit-learn.git","ssh_url":"git@github.com:artcg/scikit-learn.git","clone_url":"https://github.com/artcg/scikit-learn.git","svn_url":"https://github.com/artcg/scikit-learn","homepage":"http://scikit-learn.org","size":77148,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"scikit-learn:master","ref":"master","sha":"915458bb71e7892c271235cd65e550c1983bd6b9","user":{"login":"scikit-learn","id":365630,"avatar_url":"https://avatars.githubusercontent.com/u/365630?v=3","gravatar_id":"","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"repo":{"id":843222,"name":"scikit-learn","full_name":"scikit-learn/scikit-learn","owner":{"login":"scikit-learn","id":365630,"avatar_url":"https://avatars.githubusercontent.com/u/365630?v=3","gravatar_id":"","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scikit-learn/scikit-learn","description":"scikit-learn: machine learning in Python","fork":false,"url":"https://api.github.com/repos/scikit-learn/scikit-learn","forks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/forks","keys_url":"https://api.github.com/repos/scikit-learn/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scikit-learn/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scikit-learn/scikit-learn/teams","hooks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/events","assignees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/scikit-learn/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/tags","blobs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/scikit-learn/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscription","commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/comments{/number}","contents_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/scikit-learn/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scikit-learn/scikit-learn/merges","archive_url":"https://api.github.com/repos/scikit-learn/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scikit-learn/scikit-learn/downloads","issues_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/scikit-learn/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/scikit-learn/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scikit-learn/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/scikit-learn/scikit-learn/releases{/id}","deployments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/deployments","created_at":"2010-08-17T09:43:38Z","updated_at":"2016-11-17T22:07:52Z","pushed_at":"2016-11-17T20:45:04Z","git_url":"git://github.com/scikit-learn/scikit-learn.git","ssh_url":"git@github.com:scikit-learn/scikit-learn.git","clone_url":"https://github.com/scikit-learn/scikit-learn.git","svn_url":"https://github.com/scikit-learn/scikit-learn","homepage":"http://scikit-learn.org","size":128704,"stargazers_count":14755,"watchers_count":14755,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8360,"mirror_url":null,"open_issues_count":1127,"forks":8360,"open_issues":1127,"watchers":14755,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/7885"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/7885"},"issue":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/7885"},"comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/7885/comments"},"review_comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/7885/comments"},"review_comment":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/7885/commits"},"statuses":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/46dd13ec262e44b5fb8f5cf131b8242c093f6827"}}}}
{"actor":{"display_login":"AlexanderFabisch"}}