{"action":"closed","number":5,"pull_request":{"url":"https://api.github.com/repos/kriscross07/atom-gpp-compiler/pulls/5","id":55392339,"html_url":"https://github.com/kriscross07/atom-gpp-compiler/pull/5","diff_url":"https://github.com/kriscross07/atom-gpp-compiler/pull/5.diff","patch_url":"https://github.com/kriscross07/atom-gpp-compiler/pull/5.patch","issue_url":"https://api.github.com/repos/kriscross07/atom-gpp-compiler/issues/5","number":5,"state":"closed","locked":false,"title":"Linux shell escaping; cross-distro compatible term","user":{"login":"LinuxMercedes","id":150011,"avatar_url":"https://avatars.githubusercontent.com/u/150011?v=3","gravatar_id":"","url":"https://api.github.com/users/LinuxMercedes","html_url":"https://github.com/LinuxMercedes","followers_url":"https://api.github.com/users/LinuxMercedes/followers","following_url":"https://api.github.com/users/LinuxMercedes/following{/other_user}","gists_url":"https://api.github.com/users/LinuxMercedes/gists{/gist_id}","starred_url":"https://api.github.com/users/LinuxMercedes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LinuxMercedes/subscriptions","organizations_url":"https://api.github.com/users/LinuxMercedes/orgs","repos_url":"https://api.github.com/users/LinuxMercedes/repos","events_url":"https://api.github.com/users/LinuxMercedes/events{/privacy}","received_events_url":"https://api.github.com/users/LinuxMercedes/received_events","type":"User","site_admin":false},"body":"If you name files in bizarre ways, say, `foo${bar}.cpp`, the filenames have to be correctly escaped. \r\n\r\nMost distros don't have `gnome-terminal`; everyone should have `xterm`. A more proper fix might be to use `x-terminal-emulator` or `xdg-terminal`, depending on which is installed, and falling back to `xterm` if all else fails. That would break the `-hold` argument, though. For whatever reason, this is a Hard Problem for Linux. \r\n\r\nI haven't tested this on OS X or Windows, since I do not have machines to test on. ","created_at":"2016-01-07T21:25:23Z","updated_at":"2016-01-07T22:04:44Z","closed_at":"2016-01-07T22:04:44Z","merged_at":"2016-01-07T22:04:44Z","merge_commit_sha":"1c9ce50556c1f5f0d6fa830dc5fd552e5ed9a28c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/kriscross07/atom-gpp-compiler/pulls/5/commits","review_comments_url":"https://api.github.com/repos/kriscross07/atom-gpp-compiler/pulls/5/comments","review_comment_url":"https://api.github.com/repos/kriscross07/atom-gpp-compiler/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kriscross07/atom-gpp-compiler/issues/5/comments","statuses_url":"https://api.github.com/repos/kriscross07/atom-gpp-compiler/statuses/7e4d6029bd1e8face1dadf7ebdd2cc234a66016a","head":{"label":"LinuxMercedes:shell-fixes","ref":"shell-fixes","sha":"7e4d6029bd1e8face1dadf7ebdd2cc234a66016a","user":{"login":"LinuxMercedes","id":150011,"avatar_url":"https://avatars.githubusercontent.com/u/150011?v=3","gravatar_id":"","url":"https://api.github.com/users/LinuxMercedes","html_url":"https://github.com/LinuxMercedes","followers_url":"https://api.github.com/users/LinuxMercedes/followers","following_url":"https://api.github.com/users/LinuxMercedes/following{/other_user}","gists_url":"https://api.github.com/users/LinuxMercedes/gists{/gist_id}","starred_url":"https://api.github.com/users/LinuxMercedes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LinuxMercedes/subscriptions","organizations_url":"https://api.github.com/users/LinuxMercedes/orgs","repos_url":"https://api.github.com/users/LinuxMercedes/repos","events_url":"https://api.github.com/users/LinuxMercedes/events{/privacy}","received_events_url":"https://api.github.com/users/LinuxMercedes/received_events","type":"User","site_admin":false},"repo":{"id":49229454,"name":"atom-gpp-compiler","full_name":"LinuxMercedes/atom-gpp-compiler","owner":{"login":"LinuxMercedes","id":150011,"avatar_url":"https://avatars.githubusercontent.com/u/150011?v=3","gravatar_id":"","url":"https://api.github.com/users/LinuxMercedes","html_url":"https://github.com/LinuxMercedes","followers_url":"https://api.github.com/users/LinuxMercedes/followers","following_url":"https://api.github.com/users/LinuxMercedes/following{/other_user}","gists_url":"https://api.github.com/users/LinuxMercedes/gists{/gist_id}","starred_url":"https://api.github.com/users/LinuxMercedes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LinuxMercedes/subscriptions","organizations_url":"https://api.github.com/users/LinuxMercedes/orgs","repos_url":"https://api.github.com/users/LinuxMercedes/repos","events_url":"https://api.github.com/users/LinuxMercedes/events{/privacy}","received_events_url":"https://api.github.com/users/LinuxMercedes/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/LinuxMercedes/atom-gpp-compiler","description":"An atom package to compile and run C++","fork":true,"url":"https://api.github.com/repos/LinuxMercedes/atom-gpp-compiler","forks_url":"https://api.github.com/repos/LinuxMercedes/atom-gpp-compiler/forks","keys_url":"https://api.github.com/repos/LinuxMercedes/atom-gpp-compiler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LinuxMercedes/atom-gpp-compiler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LinuxMercedes/atom-gpp-compiler/teams","hooks_url":"https://api.github.com/repos/LinuxMercedes/atom-gpp-compiler/hooks","issue_events_url":"https://api.github.com/repos/LinuxMercedes/atom-gpp-compiler/issues/events{/number}","events_url":"https://api.github.com/repos/LinuxMercedes/atom-gpp-compiler/events","assignees_url":"https://api.github.com/repos/LinuxMercedes/atom-gpp-compiler/assignees{/user}","branches_url":"https://api.github.com/repos/LinuxMercedes/atom-gpp-compiler/branches{/branch}","tags_url":"https://api.github.com/repos/LinuxMercedes/atom-gpp-compiler/tags","blobs_url":"https://api.github.com/repos/LinuxMercedes/atom-gpp-compiler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LinuxMercedes/atom-gpp-compiler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LinuxMercedes/atom-gpp-compiler/git/refs{/sha}","trees_url":"https://api.github.com/repos/LinuxMercedes/atom-gpp-compiler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LinuxMercedes/atom-gpp-compiler/statuses/{sha}","languages_url":"https://api.github.com/repos/LinuxMercedes/atom-gpp-compiler/languages","stargazers_url":"https://api.github.com/repos/LinuxMercedes/atom-gpp-compiler/stargazers","contributors_url":"https://api.github.com/repos/LinuxMercedes/atom-gpp-compiler/contributors","subscribers_url":"https://api.github.com/repos/LinuxMercedes/atom-gpp-compiler/subscribers","subscription_url":"https://api.github.com/repos/LinuxMercedes/atom-gpp-compiler/subscription","commits_url":"https://api.github.com/repos/LinuxMercedes/atom-gpp-compiler/commits{/sha}","git_commits_url":"https://api.github.com/repos/LinuxMercedes/atom-gpp-compiler/git/commits{/sha}","comments_url":"https://api.github.com/repos/LinuxMercedes/atom-gpp-compiler/comments{/number}","issue_comment_url":"https://api.github.com/repos/LinuxMercedes/atom-gpp-compiler/issues/comments{/number}","contents_url":"https://api.github.com/repos/LinuxMercedes/atom-gpp-compiler/contents/{+path}","compare_url":"https://api.github.com/repos/LinuxMercedes/atom-gpp-compiler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LinuxMercedes/atom-gpp-compiler/merges","archive_url":"https://api.github.com/repos/LinuxMercedes/atom-gpp-compiler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LinuxMercedes/atom-gpp-compiler/downloads","issues_url":"https://api.github.com/repos/LinuxMercedes/atom-gpp-compiler/issues{/number}","pulls_url":"https://api.github.com/repos/LinuxMercedes/atom-gpp-compiler/pulls{/number}","milestones_url":"https://api.github.com/repos/LinuxMercedes/atom-gpp-compiler/milestones{/number}","notifications_url":"https://api.github.com/repos/LinuxMercedes/atom-gpp-compiler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LinuxMercedes/atom-gpp-compiler/labels{/name}","releases_url":"https://api.github.com/repos/LinuxMercedes/atom-gpp-compiler/releases{/id}","created_at":"2016-01-07T20:40:39Z","updated_at":"2016-01-07T20:40:40Z","pushed_at":"2016-01-07T21:56:23Z","git_url":"git://github.com/LinuxMercedes/atom-gpp-compiler.git","ssh_url":"git@github.com:LinuxMercedes/atom-gpp-compiler.git","clone_url":"https://github.com/LinuxMercedes/atom-gpp-compiler.git","svn_url":"https://github.com/LinuxMercedes/atom-gpp-compiler","homepage":"","size":15,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kriscross07:master","ref":"master","sha":"8dd6b954369663812118d2941c96ddb1df395755","user":{"login":"kriscross07","id":5783816,"avatar_url":"https://avatars.githubusercontent.com/u/5783816?v=3","gravatar_id":"","url":"https://api.github.com/users/kriscross07","html_url":"https://github.com/kriscross07","followers_url":"https://api.github.com/users/kriscross07/followers","following_url":"https://api.github.com/users/kriscross07/following{/other_user}","gists_url":"https://api.github.com/users/kriscross07/gists{/gist_id}","starred_url":"https://api.github.com/users/kriscross07/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kriscross07/subscriptions","organizations_url":"https://api.github.com/users/kriscross07/orgs","repos_url":"https://api.github.com/users/kriscross07/repos","events_url":"https://api.github.com/users/kriscross07/events{/privacy}","received_events_url":"https://api.github.com/users/kriscross07/received_events","type":"User","site_admin":false},"repo":{"id":43343972,"name":"atom-gpp-compiler","full_name":"kriscross07/atom-gpp-compiler","owner":{"login":"kriscross07","id":5783816,"avatar_url":"https://avatars.githubusercontent.com/u/5783816?v=3","gravatar_id":"","url":"https://api.github.com/users/kriscross07","html_url":"https://github.com/kriscross07","followers_url":"https://api.github.com/users/kriscross07/followers","following_url":"https://api.github.com/users/kriscross07/following{/other_user}","gists_url":"https://api.github.com/users/kriscross07/gists{/gist_id}","starred_url":"https://api.github.com/users/kriscross07/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kriscross07/subscriptions","organizations_url":"https://api.github.com/users/kriscross07/orgs","repos_url":"https://api.github.com/users/kriscross07/repos","events_url":"https://api.github.com/users/kriscross07/events{/privacy}","received_events_url":"https://api.github.com/users/kriscross07/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kriscross07/atom-gpp-compiler","description":"An atom package to compile and run C++","fork":false,"url":"https://api.github.com/repos/kriscross07/atom-gpp-compiler","forks_url":"https://api.github.com/repos/kriscross07/atom-gpp-compiler/forks","keys_url":"https://api.github.com/repos/kriscross07/atom-gpp-compiler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kriscross07/atom-gpp-compiler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kriscross07/atom-gpp-compiler/teams","hooks_url":"https://api.github.com/repos/kriscross07/atom-gpp-compiler/hooks","issue_events_url":"https://api.github.com/repos/kriscross07/atom-gpp-compiler/issues/events{/number}","events_url":"https://api.github.com/repos/kriscross07/atom-gpp-compiler/events","assignees_url":"https://api.github.com/repos/kriscross07/atom-gpp-compiler/assignees{/user}","branches_url":"https://api.github.com/repos/kriscross07/atom-gpp-compiler/branches{/branch}","tags_url":"https://api.github.com/repos/kriscross07/atom-gpp-compiler/tags","blobs_url":"https://api.github.com/repos/kriscross07/atom-gpp-compiler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kriscross07/atom-gpp-compiler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kriscross07/atom-gpp-compiler/git/refs{/sha}","trees_url":"https://api.github.com/repos/kriscross07/atom-gpp-compiler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kriscross07/atom-gpp-compiler/statuses/{sha}","languages_url":"https://api.github.com/repos/kriscross07/atom-gpp-compiler/languages","stargazers_url":"https://api.github.com/repos/kriscross07/atom-gpp-compiler/stargazers","contributors_url":"https://api.github.com/repos/kriscross07/atom-gpp-compiler/contributors","subscribers_url":"https://api.github.com/repos/kriscross07/atom-gpp-compiler/subscribers","subscription_url":"https://api.github.com/repos/kriscross07/atom-gpp-compiler/subscription","commits_url":"https://api.github.com/repos/kriscross07/atom-gpp-compiler/commits{/sha}","git_commits_url":"https://api.github.com/repos/kriscross07/atom-gpp-compiler/git/commits{/sha}","comments_url":"https://api.github.com/repos/kriscross07/atom-gpp-compiler/comments{/number}","issue_comment_url":"https://api.github.com/repos/kriscross07/atom-gpp-compiler/issues/comments{/number}","contents_url":"https://api.github.com/repos/kriscross07/atom-gpp-compiler/contents/{+path}","compare_url":"https://api.github.com/repos/kriscross07/atom-gpp-compiler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kriscross07/atom-gpp-compiler/merges","archive_url":"https://api.github.com/repos/kriscross07/atom-gpp-compiler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kriscross07/atom-gpp-compiler/downloads","issues_url":"https://api.github.com/repos/kriscross07/atom-gpp-compiler/issues{/number}","pulls_url":"https://api.github.com/repos/kriscross07/atom-gpp-compiler/pulls{/number}","milestones_url":"https://api.github.com/repos/kriscross07/atom-gpp-compiler/milestones{/number}","notifications_url":"https://api.github.com/repos/kriscross07/atom-gpp-compiler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kriscross07/atom-gpp-compiler/labels{/name}","releases_url":"https://api.github.com/repos/kriscross07/atom-gpp-compiler/releases{/id}","created_at":"2015-09-29T04:04:33Z","updated_at":"2016-01-07T18:20:23Z","pushed_at":"2016-01-07T22:04:44Z","git_url":"git://github.com/kriscross07/atom-gpp-compiler.git","ssh_url":"git@github.com:kriscross07/atom-gpp-compiler.git","clone_url":"https://github.com/kriscross07/atom-gpp-compiler.git","svn_url":"https://github.com/kriscross07/atom-gpp-compiler","homepage":"","size":15,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":2,"forks":3,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kriscross07/atom-gpp-compiler/pulls/5"},"html":{"href":"https://github.com/kriscross07/atom-gpp-compiler/pull/5"},"issue":{"href":"https://api.github.com/repos/kriscross07/atom-gpp-compiler/issues/5"},"comments":{"href":"https://api.github.com/repos/kriscross07/atom-gpp-compiler/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/kriscross07/atom-gpp-compiler/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/kriscross07/atom-gpp-compiler/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kriscross07/atom-gpp-compiler/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/kriscross07/atom-gpp-compiler/statuses/7e4d6029bd1e8face1dadf7ebdd2cc234a66016a"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"kriscross07","id":5783816,"avatar_url":"https://avatars.githubusercontent.com/u/5783816?v=3","gravatar_id":"","url":"https://api.github.com/users/kriscross07","html_url":"https://github.com/kriscross07","followers_url":"https://api.github.com/users/kriscross07/followers","following_url":"https://api.github.com/users/kriscross07/following{/other_user}","gists_url":"https://api.github.com/users/kriscross07/gists{/gist_id}","starred_url":"https://api.github.com/users/kriscross07/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kriscross07/subscriptions","organizations_url":"https://api.github.com/users/kriscross07/orgs","repos_url":"https://api.github.com/users/kriscross07/repos","events_url":"https://api.github.com/users/kriscross07/events{/privacy}","received_events_url":"https://api.github.com/users/kriscross07/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":2,"additions":6,"deletions":3,"changed_files":2}}