{"action":"created","comment":{"url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments/74022960","id":74022960,"diff_hunk":"@@ -85,6 +86,11 @@ Runnable prepareMergeRunnable() {\n                     }\n                     // Clear all records either owned or backup\n                     cacheRecordStore.clear();\n+\n+                    // send the cache invalidation event regardless if any actually cleared or not (no need to know how many\n+                    // actually cleared)\n+                    final CacheService cacheService = nodeEngine.getService(CacheService.SERVICE_NAME);\n+                    cacheService.sendInvalidationEvent(cacheName, null, SOURCE_NOT_AVAILABLE);","path":"hazelcast/src/main/java/com/hazelcast/cache/impl/CacheSplitBrainHandler.java","position":16,"original_position":16,"commit_id":"2657032e17ddd1b4393898219a1ffff7cbb55336","original_commit_id":"2657032e17ddd1b4393898219a1ffff7cbb55336","user":{"login":"ahmetmircik","id":2960360,"avatar_url":"https://avatars.githubusercontent.com/u/2960360?v=3","gravatar_id":"","url":"https://api.github.com/users/ahmetmircik","html_url":"https://github.com/ahmetmircik","followers_url":"https://api.github.com/users/ahmetmircik/followers","following_url":"https://api.github.com/users/ahmetmircik/following{/other_user}","gists_url":"https://api.github.com/users/ahmetmircik/gists{/gist_id}","starred_url":"https://api.github.com/users/ahmetmircik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahmetmircik/subscriptions","organizations_url":"https://api.github.com/users/ahmetmircik/orgs","repos_url":"https://api.github.com/users/ahmetmircik/repos","events_url":"https://api.github.com/users/ahmetmircik/events{/privacy}","received_events_url":"https://api.github.com/users/ahmetmircik/received_events","type":"User","site_admin":false},"body":"i see thanks","created_at":"2016-08-09T09:05:08Z","updated_at":"2016-08-09T09:05:08Z","html_url":"https://github.com/hazelcast/hazelcast/pull/8649#discussion_r74022960","pull_request_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/8649","_links":{"self":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments/74022960"},"html":{"href":"https://github.com/hazelcast/hazelcast/pull/8649#discussion_r74022960"},"pull_request":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/8649"}}},"pull_request":{"url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/8649","id":79698550,"html_url":"https://github.com/hazelcast/hazelcast/pull/8649","diff_url":"https://github.com/hazelcast/hazelcast/pull/8649.diff","patch_url":"https://github.com/hazelcast/hazelcast/pull/8649.patch","issue_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/8649","number":8649,"state":"open","locked":false,"title":"Too many client cache Invalidation callbacks for a single ICache.clear call","user":{"login":"ihsandemir","id":7543261,"avatar_url":"https://avatars.githubusercontent.com/u/7543261?v=3","gravatar_id":"","url":"https://api.github.com/users/ihsandemir","html_url":"https://github.com/ihsandemir","followers_url":"https://api.github.com/users/ihsandemir/followers","following_url":"https://api.github.com/users/ihsandemir/following{/other_user}","gists_url":"https://api.github.com/users/ihsandemir/gists{/gist_id}","starred_url":"https://api.github.com/users/ihsandemir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ihsandemir/subscriptions","organizations_url":"https://api.github.com/users/ihsandemir/orgs","repos_url":"https://api.github.com/users/ihsandemir/repos","events_url":"https://api.github.com/users/ihsandemir/events{/privacy}","received_events_url":"https://api.github.com/users/ihsandemir/received_events","type":"User","site_admin":false},"body":"Fix for decreasing the cache clear callbacks for the client for a single clear request. Current implementation can cause up to partition count callbacks for a single clear request. One ICache.clear call causes up to partitioncount callbacks to clientcacheinvalidation listener and the same number of near cache clears. This may really be a high number of callbacks and too many cache invalidations if the partition count is a high number. \r\n\r\nThe side affect of eliminating the can invalidation event sending during cache store clear needs to be investigated since AbstractCacheRecordStore.clear is being called from a few other places which may have been affected.\r\n\r\nRelated to issue #8593 ","created_at":"2016-08-02T08:56:56Z","updated_at":"2016-08-09T09:05:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"16cd547126680ea00a97c995319d31fe0182fa42","assignee":{"login":"ihsandemir","id":7543261,"avatar_url":"https://avatars.githubusercontent.com/u/7543261?v=3","gravatar_id":"","url":"https://api.github.com/users/ihsandemir","html_url":"https://github.com/ihsandemir","followers_url":"https://api.github.com/users/ihsandemir/followers","following_url":"https://api.github.com/users/ihsandemir/following{/other_user}","gists_url":"https://api.github.com/users/ihsandemir/gists{/gist_id}","starred_url":"https://api.github.com/users/ihsandemir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ihsandemir/subscriptions","organizations_url":"https://api.github.com/users/ihsandemir/orgs","repos_url":"https://api.github.com/users/ihsandemir/repos","events_url":"https://api.github.com/users/ihsandemir/events{/privacy}","received_events_url":"https://api.github.com/users/ihsandemir/received_events","type":"User","site_admin":false},"assignees":[{"login":"ihsandemir","id":7543261,"avatar_url":"https://avatars.githubusercontent.com/u/7543261?v=3","gravatar_id":"","url":"https://api.github.com/users/ihsandemir","html_url":"https://github.com/ihsandemir","followers_url":"https://api.github.com/users/ihsandemir/followers","following_url":"https://api.github.com/users/ihsandemir/following{/other_user}","gists_url":"https://api.github.com/users/ihsandemir/gists{/gist_id}","starred_url":"https://api.github.com/users/ihsandemir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ihsandemir/subscriptions","organizations_url":"https://api.github.com/users/ihsandemir/orgs","repos_url":"https://api.github.com/users/ihsandemir/repos","events_url":"https://api.github.com/users/ihsandemir/events{/privacy}","received_events_url":"https://api.github.com/users/ihsandemir/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/hazelcast/hazelcast/milestones/79","html_url":"https://github.com/hazelcast/hazelcast/milestones/3.7.1","labels_url":"https://api.github.com/repos/hazelcast/hazelcast/milestones/79/labels","id":1911159,"number":79,"title":"3.7.1","description":"","creator":{"login":"ahmetmircik","id":2960360,"avatar_url":"https://avatars.githubusercontent.com/u/2960360?v=3","gravatar_id":"","url":"https://api.github.com/users/ahmetmircik","html_url":"https://github.com/ahmetmircik","followers_url":"https://api.github.com/users/ahmetmircik/followers","following_url":"https://api.github.com/users/ahmetmircik/following{/other_user}","gists_url":"https://api.github.com/users/ahmetmircik/gists{/gist_id}","starred_url":"https://api.github.com/users/ahmetmircik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahmetmircik/subscriptions","organizations_url":"https://api.github.com/users/ahmetmircik/orgs","repos_url":"https://api.github.com/users/ahmetmircik/repos","events_url":"https://api.github.com/users/ahmetmircik/events{/privacy}","received_events_url":"https://api.github.com/users/ahmetmircik/received_events","type":"User","site_admin":false},"open_issues":24,"closed_issues":2,"state":"open","created_at":"2016-07-29T07:37:28Z","updated_at":"2016-08-09T08:59:04Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/8649/commits","review_comments_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/8649/comments","review_comment_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/8649/comments","statuses_url":"https://api.github.com/repos/hazelcast/hazelcast/statuses/2657032e17ddd1b4393898219a1ffff7cbb55336","head":{"label":"ihsandemir:cacheClearInvalidationFix","ref":"cacheClearInvalidationFix","sha":"2657032e17ddd1b4393898219a1ffff7cbb55336","user":{"login":"ihsandemir","id":7543261,"avatar_url":"https://avatars.githubusercontent.com/u/7543261?v=3","gravatar_id":"","url":"https://api.github.com/users/ihsandemir","html_url":"https://github.com/ihsandemir","followers_url":"https://api.github.com/users/ihsandemir/followers","following_url":"https://api.github.com/users/ihsandemir/following{/other_user}","gists_url":"https://api.github.com/users/ihsandemir/gists{/gist_id}","starred_url":"https://api.github.com/users/ihsandemir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ihsandemir/subscriptions","organizations_url":"https://api.github.com/users/ihsandemir/orgs","repos_url":"https://api.github.com/users/ihsandemir/repos","events_url":"https://api.github.com/users/ihsandemir/events{/privacy}","received_events_url":"https://api.github.com/users/ihsandemir/received_events","type":"User","site_admin":false},"repo":{"id":37186359,"name":"hazelcast","full_name":"ihsandemir/hazelcast","owner":{"login":"ihsandemir","id":7543261,"avatar_url":"https://avatars.githubusercontent.com/u/7543261?v=3","gravatar_id":"","url":"https://api.github.com/users/ihsandemir","html_url":"https://github.com/ihsandemir","followers_url":"https://api.github.com/users/ihsandemir/followers","following_url":"https://api.github.com/users/ihsandemir/following{/other_user}","gists_url":"https://api.github.com/users/ihsandemir/gists{/gist_id}","starred_url":"https://api.github.com/users/ihsandemir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ihsandemir/subscriptions","organizations_url":"https://api.github.com/users/ihsandemir/orgs","repos_url":"https://api.github.com/users/ihsandemir/repos","events_url":"https://api.github.com/users/ihsandemir/events{/privacy}","received_events_url":"https://api.github.com/users/ihsandemir/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ihsandemir/hazelcast","description":"Open Source In-Memory Data Grid","fork":true,"url":"https://api.github.com/repos/ihsandemir/hazelcast","forks_url":"https://api.github.com/repos/ihsandemir/hazelcast/forks","keys_url":"https://api.github.com/repos/ihsandemir/hazelcast/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ihsandemir/hazelcast/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ihsandemir/hazelcast/teams","hooks_url":"https://api.github.com/repos/ihsandemir/hazelcast/hooks","issue_events_url":"https://api.github.com/repos/ihsandemir/hazelcast/issues/events{/number}","events_url":"https://api.github.com/repos/ihsandemir/hazelcast/events","assignees_url":"https://api.github.com/repos/ihsandemir/hazelcast/assignees{/user}","branches_url":"https://api.github.com/repos/ihsandemir/hazelcast/branches{/branch}","tags_url":"https://api.github.com/repos/ihsandemir/hazelcast/tags","blobs_url":"https://api.github.com/repos/ihsandemir/hazelcast/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ihsandemir/hazelcast/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ihsandemir/hazelcast/git/refs{/sha}","trees_url":"https://api.github.com/repos/ihsandemir/hazelcast/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ihsandemir/hazelcast/statuses/{sha}","languages_url":"https://api.github.com/repos/ihsandemir/hazelcast/languages","stargazers_url":"https://api.github.com/repos/ihsandemir/hazelcast/stargazers","contributors_url":"https://api.github.com/repos/ihsandemir/hazelcast/contributors","subscribers_url":"https://api.github.com/repos/ihsandemir/hazelcast/subscribers","subscription_url":"https://api.github.com/repos/ihsandemir/hazelcast/subscription","commits_url":"https://api.github.com/repos/ihsandemir/hazelcast/commits{/sha}","git_commits_url":"https://api.github.com/repos/ihsandemir/hazelcast/git/commits{/sha}","comments_url":"https://api.github.com/repos/ihsandemir/hazelcast/comments{/number}","issue_comment_url":"https://api.github.com/repos/ihsandemir/hazelcast/issues/comments{/number}","contents_url":"https://api.github.com/repos/ihsandemir/hazelcast/contents/{+path}","compare_url":"https://api.github.com/repos/ihsandemir/hazelcast/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ihsandemir/hazelcast/merges","archive_url":"https://api.github.com/repos/ihsandemir/hazelcast/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ihsandemir/hazelcast/downloads","issues_url":"https://api.github.com/repos/ihsandemir/hazelcast/issues{/number}","pulls_url":"https://api.github.com/repos/ihsandemir/hazelcast/pulls{/number}","milestones_url":"https://api.github.com/repos/ihsandemir/hazelcast/milestones{/number}","notifications_url":"https://api.github.com/repos/ihsandemir/hazelcast/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ihsandemir/hazelcast/labels{/name}","releases_url":"https://api.github.com/repos/ihsandemir/hazelcast/releases{/id}","deployments_url":"https://api.github.com/repos/ihsandemir/hazelcast/deployments","created_at":"2015-06-10T08:58:34Z","updated_at":"2015-06-10T08:58:48Z","pushed_at":"2016-08-05T23:01:22Z","git_url":"git://github.com/ihsandemir/hazelcast.git","ssh_url":"git@github.com:ihsandemir/hazelcast.git","clone_url":"https://github.com/ihsandemir/hazelcast.git","svn_url":"https://github.com/ihsandemir/hazelcast","homepage":"www.hazelcast.com","size":95616,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hazelcast:maintenance-3.x","ref":"maintenance-3.x","sha":"98e1deb95cc519fc801d748f374e1efc2a7db7d0","user":{"login":"hazelcast","id":1453152,"avatar_url":"https://avatars.githubusercontent.com/u/1453152?v=3","gravatar_id":"","url":"https://api.github.com/users/hazelcast","html_url":"https://github.com/hazelcast","followers_url":"https://api.github.com/users/hazelcast/followers","following_url":"https://api.github.com/users/hazelcast/following{/other_user}","gists_url":"https://api.github.com/users/hazelcast/gists{/gist_id}","starred_url":"https://api.github.com/users/hazelcast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hazelcast/subscriptions","organizations_url":"https://api.github.com/users/hazelcast/orgs","repos_url":"https://api.github.com/users/hazelcast/repos","events_url":"https://api.github.com/users/hazelcast/events{/privacy}","received_events_url":"https://api.github.com/users/hazelcast/received_events","type":"Organization","site_admin":false},"repo":{"id":3786237,"name":"hazelcast","full_name":"hazelcast/hazelcast","owner":{"login":"hazelcast","id":1453152,"avatar_url":"https://avatars.githubusercontent.com/u/1453152?v=3","gravatar_id":"","url":"https://api.github.com/users/hazelcast","html_url":"https://github.com/hazelcast","followers_url":"https://api.github.com/users/hazelcast/followers","following_url":"https://api.github.com/users/hazelcast/following{/other_user}","gists_url":"https://api.github.com/users/hazelcast/gists{/gist_id}","starred_url":"https://api.github.com/users/hazelcast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hazelcast/subscriptions","organizations_url":"https://api.github.com/users/hazelcast/orgs","repos_url":"https://api.github.com/users/hazelcast/repos","events_url":"https://api.github.com/users/hazelcast/events{/privacy}","received_events_url":"https://api.github.com/users/hazelcast/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hazelcast/hazelcast","description":"Open Source In-Memory Data Grid","fork":false,"url":"https://api.github.com/repos/hazelcast/hazelcast","forks_url":"https://api.github.com/repos/hazelcast/hazelcast/forks","keys_url":"https://api.github.com/repos/hazelcast/hazelcast/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hazelcast/hazelcast/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hazelcast/hazelcast/teams","hooks_url":"https://api.github.com/repos/hazelcast/hazelcast/hooks","issue_events_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/events{/number}","events_url":"https://api.github.com/repos/hazelcast/hazelcast/events","assignees_url":"https://api.github.com/repos/hazelcast/hazelcast/assignees{/user}","branches_url":"https://api.github.com/repos/hazelcast/hazelcast/branches{/branch}","tags_url":"https://api.github.com/repos/hazelcast/hazelcast/tags","blobs_url":"https://api.github.com/repos/hazelcast/hazelcast/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hazelcast/hazelcast/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hazelcast/hazelcast/git/refs{/sha}","trees_url":"https://api.github.com/repos/hazelcast/hazelcast/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hazelcast/hazelcast/statuses/{sha}","languages_url":"https://api.github.com/repos/hazelcast/hazelcast/languages","stargazers_url":"https://api.github.com/repos/hazelcast/hazelcast/stargazers","contributors_url":"https://api.github.com/repos/hazelcast/hazelcast/contributors","subscribers_url":"https://api.github.com/repos/hazelcast/hazelcast/subscribers","subscription_url":"https://api.github.com/repos/hazelcast/hazelcast/subscription","commits_url":"https://api.github.com/repos/hazelcast/hazelcast/commits{/sha}","git_commits_url":"https://api.github.com/repos/hazelcast/hazelcast/git/commits{/sha}","comments_url":"https://api.github.com/repos/hazelcast/hazelcast/comments{/number}","issue_comment_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/comments{/number}","contents_url":"https://api.github.com/repos/hazelcast/hazelcast/contents/{+path}","compare_url":"https://api.github.com/repos/hazelcast/hazelcast/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hazelcast/hazelcast/merges","archive_url":"https://api.github.com/repos/hazelcast/hazelcast/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hazelcast/hazelcast/downloads","issues_url":"https://api.github.com/repos/hazelcast/hazelcast/issues{/number}","pulls_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls{/number}","milestones_url":"https://api.github.com/repos/hazelcast/hazelcast/milestones{/number}","notifications_url":"https://api.github.com/repos/hazelcast/hazelcast/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hazelcast/hazelcast/labels{/name}","releases_url":"https://api.github.com/repos/hazelcast/hazelcast/releases{/id}","deployments_url":"https://api.github.com/repos/hazelcast/hazelcast/deployments","created_at":"2012-03-21T12:25:18Z","updated_at":"2016-08-09T07:13:02Z","pushed_at":"2016-08-09T08:15:00Z","git_url":"git://github.com/hazelcast/hazelcast.git","ssh_url":"git@github.com:hazelcast/hazelcast.git","clone_url":"https://github.com/hazelcast/hazelcast.git","svn_url":"https://github.com/hazelcast/hazelcast","homepage":"www.hazelcast.com","size":130877,"stargazers_count":1677,"watchers_count":1677,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":783,"mirror_url":null,"open_issues_count":522,"forks":783,"open_issues":522,"watchers":1677,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/8649"},"html":{"href":"https://github.com/hazelcast/hazelcast/pull/8649"},"issue":{"href":"https://api.github.com/repos/hazelcast/hazelcast/issues/8649"},"comments":{"href":"https://api.github.com/repos/hazelcast/hazelcast/issues/8649/comments"},"review_comments":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/8649/comments"},"review_comment":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/8649/commits"},"statuses":{"href":"https://api.github.com/repos/hazelcast/hazelcast/statuses/2657032e17ddd1b4393898219a1ffff7cbb55336"}}}}
{"actor":{"display_login":"ahmetmircik"}}