{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/64822112","id":64822112,"diff_hunk":"@@ -0,0 +1,44 @@\n+apiVersion: v1","path":"hack/testdata/broken-rc-for-validate-test.yaml","position":1,"original_position":1,"commit_id":"41978b78b17cc870776a299305ca7675ebcb1008","original_commit_id":"41978b78b17cc870776a299305ca7675ebcb1008","user":{"login":"nikhiljindal","id":10199099,"avatar_url":"https://avatars.githubusercontent.com/u/10199099?v=3","gravatar_id":"","url":"https://api.github.com/users/nikhiljindal","html_url":"https://github.com/nikhiljindal","followers_url":"https://api.github.com/users/nikhiljindal/followers","following_url":"https://api.github.com/users/nikhiljindal/following{/other_user}","gists_url":"https://api.github.com/users/nikhiljindal/gists{/gist_id}","starred_url":"https://api.github.com/users/nikhiljindal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikhiljindal/subscriptions","organizations_url":"https://api.github.com/users/nikhiljindal/orgs","repos_url":"https://api.github.com/users/nikhiljindal/repos","events_url":"https://api.github.com/users/nikhiljindal/events{/privacy}","received_events_url":"https://api.github.com/users/nikhiljindal/received_events","type":"User","site_admin":false},"body":"Is `invalid-rc-with-empty-args` a better name (clearer why it is broken)","created_at":"2016-05-26T21:14:51Z","updated_at":"2016-05-26T21:14:51Z","html_url":"https://github.com/kubernetes/kubernetes/pull/25709#discussion_r64822112","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25709","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/64822112"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/25709#discussion_r64822112"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25709"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25709","id":70289582,"html_url":"https://github.com/kubernetes/kubernetes/pull/25709","diff_url":"https://github.com/kubernetes/kubernetes/pull/25709.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/25709.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/25709","number":25709,"state":"open","locked":false,"title":"Check for an empty value in validateField","user":{"login":"asalkeld","id":420707,"avatar_url":"https://avatars.githubusercontent.com/u/420707?v=3","gravatar_id":"","url":"https://api.github.com/users/asalkeld","html_url":"https://github.com/asalkeld","followers_url":"https://api.github.com/users/asalkeld/followers","following_url":"https://api.github.com/users/asalkeld/following{/other_user}","gists_url":"https://api.github.com/users/asalkeld/gists{/gist_id}","starred_url":"https://api.github.com/users/asalkeld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asalkeld/subscriptions","organizations_url":"https://api.github.com/users/asalkeld/orgs","repos_url":"https://api.github.com/users/asalkeld/repos","events_url":"https://api.github.com/users/asalkeld/events{/privacy}","received_events_url":"https://api.github.com/users/asalkeld/received_events","type":"User","site_admin":false},"body":"```release-note\r\n* Fix a panic when args was not supplied with any values.\r\n```\r\n\r\nreflect.TypeOf() can take a nil (it then returns a nil), but\r\nKind() panics on a nil.\r\n\r\nNow the user gets the following output:\r\n./kubectl.sh --server=http://localhost:8080 create -f ../../test-files/test-rc.yaml\r\nerror validating \"../../test-files/test-rc.yaml\": error validating data: unexpected nil value for field spec.template.spec.containers[0].args[0]; if you choose to ignore these errors, turn validation off with --validate=false\r\n\r\nfixes #20627","created_at":"2016-05-17T02:01:50Z","updated_at":"2016-05-26T21:14:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6fdb2c1525edcaf141cf6e74b57cf6f81550ad9e","assignee":{"login":"nikhiljindal","id":10199099,"avatar_url":"https://avatars.githubusercontent.com/u/10199099?v=3","gravatar_id":"","url":"https://api.github.com/users/nikhiljindal","html_url":"https://github.com/nikhiljindal","followers_url":"https://api.github.com/users/nikhiljindal/followers","following_url":"https://api.github.com/users/nikhiljindal/following{/other_user}","gists_url":"https://api.github.com/users/nikhiljindal/gists{/gist_id}","starred_url":"https://api.github.com/users/nikhiljindal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikhiljindal/subscriptions","organizations_url":"https://api.github.com/users/nikhiljindal/orgs","repos_url":"https://api.github.com/users/nikhiljindal/repos","events_url":"https://api.github.com/users/nikhiljindal/events{/privacy}","received_events_url":"https://api.github.com/users/nikhiljindal/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25709/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25709/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/25709/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/41978b78b17cc870776a299305ca7675ebcb1008","head":{"label":"asalkeld:null-deref","ref":"null-deref","sha":"41978b78b17cc870776a299305ca7675ebcb1008","user":{"login":"asalkeld","id":420707,"avatar_url":"https://avatars.githubusercontent.com/u/420707?v=3","gravatar_id":"","url":"https://api.github.com/users/asalkeld","html_url":"https://github.com/asalkeld","followers_url":"https://api.github.com/users/asalkeld/followers","following_url":"https://api.github.com/users/asalkeld/following{/other_user}","gists_url":"https://api.github.com/users/asalkeld/gists{/gist_id}","starred_url":"https://api.github.com/users/asalkeld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asalkeld/subscriptions","organizations_url":"https://api.github.com/users/asalkeld/orgs","repos_url":"https://api.github.com/users/asalkeld/repos","events_url":"https://api.github.com/users/asalkeld/events{/privacy}","received_events_url":"https://api.github.com/users/asalkeld/received_events","type":"User","site_admin":false},"repo":{"id":58418755,"name":"kubernetes","full_name":"asalkeld/kubernetes","owner":{"login":"asalkeld","id":420707,"avatar_url":"https://avatars.githubusercontent.com/u/420707?v=3","gravatar_id":"","url":"https://api.github.com/users/asalkeld","html_url":"https://github.com/asalkeld","followers_url":"https://api.github.com/users/asalkeld/followers","following_url":"https://api.github.com/users/asalkeld/following{/other_user}","gists_url":"https://api.github.com/users/asalkeld/gists{/gist_id}","starred_url":"https://api.github.com/users/asalkeld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asalkeld/subscriptions","organizations_url":"https://api.github.com/users/asalkeld/orgs","repos_url":"https://api.github.com/users/asalkeld/repos","events_url":"https://api.github.com/users/asalkeld/events{/privacy}","received_events_url":"https://api.github.com/users/asalkeld/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/asalkeld/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/asalkeld/kubernetes","forks_url":"https://api.github.com/repos/asalkeld/kubernetes/forks","keys_url":"https://api.github.com/repos/asalkeld/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/asalkeld/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/asalkeld/kubernetes/teams","hooks_url":"https://api.github.com/repos/asalkeld/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/asalkeld/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/asalkeld/kubernetes/events","assignees_url":"https://api.github.com/repos/asalkeld/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/asalkeld/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/asalkeld/kubernetes/tags","blobs_url":"https://api.github.com/repos/asalkeld/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/asalkeld/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/asalkeld/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/asalkeld/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/asalkeld/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/asalkeld/kubernetes/languages","stargazers_url":"https://api.github.com/repos/asalkeld/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/asalkeld/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/asalkeld/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/asalkeld/kubernetes/subscription","commits_url":"https://api.github.com/repos/asalkeld/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/asalkeld/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/asalkeld/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/asalkeld/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/asalkeld/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/asalkeld/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/asalkeld/kubernetes/merges","archive_url":"https://api.github.com/repos/asalkeld/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/asalkeld/kubernetes/downloads","issues_url":"https://api.github.com/repos/asalkeld/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/asalkeld/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/asalkeld/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/asalkeld/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/asalkeld/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/asalkeld/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/asalkeld/kubernetes/deployments","created_at":"2016-05-10T01:04:58Z","updated_at":"2016-05-10T01:05:12Z","pushed_at":"2016-05-26T04:33:22Z","git_url":"git://github.com/asalkeld/kubernetes.git","ssh_url":"git@github.com:asalkeld/kubernetes.git","clone_url":"https://github.com/asalkeld/kubernetes.git","svn_url":"https://github.com/asalkeld/kubernetes","homepage":"http://kubernetes.io","size":244980,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"505fb857260bc2f661d70c59037e6a1328020891","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-05-26T20:31:43Z","pushed_at":"2016-05-26T21:14:43Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":450834,"stargazers_count":14602,"watchers_count":14602,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4456,"mirror_url":null,"open_issues_count":3714,"forks":4456,"open_issues":3714,"watchers":14602,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25709"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/25709"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/25709"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/25709/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25709/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25709/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/41978b78b17cc870776a299305ca7675ebcb1008"}}}}
{"actor":{"display_login":"nikhiljindal"}}