{"action":"opened","number":313,"pull_request":{"url":"https://api.github.com/repos/USGS-R/gsplot/pulls/313","id":65911142,"html_url":"https://github.com/USGS-R/gsplot/pull/313","diff_url":"https://github.com/USGS-R/gsplot/pull/313.diff","patch_url":"https://github.com/USGS-R/gsplot/pull/313.patch","issue_url":"https://api.github.com/repos/USGS-R/gsplot/issues/313","number":313,"state":"open","locked":false,"title":"Iso sides","user":{"login":"jread-usgs","id":2349007,"avatar_url":"https://avatars.githubusercontent.com/u/2349007?v=3","gravatar_id":"","url":"https://api.github.com/users/jread-usgs","html_url":"https://github.com/jread-usgs","followers_url":"https://api.github.com/users/jread-usgs/followers","following_url":"https://api.github.com/users/jread-usgs/following{/other_user}","gists_url":"https://api.github.com/users/jread-usgs/gists{/gist_id}","starred_url":"https://api.github.com/users/jread-usgs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jread-usgs/subscriptions","organizations_url":"https://api.github.com/users/jread-usgs/orgs","repos_url":"https://api.github.com/users/jread-usgs/repos","events_url":"https://api.github.com/users/jread-usgs/events{/privacy}","received_events_url":"https://api.github.com/users/jread-usgs/received_events","type":"User","site_admin":false},"body":"WIP for #290 \r\n\r\nThis is a partial for that, because it \r\n - [ ] doesn't include putting logs in the sides (they are in `view.x.y.$window` still). \r\n - [ ] breaks a number of tests right now (~8 failures)\r\n - [ ] changes the `logged` functions to return `sides.n` instead of `sides.x.y` which is probably an API-breaker for some if they were using that\r\n - [ ] doesn't use the `yaxs` and `xaxs` args. The logic for those is still in the PR, but is commented out. I wasn't sure what was going on before\r\n - [ ] doesn't include documentation on the new changes/function\r\n - [ ] no tests for the new stuff \r\n\r\nBut, this does get us most of the way to #290 issue, and also I think addresses some speed issues I ran into when creating very large lists. **now**, the `set_side_lim()` (was `set_view_lim()`) only extracts args from the most recent addition to the list, instead of all (which is what was happening before). It also short-circuits the limit extraction when the user limits are fully defined (min and max). I think both of these additions will make it quite a bit faster, but I haven't tested. \r\n\r\nAlso, I noticed that the window$log function isn't really working as expected, and I don't think it has anything to do with this PR. For example, when you have view.1.2 and view.3.2 and log y for one of those, it doesn't also log y for the other view. This causes one of the test failures due to the way I am using `logged` now. \r\n\r\nfeedback welcome. I will keep this open while I chip away at some of the remaining pieces. ","created_at":"2016-04-10T13:57:48Z","updated_at":"2016-04-10T13:57:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/USGS-R/gsplot/pulls/313/commits","review_comments_url":"https://api.github.com/repos/USGS-R/gsplot/pulls/313/comments","review_comment_url":"https://api.github.com/repos/USGS-R/gsplot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/USGS-R/gsplot/issues/313/comments","statuses_url":"https://api.github.com/repos/USGS-R/gsplot/statuses/6b351930de04ccbbced4be2c81ed9911d1520550","head":{"label":"jread-usgs:iso_sides","ref":"iso_sides","sha":"6b351930de04ccbbced4be2c81ed9911d1520550","user":{"login":"jread-usgs","id":2349007,"avatar_url":"https://avatars.githubusercontent.com/u/2349007?v=3","gravatar_id":"","url":"https://api.github.com/users/jread-usgs","html_url":"https://github.com/jread-usgs","followers_url":"https://api.github.com/users/jread-usgs/followers","following_url":"https://api.github.com/users/jread-usgs/following{/other_user}","gists_url":"https://api.github.com/users/jread-usgs/gists{/gist_id}","starred_url":"https://api.github.com/users/jread-usgs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jread-usgs/subscriptions","organizations_url":"https://api.github.com/users/jread-usgs/orgs","repos_url":"https://api.github.com/users/jread-usgs/repos","events_url":"https://api.github.com/users/jread-usgs/events{/privacy}","received_events_url":"https://api.github.com/users/jread-usgs/received_events","type":"User","site_admin":false},"repo":{"id":37484990,"name":"gsplot","full_name":"jread-usgs/gsplot","owner":{"login":"jread-usgs","id":2349007,"avatar_url":"https://avatars.githubusercontent.com/u/2349007?v=3","gravatar_id":"","url":"https://api.github.com/users/jread-usgs","html_url":"https://github.com/jread-usgs","followers_url":"https://api.github.com/users/jread-usgs/followers","following_url":"https://api.github.com/users/jread-usgs/following{/other_user}","gists_url":"https://api.github.com/users/jread-usgs/gists{/gist_id}","starred_url":"https://api.github.com/users/jread-usgs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jread-usgs/subscriptions","organizations_url":"https://api.github.com/users/jread-usgs/orgs","repos_url":"https://api.github.com/users/jread-usgs/repos","events_url":"https://api.github.com/users/jread-usgs/events{/privacy}","received_events_url":"https://api.github.com/users/jread-usgs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jread-usgs/gsplot","description":"plotting foundation for timeseries reporting","fork":true,"url":"https://api.github.com/repos/jread-usgs/gsplot","forks_url":"https://api.github.com/repos/jread-usgs/gsplot/forks","keys_url":"https://api.github.com/repos/jread-usgs/gsplot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jread-usgs/gsplot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jread-usgs/gsplot/teams","hooks_url":"https://api.github.com/repos/jread-usgs/gsplot/hooks","issue_events_url":"https://api.github.com/repos/jread-usgs/gsplot/issues/events{/number}","events_url":"https://api.github.com/repos/jread-usgs/gsplot/events","assignees_url":"https://api.github.com/repos/jread-usgs/gsplot/assignees{/user}","branches_url":"https://api.github.com/repos/jread-usgs/gsplot/branches{/branch}","tags_url":"https://api.github.com/repos/jread-usgs/gsplot/tags","blobs_url":"https://api.github.com/repos/jread-usgs/gsplot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jread-usgs/gsplot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jread-usgs/gsplot/git/refs{/sha}","trees_url":"https://api.github.com/repos/jread-usgs/gsplot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jread-usgs/gsplot/statuses/{sha}","languages_url":"https://api.github.com/repos/jread-usgs/gsplot/languages","stargazers_url":"https://api.github.com/repos/jread-usgs/gsplot/stargazers","contributors_url":"https://api.github.com/repos/jread-usgs/gsplot/contributors","subscribers_url":"https://api.github.com/repos/jread-usgs/gsplot/subscribers","subscription_url":"https://api.github.com/repos/jread-usgs/gsplot/subscription","commits_url":"https://api.github.com/repos/jread-usgs/gsplot/commits{/sha}","git_commits_url":"https://api.github.com/repos/jread-usgs/gsplot/git/commits{/sha}","comments_url":"https://api.github.com/repos/jread-usgs/gsplot/comments{/number}","issue_comment_url":"https://api.github.com/repos/jread-usgs/gsplot/issues/comments{/number}","contents_url":"https://api.github.com/repos/jread-usgs/gsplot/contents/{+path}","compare_url":"https://api.github.com/repos/jread-usgs/gsplot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jread-usgs/gsplot/merges","archive_url":"https://api.github.com/repos/jread-usgs/gsplot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jread-usgs/gsplot/downloads","issues_url":"https://api.github.com/repos/jread-usgs/gsplot/issues{/number}","pulls_url":"https://api.github.com/repos/jread-usgs/gsplot/pulls{/number}","milestones_url":"https://api.github.com/repos/jread-usgs/gsplot/milestones{/number}","notifications_url":"https://api.github.com/repos/jread-usgs/gsplot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jread-usgs/gsplot/labels{/name}","releases_url":"https://api.github.com/repos/jread-usgs/gsplot/releases{/id}","deployments_url":"https://api.github.com/repos/jread-usgs/gsplot/deployments","created_at":"2015-06-15T18:59:47Z","updated_at":"2016-04-09T13:01:08Z","pushed_at":"2016-04-10T13:39:35Z","git_url":"git://github.com/jread-usgs/gsplot.git","ssh_url":"git@github.com:jread-usgs/gsplot.git","clone_url":"https://github.com/jread-usgs/gsplot.git","svn_url":"https://github.com/jread-usgs/gsplot","homepage":"","size":2665,"stargazers_count":0,"watchers_count":0,"language":"R","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"USGS-R:iso_sides","ref":"iso_sides","sha":"21368afb2c22e27fe1620a82a683ec87354fa044","user":{"login":"USGS-R","id":3188813,"avatar_url":"https://avatars.githubusercontent.com/u/3188813?v=3","gravatar_id":"","url":"https://api.github.com/users/USGS-R","html_url":"https://github.com/USGS-R","followers_url":"https://api.github.com/users/USGS-R/followers","following_url":"https://api.github.com/users/USGS-R/following{/other_user}","gists_url":"https://api.github.com/users/USGS-R/gists{/gist_id}","starred_url":"https://api.github.com/users/USGS-R/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/USGS-R/subscriptions","organizations_url":"https://api.github.com/users/USGS-R/orgs","repos_url":"https://api.github.com/users/USGS-R/repos","events_url":"https://api.github.com/users/USGS-R/events{/privacy}","received_events_url":"https://api.github.com/users/USGS-R/received_events","type":"Organization","site_admin":false},"repo":{"id":37219882,"name":"gsplot","full_name":"USGS-R/gsplot","owner":{"login":"USGS-R","id":3188813,"avatar_url":"https://avatars.githubusercontent.com/u/3188813?v=3","gravatar_id":"","url":"https://api.github.com/users/USGS-R","html_url":"https://github.com/USGS-R","followers_url":"https://api.github.com/users/USGS-R/followers","following_url":"https://api.github.com/users/USGS-R/following{/other_user}","gists_url":"https://api.github.com/users/USGS-R/gists{/gist_id}","starred_url":"https://api.github.com/users/USGS-R/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/USGS-R/subscriptions","organizations_url":"https://api.github.com/users/USGS-R/orgs","repos_url":"https://api.github.com/users/USGS-R/repos","events_url":"https://api.github.com/users/USGS-R/events{/privacy}","received_events_url":"https://api.github.com/users/USGS-R/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/USGS-R/gsplot","description":"plotting foundation for timeseries reporting","fork":false,"url":"https://api.github.com/repos/USGS-R/gsplot","forks_url":"https://api.github.com/repos/USGS-R/gsplot/forks","keys_url":"https://api.github.com/repos/USGS-R/gsplot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/USGS-R/gsplot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/USGS-R/gsplot/teams","hooks_url":"https://api.github.com/repos/USGS-R/gsplot/hooks","issue_events_url":"https://api.github.com/repos/USGS-R/gsplot/issues/events{/number}","events_url":"https://api.github.com/repos/USGS-R/gsplot/events","assignees_url":"https://api.github.com/repos/USGS-R/gsplot/assignees{/user}","branches_url":"https://api.github.com/repos/USGS-R/gsplot/branches{/branch}","tags_url":"https://api.github.com/repos/USGS-R/gsplot/tags","blobs_url":"https://api.github.com/repos/USGS-R/gsplot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/USGS-R/gsplot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/USGS-R/gsplot/git/refs{/sha}","trees_url":"https://api.github.com/repos/USGS-R/gsplot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/USGS-R/gsplot/statuses/{sha}","languages_url":"https://api.github.com/repos/USGS-R/gsplot/languages","stargazers_url":"https://api.github.com/repos/USGS-R/gsplot/stargazers","contributors_url":"https://api.github.com/repos/USGS-R/gsplot/contributors","subscribers_url":"https://api.github.com/repos/USGS-R/gsplot/subscribers","subscription_url":"https://api.github.com/repos/USGS-R/gsplot/subscription","commits_url":"https://api.github.com/repos/USGS-R/gsplot/commits{/sha}","git_commits_url":"https://api.github.com/repos/USGS-R/gsplot/git/commits{/sha}","comments_url":"https://api.github.com/repos/USGS-R/gsplot/comments{/number}","issue_comment_url":"https://api.github.com/repos/USGS-R/gsplot/issues/comments{/number}","contents_url":"https://api.github.com/repos/USGS-R/gsplot/contents/{+path}","compare_url":"https://api.github.com/repos/USGS-R/gsplot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/USGS-R/gsplot/merges","archive_url":"https://api.github.com/repos/USGS-R/gsplot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/USGS-R/gsplot/downloads","issues_url":"https://api.github.com/repos/USGS-R/gsplot/issues{/number}","pulls_url":"https://api.github.com/repos/USGS-R/gsplot/pulls{/number}","milestones_url":"https://api.github.com/repos/USGS-R/gsplot/milestones{/number}","notifications_url":"https://api.github.com/repos/USGS-R/gsplot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/USGS-R/gsplot/labels{/name}","releases_url":"https://api.github.com/repos/USGS-R/gsplot/releases{/id}","deployments_url":"https://api.github.com/repos/USGS-R/gsplot/deployments","created_at":"2015-06-10T20:08:10Z","updated_at":"2016-01-13T22:58:56Z","pushed_at":"2016-04-10T13:43:35Z","git_url":"git://github.com/USGS-R/gsplot.git","ssh_url":"git@github.com:USGS-R/gsplot.git","clone_url":"https://github.com/USGS-R/gsplot.git","svn_url":"https://github.com/USGS-R/gsplot","homepage":"","size":2640,"stargazers_count":3,"watchers_count":3,"language":"R","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":43,"forks":8,"open_issues":43,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/USGS-R/gsplot/pulls/313"},"html":{"href":"https://github.com/USGS-R/gsplot/pull/313"},"issue":{"href":"https://api.github.com/repos/USGS-R/gsplot/issues/313"},"comments":{"href":"https://api.github.com/repos/USGS-R/gsplot/issues/313/comments"},"review_comments":{"href":"https://api.github.com/repos/USGS-R/gsplot/pulls/313/comments"},"review_comment":{"href":"https://api.github.com/repos/USGS-R/gsplot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/USGS-R/gsplot/pulls/313/commits"},"statuses":{"href":"https://api.github.com/repos/USGS-R/gsplot/statuses/6b351930de04ccbbced4be2c81ed9911d1520550"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":13,"additions":210,"deletions":112,"changed_files":9}}