{"action":"created","issue":{"url":"https://api.github.com/repos/mobxjs/mobx-react/issues/134","repository_url":"https://api.github.com/repos/mobxjs/mobx-react","labels_url":"https://api.github.com/repos/mobxjs/mobx-react/issues/134/labels{/name}","comments_url":"https://api.github.com/repos/mobxjs/mobx-react/issues/134/comments","events_url":"https://api.github.com/repos/mobxjs/mobx-react/issues/134/events","html_url":"https://github.com/mobxjs/mobx-react/pull/134","id":183109685,"number":134,"title":"Dispose reaction on error inside rendering","user":{"login":"andykog","id":6760207,"avatar_url":"https://avatars.githubusercontent.com/u/6760207?v=3","gravatar_id":"","url":"https://api.github.com/users/andykog","html_url":"https://github.com/andykog","followers_url":"https://api.github.com/users/andykog/followers","following_url":"https://api.github.com/users/andykog/following{/other_user}","gists_url":"https://api.github.com/users/andykog/gists{/gist_id}","starred_url":"https://api.github.com/users/andykog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andykog/subscriptions","organizations_url":"https://api.github.com/users/andykog/orgs","repos_url":"https://api.github.com/users/andykog/repos","events_url":"https://api.github.com/users/andykog/events{/privacy}","received_events_url":"https://api.github.com/users/andykog/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/mobxjs/mobx-react/labels/bug","name":"bug","color":"fc2929"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-10-14T17:44:14Z","updated_at":"2016-10-18T13:14:31Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mobxjs/mobx-react/pulls/134","html_url":"https://github.com/mobxjs/mobx-react/pull/134","diff_url":"https://github.com/mobxjs/mobx-react/pull/134.diff","patch_url":"https://github.com/mobxjs/mobx-react/pull/134.patch"},"body":"@mweststrate, sometimes in complex apps, when error happens inside rendering, we can't see original error, because of additional forceUpdate.\r\nI've spent an hour trying to isolate this user-case: https://jsfiddle.net/Sl1v3r/1adco8hx/\r\nMay be you have a better idea on how to fix this?"},"comment":{"url":"https://api.github.com/repos/mobxjs/mobx-react/issues/comments/254503627","html_url":"https://github.com/mobxjs/mobx-react/pull/134#issuecomment-254503627","issue_url":"https://api.github.com/repos/mobxjs/mobx-react/issues/134","id":254503627,"user":{"login":"andykog","id":6760207,"avatar_url":"https://avatars.githubusercontent.com/u/6760207?v=3","gravatar_id":"","url":"https://api.github.com/users/andykog","html_url":"https://github.com/andykog","followers_url":"https://api.github.com/users/andykog/followers","following_url":"https://api.github.com/users/andykog/following{/other_user}","gists_url":"https://api.github.com/users/andykog/gists{/gist_id}","starred_url":"https://api.github.com/users/andykog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andykog/subscriptions","organizations_url":"https://api.github.com/users/andykog/orgs","repos_url":"https://api.github.com/users/andykog/repos","events_url":"https://api.github.com/users/andykog/events{/privacy}","received_events_url":"https://api.github.com/users/andykog/received_events","type":"User","site_admin":false},"created_at":"2016-10-18T13:14:30Z","updated_at":"2016-10-18T13:14:30Z","body":"@mweststrate, I'm not completely sure, but I think, the problem is that when exception occurs inside render, react have no problem with handling it, but if there is synchronous `forceUpdate` after that, react throws it's own exception in some cases (Cannot read property 'getHostNode' of null). I can try to investigate, maybe that can should be fixed inside React."}}
{"actor":{"display_login":"andykog"}}