{"action":"created","issue":{"url":"https://api.github.com/repos/tbeu/Modelica/issues/292","repository_url":"https://api.github.com/repos/tbeu/Modelica","labels_url":"https://api.github.com/repos/tbeu/Modelica/issues/292/labels{/name}","comments_url":"https://api.github.com/repos/tbeu/Modelica/issues/292/comments","events_url":"https://api.github.com/repos/tbeu/Modelica/issues/292/events","html_url":"https://github.com/tbeu/Modelica/issues/292","id":196577654,"number":292,"title":"Remove empty \"Diagram(graphics)\" annotations","user":{"login":"modelica-trac-importer","id":22202507,"avatar_url":"https://avatars.githubusercontent.com/u/22202507?v=3","gravatar_id":"","url":"https://api.github.com/users/modelica-trac-importer","html_url":"https://github.com/modelica-trac-importer","followers_url":"https://api.github.com/users/modelica-trac-importer/followers","following_url":"https://api.github.com/users/modelica-trac-importer/following{/other_user}","gists_url":"https://api.github.com/users/modelica-trac-importer/gists{/gist_id}","starred_url":"https://api.github.com/users/modelica-trac-importer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/modelica-trac-importer/subscriptions","organizations_url":"https://api.github.com/users/modelica-trac-importer/orgs","repos_url":"https://api.github.com/users/modelica-trac-importer/repos","events_url":"https://api.github.com/users/modelica-trac-importer/events{/privacy}","received_events_url":"https://api.github.com/users/modelica-trac-importer/received_events","type":"User","site_admin":false},"labels":[{"id":503777658,"url":"https://api.github.com/repos/tbeu/Modelica/labels/bug","name":"bug","color":"ee0701","default":true}],"state":"open","locked":false,"assignee":{"login":"beutlich","id":14896695,"avatar_url":"https://avatars.githubusercontent.com/u/14896695?v=3","gravatar_id":"","url":"https://api.github.com/users/beutlich","html_url":"https://github.com/beutlich","followers_url":"https://api.github.com/users/beutlich/followers","following_url":"https://api.github.com/users/beutlich/following{/other_user}","gists_url":"https://api.github.com/users/beutlich/gists{/gist_id}","starred_url":"https://api.github.com/users/beutlich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beutlich/subscriptions","organizations_url":"https://api.github.com/users/beutlich/orgs","repos_url":"https://api.github.com/users/beutlich/repos","events_url":"https://api.github.com/users/beutlich/events{/privacy}","received_events_url":"https://api.github.com/users/beutlich/received_events","type":"User","site_admin":false},"assignees":[{"login":"beutlich","id":14896695,"avatar_url":"https://avatars.githubusercontent.com/u/14896695?v=3","gravatar_id":"","url":"https://api.github.com/users/beutlich","html_url":"https://github.com/beutlich","followers_url":"https://api.github.com/users/beutlich/followers","following_url":"https://api.github.com/users/beutlich/following{/other_user}","gists_url":"https://api.github.com/users/beutlich/gists{/gist_id}","starred_url":"https://api.github.com/users/beutlich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beutlich/subscriptions","organizations_url":"https://api.github.com/users/beutlich/orgs","repos_url":"https://api.github.com/users/beutlich/repos","events_url":"https://api.github.com/users/beutlich/events{/privacy}","received_events_url":"https://api.github.com/users/beutlich/received_events","type":"User","site_admin":false}],"milestone":null,"comments":17,"created_at":"2016-12-20T03:25:59Z","updated_at":"2016-12-20T03:32:11Z","closed_at":null,"body":"**Reported by die&#x74;marw on 17 Feb 2010 12:47 UTC**\nThe MSL currently contains empty \"Diagram(graphics)\" annotations. These have no function whatsoever and should be removed.\n\n----\n\nMigrated from https://trac.modelica.org/Modelica/ticket/292"},"comment":{"url":"https://api.github.com/repos/tbeu/Modelica/issues/comments/268145519","html_url":"https://github.com/tbeu/Modelica/issues/292#issuecomment-268145519","issue_url":"https://api.github.com/repos/tbeu/Modelica/issues/292","id":268145519,"user":{"login":"modelica-trac-importer","id":22202507,"avatar_url":"https://avatars.githubusercontent.com/u/22202507?v=3","gravatar_id":"","url":"https://api.github.com/users/modelica-trac-importer","html_url":"https://github.com/modelica-trac-importer","followers_url":"https://api.github.com/users/modelica-trac-importer/followers","following_url":"https://api.github.com/users/modelica-trac-importer/following{/other_user}","gists_url":"https://api.github.com/users/modelica-trac-importer/gists{/gist_id}","starred_url":"https://api.github.com/users/modelica-trac-importer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/modelica-trac-importer/subscriptions","organizations_url":"https://api.github.com/users/modelica-trac-importer/orgs","repos_url":"https://api.github.com/users/modelica-trac-importer/repos","events_url":"https://api.github.com/users/modelica-trac-importer/events{/privacy}","received_events_url":"https://api.github.com/users/modelica-trac-importer/received_events","type":"User","site_admin":false},"created_at":"2016-12-20T03:32:11Z","updated_at":"2016-12-20T03:32:11Z","body":"**Comment by hanso&#x6c;sso&#110; on 29 Jun 2011 15:21 UTC**\nFor the first item I meant that \n `annotation(NameOfSomeAnnotation)`\nis legal (since some time ago) - and I just wanted to ensure that no-one by accident removed those.\n\nAs for the contents of 17.5: We have had many issues with those sub-grammars in the specification since it is hard to describe some things with grammars (e.g. only one graphics-entry).\n\nE.g. that grammar also makes the following illegal:\n  `annotation(Diagram(graphics={Rectangle(extent={{-68,56},{-26,16}})},             coordinateSystem(extent={{-100,-100}, {100,100}}))); `\nsince it requires the optional coordinateSystem to preceed the graphics.\n\nThat looks like an unintentional consequence of trying to describe the annotation-structure using a grammar.\n\n\nYour question: \"As I understand this having just an empty graphics component is actually illegal right?\" does not have a clear answer as I see it and I believe the specification should be made clearer.\n\nOne could argue that \"Diagram(graphics)\" is a way of specifying an empty ordered sequence; alternatively a way of keeping the default graphics (which also happens to be empty) - similarly as a modifier."}}
{"actor":{"display_login":"modelica-trac-importer"}}