{"push_id":1427038553,"size":1,"distinct_size":1,"ref":"refs/heads/reduce-api-pressure","head":"cf815ea0c1f48a2f1ea690fa777b5a9e35687277","before":"62e47c399e49c872f9c3f8bfcd6afa733a1aa11d","commits":[{"sha":"cf815ea0c1f48a2f1ea690fa777b5a9e35687277","author":{"name":"joe miller","email":"5aa5f5804956b5873f38495ef9f4fbf17003acc2@joeym.net"},"message":"bug: initial IP assignment fails adding dns record to google cloud dns api\n\nUpon assignment of a public IP for the first time to a new service\nthere will be no previous public IP set on the service. In this case we\nwere trying to send a google cloud DNS update changeset that included\nboth an \"addition\" for the newly assigned public IP and a \"deletion\"\nthat includes a nil list of public IPs. This was causing google cloud\ndns api to fail the entire changeset with an error such as:\n\n```\n2016/11/29 01:04:17 Got Possible Service update prometheus-delete.development.gce.panth.io.\n2016/11/29 01:04:17 Error creating change: googleapi: Error 400: Invalid\nvalue for 'entity.change.deletions[0].rrdata': '<empty>', invalid\n```","distinct":true,"url":"https://api.github.com/repos/pantheon-systems/kube-gce-dns/commits/cf815ea0c1f48a2f1ea690fa777b5a9e35687277"}]}
{"actor":{"display_login":"joemiller"}}