{"action":"closed","number":1385,"pull_request":{"url":"https://api.github.com/repos/KeepSafe/aiohttp/pulls/1385","id":93081681,"html_url":"https://github.com/KeepSafe/aiohttp/pull/1385","diff_url":"https://github.com/KeepSafe/aiohttp/pull/1385.diff","patch_url":"https://github.com/KeepSafe/aiohttp/pull/1385.patch","issue_url":"https://api.github.com/repos/KeepSafe/aiohttp/issues/1385","number":1385,"state":"closed","locked":false,"title":"ClientSession.request() shouldn't duplicate the param defaults from _request()","user":{"login":"mikenerone","id":795059,"avatar_url":"https://avatars.githubusercontent.com/u/795059?v=3","gravatar_id":"","url":"https://api.github.com/users/mikenerone","html_url":"https://github.com/mikenerone","followers_url":"https://api.github.com/users/mikenerone/followers","following_url":"https://api.github.com/users/mikenerone/following{/other_user}","gists_url":"https://api.github.com/users/mikenerone/gists{/gist_id}","starred_url":"https://api.github.com/users/mikenerone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikenerone/subscriptions","organizations_url":"https://api.github.com/users/mikenerone/orgs","repos_url":"https://api.github.com/users/mikenerone/repos","events_url":"https://api.github.com/users/mikenerone/events{/privacy}","received_events_url":"https://api.github.com/users/mikenerone/received_events","type":"User","site_admin":false},"body":"Most of the request methods on `ClientSession` (`get()`, `post()`, etc), have pretty generic \"**kwargs\" signatures and wrap `self._request()`. `_request()` itself contains sensible defaults, and provides one convenient method to override in a subclass if one would like to change those defaults.\r\n\r\n`ClientSession.request()` (no underscore), is an exception, though, and duplicates all of those defaults. As a result, if one wants to make their requests via `request()` (I have my reasons) overriding `_request()` alone is no longer sufficient - `request()` must itself be overridden, as well.\r\n\r\nWhile this is only a minor inconvenience, `request()` should, in my opinion, behave consistently with the other `_request()` wrappers, and have a generic \"**kwargs\" signature.","created_at":"2016-11-10T03:31:45Z","updated_at":"2016-11-13T19:29:52Z","closed_at":"2016-11-13T19:29:52Z","merged_at":"2016-11-13T19:29:52Z","merge_commit_sha":"a7607f666e49c76a7d96acf2ce4558402d0438d5","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/KeepSafe/aiohttp/pulls/1385/commits","review_comments_url":"https://api.github.com/repos/KeepSafe/aiohttp/pulls/1385/comments","review_comment_url":"https://api.github.com/repos/KeepSafe/aiohttp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/KeepSafe/aiohttp/issues/1385/comments","statuses_url":"https://api.github.com/repos/KeepSafe/aiohttp/statuses/de8584407529e3ed6fe1c057230a18d1f663bba5","head":{"label":"mikenerone:remove_duplicate_request_defaults","ref":"remove_duplicate_request_defaults","sha":"de8584407529e3ed6fe1c057230a18d1f663bba5","user":{"login":"mikenerone","id":795059,"avatar_url":"https://avatars.githubusercontent.com/u/795059?v=3","gravatar_id":"","url":"https://api.github.com/users/mikenerone","html_url":"https://github.com/mikenerone","followers_url":"https://api.github.com/users/mikenerone/followers","following_url":"https://api.github.com/users/mikenerone/following{/other_user}","gists_url":"https://api.github.com/users/mikenerone/gists{/gist_id}","starred_url":"https://api.github.com/users/mikenerone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikenerone/subscriptions","organizations_url":"https://api.github.com/users/mikenerone/orgs","repos_url":"https://api.github.com/users/mikenerone/repos","events_url":"https://api.github.com/users/mikenerone/events{/privacy}","received_events_url":"https://api.github.com/users/mikenerone/received_events","type":"User","site_admin":false},"repo":{"id":73341327,"name":"aiohttp","full_name":"mikenerone/aiohttp","owner":{"login":"mikenerone","id":795059,"avatar_url":"https://avatars.githubusercontent.com/u/795059?v=3","gravatar_id":"","url":"https://api.github.com/users/mikenerone","html_url":"https://github.com/mikenerone","followers_url":"https://api.github.com/users/mikenerone/followers","following_url":"https://api.github.com/users/mikenerone/following{/other_user}","gists_url":"https://api.github.com/users/mikenerone/gists{/gist_id}","starred_url":"https://api.github.com/users/mikenerone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikenerone/subscriptions","organizations_url":"https://api.github.com/users/mikenerone/orgs","repos_url":"https://api.github.com/users/mikenerone/repos","events_url":"https://api.github.com/users/mikenerone/events{/privacy}","received_events_url":"https://api.github.com/users/mikenerone/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mikenerone/aiohttp","description":"http client/server for asyncio (PEP-3156)","fork":true,"url":"https://api.github.com/repos/mikenerone/aiohttp","forks_url":"https://api.github.com/repos/mikenerone/aiohttp/forks","keys_url":"https://api.github.com/repos/mikenerone/aiohttp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mikenerone/aiohttp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mikenerone/aiohttp/teams","hooks_url":"https://api.github.com/repos/mikenerone/aiohttp/hooks","issue_events_url":"https://api.github.com/repos/mikenerone/aiohttp/issues/events{/number}","events_url":"https://api.github.com/repos/mikenerone/aiohttp/events","assignees_url":"https://api.github.com/repos/mikenerone/aiohttp/assignees{/user}","branches_url":"https://api.github.com/repos/mikenerone/aiohttp/branches{/branch}","tags_url":"https://api.github.com/repos/mikenerone/aiohttp/tags","blobs_url":"https://api.github.com/repos/mikenerone/aiohttp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mikenerone/aiohttp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mikenerone/aiohttp/git/refs{/sha}","trees_url":"https://api.github.com/repos/mikenerone/aiohttp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mikenerone/aiohttp/statuses/{sha}","languages_url":"https://api.github.com/repos/mikenerone/aiohttp/languages","stargazers_url":"https://api.github.com/repos/mikenerone/aiohttp/stargazers","contributors_url":"https://api.github.com/repos/mikenerone/aiohttp/contributors","subscribers_url":"https://api.github.com/repos/mikenerone/aiohttp/subscribers","subscription_url":"https://api.github.com/repos/mikenerone/aiohttp/subscription","commits_url":"https://api.github.com/repos/mikenerone/aiohttp/commits{/sha}","git_commits_url":"https://api.github.com/repos/mikenerone/aiohttp/git/commits{/sha}","comments_url":"https://api.github.com/repos/mikenerone/aiohttp/comments{/number}","issue_comment_url":"https://api.github.com/repos/mikenerone/aiohttp/issues/comments{/number}","contents_url":"https://api.github.com/repos/mikenerone/aiohttp/contents/{+path}","compare_url":"https://api.github.com/repos/mikenerone/aiohttp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mikenerone/aiohttp/merges","archive_url":"https://api.github.com/repos/mikenerone/aiohttp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mikenerone/aiohttp/downloads","issues_url":"https://api.github.com/repos/mikenerone/aiohttp/issues{/number}","pulls_url":"https://api.github.com/repos/mikenerone/aiohttp/pulls{/number}","milestones_url":"https://api.github.com/repos/mikenerone/aiohttp/milestones{/number}","notifications_url":"https://api.github.com/repos/mikenerone/aiohttp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mikenerone/aiohttp/labels{/name}","releases_url":"https://api.github.com/repos/mikenerone/aiohttp/releases{/id}","deployments_url":"https://api.github.com/repos/mikenerone/aiohttp/deployments","created_at":"2016-11-10T02:49:36Z","updated_at":"2016-11-10T02:49:38Z","pushed_at":"2016-11-10T03:24:23Z","git_url":"git://github.com/mikenerone/aiohttp.git","ssh_url":"git@github.com:mikenerone/aiohttp.git","clone_url":"https://github.com/mikenerone/aiohttp.git","svn_url":"https://github.com/mikenerone/aiohttp","homepage":"http://aiohttp.readthedocs.io","size":7732,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"KeepSafe:master","ref":"master","sha":"d53c3c1101be35770317af9a50d07fc5f4d3b4e3","user":{"login":"KeepSafe","id":1377248,"avatar_url":"https://avatars.githubusercontent.com/u/1377248?v=3","gravatar_id":"","url":"https://api.github.com/users/KeepSafe","html_url":"https://github.com/KeepSafe","followers_url":"https://api.github.com/users/KeepSafe/followers","following_url":"https://api.github.com/users/KeepSafe/following{/other_user}","gists_url":"https://api.github.com/users/KeepSafe/gists{/gist_id}","starred_url":"https://api.github.com/users/KeepSafe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KeepSafe/subscriptions","organizations_url":"https://api.github.com/users/KeepSafe/orgs","repos_url":"https://api.github.com/users/KeepSafe/repos","events_url":"https://api.github.com/users/KeepSafe/events{/privacy}","received_events_url":"https://api.github.com/users/KeepSafe/received_events","type":"Organization","site_admin":false},"repo":{"id":13258039,"name":"aiohttp","full_name":"KeepSafe/aiohttp","owner":{"login":"KeepSafe","id":1377248,"avatar_url":"https://avatars.githubusercontent.com/u/1377248?v=3","gravatar_id":"","url":"https://api.github.com/users/KeepSafe","html_url":"https://github.com/KeepSafe","followers_url":"https://api.github.com/users/KeepSafe/followers","following_url":"https://api.github.com/users/KeepSafe/following{/other_user}","gists_url":"https://api.github.com/users/KeepSafe/gists{/gist_id}","starred_url":"https://api.github.com/users/KeepSafe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KeepSafe/subscriptions","organizations_url":"https://api.github.com/users/KeepSafe/orgs","repos_url":"https://api.github.com/users/KeepSafe/repos","events_url":"https://api.github.com/users/KeepSafe/events{/privacy}","received_events_url":"https://api.github.com/users/KeepSafe/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/KeepSafe/aiohttp","description":"http client/server for asyncio (PEP-3156)","fork":false,"url":"https://api.github.com/repos/KeepSafe/aiohttp","forks_url":"https://api.github.com/repos/KeepSafe/aiohttp/forks","keys_url":"https://api.github.com/repos/KeepSafe/aiohttp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KeepSafe/aiohttp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KeepSafe/aiohttp/teams","hooks_url":"https://api.github.com/repos/KeepSafe/aiohttp/hooks","issue_events_url":"https://api.github.com/repos/KeepSafe/aiohttp/issues/events{/number}","events_url":"https://api.github.com/repos/KeepSafe/aiohttp/events","assignees_url":"https://api.github.com/repos/KeepSafe/aiohttp/assignees{/user}","branches_url":"https://api.github.com/repos/KeepSafe/aiohttp/branches{/branch}","tags_url":"https://api.github.com/repos/KeepSafe/aiohttp/tags","blobs_url":"https://api.github.com/repos/KeepSafe/aiohttp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KeepSafe/aiohttp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KeepSafe/aiohttp/git/refs{/sha}","trees_url":"https://api.github.com/repos/KeepSafe/aiohttp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KeepSafe/aiohttp/statuses/{sha}","languages_url":"https://api.github.com/repos/KeepSafe/aiohttp/languages","stargazers_url":"https://api.github.com/repos/KeepSafe/aiohttp/stargazers","contributors_url":"https://api.github.com/repos/KeepSafe/aiohttp/contributors","subscribers_url":"https://api.github.com/repos/KeepSafe/aiohttp/subscribers","subscription_url":"https://api.github.com/repos/KeepSafe/aiohttp/subscription","commits_url":"https://api.github.com/repos/KeepSafe/aiohttp/commits{/sha}","git_commits_url":"https://api.github.com/repos/KeepSafe/aiohttp/git/commits{/sha}","comments_url":"https://api.github.com/repos/KeepSafe/aiohttp/comments{/number}","issue_comment_url":"https://api.github.com/repos/KeepSafe/aiohttp/issues/comments{/number}","contents_url":"https://api.github.com/repos/KeepSafe/aiohttp/contents/{+path}","compare_url":"https://api.github.com/repos/KeepSafe/aiohttp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KeepSafe/aiohttp/merges","archive_url":"https://api.github.com/repos/KeepSafe/aiohttp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KeepSafe/aiohttp/downloads","issues_url":"https://api.github.com/repos/KeepSafe/aiohttp/issues{/number}","pulls_url":"https://api.github.com/repos/KeepSafe/aiohttp/pulls{/number}","milestones_url":"https://api.github.com/repos/KeepSafe/aiohttp/milestones{/number}","notifications_url":"https://api.github.com/repos/KeepSafe/aiohttp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KeepSafe/aiohttp/labels{/name}","releases_url":"https://api.github.com/repos/KeepSafe/aiohttp/releases{/id}","deployments_url":"https://api.github.com/repos/KeepSafe/aiohttp/deployments","created_at":"2013-10-01T23:04:01Z","updated_at":"2016-11-13T15:22:34Z","pushed_at":"2016-11-13T19:29:52Z","git_url":"git://github.com/KeepSafe/aiohttp.git","ssh_url":"git@github.com:KeepSafe/aiohttp.git","clone_url":"https://github.com/KeepSafe/aiohttp.git","svn_url":"https://github.com/KeepSafe/aiohttp","homepage":"http://aiohttp.readthedocs.io","size":8614,"stargazers_count":2479,"watchers_count":2479,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":442,"mirror_url":null,"open_issues_count":102,"forks":442,"open_issues":102,"watchers":2479,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/KeepSafe/aiohttp/pulls/1385"},"html":{"href":"https://github.com/KeepSafe/aiohttp/pull/1385"},"issue":{"href":"https://api.github.com/repos/KeepSafe/aiohttp/issues/1385"},"comments":{"href":"https://api.github.com/repos/KeepSafe/aiohttp/issues/1385/comments"},"review_comments":{"href":"https://api.github.com/repos/KeepSafe/aiohttp/pulls/1385/comments"},"review_comment":{"href":"https://api.github.com/repos/KeepSafe/aiohttp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/KeepSafe/aiohttp/pulls/1385/commits"},"statuses":{"href":"https://api.github.com/repos/KeepSafe/aiohttp/statuses/de8584407529e3ed6fe1c057230a18d1f663bba5"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"asvetlov","id":356399,"avatar_url":"https://avatars.githubusercontent.com/u/356399?v=3","gravatar_id":"","url":"https://api.github.com/users/asvetlov","html_url":"https://github.com/asvetlov","followers_url":"https://api.github.com/users/asvetlov/followers","following_url":"https://api.github.com/users/asvetlov/following{/other_user}","gists_url":"https://api.github.com/users/asvetlov/gists{/gist_id}","starred_url":"https://api.github.com/users/asvetlov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asvetlov/subscriptions","organizations_url":"https://api.github.com/users/asvetlov/orgs","repos_url":"https://api.github.com/users/asvetlov/repos","events_url":"https://api.github.com/users/asvetlov/events{/privacy}","received_events_url":"https://api.github.com/users/asvetlov/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"commits":1,"additions":2,"deletions":38,"changed_files":1}}
{"actor":{"display_login":"asvetlov"}}