{"action":"closed","number":602,"pull_request":{"url":"https://api.github.com/repos/uncrustify/uncrustify/pulls/602","id":79579257,"html_url":"https://github.com/uncrustify/uncrustify/pull/602","diff_url":"https://github.com/uncrustify/uncrustify/pull/602.diff","patch_url":"https://github.com/uncrustify/uncrustify/pull/602.patch","issue_url":"https://api.github.com/repos/uncrustify/uncrustify/issues/602","number":602,"state":"closed","locked":false,"title":"Failing test cases for calling convention not fixed in bug #633","user":{"login":"scottbilas","id":964720,"avatar_url":"https://avatars.githubusercontent.com/u/964720?v=3","gravatar_id":"","url":"https://api.github.com/users/scottbilas","html_url":"https://github.com/scottbilas","followers_url":"https://api.github.com/users/scottbilas/followers","following_url":"https://api.github.com/users/scottbilas/following{/other_user}","gists_url":"https://api.github.com/users/scottbilas/gists{/gist_id}","starred_url":"https://api.github.com/users/scottbilas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scottbilas/subscriptions","organizations_url":"https://api.github.com/users/scottbilas/orgs","repos_url":"https://api.github.com/users/scottbilas/repos","events_url":"https://api.github.com/users/scottbilas/events{/privacy}","received_events_url":"https://api.github.com/users/scottbilas/received_events","type":"User","site_admin":false},"body":"In January, fixes were made for this bug: https://sourceforge.net/p/uncrustify/bugs/633/\r\n\r\nPreviously, we had been using a workaround of marking \"set COMMENT __stdcall\" in our cfg files, so I tried removing them to validate the fix for 633. Definitely not fixed. You can see what's going on with the -p option to show the tokens. The presence of __stdcall will switch TYPE to WORD, FUNC_PROTO to FUNC_CALL, and PTR_TYPE to ARITH in many cases. We'll be continuing with our old workaround.\r\n\r\nThis PR adds more tests that demonstrate the problem more completely. Also removes a redundant test. \r\n\r\nNote that merging this PR will break tests, so it's meant only as a demonstration. (Though the test files updated here should be included in a real fix.)\r\n","created_at":"2016-08-01T14:40:11Z","updated_at":"2016-10-10T17:10:26Z","closed_at":"2016-10-10T17:10:26Z","merged_at":null,"merge_commit_sha":"e7d9597f028def0edc8a50bbd6884d96bb7667c9","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/uncrustify/uncrustify/pulls/602/commits","review_comments_url":"https://api.github.com/repos/uncrustify/uncrustify/pulls/602/comments","review_comment_url":"https://api.github.com/repos/uncrustify/uncrustify/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uncrustify/uncrustify/issues/602/comments","statuses_url":"https://api.github.com/repos/uncrustify/uncrustify/statuses/2809528b8c4ed7f7ddc7f3de04380665730ce8e3","head":{"label":"Unity-Technologies:bugs/calling-convention","ref":"bugs/calling-convention","sha":"2809528b8c4ed7f7ddc7f3de04380665730ce8e3","user":{"login":"Unity-Technologies","id":426196,"avatar_url":"https://avatars.githubusercontent.com/u/426196?v=3","gravatar_id":"","url":"https://api.github.com/users/Unity-Technologies","html_url":"https://github.com/Unity-Technologies","followers_url":"https://api.github.com/users/Unity-Technologies/followers","following_url":"https://api.github.com/users/Unity-Technologies/following{/other_user}","gists_url":"https://api.github.com/users/Unity-Technologies/gists{/gist_id}","starred_url":"https://api.github.com/users/Unity-Technologies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Unity-Technologies/subscriptions","organizations_url":"https://api.github.com/users/Unity-Technologies/orgs","repos_url":"https://api.github.com/users/Unity-Technologies/repos","events_url":"https://api.github.com/users/Unity-Technologies/events{/privacy}","received_events_url":"https://api.github.com/users/Unity-Technologies/received_events","type":"Organization","site_admin":false},"repo":{"id":24677197,"name":"uncrustify","full_name":"Unity-Technologies/uncrustify","owner":{"login":"Unity-Technologies","id":426196,"avatar_url":"https://avatars.githubusercontent.com/u/426196?v=3","gravatar_id":"","url":"https://api.github.com/users/Unity-Technologies","html_url":"https://github.com/Unity-Technologies","followers_url":"https://api.github.com/users/Unity-Technologies/followers","following_url":"https://api.github.com/users/Unity-Technologies/following{/other_user}","gists_url":"https://api.github.com/users/Unity-Technologies/gists{/gist_id}","starred_url":"https://api.github.com/users/Unity-Technologies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Unity-Technologies/subscriptions","organizations_url":"https://api.github.com/users/Unity-Technologies/orgs","repos_url":"https://api.github.com/users/Unity-Technologies/repos","events_url":"https://api.github.com/users/Unity-Technologies/events{/privacy}","received_events_url":"https://api.github.com/users/Unity-Technologies/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Unity-Technologies/uncrustify","description":"Code beautifier","fork":true,"url":"https://api.github.com/repos/Unity-Technologies/uncrustify","forks_url":"https://api.github.com/repos/Unity-Technologies/uncrustify/forks","keys_url":"https://api.github.com/repos/Unity-Technologies/uncrustify/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Unity-Technologies/uncrustify/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Unity-Technologies/uncrustify/teams","hooks_url":"https://api.github.com/repos/Unity-Technologies/uncrustify/hooks","issue_events_url":"https://api.github.com/repos/Unity-Technologies/uncrustify/issues/events{/number}","events_url":"https://api.github.com/repos/Unity-Technologies/uncrustify/events","assignees_url":"https://api.github.com/repos/Unity-Technologies/uncrustify/assignees{/user}","branches_url":"https://api.github.com/repos/Unity-Technologies/uncrustify/branches{/branch}","tags_url":"https://api.github.com/repos/Unity-Technologies/uncrustify/tags","blobs_url":"https://api.github.com/repos/Unity-Technologies/uncrustify/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Unity-Technologies/uncrustify/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Unity-Technologies/uncrustify/git/refs{/sha}","trees_url":"https://api.github.com/repos/Unity-Technologies/uncrustify/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Unity-Technologies/uncrustify/statuses/{sha}","languages_url":"https://api.github.com/repos/Unity-Technologies/uncrustify/languages","stargazers_url":"https://api.github.com/repos/Unity-Technologies/uncrustify/stargazers","contributors_url":"https://api.github.com/repos/Unity-Technologies/uncrustify/contributors","subscribers_url":"https://api.github.com/repos/Unity-Technologies/uncrustify/subscribers","subscription_url":"https://api.github.com/repos/Unity-Technologies/uncrustify/subscription","commits_url":"https://api.github.com/repos/Unity-Technologies/uncrustify/commits{/sha}","git_commits_url":"https://api.github.com/repos/Unity-Technologies/uncrustify/git/commits{/sha}","comments_url":"https://api.github.com/repos/Unity-Technologies/uncrustify/comments{/number}","issue_comment_url":"https://api.github.com/repos/Unity-Technologies/uncrustify/issues/comments{/number}","contents_url":"https://api.github.com/repos/Unity-Technologies/uncrustify/contents/{+path}","compare_url":"https://api.github.com/repos/Unity-Technologies/uncrustify/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Unity-Technologies/uncrustify/merges","archive_url":"https://api.github.com/repos/Unity-Technologies/uncrustify/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Unity-Technologies/uncrustify/downloads","issues_url":"https://api.github.com/repos/Unity-Technologies/uncrustify/issues{/number}","pulls_url":"https://api.github.com/repos/Unity-Technologies/uncrustify/pulls{/number}","milestones_url":"https://api.github.com/repos/Unity-Technologies/uncrustify/milestones{/number}","notifications_url":"https://api.github.com/repos/Unity-Technologies/uncrustify/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Unity-Technologies/uncrustify/labels{/name}","releases_url":"https://api.github.com/repos/Unity-Technologies/uncrustify/releases{/id}","deployments_url":"https://api.github.com/repos/Unity-Technologies/uncrustify/deployments","created_at":"2014-10-01T12:15:59Z","updated_at":"2016-10-07T06:51:27Z","pushed_at":"2016-09-28T14:29:57Z","git_url":"git://github.com/Unity-Technologies/uncrustify.git","ssh_url":"git@github.com:Unity-Technologies/uncrustify.git","clone_url":"https://github.com/Unity-Technologies/uncrustify.git","svn_url":"https://github.com/Unity-Technologies/uncrustify","homepage":"http://uncrustify.sourceforge.net/","size":5645,"stargazers_count":9,"watchers_count":9,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":1,"forks":4,"open_issues":1,"watchers":9,"default_branch":"master"}},"base":{"label":"uncrustify:master","ref":"master","sha":"206d3730fda279988798eff49acfa3db359f8caf","user":{"login":"uncrustify","id":17281983,"avatar_url":"https://avatars.githubusercontent.com/u/17281983?v=3","gravatar_id":"","url":"https://api.github.com/users/uncrustify","html_url":"https://github.com/uncrustify","followers_url":"https://api.github.com/users/uncrustify/followers","following_url":"https://api.github.com/users/uncrustify/following{/other_user}","gists_url":"https://api.github.com/users/uncrustify/gists{/gist_id}","starred_url":"https://api.github.com/users/uncrustify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uncrustify/subscriptions","organizations_url":"https://api.github.com/users/uncrustify/orgs","repos_url":"https://api.github.com/users/uncrustify/repos","events_url":"https://api.github.com/users/uncrustify/events{/privacy}","received_events_url":"https://api.github.com/users/uncrustify/received_events","type":"Organization","site_admin":false},"repo":{"id":340637,"name":"uncrustify","full_name":"uncrustify/uncrustify","owner":{"login":"uncrustify","id":17281983,"avatar_url":"https://avatars.githubusercontent.com/u/17281983?v=3","gravatar_id":"","url":"https://api.github.com/users/uncrustify","html_url":"https://github.com/uncrustify","followers_url":"https://api.github.com/users/uncrustify/followers","following_url":"https://api.github.com/users/uncrustify/following{/other_user}","gists_url":"https://api.github.com/users/uncrustify/gists{/gist_id}","starred_url":"https://api.github.com/users/uncrustify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uncrustify/subscriptions","organizations_url":"https://api.github.com/users/uncrustify/orgs","repos_url":"https://api.github.com/users/uncrustify/repos","events_url":"https://api.github.com/users/uncrustify/events{/privacy}","received_events_url":"https://api.github.com/users/uncrustify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uncrustify/uncrustify","description":"Code beautifier","fork":false,"url":"https://api.github.com/repos/uncrustify/uncrustify","forks_url":"https://api.github.com/repos/uncrustify/uncrustify/forks","keys_url":"https://api.github.com/repos/uncrustify/uncrustify/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uncrustify/uncrustify/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uncrustify/uncrustify/teams","hooks_url":"https://api.github.com/repos/uncrustify/uncrustify/hooks","issue_events_url":"https://api.github.com/repos/uncrustify/uncrustify/issues/events{/number}","events_url":"https://api.github.com/repos/uncrustify/uncrustify/events","assignees_url":"https://api.github.com/repos/uncrustify/uncrustify/assignees{/user}","branches_url":"https://api.github.com/repos/uncrustify/uncrustify/branches{/branch}","tags_url":"https://api.github.com/repos/uncrustify/uncrustify/tags","blobs_url":"https://api.github.com/repos/uncrustify/uncrustify/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uncrustify/uncrustify/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uncrustify/uncrustify/git/refs{/sha}","trees_url":"https://api.github.com/repos/uncrustify/uncrustify/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uncrustify/uncrustify/statuses/{sha}","languages_url":"https://api.github.com/repos/uncrustify/uncrustify/languages","stargazers_url":"https://api.github.com/repos/uncrustify/uncrustify/stargazers","contributors_url":"https://api.github.com/repos/uncrustify/uncrustify/contributors","subscribers_url":"https://api.github.com/repos/uncrustify/uncrustify/subscribers","subscription_url":"https://api.github.com/repos/uncrustify/uncrustify/subscription","commits_url":"https://api.github.com/repos/uncrustify/uncrustify/commits{/sha}","git_commits_url":"https://api.github.com/repos/uncrustify/uncrustify/git/commits{/sha}","comments_url":"https://api.github.com/repos/uncrustify/uncrustify/comments{/number}","issue_comment_url":"https://api.github.com/repos/uncrustify/uncrustify/issues/comments{/number}","contents_url":"https://api.github.com/repos/uncrustify/uncrustify/contents/{+path}","compare_url":"https://api.github.com/repos/uncrustify/uncrustify/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uncrustify/uncrustify/merges","archive_url":"https://api.github.com/repos/uncrustify/uncrustify/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uncrustify/uncrustify/downloads","issues_url":"https://api.github.com/repos/uncrustify/uncrustify/issues{/number}","pulls_url":"https://api.github.com/repos/uncrustify/uncrustify/pulls{/number}","milestones_url":"https://api.github.com/repos/uncrustify/uncrustify/milestones{/number}","notifications_url":"https://api.github.com/repos/uncrustify/uncrustify/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uncrustify/uncrustify/labels{/name}","releases_url":"https://api.github.com/repos/uncrustify/uncrustify/releases{/id}","deployments_url":"https://api.github.com/repos/uncrustify/uncrustify/deployments","created_at":"2009-10-17T18:39:53Z","updated_at":"2016-10-08T16:28:13Z","pushed_at":"2016-10-10T15:33:33Z","git_url":"git://github.com/uncrustify/uncrustify.git","ssh_url":"git@github.com:uncrustify/uncrustify.git","clone_url":"https://github.com/uncrustify/uncrustify.git","svn_url":"https://github.com/uncrustify/uncrustify","homepage":"http://uncrustify.sourceforge.net/","size":7733,"stargazers_count":1270,"watchers_count":1270,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":248,"mirror_url":null,"open_issues_count":187,"forks":248,"open_issues":187,"watchers":1270,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/uncrustify/uncrustify/pulls/602"},"html":{"href":"https://github.com/uncrustify/uncrustify/pull/602"},"issue":{"href":"https://api.github.com/repos/uncrustify/uncrustify/issues/602"},"comments":{"href":"https://api.github.com/repos/uncrustify/uncrustify/issues/602/comments"},"review_comments":{"href":"https://api.github.com/repos/uncrustify/uncrustify/pulls/602/comments"},"review_comment":{"href":"https://api.github.com/repos/uncrustify/uncrustify/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uncrustify/uncrustify/pulls/602/commits"},"statuses":{"href":"https://api.github.com/repos/uncrustify/uncrustify/statuses/2809528b8c4ed7f7ddc7f3de04380665730ce8e3"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":5,"review_comments":0,"commits":2,"additions":63,"deletions":8,"changed_files":7}}
{"actor":{"display_login":"gmaurel"}}