{"action":"created","issue":{"url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/4694","repository_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium","labels_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/4694/labels{/name}","comments_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/4694/comments","events_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/4694/events","html_url":"https://github.com/AnalyticalGraphicsInc/cesium/issues/4694","id":192476902,"number":4694,"title":"3D Tiles - ternary functions","user":{"login":"lilleyse","id":915398,"avatar_url":"https://avatars.githubusercontent.com/u/915398?v=3","gravatar_id":"","url":"https://api.github.com/users/lilleyse","html_url":"https://github.com/lilleyse","followers_url":"https://api.github.com/users/lilleyse/followers","following_url":"https://api.github.com/users/lilleyse/following{/other_user}","gists_url":"https://api.github.com/users/lilleyse/gists{/gist_id}","starred_url":"https://api.github.com/users/lilleyse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lilleyse/subscriptions","organizations_url":"https://api.github.com/users/lilleyse/orgs","repos_url":"https://api.github.com/users/lilleyse/repos","events_url":"https://api.github.com/users/lilleyse/events{/privacy}","received_events_url":"https://api.github.com/users/lilleyse/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-11-30T05:08:44Z","updated_at":"2016-12-01T20:28:29Z","closed_at":null,"body":"@Dylan-Brown \r\n\r\nBefore getting into vector math, there are two more functions to handle. You'll need to add `TERNARY` to `ExpressionNodeType.js`. Handling three operators will be similar to here: https://github.com/AnalyticalGraphicsInc/cesium/pull/4688 except you'll use `left`, `right`, and `test`. The `x` values below can be passed as the `test` argument for `new Node`.\r\n\r\n clamp(x, minVal, maxVal) - use `CesiumMath.clamp`\r\n mix(minVal, maxVal, x) - use `CesiumMath.lerp`\r\n\r\nEven though this is just two functions, use the data-driven approach like before so it is easy to add others.\r\n"},"comment":{"url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/comments/264285432","html_url":"https://github.com/AnalyticalGraphicsInc/cesium/issues/4694#issuecomment-264285432","issue_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/4694","id":264285432,"user":{"login":"Dylan-Brown","id":10562115,"avatar_url":"https://avatars.githubusercontent.com/u/10562115?v=3","gravatar_id":"","url":"https://api.github.com/users/Dylan-Brown","html_url":"https://github.com/Dylan-Brown","followers_url":"https://api.github.com/users/Dylan-Brown/followers","following_url":"https://api.github.com/users/Dylan-Brown/following{/other_user}","gists_url":"https://api.github.com/users/Dylan-Brown/gists{/gist_id}","starred_url":"https://api.github.com/users/Dylan-Brown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dylan-Brown/subscriptions","organizations_url":"https://api.github.com/users/Dylan-Brown/orgs","repos_url":"https://api.github.com/users/Dylan-Brown/repos","events_url":"https://api.github.com/users/Dylan-Brown/events{/privacy}","received_events_url":"https://api.github.com/users/Dylan-Brown/received_events","type":"User","site_admin":false},"created_at":"2016-12-01T20:28:29Z","updated_at":"2016-12-01T20:28:29Z","body":"Sounds good! I'll get working on it. \r\nAlso, I noticed in Math.js, where CesiumMath is defined, the grammar in the comment above the definition of clamp is wrong. It says \"Constraint a value\" where it should be \"Constraints a value.\" Should I fix this in my PR, or should I do it separately in a PR to master, or what?"}}
{"actor":{"display_login":"Dylan-Brown"}}