{"action":"opened","number":1427,"pull_request":{"url":"https://api.github.com/repos/mysociety/fixmystreet/pulls/1427","id":73893194,"html_url":"https://github.com/mysociety/fixmystreet/pull/1427","diff_url":"https://github.com/mysociety/fixmystreet/pull/1427.diff","patch_url":"https://github.com/mysociety/fixmystreet/pull/1427.patch","issue_url":"https://api.github.com/repos/mysociety/fixmystreet/issues/1427","number":1427,"state":"open","locked":false,"title":"[UK Councils] Send correct confirm emails for updates","user":{"login":"davea","id":4776,"avatar_url":"https://avatars.githubusercontent.com/u/4776?v=3","gravatar_id":"","url":"https://api.github.com/users/davea","html_url":"https://github.com/davea","followers_url":"https://api.github.com/users/davea/followers","following_url":"https://api.github.com/users/davea/following{/other_user}","gists_url":"https://api.github.com/users/davea/gists{/gist_id}","starred_url":"https://api.github.com/users/davea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davea/subscriptions","organizations_url":"https://api.github.com/users/davea/orgs","repos_url":"https://api.github.com/users/davea/repos","events_url":"https://api.github.com/users/davea/events{/privacy}","received_events_url":"https://api.github.com/users/davea/received_events","type":"User","site_admin":false},"body":"Some UK councils with Open311 integrations (e.g. Bromley) have a custom wording\r\nin the confirmation email sent when updates are left on reports, to make the\r\nuser aware that the update is sent to the council in question.\r\n\r\nBromley noticed that some emails were being sent without this wording, leading\r\nat least one user to contact the council directly about the report.\r\n\r\nIt turns out that although the email template contains an IF clause to use the\r\nappropriate wording for Bromley (and Stevenage) reports, the incorrect template\r\nfile was being used when updates were made via the Bromley cobrand.\r\n\r\nThis commit solves the problem by introducing a new\r\n`Cobrand::Default::path_to_email_templates` method, which is overridden by\r\n`Cobrand::UKCouncils` to include the `templates/email/fixmystreet` path. Paths\r\nreturned by this method are used as the `additional_template_paths` param when\r\ntemplating emails. A regression test is included.","created_at":"2016-06-15T11:13:52Z","updated_at":"2016-06-15T11:13:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mysociety/fixmystreet/pulls/1427/commits","review_comments_url":"https://api.github.com/repos/mysociety/fixmystreet/pulls/1427/comments","review_comment_url":"https://api.github.com/repos/mysociety/fixmystreet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mysociety/fixmystreet/issues/1427/comments","statuses_url":"https://api.github.com/repos/mysociety/fixmystreet/statuses/e49fe2fb72eb5187c073045b7449caf827f71ec4","head":{"label":"mysociety:fix-bromley-update-emails","ref":"fix-bromley-update-emails","sha":"e49fe2fb72eb5187c073045b7449caf827f71ec4","user":{"login":"mysociety","id":141338,"avatar_url":"https://avatars.githubusercontent.com/u/141338?v=3","gravatar_id":"","url":"https://api.github.com/users/mysociety","html_url":"https://github.com/mysociety","followers_url":"https://api.github.com/users/mysociety/followers","following_url":"https://api.github.com/users/mysociety/following{/other_user}","gists_url":"https://api.github.com/users/mysociety/gists{/gist_id}","starred_url":"https://api.github.com/users/mysociety/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mysociety/subscriptions","organizations_url":"https://api.github.com/users/mysociety/orgs","repos_url":"https://api.github.com/users/mysociety/repos","events_url":"https://api.github.com/users/mysociety/events{/privacy}","received_events_url":"https://api.github.com/users/mysociety/received_events","type":"Organization","site_admin":false},"repo":{"id":487492,"name":"fixmystreet","full_name":"mysociety/fixmystreet","owner":{"login":"mysociety","id":141338,"avatar_url":"https://avatars.githubusercontent.com/u/141338?v=3","gravatar_id":"","url":"https://api.github.com/users/mysociety","html_url":"https://github.com/mysociety","followers_url":"https://api.github.com/users/mysociety/followers","following_url":"https://api.github.com/users/mysociety/following{/other_user}","gists_url":"https://api.github.com/users/mysociety/gists{/gist_id}","starred_url":"https://api.github.com/users/mysociety/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mysociety/subscriptions","organizations_url":"https://api.github.com/users/mysociety/orgs","repos_url":"https://api.github.com/users/mysociety/repos","events_url":"https://api.github.com/users/mysociety/events{/privacy}","received_events_url":"https://api.github.com/users/mysociety/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mysociety/fixmystreet","description":"This is mySociety's popular map-based reporting platform: easy to install in new countries and regions","fork":false,"url":"https://api.github.com/repos/mysociety/fixmystreet","forks_url":"https://api.github.com/repos/mysociety/fixmystreet/forks","keys_url":"https://api.github.com/repos/mysociety/fixmystreet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mysociety/fixmystreet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mysociety/fixmystreet/teams","hooks_url":"https://api.github.com/repos/mysociety/fixmystreet/hooks","issue_events_url":"https://api.github.com/repos/mysociety/fixmystreet/issues/events{/number}","events_url":"https://api.github.com/repos/mysociety/fixmystreet/events","assignees_url":"https://api.github.com/repos/mysociety/fixmystreet/assignees{/user}","branches_url":"https://api.github.com/repos/mysociety/fixmystreet/branches{/branch}","tags_url":"https://api.github.com/repos/mysociety/fixmystreet/tags","blobs_url":"https://api.github.com/repos/mysociety/fixmystreet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mysociety/fixmystreet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mysociety/fixmystreet/git/refs{/sha}","trees_url":"https://api.github.com/repos/mysociety/fixmystreet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mysociety/fixmystreet/statuses/{sha}","languages_url":"https://api.github.com/repos/mysociety/fixmystreet/languages","stargazers_url":"https://api.github.com/repos/mysociety/fixmystreet/stargazers","contributors_url":"https://api.github.com/repos/mysociety/fixmystreet/contributors","subscribers_url":"https://api.github.com/repos/mysociety/fixmystreet/subscribers","subscription_url":"https://api.github.com/repos/mysociety/fixmystreet/subscription","commits_url":"https://api.github.com/repos/mysociety/fixmystreet/commits{/sha}","git_commits_url":"https://api.github.com/repos/mysociety/fixmystreet/git/commits{/sha}","comments_url":"https://api.github.com/repos/mysociety/fixmystreet/comments{/number}","issue_comment_url":"https://api.github.com/repos/mysociety/fixmystreet/issues/comments{/number}","contents_url":"https://api.github.com/repos/mysociety/fixmystreet/contents/{+path}","compare_url":"https://api.github.com/repos/mysociety/fixmystreet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mysociety/fixmystreet/merges","archive_url":"https://api.github.com/repos/mysociety/fixmystreet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mysociety/fixmystreet/downloads","issues_url":"https://api.github.com/repos/mysociety/fixmystreet/issues{/number}","pulls_url":"https://api.github.com/repos/mysociety/fixmystreet/pulls{/number}","milestones_url":"https://api.github.com/repos/mysociety/fixmystreet/milestones{/number}","notifications_url":"https://api.github.com/repos/mysociety/fixmystreet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mysociety/fixmystreet/labels{/name}","releases_url":"https://api.github.com/repos/mysociety/fixmystreet/releases{/id}","deployments_url":"https://api.github.com/repos/mysociety/fixmystreet/deployments","created_at":"2010-01-25T11:54:20Z","updated_at":"2016-06-13T23:21:19Z","pushed_at":"2016-06-15T11:13:30Z","git_url":"git://github.com/mysociety/fixmystreet.git","ssh_url":"git@github.com:mysociety/fixmystreet.git","clone_url":"https://github.com/mysociety/fixmystreet.git","svn_url":"https://github.com/mysociety/fixmystreet","homepage":"http://fixmystreet.org/","size":87228,"stargazers_count":261,"watchers_count":261,"language":"Perl","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":145,"mirror_url":null,"open_issues_count":243,"forks":145,"open_issues":243,"watchers":261,"default_branch":"master"}},"base":{"label":"mysociety:master","ref":"master","sha":"96c72fa72e547a2ce5b435db3cae8c3c45efafc1","user":{"login":"mysociety","id":141338,"avatar_url":"https://avatars.githubusercontent.com/u/141338?v=3","gravatar_id":"","url":"https://api.github.com/users/mysociety","html_url":"https://github.com/mysociety","followers_url":"https://api.github.com/users/mysociety/followers","following_url":"https://api.github.com/users/mysociety/following{/other_user}","gists_url":"https://api.github.com/users/mysociety/gists{/gist_id}","starred_url":"https://api.github.com/users/mysociety/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mysociety/subscriptions","organizations_url":"https://api.github.com/users/mysociety/orgs","repos_url":"https://api.github.com/users/mysociety/repos","events_url":"https://api.github.com/users/mysociety/events{/privacy}","received_events_url":"https://api.github.com/users/mysociety/received_events","type":"Organization","site_admin":false},"repo":{"id":487492,"name":"fixmystreet","full_name":"mysociety/fixmystreet","owner":{"login":"mysociety","id":141338,"avatar_url":"https://avatars.githubusercontent.com/u/141338?v=3","gravatar_id":"","url":"https://api.github.com/users/mysociety","html_url":"https://github.com/mysociety","followers_url":"https://api.github.com/users/mysociety/followers","following_url":"https://api.github.com/users/mysociety/following{/other_user}","gists_url":"https://api.github.com/users/mysociety/gists{/gist_id}","starred_url":"https://api.github.com/users/mysociety/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mysociety/subscriptions","organizations_url":"https://api.github.com/users/mysociety/orgs","repos_url":"https://api.github.com/users/mysociety/repos","events_url":"https://api.github.com/users/mysociety/events{/privacy}","received_events_url":"https://api.github.com/users/mysociety/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mysociety/fixmystreet","description":"This is mySociety's popular map-based reporting platform: easy to install in new countries and regions","fork":false,"url":"https://api.github.com/repos/mysociety/fixmystreet","forks_url":"https://api.github.com/repos/mysociety/fixmystreet/forks","keys_url":"https://api.github.com/repos/mysociety/fixmystreet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mysociety/fixmystreet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mysociety/fixmystreet/teams","hooks_url":"https://api.github.com/repos/mysociety/fixmystreet/hooks","issue_events_url":"https://api.github.com/repos/mysociety/fixmystreet/issues/events{/number}","events_url":"https://api.github.com/repos/mysociety/fixmystreet/events","assignees_url":"https://api.github.com/repos/mysociety/fixmystreet/assignees{/user}","branches_url":"https://api.github.com/repos/mysociety/fixmystreet/branches{/branch}","tags_url":"https://api.github.com/repos/mysociety/fixmystreet/tags","blobs_url":"https://api.github.com/repos/mysociety/fixmystreet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mysociety/fixmystreet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mysociety/fixmystreet/git/refs{/sha}","trees_url":"https://api.github.com/repos/mysociety/fixmystreet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mysociety/fixmystreet/statuses/{sha}","languages_url":"https://api.github.com/repos/mysociety/fixmystreet/languages","stargazers_url":"https://api.github.com/repos/mysociety/fixmystreet/stargazers","contributors_url":"https://api.github.com/repos/mysociety/fixmystreet/contributors","subscribers_url":"https://api.github.com/repos/mysociety/fixmystreet/subscribers","subscription_url":"https://api.github.com/repos/mysociety/fixmystreet/subscription","commits_url":"https://api.github.com/repos/mysociety/fixmystreet/commits{/sha}","git_commits_url":"https://api.github.com/repos/mysociety/fixmystreet/git/commits{/sha}","comments_url":"https://api.github.com/repos/mysociety/fixmystreet/comments{/number}","issue_comment_url":"https://api.github.com/repos/mysociety/fixmystreet/issues/comments{/number}","contents_url":"https://api.github.com/repos/mysociety/fixmystreet/contents/{+path}","compare_url":"https://api.github.com/repos/mysociety/fixmystreet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mysociety/fixmystreet/merges","archive_url":"https://api.github.com/repos/mysociety/fixmystreet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mysociety/fixmystreet/downloads","issues_url":"https://api.github.com/repos/mysociety/fixmystreet/issues{/number}","pulls_url":"https://api.github.com/repos/mysociety/fixmystreet/pulls{/number}","milestones_url":"https://api.github.com/repos/mysociety/fixmystreet/milestones{/number}","notifications_url":"https://api.github.com/repos/mysociety/fixmystreet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mysociety/fixmystreet/labels{/name}","releases_url":"https://api.github.com/repos/mysociety/fixmystreet/releases{/id}","deployments_url":"https://api.github.com/repos/mysociety/fixmystreet/deployments","created_at":"2010-01-25T11:54:20Z","updated_at":"2016-06-13T23:21:19Z","pushed_at":"2016-06-15T11:13:30Z","git_url":"git://github.com/mysociety/fixmystreet.git","ssh_url":"git@github.com:mysociety/fixmystreet.git","clone_url":"https://github.com/mysociety/fixmystreet.git","svn_url":"https://github.com/mysociety/fixmystreet","homepage":"http://fixmystreet.org/","size":87228,"stargazers_count":261,"watchers_count":261,"language":"Perl","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":145,"mirror_url":null,"open_issues_count":243,"forks":145,"open_issues":243,"watchers":261,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mysociety/fixmystreet/pulls/1427"},"html":{"href":"https://github.com/mysociety/fixmystreet/pull/1427"},"issue":{"href":"https://api.github.com/repos/mysociety/fixmystreet/issues/1427"},"comments":{"href":"https://api.github.com/repos/mysociety/fixmystreet/issues/1427/comments"},"review_comments":{"href":"https://api.github.com/repos/mysociety/fixmystreet/pulls/1427/comments"},"review_comment":{"href":"https://api.github.com/repos/mysociety/fixmystreet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mysociety/fixmystreet/pulls/1427/commits"},"statuses":{"href":"https://api.github.com/repos/mysociety/fixmystreet/statuses/e49fe2fb72eb5187c073045b7449caf827f71ec4"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":90,"deletions":5,"changed_files":4}}
{"actor":{"display_login":"davea"}}