{"action":"created","issue":{"url":"https://api.github.com/repos/Homebrew/brew/issues/542","repository_url":"https://api.github.com/repos/Homebrew/brew","labels_url":"https://api.github.com/repos/Homebrew/brew/issues/542/labels{/name}","comments_url":"https://api.github.com/repos/Homebrew/brew/issues/542/comments","events_url":"https://api.github.com/repos/Homebrew/brew/issues/542/events","html_url":"https://github.com/Homebrew/brew/pull/542","id":165977815,"number":542,"title":"Cleanup compat/ style and warnings","user":{"login":"MikeMcQuaid","id":125011,"avatar_url":"https://avatars.githubusercontent.com/u/125011?v=3","gravatar_id":"","url":"https://api.github.com/users/MikeMcQuaid","html_url":"https://github.com/MikeMcQuaid","followers_url":"https://api.github.com/users/MikeMcQuaid/followers","following_url":"https://api.github.com/users/MikeMcQuaid/following{/other_user}","gists_url":"https://api.github.com/users/MikeMcQuaid/gists{/gist_id}","starred_url":"https://api.github.com/users/MikeMcQuaid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikeMcQuaid/subscriptions","organizations_url":"https://api.github.com/users/MikeMcQuaid/orgs","repos_url":"https://api.github.com/users/MikeMcQuaid/repos","events_url":"https://api.github.com/users/MikeMcQuaid/events{/privacy}","received_events_url":"https://api.github.com/users/MikeMcQuaid/received_events","type":"User","site_admin":true},"labels":[{"url":"https://api.github.com/repos/Homebrew/brew/labels/in%20progress","name":"in progress","color":"ededed"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-07-17T13:56:45Z","updated_at":"2016-07-27T02:18:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Homebrew/brew/pulls/542","html_url":"https://github.com/Homebrew/brew/pull/542","diff_url":"https://github.com/Homebrew/brew/pull/542.diff","patch_url":"https://github.com/Homebrew/brew/pull/542.patch"},"body":"- [x] Have you followed the guidelines in our [Contributing](https://github.com/Homebrew/brew/blob/master/.github/CONTRIBUTING.md) document?\r\n- [x] Have you checked to ensure there aren't other open [Pull Requests](https://github.com/Homebrew/brew/pulls) for the same change?\r\n- [x] Have you added an explanation of what your changes do and why you'd like us to include them?\r\n- [x] Have you written new tests for your changes? [Here's an example](https://github.com/Homebrew/homebrew/pull/49031).\r\n- [x] Have you successfully run `brew tests` with your changes locally?\r\n\r\n-----\r\n\r\nCleanup the style and warning text of `compat/` and fix a test that ended up printing compatibility warnings."},"comment":{"url":"https://api.github.com/repos/Homebrew/brew/issues/comments/235462534","html_url":"https://github.com/Homebrew/brew/pull/542#issuecomment-235462534","issue_url":"https://api.github.com/repos/Homebrew/brew/issues/542","id":235462534,"user":{"login":"MikeMcQuaid","id":125011,"avatar_url":"https://avatars.githubusercontent.com/u/125011?v=3","gravatar_id":"","url":"https://api.github.com/users/MikeMcQuaid","html_url":"https://github.com/MikeMcQuaid","followers_url":"https://api.github.com/users/MikeMcQuaid/followers","following_url":"https://api.github.com/users/MikeMcQuaid/following{/other_user}","gists_url":"https://api.github.com/users/MikeMcQuaid/gists{/gist_id}","starred_url":"https://api.github.com/users/MikeMcQuaid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikeMcQuaid/subscriptions","organizations_url":"https://api.github.com/users/MikeMcQuaid/orgs","repos_url":"https://api.github.com/users/MikeMcQuaid/repos","events_url":"https://api.github.com/users/MikeMcQuaid/events{/privacy}","received_events_url":"https://api.github.com/users/MikeMcQuaid/received_events","type":"User","site_admin":true},"created_at":"2016-07-27T02:18:11Z","updated_at":"2016-07-27T02:18:11Z","body":"> All those opoo-puts pairs make me want to have a more specialized method for outputting these warnings in a more consistent way\r\n\r\nI agree but: given this is already the existing style can we leave it as-is for now?\r\n\r\n> (and possibly, but not necessarily, an option to silence this advice).\r\n\r\nDefinitely 👎 to silencing these; they should be annoying so they get fixed 😀.\r\n\r\n> It would be nice if these warnings provided a back-trace (maybe guarded behind a check for --debug) and in cases where the origin is a formula, also printed the name/path of the offending formula (should be doable by walking the stack).\r\n\r\nThis would be a good idea but I think it's probably out of the scope of this PR?"}}
{"actor":{"display_login":"MikeMcQuaid"}}