{"action":"created","issue":{"url":"https://api.github.com/repos/boomerdigital/solidus_amazon_payments/issues/3","repository_url":"https://api.github.com/repos/boomerdigital/solidus_amazon_payments","labels_url":"https://api.github.com/repos/boomerdigital/solidus_amazon_payments/issues/3/labels{/name}","comments_url":"https://api.github.com/repos/boomerdigital/solidus_amazon_payments/issues/3/comments","events_url":"https://api.github.com/repos/boomerdigital/solidus_amazon_payments/issues/3/events","html_url":"https://github.com/boomerdigital/solidus_amazon_payments/issues/3","id":149841464,"number":3,"title":"Stuff we need to look at","user":{"login":"manmartinez","id":1505446,"avatar_url":"https://avatars.githubusercontent.com/u/1505446?v=3","gravatar_id":"","url":"https://api.github.com/users/manmartinez","html_url":"https://github.com/manmartinez","followers_url":"https://api.github.com/users/manmartinez/followers","following_url":"https://api.github.com/users/manmartinez/following{/other_user}","gists_url":"https://api.github.com/users/manmartinez/gists{/gist_id}","starred_url":"https://api.github.com/users/manmartinez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manmartinez/subscriptions","organizations_url":"https://api.github.com/users/manmartinez/orgs","repos_url":"https://api.github.com/users/manmartinez/repos","events_url":"https://api.github.com/users/manmartinez/events{/privacy}","received_events_url":"https://api.github.com/users/manmartinez/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2016-04-20T17:59:46Z","updated_at":"2016-04-22T09:10:27Z","closed_at":null,"body":"1. Why do we need `solidus_social`? I think it allows users to sign in through amazon, but I'm not even sure if it works\r\n2. Refunding a transaction from the spree admin doesn't work, the button is just sitting there pointing to '#'\r\n3. We should probably remove all Amazon copyright notices.\r\n4. We need to update the gemspec file to set the author and description\r\n5. Add more test coverage\r\n6. Storing configuration inside `Spree::AppConfiguration` won't work if `use_static_preferences!` is being used, we should probably have our own configuration class\r\n7. Revisit the `Spree::AmazonTransaction` idea, right now an order `has_many` amazon transactions, and a payment also has an amazon transaction as a source, so in the best case scenario we end up with two amazon transactions per order, which doesn't make much sense to me...\r\n8. Refactor `Spree::AmazonController`. Although I've done some work there, there's still a lot of logic in that controller we probably want to extract some classes to take care of updating the spree order through checkout\r\n9. Refactor `Spree::Gateway::Amazon` looks pretty terrible :panda_face: &larr; That's a sad panda\r\n10. Take a look at closing payments. Apparently we've added the `close` event to a payment, but we also added a new method on the processing module called `close!` those two are overriding each other, probably not what we want"},"comment":{"url":"https://api.github.com/repos/boomerdigital/solidus_amazon_payments/issues/comments/213343593","html_url":"https://github.com/boomerdigital/solidus_amazon_payments/issues/3#issuecomment-213343593","issue_url":"https://api.github.com/repos/boomerdigital/solidus_amazon_payments/issues/3","id":213343593,"user":{"login":"mtomov","id":1651750,"avatar_url":"https://avatars.githubusercontent.com/u/1651750?v=3","gravatar_id":"","url":"https://api.github.com/users/mtomov","html_url":"https://github.com/mtomov","followers_url":"https://api.github.com/users/mtomov/followers","following_url":"https://api.github.com/users/mtomov/following{/other_user}","gists_url":"https://api.github.com/users/mtomov/gists{/gist_id}","starred_url":"https://api.github.com/users/mtomov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtomov/subscriptions","organizations_url":"https://api.github.com/users/mtomov/orgs","repos_url":"https://api.github.com/users/mtomov/repos","events_url":"https://api.github.com/users/mtomov/events{/privacy}","received_events_url":"https://api.github.com/users/mtomov/received_events","type":"User","site_admin":false},"created_at":"2016-04-22T09:10:27Z","updated_at":"2016-04-22T09:10:27Z","body":"> @mtomov Yeah configuration is a big deal, I handled this on another spree extension by inheriting from\r\nSpree::Preferences::Configuration you can take a look here if you think this works I'll make a PR\r\n\r\nYes, I think this works. Found a similar example for [Solidus Globalize](https://github.com/solidusio-contrib/solidus_globalize/blob/master/lib/solidus_globalize/configuration.rb), so this should be the correct way to do it. \r\n\r\nI don't really understand why just decorating the App configuration doesn't work, but I trust you. It might be because of the load order and them being in-memory cached.\r\n\r\nI think that if the Admin UI is already there, and if we just need to set-up those preferences correctly, then that would be preferable over storing them in an initializer."}}