{"action":"created","comment":{"url":"https://api.github.com/repos/phpbb/phpbb/pulls/comments/91838080","pull_request_review_id":12350700,"id":91838080,"diff_hunk":"@@ -1269,6 +1269,10 @@ ul.linklist:after,\n \tpadding: 4px 6px;\n }\n \n+.badge.hidden {\n+\tdisplay: none;\n+}\n+","path":"phpBB/styles/prosilver/theme/common.css","position":7,"original_position":7,"commit_id":"41b3450f2f93158e6a8135657b21030eb5d6b3c9","original_commit_id":"41b3450f2f93158e6a8135657b21030eb5d6b3c9","user":{"login":"javiexin","id":11807050,"avatar_url":"https://avatars.githubusercontent.com/u/11807050?v=3","gravatar_id":"","url":"https://api.github.com/users/javiexin","html_url":"https://github.com/javiexin","followers_url":"https://api.github.com/users/javiexin/followers","following_url":"https://api.github.com/users/javiexin/following{/other_user}","gists_url":"https://api.github.com/users/javiexin/gists{/gist_id}","starred_url":"https://api.github.com/users/javiexin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javiexin/subscriptions","organizations_url":"https://api.github.com/users/javiexin/orgs","repos_url":"https://api.github.com/users/javiexin/repos","events_url":"https://api.github.com/users/javiexin/events{/privacy}","received_events_url":"https://api.github.com/users/javiexin/received_events","type":"User","site_admin":false},"body":"If you prefer, it is possible to move the badge rule before the hidden rule, and that way, we would not need the extra rule. But I figured this would provide a hint to developers not to override the generic hidden rule (used elsewhere) but to modify this one, much more specific.","created_at":"2016-12-10T16:41:18Z","updated_at":"2016-12-10T16:41:18Z","html_url":"https://github.com/phpbb/phpbb/pull/4572#discussion_r91838080","pull_request_url":"https://api.github.com/repos/phpbb/phpbb/pulls/4572","_links":{"self":{"href":"https://api.github.com/repos/phpbb/phpbb/pulls/comments/91838080"},"html":{"href":"https://github.com/phpbb/phpbb/pull/4572#discussion_r91838080"},"pull_request":{"href":"https://api.github.com/repos/phpbb/phpbb/pulls/4572"}}},"pull_request":{"url":"https://api.github.com/repos/phpbb/phpbb/pulls/4572","id":97401014,"html_url":"https://github.com/phpbb/phpbb/pull/4572","diff_url":"https://github.com/phpbb/phpbb/pull/4572.diff","patch_url":"https://github.com/phpbb/phpbb/pull/4572.patch","issue_url":"https://api.github.com/repos/phpbb/phpbb/issues/4572","number":4572,"state":"open","locked":false,"title":"[ticket/14855] Update notification and PM alert bubbles","user":{"login":"javiexin","id":11807050,"avatar_url":"https://avatars.githubusercontent.com/u/11807050?v=3","gravatar_id":"","url":"https://api.github.com/users/javiexin","html_url":"https://github.com/javiexin","followers_url":"https://api.github.com/users/javiexin/followers","following_url":"https://api.github.com/users/javiexin/following{/other_user}","gists_url":"https://api.github.com/users/javiexin/gists{/gist_id}","starred_url":"https://api.github.com/users/javiexin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javiexin/subscriptions","organizations_url":"https://api.github.com/users/javiexin/orgs","repos_url":"https://api.github.com/users/javiexin/repos","events_url":"https://api.github.com/users/javiexin/events{/privacy}","received_events_url":"https://api.github.com/users/javiexin/received_events","type":"User","site_admin":false},"body":"Checklist:\r\n\r\n- [ ] Correct branch: master for new features; 3.2.x, 3.1.x for fixes\r\n- [ ] Tests pass\r\n- [ ] Code follows coding guidelines: [master / 3.2.x](https://area51.phpbb.com/docs/master/coding-guidelines.html), [3.1.x](https://area51.phpbb.com/docs/31x/coding-guidelines.html)\r\n- [ ] Commit follows commit message [format](https://wiki.phpbb.com/Git#Commit_Messages)\r\n\r\nTracker ticket:\r\n\r\nhttps://tracker.phpbb.com/browse/PHPBB3-14855\r\n\r\nAlternative implementation without removing notification from\r\nthe DOM, but changing the class.  So that style designers\r\nmight have more options (show/not show).\r\n\r\nPHPBB3-14855","created_at":"2016-12-09T23:56:56Z","updated_at":"2016-12-10T16:41:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a9726dc285fbe751302809a91d6cff18e856215f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/phpbb/phpbb/pulls/4572/commits","review_comments_url":"https://api.github.com/repos/phpbb/phpbb/pulls/4572/comments","review_comment_url":"https://api.github.com/repos/phpbb/phpbb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/phpbb/phpbb/issues/4572/comments","statuses_url":"https://api.github.com/repos/phpbb/phpbb/statuses/41b3450f2f93158e6a8135657b21030eb5d6b3c9","head":{"label":"javiexin:ticket/14855","ref":"ticket/14855","sha":"41b3450f2f93158e6a8135657b21030eb5d6b3c9","user":{"login":"javiexin","id":11807050,"avatar_url":"https://avatars.githubusercontent.com/u/11807050?v=3","gravatar_id":"","url":"https://api.github.com/users/javiexin","html_url":"https://github.com/javiexin","followers_url":"https://api.github.com/users/javiexin/followers","following_url":"https://api.github.com/users/javiexin/following{/other_user}","gists_url":"https://api.github.com/users/javiexin/gists{/gist_id}","starred_url":"https://api.github.com/users/javiexin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javiexin/subscriptions","organizations_url":"https://api.github.com/users/javiexin/orgs","repos_url":"https://api.github.com/users/javiexin/repos","events_url":"https://api.github.com/users/javiexin/events{/privacy}","received_events_url":"https://api.github.com/users/javiexin/received_events","type":"User","site_admin":false},"repo":{"id":33443243,"name":"phpbb","full_name":"javiexin/phpbb","owner":{"login":"javiexin","id":11807050,"avatar_url":"https://avatars.githubusercontent.com/u/11807050?v=3","gravatar_id":"","url":"https://api.github.com/users/javiexin","html_url":"https://github.com/javiexin","followers_url":"https://api.github.com/users/javiexin/followers","following_url":"https://api.github.com/users/javiexin/following{/other_user}","gists_url":"https://api.github.com/users/javiexin/gists{/gist_id}","starred_url":"https://api.github.com/users/javiexin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javiexin/subscriptions","organizations_url":"https://api.github.com/users/javiexin/orgs","repos_url":"https://api.github.com/users/javiexin/repos","events_url":"https://api.github.com/users/javiexin/events{/privacy}","received_events_url":"https://api.github.com/users/javiexin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/javiexin/phpbb","description":" phpBB 3 Development: phpBB is a popular open-source bulletin board written in PHP. This repository also contains the history of version 2.","fork":true,"url":"https://api.github.com/repos/javiexin/phpbb","forks_url":"https://api.github.com/repos/javiexin/phpbb/forks","keys_url":"https://api.github.com/repos/javiexin/phpbb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/javiexin/phpbb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/javiexin/phpbb/teams","hooks_url":"https://api.github.com/repos/javiexin/phpbb/hooks","issue_events_url":"https://api.github.com/repos/javiexin/phpbb/issues/events{/number}","events_url":"https://api.github.com/repos/javiexin/phpbb/events","assignees_url":"https://api.github.com/repos/javiexin/phpbb/assignees{/user}","branches_url":"https://api.github.com/repos/javiexin/phpbb/branches{/branch}","tags_url":"https://api.github.com/repos/javiexin/phpbb/tags","blobs_url":"https://api.github.com/repos/javiexin/phpbb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/javiexin/phpbb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/javiexin/phpbb/git/refs{/sha}","trees_url":"https://api.github.com/repos/javiexin/phpbb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/javiexin/phpbb/statuses/{sha}","languages_url":"https://api.github.com/repos/javiexin/phpbb/languages","stargazers_url":"https://api.github.com/repos/javiexin/phpbb/stargazers","contributors_url":"https://api.github.com/repos/javiexin/phpbb/contributors","subscribers_url":"https://api.github.com/repos/javiexin/phpbb/subscribers","subscription_url":"https://api.github.com/repos/javiexin/phpbb/subscription","commits_url":"https://api.github.com/repos/javiexin/phpbb/commits{/sha}","git_commits_url":"https://api.github.com/repos/javiexin/phpbb/git/commits{/sha}","comments_url":"https://api.github.com/repos/javiexin/phpbb/comments{/number}","issue_comment_url":"https://api.github.com/repos/javiexin/phpbb/issues/comments{/number}","contents_url":"https://api.github.com/repos/javiexin/phpbb/contents/{+path}","compare_url":"https://api.github.com/repos/javiexin/phpbb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/javiexin/phpbb/merges","archive_url":"https://api.github.com/repos/javiexin/phpbb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/javiexin/phpbb/downloads","issues_url":"https://api.github.com/repos/javiexin/phpbb/issues{/number}","pulls_url":"https://api.github.com/repos/javiexin/phpbb/pulls{/number}","milestones_url":"https://api.github.com/repos/javiexin/phpbb/milestones{/number}","notifications_url":"https://api.github.com/repos/javiexin/phpbb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/javiexin/phpbb/labels{/name}","releases_url":"https://api.github.com/repos/javiexin/phpbb/releases{/id}","deployments_url":"https://api.github.com/repos/javiexin/phpbb/deployments","created_at":"2015-04-05T14:27:02Z","updated_at":"2016-10-26T02:31:58Z","pushed_at":"2016-12-10T10:41:32Z","git_url":"git://github.com/javiexin/phpbb.git","ssh_url":"git@github.com:javiexin/phpbb.git","clone_url":"https://github.com/javiexin/phpbb.git","svn_url":"https://github.com/javiexin/phpbb","homepage":"http://www.phpbb.com","size":50217,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"3.1.x"}},"base":{"label":"phpbb:3.1.x","ref":"3.1.x","sha":"3322117c3863c443ca1b79d25541bde4c662c0ed","user":{"login":"phpbb","id":176697,"avatar_url":"https://avatars.githubusercontent.com/u/176697?v=3","gravatar_id":"","url":"https://api.github.com/users/phpbb","html_url":"https://github.com/phpbb","followers_url":"https://api.github.com/users/phpbb/followers","following_url":"https://api.github.com/users/phpbb/following{/other_user}","gists_url":"https://api.github.com/users/phpbb/gists{/gist_id}","starred_url":"https://api.github.com/users/phpbb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phpbb/subscriptions","organizations_url":"https://api.github.com/users/phpbb/orgs","repos_url":"https://api.github.com/users/phpbb/repos","events_url":"https://api.github.com/users/phpbb/events{/privacy}","received_events_url":"https://api.github.com/users/phpbb/received_events","type":"Organization","site_admin":false},"repo":{"id":541983,"name":"phpbb","full_name":"phpbb/phpbb","owner":{"login":"phpbb","id":176697,"avatar_url":"https://avatars.githubusercontent.com/u/176697?v=3","gravatar_id":"","url":"https://api.github.com/users/phpbb","html_url":"https://github.com/phpbb","followers_url":"https://api.github.com/users/phpbb/followers","following_url":"https://api.github.com/users/phpbb/following{/other_user}","gists_url":"https://api.github.com/users/phpbb/gists{/gist_id}","starred_url":"https://api.github.com/users/phpbb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phpbb/subscriptions","organizations_url":"https://api.github.com/users/phpbb/orgs","repos_url":"https://api.github.com/users/phpbb/repos","events_url":"https://api.github.com/users/phpbb/events{/privacy}","received_events_url":"https://api.github.com/users/phpbb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/phpbb/phpbb","description":" phpBB 3 Development: phpBB is a popular open-source bulletin board written in PHP. This repository also contains the history of version 2.","fork":false,"url":"https://api.github.com/repos/phpbb/phpbb","forks_url":"https://api.github.com/repos/phpbb/phpbb/forks","keys_url":"https://api.github.com/repos/phpbb/phpbb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phpbb/phpbb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phpbb/phpbb/teams","hooks_url":"https://api.github.com/repos/phpbb/phpbb/hooks","issue_events_url":"https://api.github.com/repos/phpbb/phpbb/issues/events{/number}","events_url":"https://api.github.com/repos/phpbb/phpbb/events","assignees_url":"https://api.github.com/repos/phpbb/phpbb/assignees{/user}","branches_url":"https://api.github.com/repos/phpbb/phpbb/branches{/branch}","tags_url":"https://api.github.com/repos/phpbb/phpbb/tags","blobs_url":"https://api.github.com/repos/phpbb/phpbb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phpbb/phpbb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phpbb/phpbb/git/refs{/sha}","trees_url":"https://api.github.com/repos/phpbb/phpbb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phpbb/phpbb/statuses/{sha}","languages_url":"https://api.github.com/repos/phpbb/phpbb/languages","stargazers_url":"https://api.github.com/repos/phpbb/phpbb/stargazers","contributors_url":"https://api.github.com/repos/phpbb/phpbb/contributors","subscribers_url":"https://api.github.com/repos/phpbb/phpbb/subscribers","subscription_url":"https://api.github.com/repos/phpbb/phpbb/subscription","commits_url":"https://api.github.com/repos/phpbb/phpbb/commits{/sha}","git_commits_url":"https://api.github.com/repos/phpbb/phpbb/git/commits{/sha}","comments_url":"https://api.github.com/repos/phpbb/phpbb/comments{/number}","issue_comment_url":"https://api.github.com/repos/phpbb/phpbb/issues/comments{/number}","contents_url":"https://api.github.com/repos/phpbb/phpbb/contents/{+path}","compare_url":"https://api.github.com/repos/phpbb/phpbb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phpbb/phpbb/merges","archive_url":"https://api.github.com/repos/phpbb/phpbb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phpbb/phpbb/downloads","issues_url":"https://api.github.com/repos/phpbb/phpbb/issues{/number}","pulls_url":"https://api.github.com/repos/phpbb/phpbb/pulls{/number}","milestones_url":"https://api.github.com/repos/phpbb/phpbb/milestones{/number}","notifications_url":"https://api.github.com/repos/phpbb/phpbb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phpbb/phpbb/labels{/name}","releases_url":"https://api.github.com/repos/phpbb/phpbb/releases{/id}","deployments_url":"https://api.github.com/repos/phpbb/phpbb/deployments","created_at":"2010-03-01T22:33:17Z","updated_at":"2016-12-09T15:36:16Z","pushed_at":"2016-12-10T12:40:12Z","git_url":"git://github.com/phpbb/phpbb.git","ssh_url":"git@github.com:phpbb/phpbb.git","clone_url":"https://github.com/phpbb/phpbb.git","svn_url":"https://github.com/phpbb/phpbb","homepage":"http://www.phpbb.com","size":173498,"stargazers_count":947,"watchers_count":947,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":565,"mirror_url":null,"open_issues_count":57,"forks":565,"open_issues":57,"watchers":947,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/phpbb/phpbb/pulls/4572"},"html":{"href":"https://github.com/phpbb/phpbb/pull/4572"},"issue":{"href":"https://api.github.com/repos/phpbb/phpbb/issues/4572"},"comments":{"href":"https://api.github.com/repos/phpbb/phpbb/issues/4572/comments"},"review_comments":{"href":"https://api.github.com/repos/phpbb/phpbb/pulls/4572/comments"},"review_comment":{"href":"https://api.github.com/repos/phpbb/phpbb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/phpbb/phpbb/pulls/4572/commits"},"statuses":{"href":"https://api.github.com/repos/phpbb/phpbb/statuses/41b3450f2f93158e6a8135657b21030eb5d6b3c9"}}}}
{"actor":{"display_login":"javiexin"}}