{"action":"created","comment":{"url":"https://api.github.com/repos/openssl/openssl/pulls/comments/55358368","id":55358368,"diff_hunk":"@@ -38,6 +39,8 @@ BIO_new() returns a newly created BIO or NULL if the call fails.\n \n BIO_set(), BIO_free() return 1 for success and 0 for failure.\n \n+BIO_up_ref() increments the reference count associated with the BIO object.","path":"doc/crypto/BIO_new.pod","position":21,"original_position":21,"commit_id":"83d8f1d1782bb8ed4797ac36c7542aa272f0b23c","original_commit_id":"83d8f1d1782bb8ed4797ac36c7542aa272f0b23c","user":{"login":"mattcaswell","id":7422273,"avatar_url":"https://avatars.githubusercontent.com/u/7422273?v=3","gravatar_id":"","url":"https://api.github.com/users/mattcaswell","html_url":"https://github.com/mattcaswell","followers_url":"https://api.github.com/users/mattcaswell/followers","following_url":"https://api.github.com/users/mattcaswell/following{/other_user}","gists_url":"https://api.github.com/users/mattcaswell/gists{/gist_id}","starred_url":"https://api.github.com/users/mattcaswell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattcaswell/subscriptions","organizations_url":"https://api.github.com/users/mattcaswell/orgs","repos_url":"https://api.github.com/users/mattcaswell/repos","events_url":"https://api.github.com/users/mattcaswell/events{/privacy}","received_events_url":"https://api.github.com/users/mattcaswell/received_events","type":"User","site_admin":false},"body":"This should be in the DESCRIPTION section, with BIO_up_ref() additionally added to the sentence above with the list of functions returning 1 for success and 0 for failure.","created_at":"2016-03-08T13:32:45Z","updated_at":"2016-03-08T13:32:45Z","html_url":"https://github.com/openssl/openssl/pull/772#discussion_r55358368","pull_request_url":"https://api.github.com/repos/openssl/openssl/pulls/772","_links":{"self":{"href":"https://api.github.com/repos/openssl/openssl/pulls/comments/55358368"},"html":{"href":"https://github.com/openssl/openssl/pull/772#discussion_r55358368"},"pull_request":{"href":"https://api.github.com/repos/openssl/openssl/pulls/772"}}},"pull_request":{"url":"https://api.github.com/repos/openssl/openssl/pulls/772","id":61290664,"html_url":"https://github.com/openssl/openssl/pull/772","diff_url":"https://github.com/openssl/openssl/pull/772.diff","patch_url":"https://github.com/openssl/openssl/pull/772.patch","issue_url":"https://api.github.com/repos/openssl/openssl/issues/772","number":772,"state":"open","locked":false,"title":"Threading API conversion, vol. 1","user":{"login":"ghedo","id":117643,"avatar_url":"https://avatars.githubusercontent.com/u/117643?v=3","gravatar_id":"","url":"https://api.github.com/users/ghedo","html_url":"https://github.com/ghedo","followers_url":"https://api.github.com/users/ghedo/followers","following_url":"https://api.github.com/users/ghedo/following{/other_user}","gists_url":"https://api.github.com/users/ghedo/gists{/gist_id}","starred_url":"https://api.github.com/users/ghedo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghedo/subscriptions","organizations_url":"https://api.github.com/users/ghedo/orgs","repos_url":"https://api.github.com/users/ghedo/repos","events_url":"https://api.github.com/users/ghedo/events{/privacy}","received_events_url":"https://api.github.com/users/ghedo/received_events","type":"User","site_admin":false},"body":"This is the first part of the conversion to the new multi-threading API. It's already quite big, so it's better to review the work so far instead of getting a bigger (and more difficult to review) PR later on.\r\n\r\nI added a few more *_up_ref() functions which is IMO better practice instead of using the atomic add directly and there's some style cleanup mixed in (sorry about that).","created_at":"2016-03-01T19:00:56Z","updated_at":"2016-03-08T13:32:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9820bc41135095c3e4686756bfdffdacaa105b78","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openssl/openssl/pulls/772/commits","review_comments_url":"https://api.github.com/repos/openssl/openssl/pulls/772/comments","review_comment_url":"https://api.github.com/repos/openssl/openssl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openssl/openssl/issues/772/comments","statuses_url":"https://api.github.com/repos/openssl/openssl/statuses/83d8f1d1782bb8ed4797ac36c7542aa272f0b23c","head":{"label":"ghedo:thread_api_bis","ref":"thread_api_bis","sha":"83d8f1d1782bb8ed4797ac36c7542aa272f0b23c","user":{"login":"ghedo","id":117643,"avatar_url":"https://avatars.githubusercontent.com/u/117643?v=3","gravatar_id":"","url":"https://api.github.com/users/ghedo","html_url":"https://github.com/ghedo","followers_url":"https://api.github.com/users/ghedo/followers","following_url":"https://api.github.com/users/ghedo/following{/other_user}","gists_url":"https://api.github.com/users/ghedo/gists{/gist_id}","starred_url":"https://api.github.com/users/ghedo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghedo/subscriptions","organizations_url":"https://api.github.com/users/ghedo/orgs","repos_url":"https://api.github.com/users/ghedo/repos","events_url":"https://api.github.com/users/ghedo/events{/privacy}","received_events_url":"https://api.github.com/users/ghedo/received_events","type":"User","site_admin":false},"repo":{"id":40092243,"name":"openssl","full_name":"ghedo/openssl","owner":{"login":"ghedo","id":117643,"avatar_url":"https://avatars.githubusercontent.com/u/117643?v=3","gravatar_id":"","url":"https://api.github.com/users/ghedo","html_url":"https://github.com/ghedo","followers_url":"https://api.github.com/users/ghedo/followers","following_url":"https://api.github.com/users/ghedo/following{/other_user}","gists_url":"https://api.github.com/users/ghedo/gists{/gist_id}","starred_url":"https://api.github.com/users/ghedo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghedo/subscriptions","organizations_url":"https://api.github.com/users/ghedo/orgs","repos_url":"https://api.github.com/users/ghedo/repos","events_url":"https://api.github.com/users/ghedo/events{/privacy}","received_events_url":"https://api.github.com/users/ghedo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ghedo/openssl","description":"","fork":true,"url":"https://api.github.com/repos/ghedo/openssl","forks_url":"https://api.github.com/repos/ghedo/openssl/forks","keys_url":"https://api.github.com/repos/ghedo/openssl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ghedo/openssl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ghedo/openssl/teams","hooks_url":"https://api.github.com/repos/ghedo/openssl/hooks","issue_events_url":"https://api.github.com/repos/ghedo/openssl/issues/events{/number}","events_url":"https://api.github.com/repos/ghedo/openssl/events","assignees_url":"https://api.github.com/repos/ghedo/openssl/assignees{/user}","branches_url":"https://api.github.com/repos/ghedo/openssl/branches{/branch}","tags_url":"https://api.github.com/repos/ghedo/openssl/tags","blobs_url":"https://api.github.com/repos/ghedo/openssl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ghedo/openssl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ghedo/openssl/git/refs{/sha}","trees_url":"https://api.github.com/repos/ghedo/openssl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ghedo/openssl/statuses/{sha}","languages_url":"https://api.github.com/repos/ghedo/openssl/languages","stargazers_url":"https://api.github.com/repos/ghedo/openssl/stargazers","contributors_url":"https://api.github.com/repos/ghedo/openssl/contributors","subscribers_url":"https://api.github.com/repos/ghedo/openssl/subscribers","subscription_url":"https://api.github.com/repos/ghedo/openssl/subscription","commits_url":"https://api.github.com/repos/ghedo/openssl/commits{/sha}","git_commits_url":"https://api.github.com/repos/ghedo/openssl/git/commits{/sha}","comments_url":"https://api.github.com/repos/ghedo/openssl/comments{/number}","issue_comment_url":"https://api.github.com/repos/ghedo/openssl/issues/comments{/number}","contents_url":"https://api.github.com/repos/ghedo/openssl/contents/{+path}","compare_url":"https://api.github.com/repos/ghedo/openssl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ghedo/openssl/merges","archive_url":"https://api.github.com/repos/ghedo/openssl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ghedo/openssl/downloads","issues_url":"https://api.github.com/repos/ghedo/openssl/issues{/number}","pulls_url":"https://api.github.com/repos/ghedo/openssl/pulls{/number}","milestones_url":"https://api.github.com/repos/ghedo/openssl/milestones{/number}","notifications_url":"https://api.github.com/repos/ghedo/openssl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ghedo/openssl/labels{/name}","releases_url":"https://api.github.com/repos/ghedo/openssl/releases{/id}","deployments_url":"https://api.github.com/repos/ghedo/openssl/deployments","created_at":"2015-08-02T20:43:48Z","updated_at":"2015-08-21T11:07:19Z","pushed_at":"2016-03-08T13:06:09Z","git_url":"git://github.com/ghedo/openssl.git","ssh_url":"git@github.com:ghedo/openssl.git","clone_url":"https://github.com/ghedo/openssl.git","svn_url":"https://github.com/ghedo/openssl","homepage":null,"size":81856,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openssl:master","ref":"master","sha":"54bb8f74bd3931f801472e86c481c80f868c2b91","user":{"login":"openssl","id":3279138,"avatar_url":"https://avatars.githubusercontent.com/u/3279138?v=3","gravatar_id":"","url":"https://api.github.com/users/openssl","html_url":"https://github.com/openssl","followers_url":"https://api.github.com/users/openssl/followers","following_url":"https://api.github.com/users/openssl/following{/other_user}","gists_url":"https://api.github.com/users/openssl/gists{/gist_id}","starred_url":"https://api.github.com/users/openssl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openssl/subscriptions","organizations_url":"https://api.github.com/users/openssl/orgs","repos_url":"https://api.github.com/users/openssl/repos","events_url":"https://api.github.com/users/openssl/events{/privacy}","received_events_url":"https://api.github.com/users/openssl/received_events","type":"Organization","site_admin":false},"repo":{"id":7634677,"name":"openssl","full_name":"openssl/openssl","owner":{"login":"openssl","id":3279138,"avatar_url":"https://avatars.githubusercontent.com/u/3279138?v=3","gravatar_id":"","url":"https://api.github.com/users/openssl","html_url":"https://github.com/openssl","followers_url":"https://api.github.com/users/openssl/followers","following_url":"https://api.github.com/users/openssl/following{/other_user}","gists_url":"https://api.github.com/users/openssl/gists{/gist_id}","starred_url":"https://api.github.com/users/openssl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openssl/subscriptions","organizations_url":"https://api.github.com/users/openssl/orgs","repos_url":"https://api.github.com/users/openssl/repos","events_url":"https://api.github.com/users/openssl/events{/privacy}","received_events_url":"https://api.github.com/users/openssl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openssl/openssl","description":"TLS/SSL and crypto library","fork":false,"url":"https://api.github.com/repos/openssl/openssl","forks_url":"https://api.github.com/repos/openssl/openssl/forks","keys_url":"https://api.github.com/repos/openssl/openssl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openssl/openssl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openssl/openssl/teams","hooks_url":"https://api.github.com/repos/openssl/openssl/hooks","issue_events_url":"https://api.github.com/repos/openssl/openssl/issues/events{/number}","events_url":"https://api.github.com/repos/openssl/openssl/events","assignees_url":"https://api.github.com/repos/openssl/openssl/assignees{/user}","branches_url":"https://api.github.com/repos/openssl/openssl/branches{/branch}","tags_url":"https://api.github.com/repos/openssl/openssl/tags","blobs_url":"https://api.github.com/repos/openssl/openssl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openssl/openssl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openssl/openssl/git/refs{/sha}","trees_url":"https://api.github.com/repos/openssl/openssl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openssl/openssl/statuses/{sha}","languages_url":"https://api.github.com/repos/openssl/openssl/languages","stargazers_url":"https://api.github.com/repos/openssl/openssl/stargazers","contributors_url":"https://api.github.com/repos/openssl/openssl/contributors","subscribers_url":"https://api.github.com/repos/openssl/openssl/subscribers","subscription_url":"https://api.github.com/repos/openssl/openssl/subscription","commits_url":"https://api.github.com/repos/openssl/openssl/commits{/sha}","git_commits_url":"https://api.github.com/repos/openssl/openssl/git/commits{/sha}","comments_url":"https://api.github.com/repos/openssl/openssl/comments{/number}","issue_comment_url":"https://api.github.com/repos/openssl/openssl/issues/comments{/number}","contents_url":"https://api.github.com/repos/openssl/openssl/contents/{+path}","compare_url":"https://api.github.com/repos/openssl/openssl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openssl/openssl/merges","archive_url":"https://api.github.com/repos/openssl/openssl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openssl/openssl/downloads","issues_url":"https://api.github.com/repos/openssl/openssl/issues{/number}","pulls_url":"https://api.github.com/repos/openssl/openssl/pulls{/number}","milestones_url":"https://api.github.com/repos/openssl/openssl/milestones{/number}","notifications_url":"https://api.github.com/repos/openssl/openssl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openssl/openssl/labels{/name}","releases_url":"https://api.github.com/repos/openssl/openssl/releases{/id}","deployments_url":"https://api.github.com/repos/openssl/openssl/deployments","created_at":"2013-01-15T22:34:48Z","updated_at":"2016-03-08T13:15:55Z","pushed_at":"2016-03-08T13:23:22Z","git_url":"git://github.com/openssl/openssl.git","ssh_url":"git@github.com:openssl/openssl.git","clone_url":"https://github.com/openssl/openssl.git","svn_url":"https://github.com/openssl/openssl","homepage":"https://www.openssl.org","size":91588,"stargazers_count":2246,"watchers_count":2246,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1298,"mirror_url":null,"open_issues_count":143,"forks":1298,"open_issues":143,"watchers":2246,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openssl/openssl/pulls/772"},"html":{"href":"https://github.com/openssl/openssl/pull/772"},"issue":{"href":"https://api.github.com/repos/openssl/openssl/issues/772"},"comments":{"href":"https://api.github.com/repos/openssl/openssl/issues/772/comments"},"review_comments":{"href":"https://api.github.com/repos/openssl/openssl/pulls/772/comments"},"review_comment":{"href":"https://api.github.com/repos/openssl/openssl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openssl/openssl/pulls/772/commits"},"statuses":{"href":"https://api.github.com/repos/openssl/openssl/statuses/83d8f1d1782bb8ed4797ac36c7542aa272f0b23c"}}}}