{"action":"closed","number":1647,"pull_request":{"url":"https://api.github.com/repos/coreos/fleet/pulls/1647","id":78468224,"html_url":"https://github.com/coreos/fleet/pull/1647","diff_url":"https://github.com/coreos/fleet/pull/1647.diff","patch_url":"https://github.com/coreos/fleet/pull/1647.patch","issue_url":"https://api.github.com/repos/coreos/fleet/issues/1647","number":1647,"state":"closed","locked":false,"title":"agent,unit: check errors from start/stop/unload-ing unit","user":{"login":"dongsupark","id":10096906,"avatar_url":"https://avatars.githubusercontent.com/u/10096906?v=3","gravatar_id":"","url":"https://api.github.com/users/dongsupark","html_url":"https://github.com/dongsupark","followers_url":"https://api.github.com/users/dongsupark/followers","following_url":"https://api.github.com/users/dongsupark/following{/other_user}","gists_url":"https://api.github.com/users/dongsupark/gists{/gist_id}","starred_url":"https://api.github.com/users/dongsupark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dongsupark/subscriptions","organizations_url":"https://api.github.com/users/dongsupark/orgs","repos_url":"https://api.github.com/users/dongsupark/repos","events_url":"https://api.github.com/users/dongsupark/events{/privacy}","received_events_url":"https://api.github.com/users/dongsupark/received_events","type":"User","site_admin":false},"body":"Now that UnitManager.{TriggerStart,TriggerStop,Unload}() could return an error, the error should be delivered up to ``mapTaskToFunc()``, not to be ignored by the task manager. Doing that, we can fix a bug in fleet ignoring failed attempt to start/stop a unit.\r\n\r\nFixes https://github.com/coreos/fleet/issues/998","created_at":"2016-07-22T12:19:14Z","updated_at":"2016-07-28T13:50:37Z","closed_at":"2016-07-28T13:50:37Z","merged_at":"2016-07-28T13:50:37Z","merge_commit_sha":"a7bb40fa8028f8e891141b147bc574deda6aa8c0","assignee":{"login":"dongsupark","id":10096906,"avatar_url":"https://avatars.githubusercontent.com/u/10096906?v=3","gravatar_id":"","url":"https://api.github.com/users/dongsupark","html_url":"https://github.com/dongsupark","followers_url":"https://api.github.com/users/dongsupark/followers","following_url":"https://api.github.com/users/dongsupark/following{/other_user}","gists_url":"https://api.github.com/users/dongsupark/gists{/gist_id}","starred_url":"https://api.github.com/users/dongsupark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dongsupark/subscriptions","organizations_url":"https://api.github.com/users/dongsupark/orgs","repos_url":"https://api.github.com/users/dongsupark/repos","events_url":"https://api.github.com/users/dongsupark/events{/privacy}","received_events_url":"https://api.github.com/users/dongsupark/received_events","type":"User","site_admin":false},"assignees":[{"login":"dongsupark","id":10096906,"avatar_url":"https://avatars.githubusercontent.com/u/10096906?v=3","gravatar_id":"","url":"https://api.github.com/users/dongsupark","html_url":"https://github.com/dongsupark","followers_url":"https://api.github.com/users/dongsupark/followers","following_url":"https://api.github.com/users/dongsupark/following{/other_user}","gists_url":"https://api.github.com/users/dongsupark/gists{/gist_id}","starred_url":"https://api.github.com/users/dongsupark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dongsupark/subscriptions","organizations_url":"https://api.github.com/users/dongsupark/orgs","repos_url":"https://api.github.com/users/dongsupark/repos","events_url":"https://api.github.com/users/dongsupark/events{/privacy}","received_events_url":"https://api.github.com/users/dongsupark/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/coreos/fleet/pulls/1647/commits","review_comments_url":"https://api.github.com/repos/coreos/fleet/pulls/1647/comments","review_comment_url":"https://api.github.com/repos/coreos/fleet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coreos/fleet/issues/1647/comments","statuses_url":"https://api.github.com/repos/coreos/fleet/statuses/0829c3386439a239337090932ae9d382ed70cc1d","head":{"label":"endocode:dongsu/fleetd-errcheck-startstop-task","ref":"dongsu/fleetd-errcheck-startstop-task","sha":"0829c3386439a239337090932ae9d382ed70cc1d","user":{"login":"endocode","id":4068543,"avatar_url":"https://avatars.githubusercontent.com/u/4068543?v=3","gravatar_id":"","url":"https://api.github.com/users/endocode","html_url":"https://github.com/endocode","followers_url":"https://api.github.com/users/endocode/followers","following_url":"https://api.github.com/users/endocode/following{/other_user}","gists_url":"https://api.github.com/users/endocode/gists{/gist_id}","starred_url":"https://api.github.com/users/endocode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endocode/subscriptions","organizations_url":"https://api.github.com/users/endocode/orgs","repos_url":"https://api.github.com/users/endocode/repos","events_url":"https://api.github.com/users/endocode/events{/privacy}","received_events_url":"https://api.github.com/users/endocode/received_events","type":"Organization","site_admin":false},"repo":{"id":34001513,"name":"fleet","full_name":"endocode/fleet","owner":{"login":"endocode","id":4068543,"avatar_url":"https://avatars.githubusercontent.com/u/4068543?v=3","gravatar_id":"","url":"https://api.github.com/users/endocode","html_url":"https://github.com/endocode","followers_url":"https://api.github.com/users/endocode/followers","following_url":"https://api.github.com/users/endocode/following{/other_user}","gists_url":"https://api.github.com/users/endocode/gists{/gist_id}","starred_url":"https://api.github.com/users/endocode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endocode/subscriptions","organizations_url":"https://api.github.com/users/endocode/orgs","repos_url":"https://api.github.com/users/endocode/repos","events_url":"https://api.github.com/users/endocode/events{/privacy}","received_events_url":"https://api.github.com/users/endocode/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/endocode/fleet","description":"A Distributed init System","fork":true,"url":"https://api.github.com/repos/endocode/fleet","forks_url":"https://api.github.com/repos/endocode/fleet/forks","keys_url":"https://api.github.com/repos/endocode/fleet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/endocode/fleet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/endocode/fleet/teams","hooks_url":"https://api.github.com/repos/endocode/fleet/hooks","issue_events_url":"https://api.github.com/repos/endocode/fleet/issues/events{/number}","events_url":"https://api.github.com/repos/endocode/fleet/events","assignees_url":"https://api.github.com/repos/endocode/fleet/assignees{/user}","branches_url":"https://api.github.com/repos/endocode/fleet/branches{/branch}","tags_url":"https://api.github.com/repos/endocode/fleet/tags","blobs_url":"https://api.github.com/repos/endocode/fleet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/endocode/fleet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/endocode/fleet/git/refs{/sha}","trees_url":"https://api.github.com/repos/endocode/fleet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/endocode/fleet/statuses/{sha}","languages_url":"https://api.github.com/repos/endocode/fleet/languages","stargazers_url":"https://api.github.com/repos/endocode/fleet/stargazers","contributors_url":"https://api.github.com/repos/endocode/fleet/contributors","subscribers_url":"https://api.github.com/repos/endocode/fleet/subscribers","subscription_url":"https://api.github.com/repos/endocode/fleet/subscription","commits_url":"https://api.github.com/repos/endocode/fleet/commits{/sha}","git_commits_url":"https://api.github.com/repos/endocode/fleet/git/commits{/sha}","comments_url":"https://api.github.com/repos/endocode/fleet/comments{/number}","issue_comment_url":"https://api.github.com/repos/endocode/fleet/issues/comments{/number}","contents_url":"https://api.github.com/repos/endocode/fleet/contents/{+path}","compare_url":"https://api.github.com/repos/endocode/fleet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/endocode/fleet/merges","archive_url":"https://api.github.com/repos/endocode/fleet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/endocode/fleet/downloads","issues_url":"https://api.github.com/repos/endocode/fleet/issues{/number}","pulls_url":"https://api.github.com/repos/endocode/fleet/pulls{/number}","milestones_url":"https://api.github.com/repos/endocode/fleet/milestones{/number}","notifications_url":"https://api.github.com/repos/endocode/fleet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/endocode/fleet/labels{/name}","releases_url":"https://api.github.com/repos/endocode/fleet/releases{/id}","deployments_url":"https://api.github.com/repos/endocode/fleet/deployments","created_at":"2015-04-15T15:16:33Z","updated_at":"2016-01-27T08:29:06Z","pushed_at":"2016-07-28T09:51:21Z","git_url":"git://github.com/endocode/fleet.git","ssh_url":"git@github.com:endocode/fleet.git","clone_url":"https://github.com/endocode/fleet.git","svn_url":"https://github.com/endocode/fleet","homepage":"","size":8735,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"coreos:master","ref":"master","sha":"f85e7c1a5b7f99ed07a85a19ecf487080a811264","user":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"repo":{"id":13512328,"name":"fleet","full_name":"coreos/fleet","owner":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coreos/fleet","description":"A Distributed init System","fork":false,"url":"https://api.github.com/repos/coreos/fleet","forks_url":"https://api.github.com/repos/coreos/fleet/forks","keys_url":"https://api.github.com/repos/coreos/fleet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coreos/fleet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coreos/fleet/teams","hooks_url":"https://api.github.com/repos/coreos/fleet/hooks","issue_events_url":"https://api.github.com/repos/coreos/fleet/issues/events{/number}","events_url":"https://api.github.com/repos/coreos/fleet/events","assignees_url":"https://api.github.com/repos/coreos/fleet/assignees{/user}","branches_url":"https://api.github.com/repos/coreos/fleet/branches{/branch}","tags_url":"https://api.github.com/repos/coreos/fleet/tags","blobs_url":"https://api.github.com/repos/coreos/fleet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coreos/fleet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coreos/fleet/git/refs{/sha}","trees_url":"https://api.github.com/repos/coreos/fleet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coreos/fleet/statuses/{sha}","languages_url":"https://api.github.com/repos/coreos/fleet/languages","stargazers_url":"https://api.github.com/repos/coreos/fleet/stargazers","contributors_url":"https://api.github.com/repos/coreos/fleet/contributors","subscribers_url":"https://api.github.com/repos/coreos/fleet/subscribers","subscription_url":"https://api.github.com/repos/coreos/fleet/subscription","commits_url":"https://api.github.com/repos/coreos/fleet/commits{/sha}","git_commits_url":"https://api.github.com/repos/coreos/fleet/git/commits{/sha}","comments_url":"https://api.github.com/repos/coreos/fleet/comments{/number}","issue_comment_url":"https://api.github.com/repos/coreos/fleet/issues/comments{/number}","contents_url":"https://api.github.com/repos/coreos/fleet/contents/{+path}","compare_url":"https://api.github.com/repos/coreos/fleet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coreos/fleet/merges","archive_url":"https://api.github.com/repos/coreos/fleet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coreos/fleet/downloads","issues_url":"https://api.github.com/repos/coreos/fleet/issues{/number}","pulls_url":"https://api.github.com/repos/coreos/fleet/pulls{/number}","milestones_url":"https://api.github.com/repos/coreos/fleet/milestones{/number}","notifications_url":"https://api.github.com/repos/coreos/fleet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coreos/fleet/labels{/name}","releases_url":"https://api.github.com/repos/coreos/fleet/releases{/id}","deployments_url":"https://api.github.com/repos/coreos/fleet/deployments","created_at":"2013-10-11T23:56:38Z","updated_at":"2016-07-27T14:53:43Z","pushed_at":"2016-07-28T13:50:38Z","git_url":"git://github.com/coreos/fleet.git","ssh_url":"git@github.com:coreos/fleet.git","clone_url":"https://github.com/coreos/fleet.git","svn_url":"https://github.com/coreos/fleet","homepage":"","size":10359,"stargazers_count":2249,"watchers_count":2249,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":279,"mirror_url":null,"open_issues_count":125,"forks":279,"open_issues":125,"watchers":2249,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coreos/fleet/pulls/1647"},"html":{"href":"https://github.com/coreos/fleet/pull/1647"},"issue":{"href":"https://api.github.com/repos/coreos/fleet/issues/1647"},"comments":{"href":"https://api.github.com/repos/coreos/fleet/issues/1647/comments"},"review_comments":{"href":"https://api.github.com/repos/coreos/fleet/pulls/1647/comments"},"review_comment":{"href":"https://api.github.com/repos/coreos/fleet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coreos/fleet/pulls/1647/commits"},"statuses":{"href":"https://api.github.com/repos/coreos/fleet/statuses/0829c3386439a239337090932ae9d382ed70cc1d"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"dongsupark","id":10096906,"avatar_url":"https://avatars.githubusercontent.com/u/10096906?v=3","gravatar_id":"","url":"https://api.github.com/users/dongsupark","html_url":"https://github.com/dongsupark","followers_url":"https://api.github.com/users/dongsupark/followers","following_url":"https://api.github.com/users/dongsupark/following{/other_user}","gists_url":"https://api.github.com/users/dongsupark/gists{/gist_id}","starred_url":"https://api.github.com/users/dongsupark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dongsupark/subscriptions","organizations_url":"https://api.github.com/users/dongsupark/orgs","repos_url":"https://api.github.com/users/dongsupark/repos","events_url":"https://api.github.com/users/dongsupark/events{/privacy}","received_events_url":"https://api.github.com/users/dongsupark/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":2,"additions":53,"deletions":20,"changed_files":7}}
{"actor":{"display_login":"dongsupark"}}