{"action":"opened","issue":{"url":"https://api.github.com/repos/01org/TPM2.0-TSS/issues/219","repository_url":"https://api.github.com/repos/01org/TPM2.0-TSS","labels_url":"https://api.github.com/repos/01org/TPM2.0-TSS/issues/219/labels{/name}","comments_url":"https://api.github.com/repos/01org/TPM2.0-TSS/issues/219/comments","events_url":"https://api.github.com/repos/01org/TPM2.0-TSS/issues/219/events","html_url":"https://github.com/01org/TPM2.0-TSS/issues/219","id":157115848,"number":219,"title":"customize environment using CONFIG_SITE instead of Makefile.am","user":{"login":"flihp","id":1550813,"avatar_url":"https://avatars.githubusercontent.com/u/1550813?v=3","gravatar_id":"","url":"https://api.github.com/users/flihp","html_url":"https://github.com/flihp","followers_url":"https://api.github.com/users/flihp/followers","following_url":"https://api.github.com/users/flihp/following{/other_user}","gists_url":"https://api.github.com/users/flihp/gists{/gist_id}","starred_url":"https://api.github.com/users/flihp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flihp/subscriptions","organizations_url":"https://api.github.com/users/flihp/orgs","repos_url":"https://api.github.com/users/flihp/repos","events_url":"https://api.github.com/users/flihp/events{/privacy}","received_events_url":"https://api.github.com/users/flihp/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/01org/TPM2.0-TSS/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"open","locked":false,"assignee":{"login":"flihp","id":1550813,"avatar_url":"https://avatars.githubusercontent.com/u/1550813?v=3","gravatar_id":"","url":"https://api.github.com/users/flihp","html_url":"https://github.com/flihp","followers_url":"https://api.github.com/users/flihp/followers","following_url":"https://api.github.com/users/flihp/following{/other_user}","gists_url":"https://api.github.com/users/flihp/gists{/gist_id}","starred_url":"https://api.github.com/users/flihp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flihp/subscriptions","organizations_url":"https://api.github.com/users/flihp/orgs","repos_url":"https://api.github.com/users/flihp/repos","events_url":"https://api.github.com/users/flihp/events{/privacy}","received_events_url":"https://api.github.com/users/flihp/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/01org/TPM2.0-TSS/milestones/4","html_url":"https://github.com/01org/TPM2.0-TSS/milestones/packaging","labels_url":"https://api.github.com/repos/01org/TPM2.0-TSS/milestones/4/labels","id":1313603,"number":4,"title":"packaging","description":"A collection of tasks that need to be accomplished to aid package maintainers for various distros. This means getting things like headers and libraries installed in the right place when someone invokes 'make install'.","creator":{"login":"flihp","id":1550813,"avatar_url":"https://avatars.githubusercontent.com/u/1550813?v=3","gravatar_id":"","url":"https://api.github.com/users/flihp","html_url":"https://github.com/flihp","followers_url":"https://api.github.com/users/flihp/followers","following_url":"https://api.github.com/users/flihp/following{/other_user}","gists_url":"https://api.github.com/users/flihp/gists{/gist_id}","starred_url":"https://api.github.com/users/flihp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flihp/subscriptions","organizations_url":"https://api.github.com/users/flihp/orgs","repos_url":"https://api.github.com/users/flihp/repos","events_url":"https://api.github.com/users/flihp/events{/privacy}","received_events_url":"https://api.github.com/users/flihp/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":35,"state":"open","created_at":"2015-09-18T15:36:50Z","updated_at":"2016-05-27T02:09:50Z","due_on":null,"closed_at":null},"comments":0,"created_at":"2016-05-27T02:09:50Z","updated_at":"2016-05-27T02:09:50Z","closed_at":null,"body":"Was reading about the principle of least astonishment just now, realized that the expected behavior for autotools is for CFLAGS to default to something specific (-O2 -g I think). All other customization should be done through config.site.\r\n\r\nWe force ```-Wall, -Werror``` currently but this recently caused me issues building on 32bit system (#212 ). Being able to provide an environment through a file would have made my fix easier: instead of patching a build file I would have been able to set environment variable. So the enhancement I want here is to move our desired flags to a separate file (under lib/ maybe?) and to update the documentation with instructions to build using our reference values. We should probably also indicate that submitted patches must build under the provided environment."}}
{"actor":{"display_login":"flihp"}}