{"action":"created","issue":{"url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/issues/400","repository_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin","labels_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/issues/400/labels{/name}","comments_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/issues/400/comments","events_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/issues/400/events","html_url":"https://github.com/jenkinsci/blueocean-plugin/pull/400","id":170482314,"number":400,"title":"Feature/jenkins 36582 favorites realtime","user":{"login":"cliffmeyers","id":143466,"avatar_url":"https://avatars.githubusercontent.com/u/143466?v=3","gravatar_id":"","url":"https://api.github.com/users/cliffmeyers","html_url":"https://github.com/cliffmeyers","followers_url":"https://api.github.com/users/cliffmeyers/followers","following_url":"https://api.github.com/users/cliffmeyers/following{/other_user}","gists_url":"https://api.github.com/users/cliffmeyers/gists{/gist_id}","starred_url":"https://api.github.com/users/cliffmeyers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cliffmeyers/subscriptions","organizations_url":"https://api.github.com/users/cliffmeyers/orgs","repos_url":"https://api.github.com/users/cliffmeyers/repos","events_url":"https://api.github.com/users/cliffmeyers/events{/privacy}","received_events_url":"https://api.github.com/users/cliffmeyers/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/labels/needs-review","name":"needs-review","color":"eb6420"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-08-10T18:12:03Z","updated_at":"2016-08-15T13:43:33Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/pulls/400","html_url":"https://github.com/jenkinsci/blueocean-plugin/pull/400","diff_url":"https://github.com/jenkinsci/blueocean-plugin/pull/400.diff","patch_url":"https://github.com/jenkinsci/blueocean-plugin/pull/400.patch"},"body":"# Description\r\n- See [JENKINS-36582](https://issues.jenkins-ci.org/browse/JENKINS-36582).\r\n- Testing steps:\r\n - Add several favorites to the dashboard, ideally a simple Pipeline job, multi-branch Pipeline job, and a Freestyle job.\r\n - Using the classic UI, launch the jobs in those order. Note that the first two jobs should begin running while the Freestyle job is queued.\r\n - Jobs should update with the correct status as the builds complete.\r\n - Refreshing the page in the middle of runs should render jobs in correct status.\r\n - Navigating away and back should render jobs in correct status.\r\n\r\n# Submitter checklist\r\n- [x] Link to JIRA ticket in description, if appropriate.\r\n- [x] Change is code complete and matches issue description\r\n- [x] Appropriate unit or acceptance tests or explanation to why this change has no tests\r\n- [x] Reviewer's manual test instructions provided in PR description. See Reviewer's first task below.\r\n- [x] Ran Acceptance Test Harness against PR changes.\r\n\r\n# Reviewer checklist\r\n- [ ] Run the changes and verified the change matches the issue description\r\n- [x] Reviewed the code\r\n- [x] Verified that the appropriate tests have been written or valid explanation given\r\n\r\n@jenkinsci/code-reviewers @reviewbybees \r\n"},"comment":{"url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/issues/comments/239804803","html_url":"https://github.com/jenkinsci/blueocean-plugin/pull/400#issuecomment-239804803","issue_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/issues/400","id":239804803,"user":{"login":"cliffmeyers","id":143466,"avatar_url":"https://avatars.githubusercontent.com/u/143466?v=3","gravatar_id":"","url":"https://api.github.com/users/cliffmeyers","html_url":"https://github.com/cliffmeyers","followers_url":"https://api.github.com/users/cliffmeyers/followers","following_url":"https://api.github.com/users/cliffmeyers/following{/other_user}","gists_url":"https://api.github.com/users/cliffmeyers/gists{/gist_id}","starred_url":"https://api.github.com/users/cliffmeyers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cliffmeyers/subscriptions","organizations_url":"https://api.github.com/users/cliffmeyers/orgs","repos_url":"https://api.github.com/users/cliffmeyers/repos","events_url":"https://api.github.com/users/cliffmeyers/events{/privacy}","received_events_url":"https://api.github.com/users/cliffmeyers/received_events","type":"User","site_admin":false},"created_at":"2016-08-15T13:43:33Z","updated_at":"2016-08-15T13:43:33Z","body":"@michaelneale interesting, that URL was definitely malformed but wasn't producing an error in my local environment. Fixed in commit a407264.\r\n\r\nI just ran the ATH locally and all 100 assertions passed. From looking at the log it appears there was an error in the classic UI when creating the job and trying to build it?\r\n\r\n`\r\n2016-08-15 03:32:58,831 [Thread-3] INFO   (InputStreamHandler.java:47) com.github.eirslett.maven.plugins.frontend.lib.DefaultGulpRunner - Running:  \u001B[0;32mCreate frestyle Job \"hijo\"\u001B[0m\r\n2016-08-15 03:33:03,673 [Thread-3] INFO   (InputStreamHandler.java:47) com.github.eirslett.maven.plugins.frontend.lib.DefaultGulpRunner - Waiting on job \"hijo\" to be deleted.\r\n2016-08-15 03:33:03,701 [Thread-3] INFO   (InputStreamHandler.java:47) com.github.eirslett.maven.plugins.frontend.lib.DefaultGulpRunner - Job \"hijo\" deleted.\r\n2016-08-15 03:33:05,392 [Thread-3] INFO   (InputStreamHandler.java:47) com.github.eirslett.maven.plugins.frontend.lib.DefaultGulpRunner - Waiting on job \"hijo\" to be created.\r\n2016-08-15 03:33:25,402 [Thread-3] INFO   (InputStreamHandler.java:47) com.github.eirslett.maven.plugins.frontend.lib.DefaultGulpRunner - \u001B[0;31m ??? Error: Timed out waiting for job \"hijo\" to be created. Something must have failed earlier and the job creation did not succeed.\u001B[0m\r\n2016-08-15 03:33:25,403 [Thread-3] INFO   (InputStreamHandler.java:47) com.github.eirslett.maven.plugins.frontend.lib.DefaultGulpRunner - \u001B[0;90m    at null._onTimeout (/home/ubuntu/slave/workspace/Acceptance Tests Param/acceptance/src/main/js/custom_commands/waitForJobCreated.js:19:21)\r\n2016-08-15 03:33:25,404 [Thread-3] INFO   (InputStreamHandler.java:47) com.github.eirslett.maven.plugins.frontend.lib.DefaultGulpRunner -     at Timer.listOnTimeout (timers.js:92:15)\u001B[0m\r\n2016-08-15 03:33:25,418 [Thread-3] INFO   (InputStreamHandler.java:47) com.github.eirslett.maven.plugins.frontend.lib.DefaultGulpRunner - Disconnected from the Jenkins SSE Gateway.\r\n`"}}
{"actor":{"display_login":"cliffmeyers"}}