{"action":"created","comment":{"url":"https://api.github.com/repos/infinispan/infinispan/pulls/comments/66237307","id":66237307,"diff_hunk":"@@ -15,8 +15,8 @@\n @BuiltBy(MemcachedServerConfigurationBuilder.class)\n public class MemcachedServerConfiguration extends ProtocolServerConfiguration {\n \n-   MemcachedServerConfiguration(String defaultCacheName, String name, String host, int port, int idleTimeout, int recvBufSize, int sendBufSize, SslConfiguration ssl, boolean tcpNoDelay, int workerThreads, Set<String> ignoredCaches) {\n-      super(defaultCacheName, name, host, port, idleTimeout, recvBufSize, sendBufSize, ssl, tcpNoDelay, workerThreads, ignoredCaches);\n+   MemcachedServerConfiguration(String defaultCacheName, String name, String host, int port, int idleTimeout, int recvBufSize, int sendBufSize, SslConfiguration ssl, boolean tcpNoDelay, int workerThreads, Set<String> ignoredCaches, boolean startTransport) {","path":"server/memcached/src/main/scala/org/infinispan/server/memcached/configuration/MemcachedServerConfiguration.java","position":6,"original_position":6,"commit_id":"db3d33becbdccc88a8ba080a40c065e82db2812d","original_commit_id":"db3d33becbdccc88a8ba080a40c065e82db2812d","user":{"login":"slaskawi","id":8417158,"avatar_url":"https://avatars.githubusercontent.com/u/8417158?v=3","gravatar_id":"","url":"https://api.github.com/users/slaskawi","html_url":"https://github.com/slaskawi","followers_url":"https://api.github.com/users/slaskawi/followers","following_url":"https://api.github.com/users/slaskawi/following{/other_user}","gists_url":"https://api.github.com/users/slaskawi/gists{/gist_id}","starred_url":"https://api.github.com/users/slaskawi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slaskawi/subscriptions","organizations_url":"https://api.github.com/users/slaskawi/orgs","repos_url":"https://api.github.com/users/slaskawi/repos","events_url":"https://api.github.com/users/slaskawi/events{/privacy}","received_events_url":"https://api.github.com/users/slaskawi/received_events","type":"User","site_admin":false},"body":"Yes, but Memcached server still extends the `ProtocolServer` so we need to adjust the code.","created_at":"2016-06-08T11:19:32Z","updated_at":"2016-06-08T11:19:32Z","html_url":"https://github.com/infinispan/infinispan/pull/4348#discussion_r66237307","pull_request_url":"https://api.github.com/repos/infinispan/infinispan/pulls/4348","_links":{"self":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/comments/66237307"},"html":{"href":"https://github.com/infinispan/infinispan/pull/4348#discussion_r66237307"},"pull_request":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/4348"}}},"pull_request":{"url":"https://api.github.com/repos/infinispan/infinispan/pulls/4348","id":70192049,"html_url":"https://github.com/infinispan/infinispan/pull/4348","diff_url":"https://github.com/infinispan/infinispan/pull/4348.diff","patch_url":"https://github.com/infinispan/infinispan/pull/4348.patch","issue_url":"https://api.github.com/repos/infinispan/infinispan/issues/4348","number":4348,"state":"open","locked":false,"title":"ISPN-6635 Multi tenancy","user":{"login":"slaskawi","id":8417158,"avatar_url":"https://avatars.githubusercontent.com/u/8417158?v=3","gravatar_id":"","url":"https://api.github.com/users/slaskawi","html_url":"https://github.com/slaskawi","followers_url":"https://api.github.com/users/slaskawi/followers","following_url":"https://api.github.com/users/slaskawi/following{/other_user}","gists_url":"https://api.github.com/users/slaskawi/gists{/gist_id}","starred_url":"https://api.github.com/users/slaskawi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slaskawi/subscriptions","organizations_url":"https://api.github.com/users/slaskawi/orgs","repos_url":"https://api.github.com/users/slaskawi/repos","events_url":"https://api.github.com/users/slaskawi/events{/privacy}","received_events_url":"https://api.github.com/users/slaskawi/received_events","type":"User","site_admin":false},"body":"Umbrella JIRA: https://issues.jboss.org/browse/ISPN-6635\r\nDesign: https://github.com/infinispan/infinispan/wiki/Multi-tenancy-for-Hotrod-Server\r\nConfiguration used for testing: https://gist.github.com/slaskawi/99975cc9281cf590d988db1e5d2f015e\r\n\r\nImplemented subtasks:\r\n* https://issues.jboss.org/browse/ISPN-6636\r\n* https://issues.jboss.org/browse/ISPN-6637\r\n* https://issues.jboss.org/browse/ISPN-6638\r\n\r\nStill to be done:\r\n* REST based routing https://issues.jboss.org/browse/ISPN-6707\r\n* `server/integration/testsuite` test https://issues.jboss.org/browse/ISPN-6639\r\n* Consider implementing a custom protocol https://issues.jboss.org/browse/ISPN-6640\r\n* Add tuning options https://issues.jboss.org/browse/ISPN-6708\r\n\r\n[Local JMH performance results](https://gist.github.com/slaskawi/51f76b0658b9ee0c9351bd17224b1ba2):\r\n* Initializing connection (SSL/TLS+SNI) is ~`1 ms` slower than pure Hotrod SSL/TLS on my laptop with loopback\r\n* With 10k puts we are `200 ms` slower with multi tenant router (probably it will be better with fine tuning options, epoll etc.)\r\n```\r\nBenchmark                                                                                                     (configurationClassName)  Mode  Cnt     Score    Error  Units\r\nRouterPerf.BenchmarkState.initConnectionAndPerform10KPuts     org.infinispan.server.router.performance.configuration.SingleServerNoSsl  avgt   31   435.645 ± 41.073  ms/op\r\nRouterPerf.BenchmarkState.initConnectionAndPerform10KPuts   org.infinispan.server.router.performance.configuration.SingleServerWithSsl  avgt   31   846.246 ± 21.594  ms/op\r\nRouterPerf.BenchmarkState.initConnectionAndPerform10KPuts  org.infinispan.server.router.performance.configuration.TwoServersWithSslSni  avgt   31  1000.370 ± 22.342  ms/op\r\nRouterPerf.BenchmarkState.initConnectionAndPerform10Puts      org.infinispan.server.router.performance.configuration.SingleServerNoSsl  avgt   31     3.197 ±  0.112  ms/op\r\nRouterPerf.BenchmarkState.initConnectionAndPerform10Puts    org.infinispan.server.router.performance.configuration.SingleServerWithSsl  avgt   31    13.974 ±  0.512  ms/op\r\nRouterPerf.BenchmarkState.initConnectionAndPerform10Puts   org.infinispan.server.router.performance.configuration.TwoServersWithSslSni  avgt   31    14.871 ±  0.552  ms/op\r\nRouterPerf.BenchmarkState.initConnectionOnly                  org.infinispan.server.router.performance.configuration.SingleServerNoSsl  avgt   31     3.046 ±  0.096  ms/op\r\nRouterPerf.BenchmarkState.initConnectionOnly                org.infinispan.server.router.performance.configuration.SingleServerWithSsl  avgt   31    12.725 ±  0.379  ms/op\r\nRouterPerf.BenchmarkState.initConnectionOnly               org.infinispan.server.router.performance.configuration.TwoServersWithSslSni  avgt   31    13.471 ±  0.449  ms/op\r\nRouterPerf.BenchmarkState.perform10KPuts                      org.infinispan.server.router.performance.configuration.SingleServerNoSsl  avgt   31   430.075 ± 18.088  ms/op\r\nRouterPerf.BenchmarkState.perform10KPuts                    org.infinispan.server.router.performance.configuration.SingleServerWithSsl  avgt   31   847.909 ± 34.479  ms/op\r\nRouterPerf.BenchmarkState.perform10KPuts                   org.infinispan.server.router.performance.configuration.TwoServersWithSslSni  avgt   31  1022.655 ± 32.316  ms/op\r\n```\r\n","created_at":"2016-05-16T12:52:03Z","updated_at":"2016-06-08T11:19:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4674c9cb13b4bcd76c71058bbf2d394932a48e9c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/infinispan/infinispan/pulls/4348/commits","review_comments_url":"https://api.github.com/repos/infinispan/infinispan/pulls/4348/comments","review_comment_url":"https://api.github.com/repos/infinispan/infinispan/pulls/comments{/number}","comments_url":"https://api.github.com/repos/infinispan/infinispan/issues/4348/comments","statuses_url":"https://api.github.com/repos/infinispan/infinispan/statuses/db3d33becbdccc88a8ba080a40c065e82db2812d","head":{"label":"slaskawi:ISPN-6635-Multi-tenancy","ref":"ISPN-6635-Multi-tenancy","sha":"db3d33becbdccc88a8ba080a40c065e82db2812d","user":{"login":"slaskawi","id":8417158,"avatar_url":"https://avatars.githubusercontent.com/u/8417158?v=3","gravatar_id":"","url":"https://api.github.com/users/slaskawi","html_url":"https://github.com/slaskawi","followers_url":"https://api.github.com/users/slaskawi/followers","following_url":"https://api.github.com/users/slaskawi/following{/other_user}","gists_url":"https://api.github.com/users/slaskawi/gists{/gist_id}","starred_url":"https://api.github.com/users/slaskawi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slaskawi/subscriptions","organizations_url":"https://api.github.com/users/slaskawi/orgs","repos_url":"https://api.github.com/users/slaskawi/repos","events_url":"https://api.github.com/users/slaskawi/events{/privacy}","received_events_url":"https://api.github.com/users/slaskawi/received_events","type":"User","site_admin":false},"repo":{"id":23697744,"name":"infinispan","full_name":"slaskawi/infinispan","owner":{"login":"slaskawi","id":8417158,"avatar_url":"https://avatars.githubusercontent.com/u/8417158?v=3","gravatar_id":"","url":"https://api.github.com/users/slaskawi","html_url":"https://github.com/slaskawi","followers_url":"https://api.github.com/users/slaskawi/followers","following_url":"https://api.github.com/users/slaskawi/following{/other_user}","gists_url":"https://api.github.com/users/slaskawi/gists{/gist_id}","starred_url":"https://api.github.com/users/slaskawi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slaskawi/subscriptions","organizations_url":"https://api.github.com/users/slaskawi/orgs","repos_url":"https://api.github.com/users/slaskawi/repos","events_url":"https://api.github.com/users/slaskawi/events{/privacy}","received_events_url":"https://api.github.com/users/slaskawi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/slaskawi/infinispan","description":"Infinispan is an open source data grid platform and highly scalable NoSQL cloud data store.","fork":true,"url":"https://api.github.com/repos/slaskawi/infinispan","forks_url":"https://api.github.com/repos/slaskawi/infinispan/forks","keys_url":"https://api.github.com/repos/slaskawi/infinispan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/slaskawi/infinispan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/slaskawi/infinispan/teams","hooks_url":"https://api.github.com/repos/slaskawi/infinispan/hooks","issue_events_url":"https://api.github.com/repos/slaskawi/infinispan/issues/events{/number}","events_url":"https://api.github.com/repos/slaskawi/infinispan/events","assignees_url":"https://api.github.com/repos/slaskawi/infinispan/assignees{/user}","branches_url":"https://api.github.com/repos/slaskawi/infinispan/branches{/branch}","tags_url":"https://api.github.com/repos/slaskawi/infinispan/tags","blobs_url":"https://api.github.com/repos/slaskawi/infinispan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/slaskawi/infinispan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/slaskawi/infinispan/git/refs{/sha}","trees_url":"https://api.github.com/repos/slaskawi/infinispan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/slaskawi/infinispan/statuses/{sha}","languages_url":"https://api.github.com/repos/slaskawi/infinispan/languages","stargazers_url":"https://api.github.com/repos/slaskawi/infinispan/stargazers","contributors_url":"https://api.github.com/repos/slaskawi/infinispan/contributors","subscribers_url":"https://api.github.com/repos/slaskawi/infinispan/subscribers","subscription_url":"https://api.github.com/repos/slaskawi/infinispan/subscription","commits_url":"https://api.github.com/repos/slaskawi/infinispan/commits{/sha}","git_commits_url":"https://api.github.com/repos/slaskawi/infinispan/git/commits{/sha}","comments_url":"https://api.github.com/repos/slaskawi/infinispan/comments{/number}","issue_comment_url":"https://api.github.com/repos/slaskawi/infinispan/issues/comments{/number}","contents_url":"https://api.github.com/repos/slaskawi/infinispan/contents/{+path}","compare_url":"https://api.github.com/repos/slaskawi/infinispan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/slaskawi/infinispan/merges","archive_url":"https://api.github.com/repos/slaskawi/infinispan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/slaskawi/infinispan/downloads","issues_url":"https://api.github.com/repos/slaskawi/infinispan/issues{/number}","pulls_url":"https://api.github.com/repos/slaskawi/infinispan/pulls{/number}","milestones_url":"https://api.github.com/repos/slaskawi/infinispan/milestones{/number}","notifications_url":"https://api.github.com/repos/slaskawi/infinispan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/slaskawi/infinispan/labels{/name}","releases_url":"https://api.github.com/repos/slaskawi/infinispan/releases{/id}","deployments_url":"https://api.github.com/repos/slaskawi/infinispan/deployments","created_at":"2014-09-05T09:35:13Z","updated_at":"2015-01-22T12:12:41Z","pushed_at":"2016-05-27T07:17:23Z","git_url":"git://github.com/slaskawi/infinispan.git","ssh_url":"git@github.com:slaskawi/infinispan.git","clone_url":"https://github.com/slaskawi/infinispan.git","svn_url":"https://github.com/slaskawi/infinispan","homepage":"http://www.infinispan.org","size":81253,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"infinispan:master","ref":"master","sha":"6022ed9efcda35247768bc8e45e189bd2c3c3d22","user":{"login":"infinispan","id":458093,"avatar_url":"https://avatars.githubusercontent.com/u/458093?v=3","gravatar_id":"","url":"https://api.github.com/users/infinispan","html_url":"https://github.com/infinispan","followers_url":"https://api.github.com/users/infinispan/followers","following_url":"https://api.github.com/users/infinispan/following{/other_user}","gists_url":"https://api.github.com/users/infinispan/gists{/gist_id}","starred_url":"https://api.github.com/users/infinispan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infinispan/subscriptions","organizations_url":"https://api.github.com/users/infinispan/orgs","repos_url":"https://api.github.com/users/infinispan/repos","events_url":"https://api.github.com/users/infinispan/events{/privacy}","received_events_url":"https://api.github.com/users/infinispan/received_events","type":"Organization","site_admin":false},"repo":{"id":1050944,"name":"infinispan","full_name":"infinispan/infinispan","owner":{"login":"infinispan","id":458093,"avatar_url":"https://avatars.githubusercontent.com/u/458093?v=3","gravatar_id":"","url":"https://api.github.com/users/infinispan","html_url":"https://github.com/infinispan","followers_url":"https://api.github.com/users/infinispan/followers","following_url":"https://api.github.com/users/infinispan/following{/other_user}","gists_url":"https://api.github.com/users/infinispan/gists{/gist_id}","starred_url":"https://api.github.com/users/infinispan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infinispan/subscriptions","organizations_url":"https://api.github.com/users/infinispan/orgs","repos_url":"https://api.github.com/users/infinispan/repos","events_url":"https://api.github.com/users/infinispan/events{/privacy}","received_events_url":"https://api.github.com/users/infinispan/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/infinispan/infinispan","description":"Infinispan is an open source data grid platform and highly scalable NoSQL cloud data store.","fork":false,"url":"https://api.github.com/repos/infinispan/infinispan","forks_url":"https://api.github.com/repos/infinispan/infinispan/forks","keys_url":"https://api.github.com/repos/infinispan/infinispan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/infinispan/infinispan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/infinispan/infinispan/teams","hooks_url":"https://api.github.com/repos/infinispan/infinispan/hooks","issue_events_url":"https://api.github.com/repos/infinispan/infinispan/issues/events{/number}","events_url":"https://api.github.com/repos/infinispan/infinispan/events","assignees_url":"https://api.github.com/repos/infinispan/infinispan/assignees{/user}","branches_url":"https://api.github.com/repos/infinispan/infinispan/branches{/branch}","tags_url":"https://api.github.com/repos/infinispan/infinispan/tags","blobs_url":"https://api.github.com/repos/infinispan/infinispan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/infinispan/infinispan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/infinispan/infinispan/git/refs{/sha}","trees_url":"https://api.github.com/repos/infinispan/infinispan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/infinispan/infinispan/statuses/{sha}","languages_url":"https://api.github.com/repos/infinispan/infinispan/languages","stargazers_url":"https://api.github.com/repos/infinispan/infinispan/stargazers","contributors_url":"https://api.github.com/repos/infinispan/infinispan/contributors","subscribers_url":"https://api.github.com/repos/infinispan/infinispan/subscribers","subscription_url":"https://api.github.com/repos/infinispan/infinispan/subscription","commits_url":"https://api.github.com/repos/infinispan/infinispan/commits{/sha}","git_commits_url":"https://api.github.com/repos/infinispan/infinispan/git/commits{/sha}","comments_url":"https://api.github.com/repos/infinispan/infinispan/comments{/number}","issue_comment_url":"https://api.github.com/repos/infinispan/infinispan/issues/comments{/number}","contents_url":"https://api.github.com/repos/infinispan/infinispan/contents/{+path}","compare_url":"https://api.github.com/repos/infinispan/infinispan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/infinispan/infinispan/merges","archive_url":"https://api.github.com/repos/infinispan/infinispan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/infinispan/infinispan/downloads","issues_url":"https://api.github.com/repos/infinispan/infinispan/issues{/number}","pulls_url":"https://api.github.com/repos/infinispan/infinispan/pulls{/number}","milestones_url":"https://api.github.com/repos/infinispan/infinispan/milestones{/number}","notifications_url":"https://api.github.com/repos/infinispan/infinispan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/infinispan/infinispan/labels{/name}","releases_url":"https://api.github.com/repos/infinispan/infinispan/releases{/id}","deployments_url":"https://api.github.com/repos/infinispan/infinispan/deployments","created_at":"2010-11-04T12:33:19Z","updated_at":"2016-06-05T04:15:50Z","pushed_at":"2016-06-07T21:03:15Z","git_url":"git://github.com/infinispan/infinispan.git","ssh_url":"git@github.com:infinispan/infinispan.git","clone_url":"https://github.com/infinispan/infinispan.git","svn_url":"https://github.com/infinispan/infinispan","homepage":"http://www.infinispan.org","size":96384,"stargazers_count":478,"watchers_count":478,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":350,"mirror_url":null,"open_issues_count":31,"forks":350,"open_issues":31,"watchers":478,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/4348"},"html":{"href":"https://github.com/infinispan/infinispan/pull/4348"},"issue":{"href":"https://api.github.com/repos/infinispan/infinispan/issues/4348"},"comments":{"href":"https://api.github.com/repos/infinispan/infinispan/issues/4348/comments"},"review_comments":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/4348/comments"},"review_comment":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/4348/commits"},"statuses":{"href":"https://api.github.com/repos/infinispan/infinispan/statuses/db3d33becbdccc88a8ba080a40c065e82db2812d"}}}}
{"actor":{"display_login":"slaskawi"}}