{"action":"created","comment":{"url":"https://api.github.com/repos/grpc/grpc-java/pulls/comments/78070093","id":78070093,"diff_hunk":"@@ -105,113 +115,133 @@ public void start(ClientStreamListener listener) {\n       public void operationComplete(ChannelFuture future) throws Exception {\n         if (!future.isSuccess()) {\n           // Stream creation failed. Close the stream if not already closed.\n-          Status s = statusFromFailedFuture(future);\n-          transportReportStatus(s, true, new Metadata());\n+          Status s = transportState().statusFromFailedFuture(future);\n+          transportState().transportReportStatus(s, true, new Metadata());\n         }\n       }\n     };\n \n     // Write the command requesting the creation of the stream.\n-    writeQueue.enqueue(new CreateStreamCommand(http2Headers, this),\n+    writeQueue.enqueue(new CreateStreamCommand(http2Headers, transportState()),\n         !method.getType().clientSendsOneMessage()).addListener(failureListener);\n   }\n \n-  @Override\n-  public void transportReportStatus(Status newStatus, boolean stopDelivery, Metadata trailers) {\n-    super.transportReportStatus(newStatus, stopDelivery, trailers);\n-  }\n+  private class Sink implements AbstractClientStream2.Sink {\n+    @Override\n+    public void writeFrame(WritableBuffer frame, boolean endOfStream, boolean flush) {\n+      ByteBuf bytebuf = frame == null ? EMPTY_BUFFER : ((NettyWritableBuffer) frame).bytebuf();","path":"netty/src/main/java/io/grpc/netty/NettyClientStream.java","position":100,"original_position":100,"commit_id":"5678da0cbb8900acbb9f8ccdd8a6d0f57e762920","original_commit_id":"5678da0cbb8900acbb9f8ccdd8a6d0f57e762920","user":{"login":"buchgr","id":1388179,"avatar_url":"https://avatars.githubusercontent.com/u/1388179?v=3","gravatar_id":"","url":"https://api.github.com/users/buchgr","html_url":"https://github.com/buchgr","followers_url":"https://api.github.com/users/buchgr/followers","following_url":"https://api.github.com/users/buchgr/following{/other_user}","gists_url":"https://api.github.com/users/buchgr/gists{/gist_id}","starred_url":"https://api.github.com/users/buchgr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buchgr/subscriptions","organizations_url":"https://api.github.com/users/buchgr/orgs","repos_url":"https://api.github.com/users/buchgr/repos","events_url":"https://api.github.com/users/buchgr/events{/privacy}","received_events_url":"https://api.github.com/users/buchgr/received_events","type":"User","site_admin":false},"body":"should we verify that `endStream` is `true`, when `frame` is `null`?","created_at":"2016-09-08T19:09:00Z","updated_at":"2016-09-08T19:09:00Z","html_url":"https://github.com/grpc/grpc-java/pull/2140#discussion_r78070093","pull_request_url":"https://api.github.com/repos/grpc/grpc-java/pulls/2140","_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc-java/pulls/comments/78070093"},"html":{"href":"https://github.com/grpc/grpc-java/pull/2140#discussion_r78070093"},"pull_request":{"href":"https://api.github.com/repos/grpc/grpc-java/pulls/2140"}}},"pull_request":{"url":"https://api.github.com/repos/grpc/grpc-java/pulls/2140","id":80466005,"html_url":"https://github.com/grpc/grpc-java/pull/2140","diff_url":"https://github.com/grpc/grpc-java/pull/2140.diff","patch_url":"https://github.com/grpc/grpc-java/pull/2140.patch","issue_url":"https://api.github.com/repos/grpc/grpc-java/issues/2140","number":2140,"state":"open","locked":false,"title":"core,netty: split stream state on client-side; AbstractStream2","user":{"login":"ejona86","id":2811396,"avatar_url":"https://avatars.githubusercontent.com/u/2811396?v=3","gravatar_id":"","url":"https://api.github.com/users/ejona86","html_url":"https://github.com/ejona86","followers_url":"https://api.github.com/users/ejona86/followers","following_url":"https://api.github.com/users/ejona86/following{/other_user}","gists_url":"https://api.github.com/users/ejona86/gists{/gist_id}","starred_url":"https://api.github.com/users/ejona86/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ejona86/subscriptions","organizations_url":"https://api.github.com/users/ejona86/orgs","repos_url":"https://api.github.com/users/ejona86/repos","events_url":"https://api.github.com/users/ejona86/events{/privacy}","received_events_url":"https://api.github.com/users/ejona86/received_events","type":"User","site_admin":false},"body":"OkHttp will need to be migrated in a future commit.\r\n\r\nThis is a continuation of what already was done for server-side (#1656). Although\r\nAbstractClientStream2 looks like new code, it is a reorganization of existing code\r\n(although heavily reworked).","created_at":"2016-08-08T14:59:53Z","updated_at":"2016-09-08T19:09:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"260f6a5cbe3c6d5e7a2c728dc0baa16391ee217f","assignee":{"login":"buchgr","id":1388179,"avatar_url":"https://avatars.githubusercontent.com/u/1388179?v=3","gravatar_id":"","url":"https://api.github.com/users/buchgr","html_url":"https://github.com/buchgr","followers_url":"https://api.github.com/users/buchgr/followers","following_url":"https://api.github.com/users/buchgr/following{/other_user}","gists_url":"https://api.github.com/users/buchgr/gists{/gist_id}","starred_url":"https://api.github.com/users/buchgr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buchgr/subscriptions","organizations_url":"https://api.github.com/users/buchgr/orgs","repos_url":"https://api.github.com/users/buchgr/repos","events_url":"https://api.github.com/users/buchgr/events{/privacy}","received_events_url":"https://api.github.com/users/buchgr/received_events","type":"User","site_admin":false},"assignees":[{"login":"buchgr","id":1388179,"avatar_url":"https://avatars.githubusercontent.com/u/1388179?v=3","gravatar_id":"","url":"https://api.github.com/users/buchgr","html_url":"https://github.com/buchgr","followers_url":"https://api.github.com/users/buchgr/followers","following_url":"https://api.github.com/users/buchgr/following{/other_user}","gists_url":"https://api.github.com/users/buchgr/gists{/gist_id}","starred_url":"https://api.github.com/users/buchgr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buchgr/subscriptions","organizations_url":"https://api.github.com/users/buchgr/orgs","repos_url":"https://api.github.com/users/buchgr/repos","events_url":"https://api.github.com/users/buchgr/events{/privacy}","received_events_url":"https://api.github.com/users/buchgr/received_events","type":"User","site_admin":false},{"login":"nmittler","id":6493296,"avatar_url":"https://avatars.githubusercontent.com/u/6493296?v=3","gravatar_id":"","url":"https://api.github.com/users/nmittler","html_url":"https://github.com/nmittler","followers_url":"https://api.github.com/users/nmittler/followers","following_url":"https://api.github.com/users/nmittler/following{/other_user}","gists_url":"https://api.github.com/users/nmittler/gists{/gist_id}","starred_url":"https://api.github.com/users/nmittler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmittler/subscriptions","organizations_url":"https://api.github.com/users/nmittler/orgs","repos_url":"https://api.github.com/users/nmittler/repos","events_url":"https://api.github.com/users/nmittler/events{/privacy}","received_events_url":"https://api.github.com/users/nmittler/received_events","type":"User","site_admin":false},{"login":"carl-mastrangelo","id":8943572,"avatar_url":"https://avatars.githubusercontent.com/u/8943572?v=3","gravatar_id":"","url":"https://api.github.com/users/carl-mastrangelo","html_url":"https://github.com/carl-mastrangelo","followers_url":"https://api.github.com/users/carl-mastrangelo/followers","following_url":"https://api.github.com/users/carl-mastrangelo/following{/other_user}","gists_url":"https://api.github.com/users/carl-mastrangelo/gists{/gist_id}","starred_url":"https://api.github.com/users/carl-mastrangelo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carl-mastrangelo/subscriptions","organizations_url":"https://api.github.com/users/carl-mastrangelo/orgs","repos_url":"https://api.github.com/users/carl-mastrangelo/repos","events_url":"https://api.github.com/users/carl-mastrangelo/events{/privacy}","received_events_url":"https://api.github.com/users/carl-mastrangelo/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/grpc/grpc-java/pulls/2140/commits","review_comments_url":"https://api.github.com/repos/grpc/grpc-java/pulls/2140/comments","review_comment_url":"https://api.github.com/repos/grpc/grpc-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/grpc/grpc-java/issues/2140/comments","statuses_url":"https://api.github.com/repos/grpc/grpc-java/statuses/5678da0cbb8900acbb9f8ccdd8a6d0f57e762920","head":{"label":"ejona86:split-abstractclientstream","ref":"split-abstractclientstream","sha":"5678da0cbb8900acbb9f8ccdd8a6d0f57e762920","user":{"login":"ejona86","id":2811396,"avatar_url":"https://avatars.githubusercontent.com/u/2811396?v=3","gravatar_id":"","url":"https://api.github.com/users/ejona86","html_url":"https://github.com/ejona86","followers_url":"https://api.github.com/users/ejona86/followers","following_url":"https://api.github.com/users/ejona86/following{/other_user}","gists_url":"https://api.github.com/users/ejona86/gists{/gist_id}","starred_url":"https://api.github.com/users/ejona86/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ejona86/subscriptions","organizations_url":"https://api.github.com/users/ejona86/orgs","repos_url":"https://api.github.com/users/ejona86/repos","events_url":"https://api.github.com/users/ejona86/events{/privacy}","received_events_url":"https://api.github.com/users/ejona86/received_events","type":"User","site_admin":false},"repo":{"id":31378968,"name":"grpc-java","full_name":"ejona86/grpc-java","owner":{"login":"ejona86","id":2811396,"avatar_url":"https://avatars.githubusercontent.com/u/2811396?v=3","gravatar_id":"","url":"https://api.github.com/users/ejona86","html_url":"https://github.com/ejona86","followers_url":"https://api.github.com/users/ejona86/followers","following_url":"https://api.github.com/users/ejona86/following{/other_user}","gists_url":"https://api.github.com/users/ejona86/gists{/gist_id}","starred_url":"https://api.github.com/users/ejona86/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ejona86/subscriptions","organizations_url":"https://api.github.com/users/ejona86/orgs","repos_url":"https://api.github.com/users/ejona86/repos","events_url":"https://api.github.com/users/ejona86/events{/privacy}","received_events_url":"https://api.github.com/users/ejona86/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ejona86/grpc-java","description":"The Java gRPC implementation. HTTP/2 based RPC","fork":true,"url":"https://api.github.com/repos/ejona86/grpc-java","forks_url":"https://api.github.com/repos/ejona86/grpc-java/forks","keys_url":"https://api.github.com/repos/ejona86/grpc-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ejona86/grpc-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ejona86/grpc-java/teams","hooks_url":"https://api.github.com/repos/ejona86/grpc-java/hooks","issue_events_url":"https://api.github.com/repos/ejona86/grpc-java/issues/events{/number}","events_url":"https://api.github.com/repos/ejona86/grpc-java/events","assignees_url":"https://api.github.com/repos/ejona86/grpc-java/assignees{/user}","branches_url":"https://api.github.com/repos/ejona86/grpc-java/branches{/branch}","tags_url":"https://api.github.com/repos/ejona86/grpc-java/tags","blobs_url":"https://api.github.com/repos/ejona86/grpc-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ejona86/grpc-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ejona86/grpc-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/ejona86/grpc-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ejona86/grpc-java/statuses/{sha}","languages_url":"https://api.github.com/repos/ejona86/grpc-java/languages","stargazers_url":"https://api.github.com/repos/ejona86/grpc-java/stargazers","contributors_url":"https://api.github.com/repos/ejona86/grpc-java/contributors","subscribers_url":"https://api.github.com/repos/ejona86/grpc-java/subscribers","subscription_url":"https://api.github.com/repos/ejona86/grpc-java/subscription","commits_url":"https://api.github.com/repos/ejona86/grpc-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/ejona86/grpc-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/ejona86/grpc-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/ejona86/grpc-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/ejona86/grpc-java/contents/{+path}","compare_url":"https://api.github.com/repos/ejona86/grpc-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ejona86/grpc-java/merges","archive_url":"https://api.github.com/repos/ejona86/grpc-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ejona86/grpc-java/downloads","issues_url":"https://api.github.com/repos/ejona86/grpc-java/issues{/number}","pulls_url":"https://api.github.com/repos/ejona86/grpc-java/pulls{/number}","milestones_url":"https://api.github.com/repos/ejona86/grpc-java/milestones{/number}","notifications_url":"https://api.github.com/repos/ejona86/grpc-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ejona86/grpc-java/labels{/name}","releases_url":"https://api.github.com/repos/ejona86/grpc-java/releases{/id}","deployments_url":"https://api.github.com/repos/ejona86/grpc-java/deployments","created_at":"2015-02-26T17:23:03Z","updated_at":"2016-01-12T00:09:03Z","pushed_at":"2016-09-08T18:07:33Z","git_url":"git://github.com/ejona86/grpc-java.git","ssh_url":"git@github.com:ejona86/grpc-java.git","clone_url":"https://github.com/ejona86/grpc-java.git","svn_url":"https://github.com/ejona86/grpc-java","homepage":"","size":8178,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"grpc:master","ref":"master","sha":"54f5c4ba89bed779522cf60da04fa65c65b4280b","user":{"login":"grpc","id":7802525,"avatar_url":"https://avatars.githubusercontent.com/u/7802525?v=3","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"repo":{"id":27729926,"name":"grpc-java","full_name":"grpc/grpc-java","owner":{"login":"grpc","id":7802525,"avatar_url":"https://avatars.githubusercontent.com/u/7802525?v=3","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/grpc/grpc-java","description":"The Java gRPC implementation. HTTP/2 based RPC","fork":false,"url":"https://api.github.com/repos/grpc/grpc-java","forks_url":"https://api.github.com/repos/grpc/grpc-java/forks","keys_url":"https://api.github.com/repos/grpc/grpc-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grpc/grpc-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grpc/grpc-java/teams","hooks_url":"https://api.github.com/repos/grpc/grpc-java/hooks","issue_events_url":"https://api.github.com/repos/grpc/grpc-java/issues/events{/number}","events_url":"https://api.github.com/repos/grpc/grpc-java/events","assignees_url":"https://api.github.com/repos/grpc/grpc-java/assignees{/user}","branches_url":"https://api.github.com/repos/grpc/grpc-java/branches{/branch}","tags_url":"https://api.github.com/repos/grpc/grpc-java/tags","blobs_url":"https://api.github.com/repos/grpc/grpc-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grpc/grpc-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grpc/grpc-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/grpc/grpc-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grpc/grpc-java/statuses/{sha}","languages_url":"https://api.github.com/repos/grpc/grpc-java/languages","stargazers_url":"https://api.github.com/repos/grpc/grpc-java/stargazers","contributors_url":"https://api.github.com/repos/grpc/grpc-java/contributors","subscribers_url":"https://api.github.com/repos/grpc/grpc-java/subscribers","subscription_url":"https://api.github.com/repos/grpc/grpc-java/subscription","commits_url":"https://api.github.com/repos/grpc/grpc-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/grpc/grpc-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/grpc/grpc-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/grpc/grpc-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/grpc/grpc-java/contents/{+path}","compare_url":"https://api.github.com/repos/grpc/grpc-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grpc/grpc-java/merges","archive_url":"https://api.github.com/repos/grpc/grpc-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grpc/grpc-java/downloads","issues_url":"https://api.github.com/repos/grpc/grpc-java/issues{/number}","pulls_url":"https://api.github.com/repos/grpc/grpc-java/pulls{/number}","milestones_url":"https://api.github.com/repos/grpc/grpc-java/milestones{/number}","notifications_url":"https://api.github.com/repos/grpc/grpc-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grpc/grpc-java/labels{/name}","releases_url":"https://api.github.com/repos/grpc/grpc-java/releases{/id}","deployments_url":"https://api.github.com/repos/grpc/grpc-java/deployments","created_at":"2014-12-08T19:00:00Z","updated_at":"2016-09-08T10:34:38Z","pushed_at":"2016-09-08T19:00:17Z","git_url":"git://github.com/grpc/grpc-java.git","ssh_url":"git@github.com:grpc/grpc-java.git","clone_url":"https://github.com/grpc/grpc-java.git","svn_url":"https://github.com/grpc/grpc-java","homepage":"http://grpc.io","size":27745,"stargazers_count":1948,"watchers_count":1948,"language":"Java","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":544,"mirror_url":null,"open_issues_count":235,"forks":544,"open_issues":235,"watchers":1948,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc-java/pulls/2140"},"html":{"href":"https://github.com/grpc/grpc-java/pull/2140"},"issue":{"href":"https://api.github.com/repos/grpc/grpc-java/issues/2140"},"comments":{"href":"https://api.github.com/repos/grpc/grpc-java/issues/2140/comments"},"review_comments":{"href":"https://api.github.com/repos/grpc/grpc-java/pulls/2140/comments"},"review_comment":{"href":"https://api.github.com/repos/grpc/grpc-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/grpc/grpc-java/pulls/2140/commits"},"statuses":{"href":"https://api.github.com/repos/grpc/grpc-java/statuses/5678da0cbb8900acbb9f8ccdd8a6d0f57e762920"}}}}
{"actor":{"display_login":"buchgr"}}