{"action":"created","comment":{"url":"https://api.github.com/repos/coreos/etcd/pulls/comments/79113785","id":79113785,"diff_hunk":"@@ -45,7 +48,8 @@ func NewMakeMirrorCommand() *cobra.Command {\n \t}\n \n \tc.Flags().StringVar(&mmprefix, \"prefix\", \"\", \"Key-value prefix to mirror\")\n-\t// TODO: add dest-prefix to mirror a prefix to a different prefix in the destination cluster?\n+\tc.Flags().StringVar(&mmdestprefix, \"dest-prefix\", \"\", \"destination prefix to mirror a prefix to a different prefix in the destination cluster\")\n+\tc.Flags().BoolVar(&mmremdestprefix, \"rem-dest-prefix\", false, \"remove the key-value prefix in the destination cluster\")","path":"etcdctl/ctlv3/command/make_mirror_command.go","position":33,"original_position":33,"commit_id":"bfa34163bb9444dc31ba89f4be93186769250d23","original_commit_id":"bfa34163bb9444dc31ba89f4be93186769250d23","user":{"login":"sinsharat","id":20169156,"avatar_url":"https://avatars.githubusercontent.com/u/20169156?v=3","gravatar_id":"","url":"https://api.github.com/users/sinsharat","html_url":"https://github.com/sinsharat","followers_url":"https://api.github.com/users/sinsharat/followers","following_url":"https://api.github.com/users/sinsharat/following{/other_user}","gists_url":"https://api.github.com/users/sinsharat/gists{/gist_id}","starred_url":"https://api.github.com/users/sinsharat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sinsharat/subscriptions","organizations_url":"https://api.github.com/users/sinsharat/orgs","repos_url":"https://api.github.com/users/sinsharat/repos","events_url":"https://api.github.com/users/sinsharat/events{/privacy}","received_events_url":"https://api.github.com/users/sinsharat/received_events","type":"User","site_admin":false},"body":"@xiang90 thank you for the feedback. Will do the changes.","created_at":"2016-09-16T06:44:29Z","updated_at":"2016-09-16T06:44:29Z","html_url":"https://github.com/coreos/etcd/pull/6439#discussion_r79113785","pull_request_url":"https://api.github.com/repos/coreos/etcd/pulls/6439","_links":{"self":{"href":"https://api.github.com/repos/coreos/etcd/pulls/comments/79113785"},"html":{"href":"https://github.com/coreos/etcd/pull/6439#discussion_r79113785"},"pull_request":{"href":"https://api.github.com/repos/coreos/etcd/pulls/6439"}}},"pull_request":{"url":"https://api.github.com/repos/coreos/etcd/pulls/6439","id":85405208,"html_url":"https://github.com/coreos/etcd/pull/6439","diff_url":"https://github.com/coreos/etcd/pull/6439.diff","patch_url":"https://github.com/coreos/etcd/pull/6439.patch","issue_url":"https://api.github.com/repos/coreos/etcd/issues/6439","number":6439,"state":"open","locked":false,"title":"etcdctl/ctlv3: make-mirror: feature add to modify/remove prefix in dest cluster","user":{"login":"sinsharat","id":20169156,"avatar_url":"https://avatars.githubusercontent.com/u/20169156?v=3","gravatar_id":"","url":"https://api.github.com/users/sinsharat","html_url":"https://github.com/sinsharat","followers_url":"https://api.github.com/users/sinsharat/followers","following_url":"https://api.github.com/users/sinsharat/following{/other_user}","gists_url":"https://api.github.com/users/sinsharat/gists{/gist_id}","starred_url":"https://api.github.com/users/sinsharat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sinsharat/subscriptions","organizations_url":"https://api.github.com/users/sinsharat/orgs","repos_url":"https://api.github.com/users/sinsharat/repos","events_url":"https://api.github.com/users/sinsharat/events{/privacy}","received_events_url":"https://api.github.com/users/sinsharat/received_events","type":"User","site_admin":false},"body":"implemented the below TODO:\r\n1. TODO: add dest-prefix to mirror a prefix to a different prefix in the destination cluster\r\n2. TODO: remove the prefix of the destination cluster\r\n","created_at":"2016-09-15T13:37:13Z","updated_at":"2016-09-16T06:44:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d314ba719e254a27a31cfe4274a464f22c668842","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/coreos/etcd/pulls/6439/commits","review_comments_url":"https://api.github.com/repos/coreos/etcd/pulls/6439/comments","review_comment_url":"https://api.github.com/repos/coreos/etcd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coreos/etcd/issues/6439/comments","statuses_url":"https://api.github.com/repos/coreos/etcd/statuses/bfa34163bb9444dc31ba89f4be93186769250d23","head":{"label":"sinsharat:make_mirror_feature_add","ref":"make_mirror_feature_add","sha":"bfa34163bb9444dc31ba89f4be93186769250d23","user":{"login":"sinsharat","id":20169156,"avatar_url":"https://avatars.githubusercontent.com/u/20169156?v=3","gravatar_id":"","url":"https://api.github.com/users/sinsharat","html_url":"https://github.com/sinsharat","followers_url":"https://api.github.com/users/sinsharat/followers","following_url":"https://api.github.com/users/sinsharat/following{/other_user}","gists_url":"https://api.github.com/users/sinsharat/gists{/gist_id}","starred_url":"https://api.github.com/users/sinsharat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sinsharat/subscriptions","organizations_url":"https://api.github.com/users/sinsharat/orgs","repos_url":"https://api.github.com/users/sinsharat/repos","events_url":"https://api.github.com/users/sinsharat/events{/privacy}","received_events_url":"https://api.github.com/users/sinsharat/received_events","type":"User","site_admin":false},"repo":{"id":67736780,"name":"etcd","full_name":"sinsharat/etcd","owner":{"login":"sinsharat","id":20169156,"avatar_url":"https://avatars.githubusercontent.com/u/20169156?v=3","gravatar_id":"","url":"https://api.github.com/users/sinsharat","html_url":"https://github.com/sinsharat","followers_url":"https://api.github.com/users/sinsharat/followers","following_url":"https://api.github.com/users/sinsharat/following{/other_user}","gists_url":"https://api.github.com/users/sinsharat/gists{/gist_id}","starred_url":"https://api.github.com/users/sinsharat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sinsharat/subscriptions","organizations_url":"https://api.github.com/users/sinsharat/orgs","repos_url":"https://api.github.com/users/sinsharat/repos","events_url":"https://api.github.com/users/sinsharat/events{/privacy}","received_events_url":"https://api.github.com/users/sinsharat/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sinsharat/etcd","description":"Distributed reliable key-value store for the most critical data of a distributed system","fork":true,"url":"https://api.github.com/repos/sinsharat/etcd","forks_url":"https://api.github.com/repos/sinsharat/etcd/forks","keys_url":"https://api.github.com/repos/sinsharat/etcd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sinsharat/etcd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sinsharat/etcd/teams","hooks_url":"https://api.github.com/repos/sinsharat/etcd/hooks","issue_events_url":"https://api.github.com/repos/sinsharat/etcd/issues/events{/number}","events_url":"https://api.github.com/repos/sinsharat/etcd/events","assignees_url":"https://api.github.com/repos/sinsharat/etcd/assignees{/user}","branches_url":"https://api.github.com/repos/sinsharat/etcd/branches{/branch}","tags_url":"https://api.github.com/repos/sinsharat/etcd/tags","blobs_url":"https://api.github.com/repos/sinsharat/etcd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sinsharat/etcd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sinsharat/etcd/git/refs{/sha}","trees_url":"https://api.github.com/repos/sinsharat/etcd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sinsharat/etcd/statuses/{sha}","languages_url":"https://api.github.com/repos/sinsharat/etcd/languages","stargazers_url":"https://api.github.com/repos/sinsharat/etcd/stargazers","contributors_url":"https://api.github.com/repos/sinsharat/etcd/contributors","subscribers_url":"https://api.github.com/repos/sinsharat/etcd/subscribers","subscription_url":"https://api.github.com/repos/sinsharat/etcd/subscription","commits_url":"https://api.github.com/repos/sinsharat/etcd/commits{/sha}","git_commits_url":"https://api.github.com/repos/sinsharat/etcd/git/commits{/sha}","comments_url":"https://api.github.com/repos/sinsharat/etcd/comments{/number}","issue_comment_url":"https://api.github.com/repos/sinsharat/etcd/issues/comments{/number}","contents_url":"https://api.github.com/repos/sinsharat/etcd/contents/{+path}","compare_url":"https://api.github.com/repos/sinsharat/etcd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sinsharat/etcd/merges","archive_url":"https://api.github.com/repos/sinsharat/etcd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sinsharat/etcd/downloads","issues_url":"https://api.github.com/repos/sinsharat/etcd/issues{/number}","pulls_url":"https://api.github.com/repos/sinsharat/etcd/pulls{/number}","milestones_url":"https://api.github.com/repos/sinsharat/etcd/milestones{/number}","notifications_url":"https://api.github.com/repos/sinsharat/etcd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sinsharat/etcd/labels{/name}","releases_url":"https://api.github.com/repos/sinsharat/etcd/releases{/id}","deployments_url":"https://api.github.com/repos/sinsharat/etcd/deployments","created_at":"2016-09-08T20:11:20Z","updated_at":"2016-09-08T20:11:24Z","pushed_at":"2016-09-15T13:34:40Z","git_url":"git://github.com/sinsharat/etcd.git","ssh_url":"git@github.com:sinsharat/etcd.git","clone_url":"https://github.com/sinsharat/etcd.git","svn_url":"https://github.com/sinsharat/etcd","homepage":"https://coreos.com/etcd/docs/latest/","size":23447,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"coreos:master","ref":"master","sha":"9913e0073c203a8749a0bfaa15747a8e9e9d32b1","user":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"repo":{"id":11225014,"name":"etcd","full_name":"coreos/etcd","owner":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coreos/etcd","description":"Distributed reliable key-value store for the most critical data of a distributed system","fork":false,"url":"https://api.github.com/repos/coreos/etcd","forks_url":"https://api.github.com/repos/coreos/etcd/forks","keys_url":"https://api.github.com/repos/coreos/etcd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coreos/etcd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coreos/etcd/teams","hooks_url":"https://api.github.com/repos/coreos/etcd/hooks","issue_events_url":"https://api.github.com/repos/coreos/etcd/issues/events{/number}","events_url":"https://api.github.com/repos/coreos/etcd/events","assignees_url":"https://api.github.com/repos/coreos/etcd/assignees{/user}","branches_url":"https://api.github.com/repos/coreos/etcd/branches{/branch}","tags_url":"https://api.github.com/repos/coreos/etcd/tags","blobs_url":"https://api.github.com/repos/coreos/etcd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coreos/etcd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coreos/etcd/git/refs{/sha}","trees_url":"https://api.github.com/repos/coreos/etcd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coreos/etcd/statuses/{sha}","languages_url":"https://api.github.com/repos/coreos/etcd/languages","stargazers_url":"https://api.github.com/repos/coreos/etcd/stargazers","contributors_url":"https://api.github.com/repos/coreos/etcd/contributors","subscribers_url":"https://api.github.com/repos/coreos/etcd/subscribers","subscription_url":"https://api.github.com/repos/coreos/etcd/subscription","commits_url":"https://api.github.com/repos/coreos/etcd/commits{/sha}","git_commits_url":"https://api.github.com/repos/coreos/etcd/git/commits{/sha}","comments_url":"https://api.github.com/repos/coreos/etcd/comments{/number}","issue_comment_url":"https://api.github.com/repos/coreos/etcd/issues/comments{/number}","contents_url":"https://api.github.com/repos/coreos/etcd/contents/{+path}","compare_url":"https://api.github.com/repos/coreos/etcd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coreos/etcd/merges","archive_url":"https://api.github.com/repos/coreos/etcd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coreos/etcd/downloads","issues_url":"https://api.github.com/repos/coreos/etcd/issues{/number}","pulls_url":"https://api.github.com/repos/coreos/etcd/pulls{/number}","milestones_url":"https://api.github.com/repos/coreos/etcd/milestones{/number}","notifications_url":"https://api.github.com/repos/coreos/etcd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coreos/etcd/labels{/name}","releases_url":"https://api.github.com/repos/coreos/etcd/releases{/id}","deployments_url":"https://api.github.com/repos/coreos/etcd/deployments","created_at":"2013-07-06T21:57:21Z","updated_at":"2016-09-16T06:20:39Z","pushed_at":"2016-09-16T06:35:19Z","git_url":"git://github.com/coreos/etcd.git","ssh_url":"git@github.com:coreos/etcd.git","clone_url":"https://github.com/coreos/etcd.git","svn_url":"https://github.com/coreos/etcd","homepage":"https://coreos.com/etcd/docs/latest/","size":30810,"stargazers_count":10809,"watchers_count":10809,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1907,"mirror_url":null,"open_issues_count":130,"forks":1907,"open_issues":130,"watchers":10809,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coreos/etcd/pulls/6439"},"html":{"href":"https://github.com/coreos/etcd/pull/6439"},"issue":{"href":"https://api.github.com/repos/coreos/etcd/issues/6439"},"comments":{"href":"https://api.github.com/repos/coreos/etcd/issues/6439/comments"},"review_comments":{"href":"https://api.github.com/repos/coreos/etcd/pulls/6439/comments"},"review_comment":{"href":"https://api.github.com/repos/coreos/etcd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coreos/etcd/pulls/6439/commits"},"statuses":{"href":"https://api.github.com/repos/coreos/etcd/statuses/bfa34163bb9444dc31ba89f4be93186769250d23"}}}}
{"actor":{"display_login":"sinsharat"}}