{"action":"created","issue":{"url":"https://api.github.com/repos/jgarzik/picocoin/issues/79","repository_url":"https://api.github.com/repos/jgarzik/picocoin","labels_url":"https://api.github.com/repos/jgarzik/picocoin/issues/79/labels{/name}","comments_url":"https://api.github.com/repos/jgarzik/picocoin/issues/79/comments","events_url":"https://api.github.com/repos/jgarzik/picocoin/issues/79/events","html_url":"https://github.com/jgarzik/picocoin/pull/79","id":162177578,"number":79,"title":"Implement BIP66 (DERSIG)","user":{"login":"aido","id":2703875,"avatar_url":"https://avatars.githubusercontent.com/u/2703875?v=3","gravatar_id":"","url":"https://api.github.com/users/aido","html_url":"https://github.com/aido","followers_url":"https://api.github.com/users/aido/followers","following_url":"https://api.github.com/users/aido/following{/other_user}","gists_url":"https://api.github.com/users/aido/gists{/gist_id}","starred_url":"https://api.github.com/users/aido/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aido/subscriptions","organizations_url":"https://api.github.com/users/aido/orgs","repos_url":"https://api.github.com/users/aido/repos","events_url":"https://api.github.com/users/aido/events{/privacy}","received_events_url":"https://api.github.com/users/aido/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":12,"created_at":"2016-06-24T15:57:09Z","updated_at":"2016-06-30T15:38:58Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/jgarzik/picocoin/pulls/79","html_url":"https://github.com/jgarzik/picocoin/pull/79","diff_url":"https://github.com/jgarzik/picocoin/pull/79.diff","patch_url":"https://github.com/jgarzik/picocoin/pull/79.patch"},"body":"Hi,\r\n\r\nThis pull request adds code that implements BIP66.\r\n\r\nTests have also been added.\r\n\r\nAt the moment the following tests pass in `test/script_valid.json` and I am not so sure that they should.\r\n\r\n```\r\n[\"0x4a 0x0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000\", \"0 CHECKSIG NOT\", \"DERSIG\", \"Overly long signature is incorrectly encoded for DERSIG\"],\r\n[\"0x25 0x30220220000000000000000000000000000000000000000000000000000000000000000000\", \"0 CHECKSIG NOT\", \"DERSIG\", \"Missing S is incorrectly encoded for DERSIG\"],\r\n[\"0x27 0x3024021077777777777777777777777777777777020a7777777777777777777777777777777701\", \"0 CHECKSIG NOT\", \"DERSIG\", \"S with invalid S length is incorrectly encoded for DERSIG\"],\r\n[\"0x27 0x302403107777777777777777777777777777777702107777777777777777777777777777777701\", \"0 CHECKSIG NOT\", \"DERSIG\", \"Non-integer R is incorrectly encoded for DERSIG\"],\r\n[\"0x27 0x302402107777777777777777777777777777777703107777777777777777777777777777777701\", \"0 CHECKSIG NOT\", \"DERSIG\", \"Non-integer S is incorrectly encoded for DERSIG\"],\r\n[\"0x17 0x3014020002107777777777777777777777777777777701\", \"0 CHECKSIG NOT\", \"DERSIG\", \"Zero-length R is incorrectly encoded for DERSIG\"],\r\n[\"0x17 0x3014021077777777777777777777777777777777020001\", \"0 CHECKSIG NOT\", \"DERSIG\", \"Zero-length S is incorrectly encoded for DERSIG\"],\r\n[\"0x27 0x302402107777777777777777777777777777777702108777777777777777777777777777777701\", \"0 CHECKSIG NOT\", \"DERSIG\", \"Negative S is incorrectly encoded for DERSIG\"]\r\n\r\n```"},"comment":{"url":"https://api.github.com/repos/jgarzik/picocoin/issues/comments/229698287","html_url":"https://github.com/jgarzik/picocoin/pull/79#issuecomment-229698287","issue_url":"https://api.github.com/repos/jgarzik/picocoin/issues/79","id":229698287,"user":{"login":"aido","id":2703875,"avatar_url":"https://avatars.githubusercontent.com/u/2703875?v=3","gravatar_id":"","url":"https://api.github.com/users/aido","html_url":"https://github.com/aido","followers_url":"https://api.github.com/users/aido/followers","following_url":"https://api.github.com/users/aido/following{/other_user}","gists_url":"https://api.github.com/users/aido/gists{/gist_id}","starred_url":"https://api.github.com/users/aido/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aido/subscriptions","organizations_url":"https://api.github.com/users/aido/orgs","repos_url":"https://api.github.com/users/aido/repos","events_url":"https://api.github.com/users/aido/events{/privacy}","received_events_url":"https://api.github.com/users/aido/received_events","type":"User","site_admin":false},"created_at":"2016-06-30T15:38:58Z","updated_at":"2016-06-30T15:38:58Z","body":"Hi,\r\n\r\nWork on this pull request is now complete and it is ready for comment.\r\n"}}
{"actor":{"display_login":"aido"}}