{"action":"closed","number":42,"pull_request":{"url":"https://api.github.com/repos/10up/wp_mock/pulls/42","id":42828712,"html_url":"https://github.com/10up/wp_mock/pull/42","diff_url":"https://github.com/10up/wp_mock/pull/42.diff","patch_url":"https://github.com/10up/wp_mock/pull/42.patch","issue_url":"https://api.github.com/repos/10up/wp_mock/issues/42","number":42,"state":"closed","locked":false,"title":"Remove redundant cleanup","user":{"login":"tfrommen","id":6049306,"avatar_url":"https://avatars.githubusercontent.com/u/6049306?v=3","gravatar_id":"","url":"https://api.github.com/users/tfrommen","html_url":"https://github.com/tfrommen","followers_url":"https://api.github.com/users/tfrommen/followers","following_url":"https://api.github.com/users/tfrommen/following{/other_user}","gists_url":"https://api.github.com/users/tfrommen/gists{/gist_id}","starred_url":"https://api.github.com/users/tfrommen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tfrommen/subscriptions","organizations_url":"https://api.github.com/users/tfrommen/orgs","repos_url":"https://api.github.com/users/tfrommen/repos","events_url":"https://api.github.com/users/tfrommen/events{/privacy}","received_events_url":"https://api.github.com/users/tfrommen/received_events","type":"User","site_admin":false},"body":"What this pull request does:\r\n* remove a redundant call to `Handler::cleanup()`.\r\n\r\n`Handler::cleanup()` will be called in `flush()` anyway. In the latter method, first a private property is reset, but there are no side-effects whatsoever.","created_at":"2015-08-19T15:32:07Z","updated_at":"2016-04-25T18:09:21Z","closed_at":"2016-04-25T18:09:21Z","merged_at":null,"merge_commit_sha":"22fafbdf137c7540cc5da0f356476e01086d7720","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/10up/wp_mock/pulls/42/commits","review_comments_url":"https://api.github.com/repos/10up/wp_mock/pulls/42/comments","review_comment_url":"https://api.github.com/repos/10up/wp_mock/pulls/comments{/number}","comments_url":"https://api.github.com/repos/10up/wp_mock/issues/42/comments","statuses_url":"https://api.github.com/repos/10up/wp_mock/statuses/120c32c008c2799d548255b223bebf13617c4904","head":{"label":"tfrommen:enhancement/redundant_cleanup","ref":"enhancement/redundant_cleanup","sha":"120c32c008c2799d548255b223bebf13617c4904","user":{"login":"tfrommen","id":6049306,"avatar_url":"https://avatars.githubusercontent.com/u/6049306?v=3","gravatar_id":"","url":"https://api.github.com/users/tfrommen","html_url":"https://github.com/tfrommen","followers_url":"https://api.github.com/users/tfrommen/followers","following_url":"https://api.github.com/users/tfrommen/following{/other_user}","gists_url":"https://api.github.com/users/tfrommen/gists{/gist_id}","starred_url":"https://api.github.com/users/tfrommen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tfrommen/subscriptions","organizations_url":"https://api.github.com/users/tfrommen/orgs","repos_url":"https://api.github.com/users/tfrommen/repos","events_url":"https://api.github.com/users/tfrommen/events{/privacy}","received_events_url":"https://api.github.com/users/tfrommen/received_events","type":"User","site_admin":false},"repo":{"id":40763259,"name":"wp_mock","full_name":"tfrommen/wp_mock","owner":{"login":"tfrommen","id":6049306,"avatar_url":"https://avatars.githubusercontent.com/u/6049306?v=3","gravatar_id":"","url":"https://api.github.com/users/tfrommen","html_url":"https://github.com/tfrommen","followers_url":"https://api.github.com/users/tfrommen/followers","following_url":"https://api.github.com/users/tfrommen/following{/other_user}","gists_url":"https://api.github.com/users/tfrommen/gists{/gist_id}","starred_url":"https://api.github.com/users/tfrommen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tfrommen/subscriptions","organizations_url":"https://api.github.com/users/tfrommen/orgs","repos_url":"https://api.github.com/users/tfrommen/repos","events_url":"https://api.github.com/users/tfrommen/events{/privacy}","received_events_url":"https://api.github.com/users/tfrommen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tfrommen/wp_mock","description":"WordPress API Mocking Framework","fork":true,"url":"https://api.github.com/repos/tfrommen/wp_mock","forks_url":"https://api.github.com/repos/tfrommen/wp_mock/forks","keys_url":"https://api.github.com/repos/tfrommen/wp_mock/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tfrommen/wp_mock/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tfrommen/wp_mock/teams","hooks_url":"https://api.github.com/repos/tfrommen/wp_mock/hooks","issue_events_url":"https://api.github.com/repos/tfrommen/wp_mock/issues/events{/number}","events_url":"https://api.github.com/repos/tfrommen/wp_mock/events","assignees_url":"https://api.github.com/repos/tfrommen/wp_mock/assignees{/user}","branches_url":"https://api.github.com/repos/tfrommen/wp_mock/branches{/branch}","tags_url":"https://api.github.com/repos/tfrommen/wp_mock/tags","blobs_url":"https://api.github.com/repos/tfrommen/wp_mock/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tfrommen/wp_mock/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tfrommen/wp_mock/git/refs{/sha}","trees_url":"https://api.github.com/repos/tfrommen/wp_mock/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tfrommen/wp_mock/statuses/{sha}","languages_url":"https://api.github.com/repos/tfrommen/wp_mock/languages","stargazers_url":"https://api.github.com/repos/tfrommen/wp_mock/stargazers","contributors_url":"https://api.github.com/repos/tfrommen/wp_mock/contributors","subscribers_url":"https://api.github.com/repos/tfrommen/wp_mock/subscribers","subscription_url":"https://api.github.com/repos/tfrommen/wp_mock/subscription","commits_url":"https://api.github.com/repos/tfrommen/wp_mock/commits{/sha}","git_commits_url":"https://api.github.com/repos/tfrommen/wp_mock/git/commits{/sha}","comments_url":"https://api.github.com/repos/tfrommen/wp_mock/comments{/number}","issue_comment_url":"https://api.github.com/repos/tfrommen/wp_mock/issues/comments{/number}","contents_url":"https://api.github.com/repos/tfrommen/wp_mock/contents/{+path}","compare_url":"https://api.github.com/repos/tfrommen/wp_mock/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tfrommen/wp_mock/merges","archive_url":"https://api.github.com/repos/tfrommen/wp_mock/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tfrommen/wp_mock/downloads","issues_url":"https://api.github.com/repos/tfrommen/wp_mock/issues{/number}","pulls_url":"https://api.github.com/repos/tfrommen/wp_mock/pulls{/number}","milestones_url":"https://api.github.com/repos/tfrommen/wp_mock/milestones{/number}","notifications_url":"https://api.github.com/repos/tfrommen/wp_mock/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tfrommen/wp_mock/labels{/name}","releases_url":"https://api.github.com/repos/tfrommen/wp_mock/releases{/id}","deployments_url":"https://api.github.com/repos/tfrommen/wp_mock/deployments","created_at":"2015-08-15T14:08:54Z","updated_at":"2015-08-15T14:08:54Z","pushed_at":"2015-08-20T23:16:05Z","git_url":"git://github.com/tfrommen/wp_mock.git","ssh_url":"git@github.com:tfrommen/wp_mock.git","clone_url":"https://github.com/tfrommen/wp_mock.git","svn_url":"https://github.com/tfrommen/wp_mock","homepage":null,"size":1004,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"10up:dev","ref":"dev","sha":"b124601730dd90019b2bdd8b0741b3297885eb7b","user":{"login":"10up","id":3358927,"avatar_url":"https://avatars.githubusercontent.com/u/3358927?v=3","gravatar_id":"","url":"https://api.github.com/users/10up","html_url":"https://github.com/10up","followers_url":"https://api.github.com/users/10up/followers","following_url":"https://api.github.com/users/10up/following{/other_user}","gists_url":"https://api.github.com/users/10up/gists{/gist_id}","starred_url":"https://api.github.com/users/10up/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/10up/subscriptions","organizations_url":"https://api.github.com/users/10up/orgs","repos_url":"https://api.github.com/users/10up/repos","events_url":"https://api.github.com/users/10up/events{/privacy}","received_events_url":"https://api.github.com/users/10up/received_events","type":"Organization","site_admin":false},"repo":{"id":9034019,"name":"wp_mock","full_name":"10up/wp_mock","owner":{"login":"10up","id":3358927,"avatar_url":"https://avatars.githubusercontent.com/u/3358927?v=3","gravatar_id":"","url":"https://api.github.com/users/10up","html_url":"https://github.com/10up","followers_url":"https://api.github.com/users/10up/followers","following_url":"https://api.github.com/users/10up/following{/other_user}","gists_url":"https://api.github.com/users/10up/gists{/gist_id}","starred_url":"https://api.github.com/users/10up/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/10up/subscriptions","organizations_url":"https://api.github.com/users/10up/orgs","repos_url":"https://api.github.com/users/10up/repos","events_url":"https://api.github.com/users/10up/events{/privacy}","received_events_url":"https://api.github.com/users/10up/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/10up/wp_mock","description":"WordPress API Mocking Framework","fork":false,"url":"https://api.github.com/repos/10up/wp_mock","forks_url":"https://api.github.com/repos/10up/wp_mock/forks","keys_url":"https://api.github.com/repos/10up/wp_mock/keys{/key_id}","collaborators_url":"https://api.github.com/repos/10up/wp_mock/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/10up/wp_mock/teams","hooks_url":"https://api.github.com/repos/10up/wp_mock/hooks","issue_events_url":"https://api.github.com/repos/10up/wp_mock/issues/events{/number}","events_url":"https://api.github.com/repos/10up/wp_mock/events","assignees_url":"https://api.github.com/repos/10up/wp_mock/assignees{/user}","branches_url":"https://api.github.com/repos/10up/wp_mock/branches{/branch}","tags_url":"https://api.github.com/repos/10up/wp_mock/tags","blobs_url":"https://api.github.com/repos/10up/wp_mock/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/10up/wp_mock/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/10up/wp_mock/git/refs{/sha}","trees_url":"https://api.github.com/repos/10up/wp_mock/git/trees{/sha}","statuses_url":"https://api.github.com/repos/10up/wp_mock/statuses/{sha}","languages_url":"https://api.github.com/repos/10up/wp_mock/languages","stargazers_url":"https://api.github.com/repos/10up/wp_mock/stargazers","contributors_url":"https://api.github.com/repos/10up/wp_mock/contributors","subscribers_url":"https://api.github.com/repos/10up/wp_mock/subscribers","subscription_url":"https://api.github.com/repos/10up/wp_mock/subscription","commits_url":"https://api.github.com/repos/10up/wp_mock/commits{/sha}","git_commits_url":"https://api.github.com/repos/10up/wp_mock/git/commits{/sha}","comments_url":"https://api.github.com/repos/10up/wp_mock/comments{/number}","issue_comment_url":"https://api.github.com/repos/10up/wp_mock/issues/comments{/number}","contents_url":"https://api.github.com/repos/10up/wp_mock/contents/{+path}","compare_url":"https://api.github.com/repos/10up/wp_mock/compare/{base}...{head}","merges_url":"https://api.github.com/repos/10up/wp_mock/merges","archive_url":"https://api.github.com/repos/10up/wp_mock/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/10up/wp_mock/downloads","issues_url":"https://api.github.com/repos/10up/wp_mock/issues{/number}","pulls_url":"https://api.github.com/repos/10up/wp_mock/pulls{/number}","milestones_url":"https://api.github.com/repos/10up/wp_mock/milestones{/number}","notifications_url":"https://api.github.com/repos/10up/wp_mock/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/10up/wp_mock/labels{/name}","releases_url":"https://api.github.com/repos/10up/wp_mock/releases{/id}","deployments_url":"https://api.github.com/repos/10up/wp_mock/deployments","created_at":"2013-03-26T15:49:40Z","updated_at":"2016-04-14T12:25:24Z","pushed_at":"2016-02-05T20:10:19Z","git_url":"git://github.com/10up/wp_mock.git","ssh_url":"git@github.com:10up/wp_mock.git","clone_url":"https://github.com/10up/wp_mock.git","svn_url":"https://github.com/10up/wp_mock","homepage":null,"size":901,"stargazers_count":238,"watchers_count":238,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":28,"mirror_url":null,"open_issues_count":16,"forks":28,"open_issues":16,"watchers":238,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/10up/wp_mock/pulls/42"},"html":{"href":"https://github.com/10up/wp_mock/pull/42"},"issue":{"href":"https://api.github.com/repos/10up/wp_mock/issues/42"},"comments":{"href":"https://api.github.com/repos/10up/wp_mock/issues/42/comments"},"review_comments":{"href":"https://api.github.com/repos/10up/wp_mock/pulls/42/comments"},"review_comment":{"href":"https://api.github.com/repos/10up/wp_mock/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/10up/wp_mock/pulls/42/commits"},"statuses":{"href":"https://api.github.com/repos/10up/wp_mock/statuses/120c32c008c2799d548255b223bebf13617c4904"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":0,"deletions":1,"changed_files":1}}