{"action":"created","comment":{"url":"https://api.github.com/repos/wso2/carbon-deployment/pulls/comments/63470898","id":63470898,"diff_hunk":"@@ -144,7 +145,16 @@ private WarCappMetadata getWebappMetadata(String fileName) {\n                 warCappMetadata.setWebappFileName(webApplication.getWebappFile().getName());\n                 warCappMetadata.setHostName(webApplication.getHostName());\n \n-                int httpPort = CarbonUtils.getTransportProxyPort(getConfigContext(), \"http\");\n+                int httpPort = -1;\n+                String workerHttpPortString = ServerConfiguration.getInstance().\n+                        getFirstProperty(\"Ports.WorkerHttpProxyPort\");\n+                if (workerHttpPortString != null) {\n+                    httpPort = Integer.parseInt(workerHttpPortString);\n+                }\n+\n+                if (httpPort == -1) {\n+                    httpPort = CarbonUtils.getTransportProxyPort(getConfigContext(), \"http\");\n+                }\n                 if (httpPort == -1) {\n                     httpPort = CarbonUtils.getTransportPort(getConfigContext(), \"http\");","path":"components/webapp-mgt/org.wso2.carbon.application.mgt.webapp/src/main/java/org/wso2/carbon/application/mgt/webapp/WarApplicationAdmin.java","position":24,"original_position":24,"commit_id":"07b4e914b0256d1b0a22daa6f6a18eabf8b8cb22","original_commit_id":"07b4e914b0256d1b0a22daa6f6a18eabf8b8cb22","user":{"login":"Niranjan-K","id":5525926,"avatar_url":"https://avatars.githubusercontent.com/u/5525926?v=3","gravatar_id":"","url":"https://api.github.com/users/Niranjan-K","html_url":"https://github.com/Niranjan-K","followers_url":"https://api.github.com/users/Niranjan-K/followers","following_url":"https://api.github.com/users/Niranjan-K/following{/other_user}","gists_url":"https://api.github.com/users/Niranjan-K/gists{/gist_id}","starred_url":"https://api.github.com/users/Niranjan-K/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Niranjan-K/subscriptions","organizations_url":"https://api.github.com/users/Niranjan-K/orgs","repos_url":"https://api.github.com/users/Niranjan-K/repos","events_url":"https://api.github.com/users/Niranjan-K/events{/privacy}","received_events_url":"https://api.github.com/users/Niranjan-K/received_events","type":"User","site_admin":false},"body":"Can we move this to the above \"if\" condition?","created_at":"2016-05-17T06:39:15Z","updated_at":"2016-05-17T06:39:15Z","html_url":"https://github.com/wso2/carbon-deployment/pull/204#discussion_r63470898","pull_request_url":"https://api.github.com/repos/wso2/carbon-deployment/pulls/204","_links":{"self":{"href":"https://api.github.com/repos/wso2/carbon-deployment/pulls/comments/63470898"},"html":{"href":"https://github.com/wso2/carbon-deployment/pull/204#discussion_r63470898"},"pull_request":{"href":"https://api.github.com/repos/wso2/carbon-deployment/pulls/204"}}},"pull_request":{"url":"https://api.github.com/repos/wso2/carbon-deployment/pulls/204","id":59616889,"html_url":"https://github.com/wso2/carbon-deployment/pull/204","diff_url":"https://github.com/wso2/carbon-deployment/pull/204.diff","patch_url":"https://github.com/wso2/carbon-deployment/pull/204.patch","issue_url":"https://api.github.com/repos/wso2/carbon-deployment/issues/204","number":204,"state":"closed","locked":false,"title":"Carbon 15659: Changing carbon-deployment to work with the new carbon.xml config for workers' proxy port","user":{"login":"Manuri","id":1335271,"avatar_url":"https://avatars.githubusercontent.com/u/1335271?v=3","gravatar_id":"","url":"https://api.github.com/users/Manuri","html_url":"https://github.com/Manuri","followers_url":"https://api.github.com/users/Manuri/followers","following_url":"https://api.github.com/users/Manuri/following{/other_user}","gists_url":"https://api.github.com/users/Manuri/gists{/gist_id}","starred_url":"https://api.github.com/users/Manuri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Manuri/subscriptions","organizations_url":"https://api.github.com/users/Manuri/orgs","repos_url":"https://api.github.com/users/Manuri/repos","events_url":"https://api.github.com/users/Manuri/events{/privacy}","received_events_url":"https://api.github.com/users/Manuri/received_events","type":"User","site_admin":false},"body":"Please refer https://wso2.org/jira/browse/CARBON-15659\r\n\r\nEven with a kernel version which doesn't have the worker proxy port in carbon.xml, this shouldn't break anything because if the woker proxy port configuration is not present the flow continues as it does without this change.","created_at":"2016-02-17T09:32:01Z","updated_at":"2016-05-17T06:39:15Z","closed_at":"2016-02-17T09:48:26Z","merged_at":"2016-02-17T09:48:26Z","merge_commit_sha":"9195dea9a4f06417a5a7058307c0252bc2966a09","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/wso2/carbon-deployment/pulls/204/commits","review_comments_url":"https://api.github.com/repos/wso2/carbon-deployment/pulls/204/comments","review_comment_url":"https://api.github.com/repos/wso2/carbon-deployment/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wso2/carbon-deployment/issues/204/comments","statuses_url":"https://api.github.com/repos/wso2/carbon-deployment/statuses/07b4e914b0256d1b0a22daa6f6a18eabf8b8cb22","head":{"label":"Manuri:4.5.x-CARBON-15659","ref":"4.5.x-CARBON-15659","sha":"07b4e914b0256d1b0a22daa6f6a18eabf8b8cb22","user":{"login":"Manuri","id":1335271,"avatar_url":"https://avatars.githubusercontent.com/u/1335271?v=3","gravatar_id":"","url":"https://api.github.com/users/Manuri","html_url":"https://github.com/Manuri","followers_url":"https://api.github.com/users/Manuri/followers","following_url":"https://api.github.com/users/Manuri/following{/other_user}","gists_url":"https://api.github.com/users/Manuri/gists{/gist_id}","starred_url":"https://api.github.com/users/Manuri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Manuri/subscriptions","organizations_url":"https://api.github.com/users/Manuri/orgs","repos_url":"https://api.github.com/users/Manuri/repos","events_url":"https://api.github.com/users/Manuri/events{/privacy}","received_events_url":"https://api.github.com/users/Manuri/received_events","type":"User","site_admin":false},"repo":{"id":39234305,"name":"carbon-deployment","full_name":"Manuri/carbon-deployment","owner":{"login":"Manuri","id":1335271,"avatar_url":"https://avatars.githubusercontent.com/u/1335271?v=3","gravatar_id":"","url":"https://api.github.com/users/Manuri","html_url":"https://github.com/Manuri","followers_url":"https://api.github.com/users/Manuri/followers","following_url":"https://api.github.com/users/Manuri/following{/other_user}","gists_url":"https://api.github.com/users/Manuri/gists{/gist_id}","starred_url":"https://api.github.com/users/Manuri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Manuri/subscriptions","organizations_url":"https://api.github.com/users/Manuri/orgs","repos_url":"https://api.github.com/users/Manuri/repos","events_url":"https://api.github.com/users/Manuri/events{/privacy}","received_events_url":"https://api.github.com/users/Manuri/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Manuri/carbon-deployment","description":"","fork":true,"url":"https://api.github.com/repos/Manuri/carbon-deployment","forks_url":"https://api.github.com/repos/Manuri/carbon-deployment/forks","keys_url":"https://api.github.com/repos/Manuri/carbon-deployment/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Manuri/carbon-deployment/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Manuri/carbon-deployment/teams","hooks_url":"https://api.github.com/repos/Manuri/carbon-deployment/hooks","issue_events_url":"https://api.github.com/repos/Manuri/carbon-deployment/issues/events{/number}","events_url":"https://api.github.com/repos/Manuri/carbon-deployment/events","assignees_url":"https://api.github.com/repos/Manuri/carbon-deployment/assignees{/user}","branches_url":"https://api.github.com/repos/Manuri/carbon-deployment/branches{/branch}","tags_url":"https://api.github.com/repos/Manuri/carbon-deployment/tags","blobs_url":"https://api.github.com/repos/Manuri/carbon-deployment/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Manuri/carbon-deployment/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Manuri/carbon-deployment/git/refs{/sha}","trees_url":"https://api.github.com/repos/Manuri/carbon-deployment/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Manuri/carbon-deployment/statuses/{sha}","languages_url":"https://api.github.com/repos/Manuri/carbon-deployment/languages","stargazers_url":"https://api.github.com/repos/Manuri/carbon-deployment/stargazers","contributors_url":"https://api.github.com/repos/Manuri/carbon-deployment/contributors","subscribers_url":"https://api.github.com/repos/Manuri/carbon-deployment/subscribers","subscription_url":"https://api.github.com/repos/Manuri/carbon-deployment/subscription","commits_url":"https://api.github.com/repos/Manuri/carbon-deployment/commits{/sha}","git_commits_url":"https://api.github.com/repos/Manuri/carbon-deployment/git/commits{/sha}","comments_url":"https://api.github.com/repos/Manuri/carbon-deployment/comments{/number}","issue_comment_url":"https://api.github.com/repos/Manuri/carbon-deployment/issues/comments{/number}","contents_url":"https://api.github.com/repos/Manuri/carbon-deployment/contents/{+path}","compare_url":"https://api.github.com/repos/Manuri/carbon-deployment/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Manuri/carbon-deployment/merges","archive_url":"https://api.github.com/repos/Manuri/carbon-deployment/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Manuri/carbon-deployment/downloads","issues_url":"https://api.github.com/repos/Manuri/carbon-deployment/issues{/number}","pulls_url":"https://api.github.com/repos/Manuri/carbon-deployment/pulls{/number}","milestones_url":"https://api.github.com/repos/Manuri/carbon-deployment/milestones{/number}","notifications_url":"https://api.github.com/repos/Manuri/carbon-deployment/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Manuri/carbon-deployment/labels{/name}","releases_url":"https://api.github.com/repos/Manuri/carbon-deployment/releases{/id}","deployments_url":"https://api.github.com/repos/Manuri/carbon-deployment/deployments","created_at":"2015-07-17T04:08:29Z","updated_at":"2015-07-17T04:08:34Z","pushed_at":"2016-05-12T12:32:06Z","git_url":"git://github.com/Manuri/carbon-deployment.git","ssh_url":"git@github.com:Manuri/carbon-deployment.git","clone_url":"https://github.com/Manuri/carbon-deployment.git","svn_url":"https://github.com/Manuri/carbon-deployment","homepage":null,"size":7764,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wso2:4.5.x","ref":"4.5.x","sha":"17f8ae9a4a64f204e8565e063ef848624569b3be","user":{"login":"wso2","id":533043,"avatar_url":"https://avatars.githubusercontent.com/u/533043?v=3","gravatar_id":"","url":"https://api.github.com/users/wso2","html_url":"https://github.com/wso2","followers_url":"https://api.github.com/users/wso2/followers","following_url":"https://api.github.com/users/wso2/following{/other_user}","gists_url":"https://api.github.com/users/wso2/gists{/gist_id}","starred_url":"https://api.github.com/users/wso2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wso2/subscriptions","organizations_url":"https://api.github.com/users/wso2/orgs","repos_url":"https://api.github.com/users/wso2/repos","events_url":"https://api.github.com/users/wso2/events{/privacy}","received_events_url":"https://api.github.com/users/wso2/received_events","type":"Organization","site_admin":false},"repo":{"id":16379759,"name":"carbon-deployment","full_name":"wso2/carbon-deployment","owner":{"login":"wso2","id":533043,"avatar_url":"https://avatars.githubusercontent.com/u/533043?v=3","gravatar_id":"","url":"https://api.github.com/users/wso2","html_url":"https://github.com/wso2","followers_url":"https://api.github.com/users/wso2/followers","following_url":"https://api.github.com/users/wso2/following{/other_user}","gists_url":"https://api.github.com/users/wso2/gists{/gist_id}","starred_url":"https://api.github.com/users/wso2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wso2/subscriptions","organizations_url":"https://api.github.com/users/wso2/orgs","repos_url":"https://api.github.com/users/wso2/repos","events_url":"https://api.github.com/users/wso2/events{/privacy}","received_events_url":"https://api.github.com/users/wso2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wso2/carbon-deployment","description":"","fork":false,"url":"https://api.github.com/repos/wso2/carbon-deployment","forks_url":"https://api.github.com/repos/wso2/carbon-deployment/forks","keys_url":"https://api.github.com/repos/wso2/carbon-deployment/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wso2/carbon-deployment/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wso2/carbon-deployment/teams","hooks_url":"https://api.github.com/repos/wso2/carbon-deployment/hooks","issue_events_url":"https://api.github.com/repos/wso2/carbon-deployment/issues/events{/number}","events_url":"https://api.github.com/repos/wso2/carbon-deployment/events","assignees_url":"https://api.github.com/repos/wso2/carbon-deployment/assignees{/user}","branches_url":"https://api.github.com/repos/wso2/carbon-deployment/branches{/branch}","tags_url":"https://api.github.com/repos/wso2/carbon-deployment/tags","blobs_url":"https://api.github.com/repos/wso2/carbon-deployment/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wso2/carbon-deployment/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wso2/carbon-deployment/git/refs{/sha}","trees_url":"https://api.github.com/repos/wso2/carbon-deployment/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wso2/carbon-deployment/statuses/{sha}","languages_url":"https://api.github.com/repos/wso2/carbon-deployment/languages","stargazers_url":"https://api.github.com/repos/wso2/carbon-deployment/stargazers","contributors_url":"https://api.github.com/repos/wso2/carbon-deployment/contributors","subscribers_url":"https://api.github.com/repos/wso2/carbon-deployment/subscribers","subscription_url":"https://api.github.com/repos/wso2/carbon-deployment/subscription","commits_url":"https://api.github.com/repos/wso2/carbon-deployment/commits{/sha}","git_commits_url":"https://api.github.com/repos/wso2/carbon-deployment/git/commits{/sha}","comments_url":"https://api.github.com/repos/wso2/carbon-deployment/comments{/number}","issue_comment_url":"https://api.github.com/repos/wso2/carbon-deployment/issues/comments{/number}","contents_url":"https://api.github.com/repos/wso2/carbon-deployment/contents/{+path}","compare_url":"https://api.github.com/repos/wso2/carbon-deployment/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wso2/carbon-deployment/merges","archive_url":"https://api.github.com/repos/wso2/carbon-deployment/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wso2/carbon-deployment/downloads","issues_url":"https://api.github.com/repos/wso2/carbon-deployment/issues{/number}","pulls_url":"https://api.github.com/repos/wso2/carbon-deployment/pulls{/number}","milestones_url":"https://api.github.com/repos/wso2/carbon-deployment/milestones{/number}","notifications_url":"https://api.github.com/repos/wso2/carbon-deployment/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wso2/carbon-deployment/labels{/name}","releases_url":"https://api.github.com/repos/wso2/carbon-deployment/releases{/id}","deployments_url":"https://api.github.com/repos/wso2/carbon-deployment/deployments","created_at":"2014-01-30T14:40:30Z","updated_at":"2016-02-16T06:36:18Z","pushed_at":"2016-05-12T12:32:07Z","git_url":"git://github.com/wso2/carbon-deployment.git","ssh_url":"git@github.com:wso2/carbon-deployment.git","clone_url":"https://github.com/wso2/carbon-deployment.git","svn_url":"https://github.com/wso2/carbon-deployment","homepage":null,"size":9129,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":65,"mirror_url":null,"open_issues_count":10,"forks":65,"open_issues":10,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wso2/carbon-deployment/pulls/204"},"html":{"href":"https://github.com/wso2/carbon-deployment/pull/204"},"issue":{"href":"https://api.github.com/repos/wso2/carbon-deployment/issues/204"},"comments":{"href":"https://api.github.com/repos/wso2/carbon-deployment/issues/204/comments"},"review_comments":{"href":"https://api.github.com/repos/wso2/carbon-deployment/pulls/204/comments"},"review_comment":{"href":"https://api.github.com/repos/wso2/carbon-deployment/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wso2/carbon-deployment/pulls/204/commits"},"statuses":{"href":"https://api.github.com/repos/wso2/carbon-deployment/statuses/07b4e914b0256d1b0a22daa6f6a18eabf8b8cb22"}}}}