{"action":"created","issue":{"url":"https://api.github.com/repos/uTox/uTox/issues/546","repository_url":"https://api.github.com/repos/uTox/uTox","labels_url":"https://api.github.com/repos/uTox/uTox/issues/546/labels{/name}","comments_url":"https://api.github.com/repos/uTox/uTox/issues/546/comments","events_url":"https://api.github.com/repos/uTox/uTox/issues/546/events","html_url":"https://github.com/uTox/uTox/pull/546","id":196077422,"number":546,"title":"Fix segv in ft_find_resumeable in file_transfer.c on Windows","user":{"login":"robinlinden","id":8304462,"avatar_url":"https://avatars.githubusercontent.com/u/8304462?v=3","gravatar_id":"","url":"https://api.github.com/users/robinlinden","html_url":"https://github.com/robinlinden","followers_url":"https://api.github.com/users/robinlinden/followers","following_url":"https://api.github.com/users/robinlinden/following{/other_user}","gists_url":"https://api.github.com/users/robinlinden/gists{/gist_id}","starred_url":"https://api.github.com/users/robinlinden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robinlinden/subscriptions","organizations_url":"https://api.github.com/users/robinlinden/orgs","repos_url":"https://api.github.com/users/robinlinden/repos","events_url":"https://api.github.com/users/robinlinden/events{/privacy}","received_events_url":"https://api.github.com/users/robinlinden/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-12-16T14:57:27Z","updated_at":"2016-12-16T22:19:40Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/uTox/uTox/pulls/546","html_url":"https://github.com/uTox/uTox/pull/546","diff_url":"https://github.com/uTox/uTox/pull/546.diff","patch_url":"https://github.com/uTox/uTox/pull/546.patch"},"body":"Also stop Windows `native_get_file `from creating files when passing READ to it.\r\nAlso silences warnings RE: not creating files when passing READ to `native_get_file`.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/utox/utox/546)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/uTox/uTox/issues/comments/267709901","html_url":"https://github.com/uTox/uTox/pull/546#issuecomment-267709901","issue_url":"https://api.github.com/repos/uTox/uTox/issues/546","id":267709901,"user":{"login":"GrayHatter","id":243408,"avatar_url":"https://avatars.githubusercontent.com/u/243408?v=3","gravatar_id":"","url":"https://api.github.com/users/GrayHatter","html_url":"https://github.com/GrayHatter","followers_url":"https://api.github.com/users/GrayHatter/followers","following_url":"https://api.github.com/users/GrayHatter/following{/other_user}","gists_url":"https://api.github.com/users/GrayHatter/gists{/gist_id}","starred_url":"https://api.github.com/users/GrayHatter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GrayHatter/subscriptions","organizations_url":"https://api.github.com/users/GrayHatter/orgs","repos_url":"https://api.github.com/users/GrayHatter/repos","events_url":"https://api.github.com/users/GrayHatter/events{/privacy}","received_events_url":"https://api.github.com/users/GrayHatter/received_events","type":"User","site_admin":false},"created_at":"2016-12-16T22:19:40Z","updated_at":"2016-12-16T22:19:40Z","body":"\n\n\n\nReview status: all files reviewed at latest revision, 2 unresolved discussions.\n\n---\n\n*[src/file_transfers.c, line 193 at r1](https://reviewable.io:443/reviews/utox/utox/546#-KZ8hD_XRiexWQb7r9qM:-KZ8hD_YVGdfpbrXIgdg:bp9gqxr) ([raw file](https://github.com/utox/utox/blob/78df8b28e91bbf7095af2fe1fc30fb7d88b74c79/src/file_transfers.c#L193)):*\n> ```C\n> \n>     if (!resume_data.in_use\n>         || resume_data.in_memory\n> ```\n\nthis is wrong\nit need to be && (...)\n\n```c\n     if ((!resume_data.in_use || !resume_data.resumeable)\n        && ( resume_data.in_memory\n            || resume_data.avatar\n            || resume_data.inline_img)) { // We don't want to resume these 3\n```\n\n---\n\n*[src/windows/filesys.c, line 95 at r1](https://reviewable.io:443/reviews/utox/utox/546#-KZ8hxE1C3yup5NycnDd:-KZ8hxE1C3yup5NycnDe:b72wjie) ([raw file](https://github.com/utox/utox/blob/78df8b28e91bbf7095af2fe1fc30fb7d88b74c79/src/windows/filesys.c#L95)):*\n> ```C\n>     if (fp == NULL) {\n>         if (opts > UTOX_FILE_OPTS_READ) {\n>             debug_error(\"Windows:\\tCould not open %s\\n\", path);\n> ```\n\nThis is a notice, not an error\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/utox/utox/546)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"GrayHatter"}}