{"action":"created","issue":{"url":"https://api.github.com/repos/farkam135/GoIV/issues/141","repository_url":"https://api.github.com/repos/farkam135/GoIV","labels_url":"https://api.github.com/repos/farkam135/GoIV/issues/141/labels{/name}","comments_url":"https://api.github.com/repos/farkam135/GoIV/issues/141/comments","events_url":"https://api.github.com/repos/farkam135/GoIV/issues/141/events","html_url":"https://github.com/farkam135/GoIV/issues/141","id":172618897,"number":141,"title":"Should we cache Bitmap OCR results?","user":{"login":"sarav","id":247061,"avatar_url":"https://avatars.githubusercontent.com/u/247061?v=3","gravatar_id":"","url":"https://api.github.com/users/sarav","html_url":"https://github.com/sarav","followers_url":"https://api.github.com/users/sarav/followers","following_url":"https://api.github.com/users/sarav/following{/other_user}","gists_url":"https://api.github.com/users/sarav/gists{/gist_id}","starred_url":"https://api.github.com/users/sarav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarav/subscriptions","organizations_url":"https://api.github.com/users/sarav/orgs","repos_url":"https://api.github.com/users/sarav/repos","events_url":"https://api.github.com/users/sarav/events{/privacy}","received_events_url":"https://api.github.com/users/sarav/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":22,"created_at":"2016-08-23T06:02:59Z","updated_at":"2016-08-24T09:47:28Z","closed_at":null,"body":"I gave it a shot in #140 . The logic works.\r\n\r\nIf the Bitmap is fixed, I don't see any reason the OCR results should change each time. I'd also think that the OCR code is a lot more complicated and floating point intensive than hashcode generation. Unfortunately, Bitmap.hashcode() doesn't generate a hashcode based on the bitmap picture. So, I had to extract the pixels to do it. I'm unable to officially verify it though. I guess I could do a timestamp check. Didn't think of that -- but I got to log off for today.\r\n\r\nCan others (@Blaisorblade @Eccenux @mattaereal @nahojjjen @farkam135) give it a shot and let us know what you think? Does it feel a bit faster when you check the IV for the same type of Pokemon (assuming you didn't rename it) or when you check the same Pokemon again? Is the LRU size of 200 too small? I'd like to hear some thoughts."},"comment":{"url":"https://api.github.com/repos/farkam135/GoIV/issues/comments/242011392","html_url":"https://github.com/farkam135/GoIV/issues/141#issuecomment-242011392","issue_url":"https://api.github.com/repos/farkam135/GoIV/issues/141","id":242011392,"user":{"login":"Blaisorblade","id":289960,"avatar_url":"https://avatars.githubusercontent.com/u/289960?v=3","gravatar_id":"","url":"https://api.github.com/users/Blaisorblade","html_url":"https://github.com/Blaisorblade","followers_url":"https://api.github.com/users/Blaisorblade/followers","following_url":"https://api.github.com/users/Blaisorblade/following{/other_user}","gists_url":"https://api.github.com/users/Blaisorblade/gists{/gist_id}","starred_url":"https://api.github.com/users/Blaisorblade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Blaisorblade/subscriptions","organizations_url":"https://api.github.com/users/Blaisorblade/orgs","repos_url":"https://api.github.com/users/Blaisorblade/repos","events_url":"https://api.github.com/users/Blaisorblade/events{/privacy}","received_events_url":"https://api.github.com/users/Blaisorblade/received_events","type":"User","site_admin":false},"created_at":"2016-08-24T09:47:28Z","updated_at":"2016-08-24T09:47:28Z","body":"I had missed the edit, thanks. I just found sampling profilers here: https://developer.android.com/studio/profile/ddms.html#profiling\r\nFeel free to leave it alone, but I might just try it 😄 \r\n\r\nAnd in any case, thanks for the find and 👍  for the caching."}}
{"actor":{"display_login":"Blaisorblade"}}