{"action":"opened","number":28578,"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/28578","id":94331454,"html_url":"https://github.com/docker/docker/pull/28578","diff_url":"https://github.com/docker/docker/pull/28578.diff","patch_url":"https://github.com/docker/docker/pull/28578.patch","issue_url":"https://api.github.com/repos/docker/docker/issues/28578","number":28578,"state":"open","locked":false,"title":"remove redundant file Close","user":{"login":"allencloud","id":9465626,"avatar_url":"https://avatars.githubusercontent.com/u/9465626?v=3","gravatar_id":"","url":"https://api.github.com/users/allencloud","html_url":"https://github.com/allencloud","followers_url":"https://api.github.com/users/allencloud/followers","following_url":"https://api.github.com/users/allencloud/following{/other_user}","gists_url":"https://api.github.com/users/allencloud/gists{/gist_id}","starred_url":"https://api.github.com/users/allencloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allencloud/subscriptions","organizations_url":"https://api.github.com/users/allencloud/orgs","repos_url":"https://api.github.com/users/allencloud/repos","events_url":"https://api.github.com/users/allencloud/events{/privacy}","received_events_url":"https://api.github.com/users/allencloud/received_events","type":"User","site_admin":false},"body":"remove redundant file Close\r\n\r\nAs there is already a `defer f.Close()`, then I think explicit `f.Close()` will cause problem there.\r\n\r\n**- What I did**\r\n\r\n**- How I did it**\r\n\r\n**- How to verify it**\r\n\r\n**- Description for the changelog**\r\n<!--\r\nWrite a short (one line) summary that describes the changes in this\r\npull request for inclusion in the changelog:\r\n-->\r\n\r\n\r\n**- A picture of a cute animal (not mandatory but encouraged)**\r\n\r\n\r\nSigned-off-by: allencloud <allen.sun@daocloud.io>","created_at":"2016-11-18T09:51:38Z","updated_at":"2016-11-18T09:51:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/docker/docker/pulls/28578/commits","review_comments_url":"https://api.github.com/repos/docker/docker/pulls/28578/comments","review_comment_url":"https://api.github.com/repos/docker/docker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/docker/issues/28578/comments","statuses_url":"https://api.github.com/repos/docker/docker/statuses/3dca62cfb1e7c6404cb4730425919f66c680b409","head":{"label":"allencloud:remove-redudant-file-Close","ref":"remove-redudant-file-Close","sha":"3dca62cfb1e7c6404cb4730425919f66c680b409","user":{"login":"allencloud","id":9465626,"avatar_url":"https://avatars.githubusercontent.com/u/9465626?v=3","gravatar_id":"","url":"https://api.github.com/users/allencloud","html_url":"https://github.com/allencloud","followers_url":"https://api.github.com/users/allencloud/followers","following_url":"https://api.github.com/users/allencloud/following{/other_user}","gists_url":"https://api.github.com/users/allencloud/gists{/gist_id}","starred_url":"https://api.github.com/users/allencloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allencloud/subscriptions","organizations_url":"https://api.github.com/users/allencloud/orgs","repos_url":"https://api.github.com/users/allencloud/repos","events_url":"https://api.github.com/users/allencloud/events{/privacy}","received_events_url":"https://api.github.com/users/allencloud/received_events","type":"User","site_admin":false},"repo":{"id":52540894,"name":"docker","full_name":"allencloud/docker","owner":{"login":"allencloud","id":9465626,"avatar_url":"https://avatars.githubusercontent.com/u/9465626?v=3","gravatar_id":"","url":"https://api.github.com/users/allencloud","html_url":"https://github.com/allencloud","followers_url":"https://api.github.com/users/allencloud/followers","following_url":"https://api.github.com/users/allencloud/following{/other_user}","gists_url":"https://api.github.com/users/allencloud/gists{/gist_id}","starred_url":"https://api.github.com/users/allencloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allencloud/subscriptions","organizations_url":"https://api.github.com/users/allencloud/orgs","repos_url":"https://api.github.com/users/allencloud/repos","events_url":"https://api.github.com/users/allencloud/events{/privacy}","received_events_url":"https://api.github.com/users/allencloud/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/allencloud/docker","description":"Docker - the open-source application container engine","fork":true,"url":"https://api.github.com/repos/allencloud/docker","forks_url":"https://api.github.com/repos/allencloud/docker/forks","keys_url":"https://api.github.com/repos/allencloud/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/allencloud/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/allencloud/docker/teams","hooks_url":"https://api.github.com/repos/allencloud/docker/hooks","issue_events_url":"https://api.github.com/repos/allencloud/docker/issues/events{/number}","events_url":"https://api.github.com/repos/allencloud/docker/events","assignees_url":"https://api.github.com/repos/allencloud/docker/assignees{/user}","branches_url":"https://api.github.com/repos/allencloud/docker/branches{/branch}","tags_url":"https://api.github.com/repos/allencloud/docker/tags","blobs_url":"https://api.github.com/repos/allencloud/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/allencloud/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/allencloud/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/allencloud/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/allencloud/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/allencloud/docker/languages","stargazers_url":"https://api.github.com/repos/allencloud/docker/stargazers","contributors_url":"https://api.github.com/repos/allencloud/docker/contributors","subscribers_url":"https://api.github.com/repos/allencloud/docker/subscribers","subscription_url":"https://api.github.com/repos/allencloud/docker/subscription","commits_url":"https://api.github.com/repos/allencloud/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/allencloud/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/allencloud/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/allencloud/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/allencloud/docker/contents/{+path}","compare_url":"https://api.github.com/repos/allencloud/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/allencloud/docker/merges","archive_url":"https://api.github.com/repos/allencloud/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/allencloud/docker/downloads","issues_url":"https://api.github.com/repos/allencloud/docker/issues{/number}","pulls_url":"https://api.github.com/repos/allencloud/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/allencloud/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/allencloud/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/allencloud/docker/labels{/name}","releases_url":"https://api.github.com/repos/allencloud/docker/releases{/id}","deployments_url":"https://api.github.com/repos/allencloud/docker/deployments","created_at":"2016-02-25T16:46:58Z","updated_at":"2016-11-01T15:21:59Z","pushed_at":"2016-11-18T09:50:18Z","git_url":"git://github.com/allencloud/docker.git","ssh_url":"git@github.com:allencloud/docker.git","clone_url":"https://github.com/allencloud/docker.git","svn_url":"https://github.com/allencloud/docker","homepage":"http://www.docker.com","size":112209,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"27699ba8b23217525b0b026fa689834db4454a35","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":7691631,"name":"docker","full_name":"docker/docker","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/docker","description":"Docker - the open-source application container engine","fork":false,"url":"https://api.github.com/repos/docker/docker","forks_url":"https://api.github.com/repos/docker/docker/forks","keys_url":"https://api.github.com/repos/docker/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/docker/teams","hooks_url":"https://api.github.com/repos/docker/docker/hooks","issue_events_url":"https://api.github.com/repos/docker/docker/issues/events{/number}","events_url":"https://api.github.com/repos/docker/docker/events","assignees_url":"https://api.github.com/repos/docker/docker/assignees{/user}","branches_url":"https://api.github.com/repos/docker/docker/branches{/branch}","tags_url":"https://api.github.com/repos/docker/docker/tags","blobs_url":"https://api.github.com/repos/docker/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/docker/languages","stargazers_url":"https://api.github.com/repos/docker/docker/stargazers","contributors_url":"https://api.github.com/repos/docker/docker/contributors","subscribers_url":"https://api.github.com/repos/docker/docker/subscribers","subscription_url":"https://api.github.com/repos/docker/docker/subscription","commits_url":"https://api.github.com/repos/docker/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/docker/contents/{+path}","compare_url":"https://api.github.com/repos/docker/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/docker/merges","archive_url":"https://api.github.com/repos/docker/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/docker/downloads","issues_url":"https://api.github.com/repos/docker/docker/issues{/number}","pulls_url":"https://api.github.com/repos/docker/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/docker/labels{/name}","releases_url":"https://api.github.com/repos/docker/docker/releases{/id}","deployments_url":"https://api.github.com/repos/docker/docker/deployments","created_at":"2013-01-18T18:10:57Z","updated_at":"2016-11-18T09:13:32Z","pushed_at":"2016-11-18T09:36:49Z","git_url":"git://github.com/docker/docker.git","ssh_url":"git@github.com:docker/docker.git","clone_url":"https://github.com/docker/docker.git","svn_url":"https://github.com/docker/docker","homepage":"http://www.docker.com","size":229504,"stargazers_count":36996,"watchers_count":36996,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10955,"mirror_url":null,"open_issues_count":1942,"forks":10955,"open_issues":1942,"watchers":36996,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/28578"},"html":{"href":"https://github.com/docker/docker/pull/28578"},"issue":{"href":"https://api.github.com/repos/docker/docker/issues/28578"},"comments":{"href":"https://api.github.com/repos/docker/docker/issues/28578/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/docker/pulls/28578/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/docker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/docker/pulls/28578/commits"},"statuses":{"href":"https://api.github.com/repos/docker/docker/statuses/3dca62cfb1e7c6404cb4730425919f66c680b409"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":0,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"allencloud"}}