{"action":"created","comment":{"url":"https://api.github.com/repos/almende/vis/pulls/comments/87694265","pull_request_review_id":8299072,"id":87694265,"diff_hunk":"@@ -148,7 +164,7 @@ Item.prototype.repositionY = function() {\n Item.prototype._repaintDeleteButton = function (anchor) {\n   var editable = (this.options.editable.remove &&\n                   this.options.editable.overrideItems)\n-                  || (this.data.editable === true &&\n+                  || (this.editable.remove &&\n                   !this.options.editable.overrideItems);","path":"lib/timeline/component/item/Item.js","position":50,"original_position":50,"commit_id":"7f0b987120ebe2bc6bc308d3c7a5dab50a94f985","original_commit_id":"7f0b987120ebe2bc6bc308d3c7a5dab50a94f985","user":{"login":"yotamberk","id":4319928,"avatar_url":"https://avatars.githubusercontent.com/u/4319928?v=3","gravatar_id":"","url":"https://api.github.com/users/yotamberk","html_url":"https://github.com/yotamberk","followers_url":"https://api.github.com/users/yotamberk/followers","following_url":"https://api.github.com/users/yotamberk/following{/other_user}","gists_url":"https://api.github.com/users/yotamberk/gists{/gist_id}","starred_url":"https://api.github.com/users/yotamberk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yotamberk/subscriptions","organizations_url":"https://api.github.com/users/yotamberk/orgs","repos_url":"https://api.github.com/users/yotamberk/repos","events_url":"https://api.github.com/users/yotamberk/events{/privacy}","received_events_url":"https://api.github.com/users/yotamberk/received_events","type":"User","site_admin":false},"body":"What about: `this.data.editable.remove && !this.options.editable.overrideItems`?","created_at":"2016-11-12T15:16:13Z","updated_at":"2016-11-12T15:18:48Z","html_url":"https://github.com/almende/vis/pull/2305#discussion_r87694265","pull_request_url":"https://api.github.com/repos/almende/vis/pulls/2305","_links":{"self":{"href":"https://api.github.com/repos/almende/vis/pulls/comments/87694265"},"html":{"href":"https://github.com/almende/vis/pull/2305#discussion_r87694265"},"pull_request":{"href":"https://api.github.com/repos/almende/vis/pulls/2305"}}},"pull_request":{"url":"https://api.github.com/repos/almende/vis/pulls/2305","id":93419737,"html_url":"https://github.com/almende/vis/pull/2305","diff_url":"https://github.com/almende/vis/pull/2305.diff","patch_url":"https://github.com/almende/vis/pull/2305.patch","issue_url":"https://api.github.com/repos/almende/vis/issues/2305","number":2305,"state":"open","locked":false,"title":"Timeline: More editable control","user":{"login":"simo9000","id":3857700,"avatar_url":"https://avatars.githubusercontent.com/u/3857700?v=3","gravatar_id":"","url":"https://api.github.com/users/simo9000","html_url":"https://github.com/simo9000","followers_url":"https://api.github.com/users/simo9000/followers","following_url":"https://api.github.com/users/simo9000/following{/other_user}","gists_url":"https://api.github.com/users/simo9000/gists{/gist_id}","starred_url":"https://api.github.com/users/simo9000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simo9000/subscriptions","organizations_url":"https://api.github.com/users/simo9000/orgs","repos_url":"https://api.github.com/users/simo9000/repos","events_url":"https://api.github.com/users/simo9000/events{/privacy}","received_events_url":"https://api.github.com/users/simo9000/received_events","type":"User","site_admin":false},"body":"I resisted the urge to do this but I didn't see a way around it. #2284 provided a clear means of decided when level of options was in control of the editable behavior of items. However it fell short in that when individual items are determined to be editable (and `overrideItems` is false), it enabled all three edit behaviors. This enables further control over individual item behavior but allowing `updateTime`, `updateGroup`, and `remove` to be toggled at the item level. I am glad I chose to pursue this as I found a bug which was introduced in #2284 where `timeline.editable == true` would also set `overrideItems` to true.","created_at":"2016-11-12T00:38:56Z","updated_at":"2016-11-12T15:18:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"98deb94452f148e055b67635ecd1e3452fa81bf3","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/almende/vis/pulls/2305/commits","review_comments_url":"https://api.github.com/repos/almende/vis/pulls/2305/comments","review_comment_url":"https://api.github.com/repos/almende/vis/pulls/comments{/number}","comments_url":"https://api.github.com/repos/almende/vis/issues/2305/comments","statuses_url":"https://api.github.com/repos/almende/vis/statuses/7f0b987120ebe2bc6bc308d3c7a5dab50a94f985","head":{"label":"simo9000:itemEditableOptions","ref":"itemEditableOptions","sha":"7f0b987120ebe2bc6bc308d3c7a5dab50a94f985","user":{"login":"simo9000","id":3857700,"avatar_url":"https://avatars.githubusercontent.com/u/3857700?v=3","gravatar_id":"","url":"https://api.github.com/users/simo9000","html_url":"https://github.com/simo9000","followers_url":"https://api.github.com/users/simo9000/followers","following_url":"https://api.github.com/users/simo9000/following{/other_user}","gists_url":"https://api.github.com/users/simo9000/gists{/gist_id}","starred_url":"https://api.github.com/users/simo9000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simo9000/subscriptions","organizations_url":"https://api.github.com/users/simo9000/orgs","repos_url":"https://api.github.com/users/simo9000/repos","events_url":"https://api.github.com/users/simo9000/events{/privacy}","received_events_url":"https://api.github.com/users/simo9000/received_events","type":"User","site_admin":false},"repo":{"id":72659265,"name":"vis","full_name":"simo9000/vis","owner":{"login":"simo9000","id":3857700,"avatar_url":"https://avatars.githubusercontent.com/u/3857700?v=3","gravatar_id":"","url":"https://api.github.com/users/simo9000","html_url":"https://github.com/simo9000","followers_url":"https://api.github.com/users/simo9000/followers","following_url":"https://api.github.com/users/simo9000/following{/other_user}","gists_url":"https://api.github.com/users/simo9000/gists{/gist_id}","starred_url":"https://api.github.com/users/simo9000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simo9000/subscriptions","organizations_url":"https://api.github.com/users/simo9000/orgs","repos_url":"https://api.github.com/users/simo9000/repos","events_url":"https://api.github.com/users/simo9000/events{/privacy}","received_events_url":"https://api.github.com/users/simo9000/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/simo9000/vis","description":"Dynamic, browser-based visualization library","fork":true,"url":"https://api.github.com/repos/simo9000/vis","forks_url":"https://api.github.com/repos/simo9000/vis/forks","keys_url":"https://api.github.com/repos/simo9000/vis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/simo9000/vis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/simo9000/vis/teams","hooks_url":"https://api.github.com/repos/simo9000/vis/hooks","issue_events_url":"https://api.github.com/repos/simo9000/vis/issues/events{/number}","events_url":"https://api.github.com/repos/simo9000/vis/events","assignees_url":"https://api.github.com/repos/simo9000/vis/assignees{/user}","branches_url":"https://api.github.com/repos/simo9000/vis/branches{/branch}","tags_url":"https://api.github.com/repos/simo9000/vis/tags","blobs_url":"https://api.github.com/repos/simo9000/vis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/simo9000/vis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/simo9000/vis/git/refs{/sha}","trees_url":"https://api.github.com/repos/simo9000/vis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/simo9000/vis/statuses/{sha}","languages_url":"https://api.github.com/repos/simo9000/vis/languages","stargazers_url":"https://api.github.com/repos/simo9000/vis/stargazers","contributors_url":"https://api.github.com/repos/simo9000/vis/contributors","subscribers_url":"https://api.github.com/repos/simo9000/vis/subscribers","subscription_url":"https://api.github.com/repos/simo9000/vis/subscription","commits_url":"https://api.github.com/repos/simo9000/vis/commits{/sha}","git_commits_url":"https://api.github.com/repos/simo9000/vis/git/commits{/sha}","comments_url":"https://api.github.com/repos/simo9000/vis/comments{/number}","issue_comment_url":"https://api.github.com/repos/simo9000/vis/issues/comments{/number}","contents_url":"https://api.github.com/repos/simo9000/vis/contents/{+path}","compare_url":"https://api.github.com/repos/simo9000/vis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/simo9000/vis/merges","archive_url":"https://api.github.com/repos/simo9000/vis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/simo9000/vis/downloads","issues_url":"https://api.github.com/repos/simo9000/vis/issues{/number}","pulls_url":"https://api.github.com/repos/simo9000/vis/pulls{/number}","milestones_url":"https://api.github.com/repos/simo9000/vis/milestones{/number}","notifications_url":"https://api.github.com/repos/simo9000/vis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/simo9000/vis/labels{/name}","releases_url":"https://api.github.com/repos/simo9000/vis/releases{/id}","deployments_url":"https://api.github.com/repos/simo9000/vis/deployments","created_at":"2016-11-02T16:28:15Z","updated_at":"2016-11-02T19:07:32Z","pushed_at":"2016-11-12T00:28:45Z","git_url":"git://github.com/simo9000/vis.git","ssh_url":"git@github.com:simo9000/vis.git","clone_url":"https://github.com/simo9000/vis.git","svn_url":"https://github.com/simo9000/vis","homepage":"http://visjs.org","size":129461,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"almende:develop","ref":"develop","sha":"9310b22ff995f0cea0e24d32cfcb8a3071fab1c4","user":{"login":"almende","id":1436571,"avatar_url":"https://avatars.githubusercontent.com/u/1436571?v=3","gravatar_id":"","url":"https://api.github.com/users/almende","html_url":"https://github.com/almende","followers_url":"https://api.github.com/users/almende/followers","following_url":"https://api.github.com/users/almende/following{/other_user}","gists_url":"https://api.github.com/users/almende/gists{/gist_id}","starred_url":"https://api.github.com/users/almende/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/almende/subscriptions","organizations_url":"https://api.github.com/users/almende/orgs","repos_url":"https://api.github.com/users/almende/repos","events_url":"https://api.github.com/users/almende/events{/privacy}","received_events_url":"https://api.github.com/users/almende/received_events","type":"Organization","site_admin":false},"repo":{"id":9467421,"name":"vis","full_name":"almende/vis","owner":{"login":"almende","id":1436571,"avatar_url":"https://avatars.githubusercontent.com/u/1436571?v=3","gravatar_id":"","url":"https://api.github.com/users/almende","html_url":"https://github.com/almende","followers_url":"https://api.github.com/users/almende/followers","following_url":"https://api.github.com/users/almende/following{/other_user}","gists_url":"https://api.github.com/users/almende/gists{/gist_id}","starred_url":"https://api.github.com/users/almende/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/almende/subscriptions","organizations_url":"https://api.github.com/users/almende/orgs","repos_url":"https://api.github.com/users/almende/repos","events_url":"https://api.github.com/users/almende/events{/privacy}","received_events_url":"https://api.github.com/users/almende/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/almende/vis","description":"Dynamic, browser-based visualization library","fork":false,"url":"https://api.github.com/repos/almende/vis","forks_url":"https://api.github.com/repos/almende/vis/forks","keys_url":"https://api.github.com/repos/almende/vis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/almende/vis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/almende/vis/teams","hooks_url":"https://api.github.com/repos/almende/vis/hooks","issue_events_url":"https://api.github.com/repos/almende/vis/issues/events{/number}","events_url":"https://api.github.com/repos/almende/vis/events","assignees_url":"https://api.github.com/repos/almende/vis/assignees{/user}","branches_url":"https://api.github.com/repos/almende/vis/branches{/branch}","tags_url":"https://api.github.com/repos/almende/vis/tags","blobs_url":"https://api.github.com/repos/almende/vis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/almende/vis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/almende/vis/git/refs{/sha}","trees_url":"https://api.github.com/repos/almende/vis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/almende/vis/statuses/{sha}","languages_url":"https://api.github.com/repos/almende/vis/languages","stargazers_url":"https://api.github.com/repos/almende/vis/stargazers","contributors_url":"https://api.github.com/repos/almende/vis/contributors","subscribers_url":"https://api.github.com/repos/almende/vis/subscribers","subscription_url":"https://api.github.com/repos/almende/vis/subscription","commits_url":"https://api.github.com/repos/almende/vis/commits{/sha}","git_commits_url":"https://api.github.com/repos/almende/vis/git/commits{/sha}","comments_url":"https://api.github.com/repos/almende/vis/comments{/number}","issue_comment_url":"https://api.github.com/repos/almende/vis/issues/comments{/number}","contents_url":"https://api.github.com/repos/almende/vis/contents/{+path}","compare_url":"https://api.github.com/repos/almende/vis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/almende/vis/merges","archive_url":"https://api.github.com/repos/almende/vis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/almende/vis/downloads","issues_url":"https://api.github.com/repos/almende/vis/issues{/number}","pulls_url":"https://api.github.com/repos/almende/vis/pulls{/number}","milestones_url":"https://api.github.com/repos/almende/vis/milestones{/number}","notifications_url":"https://api.github.com/repos/almende/vis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/almende/vis/labels{/name}","releases_url":"https://api.github.com/repos/almende/vis/releases{/id}","deployments_url":"https://api.github.com/repos/almende/vis/deployments","created_at":"2013-04-16T08:01:02Z","updated_at":"2016-11-11T14:22:26Z","pushed_at":"2016-11-12T00:38:56Z","git_url":"git://github.com/almende/vis.git","ssh_url":"git@github.com:almende/vis.git","clone_url":"https://github.com/almende/vis.git","svn_url":"https://github.com/almende/vis","homepage":"http://visjs.org","size":135397,"stargazers_count":4377,"watchers_count":4377,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":731,"mirror_url":null,"open_issues_count":352,"forks":731,"open_issues":352,"watchers":4377,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/almende/vis/pulls/2305"},"html":{"href":"https://github.com/almende/vis/pull/2305"},"issue":{"href":"https://api.github.com/repos/almende/vis/issues/2305"},"comments":{"href":"https://api.github.com/repos/almende/vis/issues/2305/comments"},"review_comments":{"href":"https://api.github.com/repos/almende/vis/pulls/2305/comments"},"review_comment":{"href":"https://api.github.com/repos/almende/vis/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/almende/vis/pulls/2305/commits"},"statuses":{"href":"https://api.github.com/repos/almende/vis/statuses/7f0b987120ebe2bc6bc308d3c7a5dab50a94f985"}}}}
{"actor":{"display_login":"yotamberk"}}