{"action":"closed","issue":{"url":"https://api.github.com/repos/csound/csound/issues/698","repository_url":"https://api.github.com/repos/csound/csound","labels_url":"https://api.github.com/repos/csound/csound/issues/698/labels{/name}","comments_url":"https://api.github.com/repos/csound/csound/issues/698/comments","events_url":"https://api.github.com/repos/csound/csound/issues/698/events","html_url":"https://github.com/csound/csound/issues/698","id":176378611,"number":698,"title":"CMakeLists.txt includes CUSTOM_CMAKE unconditionally and too early","user":{"login":"fsateler","id":1322013,"avatar_url":"https://avatars.githubusercontent.com/u/1322013?v=3","gravatar_id":"","url":"https://api.github.com/users/fsateler","html_url":"https://github.com/fsateler","followers_url":"https://api.github.com/users/fsateler/followers","following_url":"https://api.github.com/users/fsateler/following{/other_user}","gists_url":"https://api.github.com/users/fsateler/gists{/gist_id}","starred_url":"https://api.github.com/users/fsateler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fsateler/subscriptions","organizations_url":"https://api.github.com/users/fsateler/orgs","repos_url":"https://api.github.com/users/fsateler/repos","events_url":"https://api.github.com/users/fsateler/events{/privacy}","received_events_url":"https://api.github.com/users/fsateler/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/csound/csound/labels/bug","name":"bug","color":"fc2929"}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-09-12T13:43:11Z","updated_at":"2016-09-12T18:16:59Z","closed_at":"2016-09-12T18:16:59Z","body":"In commit 865cf0fc1d7a584f8b74e2cd6034425fcea43e24 , a second inclusion of CUSTOM_CMAKE was added at the very top of `CMakeLists.txt`. I'm sure that enables fixing stuff, but the solution is incorrect:\r\n\r\n1. It is loaded before CUSTOM_CMAKE is defined, thus can only possibly work on a second cmake invocation.\r\n2. It is loaded too early, and thus a user Custom.cmake cannot use functions/macros defined by the build system (eg, add_compiler_flags), as they would break due to being undefined when running a second cmake invocation.\r\n\r\nI think this should be removed. However, I do not know what was the problem this solved, so I can't propose an alternative solution that does not reintroduce a problem. The commit message says it helps building in msys64, is this still the case?\r\n\r\ncc @gogins "}}
{"actor":{"display_login":"fsateler"}}