{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/56392664","id":56392664,"diff_hunk":"@@ -24,11 +24,17 @@ source \"${KUBE_ROOT}/hack/lib/init.sh\"\n kube::golang::setup_env\n \n # add other BADSYMBOLS here.\n-BADSYMBOLS=\"testing[.]\"\n+BADSYMBOLS=(\n+  \"httptest\"\n+  \"testify\"\n+  \"testing[.]\"\n+)\n+# Join symbols with OR '\\|' pattern\n+PATTERN=\"$(printf '\\|%s' \"${BADSYMBOLS[@]}\" | tail -c +3)\"\n \n # b/c hyperkube binds everything simply check that for bad symbols\n-if [[ $(nm ${KUBE_OUTPUT_HOSTBIN}/hyperkube | grep \"${BADSYMBOLS}\") ]]; then\n-  echo \"output binaries contain bad symbols \\\"${BADSYMBOLS}\\\"\"\n+if nm ${KUBE_OUTPUT_HOSTBIN}/hyperkube | grep \"${PATTERN}\"; then\n+  echo \"output binaries contain bad symbols\"","path":"hack/after-build/verify-symbols.sh","position":17,"original_position":17,"commit_id":"a93b67fe9795e88f21b6576bdcfcccbb8fccfa08","original_commit_id":"a93b67fe9795e88f21b6576bdcfcccbb8fccfa08","user":{"login":"timothysc","id":169553,"avatar_url":"https://avatars.githubusercontent.com/u/169553?v=3","gravatar_id":"","url":"https://api.github.com/users/timothysc","html_url":"https://github.com/timothysc","followers_url":"https://api.github.com/users/timothysc/followers","following_url":"https://api.github.com/users/timothysc/following{/other_user}","gists_url":"https://api.github.com/users/timothysc/gists{/gist_id}","starred_url":"https://api.github.com/users/timothysc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timothysc/subscriptions","organizations_url":"https://api.github.com/users/timothysc/orgs","repos_url":"https://api.github.com/users/timothysc/repos","events_url":"https://api.github.com/users/timothysc/events{/privacy}","received_events_url":"https://api.github.com/users/timothysc/received_events","type":"User","site_admin":false},"body":"I think developers will only care about what symbols have been found, the ```nm``` grep is pretty gritty.    ","created_at":"2016-03-16T18:46:47Z","updated_at":"2016-03-16T18:46:47Z","html_url":"https://github.com/kubernetes/kubernetes/pull/23016#discussion_r56392664","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/23016","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/56392664"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/23016#discussion_r56392664"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/23016"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/23016","id":62989180,"html_url":"https://github.com/kubernetes/kubernetes/pull/23016","diff_url":"https://github.com/kubernetes/kubernetes/pull/23016.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/23016.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/23016","number":23016,"state":"closed","locked":false,"title":"Add \"testify\" and \"httptest\" to the bad symbols check","user":{"login":"timstclair","id":3272040,"avatar_url":"https://avatars.githubusercontent.com/u/3272040?v=3","gravatar_id":"","url":"https://api.github.com/users/timstclair","html_url":"https://github.com/timstclair","followers_url":"https://api.github.com/users/timstclair/followers","following_url":"https://api.github.com/users/timstclair/following{/other_user}","gists_url":"https://api.github.com/users/timstclair/gists{/gist_id}","starred_url":"https://api.github.com/users/timstclair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timstclair/subscriptions","organizations_url":"https://api.github.com/users/timstclair/orgs","repos_url":"https://api.github.com/users/timstclair/repos","events_url":"https://api.github.com/users/timstclair/events{/privacy}","received_events_url":"https://api.github.com/users/timstclair/received_events","type":"User","site_admin":false},"body":"To prevent https://github.com/kubernetes/kubernetes/issues/21114\r\n\r\n/cc @timothysc ","created_at":"2016-03-15T22:43:44Z","updated_at":"2016-03-16T18:46:47Z","closed_at":"2016-03-15T23:56:33Z","merged_at":"2016-03-15T23:56:33Z","merge_commit_sha":"4b513c5ce90863fdf1c4d9f8eaf10970c2b8e153","assignee":{"login":"lavalamp","id":647318,"avatar_url":"https://avatars.githubusercontent.com/u/647318?v=3","gravatar_id":"","url":"https://api.github.com/users/lavalamp","html_url":"https://github.com/lavalamp","followers_url":"https://api.github.com/users/lavalamp/followers","following_url":"https://api.github.com/users/lavalamp/following{/other_user}","gists_url":"https://api.github.com/users/lavalamp/gists{/gist_id}","starred_url":"https://api.github.com/users/lavalamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lavalamp/subscriptions","organizations_url":"https://api.github.com/users/lavalamp/orgs","repos_url":"https://api.github.com/users/lavalamp/repos","events_url":"https://api.github.com/users/lavalamp/events{/privacy}","received_events_url":"https://api.github.com/users/lavalamp/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/23016/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/23016/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/23016/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/a93b67fe9795e88f21b6576bdcfcccbb8fccfa08","head":{"label":"timstclair:test-isolation","ref":"test-isolation","sha":"a93b67fe9795e88f21b6576bdcfcccbb8fccfa08","user":{"login":"timstclair","id":3272040,"avatar_url":"https://avatars.githubusercontent.com/u/3272040?v=3","gravatar_id":"","url":"https://api.github.com/users/timstclair","html_url":"https://github.com/timstclair","followers_url":"https://api.github.com/users/timstclair/followers","following_url":"https://api.github.com/users/timstclair/following{/other_user}","gists_url":"https://api.github.com/users/timstclair/gists{/gist_id}","starred_url":"https://api.github.com/users/timstclair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timstclair/subscriptions","organizations_url":"https://api.github.com/users/timstclair/orgs","repos_url":"https://api.github.com/users/timstclair/repos","events_url":"https://api.github.com/users/timstclair/events{/privacy}","received_events_url":"https://api.github.com/users/timstclair/received_events","type":"User","site_admin":false},"repo":{"id":36760336,"name":"kubernetes","full_name":"timstclair/kubernetes","owner":{"login":"timstclair","id":3272040,"avatar_url":"https://avatars.githubusercontent.com/u/3272040?v=3","gravatar_id":"","url":"https://api.github.com/users/timstclair","html_url":"https://github.com/timstclair","followers_url":"https://api.github.com/users/timstclair/followers","following_url":"https://api.github.com/users/timstclair/following{/other_user}","gists_url":"https://api.github.com/users/timstclair/gists{/gist_id}","starred_url":"https://api.github.com/users/timstclair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timstclair/subscriptions","organizations_url":"https://api.github.com/users/timstclair/orgs","repos_url":"https://api.github.com/users/timstclair/repos","events_url":"https://api.github.com/users/timstclair/events{/privacy}","received_events_url":"https://api.github.com/users/timstclair/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/timstclair/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/timstclair/kubernetes","forks_url":"https://api.github.com/repos/timstclair/kubernetes/forks","keys_url":"https://api.github.com/repos/timstclair/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/timstclair/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/timstclair/kubernetes/teams","hooks_url":"https://api.github.com/repos/timstclair/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/timstclair/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/timstclair/kubernetes/events","assignees_url":"https://api.github.com/repos/timstclair/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/timstclair/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/timstclair/kubernetes/tags","blobs_url":"https://api.github.com/repos/timstclair/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/timstclair/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/timstclair/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/timstclair/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/timstclair/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/timstclair/kubernetes/languages","stargazers_url":"https://api.github.com/repos/timstclair/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/timstclair/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/timstclair/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/timstclair/kubernetes/subscription","commits_url":"https://api.github.com/repos/timstclair/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/timstclair/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/timstclair/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/timstclair/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/timstclair/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/timstclair/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/timstclair/kubernetes/merges","archive_url":"https://api.github.com/repos/timstclair/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/timstclair/kubernetes/downloads","issues_url":"https://api.github.com/repos/timstclair/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/timstclair/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/timstclair/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/timstclair/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/timstclair/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/timstclair/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/timstclair/kubernetes/deployments","created_at":"2015-06-02T20:36:50Z","updated_at":"2016-01-26T01:27:39Z","pushed_at":"2016-03-15T22:41:09Z","git_url":"git://github.com/timstclair/kubernetes.git","ssh_url":"git@github.com:timstclair/kubernetes.git","clone_url":"https://github.com/timstclair/kubernetes.git","svn_url":"https://github.com/timstclair/kubernetes","homepage":"http://kubernetes.io","size":178842,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"204d426dd3a2dcbe789f1af1e405ddf9973e52ab","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-03-16T18:16:29Z","pushed_at":"2016-03-16T18:44:12Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":342226,"stargazers_count":13268,"watchers_count":13268,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3833,"mirror_url":null,"open_issues_count":3002,"forks":3833,"open_issues":3002,"watchers":13268,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/23016"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/23016"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/23016"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/23016/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/23016/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/23016/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/a93b67fe9795e88f21b6576bdcfcccbb8fccfa08"}}}}