{"action":"created","comment":{"url":"https://api.github.com/repos/tomprogrammer/rust-ascii/pulls/comments/68221351","id":68221351,"diff_hunk":"@@ -1,12 +1,17 @@\n Unreleased\n ==========\n-* Convert `Ascii` into an enum with a variant for every ASCII character.\n+* Convert `Ascii` into an enum with a variant for every ASCII character and rename it to `AsciiChar`.\n+* Replace `OwnedAsciiCast` with `IntoAsciiString`.\n+* Replace `AsciiCast` with `AsAsciiStr` and `IntoAsciiChar`.\n+* Replace *\\_nocheck* with *\\_unchecked*, and *from_bytes* with *from_ascii* in method names.\n+* Return `std::error::Error` implementing types on error.\n+* Implement `AsciiExt` without the `unstable` Cargo feature flag, which is  removed.\n+* Require Rust 1.9 or later.","path":"RELEASES.md","position":10,"original_position":10,"commit_id":"d9f7787bda4a6a6c9ee07b1e2a84d88892af31e9","original_commit_id":"d9f7787bda4a6a6c9ee07b1e2a84d88892af31e9","user":{"login":"tomprogrammer","id":57975,"avatar_url":"https://avatars.githubusercontent.com/u/57975?v=3","gravatar_id":"","url":"https://api.github.com/users/tomprogrammer","html_url":"https://github.com/tomprogrammer","followers_url":"https://api.github.com/users/tomprogrammer/followers","following_url":"https://api.github.com/users/tomprogrammer/following{/other_user}","gists_url":"https://api.github.com/users/tomprogrammer/gists{/gist_id}","starred_url":"https://api.github.com/users/tomprogrammer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomprogrammer/subscriptions","organizations_url":"https://api.github.com/users/tomprogrammer/orgs","repos_url":"https://api.github.com/users/tomprogrammer/repos","events_url":"https://api.github.com/users/tomprogrammer/events{/privacy}","received_events_url":"https://api.github.com/users/tomprogrammer/received_events","type":"User","site_admin":false},"body":"We probably should put this requirement to the top, for easy perception.","created_at":"2016-06-23T11:56:11Z","updated_at":"2016-06-23T11:56:11Z","html_url":"https://github.com/tomprogrammer/rust-ascii/pull/19#discussion_r68221351","pull_request_url":"https://api.github.com/repos/tomprogrammer/rust-ascii/pulls/19","_links":{"self":{"href":"https://api.github.com/repos/tomprogrammer/rust-ascii/pulls/comments/68221351"},"html":{"href":"https://github.com/tomprogrammer/rust-ascii/pull/19#discussion_r68221351"},"pull_request":{"href":"https://api.github.com/repos/tomprogrammer/rust-ascii/pulls/19"}}},"pull_request":{"url":"https://api.github.com/repos/tomprogrammer/rust-ascii/pulls/19","id":69284175,"html_url":"https://github.com/tomprogrammer/rust-ascii/pull/19","diff_url":"https://github.com/tomprogrammer/rust-ascii/pull/19.diff","patch_url":"https://github.com/tomprogrammer/rust-ascii/pull/19.patch","issue_url":"https://api.github.com/repos/tomprogrammer/rust-ascii/issues/19","number":19,"state":"open","locked":false,"title":"Breaking changes","user":{"login":"tormol","id":10460821,"avatar_url":"https://avatars.githubusercontent.com/u/10460821?v=3","gravatar_id":"","url":"https://api.github.com/users/tormol","html_url":"https://github.com/tormol","followers_url":"https://api.github.com/users/tormol/followers","following_url":"https://api.github.com/users/tormol/following{/other_user}","gists_url":"https://api.github.com/users/tormol/gists{/gist_id}","starred_url":"https://api.github.com/users/tormol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tormol/subscriptions","organizations_url":"https://api.github.com/users/tormol/orgs","repos_url":"https://api.github.com/users/tormol/repos","events_url":"https://api.github.com/users/tormol/events{/privacy}","received_events_url":"https://api.github.com/users/tormol/received_events","type":"User","site_admin":false},"body":"Breaking changes on top of into_ascii that shouldn't be accepted until 1.9 is stable.\r\n\r\nWhat do you think about renaming `Ascii` to `AsciiChar`? It fells more correct but is longer.\r\n\r\nI couldn't get `AsciiStr::from{_unchecked}()` to be as generic as I want to, so I removed them for now.\r\nYou can see my attempt at `::from` in my [broken branch](https://github.com/tormol/rust-ascii/tree/broken).","created_at":"2016-05-09T00:06:13Z","updated_at":"2016-06-23T11:56:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"16d98d0af314df94ce9c9680c69d074ad4239088","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/tomprogrammer/rust-ascii/pulls/19/commits","review_comments_url":"https://api.github.com/repos/tomprogrammer/rust-ascii/pulls/19/comments","review_comment_url":"https://api.github.com/repos/tomprogrammer/rust-ascii/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tomprogrammer/rust-ascii/issues/19/comments","statuses_url":"https://api.github.com/repos/tomprogrammer/rust-ascii/statuses/d9f7787bda4a6a6c9ee07b1e2a84d88892af31e9","head":{"label":"tormol:breaking","ref":"breaking","sha":"d9f7787bda4a6a6c9ee07b1e2a84d88892af31e9","user":{"login":"tormol","id":10460821,"avatar_url":"https://avatars.githubusercontent.com/u/10460821?v=3","gravatar_id":"","url":"https://api.github.com/users/tormol","html_url":"https://github.com/tormol","followers_url":"https://api.github.com/users/tormol/followers","following_url":"https://api.github.com/users/tormol/following{/other_user}","gists_url":"https://api.github.com/users/tormol/gists{/gist_id}","starred_url":"https://api.github.com/users/tormol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tormol/subscriptions","organizations_url":"https://api.github.com/users/tormol/orgs","repos_url":"https://api.github.com/users/tormol/repos","events_url":"https://api.github.com/users/tormol/events{/privacy}","received_events_url":"https://api.github.com/users/tormol/received_events","type":"User","site_admin":false},"repo":{"id":54791580,"name":"rust-ascii","full_name":"tormol/rust-ascii","owner":{"login":"tormol","id":10460821,"avatar_url":"https://avatars.githubusercontent.com/u/10460821?v=3","gravatar_id":"","url":"https://api.github.com/users/tormol","html_url":"https://github.com/tormol","followers_url":"https://api.github.com/users/tormol/followers","following_url":"https://api.github.com/users/tormol/following{/other_user}","gists_url":"https://api.github.com/users/tormol/gists{/gist_id}","starred_url":"https://api.github.com/users/tormol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tormol/subscriptions","organizations_url":"https://api.github.com/users/tormol/orgs","repos_url":"https://api.github.com/users/tormol/repos","events_url":"https://api.github.com/users/tormol/events{/privacy}","received_events_url":"https://api.github.com/users/tormol/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tormol/rust-ascii","description":"A string which guarantees it's content is ascii encoded","fork":true,"url":"https://api.github.com/repos/tormol/rust-ascii","forks_url":"https://api.github.com/repos/tormol/rust-ascii/forks","keys_url":"https://api.github.com/repos/tormol/rust-ascii/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tormol/rust-ascii/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tormol/rust-ascii/teams","hooks_url":"https://api.github.com/repos/tormol/rust-ascii/hooks","issue_events_url":"https://api.github.com/repos/tormol/rust-ascii/issues/events{/number}","events_url":"https://api.github.com/repos/tormol/rust-ascii/events","assignees_url":"https://api.github.com/repos/tormol/rust-ascii/assignees{/user}","branches_url":"https://api.github.com/repos/tormol/rust-ascii/branches{/branch}","tags_url":"https://api.github.com/repos/tormol/rust-ascii/tags","blobs_url":"https://api.github.com/repos/tormol/rust-ascii/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tormol/rust-ascii/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tormol/rust-ascii/git/refs{/sha}","trees_url":"https://api.github.com/repos/tormol/rust-ascii/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tormol/rust-ascii/statuses/{sha}","languages_url":"https://api.github.com/repos/tormol/rust-ascii/languages","stargazers_url":"https://api.github.com/repos/tormol/rust-ascii/stargazers","contributors_url":"https://api.github.com/repos/tormol/rust-ascii/contributors","subscribers_url":"https://api.github.com/repos/tormol/rust-ascii/subscribers","subscription_url":"https://api.github.com/repos/tormol/rust-ascii/subscription","commits_url":"https://api.github.com/repos/tormol/rust-ascii/commits{/sha}","git_commits_url":"https://api.github.com/repos/tormol/rust-ascii/git/commits{/sha}","comments_url":"https://api.github.com/repos/tormol/rust-ascii/comments{/number}","issue_comment_url":"https://api.github.com/repos/tormol/rust-ascii/issues/comments{/number}","contents_url":"https://api.github.com/repos/tormol/rust-ascii/contents/{+path}","compare_url":"https://api.github.com/repos/tormol/rust-ascii/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tormol/rust-ascii/merges","archive_url":"https://api.github.com/repos/tormol/rust-ascii/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tormol/rust-ascii/downloads","issues_url":"https://api.github.com/repos/tormol/rust-ascii/issues{/number}","pulls_url":"https://api.github.com/repos/tormol/rust-ascii/pulls{/number}","milestones_url":"https://api.github.com/repos/tormol/rust-ascii/milestones{/number}","notifications_url":"https://api.github.com/repos/tormol/rust-ascii/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tormol/rust-ascii/labels{/name}","releases_url":"https://api.github.com/repos/tormol/rust-ascii/releases{/id}","deployments_url":"https://api.github.com/repos/tormol/rust-ascii/deployments","created_at":"2016-03-26T17:47:16Z","updated_at":"2016-05-09T01:00:45Z","pushed_at":"2016-06-09T19:19:01Z","git_url":"git://github.com/tormol/rust-ascii.git","ssh_url":"git@github.com:tormol/rust-ascii.git","clone_url":"https://github.com/tormol/rust-ascii.git","svn_url":"https://github.com/tormol/rust-ascii","homepage":"","size":747,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tomprogrammer:master","ref":"master","sha":"bd110bf5e8a3b15682e782edea0b55f10f345174","user":{"login":"tomprogrammer","id":57975,"avatar_url":"https://avatars.githubusercontent.com/u/57975?v=3","gravatar_id":"","url":"https://api.github.com/users/tomprogrammer","html_url":"https://github.com/tomprogrammer","followers_url":"https://api.github.com/users/tomprogrammer/followers","following_url":"https://api.github.com/users/tomprogrammer/following{/other_user}","gists_url":"https://api.github.com/users/tomprogrammer/gists{/gist_id}","starred_url":"https://api.github.com/users/tomprogrammer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomprogrammer/subscriptions","organizations_url":"https://api.github.com/users/tomprogrammer/orgs","repos_url":"https://api.github.com/users/tomprogrammer/repos","events_url":"https://api.github.com/users/tomprogrammer/events{/privacy}","received_events_url":"https://api.github.com/users/tomprogrammer/received_events","type":"User","site_admin":false},"repo":{"id":27228444,"name":"rust-ascii","full_name":"tomprogrammer/rust-ascii","owner":{"login":"tomprogrammer","id":57975,"avatar_url":"https://avatars.githubusercontent.com/u/57975?v=3","gravatar_id":"","url":"https://api.github.com/users/tomprogrammer","html_url":"https://github.com/tomprogrammer","followers_url":"https://api.github.com/users/tomprogrammer/followers","following_url":"https://api.github.com/users/tomprogrammer/following{/other_user}","gists_url":"https://api.github.com/users/tomprogrammer/gists{/gist_id}","starred_url":"https://api.github.com/users/tomprogrammer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomprogrammer/subscriptions","organizations_url":"https://api.github.com/users/tomprogrammer/orgs","repos_url":"https://api.github.com/users/tomprogrammer/repos","events_url":"https://api.github.com/users/tomprogrammer/events{/privacy}","received_events_url":"https://api.github.com/users/tomprogrammer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tomprogrammer/rust-ascii","description":"A string which guarantees it's content is ascii encoded","fork":false,"url":"https://api.github.com/repos/tomprogrammer/rust-ascii","forks_url":"https://api.github.com/repos/tomprogrammer/rust-ascii/forks","keys_url":"https://api.github.com/repos/tomprogrammer/rust-ascii/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tomprogrammer/rust-ascii/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tomprogrammer/rust-ascii/teams","hooks_url":"https://api.github.com/repos/tomprogrammer/rust-ascii/hooks","issue_events_url":"https://api.github.com/repos/tomprogrammer/rust-ascii/issues/events{/number}","events_url":"https://api.github.com/repos/tomprogrammer/rust-ascii/events","assignees_url":"https://api.github.com/repos/tomprogrammer/rust-ascii/assignees{/user}","branches_url":"https://api.github.com/repos/tomprogrammer/rust-ascii/branches{/branch}","tags_url":"https://api.github.com/repos/tomprogrammer/rust-ascii/tags","blobs_url":"https://api.github.com/repos/tomprogrammer/rust-ascii/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tomprogrammer/rust-ascii/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tomprogrammer/rust-ascii/git/refs{/sha}","trees_url":"https://api.github.com/repos/tomprogrammer/rust-ascii/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tomprogrammer/rust-ascii/statuses/{sha}","languages_url":"https://api.github.com/repos/tomprogrammer/rust-ascii/languages","stargazers_url":"https://api.github.com/repos/tomprogrammer/rust-ascii/stargazers","contributors_url":"https://api.github.com/repos/tomprogrammer/rust-ascii/contributors","subscribers_url":"https://api.github.com/repos/tomprogrammer/rust-ascii/subscribers","subscription_url":"https://api.github.com/repos/tomprogrammer/rust-ascii/subscription","commits_url":"https://api.github.com/repos/tomprogrammer/rust-ascii/commits{/sha}","git_commits_url":"https://api.github.com/repos/tomprogrammer/rust-ascii/git/commits{/sha}","comments_url":"https://api.github.com/repos/tomprogrammer/rust-ascii/comments{/number}","issue_comment_url":"https://api.github.com/repos/tomprogrammer/rust-ascii/issues/comments{/number}","contents_url":"https://api.github.com/repos/tomprogrammer/rust-ascii/contents/{+path}","compare_url":"https://api.github.com/repos/tomprogrammer/rust-ascii/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tomprogrammer/rust-ascii/merges","archive_url":"https://api.github.com/repos/tomprogrammer/rust-ascii/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tomprogrammer/rust-ascii/downloads","issues_url":"https://api.github.com/repos/tomprogrammer/rust-ascii/issues{/number}","pulls_url":"https://api.github.com/repos/tomprogrammer/rust-ascii/pulls{/number}","milestones_url":"https://api.github.com/repos/tomprogrammer/rust-ascii/milestones{/number}","notifications_url":"https://api.github.com/repos/tomprogrammer/rust-ascii/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tomprogrammer/rust-ascii/labels{/name}","releases_url":"https://api.github.com/repos/tomprogrammer/rust-ascii/releases{/id}","deployments_url":"https://api.github.com/repos/tomprogrammer/rust-ascii/deployments","created_at":"2014-11-27T14:20:33Z","updated_at":"2016-02-18T03:01:50Z","pushed_at":"2016-06-09T19:19:01Z","git_url":"git://github.com/tomprogrammer/rust-ascii.git","ssh_url":"git@github.com:tomprogrammer/rust-ascii.git","clone_url":"https://github.com/tomprogrammer/rust-ascii.git","svn_url":"https://github.com/tomprogrammer/rust-ascii","homepage":"","size":757,"stargazers_count":6,"watchers_count":6,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5,"mirror_url":null,"open_issues_count":3,"forks":5,"open_issues":3,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tomprogrammer/rust-ascii/pulls/19"},"html":{"href":"https://github.com/tomprogrammer/rust-ascii/pull/19"},"issue":{"href":"https://api.github.com/repos/tomprogrammer/rust-ascii/issues/19"},"comments":{"href":"https://api.github.com/repos/tomprogrammer/rust-ascii/issues/19/comments"},"review_comments":{"href":"https://api.github.com/repos/tomprogrammer/rust-ascii/pulls/19/comments"},"review_comment":{"href":"https://api.github.com/repos/tomprogrammer/rust-ascii/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tomprogrammer/rust-ascii/pulls/19/commits"},"statuses":{"href":"https://api.github.com/repos/tomprogrammer/rust-ascii/statuses/d9f7787bda4a6a6c9ee07b1e2a84d88892af31e9"}}}}
{"actor":{"display_login":"tomprogrammer"}}