{"action":"created","comment":{"url":"https://api.github.com/repos/pfsense/pfsense/pulls/comments/91299384","pull_request_review_id":11806291,"id":91299384,"diff_hunk":"@@ -0,0 +1,113 @@\n+#!/bin/sh\n+#\n+# rc.restore_ramdisk_store","path":"src/etc/rc.restore_ramdisk_store","position":3,"original_position":3,"commit_id":"3f0d54e2c917b9691e381ca817ac3b1bb10512ea","original_commit_id":"3f0d54e2c917b9691e381ca817ac3b1bb10512ea","user":{"login":"rbgarga","id":149872,"avatar_url":"https://avatars.githubusercontent.com/u/149872?v=3","gravatar_id":"","url":"https://api.github.com/users/rbgarga","html_url":"https://github.com/rbgarga","followers_url":"https://api.github.com/users/rbgarga/followers","following_url":"https://api.github.com/users/rbgarga/following{/other_user}","gists_url":"https://api.github.com/users/rbgarga/gists{/gist_id}","starred_url":"https://api.github.com/users/rbgarga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rbgarga/subscriptions","organizations_url":"https://api.github.com/users/rbgarga/orgs","repos_url":"https://api.github.com/users/rbgarga/repos","events_url":"https://api.github.com/users/rbgarga/events{/privacy}","received_events_url":"https://api.github.com/users/rbgarga/received_events","type":"User","site_admin":false},"body":"Please move license text to Apache 2.0","created_at":"2016-12-07T14:10:11Z","updated_at":"2016-12-07T14:14:34Z","html_url":"https://github.com/pfsense/pfsense/pull/2902#discussion_r91299384","pull_request_url":"https://api.github.com/repos/pfsense/pfsense/pulls/2902","_links":{"self":{"href":"https://api.github.com/repos/pfsense/pfsense/pulls/comments/91299384"},"html":{"href":"https://github.com/pfsense/pfsense/pull/2902#discussion_r91299384"},"pull_request":{"href":"https://api.github.com/repos/pfsense/pfsense/pulls/2902"}}},"pull_request":{"url":"https://api.github.com/repos/pfsense/pfsense/pulls/2902","id":67598893,"html_url":"https://github.com/pfsense/pfsense/pull/2902","diff_url":"https://github.com/pfsense/pfsense/pull/2902.diff","patch_url":"https://github.com/pfsense/pfsense/pull/2902.patch","issue_url":"https://api.github.com/repos/pfsense/pfsense/issues/2902","number":2902,"state":"open","locked":false,"title":"RAM Disk Management","user":{"login":"NOYB","id":1977521,"avatar_url":"https://avatars.githubusercontent.com/u/1977521?v=3","gravatar_id":"","url":"https://api.github.com/users/NOYB","html_url":"https://github.com/NOYB","followers_url":"https://api.github.com/users/NOYB/followers","following_url":"https://api.github.com/users/NOYB/following{/other_user}","gists_url":"https://api.github.com/users/NOYB/gists{/gist_id}","starred_url":"https://api.github.com/users/NOYB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NOYB/subscriptions","organizations_url":"https://api.github.com/users/NOYB/orgs","repos_url":"https://api.github.com/users/NOYB/repos","events_url":"https://api.github.com/users/NOYB/events{/privacy}","received_events_url":"https://api.github.com/users/NOYB/received_events","type":"User","site_admin":false},"body":"1) Treat the RAM disk more like a permanent storage device with content managed/restored by the system and made available at boot up, before needed by any services.\n a) Handle saving and restoring RAM disk content at reboot/shutdown/boot centrally in more of a system manged fashion.\n b) If it's in the RAM disk store it gets restored early in the pfSense startup so it's available for whatever needs to use it.\n c) Services utilizing RAM disk don't need to be aware that their content is on a RAM disk, and handling content restore individually.\n\n2) Has the benefit of eliminating some issues with the previous code as well.  Such as...\n a) Restoring RRD multiple times during boot, potentially at least 3 times, by rc.newwanip, rc.newwanipv6, and rc.boot.  Some even overlapping.\n b) Not removing the backups if/when not being utilized.  Such as on a full install with the RAM disk option not enabled.\n c) Eliminate some duplicate code.\n\n3) Looking forward.\n a) The more centrally system managed approach may crack the door open to making it easier to include some of the logs in the RAM disk store.  As well as anything else that may be useful/desirable to retain in the RAM disk across reboots.\n","created_at":"2016-04-23T07:04:44Z","updated_at":"2016-12-07T14:14:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"993b9fc79bfbd87bdff23c5ff67554b0272a2e19","assignee":{"login":"rbgarga","id":149872,"avatar_url":"https://avatars.githubusercontent.com/u/149872?v=3","gravatar_id":"","url":"https://api.github.com/users/rbgarga","html_url":"https://github.com/rbgarga","followers_url":"https://api.github.com/users/rbgarga/followers","following_url":"https://api.github.com/users/rbgarga/following{/other_user}","gists_url":"https://api.github.com/users/rbgarga/gists{/gist_id}","starred_url":"https://api.github.com/users/rbgarga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rbgarga/subscriptions","organizations_url":"https://api.github.com/users/rbgarga/orgs","repos_url":"https://api.github.com/users/rbgarga/repos","events_url":"https://api.github.com/users/rbgarga/events{/privacy}","received_events_url":"https://api.github.com/users/rbgarga/received_events","type":"User","site_admin":false},"assignees":[{"login":"rbgarga","id":149872,"avatar_url":"https://avatars.githubusercontent.com/u/149872?v=3","gravatar_id":"","url":"https://api.github.com/users/rbgarga","html_url":"https://github.com/rbgarga","followers_url":"https://api.github.com/users/rbgarga/followers","following_url":"https://api.github.com/users/rbgarga/following{/other_user}","gists_url":"https://api.github.com/users/rbgarga/gists{/gist_id}","starred_url":"https://api.github.com/users/rbgarga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rbgarga/subscriptions","organizations_url":"https://api.github.com/users/rbgarga/orgs","repos_url":"https://api.github.com/users/rbgarga/repos","events_url":"https://api.github.com/users/rbgarga/events{/privacy}","received_events_url":"https://api.github.com/users/rbgarga/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/pfsense/pfsense/pulls/2902/commits","review_comments_url":"https://api.github.com/repos/pfsense/pfsense/pulls/2902/comments","review_comment_url":"https://api.github.com/repos/pfsense/pfsense/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pfsense/pfsense/issues/2902/comments","statuses_url":"https://api.github.com/repos/pfsense/pfsense/statuses/3f0d54e2c917b9691e381ca817ac3b1bb10512ea","head":{"label":"NOYB:RAM_Disk_Management","ref":"RAM_Disk_Management","sha":"3f0d54e2c917b9691e381ca817ac3b1bb10512ea","user":{"login":"NOYB","id":1977521,"avatar_url":"https://avatars.githubusercontent.com/u/1977521?v=3","gravatar_id":"","url":"https://api.github.com/users/NOYB","html_url":"https://github.com/NOYB","followers_url":"https://api.github.com/users/NOYB/followers","following_url":"https://api.github.com/users/NOYB/following{/other_user}","gists_url":"https://api.github.com/users/NOYB/gists{/gist_id}","starred_url":"https://api.github.com/users/NOYB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NOYB/subscriptions","organizations_url":"https://api.github.com/users/NOYB/orgs","repos_url":"https://api.github.com/users/NOYB/repos","events_url":"https://api.github.com/users/NOYB/events{/privacy}","received_events_url":"https://api.github.com/users/NOYB/received_events","type":"User","site_admin":false},"repo":{"id":5139611,"name":"pfsense","full_name":"NOYB/pfsense","owner":{"login":"NOYB","id":1977521,"avatar_url":"https://avatars.githubusercontent.com/u/1977521?v=3","gravatar_id":"","url":"https://api.github.com/users/NOYB","html_url":"https://github.com/NOYB","followers_url":"https://api.github.com/users/NOYB/followers","following_url":"https://api.github.com/users/NOYB/following{/other_user}","gists_url":"https://api.github.com/users/NOYB/gists{/gist_id}","starred_url":"https://api.github.com/users/NOYB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NOYB/subscriptions","organizations_url":"https://api.github.com/users/NOYB/orgs","repos_url":"https://api.github.com/users/NOYB/repos","events_url":"https://api.github.com/users/NOYB/events{/privacy}","received_events_url":"https://api.github.com/users/NOYB/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/NOYB/pfsense","description":"Main repository for pfSense","fork":true,"url":"https://api.github.com/repos/NOYB/pfsense","forks_url":"https://api.github.com/repos/NOYB/pfsense/forks","keys_url":"https://api.github.com/repos/NOYB/pfsense/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NOYB/pfsense/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NOYB/pfsense/teams","hooks_url":"https://api.github.com/repos/NOYB/pfsense/hooks","issue_events_url":"https://api.github.com/repos/NOYB/pfsense/issues/events{/number}","events_url":"https://api.github.com/repos/NOYB/pfsense/events","assignees_url":"https://api.github.com/repos/NOYB/pfsense/assignees{/user}","branches_url":"https://api.github.com/repos/NOYB/pfsense/branches{/branch}","tags_url":"https://api.github.com/repos/NOYB/pfsense/tags","blobs_url":"https://api.github.com/repos/NOYB/pfsense/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NOYB/pfsense/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NOYB/pfsense/git/refs{/sha}","trees_url":"https://api.github.com/repos/NOYB/pfsense/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NOYB/pfsense/statuses/{sha}","languages_url":"https://api.github.com/repos/NOYB/pfsense/languages","stargazers_url":"https://api.github.com/repos/NOYB/pfsense/stargazers","contributors_url":"https://api.github.com/repos/NOYB/pfsense/contributors","subscribers_url":"https://api.github.com/repos/NOYB/pfsense/subscribers","subscription_url":"https://api.github.com/repos/NOYB/pfsense/subscription","commits_url":"https://api.github.com/repos/NOYB/pfsense/commits{/sha}","git_commits_url":"https://api.github.com/repos/NOYB/pfsense/git/commits{/sha}","comments_url":"https://api.github.com/repos/NOYB/pfsense/comments{/number}","issue_comment_url":"https://api.github.com/repos/NOYB/pfsense/issues/comments{/number}","contents_url":"https://api.github.com/repos/NOYB/pfsense/contents/{+path}","compare_url":"https://api.github.com/repos/NOYB/pfsense/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NOYB/pfsense/merges","archive_url":"https://api.github.com/repos/NOYB/pfsense/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NOYB/pfsense/downloads","issues_url":"https://api.github.com/repos/NOYB/pfsense/issues{/number}","pulls_url":"https://api.github.com/repos/NOYB/pfsense/pulls{/number}","milestones_url":"https://api.github.com/repos/NOYB/pfsense/milestones{/number}","notifications_url":"https://api.github.com/repos/NOYB/pfsense/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NOYB/pfsense/labels{/name}","releases_url":"https://api.github.com/repos/NOYB/pfsense/releases{/id}","deployments_url":"https://api.github.com/repos/NOYB/pfsense/deployments","created_at":"2012-07-22T06:25:58Z","updated_at":"2015-06-27T00:20:11Z","pushed_at":"2016-12-03T02:14:46Z","git_url":"git://github.com/NOYB/pfsense.git","ssh_url":"git@github.com:NOYB/pfsense.git","clone_url":"https://github.com/NOYB/pfsense.git","svn_url":"https://github.com/NOYB/pfsense","homepage":"http://www.pfsense.org","size":89697,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"pfsense:master","ref":"master","sha":"86bb5c37c6d7302593ccc1249faf57228a9cbfe2","user":{"login":"pfsense","id":3716965,"avatar_url":"https://avatars.githubusercontent.com/u/3716965?v=3","gravatar_id":"","url":"https://api.github.com/users/pfsense","html_url":"https://github.com/pfsense","followers_url":"https://api.github.com/users/pfsense/followers","following_url":"https://api.github.com/users/pfsense/following{/other_user}","gists_url":"https://api.github.com/users/pfsense/gists{/gist_id}","starred_url":"https://api.github.com/users/pfsense/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pfsense/subscriptions","organizations_url":"https://api.github.com/users/pfsense/orgs","repos_url":"https://api.github.com/users/pfsense/repos","events_url":"https://api.github.com/users/pfsense/events{/privacy}","received_events_url":"https://api.github.com/users/pfsense/received_events","type":"Organization","site_admin":false},"repo":{"id":1740040,"name":"pfsense","full_name":"pfsense/pfsense","owner":{"login":"pfsense","id":3716965,"avatar_url":"https://avatars.githubusercontent.com/u/3716965?v=3","gravatar_id":"","url":"https://api.github.com/users/pfsense","html_url":"https://github.com/pfsense","followers_url":"https://api.github.com/users/pfsense/followers","following_url":"https://api.github.com/users/pfsense/following{/other_user}","gists_url":"https://api.github.com/users/pfsense/gists{/gist_id}","starred_url":"https://api.github.com/users/pfsense/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pfsense/subscriptions","organizations_url":"https://api.github.com/users/pfsense/orgs","repos_url":"https://api.github.com/users/pfsense/repos","events_url":"https://api.github.com/users/pfsense/events{/privacy}","received_events_url":"https://api.github.com/users/pfsense/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pfsense/pfsense","description":"Main repository for pfSense","fork":false,"url":"https://api.github.com/repos/pfsense/pfsense","forks_url":"https://api.github.com/repos/pfsense/pfsense/forks","keys_url":"https://api.github.com/repos/pfsense/pfsense/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pfsense/pfsense/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pfsense/pfsense/teams","hooks_url":"https://api.github.com/repos/pfsense/pfsense/hooks","issue_events_url":"https://api.github.com/repos/pfsense/pfsense/issues/events{/number}","events_url":"https://api.github.com/repos/pfsense/pfsense/events","assignees_url":"https://api.github.com/repos/pfsense/pfsense/assignees{/user}","branches_url":"https://api.github.com/repos/pfsense/pfsense/branches{/branch}","tags_url":"https://api.github.com/repos/pfsense/pfsense/tags","blobs_url":"https://api.github.com/repos/pfsense/pfsense/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pfsense/pfsense/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pfsense/pfsense/git/refs{/sha}","trees_url":"https://api.github.com/repos/pfsense/pfsense/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pfsense/pfsense/statuses/{sha}","languages_url":"https://api.github.com/repos/pfsense/pfsense/languages","stargazers_url":"https://api.github.com/repos/pfsense/pfsense/stargazers","contributors_url":"https://api.github.com/repos/pfsense/pfsense/contributors","subscribers_url":"https://api.github.com/repos/pfsense/pfsense/subscribers","subscription_url":"https://api.github.com/repos/pfsense/pfsense/subscription","commits_url":"https://api.github.com/repos/pfsense/pfsense/commits{/sha}","git_commits_url":"https://api.github.com/repos/pfsense/pfsense/git/commits{/sha}","comments_url":"https://api.github.com/repos/pfsense/pfsense/comments{/number}","issue_comment_url":"https://api.github.com/repos/pfsense/pfsense/issues/comments{/number}","contents_url":"https://api.github.com/repos/pfsense/pfsense/contents/{+path}","compare_url":"https://api.github.com/repos/pfsense/pfsense/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pfsense/pfsense/merges","archive_url":"https://api.github.com/repos/pfsense/pfsense/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pfsense/pfsense/downloads","issues_url":"https://api.github.com/repos/pfsense/pfsense/issues{/number}","pulls_url":"https://api.github.com/repos/pfsense/pfsense/pulls{/number}","milestones_url":"https://api.github.com/repos/pfsense/pfsense/milestones{/number}","notifications_url":"https://api.github.com/repos/pfsense/pfsense/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pfsense/pfsense/labels{/name}","releases_url":"https://api.github.com/repos/pfsense/pfsense/releases{/id}","deployments_url":"https://api.github.com/repos/pfsense/pfsense/deployments","created_at":"2011-05-12T19:44:21Z","updated_at":"2016-12-07T11:39:09Z","pushed_at":"2016-12-07T13:44:00Z","git_url":"git://github.com/pfsense/pfsense.git","ssh_url":"git@github.com:pfsense/pfsense.git","clone_url":"https://github.com/pfsense/pfsense.git","svn_url":"https://github.com/pfsense/pfsense","homepage":"http://www.pfsense.org","size":120634,"stargazers_count":1122,"watchers_count":1122,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":576,"mirror_url":null,"open_issues_count":25,"forks":576,"open_issues":25,"watchers":1122,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pfsense/pfsense/pulls/2902"},"html":{"href":"https://github.com/pfsense/pfsense/pull/2902"},"issue":{"href":"https://api.github.com/repos/pfsense/pfsense/issues/2902"},"comments":{"href":"https://api.github.com/repos/pfsense/pfsense/issues/2902/comments"},"review_comments":{"href":"https://api.github.com/repos/pfsense/pfsense/pulls/2902/comments"},"review_comment":{"href":"https://api.github.com/repos/pfsense/pfsense/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pfsense/pfsense/pulls/2902/commits"},"statuses":{"href":"https://api.github.com/repos/pfsense/pfsense/statuses/3f0d54e2c917b9691e381ca817ac3b1bb10512ea"}}}}
{"actor":{"display_login":"rbgarga"}}