{"push_id":1019171247,"size":23,"distinct_size":23,"ref":"refs/heads/master","head":"92821ec9a57817e1429ae94c756539259488b728","before":"374f9199e33b62a4d8ae49e4efbd7d9ad17fce58","commits":[{"sha":"c42cdb7f6dcfd519d9607ac9fa53f049b2922fb8","author":{"email":"110fdadc76b6bce16977f568bdb4723eaed6fb3f@gentoo.org","name":"Sergei Trofimovich"},"message":"fix Float/Double unreg cross-compilation\n\nLooking at more failures on m68k (Trac #11395)\nI've noticed the arith001 and arith012 test failures.\n(--host=x86_64-linux --target=m68k-linux).\n\nThe following example was enough to reproduce a problem:\n\n    v :: Float\n    v = 43\n    main = print v\n\nm68k binaries printed '0.0' instead of '43.0'.\n\nThe bug here is how we encode Floats and Double\nas Words with the same binary representation.\n\nFloats:\n  Before the patch we just coerced Float to Int.\n  That breaks when we cross-compile from\n  64-bit LE to 32-bit BE.\n\n  The patch fixes conversion by accounting for padding.\n  when we extend 32-bit value to 64-bit value (LE and BE\n  do it slightly differently).\n\nDoubles:\n  Before the patch Doubles were coerced to a pair of Ints\n  (not correct as x86_64 can hold Double in one Int) and\n  then trucated this pair of Ints to pair of Word32.\n\n  The patch fixes conversion by always decomposing in\n  Word32 and accounting for host endianness (newly\n  introduced hostBE)  and target endianness (wORDS_BIGENDIAN).\n\nI've tested this patch on Double and Float conversion on\n    --host=x86_64-linux --target=m68k-linux\ncrosscompiler. It fixes 10 tests related to printing Floats\nand Doubles.\n\nThanks to Bertram Felgenhauer who poined out this probem.\n\nSigned-off-by: Sergei Trofimovich <siarheit@google.com>\n\nTest Plan: checked some examples manually, fixed 10 tests in test suite\n\nReviewers: int-e, austin, bgamari\n\nSubscribers: thomie\n\nDifferential Revision: https://phabricator.haskell.org/D1990\n\nGHC Trac Issues: #11395","distinct":true,"url":"https://api.github.com/repos/vTurbine/ghc/commits/c42cdb7f6dcfd519d9607ac9fa53f049b2922fb8"},{"sha":"fc16690a536b74e7af72e963599471474e3df603","author":{"email":"dbd597f5635f432486c5d365e9bb585b3eaa1853@cs.stanford.edu","name":"Edward Z. Yang"},"message":"Fix #11624, cannot declare hs-boot if already one in scope.\n\nI'm not sure if this fix is the \"right way\" to do it, but\nit solves the proximal problem, which is that lookupBindGroupOcc\nwas picking out the wrong renaming for hs-boot signatures,\nwhich then lead to an interface file error.\n\nSigned-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>\n\nTest Plan: validate\n\nReviewers: simonpj, hvr, austin, bgamari\n\nReviewed By: bgamari\n\nSubscribers: thomie\n\nDifferential Revision: https://phabricator.haskell.org/D1963\n\nGHC Trac Issues: #11624","distinct":true,"url":"https://api.github.com/repos/vTurbine/ghc/commits/fc16690a536b74e7af72e963599471474e3df603"},{"sha":"c937f424e4acd61d1c558e8fe9b47e7d580fdbd8","author":{"email":"73675debcd8a436be48ec22211dcf44fe0df0a64@smart-cactus.org","name":"Ben Gamari"},"message":"Add regression test for #11555","distinct":true,"url":"https://api.github.com/repos/vTurbine/ghc/commits/c937f424e4acd61d1c558e8fe9b47e7d580fdbd8"},{"sha":"a1c4230e15cbf897b97903c8a1199a1cc91efd26","author":{"email":"ef9c145df0d91f4ae3f2ee937c5757f539df3df6@gmail.com","name":"Ben Gamari"},"message":"Use catchException in a few more places\n\nThese are cases in the standard library that may benefit from the\nstrictness signature of catchException and where we know that the action\nwon't bottom.\n\nTest Plan: Validate, carefully consider changed callsites\n\nReviewers: austin, hvr\n\nSubscribers: thomie\n\nDifferential Revision: https://phabricator.haskell.org/D1972","distinct":true,"url":"https://api.github.com/repos/vTurbine/ghc/commits/a1c4230e15cbf897b97903c8a1199a1cc91efd26"},{"sha":"30ee9102db2f16894912e19b9d16156824611bbb","author":{"email":"ef9c145df0d91f4ae3f2ee937c5757f539df3df6@gmail.com","name":"Ben Gamari"},"message":"Make `catch` lazy in the action\n\nPreviously\n```lang=haskell\ncatch (error \"uh oh\") (\\(_ :: SomeException) -> print \"it failed\")\n```\nwould unexpectedly fail with \"uh oh\" instead of the handler being run\ndue to the strictness of `catch` in its first argument. See #11555 for\ndetails.\n\nTest Plan: Validate\n\nReviewers: austin, hvr, simonpj\n\nReviewed By: simonpj\n\nSubscribers: simonpj, thomie\n\nDifferential Revision: https://phabricator.haskell.org/D1973\n\nGHC Trac Issues: #11555","distinct":true,"url":"https://api.github.com/repos/vTurbine/ghc/commits/30ee9102db2f16894912e19b9d16156824611bbb"},{"sha":"f3def7643d390db54d18b8c3d385c490fba58a41","author":{"email":"07aea4c4c231d8a029cafc72e16b27182c2be4f4@seas.upenn.edu","name":"Dominik Bollmann"},"message":"add regression test for #11145.\n\nThe original TH failure observed by the ticket, namely that Template\nHaskell quotes of data instance GADTs are broken, is not observable\nanymore in HEAD. I therefore just added the corresponding regression\ntest.\n\nTest Plan: ./validate\n\nReviewers: goldfire, austin, thomie, jstolarek, bgamari\n\nReviewed By: bgamari\n\nDifferential Revision: https://phabricator.haskell.org/D1978\n\nGHC Trac Issues: #11145","distinct":true,"url":"https://api.github.com/repos/vTurbine/ghc/commits/f3def7643d390db54d18b8c3d385c490fba58a41"},{"sha":"767ff7cab7fc2d27b66cdd25d551ccf9e9e7c51d","author":{"email":"ef9c145df0d91f4ae3f2ee937c5757f539df3df6@gmail.com","name":"Ben Gamari"},"message":"Document Quasi-quotes/list comprehension ambiguity\n\n\nTest Plan: read it\n\nReviewers: austin, goldfire\n\nReviewed By: goldfire\n\nSubscribers: hvr, thomie\n\nDifferential Revision: https://phabricator.haskell.org/D1981\n\nGHC Trac Issues: #11679","distinct":true,"url":"https://api.github.com/repos/vTurbine/ghc/commits/767ff7cab7fc2d27b66cdd25d551ccf9e9e7c51d"},{"sha":"a74a3846c84ad55de3deeed8b2401a2ed514b2e1","author":{"email":"ef9c145df0d91f4ae3f2ee937c5757f539df3df6@gmail.com","name":"Ben Gamari"},"message":"Include version in AC_PACKAGE_TARNAME\n\n`AC_PACKAGE_TARNAME` is used by autoconf to generate the default value\nof docdir, which we now set to include a version number (see #11354).\nThis fixed #11659.\n\nTest Plan: `./configure --help`, validate\n\nReviewers: austin, thomie, hvr, erikd\n\nReviewed By: hvr, erikd\n\nSubscribers: erikd\n\nDifferential Revision: https://phabricator.haskell.org/D1983\n\nGHC Trac Issues: #11659","distinct":true,"url":"https://api.github.com/repos/vTurbine/ghc/commits/a74a3846c84ad55de3deeed8b2401a2ed514b2e1"},{"sha":"f8056fca87e83fd37d3f2441f5cb0335e12e3aef","author":{"email":"202fbcf3c00694524024feb79f3bb8fc1c4e4f9c@gnu.org","name":"Herbert Valerio Riedel"},"message":"Make integer-gmp operations more strict\n\nReviewers: austin, goldfire, bgamari\n\nReviewed By: bgamari\n\nSubscribers: thomie\n\nDifferential Revision: https://phabricator.haskell.org/D1984\n\nGHC Trac Issues: #10691","distinct":true,"url":"https://api.github.com/repos/vTurbine/ghc/commits/f8056fca87e83fd37d3f2441f5cb0335e12e3aef"},{"sha":"d48220eb7b2029ab90ea8185ac82b6bed51009ad","author":{"email":"9069d0e8b554bca3df1592c83c498c5cd0661c2e@owenstephens.co.uk","name":"Owen Stephens"},"message":"Add Note [Running splices in the Renamer]\n\nReviewers: austin, goldfire, bgamari\n\nReviewed By: goldfire, bgamari\n\nSubscribers: thomie\n\nDifferential Revision: https://phabricator.haskell.org/D1985","distinct":true,"url":"https://api.github.com/repos/vTurbine/ghc/commits/d48220eb7b2029ab90ea8185ac82b6bed51009ad"},{"sha":"90b8af05660dc2b36c62a07ff86703cbb9e04766","author":{"email":"81e851ff6743fa1dda97004eb5476ffbced6b8de@gmail.com","name":"Chris Martin"},"message":"Fix readme link to FixingBugs wiki page\n\nReviewers: austin, bgamari\n\nReviewed By: bgamari\n\nSubscribers: thomie\n\nDifferential Revision: https://phabricator.haskell.org/D1988","distinct":true,"url":"https://api.github.com/repos/vTurbine/ghc/commits/90b8af05660dc2b36c62a07ff86703cbb9e04766"},{"sha":"06b70ffc7b17bd34ea771b8be11574c4002db6c8","author":{"email":"81e851ff6743fa1dda97004eb5476ffbced6b8de@gmail.com","name":"Chris Martin"},"message":"Add doc to (<$>) explaining its relationship to ($)\n\nReviewers: bgamari, hvr, austin\n\nReviewed By: bgamari\n\nSubscribers: thomie\n\nDifferential Revision: https://phabricator.haskell.org/D1989","distinct":true,"url":"https://api.github.com/repos/vTurbine/ghc/commits/06b70ffc7b17bd34ea771b8be11574c4002db6c8"},{"sha":"8626d76a723c2514bab91afb82e6b8b94fed2a2b","author":{"email":"1586a8e151fb6d548e7a343b9bcdfea42e83ffc0@mega-nerd.com","name":"Erik de Castro Lopo"},"message":"rtx/posix/Itimer.c: Handle return value of `read`\n\nOn Ubuntu libc's `read` function is marked with attribute\n`warn_unused_result` which was causing build failures on\nHarbourmaster.\n\nTest Plan: validate on Harbourmaster\n\nReviewers: austin, hvr, bgamari\n\nReviewed By: hvr, bgamari\n\nSubscribers: thomie\n\nDifferential Revision: https://phabricator.haskell.org/D1993\n\nGHC Trac Issues: #11697","distinct":true,"url":"https://api.github.com/repos/vTurbine/ghc/commits/8626d76a723c2514bab91afb82e6b8b94fed2a2b"},{"sha":"6a2992dc4b6582bd95b0cef1a674a99ca8299403","author":{"email":"ef9c145df0d91f4ae3f2ee937c5757f539df3df6@gmail.com","name":"Ben Gamari"},"message":"Add MonadUnique instance for LlvmM\n\nReviewers: erikd, austin\n\nReviewed By: erikd\n\nSubscribers: thomie\n\nDifferential Revision: https://phabricator.haskell.org/D1994","distinct":true,"url":"https://api.github.com/repos/vTurbine/ghc/commits/6a2992dc4b6582bd95b0cef1a674a99ca8299403"},{"sha":"e764ede35f5c5b2c41e1670c6a9b831e0a70cd17","author":{"email":"ef9c145df0d91f4ae3f2ee937c5757f539df3df6@gmail.com","name":"Ben Gamari"},"message":"Add ghc-flag directory for -XPatternGuards\n\nReviewers: austin\n\nSubscribers: thomie\n\nDifferential Revision: https://phabricator.haskell.org/D1987","distinct":true,"url":"https://api.github.com/repos/vTurbine/ghc/commits/e764ede35f5c5b2c41e1670c6a9b831e0a70cd17"},{"sha":"2908ae8dbe8fd69f8c3ac3dab199026dfc250445","author":{"email":"ef9c145df0d91f4ae3f2ee937c5757f539df3df6@gmail.com","name":"Ben Gamari"},"message":"Handle unset HOME environment variable more gracefully\n\nTest Plan:\n  * Validate\n  * try `env -i ghc`\n  * try `env -i runghc HelloWorld.hs`\n\nReviewers: austin\n\nSubscribers: thomie, ezyang\n\nDifferential Revision: https://phabricator.haskell.org/D1971\n\nGHC Trac Issues: #11678","distinct":true,"url":"https://api.github.com/repos/vTurbine/ghc/commits/2908ae8dbe8fd69f8c3ac3dab199026dfc250445"},{"sha":"3ea11eb1c367a15e5b7dac83d31937ac7d44b3b2","author":{"email":"73675debcd8a436be48ec22211dcf44fe0df0a64@smart-cactus.org","name":"Ben Gamari"},"message":"Move getOccFS to Name","distinct":true,"url":"https://api.github.com/repos/vTurbine/ghc/commits/3ea11eb1c367a15e5b7dac83d31937ac7d44b3b2"},{"sha":"7ba817c217d3c5c4dd9550b0cf0f4314b54895a3","author":{"email":"73675debcd8a436be48ec22211dcf44fe0df0a64@smart-cactus.org","name":"Ben Gamari"},"message":"Bump allocations for T6048\n\nThis occassionally fails with allocations a few tenths of a percent\nabove threshold. Sadly there isn't a clear cause; it's likely just the\nresult of gradual creep, further underscoring the need for more regular\nperformance characterization.","distinct":true,"url":"https://api.github.com/repos/vTurbine/ghc/commits/7ba817c217d3c5c4dd9550b0cf0f4314b54895a3"},{"sha":"2f45cf3f48162a5f843005755dafa1c5c1b451a7","author":{"email":"0f335816a479d40a484b0f003cd959ed488eb2a0@gmail.com","name":"Simon Marlow"},"message":"Add -foptimal-applicative-do\n\nSummary:\nThe algorithm for ApplicativeDo rearrangement is based on a heuristic\nthat runs in O(n^2).  This patch adds the optimal algorithm, which is\nO(n^3), selected by a flag (-foptimal-applicative-do).  It finds better\nsolutions in a small number of cases (about 2% of the cases where\nApplicativeDo makes a difference), but it can be very slow for large do\nexpressions.  I'm mainly adding it for experimental reasons.\n\nToDo: user guide docs\n\nTest Plan: validate\n\nReviewers: simonpj, bgamari, austin, niteria, erikd\n\nSubscribers: thomie\n\nDifferential Revision: https://phabricator.haskell.org/D1969","distinct":true,"url":"https://api.github.com/repos/vTurbine/ghc/commits/2f45cf3f48162a5f843005755dafa1c5c1b451a7"},{"sha":"e46742f5c51938bc7c992ac37fecc6df8cab7647","author":{"email":"df7d2cee2e7ececeb2368216a0f9d0537fd32149@google.com","name":"Sergei Trofimovich"},"message":"rts: fix threadStackUnderflow type in cmm\n\nstg_stack_underflow_frame had an incorrect\ncall of C function 'threadStackUnderflow':\n    (\"ptr\" ret_off) =\n      foreign \"C\" threadStackUnderflow(\n        MyCapability(),\n        CurrentTSO);\n\nWhich means it's prototype is:\n    void * (*) (W_, void*);\nWhile real prototype is:\n    W_ (*) (Capability *cap, StgTSO *tso);\n\nThe fix is simple. Fix type annotations:\n    (ret_off) =\n      foreign \"C\" threadStackUnderflow(\n        MyCapability() \"ptr\",\n        CurrentTSO \"ptr\");\n\nNoticed when debugged T9045 test failure\non m68k target which distincts between\npointer and non pointer return types\n(uses different registers)\n\nWhile at it noticed and fixed return types\nfor 'throwTo' and 'findSpark'.\n\nTrac #11395\n\nSigned-off-by: Sergei Trofimovich <siarheit@google.com>","distinct":true,"url":"https://api.github.com/repos/vTurbine/ghc/commits/e46742f5c51938bc7c992ac37fecc6df8cab7647"}]}