{"action":"closed","number":174,"pull_request":{"url":"https://api.github.com/repos/linetools/linetools/pulls/174","id":57595379,"html_url":"https://github.com/linetools/linetools/pull/174","diff_url":"https://github.com/linetools/linetools/pull/174.diff","patch_url":"https://github.com/linetools/linetools/pull/174.patch","issue_url":"https://api.github.com/repos/linetools/linetools/issues/174","number":174,"state":"closed","locked":false,"title":"Add table to speed up reading ISM-related line data","user":{"login":"nhmc","id":174640,"avatar_url":"https://avatars.githubusercontent.com/u/174640?v=3","gravatar_id":"","url":"https://api.github.com/users/nhmc","html_url":"https://github.com/nhmc","followers_url":"https://api.github.com/users/nhmc/followers","following_url":"https://api.github.com/users/nhmc/following{/other_user}","gists_url":"https://api.github.com/users/nhmc/gists{/gist_id}","starred_url":"https://api.github.com/users/nhmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nhmc/subscriptions","organizations_url":"https://api.github.com/users/nhmc/orgs","repos_url":"https://api.github.com/users/nhmc/repos","events_url":"https://api.github.com/users/nhmc/events{/privacy}","received_events_url":"https://api.github.com/users/nhmc/received_events","type":"User","site_admin":false},"body":"Reading the ISM linelist and related versions (Strong, EUV)  is very slow. This PR fixes this by \r\n\r\n 1. Adding a new function in linelist.py to write out ISM data as a fits file, together with columns giving the Strong, EUV and HI subsets.\r\n 2. Reading this file instead of all the source files by default when making a new list. This can be turned off by the `use_ISM_table` keyword to LineList.\r\n\r\nI also removed the possibility of making a line list with multiple keys (e.g. LineList(['ISM', 'molecules'])) because this (a) simplifies the code, (b) was broken for some molecule combinations and (c) seems to be of limited use.\r\n\r\nAlso a test is added. Nothing should change from the user point of view, apart from multiple keys not working anymore.","created_at":"2016-01-29T01:45:20Z","updated_at":"2016-01-29T04:36:20Z","closed_at":"2016-01-29T04:36:20Z","merged_at":"2016-01-29T04:36:20Z","merge_commit_sha":"343dc374eabaef48e7ea96f00d49ddbb2d3a3149","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/linetools/linetools/pulls/174/commits","review_comments_url":"https://api.github.com/repos/linetools/linetools/pulls/174/comments","review_comment_url":"https://api.github.com/repos/linetools/linetools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/linetools/linetools/issues/174/comments","statuses_url":"https://api.github.com/repos/linetools/linetools/statuses/fcf28d19d683bf92f5f9950333fa601378499e06","head":{"label":"nhmc:linelist","ref":"linelist","sha":"fcf28d19d683bf92f5f9950333fa601378499e06","user":{"login":"nhmc","id":174640,"avatar_url":"https://avatars.githubusercontent.com/u/174640?v=3","gravatar_id":"","url":"https://api.github.com/users/nhmc","html_url":"https://github.com/nhmc","followers_url":"https://api.github.com/users/nhmc/followers","following_url":"https://api.github.com/users/nhmc/following{/other_user}","gists_url":"https://api.github.com/users/nhmc/gists{/gist_id}","starred_url":"https://api.github.com/users/nhmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nhmc/subscriptions","organizations_url":"https://api.github.com/users/nhmc/orgs","repos_url":"https://api.github.com/users/nhmc/repos","events_url":"https://api.github.com/users/nhmc/events{/privacy}","received_events_url":"https://api.github.com/users/nhmc/received_events","type":"User","site_admin":false},"repo":{"id":46842009,"name":"linetools","full_name":"nhmc/linetools","owner":{"login":"nhmc","id":174640,"avatar_url":"https://avatars.githubusercontent.com/u/174640?v=3","gravatar_id":"","url":"https://api.github.com/users/nhmc","html_url":"https://github.com/nhmc","followers_url":"https://api.github.com/users/nhmc/followers","following_url":"https://api.github.com/users/nhmc/following{/other_user}","gists_url":"https://api.github.com/users/nhmc/gists{/gist_id}","starred_url":"https://api.github.com/users/nhmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nhmc/subscriptions","organizations_url":"https://api.github.com/users/nhmc/orgs","repos_url":"https://api.github.com/users/nhmc/repos","events_url":"https://api.github.com/users/nhmc/events{/privacy}","received_events_url":"https://api.github.com/users/nhmc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nhmc/linetools","description":"A package for the analysis of 1d astronomical spectra, especially quasar and galaxy spectra.","fork":true,"url":"https://api.github.com/repos/nhmc/linetools","forks_url":"https://api.github.com/repos/nhmc/linetools/forks","keys_url":"https://api.github.com/repos/nhmc/linetools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nhmc/linetools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nhmc/linetools/teams","hooks_url":"https://api.github.com/repos/nhmc/linetools/hooks","issue_events_url":"https://api.github.com/repos/nhmc/linetools/issues/events{/number}","events_url":"https://api.github.com/repos/nhmc/linetools/events","assignees_url":"https://api.github.com/repos/nhmc/linetools/assignees{/user}","branches_url":"https://api.github.com/repos/nhmc/linetools/branches{/branch}","tags_url":"https://api.github.com/repos/nhmc/linetools/tags","blobs_url":"https://api.github.com/repos/nhmc/linetools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nhmc/linetools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nhmc/linetools/git/refs{/sha}","trees_url":"https://api.github.com/repos/nhmc/linetools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nhmc/linetools/statuses/{sha}","languages_url":"https://api.github.com/repos/nhmc/linetools/languages","stargazers_url":"https://api.github.com/repos/nhmc/linetools/stargazers","contributors_url":"https://api.github.com/repos/nhmc/linetools/contributors","subscribers_url":"https://api.github.com/repos/nhmc/linetools/subscribers","subscription_url":"https://api.github.com/repos/nhmc/linetools/subscription","commits_url":"https://api.github.com/repos/nhmc/linetools/commits{/sha}","git_commits_url":"https://api.github.com/repos/nhmc/linetools/git/commits{/sha}","comments_url":"https://api.github.com/repos/nhmc/linetools/comments{/number}","issue_comment_url":"https://api.github.com/repos/nhmc/linetools/issues/comments{/number}","contents_url":"https://api.github.com/repos/nhmc/linetools/contents/{+path}","compare_url":"https://api.github.com/repos/nhmc/linetools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nhmc/linetools/merges","archive_url":"https://api.github.com/repos/nhmc/linetools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nhmc/linetools/downloads","issues_url":"https://api.github.com/repos/nhmc/linetools/issues{/number}","pulls_url":"https://api.github.com/repos/nhmc/linetools/pulls{/number}","milestones_url":"https://api.github.com/repos/nhmc/linetools/milestones{/number}","notifications_url":"https://api.github.com/repos/nhmc/linetools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nhmc/linetools/labels{/name}","releases_url":"https://api.github.com/repos/nhmc/linetools/releases{/id}","deployments_url":"https://api.github.com/repos/nhmc/linetools/deployments","created_at":"2015-11-25T06:26:33Z","updated_at":"2015-11-25T06:26:34Z","pushed_at":"2016-01-29T04:20:26Z","git_url":"git://github.com/nhmc/linetools.git","ssh_url":"git@github.com:nhmc/linetools.git","clone_url":"https://github.com/nhmc/linetools.git","svn_url":"https://github.com/nhmc/linetools","homepage":"","size":7790,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"linetools:master","ref":"master","sha":"638aa7c94acf82bdd235b2419f8ae14e56b063c0","user":{"login":"linetools","id":12589255,"avatar_url":"https://avatars.githubusercontent.com/u/12589255?v=3","gravatar_id":"","url":"https://api.github.com/users/linetools","html_url":"https://github.com/linetools","followers_url":"https://api.github.com/users/linetools/followers","following_url":"https://api.github.com/users/linetools/following{/other_user}","gists_url":"https://api.github.com/users/linetools/gists{/gist_id}","starred_url":"https://api.github.com/users/linetools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linetools/subscriptions","organizations_url":"https://api.github.com/users/linetools/orgs","repos_url":"https://api.github.com/users/linetools/repos","events_url":"https://api.github.com/users/linetools/events{/privacy}","received_events_url":"https://api.github.com/users/linetools/received_events","type":"Organization","site_admin":false},"repo":{"id":36200517,"name":"linetools","full_name":"linetools/linetools","owner":{"login":"linetools","id":12589255,"avatar_url":"https://avatars.githubusercontent.com/u/12589255?v=3","gravatar_id":"","url":"https://api.github.com/users/linetools","html_url":"https://github.com/linetools","followers_url":"https://api.github.com/users/linetools/followers","following_url":"https://api.github.com/users/linetools/following{/other_user}","gists_url":"https://api.github.com/users/linetools/gists{/gist_id}","starred_url":"https://api.github.com/users/linetools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linetools/subscriptions","organizations_url":"https://api.github.com/users/linetools/orgs","repos_url":"https://api.github.com/users/linetools/repos","events_url":"https://api.github.com/users/linetools/events{/privacy}","received_events_url":"https://api.github.com/users/linetools/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/linetools/linetools","description":"A package for the analysis of 1d astronomical spectra, especially quasar and galaxy spectra.","fork":false,"url":"https://api.github.com/repos/linetools/linetools","forks_url":"https://api.github.com/repos/linetools/linetools/forks","keys_url":"https://api.github.com/repos/linetools/linetools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linetools/linetools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linetools/linetools/teams","hooks_url":"https://api.github.com/repos/linetools/linetools/hooks","issue_events_url":"https://api.github.com/repos/linetools/linetools/issues/events{/number}","events_url":"https://api.github.com/repos/linetools/linetools/events","assignees_url":"https://api.github.com/repos/linetools/linetools/assignees{/user}","branches_url":"https://api.github.com/repos/linetools/linetools/branches{/branch}","tags_url":"https://api.github.com/repos/linetools/linetools/tags","blobs_url":"https://api.github.com/repos/linetools/linetools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linetools/linetools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linetools/linetools/git/refs{/sha}","trees_url":"https://api.github.com/repos/linetools/linetools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linetools/linetools/statuses/{sha}","languages_url":"https://api.github.com/repos/linetools/linetools/languages","stargazers_url":"https://api.github.com/repos/linetools/linetools/stargazers","contributors_url":"https://api.github.com/repos/linetools/linetools/contributors","subscribers_url":"https://api.github.com/repos/linetools/linetools/subscribers","subscription_url":"https://api.github.com/repos/linetools/linetools/subscription","commits_url":"https://api.github.com/repos/linetools/linetools/commits{/sha}","git_commits_url":"https://api.github.com/repos/linetools/linetools/git/commits{/sha}","comments_url":"https://api.github.com/repos/linetools/linetools/comments{/number}","issue_comment_url":"https://api.github.com/repos/linetools/linetools/issues/comments{/number}","contents_url":"https://api.github.com/repos/linetools/linetools/contents/{+path}","compare_url":"https://api.github.com/repos/linetools/linetools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linetools/linetools/merges","archive_url":"https://api.github.com/repos/linetools/linetools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linetools/linetools/downloads","issues_url":"https://api.github.com/repos/linetools/linetools/issues{/number}","pulls_url":"https://api.github.com/repos/linetools/linetools/pulls{/number}","milestones_url":"https://api.github.com/repos/linetools/linetools/milestones{/number}","notifications_url":"https://api.github.com/repos/linetools/linetools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linetools/linetools/labels{/name}","releases_url":"https://api.github.com/repos/linetools/linetools/releases{/id}","deployments_url":"https://api.github.com/repos/linetools/linetools/deployments","created_at":"2015-05-25T00:15:17Z","updated_at":"2016-01-11T15:40:50Z","pushed_at":"2016-01-29T04:36:20Z","git_url":"git://github.com/linetools/linetools.git","ssh_url":"git@github.com:linetools/linetools.git","clone_url":"https://github.com/linetools/linetools.git","svn_url":"https://github.com/linetools/linetools","homepage":"","size":7757,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":11,"forks":5,"open_issues":11,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/linetools/linetools/pulls/174"},"html":{"href":"https://github.com/linetools/linetools/pull/174"},"issue":{"href":"https://api.github.com/repos/linetools/linetools/issues/174"},"comments":{"href":"https://api.github.com/repos/linetools/linetools/issues/174/comments"},"review_comments":{"href":"https://api.github.com/repos/linetools/linetools/pulls/174/comments"},"review_comment":{"href":"https://api.github.com/repos/linetools/linetools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/linetools/linetools/pulls/174/commits"},"statuses":{"href":"https://api.github.com/repos/linetools/linetools/statuses/fcf28d19d683bf92f5f9950333fa601378499e06"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"nhmc","id":174640,"avatar_url":"https://avatars.githubusercontent.com/u/174640?v=3","gravatar_id":"","url":"https://api.github.com/users/nhmc","html_url":"https://github.com/nhmc","followers_url":"https://api.github.com/users/nhmc/followers","following_url":"https://api.github.com/users/nhmc/following{/other_user}","gists_url":"https://api.github.com/users/nhmc/gists{/gist_id}","starred_url":"https://api.github.com/users/nhmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nhmc/subscriptions","organizations_url":"https://api.github.com/users/nhmc/orgs","repos_url":"https://api.github.com/users/nhmc/repos","events_url":"https://api.github.com/users/nhmc/events{/privacy}","received_events_url":"https://api.github.com/users/nhmc/received_events","type":"User","site_admin":false},"comments":3,"review_comments":1,"commits":3,"additions":268,"deletions":1662,"changed_files":13}}