{"action":"created","comment":{"url":"https://api.github.com/repos/JuliaLang/julia/pulls/comments/73790653","id":73790653,"diff_hunk":"@@ -1,6 +1,6 @@\n // This file is a part of Julia. License is MIT: http://julialang.org/license\n \n-#if defined(LLVM38) && !defined(LLVM37)\n+#if JL_LLVM_VERSION >= 30800","path":"src/codegen_internal.h","position":4,"original_position":4,"commit_id":"70f10aa6e44a7b119ae03f86283df084556c5f8e","original_commit_id":"70f10aa6e44a7b119ae03f86283df084556c5f8e","user":{"login":"ararslan","id":6396159,"avatar_url":"https://avatars.githubusercontent.com/u/6396159?v=3","gravatar_id":"","url":"https://api.github.com/users/ararslan","html_url":"https://github.com/ararslan","followers_url":"https://api.github.com/users/ararslan/followers","following_url":"https://api.github.com/users/ararslan/following{/other_user}","gists_url":"https://api.github.com/users/ararslan/gists{/gist_id}","starred_url":"https://api.github.com/users/ararslan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ararslan/subscriptions","organizations_url":"https://api.github.com/users/ararslan/orgs","repos_url":"https://api.github.com/users/ararslan/repos","events_url":"https://api.github.com/users/ararslan/events{/privacy}","received_events_url":"https://api.github.com/users/ararslan/received_events","type":"User","site_admin":false},"body":"@yuyichao Should the function declaration here be removed then?","created_at":"2016-08-06T19:14:16Z","updated_at":"2016-08-06T19:14:16Z","html_url":"https://github.com/JuliaLang/julia/pull/17826#discussion_r73790653","pull_request_url":"https://api.github.com/repos/JuliaLang/julia/pulls/17826","_links":{"self":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/comments/73790653"},"html":{"href":"https://github.com/JuliaLang/julia/pull/17826#discussion_r73790653"},"pull_request":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/17826"}}},"pull_request":{"url":"https://api.github.com/repos/JuliaLang/julia/pulls/17826","id":80178751,"html_url":"https://github.com/JuliaLang/julia/pull/17826","diff_url":"https://github.com/JuliaLang/julia/pull/17826.diff","patch_url":"https://github.com/JuliaLang/julia/pull/17826.patch","issue_url":"https://api.github.com/repos/JuliaLang/julia/issues/17826","number":17826,"state":"open","locked":false,"title":"RFC: Use LLVM_VERSION instead of LLVMxx","user":{"login":"ararslan","id":6396159,"avatar_url":"https://avatars.githubusercontent.com/u/6396159?v=3","gravatar_id":"","url":"https://api.github.com/users/ararslan","html_url":"https://github.com/ararslan","followers_url":"https://api.github.com/users/ararslan/followers","following_url":"https://api.github.com/users/ararslan/following{/other_user}","gists_url":"https://api.github.com/users/ararslan/gists{/gist_id}","starred_url":"https://api.github.com/users/ararslan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ararslan/subscriptions","organizations_url":"https://api.github.com/users/ararslan/orgs","repos_url":"https://api.github.com/users/ararslan/repos","events_url":"https://api.github.com/users/ararslan/events{/privacy}","received_events_url":"https://api.github.com/users/ararslan/received_events","type":"User","site_admin":false},"body":"Fixes #9860.\r\n\r\nAs noted in the linked issue, the names `LLVM37`, `LLVM34`, etc. aren't immediately descriptive because they don't refer to specific versions but rather to ranges of versions. This implements the proposed fix of having a single `LLVM_VERSION` macro that holds the LLVM version as a two-digit number and instead of checking whether `LLVMxx` is defined, we check whether `LLVM_VERSION >= xx`. Similarly, checking whether `LLVMxx` is _not_ defined equates to `LLVM_VERSION < xx`.\r\n\r\nThis works locally, so fingers crossed that it works everywhere else...","created_at":"2016-08-05T02:08:58Z","updated_at":"2016-08-06T19:14:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7988e7a72ec9bffc43176c1b83261c36646b2e08","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/JuliaLang/julia/pulls/17826/commits","review_comments_url":"https://api.github.com/repos/JuliaLang/julia/pulls/17826/comments","review_comment_url":"https://api.github.com/repos/JuliaLang/julia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JuliaLang/julia/issues/17826/comments","statuses_url":"https://api.github.com/repos/JuliaLang/julia/statuses/70f10aa6e44a7b119ae03f86283df084556c5f8e","head":{"label":"ararslan:aa/llvm_version_macro","ref":"aa/llvm_version_macro","sha":"70f10aa6e44a7b119ae03f86283df084556c5f8e","user":{"login":"ararslan","id":6396159,"avatar_url":"https://avatars.githubusercontent.com/u/6396159?v=3","gravatar_id":"","url":"https://api.github.com/users/ararslan","html_url":"https://github.com/ararslan","followers_url":"https://api.github.com/users/ararslan/followers","following_url":"https://api.github.com/users/ararslan/following{/other_user}","gists_url":"https://api.github.com/users/ararslan/gists{/gist_id}","starred_url":"https://api.github.com/users/ararslan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ararslan/subscriptions","organizations_url":"https://api.github.com/users/ararslan/orgs","repos_url":"https://api.github.com/users/ararslan/repos","events_url":"https://api.github.com/users/ararslan/events{/privacy}","received_events_url":"https://api.github.com/users/ararslan/received_events","type":"User","site_admin":false},"repo":{"id":57339960,"name":"julia","full_name":"ararslan/julia","owner":{"login":"ararslan","id":6396159,"avatar_url":"https://avatars.githubusercontent.com/u/6396159?v=3","gravatar_id":"","url":"https://api.github.com/users/ararslan","html_url":"https://github.com/ararslan","followers_url":"https://api.github.com/users/ararslan/followers","following_url":"https://api.github.com/users/ararslan/following{/other_user}","gists_url":"https://api.github.com/users/ararslan/gists{/gist_id}","starred_url":"https://api.github.com/users/ararslan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ararslan/subscriptions","organizations_url":"https://api.github.com/users/ararslan/orgs","repos_url":"https://api.github.com/users/ararslan/repos","events_url":"https://api.github.com/users/ararslan/events{/privacy}","received_events_url":"https://api.github.com/users/ararslan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ararslan/julia","description":"The Julia Language: A fresh approach to technical computing.","fork":true,"url":"https://api.github.com/repos/ararslan/julia","forks_url":"https://api.github.com/repos/ararslan/julia/forks","keys_url":"https://api.github.com/repos/ararslan/julia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ararslan/julia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ararslan/julia/teams","hooks_url":"https://api.github.com/repos/ararslan/julia/hooks","issue_events_url":"https://api.github.com/repos/ararslan/julia/issues/events{/number}","events_url":"https://api.github.com/repos/ararslan/julia/events","assignees_url":"https://api.github.com/repos/ararslan/julia/assignees{/user}","branches_url":"https://api.github.com/repos/ararslan/julia/branches{/branch}","tags_url":"https://api.github.com/repos/ararslan/julia/tags","blobs_url":"https://api.github.com/repos/ararslan/julia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ararslan/julia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ararslan/julia/git/refs{/sha}","trees_url":"https://api.github.com/repos/ararslan/julia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ararslan/julia/statuses/{sha}","languages_url":"https://api.github.com/repos/ararslan/julia/languages","stargazers_url":"https://api.github.com/repos/ararslan/julia/stargazers","contributors_url":"https://api.github.com/repos/ararslan/julia/contributors","subscribers_url":"https://api.github.com/repos/ararslan/julia/subscribers","subscription_url":"https://api.github.com/repos/ararslan/julia/subscription","commits_url":"https://api.github.com/repos/ararslan/julia/commits{/sha}","git_commits_url":"https://api.github.com/repos/ararslan/julia/git/commits{/sha}","comments_url":"https://api.github.com/repos/ararslan/julia/comments{/number}","issue_comment_url":"https://api.github.com/repos/ararslan/julia/issues/comments{/number}","contents_url":"https://api.github.com/repos/ararslan/julia/contents/{+path}","compare_url":"https://api.github.com/repos/ararslan/julia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ararslan/julia/merges","archive_url":"https://api.github.com/repos/ararslan/julia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ararslan/julia/downloads","issues_url":"https://api.github.com/repos/ararslan/julia/issues{/number}","pulls_url":"https://api.github.com/repos/ararslan/julia/pulls{/number}","milestones_url":"https://api.github.com/repos/ararslan/julia/milestones{/number}","notifications_url":"https://api.github.com/repos/ararslan/julia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ararslan/julia/labels{/name}","releases_url":"https://api.github.com/repos/ararslan/julia/releases{/id}","deployments_url":"https://api.github.com/repos/ararslan/julia/deployments","created_at":"2016-04-28T23:22:08Z","updated_at":"2016-04-28T23:22:16Z","pushed_at":"2016-08-05T06:51:12Z","git_url":"git://github.com/ararslan/julia.git","ssh_url":"git@github.com:ararslan/julia.git","clone_url":"https://github.com/ararslan/julia.git","svn_url":"https://github.com/ararslan/julia","homepage":"http://julialang.org/","size":97796,"stargazers_count":0,"watchers_count":0,"language":"Julia","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JuliaLang:master","ref":"master","sha":"3e00217d69fa3f59dfd1ee0a6fd04deccec0dd5b","user":{"login":"JuliaLang","id":743164,"avatar_url":"https://avatars.githubusercontent.com/u/743164?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"repo":{"id":1644196,"name":"julia","full_name":"JuliaLang/julia","owner":{"login":"JuliaLang","id":743164,"avatar_url":"https://avatars.githubusercontent.com/u/743164?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JuliaLang/julia","description":"The Julia Language: A fresh approach to technical computing.","fork":false,"url":"https://api.github.com/repos/JuliaLang/julia","forks_url":"https://api.github.com/repos/JuliaLang/julia/forks","keys_url":"https://api.github.com/repos/JuliaLang/julia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaLang/julia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaLang/julia/teams","hooks_url":"https://api.github.com/repos/JuliaLang/julia/hooks","issue_events_url":"https://api.github.com/repos/JuliaLang/julia/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaLang/julia/events","assignees_url":"https://api.github.com/repos/JuliaLang/julia/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaLang/julia/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaLang/julia/tags","blobs_url":"https://api.github.com/repos/JuliaLang/julia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaLang/julia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaLang/julia/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaLang/julia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaLang/julia/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaLang/julia/languages","stargazers_url":"https://api.github.com/repos/JuliaLang/julia/stargazers","contributors_url":"https://api.github.com/repos/JuliaLang/julia/contributors","subscribers_url":"https://api.github.com/repos/JuliaLang/julia/subscribers","subscription_url":"https://api.github.com/repos/JuliaLang/julia/subscription","commits_url":"https://api.github.com/repos/JuliaLang/julia/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaLang/julia/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaLang/julia/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaLang/julia/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaLang/julia/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaLang/julia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaLang/julia/merges","archive_url":"https://api.github.com/repos/JuliaLang/julia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaLang/julia/downloads","issues_url":"https://api.github.com/repos/JuliaLang/julia/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaLang/julia/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaLang/julia/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaLang/julia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaLang/julia/labels{/name}","releases_url":"https://api.github.com/repos/JuliaLang/julia/releases{/id}","deployments_url":"https://api.github.com/repos/JuliaLang/julia/deployments","created_at":"2011-04-21T07:01:50Z","updated_at":"2016-08-06T18:57:56Z","pushed_at":"2016-08-06T18:14:21Z","git_url":"git://github.com/JuliaLang/julia.git","ssh_url":"git@github.com:JuliaLang/julia.git","clone_url":"https://github.com/JuliaLang/julia.git","svn_url":"https://github.com/JuliaLang/julia","homepage":"http://julialang.org/","size":409349,"stargazers_count":7345,"watchers_count":7345,"language":"Julia","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1705,"mirror_url":null,"open_issues_count":1869,"forks":1705,"open_issues":1869,"watchers":7345,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/17826"},"html":{"href":"https://github.com/JuliaLang/julia/pull/17826"},"issue":{"href":"https://api.github.com/repos/JuliaLang/julia/issues/17826"},"comments":{"href":"https://api.github.com/repos/JuliaLang/julia/issues/17826/comments"},"review_comments":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/17826/comments"},"review_comment":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/17826/commits"},"statuses":{"href":"https://api.github.com/repos/JuliaLang/julia/statuses/70f10aa6e44a7b119ae03f86283df084556c5f8e"}}}}
{"actor":{"display_login":"ararslan"}}