{"action":"created","comment":{"url":"https://api.github.com/repos/awslabs/s2n/pulls/comments/73192035","id":73192035,"diff_hunk":"@@ -64,6 +76,8 @@ int s2n_server_extensions_send(struct s2n_connection *conn, struct s2n_stuffer *\n         GUARD(s2n_stuffer_write_uint16(out, 0));\n     }\n \n+","path":"tls/s2n_server_extensions.c","position":30,"original_position":30,"commit_id":"f0f5baa656abc52a0be667dc0a7cf655a21cce61","original_commit_id":"f0f5baa656abc52a0be667dc0a7cf655a21cce61","user":{"login":"colmmacc","id":172568,"avatar_url":"https://avatars.githubusercontent.com/u/172568?v=3","gravatar_id":"","url":"https://api.github.com/users/colmmacc","html_url":"https://github.com/colmmacc","followers_url":"https://api.github.com/users/colmmacc/followers","following_url":"https://api.github.com/users/colmmacc/following{/other_user}","gists_url":"https://api.github.com/users/colmmacc/gists{/gist_id}","starred_url":"https://api.github.com/users/colmmacc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colmmacc/subscriptions","organizations_url":"https://api.github.com/users/colmmacc/orgs","repos_url":"https://api.github.com/users/colmmacc/repos","events_url":"https://api.github.com/users/colmmacc/events{/privacy}","received_events_url":"https://api.github.com/users/colmmacc/received_events","type":"User","site_admin":false},"body":"Intentional blank lines?","created_at":"2016-08-02T16:44:08Z","updated_at":"2016-08-02T16:44:08Z","html_url":"https://github.com/awslabs/s2n/pull/269#discussion_r73192035","pull_request_url":"https://api.github.com/repos/awslabs/s2n/pulls/269","_links":{"self":{"href":"https://api.github.com/repos/awslabs/s2n/pulls/comments/73192035"},"html":{"href":"https://github.com/awslabs/s2n/pull/269#discussion_r73192035"},"pull_request":{"href":"https://api.github.com/repos/awslabs/s2n/pulls/269"}}},"pull_request":{"url":"https://api.github.com/repos/awslabs/s2n/pulls/269","id":79446822,"html_url":"https://github.com/awslabs/s2n/pull/269","diff_url":"https://github.com/awslabs/s2n/pull/269.diff","patch_url":"https://github.com/awslabs/s2n/pull/269.patch","issue_url":"https://api.github.com/repos/awslabs/s2n/issues/269","number":269,"state":"open","locked":false,"title":"Return empty renegotiation_info extension if applicable","user":{"login":"raycoll","id":4444641,"avatar_url":"https://avatars.githubusercontent.com/u/4444641?v=3","gravatar_id":"","url":"https://api.github.com/users/raycoll","html_url":"https://github.com/raycoll","followers_url":"https://api.github.com/users/raycoll/followers","following_url":"https://api.github.com/users/raycoll/following{/other_user}","gists_url":"https://api.github.com/users/raycoll/gists{/gist_id}","starred_url":"https://api.github.com/users/raycoll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raycoll/subscriptions","organizations_url":"https://api.github.com/users/raycoll/orgs","repos_url":"https://api.github.com/users/raycoll/repos","events_url":"https://api.github.com/users/raycoll/events{/privacy}","received_events_url":"https://api.github.com/users/raycoll/received_events","type":"User","site_admin":false},"body":"This change fixes an interoperability problem between s2n in\r\nserver mode and tls clients that implement the secure renegotiation\r\nextension. This change does not enable renegotiation in s2n.\r\nAn empty renegotion_info extension is now sent in the ServerHello if\r\nthe client includes either:\r\n1. TLS_EMPTY_RENEGOTIATION_INFO_SCSV in its cipher suite list\r\n2. An empty renegotiation_info extension\r\n\r\nRFC5746 suggests that TLS clients MAY terminate the handshake if the\r\nserver does not send an empty renegotiation_info extension in response\r\nto a client's [1]. The RFC states that servers that don't support renegotiation\r\nat all(like s2n), MUST implement the minimal version of the extension for\r\nthe initial handshake [2].\r\n\r\n[1] https://tools.ietf.org/html/rfc5746#section-4.1\r\n[2] https://tools.ietf.org/html/rfc5746#section-4.3","created_at":"2016-07-30T03:34:10Z","updated_at":"2016-08-02T16:44:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d40ed370b4c43d48d5536b1d2002ca898d08df88","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/awslabs/s2n/pulls/269/commits","review_comments_url":"https://api.github.com/repos/awslabs/s2n/pulls/269/comments","review_comment_url":"https://api.github.com/repos/awslabs/s2n/pulls/comments{/number}","comments_url":"https://api.github.com/repos/awslabs/s2n/issues/269/comments","statuses_url":"https://api.github.com/repos/awslabs/s2n/statuses/f0f5baa656abc52a0be667dc0a7cf655a21cce61","head":{"label":"raycoll:renegotiation","ref":"renegotiation","sha":"f0f5baa656abc52a0be667dc0a7cf655a21cce61","user":{"login":"raycoll","id":4444641,"avatar_url":"https://avatars.githubusercontent.com/u/4444641?v=3","gravatar_id":"","url":"https://api.github.com/users/raycoll","html_url":"https://github.com/raycoll","followers_url":"https://api.github.com/users/raycoll/followers","following_url":"https://api.github.com/users/raycoll/following{/other_user}","gists_url":"https://api.github.com/users/raycoll/gists{/gist_id}","starred_url":"https://api.github.com/users/raycoll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raycoll/subscriptions","organizations_url":"https://api.github.com/users/raycoll/orgs","repos_url":"https://api.github.com/users/raycoll/repos","events_url":"https://api.github.com/users/raycoll/events{/privacy}","received_events_url":"https://api.github.com/users/raycoll/received_events","type":"User","site_admin":false},"repo":{"id":49685354,"name":"s2n","full_name":"raycoll/s2n","owner":{"login":"raycoll","id":4444641,"avatar_url":"https://avatars.githubusercontent.com/u/4444641?v=3","gravatar_id":"","url":"https://api.github.com/users/raycoll","html_url":"https://github.com/raycoll","followers_url":"https://api.github.com/users/raycoll/followers","following_url":"https://api.github.com/users/raycoll/following{/other_user}","gists_url":"https://api.github.com/users/raycoll/gists{/gist_id}","starred_url":"https://api.github.com/users/raycoll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raycoll/subscriptions","organizations_url":"https://api.github.com/users/raycoll/orgs","repos_url":"https://api.github.com/users/raycoll/repos","events_url":"https://api.github.com/users/raycoll/events{/privacy}","received_events_url":"https://api.github.com/users/raycoll/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/raycoll/s2n","description":"s2n : an implementation of the TLS/SSL protocols","fork":true,"url":"https://api.github.com/repos/raycoll/s2n","forks_url":"https://api.github.com/repos/raycoll/s2n/forks","keys_url":"https://api.github.com/repos/raycoll/s2n/keys{/key_id}","collaborators_url":"https://api.github.com/repos/raycoll/s2n/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/raycoll/s2n/teams","hooks_url":"https://api.github.com/repos/raycoll/s2n/hooks","issue_events_url":"https://api.github.com/repos/raycoll/s2n/issues/events{/number}","events_url":"https://api.github.com/repos/raycoll/s2n/events","assignees_url":"https://api.github.com/repos/raycoll/s2n/assignees{/user}","branches_url":"https://api.github.com/repos/raycoll/s2n/branches{/branch}","tags_url":"https://api.github.com/repos/raycoll/s2n/tags","blobs_url":"https://api.github.com/repos/raycoll/s2n/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/raycoll/s2n/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/raycoll/s2n/git/refs{/sha}","trees_url":"https://api.github.com/repos/raycoll/s2n/git/trees{/sha}","statuses_url":"https://api.github.com/repos/raycoll/s2n/statuses/{sha}","languages_url":"https://api.github.com/repos/raycoll/s2n/languages","stargazers_url":"https://api.github.com/repos/raycoll/s2n/stargazers","contributors_url":"https://api.github.com/repos/raycoll/s2n/contributors","subscribers_url":"https://api.github.com/repos/raycoll/s2n/subscribers","subscription_url":"https://api.github.com/repos/raycoll/s2n/subscription","commits_url":"https://api.github.com/repos/raycoll/s2n/commits{/sha}","git_commits_url":"https://api.github.com/repos/raycoll/s2n/git/commits{/sha}","comments_url":"https://api.github.com/repos/raycoll/s2n/comments{/number}","issue_comment_url":"https://api.github.com/repos/raycoll/s2n/issues/comments{/number}","contents_url":"https://api.github.com/repos/raycoll/s2n/contents/{+path}","compare_url":"https://api.github.com/repos/raycoll/s2n/compare/{base}...{head}","merges_url":"https://api.github.com/repos/raycoll/s2n/merges","archive_url":"https://api.github.com/repos/raycoll/s2n/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/raycoll/s2n/downloads","issues_url":"https://api.github.com/repos/raycoll/s2n/issues{/number}","pulls_url":"https://api.github.com/repos/raycoll/s2n/pulls{/number}","milestones_url":"https://api.github.com/repos/raycoll/s2n/milestones{/number}","notifications_url":"https://api.github.com/repos/raycoll/s2n/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/raycoll/s2n/labels{/name}","releases_url":"https://api.github.com/repos/raycoll/s2n/releases{/id}","deployments_url":"https://api.github.com/repos/raycoll/s2n/deployments","created_at":"2016-01-15T00:51:01Z","updated_at":"2016-01-15T00:51:02Z","pushed_at":"2016-08-02T01:22:27Z","git_url":"git://github.com/raycoll/s2n.git","ssh_url":"git@github.com:raycoll/s2n.git","clone_url":"https://github.com/raycoll/s2n.git","svn_url":"https://github.com/raycoll/s2n","homepage":"","size":1331,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"awslabs:master","ref":"master","sha":"219d61f9b15ede0c5faa3b537629ff40807eb6df","user":{"login":"awslabs","id":3299148,"avatar_url":"https://avatars.githubusercontent.com/u/3299148?v=3","gravatar_id":"","url":"https://api.github.com/users/awslabs","html_url":"https://github.com/awslabs","followers_url":"https://api.github.com/users/awslabs/followers","following_url":"https://api.github.com/users/awslabs/following{/other_user}","gists_url":"https://api.github.com/users/awslabs/gists{/gist_id}","starred_url":"https://api.github.com/users/awslabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awslabs/subscriptions","organizations_url":"https://api.github.com/users/awslabs/orgs","repos_url":"https://api.github.com/users/awslabs/repos","events_url":"https://api.github.com/users/awslabs/events{/privacy}","received_events_url":"https://api.github.com/users/awslabs/received_events","type":"Organization","site_admin":false},"repo":{"id":21287076,"name":"s2n","full_name":"awslabs/s2n","owner":{"login":"awslabs","id":3299148,"avatar_url":"https://avatars.githubusercontent.com/u/3299148?v=3","gravatar_id":"","url":"https://api.github.com/users/awslabs","html_url":"https://github.com/awslabs","followers_url":"https://api.github.com/users/awslabs/followers","following_url":"https://api.github.com/users/awslabs/following{/other_user}","gists_url":"https://api.github.com/users/awslabs/gists{/gist_id}","starred_url":"https://api.github.com/users/awslabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awslabs/subscriptions","organizations_url":"https://api.github.com/users/awslabs/orgs","repos_url":"https://api.github.com/users/awslabs/repos","events_url":"https://api.github.com/users/awslabs/events{/privacy}","received_events_url":"https://api.github.com/users/awslabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/awslabs/s2n","description":"s2n : an implementation of the TLS/SSL protocols","fork":false,"url":"https://api.github.com/repos/awslabs/s2n","forks_url":"https://api.github.com/repos/awslabs/s2n/forks","keys_url":"https://api.github.com/repos/awslabs/s2n/keys{/key_id}","collaborators_url":"https://api.github.com/repos/awslabs/s2n/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/awslabs/s2n/teams","hooks_url":"https://api.github.com/repos/awslabs/s2n/hooks","issue_events_url":"https://api.github.com/repos/awslabs/s2n/issues/events{/number}","events_url":"https://api.github.com/repos/awslabs/s2n/events","assignees_url":"https://api.github.com/repos/awslabs/s2n/assignees{/user}","branches_url":"https://api.github.com/repos/awslabs/s2n/branches{/branch}","tags_url":"https://api.github.com/repos/awslabs/s2n/tags","blobs_url":"https://api.github.com/repos/awslabs/s2n/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/awslabs/s2n/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/awslabs/s2n/git/refs{/sha}","trees_url":"https://api.github.com/repos/awslabs/s2n/git/trees{/sha}","statuses_url":"https://api.github.com/repos/awslabs/s2n/statuses/{sha}","languages_url":"https://api.github.com/repos/awslabs/s2n/languages","stargazers_url":"https://api.github.com/repos/awslabs/s2n/stargazers","contributors_url":"https://api.github.com/repos/awslabs/s2n/contributors","subscribers_url":"https://api.github.com/repos/awslabs/s2n/subscribers","subscription_url":"https://api.github.com/repos/awslabs/s2n/subscription","commits_url":"https://api.github.com/repos/awslabs/s2n/commits{/sha}","git_commits_url":"https://api.github.com/repos/awslabs/s2n/git/commits{/sha}","comments_url":"https://api.github.com/repos/awslabs/s2n/comments{/number}","issue_comment_url":"https://api.github.com/repos/awslabs/s2n/issues/comments{/number}","contents_url":"https://api.github.com/repos/awslabs/s2n/contents/{+path}","compare_url":"https://api.github.com/repos/awslabs/s2n/compare/{base}...{head}","merges_url":"https://api.github.com/repos/awslabs/s2n/merges","archive_url":"https://api.github.com/repos/awslabs/s2n/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/awslabs/s2n/downloads","issues_url":"https://api.github.com/repos/awslabs/s2n/issues{/number}","pulls_url":"https://api.github.com/repos/awslabs/s2n/pulls{/number}","milestones_url":"https://api.github.com/repos/awslabs/s2n/milestones{/number}","notifications_url":"https://api.github.com/repos/awslabs/s2n/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/awslabs/s2n/labels{/name}","releases_url":"https://api.github.com/repos/awslabs/s2n/releases{/id}","deployments_url":"https://api.github.com/repos/awslabs/s2n/deployments","created_at":"2014-06-27T19:37:59Z","updated_at":"2016-08-02T07:12:27Z","pushed_at":"2016-08-02T13:44:54Z","git_url":"git://github.com/awslabs/s2n.git","ssh_url":"git@github.com:awslabs/s2n.git","clone_url":"https://github.com/awslabs/s2n.git","svn_url":"https://github.com/awslabs/s2n","homepage":"","size":1900,"stargazers_count":2322,"watchers_count":2322,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":201,"mirror_url":null,"open_issues_count":41,"forks":201,"open_issues":41,"watchers":2322,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/awslabs/s2n/pulls/269"},"html":{"href":"https://github.com/awslabs/s2n/pull/269"},"issue":{"href":"https://api.github.com/repos/awslabs/s2n/issues/269"},"comments":{"href":"https://api.github.com/repos/awslabs/s2n/issues/269/comments"},"review_comments":{"href":"https://api.github.com/repos/awslabs/s2n/pulls/269/comments"},"review_comment":{"href":"https://api.github.com/repos/awslabs/s2n/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/awslabs/s2n/pulls/269/commits"},"statuses":{"href":"https://api.github.com/repos/awslabs/s2n/statuses/f0f5baa656abc52a0be667dc0a7cf655a21cce61"}}}}
{"actor":{"display_login":"colmmacc"}}