{"action":"closed","number":3,"pull_request":{"url":"https://api.github.com/repos/gap-packages/toric/pulls/3","id":99504535,"html_url":"https://github.com/gap-packages/toric/pull/3","diff_url":"https://github.com/gap-packages/toric/pull/3.diff","patch_url":"https://github.com/gap-packages/toric/pull/3.patch","issue_url":"https://api.github.com/repos/gap-packages/toric/issues/3","number":3,"state":"closed","locked":false,"title":"correct examples in documentation: typo/layout + math issue","user":{"login":"jgmbenoit","id":8476716,"avatar_url":"https://avatars.githubusercontent.com/u/8476716?v=3","gravatar_id":"","url":"https://api.github.com/users/jgmbenoit","html_url":"https://github.com/jgmbenoit","followers_url":"https://api.github.com/users/jgmbenoit/followers","following_url":"https://api.github.com/users/jgmbenoit/following{/other_user}","gists_url":"https://api.github.com/users/jgmbenoit/gists{/gist_id}","starred_url":"https://api.github.com/users/jgmbenoit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgmbenoit/subscriptions","organizations_url":"https://api.github.com/users/jgmbenoit/orgs","repos_url":"https://api.github.com/users/jgmbenoit/repos","events_url":"https://api.github.com/users/jgmbenoit/events{/privacy}","received_events_url":"https://api.github.com/users/jgmbenoit/received_events","type":"User","site_admin":false},"body":"Description: upstream: correct examples in documentation: math\r\n Testing the package itself against the samples given in the documentation\r\n with the help of ExtractExamples (section 5.4 in GAPDoc Reference Manual)\r\n exhibits an unexpected `return', at least for blind eyes. We observe\r\n ```\r\n gap> J:=IdealAffineToricVariety([[1,0],[3,4]]);\r\n <two-sided ideal in Rationals[x_1,x_2,x_3,x_4,x_5], (3 generators)>\r\n gap> GeneratorsOfIdeal(J);\r\n [ -x_4^4+x_1, -x_4^3+x_2, -x_4^2+1 ]\r\n ```\r\n while we expect\r\n ```\r\n gap> J:=IdealAffineToricVariety([[1,0],[3,4]]);\r\n [ two-sided ideal in PolynomialRing(..., [ x_1, x_2 ]), (3 generators) ]\r\n gap> GeneratorsOfIdeal(J);\r\n [ -x_2^2+x_1, -x_2^3+x_1^2, -x_2^4+x_1^3 ]\r\n ```\r\n As pointed out by the upstream maintainer [private communication], the article\r\n \"Computing with toric varieties'' in \"Journal of Symbolic Computation\"\r\n volume 42 issue 5 (May 2007, pages 511-532) [doi:10.1016/j.jsc.2006.08.005]\r\n uses this example as illustration (example 2.18 (b) p 520). At the time of\r\n patching, it is not clear neither to the upstream maintainer nor to the\r\n package maintainer whether or not the two answers are equivalent. Further\r\n investigations are on their ways.\r\n \r\n Meanwhile, to not introduce a faulty correction, the example is replaced by\r\n its sibling (example 2.18 (a) p 520) whose the expected and observed final\r\n answers are the same:\r\n ```\r\n gap> J:=IdealAffineToricVariety([[0,1],[2,-1]]);\r\n <two-sided ideal in Rationals[x_1,x_2,x_3], (1 generators)>\r\n gap> GeneratorsOfIdeal(J);\r\n [ -x_2^2+x_1 ]\r\n ```\r\n Note that this test failure might hide a serious bug.\r\nOrigin: vendor, Debian\r\nAuthor: Jerome Benoit <calculus@rezozer.net>\r\nLast-Update: 2016-12-28","created_at":"2016-12-28T03:24:03Z","updated_at":"2016-12-28T17:08:00Z","closed_at":"2016-12-28T17:08:00Z","merged_at":null,"merge_commit_sha":"58243903285bbe29891db475bcfb21256b522481","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/gap-packages/toric/pulls/3/commits","review_comments_url":"https://api.github.com/repos/gap-packages/toric/pulls/3/comments","review_comment_url":"https://api.github.com/repos/gap-packages/toric/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gap-packages/toric/issues/3/comments","statuses_url":"https://api.github.com/repos/gap-packages/toric/statuses/4834048823b3d63847267c876c7179f8f111b681","head":{"label":"jgmbenoit:debian/ITP-RFS/1.8+ds-1/documentation/examples/math+possible_bug","ref":"debian/ITP-RFS/1.8+ds-1/documentation/examples/math+possible_bug","sha":"4834048823b3d63847267c876c7179f8f111b681","user":{"login":"jgmbenoit","id":8476716,"avatar_url":"https://avatars.githubusercontent.com/u/8476716?v=3","gravatar_id":"","url":"https://api.github.com/users/jgmbenoit","html_url":"https://github.com/jgmbenoit","followers_url":"https://api.github.com/users/jgmbenoit/followers","following_url":"https://api.github.com/users/jgmbenoit/following{/other_user}","gists_url":"https://api.github.com/users/jgmbenoit/gists{/gist_id}","starred_url":"https://api.github.com/users/jgmbenoit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgmbenoit/subscriptions","organizations_url":"https://api.github.com/users/jgmbenoit/orgs","repos_url":"https://api.github.com/users/jgmbenoit/repos","events_url":"https://api.github.com/users/jgmbenoit/events{/privacy}","received_events_url":"https://api.github.com/users/jgmbenoit/received_events","type":"User","site_admin":false},"repo":{"id":77497669,"name":"toric","full_name":"jgmbenoit/toric","owner":{"login":"jgmbenoit","id":8476716,"avatar_url":"https://avatars.githubusercontent.com/u/8476716?v=3","gravatar_id":"","url":"https://api.github.com/users/jgmbenoit","html_url":"https://github.com/jgmbenoit","followers_url":"https://api.github.com/users/jgmbenoit/followers","following_url":"https://api.github.com/users/jgmbenoit/following{/other_user}","gists_url":"https://api.github.com/users/jgmbenoit/gists{/gist_id}","starred_url":"https://api.github.com/users/jgmbenoit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgmbenoit/subscriptions","organizations_url":"https://api.github.com/users/jgmbenoit/orgs","repos_url":"https://api.github.com/users/jgmbenoit/repos","events_url":"https://api.github.com/users/jgmbenoit/events{/privacy}","received_events_url":"https://api.github.com/users/jgmbenoit/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jgmbenoit/toric","description":"toric is a GAP package (gap-system.org) for doing computations with toric varieties.","fork":true,"url":"https://api.github.com/repos/jgmbenoit/toric","forks_url":"https://api.github.com/repos/jgmbenoit/toric/forks","keys_url":"https://api.github.com/repos/jgmbenoit/toric/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jgmbenoit/toric/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jgmbenoit/toric/teams","hooks_url":"https://api.github.com/repos/jgmbenoit/toric/hooks","issue_events_url":"https://api.github.com/repos/jgmbenoit/toric/issues/events{/number}","events_url":"https://api.github.com/repos/jgmbenoit/toric/events","assignees_url":"https://api.github.com/repos/jgmbenoit/toric/assignees{/user}","branches_url":"https://api.github.com/repos/jgmbenoit/toric/branches{/branch}","tags_url":"https://api.github.com/repos/jgmbenoit/toric/tags","blobs_url":"https://api.github.com/repos/jgmbenoit/toric/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jgmbenoit/toric/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jgmbenoit/toric/git/refs{/sha}","trees_url":"https://api.github.com/repos/jgmbenoit/toric/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jgmbenoit/toric/statuses/{sha}","languages_url":"https://api.github.com/repos/jgmbenoit/toric/languages","stargazers_url":"https://api.github.com/repos/jgmbenoit/toric/stargazers","contributors_url":"https://api.github.com/repos/jgmbenoit/toric/contributors","subscribers_url":"https://api.github.com/repos/jgmbenoit/toric/subscribers","subscription_url":"https://api.github.com/repos/jgmbenoit/toric/subscription","commits_url":"https://api.github.com/repos/jgmbenoit/toric/commits{/sha}","git_commits_url":"https://api.github.com/repos/jgmbenoit/toric/git/commits{/sha}","comments_url":"https://api.github.com/repos/jgmbenoit/toric/comments{/number}","issue_comment_url":"https://api.github.com/repos/jgmbenoit/toric/issues/comments{/number}","contents_url":"https://api.github.com/repos/jgmbenoit/toric/contents/{+path}","compare_url":"https://api.github.com/repos/jgmbenoit/toric/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jgmbenoit/toric/merges","archive_url":"https://api.github.com/repos/jgmbenoit/toric/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jgmbenoit/toric/downloads","issues_url":"https://api.github.com/repos/jgmbenoit/toric/issues{/number}","pulls_url":"https://api.github.com/repos/jgmbenoit/toric/pulls{/number}","milestones_url":"https://api.github.com/repos/jgmbenoit/toric/milestones{/number}","notifications_url":"https://api.github.com/repos/jgmbenoit/toric/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jgmbenoit/toric/labels{/name}","releases_url":"https://api.github.com/repos/jgmbenoit/toric/releases{/id}","deployments_url":"https://api.github.com/repos/jgmbenoit/toric/deployments","created_at":"2016-12-28T02:46:46Z","updated_at":"2016-12-28T02:46:49Z","pushed_at":"2016-12-28T03:20:37Z","git_url":"git://github.com/jgmbenoit/toric.git","ssh_url":"git@github.com:jgmbenoit/toric.git","clone_url":"https://github.com/jgmbenoit/toric.git","svn_url":"https://github.com/jgmbenoit/toric","homepage":null,"size":25,"stargazers_count":0,"watchers_count":0,"language":"GAP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gap-packages:master","ref":"master","sha":"f25a3141394a0fb26407bcdaace784b5af520945","user":{"login":"gap-packages","id":14360610,"avatar_url":"https://avatars.githubusercontent.com/u/14360610?v=3","gravatar_id":"","url":"https://api.github.com/users/gap-packages","html_url":"https://github.com/gap-packages","followers_url":"https://api.github.com/users/gap-packages/followers","following_url":"https://api.github.com/users/gap-packages/following{/other_user}","gists_url":"https://api.github.com/users/gap-packages/gists{/gist_id}","starred_url":"https://api.github.com/users/gap-packages/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gap-packages/subscriptions","organizations_url":"https://api.github.com/users/gap-packages/orgs","repos_url":"https://api.github.com/users/gap-packages/repos","events_url":"https://api.github.com/users/gap-packages/events{/privacy}","received_events_url":"https://api.github.com/users/gap-packages/received_events","type":"Organization","site_admin":false},"repo":{"id":66503281,"name":"toric","full_name":"gap-packages/toric","owner":{"login":"gap-packages","id":14360610,"avatar_url":"https://avatars.githubusercontent.com/u/14360610?v=3","gravatar_id":"","url":"https://api.github.com/users/gap-packages","html_url":"https://github.com/gap-packages","followers_url":"https://api.github.com/users/gap-packages/followers","following_url":"https://api.github.com/users/gap-packages/following{/other_user}","gists_url":"https://api.github.com/users/gap-packages/gists{/gist_id}","starred_url":"https://api.github.com/users/gap-packages/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gap-packages/subscriptions","organizations_url":"https://api.github.com/users/gap-packages/orgs","repos_url":"https://api.github.com/users/gap-packages/repos","events_url":"https://api.github.com/users/gap-packages/events{/privacy}","received_events_url":"https://api.github.com/users/gap-packages/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gap-packages/toric","description":"toric is a GAP package (gap-system.org) for doing computations with toric varieties.","fork":false,"url":"https://api.github.com/repos/gap-packages/toric","forks_url":"https://api.github.com/repos/gap-packages/toric/forks","keys_url":"https://api.github.com/repos/gap-packages/toric/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gap-packages/toric/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gap-packages/toric/teams","hooks_url":"https://api.github.com/repos/gap-packages/toric/hooks","issue_events_url":"https://api.github.com/repos/gap-packages/toric/issues/events{/number}","events_url":"https://api.github.com/repos/gap-packages/toric/events","assignees_url":"https://api.github.com/repos/gap-packages/toric/assignees{/user}","branches_url":"https://api.github.com/repos/gap-packages/toric/branches{/branch}","tags_url":"https://api.github.com/repos/gap-packages/toric/tags","blobs_url":"https://api.github.com/repos/gap-packages/toric/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gap-packages/toric/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gap-packages/toric/git/refs{/sha}","trees_url":"https://api.github.com/repos/gap-packages/toric/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gap-packages/toric/statuses/{sha}","languages_url":"https://api.github.com/repos/gap-packages/toric/languages","stargazers_url":"https://api.github.com/repos/gap-packages/toric/stargazers","contributors_url":"https://api.github.com/repos/gap-packages/toric/contributors","subscribers_url":"https://api.github.com/repos/gap-packages/toric/subscribers","subscription_url":"https://api.github.com/repos/gap-packages/toric/subscription","commits_url":"https://api.github.com/repos/gap-packages/toric/commits{/sha}","git_commits_url":"https://api.github.com/repos/gap-packages/toric/git/commits{/sha}","comments_url":"https://api.github.com/repos/gap-packages/toric/comments{/number}","issue_comment_url":"https://api.github.com/repos/gap-packages/toric/issues/comments{/number}","contents_url":"https://api.github.com/repos/gap-packages/toric/contents/{+path}","compare_url":"https://api.github.com/repos/gap-packages/toric/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gap-packages/toric/merges","archive_url":"https://api.github.com/repos/gap-packages/toric/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gap-packages/toric/downloads","issues_url":"https://api.github.com/repos/gap-packages/toric/issues{/number}","pulls_url":"https://api.github.com/repos/gap-packages/toric/pulls{/number}","milestones_url":"https://api.github.com/repos/gap-packages/toric/milestones{/number}","notifications_url":"https://api.github.com/repos/gap-packages/toric/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gap-packages/toric/labels{/name}","releases_url":"https://api.github.com/repos/gap-packages/toric/releases{/id}","deployments_url":"https://api.github.com/repos/gap-packages/toric/deployments","created_at":"2016-08-24T22:07:26Z","updated_at":"2016-08-25T15:03:13Z","pushed_at":"2016-12-28T17:08:00Z","git_url":"git://github.com/gap-packages/toric.git","ssh_url":"git@github.com:gap-packages/toric.git","clone_url":"https://github.com/gap-packages/toric.git","svn_url":"https://github.com/gap-packages/toric","homepage":null,"size":70,"stargazers_count":0,"watchers_count":0,"language":"GAP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":3,"forks":1,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gap-packages/toric/pulls/3"},"html":{"href":"https://github.com/gap-packages/toric/pull/3"},"issue":{"href":"https://api.github.com/repos/gap-packages/toric/issues/3"},"comments":{"href":"https://api.github.com/repos/gap-packages/toric/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/gap-packages/toric/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/gap-packages/toric/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gap-packages/toric/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/gap-packages/toric/statuses/4834048823b3d63847267c876c7179f8f111b681"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":3,"review_comments":0,"maintainer_can_modify":false,"commits":5,"additions":5,"deletions":3,"changed_files":1}}
{"actor":{"display_login":"fingolfin"}}