{"action":"created","comment":{"url":"https://api.github.com/repos/exceptionless/Exceptionless/pulls/comments/52247146","id":52247146,"diff_hunk":"@@ -39,6 +39,9 @@ public class ErrorPlugin : EventProcessorPluginBase {\n \n             error.Data[Error.KnownDataKeys.TargetInfo] = targetInfo;\n \n+            if (context.StackSignatureData.Count > 0)","path":"Source/Core/Plugins/EventProcessor/Default/20_ErrorPlugin.cs","position":13,"original_position":13,"commit_id":"157cda016b8c178a5035c8eba82efc55d0b4566b","original_commit_id":"157cda016b8c178a5035c8eba82efc55d0b4566b","user":{"login":"adamzolotarev","id":6343727,"avatar_url":"https://avatars.githubusercontent.com/u/6343727?v=3","gravatar_id":"","url":"https://api.github.com/users/adamzolotarev","html_url":"https://github.com/adamzolotarev","followers_url":"https://api.github.com/users/adamzolotarev/followers","following_url":"https://api.github.com/users/adamzolotarev/following{/other_user}","gists_url":"https://api.github.com/users/adamzolotarev/gists{/gist_id}","starred_url":"https://api.github.com/users/adamzolotarev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamzolotarev/subscriptions","organizations_url":"https://api.github.com/users/adamzolotarev/orgs","repos_url":"https://api.github.com/users/adamzolotarev/repos","events_url":"https://api.github.com/users/adamzolotarev/events{/privacy}","received_events_url":"https://api.github.com/users/adamzolotarev/received_events","type":"User","site_admin":false},"body":"If I remove this line, then the stack signature will be different. I want the signature to be based on the manual stacking key only. I think it makes sense to check just the known key instead. I'll update the code.\r\n\r\nI'll write some tests. Thanks!","created_at":"2016-02-08T23:46:00Z","updated_at":"2016-02-08T23:46:00Z","html_url":"https://github.com/exceptionless/Exceptionless/pull/187#discussion_r52247146","pull_request_url":"https://api.github.com/repos/exceptionless/Exceptionless/pulls/187","_links":{"self":{"href":"https://api.github.com/repos/exceptionless/Exceptionless/pulls/comments/52247146"},"html":{"href":"https://github.com/exceptionless/Exceptionless/pull/187#discussion_r52247146"},"pull_request":{"href":"https://api.github.com/repos/exceptionless/Exceptionless/pulls/187"}}},"pull_request":{"url":"https://api.github.com/repos/exceptionless/Exceptionless/pulls/187","id":58509841,"html_url":"https://github.com/exceptionless/Exceptionless/pull/187","diff_url":"https://github.com/exceptionless/Exceptionless/pull/187.diff","patch_url":"https://github.com/exceptionless/Exceptionless/pull/187.patch","issue_url":"https://api.github.com/repos/exceptionless/Exceptionless/issues/187","number":187,"state":"open","locked":false,"title":"Manual stacking","user":{"login":"adamzolotarev","id":6343727,"avatar_url":"https://avatars.githubusercontent.com/u/6343727?v=3","gravatar_id":"","url":"https://api.github.com/users/adamzolotarev","html_url":"https://github.com/adamzolotarev","followers_url":"https://api.github.com/users/adamzolotarev/followers","following_url":"https://api.github.com/users/adamzolotarev/following{/other_user}","gists_url":"https://api.github.com/users/adamzolotarev/gists{/gist_id}","starred_url":"https://api.github.com/users/adamzolotarev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamzolotarev/subscriptions","organizations_url":"https://api.github.com/users/adamzolotarev/orgs","repos_url":"https://api.github.com/users/adamzolotarev/repos","events_url":"https://api.github.com/users/adamzolotarev/events{/privacy}","received_events_url":"https://api.github.com/users/adamzolotarev/received_events","type":"User","site_admin":false},"body":"Added manual stacking plugin. Don't add signature data in the error plugin if already added manual stacking. Error plugin still sets message and target info.","created_at":"2016-02-06T03:13:51Z","updated_at":"2016-02-08T23:46:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b6daaeecad264240814d454e2a3593302af3c1d1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/exceptionless/Exceptionless/pulls/187/commits","review_comments_url":"https://api.github.com/repos/exceptionless/Exceptionless/pulls/187/comments","review_comment_url":"https://api.github.com/repos/exceptionless/Exceptionless/pulls/comments{/number}","comments_url":"https://api.github.com/repos/exceptionless/Exceptionless/issues/187/comments","statuses_url":"https://api.github.com/repos/exceptionless/Exceptionless/statuses/157cda016b8c178a5035c8eba82efc55d0b4566b","head":{"label":"adamzolotarev:ManualStacking","ref":"ManualStacking","sha":"157cda016b8c178a5035c8eba82efc55d0b4566b","user":{"login":"adamzolotarev","id":6343727,"avatar_url":"https://avatars.githubusercontent.com/u/6343727?v=3","gravatar_id":"","url":"https://api.github.com/users/adamzolotarev","html_url":"https://github.com/adamzolotarev","followers_url":"https://api.github.com/users/adamzolotarev/followers","following_url":"https://api.github.com/users/adamzolotarev/following{/other_user}","gists_url":"https://api.github.com/users/adamzolotarev/gists{/gist_id}","starred_url":"https://api.github.com/users/adamzolotarev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamzolotarev/subscriptions","organizations_url":"https://api.github.com/users/adamzolotarev/orgs","repos_url":"https://api.github.com/users/adamzolotarev/repos","events_url":"https://api.github.com/users/adamzolotarev/events{/privacy}","received_events_url":"https://api.github.com/users/adamzolotarev/received_events","type":"User","site_admin":false},"repo":{"id":43190874,"name":"Exceptionless","full_name":"adamzolotarev/Exceptionless","owner":{"login":"adamzolotarev","id":6343727,"avatar_url":"https://avatars.githubusercontent.com/u/6343727?v=3","gravatar_id":"","url":"https://api.github.com/users/adamzolotarev","html_url":"https://github.com/adamzolotarev","followers_url":"https://api.github.com/users/adamzolotarev/followers","following_url":"https://api.github.com/users/adamzolotarev/following{/other_user}","gists_url":"https://api.github.com/users/adamzolotarev/gists{/gist_id}","starred_url":"https://api.github.com/users/adamzolotarev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamzolotarev/subscriptions","organizations_url":"https://api.github.com/users/adamzolotarev/orgs","repos_url":"https://api.github.com/users/adamzolotarev/repos","events_url":"https://api.github.com/users/adamzolotarev/events{/privacy}","received_events_url":"https://api.github.com/users/adamzolotarev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/adamzolotarev/Exceptionless","description":"Exceptionless server and jobs","fork":true,"url":"https://api.github.com/repos/adamzolotarev/Exceptionless","forks_url":"https://api.github.com/repos/adamzolotarev/Exceptionless/forks","keys_url":"https://api.github.com/repos/adamzolotarev/Exceptionless/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adamzolotarev/Exceptionless/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adamzolotarev/Exceptionless/teams","hooks_url":"https://api.github.com/repos/adamzolotarev/Exceptionless/hooks","issue_events_url":"https://api.github.com/repos/adamzolotarev/Exceptionless/issues/events{/number}","events_url":"https://api.github.com/repos/adamzolotarev/Exceptionless/events","assignees_url":"https://api.github.com/repos/adamzolotarev/Exceptionless/assignees{/user}","branches_url":"https://api.github.com/repos/adamzolotarev/Exceptionless/branches{/branch}","tags_url":"https://api.github.com/repos/adamzolotarev/Exceptionless/tags","blobs_url":"https://api.github.com/repos/adamzolotarev/Exceptionless/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adamzolotarev/Exceptionless/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adamzolotarev/Exceptionless/git/refs{/sha}","trees_url":"https://api.github.com/repos/adamzolotarev/Exceptionless/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adamzolotarev/Exceptionless/statuses/{sha}","languages_url":"https://api.github.com/repos/adamzolotarev/Exceptionless/languages","stargazers_url":"https://api.github.com/repos/adamzolotarev/Exceptionless/stargazers","contributors_url":"https://api.github.com/repos/adamzolotarev/Exceptionless/contributors","subscribers_url":"https://api.github.com/repos/adamzolotarev/Exceptionless/subscribers","subscription_url":"https://api.github.com/repos/adamzolotarev/Exceptionless/subscription","commits_url":"https://api.github.com/repos/adamzolotarev/Exceptionless/commits{/sha}","git_commits_url":"https://api.github.com/repos/adamzolotarev/Exceptionless/git/commits{/sha}","comments_url":"https://api.github.com/repos/adamzolotarev/Exceptionless/comments{/number}","issue_comment_url":"https://api.github.com/repos/adamzolotarev/Exceptionless/issues/comments{/number}","contents_url":"https://api.github.com/repos/adamzolotarev/Exceptionless/contents/{+path}","compare_url":"https://api.github.com/repos/adamzolotarev/Exceptionless/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adamzolotarev/Exceptionless/merges","archive_url":"https://api.github.com/repos/adamzolotarev/Exceptionless/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adamzolotarev/Exceptionless/downloads","issues_url":"https://api.github.com/repos/adamzolotarev/Exceptionless/issues{/number}","pulls_url":"https://api.github.com/repos/adamzolotarev/Exceptionless/pulls{/number}","milestones_url":"https://api.github.com/repos/adamzolotarev/Exceptionless/milestones{/number}","notifications_url":"https://api.github.com/repos/adamzolotarev/Exceptionless/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adamzolotarev/Exceptionless/labels{/name}","releases_url":"https://api.github.com/repos/adamzolotarev/Exceptionless/releases{/id}","deployments_url":"https://api.github.com/repos/adamzolotarev/Exceptionless/deployments","created_at":"2015-09-26T03:50:54Z","updated_at":"2016-01-23T18:36:00Z","pushed_at":"2016-02-06T03:18:19Z","git_url":"git://github.com/adamzolotarev/Exceptionless.git","ssh_url":"git@github.com:adamzolotarev/Exceptionless.git","clone_url":"https://github.com/adamzolotarev/Exceptionless.git","svn_url":"https://github.com/adamzolotarev/Exceptionless","homepage":"http://exceptionless.com","size":73980,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"exceptionless:master","ref":"master","sha":"4b4c5193bfb9a44b41f862891a01dd203fe0f7a9","user":{"login":"exceptionless","id":5912469,"avatar_url":"https://avatars.githubusercontent.com/u/5912469?v=3","gravatar_id":"","url":"https://api.github.com/users/exceptionless","html_url":"https://github.com/exceptionless","followers_url":"https://api.github.com/users/exceptionless/followers","following_url":"https://api.github.com/users/exceptionless/following{/other_user}","gists_url":"https://api.github.com/users/exceptionless/gists{/gist_id}","starred_url":"https://api.github.com/users/exceptionless/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exceptionless/subscriptions","organizations_url":"https://api.github.com/users/exceptionless/orgs","repos_url":"https://api.github.com/users/exceptionless/repos","events_url":"https://api.github.com/users/exceptionless/events{/privacy}","received_events_url":"https://api.github.com/users/exceptionless/received_events","type":"Organization","site_admin":false},"repo":{"id":16599849,"name":"Exceptionless","full_name":"exceptionless/Exceptionless","owner":{"login":"exceptionless","id":5912469,"avatar_url":"https://avatars.githubusercontent.com/u/5912469?v=3","gravatar_id":"","url":"https://api.github.com/users/exceptionless","html_url":"https://github.com/exceptionless","followers_url":"https://api.github.com/users/exceptionless/followers","following_url":"https://api.github.com/users/exceptionless/following{/other_user}","gists_url":"https://api.github.com/users/exceptionless/gists{/gist_id}","starred_url":"https://api.github.com/users/exceptionless/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exceptionless/subscriptions","organizations_url":"https://api.github.com/users/exceptionless/orgs","repos_url":"https://api.github.com/users/exceptionless/repos","events_url":"https://api.github.com/users/exceptionless/events{/privacy}","received_events_url":"https://api.github.com/users/exceptionless/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/exceptionless/Exceptionless","description":"Exceptionless server and jobs","fork":false,"url":"https://api.github.com/repos/exceptionless/Exceptionless","forks_url":"https://api.github.com/repos/exceptionless/Exceptionless/forks","keys_url":"https://api.github.com/repos/exceptionless/Exceptionless/keys{/key_id}","collaborators_url":"https://api.github.com/repos/exceptionless/Exceptionless/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/exceptionless/Exceptionless/teams","hooks_url":"https://api.github.com/repos/exceptionless/Exceptionless/hooks","issue_events_url":"https://api.github.com/repos/exceptionless/Exceptionless/issues/events{/number}","events_url":"https://api.github.com/repos/exceptionless/Exceptionless/events","assignees_url":"https://api.github.com/repos/exceptionless/Exceptionless/assignees{/user}","branches_url":"https://api.github.com/repos/exceptionless/Exceptionless/branches{/branch}","tags_url":"https://api.github.com/repos/exceptionless/Exceptionless/tags","blobs_url":"https://api.github.com/repos/exceptionless/Exceptionless/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/exceptionless/Exceptionless/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/exceptionless/Exceptionless/git/refs{/sha}","trees_url":"https://api.github.com/repos/exceptionless/Exceptionless/git/trees{/sha}","statuses_url":"https://api.github.com/repos/exceptionless/Exceptionless/statuses/{sha}","languages_url":"https://api.github.com/repos/exceptionless/Exceptionless/languages","stargazers_url":"https://api.github.com/repos/exceptionless/Exceptionless/stargazers","contributors_url":"https://api.github.com/repos/exceptionless/Exceptionless/contributors","subscribers_url":"https://api.github.com/repos/exceptionless/Exceptionless/subscribers","subscription_url":"https://api.github.com/repos/exceptionless/Exceptionless/subscription","commits_url":"https://api.github.com/repos/exceptionless/Exceptionless/commits{/sha}","git_commits_url":"https://api.github.com/repos/exceptionless/Exceptionless/git/commits{/sha}","comments_url":"https://api.github.com/repos/exceptionless/Exceptionless/comments{/number}","issue_comment_url":"https://api.github.com/repos/exceptionless/Exceptionless/issues/comments{/number}","contents_url":"https://api.github.com/repos/exceptionless/Exceptionless/contents/{+path}","compare_url":"https://api.github.com/repos/exceptionless/Exceptionless/compare/{base}...{head}","merges_url":"https://api.github.com/repos/exceptionless/Exceptionless/merges","archive_url":"https://api.github.com/repos/exceptionless/Exceptionless/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/exceptionless/Exceptionless/downloads","issues_url":"https://api.github.com/repos/exceptionless/Exceptionless/issues{/number}","pulls_url":"https://api.github.com/repos/exceptionless/Exceptionless/pulls{/number}","milestones_url":"https://api.github.com/repos/exceptionless/Exceptionless/milestones{/number}","notifications_url":"https://api.github.com/repos/exceptionless/Exceptionless/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/exceptionless/Exceptionless/labels{/name}","releases_url":"https://api.github.com/repos/exceptionless/Exceptionless/releases{/id}","deployments_url":"https://api.github.com/repos/exceptionless/Exceptionless/deployments","created_at":"2014-02-07T00:48:37Z","updated_at":"2016-02-05T04:00:02Z","pushed_at":"2016-02-06T03:13:52Z","git_url":"git://github.com/exceptionless/Exceptionless.git","ssh_url":"git@github.com:exceptionless/Exceptionless.git","clone_url":"https://github.com/exceptionless/Exceptionless.git","svn_url":"https://github.com/exceptionless/Exceptionless","homepage":"http://exceptionless.com","size":75162,"stargazers_count":411,"watchers_count":411,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":143,"mirror_url":null,"open_issues_count":30,"forks":143,"open_issues":30,"watchers":411,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/exceptionless/Exceptionless/pulls/187"},"html":{"href":"https://github.com/exceptionless/Exceptionless/pull/187"},"issue":{"href":"https://api.github.com/repos/exceptionless/Exceptionless/issues/187"},"comments":{"href":"https://api.github.com/repos/exceptionless/Exceptionless/issues/187/comments"},"review_comments":{"href":"https://api.github.com/repos/exceptionless/Exceptionless/pulls/187/comments"},"review_comment":{"href":"https://api.github.com/repos/exceptionless/Exceptionless/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/exceptionless/Exceptionless/pulls/187/commits"},"statuses":{"href":"https://api.github.com/repos/exceptionless/Exceptionless/statuses/157cda016b8c178a5035c8eba82efc55d0b4566b"}}}}