{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/origin/pulls/comments/50938494","id":50938494,"diff_hunk":"@@ -130,6 +130,10 @@ func GetMasterFileReferences(config *MasterConfig) []*string {\n \trefs = append(refs, &config.EtcdClientInfo.ClientCert.KeyFile)\n \trefs = append(refs, &config.EtcdClientInfo.CA)\n \n+\trefs = append(refs, &config.KubernetesMasterConfig.KubernetesEtcdClientInfo.ClientCert.CertFile)","path":"pkg/cmd/server/api/helpers.go","position":4,"original_position":4,"commit_id":"d266a6372e4306dc0e38ccb32a5cedc78a0a66d5","original_commit_id":"d266a6372e4306dc0e38ccb32a5cedc78a0a66d5","user":{"login":"liggitt","id":980082,"avatar_url":"https://avatars.githubusercontent.com/u/980082?v=3","gravatar_id":"","url":"https://api.github.com/users/liggitt","html_url":"https://github.com/liggitt","followers_url":"https://api.github.com/users/liggitt/followers","following_url":"https://api.github.com/users/liggitt/following{/other_user}","gists_url":"https://api.github.com/users/liggitt/gists{/gist_id}","starred_url":"https://api.github.com/users/liggitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liggitt/subscriptions","organizations_url":"https://api.github.com/users/liggitt/orgs","repos_url":"https://api.github.com/users/liggitt/repos","events_url":"https://api.github.com/users/liggitt/events{/privacy}","received_events_url":"https://api.github.com/users/liggitt/received_events","type":"User","site_admin":false},"body":"move these inside the `if config.KubernetesMasterConfig != nil` check below, and add an additional check to make sure `KubernetesEtcdClientInfo` is not nil","created_at":"2016-01-27T03:52:38Z","updated_at":"2016-01-27T03:52:38Z","html_url":"https://github.com/openshift/origin/pull/6838#discussion_r50938494","pull_request_url":"https://api.github.com/repos/openshift/origin/pulls/6838","_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments/50938494"},"html":{"href":"https://github.com/openshift/origin/pull/6838#discussion_r50938494"},"pull_request":{"href":"https://api.github.com/repos/openshift/origin/pulls/6838"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/6838","id":57253826,"html_url":"https://github.com/openshift/origin/pull/6838","diff_url":"https://github.com/openshift/origin/pull/6838.diff","patch_url":"https://github.com/openshift/origin/pull/6838.patch","issue_url":"https://api.github.com/repos/openshift/origin/issues/6838","number":6838,"state":"open","locked":false,"title":"Allow separating kubernetes and openshift data to different etcds.","user":{"login":"rrati","id":87555,"avatar_url":"https://avatars.githubusercontent.com/u/87555?v=3","gravatar_id":"","url":"https://api.github.com/users/rrati","html_url":"https://github.com/rrati","followers_url":"https://api.github.com/users/rrati/followers","following_url":"https://api.github.com/users/rrati/following{/other_user}","gists_url":"https://api.github.com/users/rrati/gists{/gist_id}","starred_url":"https://api.github.com/users/rrati/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rrati/subscriptions","organizations_url":"https://api.github.com/users/rrati/orgs","repos_url":"https://api.github.com/users/rrati/repos","events_url":"https://api.github.com/users/rrati/events{/privacy}","received_events_url":"https://api.github.com/users/rrati/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-01-26T18:49:50Z","updated_at":"2016-01-27T03:52:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cabb161909af7ba2b5d8b96c9f4696fef691d101","assignee":{"login":"deads2k","id":8225098,"avatar_url":"https://avatars.githubusercontent.com/u/8225098?v=3","gravatar_id":"","url":"https://api.github.com/users/deads2k","html_url":"https://github.com/deads2k","followers_url":"https://api.github.com/users/deads2k/followers","following_url":"https://api.github.com/users/deads2k/following{/other_user}","gists_url":"https://api.github.com/users/deads2k/gists{/gist_id}","starred_url":"https://api.github.com/users/deads2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deads2k/subscriptions","organizations_url":"https://api.github.com/users/deads2k/orgs","repos_url":"https://api.github.com/users/deads2k/repos","events_url":"https://api.github.com/users/deads2k/events{/privacy}","received_events_url":"https://api.github.com/users/deads2k/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin/pulls/6838/commits","review_comments_url":"https://api.github.com/repos/openshift/origin/pulls/6838/comments","review_comment_url":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin/issues/6838/comments","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/d266a6372e4306dc0e38ccb32a5cedc78a0a66d5","head":{"label":"rrati:sharding-storage","ref":"sharding-storage","sha":"d266a6372e4306dc0e38ccb32a5cedc78a0a66d5","user":{"login":"rrati","id":87555,"avatar_url":"https://avatars.githubusercontent.com/u/87555?v=3","gravatar_id":"","url":"https://api.github.com/users/rrati","html_url":"https://github.com/rrati","followers_url":"https://api.github.com/users/rrati/followers","following_url":"https://api.github.com/users/rrati/following{/other_user}","gists_url":"https://api.github.com/users/rrati/gists{/gist_id}","starred_url":"https://api.github.com/users/rrati/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rrati/subscriptions","organizations_url":"https://api.github.com/users/rrati/orgs","repos_url":"https://api.github.com/users/rrati/repos","events_url":"https://api.github.com/users/rrati/events{/privacy}","received_events_url":"https://api.github.com/users/rrati/received_events","type":"User","site_admin":false},"repo":{"id":50365494,"name":"origin","full_name":"rrati/origin","owner":{"login":"rrati","id":87555,"avatar_url":"https://avatars.githubusercontent.com/u/87555?v=3","gravatar_id":"","url":"https://api.github.com/users/rrati","html_url":"https://github.com/rrati","followers_url":"https://api.github.com/users/rrati/followers","following_url":"https://api.github.com/users/rrati/following{/other_user}","gists_url":"https://api.github.com/users/rrati/gists{/gist_id}","starred_url":"https://api.github.com/users/rrati/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rrati/subscriptions","organizations_url":"https://api.github.com/users/rrati/orgs","repos_url":"https://api.github.com/users/rrati/repos","events_url":"https://api.github.com/users/rrati/events{/privacy}","received_events_url":"https://api.github.com/users/rrati/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rrati/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":true,"url":"https://api.github.com/repos/rrati/origin","forks_url":"https://api.github.com/repos/rrati/origin/forks","keys_url":"https://api.github.com/repos/rrati/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rrati/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rrati/origin/teams","hooks_url":"https://api.github.com/repos/rrati/origin/hooks","issue_events_url":"https://api.github.com/repos/rrati/origin/issues/events{/number}","events_url":"https://api.github.com/repos/rrati/origin/events","assignees_url":"https://api.github.com/repos/rrati/origin/assignees{/user}","branches_url":"https://api.github.com/repos/rrati/origin/branches{/branch}","tags_url":"https://api.github.com/repos/rrati/origin/tags","blobs_url":"https://api.github.com/repos/rrati/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rrati/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rrati/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/rrati/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rrati/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/rrati/origin/languages","stargazers_url":"https://api.github.com/repos/rrati/origin/stargazers","contributors_url":"https://api.github.com/repos/rrati/origin/contributors","subscribers_url":"https://api.github.com/repos/rrati/origin/subscribers","subscription_url":"https://api.github.com/repos/rrati/origin/subscription","commits_url":"https://api.github.com/repos/rrati/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/rrati/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/rrati/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/rrati/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/rrati/origin/contents/{+path}","compare_url":"https://api.github.com/repos/rrati/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rrati/origin/merges","archive_url":"https://api.github.com/repos/rrati/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rrati/origin/downloads","issues_url":"https://api.github.com/repos/rrati/origin/issues{/number}","pulls_url":"https://api.github.com/repos/rrati/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/rrati/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/rrati/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rrati/origin/labels{/name}","releases_url":"https://api.github.com/repos/rrati/origin/releases{/id}","deployments_url":"https://api.github.com/repos/rrati/origin/deployments","created_at":"2016-01-25T16:51:11Z","updated_at":"2016-01-25T16:51:17Z","pushed_at":"2016-01-26T20:52:22Z","git_url":"git://github.com/rrati/origin.git","ssh_url":"git@github.com:rrati/origin.git","clone_url":"https://github.com/rrati/origin.git","svn_url":"https://github.com/rrati/origin","homepage":"http://www.openshift.org","size":197509,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"4a88b41c7c6e6848eeeaf515d5f4f86d85dd15c2","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":22442668,"name":"origin","full_name":"openshift/origin","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":false,"url":"https://api.github.com/repos/openshift/origin","forks_url":"https://api.github.com/repos/openshift/origin/forks","keys_url":"https://api.github.com/repos/openshift/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin/teams","hooks_url":"https://api.github.com/repos/openshift/origin/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin/events","assignees_url":"https://api.github.com/repos/openshift/origin/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin/tags","blobs_url":"https://api.github.com/repos/openshift/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin/languages","stargazers_url":"https://api.github.com/repos/openshift/origin/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin/subscription","commits_url":"https://api.github.com/repos/openshift/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin/merges","archive_url":"https://api.github.com/repos/openshift/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin/downloads","issues_url":"https://api.github.com/repos/openshift/origin/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/origin/deployments","created_at":"2014-07-30T20:04:05Z","updated_at":"2016-01-27T03:48:46Z","pushed_at":"2016-01-27T03:33:16Z","git_url":"git://github.com/openshift/origin.git","ssh_url":"git@github.com:openshift/origin.git","clone_url":"https://github.com/openshift/origin.git","svn_url":"https://github.com/openshift/origin","homepage":"http://www.openshift.org","size":249077,"stargazers_count":933,"watchers_count":933,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":597,"mirror_url":null,"open_issues_count":772,"forks":597,"open_issues":772,"watchers":933,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/6838"},"html":{"href":"https://github.com/openshift/origin/pull/6838"},"issue":{"href":"https://api.github.com/repos/openshift/origin/issues/6838"},"comments":{"href":"https://api.github.com/repos/openshift/origin/issues/6838/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin/pulls/6838/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin/pulls/6838/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin/statuses/d266a6372e4306dc0e38ccb32a5cedc78a0a66d5"}}}}