{"action":"created","comment":{"url":"https://api.github.com/repos/ucb-bar/rocket-chip/pulls/comments/80727594","pull_request_review_id":1763394,"id":80727594,"diff_hunk":"@@ -50,7 +50,7 @@ abstract class BaseCoreplex(c: CoreplexConfig)(implicit p: Parameters) extends L\n \n abstract class BaseCoreplexBundle(val c: CoreplexConfig)(implicit val p: Parameters) extends Bundle with HasCoreplexParameters {\n   val master = new Bundle {\n-    val mem = Vec(c.nMemChannels, new ClientUncachedTileLinkIO()(outermostParams))\n+    val mem = Vec(c.nMemChannels, new ClientUncachedTileLinkIO()(outerMemParams))","path":"src/main/scala/coreplex/BaseCoreplex.scala","position":15,"original_position":15,"commit_id":"65030f3b73596ef3a216922901b704c863a67086","original_commit_id":"65030f3b73596ef3a216922901b704c863a67086","user":{"login":"yunsup","id":703957,"avatar_url":"https://avatars.githubusercontent.com/u/703957?v=3","gravatar_id":"","url":"https://api.github.com/users/yunsup","html_url":"https://github.com/yunsup","followers_url":"https://api.github.com/users/yunsup/followers","following_url":"https://api.github.com/users/yunsup/following{/other_user}","gists_url":"https://api.github.com/users/yunsup/gists{/gist_id}","starred_url":"https://api.github.com/users/yunsup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yunsup/subscriptions","organizations_url":"https://api.github.com/users/yunsup/orgs","repos_url":"https://api.github.com/users/yunsup/repos","events_url":"https://api.github.com/users/yunsup/events{/privacy}","received_events_url":"https://api.github.com/users/yunsup/received_events","type":"User","site_admin":false},"body":"This is changing behavior.  Was this a bug before?","created_at":"2016-09-27T15:55:03Z","updated_at":"2016-09-27T15:55:03Z","html_url":"https://github.com/ucb-bar/rocket-chip/pull/349#discussion_r80727594","pull_request_url":"https://api.github.com/repos/ucb-bar/rocket-chip/pulls/349","_links":{"self":{"href":"https://api.github.com/repos/ucb-bar/rocket-chip/pulls/comments/80727594"},"html":{"href":"https://github.com/ucb-bar/rocket-chip/pull/349#discussion_r80727594"},"pull_request":{"href":"https://api.github.com/repos/ucb-bar/rocket-chip/pulls/349"}}},"pull_request":{"url":"https://api.github.com/repos/ucb-bar/rocket-chip/pulls/349","id":86869651,"html_url":"https://github.com/ucb-bar/rocket-chip/pull/349","diff_url":"https://github.com/ucb-bar/rocket-chip/pull/349.diff","patch_url":"https://github.com/ucb-bar/rocket-chip/pull/349.patch","issue_url":"https://api.github.com/repos/ucb-bar/rocket-chip/issues/349","number":349,"state":"open","locked":false,"title":"Give TileLink keys more sensible names","user":{"login":"zhemao","id":433799,"avatar_url":"https://avatars.githubusercontent.com/u/433799?v=3","gravatar_id":"","url":"https://api.github.com/users/zhemao","html_url":"https://github.com/zhemao","followers_url":"https://api.github.com/users/zhemao/followers","following_url":"https://api.github.com/users/zhemao/following{/other_user}","gists_url":"https://api.github.com/users/zhemao/gists{/gist_id}","starred_url":"https://api.github.com/users/zhemao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhemao/subscriptions","organizations_url":"https://api.github.com/users/zhemao/orgs","repos_url":"https://api.github.com/users/zhemao/repos","events_url":"https://api.github.com/users/zhemao/events{/privacy}","received_events_url":"https://api.github.com/users/zhemao/received_events","type":"User","site_admin":false},"body":"The \"Outermost\" and \"MMIO_Outermost\" keys are renamed to \"MCtoEdge\"\r\nand \"MMIOtoEdge\". They are only used after width conversion to adapt to\r\nexternal interfaces in the periphery.\r\n\r\nThat means there is no longer any width adapting done in the Coreplex,\r\nthe width adapter is moved to the Periphery just before conversion\r\nto AXI/AHB or sending off chip.\r\n\r\nWe also add an additional TLKey \"EdgetoSlave\" for the bus_axi interface.\r\nThis means there is also a width adapter from the AXI -> TL converter\r\nto the coreplex slave port.\r\n\r\nThis also fixes a bug introduced previously in which the wrong\r\nparameters object is given to the width adapter for external MMIO.","created_at":"2016-09-27T06:35:13Z","updated_at":"2016-09-27T15:55:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2c538879c31dd5bf11bbf2875a393dca6b7e6910","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ucb-bar/rocket-chip/pulls/349/commits","review_comments_url":"https://api.github.com/repos/ucb-bar/rocket-chip/pulls/349/comments","review_comment_url":"https://api.github.com/repos/ucb-bar/rocket-chip/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ucb-bar/rocket-chip/issues/349/comments","statuses_url":"https://api.github.com/repos/ucb-bar/rocket-chip/statuses/65030f3b73596ef3a216922901b704c863a67086","head":{"label":"ucb-bar:tl1-params-fix","ref":"tl1-params-fix","sha":"65030f3b73596ef3a216922901b704c863a67086","user":{"login":"ucb-bar","id":998197,"avatar_url":"https://avatars.githubusercontent.com/u/998197?v=3","gravatar_id":"","url":"https://api.github.com/users/ucb-bar","html_url":"https://github.com/ucb-bar","followers_url":"https://api.github.com/users/ucb-bar/followers","following_url":"https://api.github.com/users/ucb-bar/following{/other_user}","gists_url":"https://api.github.com/users/ucb-bar/gists{/gist_id}","starred_url":"https://api.github.com/users/ucb-bar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ucb-bar/subscriptions","organizations_url":"https://api.github.com/users/ucb-bar/orgs","repos_url":"https://api.github.com/users/ucb-bar/repos","events_url":"https://api.github.com/users/ucb-bar/events{/privacy}","received_events_url":"https://api.github.com/users/ucb-bar/received_events","type":"Organization","site_admin":false},"repo":{"id":23950406,"name":"rocket-chip","full_name":"ucb-bar/rocket-chip","owner":{"login":"ucb-bar","id":998197,"avatar_url":"https://avatars.githubusercontent.com/u/998197?v=3","gravatar_id":"","url":"https://api.github.com/users/ucb-bar","html_url":"https://github.com/ucb-bar","followers_url":"https://api.github.com/users/ucb-bar/followers","following_url":"https://api.github.com/users/ucb-bar/following{/other_user}","gists_url":"https://api.github.com/users/ucb-bar/gists{/gist_id}","starred_url":"https://api.github.com/users/ucb-bar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ucb-bar/subscriptions","organizations_url":"https://api.github.com/users/ucb-bar/orgs","repos_url":"https://api.github.com/users/ucb-bar/repos","events_url":"https://api.github.com/users/ucb-bar/events{/privacy}","received_events_url":"https://api.github.com/users/ucb-bar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ucb-bar/rocket-chip","description":"Rocket Chip Generator","fork":false,"url":"https://api.github.com/repos/ucb-bar/rocket-chip","forks_url":"https://api.github.com/repos/ucb-bar/rocket-chip/forks","keys_url":"https://api.github.com/repos/ucb-bar/rocket-chip/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ucb-bar/rocket-chip/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ucb-bar/rocket-chip/teams","hooks_url":"https://api.github.com/repos/ucb-bar/rocket-chip/hooks","issue_events_url":"https://api.github.com/repos/ucb-bar/rocket-chip/issues/events{/number}","events_url":"https://api.github.com/repos/ucb-bar/rocket-chip/events","assignees_url":"https://api.github.com/repos/ucb-bar/rocket-chip/assignees{/user}","branches_url":"https://api.github.com/repos/ucb-bar/rocket-chip/branches{/branch}","tags_url":"https://api.github.com/repos/ucb-bar/rocket-chip/tags","blobs_url":"https://api.github.com/repos/ucb-bar/rocket-chip/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ucb-bar/rocket-chip/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ucb-bar/rocket-chip/git/refs{/sha}","trees_url":"https://api.github.com/repos/ucb-bar/rocket-chip/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ucb-bar/rocket-chip/statuses/{sha}","languages_url":"https://api.github.com/repos/ucb-bar/rocket-chip/languages","stargazers_url":"https://api.github.com/repos/ucb-bar/rocket-chip/stargazers","contributors_url":"https://api.github.com/repos/ucb-bar/rocket-chip/contributors","subscribers_url":"https://api.github.com/repos/ucb-bar/rocket-chip/subscribers","subscription_url":"https://api.github.com/repos/ucb-bar/rocket-chip/subscription","commits_url":"https://api.github.com/repos/ucb-bar/rocket-chip/commits{/sha}","git_commits_url":"https://api.github.com/repos/ucb-bar/rocket-chip/git/commits{/sha}","comments_url":"https://api.github.com/repos/ucb-bar/rocket-chip/comments{/number}","issue_comment_url":"https://api.github.com/repos/ucb-bar/rocket-chip/issues/comments{/number}","contents_url":"https://api.github.com/repos/ucb-bar/rocket-chip/contents/{+path}","compare_url":"https://api.github.com/repos/ucb-bar/rocket-chip/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ucb-bar/rocket-chip/merges","archive_url":"https://api.github.com/repos/ucb-bar/rocket-chip/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ucb-bar/rocket-chip/downloads","issues_url":"https://api.github.com/repos/ucb-bar/rocket-chip/issues{/number}","pulls_url":"https://api.github.com/repos/ucb-bar/rocket-chip/pulls{/number}","milestones_url":"https://api.github.com/repos/ucb-bar/rocket-chip/milestones{/number}","notifications_url":"https://api.github.com/repos/ucb-bar/rocket-chip/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ucb-bar/rocket-chip/labels{/name}","releases_url":"https://api.github.com/repos/ucb-bar/rocket-chip/releases{/id}","deployments_url":"https://api.github.com/repos/ucb-bar/rocket-chip/deployments","created_at":"2014-09-12T07:04:30Z","updated_at":"2016-09-24T00:08:47Z","pushed_at":"2016-09-27T07:02:19Z","git_url":"git://github.com/ucb-bar/rocket-chip.git","ssh_url":"git@github.com:ucb-bar/rocket-chip.git","clone_url":"https://github.com/ucb-bar/rocket-chip.git","svn_url":"https://github.com/ucb-bar/rocket-chip","homepage":null,"size":12680,"stargazers_count":166,"watchers_count":166,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":88,"mirror_url":null,"open_issues_count":14,"forks":88,"open_issues":14,"watchers":166,"default_branch":"master"}},"base":{"label":"ucb-bar:master","ref":"master","sha":"6316ebd58f0eda2cd3d78a64c47d0e2d2b394840","user":{"login":"ucb-bar","id":998197,"avatar_url":"https://avatars.githubusercontent.com/u/998197?v=3","gravatar_id":"","url":"https://api.github.com/users/ucb-bar","html_url":"https://github.com/ucb-bar","followers_url":"https://api.github.com/users/ucb-bar/followers","following_url":"https://api.github.com/users/ucb-bar/following{/other_user}","gists_url":"https://api.github.com/users/ucb-bar/gists{/gist_id}","starred_url":"https://api.github.com/users/ucb-bar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ucb-bar/subscriptions","organizations_url":"https://api.github.com/users/ucb-bar/orgs","repos_url":"https://api.github.com/users/ucb-bar/repos","events_url":"https://api.github.com/users/ucb-bar/events{/privacy}","received_events_url":"https://api.github.com/users/ucb-bar/received_events","type":"Organization","site_admin":false},"repo":{"id":23950406,"name":"rocket-chip","full_name":"ucb-bar/rocket-chip","owner":{"login":"ucb-bar","id":998197,"avatar_url":"https://avatars.githubusercontent.com/u/998197?v=3","gravatar_id":"","url":"https://api.github.com/users/ucb-bar","html_url":"https://github.com/ucb-bar","followers_url":"https://api.github.com/users/ucb-bar/followers","following_url":"https://api.github.com/users/ucb-bar/following{/other_user}","gists_url":"https://api.github.com/users/ucb-bar/gists{/gist_id}","starred_url":"https://api.github.com/users/ucb-bar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ucb-bar/subscriptions","organizations_url":"https://api.github.com/users/ucb-bar/orgs","repos_url":"https://api.github.com/users/ucb-bar/repos","events_url":"https://api.github.com/users/ucb-bar/events{/privacy}","received_events_url":"https://api.github.com/users/ucb-bar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ucb-bar/rocket-chip","description":"Rocket Chip Generator","fork":false,"url":"https://api.github.com/repos/ucb-bar/rocket-chip","forks_url":"https://api.github.com/repos/ucb-bar/rocket-chip/forks","keys_url":"https://api.github.com/repos/ucb-bar/rocket-chip/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ucb-bar/rocket-chip/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ucb-bar/rocket-chip/teams","hooks_url":"https://api.github.com/repos/ucb-bar/rocket-chip/hooks","issue_events_url":"https://api.github.com/repos/ucb-bar/rocket-chip/issues/events{/number}","events_url":"https://api.github.com/repos/ucb-bar/rocket-chip/events","assignees_url":"https://api.github.com/repos/ucb-bar/rocket-chip/assignees{/user}","branches_url":"https://api.github.com/repos/ucb-bar/rocket-chip/branches{/branch}","tags_url":"https://api.github.com/repos/ucb-bar/rocket-chip/tags","blobs_url":"https://api.github.com/repos/ucb-bar/rocket-chip/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ucb-bar/rocket-chip/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ucb-bar/rocket-chip/git/refs{/sha}","trees_url":"https://api.github.com/repos/ucb-bar/rocket-chip/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ucb-bar/rocket-chip/statuses/{sha}","languages_url":"https://api.github.com/repos/ucb-bar/rocket-chip/languages","stargazers_url":"https://api.github.com/repos/ucb-bar/rocket-chip/stargazers","contributors_url":"https://api.github.com/repos/ucb-bar/rocket-chip/contributors","subscribers_url":"https://api.github.com/repos/ucb-bar/rocket-chip/subscribers","subscription_url":"https://api.github.com/repos/ucb-bar/rocket-chip/subscription","commits_url":"https://api.github.com/repos/ucb-bar/rocket-chip/commits{/sha}","git_commits_url":"https://api.github.com/repos/ucb-bar/rocket-chip/git/commits{/sha}","comments_url":"https://api.github.com/repos/ucb-bar/rocket-chip/comments{/number}","issue_comment_url":"https://api.github.com/repos/ucb-bar/rocket-chip/issues/comments{/number}","contents_url":"https://api.github.com/repos/ucb-bar/rocket-chip/contents/{+path}","compare_url":"https://api.github.com/repos/ucb-bar/rocket-chip/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ucb-bar/rocket-chip/merges","archive_url":"https://api.github.com/repos/ucb-bar/rocket-chip/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ucb-bar/rocket-chip/downloads","issues_url":"https://api.github.com/repos/ucb-bar/rocket-chip/issues{/number}","pulls_url":"https://api.github.com/repos/ucb-bar/rocket-chip/pulls{/number}","milestones_url":"https://api.github.com/repos/ucb-bar/rocket-chip/milestones{/number}","notifications_url":"https://api.github.com/repos/ucb-bar/rocket-chip/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ucb-bar/rocket-chip/labels{/name}","releases_url":"https://api.github.com/repos/ucb-bar/rocket-chip/releases{/id}","deployments_url":"https://api.github.com/repos/ucb-bar/rocket-chip/deployments","created_at":"2014-09-12T07:04:30Z","updated_at":"2016-09-24T00:08:47Z","pushed_at":"2016-09-27T07:02:19Z","git_url":"git://github.com/ucb-bar/rocket-chip.git","ssh_url":"git@github.com:ucb-bar/rocket-chip.git","clone_url":"https://github.com/ucb-bar/rocket-chip.git","svn_url":"https://github.com/ucb-bar/rocket-chip","homepage":null,"size":12680,"stargazers_count":166,"watchers_count":166,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":88,"mirror_url":null,"open_issues_count":14,"forks":88,"open_issues":14,"watchers":166,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ucb-bar/rocket-chip/pulls/349"},"html":{"href":"https://github.com/ucb-bar/rocket-chip/pull/349"},"issue":{"href":"https://api.github.com/repos/ucb-bar/rocket-chip/issues/349"},"comments":{"href":"https://api.github.com/repos/ucb-bar/rocket-chip/issues/349/comments"},"review_comments":{"href":"https://api.github.com/repos/ucb-bar/rocket-chip/pulls/349/comments"},"review_comment":{"href":"https://api.github.com/repos/ucb-bar/rocket-chip/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ucb-bar/rocket-chip/pulls/349/commits"},"statuses":{"href":"https://api.github.com/repos/ucb-bar/rocket-chip/statuses/65030f3b73596ef3a216922901b704c863a67086"}}}}
{"actor":{"display_login":"yunsup"}}