{"action":"created","comment":{"url":"https://api.github.com/repos/bloomberg/brisket/pulls/comments/49932982","id":49932982,"diff_hunk":"@@ -72,24 +71,33 @@ function makeClientAppStartScript(clientAppRequirePath, environmentConfig, boots\n         \"});\";\n }\n \n-function makeBootstrappingLoader(scriptBody, clientAppUrl, isAsync) {\n-    var loadAsync = isAsync ? \"s.async = true;\\n\" : \"\";","path":"lib/server/ServerRenderer.js","position":22,"original_position":22,"commit_id":"7b7733b0693c13b1cdb16cdad4c1ad28572d1c7b","original_commit_id":"7b7733b0693c13b1cdb16cdad4c1ad28572d1c7b","user":{"login":"zomaish","id":4519498,"avatar_url":"https://avatars.githubusercontent.com/u/4519498?v=3","gravatar_id":"","url":"https://api.github.com/users/zomaish","html_url":"https://github.com/zomaish","followers_url":"https://api.github.com/users/zomaish/followers","following_url":"https://api.github.com/users/zomaish/following{/other_user}","gists_url":"https://api.github.com/users/zomaish/gists{/gist_id}","starred_url":"https://api.github.com/users/zomaish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zomaish/subscriptions","organizations_url":"https://api.github.com/users/zomaish/orgs","repos_url":"https://api.github.com/users/zomaish/repos","events_url":"https://api.github.com/users/zomaish/events{/privacy}","received_events_url":"https://api.github.com/users/zomaish/received_events","type":"User","site_admin":false},"body":"this is not needed, scripts that are dynamically injected are done async by default, we would need this attribute to make the load blocking. So this line is really doing nothing but confuse the user","created_at":"2016-01-16T15:28:06Z","updated_at":"2016-01-16T15:28:06Z","html_url":"https://github.com/bloomberg/brisket/pull/238#discussion_r49932982","pull_request_url":"https://api.github.com/repos/bloomberg/brisket/pulls/238","_links":{"self":{"href":"https://api.github.com/repos/bloomberg/brisket/pulls/comments/49932982"},"html":{"href":"https://github.com/bloomberg/brisket/pull/238#discussion_r49932982"},"pull_request":{"href":"https://api.github.com/repos/bloomberg/brisket/pulls/238"}}},"pull_request":{"url":"https://api.github.com/repos/bloomberg/brisket/pulls/238","id":55780854,"html_url":"https://github.com/bloomberg/brisket/pull/238","diff_url":"https://github.com/bloomberg/brisket/pull/238.diff","patch_url":"https://github.com/bloomberg/brisket/pull/238.patch","issue_url":"https://api.github.com/repos/bloomberg/brisket/issues/238","number":238,"state":"open","locked":false,"title":"[ZE] Fix IE memory leaks with dynamic script injection","user":{"login":"zomaish","id":4519498,"avatar_url":"https://avatars.githubusercontent.com/u/4519498?v=3","gravatar_id":"","url":"https://api.github.com/users/zomaish","html_url":"https://github.com/zomaish","followers_url":"https://api.github.com/users/zomaish/followers","following_url":"https://api.github.com/users/zomaish/following{/other_user}","gists_url":"https://api.github.com/users/zomaish/gists{/gist_id}","starred_url":"https://api.github.com/users/zomaish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zomaish/subscriptions","organizations_url":"https://api.github.com/users/zomaish/orgs","repos_url":"https://api.github.com/users/zomaish/repos","events_url":"https://api.github.com/users/zomaish/events{/privacy}","received_events_url":"https://api.github.com/users/zomaish/received_events","type":"User","site_admin":false},"body":"This PR has been rebased with the latest master and version 0.43.5","created_at":"2016-01-12T16:24:50Z","updated_at":"2016-01-16T15:28:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d8460f31782c40dfb5a335fb5f9409b6030f26a9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bloomberg/brisket/pulls/238/commits","review_comments_url":"https://api.github.com/repos/bloomberg/brisket/pulls/238/comments","review_comment_url":"https://api.github.com/repos/bloomberg/brisket/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bloomberg/brisket/issues/238/comments","statuses_url":"https://api.github.com/repos/bloomberg/brisket/statuses/7b7733b0693c13b1cdb16cdad4c1ad28572d1c7b","head":{"label":"zomaish:bug/fix_ie11_mem_leak","ref":"bug/fix_ie11_mem_leak","sha":"7b7733b0693c13b1cdb16cdad4c1ad28572d1c7b","user":{"login":"zomaish","id":4519498,"avatar_url":"https://avatars.githubusercontent.com/u/4519498?v=3","gravatar_id":"","url":"https://api.github.com/users/zomaish","html_url":"https://github.com/zomaish","followers_url":"https://api.github.com/users/zomaish/followers","following_url":"https://api.github.com/users/zomaish/following{/other_user}","gists_url":"https://api.github.com/users/zomaish/gists{/gist_id}","starred_url":"https://api.github.com/users/zomaish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zomaish/subscriptions","organizations_url":"https://api.github.com/users/zomaish/orgs","repos_url":"https://api.github.com/users/zomaish/repos","events_url":"https://api.github.com/users/zomaish/events{/privacy}","received_events_url":"https://api.github.com/users/zomaish/received_events","type":"User","site_admin":false},"repo":{"id":43175301,"name":"brisket","full_name":"zomaish/brisket","owner":{"login":"zomaish","id":4519498,"avatar_url":"https://avatars.githubusercontent.com/u/4519498?v=3","gravatar_id":"","url":"https://api.github.com/users/zomaish","html_url":"https://github.com/zomaish","followers_url":"https://api.github.com/users/zomaish/followers","following_url":"https://api.github.com/users/zomaish/following{/other_user}","gists_url":"https://api.github.com/users/zomaish/gists{/gist_id}","starred_url":"https://api.github.com/users/zomaish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zomaish/subscriptions","organizations_url":"https://api.github.com/users/zomaish/orgs","repos_url":"https://api.github.com/users/zomaish/repos","events_url":"https://api.github.com/users/zomaish/events{/privacy}","received_events_url":"https://api.github.com/users/zomaish/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zomaish/brisket","description":"Bloomberg's Brisket JavaScript application framework","fork":true,"url":"https://api.github.com/repos/zomaish/brisket","forks_url":"https://api.github.com/repos/zomaish/brisket/forks","keys_url":"https://api.github.com/repos/zomaish/brisket/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zomaish/brisket/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zomaish/brisket/teams","hooks_url":"https://api.github.com/repos/zomaish/brisket/hooks","issue_events_url":"https://api.github.com/repos/zomaish/brisket/issues/events{/number}","events_url":"https://api.github.com/repos/zomaish/brisket/events","assignees_url":"https://api.github.com/repos/zomaish/brisket/assignees{/user}","branches_url":"https://api.github.com/repos/zomaish/brisket/branches{/branch}","tags_url":"https://api.github.com/repos/zomaish/brisket/tags","blobs_url":"https://api.github.com/repos/zomaish/brisket/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zomaish/brisket/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zomaish/brisket/git/refs{/sha}","trees_url":"https://api.github.com/repos/zomaish/brisket/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zomaish/brisket/statuses/{sha}","languages_url":"https://api.github.com/repos/zomaish/brisket/languages","stargazers_url":"https://api.github.com/repos/zomaish/brisket/stargazers","contributors_url":"https://api.github.com/repos/zomaish/brisket/contributors","subscribers_url":"https://api.github.com/repos/zomaish/brisket/subscribers","subscription_url":"https://api.github.com/repos/zomaish/brisket/subscription","commits_url":"https://api.github.com/repos/zomaish/brisket/commits{/sha}","git_commits_url":"https://api.github.com/repos/zomaish/brisket/git/commits{/sha}","comments_url":"https://api.github.com/repos/zomaish/brisket/comments{/number}","issue_comment_url":"https://api.github.com/repos/zomaish/brisket/issues/comments{/number}","contents_url":"https://api.github.com/repos/zomaish/brisket/contents/{+path}","compare_url":"https://api.github.com/repos/zomaish/brisket/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zomaish/brisket/merges","archive_url":"https://api.github.com/repos/zomaish/brisket/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zomaish/brisket/downloads","issues_url":"https://api.github.com/repos/zomaish/brisket/issues{/number}","pulls_url":"https://api.github.com/repos/zomaish/brisket/pulls{/number}","milestones_url":"https://api.github.com/repos/zomaish/brisket/milestones{/number}","notifications_url":"https://api.github.com/repos/zomaish/brisket/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zomaish/brisket/labels{/name}","releases_url":"https://api.github.com/repos/zomaish/brisket/releases{/id}","created_at":"2015-09-25T21:00:32Z","updated_at":"2016-01-12T17:17:59Z","pushed_at":"2016-01-14T14:07:12Z","git_url":"git://github.com/zomaish/brisket.git","ssh_url":"git@github.com:zomaish/brisket.git","clone_url":"https://github.com/zomaish/brisket.git","svn_url":"https://github.com/zomaish/brisket","homepage":"","size":644,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bloomberg:master","ref":"master","sha":"c0e35c32fa6672cfb6e8640e20ba54ea90af3fcf","user":{"login":"bloomberg","id":1416818,"avatar_url":"https://avatars.githubusercontent.com/u/1416818?v=3","gravatar_id":"","url":"https://api.github.com/users/bloomberg","html_url":"https://github.com/bloomberg","followers_url":"https://api.github.com/users/bloomberg/followers","following_url":"https://api.github.com/users/bloomberg/following{/other_user}","gists_url":"https://api.github.com/users/bloomberg/gists{/gist_id}","starred_url":"https://api.github.com/users/bloomberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bloomberg/subscriptions","organizations_url":"https://api.github.com/users/bloomberg/orgs","repos_url":"https://api.github.com/users/bloomberg/repos","events_url":"https://api.github.com/users/bloomberg/events{/privacy}","received_events_url":"https://api.github.com/users/bloomberg/received_events","type":"Organization","site_admin":false},"repo":{"id":24653948,"name":"brisket","full_name":"bloomberg/brisket","owner":{"login":"bloomberg","id":1416818,"avatar_url":"https://avatars.githubusercontent.com/u/1416818?v=3","gravatar_id":"","url":"https://api.github.com/users/bloomberg","html_url":"https://github.com/bloomberg","followers_url":"https://api.github.com/users/bloomberg/followers","following_url":"https://api.github.com/users/bloomberg/following{/other_user}","gists_url":"https://api.github.com/users/bloomberg/gists{/gist_id}","starred_url":"https://api.github.com/users/bloomberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bloomberg/subscriptions","organizations_url":"https://api.github.com/users/bloomberg/orgs","repos_url":"https://api.github.com/users/bloomberg/repos","events_url":"https://api.github.com/users/bloomberg/events{/privacy}","received_events_url":"https://api.github.com/users/bloomberg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bloomberg/brisket","description":"Bloomberg's Brisket JavaScript application framework","fork":false,"url":"https://api.github.com/repos/bloomberg/brisket","forks_url":"https://api.github.com/repos/bloomberg/brisket/forks","keys_url":"https://api.github.com/repos/bloomberg/brisket/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bloomberg/brisket/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bloomberg/brisket/teams","hooks_url":"https://api.github.com/repos/bloomberg/brisket/hooks","issue_events_url":"https://api.github.com/repos/bloomberg/brisket/issues/events{/number}","events_url":"https://api.github.com/repos/bloomberg/brisket/events","assignees_url":"https://api.github.com/repos/bloomberg/brisket/assignees{/user}","branches_url":"https://api.github.com/repos/bloomberg/brisket/branches{/branch}","tags_url":"https://api.github.com/repos/bloomberg/brisket/tags","blobs_url":"https://api.github.com/repos/bloomberg/brisket/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bloomberg/brisket/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bloomberg/brisket/git/refs{/sha}","trees_url":"https://api.github.com/repos/bloomberg/brisket/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bloomberg/brisket/statuses/{sha}","languages_url":"https://api.github.com/repos/bloomberg/brisket/languages","stargazers_url":"https://api.github.com/repos/bloomberg/brisket/stargazers","contributors_url":"https://api.github.com/repos/bloomberg/brisket/contributors","subscribers_url":"https://api.github.com/repos/bloomberg/brisket/subscribers","subscription_url":"https://api.github.com/repos/bloomberg/brisket/subscription","commits_url":"https://api.github.com/repos/bloomberg/brisket/commits{/sha}","git_commits_url":"https://api.github.com/repos/bloomberg/brisket/git/commits{/sha}","comments_url":"https://api.github.com/repos/bloomberg/brisket/comments{/number}","issue_comment_url":"https://api.github.com/repos/bloomberg/brisket/issues/comments{/number}","contents_url":"https://api.github.com/repos/bloomberg/brisket/contents/{+path}","compare_url":"https://api.github.com/repos/bloomberg/brisket/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bloomberg/brisket/merges","archive_url":"https://api.github.com/repos/bloomberg/brisket/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bloomberg/brisket/downloads","issues_url":"https://api.github.com/repos/bloomberg/brisket/issues{/number}","pulls_url":"https://api.github.com/repos/bloomberg/brisket/pulls{/number}","milestones_url":"https://api.github.com/repos/bloomberg/brisket/milestones{/number}","notifications_url":"https://api.github.com/repos/bloomberg/brisket/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bloomberg/brisket/labels{/name}","releases_url":"https://api.github.com/repos/bloomberg/brisket/releases{/id}","created_at":"2014-09-30T20:17:08Z","updated_at":"2016-01-14T10:59:59Z","pushed_at":"2016-01-15T15:52:48Z","git_url":"git://github.com/bloomberg/brisket.git","ssh_url":"git@github.com:bloomberg/brisket.git","clone_url":"https://github.com/bloomberg/brisket.git","svn_url":"https://github.com/bloomberg/brisket","homepage":"","size":730,"stargazers_count":764,"watchers_count":764,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":68,"mirror_url":null,"open_issues_count":20,"forks":68,"open_issues":20,"watchers":764,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bloomberg/brisket/pulls/238"},"html":{"href":"https://github.com/bloomberg/brisket/pull/238"},"issue":{"href":"https://api.github.com/repos/bloomberg/brisket/issues/238"},"comments":{"href":"https://api.github.com/repos/bloomberg/brisket/issues/238/comments"},"review_comments":{"href":"https://api.github.com/repos/bloomberg/brisket/pulls/238/comments"},"review_comment":{"href":"https://api.github.com/repos/bloomberg/brisket/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bloomberg/brisket/pulls/238/commits"},"statuses":{"href":"https://api.github.com/repos/bloomberg/brisket/statuses/7b7733b0693c13b1cdb16cdad4c1ad28572d1c7b"}}}}