{"action":"closed","issue":{"url":"https://api.github.com/repos/pantsbuild/pants/issues/3957","repository_url":"https://api.github.com/repos/pantsbuild/pants","labels_url":"https://api.github.com/repos/pantsbuild/pants/issues/3957/labels{/name}","comments_url":"https://api.github.com/repos/pantsbuild/pants/issues/3957/comments","events_url":"https://api.github.com/repos/pantsbuild/pants/issues/3957/events","html_url":"https://github.com/pantsbuild/pants/issues/3957","id":182660095,"number":3957,"title":"Scalafmt update","user":{"login":"mateor","id":1743873,"avatar_url":"https://avatars.githubusercontent.com/u/1743873?v=3","gravatar_id":"","url":"https://api.github.com/users/mateor","html_url":"https://github.com/mateor","followers_url":"https://api.github.com/users/mateor/followers","following_url":"https://api.github.com/users/mateor/following{/other_user}","gists_url":"https://api.github.com/users/mateor/gists{/gist_id}","starred_url":"https://api.github.com/users/mateor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mateor/subscriptions","organizations_url":"https://api.github.com/users/mateor/orgs","repos_url":"https://api.github.com/users/mateor/repos","events_url":"https://api.github.com/users/mateor/events{/privacy}","received_events_url":"https://api.github.com/users/mateor/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"stuhood","id":46740,"avatar_url":"https://avatars.githubusercontent.com/u/46740?v=3","gravatar_id":"","url":"https://api.github.com/users/stuhood","html_url":"https://github.com/stuhood","followers_url":"https://api.github.com/users/stuhood/followers","following_url":"https://api.github.com/users/stuhood/following{/other_user}","gists_url":"https://api.github.com/users/stuhood/gists{/gist_id}","starred_url":"https://api.github.com/users/stuhood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stuhood/subscriptions","organizations_url":"https://api.github.com/users/stuhood/orgs","repos_url":"https://api.github.com/users/stuhood/repos","events_url":"https://api.github.com/users/stuhood/events{/privacy}","received_events_url":"https://api.github.com/users/stuhood/received_events","type":"User","site_admin":false},"assignees":[{"login":"stuhood","id":46740,"avatar_url":"https://avatars.githubusercontent.com/u/46740?v=3","gravatar_id":"","url":"https://api.github.com/users/stuhood","html_url":"https://github.com/stuhood","followers_url":"https://api.github.com/users/stuhood/followers","following_url":"https://api.github.com/users/stuhood/following{/other_user}","gists_url":"https://api.github.com/users/stuhood/gists{/gist_id}","starred_url":"https://api.github.com/users/stuhood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stuhood/subscriptions","organizations_url":"https://api.github.com/users/stuhood/orgs","repos_url":"https://api.github.com/users/stuhood/repos","events_url":"https://api.github.com/users/stuhood/events{/privacy}","received_events_url":"https://api.github.com/users/stuhood/received_events","type":"User","site_admin":false}],"milestone":null,"comments":4,"created_at":"2016-10-12T23:35:18Z","updated_at":"2016-10-19T23:33:14Z","closed_at":"2016-10-19T23:33:14Z","body":"There were some issues raised during review that were marked Done but appear to be still live. @stuhood intends to take another pass so this is to track them.\r\n\r\n- It is skip=False by default\r\n       * Scala consumers first interaction with Pants will likely be an error that asks to reformat their source code.\r\n-  Operates over every Target in self.context.targets().\r\n       * Should limit itself to scala_library and tests.\r\n- Uses goal based scheduling instead of using Products.\r\n       * The SimpleCodegen products model is probably a more flexible choice.\r\n       * What if someone wants another compile task to go first?\r\n        * I don't think scalafmt warrants hardcoded priority, it doesn't actually need anything besides to run before `compile.zinc`\r\n- There is a default config file set in the task, but I do not believe that config file is being made available in the sdist.\r\n- Upon failure, it prints the full (adjusted?) text of one file to terminal\r\n- It suggests running\r\n\r\n        `FAILURE: Scalafmt failed with exit code 899 to fix run: `scalafmt -i --files ${files}`\r\n\r\nwhere the `${files[@]}` are every scala file it ran over, whether it passed or not.\r\n\r\n* There is no config file included in the suggested output, so the \"fix\" run may use a different config than the check config.\r\n\r\n- It bootstraps its own scalafmt tool, but suggests using the system scalafmt.\r\n       * It could at least point at the bootstrapped tool (and include the path to the config file).\r\n       * Our engineers do not currently have a system `scalafmt`, for example\r\n- A nice-to-have would be to surface the scalafmt tool as an option, like the test.junit does for the runner."}}
{"actor":{"display_login":"stuhood"}}