{"action":"created","comment":{"url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/comments/78382288","id":78382288,"diff_hunk":"@@ -19,11 +19,12 @@\n #include <unordered_map>\n #include <vector>\n \n+#include \"util/parse_number.h\"\n+\n #include \"def_use_manager.h\"\n #include \"spirv-tools/libspirv.h\"","path":"source/opt/set_spec_constant_default_value_pass.cpp","position":null,"original_position":7,"commit_id":"de4c4a8969bda21568bc9089772c39bd5e834110","original_commit_id":"0d108d8d47dd56bc6373d77acea5aaf2f2731df4","user":{"login":"dneto0","id":13054574,"avatar_url":"https://avatars.githubusercontent.com/u/13054574?v=3","gravatar_id":"","url":"https://api.github.com/users/dneto0","html_url":"https://github.com/dneto0","followers_url":"https://api.github.com/users/dneto0/followers","following_url":"https://api.github.com/users/dneto0/following{/other_user}","gists_url":"https://api.github.com/users/dneto0/gists{/gist_id}","starred_url":"https://api.github.com/users/dneto0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dneto0/subscriptions","organizations_url":"https://api.github.com/users/dneto0/orgs","repos_url":"https://api.github.com/users/dneto0/repos","events_url":"https://api.github.com/users/dneto0/events{/privacy}","received_events_url":"https://api.github.com/users/dneto0/received_events","type":"User","site_admin":false},"body":"spirv-tools/libspirv.h is also from libSPIRV-Tools.a, a different library.","created_at":"2016-09-12T14:25:42Z","updated_at":"2016-09-12T14:25:42Z","html_url":"https://github.com/KhronosGroup/SPIRV-Tools/pull/390#discussion_r78382288","pull_request_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/390","_links":{"self":{"href":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/comments/78382288"},"html":{"href":"https://github.com/KhronosGroup/SPIRV-Tools/pull/390#discussion_r78382288"},"pull_request":{"href":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/390"}}},"pull_request":{"url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/390","id":83517221,"html_url":"https://github.com/KhronosGroup/SPIRV-Tools/pull/390","diff_url":"https://github.com/KhronosGroup/SPIRV-Tools/pull/390.diff","patch_url":"https://github.com/KhronosGroup/SPIRV-Tools/pull/390.patch","issue_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/issues/390","number":390,"state":"open","locked":false,"title":"Set default values for spec constants with SpecId","user":{"login":"Qining","id":2983685,"avatar_url":"https://avatars.githubusercontent.com/u/2983685?v=3","gravatar_id":"","url":"https://api.github.com/users/Qining","html_url":"https://github.com/Qining","followers_url":"https://api.github.com/users/Qining/followers","following_url":"https://api.github.com/users/Qining/following{/other_user}","gists_url":"https://api.github.com/users/Qining/gists{/gist_id}","starred_url":"https://api.github.com/users/Qining/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Qining/subscriptions","organizations_url":"https://api.github.com/users/Qining/orgs","repos_url":"https://api.github.com/users/Qining/repos","events_url":"https://api.github.com/users/Qining/events{/privacy}","received_events_url":"https://api.github.com/users/Qining/received_events","type":"User","site_admin":false},"body":"The pass instance is constructed with a map from spec id (uint32_t) to\r\ndefault values in string format. The default value strings will be\r\nparsed to numbers according to the target spec constant type.","created_at":"2016-08-31T19:50:13Z","updated_at":"2016-09-12T14:25:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"77fe7a1dcd20f1e666af0284ba5e52a71d366be1","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/milestones/1","html_url":"https://github.com/KhronosGroup/SPIRV-Tools/milestones/SPIR-V%20optimization","labels_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/milestones/1/labels","id":1908267,"number":1,"title":"SPIR-V optimization","description":"","creator":{"login":"antiagainst","id":487928,"avatar_url":"https://avatars.githubusercontent.com/u/487928?v=3","gravatar_id":"","url":"https://api.github.com/users/antiagainst","html_url":"https://github.com/antiagainst","followers_url":"https://api.github.com/users/antiagainst/followers","following_url":"https://api.github.com/users/antiagainst/following{/other_user}","gists_url":"https://api.github.com/users/antiagainst/gists{/gist_id}","starred_url":"https://api.github.com/users/antiagainst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antiagainst/subscriptions","organizations_url":"https://api.github.com/users/antiagainst/orgs","repos_url":"https://api.github.com/users/antiagainst/repos","events_url":"https://api.github.com/users/antiagainst/events{/privacy}","received_events_url":"https://api.github.com/users/antiagainst/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":18,"state":"open","created_at":"2016-07-27T22:04:04Z","updated_at":"2016-09-08T22:33:08Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/390/commits","review_comments_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/390/comments","review_comment_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/issues/390/comments","statuses_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/statuses/de4c4a8969bda21568bc9089772c39bd5e834110","head":{"label":"Qining:set-spec-const-default-value","ref":"set-spec-const-default-value","sha":"de4c4a8969bda21568bc9089772c39bd5e834110","user":{"login":"Qining","id":2983685,"avatar_url":"https://avatars.githubusercontent.com/u/2983685?v=3","gravatar_id":"","url":"https://api.github.com/users/Qining","html_url":"https://github.com/Qining","followers_url":"https://api.github.com/users/Qining/followers","following_url":"https://api.github.com/users/Qining/following{/other_user}","gists_url":"https://api.github.com/users/Qining/gists{/gist_id}","starred_url":"https://api.github.com/users/Qining/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Qining/subscriptions","organizations_url":"https://api.github.com/users/Qining/orgs","repos_url":"https://api.github.com/users/Qining/repos","events_url":"https://api.github.com/users/Qining/events{/privacy}","received_events_url":"https://api.github.com/users/Qining/received_events","type":"User","site_admin":false},"repo":{"id":50677710,"name":"SPIRV-Tools","full_name":"Qining/SPIRV-Tools","owner":{"login":"Qining","id":2983685,"avatar_url":"https://avatars.githubusercontent.com/u/2983685?v=3","gravatar_id":"","url":"https://api.github.com/users/Qining","html_url":"https://github.com/Qining","followers_url":"https://api.github.com/users/Qining/followers","following_url":"https://api.github.com/users/Qining/following{/other_user}","gists_url":"https://api.github.com/users/Qining/gists{/gist_id}","starred_url":"https://api.github.com/users/Qining/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Qining/subscriptions","organizations_url":"https://api.github.com/users/Qining/orgs","repos_url":"https://api.github.com/users/Qining/repos","events_url":"https://api.github.com/users/Qining/events{/privacy}","received_events_url":"https://api.github.com/users/Qining/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Qining/SPIRV-Tools","description":"","fork":true,"url":"https://api.github.com/repos/Qining/SPIRV-Tools","forks_url":"https://api.github.com/repos/Qining/SPIRV-Tools/forks","keys_url":"https://api.github.com/repos/Qining/SPIRV-Tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Qining/SPIRV-Tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Qining/SPIRV-Tools/teams","hooks_url":"https://api.github.com/repos/Qining/SPIRV-Tools/hooks","issue_events_url":"https://api.github.com/repos/Qining/SPIRV-Tools/issues/events{/number}","events_url":"https://api.github.com/repos/Qining/SPIRV-Tools/events","assignees_url":"https://api.github.com/repos/Qining/SPIRV-Tools/assignees{/user}","branches_url":"https://api.github.com/repos/Qining/SPIRV-Tools/branches{/branch}","tags_url":"https://api.github.com/repos/Qining/SPIRV-Tools/tags","blobs_url":"https://api.github.com/repos/Qining/SPIRV-Tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Qining/SPIRV-Tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Qining/SPIRV-Tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/Qining/SPIRV-Tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Qining/SPIRV-Tools/statuses/{sha}","languages_url":"https://api.github.com/repos/Qining/SPIRV-Tools/languages","stargazers_url":"https://api.github.com/repos/Qining/SPIRV-Tools/stargazers","contributors_url":"https://api.github.com/repos/Qining/SPIRV-Tools/contributors","subscribers_url":"https://api.github.com/repos/Qining/SPIRV-Tools/subscribers","subscription_url":"https://api.github.com/repos/Qining/SPIRV-Tools/subscription","commits_url":"https://api.github.com/repos/Qining/SPIRV-Tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/Qining/SPIRV-Tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/Qining/SPIRV-Tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/Qining/SPIRV-Tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/Qining/SPIRV-Tools/contents/{+path}","compare_url":"https://api.github.com/repos/Qining/SPIRV-Tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Qining/SPIRV-Tools/merges","archive_url":"https://api.github.com/repos/Qining/SPIRV-Tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Qining/SPIRV-Tools/downloads","issues_url":"https://api.github.com/repos/Qining/SPIRV-Tools/issues{/number}","pulls_url":"https://api.github.com/repos/Qining/SPIRV-Tools/pulls{/number}","milestones_url":"https://api.github.com/repos/Qining/SPIRV-Tools/milestones{/number}","notifications_url":"https://api.github.com/repos/Qining/SPIRV-Tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Qining/SPIRV-Tools/labels{/name}","releases_url":"https://api.github.com/repos/Qining/SPIRV-Tools/releases{/id}","deployments_url":"https://api.github.com/repos/Qining/SPIRV-Tools/deployments","created_at":"2016-01-29T17:10:36Z","updated_at":"2016-01-29T17:10:37Z","pushed_at":"2016-09-12T14:11:40Z","git_url":"git://github.com/Qining/SPIRV-Tools.git","ssh_url":"git@github.com:Qining/SPIRV-Tools.git","clone_url":"https://github.com/Qining/SPIRV-Tools.git","svn_url":"https://github.com/Qining/SPIRV-Tools","homepage":null,"size":2418,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"KhronosGroup:master","ref":"master","sha":"049f80f3b9289e322cb1d0cfe63c6aa6bd40338f","user":{"login":"KhronosGroup","id":1608701,"avatar_url":"https://avatars.githubusercontent.com/u/1608701?v=3","gravatar_id":"","url":"https://api.github.com/users/KhronosGroup","html_url":"https://github.com/KhronosGroup","followers_url":"https://api.github.com/users/KhronosGroup/followers","following_url":"https://api.github.com/users/KhronosGroup/following{/other_user}","gists_url":"https://api.github.com/users/KhronosGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/KhronosGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KhronosGroup/subscriptions","organizations_url":"https://api.github.com/users/KhronosGroup/orgs","repos_url":"https://api.github.com/users/KhronosGroup/repos","events_url":"https://api.github.com/users/KhronosGroup/events{/privacy}","received_events_url":"https://api.github.com/users/KhronosGroup/received_events","type":"Organization","site_admin":false},"repo":{"id":45981801,"name":"SPIRV-Tools","full_name":"KhronosGroup/SPIRV-Tools","owner":{"login":"KhronosGroup","id":1608701,"avatar_url":"https://avatars.githubusercontent.com/u/1608701?v=3","gravatar_id":"","url":"https://api.github.com/users/KhronosGroup","html_url":"https://github.com/KhronosGroup","followers_url":"https://api.github.com/users/KhronosGroup/followers","following_url":"https://api.github.com/users/KhronosGroup/following{/other_user}","gists_url":"https://api.github.com/users/KhronosGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/KhronosGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KhronosGroup/subscriptions","organizations_url":"https://api.github.com/users/KhronosGroup/orgs","repos_url":"https://api.github.com/users/KhronosGroup/repos","events_url":"https://api.github.com/users/KhronosGroup/events{/privacy}","received_events_url":"https://api.github.com/users/KhronosGroup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/KhronosGroup/SPIRV-Tools","description":"","fork":false,"url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools","forks_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/forks","keys_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/teams","hooks_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/hooks","issue_events_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/issues/events{/number}","events_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/events","assignees_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/assignees{/user}","branches_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/branches{/branch}","tags_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/tags","blobs_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/statuses/{sha}","languages_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/languages","stargazers_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/stargazers","contributors_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/contributors","subscribers_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/subscribers","subscription_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/subscription","commits_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/contents/{+path}","compare_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/merges","archive_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/downloads","issues_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/issues{/number}","pulls_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls{/number}","milestones_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/milestones{/number}","notifications_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/labels{/name}","releases_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/releases{/id}","deployments_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/deployments","created_at":"2015-11-11T12:56:25Z","updated_at":"2016-09-01T23:18:51Z","pushed_at":"2016-09-12T14:11:41Z","git_url":"git://github.com/KhronosGroup/SPIRV-Tools.git","ssh_url":"git@github.com:KhronosGroup/SPIRV-Tools.git","clone_url":"https://github.com/KhronosGroup/SPIRV-Tools.git","svn_url":"https://github.com/KhronosGroup/SPIRV-Tools","homepage":null,"size":3012,"stargazers_count":136,"watchers_count":136,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":35,"mirror_url":null,"open_issues_count":25,"forks":35,"open_issues":25,"watchers":136,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/390"},"html":{"href":"https://github.com/KhronosGroup/SPIRV-Tools/pull/390"},"issue":{"href":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/issues/390"},"comments":{"href":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/issues/390/comments"},"review_comments":{"href":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/390/comments"},"review_comment":{"href":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/390/commits"},"statuses":{"href":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/statuses/de4c4a8969bda21568bc9089772c39bd5e834110"}}}}
{"actor":{"display_login":"dneto0"}}