{"action":"created","issue":{"url":"https://api.github.com/repos/coreos/fleet/issues/1589","repository_url":"https://api.github.com/repos/coreos/fleet","labels_url":"https://api.github.com/repos/coreos/fleet/issues/1589/labels{/name}","comments_url":"https://api.github.com/repos/coreos/fleet/issues/1589/comments","events_url":"https://api.github.com/repos/coreos/fleet/issues/1589/events","html_url":"https://github.com/coreos/fleet/pull/1589","id":156529577,"number":1589,"title":"functional: call systemctl is-enabled instead of list-unit-files","user":{"login":"dongsupark","id":10096906,"avatar_url":"https://avatars.githubusercontent.com/u/10096906?v=3","gravatar_id":"","url":"https://api.github.com/users/dongsupark","html_url":"https://github.com/dongsupark","followers_url":"https://api.github.com/users/dongsupark/followers","following_url":"https://api.github.com/users/dongsupark/following{/other_user}","gists_url":"https://api.github.com/users/dongsupark/gists{/gist_id}","starred_url":"https://api.github.com/users/dongsupark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dongsupark/subscriptions","organizations_url":"https://api.github.com/users/dongsupark/orgs","repos_url":"https://api.github.com/users/dongsupark/repos","events_url":"https://api.github.com/users/dongsupark/events{/privacy}","received_events_url":"https://api.github.com/users/dongsupark/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/coreos/fleet/labels/area/testing","name":"area/testing","color":"bfe5bf"},{"url":"https://api.github.com/repos/coreos/fleet/labels/dependency/external","name":"dependency/external","color":"fbfa04"},{"url":"https://api.github.com/repos/coreos/fleet/labels/kind/friction","name":"kind/friction","color":"c7def8"},{"url":"https://api.github.com/repos/coreos/fleet/labels/technology/systemd","name":"technology/systemd","color":"d4c5f9"}],"state":"open","locked":false,"assignee":{"login":"dongsupark","id":10096906,"avatar_url":"https://avatars.githubusercontent.com/u/10096906?v=3","gravatar_id":"","url":"https://api.github.com/users/dongsupark","html_url":"https://github.com/dongsupark","followers_url":"https://api.github.com/users/dongsupark/followers","following_url":"https://api.github.com/users/dongsupark/following{/other_user}","gists_url":"https://api.github.com/users/dongsupark/gists{/gist_id}","starred_url":"https://api.github.com/users/dongsupark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dongsupark/subscriptions","organizations_url":"https://api.github.com/users/dongsupark/orgs","repos_url":"https://api.github.com/users/dongsupark/repos","events_url":"https://api.github.com/users/dongsupark/events{/privacy}","received_events_url":"https://api.github.com/users/dongsupark/received_events","type":"User","site_admin":false},"milestone":null,"comments":1,"created_at":"2016-05-24T14:55:44Z","updated_at":"2016-05-25T09:43:00Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/coreos/fleet/pulls/1589","html_url":"https://github.com/coreos/fleet/pull/1589","diff_url":"https://github.com/coreos/fleet/pull/1589.diff","patch_url":"https://github.com/coreos/fleet/pull/1589.patch"},"body":"``TestSingleNodeConnectivityLoss`` has been so far retrieving is-enabled status by calling ``\"systemctl list-unit-files UNITS\"``. It was expected to get ``\"enabled\"`` for each unit. This has worked until systemd v227. However, that's not the case any more since systemd v228, precisely since https://github.com/systemd/systemd/commit/0ec0deaa30d0e68430f03fa6f32affa576481d18 (\"install: follow unit file symlinks in /usr, but not /etc when looking for [Install] data\"). Since then, systemctl list-unit-files returns ``\"linked-runtime\"`` status for each fleet unit, which is actually reasonable behavior for units that are not installed persistently under ``/etc/systemd``.\r\n\r\nWith systemd v228 or newer, however, ``TestSingleNodeConnectivityLoss`` in fleet functional tests cannot make use of ``\"systemctl list-unit-files\"`` any more. And it would not be optimal to simply change ``\"enabled\"`` to ``\"linked-runtime\"``, because then the test couldn't work with systemd < v228.\r\n\r\nSo let's work around it, by calling ``\"systemctl is-enabled UNIT\"`` instead. That command has returned correct status ``\"linked-runtime\"``, no matter whether systemd >= 228 or not.\r\n\r\nFixes: https://github.com/coreos/fleet/issues/1588"},"comment":{"url":"https://api.github.com/repos/coreos/fleet/issues/comments/221524274","html_url":"https://github.com/coreos/fleet/pull/1589#issuecomment-221524274","issue_url":"https://api.github.com/repos/coreos/fleet/issues/1589","id":221524274,"user":{"login":"dongsupark","id":10096906,"avatar_url":"https://avatars.githubusercontent.com/u/10096906?v=3","gravatar_id":"","url":"https://api.github.com/users/dongsupark","html_url":"https://github.com/dongsupark","followers_url":"https://api.github.com/users/dongsupark/followers","following_url":"https://api.github.com/users/dongsupark/following{/other_user}","gists_url":"https://api.github.com/users/dongsupark/gists{/gist_id}","starred_url":"https://api.github.com/users/dongsupark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dongsupark/subscriptions","organizations_url":"https://api.github.com/users/dongsupark/orgs","repos_url":"https://api.github.com/users/dongsupark/repos","events_url":"https://api.github.com/users/dongsupark/events{/privacy}","received_events_url":"https://api.github.com/users/dongsupark/received_events","type":"User","site_admin":false},"created_at":"2016-05-25T09:43:00Z","updated_at":"2016-05-25T09:43:00Z","body":"I just updated minor things: ``s/break/continue``, and fixing a comment."}}
{"actor":{"display_login":"dongsupark"}}