{"action":"created","comment":{"url":"https://api.github.com/repos/errordeveloper/kubernetes/pulls/comments/79006094","id":79006094,"diff_hunk":"@@ -129,6 +129,10 @@ func NewCmdManualBootstrapInitMaster(out io.Writer, s *kubeadmapi.KubeadmConfig)\n \t\t&s.InitFlags.Services.DNSDomain, \"service-dns-domain\", \"cluster.local\",\n \t\t`(optional) use alterantive domain name for services, e.g. \"myorg.internal\"`,\n \t)\n+\tcmd.PersistentFlags().BoolVar(\n+\t\t&s.InitFlags.Schedulable, \"schedule-workload\", false,\n+\t\t`(optional) allow to schedule workload to the node`,","path":"pkg/kubeadm/cmd/manual.go","position":6,"original_position":6,"commit_id":"66a1ed62af27decc30a05917156407c59c2b4122","original_commit_id":"66a1ed62af27decc30a05917156407c59c2b4122","user":{"login":"rustyrobot","id":577643,"avatar_url":"https://avatars.githubusercontent.com/u/577643?v=3","gravatar_id":"","url":"https://api.github.com/users/rustyrobot","html_url":"https://github.com/rustyrobot","followers_url":"https://api.github.com/users/rustyrobot/followers","following_url":"https://api.github.com/users/rustyrobot/following{/other_user}","gists_url":"https://api.github.com/users/rustyrobot/gists{/gist_id}","starred_url":"https://api.github.com/users/rustyrobot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rustyrobot/subscriptions","organizations_url":"https://api.github.com/users/rustyrobot/orgs","repos_url":"https://api.github.com/users/rustyrobot/repos","events_url":"https://api.github.com/users/rustyrobot/events{/privacy}","received_events_url":"https://api.github.com/users/rustyrobot/received_events","type":"User","site_admin":false},"body":"E.g. the first things which comes to mind, is to extract common args into a separate method and reuse it in both `init` and `manual`.","created_at":"2016-09-15T16:28:57Z","updated_at":"2016-09-15T16:28:57Z","html_url":"https://github.com/errordeveloper/kubernetes/pull/9#discussion_r79006094","pull_request_url":"https://api.github.com/repos/errordeveloper/kubernetes/pulls/9","_links":{"self":{"href":"https://api.github.com/repos/errordeveloper/kubernetes/pulls/comments/79006094"},"html":{"href":"https://github.com/errordeveloper/kubernetes/pull/9#discussion_r79006094"},"pull_request":{"href":"https://api.github.com/repos/errordeveloper/kubernetes/pulls/9"}}},"pull_request":{"url":"https://api.github.com/repos/errordeveloper/kubernetes/pulls/9","id":85436112,"html_url":"https://github.com/errordeveloper/kubernetes/pull/9","diff_url":"https://github.com/errordeveloper/kubernetes/pull/9.diff","patch_url":"https://github.com/errordeveloper/kubernetes/pull/9.patch","issue_url":"https://api.github.com/repos/errordeveloper/kubernetes/issues/9","number":9,"state":"open","locked":false,"title":"Add a flag to allow to schedule workload to the master node","user":{"login":"rustyrobot","id":577643,"avatar_url":"https://avatars.githubusercontent.com/u/577643?v=3","gravatar_id":"","url":"https://api.github.com/users/rustyrobot","html_url":"https://github.com/rustyrobot","followers_url":"https://api.github.com/users/rustyrobot/followers","following_url":"https://api.github.com/users/rustyrobot/following{/other_user}","gists_url":"https://api.github.com/users/rustyrobot/gists{/gist_id}","starred_url":"https://api.github.com/users/rustyrobot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rustyrobot/subscriptions","organizations_url":"https://api.github.com/users/rustyrobot/orgs","repos_url":"https://api.github.com/users/rustyrobot/repos","events_url":"https://api.github.com/users/rustyrobot/events{/privacy}","received_events_url":"https://api.github.com/users/rustyrobot/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-09-15T16:23:47Z","updated_at":"2016-09-15T16:28:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b4bc9508d775342efd7f4b65d589debcff08a559","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/errordeveloper/kubernetes/pulls/9/commits","review_comments_url":"https://api.github.com/repos/errordeveloper/kubernetes/pulls/9/comments","review_comment_url":"https://api.github.com/repos/errordeveloper/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/errordeveloper/kubernetes/issues/9/comments","statuses_url":"https://api.github.com/repos/errordeveloper/kubernetes/statuses/66a1ed62af27decc30a05917156407c59c2b4122","head":{"label":"rustyrobot:kubeadm-workload-flag","ref":"kubeadm-workload-flag","sha":"66a1ed62af27decc30a05917156407c59c2b4122","user":{"login":"rustyrobot","id":577643,"avatar_url":"https://avatars.githubusercontent.com/u/577643?v=3","gravatar_id":"","url":"https://api.github.com/users/rustyrobot","html_url":"https://github.com/rustyrobot","followers_url":"https://api.github.com/users/rustyrobot/followers","following_url":"https://api.github.com/users/rustyrobot/following{/other_user}","gists_url":"https://api.github.com/users/rustyrobot/gists{/gist_id}","starred_url":"https://api.github.com/users/rustyrobot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rustyrobot/subscriptions","organizations_url":"https://api.github.com/users/rustyrobot/orgs","repos_url":"https://api.github.com/users/rustyrobot/repos","events_url":"https://api.github.com/users/rustyrobot/events{/privacy}","received_events_url":"https://api.github.com/users/rustyrobot/received_events","type":"User","site_admin":false},"repo":{"id":67112886,"name":"kubernetes","full_name":"rustyrobot/kubernetes","owner":{"login":"rustyrobot","id":577643,"avatar_url":"https://avatars.githubusercontent.com/u/577643?v=3","gravatar_id":"","url":"https://api.github.com/users/rustyrobot","html_url":"https://github.com/rustyrobot","followers_url":"https://api.github.com/users/rustyrobot/followers","following_url":"https://api.github.com/users/rustyrobot/following{/other_user}","gists_url":"https://api.github.com/users/rustyrobot/gists{/gist_id}","starred_url":"https://api.github.com/users/rustyrobot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rustyrobot/subscriptions","organizations_url":"https://api.github.com/users/rustyrobot/orgs","repos_url":"https://api.github.com/users/rustyrobot/repos","events_url":"https://api.github.com/users/rustyrobot/events{/privacy}","received_events_url":"https://api.github.com/users/rustyrobot/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rustyrobot/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/rustyrobot/kubernetes","forks_url":"https://api.github.com/repos/rustyrobot/kubernetes/forks","keys_url":"https://api.github.com/repos/rustyrobot/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rustyrobot/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rustyrobot/kubernetes/teams","hooks_url":"https://api.github.com/repos/rustyrobot/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/rustyrobot/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/rustyrobot/kubernetes/events","assignees_url":"https://api.github.com/repos/rustyrobot/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/rustyrobot/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/rustyrobot/kubernetes/tags","blobs_url":"https://api.github.com/repos/rustyrobot/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rustyrobot/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rustyrobot/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/rustyrobot/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rustyrobot/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/rustyrobot/kubernetes/languages","stargazers_url":"https://api.github.com/repos/rustyrobot/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/rustyrobot/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/rustyrobot/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/rustyrobot/kubernetes/subscription","commits_url":"https://api.github.com/repos/rustyrobot/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/rustyrobot/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/rustyrobot/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/rustyrobot/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/rustyrobot/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/rustyrobot/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rustyrobot/kubernetes/merges","archive_url":"https://api.github.com/repos/rustyrobot/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rustyrobot/kubernetes/downloads","issues_url":"https://api.github.com/repos/rustyrobot/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/rustyrobot/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/rustyrobot/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/rustyrobot/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rustyrobot/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/rustyrobot/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/rustyrobot/kubernetes/deployments","created_at":"2016-09-01T08:27:51Z","updated_at":"2016-09-01T08:28:21Z","pushed_at":"2016-09-15T16:23:17Z","git_url":"git://github.com/rustyrobot/kubernetes.git","ssh_url":"git@github.com:rustyrobot/kubernetes.git","clone_url":"https://github.com/rustyrobot/kubernetes.git","svn_url":"https://github.com/rustyrobot/kubernetes","homepage":"http://kubernetes.io","size":318303,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"errordeveloper:kubeadm","ref":"kubeadm","sha":"e7c8aa5991d2f78c1847bd0c154cf1b960119011","user":{"login":"errordeveloper","id":251467,"avatar_url":"https://avatars.githubusercontent.com/u/251467?v=3","gravatar_id":"","url":"https://api.github.com/users/errordeveloper","html_url":"https://github.com/errordeveloper","followers_url":"https://api.github.com/users/errordeveloper/followers","following_url":"https://api.github.com/users/errordeveloper/following{/other_user}","gists_url":"https://api.github.com/users/errordeveloper/gists{/gist_id}","starred_url":"https://api.github.com/users/errordeveloper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/errordeveloper/subscriptions","organizations_url":"https://api.github.com/users/errordeveloper/orgs","repos_url":"https://api.github.com/users/errordeveloper/repos","events_url":"https://api.github.com/users/errordeveloper/events{/privacy}","received_events_url":"https://api.github.com/users/errordeveloper/received_events","type":"User","site_admin":false},"repo":{"id":25202727,"name":"kubernetes","full_name":"errordeveloper/kubernetes","owner":{"login":"errordeveloper","id":251467,"avatar_url":"https://avatars.githubusercontent.com/u/251467?v=3","gravatar_id":"","url":"https://api.github.com/users/errordeveloper","html_url":"https://github.com/errordeveloper","followers_url":"https://api.github.com/users/errordeveloper/followers","following_url":"https://api.github.com/users/errordeveloper/following{/other_user}","gists_url":"https://api.github.com/users/errordeveloper/gists{/gist_id}","starred_url":"https://api.github.com/users/errordeveloper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/errordeveloper/subscriptions","organizations_url":"https://api.github.com/users/errordeveloper/orgs","repos_url":"https://api.github.com/users/errordeveloper/repos","events_url":"https://api.github.com/users/errordeveloper/events{/privacy}","received_events_url":"https://api.github.com/users/errordeveloper/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/errordeveloper/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/errordeveloper/kubernetes","forks_url":"https://api.github.com/repos/errordeveloper/kubernetes/forks","keys_url":"https://api.github.com/repos/errordeveloper/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/errordeveloper/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/errordeveloper/kubernetes/teams","hooks_url":"https://api.github.com/repos/errordeveloper/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/errordeveloper/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/errordeveloper/kubernetes/events","assignees_url":"https://api.github.com/repos/errordeveloper/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/errordeveloper/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/errordeveloper/kubernetes/tags","blobs_url":"https://api.github.com/repos/errordeveloper/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/errordeveloper/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/errordeveloper/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/errordeveloper/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/errordeveloper/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/errordeveloper/kubernetes/languages","stargazers_url":"https://api.github.com/repos/errordeveloper/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/errordeveloper/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/errordeveloper/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/errordeveloper/kubernetes/subscription","commits_url":"https://api.github.com/repos/errordeveloper/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/errordeveloper/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/errordeveloper/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/errordeveloper/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/errordeveloper/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/errordeveloper/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/errordeveloper/kubernetes/merges","archive_url":"https://api.github.com/repos/errordeveloper/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/errordeveloper/kubernetes/downloads","issues_url":"https://api.github.com/repos/errordeveloper/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/errordeveloper/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/errordeveloper/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/errordeveloper/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/errordeveloper/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/errordeveloper/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/errordeveloper/kubernetes/deployments","created_at":"2014-10-14T11:13:25Z","updated_at":"2016-03-23T12:29:37Z","pushed_at":"2016-09-15T16:23:47Z","git_url":"git://github.com/errordeveloper/kubernetes.git","ssh_url":"git@github.com:errordeveloper/kubernetes.git","clone_url":"https://github.com/errordeveloper/kubernetes.git","svn_url":"https://github.com/errordeveloper/kubernetes","homepage":null,"size":315541,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/errordeveloper/kubernetes/pulls/9"},"html":{"href":"https://github.com/errordeveloper/kubernetes/pull/9"},"issue":{"href":"https://api.github.com/repos/errordeveloper/kubernetes/issues/9"},"comments":{"href":"https://api.github.com/repos/errordeveloper/kubernetes/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/errordeveloper/kubernetes/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/errordeveloper/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/errordeveloper/kubernetes/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/errordeveloper/kubernetes/statuses/66a1ed62af27decc30a05917156407c59c2b4122"}}}}
{"actor":{"display_login":"rustyrobot"}}