{"action":"created","issue":{"url":"https://api.github.com/repos/alphagov/paas-cf/issues/500","repository_url":"https://api.github.com/repos/alphagov/paas-cf","labels_url":"https://api.github.com/repos/alphagov/paas-cf/issues/500/labels{/name}","comments_url":"https://api.github.com/repos/alphagov/paas-cf/issues/500/comments","events_url":"https://api.github.com/repos/alphagov/paas-cf/issues/500/events","html_url":"https://github.com/alphagov/paas-cf/pull/500","id":178105372,"number":500,"title":"[#130379909] Refactor Datadog credential storage","user":{"login":"Jonty","id":1553,"avatar_url":"https://avatars.githubusercontent.com/u/1553?v=3","gravatar_id":"","url":"https://api.github.com/users/Jonty","html_url":"https://github.com/Jonty","followers_url":"https://api.github.com/users/Jonty/followers","following_url":"https://api.github.com/users/Jonty/following{/other_user}","gists_url":"https://api.github.com/users/Jonty/gists{/gist_id}","starred_url":"https://api.github.com/users/Jonty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jonty/subscriptions","organizations_url":"https://api.github.com/users/Jonty/orgs","repos_url":"https://api.github.com/users/Jonty/repos","events_url":"https://api.github.com/users/Jonty/events{/privacy}","received_events_url":"https://api.github.com/users/Jonty/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"keymon","id":280032,"avatar_url":"https://avatars.githubusercontent.com/u/280032?v=3","gravatar_id":"","url":"https://api.github.com/users/keymon","html_url":"https://github.com/keymon","followers_url":"https://api.github.com/users/keymon/followers","following_url":"https://api.github.com/users/keymon/following{/other_user}","gists_url":"https://api.github.com/users/keymon/gists{/gist_id}","starred_url":"https://api.github.com/users/keymon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keymon/subscriptions","organizations_url":"https://api.github.com/users/keymon/orgs","repos_url":"https://api.github.com/users/keymon/repos","events_url":"https://api.github.com/users/keymon/events{/privacy}","received_events_url":"https://api.github.com/users/keymon/received_events","type":"User","site_admin":false},"assignees":[{"login":"keymon","id":280032,"avatar_url":"https://avatars.githubusercontent.com/u/280032?v=3","gravatar_id":"","url":"https://api.github.com/users/keymon","html_url":"https://github.com/keymon","followers_url":"https://api.github.com/users/keymon/followers","following_url":"https://api.github.com/users/keymon/following{/other_user}","gists_url":"https://api.github.com/users/keymon/gists{/gist_id}","starred_url":"https://api.github.com/users/keymon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keymon/subscriptions","organizations_url":"https://api.github.com/users/keymon/orgs","repos_url":"https://api.github.com/users/keymon/repos","events_url":"https://api.github.com/users/keymon/events{/privacy}","received_events_url":"https://api.github.com/users/keymon/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2016-09-20T16:10:27Z","updated_at":"2016-09-21T15:19:59Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/alphagov/paas-cf/pulls/500","html_url":"https://github.com/alphagov/paas-cf/pull/500","diff_url":"https://github.com/alphagov/paas-cf/pull/500.diff","patch_url":"https://github.com/alphagov/paas-cf/pull/500.patch"},"body":"## What\r\n\r\nThis moves Datadog API and App keys into the state bucket and adds a Makefile target for populating the state bucket from the credentials repo.\r\n\r\n## How to review\r\n\r\n1. Deploy an environment, login to datadog, observe that nothing is showing up there.\r\n2. Create a datadog API key and an app key, and place them in `~/.paas-pass/datadog/dev/datadog_api_key.gpg` and `~/.paas-pass/datadog/dev/datadog_app_key.gpg`\r\n3. Run `make dev upload-datadog-secrets`, observe that these credentials have been inserted into your environment s3 state bucket as `datadog-secrets.yml`\r\n4. Redeploy your pipelines, then redeploy the environment\r\n5. Type your environment name into \"filter\" on https://app.datadoghq.com/infrastructure/map and observe that all your hosts are monitored\r\n\r\n## Who can review\r\n\r\nNot @jonty or @richardc."},"comment":{"url":"https://api.github.com/repos/alphagov/paas-cf/issues/comments/248645304","html_url":"https://github.com/alphagov/paas-cf/pull/500#issuecomment-248645304","issue_url":"https://api.github.com/repos/alphagov/paas-cf/issues/500","id":248645304,"user":{"login":"keymon","id":280032,"avatar_url":"https://avatars.githubusercontent.com/u/280032?v=3","gravatar_id":"","url":"https://api.github.com/users/keymon","html_url":"https://github.com/keymon","followers_url":"https://api.github.com/users/keymon/followers","following_url":"https://api.github.com/users/keymon/following{/other_user}","gists_url":"https://api.github.com/users/keymon/gists{/gist_id}","starred_url":"https://api.github.com/users/keymon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keymon/subscriptions","organizations_url":"https://api.github.com/users/keymon/orgs","repos_url":"https://api.github.com/users/keymon/repos","events_url":"https://api.github.com/users/keymon/events{/privacy}","received_events_url":"https://api.github.com/users/keymon/received_events","type":"User","site_admin":false},"created_at":"2016-09-21T15:19:59Z","updated_at":"2016-09-21T15:19:59Z","body":"As commented, now it fails on travis because we got a too old version of shellcheck :(\r\n\r\nIf you can upgrade it, great. Thx and sorry for the inconvenience."}}
{"actor":{"display_login":"keymon"}}