{"action":"closed","number":21,"pull_request":{"url":"https://api.github.com/repos/Stencyl/stencyl-engine/pulls/21","id":65597016,"html_url":"https://github.com/Stencyl/stencyl-engine/pull/21","diff_url":"https://github.com/Stencyl/stencyl-engine/pull/21.diff","patch_url":"https://github.com/Stencyl/stencyl-engine/pull/21.patch","issue_url":"https://api.github.com/repos/Stencyl/stencyl-engine/issues/21","number":21,"state":"closed","locked":false,"title":"Fix: \"Scale to Fit (Letterbox)\" crops off the edges","user":{"login":"iamletmethink","id":13985596,"avatar_url":"https://avatars.githubusercontent.com/u/13985596?v=3","gravatar_id":"","url":"https://api.github.com/users/iamletmethink","html_url":"https://github.com/iamletmethink","followers_url":"https://api.github.com/users/iamletmethink/followers","following_url":"https://api.github.com/users/iamletmethink/following{/other_user}","gists_url":"https://api.github.com/users/iamletmethink/gists{/gist_id}","starred_url":"https://api.github.com/users/iamletmethink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iamletmethink/subscriptions","organizations_url":"https://api.github.com/users/iamletmethink/orgs","repos_url":"https://api.github.com/users/iamletmethink/repos","events_url":"https://api.github.com/users/iamletmethink/events{/privacy}","received_events_url":"https://api.github.com/users/iamletmethink/received_events","type":"User","site_admin":false},"body":"Rather than deciding based on the screen dimensions as is done currently (which is flawed), I am now calculating the scale using the minimum to get a side to the edge for scale to fit letterbox and the maximum for scale to fit fill. This means that letterboxing can occur on both the x and the y axis.","created_at":"2016-04-07T09:12:44Z","updated_at":"2016-04-07T12:08:35Z","closed_at":"2016-04-07T12:08:35Z","merged_at":"2016-04-07T12:08:35Z","merge_commit_sha":"48b46416504372bee810d767225e9484e6798edf","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Stencyl/stencyl-engine/pulls/21/commits","review_comments_url":"https://api.github.com/repos/Stencyl/stencyl-engine/pulls/21/comments","review_comment_url":"https://api.github.com/repos/Stencyl/stencyl-engine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Stencyl/stencyl-engine/issues/21/comments","statuses_url":"https://api.github.com/repos/Stencyl/stencyl-engine/statuses/4be5f14f158fc617a7a53a8c26f42529416e0032","head":{"label":"iamletmethink:patch-10","ref":"patch-10","sha":"4be5f14f158fc617a7a53a8c26f42529416e0032","user":{"login":"iamletmethink","id":13985596,"avatar_url":"https://avatars.githubusercontent.com/u/13985596?v=3","gravatar_id":"","url":"https://api.github.com/users/iamletmethink","html_url":"https://github.com/iamletmethink","followers_url":"https://api.github.com/users/iamletmethink/followers","following_url":"https://api.github.com/users/iamletmethink/following{/other_user}","gists_url":"https://api.github.com/users/iamletmethink/gists{/gist_id}","starred_url":"https://api.github.com/users/iamletmethink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iamletmethink/subscriptions","organizations_url":"https://api.github.com/users/iamletmethink/orgs","repos_url":"https://api.github.com/users/iamletmethink/repos","events_url":"https://api.github.com/users/iamletmethink/events{/privacy}","received_events_url":"https://api.github.com/users/iamletmethink/received_events","type":"User","site_admin":false},"repo":{"id":41442874,"name":"stencyl-engine","full_name":"iamletmethink/stencyl-engine","owner":{"login":"iamletmethink","id":13985596,"avatar_url":"https://avatars.githubusercontent.com/u/13985596?v=3","gravatar_id":"","url":"https://api.github.com/users/iamletmethink","html_url":"https://github.com/iamletmethink","followers_url":"https://api.github.com/users/iamletmethink/followers","following_url":"https://api.github.com/users/iamletmethink/following{/other_user}","gists_url":"https://api.github.com/users/iamletmethink/gists{/gist_id}","starred_url":"https://api.github.com/users/iamletmethink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iamletmethink/subscriptions","organizations_url":"https://api.github.com/users/iamletmethink/orgs","repos_url":"https://api.github.com/users/iamletmethink/repos","events_url":"https://api.github.com/users/iamletmethink/events{/privacy}","received_events_url":"https://api.github.com/users/iamletmethink/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/iamletmethink/stencyl-engine","description":"Create Flash, iOS, Android, and desktop games with no code with Stencyl. This is the source to Stencyl's Haxe-based engine.","fork":true,"url":"https://api.github.com/repos/iamletmethink/stencyl-engine","forks_url":"https://api.github.com/repos/iamletmethink/stencyl-engine/forks","keys_url":"https://api.github.com/repos/iamletmethink/stencyl-engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iamletmethink/stencyl-engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iamletmethink/stencyl-engine/teams","hooks_url":"https://api.github.com/repos/iamletmethink/stencyl-engine/hooks","issue_events_url":"https://api.github.com/repos/iamletmethink/stencyl-engine/issues/events{/number}","events_url":"https://api.github.com/repos/iamletmethink/stencyl-engine/events","assignees_url":"https://api.github.com/repos/iamletmethink/stencyl-engine/assignees{/user}","branches_url":"https://api.github.com/repos/iamletmethink/stencyl-engine/branches{/branch}","tags_url":"https://api.github.com/repos/iamletmethink/stencyl-engine/tags","blobs_url":"https://api.github.com/repos/iamletmethink/stencyl-engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iamletmethink/stencyl-engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iamletmethink/stencyl-engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/iamletmethink/stencyl-engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iamletmethink/stencyl-engine/statuses/{sha}","languages_url":"https://api.github.com/repos/iamletmethink/stencyl-engine/languages","stargazers_url":"https://api.github.com/repos/iamletmethink/stencyl-engine/stargazers","contributors_url":"https://api.github.com/repos/iamletmethink/stencyl-engine/contributors","subscribers_url":"https://api.github.com/repos/iamletmethink/stencyl-engine/subscribers","subscription_url":"https://api.github.com/repos/iamletmethink/stencyl-engine/subscription","commits_url":"https://api.github.com/repos/iamletmethink/stencyl-engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/iamletmethink/stencyl-engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/iamletmethink/stencyl-engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/iamletmethink/stencyl-engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/iamletmethink/stencyl-engine/contents/{+path}","compare_url":"https://api.github.com/repos/iamletmethink/stencyl-engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iamletmethink/stencyl-engine/merges","archive_url":"https://api.github.com/repos/iamletmethink/stencyl-engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iamletmethink/stencyl-engine/downloads","issues_url":"https://api.github.com/repos/iamletmethink/stencyl-engine/issues{/number}","pulls_url":"https://api.github.com/repos/iamletmethink/stencyl-engine/pulls{/number}","milestones_url":"https://api.github.com/repos/iamletmethink/stencyl-engine/milestones{/number}","notifications_url":"https://api.github.com/repos/iamletmethink/stencyl-engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iamletmethink/stencyl-engine/labels{/name}","releases_url":"https://api.github.com/repos/iamletmethink/stencyl-engine/releases{/id}","deployments_url":"https://api.github.com/repos/iamletmethink/stencyl-engine/deployments","created_at":"2015-08-26T18:31:18Z","updated_at":"2016-03-31T14:08:51Z","pushed_at":"2016-04-07T09:12:16Z","git_url":"git://github.com/iamletmethink/stencyl-engine.git","ssh_url":"git@github.com:iamletmethink/stencyl-engine.git","clone_url":"https://github.com/iamletmethink/stencyl-engine.git","svn_url":"https://github.com/iamletmethink/stencyl-engine","homepage":"http://www.stencyl.com","size":1246,"stargazers_count":0,"watchers_count":0,"language":"Haxe","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Stencyl:master","ref":"master","sha":"574df25d5cbea5047ad655ddd6a73b5f80af65fb","user":{"login":"Stencyl","id":767125,"avatar_url":"https://avatars.githubusercontent.com/u/767125?v=3","gravatar_id":"","url":"https://api.github.com/users/Stencyl","html_url":"https://github.com/Stencyl","followers_url":"https://api.github.com/users/Stencyl/followers","following_url":"https://api.github.com/users/Stencyl/following{/other_user}","gists_url":"https://api.github.com/users/Stencyl/gists{/gist_id}","starred_url":"https://api.github.com/users/Stencyl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Stencyl/subscriptions","organizations_url":"https://api.github.com/users/Stencyl/orgs","repos_url":"https://api.github.com/users/Stencyl/repos","events_url":"https://api.github.com/users/Stencyl/events{/privacy}","received_events_url":"https://api.github.com/users/Stencyl/received_events","type":"Organization","site_admin":false},"repo":{"id":9865622,"name":"stencyl-engine","full_name":"Stencyl/stencyl-engine","owner":{"login":"Stencyl","id":767125,"avatar_url":"https://avatars.githubusercontent.com/u/767125?v=3","gravatar_id":"","url":"https://api.github.com/users/Stencyl","html_url":"https://github.com/Stencyl","followers_url":"https://api.github.com/users/Stencyl/followers","following_url":"https://api.github.com/users/Stencyl/following{/other_user}","gists_url":"https://api.github.com/users/Stencyl/gists{/gist_id}","starred_url":"https://api.github.com/users/Stencyl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Stencyl/subscriptions","organizations_url":"https://api.github.com/users/Stencyl/orgs","repos_url":"https://api.github.com/users/Stencyl/repos","events_url":"https://api.github.com/users/Stencyl/events{/privacy}","received_events_url":"https://api.github.com/users/Stencyl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Stencyl/stencyl-engine","description":"Create Flash, HTML5, iOS, Android, and desktop games with no code with Stencyl. This is the source to Stencyl's Haxe-based engine.","fork":false,"url":"https://api.github.com/repos/Stencyl/stencyl-engine","forks_url":"https://api.github.com/repos/Stencyl/stencyl-engine/forks","keys_url":"https://api.github.com/repos/Stencyl/stencyl-engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Stencyl/stencyl-engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Stencyl/stencyl-engine/teams","hooks_url":"https://api.github.com/repos/Stencyl/stencyl-engine/hooks","issue_events_url":"https://api.github.com/repos/Stencyl/stencyl-engine/issues/events{/number}","events_url":"https://api.github.com/repos/Stencyl/stencyl-engine/events","assignees_url":"https://api.github.com/repos/Stencyl/stencyl-engine/assignees{/user}","branches_url":"https://api.github.com/repos/Stencyl/stencyl-engine/branches{/branch}","tags_url":"https://api.github.com/repos/Stencyl/stencyl-engine/tags","blobs_url":"https://api.github.com/repos/Stencyl/stencyl-engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Stencyl/stencyl-engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Stencyl/stencyl-engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/Stencyl/stencyl-engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Stencyl/stencyl-engine/statuses/{sha}","languages_url":"https://api.github.com/repos/Stencyl/stencyl-engine/languages","stargazers_url":"https://api.github.com/repos/Stencyl/stencyl-engine/stargazers","contributors_url":"https://api.github.com/repos/Stencyl/stencyl-engine/contributors","subscribers_url":"https://api.github.com/repos/Stencyl/stencyl-engine/subscribers","subscription_url":"https://api.github.com/repos/Stencyl/stencyl-engine/subscription","commits_url":"https://api.github.com/repos/Stencyl/stencyl-engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/Stencyl/stencyl-engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/Stencyl/stencyl-engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/Stencyl/stencyl-engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/Stencyl/stencyl-engine/contents/{+path}","compare_url":"https://api.github.com/repos/Stencyl/stencyl-engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Stencyl/stencyl-engine/merges","archive_url":"https://api.github.com/repos/Stencyl/stencyl-engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Stencyl/stencyl-engine/downloads","issues_url":"https://api.github.com/repos/Stencyl/stencyl-engine/issues{/number}","pulls_url":"https://api.github.com/repos/Stencyl/stencyl-engine/pulls{/number}","milestones_url":"https://api.github.com/repos/Stencyl/stencyl-engine/milestones{/number}","notifications_url":"https://api.github.com/repos/Stencyl/stencyl-engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Stencyl/stencyl-engine/labels{/name}","releases_url":"https://api.github.com/repos/Stencyl/stencyl-engine/releases{/id}","deployments_url":"https://api.github.com/repos/Stencyl/stencyl-engine/deployments","created_at":"2013-05-05T07:50:18Z","updated_at":"2016-03-08T08:54:56Z","pushed_at":"2016-04-07T12:08:36Z","git_url":"git://github.com/Stencyl/stencyl-engine.git","ssh_url":"git@github.com:Stencyl/stencyl-engine.git","clone_url":"https://github.com/Stencyl/stencyl-engine.git","svn_url":"https://github.com/Stencyl/stencyl-engine","homepage":"http://www.stencyl.com","size":2432,"stargazers_count":53,"watchers_count":53,"language":"Haxe","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":1,"forks":17,"open_issues":1,"watchers":53,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Stencyl/stencyl-engine/pulls/21"},"html":{"href":"https://github.com/Stencyl/stencyl-engine/pull/21"},"issue":{"href":"https://api.github.com/repos/Stencyl/stencyl-engine/issues/21"},"comments":{"href":"https://api.github.com/repos/Stencyl/stencyl-engine/issues/21/comments"},"review_comments":{"href":"https://api.github.com/repos/Stencyl/stencyl-engine/pulls/21/comments"},"review_comment":{"href":"https://api.github.com/repos/Stencyl/stencyl-engine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Stencyl/stencyl-engine/pulls/21/commits"},"statuses":{"href":"https://api.github.com/repos/Stencyl/stencyl-engine/statuses/4be5f14f158fc617a7a53a8c26f42529416e0032"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"darioseidl","id":4629505,"avatar_url":"https://avatars.githubusercontent.com/u/4629505?v=3","gravatar_id":"","url":"https://api.github.com/users/darioseidl","html_url":"https://github.com/darioseidl","followers_url":"https://api.github.com/users/darioseidl/followers","following_url":"https://api.github.com/users/darioseidl/following{/other_user}","gists_url":"https://api.github.com/users/darioseidl/gists{/gist_id}","starred_url":"https://api.github.com/users/darioseidl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darioseidl/subscriptions","organizations_url":"https://api.github.com/users/darioseidl/orgs","repos_url":"https://api.github.com/users/darioseidl/repos","events_url":"https://api.github.com/users/darioseidl/events{/privacy}","received_events_url":"https://api.github.com/users/darioseidl/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":4,"deletions":22,"changed_files":1}}