{"action":"created","comment":{"url":"https://api.github.com/repos/PaycoinFoundation/paycoin/pulls/comments/53712646","id":53712646,"diff_hunk":"@@ -103,12 +103,11 @@ CAddrInfo* CAddrMan::Create(const CAddress &addr, const CNetAddr &addrSource, in\n     return &mapInfo[nId];\n }\n \n-void CAddrMan::SwapRandom(int nRndPos1, int nRndPos2)\n+void CAddrMan::SwapRandom(unsigned int nRndPos1, unsigned int nRndPos2)\n {\n     if (nRndPos1 == nRndPos2)\n         return;\n \n-    assert(nRndPos1 >= 0 && nRndPos2 >= 0);","path":"src/addrman.cpp","position":10,"original_position":10,"commit_id":"214bcf5302d3ccaebf76560189262c0940b9fea9","original_commit_id":"214bcf5302d3ccaebf76560189262c0940b9fea9","user":{"login":"IngCr3at1on","id":922158,"avatar_url":"https://avatars.githubusercontent.com/u/922158?v=3","gravatar_id":"","url":"https://api.github.com/users/IngCr3at1on","html_url":"https://github.com/IngCr3at1on","followers_url":"https://api.github.com/users/IngCr3at1on/followers","following_url":"https://api.github.com/users/IngCr3at1on/following{/other_user}","gists_url":"https://api.github.com/users/IngCr3at1on/gists{/gist_id}","starred_url":"https://api.github.com/users/IngCr3at1on/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IngCr3at1on/subscriptions","organizations_url":"https://api.github.com/users/IngCr3at1on/orgs","repos_url":"https://api.github.com/users/IngCr3at1on/repos","events_url":"https://api.github.com/users/IngCr3at1on/events{/privacy}","received_events_url":"https://api.github.com/users/IngCr3at1on/received_events","type":"User","site_admin":false},"body":"So essentially this is meant to insure that the RndPos# variables are positive...\r\n\r\nI'm wondering if there is any chance that they could ever be negative (if they were and this was left in place it would actually crash the application; I'm not sure what the behavior would be with this check missing); just because it was removed in Bitcoin doesn't necessarily mean it's safe or a good idea for us to remove it though...\r\n\r\nThoughts?","created_at":"2016-02-22T23:32:15Z","updated_at":"2016-02-22T23:32:15Z","html_url":"https://github.com/PaycoinFoundation/paycoin/pull/437#discussion_r53712646","pull_request_url":"https://api.github.com/repos/PaycoinFoundation/paycoin/pulls/437","_links":{"self":{"href":"https://api.github.com/repos/PaycoinFoundation/paycoin/pulls/comments/53712646"},"html":{"href":"https://github.com/PaycoinFoundation/paycoin/pull/437#discussion_r53712646"},"pull_request":{"href":"https://api.github.com/repos/PaycoinFoundation/paycoin/pulls/437"}}},"pull_request":{"url":"https://api.github.com/repos/PaycoinFoundation/paycoin/pulls/437","id":54355409,"html_url":"https://github.com/PaycoinFoundation/paycoin/pull/437","diff_url":"https://github.com/PaycoinFoundation/paycoin/pull/437.diff","patch_url":"https://github.com/PaycoinFoundation/paycoin/pull/437.patch","issue_url":"https://api.github.com/repos/PaycoinFoundation/paycoin/issues/437","number":437,"state":"open","locked":false,"title":"Fix sign comparison warnings","user":{"login":"mitchellcash","id":8009243,"avatar_url":"https://avatars.githubusercontent.com/u/8009243?v=3","gravatar_id":"","url":"https://api.github.com/users/mitchellcash","html_url":"https://github.com/mitchellcash","followers_url":"https://api.github.com/users/mitchellcash/followers","following_url":"https://api.github.com/users/mitchellcash/following{/other_user}","gists_url":"https://api.github.com/users/mitchellcash/gists{/gist_id}","starred_url":"https://api.github.com/users/mitchellcash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitchellcash/subscriptions","organizations_url":"https://api.github.com/users/mitchellcash/orgs","repos_url":"https://api.github.com/users/mitchellcash/repos","events_url":"https://api.github.com/users/mitchellcash/events{/privacy}","received_events_url":"https://api.github.com/users/mitchellcash/received_events","type":"User","site_admin":false},"body":"This does take some thunder from #366 but I think the commit messages are more detailed and it also includes some extra changes/improvements that #366 does not.","created_at":"2015-12-22T10:38:46Z","updated_at":"2016-02-22T23:32:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5ed466c8b7bac479376dc099d249177717bef108","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/PaycoinFoundation/paycoin/pulls/437/commits","review_comments_url":"https://api.github.com/repos/PaycoinFoundation/paycoin/pulls/437/comments","review_comment_url":"https://api.github.com/repos/PaycoinFoundation/paycoin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PaycoinFoundation/paycoin/issues/437/comments","statuses_url":"https://api.github.com/repos/PaycoinFoundation/paycoin/statuses/214bcf5302d3ccaebf76560189262c0940b9fea9","head":{"label":"mitchellcash:sign-compare","ref":"sign-compare","sha":"214bcf5302d3ccaebf76560189262c0940b9fea9","user":{"login":"mitchellcash","id":8009243,"avatar_url":"https://avatars.githubusercontent.com/u/8009243?v=3","gravatar_id":"","url":"https://api.github.com/users/mitchellcash","html_url":"https://github.com/mitchellcash","followers_url":"https://api.github.com/users/mitchellcash/followers","following_url":"https://api.github.com/users/mitchellcash/following{/other_user}","gists_url":"https://api.github.com/users/mitchellcash/gists{/gist_id}","starred_url":"https://api.github.com/users/mitchellcash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitchellcash/subscriptions","organizations_url":"https://api.github.com/users/mitchellcash/orgs","repos_url":"https://api.github.com/users/mitchellcash/repos","events_url":"https://api.github.com/users/mitchellcash/events{/privacy}","received_events_url":"https://api.github.com/users/mitchellcash/received_events","type":"User","site_admin":false},"repo":{"id":32920530,"name":"paycoin","full_name":"mitchellcash/paycoin","owner":{"login":"mitchellcash","id":8009243,"avatar_url":"https://avatars.githubusercontent.com/u/8009243?v=3","gravatar_id":"","url":"https://api.github.com/users/mitchellcash","html_url":"https://github.com/mitchellcash","followers_url":"https://api.github.com/users/mitchellcash/followers","following_url":"https://api.github.com/users/mitchellcash/following{/other_user}","gists_url":"https://api.github.com/users/mitchellcash/gists{/gist_id}","starred_url":"https://api.github.com/users/mitchellcash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitchellcash/subscriptions","organizations_url":"https://api.github.com/users/mitchellcash/orgs","repos_url":"https://api.github.com/users/mitchellcash/repos","events_url":"https://api.github.com/users/mitchellcash/events{/privacy}","received_events_url":"https://api.github.com/users/mitchellcash/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mitchellcash/paycoin","description":"Paycoin","fork":true,"url":"https://api.github.com/repos/mitchellcash/paycoin","forks_url":"https://api.github.com/repos/mitchellcash/paycoin/forks","keys_url":"https://api.github.com/repos/mitchellcash/paycoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mitchellcash/paycoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mitchellcash/paycoin/teams","hooks_url":"https://api.github.com/repos/mitchellcash/paycoin/hooks","issue_events_url":"https://api.github.com/repos/mitchellcash/paycoin/issues/events{/number}","events_url":"https://api.github.com/repos/mitchellcash/paycoin/events","assignees_url":"https://api.github.com/repos/mitchellcash/paycoin/assignees{/user}","branches_url":"https://api.github.com/repos/mitchellcash/paycoin/branches{/branch}","tags_url":"https://api.github.com/repos/mitchellcash/paycoin/tags","blobs_url":"https://api.github.com/repos/mitchellcash/paycoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mitchellcash/paycoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mitchellcash/paycoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/mitchellcash/paycoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mitchellcash/paycoin/statuses/{sha}","languages_url":"https://api.github.com/repos/mitchellcash/paycoin/languages","stargazers_url":"https://api.github.com/repos/mitchellcash/paycoin/stargazers","contributors_url":"https://api.github.com/repos/mitchellcash/paycoin/contributors","subscribers_url":"https://api.github.com/repos/mitchellcash/paycoin/subscribers","subscription_url":"https://api.github.com/repos/mitchellcash/paycoin/subscription","commits_url":"https://api.github.com/repos/mitchellcash/paycoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/mitchellcash/paycoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/mitchellcash/paycoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/mitchellcash/paycoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/mitchellcash/paycoin/contents/{+path}","compare_url":"https://api.github.com/repos/mitchellcash/paycoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mitchellcash/paycoin/merges","archive_url":"https://api.github.com/repos/mitchellcash/paycoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mitchellcash/paycoin/downloads","issues_url":"https://api.github.com/repos/mitchellcash/paycoin/issues{/number}","pulls_url":"https://api.github.com/repos/mitchellcash/paycoin/pulls{/number}","milestones_url":"https://api.github.com/repos/mitchellcash/paycoin/milestones{/number}","notifications_url":"https://api.github.com/repos/mitchellcash/paycoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mitchellcash/paycoin/labels{/name}","releases_url":"https://api.github.com/repos/mitchellcash/paycoin/releases{/id}","deployments_url":"https://api.github.com/repos/mitchellcash/paycoin/deployments","created_at":"2015-03-26T10:17:02Z","updated_at":"2016-01-16T03:04:30Z","pushed_at":"2016-02-22T10:16:04Z","git_url":"git://github.com/mitchellcash/paycoin.git","ssh_url":"git@github.com:mitchellcash/paycoin.git","clone_url":"https://github.com/mitchellcash/paycoin.git","svn_url":"https://github.com/mitchellcash/paycoin","homepage":"https://paycoin.com","size":35222,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"PaycoinFoundation:master","ref":"master","sha":"9b4fc440cdc630deb1d6058df07bf2027ffb0665","user":{"login":"PaycoinFoundation","id":10690863,"avatar_url":"https://avatars.githubusercontent.com/u/10690863?v=3","gravatar_id":"","url":"https://api.github.com/users/PaycoinFoundation","html_url":"https://github.com/PaycoinFoundation","followers_url":"https://api.github.com/users/PaycoinFoundation/followers","following_url":"https://api.github.com/users/PaycoinFoundation/following{/other_user}","gists_url":"https://api.github.com/users/PaycoinFoundation/gists{/gist_id}","starred_url":"https://api.github.com/users/PaycoinFoundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PaycoinFoundation/subscriptions","organizations_url":"https://api.github.com/users/PaycoinFoundation/orgs","repos_url":"https://api.github.com/users/PaycoinFoundation/repos","events_url":"https://api.github.com/users/PaycoinFoundation/events{/privacy}","received_events_url":"https://api.github.com/users/PaycoinFoundation/received_events","type":"Organization","site_admin":false},"repo":{"id":27197763,"name":"paycoin","full_name":"PaycoinFoundation/paycoin","owner":{"login":"PaycoinFoundation","id":10690863,"avatar_url":"https://avatars.githubusercontent.com/u/10690863?v=3","gravatar_id":"","url":"https://api.github.com/users/PaycoinFoundation","html_url":"https://github.com/PaycoinFoundation","followers_url":"https://api.github.com/users/PaycoinFoundation/followers","following_url":"https://api.github.com/users/PaycoinFoundation/following{/other_user}","gists_url":"https://api.github.com/users/PaycoinFoundation/gists{/gist_id}","starred_url":"https://api.github.com/users/PaycoinFoundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PaycoinFoundation/subscriptions","organizations_url":"https://api.github.com/users/PaycoinFoundation/orgs","repos_url":"https://api.github.com/users/PaycoinFoundation/repos","events_url":"https://api.github.com/users/PaycoinFoundation/events{/privacy}","received_events_url":"https://api.github.com/users/PaycoinFoundation/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PaycoinFoundation/paycoin","description":"Paycoin","fork":false,"url":"https://api.github.com/repos/PaycoinFoundation/paycoin","forks_url":"https://api.github.com/repos/PaycoinFoundation/paycoin/forks","keys_url":"https://api.github.com/repos/PaycoinFoundation/paycoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PaycoinFoundation/paycoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PaycoinFoundation/paycoin/teams","hooks_url":"https://api.github.com/repos/PaycoinFoundation/paycoin/hooks","issue_events_url":"https://api.github.com/repos/PaycoinFoundation/paycoin/issues/events{/number}","events_url":"https://api.github.com/repos/PaycoinFoundation/paycoin/events","assignees_url":"https://api.github.com/repos/PaycoinFoundation/paycoin/assignees{/user}","branches_url":"https://api.github.com/repos/PaycoinFoundation/paycoin/branches{/branch}","tags_url":"https://api.github.com/repos/PaycoinFoundation/paycoin/tags","blobs_url":"https://api.github.com/repos/PaycoinFoundation/paycoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PaycoinFoundation/paycoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PaycoinFoundation/paycoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/PaycoinFoundation/paycoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PaycoinFoundation/paycoin/statuses/{sha}","languages_url":"https://api.github.com/repos/PaycoinFoundation/paycoin/languages","stargazers_url":"https://api.github.com/repos/PaycoinFoundation/paycoin/stargazers","contributors_url":"https://api.github.com/repos/PaycoinFoundation/paycoin/contributors","subscribers_url":"https://api.github.com/repos/PaycoinFoundation/paycoin/subscribers","subscription_url":"https://api.github.com/repos/PaycoinFoundation/paycoin/subscription","commits_url":"https://api.github.com/repos/PaycoinFoundation/paycoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/PaycoinFoundation/paycoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/PaycoinFoundation/paycoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/PaycoinFoundation/paycoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/PaycoinFoundation/paycoin/contents/{+path}","compare_url":"https://api.github.com/repos/PaycoinFoundation/paycoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PaycoinFoundation/paycoin/merges","archive_url":"https://api.github.com/repos/PaycoinFoundation/paycoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PaycoinFoundation/paycoin/downloads","issues_url":"https://api.github.com/repos/PaycoinFoundation/paycoin/issues{/number}","pulls_url":"https://api.github.com/repos/PaycoinFoundation/paycoin/pulls{/number}","milestones_url":"https://api.github.com/repos/PaycoinFoundation/paycoin/milestones{/number}","notifications_url":"https://api.github.com/repos/PaycoinFoundation/paycoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PaycoinFoundation/paycoin/labels{/name}","releases_url":"https://api.github.com/repos/PaycoinFoundation/paycoin/releases{/id}","deployments_url":"https://api.github.com/repos/PaycoinFoundation/paycoin/deployments","created_at":"2014-11-26T21:51:18Z","updated_at":"2016-02-19T22:59:45Z","pushed_at":"2016-02-22T19:49:28Z","git_url":"git://github.com/PaycoinFoundation/paycoin.git","ssh_url":"git@github.com:PaycoinFoundation/paycoin.git","clone_url":"https://github.com/PaycoinFoundation/paycoin.git","svn_url":"https://github.com/PaycoinFoundation/paycoin","homepage":"https://paycoin.com","size":36463,"stargazers_count":34,"watchers_count":34,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":77,"mirror_url":null,"open_issues_count":82,"forks":77,"open_issues":82,"watchers":34,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PaycoinFoundation/paycoin/pulls/437"},"html":{"href":"https://github.com/PaycoinFoundation/paycoin/pull/437"},"issue":{"href":"https://api.github.com/repos/PaycoinFoundation/paycoin/issues/437"},"comments":{"href":"https://api.github.com/repos/PaycoinFoundation/paycoin/issues/437/comments"},"review_comments":{"href":"https://api.github.com/repos/PaycoinFoundation/paycoin/pulls/437/comments"},"review_comment":{"href":"https://api.github.com/repos/PaycoinFoundation/paycoin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PaycoinFoundation/paycoin/pulls/437/commits"},"statuses":{"href":"https://api.github.com/repos/PaycoinFoundation/paycoin/statuses/214bcf5302d3ccaebf76560189262c0940b9fea9"}}}}