{"action":"created","issue":{"url":"https://api.github.com/repos/puppetlabs/jruby-utils/issues/26","repository_url":"https://api.github.com/repos/puppetlabs/jruby-utils","labels_url":"https://api.github.com/repos/puppetlabs/jruby-utils/issues/26/labels{/name}","comments_url":"https://api.github.com/repos/puppetlabs/jruby-utils/issues/26/comments","events_url":"https://api.github.com/repos/puppetlabs/jruby-utils/issues/26/events","html_url":"https://github.com/puppetlabs/jruby-utils/pull/26","id":180745722,"number":26,"title":"(SERVER-1412) Add support for `gem-path` config","user":{"login":"cprice404","id":1341071,"avatar_url":"https://avatars.githubusercontent.com/u/1341071?v=3","gravatar_id":"","url":"https://api.github.com/users/cprice404","html_url":"https://github.com/cprice404","followers_url":"https://api.github.com/users/cprice404/followers","following_url":"https://api.github.com/users/cprice404/following{/other_user}","gists_url":"https://api.github.com/users/cprice404/gists{/gist_id}","starred_url":"https://api.github.com/users/cprice404/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cprice404/subscriptions","organizations_url":"https://api.github.com/users/cprice404/orgs","repos_url":"https://api.github.com/users/cprice404/repos","events_url":"https://api.github.com/users/cprice404/events{/privacy}","received_events_url":"https://api.github.com/users/cprice404/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-10-03T20:59:47Z","updated_at":"2016-10-03T22:40:37Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/puppetlabs/jruby-utils/pulls/26","html_url":"https://github.com/puppetlabs/jruby-utils/pull/26","diff_url":"https://github.com/puppetlabs/jruby-utils/pull/26.diff","patch_url":"https://github.com/puppetlabs/jruby-utils/pull/26.patch"},"body":"This commit adds support for a `gem-path` configuration setting.\r\nIf specified it will be used as the value for the GEM_PATH\r\nenvironment variable.  If not, GEM_PATH will be set to the same value\r\nas GEM_HOME.\r\n\r\nThis is in support of SERVER-1412, where the server will pass in a value for this setting that includes a new \"vendored\" gem directory.  My intent is that Puppet Server will *always* pass in a value for this setting, and will have its own logic for defaulting the value that it uses for that setting.  But as far as the API of this library goes it seemed like this was the best way to build it.  Open to feedback - would be willing to make it a required argument if people thought that was better (that was my original instinct on how to implement this)."},"comment":{"url":"https://api.github.com/repos/puppetlabs/jruby-utils/issues/comments/251248080","html_url":"https://github.com/puppetlabs/jruby-utils/pull/26#issuecomment-251248080","issue_url":"https://api.github.com/repos/puppetlabs/jruby-utils/issues/26","id":251248080,"user":{"login":"camlow325","id":5652737,"avatar_url":"https://avatars.githubusercontent.com/u/5652737?v=3","gravatar_id":"","url":"https://api.github.com/users/camlow325","html_url":"https://github.com/camlow325","followers_url":"https://api.github.com/users/camlow325/followers","following_url":"https://api.github.com/users/camlow325/following{/other_user}","gists_url":"https://api.github.com/users/camlow325/gists{/gist_id}","starred_url":"https://api.github.com/users/camlow325/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/camlow325/subscriptions","organizations_url":"https://api.github.com/users/camlow325/orgs","repos_url":"https://api.github.com/users/camlow325/repos","events_url":"https://api.github.com/users/camlow325/events{/privacy}","received_events_url":"https://api.github.com/users/camlow325/received_events","type":"User","site_admin":false},"created_at":"2016-10-03T22:40:37Z","updated_at":"2016-10-03T22:40:37Z","body":"When I run `gem env` on a Puppet Server 2.6.0 install today, I see that JRuby has added in a couple of special GEM PATHS that it knows about:\r\n\r\n```\r\n  - GEM PATHS:\r\n     - /opt/puppetlabs/server/data/puppetserver/jruby-gems\r\n     - /root/.gem/jruby/1.9\r\n     - file:/opt/puppetlabs/server/apps/puppetserver/puppet-server-release.jar!/META-INF/jruby.home/lib/ruby/gems/shared\r\n```\r\n\r\nIn this case, the top one comes from `GEM_HOME`.  The `/root/.gem/jruby/1.9` seems ... undesirable?  The last one, though, is one I think we need to have in order for some of the built-in jruby gems to work properly.  With the changes on this PR, will that last one still be included even when we're explicitly setting the `GEM_PATH` variable? "}}
{"actor":{"display_login":"camlow325"}}