{"action":"created","comment":{"url":"https://api.github.com/repos/SteamRE/SteamKit/pulls/comments/68486148","id":68486148,"diff_hunk":"@@ -187,10 +188,14 @@ public override void Connect(IPEndPoint endPoint, int timeout)\n                     Debug.Assert(cancellationToken == null);\r\n                     cancellationToken = new CancellationTokenSource();\r\n \r\n-                    destination = endPoint;\r\n                     socket = new Socket(AddressFamily.InterNetwork, SocketType.Stream, ProtocolType.Tcp);\r\n \r\n-                    ThreadPool.QueueUserWorkItem(TryConnect, timeout);\r\n+                    endPoint.ContinueWith(t =>\r","path":"SteamKit2/SteamKit2/Networking/Steam3/TcpConnection.cs","position":25,"original_position":25,"commit_id":"139945da7758cb1223b6184f42ac98728834f393","original_commit_id":"139945da7758cb1223b6184f42ac98728834f393","user":{"login":"Netshroud","id":284592,"avatar_url":"https://avatars.githubusercontent.com/u/284592?v=3","gravatar_id":"","url":"https://api.github.com/users/Netshroud","html_url":"https://github.com/Netshroud","followers_url":"https://api.github.com/users/Netshroud/followers","following_url":"https://api.github.com/users/Netshroud/following{/other_user}","gists_url":"https://api.github.com/users/Netshroud/gists{/gist_id}","starred_url":"https://api.github.com/users/Netshroud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Netshroud/subscriptions","organizations_url":"https://api.github.com/users/Netshroud/orgs","repos_url":"https://api.github.com/users/Netshroud/repos","events_url":"https://api.github.com/users/Netshroud/events{/privacy}","received_events_url":"https://api.github.com/users/Netshroud/received_events","type":"User","site_admin":false},"body":"What if `endPoint` (suggest renaming to `endPointTask`) is faulted or cancelled? IIRC `t.Result` will blow up, on some thread we don't control.","created_at":"2016-06-25T08:19:25Z","updated_at":"2016-06-25T08:19:25Z","html_url":"https://github.com/SteamRE/SteamKit/pull/293#discussion_r68486148","pull_request_url":"https://api.github.com/repos/SteamRE/SteamKit/pulls/293","_links":{"self":{"href":"https://api.github.com/repos/SteamRE/SteamKit/pulls/comments/68486148"},"html":{"href":"https://github.com/SteamRE/SteamKit/pull/293#discussion_r68486148"},"pull_request":{"href":"https://api.github.com/repos/SteamRE/SteamKit/pulls/293"}}},"pull_request":{"url":"https://api.github.com/repos/SteamRE/SteamKit/pulls/293","id":75164166,"html_url":"https://github.com/SteamRE/SteamKit/pull/293","diff_url":"https://github.com/SteamRE/SteamKit/pull/293.diff","patch_url":"https://github.com/SteamRE/SteamKit/pull/293.patch","issue_url":"https://api.github.com/repos/SteamRE/SteamKit/issues/293","number":293,"state":"open","locked":false,"title":"Persistent server list","user":{"login":"azuisleet","id":712742,"avatar_url":"https://avatars.githubusercontent.com/u/712742?v=3","gravatar_id":"","url":"https://api.github.com/users/azuisleet","html_url":"https://github.com/azuisleet","followers_url":"https://api.github.com/users/azuisleet/followers","following_url":"https://api.github.com/users/azuisleet/following{/other_user}","gists_url":"https://api.github.com/users/azuisleet/gists{/gist_id}","starred_url":"https://api.github.com/users/azuisleet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azuisleet/subscriptions","organizations_url":"https://api.github.com/users/azuisleet/orgs","repos_url":"https://api.github.com/users/azuisleet/repos","events_url":"https://api.github.com/users/azuisleet/events{/privacy}","received_events_url":"https://api.github.com/users/azuisleet/received_events","type":"User","site_admin":false},"body":"- Addresses the need to fetch servers from SteamDirectory\r\n- Provides persistent storage mechanisms with: FileStorageServerListProvider, IsolatedStorageServerListProvider (with an attached snk), and NullServerListProvider (the default)\r\n- Modifies the connect path to take tasks and uses continuations for them\r\n- The guts of SmartCMServerList have been replaced to only handle the most recent complete list. It not longer allows adding individual endpoints.\r\n\r\nSee sample 7 for how persistence can be used.","created_at":"2016-06-24T19:47:29Z","updated_at":"2016-06-25T08:19:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"630486a1ad926ab4844b42970d4379efd5cd132c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/SteamRE/SteamKit/pulls/293/commits","review_comments_url":"https://api.github.com/repos/SteamRE/SteamKit/pulls/293/comments","review_comment_url":"https://api.github.com/repos/SteamRE/SteamKit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SteamRE/SteamKit/issues/293/comments","statuses_url":"https://api.github.com/repos/SteamRE/SteamKit/statuses/139945da7758cb1223b6184f42ac98728834f393","head":{"label":"SteamRE:persistent-server-list","ref":"persistent-server-list","sha":"139945da7758cb1223b6184f42ac98728834f393","user":{"login":"SteamRE","id":4567126,"avatar_url":"https://avatars.githubusercontent.com/u/4567126?v=3","gravatar_id":"","url":"https://api.github.com/users/SteamRE","html_url":"https://github.com/SteamRE","followers_url":"https://api.github.com/users/SteamRE/followers","following_url":"https://api.github.com/users/SteamRE/following{/other_user}","gists_url":"https://api.github.com/users/SteamRE/gists{/gist_id}","starred_url":"https://api.github.com/users/SteamRE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SteamRE/subscriptions","organizations_url":"https://api.github.com/users/SteamRE/orgs","repos_url":"https://api.github.com/users/SteamRE/repos","events_url":"https://api.github.com/users/SteamRE/events{/privacy}","received_events_url":"https://api.github.com/users/SteamRE/received_events","type":"Organization","site_admin":false},"repo":{"id":10376425,"name":"SteamKit","full_name":"SteamRE/SteamKit","owner":{"login":"SteamRE","id":4567126,"avatar_url":"https://avatars.githubusercontent.com/u/4567126?v=3","gravatar_id":"","url":"https://api.github.com/users/SteamRE","html_url":"https://github.com/SteamRE","followers_url":"https://api.github.com/users/SteamRE/followers","following_url":"https://api.github.com/users/SteamRE/following{/other_user}","gists_url":"https://api.github.com/users/SteamRE/gists{/gist_id}","starred_url":"https://api.github.com/users/SteamRE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SteamRE/subscriptions","organizations_url":"https://api.github.com/users/SteamRE/orgs","repos_url":"https://api.github.com/users/SteamRE/repos","events_url":"https://api.github.com/users/SteamRE/events{/privacy}","received_events_url":"https://api.github.com/users/SteamRE/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SteamRE/SteamKit","description":"SteamKit2 is a .NET library designed to interoperate with Valve's Steam network. It aims to provide a simple, yet extensible, interface to perform various actions on the network.","fork":false,"url":"https://api.github.com/repos/SteamRE/SteamKit","forks_url":"https://api.github.com/repos/SteamRE/SteamKit/forks","keys_url":"https://api.github.com/repos/SteamRE/SteamKit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SteamRE/SteamKit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SteamRE/SteamKit/teams","hooks_url":"https://api.github.com/repos/SteamRE/SteamKit/hooks","issue_events_url":"https://api.github.com/repos/SteamRE/SteamKit/issues/events{/number}","events_url":"https://api.github.com/repos/SteamRE/SteamKit/events","assignees_url":"https://api.github.com/repos/SteamRE/SteamKit/assignees{/user}","branches_url":"https://api.github.com/repos/SteamRE/SteamKit/branches{/branch}","tags_url":"https://api.github.com/repos/SteamRE/SteamKit/tags","blobs_url":"https://api.github.com/repos/SteamRE/SteamKit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SteamRE/SteamKit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SteamRE/SteamKit/git/refs{/sha}","trees_url":"https://api.github.com/repos/SteamRE/SteamKit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SteamRE/SteamKit/statuses/{sha}","languages_url":"https://api.github.com/repos/SteamRE/SteamKit/languages","stargazers_url":"https://api.github.com/repos/SteamRE/SteamKit/stargazers","contributors_url":"https://api.github.com/repos/SteamRE/SteamKit/contributors","subscribers_url":"https://api.github.com/repos/SteamRE/SteamKit/subscribers","subscription_url":"https://api.github.com/repos/SteamRE/SteamKit/subscription","commits_url":"https://api.github.com/repos/SteamRE/SteamKit/commits{/sha}","git_commits_url":"https://api.github.com/repos/SteamRE/SteamKit/git/commits{/sha}","comments_url":"https://api.github.com/repos/SteamRE/SteamKit/comments{/number}","issue_comment_url":"https://api.github.com/repos/SteamRE/SteamKit/issues/comments{/number}","contents_url":"https://api.github.com/repos/SteamRE/SteamKit/contents/{+path}","compare_url":"https://api.github.com/repos/SteamRE/SteamKit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SteamRE/SteamKit/merges","archive_url":"https://api.github.com/repos/SteamRE/SteamKit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SteamRE/SteamKit/downloads","issues_url":"https://api.github.com/repos/SteamRE/SteamKit/issues{/number}","pulls_url":"https://api.github.com/repos/SteamRE/SteamKit/pulls{/number}","milestones_url":"https://api.github.com/repos/SteamRE/SteamKit/milestones{/number}","notifications_url":"https://api.github.com/repos/SteamRE/SteamKit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SteamRE/SteamKit/labels{/name}","releases_url":"https://api.github.com/repos/SteamRE/SteamKit/releases{/id}","deployments_url":"https://api.github.com/repos/SteamRE/SteamKit/deployments","created_at":"2013-05-30T05:51:34Z","updated_at":"2016-06-24T10:27:09Z","pushed_at":"2016-06-24T19:47:30Z","git_url":"git://github.com/SteamRE/SteamKit.git","ssh_url":"git@github.com:SteamRE/SteamKit.git","clone_url":"https://github.com/SteamRE/SteamKit.git","svn_url":"https://github.com/SteamRE/SteamKit","homepage":null,"size":58036,"stargazers_count":765,"watchers_count":765,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":220,"mirror_url":null,"open_issues_count":38,"forks":220,"open_issues":38,"watchers":765,"default_branch":"master"}},"base":{"label":"SteamRE:master","ref":"master","sha":"05ea8b2ba9d6f635041a939aee1bb58a908627e8","user":{"login":"SteamRE","id":4567126,"avatar_url":"https://avatars.githubusercontent.com/u/4567126?v=3","gravatar_id":"","url":"https://api.github.com/users/SteamRE","html_url":"https://github.com/SteamRE","followers_url":"https://api.github.com/users/SteamRE/followers","following_url":"https://api.github.com/users/SteamRE/following{/other_user}","gists_url":"https://api.github.com/users/SteamRE/gists{/gist_id}","starred_url":"https://api.github.com/users/SteamRE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SteamRE/subscriptions","organizations_url":"https://api.github.com/users/SteamRE/orgs","repos_url":"https://api.github.com/users/SteamRE/repos","events_url":"https://api.github.com/users/SteamRE/events{/privacy}","received_events_url":"https://api.github.com/users/SteamRE/received_events","type":"Organization","site_admin":false},"repo":{"id":10376425,"name":"SteamKit","full_name":"SteamRE/SteamKit","owner":{"login":"SteamRE","id":4567126,"avatar_url":"https://avatars.githubusercontent.com/u/4567126?v=3","gravatar_id":"","url":"https://api.github.com/users/SteamRE","html_url":"https://github.com/SteamRE","followers_url":"https://api.github.com/users/SteamRE/followers","following_url":"https://api.github.com/users/SteamRE/following{/other_user}","gists_url":"https://api.github.com/users/SteamRE/gists{/gist_id}","starred_url":"https://api.github.com/users/SteamRE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SteamRE/subscriptions","organizations_url":"https://api.github.com/users/SteamRE/orgs","repos_url":"https://api.github.com/users/SteamRE/repos","events_url":"https://api.github.com/users/SteamRE/events{/privacy}","received_events_url":"https://api.github.com/users/SteamRE/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SteamRE/SteamKit","description":"SteamKit2 is a .NET library designed to interoperate with Valve's Steam network. It aims to provide a simple, yet extensible, interface to perform various actions on the network.","fork":false,"url":"https://api.github.com/repos/SteamRE/SteamKit","forks_url":"https://api.github.com/repos/SteamRE/SteamKit/forks","keys_url":"https://api.github.com/repos/SteamRE/SteamKit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SteamRE/SteamKit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SteamRE/SteamKit/teams","hooks_url":"https://api.github.com/repos/SteamRE/SteamKit/hooks","issue_events_url":"https://api.github.com/repos/SteamRE/SteamKit/issues/events{/number}","events_url":"https://api.github.com/repos/SteamRE/SteamKit/events","assignees_url":"https://api.github.com/repos/SteamRE/SteamKit/assignees{/user}","branches_url":"https://api.github.com/repos/SteamRE/SteamKit/branches{/branch}","tags_url":"https://api.github.com/repos/SteamRE/SteamKit/tags","blobs_url":"https://api.github.com/repos/SteamRE/SteamKit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SteamRE/SteamKit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SteamRE/SteamKit/git/refs{/sha}","trees_url":"https://api.github.com/repos/SteamRE/SteamKit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SteamRE/SteamKit/statuses/{sha}","languages_url":"https://api.github.com/repos/SteamRE/SteamKit/languages","stargazers_url":"https://api.github.com/repos/SteamRE/SteamKit/stargazers","contributors_url":"https://api.github.com/repos/SteamRE/SteamKit/contributors","subscribers_url":"https://api.github.com/repos/SteamRE/SteamKit/subscribers","subscription_url":"https://api.github.com/repos/SteamRE/SteamKit/subscription","commits_url":"https://api.github.com/repos/SteamRE/SteamKit/commits{/sha}","git_commits_url":"https://api.github.com/repos/SteamRE/SteamKit/git/commits{/sha}","comments_url":"https://api.github.com/repos/SteamRE/SteamKit/comments{/number}","issue_comment_url":"https://api.github.com/repos/SteamRE/SteamKit/issues/comments{/number}","contents_url":"https://api.github.com/repos/SteamRE/SteamKit/contents/{+path}","compare_url":"https://api.github.com/repos/SteamRE/SteamKit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SteamRE/SteamKit/merges","archive_url":"https://api.github.com/repos/SteamRE/SteamKit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SteamRE/SteamKit/downloads","issues_url":"https://api.github.com/repos/SteamRE/SteamKit/issues{/number}","pulls_url":"https://api.github.com/repos/SteamRE/SteamKit/pulls{/number}","milestones_url":"https://api.github.com/repos/SteamRE/SteamKit/milestones{/number}","notifications_url":"https://api.github.com/repos/SteamRE/SteamKit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SteamRE/SteamKit/labels{/name}","releases_url":"https://api.github.com/repos/SteamRE/SteamKit/releases{/id}","deployments_url":"https://api.github.com/repos/SteamRE/SteamKit/deployments","created_at":"2013-05-30T05:51:34Z","updated_at":"2016-06-24T10:27:09Z","pushed_at":"2016-06-24T19:47:30Z","git_url":"git://github.com/SteamRE/SteamKit.git","ssh_url":"git@github.com:SteamRE/SteamKit.git","clone_url":"https://github.com/SteamRE/SteamKit.git","svn_url":"https://github.com/SteamRE/SteamKit","homepage":null,"size":58036,"stargazers_count":765,"watchers_count":765,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":220,"mirror_url":null,"open_issues_count":38,"forks":220,"open_issues":38,"watchers":765,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SteamRE/SteamKit/pulls/293"},"html":{"href":"https://github.com/SteamRE/SteamKit/pull/293"},"issue":{"href":"https://api.github.com/repos/SteamRE/SteamKit/issues/293"},"comments":{"href":"https://api.github.com/repos/SteamRE/SteamKit/issues/293/comments"},"review_comments":{"href":"https://api.github.com/repos/SteamRE/SteamKit/pulls/293/comments"},"review_comment":{"href":"https://api.github.com/repos/SteamRE/SteamKit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SteamRE/SteamKit/pulls/293/commits"},"statuses":{"href":"https://api.github.com/repos/SteamRE/SteamKit/statuses/139945da7758cb1223b6184f42ac98728834f393"}}}}
{"actor":{"display_login":"Netshroud"}}