{"action":"closed","number":38,"pull_request":{"url":"https://api.github.com/repos/themasch/node-bencode/pulls/38","id":59891727,"html_url":"https://github.com/themasch/node-bencode/pull/38","diff_url":"https://github.com/themasch/node-bencode/pull/38.diff","patch_url":"https://github.com/themasch/node-bencode/pull/38.patch","issue_url":"https://api.github.com/repos/themasch/node-bencode/issues/38","number":38,"state":"closed","locked":false,"title":"Handle boolean case","user":{"login":"kaelar","id":5303483,"avatar_url":"https://avatars.githubusercontent.com/u/5303483?v=3","gravatar_id":"","url":"https://api.github.com/users/kaelar","html_url":"https://github.com/kaelar","followers_url":"https://api.github.com/users/kaelar/followers","following_url":"https://api.github.com/users/kaelar/following{/other_user}","gists_url":"https://api.github.com/users/kaelar/gists{/gist_id}","starred_url":"https://api.github.com/users/kaelar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaelar/subscriptions","organizations_url":"https://api.github.com/users/kaelar/orgs","repos_url":"https://api.github.com/users/kaelar/repos","events_url":"https://api.github.com/users/kaelar/events{/privacy}","received_events_url":"https://api.github.com/users/kaelar/received_events","type":"User","site_admin":false},"body":"@jhermsmeier @themasch \r\n\r\nConvert boolean values to 0/1. \r\n\r\nI wasn't sure if this was \"proper\" behavior and something that should be included since booleans are not really supported. It helped in my case since I didn't want to have to convert all boolean values before sending the bencode message. I think at the very least there should be some error handling for this case.","created_at":"2016-02-19T01:24:49Z","updated_at":"2016-03-23T23:56:46Z","closed_at":"2016-03-23T23:56:46Z","merged_at":"2016-03-23T23:56:46Z","merge_commit_sha":"a948a14fef775bfc94a06c8dee95f29e9c89d0c4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/themasch/node-bencode/pulls/38/commits","review_comments_url":"https://api.github.com/repos/themasch/node-bencode/pulls/38/comments","review_comment_url":"https://api.github.com/repos/themasch/node-bencode/pulls/comments{/number}","comments_url":"https://api.github.com/repos/themasch/node-bencode/issues/38/comments","statuses_url":"https://api.github.com/repos/themasch/node-bencode/statuses/f3f75a3ab66ae68e9311a5027c836a5fd71d8985","head":{"label":"bittorrent:master","ref":"master","sha":"f3f75a3ab66ae68e9311a5027c836a5fd71d8985","user":{"login":"bittorrent","id":142253,"avatar_url":"https://avatars.githubusercontent.com/u/142253?v=3","gravatar_id":"","url":"https://api.github.com/users/bittorrent","html_url":"https://github.com/bittorrent","followers_url":"https://api.github.com/users/bittorrent/followers","following_url":"https://api.github.com/users/bittorrent/following{/other_user}","gists_url":"https://api.github.com/users/bittorrent/gists{/gist_id}","starred_url":"https://api.github.com/users/bittorrent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bittorrent/subscriptions","organizations_url":"https://api.github.com/users/bittorrent/orgs","repos_url":"https://api.github.com/users/bittorrent/repos","events_url":"https://api.github.com/users/bittorrent/events{/privacy}","received_events_url":"https://api.github.com/users/bittorrent/received_events","type":"Organization","site_admin":false},"repo":{"id":49265393,"name":"node-bencode","full_name":"bittorrent/node-bencode","owner":{"login":"bittorrent","id":142253,"avatar_url":"https://avatars.githubusercontent.com/u/142253?v=3","gravatar_id":"","url":"https://api.github.com/users/bittorrent","html_url":"https://github.com/bittorrent","followers_url":"https://api.github.com/users/bittorrent/followers","following_url":"https://api.github.com/users/bittorrent/following{/other_user}","gists_url":"https://api.github.com/users/bittorrent/gists{/gist_id}","starred_url":"https://api.github.com/users/bittorrent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bittorrent/subscriptions","organizations_url":"https://api.github.com/users/bittorrent/orgs","repos_url":"https://api.github.com/users/bittorrent/repos","events_url":"https://api.github.com/users/bittorrent/events{/privacy}","received_events_url":"https://api.github.com/users/bittorrent/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bittorrent/node-bencode","description":"bencode de/encoder for nodejs","fork":true,"url":"https://api.github.com/repos/bittorrent/node-bencode","forks_url":"https://api.github.com/repos/bittorrent/node-bencode/forks","keys_url":"https://api.github.com/repos/bittorrent/node-bencode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bittorrent/node-bencode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bittorrent/node-bencode/teams","hooks_url":"https://api.github.com/repos/bittorrent/node-bencode/hooks","issue_events_url":"https://api.github.com/repos/bittorrent/node-bencode/issues/events{/number}","events_url":"https://api.github.com/repos/bittorrent/node-bencode/events","assignees_url":"https://api.github.com/repos/bittorrent/node-bencode/assignees{/user}","branches_url":"https://api.github.com/repos/bittorrent/node-bencode/branches{/branch}","tags_url":"https://api.github.com/repos/bittorrent/node-bencode/tags","blobs_url":"https://api.github.com/repos/bittorrent/node-bencode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bittorrent/node-bencode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bittorrent/node-bencode/git/refs{/sha}","trees_url":"https://api.github.com/repos/bittorrent/node-bencode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bittorrent/node-bencode/statuses/{sha}","languages_url":"https://api.github.com/repos/bittorrent/node-bencode/languages","stargazers_url":"https://api.github.com/repos/bittorrent/node-bencode/stargazers","contributors_url":"https://api.github.com/repos/bittorrent/node-bencode/contributors","subscribers_url":"https://api.github.com/repos/bittorrent/node-bencode/subscribers","subscription_url":"https://api.github.com/repos/bittorrent/node-bencode/subscription","commits_url":"https://api.github.com/repos/bittorrent/node-bencode/commits{/sha}","git_commits_url":"https://api.github.com/repos/bittorrent/node-bencode/git/commits{/sha}","comments_url":"https://api.github.com/repos/bittorrent/node-bencode/comments{/number}","issue_comment_url":"https://api.github.com/repos/bittorrent/node-bencode/issues/comments{/number}","contents_url":"https://api.github.com/repos/bittorrent/node-bencode/contents/{+path}","compare_url":"https://api.github.com/repos/bittorrent/node-bencode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bittorrent/node-bencode/merges","archive_url":"https://api.github.com/repos/bittorrent/node-bencode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bittorrent/node-bencode/downloads","issues_url":"https://api.github.com/repos/bittorrent/node-bencode/issues{/number}","pulls_url":"https://api.github.com/repos/bittorrent/node-bencode/pulls{/number}","milestones_url":"https://api.github.com/repos/bittorrent/node-bencode/milestones{/number}","notifications_url":"https://api.github.com/repos/bittorrent/node-bencode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bittorrent/node-bencode/labels{/name}","releases_url":"https://api.github.com/repos/bittorrent/node-bencode/releases{/id}","deployments_url":"https://api.github.com/repos/bittorrent/node-bencode/deployments","created_at":"2016-01-08T10:16:30Z","updated_at":"2016-01-08T10:16:31Z","pushed_at":"2016-01-08T11:00:11Z","git_url":"git://github.com/bittorrent/node-bencode.git","ssh_url":"git@github.com:bittorrent/node-bencode.git","clone_url":"https://github.com/bittorrent/node-bencode.git","svn_url":"https://github.com/bittorrent/node-bencode","homepage":"","size":113,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"themasch:master","ref":"master","sha":"05e95ac92856150d1c7fb28f615af42b3e19d51a","user":{"login":"themasch","id":170171,"avatar_url":"https://avatars.githubusercontent.com/u/170171?v=3","gravatar_id":"","url":"https://api.github.com/users/themasch","html_url":"https://github.com/themasch","followers_url":"https://api.github.com/users/themasch/followers","following_url":"https://api.github.com/users/themasch/following{/other_user}","gists_url":"https://api.github.com/users/themasch/gists{/gist_id}","starred_url":"https://api.github.com/users/themasch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/themasch/subscriptions","organizations_url":"https://api.github.com/users/themasch/orgs","repos_url":"https://api.github.com/users/themasch/repos","events_url":"https://api.github.com/users/themasch/events{/privacy}","received_events_url":"https://api.github.com/users/themasch/received_events","type":"User","site_admin":false},"repo":{"id":775875,"name":"node-bencode","full_name":"themasch/node-bencode","owner":{"login":"themasch","id":170171,"avatar_url":"https://avatars.githubusercontent.com/u/170171?v=3","gravatar_id":"","url":"https://api.github.com/users/themasch","html_url":"https://github.com/themasch","followers_url":"https://api.github.com/users/themasch/followers","following_url":"https://api.github.com/users/themasch/following{/other_user}","gists_url":"https://api.github.com/users/themasch/gists{/gist_id}","starred_url":"https://api.github.com/users/themasch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/themasch/subscriptions","organizations_url":"https://api.github.com/users/themasch/orgs","repos_url":"https://api.github.com/users/themasch/repos","events_url":"https://api.github.com/users/themasch/events{/privacy}","received_events_url":"https://api.github.com/users/themasch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/themasch/node-bencode","description":"bencode de/encoder for nodejs","fork":false,"url":"https://api.github.com/repos/themasch/node-bencode","forks_url":"https://api.github.com/repos/themasch/node-bencode/forks","keys_url":"https://api.github.com/repos/themasch/node-bencode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/themasch/node-bencode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/themasch/node-bencode/teams","hooks_url":"https://api.github.com/repos/themasch/node-bencode/hooks","issue_events_url":"https://api.github.com/repos/themasch/node-bencode/issues/events{/number}","events_url":"https://api.github.com/repos/themasch/node-bencode/events","assignees_url":"https://api.github.com/repos/themasch/node-bencode/assignees{/user}","branches_url":"https://api.github.com/repos/themasch/node-bencode/branches{/branch}","tags_url":"https://api.github.com/repos/themasch/node-bencode/tags","blobs_url":"https://api.github.com/repos/themasch/node-bencode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/themasch/node-bencode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/themasch/node-bencode/git/refs{/sha}","trees_url":"https://api.github.com/repos/themasch/node-bencode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/themasch/node-bencode/statuses/{sha}","languages_url":"https://api.github.com/repos/themasch/node-bencode/languages","stargazers_url":"https://api.github.com/repos/themasch/node-bencode/stargazers","contributors_url":"https://api.github.com/repos/themasch/node-bencode/contributors","subscribers_url":"https://api.github.com/repos/themasch/node-bencode/subscribers","subscription_url":"https://api.github.com/repos/themasch/node-bencode/subscription","commits_url":"https://api.github.com/repos/themasch/node-bencode/commits{/sha}","git_commits_url":"https://api.github.com/repos/themasch/node-bencode/git/commits{/sha}","comments_url":"https://api.github.com/repos/themasch/node-bencode/comments{/number}","issue_comment_url":"https://api.github.com/repos/themasch/node-bencode/issues/comments{/number}","contents_url":"https://api.github.com/repos/themasch/node-bencode/contents/{+path}","compare_url":"https://api.github.com/repos/themasch/node-bencode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/themasch/node-bencode/merges","archive_url":"https://api.github.com/repos/themasch/node-bencode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/themasch/node-bencode/downloads","issues_url":"https://api.github.com/repos/themasch/node-bencode/issues{/number}","pulls_url":"https://api.github.com/repos/themasch/node-bencode/pulls{/number}","milestones_url":"https://api.github.com/repos/themasch/node-bencode/milestones{/number}","notifications_url":"https://api.github.com/repos/themasch/node-bencode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/themasch/node-bencode/labels{/name}","releases_url":"https://api.github.com/repos/themasch/node-bencode/releases{/id}","deployments_url":"https://api.github.com/repos/themasch/node-bencode/deployments","created_at":"2010-07-15T02:25:04Z","updated_at":"2016-03-14T15:19:43Z","pushed_at":"2016-03-23T23:56:46Z","git_url":"git://github.com/themasch/node-bencode.git","ssh_url":"git@github.com:themasch/node-bencode.git","clone_url":"https://github.com/themasch/node-bencode.git","svn_url":"https://github.com/themasch/node-bencode","homepage":"","size":212,"stargazers_count":48,"watchers_count":48,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":5,"forks":11,"open_issues":5,"watchers":48,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/themasch/node-bencode/pulls/38"},"html":{"href":"https://github.com/themasch/node-bencode/pull/38"},"issue":{"href":"https://api.github.com/repos/themasch/node-bencode/issues/38"},"comments":{"href":"https://api.github.com/repos/themasch/node-bencode/issues/38/comments"},"review_comments":{"href":"https://api.github.com/repos/themasch/node-bencode/pulls/38/comments"},"review_comment":{"href":"https://api.github.com/repos/themasch/node-bencode/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/themasch/node-bencode/pulls/38/commits"},"statuses":{"href":"https://api.github.com/repos/themasch/node-bencode/statuses/f3f75a3ab66ae68e9311a5027c836a5fd71d8985"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"jhermsmeier","id":244907,"avatar_url":"https://avatars.githubusercontent.com/u/244907?v=3","gravatar_id":"","url":"https://api.github.com/users/jhermsmeier","html_url":"https://github.com/jhermsmeier","followers_url":"https://api.github.com/users/jhermsmeier/followers","following_url":"https://api.github.com/users/jhermsmeier/following{/other_user}","gists_url":"https://api.github.com/users/jhermsmeier/gists{/gist_id}","starred_url":"https://api.github.com/users/jhermsmeier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhermsmeier/subscriptions","organizations_url":"https://api.github.com/users/jhermsmeier/orgs","repos_url":"https://api.github.com/users/jhermsmeier/repos","events_url":"https://api.github.com/users/jhermsmeier/events{/privacy}","received_events_url":"https://api.github.com/users/jhermsmeier/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"commits":1,"additions":3,"deletions":0,"changed_files":1}}