{"push_id":1118582924,"size":1000,"distinct_size":1231,"ref":"refs/heads/master","head":"ebbe4f8db76b947663cc535602054c84b01b080d","before":"2a7c446f987494228dc96d96272737568e01cddc","commits":[{"sha":"44d3f89e99b954d88ab802212182a7c123ac774a","author":{"email":"a2f0bf29257797dd66800b4fbb9945c3e216c004@golang.org","name":"David Crawshaw"},"message":"cmd/link, reflect: remove some method type data\n\nRemove reflect type information for unexported methods that do not\nsatisfy any interface in the program.\n\nIdeally the unexported method would not appear in the method list at\nall, but that is tricky because the slice is built by the compiler.\n\nReduces binary size:\n\n\tcmd/go: 81KB (0.8%)\n\tjujud: 258KB (0.4%)\n\nFor #6853.\n\nChange-Id: I25ef8df6907e9ac03b18689d584ea46e7d773043\nReviewed-on: https://go-review.googlesource.com/21033\nReviewed-by: Ian Lance Taylor <iant@golang.org>\nReviewed-by: Russ Cox <rsc@golang.org>\nRun-TryBot: David Crawshaw <crawshaw@golang.org>\nTryBot-Result: Gobot Gobot <gobot@golang.org>","distinct":true,"url":"https://api.github.com/repos/salewski/go/commits/44d3f89e99b954d88ab802212182a7c123ac774a"},{"sha":"4c9a470d468b6b6fa0520f32e034a1762dba3f9d","author":{"email":"8c99c3a9284e493be632950b84cd789d08ed3e9d@golang.org","name":"Keith Randall"},"message":"cmd/compile: start on ARM port\n\nStart working on arm port.  Gets close to correct\ncode for fibonacci:\n    func fib(n int) int {\n        if n < 2 {\n            return n\n        }\n        return fib(n-1) + fib(n-2)\n    }\n\nStill a lot to do, but this is a good starting point.\n\nCleaned up some arch-specific dependencies in regalloc.\n\nChange-Id: I4301c6c31a8402168e50dcfee8bcf7aee73ea9d5\nReviewed-on: https://go-review.googlesource.com/21000\nReviewed-by: David Chase <drchase@google.com>","distinct":true,"url":"https://api.github.com/repos/salewski/go/commits/4c9a470d468b6b6fa0520f32e034a1762dba3f9d"},{"sha":"0659cf691194f30345442d66c94eba632ca6d7ae","author":{"email":"e56ac2c500064424afac424d4b5e53bd0570a731@google.com","name":"Matthew Dempsky"},"message":"cmd/compile: small Mpint method simplifications\n\nGet rid of (*Mpint).Add's \"quiet\" parameter: it's always set to 0.\n\nInline (*Mpint).shift into (*Mpint).Lsh and (*Mpint).Rsh. There's no\nneed for a common shift method that can handle both left or right\nshifts based on sign when the higher level abstractions only ever do\none or the other.\n\nChange-Id: Icd3b082413f9193961b6835279e0bd4b6a6a6621\nReviewed-on: https://go-review.googlesource.com/21050\nRun-TryBot: Matthew Dempsky <mdempsky@google.com>\nTryBot-Result: Gobot Gobot <gobot@golang.org>\nReviewed-by: Robert Griesemer <gri@golang.org>","distinct":true,"url":"https://api.github.com/repos/salewski/go/commits/0659cf691194f30345442d66c94eba632ca6d7ae"},{"sha":"ca5417b8e0c859aa5537247aed03316bfd3f5a66","author":{"email":"ae9783c0b0efc69cd85ab025ddd17aa44cdc4aa5@golang.org","name":"Brad Fitzpatrick"},"message":"cmd/compile: reduce some SSA garbage\n\nIt's pretty hard to get reliable CPU numbers, even with 50 runs on an\notherwise-idle physical Linux machine, but the garbage reduction\nnumbers are nice. To get useful time/op numbers, I modified\ncompilebench to report user CPU time instead of wall time:\n\nname       old time/op     new time/op     delta\nTemplate       547ms ± 6%      557ms ± 5%   +1.80%        (p=0.001 n=49+49)\nUnicode        360ms ± 9%      365ms ± 6%     ~           (p=0.094 n=50+45)\nGoTypes        1.84s ± 3%      1.82s ± 3%   -1.50%        (p=0.000 n=50+49)\nCompiler       9.19s ± 2%      9.02s ± 2%   -1.87%        (p=0.000 n=45+50)\n\nname       old alloc/op    new alloc/op    delta\nTemplate      63.3MB ± 0%     59.1MB ± 0%   -6.72%        (p=0.000 n=50+50)\nUnicode       43.1MB ± 0%     42.9MB ± 0%   -0.47%        (p=0.000 n=50+49)\nGoTypes        220MB ± 0%      200MB ± 0%   -9.00%        (p=0.000 n=50+50)\nCompiler      1.00GB ± 0%     0.89GB ± 0%  -10.09%        (p=0.000 n=50+49)\n\nname       old allocs/op   new allocs/op   delta\nTemplate        681k ± 0%       680k ± 0%   -0.16%        (p=0.000 n=50+48)\nUnicode         541k ± 0%       541k ± 0%   -0.02%        (p=0.011 n=48+50)\nGoTypes        2.08M ± 0%      2.08M ± 0%   -0.19%        (p=0.000 n=48+50)\nCompiler       9.24M ± 0%      9.23M ± 0%   -0.11%        (p=0.000 n=50+50)\n\nChange-Id: I1fac4ebf85a1783e3289c3ffb1ed365442837643\nReviewed-on: https://go-review.googlesource.com/20995\nRun-TryBot: Brad Fitzpatrick <bradfitz@golang.org>\nTryBot-Result: Gobot Gobot <gobot@golang.org>\nReviewed-by: Dave Cheney <dave@cheney.net>\nReviewed-by: Keith Randall <khr@golang.org>","distinct":true,"url":"https://api.github.com/repos/salewski/go/commits/ca5417b8e0c859aa5537247aed03316bfd3f5a66"},{"sha":"bd83cc6dae36399f3c8fd99bd4ceea6570c70f5a","author":{"email":"bde3f4ccdd7c08fc2bda30f654959132eeced9b3@gmail.com","name":"Marvin Stenger"},"message":"cmd/compile: prettify loop iterations\n\nThis commit replaces some of\n\nfor i := len(x) - 1; i >= 0; i-- {...}\n\nstyle loops, which do not rely on reverse iteration order.\n\nChange-Id: I5542834286562da058200c06e7a173b13760e54d\nReviewed-on: https://go-review.googlesource.com/21044\nReviewed-by: Keith Randall <khr@golang.org>","distinct":true,"url":"https://api.github.com/repos/salewski/go/commits/bd83cc6dae36399f3c8fd99bd4ceea6570c70f5a"},{"sha":"694eadcce755e9d8b02a9fed8b79448cc8bbcd5c","author":{"email":"ae9783c0b0efc69cd85ab025ddd17aa44cdc4aa5@golang.org","name":"Brad Fitzpatrick"},"message":"net/http/httptest: add NewRequest helper for ease of testing handlers\n\nFixes #14199\n\nChange-Id: Ic9284023b663de3db1ca7b7b1e96eeab82ec0944\nReviewed-on: https://go-review.googlesource.com/21016\nRun-TryBot: Brad Fitzpatrick <bradfitz@golang.org>\nReviewed-by: Andrew Gerrand <adg@golang.org>","distinct":true,"url":"https://api.github.com/repos/salewski/go/commits/694eadcce755e9d8b02a9fed8b79448cc8bbcd5c"},{"sha":"7e8e9abe0a9ef49dfcba0ec5e18232327d581fe9","author":{"email":"cdc248cc4d32e4fbfe04e45228163bcecd48a0b9@gmail.com","name":"Josh Bleecher Snyder"},"message":"cmd/compile: reduce stutter\n\nThis is follow-up 1 of 3 to CL 20959.\n\nPasses toolstash -cmp.\n\nChange-Id: I9bddf7d88333fa4755e03ff8a034a35bd01b7855\nReviewed-on: https://go-review.googlesource.com/21052\nRun-TryBot: Josh Bleecher Snyder <josharian@gmail.com>\nReviewed-by: Brad Fitzpatrick <bradfitz@golang.org>\nTryBot-Result: Gobot Gobot <gobot@golang.org>","distinct":true,"url":"https://api.github.com/repos/salewski/go/commits/7e8e9abe0a9ef49dfcba0ec5e18232327d581fe9"},{"sha":"babc73547eed0fb75f4b507e02bd8235acdbc8e9","author":{"email":"cdc248cc4d32e4fbfe04e45228163bcecd48a0b9@gmail.com","name":"Josh Bleecher Snyder"},"message":"cmd/compile: remove redundant parameter from finishcompare\n\nThis is follow-up 3 of 3 to CL 20959.\n\nPasses toolstash -cmp.\n\nChange-Id: I06efded21bbc970cbefa10e8f2cac1ebc6942e1b\nReviewed-on: https://go-review.googlesource.com/21054\nRun-TryBot: Josh Bleecher Snyder <josharian@gmail.com>\nReviewed-by: Brad Fitzpatrick <bradfitz@golang.org>\nTryBot-Result: Gobot Gobot <gobot@golang.org>","distinct":true,"url":"https://api.github.com/repos/salewski/go/commits/babc73547eed0fb75f4b507e02bd8235acdbc8e9"},{"sha":"edca4cda8858c6af5a9236d81b8654cb294054c8","author":{"email":"bfcdf3e6ca6cef45543bfbb57509c92aec9a39fb@cheney.net","name":"Dave Cheney"},"message":"cmd/compile/internal/gc: remove remaining Nod(OXXX, ...)\n\nRemove almost all the remaining Nod(OXXX, ... ) uses. The performance\nchange is due entirely to the changes to func temp(*Type). The other\ncleanups have no effect, as expected.\n\nI'll address the remaining Nod(OXXX, ...) uses in a followup CL as they\nare very sensitive to change.\n\nlucky(~/go/src/cmd/compile) % benchstat /tmp/{old,new}.txt\nname      old time/op    new time/op    delta\nTemplate     391ms ± 6%     385ms ± 6%    ~     (p=0.127 n=19+20)\nGoTypes      1.27s ± 2%     1.27s ± 2%    ~     (p=0.172 n=19+19)\nCompiler     6.17s ± 2%     6.15s ± 2%    ~     (p=0.647 n=19+20)\n\nname      old alloc/op   new alloc/op   delta\nTemplate    63.7MB ± 0%    63.4MB ± 0%  -0.35%  (p=0.000 n=16+20)\nGoTypes      219MB ± 0%     218MB ± 0%  -0.38%  (p=0.000 n=20+20)\nCompiler     980MB ± 0%     976MB ± 0%  -0.38%  (p=0.000 n=20+20)\n\nname      old allocs/op  new allocs/op  delta\nTemplate      586k ± 0%      584k ± 0%  -0.30%  (p=0.000 n=20+20)\nGoTypes      1.80M ± 0%     1.79M ± 0%  -0.31%  (p=0.000 n=20+20)\nCompiler     7.74M ± 0%     7.71M ± 0%  -0.34%  (p=0.000 n=20+20)\n\nChange-Id: Ie21a5443c33a23ce30f987bdddec9fe350365d35\nReviewed-on: https://go-review.googlesource.com/21017\nReviewed-by: Ian Lance Taylor <iant@golang.org>\nReviewed-by: Brad Fitzpatrick <bradfitz@golang.org>\nRun-TryBot: Brad Fitzpatrick <bradfitz@golang.org>\nTryBot-Result: Gobot Gobot <gobot@golang.org>","distinct":true,"url":"https://api.github.com/repos/salewski/go/commits/edca4cda8858c6af5a9236d81b8654cb294054c8"},{"sha":"ddcf8d402a0f8b7556dad49005ff578244baa11c","author":{"email":"a9b249127ecbd1cdf6c8d203151427a50053d4f3@sdf.org","name":"Mohit Agarwal"},"message":"net/http: redirect if the URL path is a dir & doesn't end in a slash\n\nFixes #13996\n\nChange-Id: I9b2c7fba0705900aca9a70bc6a2687667a9a976c\nReviewed-on: https://go-review.googlesource.com/20128\nReviewed-by: Brad Fitzpatrick <bradfitz@golang.org>\nRun-TryBot: Brad Fitzpatrick <bradfitz@golang.org>\nTryBot-Result: Gobot Gobot <gobot@golang.org>","distinct":true,"url":"https://api.github.com/repos/salewski/go/commits/ddcf8d402a0f8b7556dad49005ff578244baa11c"},{"sha":"ebd67ba588eabd5bf968b5bd14dff21a1a1b1be4","author":{"email":"9b1c42e567326d02f223843097d918a102bd7788@gmail.com","name":"Yasuhiro Matsumoto"},"message":"os: fix Stdin.Stat() on windows\n\nIf name is /dev/{stdin,stdout,stderr}, return fileInfo.\n\nFixes #14853.\n\nChange-Id: Ibf7d1ae7b9f3dc43f6ed7c905ea2c5102e1971cc\nReviewed-on: https://go-review.googlesource.com/20845\nReviewed-by: Alex Brainman <alex.brainman@gmail.com>","distinct":true,"url":"https://api.github.com/repos/salewski/go/commits/ebd67ba588eabd5bf968b5bd14dff21a1a1b1be4"},{"sha":"633e41432c7c617809ddb22c0c3f2fc214a26b99","author":{"email":"53e9ab6728e383d7a27aa729bcad54874ffefc1c@gmail.com","name":"Tilman Dilo"},"message":"image/png: ignore trailing IDAT chunks\n\nIgnore superfluous trailing IDAT chunks which were not consumed when decoding\nthe image. This change fixes decoding of valid images in which a zero-length\nIDAT chunk appears after the actual image data. It also prevents decoding of\ntrailing garbage IDAT chunks or maliciously embedded additional images.\n\nFixes #14936\n\nChange-Id: I8c76cfa9a03496d9576f72bed2db109271f97c5e\nReviewed-on: https://go-review.googlesource.com/21045\nReviewed-by: Nigel Tao <nigeltao@golang.org>","distinct":true,"url":"https://api.github.com/repos/salewski/go/commits/633e41432c7c617809ddb22c0c3f2fc214a26b99"},{"sha":"b9feb91f32919e44c89205990314c9a6d3a9b2d1","author":{"email":"bfcdf3e6ca6cef45543bfbb57509c92aec9a39fb@cheney.net","name":"Dave Cheney"},"message":"cmd/compile: minor cleanups\n\nSome minor scoping cleanups found by a very old version of grind.\n\nChange-Id: I1d373817586445fc87e38305929097b652696fdd\nReviewed-on: https://go-review.googlesource.com/21064\nRun-TryBot: Dave Cheney <dave@cheney.net>\nTryBot-Result: Gobot Gobot <gobot@golang.org>\nReviewed-by: Brad Fitzpatrick <bradfitz@golang.org>","distinct":true,"url":"https://api.github.com/repos/salewski/go/commits/b9feb91f32919e44c89205990314c9a6d3a9b2d1"},{"sha":"be10c515003c22b8b4f0d98d1085687efbcf6955","author":{"email":"993af7099cb24ce1a88d64108ae1e8b0385f2fc0@gmail.com","name":"Elias Naur"},"message":"runtime/cgo: block signals to the iOS mach exception handler\n\nFor darwin/arm{,64} a non-Go thread is created to convert\nEXC_BAD_ACCESS to panics. However, the Go signal handler refuse to\nhandle signals that would otherwise be ignored if they arrive at\nnon-Go threads.\n\nBlock all (posix) signals to that thread, making sure that\nno unexpected signals arrive to it. At least one test, TestStop in\nos/signal, depends on signals not arriving on any non-Go threads.\n\nFor #14318\n\nChange-Id: I901467fb53bdadb0d03b0f1a537116c7f4754423\nReviewed-on: https://go-review.googlesource.com/21047\nReviewed-by: David Crawshaw <crawshaw@golang.org>","distinct":true,"url":"https://api.github.com/repos/salewski/go/commits/be10c515003c22b8b4f0d98d1085687efbcf6955"},{"sha":"5f08e480f447a7f197f41686bf672d39b10c3518","author":{"email":"993af7099cb24ce1a88d64108ae1e8b0385f2fc0@gmail.com","name":"Elias Naur"},"message":"misc/ios: pass through SIGCONT in the exec wrapper\n\nInstruct lldb to pass through SIGCONT unhindered when running iOS\ntests. Fixes the TestSIGCONT test in os/signal.\n\nFor #14318\n\nChange-Id: I669264208cc3d6ecae9fbc8790e0b753a93a5e04\nReviewed-on: https://go-review.googlesource.com/21071\nReviewed-by: David Crawshaw <crawshaw@golang.org>","distinct":true,"url":"https://api.github.com/repos/salewski/go/commits/5f08e480f447a7f197f41686bf672d39b10c3518"},{"sha":"0bb62299b0a37b68fa3bb40a0fe449858e162809","author":{"email":"993af7099cb24ce1a88d64108ae1e8b0385f2fc0@gmail.com","name":"Elias Naur"},"message":"misc/ios: deflake tests on darwin/arm{,arm64}\n\nA retry mechanism is in place to combat the inherent flakiness of\nlaunching iOS test binaries. Before it covered just the starting of\nlldb; expand it to cover the setup steps as well. Note that the\nrunning of the binary itself is (still) not retried, to avoid\ncovering over genuine bugs.\n\nOn my test device (iPhone 5S, iOS 9.3) starting lldb can take longer\nthan 10 seconds, so increase the timeout for that.\nFurthermore, some basic steps such as setting breakpoints in lldb\ncan take longer than the 1 second timeout. Increase that timeout\nas well, to 2 seconds.\n\nFinally, improve the error message for when ios-deploy is not\ninstalled.\n\nFor #14318\n\nChange-Id: Iba41d1bd9d023575b9454cb577b08f8cae081c2a\nReviewed-on: https://go-review.googlesource.com/21072\nReviewed-by: David Crawshaw <crawshaw@golang.org>","distinct":true,"url":"https://api.github.com/repos/salewski/go/commits/0bb62299b0a37b68fa3bb40a0fe449858e162809"},{"sha":"570a2b0eecc6ae8e398b2f1b56785cc9cacf0dbe","author":{"email":"993af7099cb24ce1a88d64108ae1e8b0385f2fc0@gmail.com","name":"Elias Naur"},"message":"cmd/dist: skip testcarchive test in Android and iOS\n\nCL 20892 converted the misc/cgo/testcarchive test to Go.\nUnfortunately, dist does not (yet) support tests running off the host\nso the testcarchive is disabled for now.\n\nFor #14318\n\nChange-Id: Iab3d0a7b5309187a603b48f22a7fa736f089f89d\nReviewed-on: https://go-review.googlesource.com/21070\nReviewed-by: David Crawshaw <crawshaw@golang.org>","distinct":true,"url":"https://api.github.com/repos/salewski/go/commits/570a2b0eecc6ae8e398b2f1b56785cc9cacf0dbe"},{"sha":"fc4358951a451c18267c4eb9ef0fb941963cc995","author":{"email":"cdc248cc4d32e4fbfe04e45228163bcecd48a0b9@gmail.com","name":"Josh Bleecher Snyder"},"message":"cmd/compile: avoid allocating a Nodes for readonly method receivers\n\nWe were allocating a Nodes for common method calls\nthat did not modify the Nodes.\nThough there is no clear wall time impact,\nthis significantly reduces the number of allocations,\nso it seems worth doing.\n\nPasses toolstash -cmp.\n\nname       old alloc/op    new alloc/op    delta\nTemplate      59.0MB ± 0%     58.6MB ± 0%   -0.81%        (p=0.000 n=25+25)\nUnicode       41.4MB ± 0%     41.3MB ± 0%   -0.18%        (p=0.000 n=25+25)\nGoTypes        198MB ± 0%      197MB ± 0%   -0.80%        (p=0.000 n=24+25)\nCompiler       875MB ± 0%      865MB ± 0%   -1.09%        (p=0.000 n=25+25)\n\nname       old allocs/op   new allocs/op   delta\nTemplate        581k ± 0%       520k ± 0%  -10.42%        (p=0.000 n=25+25)\nUnicode         413k ± 0%       403k ± 0%   -2.30%        (p=0.000 n=25+25)\nGoTypes        1.78M ± 0%      1.58M ± 0%  -11.18%        (p=0.000 n=25+25)\nCompiler       7.66M ± 0%      6.47M ± 0%  -15.51%        (p=0.000 n=25+25)\n\nChange-Id: I012a9f4b333821bdf61b4f2bdff4ce5c3b5d3057\nReviewed-on: https://go-review.googlesource.com/21056\nReviewed-by: Brad Fitzpatrick <bradfitz@golang.org>\nReviewed-by: Ian Lance Taylor <iant@golang.org>","distinct":true,"url":"https://api.github.com/repos/salewski/go/commits/fc4358951a451c18267c4eb9ef0fb941963cc995"},{"sha":"f045ca8d45c1f06312a022e40677eec3fc2e0ed3","author":{"email":"993af7099cb24ce1a88d64108ae1e8b0385f2fc0@gmail.com","name":"Elias Naur"},"message":"misc/ios: serialize iOS execution\n\nThe iOS exec wrapper use complicated machinery to run a iOS binary\non a device.\nRunning several binaries concurrently doesn't work (reliably), which\ncan break tests running concurrently. For my setup, the\nruntime:cpu124 and sync_cpu tests can't run reliably without one of them\ncrashing.\n\nAdd a file lock to the exec wrapper to serialize execution.\n\nFixes #14318 (for me)\n\nChange-Id: I023610e014b327f8d66f1d2fd2e54dd0e56f2be0\nReviewed-on: https://go-review.googlesource.com/21074\nReviewed-by: David Crawshaw <crawshaw@golang.org>","distinct":true,"url":"https://api.github.com/repos/salewski/go/commits/f045ca8d45c1f06312a022e40677eec3fc2e0ed3"},{"sha":"44532f1a9defb9cc4f48e74a7fa1ffd1dfa67022","author":{"email":"bde3f4ccdd7c08fc2bda30f654959132eeced9b3@gmail.com","name":"Marvin Stenger"},"message":"runtime: fix inconsistency in slice.go\n\nFixes #14938.\n\nAdditionally some simplifications along the way.\n\nChange-Id: I2c5fb7e32dcc6fab68fff36a49cb72e715756abe\nReviewed-on: https://go-review.googlesource.com/21046\nReviewed-by: Ian Lance Taylor <iant@golang.org>\nRun-TryBot: Ian Lance Taylor <iant@golang.org>","distinct":true,"url":"https://api.github.com/repos/salewski/go/commits/44532f1a9defb9cc4f48e74a7fa1ffd1dfa67022"}]}