{"action":"created","comment":{"url":"https://api.github.com/repos/ChurchCRM/CRM/pulls/comments/58328852","id":58328852,"diff_hunk":"@@ -21,6 +21,7 @@ public function __construct()\n    */\n   function setGroupMemberRole($groupID, $personID, $roleID)","path":"churchinfo/Service/GroupService.php","position":2,"original_position":2,"commit_id":"1f48fe83249ad57959565ca91c7220a5f8f5dada","original_commit_id":"1f48fe83249ad57959565ca91c7220a5f8f5dada","user":{"login":"DawoudIO","id":554959,"avatar_url":"https://avatars.githubusercontent.com/u/554959?v=3","gravatar_id":"","url":"https://api.github.com/users/DawoudIO","html_url":"https://github.com/DawoudIO","followers_url":"https://api.github.com/users/DawoudIO/followers","following_url":"https://api.github.com/users/DawoudIO/following{/other_user}","gists_url":"https://api.github.com/users/DawoudIO/gists{/gist_id}","starred_url":"https://api.github.com/users/DawoudIO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DawoudIO/subscriptions","organizations_url":"https://api.github.com/users/DawoudIO/orgs","repos_url":"https://api.github.com/users/DawoudIO/repos","events_url":"https://api.github.com/users/DawoudIO/events{/privacy}","received_events_url":"https://api.github.com/users/DawoudIO/received_events","type":"User","site_admin":false},"body":"Also if you are going to do it for all then use the constructor ","created_at":"2016-04-04T05:10:19Z","updated_at":"2016-04-04T05:10:19Z","html_url":"https://github.com/ChurchCRM/CRM/pull/515#discussion_r58328852","pull_request_url":"https://api.github.com/repos/ChurchCRM/CRM/pulls/515","_links":{"self":{"href":"https://api.github.com/repos/ChurchCRM/CRM/pulls/comments/58328852"},"html":{"href":"https://github.com/ChurchCRM/CRM/pull/515#discussion_r58328852"},"pull_request":{"href":"https://api.github.com/repos/ChurchCRM/CRM/pulls/515"}}},"pull_request":{"url":"https://api.github.com/repos/ChurchCRM/CRM/pulls/515","id":64889498,"html_url":"https://github.com/ChurchCRM/CRM/pull/515","diff_url":"https://github.com/ChurchCRM/CRM/pull/515.diff","patch_url":"https://github.com/ChurchCRM/CRM/pull/515.patch","issue_url":"https://api.github.com/repos/ChurchCRM/CRM/issues/515","number":515,"state":"open","locked":false,"title":"API security","user":{"login":"crossan007","id":11679900,"avatar_url":"https://avatars.githubusercontent.com/u/11679900?v=3","gravatar_id":"","url":"https://api.github.com/users/crossan007","html_url":"https://github.com/crossan007","followers_url":"https://api.github.com/users/crossan007/followers","following_url":"https://api.github.com/users/crossan007/following{/other_user}","gists_url":"https://api.github.com/users/crossan007/gists{/gist_id}","starred_url":"https://api.github.com/users/crossan007/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crossan007/subscriptions","organizations_url":"https://api.github.com/users/crossan007/orgs","repos_url":"https://api.github.com/users/crossan007/repos","events_url":"https://api.github.com/users/crossan007/events{/privacy}","received_events_url":"https://api.github.com/users/crossan007/received_events","type":"User","site_admin":false},"body":"This addresses API security in the Financial Service and System Service.\r\n\r\n![api security](https://cloud.githubusercontent.com/assets/11679900/14226678/9cee95e8-f8b6-11e5-8a78-2c502800daf2.gif)\r\n\r\n* The security is checked at the function in the service PHP file that actually retrieves the data\r\n* Check the security as close to the data as possible.\r\n* Let SLIM handle errors - Don't do try/catch in each SLIM route.  Closes  #516 \r\n\r\nTake a look at it, and let me know what you think.","created_at":"2016-04-01T02:59:37Z","updated_at":"2016-04-04T05:10:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5f97b848698eb2ea34460234c4bda41088274918","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ChurchCRM/CRM/pulls/515/commits","review_comments_url":"https://api.github.com/repos/ChurchCRM/CRM/pulls/515/comments","review_comment_url":"https://api.github.com/repos/ChurchCRM/CRM/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ChurchCRM/CRM/issues/515/comments","statuses_url":"https://api.github.com/repos/ChurchCRM/CRM/statuses/1f48fe83249ad57959565ca91c7220a5f8f5dada","head":{"label":"ChurchCRM:api_security","ref":"api_security","sha":"1f48fe83249ad57959565ca91c7220a5f8f5dada","user":{"login":"ChurchCRM","id":11025185,"avatar_url":"https://avatars.githubusercontent.com/u/11025185?v=3","gravatar_id":"","url":"https://api.github.com/users/ChurchCRM","html_url":"https://github.com/ChurchCRM","followers_url":"https://api.github.com/users/ChurchCRM/followers","following_url":"https://api.github.com/users/ChurchCRM/following{/other_user}","gists_url":"https://api.github.com/users/ChurchCRM/gists{/gist_id}","starred_url":"https://api.github.com/users/ChurchCRM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChurchCRM/subscriptions","organizations_url":"https://api.github.com/users/ChurchCRM/orgs","repos_url":"https://api.github.com/users/ChurchCRM/repos","events_url":"https://api.github.com/users/ChurchCRM/events{/privacy}","received_events_url":"https://api.github.com/users/ChurchCRM/received_events","type":"Organization","site_admin":false},"repo":{"id":30856851,"name":"CRM","full_name":"ChurchCRM/CRM","owner":{"login":"ChurchCRM","id":11025185,"avatar_url":"https://avatars.githubusercontent.com/u/11025185?v=3","gravatar_id":"","url":"https://api.github.com/users/ChurchCRM","html_url":"https://github.com/ChurchCRM","followers_url":"https://api.github.com/users/ChurchCRM/followers","following_url":"https://api.github.com/users/ChurchCRM/following{/other_user}","gists_url":"https://api.github.com/users/ChurchCRM/gists{/gist_id}","starred_url":"https://api.github.com/users/ChurchCRM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChurchCRM/subscriptions","organizations_url":"https://api.github.com/users/ChurchCRM/orgs","repos_url":"https://api.github.com/users/ChurchCRM/repos","events_url":"https://api.github.com/users/ChurchCRM/events{/privacy}","received_events_url":"https://api.github.com/users/ChurchCRM/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ChurchCRM/CRM","description":"ChurchCRM is a Fork of the ChurchInfo project, it uses ChurchInfo as  the starting point and adds new features and responsive UI.","fork":true,"url":"https://api.github.com/repos/ChurchCRM/CRM","forks_url":"https://api.github.com/repos/ChurchCRM/CRM/forks","keys_url":"https://api.github.com/repos/ChurchCRM/CRM/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ChurchCRM/CRM/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ChurchCRM/CRM/teams","hooks_url":"https://api.github.com/repos/ChurchCRM/CRM/hooks","issue_events_url":"https://api.github.com/repos/ChurchCRM/CRM/issues/events{/number}","events_url":"https://api.github.com/repos/ChurchCRM/CRM/events","assignees_url":"https://api.github.com/repos/ChurchCRM/CRM/assignees{/user}","branches_url":"https://api.github.com/repos/ChurchCRM/CRM/branches{/branch}","tags_url":"https://api.github.com/repos/ChurchCRM/CRM/tags","blobs_url":"https://api.github.com/repos/ChurchCRM/CRM/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ChurchCRM/CRM/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ChurchCRM/CRM/git/refs{/sha}","trees_url":"https://api.github.com/repos/ChurchCRM/CRM/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ChurchCRM/CRM/statuses/{sha}","languages_url":"https://api.github.com/repos/ChurchCRM/CRM/languages","stargazers_url":"https://api.github.com/repos/ChurchCRM/CRM/stargazers","contributors_url":"https://api.github.com/repos/ChurchCRM/CRM/contributors","subscribers_url":"https://api.github.com/repos/ChurchCRM/CRM/subscribers","subscription_url":"https://api.github.com/repos/ChurchCRM/CRM/subscription","commits_url":"https://api.github.com/repos/ChurchCRM/CRM/commits{/sha}","git_commits_url":"https://api.github.com/repos/ChurchCRM/CRM/git/commits{/sha}","comments_url":"https://api.github.com/repos/ChurchCRM/CRM/comments{/number}","issue_comment_url":"https://api.github.com/repos/ChurchCRM/CRM/issues/comments{/number}","contents_url":"https://api.github.com/repos/ChurchCRM/CRM/contents/{+path}","compare_url":"https://api.github.com/repos/ChurchCRM/CRM/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ChurchCRM/CRM/merges","archive_url":"https://api.github.com/repos/ChurchCRM/CRM/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ChurchCRM/CRM/downloads","issues_url":"https://api.github.com/repos/ChurchCRM/CRM/issues{/number}","pulls_url":"https://api.github.com/repos/ChurchCRM/CRM/pulls{/number}","milestones_url":"https://api.github.com/repos/ChurchCRM/CRM/milestones{/number}","notifications_url":"https://api.github.com/repos/ChurchCRM/CRM/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ChurchCRM/CRM/labels{/name}","releases_url":"https://api.github.com/repos/ChurchCRM/CRM/releases{/id}","deployments_url":"https://api.github.com/repos/ChurchCRM/CRM/deployments","created_at":"2015-02-16T06:38:40Z","updated_at":"2016-03-27T04:31:48Z","pushed_at":"2016-04-04T04:49:26Z","git_url":"git://github.com/ChurchCRM/CRM.git","ssh_url":"git@github.com:ChurchCRM/CRM.git","clone_url":"https://github.com/ChurchCRM/CRM.git","svn_url":"https://github.com/ChurchCRM/CRM","homepage":"http://www.ChurchCRM.io","size":21627,"stargazers_count":25,"watchers_count":25,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":99,"forks":16,"open_issues":99,"watchers":25,"default_branch":"develop"}},"base":{"label":"ChurchCRM:develop","ref":"develop","sha":"16f7a69ce0bf9fa0b982b61c0db00e680816cb54","user":{"login":"ChurchCRM","id":11025185,"avatar_url":"https://avatars.githubusercontent.com/u/11025185?v=3","gravatar_id":"","url":"https://api.github.com/users/ChurchCRM","html_url":"https://github.com/ChurchCRM","followers_url":"https://api.github.com/users/ChurchCRM/followers","following_url":"https://api.github.com/users/ChurchCRM/following{/other_user}","gists_url":"https://api.github.com/users/ChurchCRM/gists{/gist_id}","starred_url":"https://api.github.com/users/ChurchCRM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChurchCRM/subscriptions","organizations_url":"https://api.github.com/users/ChurchCRM/orgs","repos_url":"https://api.github.com/users/ChurchCRM/repos","events_url":"https://api.github.com/users/ChurchCRM/events{/privacy}","received_events_url":"https://api.github.com/users/ChurchCRM/received_events","type":"Organization","site_admin":false},"repo":{"id":30856851,"name":"CRM","full_name":"ChurchCRM/CRM","owner":{"login":"ChurchCRM","id":11025185,"avatar_url":"https://avatars.githubusercontent.com/u/11025185?v=3","gravatar_id":"","url":"https://api.github.com/users/ChurchCRM","html_url":"https://github.com/ChurchCRM","followers_url":"https://api.github.com/users/ChurchCRM/followers","following_url":"https://api.github.com/users/ChurchCRM/following{/other_user}","gists_url":"https://api.github.com/users/ChurchCRM/gists{/gist_id}","starred_url":"https://api.github.com/users/ChurchCRM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChurchCRM/subscriptions","organizations_url":"https://api.github.com/users/ChurchCRM/orgs","repos_url":"https://api.github.com/users/ChurchCRM/repos","events_url":"https://api.github.com/users/ChurchCRM/events{/privacy}","received_events_url":"https://api.github.com/users/ChurchCRM/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ChurchCRM/CRM","description":"ChurchCRM is a Fork of the ChurchInfo project, it uses ChurchInfo as  the starting point and adds new features and responsive UI.","fork":true,"url":"https://api.github.com/repos/ChurchCRM/CRM","forks_url":"https://api.github.com/repos/ChurchCRM/CRM/forks","keys_url":"https://api.github.com/repos/ChurchCRM/CRM/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ChurchCRM/CRM/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ChurchCRM/CRM/teams","hooks_url":"https://api.github.com/repos/ChurchCRM/CRM/hooks","issue_events_url":"https://api.github.com/repos/ChurchCRM/CRM/issues/events{/number}","events_url":"https://api.github.com/repos/ChurchCRM/CRM/events","assignees_url":"https://api.github.com/repos/ChurchCRM/CRM/assignees{/user}","branches_url":"https://api.github.com/repos/ChurchCRM/CRM/branches{/branch}","tags_url":"https://api.github.com/repos/ChurchCRM/CRM/tags","blobs_url":"https://api.github.com/repos/ChurchCRM/CRM/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ChurchCRM/CRM/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ChurchCRM/CRM/git/refs{/sha}","trees_url":"https://api.github.com/repos/ChurchCRM/CRM/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ChurchCRM/CRM/statuses/{sha}","languages_url":"https://api.github.com/repos/ChurchCRM/CRM/languages","stargazers_url":"https://api.github.com/repos/ChurchCRM/CRM/stargazers","contributors_url":"https://api.github.com/repos/ChurchCRM/CRM/contributors","subscribers_url":"https://api.github.com/repos/ChurchCRM/CRM/subscribers","subscription_url":"https://api.github.com/repos/ChurchCRM/CRM/subscription","commits_url":"https://api.github.com/repos/ChurchCRM/CRM/commits{/sha}","git_commits_url":"https://api.github.com/repos/ChurchCRM/CRM/git/commits{/sha}","comments_url":"https://api.github.com/repos/ChurchCRM/CRM/comments{/number}","issue_comment_url":"https://api.github.com/repos/ChurchCRM/CRM/issues/comments{/number}","contents_url":"https://api.github.com/repos/ChurchCRM/CRM/contents/{+path}","compare_url":"https://api.github.com/repos/ChurchCRM/CRM/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ChurchCRM/CRM/merges","archive_url":"https://api.github.com/repos/ChurchCRM/CRM/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ChurchCRM/CRM/downloads","issues_url":"https://api.github.com/repos/ChurchCRM/CRM/issues{/number}","pulls_url":"https://api.github.com/repos/ChurchCRM/CRM/pulls{/number}","milestones_url":"https://api.github.com/repos/ChurchCRM/CRM/milestones{/number}","notifications_url":"https://api.github.com/repos/ChurchCRM/CRM/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ChurchCRM/CRM/labels{/name}","releases_url":"https://api.github.com/repos/ChurchCRM/CRM/releases{/id}","deployments_url":"https://api.github.com/repos/ChurchCRM/CRM/deployments","created_at":"2015-02-16T06:38:40Z","updated_at":"2016-03-27T04:31:48Z","pushed_at":"2016-04-04T04:49:26Z","git_url":"git://github.com/ChurchCRM/CRM.git","ssh_url":"git@github.com:ChurchCRM/CRM.git","clone_url":"https://github.com/ChurchCRM/CRM.git","svn_url":"https://github.com/ChurchCRM/CRM","homepage":"http://www.ChurchCRM.io","size":21627,"stargazers_count":25,"watchers_count":25,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":99,"forks":16,"open_issues":99,"watchers":25,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ChurchCRM/CRM/pulls/515"},"html":{"href":"https://github.com/ChurchCRM/CRM/pull/515"},"issue":{"href":"https://api.github.com/repos/ChurchCRM/CRM/issues/515"},"comments":{"href":"https://api.github.com/repos/ChurchCRM/CRM/issues/515/comments"},"review_comments":{"href":"https://api.github.com/repos/ChurchCRM/CRM/pulls/515/comments"},"review_comment":{"href":"https://api.github.com/repos/ChurchCRM/CRM/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ChurchCRM/CRM/pulls/515/commits"},"statuses":{"href":"https://api.github.com/repos/ChurchCRM/CRM/statuses/1f48fe83249ad57959565ca91c7220a5f8f5dada"}}}}