{"action":"created","issue":{"url":"https://api.github.com/repos/apache/incubator-airflow/issues/1517","repository_url":"https://api.github.com/repos/apache/incubator-airflow","labels_url":"https://api.github.com/repos/apache/incubator-airflow/issues/1517/labels{/name}","comments_url":"https://api.github.com/repos/apache/incubator-airflow/issues/1517/comments","events_url":"https://api.github.com/repos/apache/incubator-airflow/issues/1517/events","html_url":"https://github.com/apache/incubator-airflow/pull/1517","id":155692762,"number":1517,"title":"[AIRFLOW-96] s3_conn_id using environment variable","user":{"login":"dm-tran","id":7153721,"avatar_url":"https://avatars.githubusercontent.com/u/7153721?v=3","gravatar_id":"","url":"https://api.github.com/users/dm-tran","html_url":"https://github.com/dm-tran","followers_url":"https://api.github.com/users/dm-tran/followers","following_url":"https://api.github.com/users/dm-tran/following{/other_user}","gists_url":"https://api.github.com/users/dm-tran/gists{/gist_id}","starred_url":"https://api.github.com/users/dm-tran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dm-tran/subscriptions","organizations_url":"https://api.github.com/users/dm-tran/orgs","repos_url":"https://api.github.com/users/dm-tran/repos","events_url":"https://api.github.com/users/dm-tran/events{/privacy}","received_events_url":"https://api.github.com/users/dm-tran/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-05-19T09:32:13Z","updated_at":"2016-10-18T09:19:40Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/incubator-airflow/pulls/1517","html_url":"https://github.com/apache/incubator-airflow/pull/1517","diff_url":"https://github.com/apache/incubator-airflow/pull/1517.diff","patch_url":"https://github.com/apache/incubator-airflow/pull/1517.patch"},"body":"Dear Airflow Maintainers,\r\n\r\nPlease accept this PR that addresses the following issues:\r\n- [AIRFLOW-96](https://issues.apache.org/jira/browse/AIRFLOW-96) : allow parameter \"s3_conn_id\" of S3KeySensor and S3PrefixSensor to be defined using an environment variable.\r\n\r\nActually, S3KeySensor and S3PrefixSensor use the S3hook, which extends BaseHook. BaseHook has get_connection, which looks a connection up : \r\n- in environment variables first\r\n- and then in the database"},"comment":{"url":"https://api.github.com/repos/apache/incubator-airflow/issues/comments/254453018","html_url":"https://github.com/apache/incubator-airflow/pull/1517#issuecomment-254453018","issue_url":"https://api.github.com/repos/apache/incubator-airflow/issues/1517","id":254453018,"user":{"login":"dm-tran","id":7153721,"avatar_url":"https://avatars.githubusercontent.com/u/7153721?v=3","gravatar_id":"","url":"https://api.github.com/users/dm-tran","html_url":"https://github.com/dm-tran","followers_url":"https://api.github.com/users/dm-tran/followers","following_url":"https://api.github.com/users/dm-tran/following{/other_user}","gists_url":"https://api.github.com/users/dm-tran/gists{/gist_id}","starred_url":"https://api.github.com/users/dm-tran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dm-tran/subscriptions","organizations_url":"https://api.github.com/users/dm-tran/orgs","repos_url":"https://api.github.com/users/dm-tran/repos","events_url":"https://api.github.com/users/dm-tran/events{/privacy}","received_events_url":"https://api.github.com/users/dm-tran/received_events","type":"User","site_admin":false},"created_at":"2016-10-18T09:19:40Z","updated_at":"2016-10-18T09:19:40Z","body":"Hi @msumit, I have resolved the conflicts and modified the commit message.\r\n\r\nThe code quality check from landscape has failed, but details cannot be seen at the moment : https://landscape.io/github/apache/incubator-airflow/pulls/1517 displays \"Server Error (500)\""}}
{"actor":{"display_login":"dm-tran"}}