{"action":"created","comment":{"url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/comments/78784331","id":78784331,"diff_hunk":"@@ -41,7 +41,15 @@ spv_context spvContextCreate(spv_target_env env) {\n   spvOperandTableGet(&operand_table, env);\n   spvExtInstTableGet(&ext_inst_table, env);\n \n-  return new spv_context_t{env, opcode_table, operand_table, ext_inst_table};\n+  return new spv_context_t{\n+      env, opcode_table, operand_table, ext_inst_table,\n+      nullptr /* an empty MessageConsumer */","path":"source/table.cpp","position":7,"original_position":7,"commit_id":"eeba76b50f03c4cbc7b438d2e1eea51f8cb09a8e","original_commit_id":"eeba76b50f03c4cbc7b438d2e1eea51f8cb09a8e","user":{"login":"dneto0","id":13054574,"avatar_url":"https://avatars.githubusercontent.com/u/13054574?v=3","gravatar_id":"","url":"https://api.github.com/users/dneto0","html_url":"https://github.com/dneto0","followers_url":"https://api.github.com/users/dneto0/followers","following_url":"https://api.github.com/users/dneto0/following{/other_user}","gists_url":"https://api.github.com/users/dneto0/gists{/gist_id}","starred_url":"https://api.github.com/users/dneto0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dneto0/subscriptions","organizations_url":"https://api.github.com/users/dneto0/orgs","repos_url":"https://api.github.com/users/dneto0/repos","events_url":"https://api.github.com/users/dneto0/events{/privacy}","received_events_url":"https://api.github.com/users/dneto0/received_events","type":"User","site_admin":false},"body":"Is this a good default?  Should we instead default to a message consumer that just does nothing with the message?  Then it's always safe to call.","created_at":"2016-09-14T16:28:26Z","updated_at":"2016-09-14T16:28:26Z","html_url":"https://github.com/KhronosGroup/SPIRV-Tools/pull/401#discussion_r78784331","pull_request_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/401","_links":{"self":{"href":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/comments/78784331"},"html":{"href":"https://github.com/KhronosGroup/SPIRV-Tools/pull/401#discussion_r78784331"},"pull_request":{"href":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/401"}}},"pull_request":{"url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/401","id":83909976,"html_url":"https://github.com/KhronosGroup/SPIRV-Tools/pull/401","diff_url":"https://github.com/KhronosGroup/SPIRV-Tools/pull/401.diff","patch_url":"https://github.com/KhronosGroup/SPIRV-Tools/pull/401.patch","issue_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/issues/401","number":401,"state":"open","locked":false,"title":"1. Callback mechanism for error handling","user":{"login":"antiagainst","id":487928,"avatar_url":"https://avatars.githubusercontent.com/u/487928?v=3","gravatar_id":"","url":"https://api.github.com/users/antiagainst","html_url":"https://github.com/antiagainst","followers_url":"https://api.github.com/users/antiagainst/followers","following_url":"https://api.github.com/users/antiagainst/following{/other_user}","gists_url":"https://api.github.com/users/antiagainst/gists{/gist_id}","starred_url":"https://api.github.com/users/antiagainst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antiagainst/subscriptions","organizations_url":"https://api.github.com/users/antiagainst/orgs","repos_url":"https://api.github.com/users/antiagainst/repos","events_url":"https://api.github.com/users/antiagainst/events{/privacy}","received_events_url":"https://api.github.com/users/antiagainst/received_events","type":"User","site_admin":false},"body":"Every time an event happens in the library that the user should be\r\naware of, the callback will be invoked.\r\n\r\nThe existing diagnostic mechanism is hijacked internally by a\r\ncallback that creates an diagnostic object each time an event\r\nhappens.","created_at":"2016-09-04T00:44:43Z","updated_at":"2016-09-14T16:28:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bb2bdb4481977774f871c233ff4b64f29eeff130","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/401/commits","review_comments_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/401/comments","review_comment_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/issues/401/comments","statuses_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/statuses/eeba76b50f03c4cbc7b438d2e1eea51f8cb09a8e","head":{"label":"antiagainst:stream","ref":"stream","sha":"eeba76b50f03c4cbc7b438d2e1eea51f8cb09a8e","user":{"login":"antiagainst","id":487928,"avatar_url":"https://avatars.githubusercontent.com/u/487928?v=3","gravatar_id":"","url":"https://api.github.com/users/antiagainst","html_url":"https://github.com/antiagainst","followers_url":"https://api.github.com/users/antiagainst/followers","following_url":"https://api.github.com/users/antiagainst/following{/other_user}","gists_url":"https://api.github.com/users/antiagainst/gists{/gist_id}","starred_url":"https://api.github.com/users/antiagainst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antiagainst/subscriptions","organizations_url":"https://api.github.com/users/antiagainst/orgs","repos_url":"https://api.github.com/users/antiagainst/repos","events_url":"https://api.github.com/users/antiagainst/events{/privacy}","received_events_url":"https://api.github.com/users/antiagainst/received_events","type":"User","site_admin":false},"repo":{"id":46284705,"name":"SPIRV-Tools","full_name":"antiagainst/SPIRV-Tools","owner":{"login":"antiagainst","id":487928,"avatar_url":"https://avatars.githubusercontent.com/u/487928?v=3","gravatar_id":"","url":"https://api.github.com/users/antiagainst","html_url":"https://github.com/antiagainst","followers_url":"https://api.github.com/users/antiagainst/followers","following_url":"https://api.github.com/users/antiagainst/following{/other_user}","gists_url":"https://api.github.com/users/antiagainst/gists{/gist_id}","starred_url":"https://api.github.com/users/antiagainst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antiagainst/subscriptions","organizations_url":"https://api.github.com/users/antiagainst/orgs","repos_url":"https://api.github.com/users/antiagainst/repos","events_url":"https://api.github.com/users/antiagainst/events{/privacy}","received_events_url":"https://api.github.com/users/antiagainst/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/antiagainst/SPIRV-Tools","description":"","fork":true,"url":"https://api.github.com/repos/antiagainst/SPIRV-Tools","forks_url":"https://api.github.com/repos/antiagainst/SPIRV-Tools/forks","keys_url":"https://api.github.com/repos/antiagainst/SPIRV-Tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/antiagainst/SPIRV-Tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/antiagainst/SPIRV-Tools/teams","hooks_url":"https://api.github.com/repos/antiagainst/SPIRV-Tools/hooks","issue_events_url":"https://api.github.com/repos/antiagainst/SPIRV-Tools/issues/events{/number}","events_url":"https://api.github.com/repos/antiagainst/SPIRV-Tools/events","assignees_url":"https://api.github.com/repos/antiagainst/SPIRV-Tools/assignees{/user}","branches_url":"https://api.github.com/repos/antiagainst/SPIRV-Tools/branches{/branch}","tags_url":"https://api.github.com/repos/antiagainst/SPIRV-Tools/tags","blobs_url":"https://api.github.com/repos/antiagainst/SPIRV-Tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/antiagainst/SPIRV-Tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/antiagainst/SPIRV-Tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/antiagainst/SPIRV-Tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/antiagainst/SPIRV-Tools/statuses/{sha}","languages_url":"https://api.github.com/repos/antiagainst/SPIRV-Tools/languages","stargazers_url":"https://api.github.com/repos/antiagainst/SPIRV-Tools/stargazers","contributors_url":"https://api.github.com/repos/antiagainst/SPIRV-Tools/contributors","subscribers_url":"https://api.github.com/repos/antiagainst/SPIRV-Tools/subscribers","subscription_url":"https://api.github.com/repos/antiagainst/SPIRV-Tools/subscription","commits_url":"https://api.github.com/repos/antiagainst/SPIRV-Tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/antiagainst/SPIRV-Tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/antiagainst/SPIRV-Tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/antiagainst/SPIRV-Tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/antiagainst/SPIRV-Tools/contents/{+path}","compare_url":"https://api.github.com/repos/antiagainst/SPIRV-Tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/antiagainst/SPIRV-Tools/merges","archive_url":"https://api.github.com/repos/antiagainst/SPIRV-Tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/antiagainst/SPIRV-Tools/downloads","issues_url":"https://api.github.com/repos/antiagainst/SPIRV-Tools/issues{/number}","pulls_url":"https://api.github.com/repos/antiagainst/SPIRV-Tools/pulls{/number}","milestones_url":"https://api.github.com/repos/antiagainst/SPIRV-Tools/milestones{/number}","notifications_url":"https://api.github.com/repos/antiagainst/SPIRV-Tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/antiagainst/SPIRV-Tools/labels{/name}","releases_url":"https://api.github.com/repos/antiagainst/SPIRV-Tools/releases{/id}","deployments_url":"https://api.github.com/repos/antiagainst/SPIRV-Tools/deployments","created_at":"2015-11-16T15:47:34Z","updated_at":"2016-01-26T23:12:38Z","pushed_at":"2016-09-12T21:14:02Z","git_url":"git://github.com/antiagainst/SPIRV-Tools.git","ssh_url":"git@github.com:antiagainst/SPIRV-Tools.git","clone_url":"https://github.com/antiagainst/SPIRV-Tools.git","svn_url":"https://github.com/antiagainst/SPIRV-Tools","homepage":null,"size":2403,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"KhronosGroup:master","ref":"master","sha":"049f80f3b9289e322cb1d0cfe63c6aa6bd40338f","user":{"login":"KhronosGroup","id":1608701,"avatar_url":"https://avatars.githubusercontent.com/u/1608701?v=3","gravatar_id":"","url":"https://api.github.com/users/KhronosGroup","html_url":"https://github.com/KhronosGroup","followers_url":"https://api.github.com/users/KhronosGroup/followers","following_url":"https://api.github.com/users/KhronosGroup/following{/other_user}","gists_url":"https://api.github.com/users/KhronosGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/KhronosGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KhronosGroup/subscriptions","organizations_url":"https://api.github.com/users/KhronosGroup/orgs","repos_url":"https://api.github.com/users/KhronosGroup/repos","events_url":"https://api.github.com/users/KhronosGroup/events{/privacy}","received_events_url":"https://api.github.com/users/KhronosGroup/received_events","type":"Organization","site_admin":false},"repo":{"id":45981801,"name":"SPIRV-Tools","full_name":"KhronosGroup/SPIRV-Tools","owner":{"login":"KhronosGroup","id":1608701,"avatar_url":"https://avatars.githubusercontent.com/u/1608701?v=3","gravatar_id":"","url":"https://api.github.com/users/KhronosGroup","html_url":"https://github.com/KhronosGroup","followers_url":"https://api.github.com/users/KhronosGroup/followers","following_url":"https://api.github.com/users/KhronosGroup/following{/other_user}","gists_url":"https://api.github.com/users/KhronosGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/KhronosGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KhronosGroup/subscriptions","organizations_url":"https://api.github.com/users/KhronosGroup/orgs","repos_url":"https://api.github.com/users/KhronosGroup/repos","events_url":"https://api.github.com/users/KhronosGroup/events{/privacy}","received_events_url":"https://api.github.com/users/KhronosGroup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/KhronosGroup/SPIRV-Tools","description":"","fork":false,"url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools","forks_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/forks","keys_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/teams","hooks_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/hooks","issue_events_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/issues/events{/number}","events_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/events","assignees_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/assignees{/user}","branches_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/branches{/branch}","tags_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/tags","blobs_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/statuses/{sha}","languages_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/languages","stargazers_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/stargazers","contributors_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/contributors","subscribers_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/subscribers","subscription_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/subscription","commits_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/contents/{+path}","compare_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/merges","archive_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/downloads","issues_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/issues{/number}","pulls_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls{/number}","milestones_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/milestones{/number}","notifications_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/labels{/name}","releases_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/releases{/id}","deployments_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/deployments","created_at":"2015-11-11T12:56:25Z","updated_at":"2016-09-01T23:18:51Z","pushed_at":"2016-09-14T16:27:00Z","git_url":"git://github.com/KhronosGroup/SPIRV-Tools.git","ssh_url":"git@github.com:KhronosGroup/SPIRV-Tools.git","clone_url":"https://github.com/KhronosGroup/SPIRV-Tools.git","svn_url":"https://github.com/KhronosGroup/SPIRV-Tools","homepage":null,"size":3018,"stargazers_count":136,"watchers_count":136,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":35,"mirror_url":null,"open_issues_count":30,"forks":35,"open_issues":30,"watchers":136,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/401"},"html":{"href":"https://github.com/KhronosGroup/SPIRV-Tools/pull/401"},"issue":{"href":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/issues/401"},"comments":{"href":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/issues/401/comments"},"review_comments":{"href":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/401/comments"},"review_comment":{"href":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/401/commits"},"statuses":{"href":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/statuses/eeba76b50f03c4cbc7b438d2e1eea51f8cb09a8e"}}}}
{"actor":{"display_login":"dneto0"}}