{"action":"created","comment":{"url":"https://api.github.com/repos/jupyter/nbconvert/pulls/comments/87459343","pull_request_review_id":8072313,"id":87459343,"diff_hunk":"@@ -50,6 +50,7 @@\n         'prevent_list_blocks': filters.prevent_list_blocks,\n         'get_metadata': filters.get_metadata,\n         'convert_pandoc': filters.convert_pandoc,\n+        'wrapped_convert_link': wrapped_convert_link,","path":"nbconvert/exporters/templateexporter.py","position":13,"original_position":13,"commit_id":"606ca9bc45caaa97d2cfd48a0e2c106f0593ce2a","original_commit_id":"93b62f387b92fd8caec4299e02b2a10b379e08ea","user":{"login":"takluyver","id":327925,"avatar_url":"https://avatars.githubusercontent.com/u/327925?v=3","gravatar_id":"","url":"https://api.github.com/users/takluyver","html_url":"https://github.com/takluyver","followers_url":"https://api.github.com/users/takluyver/followers","following_url":"https://api.github.com/users/takluyver/following{/other_user}","gists_url":"https://api.github.com/users/takluyver/gists{/gist_id}","starred_url":"https://api.github.com/users/takluyver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/takluyver/subscriptions","organizations_url":"https://api.github.com/users/takluyver/orgs","repos_url":"https://api.github.com/users/takluyver/repos","events_url":"https://api.github.com/users/takluyver/events{/privacy}","received_events_url":"https://api.github.com/users/takluyver/received_events","type":"User","site_admin":false},"body":"I'd like the name here to be a bit more descriptive: `wrapped` is an implementation detail, and it's not clear what it means (wrapped in what?). A descriptive name might be like `pandoc_internal_links_to_latex_refs`. That is a bit wordy, so better suggestions welcome.\r\n\r\nI also wonder if it should only be registered for the latex exporter - then the name could be a bit less precise. Adding a filter for an exporter works like this (example from bookbook):\r\n\r\n```python\r\ndef default_filters(self):\r\n    yield from super(MyHTMLExporter, self).default_filters()\r\n    yield ('markdown2html', markdown2html_custom)\r\n```","created_at":"2016-11-10T18:46:24Z","updated_at":"2016-11-10T18:46:24Z","html_url":"https://github.com/jupyter/nbconvert/pull/458#discussion_r87459343","pull_request_url":"https://api.github.com/repos/jupyter/nbconvert/pulls/458","_links":{"self":{"href":"https://api.github.com/repos/jupyter/nbconvert/pulls/comments/87459343"},"html":{"href":"https://github.com/jupyter/nbconvert/pull/458#discussion_r87459343"},"pull_request":{"href":"https://api.github.com/repos/jupyter/nbconvert/pulls/458"}}},"pull_request":{"url":"https://api.github.com/repos/jupyter/nbconvert/pulls/458","id":92435364,"html_url":"https://github.com/jupyter/nbconvert/pull/458","diff_url":"https://github.com/jupyter/nbconvert/pull/458.diff","patch_url":"https://github.com/jupyter/nbconvert/pull/458.patch","issue_url":"https://api.github.com/repos/jupyter/nbconvert/issues/458","number":458,"state":"open","locked":false,"title":"Link resolution","user":{"login":"michaelpacer","id":2482408,"avatar_url":"https://avatars.githubusercontent.com/u/2482408?v=3","gravatar_id":"","url":"https://api.github.com/users/michaelpacer","html_url":"https://github.com/michaelpacer","followers_url":"https://api.github.com/users/michaelpacer/followers","following_url":"https://api.github.com/users/michaelpacer/following{/other_user}","gists_url":"https://api.github.com/users/michaelpacer/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelpacer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelpacer/subscriptions","organizations_url":"https://api.github.com/users/michaelpacer/orgs","repos_url":"https://api.github.com/users/michaelpacer/repos","events_url":"https://api.github.com/users/michaelpacer/events{/privacy}","received_events_url":"https://api.github.com/users/michaelpacer/received_events","type":"User","site_admin":false},"body":"Close #11 by passing an intermediate JSON representation through a filter that directly manipulates the underlying pandoc AST as part of a 2 step conversion process.\r\n\r\nIt also creates a general utility for walking through this representation in other cases based on the  https://github.com/jgm/pandocfilters library with a new utility (`applyJSONFilters`) that we are mirroring until/if  https://github.com/jgm/pandocfilters/pull/49 is merged.\r\n\r\n@takluyver ","created_at":"2016-11-05T00:32:45Z","updated_at":"2016-11-10T18:46:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"54ef587debedd3e2de590edbf8b24529a38ed856","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/jupyter/nbconvert/pulls/458/commits","review_comments_url":"https://api.github.com/repos/jupyter/nbconvert/pulls/458/comments","review_comment_url":"https://api.github.com/repos/jupyter/nbconvert/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jupyter/nbconvert/issues/458/comments","statuses_url":"https://api.github.com/repos/jupyter/nbconvert/statuses/606ca9bc45caaa97d2cfd48a0e2c106f0593ce2a","head":{"label":"michaelpacer:link_resolution","ref":"link_resolution","sha":"606ca9bc45caaa97d2cfd48a0e2c106f0593ce2a","user":{"login":"michaelpacer","id":2482408,"avatar_url":"https://avatars.githubusercontent.com/u/2482408?v=3","gravatar_id":"","url":"https://api.github.com/users/michaelpacer","html_url":"https://github.com/michaelpacer","followers_url":"https://api.github.com/users/michaelpacer/followers","following_url":"https://api.github.com/users/michaelpacer/following{/other_user}","gists_url":"https://api.github.com/users/michaelpacer/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelpacer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelpacer/subscriptions","organizations_url":"https://api.github.com/users/michaelpacer/orgs","repos_url":"https://api.github.com/users/michaelpacer/repos","events_url":"https://api.github.com/users/michaelpacer/events{/privacy}","received_events_url":"https://api.github.com/users/michaelpacer/received_events","type":"User","site_admin":false},"repo":{"id":42892748,"name":"nbconvert","full_name":"michaelpacer/nbconvert","owner":{"login":"michaelpacer","id":2482408,"avatar_url":"https://avatars.githubusercontent.com/u/2482408?v=3","gravatar_id":"","url":"https://api.github.com/users/michaelpacer","html_url":"https://github.com/michaelpacer","followers_url":"https://api.github.com/users/michaelpacer/followers","following_url":"https://api.github.com/users/michaelpacer/following{/other_user}","gists_url":"https://api.github.com/users/michaelpacer/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelpacer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelpacer/subscriptions","organizations_url":"https://api.github.com/users/michaelpacer/orgs","repos_url":"https://api.github.com/users/michaelpacer/repos","events_url":"https://api.github.com/users/michaelpacer/events{/privacy}","received_events_url":"https://api.github.com/users/michaelpacer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/michaelpacer/nbconvert","description":"Jupyter Notebook Conversion","fork":true,"url":"https://api.github.com/repos/michaelpacer/nbconvert","forks_url":"https://api.github.com/repos/michaelpacer/nbconvert/forks","keys_url":"https://api.github.com/repos/michaelpacer/nbconvert/keys{/key_id}","collaborators_url":"https://api.github.com/repos/michaelpacer/nbconvert/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/michaelpacer/nbconvert/teams","hooks_url":"https://api.github.com/repos/michaelpacer/nbconvert/hooks","issue_events_url":"https://api.github.com/repos/michaelpacer/nbconvert/issues/events{/number}","events_url":"https://api.github.com/repos/michaelpacer/nbconvert/events","assignees_url":"https://api.github.com/repos/michaelpacer/nbconvert/assignees{/user}","branches_url":"https://api.github.com/repos/michaelpacer/nbconvert/branches{/branch}","tags_url":"https://api.github.com/repos/michaelpacer/nbconvert/tags","blobs_url":"https://api.github.com/repos/michaelpacer/nbconvert/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/michaelpacer/nbconvert/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/michaelpacer/nbconvert/git/refs{/sha}","trees_url":"https://api.github.com/repos/michaelpacer/nbconvert/git/trees{/sha}","statuses_url":"https://api.github.com/repos/michaelpacer/nbconvert/statuses/{sha}","languages_url":"https://api.github.com/repos/michaelpacer/nbconvert/languages","stargazers_url":"https://api.github.com/repos/michaelpacer/nbconvert/stargazers","contributors_url":"https://api.github.com/repos/michaelpacer/nbconvert/contributors","subscribers_url":"https://api.github.com/repos/michaelpacer/nbconvert/subscribers","subscription_url":"https://api.github.com/repos/michaelpacer/nbconvert/subscription","commits_url":"https://api.github.com/repos/michaelpacer/nbconvert/commits{/sha}","git_commits_url":"https://api.github.com/repos/michaelpacer/nbconvert/git/commits{/sha}","comments_url":"https://api.github.com/repos/michaelpacer/nbconvert/comments{/number}","issue_comment_url":"https://api.github.com/repos/michaelpacer/nbconvert/issues/comments{/number}","contents_url":"https://api.github.com/repos/michaelpacer/nbconvert/contents/{+path}","compare_url":"https://api.github.com/repos/michaelpacer/nbconvert/compare/{base}...{head}","merges_url":"https://api.github.com/repos/michaelpacer/nbconvert/merges","archive_url":"https://api.github.com/repos/michaelpacer/nbconvert/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/michaelpacer/nbconvert/downloads","issues_url":"https://api.github.com/repos/michaelpacer/nbconvert/issues{/number}","pulls_url":"https://api.github.com/repos/michaelpacer/nbconvert/pulls{/number}","milestones_url":"https://api.github.com/repos/michaelpacer/nbconvert/milestones{/number}","notifications_url":"https://api.github.com/repos/michaelpacer/nbconvert/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/michaelpacer/nbconvert/labels{/name}","releases_url":"https://api.github.com/repos/michaelpacer/nbconvert/releases{/id}","deployments_url":"https://api.github.com/repos/michaelpacer/nbconvert/deployments","created_at":"2015-09-21T20:45:20Z","updated_at":"2016-07-16T17:53:00Z","pushed_at":"2016-11-10T18:44:07Z","git_url":"git://github.com/michaelpacer/nbconvert.git","ssh_url":"git@github.com:michaelpacer/nbconvert.git","clone_url":"https://github.com/michaelpacer/nbconvert.git","svn_url":"https://github.com/michaelpacer/nbconvert","homepage":"http://nbconvert.readthedocs.org/","size":2008,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jupyter:master","ref":"master","sha":"8976336f693c84ba9076d3ce08cfc494e178d6e6","user":{"login":"jupyter","id":7388996,"avatar_url":"https://avatars.githubusercontent.com/u/7388996?v=3","gravatar_id":"","url":"https://api.github.com/users/jupyter","html_url":"https://github.com/jupyter","followers_url":"https://api.github.com/users/jupyter/followers","following_url":"https://api.github.com/users/jupyter/following{/other_user}","gists_url":"https://api.github.com/users/jupyter/gists{/gist_id}","starred_url":"https://api.github.com/users/jupyter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jupyter/subscriptions","organizations_url":"https://api.github.com/users/jupyter/orgs","repos_url":"https://api.github.com/users/jupyter/repos","events_url":"https://api.github.com/users/jupyter/events{/privacy}","received_events_url":"https://api.github.com/users/jupyter/received_events","type":"Organization","site_admin":false},"repo":{"id":33653617,"name":"nbconvert","full_name":"jupyter/nbconvert","owner":{"login":"jupyter","id":7388996,"avatar_url":"https://avatars.githubusercontent.com/u/7388996?v=3","gravatar_id":"","url":"https://api.github.com/users/jupyter","html_url":"https://github.com/jupyter","followers_url":"https://api.github.com/users/jupyter/followers","following_url":"https://api.github.com/users/jupyter/following{/other_user}","gists_url":"https://api.github.com/users/jupyter/gists{/gist_id}","starred_url":"https://api.github.com/users/jupyter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jupyter/subscriptions","organizations_url":"https://api.github.com/users/jupyter/orgs","repos_url":"https://api.github.com/users/jupyter/repos","events_url":"https://api.github.com/users/jupyter/events{/privacy}","received_events_url":"https://api.github.com/users/jupyter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jupyter/nbconvert","description":"Jupyter Notebook Conversion","fork":false,"url":"https://api.github.com/repos/jupyter/nbconvert","forks_url":"https://api.github.com/repos/jupyter/nbconvert/forks","keys_url":"https://api.github.com/repos/jupyter/nbconvert/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jupyter/nbconvert/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jupyter/nbconvert/teams","hooks_url":"https://api.github.com/repos/jupyter/nbconvert/hooks","issue_events_url":"https://api.github.com/repos/jupyter/nbconvert/issues/events{/number}","events_url":"https://api.github.com/repos/jupyter/nbconvert/events","assignees_url":"https://api.github.com/repos/jupyter/nbconvert/assignees{/user}","branches_url":"https://api.github.com/repos/jupyter/nbconvert/branches{/branch}","tags_url":"https://api.github.com/repos/jupyter/nbconvert/tags","blobs_url":"https://api.github.com/repos/jupyter/nbconvert/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jupyter/nbconvert/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jupyter/nbconvert/git/refs{/sha}","trees_url":"https://api.github.com/repos/jupyter/nbconvert/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jupyter/nbconvert/statuses/{sha}","languages_url":"https://api.github.com/repos/jupyter/nbconvert/languages","stargazers_url":"https://api.github.com/repos/jupyter/nbconvert/stargazers","contributors_url":"https://api.github.com/repos/jupyter/nbconvert/contributors","subscribers_url":"https://api.github.com/repos/jupyter/nbconvert/subscribers","subscription_url":"https://api.github.com/repos/jupyter/nbconvert/subscription","commits_url":"https://api.github.com/repos/jupyter/nbconvert/commits{/sha}","git_commits_url":"https://api.github.com/repos/jupyter/nbconvert/git/commits{/sha}","comments_url":"https://api.github.com/repos/jupyter/nbconvert/comments{/number}","issue_comment_url":"https://api.github.com/repos/jupyter/nbconvert/issues/comments{/number}","contents_url":"https://api.github.com/repos/jupyter/nbconvert/contents/{+path}","compare_url":"https://api.github.com/repos/jupyter/nbconvert/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jupyter/nbconvert/merges","archive_url":"https://api.github.com/repos/jupyter/nbconvert/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jupyter/nbconvert/downloads","issues_url":"https://api.github.com/repos/jupyter/nbconvert/issues{/number}","pulls_url":"https://api.github.com/repos/jupyter/nbconvert/pulls{/number}","milestones_url":"https://api.github.com/repos/jupyter/nbconvert/milestones{/number}","notifications_url":"https://api.github.com/repos/jupyter/nbconvert/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jupyter/nbconvert/labels{/name}","releases_url":"https://api.github.com/repos/jupyter/nbconvert/releases{/id}","deployments_url":"https://api.github.com/repos/jupyter/nbconvert/deployments","created_at":"2015-04-09T06:58:23Z","updated_at":"2016-11-05T21:26:35Z","pushed_at":"2016-11-10T18:44:07Z","git_url":"git://github.com/jupyter/nbconvert.git","ssh_url":"git@github.com:jupyter/nbconvert.git","clone_url":"https://github.com/jupyter/nbconvert.git","svn_url":"https://github.com/jupyter/nbconvert","homepage":"https://nbconvert.readthedocs.io/","size":4360,"stargazers_count":122,"watchers_count":122,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":109,"mirror_url":null,"open_issues_count":100,"forks":109,"open_issues":100,"watchers":122,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jupyter/nbconvert/pulls/458"},"html":{"href":"https://github.com/jupyter/nbconvert/pull/458"},"issue":{"href":"https://api.github.com/repos/jupyter/nbconvert/issues/458"},"comments":{"href":"https://api.github.com/repos/jupyter/nbconvert/issues/458/comments"},"review_comments":{"href":"https://api.github.com/repos/jupyter/nbconvert/pulls/458/comments"},"review_comment":{"href":"https://api.github.com/repos/jupyter/nbconvert/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jupyter/nbconvert/pulls/458/commits"},"statuses":{"href":"https://api.github.com/repos/jupyter/nbconvert/statuses/606ca9bc45caaa97d2cfd48a0e2c106f0593ce2a"}}}}
{"actor":{"display_login":"takluyver"}}