{"action":"closed","number":3877,"pull_request":{"url":"https://api.github.com/repos/jruby/jruby/pulls/3877","id":69737209,"html_url":"https://github.com/jruby/jruby/pull/3877","diff_url":"https://github.com/jruby/jruby/pull/3877.diff","patch_url":"https://github.com/jruby/jruby/pull/3877.patch","issue_url":"https://api.github.com/repos/jruby/jruby/issues/3877","number":3877,"state":"closed","locked":false,"title":"File.basename should support windows1250","user":{"login":"ahorek","id":9540855,"avatar_url":"https://avatars.githubusercontent.com/u/9540855?v=3","gravatar_id":"","url":"https://api.github.com/users/ahorek","html_url":"https://github.com/ahorek","followers_url":"https://api.github.com/users/ahorek/followers","following_url":"https://api.github.com/users/ahorek/following{/other_user}","gists_url":"https://api.github.com/users/ahorek/gists{/gist_id}","starred_url":"https://api.github.com/users/ahorek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahorek/subscriptions","organizations_url":"https://api.github.com/users/ahorek/orgs","repos_url":"https://api.github.com/users/ahorek/repos","events_url":"https://api.github.com/users/ahorek/events{/privacy}","received_events_url":"https://api.github.com/users/ahorek/received_events","type":"User","site_admin":false},"body":"since #3871\r\nFile.basename doesn't seem to handle the Windows-1250 encoding properly\r\n\r\nmri\r\n```bash\r\nFile.basename('/'.force_encoding('Windows-1250')).encoding\r\n#<Encoding:Windows-1250>\r\n```\r\n\r\njruby\r\n```bash\r\nFile.basename('/'.force_encoding('Windows-1250')).encoding\r\n#<Encoding:UTF-8>\r\n```\r\n\r\nhttps://github.com/jruby/jruby/blob/master/core/src/main/java/org/jruby/RubyFile.java#L584\r\n\r\ncauses a bundler failure once again\r\n```ruby\r\nEncoding::CompatibilityError: incompatible character encodings: Windows-1250 and UTF-8\r\n                    rindex at org/jruby/RubyString.java:2746\r\n             chop_basename at C:/jruby_repo/jruby/lib/ruby/stdlib/pathname.rb:44\r\n                      plus at C:/jruby_repo/jruby/lib/ruby/stdlib/pathname.rb:370\r\n                         + at C:/jruby_repo/jruby/lib/ruby/stdlib/pathname.rb:350\r\n                      join at C:/jruby_repo/jruby/lib/ruby/stdlib/pathname.rb:416\r\n          user_bundle_path at C:/jruby_repo/jruby/lib/ruby/gems/shared/gems/bundler-1.12.3/lib/bundler.rb:142\r\n        global_config_file at C:/jruby_repo/jruby/lib/ruby/gems/shared/gems/bundler-1.12.3/lib/bundler/settings.rb:216\r\n                initialize at C:/jruby_repo/jruby/lib/ruby/gems/shared/gems/bundler-1.12.3/lib/bundler/settings.rb:13\r\n                  settings at C:/jruby_repo/jruby/lib/ruby/gems/shared/gems/bundler-1.12.3/lib/bundler.rb:198\r\n                    report at C:/jruby_repo/jruby/lib/ruby/gems/shared/gems/bundler-1.12.3/lib/bundler/env.rb:28\r\n  request_issue_report_for at C:/jruby_repo/jruby/lib/ruby/gems/shared/gems/bundler-1.12.3/lib/bundler/friendly_errors.rb:74\r\n                 log_error at C:/jruby_repo/jruby/lib/ruby/gems/shared/gems/bundler-1.12.3/lib/bundler/friendly_errors.rb:40\r\n      with_friendly_errors at C:/jruby_repo/jruby/lib/ruby/gems/shared/gems/bundler-1.12.3/lib/bundler/friendly_errors.rb:100\r\n                     <top> at C:/jruby_repo/jruby/lib/ruby/gems/shared/gems/bundler-1.12.3/exe/bundle:19\r\n                      load at org/jruby/RubyKernel.java:962\r\n                     <top> at C:/jruby_repo/jruby/bin/bundle:22\r\n```","created_at":"2016-05-11T20:30:56Z","updated_at":"2016-05-12T14:01:11Z","closed_at":"2016-05-12T14:01:11Z","merged_at":null,"merge_commit_sha":"958e1be70d0d71a3046e5c6c7e822886ded3e1a3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jruby/jruby/pulls/3877/commits","review_comments_url":"https://api.github.com/repos/jruby/jruby/pulls/3877/comments","review_comment_url":"https://api.github.com/repos/jruby/jruby/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jruby/jruby/issues/3877/comments","statuses_url":"https://api.github.com/repos/jruby/jruby/statuses/ca1738f42306adf43415129962b1997cc214cade","head":{"label":"ahorek:windows1250_encoding","ref":"windows1250_encoding","sha":"ca1738f42306adf43415129962b1997cc214cade","user":{"login":"ahorek","id":9540855,"avatar_url":"https://avatars.githubusercontent.com/u/9540855?v=3","gravatar_id":"","url":"https://api.github.com/users/ahorek","html_url":"https://github.com/ahorek","followers_url":"https://api.github.com/users/ahorek/followers","following_url":"https://api.github.com/users/ahorek/following{/other_user}","gists_url":"https://api.github.com/users/ahorek/gists{/gist_id}","starred_url":"https://api.github.com/users/ahorek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahorek/subscriptions","organizations_url":"https://api.github.com/users/ahorek/orgs","repos_url":"https://api.github.com/users/ahorek/repos","events_url":"https://api.github.com/users/ahorek/events{/privacy}","received_events_url":"https://api.github.com/users/ahorek/received_events","type":"User","site_admin":false},"repo":{"id":26781632,"name":"jruby","full_name":"ahorek/jruby","owner":{"login":"ahorek","id":9540855,"avatar_url":"https://avatars.githubusercontent.com/u/9540855?v=3","gravatar_id":"","url":"https://api.github.com/users/ahorek","html_url":"https://github.com/ahorek","followers_url":"https://api.github.com/users/ahorek/followers","following_url":"https://api.github.com/users/ahorek/following{/other_user}","gists_url":"https://api.github.com/users/ahorek/gists{/gist_id}","starred_url":"https://api.github.com/users/ahorek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahorek/subscriptions","organizations_url":"https://api.github.com/users/ahorek/orgs","repos_url":"https://api.github.com/users/ahorek/repos","events_url":"https://api.github.com/users/ahorek/events{/privacy}","received_events_url":"https://api.github.com/users/ahorek/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ahorek/jruby","description":"JRuby, an implementation of Ruby on the JVM","fork":true,"url":"https://api.github.com/repos/ahorek/jruby","forks_url":"https://api.github.com/repos/ahorek/jruby/forks","keys_url":"https://api.github.com/repos/ahorek/jruby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ahorek/jruby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ahorek/jruby/teams","hooks_url":"https://api.github.com/repos/ahorek/jruby/hooks","issue_events_url":"https://api.github.com/repos/ahorek/jruby/issues/events{/number}","events_url":"https://api.github.com/repos/ahorek/jruby/events","assignees_url":"https://api.github.com/repos/ahorek/jruby/assignees{/user}","branches_url":"https://api.github.com/repos/ahorek/jruby/branches{/branch}","tags_url":"https://api.github.com/repos/ahorek/jruby/tags","blobs_url":"https://api.github.com/repos/ahorek/jruby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ahorek/jruby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ahorek/jruby/git/refs{/sha}","trees_url":"https://api.github.com/repos/ahorek/jruby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ahorek/jruby/statuses/{sha}","languages_url":"https://api.github.com/repos/ahorek/jruby/languages","stargazers_url":"https://api.github.com/repos/ahorek/jruby/stargazers","contributors_url":"https://api.github.com/repos/ahorek/jruby/contributors","subscribers_url":"https://api.github.com/repos/ahorek/jruby/subscribers","subscription_url":"https://api.github.com/repos/ahorek/jruby/subscription","commits_url":"https://api.github.com/repos/ahorek/jruby/commits{/sha}","git_commits_url":"https://api.github.com/repos/ahorek/jruby/git/commits{/sha}","comments_url":"https://api.github.com/repos/ahorek/jruby/comments{/number}","issue_comment_url":"https://api.github.com/repos/ahorek/jruby/issues/comments{/number}","contents_url":"https://api.github.com/repos/ahorek/jruby/contents/{+path}","compare_url":"https://api.github.com/repos/ahorek/jruby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ahorek/jruby/merges","archive_url":"https://api.github.com/repos/ahorek/jruby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ahorek/jruby/downloads","issues_url":"https://api.github.com/repos/ahorek/jruby/issues{/number}","pulls_url":"https://api.github.com/repos/ahorek/jruby/pulls{/number}","milestones_url":"https://api.github.com/repos/ahorek/jruby/milestones{/number}","notifications_url":"https://api.github.com/repos/ahorek/jruby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ahorek/jruby/labels{/name}","releases_url":"https://api.github.com/repos/ahorek/jruby/releases{/id}","deployments_url":"https://api.github.com/repos/ahorek/jruby/deployments","created_at":"2014-11-17T23:04:38Z","updated_at":"2014-11-17T23:04:54Z","pushed_at":"2016-05-12T00:53:53Z","git_url":"git://github.com/ahorek/jruby.git","ssh_url":"git@github.com:ahorek/jruby.git","clone_url":"https://github.com/ahorek/jruby.git","svn_url":"https://github.com/ahorek/jruby","homepage":"http://www.jruby.org","size":208160,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jruby:master","ref":"master","sha":"1ceddaaec787be7d195e565ba36c2fbd483d78dc","user":{"login":"jruby","id":55687,"avatar_url":"https://avatars.githubusercontent.com/u/55687?v=3","gravatar_id":"","url":"https://api.github.com/users/jruby","html_url":"https://github.com/jruby","followers_url":"https://api.github.com/users/jruby/followers","following_url":"https://api.github.com/users/jruby/following{/other_user}","gists_url":"https://api.github.com/users/jruby/gists{/gist_id}","starred_url":"https://api.github.com/users/jruby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jruby/subscriptions","organizations_url":"https://api.github.com/users/jruby/orgs","repos_url":"https://api.github.com/users/jruby/repos","events_url":"https://api.github.com/users/jruby/events{/privacy}","received_events_url":"https://api.github.com/users/jruby/received_events","type":"Organization","site_admin":false},"repo":{"id":168370,"name":"jruby","full_name":"jruby/jruby","owner":{"login":"jruby","id":55687,"avatar_url":"https://avatars.githubusercontent.com/u/55687?v=3","gravatar_id":"","url":"https://api.github.com/users/jruby","html_url":"https://github.com/jruby","followers_url":"https://api.github.com/users/jruby/followers","following_url":"https://api.github.com/users/jruby/following{/other_user}","gists_url":"https://api.github.com/users/jruby/gists{/gist_id}","starred_url":"https://api.github.com/users/jruby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jruby/subscriptions","organizations_url":"https://api.github.com/users/jruby/orgs","repos_url":"https://api.github.com/users/jruby/repos","events_url":"https://api.github.com/users/jruby/events{/privacy}","received_events_url":"https://api.github.com/users/jruby/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jruby/jruby","description":"JRuby, an implementation of Ruby on the JVM","fork":false,"url":"https://api.github.com/repos/jruby/jruby","forks_url":"https://api.github.com/repos/jruby/jruby/forks","keys_url":"https://api.github.com/repos/jruby/jruby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jruby/jruby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jruby/jruby/teams","hooks_url":"https://api.github.com/repos/jruby/jruby/hooks","issue_events_url":"https://api.github.com/repos/jruby/jruby/issues/events{/number}","events_url":"https://api.github.com/repos/jruby/jruby/events","assignees_url":"https://api.github.com/repos/jruby/jruby/assignees{/user}","branches_url":"https://api.github.com/repos/jruby/jruby/branches{/branch}","tags_url":"https://api.github.com/repos/jruby/jruby/tags","blobs_url":"https://api.github.com/repos/jruby/jruby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jruby/jruby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jruby/jruby/git/refs{/sha}","trees_url":"https://api.github.com/repos/jruby/jruby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jruby/jruby/statuses/{sha}","languages_url":"https://api.github.com/repos/jruby/jruby/languages","stargazers_url":"https://api.github.com/repos/jruby/jruby/stargazers","contributors_url":"https://api.github.com/repos/jruby/jruby/contributors","subscribers_url":"https://api.github.com/repos/jruby/jruby/subscribers","subscription_url":"https://api.github.com/repos/jruby/jruby/subscription","commits_url":"https://api.github.com/repos/jruby/jruby/commits{/sha}","git_commits_url":"https://api.github.com/repos/jruby/jruby/git/commits{/sha}","comments_url":"https://api.github.com/repos/jruby/jruby/comments{/number}","issue_comment_url":"https://api.github.com/repos/jruby/jruby/issues/comments{/number}","contents_url":"https://api.github.com/repos/jruby/jruby/contents/{+path}","compare_url":"https://api.github.com/repos/jruby/jruby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jruby/jruby/merges","archive_url":"https://api.github.com/repos/jruby/jruby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jruby/jruby/downloads","issues_url":"https://api.github.com/repos/jruby/jruby/issues{/number}","pulls_url":"https://api.github.com/repos/jruby/jruby/pulls{/number}","milestones_url":"https://api.github.com/repos/jruby/jruby/milestones{/number}","notifications_url":"https://api.github.com/repos/jruby/jruby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jruby/jruby/labels{/name}","releases_url":"https://api.github.com/repos/jruby/jruby/releases{/id}","deployments_url":"https://api.github.com/repos/jruby/jruby/deployments","created_at":"2009-04-05T03:54:35Z","updated_at":"2016-05-12T07:41:25Z","pushed_at":"2016-05-12T14:01:09Z","git_url":"git://github.com/jruby/jruby.git","ssh_url":"git@github.com:jruby/jruby.git","clone_url":"https://github.com/jruby/jruby.git","svn_url":"https://github.com/jruby/jruby","homepage":"http://www.jruby.org","size":293386,"stargazers_count":2517,"watchers_count":2517,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":652,"mirror_url":null,"open_issues_count":763,"forks":652,"open_issues":763,"watchers":2517,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jruby/jruby/pulls/3877"},"html":{"href":"https://github.com/jruby/jruby/pull/3877"},"issue":{"href":"https://api.github.com/repos/jruby/jruby/issues/3877"},"comments":{"href":"https://api.github.com/repos/jruby/jruby/issues/3877/comments"},"review_comments":{"href":"https://api.github.com/repos/jruby/jruby/pulls/3877/comments"},"review_comment":{"href":"https://api.github.com/repos/jruby/jruby/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jruby/jruby/pulls/3877/commits"},"statuses":{"href":"https://api.github.com/repos/jruby/jruby/statuses/ca1738f42306adf43415129962b1997cc214cade"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":8,"review_comments":0,"commits":1,"additions":4,"deletions":0,"changed_files":1}}