{"action":"created","issue":{"url":"https://api.github.com/repos/jenkinsci/jenkins/issues/2302","repository_url":"https://api.github.com/repos/jenkinsci/jenkins","labels_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/2302/labels{/name}","comments_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/2302/comments","events_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/2302/events","html_url":"https://github.com/jenkinsci/jenkins/pull/2302","id":152187559,"number":2302,"title":"make build log always use master’s encoding","user":{"login":"ndeloof","id":132757,"avatar_url":"https://avatars.githubusercontent.com/u/132757?v=3","gravatar_id":"","url":"https://api.github.com/users/ndeloof","html_url":"https://github.com/ndeloof","followers_url":"https://api.github.com/users/ndeloof/followers","following_url":"https://api.github.com/users/ndeloof/following{/other_user}","gists_url":"https://api.github.com/users/ndeloof/gists{/gist_id}","starred_url":"https://api.github.com/users/ndeloof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ndeloof/subscriptions","organizations_url":"https://api.github.com/users/ndeloof/orgs","repos_url":"https://api.github.com/users/ndeloof/repos","events_url":"https://api.github.com/users/ndeloof/events{/privacy}","received_events_url":"https://api.github.com/users/ndeloof/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/jenkinsci/jenkins/labels/needs-review","name":"needs-review","color":"207de5"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-05-01T08:21:02Z","updated_at":"2016-05-02T09:54:18Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/2302","html_url":"https://github.com/jenkinsci/jenkins/pull/2302","diff_url":"https://github.com/jenkinsci/jenkins/pull/2302.diff","patch_url":"https://github.com/jenkinsci/jenkins/pull/2302.patch"},"body":"Jenkins used to rely on build node's encoding as it pipe remote processes output as-is in log file.\r\nThis PR is about converting external process output from build node local encoding into master’s encoding. As a result, all logs on master use local platform encoding, and as a side-effet (considering my primary goal to implement [one-shot-executor](https://github.com/jenkinsci/one-shot-executor-plugin/)) we don't need to check build computer for encoding to create build log, so can postpone actual computer launch."},"comment":{"url":"https://api.github.com/repos/jenkinsci/jenkins/issues/comments/216182875","html_url":"https://github.com/jenkinsci/jenkins/pull/2302#issuecomment-216182875","issue_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/2302","id":216182875,"user":{"login":"ndeloof","id":132757,"avatar_url":"https://avatars.githubusercontent.com/u/132757?v=3","gravatar_id":"","url":"https://api.github.com/users/ndeloof","html_url":"https://github.com/ndeloof","followers_url":"https://api.github.com/users/ndeloof/followers","following_url":"https://api.github.com/users/ndeloof/following{/other_user}","gists_url":"https://api.github.com/users/ndeloof/gists{/gist_id}","starred_url":"https://api.github.com/users/ndeloof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ndeloof/subscriptions","organizations_url":"https://api.github.com/users/ndeloof/orgs","repos_url":"https://api.github.com/users/ndeloof/repos","events_url":"https://api.github.com/users/ndeloof/events{/privacy}","received_events_url":"https://api.github.com/users/ndeloof/received_events","type":"User","site_admin":false},"created_at":"2016-05-02T09:54:17Z","updated_at":"2016-05-02T09:54:17Z","body":"implemented as https://github.com/jenkinsci/jenkins/pull/2302/commits/f46c40ab5fb116badc9e336c046af61f88cd364f with fallback to Charset.defaultCharset. \r\nI'm not a big fan on this, in such circumstances I prefer some backward incompatibility - there's time we need some."}}