{"action":"created","comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments/75017262","id":75017262,"diff_hunk":"@@ -1437,6 +1437,11 @@ func splitTriggerPostCommit(\n \tr.store.replicateQueue.MaybeAdd(r, now)\n \tr.store.replicateQueue.MaybeAdd(rightRng, now)\n \n+\t// After a split, the newly create right-hand side range needs to be enqueued","path":"storage/store.go","position":4,"original_position":4,"commit_id":"6fc744002c9b79361a6a7bced8e79150e2fbbd45","original_commit_id":"0593fdc801aa5f8bf4b4c47e35d72883b12b6f4e","user":{"login":"spencerkimball","id":6147149,"avatar_url":"https://avatars.githubusercontent.com/u/6147149?v=3","gravatar_id":"","url":"https://api.github.com/users/spencerkimball","html_url":"https://github.com/spencerkimball","followers_url":"https://api.github.com/users/spencerkimball/followers","following_url":"https://api.github.com/users/spencerkimball/following{/other_user}","gists_url":"https://api.github.com/users/spencerkimball/gists{/gist_id}","starred_url":"https://api.github.com/users/spencerkimball/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spencerkimball/subscriptions","organizations_url":"https://api.github.com/users/spencerkimball/orgs","repos_url":"https://api.github.com/users/spencerkimball/repos","events_url":"https://api.github.com/users/spencerkimball/events{/privacy}","received_events_url":"https://api.github.com/users/spencerkimball/received_events","type":"User","site_admin":false},"body":"s/create/created/","created_at":"2016-08-16T20:49:47Z","updated_at":"2016-08-16T20:49:47Z","html_url":"https://github.com/cockroachdb/cockroach/pull/8592#discussion_r75017262","pull_request_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/8592","_links":{"self":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments/75017262"},"html":{"href":"https://github.com/cockroachdb/cockroach/pull/8592#discussion_r75017262"},"pull_request":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/8592"}}},"pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/8592","id":81534885,"html_url":"https://github.com/cockroachdb/cockroach/pull/8592","diff_url":"https://github.com/cockroachdb/cockroach/pull/8592.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/8592.patch","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/8592","number":8592,"state":"open","locked":false,"title":"storage: make Raft group creation really lazy","user":{"login":"petermattis","id":6201335,"avatar_url":"https://avatars.githubusercontent.com/u/6201335?v=3","gravatar_id":"","url":"https://api.github.com/users/petermattis","html_url":"https://github.com/petermattis","followers_url":"https://api.github.com/users/petermattis/followers","following_url":"https://api.github.com/users/petermattis/following{/other_user}","gists_url":"https://api.github.com/users/petermattis/gists{/gist_id}","starred_url":"https://api.github.com/users/petermattis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petermattis/subscriptions","organizations_url":"https://api.github.com/users/petermattis/orgs","repos_url":"https://api.github.com/users/petermattis/repos","events_url":"https://api.github.com/users/petermattis/events{/privacy}","received_events_url":"https://api.github.com/users/petermattis/received_events","type":"User","site_admin":false},"body":"At startup a store loops over all of the local range descriptors and\ncreates replicas. These replicas would then be \"ticked\" by the process\nraft goroutine. We attempted to have the raft group lazily created by\nmaking Replica.tick() a no-op if there wasn't a Raft group. But\nimmediately after the ticking we would add the replica to the set of\npending replicas and on the next iteration would call\nReplica.handleRaftReady() which would then create the Raft group.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/cockroachdb/cockroach/8592)\n<!-- Reviewable:end -->\n","created_at":"2016-08-16T20:02:37Z","updated_at":"2016-08-16T20:49:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7fff8a3b25755e9a52d753ca1ca002f655961a1a","assignee":{"login":"bdarnell","id":160562,"avatar_url":"https://avatars.githubusercontent.com/u/160562?v=3","gravatar_id":"","url":"https://api.github.com/users/bdarnell","html_url":"https://github.com/bdarnell","followers_url":"https://api.github.com/users/bdarnell/followers","following_url":"https://api.github.com/users/bdarnell/following{/other_user}","gists_url":"https://api.github.com/users/bdarnell/gists{/gist_id}","starred_url":"https://api.github.com/users/bdarnell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdarnell/subscriptions","organizations_url":"https://api.github.com/users/bdarnell/orgs","repos_url":"https://api.github.com/users/bdarnell/repos","events_url":"https://api.github.com/users/bdarnell/events{/privacy}","received_events_url":"https://api.github.com/users/bdarnell/received_events","type":"User","site_admin":false},"assignees":[{"login":"bdarnell","id":160562,"avatar_url":"https://avatars.githubusercontent.com/u/160562?v=3","gravatar_id":"","url":"https://api.github.com/users/bdarnell","html_url":"https://github.com/bdarnell","followers_url":"https://api.github.com/users/bdarnell/followers","following_url":"https://api.github.com/users/bdarnell/following{/other_user}","gists_url":"https://api.github.com/users/bdarnell/gists{/gist_id}","starred_url":"https://api.github.com/users/bdarnell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdarnell/subscriptions","organizations_url":"https://api.github.com/users/bdarnell/orgs","repos_url":"https://api.github.com/users/bdarnell/repos","events_url":"https://api.github.com/users/bdarnell/events{/privacy}","received_events_url":"https://api.github.com/users/bdarnell/received_events","type":"User","site_admin":false},{"login":"spencerkimball","id":6147149,"avatar_url":"https://avatars.githubusercontent.com/u/6147149?v=3","gravatar_id":"","url":"https://api.github.com/users/spencerkimball","html_url":"https://github.com/spencerkimball","followers_url":"https://api.github.com/users/spencerkimball/followers","following_url":"https://api.github.com/users/spencerkimball/following{/other_user}","gists_url":"https://api.github.com/users/spencerkimball/gists{/gist_id}","starred_url":"https://api.github.com/users/spencerkimball/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spencerkimball/subscriptions","organizations_url":"https://api.github.com/users/spencerkimball/orgs","repos_url":"https://api.github.com/users/spencerkimball/repos","events_url":"https://api.github.com/users/spencerkimball/events{/privacy}","received_events_url":"https://api.github.com/users/spencerkimball/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/8592/commits","review_comments_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/8592/comments","review_comment_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/8592/comments","statuses_url":"https://api.github.com/repos/cockroachdb/cockroach/statuses/6fc744002c9b79361a6a7bced8e79150e2fbbd45","head":{"label":"petermattis:pmattis/really-lazy-raft-groups","ref":"pmattis/really-lazy-raft-groups","sha":"6fc744002c9b79361a6a7bced8e79150e2fbbd45","user":{"login":"petermattis","id":6201335,"avatar_url":"https://avatars.githubusercontent.com/u/6201335?v=3","gravatar_id":"","url":"https://api.github.com/users/petermattis","html_url":"https://github.com/petermattis","followers_url":"https://api.github.com/users/petermattis/followers","following_url":"https://api.github.com/users/petermattis/following{/other_user}","gists_url":"https://api.github.com/users/petermattis/gists{/gist_id}","starred_url":"https://api.github.com/users/petermattis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petermattis/subscriptions","organizations_url":"https://api.github.com/users/petermattis/orgs","repos_url":"https://api.github.com/users/petermattis/repos","events_url":"https://api.github.com/users/petermattis/events{/privacy}","received_events_url":"https://api.github.com/users/petermattis/received_events","type":"User","site_admin":false},"repo":{"id":49213713,"name":"cockroach","full_name":"petermattis/cockroach","owner":{"login":"petermattis","id":6201335,"avatar_url":"https://avatars.githubusercontent.com/u/6201335?v=3","gravatar_id":"","url":"https://api.github.com/users/petermattis","html_url":"https://github.com/petermattis","followers_url":"https://api.github.com/users/petermattis/followers","following_url":"https://api.github.com/users/petermattis/following{/other_user}","gists_url":"https://api.github.com/users/petermattis/gists{/gist_id}","starred_url":"https://api.github.com/users/petermattis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petermattis/subscriptions","organizations_url":"https://api.github.com/users/petermattis/orgs","repos_url":"https://api.github.com/users/petermattis/repos","events_url":"https://api.github.com/users/petermattis/events{/privacy}","received_events_url":"https://api.github.com/users/petermattis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/petermattis/cockroach","description":"A Scalable, Survivable, Strongly-Consistent SQL Database","fork":true,"url":"https://api.github.com/repos/petermattis/cockroach","forks_url":"https://api.github.com/repos/petermattis/cockroach/forks","keys_url":"https://api.github.com/repos/petermattis/cockroach/keys{/key_id}","collaborators_url":"https://api.github.com/repos/petermattis/cockroach/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/petermattis/cockroach/teams","hooks_url":"https://api.github.com/repos/petermattis/cockroach/hooks","issue_events_url":"https://api.github.com/repos/petermattis/cockroach/issues/events{/number}","events_url":"https://api.github.com/repos/petermattis/cockroach/events","assignees_url":"https://api.github.com/repos/petermattis/cockroach/assignees{/user}","branches_url":"https://api.github.com/repos/petermattis/cockroach/branches{/branch}","tags_url":"https://api.github.com/repos/petermattis/cockroach/tags","blobs_url":"https://api.github.com/repos/petermattis/cockroach/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/petermattis/cockroach/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/petermattis/cockroach/git/refs{/sha}","trees_url":"https://api.github.com/repos/petermattis/cockroach/git/trees{/sha}","statuses_url":"https://api.github.com/repos/petermattis/cockroach/statuses/{sha}","languages_url":"https://api.github.com/repos/petermattis/cockroach/languages","stargazers_url":"https://api.github.com/repos/petermattis/cockroach/stargazers","contributors_url":"https://api.github.com/repos/petermattis/cockroach/contributors","subscribers_url":"https://api.github.com/repos/petermattis/cockroach/subscribers","subscription_url":"https://api.github.com/repos/petermattis/cockroach/subscription","commits_url":"https://api.github.com/repos/petermattis/cockroach/commits{/sha}","git_commits_url":"https://api.github.com/repos/petermattis/cockroach/git/commits{/sha}","comments_url":"https://api.github.com/repos/petermattis/cockroach/comments{/number}","issue_comment_url":"https://api.github.com/repos/petermattis/cockroach/issues/comments{/number}","contents_url":"https://api.github.com/repos/petermattis/cockroach/contents/{+path}","compare_url":"https://api.github.com/repos/petermattis/cockroach/compare/{base}...{head}","merges_url":"https://api.github.com/repos/petermattis/cockroach/merges","archive_url":"https://api.github.com/repos/petermattis/cockroach/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/petermattis/cockroach/downloads","issues_url":"https://api.github.com/repos/petermattis/cockroach/issues{/number}","pulls_url":"https://api.github.com/repos/petermattis/cockroach/pulls{/number}","milestones_url":"https://api.github.com/repos/petermattis/cockroach/milestones{/number}","notifications_url":"https://api.github.com/repos/petermattis/cockroach/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/petermattis/cockroach/labels{/name}","releases_url":"https://api.github.com/repos/petermattis/cockroach/releases{/id}","deployments_url":"https://api.github.com/repos/petermattis/cockroach/deployments","created_at":"2016-01-07T15:46:02Z","updated_at":"2016-06-27T02:20:29Z","pushed_at":"2016-08-16T20:49:12Z","git_url":"git://github.com/petermattis/cockroach.git","ssh_url":"git@github.com:petermattis/cockroach.git","clone_url":"https://github.com/petermattis/cockroach.git","svn_url":"https://github.com/petermattis/cockroach","homepage":"http://www.cockroachlabs.com","size":193190,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"cockroachdb:master","ref":"master","sha":"f0d0875de3a885243227be936673aa1bf89223f0","user":{"login":"cockroachdb","id":6748139,"avatar_url":"https://avatars.githubusercontent.com/u/6748139?v=3","gravatar_id":"","url":"https://api.github.com/users/cockroachdb","html_url":"https://github.com/cockroachdb","followers_url":"https://api.github.com/users/cockroachdb/followers","following_url":"https://api.github.com/users/cockroachdb/following{/other_user}","gists_url":"https://api.github.com/users/cockroachdb/gists{/gist_id}","starred_url":"https://api.github.com/users/cockroachdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockroachdb/subscriptions","organizations_url":"https://api.github.com/users/cockroachdb/orgs","repos_url":"https://api.github.com/users/cockroachdb/repos","events_url":"https://api.github.com/users/cockroachdb/events{/privacy}","received_events_url":"https://api.github.com/users/cockroachdb/received_events","type":"Organization","site_admin":false},"repo":{"id":16563587,"name":"cockroach","full_name":"cockroachdb/cockroach","owner":{"login":"cockroachdb","id":6748139,"avatar_url":"https://avatars.githubusercontent.com/u/6748139?v=3","gravatar_id":"","url":"https://api.github.com/users/cockroachdb","html_url":"https://github.com/cockroachdb","followers_url":"https://api.github.com/users/cockroachdb/followers","following_url":"https://api.github.com/users/cockroachdb/following{/other_user}","gists_url":"https://api.github.com/users/cockroachdb/gists{/gist_id}","starred_url":"https://api.github.com/users/cockroachdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockroachdb/subscriptions","organizations_url":"https://api.github.com/users/cockroachdb/orgs","repos_url":"https://api.github.com/users/cockroachdb/repos","events_url":"https://api.github.com/users/cockroachdb/events{/privacy}","received_events_url":"https://api.github.com/users/cockroachdb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cockroachdb/cockroach","description":"A Scalable, Survivable, Strongly-Consistent SQL Database","fork":false,"url":"https://api.github.com/repos/cockroachdb/cockroach","forks_url":"https://api.github.com/repos/cockroachdb/cockroach/forks","keys_url":"https://api.github.com/repos/cockroachdb/cockroach/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cockroachdb/cockroach/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cockroachdb/cockroach/teams","hooks_url":"https://api.github.com/repos/cockroachdb/cockroach/hooks","issue_events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/events{/number}","events_url":"https://api.github.com/repos/cockroachdb/cockroach/events","assignees_url":"https://api.github.com/repos/cockroachdb/cockroach/assignees{/user}","branches_url":"https://api.github.com/repos/cockroachdb/cockroach/branches{/branch}","tags_url":"https://api.github.com/repos/cockroachdb/cockroach/tags","blobs_url":"https://api.github.com/repos/cockroachdb/cockroach/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cockroachdb/cockroach/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cockroachdb/cockroach/git/refs{/sha}","trees_url":"https://api.github.com/repos/cockroachdb/cockroach/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cockroachdb/cockroach/statuses/{sha}","languages_url":"https://api.github.com/repos/cockroachdb/cockroach/languages","stargazers_url":"https://api.github.com/repos/cockroachdb/cockroach/stargazers","contributors_url":"https://api.github.com/repos/cockroachdb/cockroach/contributors","subscribers_url":"https://api.github.com/repos/cockroachdb/cockroach/subscribers","subscription_url":"https://api.github.com/repos/cockroachdb/cockroach/subscription","commits_url":"https://api.github.com/repos/cockroachdb/cockroach/commits{/sha}","git_commits_url":"https://api.github.com/repos/cockroachdb/cockroach/git/commits{/sha}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/comments{/number}","issue_comment_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments{/number}","contents_url":"https://api.github.com/repos/cockroachdb/cockroach/contents/{+path}","compare_url":"https://api.github.com/repos/cockroachdb/cockroach/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cockroachdb/cockroach/merges","archive_url":"https://api.github.com/repos/cockroachdb/cockroach/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cockroachdb/cockroach/downloads","issues_url":"https://api.github.com/repos/cockroachdb/cockroach/issues{/number}","pulls_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls{/number}","milestones_url":"https://api.github.com/repos/cockroachdb/cockroach/milestones{/number}","notifications_url":"https://api.github.com/repos/cockroachdb/cockroach/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/labels{/name}","releases_url":"https://api.github.com/repos/cockroachdb/cockroach/releases{/id}","deployments_url":"https://api.github.com/repos/cockroachdb/cockroach/deployments","created_at":"2014-02-06T00:18:47Z","updated_at":"2016-08-16T09:52:23Z","pushed_at":"2016-08-16T20:49:17Z","git_url":"git://github.com/cockroachdb/cockroach.git","ssh_url":"git@github.com:cockroachdb/cockroach.git","clone_url":"https://github.com/cockroachdb/cockroach.git","svn_url":"https://github.com/cockroachdb/cockroach","homepage":"https://www.cockroachlabs.com","size":309663,"stargazers_count":7383,"watchers_count":7383,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":728,"mirror_url":null,"open_issues_count":580,"forks":728,"open_issues":580,"watchers":7383,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/8592"},"html":{"href":"https://github.com/cockroachdb/cockroach/pull/8592"},"issue":{"href":"https://api.github.com/repos/cockroachdb/cockroach/issues/8592"},"comments":{"href":"https://api.github.com/repos/cockroachdb/cockroach/issues/8592/comments"},"review_comments":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/8592/comments"},"review_comment":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/8592/commits"},"statuses":{"href":"https://api.github.com/repos/cockroachdb/cockroach/statuses/6fc744002c9b79361a6a7bced8e79150e2fbbd45"}}}}
{"actor":{"display_login":"spencerkimball"}}