{"action":"created","issue":{"url":"https://api.github.com/repos/devtools-html/debugger.html/issues/1179","repository_url":"https://api.github.com/repos/devtools-html/debugger.html","labels_url":"https://api.github.com/repos/devtools-html/debugger.html/issues/1179/labels{/name}","comments_url":"https://api.github.com/repos/devtools-html/debugger.html/issues/1179/comments","events_url":"https://api.github.com/repos/devtools-html/debugger.html/issues/1179/events","html_url":"https://github.com/devtools-html/debugger.html/pull/1179","id":188987149,"number":1179,"title":"Added Flow types to pause actions and reducer","user":{"login":"montogeek","id":1002461,"avatar_url":"https://avatars.githubusercontent.com/u/1002461?v=3","gravatar_id":"","url":"https://api.github.com/users/montogeek","html_url":"https://github.com/montogeek","followers_url":"https://api.github.com/users/montogeek/followers","following_url":"https://api.github.com/users/montogeek/following{/other_user}","gists_url":"https://api.github.com/users/montogeek/gists{/gist_id}","starred_url":"https://api.github.com/users/montogeek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/montogeek/subscriptions","organizations_url":"https://api.github.com/users/montogeek/orgs","repos_url":"https://api.github.com/users/montogeek/repos","events_url":"https://api.github.com/users/montogeek/events{/privacy}","received_events_url":"https://api.github.com/users/montogeek/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-11-13T18:57:16Z","updated_at":"2016-11-16T18:16:47Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/devtools-html/debugger.html/pulls/1179","html_url":"https://github.com/devtools-html/debugger.html/pull/1179","diff_url":"https://github.com/devtools-html/debugger.html/pull/1179.diff","patch_url":"https://github.com/devtools-html/debugger.html/pull/1179.patch"},"body":"Associated Issue: #1004 \r\n\r\n### Summary of Changes\r\n\r\nAdded Flow types to pause actions\r\nAdded Flow types to pause reducers\r\n\r\n### Testing\r\n\r\n[x] passes `npm test`\r\n[x] passes `npm run lint`\r\n\r\nNotes:\r\nFlow version: 0.35.0, I used the last one since it was not specified in `.flowconfig`, although 0.34.0 is specified in `package.json`, it took the chance to use the last version.\r\n\r\n- There are errors related with the `fromJS` utility, since it is not Flow typed.\r\n- Flow 0.35.0 started complaining about these lines https://github.com/devtools-html/debugger.html/blob/master/public/js/utils/utils.js#L207 and https://github.com/devtools-html/debugger.html/blob/master/packages/devtools-local-toolbox/public/js/utils/utils.js#L163 with the error: `call of method assign: Expected object instead of T`\r\n- `pause` reducer (https://github.com/devtools-html/debugger.html/blob/master/public/js/reducers/pause.js#L41) is handling an `source` action (https://github.com/devtools-html/debugger.html/blob/master/public/js/actions/sources.js#L195)\r\n- This constant/action does not longer exists: https://github.com/devtools-html/debugger.html/blob/master/public/js/reducers/pause.js#L56\r\n- Unfortunately Flow does not support object computed keys in Object type declarations, thats why this is hardcoded: https://github.com/devtools-html/debugger.html/compare/master...montogeek:flow-type-pause-actions-reducer?expand=1#diff-195a73de407881358c8dfc0c5891f7feR114\r\n"},"comment":{"url":"https://api.github.com/repos/devtools-html/debugger.html/issues/comments/261026356","html_url":"https://github.com/devtools-html/debugger.html/pull/1179#issuecomment-261026356","issue_url":"https://api.github.com/repos/devtools-html/debugger.html/issues/1179","id":261026356,"user":{"login":"montogeek","id":1002461,"avatar_url":"https://avatars.githubusercontent.com/u/1002461?v=3","gravatar_id":"","url":"https://api.github.com/users/montogeek","html_url":"https://github.com/montogeek","followers_url":"https://api.github.com/users/montogeek/followers","following_url":"https://api.github.com/users/montogeek/following{/other_user}","gists_url":"https://api.github.com/users/montogeek/gists{/gist_id}","starred_url":"https://api.github.com/users/montogeek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/montogeek/subscriptions","organizations_url":"https://api.github.com/users/montogeek/orgs","repos_url":"https://api.github.com/users/montogeek/repos","events_url":"https://api.github.com/users/montogeek/events{/privacy}","received_events_url":"https://api.github.com/users/montogeek/received_events","type":"User","site_admin":false},"created_at":"2016-11-16T18:16:47Z","updated_at":"2016-11-16T18:16:47Z","body":"@jasonLaster Thank you so much! Sorry for not catching those details!"}}
{"actor":{"display_login":"montogeek"}}