{"action":"created","comment":{"url":"https://api.github.com/repos/Polymer/polymer-analyzer/pulls/comments/76159516","id":76159516,"diff_hunk":"@@ -0,0 +1,27 @@\n+/**\n+ * @license\n+ * Copyright (c) 2016 The Polymer Project Authors. All rights reserved.\n+ * This code may only be used under the BSD style license found at\n+ * http://polymer.github.io/LICENSE.txt\n+ * The complete set of authors may be found at\n+ * http://polymer.github.io/AUTHORS.txt\n+ * The complete set of contributors may be found at\n+ * http://polymer.github.io/CONTRIBUTORS.txt\n+ * Code distributed by Google as part of the polymer project is also\n+ * subject to an additional IP rights grant found at\n+ * http://polymer.github.io/PATENTS.txt\n+ */\n+\n+export interface SourceRange {\n+  /* The resolved path to the file. */\n+  file: string;","path":"src/ast/source-range.ts","position":17,"original_position":17,"commit_id":"635e08dab09ceed07e327488ccbf946d1ec8dc1a","original_commit_id":"635e08dab09ceed07e327488ccbf946d1ec8dc1a","user":{"login":"rictic","id":1659,"avatar_url":"https://avatars.githubusercontent.com/u/1659?v=3","gravatar_id":"","url":"https://api.github.com/users/rictic","html_url":"https://github.com/rictic","followers_url":"https://api.github.com/users/rictic/followers","following_url":"https://api.github.com/users/rictic/following{/other_user}","gists_url":"https://api.github.com/users/rictic/gists{/gist_id}","starred_url":"https://api.github.com/users/rictic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rictic/subscriptions","organizations_url":"https://api.github.com/users/rictic/orgs","repos_url":"https://api.github.com/users/rictic/repos","events_url":"https://api.github.com/users/rictic/events{/privacy}","received_events_url":"https://api.github.com/users/rictic/received_events","type":"User","site_admin":false},"body":"Aren't we operating on a principle of avoiding pointers back up? I'd also add that all current uses of source ranges want string file urls, which suggests to me that this is the more useful format.","created_at":"2016-08-24T23:42:10Z","updated_at":"2016-08-24T23:42:10Z","html_url":"https://github.com/Polymer/polymer-analyzer/pull/290#discussion_r76159516","pull_request_url":"https://api.github.com/repos/Polymer/polymer-analyzer/pulls/290","_links":{"self":{"href":"https://api.github.com/repos/Polymer/polymer-analyzer/pulls/comments/76159516"},"html":{"href":"https://github.com/Polymer/polymer-analyzer/pull/290#discussion_r76159516"},"pull_request":{"href":"https://api.github.com/repos/Polymer/polymer-analyzer/pulls/290"}}},"pull_request":{"url":"https://api.github.com/repos/Polymer/polymer-analyzer/pulls/290","id":81876001,"html_url":"https://github.com/Polymer/polymer-analyzer/pull/290","diff_url":"https://github.com/Polymer/polymer-analyzer/pull/290.diff","patch_url":"https://github.com/Polymer/polymer-analyzer/pull/290.patch","issue_url":"https://api.github.com/repos/Polymer/polymer-analyzer/issues/290","number":290,"state":"open","locked":false,"title":"Source ranges are better than locations","user":{"login":"rictic","id":1659,"avatar_url":"https://avatars.githubusercontent.com/u/1659?v=3","gravatar_id":"","url":"https://api.github.com/users/rictic","html_url":"https://github.com/rictic","followers_url":"https://api.github.com/users/rictic/followers","following_url":"https://api.github.com/users/rictic/following{/other_user}","gists_url":"https://api.github.com/users/rictic/gists{/gist_id}","starred_url":"https://api.github.com/users/rictic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rictic/subscriptions","organizations_url":"https://api.github.com/users/rictic/orgs","repos_url":"https://api.github.com/users/rictic/repos","events_url":"https://api.github.com/users/rictic/events{/privacy}","received_events_url":"https://api.github.com/users/rictic/received_events","type":"User","site_admin":false},"body":"* Also gives the responsibility of producing SourceRanges from Nodes to the Document\r\n\r\nCommits are pretty logical, but the end point also looks pretty skimmable.\r\n","created_at":"2016-08-18T19:45:33Z","updated_at":"2016-08-24T23:42:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"038a500d612bc8b26f82dfa059d83faf26fb713a","assignee":{"login":"justinfagnani","id":522948,"avatar_url":"https://avatars.githubusercontent.com/u/522948?v=3","gravatar_id":"","url":"https://api.github.com/users/justinfagnani","html_url":"https://github.com/justinfagnani","followers_url":"https://api.github.com/users/justinfagnani/followers","following_url":"https://api.github.com/users/justinfagnani/following{/other_user}","gists_url":"https://api.github.com/users/justinfagnani/gists{/gist_id}","starred_url":"https://api.github.com/users/justinfagnani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinfagnani/subscriptions","organizations_url":"https://api.github.com/users/justinfagnani/orgs","repos_url":"https://api.github.com/users/justinfagnani/repos","events_url":"https://api.github.com/users/justinfagnani/events{/privacy}","received_events_url":"https://api.github.com/users/justinfagnani/received_events","type":"User","site_admin":false},"assignees":[{"login":"justinfagnani","id":522948,"avatar_url":"https://avatars.githubusercontent.com/u/522948?v=3","gravatar_id":"","url":"https://api.github.com/users/justinfagnani","html_url":"https://github.com/justinfagnani","followers_url":"https://api.github.com/users/justinfagnani/followers","following_url":"https://api.github.com/users/justinfagnani/following{/other_user}","gists_url":"https://api.github.com/users/justinfagnani/gists{/gist_id}","starred_url":"https://api.github.com/users/justinfagnani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinfagnani/subscriptions","organizations_url":"https://api.github.com/users/justinfagnani/orgs","repos_url":"https://api.github.com/users/justinfagnani/repos","events_url":"https://api.github.com/users/justinfagnani/events{/privacy}","received_events_url":"https://api.github.com/users/justinfagnani/received_events","type":"User","site_admin":false},{"login":"FredKSchott","id":622227,"avatar_url":"https://avatars.githubusercontent.com/u/622227?v=3","gravatar_id":"","url":"https://api.github.com/users/FredKSchott","html_url":"https://github.com/FredKSchott","followers_url":"https://api.github.com/users/FredKSchott/followers","following_url":"https://api.github.com/users/FredKSchott/following{/other_user}","gists_url":"https://api.github.com/users/FredKSchott/gists{/gist_id}","starred_url":"https://api.github.com/users/FredKSchott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FredKSchott/subscriptions","organizations_url":"https://api.github.com/users/FredKSchott/orgs","repos_url":"https://api.github.com/users/FredKSchott/repos","events_url":"https://api.github.com/users/FredKSchott/events{/privacy}","received_events_url":"https://api.github.com/users/FredKSchott/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Polymer/polymer-analyzer/pulls/290/commits","review_comments_url":"https://api.github.com/repos/Polymer/polymer-analyzer/pulls/290/comments","review_comment_url":"https://api.github.com/repos/Polymer/polymer-analyzer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Polymer/polymer-analyzer/issues/290/comments","statuses_url":"https://api.github.com/repos/Polymer/polymer-analyzer/statuses/635e08dab09ceed07e327488ccbf946d1ec8dc1a","head":{"label":"Polymer:source-ranges","ref":"source-ranges","sha":"635e08dab09ceed07e327488ccbf946d1ec8dc1a","user":{"login":"Polymer","id":2159051,"avatar_url":"https://avatars.githubusercontent.com/u/2159051?v=3","gravatar_id":"","url":"https://api.github.com/users/Polymer","html_url":"https://github.com/Polymer","followers_url":"https://api.github.com/users/Polymer/followers","following_url":"https://api.github.com/users/Polymer/following{/other_user}","gists_url":"https://api.github.com/users/Polymer/gists{/gist_id}","starred_url":"https://api.github.com/users/Polymer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Polymer/subscriptions","organizations_url":"https://api.github.com/users/Polymer/orgs","repos_url":"https://api.github.com/users/Polymer/repos","events_url":"https://api.github.com/users/Polymer/events{/privacy}","received_events_url":"https://api.github.com/users/Polymer/received_events","type":"Organization","site_admin":false},"repo":{"id":30035812,"name":"polymer-analyzer","full_name":"Polymer/polymer-analyzer","owner":{"login":"Polymer","id":2159051,"avatar_url":"https://avatars.githubusercontent.com/u/2159051?v=3","gravatar_id":"","url":"https://api.github.com/users/Polymer","html_url":"https://github.com/Polymer","followers_url":"https://api.github.com/users/Polymer/followers","following_url":"https://api.github.com/users/Polymer/following{/other_user}","gists_url":"https://api.github.com/users/Polymer/gists{/gist_id}","starred_url":"https://api.github.com/users/Polymer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Polymer/subscriptions","organizations_url":"https://api.github.com/users/Polymer/orgs","repos_url":"https://api.github.com/users/Polymer/repos","events_url":"https://api.github.com/users/Polymer/events{/privacy}","received_events_url":"https://api.github.com/users/Polymer/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Polymer/polymer-analyzer","description":"A utility for analyzing polymer elements.","fork":false,"url":"https://api.github.com/repos/Polymer/polymer-analyzer","forks_url":"https://api.github.com/repos/Polymer/polymer-analyzer/forks","keys_url":"https://api.github.com/repos/Polymer/polymer-analyzer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Polymer/polymer-analyzer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Polymer/polymer-analyzer/teams","hooks_url":"https://api.github.com/repos/Polymer/polymer-analyzer/hooks","issue_events_url":"https://api.github.com/repos/Polymer/polymer-analyzer/issues/events{/number}","events_url":"https://api.github.com/repos/Polymer/polymer-analyzer/events","assignees_url":"https://api.github.com/repos/Polymer/polymer-analyzer/assignees{/user}","branches_url":"https://api.github.com/repos/Polymer/polymer-analyzer/branches{/branch}","tags_url":"https://api.github.com/repos/Polymer/polymer-analyzer/tags","blobs_url":"https://api.github.com/repos/Polymer/polymer-analyzer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Polymer/polymer-analyzer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Polymer/polymer-analyzer/git/refs{/sha}","trees_url":"https://api.github.com/repos/Polymer/polymer-analyzer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Polymer/polymer-analyzer/statuses/{sha}","languages_url":"https://api.github.com/repos/Polymer/polymer-analyzer/languages","stargazers_url":"https://api.github.com/repos/Polymer/polymer-analyzer/stargazers","contributors_url":"https://api.github.com/repos/Polymer/polymer-analyzer/contributors","subscribers_url":"https://api.github.com/repos/Polymer/polymer-analyzer/subscribers","subscription_url":"https://api.github.com/repos/Polymer/polymer-analyzer/subscription","commits_url":"https://api.github.com/repos/Polymer/polymer-analyzer/commits{/sha}","git_commits_url":"https://api.github.com/repos/Polymer/polymer-analyzer/git/commits{/sha}","comments_url":"https://api.github.com/repos/Polymer/polymer-analyzer/comments{/number}","issue_comment_url":"https://api.github.com/repos/Polymer/polymer-analyzer/issues/comments{/number}","contents_url":"https://api.github.com/repos/Polymer/polymer-analyzer/contents/{+path}","compare_url":"https://api.github.com/repos/Polymer/polymer-analyzer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Polymer/polymer-analyzer/merges","archive_url":"https://api.github.com/repos/Polymer/polymer-analyzer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Polymer/polymer-analyzer/downloads","issues_url":"https://api.github.com/repos/Polymer/polymer-analyzer/issues{/number}","pulls_url":"https://api.github.com/repos/Polymer/polymer-analyzer/pulls{/number}","milestones_url":"https://api.github.com/repos/Polymer/polymer-analyzer/milestones{/number}","notifications_url":"https://api.github.com/repos/Polymer/polymer-analyzer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Polymer/polymer-analyzer/labels{/name}","releases_url":"https://api.github.com/repos/Polymer/polymer-analyzer/releases{/id}","deployments_url":"https://api.github.com/repos/Polymer/polymer-analyzer/deployments","created_at":"2015-01-29T18:56:38Z","updated_at":"2016-08-22T16:27:57Z","pushed_at":"2016-08-24T23:19:47Z","git_url":"git://github.com/Polymer/polymer-analyzer.git","ssh_url":"git@github.com:Polymer/polymer-analyzer.git","clone_url":"https://github.com/Polymer/polymer-analyzer.git","svn_url":"https://github.com/Polymer/polymer-analyzer","homepage":"","size":29782,"stargazers_count":86,"watchers_count":86,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":37,"mirror_url":null,"open_issues_count":47,"forks":37,"open_issues":47,"watchers":86,"default_branch":"master"}},"base":{"label":"Polymer:master","ref":"master","sha":"f8f74cb5d38ef9654acc277c6630b487309dc3d4","user":{"login":"Polymer","id":2159051,"avatar_url":"https://avatars.githubusercontent.com/u/2159051?v=3","gravatar_id":"","url":"https://api.github.com/users/Polymer","html_url":"https://github.com/Polymer","followers_url":"https://api.github.com/users/Polymer/followers","following_url":"https://api.github.com/users/Polymer/following{/other_user}","gists_url":"https://api.github.com/users/Polymer/gists{/gist_id}","starred_url":"https://api.github.com/users/Polymer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Polymer/subscriptions","organizations_url":"https://api.github.com/users/Polymer/orgs","repos_url":"https://api.github.com/users/Polymer/repos","events_url":"https://api.github.com/users/Polymer/events{/privacy}","received_events_url":"https://api.github.com/users/Polymer/received_events","type":"Organization","site_admin":false},"repo":{"id":30035812,"name":"polymer-analyzer","full_name":"Polymer/polymer-analyzer","owner":{"login":"Polymer","id":2159051,"avatar_url":"https://avatars.githubusercontent.com/u/2159051?v=3","gravatar_id":"","url":"https://api.github.com/users/Polymer","html_url":"https://github.com/Polymer","followers_url":"https://api.github.com/users/Polymer/followers","following_url":"https://api.github.com/users/Polymer/following{/other_user}","gists_url":"https://api.github.com/users/Polymer/gists{/gist_id}","starred_url":"https://api.github.com/users/Polymer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Polymer/subscriptions","organizations_url":"https://api.github.com/users/Polymer/orgs","repos_url":"https://api.github.com/users/Polymer/repos","events_url":"https://api.github.com/users/Polymer/events{/privacy}","received_events_url":"https://api.github.com/users/Polymer/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Polymer/polymer-analyzer","description":"A utility for analyzing polymer elements.","fork":false,"url":"https://api.github.com/repos/Polymer/polymer-analyzer","forks_url":"https://api.github.com/repos/Polymer/polymer-analyzer/forks","keys_url":"https://api.github.com/repos/Polymer/polymer-analyzer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Polymer/polymer-analyzer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Polymer/polymer-analyzer/teams","hooks_url":"https://api.github.com/repos/Polymer/polymer-analyzer/hooks","issue_events_url":"https://api.github.com/repos/Polymer/polymer-analyzer/issues/events{/number}","events_url":"https://api.github.com/repos/Polymer/polymer-analyzer/events","assignees_url":"https://api.github.com/repos/Polymer/polymer-analyzer/assignees{/user}","branches_url":"https://api.github.com/repos/Polymer/polymer-analyzer/branches{/branch}","tags_url":"https://api.github.com/repos/Polymer/polymer-analyzer/tags","blobs_url":"https://api.github.com/repos/Polymer/polymer-analyzer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Polymer/polymer-analyzer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Polymer/polymer-analyzer/git/refs{/sha}","trees_url":"https://api.github.com/repos/Polymer/polymer-analyzer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Polymer/polymer-analyzer/statuses/{sha}","languages_url":"https://api.github.com/repos/Polymer/polymer-analyzer/languages","stargazers_url":"https://api.github.com/repos/Polymer/polymer-analyzer/stargazers","contributors_url":"https://api.github.com/repos/Polymer/polymer-analyzer/contributors","subscribers_url":"https://api.github.com/repos/Polymer/polymer-analyzer/subscribers","subscription_url":"https://api.github.com/repos/Polymer/polymer-analyzer/subscription","commits_url":"https://api.github.com/repos/Polymer/polymer-analyzer/commits{/sha}","git_commits_url":"https://api.github.com/repos/Polymer/polymer-analyzer/git/commits{/sha}","comments_url":"https://api.github.com/repos/Polymer/polymer-analyzer/comments{/number}","issue_comment_url":"https://api.github.com/repos/Polymer/polymer-analyzer/issues/comments{/number}","contents_url":"https://api.github.com/repos/Polymer/polymer-analyzer/contents/{+path}","compare_url":"https://api.github.com/repos/Polymer/polymer-analyzer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Polymer/polymer-analyzer/merges","archive_url":"https://api.github.com/repos/Polymer/polymer-analyzer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Polymer/polymer-analyzer/downloads","issues_url":"https://api.github.com/repos/Polymer/polymer-analyzer/issues{/number}","pulls_url":"https://api.github.com/repos/Polymer/polymer-analyzer/pulls{/number}","milestones_url":"https://api.github.com/repos/Polymer/polymer-analyzer/milestones{/number}","notifications_url":"https://api.github.com/repos/Polymer/polymer-analyzer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Polymer/polymer-analyzer/labels{/name}","releases_url":"https://api.github.com/repos/Polymer/polymer-analyzer/releases{/id}","deployments_url":"https://api.github.com/repos/Polymer/polymer-analyzer/deployments","created_at":"2015-01-29T18:56:38Z","updated_at":"2016-08-22T16:27:57Z","pushed_at":"2016-08-24T23:19:47Z","git_url":"git://github.com/Polymer/polymer-analyzer.git","ssh_url":"git@github.com:Polymer/polymer-analyzer.git","clone_url":"https://github.com/Polymer/polymer-analyzer.git","svn_url":"https://github.com/Polymer/polymer-analyzer","homepage":"","size":29782,"stargazers_count":86,"watchers_count":86,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":37,"mirror_url":null,"open_issues_count":47,"forks":37,"open_issues":47,"watchers":86,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Polymer/polymer-analyzer/pulls/290"},"html":{"href":"https://github.com/Polymer/polymer-analyzer/pull/290"},"issue":{"href":"https://api.github.com/repos/Polymer/polymer-analyzer/issues/290"},"comments":{"href":"https://api.github.com/repos/Polymer/polymer-analyzer/issues/290/comments"},"review_comments":{"href":"https://api.github.com/repos/Polymer/polymer-analyzer/pulls/290/comments"},"review_comment":{"href":"https://api.github.com/repos/Polymer/polymer-analyzer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Polymer/polymer-analyzer/pulls/290/commits"},"statuses":{"href":"https://api.github.com/repos/Polymer/polymer-analyzer/statuses/635e08dab09ceed07e327488ccbf946d1ec8dc1a"}}}}
{"actor":{"display_login":"rictic"}}