{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/mysql-5.6/pulls/comments/87719196","pull_request_review_id":8320453,"id":87719196,"diff_hunk":"@@ -8150,7 +8150,7 @@ void ha_rocksdb::setup_scan_iterator(\n \n       auto read_opts = rocksdb::ReadOptions();\n       read_opts.snapshot= m_scan_it_snapshot;\n-      m_scan_it= rdb->NewIterator(read_opts);\n+      m_scan_it= rdb->NewIterator(read_opts, kd.get_cf());","path":"storage/rocksdb/ha_rocksdb.cc","position":5,"original_position":5,"commit_id":"e5381ee4bc53089d22983e9bd9f4d8ca4c63f5cf","original_commit_id":"e5381ee4bc53089d22983e9bd9f4d8ca4c63f5cf","user":{"login":"lth","id":292656,"avatar_url":"https://avatars.githubusercontent.com/u/292656?v=3","gravatar_id":"","url":"https://api.github.com/users/lth","html_url":"https://github.com/lth","followers_url":"https://api.github.com/users/lth/followers","following_url":"https://api.github.com/users/lth/following{/other_user}","gists_url":"https://api.github.com/users/lth/gists{/gist_id}","starred_url":"https://api.github.com/users/lth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lth/subscriptions","organizations_url":"https://api.github.com/users/lth/orgs","repos_url":"https://api.github.com/users/lth/repos","events_url":"https://api.github.com/users/lth/events{/privacy}","received_events_url":"https://api.github.com/users/lth/received_events","type":"User","site_admin":false},"body":"I just realized that I'm not setting the read_opts from `skip_bloom` and `fill_cache` in this case. Do you think this is necessary?","created_at":"2016-11-13T19:17:28Z","updated_at":"2016-11-13T19:17:28Z","html_url":"https://github.com/facebook/mysql-5.6/pull/421#discussion_r87719196","pull_request_url":"https://api.github.com/repos/facebook/mysql-5.6/pulls/421","_links":{"self":{"href":"https://api.github.com/repos/facebook/mysql-5.6/pulls/comments/87719196"},"html":{"href":"https://github.com/facebook/mysql-5.6/pull/421#discussion_r87719196"},"pull_request":{"href":"https://api.github.com/repos/facebook/mysql-5.6/pulls/421"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/mysql-5.6/pulls/421","id":93470216,"html_url":"https://github.com/facebook/mysql-5.6/pull/421","diff_url":"https://github.com/facebook/mysql-5.6/pull/421.diff","patch_url":"https://github.com/facebook/mysql-5.6/pull/421.patch","issue_url":"https://api.github.com/repos/facebook/mysql-5.6/issues/421","number":421,"state":"open","locked":false,"title":"Fixing how to get Iterator with commit_in_the_middle()","user":{"login":"yoshinorim","id":253614,"avatar_url":"https://avatars.githubusercontent.com/u/253614?v=3","gravatar_id":"","url":"https://api.github.com/users/yoshinorim","html_url":"https://github.com/yoshinorim","followers_url":"https://api.github.com/users/yoshinorim/followers","following_url":"https://api.github.com/users/yoshinorim/following{/other_user}","gists_url":"https://api.github.com/users/yoshinorim/gists{/gist_id}","starred_url":"https://api.github.com/users/yoshinorim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yoshinorim/subscriptions","organizations_url":"https://api.github.com/users/yoshinorim/orgs","repos_url":"https://api.github.com/users/yoshinorim/repos","events_url":"https://api.github.com/users/yoshinorim/events{/privacy}","received_events_url":"https://api.github.com/users/yoshinorim/received_events","type":"User","site_admin":false},"body":"Summary: NewIterator() needs CF handle, otherwise it returns\r\nan iterator for default column family, which doesn't return\r\nexpected rows.\r\n\r\nSquash with: https://phabricator.intern.facebook.com/D4159222\r\n\r\nTest Plan: mtr","created_at":"2016-11-13T11:37:45Z","updated_at":"2016-11-13T19:17:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"14f90e86c945b5f19556013a6c6b70439c5b10b0","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/mysql-5.6/pulls/421/commits","review_comments_url":"https://api.github.com/repos/facebook/mysql-5.6/pulls/421/comments","review_comment_url":"https://api.github.com/repos/facebook/mysql-5.6/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/mysql-5.6/issues/421/comments","statuses_url":"https://api.github.com/repos/facebook/mysql-5.6/statuses/e5381ee4bc53089d22983e9bd9f4d8ca4c63f5cf","head":{"label":"yoshinorim:commit_in_the_middle_fix","ref":"commit_in_the_middle_fix","sha":"e5381ee4bc53089d22983e9bd9f4d8ca4c63f5cf","user":{"login":"yoshinorim","id":253614,"avatar_url":"https://avatars.githubusercontent.com/u/253614?v=3","gravatar_id":"","url":"https://api.github.com/users/yoshinorim","html_url":"https://github.com/yoshinorim","followers_url":"https://api.github.com/users/yoshinorim/followers","following_url":"https://api.github.com/users/yoshinorim/following{/other_user}","gists_url":"https://api.github.com/users/yoshinorim/gists{/gist_id}","starred_url":"https://api.github.com/users/yoshinorim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yoshinorim/subscriptions","organizations_url":"https://api.github.com/users/yoshinorim/orgs","repos_url":"https://api.github.com/users/yoshinorim/repos","events_url":"https://api.github.com/users/yoshinorim/events{/privacy}","received_events_url":"https://api.github.com/users/yoshinorim/received_events","type":"User","site_admin":false},"repo":{"id":72456846,"name":"mysql-5.6","full_name":"yoshinorim/mysql-5.6","owner":{"login":"yoshinorim","id":253614,"avatar_url":"https://avatars.githubusercontent.com/u/253614?v=3","gravatar_id":"","url":"https://api.github.com/users/yoshinorim","html_url":"https://github.com/yoshinorim","followers_url":"https://api.github.com/users/yoshinorim/followers","following_url":"https://api.github.com/users/yoshinorim/following{/other_user}","gists_url":"https://api.github.com/users/yoshinorim/gists{/gist_id}","starred_url":"https://api.github.com/users/yoshinorim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yoshinorim/subscriptions","organizations_url":"https://api.github.com/users/yoshinorim/orgs","repos_url":"https://api.github.com/users/yoshinorim/repos","events_url":"https://api.github.com/users/yoshinorim/events{/privacy}","received_events_url":"https://api.github.com/users/yoshinorim/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yoshinorim/mysql-5.6","description":"Facebook's branch of the Oracle MySQL v5.6 database. This includes MyRocks.","fork":true,"url":"https://api.github.com/repos/yoshinorim/mysql-5.6","forks_url":"https://api.github.com/repos/yoshinorim/mysql-5.6/forks","keys_url":"https://api.github.com/repos/yoshinorim/mysql-5.6/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yoshinorim/mysql-5.6/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yoshinorim/mysql-5.6/teams","hooks_url":"https://api.github.com/repos/yoshinorim/mysql-5.6/hooks","issue_events_url":"https://api.github.com/repos/yoshinorim/mysql-5.6/issues/events{/number}","events_url":"https://api.github.com/repos/yoshinorim/mysql-5.6/events","assignees_url":"https://api.github.com/repos/yoshinorim/mysql-5.6/assignees{/user}","branches_url":"https://api.github.com/repos/yoshinorim/mysql-5.6/branches{/branch}","tags_url":"https://api.github.com/repos/yoshinorim/mysql-5.6/tags","blobs_url":"https://api.github.com/repos/yoshinorim/mysql-5.6/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yoshinorim/mysql-5.6/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yoshinorim/mysql-5.6/git/refs{/sha}","trees_url":"https://api.github.com/repos/yoshinorim/mysql-5.6/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yoshinorim/mysql-5.6/statuses/{sha}","languages_url":"https://api.github.com/repos/yoshinorim/mysql-5.6/languages","stargazers_url":"https://api.github.com/repos/yoshinorim/mysql-5.6/stargazers","contributors_url":"https://api.github.com/repos/yoshinorim/mysql-5.6/contributors","subscribers_url":"https://api.github.com/repos/yoshinorim/mysql-5.6/subscribers","subscription_url":"https://api.github.com/repos/yoshinorim/mysql-5.6/subscription","commits_url":"https://api.github.com/repos/yoshinorim/mysql-5.6/commits{/sha}","git_commits_url":"https://api.github.com/repos/yoshinorim/mysql-5.6/git/commits{/sha}","comments_url":"https://api.github.com/repos/yoshinorim/mysql-5.6/comments{/number}","issue_comment_url":"https://api.github.com/repos/yoshinorim/mysql-5.6/issues/comments{/number}","contents_url":"https://api.github.com/repos/yoshinorim/mysql-5.6/contents/{+path}","compare_url":"https://api.github.com/repos/yoshinorim/mysql-5.6/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yoshinorim/mysql-5.6/merges","archive_url":"https://api.github.com/repos/yoshinorim/mysql-5.6/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yoshinorim/mysql-5.6/downloads","issues_url":"https://api.github.com/repos/yoshinorim/mysql-5.6/issues{/number}","pulls_url":"https://api.github.com/repos/yoshinorim/mysql-5.6/pulls{/number}","milestones_url":"https://api.github.com/repos/yoshinorim/mysql-5.6/milestones{/number}","notifications_url":"https://api.github.com/repos/yoshinorim/mysql-5.6/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yoshinorim/mysql-5.6/labels{/name}","releases_url":"https://api.github.com/repos/yoshinorim/mysql-5.6/releases{/id}","deployments_url":"https://api.github.com/repos/yoshinorim/mysql-5.6/deployments","created_at":"2016-10-31T16:42:33Z","updated_at":"2016-10-31T16:44:11Z","pushed_at":"2016-11-13T11:36:01Z","git_url":"git://github.com/yoshinorim/mysql-5.6.git","ssh_url":"git@github.com:yoshinorim/mysql-5.6.git","clone_url":"https://github.com/yoshinorim/mysql-5.6.git","svn_url":"https://github.com/yoshinorim/mysql-5.6","homepage":"https://github.com/facebook/mysql-5.6","size":346140,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"webscalesql-5.6.27.75"}},"base":{"label":"facebook:webscalesql-5.6.27.75","ref":"webscalesql-5.6.27.75","sha":"0d7b1fe5f948cd5b501732cb3ad6bd5e40f81f5a","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":9454675,"name":"mysql-5.6","full_name":"facebook/mysql-5.6","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/mysql-5.6","description":"Facebook's branch of the Oracle MySQL v5.6 database. This includes MyRocks.","fork":false,"url":"https://api.github.com/repos/facebook/mysql-5.6","forks_url":"https://api.github.com/repos/facebook/mysql-5.6/forks","keys_url":"https://api.github.com/repos/facebook/mysql-5.6/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/mysql-5.6/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/mysql-5.6/teams","hooks_url":"https://api.github.com/repos/facebook/mysql-5.6/hooks","issue_events_url":"https://api.github.com/repos/facebook/mysql-5.6/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/mysql-5.6/events","assignees_url":"https://api.github.com/repos/facebook/mysql-5.6/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/mysql-5.6/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/mysql-5.6/tags","blobs_url":"https://api.github.com/repos/facebook/mysql-5.6/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/mysql-5.6/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/mysql-5.6/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/mysql-5.6/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/mysql-5.6/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/mysql-5.6/languages","stargazers_url":"https://api.github.com/repos/facebook/mysql-5.6/stargazers","contributors_url":"https://api.github.com/repos/facebook/mysql-5.6/contributors","subscribers_url":"https://api.github.com/repos/facebook/mysql-5.6/subscribers","subscription_url":"https://api.github.com/repos/facebook/mysql-5.6/subscription","commits_url":"https://api.github.com/repos/facebook/mysql-5.6/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/mysql-5.6/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/mysql-5.6/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/mysql-5.6/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/mysql-5.6/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/mysql-5.6/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/mysql-5.6/merges","archive_url":"https://api.github.com/repos/facebook/mysql-5.6/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/mysql-5.6/downloads","issues_url":"https://api.github.com/repos/facebook/mysql-5.6/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/mysql-5.6/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/mysql-5.6/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/mysql-5.6/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/mysql-5.6/labels{/name}","releases_url":"https://api.github.com/repos/facebook/mysql-5.6/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/mysql-5.6/deployments","created_at":"2013-04-15T17:54:43Z","updated_at":"2016-11-10T06:35:13Z","pushed_at":"2016-11-13T11:37:46Z","git_url":"git://github.com/facebook/mysql-5.6.git","ssh_url":"git@github.com:facebook/mysql-5.6.git","clone_url":"https://github.com/facebook/mysql-5.6.git","svn_url":"https://github.com/facebook/mysql-5.6","homepage":"https://github.com/facebook/mysql-5.6","size":499446,"stargazers_count":745,"watchers_count":745,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":247,"mirror_url":null,"open_issues_count":113,"forks":247,"open_issues":113,"watchers":745,"default_branch":"webscalesql-5.6.27.75"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/mysql-5.6/pulls/421"},"html":{"href":"https://github.com/facebook/mysql-5.6/pull/421"},"issue":{"href":"https://api.github.com/repos/facebook/mysql-5.6/issues/421"},"comments":{"href":"https://api.github.com/repos/facebook/mysql-5.6/issues/421/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/mysql-5.6/pulls/421/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/mysql-5.6/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/mysql-5.6/pulls/421/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/mysql-5.6/statuses/e5381ee4bc53089d22983e9bd9f4d8ca4c63f5cf"}}}}
{"actor":{"display_login":"lth"}}