{"action":"created","issue":{"url":"https://api.github.com/repos/apache/flink/issues/1563","labels_url":"https://api.github.com/repos/apache/flink/issues/1563/labels{/name}","comments_url":"https://api.github.com/repos/apache/flink/issues/1563/comments","events_url":"https://api.github.com/repos/apache/flink/issues/1563/events","html_url":"https://github.com/apache/flink/pull/1563","id":129880314,"number":1563,"title":"[FLINK-3296] Remove 'flushing' behavior of the OutputFormat in DataStream API","user":{"login":"rmetzger","id":89049,"avatar_url":"https://avatars.githubusercontent.com/u/89049?v=3","gravatar_id":"","url":"https://api.github.com/users/rmetzger","html_url":"https://github.com/rmetzger","followers_url":"https://api.github.com/users/rmetzger/followers","following_url":"https://api.github.com/users/rmetzger/following{/other_user}","gists_url":"https://api.github.com/users/rmetzger/gists{/gist_id}","starred_url":"https://api.github.com/users/rmetzger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmetzger/subscriptions","organizations_url":"https://api.github.com/users/rmetzger/orgs","repos_url":"https://api.github.com/users/rmetzger/repos","events_url":"https://api.github.com/users/rmetzger/events{/privacy}","received_events_url":"https://api.github.com/users/rmetzger/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-01-29T20:55:16Z","updated_at":"2016-02-01T15:28:56Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/flink/pulls/1563","html_url":"https://github.com/apache/flink/pull/1563","diff_url":"https://github.com/apache/flink/pull/1563.diff","patch_url":"https://github.com/apache/flink/pull/1563.patch"},"body":"I removed the `FileSinkFunctionByMillis` and removed all the `millis` arguments on the writing functions.\r\n\r\nThe whole \"buffering\" and \"flushing\" functionality was broken: Elements were kept in an ArrayList and send to the OutputFormat on \"flush()\". However, the flush was not really called periodically. It was only checked when new records arrived. So when a stream is not having elements for a certain time, the last few elements would just stay in the list until new elements arrive again."},"comment":{"url":"https://api.github.com/repos/apache/flink/issues/comments/178020653","html_url":"https://github.com/apache/flink/pull/1563#issuecomment-178020653","issue_url":"https://api.github.com/repos/apache/flink/issues/1563","id":178020653,"user":{"login":"StephanEwen","id":1727146,"avatar_url":"https://avatars.githubusercontent.com/u/1727146?v=3","gravatar_id":"","url":"https://api.github.com/users/StephanEwen","html_url":"https://github.com/StephanEwen","followers_url":"https://api.github.com/users/StephanEwen/followers","following_url":"https://api.github.com/users/StephanEwen/following{/other_user}","gists_url":"https://api.github.com/users/StephanEwen/gists{/gist_id}","starred_url":"https://api.github.com/users/StephanEwen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StephanEwen/subscriptions","organizations_url":"https://api.github.com/users/StephanEwen/orgs","repos_url":"https://api.github.com/users/StephanEwen/repos","events_url":"https://api.github.com/users/StephanEwen/events{/privacy}","received_events_url":"https://api.github.com/users/StephanEwen/received_events","type":"User","site_admin":false},"created_at":"2016-02-01T15:28:56Z","updated_at":"2016-02-01T15:28:56Z","body":"Code looks good. I would like to update the docs to include a bit more info (like in the inline comment) and at least refer to the `addSink(...)` method, for fault tolerant sinks."}}