{"action":"created","issue":{"url":"https://api.github.com/repos/pmem/nvml/issues/1277","repository_url":"https://api.github.com/repos/pmem/nvml","labels_url":"https://api.github.com/repos/pmem/nvml/issues/1277/labels{/name}","comments_url":"https://api.github.com/repos/pmem/nvml/issues/1277/comments","events_url":"https://api.github.com/repos/pmem/nvml/issues/1277/events","html_url":"https://github.com/pmem/nvml/pull/1277","id":181791464,"number":1277,"title":"win: port test obj_sync","user":{"login":"JLLLinn","id":5632438,"avatar_url":"https://avatars.githubusercontent.com/u/5632438?v=3","gravatar_id":"","url":"https://api.github.com/users/JLLLinn","html_url":"https://github.com/JLLLinn","followers_url":"https://api.github.com/users/JLLLinn/followers","following_url":"https://api.github.com/users/JLLLinn/following{/other_user}","gists_url":"https://api.github.com/users/JLLLinn/gists{/gist_id}","starred_url":"https://api.github.com/users/JLLLinn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JLLLinn/subscriptions","organizations_url":"https://api.github.com/users/JLLLinn/orgs","repos_url":"https://api.github.com/users/JLLLinn/repos","events_url":"https://api.github.com/users/JLLLinn/events{/privacy}","received_events_url":"https://api.github.com/users/JLLLinn/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-10-08T00:13:05Z","updated_at":"2016-10-12T23:32:52Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/pmem/nvml/pulls/1277","html_url":"https://github.com/pmem/nvml/pull/1277","diff_url":"https://github.com/pmem/nvml/pull/1277.diff","patch_url":"https://github.com/pmem/nvml/pull/1277.patch"},"body":"\n\n<!-- Reviewable:start -->\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/pmem/nvml/1277)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/pmem/nvml/issues/comments/253369490","html_url":"https://github.com/pmem/nvml/pull/1277#issuecomment-253369490","issue_url":"https://api.github.com/repos/pmem/nvml/issues/1277","id":253369490,"user":{"login":"JLLLinn","id":5632438,"avatar_url":"https://avatars.githubusercontent.com/u/5632438?v=3","gravatar_id":"","url":"https://api.github.com/users/JLLLinn","html_url":"https://github.com/JLLLinn","followers_url":"https://api.github.com/users/JLLLinn/followers","following_url":"https://api.github.com/users/JLLLinn/following{/other_user}","gists_url":"https://api.github.com/users/JLLLinn/gists{/gist_id}","starred_url":"https://api.github.com/users/JLLLinn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JLLLinn/subscriptions","organizations_url":"https://api.github.com/users/JLLLinn/orgs","repos_url":"https://api.github.com/users/JLLLinn/repos","events_url":"https://api.github.com/users/JLLLinn/events{/privacy}","received_events_url":"https://api.github.com/users/JLLLinn/received_events","type":"User","site_admin":false},"created_at":"2016-10-12T23:32:52Z","updated_at":"2016-10-12T23:32:52Z","body":"\n\n\n\nReview status: 28 of 32 files reviewed at latest revision, 6 unresolved discussions.\n\n---\n\n*[src/test/obj_sync/obj_sync.c, line 101 at r3](https://reviewable.io:443/reviews/pmem/nvml/1277#-KTuJHtTu9-C1xM_7Bhy:-KTvDbQrLZB9Q-ZjqUt_:bbcv1vh) ([raw file](https://github.com/pmem/nvml/blob/dbf7aee0a4a8060a434c35a28ee7db7e24d61e83/src/test/obj_sync/obj_sync.c#L101)):*\n<details><summary><i>Previously, krzycz (Krzysztof Czurylo) wrote…</i></summary>\n> What about the same approach as for __sync_bool_compare_and_swap()?\n> Define util_fetch_and_addXX() wrappers in util.h, and use util_fetch_and_add64() here. (no #ifdef)\n</details>\nTo do this we will likely have to change the feature code (all __sync_bool_compare_and_swap to util_bool_compare_and_swap) as happens for util_fetch_and_add, should I proceed with it?\n\n---\n\n*[src/test/obj_sync/obj_sync.vcxproj, line 65 at r3](https://reviewable.io:443/reviews/pmem/nvml/1277#-KTuK51MScHZe2jRawfj:-KTvD7rb68xiR75yEXmQ:bbnolh3) ([raw file](https://github.com/pmem/nvml/blob/dbf7aee0a4a8060a434c35a28ee7db7e24d61e83/src/test/obj_sync/obj_sync.vcxproj#L65)):*\n<details><summary><i>Previously, krzycz (Krzysztof Czurylo) wrote…</i></summary>\n> Is this really needed?\n</details>\nVS warns about this since pthread_mutex_init (and 2 others) has \"__restrict\" in their definition but not in the FUNC_MOCK\n\n---\n\n*[src/test/obj_sync/obj_sync.vcxproj, line 101 at r3](https://reviewable.io:443/reviews/pmem/nvml/1277#-KTuOjXMgjaNBNgWpRd2:-KTvCJ197SQKsQDzI_uZ:bkwwldr) ([raw file](https://github.com/pmem/nvml/blob/dbf7aee0a4a8060a434c35a28ee7db7e24d61e83/src/test/obj_sync/obj_sync.vcxproj#L101)):*\n<details><summary><i>Previously, krzycz (Krzysztof Czurylo) wrote…</i></summary>\n> Are all these files really required by this test? Isn't sync.c enough?\n</details>\nDone. set.c is needed since a mocked function is called during pre-loading. also need pthread_windows for all the real function definition.  Others are excluded after libpmemobj is added as reference.\n\n---\n\n*[src/windows/include/platform.h, line 183 at r3](https://reviewable.io:443/reviews/pmem/nvml/1277#-KTuSFQE9DYbEsxAT-ZN:-KTvCCtdxstHnJCrsjgN:bjotsuz) ([raw file](https://github.com/pmem/nvml/blob/dbf7aee0a4a8060a434c35a28ee7db7e24d61e83/src/windows/include/platform.h#L183)):*\n<details><summary><i>Previously, krzycz (Krzysztof Czurylo) wrote…</i></summary>\n> We have it already in pthread_windows.c. Perhaps, we could get rid of one of those?\n> Also, if it's used in win_time.c only, then why not to define it there?\n</details>\nMoved this to win_time, Done\n\n---\n\n*[src/windows/liblinux/win_time.c, line 38 at r3](https://reviewable.io:443/reviews/pmem/nvml/1277#-KTuQlp46irVqncbaYH_:-KTvCB4ot1ia8NgEXmkf:b-896fix) ([raw file](https://github.com/pmem/nvml/blob/dbf7aee0a4a8060a434c35a28ee7db7e24d61e83/src/windows/liblinux/win_time.c#L38)):*\n<details><summary><i>Previously, krzycz (Krzysztof Czurylo) wrote…</i></summary>\n> missing brief\n</details>\nDone.\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/pmem/nvml/1277)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"JLLLinn"}}