{"action":"created","issue":{"url":"https://api.github.com/repos/PokemonGoF/PokemonGo-Bot/issues/5696","repository_url":"https://api.github.com/repos/PokemonGoF/PokemonGo-Bot","labels_url":"https://api.github.com/repos/PokemonGoF/PokemonGo-Bot/issues/5696/labels{/name}","comments_url":"https://api.github.com/repos/PokemonGoF/PokemonGo-Bot/issues/5696/comments","events_url":"https://api.github.com/repos/PokemonGoF/PokemonGo-Bot/issues/5696/events","html_url":"https://github.com/PokemonGoF/PokemonGo-Bot/pull/5696","id":179331309,"number":5696,"title":"Revert \"Avoid task init if task is disabled\" (#5591)","user":{"login":"YvesHenri","id":9488596,"avatar_url":"https://avatars.githubusercontent.com/u/9488596?v=3","gravatar_id":"","url":"https://api.github.com/users/YvesHenri","html_url":"https://github.com/YvesHenri","followers_url":"https://api.github.com/users/YvesHenri/followers","following_url":"https://api.github.com/users/YvesHenri/following{/other_user}","gists_url":"https://api.github.com/users/YvesHenri/gists{/gist_id}","starred_url":"https://api.github.com/users/YvesHenri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YvesHenri/subscriptions","organizations_url":"https://api.github.com/users/YvesHenri/orgs","repos_url":"https://api.github.com/users/YvesHenri/repos","events_url":"https://api.github.com/users/YvesHenri/events{/privacy}","received_events_url":"https://api.github.com/users/YvesHenri/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":12,"created_at":"2016-09-26T20:39:04Z","updated_at":"2016-09-27T02:58:07Z","closed_at":"2016-09-27T02:57:30Z","pull_request":{"url":"https://api.github.com/repos/PokemonGoF/PokemonGo-Bot/pulls/5696","html_url":"https://github.com/PokemonGoF/PokemonGo-Bot/pull/5696","diff_url":"https://github.com/PokemonGoF/PokemonGo-Bot/pull/5696.diff","patch_url":"https://github.com/PokemonGoF/PokemonGo-Bot/pull/5696.patch"},"body":"As expected, I just came across with the following situation:\r\n\r\n_If the user wants to disable catching nearby pokemons **ONLY** and enables Sniper and/or MoveToMapPokemon, the PokemonCatchWorker will never be initialized._ But what's so bad about this? Well, I need to store the `daily_catch_limit` value (PokemonCatchWorker task's config), since it'll be used from both Sniper/MTMP, but if that task is never initialized, I will never have this value.\r\n\r\nThis is just **ONE MORE** case that proves why we shouldn't handle such logic in the TreeConfigBuilder/BaseTask, like I said, unless you guys can come up with something better (post below).\r\n\r\nThese are definitely not viable:\r\n\r\n- Load up and parse the whole config file and retrieve only the PokemonCatchWorker portion within both Sniper/MTMP tasks if need be\r\n"},"comment":{"url":"https://api.github.com/repos/PokemonGoF/PokemonGo-Bot/issues/comments/249754061","html_url":"https://github.com/PokemonGoF/PokemonGo-Bot/pull/5696#issuecomment-249754061","issue_url":"https://api.github.com/repos/PokemonGoF/PokemonGo-Bot/issues/5696","id":249754061,"user":{"login":"Gobberwart","id":20783738,"avatar_url":"https://avatars.githubusercontent.com/u/20783738?v=3","gravatar_id":"","url":"https://api.github.com/users/Gobberwart","html_url":"https://github.com/Gobberwart","followers_url":"https://api.github.com/users/Gobberwart/followers","following_url":"https://api.github.com/users/Gobberwart/following{/other_user}","gists_url":"https://api.github.com/users/Gobberwart/gists{/gist_id}","starred_url":"https://api.github.com/users/Gobberwart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gobberwart/subscriptions","organizations_url":"https://api.github.com/users/Gobberwart/orgs","repos_url":"https://api.github.com/users/Gobberwart/repos","events_url":"https://api.github.com/users/Gobberwart/events{/privacy}","received_events_url":"https://api.github.com/users/Gobberwart/received_events","type":"User","site_admin":false},"created_at":"2016-09-27T02:58:07Z","updated_at":"2016-09-27T02:58:07Z","body":"For now, revert this to fix problems it has caused. We can always revisit later."}}
{"actor":{"display_login":"Gobberwart"}}