{"action":"created","comment":{"url":"https://api.github.com/repos/sgmap/beta.gouv.fr/pulls/comments/68272935","id":68272935,"diff_hunk":"@@ -0,0 +1,17 @@\n+class EnforceImgHTTPS < ::HTMLProofer::Check\n+  def run\n+    @html.css('img').each do |node|\n+      img = create_element(node)","path":"rb/lib/htmlproofer/enforce_img_https.rb","position":null,"original_position":4,"commit_id":"20cf5ff1384264d9010a827226e69c45ce086072","original_commit_id":"b411335b2e5ba56231353bda7cc38f6f6ac10ca9","user":{"login":"Morendil","id":216452,"avatar_url":"https://avatars.githubusercontent.com/u/216452?v=3","gravatar_id":"","url":"https://api.github.com/users/Morendil","html_url":"https://github.com/Morendil","followers_url":"https://api.github.com/users/Morendil/followers","following_url":"https://api.github.com/users/Morendil/following{/other_user}","gists_url":"https://api.github.com/users/Morendil/gists{/gist_id}","starred_url":"https://api.github.com/users/Morendil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Morendil/subscriptions","organizations_url":"https://api.github.com/users/Morendil/orgs","repos_url":"https://api.github.com/users/Morendil/repos","events_url":"https://api.github.com/users/Morendil/events{/privacy}","received_events_url":"https://api.github.com/users/Morendil/received_events","type":"User","site_admin":false},"body":"You might have misunderstood my intent in using the underlying `node`, which was to accomodate this:\r\n\r\n`  <img src=\"//adresse.data.gouv.fr/static/img/BAN.png\">`\r\n\r\nwhich will now be considered incorrect by EnforceImgHTTPS, even though it is actually just fine. The problem is that the HTMLProofer::Element constructor provides \"http\" to make up for a missing `scheme`, and so our tests would fail in a case like the above.\r\n\r\n**Right now** this doesn't lead to any failures, and so might not be an obstacle to merging as-is, but we might face a nasty surprise (and a long debugging session) later on if someone use `scheme`-less images (just as we now rely on `scheme`-less JS and CSS), and unexpectedly sees their PR go red.","created_at":"2016-06-23T17:01:25Z","updated_at":"2016-06-23T17:01:25Z","html_url":"https://github.com/sgmap/beta.gouv.fr/pull/253#discussion_r68272935","pull_request_url":"https://api.github.com/repos/sgmap/beta.gouv.fr/pulls/253","_links":{"self":{"href":"https://api.github.com/repos/sgmap/beta.gouv.fr/pulls/comments/68272935"},"html":{"href":"https://github.com/sgmap/beta.gouv.fr/pull/253#discussion_r68272935"},"pull_request":{"href":"https://api.github.com/repos/sgmap/beta.gouv.fr/pulls/253"}}},"pull_request":{"url":"https://api.github.com/repos/sgmap/beta.gouv.fr/pulls/253","id":74338958,"html_url":"https://github.com/sgmap/beta.gouv.fr/pull/253","diff_url":"https://github.com/sgmap/beta.gouv.fr/pull/253.diff","patch_url":"https://github.com/sgmap/beta.gouv.fr/pull/253.patch","issue_url":"https://api.github.com/repos/sgmap/beta.gouv.fr/issues/253","number":253,"state":"open","locked":false,"title":"Add check for insecure images to htmlproofer","user":{"login":"Morendil","id":216452,"avatar_url":"https://avatars.githubusercontent.com/u/216452?v=3","gravatar_id":"","url":"https://api.github.com/users/Morendil","html_url":"https://github.com/Morendil","followers_url":"https://api.github.com/users/Morendil/followers","following_url":"https://api.github.com/users/Morendil/following{/other_user}","gists_url":"https://api.github.com/users/Morendil/gists{/gist_id}","starred_url":"https://api.github.com/users/Morendil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Morendil/subscriptions","organizations_url":"https://api.github.com/users/Morendil/orgs","repos_url":"https://api.github.com/users/Morendil/repos","events_url":"https://api.github.com/users/Morendil/events{/privacy}","received_events_url":"https://api.github.com/users/Morendil/received_events","type":"User","site_admin":false},"body":"Will fix #74 after getting build to pass by fixing deliberate error in _startup/datagouv.md","created_at":"2016-06-18T14:50:30Z","updated_at":"2016-06-23T17:01:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7f76b51a8046b17fb2ea370ee72bfb6e6e4aca08","assignee":{"login":"Morendil","id":216452,"avatar_url":"https://avatars.githubusercontent.com/u/216452?v=3","gravatar_id":"","url":"https://api.github.com/users/Morendil","html_url":"https://github.com/Morendil","followers_url":"https://api.github.com/users/Morendil/followers","following_url":"https://api.github.com/users/Morendil/following{/other_user}","gists_url":"https://api.github.com/users/Morendil/gists{/gist_id}","starred_url":"https://api.github.com/users/Morendil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Morendil/subscriptions","organizations_url":"https://api.github.com/users/Morendil/orgs","repos_url":"https://api.github.com/users/Morendil/repos","events_url":"https://api.github.com/users/Morendil/events{/privacy}","received_events_url":"https://api.github.com/users/Morendil/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/sgmap/beta.gouv.fr/pulls/253/commits","review_comments_url":"https://api.github.com/repos/sgmap/beta.gouv.fr/pulls/253/comments","review_comment_url":"https://api.github.com/repos/sgmap/beta.gouv.fr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sgmap/beta.gouv.fr/issues/253/comments","statuses_url":"https://api.github.com/repos/sgmap/beta.gouv.fr/statuses/20cf5ff1384264d9010a827226e69c45ce086072","head":{"label":"sgmap:htmlproofer-extra","ref":"htmlproofer-extra","sha":"20cf5ff1384264d9010a827226e69c45ce086072","user":{"login":"sgmap","id":7874148,"avatar_url":"https://avatars.githubusercontent.com/u/7874148?v=3","gravatar_id":"","url":"https://api.github.com/users/sgmap","html_url":"https://github.com/sgmap","followers_url":"https://api.github.com/users/sgmap/followers","following_url":"https://api.github.com/users/sgmap/following{/other_user}","gists_url":"https://api.github.com/users/sgmap/gists{/gist_id}","starred_url":"https://api.github.com/users/sgmap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgmap/subscriptions","organizations_url":"https://api.github.com/users/sgmap/orgs","repos_url":"https://api.github.com/users/sgmap/repos","events_url":"https://api.github.com/users/sgmap/events{/privacy}","received_events_url":"https://api.github.com/users/sgmap/received_events","type":"Organization","site_admin":false},"repo":{"id":48237006,"name":"beta.gouv.fr","full_name":"sgmap/beta.gouv.fr","owner":{"login":"sgmap","id":7874148,"avatar_url":"https://avatars.githubusercontent.com/u/7874148?v=3","gravatar_id":"","url":"https://api.github.com/users/sgmap","html_url":"https://github.com/sgmap","followers_url":"https://api.github.com/users/sgmap/followers","following_url":"https://api.github.com/users/sgmap/following{/other_user}","gists_url":"https://api.github.com/users/sgmap/gists{/gist_id}","starred_url":"https://api.github.com/users/sgmap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgmap/subscriptions","organizations_url":"https://api.github.com/users/sgmap/orgs","repos_url":"https://api.github.com/users/sgmap/repos","events_url":"https://api.github.com/users/sgmap/events{/privacy}","received_events_url":"https://api.github.com/users/sgmap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sgmap/beta.gouv.fr","description":"Le site public de l'Incubateur de Services Numériques de l'État français.","fork":false,"url":"https://api.github.com/repos/sgmap/beta.gouv.fr","forks_url":"https://api.github.com/repos/sgmap/beta.gouv.fr/forks","keys_url":"https://api.github.com/repos/sgmap/beta.gouv.fr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sgmap/beta.gouv.fr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sgmap/beta.gouv.fr/teams","hooks_url":"https://api.github.com/repos/sgmap/beta.gouv.fr/hooks","issue_events_url":"https://api.github.com/repos/sgmap/beta.gouv.fr/issues/events{/number}","events_url":"https://api.github.com/repos/sgmap/beta.gouv.fr/events","assignees_url":"https://api.github.com/repos/sgmap/beta.gouv.fr/assignees{/user}","branches_url":"https://api.github.com/repos/sgmap/beta.gouv.fr/branches{/branch}","tags_url":"https://api.github.com/repos/sgmap/beta.gouv.fr/tags","blobs_url":"https://api.github.com/repos/sgmap/beta.gouv.fr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sgmap/beta.gouv.fr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sgmap/beta.gouv.fr/git/refs{/sha}","trees_url":"https://api.github.com/repos/sgmap/beta.gouv.fr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sgmap/beta.gouv.fr/statuses/{sha}","languages_url":"https://api.github.com/repos/sgmap/beta.gouv.fr/languages","stargazers_url":"https://api.github.com/repos/sgmap/beta.gouv.fr/stargazers","contributors_url":"https://api.github.com/repos/sgmap/beta.gouv.fr/contributors","subscribers_url":"https://api.github.com/repos/sgmap/beta.gouv.fr/subscribers","subscription_url":"https://api.github.com/repos/sgmap/beta.gouv.fr/subscription","commits_url":"https://api.github.com/repos/sgmap/beta.gouv.fr/commits{/sha}","git_commits_url":"https://api.github.com/repos/sgmap/beta.gouv.fr/git/commits{/sha}","comments_url":"https://api.github.com/repos/sgmap/beta.gouv.fr/comments{/number}","issue_comment_url":"https://api.github.com/repos/sgmap/beta.gouv.fr/issues/comments{/number}","contents_url":"https://api.github.com/repos/sgmap/beta.gouv.fr/contents/{+path}","compare_url":"https://api.github.com/repos/sgmap/beta.gouv.fr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sgmap/beta.gouv.fr/merges","archive_url":"https://api.github.com/repos/sgmap/beta.gouv.fr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sgmap/beta.gouv.fr/downloads","issues_url":"https://api.github.com/repos/sgmap/beta.gouv.fr/issues{/number}","pulls_url":"https://api.github.com/repos/sgmap/beta.gouv.fr/pulls{/number}","milestones_url":"https://api.github.com/repos/sgmap/beta.gouv.fr/milestones{/number}","notifications_url":"https://api.github.com/repos/sgmap/beta.gouv.fr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sgmap/beta.gouv.fr/labels{/name}","releases_url":"https://api.github.com/repos/sgmap/beta.gouv.fr/releases{/id}","deployments_url":"https://api.github.com/repos/sgmap/beta.gouv.fr/deployments","created_at":"2015-12-18T13:33:48Z","updated_at":"2016-06-15T08:29:56Z","pushed_at":"2016-06-23T16:25:00Z","git_url":"git://github.com/sgmap/beta.gouv.fr.git","ssh_url":"git@github.com:sgmap/beta.gouv.fr.git","clone_url":"https://github.com/sgmap/beta.gouv.fr.git","svn_url":"https://github.com/sgmap/beta.gouv.fr","homepage":"https://beta.gouv.fr","size":17247,"stargazers_count":12,"watchers_count":12,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":21,"mirror_url":null,"open_issues_count":9,"forks":21,"open_issues":9,"watchers":12,"default_branch":"gh-pages"}},"base":{"label":"sgmap:gh-pages","ref":"gh-pages","sha":"99a56b9c02da1ea90ec4b0c4d9584026becb4eae","user":{"login":"sgmap","id":7874148,"avatar_url":"https://avatars.githubusercontent.com/u/7874148?v=3","gravatar_id":"","url":"https://api.github.com/users/sgmap","html_url":"https://github.com/sgmap","followers_url":"https://api.github.com/users/sgmap/followers","following_url":"https://api.github.com/users/sgmap/following{/other_user}","gists_url":"https://api.github.com/users/sgmap/gists{/gist_id}","starred_url":"https://api.github.com/users/sgmap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgmap/subscriptions","organizations_url":"https://api.github.com/users/sgmap/orgs","repos_url":"https://api.github.com/users/sgmap/repos","events_url":"https://api.github.com/users/sgmap/events{/privacy}","received_events_url":"https://api.github.com/users/sgmap/received_events","type":"Organization","site_admin":false},"repo":{"id":48237006,"name":"beta.gouv.fr","full_name":"sgmap/beta.gouv.fr","owner":{"login":"sgmap","id":7874148,"avatar_url":"https://avatars.githubusercontent.com/u/7874148?v=3","gravatar_id":"","url":"https://api.github.com/users/sgmap","html_url":"https://github.com/sgmap","followers_url":"https://api.github.com/users/sgmap/followers","following_url":"https://api.github.com/users/sgmap/following{/other_user}","gists_url":"https://api.github.com/users/sgmap/gists{/gist_id}","starred_url":"https://api.github.com/users/sgmap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgmap/subscriptions","organizations_url":"https://api.github.com/users/sgmap/orgs","repos_url":"https://api.github.com/users/sgmap/repos","events_url":"https://api.github.com/users/sgmap/events{/privacy}","received_events_url":"https://api.github.com/users/sgmap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sgmap/beta.gouv.fr","description":"Le site public de l'Incubateur de Services Numériques de l'État français.","fork":false,"url":"https://api.github.com/repos/sgmap/beta.gouv.fr","forks_url":"https://api.github.com/repos/sgmap/beta.gouv.fr/forks","keys_url":"https://api.github.com/repos/sgmap/beta.gouv.fr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sgmap/beta.gouv.fr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sgmap/beta.gouv.fr/teams","hooks_url":"https://api.github.com/repos/sgmap/beta.gouv.fr/hooks","issue_events_url":"https://api.github.com/repos/sgmap/beta.gouv.fr/issues/events{/number}","events_url":"https://api.github.com/repos/sgmap/beta.gouv.fr/events","assignees_url":"https://api.github.com/repos/sgmap/beta.gouv.fr/assignees{/user}","branches_url":"https://api.github.com/repos/sgmap/beta.gouv.fr/branches{/branch}","tags_url":"https://api.github.com/repos/sgmap/beta.gouv.fr/tags","blobs_url":"https://api.github.com/repos/sgmap/beta.gouv.fr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sgmap/beta.gouv.fr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sgmap/beta.gouv.fr/git/refs{/sha}","trees_url":"https://api.github.com/repos/sgmap/beta.gouv.fr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sgmap/beta.gouv.fr/statuses/{sha}","languages_url":"https://api.github.com/repos/sgmap/beta.gouv.fr/languages","stargazers_url":"https://api.github.com/repos/sgmap/beta.gouv.fr/stargazers","contributors_url":"https://api.github.com/repos/sgmap/beta.gouv.fr/contributors","subscribers_url":"https://api.github.com/repos/sgmap/beta.gouv.fr/subscribers","subscription_url":"https://api.github.com/repos/sgmap/beta.gouv.fr/subscription","commits_url":"https://api.github.com/repos/sgmap/beta.gouv.fr/commits{/sha}","git_commits_url":"https://api.github.com/repos/sgmap/beta.gouv.fr/git/commits{/sha}","comments_url":"https://api.github.com/repos/sgmap/beta.gouv.fr/comments{/number}","issue_comment_url":"https://api.github.com/repos/sgmap/beta.gouv.fr/issues/comments{/number}","contents_url":"https://api.github.com/repos/sgmap/beta.gouv.fr/contents/{+path}","compare_url":"https://api.github.com/repos/sgmap/beta.gouv.fr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sgmap/beta.gouv.fr/merges","archive_url":"https://api.github.com/repos/sgmap/beta.gouv.fr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sgmap/beta.gouv.fr/downloads","issues_url":"https://api.github.com/repos/sgmap/beta.gouv.fr/issues{/number}","pulls_url":"https://api.github.com/repos/sgmap/beta.gouv.fr/pulls{/number}","milestones_url":"https://api.github.com/repos/sgmap/beta.gouv.fr/milestones{/number}","notifications_url":"https://api.github.com/repos/sgmap/beta.gouv.fr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sgmap/beta.gouv.fr/labels{/name}","releases_url":"https://api.github.com/repos/sgmap/beta.gouv.fr/releases{/id}","deployments_url":"https://api.github.com/repos/sgmap/beta.gouv.fr/deployments","created_at":"2015-12-18T13:33:48Z","updated_at":"2016-06-15T08:29:56Z","pushed_at":"2016-06-23T16:25:00Z","git_url":"git://github.com/sgmap/beta.gouv.fr.git","ssh_url":"git@github.com:sgmap/beta.gouv.fr.git","clone_url":"https://github.com/sgmap/beta.gouv.fr.git","svn_url":"https://github.com/sgmap/beta.gouv.fr","homepage":"https://beta.gouv.fr","size":17247,"stargazers_count":12,"watchers_count":12,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":21,"mirror_url":null,"open_issues_count":9,"forks":21,"open_issues":9,"watchers":12,"default_branch":"gh-pages"}},"_links":{"self":{"href":"https://api.github.com/repos/sgmap/beta.gouv.fr/pulls/253"},"html":{"href":"https://github.com/sgmap/beta.gouv.fr/pull/253"},"issue":{"href":"https://api.github.com/repos/sgmap/beta.gouv.fr/issues/253"},"comments":{"href":"https://api.github.com/repos/sgmap/beta.gouv.fr/issues/253/comments"},"review_comments":{"href":"https://api.github.com/repos/sgmap/beta.gouv.fr/pulls/253/comments"},"review_comment":{"href":"https://api.github.com/repos/sgmap/beta.gouv.fr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sgmap/beta.gouv.fr/pulls/253/commits"},"statuses":{"href":"https://api.github.com/repos/sgmap/beta.gouv.fr/statuses/20cf5ff1384264d9010a827226e69c45ce086072"}}}}
{"actor":{"display_login":"Morendil"}}