{"action":"created","issue":{"url":"https://api.github.com/repos/NeuronRobotics/nrjavaserial/issues/89","repository_url":"https://api.github.com/repos/NeuronRobotics/nrjavaserial","labels_url":"https://api.github.com/repos/NeuronRobotics/nrjavaserial/issues/89/labels{/name}","comments_url":"https://api.github.com/repos/NeuronRobotics/nrjavaserial/issues/89/comments","events_url":"https://api.github.com/repos/NeuronRobotics/nrjavaserial/issues/89/events","html_url":"https://github.com/NeuronRobotics/nrjavaserial/pull/89","id":187565104,"number":89,"title":"Support serial dirvers lacking internal buffers","user":{"login":"T-Svensson","id":3322397,"avatar_url":"https://avatars.githubusercontent.com/u/3322397?v=3","gravatar_id":"","url":"https://api.github.com/users/T-Svensson","html_url":"https://github.com/T-Svensson","followers_url":"https://api.github.com/users/T-Svensson/followers","following_url":"https://api.github.com/users/T-Svensson/following{/other_user}","gists_url":"https://api.github.com/users/T-Svensson/gists{/gist_id}","starred_url":"https://api.github.com/users/T-Svensson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/T-Svensson/subscriptions","organizations_url":"https://api.github.com/users/T-Svensson/orgs","repos_url":"https://api.github.com/users/T-Svensson/repos","events_url":"https://api.github.com/users/T-Svensson/events{/privacy}","received_events_url":"https://api.github.com/users/T-Svensson/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-11-06T14:38:27Z","updated_at":"2016-11-06T22:10:20Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/NeuronRobotics/nrjavaserial/pulls/89","html_url":"https://github.com/NeuronRobotics/nrjavaserial/pull/89","diff_url":"https://github.com/NeuronRobotics/nrjavaserial/pull/89.diff","patch_url":"https://github.com/NeuronRobotics/nrjavaserial/pull/89.patch"},"body":"- On Windows, some serial drivers throws an error from tcdrain() as they claim that they have no buffers. Do not treat this as a fatal error, but instead assume that the write was successful and continue on.\r\n- Do not hide the error message from tcdrain() when something goes wrong.\r\n- Revert to RXTX API so NRJavaSerial can be used as a drop-in replacement for projects using gnu.io.* classes.\r\n- Fixed some minor compilation warnings."},"comment":{"url":"https://api.github.com/repos/NeuronRobotics/nrjavaserial/issues/comments/258714883","html_url":"https://github.com/NeuronRobotics/nrjavaserial/pull/89#issuecomment-258714883","issue_url":"https://api.github.com/repos/NeuronRobotics/nrjavaserial/issues/89","id":258714883,"user":{"login":"T-Svensson","id":3322397,"avatar_url":"https://avatars.githubusercontent.com/u/3322397?v=3","gravatar_id":"","url":"https://api.github.com/users/T-Svensson","html_url":"https://github.com/T-Svensson","followers_url":"https://api.github.com/users/T-Svensson/followers","following_url":"https://api.github.com/users/T-Svensson/following{/other_user}","gists_url":"https://api.github.com/users/T-Svensson/gists{/gist_id}","starred_url":"https://api.github.com/users/T-Svensson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/T-Svensson/subscriptions","organizations_url":"https://api.github.com/users/T-Svensson/orgs","repos_url":"https://api.github.com/users/T-Svensson/repos","events_url":"https://api.github.com/users/T-Svensson/events{/privacy}","received_events_url":"https://api.github.com/users/T-Svensson/received_events","type":"User","site_admin":false},"created_at":"2016-11-06T22:10:20Z","updated_at":"2016-11-06T22:10:20Z","body":"Well, the change I did in CommPortIdentifer is one of the key changes to make it work with org.eclipse.tm.terminal, the terminal plugin provided by the Eclipse foundation.\r\nRXTX, CommPortIdentifier.java line 352 in http://rxtx.qbang.org/pub/rxtx/rxtx-2.2pre2.zip, uses the return type CommPort thus NRJavaSerial broke the API when it changed. I can't see when the change happened, since github has no record of the source before commit f24084736c1cae1519df45138f4f3243c27db73d.\r\n\r\nIt's only the first point In the description that only affects Windows, the rest affects all the different platforms."}}
{"actor":{"display_login":"T-Svensson"}}