{"push_id":1219098572,"size":148,"distinct_size":148,"ref":"refs/heads/master","head":"8887175db85b63bc2b0445b8e7f83fed530fb6ea","before":"f72a82327b172e1a2979e46cb7a579e3cc2f3bd6","commits":[{"sha":"0258813113b500f356cbcfa586edac0e43ef73ff","author":{"name":"Michael Gottesman","email":"4db64bf1b10b871c56257ec0356c24737011518b@apple.com"},"message":"Do not build SwiftReflectionTest when we are not including tests.\n\nThis avoids a cmake warning.","distinct":true,"url":"https://api.github.com/repos/CodaFi/swift/commits/0258813113b500f356cbcfa586edac0e43ef73ff"},{"sha":"34b9b9898885979d49344b6851f87e05cf6f8315","author":{"name":"Nate Cook","email":"73e3480adb94303ffae56960e010cd0b910f3957@apple.com"},"message":"[stdlib] Convert existential collection === operator to method","distinct":true,"url":"https://api.github.com/repos/CodaFi/swift/commits/34b9b9898885979d49344b6851f87e05cf6f8315"},{"sha":"7e6a1055b7cc7f9c87f89519fa75cffc438131f2","author":{"name":"Nate Cook","email":"73e3480adb94303ffae56960e010cd0b910f3957@apple.com"},"message":"stdlib: underscore AnyCollectionProtocol","distinct":true,"url":"https://api.github.com/repos/CodaFi/swift/commits/7e6a1055b7cc7f9c87f89519fa75cffc438131f2"},{"sha":"36e37ce000f1bde3e920839f58978f86da79ea9c","author":{"name":"Nate Cook","email":"73e3480adb94303ffae56960e010cd0b910f3957@apple.com"},"message":"Update renaming test","distinct":true,"url":"https://api.github.com/repos/CodaFi/swift/commits/36e37ce000f1bde3e920839f58978f86da79ea9c"},{"sha":"d7ee56088f132d20567a8b2969c2d6634459baf4","author":{"name":"Nate Cook","email":"73e3480adb94303ffae56960e010cd0b910f3957@apple.com"},"message":"[stdlib] Implement partition API change (SE-0120)","distinct":true,"url":"https://api.github.com/repos/CodaFi/swift/commits/d7ee56088f132d20567a8b2969c2d6634459baf4"},{"sha":"1d037800b9cead46db81d610bda36fb9a31f4425","author":{"name":"Nate Cook","email":"73e3480adb94303ffae56960e010cd0b910f3957@apple.com"},"message":"[stdlib] Update tests for new partition APIs\n\nSpecial thanks to @aschwaighofer for help with these tests and fix-its!","distinct":true,"url":"https://api.github.com/repos/CodaFi/swift/commits/1d037800b9cead46db81d610bda36fb9a31f4425"},{"sha":"13d1ac5b812f633d293653928349273a92ba4f93","author":{"name":"Nate Cook","email":"73e3480adb94303ffae56960e010cd0b910f3957@apple.com"},"message":"[stdlib] Update partition implementation with feedback","distinct":true,"url":"https://api.github.com/repos/CodaFi/swift/commits/13d1ac5b812f633d293653928349273a92ba4f93"},{"sha":"29bbff221b11cdee66367d532d6ca74fd276b35c","author":{"name":"Nate Cook","email":"73e3480adb94303ffae56960e010cd0b910f3957@apple.com"},"message":"[stdlib] Update partition tests with feedback","distinct":true,"url":"https://api.github.com/repos/CodaFi/swift/commits/29bbff221b11cdee66367d532d6ca74fd276b35c"},{"sha":"2a6a67118a3d4d89e393f93be3138eaebf5d419a","author":{"name":"Nate Cook","email":"73e3480adb94303ffae56960e010cd0b910f3957@apple.com"},"message":"Test partition(by:) on all mutable collections","distinct":true,"url":"https://api.github.com/repos/CodaFi/swift/commits/2a6a67118a3d4d89e393f93be3138eaebf5d419a"},{"sha":"cecc463bd0e54a809bef1a7a92bcf1f815179262","author":{"name":"Tony Parker","email":"6b0dca4dd0bff0c6c240bd20c2686320b4dd67d4@apple.com"},"message":"Rename NSOutputStream to OutputStream","distinct":true,"url":"https://api.github.com/repos/CodaFi/swift/commits/cecc463bd0e54a809bef1a7a92bcf1f815179262"},{"sha":"758cf64283082bcbaed74305aef20e0c53aee4ae","author":{"name":"Jordan Rose","email":"92520b00b4dfdc269f73534aec3bca632e7dd331@apple.com"},"message":"Rework access checking in terms of \"access scopes\".\n\n(in preparation for the private/fileprivate split)\n\nAn \"access scope\" is the outermost DeclContext where a particular\ndeclaration may be referenced: for a 'fileprivate' declaration it's\nthe enclosing file, and for an 'internal' declaration it's the module.\n'public' corresponds to a scope of \"everything\", represented by a null\nDeclContext.\n\nThis model extends naturally to the (not-yet-implemented) SE-0025\nnotion of 'private', where the access scope is a declaration's\nimmediately enclosing DeclContext.\n\nComplicating this model is the revised rules that allow, e.g., a public\ndeclaration to be declared within an internal type. The access scope\nfor this declaration is still just the module, not \"everything\".\n\nThis commit reworks formal access control checking in terms of this\nmodel, including tightening up some of the handling for '@testable'.\nThis implements the rule that you must be able to access a declaration's\ntype everywhere you can reference the declaration.\n\nThis was not intended to change compiler behavior, but in practice it\nhas made cross-file dependency tracking a bit more conservative\n(unnecessarily), caught a mistake in diagnosing access violations,\nand fixed a fuzzer-based crasher (see test changes).\n\nProgress on SE-0025 ('private' and 'fileprivate')","distinct":true,"url":"https://api.github.com/repos/CodaFi/swift/commits/758cf64283082bcbaed74305aef20e0c53aee4ae"},{"sha":"e9713d6af9af7328294a981996a5af28032800dc","author":{"name":"Jordan Rose","email":"92520b00b4dfdc269f73534aec3bca632e7dd331@apple.com"},"message":"Make the default access level 'internal'.\n\nNow that we're equipped to check the access level properly, taking\nparent scopes into account, flip the switch as specified by SE-0025:\nthe default access level everywhere is 'internal'.\n\nThe one exception is constrained extensions, as described in 306eddab.\nI haven't thought through whether these are safe or not, so for now\nI'm leaving the logic conservative. If it turns out to be safe I'll\nconsider it a bug fix.\n\nPart of SE-0025 ('fileprivate' and 'private').","distinct":true,"url":"https://api.github.com/repos/CodaFi/swift/commits/e9713d6af9af7328294a981996a5af28032800dc"},{"sha":"11baa7a14f3a914df813bbfc9b924757e9eaa1ee","author":{"name":"Steve (Numerics) Canon","email":"38cec10728e747ffd6aaefba1aa3d5ffa8bc5d76@apple.com"},"message":"Possible fix for label of isTotallyOrdered(below:).","distinct":true,"url":"https://api.github.com/repos/CodaFi/swift/commits/11baa7a14f3a914df813bbfc9b924757e9eaa1ee"},{"sha":"1716e3129c2052c8400c856af4b854e9d081dfa8","author":{"name":"Michael Gottesman","email":"4db64bf1b10b871c56257ec0356c24737011518b@apple.com"},"message":"[cmake] Do not build/link parts of LLVM that we do not use if we are not going to test LLVM.\n\nThese are parts of LLVM that Swift strictly /never/ uses, but are used by LLVM\nfor testing. In a future commit, functionality will be added to build-script to\ntest LLVM.\n\nOther parts of LLVM that can be used by Swift depending on ones configuration\nwill be disabled in a future patch via the introduction of a new components\nsystem.","distinct":true,"url":"https://api.github.com/repos/CodaFi/swift/commits/1716e3129c2052c8400c856af4b854e9d081dfa8"},{"sha":"2f68b696767983077e11a0f93a5fa4f1d90dcfc2","author":{"name":"practicalswift","email":"7bc8dfe66114fb97ee9aed052bc05e17800b570f@users.noreply.github.com"},"message":"[SourceKit] Add test case for crash triggered in swift::TypeChecker::checkInheritanceClause(swift::Decl*, swift::GenericTypeResolver*)\n\nStack trace:\n\n```\nfound code completion token A at offset 163\nswift-ide-test: /path/to/swift/lib/AST/ArchetypeBuilder.cpp:2103: static swift::Type swift::ArchetypeBuilder::mapTypeOutOfContext(swift::ModuleDecl *, swift::GenericParamList *, swift::Type): Assertion `!type->hasArchetype() && \"not fully substituted\"' failed.\n9  swift-ide-test  0x000000000097ff7f swift::TypeChecker::checkInheritanceClause(swift::Decl*, swift::GenericTypeResolver*) + 5471\n10 swift-ide-test  0x00000000009814d8 swift::TypeChecker::validateDecl(swift::ValueDecl*, bool) + 376\n13 swift-ide-test  0x0000000000986d16 swift::TypeChecker::typeCheckDecl(swift::Decl*, bool) + 150\n16 swift-ide-test  0x00000000009effe4 swift::TypeChecker::typeCheckClosureBody(swift::ClosureExpr*) + 244\n17 swift-ide-test  0x0000000000a268cc swift::constraints::ConstraintSystem::applySolution(swift::constraints::Solution&, swift::Expr*, swift::Type, bool, bool, bool) + 876\n18 swift-ide-test  0x00000000009752ba swift::TypeChecker::typeCheckExpression(swift::Expr*&, swift::DeclContext*, swift::TypeLoc, swift::ContextualTypePurpose, swift::OptionSet<swift::TypeCheckExprFlags, unsigned int>, swift::ExprTypeCheckListener*, swift::constraints::ConstraintSystem*) + 778\n21 swift-ide-test  0x00000000009eec5a swift::TypeChecker::typeCheckFunctionBodyUntil(swift::FuncDecl*, swift::SourceLoc) + 346\n22 swift-ide-test  0x00000000009eeabe swift::TypeChecker::typeCheckAbstractFunctionBodyUntil(swift::AbstractFunctionDecl*, swift::SourceLoc) + 46\n23 swift-ide-test  0x00000000009acb6f swift::typeCheckAbstractFunctionBodyUntil(swift::AbstractFunctionDecl*, swift::SourceLoc) + 655\n25 swift-ide-test  0x00000000008eeaa1 swift::performDelayedParsing(swift::DeclContext*, swift::PersistentParserState&, swift::CodeCompletionCallbacksFactory*) + 305\n26 swift-ide-test  0x00000000007a6e9d swift::CompilerInstance::performSema() + 3597\n27 swift-ide-test  0x000000000074a001 main + 34609\nStack dump:\n0.\tProgram arguments: swift-ide-test -code-completion -code-completion-token=A -source-filename=<INPUT-FILE>\n1.\tWhile type-checking expression at [<INPUT-FILE>:3:28 - line:3:38] RangeText=\"{enum a:e)\"\n2.\tWhile type-checking 'a' at <INPUT-FILE>:3:29\n```","distinct":true,"url":"https://api.github.com/repos/CodaFi/swift/commits/2f68b696767983077e11a0f93a5fa4f1d90dcfc2"},{"sha":"8b52544365483bc5ee5e7edd5498fe769b07e503","author":{"name":"practicalswift","email":"7bc8dfe66114fb97ee9aed052bc05e17800b570f@users.noreply.github.com"},"message":"[swiftc (70 vs. 5114)] Add crasher in swift::TypeChecker::resolveWitness(...)\n\nAdd test case for crash triggered in `swift::TypeChecker::resolveWitness(...)`.\n\nCurrent number of unresolved compiler crashers: 70 (5114 resolved)\n\nAssertion failure in [`lib/Sema/TypeCheckProtocol.cpp (line 1813)`](https://github.com/apple/swift/blob/master/lib/Sema/TypeCheckProtocol.cpp#L1813):\n\n```\nAssertion `(archetype != nullptr || isError) && \"Should have built archetypes already\"' failed.\n\nWhen executing: swift::Substitution getArchetypeSubstitution(swift::TypeChecker &, swift::DeclContext *, swift::ArchetypeType *, swift::Type)\n```\n\nAssertion context:\n\n```\n  assert(!resultReplacement->isTypeParameter() && \"Can't be dependent\");\n  SmallVector<ProtocolConformanceRef, 4> conformances;\n\n  bool isError = replacement->is<ErrorType>();\n  assert((archetype != nullptr || isError) &&\n         \"Should have built archetypes already\");\n\n  // FIXME: Turn the nullptr check into an assertion\n  if (archetype != nullptr) {\n    for (auto proto : archetype->getConformsTo()) {\n      ProtocolConformance *conformance = nullptr;\n```\nStack trace:\n\n```\nswift: /path/to/swift/lib/Sema/TypeCheckProtocol.cpp:1813: swift::Substitution getArchetypeSubstitution(swift::TypeChecker &, swift::DeclContext *, swift::ArchetypeType *, swift::Type): Assertion `(archetype != nullptr || isError) && \"Should have built archetypes already\"' failed.\n11 swift           0x0000000000f13609 swift::TypeChecker::resolveWitness(swift::NormalProtocolConformance const*, swift::ValueDecl*) + 569\n12 swift           0x000000000113001b swift::NormalProtocolConformance::getWitness(swift::ValueDecl*, swift::LazyResolver*) const + 171\n14 swift           0x0000000000f05d24 swift::TypeChecker::lookupUnqualified(swift::DeclContext*, swift::DeclName, swift::SourceLoc, swift::OptionSet<swift::NameLookupFlags, unsigned int>) + 404\n15 swift           0x0000000000eaf03c swift::TypeChecker::resolveDeclRefExpr(swift::UnresolvedDeclRefExpr*, swift::DeclContext*) + 108\n17 swift           0x000000000108188b swift::Expr::walk(swift::ASTWalker&) + 27\n18 swift           0x0000000000eb0770 swift::TypeChecker::solveForExpression(swift::Expr*&, swift::DeclContext*, swift::Type, swift::FreeTypeVariableBinding, swift::ExprTypeCheckListener*, swift::constraints::ConstraintSystem&, llvm::SmallVectorImpl<swift::constraints::Solution>&, swift::OptionSet<swift::TypeCheckExprFlags, unsigned int>) + 224\n19 swift           0x0000000000eb75ad swift::TypeChecker::typeCheckExpression(swift::Expr*&, swift::DeclContext*, swift::TypeLoc, swift::ContextualTypePurpose, swift::OptionSet<swift::TypeCheckExprFlags, unsigned int>, swift::ExprTypeCheckListener*, swift::constraints::ConstraintSystem*) + 621\n20 swift           0x0000000000eb8760 swift::TypeChecker::typeCheckBinding(swift::Pattern*&, swift::Expr*&, swift::DeclContext*) + 352\n21 swift           0x0000000000eb897b swift::TypeChecker::typeCheckPatternBinding(swift::PatternBindingDecl*, unsigned int) + 267\n23 swift           0x0000000000ec4d1d swift::TypeChecker::validateDecl(swift::ValueDecl*, bool) + 3853\n29 swift           0x0000000000ec95b6 swift::TypeChecker::typeCheckDecl(swift::Decl*, bool) + 150\n30 swift           0x0000000000eebde2 swift::performTypeChecking(swift::SourceFile&, swift::TopLevelContext&, swift::OptionSet<swift::TypeCheckingFlags, unsigned int>, unsigned int, unsigned int) + 1026\n31 swift           0x0000000000c735c9 swift::CompilerInstance::performSema() + 3289\n33 swift           0x00000000007d9277 swift::performFrontend(llvm::ArrayRef<char const*>, char const*, void*, swift::FrontendObserver*) + 2887\n34 swift           0x00000000007a5278 main + 2872\nStack dump:\n0.\tProgram arguments: /path/to/swift/bin/swift -frontend -c -primary-file validation-test/compiler_crashers/28374-swift-typechecker-resolvewitness.swift -target x86_64-unknown-linux-gnu -disable-objc-interop -module-name main -o /tmp/28374-swift-typechecker-resolvewitness-9c17ae.o\n1.\tWhile type-checking 'a' at validation-test/compiler_crashers/28374-swift-typechecker-resolvewitness.swift:10:1\n2.\tWhile type-checking expression at [validation-test/compiler_crashers/28374-swift-typechecker-resolvewitness.swift:15:7 - line:15:7] RangeText=\"B\"\n<unknown>:0: error: unable to execute command: Aborted\n<unknown>:0: error: compile command failed due to signal (use -v to see invocation)\n```","distinct":true,"url":"https://api.github.com/repos/CodaFi/swift/commits/8b52544365483bc5ee5e7edd5498fe769b07e503"},{"sha":"e4b27cdc82693bd28e989db1f93222422fc14fe9","author":{"name":"Ben Langmuir","email":"24208d537a689fccffa1f56cc0529d81ef0b3926@apple.com"},"message":"[CodeCompletion] Clear TypeVariableTypes from unresolved member expressions\n\nThis prevents use-after-free when the contraint system arean goes away.\n\nrdar://problem/26057202","distinct":true,"url":"https://api.github.com/repos/CodaFi/swift/commits/e4b27cdc82693bd28e989db1f93222422fc14fe9"},{"sha":"97380795631587fa1d626ddb9cf62d3079b516d9","author":{"name":"Slava Pestov","email":"9e16c7b0af09ed5751f270a67048f3177998c735@apple.com"},"message":"AST: Remove unused getWithoutNoReturn() method, NFC","distinct":true,"url":"https://api.github.com/repos/CodaFi/swift/commits/97380795631587fa1d626ddb9cf62d3079b516d9"},{"sha":"6ff02a9fe2fdc52a74977ad1fb2cf8302bc2a63f","author":{"name":"Slava Pestov","email":"9e16c7b0af09ed5751f270a67048f3177998c735@apple.com"},"message":"AST/SIL: Add a new Never type, and a TypeBase::isNever() check\n\nMostly NFC, this is just plumbing for the next patch.\nNote that isNever() returns true for any uninhabited\nenum.\n\nIt should be generalized so that stuff like (Never, Int)\nis also known to be uninhabited, or even to support\ngeneric substitutions that yield uninhabited types,\nbut for now I really see no reason to go that far, and\nthe current check for an enum with no cases seems\nperfectly adequate.","distinct":true,"url":"https://api.github.com/repos/CodaFi/swift/commits/6ff02a9fe2fdc52a74977ad1fb2cf8302bc2a63f"},{"sha":"4022624dbab68d139bd207e3eaa2891ae886c21d","author":{"name":"Slava Pestov","email":"9e16c7b0af09ed5751f270a67048f3177998c735@apple.com"},"message":"stdlib: Rename _unimplemented_initializer to _unimplementedInitializer, NFC\n\nThis addresses a FIXME.","distinct":true,"url":"https://api.github.com/repos/CodaFi/swift/commits/4022624dbab68d139bd207e3eaa2891ae886c21d"}]}
{"actor":{"display_login":"CodaFi"}}