{"action":"created","comment":{"url":"https://api.github.com/repos/getsentry/sentry/pulls/comments/88720555","pull_request_review_id":9288024,"id":88720555,"diff_hunk":"@@ -132,10 +132,10 @@ const ReleaseDetails = React.createClass({\n               </div>\n             </div>\n             <ul className=\"nav nav-tabs\">\n-              <ListLink to={`/${orgId}/${projectId}/releases/${encodeURIComponent(release.version)}/`} isActive={(to)=> {\n+              <ListLink to={`/${orgId}/${projectId}/releases/${encodeURIComponent(release.version)}/`} isActive={(loc) => {\n                 // react-router isActive will return true for any route that is part of the active route\n                 // e.g. parent routes. To avoid matching on sub-routes, insist on strict path equality.\n-                return to === this.context.location.pathname;\n+                return loc.pathname === this.props.location.pathname;","path":"src/sentry/static/sentry/app/views/releaseDetails.jsx","position":9,"original_position":9,"commit_id":"22f2b378dbb7056eb631f8591f1b3de2eeddcb07","original_commit_id":"22f2b378dbb7056eb631f8591f1b3de2eeddcb07","user":{"login":"macqueen","id":5026776,"avatar_url":"https://avatars.githubusercontent.com/u/5026776?v=3","gravatar_id":"","url":"https://api.github.com/users/macqueen","html_url":"https://github.com/macqueen","followers_url":"https://api.github.com/users/macqueen/followers","following_url":"https://api.github.com/users/macqueen/following{/other_user}","gists_url":"https://api.github.com/users/macqueen/gists{/gist_id}","starred_url":"https://api.github.com/users/macqueen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/macqueen/subscriptions","organizations_url":"https://api.github.com/users/macqueen/orgs","repos_url":"https://api.github.com/users/macqueen/repos","events_url":"https://api.github.com/users/macqueen/events{/privacy}","received_events_url":"https://api.github.com/users/macqueen/received_events","type":"User","site_admin":false},"body":"yeah, [upgrade guide](https://github.com/ReactTraining/react-router/blob/master/upgrade-guides/v2.0.0.md#accessing-location) and [docs](https://github.com/ReactTraining/react-router/blob/v2.8.1/docs/API.md#route-components) for more details","created_at":"2016-11-18T19:15:26Z","updated_at":"2016-11-18T19:15:34Z","html_url":"https://github.com/getsentry/sentry/pull/4555#discussion_r88720555","pull_request_url":"https://api.github.com/repos/getsentry/sentry/pulls/4555","_links":{"self":{"href":"https://api.github.com/repos/getsentry/sentry/pulls/comments/88720555"},"html":{"href":"https://github.com/getsentry/sentry/pull/4555#discussion_r88720555"},"pull_request":{"href":"https://api.github.com/repos/getsentry/sentry/pulls/4555"}}},"pull_request":{"url":"https://api.github.com/repos/getsentry/sentry/pulls/4555","id":94285066,"html_url":"https://github.com/getsentry/sentry/pull/4555","diff_url":"https://github.com/getsentry/sentry/pull/4555.diff","patch_url":"https://github.com/getsentry/sentry/pull/4555.patch","issue_url":"https://api.github.com/repos/getsentry/sentry/issues/4555","number":4555,"state":"open","locked":false,"title":"upgrade react-router to 2.8.1","user":{"login":"macqueen","id":5026776,"avatar_url":"https://avatars.githubusercontent.com/u/5026776?v=3","gravatar_id":"","url":"https://api.github.com/users/macqueen","html_url":"https://github.com/macqueen","followers_url":"https://api.github.com/users/macqueen/followers","following_url":"https://api.github.com/users/macqueen/following{/other_user}","gists_url":"https://api.github.com/users/macqueen/gists{/gist_id}","starred_url":"https://api.github.com/users/macqueen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/macqueen/subscriptions","organizations_url":"https://api.github.com/users/macqueen/orgs","repos_url":"https://api.github.com/users/macqueen/repos","events_url":"https://api.github.com/users/macqueen/events{/privacy}","received_events_url":"https://api.github.com/users/macqueen/received_events","type":"User","site_admin":false},"body":"change log here: https://github.com/ReactTraining/react-router/blob/master/CHANGES.md\r\n\r\nmain things that affected us are:\r\n- deprecated all mixins -- the `History` one was the only one we were using\r\n- replaced `context.history` with `context.router`\r\n- deprecated `context.location` (you can get around this by defining `getChildContext` in our parent `App` component\r\n- changed prop types/arguments for `<Link/>` and `isActive` to accept either a string or a [location descriptor](https://github.com/ReactTraining/react-router/blob/master/upgrade-guides/v2.0.0.md#link-to-onenter-and-isactive-use-location-descriptors) instead of having separate `query` and `state` props/arguments\r\n\r\nother notes:\r\n- upgrading this also made all of the proptype warnings coming from react-router go away\r\n- i also need to make similar updates in getsentry\r\n\r\n@getsentry/product ","created_at":"2016-11-18T01:07:41Z","updated_at":"2016-11-18T19:15:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"97565ee8f39dcca56371603d3ba9e8ed581c1630","assignee":{"login":"benvinegar","id":2153,"avatar_url":"https://avatars.githubusercontent.com/u/2153?v=3","gravatar_id":"","url":"https://api.github.com/users/benvinegar","html_url":"https://github.com/benvinegar","followers_url":"https://api.github.com/users/benvinegar/followers","following_url":"https://api.github.com/users/benvinegar/following{/other_user}","gists_url":"https://api.github.com/users/benvinegar/gists{/gist_id}","starred_url":"https://api.github.com/users/benvinegar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benvinegar/subscriptions","organizations_url":"https://api.github.com/users/benvinegar/orgs","repos_url":"https://api.github.com/users/benvinegar/repos","events_url":"https://api.github.com/users/benvinegar/events{/privacy}","received_events_url":"https://api.github.com/users/benvinegar/received_events","type":"User","site_admin":false},"assignees":[{"login":"benvinegar","id":2153,"avatar_url":"https://avatars.githubusercontent.com/u/2153?v=3","gravatar_id":"","url":"https://api.github.com/users/benvinegar","html_url":"https://github.com/benvinegar","followers_url":"https://api.github.com/users/benvinegar/followers","following_url":"https://api.github.com/users/benvinegar/following{/other_user}","gists_url":"https://api.github.com/users/benvinegar/gists{/gist_id}","starred_url":"https://api.github.com/users/benvinegar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benvinegar/subscriptions","organizations_url":"https://api.github.com/users/benvinegar/orgs","repos_url":"https://api.github.com/users/benvinegar/repos","events_url":"https://api.github.com/users/benvinegar/events{/privacy}","received_events_url":"https://api.github.com/users/benvinegar/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/getsentry/sentry/pulls/4555/commits","review_comments_url":"https://api.github.com/repos/getsentry/sentry/pulls/4555/comments","review_comment_url":"https://api.github.com/repos/getsentry/sentry/pulls/comments{/number}","comments_url":"https://api.github.com/repos/getsentry/sentry/issues/4555/comments","statuses_url":"https://api.github.com/repos/getsentry/sentry/statuses/22f2b378dbb7056eb631f8591f1b3de2eeddcb07","head":{"label":"getsentry:upgrade-react-router","ref":"upgrade-react-router","sha":"22f2b378dbb7056eb631f8591f1b3de2eeddcb07","user":{"login":"getsentry","id":1396951,"avatar_url":"https://avatars.githubusercontent.com/u/1396951?v=3","gravatar_id":"","url":"https://api.github.com/users/getsentry","html_url":"https://github.com/getsentry","followers_url":"https://api.github.com/users/getsentry/followers","following_url":"https://api.github.com/users/getsentry/following{/other_user}","gists_url":"https://api.github.com/users/getsentry/gists{/gist_id}","starred_url":"https://api.github.com/users/getsentry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getsentry/subscriptions","organizations_url":"https://api.github.com/users/getsentry/orgs","repos_url":"https://api.github.com/users/getsentry/repos","events_url":"https://api.github.com/users/getsentry/events{/privacy}","received_events_url":"https://api.github.com/users/getsentry/received_events","type":"Organization","site_admin":false},"repo":{"id":873328,"name":"sentry","full_name":"getsentry/sentry","owner":{"login":"getsentry","id":1396951,"avatar_url":"https://avatars.githubusercontent.com/u/1396951?v=3","gravatar_id":"","url":"https://api.github.com/users/getsentry","html_url":"https://github.com/getsentry","followers_url":"https://api.github.com/users/getsentry/followers","following_url":"https://api.github.com/users/getsentry/following{/other_user}","gists_url":"https://api.github.com/users/getsentry/gists{/gist_id}","starred_url":"https://api.github.com/users/getsentry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getsentry/subscriptions","organizations_url":"https://api.github.com/users/getsentry/orgs","repos_url":"https://api.github.com/users/getsentry/repos","events_url":"https://api.github.com/users/getsentry/events{/privacy}","received_events_url":"https://api.github.com/users/getsentry/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/getsentry/sentry","description":"Sentry is cross-platform crash reporting built with love","fork":false,"url":"https://api.github.com/repos/getsentry/sentry","forks_url":"https://api.github.com/repos/getsentry/sentry/forks","keys_url":"https://api.github.com/repos/getsentry/sentry/keys{/key_id}","collaborators_url":"https://api.github.com/repos/getsentry/sentry/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/getsentry/sentry/teams","hooks_url":"https://api.github.com/repos/getsentry/sentry/hooks","issue_events_url":"https://api.github.com/repos/getsentry/sentry/issues/events{/number}","events_url":"https://api.github.com/repos/getsentry/sentry/events","assignees_url":"https://api.github.com/repos/getsentry/sentry/assignees{/user}","branches_url":"https://api.github.com/repos/getsentry/sentry/branches{/branch}","tags_url":"https://api.github.com/repos/getsentry/sentry/tags","blobs_url":"https://api.github.com/repos/getsentry/sentry/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/getsentry/sentry/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/getsentry/sentry/git/refs{/sha}","trees_url":"https://api.github.com/repos/getsentry/sentry/git/trees{/sha}","statuses_url":"https://api.github.com/repos/getsentry/sentry/statuses/{sha}","languages_url":"https://api.github.com/repos/getsentry/sentry/languages","stargazers_url":"https://api.github.com/repos/getsentry/sentry/stargazers","contributors_url":"https://api.github.com/repos/getsentry/sentry/contributors","subscribers_url":"https://api.github.com/repos/getsentry/sentry/subscribers","subscription_url":"https://api.github.com/repos/getsentry/sentry/subscription","commits_url":"https://api.github.com/repos/getsentry/sentry/commits{/sha}","git_commits_url":"https://api.github.com/repos/getsentry/sentry/git/commits{/sha}","comments_url":"https://api.github.com/repos/getsentry/sentry/comments{/number}","issue_comment_url":"https://api.github.com/repos/getsentry/sentry/issues/comments{/number}","contents_url":"https://api.github.com/repos/getsentry/sentry/contents/{+path}","compare_url":"https://api.github.com/repos/getsentry/sentry/compare/{base}...{head}","merges_url":"https://api.github.com/repos/getsentry/sentry/merges","archive_url":"https://api.github.com/repos/getsentry/sentry/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/getsentry/sentry/downloads","issues_url":"https://api.github.com/repos/getsentry/sentry/issues{/number}","pulls_url":"https://api.github.com/repos/getsentry/sentry/pulls{/number}","milestones_url":"https://api.github.com/repos/getsentry/sentry/milestones{/number}","notifications_url":"https://api.github.com/repos/getsentry/sentry/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/getsentry/sentry/labels{/name}","releases_url":"https://api.github.com/repos/getsentry/sentry/releases{/id}","deployments_url":"https://api.github.com/repos/getsentry/sentry/deployments","created_at":"2010-08-30T22:06:41Z","updated_at":"2016-11-18T16:16:11Z","pushed_at":"2016-11-18T19:05:58Z","git_url":"git://github.com/getsentry/sentry.git","ssh_url":"git@github.com:getsentry/sentry.git","clone_url":"https://github.com/getsentry/sentry.git","svn_url":"https://github.com/getsentry/sentry","homepage":"https://sentry.io","size":92453,"stargazers_count":10974,"watchers_count":10974,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1309,"mirror_url":null,"open_issues_count":439,"forks":1309,"open_issues":439,"watchers":10974,"default_branch":"master"}},"base":{"label":"getsentry:master","ref":"master","sha":"26d701b19668941e9822b1d7054728461cebf06f","user":{"login":"getsentry","id":1396951,"avatar_url":"https://avatars.githubusercontent.com/u/1396951?v=3","gravatar_id":"","url":"https://api.github.com/users/getsentry","html_url":"https://github.com/getsentry","followers_url":"https://api.github.com/users/getsentry/followers","following_url":"https://api.github.com/users/getsentry/following{/other_user}","gists_url":"https://api.github.com/users/getsentry/gists{/gist_id}","starred_url":"https://api.github.com/users/getsentry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getsentry/subscriptions","organizations_url":"https://api.github.com/users/getsentry/orgs","repos_url":"https://api.github.com/users/getsentry/repos","events_url":"https://api.github.com/users/getsentry/events{/privacy}","received_events_url":"https://api.github.com/users/getsentry/received_events","type":"Organization","site_admin":false},"repo":{"id":873328,"name":"sentry","full_name":"getsentry/sentry","owner":{"login":"getsentry","id":1396951,"avatar_url":"https://avatars.githubusercontent.com/u/1396951?v=3","gravatar_id":"","url":"https://api.github.com/users/getsentry","html_url":"https://github.com/getsentry","followers_url":"https://api.github.com/users/getsentry/followers","following_url":"https://api.github.com/users/getsentry/following{/other_user}","gists_url":"https://api.github.com/users/getsentry/gists{/gist_id}","starred_url":"https://api.github.com/users/getsentry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getsentry/subscriptions","organizations_url":"https://api.github.com/users/getsentry/orgs","repos_url":"https://api.github.com/users/getsentry/repos","events_url":"https://api.github.com/users/getsentry/events{/privacy}","received_events_url":"https://api.github.com/users/getsentry/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/getsentry/sentry","description":"Sentry is cross-platform crash reporting built with love","fork":false,"url":"https://api.github.com/repos/getsentry/sentry","forks_url":"https://api.github.com/repos/getsentry/sentry/forks","keys_url":"https://api.github.com/repos/getsentry/sentry/keys{/key_id}","collaborators_url":"https://api.github.com/repos/getsentry/sentry/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/getsentry/sentry/teams","hooks_url":"https://api.github.com/repos/getsentry/sentry/hooks","issue_events_url":"https://api.github.com/repos/getsentry/sentry/issues/events{/number}","events_url":"https://api.github.com/repos/getsentry/sentry/events","assignees_url":"https://api.github.com/repos/getsentry/sentry/assignees{/user}","branches_url":"https://api.github.com/repos/getsentry/sentry/branches{/branch}","tags_url":"https://api.github.com/repos/getsentry/sentry/tags","blobs_url":"https://api.github.com/repos/getsentry/sentry/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/getsentry/sentry/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/getsentry/sentry/git/refs{/sha}","trees_url":"https://api.github.com/repos/getsentry/sentry/git/trees{/sha}","statuses_url":"https://api.github.com/repos/getsentry/sentry/statuses/{sha}","languages_url":"https://api.github.com/repos/getsentry/sentry/languages","stargazers_url":"https://api.github.com/repos/getsentry/sentry/stargazers","contributors_url":"https://api.github.com/repos/getsentry/sentry/contributors","subscribers_url":"https://api.github.com/repos/getsentry/sentry/subscribers","subscription_url":"https://api.github.com/repos/getsentry/sentry/subscription","commits_url":"https://api.github.com/repos/getsentry/sentry/commits{/sha}","git_commits_url":"https://api.github.com/repos/getsentry/sentry/git/commits{/sha}","comments_url":"https://api.github.com/repos/getsentry/sentry/comments{/number}","issue_comment_url":"https://api.github.com/repos/getsentry/sentry/issues/comments{/number}","contents_url":"https://api.github.com/repos/getsentry/sentry/contents/{+path}","compare_url":"https://api.github.com/repos/getsentry/sentry/compare/{base}...{head}","merges_url":"https://api.github.com/repos/getsentry/sentry/merges","archive_url":"https://api.github.com/repos/getsentry/sentry/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/getsentry/sentry/downloads","issues_url":"https://api.github.com/repos/getsentry/sentry/issues{/number}","pulls_url":"https://api.github.com/repos/getsentry/sentry/pulls{/number}","milestones_url":"https://api.github.com/repos/getsentry/sentry/milestones{/number}","notifications_url":"https://api.github.com/repos/getsentry/sentry/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/getsentry/sentry/labels{/name}","releases_url":"https://api.github.com/repos/getsentry/sentry/releases{/id}","deployments_url":"https://api.github.com/repos/getsentry/sentry/deployments","created_at":"2010-08-30T22:06:41Z","updated_at":"2016-11-18T16:16:11Z","pushed_at":"2016-11-18T19:05:58Z","git_url":"git://github.com/getsentry/sentry.git","ssh_url":"git@github.com:getsentry/sentry.git","clone_url":"https://github.com/getsentry/sentry.git","svn_url":"https://github.com/getsentry/sentry","homepage":"https://sentry.io","size":92453,"stargazers_count":10974,"watchers_count":10974,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1309,"mirror_url":null,"open_issues_count":439,"forks":1309,"open_issues":439,"watchers":10974,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/getsentry/sentry/pulls/4555"},"html":{"href":"https://github.com/getsentry/sentry/pull/4555"},"issue":{"href":"https://api.github.com/repos/getsentry/sentry/issues/4555"},"comments":{"href":"https://api.github.com/repos/getsentry/sentry/issues/4555/comments"},"review_comments":{"href":"https://api.github.com/repos/getsentry/sentry/pulls/4555/comments"},"review_comment":{"href":"https://api.github.com/repos/getsentry/sentry/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/getsentry/sentry/pulls/4555/commits"},"statuses":{"href":"https://api.github.com/repos/getsentry/sentry/statuses/22f2b378dbb7056eb631f8591f1b3de2eeddcb07"}}}}
{"actor":{"display_login":"macqueen"}}