{"action":"created","comment":{"url":"https://api.github.com/repos/orocos/rtt_soem/pulls/comments/83642810","pull_request_review_id":4472418,"id":83642810,"diff_hunk":"@@ -94,6 +107,33 @@ bool SoemMasterComponent::configureHook()\n             // wait for all slaves to reach PRE_OP state\n             ec_statecheck(0, EC_STATE_PRE_OP, EC_TIMEOUTSTATE);\n \n+            // The state should be verified for every slave because calling\n+            // ec_statecheck(0, EC_STATE_SAFE_OP, EC_TIMEOUTSTATE);\n+            // otherwise the member state of every slave wouldn't be updated\n+            for(int i = 0; i <= ec_slavecount; i++)\n+            {\n+               ec_statecheck(i, EC_STATE_PRE_OP, EC_TIMEOUTSTATE);\n+            }\n+\n+            /* The parameter to be sent to the slaves are loaded */\n+            for (unsigned int i=0; i < parameters.size(); i++)\n+            {\n+               int wkc;\n+               addressInfo tmp;\n+               tmp.slavePosition = parameters[i].slavePosition;\n+               tmp.index = parameters[i].index;\n+               tmp.subIndex = parameters[i].subIndex;\n+\t\t    \n+               wkc = writeCoeSDO(&tmp,parameters[i].completeAccess,parameters[i].size,&parameters[i].param);\n+\n+               if(wkc == 0)\n+               {\n+                  log(Error) << \"Slave_\" << tmp.slavePosition <<\" SDOwrite{index[\"<< tmp.index\n+                             << \"] subindex[\"<< (int)tmp.subIndex <<\"] size \"<< parameters[i].size\n+                             << \" value \"<< parameters[i].param << \"} wkc \"<< wkc << endlog();\n+               }\n+            }\n+","path":"soem_master/soem_master_component.cpp","position":61,"original_position":61,"commit_id":"59de91a9e85d5e06a7fd462432901bd5bea60a58","original_commit_id":"59de91a9e85d5e06a7fd462432901bd5bea60a58","user":{"login":"MagnaboscoL","id":21257550,"avatar_url":"https://avatars.githubusercontent.com/u/21257550?v=3","gravatar_id":"","url":"https://api.github.com/users/MagnaboscoL","html_url":"https://github.com/MagnaboscoL","followers_url":"https://api.github.com/users/MagnaboscoL/followers","following_url":"https://api.github.com/users/MagnaboscoL/following{/other_user}","gists_url":"https://api.github.com/users/MagnaboscoL/gists{/gist_id}","starred_url":"https://api.github.com/users/MagnaboscoL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MagnaboscoL/subscriptions","organizations_url":"https://api.github.com/users/MagnaboscoL/orgs","repos_url":"https://api.github.com/users/MagnaboscoL/repos","events_url":"https://api.github.com/users/MagnaboscoL/events{/privacy}","received_events_url":"https://api.github.com/users/MagnaboscoL/received_events","type":"User","site_admin":false},"body":"Of course the CoE writing could happen in the driver's configure function (and I would have preferred that) but was placed here since the property \"slavesCoeParameters\" is a master's property.\r\nAs described above I think that the whole matter is totally depending on the parameterization approach so any suggestion to improve that is welcome.","created_at":"2016-10-17T13:32:43Z","updated_at":"2016-10-17T13:32:43Z","html_url":"https://github.com/orocos/rtt_soem/pull/10#discussion_r83642810","pull_request_url":"https://api.github.com/repos/orocos/rtt_soem/pulls/10","_links":{"self":{"href":"https://api.github.com/repos/orocos/rtt_soem/pulls/comments/83642810"},"html":{"href":"https://github.com/orocos/rtt_soem/pull/10#discussion_r83642810"},"pull_request":{"href":"https://api.github.com/repos/orocos/rtt_soem/pulls/10"}}},"pull_request":{"url":"https://api.github.com/repos/orocos/rtt_soem/pulls/10","id":89388528,"html_url":"https://github.com/orocos/rtt_soem/pull/10","diff_url":"https://github.com/orocos/rtt_soem/pull/10.diff","patch_url":"https://github.com/orocos/rtt_soem/pull/10.patch","issue_url":"https://api.github.com/repos/orocos/rtt_soem/issues/10","number":10,"state":"open","locked":false,"title":"Feature/coe parametrization (#1)","user":{"login":"MagnaboscoL","id":21257550,"avatar_url":"https://avatars.githubusercontent.com/u/21257550?v=3","gravatar_id":"","url":"https://api.github.com/users/MagnaboscoL","html_url":"https://github.com/MagnaboscoL","followers_url":"https://api.github.com/users/MagnaboscoL/followers","following_url":"https://api.github.com/users/MagnaboscoL/following{/other_user}","gists_url":"https://api.github.com/users/MagnaboscoL/gists{/gist_id}","starred_url":"https://api.github.com/users/MagnaboscoL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MagnaboscoL/subscriptions","organizations_url":"https://api.github.com/users/MagnaboscoL/orgs","repos_url":"https://api.github.com/users/MagnaboscoL/repos","events_url":"https://api.github.com/users/MagnaboscoL/events{/privacy}","received_events_url":"https://api.github.com/users/MagnaboscoL/received_events","type":"User","site_admin":false},"body":"* Each slave can be parametrized differently since its CoE parameters are loaded from the file soem.cpf.\r\n* Fix the ec_state unknown issue in the Task Browser\r\n* Fix the master/slaves state mismatch\r\n\r\n@smits PTAL","created_at":"2016-10-14T13:53:33Z","updated_at":"2016-10-17T13:32:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cb759a5394fed652e07abbaf526b543f21140184","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/orocos/rtt_soem/pulls/10/commits","review_comments_url":"https://api.github.com/repos/orocos/rtt_soem/pulls/10/comments","review_comment_url":"https://api.github.com/repos/orocos/rtt_soem/pulls/comments{/number}","comments_url":"https://api.github.com/repos/orocos/rtt_soem/issues/10/comments","statuses_url":"https://api.github.com/repos/orocos/rtt_soem/statuses/59de91a9e85d5e06a7fd462432901bd5bea60a58","head":{"label":"MagnaboscoL:master","ref":"master","sha":"59de91a9e85d5e06a7fd462432901bd5bea60a58","user":{"login":"MagnaboscoL","id":21257550,"avatar_url":"https://avatars.githubusercontent.com/u/21257550?v=3","gravatar_id":"","url":"https://api.github.com/users/MagnaboscoL","html_url":"https://github.com/MagnaboscoL","followers_url":"https://api.github.com/users/MagnaboscoL/followers","following_url":"https://api.github.com/users/MagnaboscoL/following{/other_user}","gists_url":"https://api.github.com/users/MagnaboscoL/gists{/gist_id}","starred_url":"https://api.github.com/users/MagnaboscoL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MagnaboscoL/subscriptions","organizations_url":"https://api.github.com/users/MagnaboscoL/orgs","repos_url":"https://api.github.com/users/MagnaboscoL/repos","events_url":"https://api.github.com/users/MagnaboscoL/events{/privacy}","received_events_url":"https://api.github.com/users/MagnaboscoL/received_events","type":"User","site_admin":false},"repo":{"id":70908490,"name":"rtt_soem","full_name":"MagnaboscoL/rtt_soem","owner":{"login":"MagnaboscoL","id":21257550,"avatar_url":"https://avatars.githubusercontent.com/u/21257550?v=3","gravatar_id":"","url":"https://api.github.com/users/MagnaboscoL","html_url":"https://github.com/MagnaboscoL","followers_url":"https://api.github.com/users/MagnaboscoL/followers","following_url":"https://api.github.com/users/MagnaboscoL/following{/other_user}","gists_url":"https://api.github.com/users/MagnaboscoL/gists{/gist_id}","starred_url":"https://api.github.com/users/MagnaboscoL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MagnaboscoL/subscriptions","organizations_url":"https://api.github.com/users/MagnaboscoL/orgs","repos_url":"https://api.github.com/users/MagnaboscoL/repos","events_url":"https://api.github.com/users/MagnaboscoL/events{/privacy}","received_events_url":"https://api.github.com/users/MagnaboscoL/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MagnaboscoL/rtt_soem","description":"RTT SOEM EtherCAT components and drivers","fork":true,"url":"https://api.github.com/repos/MagnaboscoL/rtt_soem","forks_url":"https://api.github.com/repos/MagnaboscoL/rtt_soem/forks","keys_url":"https://api.github.com/repos/MagnaboscoL/rtt_soem/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MagnaboscoL/rtt_soem/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MagnaboscoL/rtt_soem/teams","hooks_url":"https://api.github.com/repos/MagnaboscoL/rtt_soem/hooks","issue_events_url":"https://api.github.com/repos/MagnaboscoL/rtt_soem/issues/events{/number}","events_url":"https://api.github.com/repos/MagnaboscoL/rtt_soem/events","assignees_url":"https://api.github.com/repos/MagnaboscoL/rtt_soem/assignees{/user}","branches_url":"https://api.github.com/repos/MagnaboscoL/rtt_soem/branches{/branch}","tags_url":"https://api.github.com/repos/MagnaboscoL/rtt_soem/tags","blobs_url":"https://api.github.com/repos/MagnaboscoL/rtt_soem/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MagnaboscoL/rtt_soem/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MagnaboscoL/rtt_soem/git/refs{/sha}","trees_url":"https://api.github.com/repos/MagnaboscoL/rtt_soem/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MagnaboscoL/rtt_soem/statuses/{sha}","languages_url":"https://api.github.com/repos/MagnaboscoL/rtt_soem/languages","stargazers_url":"https://api.github.com/repos/MagnaboscoL/rtt_soem/stargazers","contributors_url":"https://api.github.com/repos/MagnaboscoL/rtt_soem/contributors","subscribers_url":"https://api.github.com/repos/MagnaboscoL/rtt_soem/subscribers","subscription_url":"https://api.github.com/repos/MagnaboscoL/rtt_soem/subscription","commits_url":"https://api.github.com/repos/MagnaboscoL/rtt_soem/commits{/sha}","git_commits_url":"https://api.github.com/repos/MagnaboscoL/rtt_soem/git/commits{/sha}","comments_url":"https://api.github.com/repos/MagnaboscoL/rtt_soem/comments{/number}","issue_comment_url":"https://api.github.com/repos/MagnaboscoL/rtt_soem/issues/comments{/number}","contents_url":"https://api.github.com/repos/MagnaboscoL/rtt_soem/contents/{+path}","compare_url":"https://api.github.com/repos/MagnaboscoL/rtt_soem/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MagnaboscoL/rtt_soem/merges","archive_url":"https://api.github.com/repos/MagnaboscoL/rtt_soem/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MagnaboscoL/rtt_soem/downloads","issues_url":"https://api.github.com/repos/MagnaboscoL/rtt_soem/issues{/number}","pulls_url":"https://api.github.com/repos/MagnaboscoL/rtt_soem/pulls{/number}","milestones_url":"https://api.github.com/repos/MagnaboscoL/rtt_soem/milestones{/number}","notifications_url":"https://api.github.com/repos/MagnaboscoL/rtt_soem/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MagnaboscoL/rtt_soem/labels{/name}","releases_url":"https://api.github.com/repos/MagnaboscoL/rtt_soem/releases{/id}","deployments_url":"https://api.github.com/repos/MagnaboscoL/rtt_soem/deployments","created_at":"2016-10-14T12:32:04Z","updated_at":"2016-10-14T12:32:06Z","pushed_at":"2016-10-14T13:42:40Z","git_url":"git://github.com/MagnaboscoL/rtt_soem.git","ssh_url":"git@github.com:MagnaboscoL/rtt_soem.git","clone_url":"https://github.com/MagnaboscoL/rtt_soem.git","svn_url":"https://github.com/MagnaboscoL/rtt_soem","homepage":null,"size":149,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"orocos:master","ref":"master","sha":"97d0cb9d4fa608a9acf8f49a177e617217ccc5c2","user":{"login":"orocos","id":360585,"avatar_url":"https://avatars.githubusercontent.com/u/360585?v=3","gravatar_id":"","url":"https://api.github.com/users/orocos","html_url":"https://github.com/orocos","followers_url":"https://api.github.com/users/orocos/followers","following_url":"https://api.github.com/users/orocos/following{/other_user}","gists_url":"https://api.github.com/users/orocos/gists{/gist_id}","starred_url":"https://api.github.com/users/orocos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orocos/subscriptions","organizations_url":"https://api.github.com/users/orocos/orgs","repos_url":"https://api.github.com/users/orocos/repos","events_url":"https://api.github.com/users/orocos/events{/privacy}","received_events_url":"https://api.github.com/users/orocos/received_events","type":"Organization","site_admin":false},"repo":{"id":17054268,"name":"rtt_soem","full_name":"orocos/rtt_soem","owner":{"login":"orocos","id":360585,"avatar_url":"https://avatars.githubusercontent.com/u/360585?v=3","gravatar_id":"","url":"https://api.github.com/users/orocos","html_url":"https://github.com/orocos","followers_url":"https://api.github.com/users/orocos/followers","following_url":"https://api.github.com/users/orocos/following{/other_user}","gists_url":"https://api.github.com/users/orocos/gists{/gist_id}","starred_url":"https://api.github.com/users/orocos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orocos/subscriptions","organizations_url":"https://api.github.com/users/orocos/orgs","repos_url":"https://api.github.com/users/orocos/repos","events_url":"https://api.github.com/users/orocos/events{/privacy}","received_events_url":"https://api.github.com/users/orocos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/orocos/rtt_soem","description":"RTT SOEM EtherCAT components and drivers","fork":false,"url":"https://api.github.com/repos/orocos/rtt_soem","forks_url":"https://api.github.com/repos/orocos/rtt_soem/forks","keys_url":"https://api.github.com/repos/orocos/rtt_soem/keys{/key_id}","collaborators_url":"https://api.github.com/repos/orocos/rtt_soem/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/orocos/rtt_soem/teams","hooks_url":"https://api.github.com/repos/orocos/rtt_soem/hooks","issue_events_url":"https://api.github.com/repos/orocos/rtt_soem/issues/events{/number}","events_url":"https://api.github.com/repos/orocos/rtt_soem/events","assignees_url":"https://api.github.com/repos/orocos/rtt_soem/assignees{/user}","branches_url":"https://api.github.com/repos/orocos/rtt_soem/branches{/branch}","tags_url":"https://api.github.com/repos/orocos/rtt_soem/tags","blobs_url":"https://api.github.com/repos/orocos/rtt_soem/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/orocos/rtt_soem/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/orocos/rtt_soem/git/refs{/sha}","trees_url":"https://api.github.com/repos/orocos/rtt_soem/git/trees{/sha}","statuses_url":"https://api.github.com/repos/orocos/rtt_soem/statuses/{sha}","languages_url":"https://api.github.com/repos/orocos/rtt_soem/languages","stargazers_url":"https://api.github.com/repos/orocos/rtt_soem/stargazers","contributors_url":"https://api.github.com/repos/orocos/rtt_soem/contributors","subscribers_url":"https://api.github.com/repos/orocos/rtt_soem/subscribers","subscription_url":"https://api.github.com/repos/orocos/rtt_soem/subscription","commits_url":"https://api.github.com/repos/orocos/rtt_soem/commits{/sha}","git_commits_url":"https://api.github.com/repos/orocos/rtt_soem/git/commits{/sha}","comments_url":"https://api.github.com/repos/orocos/rtt_soem/comments{/number}","issue_comment_url":"https://api.github.com/repos/orocos/rtt_soem/issues/comments{/number}","contents_url":"https://api.github.com/repos/orocos/rtt_soem/contents/{+path}","compare_url":"https://api.github.com/repos/orocos/rtt_soem/compare/{base}...{head}","merges_url":"https://api.github.com/repos/orocos/rtt_soem/merges","archive_url":"https://api.github.com/repos/orocos/rtt_soem/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/orocos/rtt_soem/downloads","issues_url":"https://api.github.com/repos/orocos/rtt_soem/issues{/number}","pulls_url":"https://api.github.com/repos/orocos/rtt_soem/pulls{/number}","milestones_url":"https://api.github.com/repos/orocos/rtt_soem/milestones{/number}","notifications_url":"https://api.github.com/repos/orocos/rtt_soem/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/orocos/rtt_soem/labels{/name}","releases_url":"https://api.github.com/repos/orocos/rtt_soem/releases{/id}","deployments_url":"https://api.github.com/repos/orocos/rtt_soem/deployments","created_at":"2014-02-21T11:20:01Z","updated_at":"2016-07-15T00:59:02Z","pushed_at":"2016-10-14T13:53:34Z","git_url":"git://github.com/orocos/rtt_soem.git","ssh_url":"git@github.com:orocos/rtt_soem.git","clone_url":"https://github.com/orocos/rtt_soem.git","svn_url":"https://github.com/orocos/rtt_soem","homepage":null,"size":450,"stargazers_count":7,"watchers_count":7,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":5,"forks":11,"open_issues":5,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/orocos/rtt_soem/pulls/10"},"html":{"href":"https://github.com/orocos/rtt_soem/pull/10"},"issue":{"href":"https://api.github.com/repos/orocos/rtt_soem/issues/10"},"comments":{"href":"https://api.github.com/repos/orocos/rtt_soem/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/orocos/rtt_soem/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/orocos/rtt_soem/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/orocos/rtt_soem/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/orocos/rtt_soem/statuses/59de91a9e85d5e06a7fd462432901bd5bea60a58"}}}}
{"actor":{"display_login":"MagnaboscoL"}}