{"action":"created","comment":{"url":"https://api.github.com/repos/OpenFeign/feign/pulls/comments/81452159","pull_request_review_id":2433368,"id":81452159,"diff_hunk":"@@ -200,21 +200,29 @@ private static void putKV(String stringToParse, Map<String, Collection<String>>\n     map.put(key, values);\n   }\n \n+  /** {@link #resolve(Map, Map)}, which assumes no parameter is encoded */\n+  public RequestTemplate resolve(Map<String, ?> unencoded) {\n+    return resolve(unencoded, Collections.<String, Boolean>emptyMap());\n+  }\n+\n   /**\n    * Resolves any template parameters in the requests path, query, or headers against the supplied\n    * unencoded arguments. <br> <br><br><b>relationship to JAXRS 2.0</b><br> <br> This call is\n    * similar to {@code javax.ws.rs.client.WebTarget.resolveTemplates(templateValues, true)} , except\n    * that the template values apply to any part of the request, not just the URL\n    */\n-  public RequestTemplate resolve(Map<String, ?> unencoded) {\n-    replaceQueryValues(unencoded);\n+  public RequestTemplate resolve(Map<String, ?> unencoded, Map<String, Boolean> alreadyEncoded) {","path":"core/src/main/java/feign/RequestTemplate.java","position":26,"original_position":26,"commit_id":"752f0e67619fcf2a088d6733981620f226536450","original_commit_id":"752f0e67619fcf2a088d6733981620f226536450","user":{"login":"adriancole","id":64215,"avatar_url":"https://avatars.githubusercontent.com/u/64215?v=3","gravatar_id":"","url":"https://api.github.com/users/adriancole","html_url":"https://github.com/adriancole","followers_url":"https://api.github.com/users/adriancole/followers","following_url":"https://api.github.com/users/adriancole/following{/other_user}","gists_url":"https://api.github.com/users/adriancole/gists{/gist_id}","starred_url":"https://api.github.com/users/adriancole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adriancole/subscriptions","organizations_url":"https://api.github.com/users/adriancole/orgs","repos_url":"https://api.github.com/users/adriancole/repos","events_url":"https://api.github.com/users/adriancole/events{/privacy}","received_events_url":"https://api.github.com/users/adriancole/received_events","type":"User","site_admin":false},"body":"for this and below, package private is fine (as opposed to private). these are new methods, so we can hide them until someone asks. package private is better as it can be tested directly (plus the bytecode is smaller)","created_at":"2016-10-01T15:39:39Z","updated_at":"2016-10-01T15:40:56Z","html_url":"https://github.com/OpenFeign/feign/pull/465#discussion_r81452159","pull_request_url":"https://api.github.com/repos/OpenFeign/feign/pulls/465","_links":{"self":{"href":"https://api.github.com/repos/OpenFeign/feign/pulls/comments/81452159"},"html":{"href":"https://github.com/OpenFeign/feign/pull/465#discussion_r81452159"},"pull_request":{"href":"https://api.github.com/repos/OpenFeign/feign/pulls/465"}}},"pull_request":{"url":"https://api.github.com/repos/OpenFeign/feign/pulls/465","id":86748170,"html_url":"https://github.com/OpenFeign/feign/pull/465","diff_url":"https://github.com/OpenFeign/feign/pull/465.diff","patch_url":"https://github.com/OpenFeign/feign/pull/465.patch","issue_url":"https://api.github.com/repos/OpenFeign/feign/issues/465","number":465,"state":"open","locked":false,"title":"Implements possibility to disable @Param url encoding","user":{"login":"parkee","id":1686347,"avatar_url":"https://avatars.githubusercontent.com/u/1686347?v=3","gravatar_id":"","url":"https://api.github.com/users/parkee","html_url":"https://github.com/parkee","followers_url":"https://api.github.com/users/parkee/followers","following_url":"https://api.github.com/users/parkee/following{/other_user}","gists_url":"https://api.github.com/users/parkee/gists{/gist_id}","starred_url":"https://api.github.com/users/parkee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parkee/subscriptions","organizations_url":"https://api.github.com/users/parkee/orgs","repos_url":"https://api.github.com/users/parkee/repos","events_url":"https://api.github.com/users/parkee/events{/privacy}","received_events_url":"https://api.github.com/users/parkee/received_events","type":"User","site_admin":false},"body":"Now it is possible with @Param(encoded = true) to disable hardcoded call of urlEncode method on every @Param\r\nThis helps to implement matrix params or send unencoded path variables or query parameters which is required by some APIs","created_at":"2016-09-26T14:02:08Z","updated_at":"2016-10-01T15:40:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"be76106abcb9c58aaae05826b834d6a035787bf7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/OpenFeign/feign/pulls/465/commits","review_comments_url":"https://api.github.com/repos/OpenFeign/feign/pulls/465/comments","review_comment_url":"https://api.github.com/repos/OpenFeign/feign/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenFeign/feign/issues/465/comments","statuses_url":"https://api.github.com/repos/OpenFeign/feign/statuses/752f0e67619fcf2a088d6733981620f226536450","head":{"label":"parkee:master","ref":"master","sha":"752f0e67619fcf2a088d6733981620f226536450","user":{"login":"parkee","id":1686347,"avatar_url":"https://avatars.githubusercontent.com/u/1686347?v=3","gravatar_id":"","url":"https://api.github.com/users/parkee","html_url":"https://github.com/parkee","followers_url":"https://api.github.com/users/parkee/followers","following_url":"https://api.github.com/users/parkee/following{/other_user}","gists_url":"https://api.github.com/users/parkee/gists{/gist_id}","starred_url":"https://api.github.com/users/parkee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parkee/subscriptions","organizations_url":"https://api.github.com/users/parkee/orgs","repos_url":"https://api.github.com/users/parkee/repos","events_url":"https://api.github.com/users/parkee/events{/privacy}","received_events_url":"https://api.github.com/users/parkee/received_events","type":"User","site_admin":false},"repo":{"id":69227207,"name":"feign","full_name":"parkee/feign","owner":{"login":"parkee","id":1686347,"avatar_url":"https://avatars.githubusercontent.com/u/1686347?v=3","gravatar_id":"","url":"https://api.github.com/users/parkee","html_url":"https://github.com/parkee","followers_url":"https://api.github.com/users/parkee/followers","following_url":"https://api.github.com/users/parkee/following{/other_user}","gists_url":"https://api.github.com/users/parkee/gists{/gist_id}","starred_url":"https://api.github.com/users/parkee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parkee/subscriptions","organizations_url":"https://api.github.com/users/parkee/orgs","repos_url":"https://api.github.com/users/parkee/repos","events_url":"https://api.github.com/users/parkee/events{/privacy}","received_events_url":"https://api.github.com/users/parkee/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/parkee/feign","description":"Feign makes writing java http clients easier","fork":true,"url":"https://api.github.com/repos/parkee/feign","forks_url":"https://api.github.com/repos/parkee/feign/forks","keys_url":"https://api.github.com/repos/parkee/feign/keys{/key_id}","collaborators_url":"https://api.github.com/repos/parkee/feign/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/parkee/feign/teams","hooks_url":"https://api.github.com/repos/parkee/feign/hooks","issue_events_url":"https://api.github.com/repos/parkee/feign/issues/events{/number}","events_url":"https://api.github.com/repos/parkee/feign/events","assignees_url":"https://api.github.com/repos/parkee/feign/assignees{/user}","branches_url":"https://api.github.com/repos/parkee/feign/branches{/branch}","tags_url":"https://api.github.com/repos/parkee/feign/tags","blobs_url":"https://api.github.com/repos/parkee/feign/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/parkee/feign/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/parkee/feign/git/refs{/sha}","trees_url":"https://api.github.com/repos/parkee/feign/git/trees{/sha}","statuses_url":"https://api.github.com/repos/parkee/feign/statuses/{sha}","languages_url":"https://api.github.com/repos/parkee/feign/languages","stargazers_url":"https://api.github.com/repos/parkee/feign/stargazers","contributors_url":"https://api.github.com/repos/parkee/feign/contributors","subscribers_url":"https://api.github.com/repos/parkee/feign/subscribers","subscription_url":"https://api.github.com/repos/parkee/feign/subscription","commits_url":"https://api.github.com/repos/parkee/feign/commits{/sha}","git_commits_url":"https://api.github.com/repos/parkee/feign/git/commits{/sha}","comments_url":"https://api.github.com/repos/parkee/feign/comments{/number}","issue_comment_url":"https://api.github.com/repos/parkee/feign/issues/comments{/number}","contents_url":"https://api.github.com/repos/parkee/feign/contents/{+path}","compare_url":"https://api.github.com/repos/parkee/feign/compare/{base}...{head}","merges_url":"https://api.github.com/repos/parkee/feign/merges","archive_url":"https://api.github.com/repos/parkee/feign/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/parkee/feign/downloads","issues_url":"https://api.github.com/repos/parkee/feign/issues{/number}","pulls_url":"https://api.github.com/repos/parkee/feign/pulls{/number}","milestones_url":"https://api.github.com/repos/parkee/feign/milestones{/number}","notifications_url":"https://api.github.com/repos/parkee/feign/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/parkee/feign/labels{/name}","releases_url":"https://api.github.com/repos/parkee/feign/releases{/id}","deployments_url":"https://api.github.com/repos/parkee/feign/deployments","created_at":"2016-09-26T08:04:23Z","updated_at":"2016-09-26T08:04:25Z","pushed_at":"2016-10-01T12:24:00Z","git_url":"git://github.com/parkee/feign.git","ssh_url":"git@github.com:parkee/feign.git","clone_url":"https://github.com/parkee/feign.git","svn_url":"https://github.com/parkee/feign","homepage":"","size":1740,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OpenFeign:master","ref":"master","sha":"8c101e1422723deece6a292861833a07ff0effac","user":{"login":"OpenFeign","id":20077752,"avatar_url":"https://avatars.githubusercontent.com/u/20077752?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenFeign","html_url":"https://github.com/OpenFeign","followers_url":"https://api.github.com/users/OpenFeign/followers","following_url":"https://api.github.com/users/OpenFeign/following{/other_user}","gists_url":"https://api.github.com/users/OpenFeign/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenFeign/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenFeign/subscriptions","organizations_url":"https://api.github.com/users/OpenFeign/orgs","repos_url":"https://api.github.com/users/OpenFeign/repos","events_url":"https://api.github.com/users/OpenFeign/events{/privacy}","received_events_url":"https://api.github.com/users/OpenFeign/received_events","type":"Organization","site_admin":false},"repo":{"id":10981994,"name":"feign","full_name":"OpenFeign/feign","owner":{"login":"OpenFeign","id":20077752,"avatar_url":"https://avatars.githubusercontent.com/u/20077752?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenFeign","html_url":"https://github.com/OpenFeign","followers_url":"https://api.github.com/users/OpenFeign/followers","following_url":"https://api.github.com/users/OpenFeign/following{/other_user}","gists_url":"https://api.github.com/users/OpenFeign/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenFeign/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenFeign/subscriptions","organizations_url":"https://api.github.com/users/OpenFeign/orgs","repos_url":"https://api.github.com/users/OpenFeign/repos","events_url":"https://api.github.com/users/OpenFeign/events{/privacy}","received_events_url":"https://api.github.com/users/OpenFeign/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenFeign/feign","description":"Feign makes writing java http clients easier","fork":false,"url":"https://api.github.com/repos/OpenFeign/feign","forks_url":"https://api.github.com/repos/OpenFeign/feign/forks","keys_url":"https://api.github.com/repos/OpenFeign/feign/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenFeign/feign/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenFeign/feign/teams","hooks_url":"https://api.github.com/repos/OpenFeign/feign/hooks","issue_events_url":"https://api.github.com/repos/OpenFeign/feign/issues/events{/number}","events_url":"https://api.github.com/repos/OpenFeign/feign/events","assignees_url":"https://api.github.com/repos/OpenFeign/feign/assignees{/user}","branches_url":"https://api.github.com/repos/OpenFeign/feign/branches{/branch}","tags_url":"https://api.github.com/repos/OpenFeign/feign/tags","blobs_url":"https://api.github.com/repos/OpenFeign/feign/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenFeign/feign/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenFeign/feign/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenFeign/feign/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenFeign/feign/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenFeign/feign/languages","stargazers_url":"https://api.github.com/repos/OpenFeign/feign/stargazers","contributors_url":"https://api.github.com/repos/OpenFeign/feign/contributors","subscribers_url":"https://api.github.com/repos/OpenFeign/feign/subscribers","subscription_url":"https://api.github.com/repos/OpenFeign/feign/subscription","commits_url":"https://api.github.com/repos/OpenFeign/feign/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenFeign/feign/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenFeign/feign/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenFeign/feign/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenFeign/feign/contents/{+path}","compare_url":"https://api.github.com/repos/OpenFeign/feign/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenFeign/feign/merges","archive_url":"https://api.github.com/repos/OpenFeign/feign/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenFeign/feign/downloads","issues_url":"https://api.github.com/repos/OpenFeign/feign/issues{/number}","pulls_url":"https://api.github.com/repos/OpenFeign/feign/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenFeign/feign/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenFeign/feign/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenFeign/feign/labels{/name}","releases_url":"https://api.github.com/repos/OpenFeign/feign/releases{/id}","deployments_url":"https://api.github.com/repos/OpenFeign/feign/deployments","created_at":"2013-06-26T23:28:16Z","updated_at":"2016-09-30T22:57:13Z","pushed_at":"2016-10-01T12:24:01Z","git_url":"git://github.com/OpenFeign/feign.git","ssh_url":"git@github.com:OpenFeign/feign.git","clone_url":"https://github.com/OpenFeign/feign.git","svn_url":"https://github.com/OpenFeign/feign","homepage":"","size":2433,"stargazers_count":1291,"watchers_count":1291,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":254,"mirror_url":null,"open_issues_count":55,"forks":254,"open_issues":55,"watchers":1291,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenFeign/feign/pulls/465"},"html":{"href":"https://github.com/OpenFeign/feign/pull/465"},"issue":{"href":"https://api.github.com/repos/OpenFeign/feign/issues/465"},"comments":{"href":"https://api.github.com/repos/OpenFeign/feign/issues/465/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenFeign/feign/pulls/465/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenFeign/feign/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenFeign/feign/pulls/465/commits"},"statuses":{"href":"https://api.github.com/repos/OpenFeign/feign/statuses/752f0e67619fcf2a088d6733981620f226536450"}}}}
{"actor":{"display_login":"adriancole"}}