{"action":"closed","number":1465,"pull_request":{"url":"https://api.github.com/repos/apache/cloudstack/pulls/1465","id":65669504,"html_url":"https://github.com/apache/cloudstack/pull/1465","diff_url":"https://github.com/apache/cloudstack/pull/1465.diff","patch_url":"https://github.com/apache/cloudstack/pull/1465.patch","issue_url":"https://api.github.com/repos/apache/cloudstack/issues/1465","number":1465,"state":"closed","locked":false,"title":"Fix concurrency issue on virtual router","user":{"login":"remibergsma","id":1630096,"avatar_url":"https://avatars.githubusercontent.com/u/1630096?v=3","gravatar_id":"","url":"https://api.github.com/users/remibergsma","html_url":"https://github.com/remibergsma","followers_url":"https://api.github.com/users/remibergsma/followers","following_url":"https://api.github.com/users/remibergsma/following{/other_user}","gists_url":"https://api.github.com/users/remibergsma/gists{/gist_id}","starred_url":"https://api.github.com/users/remibergsma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/remibergsma/subscriptions","organizations_url":"https://api.github.com/users/remibergsma/orgs","repos_url":"https://api.github.com/users/remibergsma/repos","events_url":"https://api.github.com/users/remibergsma/events{/privacy}","received_events_url":"https://api.github.com/users/remibergsma/received_events","type":"User","site_admin":false},"body":"The json files now have UUIDs to prevent them from getting overwritten before they've been executed. Prevents config to be pushed to the wrong router :-s\r\n\r\n```\r\n2016-02-25 18:32:23,797 DEBUG [c.c.a.t.Request] (AgentManager-Handler-1:null) (logid:) Seq 2-4684025087442026584: Processing:  { Ans: , MgmtId: 90520732674657, via: 2, Ver: v1, Flags: 10, [{\"com.cloud.agent.api.routing.GroupA\r\nnswer\":{\"results\":[\"null - success: null\",\"null - success: [INFO] update_config.py :: Processing incoming file => vm_dhcp_entry.json.4ea45061-2efb-4467-8eaa-db3d77fb0a7b\\n[INFO] Processing JSON file vm_dhcp_entry.json.4ea4506\r\n1-2efb-4467-8eaa-db3d77fb0a7b\\n\"],\"result\":true,\"wait\":0}}] }\r\n```\r\n\r\nOn the router:\r\n```\r\n2016-02-25 18:32:23,416  merge.py __moveFile:298 Processed file written to /var/cache/cloud/processed/vm_dhcp_entry.json.4ea45061-2efb-4467-8eaa-db3d77fb0a7b.gz\r\n```\r\n\r\n![screen shot 2016-02-25 at 19 33 17](https://cloud.githubusercontent.com/assets/1630096/13329886/acdae4fc-dbf6-11e5-8c20-fdc6661f5a0b.png)","created_at":"2016-04-07T17:37:09Z","updated_at":"2016-04-07T19:04:37Z","closed_at":"2016-04-07T19:04:37Z","merged_at":null,"merge_commit_sha":"56485b2203068a01af51e9fba95a6fa17bbcf9ff","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/cloudstack/pulls/1465/commits","review_comments_url":"https://api.github.com/repos/apache/cloudstack/pulls/1465/comments","review_comment_url":"https://api.github.com/repos/apache/cloudstack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/cloudstack/issues/1465/comments","statuses_url":"https://api.github.com/repos/apache/cloudstack/statuses/f632215b0493b210201fa7590db00ce64cf25e4a","head":{"label":"remibergsma:47_fix_concurrency_issue","ref":"47_fix_concurrency_issue","sha":"f632215b0493b210201fa7590db00ce64cf25e4a","user":{"login":"remibergsma","id":1630096,"avatar_url":"https://avatars.githubusercontent.com/u/1630096?v=3","gravatar_id":"","url":"https://api.github.com/users/remibergsma","html_url":"https://github.com/remibergsma","followers_url":"https://api.github.com/users/remibergsma/followers","following_url":"https://api.github.com/users/remibergsma/following{/other_user}","gists_url":"https://api.github.com/users/remibergsma/gists{/gist_id}","starred_url":"https://api.github.com/users/remibergsma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/remibergsma/subscriptions","organizations_url":"https://api.github.com/users/remibergsma/orgs","repos_url":"https://api.github.com/users/remibergsma/repos","events_url":"https://api.github.com/users/remibergsma/events{/privacy}","received_events_url":"https://api.github.com/users/remibergsma/received_events","type":"User","site_admin":false},"repo":{"id":33662311,"name":"cloudstack","full_name":"remibergsma/cloudstack","owner":{"login":"remibergsma","id":1630096,"avatar_url":"https://avatars.githubusercontent.com/u/1630096?v=3","gravatar_id":"","url":"https://api.github.com/users/remibergsma","html_url":"https://github.com/remibergsma","followers_url":"https://api.github.com/users/remibergsma/followers","following_url":"https://api.github.com/users/remibergsma/following{/other_user}","gists_url":"https://api.github.com/users/remibergsma/gists{/gist_id}","starred_url":"https://api.github.com/users/remibergsma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/remibergsma/subscriptions","organizations_url":"https://api.github.com/users/remibergsma/orgs","repos_url":"https://api.github.com/users/remibergsma/repos","events_url":"https://api.github.com/users/remibergsma/events{/privacy}","received_events_url":"https://api.github.com/users/remibergsma/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/remibergsma/cloudstack","description":"Mirror of Apache Cloudstack","fork":true,"url":"https://api.github.com/repos/remibergsma/cloudstack","forks_url":"https://api.github.com/repos/remibergsma/cloudstack/forks","keys_url":"https://api.github.com/repos/remibergsma/cloudstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/remibergsma/cloudstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/remibergsma/cloudstack/teams","hooks_url":"https://api.github.com/repos/remibergsma/cloudstack/hooks","issue_events_url":"https://api.github.com/repos/remibergsma/cloudstack/issues/events{/number}","events_url":"https://api.github.com/repos/remibergsma/cloudstack/events","assignees_url":"https://api.github.com/repos/remibergsma/cloudstack/assignees{/user}","branches_url":"https://api.github.com/repos/remibergsma/cloudstack/branches{/branch}","tags_url":"https://api.github.com/repos/remibergsma/cloudstack/tags","blobs_url":"https://api.github.com/repos/remibergsma/cloudstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/remibergsma/cloudstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/remibergsma/cloudstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/remibergsma/cloudstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/remibergsma/cloudstack/statuses/{sha}","languages_url":"https://api.github.com/repos/remibergsma/cloudstack/languages","stargazers_url":"https://api.github.com/repos/remibergsma/cloudstack/stargazers","contributors_url":"https://api.github.com/repos/remibergsma/cloudstack/contributors","subscribers_url":"https://api.github.com/repos/remibergsma/cloudstack/subscribers","subscription_url":"https://api.github.com/repos/remibergsma/cloudstack/subscription","commits_url":"https://api.github.com/repos/remibergsma/cloudstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/remibergsma/cloudstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/remibergsma/cloudstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/remibergsma/cloudstack/issues/comments{/number}","contents_url":"https://api.github.com/repos/remibergsma/cloudstack/contents/{+path}","compare_url":"https://api.github.com/repos/remibergsma/cloudstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/remibergsma/cloudstack/merges","archive_url":"https://api.github.com/repos/remibergsma/cloudstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/remibergsma/cloudstack/downloads","issues_url":"https://api.github.com/repos/remibergsma/cloudstack/issues{/number}","pulls_url":"https://api.github.com/repos/remibergsma/cloudstack/pulls{/number}","milestones_url":"https://api.github.com/repos/remibergsma/cloudstack/milestones{/number}","notifications_url":"https://api.github.com/repos/remibergsma/cloudstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/remibergsma/cloudstack/labels{/name}","releases_url":"https://api.github.com/repos/remibergsma/cloudstack/releases{/id}","deployments_url":"https://api.github.com/repos/remibergsma/cloudstack/deployments","created_at":"2015-04-09T10:12:10Z","updated_at":"2016-01-17T20:37:54Z","pushed_at":"2016-04-07T19:02:31Z","git_url":"git://github.com/remibergsma/cloudstack.git","ssh_url":"git@github.com:remibergsma/cloudstack.git","clone_url":"https://github.com/remibergsma/cloudstack.git","svn_url":"https://github.com/remibergsma/cloudstack","homepage":null,"size":508059,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"f960725dd59e5a332fd652d1613c8de8a48cfb28","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":9759448,"name":"cloudstack","full_name":"apache/cloudstack","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/cloudstack","description":"Mirror of Apache Cloudstack","fork":false,"url":"https://api.github.com/repos/apache/cloudstack","forks_url":"https://api.github.com/repos/apache/cloudstack/forks","keys_url":"https://api.github.com/repos/apache/cloudstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/cloudstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/cloudstack/teams","hooks_url":"https://api.github.com/repos/apache/cloudstack/hooks","issue_events_url":"https://api.github.com/repos/apache/cloudstack/issues/events{/number}","events_url":"https://api.github.com/repos/apache/cloudstack/events","assignees_url":"https://api.github.com/repos/apache/cloudstack/assignees{/user}","branches_url":"https://api.github.com/repos/apache/cloudstack/branches{/branch}","tags_url":"https://api.github.com/repos/apache/cloudstack/tags","blobs_url":"https://api.github.com/repos/apache/cloudstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/cloudstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/cloudstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/cloudstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/cloudstack/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/cloudstack/languages","stargazers_url":"https://api.github.com/repos/apache/cloudstack/stargazers","contributors_url":"https://api.github.com/repos/apache/cloudstack/contributors","subscribers_url":"https://api.github.com/repos/apache/cloudstack/subscribers","subscription_url":"https://api.github.com/repos/apache/cloudstack/subscription","commits_url":"https://api.github.com/repos/apache/cloudstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/cloudstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/cloudstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/cloudstack/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/cloudstack/contents/{+path}","compare_url":"https://api.github.com/repos/apache/cloudstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/cloudstack/merges","archive_url":"https://api.github.com/repos/apache/cloudstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/cloudstack/downloads","issues_url":"https://api.github.com/repos/apache/cloudstack/issues{/number}","pulls_url":"https://api.github.com/repos/apache/cloudstack/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/cloudstack/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/cloudstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/cloudstack/labels{/name}","releases_url":"https://api.github.com/repos/apache/cloudstack/releases{/id}","deployments_url":"https://api.github.com/repos/apache/cloudstack/deployments","created_at":"2013-04-29T22:27:12Z","updated_at":"2016-04-07T11:57:34Z","pushed_at":"2016-04-07T19:03:11Z","git_url":"git://github.com/apache/cloudstack.git","ssh_url":"git@github.com:apache/cloudstack.git","clone_url":"https://github.com/apache/cloudstack.git","svn_url":"https://github.com/apache/cloudstack","homepage":null,"size":518151,"stargazers_count":353,"watchers_count":353,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":472,"mirror_url":"git://git.apache.org/cloudstack.git","open_issues_count":195,"forks":472,"open_issues":195,"watchers":353,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/cloudstack/pulls/1465"},"html":{"href":"https://github.com/apache/cloudstack/pull/1465"},"issue":{"href":"https://api.github.com/repos/apache/cloudstack/issues/1465"},"comments":{"href":"https://api.github.com/repos/apache/cloudstack/issues/1465/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/cloudstack/pulls/1465/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/cloudstack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/cloudstack/pulls/1465/commits"},"statuses":{"href":"https://api.github.com/repos/apache/cloudstack/statuses/f632215b0493b210201fa7590db00ce64cf25e4a"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":2,"review_comments":1,"commits":1,"additions":26,"deletions":3,"changed_files":4}}