{"action":"created","issue":{"url":"https://api.github.com/repos/aframevr/aframe/issues/2154","repository_url":"https://api.github.com/repos/aframevr/aframe","labels_url":"https://api.github.com/repos/aframevr/aframe/issues/2154/labels{/name}","comments_url":"https://api.github.com/repos/aframevr/aframe/issues/2154/comments","events_url":"https://api.github.com/repos/aframevr/aframe/issues/2154/events","html_url":"https://github.com/aframevr/aframe/pull/2154","id":193014405,"number":2154,"title":"Remove modifier key conditions from util.shouldCaptureKeyEvent(e)","user":{"login":"donmccurdy","id":1848368,"avatar_url":"https://avatars.githubusercontent.com/u/1848368?v=3","gravatar_id":"","url":"https://api.github.com/users/donmccurdy","html_url":"https://github.com/donmccurdy","followers_url":"https://api.github.com/users/donmccurdy/followers","following_url":"https://api.github.com/users/donmccurdy/following{/other_user}","gists_url":"https://api.github.com/users/donmccurdy/gists{/gist_id}","starred_url":"https://api.github.com/users/donmccurdy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/donmccurdy/subscriptions","organizations_url":"https://api.github.com/users/donmccurdy/orgs","repos_url":"https://api.github.com/users/donmccurdy/repos","events_url":"https://api.github.com/users/donmccurdy/events{/privacy}","received_events_url":"https://api.github.com/users/donmccurdy/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-12-02T02:01:54Z","updated_at":"2016-12-06T23:06:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/aframevr/aframe/pulls/2154","html_url":"https://github.com/aframevr/aframe/pull/2154","diff_url":"https://github.com/aframevr/aframe/pull/2154.diff","patch_url":"https://github.com/aframevr/aframe/pull/2154.patch"},"body":"Fixes #1479.\r\n\r\nThe condition for modifier keys was introduced by 8697452f, with the goal of fixing the issue that it now seems to be causing.\r\n\r\nI'm testing in three browsers:\r\n\r\n* Chrome (KeyboardEvent.**code**)\r\n* Firefox (KeyboardEvent.**code**)\r\n* Safari (KeyboardEvent.**keyCode**)\r\n\r\nCurrently, all three exhibit #1479 for all modifier keys. With this change, <kbd>shift</kbd>, <kbd>alt</kbd>, and <kbd>ctrl</kbd> are fixed, and do not interfere with WASD controls.. <kbd>meta</kbd> is unfortunately not fixed, but that's a browser implementation \"feature\" and pretty much unavoidable with userland code."},"comment":{"url":"https://api.github.com/repos/aframevr/aframe/issues/comments/265302396","html_url":"https://github.com/aframevr/aframe/pull/2154#issuecomment-265302396","issue_url":"https://api.github.com/repos/aframevr/aframe/issues/2154","id":265302396,"user":{"login":"donmccurdy","id":1848368,"avatar_url":"https://avatars.githubusercontent.com/u/1848368?v=3","gravatar_id":"","url":"https://api.github.com/users/donmccurdy","html_url":"https://github.com/donmccurdy","followers_url":"https://api.github.com/users/donmccurdy/followers","following_url":"https://api.github.com/users/donmccurdy/following{/other_user}","gists_url":"https://api.github.com/users/donmccurdy/gists{/gist_id}","starred_url":"https://api.github.com/users/donmccurdy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/donmccurdy/subscriptions","organizations_url":"https://api.github.com/users/donmccurdy/orgs","repos_url":"https://api.github.com/users/donmccurdy/repos","events_url":"https://api.github.com/users/donmccurdy/events{/privacy}","received_events_url":"https://api.github.com/users/donmccurdy/received_events","type":"User","site_admin":false},"created_at":"2016-12-06T23:06:48Z","updated_at":"2016-12-06T23:06:48Z","body":"Removed the `shouldCaptureKey` conditional in `onKeyUp`.\r\n\r\nI agree with the `document.activeElement` check in `shouldCaptureKey`, since that keeps #1063 closed. The <kbd>meta</kbd> check is borderline, IMHO."}}
{"actor":{"display_login":"donmccurdy"}}