{"action":"created","comment":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/82539740","pull_request_review_id":3440713,"id":82539740,"diff_hunk":"@@ -353,10 +353,7 @@ def fit_predict(self, X, y=None, **fit_params):\n         -------\n         y_pred : array-like\n         \"\"\"\n-        Xt = X\n-        for name, transform in self.steps[:-1]:\n-            if transform is not None:\n-                Xt = transform.fit_transform(Xt)\n+        Xt, fit_params = self._pre_transform(X, y, **fit_params)","path":"sklearn/pipeline.py","position":null,"original_position":8,"commit_id":"50d47f05bb982e78dce54d45c00d08c30a19d0d8","original_commit_id":"540f96e375e7b9d875608b95f25b2652b893f84e","user":{"login":"sshleifer","id":6045025,"avatar_url":"https://avatars.githubusercontent.com/u/6045025?v=3","gravatar_id":"","url":"https://api.github.com/users/sshleifer","html_url":"https://github.com/sshleifer","followers_url":"https://api.github.com/users/sshleifer/followers","following_url":"https://api.github.com/users/sshleifer/following{/other_user}","gists_url":"https://api.github.com/users/sshleifer/gists{/gist_id}","starred_url":"https://api.github.com/users/sshleifer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sshleifer/subscriptions","organizations_url":"https://api.github.com/users/sshleifer/orgs","repos_url":"https://api.github.com/users/sshleifer/repos","events_url":"https://api.github.com/users/sshleifer/events{/privacy}","received_events_url":"https://api.github.com/users/sshleifer/received_events","type":"User","site_admin":false},"body":"fixed https://github.com/scikit-learn/scikit-learn/pull/7621/commits/50d47f05bb982e78dce54d45c00d08c30a19d0d8","created_at":"2016-10-10T02:49:49Z","updated_at":"2016-10-10T02:49:49Z","html_url":"https://github.com/scikit-learn/scikit-learn/pull/7621#discussion_r82539740","pull_request_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/7621","_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/82539740"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/7621#discussion_r82539740"},"pull_request":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/7621"}}},"pull_request":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/7621","id":88602192,"html_url":"https://github.com/scikit-learn/scikit-learn/pull/7621","diff_url":"https://github.com/scikit-learn/scikit-learn/pull/7621.diff","patch_url":"https://github.com/scikit-learn/scikit-learn/pull/7621.patch","issue_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/7621","number":7621,"state":"open","locked":false,"title":"[MRG] Pipeline uses use fit_predict from 17.x","user":{"login":"sshleifer","id":6045025,"avatar_url":"https://avatars.githubusercontent.com/u/6045025?v=3","gravatar_id":"","url":"https://api.github.com/users/sshleifer","html_url":"https://github.com/sshleifer","followers_url":"https://api.github.com/users/sshleifer/followers","following_url":"https://api.github.com/users/sshleifer/following{/other_user}","gists_url":"https://api.github.com/users/sshleifer/gists{/gist_id}","starred_url":"https://api.github.com/users/sshleifer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sshleifer/subscriptions","organizations_url":"https://api.github.com/users/sshleifer/orgs","repos_url":"https://api.github.com/users/sshleifer/repos","events_url":"https://api.github.com/users/sshleifer/events{/privacy}","received_events_url":"https://api.github.com/users/sshleifer/received_events","type":"User","site_admin":false},"body":"#### What does this implement/fix? Explain your changes.\r\nPreviously, `**fit_params` were not passed to the `fit_transform` steps of the `fit_predict` method\r\n\r\n\r\n","created_at":"2016-10-10T01:18:05Z","updated_at":"2016-10-10T02:49:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f7d1d4b094861b3dfaa43e4a248b383db3c462f1","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/7621/commits","review_comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/7621/comments","review_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/7621/comments","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/50d47f05bb982e78dce54d45c00d08c30a19d0d8","head":{"label":"sshleifer:fit-transform-kwargs","ref":"fit-transform-kwargs","sha":"50d47f05bb982e78dce54d45c00d08c30a19d0d8","user":{"login":"sshleifer","id":6045025,"avatar_url":"https://avatars.githubusercontent.com/u/6045025?v=3","gravatar_id":"","url":"https://api.github.com/users/sshleifer","html_url":"https://github.com/sshleifer","followers_url":"https://api.github.com/users/sshleifer/followers","following_url":"https://api.github.com/users/sshleifer/following{/other_user}","gists_url":"https://api.github.com/users/sshleifer/gists{/gist_id}","starred_url":"https://api.github.com/users/sshleifer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sshleifer/subscriptions","organizations_url":"https://api.github.com/users/sshleifer/orgs","repos_url":"https://api.github.com/users/sshleifer/repos","events_url":"https://api.github.com/users/sshleifer/events{/privacy}","received_events_url":"https://api.github.com/users/sshleifer/received_events","type":"User","site_admin":false},"repo":{"id":64036558,"name":"scikit-learn","full_name":"sshleifer/scikit-learn","owner":{"login":"sshleifer","id":6045025,"avatar_url":"https://avatars.githubusercontent.com/u/6045025?v=3","gravatar_id":"","url":"https://api.github.com/users/sshleifer","html_url":"https://github.com/sshleifer","followers_url":"https://api.github.com/users/sshleifer/followers","following_url":"https://api.github.com/users/sshleifer/following{/other_user}","gists_url":"https://api.github.com/users/sshleifer/gists{/gist_id}","starred_url":"https://api.github.com/users/sshleifer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sshleifer/subscriptions","organizations_url":"https://api.github.com/users/sshleifer/orgs","repos_url":"https://api.github.com/users/sshleifer/repos","events_url":"https://api.github.com/users/sshleifer/events{/privacy}","received_events_url":"https://api.github.com/users/sshleifer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sshleifer/scikit-learn","description":"scikit-learn: machine learning in Python","fork":true,"url":"https://api.github.com/repos/sshleifer/scikit-learn","forks_url":"https://api.github.com/repos/sshleifer/scikit-learn/forks","keys_url":"https://api.github.com/repos/sshleifer/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sshleifer/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sshleifer/scikit-learn/teams","hooks_url":"https://api.github.com/repos/sshleifer/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/sshleifer/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/sshleifer/scikit-learn/events","assignees_url":"https://api.github.com/repos/sshleifer/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/sshleifer/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/sshleifer/scikit-learn/tags","blobs_url":"https://api.github.com/repos/sshleifer/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sshleifer/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sshleifer/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/sshleifer/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sshleifer/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/sshleifer/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/sshleifer/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/sshleifer/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/sshleifer/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/sshleifer/scikit-learn/subscription","commits_url":"https://api.github.com/repos/sshleifer/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/sshleifer/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/sshleifer/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/sshleifer/scikit-learn/issues/comments{/number}","contents_url":"https://api.github.com/repos/sshleifer/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/sshleifer/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sshleifer/scikit-learn/merges","archive_url":"https://api.github.com/repos/sshleifer/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sshleifer/scikit-learn/downloads","issues_url":"https://api.github.com/repos/sshleifer/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/sshleifer/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/sshleifer/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/sshleifer/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sshleifer/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/sshleifer/scikit-learn/releases{/id}","deployments_url":"https://api.github.com/repos/sshleifer/scikit-learn/deployments","created_at":"2016-07-23T21:20:28Z","updated_at":"2016-07-23T21:20:36Z","pushed_at":"2016-10-10T01:25:36Z","git_url":"git://github.com/sshleifer/scikit-learn.git","ssh_url":"git@github.com:sshleifer/scikit-learn.git","clone_url":"https://github.com/sshleifer/scikit-learn.git","svn_url":"https://github.com/sshleifer/scikit-learn","homepage":"http://scikit-learn.org","size":75559,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"scikit-learn:master","ref":"master","sha":"33ed90dc0aa0549a5963000d7d070aa18ca389c4","user":{"login":"scikit-learn","id":365630,"avatar_url":"https://avatars.githubusercontent.com/u/365630?v=3","gravatar_id":"","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"repo":{"id":843222,"name":"scikit-learn","full_name":"scikit-learn/scikit-learn","owner":{"login":"scikit-learn","id":365630,"avatar_url":"https://avatars.githubusercontent.com/u/365630?v=3","gravatar_id":"","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scikit-learn/scikit-learn","description":"scikit-learn: machine learning in Python","fork":false,"url":"https://api.github.com/repos/scikit-learn/scikit-learn","forks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/forks","keys_url":"https://api.github.com/repos/scikit-learn/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scikit-learn/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scikit-learn/scikit-learn/teams","hooks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/events","assignees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/scikit-learn/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/tags","blobs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/scikit-learn/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscription","commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/comments{/number}","contents_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/scikit-learn/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scikit-learn/scikit-learn/merges","archive_url":"https://api.github.com/repos/scikit-learn/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scikit-learn/scikit-learn/downloads","issues_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/scikit-learn/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/scikit-learn/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scikit-learn/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/scikit-learn/scikit-learn/releases{/id}","deployments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/deployments","created_at":"2010-08-17T09:43:38Z","updated_at":"2016-10-10T02:01:43Z","pushed_at":"2016-10-10T02:42:34Z","git_url":"git://github.com/scikit-learn/scikit-learn.git","ssh_url":"git@github.com:scikit-learn/scikit-learn.git","clone_url":"https://github.com/scikit-learn/scikit-learn.git","svn_url":"https://github.com/scikit-learn/scikit-learn","homepage":"http://scikit-learn.org","size":125625,"stargazers_count":13877,"watchers_count":13877,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7955,"mirror_url":null,"open_issues_count":1190,"forks":7955,"open_issues":1190,"watchers":13877,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/7621"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/7621"},"issue":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/7621"},"comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/7621/comments"},"review_comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/7621/comments"},"review_comment":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/7621/commits"},"statuses":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/50d47f05bb982e78dce54d45c00d08c30a19d0d8"}}}}
{"actor":{"display_login":"sshleifer"}}