{"action":"created","comment":{"url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments/54118349","id":54118349,"diff_hunk":"@@ -18,10 +18,6 @@ SRCDIR= src\n BUILDDIR= src\n endif\n \n-ifneq ($(PORTNAME), win32)","path":"gpAux/extensions/gpmapreduce/Makefile","position":4,"original_position":4,"commit_id":"86575a709b853edc70b1c2aa360781c5750d5bf9","original_commit_id":"86575a709b853edc70b1c2aa360781c5750d5bf9","user":{"login":"xinzweb","id":723898,"avatar_url":"https://avatars.githubusercontent.com/u/723898?v=3","gravatar_id":"","url":"https://api.github.com/users/xinzweb","html_url":"https://github.com/xinzweb","followers_url":"https://api.github.com/users/xinzweb/followers","following_url":"https://api.github.com/users/xinzweb/following{/other_user}","gists_url":"https://api.github.com/users/xinzweb/gists{/gist_id}","starred_url":"https://api.github.com/users/xinzweb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xinzweb/subscriptions","organizations_url":"https://api.github.com/users/xinzweb/orgs","repos_url":"https://api.github.com/users/xinzweb/repos","events_url":"https://api.github.com/users/xinzweb/events{/privacy}","received_events_url":"https://api.github.com/users/xinzweb/received_events","type":"User","site_admin":false},"body":"Is this required for adding mapreduce? Please make sure the win32 build ok with this fix. Thanks.","created_at":"2016-02-25T16:07:24Z","updated_at":"2016-02-25T16:07:24Z","html_url":"https://github.com/greenplum-db/gpdb/pull/434#discussion_r54118349","pull_request_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/434","_links":{"self":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments/54118349"},"html":{"href":"https://github.com/greenplum-db/gpdb/pull/434#discussion_r54118349"},"pull_request":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/434"}}},"pull_request":{"url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/434","id":60663709,"html_url":"https://github.com/greenplum-db/gpdb/pull/434","diff_url":"https://github.com/greenplum-db/gpdb/pull/434.diff","patch_url":"https://github.com/greenplum-db/gpdb/pull/434.patch","issue_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/434","number":434,"state":"open","locked":false,"title":"Connect mapreduce to the build and make test pass","user":{"login":"danielgustafsson","id":321790,"avatar_url":"https://avatars.githubusercontent.com/u/321790?v=3","gravatar_id":"","url":"https://api.github.com/users/danielgustafsson","html_url":"https://github.com/danielgustafsson","followers_url":"https://api.github.com/users/danielgustafsson/followers","following_url":"https://api.github.com/users/danielgustafsson/following{/other_user}","gists_url":"https://api.github.com/users/danielgustafsson/gists{/gist_id}","starred_url":"https://api.github.com/users/danielgustafsson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielgustafsson/subscriptions","organizations_url":"https://api.github.com/users/danielgustafsson/orgs","repos_url":"https://api.github.com/users/danielgustafsson/repos","events_url":"https://api.github.com/users/danielgustafsson/events{/privacy}","received_events_url":"https://api.github.com/users/danielgustafsson/received_events","type":"User","site_admin":false},"body":"Growing increasingly annoyed at seeing `mapred ... FAILED` when hacking on the merges (and there have been questions why this fails on the mailinglist) I decided to see what it would take to get it working for the normal buildsequence of configure, make install, make installcheck-good. Turns out it was quite easy.\r\n\r\nThe gist of this patch is that it connects mapreduce to the build if so is desired and fixes the tests. To do this a new switch is added to autoconf, `--enable-mapreduce`, which connects the GPMapreduce extension to the build. If set to on the mapreduce extension in `gpAux/extensions` will be built and installed by the normal `make install`. Autoconf checks for libyaml has been added since it's a depedency for GPMapreduce. As a side effect, this will properly clean and distclean for gpfdist in `gpAux/extensions` as well. \r\n\r\nThe Python and Perl version tests are moved in under ignore blocks to make the test less fragile. Testing for specific versions is not ideal IMO, if this is to be kept as a real test it should be rewritten to look for interpreters satisfying minimum version requirements rather then exact (although the value of that can be argued as well). Keeping the version output in the test seems valuable though since it can be good information when debugging where access is limited to the `regression.diffs` file. Also fixes a trivial typo in a comment.\r\n\r\nGPMapreduce isn't really touched at all, the fixes there are limited to a broken header guard and removing the `-pthreads` compiler flag since it's not threaded (and unused flags cause warnings in clang).\r\n\r\nWith these patches applied, mapred tests pass with the following (+ the required `source` commands of course):\r\n```\r\n./configure --with-perl --with-python --enable-mapreduce\r\nmake install\r\nmake -C gpAux/gpdemo cluster\r\nmake installcheck-good\r\n```","created_at":"2016-02-25T11:26:17Z","updated_at":"2016-02-25T16:07:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5a3a37a9a9374fdf5641091c60b430e1aa3caaaf","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/434/commits","review_comments_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/434/comments","review_comment_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/434/comments","statuses_url":"https://api.github.com/repos/greenplum-db/gpdb/statuses/86575a709b853edc70b1c2aa360781c5750d5bf9","head":{"label":"danielgustafsson:enable_gpmapreduce","ref":"enable_gpmapreduce","sha":"86575a709b853edc70b1c2aa360781c5750d5bf9","user":{"login":"danielgustafsson","id":321790,"avatar_url":"https://avatars.githubusercontent.com/u/321790?v=3","gravatar_id":"","url":"https://api.github.com/users/danielgustafsson","html_url":"https://github.com/danielgustafsson","followers_url":"https://api.github.com/users/danielgustafsson/followers","following_url":"https://api.github.com/users/danielgustafsson/following{/other_user}","gists_url":"https://api.github.com/users/danielgustafsson/gists{/gist_id}","starred_url":"https://api.github.com/users/danielgustafsson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielgustafsson/subscriptions","organizations_url":"https://api.github.com/users/danielgustafsson/orgs","repos_url":"https://api.github.com/users/danielgustafsson/repos","events_url":"https://api.github.com/users/danielgustafsson/events{/privacy}","received_events_url":"https://api.github.com/users/danielgustafsson/received_events","type":"User","site_admin":false},"repo":{"id":45419965,"name":"gpdb","full_name":"danielgustafsson/gpdb","owner":{"login":"danielgustafsson","id":321790,"avatar_url":"https://avatars.githubusercontent.com/u/321790?v=3","gravatar_id":"","url":"https://api.github.com/users/danielgustafsson","html_url":"https://github.com/danielgustafsson","followers_url":"https://api.github.com/users/danielgustafsson/followers","following_url":"https://api.github.com/users/danielgustafsson/following{/other_user}","gists_url":"https://api.github.com/users/danielgustafsson/gists{/gist_id}","starred_url":"https://api.github.com/users/danielgustafsson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielgustafsson/subscriptions","organizations_url":"https://api.github.com/users/danielgustafsson/orgs","repos_url":"https://api.github.com/users/danielgustafsson/repos","events_url":"https://api.github.com/users/danielgustafsson/events{/privacy}","received_events_url":"https://api.github.com/users/danielgustafsson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/danielgustafsson/gpdb","description":"Pivotal Greenplum Database","fork":true,"url":"https://api.github.com/repos/danielgustafsson/gpdb","forks_url":"https://api.github.com/repos/danielgustafsson/gpdb/forks","keys_url":"https://api.github.com/repos/danielgustafsson/gpdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danielgustafsson/gpdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danielgustafsson/gpdb/teams","hooks_url":"https://api.github.com/repos/danielgustafsson/gpdb/hooks","issue_events_url":"https://api.github.com/repos/danielgustafsson/gpdb/issues/events{/number}","events_url":"https://api.github.com/repos/danielgustafsson/gpdb/events","assignees_url":"https://api.github.com/repos/danielgustafsson/gpdb/assignees{/user}","branches_url":"https://api.github.com/repos/danielgustafsson/gpdb/branches{/branch}","tags_url":"https://api.github.com/repos/danielgustafsson/gpdb/tags","blobs_url":"https://api.github.com/repos/danielgustafsson/gpdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danielgustafsson/gpdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danielgustafsson/gpdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/danielgustafsson/gpdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danielgustafsson/gpdb/statuses/{sha}","languages_url":"https://api.github.com/repos/danielgustafsson/gpdb/languages","stargazers_url":"https://api.github.com/repos/danielgustafsson/gpdb/stargazers","contributors_url":"https://api.github.com/repos/danielgustafsson/gpdb/contributors","subscribers_url":"https://api.github.com/repos/danielgustafsson/gpdb/subscribers","subscription_url":"https://api.github.com/repos/danielgustafsson/gpdb/subscription","commits_url":"https://api.github.com/repos/danielgustafsson/gpdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/danielgustafsson/gpdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/danielgustafsson/gpdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/danielgustafsson/gpdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/danielgustafsson/gpdb/contents/{+path}","compare_url":"https://api.github.com/repos/danielgustafsson/gpdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danielgustafsson/gpdb/merges","archive_url":"https://api.github.com/repos/danielgustafsson/gpdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danielgustafsson/gpdb/downloads","issues_url":"https://api.github.com/repos/danielgustafsson/gpdb/issues{/number}","pulls_url":"https://api.github.com/repos/danielgustafsson/gpdb/pulls{/number}","milestones_url":"https://api.github.com/repos/danielgustafsson/gpdb/milestones{/number}","notifications_url":"https://api.github.com/repos/danielgustafsson/gpdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danielgustafsson/gpdb/labels{/name}","releases_url":"https://api.github.com/repos/danielgustafsson/gpdb/releases{/id}","deployments_url":"https://api.github.com/repos/danielgustafsson/gpdb/deployments","created_at":"2015-11-02T20:26:32Z","updated_at":"2015-11-02T20:27:17Z","pushed_at":"2016-02-25T11:29:23Z","git_url":"git://github.com/danielgustafsson/gpdb.git","ssh_url":"git@github.com:danielgustafsson/gpdb.git","clone_url":"https://github.com/danielgustafsson/gpdb.git","svn_url":"https://github.com/danielgustafsson/gpdb","homepage":"http://greenplum.org","size":132006,"stargazers_count":0,"watchers_count":0,"language":"PLpgSQL","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"greenplum-db:master","ref":"master","sha":"8932914dfdbd9e41678efa3b3f58b54e15e2d2d3","user":{"login":"greenplum-db","id":14097842,"avatar_url":"https://avatars.githubusercontent.com/u/14097842?v=3","gravatar_id":"","url":"https://api.github.com/users/greenplum-db","html_url":"https://github.com/greenplum-db","followers_url":"https://api.github.com/users/greenplum-db/followers","following_url":"https://api.github.com/users/greenplum-db/following{/other_user}","gists_url":"https://api.github.com/users/greenplum-db/gists{/gist_id}","starred_url":"https://api.github.com/users/greenplum-db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greenplum-db/subscriptions","organizations_url":"https://api.github.com/users/greenplum-db/orgs","repos_url":"https://api.github.com/users/greenplum-db/repos","events_url":"https://api.github.com/users/greenplum-db/events{/privacy}","received_events_url":"https://api.github.com/users/greenplum-db/received_events","type":"Organization","site_admin":false},"repo":{"id":44781140,"name":"gpdb","full_name":"greenplum-db/gpdb","owner":{"login":"greenplum-db","id":14097842,"avatar_url":"https://avatars.githubusercontent.com/u/14097842?v=3","gravatar_id":"","url":"https://api.github.com/users/greenplum-db","html_url":"https://github.com/greenplum-db","followers_url":"https://api.github.com/users/greenplum-db/followers","following_url":"https://api.github.com/users/greenplum-db/following{/other_user}","gists_url":"https://api.github.com/users/greenplum-db/gists{/gist_id}","starred_url":"https://api.github.com/users/greenplum-db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greenplum-db/subscriptions","organizations_url":"https://api.github.com/users/greenplum-db/orgs","repos_url":"https://api.github.com/users/greenplum-db/repos","events_url":"https://api.github.com/users/greenplum-db/events{/privacy}","received_events_url":"https://api.github.com/users/greenplum-db/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/greenplum-db/gpdb","description":"Greenplum Database","fork":false,"url":"https://api.github.com/repos/greenplum-db/gpdb","forks_url":"https://api.github.com/repos/greenplum-db/gpdb/forks","keys_url":"https://api.github.com/repos/greenplum-db/gpdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/greenplum-db/gpdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/greenplum-db/gpdb/teams","hooks_url":"https://api.github.com/repos/greenplum-db/gpdb/hooks","issue_events_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/events{/number}","events_url":"https://api.github.com/repos/greenplum-db/gpdb/events","assignees_url":"https://api.github.com/repos/greenplum-db/gpdb/assignees{/user}","branches_url":"https://api.github.com/repos/greenplum-db/gpdb/branches{/branch}","tags_url":"https://api.github.com/repos/greenplum-db/gpdb/tags","blobs_url":"https://api.github.com/repos/greenplum-db/gpdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/greenplum-db/gpdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/greenplum-db/gpdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/greenplum-db/gpdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/greenplum-db/gpdb/statuses/{sha}","languages_url":"https://api.github.com/repos/greenplum-db/gpdb/languages","stargazers_url":"https://api.github.com/repos/greenplum-db/gpdb/stargazers","contributors_url":"https://api.github.com/repos/greenplum-db/gpdb/contributors","subscribers_url":"https://api.github.com/repos/greenplum-db/gpdb/subscribers","subscription_url":"https://api.github.com/repos/greenplum-db/gpdb/subscription","commits_url":"https://api.github.com/repos/greenplum-db/gpdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/greenplum-db/gpdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/greenplum-db/gpdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/greenplum-db/gpdb/contents/{+path}","compare_url":"https://api.github.com/repos/greenplum-db/gpdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/greenplum-db/gpdb/merges","archive_url":"https://api.github.com/repos/greenplum-db/gpdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/greenplum-db/gpdb/downloads","issues_url":"https://api.github.com/repos/greenplum-db/gpdb/issues{/number}","pulls_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls{/number}","milestones_url":"https://api.github.com/repos/greenplum-db/gpdb/milestones{/number}","notifications_url":"https://api.github.com/repos/greenplum-db/gpdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/greenplum-db/gpdb/labels{/name}","releases_url":"https://api.github.com/repos/greenplum-db/gpdb/releases{/id}","deployments_url":"https://api.github.com/repos/greenplum-db/gpdb/deployments","created_at":"2015-10-23T00:25:17Z","updated_at":"2016-02-25T11:43:40Z","pushed_at":"2016-02-25T15:53:09Z","git_url":"git://github.com/greenplum-db/gpdb.git","ssh_url":"git@github.com:greenplum-db/gpdb.git","clone_url":"https://github.com/greenplum-db/gpdb.git","svn_url":"https://github.com/greenplum-db/gpdb","homepage":"http://greenplum.org","size":135778,"stargazers_count":1326,"watchers_count":1326,"language":"PLpgSQL","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":322,"mirror_url":null,"open_issues_count":66,"forks":322,"open_issues":66,"watchers":1326,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/434"},"html":{"href":"https://github.com/greenplum-db/gpdb/pull/434"},"issue":{"href":"https://api.github.com/repos/greenplum-db/gpdb/issues/434"},"comments":{"href":"https://api.github.com/repos/greenplum-db/gpdb/issues/434/comments"},"review_comments":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/434/comments"},"review_comment":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/434/commits"},"statuses":{"href":"https://api.github.com/repos/greenplum-db/gpdb/statuses/86575a709b853edc70b1c2aa360781c5750d5bf9"}}}}