{"action":"created","comment":{"url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/pulls/comments/72494168","id":72494168,"diff_hunk":"@@ -83,6 +83,17 @@\n @property (assign, nonatomic) BOOL sendButtonOnRight;\n \n /**\n+ *  Specify if the send button might be enabled.\n+ *\n+ *  @discussion Normally the send button will be enabled if the `textView` contains text. This\n+ *  property overrides this behaviour, for example to disable the send button, if the internet\n+ *  connection is lost.\n+ *\n+ *  @see `updateSendButtonEnabledState`.\n+ */\n+@property (assign, nonatomic) BOOL sendButtonEnabled;","path":"JSQMessagesViewController/Views/JSQMessagesInputToolbar.h","position":12,"original_position":12,"commit_id":"5b856e68bc0240dd805c80bb8a755e384688ed68","original_commit_id":"5b856e68bc0240dd805c80bb8a755e384688ed68","user":{"login":"Lucashuang0802","id":3754490,"avatar_url":"https://avatars.githubusercontent.com/u/3754490?v=3","gravatar_id":"","url":"https://api.github.com/users/Lucashuang0802","html_url":"https://github.com/Lucashuang0802","followers_url":"https://api.github.com/users/Lucashuang0802/followers","following_url":"https://api.github.com/users/Lucashuang0802/following{/other_user}","gists_url":"https://api.github.com/users/Lucashuang0802/gists{/gist_id}","starred_url":"https://api.github.com/users/Lucashuang0802/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lucashuang0802/subscriptions","organizations_url":"https://api.github.com/users/Lucashuang0802/orgs","repos_url":"https://api.github.com/users/Lucashuang0802/repos","events_url":"https://api.github.com/users/Lucashuang0802/events{/privacy}","received_events_url":"https://api.github.com/users/Lucashuang0802/received_events","type":"User","site_admin":false},"body":"I would vote for `sendButtonDisabled`. It's intuitive for developers to control the send button. And I propose to deprecate `toggleSendButtonEnabled`. Instead, let property setter to handle all necessary internal changes.","created_at":"2016-07-27T18:20:37Z","updated_at":"2016-07-27T18:20:37Z","html_url":"https://github.com/jessesquires/JSQMessagesViewController/pull/1609#discussion_r72494168","pull_request_url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/pulls/1609","_links":{"self":{"href":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/pulls/comments/72494168"},"html":{"href":"https://github.com/jessesquires/JSQMessagesViewController/pull/1609#discussion_r72494168"},"pull_request":{"href":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/pulls/1609"}}},"pull_request":{"url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/pulls/1609","id":71804157,"html_url":"https://github.com/jessesquires/JSQMessagesViewController/pull/1609","diff_url":"https://github.com/jessesquires/JSQMessagesViewController/pull/1609.diff","patch_url":"https://github.com/jessesquires/JSQMessagesViewController/pull/1609.patch","issue_url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/issues/1609","number":1609,"state":"closed","locked":false,"title":"Added sendButtonEndabled property to input toolbar. Solves #1575.","user":{"login":"sebastianludwig","id":1715010,"avatar_url":"https://avatars.githubusercontent.com/u/1715010?v=3","gravatar_id":"","url":"https://api.github.com/users/sebastianludwig","html_url":"https://github.com/sebastianludwig","followers_url":"https://api.github.com/users/sebastianludwig/followers","following_url":"https://api.github.com/users/sebastianludwig/following{/other_user}","gists_url":"https://api.github.com/users/sebastianludwig/gists{/gist_id}","starred_url":"https://api.github.com/users/sebastianludwig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebastianludwig/subscriptions","organizations_url":"https://api.github.com/users/sebastianludwig/orgs","repos_url":"https://api.github.com/users/sebastianludwig/repos","events_url":"https://api.github.com/users/sebastianludwig/events{/privacy}","received_events_url":"https://api.github.com/users/sebastianludwig/received_events","type":"User","site_admin":false},"body":"## Pull request checklist\r\n\r\n- [x] All tests pass. Demo project builds and runs.\r\n- [x] I have resolved any merge conflicts.\r\n- [x] I have followed the [coding style](https://github.com/jessesquires/HowToContribute#style-guidelines), and reviewed the [contributing guidelines](https://github.com/jessesquires/JSQMessagesViewController/blob/develop/.github/CONTRIBUTING.md). Confirmation: 💪😎👊\r\n\r\n#### This fixes issue #1575.\r\n\r\n## What's in this pull request?\r\n\r\n> Added sendButtonEndabled property to input toolbar. Solves #1575.","created_at":"2016-05-28T15:06:54Z","updated_at":"2016-07-27T18:20:37Z","closed_at":"2016-07-27T17:27:46Z","merged_at":"2016-07-27T17:27:46Z","merge_commit_sha":"e6652fb5d0224153837ce62963c6042811982214","assignee":{"login":"jessesquires","id":2301114,"avatar_url":"https://avatars.githubusercontent.com/u/2301114?v=3","gravatar_id":"","url":"https://api.github.com/users/jessesquires","html_url":"https://github.com/jessesquires","followers_url":"https://api.github.com/users/jessesquires/followers","following_url":"https://api.github.com/users/jessesquires/following{/other_user}","gists_url":"https://api.github.com/users/jessesquires/gists{/gist_id}","starred_url":"https://api.github.com/users/jessesquires/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jessesquires/subscriptions","organizations_url":"https://api.github.com/users/jessesquires/orgs","repos_url":"https://api.github.com/users/jessesquires/repos","events_url":"https://api.github.com/users/jessesquires/events{/privacy}","received_events_url":"https://api.github.com/users/jessesquires/received_events","type":"User","site_admin":false},"assignees":[{"login":"jessesquires","id":2301114,"avatar_url":"https://avatars.githubusercontent.com/u/2301114?v=3","gravatar_id":"","url":"https://api.github.com/users/jessesquires","html_url":"https://github.com/jessesquires","followers_url":"https://api.github.com/users/jessesquires/followers","following_url":"https://api.github.com/users/jessesquires/following{/other_user}","gists_url":"https://api.github.com/users/jessesquires/gists{/gist_id}","starred_url":"https://api.github.com/users/jessesquires/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jessesquires/subscriptions","organizations_url":"https://api.github.com/users/jessesquires/orgs","repos_url":"https://api.github.com/users/jessesquires/repos","events_url":"https://api.github.com/users/jessesquires/events{/privacy}","received_events_url":"https://api.github.com/users/jessesquires/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/milestones/7","html_url":"https://github.com/jessesquires/JSQMessagesViewController/milestones/8.0.0","labels_url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/milestones/7/labels","id":917263,"number":7,"title":"8.0.0","description":"* Dropping iOS 7 support. Library will be iOS 8+ only.\r\n* Breaking API changes from version 7.x.x\r\n\r\nWork happening on the [`develop`](https://github.com/jessesquires/JSQMessagesViewController/tree/develop) branch.\r\n","creator":{"login":"jessesquires","id":2301114,"avatar_url":"https://avatars.githubusercontent.com/u/2301114?v=3","gravatar_id":"","url":"https://api.github.com/users/jessesquires","html_url":"https://github.com/jessesquires","followers_url":"https://api.github.com/users/jessesquires/followers","following_url":"https://api.github.com/users/jessesquires/following{/other_user}","gists_url":"https://api.github.com/users/jessesquires/gists{/gist_id}","starred_url":"https://api.github.com/users/jessesquires/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jessesquires/subscriptions","organizations_url":"https://api.github.com/users/jessesquires/orgs","repos_url":"https://api.github.com/users/jessesquires/repos","events_url":"https://api.github.com/users/jessesquires/events{/privacy}","received_events_url":"https://api.github.com/users/jessesquires/received_events","type":"User","site_admin":false},"open_issues":46,"closed_issues":56,"state":"open","created_at":"2014-12-30T01:47:08Z","updated_at":"2016-07-27T17:27:47Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/pulls/1609/commits","review_comments_url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/pulls/1609/comments","review_comment_url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/issues/1609/comments","statuses_url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/statuses/5b856e68bc0240dd805c80bb8a755e384688ed68","head":{"label":"sebastianludwig:disable_send_button","ref":"disable_send_button","sha":"5b856e68bc0240dd805c80bb8a755e384688ed68","user":{"login":"sebastianludwig","id":1715010,"avatar_url":"https://avatars.githubusercontent.com/u/1715010?v=3","gravatar_id":"","url":"https://api.github.com/users/sebastianludwig","html_url":"https://github.com/sebastianludwig","followers_url":"https://api.github.com/users/sebastianludwig/followers","following_url":"https://api.github.com/users/sebastianludwig/following{/other_user}","gists_url":"https://api.github.com/users/sebastianludwig/gists{/gist_id}","starred_url":"https://api.github.com/users/sebastianludwig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebastianludwig/subscriptions","organizations_url":"https://api.github.com/users/sebastianludwig/orgs","repos_url":"https://api.github.com/users/sebastianludwig/repos","events_url":"https://api.github.com/users/sebastianludwig/events{/privacy}","received_events_url":"https://api.github.com/users/sebastianludwig/received_events","type":"User","site_admin":false},"repo":{"id":31117321,"name":"JSQMessagesViewController","full_name":"sebastianludwig/JSQMessagesViewController","owner":{"login":"sebastianludwig","id":1715010,"avatar_url":"https://avatars.githubusercontent.com/u/1715010?v=3","gravatar_id":"","url":"https://api.github.com/users/sebastianludwig","html_url":"https://github.com/sebastianludwig","followers_url":"https://api.github.com/users/sebastianludwig/followers","following_url":"https://api.github.com/users/sebastianludwig/following{/other_user}","gists_url":"https://api.github.com/users/sebastianludwig/gists{/gist_id}","starred_url":"https://api.github.com/users/sebastianludwig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebastianludwig/subscriptions","organizations_url":"https://api.github.com/users/sebastianludwig/orgs","repos_url":"https://api.github.com/users/sebastianludwig/repos","events_url":"https://api.github.com/users/sebastianludwig/events{/privacy}","received_events_url":"https://api.github.com/users/sebastianludwig/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sebastianludwig/JSQMessagesViewController","description":"An elegant messages UI library for iOS","fork":true,"url":"https://api.github.com/repos/sebastianludwig/JSQMessagesViewController","forks_url":"https://api.github.com/repos/sebastianludwig/JSQMessagesViewController/forks","keys_url":"https://api.github.com/repos/sebastianludwig/JSQMessagesViewController/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sebastianludwig/JSQMessagesViewController/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sebastianludwig/JSQMessagesViewController/teams","hooks_url":"https://api.github.com/repos/sebastianludwig/JSQMessagesViewController/hooks","issue_events_url":"https://api.github.com/repos/sebastianludwig/JSQMessagesViewController/issues/events{/number}","events_url":"https://api.github.com/repos/sebastianludwig/JSQMessagesViewController/events","assignees_url":"https://api.github.com/repos/sebastianludwig/JSQMessagesViewController/assignees{/user}","branches_url":"https://api.github.com/repos/sebastianludwig/JSQMessagesViewController/branches{/branch}","tags_url":"https://api.github.com/repos/sebastianludwig/JSQMessagesViewController/tags","blobs_url":"https://api.github.com/repos/sebastianludwig/JSQMessagesViewController/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sebastianludwig/JSQMessagesViewController/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sebastianludwig/JSQMessagesViewController/git/refs{/sha}","trees_url":"https://api.github.com/repos/sebastianludwig/JSQMessagesViewController/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sebastianludwig/JSQMessagesViewController/statuses/{sha}","languages_url":"https://api.github.com/repos/sebastianludwig/JSQMessagesViewController/languages","stargazers_url":"https://api.github.com/repos/sebastianludwig/JSQMessagesViewController/stargazers","contributors_url":"https://api.github.com/repos/sebastianludwig/JSQMessagesViewController/contributors","subscribers_url":"https://api.github.com/repos/sebastianludwig/JSQMessagesViewController/subscribers","subscription_url":"https://api.github.com/repos/sebastianludwig/JSQMessagesViewController/subscription","commits_url":"https://api.github.com/repos/sebastianludwig/JSQMessagesViewController/commits{/sha}","git_commits_url":"https://api.github.com/repos/sebastianludwig/JSQMessagesViewController/git/commits{/sha}","comments_url":"https://api.github.com/repos/sebastianludwig/JSQMessagesViewController/comments{/number}","issue_comment_url":"https://api.github.com/repos/sebastianludwig/JSQMessagesViewController/issues/comments{/number}","contents_url":"https://api.github.com/repos/sebastianludwig/JSQMessagesViewController/contents/{+path}","compare_url":"https://api.github.com/repos/sebastianludwig/JSQMessagesViewController/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sebastianludwig/JSQMessagesViewController/merges","archive_url":"https://api.github.com/repos/sebastianludwig/JSQMessagesViewController/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sebastianludwig/JSQMessagesViewController/downloads","issues_url":"https://api.github.com/repos/sebastianludwig/JSQMessagesViewController/issues{/number}","pulls_url":"https://api.github.com/repos/sebastianludwig/JSQMessagesViewController/pulls{/number}","milestones_url":"https://api.github.com/repos/sebastianludwig/JSQMessagesViewController/milestones{/number}","notifications_url":"https://api.github.com/repos/sebastianludwig/JSQMessagesViewController/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sebastianludwig/JSQMessagesViewController/labels{/name}","releases_url":"https://api.github.com/repos/sebastianludwig/JSQMessagesViewController/releases{/id}","deployments_url":"https://api.github.com/repos/sebastianludwig/JSQMessagesViewController/deployments","created_at":"2015-02-21T06:20:05Z","updated_at":"2015-02-21T08:17:51Z","pushed_at":"2016-05-30T07:05:10Z","git_url":"git://github.com/sebastianludwig/JSQMessagesViewController.git","ssh_url":"git@github.com:sebastianludwig/JSQMessagesViewController.git","clone_url":"https://github.com/sebastianludwig/JSQMessagesViewController.git","svn_url":"https://github.com/sebastianludwig/JSQMessagesViewController","homepage":"http://jessesquires.com/JSQMessagesViewController","size":18264,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"jessesquires:develop","ref":"develop","sha":"e0016e4b7b5acf8326692882a77e636068503fb8","user":{"login":"jessesquires","id":2301114,"avatar_url":"https://avatars.githubusercontent.com/u/2301114?v=3","gravatar_id":"","url":"https://api.github.com/users/jessesquires","html_url":"https://github.com/jessesquires","followers_url":"https://api.github.com/users/jessesquires/followers","following_url":"https://api.github.com/users/jessesquires/following{/other_user}","gists_url":"https://api.github.com/users/jessesquires/gists{/gist_id}","starred_url":"https://api.github.com/users/jessesquires/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jessesquires/subscriptions","organizations_url":"https://api.github.com/users/jessesquires/orgs","repos_url":"https://api.github.com/users/jessesquires/repos","events_url":"https://api.github.com/users/jessesquires/events{/privacy}","received_events_url":"https://api.github.com/users/jessesquires/received_events","type":"User","site_admin":false},"repo":{"id":8257106,"name":"JSQMessagesViewController","full_name":"jessesquires/JSQMessagesViewController","owner":{"login":"jessesquires","id":2301114,"avatar_url":"https://avatars.githubusercontent.com/u/2301114?v=3","gravatar_id":"","url":"https://api.github.com/users/jessesquires","html_url":"https://github.com/jessesquires","followers_url":"https://api.github.com/users/jessesquires/followers","following_url":"https://api.github.com/users/jessesquires/following{/other_user}","gists_url":"https://api.github.com/users/jessesquires/gists{/gist_id}","starred_url":"https://api.github.com/users/jessesquires/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jessesquires/subscriptions","organizations_url":"https://api.github.com/users/jessesquires/orgs","repos_url":"https://api.github.com/users/jessesquires/repos","events_url":"https://api.github.com/users/jessesquires/events{/privacy}","received_events_url":"https://api.github.com/users/jessesquires/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jessesquires/JSQMessagesViewController","description":"An elegant messages UI library for iOS","fork":false,"url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController","forks_url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/forks","keys_url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/teams","hooks_url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/hooks","issue_events_url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/issues/events{/number}","events_url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/events","assignees_url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/assignees{/user}","branches_url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/branches{/branch}","tags_url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/tags","blobs_url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/git/refs{/sha}","trees_url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/statuses/{sha}","languages_url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/languages","stargazers_url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/stargazers","contributors_url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/contributors","subscribers_url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/subscribers","subscription_url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/subscription","commits_url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/commits{/sha}","git_commits_url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/git/commits{/sha}","comments_url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/comments{/number}","issue_comment_url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/issues/comments{/number}","contents_url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/contents/{+path}","compare_url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/merges","archive_url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/downloads","issues_url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/issues{/number}","pulls_url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/pulls{/number}","milestones_url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/milestones{/number}","notifications_url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/labels{/name}","releases_url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/releases{/id}","deployments_url":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/deployments","created_at":"2013-02-17T21:40:44Z","updated_at":"2016-07-27T17:26:06Z","pushed_at":"2016-07-27T17:50:09Z","git_url":"git://github.com/jessesquires/JSQMessagesViewController.git","ssh_url":"git@github.com:jessesquires/JSQMessagesViewController.git","clone_url":"https://github.com/jessesquires/JSQMessagesViewController.git","svn_url":"https://github.com/jessesquires/JSQMessagesViewController","homepage":"http://jessesquires.com/JSQMessagesViewController/","size":60007,"stargazers_count":8754,"watchers_count":8754,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2039,"mirror_url":null,"open_issues_count":134,"forks":2039,"open_issues":134,"watchers":8754,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/pulls/1609"},"html":{"href":"https://github.com/jessesquires/JSQMessagesViewController/pull/1609"},"issue":{"href":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/issues/1609"},"comments":{"href":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/issues/1609/comments"},"review_comments":{"href":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/pulls/1609/comments"},"review_comment":{"href":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/pulls/1609/commits"},"statuses":{"href":"https://api.github.com/repos/jessesquires/JSQMessagesViewController/statuses/5b856e68bc0240dd805c80bb8a755e384688ed68"}}}}
{"actor":{"display_login":"Lucashuang0802"}}