{"action":"closed","issue":{"url":"https://api.github.com/repos/california-civic-data-coalition/django-calaccess-raw-data/issues/1178","labels_url":"https://api.github.com/repos/california-civic-data-coalition/django-calaccess-raw-data/issues/1178/labels{/name}","comments_url":"https://api.github.com/repos/california-civic-data-coalition/django-calaccess-raw-data/issues/1178/comments","events_url":"https://api.github.com/repos/california-civic-data-coalition/django-calaccess-raw-data/issues/1178/events","html_url":"https://github.com/california-civic-data-coalition/django-calaccess-raw-data/issues/1178","id":127325257,"number":1178,"title":"Add app_name option to downloadcalaccessrawdata","user":{"login":"gordonje","id":4304548,"avatar_url":"https://avatars.githubusercontent.com/u/4304548?v=3","gravatar_id":"","url":"https://api.github.com/users/gordonje","html_url":"https://github.com/gordonje","followers_url":"https://api.github.com/users/gordonje/followers","following_url":"https://api.github.com/users/gordonje/following{/other_user}","gists_url":"https://api.github.com/users/gordonje/gists{/gist_id}","starred_url":"https://api.github.com/users/gordonje/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gordonje/subscriptions","organizations_url":"https://api.github.com/users/gordonje/orgs","repos_url":"https://api.github.com/users/gordonje/repos","events_url":"https://api.github.com/users/gordonje/events{/privacy}","received_events_url":"https://api.github.com/users/gordonje/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/california-civic-data-coalition/django-calaccess-raw-data/labels/question","name":"question","color":"cc317c"}],"state":"closed","locked":false,"assignee":{"login":"gordonje","id":4304548,"avatar_url":"https://avatars.githubusercontent.com/u/4304548?v=3","gravatar_id":"","url":"https://api.github.com/users/gordonje","html_url":"https://github.com/gordonje","followers_url":"https://api.github.com/users/gordonje/followers","following_url":"https://api.github.com/users/gordonje/following{/other_user}","gists_url":"https://api.github.com/users/gordonje/gists{/gist_id}","starred_url":"https://api.github.com/users/gordonje/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gordonje/subscriptions","organizations_url":"https://api.github.com/users/gordonje/orgs","repos_url":"https://api.github.com/users/gordonje/repos","events_url":"https://api.github.com/users/gordonje/events{/privacy}","received_events_url":"https://api.github.com/users/gordonje/received_events","type":"User","site_admin":false},"milestone":null,"comments":2,"created_at":"2016-01-18T22:42:31Z","updated_at":"2016-01-22T22:21:04Z","closed_at":"2016-01-22T22:21:04Z","body":"(Arose out of work on #1169)\r\n\r\nThe `downloadcalaccessrawdata` command has a global `download_file()` function that's called by one of the command's `.download` method. I'm wondering why the global function is necessary: Why not just move all this logic inside `.download`? \r\n\r\nIt doesn't appear as though the global function is being called anywhere else in calaccess_raw's code.\r\n\r\nLooks like this was added as part of implementing the resume-download option (#1154)  because other apps need to be able to use this logic. \r\n\r\nSeems like we did something similar when we implemented an `--app-name` option for loadcalaccessrawfile (see #1145). \r\n\r\nMaybe the download command needs the `--app-name` option as well, then we could move this logic back inside the command's method."}}