{"action":"created","issue":{"url":"https://api.github.com/repos/s-rah/onionscan/issues/113","repository_url":"https://api.github.com/repos/s-rah/onionscan","labels_url":"https://api.github.com/repos/s-rah/onionscan/issues/113/labels{/name}","comments_url":"https://api.github.com/repos/s-rah/onionscan/issues/113/comments","events_url":"https://api.github.com/repos/s-rah/onionscan/issues/113/events","html_url":"https://github.com/s-rah/onionscan/pull/113","id":188915889,"number":113,"title":"Dispatch onion scans from table","user":{"login":"laanwj","id":126646,"avatar_url":"https://avatars.githubusercontent.com/u/126646?v=3","gravatar_id":"","url":"https://api.github.com/users/laanwj","html_url":"https://github.com/laanwj","followers_url":"https://api.github.com/users/laanwj/followers","following_url":"https://api.github.com/users/laanwj/following{/other_user}","gists_url":"https://api.github.com/users/laanwj/gists{/gist_id}","starred_url":"https://api.github.com/users/laanwj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laanwj/subscriptions","organizations_url":"https://api.github.com/users/laanwj/orgs","repos_url":"https://api.github.com/users/laanwj/repos","events_url":"https://api.github.com/users/laanwj/events{/privacy}","received_events_url":"https://api.github.com/users/laanwj/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-11-12T15:01:14Z","updated_at":"2016-11-14T09:25:05Z","closed_at":"2016-11-14T09:18:21Z","pull_request":{"url":"https://api.github.com/repos/s-rah/onionscan/pulls/113","html_url":"https://github.com/s-rah/onionscan/pull/113","diff_url":"https://github.com/s-rah/onionscan/pull/113.diff","patch_url":"https://github.com/s-rah/onionscan/pull/113.patch"},"body":"Create a single table `allScans` with a mapping from scan name to `{protocol.Scanner,bool runByDefault}`. Remove the function `PerformNextAction` with the huge switch statement and instead directly use the map for dispatching. Also use this map in `GetAllActions` to avoid duplication.\r\n\r\nThe only user visible impact should be that the scans are re-ordered.\r\n\r\nThis is just an experiment, don't know if you'll see it as an improvement :)"},"comment":{"url":"https://api.github.com/repos/s-rah/onionscan/issues/comments/260286391","html_url":"https://github.com/s-rah/onionscan/pull/113#issuecomment-260286391","issue_url":"https://api.github.com/repos/s-rah/onionscan/issues/113","id":260286391,"user":{"login":"s-rah","id":106626,"avatar_url":"https://avatars.githubusercontent.com/u/106626?v=3","gravatar_id":"","url":"https://api.github.com/users/s-rah","html_url":"https://github.com/s-rah","followers_url":"https://api.github.com/users/s-rah/followers","following_url":"https://api.github.com/users/s-rah/following{/other_user}","gists_url":"https://api.github.com/users/s-rah/gists{/gist_id}","starred_url":"https://api.github.com/users/s-rah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s-rah/subscriptions","organizations_url":"https://api.github.com/users/s-rah/orgs","repos_url":"https://api.github.com/users/s-rah/repos","events_url":"https://api.github.com/users/s-rah/events{/privacy}","received_events_url":"https://api.github.com/users/s-rah/received_events","type":"User","site_admin":false},"created_at":"2016-11-14T09:25:05Z","updated_at":"2016-11-14T09:25:05Z","body":"Choosing to merge this for now since it's a much simpler structure and it lends itself better to future improvements in this space (changing protocols, etc.) I'm not so sure about the ordering, I actually think we should probably come up with a few different sets of scans based on common failures (with web being a baseline since it's the most common, along with ssh and tls) - although I've not yet got a good idea about what that looks like practically.\r\n\r\n"}}
{"actor":{"display_login":"s-rah"}}