{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/react/issues/8329","repository_url":"https://api.github.com/repos/facebook/react","labels_url":"https://api.github.com/repos/facebook/react/issues/8329/labels{/name}","comments_url":"https://api.github.com/repos/facebook/react/issues/8329/comments","events_url":"https://api.github.com/repos/facebook/react/issues/8329/events","html_url":"https://github.com/facebook/react/pull/8329","id":190049056,"number":8329,"title":"Do not extract mouse events for children of disabled parents","user":{"login":"nhunzaker","id":590904,"avatar_url":"https://avatars.githubusercontent.com/u/590904?v=3","gravatar_id":"","url":"https://api.github.com/users/nhunzaker","html_url":"https://github.com/nhunzaker","followers_url":"https://api.github.com/users/nhunzaker/followers","following_url":"https://api.github.com/users/nhunzaker/following{/other_user}","gists_url":"https://api.github.com/users/nhunzaker/gists{/gist_id}","starred_url":"https://api.github.com/users/nhunzaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nhunzaker/subscriptions","organizations_url":"https://api.github.com/users/nhunzaker/orgs","repos_url":"https://api.github.com/users/nhunzaker/repos","events_url":"https://api.github.com/users/nhunzaker/events{/privacy}","received_events_url":"https://api.github.com/users/nhunzaker/received_events","type":"User","site_admin":false},"labels":[{"id":196858374,"url":"https://api.github.com/repos/facebook/react/labels/CLA%20Signed","name":"CLA Signed","color":"e7e7e7","default":false},{"id":130714623,"url":"https://api.github.com/repos/facebook/react/labels/GH%20Review:%20review-needed","name":"GH Review: review-needed","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-11-17T13:38:26Z","updated_at":"2016-11-17T14:47:42Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/facebook/react/pulls/8329","html_url":"https://github.com/facebook/react/pull/8329","diff_url":"https://github.com/facebook/react/pull/8329.diff","patch_url":"https://github.com/facebook/react/pull/8329.patch"},"body":"Potential fix for https://github.com/facebook/react/issues/8308. React (my fault) only sifts out mouse events for disabled elements that are the direct target of dispatch. If an element is the child of a disabled parent, the event incorrectly dispatches because `SimpleEventPlugin` doesn't see a `disabled` prop. For example:\r\n\r\n```javascript\r\n<button onClick={...} disabled>\r\n    <span />    <------ Click!\r\n</button>\r\n```\r\n\r\nIncorrectly fires the onClick handler\r\n\r\nOriginal test case (From that issue) here:\r\nhttps://jsfiddle.net/rcataldo/69z2wepo/62589/\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/facebook/react/issues/comments/261265503","html_url":"https://github.com/facebook/react/pull/8329#issuecomment-261265503","issue_url":"https://api.github.com/repos/facebook/react/issues/8329","id":261265503,"user":{"login":"sebmarkbage","id":63648,"avatar_url":"https://avatars.githubusercontent.com/u/63648?v=3","gravatar_id":"","url":"https://api.github.com/users/sebmarkbage","html_url":"https://github.com/sebmarkbage","followers_url":"https://api.github.com/users/sebmarkbage/followers","following_url":"https://api.github.com/users/sebmarkbage/following{/other_user}","gists_url":"https://api.github.com/users/sebmarkbage/gists{/gist_id}","starred_url":"https://api.github.com/users/sebmarkbage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebmarkbage/subscriptions","organizations_url":"https://api.github.com/users/sebmarkbage/orgs","repos_url":"https://api.github.com/users/sebmarkbage/repos","events_url":"https://api.github.com/users/sebmarkbage/events{/privacy}","received_events_url":"https://api.github.com/users/sebmarkbage/received_events","type":"User","site_admin":false},"created_at":"2016-11-17T14:47:42Z","updated_at":"2016-11-17T14:47:42Z","body":"Ideally we should do this during `traverseTwoPhase`. We're already walking this. Conceptually events traverse from the root and down to the target and back up. Any time a parent should be able to intercept.\r\n\r\nWe could make `traverseTwoPhase` return a boolean and if it returns false we abort the capture phase and return back up the bubble from that point on."}}
{"actor":{"display_login":"sebmarkbage"}}