{"action":"created","comment":{"url":"https://api.github.com/repos/mantidproject/mslice/pulls/comments/82578200","pull_request_review_id":3475360,"id":82578200,"diff_hunk":"@@ -33,7 +40,13 @@ def calculate_projection(self, input_workspace, axis1, axis2):\n                 str(dim0.getMaximum()) + ',' + str(dim0.getNBins())\n             dim1 = dim1.getName() + ',' + str(dim1.getMinimum()) + ',' +\\\n                 str(dim1.getMaximum()) + ',' + str(dim1.getNBins())\n-            return SliceMD(InputWorkspace=output_workspace, OutputWorkspace=output_workspace, AlignedDim0=dim0,\n-                           AlignedDim1=dim1)\n+            SliceMD(InputWorkspace=output_workspace, OutputWorkspace=output_workspace, AlignedDim0=dim0,\n+                    AlignedDim1=dim1)\n         else:\n             raise NotImplementedError(\"Not implemented axis1 = %s and axis2 = %s\" % (axis1, axis2))\n+        # Now scale the energy axis if required - ConvertToMD always gives DeltaE in meV\n+        if units == WAVENUMBER_LABEL:\n+            TransformMD(InputWorkspace=output_workspace, OutputWorkspace=output_workspace, Scaling=scale)\n+            self._workspace_provider.get_workspace_handle(output_workspace).setComment('MSlice_in_wavenumber')\n+        elif units != MEV_LABEL:\n+            raise NotImplementedError(\"Unit %s not recognised. Only 'meV' and 'cm-1' implemented.\" % (units))","path":"models/projection/powder/mantid_projection_calculator.py","position":57,"original_position":57,"commit_id":"a40c8b2836c014a5be01a37e8ef5755827911343","original_commit_id":"a40c8b2836c014a5be01a37e8ef5755827911343","user":{"login":"mducle","id":14106963,"avatar_url":"https://avatars.githubusercontent.com/u/14106963?v=3","gravatar_id":"","url":"https://api.github.com/users/mducle","html_url":"https://github.com/mducle","followers_url":"https://api.github.com/users/mducle/followers","following_url":"https://api.github.com/users/mducle/following{/other_user}","gists_url":"https://api.github.com/users/mducle/gists{/gist_id}","starred_url":"https://api.github.com/users/mducle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mducle/subscriptions","organizations_url":"https://api.github.com/users/mducle/orgs","repos_url":"https://api.github.com/users/mducle/repos","events_url":"https://api.github.com/users/mducle/events{/privacy}","received_events_url":"https://api.github.com/users/mducle/received_events","type":"User","site_admin":false},"body":"Ah oops. Yes. Sorry, I should at a return value. I was only checking it with the GUI.","created_at":"2016-10-10T10:28:48Z","updated_at":"2016-10-10T10:28:48Z","html_url":"https://github.com/mantidproject/mslice/pull/93#discussion_r82578200","pull_request_url":"https://api.github.com/repos/mantidproject/mslice/pulls/93","_links":{"self":{"href":"https://api.github.com/repos/mantidproject/mslice/pulls/comments/82578200"},"html":{"href":"https://github.com/mantidproject/mslice/pull/93#discussion_r82578200"},"pull_request":{"href":"https://api.github.com/repos/mantidproject/mslice/pulls/93"}}},"pull_request":{"url":"https://api.github.com/repos/mantidproject/mslice/pulls/93","id":87581024,"html_url":"https://github.com/mantidproject/mslice/pull/93","diff_url":"https://github.com/mantidproject/mslice/pull/93.diff","patch_url":"https://github.com/mantidproject/mslice/pull/93.patch","issue_url":"https://api.github.com/repos/mantidproject/mslice/issues/93","number":93,"state":"open","locked":false,"title":"Implement wavenumber conversion","user":{"login":"mducle","id":14106963,"avatar_url":"https://avatars.githubusercontent.com/u/14106963?v=3","gravatar_id":"","url":"https://api.github.com/users/mducle","html_url":"https://github.com/mducle","followers_url":"https://api.github.com/users/mducle/followers","following_url":"https://api.github.com/users/mducle/following{/other_user}","gists_url":"https://api.github.com/users/mducle/gists{/gist_id}","starred_url":"https://api.github.com/users/mducle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mducle/subscriptions","organizations_url":"https://api.github.com/users/mducle/orgs","repos_url":"https://api.github.com/users/mducle/repos","events_url":"https://api.github.com/users/mducle/events{/privacy}","received_events_url":"https://api.github.com/users/mducle/received_events","type":"User","site_admin":false},"body":"Added wavenumbers `cm-1` as a possible energy unit. \r\n\r\n**To test:**\r\n\r\nLoad a dataset and select `cm-1` from the `units` combo box, and calculate projection. Check that the resulting MD workspace has energy which is scaled by 8.066 compared to the MD workspace created with `units=meV`. The new workspaces should have a `_cm` suffix.\r\n\r\nFixes #63.\r\n\r\n","created_at":"2016-09-30T23:27:49Z","updated_at":"2016-10-10T10:28:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4091eeb842366d05d94b79bd6a29996482c3354c","assignee":{"login":"martyngigg","id":733773,"avatar_url":"https://avatars.githubusercontent.com/u/733773?v=3","gravatar_id":"","url":"https://api.github.com/users/martyngigg","html_url":"https://github.com/martyngigg","followers_url":"https://api.github.com/users/martyngigg/followers","following_url":"https://api.github.com/users/martyngigg/following{/other_user}","gists_url":"https://api.github.com/users/martyngigg/gists{/gist_id}","starred_url":"https://api.github.com/users/martyngigg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martyngigg/subscriptions","organizations_url":"https://api.github.com/users/martyngigg/orgs","repos_url":"https://api.github.com/users/martyngigg/repos","events_url":"https://api.github.com/users/martyngigg/events{/privacy}","received_events_url":"https://api.github.com/users/martyngigg/received_events","type":"User","site_admin":false},"assignees":[{"login":"martyngigg","id":733773,"avatar_url":"https://avatars.githubusercontent.com/u/733773?v=3","gravatar_id":"","url":"https://api.github.com/users/martyngigg","html_url":"https://github.com/martyngigg","followers_url":"https://api.github.com/users/martyngigg/followers","following_url":"https://api.github.com/users/martyngigg/following{/other_user}","gists_url":"https://api.github.com/users/martyngigg/gists{/gist_id}","starred_url":"https://api.github.com/users/martyngigg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martyngigg/subscriptions","organizations_url":"https://api.github.com/users/martyngigg/orgs","repos_url":"https://api.github.com/users/martyngigg/repos","events_url":"https://api.github.com/users/martyngigg/events{/privacy}","received_events_url":"https://api.github.com/users/martyngigg/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/mantidproject/mslice/pulls/93/commits","review_comments_url":"https://api.github.com/repos/mantidproject/mslice/pulls/93/comments","review_comment_url":"https://api.github.com/repos/mantidproject/mslice/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mantidproject/mslice/issues/93/comments","statuses_url":"https://api.github.com/repos/mantidproject/mslice/statuses/a40c8b2836c014a5be01a37e8ef5755827911343","head":{"label":"mantidproject:63_energy_units","ref":"63_energy_units","sha":"a40c8b2836c014a5be01a37e8ef5755827911343","user":{"login":"mantidproject","id":671496,"avatar_url":"https://avatars.githubusercontent.com/u/671496?v=3","gravatar_id":"","url":"https://api.github.com/users/mantidproject","html_url":"https://github.com/mantidproject","followers_url":"https://api.github.com/users/mantidproject/followers","following_url":"https://api.github.com/users/mantidproject/following{/other_user}","gists_url":"https://api.github.com/users/mantidproject/gists{/gist_id}","starred_url":"https://api.github.com/users/mantidproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mantidproject/subscriptions","organizations_url":"https://api.github.com/users/mantidproject/orgs","repos_url":"https://api.github.com/users/mantidproject/repos","events_url":"https://api.github.com/users/mantidproject/events{/privacy}","received_events_url":"https://api.github.com/users/mantidproject/received_events","type":"Organization","site_admin":false},"repo":{"id":63767305,"name":"mslice","full_name":"mantidproject/mslice","owner":{"login":"mantidproject","id":671496,"avatar_url":"https://avatars.githubusercontent.com/u/671496?v=3","gravatar_id":"","url":"https://api.github.com/users/mantidproject","html_url":"https://github.com/mantidproject","followers_url":"https://api.github.com/users/mantidproject/followers","following_url":"https://api.github.com/users/mantidproject/following{/other_user}","gists_url":"https://api.github.com/users/mantidproject/gists{/gist_id}","starred_url":"https://api.github.com/users/mantidproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mantidproject/subscriptions","organizations_url":"https://api.github.com/users/mantidproject/orgs","repos_url":"https://api.github.com/users/mantidproject/repos","events_url":"https://api.github.com/users/mantidproject/events{/privacy}","received_events_url":"https://api.github.com/users/mantidproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mantidproject/mslice","description":"Source code for Mantid MSlice","fork":false,"url":"https://api.github.com/repos/mantidproject/mslice","forks_url":"https://api.github.com/repos/mantidproject/mslice/forks","keys_url":"https://api.github.com/repos/mantidproject/mslice/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mantidproject/mslice/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mantidproject/mslice/teams","hooks_url":"https://api.github.com/repos/mantidproject/mslice/hooks","issue_events_url":"https://api.github.com/repos/mantidproject/mslice/issues/events{/number}","events_url":"https://api.github.com/repos/mantidproject/mslice/events","assignees_url":"https://api.github.com/repos/mantidproject/mslice/assignees{/user}","branches_url":"https://api.github.com/repos/mantidproject/mslice/branches{/branch}","tags_url":"https://api.github.com/repos/mantidproject/mslice/tags","blobs_url":"https://api.github.com/repos/mantidproject/mslice/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mantidproject/mslice/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mantidproject/mslice/git/refs{/sha}","trees_url":"https://api.github.com/repos/mantidproject/mslice/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mantidproject/mslice/statuses/{sha}","languages_url":"https://api.github.com/repos/mantidproject/mslice/languages","stargazers_url":"https://api.github.com/repos/mantidproject/mslice/stargazers","contributors_url":"https://api.github.com/repos/mantidproject/mslice/contributors","subscribers_url":"https://api.github.com/repos/mantidproject/mslice/subscribers","subscription_url":"https://api.github.com/repos/mantidproject/mslice/subscription","commits_url":"https://api.github.com/repos/mantidproject/mslice/commits{/sha}","git_commits_url":"https://api.github.com/repos/mantidproject/mslice/git/commits{/sha}","comments_url":"https://api.github.com/repos/mantidproject/mslice/comments{/number}","issue_comment_url":"https://api.github.com/repos/mantidproject/mslice/issues/comments{/number}","contents_url":"https://api.github.com/repos/mantidproject/mslice/contents/{+path}","compare_url":"https://api.github.com/repos/mantidproject/mslice/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mantidproject/mslice/merges","archive_url":"https://api.github.com/repos/mantidproject/mslice/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mantidproject/mslice/downloads","issues_url":"https://api.github.com/repos/mantidproject/mslice/issues{/number}","pulls_url":"https://api.github.com/repos/mantidproject/mslice/pulls{/number}","milestones_url":"https://api.github.com/repos/mantidproject/mslice/milestones{/number}","notifications_url":"https://api.github.com/repos/mantidproject/mslice/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mantidproject/mslice/labels{/name}","releases_url":"https://api.github.com/repos/mantidproject/mslice/releases{/id}","deployments_url":"https://api.github.com/repos/mantidproject/mslice/deployments","created_at":"2016-07-20T09:10:10Z","updated_at":"2016-09-20T06:29:07Z","pushed_at":"2016-10-10T10:02:33Z","git_url":"git://github.com/mantidproject/mslice.git","ssh_url":"git@github.com:mantidproject/mslice.git","clone_url":"https://github.com/mantidproject/mslice.git","svn_url":"https://github.com/mantidproject/mslice","homepage":"","size":1527,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":30,"forks":1,"open_issues":30,"watchers":0,"default_branch":"master"}},"base":{"label":"mantidproject:master","ref":"master","sha":"73f8f4d3a98b79168cd8190a86cb98161551dab3","user":{"login":"mantidproject","id":671496,"avatar_url":"https://avatars.githubusercontent.com/u/671496?v=3","gravatar_id":"","url":"https://api.github.com/users/mantidproject","html_url":"https://github.com/mantidproject","followers_url":"https://api.github.com/users/mantidproject/followers","following_url":"https://api.github.com/users/mantidproject/following{/other_user}","gists_url":"https://api.github.com/users/mantidproject/gists{/gist_id}","starred_url":"https://api.github.com/users/mantidproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mantidproject/subscriptions","organizations_url":"https://api.github.com/users/mantidproject/orgs","repos_url":"https://api.github.com/users/mantidproject/repos","events_url":"https://api.github.com/users/mantidproject/events{/privacy}","received_events_url":"https://api.github.com/users/mantidproject/received_events","type":"Organization","site_admin":false},"repo":{"id":63767305,"name":"mslice","full_name":"mantidproject/mslice","owner":{"login":"mantidproject","id":671496,"avatar_url":"https://avatars.githubusercontent.com/u/671496?v=3","gravatar_id":"","url":"https://api.github.com/users/mantidproject","html_url":"https://github.com/mantidproject","followers_url":"https://api.github.com/users/mantidproject/followers","following_url":"https://api.github.com/users/mantidproject/following{/other_user}","gists_url":"https://api.github.com/users/mantidproject/gists{/gist_id}","starred_url":"https://api.github.com/users/mantidproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mantidproject/subscriptions","organizations_url":"https://api.github.com/users/mantidproject/orgs","repos_url":"https://api.github.com/users/mantidproject/repos","events_url":"https://api.github.com/users/mantidproject/events{/privacy}","received_events_url":"https://api.github.com/users/mantidproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mantidproject/mslice","description":"Source code for Mantid MSlice","fork":false,"url":"https://api.github.com/repos/mantidproject/mslice","forks_url":"https://api.github.com/repos/mantidproject/mslice/forks","keys_url":"https://api.github.com/repos/mantidproject/mslice/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mantidproject/mslice/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mantidproject/mslice/teams","hooks_url":"https://api.github.com/repos/mantidproject/mslice/hooks","issue_events_url":"https://api.github.com/repos/mantidproject/mslice/issues/events{/number}","events_url":"https://api.github.com/repos/mantidproject/mslice/events","assignees_url":"https://api.github.com/repos/mantidproject/mslice/assignees{/user}","branches_url":"https://api.github.com/repos/mantidproject/mslice/branches{/branch}","tags_url":"https://api.github.com/repos/mantidproject/mslice/tags","blobs_url":"https://api.github.com/repos/mantidproject/mslice/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mantidproject/mslice/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mantidproject/mslice/git/refs{/sha}","trees_url":"https://api.github.com/repos/mantidproject/mslice/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mantidproject/mslice/statuses/{sha}","languages_url":"https://api.github.com/repos/mantidproject/mslice/languages","stargazers_url":"https://api.github.com/repos/mantidproject/mslice/stargazers","contributors_url":"https://api.github.com/repos/mantidproject/mslice/contributors","subscribers_url":"https://api.github.com/repos/mantidproject/mslice/subscribers","subscription_url":"https://api.github.com/repos/mantidproject/mslice/subscription","commits_url":"https://api.github.com/repos/mantidproject/mslice/commits{/sha}","git_commits_url":"https://api.github.com/repos/mantidproject/mslice/git/commits{/sha}","comments_url":"https://api.github.com/repos/mantidproject/mslice/comments{/number}","issue_comment_url":"https://api.github.com/repos/mantidproject/mslice/issues/comments{/number}","contents_url":"https://api.github.com/repos/mantidproject/mslice/contents/{+path}","compare_url":"https://api.github.com/repos/mantidproject/mslice/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mantidproject/mslice/merges","archive_url":"https://api.github.com/repos/mantidproject/mslice/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mantidproject/mslice/downloads","issues_url":"https://api.github.com/repos/mantidproject/mslice/issues{/number}","pulls_url":"https://api.github.com/repos/mantidproject/mslice/pulls{/number}","milestones_url":"https://api.github.com/repos/mantidproject/mslice/milestones{/number}","notifications_url":"https://api.github.com/repos/mantidproject/mslice/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mantidproject/mslice/labels{/name}","releases_url":"https://api.github.com/repos/mantidproject/mslice/releases{/id}","deployments_url":"https://api.github.com/repos/mantidproject/mslice/deployments","created_at":"2016-07-20T09:10:10Z","updated_at":"2016-09-20T06:29:07Z","pushed_at":"2016-10-10T10:02:33Z","git_url":"git://github.com/mantidproject/mslice.git","ssh_url":"git@github.com:mantidproject/mslice.git","clone_url":"https://github.com/mantidproject/mslice.git","svn_url":"https://github.com/mantidproject/mslice","homepage":"","size":1527,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":30,"forks":1,"open_issues":30,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mantidproject/mslice/pulls/93"},"html":{"href":"https://github.com/mantidproject/mslice/pull/93"},"issue":{"href":"https://api.github.com/repos/mantidproject/mslice/issues/93"},"comments":{"href":"https://api.github.com/repos/mantidproject/mslice/issues/93/comments"},"review_comments":{"href":"https://api.github.com/repos/mantidproject/mslice/pulls/93/comments"},"review_comment":{"href":"https://api.github.com/repos/mantidproject/mslice/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mantidproject/mslice/pulls/93/commits"},"statuses":{"href":"https://api.github.com/repos/mantidproject/mslice/statuses/a40c8b2836c014a5be01a37e8ef5755827911343"}}}}
{"actor":{"display_login":"mducle"}}