{"action":"created","comment":{"url":"https://api.github.com/repos/emberjs/ember.js/pulls/comments/60126908","id":60126908,"diff_hunk":"@@ -692,9 +694,13 @@ Registry.prototype = {\n     return assign({}, fallbackKnown, localKnown, resolverKnown);\n   },\n \n-  validateFullName(fullName) {\n+  validateFullName(fullName, tolerant) {","path":"packages/container/lib/registry.js","position":25,"original_position":25,"commit_id":"4d83c9b49615ba727261249e1d29f2aacda700f2","original_commit_id":"4d83c9b49615ba727261249e1d29f2aacda700f2","user":{"login":"dgeb","id":29122,"avatar_url":"https://avatars.githubusercontent.com/u/29122?v=3","gravatar_id":"","url":"https://api.github.com/users/dgeb","html_url":"https://github.com/dgeb","followers_url":"https://api.github.com/users/dgeb/followers","following_url":"https://api.github.com/users/dgeb/following{/other_user}","gists_url":"https://api.github.com/users/dgeb/gists{/gist_id}","starred_url":"https://api.github.com/users/dgeb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgeb/subscriptions","organizations_url":"https://api.github.com/users/dgeb/orgs","repos_url":"https://api.github.com/users/dgeb/repos","events_url":"https://api.github.com/users/dgeb/events{/privacy}","received_events_url":"https://api.github.com/users/dgeb/received_events","type":"User","site_admin":false},"body":"How about this alternative: \r\n\r\n* Create a new method `isValidFullName` that returns a boolean and never throws. \r\n* `validateFullName` could internally call `isValidFullName`, as could `has`.\r\n* `validateFullName` could continue to throw.\r\n\r\nI think this works because `validateFullName` sounds imperative and I would expect it to throw, plus the `tolerant` param seems a bit iffy.\r\n","created_at":"2016-04-18T20:19:43Z","updated_at":"2016-04-18T20:19:43Z","html_url":"https://github.com/emberjs/ember.js/pull/13356#discussion_r60126908","pull_request_url":"https://api.github.com/repos/emberjs/ember.js/pulls/13356","_links":{"self":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/comments/60126908"},"html":{"href":"https://github.com/emberjs/ember.js/pull/13356#discussion_r60126908"},"pull_request":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/13356"}}},"pull_request":{"url":"https://api.github.com/repos/emberjs/ember.js/pulls/13356","id":66869492,"html_url":"https://github.com/emberjs/ember.js/pull/13356","diff_url":"https://github.com/emberjs/ember.js/pull/13356.diff","patch_url":"https://github.com/emberjs/ember.js/pull/13356.patch","issue_url":"https://api.github.com/repos/emberjs/ember.js/issues/13356","number":13356,"state":"open","locked":false,"title":"[BUGFIX beta] Update Registry#has to always return true/false.","user":{"login":"rwjblue","id":12637,"avatar_url":"https://avatars.githubusercontent.com/u/12637?v=3","gravatar_id":"","url":"https://api.github.com/users/rwjblue","html_url":"https://github.com/rwjblue","followers_url":"https://api.github.com/users/rwjblue/followers","following_url":"https://api.github.com/users/rwjblue/following{/other_user}","gists_url":"https://api.github.com/users/rwjblue/gists{/gist_id}","starred_url":"https://api.github.com/users/rwjblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwjblue/subscriptions","organizations_url":"https://api.github.com/users/rwjblue/orgs","repos_url":"https://api.github.com/users/rwjblue/repos","events_url":"https://api.github.com/users/rwjblue/events{/privacy}","received_events_url":"https://api.github.com/users/rwjblue/received_events","type":"User","site_admin":false},"body":"Fixes #12082.","created_at":"2016-04-18T15:07:39Z","updated_at":"2016-04-18T20:19:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9553b153a13f31713fd5e9ac8f1139e79597e833","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/emberjs/ember.js/pulls/13356/commits","review_comments_url":"https://api.github.com/repos/emberjs/ember.js/pulls/13356/comments","review_comment_url":"https://api.github.com/repos/emberjs/ember.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/emberjs/ember.js/issues/13356/comments","statuses_url":"https://api.github.com/repos/emberjs/ember.js/statuses/4d83c9b49615ba727261249e1d29f2aacda700f2","head":{"label":"rwjblue:beef-up-regexp","ref":"beef-up-regexp","sha":"4d83c9b49615ba727261249e1d29f2aacda700f2","user":{"login":"rwjblue","id":12637,"avatar_url":"https://avatars.githubusercontent.com/u/12637?v=3","gravatar_id":"","url":"https://api.github.com/users/rwjblue","html_url":"https://github.com/rwjblue","followers_url":"https://api.github.com/users/rwjblue/followers","following_url":"https://api.github.com/users/rwjblue/following{/other_user}","gists_url":"https://api.github.com/users/rwjblue/gists{/gist_id}","starred_url":"https://api.github.com/users/rwjblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwjblue/subscriptions","organizations_url":"https://api.github.com/users/rwjblue/orgs","repos_url":"https://api.github.com/users/rwjblue/repos","events_url":"https://api.github.com/users/rwjblue/events{/privacy}","received_events_url":"https://api.github.com/users/rwjblue/received_events","type":"User","site_admin":false},"repo":{"id":12009595,"name":"ember.js","full_name":"rwjblue/ember.js","owner":{"login":"rwjblue","id":12637,"avatar_url":"https://avatars.githubusercontent.com/u/12637?v=3","gravatar_id":"","url":"https://api.github.com/users/rwjblue","html_url":"https://github.com/rwjblue","followers_url":"https://api.github.com/users/rwjblue/followers","following_url":"https://api.github.com/users/rwjblue/following{/other_user}","gists_url":"https://api.github.com/users/rwjblue/gists{/gist_id}","starred_url":"https://api.github.com/users/rwjblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwjblue/subscriptions","organizations_url":"https://api.github.com/users/rwjblue/orgs","repos_url":"https://api.github.com/users/rwjblue/repos","events_url":"https://api.github.com/users/rwjblue/events{/privacy}","received_events_url":"https://api.github.com/users/rwjblue/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rwjblue/ember.js","description":"Ember.js - A JavaScript framework for creating ambitious web applications","fork":true,"url":"https://api.github.com/repos/rwjblue/ember.js","forks_url":"https://api.github.com/repos/rwjblue/ember.js/forks","keys_url":"https://api.github.com/repos/rwjblue/ember.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rwjblue/ember.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rwjblue/ember.js/teams","hooks_url":"https://api.github.com/repos/rwjblue/ember.js/hooks","issue_events_url":"https://api.github.com/repos/rwjblue/ember.js/issues/events{/number}","events_url":"https://api.github.com/repos/rwjblue/ember.js/events","assignees_url":"https://api.github.com/repos/rwjblue/ember.js/assignees{/user}","branches_url":"https://api.github.com/repos/rwjblue/ember.js/branches{/branch}","tags_url":"https://api.github.com/repos/rwjblue/ember.js/tags","blobs_url":"https://api.github.com/repos/rwjblue/ember.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rwjblue/ember.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rwjblue/ember.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/rwjblue/ember.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rwjblue/ember.js/statuses/{sha}","languages_url":"https://api.github.com/repos/rwjblue/ember.js/languages","stargazers_url":"https://api.github.com/repos/rwjblue/ember.js/stargazers","contributors_url":"https://api.github.com/repos/rwjblue/ember.js/contributors","subscribers_url":"https://api.github.com/repos/rwjblue/ember.js/subscribers","subscription_url":"https://api.github.com/repos/rwjblue/ember.js/subscription","commits_url":"https://api.github.com/repos/rwjblue/ember.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/rwjblue/ember.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/rwjblue/ember.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/rwjblue/ember.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/rwjblue/ember.js/contents/{+path}","compare_url":"https://api.github.com/repos/rwjblue/ember.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rwjblue/ember.js/merges","archive_url":"https://api.github.com/repos/rwjblue/ember.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rwjblue/ember.js/downloads","issues_url":"https://api.github.com/repos/rwjblue/ember.js/issues{/number}","pulls_url":"https://api.github.com/repos/rwjblue/ember.js/pulls{/number}","milestones_url":"https://api.github.com/repos/rwjblue/ember.js/milestones{/number}","notifications_url":"https://api.github.com/repos/rwjblue/ember.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rwjblue/ember.js/labels{/name}","releases_url":"https://api.github.com/repos/rwjblue/ember.js/releases{/id}","deployments_url":"https://api.github.com/repos/rwjblue/ember.js/deployments","created_at":"2013-08-09T20:05:11Z","updated_at":"2014-07-18T12:44:07Z","pushed_at":"2016-04-18T17:03:38Z","git_url":"git://github.com/rwjblue/ember.js.git","ssh_url":"git@github.com:rwjblue/ember.js.git","clone_url":"https://github.com/rwjblue/ember.js.git","svn_url":"https://github.com/rwjblue/ember.js","homepage":"http://www.emberjs.com","size":28748,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"emberjs:master","ref":"master","sha":"fe04b2f3e1353cfc5819555d453a256729fc6feb","user":{"login":"emberjs","id":1253363,"avatar_url":"https://avatars.githubusercontent.com/u/1253363?v=3","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"repo":{"id":1801829,"name":"ember.js","full_name":"emberjs/ember.js","owner":{"login":"emberjs","id":1253363,"avatar_url":"https://avatars.githubusercontent.com/u/1253363?v=3","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/emberjs/ember.js","description":"Ember.js - A JavaScript framework for creating ambitious web applications","fork":false,"url":"https://api.github.com/repos/emberjs/ember.js","forks_url":"https://api.github.com/repos/emberjs/ember.js/forks","keys_url":"https://api.github.com/repos/emberjs/ember.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emberjs/ember.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emberjs/ember.js/teams","hooks_url":"https://api.github.com/repos/emberjs/ember.js/hooks","issue_events_url":"https://api.github.com/repos/emberjs/ember.js/issues/events{/number}","events_url":"https://api.github.com/repos/emberjs/ember.js/events","assignees_url":"https://api.github.com/repos/emberjs/ember.js/assignees{/user}","branches_url":"https://api.github.com/repos/emberjs/ember.js/branches{/branch}","tags_url":"https://api.github.com/repos/emberjs/ember.js/tags","blobs_url":"https://api.github.com/repos/emberjs/ember.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emberjs/ember.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emberjs/ember.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/emberjs/ember.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emberjs/ember.js/statuses/{sha}","languages_url":"https://api.github.com/repos/emberjs/ember.js/languages","stargazers_url":"https://api.github.com/repos/emberjs/ember.js/stargazers","contributors_url":"https://api.github.com/repos/emberjs/ember.js/contributors","subscribers_url":"https://api.github.com/repos/emberjs/ember.js/subscribers","subscription_url":"https://api.github.com/repos/emberjs/ember.js/subscription","commits_url":"https://api.github.com/repos/emberjs/ember.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/emberjs/ember.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/emberjs/ember.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/emberjs/ember.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/emberjs/ember.js/contents/{+path}","compare_url":"https://api.github.com/repos/emberjs/ember.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emberjs/ember.js/merges","archive_url":"https://api.github.com/repos/emberjs/ember.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emberjs/ember.js/downloads","issues_url":"https://api.github.com/repos/emberjs/ember.js/issues{/number}","pulls_url":"https://api.github.com/repos/emberjs/ember.js/pulls{/number}","milestones_url":"https://api.github.com/repos/emberjs/ember.js/milestones{/number}","notifications_url":"https://api.github.com/repos/emberjs/ember.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emberjs/ember.js/labels{/name}","releases_url":"https://api.github.com/repos/emberjs/ember.js/releases{/id}","deployments_url":"https://api.github.com/repos/emberjs/ember.js/deployments","created_at":"2011-05-25T23:39:40Z","updated_at":"2016-04-18T16:49:04Z","pushed_at":"2016-04-18T20:02:57Z","git_url":"git://github.com/emberjs/ember.js.git","ssh_url":"git@github.com:emberjs/ember.js.git","clone_url":"https://github.com/emberjs/ember.js.git","svn_url":"https://github.com/emberjs/ember.js","homepage":"http://www.emberjs.com","size":67113,"stargazers_count":16081,"watchers_count":16081,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3457,"mirror_url":null,"open_issues_count":309,"forks":3457,"open_issues":309,"watchers":16081,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/13356"},"html":{"href":"https://github.com/emberjs/ember.js/pull/13356"},"issue":{"href":"https://api.github.com/repos/emberjs/ember.js/issues/13356"},"comments":{"href":"https://api.github.com/repos/emberjs/ember.js/issues/13356/comments"},"review_comments":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/13356/comments"},"review_comment":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/13356/commits"},"statuses":{"href":"https://api.github.com/repos/emberjs/ember.js/statuses/4d83c9b49615ba727261249e1d29f2aacda700f2"}}}}