{"action":"created","issue":{"url":"https://api.github.com/repos/silklabs/silk/issues/4","repository_url":"https://api.github.com/repos/silklabs/silk","labels_url":"https://api.github.com/repos/silklabs/silk/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/silklabs/silk/issues/4/comments","events_url":"https://api.github.com/repos/silklabs/silk/issues/4/events","html_url":"https://github.com/silklabs/silk/pull/4","id":159835965,"number":4,"title":"initial commit to enable Victara support","user":{"login":"angelpipe","id":1757966,"avatar_url":"https://avatars.githubusercontent.com/u/1757966?v=3","gravatar_id":"","url":"https://api.github.com/users/angelpipe","html_url":"https://github.com/angelpipe","followers_url":"https://api.github.com/users/angelpipe/followers","following_url":"https://api.github.com/users/angelpipe/following{/other_user}","gists_url":"https://api.github.com/users/angelpipe/gists{/gist_id}","starred_url":"https://api.github.com/users/angelpipe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angelpipe/subscriptions","organizations_url":"https://api.github.com/users/angelpipe/orgs","repos_url":"https://api.github.com/users/angelpipe/repos","events_url":"https://api.github.com/users/angelpipe/events{/privacy}","received_events_url":"https://api.github.com/users/angelpipe/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":15,"created_at":"2016-06-12T16:37:49Z","updated_at":"2016-06-19T04:56:42Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/silklabs/silk/pulls/4","html_url":"https://github.com/silklabs/silk/pull/4","diff_url":"https://github.com/silklabs/silk/pull/4.diff","patch_url":"https://github.com/silklabs/silk/pull/4.patch"},"body":"Hey,\r\nI'm intending to enable Victara(Moto X 2nd generation) support. I have given some steps but i want to make sure I'm pointing in the right direction, and I still have some doubts. Please forgive me if i do very basic questions (I didn't know anything about AOSP building a week ago).\r\n\r\n## The approach\r\n\r\nI want to use the most i can from AOSP because porting is easier as your current patches are written for it and mako board is a good starting point. Taking that in account, I'm using the same android-5.1.1_r1.xml file in my custom victara.xml. After that, I'm adding Cyanogen Mod's Victara repo into /device/motorola/victara; and finally, I add motorola vendor files into /vendor/motorola. Am I crazy or this should be enough to get an almost pure AOSP build for the device?. I hope I'm on the right path, you can check the details of this in the victara.xml file.\r\n\r\n## Patches\r\n\r\nAs i used the same AOSP version you're using for mako, i guess the only patches that i need to review are the device ones (is that assumption ok?). I found 5 patches that are candidates to be ported to victara's build. I have rewritten some and i have doubts in others, so i will give a status for each one of them.\r\n\r\n* **0001-Add-silk-product.patch** *PORTED*\r\nThis patch is currently ported in this branch. If you find a problem about it, feel free to point it out.\r\n\r\n* **0001-Don-t-enable-MTP-by-default.patch** *NOT PORTED*\r\nI haven't found any reference on CM's code where *persist.sys.usb.config's* value is set to mtp. Does it mean this patch is not necessary?. The file where the var is referenced is https://github.com/CyanogenMod/android_device_motorola_victara/blob/cm-12.1/rootdir/etc/init.mmi.usb.sh\r\n\r\n* **0001-Enable-firmware-to-mount-with-SELinux-disabled.patch** *NOT PORTED*\r\nIn the fstab file from CM(https://github.com/CyanogenMod/android_device_motorola_victara/blob/cm-12.1/rootdir/etc/fstab.qcom), the /dev/block/platform/msm_sdcc.1/by-name/modem and /dev/block/platform/msm_sdcc.1/by-name/persist volumes are not listed so it is not possible to apply the change for the modem one. Should I add those volumes? could it affect the build?.\r\n\r\n* **0001-Keep-2-cores-online-at-1.2ghz-to-stay-cool.patch** *NOT PORTED*\r\nI have a big question here, Does Silk use only 2 underclocked cores all the time?. Besides that, i think this is the trickiest patch because this kind of configuration for mako is done only in *init.mako.rc*; but in CM it is done in two files https://github.com/CyanogenMod/android_device_motorola_victara/blob/cm-12.1/rootdir/etc/init.target.rc and https://github.com/CyanogenMod/android_device_motorola_victara/blob/cm-12.1/rootdir/etc/init.qcom.rc. I don't know in which one of those should I set the patch, my guess is *init.qcom.rc* as it includes *init.target.rc*. The other thing is I'm wondering if this patch is really necessary because CM does a lot of cpu settings in these files (could this patch as it is on mako cause conflicts with current CM settings?).\r\n\r\n* **0001-sdcard-remove-derived-permissions.patch** *PORTED*\r\nThis patch is currently ported in this branch. If you find a problem about it, feel free to point it out.\r\n\r\nThank you so much for reading this long text!\r\n\r\nBest Regards."},"comment":{"url":"https://api.github.com/repos/silklabs/silk/issues/comments/226979604","html_url":"https://github.com/silklabs/silk/pull/4#issuecomment-226979604","issue_url":"https://api.github.com/repos/silklabs/silk/issues/4","id":226979604,"user":{"login":"angelpipe","id":1757966,"avatar_url":"https://avatars.githubusercontent.com/u/1757966?v=3","gravatar_id":"","url":"https://api.github.com/users/angelpipe","html_url":"https://github.com/angelpipe","followers_url":"https://api.github.com/users/angelpipe/followers","following_url":"https://api.github.com/users/angelpipe/following{/other_user}","gists_url":"https://api.github.com/users/angelpipe/gists{/gist_id}","starred_url":"https://api.github.com/users/angelpipe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angelpipe/subscriptions","organizations_url":"https://api.github.com/users/angelpipe/orgs","repos_url":"https://api.github.com/users/angelpipe/repos","events_url":"https://api.github.com/users/angelpipe/events{/privacy}","received_events_url":"https://api.github.com/users/angelpipe/received_events","type":"User","site_admin":false},"created_at":"2016-06-19T04:56:42Z","updated_at":"2016-06-19T04:56:42Z","body":"The file already had that parameter :("}}
{"actor":{"display_login":"angelpipe"}}