{"action":"created","issue":{"url":"https://api.github.com/repos/Automattic/wp-calypso/issues/5550","repository_url":"https://api.github.com/repos/Automattic/wp-calypso","labels_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/5550/labels{/name}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/5550/comments","events_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/5550/events","html_url":"https://github.com/Automattic/wp-calypso/pull/5550","id":156482930,"number":5550,"title":"WebPreview: Allow externalUrl to be set for the external link button","user":{"login":"ehg","id":215074,"avatar_url":"https://avatars.githubusercontent.com/u/215074?v=3","gravatar_id":"","url":"https://api.github.com/users/ehg","html_url":"https://github.com/ehg","followers_url":"https://api.github.com/users/ehg/followers","following_url":"https://api.github.com/users/ehg/following{/other_user}","gists_url":"https://api.github.com/users/ehg/gists{/gist_id}","starred_url":"https://api.github.com/users/ehg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ehg/subscriptions","organizations_url":"https://api.github.com/users/ehg/orgs","repos_url":"https://api.github.com/users/ehg/repos","events_url":"https://api.github.com/users/ehg/events{/privacy}","received_events_url":"https://api.github.com/users/ehg/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Automattic/wp-calypso/labels/Editor","name":"Editor","color":"006b75"},{"url":"https://api.github.com/repos/Automattic/wp-calypso/labels/Framework","name":"Framework","color":"006b75"},{"url":"https://api.github.com/repos/Automattic/wp-calypso/labels/GuidedTours","name":"GuidedTours","color":"006b75"},{"url":"https://api.github.com/repos/Automattic/wp-calypso/labels/[Status]%20Needs%20Review","name":"[Status] Needs Review","color":"fbca04"}],"state":"open","locked":false,"assignee":{"login":"ehg","id":215074,"avatar_url":"https://avatars.githubusercontent.com/u/215074?v=3","gravatar_id":"","url":"https://api.github.com/users/ehg","html_url":"https://github.com/ehg","followers_url":"https://api.github.com/users/ehg/followers","following_url":"https://api.github.com/users/ehg/following{/other_user}","gists_url":"https://api.github.com/users/ehg/gists{/gist_id}","starred_url":"https://api.github.com/users/ehg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ehg/subscriptions","organizations_url":"https://api.github.com/users/ehg/orgs","repos_url":"https://api.github.com/users/ehg/repos","events_url":"https://api.github.com/users/ehg/events{/privacy}","received_events_url":"https://api.github.com/users/ehg/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/Automattic/wp-calypso/milestones/83","html_url":"https://github.com/Automattic/wp-calypso/milestones/GuidedTours%20M2:%20Preview%20&%20Polish","labels_url":"https://api.github.com/repos/Automattic/wp-calypso/milestones/83/labels","id":1738161,"number":83,"title":"GuidedTours M2: Preview & Polish","description":"","creator":{"login":"lsinger","id":23619,"avatar_url":"https://avatars.githubusercontent.com/u/23619?v=3","gravatar_id":"","url":"https://api.github.com/users/lsinger","html_url":"https://github.com/lsinger","followers_url":"https://api.github.com/users/lsinger/followers","following_url":"https://api.github.com/users/lsinger/following{/other_user}","gists_url":"https://api.github.com/users/lsinger/gists{/gist_id}","starred_url":"https://api.github.com/users/lsinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsinger/subscriptions","organizations_url":"https://api.github.com/users/lsinger/orgs","repos_url":"https://api.github.com/users/lsinger/repos","events_url":"https://api.github.com/users/lsinger/events{/privacy}","received_events_url":"https://api.github.com/users/lsinger/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":6,"state":"open","created_at":"2016-04-29T09:23:31Z","updated_at":"2016-05-25T11:05:37Z","due_on":null,"closed_at":null},"comments":2,"created_at":"2016-05-24T11:23:22Z","updated_at":"2016-05-26T12:18:47Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/5550","html_url":"https://github.com/Automattic/wp-calypso/pull/5550","diff_url":"https://github.com/Automattic/wp-calypso/pull/5550.diff","patch_url":"https://github.com/Automattic/wp-calypso/pull/5550.patch"},"body":"When previewing a post or site, the external link shouldn't contain iframe specific qargs, which trigger ifrarme specific behaviour (no masterbar, rewritten links). Let's specify an `externalUrl` instead. This will also help with copy and pasted links not containing ugly qargs.\r\n\r\n![screen shot 2016-05-25 at 17 03 49](https://cloud.githubusercontent.com/assets/215074/15547196/b1189a42-229a-11e6-9407-d12606b6a340.png)\r\n\r\n\r\n- Modify the `EditorPreview` & `DesignPreview` accordingly\r\n\r\nTo test:\r\n\r\n1. Edit/add a new post/page.\r\n2. Open the preview\r\n3. Check the external link is void of any iframe args (`p` is fine, and expected)\r\n4. Click the site card\r\n5. Check the link qargs again."},"comment":{"url":"https://api.github.com/repos/Automattic/wp-calypso/issues/comments/221855231","html_url":"https://github.com/Automattic/wp-calypso/pull/5550#issuecomment-221855231","issue_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/5550","id":221855231,"user":{"login":"lsinger","id":23619,"avatar_url":"https://avatars.githubusercontent.com/u/23619?v=3","gravatar_id":"","url":"https://api.github.com/users/lsinger","html_url":"https://github.com/lsinger","followers_url":"https://api.github.com/users/lsinger/followers","following_url":"https://api.github.com/users/lsinger/following{/other_user}","gists_url":"https://api.github.com/users/lsinger/gists{/gist_id}","starred_url":"https://api.github.com/users/lsinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsinger/subscriptions","organizations_url":"https://api.github.com/users/lsinger/orgs","repos_url":"https://api.github.com/users/lsinger/repos","events_url":"https://api.github.com/users/lsinger/events{/privacy}","received_events_url":"https://api.github.com/users/lsinger/received_events","type":"User","site_admin":false},"created_at":"2016-05-26T12:18:46Z","updated_at":"2016-05-26T12:18:46Z","body":"LGMT. Squash / prettify commit(s) + :shipit:! 🎉 "}}
{"actor":{"display_login":"lsinger"}}