{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls/comments/93304582","pull_request_review_id":13829464,"id":93304582,"diff_hunk":"@@ -150,7 +150,11 @@ def _bytes_to_json(value):\n def _timestamp_to_json(value):","path":"bigquery/google/cloud/bigquery/_helpers.py","position":13,"original_position":13,"commit_id":"fc4442e7fce69d1be533c3436d6cd254b2256580","original_commit_id":"fc4442e7fce69d1be533c3436d6cd254b2256580","user":{"login":"daspecster","id":192456,"avatar_url":"https://avatars.githubusercontent.com/u/192456?v=3","gravatar_id":"","url":"https://api.github.com/users/daspecster","html_url":"https://github.com/daspecster","followers_url":"https://api.github.com/users/daspecster/followers","following_url":"https://api.github.com/users/daspecster/following{/other_user}","gists_url":"https://api.github.com/users/daspecster/gists{/gist_id}","starred_url":"https://api.github.com/users/daspecster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daspecster/subscriptions","organizations_url":"https://api.github.com/users/daspecster/orgs","repos_url":"https://api.github.com/users/daspecster/repos","events_url":"https://api.github.com/users/daspecster/events{/privacy}","received_events_url":"https://api.github.com/users/daspecster/received_events","type":"User","site_admin":false},"body":"I know this is only used in BigQuery right now, but since it's kind of BigQuery specific, should the method name be something like `_bq_timestamp_to_json`?","created_at":"2016-12-20T19:12:53Z","updated_at":"2016-12-20T19:12:53Z","html_url":"https://github.com/GoogleCloudPlatform/google-cloud-python/pull/2891#discussion_r93304582","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls/2891","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls/comments/93304582"},"html":{"href":"https://github.com/GoogleCloudPlatform/google-cloud-python/pull/2891#discussion_r93304582"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls/2891"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls/2891","id":98806736,"html_url":"https://github.com/GoogleCloudPlatform/google-cloud-python/pull/2891","diff_url":"https://github.com/GoogleCloudPlatform/google-cloud-python/pull/2891.diff","patch_url":"https://github.com/GoogleCloudPlatform/google-cloud-python/pull/2891.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/issues/2891","number":2891,"state":"open","locked":false,"title":"Send TIMESTAMP query parameters as strings.","user":{"login":"tseaver","id":242750,"avatar_url":"https://avatars.githubusercontent.com/u/242750?v=3","gravatar_id":"","url":"https://api.github.com/users/tseaver","html_url":"https://github.com/tseaver","followers_url":"https://api.github.com/users/tseaver/followers","following_url":"https://api.github.com/users/tseaver/following{/other_user}","gists_url":"https://api.github.com/users/tseaver/gists{/gist_id}","starred_url":"https://api.github.com/users/tseaver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tseaver/subscriptions","organizations_url":"https://api.github.com/users/tseaver/orgs","repos_url":"https://api.github.com/users/tseaver/repos","events_url":"https://api.github.com/users/tseaver/events{/privacy}","received_events_url":"https://api.github.com/users/tseaver/received_events","type":"User","site_admin":false},"body":"- *Not* the float-time-since-epoch-in-seconds which Bigquery uses for all other `TIMESTAMP` values. :(\r\n- *Not* RFC3339, but the SQL-mandated format with an embedded space. :(\r\n\r\nCloses: #2886.\r\n\r\n/cc @tswast ","created_at":"2016-12-20T19:05:14Z","updated_at":"2016-12-20T19:12:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"101bce60a3ba9a2c4f36807ed14be24854c425e0","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls/2891/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls/2891/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/issues/2891/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/statuses/fc4442e7fce69d1be533c3436d6cd254b2256580","head":{"label":"tseaver:2886-bigquery-timestamp-query-parm","ref":"2886-bigquery-timestamp-query-parm","sha":"fc4442e7fce69d1be533c3436d6cd254b2256580","user":{"login":"tseaver","id":242750,"avatar_url":"https://avatars.githubusercontent.com/u/242750?v=3","gravatar_id":"","url":"https://api.github.com/users/tseaver","html_url":"https://github.com/tseaver","followers_url":"https://api.github.com/users/tseaver/followers","following_url":"https://api.github.com/users/tseaver/following{/other_user}","gists_url":"https://api.github.com/users/tseaver/gists{/gist_id}","starred_url":"https://api.github.com/users/tseaver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tseaver/subscriptions","organizations_url":"https://api.github.com/users/tseaver/orgs","repos_url":"https://api.github.com/users/tseaver/repos","events_url":"https://api.github.com/users/tseaver/events{/privacy}","received_events_url":"https://api.github.com/users/tseaver/received_events","type":"User","site_admin":false},"repo":{"id":23322104,"name":"google-cloud-python","full_name":"tseaver/google-cloud-python","owner":{"login":"tseaver","id":242750,"avatar_url":"https://avatars.githubusercontent.com/u/242750?v=3","gravatar_id":"","url":"https://api.github.com/users/tseaver","html_url":"https://github.com/tseaver","followers_url":"https://api.github.com/users/tseaver/followers","following_url":"https://api.github.com/users/tseaver/following{/other_user}","gists_url":"https://api.github.com/users/tseaver/gists{/gist_id}","starred_url":"https://api.github.com/users/tseaver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tseaver/subscriptions","organizations_url":"https://api.github.com/users/tseaver/orgs","repos_url":"https://api.github.com/users/tseaver/repos","events_url":"https://api.github.com/users/tseaver/events{/privacy}","received_events_url":"https://api.github.com/users/tseaver/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tseaver/google-cloud-python","description":"Google Cloud Python Client Library","fork":true,"url":"https://api.github.com/repos/tseaver/google-cloud-python","forks_url":"https://api.github.com/repos/tseaver/google-cloud-python/forks","keys_url":"https://api.github.com/repos/tseaver/google-cloud-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tseaver/google-cloud-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tseaver/google-cloud-python/teams","hooks_url":"https://api.github.com/repos/tseaver/google-cloud-python/hooks","issue_events_url":"https://api.github.com/repos/tseaver/google-cloud-python/issues/events{/number}","events_url":"https://api.github.com/repos/tseaver/google-cloud-python/events","assignees_url":"https://api.github.com/repos/tseaver/google-cloud-python/assignees{/user}","branches_url":"https://api.github.com/repos/tseaver/google-cloud-python/branches{/branch}","tags_url":"https://api.github.com/repos/tseaver/google-cloud-python/tags","blobs_url":"https://api.github.com/repos/tseaver/google-cloud-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tseaver/google-cloud-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tseaver/google-cloud-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/tseaver/google-cloud-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tseaver/google-cloud-python/statuses/{sha}","languages_url":"https://api.github.com/repos/tseaver/google-cloud-python/languages","stargazers_url":"https://api.github.com/repos/tseaver/google-cloud-python/stargazers","contributors_url":"https://api.github.com/repos/tseaver/google-cloud-python/contributors","subscribers_url":"https://api.github.com/repos/tseaver/google-cloud-python/subscribers","subscription_url":"https://api.github.com/repos/tseaver/google-cloud-python/subscription","commits_url":"https://api.github.com/repos/tseaver/google-cloud-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/tseaver/google-cloud-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/tseaver/google-cloud-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/tseaver/google-cloud-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/tseaver/google-cloud-python/contents/{+path}","compare_url":"https://api.github.com/repos/tseaver/google-cloud-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tseaver/google-cloud-python/merges","archive_url":"https://api.github.com/repos/tseaver/google-cloud-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tseaver/google-cloud-python/downloads","issues_url":"https://api.github.com/repos/tseaver/google-cloud-python/issues{/number}","pulls_url":"https://api.github.com/repos/tseaver/google-cloud-python/pulls{/number}","milestones_url":"https://api.github.com/repos/tseaver/google-cloud-python/milestones{/number}","notifications_url":"https://api.github.com/repos/tseaver/google-cloud-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tseaver/google-cloud-python/labels{/name}","releases_url":"https://api.github.com/repos/tseaver/google-cloud-python/releases{/id}","deployments_url":"https://api.github.com/repos/tseaver/google-cloud-python/deployments","created_at":"2014-08-25T17:19:33Z","updated_at":"2016-10-25T14:17:09Z","pushed_at":"2016-12-20T19:03:47Z","git_url":"git://github.com/tseaver/google-cloud-python.git","ssh_url":"git@github.com:tseaver/google-cloud-python.git","clone_url":"https://github.com/tseaver/google-cloud-python.git","svn_url":"https://github.com/tseaver/google-cloud-python","homepage":"http://googlecloudplatform.github.io/gcloud-python/","size":19267,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"3d354dc6bdb0e1aede7633a4f6edd2f213e60da6","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":16316451,"name":"google-cloud-python","full_name":"GoogleCloudPlatform/google-cloud-python","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/google-cloud-python","description":"Google Cloud Client Library for Python","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/deployments","created_at":"2014-01-28T15:51:47Z","updated_at":"2016-12-20T08:53:14Z","pushed_at":"2016-12-20T19:05:15Z","git_url":"git://github.com/GoogleCloudPlatform/google-cloud-python.git","ssh_url":"git@github.com:GoogleCloudPlatform/google-cloud-python.git","clone_url":"https://github.com/GoogleCloudPlatform/google-cloud-python.git","svn_url":"https://github.com/GoogleCloudPlatform/google-cloud-python","homepage":"https://googlecloudplatform.github.io/google-cloud-python/","size":108785,"stargazers_count":484,"watchers_count":484,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":249,"mirror_url":null,"open_issues_count":265,"forks":249,"open_issues":265,"watchers":484,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls/2891"},"html":{"href":"https://github.com/GoogleCloudPlatform/google-cloud-python/pull/2891"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/issues/2891"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/issues/2891/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls/2891/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls/2891/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/statuses/fc4442e7fce69d1be533c3436d6cd254b2256580"}}}}
{"actor":{"display_login":"daspecster"}}