{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/5504","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/5504/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/5504/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/5504/events","html_url":"https://github.com/nodejs/node/pull/5504","id":137628691,"number":5504,"title":"src: remove BINARY encoding","user":{"login":"indutny","id":238531,"avatar_url":"https://avatars.githubusercontent.com/u/238531?v=3","gravatar_id":"","url":"https://api.github.com/users/indutny","html_url":"https://github.com/indutny","followers_url":"https://api.github.com/users/indutny/followers","following_url":"https://api.github.com/users/indutny/following{/other_user}","gists_url":"https://api.github.com/users/indutny/gists{/gist_id}","starred_url":"https://api.github.com/users/indutny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indutny/subscriptions","organizations_url":"https://api.github.com/users/indutny/orgs","repos_url":"https://api.github.com/users/indutny/repos","events_url":"https://api.github.com/users/indutny/events{/privacy}","received_events_url":"https://api.github.com/users/indutny/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/nodejs/node/labels/buffer","name":"buffer","color":"f7c6c7"},{"url":"https://api.github.com/repos/nodejs/node/labels/c++","name":"c++","color":"e11d21"},{"url":"https://api.github.com/repos/nodejs/node/labels/crypto","name":"crypto","color":"009800"},{"url":"https://api.github.com/repos/nodejs/node/labels/doc","name":"doc","color":"006b75"},{"url":"https://api.github.com/repos/nodejs/node/labels/http","name":"http","color":"c7def8"},{"url":"https://api.github.com/repos/nodejs/node/labels/net","name":"net","color":"eb6420"},{"url":"https://api.github.com/repos/nodejs/node/labels/semver-major","name":"semver-major","color":"fbca04"},{"url":"https://api.github.com/repos/nodejs/node/labels/tls","name":"tls","color":"fad8c7"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":51,"created_at":"2016-03-01T16:53:18Z","updated_at":"2016-03-03T12:24:46Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/5504","html_url":"https://github.com/nodejs/node/pull/5504","diff_url":"https://github.com/nodejs/node/pull/5504.diff","patch_url":"https://github.com/nodejs/node/pull/5504.patch"},"body":"### Pull Request check-list\r\n\r\n_Please make sure to review and check all of these items:_\r\n\r\n- [x] Does `make -j8 test` (UNIX) or `vcbuild test nosign` (Windows) pass with\r\n  this change (including linting)?\r\n- [x] Is the commit message formatted according to [CONTRIBUTING.md][0]?\r\n- [x] If this change fixes a bug (or a performance problem), is a regression\r\n  test (or a benchmark) included?\r\n- [x] Is a documentation update included (if this change modifies\r\n  existing APIs, or introduces new ones)?\r\n\r\n_NOTE: these things are not required to open a PR and can be done\r\nafterwards / while the PR is open._\r\n\r\n### Affected core subsystem(s)\r\n\r\n_Please provide affected core subsystem(s) (like buffer, cluster, crypto, etc)_\r\n\r\n[0]: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#step-3-commit\r\n\r\n### Description of change\r\n\r\nIt was fun,\r\nnow it is gone.\r\n\r\n-------------\r\n\r\nI decided to follow @chrisdickinson footsteps and submit provocative PR :wink: Hopefully this will help to spin of a useful discussion!"},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/191734740","html_url":"https://github.com/nodejs/node/pull/5504#issuecomment-191734740","issue_url":"https://api.github.com/repos/nodejs/node/issues/5504","id":191734740,"user":{"login":"domenic","id":617481,"avatar_url":"https://avatars.githubusercontent.com/u/617481?v=3","gravatar_id":"","url":"https://api.github.com/users/domenic","html_url":"https://github.com/domenic","followers_url":"https://api.github.com/users/domenic/followers","following_url":"https://api.github.com/users/domenic/following{/other_user}","gists_url":"https://api.github.com/users/domenic/gists{/gist_id}","starred_url":"https://api.github.com/users/domenic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/domenic/subscriptions","organizations_url":"https://api.github.com/users/domenic/orgs","repos_url":"https://api.github.com/users/domenic/repos","events_url":"https://api.github.com/users/domenic/events{/privacy}","received_events_url":"https://api.github.com/users/domenic/received_events","type":"User","site_admin":false},"created_at":"2016-03-03T12:24:46Z","updated_at":"2016-03-03T12:24:46Z","body":"The Unicode standard does not define encodings apart from Unicode. It defines character ranges, but those are not related."}}