{"action":"created","issue":{"url":"https://api.github.com/repos/Metaswitch/freeDiameter/issues/21","repository_url":"https://api.github.com/repos/Metaswitch/freeDiameter","labels_url":"https://api.github.com/repos/Metaswitch/freeDiameter/issues/21/labels{/name}","comments_url":"https://api.github.com/repos/Metaswitch/freeDiameter/issues/21/comments","events_url":"https://api.github.com/repos/Metaswitch/freeDiameter/issues/21/events","html_url":"https://github.com/Metaswitch/freeDiameter/issues/21","id":78931409,"number":21,"title":"freeDiameter generates error logs when there are no session IDs on messages that don't require session IDs","user":{"login":"graemerobertson","id":5907876,"avatar_url":"https://avatars.githubusercontent.com/u/5907876?v=3","gravatar_id":"","url":"https://api.github.com/users/graemerobertson","html_url":"https://github.com/graemerobertson","followers_url":"https://api.github.com/users/graemerobertson/followers","following_url":"https://api.github.com/users/graemerobertson/following{/other_user}","gists_url":"https://api.github.com/users/graemerobertson/gists{/gist_id}","starred_url":"https://api.github.com/users/graemerobertson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graemerobertson/subscriptions","organizations_url":"https://api.github.com/users/graemerobertson/orgs","repos_url":"https://api.github.com/users/graemerobertson/repos","events_url":"https://api.github.com/users/graemerobertson/events{/privacy}","received_events_url":"https://api.github.com/users/graemerobertson/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-05-21T10:25:27Z","updated_at":"2016-06-08T22:11:24Z","closed_at":null,"body":"I've got freeDiameter running as a client and I'm seeing regular logs that look like\r\n\r\n```\r\n21-05-2015 10:19:40.950 UTC Debug diameterstack.cpp:781: Processing a sent diameter message\r\n21-05-2015 10:19:40.950 UTC Debug diameterstack.cpp:783: Got existing trail ID: 0\r\n21-05-2015 10:19:40.950 UTC Debug freeDiameter: No Session-Id AVP found in message 0x7fa1d0016d70\r\n21-05-2015 10:19:40.950 UTC Error freeDiameter: ERROR: Invalid parameter '(( ((session) != ((void *)0)) && ( ((struct session *)(session))->eyec == 0x53551D) ) && sid)', 22\r\n21-05-2015 10:19:40.950 UTC Debug freeDiameter: Sending 104b data on connection {----} TCP from [10.225.20.196]:35336 (11<-2007)\r\n```\r\n\r\nThey seem to correlate with things like responding to Device-Watchdog-Requests and Capabilities-Exchange-Requests (which don't have session IDs).\r\n\r\nThere doesn't seem to be any impact on behaviour - the error log is just annoying and misleading (and wrong).\r\n\r\nShould be easy to repro since the log seems to be generated on trying to send any DWA or CEA. Next step is probably to work out the code path in freeDiameter that leads to this log being generated (by adding more logs or by running with gdb)."},"comment":{"url":"https://api.github.com/repos/Metaswitch/freeDiameter/issues/comments/224745620","html_url":"https://github.com/Metaswitch/freeDiameter/issues/21#issuecomment-224745620","issue_url":"https://api.github.com/repos/Metaswitch/freeDiameter/issues/21","id":224745620,"user":{"login":"rkd-msw","id":4363492,"avatar_url":"https://avatars.githubusercontent.com/u/4363492?v=3","gravatar_id":"","url":"https://api.github.com/users/rkd-msw","html_url":"https://github.com/rkd-msw","followers_url":"https://api.github.com/users/rkd-msw/followers","following_url":"https://api.github.com/users/rkd-msw/following{/other_user}","gists_url":"https://api.github.com/users/rkd-msw/gists{/gist_id}","starred_url":"https://api.github.com/users/rkd-msw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rkd-msw/subscriptions","organizations_url":"https://api.github.com/users/rkd-msw/orgs","repos_url":"https://api.github.com/users/rkd-msw/repos","events_url":"https://api.github.com/users/rkd-msw/events{/privacy}","received_events_url":"https://api.github.com/users/rkd-msw/received_events","type":"User","site_admin":false},"created_at":"2016-06-08T22:11:24Z","updated_at":"2016-06-08T22:11:24Z","body":"I've just looked for this on the staging Ralf and it no longer seems to repro:\r\n\r\n```\r\n08-06-2016 19:00:28.633 UTC Debug freeDiameter: 'STATE_OPEN'    <-- 'FDEVP_CNX_MSG_RECV'        (0x7fadec0edc10,120)    '10.0.0.83'\r\n08-06-2016 19:00:28.633 UTC Debug freeDiameter: Iterating on rules of COMMAND: 'Device-Watchdog-Request'.\r\n08-06-2016 19:00:28.633 UTC Debug freeDiameter: No Session-Id AVP found in message 0x7fadf00c3810\r\n08-06-2016 19:00:28.633 UTC Debug freeDiameter: Peer timeout reset to 30 seconds (+/- 2)\r\n08-06-2016 19:00:28.633 UTC Debug freeDiameter: '10.0.0.83' in state 'STATE_OPEN' waiting for next event.\r\n08-06-2016 19:00:28.633 UTC Debug freeDiameter: GOING TO SEND TO '10.0.0.83': 'Device-Watchdog-Answer'0/280 f:---- src:'(nil)' len:20 {C:268/l:12,C:264/l:8,C:296/l:8,C:278/l:12}\r\n08-06-2016 19:00:28.633 UTC Debug freeDiameter: Sending 128b data on connection {----} TCP,#392->10.0.0.83(3868)\r\n```\r\n\r\nI've grepped for `Error freeDiameter` in /var/log/ralf and found nothing. Should we close?"}}
{"actor":{"display_login":"rkd-msw"}}