{"action":"created","comment":{"url":"https://api.github.com/repos/edx/configuration/pulls/comments/64389013","id":64389013,"diff_hunk":"@@ -25,5 +25,45 @@\n #\n # dependencies:\n #   - role: themes\n+#     theme_users:\n+#       - ecommerce\n+#       - edxapp\n+#     additional_theme_dirs:\n+#      - /edx/app/ecommerce/ecommerce/ecommerce/themes\n #     when do_setup_themes\n #\n+\n+# make sure edx-theme's group has read/write access to themes directory\n+- name: ensure edx-theme's group has read/write access to themes directory\n+  file:\n+    path: \"{{ themes_home }}\"\n+    state: directory\n+    recurse: yes\n+    owner: \"{{ themes_user }}\"\n+    group: \"{{ themes_group }}\"\n+    mode: \"g+rw\"\n+  tags:\n+    - install\n+    - install:base\n+\n+- name: assign theme's group to all theme's directories\n+  file:\n+    path: \"{{ item }}\"\n+    state: directory\n+    recurse: yes\n+    group: \"{{ themes_group }}\"\n+    mode: \"g+rw\"\n+  with_items: additional_theme_dirs\n+  when: additional_theme_dirs is defined\n+  tags:\n+    - install\n+    - install:base\n+\n+- name: Add theme users to theme's group so that that have read/erite access to themes directories","path":"playbooks/roles/edx-themes/tasks/main.yml","position":38,"original_position":38,"commit_id":"7da5f4bcd2b4ee67aeec7f91162a957210146a59","original_commit_id":"7da5f4bcd2b4ee67aeec7f91162a957210146a59","user":{"login":"saleem-latif","id":7114956,"avatar_url":"https://avatars.githubusercontent.com/u/7114956?v=3","gravatar_id":"","url":"https://api.github.com/users/saleem-latif","html_url":"https://github.com/saleem-latif","followers_url":"https://api.github.com/users/saleem-latif/followers","following_url":"https://api.github.com/users/saleem-latif/following{/other_user}","gists_url":"https://api.github.com/users/saleem-latif/gists{/gist_id}","starred_url":"https://api.github.com/users/saleem-latif/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saleem-latif/subscriptions","organizations_url":"https://api.github.com/users/saleem-latif/orgs","repos_url":"https://api.github.com/users/saleem-latif/repos","events_url":"https://api.github.com/users/saleem-latif/events{/privacy}","received_events_url":"https://api.github.com/users/saleem-latif/received_events","type":"User","site_admin":false},"body":"@fredsmith yes, that sounds good, I will update add-user role also. ","created_at":"2016-05-24T13:23:55Z","updated_at":"2016-05-24T13:23:55Z","html_url":"https://github.com/edx/configuration/pull/3065#discussion_r64389013","pull_request_url":"https://api.github.com/repos/edx/configuration/pulls/3065","_links":{"self":{"href":"https://api.github.com/repos/edx/configuration/pulls/comments/64389013"},"html":{"href":"https://github.com/edx/configuration/pull/3065#discussion_r64389013"},"pull_request":{"href":"https://api.github.com/repos/edx/configuration/pulls/3065"}}},"pull_request":{"url":"https://api.github.com/repos/edx/configuration/pulls/3065","id":71160304,"html_url":"https://github.com/edx/configuration/pull/3065","diff_url":"https://github.com/edx/configuration/pull/3065.diff","patch_url":"https://github.com/edx/configuration/pull/3065.patch","issue_url":"https://api.github.com/repos/edx/configuration/issues/3065","number":3065,"state":"open","locked":false,"title":"MAYN-281: Update edx-configuration to support multiple theme directories","user":{"login":"saleem-latif","id":7114956,"avatar_url":"https://avatars.githubusercontent.com/u/7114956?v=3","gravatar_id":"","url":"https://api.github.com/users/saleem-latif","html_url":"https://github.com/saleem-latif","followers_url":"https://api.github.com/users/saleem-latif/followers","following_url":"https://api.github.com/users/saleem-latif/following{/other_user}","gists_url":"https://api.github.com/users/saleem-latif/gists{/gist_id}","starred_url":"https://api.github.com/users/saleem-latif/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saleem-latif/subscriptions","organizations_url":"https://api.github.com/users/saleem-latif/orgs","repos_url":"https://api.github.com/users/saleem-latif/repos","events_url":"https://api.github.com/users/saleem-latif/events{/privacy}","received_events_url":"https://api.github.com/users/saleem-latif/received_events","type":"User","site_admin":false},"body":"Hi @mattdrayer , @fredsmith , @feanil \r\n\r\nKindly take a look at this PR, it contains changes for MAYN-281,\r\n\r\n__Description of MAYN-281:__\r\nCurrently, we can specify only one theme directory for themes. Update configuration so that multiple theme dirs can be specified\r\nHere is a list of changes\r\n\r\n1. Rename `ECOMMERCE_COMPREHENSIVE_THEME_DIR` to  `ECOMMERCE_COMPREHENSIVE_THEME_DIRS` and make it accept list of directories instead of a single directory.\r\n2. `COMPREHENSIVE_THEME_DIR` is renamed to `COMPREHENSIVE_THEME_DIRS` in ecommerce, so we need to make corresponding update in ansible scripts too.\r\n3. create a group named `edx-themes` with read/write permissions to all theme directories so that any ansible user (like ecommerce, edxapp) that requires access to edx-themes can join this group for proper access rights.\r\n4. Remove ansible scripts that copy themes from edx-themes dir into ecommerce/themes.\r\n","created_at":"2016-05-24T05:38:01Z","updated_at":"2016-05-24T13:23:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"60b232c1a4ac2c73c6a51936040fb97f8dfaadd2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/edx/configuration/pulls/3065/commits","review_comments_url":"https://api.github.com/repos/edx/configuration/pulls/3065/comments","review_comment_url":"https://api.github.com/repos/edx/configuration/pulls/comments{/number}","comments_url":"https://api.github.com/repos/edx/configuration/issues/3065/comments","statuses_url":"https://api.github.com/repos/edx/configuration/statuses/7da5f4bcd2b4ee67aeec7f91162a957210146a59","head":{"label":"edx:saleem-latif/MAYN-281","ref":"saleem-latif/MAYN-281","sha":"7da5f4bcd2b4ee67aeec7f91162a957210146a59","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":9478219,"name":"configuration","full_name":"edx/configuration","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/configuration","description":"a simple, but flexible, way for anyone to stand up an instance of the edX platform that is fully configured and ready-to-go","fork":false,"url":"https://api.github.com/repos/edx/configuration","forks_url":"https://api.github.com/repos/edx/configuration/forks","keys_url":"https://api.github.com/repos/edx/configuration/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/configuration/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/configuration/teams","hooks_url":"https://api.github.com/repos/edx/configuration/hooks","issue_events_url":"https://api.github.com/repos/edx/configuration/issues/events{/number}","events_url":"https://api.github.com/repos/edx/configuration/events","assignees_url":"https://api.github.com/repos/edx/configuration/assignees{/user}","branches_url":"https://api.github.com/repos/edx/configuration/branches{/branch}","tags_url":"https://api.github.com/repos/edx/configuration/tags","blobs_url":"https://api.github.com/repos/edx/configuration/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/configuration/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/configuration/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/configuration/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/configuration/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/configuration/languages","stargazers_url":"https://api.github.com/repos/edx/configuration/stargazers","contributors_url":"https://api.github.com/repos/edx/configuration/contributors","subscribers_url":"https://api.github.com/repos/edx/configuration/subscribers","subscription_url":"https://api.github.com/repos/edx/configuration/subscription","commits_url":"https://api.github.com/repos/edx/configuration/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/configuration/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/configuration/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/configuration/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/configuration/contents/{+path}","compare_url":"https://api.github.com/repos/edx/configuration/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/configuration/merges","archive_url":"https://api.github.com/repos/edx/configuration/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/configuration/downloads","issues_url":"https://api.github.com/repos/edx/configuration/issues{/number}","pulls_url":"https://api.github.com/repos/edx/configuration/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/configuration/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/configuration/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/configuration/labels{/name}","releases_url":"https://api.github.com/repos/edx/configuration/releases{/id}","deployments_url":"https://api.github.com/repos/edx/configuration/deployments","created_at":"2013-04-16T17:23:42Z","updated_at":"2016-05-20T17:40:56Z","pushed_at":"2016-05-24T13:17:07Z","git_url":"git://github.com/edx/configuration.git","ssh_url":"git@github.com:edx/configuration.git","clone_url":"https://github.com/edx/configuration.git","svn_url":"https://github.com/edx/configuration","homepage":"","size":41166,"stargazers_count":515,"watchers_count":515,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":498,"mirror_url":null,"open_issues_count":55,"forks":498,"open_issues":55,"watchers":515,"default_branch":"master"}},"base":{"label":"edx:master","ref":"master","sha":"e805b2965aba059fd04ce2625929eed10228701a","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":9478219,"name":"configuration","full_name":"edx/configuration","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/configuration","description":"a simple, but flexible, way for anyone to stand up an instance of the edX platform that is fully configured and ready-to-go","fork":false,"url":"https://api.github.com/repos/edx/configuration","forks_url":"https://api.github.com/repos/edx/configuration/forks","keys_url":"https://api.github.com/repos/edx/configuration/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/configuration/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/configuration/teams","hooks_url":"https://api.github.com/repos/edx/configuration/hooks","issue_events_url":"https://api.github.com/repos/edx/configuration/issues/events{/number}","events_url":"https://api.github.com/repos/edx/configuration/events","assignees_url":"https://api.github.com/repos/edx/configuration/assignees{/user}","branches_url":"https://api.github.com/repos/edx/configuration/branches{/branch}","tags_url":"https://api.github.com/repos/edx/configuration/tags","blobs_url":"https://api.github.com/repos/edx/configuration/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/configuration/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/configuration/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/configuration/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/configuration/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/configuration/languages","stargazers_url":"https://api.github.com/repos/edx/configuration/stargazers","contributors_url":"https://api.github.com/repos/edx/configuration/contributors","subscribers_url":"https://api.github.com/repos/edx/configuration/subscribers","subscription_url":"https://api.github.com/repos/edx/configuration/subscription","commits_url":"https://api.github.com/repos/edx/configuration/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/configuration/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/configuration/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/configuration/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/configuration/contents/{+path}","compare_url":"https://api.github.com/repos/edx/configuration/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/configuration/merges","archive_url":"https://api.github.com/repos/edx/configuration/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/configuration/downloads","issues_url":"https://api.github.com/repos/edx/configuration/issues{/number}","pulls_url":"https://api.github.com/repos/edx/configuration/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/configuration/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/configuration/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/configuration/labels{/name}","releases_url":"https://api.github.com/repos/edx/configuration/releases{/id}","deployments_url":"https://api.github.com/repos/edx/configuration/deployments","created_at":"2013-04-16T17:23:42Z","updated_at":"2016-05-20T17:40:56Z","pushed_at":"2016-05-24T13:17:07Z","git_url":"git://github.com/edx/configuration.git","ssh_url":"git@github.com:edx/configuration.git","clone_url":"https://github.com/edx/configuration.git","svn_url":"https://github.com/edx/configuration","homepage":"","size":41166,"stargazers_count":515,"watchers_count":515,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":498,"mirror_url":null,"open_issues_count":55,"forks":498,"open_issues":55,"watchers":515,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edx/configuration/pulls/3065"},"html":{"href":"https://github.com/edx/configuration/pull/3065"},"issue":{"href":"https://api.github.com/repos/edx/configuration/issues/3065"},"comments":{"href":"https://api.github.com/repos/edx/configuration/issues/3065/comments"},"review_comments":{"href":"https://api.github.com/repos/edx/configuration/pulls/3065/comments"},"review_comment":{"href":"https://api.github.com/repos/edx/configuration/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/edx/configuration/pulls/3065/commits"},"statuses":{"href":"https://api.github.com/repos/edx/configuration/statuses/7da5f4bcd2b4ee67aeec7f91162a957210146a59"}}}}
{"actor":{"display_login":"saleem-latif"}}