{"action":"created","comment":{"url":"https://api.github.com/repos/hadley/devtools/pulls/comments/50304249","id":50304249,"diff_hunk":"@@ -47,6 +47,8 @@\n #'   It defaults to the option \\code{\"Ncpus\"} or \\code{1} if unset.\n #' @param force_deps whether to force installation of dependencies even if their\n #'   SHA1 reference hasn't changed from the currently installed version.\n+#' @param metadata \\code{list} of metadata (normally generated by\n+#'   \\code{remote_metadata}) to add to the DESCRIPTION file after installation.","path":"R/install.r","position":5,"original_position":5,"commit_id":"6467f7c702a9e1c99940ba2a95e50bae94993f2c","original_commit_id":"6467f7c702a9e1c99940ba2a95e50bae94993f2c","user":{"login":"hadley","id":4196,"avatar_url":"https://avatars.githubusercontent.com/u/4196?v=3","gravatar_id":"","url":"https://api.github.com/users/hadley","html_url":"https://github.com/hadley","followers_url":"https://api.github.com/users/hadley/followers","following_url":"https://api.github.com/users/hadley/following{/other_user}","gists_url":"https://api.github.com/users/hadley/gists{/gist_id}","starred_url":"https://api.github.com/users/hadley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hadley/subscriptions","organizations_url":"https://api.github.com/users/hadley/orgs","repos_url":"https://api.github.com/users/hadley/repos","events_url":"https://api.github.com/users/hadley/events{/privacy}","received_events_url":"https://api.github.com/users/hadley/received_events","type":"User","site_admin":false},"body":"I'd say: `Named list of metadata entries to be added to the \\code{DESCRIPTION} prior to installation.`","created_at":"2016-01-20T19:23:15Z","updated_at":"2016-01-20T19:23:15Z","html_url":"https://github.com/hadley/devtools/pull/1027#discussion_r50304249","pull_request_url":"https://api.github.com/repos/hadley/devtools/pulls/1027","_links":{"self":{"href":"https://api.github.com/repos/hadley/devtools/pulls/comments/50304249"},"html":{"href":"https://github.com/hadley/devtools/pull/1027#discussion_r50304249"},"pull_request":{"href":"https://api.github.com/repos/hadley/devtools/pulls/1027"}}},"pull_request":{"url":"https://api.github.com/repos/hadley/devtools/pulls/1027","id":56127105,"html_url":"https://github.com/hadley/devtools/pull/1027","diff_url":"https://github.com/hadley/devtools/pull/1027.diff","patch_url":"https://github.com/hadley/devtools/pull/1027.patch","issue_url":"https://api.github.com/repos/hadley/devtools/issues/1027","number":1027,"state":"open","locked":false,"title":"Install sha (second attempt)","user":{"login":"rmflight","id":1509626,"avatar_url":"https://avatars.githubusercontent.com/u/1509626?v=3","gravatar_id":"","url":"https://api.github.com/users/rmflight","html_url":"https://github.com/rmflight","followers_url":"https://api.github.com/users/rmflight/followers","following_url":"https://api.github.com/users/rmflight/following{/other_user}","gists_url":"https://api.github.com/users/rmflight/gists{/gist_id}","starred_url":"https://api.github.com/users/rmflight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmflight/subscriptions","organizations_url":"https://api.github.com/users/rmflight/orgs","repos_url":"https://api.github.com/users/rmflight/repos","events_url":"https://api.github.com/users/rmflight/events{/privacy}","received_events_url":"https://api.github.com/users/rmflight/received_events","type":"User","site_admin":false},"body":"@jimhester, based on our earlier conversations, here is a second attempt at adding the SHA1 to the package install. It uses `git_committed` as we discussed as the default function of `add_sha`, and then if that passes, will then use `install_local` to copy the package to a temp directory and do the install from there, which automatically adds the SHA1.\r\n\r\nNote that the call to `install_local` probably needs to have all the other `install` arguments added to it to truly work as intended, but this currently passes all the tests, including the ones I added. \r\n\r\nIf this passes muster, I will add the rest of the install arguments to the `install_local` call.\r\n\r\nThe only ugly part of this I don't like is the `return()` statement that keeps a second round of `install` from happening and installing the one in the current directory, because that causes a `NULL` return value. I don't know how to avoid that ATM.","created_at":"2016-01-15T03:33:10Z","updated_at":"2016-01-20T19:23:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fc9e394da831fa3622a3bcf4c55043ea58d20294","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hadley/devtools/pulls/1027/commits","review_comments_url":"https://api.github.com/repos/hadley/devtools/pulls/1027/comments","review_comment_url":"https://api.github.com/repos/hadley/devtools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hadley/devtools/issues/1027/comments","statuses_url":"https://api.github.com/repos/hadley/devtools/statuses/6467f7c702a9e1c99940ba2a95e50bae94993f2c","head":{"label":"rmflight:install_sha","ref":"install_sha","sha":"6467f7c702a9e1c99940ba2a95e50bae94993f2c","user":{"login":"rmflight","id":1509626,"avatar_url":"https://avatars.githubusercontent.com/u/1509626?v=3","gravatar_id":"","url":"https://api.github.com/users/rmflight","html_url":"https://github.com/rmflight","followers_url":"https://api.github.com/users/rmflight/followers","following_url":"https://api.github.com/users/rmflight/following{/other_user}","gists_url":"https://api.github.com/users/rmflight/gists{/gist_id}","starred_url":"https://api.github.com/users/rmflight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmflight/subscriptions","organizations_url":"https://api.github.com/users/rmflight/orgs","repos_url":"https://api.github.com/users/rmflight/repos","events_url":"https://api.github.com/users/rmflight/events{/privacy}","received_events_url":"https://api.github.com/users/rmflight/received_events","type":"User","site_admin":false},"repo":{"id":49616156,"name":"devtools","full_name":"rmflight/devtools","owner":{"login":"rmflight","id":1509626,"avatar_url":"https://avatars.githubusercontent.com/u/1509626?v=3","gravatar_id":"","url":"https://api.github.com/users/rmflight","html_url":"https://github.com/rmflight","followers_url":"https://api.github.com/users/rmflight/followers","following_url":"https://api.github.com/users/rmflight/following{/other_user}","gists_url":"https://api.github.com/users/rmflight/gists{/gist_id}","starred_url":"https://api.github.com/users/rmflight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmflight/subscriptions","organizations_url":"https://api.github.com/users/rmflight/orgs","repos_url":"https://api.github.com/users/rmflight/repos","events_url":"https://api.github.com/users/rmflight/events{/privacy}","received_events_url":"https://api.github.com/users/rmflight/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rmflight/devtools","description":"Tools to make an R developer's life easier","fork":true,"url":"https://api.github.com/repos/rmflight/devtools","forks_url":"https://api.github.com/repos/rmflight/devtools/forks","keys_url":"https://api.github.com/repos/rmflight/devtools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rmflight/devtools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rmflight/devtools/teams","hooks_url":"https://api.github.com/repos/rmflight/devtools/hooks","issue_events_url":"https://api.github.com/repos/rmflight/devtools/issues/events{/number}","events_url":"https://api.github.com/repos/rmflight/devtools/events","assignees_url":"https://api.github.com/repos/rmflight/devtools/assignees{/user}","branches_url":"https://api.github.com/repos/rmflight/devtools/branches{/branch}","tags_url":"https://api.github.com/repos/rmflight/devtools/tags","blobs_url":"https://api.github.com/repos/rmflight/devtools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rmflight/devtools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rmflight/devtools/git/refs{/sha}","trees_url":"https://api.github.com/repos/rmflight/devtools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rmflight/devtools/statuses/{sha}","languages_url":"https://api.github.com/repos/rmflight/devtools/languages","stargazers_url":"https://api.github.com/repos/rmflight/devtools/stargazers","contributors_url":"https://api.github.com/repos/rmflight/devtools/contributors","subscribers_url":"https://api.github.com/repos/rmflight/devtools/subscribers","subscription_url":"https://api.github.com/repos/rmflight/devtools/subscription","commits_url":"https://api.github.com/repos/rmflight/devtools/commits{/sha}","git_commits_url":"https://api.github.com/repos/rmflight/devtools/git/commits{/sha}","comments_url":"https://api.github.com/repos/rmflight/devtools/comments{/number}","issue_comment_url":"https://api.github.com/repos/rmflight/devtools/issues/comments{/number}","contents_url":"https://api.github.com/repos/rmflight/devtools/contents/{+path}","compare_url":"https://api.github.com/repos/rmflight/devtools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rmflight/devtools/merges","archive_url":"https://api.github.com/repos/rmflight/devtools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rmflight/devtools/downloads","issues_url":"https://api.github.com/repos/rmflight/devtools/issues{/number}","pulls_url":"https://api.github.com/repos/rmflight/devtools/pulls{/number}","milestones_url":"https://api.github.com/repos/rmflight/devtools/milestones{/number}","notifications_url":"https://api.github.com/repos/rmflight/devtools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rmflight/devtools/labels{/name}","releases_url":"https://api.github.com/repos/rmflight/devtools/releases{/id}","created_at":"2016-01-14T02:11:42Z","updated_at":"2016-01-14T02:11:43Z","pushed_at":"2016-01-20T18:41:56Z","git_url":"git://github.com/rmflight/devtools.git","ssh_url":"git@github.com:rmflight/devtools.git","clone_url":"https://github.com/rmflight/devtools.git","svn_url":"https://github.com/rmflight/devtools","homepage":"","size":3588,"stargazers_count":0,"watchers_count":0,"language":"R","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"hadley:master","ref":"master","sha":"8f95b6f6d0e5f3724858a3b09a6d6422458d2dff","user":{"login":"hadley","id":4196,"avatar_url":"https://avatars.githubusercontent.com/u/4196?v=3","gravatar_id":"","url":"https://api.github.com/users/hadley","html_url":"https://github.com/hadley","followers_url":"https://api.github.com/users/hadley/followers","following_url":"https://api.github.com/users/hadley/following{/other_user}","gists_url":"https://api.github.com/users/hadley/gists{/gist_id}","starred_url":"https://api.github.com/users/hadley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hadley/subscriptions","organizations_url":"https://api.github.com/users/hadley/orgs","repos_url":"https://api.github.com/users/hadley/repos","events_url":"https://api.github.com/users/hadley/events{/privacy}","received_events_url":"https://api.github.com/users/hadley/received_events","type":"User","site_admin":false},"repo":{"id":643909,"name":"devtools","full_name":"hadley/devtools","owner":{"login":"hadley","id":4196,"avatar_url":"https://avatars.githubusercontent.com/u/4196?v=3","gravatar_id":"","url":"https://api.github.com/users/hadley","html_url":"https://github.com/hadley","followers_url":"https://api.github.com/users/hadley/followers","following_url":"https://api.github.com/users/hadley/following{/other_user}","gists_url":"https://api.github.com/users/hadley/gists{/gist_id}","starred_url":"https://api.github.com/users/hadley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hadley/subscriptions","organizations_url":"https://api.github.com/users/hadley/orgs","repos_url":"https://api.github.com/users/hadley/repos","events_url":"https://api.github.com/users/hadley/events{/privacy}","received_events_url":"https://api.github.com/users/hadley/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hadley/devtools","description":"Tools to make an R developer's life easier","fork":false,"url":"https://api.github.com/repos/hadley/devtools","forks_url":"https://api.github.com/repos/hadley/devtools/forks","keys_url":"https://api.github.com/repos/hadley/devtools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hadley/devtools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hadley/devtools/teams","hooks_url":"https://api.github.com/repos/hadley/devtools/hooks","issue_events_url":"https://api.github.com/repos/hadley/devtools/issues/events{/number}","events_url":"https://api.github.com/repos/hadley/devtools/events","assignees_url":"https://api.github.com/repos/hadley/devtools/assignees{/user}","branches_url":"https://api.github.com/repos/hadley/devtools/branches{/branch}","tags_url":"https://api.github.com/repos/hadley/devtools/tags","blobs_url":"https://api.github.com/repos/hadley/devtools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hadley/devtools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hadley/devtools/git/refs{/sha}","trees_url":"https://api.github.com/repos/hadley/devtools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hadley/devtools/statuses/{sha}","languages_url":"https://api.github.com/repos/hadley/devtools/languages","stargazers_url":"https://api.github.com/repos/hadley/devtools/stargazers","contributors_url":"https://api.github.com/repos/hadley/devtools/contributors","subscribers_url":"https://api.github.com/repos/hadley/devtools/subscribers","subscription_url":"https://api.github.com/repos/hadley/devtools/subscription","commits_url":"https://api.github.com/repos/hadley/devtools/commits{/sha}","git_commits_url":"https://api.github.com/repos/hadley/devtools/git/commits{/sha}","comments_url":"https://api.github.com/repos/hadley/devtools/comments{/number}","issue_comment_url":"https://api.github.com/repos/hadley/devtools/issues/comments{/number}","contents_url":"https://api.github.com/repos/hadley/devtools/contents/{+path}","compare_url":"https://api.github.com/repos/hadley/devtools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hadley/devtools/merges","archive_url":"https://api.github.com/repos/hadley/devtools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hadley/devtools/downloads","issues_url":"https://api.github.com/repos/hadley/devtools/issues{/number}","pulls_url":"https://api.github.com/repos/hadley/devtools/pulls{/number}","milestones_url":"https://api.github.com/repos/hadley/devtools/milestones{/number}","notifications_url":"https://api.github.com/repos/hadley/devtools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hadley/devtools/labels{/name}","releases_url":"https://api.github.com/repos/hadley/devtools/releases{/id}","created_at":"2010-05-03T04:08:49Z","updated_at":"2016-01-20T19:02:00Z","pushed_at":"2016-01-20T19:18:34Z","git_url":"git://github.com/hadley/devtools.git","ssh_url":"git@github.com:hadley/devtools.git","clone_url":"https://github.com/hadley/devtools.git","svn_url":"https://github.com/hadley/devtools","homepage":"","size":4076,"stargazers_count":1165,"watchers_count":1165,"language":"R","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":365,"mirror_url":null,"open_issues_count":29,"forks":365,"open_issues":29,"watchers":1165,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hadley/devtools/pulls/1027"},"html":{"href":"https://github.com/hadley/devtools/pull/1027"},"issue":{"href":"https://api.github.com/repos/hadley/devtools/issues/1027"},"comments":{"href":"https://api.github.com/repos/hadley/devtools/issues/1027/comments"},"review_comments":{"href":"https://api.github.com/repos/hadley/devtools/pulls/1027/comments"},"review_comment":{"href":"https://api.github.com/repos/hadley/devtools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hadley/devtools/pulls/1027/commits"},"statuses":{"href":"https://api.github.com/repos/hadley/devtools/statuses/6467f7c702a9e1c99940ba2a95e50bae94993f2c"}}}}