{"action":"created","issue":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/11646","repository_url":"https://api.github.com/repos/cockroachdb/cockroach","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/11646/labels{/name}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/11646/comments","events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/11646/events","html_url":"https://github.com/cockroachdb/cockroach/pull/11646","id":191877624,"number":11646,"title":"testutils: Make IsError interpret empty re as not expecting an error","user":{"login":"a-robinson","id":7085343,"avatar_url":"https://avatars.githubusercontent.com/u/7085343?v=3","gravatar_id":"","url":"https://api.github.com/users/a-robinson","html_url":"https://github.com/a-robinson","followers_url":"https://api.github.com/users/a-robinson/followers","following_url":"https://api.github.com/users/a-robinson/following{/other_user}","gists_url":"https://api.github.com/users/a-robinson/gists{/gist_id}","starred_url":"https://api.github.com/users/a-robinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-robinson/subscriptions","organizations_url":"https://api.github.com/users/a-robinson/orgs","repos_url":"https://api.github.com/users/a-robinson/repos","events_url":"https://api.github.com/users/a-robinson/events{/privacy}","received_events_url":"https://api.github.com/users/a-robinson/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-11-27T18:52:37Z","updated_at":"2016-11-28T13:37:55Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/11646","html_url":"https://github.com/cockroachdb/cockroach/pull/11646","diff_url":"https://github.com/cockroachdb/cockroach/pull/11646.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/11646.patch"},"body":"This makes using IsError (and IsPError) much simpler in tests that\r\ndon't always expect an error, since now you don't have to first check\r\nwhether an error is expected before calling IsError. It's worth noting\r\nthat this broke zero tests -- no test was relying on the behavior of\r\nsaying that every error matched with the empty regex.\r\n\r\nI've gone and cleaned up the uses of IsError that were working around\r\nits old behavior to simplify them and get rid of bad examples for\r\nfuture developers to copy from. In the process, I found an MVCC test\r\nthat wasn't actually testing what it was supposed to be and fixed it.\r\n\r\nThis was annoying me while I was writing tests for the migration code last week.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/cockroachdb/cockroach/11646)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments/263272989","html_url":"https://github.com/cockroachdb/cockroach/pull/11646#issuecomment-263272989","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/11646","id":263272989,"user":{"login":"petermattis","id":6201335,"avatar_url":"https://avatars.githubusercontent.com/u/6201335?v=3","gravatar_id":"","url":"https://api.github.com/users/petermattis","html_url":"https://github.com/petermattis","followers_url":"https://api.github.com/users/petermattis/followers","following_url":"https://api.github.com/users/petermattis/following{/other_user}","gists_url":"https://api.github.com/users/petermattis/gists{/gist_id}","starred_url":"https://api.github.com/users/petermattis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petermattis/subscriptions","organizations_url":"https://api.github.com/users/petermattis/orgs","repos_url":"https://api.github.com/users/petermattis/repos","events_url":"https://api.github.com/users/petermattis/events{/privacy}","received_events_url":"https://api.github.com/users/petermattis/received_events","type":"User","site_admin":false},"created_at":"2016-11-28T13:37:55Z","updated_at":"2016-11-28T13:37:55Z","body":"<img class=\"emoji\" title=\":lgtm:\" alt=\":lgtm:\" align=\"absmiddle\" src=\"https://reviewable.io/lgtm.png\" height=\"20\" width=\"61\"/>\n\n---\n\nReview status: 0 of 14 files reviewed at latest revision, all discussions resolved, some commit checks failed.\n\n---\n\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/cockroachdb/cockroach/11646#-:-KXf8zXjGJYzqv8jDxOD:bnfp4nl)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"petermattis"}}