{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/26936","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/26936/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/26936/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/26936/events","html_url":"https://github.com/kubernetes/kubernetes/pull/26936","id":158838457,"number":26936,"title":"rkt: Fix incomplete selinux context string when the option is partial.","user":{"login":"yifan-gu","id":3278588,"avatar_url":"https://avatars.githubusercontent.com/u/3278588?v=3","gravatar_id":"","url":"https://api.github.com/users/yifan-gu","html_url":"https://github.com/yifan-gu","followers_url":"https://api.github.com/users/yifan-gu/followers","following_url":"https://api.github.com/users/yifan-gu/following{/other_user}","gists_url":"https://api.github.com/users/yifan-gu/gists{/gist_id}","starred_url":"https://api.github.com/users/yifan-gu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yifan-gu/subscriptions","organizations_url":"https://api.github.com/users/yifan-gu/orgs","repos_url":"https://api.github.com/users/yifan-gu/repos","events_url":"https://api.github.com/users/yifan-gu/events{/privacy}","received_events_url":"https://api.github.com/users/yifan-gu/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cla:%20yes","name":"cla: yes","color":"bfe5bf"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/dependency/rkt","name":"dependency/rkt","color":"fbfa04"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/M","name":"size/M","color":"eebb00"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/team/node","name":"team/node","color":"d2b48c"}],"state":"open","locked":false,"assignee":{"login":"euank","id":2147649,"avatar_url":"https://avatars.githubusercontent.com/u/2147649?v=3","gravatar_id":"","url":"https://api.github.com/users/euank","html_url":"https://github.com/euank","followers_url":"https://api.github.com/users/euank/followers","following_url":"https://api.github.com/users/euank/following{/other_user}","gists_url":"https://api.github.com/users/euank/gists{/gist_id}","starred_url":"https://api.github.com/users/euank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/euank/subscriptions","organizations_url":"https://api.github.com/users/euank/orgs","repos_url":"https://api.github.com/users/euank/repos","events_url":"https://api.github.com/users/euank/events{/privacy}","received_events_url":"https://api.github.com/users/euank/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/19","html_url":"https://github.com/kubernetes/kubernetes/milestones/rktnetes-v1.0","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/19/labels","id":1685452,"number":19,"title":"rktnetes-v1.0","description":"","creator":{"login":"dchen1107","id":7740897,"avatar_url":"https://avatars.githubusercontent.com/u/7740897?v=3","gravatar_id":"","url":"https://api.github.com/users/dchen1107","html_url":"https://github.com/dchen1107","followers_url":"https://api.github.com/users/dchen1107/followers","following_url":"https://api.github.com/users/dchen1107/following{/other_user}","gists_url":"https://api.github.com/users/dchen1107/gists{/gist_id}","starred_url":"https://api.github.com/users/dchen1107/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dchen1107/subscriptions","organizations_url":"https://api.github.com/users/dchen1107/orgs","repos_url":"https://api.github.com/users/dchen1107/repos","events_url":"https://api.github.com/users/dchen1107/events{/privacy}","received_events_url":"https://api.github.com/users/dchen1107/received_events","type":"User","site_admin":false},"open_issues":19,"closed_issues":37,"state":"open","created_at":"2016-04-05T19:02:11Z","updated_at":"2016-06-07T16:31:06Z","due_on":"2016-05-09T07:00:00Z","closed_at":null},"comments":3,"created_at":"2016-06-07T04:56:14Z","updated_at":"2016-06-07T18:10:50Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/26936","html_url":"https://github.com/kubernetes/kubernetes/pull/26936","diff_url":"https://github.com/kubernetes/kubernetes/pull/26936.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/26936.patch"},"body":"Fix \"EmptyDir\" e2e tests failures caused by #https://github.com/kubernetes/kubernetes/pull/24901\r\n\r\nAs mentioned in https://github.com/kubernetes/kubernetes/pull/24901#discussion_r61372312\r\nWe should apply the selinux context of the rkt data directory (/var/lib/rkt) when users do not specify all the selinux options.\r\n\r\nDue to my fault, the change was missed during rebase, thus caused the regression.\r\n\r\nAfter applying this PR, the e2e tests passed.\r\n```\r\n$ go run hack/e2e.go -v -test --test_args=\"--ginkgo.dryRun=false --ginkgo.focus=EmptyDir\"\r\n...\r\nRan 19 of 313 Specs in 199.319 seconds\r\nSUCCESS! -- 19 Passed | 0 Failed | 0 Pending | 294 Skipped PASS\r\n```\r\n\r\nBTW, the test is removed because the `--no-overlay=true` flag will only be there on non-coreos distro.\r\n\r\ncc @euank @kubernetes/sig-node "},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/224366007","html_url":"https://github.com/kubernetes/kubernetes/pull/26936#issuecomment-224366007","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/26936","id":224366007,"user":{"login":"yifan-gu","id":3278588,"avatar_url":"https://avatars.githubusercontent.com/u/3278588?v=3","gravatar_id":"","url":"https://api.github.com/users/yifan-gu","html_url":"https://github.com/yifan-gu","followers_url":"https://api.github.com/users/yifan-gu/followers","following_url":"https://api.github.com/users/yifan-gu/following{/other_user}","gists_url":"https://api.github.com/users/yifan-gu/gists{/gist_id}","starred_url":"https://api.github.com/users/yifan-gu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yifan-gu/subscriptions","organizations_url":"https://api.github.com/users/yifan-gu/orgs","repos_url":"https://api.github.com/users/yifan-gu/repos","events_url":"https://api.github.com/users/yifan-gu/events{/privacy}","received_events_url":"https://api.github.com/users/yifan-gu/received_events","type":"User","site_admin":false},"created_at":"2016-06-07T18:10:50Z","updated_at":"2016-06-07T18:10:50Z","body":"@euank OK, the selinux package is not included in build on non-linux platform"}}
{"actor":{"display_login":"yifan-gu"}}