{"action":"created","comment":{"url":"https://api.github.com/repos/getsentry/sentry/pulls/comments/83718172","pull_request_review_id":4543718,"id":83718172,"diff_hunk":"@@ -123,7 +123,13 @@ def recover_confirm(request, user_id, hash):\n @login_required\n def start_confirm_email(request):\n     has_unverified_emails = request.user.has_unverified_emails()\n-    if has_unverified_emails:\n+\n+    if 'email' in request.GET:","path":"src/sentry/web/frontend/accounts.py","position":null,"original_position":6,"commit_id":"31f5c2673f9f12760a7d81a89efda0f5e331a55f","original_commit_id":"58f56c21e326a3a4ef9ccdededd2aa1ce45c9feb","user":{"login":"kjlundsgaard","id":9269824,"avatar_url":"https://avatars.githubusercontent.com/u/9269824?v=3","gravatar_id":"","url":"https://api.github.com/users/kjlundsgaard","html_url":"https://github.com/kjlundsgaard","followers_url":"https://api.github.com/users/kjlundsgaard/followers","following_url":"https://api.github.com/users/kjlundsgaard/following{/other_user}","gists_url":"https://api.github.com/users/kjlundsgaard/gists{/gist_id}","starred_url":"https://api.github.com/users/kjlundsgaard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kjlundsgaard/subscriptions","organizations_url":"https://api.github.com/users/kjlundsgaard/orgs","repos_url":"https://api.github.com/users/kjlundsgaard/repos","events_url":"https://api.github.com/users/kjlundsgaard/events{/privacy}","received_events_url":"https://api.github.com/users/kjlundsgaard/received_events","type":"User","site_admin":false},"body":"I went ahead and created a separate method for sending the confirmation for primary email since the primary email value doesn't change and therefore doesn't need to be passed as a parameter. With this change, would this still run the risk of causing emails to be generated?","created_at":"2016-10-17T19:42:47Z","updated_at":"2016-10-17T19:42:47Z","html_url":"https://github.com/getsentry/sentry/pull/4358#discussion_r83718172","pull_request_url":"https://api.github.com/repos/getsentry/sentry/pulls/4358","_links":{"self":{"href":"https://api.github.com/repos/getsentry/sentry/pulls/comments/83718172"},"html":{"href":"https://github.com/getsentry/sentry/pull/4358#discussion_r83718172"},"pull_request":{"href":"https://api.github.com/repos/getsentry/sentry/pulls/4358"}}},"pull_request":{"url":"https://api.github.com/repos/getsentry/sentry/pulls/4358","id":89301145,"html_url":"https://github.com/getsentry/sentry/pull/4358","diff_url":"https://github.com/getsentry/sentry/pull/4358.diff","patch_url":"https://github.com/getsentry/sentry/pull/4358.patch","issue_url":"https://api.github.com/repos/getsentry/sentry/issues/4358","number":4358,"state":"open","locked":false,"title":"Make it so verification is sent to specific emails upon adding them","user":{"login":"kjlundsgaard","id":9269824,"avatar_url":"https://avatars.githubusercontent.com/u/9269824?v=3","gravatar_id":"","url":"https://api.github.com/users/kjlundsgaard","html_url":"https://github.com/kjlundsgaard","followers_url":"https://api.github.com/users/kjlundsgaard/followers","following_url":"https://api.github.com/users/kjlundsgaard/following{/other_user}","gists_url":"https://api.github.com/users/kjlundsgaard/gists{/gist_id}","starred_url":"https://api.github.com/users/kjlundsgaard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kjlundsgaard/subscriptions","organizations_url":"https://api.github.com/users/kjlundsgaard/orgs","repos_url":"https://api.github.com/users/kjlundsgaard/repos","events_url":"https://api.github.com/users/kjlundsgaard/events{/privacy}","received_events_url":"https://api.github.com/users/kjlundsgaard/received_events","type":"User","site_admin":false},"body":"This makes it so that whenever a new email is added, the verification email should only be sent to that email. It also allows you to only send a verification email to your primary email from account settings, but clicking resend verification emails in the emails tab still sends to all unverified emails.\r\n\r\n@getsentry/platform ","created_at":"2016-10-13T23:28:50Z","updated_at":"2016-10-17T19:42:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"775dbc3b4172e2e45376c220ad94de23c8223780","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/getsentry/sentry/pulls/4358/commits","review_comments_url":"https://api.github.com/repos/getsentry/sentry/pulls/4358/comments","review_comment_url":"https://api.github.com/repos/getsentry/sentry/pulls/comments{/number}","comments_url":"https://api.github.com/repos/getsentry/sentry/issues/4358/comments","statuses_url":"https://api.github.com/repos/getsentry/sentry/statuses/31f5c2673f9f12760a7d81a89efda0f5e331a55f","head":{"label":"getsentry:send-separate-emails","ref":"send-separate-emails","sha":"31f5c2673f9f12760a7d81a89efda0f5e331a55f","user":{"login":"getsentry","id":1396951,"avatar_url":"https://avatars.githubusercontent.com/u/1396951?v=3","gravatar_id":"","url":"https://api.github.com/users/getsentry","html_url":"https://github.com/getsentry","followers_url":"https://api.github.com/users/getsentry/followers","following_url":"https://api.github.com/users/getsentry/following{/other_user}","gists_url":"https://api.github.com/users/getsentry/gists{/gist_id}","starred_url":"https://api.github.com/users/getsentry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getsentry/subscriptions","organizations_url":"https://api.github.com/users/getsentry/orgs","repos_url":"https://api.github.com/users/getsentry/repos","events_url":"https://api.github.com/users/getsentry/events{/privacy}","received_events_url":"https://api.github.com/users/getsentry/received_events","type":"Organization","site_admin":false},"repo":{"id":873328,"name":"sentry","full_name":"getsentry/sentry","owner":{"login":"getsentry","id":1396951,"avatar_url":"https://avatars.githubusercontent.com/u/1396951?v=3","gravatar_id":"","url":"https://api.github.com/users/getsentry","html_url":"https://github.com/getsentry","followers_url":"https://api.github.com/users/getsentry/followers","following_url":"https://api.github.com/users/getsentry/following{/other_user}","gists_url":"https://api.github.com/users/getsentry/gists{/gist_id}","starred_url":"https://api.github.com/users/getsentry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getsentry/subscriptions","organizations_url":"https://api.github.com/users/getsentry/orgs","repos_url":"https://api.github.com/users/getsentry/repos","events_url":"https://api.github.com/users/getsentry/events{/privacy}","received_events_url":"https://api.github.com/users/getsentry/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/getsentry/sentry","description":"Sentry is cross-platform crash reporting built with love","fork":false,"url":"https://api.github.com/repos/getsentry/sentry","forks_url":"https://api.github.com/repos/getsentry/sentry/forks","keys_url":"https://api.github.com/repos/getsentry/sentry/keys{/key_id}","collaborators_url":"https://api.github.com/repos/getsentry/sentry/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/getsentry/sentry/teams","hooks_url":"https://api.github.com/repos/getsentry/sentry/hooks","issue_events_url":"https://api.github.com/repos/getsentry/sentry/issues/events{/number}","events_url":"https://api.github.com/repos/getsentry/sentry/events","assignees_url":"https://api.github.com/repos/getsentry/sentry/assignees{/user}","branches_url":"https://api.github.com/repos/getsentry/sentry/branches{/branch}","tags_url":"https://api.github.com/repos/getsentry/sentry/tags","blobs_url":"https://api.github.com/repos/getsentry/sentry/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/getsentry/sentry/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/getsentry/sentry/git/refs{/sha}","trees_url":"https://api.github.com/repos/getsentry/sentry/git/trees{/sha}","statuses_url":"https://api.github.com/repos/getsentry/sentry/statuses/{sha}","languages_url":"https://api.github.com/repos/getsentry/sentry/languages","stargazers_url":"https://api.github.com/repos/getsentry/sentry/stargazers","contributors_url":"https://api.github.com/repos/getsentry/sentry/contributors","subscribers_url":"https://api.github.com/repos/getsentry/sentry/subscribers","subscription_url":"https://api.github.com/repos/getsentry/sentry/subscription","commits_url":"https://api.github.com/repos/getsentry/sentry/commits{/sha}","git_commits_url":"https://api.github.com/repos/getsentry/sentry/git/commits{/sha}","comments_url":"https://api.github.com/repos/getsentry/sentry/comments{/number}","issue_comment_url":"https://api.github.com/repos/getsentry/sentry/issues/comments{/number}","contents_url":"https://api.github.com/repos/getsentry/sentry/contents/{+path}","compare_url":"https://api.github.com/repos/getsentry/sentry/compare/{base}...{head}","merges_url":"https://api.github.com/repos/getsentry/sentry/merges","archive_url":"https://api.github.com/repos/getsentry/sentry/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/getsentry/sentry/downloads","issues_url":"https://api.github.com/repos/getsentry/sentry/issues{/number}","pulls_url":"https://api.github.com/repos/getsentry/sentry/pulls{/number}","milestones_url":"https://api.github.com/repos/getsentry/sentry/milestones{/number}","notifications_url":"https://api.github.com/repos/getsentry/sentry/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/getsentry/sentry/labels{/name}","releases_url":"https://api.github.com/repos/getsentry/sentry/releases{/id}","deployments_url":"https://api.github.com/repos/getsentry/sentry/deployments","created_at":"2010-08-30T22:06:41Z","updated_at":"2016-10-17T17:08:38Z","pushed_at":"2016-10-17T19:34:06Z","git_url":"git://github.com/getsentry/sentry.git","ssh_url":"git@github.com:getsentry/sentry.git","clone_url":"https://github.com/getsentry/sentry.git","svn_url":"https://github.com/getsentry/sentry","homepage":"https://sentry.io","size":88639,"stargazers_count":10635,"watchers_count":10635,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1258,"mirror_url":null,"open_issues_count":429,"forks":1258,"open_issues":429,"watchers":10635,"default_branch":"master"}},"base":{"label":"getsentry:master","ref":"master","sha":"686c357871b326ce44c2a00a7bd59f96d2365d63","user":{"login":"getsentry","id":1396951,"avatar_url":"https://avatars.githubusercontent.com/u/1396951?v=3","gravatar_id":"","url":"https://api.github.com/users/getsentry","html_url":"https://github.com/getsentry","followers_url":"https://api.github.com/users/getsentry/followers","following_url":"https://api.github.com/users/getsentry/following{/other_user}","gists_url":"https://api.github.com/users/getsentry/gists{/gist_id}","starred_url":"https://api.github.com/users/getsentry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getsentry/subscriptions","organizations_url":"https://api.github.com/users/getsentry/orgs","repos_url":"https://api.github.com/users/getsentry/repos","events_url":"https://api.github.com/users/getsentry/events{/privacy}","received_events_url":"https://api.github.com/users/getsentry/received_events","type":"Organization","site_admin":false},"repo":{"id":873328,"name":"sentry","full_name":"getsentry/sentry","owner":{"login":"getsentry","id":1396951,"avatar_url":"https://avatars.githubusercontent.com/u/1396951?v=3","gravatar_id":"","url":"https://api.github.com/users/getsentry","html_url":"https://github.com/getsentry","followers_url":"https://api.github.com/users/getsentry/followers","following_url":"https://api.github.com/users/getsentry/following{/other_user}","gists_url":"https://api.github.com/users/getsentry/gists{/gist_id}","starred_url":"https://api.github.com/users/getsentry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getsentry/subscriptions","organizations_url":"https://api.github.com/users/getsentry/orgs","repos_url":"https://api.github.com/users/getsentry/repos","events_url":"https://api.github.com/users/getsentry/events{/privacy}","received_events_url":"https://api.github.com/users/getsentry/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/getsentry/sentry","description":"Sentry is cross-platform crash reporting built with love","fork":false,"url":"https://api.github.com/repos/getsentry/sentry","forks_url":"https://api.github.com/repos/getsentry/sentry/forks","keys_url":"https://api.github.com/repos/getsentry/sentry/keys{/key_id}","collaborators_url":"https://api.github.com/repos/getsentry/sentry/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/getsentry/sentry/teams","hooks_url":"https://api.github.com/repos/getsentry/sentry/hooks","issue_events_url":"https://api.github.com/repos/getsentry/sentry/issues/events{/number}","events_url":"https://api.github.com/repos/getsentry/sentry/events","assignees_url":"https://api.github.com/repos/getsentry/sentry/assignees{/user}","branches_url":"https://api.github.com/repos/getsentry/sentry/branches{/branch}","tags_url":"https://api.github.com/repos/getsentry/sentry/tags","blobs_url":"https://api.github.com/repos/getsentry/sentry/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/getsentry/sentry/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/getsentry/sentry/git/refs{/sha}","trees_url":"https://api.github.com/repos/getsentry/sentry/git/trees{/sha}","statuses_url":"https://api.github.com/repos/getsentry/sentry/statuses/{sha}","languages_url":"https://api.github.com/repos/getsentry/sentry/languages","stargazers_url":"https://api.github.com/repos/getsentry/sentry/stargazers","contributors_url":"https://api.github.com/repos/getsentry/sentry/contributors","subscribers_url":"https://api.github.com/repos/getsentry/sentry/subscribers","subscription_url":"https://api.github.com/repos/getsentry/sentry/subscription","commits_url":"https://api.github.com/repos/getsentry/sentry/commits{/sha}","git_commits_url":"https://api.github.com/repos/getsentry/sentry/git/commits{/sha}","comments_url":"https://api.github.com/repos/getsentry/sentry/comments{/number}","issue_comment_url":"https://api.github.com/repos/getsentry/sentry/issues/comments{/number}","contents_url":"https://api.github.com/repos/getsentry/sentry/contents/{+path}","compare_url":"https://api.github.com/repos/getsentry/sentry/compare/{base}...{head}","merges_url":"https://api.github.com/repos/getsentry/sentry/merges","archive_url":"https://api.github.com/repos/getsentry/sentry/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/getsentry/sentry/downloads","issues_url":"https://api.github.com/repos/getsentry/sentry/issues{/number}","pulls_url":"https://api.github.com/repos/getsentry/sentry/pulls{/number}","milestones_url":"https://api.github.com/repos/getsentry/sentry/milestones{/number}","notifications_url":"https://api.github.com/repos/getsentry/sentry/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/getsentry/sentry/labels{/name}","releases_url":"https://api.github.com/repos/getsentry/sentry/releases{/id}","deployments_url":"https://api.github.com/repos/getsentry/sentry/deployments","created_at":"2010-08-30T22:06:41Z","updated_at":"2016-10-17T17:08:38Z","pushed_at":"2016-10-17T19:34:06Z","git_url":"git://github.com/getsentry/sentry.git","ssh_url":"git@github.com:getsentry/sentry.git","clone_url":"https://github.com/getsentry/sentry.git","svn_url":"https://github.com/getsentry/sentry","homepage":"https://sentry.io","size":88639,"stargazers_count":10635,"watchers_count":10635,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1258,"mirror_url":null,"open_issues_count":429,"forks":1258,"open_issues":429,"watchers":10635,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/getsentry/sentry/pulls/4358"},"html":{"href":"https://github.com/getsentry/sentry/pull/4358"},"issue":{"href":"https://api.github.com/repos/getsentry/sentry/issues/4358"},"comments":{"href":"https://api.github.com/repos/getsentry/sentry/issues/4358/comments"},"review_comments":{"href":"https://api.github.com/repos/getsentry/sentry/pulls/4358/comments"},"review_comment":{"href":"https://api.github.com/repos/getsentry/sentry/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/getsentry/sentry/pulls/4358/commits"},"statuses":{"href":"https://api.github.com/repos/getsentry/sentry/statuses/31f5c2673f9f12760a7d81a89efda0f5e331a55f"}}}}
{"actor":{"display_login":"kjlundsgaard"}}