{"action":"closed","number":1098,"pull_request":{"url":"https://api.github.com/repos/fastlane/fastlane/pulls/1098","id":56031990,"html_url":"https://github.com/fastlane/fastlane/pull/1098","diff_url":"https://github.com/fastlane/fastlane/pull/1098.diff","patch_url":"https://github.com/fastlane/fastlane/pull/1098.patch","issue_url":"https://api.github.com/repos/fastlane/fastlane/issues/1098","number":1098,"state":"closed","locked":false,"title":"Support multiple ignore paths for slather action","user":{"login":"mgrebenets","id":350654,"avatar_url":"https://avatars.githubusercontent.com/u/350654?v=3","gravatar_id":"","url":"https://api.github.com/users/mgrebenets","html_url":"https://github.com/mgrebenets","followers_url":"https://api.github.com/users/mgrebenets/followers","following_url":"https://api.github.com/users/mgrebenets/following{/other_user}","gists_url":"https://api.github.com/users/mgrebenets/gists{/gist_id}","starred_url":"https://api.github.com/users/mgrebenets/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgrebenets/subscriptions","organizations_url":"https://api.github.com/users/mgrebenets/orgs","repos_url":"https://api.github.com/users/mgrebenets/repos","events_url":"https://api.github.com/users/mgrebenets/events{/privacy}","received_events_url":"https://api.github.com/users/mgrebenets/received_events","type":"User","site_admin":false},"body":"With these changes it's possible to specify multiple ignore paths as an array as well as keep backwards compatibility and use just a string.\r\n\r\n\r\n```ruby\r\n    slather(\r\n        proj: \"project\",\r\n        scheme: \"scheme\",\r\n        input_format: \"profdata\",\r\n        ignore: [\"Pods/*\", \"../**/*/Xcode*\"],\r\n       # ignore: \"Pods/*\", # also works\r\n        simple_output: true\r\n    )\r\n```\r\n\r\nThis change also adds quotes when composing shell command, so it's becomes `--ignore \"../**/*/Xcode*\"` instead of `--ignore ../**/*/Xcode*`, which causes some troubles.\r\n\r\nWhat do you think @mattdelves ?\r\n","created_at":"2016-01-14T13:00:45Z","updated_at":"2016-01-24T22:30:56Z","closed_at":"2016-01-24T22:30:56Z","merged_at":"2016-01-24T22:30:56Z","merge_commit_sha":"9159d6fd93dec3f78b23e8323af73b8c6ef8e2c4","assignee":{"login":"ohwutup","id":2587018,"avatar_url":"https://avatars.githubusercontent.com/u/2587018?v=3","gravatar_id":"","url":"https://api.github.com/users/ohwutup","html_url":"https://github.com/ohwutup","followers_url":"https://api.github.com/users/ohwutup/followers","following_url":"https://api.github.com/users/ohwutup/following{/other_user}","gists_url":"https://api.github.com/users/ohwutup/gists{/gist_id}","starred_url":"https://api.github.com/users/ohwutup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ohwutup/subscriptions","organizations_url":"https://api.github.com/users/ohwutup/orgs","repos_url":"https://api.github.com/users/ohwutup/repos","events_url":"https://api.github.com/users/ohwutup/events{/privacy}","received_events_url":"https://api.github.com/users/ohwutup/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/fastlane/fastlane/pulls/1098/commits","review_comments_url":"https://api.github.com/repos/fastlane/fastlane/pulls/1098/comments","review_comment_url":"https://api.github.com/repos/fastlane/fastlane/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fastlane/fastlane/issues/1098/comments","statuses_url":"https://api.github.com/repos/fastlane/fastlane/statuses/f3318a7ca79fc2b8a5b6ea07b3dcb3fd6000b87e","head":{"label":"mgrebenets:feature/multiple-ignore-paths-for-slather","ref":"feature/multiple-ignore-paths-for-slather","sha":"f3318a7ca79fc2b8a5b6ea07b3dcb3fd6000b87e","user":{"login":"mgrebenets","id":350654,"avatar_url":"https://avatars.githubusercontent.com/u/350654?v=3","gravatar_id":"","url":"https://api.github.com/users/mgrebenets","html_url":"https://github.com/mgrebenets","followers_url":"https://api.github.com/users/mgrebenets/followers","following_url":"https://api.github.com/users/mgrebenets/following{/other_user}","gists_url":"https://api.github.com/users/mgrebenets/gists{/gist_id}","starred_url":"https://api.github.com/users/mgrebenets/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgrebenets/subscriptions","organizations_url":"https://api.github.com/users/mgrebenets/orgs","repos_url":"https://api.github.com/users/mgrebenets/repos","events_url":"https://api.github.com/users/mgrebenets/events{/privacy}","received_events_url":"https://api.github.com/users/mgrebenets/received_events","type":"User","site_admin":false},"repo":{"id":49501976,"name":"fastlane","full_name":"mgrebenets/fastlane","owner":{"login":"mgrebenets","id":350654,"avatar_url":"https://avatars.githubusercontent.com/u/350654?v=3","gravatar_id":"","url":"https://api.github.com/users/mgrebenets","html_url":"https://github.com/mgrebenets","followers_url":"https://api.github.com/users/mgrebenets/followers","following_url":"https://api.github.com/users/mgrebenets/following{/other_user}","gists_url":"https://api.github.com/users/mgrebenets/gists{/gist_id}","starred_url":"https://api.github.com/users/mgrebenets/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgrebenets/subscriptions","organizations_url":"https://api.github.com/users/mgrebenets/orgs","repos_url":"https://api.github.com/users/mgrebenets/repos","events_url":"https://api.github.com/users/mgrebenets/events{/privacy}","received_events_url":"https://api.github.com/users/mgrebenets/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mgrebenets/fastlane","description":"Connect all iOS deployment tools into one streamlined workflow","fork":true,"url":"https://api.github.com/repos/mgrebenets/fastlane","forks_url":"https://api.github.com/repos/mgrebenets/fastlane/forks","keys_url":"https://api.github.com/repos/mgrebenets/fastlane/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mgrebenets/fastlane/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mgrebenets/fastlane/teams","hooks_url":"https://api.github.com/repos/mgrebenets/fastlane/hooks","issue_events_url":"https://api.github.com/repos/mgrebenets/fastlane/issues/events{/number}","events_url":"https://api.github.com/repos/mgrebenets/fastlane/events","assignees_url":"https://api.github.com/repos/mgrebenets/fastlane/assignees{/user}","branches_url":"https://api.github.com/repos/mgrebenets/fastlane/branches{/branch}","tags_url":"https://api.github.com/repos/mgrebenets/fastlane/tags","blobs_url":"https://api.github.com/repos/mgrebenets/fastlane/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mgrebenets/fastlane/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mgrebenets/fastlane/git/refs{/sha}","trees_url":"https://api.github.com/repos/mgrebenets/fastlane/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mgrebenets/fastlane/statuses/{sha}","languages_url":"https://api.github.com/repos/mgrebenets/fastlane/languages","stargazers_url":"https://api.github.com/repos/mgrebenets/fastlane/stargazers","contributors_url":"https://api.github.com/repos/mgrebenets/fastlane/contributors","subscribers_url":"https://api.github.com/repos/mgrebenets/fastlane/subscribers","subscription_url":"https://api.github.com/repos/mgrebenets/fastlane/subscription","commits_url":"https://api.github.com/repos/mgrebenets/fastlane/commits{/sha}","git_commits_url":"https://api.github.com/repos/mgrebenets/fastlane/git/commits{/sha}","comments_url":"https://api.github.com/repos/mgrebenets/fastlane/comments{/number}","issue_comment_url":"https://api.github.com/repos/mgrebenets/fastlane/issues/comments{/number}","contents_url":"https://api.github.com/repos/mgrebenets/fastlane/contents/{+path}","compare_url":"https://api.github.com/repos/mgrebenets/fastlane/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mgrebenets/fastlane/merges","archive_url":"https://api.github.com/repos/mgrebenets/fastlane/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mgrebenets/fastlane/downloads","issues_url":"https://api.github.com/repos/mgrebenets/fastlane/issues{/number}","pulls_url":"https://api.github.com/repos/mgrebenets/fastlane/pulls{/number}","milestones_url":"https://api.github.com/repos/mgrebenets/fastlane/milestones{/number}","notifications_url":"https://api.github.com/repos/mgrebenets/fastlane/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mgrebenets/fastlane/labels{/name}","releases_url":"https://api.github.com/repos/mgrebenets/fastlane/releases{/id}","deployments_url":"https://api.github.com/repos/mgrebenets/fastlane/deployments","created_at":"2016-01-12T13:33:12Z","updated_at":"2016-01-12T13:33:15Z","pushed_at":"2016-01-24T08:10:13Z","git_url":"git://github.com/mgrebenets/fastlane.git","ssh_url":"git@github.com:mgrebenets/fastlane.git","clone_url":"https://github.com/mgrebenets/fastlane.git","svn_url":"https://github.com/mgrebenets/fastlane","homepage":"https://fastlane.tools","size":3799,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fastlane:master","ref":"master","sha":"e31d2749dcf961cb91313f76eb4caa8ce7db82ad","user":{"login":"fastlane","id":11098337,"avatar_url":"https://avatars.githubusercontent.com/u/11098337?v=3","gravatar_id":"","url":"https://api.github.com/users/fastlane","html_url":"https://github.com/fastlane","followers_url":"https://api.github.com/users/fastlane/followers","following_url":"https://api.github.com/users/fastlane/following{/other_user}","gists_url":"https://api.github.com/users/fastlane/gists{/gist_id}","starred_url":"https://api.github.com/users/fastlane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fastlane/subscriptions","organizations_url":"https://api.github.com/users/fastlane/orgs","repos_url":"https://api.github.com/users/fastlane/repos","events_url":"https://api.github.com/users/fastlane/events{/privacy}","received_events_url":"https://api.github.com/users/fastlane/received_events","type":"Organization","site_admin":false},"repo":{"id":27442967,"name":"fastlane","full_name":"fastlane/fastlane","owner":{"login":"fastlane","id":11098337,"avatar_url":"https://avatars.githubusercontent.com/u/11098337?v=3","gravatar_id":"","url":"https://api.github.com/users/fastlane","html_url":"https://github.com/fastlane","followers_url":"https://api.github.com/users/fastlane/followers","following_url":"https://api.github.com/users/fastlane/following{/other_user}","gists_url":"https://api.github.com/users/fastlane/gists{/gist_id}","starred_url":"https://api.github.com/users/fastlane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fastlane/subscriptions","organizations_url":"https://api.github.com/users/fastlane/orgs","repos_url":"https://api.github.com/users/fastlane/repos","events_url":"https://api.github.com/users/fastlane/events{/privacy}","received_events_url":"https://api.github.com/users/fastlane/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fastlane/fastlane","description":"Connect all iOS deployment tools into one streamlined workflow","fork":false,"url":"https://api.github.com/repos/fastlane/fastlane","forks_url":"https://api.github.com/repos/fastlane/fastlane/forks","keys_url":"https://api.github.com/repos/fastlane/fastlane/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fastlane/fastlane/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fastlane/fastlane/teams","hooks_url":"https://api.github.com/repos/fastlane/fastlane/hooks","issue_events_url":"https://api.github.com/repos/fastlane/fastlane/issues/events{/number}","events_url":"https://api.github.com/repos/fastlane/fastlane/events","assignees_url":"https://api.github.com/repos/fastlane/fastlane/assignees{/user}","branches_url":"https://api.github.com/repos/fastlane/fastlane/branches{/branch}","tags_url":"https://api.github.com/repos/fastlane/fastlane/tags","blobs_url":"https://api.github.com/repos/fastlane/fastlane/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fastlane/fastlane/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fastlane/fastlane/git/refs{/sha}","trees_url":"https://api.github.com/repos/fastlane/fastlane/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fastlane/fastlane/statuses/{sha}","languages_url":"https://api.github.com/repos/fastlane/fastlane/languages","stargazers_url":"https://api.github.com/repos/fastlane/fastlane/stargazers","contributors_url":"https://api.github.com/repos/fastlane/fastlane/contributors","subscribers_url":"https://api.github.com/repos/fastlane/fastlane/subscribers","subscription_url":"https://api.github.com/repos/fastlane/fastlane/subscription","commits_url":"https://api.github.com/repos/fastlane/fastlane/commits{/sha}","git_commits_url":"https://api.github.com/repos/fastlane/fastlane/git/commits{/sha}","comments_url":"https://api.github.com/repos/fastlane/fastlane/comments{/number}","issue_comment_url":"https://api.github.com/repos/fastlane/fastlane/issues/comments{/number}","contents_url":"https://api.github.com/repos/fastlane/fastlane/contents/{+path}","compare_url":"https://api.github.com/repos/fastlane/fastlane/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fastlane/fastlane/merges","archive_url":"https://api.github.com/repos/fastlane/fastlane/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fastlane/fastlane/downloads","issues_url":"https://api.github.com/repos/fastlane/fastlane/issues{/number}","pulls_url":"https://api.github.com/repos/fastlane/fastlane/pulls{/number}","milestones_url":"https://api.github.com/repos/fastlane/fastlane/milestones{/number}","notifications_url":"https://api.github.com/repos/fastlane/fastlane/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fastlane/fastlane/labels{/name}","releases_url":"https://api.github.com/repos/fastlane/fastlane/releases{/id}","deployments_url":"https://api.github.com/repos/fastlane/fastlane/deployments","created_at":"2014-12-02T17:00:38Z","updated_at":"2016-01-24T21:02:12Z","pushed_at":"2016-01-24T22:30:56Z","git_url":"git://github.com/fastlane/fastlane.git","ssh_url":"git@github.com:fastlane/fastlane.git","clone_url":"https://github.com/fastlane/fastlane.git","svn_url":"https://github.com/fastlane/fastlane","homepage":"https://fastlane.tools","size":6519,"stargazers_count":5281,"watchers_count":5281,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":591,"mirror_url":null,"open_issues_count":213,"forks":591,"open_issues":213,"watchers":5281,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fastlane/fastlane/pulls/1098"},"html":{"href":"https://github.com/fastlane/fastlane/pull/1098"},"issue":{"href":"https://api.github.com/repos/fastlane/fastlane/issues/1098"},"comments":{"href":"https://api.github.com/repos/fastlane/fastlane/issues/1098/comments"},"review_comments":{"href":"https://api.github.com/repos/fastlane/fastlane/pulls/1098/comments"},"review_comment":{"href":"https://api.github.com/repos/fastlane/fastlane/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fastlane/fastlane/pulls/1098/commits"},"statuses":{"href":"https://api.github.com/repos/fastlane/fastlane/statuses/f3318a7ca79fc2b8a5b6ea07b3dcb3fd6000b87e"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"ohwutup","id":2587018,"avatar_url":"https://avatars.githubusercontent.com/u/2587018?v=3","gravatar_id":"","url":"https://api.github.com/users/ohwutup","html_url":"https://github.com/ohwutup","followers_url":"https://api.github.com/users/ohwutup/followers","following_url":"https://api.github.com/users/ohwutup/following{/other_user}","gists_url":"https://api.github.com/users/ohwutup/gists{/gist_id}","starred_url":"https://api.github.com/users/ohwutup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ohwutup/subscriptions","organizations_url":"https://api.github.com/users/ohwutup/orgs","repos_url":"https://api.github.com/users/ohwutup/repos","events_url":"https://api.github.com/users/ohwutup/events{/privacy}","received_events_url":"https://api.github.com/users/ohwutup/received_events","type":"User","site_admin":false},"comments":10,"review_comments":9,"commits":1,"additions":39,"deletions":7,"changed_files":2}}