{"action":"created","issue":{"url":"https://api.github.com/repos/fb55/css-select/issues/41","repository_url":"https://api.github.com/repos/fb55/css-select","labels_url":"https://api.github.com/repos/fb55/css-select/issues/41/labels{/name}","comments_url":"https://api.github.com/repos/fb55/css-select/issues/41/comments","events_url":"https://api.github.com/repos/fb55/css-select/issues/41/events","html_url":"https://github.com/fb55/css-select/pull/41","id":156586153,"number":41,"title":"prevent errors on valid pseudo selectors","user":{"login":"Autarc","id":1060490,"avatar_url":"https://avatars.githubusercontent.com/u/1060490?v=3","gravatar_id":"","url":"https://api.github.com/users/Autarc","html_url":"https://github.com/Autarc","followers_url":"https://api.github.com/users/Autarc/followers","following_url":"https://api.github.com/users/Autarc/following{/other_user}","gists_url":"https://api.github.com/users/Autarc/gists{/gist_id}","starred_url":"https://api.github.com/users/Autarc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Autarc/subscriptions","organizations_url":"https://api.github.com/users/Autarc/orgs","repos_url":"https://api.github.com/users/Autarc/repos","events_url":"https://api.github.com/users/Autarc/events{/privacy}","received_events_url":"https://api.github.com/users/Autarc/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-05-24T19:10:27Z","updated_at":"2016-05-24T19:17:27Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/fb55/css-select/pulls/41","html_url":"https://github.com/fb55/css-select/pull/41","diff_url":"https://github.com/fb55/css-select/pull/41.diff","patch_url":"https://github.com/fb55/css-select/pull/41.patch"},"body":"Although the current version implements quite a few pseudo selectors and claims a `Full implementation of CSS3 selectors`, I just found out that this unfortunately not true for some common cases. So far [a simple regex based check](https://github.com/fb55/css-select/blob/master/lib/pseudos.js#L364) is used to determine valid pseudo selectors. Since this covers only the ones which are properly supported through a function, typical selectors like `:hover`, `:focus` or `::after` keep throwing a SyntaxError. With this update a more extensive lookup is used through [a helper](https://github.com/Autarc/is-pseudo) and even through there are no further matches, at least the call returns without an issue.\r\n\r\nIn addition I've added a `.gitignore` to avoid accidentally pushing `node_modules` :)"},"comment":{"url":"https://api.github.com/repos/fb55/css-select/issues/comments/221374530","html_url":"https://github.com/fb55/css-select/pull/41#issuecomment-221374530","issue_url":"https://api.github.com/repos/fb55/css-select/issues/41","id":221374530,"user":{"login":"coveralls","id":2354108,"avatar_url":"https://avatars.githubusercontent.com/u/2354108?v=3","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2016-05-24T19:17:27Z","updated_at":"2016-05-24T19:17:27Z","body":"\n[![Coverage Status](https://coveralls.io/builds/6314737/badge)](https://coveralls.io/builds/6314737)\n\nCoverage decreased (-0.5%) to 97.816% when pulling **86d989fa482dad037f9b8a65a630eebc6e2c55a1 on Autarc:master** into **ba0e5ae4312c54294221cfdefec99af74963465b on fb55:master**.\n"}}
{"actor":{"display_login":"coveralls"}}