{"action":"created","issue":{"url":"https://api.github.com/repos/graphite-project/graphite-web/issues/1630","repository_url":"https://api.github.com/repos/graphite-project/graphite-web","labels_url":"https://api.github.com/repos/graphite-project/graphite-web/issues/1630/labels{/name}","comments_url":"https://api.github.com/repos/graphite-project/graphite-web/issues/1630/comments","events_url":"https://api.github.com/repos/graphite-project/graphite-web/issues/1630/events","html_url":"https://github.com/graphite-project/graphite-web/pull/1630","id":168251251,"number":1630,"title":"Add nodelist format to metrics find view","user":{"login":"obfuscurity","id":494338,"avatar_url":"https://avatars.githubusercontent.com/u/494338?v=3","gravatar_id":"","url":"https://api.github.com/users/obfuscurity","html_url":"https://github.com/obfuscurity","followers_url":"https://api.github.com/users/obfuscurity/followers","following_url":"https://api.github.com/users/obfuscurity/following{/other_user}","gists_url":"https://api.github.com/users/obfuscurity/gists{/gist_id}","starred_url":"https://api.github.com/users/obfuscurity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obfuscurity/subscriptions","organizations_url":"https://api.github.com/users/obfuscurity/orgs","repos_url":"https://api.github.com/users/obfuscurity/repos","events_url":"https://api.github.com/users/obfuscurity/events{/privacy}","received_events_url":"https://api.github.com/users/obfuscurity/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/graphite-project/graphite-web/milestones/2","html_url":"https://github.com/graphite-project/graphite-web/milestones/1.0.0","labels_url":"https://api.github.com/repos/graphite-project/graphite-web/milestones/2/labels","id":258250,"number":2,"title":"1.0.0","description":"","creator":{"login":"mleinart","id":317999,"avatar_url":"https://avatars.githubusercontent.com/u/317999?v=3","gravatar_id":"","url":"https://api.github.com/users/mleinart","html_url":"https://github.com/mleinart","followers_url":"https://api.github.com/users/mleinart/followers","following_url":"https://api.github.com/users/mleinart/following{/other_user}","gists_url":"https://api.github.com/users/mleinart/gists{/gist_id}","starred_url":"https://api.github.com/users/mleinart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mleinart/subscriptions","organizations_url":"https://api.github.com/users/mleinart/orgs","repos_url":"https://api.github.com/users/mleinart/repos","events_url":"https://api.github.com/users/mleinart/events{/privacy}","received_events_url":"https://api.github.com/users/mleinart/received_events","type":"User","site_admin":false},"open_issues":31,"closed_issues":32,"state":"open","created_at":"2013-02-02T06:42:41Z","updated_at":"2016-07-29T05:03:32Z","due_on":null,"closed_at":null},"comments":4,"created_at":"2016-07-29T05:03:32Z","updated_at":"2016-07-29T13:50:32Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/graphite-project/graphite-web/pulls/1630","html_url":"https://github.com/graphite-project/graphite-web/pull/1630","diff_url":"https://github.com/graphite-project/graphite-web/pull/1630.diff","patch_url":"https://github.com/graphite-project/graphite-web/pull/1630.patch"},"body":"This is a new implementation of @toni-moreno's proposed change in https://github.com/graphite-project/graphite-web/pull/718. I believe this is a cleaner approach, extending `/metrics/find/` with a new `format=nodelist` parameter. The optional `position` parameter allows the user to override the default (`-1`) node index.\r\n\r\n/cc @brutasse @cbowman0 \r\n\r\n```\r\n$ curl -k \"https://127.0.0.1:443/metrics/find/?query=carbon.*.*.*&format=nodelist&position=2\"\r\n\"{'nodes': ['vagrant-1']}\"\r\n\r\n$ curl -k \"https://127.0.0.1:443/metrics/find/?query=carbon.*.*.*&format=nodelist\"\r\n\"{'nodes': ['activeConnections', 'avgUpdateTime', 'blacklistMatches', 'cache', 'committedPoints', 'cpuUsage', 'creates', 'droppedCreates', 'errors', 'memUsage', 'metricsReceived', 'pointsPerUpdate', 'updateOperations', 'whitelistRejects']}\"\r\n```"},"comment":{"url":"https://api.github.com/repos/graphite-project/graphite-web/issues/comments/236185371","html_url":"https://github.com/graphite-project/graphite-web/pull/1630#issuecomment-236185371","issue_url":"https://api.github.com/repos/graphite-project/graphite-web/issues/1630","id":236185371,"user":{"login":"obfuscurity","id":494338,"avatar_url":"https://avatars.githubusercontent.com/u/494338?v=3","gravatar_id":"","url":"https://api.github.com/users/obfuscurity","html_url":"https://github.com/obfuscurity","followers_url":"https://api.github.com/users/obfuscurity/followers","following_url":"https://api.github.com/users/obfuscurity/following{/other_user}","gists_url":"https://api.github.com/users/obfuscurity/gists{/gist_id}","starred_url":"https://api.github.com/users/obfuscurity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obfuscurity/subscriptions","organizations_url":"https://api.github.com/users/obfuscurity/orgs","repos_url":"https://api.github.com/users/obfuscurity/repos","events_url":"https://api.github.com/users/obfuscurity/events{/privacy}","received_events_url":"https://api.github.com/users/obfuscurity/received_events","type":"User","site_admin":false},"created_at":"2016-07-29T13:50:32Z","updated_at":"2016-07-29T13:50:32Z","body":"Note that removing the interpolation (which was mistakenly left in during debugging) also fixed JSON validation.\r\n\r\n```\r\ncurl -s -k \"https://127.0.0.1:443/metrics/find/?query=carbon.*.*.*&format=nodelist&position=2\" | json_pp\r\n{\r\n   \"nodes\" : [\r\n      \"vagrant-1\"\r\n   ]\r\n}\r\n\r\n$ curl -s -k \"https://127.0.0.1:443/metrics/find/?query=carbon.*.*.*&format=nodelist&position=-1\" | json_pp\r\n{\r\n   \"nodes\" : [\r\n      \"activeConnections\",\r\n      \"avgUpdateTime\",\r\n      \"blacklistMatches\",\r\n      \"cache\",\r\n      \"committedPoints\",\r\n      \"cpuUsage\",\r\n      \"creates\",\r\n      \"droppedCreates\",\r\n      \"errors\",\r\n      \"memUsage\",\r\n      \"metricsReceived\",\r\n      \"pointsPerUpdate\",\r\n      \"updateOperations\",\r\n      \"whitelistRejects\"\r\n   ]\r\n}\r\n```"}}
{"actor":{"display_login":"obfuscurity"}}