{"action":"closed","number":2088,"pull_request":{"url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/2088","id":95106048,"html_url":"https://github.com/Microsoft/ChakraCore/pull/2088","diff_url":"https://github.com/Microsoft/ChakraCore/pull/2088.diff","patch_url":"https://github.com/Microsoft/ChakraCore/pull/2088.patch","issue_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/2088","number":2088,"state":"closed","locked":false,"title":"xplat: don't use private heap","user":{"login":"ianwjhalliday","id":906649,"avatar_url":"https://avatars.githubusercontent.com/u/906649?v=3","gravatar_id":"","url":"https://api.github.com/users/ianwjhalliday","html_url":"https://github.com/ianwjhalliday","followers_url":"https://api.github.com/users/ianwjhalliday/followers","following_url":"https://api.github.com/users/ianwjhalliday/following{/other_user}","gists_url":"https://api.github.com/users/ianwjhalliday/gists{/gist_id}","starred_url":"https://api.github.com/users/ianwjhalliday/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianwjhalliday/subscriptions","organizations_url":"https://api.github.com/users/ianwjhalliday/orgs","repos_url":"https://api.github.com/users/ianwjhalliday/repos","events_url":"https://api.github.com/users/ianwjhalliday/events{/privacy}","received_events_url":"https://api.github.com/users/ianwjhalliday/received_events","type":"User","site_admin":false},"body":"Do not use private heap on xplat.\r\n\r\nCurrently with our static linking in node-chakracore our overridden new/delete operators are picked up by node itself.  Use of the private heap leads to instability on shutdown due to the chance that HeapAllocator::Instance is disposed before other allocations.  Using alloc and free instead circumvents this problem.","created_at":"2016-11-24T01:54:05Z","updated_at":"2016-11-24T04:02:13Z","closed_at":"2016-11-24T04:02:13Z","merged_at":"2016-11-24T04:02:13Z","merge_commit_sha":"83917596c474dab492f61241370b8fbfc4b98b9a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/2088/commits","review_comments_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/2088/comments","review_comment_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/2088/comments","statuses_url":"https://api.github.com/repos/Microsoft/ChakraCore/statuses/83917596c474dab492f61241370b8fbfc4b98b9a","head":{"label":"ianwjhalliday:release/2.0-pre","ref":"release/2.0-pre","sha":"83917596c474dab492f61241370b8fbfc4b98b9a","user":{"login":"ianwjhalliday","id":906649,"avatar_url":"https://avatars.githubusercontent.com/u/906649?v=3","gravatar_id":"","url":"https://api.github.com/users/ianwjhalliday","html_url":"https://github.com/ianwjhalliday","followers_url":"https://api.github.com/users/ianwjhalliday/followers","following_url":"https://api.github.com/users/ianwjhalliday/following{/other_user}","gists_url":"https://api.github.com/users/ianwjhalliday/gists{/gist_id}","starred_url":"https://api.github.com/users/ianwjhalliday/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianwjhalliday/subscriptions","organizations_url":"https://api.github.com/users/ianwjhalliday/orgs","repos_url":"https://api.github.com/users/ianwjhalliday/repos","events_url":"https://api.github.com/users/ianwjhalliday/events{/privacy}","received_events_url":"https://api.github.com/users/ianwjhalliday/received_events","type":"User","site_admin":false},"repo":{"id":49596782,"name":"ChakraCore","full_name":"ianwjhalliday/ChakraCore","owner":{"login":"ianwjhalliday","id":906649,"avatar_url":"https://avatars.githubusercontent.com/u/906649?v=3","gravatar_id":"","url":"https://api.github.com/users/ianwjhalliday","html_url":"https://github.com/ianwjhalliday","followers_url":"https://api.github.com/users/ianwjhalliday/followers","following_url":"https://api.github.com/users/ianwjhalliday/following{/other_user}","gists_url":"https://api.github.com/users/ianwjhalliday/gists{/gist_id}","starred_url":"https://api.github.com/users/ianwjhalliday/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianwjhalliday/subscriptions","organizations_url":"https://api.github.com/users/ianwjhalliday/orgs","repos_url":"https://api.github.com/users/ianwjhalliday/repos","events_url":"https://api.github.com/users/ianwjhalliday/events{/privacy}","received_events_url":"https://api.github.com/users/ianwjhalliday/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ianwjhalliday/ChakraCore","description":"ChakraCore is the core part of the Chakra Javascript engine that powers Microsoft Edge","fork":true,"url":"https://api.github.com/repos/ianwjhalliday/ChakraCore","forks_url":"https://api.github.com/repos/ianwjhalliday/ChakraCore/forks","keys_url":"https://api.github.com/repos/ianwjhalliday/ChakraCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ianwjhalliday/ChakraCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ianwjhalliday/ChakraCore/teams","hooks_url":"https://api.github.com/repos/ianwjhalliday/ChakraCore/hooks","issue_events_url":"https://api.github.com/repos/ianwjhalliday/ChakraCore/issues/events{/number}","events_url":"https://api.github.com/repos/ianwjhalliday/ChakraCore/events","assignees_url":"https://api.github.com/repos/ianwjhalliday/ChakraCore/assignees{/user}","branches_url":"https://api.github.com/repos/ianwjhalliday/ChakraCore/branches{/branch}","tags_url":"https://api.github.com/repos/ianwjhalliday/ChakraCore/tags","blobs_url":"https://api.github.com/repos/ianwjhalliday/ChakraCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ianwjhalliday/ChakraCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ianwjhalliday/ChakraCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/ianwjhalliday/ChakraCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ianwjhalliday/ChakraCore/statuses/{sha}","languages_url":"https://api.github.com/repos/ianwjhalliday/ChakraCore/languages","stargazers_url":"https://api.github.com/repos/ianwjhalliday/ChakraCore/stargazers","contributors_url":"https://api.github.com/repos/ianwjhalliday/ChakraCore/contributors","subscribers_url":"https://api.github.com/repos/ianwjhalliday/ChakraCore/subscribers","subscription_url":"https://api.github.com/repos/ianwjhalliday/ChakraCore/subscription","commits_url":"https://api.github.com/repos/ianwjhalliday/ChakraCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/ianwjhalliday/ChakraCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/ianwjhalliday/ChakraCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/ianwjhalliday/ChakraCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/ianwjhalliday/ChakraCore/contents/{+path}","compare_url":"https://api.github.com/repos/ianwjhalliday/ChakraCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ianwjhalliday/ChakraCore/merges","archive_url":"https://api.github.com/repos/ianwjhalliday/ChakraCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ianwjhalliday/ChakraCore/downloads","issues_url":"https://api.github.com/repos/ianwjhalliday/ChakraCore/issues{/number}","pulls_url":"https://api.github.com/repos/ianwjhalliday/ChakraCore/pulls{/number}","milestones_url":"https://api.github.com/repos/ianwjhalliday/ChakraCore/milestones{/number}","notifications_url":"https://api.github.com/repos/ianwjhalliday/ChakraCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ianwjhalliday/ChakraCore/labels{/name}","releases_url":"https://api.github.com/repos/ianwjhalliday/ChakraCore/releases{/id}","deployments_url":"https://api.github.com/repos/ianwjhalliday/ChakraCore/deployments","created_at":"2016-01-13T19:33:09Z","updated_at":"2016-11-15T03:02:30Z","pushed_at":"2016-11-24T01:52:48Z","git_url":"git://github.com/ianwjhalliday/ChakraCore.git","ssh_url":"git@github.com:ianwjhalliday/ChakraCore.git","clone_url":"https://github.com/ianwjhalliday/ChakraCore.git","svn_url":"https://github.com/ianwjhalliday/ChakraCore","homepage":null,"size":48411,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:release/2.0-pre","ref":"release/2.0-pre","sha":"f6f706c526e177b7e846506bc7e8ef1521ae5877","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":49086513,"name":"ChakraCore","full_name":"Microsoft/ChakraCore","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/ChakraCore","description":"ChakraCore is the core part of the Chakra Javascript engine that powers Microsoft Edge","fork":false,"url":"https://api.github.com/repos/Microsoft/ChakraCore","forks_url":"https://api.github.com/repos/Microsoft/ChakraCore/forks","keys_url":"https://api.github.com/repos/Microsoft/ChakraCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/ChakraCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/ChakraCore/teams","hooks_url":"https://api.github.com/repos/Microsoft/ChakraCore/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/ChakraCore/events","assignees_url":"https://api.github.com/repos/Microsoft/ChakraCore/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/ChakraCore/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/ChakraCore/tags","blobs_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/ChakraCore/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/ChakraCore/languages","stargazers_url":"https://api.github.com/repos/Microsoft/ChakraCore/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/ChakraCore/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/ChakraCore/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/ChakraCore/subscription","commits_url":"https://api.github.com/repos/Microsoft/ChakraCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/ChakraCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/ChakraCore/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/ChakraCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/ChakraCore/merges","archive_url":"https://api.github.com/repos/Microsoft/ChakraCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/ChakraCore/downloads","issues_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/ChakraCore/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/ChakraCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/ChakraCore/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/ChakraCore/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/ChakraCore/deployments","created_at":"2016-01-05T19:05:31Z","updated_at":"2016-11-24T02:30:01Z","pushed_at":"2016-11-24T04:02:12Z","git_url":"git://github.com/Microsoft/ChakraCore.git","ssh_url":"git@github.com:Microsoft/ChakraCore.git","clone_url":"https://github.com/Microsoft/ChakraCore.git","svn_url":"https://github.com/Microsoft/ChakraCore","homepage":null,"size":61768,"stargazers_count":5772,"watchers_count":5772,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":662,"mirror_url":null,"open_issues_count":193,"forks":662,"open_issues":193,"watchers":5772,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/2088"},"html":{"href":"https://github.com/Microsoft/ChakraCore/pull/2088"},"issue":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/issues/2088"},"comments":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/issues/2088/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/2088/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/2088/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/statuses/83917596c474dab492f61241370b8fbfc4b98b9a"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"chakrabot","id":14987435,"avatar_url":"https://avatars.githubusercontent.com/u/14987435?v=3","gravatar_id":"","url":"https://api.github.com/users/chakrabot","html_url":"https://github.com/chakrabot","followers_url":"https://api.github.com/users/chakrabot/followers","following_url":"https://api.github.com/users/chakrabot/following{/other_user}","gists_url":"https://api.github.com/users/chakrabot/gists{/gist_id}","starred_url":"https://api.github.com/users/chakrabot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chakrabot/subscriptions","organizations_url":"https://api.github.com/users/chakrabot/orgs","repos_url":"https://api.github.com/users/chakrabot/repos","events_url":"https://api.github.com/users/chakrabot/events{/privacy}","received_events_url":"https://api.github.com/users/chakrabot/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":1,"additions":5,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"chakrabot"}}