{"action":"created","comment":{"url":"https://api.github.com/repos/4teamwork/ftw-buildouts/pulls/comments/77988342","id":77988342,"diff_hunk":"@@ -0,0 +1,81 @@\n+# Redis base configuration.\n+# Use development.cfg or production.cfg, not base.cfg directly.\n+\n+[redis-settings]\n+# port = # set by development.cfg or production.cfg\n+# redis-version = # set by [version].cfg\n+bind = 127.0.0.1\n+timeout = 0\n+filenamebase = redis\n+dir = ${buildout:directory}/var/redis\n+configfile = ${buildout:parts-directory}/redis/${redis-settings:filenamebase}.conf\n+pidfile = ${redis-settings:dir}/${redis-settings:filenamebase}.pid\n+sockfile = ${redis-settings:dir}/${redis-settings:filenamebase}.sock\n+logfile = ${redis-settings:dir}/${redis-settings:filenamebase}.log\n+rdb_filename = ${redis-settings:filenamebase}.rdb\n+aof_filename = ${redis-settings:filenamebase}.aof\n+# appendonly enables AOF storage, which is not enabled in the default config.\n+# see http://redis.io/topics/persistence\n+appendonly = yes\n+\n+# We cannot add a [buildout] secion in this file because it is\n+# an indirect, 3rd level extends and declaring a [buildout]\n+# part will break / reset values. Thanks buildout.\n+parts =\n+    redis-download\n+    redis-build\n+    redis-ensure-var-exists\n+    redis-server\n+    redis-py\n+\n+\n+[redis-download]\n+recipe = hexagonit.recipe.download\n+strip-top-level-dir = true\n+url = http://download.redis.io/releases/redis-${redis-settings:redis-version}.tar.gz\n+md5sum = ${redis-settings:redis-md5sum}\n+destination = ${buildout:parts-directory}/redis-${redis-settings:redis-version}\n+\n+\n+[redis-build]\n+recipe = collective.recipe.cmd\n+on_install = true\n+on_update = false\n+cmds = cd ${redis-download:location} && make\n+\n+\n+[redis-ensure-var-exists]\n+recipe = collective.recipe.cmd\n+on_install = true\n+on_update = true\n+cmds = mkdir -p ${redis-settings:dir}\n+\n+\n+[redis-server]\n+recipe = collective.recipe.template\n+input = inline:\n+    #!/bin/sh\n+    ${redis-download:location}/src/redis-server ${redis-server:args-default} ${redis-server:args-custom}\n+args-default =\n+    --port ${redis-settings:port} \\\n+    --bind ${redis-settings:bind} \\\n+    --timeout ${redis-settings:timeout} \\\n+    --pidfile ${redis-settings:pidfile} \\\n+    --logfile ${redis-settings:logfile} \\\n+    --unixsocket ${redis-settings:sockfile} \\\n+    --dir ${redis-settings:dir} \\\n+    --dbfilename ${redis-settings:rdb_filename} \\\n+    --appendfilename ${redis-settings:aof_filename} \\\n+    --appendonly ${redis-settings:appendonly}\n+args-custom =\n+output = ${buildout:directory}/bin/redis-server\n+mode = 755\n+\n+\n+[redis-py]\n+recipe = zc.recipe.egg:scripts\n+eggs = redis\n+interpreter = redispy\n+initialization =\n+    import redis\n+    r = redis.StrictRedis(host='localhost', port=${redis-settings:port}, db=0)","path":"redis/base.cfg","position":81,"original_position":81,"commit_id":"0695fc66143dafc1430e9fce1b10fa97dff189f3","original_commit_id":"0695fc66143dafc1430e9fce1b10fa97dff189f3","user":{"login":"jone","id":7469,"avatar_url":"https://avatars.githubusercontent.com/u/7469?v=3","gravatar_id":"","url":"https://api.github.com/users/jone","html_url":"https://github.com/jone","followers_url":"https://api.github.com/users/jone/followers","following_url":"https://api.github.com/users/jone/following{/other_user}","gists_url":"https://api.github.com/users/jone/gists{/gist_id}","starred_url":"https://api.github.com/users/jone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jone/subscriptions","organizations_url":"https://api.github.com/users/jone/orgs","repos_url":"https://api.github.com/users/jone/repos","events_url":"https://api.github.com/users/jone/events{/privacy}","received_events_url":"https://api.github.com/users/jone/received_events","type":"User","site_admin":false},"body":"The `bind` will allow to bind to all interfaces (`0.0.0.0`), when one knows what one does. But can I then connect to `0.0.0.0` here?\r\n\r\nMy thoughts were that when using this buildout, redis is actually installed on localhost, because that's what this buildout does. Therefore it should always work with localhost, right?\r\n\r\nSo I'm not sure. For me, `bind` has a different meaning than \"connect to host x\".\r\nWhat would you do?","created_at":"2016-09-08T11:24:39Z","updated_at":"2016-09-08T11:24:39Z","html_url":"https://github.com/4teamwork/ftw-buildouts/pull/45#discussion_r77988342","pull_request_url":"https://api.github.com/repos/4teamwork/ftw-buildouts/pulls/45","_links":{"self":{"href":"https://api.github.com/repos/4teamwork/ftw-buildouts/pulls/comments/77988342"},"html":{"href":"https://github.com/4teamwork/ftw-buildouts/pull/45#discussion_r77988342"},"pull_request":{"href":"https://api.github.com/repos/4teamwork/ftw-buildouts/pulls/45"}}},"pull_request":{"url":"https://api.github.com/repos/4teamwork/ftw-buildouts/pulls/45","id":84450071,"html_url":"https://github.com/4teamwork/ftw-buildouts/pull/45","diff_url":"https://github.com/4teamwork/ftw-buildouts/pull/45.diff","patch_url":"https://github.com/4teamwork/ftw-buildouts/pull/45.patch","issue_url":"https://api.github.com/repos/4teamwork/ftw-buildouts/issues/45","number":45,"state":"open","locked":false,"title":"Buildouts for installing redis.","user":{"login":"jone","id":7469,"avatar_url":"https://avatars.githubusercontent.com/u/7469?v=3","gravatar_id":"","url":"https://api.github.com/users/jone","html_url":"https://github.com/jone","followers_url":"https://api.github.com/users/jone/followers","following_url":"https://api.github.com/users/jone/following{/other_user}","gists_url":"https://api.github.com/users/jone/gists{/gist_id}","starred_url":"https://api.github.com/users/jone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jone/subscriptions","organizations_url":"https://api.github.com/users/jone/orgs","repos_url":"https://api.github.com/users/jone/repos","events_url":"https://api.github.com/users/jone/events{/privacy}","received_events_url":"https://api.github.com/users/jone/received_events","type":"User","site_admin":false},"body":"Sometimes a Redis installation should be shipped along with the a project.\r\nThese buildouts help downloading, building and configuring a redis installation for production and for development purposes.\r\n\r\n/cc @lukasgraf @maethu @buchi ","created_at":"2016-09-08T10:14:03Z","updated_at":"2016-09-08T11:24:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0b835b1ee2a6735a24801ead77dadd8efce97344","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/4teamwork/ftw-buildouts/pulls/45/commits","review_comments_url":"https://api.github.com/repos/4teamwork/ftw-buildouts/pulls/45/comments","review_comment_url":"https://api.github.com/repos/4teamwork/ftw-buildouts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/4teamwork/ftw-buildouts/issues/45/comments","statuses_url":"https://api.github.com/repos/4teamwork/ftw-buildouts/statuses/0695fc66143dafc1430e9fce1b10fa97dff189f3","head":{"label":"4teamwork:jone-redis","ref":"jone-redis","sha":"0695fc66143dafc1430e9fce1b10fa97dff189f3","user":{"login":"4teamwork","id":681821,"avatar_url":"https://avatars.githubusercontent.com/u/681821?v=3","gravatar_id":"","url":"https://api.github.com/users/4teamwork","html_url":"https://github.com/4teamwork","followers_url":"https://api.github.com/users/4teamwork/followers","following_url":"https://api.github.com/users/4teamwork/following{/other_user}","gists_url":"https://api.github.com/users/4teamwork/gists{/gist_id}","starred_url":"https://api.github.com/users/4teamwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/4teamwork/subscriptions","organizations_url":"https://api.github.com/users/4teamwork/orgs","repos_url":"https://api.github.com/users/4teamwork/repos","events_url":"https://api.github.com/users/4teamwork/events{/privacy}","received_events_url":"https://api.github.com/users/4teamwork/received_events","type":"Organization","site_admin":false},"repo":{"id":3884878,"name":"ftw-buildouts","full_name":"4teamwork/ftw-buildouts","owner":{"login":"4teamwork","id":681821,"avatar_url":"https://avatars.githubusercontent.com/u/681821?v=3","gravatar_id":"","url":"https://api.github.com/users/4teamwork","html_url":"https://github.com/4teamwork","followers_url":"https://api.github.com/users/4teamwork/followers","following_url":"https://api.github.com/users/4teamwork/following{/other_user}","gists_url":"https://api.github.com/users/4teamwork/gists{/gist_id}","starred_url":"https://api.github.com/users/4teamwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/4teamwork/subscriptions","organizations_url":"https://api.github.com/users/4teamwork/orgs","repos_url":"https://api.github.com/users/4teamwork/repos","events_url":"https://api.github.com/users/4teamwork/events{/privacy}","received_events_url":"https://api.github.com/users/4teamwork/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/4teamwork/ftw-buildouts","description":"Buildout base configurations for development and testing.","fork":false,"url":"https://api.github.com/repos/4teamwork/ftw-buildouts","forks_url":"https://api.github.com/repos/4teamwork/ftw-buildouts/forks","keys_url":"https://api.github.com/repos/4teamwork/ftw-buildouts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/4teamwork/ftw-buildouts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/4teamwork/ftw-buildouts/teams","hooks_url":"https://api.github.com/repos/4teamwork/ftw-buildouts/hooks","issue_events_url":"https://api.github.com/repos/4teamwork/ftw-buildouts/issues/events{/number}","events_url":"https://api.github.com/repos/4teamwork/ftw-buildouts/events","assignees_url":"https://api.github.com/repos/4teamwork/ftw-buildouts/assignees{/user}","branches_url":"https://api.github.com/repos/4teamwork/ftw-buildouts/branches{/branch}","tags_url":"https://api.github.com/repos/4teamwork/ftw-buildouts/tags","blobs_url":"https://api.github.com/repos/4teamwork/ftw-buildouts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/4teamwork/ftw-buildouts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/4teamwork/ftw-buildouts/git/refs{/sha}","trees_url":"https://api.github.com/repos/4teamwork/ftw-buildouts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/4teamwork/ftw-buildouts/statuses/{sha}","languages_url":"https://api.github.com/repos/4teamwork/ftw-buildouts/languages","stargazers_url":"https://api.github.com/repos/4teamwork/ftw-buildouts/stargazers","contributors_url":"https://api.github.com/repos/4teamwork/ftw-buildouts/contributors","subscribers_url":"https://api.github.com/repos/4teamwork/ftw-buildouts/subscribers","subscription_url":"https://api.github.com/repos/4teamwork/ftw-buildouts/subscription","commits_url":"https://api.github.com/repos/4teamwork/ftw-buildouts/commits{/sha}","git_commits_url":"https://api.github.com/repos/4teamwork/ftw-buildouts/git/commits{/sha}","comments_url":"https://api.github.com/repos/4teamwork/ftw-buildouts/comments{/number}","issue_comment_url":"https://api.github.com/repos/4teamwork/ftw-buildouts/issues/comments{/number}","contents_url":"https://api.github.com/repos/4teamwork/ftw-buildouts/contents/{+path}","compare_url":"https://api.github.com/repos/4teamwork/ftw-buildouts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/4teamwork/ftw-buildouts/merges","archive_url":"https://api.github.com/repos/4teamwork/ftw-buildouts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/4teamwork/ftw-buildouts/downloads","issues_url":"https://api.github.com/repos/4teamwork/ftw-buildouts/issues{/number}","pulls_url":"https://api.github.com/repos/4teamwork/ftw-buildouts/pulls{/number}","milestones_url":"https://api.github.com/repos/4teamwork/ftw-buildouts/milestones{/number}","notifications_url":"https://api.github.com/repos/4teamwork/ftw-buildouts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/4teamwork/ftw-buildouts/labels{/name}","releases_url":"https://api.github.com/repos/4teamwork/ftw-buildouts/releases{/id}","deployments_url":"https://api.github.com/repos/4teamwork/ftw-buildouts/deployments","created_at":"2012-03-31T10:57:44Z","updated_at":"2016-09-06T07:45:53Z","pushed_at":"2016-09-08T11:20:37Z","git_url":"git://github.com/4teamwork/ftw-buildouts.git","ssh_url":"git@github.com:4teamwork/ftw-buildouts.git","clone_url":"https://github.com/4teamwork/ftw-buildouts.git","svn_url":"https://github.com/4teamwork/ftw-buildouts","homepage":"","size":226,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":4,"forks":1,"open_issues":4,"watchers":3,"default_branch":"master"}},"base":{"label":"4teamwork:master","ref":"master","sha":"55b4c18f6ef827a9f4492885f91b30e5ec42975e","user":{"login":"4teamwork","id":681821,"avatar_url":"https://avatars.githubusercontent.com/u/681821?v=3","gravatar_id":"","url":"https://api.github.com/users/4teamwork","html_url":"https://github.com/4teamwork","followers_url":"https://api.github.com/users/4teamwork/followers","following_url":"https://api.github.com/users/4teamwork/following{/other_user}","gists_url":"https://api.github.com/users/4teamwork/gists{/gist_id}","starred_url":"https://api.github.com/users/4teamwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/4teamwork/subscriptions","organizations_url":"https://api.github.com/users/4teamwork/orgs","repos_url":"https://api.github.com/users/4teamwork/repos","events_url":"https://api.github.com/users/4teamwork/events{/privacy}","received_events_url":"https://api.github.com/users/4teamwork/received_events","type":"Organization","site_admin":false},"repo":{"id":3884878,"name":"ftw-buildouts","full_name":"4teamwork/ftw-buildouts","owner":{"login":"4teamwork","id":681821,"avatar_url":"https://avatars.githubusercontent.com/u/681821?v=3","gravatar_id":"","url":"https://api.github.com/users/4teamwork","html_url":"https://github.com/4teamwork","followers_url":"https://api.github.com/users/4teamwork/followers","following_url":"https://api.github.com/users/4teamwork/following{/other_user}","gists_url":"https://api.github.com/users/4teamwork/gists{/gist_id}","starred_url":"https://api.github.com/users/4teamwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/4teamwork/subscriptions","organizations_url":"https://api.github.com/users/4teamwork/orgs","repos_url":"https://api.github.com/users/4teamwork/repos","events_url":"https://api.github.com/users/4teamwork/events{/privacy}","received_events_url":"https://api.github.com/users/4teamwork/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/4teamwork/ftw-buildouts","description":"Buildout base configurations for development and testing.","fork":false,"url":"https://api.github.com/repos/4teamwork/ftw-buildouts","forks_url":"https://api.github.com/repos/4teamwork/ftw-buildouts/forks","keys_url":"https://api.github.com/repos/4teamwork/ftw-buildouts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/4teamwork/ftw-buildouts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/4teamwork/ftw-buildouts/teams","hooks_url":"https://api.github.com/repos/4teamwork/ftw-buildouts/hooks","issue_events_url":"https://api.github.com/repos/4teamwork/ftw-buildouts/issues/events{/number}","events_url":"https://api.github.com/repos/4teamwork/ftw-buildouts/events","assignees_url":"https://api.github.com/repos/4teamwork/ftw-buildouts/assignees{/user}","branches_url":"https://api.github.com/repos/4teamwork/ftw-buildouts/branches{/branch}","tags_url":"https://api.github.com/repos/4teamwork/ftw-buildouts/tags","blobs_url":"https://api.github.com/repos/4teamwork/ftw-buildouts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/4teamwork/ftw-buildouts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/4teamwork/ftw-buildouts/git/refs{/sha}","trees_url":"https://api.github.com/repos/4teamwork/ftw-buildouts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/4teamwork/ftw-buildouts/statuses/{sha}","languages_url":"https://api.github.com/repos/4teamwork/ftw-buildouts/languages","stargazers_url":"https://api.github.com/repos/4teamwork/ftw-buildouts/stargazers","contributors_url":"https://api.github.com/repos/4teamwork/ftw-buildouts/contributors","subscribers_url":"https://api.github.com/repos/4teamwork/ftw-buildouts/subscribers","subscription_url":"https://api.github.com/repos/4teamwork/ftw-buildouts/subscription","commits_url":"https://api.github.com/repos/4teamwork/ftw-buildouts/commits{/sha}","git_commits_url":"https://api.github.com/repos/4teamwork/ftw-buildouts/git/commits{/sha}","comments_url":"https://api.github.com/repos/4teamwork/ftw-buildouts/comments{/number}","issue_comment_url":"https://api.github.com/repos/4teamwork/ftw-buildouts/issues/comments{/number}","contents_url":"https://api.github.com/repos/4teamwork/ftw-buildouts/contents/{+path}","compare_url":"https://api.github.com/repos/4teamwork/ftw-buildouts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/4teamwork/ftw-buildouts/merges","archive_url":"https://api.github.com/repos/4teamwork/ftw-buildouts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/4teamwork/ftw-buildouts/downloads","issues_url":"https://api.github.com/repos/4teamwork/ftw-buildouts/issues{/number}","pulls_url":"https://api.github.com/repos/4teamwork/ftw-buildouts/pulls{/number}","milestones_url":"https://api.github.com/repos/4teamwork/ftw-buildouts/milestones{/number}","notifications_url":"https://api.github.com/repos/4teamwork/ftw-buildouts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/4teamwork/ftw-buildouts/labels{/name}","releases_url":"https://api.github.com/repos/4teamwork/ftw-buildouts/releases{/id}","deployments_url":"https://api.github.com/repos/4teamwork/ftw-buildouts/deployments","created_at":"2012-03-31T10:57:44Z","updated_at":"2016-09-06T07:45:53Z","pushed_at":"2016-09-08T11:20:37Z","git_url":"git://github.com/4teamwork/ftw-buildouts.git","ssh_url":"git@github.com:4teamwork/ftw-buildouts.git","clone_url":"https://github.com/4teamwork/ftw-buildouts.git","svn_url":"https://github.com/4teamwork/ftw-buildouts","homepage":"","size":226,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":4,"forks":1,"open_issues":4,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/4teamwork/ftw-buildouts/pulls/45"},"html":{"href":"https://github.com/4teamwork/ftw-buildouts/pull/45"},"issue":{"href":"https://api.github.com/repos/4teamwork/ftw-buildouts/issues/45"},"comments":{"href":"https://api.github.com/repos/4teamwork/ftw-buildouts/issues/45/comments"},"review_comments":{"href":"https://api.github.com/repos/4teamwork/ftw-buildouts/pulls/45/comments"},"review_comment":{"href":"https://api.github.com/repos/4teamwork/ftw-buildouts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/4teamwork/ftw-buildouts/pulls/45/commits"},"statuses":{"href":"https://api.github.com/repos/4teamwork/ftw-buildouts/statuses/0695fc66143dafc1430e9fce1b10fa97dff189f3"}}}}
{"actor":{"display_login":"jone"}}