{"action":"created","comment":{"url":"https://api.github.com/repos/opencontainers/runtime-spec/pulls/comments/65917005","id":65917005,"diff_hunk":"@@ -12,12 +12,10 @@ This MUST include the following artifacts:\n \n 1. `config.json` : contains configuration data.\n This REQUIRED file MUST reside in the root of the bundle directory and MUST be named `config.json`.\n-When the bundle is packaged up for distribution, this file MUST be included.\n See [`config.json`](config.md) for more details.\n \n 2. A directory representing the root filesystem of the container.\n While the name of this REQUIRED directory may be arbitrary, users should consider using a conventional name, such as `rootfs`.\n-When the bundle is packaged up for distribution, this directory MUST be included.","path":"bundle.md","position":9,"original_position":9,"commit_id":"ecb7fa51eaa7fdcd272f3a5b9db3100c058b18d6","original_commit_id":"ecb7fa51eaa7fdcd272f3a5b9db3100c058b18d6","user":{"login":"wking","id":209920,"avatar_url":"https://avatars.githubusercontent.com/u/209920?v=3","gravatar_id":"","url":"https://api.github.com/users/wking","html_url":"https://github.com/wking","followers_url":"https://api.github.com/users/wking/followers","following_url":"https://api.github.com/users/wking/following{/other_user}","gists_url":"https://api.github.com/users/wking/gists{/gist_id}","starred_url":"https://api.github.com/users/wking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wking/subscriptions","organizations_url":"https://api.github.com/users/wking/orgs","repos_url":"https://api.github.com/users/wking/repos","events_url":"https://api.github.com/users/wking/events{/privacy}","received_events_url":"https://api.github.com/users/wking/received_events","type":"User","site_admin":false},"body":"On Mon, Jun 06, 2016 at 08:16:10AM -0700, Vincent Batts wrote:\n> >  See [`config.json`](config.md) for more details.\n> >  \n> >  2. A directory representing the root filesystem of the container.\n> >  While the name of this REQUIRED directory may be arbitrary, users should consider using a conventional name, such as `rootfs`.\n> > -When the bundle is packaged up for distribution, this directory MUST be included.\n> \n> this feels like a drive-by of MUST ...\n\nMy removal is a drive by?  Or the current sentences are drive-bys?  If\nthe latter, are you suggesting we keep the sentences (with “MUST” →\n“must”) as toothless, informative context?  I'd rather just link to\nimage-spec's “what portions of the bundle do we transport” docs\n(creating them if they don't exist) to provide that context.\n","created_at":"2016-06-06T15:56:51Z","updated_at":"2016-06-06T15:56:51Z","html_url":"https://github.com/opencontainers/runtime-spec/pull/487#discussion_r65917005","pull_request_url":"https://api.github.com/repos/opencontainers/runtime-spec/pulls/487","_links":{"self":{"href":"https://api.github.com/repos/opencontainers/runtime-spec/pulls/comments/65917005"},"html":{"href":"https://github.com/opencontainers/runtime-spec/pull/487#discussion_r65917005"},"pull_request":{"href":"https://api.github.com/repos/opencontainers/runtime-spec/pulls/487"}}},"pull_request":{"url":"https://api.github.com/repos/opencontainers/runtime-spec/pulls/487","id":72612793,"html_url":"https://github.com/opencontainers/runtime-spec/pull/487","diff_url":"https://github.com/opencontainers/runtime-spec/pull/487.diff","patch_url":"https://github.com/opencontainers/runtime-spec/pull/487.patch","issue_url":"https://api.github.com/repos/opencontainers/runtime-spec/issues/487","number":487,"state":"open","locked":false,"title":"bundle: Remove distribution references","user":{"login":"wking","id":209920,"avatar_url":"https://avatars.githubusercontent.com/u/209920?v=3","gravatar_id":"","url":"https://api.github.com/users/wking","html_url":"https://github.com/wking","followers_url":"https://api.github.com/users/wking/followers","following_url":"https://api.github.com/users/wking/following{/other_user}","gists_url":"https://api.github.com/users/wking/gists{/gist_id}","starred_url":"https://api.github.com/users/wking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wking/subscriptions","organizations_url":"https://api.github.com/users/wking/orgs","repos_url":"https://api.github.com/users/wking/repos","events_url":"https://api.github.com/users/wking/events{/privacy}","received_events_url":"https://api.github.com/users/wking/received_events","type":"User","site_admin":false},"body":"These distribution requirements belong in image-spec or similar.  They\ndon't apply to runtimes or filesystem bundles (the latter are covered\nby the earlier \"This MUST include the following artifacts\"), which are\nthe two entities tested for compliance with this spec.","created_at":"2016-06-04T20:53:32Z","updated_at":"2016-06-06T15:56:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"60c2a3c79656d34c1137d26e1b8b22af28bfcc05","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/opencontainers/runtime-spec/pulls/487/commits","review_comments_url":"https://api.github.com/repos/opencontainers/runtime-spec/pulls/487/comments","review_comment_url":"https://api.github.com/repos/opencontainers/runtime-spec/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opencontainers/runtime-spec/issues/487/comments","statuses_url":"https://api.github.com/repos/opencontainers/runtime-spec/statuses/ecb7fa51eaa7fdcd272f3a5b9db3100c058b18d6","head":{"label":"wking:no-distribution-references","ref":"no-distribution-references","sha":"ecb7fa51eaa7fdcd272f3a5b9db3100c058b18d6","user":{"login":"wking","id":209920,"avatar_url":"https://avatars.githubusercontent.com/u/209920?v=3","gravatar_id":"","url":"https://api.github.com/users/wking","html_url":"https://github.com/wking","followers_url":"https://api.github.com/users/wking/followers","following_url":"https://api.github.com/users/wking/following{/other_user}","gists_url":"https://api.github.com/users/wking/gists{/gist_id}","starred_url":"https://api.github.com/users/wking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wking/subscriptions","organizations_url":"https://api.github.com/users/wking/orgs","repos_url":"https://api.github.com/users/wking/repos","events_url":"https://api.github.com/users/wking/events{/privacy}","received_events_url":"https://api.github.com/users/wking/received_events","type":"User","site_admin":false},"repo":{"id":38028795,"name":"opencontainer-runtime-spec","full_name":"wking/opencontainer-runtime-spec","owner":{"login":"wking","id":209920,"avatar_url":"https://avatars.githubusercontent.com/u/209920?v=3","gravatar_id":"","url":"https://api.github.com/users/wking","html_url":"https://github.com/wking","followers_url":"https://api.github.com/users/wking/followers","following_url":"https://api.github.com/users/wking/following{/other_user}","gists_url":"https://api.github.com/users/wking/gists{/gist_id}","starred_url":"https://api.github.com/users/wking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wking/subscriptions","organizations_url":"https://api.github.com/users/wking/orgs","repos_url":"https://api.github.com/users/wking/repos","events_url":"https://api.github.com/users/wking/events{/privacy}","received_events_url":"https://api.github.com/users/wking/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wking/opencontainer-runtime-spec","description":"Open Container Specifications","fork":true,"url":"https://api.github.com/repos/wking/opencontainer-runtime-spec","forks_url":"https://api.github.com/repos/wking/opencontainer-runtime-spec/forks","keys_url":"https://api.github.com/repos/wking/opencontainer-runtime-spec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wking/opencontainer-runtime-spec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wking/opencontainer-runtime-spec/teams","hooks_url":"https://api.github.com/repos/wking/opencontainer-runtime-spec/hooks","issue_events_url":"https://api.github.com/repos/wking/opencontainer-runtime-spec/issues/events{/number}","events_url":"https://api.github.com/repos/wking/opencontainer-runtime-spec/events","assignees_url":"https://api.github.com/repos/wking/opencontainer-runtime-spec/assignees{/user}","branches_url":"https://api.github.com/repos/wking/opencontainer-runtime-spec/branches{/branch}","tags_url":"https://api.github.com/repos/wking/opencontainer-runtime-spec/tags","blobs_url":"https://api.github.com/repos/wking/opencontainer-runtime-spec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wking/opencontainer-runtime-spec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wking/opencontainer-runtime-spec/git/refs{/sha}","trees_url":"https://api.github.com/repos/wking/opencontainer-runtime-spec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wking/opencontainer-runtime-spec/statuses/{sha}","languages_url":"https://api.github.com/repos/wking/opencontainer-runtime-spec/languages","stargazers_url":"https://api.github.com/repos/wking/opencontainer-runtime-spec/stargazers","contributors_url":"https://api.github.com/repos/wking/opencontainer-runtime-spec/contributors","subscribers_url":"https://api.github.com/repos/wking/opencontainer-runtime-spec/subscribers","subscription_url":"https://api.github.com/repos/wking/opencontainer-runtime-spec/subscription","commits_url":"https://api.github.com/repos/wking/opencontainer-runtime-spec/commits{/sha}","git_commits_url":"https://api.github.com/repos/wking/opencontainer-runtime-spec/git/commits{/sha}","comments_url":"https://api.github.com/repos/wking/opencontainer-runtime-spec/comments{/number}","issue_comment_url":"https://api.github.com/repos/wking/opencontainer-runtime-spec/issues/comments{/number}","contents_url":"https://api.github.com/repos/wking/opencontainer-runtime-spec/contents/{+path}","compare_url":"https://api.github.com/repos/wking/opencontainer-runtime-spec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wking/opencontainer-runtime-spec/merges","archive_url":"https://api.github.com/repos/wking/opencontainer-runtime-spec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wking/opencontainer-runtime-spec/downloads","issues_url":"https://api.github.com/repos/wking/opencontainer-runtime-spec/issues{/number}","pulls_url":"https://api.github.com/repos/wking/opencontainer-runtime-spec/pulls{/number}","milestones_url":"https://api.github.com/repos/wking/opencontainer-runtime-spec/milestones{/number}","notifications_url":"https://api.github.com/repos/wking/opencontainer-runtime-spec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wking/opencontainer-runtime-spec/labels{/name}","releases_url":"https://api.github.com/repos/wking/opencontainer-runtime-spec/releases{/id}","deployments_url":"https://api.github.com/repos/wking/opencontainer-runtime-spec/deployments","created_at":"2015-06-25T04:59:11Z","updated_at":"2016-04-12T04:54:47Z","pushed_at":"2016-06-06T07:03:41Z","git_url":"git://github.com/wking/opencontainer-runtime-spec.git","ssh_url":"git@github.com:wking/opencontainer-runtime-spec.git","clone_url":"https://github.com/wking/opencontainer-runtime-spec.git","svn_url":"https://github.com/wking/opencontainer-runtime-spec","homepage":"http://www.opencontainers.org","size":653,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"opencontainers:master","ref":"master","sha":"b953df428100f4bdb0704519d130ec84bc1568b3","user":{"login":"opencontainers","id":12563465,"avatar_url":"https://avatars.githubusercontent.com/u/12563465?v=3","gravatar_id":"","url":"https://api.github.com/users/opencontainers","html_url":"https://github.com/opencontainers","followers_url":"https://api.github.com/users/opencontainers/followers","following_url":"https://api.github.com/users/opencontainers/following{/other_user}","gists_url":"https://api.github.com/users/opencontainers/gists{/gist_id}","starred_url":"https://api.github.com/users/opencontainers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opencontainers/subscriptions","organizations_url":"https://api.github.com/users/opencontainers/orgs","repos_url":"https://api.github.com/users/opencontainers/repos","events_url":"https://api.github.com/users/opencontainers/events{/privacy}","received_events_url":"https://api.github.com/users/opencontainers/received_events","type":"Organization","site_admin":false},"repo":{"id":36960293,"name":"runtime-spec","full_name":"opencontainers/runtime-spec","owner":{"login":"opencontainers","id":12563465,"avatar_url":"https://avatars.githubusercontent.com/u/12563465?v=3","gravatar_id":"","url":"https://api.github.com/users/opencontainers","html_url":"https://github.com/opencontainers","followers_url":"https://api.github.com/users/opencontainers/followers","following_url":"https://api.github.com/users/opencontainers/following{/other_user}","gists_url":"https://api.github.com/users/opencontainers/gists{/gist_id}","starred_url":"https://api.github.com/users/opencontainers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opencontainers/subscriptions","organizations_url":"https://api.github.com/users/opencontainers/orgs","repos_url":"https://api.github.com/users/opencontainers/repos","events_url":"https://api.github.com/users/opencontainers/events{/privacy}","received_events_url":"https://api.github.com/users/opencontainers/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opencontainers/runtime-spec","description":"OCI Runtime Specification","fork":false,"url":"https://api.github.com/repos/opencontainers/runtime-spec","forks_url":"https://api.github.com/repos/opencontainers/runtime-spec/forks","keys_url":"https://api.github.com/repos/opencontainers/runtime-spec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opencontainers/runtime-spec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opencontainers/runtime-spec/teams","hooks_url":"https://api.github.com/repos/opencontainers/runtime-spec/hooks","issue_events_url":"https://api.github.com/repos/opencontainers/runtime-spec/issues/events{/number}","events_url":"https://api.github.com/repos/opencontainers/runtime-spec/events","assignees_url":"https://api.github.com/repos/opencontainers/runtime-spec/assignees{/user}","branches_url":"https://api.github.com/repos/opencontainers/runtime-spec/branches{/branch}","tags_url":"https://api.github.com/repos/opencontainers/runtime-spec/tags","blobs_url":"https://api.github.com/repos/opencontainers/runtime-spec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opencontainers/runtime-spec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opencontainers/runtime-spec/git/refs{/sha}","trees_url":"https://api.github.com/repos/opencontainers/runtime-spec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opencontainers/runtime-spec/statuses/{sha}","languages_url":"https://api.github.com/repos/opencontainers/runtime-spec/languages","stargazers_url":"https://api.github.com/repos/opencontainers/runtime-spec/stargazers","contributors_url":"https://api.github.com/repos/opencontainers/runtime-spec/contributors","subscribers_url":"https://api.github.com/repos/opencontainers/runtime-spec/subscribers","subscription_url":"https://api.github.com/repos/opencontainers/runtime-spec/subscription","commits_url":"https://api.github.com/repos/opencontainers/runtime-spec/commits{/sha}","git_commits_url":"https://api.github.com/repos/opencontainers/runtime-spec/git/commits{/sha}","comments_url":"https://api.github.com/repos/opencontainers/runtime-spec/comments{/number}","issue_comment_url":"https://api.github.com/repos/opencontainers/runtime-spec/issues/comments{/number}","contents_url":"https://api.github.com/repos/opencontainers/runtime-spec/contents/{+path}","compare_url":"https://api.github.com/repos/opencontainers/runtime-spec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opencontainers/runtime-spec/merges","archive_url":"https://api.github.com/repos/opencontainers/runtime-spec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opencontainers/runtime-spec/downloads","issues_url":"https://api.github.com/repos/opencontainers/runtime-spec/issues{/number}","pulls_url":"https://api.github.com/repos/opencontainers/runtime-spec/pulls{/number}","milestones_url":"https://api.github.com/repos/opencontainers/runtime-spec/milestones{/number}","notifications_url":"https://api.github.com/repos/opencontainers/runtime-spec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opencontainers/runtime-spec/labels{/name}","releases_url":"https://api.github.com/repos/opencontainers/runtime-spec/releases{/id}","deployments_url":"https://api.github.com/repos/opencontainers/runtime-spec/deployments","created_at":"2015-06-05T23:30:10Z","updated_at":"2016-06-06T08:16:50Z","pushed_at":"2016-06-06T07:03:52Z","git_url":"git://github.com/opencontainers/runtime-spec.git","ssh_url":"git@github.com:opencontainers/runtime-spec.git","clone_url":"https://github.com/opencontainers/runtime-spec.git","svn_url":"https://github.com/opencontainers/runtime-spec","homepage":"http://www.opencontainers.org","size":1926,"stargazers_count":705,"watchers_count":705,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":117,"mirror_url":null,"open_issues_count":35,"forks":117,"open_issues":35,"watchers":705,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opencontainers/runtime-spec/pulls/487"},"html":{"href":"https://github.com/opencontainers/runtime-spec/pull/487"},"issue":{"href":"https://api.github.com/repos/opencontainers/runtime-spec/issues/487"},"comments":{"href":"https://api.github.com/repos/opencontainers/runtime-spec/issues/487/comments"},"review_comments":{"href":"https://api.github.com/repos/opencontainers/runtime-spec/pulls/487/comments"},"review_comment":{"href":"https://api.github.com/repos/opencontainers/runtime-spec/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opencontainers/runtime-spec/pulls/487/commits"},"statuses":{"href":"https://api.github.com/repos/opencontainers/runtime-spec/statuses/ecb7fa51eaa7fdcd272f3a5b9db3100c058b18d6"}}}}
{"actor":{"display_login":"wking"}}