{"push_id":1300141166,"size":1,"distinct_size":1,"ref":"refs/heads/master","head":"ce0099849b915f114a453b1860fb159da03124c6","before":"e4fc7fd969449b032548dc527e01fc70350176d1","commits":[{"sha":"ce0099849b915f114a453b1860fb159da03124c6","author":{"name":"Adam Williamson","email":"8644032b318bb67907dd349051d793bd7ced6774@happyassassin.net"},"message":"isotovideo: don't upload disks if test failed (POO #13722) (#597)\n\nAt present, the \"# mark hard disks for upload if test finished\"\r\nblock runs even if the test *failed*: it's only skipped if\r\nsomething went really wrong with test execution somehow (which\r\ncauses $r to be set to 1). This is a problem because commonly,\r\nif the test failed, the SUT will not have been shut down\r\ncleanly, so we'll run into the \"ERROR: Machine not shut down\"\r\ncase, which causes us to exit 1 (which in turn, on current\r\nopenQA git, causes the test to wind up as 'incomplete' rather\r\nthan 'failed').\r\n\r\n`autotest::runalltests` actually returns either 0 or 1 to signal\r\nwhether a fatal test failed or not, but nothing was using this\r\nreturn value at present; `run_all` only cared if `runalltests`\r\n*died*, not if it returned 0 or 1.\r\n\r\nSo to improve things, let's have `run_all` care both whether\r\n`runalltests` died and what it returned, and pass both bits of\r\ninformation along to `isotovideo`, which can then use them both\r\nto decide whether to run the disk upload block or not.\r\n\r\nIf anyone has a case where they want a test to upload its disk\r\nimages regardless of whether the test failed, we could tweak\r\nthis a bit more - say, if `STORE_ON_FAIL` var is set, we can\r\nrun the upload block but skip the 'is VM shut down?' check if\r\n`$passed` is 0, or something like that.\r\n\r\nAdd some tests that cover all this `run_all` stuff.","distinct":true,"url":"https://api.github.com/repos/os-autoinst/os-autoinst/commits/ce0099849b915f114a453b1860fb159da03124c6"}]}
{"actor":{"display_login":"coolo"}}