{"action":"closed","number":57,"pull_request":{"url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-python/pulls/57","id":94222572,"html_url":"https://github.com/AzureAD/azure-activedirectory-library-for-python/pull/57","diff_url":"https://github.com/AzureAD/azure-activedirectory-library-for-python/pull/57.diff","patch_url":"https://github.com/AzureAD/azure-activedirectory-library-for-python/pull/57.patch","issue_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-python/issues/57","number":57,"state":"closed","locked":false,"title":"Introduce a parameter AuthenticationContext(..., api_version='1.0')","user":{"login":"rayluo","id":821550,"avatar_url":"https://avatars.githubusercontent.com/u/821550?v=3","gravatar_id":"","url":"https://api.github.com/users/rayluo","html_url":"https://github.com/rayluo","followers_url":"https://api.github.com/users/rayluo/followers","following_url":"https://api.github.com/users/rayluo/following{/other_user}","gists_url":"https://api.github.com/users/rayluo/gists{/gist_id}","starred_url":"https://api.github.com/users/rayluo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rayluo/subscriptions","organizations_url":"https://api.github.com/users/rayluo/orgs","repos_url":"https://api.github.com/users/rayluo/repos","events_url":"https://api.github.com/users/rayluo/events{/privacy}","received_events_url":"https://api.github.com/users/rayluo/received_events","type":"User","site_admin":false},"body":"In an attempt to fix #54 yet maintain backward compatibility, this PR introduces a parameter AuthenticationContext(..., api_version='1.0') to turn on/off api-version behavior.\r\n\r\n* Legacy ADAL-python customers can safely upgrade to the upcoming new version which contains this adjustment. By default, your current code will still work with the SAME behavior as before.\r\n* However, to ensure a smooth transition, we recommend the current ADAL-python customers to try out the new behavior by explicitly set `context = AuthenticationContext(..., api_version=None)`, to confirm that your app will work fine with this new direction.\r\n* New ADAL-python customers shall use `context = AuthenticationContext(..., api_version=None)` too. In future, this switch will have a default value as `None`.","created_at":"2016-11-17T18:24:15Z","updated_at":"2016-11-18T22:09:28Z","closed_at":"2016-11-18T22:09:28Z","merged_at":"2016-11-18T22:09:28Z","merge_commit_sha":"15dc8f6ece1e5986b0cdcb7be6c8e6f49a291b8d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-python/pulls/57/commits","review_comments_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-python/pulls/57/comments","review_comment_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-python/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-python/issues/57/comments","statuses_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-python/statuses/791c7878a85d41e641310037992def12171d1bd6","head":{"label":"AzureAD:switch-for-api-version","ref":"switch-for-api-version","sha":"791c7878a85d41e641310037992def12171d1bd6","user":{"login":"AzureAD","id":2966316,"avatar_url":"https://avatars.githubusercontent.com/u/2966316?v=3","gravatar_id":"","url":"https://api.github.com/users/AzureAD","html_url":"https://github.com/AzureAD","followers_url":"https://api.github.com/users/AzureAD/followers","following_url":"https://api.github.com/users/AzureAD/following{/other_user}","gists_url":"https://api.github.com/users/AzureAD/gists{/gist_id}","starred_url":"https://api.github.com/users/AzureAD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AzureAD/subscriptions","organizations_url":"https://api.github.com/users/AzureAD/orgs","repos_url":"https://api.github.com/users/AzureAD/repos","events_url":"https://api.github.com/users/AzureAD/events{/privacy}","received_events_url":"https://api.github.com/users/AzureAD/received_events","type":"Organization","site_admin":false},"repo":{"id":43620042,"name":"azure-activedirectory-library-for-python","full_name":"AzureAD/azure-activedirectory-library-for-python","owner":{"login":"AzureAD","id":2966316,"avatar_url":"https://avatars.githubusercontent.com/u/2966316?v=3","gravatar_id":"","url":"https://api.github.com/users/AzureAD","html_url":"https://github.com/AzureAD","followers_url":"https://api.github.com/users/AzureAD/followers","following_url":"https://api.github.com/users/AzureAD/following{/other_user}","gists_url":"https://api.github.com/users/AzureAD/gists{/gist_id}","starred_url":"https://api.github.com/users/AzureAD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AzureAD/subscriptions","organizations_url":"https://api.github.com/users/AzureAD/orgs","repos_url":"https://api.github.com/users/AzureAD/repos","events_url":"https://api.github.com/users/AzureAD/events{/privacy}","received_events_url":"https://api.github.com/users/AzureAD/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AzureAD/azure-activedirectory-library-for-python","description":"ADAL for Python","fork":false,"url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-python","forks_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-python/forks","keys_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-python/teams","hooks_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-python/hooks","issue_events_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-python/issues/events{/number}","events_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-python/events","assignees_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-python/assignees{/user}","branches_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-python/branches{/branch}","tags_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-python/tags","blobs_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-python/statuses/{sha}","languages_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-python/languages","stargazers_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-python/stargazers","contributors_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-python/contributors","subscribers_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-python/subscribers","subscription_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-python/subscription","commits_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-python/contents/{+path}","compare_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-python/merges","archive_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-python/downloads","issues_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-python/issues{/number}","pulls_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-python/pulls{/number}","milestones_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-python/milestones{/number}","notifications_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-python/labels{/name}","releases_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-python/releases{/id}","deployments_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-python/deployments","created_at":"2015-10-04T00:38:03Z","updated_at":"2016-11-17T17:22:09Z","pushed_at":"2016-11-18T22:09:29Z","git_url":"git://github.com/AzureAD/azure-activedirectory-library-for-python.git","ssh_url":"git@github.com:AzureAD/azure-activedirectory-library-for-python.git","clone_url":"https://github.com/AzureAD/azure-activedirectory-library-for-python.git","svn_url":"https://github.com/AzureAD/azure-activedirectory-library-for-python","homepage":null,"size":476,"stargazers_count":21,"watchers_count":21,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":2,"forks":14,"open_issues":2,"watchers":21,"default_branch":"dev"}},"base":{"label":"AzureAD:dev","ref":"dev","sha":"b9affeb5035e41a80e56053c054ce22ea3039b37","user":{"login":"AzureAD","id":2966316,"avatar_url":"https://avatars.githubusercontent.com/u/2966316?v=3","gravatar_id":"","url":"https://api.github.com/users/AzureAD","html_url":"https://github.com/AzureAD","followers_url":"https://api.github.com/users/AzureAD/followers","following_url":"https://api.github.com/users/AzureAD/following{/other_user}","gists_url":"https://api.github.com/users/AzureAD/gists{/gist_id}","starred_url":"https://api.github.com/users/AzureAD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AzureAD/subscriptions","organizations_url":"https://api.github.com/users/AzureAD/orgs","repos_url":"https://api.github.com/users/AzureAD/repos","events_url":"https://api.github.com/users/AzureAD/events{/privacy}","received_events_url":"https://api.github.com/users/AzureAD/received_events","type":"Organization","site_admin":false},"repo":{"id":43620042,"name":"azure-activedirectory-library-for-python","full_name":"AzureAD/azure-activedirectory-library-for-python","owner":{"login":"AzureAD","id":2966316,"avatar_url":"https://avatars.githubusercontent.com/u/2966316?v=3","gravatar_id":"","url":"https://api.github.com/users/AzureAD","html_url":"https://github.com/AzureAD","followers_url":"https://api.github.com/users/AzureAD/followers","following_url":"https://api.github.com/users/AzureAD/following{/other_user}","gists_url":"https://api.github.com/users/AzureAD/gists{/gist_id}","starred_url":"https://api.github.com/users/AzureAD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AzureAD/subscriptions","organizations_url":"https://api.github.com/users/AzureAD/orgs","repos_url":"https://api.github.com/users/AzureAD/repos","events_url":"https://api.github.com/users/AzureAD/events{/privacy}","received_events_url":"https://api.github.com/users/AzureAD/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AzureAD/azure-activedirectory-library-for-python","description":"ADAL for Python","fork":false,"url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-python","forks_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-python/forks","keys_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-python/teams","hooks_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-python/hooks","issue_events_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-python/issues/events{/number}","events_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-python/events","assignees_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-python/assignees{/user}","branches_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-python/branches{/branch}","tags_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-python/tags","blobs_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-python/statuses/{sha}","languages_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-python/languages","stargazers_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-python/stargazers","contributors_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-python/contributors","subscribers_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-python/subscribers","subscription_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-python/subscription","commits_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-python/contents/{+path}","compare_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-python/merges","archive_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-python/downloads","issues_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-python/issues{/number}","pulls_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-python/pulls{/number}","milestones_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-python/milestones{/number}","notifications_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-python/labels{/name}","releases_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-python/releases{/id}","deployments_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-python/deployments","created_at":"2015-10-04T00:38:03Z","updated_at":"2016-11-17T17:22:09Z","pushed_at":"2016-11-18T22:09:29Z","git_url":"git://github.com/AzureAD/azure-activedirectory-library-for-python.git","ssh_url":"git@github.com:AzureAD/azure-activedirectory-library-for-python.git","clone_url":"https://github.com/AzureAD/azure-activedirectory-library-for-python.git","svn_url":"https://github.com/AzureAD/azure-activedirectory-library-for-python","homepage":null,"size":476,"stargazers_count":21,"watchers_count":21,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":2,"forks":14,"open_issues":2,"watchers":21,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-python/pulls/57"},"html":{"href":"https://github.com/AzureAD/azure-activedirectory-library-for-python/pull/57"},"issue":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-python/issues/57"},"comments":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-python/issues/57/comments"},"review_comments":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-python/pulls/57/comments"},"review_comment":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-python/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-python/pulls/57/commits"},"statuses":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-python/statuses/791c7878a85d41e641310037992def12171d1bd6"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"rayluo","id":821550,"avatar_url":"https://avatars.githubusercontent.com/u/821550?v=3","gravatar_id":"","url":"https://api.github.com/users/rayluo","html_url":"https://github.com/rayluo","followers_url":"https://api.github.com/users/rayluo/followers","following_url":"https://api.github.com/users/rayluo/following{/other_user}","gists_url":"https://api.github.com/users/rayluo/gists{/gist_id}","starred_url":"https://api.github.com/users/rayluo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rayluo/subscriptions","organizations_url":"https://api.github.com/users/rayluo/orgs","repos_url":"https://api.github.com/users/rayluo/repos","events_url":"https://api.github.com/users/rayluo/events{/privacy}","received_events_url":"https://api.github.com/users/rayluo/received_events","type":"User","site_admin":false},"comments":4,"review_comments":9,"commits":4,"additions":105,"deletions":4,"changed_files":3}}
{"actor":{"display_login":"rayluo"}}