{"action":"created","issue":{"url":"https://api.github.com/repos/stevemao/mock-bin/issues/5","repository_url":"https://api.github.com/repos/stevemao/mock-bin","labels_url":"https://api.github.com/repos/stevemao/mock-bin/issues/5/labels{/name}","comments_url":"https://api.github.com/repos/stevemao/mock-bin/issues/5/comments","events_url":"https://api.github.com/repos/stevemao/mock-bin/issues/5/events","html_url":"https://github.com/stevemao/mock-bin/issues/5","id":161037441,"number":5,"title":"Tests are flaky on windows","user":{"login":"Tapppi","id":3275280,"avatar_url":"https://avatars.githubusercontent.com/u/3275280?v=3","gravatar_id":"","url":"https://api.github.com/users/Tapppi","html_url":"https://github.com/Tapppi","followers_url":"https://api.github.com/users/Tapppi/followers","following_url":"https://api.github.com/users/Tapppi/following{/other_user}","gists_url":"https://api.github.com/users/Tapppi/gists{/gist_id}","starred_url":"https://api.github.com/users/Tapppi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tapppi/subscriptions","organizations_url":"https://api.github.com/users/Tapppi/orgs","repos_url":"https://api.github.com/users/Tapppi/repos","events_url":"https://api.github.com/users/Tapppi/events{/privacy}","received_events_url":"https://api.github.com/users/Tapppi/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-06-18T18:31:40Z","updated_at":"2016-06-21T15:41:06Z","closed_at":null,"body":"Tests might or might not work randomly (at least on windows). This is due to the shell.env.PATH modifying the path for the process and AVA running the tests in parallel thus them both modifying the same path. This would also affect any downstream packages using mock-bin for tests that run in the same process parallel (namely AVA tests in the same file).\r\n\r\nNot sure how this should be fixed.. Some possible solutions:\r\n1. Write tests in separate files. AVA runs all test files in separate processes that don't share the path variable. Any downstream packages would also need to do this.\r\n2. Run tests with --serial. Same as 1. really..\r\n3. ???"},"comment":{"url":"https://api.github.com/repos/stevemao/mock-bin/issues/comments/227480895","html_url":"https://github.com/stevemao/mock-bin/issues/5#issuecomment-227480895","issue_url":"https://api.github.com/repos/stevemao/mock-bin/issues/5","id":227480895,"user":{"login":"Tapppi","id":3275280,"avatar_url":"https://avatars.githubusercontent.com/u/3275280?v=3","gravatar_id":"","url":"https://api.github.com/users/Tapppi","html_url":"https://github.com/Tapppi","followers_url":"https://api.github.com/users/Tapppi/followers","following_url":"https://api.github.com/users/Tapppi/following{/other_user}","gists_url":"https://api.github.com/users/Tapppi/gists{/gist_id}","starred_url":"https://api.github.com/users/Tapppi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tapppi/subscriptions","organizations_url":"https://api.github.com/users/Tapppi/orgs","repos_url":"https://api.github.com/users/Tapppi/repos","events_url":"https://api.github.com/users/Tapppi/events{/privacy}","received_events_url":"https://api.github.com/users/Tapppi/received_events","type":"User","site_admin":false},"created_at":"2016-06-21T15:41:06Z","updated_at":"2016-06-21T15:41:06Z","body":"Well the current workaround I used for this repo was to run the tests serially on windows (`test-win` does `xo && ava --serial`). It's far from ideal as any package that uses this package will have to do the same for their mocked tests. If it's alright, let's keep this open for the moment while I try to come up with a more elegant solution? The next step otherwise is probably to add a small `Windows caveats` (or something similar) section to the `readme` so that this doesn't surprise anyone, It's a bitch to diagnose."}}
{"actor":{"display_login":"Tapppi"}}