{"action":"created","issue":{"url":"https://api.github.com/repos/chaijs/type-detect/issues/11","repository_url":"https://api.github.com/repos/chaijs/type-detect","labels_url":"https://api.github.com/repos/chaijs/type-detect/issues/11/labels{/name}","comments_url":"https://api.github.com/repos/chaijs/type-detect/issues/11/comments","events_url":"https://api.github.com/repos/chaijs/type-detect/issues/11/events","html_url":"https://github.com/chaijs/type-detect/pull/11","id":136548477,"number":11,"title":"Giant refactor","user":{"login":"keithamus","id":118266,"avatar_url":"https://avatars.githubusercontent.com/u/118266?v=3","gravatar_id":"","url":"https://api.github.com/users/keithamus","html_url":"https://github.com/keithamus","followers_url":"https://api.github.com/users/keithamus/followers","following_url":"https://api.github.com/users/keithamus/following{/other_user}","gists_url":"https://api.github.com/users/keithamus/gists{/gist_id}","starred_url":"https://api.github.com/users/keithamus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keithamus/subscriptions","organizations_url":"https://api.github.com/users/keithamus/orgs","repos_url":"https://api.github.com/users/keithamus/repos","events_url":"https://api.github.com/users/keithamus/events{/privacy}","received_events_url":"https://api.github.com/users/keithamus/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":10,"created_at":"2016-02-25T23:46:59Z","updated_at":"2016-03-13T14:20:16Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/chaijs/type-detect/pulls/11","html_url":"https://github.com/chaijs/type-detect/pull/11","diff_url":"https://github.com/chaijs/type-detect/pull/11.diff","patch_url":"https://github.com/chaijs/type-detect/pull/11.patch"},"body":"This is quite a large PR, I'll go over some of the features:\r\n\r\n - Remove `Library` class, as no one was using it (no, [seriously](https://github.com/keithamus/type-detect/commit/2fe4de1815b92fd9f5c6b172b25d58dce2d9855e)).\r\n - Added eslint\r\n - Added semantic release - meaning every commit (that hits travis) releases a new version of the code.\r\n - Added loads of tests, for browser & node\r\n - Added Karma to auto test in travis & saucelabs\r\n - Switched coverage to istanbul\r\n - Tweaked the main function, adding hot paths for big speed improvements, and extra guards for consistent type reporting\r\n\r\n@logicalparadox and @davelosert it'd be great if you could review this all - I know it's quite a lot but having your eyes on it would be good.\r\n\r\nFYI - I intend to introduce Karma/Eslint/(Possibly Benchmarks)/Semantic Release across all of chai's portfolio. This is the first because its a good test case as its the smallest one.\r\n\r\nP.S. if you want to ask any questions about any of it, or have reservations for any of it, go right ahead."},"comment":{"url":"https://api.github.com/repos/chaijs/type-detect/issues/comments/195963730","html_url":"https://github.com/chaijs/type-detect/pull/11#issuecomment-195963730","issue_url":"https://api.github.com/repos/chaijs/type-detect/issues/11","id":195963730,"user":{"login":"lucasfcosta","id":6868147,"avatar_url":"https://avatars.githubusercontent.com/u/6868147?v=3","gravatar_id":"","url":"https://api.github.com/users/lucasfcosta","html_url":"https://github.com/lucasfcosta","followers_url":"https://api.github.com/users/lucasfcosta/followers","following_url":"https://api.github.com/users/lucasfcosta/following{/other_user}","gists_url":"https://api.github.com/users/lucasfcosta/gists{/gist_id}","starred_url":"https://api.github.com/users/lucasfcosta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucasfcosta/subscriptions","organizations_url":"https://api.github.com/users/lucasfcosta/orgs","repos_url":"https://api.github.com/users/lucasfcosta/repos","events_url":"https://api.github.com/users/lucasfcosta/events{/privacy}","received_events_url":"https://api.github.com/users/lucasfcosta/received_events","type":"User","site_admin":false},"created_at":"2016-03-13T14:20:16Z","updated_at":"2016-03-13T14:20:16Z","body":"Looks good to me!\r\nEverything works fine here too.\r\nI think we are ready to merge this, but it would be cool to follow what @davelosert said above.\r\n\r\nGreat work!"}}