{"action":"created","comment":{"url":"https://api.github.com/repos/neo4j/neo4j/pulls/comments/54588854","id":54588854,"diff_hunk":"@@ -58,6 +59,11 @@ public KernelStatement( KernelTransactionImplementation transaction,\n     @Override\n     public ReadOperations readOperations()\n     {\n+        if( !transaction.mode().allowsReads() )","path":"community/kernel/src/main/java/org/neo4j/kernel/impl/api/KernelStatement.java","position":12,"original_position":12,"commit_id":"3edb739fea3c9e0d7e12135cc744f2d7c28798ec","original_commit_id":"3edb739fea3c9e0d7e12135cc744f2d7c28798ec","user":{"login":"craigtaverner","id":114451,"avatar_url":"https://avatars.githubusercontent.com/u/114451?v=3","gravatar_id":"","url":"https://api.github.com/users/craigtaverner","html_url":"https://github.com/craigtaverner","followers_url":"https://api.github.com/users/craigtaverner/followers","following_url":"https://api.github.com/users/craigtaverner/following{/other_user}","gists_url":"https://api.github.com/users/craigtaverner/gists{/gist_id}","starred_url":"https://api.github.com/users/craigtaverner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/craigtaverner/subscriptions","organizations_url":"https://api.github.com/users/craigtaverner/orgs","repos_url":"https://api.github.com/users/craigtaverner/repos","events_url":"https://api.github.com/users/craigtaverner/events{/privacy}","received_events_url":"https://api.github.com/users/craigtaverner/received_events","type":"User","site_admin":false},"body":"That is an option. The 'if' statement would occur elsewhere, so this is just moving code around a bit. We went for this approach here partly because it was more similar to where we think things will go in future when we write richer access control into the statement. Right now there is a 1:1:1 mapping from the kernel statement methods, access mode and exceptions thrown, so either solution is fine, but in future we think it might be more complex. For example, the AccessMode might not have enough knowledge to compose the message in the exception, and that would need to be done in the statement. I'd prefer to keep things the way they are here.","created_at":"2016-03-01T16:05:34Z","updated_at":"2016-03-01T16:05:34Z","html_url":"https://github.com/neo4j/neo4j/pull/6535#discussion_r54588854","pull_request_url":"https://api.github.com/repos/neo4j/neo4j/pulls/6535","_links":{"self":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/comments/54588854"},"html":{"href":"https://github.com/neo4j/neo4j/pull/6535#discussion_r54588854"},"pull_request":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/6535"}}},"pull_request":{"url":"https://api.github.com/repos/neo4j/neo4j/pulls/6535","id":60837686,"html_url":"https://github.com/neo4j/neo4j/pull/6535","diff_url":"https://github.com/neo4j/neo4j/pull/6535.diff","patch_url":"https://github.com/neo4j/neo4j/pull/6535.patch","issue_url":"https://api.github.com/repos/neo4j/neo4j/issues/6535","number":6535,"state":"open","locked":false,"title":"Support AccessMode.NONE","user":{"login":"craigtaverner","id":114451,"avatar_url":"https://avatars.githubusercontent.com/u/114451?v=3","gravatar_id":"","url":"https://api.github.com/users/craigtaverner","html_url":"https://github.com/craigtaverner","followers_url":"https://api.github.com/users/craigtaverner/followers","following_url":"https://api.github.com/users/craigtaverner/following{/other_user}","gists_url":"https://api.github.com/users/craigtaverner/gists{/gist_id}","starred_url":"https://api.github.com/users/craigtaverner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/craigtaverner/subscriptions","organizations_url":"https://api.github.com/users/craigtaverner/orgs","repos_url":"https://api.github.com/users/craigtaverner/repos","events_url":"https://api.github.com/users/craigtaverner/events{/privacy}","received_events_url":"https://api.github.com/users/craigtaverner/received_events","type":"User","site_admin":false},"body":"Support the concept of an AccessMode.NONE allowing transactions to be created, but no actual operations to be performed. This is required in order to allow admin activities through Cypher that do not touch the database, like password change.","created_at":"2016-02-26T12:53:48Z","updated_at":"2016-03-01T16:05:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"418e8e1f377b756f04f70a4ca2f38cd23a6afb70","assignee":{"login":"MishaDemianenko","id":12656787,"avatar_url":"https://avatars.githubusercontent.com/u/12656787?v=3","gravatar_id":"","url":"https://api.github.com/users/MishaDemianenko","html_url":"https://github.com/MishaDemianenko","followers_url":"https://api.github.com/users/MishaDemianenko/followers","following_url":"https://api.github.com/users/MishaDemianenko/following{/other_user}","gists_url":"https://api.github.com/users/MishaDemianenko/gists{/gist_id}","starred_url":"https://api.github.com/users/MishaDemianenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MishaDemianenko/subscriptions","organizations_url":"https://api.github.com/users/MishaDemianenko/orgs","repos_url":"https://api.github.com/users/MishaDemianenko/repos","events_url":"https://api.github.com/users/MishaDemianenko/events{/privacy}","received_events_url":"https://api.github.com/users/MishaDemianenko/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/neo4j/neo4j/pulls/6535/commits","review_comments_url":"https://api.github.com/repos/neo4j/neo4j/pulls/6535/comments","review_comment_url":"https://api.github.com/repos/neo4j/neo4j/pulls/comments{/number}","comments_url":"https://api.github.com/repos/neo4j/neo4j/issues/6535/comments","statuses_url":"https://api.github.com/repos/neo4j/neo4j/statuses/3edb739fea3c9e0d7e12135cc744f2d7c28798ec","head":{"label":"craigtaverner:3.0-auth-none","ref":"3.0-auth-none","sha":"3edb739fea3c9e0d7e12135cc744f2d7c28798ec","user":{"login":"craigtaverner","id":114451,"avatar_url":"https://avatars.githubusercontent.com/u/114451?v=3","gravatar_id":"","url":"https://api.github.com/users/craigtaverner","html_url":"https://github.com/craigtaverner","followers_url":"https://api.github.com/users/craigtaverner/followers","following_url":"https://api.github.com/users/craigtaverner/following{/other_user}","gists_url":"https://api.github.com/users/craigtaverner/gists{/gist_id}","starred_url":"https://api.github.com/users/craigtaverner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/craigtaverner/subscriptions","organizations_url":"https://api.github.com/users/craigtaverner/orgs","repos_url":"https://api.github.com/users/craigtaverner/repos","events_url":"https://api.github.com/users/craigtaverner/events{/privacy}","received_events_url":"https://api.github.com/users/craigtaverner/received_events","type":"User","site_admin":false},"repo":{"id":17599080,"name":"neo4j","full_name":"craigtaverner/neo4j","owner":{"login":"craigtaverner","id":114451,"avatar_url":"https://avatars.githubusercontent.com/u/114451?v=3","gravatar_id":"","url":"https://api.github.com/users/craigtaverner","html_url":"https://github.com/craigtaverner","followers_url":"https://api.github.com/users/craigtaverner/followers","following_url":"https://api.github.com/users/craigtaverner/following{/other_user}","gists_url":"https://api.github.com/users/craigtaverner/gists{/gist_id}","starred_url":"https://api.github.com/users/craigtaverner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/craigtaverner/subscriptions","organizations_url":"https://api.github.com/users/craigtaverner/orgs","repos_url":"https://api.github.com/users/craigtaverner/repos","events_url":"https://api.github.com/users/craigtaverner/events{/privacy}","received_events_url":"https://api.github.com/users/craigtaverner/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/craigtaverner/neo4j","description":"The World's Leading Graph Database","fork":true,"url":"https://api.github.com/repos/craigtaverner/neo4j","forks_url":"https://api.github.com/repos/craigtaverner/neo4j/forks","keys_url":"https://api.github.com/repos/craigtaverner/neo4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/craigtaverner/neo4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/craigtaverner/neo4j/teams","hooks_url":"https://api.github.com/repos/craigtaverner/neo4j/hooks","issue_events_url":"https://api.github.com/repos/craigtaverner/neo4j/issues/events{/number}","events_url":"https://api.github.com/repos/craigtaverner/neo4j/events","assignees_url":"https://api.github.com/repos/craigtaverner/neo4j/assignees{/user}","branches_url":"https://api.github.com/repos/craigtaverner/neo4j/branches{/branch}","tags_url":"https://api.github.com/repos/craigtaverner/neo4j/tags","blobs_url":"https://api.github.com/repos/craigtaverner/neo4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/craigtaverner/neo4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/craigtaverner/neo4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/craigtaverner/neo4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/craigtaverner/neo4j/statuses/{sha}","languages_url":"https://api.github.com/repos/craigtaverner/neo4j/languages","stargazers_url":"https://api.github.com/repos/craigtaverner/neo4j/stargazers","contributors_url":"https://api.github.com/repos/craigtaverner/neo4j/contributors","subscribers_url":"https://api.github.com/repos/craigtaverner/neo4j/subscribers","subscription_url":"https://api.github.com/repos/craigtaverner/neo4j/subscription","commits_url":"https://api.github.com/repos/craigtaverner/neo4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/craigtaverner/neo4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/craigtaverner/neo4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/craigtaverner/neo4j/issues/comments{/number}","contents_url":"https://api.github.com/repos/craigtaverner/neo4j/contents/{+path}","compare_url":"https://api.github.com/repos/craigtaverner/neo4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/craigtaverner/neo4j/merges","archive_url":"https://api.github.com/repos/craigtaverner/neo4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/craigtaverner/neo4j/downloads","issues_url":"https://api.github.com/repos/craigtaverner/neo4j/issues{/number}","pulls_url":"https://api.github.com/repos/craigtaverner/neo4j/pulls{/number}","milestones_url":"https://api.github.com/repos/craigtaverner/neo4j/milestones{/number}","notifications_url":"https://api.github.com/repos/craigtaverner/neo4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/craigtaverner/neo4j/labels{/name}","releases_url":"https://api.github.com/repos/craigtaverner/neo4j/releases{/id}","deployments_url":"https://api.github.com/repos/craigtaverner/neo4j/deployments","created_at":"2014-03-10T16:12:05Z","updated_at":"2015-03-14T12:35:18Z","pushed_at":"2016-03-01T15:43:13Z","git_url":"git://github.com/craigtaverner/neo4j.git","ssh_url":"git@github.com:craigtaverner/neo4j.git","clone_url":"https://github.com/craigtaverner/neo4j.git","svn_url":"https://github.com/craigtaverner/neo4j","homepage":"http://neo4j.org","size":289872,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"neo4j:3.0","ref":"3.0","sha":"dcf58f0717b26e8b5b903ff2fd5529189772f918","user":{"login":"neo4j","id":201120,"avatar_url":"https://avatars.githubusercontent.com/u/201120?v=3","gravatar_id":"","url":"https://api.github.com/users/neo4j","html_url":"https://github.com/neo4j","followers_url":"https://api.github.com/users/neo4j/followers","following_url":"https://api.github.com/users/neo4j/following{/other_user}","gists_url":"https://api.github.com/users/neo4j/gists{/gist_id}","starred_url":"https://api.github.com/users/neo4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neo4j/subscriptions","organizations_url":"https://api.github.com/users/neo4j/orgs","repos_url":"https://api.github.com/users/neo4j/repos","events_url":"https://api.github.com/users/neo4j/events{/privacy}","received_events_url":"https://api.github.com/users/neo4j/received_events","type":"Organization","site_admin":false},"repo":{"id":6650539,"name":"neo4j","full_name":"neo4j/neo4j","owner":{"login":"neo4j","id":201120,"avatar_url":"https://avatars.githubusercontent.com/u/201120?v=3","gravatar_id":"","url":"https://api.github.com/users/neo4j","html_url":"https://github.com/neo4j","followers_url":"https://api.github.com/users/neo4j/followers","following_url":"https://api.github.com/users/neo4j/following{/other_user}","gists_url":"https://api.github.com/users/neo4j/gists{/gist_id}","starred_url":"https://api.github.com/users/neo4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neo4j/subscriptions","organizations_url":"https://api.github.com/users/neo4j/orgs","repos_url":"https://api.github.com/users/neo4j/repos","events_url":"https://api.github.com/users/neo4j/events{/privacy}","received_events_url":"https://api.github.com/users/neo4j/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/neo4j/neo4j","description":"Graphs for Everyone","fork":false,"url":"https://api.github.com/repos/neo4j/neo4j","forks_url":"https://api.github.com/repos/neo4j/neo4j/forks","keys_url":"https://api.github.com/repos/neo4j/neo4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neo4j/neo4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neo4j/neo4j/teams","hooks_url":"https://api.github.com/repos/neo4j/neo4j/hooks","issue_events_url":"https://api.github.com/repos/neo4j/neo4j/issues/events{/number}","events_url":"https://api.github.com/repos/neo4j/neo4j/events","assignees_url":"https://api.github.com/repos/neo4j/neo4j/assignees{/user}","branches_url":"https://api.github.com/repos/neo4j/neo4j/branches{/branch}","tags_url":"https://api.github.com/repos/neo4j/neo4j/tags","blobs_url":"https://api.github.com/repos/neo4j/neo4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neo4j/neo4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neo4j/neo4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/neo4j/neo4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neo4j/neo4j/statuses/{sha}","languages_url":"https://api.github.com/repos/neo4j/neo4j/languages","stargazers_url":"https://api.github.com/repos/neo4j/neo4j/stargazers","contributors_url":"https://api.github.com/repos/neo4j/neo4j/contributors","subscribers_url":"https://api.github.com/repos/neo4j/neo4j/subscribers","subscription_url":"https://api.github.com/repos/neo4j/neo4j/subscription","commits_url":"https://api.github.com/repos/neo4j/neo4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/neo4j/neo4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/neo4j/neo4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/neo4j/neo4j/issues/comments{/number}","contents_url":"https://api.github.com/repos/neo4j/neo4j/contents/{+path}","compare_url":"https://api.github.com/repos/neo4j/neo4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neo4j/neo4j/merges","archive_url":"https://api.github.com/repos/neo4j/neo4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neo4j/neo4j/downloads","issues_url":"https://api.github.com/repos/neo4j/neo4j/issues{/number}","pulls_url":"https://api.github.com/repos/neo4j/neo4j/pulls{/number}","milestones_url":"https://api.github.com/repos/neo4j/neo4j/milestones{/number}","notifications_url":"https://api.github.com/repos/neo4j/neo4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neo4j/neo4j/labels{/name}","releases_url":"https://api.github.com/repos/neo4j/neo4j/releases{/id}","deployments_url":"https://api.github.com/repos/neo4j/neo4j/deployments","created_at":"2012-11-12T08:46:15Z","updated_at":"2016-03-01T15:50:16Z","pushed_at":"2016-03-01T15:54:51Z","git_url":"git://github.com/neo4j/neo4j.git","ssh_url":"git@github.com:neo4j/neo4j.git","clone_url":"https://github.com/neo4j/neo4j.git","svn_url":"https://github.com/neo4j/neo4j","homepage":"http://neo4j.com","size":337781,"stargazers_count":2381,"watchers_count":2381,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":850,"mirror_url":null,"open_issues_count":380,"forks":850,"open_issues":380,"watchers":2381,"default_branch":"3.0"}},"_links":{"self":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/6535"},"html":{"href":"https://github.com/neo4j/neo4j/pull/6535"},"issue":{"href":"https://api.github.com/repos/neo4j/neo4j/issues/6535"},"comments":{"href":"https://api.github.com/repos/neo4j/neo4j/issues/6535/comments"},"review_comments":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/6535/comments"},"review_comment":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/6535/commits"},"statuses":{"href":"https://api.github.com/repos/neo4j/neo4j/statuses/3edb739fea3c9e0d7e12135cc744f2d7c28798ec"}}}}