{"action":"created","comment":{"url":"https://api.github.com/repos/gammapy/gammapy/pulls/comments/63926166","id":63926166,"diff_hunk":"@@ -0,0 +1,71 @@\n+#Licensed under a 3-clause BSD style license - see LICENSE.rst\n+\n+from __future__ import absolute_import, division, print_function, unicode_literals\n+from ..utils.nddata import NDDataArray, DataAxis, BinnedDataAxis\n+from collections import OrderedDict\n+import numpy as np\n+\n+class EffectiveArea2D(NDDataArray):\n+    \"\"\"2D effective area table\n+\n+    Axes: ``THETA``, ``ENERG``","path":"gammapy/irf/effective_area.py","position":11,"original_position":11,"commit_id":"69101fc5152a3a60367a5c9d6055652764d38048","original_commit_id":"93e1b1332862bd05843f031a3e83ef7deddd3109","user":{"login":"cdeil","id":852409,"avatar_url":"https://avatars.githubusercontent.com/u/852409?v=3","gravatar_id":"","url":"https://api.github.com/users/cdeil","html_url":"https://github.com/cdeil","followers_url":"https://api.github.com/users/cdeil/followers","following_url":"https://api.github.com/users/cdeil/following{/other_user}","gists_url":"https://api.github.com/users/cdeil/gists{/gist_id}","starred_url":"https://api.github.com/users/cdeil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdeil/subscriptions","organizations_url":"https://api.github.com/users/cdeil/orgs","repos_url":"https://api.github.com/users/cdeil/repos","events_url":"https://api.github.com/users/cdeil/events{/privacy}","received_events_url":"https://api.github.com/users/cdeil/received_events","type":"User","site_admin":false},"body":"Yes, probably a mechanism to map FITS axis names to something else would be nice, for cases where the FITS names are cryptic.","created_at":"2016-05-19T18:02:54Z","updated_at":"2016-05-19T18:02:54Z","html_url":"https://github.com/gammapy/gammapy/pull/527#discussion_r63926166","pull_request_url":"https://api.github.com/repos/gammapy/gammapy/pulls/527","_links":{"self":{"href":"https://api.github.com/repos/gammapy/gammapy/pulls/comments/63926166"},"html":{"href":"https://github.com/gammapy/gammapy/pull/527#discussion_r63926166"},"pull_request":{"href":"https://api.github.com/repos/gammapy/gammapy/pulls/527"}}},"pull_request":{"url":"https://api.github.com/repos/gammapy/gammapy/pulls/527","id":69504989,"html_url":"https://github.com/gammapy/gammapy/pull/527","diff_url":"https://github.com/gammapy/gammapy/pull/527.diff","patch_url":"https://github.com/gammapy/gammapy/pull/527.patch","issue_url":"https://api.github.com/repos/gammapy/gammapy/issues/527","number":527,"state":"open","locked":false,"title":"ND data base class for gammapy.irf ","user":{"login":"joleroi","id":11678435,"avatar_url":"https://avatars.githubusercontent.com/u/11678435?v=3","gravatar_id":"","url":"https://api.github.com/users/joleroi","html_url":"https://github.com/joleroi","followers_url":"https://api.github.com/users/joleroi/followers","following_url":"https://api.github.com/users/joleroi/following{/other_user}","gists_url":"https://api.github.com/users/joleroi/gists{/gist_id}","starred_url":"https://api.github.com/users/joleroi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joleroi/subscriptions","organizations_url":"https://api.github.com/users/joleroi/orgs","repos_url":"https://api.github.com/users/joleroi/repos","events_url":"https://api.github.com/users/joleroi/events{/privacy}","received_events_url":"https://api.github.com/users/joleroi/received_events","type":"User","site_admin":false},"body":"This PR introduces a base class to be used (potentially) firstly in gammapy.irf and maybe in other places. For an example see \r\n\r\nhttps://github.com/gammapy/gammapy-extra/blob/master/notebooks/nddata_demo.ipynb\r\n\r\nAn scratch EffectiveArea2D class that subclasses the NDData class is also part of this PR","created_at":"2016-05-10T13:23:20Z","updated_at":"2016-05-19T18:02:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5266389de4d02e4d5908bd09a690763461b86251","assignee":{"login":"cdeil","id":852409,"avatar_url":"https://avatars.githubusercontent.com/u/852409?v=3","gravatar_id":"","url":"https://api.github.com/users/cdeil","html_url":"https://github.com/cdeil","followers_url":"https://api.github.com/users/cdeil/followers","following_url":"https://api.github.com/users/cdeil/following{/other_user}","gists_url":"https://api.github.com/users/cdeil/gists{/gist_id}","starred_url":"https://api.github.com/users/cdeil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdeil/subscriptions","organizations_url":"https://api.github.com/users/cdeil/orgs","repos_url":"https://api.github.com/users/cdeil/repos","events_url":"https://api.github.com/users/cdeil/events{/privacy}","received_events_url":"https://api.github.com/users/cdeil/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/gammapy/gammapy/milestones/7","html_url":"https://github.com/gammapy/gammapy/milestones/0.5","labels_url":"https://api.github.com/repos/gammapy/gammapy/milestones/7/labels","id":1275561,"number":7,"title":"0.5","description":"","creator":{"login":"cdeil","id":852409,"avatar_url":"https://avatars.githubusercontent.com/u/852409?v=3","gravatar_id":"","url":"https://api.github.com/users/cdeil","html_url":"https://github.com/cdeil","followers_url":"https://api.github.com/users/cdeil/followers","following_url":"https://api.github.com/users/cdeil/following{/other_user}","gists_url":"https://api.github.com/users/cdeil/gists{/gist_id}","starred_url":"https://api.github.com/users/cdeil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdeil/subscriptions","organizations_url":"https://api.github.com/users/cdeil/orgs","repos_url":"https://api.github.com/users/cdeil/repos","events_url":"https://api.github.com/users/cdeil/events{/privacy}","received_events_url":"https://api.github.com/users/cdeil/received_events","type":"User","site_admin":false},"open_issues":78,"closed_issues":11,"state":"open","created_at":"2015-08-27T09:29:48Z","updated_at":"2016-05-19T17:56:29Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/gammapy/gammapy/pulls/527/commits","review_comments_url":"https://api.github.com/repos/gammapy/gammapy/pulls/527/comments","review_comment_url":"https://api.github.com/repos/gammapy/gammapy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gammapy/gammapy/issues/527/comments","statuses_url":"https://api.github.com/repos/gammapy/gammapy/statuses/69101fc5152a3a60367a5c9d6055652764d38048","head":{"label":"joleroi:nddata","ref":"nddata","sha":"69101fc5152a3a60367a5c9d6055652764d38048","user":{"login":"joleroi","id":11678435,"avatar_url":"https://avatars.githubusercontent.com/u/11678435?v=3","gravatar_id":"","url":"https://api.github.com/users/joleroi","html_url":"https://github.com/joleroi","followers_url":"https://api.github.com/users/joleroi/followers","following_url":"https://api.github.com/users/joleroi/following{/other_user}","gists_url":"https://api.github.com/users/joleroi/gists{/gist_id}","starred_url":"https://api.github.com/users/joleroi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joleroi/subscriptions","organizations_url":"https://api.github.com/users/joleroi/orgs","repos_url":"https://api.github.com/users/joleroi/repos","events_url":"https://api.github.com/users/joleroi/events{/privacy}","received_events_url":"https://api.github.com/users/joleroi/received_events","type":"User","site_admin":false},"repo":{"id":34865384,"name":"gammapy","full_name":"joleroi/gammapy","owner":{"login":"joleroi","id":11678435,"avatar_url":"https://avatars.githubusercontent.com/u/11678435?v=3","gravatar_id":"","url":"https://api.github.com/users/joleroi","html_url":"https://github.com/joleroi","followers_url":"https://api.github.com/users/joleroi/followers","following_url":"https://api.github.com/users/joleroi/following{/other_user}","gists_url":"https://api.github.com/users/joleroi/gists{/gist_id}","starred_url":"https://api.github.com/users/joleroi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joleroi/subscriptions","organizations_url":"https://api.github.com/users/joleroi/orgs","repos_url":"https://api.github.com/users/joleroi/repos","events_url":"https://api.github.com/users/joleroi/events{/privacy}","received_events_url":"https://api.github.com/users/joleroi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/joleroi/gammapy","description":"A Python package for gamma-ray astronomy","fork":true,"url":"https://api.github.com/repos/joleroi/gammapy","forks_url":"https://api.github.com/repos/joleroi/gammapy/forks","keys_url":"https://api.github.com/repos/joleroi/gammapy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joleroi/gammapy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joleroi/gammapy/teams","hooks_url":"https://api.github.com/repos/joleroi/gammapy/hooks","issue_events_url":"https://api.github.com/repos/joleroi/gammapy/issues/events{/number}","events_url":"https://api.github.com/repos/joleroi/gammapy/events","assignees_url":"https://api.github.com/repos/joleroi/gammapy/assignees{/user}","branches_url":"https://api.github.com/repos/joleroi/gammapy/branches{/branch}","tags_url":"https://api.github.com/repos/joleroi/gammapy/tags","blobs_url":"https://api.github.com/repos/joleroi/gammapy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joleroi/gammapy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joleroi/gammapy/git/refs{/sha}","trees_url":"https://api.github.com/repos/joleroi/gammapy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joleroi/gammapy/statuses/{sha}","languages_url":"https://api.github.com/repos/joleroi/gammapy/languages","stargazers_url":"https://api.github.com/repos/joleroi/gammapy/stargazers","contributors_url":"https://api.github.com/repos/joleroi/gammapy/contributors","subscribers_url":"https://api.github.com/repos/joleroi/gammapy/subscribers","subscription_url":"https://api.github.com/repos/joleroi/gammapy/subscription","commits_url":"https://api.github.com/repos/joleroi/gammapy/commits{/sha}","git_commits_url":"https://api.github.com/repos/joleroi/gammapy/git/commits{/sha}","comments_url":"https://api.github.com/repos/joleroi/gammapy/comments{/number}","issue_comment_url":"https://api.github.com/repos/joleroi/gammapy/issues/comments{/number}","contents_url":"https://api.github.com/repos/joleroi/gammapy/contents/{+path}","compare_url":"https://api.github.com/repos/joleroi/gammapy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joleroi/gammapy/merges","archive_url":"https://api.github.com/repos/joleroi/gammapy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joleroi/gammapy/downloads","issues_url":"https://api.github.com/repos/joleroi/gammapy/issues{/number}","pulls_url":"https://api.github.com/repos/joleroi/gammapy/pulls{/number}","milestones_url":"https://api.github.com/repos/joleroi/gammapy/milestones{/number}","notifications_url":"https://api.github.com/repos/joleroi/gammapy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joleroi/gammapy/labels{/name}","releases_url":"https://api.github.com/repos/joleroi/gammapy/releases{/id}","deployments_url":"https://api.github.com/repos/joleroi/gammapy/deployments","created_at":"2015-04-30T16:42:10Z","updated_at":"2015-04-30T16:42:10Z","pushed_at":"2016-05-19T13:30:23Z","git_url":"git://github.com/joleroi/gammapy.git","ssh_url":"git@github.com:joleroi/gammapy.git","clone_url":"https://github.com/joleroi/gammapy.git","svn_url":"https://github.com/joleroi/gammapy","homepage":"https://gammapy.readthedocs.org/","size":5625,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gammapy:master","ref":"master","sha":"e8a14b55f0de19211f509179395db48aa43d72f8","user":{"login":"gammapy","id":852764,"avatar_url":"https://avatars.githubusercontent.com/u/852764?v=3","gravatar_id":"","url":"https://api.github.com/users/gammapy","html_url":"https://github.com/gammapy","followers_url":"https://api.github.com/users/gammapy/followers","following_url":"https://api.github.com/users/gammapy/following{/other_user}","gists_url":"https://api.github.com/users/gammapy/gists{/gist_id}","starred_url":"https://api.github.com/users/gammapy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gammapy/subscriptions","organizations_url":"https://api.github.com/users/gammapy/orgs","repos_url":"https://api.github.com/users/gammapy/repos","events_url":"https://api.github.com/users/gammapy/events{/privacy}","received_events_url":"https://api.github.com/users/gammapy/received_events","type":"Organization","site_admin":false},"repo":{"id":10073640,"name":"gammapy","full_name":"gammapy/gammapy","owner":{"login":"gammapy","id":852764,"avatar_url":"https://avatars.githubusercontent.com/u/852764?v=3","gravatar_id":"","url":"https://api.github.com/users/gammapy","html_url":"https://github.com/gammapy","followers_url":"https://api.github.com/users/gammapy/followers","following_url":"https://api.github.com/users/gammapy/following{/other_user}","gists_url":"https://api.github.com/users/gammapy/gists{/gist_id}","starred_url":"https://api.github.com/users/gammapy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gammapy/subscriptions","organizations_url":"https://api.github.com/users/gammapy/orgs","repos_url":"https://api.github.com/users/gammapy/repos","events_url":"https://api.github.com/users/gammapy/events{/privacy}","received_events_url":"https://api.github.com/users/gammapy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gammapy/gammapy","description":"A Python package for gamma-ray astronomy","fork":false,"url":"https://api.github.com/repos/gammapy/gammapy","forks_url":"https://api.github.com/repos/gammapy/gammapy/forks","keys_url":"https://api.github.com/repos/gammapy/gammapy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gammapy/gammapy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gammapy/gammapy/teams","hooks_url":"https://api.github.com/repos/gammapy/gammapy/hooks","issue_events_url":"https://api.github.com/repos/gammapy/gammapy/issues/events{/number}","events_url":"https://api.github.com/repos/gammapy/gammapy/events","assignees_url":"https://api.github.com/repos/gammapy/gammapy/assignees{/user}","branches_url":"https://api.github.com/repos/gammapy/gammapy/branches{/branch}","tags_url":"https://api.github.com/repos/gammapy/gammapy/tags","blobs_url":"https://api.github.com/repos/gammapy/gammapy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gammapy/gammapy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gammapy/gammapy/git/refs{/sha}","trees_url":"https://api.github.com/repos/gammapy/gammapy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gammapy/gammapy/statuses/{sha}","languages_url":"https://api.github.com/repos/gammapy/gammapy/languages","stargazers_url":"https://api.github.com/repos/gammapy/gammapy/stargazers","contributors_url":"https://api.github.com/repos/gammapy/gammapy/contributors","subscribers_url":"https://api.github.com/repos/gammapy/gammapy/subscribers","subscription_url":"https://api.github.com/repos/gammapy/gammapy/subscription","commits_url":"https://api.github.com/repos/gammapy/gammapy/commits{/sha}","git_commits_url":"https://api.github.com/repos/gammapy/gammapy/git/commits{/sha}","comments_url":"https://api.github.com/repos/gammapy/gammapy/comments{/number}","issue_comment_url":"https://api.github.com/repos/gammapy/gammapy/issues/comments{/number}","contents_url":"https://api.github.com/repos/gammapy/gammapy/contents/{+path}","compare_url":"https://api.github.com/repos/gammapy/gammapy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gammapy/gammapy/merges","archive_url":"https://api.github.com/repos/gammapy/gammapy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gammapy/gammapy/downloads","issues_url":"https://api.github.com/repos/gammapy/gammapy/issues{/number}","pulls_url":"https://api.github.com/repos/gammapy/gammapy/pulls{/number}","milestones_url":"https://api.github.com/repos/gammapy/gammapy/milestones{/number}","notifications_url":"https://api.github.com/repos/gammapy/gammapy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gammapy/gammapy/labels{/name}","releases_url":"https://api.github.com/repos/gammapy/gammapy/releases{/id}","deployments_url":"https://api.github.com/repos/gammapy/gammapy/deployments","created_at":"2013-05-15T07:50:40Z","updated_at":"2016-04-21T13:35:29Z","pushed_at":"2016-05-19T17:19:13Z","git_url":"git://github.com/gammapy/gammapy.git","ssh_url":"git@github.com:gammapy/gammapy.git","clone_url":"https://github.com/gammapy/gammapy.git","svn_url":"https://github.com/gammapy/gammapy","homepage":"https://gammapy.readthedocs.org/","size":6169,"stargazers_count":22,"watchers_count":22,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":39,"mirror_url":null,"open_issues_count":143,"forks":39,"open_issues":143,"watchers":22,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gammapy/gammapy/pulls/527"},"html":{"href":"https://github.com/gammapy/gammapy/pull/527"},"issue":{"href":"https://api.github.com/repos/gammapy/gammapy/issues/527"},"comments":{"href":"https://api.github.com/repos/gammapy/gammapy/issues/527/comments"},"review_comments":{"href":"https://api.github.com/repos/gammapy/gammapy/pulls/527/comments"},"review_comment":{"href":"https://api.github.com/repos/gammapy/gammapy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gammapy/gammapy/pulls/527/commits"},"statuses":{"href":"https://api.github.com/repos/gammapy/gammapy/statuses/69101fc5152a3a60367a5c9d6055652764d38048"}}}}