{"action":"created","comment":{"url":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/pulls/comments/91983931","pull_request_review_id":12493180,"id":91983931,"diff_hunk":"@@ -191,6 +196,28 @@ class LogStash::Outputs::ElasticSearch < LogStash::Outputs::Base\n   # have become stale (half-closed) while kept inactive in the pool.'\n   # See https://hc.apache.org/httpcomponents-client-ga/httpclient/apidocs/org/apache/http/impl/conn/PoolingHttpClientConnectionManager.html#setValidateAfterInactivity(int)[these docs for more info]\n   config :validate_after_inactivity, :validate => :number, :default => 10000\n+  \n+  # This is the maximum size HTTP request this plugin will attempt to send.\n+  #\n+  # This plugin will try to send appropriately sized requests, using multiple\n+  # requests per batch if the events are very large, but if a single event\n+  # is larger than this value sending even that single request will break. ","path":"lib/logstash/outputs/elasticsearch.rb","position":42,"original_position":42,"commit_id":"b4341de2b8988c01f785a7b8e0020138481fe1f8","original_commit_id":"b4341de2b8988c01f785a7b8e0020138481fe1f8","user":{"login":"jordansissel","id":131818,"avatar_url":"https://avatars.githubusercontent.com/u/131818?v=3","gravatar_id":"","url":"https://api.github.com/users/jordansissel","html_url":"https://github.com/jordansissel","followers_url":"https://api.github.com/users/jordansissel/followers","following_url":"https://api.github.com/users/jordansissel/following{/other_user}","gists_url":"https://api.github.com/users/jordansissel/gists{/gist_id}","starred_url":"https://api.github.com/users/jordansissel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jordansissel/subscriptions","organizations_url":"https://api.github.com/users/jordansissel/orgs","repos_url":"https://api.github.com/users/jordansissel/repos","events_url":"https://api.github.com/users/jordansissel/events{/privacy}","received_events_url":"https://api.github.com/users/jordansissel/received_events","type":"User","site_admin":false},"body":"\"will break\" --- it will break what?","created_at":"2016-12-12T16:33:29Z","updated_at":"2016-12-12T16:46:46Z","html_url":"https://github.com/logstash-plugins/logstash-output-elasticsearch/pull/523#discussion_r91983931","pull_request_url":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/pulls/523","_links":{"self":{"href":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/pulls/comments/91983931"},"html":{"href":"https://github.com/logstash-plugins/logstash-output-elasticsearch/pull/523#discussion_r91983931"},"pull_request":{"href":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/pulls/523"}}},"pull_request":{"url":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/pulls/523","id":96787243,"html_url":"https://github.com/logstash-plugins/logstash-output-elasticsearch/pull/523","diff_url":"https://github.com/logstash-plugins/logstash-output-elasticsearch/pull/523.diff","patch_url":"https://github.com/logstash-plugins/logstash-output-elasticsearch/pull/523.patch","issue_url":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/issues/523","number":523,"state":"open","locked":false,"title":"Always retry full-request failures","user":{"login":"andrewvc","id":131427,"avatar_url":"https://avatars.githubusercontent.com/u/131427?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewvc","html_url":"https://github.com/andrewvc","followers_url":"https://api.github.com/users/andrewvc/followers","following_url":"https://api.github.com/users/andrewvc/following{/other_user}","gists_url":"https://api.github.com/users/andrewvc/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewvc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewvc/subscriptions","organizations_url":"https://api.github.com/users/andrewvc/orgs","repos_url":"https://api.github.com/users/andrewvc/repos","events_url":"https://api.github.com/users/andrewvc/events{/privacy}","received_events_url":"https://api.github.com/users/andrewvc/received_events","type":"User","site_admin":false},"body":"We now always retry full-request failures. It makes no sense to stop retrying a bulk request because the bulk API should always return 200. In any other situation we may lose data. Sometimes a full request can legitimately fail if there is a too-large request size from a too-large event. To fix this we now check before sending requests if the size is too large, and have added a new max_request_size option to configure this.\r\n\r\nFixes #522","created_at":"2016-12-06T19:15:53Z","updated_at":"2016-12-12T16:46:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e90610f2246afa20ad29396ec9edd2a91408c354","assignee":{"login":"andrewvc","id":131427,"avatar_url":"https://avatars.githubusercontent.com/u/131427?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewvc","html_url":"https://github.com/andrewvc","followers_url":"https://api.github.com/users/andrewvc/followers","following_url":"https://api.github.com/users/andrewvc/following{/other_user}","gists_url":"https://api.github.com/users/andrewvc/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewvc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewvc/subscriptions","organizations_url":"https://api.github.com/users/andrewvc/orgs","repos_url":"https://api.github.com/users/andrewvc/repos","events_url":"https://api.github.com/users/andrewvc/events{/privacy}","received_events_url":"https://api.github.com/users/andrewvc/received_events","type":"User","site_admin":false},"assignees":[{"login":"andrewvc","id":131427,"avatar_url":"https://avatars.githubusercontent.com/u/131427?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewvc","html_url":"https://github.com/andrewvc","followers_url":"https://api.github.com/users/andrewvc/followers","following_url":"https://api.github.com/users/andrewvc/following{/other_user}","gists_url":"https://api.github.com/users/andrewvc/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewvc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewvc/subscriptions","organizations_url":"https://api.github.com/users/andrewvc/orgs","repos_url":"https://api.github.com/users/andrewvc/repos","events_url":"https://api.github.com/users/andrewvc/events{/privacy}","received_events_url":"https://api.github.com/users/andrewvc/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/pulls/523/commits","review_comments_url":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/pulls/523/comments","review_comment_url":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/issues/523/comments","statuses_url":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/statuses/b4341de2b8988c01f785a7b8e0020138481fe1f8","head":{"label":"andrewvc:fix-retry-behavior","ref":"fix-retry-behavior","sha":"b4341de2b8988c01f785a7b8e0020138481fe1f8","user":{"login":"andrewvc","id":131427,"avatar_url":"https://avatars.githubusercontent.com/u/131427?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewvc","html_url":"https://github.com/andrewvc","followers_url":"https://api.github.com/users/andrewvc/followers","following_url":"https://api.github.com/users/andrewvc/following{/other_user}","gists_url":"https://api.github.com/users/andrewvc/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewvc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewvc/subscriptions","organizations_url":"https://api.github.com/users/andrewvc/orgs","repos_url":"https://api.github.com/users/andrewvc/repos","events_url":"https://api.github.com/users/andrewvc/events{/privacy}","received_events_url":"https://api.github.com/users/andrewvc/received_events","type":"User","site_admin":false},"repo":{"id":37491407,"name":"logstash-output-elasticsearch","full_name":"andrewvc/logstash-output-elasticsearch","owner":{"login":"andrewvc","id":131427,"avatar_url":"https://avatars.githubusercontent.com/u/131427?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewvc","html_url":"https://github.com/andrewvc","followers_url":"https://api.github.com/users/andrewvc/followers","following_url":"https://api.github.com/users/andrewvc/following{/other_user}","gists_url":"https://api.github.com/users/andrewvc/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewvc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewvc/subscriptions","organizations_url":"https://api.github.com/users/andrewvc/orgs","repos_url":"https://api.github.com/users/andrewvc/repos","events_url":"https://api.github.com/users/andrewvc/events{/privacy}","received_events_url":"https://api.github.com/users/andrewvc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andrewvc/logstash-output-elasticsearch","description":null,"fork":true,"url":"https://api.github.com/repos/andrewvc/logstash-output-elasticsearch","forks_url":"https://api.github.com/repos/andrewvc/logstash-output-elasticsearch/forks","keys_url":"https://api.github.com/repos/andrewvc/logstash-output-elasticsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andrewvc/logstash-output-elasticsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andrewvc/logstash-output-elasticsearch/teams","hooks_url":"https://api.github.com/repos/andrewvc/logstash-output-elasticsearch/hooks","issue_events_url":"https://api.github.com/repos/andrewvc/logstash-output-elasticsearch/issues/events{/number}","events_url":"https://api.github.com/repos/andrewvc/logstash-output-elasticsearch/events","assignees_url":"https://api.github.com/repos/andrewvc/logstash-output-elasticsearch/assignees{/user}","branches_url":"https://api.github.com/repos/andrewvc/logstash-output-elasticsearch/branches{/branch}","tags_url":"https://api.github.com/repos/andrewvc/logstash-output-elasticsearch/tags","blobs_url":"https://api.github.com/repos/andrewvc/logstash-output-elasticsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andrewvc/logstash-output-elasticsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andrewvc/logstash-output-elasticsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/andrewvc/logstash-output-elasticsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andrewvc/logstash-output-elasticsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/andrewvc/logstash-output-elasticsearch/languages","stargazers_url":"https://api.github.com/repos/andrewvc/logstash-output-elasticsearch/stargazers","contributors_url":"https://api.github.com/repos/andrewvc/logstash-output-elasticsearch/contributors","subscribers_url":"https://api.github.com/repos/andrewvc/logstash-output-elasticsearch/subscribers","subscription_url":"https://api.github.com/repos/andrewvc/logstash-output-elasticsearch/subscription","commits_url":"https://api.github.com/repos/andrewvc/logstash-output-elasticsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/andrewvc/logstash-output-elasticsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/andrewvc/logstash-output-elasticsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/andrewvc/logstash-output-elasticsearch/issues/comments{/number}","contents_url":"https://api.github.com/repos/andrewvc/logstash-output-elasticsearch/contents/{+path}","compare_url":"https://api.github.com/repos/andrewvc/logstash-output-elasticsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andrewvc/logstash-output-elasticsearch/merges","archive_url":"https://api.github.com/repos/andrewvc/logstash-output-elasticsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andrewvc/logstash-output-elasticsearch/downloads","issues_url":"https://api.github.com/repos/andrewvc/logstash-output-elasticsearch/issues{/number}","pulls_url":"https://api.github.com/repos/andrewvc/logstash-output-elasticsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/andrewvc/logstash-output-elasticsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/andrewvc/logstash-output-elasticsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andrewvc/logstash-output-elasticsearch/labels{/name}","releases_url":"https://api.github.com/repos/andrewvc/logstash-output-elasticsearch/releases{/id}","deployments_url":"https://api.github.com/repos/andrewvc/logstash-output-elasticsearch/deployments","created_at":"2015-06-15T21:07:46Z","updated_at":"2015-06-15T21:07:46Z","pushed_at":"2016-12-09T20:07:14Z","git_url":"git://github.com/andrewvc/logstash-output-elasticsearch.git","ssh_url":"git@github.com:andrewvc/logstash-output-elasticsearch.git","clone_url":"https://github.com/andrewvc/logstash-output-elasticsearch.git","svn_url":"https://github.com/andrewvc/logstash-output-elasticsearch","homepage":null,"size":41560,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"logstash-plugins:master","ref":"master","sha":"089bdb99d32b2381de7342c255f5304772b4066d","user":{"login":"logstash-plugins","id":8961934,"avatar_url":"https://avatars.githubusercontent.com/u/8961934?v=3","gravatar_id":"","url":"https://api.github.com/users/logstash-plugins","html_url":"https://github.com/logstash-plugins","followers_url":"https://api.github.com/users/logstash-plugins/followers","following_url":"https://api.github.com/users/logstash-plugins/following{/other_user}","gists_url":"https://api.github.com/users/logstash-plugins/gists{/gist_id}","starred_url":"https://api.github.com/users/logstash-plugins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/logstash-plugins/subscriptions","organizations_url":"https://api.github.com/users/logstash-plugins/orgs","repos_url":"https://api.github.com/users/logstash-plugins/repos","events_url":"https://api.github.com/users/logstash-plugins/events{/privacy}","received_events_url":"https://api.github.com/users/logstash-plugins/received_events","type":"Organization","site_admin":false},"repo":{"id":25476601,"name":"logstash-output-elasticsearch","full_name":"logstash-plugins/logstash-output-elasticsearch","owner":{"login":"logstash-plugins","id":8961934,"avatar_url":"https://avatars.githubusercontent.com/u/8961934?v=3","gravatar_id":"","url":"https://api.github.com/users/logstash-plugins","html_url":"https://github.com/logstash-plugins","followers_url":"https://api.github.com/users/logstash-plugins/followers","following_url":"https://api.github.com/users/logstash-plugins/following{/other_user}","gists_url":"https://api.github.com/users/logstash-plugins/gists{/gist_id}","starred_url":"https://api.github.com/users/logstash-plugins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/logstash-plugins/subscriptions","organizations_url":"https://api.github.com/users/logstash-plugins/orgs","repos_url":"https://api.github.com/users/logstash-plugins/repos","events_url":"https://api.github.com/users/logstash-plugins/events{/privacy}","received_events_url":"https://api.github.com/users/logstash-plugins/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/logstash-plugins/logstash-output-elasticsearch","description":null,"fork":false,"url":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch","forks_url":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/forks","keys_url":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/teams","hooks_url":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/hooks","issue_events_url":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/issues/events{/number}","events_url":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/events","assignees_url":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/assignees{/user}","branches_url":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/branches{/branch}","tags_url":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/tags","blobs_url":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/languages","stargazers_url":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/stargazers","contributors_url":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/contributors","subscribers_url":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/subscribers","subscription_url":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/subscription","commits_url":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/issues/comments{/number}","contents_url":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/contents/{+path}","compare_url":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/merges","archive_url":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/downloads","issues_url":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/issues{/number}","pulls_url":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/labels{/name}","releases_url":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/releases{/id}","deployments_url":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/deployments","created_at":"2014-10-20T16:56:37Z","updated_at":"2016-11-12T02:03:56Z","pushed_at":"2016-12-10T00:08:09Z","git_url":"git://github.com/logstash-plugins/logstash-output-elasticsearch.git","ssh_url":"git@github.com:logstash-plugins/logstash-output-elasticsearch.git","clone_url":"https://github.com/logstash-plugins/logstash-output-elasticsearch.git","svn_url":"https://github.com/logstash-plugins/logstash-output-elasticsearch","homepage":"https://www.elastic.co/guide/en/logstash/current/plugins-outputs-elasticsearch.html","size":69624,"stargazers_count":70,"watchers_count":70,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":134,"mirror_url":null,"open_issues_count":129,"forks":134,"open_issues":129,"watchers":70,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/pulls/523"},"html":{"href":"https://github.com/logstash-plugins/logstash-output-elasticsearch/pull/523"},"issue":{"href":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/issues/523"},"comments":{"href":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/issues/523/comments"},"review_comments":{"href":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/pulls/523/comments"},"review_comment":{"href":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/pulls/523/commits"},"statuses":{"href":"https://api.github.com/repos/logstash-plugins/logstash-output-elasticsearch/statuses/b4341de2b8988c01f785a7b8e0020138481fe1f8"}}}}
{"actor":{"display_login":"jordansissel"}}