{"action":"created","comment":{"url":"https://api.github.com/repos/RPCS3/rpcs3/pulls/comments/69417957","id":69417957,"diff_hunk":"@@ -212,6 +212,169 @@ namespace rsx\n \t};\n \n \ttexture_magnify_filter to_texture_magnify_filter(u8 in);\n+\n+\tenum class stencil_op : u8\n+\t{\n+\t\tkeep,\n+\t\tzero,\n+\t\treplace,\n+\t\tincr,\n+\t\tdecr,\n+\t\tinvert,\n+\t\tincr_wrap,\n+\t\tdecr_wrap,\n+\t};\n+\n+\tstencil_op to_stencil_op(u16 in);\n+\n+\tenum class blend_equation : u8\n+\t{\n+\t\tadd,\n+\t\tmin,\n+\t\tmax,\n+\t\tsubstract,\n+\t\treverse_substract,\n+\t\treverse_substract_signed,\n+\t\tadd_signed,\n+\t\treverse_add_signed,\n+\t};\n+\n+\tblend_equation to_blend_equation(u16 in);\n+\n+\tenum class blend_factor : u8\n+\t{\n+\t\tzero,\n+\t\tone,\n+\t\tsrc_color,\n+\t\tone_minus_src_color,\n+\t\tdst_color,\n+\t\tone_minus_dst_color,\n+\t\tsrc_alpha,\n+\t\tone_minus_src_alpha,\n+\t\tdst_alpha,\n+\t\tone_minus_dst_alpha,\n+\t\tsrc_alpha_saturate,\n+\t\tconstant_color,\n+\t\tone_minus_constant_color,\n+\t\tconstant_alpha,\n+\t\tone_minus_constant_alpha,\n+\t};\n+\n+\tblend_factor to_blend_factor(u16 in);\n+\n+\tenum class logic_op : u8\n+\t{\n+\t\tclear,\n+\t\tand,","path":"rpcs3/Emu/RSX/GCM.h","position":57,"original_position":57,"commit_id":"da68e528b36cbf2dab0be588115034a3231cd815","original_commit_id":"da68e528b36cbf2dab0be588115034a3231cd815","user":{"login":"paulsapps","id":7420121,"avatar_url":"https://avatars.githubusercontent.com/u/7420121?v=3","gravatar_id":"","url":"https://api.github.com/users/paulsapps","html_url":"https://github.com/paulsapps","followers_url":"https://api.github.com/users/paulsapps/followers","following_url":"https://api.github.com/users/paulsapps/following{/other_user}","gists_url":"https://api.github.com/users/paulsapps/gists{/gist_id}","starred_url":"https://api.github.com/users/paulsapps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulsapps/subscriptions","organizations_url":"https://api.github.com/users/paulsapps/orgs","repos_url":"https://api.github.com/users/paulsapps/repos","events_url":"https://api.github.com/users/paulsapps/events{/privacy}","received_events_url":"https://api.github.com/users/paulsapps/received_events","type":"User","site_admin":false},"body":"they don't work in msvc","created_at":"2016-07-04T07:32:18Z","updated_at":"2016-07-04T07:32:18Z","html_url":"https://github.com/RPCS3/rpcs3/pull/1865#discussion_r69417957","pull_request_url":"https://api.github.com/repos/RPCS3/rpcs3/pulls/1865","_links":{"self":{"href":"https://api.github.com/repos/RPCS3/rpcs3/pulls/comments/69417957"},"html":{"href":"https://github.com/RPCS3/rpcs3/pull/1865#discussion_r69417957"},"pull_request":{"href":"https://api.github.com/repos/RPCS3/rpcs3/pulls/1865"}}},"pull_request":{"url":"https://api.github.com/repos/RPCS3/rpcs3/pulls/1865","id":76100967,"html_url":"https://github.com/RPCS3/rpcs3/pull/1865","diff_url":"https://github.com/RPCS3/rpcs3/pull/1865.diff","patch_url":"https://github.com/RPCS3/rpcs3/pull/1865.patch","issue_url":"https://api.github.com/repos/RPCS3/rpcs3/issues/1865","number":1865,"state":"open","locked":false,"title":"Factorize rsx state","user":{"login":"vlj","id":6413475,"avatar_url":"https://avatars.githubusercontent.com/u/6413475?v=3","gravatar_id":"","url":"https://api.github.com/users/vlj","html_url":"https://github.com/vlj","followers_url":"https://api.github.com/users/vlj/followers","following_url":"https://api.github.com/users/vlj/following{/other_user}","gists_url":"https://api.github.com/users/vlj/gists{/gist_id}","starred_url":"https://api.github.com/users/vlj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vlj/subscriptions","organizations_url":"https://api.github.com/users/vlj/orgs","repos_url":"https://api.github.com/users/vlj/repos","events_url":"https://api.github.com/users/vlj/events{/privacy}","received_events_url":"https://api.github.com/users/vlj/received_events","type":"User","site_admin":false},"body":"This PR factorises hides rsx::method_registers array inside a new rsx_state struct that exposes state through function member in a higher level way and more strongly typed. It basically removes all the bit shift, bit mask, reinterpret cast that were spread throughout backends.\r\n\r\nWhile it improves code maintainability the longterm goal is to have a proper complete rsx state structure that can be copied and serialised for debug purpose. Having a single structure were every piece of rendering code interacts is a first step in this direction.\r\n The next one is to replace the array inside rsx_state with discrete data member to directly store the decoded data instead of storing the register value and then decode it when retrieving the data. This should translate to a more compact structure.","created_at":"2016-07-03T23:08:17Z","updated_at":"2016-07-04T07:32:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7c76cdcb8c5bbfca0b61488f8c0310aac6ea6f6b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/RPCS3/rpcs3/pulls/1865/commits","review_comments_url":"https://api.github.com/repos/RPCS3/rpcs3/pulls/1865/comments","review_comment_url":"https://api.github.com/repos/RPCS3/rpcs3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RPCS3/rpcs3/issues/1865/comments","statuses_url":"https://api.github.com/repos/RPCS3/rpcs3/statuses/da68e528b36cbf2dab0be588115034a3231cd815","head":{"label":"vlj:rsx-refactor","ref":"rsx-refactor","sha":"da68e528b36cbf2dab0be588115034a3231cd815","user":{"login":"vlj","id":6413475,"avatar_url":"https://avatars.githubusercontent.com/u/6413475?v=3","gravatar_id":"","url":"https://api.github.com/users/vlj","html_url":"https://github.com/vlj","followers_url":"https://api.github.com/users/vlj/followers","following_url":"https://api.github.com/users/vlj/following{/other_user}","gists_url":"https://api.github.com/users/vlj/gists{/gist_id}","starred_url":"https://api.github.com/users/vlj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vlj/subscriptions","organizations_url":"https://api.github.com/users/vlj/orgs","repos_url":"https://api.github.com/users/vlj/repos","events_url":"https://api.github.com/users/vlj/events{/privacy}","received_events_url":"https://api.github.com/users/vlj/received_events","type":"User","site_admin":false},"repo":{"id":35342587,"name":"rpcs3","full_name":"vlj/rpcs3","owner":{"login":"vlj","id":6413475,"avatar_url":"https://avatars.githubusercontent.com/u/6413475?v=3","gravatar_id":"","url":"https://api.github.com/users/vlj","html_url":"https://github.com/vlj","followers_url":"https://api.github.com/users/vlj/followers","following_url":"https://api.github.com/users/vlj/following{/other_user}","gists_url":"https://api.github.com/users/vlj/gists{/gist_id}","starred_url":"https://api.github.com/users/vlj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vlj/subscriptions","organizations_url":"https://api.github.com/users/vlj/orgs","repos_url":"https://api.github.com/users/vlj/repos","events_url":"https://api.github.com/users/vlj/events{/privacy}","received_events_url":"https://api.github.com/users/vlj/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vlj/rpcs3","description":"PS3 emulator/debugger","fork":true,"url":"https://api.github.com/repos/vlj/rpcs3","forks_url":"https://api.github.com/repos/vlj/rpcs3/forks","keys_url":"https://api.github.com/repos/vlj/rpcs3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vlj/rpcs3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vlj/rpcs3/teams","hooks_url":"https://api.github.com/repos/vlj/rpcs3/hooks","issue_events_url":"https://api.github.com/repos/vlj/rpcs3/issues/events{/number}","events_url":"https://api.github.com/repos/vlj/rpcs3/events","assignees_url":"https://api.github.com/repos/vlj/rpcs3/assignees{/user}","branches_url":"https://api.github.com/repos/vlj/rpcs3/branches{/branch}","tags_url":"https://api.github.com/repos/vlj/rpcs3/tags","blobs_url":"https://api.github.com/repos/vlj/rpcs3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vlj/rpcs3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vlj/rpcs3/git/refs{/sha}","trees_url":"https://api.github.com/repos/vlj/rpcs3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vlj/rpcs3/statuses/{sha}","languages_url":"https://api.github.com/repos/vlj/rpcs3/languages","stargazers_url":"https://api.github.com/repos/vlj/rpcs3/stargazers","contributors_url":"https://api.github.com/repos/vlj/rpcs3/contributors","subscribers_url":"https://api.github.com/repos/vlj/rpcs3/subscribers","subscription_url":"https://api.github.com/repos/vlj/rpcs3/subscription","commits_url":"https://api.github.com/repos/vlj/rpcs3/commits{/sha}","git_commits_url":"https://api.github.com/repos/vlj/rpcs3/git/commits{/sha}","comments_url":"https://api.github.com/repos/vlj/rpcs3/comments{/number}","issue_comment_url":"https://api.github.com/repos/vlj/rpcs3/issues/comments{/number}","contents_url":"https://api.github.com/repos/vlj/rpcs3/contents/{+path}","compare_url":"https://api.github.com/repos/vlj/rpcs3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vlj/rpcs3/merges","archive_url":"https://api.github.com/repos/vlj/rpcs3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vlj/rpcs3/downloads","issues_url":"https://api.github.com/repos/vlj/rpcs3/issues{/number}","pulls_url":"https://api.github.com/repos/vlj/rpcs3/pulls{/number}","milestones_url":"https://api.github.com/repos/vlj/rpcs3/milestones{/number}","notifications_url":"https://api.github.com/repos/vlj/rpcs3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vlj/rpcs3/labels{/name}","releases_url":"https://api.github.com/repos/vlj/rpcs3/releases{/id}","deployments_url":"https://api.github.com/repos/vlj/rpcs3/deployments","created_at":"2015-05-09T19:43:56Z","updated_at":"2016-04-13T04:15:34Z","pushed_at":"2016-07-03T22:49:12Z","git_url":"git://github.com/vlj/rpcs3.git","ssh_url":"git@github.com:vlj/rpcs3.git","clone_url":"https://github.com/vlj/rpcs3.git","svn_url":"https://github.com/vlj/rpcs3","homepage":null,"size":35601,"stargazers_count":8,"watchers_count":8,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":8,"default_branch":"master"}},"base":{"label":"RPCS3:master","ref":"master","sha":"effd379c2556285221752695a655c59c019a1324","user":{"login":"RPCS3","id":8070735,"avatar_url":"https://avatars.githubusercontent.com/u/8070735?v=3","gravatar_id":"","url":"https://api.github.com/users/RPCS3","html_url":"https://github.com/RPCS3","followers_url":"https://api.github.com/users/RPCS3/followers","following_url":"https://api.github.com/users/RPCS3/following{/other_user}","gists_url":"https://api.github.com/users/RPCS3/gists{/gist_id}","starred_url":"https://api.github.com/users/RPCS3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RPCS3/subscriptions","organizations_url":"https://api.github.com/users/RPCS3/orgs","repos_url":"https://api.github.com/users/RPCS3/repos","events_url":"https://api.github.com/users/RPCS3/events{/privacy}","received_events_url":"https://api.github.com/users/RPCS3/received_events","type":"Organization","site_admin":false},"repo":{"id":6520784,"name":"rpcs3","full_name":"RPCS3/rpcs3","owner":{"login":"RPCS3","id":8070735,"avatar_url":"https://avatars.githubusercontent.com/u/8070735?v=3","gravatar_id":"","url":"https://api.github.com/users/RPCS3","html_url":"https://github.com/RPCS3","followers_url":"https://api.github.com/users/RPCS3/followers","following_url":"https://api.github.com/users/RPCS3/following{/other_user}","gists_url":"https://api.github.com/users/RPCS3/gists{/gist_id}","starred_url":"https://api.github.com/users/RPCS3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RPCS3/subscriptions","organizations_url":"https://api.github.com/users/RPCS3/orgs","repos_url":"https://api.github.com/users/RPCS3/repos","events_url":"https://api.github.com/users/RPCS3/events{/privacy}","received_events_url":"https://api.github.com/users/RPCS3/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RPCS3/rpcs3","description":"PS3 emulator/debugger","fork":false,"url":"https://api.github.com/repos/RPCS3/rpcs3","forks_url":"https://api.github.com/repos/RPCS3/rpcs3/forks","keys_url":"https://api.github.com/repos/RPCS3/rpcs3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RPCS3/rpcs3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RPCS3/rpcs3/teams","hooks_url":"https://api.github.com/repos/RPCS3/rpcs3/hooks","issue_events_url":"https://api.github.com/repos/RPCS3/rpcs3/issues/events{/number}","events_url":"https://api.github.com/repos/RPCS3/rpcs3/events","assignees_url":"https://api.github.com/repos/RPCS3/rpcs3/assignees{/user}","branches_url":"https://api.github.com/repos/RPCS3/rpcs3/branches{/branch}","tags_url":"https://api.github.com/repos/RPCS3/rpcs3/tags","blobs_url":"https://api.github.com/repos/RPCS3/rpcs3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RPCS3/rpcs3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RPCS3/rpcs3/git/refs{/sha}","trees_url":"https://api.github.com/repos/RPCS3/rpcs3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RPCS3/rpcs3/statuses/{sha}","languages_url":"https://api.github.com/repos/RPCS3/rpcs3/languages","stargazers_url":"https://api.github.com/repos/RPCS3/rpcs3/stargazers","contributors_url":"https://api.github.com/repos/RPCS3/rpcs3/contributors","subscribers_url":"https://api.github.com/repos/RPCS3/rpcs3/subscribers","subscription_url":"https://api.github.com/repos/RPCS3/rpcs3/subscription","commits_url":"https://api.github.com/repos/RPCS3/rpcs3/commits{/sha}","git_commits_url":"https://api.github.com/repos/RPCS3/rpcs3/git/commits{/sha}","comments_url":"https://api.github.com/repos/RPCS3/rpcs3/comments{/number}","issue_comment_url":"https://api.github.com/repos/RPCS3/rpcs3/issues/comments{/number}","contents_url":"https://api.github.com/repos/RPCS3/rpcs3/contents/{+path}","compare_url":"https://api.github.com/repos/RPCS3/rpcs3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RPCS3/rpcs3/merges","archive_url":"https://api.github.com/repos/RPCS3/rpcs3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RPCS3/rpcs3/downloads","issues_url":"https://api.github.com/repos/RPCS3/rpcs3/issues{/number}","pulls_url":"https://api.github.com/repos/RPCS3/rpcs3/pulls{/number}","milestones_url":"https://api.github.com/repos/RPCS3/rpcs3/milestones{/number}","notifications_url":"https://api.github.com/repos/RPCS3/rpcs3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RPCS3/rpcs3/labels{/name}","releases_url":"https://api.github.com/repos/RPCS3/rpcs3/releases{/id}","deployments_url":"https://api.github.com/repos/RPCS3/rpcs3/deployments","created_at":"2012-11-03T15:16:18Z","updated_at":"2016-07-03T23:41:14Z","pushed_at":"2016-07-03T23:08:17Z","git_url":"git://github.com/RPCS3/rpcs3.git","ssh_url":"git@github.com:RPCS3/rpcs3.git","clone_url":"https://github.com/RPCS3/rpcs3.git","svn_url":"https://github.com/RPCS3/rpcs3","homepage":null,"size":74467,"stargazers_count":2146,"watchers_count":2146,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":437,"mirror_url":null,"open_issues_count":112,"forks":437,"open_issues":112,"watchers":2146,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RPCS3/rpcs3/pulls/1865"},"html":{"href":"https://github.com/RPCS3/rpcs3/pull/1865"},"issue":{"href":"https://api.github.com/repos/RPCS3/rpcs3/issues/1865"},"comments":{"href":"https://api.github.com/repos/RPCS3/rpcs3/issues/1865/comments"},"review_comments":{"href":"https://api.github.com/repos/RPCS3/rpcs3/pulls/1865/comments"},"review_comment":{"href":"https://api.github.com/repos/RPCS3/rpcs3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RPCS3/rpcs3/pulls/1865/commits"},"statuses":{"href":"https://api.github.com/repos/RPCS3/rpcs3/statuses/da68e528b36cbf2dab0be588115034a3231cd815"}}}}
{"actor":{"display_login":"paulsapps"}}