{"action":"created","issue":{"url":"https://api.github.com/repos/uclibs/scholar_uc/issues/1043","repository_url":"https://api.github.com/repos/uclibs/scholar_uc","labels_url":"https://api.github.com/repos/uclibs/scholar_uc/issues/1043/labels{/name}","comments_url":"https://api.github.com/repos/uclibs/scholar_uc/issues/1043/comments","events_url":"https://api.github.com/repos/uclibs/scholar_uc/issues/1043/events","html_url":"https://github.com/uclibs/scholar_uc/pull/1043","id":196712665,"number":1043,"title":"Monkey patch handle control chars in form input","user":{"login":"crowesn","id":1069588,"avatar_url":"https://avatars.githubusercontent.com/u/1069588?v=3","gravatar_id":"","url":"https://api.github.com/users/crowesn","html_url":"https://github.com/crowesn","followers_url":"https://api.github.com/users/crowesn/followers","following_url":"https://api.github.com/users/crowesn/following{/other_user}","gists_url":"https://api.github.com/users/crowesn/gists{/gist_id}","starred_url":"https://api.github.com/users/crowesn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowesn/subscriptions","organizations_url":"https://api.github.com/users/crowesn/orgs","repos_url":"https://api.github.com/users/crowesn/repos","events_url":"https://api.github.com/users/crowesn/events{/privacy}","received_events_url":"https://api.github.com/users/crowesn/received_events","type":"User","site_admin":false},"labels":[{"id":193855159,"url":"https://api.github.com/repos/uclibs/scholar_uc/labels/in%20progress","name":"in progress","color":"ededed","default":false},{"id":480242856,"url":"https://api.github.com/repos/uclibs/scholar_uc/labels/Needs%20review","name":"Needs review","color":"1d76db","default":false},{"id":365186777,"url":"https://api.github.com/repos/uclibs/scholar_uc/labels/Scholar%203.0","name":"Scholar 3.0","color":"bfd4f2","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-12-20T16:11:14Z","updated_at":"2016-12-20T16:52:39Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/uclibs/scholar_uc/pulls/1043","html_url":"https://github.com/uclibs/scholar_uc/pull/1043","diff_url":"https://github.com/uclibs/scholar_uc/pull/1043.diff","patch_url":"https://github.com/uclibs/scholar_uc/pull/1043.patch"},"body":"Fixes #1022 \r\n\r\nRsolr version in Sufia defaults to xml serialization, making control chars illegal and crashing the app when they are included in form input. A patch has been added to Rsolr upstream (defaulting to json serialization). In the meantime, we can monkey patch rsolr to filter out control chars before indexing in solr.\r\n\r\nThis code borrowed from @jeremyf (thanks!).\r\n\r\nChanges proposed in this pull request:\r\n* Add Rsolr monkey patch with method to sanitize input before solr index.\r\n* Add specs to test the sanitize methods.\r\n"},"comment":{"url":"https://api.github.com/repos/uclibs/scholar_uc/issues/comments/268295434","html_url":"https://github.com/uclibs/scholar_uc/pull/1043#issuecomment-268295434","issue_url":"https://api.github.com/repos/uclibs/scholar_uc/issues/1043","id":268295434,"user":{"login":"coveralls","id":2354108,"avatar_url":"https://avatars.githubusercontent.com/u/2354108?v=3","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2016-12-20T16:52:39Z","updated_at":"2016-12-20T16:52:39Z","body":"\n[![Coverage Status](https://coveralls.io/builds/9363005/badge)](https://coveralls.io/builds/9363005)\n\nCoverage remained the same at 96.405% when pulling **64e8d7df71c54180692cd65f5f3aa834d92522a2 on bug/#1022-illegal-characters** into **00a93d1f2dfa6cd2da6db96e656bbac6f7b1fdd0 on develop**.\n"}}
{"actor":{"display_login":"coveralls"}}