{"action":"closed","issue":{"url":"https://api.github.com/repos/vmware/vic/issues/1128","repository_url":"https://api.github.com/repos/vmware/vic","labels_url":"https://api.github.com/repos/vmware/vic/issues/1128/labels{/name}","comments_url":"https://api.github.com/repos/vmware/vic/issues/1128/comments","events_url":"https://api.github.com/repos/vmware/vic/issues/1128/events","html_url":"https://github.com/vmware/vic/issues/1128","id":160830397,"number":1128,"title":"Attach should time out if connection cannot be established","user":{"login":"hickeng","id":3923729,"avatar_url":"https://avatars.githubusercontent.com/u/3923729?v=3","gravatar_id":"","url":"https://api.github.com/users/hickeng","html_url":"https://github.com/hickeng","followers_url":"https://api.github.com/users/hickeng/followers","following_url":"https://api.github.com/users/hickeng/following{/other_user}","gists_url":"https://api.github.com/users/hickeng/gists{/gist_id}","starred_url":"https://api.github.com/users/hickeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hickeng/subscriptions","organizations_url":"https://api.github.com/users/hickeng/orgs","repos_url":"https://api.github.com/users/hickeng/repos","events_url":"https://api.github.com/users/hickeng/events{/privacy}","received_events_url":"https://api.github.com/users/hickeng/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/vmware/vic/labels/component/portlayer/interaction","name":"component/portlayer/interaction","color":"d4c5f9"},{"url":"https://api.github.com/repos/vmware/vic/labels/kind/bug","name":"kind/bug","color":"f7c6c7"},{"url":"https://api.github.com/repos/vmware/vic/labels/kind/user-doc","name":"kind/user-doc","color":"c5def5"}],"state":"closed","locked":false,"assignee":{"login":"sflxn","id":1330508,"avatar_url":"https://avatars.githubusercontent.com/u/1330508?v=3","gravatar_id":"","url":"https://api.github.com/users/sflxn","html_url":"https://github.com/sflxn","followers_url":"https://api.github.com/users/sflxn/followers","following_url":"https://api.github.com/users/sflxn/following{/other_user}","gists_url":"https://api.github.com/users/sflxn/gists{/gist_id}","starred_url":"https://api.github.com/users/sflxn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sflxn/subscriptions","organizations_url":"https://api.github.com/users/sflxn/orgs","repos_url":"https://api.github.com/users/sflxn/repos","events_url":"https://api.github.com/users/sflxn/events{/privacy}","received_events_url":"https://api.github.com/users/sflxn/received_events","type":"User","site_admin":false},"assignees":[{"login":"sflxn","id":1330508,"avatar_url":"https://avatars.githubusercontent.com/u/1330508?v=3","gravatar_id":"","url":"https://api.github.com/users/sflxn","html_url":"https://github.com/sflxn","followers_url":"https://api.github.com/users/sflxn/followers","following_url":"https://api.github.com/users/sflxn/following{/other_user}","gists_url":"https://api.github.com/users/sflxn/gists{/gist_id}","starred_url":"https://api.github.com/users/sflxn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sflxn/subscriptions","organizations_url":"https://api.github.com/users/sflxn/orgs","repos_url":"https://api.github.com/users/sflxn/repos","events_url":"https://api.github.com/users/sflxn/events{/privacy}","received_events_url":"https://api.github.com/users/sflxn/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/vmware/vic/milestones/37","html_url":"https://github.com/vmware/vic/milestones/VIC%20GA%20Release","labels_url":"https://api.github.com/repos/vmware/vic/milestones/37/labels","id":1799354,"number":37,"title":"VIC GA Release","description":"*Please keep this limited to items in the GA Plan sheet* \r\n\r\nThis milestone is for release tracking only. It is tracking all of the customer facing issues identified in the VIC GA Plan spreadsheet. The Due date is set to 1 week before the start of VMworld","creator":{"login":"mdubya66","id":15821624,"avatar_url":"https://avatars.githubusercontent.com/u/15821624?v=3","gravatar_id":"","url":"https://api.github.com/users/mdubya66","html_url":"https://github.com/mdubya66","followers_url":"https://api.github.com/users/mdubya66/followers","following_url":"https://api.github.com/users/mdubya66/following{/other_user}","gists_url":"https://api.github.com/users/mdubya66/gists{/gist_id}","starred_url":"https://api.github.com/users/mdubya66/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdubya66/subscriptions","organizations_url":"https://api.github.com/users/mdubya66/orgs","repos_url":"https://api.github.com/users/mdubya66/repos","events_url":"https://api.github.com/users/mdubya66/events{/privacy}","received_events_url":"https://api.github.com/users/mdubya66/received_events","type":"User","site_admin":false},"open_issues":141,"closed_issues":6,"state":"open","created_at":"2016-05-31T17:50:00Z","updated_at":"2016-07-08T22:57:45Z","due_on":"2016-08-20T05:00:00Z","closed_at":null},"comments":7,"created_at":"2016-06-17T07:45:25Z","updated_at":"2016-07-08T22:57:45Z","closed_at":"2016-07-08T22:57:45Z","body":"Just tried attaching to a container without having appropriate firewall config (2377 was not open on ESX for outbound). The attach hung - as can been seen from the timestamps for the port-layer there was a significant period of time between the attempt and the success (after I corrected the firewall config).\r\n\r\nWe see context deadlines expiring for resize, but not for the initial attach. I know that the attach deadline is set high on the port layer (and that we need to figure out with @casualjim how to make it infinite), but we need to look at having separate timeouts for the HTTP 200 response to the attach (call it 15sec) vs the consumption of the body (until closed).\r\n\r\nFrom port-layer.log:\r\n```\r\ntime=\"2016-06-17T07:32:17Z\" level=info msg=\"Attempting to get ssh session for container f8db066558f2f1220fc1f01c74a1742f0b85dd7c893b56455d271e4fdbb56d55 stdin\" \r\ntime=\"2016-06-17T07:35:09Z\" level=info msg=\"Received incoming connection\" \r\n```\r\n\r\nFrom personality:\r\n```\r\ntime=\"2016-06-17T07:31:41Z\" level=info msg=\"[BEGIN] [github.com/vmware/vic/lib/apiservers/engine/backends.(*Container).ContainerCreate] ContainerCreate\" \r\ntime=\"2016-06-17T07:31:41Z\" level=info msg=\"config.Config = &{Hostname: Domainname: User: AttachStdin:true AttachStdout:true AttachStderr:true ExposedPorts:map[] PublishService: Tty:true OpenStdin:true StdinOnce:true Env:[] Cmd:[/bin/ash] ArgsEscaped:false Image:busybox Volumes:map[] WorkingDir: Entrypoint:[] NetworkDisabled:false MacAddress: OnBuild:[] Labels:map[] StopSignal:}\" \r\ntime=\"2016-06-17T07:31:44Z\" level=info msg=\"v1 = {ID:437595becdebaaaf3a4fc3db02c59a980f955dee825c153308c670610bb694e1 Config:{Hostname:156e10b83429 Domainname: User: AttachStdin:false AttachStdout:false AttachStderr:false ExposedPorts:map[] PublishService: Tty:false OpenStdin:false StdinOnce:false Env:[] Cmd:[sh] ArgsEscaped:false Image:56ed16bd6310cca65920c653a9bb22de6b235990dcaa1742ff839867aed730e5 Volumes:map[] WorkingDir: Entrypoint:[] NetworkDisabled:false MacAddress: OnBuild:[] Labels:map[] StopSignal:}}\" \r\ntime=\"2016-06-17T07:31:44Z\" level=info msg=\"ContainerCreate config' = {Name:condescending_boyd Config:0xc820144c60 HostConfig:0xc820336a80 NetworkingConfig:0xc82001c668 AdjustCPUShares:false}\" \r\ntime=\"2016-06-17T07:31:44Z\" level=info msg=\"dockerContainerCreateParamsToPortlayer = &{Args:[] Env:[TERM=xterm] Image:0xc8204acca0 ImageStore:0xc8204acce0 Name:0xc8204accb0 NetworkDisabled:0xc8204acbf8 Path:0xc8204accc0 Tty:0xc8204acbf9 WorkingDir:0xc8204accf0}\" \r\ntime=\"2016-06-17T07:31:44Z\" level=info msg=\"container.ContainerCreate succeeded.  Returning container handle {ec8d26bb3f3dd7bc4866f9dbc5e265e7 f8db066558f2f1220fc1f01c74a1742f0b85dd7c893b56455d271e4fdbb56d55}\" \r\ntime=\"2016-06-17T07:31:44Z\" level=info msg=\"[ END ] [github.com/vmware/vic/lib/apiservers/engine/backends.(*Container).ContainerCreate] [2.834317626s] ContainerCreate\" \r\ntime=\"2016-06-17T07:31:44Z\" level=info msg=\"[BEGIN] [github.com/vmware/vic/lib/apiservers/engine/backends.(*Container).ContainerAttach] ContainerAttach\" \r\ntime=\"2016-06-17T07:31:44Z\" level=info msg=\"[BEGIN] [github.com/vmware/vic/lib/apiservers/engine/backends.(*Container).ContainerStart] ContainerStart\" \r\ntime=\"2016-06-17T07:31:56Z\" level=info msg=\"[ END ] [github.com/vmware/vic/lib/apiservers/engine/backends.(*Container).ContainerStart] [11.869013407s] ContainerStart\" \r\ntime=\"2016-06-17T07:31:56Z\" level=info msg=\"[BEGIN] [github.com/vmware/vic/lib/apiservers/engine/backends.(*Container).ContainerResize] ContainerResize\" \r\ntime=\"2016-06-17T07:32:26Z\" level=info msg=\"[ END ] [github.com/vmware/vic/lib/apiservers/engine/backends.(*Container).ContainerResize] [30.000596954s] ContainerResize\" \r\ntime=\"2016-06-17T07:32:26Z\" level=error msg=\"Handler for POST /v1.23/containers/f8db066558f2f1220fc1f01c74a1742f0b85dd7c893b56455d271e4fdbb56d55/resize returned error: Unknown error from the interaction port layer: context deadline exceeded\" \r\n```\r\n\r\n@sflxn for comments"}}
{"actor":{"display_login":"sflxn"}}