{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/heapster/issues/1380","repository_url":"https://api.github.com/repos/kubernetes/heapster","labels_url":"https://api.github.com/repos/kubernetes/heapster/issues/1380/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/heapster/issues/1380/comments","events_url":"https://api.github.com/repos/kubernetes/heapster/issues/1380/events","html_url":"https://github.com/kubernetes/heapster/pull/1380","id":189316126,"number":1380,"title":"Add cluster tag for es event","user":{"login":"andyxning","id":2404712,"avatar_url":"https://avatars.githubusercontent.com/u/2404712?v=3","gravatar_id":"","url":"https://api.github.com/users/andyxning","html_url":"https://github.com/andyxning","followers_url":"https://api.github.com/users/andyxning/followers","following_url":"https://api.github.com/users/andyxning/following{/other_user}","gists_url":"https://api.github.com/users/andyxning/gists{/gist_id}","starred_url":"https://api.github.com/users/andyxning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andyxning/subscriptions","organizations_url":"https://api.github.com/users/andyxning/orgs","repos_url":"https://api.github.com/users/andyxning/repos","events_url":"https://api.github.com/users/andyxning/events{/privacy}","received_events_url":"https://api.github.com/users/andyxning/received_events","type":"User","site_admin":false},"labels":[{"id":246779186,"url":"https://api.github.com/repos/kubernetes/heapster/labels/cla:%20yes","name":"cla: yes","color":"bfe5bf","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-11-15T07:10:09Z","updated_at":"2016-11-21T02:16:09Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kubernetes/heapster/pulls/1380","html_url":"https://github.com/kubernetes/heapster/pull/1380","diff_url":"https://github.com/kubernetes/heapster/pull/1380.diff","patch_url":"https://github.com/kubernetes/heapster/pull/1380.patch"},"body":"This PR will add a new elasticsearch field `eventCluster`. A new eventer command line argument `cluster` is added to config the value for `eventCluster`.\r\n\r\nLet me explain why we should add this option. Image that, we have one Kubernetes `A` cluster in one datacenter, i have set up one ES to collect the events from A Kubernetes cluster. Everything is OK. After some time we added the second Kubernetes cluster `B` in the same datacenter as Kubernetes `A`. We want also want to collect the events of cluster `B` using the same one ES as cluster `A`. This will make our ES operation more easy and stability with maintaining small ES clusters.  However, currently, we can not make a difference between events for cluster `A` and `B`. \r\n\r\nWe can accomplish this by setting a `eventCluster` field in the ES mapping to distinct this. This is just like what [syslog does to with facility to distinct log sources by adding facility in the emitted log]() and what [fluentd log plugin does when emitting log info by adding `container_id` and `container_name` meta info](https://docs.docker.com/engine/admin/logging/fluentd/).\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.kubernetes.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.kubernetes.io/reviews/kubernetes/heapster/1380)\r\n<!-- Reviewable:end -->\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/heapster/issues/comments/261826740","html_url":"https://github.com/kubernetes/heapster/pull/1380#issuecomment-261826740","issue_url":"https://api.github.com/repos/kubernetes/heapster/issues/1380","id":261826740,"user":{"login":"andyxning","id":2404712,"avatar_url":"https://avatars.githubusercontent.com/u/2404712?v=3","gravatar_id":"","url":"https://api.github.com/users/andyxning","html_url":"https://github.com/andyxning","followers_url":"https://api.github.com/users/andyxning/followers","following_url":"https://api.github.com/users/andyxning/following{/other_user}","gists_url":"https://api.github.com/users/andyxning/gists{/gist_id}","starred_url":"https://api.github.com/users/andyxning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andyxning/subscriptions","organizations_url":"https://api.github.com/users/andyxning/orgs","repos_url":"https://api.github.com/users/andyxning/repos","events_url":"https://api.github.com/users/andyxning/events{/privacy}","received_events_url":"https://api.github.com/users/andyxning/received_events","type":"User","site_admin":false},"created_at":"2016-11-21T02:16:09Z","updated_at":"2016-11-21T02:16:09Z","body":"@AlmogBaku Another Index other than the default Heapster? I am not quite familiar with ES, can you please explain this?  "}}
{"actor":{"display_login":"andyxning"}}