{"action":"created","comment":{"url":"https://api.github.com/repos/KeepSafe/aiohttp/pulls/comments/74738408","id":74738408,"diff_hunk":"@@ -55,7 +56,10 @@ def test_client(loop):\n \n     @asyncio.coroutine\n     def _create_from_app_factory(app_factory, *args, **kwargs):\n-        app = app_factory(loop, *args, **kwargs)\n+        if not isinstance(app_factory, Application):\n+            app = app_factory(loop, *args, **kwargs)\n+        else:\n+            app = app_factory","path":"aiohttp/pytest_plugin.py","position":16,"original_position":16,"commit_id":"bc03bee41c1f5a116a40877711274b9f959f972d","original_commit_id":"317d78c63b857a887498424fb617e8c58a203bbb","user":{"login":"asvetlov","id":356399,"avatar_url":"https://avatars.githubusercontent.com/u/356399?v=3","gravatar_id":"","url":"https://api.github.com/users/asvetlov","html_url":"https://github.com/asvetlov","followers_url":"https://api.github.com/users/asvetlov/followers","following_url":"https://api.github.com/users/asvetlov/following{/other_user}","gists_url":"https://api.github.com/users/asvetlov/gists{/gist_id}","starred_url":"https://api.github.com/users/asvetlov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asvetlov/subscriptions","organizations_url":"https://api.github.com/users/asvetlov/orgs","repos_url":"https://api.github.com/users/asvetlov/repos","events_url":"https://api.github.com/users/asvetlov/events{/privacy}","received_events_url":"https://api.github.com/users/asvetlov/received_events","type":"User","site_admin":false},"body":"Also please make sure that `args` and `kwargs` are both empty.","created_at":"2016-08-15T09:27:36Z","updated_at":"2016-08-15T09:27:36Z","html_url":"https://github.com/KeepSafe/aiohttp/pull/1083#discussion_r74738408","pull_request_url":"https://api.github.com/repos/KeepSafe/aiohttp/pulls/1083","_links":{"self":{"href":"https://api.github.com/repos/KeepSafe/aiohttp/pulls/comments/74738408"},"html":{"href":"https://github.com/KeepSafe/aiohttp/pull/1083#discussion_r74738408"},"pull_request":{"href":"https://api.github.com/repos/KeepSafe/aiohttp/pulls/1083"}}},"pull_request":{"url":"https://api.github.com/repos/KeepSafe/aiohttp/pulls/1083","id":81273997,"html_url":"https://github.com/KeepSafe/aiohttp/pull/1083","diff_url":"https://github.com/KeepSafe/aiohttp/pull/1083.diff","patch_url":"https://github.com/KeepSafe/aiohttp/pull/1083.patch","issue_url":"https://api.github.com/repos/KeepSafe/aiohttp/issues/1083","number":1083,"state":"open","locked":false,"title":"Improvement test_client can accept instance object.","user":{"login":"nexusz99","id":330233,"avatar_url":"https://avatars.githubusercontent.com/u/330233?v=3","gravatar_id":"","url":"https://api.github.com/users/nexusz99","html_url":"https://github.com/nexusz99","followers_url":"https://api.github.com/users/nexusz99/followers","following_url":"https://api.github.com/users/nexusz99/following{/other_user}","gists_url":"https://api.github.com/users/nexusz99/gists{/gist_id}","starred_url":"https://api.github.com/users/nexusz99/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nexusz99/subscriptions","organizations_url":"https://api.github.com/users/nexusz99/orgs","repos_url":"https://api.github.com/users/nexusz99/repos","events_url":"https://api.github.com/users/nexusz99/events{/privacy}","received_events_url":"https://api.github.com/users/nexusz99/received_events","type":"User","site_admin":false},"body":"## What do these changes do?\r\n\r\nImprovement test_client can accept instance object as parameter.\r\n\r\n## Are there changes in behavior for the user?\r\n\r\nNo\r\n\r\n## Related issue number\r\n\r\n#1066 \r\n\r\n## Checklist\r\n\r\n- [O] I think the code is well written\r\n- [O] Unit tests for the changes exist\r\n- [O] Documentation reflects the changes\r\n","created_at":"2016-08-15T06:14:59Z","updated_at":"2016-08-15T09:27:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bb43bc8be373a7448b4851ecbb71986ea55d4969","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/KeepSafe/aiohttp/pulls/1083/commits","review_comments_url":"https://api.github.com/repos/KeepSafe/aiohttp/pulls/1083/comments","review_comment_url":"https://api.github.com/repos/KeepSafe/aiohttp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/KeepSafe/aiohttp/issues/1083/comments","statuses_url":"https://api.github.com/repos/KeepSafe/aiohttp/statuses/bc03bee41c1f5a116a40877711274b9f959f972d","head":{"label":"nexusz99:master","ref":"master","sha":"bc03bee41c1f5a116a40877711274b9f959f972d","user":{"login":"nexusz99","id":330233,"avatar_url":"https://avatars.githubusercontent.com/u/330233?v=3","gravatar_id":"","url":"https://api.github.com/users/nexusz99","html_url":"https://github.com/nexusz99","followers_url":"https://api.github.com/users/nexusz99/followers","following_url":"https://api.github.com/users/nexusz99/following{/other_user}","gists_url":"https://api.github.com/users/nexusz99/gists{/gist_id}","starred_url":"https://api.github.com/users/nexusz99/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nexusz99/subscriptions","organizations_url":"https://api.github.com/users/nexusz99/orgs","repos_url":"https://api.github.com/users/nexusz99/repos","events_url":"https://api.github.com/users/nexusz99/events{/privacy}","received_events_url":"https://api.github.com/users/nexusz99/received_events","type":"User","site_admin":false},"repo":{"id":65694298,"name":"aiohttp","full_name":"nexusz99/aiohttp","owner":{"login":"nexusz99","id":330233,"avatar_url":"https://avatars.githubusercontent.com/u/330233?v=3","gravatar_id":"","url":"https://api.github.com/users/nexusz99","html_url":"https://github.com/nexusz99","followers_url":"https://api.github.com/users/nexusz99/followers","following_url":"https://api.github.com/users/nexusz99/following{/other_user}","gists_url":"https://api.github.com/users/nexusz99/gists{/gist_id}","starred_url":"https://api.github.com/users/nexusz99/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nexusz99/subscriptions","organizations_url":"https://api.github.com/users/nexusz99/orgs","repos_url":"https://api.github.com/users/nexusz99/repos","events_url":"https://api.github.com/users/nexusz99/events{/privacy}","received_events_url":"https://api.github.com/users/nexusz99/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nexusz99/aiohttp","description":"http client/server for asyncio (PEP-3156)","fork":true,"url":"https://api.github.com/repos/nexusz99/aiohttp","forks_url":"https://api.github.com/repos/nexusz99/aiohttp/forks","keys_url":"https://api.github.com/repos/nexusz99/aiohttp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nexusz99/aiohttp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nexusz99/aiohttp/teams","hooks_url":"https://api.github.com/repos/nexusz99/aiohttp/hooks","issue_events_url":"https://api.github.com/repos/nexusz99/aiohttp/issues/events{/number}","events_url":"https://api.github.com/repos/nexusz99/aiohttp/events","assignees_url":"https://api.github.com/repos/nexusz99/aiohttp/assignees{/user}","branches_url":"https://api.github.com/repos/nexusz99/aiohttp/branches{/branch}","tags_url":"https://api.github.com/repos/nexusz99/aiohttp/tags","blobs_url":"https://api.github.com/repos/nexusz99/aiohttp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nexusz99/aiohttp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nexusz99/aiohttp/git/refs{/sha}","trees_url":"https://api.github.com/repos/nexusz99/aiohttp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nexusz99/aiohttp/statuses/{sha}","languages_url":"https://api.github.com/repos/nexusz99/aiohttp/languages","stargazers_url":"https://api.github.com/repos/nexusz99/aiohttp/stargazers","contributors_url":"https://api.github.com/repos/nexusz99/aiohttp/contributors","subscribers_url":"https://api.github.com/repos/nexusz99/aiohttp/subscribers","subscription_url":"https://api.github.com/repos/nexusz99/aiohttp/subscription","commits_url":"https://api.github.com/repos/nexusz99/aiohttp/commits{/sha}","git_commits_url":"https://api.github.com/repos/nexusz99/aiohttp/git/commits{/sha}","comments_url":"https://api.github.com/repos/nexusz99/aiohttp/comments{/number}","issue_comment_url":"https://api.github.com/repos/nexusz99/aiohttp/issues/comments{/number}","contents_url":"https://api.github.com/repos/nexusz99/aiohttp/contents/{+path}","compare_url":"https://api.github.com/repos/nexusz99/aiohttp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nexusz99/aiohttp/merges","archive_url":"https://api.github.com/repos/nexusz99/aiohttp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nexusz99/aiohttp/downloads","issues_url":"https://api.github.com/repos/nexusz99/aiohttp/issues{/number}","pulls_url":"https://api.github.com/repos/nexusz99/aiohttp/pulls{/number}","milestones_url":"https://api.github.com/repos/nexusz99/aiohttp/milestones{/number}","notifications_url":"https://api.github.com/repos/nexusz99/aiohttp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nexusz99/aiohttp/labels{/name}","releases_url":"https://api.github.com/repos/nexusz99/aiohttp/releases{/id}","deployments_url":"https://api.github.com/repos/nexusz99/aiohttp/deployments","created_at":"2016-08-15T01:09:14Z","updated_at":"2016-08-15T01:09:15Z","pushed_at":"2016-08-15T08:32:30Z","git_url":"git://github.com/nexusz99/aiohttp.git","ssh_url":"git@github.com:nexusz99/aiohttp.git","clone_url":"https://github.com/nexusz99/aiohttp.git","svn_url":"https://github.com/nexusz99/aiohttp","homepage":"http://aiohttp.readthedocs.io","size":6937,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"KeepSafe:master","ref":"master","sha":"1cf6c183097ec75a7ec9ebd693873b6069eedbb1","user":{"login":"KeepSafe","id":1377248,"avatar_url":"https://avatars.githubusercontent.com/u/1377248?v=3","gravatar_id":"","url":"https://api.github.com/users/KeepSafe","html_url":"https://github.com/KeepSafe","followers_url":"https://api.github.com/users/KeepSafe/followers","following_url":"https://api.github.com/users/KeepSafe/following{/other_user}","gists_url":"https://api.github.com/users/KeepSafe/gists{/gist_id}","starred_url":"https://api.github.com/users/KeepSafe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KeepSafe/subscriptions","organizations_url":"https://api.github.com/users/KeepSafe/orgs","repos_url":"https://api.github.com/users/KeepSafe/repos","events_url":"https://api.github.com/users/KeepSafe/events{/privacy}","received_events_url":"https://api.github.com/users/KeepSafe/received_events","type":"Organization","site_admin":false},"repo":{"id":13258039,"name":"aiohttp","full_name":"KeepSafe/aiohttp","owner":{"login":"KeepSafe","id":1377248,"avatar_url":"https://avatars.githubusercontent.com/u/1377248?v=3","gravatar_id":"","url":"https://api.github.com/users/KeepSafe","html_url":"https://github.com/KeepSafe","followers_url":"https://api.github.com/users/KeepSafe/followers","following_url":"https://api.github.com/users/KeepSafe/following{/other_user}","gists_url":"https://api.github.com/users/KeepSafe/gists{/gist_id}","starred_url":"https://api.github.com/users/KeepSafe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KeepSafe/subscriptions","organizations_url":"https://api.github.com/users/KeepSafe/orgs","repos_url":"https://api.github.com/users/KeepSafe/repos","events_url":"https://api.github.com/users/KeepSafe/events{/privacy}","received_events_url":"https://api.github.com/users/KeepSafe/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/KeepSafe/aiohttp","description":"http client/server for asyncio (PEP-3156)","fork":false,"url":"https://api.github.com/repos/KeepSafe/aiohttp","forks_url":"https://api.github.com/repos/KeepSafe/aiohttp/forks","keys_url":"https://api.github.com/repos/KeepSafe/aiohttp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KeepSafe/aiohttp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KeepSafe/aiohttp/teams","hooks_url":"https://api.github.com/repos/KeepSafe/aiohttp/hooks","issue_events_url":"https://api.github.com/repos/KeepSafe/aiohttp/issues/events{/number}","events_url":"https://api.github.com/repos/KeepSafe/aiohttp/events","assignees_url":"https://api.github.com/repos/KeepSafe/aiohttp/assignees{/user}","branches_url":"https://api.github.com/repos/KeepSafe/aiohttp/branches{/branch}","tags_url":"https://api.github.com/repos/KeepSafe/aiohttp/tags","blobs_url":"https://api.github.com/repos/KeepSafe/aiohttp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KeepSafe/aiohttp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KeepSafe/aiohttp/git/refs{/sha}","trees_url":"https://api.github.com/repos/KeepSafe/aiohttp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KeepSafe/aiohttp/statuses/{sha}","languages_url":"https://api.github.com/repos/KeepSafe/aiohttp/languages","stargazers_url":"https://api.github.com/repos/KeepSafe/aiohttp/stargazers","contributors_url":"https://api.github.com/repos/KeepSafe/aiohttp/contributors","subscribers_url":"https://api.github.com/repos/KeepSafe/aiohttp/subscribers","subscription_url":"https://api.github.com/repos/KeepSafe/aiohttp/subscription","commits_url":"https://api.github.com/repos/KeepSafe/aiohttp/commits{/sha}","git_commits_url":"https://api.github.com/repos/KeepSafe/aiohttp/git/commits{/sha}","comments_url":"https://api.github.com/repos/KeepSafe/aiohttp/comments{/number}","issue_comment_url":"https://api.github.com/repos/KeepSafe/aiohttp/issues/comments{/number}","contents_url":"https://api.github.com/repos/KeepSafe/aiohttp/contents/{+path}","compare_url":"https://api.github.com/repos/KeepSafe/aiohttp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KeepSafe/aiohttp/merges","archive_url":"https://api.github.com/repos/KeepSafe/aiohttp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KeepSafe/aiohttp/downloads","issues_url":"https://api.github.com/repos/KeepSafe/aiohttp/issues{/number}","pulls_url":"https://api.github.com/repos/KeepSafe/aiohttp/pulls{/number}","milestones_url":"https://api.github.com/repos/KeepSafe/aiohttp/milestones{/number}","notifications_url":"https://api.github.com/repos/KeepSafe/aiohttp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KeepSafe/aiohttp/labels{/name}","releases_url":"https://api.github.com/repos/KeepSafe/aiohttp/releases{/id}","deployments_url":"https://api.github.com/repos/KeepSafe/aiohttp/deployments","created_at":"2013-10-01T23:04:01Z","updated_at":"2016-08-15T08:04:07Z","pushed_at":"2016-08-15T09:19:51Z","git_url":"git://github.com/KeepSafe/aiohttp.git","ssh_url":"git@github.com:KeepSafe/aiohttp.git","clone_url":"https://github.com/KeepSafe/aiohttp.git","svn_url":"https://github.com/KeepSafe/aiohttp","homepage":"http://aiohttp.readthedocs.io","size":7445,"stargazers_count":2074,"watchers_count":2074,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":363,"mirror_url":null,"open_issues_count":107,"forks":363,"open_issues":107,"watchers":2074,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/KeepSafe/aiohttp/pulls/1083"},"html":{"href":"https://github.com/KeepSafe/aiohttp/pull/1083"},"issue":{"href":"https://api.github.com/repos/KeepSafe/aiohttp/issues/1083"},"comments":{"href":"https://api.github.com/repos/KeepSafe/aiohttp/issues/1083/comments"},"review_comments":{"href":"https://api.github.com/repos/KeepSafe/aiohttp/pulls/1083/comments"},"review_comment":{"href":"https://api.github.com/repos/KeepSafe/aiohttp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/KeepSafe/aiohttp/pulls/1083/commits"},"statuses":{"href":"https://api.github.com/repos/KeepSafe/aiohttp/statuses/bc03bee41c1f5a116a40877711274b9f959f972d"}}}}
{"actor":{"display_login":"asvetlov"}}