{"action":"created","comment":{"url":"https://api.github.com/repos/valhalla/sif/pulls/comments/87065712","pull_request_review_id":7692914,"id":87065712,"diff_hunk":"@@ -606,6 +605,11 @@ Cost BicycleCost::EdgeCost(const baldr::DirectedEdge* edge) const {\n       // penalty and road class factor\n       factor = speedpenalty_[road_speed] +\n               (road_factor_ * kRoadClassFactor[static_cast<uint32_t>(edge->classification())]);\n+\n+      // Slight penalty going though destination only areas if no bike lanes\n+      if (edge->destonly()) {\n+        factor += 0.1f;","path":"src/sif/bicyclecost.cc","position":37,"original_position":37,"commit_id":"df5f06764ab14f60f06bb9a3169e2341144569ed","original_commit_id":"df5f06764ab14f60f06bb9a3169e2341144569ed","user":{"login":"kevinkreiser","id":697548,"avatar_url":"https://avatars.githubusercontent.com/u/697548?v=3","gravatar_id":"","url":"https://api.github.com/users/kevinkreiser","html_url":"https://github.com/kevinkreiser","followers_url":"https://api.github.com/users/kevinkreiser/followers","following_url":"https://api.github.com/users/kevinkreiser/following{/other_user}","gists_url":"https://api.github.com/users/kevinkreiser/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinkreiser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinkreiser/subscriptions","organizations_url":"https://api.github.com/users/kevinkreiser/orgs","repos_url":"https://api.github.com/users/kevinkreiser/repos","events_url":"https://api.github.com/users/kevinkreiser/events{/privacy}","received_events_url":"https://api.github.com/users/kevinkreiser/received_events","type":"User","site_admin":false},"body":"should this be a `constexpr` as well?","created_at":"2016-11-08T19:32:22Z","updated_at":"2016-11-08T19:32:22Z","html_url":"https://github.com/valhalla/sif/pull/152#discussion_r87065712","pull_request_url":"https://api.github.com/repos/valhalla/sif/pulls/152","_links":{"self":{"href":"https://api.github.com/repos/valhalla/sif/pulls/comments/87065712"},"html":{"href":"https://github.com/valhalla/sif/pull/152#discussion_r87065712"},"pull_request":{"href":"https://api.github.com/repos/valhalla/sif/pulls/152"}}},"pull_request":{"url":"https://api.github.com/repos/valhalla/sif/pulls/152","id":92842505,"html_url":"https://github.com/valhalla/sif/pull/152","diff_url":"https://github.com/valhalla/sif/pull/152.diff","patch_url":"https://github.com/valhalla/sif/pull/152.patch","issue_url":"https://api.github.com/repos/valhalla/sif/issues/152","number":152,"state":"open","locked":false,"title":"Reduce the crossing cost for pedestrian routes when stop impact is low.","user":{"login":"dnesbitt61","id":1838768,"avatar_url":"https://avatars.githubusercontent.com/u/1838768?v=3","gravatar_id":"","url":"https://api.github.com/users/dnesbitt61","html_url":"https://github.com/dnesbitt61","followers_url":"https://api.github.com/users/dnesbitt61/followers","following_url":"https://api.github.com/users/dnesbitt61/following{/other_user}","gists_url":"https://api.github.com/users/dnesbitt61/gists{/gist_id}","starred_url":"https://api.github.com/users/dnesbitt61/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnesbitt61/subscriptions","organizations_url":"https://api.github.com/users/dnesbitt61/orgs","repos_url":"https://api.github.com/users/dnesbitt61/repos","events_url":"https://api.github.com/users/dnesbitt61/events{/privacy}","received_events_url":"https://api.github.com/users/dnesbitt61/received_events","type":"User","site_admin":false},"body":"Add penalty to roundabouts. Change bicycle penalty to be on driveways (not destination only roads). Add small penalty to destination only roads.\r\nFixes issue#148\r\n","created_at":"2016-11-08T19:25:56Z","updated_at":"2016-11-08T19:32:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eec77ca976dcfc71f6322b1dcb0d77868e8dc124","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/valhalla/sif/pulls/152/commits","review_comments_url":"https://api.github.com/repos/valhalla/sif/pulls/152/comments","review_comment_url":"https://api.github.com/repos/valhalla/sif/pulls/comments{/number}","comments_url":"https://api.github.com/repos/valhalla/sif/issues/152/comments","statuses_url":"https://api.github.com/repos/valhalla/sif/statuses/df5f06764ab14f60f06bb9a3169e2341144569ed","head":{"label":"valhalla:dwn","ref":"dwn","sha":"df5f06764ab14f60f06bb9a3169e2341144569ed","user":{"login":"valhalla","id":10232331,"avatar_url":"https://avatars.githubusercontent.com/u/10232331?v=3","gravatar_id":"","url":"https://api.github.com/users/valhalla","html_url":"https://github.com/valhalla","followers_url":"https://api.github.com/users/valhalla/followers","following_url":"https://api.github.com/users/valhalla/following{/other_user}","gists_url":"https://api.github.com/users/valhalla/gists{/gist_id}","starred_url":"https://api.github.com/users/valhalla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/valhalla/subscriptions","organizations_url":"https://api.github.com/users/valhalla/orgs","repos_url":"https://api.github.com/users/valhalla/repos","events_url":"https://api.github.com/users/valhalla/events{/privacy}","received_events_url":"https://api.github.com/users/valhalla/received_events","type":"Organization","site_admin":false},"repo":{"id":33613304,"name":"sif","full_name":"valhalla/sif","owner":{"login":"valhalla","id":10232331,"avatar_url":"https://avatars.githubusercontent.com/u/10232331?v=3","gravatar_id":"","url":"https://api.github.com/users/valhalla","html_url":"https://github.com/valhalla","followers_url":"https://api.github.com/users/valhalla/followers","following_url":"https://api.github.com/users/valhalla/following{/other_user}","gists_url":"https://api.github.com/users/valhalla/gists{/gist_id}","starred_url":"https://api.github.com/users/valhalla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/valhalla/subscriptions","organizations_url":"https://api.github.com/users/valhalla/orgs","repos_url":"https://api.github.com/users/valhalla/repos","events_url":"https://api.github.com/users/valhalla/events{/privacy}","received_events_url":"https://api.github.com/users/valhalla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/valhalla/sif","description":"Costing model used in graph traversal and correlation","fork":false,"url":"https://api.github.com/repos/valhalla/sif","forks_url":"https://api.github.com/repos/valhalla/sif/forks","keys_url":"https://api.github.com/repos/valhalla/sif/keys{/key_id}","collaborators_url":"https://api.github.com/repos/valhalla/sif/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/valhalla/sif/teams","hooks_url":"https://api.github.com/repos/valhalla/sif/hooks","issue_events_url":"https://api.github.com/repos/valhalla/sif/issues/events{/number}","events_url":"https://api.github.com/repos/valhalla/sif/events","assignees_url":"https://api.github.com/repos/valhalla/sif/assignees{/user}","branches_url":"https://api.github.com/repos/valhalla/sif/branches{/branch}","tags_url":"https://api.github.com/repos/valhalla/sif/tags","blobs_url":"https://api.github.com/repos/valhalla/sif/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/valhalla/sif/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/valhalla/sif/git/refs{/sha}","trees_url":"https://api.github.com/repos/valhalla/sif/git/trees{/sha}","statuses_url":"https://api.github.com/repos/valhalla/sif/statuses/{sha}","languages_url":"https://api.github.com/repos/valhalla/sif/languages","stargazers_url":"https://api.github.com/repos/valhalla/sif/stargazers","contributors_url":"https://api.github.com/repos/valhalla/sif/contributors","subscribers_url":"https://api.github.com/repos/valhalla/sif/subscribers","subscription_url":"https://api.github.com/repos/valhalla/sif/subscription","commits_url":"https://api.github.com/repos/valhalla/sif/commits{/sha}","git_commits_url":"https://api.github.com/repos/valhalla/sif/git/commits{/sha}","comments_url":"https://api.github.com/repos/valhalla/sif/comments{/number}","issue_comment_url":"https://api.github.com/repos/valhalla/sif/issues/comments{/number}","contents_url":"https://api.github.com/repos/valhalla/sif/contents/{+path}","compare_url":"https://api.github.com/repos/valhalla/sif/compare/{base}...{head}","merges_url":"https://api.github.com/repos/valhalla/sif/merges","archive_url":"https://api.github.com/repos/valhalla/sif/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/valhalla/sif/downloads","issues_url":"https://api.github.com/repos/valhalla/sif/issues{/number}","pulls_url":"https://api.github.com/repos/valhalla/sif/pulls{/number}","milestones_url":"https://api.github.com/repos/valhalla/sif/milestones{/number}","notifications_url":"https://api.github.com/repos/valhalla/sif/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/valhalla/sif/labels{/name}","releases_url":"https://api.github.com/repos/valhalla/sif/releases{/id}","deployments_url":"https://api.github.com/repos/valhalla/sif/deployments","created_at":"2015-04-08T14:51:44Z","updated_at":"2016-11-02T20:53:49Z","pushed_at":"2016-11-08T19:25:56Z","git_url":"git://github.com/valhalla/sif.git","ssh_url":"git@github.com:valhalla/sif.git","clone_url":"https://github.com/valhalla/sif.git","svn_url":"https://github.com/valhalla/sif","homepage":"","size":6059,"stargazers_count":14,"watchers_count":14,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":11,"forks":9,"open_issues":11,"watchers":14,"default_branch":"master"}},"base":{"label":"valhalla:master","ref":"master","sha":"5c788be42dc0e706941850fc3eeb60d8fe9073a1","user":{"login":"valhalla","id":10232331,"avatar_url":"https://avatars.githubusercontent.com/u/10232331?v=3","gravatar_id":"","url":"https://api.github.com/users/valhalla","html_url":"https://github.com/valhalla","followers_url":"https://api.github.com/users/valhalla/followers","following_url":"https://api.github.com/users/valhalla/following{/other_user}","gists_url":"https://api.github.com/users/valhalla/gists{/gist_id}","starred_url":"https://api.github.com/users/valhalla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/valhalla/subscriptions","organizations_url":"https://api.github.com/users/valhalla/orgs","repos_url":"https://api.github.com/users/valhalla/repos","events_url":"https://api.github.com/users/valhalla/events{/privacy}","received_events_url":"https://api.github.com/users/valhalla/received_events","type":"Organization","site_admin":false},"repo":{"id":33613304,"name":"sif","full_name":"valhalla/sif","owner":{"login":"valhalla","id":10232331,"avatar_url":"https://avatars.githubusercontent.com/u/10232331?v=3","gravatar_id":"","url":"https://api.github.com/users/valhalla","html_url":"https://github.com/valhalla","followers_url":"https://api.github.com/users/valhalla/followers","following_url":"https://api.github.com/users/valhalla/following{/other_user}","gists_url":"https://api.github.com/users/valhalla/gists{/gist_id}","starred_url":"https://api.github.com/users/valhalla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/valhalla/subscriptions","organizations_url":"https://api.github.com/users/valhalla/orgs","repos_url":"https://api.github.com/users/valhalla/repos","events_url":"https://api.github.com/users/valhalla/events{/privacy}","received_events_url":"https://api.github.com/users/valhalla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/valhalla/sif","description":"Costing model used in graph traversal and correlation","fork":false,"url":"https://api.github.com/repos/valhalla/sif","forks_url":"https://api.github.com/repos/valhalla/sif/forks","keys_url":"https://api.github.com/repos/valhalla/sif/keys{/key_id}","collaborators_url":"https://api.github.com/repos/valhalla/sif/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/valhalla/sif/teams","hooks_url":"https://api.github.com/repos/valhalla/sif/hooks","issue_events_url":"https://api.github.com/repos/valhalla/sif/issues/events{/number}","events_url":"https://api.github.com/repos/valhalla/sif/events","assignees_url":"https://api.github.com/repos/valhalla/sif/assignees{/user}","branches_url":"https://api.github.com/repos/valhalla/sif/branches{/branch}","tags_url":"https://api.github.com/repos/valhalla/sif/tags","blobs_url":"https://api.github.com/repos/valhalla/sif/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/valhalla/sif/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/valhalla/sif/git/refs{/sha}","trees_url":"https://api.github.com/repos/valhalla/sif/git/trees{/sha}","statuses_url":"https://api.github.com/repos/valhalla/sif/statuses/{sha}","languages_url":"https://api.github.com/repos/valhalla/sif/languages","stargazers_url":"https://api.github.com/repos/valhalla/sif/stargazers","contributors_url":"https://api.github.com/repos/valhalla/sif/contributors","subscribers_url":"https://api.github.com/repos/valhalla/sif/subscribers","subscription_url":"https://api.github.com/repos/valhalla/sif/subscription","commits_url":"https://api.github.com/repos/valhalla/sif/commits{/sha}","git_commits_url":"https://api.github.com/repos/valhalla/sif/git/commits{/sha}","comments_url":"https://api.github.com/repos/valhalla/sif/comments{/number}","issue_comment_url":"https://api.github.com/repos/valhalla/sif/issues/comments{/number}","contents_url":"https://api.github.com/repos/valhalla/sif/contents/{+path}","compare_url":"https://api.github.com/repos/valhalla/sif/compare/{base}...{head}","merges_url":"https://api.github.com/repos/valhalla/sif/merges","archive_url":"https://api.github.com/repos/valhalla/sif/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/valhalla/sif/downloads","issues_url":"https://api.github.com/repos/valhalla/sif/issues{/number}","pulls_url":"https://api.github.com/repos/valhalla/sif/pulls{/number}","milestones_url":"https://api.github.com/repos/valhalla/sif/milestones{/number}","notifications_url":"https://api.github.com/repos/valhalla/sif/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/valhalla/sif/labels{/name}","releases_url":"https://api.github.com/repos/valhalla/sif/releases{/id}","deployments_url":"https://api.github.com/repos/valhalla/sif/deployments","created_at":"2015-04-08T14:51:44Z","updated_at":"2016-11-02T20:53:49Z","pushed_at":"2016-11-08T19:25:56Z","git_url":"git://github.com/valhalla/sif.git","ssh_url":"git@github.com:valhalla/sif.git","clone_url":"https://github.com/valhalla/sif.git","svn_url":"https://github.com/valhalla/sif","homepage":"","size":6059,"stargazers_count":14,"watchers_count":14,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":11,"forks":9,"open_issues":11,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/valhalla/sif/pulls/152"},"html":{"href":"https://github.com/valhalla/sif/pull/152"},"issue":{"href":"https://api.github.com/repos/valhalla/sif/issues/152"},"comments":{"href":"https://api.github.com/repos/valhalla/sif/issues/152/comments"},"review_comments":{"href":"https://api.github.com/repos/valhalla/sif/pulls/152/comments"},"review_comment":{"href":"https://api.github.com/repos/valhalla/sif/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/valhalla/sif/pulls/152/commits"},"statuses":{"href":"https://api.github.com/repos/valhalla/sif/statuses/df5f06764ab14f60f06bb9a3169e2341144569ed"}}}}
{"actor":{"display_login":"kevinkreiser"}}