{"action":"created","comment":{"url":"https://api.github.com/repos/openvstorage/framework-alba-plugin/pulls/comments/53471194","id":53471194,"diff_hunk":"@@ -251,7 +251,10 @@ def add_cluster(alba_backend_guid):\n \n         etcd_key = AlbaController.ETCD_NR_OF_AGENTS_KEY.format(alba_backend_guid)\n         nr_of_storage_nodes = len(AlbaNodeList.get_albanodes())\n-        EtcdConfiguration.set(etcd_key, nr_of_storage_nodes)","path":"ovs/lib/albacontroller.py","position":4,"original_position":4,"commit_id":"5388bf3c783b24fccfdb922290d34e0b64d1692e","original_commit_id":"5388bf3c783b24fccfdb922290d34e0b64d1692e","user":{"login":"khenderick","id":1453214,"avatar_url":"https://avatars.githubusercontent.com/u/1453214?v=3","gravatar_id":"","url":"https://api.github.com/users/khenderick","html_url":"https://github.com/khenderick","followers_url":"https://api.github.com/users/khenderick/followers","following_url":"https://api.github.com/users/khenderick/following{/other_user}","gists_url":"https://api.github.com/users/khenderick/gists{/gist_id}","starred_url":"https://api.github.com/users/khenderick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khenderick/subscriptions","organizations_url":"https://api.github.com/users/khenderick/orgs","repos_url":"https://api.github.com/users/khenderick/repos","events_url":"https://api.github.com/users/khenderick/events{/privacy}","received_events_url":"https://api.github.com/users/khenderick/received_events","type":"User","site_admin":false},"body":"The setup still does that, but at this point, at the node being installed, the asd-manager setup has not been executed yet. So basically, the correct thing to do here is make sure that the AlbaController.add_cluster also (at the end) runs that one method that does the node detection.","created_at":"2016-02-19T15:07:48Z","updated_at":"2016-02-19T15:07:48Z","html_url":"https://github.com/openvstorage/framework-alba-plugin/pull/107#discussion_r53471194","pull_request_url":"https://api.github.com/repos/openvstorage/framework-alba-plugin/pulls/107","_links":{"self":{"href":"https://api.github.com/repos/openvstorage/framework-alba-plugin/pulls/comments/53471194"},"html":{"href":"https://github.com/openvstorage/framework-alba-plugin/pull/107#discussion_r53471194"},"pull_request":{"href":"https://api.github.com/repos/openvstorage/framework-alba-plugin/pulls/107"}}},"pull_request":{"url":"https://api.github.com/repos/openvstorage/framework-alba-plugin/pulls/107","id":59959788,"html_url":"https://github.com/openvstorage/framework-alba-plugin/pull/107","diff_url":"https://github.com/openvstorage/framework-alba-plugin/pull/107.diff","patch_url":"https://github.com/openvstorage/framework-alba-plugin/pull/107.patch","issue_url":"https://api.github.com/repos/openvstorage/framework-alba-plugin/issues/107","number":107,"state":"open","locked":false,"title":"ovs-4139-initial-etcd-value-update","user":{"login":"pploegaert","id":8393135,"avatar_url":"https://avatars.githubusercontent.com/u/8393135?v=3","gravatar_id":"","url":"https://api.github.com/users/pploegaert","html_url":"https://github.com/pploegaert","followers_url":"https://api.github.com/users/pploegaert/followers","following_url":"https://api.github.com/users/pploegaert/following{/other_user}","gists_url":"https://api.github.com/users/pploegaert/gists{/gist_id}","starred_url":"https://api.github.com/users/pploegaert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pploegaert/subscriptions","organizations_url":"https://api.github.com/users/pploegaert/orgs","repos_url":"https://api.github.com/users/pploegaert/repos","events_url":"https://api.github.com/users/pploegaert/events{/privacy}","received_events_url":"https://api.github.com/users/pploegaert/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-02-19T14:58:58Z","updated_at":"2016-02-19T15:07:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2153b0c081cb08677b4dd9c907e060d97b6bd8de","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openvstorage/framework-alba-plugin/pulls/107/commits","review_comments_url":"https://api.github.com/repos/openvstorage/framework-alba-plugin/pulls/107/comments","review_comment_url":"https://api.github.com/repos/openvstorage/framework-alba-plugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openvstorage/framework-alba-plugin/issues/107/comments","statuses_url":"https://api.github.com/repos/openvstorage/framework-alba-plugin/statuses/5388bf3c783b24fccfdb922290d34e0b64d1692e","head":{"label":"openvstorage:ovs-4139-initial-etcd-value-update","ref":"ovs-4139-initial-etcd-value-update","sha":"5388bf3c783b24fccfdb922290d34e0b64d1692e","user":{"login":"openvstorage","id":12763393,"avatar_url":"https://avatars.githubusercontent.com/u/12763393?v=3","gravatar_id":"","url":"https://api.github.com/users/openvstorage","html_url":"https://github.com/openvstorage","followers_url":"https://api.github.com/users/openvstorage/followers","following_url":"https://api.github.com/users/openvstorage/following{/other_user}","gists_url":"https://api.github.com/users/openvstorage/gists{/gist_id}","starred_url":"https://api.github.com/users/openvstorage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openvstorage/subscriptions","organizations_url":"https://api.github.com/users/openvstorage/orgs","repos_url":"https://api.github.com/users/openvstorage/repos","events_url":"https://api.github.com/users/openvstorage/events{/privacy}","received_events_url":"https://api.github.com/users/openvstorage/received_events","type":"Organization","site_admin":false},"repo":{"id":39820044,"name":"framework-alba-plugin","full_name":"openvstorage/framework-alba-plugin","owner":{"login":"openvstorage","id":12763393,"avatar_url":"https://avatars.githubusercontent.com/u/12763393?v=3","gravatar_id":"","url":"https://api.github.com/users/openvstorage","html_url":"https://github.com/openvstorage","followers_url":"https://api.github.com/users/openvstorage/followers","following_url":"https://api.github.com/users/openvstorage/following{/other_user}","gists_url":"https://api.github.com/users/openvstorage/gists{/gist_id}","starred_url":"https://api.github.com/users/openvstorage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openvstorage/subscriptions","organizations_url":"https://api.github.com/users/openvstorage/orgs","repos_url":"https://api.github.com/users/openvstorage/repos","events_url":"https://api.github.com/users/openvstorage/events{/privacy}","received_events_url":"https://api.github.com/users/openvstorage/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openvstorage/framework-alba-plugin","description":null,"fork":false,"url":"https://api.github.com/repos/openvstorage/framework-alba-plugin","forks_url":"https://api.github.com/repos/openvstorage/framework-alba-plugin/forks","keys_url":"https://api.github.com/repos/openvstorage/framework-alba-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openvstorage/framework-alba-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openvstorage/framework-alba-plugin/teams","hooks_url":"https://api.github.com/repos/openvstorage/framework-alba-plugin/hooks","issue_events_url":"https://api.github.com/repos/openvstorage/framework-alba-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/openvstorage/framework-alba-plugin/events","assignees_url":"https://api.github.com/repos/openvstorage/framework-alba-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/openvstorage/framework-alba-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/openvstorage/framework-alba-plugin/tags","blobs_url":"https://api.github.com/repos/openvstorage/framework-alba-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openvstorage/framework-alba-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openvstorage/framework-alba-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/openvstorage/framework-alba-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openvstorage/framework-alba-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/openvstorage/framework-alba-plugin/languages","stargazers_url":"https://api.github.com/repos/openvstorage/framework-alba-plugin/stargazers","contributors_url":"https://api.github.com/repos/openvstorage/framework-alba-plugin/contributors","subscribers_url":"https://api.github.com/repos/openvstorage/framework-alba-plugin/subscribers","subscription_url":"https://api.github.com/repos/openvstorage/framework-alba-plugin/subscription","commits_url":"https://api.github.com/repos/openvstorage/framework-alba-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/openvstorage/framework-alba-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/openvstorage/framework-alba-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/openvstorage/framework-alba-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/openvstorage/framework-alba-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/openvstorage/framework-alba-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openvstorage/framework-alba-plugin/merges","archive_url":"https://api.github.com/repos/openvstorage/framework-alba-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openvstorage/framework-alba-plugin/downloads","issues_url":"https://api.github.com/repos/openvstorage/framework-alba-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/openvstorage/framework-alba-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/openvstorage/framework-alba-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/openvstorage/framework-alba-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openvstorage/framework-alba-plugin/labels{/name}","releases_url":"https://api.github.com/repos/openvstorage/framework-alba-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/openvstorage/framework-alba-plugin/deployments","created_at":"2015-07-28T07:40:52Z","updated_at":"2016-01-11T14:14:00Z","pushed_at":"2016-02-19T14:59:00Z","git_url":"git://github.com/openvstorage/framework-alba-plugin.git","ssh_url":"git@github.com:openvstorage/framework-alba-plugin.git","clone_url":"https://github.com/openvstorage/framework-alba-plugin.git","svn_url":"https://github.com/openvstorage/framework-alba-plugin","homepage":null,"size":658,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":3,"forks":1,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"openvstorage:master","ref":"master","sha":"145538ab6b3be6210dab4dc64c5fdd5f28d6fc5c","user":{"login":"openvstorage","id":12763393,"avatar_url":"https://avatars.githubusercontent.com/u/12763393?v=3","gravatar_id":"","url":"https://api.github.com/users/openvstorage","html_url":"https://github.com/openvstorage","followers_url":"https://api.github.com/users/openvstorage/followers","following_url":"https://api.github.com/users/openvstorage/following{/other_user}","gists_url":"https://api.github.com/users/openvstorage/gists{/gist_id}","starred_url":"https://api.github.com/users/openvstorage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openvstorage/subscriptions","organizations_url":"https://api.github.com/users/openvstorage/orgs","repos_url":"https://api.github.com/users/openvstorage/repos","events_url":"https://api.github.com/users/openvstorage/events{/privacy}","received_events_url":"https://api.github.com/users/openvstorage/received_events","type":"Organization","site_admin":false},"repo":{"id":39820044,"name":"framework-alba-plugin","full_name":"openvstorage/framework-alba-plugin","owner":{"login":"openvstorage","id":12763393,"avatar_url":"https://avatars.githubusercontent.com/u/12763393?v=3","gravatar_id":"","url":"https://api.github.com/users/openvstorage","html_url":"https://github.com/openvstorage","followers_url":"https://api.github.com/users/openvstorage/followers","following_url":"https://api.github.com/users/openvstorage/following{/other_user}","gists_url":"https://api.github.com/users/openvstorage/gists{/gist_id}","starred_url":"https://api.github.com/users/openvstorage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openvstorage/subscriptions","organizations_url":"https://api.github.com/users/openvstorage/orgs","repos_url":"https://api.github.com/users/openvstorage/repos","events_url":"https://api.github.com/users/openvstorage/events{/privacy}","received_events_url":"https://api.github.com/users/openvstorage/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openvstorage/framework-alba-plugin","description":null,"fork":false,"url":"https://api.github.com/repos/openvstorage/framework-alba-plugin","forks_url":"https://api.github.com/repos/openvstorage/framework-alba-plugin/forks","keys_url":"https://api.github.com/repos/openvstorage/framework-alba-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openvstorage/framework-alba-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openvstorage/framework-alba-plugin/teams","hooks_url":"https://api.github.com/repos/openvstorage/framework-alba-plugin/hooks","issue_events_url":"https://api.github.com/repos/openvstorage/framework-alba-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/openvstorage/framework-alba-plugin/events","assignees_url":"https://api.github.com/repos/openvstorage/framework-alba-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/openvstorage/framework-alba-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/openvstorage/framework-alba-plugin/tags","blobs_url":"https://api.github.com/repos/openvstorage/framework-alba-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openvstorage/framework-alba-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openvstorage/framework-alba-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/openvstorage/framework-alba-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openvstorage/framework-alba-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/openvstorage/framework-alba-plugin/languages","stargazers_url":"https://api.github.com/repos/openvstorage/framework-alba-plugin/stargazers","contributors_url":"https://api.github.com/repos/openvstorage/framework-alba-plugin/contributors","subscribers_url":"https://api.github.com/repos/openvstorage/framework-alba-plugin/subscribers","subscription_url":"https://api.github.com/repos/openvstorage/framework-alba-plugin/subscription","commits_url":"https://api.github.com/repos/openvstorage/framework-alba-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/openvstorage/framework-alba-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/openvstorage/framework-alba-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/openvstorage/framework-alba-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/openvstorage/framework-alba-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/openvstorage/framework-alba-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openvstorage/framework-alba-plugin/merges","archive_url":"https://api.github.com/repos/openvstorage/framework-alba-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openvstorage/framework-alba-plugin/downloads","issues_url":"https://api.github.com/repos/openvstorage/framework-alba-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/openvstorage/framework-alba-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/openvstorage/framework-alba-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/openvstorage/framework-alba-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openvstorage/framework-alba-plugin/labels{/name}","releases_url":"https://api.github.com/repos/openvstorage/framework-alba-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/openvstorage/framework-alba-plugin/deployments","created_at":"2015-07-28T07:40:52Z","updated_at":"2016-01-11T14:14:00Z","pushed_at":"2016-02-19T14:59:00Z","git_url":"git://github.com/openvstorage/framework-alba-plugin.git","ssh_url":"git@github.com:openvstorage/framework-alba-plugin.git","clone_url":"https://github.com/openvstorage/framework-alba-plugin.git","svn_url":"https://github.com/openvstorage/framework-alba-plugin","homepage":null,"size":658,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":3,"forks":1,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openvstorage/framework-alba-plugin/pulls/107"},"html":{"href":"https://github.com/openvstorage/framework-alba-plugin/pull/107"},"issue":{"href":"https://api.github.com/repos/openvstorage/framework-alba-plugin/issues/107"},"comments":{"href":"https://api.github.com/repos/openvstorage/framework-alba-plugin/issues/107/comments"},"review_comments":{"href":"https://api.github.com/repos/openvstorage/framework-alba-plugin/pulls/107/comments"},"review_comment":{"href":"https://api.github.com/repos/openvstorage/framework-alba-plugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openvstorage/framework-alba-plugin/pulls/107/commits"},"statuses":{"href":"https://api.github.com/repos/openvstorage/framework-alba-plugin/statuses/5388bf3c783b24fccfdb922290d34e0b64d1692e"}}}}