{"action":"created","comment":{"url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/comments/78707045","id":78707045,"diff_hunk":"@@ -116,6 +118,9 @@\n os_sdn_net = Barclamp::Inventory.get_network_definition(node, \"os_sdn\")\n mtu_value = os_sdn_net.nil? ? 1500 : os_sdn_net[\"mtu\"].to_i\n \n+ipam_driver = nil\n+ipam_driver = \"infoblox\" if infoblox_settings[:use_infoblox]","path":"chef/cookbooks/neutron/recipes/common_config.rb","position":14,"original_position":14,"commit_id":"9700382f0b662c4aa9420de7b94de0d692ffc839","original_commit_id":"9700382f0b662c4aa9420de7b94de0d692ffc839","user":{"login":"jgrassler","id":5631641,"avatar_url":"https://avatars.githubusercontent.com/u/5631641?v=3","gravatar_id":"","url":"https://api.github.com/users/jgrassler","html_url":"https://github.com/jgrassler","followers_url":"https://api.github.com/users/jgrassler/followers","following_url":"https://api.github.com/users/jgrassler/following{/other_user}","gists_url":"https://api.github.com/users/jgrassler/gists{/gist_id}","starred_url":"https://api.github.com/users/jgrassler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgrassler/subscriptions","organizations_url":"https://api.github.com/users/jgrassler/orgs","repos_url":"https://api.github.com/users/jgrassler/repos","events_url":"https://api.github.com/users/jgrassler/events{/privacy}","received_events_url":"https://api.github.com/users/jgrassler/received_events","type":"User","site_admin":false},"body":"I don't like the `? :` operator very much - it is easy to overlook and hence almost invariably slows at least me down when reading the code. I.e. this is mostly a matter of personal preference :-)\r\n\r\nIf you'd rather have a one liner here I can change it, though.","created_at":"2016-09-14T08:37:34Z","updated_at":"2016-09-14T08:37:34Z","html_url":"https://github.com/crowbar/crowbar-openstack/pull/521#discussion_r78707045","pull_request_url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/521","_links":{"self":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/comments/78707045"},"html":{"href":"https://github.com/crowbar/crowbar-openstack/pull/521#discussion_r78707045"},"pull_request":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/521"}}},"pull_request":{"url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/521","id":84018750,"html_url":"https://github.com/crowbar/crowbar-openstack/pull/521","diff_url":"https://github.com/crowbar/crowbar-openstack/pull/521.diff","patch_url":"https://github.com/crowbar/crowbar-openstack/pull/521.patch","issue_url":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/521","number":521,"state":"open","locked":false,"title":"Infoblox","user":{"login":"jgrassler","id":5631641,"avatar_url":"https://avatars.githubusercontent.com/u/5631641?v=3","gravatar_id":"","url":"https://api.github.com/users/jgrassler","html_url":"https://github.com/jgrassler","followers_url":"https://api.github.com/users/jgrassler/followers","following_url":"https://api.github.com/users/jgrassler/following{/other_user}","gists_url":"https://api.github.com/users/jgrassler/gists{/gist_id}","starred_url":"https://api.github.com/users/jgrassler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgrassler/subscriptions","organizations_url":"https://api.github.com/users/jgrassler/orgs","repos_url":"https://api.github.com/users/jgrassler/repos","events_url":"https://api.github.com/users/jgrassler/events{/privacy}","received_events_url":"https://api.github.com/users/jgrassler/received_events","type":"User","site_admin":false},"body":"This pull request adds support for the [new style infoblox Neutron plugin](https://github.com/openstack/networking-infoblox/).","created_at":"2016-09-05T15:39:30Z","updated_at":"2016-09-14T08:37:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"af6cc07c8eaa4d3f8a3d797c5c2a1a0d9843e758","assignee":{"login":"vuntz","id":1758783,"avatar_url":"https://avatars.githubusercontent.com/u/1758783?v=3","gravatar_id":"","url":"https://api.github.com/users/vuntz","html_url":"https://github.com/vuntz","followers_url":"https://api.github.com/users/vuntz/followers","following_url":"https://api.github.com/users/vuntz/following{/other_user}","gists_url":"https://api.github.com/users/vuntz/gists{/gist_id}","starred_url":"https://api.github.com/users/vuntz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vuntz/subscriptions","organizations_url":"https://api.github.com/users/vuntz/orgs","repos_url":"https://api.github.com/users/vuntz/repos","events_url":"https://api.github.com/users/vuntz/events{/privacy}","received_events_url":"https://api.github.com/users/vuntz/received_events","type":"User","site_admin":false},"assignees":[{"login":"vuntz","id":1758783,"avatar_url":"https://avatars.githubusercontent.com/u/1758783?v=3","gravatar_id":"","url":"https://api.github.com/users/vuntz","html_url":"https://github.com/vuntz","followers_url":"https://api.github.com/users/vuntz/followers","following_url":"https://api.github.com/users/vuntz/following{/other_user}","gists_url":"https://api.github.com/users/vuntz/gists{/gist_id}","starred_url":"https://api.github.com/users/vuntz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vuntz/subscriptions","organizations_url":"https://api.github.com/users/vuntz/orgs","repos_url":"https://api.github.com/users/vuntz/repos","events_url":"https://api.github.com/users/vuntz/events{/privacy}","received_events_url":"https://api.github.com/users/vuntz/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/521/commits","review_comments_url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/521/comments","review_comment_url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/521/comments","statuses_url":"https://api.github.com/repos/crowbar/crowbar-openstack/statuses/9700382f0b662c4aa9420de7b94de0d692ffc839","head":{"label":"jgrassler:infoblox","ref":"infoblox","sha":"9700382f0b662c4aa9420de7b94de0d692ffc839","user":{"login":"jgrassler","id":5631641,"avatar_url":"https://avatars.githubusercontent.com/u/5631641?v=3","gravatar_id":"","url":"https://api.github.com/users/jgrassler","html_url":"https://github.com/jgrassler","followers_url":"https://api.github.com/users/jgrassler/followers","following_url":"https://api.github.com/users/jgrassler/following{/other_user}","gists_url":"https://api.github.com/users/jgrassler/gists{/gist_id}","starred_url":"https://api.github.com/users/jgrassler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgrassler/subscriptions","organizations_url":"https://api.github.com/users/jgrassler/orgs","repos_url":"https://api.github.com/users/jgrassler/repos","events_url":"https://api.github.com/users/jgrassler/events{/privacy}","received_events_url":"https://api.github.com/users/jgrassler/received_events","type":"User","site_admin":false},"repo":{"id":54136324,"name":"crowbar-openstack","full_name":"jgrassler/crowbar-openstack","owner":{"login":"jgrassler","id":5631641,"avatar_url":"https://avatars.githubusercontent.com/u/5631641?v=3","gravatar_id":"","url":"https://api.github.com/users/jgrassler","html_url":"https://github.com/jgrassler","followers_url":"https://api.github.com/users/jgrassler/followers","following_url":"https://api.github.com/users/jgrassler/following{/other_user}","gists_url":"https://api.github.com/users/jgrassler/gists{/gist_id}","starred_url":"https://api.github.com/users/jgrassler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgrassler/subscriptions","organizations_url":"https://api.github.com/users/jgrassler/orgs","repos_url":"https://api.github.com/users/jgrassler/repos","events_url":"https://api.github.com/users/jgrassler/events{/privacy}","received_events_url":"https://api.github.com/users/jgrassler/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jgrassler/crowbar-openstack","description":"Openstack deployment for Crowbar","fork":true,"url":"https://api.github.com/repos/jgrassler/crowbar-openstack","forks_url":"https://api.github.com/repos/jgrassler/crowbar-openstack/forks","keys_url":"https://api.github.com/repos/jgrassler/crowbar-openstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jgrassler/crowbar-openstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jgrassler/crowbar-openstack/teams","hooks_url":"https://api.github.com/repos/jgrassler/crowbar-openstack/hooks","issue_events_url":"https://api.github.com/repos/jgrassler/crowbar-openstack/issues/events{/number}","events_url":"https://api.github.com/repos/jgrassler/crowbar-openstack/events","assignees_url":"https://api.github.com/repos/jgrassler/crowbar-openstack/assignees{/user}","branches_url":"https://api.github.com/repos/jgrassler/crowbar-openstack/branches{/branch}","tags_url":"https://api.github.com/repos/jgrassler/crowbar-openstack/tags","blobs_url":"https://api.github.com/repos/jgrassler/crowbar-openstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jgrassler/crowbar-openstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jgrassler/crowbar-openstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/jgrassler/crowbar-openstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jgrassler/crowbar-openstack/statuses/{sha}","languages_url":"https://api.github.com/repos/jgrassler/crowbar-openstack/languages","stargazers_url":"https://api.github.com/repos/jgrassler/crowbar-openstack/stargazers","contributors_url":"https://api.github.com/repos/jgrassler/crowbar-openstack/contributors","subscribers_url":"https://api.github.com/repos/jgrassler/crowbar-openstack/subscribers","subscription_url":"https://api.github.com/repos/jgrassler/crowbar-openstack/subscription","commits_url":"https://api.github.com/repos/jgrassler/crowbar-openstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/jgrassler/crowbar-openstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/jgrassler/crowbar-openstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/jgrassler/crowbar-openstack/issues/comments{/number}","contents_url":"https://api.github.com/repos/jgrassler/crowbar-openstack/contents/{+path}","compare_url":"https://api.github.com/repos/jgrassler/crowbar-openstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jgrassler/crowbar-openstack/merges","archive_url":"https://api.github.com/repos/jgrassler/crowbar-openstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jgrassler/crowbar-openstack/downloads","issues_url":"https://api.github.com/repos/jgrassler/crowbar-openstack/issues{/number}","pulls_url":"https://api.github.com/repos/jgrassler/crowbar-openstack/pulls{/number}","milestones_url":"https://api.github.com/repos/jgrassler/crowbar-openstack/milestones{/number}","notifications_url":"https://api.github.com/repos/jgrassler/crowbar-openstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jgrassler/crowbar-openstack/labels{/name}","releases_url":"https://api.github.com/repos/jgrassler/crowbar-openstack/releases{/id}","deployments_url":"https://api.github.com/repos/jgrassler/crowbar-openstack/deployments","created_at":"2016-03-17T17:05:22Z","updated_at":"2016-03-17T17:05:24Z","pushed_at":"2016-09-13T08:11:37Z","git_url":"git://github.com/jgrassler/crowbar-openstack.git","ssh_url":"git@github.com:jgrassler/crowbar-openstack.git","clone_url":"https://github.com/jgrassler/crowbar-openstack.git","svn_url":"https://github.com/jgrassler/crowbar-openstack","homepage":null,"size":17399,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"crowbar:master","ref":"master","sha":"0c5fcbce3cea82d0920bbd0141deb6aa41868ed5","user":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars.githubusercontent.com/u/2910205?v=3","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"repo":{"id":39006903,"name":"crowbar-openstack","full_name":"crowbar/crowbar-openstack","owner":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars.githubusercontent.com/u/2910205?v=3","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crowbar/crowbar-openstack","description":"Openstack deployment for Crowbar","fork":false,"url":"https://api.github.com/repos/crowbar/crowbar-openstack","forks_url":"https://api.github.com/repos/crowbar/crowbar-openstack/forks","keys_url":"https://api.github.com/repos/crowbar/crowbar-openstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crowbar/crowbar-openstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crowbar/crowbar-openstack/teams","hooks_url":"https://api.github.com/repos/crowbar/crowbar-openstack/hooks","issue_events_url":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/events{/number}","events_url":"https://api.github.com/repos/crowbar/crowbar-openstack/events","assignees_url":"https://api.github.com/repos/crowbar/crowbar-openstack/assignees{/user}","branches_url":"https://api.github.com/repos/crowbar/crowbar-openstack/branches{/branch}","tags_url":"https://api.github.com/repos/crowbar/crowbar-openstack/tags","blobs_url":"https://api.github.com/repos/crowbar/crowbar-openstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crowbar/crowbar-openstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crowbar/crowbar-openstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/crowbar/crowbar-openstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crowbar/crowbar-openstack/statuses/{sha}","languages_url":"https://api.github.com/repos/crowbar/crowbar-openstack/languages","stargazers_url":"https://api.github.com/repos/crowbar/crowbar-openstack/stargazers","contributors_url":"https://api.github.com/repos/crowbar/crowbar-openstack/contributors","subscribers_url":"https://api.github.com/repos/crowbar/crowbar-openstack/subscribers","subscription_url":"https://api.github.com/repos/crowbar/crowbar-openstack/subscription","commits_url":"https://api.github.com/repos/crowbar/crowbar-openstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/crowbar/crowbar-openstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/crowbar/crowbar-openstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/comments{/number}","contents_url":"https://api.github.com/repos/crowbar/crowbar-openstack/contents/{+path}","compare_url":"https://api.github.com/repos/crowbar/crowbar-openstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crowbar/crowbar-openstack/merges","archive_url":"https://api.github.com/repos/crowbar/crowbar-openstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crowbar/crowbar-openstack/downloads","issues_url":"https://api.github.com/repos/crowbar/crowbar-openstack/issues{/number}","pulls_url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls{/number}","milestones_url":"https://api.github.com/repos/crowbar/crowbar-openstack/milestones{/number}","notifications_url":"https://api.github.com/repos/crowbar/crowbar-openstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crowbar/crowbar-openstack/labels{/name}","releases_url":"https://api.github.com/repos/crowbar/crowbar-openstack/releases{/id}","deployments_url":"https://api.github.com/repos/crowbar/crowbar-openstack/deployments","created_at":"2015-07-13T10:55:33Z","updated_at":"2016-01-11T12:29:07Z","pushed_at":"2016-09-13T15:03:27Z","git_url":"git://github.com/crowbar/crowbar-openstack.git","ssh_url":"git@github.com:crowbar/crowbar-openstack.git","clone_url":"https://github.com/crowbar/crowbar-openstack.git","svn_url":"https://github.com/crowbar/crowbar-openstack","homepage":null,"size":18107,"stargazers_count":2,"watchers_count":2,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":35,"mirror_url":null,"open_issues_count":29,"forks":35,"open_issues":29,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/521"},"html":{"href":"https://github.com/crowbar/crowbar-openstack/pull/521"},"issue":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/521"},"comments":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/521/comments"},"review_comments":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/521/comments"},"review_comment":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/521/commits"},"statuses":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/statuses/9700382f0b662c4aa9420de7b94de0d692ffc839"}}}}
{"actor":{"display_login":"jgrassler"}}