{"action":"created","comment":{"url":"https://api.github.com/repos/apache/brooklyn-server/pulls/comments/86974177","pull_request_review_id":7603954,"id":86974177,"diff_hunk":"@@ -109,6 +130,49 @@ public Integer get() {\n         }\n     }\n \n+    private HttpRequestBase createHttpMethod(HttpMethod method, String url, Map<String, String> headers, String body) throws Exception {\n+        switch (method) {\n+            case GET:\n+                HttpTool.HttpGetBuilder httpGetBuilder = new HttpTool.HttpGetBuilder(new URI(url));","path":"test-framework/src/main/java/org/apache/brooklyn/test/framework/TestHttpCallImpl.java","position":90,"original_position":90,"commit_id":"bb683b7cd809b5f3a6a94af13d38b11325670ea5","original_commit_id":"bb683b7cd809b5f3a6a94af13d38b11325670ea5","user":{"login":"tbouron","id":2082759,"avatar_url":"https://avatars.githubusercontent.com/u/2082759?v=3","gravatar_id":"","url":"https://api.github.com/users/tbouron","html_url":"https://github.com/tbouron","followers_url":"https://api.github.com/users/tbouron/followers","following_url":"https://api.github.com/users/tbouron/following{/other_user}","gists_url":"https://api.github.com/users/tbouron/gists{/gist_id}","starred_url":"https://api.github.com/users/tbouron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbouron/subscriptions","organizations_url":"https://api.github.com/users/tbouron/orgs","repos_url":"https://api.github.com/users/tbouron/repos","events_url":"https://api.github.com/users/tbouron/events{/privacy}","received_events_url":"https://api.github.com/users/tbouron/received_events","type":"User","site_admin":false},"body":"Agree but the the `HttpTool.HttpRequestBuilder` is based on the request class which is why there is this conversion enum -> request. Do you think the `HttpMethod` and this private method `createHttpMethod` should move into `HttpTool`?","created_at":"2016-11-08T11:56:23Z","updated_at":"2016-11-08T11:56:23Z","html_url":"https://github.com/apache/brooklyn-server/pull/414#discussion_r86974177","pull_request_url":"https://api.github.com/repos/apache/brooklyn-server/pulls/414","_links":{"self":{"href":"https://api.github.com/repos/apache/brooklyn-server/pulls/comments/86974177"},"html":{"href":"https://github.com/apache/brooklyn-server/pull/414#discussion_r86974177"},"pull_request":{"href":"https://api.github.com/repos/apache/brooklyn-server/pulls/414"}}},"pull_request":{"url":"https://api.github.com/repos/apache/brooklyn-server/pulls/414","id":92741128,"html_url":"https://github.com/apache/brooklyn-server/pull/414","diff_url":"https://github.com/apache/brooklyn-server/pull/414.diff","patch_url":"https://github.com/apache/brooklyn-server/pull/414.patch","issue_url":"https://api.github.com/repos/apache/brooklyn-server/issues/414","number":414,"state":"open","locked":false,"title":"Improvement of TestHttpCall entity","user":{"login":"tbouron","id":2082759,"avatar_url":"https://avatars.githubusercontent.com/u/2082759?v=3","gravatar_id":"","url":"https://api.github.com/users/tbouron","html_url":"https://github.com/tbouron","followers_url":"https://api.github.com/users/tbouron/followers","following_url":"https://api.github.com/users/tbouron/following{/other_user}","gists_url":"https://api.github.com/users/tbouron/gists{/gist_id}","starred_url":"https://api.github.com/users/tbouron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbouron/subscriptions","organizations_url":"https://api.github.com/users/tbouron/orgs","repos_url":"https://api.github.com/users/tbouron/repos","events_url":"https://api.github.com/users/tbouron/events{/privacy}","received_events_url":"https://api.github.com/users/tbouron/received_events","type":"User","site_admin":false},"body":"This adds the possibility to:\r\n- do GET, POST, PUT, DELETE and OPTIONS requests\r\n- specify headers\r\n- specify request body for POST and PUT requests","created_at":"2016-11-08T09:23:28Z","updated_at":"2016-11-08T11:56:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"80f2e7a36a7d41c9af8fa61366e51e23a19560a1","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/brooklyn-server/pulls/414/commits","review_comments_url":"https://api.github.com/repos/apache/brooklyn-server/pulls/414/comments","review_comment_url":"https://api.github.com/repos/apache/brooklyn-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/brooklyn-server/issues/414/comments","statuses_url":"https://api.github.com/repos/apache/brooklyn-server/statuses/bb683b7cd809b5f3a6a94af13d38b11325670ea5","head":{"label":"tbouron:feature/test-http-call-methods","ref":"feature/test-http-call-methods","sha":"bb683b7cd809b5f3a6a94af13d38b11325670ea5","user":{"login":"tbouron","id":2082759,"avatar_url":"https://avatars.githubusercontent.com/u/2082759?v=3","gravatar_id":"","url":"https://api.github.com/users/tbouron","html_url":"https://github.com/tbouron","followers_url":"https://api.github.com/users/tbouron/followers","following_url":"https://api.github.com/users/tbouron/following{/other_user}","gists_url":"https://api.github.com/users/tbouron/gists{/gist_id}","starred_url":"https://api.github.com/users/tbouron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbouron/subscriptions","organizations_url":"https://api.github.com/users/tbouron/orgs","repos_url":"https://api.github.com/users/tbouron/repos","events_url":"https://api.github.com/users/tbouron/events{/privacy}","received_events_url":"https://api.github.com/users/tbouron/received_events","type":"User","site_admin":false},"repo":{"id":69347875,"name":"brooklyn-server","full_name":"tbouron/brooklyn-server","owner":{"login":"tbouron","id":2082759,"avatar_url":"https://avatars.githubusercontent.com/u/2082759?v=3","gravatar_id":"","url":"https://api.github.com/users/tbouron","html_url":"https://github.com/tbouron","followers_url":"https://api.github.com/users/tbouron/followers","following_url":"https://api.github.com/users/tbouron/following{/other_user}","gists_url":"https://api.github.com/users/tbouron/gists{/gist_id}","starred_url":"https://api.github.com/users/tbouron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbouron/subscriptions","organizations_url":"https://api.github.com/users/tbouron/orgs","repos_url":"https://api.github.com/users/tbouron/repos","events_url":"https://api.github.com/users/tbouron/events{/privacy}","received_events_url":"https://api.github.com/users/tbouron/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tbouron/brooklyn-server","description":"Mirror of Apache Brooklyn server","fork":true,"url":"https://api.github.com/repos/tbouron/brooklyn-server","forks_url":"https://api.github.com/repos/tbouron/brooklyn-server/forks","keys_url":"https://api.github.com/repos/tbouron/brooklyn-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tbouron/brooklyn-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tbouron/brooklyn-server/teams","hooks_url":"https://api.github.com/repos/tbouron/brooklyn-server/hooks","issue_events_url":"https://api.github.com/repos/tbouron/brooklyn-server/issues/events{/number}","events_url":"https://api.github.com/repos/tbouron/brooklyn-server/events","assignees_url":"https://api.github.com/repos/tbouron/brooklyn-server/assignees{/user}","branches_url":"https://api.github.com/repos/tbouron/brooklyn-server/branches{/branch}","tags_url":"https://api.github.com/repos/tbouron/brooklyn-server/tags","blobs_url":"https://api.github.com/repos/tbouron/brooklyn-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tbouron/brooklyn-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tbouron/brooklyn-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/tbouron/brooklyn-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tbouron/brooklyn-server/statuses/{sha}","languages_url":"https://api.github.com/repos/tbouron/brooklyn-server/languages","stargazers_url":"https://api.github.com/repos/tbouron/brooklyn-server/stargazers","contributors_url":"https://api.github.com/repos/tbouron/brooklyn-server/contributors","subscribers_url":"https://api.github.com/repos/tbouron/brooklyn-server/subscribers","subscription_url":"https://api.github.com/repos/tbouron/brooklyn-server/subscription","commits_url":"https://api.github.com/repos/tbouron/brooklyn-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/tbouron/brooklyn-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/tbouron/brooklyn-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/tbouron/brooklyn-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/tbouron/brooklyn-server/contents/{+path}","compare_url":"https://api.github.com/repos/tbouron/brooklyn-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tbouron/brooklyn-server/merges","archive_url":"https://api.github.com/repos/tbouron/brooklyn-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tbouron/brooklyn-server/downloads","issues_url":"https://api.github.com/repos/tbouron/brooklyn-server/issues{/number}","pulls_url":"https://api.github.com/repos/tbouron/brooklyn-server/pulls{/number}","milestones_url":"https://api.github.com/repos/tbouron/brooklyn-server/milestones{/number}","notifications_url":"https://api.github.com/repos/tbouron/brooklyn-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tbouron/brooklyn-server/labels{/name}","releases_url":"https://api.github.com/repos/tbouron/brooklyn-server/releases{/id}","deployments_url":"https://api.github.com/repos/tbouron/brooklyn-server/deployments","created_at":"2016-09-27T11:02:43Z","updated_at":"2016-09-27T11:02:53Z","pushed_at":"2016-11-08T09:21:25Z","git_url":"git://github.com/tbouron/brooklyn-server.git","ssh_url":"git@github.com:tbouron/brooklyn-server.git","clone_url":"https://github.com/tbouron/brooklyn-server.git","svn_url":"https://github.com/tbouron/brooklyn-server","homepage":null,"size":31616,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"e56de02d29fe63b74f2627d18a8c73093d06c85f","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":47246081,"name":"brooklyn-server","full_name":"apache/brooklyn-server","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/brooklyn-server","description":"Mirror of Apache Brooklyn server","fork":false,"url":"https://api.github.com/repos/apache/brooklyn-server","forks_url":"https://api.github.com/repos/apache/brooklyn-server/forks","keys_url":"https://api.github.com/repos/apache/brooklyn-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/brooklyn-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/brooklyn-server/teams","hooks_url":"https://api.github.com/repos/apache/brooklyn-server/hooks","issue_events_url":"https://api.github.com/repos/apache/brooklyn-server/issues/events{/number}","events_url":"https://api.github.com/repos/apache/brooklyn-server/events","assignees_url":"https://api.github.com/repos/apache/brooklyn-server/assignees{/user}","branches_url":"https://api.github.com/repos/apache/brooklyn-server/branches{/branch}","tags_url":"https://api.github.com/repos/apache/brooklyn-server/tags","blobs_url":"https://api.github.com/repos/apache/brooklyn-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/brooklyn-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/brooklyn-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/brooklyn-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/brooklyn-server/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/brooklyn-server/languages","stargazers_url":"https://api.github.com/repos/apache/brooklyn-server/stargazers","contributors_url":"https://api.github.com/repos/apache/brooklyn-server/contributors","subscribers_url":"https://api.github.com/repos/apache/brooklyn-server/subscribers","subscription_url":"https://api.github.com/repos/apache/brooklyn-server/subscription","commits_url":"https://api.github.com/repos/apache/brooklyn-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/brooklyn-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/brooklyn-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/brooklyn-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/brooklyn-server/contents/{+path}","compare_url":"https://api.github.com/repos/apache/brooklyn-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/brooklyn-server/merges","archive_url":"https://api.github.com/repos/apache/brooklyn-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/brooklyn-server/downloads","issues_url":"https://api.github.com/repos/apache/brooklyn-server/issues{/number}","pulls_url":"https://api.github.com/repos/apache/brooklyn-server/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/brooklyn-server/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/brooklyn-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/brooklyn-server/labels{/name}","releases_url":"https://api.github.com/repos/apache/brooklyn-server/releases{/id}","deployments_url":"https://api.github.com/repos/apache/brooklyn-server/deployments","created_at":"2015-12-02T08:00:06Z","updated_at":"2016-11-01T11:09:27Z","pushed_at":"2016-11-08T11:26:39Z","git_url":"git://github.com/apache/brooklyn-server.git","ssh_url":"git@github.com:apache/brooklyn-server.git","clone_url":"https://github.com/apache/brooklyn-server.git","svn_url":"https://github.com/apache/brooklyn-server","homepage":null,"size":32544,"stargazers_count":13,"watchers_count":13,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":38,"mirror_url":"git://git.apache.org/brooklyn-server.git","open_issues_count":23,"forks":38,"open_issues":23,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/brooklyn-server/pulls/414"},"html":{"href":"https://github.com/apache/brooklyn-server/pull/414"},"issue":{"href":"https://api.github.com/repos/apache/brooklyn-server/issues/414"},"comments":{"href":"https://api.github.com/repos/apache/brooklyn-server/issues/414/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/brooklyn-server/pulls/414/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/brooklyn-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/brooklyn-server/pulls/414/commits"},"statuses":{"href":"https://api.github.com/repos/apache/brooklyn-server/statuses/bb683b7cd809b5f3a6a94af13d38b11325670ea5"}}}}
{"actor":{"display_login":"tbouron"}}