{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/35647","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/35647/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/35647/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/35647/events","html_url":"https://github.com/kubernetes/kubernetes/pull/35647","id":185490151,"number":35647,"title":"Fix strategic patch for list of primitive type with merge sementic","user":{"login":"ymqytw","id":2589105,"avatar_url":"https://avatars.githubusercontent.com/u/2589105?v=3","gravatar_id":"","url":"https://api.github.com/users/ymqytw","html_url":"https://github.com/ymqytw","followers_url":"https://api.github.com/users/ymqytw/followers","following_url":"https://api.github.com/users/ymqytw/following{/other_user}","gists_url":"https://api.github.com/users/ymqytw/gists{/gist_id}","starred_url":"https://api.github.com/users/ymqytw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ymqytw/subscriptions","organizations_url":"https://api.github.com/users/ymqytw/orgs","repos_url":"https://api.github.com/users/ymqytw/repos","events_url":"https://api.github.com/users/ymqytw/events{/privacy}","received_events_url":"https://api.github.com/users/ymqytw/received_events","type":"User","site_admin":false},"labels":[{"id":176978828,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cla:%20yes","name":"cla: yes","color":"bfe5bf","default":false},{"id":148225179,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/lgtm","name":"lgtm","color":"15dd18","default":false},{"id":200149833,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note","name":"release-note","color":"c2e0c6","default":false},{"id":253451093,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/XXL","name":"size/XXL","color":"ee0000","default":false}],"state":"closed","locked":false,"assignee":{"login":"fabianofranz","id":158611,"avatar_url":"https://avatars.githubusercontent.com/u/158611?v=3","gravatar_id":"","url":"https://api.github.com/users/fabianofranz","html_url":"https://github.com/fabianofranz","followers_url":"https://api.github.com/users/fabianofranz/followers","following_url":"https://api.github.com/users/fabianofranz/following{/other_user}","gists_url":"https://api.github.com/users/fabianofranz/gists{/gist_id}","starred_url":"https://api.github.com/users/fabianofranz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabianofranz/subscriptions","organizations_url":"https://api.github.com/users/fabianofranz/orgs","repos_url":"https://api.github.com/users/fabianofranz/repos","events_url":"https://api.github.com/users/fabianofranz/events{/privacy}","received_events_url":"https://api.github.com/users/fabianofranz/received_events","type":"User","site_admin":false},"assignees":[{"login":"fabianofranz","id":158611,"avatar_url":"https://avatars.githubusercontent.com/u/158611?v=3","gravatar_id":"","url":"https://api.github.com/users/fabianofranz","html_url":"https://github.com/fabianofranz","followers_url":"https://api.github.com/users/fabianofranz/followers","following_url":"https://api.github.com/users/fabianofranz/following{/other_user}","gists_url":"https://api.github.com/users/fabianofranz/gists{/gist_id}","starred_url":"https://api.github.com/users/fabianofranz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabianofranz/subscriptions","organizations_url":"https://api.github.com/users/fabianofranz/orgs","repos_url":"https://api.github.com/users/fabianofranz/repos","events_url":"https://api.github.com/users/fabianofranz/events{/privacy}","received_events_url":"https://api.github.com/users/fabianofranz/received_events","type":"User","site_admin":false},{"login":"AdoHe","id":1555564,"avatar_url":"https://avatars.githubusercontent.com/u/1555564?v=3","gravatar_id":"","url":"https://api.github.com/users/AdoHe","html_url":"https://github.com/AdoHe","followers_url":"https://api.github.com/users/AdoHe/followers","following_url":"https://api.github.com/users/AdoHe/following{/other_user}","gists_url":"https://api.github.com/users/AdoHe/gists{/gist_id}","starred_url":"https://api.github.com/users/AdoHe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AdoHe/subscriptions","organizations_url":"https://api.github.com/users/AdoHe/orgs","repos_url":"https://api.github.com/users/AdoHe/repos","events_url":"https://api.github.com/users/AdoHe/events{/privacy}","received_events_url":"https://api.github.com/users/AdoHe/received_events","type":"User","site_admin":false},{"login":"caesarxuchao","id":2823529,"avatar_url":"https://avatars.githubusercontent.com/u/2823529?v=3","gravatar_id":"","url":"https://api.github.com/users/caesarxuchao","html_url":"https://github.com/caesarxuchao","followers_url":"https://api.github.com/users/caesarxuchao/followers","following_url":"https://api.github.com/users/caesarxuchao/following{/other_user}","gists_url":"https://api.github.com/users/caesarxuchao/gists{/gist_id}","starred_url":"https://api.github.com/users/caesarxuchao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caesarxuchao/subscriptions","organizations_url":"https://api.github.com/users/caesarxuchao/orgs","repos_url":"https://api.github.com/users/caesarxuchao/repos","events_url":"https://api.github.com/users/caesarxuchao/events{/privacy}","received_events_url":"https://api.github.com/users/caesarxuchao/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/23","html_url":"https://github.com/kubernetes/kubernetes/milestones/v1.5","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/23/labels","id":1945978,"number":23,"title":"v1.5","description":"","creator":{"login":"lavalamp","id":647318,"avatar_url":"https://avatars.githubusercontent.com/u/647318?v=3","gravatar_id":"","url":"https://api.github.com/users/lavalamp","html_url":"https://github.com/lavalamp","followers_url":"https://api.github.com/users/lavalamp/followers","following_url":"https://api.github.com/users/lavalamp/following{/other_user}","gists_url":"https://api.github.com/users/lavalamp/gists{/gist_id}","starred_url":"https://api.github.com/users/lavalamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lavalamp/subscriptions","organizations_url":"https://api.github.com/users/lavalamp/orgs","repos_url":"https://api.github.com/users/lavalamp/repos","events_url":"https://api.github.com/users/lavalamp/events{/privacy}","received_events_url":"https://api.github.com/users/lavalamp/received_events","type":"User","site_admin":false},"open_issues":130,"closed_issues":817,"state":"open","created_at":"2016-08-16T21:47:28Z","updated_at":"2016-11-22T19:25:23Z","due_on":"2016-12-09T00:00:00Z","closed_at":null},"comments":63,"created_at":"2016-10-26T19:40:21Z","updated_at":"2016-11-22T19:33:48Z","closed_at":"2016-11-11T22:36:44Z","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/35647","html_url":"https://github.com/kubernetes/kubernetes/pull/35647","diff_url":"https://github.com/kubernetes/kubernetes/pull/35647.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/35647.patch"},"body":"Fix strategic patch for list of primitive type when the patch strategy is `merge`.\r\nBefore: we cannot replace or delete an item in a list of primitive, e.g. string, when the patch strategy is `merge`. It will always append new items to the list.\r\nThis patch will generate a map to update the list of primitive type.\r\nThe server with this patch will accept either a new patch or an old patch.\r\nThe client will found out the APIserver version before generate the patch.\r\n\r\nFixes #35163, #32398\r\n\r\ncc: @pwittrock @fabianofranz \r\n\r\n``` release-note\r\nFix strategic patch for list of primitive type when patch strategy is `merge` to remove deleted objects.\r\n```\r\n\r\n<!-- Reviewable:start -->\r\n\r\n---\r\n\r\nThis change is [<img src=\"https://reviewable.kubernetes.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.kubernetes.io/reviews/kubernetes/kubernetes/35647)\r\n\r\n<!-- Reviewable:end -->\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/262341768","html_url":"https://github.com/kubernetes/kubernetes/pull/35647#issuecomment-262341768","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/35647","id":262341768,"user":{"login":"ymqytw","id":2589105,"avatar_url":"https://avatars.githubusercontent.com/u/2589105?v=3","gravatar_id":"","url":"https://api.github.com/users/ymqytw","html_url":"https://github.com/ymqytw","followers_url":"https://api.github.com/users/ymqytw/followers","following_url":"https://api.github.com/users/ymqytw/following{/other_user}","gists_url":"https://api.github.com/users/ymqytw/gists{/gist_id}","starred_url":"https://api.github.com/users/ymqytw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ymqytw/subscriptions","organizations_url":"https://api.github.com/users/ymqytw/orgs","repos_url":"https://api.github.com/users/ymqytw/repos","events_url":"https://api.github.com/users/ymqytw/events{/privacy}","received_events_url":"https://api.github.com/users/ymqytw/received_events","type":"User","site_admin":false},"created_at":"2016-11-22T19:33:48Z","updated_at":"2016-11-22T19:33:48Z","body":"> I don't think it's valid to base any functionality on the release version.\r\n\r\n@bgrant0607 This part has been removed in #36916. In that PR, we change the behavior to:\r\nfirst try the new patch, if it fails because the server don't recognize it, it will try the old patch."}}
{"actor":{"display_login":"ymqytw"}}