{"action":"created","comment":{"url":"https://api.github.com/repos/bwinton/TabCenter/pulls/comments/76673855","id":76673855,"diff_hunk":"@@ -497,6 +497,31 @@ VerticalTabs.prototype = {\n       }\n     });\n \n+    let oldUpdateToolbars = window.FullScreen._updateToolbars;\n+    window.FullScreen._updateToolbars = (aEnterFS) => {\n+      oldUpdateToolbars.bind(window.FullScreen)(aEnterFS);\n+      let fullscreenctls = document.getElementById('window-controls');\n+      let navbar = document.getElementById('nav-bar');\n+      let toggler = document.getElementById('fullscr-toggler');\n+      let sibling = document.getElementById('navigator-toolbox').nextSibling;\n+\n+      if (aEnterFS && fullscreenctls.parentNode.id === 'TabsToolbar') {\n+        navbar.appendChild('fullscreenctls');\n+        toggler.removeAttribute('hidden');\n+        window.gNavToolbox.style.marginTop = (-window.gNavToolbox.getBoundingClientRect().height - 1) + 'px';\n+        document.getElementById('appcontent').insertBefore(toggler, sibling);\n+      }\n+    };\n+\n+    //hidden nav toolbox needs to be moved 1 pix higher to account for the toggler every time it hides\n+    let oldHideNavToolbox = window.FullScreen.hideNavToolbox;\n+    window.FullScreen.hideNavToolbox = (aAnimate = false) => {\n+      oldHideNavToolbox.bind(window.FullScreen)(aAnimate);\n+      let toggler = document.getElementById('fullscr-toggler');\n+      toggler.removeAttribute('hidden');\n+      window.gNavToolbox.style.marginTop = (-window.gNavToolbox.getBoundingClientRect().height - 1) + 'px';\n+    };","path":"verticaltabs.js","position":27,"original_position":27,"commit_id":"3c31e4b6882560325cb06c9efa5756f9a3731b4d","original_commit_id":"ca49a1c60b566ca936a766786c47b55adef6041a","user":{"login":"ericawright","id":10803178,"avatar_url":"https://avatars.githubusercontent.com/u/10803178?v=3","gravatar_id":"","url":"https://api.github.com/users/ericawright","html_url":"https://github.com/ericawright","followers_url":"https://api.github.com/users/ericawright/followers","following_url":"https://api.github.com/users/ericawright/following{/other_user}","gists_url":"https://api.github.com/users/ericawright/gists{/gist_id}","starred_url":"https://api.github.com/users/ericawright/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericawright/subscriptions","organizations_url":"https://api.github.com/users/ericawright/orgs","repos_url":"https://api.github.com/users/ericawright/repos","events_url":"https://api.github.com/users/ericawright/events{/privacy}","received_events_url":"https://api.github.com/users/ericawright/received_events","type":"User","site_admin":false},"body":"yeah, I need to do this though... so should I wait till your\r\n![screen shot 2016-08-29 at 12 46 39 pm](https://cloud.githubusercontent.com/assets/10803178/18064965/b3bf722e-6de6-11e6-9e19-afc06a84677f.png)\r\ns is finished first?","created_at":"2016-08-29T19:47:12Z","updated_at":"2016-08-29T19:47:12Z","html_url":"https://github.com/bwinton/TabCenter/pull/595#discussion_r76673855","pull_request_url":"https://api.github.com/repos/bwinton/TabCenter/pulls/595","_links":{"self":{"href":"https://api.github.com/repos/bwinton/TabCenter/pulls/comments/76673855"},"html":{"href":"https://github.com/bwinton/TabCenter/pull/595#discussion_r76673855"},"pull_request":{"href":"https://api.github.com/repos/bwinton/TabCenter/pulls/595"}}},"pull_request":{"url":"https://api.github.com/repos/bwinton/TabCenter/pulls/595","id":83026056,"html_url":"https://github.com/bwinton/TabCenter/pull/595","diff_url":"https://github.com/bwinton/TabCenter/pull/595.diff","patch_url":"https://github.com/bwinton/TabCenter/pull/595.patch","issue_url":"https://api.github.com/repos/bwinton/TabCenter/issues/595","number":595,"state":"open","locked":false,"title":"Fix: window controls in fullscreen","user":{"login":"ericawright","id":10803178,"avatar_url":"https://avatars.githubusercontent.com/u/10803178?v=3","gravatar_id":"","url":"https://api.github.com/users/ericawright","html_url":"https://github.com/ericawright","followers_url":"https://api.github.com/users/ericawright/followers","following_url":"https://api.github.com/users/ericawright/following{/other_user}","gists_url":"https://api.github.com/users/ericawright/gists{/gist_id}","starred_url":"https://api.github.com/users/ericawright/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericawright/subscriptions","organizations_url":"https://api.github.com/users/ericawright/orgs","repos_url":"https://api.github.com/users/ericawright/repos","events_url":"https://api.github.com/users/ericawright/events{/privacy}","received_events_url":"https://api.github.com/users/ericawright/received_events","type":"User","site_admin":false},"body":"@bwinton \r\n\r\nHide the window controls if they were moved to the TabsToolbar. \r\nMove the fullscr-toggler to be above the main window, instead of above tab center\r\n\r\nnotes: currently adding window controls to the #nav-bar. would like to add to the #titlebar but it will not work with the slide in out/toggle on mousing up.\r\n\r\nFixes: #509.","created_at":"2016-08-28T20:24:26Z","updated_at":"2016-08-29T19:47:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4079d56cb55fc21e3c5d3fd87bfc3bddb106b4bb","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/bwinton/TabCenter/pulls/595/commits","review_comments_url":"https://api.github.com/repos/bwinton/TabCenter/pulls/595/comments","review_comment_url":"https://api.github.com/repos/bwinton/TabCenter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bwinton/TabCenter/issues/595/comments","statuses_url":"https://api.github.com/repos/bwinton/TabCenter/statuses/3c31e4b6882560325cb06c9efa5756f9a3731b4d","head":{"label":"ericawright:window-controls","ref":"window-controls","sha":"3c31e4b6882560325cb06c9efa5756f9a3731b4d","user":{"login":"ericawright","id":10803178,"avatar_url":"https://avatars.githubusercontent.com/u/10803178?v=3","gravatar_id":"","url":"https://api.github.com/users/ericawright","html_url":"https://github.com/ericawright","followers_url":"https://api.github.com/users/ericawright/followers","following_url":"https://api.github.com/users/ericawright/following{/other_user}","gists_url":"https://api.github.com/users/ericawright/gists{/gist_id}","starred_url":"https://api.github.com/users/ericawright/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericawright/subscriptions","organizations_url":"https://api.github.com/users/ericawright/orgs","repos_url":"https://api.github.com/users/ericawright/repos","events_url":"https://api.github.com/users/ericawright/events{/privacy}","received_events_url":"https://api.github.com/users/ericawright/received_events","type":"User","site_admin":false},"repo":{"id":58400156,"name":"VerticalTabs","full_name":"ericawright/VerticalTabs","owner":{"login":"ericawright","id":10803178,"avatar_url":"https://avatars.githubusercontent.com/u/10803178?v=3","gravatar_id":"","url":"https://api.github.com/users/ericawright","html_url":"https://github.com/ericawright","followers_url":"https://api.github.com/users/ericawright/followers","following_url":"https://api.github.com/users/ericawright/following{/other_user}","gists_url":"https://api.github.com/users/ericawright/gists{/gist_id}","starred_url":"https://api.github.com/users/ericawright/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericawright/subscriptions","organizations_url":"https://api.github.com/users/ericawright/orgs","repos_url":"https://api.github.com/users/ericawright/repos","events_url":"https://api.github.com/users/ericawright/events{/privacy}","received_events_url":"https://api.github.com/users/ericawright/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ericawright/VerticalTabs","description":"Firefox add-on for arranging tabs vertically","fork":true,"url":"https://api.github.com/repos/ericawright/VerticalTabs","forks_url":"https://api.github.com/repos/ericawright/VerticalTabs/forks","keys_url":"https://api.github.com/repos/ericawright/VerticalTabs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ericawright/VerticalTabs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ericawright/VerticalTabs/teams","hooks_url":"https://api.github.com/repos/ericawright/VerticalTabs/hooks","issue_events_url":"https://api.github.com/repos/ericawright/VerticalTabs/issues/events{/number}","events_url":"https://api.github.com/repos/ericawright/VerticalTabs/events","assignees_url":"https://api.github.com/repos/ericawright/VerticalTabs/assignees{/user}","branches_url":"https://api.github.com/repos/ericawright/VerticalTabs/branches{/branch}","tags_url":"https://api.github.com/repos/ericawright/VerticalTabs/tags","blobs_url":"https://api.github.com/repos/ericawright/VerticalTabs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ericawright/VerticalTabs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ericawright/VerticalTabs/git/refs{/sha}","trees_url":"https://api.github.com/repos/ericawright/VerticalTabs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ericawright/VerticalTabs/statuses/{sha}","languages_url":"https://api.github.com/repos/ericawright/VerticalTabs/languages","stargazers_url":"https://api.github.com/repos/ericawright/VerticalTabs/stargazers","contributors_url":"https://api.github.com/repos/ericawright/VerticalTabs/contributors","subscribers_url":"https://api.github.com/repos/ericawright/VerticalTabs/subscribers","subscription_url":"https://api.github.com/repos/ericawright/VerticalTabs/subscription","commits_url":"https://api.github.com/repos/ericawright/VerticalTabs/commits{/sha}","git_commits_url":"https://api.github.com/repos/ericawright/VerticalTabs/git/commits{/sha}","comments_url":"https://api.github.com/repos/ericawright/VerticalTabs/comments{/number}","issue_comment_url":"https://api.github.com/repos/ericawright/VerticalTabs/issues/comments{/number}","contents_url":"https://api.github.com/repos/ericawright/VerticalTabs/contents/{+path}","compare_url":"https://api.github.com/repos/ericawright/VerticalTabs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ericawright/VerticalTabs/merges","archive_url":"https://api.github.com/repos/ericawright/VerticalTabs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ericawright/VerticalTabs/downloads","issues_url":"https://api.github.com/repos/ericawright/VerticalTabs/issues{/number}","pulls_url":"https://api.github.com/repos/ericawright/VerticalTabs/pulls{/number}","milestones_url":"https://api.github.com/repos/ericawright/VerticalTabs/milestones{/number}","notifications_url":"https://api.github.com/repos/ericawright/VerticalTabs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ericawright/VerticalTabs/labels{/name}","releases_url":"https://api.github.com/repos/ericawright/VerticalTabs/releases{/id}","deployments_url":"https://api.github.com/repos/ericawright/VerticalTabs/deployments","created_at":"2016-05-09T18:50:39Z","updated_at":"2016-05-09T18:50:41Z","pushed_at":"2016-08-29T16:20:11Z","git_url":"git://github.com/ericawright/VerticalTabs.git","ssh_url":"git@github.com:ericawright/VerticalTabs.git","clone_url":"https://github.com/ericawright/VerticalTabs.git","svn_url":"https://github.com/ericawright/VerticalTabs","homepage":"https://addons.mozilla.org/firefox/addon/108862/","size":2795,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bwinton:master","ref":"master","sha":"f6c27d9a3dff000dd0f8bebd969af02d45be3563","user":{"login":"bwinton","id":159571,"avatar_url":"https://avatars.githubusercontent.com/u/159571?v=3","gravatar_id":"","url":"https://api.github.com/users/bwinton","html_url":"https://github.com/bwinton","followers_url":"https://api.github.com/users/bwinton/followers","following_url":"https://api.github.com/users/bwinton/following{/other_user}","gists_url":"https://api.github.com/users/bwinton/gists{/gist_id}","starred_url":"https://api.github.com/users/bwinton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bwinton/subscriptions","organizations_url":"https://api.github.com/users/bwinton/orgs","repos_url":"https://api.github.com/users/bwinton/repos","events_url":"https://api.github.com/users/bwinton/events{/privacy}","received_events_url":"https://api.github.com/users/bwinton/received_events","type":"User","site_admin":false},"repo":{"id":21625093,"name":"TabCenter","full_name":"bwinton/TabCenter","owner":{"login":"bwinton","id":159571,"avatar_url":"https://avatars.githubusercontent.com/u/159571?v=3","gravatar_id":"","url":"https://api.github.com/users/bwinton","html_url":"https://github.com/bwinton","followers_url":"https://api.github.com/users/bwinton/followers","following_url":"https://api.github.com/users/bwinton/following{/other_user}","gists_url":"https://api.github.com/users/bwinton/gists{/gist_id}","starred_url":"https://api.github.com/users/bwinton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bwinton/subscriptions","organizations_url":"https://api.github.com/users/bwinton/orgs","repos_url":"https://api.github.com/users/bwinton/repos","events_url":"https://api.github.com/users/bwinton/events{/privacy}","received_events_url":"https://api.github.com/users/bwinton/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bwinton/TabCenter","description":"Firefox add-on for arranging tabs vertically","fork":false,"url":"https://api.github.com/repos/bwinton/TabCenter","forks_url":"https://api.github.com/repos/bwinton/TabCenter/forks","keys_url":"https://api.github.com/repos/bwinton/TabCenter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bwinton/TabCenter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bwinton/TabCenter/teams","hooks_url":"https://api.github.com/repos/bwinton/TabCenter/hooks","issue_events_url":"https://api.github.com/repos/bwinton/TabCenter/issues/events{/number}","events_url":"https://api.github.com/repos/bwinton/TabCenter/events","assignees_url":"https://api.github.com/repos/bwinton/TabCenter/assignees{/user}","branches_url":"https://api.github.com/repos/bwinton/TabCenter/branches{/branch}","tags_url":"https://api.github.com/repos/bwinton/TabCenter/tags","blobs_url":"https://api.github.com/repos/bwinton/TabCenter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bwinton/TabCenter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bwinton/TabCenter/git/refs{/sha}","trees_url":"https://api.github.com/repos/bwinton/TabCenter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bwinton/TabCenter/statuses/{sha}","languages_url":"https://api.github.com/repos/bwinton/TabCenter/languages","stargazers_url":"https://api.github.com/repos/bwinton/TabCenter/stargazers","contributors_url":"https://api.github.com/repos/bwinton/TabCenter/contributors","subscribers_url":"https://api.github.com/repos/bwinton/TabCenter/subscribers","subscription_url":"https://api.github.com/repos/bwinton/TabCenter/subscription","commits_url":"https://api.github.com/repos/bwinton/TabCenter/commits{/sha}","git_commits_url":"https://api.github.com/repos/bwinton/TabCenter/git/commits{/sha}","comments_url":"https://api.github.com/repos/bwinton/TabCenter/comments{/number}","issue_comment_url":"https://api.github.com/repos/bwinton/TabCenter/issues/comments{/number}","contents_url":"https://api.github.com/repos/bwinton/TabCenter/contents/{+path}","compare_url":"https://api.github.com/repos/bwinton/TabCenter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bwinton/TabCenter/merges","archive_url":"https://api.github.com/repos/bwinton/TabCenter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bwinton/TabCenter/downloads","issues_url":"https://api.github.com/repos/bwinton/TabCenter/issues{/number}","pulls_url":"https://api.github.com/repos/bwinton/TabCenter/pulls{/number}","milestones_url":"https://api.github.com/repos/bwinton/TabCenter/milestones{/number}","notifications_url":"https://api.github.com/repos/bwinton/TabCenter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bwinton/TabCenter/labels{/name}","releases_url":"https://api.github.com/repos/bwinton/TabCenter/releases{/id}","deployments_url":"https://api.github.com/repos/bwinton/TabCenter/deployments","created_at":"2014-07-08T18:37:28Z","updated_at":"2016-08-28T02:11:25Z","pushed_at":"2016-08-29T16:20:11Z","git_url":"git://github.com/bwinton/TabCenter.git","ssh_url":"git@github.com:bwinton/TabCenter.git","clone_url":"https://github.com/bwinton/TabCenter.git","svn_url":"https://github.com/bwinton/TabCenter","homepage":"https://testpilot.firefox.com/experiments/tab-center","size":2845,"stargazers_count":83,"watchers_count":83,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"open_issues_count":82,"forks":26,"open_issues":82,"watchers":83,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bwinton/TabCenter/pulls/595"},"html":{"href":"https://github.com/bwinton/TabCenter/pull/595"},"issue":{"href":"https://api.github.com/repos/bwinton/TabCenter/issues/595"},"comments":{"href":"https://api.github.com/repos/bwinton/TabCenter/issues/595/comments"},"review_comments":{"href":"https://api.github.com/repos/bwinton/TabCenter/pulls/595/comments"},"review_comment":{"href":"https://api.github.com/repos/bwinton/TabCenter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bwinton/TabCenter/pulls/595/commits"},"statuses":{"href":"https://api.github.com/repos/bwinton/TabCenter/statuses/3c31e4b6882560325cb06c9efa5756f9a3731b4d"}}}}
{"actor":{"display_login":"ericawright"}}