{"action":"created","issue":{"url":"https://api.github.com/repos/ehcache/ehcache3/issues/837","repository_url":"https://api.github.com/repos/ehcache/ehcache3","labels_url":"https://api.github.com/repos/ehcache/ehcache3/issues/837/labels{/name}","comments_url":"https://api.github.com/repos/ehcache/ehcache3/issues/837/comments","events_url":"https://api.github.com/repos/ehcache/ehcache3/issues/837/events","html_url":"https://github.com/ehcache/ehcache3/issues/837","id":139956168,"number":837,"title":"Revisit contract between ClassInstanceProvider and Closeable things","user":{"login":"ljacomet","id":135308,"avatar_url":"https://avatars.githubusercontent.com/u/135308?v=3","gravatar_id":"","url":"https://api.github.com/users/ljacomet","html_url":"https://github.com/ljacomet","followers_url":"https://api.github.com/users/ljacomet/followers","following_url":"https://api.github.com/users/ljacomet/following{/other_user}","gists_url":"https://api.github.com/users/ljacomet/gists{/gist_id}","starred_url":"https://api.github.com/users/ljacomet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ljacomet/subscriptions","organizations_url":"https://api.github.com/users/ljacomet/orgs","repos_url":"https://api.github.com/users/ljacomet/repos","events_url":"https://api.github.com/users/ljacomet/events{/privacy}","received_events_url":"https://api.github.com/users/ljacomet/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ehcache/ehcache3/labels/api","name":"api","color":"006b75"},{"url":"https://api.github.com/repos/ehcache/ehcache3/labels/question","name":"question","color":"cc317c"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-03-10T17:18:53Z","updated_at":"2016-03-16T21:39:46Z","closed_at":null,"body":"After discussions with @cljohnso, @chrisdennis and @lorban there is some thought that the contract with regards to user provided instances needs to be revised.\r\n\r\nCurrently anything that implements `Closeable` will be closed when released. Suggestion is to not do that for things that were provided as instances and limit it to things that were constructed by provider."},"comment":{"url":"https://api.github.com/repos/ehcache/ehcache3/issues/comments/197559529","html_url":"https://github.com/ehcache/ehcache3/issues/837#issuecomment-197559529","issue_url":"https://api.github.com/repos/ehcache/ehcache3/issues/837","id":197559529,"user":{"login":"ljacomet","id":135308,"avatar_url":"https://avatars.githubusercontent.com/u/135308?v=3","gravatar_id":"","url":"https://api.github.com/users/ljacomet","html_url":"https://github.com/ljacomet","followers_url":"https://api.github.com/users/ljacomet/followers","following_url":"https://api.github.com/users/ljacomet/following{/other_user}","gists_url":"https://api.github.com/users/ljacomet/gists{/gist_id}","starred_url":"https://api.github.com/users/ljacomet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ljacomet/subscriptions","organizations_url":"https://api.github.com/users/ljacomet/orgs","repos_url":"https://api.github.com/users/ljacomet/repos","events_url":"https://api.github.com/users/ljacomet/events{/privacy}","received_events_url":"https://api.github.com/users/ljacomet/received_events","type":"User","site_admin":false},"created_at":"2016-03-16T21:39:46Z","updated_at":"2016-03-16T21:39:46Z","body":"From discussion during the (dev meeting of March 15th](https://www.youtube.com/watch?v=ROiD7zPLqfk), we agreed that while we maintain the `Closeable` will be closed contract, it will be limited to instances constructed by the `ClassInstanceProvider` or equivalent. When the user provides us with his own instance, we will not perform that invocation at all."}}