{"action":"created","issue":{"url":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/issues/155","repository_url":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql","labels_url":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/issues/155/labels{/name}","comments_url":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/issues/155/comments","events_url":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/issues/155/events","html_url":"https://github.com/mozilla/fxa-auth-db-mysql/pull/155","id":169843971,"number":155,"title":"feat(db): Record whether unverified tokens wanted keys.","user":{"login":"rfk","id":34695,"avatar_url":"https://avatars.githubusercontent.com/u/34695?v=3","gravatar_id":"","url":"https://api.github.com/users/rfk","html_url":"https://github.com/rfk","followers_url":"https://api.github.com/users/rfk/followers","following_url":"https://api.github.com/users/rfk/following{/other_user}","gists_url":"https://api.github.com/users/rfk/gists{/gist_id}","starred_url":"https://api.github.com/users/rfk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rfk/subscriptions","organizations_url":"https://api.github.com/users/rfk/orgs","repos_url":"https://api.github.com/users/rfk/repos","events_url":"https://api.github.com/users/rfk/events{/privacy}","received_events_url":"https://api.github.com/users/rfk/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/labels/waffle:active","name":"waffle:active","color":"ededed"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-08-08T05:04:38Z","updated_at":"2016-08-08T06:20:19Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/pulls/155","html_url":"https://github.com/mozilla/fxa-auth-db-mysql/pull/155","diff_url":"https://github.com/mozilla/fxa-auth-db-mysql/pull/155.diff","patch_url":"https://github.com/mozilla/fxa-auth-db-mysql/pull/155.patch"},"body":"Fixes #151.\r\n\r\n@pb @vbudhram here's my sketch for how we might explicitly track whether an unverified sessionToken wanted keys or not.  It will require a corresponding change in the auth-server to send over the new state, which I've added in https://github.com/mozilla/fxa-auth-server/pull/1376.  In particular, see here for how I think we'd want to use it:\r\n\r\n  https://github.com/mozilla/fxa-auth-server/pull/1376/files#diff-ab87c506e682e952973178a41792df12R1158\r\n\r\nDoes this seem like a reasonable path forward?"},"comment":{"url":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/issues/comments/238150706","html_url":"https://github.com/mozilla/fxa-auth-db-mysql/pull/155#issuecomment-238150706","issue_url":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/issues/155","id":238150706,"user":{"login":"philbooth","id":64367,"avatar_url":"https://avatars.githubusercontent.com/u/64367?v=3","gravatar_id":"","url":"https://api.github.com/users/philbooth","html_url":"https://github.com/philbooth","followers_url":"https://api.github.com/users/philbooth/followers","following_url":"https://api.github.com/users/philbooth/following{/other_user}","gists_url":"https://api.github.com/users/philbooth/gists{/gist_id}","starred_url":"https://api.github.com/users/philbooth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philbooth/subscriptions","organizations_url":"https://api.github.com/users/philbooth/orgs","repos_url":"https://api.github.com/users/philbooth/repos","events_url":"https://api.github.com/users/philbooth/events{/privacy}","received_events_url":"https://api.github.com/users/philbooth/received_events","type":"User","site_admin":false},"created_at":"2016-08-08T06:20:18Z","updated_at":"2016-08-08T06:20:18Z","body":"Quick question about the naming of `wantedKeys`: is it the right name for this layer of abstraction?\r\n\r\n`wantedKeys` seems like it might be more concretely related to request-handling in the auth server, rather than a trait of the sessionToken itself. Could it ever be possible for this state also to be triggered for other reasons?\r\n\r\nI was thinking that a name along the lines of `needsVerification`, `requiresVerification`, `expectsVerification` might be more session-tokeny? No worries if not, just wanted to ask the question."}}
{"actor":{"display_login":"philbooth"}}