{"action":"closed","number":585,"pull_request":{"url":"https://api.github.com/repos/droolsjbpm/jbpm/pulls/585","id":84564776,"html_url":"https://github.com/droolsjbpm/jbpm/pull/585","diff_url":"https://github.com/droolsjbpm/jbpm/pull/585.diff","patch_url":"https://github.com/droolsjbpm/jbpm/pull/585.patch","issue_url":"https://api.github.com/repos/droolsjbpm/jbpm/issues/585","number":585,"state":"closed","locked":false,"title":"JBPM-5082: Added users management configurations for the jbpm installer.","user":{"login":"romartin","id":4602417,"avatar_url":"https://avatars.githubusercontent.com/u/4602417?v=3","gravatar_id":"","url":"https://api.github.com/users/romartin","html_url":"https://github.com/romartin","followers_url":"https://api.github.com/users/romartin/followers","following_url":"https://api.github.com/users/romartin/following{/other_user}","gists_url":"https://api.github.com/users/romartin/gists{/gist_id}","starred_url":"https://api.github.com/users/romartin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romartin/subscriptions","organizations_url":"https://api.github.com/users/romartin/orgs","repos_url":"https://api.github.com/users/romartin/repos","events_url":"https://api.github.com/users/romartin/events{/privacy}","received_events_url":"https://api.github.com/users/romartin/received_events","type":"User","site_admin":false},"body":"Hi @krisv , @mswiderski , @dgutierr ,\r\n\r\nCan you please check if you agree on this change? If so, will create the PR for master as well. \r\n\r\nCurrently passwords on the jbpm-installer are on clear text, but both add-user script and our users management stuff do encrypt the passwords. So adding users from the UI adds the hashed password on the properties file, but the default passwords are on clear text.\r\n\r\nI see two options:\r\n1- Adding a configuration flag on the users management stuff to indicate wether passwords should be encrypted and use this configuration to set no encryption on the jbpm-installer.\r\n2.- Moving the jbpm-installer to the use of encrypted passwords, as both add-user script and users management stuff expects.\r\n\r\nThis PR is the fix for option 2 -> Added users management configurations for the jbpm installer and disabled use of UserRoles login module for the other domain security (use of encrypted password using same RealmDirect module).\r\n\r\nNote that the UserRoles login module used on the security domain is replaced by the RealmDirect one, which by default expects the encrypted passwords. This way:\r\n- The passwords are encrypted ( added comments in the password file with the clear text )\r\n- The configuration is centralized on just the realm conftiguration ( no need to specify the file paths on the security domain section as well )\r\n\r\nI have checked the workbench and the kieserver, both connectivities works fine and now the users created from the UI can log in fine. Not sure if this change could have more implications...\r\n\r\nPS: https://issues.jboss.org/browse/JBPM-5082\r\n\r\nThanks!!","created_at":"2016-09-08T22:24:53Z","updated_at":"2016-09-09T08:30:03Z","closed_at":"2016-09-09T08:30:03Z","merged_at":"2016-09-09T08:30:03Z","merge_commit_sha":"007bd2bae55bf7bb1ca1f08119edf4b32cb01487","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/droolsjbpm/jbpm/pulls/585/commits","review_comments_url":"https://api.github.com/repos/droolsjbpm/jbpm/pulls/585/comments","review_comment_url":"https://api.github.com/repos/droolsjbpm/jbpm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/droolsjbpm/jbpm/issues/585/comments","statuses_url":"https://api.github.com/repos/droolsjbpm/jbpm/statuses/ce126b8802b5aab10f757ec7fcb5529cd5f4cf87","head":{"label":"romartin:65x-users-mgmt","ref":"65x-users-mgmt","sha":"ce126b8802b5aab10f757ec7fcb5529cd5f4cf87","user":{"login":"romartin","id":4602417,"avatar_url":"https://avatars.githubusercontent.com/u/4602417?v=3","gravatar_id":"","url":"https://api.github.com/users/romartin","html_url":"https://github.com/romartin","followers_url":"https://api.github.com/users/romartin/followers","following_url":"https://api.github.com/users/romartin/following{/other_user}","gists_url":"https://api.github.com/users/romartin/gists{/gist_id}","starred_url":"https://api.github.com/users/romartin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romartin/subscriptions","organizations_url":"https://api.github.com/users/romartin/orgs","repos_url":"https://api.github.com/users/romartin/repos","events_url":"https://api.github.com/users/romartin/events{/privacy}","received_events_url":"https://api.github.com/users/romartin/received_events","type":"User","site_admin":false},"repo":{"id":67639415,"name":"jbpm","full_name":"romartin/jbpm","owner":{"login":"romartin","id":4602417,"avatar_url":"https://avatars.githubusercontent.com/u/4602417?v=3","gravatar_id":"","url":"https://api.github.com/users/romartin","html_url":"https://github.com/romartin","followers_url":"https://api.github.com/users/romartin/followers","following_url":"https://api.github.com/users/romartin/following{/other_user}","gists_url":"https://api.github.com/users/romartin/gists{/gist_id}","starred_url":"https://api.github.com/users/romartin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romartin/subscriptions","organizations_url":"https://api.github.com/users/romartin/orgs","repos_url":"https://api.github.com/users/romartin/repos","events_url":"https://api.github.com/users/romartin/events{/privacy}","received_events_url":"https://api.github.com/users/romartin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/romartin/jbpm","description":"a Business Process Management (BPM) Suite","fork":true,"url":"https://api.github.com/repos/romartin/jbpm","forks_url":"https://api.github.com/repos/romartin/jbpm/forks","keys_url":"https://api.github.com/repos/romartin/jbpm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/romartin/jbpm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/romartin/jbpm/teams","hooks_url":"https://api.github.com/repos/romartin/jbpm/hooks","issue_events_url":"https://api.github.com/repos/romartin/jbpm/issues/events{/number}","events_url":"https://api.github.com/repos/romartin/jbpm/events","assignees_url":"https://api.github.com/repos/romartin/jbpm/assignees{/user}","branches_url":"https://api.github.com/repos/romartin/jbpm/branches{/branch}","tags_url":"https://api.github.com/repos/romartin/jbpm/tags","blobs_url":"https://api.github.com/repos/romartin/jbpm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/romartin/jbpm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/romartin/jbpm/git/refs{/sha}","trees_url":"https://api.github.com/repos/romartin/jbpm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/romartin/jbpm/statuses/{sha}","languages_url":"https://api.github.com/repos/romartin/jbpm/languages","stargazers_url":"https://api.github.com/repos/romartin/jbpm/stargazers","contributors_url":"https://api.github.com/repos/romartin/jbpm/contributors","subscribers_url":"https://api.github.com/repos/romartin/jbpm/subscribers","subscription_url":"https://api.github.com/repos/romartin/jbpm/subscription","commits_url":"https://api.github.com/repos/romartin/jbpm/commits{/sha}","git_commits_url":"https://api.github.com/repos/romartin/jbpm/git/commits{/sha}","comments_url":"https://api.github.com/repos/romartin/jbpm/comments{/number}","issue_comment_url":"https://api.github.com/repos/romartin/jbpm/issues/comments{/number}","contents_url":"https://api.github.com/repos/romartin/jbpm/contents/{+path}","compare_url":"https://api.github.com/repos/romartin/jbpm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/romartin/jbpm/merges","archive_url":"https://api.github.com/repos/romartin/jbpm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/romartin/jbpm/downloads","issues_url":"https://api.github.com/repos/romartin/jbpm/issues{/number}","pulls_url":"https://api.github.com/repos/romartin/jbpm/pulls{/number}","milestones_url":"https://api.github.com/repos/romartin/jbpm/milestones{/number}","notifications_url":"https://api.github.com/repos/romartin/jbpm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/romartin/jbpm/labels{/name}","releases_url":"https://api.github.com/repos/romartin/jbpm/releases{/id}","deployments_url":"https://api.github.com/repos/romartin/jbpm/deployments","created_at":"2016-09-07T20:04:33Z","updated_at":"2016-09-07T20:04:47Z","pushed_at":"2016-09-08T21:24:13Z","git_url":"git://github.com/romartin/jbpm.git","ssh_url":"git@github.com:romartin/jbpm.git","clone_url":"https://github.com/romartin/jbpm.git","svn_url":"https://github.com/romartin/jbpm","homepage":"http://www.jbpm.org","size":40692,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"droolsjbpm:6.5.x","ref":"6.5.x","sha":"a30661e9a6314ecd13337ec0a2774c826e168793","user":{"login":"droolsjbpm","id":517980,"avatar_url":"https://avatars.githubusercontent.com/u/517980?v=3","gravatar_id":"","url":"https://api.github.com/users/droolsjbpm","html_url":"https://github.com/droolsjbpm","followers_url":"https://api.github.com/users/droolsjbpm/followers","following_url":"https://api.github.com/users/droolsjbpm/following{/other_user}","gists_url":"https://api.github.com/users/droolsjbpm/gists{/gist_id}","starred_url":"https://api.github.com/users/droolsjbpm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/droolsjbpm/subscriptions","organizations_url":"https://api.github.com/users/droolsjbpm/orgs","repos_url":"https://api.github.com/users/droolsjbpm/repos","events_url":"https://api.github.com/users/droolsjbpm/events{/privacy}","received_events_url":"https://api.github.com/users/droolsjbpm/received_events","type":"Organization","site_admin":false},"repo":{"id":930571,"name":"jbpm","full_name":"droolsjbpm/jbpm","owner":{"login":"droolsjbpm","id":517980,"avatar_url":"https://avatars.githubusercontent.com/u/517980?v=3","gravatar_id":"","url":"https://api.github.com/users/droolsjbpm","html_url":"https://github.com/droolsjbpm","followers_url":"https://api.github.com/users/droolsjbpm/followers","following_url":"https://api.github.com/users/droolsjbpm/following{/other_user}","gists_url":"https://api.github.com/users/droolsjbpm/gists{/gist_id}","starred_url":"https://api.github.com/users/droolsjbpm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/droolsjbpm/subscriptions","organizations_url":"https://api.github.com/users/droolsjbpm/orgs","repos_url":"https://api.github.com/users/droolsjbpm/repos","events_url":"https://api.github.com/users/droolsjbpm/events{/privacy}","received_events_url":"https://api.github.com/users/droolsjbpm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/droolsjbpm/jbpm","description":"a Business Process Management (BPM) Suite","fork":false,"url":"https://api.github.com/repos/droolsjbpm/jbpm","forks_url":"https://api.github.com/repos/droolsjbpm/jbpm/forks","keys_url":"https://api.github.com/repos/droolsjbpm/jbpm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/droolsjbpm/jbpm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/droolsjbpm/jbpm/teams","hooks_url":"https://api.github.com/repos/droolsjbpm/jbpm/hooks","issue_events_url":"https://api.github.com/repos/droolsjbpm/jbpm/issues/events{/number}","events_url":"https://api.github.com/repos/droolsjbpm/jbpm/events","assignees_url":"https://api.github.com/repos/droolsjbpm/jbpm/assignees{/user}","branches_url":"https://api.github.com/repos/droolsjbpm/jbpm/branches{/branch}","tags_url":"https://api.github.com/repos/droolsjbpm/jbpm/tags","blobs_url":"https://api.github.com/repos/droolsjbpm/jbpm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/droolsjbpm/jbpm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/droolsjbpm/jbpm/git/refs{/sha}","trees_url":"https://api.github.com/repos/droolsjbpm/jbpm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/droolsjbpm/jbpm/statuses/{sha}","languages_url":"https://api.github.com/repos/droolsjbpm/jbpm/languages","stargazers_url":"https://api.github.com/repos/droolsjbpm/jbpm/stargazers","contributors_url":"https://api.github.com/repos/droolsjbpm/jbpm/contributors","subscribers_url":"https://api.github.com/repos/droolsjbpm/jbpm/subscribers","subscription_url":"https://api.github.com/repos/droolsjbpm/jbpm/subscription","commits_url":"https://api.github.com/repos/droolsjbpm/jbpm/commits{/sha}","git_commits_url":"https://api.github.com/repos/droolsjbpm/jbpm/git/commits{/sha}","comments_url":"https://api.github.com/repos/droolsjbpm/jbpm/comments{/number}","issue_comment_url":"https://api.github.com/repos/droolsjbpm/jbpm/issues/comments{/number}","contents_url":"https://api.github.com/repos/droolsjbpm/jbpm/contents/{+path}","compare_url":"https://api.github.com/repos/droolsjbpm/jbpm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/droolsjbpm/jbpm/merges","archive_url":"https://api.github.com/repos/droolsjbpm/jbpm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/droolsjbpm/jbpm/downloads","issues_url":"https://api.github.com/repos/droolsjbpm/jbpm/issues{/number}","pulls_url":"https://api.github.com/repos/droolsjbpm/jbpm/pulls{/number}","milestones_url":"https://api.github.com/repos/droolsjbpm/jbpm/milestones{/number}","notifications_url":"https://api.github.com/repos/droolsjbpm/jbpm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/droolsjbpm/jbpm/labels{/name}","releases_url":"https://api.github.com/repos/droolsjbpm/jbpm/releases{/id}","deployments_url":"https://api.github.com/repos/droolsjbpm/jbpm/deployments","created_at":"2010-09-22T13:19:52Z","updated_at":"2016-09-07T06:19:59Z","pushed_at":"2016-09-09T08:30:03Z","git_url":"git://github.com/droolsjbpm/jbpm.git","ssh_url":"git@github.com:droolsjbpm/jbpm.git","clone_url":"https://github.com/droolsjbpm/jbpm.git","svn_url":"https://github.com/droolsjbpm/jbpm","homepage":"http://www.jbpm.org","size":49306,"stargazers_count":511,"watchers_count":511,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":698,"mirror_url":null,"open_issues_count":3,"forks":698,"open_issues":3,"watchers":511,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/droolsjbpm/jbpm/pulls/585"},"html":{"href":"https://github.com/droolsjbpm/jbpm/pull/585"},"issue":{"href":"https://api.github.com/repos/droolsjbpm/jbpm/issues/585"},"comments":{"href":"https://api.github.com/repos/droolsjbpm/jbpm/issues/585/comments"},"review_comments":{"href":"https://api.github.com/repos/droolsjbpm/jbpm/pulls/585/comments"},"review_comment":{"href":"https://api.github.com/repos/droolsjbpm/jbpm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/droolsjbpm/jbpm/pulls/585/commits"},"statuses":{"href":"https://api.github.com/repos/droolsjbpm/jbpm/statuses/ce126b8802b5aab10f757ec7fcb5529cd5f4cf87"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"mswiderski","id":904474,"avatar_url":"https://avatars.githubusercontent.com/u/904474?v=3","gravatar_id":"","url":"https://api.github.com/users/mswiderski","html_url":"https://github.com/mswiderski","followers_url":"https://api.github.com/users/mswiderski/followers","following_url":"https://api.github.com/users/mswiderski/following{/other_user}","gists_url":"https://api.github.com/users/mswiderski/gists{/gist_id}","starred_url":"https://api.github.com/users/mswiderski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mswiderski/subscriptions","organizations_url":"https://api.github.com/users/mswiderski/orgs","repos_url":"https://api.github.com/users/mswiderski/repos","events_url":"https://api.github.com/users/mswiderski/events{/privacy}","received_events_url":"https://api.github.com/users/mswiderski/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"commits":1,"additions":60,"deletions":39,"changed_files":7}}
{"actor":{"display_login":"mswiderski"}}