{"action":"created","issue":{"url":"https://api.github.com/repos/18F/crime-data-api/issues/121","repository_url":"https://api.github.com/repos/18F/crime-data-api","labels_url":"https://api.github.com/repos/18F/crime-data-api/issues/121/labels{/name}","comments_url":"https://api.github.com/repos/18F/crime-data-api/issues/121/comments","events_url":"https://api.github.com/repos/18F/crime-data-api/issues/121/events","html_url":"https://github.com/18F/crime-data-api/pull/121","id":192172905,"number":121,"title":"Remove tests for users and roles","user":{"login":"harrisj","id":2044,"avatar_url":"https://avatars.githubusercontent.com/u/2044?v=3","gravatar_id":"","url":"https://api.github.com/users/harrisj","html_url":"https://github.com/harrisj","followers_url":"https://api.github.com/users/harrisj/followers","following_url":"https://api.github.com/users/harrisj/following{/other_user}","gists_url":"https://api.github.com/users/harrisj/gists{/gist_id}","starred_url":"https://api.github.com/users/harrisj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harrisj/subscriptions","organizations_url":"https://api.github.com/users/harrisj/orgs","repos_url":"https://api.github.com/users/harrisj/repos","events_url":"https://api.github.com/users/harrisj/events{/privacy}","received_events_url":"https://api.github.com/users/harrisj/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-11-29T02:37:43Z","updated_at":"2016-11-29T04:24:23Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/18F/crime-data-api/pulls/121","html_url":"https://github.com/18F/crime-data-api/pull/121","diff_url":"https://github.com/18F/crime-data-api/pull/121.diff","patch_url":"https://github.com/18F/crime-data-api/pull/121.patch"},"body":"Fixes #117 \r\n\r\nThese were part of the initial Flask scaffolding and are not used, so best to not keep tests that slow down everything and could break. There are still a few other places to clean up this code if we want to continue removing code that is not actually used (I recommend doing that):\r\n\r\n- [ ] The User and Role model\r\n- [ ] The blueprints for user and public (this would mean we need a new homepage)\r\n- [ ] The login_manager\r\n\r\nWhat do you think?"},"comment":{"url":"https://api.github.com/repos/18F/crime-data-api/issues/comments/263472726","html_url":"https://github.com/18F/crime-data-api/pull/121#issuecomment-263472726","issue_url":"https://api.github.com/repos/18F/crime-data-api/issues/121","id":263472726,"user":{"login":"catherinedevlin","id":208054,"avatar_url":"https://avatars.githubusercontent.com/u/208054?v=3","gravatar_id":"","url":"https://api.github.com/users/catherinedevlin","html_url":"https://github.com/catherinedevlin","followers_url":"https://api.github.com/users/catherinedevlin/followers","following_url":"https://api.github.com/users/catherinedevlin/following{/other_user}","gists_url":"https://api.github.com/users/catherinedevlin/gists{/gist_id}","starred_url":"https://api.github.com/users/catherinedevlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/catherinedevlin/subscriptions","organizations_url":"https://api.github.com/users/catherinedevlin/orgs","repos_url":"https://api.github.com/users/catherinedevlin/repos","events_url":"https://api.github.com/users/catherinedevlin/events{/privacy}","received_events_url":"https://api.github.com/users/catherinedevlin/received_events","type":"User","site_admin":false},"created_at":"2016-11-29T04:24:23Z","updated_at":"2016-11-29T04:24:23Z","body":"This looks great, thank you.\r\n\r\nI think we should also delete the code you mention.  Should I merge this now, or do you want to commit those deletions to this same PR first?"}}
{"actor":{"display_login":"catherinedevlin"}}