{"action":"created","issue":{"url":"https://api.github.com/repos/plotly/plotly.js/issues/1028","repository_url":"https://api.github.com/repos/plotly/plotly.js","labels_url":"https://api.github.com/repos/plotly/plotly.js/issues/1028/labels{/name}","comments_url":"https://api.github.com/repos/plotly/plotly.js/issues/1028/comments","events_url":"https://api.github.com/repos/plotly/plotly.js/issues/1028/events","html_url":"https://github.com/plotly/plotly.js/pull/1028","id":182347369,"number":1028,"title":"Add grouping property to traces","user":{"login":"rreusser","id":572717,"avatar_url":"https://avatars.githubusercontent.com/u/572717?v=3","gravatar_id":"","url":"https://api.github.com/users/rreusser","html_url":"https://github.com/rreusser","followers_url":"https://api.github.com/users/rreusser/followers","following_url":"https://api.github.com/users/rreusser/following{/other_user}","gists_url":"https://api.github.com/users/rreusser/gists{/gist_id}","starred_url":"https://api.github.com/users/rreusser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rreusser/subscriptions","organizations_url":"https://api.github.com/users/rreusser/orgs","repos_url":"https://api.github.com/users/rreusser/repos","events_url":"https://api.github.com/users/rreusser/events{/privacy}","received_events_url":"https://api.github.com/users/rreusser/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/plotly/plotly.js/labels/status:%20on%20hold","name":"status: on hold","color":"fb9a99"},{"url":"https://api.github.com/repos/plotly/plotly.js/labels/type:%20feature","name":"type: feature","color":"1f78b4"}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/plotly/plotly.js/milestones/12","html_url":"https://github.com/plotly/plotly.js/milestones/v1.19.0","labels_url":"https://api.github.com/repos/plotly/plotly.js/milestones/12/labels","id":2068037,"number":12,"title":"v1.19.0","description":"","creator":{"login":"etpinard","id":6675409,"avatar_url":"https://avatars.githubusercontent.com/u/6675409?v=3","gravatar_id":"","url":"https://api.github.com/users/etpinard","html_url":"https://github.com/etpinard","followers_url":"https://api.github.com/users/etpinard/followers","following_url":"https://api.github.com/users/etpinard/following{/other_user}","gists_url":"https://api.github.com/users/etpinard/gists{/gist_id}","starred_url":"https://api.github.com/users/etpinard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etpinard/subscriptions","organizations_url":"https://api.github.com/users/etpinard/orgs","repos_url":"https://api.github.com/users/etpinard/repos","events_url":"https://api.github.com/users/etpinard/events{/privacy}","received_events_url":"https://api.github.com/users/etpinard/received_events","type":"User","site_admin":false},"open_issues":12,"closed_issues":3,"state":"open","created_at":"2016-10-13T14:45:23Z","updated_at":"2016-10-20T15:48:02Z","due_on":"2016-10-27T00:00:00Z","closed_at":null},"comments":9,"created_at":"2016-10-11T19:05:56Z","updated_at":"2016-10-20T15:48:02Z","closed_at":"2016-10-20T15:48:02Z","pull_request":{"url":"https://api.github.com/repos/plotly/plotly.js/pulls/1028","html_url":"https://github.com/plotly/plotly.js/pull/1028","diff_url":"https://github.com/plotly/plotly.js/pull/1028.diff","patch_url":"https://github.com/plotly/plotly.js/pull/1028.patch"},"body":"It's become clear that the `ids` field is insufficient. It's needed for object constancy while animating, but  duplicate `ids` result in disappearing markers. This is the expected behavior; it just precludes overloading the `ids` field for something like a filter transform, where duplicate data is perfectly reasonable.\r\n\r\nThis PR:\r\n- [x] adds a `grouping` property to traces and explicitly notes that it has no inherent effect\r\n- [x] notes in the docs that duplicate `ids` are invalid or at least have likely-unintended consequences\r\n- [x] adds `calcdata` tests for casting `ids`\r\n\r\nFeedback on naming and functionality is welcome. I don't like adding attributes, but this is very lightweight, seems necessary, and explicitly notes that it does not have any effect unless hooked up elsewhere by the user (e.g. transforms).\r\n\r\nSee also: #1027 \r\ncc: @chriddyp @etpinard @alexcjohnson "},"comment":{"url":"https://api.github.com/repos/plotly/plotly.js/issues/comments/255145720","html_url":"https://github.com/plotly/plotly.js/pull/1028#issuecomment-255145720","issue_url":"https://api.github.com/repos/plotly/plotly.js/issues/1028","id":255145720,"user":{"login":"etpinard","id":6675409,"avatar_url":"https://avatars.githubusercontent.com/u/6675409?v=3","gravatar_id":"","url":"https://api.github.com/users/etpinard","html_url":"https://github.com/etpinard","followers_url":"https://api.github.com/users/etpinard/followers","following_url":"https://api.github.com/users/etpinard/following{/other_user}","gists_url":"https://api.github.com/users/etpinard/gists{/gist_id}","starred_url":"https://api.github.com/users/etpinard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etpinard/subscriptions","organizations_url":"https://api.github.com/users/etpinard/orgs","repos_url":"https://api.github.com/users/etpinard/repos","events_url":"https://api.github.com/users/etpinard/events{/privacy}","received_events_url":"https://api.github.com/users/etpinard/received_events","type":"User","site_admin":false},"created_at":"2016-10-20T15:48:02Z","updated_at":"2016-10-20T15:48:02Z","body":"Obsolete."}}
{"actor":{"display_login":"etpinard"}}