{"action":"created","comment":{"url":"https://api.github.com/repos/lxc/lxd/pulls/comments/80702053","pull_request_review_id":1740454,"id":80702053,"diff_hunk":"@@ -1264,6 +1273,44 @@ func (c *containerLXC) startCommon() (string, error) {\n \t\t\t\t\treturn \"\", err\n \t\t\t\t}\n \t\t\t}\n+\t\t} else if m[\"type\"] == \"nic\" {\n+\t\t\tif m[\"nictype\"] == \"bridged\" && shared.IsTrue(m[\"security.mac_filtering\"]) {","path":"lxd/container_lxc.go","position":31,"original_position":31,"commit_id":"e24bf440a8c8b991300961bca7de94525ad4fbd7","original_commit_id":"e24bf440a8c8b991300961bca7de94525ad4fbd7","user":{"login":"tych0","id":785111,"avatar_url":"https://avatars.githubusercontent.com/u/785111?v=3","gravatar_id":"","url":"https://api.github.com/users/tych0","html_url":"https://github.com/tych0","followers_url":"https://api.github.com/users/tych0/followers","following_url":"https://api.github.com/users/tych0/following{/other_user}","gists_url":"https://api.github.com/users/tych0/gists{/gist_id}","starred_url":"https://api.github.com/users/tych0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tych0/subscriptions","organizations_url":"https://api.github.com/users/tych0/orgs","repos_url":"https://api.github.com/users/tych0/repos","events_url":"https://api.github.com/users/tych0/events{/privacy}","received_events_url":"https://api.github.com/users/tych0/received_events","type":"User","site_admin":false},"body":"Since this is only valid on veths, should we reject it if someone tries to set it on a macvlan or something?","created_at":"2016-09-27T14:15:13Z","updated_at":"2016-09-27T14:15:13Z","html_url":"https://github.com/lxc/lxd/pull/2429#discussion_r80702053","pull_request_url":"https://api.github.com/repos/lxc/lxd/pulls/2429","_links":{"self":{"href":"https://api.github.com/repos/lxc/lxd/pulls/comments/80702053"},"html":{"href":"https://github.com/lxc/lxd/pull/2429#discussion_r80702053"},"pull_request":{"href":"https://api.github.com/repos/lxc/lxd/pulls/2429"}}},"pull_request":{"url":"https://api.github.com/repos/lxc/lxd/pulls/2429","id":86861269,"html_url":"https://github.com/lxc/lxd/pull/2429","diff_url":"https://github.com/lxc/lxd/pull/2429.diff","patch_url":"https://github.com/lxc/lxd/pull/2429.patch","issue_url":"https://api.github.com/repos/lxc/lxd/issues/2429","number":2429,"state":"open","locked":false,"title":"Introduce security.mac_filtering","user":{"login":"stgraber","id":2230599,"avatar_url":"https://avatars.githubusercontent.com/u/2230599?v=3","gravatar_id":"","url":"https://api.github.com/users/stgraber","html_url":"https://github.com/stgraber","followers_url":"https://api.github.com/users/stgraber/followers","following_url":"https://api.github.com/users/stgraber/following{/other_user}","gists_url":"https://api.github.com/users/stgraber/gists{/gist_id}","starred_url":"https://api.github.com/users/stgraber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stgraber/subscriptions","organizations_url":"https://api.github.com/users/stgraber/orgs","repos_url":"https://api.github.com/users/stgraber/repos","events_url":"https://api.github.com/users/stgraber/events{/privacy}","received_events_url":"https://api.github.com/users/stgraber/received_events","type":"User","site_admin":false},"body":"This option for bridged nic devices turns on MAC filtering on the host,\r\npreventing the container from sending traffic for a MAC other than the\r\none known by LXD.\r\n\r\nSigned-off-by: Stéphane Graber <stgraber@ubuntu.com>","created_at":"2016-09-27T04:39:19Z","updated_at":"2016-09-27T14:15:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"179689edd10c72336ea5d95d94e332997b738deb","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/lxc/lxd/pulls/2429/commits","review_comments_url":"https://api.github.com/repos/lxc/lxd/pulls/2429/comments","review_comment_url":"https://api.github.com/repos/lxc/lxd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lxc/lxd/issues/2429/comments","statuses_url":"https://api.github.com/repos/lxc/lxd/statuses/e24bf440a8c8b991300961bca7de94525ad4fbd7","head":{"label":"stgraber:master","ref":"master","sha":"e24bf440a8c8b991300961bca7de94525ad4fbd7","user":{"login":"stgraber","id":2230599,"avatar_url":"https://avatars.githubusercontent.com/u/2230599?v=3","gravatar_id":"","url":"https://api.github.com/users/stgraber","html_url":"https://github.com/stgraber","followers_url":"https://api.github.com/users/stgraber/followers","following_url":"https://api.github.com/users/stgraber/following{/other_user}","gists_url":"https://api.github.com/users/stgraber/gists{/gist_id}","starred_url":"https://api.github.com/users/stgraber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stgraber/subscriptions","organizations_url":"https://api.github.com/users/stgraber/orgs","repos_url":"https://api.github.com/users/stgraber/repos","events_url":"https://api.github.com/users/stgraber/events{/privacy}","received_events_url":"https://api.github.com/users/stgraber/received_events","type":"User","site_admin":false},"repo":{"id":26225592,"name":"lxd","full_name":"stgraber/lxd","owner":{"login":"stgraber","id":2230599,"avatar_url":"https://avatars.githubusercontent.com/u/2230599?v=3","gravatar_id":"","url":"https://api.github.com/users/stgraber","html_url":"https://github.com/stgraber","followers_url":"https://api.github.com/users/stgraber/followers","following_url":"https://api.github.com/users/stgraber/following{/other_user}","gists_url":"https://api.github.com/users/stgraber/gists{/gist_id}","starred_url":"https://api.github.com/users/stgraber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stgraber/subscriptions","organizations_url":"https://api.github.com/users/stgraber/orgs","repos_url":"https://api.github.com/users/stgraber/repos","events_url":"https://api.github.com/users/stgraber/events{/privacy}","received_events_url":"https://api.github.com/users/stgraber/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stgraber/lxd","description":"Personal work copy of lxc/lxd","fork":true,"url":"https://api.github.com/repos/stgraber/lxd","forks_url":"https://api.github.com/repos/stgraber/lxd/forks","keys_url":"https://api.github.com/repos/stgraber/lxd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stgraber/lxd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stgraber/lxd/teams","hooks_url":"https://api.github.com/repos/stgraber/lxd/hooks","issue_events_url":"https://api.github.com/repos/stgraber/lxd/issues/events{/number}","events_url":"https://api.github.com/repos/stgraber/lxd/events","assignees_url":"https://api.github.com/repos/stgraber/lxd/assignees{/user}","branches_url":"https://api.github.com/repos/stgraber/lxd/branches{/branch}","tags_url":"https://api.github.com/repos/stgraber/lxd/tags","blobs_url":"https://api.github.com/repos/stgraber/lxd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stgraber/lxd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stgraber/lxd/git/refs{/sha}","trees_url":"https://api.github.com/repos/stgraber/lxd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stgraber/lxd/statuses/{sha}","languages_url":"https://api.github.com/repos/stgraber/lxd/languages","stargazers_url":"https://api.github.com/repos/stgraber/lxd/stargazers","contributors_url":"https://api.github.com/repos/stgraber/lxd/contributors","subscribers_url":"https://api.github.com/repos/stgraber/lxd/subscribers","subscription_url":"https://api.github.com/repos/stgraber/lxd/subscription","commits_url":"https://api.github.com/repos/stgraber/lxd/commits{/sha}","git_commits_url":"https://api.github.com/repos/stgraber/lxd/git/commits{/sha}","comments_url":"https://api.github.com/repos/stgraber/lxd/comments{/number}","issue_comment_url":"https://api.github.com/repos/stgraber/lxd/issues/comments{/number}","contents_url":"https://api.github.com/repos/stgraber/lxd/contents/{+path}","compare_url":"https://api.github.com/repos/stgraber/lxd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stgraber/lxd/merges","archive_url":"https://api.github.com/repos/stgraber/lxd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stgraber/lxd/downloads","issues_url":"https://api.github.com/repos/stgraber/lxd/issues{/number}","pulls_url":"https://api.github.com/repos/stgraber/lxd/pulls{/number}","milestones_url":"https://api.github.com/repos/stgraber/lxd/milestones{/number}","notifications_url":"https://api.github.com/repos/stgraber/lxd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stgraber/lxd/labels{/name}","releases_url":"https://api.github.com/repos/stgraber/lxd/releases{/id}","deployments_url":"https://api.github.com/repos/stgraber/lxd/deployments","created_at":"2014-11-05T15:24:41Z","updated_at":"2016-02-18T06:25:56Z","pushed_at":"2016-09-27T04:39:12Z","git_url":"git://github.com/stgraber/lxd.git","ssh_url":"git@github.com:stgraber/lxd.git","clone_url":"https://github.com/stgraber/lxd.git","svn_url":"https://github.com/stgraber/lxd","homepage":"","size":6926,"stargazers_count":3,"watchers_count":3,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":3,"default_branch":"master"}},"base":{"label":"lxc:master","ref":"master","sha":"0c6a44e8d34d987d0e96b62fed2e36000f57559f","user":{"login":"lxc","id":2301756,"avatar_url":"https://avatars.githubusercontent.com/u/2301756?v=3","gravatar_id":"","url":"https://api.github.com/users/lxc","html_url":"https://github.com/lxc","followers_url":"https://api.github.com/users/lxc/followers","following_url":"https://api.github.com/users/lxc/following{/other_user}","gists_url":"https://api.github.com/users/lxc/gists{/gist_id}","starred_url":"https://api.github.com/users/lxc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lxc/subscriptions","organizations_url":"https://api.github.com/users/lxc/orgs","repos_url":"https://api.github.com/users/lxc/repos","events_url":"https://api.github.com/users/lxc/events{/privacy}","received_events_url":"https://api.github.com/users/lxc/received_events","type":"Organization","site_admin":false},"repo":{"id":26192117,"name":"lxd","full_name":"lxc/lxd","owner":{"login":"lxc","id":2301756,"avatar_url":"https://avatars.githubusercontent.com/u/2301756?v=3","gravatar_id":"","url":"https://api.github.com/users/lxc","html_url":"https://github.com/lxc","followers_url":"https://api.github.com/users/lxc/followers","following_url":"https://api.github.com/users/lxc/following{/other_user}","gists_url":"https://api.github.com/users/lxc/gists{/gist_id}","starred_url":"https://api.github.com/users/lxc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lxc/subscriptions","organizations_url":"https://api.github.com/users/lxc/orgs","repos_url":"https://api.github.com/users/lxc/repos","events_url":"https://api.github.com/users/lxc/events{/privacy}","received_events_url":"https://api.github.com/users/lxc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lxc/lxd","description":"Daemon based on liblxc offering a REST API to manage containers","fork":false,"url":"https://api.github.com/repos/lxc/lxd","forks_url":"https://api.github.com/repos/lxc/lxd/forks","keys_url":"https://api.github.com/repos/lxc/lxd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lxc/lxd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lxc/lxd/teams","hooks_url":"https://api.github.com/repos/lxc/lxd/hooks","issue_events_url":"https://api.github.com/repos/lxc/lxd/issues/events{/number}","events_url":"https://api.github.com/repos/lxc/lxd/events","assignees_url":"https://api.github.com/repos/lxc/lxd/assignees{/user}","branches_url":"https://api.github.com/repos/lxc/lxd/branches{/branch}","tags_url":"https://api.github.com/repos/lxc/lxd/tags","blobs_url":"https://api.github.com/repos/lxc/lxd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lxc/lxd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lxc/lxd/git/refs{/sha}","trees_url":"https://api.github.com/repos/lxc/lxd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lxc/lxd/statuses/{sha}","languages_url":"https://api.github.com/repos/lxc/lxd/languages","stargazers_url":"https://api.github.com/repos/lxc/lxd/stargazers","contributors_url":"https://api.github.com/repos/lxc/lxd/contributors","subscribers_url":"https://api.github.com/repos/lxc/lxd/subscribers","subscription_url":"https://api.github.com/repos/lxc/lxd/subscription","commits_url":"https://api.github.com/repos/lxc/lxd/commits{/sha}","git_commits_url":"https://api.github.com/repos/lxc/lxd/git/commits{/sha}","comments_url":"https://api.github.com/repos/lxc/lxd/comments{/number}","issue_comment_url":"https://api.github.com/repos/lxc/lxd/issues/comments{/number}","contents_url":"https://api.github.com/repos/lxc/lxd/contents/{+path}","compare_url":"https://api.github.com/repos/lxc/lxd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lxc/lxd/merges","archive_url":"https://api.github.com/repos/lxc/lxd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lxc/lxd/downloads","issues_url":"https://api.github.com/repos/lxc/lxd/issues{/number}","pulls_url":"https://api.github.com/repos/lxc/lxd/pulls{/number}","milestones_url":"https://api.github.com/repos/lxc/lxd/milestones{/number}","notifications_url":"https://api.github.com/repos/lxc/lxd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lxc/lxd/labels{/name}","releases_url":"https://api.github.com/repos/lxc/lxd/releases{/id}","deployments_url":"https://api.github.com/repos/lxc/lxd/deployments","created_at":"2014-11-04T22:40:52Z","updated_at":"2016-09-24T18:25:20Z","pushed_at":"2016-09-27T04:39:20Z","git_url":"git://github.com/lxc/lxd.git","ssh_url":"git@github.com:lxc/lxd.git","clone_url":"https://github.com/lxc/lxd.git","svn_url":"https://github.com/lxc/lxd","homepage":"https://linuxcontainers.org/lxd","size":10175,"stargazers_count":1106,"watchers_count":1106,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":225,"mirror_url":null,"open_issues_count":71,"forks":225,"open_issues":71,"watchers":1106,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lxc/lxd/pulls/2429"},"html":{"href":"https://github.com/lxc/lxd/pull/2429"},"issue":{"href":"https://api.github.com/repos/lxc/lxd/issues/2429"},"comments":{"href":"https://api.github.com/repos/lxc/lxd/issues/2429/comments"},"review_comments":{"href":"https://api.github.com/repos/lxc/lxd/pulls/2429/comments"},"review_comment":{"href":"https://api.github.com/repos/lxc/lxd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lxc/lxd/pulls/2429/commits"},"statuses":{"href":"https://api.github.com/repos/lxc/lxd/statuses/e24bf440a8c8b991300961bca7de94525ad4fbd7"}}}}
{"actor":{"display_login":"tych0"}}