{"action":"created","issue":{"url":"https://api.github.com/repos/saltstack/salt/issues/35110","repository_url":"https://api.github.com/repos/saltstack/salt","labels_url":"https://api.github.com/repos/saltstack/salt/issues/35110/labels{/name}","comments_url":"https://api.github.com/repos/saltstack/salt/issues/35110/comments","events_url":"https://api.github.com/repos/saltstack/salt/issues/35110/events","html_url":"https://github.com/saltstack/salt/pull/35110","id":168753599,"number":35110,"title":"Do not return job status back to master for master_alive and master_failback schedules","user":{"login":"hu-dabao","id":3854528,"avatar_url":"https://avatars.githubusercontent.com/u/3854528?v=3","gravatar_id":"","url":"https://api.github.com/users/hu-dabao","html_url":"https://github.com/hu-dabao","followers_url":"https://api.github.com/users/hu-dabao/followers","following_url":"https://api.github.com/users/hu-dabao/following{/other_user}","gists_url":"https://api.github.com/users/hu-dabao/gists{/gist_id}","starred_url":"https://api.github.com/users/hu-dabao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hu-dabao/subscriptions","organizations_url":"https://api.github.com/users/hu-dabao/orgs","repos_url":"https://api.github.com/users/hu-dabao/repos","events_url":"https://api.github.com/users/hu-dabao/events{/privacy}","received_events_url":"https://api.github.com/users/hu-dabao/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-08-01T22:06:55Z","updated_at":"2016-08-02T07:49:45Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/saltstack/salt/pulls/35110","html_url":"https://github.com/saltstack/salt/pull/35110","diff_url":"https://github.com/saltstack/salt/pull/35110.diff","patch_url":"https://github.com/saltstack/salt/pull/35110.patch"},"body":"### What does this PR do?\r\nStop `__master_alive` and `__master_failback` schedules reporting back to masters. \r\n\r\nThe reasons of reducing this unnecessary load to master for multi-master setup are\r\n1. This will make unnecessary spams to master when amount of minions of each master is not small, which will cause unnecessary load on event bus. (1k+ minions with master_live frequency of 30s will totally flood master event bus with useless info)\r\n2. Alive master doesn't need to know from **every single** minion it has that it is alive. Master knows its life better than any other processes (successful `__master_alive` run case). \r\n3. Dead master doesn't have ability to know from **every single** minion it has that it is dead, because it is already dead (failed `__master_alive` run case). \r\n4. Same to `__master_failback` cases.\r\n\r\nHuge amount of useless events from minions back to master will finally downgrade multi-masters' scalability and reliability. \r\n \r\n\r\n### What issues does this PR fix or reference?\r\n\r\n### Previous Behavior\r\nIn the multi-master setup, all minions of the masters will return all `__master_alive` and `__master_failback` events to masters.\r\n\r\n### New Behavior\r\nIn the multi-master setup, all minions of the masters will stop returning any `__master_alive` and `__master_failback` events to masters.\r\n\r\n### Tests written?\r\n\r\nNo\r\n\r\nPlease review [Salt's Contributing Guide](https://docs.saltstack.com/en/latest/topics/development/contributing.html) for best practices.\r\n"},"comment":{"url":"https://api.github.com/repos/saltstack/salt/issues/comments/236828670","html_url":"https://github.com/saltstack/salt/pull/35110#issuecomment-236828670","issue_url":"https://api.github.com/repos/saltstack/salt/issues/35110","id":236828670,"user":{"login":"cachedout","id":111616,"avatar_url":"https://avatars.githubusercontent.com/u/111616?v=3","gravatar_id":"","url":"https://api.github.com/users/cachedout","html_url":"https://github.com/cachedout","followers_url":"https://api.github.com/users/cachedout/followers","following_url":"https://api.github.com/users/cachedout/following{/other_user}","gists_url":"https://api.github.com/users/cachedout/gists{/gist_id}","starred_url":"https://api.github.com/users/cachedout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cachedout/subscriptions","organizations_url":"https://api.github.com/users/cachedout/orgs","repos_url":"https://api.github.com/users/cachedout/repos","events_url":"https://api.github.com/users/cachedout/events{/privacy}","received_events_url":"https://api.github.com/users/cachedout/received_events","type":"User","site_admin":false},"created_at":"2016-08-02T07:49:45Z","updated_at":"2016-08-02T07:49:45Z","body":"This seems totally sensible. Thanks, @hu-dabao "}}
{"actor":{"display_login":"cachedout"}}