{"action":"opened","issue":{"url":"https://api.github.com/repos/sencha/electron-demo/issues/13","repository_url":"https://api.github.com/repos/sencha/electron-demo","labels_url":"https://api.github.com/repos/sencha/electron-demo/issues/13/labels{/name}","comments_url":"https://api.github.com/repos/sencha/electron-demo/issues/13/comments","events_url":"https://api.github.com/repos/sencha/electron-demo/issues/13/events","html_url":"https://github.com/sencha/electron-demo/issues/13","id":191501476,"number":13,"title":"ext-electron package shouldn't break applications while running in a browser","user":{"login":"savelee","id":303039,"avatar_url":"https://avatars.githubusercontent.com/u/303039?v=3","gravatar_id":"","url":"https://api.github.com/users/savelee","html_url":"https://github.com/savelee","followers_url":"https://api.github.com/users/savelee/followers","following_url":"https://api.github.com/users/savelee/following{/other_user}","gists_url":"https://api.github.com/users/savelee/gists{/gist_id}","starred_url":"https://api.github.com/users/savelee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/savelee/subscriptions","organizations_url":"https://api.github.com/users/savelee/orgs","repos_url":"https://api.github.com/users/savelee/repos","events_url":"https://api.github.com/users/savelee/events{/privacy}","received_events_url":"https://api.github.com/users/savelee/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-11-24T11:52:25Z","updated_at":"2016-11-24T11:52:25Z","closed_at":null,"body":"When requiring/mixin ext-electron packages within a current Ext JS application, it shouldn't break when running in a browser. Instead it should check if running in electron, before loading native stuff.\r\n\r\nI solved it by adding to Manager.js, Dialog.js and FilePicker.js the following check:\r\n\r\n---\r\n  if(window && window.process) {\r\n   // current electron implementation\r\n  } else {\r\n     return {\r\n        requires: [\r\n            'Ext.Class'\r\n        ]\r\n     }\r\n }\r\n---"}}
{"actor":{"display_login":"savelee"}}