{"action":"created","issue":{"url":"https://api.github.com/repos/checkstyle/checkstyle/issues/2940","repository_url":"https://api.github.com/repos/checkstyle/checkstyle","labels_url":"https://api.github.com/repos/checkstyle/checkstyle/issues/2940/labels{/name}","comments_url":"https://api.github.com/repos/checkstyle/checkstyle/issues/2940/comments","events_url":"https://api.github.com/repos/checkstyle/checkstyle/issues/2940/events","html_url":"https://github.com/checkstyle/checkstyle/pull/2940","id":134755541,"number":2940,"title":"Issue 2763: restoration of throwsIndent","user":{"login":"rnveach","id":5427943,"avatar_url":"https://avatars.githubusercontent.com/u/5427943?v=3","gravatar_id":"","url":"https://api.github.com/users/rnveach","html_url":"https://github.com/rnveach","followers_url":"https://api.github.com/users/rnveach/followers","following_url":"https://api.github.com/users/rnveach/following{/other_user}","gists_url":"https://api.github.com/users/rnveach/gists{/gist_id}","starred_url":"https://api.github.com/users/rnveach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rnveach/subscriptions","organizations_url":"https://api.github.com/users/rnveach/orgs","repos_url":"https://api.github.com/users/rnveach/repos","events_url":"https://api.github.com/users/rnveach/events{/privacy}","received_events_url":"https://api.github.com/users/rnveach/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2016-02-19T02:36:49Z","updated_at":"2016-04-28T19:07:09Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/checkstyle/checkstyle/pulls/2940","html_url":"https://github.com/checkstyle/checkstyle/pull/2940","diff_url":"https://github.com/checkstyle/checkstyle/pull/2940.diff","patch_url":"https://github.com/checkstyle/checkstyle/pull/2940.patch"},"body":"Issue #2763 \r\n\r\nThis restores `throwsIndent`s code from https://github.com/checkstyle/checkstyle/commit/1ff166e1b64ddf40bd9f9cbd9834b8905f77fd94 with 1 addition.\r\n\r\nhttps://github.com/rnveach/checkstyle/blob/404c1ced913286319251ee5f86549f13891c1940/src/main/java/com/puppycrawl/tools/checkstyle/checks/indentation/MethodDefHandler.java#L78-L88\r\nThese lines are new. They allow exceptions that appear on separate lines to be indented based on line wrapping. Without it, those lines would be skipped, just like throws was before this fix.\r\n\r\n**Gray area**:\r\nhttps://github.com/rnveach/checkstyle/blob/404c1ced913286319251ee5f86549f13891c1940/src/main/java/com/puppycrawl/tools/checkstyle/checks/indentation/MethodDefHandler.java#L80-L87\r\nThis section is ugly and I may look into fixing it.\r\nThe issue is `LineWrappingHandler`s first node must be the first node on the line (source https://github.com/checkstyle/checkstyle/blob/7572ba1f8e392bd0a57e87c48f4d3abefb83fe6a/src/main/java/com/puppycrawl/tools/checkstyle/checks/indentation/LineWrappingHandler.java#L107-L108). If you don't give it the first node on the line, it thinks the node is still the first on the line and produces invalid indentation recommendations. I feel this is a tough requirement to meet unless we design another routine to search for the first node.\r\nI don't know how this will affect the other areas that call the class or filed issues."},"comment":{"url":"https://api.github.com/repos/checkstyle/checkstyle/issues/comments/215530936","html_url":"https://github.com/checkstyle/checkstyle/pull/2940#issuecomment-215530936","issue_url":"https://api.github.com/repos/checkstyle/checkstyle/issues/2940","id":215530936,"user":{"login":"codecov-io","id":8655789,"avatar_url":"https://avatars.githubusercontent.com/u/8655789?v=3","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2016-04-28T19:07:09Z","updated_at":"2016-04-28T19:07:09Z","body":"## [Current coverage][cc-pull] is **100%**\n> Merging [#2940][cc-pull] into [master][cc-base-branch] will decrease coverage by **+n/a%**\n\n```diff\n@@             master   #2940   diff @@\n=======================================\n  Files           275     272     -3   \n  Lines         13795   13170   -625   \n  Methods           0       0          \n  Branches       3169    3020   -149   \n=======================================\n- Hits          13795   13170   -625   \n  Misses            0       0          \n  Partials          0       0          \n```\n\n1. 2 files in `...ls/checkstyle/checks` were modified. [more](https://codecov.io/gh/checkstyle/checkstyle/commit/cf3b4ff86a2abf6e53a7e6f26e32bc3efbb5a336/changes?src=pr#7372632F6D61696E2F6A6176612F636F6D2F7075707079637261776C2F746F6F6C732F636865636B7374796C652F636865636B73) \n  - Hits `+3`\n1. 2 files in `...tools/checkstyle/api` were modified. [more](https://codecov.io/gh/checkstyle/checkstyle/commit/cf3b4ff86a2abf6e53a7e6f26e32bc3efbb5a336/changes?src=pr#7372632F6D61696E2F6A6176612F636F6D2F7075707079637261776C2F746F6F6C732F636865636B7374796C652F617069) \n  - Hits `-2`\n1. 1 files in `...awl/tools/checkstyle` were modified. [more](https://codecov.io/gh/checkstyle/checkstyle/commit/cf3b4ff86a2abf6e53a7e6f26e32bc3efbb5a336/changes?src=pr#7372632F6D61696E2F6A6176612F636F6D2F7075707079637261776C2F746F6F6C732F636865636B7374796C65) \n  - Hits `-12`\n1. 4 files (not in diff) in `...ols/checkstyle/utils` were modified. [more](https://codecov.io/gh/checkstyle/checkstyle/commit/cf3b4ff86a2abf6e53a7e6f26e32bc3efbb5a336/changes?src=pr#7372632F6D61696E2F6A6176612F636F6D2F7075707079637261776C2F746F6F6C732F636865636B7374796C652F7574696C73) \n  - Hits `-5`\n1. 8 files (not in diff) in `...le/checks/whitespace` were modified. [more](https://codecov.io/gh/checkstyle/checkstyle/commit/cf3b4ff86a2abf6e53a7e6f26e32bc3efbb5a336/changes?src=pr#7372632F6D61696E2F6A6176612F636F6D2F7075707079637261776C2F746F6F6C732F636865636B7374796C652F636865636B732F77686974657370616365) \n  - Hits `-33`\n1. 3 files (not in diff) in `...ckstyle/checks/sizes` were modified. [more](https://codecov.io/gh/checkstyle/checkstyle/commit/cf3b4ff86a2abf6e53a7e6f26e32bc3efbb5a336/changes?src=pr#7372632F6D61696E2F6A6176612F636F6D2F7075707079637261776C2F746F6F6C732F636865636B7374796C652F636865636B732F73697A6573)\n1. 3 files (not in diff) in `...kstyle/checks/regexp` were modified. [more](https://codecov.io/gh/checkstyle/checkstyle/commit/cf3b4ff86a2abf6e53a7e6f26e32bc3efbb5a336/changes?src=pr#7372632F6D61696E2F6A6176612F636F6D2F7075707079637261776C2F746F6F6C732F636865636B7374796C652F636865636B732F726567657870)\n1. 3 files (not in diff) in `...kstyle/checks/naming` were modified. [more](https://codecov.io/gh/checkstyle/checkstyle/commit/cf3b4ff86a2abf6e53a7e6f26e32bc3efbb5a336/changes?src=pr#7372632F6D61696E2F6A6176612F636F6D2F7075707079637261776C2F746F6F6C732F636865636B7374796C652F636865636B732F6E616D696E67)\n1. 2 files (not in diff) in `...tyle/checks/modifier` were modified. [more](https://codecov.io/gh/checkstyle/checkstyle/commit/cf3b4ff86a2abf6e53a7e6f26e32bc3efbb5a336/changes?src=pr#7372632F6D61696E2F6A6176612F636F6D2F7075707079637261776C2F746F6F6C732F636865636B7374796C652F636865636B732F6D6F646966696572) \n  - Hits `-6`\n1. 4 files (not in diff) in `...style/checks/javadoc` were modified. [more](https://codecov.io/gh/checkstyle/checkstyle/commit/cf3b4ff86a2abf6e53a7e6f26e32bc3efbb5a336/changes?src=pr#7372632F6D61696E2F6A6176612F636F6D2F7075707079637261776C2F746F6F6C732F636865636B7374796C652F636865636B732F6A617661646F63) \n  - Hits `+148`\n\n\n> Powered by [Codecov](https://codecov.io?src=pr). Last updated by cf3b4ff\n[cc-base-branch]: https://codecov.io/gh/checkstyle/checkstyle/branch/master?src=pr\n[cc-pull]: https://codecov.io/gh/checkstyle/checkstyle/pull/2940?src=pr"}}