{"action":"created","comment":{"url":"https://api.github.com/repos/flutter/engine/pulls/comments/68887275","id":68887275,"diff_hunk":"@@ -62,53 +71,64 @@ - (instancetype)initWithBridge:(sky::shell::AccessibilityBridge*)bridge\n   return self;\n }\n \n-#pragma mark - Semantics node methods\n-\n-- (void)update:(const semantics::SemanticsNodePtr&)mojoNode {\n-  DCHECK(_uid == mojoNode->id);\n-\n-  if (!mojoNode->flags.is_null()) {\n-    _flags = mojoNode->flags.Pass();\n-  }\n-\n-  if (!mojoNode->strings.is_null()) {\n-    _strings = mojoNode->strings.Pass();\n-  }\n-\n-  if (!mojoNode->geometry.is_null()) {\n-    _geometry = mojoNode->geometry;\n-  }\n-\n-  if (!mojoNode->children.is_null()) {\n-    // Mark existing children as orphans\n-    NSArray* oldChildren = _children;\n-    for (AccessibilityNode* child in oldChildren) {\n-      DCHECK(child->_parent != nil);\n-      child->_parent = nil;\n-    }\n-\n-    // Set the new list of children\n-    NSMutableArray* children = [[NSMutableArray alloc] init];\n-    _children = children;\n-    for (const semantics::SemanticsNodePtr& mojoChild : mojoNode->children) {\n-      AccessibilityNode* child = _bridge->UpdateNode(mojoChild);\n-      child->_parent = self;\n-      [children insertObject:child atIndex:0];\n-    }\n-\n-    // Remove those children that are still marked as orphans\n-    for (AccessibilityNode* child in oldChildren) {\n-      if (child->_parent == nil) {\n-        _bridge->RemoveNode(child);\n+#pragma mark - Semantic object methods\n+\n+- (void)updateWith:(const semantics::SemanticsNodePtr&)node {\n+  DCHECK(_uid == node->id);\n+\n+  if (!node->flags.is_null())\n+    _flags = node->flags.Pass();\n+\n+  if (!node->strings.is_null())\n+    _strings = node->strings.Pass();\n+\n+  if (!node->geometry.is_null())\n+    _geometry = node->geometry;\n+\n+  if (!node->actions.is_null()) {\n+    _canBeTapped = false;\n+    _canBeLongPressed = false;\n+    _canBeScrolledHorizontally = false;\n+    _canBeScrolledVertically = false;\n+    for (semantics::SemanticAction action : node->actions) {\n+      switch (action) {\n+      case semantics::SemanticAction::TAP:\n+        _canBeTapped = true;\n+        break;\n+      case semantics::SemanticAction::LONG_PRESS:\n+        _canBeLongPressed = true;\n+        break;\n+      case semantics::SemanticAction::SCROLL_LEFT:","path":"sky/shell/platform/ios/framework/Source/accessibility_bridge.mm","position":123,"original_position":123,"commit_id":"374f929c0c0a5b0523837642b18dce3380b4290b","original_commit_id":"374f929c0c0a5b0523837642b18dce3380b4290b","user":{"login":"tvolkert","id":15253456,"avatar_url":"https://avatars.githubusercontent.com/u/15253456?v=3","gravatar_id":"","url":"https://api.github.com/users/tvolkert","html_url":"https://github.com/tvolkert","followers_url":"https://api.github.com/users/tvolkert/followers","following_url":"https://api.github.com/users/tvolkert/following{/other_user}","gists_url":"https://api.github.com/users/tvolkert/gists{/gist_id}","starred_url":"https://api.github.com/users/tvolkert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tvolkert/subscriptions","organizations_url":"https://api.github.com/users/tvolkert/orgs","repos_url":"https://api.github.com/users/tvolkert/repos","events_url":"https://api.github.com/users/tvolkert/events{/privacy}","received_events_url":"https://api.github.com/users/tvolkert/received_events","type":"User","site_admin":false},"body":"You can coalesce the `SCROLL_LEFT` and `SCROLL_RIGHT` cases.  Same with `SCROLL_UP` and `SCROLL_DOWN`","created_at":"2016-06-29T05:28:06Z","updated_at":"2016-06-29T05:28:06Z","html_url":"https://github.com/flutter/engine/pull/2777#discussion_r68887275","pull_request_url":"https://api.github.com/repos/flutter/engine/pulls/2777","_links":{"self":{"href":"https://api.github.com/repos/flutter/engine/pulls/comments/68887275"},"html":{"href":"https://github.com/flutter/engine/pull/2777#discussion_r68887275"},"pull_request":{"href":"https://api.github.com/repos/flutter/engine/pulls/2777"}}},"pull_request":{"url":"https://api.github.com/repos/flutter/engine/pulls/2777","id":75583521,"html_url":"https://github.com/flutter/engine/pull/2777","diff_url":"https://github.com/flutter/engine/pull/2777.diff","patch_url":"https://github.com/flutter/engine/pull/2777.patch","issue_url":"https://api.github.com/repos/flutter/engine/issues/2777","number":2777,"state":"open","locked":false,"title":"Harmonize Android and iOS accessibility bridges","user":{"login":"abarth","id":112007,"avatar_url":"https://avatars.githubusercontent.com/u/112007?v=3","gravatar_id":"","url":"https://api.github.com/users/abarth","html_url":"https://github.com/abarth","followers_url":"https://api.github.com/users/abarth/followers","following_url":"https://api.github.com/users/abarth/following{/other_user}","gists_url":"https://api.github.com/users/abarth/gists{/gist_id}","starred_url":"https://api.github.com/users/abarth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abarth/subscriptions","organizations_url":"https://api.github.com/users/abarth/orgs","repos_url":"https://api.github.com/users/abarth/repos","events_url":"https://api.github.com/users/abarth/events{/privacy}","received_events_url":"https://api.github.com/users/abarth/received_events","type":"User","site_admin":false},"body":"These classes now use the same terminology and work in the same way.\r\nAlso, change semantics.mojom to use an enumeration of actions instead of\r\nhaving a separate method per action. This will hopefully scale better.","created_at":"2016-06-29T03:28:26Z","updated_at":"2016-06-29T05:28:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"22bc70339b974b05d3f3db9430ce7b692734d1dd","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/flutter/engine/pulls/2777/commits","review_comments_url":"https://api.github.com/repos/flutter/engine/pulls/2777/comments","review_comment_url":"https://api.github.com/repos/flutter/engine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flutter/engine/issues/2777/comments","statuses_url":"https://api.github.com/repos/flutter/engine/statuses/374f929c0c0a5b0523837642b18dce3380b4290b","head":{"label":"abarth:semantic_object","ref":"semantic_object","sha":"374f929c0c0a5b0523837642b18dce3380b4290b","user":{"login":"abarth","id":112007,"avatar_url":"https://avatars.githubusercontent.com/u/112007?v=3","gravatar_id":"","url":"https://api.github.com/users/abarth","html_url":"https://github.com/abarth","followers_url":"https://api.github.com/users/abarth/followers","following_url":"https://api.github.com/users/abarth/following{/other_user}","gists_url":"https://api.github.com/users/abarth/gists{/gist_id}","starred_url":"https://api.github.com/users/abarth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abarth/subscriptions","organizations_url":"https://api.github.com/users/abarth/orgs","repos_url":"https://api.github.com/users/abarth/repos","events_url":"https://api.github.com/users/abarth/events{/privacy}","received_events_url":"https://api.github.com/users/abarth/received_events","type":"User","site_admin":false},"repo":{"id":39215675,"name":"engine","full_name":"abarth/engine","owner":{"login":"abarth","id":112007,"avatar_url":"https://avatars.githubusercontent.com/u/112007?v=3","gravatar_id":"","url":"https://api.github.com/users/abarth","html_url":"https://github.com/abarth","followers_url":"https://api.github.com/users/abarth/followers","following_url":"https://api.github.com/users/abarth/following{/other_user}","gists_url":"https://api.github.com/users/abarth/gists{/gist_id}","starred_url":"https://api.github.com/users/abarth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abarth/subscriptions","organizations_url":"https://api.github.com/users/abarth/orgs","repos_url":"https://api.github.com/users/abarth/repos","events_url":"https://api.github.com/users/abarth/events{/privacy}","received_events_url":"https://api.github.com/users/abarth/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/abarth/engine","description":"The Flutter engine","fork":true,"url":"https://api.github.com/repos/abarth/engine","forks_url":"https://api.github.com/repos/abarth/engine/forks","keys_url":"https://api.github.com/repos/abarth/engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/abarth/engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/abarth/engine/teams","hooks_url":"https://api.github.com/repos/abarth/engine/hooks","issue_events_url":"https://api.github.com/repos/abarth/engine/issues/events{/number}","events_url":"https://api.github.com/repos/abarth/engine/events","assignees_url":"https://api.github.com/repos/abarth/engine/assignees{/user}","branches_url":"https://api.github.com/repos/abarth/engine/branches{/branch}","tags_url":"https://api.github.com/repos/abarth/engine/tags","blobs_url":"https://api.github.com/repos/abarth/engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/abarth/engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/abarth/engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/abarth/engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/abarth/engine/statuses/{sha}","languages_url":"https://api.github.com/repos/abarth/engine/languages","stargazers_url":"https://api.github.com/repos/abarth/engine/stargazers","contributors_url":"https://api.github.com/repos/abarth/engine/contributors","subscribers_url":"https://api.github.com/repos/abarth/engine/subscribers","subscription_url":"https://api.github.com/repos/abarth/engine/subscription","commits_url":"https://api.github.com/repos/abarth/engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/abarth/engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/abarth/engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/abarth/engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/abarth/engine/contents/{+path}","compare_url":"https://api.github.com/repos/abarth/engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/abarth/engine/merges","archive_url":"https://api.github.com/repos/abarth/engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/abarth/engine/downloads","issues_url":"https://api.github.com/repos/abarth/engine/issues{/number}","pulls_url":"https://api.github.com/repos/abarth/engine/pulls{/number}","milestones_url":"https://api.github.com/repos/abarth/engine/milestones{/number}","notifications_url":"https://api.github.com/repos/abarth/engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/abarth/engine/labels{/name}","releases_url":"https://api.github.com/repos/abarth/engine/releases{/id}","deployments_url":"https://api.github.com/repos/abarth/engine/deployments","created_at":"2015-07-16T19:18:24Z","updated_at":"2016-05-31T16:04:21Z","pushed_at":"2016-06-29T03:28:17Z","git_url":"git://github.com/abarth/engine.git","ssh_url":"git@github.com:abarth/engine.git","clone_url":"https://github.com/abarth/engine.git","svn_url":"https://github.com/abarth/engine","homepage":"http://flutter.io","size":84874,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"flutter:master","ref":"master","sha":"93753789bbec9e62eb670f478580287d9787ed9f","user":{"login":"flutter","id":14101776,"avatar_url":"https://avatars.githubusercontent.com/u/14101776?v=3","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"repo":{"id":39211337,"name":"engine","full_name":"flutter/engine","owner":{"login":"flutter","id":14101776,"avatar_url":"https://avatars.githubusercontent.com/u/14101776?v=3","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/flutter/engine","description":"The Flutter engine","fork":false,"url":"https://api.github.com/repos/flutter/engine","forks_url":"https://api.github.com/repos/flutter/engine/forks","keys_url":"https://api.github.com/repos/flutter/engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flutter/engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flutter/engine/teams","hooks_url":"https://api.github.com/repos/flutter/engine/hooks","issue_events_url":"https://api.github.com/repos/flutter/engine/issues/events{/number}","events_url":"https://api.github.com/repos/flutter/engine/events","assignees_url":"https://api.github.com/repos/flutter/engine/assignees{/user}","branches_url":"https://api.github.com/repos/flutter/engine/branches{/branch}","tags_url":"https://api.github.com/repos/flutter/engine/tags","blobs_url":"https://api.github.com/repos/flutter/engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flutter/engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flutter/engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/flutter/engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flutter/engine/statuses/{sha}","languages_url":"https://api.github.com/repos/flutter/engine/languages","stargazers_url":"https://api.github.com/repos/flutter/engine/stargazers","contributors_url":"https://api.github.com/repos/flutter/engine/contributors","subscribers_url":"https://api.github.com/repos/flutter/engine/subscribers","subscription_url":"https://api.github.com/repos/flutter/engine/subscription","commits_url":"https://api.github.com/repos/flutter/engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/flutter/engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/flutter/engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/flutter/engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/flutter/engine/contents/{+path}","compare_url":"https://api.github.com/repos/flutter/engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flutter/engine/merges","archive_url":"https://api.github.com/repos/flutter/engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flutter/engine/downloads","issues_url":"https://api.github.com/repos/flutter/engine/issues{/number}","pulls_url":"https://api.github.com/repos/flutter/engine/pulls{/number}","milestones_url":"https://api.github.com/repos/flutter/engine/milestones{/number}","notifications_url":"https://api.github.com/repos/flutter/engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flutter/engine/labels{/name}","releases_url":"https://api.github.com/repos/flutter/engine/releases{/id}","deployments_url":"https://api.github.com/repos/flutter/engine/deployments","created_at":"2015-07-16T17:39:56Z","updated_at":"2016-06-27T05:16:58Z","pushed_at":"2016-06-29T03:28:27Z","git_url":"git://github.com/flutter/engine.git","ssh_url":"git@github.com:flutter/engine.git","clone_url":"https://github.com/flutter/engine.git","svn_url":"https://github.com/flutter/engine","homepage":"http://flutter.io","size":104824,"stargazers_count":874,"watchers_count":874,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":148,"mirror_url":null,"open_issues_count":4,"forks":148,"open_issues":4,"watchers":874,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flutter/engine/pulls/2777"},"html":{"href":"https://github.com/flutter/engine/pull/2777"},"issue":{"href":"https://api.github.com/repos/flutter/engine/issues/2777"},"comments":{"href":"https://api.github.com/repos/flutter/engine/issues/2777/comments"},"review_comments":{"href":"https://api.github.com/repos/flutter/engine/pulls/2777/comments"},"review_comment":{"href":"https://api.github.com/repos/flutter/engine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flutter/engine/pulls/2777/commits"},"statuses":{"href":"https://api.github.com/repos/flutter/engine/statuses/374f929c0c0a5b0523837642b18dce3380b4290b"}}}}
{"actor":{"display_login":"tvolkert"}}