{"action":"created","comment":{"url":"https://api.github.com/repos/ucb-bar/rocket-chip/pulls/comments/84800012","pull_request_review_id":5554735,"id":84800012,"diff_hunk":"@@ -398,6 +413,7 @@ class TileLinkIONarrower(innerTLId: String, outerTLId: String)\n   val shrink = iacq.a_type === Acquire.getBlockType\n   val smallput = iacq.a_type === Acquire.putType\n   val smallget = iacq.a_type === Acquire.getType\n+  val atomic = iacq.a_type === Acquire.putAtomicType","path":"src/main/scala/uncore/converters/Tilelink.scala","position":47,"original_position":47,"commit_id":"95cfa1669f3520a2957cc9bf3c4881d018772d59","original_commit_id":"95cfa1669f3520a2957cc9bf3c4881d018772d59","user":{"login":"hcook","id":461938,"avatar_url":"https://avatars.githubusercontent.com/u/461938?v=3","gravatar_id":"","url":"https://api.github.com/users/hcook","html_url":"https://github.com/hcook","followers_url":"https://api.github.com/users/hcook/followers","following_url":"https://api.github.com/users/hcook/following{/other_user}","gists_url":"https://api.github.com/users/hcook/gists{/gist_id}","starred_url":"https://api.github.com/users/hcook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hcook/subscriptions","organizations_url":"https://api.github.com/users/hcook/orgs","repos_url":"https://api.github.com/users/hcook/repos","events_url":"https://api.github.com/users/hcook/events{/privacy}","received_events_url":"https://api.github.com/users/hcook/received_events","type":"User","site_admin":false},"body":"do you need assertions on the outer size similar to the ones on smallput and smallget below (line 446)?","created_at":"2016-10-24T22:46:32Z","updated_at":"2016-10-24T22:46:32Z","html_url":"https://github.com/ucb-bar/rocket-chip/pull/413#discussion_r84800012","pull_request_url":"https://api.github.com/repos/ucb-bar/rocket-chip/pulls/413","_links":{"self":{"href":"https://api.github.com/repos/ucb-bar/rocket-chip/pulls/comments/84800012"},"html":{"href":"https://github.com/ucb-bar/rocket-chip/pull/413#discussion_r84800012"},"pull_request":{"href":"https://api.github.com/repos/ucb-bar/rocket-chip/pulls/413"}}},"pull_request":{"url":"https://api.github.com/repos/ucb-bar/rocket-chip/pulls/413","id":90683183,"html_url":"https://github.com/ucb-bar/rocket-chip/pull/413","diff_url":"https://github.com/ucb-bar/rocket-chip/pull/413.diff","patch_url":"https://github.com/ucb-bar/rocket-chip/pull/413.patch","issue_url":"https://api.github.com/repos/ucb-bar/rocket-chip/issues/413","number":413,"state":"open","locked":false,"title":"Add PutAtomic support to width adapters","user":{"login":"zhemao","id":433799,"avatar_url":"https://avatars.githubusercontent.com/u/433799?v=3","gravatar_id":"","url":"https://api.github.com/users/zhemao","html_url":"https://github.com/zhemao","followers_url":"https://api.github.com/users/zhemao/followers","following_url":"https://api.github.com/users/zhemao/following{/other_user}","gists_url":"https://api.github.com/users/zhemao/gists{/gist_id}","starred_url":"https://api.github.com/users/zhemao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhemao/subscriptions","organizations_url":"https://api.github.com/users/zhemao/orgs","repos_url":"https://api.github.com/users/zhemao/repos","events_url":"https://api.github.com/users/zhemao/events{/privacy}","received_events_url":"https://api.github.com/users/zhemao/received_events","type":"User","site_admin":false},"body":"The TileLink widener and narrower did not support PutAtomic operations, so they were not passing through correctly. This commit fixes that issue and adds a unittest.","created_at":"2016-10-24T20:09:39Z","updated_at":"2016-10-24T22:46:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"898e572d93ca86e74e4aa8cb0025ec949f45960a","assignee":{"login":"hcook","id":461938,"avatar_url":"https://avatars.githubusercontent.com/u/461938?v=3","gravatar_id":"","url":"https://api.github.com/users/hcook","html_url":"https://github.com/hcook","followers_url":"https://api.github.com/users/hcook/followers","following_url":"https://api.github.com/users/hcook/following{/other_user}","gists_url":"https://api.github.com/users/hcook/gists{/gist_id}","starred_url":"https://api.github.com/users/hcook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hcook/subscriptions","organizations_url":"https://api.github.com/users/hcook/orgs","repos_url":"https://api.github.com/users/hcook/repos","events_url":"https://api.github.com/users/hcook/events{/privacy}","received_events_url":"https://api.github.com/users/hcook/received_events","type":"User","site_admin":false},"assignees":[{"login":"hcook","id":461938,"avatar_url":"https://avatars.githubusercontent.com/u/461938?v=3","gravatar_id":"","url":"https://api.github.com/users/hcook","html_url":"https://github.com/hcook","followers_url":"https://api.github.com/users/hcook/followers","following_url":"https://api.github.com/users/hcook/following{/other_user}","gists_url":"https://api.github.com/users/hcook/gists{/gist_id}","starred_url":"https://api.github.com/users/hcook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hcook/subscriptions","organizations_url":"https://api.github.com/users/hcook/orgs","repos_url":"https://api.github.com/users/hcook/repos","events_url":"https://api.github.com/users/hcook/events{/privacy}","received_events_url":"https://api.github.com/users/hcook/received_events","type":"User","site_admin":false},{"login":"terpstra","id":1101706,"avatar_url":"https://avatars.githubusercontent.com/u/1101706?v=3","gravatar_id":"","url":"https://api.github.com/users/terpstra","html_url":"https://github.com/terpstra","followers_url":"https://api.github.com/users/terpstra/followers","following_url":"https://api.github.com/users/terpstra/following{/other_user}","gists_url":"https://api.github.com/users/terpstra/gists{/gist_id}","starred_url":"https://api.github.com/users/terpstra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terpstra/subscriptions","organizations_url":"https://api.github.com/users/terpstra/orgs","repos_url":"https://api.github.com/users/terpstra/repos","events_url":"https://api.github.com/users/terpstra/events{/privacy}","received_events_url":"https://api.github.com/users/terpstra/received_events","type":"User","site_admin":false},{"login":"colinschmidt","id":5083958,"avatar_url":"https://avatars.githubusercontent.com/u/5083958?v=3","gravatar_id":"","url":"https://api.github.com/users/colinschmidt","html_url":"https://github.com/colinschmidt","followers_url":"https://api.github.com/users/colinschmidt/followers","following_url":"https://api.github.com/users/colinschmidt/following{/other_user}","gists_url":"https://api.github.com/users/colinschmidt/gists{/gist_id}","starred_url":"https://api.github.com/users/colinschmidt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colinschmidt/subscriptions","organizations_url":"https://api.github.com/users/colinschmidt/orgs","repos_url":"https://api.github.com/users/colinschmidt/repos","events_url":"https://api.github.com/users/colinschmidt/events{/privacy}","received_events_url":"https://api.github.com/users/colinschmidt/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ucb-bar/rocket-chip/pulls/413/commits","review_comments_url":"https://api.github.com/repos/ucb-bar/rocket-chip/pulls/413/comments","review_comment_url":"https://api.github.com/repos/ucb-bar/rocket-chip/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ucb-bar/rocket-chip/issues/413/comments","statuses_url":"https://api.github.com/repos/ucb-bar/rocket-chip/statuses/95cfa1669f3520a2957cc9bf3c4881d018772d59","head":{"label":"ucb-bar:width-adapter-atomics","ref":"width-adapter-atomics","sha":"95cfa1669f3520a2957cc9bf3c4881d018772d59","user":{"login":"ucb-bar","id":998197,"avatar_url":"https://avatars.githubusercontent.com/u/998197?v=3","gravatar_id":"","url":"https://api.github.com/users/ucb-bar","html_url":"https://github.com/ucb-bar","followers_url":"https://api.github.com/users/ucb-bar/followers","following_url":"https://api.github.com/users/ucb-bar/following{/other_user}","gists_url":"https://api.github.com/users/ucb-bar/gists{/gist_id}","starred_url":"https://api.github.com/users/ucb-bar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ucb-bar/subscriptions","organizations_url":"https://api.github.com/users/ucb-bar/orgs","repos_url":"https://api.github.com/users/ucb-bar/repos","events_url":"https://api.github.com/users/ucb-bar/events{/privacy}","received_events_url":"https://api.github.com/users/ucb-bar/received_events","type":"Organization","site_admin":false},"repo":{"id":23950406,"name":"rocket-chip","full_name":"ucb-bar/rocket-chip","owner":{"login":"ucb-bar","id":998197,"avatar_url":"https://avatars.githubusercontent.com/u/998197?v=3","gravatar_id":"","url":"https://api.github.com/users/ucb-bar","html_url":"https://github.com/ucb-bar","followers_url":"https://api.github.com/users/ucb-bar/followers","following_url":"https://api.github.com/users/ucb-bar/following{/other_user}","gists_url":"https://api.github.com/users/ucb-bar/gists{/gist_id}","starred_url":"https://api.github.com/users/ucb-bar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ucb-bar/subscriptions","organizations_url":"https://api.github.com/users/ucb-bar/orgs","repos_url":"https://api.github.com/users/ucb-bar/repos","events_url":"https://api.github.com/users/ucb-bar/events{/privacy}","received_events_url":"https://api.github.com/users/ucb-bar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ucb-bar/rocket-chip","description":"Rocket Chip Generator","fork":false,"url":"https://api.github.com/repos/ucb-bar/rocket-chip","forks_url":"https://api.github.com/repos/ucb-bar/rocket-chip/forks","keys_url":"https://api.github.com/repos/ucb-bar/rocket-chip/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ucb-bar/rocket-chip/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ucb-bar/rocket-chip/teams","hooks_url":"https://api.github.com/repos/ucb-bar/rocket-chip/hooks","issue_events_url":"https://api.github.com/repos/ucb-bar/rocket-chip/issues/events{/number}","events_url":"https://api.github.com/repos/ucb-bar/rocket-chip/events","assignees_url":"https://api.github.com/repos/ucb-bar/rocket-chip/assignees{/user}","branches_url":"https://api.github.com/repos/ucb-bar/rocket-chip/branches{/branch}","tags_url":"https://api.github.com/repos/ucb-bar/rocket-chip/tags","blobs_url":"https://api.github.com/repos/ucb-bar/rocket-chip/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ucb-bar/rocket-chip/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ucb-bar/rocket-chip/git/refs{/sha}","trees_url":"https://api.github.com/repos/ucb-bar/rocket-chip/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ucb-bar/rocket-chip/statuses/{sha}","languages_url":"https://api.github.com/repos/ucb-bar/rocket-chip/languages","stargazers_url":"https://api.github.com/repos/ucb-bar/rocket-chip/stargazers","contributors_url":"https://api.github.com/repos/ucb-bar/rocket-chip/contributors","subscribers_url":"https://api.github.com/repos/ucb-bar/rocket-chip/subscribers","subscription_url":"https://api.github.com/repos/ucb-bar/rocket-chip/subscription","commits_url":"https://api.github.com/repos/ucb-bar/rocket-chip/commits{/sha}","git_commits_url":"https://api.github.com/repos/ucb-bar/rocket-chip/git/commits{/sha}","comments_url":"https://api.github.com/repos/ucb-bar/rocket-chip/comments{/number}","issue_comment_url":"https://api.github.com/repos/ucb-bar/rocket-chip/issues/comments{/number}","contents_url":"https://api.github.com/repos/ucb-bar/rocket-chip/contents/{+path}","compare_url":"https://api.github.com/repos/ucb-bar/rocket-chip/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ucb-bar/rocket-chip/merges","archive_url":"https://api.github.com/repos/ucb-bar/rocket-chip/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ucb-bar/rocket-chip/downloads","issues_url":"https://api.github.com/repos/ucb-bar/rocket-chip/issues{/number}","pulls_url":"https://api.github.com/repos/ucb-bar/rocket-chip/pulls{/number}","milestones_url":"https://api.github.com/repos/ucb-bar/rocket-chip/milestones{/number}","notifications_url":"https://api.github.com/repos/ucb-bar/rocket-chip/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ucb-bar/rocket-chip/labels{/name}","releases_url":"https://api.github.com/repos/ucb-bar/rocket-chip/releases{/id}","deployments_url":"https://api.github.com/repos/ucb-bar/rocket-chip/deployments","created_at":"2014-09-12T07:04:30Z","updated_at":"2016-10-22T04:02:08Z","pushed_at":"2016-10-24T22:01:41Z","git_url":"git://github.com/ucb-bar/rocket-chip.git","ssh_url":"git@github.com:ucb-bar/rocket-chip.git","clone_url":"https://github.com/ucb-bar/rocket-chip.git","svn_url":"https://github.com/ucb-bar/rocket-chip","homepage":null,"size":16356,"stargazers_count":172,"watchers_count":172,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":93,"mirror_url":null,"open_issues_count":17,"forks":93,"open_issues":17,"watchers":172,"default_branch":"master"}},"base":{"label":"ucb-bar:master","ref":"master","sha":"737cf82478bdf7d97d198bf3ff0d4573070c9e24","user":{"login":"ucb-bar","id":998197,"avatar_url":"https://avatars.githubusercontent.com/u/998197?v=3","gravatar_id":"","url":"https://api.github.com/users/ucb-bar","html_url":"https://github.com/ucb-bar","followers_url":"https://api.github.com/users/ucb-bar/followers","following_url":"https://api.github.com/users/ucb-bar/following{/other_user}","gists_url":"https://api.github.com/users/ucb-bar/gists{/gist_id}","starred_url":"https://api.github.com/users/ucb-bar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ucb-bar/subscriptions","organizations_url":"https://api.github.com/users/ucb-bar/orgs","repos_url":"https://api.github.com/users/ucb-bar/repos","events_url":"https://api.github.com/users/ucb-bar/events{/privacy}","received_events_url":"https://api.github.com/users/ucb-bar/received_events","type":"Organization","site_admin":false},"repo":{"id":23950406,"name":"rocket-chip","full_name":"ucb-bar/rocket-chip","owner":{"login":"ucb-bar","id":998197,"avatar_url":"https://avatars.githubusercontent.com/u/998197?v=3","gravatar_id":"","url":"https://api.github.com/users/ucb-bar","html_url":"https://github.com/ucb-bar","followers_url":"https://api.github.com/users/ucb-bar/followers","following_url":"https://api.github.com/users/ucb-bar/following{/other_user}","gists_url":"https://api.github.com/users/ucb-bar/gists{/gist_id}","starred_url":"https://api.github.com/users/ucb-bar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ucb-bar/subscriptions","organizations_url":"https://api.github.com/users/ucb-bar/orgs","repos_url":"https://api.github.com/users/ucb-bar/repos","events_url":"https://api.github.com/users/ucb-bar/events{/privacy}","received_events_url":"https://api.github.com/users/ucb-bar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ucb-bar/rocket-chip","description":"Rocket Chip Generator","fork":false,"url":"https://api.github.com/repos/ucb-bar/rocket-chip","forks_url":"https://api.github.com/repos/ucb-bar/rocket-chip/forks","keys_url":"https://api.github.com/repos/ucb-bar/rocket-chip/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ucb-bar/rocket-chip/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ucb-bar/rocket-chip/teams","hooks_url":"https://api.github.com/repos/ucb-bar/rocket-chip/hooks","issue_events_url":"https://api.github.com/repos/ucb-bar/rocket-chip/issues/events{/number}","events_url":"https://api.github.com/repos/ucb-bar/rocket-chip/events","assignees_url":"https://api.github.com/repos/ucb-bar/rocket-chip/assignees{/user}","branches_url":"https://api.github.com/repos/ucb-bar/rocket-chip/branches{/branch}","tags_url":"https://api.github.com/repos/ucb-bar/rocket-chip/tags","blobs_url":"https://api.github.com/repos/ucb-bar/rocket-chip/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ucb-bar/rocket-chip/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ucb-bar/rocket-chip/git/refs{/sha}","trees_url":"https://api.github.com/repos/ucb-bar/rocket-chip/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ucb-bar/rocket-chip/statuses/{sha}","languages_url":"https://api.github.com/repos/ucb-bar/rocket-chip/languages","stargazers_url":"https://api.github.com/repos/ucb-bar/rocket-chip/stargazers","contributors_url":"https://api.github.com/repos/ucb-bar/rocket-chip/contributors","subscribers_url":"https://api.github.com/repos/ucb-bar/rocket-chip/subscribers","subscription_url":"https://api.github.com/repos/ucb-bar/rocket-chip/subscription","commits_url":"https://api.github.com/repos/ucb-bar/rocket-chip/commits{/sha}","git_commits_url":"https://api.github.com/repos/ucb-bar/rocket-chip/git/commits{/sha}","comments_url":"https://api.github.com/repos/ucb-bar/rocket-chip/comments{/number}","issue_comment_url":"https://api.github.com/repos/ucb-bar/rocket-chip/issues/comments{/number}","contents_url":"https://api.github.com/repos/ucb-bar/rocket-chip/contents/{+path}","compare_url":"https://api.github.com/repos/ucb-bar/rocket-chip/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ucb-bar/rocket-chip/merges","archive_url":"https://api.github.com/repos/ucb-bar/rocket-chip/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ucb-bar/rocket-chip/downloads","issues_url":"https://api.github.com/repos/ucb-bar/rocket-chip/issues{/number}","pulls_url":"https://api.github.com/repos/ucb-bar/rocket-chip/pulls{/number}","milestones_url":"https://api.github.com/repos/ucb-bar/rocket-chip/milestones{/number}","notifications_url":"https://api.github.com/repos/ucb-bar/rocket-chip/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ucb-bar/rocket-chip/labels{/name}","releases_url":"https://api.github.com/repos/ucb-bar/rocket-chip/releases{/id}","deployments_url":"https://api.github.com/repos/ucb-bar/rocket-chip/deployments","created_at":"2014-09-12T07:04:30Z","updated_at":"2016-10-22T04:02:08Z","pushed_at":"2016-10-24T22:01:41Z","git_url":"git://github.com/ucb-bar/rocket-chip.git","ssh_url":"git@github.com:ucb-bar/rocket-chip.git","clone_url":"https://github.com/ucb-bar/rocket-chip.git","svn_url":"https://github.com/ucb-bar/rocket-chip","homepage":null,"size":16356,"stargazers_count":172,"watchers_count":172,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":93,"mirror_url":null,"open_issues_count":17,"forks":93,"open_issues":17,"watchers":172,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ucb-bar/rocket-chip/pulls/413"},"html":{"href":"https://github.com/ucb-bar/rocket-chip/pull/413"},"issue":{"href":"https://api.github.com/repos/ucb-bar/rocket-chip/issues/413"},"comments":{"href":"https://api.github.com/repos/ucb-bar/rocket-chip/issues/413/comments"},"review_comments":{"href":"https://api.github.com/repos/ucb-bar/rocket-chip/pulls/413/comments"},"review_comment":{"href":"https://api.github.com/repos/ucb-bar/rocket-chip/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ucb-bar/rocket-chip/pulls/413/commits"},"statuses":{"href":"https://api.github.com/repos/ucb-bar/rocket-chip/statuses/95cfa1669f3520a2957cc9bf3c4881d018772d59"}}}}
{"actor":{"display_login":"hcook"}}