{"action":"created","issue":{"url":"https://api.github.com/repos/apache/spark/issues/14454","repository_url":"https://api.github.com/repos/apache/spark","labels_url":"https://api.github.com/repos/apache/spark/issues/14454/labels{/name}","comments_url":"https://api.github.com/repos/apache/spark/issues/14454/comments","events_url":"https://api.github.com/repos/apache/spark/issues/14454/events","html_url":"https://github.com/apache/spark/pull/14454","id":168810303,"number":14454,"title":"[Minor] [ML] Rename TreeEnsembleModels to TreeEnsembleModel for PySpark","user":{"login":"yanboliang","id":1962026,"avatar_url":"https://avatars.githubusercontent.com/u/1962026?v=3","gravatar_id":"","url":"https://api.github.com/users/yanboliang","html_url":"https://github.com/yanboliang","followers_url":"https://api.github.com/users/yanboliang/followers","following_url":"https://api.github.com/users/yanboliang/following{/other_user}","gists_url":"https://api.github.com/users/yanboliang/gists{/gist_id}","starred_url":"https://api.github.com/users/yanboliang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yanboliang/subscriptions","organizations_url":"https://api.github.com/users/yanboliang/orgs","repos_url":"https://api.github.com/users/yanboliang/repos","events_url":"https://api.github.com/users/yanboliang/events{/privacy}","received_events_url":"https://api.github.com/users/yanboliang/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-08-02T06:37:41Z","updated_at":"2016-08-07T09:17:45Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/14454","html_url":"https://github.com/apache/spark/pull/14454","diff_url":"https://github.com/apache/spark/pull/14454.diff","patch_url":"https://github.com/apache/spark/pull/14454.patch"},"body":"## What changes were proposed in this pull request?\r\nFix the typo of ```TreeEnsembleModels``` for PySpark, it should ```TreeEnsembleModel``` which will be consistent with Scala. What's more, it represents a tree ensemble model, so  ```TreeEnsembleModel``` should be more reasonable. This should not be used public, so it will not involve  breaking change.\r\n\r\n## How was this patch tested?\r\nNo new tests, should pass existing ones.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/apache/spark/issues/comments/238072220","html_url":"https://github.com/apache/spark/pull/14454#issuecomment-238072220","issue_url":"https://api.github.com/repos/apache/spark/issues/14454","id":238072220,"user":{"login":"srowen","id":822522,"avatar_url":"https://avatars.githubusercontent.com/u/822522?v=3","gravatar_id":"","url":"https://api.github.com/users/srowen","html_url":"https://github.com/srowen","followers_url":"https://api.github.com/users/srowen/followers","following_url":"https://api.github.com/users/srowen/following{/other_user}","gists_url":"https://api.github.com/users/srowen/gists{/gist_id}","starred_url":"https://api.github.com/users/srowen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srowen/subscriptions","organizations_url":"https://api.github.com/users/srowen/orgs","repos_url":"https://api.github.com/users/srowen/repos","events_url":"https://api.github.com/users/srowen/events{/privacy}","received_events_url":"https://api.github.com/users/srowen/received_events","type":"User","site_admin":false},"created_at":"2016-08-07T09:17:45Z","updated_at":"2016-08-07T09:17:45Z","body":"Hm, though it ends up being exposed in Python, no? that's what I'm concerned about. If it's just a rename, yeah I agree ideally we'd do it but am not clear it's worth the possible breakage. Unless someone does confirm that really nobody should be using this directly in Python."}}
{"actor":{"display_login":"srowen"}}