{"action":"created","issue":{"url":"https://api.github.com/repos/schibsted/sdk-js/issues/57","repository_url":"https://api.github.com/repos/schibsted/sdk-js","labels_url":"https://api.github.com/repos/schibsted/sdk-js/issues/57/labels{/name}","comments_url":"https://api.github.com/repos/schibsted/sdk-js/issues/57/comments","events_url":"https://api.github.com/repos/schibsted/sdk-js/issues/57/events","html_url":"https://github.com/schibsted/sdk-js/issues/57","id":170130974,"number":57,"title":"Incorrect description of behavior in docs","user":{"login":"kjarmicki","id":1783785,"avatar_url":"https://avatars.githubusercontent.com/u/1783785?v=3","gravatar_id":"","url":"https://api.github.com/users/kjarmicki","html_url":"https://github.com/kjarmicki","followers_url":"https://api.github.com/users/kjarmicki/followers","following_url":"https://api.github.com/users/kjarmicki/following{/other_user}","gists_url":"https://api.github.com/users/kjarmicki/gists{/gist_id}","starred_url":"https://api.github.com/users/kjarmicki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kjarmicki/subscriptions","organizations_url":"https://api.github.com/users/kjarmicki/orgs","repos_url":"https://api.github.com/users/kjarmicki/repos","events_url":"https://api.github.com/users/kjarmicki/events{/privacy}","received_events_url":"https://api.github.com/users/kjarmicki/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-08-09T10:16:25Z","updated_at":"2016-08-15T15:06:34Z","closed_at":null,"body":"At http://techdocs.spid.no/sdks/js/events/ it states:\r\n```\r\nSPiD.login\t\r\n(...)\r\nPage loads, user is already logged in\r\n```\r\n\r\nThis is incorrect, `login` event is fired once - when user actually logs in, not if the session is already stored in cache (and valid).\r\n\r\nThis can be approached in two ways:\r\n- change the description in the docs to fit the behavior and provide another event that's fired when session cache is already populated\r\n- fix login event to match behavior described in docs"},"comment":{"url":"https://api.github.com/repos/schibsted/sdk-js/issues/comments/239826745","html_url":"https://github.com/schibsted/sdk-js/issues/57#issuecomment-239826745","issue_url":"https://api.github.com/repos/schibsted/sdk-js/issues/57","id":239826745,"user":{"login":"danielbentes","id":158701,"avatar_url":"https://avatars.githubusercontent.com/u/158701?v=3","gravatar_id":"","url":"https://api.github.com/users/danielbentes","html_url":"https://github.com/danielbentes","followers_url":"https://api.github.com/users/danielbentes/followers","following_url":"https://api.github.com/users/danielbentes/following{/other_user}","gists_url":"https://api.github.com/users/danielbentes/gists{/gist_id}","starred_url":"https://api.github.com/users/danielbentes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielbentes/subscriptions","organizations_url":"https://api.github.com/users/danielbentes/orgs","repos_url":"https://api.github.com/users/danielbentes/repos","events_url":"https://api.github.com/users/danielbentes/events{/privacy}","received_events_url":"https://api.github.com/users/danielbentes/received_events","type":"User","site_admin":false},"created_at":"2016-08-15T15:06:34Z","updated_at":"2016-08-15T15:06:34Z","body":"I don't have data about other clients. But in any case, this should be announced as a braking change for the version with this fixed."}}
{"actor":{"display_login":"danielbentes"}}