{"action":"closed","number":180,"pull_request":{"url":"https://api.github.com/repos/PBSPro/pbspro/pulls/180","id":89948006,"html_url":"https://github.com/PBSPro/pbspro/pull/180","diff_url":"https://github.com/PBSPro/pbspro/pull/180.diff","patch_url":"https://github.com/PBSPro/pbspro/pull/180.patch","issue_url":"https://api.github.com/repos/PBSPro/pbspro/issues/180","number":180,"state":"closed","locked":false,"title":"PP-472: PP-492: Admin must be able to set the PBS_HOME, PBS_SERVER and PBS_DATA_SERVICE_USER value at install time & pbs_postinstall fails due to hard coded path.","user":{"login":"bremanandjk","id":17980660,"avatar_url":"https://avatars.githubusercontent.com/u/17980660?v=3","gravatar_id":"","url":"https://api.github.com/users/bremanandjk","html_url":"https://github.com/bremanandjk","followers_url":"https://api.github.com/users/bremanandjk/followers","following_url":"https://api.github.com/users/bremanandjk/following{/other_user}","gists_url":"https://api.github.com/users/bremanandjk/gists{/gist_id}","starred_url":"https://api.github.com/users/bremanandjk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bremanandjk/subscriptions","organizations_url":"https://api.github.com/users/bremanandjk/orgs","repos_url":"https://api.github.com/users/bremanandjk/repos","events_url":"https://api.github.com/users/bremanandjk/events{/privacy}","received_events_url":"https://api.github.com/users/bremanandjk/received_events","type":"User","site_admin":false},"body":"<!--- Please review your changes in preview mode -->\r\n<!--- Provide a general summary of your changes in the Title above -->\r\n\r\n#### Issue-ID\r\n<!--- Replace PP-472 below (2 places) with the actual JIRA id -->\r\n* **[PP-472](https://pbspro.atlassian.net/browse/PP-472)**\r\n* **[PP-492](https://pbspro.atlassian.net/browse/PP-492)**\r\n\r\n#### Problem description\r\n \r\n-  As an admin, I must be able to set the PBS_SERVER value at install time, so I do not have to perform additional configuration steps after installation to have a functional installation on my commands/execution hosts.\r\n-     As an admin, I want to be able to set the PBS_HOME location at install time, so I do not have to perform additional configuration steps after installation to move it to where I want it to be.\r\n-     As an admin, I want to be able to set a value for PBS_DATA_SERVICE_USER to an existing user acount at install time, so I do not have to perform additional configuration steps after installation to run the PBS data service as my desired user account.\r\n-     pbs_postinstall fails due to hard coded path.\r\n\r\n#### Cause / Analysis\r\n* PBS installations scripts are not reading environment variables (PBS_SERVER, PBS_HOME, PBS_DATA_SERVICE_USER)\r\n\r\n#### Solution description\r\n* Changes are in pbs_postinstall script to read environment variables. a) PBS_HOME b) PBS_SERVER and c) PBS_DATA_SERVER_USER\r\n* pbs_postinstall fails due to hard coded path. Have modified to configured variable.\r\n\r\n#### Checklist:\r\n<!--- Use the preview button to see the checkboxes/links properly. -->\r\n<!--- Go over the following points, and put an `x` (without spaces around it) in the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] I have joined the **[pbspro community forum](http://community.pbspro.org/)**.\r\n- [x] My pull request contains a **single, signed** commit. See **[setting up gpg signature](https://pbspro.atlassian.net/wiki/display/DG/Signing+Your+Git+Commits)**.\r\n- [x] My code follows the **[coding style](https://pbspro.atlassian.net/wiki/display/DG/Coding+Standards)** of this project.\r\n- [x] My change requires project documentation. See **[required documentation checklist](https://pbspro.atlassian.net/wiki/display/DG/Checklist+for+Developing+Features+and+Bug+Fixes)** for details.\r\n- [x] I have added documentation in the **[project documentation area](https://pbspro.atlassian.net/wiki/display/PD)**.\r\n- [ ] I have added new **PTL test(s) to my commit**. (See **[using PTL for testing](https://pbspro.atlassian.net/wiki/display/DG/Using+PTL+for+Testing)**) *(or)*\r\n- [x] I have added  **manual test(s) to the Jira ticket and explained why PTL is not appropriate** for this case.\r\n- [x] All new and existing automated tests have passed. (See **[running automated PTL tests](https://pbspro.atlassian.net/wiki/display/DG/PTL+Quick+Start+Guide)**).\r\n- [x] I have attached **test logs to the Jira ticket** as evidence of testing/verification.\r\n\r\n\r\n__***For further information please visit the [Developer Guide Home](https://pbspro.atlassian.net/wiki/display/DG/Developer+Guide+Home).***__\r\n","created_at":"2016-10-19T06:19:26Z","updated_at":"2016-10-19T09:28:50Z","closed_at":"2016-10-19T09:28:50Z","merged_at":"2016-10-19T09:28:50Z","merge_commit_sha":"6733daa7c24ca65c2975908d930d43b18f21caec","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/PBSPro/pbspro/pulls/180/commits","review_comments_url":"https://api.github.com/repos/PBSPro/pbspro/pulls/180/comments","review_comment_url":"https://api.github.com/repos/PBSPro/pbspro/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PBSPro/pbspro/issues/180/comments","statuses_url":"https://api.github.com/repos/PBSPro/pbspro/statuses/6733daa7c24ca65c2975908d930d43b18f21caec","head":{"label":"bremanandjk:PP-472","ref":"PP-472","sha":"6733daa7c24ca65c2975908d930d43b18f21caec","user":{"login":"bremanandjk","id":17980660,"avatar_url":"https://avatars.githubusercontent.com/u/17980660?v=3","gravatar_id":"","url":"https://api.github.com/users/bremanandjk","html_url":"https://github.com/bremanandjk","followers_url":"https://api.github.com/users/bremanandjk/followers","following_url":"https://api.github.com/users/bremanandjk/following{/other_user}","gists_url":"https://api.github.com/users/bremanandjk/gists{/gist_id}","starred_url":"https://api.github.com/users/bremanandjk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bremanandjk/subscriptions","organizations_url":"https://api.github.com/users/bremanandjk/orgs","repos_url":"https://api.github.com/users/bremanandjk/repos","events_url":"https://api.github.com/users/bremanandjk/events{/privacy}","received_events_url":"https://api.github.com/users/bremanandjk/received_events","type":"User","site_admin":false},"repo":{"id":66549617,"name":"pbspro","full_name":"bremanandjk/pbspro","owner":{"login":"bremanandjk","id":17980660,"avatar_url":"https://avatars.githubusercontent.com/u/17980660?v=3","gravatar_id":"","url":"https://api.github.com/users/bremanandjk","html_url":"https://github.com/bremanandjk","followers_url":"https://api.github.com/users/bremanandjk/followers","following_url":"https://api.github.com/users/bremanandjk/following{/other_user}","gists_url":"https://api.github.com/users/bremanandjk/gists{/gist_id}","starred_url":"https://api.github.com/users/bremanandjk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bremanandjk/subscriptions","organizations_url":"https://api.github.com/users/bremanandjk/orgs","repos_url":"https://api.github.com/users/bremanandjk/repos","events_url":"https://api.github.com/users/bremanandjk/events{/privacy}","received_events_url":"https://api.github.com/users/bremanandjk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bremanandjk/pbspro","description":"An HPC workload manager and job scheduler for desktops, clusters, and clouds.","fork":true,"url":"https://api.github.com/repos/bremanandjk/pbspro","forks_url":"https://api.github.com/repos/bremanandjk/pbspro/forks","keys_url":"https://api.github.com/repos/bremanandjk/pbspro/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bremanandjk/pbspro/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bremanandjk/pbspro/teams","hooks_url":"https://api.github.com/repos/bremanandjk/pbspro/hooks","issue_events_url":"https://api.github.com/repos/bremanandjk/pbspro/issues/events{/number}","events_url":"https://api.github.com/repos/bremanandjk/pbspro/events","assignees_url":"https://api.github.com/repos/bremanandjk/pbspro/assignees{/user}","branches_url":"https://api.github.com/repos/bremanandjk/pbspro/branches{/branch}","tags_url":"https://api.github.com/repos/bremanandjk/pbspro/tags","blobs_url":"https://api.github.com/repos/bremanandjk/pbspro/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bremanandjk/pbspro/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bremanandjk/pbspro/git/refs{/sha}","trees_url":"https://api.github.com/repos/bremanandjk/pbspro/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bremanandjk/pbspro/statuses/{sha}","languages_url":"https://api.github.com/repos/bremanandjk/pbspro/languages","stargazers_url":"https://api.github.com/repos/bremanandjk/pbspro/stargazers","contributors_url":"https://api.github.com/repos/bremanandjk/pbspro/contributors","subscribers_url":"https://api.github.com/repos/bremanandjk/pbspro/subscribers","subscription_url":"https://api.github.com/repos/bremanandjk/pbspro/subscription","commits_url":"https://api.github.com/repos/bremanandjk/pbspro/commits{/sha}","git_commits_url":"https://api.github.com/repos/bremanandjk/pbspro/git/commits{/sha}","comments_url":"https://api.github.com/repos/bremanandjk/pbspro/comments{/number}","issue_comment_url":"https://api.github.com/repos/bremanandjk/pbspro/issues/comments{/number}","contents_url":"https://api.github.com/repos/bremanandjk/pbspro/contents/{+path}","compare_url":"https://api.github.com/repos/bremanandjk/pbspro/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bremanandjk/pbspro/merges","archive_url":"https://api.github.com/repos/bremanandjk/pbspro/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bremanandjk/pbspro/downloads","issues_url":"https://api.github.com/repos/bremanandjk/pbspro/issues{/number}","pulls_url":"https://api.github.com/repos/bremanandjk/pbspro/pulls{/number}","milestones_url":"https://api.github.com/repos/bremanandjk/pbspro/milestones{/number}","notifications_url":"https://api.github.com/repos/bremanandjk/pbspro/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bremanandjk/pbspro/labels{/name}","releases_url":"https://api.github.com/repos/bremanandjk/pbspro/releases{/id}","deployments_url":"https://api.github.com/repos/bremanandjk/pbspro/deployments","created_at":"2016-08-25T10:43:37Z","updated_at":"2016-08-25T10:43:43Z","pushed_at":"2016-10-19T06:06:57Z","git_url":"git://github.com/bremanandjk/pbspro.git","ssh_url":"git@github.com:bremanandjk/pbspro.git","clone_url":"https://github.com/bremanandjk/pbspro.git","svn_url":"https://github.com/bremanandjk/pbspro","homepage":"www.pbspro.org","size":5650,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PBSPro:master","ref":"master","sha":"ada357c6cd04fba33df14dc6bb9207f08050f65c","user":{"login":"PBSPro","id":19280436,"avatar_url":"https://avatars.githubusercontent.com/u/19280436?v=3","gravatar_id":"","url":"https://api.github.com/users/PBSPro","html_url":"https://github.com/PBSPro","followers_url":"https://api.github.com/users/PBSPro/followers","following_url":"https://api.github.com/users/PBSPro/following{/other_user}","gists_url":"https://api.github.com/users/PBSPro/gists{/gist_id}","starred_url":"https://api.github.com/users/PBSPro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PBSPro/subscriptions","organizations_url":"https://api.github.com/users/PBSPro/orgs","repos_url":"https://api.github.com/users/PBSPro/repos","events_url":"https://api.github.com/users/PBSPro/events{/privacy}","received_events_url":"https://api.github.com/users/PBSPro/received_events","type":"Organization","site_admin":false},"repo":{"id":59082072,"name":"pbspro","full_name":"PBSPro/pbspro","owner":{"login":"PBSPro","id":19280436,"avatar_url":"https://avatars.githubusercontent.com/u/19280436?v=3","gravatar_id":"","url":"https://api.github.com/users/PBSPro","html_url":"https://github.com/PBSPro","followers_url":"https://api.github.com/users/PBSPro/followers","following_url":"https://api.github.com/users/PBSPro/following{/other_user}","gists_url":"https://api.github.com/users/PBSPro/gists{/gist_id}","starred_url":"https://api.github.com/users/PBSPro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PBSPro/subscriptions","organizations_url":"https://api.github.com/users/PBSPro/orgs","repos_url":"https://api.github.com/users/PBSPro/repos","events_url":"https://api.github.com/users/PBSPro/events{/privacy}","received_events_url":"https://api.github.com/users/PBSPro/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PBSPro/pbspro","description":"An HPC workload manager and job scheduler for desktops, clusters, and clouds.","fork":false,"url":"https://api.github.com/repos/PBSPro/pbspro","forks_url":"https://api.github.com/repos/PBSPro/pbspro/forks","keys_url":"https://api.github.com/repos/PBSPro/pbspro/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PBSPro/pbspro/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PBSPro/pbspro/teams","hooks_url":"https://api.github.com/repos/PBSPro/pbspro/hooks","issue_events_url":"https://api.github.com/repos/PBSPro/pbspro/issues/events{/number}","events_url":"https://api.github.com/repos/PBSPro/pbspro/events","assignees_url":"https://api.github.com/repos/PBSPro/pbspro/assignees{/user}","branches_url":"https://api.github.com/repos/PBSPro/pbspro/branches{/branch}","tags_url":"https://api.github.com/repos/PBSPro/pbspro/tags","blobs_url":"https://api.github.com/repos/PBSPro/pbspro/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PBSPro/pbspro/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PBSPro/pbspro/git/refs{/sha}","trees_url":"https://api.github.com/repos/PBSPro/pbspro/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PBSPro/pbspro/statuses/{sha}","languages_url":"https://api.github.com/repos/PBSPro/pbspro/languages","stargazers_url":"https://api.github.com/repos/PBSPro/pbspro/stargazers","contributors_url":"https://api.github.com/repos/PBSPro/pbspro/contributors","subscribers_url":"https://api.github.com/repos/PBSPro/pbspro/subscribers","subscription_url":"https://api.github.com/repos/PBSPro/pbspro/subscription","commits_url":"https://api.github.com/repos/PBSPro/pbspro/commits{/sha}","git_commits_url":"https://api.github.com/repos/PBSPro/pbspro/git/commits{/sha}","comments_url":"https://api.github.com/repos/PBSPro/pbspro/comments{/number}","issue_comment_url":"https://api.github.com/repos/PBSPro/pbspro/issues/comments{/number}","contents_url":"https://api.github.com/repos/PBSPro/pbspro/contents/{+path}","compare_url":"https://api.github.com/repos/PBSPro/pbspro/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PBSPro/pbspro/merges","archive_url":"https://api.github.com/repos/PBSPro/pbspro/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PBSPro/pbspro/downloads","issues_url":"https://api.github.com/repos/PBSPro/pbspro/issues{/number}","pulls_url":"https://api.github.com/repos/PBSPro/pbspro/pulls{/number}","milestones_url":"https://api.github.com/repos/PBSPro/pbspro/milestones{/number}","notifications_url":"https://api.github.com/repos/PBSPro/pbspro/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PBSPro/pbspro/labels{/name}","releases_url":"https://api.github.com/repos/PBSPro/pbspro/releases{/id}","deployments_url":"https://api.github.com/repos/PBSPro/pbspro/deployments","created_at":"2016-05-18T04:31:29Z","updated_at":"2016-10-15T09:08:45Z","pushed_at":"2016-10-19T09:28:50Z","git_url":"git://github.com/PBSPro/pbspro.git","ssh_url":"git@github.com:PBSPro/pbspro.git","clone_url":"https://github.com/PBSPro/pbspro.git","svn_url":"https://github.com/PBSPro/pbspro","homepage":"www.pbspro.org","size":6318,"stargazers_count":56,"watchers_count":56,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":58,"mirror_url":null,"open_issues_count":3,"forks":58,"open_issues":3,"watchers":56,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PBSPro/pbspro/pulls/180"},"html":{"href":"https://github.com/PBSPro/pbspro/pull/180"},"issue":{"href":"https://api.github.com/repos/PBSPro/pbspro/issues/180"},"comments":{"href":"https://api.github.com/repos/PBSPro/pbspro/issues/180/comments"},"review_comments":{"href":"https://api.github.com/repos/PBSPro/pbspro/pulls/180/comments"},"review_comment":{"href":"https://api.github.com/repos/PBSPro/pbspro/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PBSPro/pbspro/pulls/180/commits"},"statuses":{"href":"https://api.github.com/repos/PBSPro/pbspro/statuses/6733daa7c24ca65c2975908d930d43b18f21caec"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"subhasisb","id":15310678,"avatar_url":"https://avatars.githubusercontent.com/u/15310678?v=3","gravatar_id":"","url":"https://api.github.com/users/subhasisb","html_url":"https://github.com/subhasisb","followers_url":"https://api.github.com/users/subhasisb/followers","following_url":"https://api.github.com/users/subhasisb/following{/other_user}","gists_url":"https://api.github.com/users/subhasisb/gists{/gist_id}","starred_url":"https://api.github.com/users/subhasisb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/subhasisb/subscriptions","organizations_url":"https://api.github.com/users/subhasisb/orgs","repos_url":"https://api.github.com/users/subhasisb/repos","events_url":"https://api.github.com/users/subhasisb/events{/privacy}","received_events_url":"https://api.github.com/users/subhasisb/received_events","type":"User","site_admin":false},"comments":4,"review_comments":0,"commits":1,"additions":32,"deletions":22,"changed_files":3}}
{"actor":{"display_login":"subhasisb"}}