{"action":"created","comment":{"url":"https://api.github.com/repos/jquery/qunit/pulls/comments/59582257","id":59582257,"diff_hunk":"@@ -1,51 +1,42 @@\n-// Deprecated\n-// Extend assert methods to QUnit for Backwards compatibility\n-( function() {\n-\tvar i,\n-\t\tassertions = Assert.prototype;\n+function applyDeprecated( name ) {\n+\treturn function() {\n+\t\tthrow new Error(\n+\t\t\t\"`\" + name + \"` is removed in QUnit 2.0, you should now use the \" +\n+\t\t\t\"correct namespace.\\n\" +\n+\t\t\t\"Details in our upgrade at https://qunitjs.com/upgrade-guide-2.x/\"\n+\t\t);\n+\t};\n+}\n \n-\tfunction applyCurrent( current ) {\n-\t\treturn function() {\n-\t\t\tvar assert = new Assert( QUnit.config.current );\n-\t\t\tcurrent.apply( assert, arguments );\n-\t\t};\n-\t}\n+Object.keys( Assert.prototype ).forEach( function( key ) {\n+\tQUnit[ key ] = applyDeprecated( \"QUnit.\" + key );\n+} );\n \n-\tfor ( i in assertions ) {\n-\t\tQUnit[ i ] = applyCurrent( assertions[ i ] );\n-\t}\n-}() );\n+QUnit.stop = applyDeprecated( \"QUnit.stop\" );","path":"src/export.js","position":30,"original_position":30,"commit_id":"70b9d70d45db6cd914837c6242e50ebf4a43519a","original_commit_id":"70b9d70d45db6cd914837c6242e50ebf4a43519a","user":{"login":"gibson042","id":1199584,"avatar_url":"https://avatars.githubusercontent.com/u/1199584?v=3","gravatar_id":"","url":"https://api.github.com/users/gibson042","html_url":"https://github.com/gibson042","followers_url":"https://api.github.com/users/gibson042/followers","following_url":"https://api.github.com/users/gibson042/following{/other_user}","gists_url":"https://api.github.com/users/gibson042/gists{/gist_id}","starred_url":"https://api.github.com/users/gibson042/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gibson042/subscriptions","organizations_url":"https://api.github.com/users/gibson042/orgs","repos_url":"https://api.github.com/users/gibson042/repos","events_url":"https://api.github.com/users/gibson042/events{/privacy}","received_events_url":"https://api.github.com/users/gibson042/received_events","type":"User","site_admin":false},"body":"`stop` should be handled separately, since there is no \"correct namespace\".","created_at":"2016-04-13T16:42:33Z","updated_at":"2016-04-13T16:42:33Z","html_url":"https://github.com/jquery/qunit/pull/976#discussion_r59582257","pull_request_url":"https://api.github.com/repos/jquery/qunit/pulls/976","_links":{"self":{"href":"https://api.github.com/repos/jquery/qunit/pulls/comments/59582257"},"html":{"href":"https://github.com/jquery/qunit/pull/976#discussion_r59582257"},"pull_request":{"href":"https://api.github.com/repos/jquery/qunit/pulls/976"}}},"pull_request":{"url":"https://api.github.com/repos/jquery/qunit/pulls/976","id":64216258,"html_url":"https://github.com/jquery/qunit/pull/976","diff_url":"https://github.com/jquery/qunit/pull/976.diff","patch_url":"https://github.com/jquery/qunit/pull/976.patch","issue_url":"https://api.github.com/repos/jquery/qunit/issues/976","number":976,"state":"open","locked":false,"title":"All: Remove deprecated features","user":{"login":"leobalter","id":301201,"avatar_url":"https://avatars.githubusercontent.com/u/301201?v=3","gravatar_id":"","url":"https://api.github.com/users/leobalter","html_url":"https://github.com/leobalter","followers_url":"https://api.github.com/users/leobalter/followers","following_url":"https://api.github.com/users/leobalter/following{/other_user}","gists_url":"https://api.github.com/users/leobalter/gists{/gist_id}","starred_url":"https://api.github.com/users/leobalter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leobalter/subscriptions","organizations_url":"https://api.github.com/users/leobalter/orgs","repos_url":"https://api.github.com/users/leobalter/repos","events_url":"https://api.github.com/users/leobalter/events{/privacy}","received_events_url":"https://api.github.com/users/leobalter/received_events","type":"User","site_admin":false},"body":"- globals\r\n- assertions on QUnit namespace\r\n- QUnit.stop\r\n- QUnit.init\r\n- setup/teardown\r\n- asyncTest\r\n- test with expected and async parameters\r\n- old style for logging callbacks\r\n- duration property on testDone details\r\n\r\nThis is the first batch. It can be improved and QUnit.reset is not addressed here yet.","created_at":"2016-03-25T22:47:53Z","updated_at":"2016-04-13T16:42:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6561f196894e0492d0953bf205925068e469f8da","assignee":null,"milestone":{"url":"https://api.github.com/repos/jquery/qunit/milestones/2","html_url":"https://github.com/jquery/qunit/milestones/v2.0","labels_url":"https://api.github.com/repos/jquery/qunit/milestones/2/labels","id":353904,"number":2,"title":"v2.0","description":"","creator":{"login":"Krinkle","id":156867,"avatar_url":"https://avatars.githubusercontent.com/u/156867?v=3","gravatar_id":"","url":"https://api.github.com/users/Krinkle","html_url":"https://github.com/Krinkle","followers_url":"https://api.github.com/users/Krinkle/followers","following_url":"https://api.github.com/users/Krinkle/following{/other_user}","gists_url":"https://api.github.com/users/Krinkle/gists{/gist_id}","starred_url":"https://api.github.com/users/Krinkle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Krinkle/subscriptions","organizations_url":"https://api.github.com/users/Krinkle/orgs","repos_url":"https://api.github.com/users/Krinkle/repos","events_url":"https://api.github.com/users/Krinkle/events{/privacy}","received_events_url":"https://api.github.com/users/Krinkle/received_events","type":"User","site_admin":false},"open_issues":13,"closed_issues":11,"state":"open","created_at":"2013-06-12T16:55:24Z","updated_at":"2016-03-25T22:48:54Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/jquery/qunit/pulls/976/commits","review_comments_url":"https://api.github.com/repos/jquery/qunit/pulls/976/comments","review_comment_url":"https://api.github.com/repos/jquery/qunit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jquery/qunit/issues/976/comments","statuses_url":"https://api.github.com/repos/jquery/qunit/statuses/70b9d70d45db6cd914837c6242e50ebf4a43519a","head":{"label":"leobalter:2.0-start","ref":"2.0-start","sha":"70b9d70d45db6cd914837c6242e50ebf4a43519a","user":{"login":"leobalter","id":301201,"avatar_url":"https://avatars.githubusercontent.com/u/301201?v=3","gravatar_id":"","url":"https://api.github.com/users/leobalter","html_url":"https://github.com/leobalter","followers_url":"https://api.github.com/users/leobalter/followers","following_url":"https://api.github.com/users/leobalter/following{/other_user}","gists_url":"https://api.github.com/users/leobalter/gists{/gist_id}","starred_url":"https://api.github.com/users/leobalter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leobalter/subscriptions","organizations_url":"https://api.github.com/users/leobalter/orgs","repos_url":"https://api.github.com/users/leobalter/repos","events_url":"https://api.github.com/users/leobalter/events{/privacy}","received_events_url":"https://api.github.com/users/leobalter/received_events","type":"User","site_admin":false},"repo":{"id":15093934,"name":"qunit","full_name":"leobalter/qunit","owner":{"login":"leobalter","id":301201,"avatar_url":"https://avatars.githubusercontent.com/u/301201?v=3","gravatar_id":"","url":"https://api.github.com/users/leobalter","html_url":"https://github.com/leobalter","followers_url":"https://api.github.com/users/leobalter/followers","following_url":"https://api.github.com/users/leobalter/following{/other_user}","gists_url":"https://api.github.com/users/leobalter/gists{/gist_id}","starred_url":"https://api.github.com/users/leobalter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leobalter/subscriptions","organizations_url":"https://api.github.com/users/leobalter/orgs","repos_url":"https://api.github.com/users/leobalter/repos","events_url":"https://api.github.com/users/leobalter/events{/privacy}","received_events_url":"https://api.github.com/users/leobalter/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/leobalter/qunit","description":"An easy-to-use JavaScript Unit Testing framework.","fork":true,"url":"https://api.github.com/repos/leobalter/qunit","forks_url":"https://api.github.com/repos/leobalter/qunit/forks","keys_url":"https://api.github.com/repos/leobalter/qunit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/leobalter/qunit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/leobalter/qunit/teams","hooks_url":"https://api.github.com/repos/leobalter/qunit/hooks","issue_events_url":"https://api.github.com/repos/leobalter/qunit/issues/events{/number}","events_url":"https://api.github.com/repos/leobalter/qunit/events","assignees_url":"https://api.github.com/repos/leobalter/qunit/assignees{/user}","branches_url":"https://api.github.com/repos/leobalter/qunit/branches{/branch}","tags_url":"https://api.github.com/repos/leobalter/qunit/tags","blobs_url":"https://api.github.com/repos/leobalter/qunit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/leobalter/qunit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/leobalter/qunit/git/refs{/sha}","trees_url":"https://api.github.com/repos/leobalter/qunit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/leobalter/qunit/statuses/{sha}","languages_url":"https://api.github.com/repos/leobalter/qunit/languages","stargazers_url":"https://api.github.com/repos/leobalter/qunit/stargazers","contributors_url":"https://api.github.com/repos/leobalter/qunit/contributors","subscribers_url":"https://api.github.com/repos/leobalter/qunit/subscribers","subscription_url":"https://api.github.com/repos/leobalter/qunit/subscription","commits_url":"https://api.github.com/repos/leobalter/qunit/commits{/sha}","git_commits_url":"https://api.github.com/repos/leobalter/qunit/git/commits{/sha}","comments_url":"https://api.github.com/repos/leobalter/qunit/comments{/number}","issue_comment_url":"https://api.github.com/repos/leobalter/qunit/issues/comments{/number}","contents_url":"https://api.github.com/repos/leobalter/qunit/contents/{+path}","compare_url":"https://api.github.com/repos/leobalter/qunit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/leobalter/qunit/merges","archive_url":"https://api.github.com/repos/leobalter/qunit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/leobalter/qunit/downloads","issues_url":"https://api.github.com/repos/leobalter/qunit/issues{/number}","pulls_url":"https://api.github.com/repos/leobalter/qunit/pulls{/number}","milestones_url":"https://api.github.com/repos/leobalter/qunit/milestones{/number}","notifications_url":"https://api.github.com/repos/leobalter/qunit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/leobalter/qunit/labels{/name}","releases_url":"https://api.github.com/repos/leobalter/qunit/releases{/id}","deployments_url":"https://api.github.com/repos/leobalter/qunit/deployments","created_at":"2013-12-11T00:34:30Z","updated_at":"2015-04-14T15:26:48Z","pushed_at":"2016-04-13T15:09:26Z","git_url":"git://github.com/leobalter/qunit.git","ssh_url":"git@github.com:leobalter/qunit.git","clone_url":"https://github.com/leobalter/qunit.git","svn_url":"https://github.com/leobalter/qunit","homepage":"http://qunitjs.com","size":1508,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jquery:master","ref":"master","sha":"f313fb384c8ad186d253f8462735f97fea4ca6a2","user":{"login":"jquery","id":70142,"avatar_url":"https://avatars.githubusercontent.com/u/70142?v=3","gravatar_id":"","url":"https://api.github.com/users/jquery","html_url":"https://github.com/jquery","followers_url":"https://api.github.com/users/jquery/followers","following_url":"https://api.github.com/users/jquery/following{/other_user}","gists_url":"https://api.github.com/users/jquery/gists{/gist_id}","starred_url":"https://api.github.com/users/jquery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jquery/subscriptions","organizations_url":"https://api.github.com/users/jquery/orgs","repos_url":"https://api.github.com/users/jquery/repos","events_url":"https://api.github.com/users/jquery/events{/privacy}","received_events_url":"https://api.github.com/users/jquery/received_events","type":"Organization","site_admin":false},"repo":{"id":259691,"name":"qunit","full_name":"jquery/qunit","owner":{"login":"jquery","id":70142,"avatar_url":"https://avatars.githubusercontent.com/u/70142?v=3","gravatar_id":"","url":"https://api.github.com/users/jquery","html_url":"https://github.com/jquery","followers_url":"https://api.github.com/users/jquery/followers","following_url":"https://api.github.com/users/jquery/following{/other_user}","gists_url":"https://api.github.com/users/jquery/gists{/gist_id}","starred_url":"https://api.github.com/users/jquery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jquery/subscriptions","organizations_url":"https://api.github.com/users/jquery/orgs","repos_url":"https://api.github.com/users/jquery/repos","events_url":"https://api.github.com/users/jquery/events{/privacy}","received_events_url":"https://api.github.com/users/jquery/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jquery/qunit","description":"An easy-to-use JavaScript Unit Testing framework.","fork":false,"url":"https://api.github.com/repos/jquery/qunit","forks_url":"https://api.github.com/repos/jquery/qunit/forks","keys_url":"https://api.github.com/repos/jquery/qunit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jquery/qunit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jquery/qunit/teams","hooks_url":"https://api.github.com/repos/jquery/qunit/hooks","issue_events_url":"https://api.github.com/repos/jquery/qunit/issues/events{/number}","events_url":"https://api.github.com/repos/jquery/qunit/events","assignees_url":"https://api.github.com/repos/jquery/qunit/assignees{/user}","branches_url":"https://api.github.com/repos/jquery/qunit/branches{/branch}","tags_url":"https://api.github.com/repos/jquery/qunit/tags","blobs_url":"https://api.github.com/repos/jquery/qunit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jquery/qunit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jquery/qunit/git/refs{/sha}","trees_url":"https://api.github.com/repos/jquery/qunit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jquery/qunit/statuses/{sha}","languages_url":"https://api.github.com/repos/jquery/qunit/languages","stargazers_url":"https://api.github.com/repos/jquery/qunit/stargazers","contributors_url":"https://api.github.com/repos/jquery/qunit/contributors","subscribers_url":"https://api.github.com/repos/jquery/qunit/subscribers","subscription_url":"https://api.github.com/repos/jquery/qunit/subscription","commits_url":"https://api.github.com/repos/jquery/qunit/commits{/sha}","git_commits_url":"https://api.github.com/repos/jquery/qunit/git/commits{/sha}","comments_url":"https://api.github.com/repos/jquery/qunit/comments{/number}","issue_comment_url":"https://api.github.com/repos/jquery/qunit/issues/comments{/number}","contents_url":"https://api.github.com/repos/jquery/qunit/contents/{+path}","compare_url":"https://api.github.com/repos/jquery/qunit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jquery/qunit/merges","archive_url":"https://api.github.com/repos/jquery/qunit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jquery/qunit/downloads","issues_url":"https://api.github.com/repos/jquery/qunit/issues{/number}","pulls_url":"https://api.github.com/repos/jquery/qunit/pulls{/number}","milestones_url":"https://api.github.com/repos/jquery/qunit/milestones{/number}","notifications_url":"https://api.github.com/repos/jquery/qunit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jquery/qunit/labels{/name}","releases_url":"https://api.github.com/repos/jquery/qunit/releases{/id}","deployments_url":"https://api.github.com/repos/jquery/qunit/deployments","created_at":"2009-07-24T16:26:23Z","updated_at":"2016-04-12T02:52:59Z","pushed_at":"2016-04-13T16:36:02Z","git_url":"git://github.com/jquery/qunit.git","ssh_url":"git@github.com:jquery/qunit.git","clone_url":"https://github.com/jquery/qunit.git","svn_url":"https://github.com/jquery/qunit","homepage":"http://qunitjs.com","size":6210,"stargazers_count":3420,"watchers_count":3420,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":711,"mirror_url":null,"open_issues_count":59,"forks":711,"open_issues":59,"watchers":3420,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jquery/qunit/pulls/976"},"html":{"href":"https://github.com/jquery/qunit/pull/976"},"issue":{"href":"https://api.github.com/repos/jquery/qunit/issues/976"},"comments":{"href":"https://api.github.com/repos/jquery/qunit/issues/976/comments"},"review_comments":{"href":"https://api.github.com/repos/jquery/qunit/pulls/976/comments"},"review_comment":{"href":"https://api.github.com/repos/jquery/qunit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jquery/qunit/pulls/976/commits"},"statuses":{"href":"https://api.github.com/repos/jquery/qunit/statuses/70b9d70d45db6cd914837c6242e50ebf4a43519a"}}}}