{"action":"created","comment":{"url":"https://api.github.com/repos/QubesOS/qubes-core-agent-linux/pulls/comments/65012729","id":65012729,"diff_hunk":"@@ -20,21 +20,35 @@\n #\n #\n \n+if type kdialog 2> /dev/null; then\n+kdlg=1\n+else kdlg=0\n+fi\n+\n+if [ $kdlg -eq 1 ] ; then\n VM=$(kdialog -inputbox \"Enter the VM name to send files to:\")\n+else\n+VM=$(zenity --entry --text=\"Enter the VM name to send files to:\")\n+fi\n+\n if [ X$VM = X ] ; then exit 0 ; fi\n \n SIZE=$(du --apparent-size -c -- \"$@\" 2> /dev/null | tail -1 | cut -f 1)\n+if [ $kdlg -eq 1 ] ;then\n REF=$(kdialog --progressbar \"Copy progress\")\n+fi\n qdbus $REF org.freedesktop.DBus.Properties.Set \"\" maximum $SIZE\n \n export PROGRESS_TYPE=gui\n \n /usr/lib/qubes/qrexec-client-vm $VM qubes.Filecopy \\\n \t/usr/lib/qubes/qfile-agent \"$@\" |\n+if [ $kdlg -eq 1 ] ;then\n (while read sentsize ; do\n \tCURRSIZE=$(($sentsize/1024))\n \tqdbus $REF  org.freedesktop.DBus.Properties.Set \"\" value $CURRSIZE\n done)\n+fi","path":"qubes-rpc/qvm-copy-to-vm.kde","position":32,"original_position":32,"commit_id":"b863ea8ce094b42a936139834ed31f5b6ed5f1be","original_commit_id":"b863ea8ce094b42a936139834ed31f5b6ed5f1be","user":{"login":"marmarek","id":726704,"avatar_url":"https://avatars.githubusercontent.com/u/726704?v=3","gravatar_id":"","url":"https://api.github.com/users/marmarek","html_url":"https://github.com/marmarek","followers_url":"https://api.github.com/users/marmarek/followers","following_url":"https://api.github.com/users/marmarek/following{/other_user}","gists_url":"https://api.github.com/users/marmarek/gists{/gist_id}","starred_url":"https://api.github.com/users/marmarek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marmarek/subscriptions","organizations_url":"https://api.github.com/users/marmarek/orgs","repos_url":"https://api.github.com/users/marmarek/repos","events_url":"https://api.github.com/users/marmarek/events{/privacy}","received_events_url":"https://api.github.com/users/marmarek/received_events","type":"User","site_admin":false},"body":"Keep in mind the output of `qrexec-client-vm` above is piped here, so probably some `else` clause should be used. Otherwise `qfile-agent` will get SIGPIPE on reporting progress. Or simply set `PROGRESS_TYPE` to empty string.","created_at":"2016-05-29T22:31:45Z","updated_at":"2016-05-29T22:31:45Z","html_url":"https://github.com/QubesOS/qubes-core-agent-linux/pull/14#discussion_r65012729","pull_request_url":"https://api.github.com/repos/QubesOS/qubes-core-agent-linux/pulls/14","_links":{"self":{"href":"https://api.github.com/repos/QubesOS/qubes-core-agent-linux/pulls/comments/65012729"},"html":{"href":"https://github.com/QubesOS/qubes-core-agent-linux/pull/14#discussion_r65012729"},"pull_request":{"href":"https://api.github.com/repos/QubesOS/qubes-core-agent-linux/pulls/14"}}},"pull_request":{"url":"https://api.github.com/repos/QubesOS/qubes-core-agent-linux/pulls/14","id":71815749,"html_url":"https://github.com/QubesOS/qubes-core-agent-linux/pull/14","diff_url":"https://github.com/QubesOS/qubes-core-agent-linux/pull/14.diff","patch_url":"https://github.com/QubesOS/qubes-core-agent-linux/pull/14.patch","issue_url":"https://api.github.com/repos/QubesOS/qubes-core-agent-linux/issues/14","number":14,"state":"open","locked":false,"title":"Fallback to zenity if kdialog not available","user":{"login":"unman","id":13558340,"avatar_url":"https://avatars.githubusercontent.com/u/13558340?v=3","gravatar_id":"","url":"https://api.github.com/users/unman","html_url":"https://github.com/unman","followers_url":"https://api.github.com/users/unman/followers","following_url":"https://api.github.com/users/unman/following{/other_user}","gists_url":"https://api.github.com/users/unman/gists{/gist_id}","starred_url":"https://api.github.com/users/unman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unman/subscriptions","organizations_url":"https://api.github.com/users/unman/orgs","repos_url":"https://api.github.com/users/unman/repos","events_url":"https://api.github.com/users/unman/events{/privacy}","received_events_url":"https://api.github.com/users/unman/received_events","type":"User","site_admin":false},"body":"The issue with dolphin identified in https://github.com/QubesOS/qubes-issues/issues/1429 arises because kdialog isn't installed in debian template. It can't be made a dependency of the core-agent package as it pulls a ridiculous amount of kde stuff with it.\r\nThis quick fix closes issue with dolphin.","created_at":"2016-05-29T01:28:56Z","updated_at":"2016-05-29T22:31:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f8381bb4ff899b7d3e501f5d4e2ad28430b5d409","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/QubesOS/qubes-core-agent-linux/pulls/14/commits","review_comments_url":"https://api.github.com/repos/QubesOS/qubes-core-agent-linux/pulls/14/comments","review_comment_url":"https://api.github.com/repos/QubesOS/qubes-core-agent-linux/pulls/comments{/number}","comments_url":"https://api.github.com/repos/QubesOS/qubes-core-agent-linux/issues/14/comments","statuses_url":"https://api.github.com/repos/QubesOS/qubes-core-agent-linux/statuses/b863ea8ce094b42a936139834ed31f5b6ed5f1be","head":{"label":"unman:1429","ref":"1429","sha":"b863ea8ce094b42a936139834ed31f5b6ed5f1be","user":{"login":"unman","id":13558340,"avatar_url":"https://avatars.githubusercontent.com/u/13558340?v=3","gravatar_id":"","url":"https://api.github.com/users/unman","html_url":"https://github.com/unman","followers_url":"https://api.github.com/users/unman/followers","following_url":"https://api.github.com/users/unman/following{/other_user}","gists_url":"https://api.github.com/users/unman/gists{/gist_id}","starred_url":"https://api.github.com/users/unman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unman/subscriptions","organizations_url":"https://api.github.com/users/unman/orgs","repos_url":"https://api.github.com/users/unman/repos","events_url":"https://api.github.com/users/unman/events{/privacy}","received_events_url":"https://api.github.com/users/unman/received_events","type":"User","site_admin":false},"repo":{"id":59917838,"name":"qubes-core-agent-linux","full_name":"unman/qubes-core-agent-linux","owner":{"login":"unman","id":13558340,"avatar_url":"https://avatars.githubusercontent.com/u/13558340?v=3","gravatar_id":"","url":"https://api.github.com/users/unman","html_url":"https://github.com/unman","followers_url":"https://api.github.com/users/unman/followers","following_url":"https://api.github.com/users/unman/following{/other_user}","gists_url":"https://api.github.com/users/unman/gists{/gist_id}","starred_url":"https://api.github.com/users/unman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unman/subscriptions","organizations_url":"https://api.github.com/users/unman/orgs","repos_url":"https://api.github.com/users/unman/repos","events_url":"https://api.github.com/users/unman/events{/privacy}","received_events_url":"https://api.github.com/users/unman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/unman/qubes-core-agent-linux","description":"Qubes component: core-agent-linux","fork":true,"url":"https://api.github.com/repos/unman/qubes-core-agent-linux","forks_url":"https://api.github.com/repos/unman/qubes-core-agent-linux/forks","keys_url":"https://api.github.com/repos/unman/qubes-core-agent-linux/keys{/key_id}","collaborators_url":"https://api.github.com/repos/unman/qubes-core-agent-linux/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/unman/qubes-core-agent-linux/teams","hooks_url":"https://api.github.com/repos/unman/qubes-core-agent-linux/hooks","issue_events_url":"https://api.github.com/repos/unman/qubes-core-agent-linux/issues/events{/number}","events_url":"https://api.github.com/repos/unman/qubes-core-agent-linux/events","assignees_url":"https://api.github.com/repos/unman/qubes-core-agent-linux/assignees{/user}","branches_url":"https://api.github.com/repos/unman/qubes-core-agent-linux/branches{/branch}","tags_url":"https://api.github.com/repos/unman/qubes-core-agent-linux/tags","blobs_url":"https://api.github.com/repos/unman/qubes-core-agent-linux/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/unman/qubes-core-agent-linux/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/unman/qubes-core-agent-linux/git/refs{/sha}","trees_url":"https://api.github.com/repos/unman/qubes-core-agent-linux/git/trees{/sha}","statuses_url":"https://api.github.com/repos/unman/qubes-core-agent-linux/statuses/{sha}","languages_url":"https://api.github.com/repos/unman/qubes-core-agent-linux/languages","stargazers_url":"https://api.github.com/repos/unman/qubes-core-agent-linux/stargazers","contributors_url":"https://api.github.com/repos/unman/qubes-core-agent-linux/contributors","subscribers_url":"https://api.github.com/repos/unman/qubes-core-agent-linux/subscribers","subscription_url":"https://api.github.com/repos/unman/qubes-core-agent-linux/subscription","commits_url":"https://api.github.com/repos/unman/qubes-core-agent-linux/commits{/sha}","git_commits_url":"https://api.github.com/repos/unman/qubes-core-agent-linux/git/commits{/sha}","comments_url":"https://api.github.com/repos/unman/qubes-core-agent-linux/comments{/number}","issue_comment_url":"https://api.github.com/repos/unman/qubes-core-agent-linux/issues/comments{/number}","contents_url":"https://api.github.com/repos/unman/qubes-core-agent-linux/contents/{+path}","compare_url":"https://api.github.com/repos/unman/qubes-core-agent-linux/compare/{base}...{head}","merges_url":"https://api.github.com/repos/unman/qubes-core-agent-linux/merges","archive_url":"https://api.github.com/repos/unman/qubes-core-agent-linux/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/unman/qubes-core-agent-linux/downloads","issues_url":"https://api.github.com/repos/unman/qubes-core-agent-linux/issues{/number}","pulls_url":"https://api.github.com/repos/unman/qubes-core-agent-linux/pulls{/number}","milestones_url":"https://api.github.com/repos/unman/qubes-core-agent-linux/milestones{/number}","notifications_url":"https://api.github.com/repos/unman/qubes-core-agent-linux/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/unman/qubes-core-agent-linux/labels{/name}","releases_url":"https://api.github.com/repos/unman/qubes-core-agent-linux/releases{/id}","deployments_url":"https://api.github.com/repos/unman/qubes-core-agent-linux/deployments","created_at":"2016-05-28T23:02:23Z","updated_at":"2016-05-28T23:02:25Z","pushed_at":"2016-05-29T01:23:30Z","git_url":"git://github.com/unman/qubes-core-agent-linux.git","ssh_url":"git@github.com:unman/qubes-core-agent-linux.git","clone_url":"https://github.com/unman/qubes-core-agent-linux.git","svn_url":"https://github.com/unman/qubes-core-agent-linux","homepage":null,"size":4808,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"QubesOS:master","ref":"master","sha":"3db93cdc87e75474429207871543491f18ac9afc","user":{"login":"QubesOS","id":10213205,"avatar_url":"https://avatars.githubusercontent.com/u/10213205?v=3","gravatar_id":"","url":"https://api.github.com/users/QubesOS","html_url":"https://github.com/QubesOS","followers_url":"https://api.github.com/users/QubesOS/followers","following_url":"https://api.github.com/users/QubesOS/following{/other_user}","gists_url":"https://api.github.com/users/QubesOS/gists{/gist_id}","starred_url":"https://api.github.com/users/QubesOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/QubesOS/subscriptions","organizations_url":"https://api.github.com/users/QubesOS/orgs","repos_url":"https://api.github.com/users/QubesOS/repos","events_url":"https://api.github.com/users/QubesOS/events{/privacy}","received_events_url":"https://api.github.com/users/QubesOS/received_events","type":"Organization","site_admin":false},"repo":{"id":30624145,"name":"qubes-core-agent-linux","full_name":"QubesOS/qubes-core-agent-linux","owner":{"login":"QubesOS","id":10213205,"avatar_url":"https://avatars.githubusercontent.com/u/10213205?v=3","gravatar_id":"","url":"https://api.github.com/users/QubesOS","html_url":"https://github.com/QubesOS","followers_url":"https://api.github.com/users/QubesOS/followers","following_url":"https://api.github.com/users/QubesOS/following{/other_user}","gists_url":"https://api.github.com/users/QubesOS/gists{/gist_id}","starred_url":"https://api.github.com/users/QubesOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/QubesOS/subscriptions","organizations_url":"https://api.github.com/users/QubesOS/orgs","repos_url":"https://api.github.com/users/QubesOS/repos","events_url":"https://api.github.com/users/QubesOS/events{/privacy}","received_events_url":"https://api.github.com/users/QubesOS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/QubesOS/qubes-core-agent-linux","description":"Qubes component: core-agent-linux","fork":false,"url":"https://api.github.com/repos/QubesOS/qubes-core-agent-linux","forks_url":"https://api.github.com/repos/QubesOS/qubes-core-agent-linux/forks","keys_url":"https://api.github.com/repos/QubesOS/qubes-core-agent-linux/keys{/key_id}","collaborators_url":"https://api.github.com/repos/QubesOS/qubes-core-agent-linux/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/QubesOS/qubes-core-agent-linux/teams","hooks_url":"https://api.github.com/repos/QubesOS/qubes-core-agent-linux/hooks","issue_events_url":"https://api.github.com/repos/QubesOS/qubes-core-agent-linux/issues/events{/number}","events_url":"https://api.github.com/repos/QubesOS/qubes-core-agent-linux/events","assignees_url":"https://api.github.com/repos/QubesOS/qubes-core-agent-linux/assignees{/user}","branches_url":"https://api.github.com/repos/QubesOS/qubes-core-agent-linux/branches{/branch}","tags_url":"https://api.github.com/repos/QubesOS/qubes-core-agent-linux/tags","blobs_url":"https://api.github.com/repos/QubesOS/qubes-core-agent-linux/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/QubesOS/qubes-core-agent-linux/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/QubesOS/qubes-core-agent-linux/git/refs{/sha}","trees_url":"https://api.github.com/repos/QubesOS/qubes-core-agent-linux/git/trees{/sha}","statuses_url":"https://api.github.com/repos/QubesOS/qubes-core-agent-linux/statuses/{sha}","languages_url":"https://api.github.com/repos/QubesOS/qubes-core-agent-linux/languages","stargazers_url":"https://api.github.com/repos/QubesOS/qubes-core-agent-linux/stargazers","contributors_url":"https://api.github.com/repos/QubesOS/qubes-core-agent-linux/contributors","subscribers_url":"https://api.github.com/repos/QubesOS/qubes-core-agent-linux/subscribers","subscription_url":"https://api.github.com/repos/QubesOS/qubes-core-agent-linux/subscription","commits_url":"https://api.github.com/repos/QubesOS/qubes-core-agent-linux/commits{/sha}","git_commits_url":"https://api.github.com/repos/QubesOS/qubes-core-agent-linux/git/commits{/sha}","comments_url":"https://api.github.com/repos/QubesOS/qubes-core-agent-linux/comments{/number}","issue_comment_url":"https://api.github.com/repos/QubesOS/qubes-core-agent-linux/issues/comments{/number}","contents_url":"https://api.github.com/repos/QubesOS/qubes-core-agent-linux/contents/{+path}","compare_url":"https://api.github.com/repos/QubesOS/qubes-core-agent-linux/compare/{base}...{head}","merges_url":"https://api.github.com/repos/QubesOS/qubes-core-agent-linux/merges","archive_url":"https://api.github.com/repos/QubesOS/qubes-core-agent-linux/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/QubesOS/qubes-core-agent-linux/downloads","issues_url":"https://api.github.com/repos/QubesOS/qubes-core-agent-linux/issues{/number}","pulls_url":"https://api.github.com/repos/QubesOS/qubes-core-agent-linux/pulls{/number}","milestones_url":"https://api.github.com/repos/QubesOS/qubes-core-agent-linux/milestones{/number}","notifications_url":"https://api.github.com/repos/QubesOS/qubes-core-agent-linux/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/QubesOS/qubes-core-agent-linux/labels{/name}","releases_url":"https://api.github.com/repos/QubesOS/qubes-core-agent-linux/releases{/id}","deployments_url":"https://api.github.com/repos/QubesOS/qubes-core-agent-linux/deployments","created_at":"2015-02-11T01:27:32Z","updated_at":"2016-02-12T08:30:22Z","pushed_at":"2016-05-29T01:28:56Z","git_url":"git://github.com/QubesOS/qubes-core-agent-linux.git","ssh_url":"git@github.com:QubesOS/qubes-core-agent-linux.git","clone_url":"https://github.com/QubesOS/qubes-core-agent-linux.git","svn_url":"https://github.com/QubesOS/qubes-core-agent-linux","homepage":null,"size":4809,"stargazers_count":5,"watchers_count":5,"language":"C","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":2,"forks":14,"open_issues":2,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/QubesOS/qubes-core-agent-linux/pulls/14"},"html":{"href":"https://github.com/QubesOS/qubes-core-agent-linux/pull/14"},"issue":{"href":"https://api.github.com/repos/QubesOS/qubes-core-agent-linux/issues/14"},"comments":{"href":"https://api.github.com/repos/QubesOS/qubes-core-agent-linux/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/QubesOS/qubes-core-agent-linux/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/QubesOS/qubes-core-agent-linux/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/QubesOS/qubes-core-agent-linux/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/QubesOS/qubes-core-agent-linux/statuses/b863ea8ce094b42a936139834ed31f5b6ed5f1be"}}}}
{"actor":{"display_login":"marmarek"}}