{"action":"closed","number":350,"pull_request":{"url":"https://api.github.com/repos/e-mission/e-mission-server/pulls/350","id":81268679,"html_url":"https://github.com/e-mission/e-mission-server/pull/350","diff_url":"https://github.com/e-mission/e-mission-server/pull/350.diff","patch_url":"https://github.com/e-mission/e-mission-server/pull/350.patch","issue_url":"https://api.github.com/repos/e-mission/e-mission-server/issues/350","number":350,"state":"closed","locked":false,"title":"We have enough points to make a decision only when they span at least…","user":{"login":"shankari","id":2423263,"avatar_url":"https://avatars.githubusercontent.com/u/2423263?v=3","gravatar_id":"","url":"https://api.github.com/users/shankari","html_url":"https://github.com/shankari","followers_url":"https://api.github.com/users/shankari/followers","following_url":"https://api.github.com/users/shankari/following{/other_user}","gists_url":"https://api.github.com/users/shankari/gists{/gist_id}","starred_url":"https://api.github.com/users/shankari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shankari/subscriptions","organizations_url":"https://api.github.com/users/shankari/orgs","repos_url":"https://api.github.com/users/shankari/repos","events_url":"https://api.github.com/users/shankari/events{/privacy}","received_events_url":"https://api.github.com/users/shankari/received_events","type":"User","site_admin":false},"body":"… 5 mins\r\n\r\nBefore this change, we had two checks to determine whether we had enough\r\npoints to make a decision\r\n\r\n- whether we had at least 10 points\r\n- whether any of them were in the past 5 mins\r\n\r\nIf the points that we received were 30 secs apart, as we expected, this would\r\nwork just fine. But if they were more frequent, as when navigating while\r\nwalking, then we detect a trip end way before 5 mins.\r\n\r\nIn this change, we also add an additional check to ensure that the points from\r\nthe last 5 mins query actually span 5 mins. With this check, I think that we\r\ncan remove the last 10 points check, but I want to wait until we have a more\r\nprincipled checker to confirm before making a subtractive change.","created_at":"2016-08-15T04:17:19Z","updated_at":"2016-08-15T22:06:21Z","closed_at":"2016-08-15T22:06:21Z","merged_at":"2016-08-15T22:06:21Z","merge_commit_sha":"5cd3d7c7530f244b5b8f0abe11278c7daa1a15bf","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/e-mission/e-mission-server/pulls/350/commits","review_comments_url":"https://api.github.com/repos/e-mission/e-mission-server/pulls/350/comments","review_comment_url":"https://api.github.com/repos/e-mission/e-mission-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/e-mission/e-mission-server/issues/350/comments","statuses_url":"https://api.github.com/repos/e-mission/e-mission-server/statuses/5c59a71c8cf2184785de1f382c9a258d886e5061","head":{"label":"shankari:fix_issue_345","ref":"fix_issue_345","sha":"5c59a71c8cf2184785de1f382c9a258d886e5061","user":{"login":"shankari","id":2423263,"avatar_url":"https://avatars.githubusercontent.com/u/2423263?v=3","gravatar_id":"","url":"https://api.github.com/users/shankari","html_url":"https://github.com/shankari","followers_url":"https://api.github.com/users/shankari/followers","following_url":"https://api.github.com/users/shankari/following{/other_user}","gists_url":"https://api.github.com/users/shankari/gists{/gist_id}","starred_url":"https://api.github.com/users/shankari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shankari/subscriptions","organizations_url":"https://api.github.com/users/shankari/orgs","repos_url":"https://api.github.com/users/shankari/repos","events_url":"https://api.github.com/users/shankari/events{/privacy}","received_events_url":"https://api.github.com/users/shankari/received_events","type":"User","site_admin":false},"repo":{"id":26309298,"name":"e-mission-server","full_name":"shankari/e-mission-server","owner":{"login":"shankari","id":2423263,"avatar_url":"https://avatars.githubusercontent.com/u/2423263?v=3","gravatar_id":"","url":"https://api.github.com/users/shankari","html_url":"https://github.com/shankari","followers_url":"https://api.github.com/users/shankari/followers","following_url":"https://api.github.com/users/shankari/following{/other_user}","gists_url":"https://api.github.com/users/shankari/gists{/gist_id}","starred_url":"https://api.github.com/users/shankari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shankari/subscriptions","organizations_url":"https://api.github.com/users/shankari/orgs","repos_url":"https://api.github.com/users/shankari/repos","events_url":"https://api.github.com/users/shankari/events{/privacy}","received_events_url":"https://api.github.com/users/shankari/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shankari/e-mission-server","description":"The backend (server) code for the e-mission server","fork":true,"url":"https://api.github.com/repos/shankari/e-mission-server","forks_url":"https://api.github.com/repos/shankari/e-mission-server/forks","keys_url":"https://api.github.com/repos/shankari/e-mission-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shankari/e-mission-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shankari/e-mission-server/teams","hooks_url":"https://api.github.com/repos/shankari/e-mission-server/hooks","issue_events_url":"https://api.github.com/repos/shankari/e-mission-server/issues/events{/number}","events_url":"https://api.github.com/repos/shankari/e-mission-server/events","assignees_url":"https://api.github.com/repos/shankari/e-mission-server/assignees{/user}","branches_url":"https://api.github.com/repos/shankari/e-mission-server/branches{/branch}","tags_url":"https://api.github.com/repos/shankari/e-mission-server/tags","blobs_url":"https://api.github.com/repos/shankari/e-mission-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shankari/e-mission-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shankari/e-mission-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/shankari/e-mission-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shankari/e-mission-server/statuses/{sha}","languages_url":"https://api.github.com/repos/shankari/e-mission-server/languages","stargazers_url":"https://api.github.com/repos/shankari/e-mission-server/stargazers","contributors_url":"https://api.github.com/repos/shankari/e-mission-server/contributors","subscribers_url":"https://api.github.com/repos/shankari/e-mission-server/subscribers","subscription_url":"https://api.github.com/repos/shankari/e-mission-server/subscription","commits_url":"https://api.github.com/repos/shankari/e-mission-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/shankari/e-mission-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/shankari/e-mission-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/shankari/e-mission-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/shankari/e-mission-server/contents/{+path}","compare_url":"https://api.github.com/repos/shankari/e-mission-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shankari/e-mission-server/merges","archive_url":"https://api.github.com/repos/shankari/e-mission-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shankari/e-mission-server/downloads","issues_url":"https://api.github.com/repos/shankari/e-mission-server/issues{/number}","pulls_url":"https://api.github.com/repos/shankari/e-mission-server/pulls{/number}","milestones_url":"https://api.github.com/repos/shankari/e-mission-server/milestones{/number}","notifications_url":"https://api.github.com/repos/shankari/e-mission-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shankari/e-mission-server/labels{/name}","releases_url":"https://api.github.com/repos/shankari/e-mission-server/releases{/id}","deployments_url":"https://api.github.com/repos/shankari/e-mission-server/deployments","created_at":"2014-11-07T07:44:00Z","updated_at":"2016-02-11T18:16:54Z","pushed_at":"2016-08-15T18:13:58Z","git_url":"git://github.com/shankari/e-mission-server.git","ssh_url":"git@github.com:shankari/e-mission-server.git","clone_url":"https://github.com/shankari/e-mission-server.git","svn_url":"https://github.com/shankari/e-mission-server","homepage":"https://e-mission.eecs.berkeley.edu","size":92587,"stargazers_count":0,"watchers_count":0,"language":"Jupyter Notebook","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"e-mission:master","ref":"master","sha":"c244cb70170264801f0464e2dd02c5d3dd275806","user":{"login":"e-mission","id":10713694,"avatar_url":"https://avatars.githubusercontent.com/u/10713694?v=3","gravatar_id":"","url":"https://api.github.com/users/e-mission","html_url":"https://github.com/e-mission","followers_url":"https://api.github.com/users/e-mission/followers","following_url":"https://api.github.com/users/e-mission/following{/other_user}","gists_url":"https://api.github.com/users/e-mission/gists{/gist_id}","starred_url":"https://api.github.com/users/e-mission/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/e-mission/subscriptions","organizations_url":"https://api.github.com/users/e-mission/orgs","repos_url":"https://api.github.com/users/e-mission/repos","events_url":"https://api.github.com/users/e-mission/events{/privacy}","received_events_url":"https://api.github.com/users/e-mission/received_events","type":"Organization","site_admin":false},"repo":{"id":26307245,"name":"e-mission-server","full_name":"e-mission/e-mission-server","owner":{"login":"e-mission","id":10713694,"avatar_url":"https://avatars.githubusercontent.com/u/10713694?v=3","gravatar_id":"","url":"https://api.github.com/users/e-mission","html_url":"https://github.com/e-mission","followers_url":"https://api.github.com/users/e-mission/followers","following_url":"https://api.github.com/users/e-mission/following{/other_user}","gists_url":"https://api.github.com/users/e-mission/gists{/gist_id}","starred_url":"https://api.github.com/users/e-mission/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/e-mission/subscriptions","organizations_url":"https://api.github.com/users/e-mission/orgs","repos_url":"https://api.github.com/users/e-mission/repos","events_url":"https://api.github.com/users/e-mission/events{/privacy}","received_events_url":"https://api.github.com/users/e-mission/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/e-mission/e-mission-server","description":"The backend (server) code for the e-mission server","fork":false,"url":"https://api.github.com/repos/e-mission/e-mission-server","forks_url":"https://api.github.com/repos/e-mission/e-mission-server/forks","keys_url":"https://api.github.com/repos/e-mission/e-mission-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/e-mission/e-mission-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/e-mission/e-mission-server/teams","hooks_url":"https://api.github.com/repos/e-mission/e-mission-server/hooks","issue_events_url":"https://api.github.com/repos/e-mission/e-mission-server/issues/events{/number}","events_url":"https://api.github.com/repos/e-mission/e-mission-server/events","assignees_url":"https://api.github.com/repos/e-mission/e-mission-server/assignees{/user}","branches_url":"https://api.github.com/repos/e-mission/e-mission-server/branches{/branch}","tags_url":"https://api.github.com/repos/e-mission/e-mission-server/tags","blobs_url":"https://api.github.com/repos/e-mission/e-mission-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/e-mission/e-mission-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/e-mission/e-mission-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/e-mission/e-mission-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/e-mission/e-mission-server/statuses/{sha}","languages_url":"https://api.github.com/repos/e-mission/e-mission-server/languages","stargazers_url":"https://api.github.com/repos/e-mission/e-mission-server/stargazers","contributors_url":"https://api.github.com/repos/e-mission/e-mission-server/contributors","subscribers_url":"https://api.github.com/repos/e-mission/e-mission-server/subscribers","subscription_url":"https://api.github.com/repos/e-mission/e-mission-server/subscription","commits_url":"https://api.github.com/repos/e-mission/e-mission-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/e-mission/e-mission-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/e-mission/e-mission-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/e-mission/e-mission-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/e-mission/e-mission-server/contents/{+path}","compare_url":"https://api.github.com/repos/e-mission/e-mission-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/e-mission/e-mission-server/merges","archive_url":"https://api.github.com/repos/e-mission/e-mission-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/e-mission/e-mission-server/downloads","issues_url":"https://api.github.com/repos/e-mission/e-mission-server/issues{/number}","pulls_url":"https://api.github.com/repos/e-mission/e-mission-server/pulls{/number}","milestones_url":"https://api.github.com/repos/e-mission/e-mission-server/milestones{/number}","notifications_url":"https://api.github.com/repos/e-mission/e-mission-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/e-mission/e-mission-server/labels{/name}","releases_url":"https://api.github.com/repos/e-mission/e-mission-server/releases{/id}","deployments_url":"https://api.github.com/repos/e-mission/e-mission-server/deployments","created_at":"2014-11-07T06:39:02Z","updated_at":"2016-06-11T09:09:56Z","pushed_at":"2016-08-15T22:06:21Z","git_url":"git://github.com/e-mission/e-mission-server.git","ssh_url":"git@github.com:e-mission/e-mission-server.git","clone_url":"https://github.com/e-mission/e-mission-server.git","svn_url":"https://github.com/e-mission/e-mission-server","homepage":"https://e-mission.eecs.berkeley.edu","size":93097,"stargazers_count":2,"watchers_count":2,"language":"Jupyter Notebook","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":29,"mirror_url":null,"open_issues_count":63,"forks":29,"open_issues":63,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/e-mission/e-mission-server/pulls/350"},"html":{"href":"https://github.com/e-mission/e-mission-server/pull/350"},"issue":{"href":"https://api.github.com/repos/e-mission/e-mission-server/issues/350"},"comments":{"href":"https://api.github.com/repos/e-mission/e-mission-server/issues/350/comments"},"review_comments":{"href":"https://api.github.com/repos/e-mission/e-mission-server/pulls/350/comments"},"review_comment":{"href":"https://api.github.com/repos/e-mission/e-mission-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/e-mission/e-mission-server/pulls/350/commits"},"statuses":{"href":"https://api.github.com/repos/e-mission/e-mission-server/statuses/5c59a71c8cf2184785de1f382c9a258d886e5061"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"shankari","id":2423263,"avatar_url":"https://avatars.githubusercontent.com/u/2423263?v=3","gravatar_id":"","url":"https://api.github.com/users/shankari","html_url":"https://github.com/shankari","followers_url":"https://api.github.com/users/shankari/followers","following_url":"https://api.github.com/users/shankari/following{/other_user}","gists_url":"https://api.github.com/users/shankari/gists{/gist_id}","starred_url":"https://api.github.com/users/shankari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shankari/subscriptions","organizations_url":"https://api.github.com/users/shankari/orgs","repos_url":"https://api.github.com/users/shankari/repos","events_url":"https://api.github.com/users/shankari/events{/privacy}","received_events_url":"https://api.github.com/users/shankari/received_events","type":"User","site_admin":false},"comments":5,"review_comments":0,"commits":2,"additions":14,"deletions":2,"changed_files":2}}
{"actor":{"display_login":"shankari"}}