{"action":"created","comment":{"url":"https://api.github.com/repos/edx/edx-app-android/pulls/comments/80914180","pull_request_review_id":1930953,"id":80914180,"diff_hunk":"@@ -235,24 +235,38 @@ public String getEmail() {\n         return activityLoginBinding.emailEt.getText().toString().trim();\n     }\n \n-    private static final int RESET_PASSWORD_REQUEST_CODE = 0;\n-\n     private void showResetPasswordDialog() {\n-        startActivityForResult(ResetPasswordActivity.newIntent(getEmail()), RESET_PASSWORD_REQUEST_CODE);\n+        resetPasswordAlert = ResetPasswordAlertDialogFragment.newInstance(this, getEmail());\n+        resetPasswordAlert.setListener(this);\n+        resetPasswordAlert.show(getSupportFragmentManager(), null);\n     }\n \n-    public void showEulaDialog() {\n-        environment.getRouter().showWebViewDialog(this, getString(R.string.eula_file_link), getString(R.string.end_user_title));\n+    @Override\n+    public void onResult(boolean success, @Nullable String errorMessage) {","path":"OpenEdXMobile/src/main/java/org/edx/mobile/view/LoginActivity.java","position":50,"original_position":50,"commit_id":"e3ed1a14438fc25f72fee22b6938503592634bb5","original_commit_id":"e3ed1a14438fc25f72fee22b6938503592634bb5","user":{"login":"miankhalid","id":1710804,"avatar_url":"https://avatars.githubusercontent.com/u/1710804?v=3","gravatar_id":"","url":"https://api.github.com/users/miankhalid","html_url":"https://github.com/miankhalid","followers_url":"https://api.github.com/users/miankhalid/followers","following_url":"https://api.github.com/users/miankhalid/following{/other_user}","gists_url":"https://api.github.com/users/miankhalid/gists{/gist_id}","starred_url":"https://api.github.com/users/miankhalid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miankhalid/subscriptions","organizations_url":"https://api.github.com/users/miankhalid/orgs","repos_url":"https://api.github.com/users/miankhalid/repos","events_url":"https://api.github.com/users/miankhalid/events{/privacy}","received_events_url":"https://api.github.com/users/miankhalid/received_events","type":"User","site_admin":false},"body":"This function could use some auto-formatting.","created_at":"2016-09-28T13:25:41Z","updated_at":"2016-09-28T13:25:41Z","html_url":"https://github.com/edx/edx-app-android/pull/817#discussion_r80914180","pull_request_url":"https://api.github.com/repos/edx/edx-app-android/pulls/817","_links":{"self":{"href":"https://api.github.com/repos/edx/edx-app-android/pulls/comments/80914180"},"html":{"href":"https://github.com/edx/edx-app-android/pull/817#discussion_r80914180"},"pull_request":{"href":"https://api.github.com/repos/edx/edx-app-android/pulls/817"}}},"pull_request":{"url":"https://api.github.com/repos/edx/edx-app-android/pulls/817","id":83678735,"html_url":"https://github.com/edx/edx-app-android/pull/817","diff_url":"https://github.com/edx/edx-app-android/pull/817.diff","patch_url":"https://github.com/edx/edx-app-android/pull/817.patch","issue_url":"https://api.github.com/repos/edx/edx-app-android/issues/817","number":817,"state":"open","locked":false,"title":"Making Forgot your password and TOS accessible","user":{"login":"mdinino","id":18707535,"avatar_url":"https://avatars.githubusercontent.com/u/18707535?v=3","gravatar_id":"","url":"https://api.github.com/users/mdinino","html_url":"https://github.com/mdinino","followers_url":"https://api.github.com/users/mdinino/followers","following_url":"https://api.github.com/users/mdinino/following{/other_user}","gists_url":"https://api.github.com/users/mdinino/gists{/gist_id}","starred_url":"https://api.github.com/users/mdinino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdinino/subscriptions","organizations_url":"https://api.github.com/users/mdinino/orgs","repos_url":"https://api.github.com/users/mdinino/repos","events_url":"https://api.github.com/users/mdinino/events{/privacy}","received_events_url":"https://api.github.com/users/mdinino/received_events","type":"User","site_admin":false},"body":"Description\r\n\r\n[MA-2716](https://openedx.atlassian.net/browse/MA-2716)\r\n[MA-2788](https://openedx.atlassian.net/browse/MA-2788)\r\n\r\n*TOS Screen Changes:\r\nI changed the TOS screen from looking like the left screen to looking like the right screen.\r\n<img src=\"https://cloud.githubusercontent.com/assets/18707535/18181435/251eb23a-7059-11e6-8482-f9f14aec9511.png\" width=\"250\" height=\"500\"/><img src=\"https://cloud.githubusercontent.com/assets/18707535/18286691/f4cd2b38-7441-11e6-8706-83ea126827d3.png\" width=\"250\" height=\"500\" />\r\n\r\nHeres why I did it:\r\nAccording to a stack overflow post (http://stackoverflow.com/questions/28472985/android-set-talkback-accessibility-focus-to-a-specific-view), TalkBack needs some time before it attaches itself to a view and therefore we would need to request focus of the \"End User License Agreement\" view after 500 milliseconds. I thought this was a hack and instead just made the End User License Agreement be the title of the activity. In order to show the title, we need the action bar. TalkBack works correctly after this.\r\n\r\nI also took out the \"close\" button because it was redundant.\r\n\r\nClicking on \"Forgot Your Password\" from Login dialog.\r\n\r\nIf there is no network, I changed the alert dialog from the left screen to the right screen.\r\n<img src=\"https://cloud.githubusercontent.com/assets/18707535/18183936/9fa6a0c0-7064-11e6-8b5a-53f10e01d1b3.png\" width=\"250\"  height=\"500\"/><img src=\"https://cloud.githubusercontent.com/assets/18707535/18288189/55d8643c-7448-11e6-9a08-21ed4228ce4f.png\" width=\"250\"  height=\"500\"/>\r\n\r\n\r\nI did that to make the alert consistent with the other alerts and for accessibility reasons.\r\n\r\nAs far as the \"Forgot your password dialog\" itself goes, I changed it from (left) to (middle). The image on the right shows what it looks like with an error.\r\n<img src=\"https://cloud.githubusercontent.com/assets/18707535/18216852/70d162bc-7127-11e6-9266-279f85678e8c.png\" width=\"250\"  height=\"500\" /><img src=\"https://cloud.githubusercontent.com/assets/18707535/18288279/bb70ce24-7448-11e6-9a81-a33a8ed5570b.png\" width=\"250\"  height=\"500\" /><img src=\"https://cloud.githubusercontent.com/assets/18707535/18291125/5cb7ea96-7454-11e6-8c49-a66b2c6e90f0.png\" width=\"250\"  height=\"500\" />\r\n\r\nI changed it to look more consistent with the other alert dialogs as well as to be more accessible (text input layouts are inherently more accessible).\r\n\r\nThis is what it looks like when an email was sent\r\n<img src=\"https://cloud.githubusercontent.com/assets/18707535/18888596/ffc101f0-84c6-11e6-91c5-8141bca54bb5.png\" width=\"250\"  height=\"500\" />\r\n\r\n### Testing\r\n- [ ] Unit, integration, acceptance tests as appropriate\r\n- On the login/registration screen, I verified that with navigating to the \"Forgot your password?\" and TOS link, TB announced \"double tap to activate\" after reading the text.\r\n- On the TOS screen, I verified that TB read out the header (\"End User License Agreement\").\r\n- On this screen I also verified that tapping \"close\" at the bottom of the page, or tapping the arrow on the action bar closed the dialog and brought us to the previous dialog.\r\n- On login screen, I verified that, upon tapping \"Forgot Your Password?\" and there was no network, the network error was shown. I verified that this is a modal dialog (only clicking back button or OK) dismissed it.\r\n- On login screen, I verified that, upon \"Forgot Your Password?\" and there was a network connection, we were brought to the Forgot Your Password Dialog.\r\n- I verified that, upon showing the Forgot Your Password Dialog, TB read the header \"Reset Password\". I also verified that TB could navigate to the elements and read them appropriately.\r\n- I verified that the Forgot Your Password Dialog was modal.\r\n- I verified that the Cancel button properly dismissed the dialog.\r\n- I verified that, upon tapping OK and there was an error. the error was shown and TB announced the error.\r\n- I verified that, upon tapping OK and there was no error, the email address successfully was emailed a link to reset password. I also verified that doing so dismissed the Forgot Your Password Dialog.\r\n- Upon receiving the email, I changed the password, and verified that I could log in with the new password.\r\n\r\n### Reviewers\r\nIf you've been tagged for review, please check your corresponding box once you've given the :+1:.\r\n- [ ] Code review: @1zaman \r\n- [ ] Code review: @miankhalid \r\n- [ ] Code review: @bguertin \r\n- [ ] UX review: @lizcohen\r\n- [ ] FYI @andy-armstrong \r\n","created_at":"2016-09-01T18:01:10Z","updated_at":"2016-09-28T13:47:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"842c14493cab524debd057da153401a5718fc38c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/edx/edx-app-android/pulls/817/commits","review_comments_url":"https://api.github.com/repos/edx/edx-app-android/pulls/817/comments","review_comment_url":"https://api.github.com/repos/edx/edx-app-android/pulls/comments{/number}","comments_url":"https://api.github.com/repos/edx/edx-app-android/issues/817/comments","statuses_url":"https://api.github.com/repos/edx/edx-app-android/statuses/e3ed1a14438fc25f72fee22b6938503592634bb5","head":{"label":"edx:mdinino/MA-2716","ref":"mdinino/MA-2716","sha":"e3ed1a14438fc25f72fee22b6938503592634bb5","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":29251742,"name":"edx-app-android","full_name":"edx/edx-app-android","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-app-android","description":"","fork":false,"url":"https://api.github.com/repos/edx/edx-app-android","forks_url":"https://api.github.com/repos/edx/edx-app-android/forks","keys_url":"https://api.github.com/repos/edx/edx-app-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-app-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-app-android/teams","hooks_url":"https://api.github.com/repos/edx/edx-app-android/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-app-android/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-app-android/events","assignees_url":"https://api.github.com/repos/edx/edx-app-android/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-app-android/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-app-android/tags","blobs_url":"https://api.github.com/repos/edx/edx-app-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-app-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-app-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-app-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-app-android/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-app-android/languages","stargazers_url":"https://api.github.com/repos/edx/edx-app-android/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-app-android/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-app-android/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-app-android/subscription","commits_url":"https://api.github.com/repos/edx/edx-app-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-app-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-app-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-app-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-app-android/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-app-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-app-android/merges","archive_url":"https://api.github.com/repos/edx/edx-app-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-app-android/downloads","issues_url":"https://api.github.com/repos/edx/edx-app-android/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-app-android/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-app-android/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-app-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-app-android/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-app-android/releases{/id}","deployments_url":"https://api.github.com/repos/edx/edx-app-android/deployments","created_at":"2015-01-14T15:49:47Z","updated_at":"2016-09-24T16:08:15Z","pushed_at":"2016-09-28T12:42:30Z","git_url":"git://github.com/edx/edx-app-android.git","ssh_url":"git@github.com:edx/edx-app-android.git","clone_url":"https://github.com/edx/edx-app-android.git","svn_url":"https://github.com/edx/edx-app-android","homepage":null,"size":24175,"stargazers_count":94,"watchers_count":94,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":101,"mirror_url":null,"open_issues_count":16,"forks":101,"open_issues":16,"watchers":94,"default_branch":"master"}},"base":{"label":"edx:master","ref":"master","sha":"ef5bbf482c9402bfd8723cbceb87ec3c007c69f5","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":29251742,"name":"edx-app-android","full_name":"edx/edx-app-android","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-app-android","description":"","fork":false,"url":"https://api.github.com/repos/edx/edx-app-android","forks_url":"https://api.github.com/repos/edx/edx-app-android/forks","keys_url":"https://api.github.com/repos/edx/edx-app-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-app-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-app-android/teams","hooks_url":"https://api.github.com/repos/edx/edx-app-android/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-app-android/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-app-android/events","assignees_url":"https://api.github.com/repos/edx/edx-app-android/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-app-android/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-app-android/tags","blobs_url":"https://api.github.com/repos/edx/edx-app-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-app-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-app-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-app-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-app-android/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-app-android/languages","stargazers_url":"https://api.github.com/repos/edx/edx-app-android/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-app-android/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-app-android/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-app-android/subscription","commits_url":"https://api.github.com/repos/edx/edx-app-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-app-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-app-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-app-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-app-android/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-app-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-app-android/merges","archive_url":"https://api.github.com/repos/edx/edx-app-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-app-android/downloads","issues_url":"https://api.github.com/repos/edx/edx-app-android/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-app-android/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-app-android/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-app-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-app-android/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-app-android/releases{/id}","deployments_url":"https://api.github.com/repos/edx/edx-app-android/deployments","created_at":"2015-01-14T15:49:47Z","updated_at":"2016-09-24T16:08:15Z","pushed_at":"2016-09-28T12:42:30Z","git_url":"git://github.com/edx/edx-app-android.git","ssh_url":"git@github.com:edx/edx-app-android.git","clone_url":"https://github.com/edx/edx-app-android.git","svn_url":"https://github.com/edx/edx-app-android","homepage":null,"size":24175,"stargazers_count":94,"watchers_count":94,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":101,"mirror_url":null,"open_issues_count":16,"forks":101,"open_issues":16,"watchers":94,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edx/edx-app-android/pulls/817"},"html":{"href":"https://github.com/edx/edx-app-android/pull/817"},"issue":{"href":"https://api.github.com/repos/edx/edx-app-android/issues/817"},"comments":{"href":"https://api.github.com/repos/edx/edx-app-android/issues/817/comments"},"review_comments":{"href":"https://api.github.com/repos/edx/edx-app-android/pulls/817/comments"},"review_comment":{"href":"https://api.github.com/repos/edx/edx-app-android/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/edx/edx-app-android/pulls/817/commits"},"statuses":{"href":"https://api.github.com/repos/edx/edx-app-android/statuses/e3ed1a14438fc25f72fee22b6938503592634bb5"}}}}
{"actor":{"display_login":"miankhalid"}}