{"action":"created","comment":{"url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments/85332090","pull_request_review_id":6053621,"id":85332090,"diff_hunk":"@@ -673,6 +665,22 @@ typedef union {\n #define INET6_ADDRSTRLEN 65\n #endif\n \n+inline void LogErr(unsigned err,unsigned ref,const char *info,unsigned lineno,const char *tracename)\n+{\n+    if (err)\n+    {\n+        PROGLOG(\"jsocket(%d,%d)%s%s err = %d%s%s\",ref,lineno,\n+           (info&&*info)?\" \":\"\",(info&&*info)?info:\"\",err,\n+           (tracename&&*tracename)?\" : \":\"\",(tracename&&*tracename)?tracename:\"\");\n+        if (JSE_NOTCONN == err)","path":"system/jlib/jsocket.cpp","position":26,"original_position":26,"commit_id":"3a60f802b4d4922aede5750282c141e3a867547b","original_commit_id":"3a60f802b4d4922aede5750282c141e3a867547b","user":{"login":"mckellyln","id":5116200,"avatar_url":"https://avatars.githubusercontent.com/u/5116200?v=3","gravatar_id":"","url":"https://api.github.com/users/mckellyln","html_url":"https://github.com/mckellyln","followers_url":"https://api.github.com/users/mckellyln/followers","following_url":"https://api.github.com/users/mckellyln/following{/other_user}","gists_url":"https://api.github.com/users/mckellyln/gists{/gist_id}","starred_url":"https://api.github.com/users/mckellyln/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mckellyln/subscriptions","organizations_url":"https://api.github.com/users/mckellyln/orgs","repos_url":"https://api.github.com/users/mckellyln/repos","events_url":"https://api.github.com/users/mckellyln/events{/privacy}","received_events_url":"https://api.github.com/users/mckellyln/received_events","type":"User","site_admin":false},"body":"Maybe also add JSE_CONNRESET and JSE_CONNABORTED here ?","created_at":"2016-10-27T13:07:24Z","updated_at":"2016-10-27T13:07:24Z","html_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/9281#discussion_r85332090","pull_request_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/9281","_links":{"self":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments/85332090"},"html":{"href":"https://github.com/hpcc-systems/HPCC-Platform/pull/9281#discussion_r85332090"},"pull_request":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/9281"}}},"pull_request":{"url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/9281","id":91188336,"html_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/9281","diff_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/9281.diff","patch_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/9281.patch","issue_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/9281","number":9281,"state":"open","locked":false,"title":"HPCC-16541 jsocket / MP link closed tracing","user":{"login":"jakesmith","id":902700,"avatar_url":"https://avatars.githubusercontent.com/u/902700?v=3","gravatar_id":"","url":"https://api.github.com/users/jakesmith","html_url":"https://github.com/jakesmith","followers_url":"https://api.github.com/users/jakesmith/followers","following_url":"https://api.github.com/users/jakesmith/following{/other_user}","gists_url":"https://api.github.com/users/jakesmith/gists{/gist_id}","starred_url":"https://api.github.com/users/jakesmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakesmith/subscriptions","organizations_url":"https://api.github.com/users/jakesmith/orgs","repos_url":"https://api.github.com/users/jakesmith/repos","events_url":"https://api.github.com/users/jakesmith/events{/privacy}","received_events_url":"https://api.github.com/users/jakesmith/received_events","type":"User","site_admin":false},"body":"Add some tracing, inc. stack tracing when sockets lost\r\nAlso add an experimental option to reconenct the channel in some\r\ncases.\r\n\r\nSigned-off-by: Jake Smith <jake.smith@lexisnexis.com>","created_at":"2016-10-27T12:14:35Z","updated_at":"2016-10-27T13:07:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8828b88da2d23aa68e91b29d9f55670e7b76c290","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/9281/commits","review_comments_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/9281/comments","review_comment_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/9281/comments","statuses_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/statuses/3a60f802b4d4922aede5750282c141e3a867547b","head":{"label":"jakesmith:hpcc-16541","ref":"hpcc-16541","sha":"3a60f802b4d4922aede5750282c141e3a867547b","user":{"login":"jakesmith","id":902700,"avatar_url":"https://avatars.githubusercontent.com/u/902700?v=3","gravatar_id":"","url":"https://api.github.com/users/jakesmith","html_url":"https://github.com/jakesmith","followers_url":"https://api.github.com/users/jakesmith/followers","following_url":"https://api.github.com/users/jakesmith/following{/other_user}","gists_url":"https://api.github.com/users/jakesmith/gists{/gist_id}","starred_url":"https://api.github.com/users/jakesmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakesmith/subscriptions","organizations_url":"https://api.github.com/users/jakesmith/orgs","repos_url":"https://api.github.com/users/jakesmith/repos","events_url":"https://api.github.com/users/jakesmith/events{/privacy}","received_events_url":"https://api.github.com/users/jakesmith/received_events","type":"User","site_admin":false},"repo":{"id":2041370,"name":"HPCC-Platform","full_name":"jakesmith/HPCC-Platform","owner":{"login":"jakesmith","id":902700,"avatar_url":"https://avatars.githubusercontent.com/u/902700?v=3","gravatar_id":"","url":"https://api.github.com/users/jakesmith","html_url":"https://github.com/jakesmith","followers_url":"https://api.github.com/users/jakesmith/followers","following_url":"https://api.github.com/users/jakesmith/following{/other_user}","gists_url":"https://api.github.com/users/jakesmith/gists{/gist_id}","starred_url":"https://api.github.com/users/jakesmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakesmith/subscriptions","organizations_url":"https://api.github.com/users/jakesmith/orgs","repos_url":"https://api.github.com/users/jakesmith/repos","events_url":"https://api.github.com/users/jakesmith/events{/privacy}","received_events_url":"https://api.github.com/users/jakesmith/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jakesmith/HPCC-Platform","description":"HPCC Systems big data solution, community edition","fork":true,"url":"https://api.github.com/repos/jakesmith/HPCC-Platform","forks_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/forks","keys_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/teams","hooks_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/hooks","issue_events_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/issues/events{/number}","events_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/events","assignees_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/assignees{/user}","branches_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/branches{/branch}","tags_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/tags","blobs_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/statuses/{sha}","languages_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/languages","stargazers_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/stargazers","contributors_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/contributors","subscribers_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/subscribers","subscription_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/subscription","commits_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/contents/{+path}","compare_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/merges","archive_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/downloads","issues_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/issues{/number}","pulls_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/pulls{/number}","milestones_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/milestones{/number}","notifications_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/labels{/name}","releases_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/releases{/id}","deployments_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/deployments","created_at":"2011-07-13T10:47:52Z","updated_at":"2014-09-16T18:05:11Z","pushed_at":"2016-10-27T12:13:11Z","git_url":"git://github.com/jakesmith/HPCC-Platform.git","ssh_url":"git@github.com:jakesmith/HPCC-Platform.git","clone_url":"https://github.com/jakesmith/HPCC-Platform.git","svn_url":"https://github.com/jakesmith/HPCC-Platform","homepage":"www.hpccsystems.com","size":169749,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":7,"forks":0,"open_issues":7,"watchers":1,"default_branch":"master"}},"base":{"label":"hpcc-systems:candidate-6.0.8","ref":"candidate-6.0.8","sha":"da64f329cb5f5d0db96af3f2c5b39f4434ac6648","user":{"login":"hpcc-systems","id":900867,"avatar_url":"https://avatars.githubusercontent.com/u/900867?v=3","gravatar_id":"","url":"https://api.github.com/users/hpcc-systems","html_url":"https://github.com/hpcc-systems","followers_url":"https://api.github.com/users/hpcc-systems/followers","following_url":"https://api.github.com/users/hpcc-systems/following{/other_user}","gists_url":"https://api.github.com/users/hpcc-systems/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcc-systems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcc-systems/subscriptions","organizations_url":"https://api.github.com/users/hpcc-systems/orgs","repos_url":"https://api.github.com/users/hpcc-systems/repos","events_url":"https://api.github.com/users/hpcc-systems/events{/privacy}","received_events_url":"https://api.github.com/users/hpcc-systems/received_events","type":"Organization","site_admin":false},"repo":{"id":2030681,"name":"HPCC-Platform","full_name":"hpcc-systems/HPCC-Platform","owner":{"login":"hpcc-systems","id":900867,"avatar_url":"https://avatars.githubusercontent.com/u/900867?v=3","gravatar_id":"","url":"https://api.github.com/users/hpcc-systems","html_url":"https://github.com/hpcc-systems","followers_url":"https://api.github.com/users/hpcc-systems/followers","following_url":"https://api.github.com/users/hpcc-systems/following{/other_user}","gists_url":"https://api.github.com/users/hpcc-systems/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcc-systems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcc-systems/subscriptions","organizations_url":"https://api.github.com/users/hpcc-systems/orgs","repos_url":"https://api.github.com/users/hpcc-systems/repos","events_url":"https://api.github.com/users/hpcc-systems/events{/privacy}","received_events_url":"https://api.github.com/users/hpcc-systems/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hpcc-systems/HPCC-Platform","description":"HPCC Systems (High Performance Computing Cluster) is an open source, massive parallel-processing computing platform for big data processing and analytics.","fork":false,"url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform","forks_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/forks","keys_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/teams","hooks_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/hooks","issue_events_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/events{/number}","events_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/events","assignees_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/assignees{/user}","branches_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/branches{/branch}","tags_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/tags","blobs_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/statuses/{sha}","languages_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/languages","stargazers_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/stargazers","contributors_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/contributors","subscribers_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/subscribers","subscription_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/subscription","commits_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/contents/{+path}","compare_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/merges","archive_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/downloads","issues_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues{/number}","pulls_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls{/number}","milestones_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/milestones{/number}","notifications_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/labels{/name}","releases_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/releases{/id}","deployments_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/deployments","created_at":"2011-07-11T14:29:51Z","updated_at":"2016-10-27T03:02:03Z","pushed_at":"2016-10-27T12:18:46Z","git_url":"git://github.com/hpcc-systems/HPCC-Platform.git","ssh_url":"git@github.com:hpcc-systems/HPCC-Platform.git","clone_url":"https://github.com/hpcc-systems/HPCC-Platform.git","svn_url":"https://github.com/hpcc-systems/HPCC-Platform","homepage":"http://hpccsystems.com","size":184893,"stargazers_count":293,"watchers_count":293,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":153,"mirror_url":null,"open_issues_count":425,"forks":153,"open_issues":425,"watchers":293,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/9281"},"html":{"href":"https://github.com/hpcc-systems/HPCC-Platform/pull/9281"},"issue":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/9281"},"comments":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/9281/comments"},"review_comments":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/9281/comments"},"review_comment":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/9281/commits"},"statuses":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/statuses/3a60f802b4d4922aede5750282c141e3a867547b"}}}}
{"actor":{"display_login":"mckellyln"}}