{"action":"created","comment":{"url":"https://api.github.com/repos/yast/yast-yast2/pulls/comments/63697203","id":63697203,"diff_hunk":"@@ -10,6 +10,14 @@\n describe Yast::SuSEFirewallProposal do\n   subject { Yast::SuSEFirewallProposal }\n \n+  before :example do\n+    # We shouldn't run this test if firewalld is running\n+    if Yast::SuSEFirewall.is_a?(Yast::SuSEFirewalldClass)\n+      skip \"FirewallD backend is not supported by this test\" do\n+      end\n+    end\n+  end","path":"library/network/test/susefirewall_proposal_test.rb","position":10,"original_position":10,"commit_id":"78316d1b3f95ec31781613c912271b819bb2edda","original_commit_id":"78316d1b3f95ec31781613c912271b819bb2edda","user":{"login":"jreidinger","id":478871,"avatar_url":"https://avatars.githubusercontent.com/u/478871?v=3","gravatar_id":"","url":"https://api.github.com/users/jreidinger","html_url":"https://github.com/jreidinger","followers_url":"https://api.github.com/users/jreidinger/followers","following_url":"https://api.github.com/users/jreidinger/following{/other_user}","gists_url":"https://api.github.com/users/jreidinger/gists{/gist_id}","starred_url":"https://api.github.com/users/jreidinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jreidinger/subscriptions","organizations_url":"https://api.github.com/users/jreidinger/orgs","repos_url":"https://api.github.com/users/jreidinger/repos","events_url":"https://api.github.com/users/jreidinger/events{/privacy}","received_events_url":"https://api.github.com/users/jreidinger/received_events","type":"User","site_admin":false},"body":"Sorry, but this is not unit test. Unit test really should not depend on runtime environement. It will produce unpredictable results.","created_at":"2016-05-18T12:59:29Z","updated_at":"2016-05-18T12:59:29Z","html_url":"https://github.com/yast/yast-yast2/pull/457#discussion_r63697203","pull_request_url":"https://api.github.com/repos/yast/yast-yast2/pulls/457","_links":{"self":{"href":"https://api.github.com/repos/yast/yast-yast2/pulls/comments/63697203"},"html":{"href":"https://github.com/yast/yast-yast2/pull/457#discussion_r63697203"},"pull_request":{"href":"https://api.github.com/repos/yast/yast-yast2/pulls/457"}}},"pull_request":{"url":"https://api.github.com/repos/yast/yast-yast2/pulls/457","id":65462738,"html_url":"https://github.com/yast/yast-yast2/pull/457","diff_url":"https://github.com/yast/yast-yast2/pull/457.diff","patch_url":"https://github.com/yast/yast-yast2/pull/457.patch","issue_url":"https://api.github.com/repos/yast/yast-yast2/issues/457","number":457,"state":"open","locked":false,"title":"Add FirewallD support to SuSEFirewall2 backend","user":{"login":"hwoarang","id":45309,"avatar_url":"https://avatars.githubusercontent.com/u/45309?v=3","gravatar_id":"","url":"https://api.github.com/users/hwoarang","html_url":"https://github.com/hwoarang","followers_url":"https://api.github.com/users/hwoarang/followers","following_url":"https://api.github.com/users/hwoarang/following{/other_user}","gists_url":"https://api.github.com/users/hwoarang/gists{/gist_id}","starred_url":"https://api.github.com/users/hwoarang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hwoarang/subscriptions","organizations_url":"https://api.github.com/users/hwoarang/orgs","repos_url":"https://api.github.com/users/hwoarang/repos","events_url":"https://api.github.com/users/hwoarang/events{/privacy}","received_events_url":"https://api.github.com/users/hwoarang/received_events","type":"User","site_admin":false},"body":"Hi,\r\n\r\nThis patchset extends the SuSEFirewall2 backend with FirewallD ([website](http://www.firewalld.org/), [OBS package](https://build.opensuse.org/package/show/openSUSE:Factory/firewalld)) support. The goal is for yast2 modules to be able to use either SuSEfirewall2 or FirewallD to perform their regular firewall configurations depending on which one is running on the system. Not all methods have been added to FirewallD since some of them do not appear to be used anymore. If something is missing I will fix it in a subsequent commit as bugs or limitations are being identified by the broader adoption and use of the extended API.\r\n\r\nThe only known limitation so far is in the testsuite where firewalld tests can't run in parallel with SuSEfirewall2. The reason for that is that they both manipulate the Yast::SuSEFirewall and Yast::SuSEFirewallServices objects so if these tests run in parallel strange things can happen ;) The solution so far is to disable either SuSEfirewall2 or FirewallD tests based on which backend is running as I couldn't find a way to disable parallelism on library/network/test/* files. I believe that using \"doubles\" or using rspec mock to fake methods is not going to actually tests the backend properly so the testsuite will end up being mostly useless. If you happen to know of the proper way to disable parallelism in a specific subdir please let me know. In the meantime I didn't want to delay the PR because of that as I want to get some broader testing of the extended code.\r\n\r\nThank you","created_at":"2016-04-06T13:08:22Z","updated_at":"2016-05-18T12:59:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a7a0c171773f37b20712b9f60b4c14067e7d3dab","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/yast/yast-yast2/pulls/457/commits","review_comments_url":"https://api.github.com/repos/yast/yast-yast2/pulls/457/comments","review_comment_url":"https://api.github.com/repos/yast/yast-yast2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yast/yast-yast2/issues/457/comments","statuses_url":"https://api.github.com/repos/yast/yast-yast2/statuses/78316d1b3f95ec31781613c912271b819bb2edda","head":{"label":"hwoarang:firewalld","ref":"firewalld","sha":"78316d1b3f95ec31781613c912271b819bb2edda","user":{"login":"hwoarang","id":45309,"avatar_url":"https://avatars.githubusercontent.com/u/45309?v=3","gravatar_id":"","url":"https://api.github.com/users/hwoarang","html_url":"https://github.com/hwoarang","followers_url":"https://api.github.com/users/hwoarang/followers","following_url":"https://api.github.com/users/hwoarang/following{/other_user}","gists_url":"https://api.github.com/users/hwoarang/gists{/gist_id}","starred_url":"https://api.github.com/users/hwoarang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hwoarang/subscriptions","organizations_url":"https://api.github.com/users/hwoarang/orgs","repos_url":"https://api.github.com/users/hwoarang/repos","events_url":"https://api.github.com/users/hwoarang/events{/privacy}","received_events_url":"https://api.github.com/users/hwoarang/received_events","type":"User","site_admin":false},"repo":{"id":50931867,"name":"yast-yast2","full_name":"hwoarang/yast-yast2","owner":{"login":"hwoarang","id":45309,"avatar_url":"https://avatars.githubusercontent.com/u/45309?v=3","gravatar_id":"","url":"https://api.github.com/users/hwoarang","html_url":"https://github.com/hwoarang","followers_url":"https://api.github.com/users/hwoarang/followers","following_url":"https://api.github.com/users/hwoarang/following{/other_user}","gists_url":"https://api.github.com/users/hwoarang/gists{/gist_id}","starred_url":"https://api.github.com/users/hwoarang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hwoarang/subscriptions","organizations_url":"https://api.github.com/users/hwoarang/orgs","repos_url":"https://api.github.com/users/hwoarang/repos","events_url":"https://api.github.com/users/hwoarang/events{/privacy}","received_events_url":"https://api.github.com/users/hwoarang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hwoarang/yast-yast2","description":"YaST module yast2","fork":true,"url":"https://api.github.com/repos/hwoarang/yast-yast2","forks_url":"https://api.github.com/repos/hwoarang/yast-yast2/forks","keys_url":"https://api.github.com/repos/hwoarang/yast-yast2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hwoarang/yast-yast2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hwoarang/yast-yast2/teams","hooks_url":"https://api.github.com/repos/hwoarang/yast-yast2/hooks","issue_events_url":"https://api.github.com/repos/hwoarang/yast-yast2/issues/events{/number}","events_url":"https://api.github.com/repos/hwoarang/yast-yast2/events","assignees_url":"https://api.github.com/repos/hwoarang/yast-yast2/assignees{/user}","branches_url":"https://api.github.com/repos/hwoarang/yast-yast2/branches{/branch}","tags_url":"https://api.github.com/repos/hwoarang/yast-yast2/tags","blobs_url":"https://api.github.com/repos/hwoarang/yast-yast2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hwoarang/yast-yast2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hwoarang/yast-yast2/git/refs{/sha}","trees_url":"https://api.github.com/repos/hwoarang/yast-yast2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hwoarang/yast-yast2/statuses/{sha}","languages_url":"https://api.github.com/repos/hwoarang/yast-yast2/languages","stargazers_url":"https://api.github.com/repos/hwoarang/yast-yast2/stargazers","contributors_url":"https://api.github.com/repos/hwoarang/yast-yast2/contributors","subscribers_url":"https://api.github.com/repos/hwoarang/yast-yast2/subscribers","subscription_url":"https://api.github.com/repos/hwoarang/yast-yast2/subscription","commits_url":"https://api.github.com/repos/hwoarang/yast-yast2/commits{/sha}","git_commits_url":"https://api.github.com/repos/hwoarang/yast-yast2/git/commits{/sha}","comments_url":"https://api.github.com/repos/hwoarang/yast-yast2/comments{/number}","issue_comment_url":"https://api.github.com/repos/hwoarang/yast-yast2/issues/comments{/number}","contents_url":"https://api.github.com/repos/hwoarang/yast-yast2/contents/{+path}","compare_url":"https://api.github.com/repos/hwoarang/yast-yast2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hwoarang/yast-yast2/merges","archive_url":"https://api.github.com/repos/hwoarang/yast-yast2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hwoarang/yast-yast2/downloads","issues_url":"https://api.github.com/repos/hwoarang/yast-yast2/issues{/number}","pulls_url":"https://api.github.com/repos/hwoarang/yast-yast2/pulls{/number}","milestones_url":"https://api.github.com/repos/hwoarang/yast-yast2/milestones{/number}","notifications_url":"https://api.github.com/repos/hwoarang/yast-yast2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hwoarang/yast-yast2/labels{/name}","releases_url":"https://api.github.com/repos/hwoarang/yast-yast2/releases{/id}","deployments_url":"https://api.github.com/repos/hwoarang/yast-yast2/deployments","created_at":"2016-02-02T15:52:54Z","updated_at":"2016-02-02T15:52:56Z","pushed_at":"2016-04-29T09:45:41Z","git_url":"git://github.com/hwoarang/yast-yast2.git","ssh_url":"git@github.com:hwoarang/yast-yast2.git","clone_url":"https://github.com/hwoarang/yast-yast2.git","svn_url":"https://github.com/hwoarang/yast-yast2","homepage":"http://en.opensuse.org/Portal:YaST","size":23952,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"yast:master","ref":"master","sha":"8b6db2775c8be3e16f551fed32a8d377603625db","user":{"login":"yast","id":909990,"avatar_url":"https://avatars.githubusercontent.com/u/909990?v=3","gravatar_id":"","url":"https://api.github.com/users/yast","html_url":"https://github.com/yast","followers_url":"https://api.github.com/users/yast/followers","following_url":"https://api.github.com/users/yast/following{/other_user}","gists_url":"https://api.github.com/users/yast/gists{/gist_id}","starred_url":"https://api.github.com/users/yast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yast/subscriptions","organizations_url":"https://api.github.com/users/yast/orgs","repos_url":"https://api.github.com/users/yast/repos","events_url":"https://api.github.com/users/yast/events{/privacy}","received_events_url":"https://api.github.com/users/yast/received_events","type":"Organization","site_admin":false},"repo":{"id":4368244,"name":"yast-yast2","full_name":"yast/yast-yast2","owner":{"login":"yast","id":909990,"avatar_url":"https://avatars.githubusercontent.com/u/909990?v=3","gravatar_id":"","url":"https://api.github.com/users/yast","html_url":"https://github.com/yast","followers_url":"https://api.github.com/users/yast/followers","following_url":"https://api.github.com/users/yast/following{/other_user}","gists_url":"https://api.github.com/users/yast/gists{/gist_id}","starred_url":"https://api.github.com/users/yast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yast/subscriptions","organizations_url":"https://api.github.com/users/yast/orgs","repos_url":"https://api.github.com/users/yast/repos","events_url":"https://api.github.com/users/yast/events{/privacy}","received_events_url":"https://api.github.com/users/yast/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yast/yast-yast2","description":"YaST module yast2","fork":false,"url":"https://api.github.com/repos/yast/yast-yast2","forks_url":"https://api.github.com/repos/yast/yast-yast2/forks","keys_url":"https://api.github.com/repos/yast/yast-yast2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yast/yast-yast2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yast/yast-yast2/teams","hooks_url":"https://api.github.com/repos/yast/yast-yast2/hooks","issue_events_url":"https://api.github.com/repos/yast/yast-yast2/issues/events{/number}","events_url":"https://api.github.com/repos/yast/yast-yast2/events","assignees_url":"https://api.github.com/repos/yast/yast-yast2/assignees{/user}","branches_url":"https://api.github.com/repos/yast/yast-yast2/branches{/branch}","tags_url":"https://api.github.com/repos/yast/yast-yast2/tags","blobs_url":"https://api.github.com/repos/yast/yast-yast2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yast/yast-yast2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yast/yast-yast2/git/refs{/sha}","trees_url":"https://api.github.com/repos/yast/yast-yast2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yast/yast-yast2/statuses/{sha}","languages_url":"https://api.github.com/repos/yast/yast-yast2/languages","stargazers_url":"https://api.github.com/repos/yast/yast-yast2/stargazers","contributors_url":"https://api.github.com/repos/yast/yast-yast2/contributors","subscribers_url":"https://api.github.com/repos/yast/yast-yast2/subscribers","subscription_url":"https://api.github.com/repos/yast/yast-yast2/subscription","commits_url":"https://api.github.com/repos/yast/yast-yast2/commits{/sha}","git_commits_url":"https://api.github.com/repos/yast/yast-yast2/git/commits{/sha}","comments_url":"https://api.github.com/repos/yast/yast-yast2/comments{/number}","issue_comment_url":"https://api.github.com/repos/yast/yast-yast2/issues/comments{/number}","contents_url":"https://api.github.com/repos/yast/yast-yast2/contents/{+path}","compare_url":"https://api.github.com/repos/yast/yast-yast2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yast/yast-yast2/merges","archive_url":"https://api.github.com/repos/yast/yast-yast2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yast/yast-yast2/downloads","issues_url":"https://api.github.com/repos/yast/yast-yast2/issues{/number}","pulls_url":"https://api.github.com/repos/yast/yast-yast2/pulls{/number}","milestones_url":"https://api.github.com/repos/yast/yast-yast2/milestones{/number}","notifications_url":"https://api.github.com/repos/yast/yast-yast2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yast/yast-yast2/labels{/name}","releases_url":"https://api.github.com/repos/yast/yast-yast2/releases{/id}","deployments_url":"https://api.github.com/repos/yast/yast-yast2/deployments","created_at":"2012-05-18T10:27:22Z","updated_at":"2016-05-11T02:28:18Z","pushed_at":"2016-05-18T11:41:39Z","git_url":"git://github.com/yast/yast-yast2.git","ssh_url":"git@github.com:yast/yast-yast2.git","clone_url":"https://github.com/yast/yast-yast2.git","svn_url":"https://github.com/yast/yast-yast2","homepage":"http://en.opensuse.org/Portal:YaST","size":24888,"stargazers_count":15,"watchers_count":15,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":27,"mirror_url":null,"open_issues_count":7,"forks":27,"open_issues":7,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yast/yast-yast2/pulls/457"},"html":{"href":"https://github.com/yast/yast-yast2/pull/457"},"issue":{"href":"https://api.github.com/repos/yast/yast-yast2/issues/457"},"comments":{"href":"https://api.github.com/repos/yast/yast-yast2/issues/457/comments"},"review_comments":{"href":"https://api.github.com/repos/yast/yast-yast2/pulls/457/comments"},"review_comment":{"href":"https://api.github.com/repos/yast/yast-yast2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yast/yast-yast2/pulls/457/commits"},"statuses":{"href":"https://api.github.com/repos/yast/yast-yast2/statuses/78316d1b3f95ec31781613c912271b819bb2edda"}}}}