{"action":"created","comment":{"url":"https://api.github.com/repos/untitaker/rust-vobject/pulls/comments/53552369","id":53552369,"diff_hunk":"@@ -269,20 +317,20 @@ impl<'s> Parser<'s> {\n             x > '\\u{1F}'\n         };\n \n-        if self.peek() == Some('\"') {\n+        if self.peek() == Some(('\"', 1)) {\n             self.consume_char();\n-            let rv = self.consume_while(qsafe).to_owned();\n+            let rv = self.consume_while(qsafe);\n             try!(self.assert_char('\"'));\n             self.consume_char();\n             Ok(rv)\n         } else {\n-            Ok(self.consume_while(|x| qsafe(x) && x != ';' && x != ':').to_owned())\n+            Ok(self.consume_while(|x| qsafe(x) && x != ';' && x != ':'))\n         }\n     }\n \n     fn consume_param<'a>(&'a mut self) -> ParseResult<(String, String)> {\n         let name = try!(self.consume_param_name());\n-        let value = if self.peek() == Some('=') {\n+        let value = if self.peek() == Some(('=', 1)) {","path":"src/vobject/lib.rs","position":154,"original_position":154,"commit_id":"9e867bfd779894d602487d4fbaabe5d63d94cb52","original_commit_id":"9e867bfd779894d602487d4fbaabe5d63d94cb52","user":{"login":"untitaker","id":837573,"avatar_url":"https://avatars.githubusercontent.com/u/837573?v=3","gravatar_id":"","url":"https://api.github.com/users/untitaker","html_url":"https://github.com/untitaker","followers_url":"https://api.github.com/users/untitaker/followers","following_url":"https://api.github.com/users/untitaker/following{/other_user}","gists_url":"https://api.github.com/users/untitaker/gists{/gist_id}","starred_url":"https://api.github.com/users/untitaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/untitaker/subscriptions","organizations_url":"https://api.github.com/users/untitaker/orgs","repos_url":"https://api.github.com/users/untitaker/repos","events_url":"https://api.github.com/users/untitaker/events{/privacy}","received_events_url":"https://api.github.com/users/untitaker/received_events","type":"User","site_admin":false},"body":"Do we actually require offset == 1 in this conditional?","created_at":"2016-02-20T15:50:33Z","updated_at":"2016-02-20T15:50:33Z","html_url":"https://github.com/untitaker/rust-vobject/pull/9#discussion_r53552369","pull_request_url":"https://api.github.com/repos/untitaker/rust-vobject/pulls/9","_links":{"self":{"href":"https://api.github.com/repos/untitaker/rust-vobject/pulls/comments/53552369"},"html":{"href":"https://github.com/untitaker/rust-vobject/pull/9#discussion_r53552369"},"pull_request":{"href":"https://api.github.com/repos/untitaker/rust-vobject/pulls/9"}}},"pull_request":{"url":"https://api.github.com/repos/untitaker/rust-vobject/pulls/9","id":60051169,"html_url":"https://github.com/untitaker/rust-vobject/pull/9","diff_url":"https://github.com/untitaker/rust-vobject/pull/9.diff","patch_url":"https://github.com/untitaker/rust-vobject/pull/9.patch","issue_url":"https://api.github.com/repos/untitaker/rust-vobject/issues/9","number":9,"state":"open","locked":false,"title":"Generalized line unfolding in parser (issue #2)","user":{"login":"gracinet","id":474220,"avatar_url":"https://avatars.githubusercontent.com/u/474220?v=3","gravatar_id":"","url":"https://api.github.com/users/gracinet","html_url":"https://github.com/gracinet","followers_url":"https://api.github.com/users/gracinet/followers","following_url":"https://api.github.com/users/gracinet/following{/other_user}","gists_url":"https://api.github.com/users/gracinet/gists{/gist_id}","starred_url":"https://api.github.com/users/gracinet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gracinet/subscriptions","organizations_url":"https://api.github.com/users/gracinet/orgs","repos_url":"https://api.github.com/users/gracinet/repos","events_url":"https://api.github.com/users/gracinet/events{/privacy}","received_events_url":"https://api.github.com/users/gracinet/received_events","type":"User","site_admin":false},"body":"Ignoring (CR)LF followed by a single whitespace char is now done in peek()\r\nand therefore is enforced in all processing.\r\n\r\nThis version has been able to parse a full ics file exported from Google (the very one with which I encountered issue #2).\r\nThis is work in progress, and my actual first non utterly trivial code in Rust, don't hesitate to say if the approach taken doesn't suit you, or if assumptions about efficiency are wrong etc.\r\n\r\nSome choices:\r\n\r\n- in `consume_while()`, tried to minimize the copying operations, but it can't return a str (slice) \r\n  anymore in any case.\r\n- for simplicity, I discarded CR completely from peek_at(). If you agree with this, some conditions \r\n  downstream (consume_eol()...) can be simplified.\r\n","created_at":"2016-02-20T15:33:06Z","updated_at":"2016-02-20T15:50:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"35d19c0f1e5e87bf0b5f560d08821a2eb6d5f1e2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/untitaker/rust-vobject/pulls/9/commits","review_comments_url":"https://api.github.com/repos/untitaker/rust-vobject/pulls/9/comments","review_comment_url":"https://api.github.com/repos/untitaker/rust-vobject/pulls/comments{/number}","comments_url":"https://api.github.com/repos/untitaker/rust-vobject/issues/9/comments","statuses_url":"https://api.github.com/repos/untitaker/rust-vobject/statuses/9e867bfd779894d602487d4fbaabe5d63d94cb52","head":{"label":"gracinet:master","ref":"master","sha":"9e867bfd779894d602487d4fbaabe5d63d94cb52","user":{"login":"gracinet","id":474220,"avatar_url":"https://avatars.githubusercontent.com/u/474220?v=3","gravatar_id":"","url":"https://api.github.com/users/gracinet","html_url":"https://github.com/gracinet","followers_url":"https://api.github.com/users/gracinet/followers","following_url":"https://api.github.com/users/gracinet/following{/other_user}","gists_url":"https://api.github.com/users/gracinet/gists{/gist_id}","starred_url":"https://api.github.com/users/gracinet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gracinet/subscriptions","organizations_url":"https://api.github.com/users/gracinet/orgs","repos_url":"https://api.github.com/users/gracinet/repos","events_url":"https://api.github.com/users/gracinet/events{/privacy}","received_events_url":"https://api.github.com/users/gracinet/received_events","type":"User","site_admin":false},"repo":{"id":52107982,"name":"rust-vobject","full_name":"gracinet/rust-vobject","owner":{"login":"gracinet","id":474220,"avatar_url":"https://avatars.githubusercontent.com/u/474220?v=3","gravatar_id":"","url":"https://api.github.com/users/gracinet","html_url":"https://github.com/gracinet","followers_url":"https://api.github.com/users/gracinet/followers","following_url":"https://api.github.com/users/gracinet/following{/other_user}","gists_url":"https://api.github.com/users/gracinet/gists{/gist_id}","starred_url":"https://api.github.com/users/gracinet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gracinet/subscriptions","organizations_url":"https://api.github.com/users/gracinet/orgs","repos_url":"https://api.github.com/users/gracinet/repos","events_url":"https://api.github.com/users/gracinet/events{/privacy}","received_events_url":"https://api.github.com/users/gracinet/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gracinet/rust-vobject","description":"VObject parser and generator for Rust","fork":true,"url":"https://api.github.com/repos/gracinet/rust-vobject","forks_url":"https://api.github.com/repos/gracinet/rust-vobject/forks","keys_url":"https://api.github.com/repos/gracinet/rust-vobject/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gracinet/rust-vobject/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gracinet/rust-vobject/teams","hooks_url":"https://api.github.com/repos/gracinet/rust-vobject/hooks","issue_events_url":"https://api.github.com/repos/gracinet/rust-vobject/issues/events{/number}","events_url":"https://api.github.com/repos/gracinet/rust-vobject/events","assignees_url":"https://api.github.com/repos/gracinet/rust-vobject/assignees{/user}","branches_url":"https://api.github.com/repos/gracinet/rust-vobject/branches{/branch}","tags_url":"https://api.github.com/repos/gracinet/rust-vobject/tags","blobs_url":"https://api.github.com/repos/gracinet/rust-vobject/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gracinet/rust-vobject/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gracinet/rust-vobject/git/refs{/sha}","trees_url":"https://api.github.com/repos/gracinet/rust-vobject/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gracinet/rust-vobject/statuses/{sha}","languages_url":"https://api.github.com/repos/gracinet/rust-vobject/languages","stargazers_url":"https://api.github.com/repos/gracinet/rust-vobject/stargazers","contributors_url":"https://api.github.com/repos/gracinet/rust-vobject/contributors","subscribers_url":"https://api.github.com/repos/gracinet/rust-vobject/subscribers","subscription_url":"https://api.github.com/repos/gracinet/rust-vobject/subscription","commits_url":"https://api.github.com/repos/gracinet/rust-vobject/commits{/sha}","git_commits_url":"https://api.github.com/repos/gracinet/rust-vobject/git/commits{/sha}","comments_url":"https://api.github.com/repos/gracinet/rust-vobject/comments{/number}","issue_comment_url":"https://api.github.com/repos/gracinet/rust-vobject/issues/comments{/number}","contents_url":"https://api.github.com/repos/gracinet/rust-vobject/contents/{+path}","compare_url":"https://api.github.com/repos/gracinet/rust-vobject/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gracinet/rust-vobject/merges","archive_url":"https://api.github.com/repos/gracinet/rust-vobject/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gracinet/rust-vobject/downloads","issues_url":"https://api.github.com/repos/gracinet/rust-vobject/issues{/number}","pulls_url":"https://api.github.com/repos/gracinet/rust-vobject/pulls{/number}","milestones_url":"https://api.github.com/repos/gracinet/rust-vobject/milestones{/number}","notifications_url":"https://api.github.com/repos/gracinet/rust-vobject/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gracinet/rust-vobject/labels{/name}","releases_url":"https://api.github.com/repos/gracinet/rust-vobject/releases{/id}","deployments_url":"https://api.github.com/repos/gracinet/rust-vobject/deployments","created_at":"2016-02-19T18:32:46Z","updated_at":"2016-02-19T18:32:47Z","pushed_at":"2016-02-20T15:21:23Z","git_url":"git://github.com/gracinet/rust-vobject.git","ssh_url":"git@github.com:gracinet/rust-vobject.git","clone_url":"https://github.com/gracinet/rust-vobject.git","svn_url":"https://github.com/gracinet/rust-vobject","homepage":"http://rust-vobject.unterwaditzer.net/","size":45,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"untitaker:master","ref":"master","sha":"10b30e94ba8de939e052839f9b2a4a832521721e","user":{"login":"untitaker","id":837573,"avatar_url":"https://avatars.githubusercontent.com/u/837573?v=3","gravatar_id":"","url":"https://api.github.com/users/untitaker","html_url":"https://github.com/untitaker","followers_url":"https://api.github.com/users/untitaker/followers","following_url":"https://api.github.com/users/untitaker/following{/other_user}","gists_url":"https://api.github.com/users/untitaker/gists{/gist_id}","starred_url":"https://api.github.com/users/untitaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/untitaker/subscriptions","organizations_url":"https://api.github.com/users/untitaker/orgs","repos_url":"https://api.github.com/users/untitaker/repos","events_url":"https://api.github.com/users/untitaker/events{/privacy}","received_events_url":"https://api.github.com/users/untitaker/received_events","type":"User","site_admin":false},"repo":{"id":26365146,"name":"rust-vobject","full_name":"untitaker/rust-vobject","owner":{"login":"untitaker","id":837573,"avatar_url":"https://avatars.githubusercontent.com/u/837573?v=3","gravatar_id":"","url":"https://api.github.com/users/untitaker","html_url":"https://github.com/untitaker","followers_url":"https://api.github.com/users/untitaker/followers","following_url":"https://api.github.com/users/untitaker/following{/other_user}","gists_url":"https://api.github.com/users/untitaker/gists{/gist_id}","starred_url":"https://api.github.com/users/untitaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/untitaker/subscriptions","organizations_url":"https://api.github.com/users/untitaker/orgs","repos_url":"https://api.github.com/users/untitaker/repos","events_url":"https://api.github.com/users/untitaker/events{/privacy}","received_events_url":"https://api.github.com/users/untitaker/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/untitaker/rust-vobject","description":"VObject parser and generator for Rust","fork":false,"url":"https://api.github.com/repos/untitaker/rust-vobject","forks_url":"https://api.github.com/repos/untitaker/rust-vobject/forks","keys_url":"https://api.github.com/repos/untitaker/rust-vobject/keys{/key_id}","collaborators_url":"https://api.github.com/repos/untitaker/rust-vobject/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/untitaker/rust-vobject/teams","hooks_url":"https://api.github.com/repos/untitaker/rust-vobject/hooks","issue_events_url":"https://api.github.com/repos/untitaker/rust-vobject/issues/events{/number}","events_url":"https://api.github.com/repos/untitaker/rust-vobject/events","assignees_url":"https://api.github.com/repos/untitaker/rust-vobject/assignees{/user}","branches_url":"https://api.github.com/repos/untitaker/rust-vobject/branches{/branch}","tags_url":"https://api.github.com/repos/untitaker/rust-vobject/tags","blobs_url":"https://api.github.com/repos/untitaker/rust-vobject/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/untitaker/rust-vobject/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/untitaker/rust-vobject/git/refs{/sha}","trees_url":"https://api.github.com/repos/untitaker/rust-vobject/git/trees{/sha}","statuses_url":"https://api.github.com/repos/untitaker/rust-vobject/statuses/{sha}","languages_url":"https://api.github.com/repos/untitaker/rust-vobject/languages","stargazers_url":"https://api.github.com/repos/untitaker/rust-vobject/stargazers","contributors_url":"https://api.github.com/repos/untitaker/rust-vobject/contributors","subscribers_url":"https://api.github.com/repos/untitaker/rust-vobject/subscribers","subscription_url":"https://api.github.com/repos/untitaker/rust-vobject/subscription","commits_url":"https://api.github.com/repos/untitaker/rust-vobject/commits{/sha}","git_commits_url":"https://api.github.com/repos/untitaker/rust-vobject/git/commits{/sha}","comments_url":"https://api.github.com/repos/untitaker/rust-vobject/comments{/number}","issue_comment_url":"https://api.github.com/repos/untitaker/rust-vobject/issues/comments{/number}","contents_url":"https://api.github.com/repos/untitaker/rust-vobject/contents/{+path}","compare_url":"https://api.github.com/repos/untitaker/rust-vobject/compare/{base}...{head}","merges_url":"https://api.github.com/repos/untitaker/rust-vobject/merges","archive_url":"https://api.github.com/repos/untitaker/rust-vobject/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/untitaker/rust-vobject/downloads","issues_url":"https://api.github.com/repos/untitaker/rust-vobject/issues{/number}","pulls_url":"https://api.github.com/repos/untitaker/rust-vobject/pulls{/number}","milestones_url":"https://api.github.com/repos/untitaker/rust-vobject/milestones{/number}","notifications_url":"https://api.github.com/repos/untitaker/rust-vobject/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/untitaker/rust-vobject/labels{/name}","releases_url":"https://api.github.com/repos/untitaker/rust-vobject/releases{/id}","deployments_url":"https://api.github.com/repos/untitaker/rust-vobject/deployments","created_at":"2014-11-08T15:45:50Z","updated_at":"2015-10-21T12:30:06Z","pushed_at":"2016-02-20T15:33:06Z","git_url":"git://github.com/untitaker/rust-vobject.git","ssh_url":"git@github.com:untitaker/rust-vobject.git","clone_url":"https://github.com/untitaker/rust-vobject.git","svn_url":"https://github.com/untitaker/rust-vobject","homepage":"http://rust-vobject.unterwaditzer.net/","size":43,"stargazers_count":1,"watchers_count":1,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":3,"forks":1,"open_issues":3,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/untitaker/rust-vobject/pulls/9"},"html":{"href":"https://github.com/untitaker/rust-vobject/pull/9"},"issue":{"href":"https://api.github.com/repos/untitaker/rust-vobject/issues/9"},"comments":{"href":"https://api.github.com/repos/untitaker/rust-vobject/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/untitaker/rust-vobject/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/untitaker/rust-vobject/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/untitaker/rust-vobject/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/untitaker/rust-vobject/statuses/9e867bfd779894d602487d4fbaabe5d63d94cb52"}}}}