{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/pulls/comments/92723260","pull_request_review_id":13244656,"id":92723260,"diff_hunk":"@@ -16,65 +16,33 @@\n \n package com.google.cloud.pubsub;\n \n-import com.google.common.math.Stats;\n-import javax.annotation.concurrent.Immutable;\n+import com.google.auto.value.AutoValue;\n \n /**\n  * A snapshot of the subscriber statistics at the time they were requested from the {@link\n  * Subscriber}.\n  */\n //TODO: Finish implementation.\n-@Immutable\n-public class SubscriberStats {\n-  private final long totalReceivedMessages;\n-  private final long totalAckedMessages;\n-  private final Stats endToEndLatency;\n-  private final Stats ackLatency;\n-  private final long numberOfAutoExtendedAckDeadlines;\n-\n-  SubscriberStats() {\n-    this.totalReceivedMessages = 0;\n-    this.totalAckedMessages = 0;\n-    this.numberOfAutoExtendedAckDeadlines = 0;\n-    this.endToEndLatency = null;\n-    this.ackLatency = null;\n-  }\n-\n-  /** Number of successfully published messages. */\n-  public long getReceivedMessages() {\n-    return totalReceivedMessages;\n-  }\n-\n-  /** Number of successfully published messages. */\n-  public long getAckedMessages() {\n-    return totalAckedMessages;\n-  }\n+@AutoValue\n+public abstract class SubscriberStats {\n+  @AutoValue\n+  public static abstract class Stats {}","path":"google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/SubscriberStats.java","position":41,"original_position":41,"commit_id":"087427c76236ed1ca6a5ed98bfa10f93696f4c27","original_commit_id":"087427c76236ed1ca6a5ed98bfa10f93696f4c27","user":{"login":"pongad","id":1617025,"avatar_url":"https://avatars.githubusercontent.com/u/1617025?v=3","gravatar_id":"","url":"https://api.github.com/users/pongad","html_url":"https://github.com/pongad","followers_url":"https://api.github.com/users/pongad/followers","following_url":"https://api.github.com/users/pongad/following{/other_user}","gists_url":"https://api.github.com/users/pongad/gists{/gist_id}","starred_url":"https://api.github.com/users/pongad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pongad/subscriptions","organizations_url":"https://api.github.com/users/pongad/orgs","repos_url":"https://api.github.com/users/pongad/repos","events_url":"https://api.github.com/users/pongad/events{/privacy}","received_events_url":"https://api.github.com/users/pongad/received_events","type":"User","site_admin":false},"body":"Sorry, I should have been explicit in the commit msg.","created_at":"2016-12-15T23:28:29Z","updated_at":"2016-12-15T23:28:29Z","html_url":"https://github.com/GoogleCloudPlatform/google-cloud-java/pull/1480#discussion_r92723260","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/pulls/1480","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/pulls/comments/92723260"},"html":{"href":"https://github.com/GoogleCloudPlatform/google-cloud-java/pull/1480#discussion_r92723260"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/pulls/1480"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/pulls/1480","id":98249095,"html_url":"https://github.com/GoogleCloudPlatform/google-cloud-java/pull/1480","diff_url":"https://github.com/GoogleCloudPlatform/google-cloud-java/pull/1480.diff","patch_url":"https://github.com/GoogleCloudPlatform/google-cloud-java/pull/1480.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/issues/1480","number":1480,"state":"open","locked":false,"title":"use fewer guava classes in public surface","user":{"login":"pongad","id":1617025,"avatar_url":"https://avatars.githubusercontent.com/u/1617025?v=3","gravatar_id":"","url":"https://api.github.com/users/pongad","html_url":"https://github.com/pongad","followers_url":"https://api.github.com/users/pongad/followers","following_url":"https://api.github.com/users/pongad/following{/other_user}","gists_url":"https://api.github.com/users/pongad/gists{/gist_id}","starred_url":"https://api.github.com/users/pongad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pongad/subscriptions","organizations_url":"https://api.github.com/users/pongad/orgs","repos_url":"https://api.github.com/users/pongad/repos","events_url":"https://api.github.com/users/pongad/events{/privacy}","received_events_url":"https://api.github.com/users/pongad/received_events","type":"User","site_admin":false},"body":"- SubscriberImpl used to expose AbstractService.\r\n  We just make this package-private.\r\n- SubscriberStats defines its own Stats type.\r\n- SubsriberStats and PublisherStats are implemented with AutoValue.","created_at":"2016-12-15T23:05:41Z","updated_at":"2016-12-15T23:28:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"321d7949387b676e53c6f2072545ff6d8a2b256f","assignee":{"login":"garrettjonesgoogle","id":13341017,"avatar_url":"https://avatars.githubusercontent.com/u/13341017?v=3","gravatar_id":"","url":"https://api.github.com/users/garrettjonesgoogle","html_url":"https://github.com/garrettjonesgoogle","followers_url":"https://api.github.com/users/garrettjonesgoogle/followers","following_url":"https://api.github.com/users/garrettjonesgoogle/following{/other_user}","gists_url":"https://api.github.com/users/garrettjonesgoogle/gists{/gist_id}","starred_url":"https://api.github.com/users/garrettjonesgoogle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garrettjonesgoogle/subscriptions","organizations_url":"https://api.github.com/users/garrettjonesgoogle/orgs","repos_url":"https://api.github.com/users/garrettjonesgoogle/repos","events_url":"https://api.github.com/users/garrettjonesgoogle/events{/privacy}","received_events_url":"https://api.github.com/users/garrettjonesgoogle/received_events","type":"User","site_admin":false},"assignees":[{"login":"garrettjonesgoogle","id":13341017,"avatar_url":"https://avatars.githubusercontent.com/u/13341017?v=3","gravatar_id":"","url":"https://api.github.com/users/garrettjonesgoogle","html_url":"https://github.com/garrettjonesgoogle","followers_url":"https://api.github.com/users/garrettjonesgoogle/followers","following_url":"https://api.github.com/users/garrettjonesgoogle/following{/other_user}","gists_url":"https://api.github.com/users/garrettjonesgoogle/gists{/gist_id}","starred_url":"https://api.github.com/users/garrettjonesgoogle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garrettjonesgoogle/subscriptions","organizations_url":"https://api.github.com/users/garrettjonesgoogle/orgs","repos_url":"https://api.github.com/users/garrettjonesgoogle/repos","events_url":"https://api.github.com/users/garrettjonesgoogle/events{/privacy}","received_events_url":"https://api.github.com/users/garrettjonesgoogle/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/pulls/1480/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/pulls/1480/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/issues/1480/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/statuses/087427c76236ed1ca6a5ed98bfa10f93696f4c27","head":{"label":"pongad:deguava","ref":"deguava","sha":"087427c76236ed1ca6a5ed98bfa10f93696f4c27","user":{"login":"pongad","id":1617025,"avatar_url":"https://avatars.githubusercontent.com/u/1617025?v=3","gravatar_id":"","url":"https://api.github.com/users/pongad","html_url":"https://github.com/pongad","followers_url":"https://api.github.com/users/pongad/followers","following_url":"https://api.github.com/users/pongad/following{/other_user}","gists_url":"https://api.github.com/users/pongad/gists{/gist_id}","starred_url":"https://api.github.com/users/pongad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pongad/subscriptions","organizations_url":"https://api.github.com/users/pongad/orgs","repos_url":"https://api.github.com/users/pongad/repos","events_url":"https://api.github.com/users/pongad/events{/privacy}","received_events_url":"https://api.github.com/users/pongad/received_events","type":"User","site_admin":false},"repo":{"id":47151174,"name":"google-cloud-java","full_name":"pongad/google-cloud-java","owner":{"login":"pongad","id":1617025,"avatar_url":"https://avatars.githubusercontent.com/u/1617025?v=3","gravatar_id":"","url":"https://api.github.com/users/pongad","html_url":"https://github.com/pongad","followers_url":"https://api.github.com/users/pongad/followers","following_url":"https://api.github.com/users/pongad/following{/other_user}","gists_url":"https://api.github.com/users/pongad/gists{/gist_id}","starred_url":"https://api.github.com/users/pongad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pongad/subscriptions","organizations_url":"https://api.github.com/users/pongad/orgs","repos_url":"https://api.github.com/users/pongad/repos","events_url":"https://api.github.com/users/pongad/events{/privacy}","received_events_url":"https://api.github.com/users/pongad/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pongad/google-cloud-java","description":"Google Cloud Client Library for Java","fork":true,"url":"https://api.github.com/repos/pongad/google-cloud-java","forks_url":"https://api.github.com/repos/pongad/google-cloud-java/forks","keys_url":"https://api.github.com/repos/pongad/google-cloud-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pongad/google-cloud-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pongad/google-cloud-java/teams","hooks_url":"https://api.github.com/repos/pongad/google-cloud-java/hooks","issue_events_url":"https://api.github.com/repos/pongad/google-cloud-java/issues/events{/number}","events_url":"https://api.github.com/repos/pongad/google-cloud-java/events","assignees_url":"https://api.github.com/repos/pongad/google-cloud-java/assignees{/user}","branches_url":"https://api.github.com/repos/pongad/google-cloud-java/branches{/branch}","tags_url":"https://api.github.com/repos/pongad/google-cloud-java/tags","blobs_url":"https://api.github.com/repos/pongad/google-cloud-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pongad/google-cloud-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pongad/google-cloud-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/pongad/google-cloud-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pongad/google-cloud-java/statuses/{sha}","languages_url":"https://api.github.com/repos/pongad/google-cloud-java/languages","stargazers_url":"https://api.github.com/repos/pongad/google-cloud-java/stargazers","contributors_url":"https://api.github.com/repos/pongad/google-cloud-java/contributors","subscribers_url":"https://api.github.com/repos/pongad/google-cloud-java/subscribers","subscription_url":"https://api.github.com/repos/pongad/google-cloud-java/subscription","commits_url":"https://api.github.com/repos/pongad/google-cloud-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/pongad/google-cloud-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/pongad/google-cloud-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/pongad/google-cloud-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/pongad/google-cloud-java/contents/{+path}","compare_url":"https://api.github.com/repos/pongad/google-cloud-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pongad/google-cloud-java/merges","archive_url":"https://api.github.com/repos/pongad/google-cloud-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pongad/google-cloud-java/downloads","issues_url":"https://api.github.com/repos/pongad/google-cloud-java/issues{/number}","pulls_url":"https://api.github.com/repos/pongad/google-cloud-java/pulls{/number}","milestones_url":"https://api.github.com/repos/pongad/google-cloud-java/milestones{/number}","notifications_url":"https://api.github.com/repos/pongad/google-cloud-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pongad/google-cloud-java/labels{/name}","releases_url":"https://api.github.com/repos/pongad/google-cloud-java/releases{/id}","deployments_url":"https://api.github.com/repos/pongad/google-cloud-java/deployments","created_at":"2015-11-30T22:56:21Z","updated_at":"2016-12-04T23:35:55Z","pushed_at":"2016-12-15T23:04:44Z","git_url":"git://github.com/pongad/google-cloud-java.git","ssh_url":"git@github.com:pongad/google-cloud-java.git","clone_url":"https://github.com/pongad/google-cloud-java.git","svn_url":"https://github.com/pongad/google-cloud-java","homepage":"http://googlecloudplatform.github.io/gcloud-java/","size":8361,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:pubsub-hp","ref":"pubsub-hp","sha":"663d6cf6d1dfbfae7438345be574b3e5203173f0","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":26181278,"name":"google-cloud-java","full_name":"GoogleCloudPlatform/google-cloud-java","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/google-cloud-java","description":"Google Cloud Client Library for Java","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/deployments","created_at":"2014-11-04T17:57:16Z","updated_at":"2016-12-14T03:14:33Z","pushed_at":"2016-12-15T23:05:41Z","git_url":"git://github.com/GoogleCloudPlatform/google-cloud-java.git","ssh_url":"git@github.com:GoogleCloudPlatform/google-cloud-java.git","clone_url":"https://github.com/GoogleCloudPlatform/google-cloud-java.git","svn_url":"https://github.com/GoogleCloudPlatform/google-cloud-java","homepage":"http://googlecloudplatform.github.io/google-cloud-java/","size":82884,"stargazers_count":200,"watchers_count":200,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":112,"mirror_url":null,"open_issues_count":126,"forks":112,"open_issues":126,"watchers":200,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/pulls/1480"},"html":{"href":"https://github.com/GoogleCloudPlatform/google-cloud-java/pull/1480"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/issues/1480"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/issues/1480/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/pulls/1480/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/pulls/1480/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/statuses/087427c76236ed1ca6a5ed98bfa10f93696f4c27"}}}}
{"actor":{"display_login":"pongad"}}