{"action":"created","comment":{"url":"https://api.github.com/repos/chartjs/Chart.js/pulls/comments/83536135","pull_request_review_id":4375840,"id":83536135,"diff_hunk":"@@ -62,7 +63,9 @@ module.exports = function(Chart) {\n \t\t\t}\n \n \t\t\tvar center = element.getCenterPoint();\n-\t\t\tvar distance = Math.round(helpers.distanceBetweenPoints(position, center));\n+\t\t\tvar distance = distanceMetric ?\n+\t\t\t\t\t\t\tdistanceMetric(position, center) :\n+\t\t\t\t\t\t\tMath.round(helpers.distanceBetweenPoints(position, center));","path":"src/core/core.interaction.js","position":19,"original_position":19,"commit_id":"c187f955ffbabfe23a46aacf771f782cfb83b0bf","original_commit_id":"c187f955ffbabfe23a46aacf771f782cfb83b0bf","user":{"login":"simonbrunel","id":3874900,"avatar_url":"https://avatars.githubusercontent.com/u/3874900?v=3","gravatar_id":"","url":"https://api.github.com/users/simonbrunel","html_url":"https://github.com/simonbrunel","followers_url":"https://api.github.com/users/simonbrunel/followers","following_url":"https://api.github.com/users/simonbrunel/following{/other_user}","gists_url":"https://api.github.com/users/simonbrunel/gists{/gist_id}","starred_url":"https://api.github.com/users/simonbrunel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simonbrunel/subscriptions","organizations_url":"https://api.github.com/users/simonbrunel/orgs","repos_url":"https://api.github.com/users/simonbrunel/repos","events_url":"https://api.github.com/users/simonbrunel/events{/privacy}","received_events_url":"https://api.github.com/users/simonbrunel/received_events","type":"User","site_admin":false},"body":"Do we really need to round the value?","created_at":"2016-10-15T17:06:46Z","updated_at":"2016-10-15T17:06:46Z","html_url":"https://github.com/chartjs/Chart.js/pull/3471#discussion_r83536135","pull_request_url":"https://api.github.com/repos/chartjs/Chart.js/pulls/3471","_links":{"self":{"href":"https://api.github.com/repos/chartjs/Chart.js/pulls/comments/83536135"},"html":{"href":"https://github.com/chartjs/Chart.js/pull/3471#discussion_r83536135"},"pull_request":{"href":"https://api.github.com/repos/chartjs/Chart.js/pulls/3471"}}},"pull_request":{"url":"https://api.github.com/repos/chartjs/Chart.js/pulls/3471","id":89461133,"html_url":"https://github.com/chartjs/Chart.js/pull/3471","diff_url":"https://github.com/chartjs/Chart.js/pull/3471.diff","patch_url":"https://github.com/chartjs/Chart.js/pull/3471.patch","issue_url":"https://api.github.com/repos/chartjs/Chart.js/issues/3471","number":3471,"state":"open","locked":false,"title":"Make index mode only work with the horizontal distance to an element ","user":{"login":"etimberg","id":6757853,"avatar_url":"https://avatars.githubusercontent.com/u/6757853?v=3","gravatar_id":"","url":"https://api.github.com/users/etimberg","html_url":"https://github.com/etimberg","followers_url":"https://api.github.com/users/etimberg/followers","following_url":"https://api.github.com/users/etimberg/following{/other_user}","gists_url":"https://api.github.com/users/etimberg/gists{/gist_id}","starred_url":"https://api.github.com/users/etimberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etimberg/subscriptions","organizations_url":"https://api.github.com/users/etimberg/orgs","repos_url":"https://api.github.com/users/etimberg/repos","events_url":"https://api.github.com/users/etimberg/events{/privacy}","received_events_url":"https://api.github.com/users/etimberg/received_events","type":"User","site_admin":false},"body":"This only applies when `intersect: false` is in the tooltip options. @simonbrunel noticed this behaviour. I added a test to ensure that the horizontal distance is what applies. \r\n\r\nOne question ... what do we do for horizontal bar charts? In that case we want to use the y direction. @chartjs/maintainers thoughts on this?","created_at":"2016-10-14T21:55:05Z","updated_at":"2016-10-15T17:08:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a18bb85202b5ef32430993aa7d94c12f6db8feef","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/chartjs/Chart.js/pulls/3471/commits","review_comments_url":"https://api.github.com/repos/chartjs/Chart.js/pulls/3471/comments","review_comment_url":"https://api.github.com/repos/chartjs/Chart.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chartjs/Chart.js/issues/3471/comments","statuses_url":"https://api.github.com/repos/chartjs/Chart.js/statuses/c187f955ffbabfe23a46aacf771f782cfb83b0bf","head":{"label":"chartjs:fix/tooltip-index-mode","ref":"fix/tooltip-index-mode","sha":"c187f955ffbabfe23a46aacf771f782cfb83b0bf","user":{"login":"chartjs","id":10342521,"avatar_url":"https://avatars.githubusercontent.com/u/10342521?v=3","gravatar_id":"","url":"https://api.github.com/users/chartjs","html_url":"https://github.com/chartjs","followers_url":"https://api.github.com/users/chartjs/followers","following_url":"https://api.github.com/users/chartjs/following{/other_user}","gists_url":"https://api.github.com/users/chartjs/gists{/gist_id}","starred_url":"https://api.github.com/users/chartjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chartjs/subscriptions","organizations_url":"https://api.github.com/users/chartjs/orgs","repos_url":"https://api.github.com/users/chartjs/repos","events_url":"https://api.github.com/users/chartjs/events{/privacy}","received_events_url":"https://api.github.com/users/chartjs/received_events","type":"Organization","site_admin":false},"repo":{"id":8843683,"name":"Chart.js","full_name":"chartjs/Chart.js","owner":{"login":"chartjs","id":10342521,"avatar_url":"https://avatars.githubusercontent.com/u/10342521?v=3","gravatar_id":"","url":"https://api.github.com/users/chartjs","html_url":"https://github.com/chartjs","followers_url":"https://api.github.com/users/chartjs/followers","following_url":"https://api.github.com/users/chartjs/following{/other_user}","gists_url":"https://api.github.com/users/chartjs/gists{/gist_id}","starred_url":"https://api.github.com/users/chartjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chartjs/subscriptions","organizations_url":"https://api.github.com/users/chartjs/orgs","repos_url":"https://api.github.com/users/chartjs/repos","events_url":"https://api.github.com/users/chartjs/events{/privacy}","received_events_url":"https://api.github.com/users/chartjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chartjs/Chart.js","description":"Simple HTML5 Charts using the <canvas> tag","fork":false,"url":"https://api.github.com/repos/chartjs/Chart.js","forks_url":"https://api.github.com/repos/chartjs/Chart.js/forks","keys_url":"https://api.github.com/repos/chartjs/Chart.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chartjs/Chart.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chartjs/Chart.js/teams","hooks_url":"https://api.github.com/repos/chartjs/Chart.js/hooks","issue_events_url":"https://api.github.com/repos/chartjs/Chart.js/issues/events{/number}","events_url":"https://api.github.com/repos/chartjs/Chart.js/events","assignees_url":"https://api.github.com/repos/chartjs/Chart.js/assignees{/user}","branches_url":"https://api.github.com/repos/chartjs/Chart.js/branches{/branch}","tags_url":"https://api.github.com/repos/chartjs/Chart.js/tags","blobs_url":"https://api.github.com/repos/chartjs/Chart.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chartjs/Chart.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chartjs/Chart.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/chartjs/Chart.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chartjs/Chart.js/statuses/{sha}","languages_url":"https://api.github.com/repos/chartjs/Chart.js/languages","stargazers_url":"https://api.github.com/repos/chartjs/Chart.js/stargazers","contributors_url":"https://api.github.com/repos/chartjs/Chart.js/contributors","subscribers_url":"https://api.github.com/repos/chartjs/Chart.js/subscribers","subscription_url":"https://api.github.com/repos/chartjs/Chart.js/subscription","commits_url":"https://api.github.com/repos/chartjs/Chart.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/chartjs/Chart.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/chartjs/Chart.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/chartjs/Chart.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/chartjs/Chart.js/contents/{+path}","compare_url":"https://api.github.com/repos/chartjs/Chart.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chartjs/Chart.js/merges","archive_url":"https://api.github.com/repos/chartjs/Chart.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chartjs/Chart.js/downloads","issues_url":"https://api.github.com/repos/chartjs/Chart.js/issues{/number}","pulls_url":"https://api.github.com/repos/chartjs/Chart.js/pulls{/number}","milestones_url":"https://api.github.com/repos/chartjs/Chart.js/milestones{/number}","notifications_url":"https://api.github.com/repos/chartjs/Chart.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chartjs/Chart.js/labels{/name}","releases_url":"https://api.github.com/repos/chartjs/Chart.js/releases{/id}","deployments_url":"https://api.github.com/repos/chartjs/Chart.js/deployments","created_at":"2013-03-17T23:56:36Z","updated_at":"2016-10-15T15:06:41Z","pushed_at":"2016-10-15T12:40:27Z","git_url":"git://github.com/chartjs/Chart.js.git","ssh_url":"git@github.com:chartjs/Chart.js.git","clone_url":"https://github.com/chartjs/Chart.js.git","svn_url":"https://github.com/chartjs/Chart.js","homepage":"http://www.chartjs.org/","size":11836,"stargazers_count":25671,"watchers_count":25671,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6967,"mirror_url":null,"open_issues_count":245,"forks":6967,"open_issues":245,"watchers":25671,"default_branch":"master"}},"base":{"label":"chartjs:master","ref":"master","sha":"a86c47cf480e8d86ea03a121e9b6552a17aae41d","user":{"login":"chartjs","id":10342521,"avatar_url":"https://avatars.githubusercontent.com/u/10342521?v=3","gravatar_id":"","url":"https://api.github.com/users/chartjs","html_url":"https://github.com/chartjs","followers_url":"https://api.github.com/users/chartjs/followers","following_url":"https://api.github.com/users/chartjs/following{/other_user}","gists_url":"https://api.github.com/users/chartjs/gists{/gist_id}","starred_url":"https://api.github.com/users/chartjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chartjs/subscriptions","organizations_url":"https://api.github.com/users/chartjs/orgs","repos_url":"https://api.github.com/users/chartjs/repos","events_url":"https://api.github.com/users/chartjs/events{/privacy}","received_events_url":"https://api.github.com/users/chartjs/received_events","type":"Organization","site_admin":false},"repo":{"id":8843683,"name":"Chart.js","full_name":"chartjs/Chart.js","owner":{"login":"chartjs","id":10342521,"avatar_url":"https://avatars.githubusercontent.com/u/10342521?v=3","gravatar_id":"","url":"https://api.github.com/users/chartjs","html_url":"https://github.com/chartjs","followers_url":"https://api.github.com/users/chartjs/followers","following_url":"https://api.github.com/users/chartjs/following{/other_user}","gists_url":"https://api.github.com/users/chartjs/gists{/gist_id}","starred_url":"https://api.github.com/users/chartjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chartjs/subscriptions","organizations_url":"https://api.github.com/users/chartjs/orgs","repos_url":"https://api.github.com/users/chartjs/repos","events_url":"https://api.github.com/users/chartjs/events{/privacy}","received_events_url":"https://api.github.com/users/chartjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chartjs/Chart.js","description":"Simple HTML5 Charts using the <canvas> tag","fork":false,"url":"https://api.github.com/repos/chartjs/Chart.js","forks_url":"https://api.github.com/repos/chartjs/Chart.js/forks","keys_url":"https://api.github.com/repos/chartjs/Chart.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chartjs/Chart.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chartjs/Chart.js/teams","hooks_url":"https://api.github.com/repos/chartjs/Chart.js/hooks","issue_events_url":"https://api.github.com/repos/chartjs/Chart.js/issues/events{/number}","events_url":"https://api.github.com/repos/chartjs/Chart.js/events","assignees_url":"https://api.github.com/repos/chartjs/Chart.js/assignees{/user}","branches_url":"https://api.github.com/repos/chartjs/Chart.js/branches{/branch}","tags_url":"https://api.github.com/repos/chartjs/Chart.js/tags","blobs_url":"https://api.github.com/repos/chartjs/Chart.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chartjs/Chart.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chartjs/Chart.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/chartjs/Chart.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chartjs/Chart.js/statuses/{sha}","languages_url":"https://api.github.com/repos/chartjs/Chart.js/languages","stargazers_url":"https://api.github.com/repos/chartjs/Chart.js/stargazers","contributors_url":"https://api.github.com/repos/chartjs/Chart.js/contributors","subscribers_url":"https://api.github.com/repos/chartjs/Chart.js/subscribers","subscription_url":"https://api.github.com/repos/chartjs/Chart.js/subscription","commits_url":"https://api.github.com/repos/chartjs/Chart.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/chartjs/Chart.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/chartjs/Chart.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/chartjs/Chart.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/chartjs/Chart.js/contents/{+path}","compare_url":"https://api.github.com/repos/chartjs/Chart.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chartjs/Chart.js/merges","archive_url":"https://api.github.com/repos/chartjs/Chart.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chartjs/Chart.js/downloads","issues_url":"https://api.github.com/repos/chartjs/Chart.js/issues{/number}","pulls_url":"https://api.github.com/repos/chartjs/Chart.js/pulls{/number}","milestones_url":"https://api.github.com/repos/chartjs/Chart.js/milestones{/number}","notifications_url":"https://api.github.com/repos/chartjs/Chart.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chartjs/Chart.js/labels{/name}","releases_url":"https://api.github.com/repos/chartjs/Chart.js/releases{/id}","deployments_url":"https://api.github.com/repos/chartjs/Chart.js/deployments","created_at":"2013-03-17T23:56:36Z","updated_at":"2016-10-15T15:06:41Z","pushed_at":"2016-10-15T12:40:27Z","git_url":"git://github.com/chartjs/Chart.js.git","ssh_url":"git@github.com:chartjs/Chart.js.git","clone_url":"https://github.com/chartjs/Chart.js.git","svn_url":"https://github.com/chartjs/Chart.js","homepage":"http://www.chartjs.org/","size":11836,"stargazers_count":25671,"watchers_count":25671,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6967,"mirror_url":null,"open_issues_count":245,"forks":6967,"open_issues":245,"watchers":25671,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/chartjs/Chart.js/pulls/3471"},"html":{"href":"https://github.com/chartjs/Chart.js/pull/3471"},"issue":{"href":"https://api.github.com/repos/chartjs/Chart.js/issues/3471"},"comments":{"href":"https://api.github.com/repos/chartjs/Chart.js/issues/3471/comments"},"review_comments":{"href":"https://api.github.com/repos/chartjs/Chart.js/pulls/3471/comments"},"review_comment":{"href":"https://api.github.com/repos/chartjs/Chart.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chartjs/Chart.js/pulls/3471/commits"},"statuses":{"href":"https://api.github.com/repos/chartjs/Chart.js/statuses/c187f955ffbabfe23a46aacf771f782cfb83b0bf"}}}}
{"actor":{"display_login":"simonbrunel"}}