{"action":"created","comment":{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments/89795236","pull_request_review_id":10329033,"id":89795236,"diff_hunk":"@@ -0,0 +1,903 @@\n+/*\n+* Copyright (C) 2008-2016 TrinityCore <http://www.trinitycore.org/>","path":"src/server/scripts/Events/fireworks_show.cpp","position":2,"original_position":2,"commit_id":"0a9f96c26e85467d50a104b2ad70caeb68d21d70","original_commit_id":"0a9f96c26e85467d50a104b2ad70caeb68d21d70","user":{"login":"Kittnz","id":5845231,"avatar_url":"https://avatars.githubusercontent.com/u/5845231?v=3","gravatar_id":"","url":"https://api.github.com/users/Kittnz","html_url":"https://github.com/Kittnz","followers_url":"https://api.github.com/users/Kittnz/followers","following_url":"https://api.github.com/users/Kittnz/following{/other_user}","gists_url":"https://api.github.com/users/Kittnz/gists{/gist_id}","starred_url":"https://api.github.com/users/Kittnz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kittnz/subscriptions","organizations_url":"https://api.github.com/users/Kittnz/orgs","repos_url":"https://api.github.com/users/Kittnz/repos","events_url":"https://api.github.com/users/Kittnz/events{/privacy}","received_events_url":"https://api.github.com/users/Kittnz/received_events","type":"User","site_admin":false},"body":"I didn't even notice, alright.","created_at":"2016-11-28T14:53:37Z","updated_at":"2016-11-28T14:53:37Z","html_url":"https://github.com/TrinityCore/TrinityCore/pull/18319#discussion_r89795236","pull_request_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/18319","_links":{"self":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments/89795236"},"html":{"href":"https://github.com/TrinityCore/TrinityCore/pull/18319#discussion_r89795236"},"pull_request":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/18319"}}},"pull_request":{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/18319","id":95371647,"html_url":"https://github.com/TrinityCore/TrinityCore/pull/18319","diff_url":"https://github.com/TrinityCore/TrinityCore/pull/18319.diff","patch_url":"https://github.com/TrinityCore/TrinityCore/pull/18319.patch","issue_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/18319","number":18319,"state":"open","locked":false,"title":"Core/Event: Add Fireworks Spectacular (4th of July) & New Year's Eve event!","user":{"login":"Kittnz","id":5845231,"avatar_url":"https://avatars.githubusercontent.com/u/5845231?v=3","gravatar_id":"","url":"https://api.github.com/users/Kittnz","html_url":"https://github.com/Kittnz","followers_url":"https://api.github.com/users/Kittnz/followers","following_url":"https://api.github.com/users/Kittnz/following{/other_user}","gists_url":"https://api.github.com/users/Kittnz/gists{/gist_id}","starred_url":"https://api.github.com/users/Kittnz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kittnz/subscriptions","organizations_url":"https://api.github.com/users/Kittnz/orgs","repos_url":"https://api.github.com/users/Kittnz/repos","events_url":"https://api.github.com/users/Kittnz/events{/privacy}","received_events_url":"https://api.github.com/users/Kittnz/received_events","type":"User","site_admin":false},"body":"**Changes proposed:**\r\n\r\n-  Add Fireworks Spectacular (4th of July) & New Year's Eve event!\r\n\r\n**Target branch(es):** 3.3.5/master\r\nBoth branches\r\n\r\nNotes:\r\nI have no other way then to use a gameobject script.\r\nI'v looked into mapscript or worldmapscript but i don't see another way to make this happen. \r\nAnd a grid problem, when a grid is not active and one of the cheer speaker objects is not active it will stop firing the fireworks. Also cheer speaker gob is used in brewfests Dark Iron invasion event. If we script that event we need to change the script.\r\n\r\n**Tests performed:** (Does it build, tested in-game, etc.)\r\nBuild on windows and tested on windows.\r\n\r\nThanks to @Treeston for all the advice!","created_at":"2016-11-26T13:30:18Z","updated_at":"2016-11-28T14:53:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"487294b37dbcf2d3e7a8e5f76a3b1bd874df8ee3","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/18319/commits","review_comments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/18319/comments","review_comment_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/18319/comments","statuses_url":"https://api.github.com/repos/TrinityCore/TrinityCore/statuses/0a9f96c26e85467d50a104b2ad70caeb68d21d70","head":{"label":"Kittnz:fireworks","ref":"fireworks","sha":"0a9f96c26e85467d50a104b2ad70caeb68d21d70","user":{"login":"Kittnz","id":5845231,"avatar_url":"https://avatars.githubusercontent.com/u/5845231?v=3","gravatar_id":"","url":"https://api.github.com/users/Kittnz","html_url":"https://github.com/Kittnz","followers_url":"https://api.github.com/users/Kittnz/followers","following_url":"https://api.github.com/users/Kittnz/following{/other_user}","gists_url":"https://api.github.com/users/Kittnz/gists{/gist_id}","starred_url":"https://api.github.com/users/Kittnz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kittnz/subscriptions","organizations_url":"https://api.github.com/users/Kittnz/orgs","repos_url":"https://api.github.com/users/Kittnz/repos","events_url":"https://api.github.com/users/Kittnz/events{/privacy}","received_events_url":"https://api.github.com/users/Kittnz/received_events","type":"User","site_admin":false},"repo":{"id":45490188,"name":"TrinityCore","full_name":"Kittnz/TrinityCore","owner":{"login":"Kittnz","id":5845231,"avatar_url":"https://avatars.githubusercontent.com/u/5845231?v=3","gravatar_id":"","url":"https://api.github.com/users/Kittnz","html_url":"https://github.com/Kittnz","followers_url":"https://api.github.com/users/Kittnz/followers","following_url":"https://api.github.com/users/Kittnz/following{/other_user}","gists_url":"https://api.github.com/users/Kittnz/gists{/gist_id}","starred_url":"https://api.github.com/users/Kittnz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kittnz/subscriptions","organizations_url":"https://api.github.com/users/Kittnz/orgs","repos_url":"https://api.github.com/users/Kittnz/repos","events_url":"https://api.github.com/users/Kittnz/events{/privacy}","received_events_url":"https://api.github.com/users/Kittnz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Kittnz/TrinityCore","description":"TrinityCore Open Source MMO Framework","fork":true,"url":"https://api.github.com/repos/Kittnz/TrinityCore","forks_url":"https://api.github.com/repos/Kittnz/TrinityCore/forks","keys_url":"https://api.github.com/repos/Kittnz/TrinityCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Kittnz/TrinityCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Kittnz/TrinityCore/teams","hooks_url":"https://api.github.com/repos/Kittnz/TrinityCore/hooks","issue_events_url":"https://api.github.com/repos/Kittnz/TrinityCore/issues/events{/number}","events_url":"https://api.github.com/repos/Kittnz/TrinityCore/events","assignees_url":"https://api.github.com/repos/Kittnz/TrinityCore/assignees{/user}","branches_url":"https://api.github.com/repos/Kittnz/TrinityCore/branches{/branch}","tags_url":"https://api.github.com/repos/Kittnz/TrinityCore/tags","blobs_url":"https://api.github.com/repos/Kittnz/TrinityCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Kittnz/TrinityCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Kittnz/TrinityCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/Kittnz/TrinityCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Kittnz/TrinityCore/statuses/{sha}","languages_url":"https://api.github.com/repos/Kittnz/TrinityCore/languages","stargazers_url":"https://api.github.com/repos/Kittnz/TrinityCore/stargazers","contributors_url":"https://api.github.com/repos/Kittnz/TrinityCore/contributors","subscribers_url":"https://api.github.com/repos/Kittnz/TrinityCore/subscribers","subscription_url":"https://api.github.com/repos/Kittnz/TrinityCore/subscription","commits_url":"https://api.github.com/repos/Kittnz/TrinityCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/Kittnz/TrinityCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/Kittnz/TrinityCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/Kittnz/TrinityCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/Kittnz/TrinityCore/contents/{+path}","compare_url":"https://api.github.com/repos/Kittnz/TrinityCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Kittnz/TrinityCore/merges","archive_url":"https://api.github.com/repos/Kittnz/TrinityCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Kittnz/TrinityCore/downloads","issues_url":"https://api.github.com/repos/Kittnz/TrinityCore/issues{/number}","pulls_url":"https://api.github.com/repos/Kittnz/TrinityCore/pulls{/number}","milestones_url":"https://api.github.com/repos/Kittnz/TrinityCore/milestones{/number}","notifications_url":"https://api.github.com/repos/Kittnz/TrinityCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Kittnz/TrinityCore/labels{/name}","releases_url":"https://api.github.com/repos/Kittnz/TrinityCore/releases{/id}","deployments_url":"https://api.github.com/repos/Kittnz/TrinityCore/deployments","created_at":"2015-11-03T19:26:39Z","updated_at":"2015-11-03T19:27:37Z","pushed_at":"2016-11-27T05:49:37Z","git_url":"git://github.com/Kittnz/TrinityCore.git","ssh_url":"git@github.com:Kittnz/TrinityCore.git","clone_url":"https://github.com/Kittnz/TrinityCore.git","svn_url":"https://github.com/Kittnz/TrinityCore","homepage":"http://www.trinitycore.org","size":353388,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"6.x"}},"base":{"label":"TrinityCore:3.3.5","ref":"3.3.5","sha":"791899a6c751cd776ff6ace23d7d092ad1fcdf61","user":{"login":"TrinityCore","id":539602,"avatar_url":"https://avatars.githubusercontent.com/u/539602?v=3","gravatar_id":"","url":"https://api.github.com/users/TrinityCore","html_url":"https://github.com/TrinityCore","followers_url":"https://api.github.com/users/TrinityCore/followers","following_url":"https://api.github.com/users/TrinityCore/following{/other_user}","gists_url":"https://api.github.com/users/TrinityCore/gists{/gist_id}","starred_url":"https://api.github.com/users/TrinityCore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TrinityCore/subscriptions","organizations_url":"https://api.github.com/users/TrinityCore/orgs","repos_url":"https://api.github.com/users/TrinityCore/repos","events_url":"https://api.github.com/users/TrinityCore/events{/privacy}","received_events_url":"https://api.github.com/users/TrinityCore/received_events","type":"Organization","site_admin":false},"repo":{"id":1204412,"name":"TrinityCore","full_name":"TrinityCore/TrinityCore","owner":{"login":"TrinityCore","id":539602,"avatar_url":"https://avatars.githubusercontent.com/u/539602?v=3","gravatar_id":"","url":"https://api.github.com/users/TrinityCore","html_url":"https://github.com/TrinityCore","followers_url":"https://api.github.com/users/TrinityCore/followers","following_url":"https://api.github.com/users/TrinityCore/following{/other_user}","gists_url":"https://api.github.com/users/TrinityCore/gists{/gist_id}","starred_url":"https://api.github.com/users/TrinityCore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TrinityCore/subscriptions","organizations_url":"https://api.github.com/users/TrinityCore/orgs","repos_url":"https://api.github.com/users/TrinityCore/repos","events_url":"https://api.github.com/users/TrinityCore/events{/privacy}","received_events_url":"https://api.github.com/users/TrinityCore/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TrinityCore/TrinityCore","description":"TrinityCore Open Source MMO Framework","fork":false,"url":"https://api.github.com/repos/TrinityCore/TrinityCore","forks_url":"https://api.github.com/repos/TrinityCore/TrinityCore/forks","keys_url":"https://api.github.com/repos/TrinityCore/TrinityCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TrinityCore/TrinityCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TrinityCore/TrinityCore/teams","hooks_url":"https://api.github.com/repos/TrinityCore/TrinityCore/hooks","issue_events_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/events{/number}","events_url":"https://api.github.com/repos/TrinityCore/TrinityCore/events","assignees_url":"https://api.github.com/repos/TrinityCore/TrinityCore/assignees{/user}","branches_url":"https://api.github.com/repos/TrinityCore/TrinityCore/branches{/branch}","tags_url":"https://api.github.com/repos/TrinityCore/TrinityCore/tags","blobs_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TrinityCore/TrinityCore/statuses/{sha}","languages_url":"https://api.github.com/repos/TrinityCore/TrinityCore/languages","stargazers_url":"https://api.github.com/repos/TrinityCore/TrinityCore/stargazers","contributors_url":"https://api.github.com/repos/TrinityCore/TrinityCore/contributors","subscribers_url":"https://api.github.com/repos/TrinityCore/TrinityCore/subscribers","subscription_url":"https://api.github.com/repos/TrinityCore/TrinityCore/subscription","commits_url":"https://api.github.com/repos/TrinityCore/TrinityCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/TrinityCore/TrinityCore/contents/{+path}","compare_url":"https://api.github.com/repos/TrinityCore/TrinityCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TrinityCore/TrinityCore/merges","archive_url":"https://api.github.com/repos/TrinityCore/TrinityCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TrinityCore/TrinityCore/downloads","issues_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues{/number}","pulls_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls{/number}","milestones_url":"https://api.github.com/repos/TrinityCore/TrinityCore/milestones{/number}","notifications_url":"https://api.github.com/repos/TrinityCore/TrinityCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TrinityCore/TrinityCore/labels{/name}","releases_url":"https://api.github.com/repos/TrinityCore/TrinityCore/releases{/id}","deployments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/deployments","created_at":"2010-12-28T23:40:07Z","updated_at":"2016-11-28T00:12:04Z","pushed_at":"2016-11-28T14:33:43Z","git_url":"git://github.com/TrinityCore/TrinityCore.git","ssh_url":"git@github.com:TrinityCore/TrinityCore.git","clone_url":"https://github.com/TrinityCore/TrinityCore.git","svn_url":"https://github.com/TrinityCore/TrinityCore","homepage":"http://www.trinitycore.org","size":827741,"stargazers_count":3539,"watchers_count":3539,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3602,"mirror_url":null,"open_issues_count":1232,"forks":3602,"open_issues":1232,"watchers":3539,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/18319"},"html":{"href":"https://github.com/TrinityCore/TrinityCore/pull/18319"},"issue":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/18319"},"comments":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/18319/comments"},"review_comments":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/18319/comments"},"review_comment":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/18319/commits"},"statuses":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/statuses/0a9f96c26e85467d50a104b2ad70caeb68d21d70"}}}}
{"actor":{"display_login":"Kittnz"}}