{"action":"created","comment":{"url":"https://api.github.com/repos/linnovate/mean/pulls/comments/92210998","pull_request_review_id":12722370,"id":92210998,"diff_hunk":"@@ -94,53 +124,71 @@ angular.module('mean.users').factory('MeanUser', [ '$rootScope', '$http', '$loca\n \n     MeanUserKlass.prototype.login = function (user) {\n       // this is an ugly hack due to mean-admin needs\n+      var self = this;\n       var destination = $location.path().indexOf('/login') === -1 ? $location.absUrl() : false;\n       $http.post('/api/login', {\n           email: user.email,\n           password: user.password,\n-          redirect: destination\n+          redirect: $cookies.get('redirect') || destination\n+        })\n+        .then(function (response){\n+          self.onIdentity.bind(self)\n         })\n-        .success(this.onIdentity.bind(this))\n-        .error(this.onIdFail.bind(this));\n+        .catch(function (response){\n+          self.onIdFail.bind(self)\n+        });\n     };\n \n     MeanUserKlass.prototype.register = function(user) {\n+      var self = this;\n       $http.post('/api/register', {\n         email: user.email,\n         password: user.password,\n         confirmPassword: user.confirmPassword,\n         username: user.username,\n         name: user.name\n       })\n-        .success(this.onIdentity.bind(this))\n-        .error(this.onIdFail.bind(this));\n+        .then(function (response){\n+          self.onIdentity.bind(self)\n+        })\n+        .catch(function (response){\n+          self.onIdFail.bind(self)\n+        });\n     };\n \n     MeanUserKlass.prototype.resetpassword = function(user) {\n-        $http.post('/api/reset/' + $stateParams.tokenId, {\n-          password: user.password,\n-          confirmPassword: user.confirmPassword\n+      var self = this;\n+      $http.post('/api/reset/' + $stateParams.tokenId, {\n+        password: user.password,\n+        confirmPassword: user.confirmPassword\n+      })\n+        .then(function (response){\n+          self.onIdentity.bind(self)\n         })\n-          .success(this.onIdentity.bind(this))\n-          .error(this.onIdFail.bind(this));\n+        .catch(function (response){\n+          self.onIdFail.bind(self)","path":"packages/core/users/public/services/meanUser.js","position":167,"original_position":167,"commit_id":"55a99daadddbd91133f0bb112c64562eb080abe2","original_commit_id":"55a99daadddbd91133f0bb112c64562eb080abe2","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Missing semicolon.","created_at":"2016-12-13T16:44:24Z","updated_at":"2016-12-13T16:44:24Z","html_url":"https://github.com/linnovate/mean/pull/1720#discussion_r92210998","pull_request_url":"https://api.github.com/repos/linnovate/mean/pulls/1720","_links":{"self":{"href":"https://api.github.com/repos/linnovate/mean/pulls/comments/92210998"},"html":{"href":"https://github.com/linnovate/mean/pull/1720#discussion_r92210998"},"pull_request":{"href":"https://api.github.com/repos/linnovate/mean/pulls/1720"}}},"pull_request":{"url":"https://api.github.com/repos/linnovate/mean/pulls/1720","id":97788914,"html_url":"https://github.com/linnovate/mean/pull/1720","diff_url":"https://github.com/linnovate/mean/pull/1720.diff","patch_url":"https://github.com/linnovate/mean/pull/1720.patch","issue_url":"https://api.github.com/repos/linnovate/mean/issues/1720","number":1720,"state":"open","locked":false,"title":"Fix angular 1.6.0 breaks","user":{"login":"quentinhayot","id":1408948,"avatar_url":"https://avatars.githubusercontent.com/u/1408948?v=3","gravatar_id":"","url":"https://api.github.com/users/quentinhayot","html_url":"https://github.com/quentinhayot","followers_url":"https://api.github.com/users/quentinhayot/followers","following_url":"https://api.github.com/users/quentinhayot/following{/other_user}","gists_url":"https://api.github.com/users/quentinhayot/gists{/gist_id}","starred_url":"https://api.github.com/users/quentinhayot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quentinhayot/subscriptions","organizations_url":"https://api.github.com/users/quentinhayot/orgs","repos_url":"https://api.github.com/users/quentinhayot/repos","events_url":"https://api.github.com/users/quentinhayot/events{/privacy}","received_events_url":"https://api.github.com/users/quentinhayot/received_events","type":"User","site_admin":false},"body":"`$http(...).success` and `$http(...).error` have been removed.\r\n`$http(...).then`and `$http(...).catch`used instead as suggested at :\r\nhttps://docs.angularjs.org/guide/migration#migrate1.5to1.6-ng-services-$http","created_at":"2016-12-13T16:44:12Z","updated_at":"2016-12-13T16:44:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fecd6be7cca91df98bfd169429998c76ba1dfb2e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/linnovate/mean/pulls/1720/commits","review_comments_url":"https://api.github.com/repos/linnovate/mean/pulls/1720/comments","review_comment_url":"https://api.github.com/repos/linnovate/mean/pulls/comments{/number}","comments_url":"https://api.github.com/repos/linnovate/mean/issues/1720/comments","statuses_url":"https://api.github.com/repos/linnovate/mean/statuses/55a99daadddbd91133f0bb112c64562eb080abe2","head":{"label":"quentinhayot:0.5.5","ref":"0.5.5","sha":"55a99daadddbd91133f0bb112c64562eb080abe2","user":{"login":"quentinhayot","id":1408948,"avatar_url":"https://avatars.githubusercontent.com/u/1408948?v=3","gravatar_id":"","url":"https://api.github.com/users/quentinhayot","html_url":"https://github.com/quentinhayot","followers_url":"https://api.github.com/users/quentinhayot/followers","following_url":"https://api.github.com/users/quentinhayot/following{/other_user}","gists_url":"https://api.github.com/users/quentinhayot/gists{/gist_id}","starred_url":"https://api.github.com/users/quentinhayot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quentinhayot/subscriptions","organizations_url":"https://api.github.com/users/quentinhayot/orgs","repos_url":"https://api.github.com/users/quentinhayot/repos","events_url":"https://api.github.com/users/quentinhayot/events{/privacy}","received_events_url":"https://api.github.com/users/quentinhayot/received_events","type":"User","site_admin":false},"repo":{"id":76377995,"name":"mean","full_name":"quentinhayot/mean","owner":{"login":"quentinhayot","id":1408948,"avatar_url":"https://avatars.githubusercontent.com/u/1408948?v=3","gravatar_id":"","url":"https://api.github.com/users/quentinhayot","html_url":"https://github.com/quentinhayot","followers_url":"https://api.github.com/users/quentinhayot/followers","following_url":"https://api.github.com/users/quentinhayot/following{/other_user}","gists_url":"https://api.github.com/users/quentinhayot/gists{/gist_id}","starred_url":"https://api.github.com/users/quentinhayot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quentinhayot/subscriptions","organizations_url":"https://api.github.com/users/quentinhayot/orgs","repos_url":"https://api.github.com/users/quentinhayot/repos","events_url":"https://api.github.com/users/quentinhayot/events{/privacy}","received_events_url":"https://api.github.com/users/quentinhayot/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/quentinhayot/mean","description":"MEAN (Mongo, Express, Angular, Node) - A Simple, Scalable and Easy starting point for full stack javascript web development - utilizing many of the best practices we've found on the way","fork":true,"url":"https://api.github.com/repos/quentinhayot/mean","forks_url":"https://api.github.com/repos/quentinhayot/mean/forks","keys_url":"https://api.github.com/repos/quentinhayot/mean/keys{/key_id}","collaborators_url":"https://api.github.com/repos/quentinhayot/mean/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/quentinhayot/mean/teams","hooks_url":"https://api.github.com/repos/quentinhayot/mean/hooks","issue_events_url":"https://api.github.com/repos/quentinhayot/mean/issues/events{/number}","events_url":"https://api.github.com/repos/quentinhayot/mean/events","assignees_url":"https://api.github.com/repos/quentinhayot/mean/assignees{/user}","branches_url":"https://api.github.com/repos/quentinhayot/mean/branches{/branch}","tags_url":"https://api.github.com/repos/quentinhayot/mean/tags","blobs_url":"https://api.github.com/repos/quentinhayot/mean/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/quentinhayot/mean/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/quentinhayot/mean/git/refs{/sha}","trees_url":"https://api.github.com/repos/quentinhayot/mean/git/trees{/sha}","statuses_url":"https://api.github.com/repos/quentinhayot/mean/statuses/{sha}","languages_url":"https://api.github.com/repos/quentinhayot/mean/languages","stargazers_url":"https://api.github.com/repos/quentinhayot/mean/stargazers","contributors_url":"https://api.github.com/repos/quentinhayot/mean/contributors","subscribers_url":"https://api.github.com/repos/quentinhayot/mean/subscribers","subscription_url":"https://api.github.com/repos/quentinhayot/mean/subscription","commits_url":"https://api.github.com/repos/quentinhayot/mean/commits{/sha}","git_commits_url":"https://api.github.com/repos/quentinhayot/mean/git/commits{/sha}","comments_url":"https://api.github.com/repos/quentinhayot/mean/comments{/number}","issue_comment_url":"https://api.github.com/repos/quentinhayot/mean/issues/comments{/number}","contents_url":"https://api.github.com/repos/quentinhayot/mean/contents/{+path}","compare_url":"https://api.github.com/repos/quentinhayot/mean/compare/{base}...{head}","merges_url":"https://api.github.com/repos/quentinhayot/mean/merges","archive_url":"https://api.github.com/repos/quentinhayot/mean/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/quentinhayot/mean/downloads","issues_url":"https://api.github.com/repos/quentinhayot/mean/issues{/number}","pulls_url":"https://api.github.com/repos/quentinhayot/mean/pulls{/number}","milestones_url":"https://api.github.com/repos/quentinhayot/mean/milestones{/number}","notifications_url":"https://api.github.com/repos/quentinhayot/mean/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/quentinhayot/mean/labels{/name}","releases_url":"https://api.github.com/repos/quentinhayot/mean/releases{/id}","deployments_url":"https://api.github.com/repos/quentinhayot/mean/deployments","created_at":"2016-12-13T16:34:40Z","updated_at":"2016-12-13T16:34:42Z","pushed_at":"2016-12-13T16:42:02Z","git_url":"git://github.com/quentinhayot/mean.git","ssh_url":"git@github.com:quentinhayot/mean.git","clone_url":"https://github.com/quentinhayot/mean.git","svn_url":"https://github.com/quentinhayot/mean","homepage":"http://mean.io","size":12384,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"linnovate:0.5.5","ref":"0.5.5","sha":"a303f897f5a39395b716ea9137d5745853b1f7ad","user":{"login":"linnovate","id":307487,"avatar_url":"https://avatars.githubusercontent.com/u/307487?v=3","gravatar_id":"","url":"https://api.github.com/users/linnovate","html_url":"https://github.com/linnovate","followers_url":"https://api.github.com/users/linnovate/followers","following_url":"https://api.github.com/users/linnovate/following{/other_user}","gists_url":"https://api.github.com/users/linnovate/gists{/gist_id}","starred_url":"https://api.github.com/users/linnovate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linnovate/subscriptions","organizations_url":"https://api.github.com/users/linnovate/orgs","repos_url":"https://api.github.com/users/linnovate/repos","events_url":"https://api.github.com/users/linnovate/events{/privacy}","received_events_url":"https://api.github.com/users/linnovate/received_events","type":"Organization","site_admin":false},"repo":{"id":10219106,"name":"mean","full_name":"linnovate/mean","owner":{"login":"linnovate","id":307487,"avatar_url":"https://avatars.githubusercontent.com/u/307487?v=3","gravatar_id":"","url":"https://api.github.com/users/linnovate","html_url":"https://github.com/linnovate","followers_url":"https://api.github.com/users/linnovate/followers","following_url":"https://api.github.com/users/linnovate/following{/other_user}","gists_url":"https://api.github.com/users/linnovate/gists{/gist_id}","starred_url":"https://api.github.com/users/linnovate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linnovate/subscriptions","organizations_url":"https://api.github.com/users/linnovate/orgs","repos_url":"https://api.github.com/users/linnovate/repos","events_url":"https://api.github.com/users/linnovate/events{/privacy}","received_events_url":"https://api.github.com/users/linnovate/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/linnovate/mean","description":"MEAN (Mongo, Express, Angular, Node) - A Simple, Scalable and Easy starting point for full stack javascript web development - utilizing many of the best practices we've found on the way","fork":false,"url":"https://api.github.com/repos/linnovate/mean","forks_url":"https://api.github.com/repos/linnovate/mean/forks","keys_url":"https://api.github.com/repos/linnovate/mean/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linnovate/mean/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linnovate/mean/teams","hooks_url":"https://api.github.com/repos/linnovate/mean/hooks","issue_events_url":"https://api.github.com/repos/linnovate/mean/issues/events{/number}","events_url":"https://api.github.com/repos/linnovate/mean/events","assignees_url":"https://api.github.com/repos/linnovate/mean/assignees{/user}","branches_url":"https://api.github.com/repos/linnovate/mean/branches{/branch}","tags_url":"https://api.github.com/repos/linnovate/mean/tags","blobs_url":"https://api.github.com/repos/linnovate/mean/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linnovate/mean/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linnovate/mean/git/refs{/sha}","trees_url":"https://api.github.com/repos/linnovate/mean/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linnovate/mean/statuses/{sha}","languages_url":"https://api.github.com/repos/linnovate/mean/languages","stargazers_url":"https://api.github.com/repos/linnovate/mean/stargazers","contributors_url":"https://api.github.com/repos/linnovate/mean/contributors","subscribers_url":"https://api.github.com/repos/linnovate/mean/subscribers","subscription_url":"https://api.github.com/repos/linnovate/mean/subscription","commits_url":"https://api.github.com/repos/linnovate/mean/commits{/sha}","git_commits_url":"https://api.github.com/repos/linnovate/mean/git/commits{/sha}","comments_url":"https://api.github.com/repos/linnovate/mean/comments{/number}","issue_comment_url":"https://api.github.com/repos/linnovate/mean/issues/comments{/number}","contents_url":"https://api.github.com/repos/linnovate/mean/contents/{+path}","compare_url":"https://api.github.com/repos/linnovate/mean/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linnovate/mean/merges","archive_url":"https://api.github.com/repos/linnovate/mean/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linnovate/mean/downloads","issues_url":"https://api.github.com/repos/linnovate/mean/issues{/number}","pulls_url":"https://api.github.com/repos/linnovate/mean/pulls{/number}","milestones_url":"https://api.github.com/repos/linnovate/mean/milestones{/number}","notifications_url":"https://api.github.com/repos/linnovate/mean/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linnovate/mean/labels{/name}","releases_url":"https://api.github.com/repos/linnovate/mean/releases{/id}","deployments_url":"https://api.github.com/repos/linnovate/mean/deployments","created_at":"2013-05-22T12:15:47Z","updated_at":"2016-12-13T15:26:20Z","pushed_at":"2016-12-13T16:44:12Z","git_url":"git://github.com/linnovate/mean.git","ssh_url":"git@github.com:linnovate/mean.git","clone_url":"https://github.com/linnovate/mean.git","svn_url":"https://github.com/linnovate/mean","homepage":"http://mean.io","size":12384,"stargazers_count":9677,"watchers_count":9677,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2909,"mirror_url":null,"open_issues_count":184,"forks":2909,"open_issues":184,"watchers":9677,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/linnovate/mean/pulls/1720"},"html":{"href":"https://github.com/linnovate/mean/pull/1720"},"issue":{"href":"https://api.github.com/repos/linnovate/mean/issues/1720"},"comments":{"href":"https://api.github.com/repos/linnovate/mean/issues/1720/comments"},"review_comments":{"href":"https://api.github.com/repos/linnovate/mean/pulls/1720/comments"},"review_comment":{"href":"https://api.github.com/repos/linnovate/mean/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/linnovate/mean/pulls/1720/commits"},"statuses":{"href":"https://api.github.com/repos/linnovate/mean/statuses/55a99daadddbd91133f0bb112c64562eb080abe2"}}}}
{"actor":{"display_login":"houndci-bot"}}