{"action":"created","comment":{"url":"https://api.github.com/repos/frappe/frappe/pulls/comments/91907733","pull_request_review_id":12415063,"id":91907733,"diff_hunk":"@@ -170,43 +156,20 @@ def get_emails_sent_this_month():\n \treturn frappe.db.sql(\"\"\"select count(name) from `tabEmail Queue` where\n \t\tstatus='Sent' and MONTH(creation)=MONTH(CURDATE())\"\"\")[0][0]\n \n-def get_unsubscribe_link(reference_doctype, reference_name,\n-\temail, recipients, expose_recipients, show_as_cc,\n-\tunsubscribe_method, unsubscribe_params, unsubscribe_message):\n-\n-\temail_sent_to = recipients if expose_recipients else [email]\n-\temail_sent_cc = \", \".join([e for e in email_sent_to if e in show_as_cc])\n-\temail_sent_to = \", \".join([e for e in email_sent_to if e not in show_as_cc])\n-\n-\tif email_sent_cc:\n-\t\temail_sent_message = _(\"This email was sent to {0} and copied to {1}\").format(email_sent_to, email_sent_cc)\n-\telse:","path":"frappe/email/queue.py","position":124,"original_position":124,"commit_id":"b717df02d758290e349ab398cded53ae6c0bedc2","original_commit_id":"b717df02d758290e349ab398cded53ae6c0bedc2","user":{"login":"rmehta","id":140076,"avatar_url":"https://avatars.githubusercontent.com/u/140076?v=3","gravatar_id":"","url":"https://api.github.com/users/rmehta","html_url":"https://github.com/rmehta","followers_url":"https://api.github.com/users/rmehta/followers","following_url":"https://api.github.com/users/rmehta/following{/other_user}","gists_url":"https://api.github.com/users/rmehta/gists{/gist_id}","starred_url":"https://api.github.com/users/rmehta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmehta/subscriptions","organizations_url":"https://api.github.com/users/rmehta/orgs","repos_url":"https://api.github.com/users/rmehta/repos","events_url":"https://api.github.com/users/rmehta/events{/privacy}","received_events_url":"https://api.github.com/users/rmehta/received_events","type":"User","site_admin":false},"body":"can we also have these messages when the mail gets build again? Should not be too hard (?) Always good to know who else was marked on the mail.","created_at":"2016-12-12T09:16:31Z","updated_at":"2016-12-12T09:20:59Z","html_url":"https://github.com/frappe/frappe/pull/2441#discussion_r91907733","pull_request_url":"https://api.github.com/repos/frappe/frappe/pulls/2441","_links":{"self":{"href":"https://api.github.com/repos/frappe/frappe/pulls/comments/91907733"},"html":{"href":"https://github.com/frappe/frappe/pull/2441#discussion_r91907733"},"pull_request":{"href":"https://api.github.com/repos/frappe/frappe/pulls/2441"}}},"pull_request":{"url":"https://api.github.com/repos/frappe/frappe/pulls/2441","id":97484027,"html_url":"https://github.com/frappe/frappe/pull/2441","diff_url":"https://github.com/frappe/frappe/pull/2441.diff","patch_url":"https://github.com/frappe/frappe/pull/2441.patch","issue_url":"https://api.github.com/repos/frappe/frappe/issues/2441","number":2441,"state":"open","locked":false,"title":"Email cc in headers if expose recipients","user":{"login":"RobertSchouten","id":15826176,"avatar_url":"https://avatars.githubusercontent.com/u/15826176?v=3","gravatar_id":"","url":"https://api.github.com/users/RobertSchouten","html_url":"https://github.com/RobertSchouten","followers_url":"https://api.github.com/users/RobertSchouten/followers","following_url":"https://api.github.com/users/RobertSchouten/following{/other_user}","gists_url":"https://api.github.com/users/RobertSchouten/gists{/gist_id}","starred_url":"https://api.github.com/users/RobertSchouten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RobertSchouten/subscriptions","organizations_url":"https://api.github.com/users/RobertSchouten/orgs","repos_url":"https://api.github.com/users/RobertSchouten/repos","events_url":"https://api.github.com/users/RobertSchouten/events{/privacy}","received_events_url":"https://api.github.com/users/RobertSchouten/received_events","type":"User","site_admin":false},"body":"create one email per email with recipients child table instead of one email per recipient to minimise email queue\r\n\r\nif expose recipeint is false\r\nto field is left with hook and at sending the recipient and unsubscribe link is added","created_at":"2016-12-12T01:44:51Z","updated_at":"2016-12-12T09:20:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"09efd3a45f42df18ffa522278489a5db46e1cbf9","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/frappe/frappe/pulls/2441/commits","review_comments_url":"https://api.github.com/repos/frappe/frappe/pulls/2441/comments","review_comment_url":"https://api.github.com/repos/frappe/frappe/pulls/comments{/number}","comments_url":"https://api.github.com/repos/frappe/frappe/issues/2441/comments","statuses_url":"https://api.github.com/repos/frappe/frappe/statuses/b717df02d758290e349ab398cded53ae6c0bedc2","head":{"label":"RobertSchouten:email_cc_dev2","ref":"email_cc_dev2","sha":"b717df02d758290e349ab398cded53ae6c0bedc2","user":{"login":"RobertSchouten","id":15826176,"avatar_url":"https://avatars.githubusercontent.com/u/15826176?v=3","gravatar_id":"","url":"https://api.github.com/users/RobertSchouten","html_url":"https://github.com/RobertSchouten","followers_url":"https://api.github.com/users/RobertSchouten/followers","following_url":"https://api.github.com/users/RobertSchouten/following{/other_user}","gists_url":"https://api.github.com/users/RobertSchouten/gists{/gist_id}","starred_url":"https://api.github.com/users/RobertSchouten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RobertSchouten/subscriptions","organizations_url":"https://api.github.com/users/RobertSchouten/orgs","repos_url":"https://api.github.com/users/RobertSchouten/repos","events_url":"https://api.github.com/users/RobertSchouten/events{/privacy}","received_events_url":"https://api.github.com/users/RobertSchouten/received_events","type":"User","site_admin":false},"repo":{"id":50985962,"name":"frappe","full_name":"RobertSchouten/frappe","owner":{"login":"RobertSchouten","id":15826176,"avatar_url":"https://avatars.githubusercontent.com/u/15826176?v=3","gravatar_id":"","url":"https://api.github.com/users/RobertSchouten","html_url":"https://github.com/RobertSchouten","followers_url":"https://api.github.com/users/RobertSchouten/followers","following_url":"https://api.github.com/users/RobertSchouten/following{/other_user}","gists_url":"https://api.github.com/users/RobertSchouten/gists{/gist_id}","starred_url":"https://api.github.com/users/RobertSchouten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RobertSchouten/subscriptions","organizations_url":"https://api.github.com/users/RobertSchouten/orgs","repos_url":"https://api.github.com/users/RobertSchouten/repos","events_url":"https://api.github.com/users/RobertSchouten/events{/privacy}","received_events_url":"https://api.github.com/users/RobertSchouten/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/RobertSchouten/frappe","description":"Full stack web framework in python & js. Used to build erpnext","fork":true,"url":"https://api.github.com/repos/RobertSchouten/frappe","forks_url":"https://api.github.com/repos/RobertSchouten/frappe/forks","keys_url":"https://api.github.com/repos/RobertSchouten/frappe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RobertSchouten/frappe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RobertSchouten/frappe/teams","hooks_url":"https://api.github.com/repos/RobertSchouten/frappe/hooks","issue_events_url":"https://api.github.com/repos/RobertSchouten/frappe/issues/events{/number}","events_url":"https://api.github.com/repos/RobertSchouten/frappe/events","assignees_url":"https://api.github.com/repos/RobertSchouten/frappe/assignees{/user}","branches_url":"https://api.github.com/repos/RobertSchouten/frappe/branches{/branch}","tags_url":"https://api.github.com/repos/RobertSchouten/frappe/tags","blobs_url":"https://api.github.com/repos/RobertSchouten/frappe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RobertSchouten/frappe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RobertSchouten/frappe/git/refs{/sha}","trees_url":"https://api.github.com/repos/RobertSchouten/frappe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RobertSchouten/frappe/statuses/{sha}","languages_url":"https://api.github.com/repos/RobertSchouten/frappe/languages","stargazers_url":"https://api.github.com/repos/RobertSchouten/frappe/stargazers","contributors_url":"https://api.github.com/repos/RobertSchouten/frappe/contributors","subscribers_url":"https://api.github.com/repos/RobertSchouten/frappe/subscribers","subscription_url":"https://api.github.com/repos/RobertSchouten/frappe/subscription","commits_url":"https://api.github.com/repos/RobertSchouten/frappe/commits{/sha}","git_commits_url":"https://api.github.com/repos/RobertSchouten/frappe/git/commits{/sha}","comments_url":"https://api.github.com/repos/RobertSchouten/frappe/comments{/number}","issue_comment_url":"https://api.github.com/repos/RobertSchouten/frappe/issues/comments{/number}","contents_url":"https://api.github.com/repos/RobertSchouten/frappe/contents/{+path}","compare_url":"https://api.github.com/repos/RobertSchouten/frappe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RobertSchouten/frappe/merges","archive_url":"https://api.github.com/repos/RobertSchouten/frappe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RobertSchouten/frappe/downloads","issues_url":"https://api.github.com/repos/RobertSchouten/frappe/issues{/number}","pulls_url":"https://api.github.com/repos/RobertSchouten/frappe/pulls{/number}","milestones_url":"https://api.github.com/repos/RobertSchouten/frappe/milestones{/number}","notifications_url":"https://api.github.com/repos/RobertSchouten/frappe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RobertSchouten/frappe/labels{/name}","releases_url":"https://api.github.com/repos/RobertSchouten/frappe/releases{/id}","deployments_url":"https://api.github.com/repos/RobertSchouten/frappe/deployments","created_at":"2016-02-03T08:38:57Z","updated_at":"2016-06-22T09:03:55Z","pushed_at":"2016-12-12T01:35:56Z","git_url":"git://github.com/RobertSchouten/frappe.git","ssh_url":"git@github.com:RobertSchouten/frappe.git","clone_url":"https://github.com/RobertSchouten/frappe.git","svn_url":"https://github.com/RobertSchouten/frappe","homepage":"http://erpnext.org","size":82615,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"frappe:develop","ref":"develop","sha":"07ce46668f4cf647af075d6a33875faefd895458","user":{"login":"frappe","id":836974,"avatar_url":"https://avatars.githubusercontent.com/u/836974?v=3","gravatar_id":"","url":"https://api.github.com/users/frappe","html_url":"https://github.com/frappe","followers_url":"https://api.github.com/users/frappe/followers","following_url":"https://api.github.com/users/frappe/following{/other_user}","gists_url":"https://api.github.com/users/frappe/gists{/gist_id}","starred_url":"https://api.github.com/users/frappe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frappe/subscriptions","organizations_url":"https://api.github.com/users/frappe/orgs","repos_url":"https://api.github.com/users/frappe/repos","events_url":"https://api.github.com/users/frappe/events{/privacy}","received_events_url":"https://api.github.com/users/frappe/received_events","type":"Organization","site_admin":false},"repo":{"id":1864194,"name":"frappe","full_name":"frappe/frappe","owner":{"login":"frappe","id":836974,"avatar_url":"https://avatars.githubusercontent.com/u/836974?v=3","gravatar_id":"","url":"https://api.github.com/users/frappe","html_url":"https://github.com/frappe","followers_url":"https://api.github.com/users/frappe/followers","following_url":"https://api.github.com/users/frappe/following{/other_user}","gists_url":"https://api.github.com/users/frappe/gists{/gist_id}","starred_url":"https://api.github.com/users/frappe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frappe/subscriptions","organizations_url":"https://api.github.com/users/frappe/orgs","repos_url":"https://api.github.com/users/frappe/repos","events_url":"https://api.github.com/users/frappe/events{/privacy}","received_events_url":"https://api.github.com/users/frappe/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/frappe/frappe","description":"Full Stack Web Framework in Python & JS. Used to build ERPNext","fork":false,"url":"https://api.github.com/repos/frappe/frappe","forks_url":"https://api.github.com/repos/frappe/frappe/forks","keys_url":"https://api.github.com/repos/frappe/frappe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/frappe/frappe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/frappe/frappe/teams","hooks_url":"https://api.github.com/repos/frappe/frappe/hooks","issue_events_url":"https://api.github.com/repos/frappe/frappe/issues/events{/number}","events_url":"https://api.github.com/repos/frappe/frappe/events","assignees_url":"https://api.github.com/repos/frappe/frappe/assignees{/user}","branches_url":"https://api.github.com/repos/frappe/frappe/branches{/branch}","tags_url":"https://api.github.com/repos/frappe/frappe/tags","blobs_url":"https://api.github.com/repos/frappe/frappe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/frappe/frappe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/frappe/frappe/git/refs{/sha}","trees_url":"https://api.github.com/repos/frappe/frappe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/frappe/frappe/statuses/{sha}","languages_url":"https://api.github.com/repos/frappe/frappe/languages","stargazers_url":"https://api.github.com/repos/frappe/frappe/stargazers","contributors_url":"https://api.github.com/repos/frappe/frappe/contributors","subscribers_url":"https://api.github.com/repos/frappe/frappe/subscribers","subscription_url":"https://api.github.com/repos/frappe/frappe/subscription","commits_url":"https://api.github.com/repos/frappe/frappe/commits{/sha}","git_commits_url":"https://api.github.com/repos/frappe/frappe/git/commits{/sha}","comments_url":"https://api.github.com/repos/frappe/frappe/comments{/number}","issue_comment_url":"https://api.github.com/repos/frappe/frappe/issues/comments{/number}","contents_url":"https://api.github.com/repos/frappe/frappe/contents/{+path}","compare_url":"https://api.github.com/repos/frappe/frappe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/frappe/frappe/merges","archive_url":"https://api.github.com/repos/frappe/frappe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/frappe/frappe/downloads","issues_url":"https://api.github.com/repos/frappe/frappe/issues{/number}","pulls_url":"https://api.github.com/repos/frappe/frappe/pulls{/number}","milestones_url":"https://api.github.com/repos/frappe/frappe/milestones{/number}","notifications_url":"https://api.github.com/repos/frappe/frappe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/frappe/frappe/labels{/name}","releases_url":"https://api.github.com/repos/frappe/frappe/releases{/id}","deployments_url":"https://api.github.com/repos/frappe/frappe/deployments","created_at":"2011-06-08T08:14:16Z","updated_at":"2016-12-12T06:44:58Z","pushed_at":"2016-12-12T09:05:05Z","git_url":"git://github.com/frappe/frappe.git","ssh_url":"git@github.com:frappe/frappe.git","clone_url":"https://github.com/frappe/frappe.git","svn_url":"https://github.com/frappe/frappe","homepage":"http://frappe.io","size":96138,"stargazers_count":484,"watchers_count":484,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":352,"mirror_url":null,"open_issues_count":198,"forks":352,"open_issues":198,"watchers":484,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/frappe/frappe/pulls/2441"},"html":{"href":"https://github.com/frappe/frappe/pull/2441"},"issue":{"href":"https://api.github.com/repos/frappe/frappe/issues/2441"},"comments":{"href":"https://api.github.com/repos/frappe/frappe/issues/2441/comments"},"review_comments":{"href":"https://api.github.com/repos/frappe/frappe/pulls/2441/comments"},"review_comment":{"href":"https://api.github.com/repos/frappe/frappe/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/frappe/frappe/pulls/2441/commits"},"statuses":{"href":"https://api.github.com/repos/frappe/frappe/statuses/b717df02d758290e349ab398cded53ae6c0bedc2"}}}}
{"actor":{"display_login":"rmehta"}}