{"action":"created","issue":{"url":"https://api.github.com/repos/diginc/docker-pi-hole/issues/23","repository_url":"https://api.github.com/repos/diginc/docker-pi-hole","labels_url":"https://api.github.com/repos/diginc/docker-pi-hole/issues/23/labels{/name}","comments_url":"https://api.github.com/repos/diginc/docker-pi-hole/issues/23/comments","events_url":"https://api.github.com/repos/diginc/docker-pi-hole/issues/23/events","html_url":"https://github.com/diginc/docker-pi-hole/issues/23","id":166190614,"number":23,"title":"Inconsistent Behavior with Whitelist from Admin GUI","user":{"login":"dbec","id":10676646,"avatar_url":"https://avatars.githubusercontent.com/u/10676646?v=3","gravatar_id":"","url":"https://api.github.com/users/dbec","html_url":"https://github.com/dbec","followers_url":"https://api.github.com/users/dbec/followers","following_url":"https://api.github.com/users/dbec/following{/other_user}","gists_url":"https://api.github.com/users/dbec/gists{/gist_id}","starred_url":"https://api.github.com/users/dbec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbec/subscriptions","organizations_url":"https://api.github.com/users/dbec/orgs","repos_url":"https://api.github.com/users/dbec/repos","events_url":"https://api.github.com/users/dbec/events{/privacy}","received_events_url":"https://api.github.com/users/dbec/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-07-18T20:51:57Z","updated_at":"2016-07-18T22:30:50Z","closed_at":null,"body":"Using \"debian_dev\" tagged version, in the admin interface I'm noticing odd behavior:\r\nAdd a domain to whitelist\r\nConfirm domain is added to end of /etc/pihole/whitelist.txt on container\r\nRemove domain from whitelist via red garbage can icon on the right\r\nDomain is removed from list in the GUI\r\nDomain is no longer in whitelist.txt\r\nHowever, domain is added to end of gravity.list (?!), causing the domain to be \"pi-holed\"\r\n\r\nI noticed this in earlier versions as well.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/diginc/docker-pi-hole/issues/comments/233478824","html_url":"https://github.com/diginc/docker-pi-hole/issues/23#issuecomment-233478824","issue_url":"https://api.github.com/repos/diginc/docker-pi-hole/issues/23","id":233478824,"user":{"login":"diginc","id":868002,"avatar_url":"https://avatars.githubusercontent.com/u/868002?v=3","gravatar_id":"","url":"https://api.github.com/users/diginc","html_url":"https://github.com/diginc","followers_url":"https://api.github.com/users/diginc/followers","following_url":"https://api.github.com/users/diginc/following{/other_user}","gists_url":"https://api.github.com/users/diginc/gists{/gist_id}","starred_url":"https://api.github.com/users/diginc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diginc/subscriptions","organizations_url":"https://api.github.com/users/diginc/orgs","repos_url":"https://api.github.com/users/diginc/repos","events_url":"https://api.github.com/users/diginc/events{/privacy}","received_events_url":"https://api.github.com/users/diginc/received_events","type":"User","site_admin":false},"created_at":"2016-07-18T22:30:50Z","updated_at":"2016-07-18T22:30:50Z","body":"```\r\nroot@90dab8d5adbc:/# sudo pihole -w -q issue23.github\r\n::: You are root.\r\n:::\r\n::: Modifying HOSTS file to whitelist 9 domains... done!\r\n:::\r\n::: Refresh lists in dnsmasq... done!\r\nroot@90dab8d5adbc:/# grep 'issue23' /etc/pihole/*\r\n/etc/pihole/whitelist.txt:issue23.github\r\n\r\nroot@90dab8d5adbc:/# sudo pihole -w -q -d issue23.github\r\n::: You are root.\r\n:::\r\n::: Modifying HOSTS file to un-whitelist domains...\r\n:::    Un-whitelisting issue23.github on IPv4 done!\r\n:::        Removing issue23.github from /etc/pihole/whitelist.txt... done!\r\n:::\r\n::: Refresh lists in dnsmasq... done!\r\nroot@90dab8d5adbc:/# grep 'issue23' /etc/pihole/*\r\n/etc/pihole/gravity.list:192.168.41.55 issue23.github\r\n```\r\n\r\nYup...I can reproduce this without using my AdminLTE fork code changes so I'm going to have to call in @pi-hole/dashboard , what do you guys think?  \r\n\r\nThis line to blame?  \r\nhttps://github.com/pi-hole/pi-hole/blob/master/advanced/Scripts/whitelist.sh#L185\r\nun-whitelist = auto-blacklist ?"}}
{"actor":{"display_login":"diginc"}}