{"action":"created","comment":{"url":"https://api.github.com/repos/getsenic/nuimo-windows/pulls/comments/75353808","id":75353808,"diff_hunk":"@@ -1,16 +0,0 @@\n-﻿{\n-  \"dependencies\": {\n-    \"Microsoft.NETCore.UniversalWindowsPlatform\": \"5.0.0\"\n-  },\n-  \"frameworks\": {\n-    \"uap10.0\": {}\n-  },\n-  \"runtimes\": {\n-    \"win10-arm\": {},\n-    \"win10-arm-aot\": {},\n-    \"win10-x86\": {},\n-    \"win10-x86-aot\": {},\n-    \"win10-x64\": {},\n-    \"win10-x64-aot\": {}\n-  }\n-}","path":"NuimoSDK/project.json","position":16,"original_position":16,"commit_id":"0fe9dd8bc4bc189974567a6aba3be00a35012e6d","original_commit_id":"0fe9dd8bc4bc189974567a6aba3be00a35012e6d","user":{"login":"Inrego","id":2242329,"avatar_url":"https://avatars.githubusercontent.com/u/2242329?v=3","gravatar_id":"","url":"https://api.github.com/users/Inrego","html_url":"https://github.com/Inrego","followers_url":"https://api.github.com/users/Inrego/followers","following_url":"https://api.github.com/users/Inrego/following{/other_user}","gists_url":"https://api.github.com/users/Inrego/gists{/gist_id}","starred_url":"https://api.github.com/users/Inrego/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Inrego/subscriptions","organizations_url":"https://api.github.com/users/Inrego/orgs","repos_url":"https://api.github.com/users/Inrego/repos","events_url":"https://api.github.com/users/Inrego/events{/privacy}","received_events_url":"https://api.github.com/users/Inrego/received_events","type":"User","site_admin":false},"body":"No it's not necessary. It's a required file for the project type you initially created. It is not used by the project type I changed to.","created_at":"2016-08-18T17:41:56Z","updated_at":"2016-08-18T17:41:56Z","html_url":"https://github.com/getsenic/nuimo-windows/pull/8#discussion_r75353808","pull_request_url":"https://api.github.com/repos/getsenic/nuimo-windows/pulls/8","_links":{"self":{"href":"https://api.github.com/repos/getsenic/nuimo-windows/pulls/comments/75353808"},"html":{"href":"https://github.com/getsenic/nuimo-windows/pull/8#discussion_r75353808"},"pull_request":{"href":"https://api.github.com/repos/getsenic/nuimo-windows/pulls/8"}}},"pull_request":{"url":"https://api.github.com/repos/getsenic/nuimo-windows/pulls/8","id":80278482,"html_url":"https://github.com/getsenic/nuimo-windows/pull/8","diff_url":"https://github.com/getsenic/nuimo-windows/pull/8.diff","patch_url":"https://github.com/getsenic/nuimo-windows/pull/8.patch","issue_url":"https://api.github.com/repos/getsenic/nuimo-windows/issues/8","number":8,"state":"open","locked":false,"title":"Converted to Portable library","user":{"login":"Inrego","id":2242329,"avatar_url":"https://avatars.githubusercontent.com/u/2242329?v=3","gravatar_id":"","url":"https://api.github.com/users/Inrego","html_url":"https://github.com/Inrego","followers_url":"https://api.github.com/users/Inrego/followers","following_url":"https://api.github.com/users/Inrego/following{/other_user}","gists_url":"https://api.github.com/users/Inrego/gists{/gist_id}","starred_url":"https://api.github.com/users/Inrego/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Inrego/subscriptions","organizations_url":"https://api.github.com/users/Inrego/orgs","repos_url":"https://api.github.com/users/Inrego/repos","events_url":"https://api.github.com/users/Inrego/events{/privacy}","received_events_url":"https://api.github.com/users/Inrego/received_events","type":"User","site_admin":false},"body":"I've converted the project to a portable library, in order to be able to target both UWP 10 and .NET 4.5\r\n\r\nI've tested that the compiled .dll can be referenced in both a .NET 4.5 project and a UWP 10 project. I have also tested that the resulting .dll works in .NET 4.5 by successfully writing a LED Matrix to the Nuimo device. I have not yet tested the .dll in any UWP projects, but as Portable libraries are exactly for this kind of stuff, I can't imagine why it shouldn't work. Still think it should be tested before going live with the change, though.","created_at":"2016-08-05T17:26:54Z","updated_at":"2016-08-18T17:41:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"25791e4170ccc1f9ae30f418969d2288393ed4ee","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/getsenic/nuimo-windows/pulls/8/commits","review_comments_url":"https://api.github.com/repos/getsenic/nuimo-windows/pulls/8/comments","review_comment_url":"https://api.github.com/repos/getsenic/nuimo-windows/pulls/comments{/number}","comments_url":"https://api.github.com/repos/getsenic/nuimo-windows/issues/8/comments","statuses_url":"https://api.github.com/repos/getsenic/nuimo-windows/statuses/0fe9dd8bc4bc189974567a6aba3be00a35012e6d","head":{"label":"Inrego:master","ref":"master","sha":"0fe9dd8bc4bc189974567a6aba3be00a35012e6d","user":{"login":"Inrego","id":2242329,"avatar_url":"https://avatars.githubusercontent.com/u/2242329?v=3","gravatar_id":"","url":"https://api.github.com/users/Inrego","html_url":"https://github.com/Inrego","followers_url":"https://api.github.com/users/Inrego/followers","following_url":"https://api.github.com/users/Inrego/following{/other_user}","gists_url":"https://api.github.com/users/Inrego/gists{/gist_id}","starred_url":"https://api.github.com/users/Inrego/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Inrego/subscriptions","organizations_url":"https://api.github.com/users/Inrego/orgs","repos_url":"https://api.github.com/users/Inrego/repos","events_url":"https://api.github.com/users/Inrego/events{/privacy}","received_events_url":"https://api.github.com/users/Inrego/received_events","type":"User","site_admin":false},"repo":{"id":65033189,"name":"nuimo-windows","full_name":"Inrego/nuimo-windows","owner":{"login":"Inrego","id":2242329,"avatar_url":"https://avatars.githubusercontent.com/u/2242329?v=3","gravatar_id":"","url":"https://api.github.com/users/Inrego","html_url":"https://github.com/Inrego","followers_url":"https://api.github.com/users/Inrego/followers","following_url":"https://api.github.com/users/Inrego/following{/other_user}","gists_url":"https://api.github.com/users/Inrego/gists{/gist_id}","starred_url":"https://api.github.com/users/Inrego/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Inrego/subscriptions","organizations_url":"https://api.github.com/users/Inrego/orgs","repos_url":"https://api.github.com/users/Inrego/repos","events_url":"https://api.github.com/users/Inrego/events{/privacy}","received_events_url":"https://api.github.com/users/Inrego/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Inrego/nuimo-windows","description":"Library for Windows 10 platforms to connect and communicate with Nuimo controllers made by Senic","fork":true,"url":"https://api.github.com/repos/Inrego/nuimo-windows","forks_url":"https://api.github.com/repos/Inrego/nuimo-windows/forks","keys_url":"https://api.github.com/repos/Inrego/nuimo-windows/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Inrego/nuimo-windows/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Inrego/nuimo-windows/teams","hooks_url":"https://api.github.com/repos/Inrego/nuimo-windows/hooks","issue_events_url":"https://api.github.com/repos/Inrego/nuimo-windows/issues/events{/number}","events_url":"https://api.github.com/repos/Inrego/nuimo-windows/events","assignees_url":"https://api.github.com/repos/Inrego/nuimo-windows/assignees{/user}","branches_url":"https://api.github.com/repos/Inrego/nuimo-windows/branches{/branch}","tags_url":"https://api.github.com/repos/Inrego/nuimo-windows/tags","blobs_url":"https://api.github.com/repos/Inrego/nuimo-windows/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Inrego/nuimo-windows/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Inrego/nuimo-windows/git/refs{/sha}","trees_url":"https://api.github.com/repos/Inrego/nuimo-windows/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Inrego/nuimo-windows/statuses/{sha}","languages_url":"https://api.github.com/repos/Inrego/nuimo-windows/languages","stargazers_url":"https://api.github.com/repos/Inrego/nuimo-windows/stargazers","contributors_url":"https://api.github.com/repos/Inrego/nuimo-windows/contributors","subscribers_url":"https://api.github.com/repos/Inrego/nuimo-windows/subscribers","subscription_url":"https://api.github.com/repos/Inrego/nuimo-windows/subscription","commits_url":"https://api.github.com/repos/Inrego/nuimo-windows/commits{/sha}","git_commits_url":"https://api.github.com/repos/Inrego/nuimo-windows/git/commits{/sha}","comments_url":"https://api.github.com/repos/Inrego/nuimo-windows/comments{/number}","issue_comment_url":"https://api.github.com/repos/Inrego/nuimo-windows/issues/comments{/number}","contents_url":"https://api.github.com/repos/Inrego/nuimo-windows/contents/{+path}","compare_url":"https://api.github.com/repos/Inrego/nuimo-windows/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Inrego/nuimo-windows/merges","archive_url":"https://api.github.com/repos/Inrego/nuimo-windows/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Inrego/nuimo-windows/downloads","issues_url":"https://api.github.com/repos/Inrego/nuimo-windows/issues{/number}","pulls_url":"https://api.github.com/repos/Inrego/nuimo-windows/pulls{/number}","milestones_url":"https://api.github.com/repos/Inrego/nuimo-windows/milestones{/number}","notifications_url":"https://api.github.com/repos/Inrego/nuimo-windows/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Inrego/nuimo-windows/labels{/name}","releases_url":"https://api.github.com/repos/Inrego/nuimo-windows/releases{/id}","deployments_url":"https://api.github.com/repos/Inrego/nuimo-windows/deployments","created_at":"2016-08-05T16:27:40Z","updated_at":"2016-08-05T16:27:42Z","pushed_at":"2016-08-12T00:36:27Z","git_url":"git://github.com/Inrego/nuimo-windows.git","ssh_url":"git@github.com:Inrego/nuimo-windows.git","clone_url":"https://github.com/Inrego/nuimo-windows.git","svn_url":"https://github.com/Inrego/nuimo-windows","homepage":"","size":1137,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"getsenic:master","ref":"master","sha":"9a3b0f9a78a40da80470799e4201928785a679fc","user":{"login":"getsenic","id":4527760,"avatar_url":"https://avatars.githubusercontent.com/u/4527760?v=3","gravatar_id":"","url":"https://api.github.com/users/getsenic","html_url":"https://github.com/getsenic","followers_url":"https://api.github.com/users/getsenic/followers","following_url":"https://api.github.com/users/getsenic/following{/other_user}","gists_url":"https://api.github.com/users/getsenic/gists{/gist_id}","starred_url":"https://api.github.com/users/getsenic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getsenic/subscriptions","organizations_url":"https://api.github.com/users/getsenic/orgs","repos_url":"https://api.github.com/users/getsenic/repos","events_url":"https://api.github.com/users/getsenic/events{/privacy}","received_events_url":"https://api.github.com/users/getsenic/received_events","type":"Organization","site_admin":false},"repo":{"id":63604450,"name":"nuimo-windows","full_name":"getsenic/nuimo-windows","owner":{"login":"getsenic","id":4527760,"avatar_url":"https://avatars.githubusercontent.com/u/4527760?v=3","gravatar_id":"","url":"https://api.github.com/users/getsenic","html_url":"https://github.com/getsenic","followers_url":"https://api.github.com/users/getsenic/followers","following_url":"https://api.github.com/users/getsenic/following{/other_user}","gists_url":"https://api.github.com/users/getsenic/gists{/gist_id}","starred_url":"https://api.github.com/users/getsenic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getsenic/subscriptions","organizations_url":"https://api.github.com/users/getsenic/orgs","repos_url":"https://api.github.com/users/getsenic/repos","events_url":"https://api.github.com/users/getsenic/events{/privacy}","received_events_url":"https://api.github.com/users/getsenic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/getsenic/nuimo-windows","description":"Library for Windows 10 platforms to connect and communicate with Nuimo controllers made by Senic","fork":false,"url":"https://api.github.com/repos/getsenic/nuimo-windows","forks_url":"https://api.github.com/repos/getsenic/nuimo-windows/forks","keys_url":"https://api.github.com/repos/getsenic/nuimo-windows/keys{/key_id}","collaborators_url":"https://api.github.com/repos/getsenic/nuimo-windows/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/getsenic/nuimo-windows/teams","hooks_url":"https://api.github.com/repos/getsenic/nuimo-windows/hooks","issue_events_url":"https://api.github.com/repos/getsenic/nuimo-windows/issues/events{/number}","events_url":"https://api.github.com/repos/getsenic/nuimo-windows/events","assignees_url":"https://api.github.com/repos/getsenic/nuimo-windows/assignees{/user}","branches_url":"https://api.github.com/repos/getsenic/nuimo-windows/branches{/branch}","tags_url":"https://api.github.com/repos/getsenic/nuimo-windows/tags","blobs_url":"https://api.github.com/repos/getsenic/nuimo-windows/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/getsenic/nuimo-windows/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/getsenic/nuimo-windows/git/refs{/sha}","trees_url":"https://api.github.com/repos/getsenic/nuimo-windows/git/trees{/sha}","statuses_url":"https://api.github.com/repos/getsenic/nuimo-windows/statuses/{sha}","languages_url":"https://api.github.com/repos/getsenic/nuimo-windows/languages","stargazers_url":"https://api.github.com/repos/getsenic/nuimo-windows/stargazers","contributors_url":"https://api.github.com/repos/getsenic/nuimo-windows/contributors","subscribers_url":"https://api.github.com/repos/getsenic/nuimo-windows/subscribers","subscription_url":"https://api.github.com/repos/getsenic/nuimo-windows/subscription","commits_url":"https://api.github.com/repos/getsenic/nuimo-windows/commits{/sha}","git_commits_url":"https://api.github.com/repos/getsenic/nuimo-windows/git/commits{/sha}","comments_url":"https://api.github.com/repos/getsenic/nuimo-windows/comments{/number}","issue_comment_url":"https://api.github.com/repos/getsenic/nuimo-windows/issues/comments{/number}","contents_url":"https://api.github.com/repos/getsenic/nuimo-windows/contents/{+path}","compare_url":"https://api.github.com/repos/getsenic/nuimo-windows/compare/{base}...{head}","merges_url":"https://api.github.com/repos/getsenic/nuimo-windows/merges","archive_url":"https://api.github.com/repos/getsenic/nuimo-windows/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/getsenic/nuimo-windows/downloads","issues_url":"https://api.github.com/repos/getsenic/nuimo-windows/issues{/number}","pulls_url":"https://api.github.com/repos/getsenic/nuimo-windows/pulls{/number}","milestones_url":"https://api.github.com/repos/getsenic/nuimo-windows/milestones{/number}","notifications_url":"https://api.github.com/repos/getsenic/nuimo-windows/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/getsenic/nuimo-windows/labels{/name}","releases_url":"https://api.github.com/repos/getsenic/nuimo-windows/releases{/id}","deployments_url":"https://api.github.com/repos/getsenic/nuimo-windows/deployments","created_at":"2016-07-18T13:17:03Z","updated_at":"2016-08-16T20:16:19Z","pushed_at":"2016-08-12T22:52:39Z","git_url":"git://github.com/getsenic/nuimo-windows.git","ssh_url":"git@github.com:getsenic/nuimo-windows.git","clone_url":"https://github.com/getsenic/nuimo-windows.git","svn_url":"https://github.com/getsenic/nuimo-windows","homepage":"","size":1141,"stargazers_count":8,"watchers_count":8,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":6,"forks":4,"open_issues":6,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/getsenic/nuimo-windows/pulls/8"},"html":{"href":"https://github.com/getsenic/nuimo-windows/pull/8"},"issue":{"href":"https://api.github.com/repos/getsenic/nuimo-windows/issues/8"},"comments":{"href":"https://api.github.com/repos/getsenic/nuimo-windows/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/getsenic/nuimo-windows/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/getsenic/nuimo-windows/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/getsenic/nuimo-windows/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/getsenic/nuimo-windows/statuses/0fe9dd8bc4bc189974567a6aba3be00a35012e6d"}}}}
{"actor":{"display_login":"Inrego"}}