{"action":"created","issue":{"url":"https://api.github.com/repos/openshift/origin/issues/8925","repository_url":"https://api.github.com/repos/openshift/origin","labels_url":"https://api.github.com/repos/openshift/origin/issues/8925/labels{/name}","comments_url":"https://api.github.com/repos/openshift/origin/issues/8925/comments","events_url":"https://api.github.com/repos/openshift/origin/issues/8925/events","html_url":"https://github.com/openshift/origin/pull/8925","id":155543579,"number":8925,"title":"F5: Cleanup mockF5.close() calls in tests","user":{"login":"Miciah","id":2042465,"avatar_url":"https://avatars.githubusercontent.com/u/2042465?v=3","gravatar_id":"","url":"https://api.github.com/users/Miciah","html_url":"https://github.com/Miciah","followers_url":"https://api.github.com/users/Miciah/followers","following_url":"https://api.github.com/users/Miciah/following{/other_user}","gists_url":"https://api.github.com/users/Miciah/gists{/gist_id}","starred_url":"https://api.github.com/users/Miciah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Miciah/subscriptions","organizations_url":"https://api.github.com/users/Miciah/orgs","repos_url":"https://api.github.com/users/Miciah/repos","events_url":"https://api.github.com/users/Miciah/events{/privacy}","received_events_url":"https://api.github.com/users/Miciah/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-05-18T16:17:05Z","updated_at":"2016-05-18T17:18:55Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/8925","html_url":"https://github.com/openshift/origin/pull/8925","diff_url":"https://github.com/openshift/origin/pull/8925.diff","patch_url":"https://github.com/openshift/origin/pull/8925.patch"},"body":"Comment `newTestRouterWithState` and `newTestRouter`.\r\n\r\nDelete workaround for slow ECDHE performance now that that issue has been resolved (per https://github.com/openshift/origin/issues/4417).\r\n\r\nClose the mock F5 server when `TestInitializeF5Plugin` finishes.\r\n\r\nFix a potential `nil` pointer dereference in `TestF5RouterPartition`.\r\n\r\nFix a potential double-close in `TestF5RouterPartition`.\r\n\r\nRelated to https://github.com/openshift/origin/issues/8908\r\n\r\n--\r\n\r\nopenshift-bot, please [test]!\r\n\r\n@ramr\r\n\r\n--\r\n\r\nI'm not confident that these changes alone will resolve all the problems reported in the issue, but let's go ahead and see what happens when we fix the obvious problems..."},"comment":{"url":"https://api.github.com/repos/openshift/origin/issues/comments/220097147","html_url":"https://github.com/openshift/origin/pull/8925#issuecomment-220097147","issue_url":"https://api.github.com/repos/openshift/origin/issues/8925","id":220097147,"user":{"login":"Miciah","id":2042465,"avatar_url":"https://avatars.githubusercontent.com/u/2042465?v=3","gravatar_id":"","url":"https://api.github.com/users/Miciah","html_url":"https://github.com/Miciah","followers_url":"https://api.github.com/users/Miciah/followers","following_url":"https://api.github.com/users/Miciah/following{/other_user}","gists_url":"https://api.github.com/users/Miciah/gists{/gist_id}","starred_url":"https://api.github.com/users/Miciah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Miciah/subscriptions","organizations_url":"https://api.github.com/users/Miciah/orgs","repos_url":"https://api.github.com/users/Miciah/repos","events_url":"https://api.github.com/users/Miciah/events{/privacy}","received_events_url":"https://api.github.com/users/Miciah/received_events","type":"User","site_admin":false},"created_at":"2016-05-18T17:18:55Z","updated_at":"2016-05-18T17:18:55Z","body":"Thanks, openshift-bot! Would you mind [test]ing again since I amended the commit, and it looks like you tested the initial version?"}}