{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/6277","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/6277/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/6277/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/6277/events","html_url":"https://github.com/nodejs/node/pull/6277","id":149486632,"number":6277,"title":"v8: warn in Template::Set() on improper use","user":{"login":"bnoordhuis","id":275871,"avatar_url":"https://avatars.githubusercontent.com/u/275871?v=3","gravatar_id":"","url":"https://api.github.com/users/bnoordhuis","html_url":"https://github.com/bnoordhuis","followers_url":"https://api.github.com/users/bnoordhuis/followers","following_url":"https://api.github.com/users/bnoordhuis/following{/other_user}","gists_url":"https://api.github.com/users/bnoordhuis/gists{/gist_id}","starred_url":"https://api.github.com/users/bnoordhuis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bnoordhuis/subscriptions","organizations_url":"https://api.github.com/users/bnoordhuis/orgs","repos_url":"https://api.github.com/users/bnoordhuis/repos","events_url":"https://api.github.com/users/bnoordhuis/events{/privacy}","received_events_url":"https://api.github.com/users/bnoordhuis/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/nodejs/node/labels/v8","name":"v8","color":"0052cc"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/nodejs/node/milestones/13","html_url":"https://github.com/nodejs/node/milestones/6.0.0","labels_url":"https://api.github.com/repos/nodejs/node/milestones/13/labels","id":1269366,"number":13,"title":"6.0.0","description":"","creator":{"login":"Fishrock123","id":1093990,"avatar_url":"https://avatars.githubusercontent.com/u/1093990?v=3","gravatar_id":"","url":"https://api.github.com/users/Fishrock123","html_url":"https://github.com/Fishrock123","followers_url":"https://api.github.com/users/Fishrock123/followers","following_url":"https://api.github.com/users/Fishrock123/following{/other_user}","gists_url":"https://api.github.com/users/Fishrock123/gists{/gist_id}","starred_url":"https://api.github.com/users/Fishrock123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fishrock123/subscriptions","organizations_url":"https://api.github.com/users/Fishrock123/orgs","repos_url":"https://api.github.com/users/Fishrock123/repos","events_url":"https://api.github.com/users/Fishrock123/events{/privacy}","received_events_url":"https://api.github.com/users/Fishrock123/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":21,"state":"open","created_at":"2015-08-24T13:31:52Z","updated_at":"2016-04-19T14:57:15Z","due_on":"2016-04-30T04:00:00Z","closed_at":null},"comments":6,"created_at":"2016-04-19T14:57:15Z","updated_at":"2016-04-19T16:57:59Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/6277","html_url":"https://github.com/nodejs/node/pull/6277","diff_url":"https://github.com/nodejs/node/pull/6277.diff","patch_url":"https://github.com/nodejs/node/pull/6277.patch"},"body":"The next major release will make it a fatal error to use non-primitive\r\nvalues in function templates and object templates.\r\n\r\nPrint a warning that includes the C and JS stack trace to tell people to\r\nupgrade their add-ons.  The C stack trace is only printed on platforms\r\nthat support it (the BSDs, OS X and Linux+glibc.)\r\n\r\nRefs: #6216\r\n\r\nSpeculative - I'd like some input whether other collaborators think it's a good approach.  It can get pretty noisy when native code abuses `v8::Template::Set()` a lot but OTOH, hopefully that means it gets fixed quickly.\r\n\r\nCI: https://ci.nodejs.org/job/node-test-pull-request/2319/"},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/212015520","html_url":"https://github.com/nodejs/node/pull/6277#issuecomment-212015520","issue_url":"https://api.github.com/repos/nodejs/node/issues/6277","id":212015520,"user":{"login":"ofrobots","id":79017,"avatar_url":"https://avatars.githubusercontent.com/u/79017?v=3","gravatar_id":"","url":"https://api.github.com/users/ofrobots","html_url":"https://github.com/ofrobots","followers_url":"https://api.github.com/users/ofrobots/followers","following_url":"https://api.github.com/users/ofrobots/following{/other_user}","gists_url":"https://api.github.com/users/ofrobots/gists{/gist_id}","starred_url":"https://api.github.com/users/ofrobots/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ofrobots/subscriptions","organizations_url":"https://api.github.com/users/ofrobots/orgs","repos_url":"https://api.github.com/users/ofrobots/repos","events_url":"https://api.github.com/users/ofrobots/events{/privacy}","received_events_url":"https://api.github.com/users/ofrobots/received_events","type":"User","site_admin":false},"created_at":"2016-04-19T16:57:59Z","updated_at":"2016-04-19T16:57:59Z","body":"I wonder if it makes sense to add a flag (upstream, and floated here) to silence such runtime deprecation warnings. I do think it is good to be noisy by default on such imminent deprecations, but it would also be nice to be able to silence the warning if the user wishes.\r\n\r\nOne the problems native modules have had is that they never realize that things have been deprecated for a long time, and discover it when next Node.js major w/ new V8 drop them. If such a runtime deprecation warning flag existed, we could potentially use it for more things."}}