{"action":"created","comment":{"url":"https://api.github.com/repos/Katello/forklift/pulls/comments/84101385","pull_request_review_id":4900088,"id":84101385,"diff_hunk":"@@ -63,13 +63,15 @@ def process_versions(config, versions)\n           katello_box = Marshal.load(\n             Marshal.dump(config['boxes'][\"#{os}-katello-nightly\"])\n           )\n-          katello_box['options'] ||= []\n-          katello_box['options'] << \" --version #{version}\"\n+          katello_box['ansible'] ||= {}\n+          katello_box['ansible']['variables'] = { 'foreman_version' => version }\n \n           capsule_box = Marshal.load(\n             Marshal.dump(config['boxes'][\"#{os}-capsule-nightly\"])\n           )\n+          capsule_box['ansible'] ||= {}\n           capsule_box['ansible']['server'] = \"#{os}-katello-#{katello_version}\"\n+          capsule_box['ansible']['variables'] = { 'foreman_version' => version }","path":"lib/forklift/box_loader.rb","position":14,"original_position":14,"commit_id":"08c266baf32d8dc228a9fd3d5adbc728cd49e11f","original_commit_id":"08c266baf32d8dc228a9fd3d5adbc728cd49e11f","user":{"login":"stbenjam","id":429763,"avatar_url":"https://avatars.githubusercontent.com/u/429763?v=3","gravatar_id":"","url":"https://api.github.com/users/stbenjam","html_url":"https://github.com/stbenjam","followers_url":"https://api.github.com/users/stbenjam/followers","following_url":"https://api.github.com/users/stbenjam/following{/other_user}","gists_url":"https://api.github.com/users/stbenjam/gists{/gist_id}","starred_url":"https://api.github.com/users/stbenjam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stbenjam/subscriptions","organizations_url":"https://api.github.com/users/stbenjam/orgs","repos_url":"https://api.github.com/users/stbenjam/repos","events_url":"https://api.github.com/users/stbenjam/events{/privacy}","received_events_url":"https://api.github.com/users/stbenjam/received_events","type":"User","site_admin":false},"body":"I would be ok with pulling out the dynamic boxes, I think if a user wants a particular box they could just create it with the right variables. Having fewer boxes listed by default in forklift would be better IMHO, especially if the boxes.yaml.example includes an example of a particular versioned box","created_at":"2016-10-19T15:45:07Z","updated_at":"2016-10-19T15:45:07Z","html_url":"https://github.com/Katello/forklift/pull/323#discussion_r84101385","pull_request_url":"https://api.github.com/repos/Katello/forklift/pulls/323","_links":{"self":{"href":"https://api.github.com/repos/Katello/forklift/pulls/comments/84101385"},"html":{"href":"https://github.com/Katello/forklift/pull/323#discussion_r84101385"},"pull_request":{"href":"https://api.github.com/repos/Katello/forklift/pulls/323"}}},"pull_request":{"url":"https://api.github.com/repos/Katello/forklift/pulls/323","id":90002079,"html_url":"https://github.com/Katello/forklift/pull/323","diff_url":"https://github.com/Katello/forklift/pull/323.diff","patch_url":"https://github.com/Katello/forklift/pull/323.patch","issue_url":"https://api.github.com/repos/Katello/forklift/issues/323","number":323,"state":"open","locked":false,"title":"Set foreman_version when building up version boxes","user":{"login":"ehelms","id":293363,"avatar_url":"https://avatars.githubusercontent.com/u/293363?v=3","gravatar_id":"","url":"https://api.github.com/users/ehelms","html_url":"https://github.com/ehelms","followers_url":"https://api.github.com/users/ehelms/followers","following_url":"https://api.github.com/users/ehelms/following{/other_user}","gists_url":"https://api.github.com/users/ehelms/gists{/gist_id}","starred_url":"https://api.github.com/users/ehelms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ehelms/subscriptions","organizations_url":"https://api.github.com/users/ehelms/orgs","repos_url":"https://api.github.com/users/ehelms/repos","events_url":"https://api.github.com/users/ehelms/events{/privacy}","received_events_url":"https://api.github.com/users/ehelms/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-10-19T12:47:25Z","updated_at":"2016-10-19T15:45:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2e74b88c46f05bb02366a88639ec12027ce757b2","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Katello/forklift/pulls/323/commits","review_comments_url":"https://api.github.com/repos/Katello/forklift/pulls/323/comments","review_comment_url":"https://api.github.com/repos/Katello/forklift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Katello/forklift/issues/323/comments","statuses_url":"https://api.github.com/repos/Katello/forklift/statuses/08c266baf32d8dc228a9fd3d5adbc728cd49e11f","head":{"label":"ehelms:fix-version-setting","ref":"fix-version-setting","sha":"08c266baf32d8dc228a9fd3d5adbc728cd49e11f","user":{"login":"ehelms","id":293363,"avatar_url":"https://avatars.githubusercontent.com/u/293363?v=3","gravatar_id":"","url":"https://api.github.com/users/ehelms","html_url":"https://github.com/ehelms","followers_url":"https://api.github.com/users/ehelms/followers","following_url":"https://api.github.com/users/ehelms/following{/other_user}","gists_url":"https://api.github.com/users/ehelms/gists{/gist_id}","starred_url":"https://api.github.com/users/ehelms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ehelms/subscriptions","organizations_url":"https://api.github.com/users/ehelms/orgs","repos_url":"https://api.github.com/users/ehelms/repos","events_url":"https://api.github.com/users/ehelms/events{/privacy}","received_events_url":"https://api.github.com/users/ehelms/received_events","type":"User","site_admin":false},"repo":{"id":16161762,"name":"forklift","full_name":"ehelms/forklift","owner":{"login":"ehelms","id":293363,"avatar_url":"https://avatars.githubusercontent.com/u/293363?v=3","gravatar_id":"","url":"https://api.github.com/users/ehelms","html_url":"https://github.com/ehelms","followers_url":"https://api.github.com/users/ehelms/followers","following_url":"https://api.github.com/users/ehelms/following{/other_user}","gists_url":"https://api.github.com/users/ehelms/gists{/gist_id}","starred_url":"https://api.github.com/users/ehelms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ehelms/subscriptions","organizations_url":"https://api.github.com/users/ehelms/orgs","repos_url":"https://api.github.com/users/ehelms/repos","events_url":"https://api.github.com/users/ehelms/events{/privacy}","received_events_url":"https://api.github.com/users/ehelms/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ehelms/forklift","description":"Helpful deployment scripts for Katello","fork":true,"url":"https://api.github.com/repos/ehelms/forklift","forks_url":"https://api.github.com/repos/ehelms/forklift/forks","keys_url":"https://api.github.com/repos/ehelms/forklift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ehelms/forklift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ehelms/forklift/teams","hooks_url":"https://api.github.com/repos/ehelms/forklift/hooks","issue_events_url":"https://api.github.com/repos/ehelms/forklift/issues/events{/number}","events_url":"https://api.github.com/repos/ehelms/forklift/events","assignees_url":"https://api.github.com/repos/ehelms/forklift/assignees{/user}","branches_url":"https://api.github.com/repos/ehelms/forklift/branches{/branch}","tags_url":"https://api.github.com/repos/ehelms/forklift/tags","blobs_url":"https://api.github.com/repos/ehelms/forklift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ehelms/forklift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ehelms/forklift/git/refs{/sha}","trees_url":"https://api.github.com/repos/ehelms/forklift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ehelms/forklift/statuses/{sha}","languages_url":"https://api.github.com/repos/ehelms/forklift/languages","stargazers_url":"https://api.github.com/repos/ehelms/forklift/stargazers","contributors_url":"https://api.github.com/repos/ehelms/forklift/contributors","subscribers_url":"https://api.github.com/repos/ehelms/forklift/subscribers","subscription_url":"https://api.github.com/repos/ehelms/forklift/subscription","commits_url":"https://api.github.com/repos/ehelms/forklift/commits{/sha}","git_commits_url":"https://api.github.com/repos/ehelms/forklift/git/commits{/sha}","comments_url":"https://api.github.com/repos/ehelms/forklift/comments{/number}","issue_comment_url":"https://api.github.com/repos/ehelms/forklift/issues/comments{/number}","contents_url":"https://api.github.com/repos/ehelms/forklift/contents/{+path}","compare_url":"https://api.github.com/repos/ehelms/forklift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ehelms/forklift/merges","archive_url":"https://api.github.com/repos/ehelms/forklift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ehelms/forklift/downloads","issues_url":"https://api.github.com/repos/ehelms/forklift/issues{/number}","pulls_url":"https://api.github.com/repos/ehelms/forklift/pulls{/number}","milestones_url":"https://api.github.com/repos/ehelms/forklift/milestones{/number}","notifications_url":"https://api.github.com/repos/ehelms/forklift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ehelms/forklift/labels{/name}","releases_url":"https://api.github.com/repos/ehelms/forklift/releases{/id}","deployments_url":"https://api.github.com/repos/ehelms/forklift/deployments","created_at":"2014-01-23T03:58:16Z","updated_at":"2016-07-22T12:25:23Z","pushed_at":"2016-10-19T12:52:39Z","git_url":"git://github.com/ehelms/forklift.git","ssh_url":"git@github.com:ehelms/forklift.git","clone_url":"https://github.com/ehelms/forklift.git","svn_url":"https://github.com/ehelms/forklift","homepage":null,"size":503,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Katello:master","ref":"master","sha":"9cef0bb27f9c4906f2d7a5d4b05a59d9c98ab8c0","user":{"login":"Katello","id":1316386,"avatar_url":"https://avatars.githubusercontent.com/u/1316386?v=3","gravatar_id":"","url":"https://api.github.com/users/Katello","html_url":"https://github.com/Katello","followers_url":"https://api.github.com/users/Katello/followers","following_url":"https://api.github.com/users/Katello/following{/other_user}","gists_url":"https://api.github.com/users/Katello/gists{/gist_id}","starred_url":"https://api.github.com/users/Katello/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Katello/subscriptions","organizations_url":"https://api.github.com/users/Katello/orgs","repos_url":"https://api.github.com/users/Katello/repos","events_url":"https://api.github.com/users/Katello/events{/privacy}","received_events_url":"https://api.github.com/users/Katello/received_events","type":"Organization","site_admin":false},"repo":{"id":16148652,"name":"forklift","full_name":"Katello/forklift","owner":{"login":"Katello","id":1316386,"avatar_url":"https://avatars.githubusercontent.com/u/1316386?v=3","gravatar_id":"","url":"https://api.github.com/users/Katello","html_url":"https://github.com/Katello","followers_url":"https://api.github.com/users/Katello/followers","following_url":"https://api.github.com/users/Katello/following{/other_user}","gists_url":"https://api.github.com/users/Katello/gists{/gist_id}","starred_url":"https://api.github.com/users/Katello/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Katello/subscriptions","organizations_url":"https://api.github.com/users/Katello/orgs","repos_url":"https://api.github.com/users/Katello/repos","events_url":"https://api.github.com/users/Katello/events{/privacy}","received_events_url":"https://api.github.com/users/Katello/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Katello/forklift","description":"Helpful deployment scripts for Katello","fork":false,"url":"https://api.github.com/repos/Katello/forklift","forks_url":"https://api.github.com/repos/Katello/forklift/forks","keys_url":"https://api.github.com/repos/Katello/forklift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Katello/forklift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Katello/forklift/teams","hooks_url":"https://api.github.com/repos/Katello/forklift/hooks","issue_events_url":"https://api.github.com/repos/Katello/forklift/issues/events{/number}","events_url":"https://api.github.com/repos/Katello/forklift/events","assignees_url":"https://api.github.com/repos/Katello/forklift/assignees{/user}","branches_url":"https://api.github.com/repos/Katello/forklift/branches{/branch}","tags_url":"https://api.github.com/repos/Katello/forklift/tags","blobs_url":"https://api.github.com/repos/Katello/forklift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Katello/forklift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Katello/forklift/git/refs{/sha}","trees_url":"https://api.github.com/repos/Katello/forklift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Katello/forklift/statuses/{sha}","languages_url":"https://api.github.com/repos/Katello/forklift/languages","stargazers_url":"https://api.github.com/repos/Katello/forklift/stargazers","contributors_url":"https://api.github.com/repos/Katello/forklift/contributors","subscribers_url":"https://api.github.com/repos/Katello/forklift/subscribers","subscription_url":"https://api.github.com/repos/Katello/forklift/subscription","commits_url":"https://api.github.com/repos/Katello/forklift/commits{/sha}","git_commits_url":"https://api.github.com/repos/Katello/forklift/git/commits{/sha}","comments_url":"https://api.github.com/repos/Katello/forklift/comments{/number}","issue_comment_url":"https://api.github.com/repos/Katello/forklift/issues/comments{/number}","contents_url":"https://api.github.com/repos/Katello/forklift/contents/{+path}","compare_url":"https://api.github.com/repos/Katello/forklift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Katello/forklift/merges","archive_url":"https://api.github.com/repos/Katello/forklift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Katello/forklift/downloads","issues_url":"https://api.github.com/repos/Katello/forklift/issues{/number}","pulls_url":"https://api.github.com/repos/Katello/forklift/pulls{/number}","milestones_url":"https://api.github.com/repos/Katello/forklift/milestones{/number}","notifications_url":"https://api.github.com/repos/Katello/forklift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Katello/forklift/labels{/name}","releases_url":"https://api.github.com/repos/Katello/forklift/releases{/id}","deployments_url":"https://api.github.com/repos/Katello/forklift/deployments","created_at":"2014-01-22T18:44:49Z","updated_at":"2016-10-12T08:51:05Z","pushed_at":"2016-10-19T12:52:39Z","git_url":"git://github.com/Katello/forklift.git","ssh_url":"git@github.com:Katello/forklift.git","clone_url":"https://github.com/Katello/forklift.git","svn_url":"https://github.com/Katello/forklift","homepage":null,"size":572,"stargazers_count":35,"watchers_count":35,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":58,"mirror_url":null,"open_issues_count":21,"forks":58,"open_issues":21,"watchers":35,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Katello/forklift/pulls/323"},"html":{"href":"https://github.com/Katello/forklift/pull/323"},"issue":{"href":"https://api.github.com/repos/Katello/forklift/issues/323"},"comments":{"href":"https://api.github.com/repos/Katello/forklift/issues/323/comments"},"review_comments":{"href":"https://api.github.com/repos/Katello/forklift/pulls/323/comments"},"review_comment":{"href":"https://api.github.com/repos/Katello/forklift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Katello/forklift/pulls/323/commits"},"statuses":{"href":"https://api.github.com/repos/Katello/forklift/statuses/08c266baf32d8dc228a9fd3d5adbc728cd49e11f"}}}}
{"actor":{"display_login":"stbenjam"}}