{"action":"created","issue":{"url":"https://api.github.com/repos/pattern-lab/patternlab-php/issues/353","repository_url":"https://api.github.com/repos/pattern-lab/patternlab-php","labels_url":"https://api.github.com/repos/pattern-lab/patternlab-php/issues/353/labels{/name}","comments_url":"https://api.github.com/repos/pattern-lab/patternlab-php/issues/353/comments","events_url":"https://api.github.com/repos/pattern-lab/patternlab-php/issues/353/events","html_url":"https://github.com/pattern-lab/patternlab-php/issues/353","id":144937449,"number":353,"title":"Renumbering meta templates (header and footer) breaks PL","user":{"login":"MikeAHenry","id":8160875,"avatar_url":"https://avatars.githubusercontent.com/u/8160875?v=3","gravatar_id":"","url":"https://api.github.com/users/MikeAHenry","html_url":"https://github.com/MikeAHenry","followers_url":"https://api.github.com/users/MikeAHenry/followers","following_url":"https://api.github.com/users/MikeAHenry/following{/other_user}","gists_url":"https://api.github.com/users/MikeAHenry/gists{/gist_id}","starred_url":"https://api.github.com/users/MikeAHenry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikeAHenry/subscriptions","organizations_url":"https://api.github.com/users/MikeAHenry/orgs","repos_url":"https://api.github.com/users/MikeAHenry/repos","events_url":"https://api.github.com/users/MikeAHenry/events{/privacy}","received_events_url":"https://api.github.com/users/MikeAHenry/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/pattern-lab/patternlab-php/labels/wontfix","name":"wontfix","color":"ffffff"}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-03-31T15:39:43Z","updated_at":"2016-07-13T14:47:43Z","closed_at":"2016-07-13T14:47:43Z","body":"When I changed the names of the _00-header and _01-footer files to remove the numbering, they did not get inserted into the generated html files, and the Pattern Lab viewer stopped working.\r\n\r\nIt looks like maybe these lines are the culprit:\r\n```\r\n  $patternHeadPath    = __DIR__.$this->sp.\"00-atoms/00-meta/_00-head.mustache\";\r\n  $patternFootPath    = __DIR__.$this->sp.\"00-atoms/00-meta/_01-foot.mustache\";\r\n```\r\n(core/lib/PatternLab/Builder.php:975-976)\r\n\r\nIs there a reason these are hard-coded values? (i.e., should we refrain from renaming or renumbering the files and atom directory?)"},"comment":{"url":"https://api.github.com/repos/pattern-lab/patternlab-php/issues/comments/232378729","html_url":"https://github.com/pattern-lab/patternlab-php/issues/353#issuecomment-232378729","issue_url":"https://api.github.com/repos/pattern-lab/patternlab-php/issues/353","id":232378729,"user":{"login":"dmolsen","id":2746,"avatar_url":"https://avatars.githubusercontent.com/u/2746?v=3","gravatar_id":"","url":"https://api.github.com/users/dmolsen","html_url":"https://github.com/dmolsen","followers_url":"https://api.github.com/users/dmolsen/followers","following_url":"https://api.github.com/users/dmolsen/following{/other_user}","gists_url":"https://api.github.com/users/dmolsen/gists{/gist_id}","starred_url":"https://api.github.com/users/dmolsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmolsen/subscriptions","organizations_url":"https://api.github.com/users/dmolsen/orgs","repos_url":"https://api.github.com/users/dmolsen/repos","events_url":"https://api.github.com/users/dmolsen/events{/privacy}","received_events_url":"https://api.github.com/users/dmolsen/received_events","type":"User","site_admin":false},"created_at":"2016-07-13T14:47:43Z","updated_at":"2016-07-13T14:47:43Z","body":"@MikeAHenry -\r\n\r\nThis has been addressed in PL2. It won't be fixed in PL1. And the reason is that it was a dumb design decision on my part."}}
{"actor":{"display_login":"dmolsen"}}