{"push_id":1423330762,"size":13,"distinct_size":3,"ref":"refs/heads/assignment-warning","head":"274fbe7de1f0ac3e945e11678ce0b5998ed8e1ce","before":"3c82cb8f8330ba37de1ab2e83d7281e0c194ca5c","commits":[{"sha":"66c3343af5bda04494c3a7f44f6801dc375958f2","author":{"name":"Brett V. Forsgren","email":"5e6719fb067d6d6588c37c966f26167cfc1b117d@microsoft.com"},"message":"add F5 instructions (#1823)","distinct":false,"url":"https://api.github.com/repos/forki/visualfsharp/commits/66c3343af5bda04494c3a7f44f6801dc375958f2"},{"sha":"820af622c09067bc30e419af5a1f21ccf96e65a2","author":{"name":"Don Syme","email":"dcc6d6120f0d7045d31da1f6813701b7289a905f@users.noreply.github.com"},"message":"Fix some underlying causes of long UI blocks in new LS implementation (#1819)\n\nFixes underlying issues associated with https://github.com/Microsoft/visualfsharp/issues/1815\r\n\r\nAfter getting a 15+ second UI block in VS 2017, I've done a complete review of the way the new LanguageService implementation is using FSharp.Compiler.Service (the DLL internally called FSharp.Compiler.LanguageService in the Visual F# Tools repo, but it's basically the same component as FCS)\r\n\r\nIn short, the new LS implementation expects FCS to honour cancellation of submitted tasks in a more timely way.  This PR greatly improves the cancellability of FCS requests, which was one of the underlying causes of such a long UI block.\r\n\r\n1. Improve FCS so that it respects cancellation in a more timely way.  Cancellation will now be respected at each step of the evaluation of the incremental build graph (IncrementalBuild.fs). This represents a fundamental improvement to FCS which will be very useful to other F# editors as well, as long as they are cancelling tasks.\r\n\r\n   In particular, some FCS requests could be _very_ long running, e.g. CheckFileInProject may require checking **all** the files prior to this file (and if cross-F#-to-F#-project checking is enabled then it will  require checking all the dependent projects too).  \r\n\r\n   Prior to this PR FCS was not respecting cancellation of these requests, and was simply running them through and then throwing the results away.\r\n\r\n2. The new LS implementation was using some unnecessary calls to Async.RunSynchronously.  All of these could inject arbitrary non-responsiveness into some part of the causality chains.  I've removed these in favour of fully async code.\r\n\r\n3. In FCS the old IsResultObsolete logic can be removed in favour of checking a cancellation token\r\n\r\nThis also fixes https://github.com/Microsoft/visualfsharp/issues/1756, see [this change here](https://github.com/Microsoft/visualfsharp/pull/1819/files#diff-69fa840cd1c6d144d0cd489cad82e901R88)\r\n\r\nWe have a separate issue that too may errors/warnings are shown for out-of-project files - the old LS implementation showed the first 3 errors - a good choice which we decided on long ago.  I'll add an issue for that.","distinct":false,"url":"https://api.github.com/repos/forki/visualfsharp/commits/820af622c09067bc30e419af5a1f21ccf96e65a2"},{"sha":"3fbc1332fb66ce1cb0d427ec2330b800acf673ba","author":{"name":"Brett V. Forsgren","email":"5e6719fb067d6d6588c37c966f26167cfc1b117d@microsoft.com"},"message":"update project options cache when files are added/removed (#1813)","distinct":false,"url":"https://api.github.com/repos/forki/visualfsharp/commits/3fbc1332fb66ce1cb0d427ec2330b800acf673ba"},{"sha":"adff559036f5e63ef385867cdf20375f3e58c0e1","author":{"name":"Steffen Forkmann","email":"73e4e81da72594ca119e43d5808fcc41f1abc2bf@gmail.com"},"message":"Fix [<RequireQualifiedAccess>] on a DU shadows types in the same module (#1512)\n\n* Reproduce #1253\r\n\r\n* Union resolution should not stop other searches\r\n\r\n* reproduce #1294\r\n\r\n* fix #1294\r\n\r\n* Show that constructor syntax still works\r\n\r\n* Fix shortcut\r\n\r\n* Fix shortcut\r\n\r\n* Adding further tests\r\n\r\n* Search for a discriminated union without RequireQualifiedAccess attribute\r\n\r\n* Don't run union search twice\r\n\r\n* Simplify code\r\n\r\n* Fix encoding  issue","distinct":false,"url":"https://api.github.com/repos/forki/visualfsharp/commits/adff559036f5e63ef385867cdf20375f3e58c0e1"},{"sha":"41cc6afa3520704aff018825b7167bb0c128fb82","author":{"name":"Steffen Forkmann","email":"73e4e81da72594ca119e43d5808fcc41f1abc2bf@gmail.com"},"message":"Fixing #1644 (#1818)\n\n* try to reproduce #1644\r\n\r\n* Fix #1644","distinct":false,"url":"https://api.github.com/repos/forki/visualfsharp/commits/41cc6afa3520704aff018825b7167bb0c128fb82"},{"sha":"bfe4086c0fda8b49aff22fce7dd0a530c11193e5","author":{"name":"Don Syme","email":"dcc6d6120f0d7045d31da1f6813701b7289a905f@users.noreply.github.com"},"message":"Fix colorization speed in large files (#1829)\n\nFixes #1821\r\n\r\nIncremental colorization was not being effective on changing files for a number of reasons\r\n•Data cache was keyed by source text rather than document ID\r\n•We were writing None entries right through to end-of-file even when we could stop earlier\r\n•We weren't checking that start-of-line indexes and lex states were still the same when reusing entries\r\n•Tokenizers getting recreated for each line - we can cache these as well.\r\n\r\nI've tried the PR out on large files and it works much more efficiently.\r\n\r\nAlso a fix to make  ShouldTriggerCompletionAux  faster in the common case where not pressing  . \r\n\r\nThis also fixes glyphs: #1806. Public/private/protected is not yet propagated to the glyph but this gives us feature parity with VS2015","distinct":false,"url":"https://api.github.com/repos/forki/visualfsharp/commits/bfe4086c0fda8b49aff22fce7dd0a530c11193e5"},{"sha":"74c986977121ea00320ce63f59e4bcc3a5d1c0ed","author":{"name":"Don Syme","email":"dcc6d6120f0d7045d31da1f6813701b7289a905f@users.noreply.github.com"},"message":"fixes for type providers (#1831)\n\nFix type providers on VS2017 RC.","distinct":false,"url":"https://api.github.com/repos/forki/visualfsharp/commits/74c986977121ea00320ce63f59e4bcc3a5d1c0ed"},{"sha":"8e0e0da64a3dc6922f98b82c07b263c471a9479e","author":{"name":"Vasily Kirichenko","email":"25af4c6c82e1f3d7a4affe3be5f7d45339cc81e9@gmail.com"},"message":"CommentUncommentService (#1832)","distinct":false,"url":"https://api.github.com/repos/forki/visualfsharp/commits/8e0e0da64a3dc6922f98b82c07b263c471a9479e"},{"sha":"a6e900eda649ef97762193768991d879ff0c9e88","author":{"name":"Steffen Forkmann","email":"73e4e81da72594ca119e43d5808fcc41f1abc2bf@gmail.com"},"message":"Don't suggest types that are not accessible (#1552)\n\n* Repro case for #1548\r\n\r\n* Fixes suggestions in #1548","distinct":false,"url":"https://api.github.com/repos/forki/visualfsharp/commits/a6e900eda649ef97762193768991d879ff0c9e88"},{"sha":"2f5851a1db3749dcf561e9d1f6afe72f27490a4a","author":{"name":"Kurt Schelfthout","email":"e17d78dfb27c2930a51f1de396580d3f1fa5443c@gmail.com"},"message":"Implement RFC fs-1025:  Improve record inference. (#1771)","distinct":false,"url":"https://api.github.com/repos/forki/visualfsharp/commits/2f5851a1db3749dcf561e9d1f6afe72f27490a4a"},{"sha":"403fc0cc19d1f2111eaa8e9fb2e9df23331385cf","author":{"name":"Steffen Forkmann","email":"73e4e81da72594ca119e43d5808fcc41f1abc2bf@gmail.com"},"message":"Add type info to error - references #1574 (#1834)\n\n* Add type info to error - references #1574\r\n\r\n* Add type info to FS0314\r\n\r\n* Add type info to more SignatureConformance errors","distinct":true,"url":"https://api.github.com/repos/forki/visualfsharp/commits/403fc0cc19d1f2111eaa8e9fb2e9df23331385cf"},{"sha":"beef0896b3f923de96ad6965bf7d531d03bb5c79","author":{"name":"Kevin Ransom (msft)","email":"94a8832b483662cc21132debaba90bf25b32fd74@hotmail.com"},"message":"Modify build to include fsharp compiler dependencies in vsix'.  Enables OSS build FSI to run. (#1833)","distinct":true,"url":"https://api.github.com/repos/forki/visualfsharp/commits/beef0896b3f923de96ad6965bf7d531d03bb5c79"},{"sha":"274fbe7de1f0ac3e945e11678ce0b5998ed8e1ce","author":{"name":"Steffen Forkmann","email":"a40dbea1e549931a45a76e318003f628cf59eccf@msu-solutions.de"},"message":"Emit special warning when = is used and user might want to use <-","distinct":true,"url":"https://api.github.com/repos/forki/visualfsharp/commits/274fbe7de1f0ac3e945e11678ce0b5998ed8e1ce"}]}
{"actor":{"display_login":"forki"}}