{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/54658542","id":54658542,"diff_hunk":"@@ -267,8 +262,10 @@ RemoveDirectoryW(\n         goto done;\n     }\n \n-    length = (PAL_wcslen(lpPathName)+1) * 3;\n+    length = WideCharToMultiByte( CP_ACP, 0, lpPathName, -1, NULL, 0,\n+                                   NULL, NULL );","path":"src/pal/src/file/directory.cpp","position":72,"original_position":72,"commit_id":"02c629c18046413be0cedca95954407ae73968c6","original_commit_id":"02c629c18046413be0cedca95954407ae73968c6","user":{"login":"janvorli","id":10758568,"avatar_url":"https://avatars.githubusercontent.com/u/10758568?v=3","gravatar_id":"","url":"https://api.github.com/users/janvorli","html_url":"https://github.com/janvorli","followers_url":"https://api.github.com/users/janvorli/followers","following_url":"https://api.github.com/users/janvorli/following{/other_user}","gists_url":"https://api.github.com/users/janvorli/gists{/gist_id}","starred_url":"https://api.github.com/users/janvorli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janvorli/subscriptions","organizations_url":"https://api.github.com/users/janvorli/orgs","repos_url":"https://api.github.com/users/janvorli/repos","events_url":"https://api.github.com/users/janvorli/events{/privacy}","received_events_url":"https://api.github.com/users/janvorli/received_events","type":"User","site_admin":false},"body":"+1","created_at":"2016-03-02T00:05:18Z","updated_at":"2016-03-02T00:05:18Z","html_url":"https://github.com/dotnet/coreclr/pull/3441#discussion_r54658542","pull_request_url":"https://api.github.com/repos/dotnet/coreclr/pulls/3441","_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/54658542"},"html":{"href":"https://github.com/dotnet/coreclr/pull/3441#discussion_r54658542"},"pull_request":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/3441"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/3441","id":61202370,"html_url":"https://github.com/dotnet/coreclr/pull/3441","diff_url":"https://github.com/dotnet/coreclr/pull/3441.diff","patch_url":"https://github.com/dotnet/coreclr/pull/3441.patch","issue_url":"https://api.github.com/repos/dotnet/coreclr/issues/3441","number":3441,"state":"open","locked":false,"title":"Enabling LongFile Support in PAL","user":{"login":"ramarag","id":10203266,"avatar_url":"https://avatars.githubusercontent.com/u/10203266?v=3","gravatar_id":"","url":"https://api.github.com/users/ramarag","html_url":"https://github.com/ramarag","followers_url":"https://api.github.com/users/ramarag/followers","following_url":"https://api.github.com/users/ramarag/following{/other_user}","gists_url":"https://api.github.com/users/ramarag/gists{/gist_id}","starred_url":"https://api.github.com/users/ramarag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ramarag/subscriptions","organizations_url":"https://api.github.com/users/ramarag/orgs","repos_url":"https://api.github.com/users/ramarag/repos","events_url":"https://api.github.com/users/ramarag/events{/privacy}","received_events_url":"https://api.github.com/users/ramarag/received_events","type":"User","site_admin":false},"body":"This change enables the PAL to support Long file names.\r\n\r\n1. The Ansi version of the APIs have been moved out of pal.h , they are still consumable from palprivate.h\r\n\r\n2.  Ansi Version of The Apis no longer return the Windows style error if the Path is longer than MAX_PATH/MAX_LONGPATH\r\n\r\n3.  GetTempFileName still has a dependency on MAX_PATH/MAX_LONGPATH as there is no way for the caller to tell the API the length of the buffer they are passing in\r\n\r\n@JohnChen0 @gkhanna79 @JeremyKuhne  @janvorli @jkotas  PTAL","created_at":"2016-03-01T07:13:52Z","updated_at":"2016-03-02T00:05:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"933e6541afebfa241e9df08329cfeb0a94e00218","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/coreclr/pulls/3441/commits","review_comments_url":"https://api.github.com/repos/dotnet/coreclr/pulls/3441/comments","review_comment_url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/coreclr/issues/3441/comments","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/02c629c18046413be0cedca95954407ae73968c6","head":{"label":"ramarag:pal_longfile","ref":"pal_longfile","sha":"02c629c18046413be0cedca95954407ae73968c6","user":{"login":"ramarag","id":10203266,"avatar_url":"https://avatars.githubusercontent.com/u/10203266?v=3","gravatar_id":"","url":"https://api.github.com/users/ramarag","html_url":"https://github.com/ramarag","followers_url":"https://api.github.com/users/ramarag/followers","following_url":"https://api.github.com/users/ramarag/following{/other_user}","gists_url":"https://api.github.com/users/ramarag/gists{/gist_id}","starred_url":"https://api.github.com/users/ramarag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ramarag/subscriptions","organizations_url":"https://api.github.com/users/ramarag/orgs","repos_url":"https://api.github.com/users/ramarag/repos","events_url":"https://api.github.com/users/ramarag/events{/privacy}","received_events_url":"https://api.github.com/users/ramarag/received_events","type":"User","site_admin":false},"repo":{"id":30266414,"name":"coreclr","full_name":"ramarag/coreclr","owner":{"login":"ramarag","id":10203266,"avatar_url":"https://avatars.githubusercontent.com/u/10203266?v=3","gravatar_id":"","url":"https://api.github.com/users/ramarag","html_url":"https://github.com/ramarag","followers_url":"https://api.github.com/users/ramarag/followers","following_url":"https://api.github.com/users/ramarag/following{/other_user}","gists_url":"https://api.github.com/users/ramarag/gists{/gist_id}","starred_url":"https://api.github.com/users/ramarag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ramarag/subscriptions","organizations_url":"https://api.github.com/users/ramarag/orgs","repos_url":"https://api.github.com/users/ramarag/repos","events_url":"https://api.github.com/users/ramarag/events{/privacy}","received_events_url":"https://api.github.com/users/ramarag/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ramarag/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR. It is an execution engine for .NET apps, performing functions such as IL byte code loading, compilation to machine code and garbage collection. The repo contains the complete up-to-date CoreCLR codebase.","fork":true,"url":"https://api.github.com/repos/ramarag/coreclr","forks_url":"https://api.github.com/repos/ramarag/coreclr/forks","keys_url":"https://api.github.com/repos/ramarag/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ramarag/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ramarag/coreclr/teams","hooks_url":"https://api.github.com/repos/ramarag/coreclr/hooks","issue_events_url":"https://api.github.com/repos/ramarag/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/ramarag/coreclr/events","assignees_url":"https://api.github.com/repos/ramarag/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/ramarag/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/ramarag/coreclr/tags","blobs_url":"https://api.github.com/repos/ramarag/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ramarag/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ramarag/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/ramarag/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ramarag/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/ramarag/coreclr/languages","stargazers_url":"https://api.github.com/repos/ramarag/coreclr/stargazers","contributors_url":"https://api.github.com/repos/ramarag/coreclr/contributors","subscribers_url":"https://api.github.com/repos/ramarag/coreclr/subscribers","subscription_url":"https://api.github.com/repos/ramarag/coreclr/subscription","commits_url":"https://api.github.com/repos/ramarag/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/ramarag/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/ramarag/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/ramarag/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/ramarag/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/ramarag/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ramarag/coreclr/merges","archive_url":"https://api.github.com/repos/ramarag/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ramarag/coreclr/downloads","issues_url":"https://api.github.com/repos/ramarag/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/ramarag/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/ramarag/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/ramarag/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ramarag/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/ramarag/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/ramarag/coreclr/deployments","created_at":"2015-02-03T21:50:27Z","updated_at":"2016-01-20T22:31:20Z","pushed_at":"2016-03-01T07:23:10Z","git_url":"git://github.com/ramarag/coreclr.git","ssh_url":"git@github.com:ramarag/coreclr.git","clone_url":"https://github.com/ramarag/coreclr.git","svn_url":"https://github.com/ramarag/coreclr","homepage":"","size":62349,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"444ca211c12c1f424acc1fa275272f284dcccb75","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":30092893,"name":"coreclr","full_name":"dotnet/coreclr","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called mscorlib. It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes.","fork":false,"url":"https://api.github.com/repos/dotnet/coreclr","forks_url":"https://api.github.com/repos/dotnet/coreclr/forks","keys_url":"https://api.github.com/repos/dotnet/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/coreclr/teams","hooks_url":"https://api.github.com/repos/dotnet/coreclr/hooks","issue_events_url":"https://api.github.com/repos/dotnet/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/coreclr/events","assignees_url":"https://api.github.com/repos/dotnet/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/coreclr/tags","blobs_url":"https://api.github.com/repos/dotnet/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/coreclr/languages","stargazers_url":"https://api.github.com/repos/dotnet/coreclr/stargazers","contributors_url":"https://api.github.com/repos/dotnet/coreclr/contributors","subscribers_url":"https://api.github.com/repos/dotnet/coreclr/subscribers","subscription_url":"https://api.github.com/repos/dotnet/coreclr/subscription","commits_url":"https://api.github.com/repos/dotnet/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/coreclr/merges","archive_url":"https://api.github.com/repos/dotnet/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/coreclr/downloads","issues_url":"https://api.github.com/repos/dotnet/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/coreclr/deployments","created_at":"2015-01-30T22:10:02Z","updated_at":"2016-03-01T16:02:49Z","pushed_at":"2016-03-01T23:53:57Z","git_url":"git://github.com/dotnet/coreclr.git","ssh_url":"git@github.com:dotnet/coreclr.git","clone_url":"https://github.com/dotnet/coreclr.git","svn_url":"https://github.com/dotnet/coreclr","homepage":"http://dotnet.github.io/","size":68661,"stargazers_count":5955,"watchers_count":5955,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1316,"mirror_url":null,"open_issues_count":573,"forks":1316,"open_issues":573,"watchers":5955,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/3441"},"html":{"href":"https://github.com/dotnet/coreclr/pull/3441"},"issue":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/3441"},"comments":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/3441/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/3441/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/3441/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/coreclr/statuses/02c629c18046413be0cedca95954407ae73968c6"}}}}