{"action":"created","issue":{"url":"https://api.github.com/repos/opensim-org/opensim-core/issues/1005","repository_url":"https://api.github.com/repos/opensim-org/opensim-core","labels_url":"https://api.github.com/repos/opensim-org/opensim-core/issues/1005/labels{/name}","comments_url":"https://api.github.com/repos/opensim-org/opensim-core/issues/1005/comments","events_url":"https://api.github.com/repos/opensim-org/opensim-core/issues/1005/events","html_url":"https://github.com/opensim-org/opensim-core/pull/1005","id":160239816,"number":1005,"title":"Geometry 4 wrap objects","user":{"login":"aymanhab","id":3972208,"avatar_url":"https://avatars.githubusercontent.com/u/3972208?v=3","gravatar_id":"","url":"https://api.github.com/users/aymanhab","html_url":"https://github.com/aymanhab","followers_url":"https://api.github.com/users/aymanhab/followers","following_url":"https://api.github.com/users/aymanhab/following{/other_user}","gists_url":"https://api.github.com/users/aymanhab/gists{/gist_id}","starred_url":"https://api.github.com/users/aymanhab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aymanhab/subscriptions","organizations_url":"https://api.github.com/users/aymanhab/orgs","repos_url":"https://api.github.com/users/aymanhab/repos","events_url":"https://api.github.com/users/aymanhab/events{/privacy}","received_events_url":"https://api.github.com/users/aymanhab/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":24,"created_at":"2016-06-14T17:35:23Z","updated_at":"2016-06-17T21:19:12Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/opensim-org/opensim-core/pulls/1005","html_url":"https://github.com/opensim-org/opensim-core/pull/1005","diff_url":"https://github.com/opensim-org/opensim-core/pull/1005.diff","patch_url":"https://github.com/opensim-org/opensim-core/pull/1005.patch"},"body":"This PR is basically a refactoring /no-op to move custom visualization code from ModelVisualiser to proper generateDecorations methods of classes (Wrap{Sphere, Cylinder,Ellipsoid} and ContactSphere). WrapTorus was never implemented so an exception/place holder is introduced and thrown. With this we can test if WrapObject(s) and ContactSpheres show up in the GUI/Visualizer. Later PRs will address:\r\n- Parts of Analytical shapes (Quadrants etc. that were not handled in the past).\r\n- WrapTorus\r\n- ContactHalfSpace\r\n- ContactMesh.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"35\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/opensim-org/opensim-core/1005)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/opensim-org/opensim-core/issues/comments/226884138","html_url":"https://github.com/opensim-org/opensim-core/pull/1005#issuecomment-226884138","issue_url":"https://api.github.com/repos/opensim-org/opensim-core/issues/1005","id":226884138,"user":{"login":"aymanhab","id":3972208,"avatar_url":"https://avatars.githubusercontent.com/u/3972208?v=3","gravatar_id":"","url":"https://api.github.com/users/aymanhab","html_url":"https://github.com/aymanhab","followers_url":"https://api.github.com/users/aymanhab/followers","following_url":"https://api.github.com/users/aymanhab/following{/other_user}","gists_url":"https://api.github.com/users/aymanhab/gists{/gist_id}","starred_url":"https://api.github.com/users/aymanhab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aymanhab/subscriptions","organizations_url":"https://api.github.com/users/aymanhab/orgs","repos_url":"https://api.github.com/users/aymanhab/repos","events_url":"https://api.github.com/users/aymanhab/events{/privacy}","received_events_url":"https://api.github.com/users/aymanhab/received_events","type":"User","site_admin":false},"created_at":"2016-06-17T21:19:12Z","updated_at":"2016-06-17T21:19:12Z","body":"Tests pass minus bogus failure in testComponents."}}
{"actor":{"display_login":"aymanhab"}}