{"action":"created","comment":{"url":"https://api.github.com/repos/FujitsuEnablingSoftwareTechnologyGmbH/kubernetes/pulls/comments/61992961","id":61992961,"diff_hunk":"@@ -35,8 +35,8 @@ MINION_FLAVOR=${MINION_FLAVOR:-m1.medium}\n \n EXTERNAL_NETWORK=${EXTERNAL_NETWORK:-public}\n \n-#FIXME This can get set by evaulating the output of `swift auth` and stripping the base URL from OS_STORAGE_URL, but will require a refactor. Till then...\n-SWIFT_SERVER_URL=${SWIFT_SERVER_URL:-http://192.168.123.100:8080}\n+SWIFT_SERVER_URL_DEFAULT=$(openstack catalog show object-store --format value | egrep -o \"publicURL: (.+)$\" | cut -d\" \" -f2)","path":"cluster/openstack-heat/config-default.sh","position":6,"original_position":6,"commit_id":"75fff6702fe6bd411e7f6dec7639c7e6b196cbb4","original_commit_id":"75fff6702fe6bd411e7f6dec7639c7e6b196cbb4","user":{"login":"zreigz","id":13030040,"avatar_url":"https://avatars.githubusercontent.com/u/13030040?v=3","gravatar_id":"","url":"https://api.github.com/users/zreigz","html_url":"https://github.com/zreigz","followers_url":"https://api.github.com/users/zreigz/followers","following_url":"https://api.github.com/users/zreigz/following{/other_user}","gists_url":"https://api.github.com/users/zreigz/gists{/gist_id}","starred_url":"https://api.github.com/users/zreigz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zreigz/subscriptions","organizations_url":"https://api.github.com/users/zreigz/orgs","repos_url":"https://api.github.com/users/zreigz/repos","events_url":"https://api.github.com/users/zreigz/events{/privacy}","received_events_url":"https://api.github.com/users/zreigz/received_events","type":"User","site_admin":false},"body":"This shouldn't be here. This is configuration file with some defaults values. Openstack client won't work here because sourcing openrc-default.sh is done in util.sh.\r\nI suggest move this line to util.sh","created_at":"2016-05-04T06:04:31Z","updated_at":"2016-05-04T06:04:31Z","html_url":"https://github.com/FujitsuEnablingSoftwareTechnologyGmbH/kubernetes/pull/12#discussion_r61992961","pull_request_url":"https://api.github.com/repos/FujitsuEnablingSoftwareTechnologyGmbH/kubernetes/pulls/12","_links":{"self":{"href":"https://api.github.com/repos/FujitsuEnablingSoftwareTechnologyGmbH/kubernetes/pulls/comments/61992961"},"html":{"href":"https://github.com/FujitsuEnablingSoftwareTechnologyGmbH/kubernetes/pull/12#discussion_r61992961"},"pull_request":{"href":"https://api.github.com/repos/FujitsuEnablingSoftwareTechnologyGmbH/kubernetes/pulls/12"}}},"pull_request":{"url":"https://api.github.com/repos/FujitsuEnablingSoftwareTechnologyGmbH/kubernetes/pulls/12","id":68506159,"html_url":"https://github.com/FujitsuEnablingSoftwareTechnologyGmbH/kubernetes/pull/12","diff_url":"https://github.com/FujitsuEnablingSoftwareTechnologyGmbH/kubernetes/pull/12.diff","patch_url":"https://github.com/FujitsuEnablingSoftwareTechnologyGmbH/kubernetes/pull/12.patch","issue_url":"https://api.github.com/repos/FujitsuEnablingSoftwareTechnologyGmbH/kubernetes/issues/12","number":12,"state":"open","locked":false,"title":"Automatically detect swift URL","user":{"login":"ctrlaltdel","id":8973,"avatar_url":"https://avatars.githubusercontent.com/u/8973?v=3","gravatar_id":"","url":"https://api.github.com/users/ctrlaltdel","html_url":"https://github.com/ctrlaltdel","followers_url":"https://api.github.com/users/ctrlaltdel/followers","following_url":"https://api.github.com/users/ctrlaltdel/following{/other_user}","gists_url":"https://api.github.com/users/ctrlaltdel/gists{/gist_id}","starred_url":"https://api.github.com/users/ctrlaltdel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ctrlaltdel/subscriptions","organizations_url":"https://api.github.com/users/ctrlaltdel/orgs","repos_url":"https://api.github.com/users/ctrlaltdel/repos","events_url":"https://api.github.com/users/ctrlaltdel/events{/privacy}","received_events_url":"https://api.github.com/users/ctrlaltdel/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-05-01T20:22:54Z","updated_at":"2016-05-04T06:04:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"927b14e1e6a95702e4785425bdd8fa3246f8d2dc","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/FujitsuEnablingSoftwareTechnologyGmbH/kubernetes/pulls/12/commits","review_comments_url":"https://api.github.com/repos/FujitsuEnablingSoftwareTechnologyGmbH/kubernetes/pulls/12/comments","review_comment_url":"https://api.github.com/repos/FujitsuEnablingSoftwareTechnologyGmbH/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/FujitsuEnablingSoftwareTechnologyGmbH/kubernetes/issues/12/comments","statuses_url":"https://api.github.com/repos/FujitsuEnablingSoftwareTechnologyGmbH/kubernetes/statuses/75fff6702fe6bd411e7f6dec7639c7e6b196cbb4","head":{"label":"ctrlaltdel:openstack-provider-swift-url","ref":"openstack-provider-swift-url","sha":"75fff6702fe6bd411e7f6dec7639c7e6b196cbb4","user":{"login":"ctrlaltdel","id":8973,"avatar_url":"https://avatars.githubusercontent.com/u/8973?v=3","gravatar_id":"","url":"https://api.github.com/users/ctrlaltdel","html_url":"https://github.com/ctrlaltdel","followers_url":"https://api.github.com/users/ctrlaltdel/followers","following_url":"https://api.github.com/users/ctrlaltdel/following{/other_user}","gists_url":"https://api.github.com/users/ctrlaltdel/gists{/gist_id}","starred_url":"https://api.github.com/users/ctrlaltdel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ctrlaltdel/subscriptions","organizations_url":"https://api.github.com/users/ctrlaltdel/orgs","repos_url":"https://api.github.com/users/ctrlaltdel/repos","events_url":"https://api.github.com/users/ctrlaltdel/events{/privacy}","received_events_url":"https://api.github.com/users/ctrlaltdel/received_events","type":"User","site_admin":false},"repo":{"id":46718971,"name":"kubernetes","full_name":"ctrlaltdel/kubernetes","owner":{"login":"ctrlaltdel","id":8973,"avatar_url":"https://avatars.githubusercontent.com/u/8973?v=3","gravatar_id":"","url":"https://api.github.com/users/ctrlaltdel","html_url":"https://github.com/ctrlaltdel","followers_url":"https://api.github.com/users/ctrlaltdel/followers","following_url":"https://api.github.com/users/ctrlaltdel/following{/other_user}","gists_url":"https://api.github.com/users/ctrlaltdel/gists{/gist_id}","starred_url":"https://api.github.com/users/ctrlaltdel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ctrlaltdel/subscriptions","organizations_url":"https://api.github.com/users/ctrlaltdel/orgs","repos_url":"https://api.github.com/users/ctrlaltdel/repos","events_url":"https://api.github.com/users/ctrlaltdel/events{/privacy}","received_events_url":"https://api.github.com/users/ctrlaltdel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ctrlaltdel/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/ctrlaltdel/kubernetes","forks_url":"https://api.github.com/repos/ctrlaltdel/kubernetes/forks","keys_url":"https://api.github.com/repos/ctrlaltdel/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ctrlaltdel/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ctrlaltdel/kubernetes/teams","hooks_url":"https://api.github.com/repos/ctrlaltdel/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/ctrlaltdel/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/ctrlaltdel/kubernetes/events","assignees_url":"https://api.github.com/repos/ctrlaltdel/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/ctrlaltdel/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/ctrlaltdel/kubernetes/tags","blobs_url":"https://api.github.com/repos/ctrlaltdel/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ctrlaltdel/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ctrlaltdel/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/ctrlaltdel/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ctrlaltdel/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/ctrlaltdel/kubernetes/languages","stargazers_url":"https://api.github.com/repos/ctrlaltdel/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/ctrlaltdel/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/ctrlaltdel/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/ctrlaltdel/kubernetes/subscription","commits_url":"https://api.github.com/repos/ctrlaltdel/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/ctrlaltdel/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/ctrlaltdel/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/ctrlaltdel/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/ctrlaltdel/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/ctrlaltdel/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ctrlaltdel/kubernetes/merges","archive_url":"https://api.github.com/repos/ctrlaltdel/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ctrlaltdel/kubernetes/downloads","issues_url":"https://api.github.com/repos/ctrlaltdel/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/ctrlaltdel/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/ctrlaltdel/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/ctrlaltdel/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ctrlaltdel/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/ctrlaltdel/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/ctrlaltdel/kubernetes/deployments","created_at":"2015-11-23T12:32:12Z","updated_at":"2015-11-23T12:32:56Z","pushed_at":"2016-05-01T20:18:00Z","git_url":"git://github.com/ctrlaltdel/kubernetes.git","ssh_url":"git@github.com:ctrlaltdel/kubernetes.git","clone_url":"https://github.com/ctrlaltdel/kubernetes.git","svn_url":"https://github.com/ctrlaltdel/kubernetes","homepage":"http://kubernetes.io","size":186783,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"FujitsuEnablingSoftwareTechnologyGmbH:openstack-provider","ref":"openstack-provider","sha":"53eef9e412b3f702eb4e25f61f2458fcfdbb2d4e","user":{"login":"FujitsuEnablingSoftwareTechnologyGmbH","id":12654358,"avatar_url":"https://avatars.githubusercontent.com/u/12654358?v=3","gravatar_id":"","url":"https://api.github.com/users/FujitsuEnablingSoftwareTechnologyGmbH","html_url":"https://github.com/FujitsuEnablingSoftwareTechnologyGmbH","followers_url":"https://api.github.com/users/FujitsuEnablingSoftwareTechnologyGmbH/followers","following_url":"https://api.github.com/users/FujitsuEnablingSoftwareTechnologyGmbH/following{/other_user}","gists_url":"https://api.github.com/users/FujitsuEnablingSoftwareTechnologyGmbH/gists{/gist_id}","starred_url":"https://api.github.com/users/FujitsuEnablingSoftwareTechnologyGmbH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FujitsuEnablingSoftwareTechnologyGmbH/subscriptions","organizations_url":"https://api.github.com/users/FujitsuEnablingSoftwareTechnologyGmbH/orgs","repos_url":"https://api.github.com/users/FujitsuEnablingSoftwareTechnologyGmbH/repos","events_url":"https://api.github.com/users/FujitsuEnablingSoftwareTechnologyGmbH/events{/privacy}","received_events_url":"https://api.github.com/users/FujitsuEnablingSoftwareTechnologyGmbH/received_events","type":"Organization","site_admin":false},"repo":{"id":51141294,"name":"kubernetes","full_name":"FujitsuEnablingSoftwareTechnologyGmbH/kubernetes","owner":{"login":"FujitsuEnablingSoftwareTechnologyGmbH","id":12654358,"avatar_url":"https://avatars.githubusercontent.com/u/12654358?v=3","gravatar_id":"","url":"https://api.github.com/users/FujitsuEnablingSoftwareTechnologyGmbH","html_url":"https://github.com/FujitsuEnablingSoftwareTechnologyGmbH","followers_url":"https://api.github.com/users/FujitsuEnablingSoftwareTechnologyGmbH/followers","following_url":"https://api.github.com/users/FujitsuEnablingSoftwareTechnologyGmbH/following{/other_user}","gists_url":"https://api.github.com/users/FujitsuEnablingSoftwareTechnologyGmbH/gists{/gist_id}","starred_url":"https://api.github.com/users/FujitsuEnablingSoftwareTechnologyGmbH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FujitsuEnablingSoftwareTechnologyGmbH/subscriptions","organizations_url":"https://api.github.com/users/FujitsuEnablingSoftwareTechnologyGmbH/orgs","repos_url":"https://api.github.com/users/FujitsuEnablingSoftwareTechnologyGmbH/repos","events_url":"https://api.github.com/users/FujitsuEnablingSoftwareTechnologyGmbH/events{/privacy}","received_events_url":"https://api.github.com/users/FujitsuEnablingSoftwareTechnologyGmbH/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/FujitsuEnablingSoftwareTechnologyGmbH/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/FujitsuEnablingSoftwareTechnologyGmbH/kubernetes","forks_url":"https://api.github.com/repos/FujitsuEnablingSoftwareTechnologyGmbH/kubernetes/forks","keys_url":"https://api.github.com/repos/FujitsuEnablingSoftwareTechnologyGmbH/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FujitsuEnablingSoftwareTechnologyGmbH/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FujitsuEnablingSoftwareTechnologyGmbH/kubernetes/teams","hooks_url":"https://api.github.com/repos/FujitsuEnablingSoftwareTechnologyGmbH/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/FujitsuEnablingSoftwareTechnologyGmbH/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/FujitsuEnablingSoftwareTechnologyGmbH/kubernetes/events","assignees_url":"https://api.github.com/repos/FujitsuEnablingSoftwareTechnologyGmbH/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/FujitsuEnablingSoftwareTechnologyGmbH/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/FujitsuEnablingSoftwareTechnologyGmbH/kubernetes/tags","blobs_url":"https://api.github.com/repos/FujitsuEnablingSoftwareTechnologyGmbH/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FujitsuEnablingSoftwareTechnologyGmbH/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FujitsuEnablingSoftwareTechnologyGmbH/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/FujitsuEnablingSoftwareTechnologyGmbH/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FujitsuEnablingSoftwareTechnologyGmbH/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/FujitsuEnablingSoftwareTechnologyGmbH/kubernetes/languages","stargazers_url":"https://api.github.com/repos/FujitsuEnablingSoftwareTechnologyGmbH/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/FujitsuEnablingSoftwareTechnologyGmbH/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/FujitsuEnablingSoftwareTechnologyGmbH/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/FujitsuEnablingSoftwareTechnologyGmbH/kubernetes/subscription","commits_url":"https://api.github.com/repos/FujitsuEnablingSoftwareTechnologyGmbH/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/FujitsuEnablingSoftwareTechnologyGmbH/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/FujitsuEnablingSoftwareTechnologyGmbH/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/FujitsuEnablingSoftwareTechnologyGmbH/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/FujitsuEnablingSoftwareTechnologyGmbH/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/FujitsuEnablingSoftwareTechnologyGmbH/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FujitsuEnablingSoftwareTechnologyGmbH/kubernetes/merges","archive_url":"https://api.github.com/repos/FujitsuEnablingSoftwareTechnologyGmbH/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FujitsuEnablingSoftwareTechnologyGmbH/kubernetes/downloads","issues_url":"https://api.github.com/repos/FujitsuEnablingSoftwareTechnologyGmbH/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/FujitsuEnablingSoftwareTechnologyGmbH/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/FujitsuEnablingSoftwareTechnologyGmbH/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/FujitsuEnablingSoftwareTechnologyGmbH/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FujitsuEnablingSoftwareTechnologyGmbH/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/FujitsuEnablingSoftwareTechnologyGmbH/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/FujitsuEnablingSoftwareTechnologyGmbH/kubernetes/deployments","created_at":"2016-02-05T10:51:36Z","updated_at":"2016-03-30T18:21:20Z","pushed_at":"2016-05-01T20:22:54Z","git_url":"git://github.com/FujitsuEnablingSoftwareTechnologyGmbH/kubernetes.git","ssh_url":"git@github.com:FujitsuEnablingSoftwareTechnologyGmbH/kubernetes.git","clone_url":"https://github.com/FujitsuEnablingSoftwareTechnologyGmbH/kubernetes.git","svn_url":"https://github.com/FujitsuEnablingSoftwareTechnologyGmbH/kubernetes","homepage":"http://kubernetes.io","size":188018,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/FujitsuEnablingSoftwareTechnologyGmbH/kubernetes/pulls/12"},"html":{"href":"https://github.com/FujitsuEnablingSoftwareTechnologyGmbH/kubernetes/pull/12"},"issue":{"href":"https://api.github.com/repos/FujitsuEnablingSoftwareTechnologyGmbH/kubernetes/issues/12"},"comments":{"href":"https://api.github.com/repos/FujitsuEnablingSoftwareTechnologyGmbH/kubernetes/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/FujitsuEnablingSoftwareTechnologyGmbH/kubernetes/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/FujitsuEnablingSoftwareTechnologyGmbH/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/FujitsuEnablingSoftwareTechnologyGmbH/kubernetes/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/FujitsuEnablingSoftwareTechnologyGmbH/kubernetes/statuses/75fff6702fe6bd411e7f6dec7639c7e6b196cbb4"}}}}