{"action":"closed","number":2001,"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/2001","id":64881595,"html_url":"https://github.com/apple/swift/pull/2001","diff_url":"https://github.com/apple/swift/pull/2001.diff","patch_url":"https://github.com/apple/swift/pull/2001.patch","issue_url":"https://api.github.com/repos/apple/swift/issues/2001","number":2001,"state":"closed","locked":false,"title":"WIP: [Parse] Implement SE-0046: Consistent label behavior","user":{"login":"harlanhaskins","id":853032,"avatar_url":"https://avatars.githubusercontent.com/u/853032?v=3","gravatar_id":"","url":"https://api.github.com/users/harlanhaskins","html_url":"https://github.com/harlanhaskins","followers_url":"https://api.github.com/users/harlanhaskins/followers","following_url":"https://api.github.com/users/harlanhaskins/following{/other_user}","gists_url":"https://api.github.com/users/harlanhaskins/gists{/gist_id}","starred_url":"https://api.github.com/users/harlanhaskins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harlanhaskins/subscriptions","organizations_url":"https://api.github.com/users/harlanhaskins/orgs","repos_url":"https://api.github.com/users/harlanhaskins/repos","events_url":"https://api.github.com/users/harlanhaskins/events{/privacy}","received_events_url":"https://api.github.com/users/harlanhaskins/received_events","type":"User","site_admin":false},"body":"<!-- Please complete this template before creating pull request. -->\r\n#### What's in this pull request?\r\n\r\nThis pull request implements [SE-0046: Establish consistent label behavior across all parameters including first labels](https://github.com/apple/swift-evolution/blob/master/proposals/0046-first-label.md).\r\n\r\nRemoves the special case for 'first argument labels' from function declarations, and makes no distinction in label behavior between initializers and standard functions.\r\n\r\nThis currently Breaks All the Things™.\r\n\r\n<!-- Description about pull request. -->\r\n\r\n#### Resolved bug number: ([SR-961](https://bugs.swift.org/browse/SR-961))\r\n<!-- If this pull request resolves any bugs from Swift bug tracker -->\r\n\r\n* * * *\r\n\r\n<!-- This selection should only be completed by Swift admin -->\r\nBefore merging this pull request to apple/swift repository:\r\n- [ ] Test pull request on Swift continuous integration.\r\n\r\n<details>\r\n  <summary>Triggering Swift CI</summary>\r\n\r\nThe swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:\r\n\r\n**Smoke Testing**\r\n\r\n        Platform     | Comment\r\n        ------------ | -------------\r\n        All supported platforms     | @swift-ci Please smoke test\r\n        OS X platform               | @swift-ci Please smoke test OS X platform\r\n        Linux platform              | @swift-ci Please smoke test Linux platform\r\n\r\n **Validation Testing**\r\n\r\n        Platform     | Comment\r\n        ------------ | -------------\r\n        All supported platforms     | @swift-ci Please test\r\n        OS X platform               | @swift-ci Please test OS X platform\r\n        Linux platform              | @swift-ci Please test Linux platform\r\n\r\nNote: Only members of the Apple organization can trigger swift-ci.\r\n</details>\r\n<!-- Thank you for your contribution to Swift! -->\r\n\r\n","created_at":"2016-04-01T00:47:24Z","updated_at":"2016-04-04T17:16:29Z","closed_at":"2016-04-04T17:16:29Z","merged_at":null,"merge_commit_sha":"805c02768071a089932f78e0b9cec2e15a8eb2bb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift/pulls/2001/commits","review_comments_url":"https://api.github.com/repos/apple/swift/pulls/2001/comments","review_comment_url":"https://api.github.com/repos/apple/swift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift/issues/2001/comments","statuses_url":"https://api.github.com/repos/apple/swift/statuses/69ef23969ada8d08dea93f962a0bcae28bd4fec0","head":{"label":"harlanhaskins:se-46-establish-consistent-argument-labels","ref":"se-46-establish-consistent-argument-labels","sha":"69ef23969ada8d08dea93f962a0bcae28bd4fec0","user":{"login":"harlanhaskins","id":853032,"avatar_url":"https://avatars.githubusercontent.com/u/853032?v=3","gravatar_id":"","url":"https://api.github.com/users/harlanhaskins","html_url":"https://github.com/harlanhaskins","followers_url":"https://api.github.com/users/harlanhaskins/followers","following_url":"https://api.github.com/users/harlanhaskins/following{/other_user}","gists_url":"https://api.github.com/users/harlanhaskins/gists{/gist_id}","starred_url":"https://api.github.com/users/harlanhaskins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harlanhaskins/subscriptions","organizations_url":"https://api.github.com/users/harlanhaskins/orgs","repos_url":"https://api.github.com/users/harlanhaskins/repos","events_url":"https://api.github.com/users/harlanhaskins/events{/privacy}","received_events_url":"https://api.github.com/users/harlanhaskins/received_events","type":"User","site_admin":false},"repo":{"id":50544638,"name":"swift","full_name":"harlanhaskins/swift","owner":{"login":"harlanhaskins","id":853032,"avatar_url":"https://avatars.githubusercontent.com/u/853032?v=3","gravatar_id":"","url":"https://api.github.com/users/harlanhaskins","html_url":"https://github.com/harlanhaskins","followers_url":"https://api.github.com/users/harlanhaskins/followers","following_url":"https://api.github.com/users/harlanhaskins/following{/other_user}","gists_url":"https://api.github.com/users/harlanhaskins/gists{/gist_id}","starred_url":"https://api.github.com/users/harlanhaskins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harlanhaskins/subscriptions","organizations_url":"https://api.github.com/users/harlanhaskins/orgs","repos_url":"https://api.github.com/users/harlanhaskins/repos","events_url":"https://api.github.com/users/harlanhaskins/events{/privacy}","received_events_url":"https://api.github.com/users/harlanhaskins/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/harlanhaskins/swift","description":"The Swift Programming Language","fork":true,"url":"https://api.github.com/repos/harlanhaskins/swift","forks_url":"https://api.github.com/repos/harlanhaskins/swift/forks","keys_url":"https://api.github.com/repos/harlanhaskins/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/harlanhaskins/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/harlanhaskins/swift/teams","hooks_url":"https://api.github.com/repos/harlanhaskins/swift/hooks","issue_events_url":"https://api.github.com/repos/harlanhaskins/swift/issues/events{/number}","events_url":"https://api.github.com/repos/harlanhaskins/swift/events","assignees_url":"https://api.github.com/repos/harlanhaskins/swift/assignees{/user}","branches_url":"https://api.github.com/repos/harlanhaskins/swift/branches{/branch}","tags_url":"https://api.github.com/repos/harlanhaskins/swift/tags","blobs_url":"https://api.github.com/repos/harlanhaskins/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/harlanhaskins/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/harlanhaskins/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/harlanhaskins/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/harlanhaskins/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/harlanhaskins/swift/languages","stargazers_url":"https://api.github.com/repos/harlanhaskins/swift/stargazers","contributors_url":"https://api.github.com/repos/harlanhaskins/swift/contributors","subscribers_url":"https://api.github.com/repos/harlanhaskins/swift/subscribers","subscription_url":"https://api.github.com/repos/harlanhaskins/swift/subscription","commits_url":"https://api.github.com/repos/harlanhaskins/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/harlanhaskins/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/harlanhaskins/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/harlanhaskins/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/harlanhaskins/swift/contents/{+path}","compare_url":"https://api.github.com/repos/harlanhaskins/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/harlanhaskins/swift/merges","archive_url":"https://api.github.com/repos/harlanhaskins/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/harlanhaskins/swift/downloads","issues_url":"https://api.github.com/repos/harlanhaskins/swift/issues{/number}","pulls_url":"https://api.github.com/repos/harlanhaskins/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/harlanhaskins/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/harlanhaskins/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/harlanhaskins/swift/labels{/name}","releases_url":"https://api.github.com/repos/harlanhaskins/swift/releases{/id}","deployments_url":"https://api.github.com/repos/harlanhaskins/swift/deployments","created_at":"2016-01-27T23:09:47Z","updated_at":"2016-01-27T23:10:02Z","pushed_at":"2016-04-03T02:51:02Z","git_url":"git://github.com/harlanhaskins/swift.git","ssh_url":"git@github.com:harlanhaskins/swift.git","clone_url":"https://github.com/harlanhaskins/swift.git","svn_url":"https://github.com/harlanhaskins/swift","homepage":"https://swift.org/","size":85062,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apple:master","ref":"master","sha":"8afcf65fa2c8dd3f34e56295ea8b4745d5f95958","user":{"login":"apple","id":10639145,"avatar_url":"https://avatars.githubusercontent.com/u/10639145?v=3","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":44838949,"name":"swift","full_name":"apple/swift","owner":{"login":"apple","id":10639145,"avatar_url":"https://avatars.githubusercontent.com/u/10639145?v=3","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apple/swift","description":"The Swift Programming Language","fork":false,"url":"https://api.github.com/repos/apple/swift","forks_url":"https://api.github.com/repos/apple/swift/forks","keys_url":"https://api.github.com/repos/apple/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift/teams","hooks_url":"https://api.github.com/repos/apple/swift/hooks","issue_events_url":"https://api.github.com/repos/apple/swift/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift/events","assignees_url":"https://api.github.com/repos/apple/swift/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift/tags","blobs_url":"https://api.github.com/repos/apple/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift/languages","stargazers_url":"https://api.github.com/repos/apple/swift/stargazers","contributors_url":"https://api.github.com/repos/apple/swift/contributors","subscribers_url":"https://api.github.com/repos/apple/swift/subscribers","subscription_url":"https://api.github.com/repos/apple/swift/subscription","commits_url":"https://api.github.com/repos/apple/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift/merges","archive_url":"https://api.github.com/repos/apple/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift/downloads","issues_url":"https://api.github.com/repos/apple/swift/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift/deployments","created_at":"2015-10-23T21:15:07Z","updated_at":"2016-04-04T17:09:57Z","pushed_at":"2016-04-04T17:04:52Z","git_url":"git://github.com/apple/swift.git","ssh_url":"git@github.com:apple/swift.git","clone_url":"https://github.com/apple/swift.git","svn_url":"https://github.com/apple/swift","homepage":"https://swift.org/","size":132333,"stargazers_count":28277,"watchers_count":28277,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3731,"mirror_url":null,"open_issues_count":81,"forks":3731,"open_issues":81,"watchers":28277,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/2001"},"html":{"href":"https://github.com/apple/swift/pull/2001"},"issue":{"href":"https://api.github.com/repos/apple/swift/issues/2001"},"comments":{"href":"https://api.github.com/repos/apple/swift/issues/2001/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift/pulls/2001/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift/pulls/2001/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift/statuses/69ef23969ada8d08dea93f962a0bcae28bd4fec0"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":3,"review_comments":0,"commits":7,"additions":1209,"deletions":1201,"changed_files":1073}}