{"action":"created","comment":{"url":"https://api.github.com/repos/ubuntu-core/snappy/pulls/comments/50734681","id":50734681,"diff_hunk":"@@ -0,0 +1,60 @@\n+// -*- Mode: Go; indent-tabs-mode: t -*-\n+\n+/*\n+ * Copyright (C) 2015 Canonical Ltd\n+ *\n+ * This program is free software: you can redistribute it and/or modify\n+ * it under the terms of the GNU General Public License version 3 as\n+ * published by the Free Software Foundation.\n+ *\n+ * This program is distributed in the hope that it will be useful,\n+ * but WITHOUT ANY WARRANTY; without even the implied warranty of\n+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the\n+ * GNU General Public License for more details.\n+ *\n+ * You should have received a copy of the GNU General Public License\n+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.\n+ *\n+ */\n+\n+package skills\n+\n+import (\n+\t\"fmt\"\n+)\n+\n+// TestType is a skill type for various kind of tests.\n+// It is public so that it can be consumed from other packages.\n+type TestType struct {\n+\t// TypeName is the name of this type\n+\tTypeName string\n+\t// SanitizeCallback is the callback invoked inside Sanitize()\n+\tSanitizeCallback func(skill *Skill) error\n+}\n+\n+// String() returns the same value as Name().\n+func (t *TestType) String() string {\n+\treturn t.Name()\n+}\n+\n+// Name returns the name of the test type.\n+func (t *TestType) Name() string {\n+\treturn t.TypeName\n+}\n+\n+// Sanitize checks and possibly modifies a skill.\n+func (t *TestType) Sanitize(skill *Skill) error {\n+\tif t.Name() != skill.Type {\n+\t\treturn fmt.Errorf(\"skill is not of type %q\", t)","path":"skills/testtype.go","position":48,"original_position":48,"commit_id":"c6ff07948038d2623ebc8db7b799864f7e23948f","original_commit_id":"c6ff07948038d2623ebc8db7b799864f7e23948f","user":{"login":"zyga","id":784262,"avatar_url":"https://avatars.githubusercontent.com/u/784262?v=3","gravatar_id":"","url":"https://api.github.com/users/zyga","html_url":"https://github.com/zyga","followers_url":"https://api.github.com/users/zyga/followers","following_url":"https://api.github.com/users/zyga/following{/other_user}","gists_url":"https://api.github.com/users/zyga/gists{/gist_id}","starred_url":"https://api.github.com/users/zyga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zyga/subscriptions","organizations_url":"https://api.github.com/users/zyga/orgs","repos_url":"https://api.github.com/users/zyga/repos","events_url":"https://api.github.com/users/zyga/events{/privacy}","received_events_url":"https://api.github.com/users/zyga/received_events","type":"User","site_admin":false},"body":"Makes sense, changed.","created_at":"2016-01-25T18:33:34Z","updated_at":"2016-01-25T18:33:34Z","html_url":"https://github.com/ubuntu-core/snappy/pull/362#discussion_r50734681","pull_request_url":"https://api.github.com/repos/ubuntu-core/snappy/pulls/362","_links":{"self":{"href":"https://api.github.com/repos/ubuntu-core/snappy/pulls/comments/50734681"},"html":{"href":"https://github.com/ubuntu-core/snappy/pull/362#discussion_r50734681"},"pull_request":{"href":"https://api.github.com/repos/ubuntu-core/snappy/pulls/362"}}},"pull_request":{"url":"https://api.github.com/repos/ubuntu-core/snappy/pulls/362","id":56879044,"html_url":"https://github.com/ubuntu-core/snappy/pull/362","diff_url":"https://github.com/ubuntu-core/snappy/pull/362.diff","patch_url":"https://github.com/ubuntu-core/snappy/pull/362.patch","issue_url":"https://api.github.com/repos/ubuntu-core/snappy/issues/362","number":362,"state":"open","locked":false,"title":"skills: add special skill type for testing","user":{"login":"zyga","id":784262,"avatar_url":"https://avatars.githubusercontent.com/u/784262?v=3","gravatar_id":"","url":"https://api.github.com/users/zyga","html_url":"https://github.com/zyga","followers_url":"https://api.github.com/users/zyga/followers","following_url":"https://api.github.com/users/zyga/following{/other_user}","gists_url":"https://api.github.com/users/zyga/gists{/gist_id}","starred_url":"https://api.github.com/users/zyga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zyga/subscriptions","organizations_url":"https://api.github.com/users/zyga/orgs","repos_url":"https://api.github.com/users/zyga/repos","events_url":"https://api.github.com/users/zyga/events{/privacy}","received_events_url":"https://api.github.com/users/zyga/received_events","type":"User","site_admin":false},"body":"Many tests require a valid type to work with. The TestType is exactly\r\nthat, allowing us to create a range of valid and invalid capabilities,\r\ndepending on the needs of a particular test.","created_at":"2016-01-22T11:58:29Z","updated_at":"2016-01-25T18:33:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4f58706d205ddf8da38c5afc88203c392b3d7919","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ubuntu-core/snappy/pulls/362/commits","review_comments_url":"https://api.github.com/repos/ubuntu-core/snappy/pulls/362/comments","review_comment_url":"https://api.github.com/repos/ubuntu-core/snappy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ubuntu-core/snappy/issues/362/comments","statuses_url":"https://api.github.com/repos/ubuntu-core/snappy/statuses/c6ff07948038d2623ebc8db7b799864f7e23948f","head":{"label":"zyga:skills-testtype","ref":"skills-testtype","sha":"c6ff07948038d2623ebc8db7b799864f7e23948f","user":{"login":"zyga","id":784262,"avatar_url":"https://avatars.githubusercontent.com/u/784262?v=3","gravatar_id":"","url":"https://api.github.com/users/zyga","html_url":"https://github.com/zyga","followers_url":"https://api.github.com/users/zyga/followers","following_url":"https://api.github.com/users/zyga/following{/other_user}","gists_url":"https://api.github.com/users/zyga/gists{/gist_id}","starred_url":"https://api.github.com/users/zyga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zyga/subscriptions","organizations_url":"https://api.github.com/users/zyga/orgs","repos_url":"https://api.github.com/users/zyga/repos","events_url":"https://api.github.com/users/zyga/events{/privacy}","received_events_url":"https://api.github.com/users/zyga/received_events","type":"User","site_admin":false},"repo":{"id":45263078,"name":"snappy","full_name":"zyga/snappy","owner":{"login":"zyga","id":784262,"avatar_url":"https://avatars.githubusercontent.com/u/784262?v=3","gravatar_id":"","url":"https://api.github.com/users/zyga","html_url":"https://github.com/zyga","followers_url":"https://api.github.com/users/zyga/followers","following_url":"https://api.github.com/users/zyga/following{/other_user}","gists_url":"https://api.github.com/users/zyga/gists{/gist_id}","starred_url":"https://api.github.com/users/zyga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zyga/subscriptions","organizations_url":"https://api.github.com/users/zyga/orgs","repos_url":"https://api.github.com/users/zyga/repos","events_url":"https://api.github.com/users/zyga/events{/privacy}","received_events_url":"https://api.github.com/users/zyga/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zyga/snappy","description":"Snappy is the software at the heart of Ubuntu Core.","fork":true,"url":"https://api.github.com/repos/zyga/snappy","forks_url":"https://api.github.com/repos/zyga/snappy/forks","keys_url":"https://api.github.com/repos/zyga/snappy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zyga/snappy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zyga/snappy/teams","hooks_url":"https://api.github.com/repos/zyga/snappy/hooks","issue_events_url":"https://api.github.com/repos/zyga/snappy/issues/events{/number}","events_url":"https://api.github.com/repos/zyga/snappy/events","assignees_url":"https://api.github.com/repos/zyga/snappy/assignees{/user}","branches_url":"https://api.github.com/repos/zyga/snappy/branches{/branch}","tags_url":"https://api.github.com/repos/zyga/snappy/tags","blobs_url":"https://api.github.com/repos/zyga/snappy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zyga/snappy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zyga/snappy/git/refs{/sha}","trees_url":"https://api.github.com/repos/zyga/snappy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zyga/snappy/statuses/{sha}","languages_url":"https://api.github.com/repos/zyga/snappy/languages","stargazers_url":"https://api.github.com/repos/zyga/snappy/stargazers","contributors_url":"https://api.github.com/repos/zyga/snappy/contributors","subscribers_url":"https://api.github.com/repos/zyga/snappy/subscribers","subscription_url":"https://api.github.com/repos/zyga/snappy/subscription","commits_url":"https://api.github.com/repos/zyga/snappy/commits{/sha}","git_commits_url":"https://api.github.com/repos/zyga/snappy/git/commits{/sha}","comments_url":"https://api.github.com/repos/zyga/snappy/comments{/number}","issue_comment_url":"https://api.github.com/repos/zyga/snappy/issues/comments{/number}","contents_url":"https://api.github.com/repos/zyga/snappy/contents/{+path}","compare_url":"https://api.github.com/repos/zyga/snappy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zyga/snappy/merges","archive_url":"https://api.github.com/repos/zyga/snappy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zyga/snappy/downloads","issues_url":"https://api.github.com/repos/zyga/snappy/issues{/number}","pulls_url":"https://api.github.com/repos/zyga/snappy/pulls{/number}","milestones_url":"https://api.github.com/repos/zyga/snappy/milestones{/number}","notifications_url":"https://api.github.com/repos/zyga/snappy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zyga/snappy/labels{/name}","releases_url":"https://api.github.com/repos/zyga/snappy/releases{/id}","deployments_url":"https://api.github.com/repos/zyga/snappy/deployments","created_at":"2015-10-30T16:30:25Z","updated_at":"2015-10-30T16:30:28Z","pushed_at":"2016-01-25T18:19:15Z","git_url":"git://github.com/zyga/snappy.git","ssh_url":"git@github.com:zyga/snappy.git","clone_url":"https://github.com/zyga/snappy.git","svn_url":"https://github.com/zyga/snappy","homepage":null,"size":24449,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"15.04"}},"base":{"label":"ubuntu-core:master","ref":"master","sha":"9d91c8cce5509c4fe6e20c839d63bab0ac421943","user":{"login":"ubuntu-core","id":15022473,"avatar_url":"https://avatars.githubusercontent.com/u/15022473?v=3","gravatar_id":"","url":"https://api.github.com/users/ubuntu-core","html_url":"https://github.com/ubuntu-core","followers_url":"https://api.github.com/users/ubuntu-core/followers","following_url":"https://api.github.com/users/ubuntu-core/following{/other_user}","gists_url":"https://api.github.com/users/ubuntu-core/gists{/gist_id}","starred_url":"https://api.github.com/users/ubuntu-core/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ubuntu-core/subscriptions","organizations_url":"https://api.github.com/users/ubuntu-core/orgs","repos_url":"https://api.github.com/users/ubuntu-core/repos","events_url":"https://api.github.com/users/ubuntu-core/events{/privacy}","received_events_url":"https://api.github.com/users/ubuntu-core/received_events","type":"Organization","site_admin":false},"repo":{"id":44672744,"name":"snappy","full_name":"ubuntu-core/snappy","owner":{"login":"ubuntu-core","id":15022473,"avatar_url":"https://avatars.githubusercontent.com/u/15022473?v=3","gravatar_id":"","url":"https://api.github.com/users/ubuntu-core","html_url":"https://github.com/ubuntu-core","followers_url":"https://api.github.com/users/ubuntu-core/followers","following_url":"https://api.github.com/users/ubuntu-core/following{/other_user}","gists_url":"https://api.github.com/users/ubuntu-core/gists{/gist_id}","starred_url":"https://api.github.com/users/ubuntu-core/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ubuntu-core/subscriptions","organizations_url":"https://api.github.com/users/ubuntu-core/orgs","repos_url":"https://api.github.com/users/ubuntu-core/repos","events_url":"https://api.github.com/users/ubuntu-core/events{/privacy}","received_events_url":"https://api.github.com/users/ubuntu-core/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ubuntu-core/snappy","description":"Snappy is the software at the heart of Ubuntu Core.","fork":false,"url":"https://api.github.com/repos/ubuntu-core/snappy","forks_url":"https://api.github.com/repos/ubuntu-core/snappy/forks","keys_url":"https://api.github.com/repos/ubuntu-core/snappy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ubuntu-core/snappy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ubuntu-core/snappy/teams","hooks_url":"https://api.github.com/repos/ubuntu-core/snappy/hooks","issue_events_url":"https://api.github.com/repos/ubuntu-core/snappy/issues/events{/number}","events_url":"https://api.github.com/repos/ubuntu-core/snappy/events","assignees_url":"https://api.github.com/repos/ubuntu-core/snappy/assignees{/user}","branches_url":"https://api.github.com/repos/ubuntu-core/snappy/branches{/branch}","tags_url":"https://api.github.com/repos/ubuntu-core/snappy/tags","blobs_url":"https://api.github.com/repos/ubuntu-core/snappy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ubuntu-core/snappy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ubuntu-core/snappy/git/refs{/sha}","trees_url":"https://api.github.com/repos/ubuntu-core/snappy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ubuntu-core/snappy/statuses/{sha}","languages_url":"https://api.github.com/repos/ubuntu-core/snappy/languages","stargazers_url":"https://api.github.com/repos/ubuntu-core/snappy/stargazers","contributors_url":"https://api.github.com/repos/ubuntu-core/snappy/contributors","subscribers_url":"https://api.github.com/repos/ubuntu-core/snappy/subscribers","subscription_url":"https://api.github.com/repos/ubuntu-core/snappy/subscription","commits_url":"https://api.github.com/repos/ubuntu-core/snappy/commits{/sha}","git_commits_url":"https://api.github.com/repos/ubuntu-core/snappy/git/commits{/sha}","comments_url":"https://api.github.com/repos/ubuntu-core/snappy/comments{/number}","issue_comment_url":"https://api.github.com/repos/ubuntu-core/snappy/issues/comments{/number}","contents_url":"https://api.github.com/repos/ubuntu-core/snappy/contents/{+path}","compare_url":"https://api.github.com/repos/ubuntu-core/snappy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ubuntu-core/snappy/merges","archive_url":"https://api.github.com/repos/ubuntu-core/snappy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ubuntu-core/snappy/downloads","issues_url":"https://api.github.com/repos/ubuntu-core/snappy/issues{/number}","pulls_url":"https://api.github.com/repos/ubuntu-core/snappy/pulls{/number}","milestones_url":"https://api.github.com/repos/ubuntu-core/snappy/milestones{/number}","notifications_url":"https://api.github.com/repos/ubuntu-core/snappy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ubuntu-core/snappy/labels{/name}","releases_url":"https://api.github.com/repos/ubuntu-core/snappy/releases{/id}","deployments_url":"https://api.github.com/repos/ubuntu-core/snappy/deployments","created_at":"2015-10-21T11:51:46Z","updated_at":"2016-01-19T08:01:39Z","pushed_at":"2016-01-25T18:29:44Z","git_url":"git://github.com/ubuntu-core/snappy.git","ssh_url":"git@github.com:ubuntu-core/snappy.git","clone_url":"https://github.com/ubuntu-core/snappy.git","svn_url":"https://github.com/ubuntu-core/snappy","homepage":null,"size":25171,"stargazers_count":49,"watchers_count":49,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"open_issues_count":14,"forks":21,"open_issues":14,"watchers":49,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ubuntu-core/snappy/pulls/362"},"html":{"href":"https://github.com/ubuntu-core/snappy/pull/362"},"issue":{"href":"https://api.github.com/repos/ubuntu-core/snappy/issues/362"},"comments":{"href":"https://api.github.com/repos/ubuntu-core/snappy/issues/362/comments"},"review_comments":{"href":"https://api.github.com/repos/ubuntu-core/snappy/pulls/362/comments"},"review_comment":{"href":"https://api.github.com/repos/ubuntu-core/snappy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ubuntu-core/snappy/pulls/362/commits"},"statuses":{"href":"https://api.github.com/repos/ubuntu-core/snappy/statuses/c6ff07948038d2623ebc8db7b799864f7e23948f"}}}}