{"action":"created","issue":{"url":"https://api.github.com/repos/ampproject/amphtml/issues/4015","repository_url":"https://api.github.com/repos/ampproject/amphtml","labels_url":"https://api.github.com/repos/ampproject/amphtml/issues/4015/labels{/name}","comments_url":"https://api.github.com/repos/ampproject/amphtml/issues/4015/comments","events_url":"https://api.github.com/repos/ampproject/amphtml/issues/4015/events","html_url":"https://github.com/ampproject/amphtml/pull/4015","id":164902352,"number":4015,"title":"make `attemptChangeSize` return a promise","user":{"login":"zhouyx","id":5419904,"avatar_url":"https://avatars.githubusercontent.com/u/5419904?v=3","gravatar_id":"","url":"https://api.github.com/users/zhouyx","html_url":"https://github.com/zhouyx","followers_url":"https://api.github.com/users/zhouyx/followers","following_url":"https://api.github.com/users/zhouyx/following{/other_user}","gists_url":"https://api.github.com/users/zhouyx/gists{/gist_id}","starred_url":"https://api.github.com/users/zhouyx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhouyx/subscriptions","organizations_url":"https://api.github.com/users/zhouyx/orgs","repos_url":"https://api.github.com/users/zhouyx/repos","events_url":"https://api.github.com/users/zhouyx/events{/privacy}","received_events_url":"https://api.github.com/users/zhouyx/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ampproject/amphtml/labels/NEEDS%20REVIEW","name":"NEEDS REVIEW","color":"e11d21"}],"state":"open","locked":false,"assignee":{"login":"sriramkrish85","id":1037311,"avatar_url":"https://avatars.githubusercontent.com/u/1037311?v=3","gravatar_id":"","url":"https://api.github.com/users/sriramkrish85","html_url":"https://github.com/sriramkrish85","followers_url":"https://api.github.com/users/sriramkrish85/followers","following_url":"https://api.github.com/users/sriramkrish85/following{/other_user}","gists_url":"https://api.github.com/users/sriramkrish85/gists{/gist_id}","starred_url":"https://api.github.com/users/sriramkrish85/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sriramkrish85/subscriptions","organizations_url":"https://api.github.com/users/sriramkrish85/orgs","repos_url":"https://api.github.com/users/sriramkrish85/repos","events_url":"https://api.github.com/users/sriramkrish85/events{/privacy}","received_events_url":"https://api.github.com/users/sriramkrish85/received_events","type":"User","site_admin":false},"assignees":[{"login":"sriramkrish85","id":1037311,"avatar_url":"https://avatars.githubusercontent.com/u/1037311?v=3","gravatar_id":"","url":"https://api.github.com/users/sriramkrish85","html_url":"https://github.com/sriramkrish85","followers_url":"https://api.github.com/users/sriramkrish85/followers","following_url":"https://api.github.com/users/sriramkrish85/following{/other_user}","gists_url":"https://api.github.com/users/sriramkrish85/gists{/gist_id}","starred_url":"https://api.github.com/users/sriramkrish85/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sriramkrish85/subscriptions","organizations_url":"https://api.github.com/users/sriramkrish85/orgs","repos_url":"https://api.github.com/users/sriramkrish85/repos","events_url":"https://api.github.com/users/sriramkrish85/events{/privacy}","received_events_url":"https://api.github.com/users/sriramkrish85/received_events","type":"User","site_admin":false}],"milestone":null,"comments":6,"created_at":"2016-07-11T18:25:43Z","updated_at":"2016-07-20T22:58:54Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/4015","html_url":"https://github.com/ampproject/amphtml/pull/4015","diff_url":"https://github.com/ampproject/amphtml/pull/4015.diff","patch_url":"https://github.com/ampproject/amphtml/pull/4015.patch"},"body":"#4014\r\nChange `attemptChangeSize` `attemptChanteHeight` to return a promise\r\nDelete current opt_callback, and switch to using then, involved elements are `amp-iframe`, `amp-fx-flying-carpet`,  `amp-ad-3p-impl`, fix tests for these elements"},"comment":{"url":"https://api.github.com/repos/ampproject/amphtml/issues/comments/234109651","html_url":"https://github.com/ampproject/amphtml/pull/4015#issuecomment-234109651","issue_url":"https://api.github.com/repos/ampproject/amphtml/issues/4015","id":234109651,"user":{"login":"zhouyx","id":5419904,"avatar_url":"https://avatars.githubusercontent.com/u/5419904?v=3","gravatar_id":"","url":"https://api.github.com/users/zhouyx","html_url":"https://github.com/zhouyx","followers_url":"https://api.github.com/users/zhouyx/followers","following_url":"https://api.github.com/users/zhouyx/following{/other_user}","gists_url":"https://api.github.com/users/zhouyx/gists{/gist_id}","starred_url":"https://api.github.com/users/zhouyx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhouyx/subscriptions","organizations_url":"https://api.github.com/users/zhouyx/orgs","repos_url":"https://api.github.com/users/zhouyx/repos","events_url":"https://api.github.com/users/zhouyx/events{/privacy}","received_events_url":"https://api.github.com/users/zhouyx/received_events","type":"User","site_admin":false},"created_at":"2016-07-20T22:58:54Z","updated_at":"2016-07-20T22:58:54Z","body":"Not related to this PR, but I found this test has a changeSize diff = 0 case, which I felt not related to its description.\r\nhttps://github.com/ampproject/amphtml/blob/master/test/functional/test-resources.js#L1015"}}
{"actor":{"display_login":"zhouyx"}}