{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/37966","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/37966/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/37966/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/37966/events","html_url":"https://github.com/kubernetes/kubernetes/pull/37966","id":193183409,"number":37966,"title":"decided to extract common logic for RESTMapping and RESTMappings to a…","user":{"login":"p0lyn0mial","id":21304151,"avatar_url":"https://avatars.githubusercontent.com/u/21304151?v=3","gravatar_id":"","url":"https://api.github.com/users/p0lyn0mial","html_url":"https://github.com/p0lyn0mial","followers_url":"https://api.github.com/users/p0lyn0mial/followers","following_url":"https://api.github.com/users/p0lyn0mial/following{/other_user}","gists_url":"https://api.github.com/users/p0lyn0mial/gists{/gist_id}","starred_url":"https://api.github.com/users/p0lyn0mial/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/p0lyn0mial/subscriptions","organizations_url":"https://api.github.com/users/p0lyn0mial/orgs","repos_url":"https://api.github.com/users/p0lyn0mial/repos","events_url":"https://api.github.com/users/p0lyn0mial/events{/privacy}","received_events_url":"https://api.github.com/users/p0lyn0mial/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-12-02T18:21:03Z","updated_at":"2016-12-02T18:21:04Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/37966","html_url":"https://github.com/kubernetes/kubernetes/pull/37966","diff_url":"https://github.com/kubernetes/kubernetes/pull/37966.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/37966.patch"},"body":"<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If this is your first time, read our contributor guidelines https://github.com/kubernetes/kubernetes/blob/master/CONTRIBUTING.md and developer guide https://github.com/kubernetes/kubernetes/blob/master/docs/devel/development.md\r\n2. If you want *faster* PR reviews, read how: https://github.com/kubernetes/kubernetes/blob/master/docs/devel/faster_reviews.md\r\n3. Follow the instructions for writing a release note: https://github.com/kubernetes/kubernetes/blob/master/docs/devel/pull-requests.md#release-notes\r\n-->\r\n\r\n**What this PR does / why we need it**: the changes introduced in this PR extract common logic of RESTMapping and RESTMappings to one common method. \r\n\r\n**Special notes for your reviewer**: this is my first PR - be polite.\r\n\r\n\r\n\r\nThe only change in logic to what was before is when calling commonRESTMappings from RESTMapping\r\nwe search all defaultGroupVersion as opposed to just one when no mapping was found for provided versions."},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/264524202","html_url":"https://github.com/kubernetes/kubernetes/pull/37966#issuecomment-264524202","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/37966","id":264524202,"user":{"login":"k8s-ci-robot","id":20407524,"avatar_url":"https://avatars.githubusercontent.com/u/20407524?v=3","gravatar_id":"","url":"https://api.github.com/users/k8s-ci-robot","html_url":"https://github.com/k8s-ci-robot","followers_url":"https://api.github.com/users/k8s-ci-robot/followers","following_url":"https://api.github.com/users/k8s-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-ci-robot/orgs","repos_url":"https://api.github.com/users/k8s-ci-robot/repos","events_url":"https://api.github.com/users/k8s-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2016-12-02T18:21:04Z","updated_at":"2016-12-02T18:21:04Z","body":"\nCan a [kubernetes](https://github.com/orgs/kubernetes/people) member verify that this patch is reasonable to test? If so, please reply with \"@k8s-bot ok to test\" on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands will still work. Regular contributors should join the org to skip this step.\n\n<details>\nIf you have questions or suggestions related to this bot's behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>\n"}}
{"actor":{"display_login":"k8s-ci-robot"}}