{"action":"opened","number":20045,"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/20045","id":58474711,"html_url":"https://github.com/docker/docker/pull/20045","diff_url":"https://github.com/docker/docker/pull/20045.diff","patch_url":"https://github.com/docker/docker/pull/20045.patch","issue_url":"https://api.github.com/repos/docker/docker/issues/20045","number":20045,"state":"open","locked":false,"title":"Fix ZFS permissions bug with user namespaces","user":{"login":"estesp","id":1397980,"avatar_url":"https://avatars.githubusercontent.com/u/1397980?v=3","gravatar_id":"","url":"https://api.github.com/users/estesp","html_url":"https://github.com/estesp","followers_url":"https://api.github.com/users/estesp/followers","following_url":"https://api.github.com/users/estesp/following{/other_user}","gists_url":"https://api.github.com/users/estesp/gists{/gist_id}","starred_url":"https://api.github.com/users/estesp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/estesp/subscriptions","organizations_url":"https://api.github.com/users/estesp/orgs","repos_url":"https://api.github.com/users/estesp/repos","events_url":"https://api.github.com/users/estesp/events{/privacy}","received_events_url":"https://api.github.com/users/estesp/received_events","type":"User","site_admin":false},"body":"Fixes #20007\r\n\r\nFix root directory of the mountpoint being owned by real root. This is\r\nunique to ZFS because of the way file mountpoints are created using the\r\nZFS tooling, and the remapping that happens at layer unpack doesn't\r\nimpact this root (already created) holding directory for the layer.\r\n\r\nI wish this could be less heavy-handed; e.g. use `Stat` to check ownership but my assumption is that either syscall is probably a similar cost. The problem is that when the FS is created in the ZFS driver it isn't mounted, so we have no chance to set this up properly at creation time (at least with my limited knowledge of ZFS), and have to wait until it's mounted to correct this ownership problem.\r\n\r\nDocker-DCO-1.1-Signed-off-by: Phil Estes <estesp@linux.vnet.ibm.com> (github: estesp)","created_at":"2016-02-05T19:42:20Z","updated_at":"2016-02-05T19:42:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/docker/docker/pulls/20045/commits","review_comments_url":"https://api.github.com/repos/docker/docker/pulls/20045/comments","review_comment_url":"https://api.github.com/repos/docker/docker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/docker/issues/20045/comments","statuses_url":"https://api.github.com/repos/docker/docker/statuses/aef0995b02a5a90ad74e6d91901d7bc8a9713796","head":{"label":"estesp:zfs-userns-permissions-fix","ref":"zfs-userns-permissions-fix","sha":"aef0995b02a5a90ad74e6d91901d7bc8a9713796","user":{"login":"estesp","id":1397980,"avatar_url":"https://avatars.githubusercontent.com/u/1397980?v=3","gravatar_id":"","url":"https://api.github.com/users/estesp","html_url":"https://github.com/estesp","followers_url":"https://api.github.com/users/estesp/followers","following_url":"https://api.github.com/users/estesp/following{/other_user}","gists_url":"https://api.github.com/users/estesp/gists{/gist_id}","starred_url":"https://api.github.com/users/estesp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/estesp/subscriptions","organizations_url":"https://api.github.com/users/estesp/orgs","repos_url":"https://api.github.com/users/estesp/repos","events_url":"https://api.github.com/users/estesp/events{/privacy}","received_events_url":"https://api.github.com/users/estesp/received_events","type":"User","site_admin":false},"repo":{"id":23801241,"name":"docker","full_name":"estesp/docker","owner":{"login":"estesp","id":1397980,"avatar_url":"https://avatars.githubusercontent.com/u/1397980?v=3","gravatar_id":"","url":"https://api.github.com/users/estesp","html_url":"https://github.com/estesp","followers_url":"https://api.github.com/users/estesp/followers","following_url":"https://api.github.com/users/estesp/following{/other_user}","gists_url":"https://api.github.com/users/estesp/gists{/gist_id}","starred_url":"https://api.github.com/users/estesp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/estesp/subscriptions","organizations_url":"https://api.github.com/users/estesp/orgs","repos_url":"https://api.github.com/users/estesp/repos","events_url":"https://api.github.com/users/estesp/events{/privacy}","received_events_url":"https://api.github.com/users/estesp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/estesp/docker","description":"Docker - the open-source application container engine","fork":true,"url":"https://api.github.com/repos/estesp/docker","forks_url":"https://api.github.com/repos/estesp/docker/forks","keys_url":"https://api.github.com/repos/estesp/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/estesp/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/estesp/docker/teams","hooks_url":"https://api.github.com/repos/estesp/docker/hooks","issue_events_url":"https://api.github.com/repos/estesp/docker/issues/events{/number}","events_url":"https://api.github.com/repos/estesp/docker/events","assignees_url":"https://api.github.com/repos/estesp/docker/assignees{/user}","branches_url":"https://api.github.com/repos/estesp/docker/branches{/branch}","tags_url":"https://api.github.com/repos/estesp/docker/tags","blobs_url":"https://api.github.com/repos/estesp/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/estesp/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/estesp/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/estesp/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/estesp/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/estesp/docker/languages","stargazers_url":"https://api.github.com/repos/estesp/docker/stargazers","contributors_url":"https://api.github.com/repos/estesp/docker/contributors","subscribers_url":"https://api.github.com/repos/estesp/docker/subscribers","subscription_url":"https://api.github.com/repos/estesp/docker/subscription","commits_url":"https://api.github.com/repos/estesp/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/estesp/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/estesp/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/estesp/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/estesp/docker/contents/{+path}","compare_url":"https://api.github.com/repos/estesp/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/estesp/docker/merges","archive_url":"https://api.github.com/repos/estesp/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/estesp/docker/downloads","issues_url":"https://api.github.com/repos/estesp/docker/issues{/number}","pulls_url":"https://api.github.com/repos/estesp/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/estesp/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/estesp/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/estesp/docker/labels{/name}","releases_url":"https://api.github.com/repos/estesp/docker/releases{/id}","deployments_url":"https://api.github.com/repos/estesp/docker/deployments","created_at":"2014-09-08T17:42:10Z","updated_at":"2016-01-11T15:28:59Z","pushed_at":"2016-02-05T19:39:41Z","git_url":"git://github.com/estesp/docker.git","ssh_url":"git@github.com:estesp/docker.git","clone_url":"https://github.com/estesp/docker.git","svn_url":"https://github.com/estesp/docker","homepage":"http://www.docker.com","size":80784,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"1573960dca09e789be7cd18cfeaaf024a1e03bd5","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":7691631,"name":"docker","full_name":"docker/docker","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/docker","description":"Docker - the open-source application container engine","fork":false,"url":"https://api.github.com/repos/docker/docker","forks_url":"https://api.github.com/repos/docker/docker/forks","keys_url":"https://api.github.com/repos/docker/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/docker/teams","hooks_url":"https://api.github.com/repos/docker/docker/hooks","issue_events_url":"https://api.github.com/repos/docker/docker/issues/events{/number}","events_url":"https://api.github.com/repos/docker/docker/events","assignees_url":"https://api.github.com/repos/docker/docker/assignees{/user}","branches_url":"https://api.github.com/repos/docker/docker/branches{/branch}","tags_url":"https://api.github.com/repos/docker/docker/tags","blobs_url":"https://api.github.com/repos/docker/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/docker/languages","stargazers_url":"https://api.github.com/repos/docker/docker/stargazers","contributors_url":"https://api.github.com/repos/docker/docker/contributors","subscribers_url":"https://api.github.com/repos/docker/docker/subscribers","subscription_url":"https://api.github.com/repos/docker/docker/subscription","commits_url":"https://api.github.com/repos/docker/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/docker/contents/{+path}","compare_url":"https://api.github.com/repos/docker/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/docker/merges","archive_url":"https://api.github.com/repos/docker/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/docker/downloads","issues_url":"https://api.github.com/repos/docker/docker/issues{/number}","pulls_url":"https://api.github.com/repos/docker/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/docker/labels{/name}","releases_url":"https://api.github.com/repos/docker/docker/releases{/id}","deployments_url":"https://api.github.com/repos/docker/docker/deployments","created_at":"2013-01-18T18:10:57Z","updated_at":"2016-02-05T19:32:25Z","pushed_at":"2016-02-05T18:51:23Z","git_url":"git://github.com/docker/docker.git","ssh_url":"git@github.com:docker/docker.git","clone_url":"https://github.com/docker/docker.git","svn_url":"https://github.com/docker/docker","homepage":"http://www.docker.com","size":135872,"stargazers_count":28470,"watchers_count":28470,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7877,"mirror_url":null,"open_issues_count":1264,"forks":7877,"open_issues":1264,"watchers":28470,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/20045"},"html":{"href":"https://github.com/docker/docker/pull/20045"},"issue":{"href":"https://api.github.com/repos/docker/docker/issues/20045"},"comments":{"href":"https://api.github.com/repos/docker/docker/issues/20045/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/docker/pulls/20045/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/docker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/docker/pulls/20045/commits"},"statuses":{"href":"https://api.github.com/repos/docker/docker/statuses/aef0995b02a5a90ad74e6d91901d7bc8a9713796"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":6,"deletions":2,"changed_files":1}}