{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/84554560","pull_request_review_id":5329204,"id":84554560,"diff_hunk":"@@ -177,7 +177,10 @@ var stringifyPrimitive = function(v) {\n };\n \n \n-QueryString.stringify = QueryString.encode = function(obj, sep, eq, options) {\n+QueryString.stringify = QueryString.encode = function stringify(obj,","path":"lib/querystring.js","position":32,"original_position":32,"commit_id":"fdbe6280a3adb14e2dce495fe3d16febf774cfe9","original_commit_id":"fdbe6280a3adb14e2dce495fe3d16febf774cfe9","user":{"login":"mscdex","id":54666,"avatar_url":"https://avatars.githubusercontent.com/u/54666?v=3","gravatar_id":"","url":"https://api.github.com/users/mscdex","html_url":"https://github.com/mscdex","followers_url":"https://api.github.com/users/mscdex/followers","following_url":"https://api.github.com/users/mscdex/following{/other_user}","gists_url":"https://api.github.com/users/mscdex/gists{/gist_id}","starred_url":"https://api.github.com/users/mscdex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mscdex/subscriptions","organizations_url":"https://api.github.com/users/mscdex/orgs","repos_url":"https://api.github.com/users/mscdex/repos","events_url":"https://api.github.com/users/mscdex/events{/privacy}","received_events_url":"https://api.github.com/users/mscdex/received_events","type":"User","site_admin":false},"body":"This could be a little confusing ;-)","created_at":"2016-10-21T22:24:15Z","updated_at":"2016-10-21T22:24:15Z","html_url":"https://github.com/nodejs/node/pull/9230#discussion_r84554560","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/9230","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/84554560"},"html":{"href":"https://github.com/nodejs/node/pull/9230#discussion_r84554560"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/9230"}}},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/9230","id":90451710,"html_url":"https://github.com/nodejs/node/pull/9230","diff_url":"https://github.com/nodejs/node/pull/9230.diff","patch_url":"https://github.com/nodejs/node/pull/9230.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/9230","number":9230,"state":"open","locked":false,"title":"querystring: name anonymous functions","user":{"login":"tylerbrazier","id":4481528,"avatar_url":"https://avatars.githubusercontent.com/u/4481528?v=3","gravatar_id":"","url":"https://api.github.com/users/tylerbrazier","html_url":"https://github.com/tylerbrazier","followers_url":"https://api.github.com/users/tylerbrazier/followers","following_url":"https://api.github.com/users/tylerbrazier/following{/other_user}","gists_url":"https://api.github.com/users/tylerbrazier/gists{/gist_id}","starred_url":"https://api.github.com/users/tylerbrazier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tylerbrazier/subscriptions","organizations_url":"https://api.github.com/users/tylerbrazier/orgs","repos_url":"https://api.github.com/users/tylerbrazier/repos","events_url":"https://api.github.com/users/tylerbrazier/events{/privacy}","received_events_url":"https://api.github.com/users/tylerbrazier/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you for your pull request. Please review below requirements.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j8 test` (UNIX), or `vcbuild test nosign` (Windows) passes\r\n- [x] commit message follows commit guidelines\r\n\r\n##### Affected core subsystem(s)\r\n<!-- Provide affected core subsystem(s) (like doc, cluster, crypto, etc). -->\r\nquerystring\r\n\r\n##### Description of change\r\n<!-- Provide a description of the change below this comment. -->\r\nnamed anonymous functions in querystring\r\nRef: https://github.com/nodejs/node/issues/8913","created_at":"2016-10-21T22:06:46Z","updated_at":"2016-10-21T22:24:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"770d55c4c36078b4f84ecf7f3d9c3fdb4c29ed4f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/9230/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/9230/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/9230/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/fdbe6280a3adb14e2dce495fe3d16febf774cfe9","head":{"label":"tylerbrazier:qs-fn-names","ref":"qs-fn-names","sha":"fdbe6280a3adb14e2dce495fe3d16febf774cfe9","user":{"login":"tylerbrazier","id":4481528,"avatar_url":"https://avatars.githubusercontent.com/u/4481528?v=3","gravatar_id":"","url":"https://api.github.com/users/tylerbrazier","html_url":"https://github.com/tylerbrazier","followers_url":"https://api.github.com/users/tylerbrazier/followers","following_url":"https://api.github.com/users/tylerbrazier/following{/other_user}","gists_url":"https://api.github.com/users/tylerbrazier/gists{/gist_id}","starred_url":"https://api.github.com/users/tylerbrazier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tylerbrazier/subscriptions","organizations_url":"https://api.github.com/users/tylerbrazier/orgs","repos_url":"https://api.github.com/users/tylerbrazier/repos","events_url":"https://api.github.com/users/tylerbrazier/events{/privacy}","received_events_url":"https://api.github.com/users/tylerbrazier/received_events","type":"User","site_admin":false},"repo":{"id":70656880,"name":"node","full_name":"tylerbrazier/node","owner":{"login":"tylerbrazier","id":4481528,"avatar_url":"https://avatars.githubusercontent.com/u/4481528?v=3","gravatar_id":"","url":"https://api.github.com/users/tylerbrazier","html_url":"https://github.com/tylerbrazier","followers_url":"https://api.github.com/users/tylerbrazier/followers","following_url":"https://api.github.com/users/tylerbrazier/following{/other_user}","gists_url":"https://api.github.com/users/tylerbrazier/gists{/gist_id}","starred_url":"https://api.github.com/users/tylerbrazier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tylerbrazier/subscriptions","organizations_url":"https://api.github.com/users/tylerbrazier/orgs","repos_url":"https://api.github.com/users/tylerbrazier/repos","events_url":"https://api.github.com/users/tylerbrazier/events{/privacy}","received_events_url":"https://api.github.com/users/tylerbrazier/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tylerbrazier/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":true,"url":"https://api.github.com/repos/tylerbrazier/node","forks_url":"https://api.github.com/repos/tylerbrazier/node/forks","keys_url":"https://api.github.com/repos/tylerbrazier/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tylerbrazier/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tylerbrazier/node/teams","hooks_url":"https://api.github.com/repos/tylerbrazier/node/hooks","issue_events_url":"https://api.github.com/repos/tylerbrazier/node/issues/events{/number}","events_url":"https://api.github.com/repos/tylerbrazier/node/events","assignees_url":"https://api.github.com/repos/tylerbrazier/node/assignees{/user}","branches_url":"https://api.github.com/repos/tylerbrazier/node/branches{/branch}","tags_url":"https://api.github.com/repos/tylerbrazier/node/tags","blobs_url":"https://api.github.com/repos/tylerbrazier/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tylerbrazier/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tylerbrazier/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/tylerbrazier/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tylerbrazier/node/statuses/{sha}","languages_url":"https://api.github.com/repos/tylerbrazier/node/languages","stargazers_url":"https://api.github.com/repos/tylerbrazier/node/stargazers","contributors_url":"https://api.github.com/repos/tylerbrazier/node/contributors","subscribers_url":"https://api.github.com/repos/tylerbrazier/node/subscribers","subscription_url":"https://api.github.com/repos/tylerbrazier/node/subscription","commits_url":"https://api.github.com/repos/tylerbrazier/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/tylerbrazier/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/tylerbrazier/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/tylerbrazier/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/tylerbrazier/node/contents/{+path}","compare_url":"https://api.github.com/repos/tylerbrazier/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tylerbrazier/node/merges","archive_url":"https://api.github.com/repos/tylerbrazier/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tylerbrazier/node/downloads","issues_url":"https://api.github.com/repos/tylerbrazier/node/issues{/number}","pulls_url":"https://api.github.com/repos/tylerbrazier/node/pulls{/number}","milestones_url":"https://api.github.com/repos/tylerbrazier/node/milestones{/number}","notifications_url":"https://api.github.com/repos/tylerbrazier/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tylerbrazier/node/labels{/name}","releases_url":"https://api.github.com/repos/tylerbrazier/node/releases{/id}","deployments_url":"https://api.github.com/repos/tylerbrazier/node/deployments","created_at":"2016-10-12T02:59:57Z","updated_at":"2016-10-12T03:00:21Z","pushed_at":"2016-10-21T22:09:53Z","git_url":"git://github.com/tylerbrazier/node.git","ssh_url":"git@github.com:tylerbrazier/node.git","clone_url":"https://github.com/tylerbrazier/node.git","svn_url":"https://github.com/tylerbrazier/node","homepage":"https://nodejs.org","size":235200,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"f1a3755cd1aeb204cc41f53c4617ab509c9e7570","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2016-10-21T22:20:35Z","pushed_at":"2016-10-21T22:14:43Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":350051,"stargazers_count":27993,"watchers_count":27993,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4640,"mirror_url":null,"open_issues_count":855,"forks":4640,"open_issues":855,"watchers":27993,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/9230"},"html":{"href":"https://github.com/nodejs/node/pull/9230"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/9230"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/9230/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/9230/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/9230/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/fdbe6280a3adb14e2dce495fe3d16febf774cfe9"}}}}
{"actor":{"display_login":"mscdex"}}