{"action":"created","comment":{"url":"https://api.github.com/repos/whatwg/streams/pulls/comments/82113668","pull_request_review_id":3042826,"id":82113668,"diff_hunk":"@@ -0,0 +1,73 @@\n+'use strict';\n+\n+if (self.importScripts) {\n+  self.importScripts('/resources/testharness.js');\n+}\n+\n+promise_test(() => {\n+  let controller;\n+  const ws = new WritableStream({\n+    start(c) {\n+      controller = c;\n+    }\n+  });\n+\n+  // Now error the stream after its construction.\n+  const passedError = new Error('horrible things');\n+  controller.error(passedError);\n+\n+  const writer = ws.getWriter();\n+\n+  assert_equals(writer.desiredSize, null, 'desiredSize should be null');\n+  return writer.closed.catch(r => {\n+    assert_equals(r, passedError, 'ws should be errored by passedError');\n+  });\n+}, 'controller argument should be passed to start method');\n+\n+promise_test(() => {\n+  const ws = new WritableStream({}, {\n+    highWaterMark: 1000,\n+    size() { return 1; }\n+  });\n+\n+  const writer = ws.getWriter();\n+\n+  assert_equals(writer.desiredSize, 1000, 'desiredSize should be 1000');\n+  return writer.ready.then(v => {\n+    assert_equals(v, undefined, 'ready promise should fulfill with undefined');\n+  });\n+}, 'highWaterMark should be copied to desiredSize');","path":"reference-implementation/to-upstream-wpts/writable-streams/constructor.js","position":39,"original_position":39,"commit_id":"411d966572bdb9458d21198541b8508c7fb2e123","original_commit_id":"411d966572bdb9458d21198541b8508c7fb2e123","user":{"login":"tyoshino","id":4511440,"avatar_url":"https://avatars.githubusercontent.com/u/4511440?v=3","gravatar_id":"","url":"https://api.github.com/users/tyoshino","html_url":"https://github.com/tyoshino","followers_url":"https://api.github.com/users/tyoshino/followers","following_url":"https://api.github.com/users/tyoshino/following{/other_user}","gists_url":"https://api.github.com/users/tyoshino/gists{/gist_id}","starred_url":"https://api.github.com/users/tyoshino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tyoshino/subscriptions","organizations_url":"https://api.github.com/users/tyoshino/orgs","repos_url":"https://api.github.com/users/tyoshino/repos","events_url":"https://api.github.com/users/tyoshino/events{/privacy}","received_events_url":"https://api.github.com/users/tyoshino/received_events","type":"User","site_admin":false},"body":"how about s/copied/reflected/?","created_at":"2016-10-06T03:59:28Z","updated_at":"2016-10-06T04:02:21Z","html_url":"https://github.com/whatwg/streams/pull/524#discussion_r82113668","pull_request_url":"https://api.github.com/repos/whatwg/streams/pulls/524","_links":{"self":{"href":"https://api.github.com/repos/whatwg/streams/pulls/comments/82113668"},"html":{"href":"https://github.com/whatwg/streams/pull/524#discussion_r82113668"},"pull_request":{"href":"https://api.github.com/repos/whatwg/streams/pulls/524"}}},"pull_request":{"url":"https://api.github.com/repos/whatwg/streams/pulls/524","id":88030134,"html_url":"https://github.com/whatwg/streams/pull/524","diff_url":"https://github.com/whatwg/streams/pull/524.diff","patch_url":"https://github.com/whatwg/streams/pull/524.patch","issue_url":"https://api.github.com/repos/whatwg/streams/issues/524","number":524,"state":"open","locked":false,"title":"Port constructor tests to web-platform-tests","user":{"login":"ricea","id":6678407,"avatar_url":"https://avatars.githubusercontent.com/u/6678407?v=3","gravatar_id":"","url":"https://api.github.com/users/ricea","html_url":"https://github.com/ricea","followers_url":"https://api.github.com/users/ricea/followers","following_url":"https://api.github.com/users/ricea/following{/other_user}","gists_url":"https://api.github.com/users/ricea/gists{/gist_id}","starred_url":"https://api.github.com/users/ricea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ricea/subscriptions","organizations_url":"https://api.github.com/users/ricea/orgs","repos_url":"https://api.github.com/users/ricea/repos","events_url":"https://api.github.com/users/ricea/events{/privacy}","received_events_url":"https://api.github.com/users/ricea/received_events","type":"User","site_admin":false},"body":"Move tests relating to the WritableStream constructor and\r\nnewly-constructed objects to the testharness.js framework.\r\n\r\nOnly syntactic and style changes have been made in this CL. There are no\r\nsemantic changes, except that some property existence checks have been\r\nchanged to use assert_idl_attribute(), which is stricter. Also where the\r\noriginal test verified that a promise resolved, the ported version just\r\nreturns the promise and lets the test harness check it.","created_at":"2016-10-05T07:46:34Z","updated_at":"2016-10-06T04:02:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"12641c51ea31d843681315185ac8e5ae376038f8","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/whatwg/streams/pulls/524/commits","review_comments_url":"https://api.github.com/repos/whatwg/streams/pulls/524/comments","review_comment_url":"https://api.github.com/repos/whatwg/streams/pulls/comments{/number}","comments_url":"https://api.github.com/repos/whatwg/streams/issues/524/comments","statuses_url":"https://api.github.com/repos/whatwg/streams/statuses/411d966572bdb9458d21198541b8508c7fb2e123","head":{"label":"ricea:writable_streams_test_port1","ref":"writable_streams_test_port1","sha":"411d966572bdb9458d21198541b8508c7fb2e123","user":{"login":"ricea","id":6678407,"avatar_url":"https://avatars.githubusercontent.com/u/6678407?v=3","gravatar_id":"","url":"https://api.github.com/users/ricea","html_url":"https://github.com/ricea","followers_url":"https://api.github.com/users/ricea/followers","following_url":"https://api.github.com/users/ricea/following{/other_user}","gists_url":"https://api.github.com/users/ricea/gists{/gist_id}","starred_url":"https://api.github.com/users/ricea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ricea/subscriptions","organizations_url":"https://api.github.com/users/ricea/orgs","repos_url":"https://api.github.com/users/ricea/repos","events_url":"https://api.github.com/users/ricea/events{/privacy}","received_events_url":"https://api.github.com/users/ricea/received_events","type":"User","site_admin":false},"repo":{"id":64450373,"name":"streams","full_name":"ricea/streams","owner":{"login":"ricea","id":6678407,"avatar_url":"https://avatars.githubusercontent.com/u/6678407?v=3","gravatar_id":"","url":"https://api.github.com/users/ricea","html_url":"https://github.com/ricea","followers_url":"https://api.github.com/users/ricea/followers","following_url":"https://api.github.com/users/ricea/following{/other_user}","gists_url":"https://api.github.com/users/ricea/gists{/gist_id}","starred_url":"https://api.github.com/users/ricea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ricea/subscriptions","organizations_url":"https://api.github.com/users/ricea/orgs","repos_url":"https://api.github.com/users/ricea/repos","events_url":"https://api.github.com/users/ricea/events{/privacy}","received_events_url":"https://api.github.com/users/ricea/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ricea/streams","description":"Streams Standard","fork":true,"url":"https://api.github.com/repos/ricea/streams","forks_url":"https://api.github.com/repos/ricea/streams/forks","keys_url":"https://api.github.com/repos/ricea/streams/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ricea/streams/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ricea/streams/teams","hooks_url":"https://api.github.com/repos/ricea/streams/hooks","issue_events_url":"https://api.github.com/repos/ricea/streams/issues/events{/number}","events_url":"https://api.github.com/repos/ricea/streams/events","assignees_url":"https://api.github.com/repos/ricea/streams/assignees{/user}","branches_url":"https://api.github.com/repos/ricea/streams/branches{/branch}","tags_url":"https://api.github.com/repos/ricea/streams/tags","blobs_url":"https://api.github.com/repos/ricea/streams/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ricea/streams/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ricea/streams/git/refs{/sha}","trees_url":"https://api.github.com/repos/ricea/streams/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ricea/streams/statuses/{sha}","languages_url":"https://api.github.com/repos/ricea/streams/languages","stargazers_url":"https://api.github.com/repos/ricea/streams/stargazers","contributors_url":"https://api.github.com/repos/ricea/streams/contributors","subscribers_url":"https://api.github.com/repos/ricea/streams/subscribers","subscription_url":"https://api.github.com/repos/ricea/streams/subscription","commits_url":"https://api.github.com/repos/ricea/streams/commits{/sha}","git_commits_url":"https://api.github.com/repos/ricea/streams/git/commits{/sha}","comments_url":"https://api.github.com/repos/ricea/streams/comments{/number}","issue_comment_url":"https://api.github.com/repos/ricea/streams/issues/comments{/number}","contents_url":"https://api.github.com/repos/ricea/streams/contents/{+path}","compare_url":"https://api.github.com/repos/ricea/streams/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ricea/streams/merges","archive_url":"https://api.github.com/repos/ricea/streams/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ricea/streams/downloads","issues_url":"https://api.github.com/repos/ricea/streams/issues{/number}","pulls_url":"https://api.github.com/repos/ricea/streams/pulls{/number}","milestones_url":"https://api.github.com/repos/ricea/streams/milestones{/number}","notifications_url":"https://api.github.com/repos/ricea/streams/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ricea/streams/labels{/name}","releases_url":"https://api.github.com/repos/ricea/streams/releases{/id}","deployments_url":"https://api.github.com/repos/ricea/streams/deployments","created_at":"2016-07-29T04:28:21Z","updated_at":"2016-07-29T04:28:21Z","pushed_at":"2016-10-05T07:43:54Z","git_url":"git://github.com/ricea/streams.git","ssh_url":"git@github.com:ricea/streams.git","clone_url":"https://github.com/ricea/streams.git","svn_url":"https://github.com/ricea/streams","homepage":"https://streams.spec.whatwg.org/","size":1867,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"whatwg:master","ref":"master","sha":"da10fb1121cc2a4d5ceb540230084de779913cf4","user":{"login":"whatwg","id":2226336,"avatar_url":"https://avatars.githubusercontent.com/u/2226336?v=3","gravatar_id":"","url":"https://api.github.com/users/whatwg","html_url":"https://github.com/whatwg","followers_url":"https://api.github.com/users/whatwg/followers","following_url":"https://api.github.com/users/whatwg/following{/other_user}","gists_url":"https://api.github.com/users/whatwg/gists{/gist_id}","starred_url":"https://api.github.com/users/whatwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whatwg/subscriptions","organizations_url":"https://api.github.com/users/whatwg/orgs","repos_url":"https://api.github.com/users/whatwg/repos","events_url":"https://api.github.com/users/whatwg/events{/privacy}","received_events_url":"https://api.github.com/users/whatwg/received_events","type":"Organization","site_admin":false},"repo":{"id":13962843,"name":"streams","full_name":"whatwg/streams","owner":{"login":"whatwg","id":2226336,"avatar_url":"https://avatars.githubusercontent.com/u/2226336?v=3","gravatar_id":"","url":"https://api.github.com/users/whatwg","html_url":"https://github.com/whatwg","followers_url":"https://api.github.com/users/whatwg/followers","following_url":"https://api.github.com/users/whatwg/following{/other_user}","gists_url":"https://api.github.com/users/whatwg/gists{/gist_id}","starred_url":"https://api.github.com/users/whatwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whatwg/subscriptions","organizations_url":"https://api.github.com/users/whatwg/orgs","repos_url":"https://api.github.com/users/whatwg/repos","events_url":"https://api.github.com/users/whatwg/events{/privacy}","received_events_url":"https://api.github.com/users/whatwg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/whatwg/streams","description":"Streams Standard","fork":false,"url":"https://api.github.com/repos/whatwg/streams","forks_url":"https://api.github.com/repos/whatwg/streams/forks","keys_url":"https://api.github.com/repos/whatwg/streams/keys{/key_id}","collaborators_url":"https://api.github.com/repos/whatwg/streams/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/whatwg/streams/teams","hooks_url":"https://api.github.com/repos/whatwg/streams/hooks","issue_events_url":"https://api.github.com/repos/whatwg/streams/issues/events{/number}","events_url":"https://api.github.com/repos/whatwg/streams/events","assignees_url":"https://api.github.com/repos/whatwg/streams/assignees{/user}","branches_url":"https://api.github.com/repos/whatwg/streams/branches{/branch}","tags_url":"https://api.github.com/repos/whatwg/streams/tags","blobs_url":"https://api.github.com/repos/whatwg/streams/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/whatwg/streams/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/whatwg/streams/git/refs{/sha}","trees_url":"https://api.github.com/repos/whatwg/streams/git/trees{/sha}","statuses_url":"https://api.github.com/repos/whatwg/streams/statuses/{sha}","languages_url":"https://api.github.com/repos/whatwg/streams/languages","stargazers_url":"https://api.github.com/repos/whatwg/streams/stargazers","contributors_url":"https://api.github.com/repos/whatwg/streams/contributors","subscribers_url":"https://api.github.com/repos/whatwg/streams/subscribers","subscription_url":"https://api.github.com/repos/whatwg/streams/subscription","commits_url":"https://api.github.com/repos/whatwg/streams/commits{/sha}","git_commits_url":"https://api.github.com/repos/whatwg/streams/git/commits{/sha}","comments_url":"https://api.github.com/repos/whatwg/streams/comments{/number}","issue_comment_url":"https://api.github.com/repos/whatwg/streams/issues/comments{/number}","contents_url":"https://api.github.com/repos/whatwg/streams/contents/{+path}","compare_url":"https://api.github.com/repos/whatwg/streams/compare/{base}...{head}","merges_url":"https://api.github.com/repos/whatwg/streams/merges","archive_url":"https://api.github.com/repos/whatwg/streams/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/whatwg/streams/downloads","issues_url":"https://api.github.com/repos/whatwg/streams/issues{/number}","pulls_url":"https://api.github.com/repos/whatwg/streams/pulls{/number}","milestones_url":"https://api.github.com/repos/whatwg/streams/milestones{/number}","notifications_url":"https://api.github.com/repos/whatwg/streams/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/whatwg/streams/labels{/name}","releases_url":"https://api.github.com/repos/whatwg/streams/releases{/id}","deployments_url":"https://api.github.com/repos/whatwg/streams/deployments","created_at":"2013-10-29T17:16:58Z","updated_at":"2016-10-04T02:17:10Z","pushed_at":"2016-10-05T07:46:34Z","git_url":"git://github.com/whatwg/streams.git","ssh_url":"git@github.com:whatwg/streams.git","clone_url":"https://github.com/whatwg/streams.git","svn_url":"https://github.com/whatwg/streams","homepage":"https://streams.spec.whatwg.org/","size":2548,"stargazers_count":579,"watchers_count":579,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":53,"mirror_url":null,"open_issues_count":54,"forks":53,"open_issues":54,"watchers":579,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/whatwg/streams/pulls/524"},"html":{"href":"https://github.com/whatwg/streams/pull/524"},"issue":{"href":"https://api.github.com/repos/whatwg/streams/issues/524"},"comments":{"href":"https://api.github.com/repos/whatwg/streams/issues/524/comments"},"review_comments":{"href":"https://api.github.com/repos/whatwg/streams/pulls/524/comments"},"review_comment":{"href":"https://api.github.com/repos/whatwg/streams/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/whatwg/streams/pulls/524/commits"},"statuses":{"href":"https://api.github.com/repos/whatwg/streams/statuses/411d966572bdb9458d21198541b8508c7fb2e123"}}}}
{"actor":{"display_login":"tyoshino"}}