{"action":"opened","number":36372,"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/36372","id":84744063,"html_url":"https://github.com/rust-lang/rust/pull/36372","diff_url":"https://github.com/rust-lang/rust/pull/36372.diff","patch_url":"https://github.com/rust-lang/rust/pull/36372.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/36372","number":36372,"state":"open","locked":false,"title":"Inherit overflow checks for sum and product","user":{"login":"sfackler","id":1455697,"avatar_url":"https://avatars.githubusercontent.com/u/1455697?v=3","gravatar_id":"","url":"https://api.github.com/users/sfackler","html_url":"https://github.com/sfackler","followers_url":"https://api.github.com/users/sfackler/followers","following_url":"https://api.github.com/users/sfackler/following{/other_user}","gists_url":"https://api.github.com/users/sfackler/gists{/gist_id}","starred_url":"https://api.github.com/users/sfackler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sfackler/subscriptions","organizations_url":"https://api.github.com/users/sfackler/orgs","repos_url":"https://api.github.com/users/sfackler/repos","events_url":"https://api.github.com/users/sfackler/events{/privacy}","received_events_url":"https://api.github.com/users/sfackler/received_events","type":"User","site_admin":false},"body":"We have previously documented the fact that these will panic on overflow, but I think this behavior is what people actually want/expect.\r\n\r\nr? @alexcrichton \r\n\r\nCloses #35807","created_at":"2016-09-10T04:09:26Z","updated_at":"2016-09-10T04:09:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/36372/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/36372/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/36372/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/57e7c78460f568c3ad3fb217841b6f90a7229f1c","head":{"label":"sfackler:sum-prod-overflow","ref":"sum-prod-overflow","sha":"57e7c78460f568c3ad3fb217841b6f90a7229f1c","user":{"login":"sfackler","id":1455697,"avatar_url":"https://avatars.githubusercontent.com/u/1455697?v=3","gravatar_id":"","url":"https://api.github.com/users/sfackler","html_url":"https://github.com/sfackler","followers_url":"https://api.github.com/users/sfackler/followers","following_url":"https://api.github.com/users/sfackler/following{/other_user}","gists_url":"https://api.github.com/users/sfackler/gists{/gist_id}","starred_url":"https://api.github.com/users/sfackler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sfackler/subscriptions","organizations_url":"https://api.github.com/users/sfackler/orgs","repos_url":"https://api.github.com/users/sfackler/repos","events_url":"https://api.github.com/users/sfackler/events{/privacy}","received_events_url":"https://api.github.com/users/sfackler/received_events","type":"User","site_admin":false},"repo":{"id":10324482,"name":"rust","full_name":"sfackler/rust","owner":{"login":"sfackler","id":1455697,"avatar_url":"https://avatars.githubusercontent.com/u/1455697?v=3","gravatar_id":"","url":"https://api.github.com/users/sfackler","html_url":"https://github.com/sfackler","followers_url":"https://api.github.com/users/sfackler/followers","following_url":"https://api.github.com/users/sfackler/following{/other_user}","gists_url":"https://api.github.com/users/sfackler/gists{/gist_id}","starred_url":"https://api.github.com/users/sfackler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sfackler/subscriptions","organizations_url":"https://api.github.com/users/sfackler/orgs","repos_url":"https://api.github.com/users/sfackler/repos","events_url":"https://api.github.com/users/sfackler/events{/privacy}","received_events_url":"https://api.github.com/users/sfackler/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sfackler/rust","description":"a safe, concurrent, practical language","fork":true,"url":"https://api.github.com/repos/sfackler/rust","forks_url":"https://api.github.com/repos/sfackler/rust/forks","keys_url":"https://api.github.com/repos/sfackler/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sfackler/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sfackler/rust/teams","hooks_url":"https://api.github.com/repos/sfackler/rust/hooks","issue_events_url":"https://api.github.com/repos/sfackler/rust/issues/events{/number}","events_url":"https://api.github.com/repos/sfackler/rust/events","assignees_url":"https://api.github.com/repos/sfackler/rust/assignees{/user}","branches_url":"https://api.github.com/repos/sfackler/rust/branches{/branch}","tags_url":"https://api.github.com/repos/sfackler/rust/tags","blobs_url":"https://api.github.com/repos/sfackler/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sfackler/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sfackler/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/sfackler/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sfackler/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/sfackler/rust/languages","stargazers_url":"https://api.github.com/repos/sfackler/rust/stargazers","contributors_url":"https://api.github.com/repos/sfackler/rust/contributors","subscribers_url":"https://api.github.com/repos/sfackler/rust/subscribers","subscription_url":"https://api.github.com/repos/sfackler/rust/subscription","commits_url":"https://api.github.com/repos/sfackler/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/sfackler/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/sfackler/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/sfackler/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/sfackler/rust/contents/{+path}","compare_url":"https://api.github.com/repos/sfackler/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sfackler/rust/merges","archive_url":"https://api.github.com/repos/sfackler/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sfackler/rust/downloads","issues_url":"https://api.github.com/repos/sfackler/rust/issues{/number}","pulls_url":"https://api.github.com/repos/sfackler/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/sfackler/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/sfackler/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sfackler/rust/labels{/name}","releases_url":"https://api.github.com/repos/sfackler/rust/releases{/id}","deployments_url":"https://api.github.com/repos/sfackler/rust/deployments","created_at":"2013-05-27T23:45:53Z","updated_at":"2015-01-07T05:08:25Z","pushed_at":"2016-09-10T04:08:38Z","git_url":"git://github.com/sfackler/rust.git","ssh_url":"git@github.com:sfackler/rust.git","clone_url":"https://github.com/sfackler/rust.git","svn_url":"https://github.com/sfackler/rust","homepage":"http://www.rust-lang.org","size":297202,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"f1f40f850e2546c2c187514e3d61d17544ba433f","user":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"name":"rust","full_name":"rust-lang/rust","owner":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/rust","description":"A safe, concurrent, practical language.","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","deployments_url":"https://api.github.com/repos/rust-lang/rust/deployments","created_at":"2010-06-16T20:39:03Z","updated_at":"2016-09-10T03:00:37Z","pushed_at":"2016-09-10T04:09:26Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"git@github.com:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"https://www.rust-lang.org","size":509609,"stargazers_count":18227,"watchers_count":18227,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3516,"mirror_url":null,"open_issues_count":2790,"forks":3516,"open_issues":2790,"watchers":18227,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/36372"},"html":{"href":"https://github.com/rust-lang/rust/pull/36372"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/36372"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/36372/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/36372/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/36372/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/57e7c78460f568c3ad3fb217841b6f90a7229f1c"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":69,"deletions":6,"changed_files":4}}
{"actor":{"display_login":"sfackler"}}