{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/comments/57355584","id":57355584,"diff_hunk":"@@ -40,7 +40,42 @@ describe('manifest: icons-192 audit', () => {\n     return assert.equal(Audit.audit(inputs).value, false);\n   });\n \n+  it('fails when a manifest contains an icon with no size', () => {\n+    const manifestSrc = JSON.stringify({\n+      icons: [{\n+        src: 'icon.png'\n+      }]\n+    });\n+    const manifest = manifestParser(manifestSrc).value;","path":"test/audits/manifest/icons-192.js","position":10,"original_position":10,"commit_id":"baa0af53319657949286dfcf02ebfeb58abc635a","original_commit_id":"baa0af53319657949286dfcf02ebfeb58abc635a","user":{"login":"brendankenny","id":316891,"avatar_url":"https://avatars.githubusercontent.com/u/316891?v=3","gravatar_id":"","url":"https://api.github.com/users/brendankenny","html_url":"https://github.com/brendankenny","followers_url":"https://api.github.com/users/brendankenny/followers","following_url":"https://api.github.com/users/brendankenny/following{/other_user}","gists_url":"https://api.github.com/users/brendankenny/gists{/gist_id}","starred_url":"https://api.github.com/users/brendankenny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brendankenny/subscriptions","organizations_url":"https://api.github.com/users/brendankenny/orgs","repos_url":"https://api.github.com/users/brendankenny/repos","events_url":"https://api.github.com/users/brendankenny/events{/privacy}","received_events_url":"https://api.github.com/users/brendankenny/received_events","type":"User","site_admin":false},"body":"that was intentional, because we have sane variable scope and to keep things parallel to other tests, but I can rename to something else","created_at":"2016-03-24T17:34:11Z","updated_at":"2016-03-24T17:34:11Z","html_url":"https://github.com/GoogleChrome/lighthouse/pull/71#discussion_r57355584","pull_request_url":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/71","_links":{"self":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/comments/57355584"},"html":{"href":"https://github.com/GoogleChrome/lighthouse/pull/71#discussion_r57355584"},"pull_request":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/71"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/71","id":63929456,"html_url":"https://github.com/GoogleChrome/lighthouse/pull/71","diff_url":"https://github.com/GoogleChrome/lighthouse/pull/71.diff","patch_url":"https://github.com/GoogleChrome/lighthouse/pull/71.patch","issue_url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/71","number":71,"state":"open","locked":false,"title":"add a few more icon-192 tests","user":{"login":"brendankenny","id":316891,"avatar_url":"https://avatars.githubusercontent.com/u/316891?v=3","gravatar_id":"","url":"https://api.github.com/users/brendankenny","html_url":"https://github.com/brendankenny","followers_url":"https://api.github.com/users/brendankenny/followers","following_url":"https://api.github.com/users/brendankenny/following{/other_user}","gists_url":"https://api.github.com/users/brendankenny/gists{/gist_id}","starred_url":"https://api.github.com/users/brendankenny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brendankenny/subscriptions","organizations_url":"https://api.github.com/users/brendankenny/orgs","repos_url":"https://api.github.com/users/brendankenny/repos","events_url":"https://api.github.com/users/brendankenny/events{/privacy}","received_events_url":"https://api.github.com/users/brendankenny/received_events","type":"User","site_admin":false},"body":"also fixes a TypeError in the icon-192 audit when a manifest has an icon with no list of sizes","created_at":"2016-03-23T18:21:23Z","updated_at":"2016-03-24T17:34:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"51eb782783d082993632c9e81721c48e4164adfd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/71/commits","review_comments_url":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/71/comments","review_comment_url":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/71/comments","statuses_url":"https://api.github.com/repos/GoogleChrome/lighthouse/statuses/baa0af53319657949286dfcf02ebfeb58abc635a","head":{"label":"brendankenny:icon192test","ref":"icon192test","sha":"baa0af53319657949286dfcf02ebfeb58abc635a","user":{"login":"brendankenny","id":316891,"avatar_url":"https://avatars.githubusercontent.com/u/316891?v=3","gravatar_id":"","url":"https://api.github.com/users/brendankenny","html_url":"https://github.com/brendankenny","followers_url":"https://api.github.com/users/brendankenny/followers","following_url":"https://api.github.com/users/brendankenny/following{/other_user}","gists_url":"https://api.github.com/users/brendankenny/gists{/gist_id}","starred_url":"https://api.github.com/users/brendankenny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brendankenny/subscriptions","organizations_url":"https://api.github.com/users/brendankenny/orgs","repos_url":"https://api.github.com/users/brendankenny/repos","events_url":"https://api.github.com/users/brendankenny/events{/privacy}","received_events_url":"https://api.github.com/users/brendankenny/received_events","type":"User","site_admin":false},"repo":{"id":53702738,"name":"lighthouse","full_name":"brendankenny/lighthouse","owner":{"login":"brendankenny","id":316891,"avatar_url":"https://avatars.githubusercontent.com/u/316891?v=3","gravatar_id":"","url":"https://api.github.com/users/brendankenny","html_url":"https://github.com/brendankenny","followers_url":"https://api.github.com/users/brendankenny/followers","following_url":"https://api.github.com/users/brendankenny/following{/other_user}","gists_url":"https://api.github.com/users/brendankenny/gists{/gist_id}","starred_url":"https://api.github.com/users/brendankenny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brendankenny/subscriptions","organizations_url":"https://api.github.com/users/brendankenny/orgs","repos_url":"https://api.github.com/users/brendankenny/repos","events_url":"https://api.github.com/users/brendankenny/events{/privacy}","received_events_url":"https://api.github.com/users/brendankenny/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brendankenny/lighthouse","description":null,"fork":true,"url":"https://api.github.com/repos/brendankenny/lighthouse","forks_url":"https://api.github.com/repos/brendankenny/lighthouse/forks","keys_url":"https://api.github.com/repos/brendankenny/lighthouse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brendankenny/lighthouse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brendankenny/lighthouse/teams","hooks_url":"https://api.github.com/repos/brendankenny/lighthouse/hooks","issue_events_url":"https://api.github.com/repos/brendankenny/lighthouse/issues/events{/number}","events_url":"https://api.github.com/repos/brendankenny/lighthouse/events","assignees_url":"https://api.github.com/repos/brendankenny/lighthouse/assignees{/user}","branches_url":"https://api.github.com/repos/brendankenny/lighthouse/branches{/branch}","tags_url":"https://api.github.com/repos/brendankenny/lighthouse/tags","blobs_url":"https://api.github.com/repos/brendankenny/lighthouse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brendankenny/lighthouse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brendankenny/lighthouse/git/refs{/sha}","trees_url":"https://api.github.com/repos/brendankenny/lighthouse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brendankenny/lighthouse/statuses/{sha}","languages_url":"https://api.github.com/repos/brendankenny/lighthouse/languages","stargazers_url":"https://api.github.com/repos/brendankenny/lighthouse/stargazers","contributors_url":"https://api.github.com/repos/brendankenny/lighthouse/contributors","subscribers_url":"https://api.github.com/repos/brendankenny/lighthouse/subscribers","subscription_url":"https://api.github.com/repos/brendankenny/lighthouse/subscription","commits_url":"https://api.github.com/repos/brendankenny/lighthouse/commits{/sha}","git_commits_url":"https://api.github.com/repos/brendankenny/lighthouse/git/commits{/sha}","comments_url":"https://api.github.com/repos/brendankenny/lighthouse/comments{/number}","issue_comment_url":"https://api.github.com/repos/brendankenny/lighthouse/issues/comments{/number}","contents_url":"https://api.github.com/repos/brendankenny/lighthouse/contents/{+path}","compare_url":"https://api.github.com/repos/brendankenny/lighthouse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brendankenny/lighthouse/merges","archive_url":"https://api.github.com/repos/brendankenny/lighthouse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brendankenny/lighthouse/downloads","issues_url":"https://api.github.com/repos/brendankenny/lighthouse/issues{/number}","pulls_url":"https://api.github.com/repos/brendankenny/lighthouse/pulls{/number}","milestones_url":"https://api.github.com/repos/brendankenny/lighthouse/milestones{/number}","notifications_url":"https://api.github.com/repos/brendankenny/lighthouse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brendankenny/lighthouse/labels{/name}","releases_url":"https://api.github.com/repos/brendankenny/lighthouse/releases{/id}","deployments_url":"https://api.github.com/repos/brendankenny/lighthouse/deployments","created_at":"2016-03-11T23:23:05Z","updated_at":"2016-03-11T23:23:06Z","pushed_at":"2016-03-24T05:57:17Z","git_url":"git://github.com/brendankenny/lighthouse.git","ssh_url":"git@github.com:brendankenny/lighthouse.git","clone_url":"https://github.com/brendankenny/lighthouse.git","svn_url":"https://github.com/brendankenny/lighthouse","homepage":null,"size":2274,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleChrome:master","ref":"master","sha":"666c0369d00b6ed323e7d3f14d816eb26cb426f7","user":{"login":"GoogleChrome","id":1778935,"avatar_url":"https://avatars.githubusercontent.com/u/1778935?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleChrome","html_url":"https://github.com/GoogleChrome","followers_url":"https://api.github.com/users/GoogleChrome/followers","following_url":"https://api.github.com/users/GoogleChrome/following{/other_user}","gists_url":"https://api.github.com/users/GoogleChrome/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleChrome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleChrome/subscriptions","organizations_url":"https://api.github.com/users/GoogleChrome/orgs","repos_url":"https://api.github.com/users/GoogleChrome/repos","events_url":"https://api.github.com/users/GoogleChrome/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleChrome/received_events","type":"Organization","site_admin":false},"repo":{"id":53370988,"name":"lighthouse","full_name":"GoogleChrome/lighthouse","owner":{"login":"GoogleChrome","id":1778935,"avatar_url":"https://avatars.githubusercontent.com/u/1778935?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleChrome","html_url":"https://github.com/GoogleChrome","followers_url":"https://api.github.com/users/GoogleChrome/followers","following_url":"https://api.github.com/users/GoogleChrome/following{/other_user}","gists_url":"https://api.github.com/users/GoogleChrome/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleChrome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleChrome/subscriptions","organizations_url":"https://api.github.com/users/GoogleChrome/orgs","repos_url":"https://api.github.com/users/GoogleChrome/repos","events_url":"https://api.github.com/users/GoogleChrome/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleChrome/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleChrome/lighthouse","description":null,"fork":false,"url":"https://api.github.com/repos/GoogleChrome/lighthouse","forks_url":"https://api.github.com/repos/GoogleChrome/lighthouse/forks","keys_url":"https://api.github.com/repos/GoogleChrome/lighthouse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleChrome/lighthouse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleChrome/lighthouse/teams","hooks_url":"https://api.github.com/repos/GoogleChrome/lighthouse/hooks","issue_events_url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleChrome/lighthouse/events","assignees_url":"https://api.github.com/repos/GoogleChrome/lighthouse/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleChrome/lighthouse/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleChrome/lighthouse/tags","blobs_url":"https://api.github.com/repos/GoogleChrome/lighthouse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleChrome/lighthouse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleChrome/lighthouse/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleChrome/lighthouse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleChrome/lighthouse/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleChrome/lighthouse/languages","stargazers_url":"https://api.github.com/repos/GoogleChrome/lighthouse/stargazers","contributors_url":"https://api.github.com/repos/GoogleChrome/lighthouse/contributors","subscribers_url":"https://api.github.com/repos/GoogleChrome/lighthouse/subscribers","subscription_url":"https://api.github.com/repos/GoogleChrome/lighthouse/subscription","commits_url":"https://api.github.com/repos/GoogleChrome/lighthouse/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleChrome/lighthouse/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleChrome/lighthouse/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleChrome/lighthouse/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleChrome/lighthouse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleChrome/lighthouse/merges","archive_url":"https://api.github.com/repos/GoogleChrome/lighthouse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleChrome/lighthouse/downloads","issues_url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleChrome/lighthouse/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleChrome/lighthouse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleChrome/lighthouse/labels{/name}","releases_url":"https://api.github.com/repos/GoogleChrome/lighthouse/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleChrome/lighthouse/deployments","created_at":"2016-03-08T01:03:11Z","updated_at":"2016-03-24T07:58:30Z","pushed_at":"2016-03-24T17:29:07Z","git_url":"git://github.com/GoogleChrome/lighthouse.git","ssh_url":"git@github.com:GoogleChrome/lighthouse.git","clone_url":"https://github.com/GoogleChrome/lighthouse.git","svn_url":"https://github.com/GoogleChrome/lighthouse","homepage":null,"size":2327,"stargazers_count":51,"watchers_count":51,"language":"JavaScript","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":27,"forks":9,"open_issues":27,"watchers":51,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/71"},"html":{"href":"https://github.com/GoogleChrome/lighthouse/pull/71"},"issue":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/71"},"comments":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/71/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/71/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/71/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/statuses/baa0af53319657949286dfcf02ebfeb58abc635a"}}}}