{"action":"created","issue":{"url":"https://api.github.com/repos/ipld/js-ipld-dag-pb/issues/7","repository_url":"https://api.github.com/repos/ipld/js-ipld-dag-pb","labels_url":"https://api.github.com/repos/ipld/js-ipld-dag-pb/issues/7/labels{/name}","comments_url":"https://api.github.com/repos/ipld/js-ipld-dag-pb/issues/7/comments","events_url":"https://api.github.com/repos/ipld/js-ipld-dag-pb/issues/7/events","html_url":"https://github.com/ipld/js-ipld-dag-pb/pull/7","id":189140366,"number":7,"title":"Rebase on feat/immutable","user":{"login":"haadcode","id":7499694,"avatar_url":"https://avatars.githubusercontent.com/u/7499694?v=3","gravatar_id":"","url":"https://api.github.com/users/haadcode","html_url":"https://github.com/haadcode","followers_url":"https://api.github.com/users/haadcode/followers","following_url":"https://api.github.com/users/haadcode/following{/other_user}","gists_url":"https://api.github.com/users/haadcode/gists{/gist_id}","starred_url":"https://api.github.com/users/haadcode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haadcode/subscriptions","organizations_url":"https://api.github.com/users/haadcode/orgs","repos_url":"https://api.github.com/users/haadcode/repos","events_url":"https://api.github.com/users/haadcode/events{/privacy}","received_events_url":"https://api.github.com/users/haadcode/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-11-14T15:24:51Z","updated_at":"2016-11-14T15:47:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ipld/js-ipld-dag-pb/pulls/7","html_url":"https://github.com/ipld/js-ipld-dag-pb/pull/7","diff_url":"https://github.com/ipld/js-ipld-dag-pb/pull/7.diff","patch_url":"https://github.com/ipld/js-ipld-dag-pb/pull/7.patch"},"body":"Refactored https://github.com/ipld/js-ipld-dag-pb/pull/6"},"comment":{"url":"https://api.github.com/repos/ipld/js-ipld-dag-pb/issues/comments/260371998","html_url":"https://github.com/ipld/js-ipld-dag-pb/pull/7#issuecomment-260371998","issue_url":"https://api.github.com/repos/ipld/js-ipld-dag-pb/issues/7","id":260371998,"user":{"login":"diasdavid","id":1211152,"avatar_url":"https://avatars.githubusercontent.com/u/1211152?v=3","gravatar_id":"","url":"https://api.github.com/users/diasdavid","html_url":"https://github.com/diasdavid","followers_url":"https://api.github.com/users/diasdavid/followers","following_url":"https://api.github.com/users/diasdavid/following{/other_user}","gists_url":"https://api.github.com/users/diasdavid/gists{/gist_id}","starred_url":"https://api.github.com/users/diasdavid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diasdavid/subscriptions","organizations_url":"https://api.github.com/users/diasdavid/orgs","repos_url":"https://api.github.com/users/diasdavid/repos","events_url":"https://api.github.com/users/diasdavid/events{/privacy}","received_events_url":"https://api.github.com/users/diasdavid/received_events","type":"User","site_admin":false},"created_at":"2016-11-14T15:47:48Z","updated_at":"2016-11-14T15:47:48Z","body":"Thank you for giving a thorough review and coming up with a new structure. I've made a fair amount of comments, it would be ideal if tests were passing so that we know the PR is correct (you will see comments showing on why it's not).\r\n\r\nThings I like and will certainly adopt for https://github.com/ipld/js-ipld-dag-pb/pull/6:\r\n\r\n- Avoiding Object.defineProperty, as also mentioned by @dignifiedquire (https://github.com/ipld/js-ipld-dag-pb/pull/6#discussion_r87779504)\r\n- Factoring out the create function, so that the DAGNode file is less long\r\n- Make .json a .toJSON sync function\r\n\r\nThings I'm not in favour and given our previous discussions, they won't be included in the main PR\r\n\r\n- Migration to Promises for internals as noted and justified at : https://github.com/ipld/js-ipld-dag-pb/pull/7#discussion_r87823617\r\n  - Note: It might make sense to support also a promises API for the .create function since it is a top level consumed object (from ipfs.object.get), so that people don't have their promise chain broken, however, we are not dropping callbacks.\r\n\r\nThings that don't make sense to me to have throughout our codebase:\r\n\r\n- Define \"Classes with static methods just to export a bunch of functions\" instead of exporting functions with the conventional module.exports. It is mostly a style/convention change which doesn't add any benefit."}}
{"actor":{"display_login":"diasdavid"}}