{"action":"created","issue":{"url":"https://api.github.com/repos/fewd-sg/homework-week-5/issues/13","repository_url":"https://api.github.com/repos/fewd-sg/homework-week-5","labels_url":"https://api.github.com/repos/fewd-sg/homework-week-5/issues/13/labels{/name}","comments_url":"https://api.github.com/repos/fewd-sg/homework-week-5/issues/13/comments","events_url":"https://api.github.com/repos/fewd-sg/homework-week-5/issues/13/events","html_url":"https://github.com/fewd-sg/homework-week-5/pull/13","id":177154309,"number":13,"title":"Leeyee week 5 submission","user":{"login":"leeyee32","id":20722891,"avatar_url":"https://avatars.githubusercontent.com/u/20722891?v=3","gravatar_id":"","url":"https://api.github.com/users/leeyee32","html_url":"https://github.com/leeyee32","followers_url":"https://api.github.com/users/leeyee32/followers","following_url":"https://api.github.com/users/leeyee32/following{/other_user}","gists_url":"https://api.github.com/users/leeyee32/gists{/gist_id}","starred_url":"https://api.github.com/users/leeyee32/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leeyee32/subscriptions","organizations_url":"https://api.github.com/users/leeyee32/orgs","repos_url":"https://api.github.com/users/leeyee32/repos","events_url":"https://api.github.com/users/leeyee32/events{/privacy}","received_events_url":"https://api.github.com/users/leeyee32/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"spinningarrow","id":1797328,"avatar_url":"https://avatars.githubusercontent.com/u/1797328?v=3","gravatar_id":"","url":"https://api.github.com/users/spinningarrow","html_url":"https://github.com/spinningarrow","followers_url":"https://api.github.com/users/spinningarrow/followers","following_url":"https://api.github.com/users/spinningarrow/following{/other_user}","gists_url":"https://api.github.com/users/spinningarrow/gists{/gist_id}","starred_url":"https://api.github.com/users/spinningarrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spinningarrow/subscriptions","organizations_url":"https://api.github.com/users/spinningarrow/orgs","repos_url":"https://api.github.com/users/spinningarrow/repos","events_url":"https://api.github.com/users/spinningarrow/events{/privacy}","received_events_url":"https://api.github.com/users/spinningarrow/received_events","type":"User","site_admin":false},"assignees":[{"login":"spinningarrow","id":1797328,"avatar_url":"https://avatars.githubusercontent.com/u/1797328?v=3","gravatar_id":"","url":"https://api.github.com/users/spinningarrow","html_url":"https://github.com/spinningarrow","followers_url":"https://api.github.com/users/spinningarrow/followers","following_url":"https://api.github.com/users/spinningarrow/following{/other_user}","gists_url":"https://api.github.com/users/spinningarrow/gists{/gist_id}","starred_url":"https://api.github.com/users/spinningarrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spinningarrow/subscriptions","organizations_url":"https://api.github.com/users/spinningarrow/orgs","repos_url":"https://api.github.com/users/spinningarrow/repos","events_url":"https://api.github.com/users/spinningarrow/events{/privacy}","received_events_url":"https://api.github.com/users/spinningarrow/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2016-09-15T11:40:40Z","updated_at":"2016-10-03T14:40:05Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/fewd-sg/homework-week-5/pulls/13","html_url":"https://github.com/fewd-sg/homework-week-5/pull/13","diff_url":"https://github.com/fewd-sg/homework-week-5/pull/13.diff","patch_url":"https://github.com/fewd-sg/homework-week-5/pull/13.patch"},"body":"Leeyee week 5 submission"},"comment":{"url":"https://api.github.com/repos/fewd-sg/homework-week-5/issues/comments/251123670","html_url":"https://github.com/fewd-sg/homework-week-5/pull/13#issuecomment-251123670","issue_url":"https://api.github.com/repos/fewd-sg/homework-week-5/issues/13","id":251123670,"user":{"login":"spinningarrow","id":1797328,"avatar_url":"https://avatars.githubusercontent.com/u/1797328?v=3","gravatar_id":"","url":"https://api.github.com/users/spinningarrow","html_url":"https://github.com/spinningarrow","followers_url":"https://api.github.com/users/spinningarrow/followers","following_url":"https://api.github.com/users/spinningarrow/following{/other_user}","gists_url":"https://api.github.com/users/spinningarrow/gists{/gist_id}","starred_url":"https://api.github.com/users/spinningarrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spinningarrow/subscriptions","organizations_url":"https://api.github.com/users/spinningarrow/orgs","repos_url":"https://api.github.com/users/spinningarrow/repos","events_url":"https://api.github.com/users/spinningarrow/events{/privacy}","received_events_url":"https://api.github.com/users/spinningarrow/received_events","type":"User","site_admin":false},"created_at":"2016-10-03T14:40:05Z","updated_at":"2016-10-03T14:40:05Z","body":"Great work! Your submission works well, and even \"cleans\" the user input – nice! Here's some feedback:\r\n\r\n- Good on you for trying to use jQuery even though it hadn't been taught in the class at this point! Though I always say, it pays to get familiar with \"vanilla\" (non-jQuery) JavaScript as well 🙂\r\n- Really liked that you cleaned up the user's input before comparing it by using `trim` and `toLowerCase`! A small note: if you're using `trim` then you don't need the `.replace(/^\\s+|\\s+$/g,\"\")` at the end - they both do the same thing. General rule of thumb - if there's a function that can do the same thing that a regular expression does, use the function since it's clearer.\r\n- Try to indent your code more consistently - it makes it clearer! There are plugins available for most text editors that can auto-indent for you.\r\n\r\n# Rubrics: FEWD Week #5 Project: More JavaScript\r\n\r\n|                                                                                                                               |                                |                        |                          |\r\n|-------------------------------------------------------------------------------------------------------------------------------|--------------------------------|------------------------|--------------------------|\r\n| Technical Requirements                                                                                                        | Does Not Meet Expectations (0) | Meets Expectations (1) | Exceeds Expectations (2) |\r\n| Get the string value of your user's input                                                     |                                |                        |           ✔️               |\r\n| Store user input in `var city`                                                                                            |                                |            ✔️            |                          |\r\n| Use `onclick` to figure out when the user clicks the \"submit\" button                                      |                                |                        |          ✔️                |\r\n| Create `if / else if / else` conditionals to control the flow of your application                                         |                                |           ✔️             |                          |\r\n| Write at least six different lines of pseudocode and display them inline as JavaScript comments                               |                                |                        |          ✔️                |\r\n| Use the ```||``` operator in your conditionals to allow for multiple string values to execute ```if/else if``` statement code |                                |           ✔️             |                          |\r\n| If a user submits \"New York\" or \"New York City\" or \"NYC\" make the background of the page nyc.jpg                              |                                |             ✔️           |                          |\r\n| If a user submits \"San Francisco\" or \"SF\" or \"Bay Area\" make the background of the page sf.jpg                                |                                |         ✔️               |                          |\r\n| If a user submits \"Los Angeles\" or \"LA\" or \"LAX\" make the background of the page la.jpg                                       |                                |       ✔️                 |                          |\r\n| If a user submits \"Austin\" or \"ATX\" make the background of the page austin.jpg                                                |                                |         ✔️               |                          |\r\n| If a user submits \"Sydney\" or \"SYD\" make the background of the page sydney.jpg                                                |                                |          ✔️              |                          |"}}
{"actor":{"display_login":"spinningarrow"}}