{"action":"created","issue":{"url":"https://api.github.com/repos/raffenet/mpich-migrate-test/issues/208","repository_url":"https://api.github.com/repos/raffenet/mpich-migrate-test","labels_url":"https://api.github.com/repos/raffenet/mpich-migrate-test/issues/208/labels{/name}","comments_url":"https://api.github.com/repos/raffenet/mpich-migrate-test/issues/208/comments","events_url":"https://api.github.com/repos/raffenet/mpich-migrate-test/issues/208/events","html_url":"https://github.com/raffenet/mpich-migrate-test/issues/208","id":167982486,"number":208,"title":"FW: [mpich-discuss] mpich2-1.0.7 file mpif.h and fortran compiler g95","user":{"login":"raffenet","id":1410792,"avatar_url":"https://avatars.githubusercontent.com/u/1410792?v=3","gravatar_id":"","url":"https://api.github.com/users/raffenet","html_url":"https://github.com/raffenet","followers_url":"https://api.github.com/users/raffenet/followers","following_url":"https://api.github.com/users/raffenet/following{/other_user}","gists_url":"https://api.github.com/users/raffenet/gists{/gist_id}","starred_url":"https://api.github.com/users/raffenet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raffenet/subscriptions","organizations_url":"https://api.github.com/users/raffenet/orgs","repos_url":"https://api.github.com/users/raffenet/repos","events_url":"https://api.github.com/users/raffenet/events{/privacy}","received_events_url":"https://api.github.com/users/raffenet/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-07-27T23:46:48Z","updated_at":"2016-07-27T23:46:49Z","closed_at":null,"body":"**Originally by _\"Rajeev Thakur\" <thakur@mcs.anl.gov>_ on 2008-10-11 10:22:05 -0500**\n\n___\n\n\n```\n\n\n\n-----Original Message-----\nFrom: owner-mpich-discuss@mcs.anl.gov\n[mailto:owner-mpich-discuss@mcs.anl.gov] On Behalf Of\ncornelis.broeders@web.de\nSent: Saturday, October 11, 2008 5:34 AM\nTo: mpich-discuss@mcs.anl.gov\nSubject: Re: [mpich-discuss] mpich2-1.0.7 file mpif.h and fortran compiler\ng95\n\nproblem is reproducable with following procedures:\n\n1) create file savetest.F with 4 lines:\n\n     save\n#include \"sav.h\"\n      stop\n      end\n\n2) create file sav.h with 2 lines:\n\n      integer*4 j\n      save j\n\n3) run g95 result:\n\ng95 -o savetest savetest.F\nIn file sav.h:2\n\n    Included at savetest.F:2\n\n      save j\n\n\n          1\nError: SAVE statement at (1) follows blanket SAVE statement\n\n4) for completeness gfortran:\n\ngfortran -o savetest savetest.F\nsav.h:2.10:\n    Included at savetest.F:3:\n\n      save j\n         1\nWarning: SAVE statement at (1) follows blanket SAVE statement\nsav.h:1.17:\n    Included at savetest.F:3:\n\n      integer*4 j\n                1\nWarning: Duplicate SAVE attribute specified at (1)\n\nI hope this information helps.\n\nC.H.M. Broeders     http://www.cornelis-broeders.de\n\n\n> -----Ursprüngliche Nachricht-----\n> Von: \"Anthony Chan\" <chan@mcs.anl.gov>\n> Gesendet: 10.10.08 22:23:43\n> An: mpich-discuss@mcs.anl.gov\n> Betreff: Re: [mpich-discuss] mpich2-1.0.7 file mpif.h and fortran\n> compiler g95\n\n\n>\n> I don't see mpif.h has any \"blanket\" SAVE statement (assume I don't\n> misinterpret what a \"blanket\" SAVE is).  To help us understand the\n> issue, can you send us a simple fortran MPI program that illustrates\n> the need of such a construct in mpif.h ?\n>\n> Thanks,\n> A.Chan\n>\n> ----- \"cornelis broeders\" <cornelis.broeders@web.de> wrote:\n>\n> > Hello,\n> > I encountered the error message \"SAVE statement at (1) follows\n> > blanket SAVE statement\"  during installation of the huge package\n> > mcnpx. After some efforts I found that this message is generally\n> > issued by g95 (and\n> > gfortran?) if a program with a previous \"save\" statement includes a\n> > file, like mpif.h, containing  \"save var\" statements. Putting the\n> > SAVE statements of mpif.h in an exclude construct \"#ifndef G95  ...\n> > #endif solved my problem. I propose to include such kind of patch\n> > for g95 in future releases of mpich2. Could somebody comment on this\nproposal?\n> > Best regards,\n> >\n> >\n> >\n> > C.H.M. Broeders,       http://www.cornelis-broeders.de\n>\n>\n\n--\nhttp://www.cornelis-broeders.de\n\n\n\n\nC.H.M. Broeders,       http://www.cornelis-broeders.de\n```"},"comment":{"url":"https://api.github.com/repos/raffenet/mpich-migrate-test/issues/comments/235755648","html_url":"https://github.com/raffenet/mpich-migrate-test/issues/208#issuecomment-235755648","issue_url":"https://api.github.com/repos/raffenet/mpich-migrate-test/issues/208","id":235755648,"user":{"login":"raffenet","id":1410792,"avatar_url":"https://avatars.githubusercontent.com/u/1410792?v=3","gravatar_id":"","url":"https://api.github.com/users/raffenet","html_url":"https://github.com/raffenet","followers_url":"https://api.github.com/users/raffenet/followers","following_url":"https://api.github.com/users/raffenet/following{/other_user}","gists_url":"https://api.github.com/users/raffenet/gists{/gist_id}","starred_url":"https://api.github.com/users/raffenet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raffenet/subscriptions","organizations_url":"https://api.github.com/users/raffenet/orgs","repos_url":"https://api.github.com/users/raffenet/repos","events_url":"https://api.github.com/users/raffenet/events{/privacy}","received_events_url":"https://api.github.com/users/raffenet/received_events","type":"User","site_admin":false},"created_at":"2016-07-27T23:46:49Z","updated_at":"2016-07-27T23:46:49Z","body":"**Originally by _Anthony Chan_ on 2008-10-11 14:38:28 -0500**\n\n___\n```\n\nI compiled the following test program with gnu(gfortran, g77),\nintel, absoft, PGI, NAG, xlf90, sun's f90.\n\n/homes/chan/ts_f90> cat test_save.f\n      integer i\n      save\n      save i\n      i = 1\n      end\n\nOnly gfortran emits a warning message (can't find g95 in MCS)\n\na lengthy discussion of this problem is here\nhttp://gcc.gnu.org/bugzilla/show_bug.cgi?id=19425\nand\nhttp://gcc.gnu.org/ml/fortran/2005-03/msg00410.html\n\n(FWIW, OpenMPI's mpif.h does not use SAVE on their named common blocks).\nStrictly speaking, using the save statement on the named common block\nin our mpif.h is a sufficient not necessary condition to guarantee mpif.h\nworks on all/most platforms.   But since we can't stop user from using\n\"blanket save\" in their MPI code, this seems to suggest mpif.h can't use\nsave statement if we want to support g95 or to make mpif.h more robust.\n(BTW, adding #ifdef in mpif.h seems like a bad idea for portability reason)\nwe can have a configure test to check if save is necessary in mpif.h, but the\ntest will be a runtime test.... not sure if a runtime test is a good idea.\n\nHowever, we can also ask user who faces this problem to use gfortran instead?\ni.e. we ignore the problem because g95 seems to be a dying branch\n(could be wrong here, not sure if there are platforms relying on g95)....\n\nA.Chan\n\n----- \"mpich2\" <mpich2-maint@mcs.anl.gov> wrote:\n\n> --------------------------------------------------+-------------------------\n>  Reporter:  \"Rajeev Thakur\" <thakur@mcs.anl.gov>  |        Type:  bug\n>\n>    Status:  new                                   |    Priority:\n> major\n> Milestone:                                        |   Component:\n> mpich2\n> --------------------------------------------------+-------------------------\n>\n>\n>  {{{\n>\n>\n>\n>  -----Original Message-----\n>  From: owner-mpich-discuss@mcs.anl.gov\n>  [mailto:owner-mpich-discuss@mcs.anl.gov] On Behalf Of\n>  cornelis.broeders@web.de\n>  Sent: Saturday, October 11, 2008 5:34 AM\n>  To: mpich-discuss@mcs.anl.gov\n>  Subject: Re: [mpich-discuss] mpich2-1.0.7 file mpif.h and fortran\n> compiler\n>  g95\n>\n>  problem is reproducable with following procedures:\n>\n>  1) create file savetest.F with 4 lines:\n>\n>       save\n>  #include \"sav.h\"\n>        stop\n>        end\n>\n>  2) create file sav.h with 2 lines:\n>\n>        integer*4 j\n>        save j\n>\n>  3) run g95 result:\n>\n>  g95 -o savetest savetest.F\n>  In file sav.h:2\n>\n>      Included at savetest.F:2\n>\n>        save j\n>\n>\n>            1\n>  Error: SAVE statement at (1) follows blanket SAVE statement\n>\n>  4) for completeness gfortran:\n>\n>  gfortran -o savetest savetest.F\n>  sav.h:2.10:\n>      Included at savetest.F:3:\n>\n>        save j\n>           1\n>  Warning: SAVE statement at (1) follows blanket SAVE statement\n>  sav.h:1.17:\n>      Included at savetest.F:3:\n>\n>        integer*4 j\n>                  1\n>  Warning: Duplicate SAVE attribute specified at (1)\n>\n>  I hope this information helps.\n>\n>  C.H.M. Broeders     http://www.cornelis-broeders.de\n>\n>\n>  > -----Ursprüngliche Nachricht-----\n>  > Von: \"Anthony Chan\" <chan@mcs.anl.gov>\n>  > Gesendet: 10.10.08 22:23:43\n>  > An: mpich-discuss@mcs.anl.gov\n>  > Betreff: Re: [mpich-discuss] mpich2-1.0.7 file mpif.h and fortran\n>  > compiler g95\n>\n>\n>  >\n>  > I don't see mpif.h has any \"blanket\" SAVE statement (assume I\n> don't\n>  > misinterpret what a \"blanket\" SAVE is).  To help us understand the\n>  > issue, can you send us a simple fortran MPI program that\n> illustrates\n>  > the need of such a construct in mpif.h ?\n>  >\n>  > Thanks,\n>  > A.Chan\n>  >\n>  > ----- \"cornelis broeders\" <cornelis.broeders@web.de> wrote:\n>  >\n>  > > Hello,\n>  > > I encountered the error message \"SAVE statement at (1) follows\n>  > > blanket SAVE statement\"  during installation of the huge package\n>  > > mcnpx. After some efforts I found that this message is generally\n>  > > issued by g95 (and\n>  > > gfortran?) if a program with a previous \"save\" statement includes\n> a\n>  > > file, like mpif.h, containing  \"save var\" statements. Putting\n> the\n>  > > SAVE statements of mpif.h in an exclude construct \"#ifndef G95\n> ...\n>  > > #endif solved my problem. I propose to include such kind of\n> patch\n>  > > for g95 in future releases of mpich2. Could somebody comment on\n> this\n>  proposal?\n>  > > Best regards,\n>  > >\n>  > >\n>  > >\n>  > > C.H.M. Broeders,       http://www.cornelis-broeders.de\n>  >\n>  >\n>\n>  --\n>  http://www.cornelis-broeders.de\n>\n>\n>\n>\n>  C.H.M. Broeders,       http://www.cornelis-broeders.de\n>  ```\n>\n>\n> --\n> Ticket URL: <https://trac.mcs.anl.gov/projects/mpich2/ticket/208>\n}}}"}}
{"actor":{"display_login":"raffenet"}}