{"action":"created","comment":{"url":"https://api.github.com/repos/kaazing/docker.tutorials/pulls/comments/69264655","id":69264655,"diff_hunk":"@@ -0,0 +1,30 @@\n+version: '2'\n+services:\n+  gateway:\n+    build: gateway\n+    ports:\n+      - \"8000:8000\"\n+    hostname: \"kaazing.example.com\"\n+    networks: \n+      tut-redis: \n+        ipv4_address: 172.19.0.3\n+    volumes:\n+    - /var/log/tut-redis/gateway:/kaazing-gateway/log\n+  redis:\n+    build: broker\n+    ports:\n+      - \"6379:6379\"\n+    networks: \n+      tut-redis: \n+        ipv4_address: 172.19.0.4      \n+    volumes:\n+     - /var/log/tut-redis/redis:/data/log/\n+networks:\n+  tut-redis:","path":"redis/redis/docker-compose.yml","position":23,"original_position":23,"commit_id":"3b1328e4c2d08b2f4fd2103b7cb1044799f53a3c","original_commit_id":"3b1328e4c2d08b2f4fd2103b7cb1044799f53a3c","user":{"login":"DoruM","id":3726034,"avatar_url":"https://avatars.githubusercontent.com/u/3726034?v=3","gravatar_id":"","url":"https://api.github.com/users/DoruM","html_url":"https://github.com/DoruM","followers_url":"https://api.github.com/users/DoruM/followers","following_url":"https://api.github.com/users/DoruM/following{/other_user}","gists_url":"https://api.github.com/users/DoruM/gists{/gist_id}","starred_url":"https://api.github.com/users/DoruM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DoruM/subscriptions","organizations_url":"https://api.github.com/users/DoruM/orgs","repos_url":"https://api.github.com/users/DoruM/repos","events_url":"https://api.github.com/users/DoruM/events{/privacy}","received_events_url":"https://api.github.com/users/DoruM/received_events","type":"User","site_admin":false},"body":"First of all, I think this is best practices in docker to assign IP addresses.\r\n\r\nAside from that, there was a practical reason for that. I run docker in Windows 7 (boot2docker).\r\n\r\nAs such, to connect to the actual server I need to create a tunnel in VirtualBox to the machine, and connect to THAT machine, (from Chrome from the Windows 7 host). IF I wouldn't create a static IP, a new IP would be created every time I would tear it down and I would need to enter into VirtualBox GUI and change the tunnel every time.\r\n\r\nBTW, related to this, I think more information should be added on the README as to how to run on boot2docker.","created_at":"2016-07-01T08:16:47Z","updated_at":"2016-07-01T08:16:47Z","html_url":"https://github.com/kaazing/docker.tutorials/pull/5#discussion_r69264655","pull_request_url":"https://api.github.com/repos/kaazing/docker.tutorials/pulls/5","_links":{"self":{"href":"https://api.github.com/repos/kaazing/docker.tutorials/pulls/comments/69264655"},"html":{"href":"https://github.com/kaazing/docker.tutorials/pull/5#discussion_r69264655"},"pull_request":{"href":"https://api.github.com/repos/kaazing/docker.tutorials/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/kaazing/docker.tutorials/pulls/5","id":75815414,"html_url":"https://github.com/kaazing/docker.tutorials/pull/5","diff_url":"https://github.com/kaazing/docker.tutorials/pull/5.diff","patch_url":"https://github.com/kaazing/docker.tutorials/pull/5.patch","issue_url":"https://api.github.com/repos/kaazing/docker.tutorials/issues/5","number":5,"state":"open","locked":false,"title":"Created docker tutorial for redis","user":{"login":"DoruM","id":3726034,"avatar_url":"https://avatars.githubusercontent.com/u/3726034?v=3","gravatar_id":"","url":"https://api.github.com/users/DoruM","html_url":"https://github.com/DoruM","followers_url":"https://api.github.com/users/DoruM/followers","following_url":"https://api.github.com/users/DoruM/following{/other_user}","gists_url":"https://api.github.com/users/DoruM/gists{/gist_id}","starred_url":"https://api.github.com/users/DoruM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DoruM/subscriptions","organizations_url":"https://api.github.com/users/DoruM/orgs","repos_url":"https://api.github.com/users/DoruM/repos","events_url":"https://api.github.com/users/DoruM/events{/privacy}","received_events_url":"https://api.github.com/users/DoruM/received_events","type":"User","site_admin":false},"body":"A few comments on this pull request. \r\n\r\n- curl uses Chrome user agent (instead of curl user agent). This is done in order to get over the firewall.\r\n- curl uses --insecure. This was done for the same reason. \r\n- I have allowed origin * in the gateway.\r\n- Changed to ws from wss\r\n- Added volume mapping for the drives in redis (Thus they can be checked directly from the host, or from boot2docker).\r\n- This example uses the JMS client. If a redis only client is needed, we have to create it first. As such a new issue should be created.","created_at":"2016-06-30T13:03:49Z","updated_at":"2016-07-01T08:16:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6a22c2b34cc7bd821e33b0f5c5ab6c14b4e40d11","assignee":{"login":"dpwspoon","id":2014623,"avatar_url":"https://avatars.githubusercontent.com/u/2014623?v=3","gravatar_id":"","url":"https://api.github.com/users/dpwspoon","html_url":"https://github.com/dpwspoon","followers_url":"https://api.github.com/users/dpwspoon/followers","following_url":"https://api.github.com/users/dpwspoon/following{/other_user}","gists_url":"https://api.github.com/users/dpwspoon/gists{/gist_id}","starred_url":"https://api.github.com/users/dpwspoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpwspoon/subscriptions","organizations_url":"https://api.github.com/users/dpwspoon/orgs","repos_url":"https://api.github.com/users/dpwspoon/repos","events_url":"https://api.github.com/users/dpwspoon/events{/privacy}","received_events_url":"https://api.github.com/users/dpwspoon/received_events","type":"User","site_admin":false},"assignees":[{"login":"dpwspoon","id":2014623,"avatar_url":"https://avatars.githubusercontent.com/u/2014623?v=3","gravatar_id":"","url":"https://api.github.com/users/dpwspoon","html_url":"https://github.com/dpwspoon","followers_url":"https://api.github.com/users/dpwspoon/followers","following_url":"https://api.github.com/users/dpwspoon/following{/other_user}","gists_url":"https://api.github.com/users/dpwspoon/gists{/gist_id}","starred_url":"https://api.github.com/users/dpwspoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpwspoon/subscriptions","organizations_url":"https://api.github.com/users/dpwspoon/orgs","repos_url":"https://api.github.com/users/dpwspoon/repos","events_url":"https://api.github.com/users/dpwspoon/events{/privacy}","received_events_url":"https://api.github.com/users/dpwspoon/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kaazing/docker.tutorials/pulls/5/commits","review_comments_url":"https://api.github.com/repos/kaazing/docker.tutorials/pulls/5/comments","review_comment_url":"https://api.github.com/repos/kaazing/docker.tutorials/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kaazing/docker.tutorials/issues/5/comments","statuses_url":"https://api.github.com/repos/kaazing/docker.tutorials/statuses/3b1328e4c2d08b2f4fd2103b7cb1044799f53a3c","head":{"label":"DoruM:redis-docker-tutorial","ref":"redis-docker-tutorial","sha":"3b1328e4c2d08b2f4fd2103b7cb1044799f53a3c","user":{"login":"DoruM","id":3726034,"avatar_url":"https://avatars.githubusercontent.com/u/3726034?v=3","gravatar_id":"","url":"https://api.github.com/users/DoruM","html_url":"https://github.com/DoruM","followers_url":"https://api.github.com/users/DoruM/followers","following_url":"https://api.github.com/users/DoruM/following{/other_user}","gists_url":"https://api.github.com/users/DoruM/gists{/gist_id}","starred_url":"https://api.github.com/users/DoruM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DoruM/subscriptions","organizations_url":"https://api.github.com/users/DoruM/orgs","repos_url":"https://api.github.com/users/DoruM/repos","events_url":"https://api.github.com/users/DoruM/events{/privacy}","received_events_url":"https://api.github.com/users/DoruM/received_events","type":"User","site_admin":false},"repo":{"id":62206199,"name":"docker.tutorials","full_name":"DoruM/docker.tutorials","owner":{"login":"DoruM","id":3726034,"avatar_url":"https://avatars.githubusercontent.com/u/3726034?v=3","gravatar_id":"","url":"https://api.github.com/users/DoruM","html_url":"https://github.com/DoruM","followers_url":"https://api.github.com/users/DoruM/followers","following_url":"https://api.github.com/users/DoruM/following{/other_user}","gists_url":"https://api.github.com/users/DoruM/gists{/gist_id}","starred_url":"https://api.github.com/users/DoruM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DoruM/subscriptions","organizations_url":"https://api.github.com/users/DoruM/orgs","repos_url":"https://api.github.com/users/DoruM/repos","events_url":"https://api.github.com/users/DoruM/events{/privacy}","received_events_url":"https://api.github.com/users/DoruM/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DoruM/docker.tutorials","description":null,"fork":true,"url":"https://api.github.com/repos/DoruM/docker.tutorials","forks_url":"https://api.github.com/repos/DoruM/docker.tutorials/forks","keys_url":"https://api.github.com/repos/DoruM/docker.tutorials/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DoruM/docker.tutorials/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DoruM/docker.tutorials/teams","hooks_url":"https://api.github.com/repos/DoruM/docker.tutorials/hooks","issue_events_url":"https://api.github.com/repos/DoruM/docker.tutorials/issues/events{/number}","events_url":"https://api.github.com/repos/DoruM/docker.tutorials/events","assignees_url":"https://api.github.com/repos/DoruM/docker.tutorials/assignees{/user}","branches_url":"https://api.github.com/repos/DoruM/docker.tutorials/branches{/branch}","tags_url":"https://api.github.com/repos/DoruM/docker.tutorials/tags","blobs_url":"https://api.github.com/repos/DoruM/docker.tutorials/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DoruM/docker.tutorials/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DoruM/docker.tutorials/git/refs{/sha}","trees_url":"https://api.github.com/repos/DoruM/docker.tutorials/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DoruM/docker.tutorials/statuses/{sha}","languages_url":"https://api.github.com/repos/DoruM/docker.tutorials/languages","stargazers_url":"https://api.github.com/repos/DoruM/docker.tutorials/stargazers","contributors_url":"https://api.github.com/repos/DoruM/docker.tutorials/contributors","subscribers_url":"https://api.github.com/repos/DoruM/docker.tutorials/subscribers","subscription_url":"https://api.github.com/repos/DoruM/docker.tutorials/subscription","commits_url":"https://api.github.com/repos/DoruM/docker.tutorials/commits{/sha}","git_commits_url":"https://api.github.com/repos/DoruM/docker.tutorials/git/commits{/sha}","comments_url":"https://api.github.com/repos/DoruM/docker.tutorials/comments{/number}","issue_comment_url":"https://api.github.com/repos/DoruM/docker.tutorials/issues/comments{/number}","contents_url":"https://api.github.com/repos/DoruM/docker.tutorials/contents/{+path}","compare_url":"https://api.github.com/repos/DoruM/docker.tutorials/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DoruM/docker.tutorials/merges","archive_url":"https://api.github.com/repos/DoruM/docker.tutorials/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DoruM/docker.tutorials/downloads","issues_url":"https://api.github.com/repos/DoruM/docker.tutorials/issues{/number}","pulls_url":"https://api.github.com/repos/DoruM/docker.tutorials/pulls{/number}","milestones_url":"https://api.github.com/repos/DoruM/docker.tutorials/milestones{/number}","notifications_url":"https://api.github.com/repos/DoruM/docker.tutorials/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DoruM/docker.tutorials/labels{/name}","releases_url":"https://api.github.com/repos/DoruM/docker.tutorials/releases{/id}","deployments_url":"https://api.github.com/repos/DoruM/docker.tutorials/deployments","created_at":"2016-06-29T07:42:31Z","updated_at":"2016-06-23T08:27:05Z","pushed_at":"2016-06-30T14:00:54Z","git_url":"git://github.com/DoruM/docker.tutorials.git","ssh_url":"git@github.com:DoruM/docker.tutorials.git","clone_url":"https://github.com/DoruM/docker.tutorials.git","svn_url":"https://github.com/DoruM/docker.tutorials","homepage":null,"size":242,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"kaazing:develop","ref":"develop","sha":"fa05d85107ca64351663d9f152f383e889a2ff3e","user":{"login":"kaazing","id":1056680,"avatar_url":"https://avatars.githubusercontent.com/u/1056680?v=3","gravatar_id":"","url":"https://api.github.com/users/kaazing","html_url":"https://github.com/kaazing","followers_url":"https://api.github.com/users/kaazing/followers","following_url":"https://api.github.com/users/kaazing/following{/other_user}","gists_url":"https://api.github.com/users/kaazing/gists{/gist_id}","starred_url":"https://api.github.com/users/kaazing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaazing/subscriptions","organizations_url":"https://api.github.com/users/kaazing/orgs","repos_url":"https://api.github.com/users/kaazing/repos","events_url":"https://api.github.com/users/kaazing/events{/privacy}","received_events_url":"https://api.github.com/users/kaazing/received_events","type":"Organization","site_admin":false},"repo":{"id":59696158,"name":"docker.tutorials","full_name":"kaazing/docker.tutorials","owner":{"login":"kaazing","id":1056680,"avatar_url":"https://avatars.githubusercontent.com/u/1056680?v=3","gravatar_id":"","url":"https://api.github.com/users/kaazing","html_url":"https://github.com/kaazing","followers_url":"https://api.github.com/users/kaazing/followers","following_url":"https://api.github.com/users/kaazing/following{/other_user}","gists_url":"https://api.github.com/users/kaazing/gists{/gist_id}","starred_url":"https://api.github.com/users/kaazing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaazing/subscriptions","organizations_url":"https://api.github.com/users/kaazing/orgs","repos_url":"https://api.github.com/users/kaazing/repos","events_url":"https://api.github.com/users/kaazing/events{/privacy}","received_events_url":"https://api.github.com/users/kaazing/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kaazing/docker.tutorials","description":null,"fork":false,"url":"https://api.github.com/repos/kaazing/docker.tutorials","forks_url":"https://api.github.com/repos/kaazing/docker.tutorials/forks","keys_url":"https://api.github.com/repos/kaazing/docker.tutorials/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kaazing/docker.tutorials/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kaazing/docker.tutorials/teams","hooks_url":"https://api.github.com/repos/kaazing/docker.tutorials/hooks","issue_events_url":"https://api.github.com/repos/kaazing/docker.tutorials/issues/events{/number}","events_url":"https://api.github.com/repos/kaazing/docker.tutorials/events","assignees_url":"https://api.github.com/repos/kaazing/docker.tutorials/assignees{/user}","branches_url":"https://api.github.com/repos/kaazing/docker.tutorials/branches{/branch}","tags_url":"https://api.github.com/repos/kaazing/docker.tutorials/tags","blobs_url":"https://api.github.com/repos/kaazing/docker.tutorials/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kaazing/docker.tutorials/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kaazing/docker.tutorials/git/refs{/sha}","trees_url":"https://api.github.com/repos/kaazing/docker.tutorials/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kaazing/docker.tutorials/statuses/{sha}","languages_url":"https://api.github.com/repos/kaazing/docker.tutorials/languages","stargazers_url":"https://api.github.com/repos/kaazing/docker.tutorials/stargazers","contributors_url":"https://api.github.com/repos/kaazing/docker.tutorials/contributors","subscribers_url":"https://api.github.com/repos/kaazing/docker.tutorials/subscribers","subscription_url":"https://api.github.com/repos/kaazing/docker.tutorials/subscription","commits_url":"https://api.github.com/repos/kaazing/docker.tutorials/commits{/sha}","git_commits_url":"https://api.github.com/repos/kaazing/docker.tutorials/git/commits{/sha}","comments_url":"https://api.github.com/repos/kaazing/docker.tutorials/comments{/number}","issue_comment_url":"https://api.github.com/repos/kaazing/docker.tutorials/issues/comments{/number}","contents_url":"https://api.github.com/repos/kaazing/docker.tutorials/contents/{+path}","compare_url":"https://api.github.com/repos/kaazing/docker.tutorials/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kaazing/docker.tutorials/merges","archive_url":"https://api.github.com/repos/kaazing/docker.tutorials/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kaazing/docker.tutorials/downloads","issues_url":"https://api.github.com/repos/kaazing/docker.tutorials/issues{/number}","pulls_url":"https://api.github.com/repos/kaazing/docker.tutorials/pulls{/number}","milestones_url":"https://api.github.com/repos/kaazing/docker.tutorials/milestones{/number}","notifications_url":"https://api.github.com/repos/kaazing/docker.tutorials/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kaazing/docker.tutorials/labels{/name}","releases_url":"https://api.github.com/repos/kaazing/docker.tutorials/releases{/id}","deployments_url":"https://api.github.com/repos/kaazing/docker.tutorials/deployments","created_at":"2016-05-25T20:41:11Z","updated_at":"2016-06-23T08:27:05Z","pushed_at":"2016-06-30T14:00:54Z","git_url":"git://github.com/kaazing/docker.tutorials.git","ssh_url":"git@github.com:kaazing/docker.tutorials.git","clone_url":"https://github.com/kaazing/docker.tutorials.git","svn_url":"https://github.com/kaazing/docker.tutorials","homepage":null,"size":191,"stargazers_count":1,"watchers_count":1,"language":null,"has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":3,"forks":3,"open_issues":3,"watchers":1,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/kaazing/docker.tutorials/pulls/5"},"html":{"href":"https://github.com/kaazing/docker.tutorials/pull/5"},"issue":{"href":"https://api.github.com/repos/kaazing/docker.tutorials/issues/5"},"comments":{"href":"https://api.github.com/repos/kaazing/docker.tutorials/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/kaazing/docker.tutorials/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/kaazing/docker.tutorials/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kaazing/docker.tutorials/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/kaazing/docker.tutorials/statuses/3b1328e4c2d08b2f4fd2103b7cb1044799f53a3c"}}}}
{"actor":{"display_login":"DoruM"}}