{"action":"closed","number":9,"pull_request":{"url":"https://api.github.com/repos/hunner/puppet-hiera/pulls/9","id":9641905,"html_url":"https://github.com/hunner/puppet-hiera/pull/9","diff_url":"https://github.com/hunner/puppet-hiera/pull/9.diff","patch_url":"https://github.com/hunner/puppet-hiera/pull/9.patch","issue_url":"https://api.github.com/repos/hunner/puppet-hiera/issues/9","number":9,"state":"closed","locked":false,"title":"Add testing framework and tests","user":{"login":"zined","id":1200504,"avatar_url":"https://avatars.githubusercontent.com/u/1200504?v=3","gravatar_id":"","url":"https://api.github.com/users/zined","html_url":"https://github.com/zined","followers_url":"https://api.github.com/users/zined/followers","following_url":"https://api.github.com/users/zined/following{/other_user}","gists_url":"https://api.github.com/users/zined/gists{/gist_id}","starred_url":"https://api.github.com/users/zined/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zined/subscriptions","organizations_url":"https://api.github.com/users/zined/orgs","repos_url":"https://api.github.com/users/zined/repos","events_url":"https://api.github.com/users/zined/events{/privacy}","received_events_url":"https://api.github.com/users/zined/received_events","type":"User","site_admin":false},"body":"Hey there,\r\n\r\nfirst of all - thanks for the puppet hiera module!\r\n\r\nI'd love to apply some changes, and refactored those to make it mergable back into your repository.\r\n\r\n- incorporate test skeleton from https://github.com/Jimdo/puppet-skeleton. this adds plenty of testing possibilities. at the moment i just implemented a basic set of unit tests, but it adds stuff like integration testing with vagrant boxes.\r\n\r\n- enhance the \"extra_config\" logic, by enabling handling for hash values. this way more complex extra configurations can be given to the module. backwards compatibility for plain strings is ensured and tested.\r\n\r\nLast point: would you mind changing the name to \"puppet-hiera\"? This seems to be defacto standard for puppet modules, and does not break automatisms on our side.\r\n\r\nThanksalot!","created_at":"2013-11-04T13:52:29Z","updated_at":"2016-01-19T18:38:30Z","closed_at":"2016-01-19T18:38:30Z","merged_at":null,"merge_commit_sha":"cad96eb6eabca93071ad9a0a3263b4ef7c7bbe1b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hunner/puppet-hiera/pulls/9/commits","review_comments_url":"https://api.github.com/repos/hunner/puppet-hiera/pulls/9/comments","review_comment_url":"https://api.github.com/repos/hunner/puppet-hiera/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hunner/puppet-hiera/issues/9/comments","statuses_url":"https://api.github.com/repos/hunner/puppet-hiera/statuses/366f3d8674aadadc56a7218da1d13c6a8aae43ae","head":{"label":"zined:add_testing_framework_and_tests","ref":"add_testing_framework_and_tests","sha":"366f3d8674aadadc56a7218da1d13c6a8aae43ae","user":{"login":"zined","id":1200504,"avatar_url":"https://avatars.githubusercontent.com/u/1200504?v=3","gravatar_id":"","url":"https://api.github.com/users/zined","html_url":"https://github.com/zined","followers_url":"https://api.github.com/users/zined/followers","following_url":"https://api.github.com/users/zined/following{/other_user}","gists_url":"https://api.github.com/users/zined/gists{/gist_id}","starred_url":"https://api.github.com/users/zined/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zined/subscriptions","organizations_url":"https://api.github.com/users/zined/orgs","repos_url":"https://api.github.com/users/zined/repos","events_url":"https://api.github.com/users/zined/events{/privacy}","received_events_url":"https://api.github.com/users/zined/received_events","type":"User","site_admin":false},"repo":{"id":14110685,"name":"puppet-hiera","full_name":"zined/puppet-hiera","owner":{"login":"zined","id":1200504,"avatar_url":"https://avatars.githubusercontent.com/u/1200504?v=3","gravatar_id":"","url":"https://api.github.com/users/zined","html_url":"https://github.com/zined","followers_url":"https://api.github.com/users/zined/followers","following_url":"https://api.github.com/users/zined/following{/other_user}","gists_url":"https://api.github.com/users/zined/gists{/gist_id}","starred_url":"https://api.github.com/users/zined/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zined/subscriptions","organizations_url":"https://api.github.com/users/zined/orgs","repos_url":"https://api.github.com/users/zined/repos","events_url":"https://api.github.com/users/zined/events{/privacy}","received_events_url":"https://api.github.com/users/zined/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zined/puppet-hiera","description":"Hiera hierarchy module for templating `hiera.yaml`","fork":true,"url":"https://api.github.com/repos/zined/puppet-hiera","forks_url":"https://api.github.com/repos/zined/puppet-hiera/forks","keys_url":"https://api.github.com/repos/zined/puppet-hiera/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zined/puppet-hiera/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zined/puppet-hiera/teams","hooks_url":"https://api.github.com/repos/zined/puppet-hiera/hooks","issue_events_url":"https://api.github.com/repos/zined/puppet-hiera/issues/events{/number}","events_url":"https://api.github.com/repos/zined/puppet-hiera/events","assignees_url":"https://api.github.com/repos/zined/puppet-hiera/assignees{/user}","branches_url":"https://api.github.com/repos/zined/puppet-hiera/branches{/branch}","tags_url":"https://api.github.com/repos/zined/puppet-hiera/tags","blobs_url":"https://api.github.com/repos/zined/puppet-hiera/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zined/puppet-hiera/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zined/puppet-hiera/git/refs{/sha}","trees_url":"https://api.github.com/repos/zined/puppet-hiera/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zined/puppet-hiera/statuses/{sha}","languages_url":"https://api.github.com/repos/zined/puppet-hiera/languages","stargazers_url":"https://api.github.com/repos/zined/puppet-hiera/stargazers","contributors_url":"https://api.github.com/repos/zined/puppet-hiera/contributors","subscribers_url":"https://api.github.com/repos/zined/puppet-hiera/subscribers","subscription_url":"https://api.github.com/repos/zined/puppet-hiera/subscription","commits_url":"https://api.github.com/repos/zined/puppet-hiera/commits{/sha}","git_commits_url":"https://api.github.com/repos/zined/puppet-hiera/git/commits{/sha}","comments_url":"https://api.github.com/repos/zined/puppet-hiera/comments{/number}","issue_comment_url":"https://api.github.com/repos/zined/puppet-hiera/issues/comments{/number}","contents_url":"https://api.github.com/repos/zined/puppet-hiera/contents/{+path}","compare_url":"https://api.github.com/repos/zined/puppet-hiera/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zined/puppet-hiera/merges","archive_url":"https://api.github.com/repos/zined/puppet-hiera/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zined/puppet-hiera/downloads","issues_url":"https://api.github.com/repos/zined/puppet-hiera/issues{/number}","pulls_url":"https://api.github.com/repos/zined/puppet-hiera/pulls{/number}","milestones_url":"https://api.github.com/repos/zined/puppet-hiera/milestones{/number}","notifications_url":"https://api.github.com/repos/zined/puppet-hiera/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zined/puppet-hiera/labels{/name}","releases_url":"https://api.github.com/repos/zined/puppet-hiera/releases{/id}","created_at":"2013-11-04T13:44:20Z","updated_at":"2013-11-07T12:54:42Z","pushed_at":"2013-11-05T11:24:51Z","git_url":"git://github.com/zined/puppet-hiera.git","ssh_url":"git@github.com:zined/puppet-hiera.git","clone_url":"https://github.com/zined/puppet-hiera.git","svn_url":"https://github.com/zined/puppet-hiera","homepage":null,"size":128,"stargazers_count":0,"watchers_count":0,"language":"Puppet","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hunner:master","ref":"master","sha":"5cea338b175262edb4f2a63979db74160e48ab63","user":{"login":"hunner","id":91972,"avatar_url":"https://avatars.githubusercontent.com/u/91972?v=3","gravatar_id":"","url":"https://api.github.com/users/hunner","html_url":"https://github.com/hunner","followers_url":"https://api.github.com/users/hunner/followers","following_url":"https://api.github.com/users/hunner/following{/other_user}","gists_url":"https://api.github.com/users/hunner/gists{/gist_id}","starred_url":"https://api.github.com/users/hunner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hunner/subscriptions","organizations_url":"https://api.github.com/users/hunner/orgs","repos_url":"https://api.github.com/users/hunner/repos","events_url":"https://api.github.com/users/hunner/events{/privacy}","received_events_url":"https://api.github.com/users/hunner/received_events","type":"User","site_admin":false},"repo":{"id":5417020,"name":"puppet-hiera","full_name":"hunner/puppet-hiera","owner":{"login":"hunner","id":91972,"avatar_url":"https://avatars.githubusercontent.com/u/91972?v=3","gravatar_id":"","url":"https://api.github.com/users/hunner","html_url":"https://github.com/hunner","followers_url":"https://api.github.com/users/hunner/followers","following_url":"https://api.github.com/users/hunner/following{/other_user}","gists_url":"https://api.github.com/users/hunner/gists{/gist_id}","starred_url":"https://api.github.com/users/hunner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hunner/subscriptions","organizations_url":"https://api.github.com/users/hunner/orgs","repos_url":"https://api.github.com/users/hunner/repos","events_url":"https://api.github.com/users/hunner/events{/privacy}","received_events_url":"https://api.github.com/users/hunner/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hunner/puppet-hiera","description":"Hiera hierarchy module for templating `hiera.yaml`","fork":false,"url":"https://api.github.com/repos/hunner/puppet-hiera","forks_url":"https://api.github.com/repos/hunner/puppet-hiera/forks","keys_url":"https://api.github.com/repos/hunner/puppet-hiera/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hunner/puppet-hiera/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hunner/puppet-hiera/teams","hooks_url":"https://api.github.com/repos/hunner/puppet-hiera/hooks","issue_events_url":"https://api.github.com/repos/hunner/puppet-hiera/issues/events{/number}","events_url":"https://api.github.com/repos/hunner/puppet-hiera/events","assignees_url":"https://api.github.com/repos/hunner/puppet-hiera/assignees{/user}","branches_url":"https://api.github.com/repos/hunner/puppet-hiera/branches{/branch}","tags_url":"https://api.github.com/repos/hunner/puppet-hiera/tags","blobs_url":"https://api.github.com/repos/hunner/puppet-hiera/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hunner/puppet-hiera/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hunner/puppet-hiera/git/refs{/sha}","trees_url":"https://api.github.com/repos/hunner/puppet-hiera/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hunner/puppet-hiera/statuses/{sha}","languages_url":"https://api.github.com/repos/hunner/puppet-hiera/languages","stargazers_url":"https://api.github.com/repos/hunner/puppet-hiera/stargazers","contributors_url":"https://api.github.com/repos/hunner/puppet-hiera/contributors","subscribers_url":"https://api.github.com/repos/hunner/puppet-hiera/subscribers","subscription_url":"https://api.github.com/repos/hunner/puppet-hiera/subscription","commits_url":"https://api.github.com/repos/hunner/puppet-hiera/commits{/sha}","git_commits_url":"https://api.github.com/repos/hunner/puppet-hiera/git/commits{/sha}","comments_url":"https://api.github.com/repos/hunner/puppet-hiera/comments{/number}","issue_comment_url":"https://api.github.com/repos/hunner/puppet-hiera/issues/comments{/number}","contents_url":"https://api.github.com/repos/hunner/puppet-hiera/contents/{+path}","compare_url":"https://api.github.com/repos/hunner/puppet-hiera/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hunner/puppet-hiera/merges","archive_url":"https://api.github.com/repos/hunner/puppet-hiera/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hunner/puppet-hiera/downloads","issues_url":"https://api.github.com/repos/hunner/puppet-hiera/issues{/number}","pulls_url":"https://api.github.com/repos/hunner/puppet-hiera/pulls{/number}","milestones_url":"https://api.github.com/repos/hunner/puppet-hiera/milestones{/number}","notifications_url":"https://api.github.com/repos/hunner/puppet-hiera/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hunner/puppet-hiera/labels{/name}","releases_url":"https://api.github.com/repos/hunner/puppet-hiera/releases{/id}","created_at":"2012-08-14T18:47:18Z","updated_at":"2015-12-22T04:31:05Z","pushed_at":"2016-01-15T19:17:45Z","git_url":"git://github.com/hunner/puppet-hiera.git","ssh_url":"git@github.com:hunner/puppet-hiera.git","clone_url":"https://github.com/hunner/puppet-hiera.git","svn_url":"https://github.com/hunner/puppet-hiera","homepage":null,"size":172,"stargazers_count":13,"watchers_count":13,"language":"Puppet","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":54,"mirror_url":null,"open_issues_count":25,"forks":54,"open_issues":25,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hunner/puppet-hiera/pulls/9"},"html":{"href":"https://github.com/hunner/puppet-hiera/pull/9"},"issue":{"href":"https://api.github.com/repos/hunner/puppet-hiera/issues/9"},"comments":{"href":"https://api.github.com/repos/hunner/puppet-hiera/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/hunner/puppet-hiera/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/hunner/puppet-hiera/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hunner/puppet-hiera/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/hunner/puppet-hiera/statuses/366f3d8674aadadc56a7218da1d13c6a8aae43ae"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":5,"review_comments":2,"commits":8,"additions":596,"deletions":27,"changed_files":14}}