{"push_id":1215366305,"size":9,"distinct_size":1,"ref":"refs/heads/default-renderer","head":"b8377c5833b22757e2d6caf562d4b5373e963293","before":"f8adbbb3a8da0242afbefdc9fbcd0490064362ad","commits":[{"sha":"f718cdb3793c1c31e73a4451a14e2bd34741446d","author":{"name":"Chad Hietala","email":"79127bbef4d01a1f8f2a59ea12620b7714d8fa4e@gmail.com"},"message":"[Glimmer2] Fix action target in a block","distinct":false,"url":"https://api.github.com/repos/emberjs/ember.js/commits/f718cdb3793c1c31e73a4451a14e2bd34741446d"},{"sha":"a9fe3744481d1ec4b3f85bf768cf56797739189f","author":{"name":"Chad Hietala","email":"79127bbef4d01a1f8f2a59ea12620b7714d8fa4e@gmail.com"},"message":"[Glimmer2] tests for html-safe and render\n\nMaintain our own safestring and escapeexpression for now","distinct":false,"url":"https://api.github.com/repos/emberjs/ember.js/commits/a9fe3744481d1ec4b3f85bf768cf56797739189f"},{"sha":"cbe74dddf20eda2fdd64526b0723025cfe58ff4f","author":{"name":"Robert Jackson","email":"b4a5ea001e047040e8c9075b67a268293138da2c@rwjblue.com"},"message":"Merge pull request #13850 from chadhietala/fix-action-scope\n\n[Glimmer2] Fix action target in a block","distinct":false,"url":"https://api.github.com/repos/emberjs/ember.js/commits/cbe74dddf20eda2fdd64526b0723025cfe58ff4f"},{"sha":"52ba7d0325f034475e93887eee48110de514455d","author":{"name":"Chad Hietala","email":"79127bbef4d01a1f8f2a59ea12620b7714d8fa4e@gmail.com"},"message":"Merge pull request #13845 from chadhietala/rando-tests\n\n[Glimmer2] tests for html-safe and render","distinct":false,"url":"https://api.github.com/repos/emberjs/ember.js/commits/52ba7d0325f034475e93887eee48110de514455d"},{"sha":"7737eb4a86dccf5b1f228cbf761b48a0e9c8258b","author":{"name":"Sergio Arbeo","email":"0e1b04e050802d18bff8081bba985d626b6711b7@gmail.com"},"message":"[BUGFIX beta] Keep rest positional parameters when nesting contextual\ncomponents if needed.\n\nSteps to reproduce the bug before this patch:\n\n1. Create a component with rest positional param (like `link-to`).\n2. Create contextual component (`(component \"link-to\" \"index\")`).\n3. Render it (`{{component (component \"link-to\" \"index\")}}`).\n4. Realize the component did not receive `\"index\"` at all.\n\nWhat was causing it?\n====================\n\nBecause of how positional parameters work (both in components and contextual\ncomponents), it is needed to treat them at each level and then merge them.\nSadly, this was causing to overwrite the rest positional parameters because\nwhen no parameters are passed, the attribute get an empty array nonetheless.\n\nIn the example above, assuming `LinkToComponent.positionalParams === 'params'`:\n\n1. Contextual component in `2` gets its positional parameters processed and\n   receives the following named parameters `{ params: ['index'] }`.\n2. When rendering, the `{{component}}` processes its own parameters getting\n   `{ params: [] }`. Then it merges in a `new EmptyObject()` these attributes\n   on top of the ones in the contextual component. (See what I did there?\n   I used the JS keyword `new` as an adjective! He he. Don't judge me, it is\n   pretty late in here)\n\nSolving the issue\n=================\n\nThis PR changes the implementation of `mergeInNewHash` to keep the original\npositional parameters if the new ones are empty and the positional parameter is\nof type rest.\n\nFixes #13742","distinct":false,"url":"https://api.github.com/repos/emberjs/ember.js/commits/7737eb4a86dccf5b1f228cbf761b48a0e9c8258b"},{"sha":"7246a373d229a8c2b548d935fc0a9d6a72a2bc70","author":{"name":"Robert Jackson","email":"b4a5ea001e047040e8c9075b67a268293138da2c@rwjblue.com"},"message":"Merge pull request #13764 from Serabe/fix/13742\n\n[BUGFIX beta] Keep rest positional parameters when nesting contextual components if needed.","distinct":false,"url":"https://api.github.com/repos/emberjs/ember.js/commits/7246a373d229a8c2b548d935fc0a9d6a72a2bc70"},{"sha":"2a233df8c6aa387898299d79dd4b2965b4266015","author":{"name":"Robert Jackson","email":"93ec85078c2139ee9ae0d5f436dd85f7e5c656bb@twitch.tv"},"message":"Use the renderer to manage the view registry.\n\n* Remove usage of `Ember.View.views`. This has not been exposed since 1.x.\n* Use the renderer to update view registry.","distinct":false,"url":"https://api.github.com/repos/emberjs/ember.js/commits/2a233df8c6aa387898299d79dd4b2965b4266015"},{"sha":"6933403faf2f91b08a150902458114b5616dc29f","author":{"name":"Kris Selden","email":"c8b8a952cdfb07b199755bb43eb7c73dfbd59287@gmail.com"},"message":"Merge pull request #13852 from rwjblue/pass-through-view-registry\n\n[GLIMMER] Ensure the view registry is propagated.","distinct":false,"url":"https://api.github.com/repos/emberjs/ember.js/commits/6933403faf2f91b08a150902458114b5616dc29f"},{"sha":"b8377c5833b22757e2d6caf562d4b5373e963293","author":{"name":"Robert Jackson","email":"93ec85078c2139ee9ae0d5f436dd85f7e5c656bb@twitch.tv"},"message":"Get correct renderer when appending views without a container.","distinct":true,"url":"https://api.github.com/repos/emberjs/ember.js/commits/b8377c5833b22757e2d6caf562d4b5373e963293"}]}
{"actor":{"display_login":"rwjblue"}}