{"action":"created","comment":{"url":"https://api.github.com/repos/openresty/lua-nginx-module/pulls/comments/71993760","id":71993760,"diff_hunk":"@@ -106,32 +103,6 @@ ngx_http_lua_shdict_init_zone(ngx_shm_zone_t *shm_zone, void *data)\n     ctx->shpool->log_nomem = 0;\n #endif\n \n-done:\n-\n-    dd(\"get lmcf\");\n-\n-    lmcf = ctx->main_conf;\n-\n-    dd(\"lmcf->lua: %p\", lmcf->lua);\n-\n-    lmcf->shm_zones_inited++;\n-\n-    if (lmcf->shm_zones_inited == lmcf->shm_zones->nelts\n-        && lmcf->init_handler)\n-    {\n-        saved_cycle = ngx_cycle;\n-        ngx_cycle = ctx->cycle;","path":"src/ngx_http_lua_shdict.c","position":47,"original_position":47,"commit_id":"5fc25f0a3fe3e9b2b162e82742f467579b0cdc3e","original_commit_id":"5fc25f0a3fe3e9b2b162e82742f467579b0cdc3e","user":{"login":"agentzh","id":56241,"avatar_url":"https://avatars.githubusercontent.com/u/56241?v=3","gravatar_id":"","url":"https://api.github.com/users/agentzh","html_url":"https://github.com/agentzh","followers_url":"https://api.github.com/users/agentzh/followers","following_url":"https://api.github.com/users/agentzh/following{/other_user}","gists_url":"https://api.github.com/users/agentzh/gists{/gist_id}","starred_url":"https://api.github.com/users/agentzh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agentzh/subscriptions","organizations_url":"https://api.github.com/users/agentzh/orgs","repos_url":"https://api.github.com/users/agentzh/repos","events_url":"https://api.github.com/users/agentzh/events{/privacy}","received_events_url":"https://api.github.com/users/agentzh/received_events","type":"User","site_admin":false},"body":"Again: we need these lines in your new version since they fixed real issues.","created_at":"2016-07-24T19:20:32Z","updated_at":"2016-07-24T19:20:32Z","html_url":"https://github.com/openresty/lua-nginx-module/pull/823#discussion_r71993760","pull_request_url":"https://api.github.com/repos/openresty/lua-nginx-module/pulls/823","_links":{"self":{"href":"https://api.github.com/repos/openresty/lua-nginx-module/pulls/comments/71993760"},"html":{"href":"https://github.com/openresty/lua-nginx-module/pull/823#discussion_r71993760"},"pull_request":{"href":"https://api.github.com/repos/openresty/lua-nginx-module/pulls/823"}}},"pull_request":{"url":"https://api.github.com/repos/openresty/lua-nginx-module/pulls/823","id":78598322,"html_url":"https://github.com/openresty/lua-nginx-module/pull/823","diff_url":"https://github.com/openresty/lua-nginx-module/pull/823.diff","patch_url":"https://github.com/openresty/lua-nginx-module/pull/823.patch","issue_url":"https://api.github.com/repos/openresty/lua-nginx-module/issues/823","number":823,"state":"open","locked":false,"title":"Shm zones registration capi2","user":{"login":"helloyi","id":5888524,"avatar_url":"https://avatars.githubusercontent.com/u/5888524?v=3","gravatar_id":"","url":"https://api.github.com/users/helloyi","html_url":"https://github.com/helloyi","followers_url":"https://api.github.com/users/helloyi/followers","following_url":"https://api.github.com/users/helloyi/following{/other_user}","gists_url":"https://api.github.com/users/helloyi/gists{/gist_id}","starred_url":"https://api.github.com/users/helloyi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helloyi/subscriptions","organizations_url":"https://api.github.com/users/helloyi/orgs","repos_url":"https://api.github.com/users/helloyi/repos","events_url":"https://api.github.com/users/helloyi/events{/privacy}","received_events_url":"https://api.github.com/users/helloyi/received_events","type":"User","site_admin":false},"body":"1. ngx_http_lua_shm_zone_reg_capi struct graph.\r\n![ngx_http_lua_shm_zone_reg_api](https://cloud.githubusercontent.com/assets/5888524/17083977/843802ce-51e3-11e6-903c-0acb4493d454.png)\r\n\r\n2. All code passed 'ngx-releng' check.\r\n3. Now, `ngx_http_lua_shared_memory_add` return `ngx_shm_zone_t`, instead of `ngx_http_lua_shm_zone_t` some else.  And, must be find zone with `ngx_http lua_find_zone`.","created_at":"2016-07-24T13:29:23Z","updated_at":"2016-07-24T19:20:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"26b6f48809ae78ce6572f78a3942a73468a83211","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/openresty/lua-nginx-module/pulls/823/commits","review_comments_url":"https://api.github.com/repos/openresty/lua-nginx-module/pulls/823/comments","review_comment_url":"https://api.github.com/repos/openresty/lua-nginx-module/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openresty/lua-nginx-module/issues/823/comments","statuses_url":"https://api.github.com/repos/openresty/lua-nginx-module/statuses/5fc25f0a3fe3e9b2b162e82742f467579b0cdc3e","head":{"label":"helloyi:shm-zones-registration-capi2","ref":"shm-zones-registration-capi2","sha":"5fc25f0a3fe3e9b2b162e82742f467579b0cdc3e","user":{"login":"helloyi","id":5888524,"avatar_url":"https://avatars.githubusercontent.com/u/5888524?v=3","gravatar_id":"","url":"https://api.github.com/users/helloyi","html_url":"https://github.com/helloyi","followers_url":"https://api.github.com/users/helloyi/followers","following_url":"https://api.github.com/users/helloyi/following{/other_user}","gists_url":"https://api.github.com/users/helloyi/gists{/gist_id}","starred_url":"https://api.github.com/users/helloyi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helloyi/subscriptions","organizations_url":"https://api.github.com/users/helloyi/orgs","repos_url":"https://api.github.com/users/helloyi/repos","events_url":"https://api.github.com/users/helloyi/events{/privacy}","received_events_url":"https://api.github.com/users/helloyi/received_events","type":"User","site_admin":false},"repo":{"id":41372910,"name":"lua-nginx-module","full_name":"helloyi/lua-nginx-module","owner":{"login":"helloyi","id":5888524,"avatar_url":"https://avatars.githubusercontent.com/u/5888524?v=3","gravatar_id":"","url":"https://api.github.com/users/helloyi","html_url":"https://github.com/helloyi","followers_url":"https://api.github.com/users/helloyi/followers","following_url":"https://api.github.com/users/helloyi/following{/other_user}","gists_url":"https://api.github.com/users/helloyi/gists{/gist_id}","starred_url":"https://api.github.com/users/helloyi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helloyi/subscriptions","organizations_url":"https://api.github.com/users/helloyi/orgs","repos_url":"https://api.github.com/users/helloyi/repos","events_url":"https://api.github.com/users/helloyi/events{/privacy}","received_events_url":"https://api.github.com/users/helloyi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/helloyi/lua-nginx-module","description":"Embed the Power of Lua into NGINX","fork":true,"url":"https://api.github.com/repos/helloyi/lua-nginx-module","forks_url":"https://api.github.com/repos/helloyi/lua-nginx-module/forks","keys_url":"https://api.github.com/repos/helloyi/lua-nginx-module/keys{/key_id}","collaborators_url":"https://api.github.com/repos/helloyi/lua-nginx-module/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/helloyi/lua-nginx-module/teams","hooks_url":"https://api.github.com/repos/helloyi/lua-nginx-module/hooks","issue_events_url":"https://api.github.com/repos/helloyi/lua-nginx-module/issues/events{/number}","events_url":"https://api.github.com/repos/helloyi/lua-nginx-module/events","assignees_url":"https://api.github.com/repos/helloyi/lua-nginx-module/assignees{/user}","branches_url":"https://api.github.com/repos/helloyi/lua-nginx-module/branches{/branch}","tags_url":"https://api.github.com/repos/helloyi/lua-nginx-module/tags","blobs_url":"https://api.github.com/repos/helloyi/lua-nginx-module/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/helloyi/lua-nginx-module/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/helloyi/lua-nginx-module/git/refs{/sha}","trees_url":"https://api.github.com/repos/helloyi/lua-nginx-module/git/trees{/sha}","statuses_url":"https://api.github.com/repos/helloyi/lua-nginx-module/statuses/{sha}","languages_url":"https://api.github.com/repos/helloyi/lua-nginx-module/languages","stargazers_url":"https://api.github.com/repos/helloyi/lua-nginx-module/stargazers","contributors_url":"https://api.github.com/repos/helloyi/lua-nginx-module/contributors","subscribers_url":"https://api.github.com/repos/helloyi/lua-nginx-module/subscribers","subscription_url":"https://api.github.com/repos/helloyi/lua-nginx-module/subscription","commits_url":"https://api.github.com/repos/helloyi/lua-nginx-module/commits{/sha}","git_commits_url":"https://api.github.com/repos/helloyi/lua-nginx-module/git/commits{/sha}","comments_url":"https://api.github.com/repos/helloyi/lua-nginx-module/comments{/number}","issue_comment_url":"https://api.github.com/repos/helloyi/lua-nginx-module/issues/comments{/number}","contents_url":"https://api.github.com/repos/helloyi/lua-nginx-module/contents/{+path}","compare_url":"https://api.github.com/repos/helloyi/lua-nginx-module/compare/{base}...{head}","merges_url":"https://api.github.com/repos/helloyi/lua-nginx-module/merges","archive_url":"https://api.github.com/repos/helloyi/lua-nginx-module/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/helloyi/lua-nginx-module/downloads","issues_url":"https://api.github.com/repos/helloyi/lua-nginx-module/issues{/number}","pulls_url":"https://api.github.com/repos/helloyi/lua-nginx-module/pulls{/number}","milestones_url":"https://api.github.com/repos/helloyi/lua-nginx-module/milestones{/number}","notifications_url":"https://api.github.com/repos/helloyi/lua-nginx-module/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/helloyi/lua-nginx-module/labels{/name}","releases_url":"https://api.github.com/repos/helloyi/lua-nginx-module/releases{/id}","deployments_url":"https://api.github.com/repos/helloyi/lua-nginx-module/deployments","created_at":"2015-08-25T15:52:42Z","updated_at":"2016-07-04T10:13:49Z","pushed_at":"2016-07-24T13:12:26Z","git_url":"git://github.com/helloyi/lua-nginx-module.git","ssh_url":"git@github.com:helloyi/lua-nginx-module.git","clone_url":"https://github.com/helloyi/lua-nginx-module.git","svn_url":"https://github.com/helloyi/lua-nginx-module","homepage":"http://openresty.org","size":14560,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openresty:master","ref":"master","sha":"a5ac9fa2e623854178c3fbb77f643cc95226a3e9","user":{"login":"openresty","id":7390180,"avatar_url":"https://avatars.githubusercontent.com/u/7390180?v=3","gravatar_id":"","url":"https://api.github.com/users/openresty","html_url":"https://github.com/openresty","followers_url":"https://api.github.com/users/openresty/followers","following_url":"https://api.github.com/users/openresty/following{/other_user}","gists_url":"https://api.github.com/users/openresty/gists{/gist_id}","starred_url":"https://api.github.com/users/openresty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openresty/subscriptions","organizations_url":"https://api.github.com/users/openresty/orgs","repos_url":"https://api.github.com/users/openresty/repos","events_url":"https://api.github.com/users/openresty/events{/privacy}","received_events_url":"https://api.github.com/users/openresty/received_events","type":"Organization","site_admin":false},"repo":{"id":613829,"name":"lua-nginx-module","full_name":"openresty/lua-nginx-module","owner":{"login":"openresty","id":7390180,"avatar_url":"https://avatars.githubusercontent.com/u/7390180?v=3","gravatar_id":"","url":"https://api.github.com/users/openresty","html_url":"https://github.com/openresty","followers_url":"https://api.github.com/users/openresty/followers","following_url":"https://api.github.com/users/openresty/following{/other_user}","gists_url":"https://api.github.com/users/openresty/gists{/gist_id}","starred_url":"https://api.github.com/users/openresty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openresty/subscriptions","organizations_url":"https://api.github.com/users/openresty/orgs","repos_url":"https://api.github.com/users/openresty/repos","events_url":"https://api.github.com/users/openresty/events{/privacy}","received_events_url":"https://api.github.com/users/openresty/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openresty/lua-nginx-module","description":"Embed the Power of Lua into NGINX HTTP servers","fork":false,"url":"https://api.github.com/repos/openresty/lua-nginx-module","forks_url":"https://api.github.com/repos/openresty/lua-nginx-module/forks","keys_url":"https://api.github.com/repos/openresty/lua-nginx-module/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openresty/lua-nginx-module/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openresty/lua-nginx-module/teams","hooks_url":"https://api.github.com/repos/openresty/lua-nginx-module/hooks","issue_events_url":"https://api.github.com/repos/openresty/lua-nginx-module/issues/events{/number}","events_url":"https://api.github.com/repos/openresty/lua-nginx-module/events","assignees_url":"https://api.github.com/repos/openresty/lua-nginx-module/assignees{/user}","branches_url":"https://api.github.com/repos/openresty/lua-nginx-module/branches{/branch}","tags_url":"https://api.github.com/repos/openresty/lua-nginx-module/tags","blobs_url":"https://api.github.com/repos/openresty/lua-nginx-module/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openresty/lua-nginx-module/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openresty/lua-nginx-module/git/refs{/sha}","trees_url":"https://api.github.com/repos/openresty/lua-nginx-module/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openresty/lua-nginx-module/statuses/{sha}","languages_url":"https://api.github.com/repos/openresty/lua-nginx-module/languages","stargazers_url":"https://api.github.com/repos/openresty/lua-nginx-module/stargazers","contributors_url":"https://api.github.com/repos/openresty/lua-nginx-module/contributors","subscribers_url":"https://api.github.com/repos/openresty/lua-nginx-module/subscribers","subscription_url":"https://api.github.com/repos/openresty/lua-nginx-module/subscription","commits_url":"https://api.github.com/repos/openresty/lua-nginx-module/commits{/sha}","git_commits_url":"https://api.github.com/repos/openresty/lua-nginx-module/git/commits{/sha}","comments_url":"https://api.github.com/repos/openresty/lua-nginx-module/comments{/number}","issue_comment_url":"https://api.github.com/repos/openresty/lua-nginx-module/issues/comments{/number}","contents_url":"https://api.github.com/repos/openresty/lua-nginx-module/contents/{+path}","compare_url":"https://api.github.com/repos/openresty/lua-nginx-module/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openresty/lua-nginx-module/merges","archive_url":"https://api.github.com/repos/openresty/lua-nginx-module/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openresty/lua-nginx-module/downloads","issues_url":"https://api.github.com/repos/openresty/lua-nginx-module/issues{/number}","pulls_url":"https://api.github.com/repos/openresty/lua-nginx-module/pulls{/number}","milestones_url":"https://api.github.com/repos/openresty/lua-nginx-module/milestones{/number}","notifications_url":"https://api.github.com/repos/openresty/lua-nginx-module/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openresty/lua-nginx-module/labels{/name}","releases_url":"https://api.github.com/repos/openresty/lua-nginx-module/releases{/id}","deployments_url":"https://api.github.com/repos/openresty/lua-nginx-module/deployments","created_at":"2010-04-16T15:59:01Z","updated_at":"2016-07-23T16:30:34Z","pushed_at":"2016-07-24T13:29:23Z","git_url":"git://github.com/openresty/lua-nginx-module.git","ssh_url":"git@github.com:openresty/lua-nginx-module.git","clone_url":"https://github.com/openresty/lua-nginx-module.git","svn_url":"https://github.com/openresty/lua-nginx-module","homepage":"https://openresty.org/","size":19081,"stargazers_count":3176,"watchers_count":3176,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":722,"mirror_url":null,"open_issues_count":73,"forks":722,"open_issues":73,"watchers":3176,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openresty/lua-nginx-module/pulls/823"},"html":{"href":"https://github.com/openresty/lua-nginx-module/pull/823"},"issue":{"href":"https://api.github.com/repos/openresty/lua-nginx-module/issues/823"},"comments":{"href":"https://api.github.com/repos/openresty/lua-nginx-module/issues/823/comments"},"review_comments":{"href":"https://api.github.com/repos/openresty/lua-nginx-module/pulls/823/comments"},"review_comment":{"href":"https://api.github.com/repos/openresty/lua-nginx-module/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openresty/lua-nginx-module/pulls/823/commits"},"statuses":{"href":"https://api.github.com/repos/openresty/lua-nginx-module/statuses/5fc25f0a3fe3e9b2b162e82742f467579b0cdc3e"}}}}
{"actor":{"display_login":"agentzh"}}