{"action":"created","issue":{"url":"https://api.github.com/repos/levnach/z3/issues/2","repository_url":"https://api.github.com/repos/levnach/z3","labels_url":"https://api.github.com/repos/levnach/z3/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/levnach/z3/issues/2/comments","events_url":"https://api.github.com/repos/levnach/z3/issues/2/events","html_url":"https://github.com/levnach/z3/pull/2","id":147770042,"number":2,"title":"adding LRA functionality","user":{"login":"NikolajBjorner","id":3085284,"avatar_url":"https://avatars.githubusercontent.com/u/3085284?v=3","gravatar_id":"","url":"https://api.github.com/users/NikolajBjorner","html_url":"https://github.com/NikolajBjorner","followers_url":"https://api.github.com/users/NikolajBjorner/followers","following_url":"https://api.github.com/users/NikolajBjorner/following{/other_user}","gists_url":"https://api.github.com/users/NikolajBjorner/gists{/gist_id}","starred_url":"https://api.github.com/users/NikolajBjorner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NikolajBjorner/subscriptions","organizations_url":"https://api.github.com/users/NikolajBjorner/orgs","repos_url":"https://api.github.com/users/NikolajBjorner/repos","events_url":"https://api.github.com/users/NikolajBjorner/events{/privacy}","received_events_url":"https://api.github.com/users/NikolajBjorner/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-04-12T14:30:40Z","updated_at":"2016-04-13T23:48:32Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/levnach/z3/pulls/2","html_url":"https://github.com/levnach/z3/pull/2","diff_url":"https://github.com/levnach/z3/pull/2.diff","patch_url":"https://github.com/levnach/z3/pull/2.patch"},"body":"several things are TBD, but exposes a few questions, such as:\r\n1. what is the design for using infinitesimals?\r\n2. the design for cancellation can be more general. Instead of setting a time limit\r\n    expose a method for setting an abstract class that can be queried for cancellation and resource bounds. The class could have a signature of the form:\r\n\r\n        class resource_limit {\r\n        public:\r\n             virtual bool get_cancel_flag() = 0;\r\n        }\r\n\r\nThen lp_solver has a method:\r\n\r\n       void set_resource(resource_limit* rl) { m_resource_limit = rl; }\r\n\r\nand a private:\r\n\r\n       bool canceled() { m_resource_limit && m_resource_limit->get_cancel_flag(); }\r\n"},"comment":{"url":"https://api.github.com/repos/levnach/z3/issues/comments/209693790","html_url":"https://github.com/levnach/z3/pull/2#issuecomment-209693790","issue_url":"https://api.github.com/repos/levnach/z3/issues/2","id":209693790,"user":{"login":"NikolajBjorner","id":3085284,"avatar_url":"https://avatars.githubusercontent.com/u/3085284?v=3","gravatar_id":"","url":"https://api.github.com/users/NikolajBjorner","html_url":"https://github.com/NikolajBjorner","followers_url":"https://api.github.com/users/NikolajBjorner/followers","following_url":"https://api.github.com/users/NikolajBjorner/following{/other_user}","gists_url":"https://api.github.com/users/NikolajBjorner/gists{/gist_id}","starred_url":"https://api.github.com/users/NikolajBjorner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NikolajBjorner/subscriptions","organizations_url":"https://api.github.com/users/NikolajBjorner/orgs","repos_url":"https://api.github.com/users/NikolajBjorner/repos","events_url":"https://api.github.com/users/NikolajBjorner/events{/privacy}","received_events_url":"https://api.github.com/users/NikolajBjorner/received_events","type":"User","site_admin":false},"created_at":"2016-04-13T23:48:32Z","updated_at":"2016-04-13T23:48:32Z","body":"Related to the use of T and X (I guess one is for numerals used for coefficients, the other is for numerals that the variables can have. Consider the following code:\r\n\r\n<code>\r\n        template <typename T, typename X>\r\n        struct lp_constraint {\r\n             X m_rs; // right side of the constraint\r\n             lp_relation m_relation;\r\n             lp_constraint() {} // empty constructor\r\n             lp_constraint(T rs, lp_relation relation): m_rs(rs), m_relation(relation) {}\r\n       };\r\n</code>\r\nThe template variable X is used for m_rs, but the template variable T is used in the constructor.\r\nSo X has to be equal to T in all legal uses. This would appear to me as a typo.\r\n"}}