{"action":"created","comment":{"url":"https://api.github.com/repos/ThaDafinser/ZfcDatagrid/pulls/comments/59363893","id":59363893,"diff_hunk":"@@ -1,21 +1,22 @@\n <?php\n namespace ZfcDatagrid\\Renderer\\BootstrapTable\\View\\Helper;\n \n+use Zend\\ServiceManager\\AbstractPluginManager;\n use Zend\\ServiceManager\\FactoryInterface;\n use Zend\\ServiceManager\\ServiceLocatorInterface;\n \n class TableRowFactory implements FactoryInterface\n {\n     /**\n-     * @param  ServiceLocatorInterface $serviceLocator\n+     * @param  ServiceLocatorInterface|AbstractPluginManager $serviceLocator","path":"src/ZfcDatagrid/Renderer/BootstrapTable/View/Helper/TableRowFactory.php","position":12,"original_position":12,"commit_id":"41a26108db6e170b7a32b8425eef2ca0eac67c20","original_commit_id":"41a26108db6e170b7a32b8425eef2ca0eac67c20","user":{"login":"kokspflanze","id":1885435,"avatar_url":"https://avatars.githubusercontent.com/u/1885435?v=3","gravatar_id":"","url":"https://api.github.com/users/kokspflanze","html_url":"https://github.com/kokspflanze","followers_url":"https://api.github.com/users/kokspflanze/followers","following_url":"https://api.github.com/users/kokspflanze/following{/other_user}","gists_url":"https://api.github.com/users/kokspflanze/gists{/gist_id}","starred_url":"https://api.github.com/users/kokspflanze/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kokspflanze/subscriptions","organizations_url":"https://api.github.com/users/kokspflanze/orgs","repos_url":"https://api.github.com/users/kokspflanze/repos","events_url":"https://api.github.com/users/kokspflanze/events{/privacy}","received_events_url":"https://api.github.com/users/kokspflanze/received_events","type":"User","site_admin":false},"body":"the method signature is from https://github.com/zendframework/zend-servicemanager/blob/release-2.7.5/src/FactoryInterface.php#L20\r\n\r\nthe $serviceLocator is `Zend\\View\\HelperPluginManager` and if we call there, only the get method, than we get only view_plugins and not the \"global\" services\r\n\r\nhttp://robertbasic.com/blog/working-with-custom-view-helpers-in-zend-framework-2/","created_at":"2016-04-12T12:06:40Z","updated_at":"2016-04-12T12:06:40Z","html_url":"https://github.com/ThaDafinser/ZfcDatagrid/pull/234#discussion_r59363893","pull_request_url":"https://api.github.com/repos/ThaDafinser/ZfcDatagrid/pulls/234","_links":{"self":{"href":"https://api.github.com/repos/ThaDafinser/ZfcDatagrid/pulls/comments/59363893"},"html":{"href":"https://github.com/ThaDafinser/ZfcDatagrid/pull/234#discussion_r59363893"},"pull_request":{"href":"https://api.github.com/repos/ThaDafinser/ZfcDatagrid/pulls/234"}}},"pull_request":{"url":"https://api.github.com/repos/ThaDafinser/ZfcDatagrid/pulls/234","id":65409937,"html_url":"https://github.com/ThaDafinser/ZfcDatagrid/pull/234","diff_url":"https://github.com/ThaDafinser/ZfcDatagrid/pull/234.diff","patch_url":"https://github.com/ThaDafinser/ZfcDatagrid/pull/234.patch","issue_url":"https://api.github.com/repos/ThaDafinser/ZfcDatagrid/issues/234","number":234,"state":"open","locked":false,"title":"view helper AbstractPluginManager","user":{"login":"kokspflanze","id":1885435,"avatar_url":"https://avatars.githubusercontent.com/u/1885435?v=3","gravatar_id":"","url":"https://api.github.com/users/kokspflanze","html_url":"https://github.com/kokspflanze","followers_url":"https://api.github.com/users/kokspflanze/followers","following_url":"https://api.github.com/users/kokspflanze/following{/other_user}","gists_url":"https://api.github.com/users/kokspflanze/gists{/gist_id}","starred_url":"https://api.github.com/users/kokspflanze/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kokspflanze/subscriptions","organizations_url":"https://api.github.com/users/kokspflanze/orgs","repos_url":"https://api.github.com/users/kokspflanze/repos","events_url":"https://api.github.com/users/kokspflanze/events{/privacy}","received_events_url":"https://api.github.com/users/kokspflanze/received_events","type":"User","site_admin":false},"body":"hi,\r\n\r\nadded getServiceLocator in both view-helper, we get there a `Zend\\ServiceManager\\AbstractPluginManager` object so we have to use this method.","created_at":"2016-04-06T04:53:55Z","updated_at":"2016-04-12T12:06:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7bafe73fa5ece58033f5526883dc5a08d897ac61","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ThaDafinser/ZfcDatagrid/pulls/234/commits","review_comments_url":"https://api.github.com/repos/ThaDafinser/ZfcDatagrid/pulls/234/comments","review_comment_url":"https://api.github.com/repos/ThaDafinser/ZfcDatagrid/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ThaDafinser/ZfcDatagrid/issues/234/comments","statuses_url":"https://api.github.com/repos/ThaDafinser/ZfcDatagrid/statuses/41a26108db6e170b7a32b8425eef2ca0eac67c20","head":{"label":"kokspflanze:bugfix/view_helper","ref":"bugfix/view_helper","sha":"41a26108db6e170b7a32b8425eef2ca0eac67c20","user":{"login":"kokspflanze","id":1885435,"avatar_url":"https://avatars.githubusercontent.com/u/1885435?v=3","gravatar_id":"","url":"https://api.github.com/users/kokspflanze","html_url":"https://github.com/kokspflanze","followers_url":"https://api.github.com/users/kokspflanze/followers","following_url":"https://api.github.com/users/kokspflanze/following{/other_user}","gists_url":"https://api.github.com/users/kokspflanze/gists{/gist_id}","starred_url":"https://api.github.com/users/kokspflanze/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kokspflanze/subscriptions","organizations_url":"https://api.github.com/users/kokspflanze/orgs","repos_url":"https://api.github.com/users/kokspflanze/repos","events_url":"https://api.github.com/users/kokspflanze/events{/privacy}","received_events_url":"https://api.github.com/users/kokspflanze/received_events","type":"User","site_admin":false},"repo":{"id":31854511,"name":"ZfcDatagrid","full_name":"kokspflanze/ZfcDatagrid","owner":{"login":"kokspflanze","id":1885435,"avatar_url":"https://avatars.githubusercontent.com/u/1885435?v=3","gravatar_id":"","url":"https://api.github.com/users/kokspflanze","html_url":"https://github.com/kokspflanze","followers_url":"https://api.github.com/users/kokspflanze/followers","following_url":"https://api.github.com/users/kokspflanze/following{/other_user}","gists_url":"https://api.github.com/users/kokspflanze/gists{/gist_id}","starred_url":"https://api.github.com/users/kokspflanze/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kokspflanze/subscriptions","organizations_url":"https://api.github.com/users/kokspflanze/orgs","repos_url":"https://api.github.com/users/kokspflanze/repos","events_url":"https://api.github.com/users/kokspflanze/events{/privacy}","received_events_url":"https://api.github.com/users/kokspflanze/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kokspflanze/ZfcDatagrid","description":"A datagrid module for ZF2 with different datasources (Doctrine2, Zend\\Db, Array, ...) and output formats (jqGrid. Bootstrap, CLI, PDF, Excel,...)","fork":true,"url":"https://api.github.com/repos/kokspflanze/ZfcDatagrid","forks_url":"https://api.github.com/repos/kokspflanze/ZfcDatagrid/forks","keys_url":"https://api.github.com/repos/kokspflanze/ZfcDatagrid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kokspflanze/ZfcDatagrid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kokspflanze/ZfcDatagrid/teams","hooks_url":"https://api.github.com/repos/kokspflanze/ZfcDatagrid/hooks","issue_events_url":"https://api.github.com/repos/kokspflanze/ZfcDatagrid/issues/events{/number}","events_url":"https://api.github.com/repos/kokspflanze/ZfcDatagrid/events","assignees_url":"https://api.github.com/repos/kokspflanze/ZfcDatagrid/assignees{/user}","branches_url":"https://api.github.com/repos/kokspflanze/ZfcDatagrid/branches{/branch}","tags_url":"https://api.github.com/repos/kokspflanze/ZfcDatagrid/tags","blobs_url":"https://api.github.com/repos/kokspflanze/ZfcDatagrid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kokspflanze/ZfcDatagrid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kokspflanze/ZfcDatagrid/git/refs{/sha}","trees_url":"https://api.github.com/repos/kokspflanze/ZfcDatagrid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kokspflanze/ZfcDatagrid/statuses/{sha}","languages_url":"https://api.github.com/repos/kokspflanze/ZfcDatagrid/languages","stargazers_url":"https://api.github.com/repos/kokspflanze/ZfcDatagrid/stargazers","contributors_url":"https://api.github.com/repos/kokspflanze/ZfcDatagrid/contributors","subscribers_url":"https://api.github.com/repos/kokspflanze/ZfcDatagrid/subscribers","subscription_url":"https://api.github.com/repos/kokspflanze/ZfcDatagrid/subscription","commits_url":"https://api.github.com/repos/kokspflanze/ZfcDatagrid/commits{/sha}","git_commits_url":"https://api.github.com/repos/kokspflanze/ZfcDatagrid/git/commits{/sha}","comments_url":"https://api.github.com/repos/kokspflanze/ZfcDatagrid/comments{/number}","issue_comment_url":"https://api.github.com/repos/kokspflanze/ZfcDatagrid/issues/comments{/number}","contents_url":"https://api.github.com/repos/kokspflanze/ZfcDatagrid/contents/{+path}","compare_url":"https://api.github.com/repos/kokspflanze/ZfcDatagrid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kokspflanze/ZfcDatagrid/merges","archive_url":"https://api.github.com/repos/kokspflanze/ZfcDatagrid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kokspflanze/ZfcDatagrid/downloads","issues_url":"https://api.github.com/repos/kokspflanze/ZfcDatagrid/issues{/number}","pulls_url":"https://api.github.com/repos/kokspflanze/ZfcDatagrid/pulls{/number}","milestones_url":"https://api.github.com/repos/kokspflanze/ZfcDatagrid/milestones{/number}","notifications_url":"https://api.github.com/repos/kokspflanze/ZfcDatagrid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kokspflanze/ZfcDatagrid/labels{/name}","releases_url":"https://api.github.com/repos/kokspflanze/ZfcDatagrid/releases{/id}","deployments_url":"https://api.github.com/repos/kokspflanze/ZfcDatagrid/deployments","created_at":"2015-03-08T15:25:45Z","updated_at":"2016-04-05T21:55:21Z","pushed_at":"2016-04-05T21:55:17Z","git_url":"git://github.com/kokspflanze/ZfcDatagrid.git","ssh_url":"git@github.com:kokspflanze/ZfcDatagrid.git","clone_url":"https://github.com/kokspflanze/ZfcDatagrid.git","svn_url":"https://github.com/kokspflanze/ZfcDatagrid","homepage":"","size":1579,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ThaDafinser:develop","ref":"develop","sha":"ba02f46932b56cedb8f6e701ae28c182bedcc62b","user":{"login":"ThaDafinser","id":533017,"avatar_url":"https://avatars.githubusercontent.com/u/533017?v=3","gravatar_id":"","url":"https://api.github.com/users/ThaDafinser","html_url":"https://github.com/ThaDafinser","followers_url":"https://api.github.com/users/ThaDafinser/followers","following_url":"https://api.github.com/users/ThaDafinser/following{/other_user}","gists_url":"https://api.github.com/users/ThaDafinser/gists{/gist_id}","starred_url":"https://api.github.com/users/ThaDafinser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThaDafinser/subscriptions","organizations_url":"https://api.github.com/users/ThaDafinser/orgs","repos_url":"https://api.github.com/users/ThaDafinser/repos","events_url":"https://api.github.com/users/ThaDafinser/events{/privacy}","received_events_url":"https://api.github.com/users/ThaDafinser/received_events","type":"User","site_admin":false},"repo":{"id":9669251,"name":"ZfcDatagrid","full_name":"ThaDafinser/ZfcDatagrid","owner":{"login":"ThaDafinser","id":533017,"avatar_url":"https://avatars.githubusercontent.com/u/533017?v=3","gravatar_id":"","url":"https://api.github.com/users/ThaDafinser","html_url":"https://github.com/ThaDafinser","followers_url":"https://api.github.com/users/ThaDafinser/followers","following_url":"https://api.github.com/users/ThaDafinser/following{/other_user}","gists_url":"https://api.github.com/users/ThaDafinser/gists{/gist_id}","starred_url":"https://api.github.com/users/ThaDafinser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThaDafinser/subscriptions","organizations_url":"https://api.github.com/users/ThaDafinser/orgs","repos_url":"https://api.github.com/users/ThaDafinser/repos","events_url":"https://api.github.com/users/ThaDafinser/events{/privacy}","received_events_url":"https://api.github.com/users/ThaDafinser/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ThaDafinser/ZfcDatagrid","description":"A datagrid module for ZF2 with different datasources (Doctrine2, Zend\\Db, Array, ...) and output formats (jqGrid. Bootstrap, CLI, PDF, Excel,...)","fork":false,"url":"https://api.github.com/repos/ThaDafinser/ZfcDatagrid","forks_url":"https://api.github.com/repos/ThaDafinser/ZfcDatagrid/forks","keys_url":"https://api.github.com/repos/ThaDafinser/ZfcDatagrid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ThaDafinser/ZfcDatagrid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ThaDafinser/ZfcDatagrid/teams","hooks_url":"https://api.github.com/repos/ThaDafinser/ZfcDatagrid/hooks","issue_events_url":"https://api.github.com/repos/ThaDafinser/ZfcDatagrid/issues/events{/number}","events_url":"https://api.github.com/repos/ThaDafinser/ZfcDatagrid/events","assignees_url":"https://api.github.com/repos/ThaDafinser/ZfcDatagrid/assignees{/user}","branches_url":"https://api.github.com/repos/ThaDafinser/ZfcDatagrid/branches{/branch}","tags_url":"https://api.github.com/repos/ThaDafinser/ZfcDatagrid/tags","blobs_url":"https://api.github.com/repos/ThaDafinser/ZfcDatagrid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ThaDafinser/ZfcDatagrid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ThaDafinser/ZfcDatagrid/git/refs{/sha}","trees_url":"https://api.github.com/repos/ThaDafinser/ZfcDatagrid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ThaDafinser/ZfcDatagrid/statuses/{sha}","languages_url":"https://api.github.com/repos/ThaDafinser/ZfcDatagrid/languages","stargazers_url":"https://api.github.com/repos/ThaDafinser/ZfcDatagrid/stargazers","contributors_url":"https://api.github.com/repos/ThaDafinser/ZfcDatagrid/contributors","subscribers_url":"https://api.github.com/repos/ThaDafinser/ZfcDatagrid/subscribers","subscription_url":"https://api.github.com/repos/ThaDafinser/ZfcDatagrid/subscription","commits_url":"https://api.github.com/repos/ThaDafinser/ZfcDatagrid/commits{/sha}","git_commits_url":"https://api.github.com/repos/ThaDafinser/ZfcDatagrid/git/commits{/sha}","comments_url":"https://api.github.com/repos/ThaDafinser/ZfcDatagrid/comments{/number}","issue_comment_url":"https://api.github.com/repos/ThaDafinser/ZfcDatagrid/issues/comments{/number}","contents_url":"https://api.github.com/repos/ThaDafinser/ZfcDatagrid/contents/{+path}","compare_url":"https://api.github.com/repos/ThaDafinser/ZfcDatagrid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ThaDafinser/ZfcDatagrid/merges","archive_url":"https://api.github.com/repos/ThaDafinser/ZfcDatagrid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ThaDafinser/ZfcDatagrid/downloads","issues_url":"https://api.github.com/repos/ThaDafinser/ZfcDatagrid/issues{/number}","pulls_url":"https://api.github.com/repos/ThaDafinser/ZfcDatagrid/pulls{/number}","milestones_url":"https://api.github.com/repos/ThaDafinser/ZfcDatagrid/milestones{/number}","notifications_url":"https://api.github.com/repos/ThaDafinser/ZfcDatagrid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ThaDafinser/ZfcDatagrid/labels{/name}","releases_url":"https://api.github.com/repos/ThaDafinser/ZfcDatagrid/releases{/id}","deployments_url":"https://api.github.com/repos/ThaDafinser/ZfcDatagrid/deployments","created_at":"2013-04-25T10:25:28Z","updated_at":"2016-01-22T08:21:45Z","pushed_at":"2016-04-06T04:53:56Z","git_url":"git://github.com/ThaDafinser/ZfcDatagrid.git","ssh_url":"git@github.com:ThaDafinser/ZfcDatagrid.git","clone_url":"https://github.com/ThaDafinser/ZfcDatagrid.git","svn_url":"https://github.com/ThaDafinser/ZfcDatagrid","homepage":"","size":1678,"stargazers_count":90,"watchers_count":90,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":55,"mirror_url":null,"open_issues_count":27,"forks":55,"open_issues":27,"watchers":90,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ThaDafinser/ZfcDatagrid/pulls/234"},"html":{"href":"https://github.com/ThaDafinser/ZfcDatagrid/pull/234"},"issue":{"href":"https://api.github.com/repos/ThaDafinser/ZfcDatagrid/issues/234"},"comments":{"href":"https://api.github.com/repos/ThaDafinser/ZfcDatagrid/issues/234/comments"},"review_comments":{"href":"https://api.github.com/repos/ThaDafinser/ZfcDatagrid/pulls/234/comments"},"review_comment":{"href":"https://api.github.com/repos/ThaDafinser/ZfcDatagrid/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ThaDafinser/ZfcDatagrid/pulls/234/commits"},"statuses":{"href":"https://api.github.com/repos/ThaDafinser/ZfcDatagrid/statuses/41a26108db6e170b7a32b8425eef2ca0eac67c20"}}}}