{"action":"created","issue":{"url":"https://api.github.com/repos/lishid/Orebfuscator/issues/125","repository_url":"https://api.github.com/repos/lishid/Orebfuscator","labels_url":"https://api.github.com/repos/lishid/Orebfuscator/issues/125/labels{/name}","comments_url":"https://api.github.com/repos/lishid/Orebfuscator/issues/125/comments","events_url":"https://api.github.com/repos/lishid/Orebfuscator/issues/125/events","html_url":"https://github.com/lishid/Orebfuscator/issues/125","id":173577352,"number":125,"title":"Orebfuscator obfuscating chunks for Citizens NPC's","user":{"login":"astr1al","id":8759521,"avatar_url":"https://avatars.githubusercontent.com/u/8759521?v=3","gravatar_id":"","url":"https://api.github.com/users/astr1al","html_url":"https://github.com/astr1al","followers_url":"https://api.github.com/users/astr1al/followers","following_url":"https://api.github.com/users/astr1al/following{/other_user}","gists_url":"https://api.github.com/users/astr1al/gists{/gist_id}","starred_url":"https://api.github.com/users/astr1al/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astr1al/subscriptions","organizations_url":"https://api.github.com/users/astr1al/orgs","repos_url":"https://api.github.com/users/astr1al/repos","events_url":"https://api.github.com/users/astr1al/events{/privacy}","received_events_url":"https://api.github.com/users/astr1al/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":15,"created_at":"2016-08-27T04:33:45Z","updated_at":"2016-08-31T17:06:52Z","closed_at":null,"body":"My server seems to lag more over time, and is scheduled to restart every 24 hours. After some help from Spigot IRC evaluating a heap dump, they were able to determine that orebfuscator is trying to hide ores from NPC's from the Citizens plugin. https://cl.ly/3F2G3S3q1x40\r\n\r\nThis is on build 4.1.4 on spigot 1.10.2"},"comment":{"url":"https://api.github.com/repos/lishid/Orebfuscator/issues/comments/243832308","html_url":"https://github.com/lishid/Orebfuscator/issues/125#issuecomment-243832308","issue_url":"https://api.github.com/repos/lishid/Orebfuscator/issues/125","id":243832308,"user":{"login":"BlackCoyote","id":6047423,"avatar_url":"https://avatars.githubusercontent.com/u/6047423?v=3","gravatar_id":"","url":"https://api.github.com/users/BlackCoyote","html_url":"https://github.com/BlackCoyote","followers_url":"https://api.github.com/users/BlackCoyote/followers","following_url":"https://api.github.com/users/BlackCoyote/following{/other_user}","gists_url":"https://api.github.com/users/BlackCoyote/gists{/gist_id}","starred_url":"https://api.github.com/users/BlackCoyote/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BlackCoyote/subscriptions","organizations_url":"https://api.github.com/users/BlackCoyote/orgs","repos_url":"https://api.github.com/users/BlackCoyote/repos","events_url":"https://api.github.com/users/BlackCoyote/events{/privacy}","received_events_url":"https://api.github.com/users/BlackCoyote/received_events","type":"User","site_admin":false},"created_at":"2016-08-31T17:06:51Z","updated_at":"2016-08-31T17:06:51Z","body":"@ProgrammerDan Generally speaking, It is never worth obfuscating ores for NPCS, since NPCS can't see them like that anyway. Your example of the player following the mining NPC is going to be an issue regardless of whether or not the NPC's ores are obfuscated as NPCS will read the world data directly on the server anyway. Any limitations the NPC would have, would have to be programmed in its own behaviour.\r\n\r\nIt's understandable you'd much rather want to work with a generalized meta tag rather than one for citizens specificly. However, Citizens, being the highest ranked NPC plugin at rank 9 of all tracked plugins, is setting the example for the \"NPC\" metadata to be this standard. A fair few plugins such as worldguard have adopted this as the standard method to detect if an entity is an NPC, making it the most common method for detecting NPCS already right now. Any NPC plugin that has not updated to this method is either one that is failing to stay up to date or has very stubborn developers! Besides that, it is simply more logical to, when you want an NPC to not mimic various player based scenarios, to just mark the entity as an NPC, rather than to mark that entity with all the behaviours you want to prevent it from triggering.\r\n\r\nYou suggested having ultimate control on a per NPC base by using permissions, and, though potentially pointless, that would have been an interesting feature to have, but as @mcmonkey4eva pointes out, adding permissions for NPCs would be extremely dificult if not impossible.\r\n\r\nUltimately, I genuinely do believe that, Orebfuscator, The definitive Anti X-Ray plugin for CraftBukkit, should only be obfuscating ores for those who can actually use X-Ray mods. and not NPCS who have serverside programming that would render orebfuscator's attempts to blur its vision useless. And since the metadata \"NPC\" is going to be the right method to detect if the entity is an NPC the vast majority of the time, it is going to be the best the way to accomplish that.\r\nIf you're truly concerned that in some scenarios, trying to obfuscate the vision for NPCS is a useful thing, we can always ask for it to be a configurable option in general.\r\n\r\n\r\nSorry for the long read, I hope you take the time to read through this! :)\r\n"}}
{"actor":{"display_login":"BlackCoyote"}}