{"action":"created","comment":{"url":"https://api.github.com/repos/openssl/openssl/pulls/comments/84488922","pull_request_review_id":5265054,"id":84488922,"diff_hunk":"@@ -64,10 +64,11 @@ TLS/SSL I/O function should be retried.\n \n Caveat: Any TLS/SSL I/O function can lead to either of\n B<SSL_ERROR_WANT_READ> and B<SSL_ERROR_WANT_WRITE>.  In particular,\n-SSL_read() or SSL_peek() may want to write data and SSL_write() may want\n-to read data.  This is mainly because TLS/SSL handshakes may occur at any\n-time during the protocol (initiated by either the client or the server);\n-SSL_read(), SSL_peek(), and SSL_write() will handle any pending handshakes.\n+SSL_read_ex(), SSL_read() SSL_peek_ex() or SSL_peek() may want to write data and","path":"doc/ssl/SSL_get_error.pod","position":21,"original_position":21,"commit_id":"caa31742ce1c1029b2dc698616bf050b3f5ea31c","original_commit_id":"caa31742ce1c1029b2dc698616bf050b3f5ea31c","user":{"login":"richsalz","id":7332500,"avatar_url":"https://avatars.githubusercontent.com/u/7332500?v=3","gravatar_id":"","url":"https://api.github.com/users/richsalz","html_url":"https://github.com/richsalz","followers_url":"https://api.github.com/users/richsalz/followers","following_url":"https://api.github.com/users/richsalz/following{/other_user}","gists_url":"https://api.github.com/users/richsalz/gists{/gist_id}","starred_url":"https://api.github.com/users/richsalz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richsalz/subscriptions","organizations_url":"https://api.github.com/users/richsalz/orgs","repos_url":"https://api.github.com/users/richsalz/repos","events_url":"https://api.github.com/users/richsalz/events{/privacy}","received_events_url":"https://api.github.com/users/richsalz/received_events","type":"User","site_admin":false},"body":"missing commas after read,peek_ex, and peek.","created_at":"2016-10-21T14:22:09Z","updated_at":"2016-10-21T14:22:09Z","html_url":"https://github.com/openssl/openssl/pull/1751#discussion_r84488922","pull_request_url":"https://api.github.com/repos/openssl/openssl/pulls/1751","_links":{"self":{"href":"https://api.github.com/repos/openssl/openssl/pulls/comments/84488922"},"html":{"href":"https://github.com/openssl/openssl/pull/1751#discussion_r84488922"},"pull_request":{"href":"https://api.github.com/repos/openssl/openssl/pulls/1751"}}},"pull_request":{"url":"https://api.github.com/repos/openssl/openssl/pulls/1751","id":90213380,"html_url":"https://github.com/openssl/openssl/pull/1751","diff_url":"https://github.com/openssl/openssl/pull/1751.diff","patch_url":"https://github.com/openssl/openssl/pull/1751.patch","issue_url":"https://api.github.com/repos/openssl/openssl/issues/1751","number":1751,"state":"open","locked":false,"title":"Size_t-ify libssl","user":{"login":"mattcaswell","id":7422273,"avatar_url":"https://avatars.githubusercontent.com/u/7422273?v=3","gravatar_id":"","url":"https://api.github.com/users/mattcaswell","html_url":"https://github.com/mattcaswell","followers_url":"https://api.github.com/users/mattcaswell/followers","following_url":"https://api.github.com/users/mattcaswell/following{/other_user}","gists_url":"https://api.github.com/users/mattcaswell/gists{/gist_id}","starred_url":"https://api.github.com/users/mattcaswell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattcaswell/subscriptions","organizations_url":"https://api.github.com/users/mattcaswell/orgs","repos_url":"https://api.github.com/users/mattcaswell/repos","events_url":"https://api.github.com/users/mattcaswell/events{/privacy}","received_events_url":"https://api.github.com/users/mattcaswell/received_events","type":"User","site_admin":false},"body":"This is a more-or-less complete conversion of the whole implementation of libssl to use size_t for sizes of things where appropriate. It is the second part of two PRs (see #1750 for the first part). A third PR will be required with a small amount of work to join the two halves together (although they can be reviewed and implemented entirely independently).\r\n\r\nThis introduces SSL_read_ex(), SSL_write_ex() and SSL_peek_ex() which use size_t arguments and return size_t information about the number of bytes read/written. All internal structure members and function arguments have been converted to use size_t where appropriate.\r\n\r\nThe boundary of this conversion is libssl. This means there are a number of \"TODOs\" left in the code where we call into libcrypto, and in those locations various type conversions need to take place.\r\n\r\nI have not converted other libssl APIs which should probably have been size_t from the start, and instead do the necessary casts/conversions internally where needed. Over time we may want to convert some of those too.","created_at":"2016-10-20T14:36:16Z","updated_at":"2016-10-21T14:30:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"64091357ede285fa9b828a6a23f01b477d954874","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/openssl/openssl/pulls/1751/commits","review_comments_url":"https://api.github.com/repos/openssl/openssl/pulls/1751/comments","review_comment_url":"https://api.github.com/repos/openssl/openssl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openssl/openssl/issues/1751/comments","statuses_url":"https://api.github.com/repos/openssl/openssl/statuses/caa31742ce1c1029b2dc698616bf050b3f5ea31c","head":{"label":"mattcaswell:size_tify-libssl","ref":"size_tify-libssl","sha":"caa31742ce1c1029b2dc698616bf050b3f5ea31c","user":{"login":"mattcaswell","id":7422273,"avatar_url":"https://avatars.githubusercontent.com/u/7422273?v=3","gravatar_id":"","url":"https://api.github.com/users/mattcaswell","html_url":"https://github.com/mattcaswell","followers_url":"https://api.github.com/users/mattcaswell/followers","following_url":"https://api.github.com/users/mattcaswell/following{/other_user}","gists_url":"https://api.github.com/users/mattcaswell/gists{/gist_id}","starred_url":"https://api.github.com/users/mattcaswell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattcaswell/subscriptions","organizations_url":"https://api.github.com/users/mattcaswell/orgs","repos_url":"https://api.github.com/users/mattcaswell/repos","events_url":"https://api.github.com/users/mattcaswell/events{/privacy}","received_events_url":"https://api.github.com/users/mattcaswell/received_events","type":"User","site_admin":false},"repo":{"id":26978010,"name":"openssl","full_name":"mattcaswell/openssl","owner":{"login":"mattcaswell","id":7422273,"avatar_url":"https://avatars.githubusercontent.com/u/7422273?v=3","gravatar_id":"","url":"https://api.github.com/users/mattcaswell","html_url":"https://github.com/mattcaswell","followers_url":"https://api.github.com/users/mattcaswell/followers","following_url":"https://api.github.com/users/mattcaswell/following{/other_user}","gists_url":"https://api.github.com/users/mattcaswell/gists{/gist_id}","starred_url":"https://api.github.com/users/mattcaswell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattcaswell/subscriptions","organizations_url":"https://api.github.com/users/mattcaswell/orgs","repos_url":"https://api.github.com/users/mattcaswell/repos","events_url":"https://api.github.com/users/mattcaswell/events{/privacy}","received_events_url":"https://api.github.com/users/mattcaswell/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mattcaswell/openssl","description":null,"fork":true,"url":"https://api.github.com/repos/mattcaswell/openssl","forks_url":"https://api.github.com/repos/mattcaswell/openssl/forks","keys_url":"https://api.github.com/repos/mattcaswell/openssl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mattcaswell/openssl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mattcaswell/openssl/teams","hooks_url":"https://api.github.com/repos/mattcaswell/openssl/hooks","issue_events_url":"https://api.github.com/repos/mattcaswell/openssl/issues/events{/number}","events_url":"https://api.github.com/repos/mattcaswell/openssl/events","assignees_url":"https://api.github.com/repos/mattcaswell/openssl/assignees{/user}","branches_url":"https://api.github.com/repos/mattcaswell/openssl/branches{/branch}","tags_url":"https://api.github.com/repos/mattcaswell/openssl/tags","blobs_url":"https://api.github.com/repos/mattcaswell/openssl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mattcaswell/openssl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mattcaswell/openssl/git/refs{/sha}","trees_url":"https://api.github.com/repos/mattcaswell/openssl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mattcaswell/openssl/statuses/{sha}","languages_url":"https://api.github.com/repos/mattcaswell/openssl/languages","stargazers_url":"https://api.github.com/repos/mattcaswell/openssl/stargazers","contributors_url":"https://api.github.com/repos/mattcaswell/openssl/contributors","subscribers_url":"https://api.github.com/repos/mattcaswell/openssl/subscribers","subscription_url":"https://api.github.com/repos/mattcaswell/openssl/subscription","commits_url":"https://api.github.com/repos/mattcaswell/openssl/commits{/sha}","git_commits_url":"https://api.github.com/repos/mattcaswell/openssl/git/commits{/sha}","comments_url":"https://api.github.com/repos/mattcaswell/openssl/comments{/number}","issue_comment_url":"https://api.github.com/repos/mattcaswell/openssl/issues/comments{/number}","contents_url":"https://api.github.com/repos/mattcaswell/openssl/contents/{+path}","compare_url":"https://api.github.com/repos/mattcaswell/openssl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mattcaswell/openssl/merges","archive_url":"https://api.github.com/repos/mattcaswell/openssl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mattcaswell/openssl/downloads","issues_url":"https://api.github.com/repos/mattcaswell/openssl/issues{/number}","pulls_url":"https://api.github.com/repos/mattcaswell/openssl/pulls{/number}","milestones_url":"https://api.github.com/repos/mattcaswell/openssl/milestones{/number}","notifications_url":"https://api.github.com/repos/mattcaswell/openssl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mattcaswell/openssl/labels{/name}","releases_url":"https://api.github.com/repos/mattcaswell/openssl/releases{/id}","deployments_url":"https://api.github.com/repos/mattcaswell/openssl/deployments","created_at":"2014-11-21T21:09:59Z","updated_at":"2016-08-01T05:48:34Z","pushed_at":"2016-10-21T14:29:41Z","git_url":"git://github.com/mattcaswell/openssl.git","ssh_url":"git@github.com:mattcaswell/openssl.git","clone_url":"https://github.com/mattcaswell/openssl.git","svn_url":"https://github.com/mattcaswell/openssl","homepage":null,"size":112721,"stargazers_count":4,"watchers_count":4,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":4,"default_branch":"master"}},"base":{"label":"openssl:master","ref":"master","sha":"b85bf6395251dc28457b95de586a2f0a5faae4af","user":{"login":"openssl","id":3279138,"avatar_url":"https://avatars.githubusercontent.com/u/3279138?v=3","gravatar_id":"","url":"https://api.github.com/users/openssl","html_url":"https://github.com/openssl","followers_url":"https://api.github.com/users/openssl/followers","following_url":"https://api.github.com/users/openssl/following{/other_user}","gists_url":"https://api.github.com/users/openssl/gists{/gist_id}","starred_url":"https://api.github.com/users/openssl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openssl/subscriptions","organizations_url":"https://api.github.com/users/openssl/orgs","repos_url":"https://api.github.com/users/openssl/repos","events_url":"https://api.github.com/users/openssl/events{/privacy}","received_events_url":"https://api.github.com/users/openssl/received_events","type":"Organization","site_admin":false},"repo":{"id":7634677,"name":"openssl","full_name":"openssl/openssl","owner":{"login":"openssl","id":3279138,"avatar_url":"https://avatars.githubusercontent.com/u/3279138?v=3","gravatar_id":"","url":"https://api.github.com/users/openssl","html_url":"https://github.com/openssl","followers_url":"https://api.github.com/users/openssl/followers","following_url":"https://api.github.com/users/openssl/following{/other_user}","gists_url":"https://api.github.com/users/openssl/gists{/gist_id}","starred_url":"https://api.github.com/users/openssl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openssl/subscriptions","organizations_url":"https://api.github.com/users/openssl/orgs","repos_url":"https://api.github.com/users/openssl/repos","events_url":"https://api.github.com/users/openssl/events{/privacy}","received_events_url":"https://api.github.com/users/openssl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openssl/openssl","description":"TLS/SSL and crypto library","fork":false,"url":"https://api.github.com/repos/openssl/openssl","forks_url":"https://api.github.com/repos/openssl/openssl/forks","keys_url":"https://api.github.com/repos/openssl/openssl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openssl/openssl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openssl/openssl/teams","hooks_url":"https://api.github.com/repos/openssl/openssl/hooks","issue_events_url":"https://api.github.com/repos/openssl/openssl/issues/events{/number}","events_url":"https://api.github.com/repos/openssl/openssl/events","assignees_url":"https://api.github.com/repos/openssl/openssl/assignees{/user}","branches_url":"https://api.github.com/repos/openssl/openssl/branches{/branch}","tags_url":"https://api.github.com/repos/openssl/openssl/tags","blobs_url":"https://api.github.com/repos/openssl/openssl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openssl/openssl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openssl/openssl/git/refs{/sha}","trees_url":"https://api.github.com/repos/openssl/openssl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openssl/openssl/statuses/{sha}","languages_url":"https://api.github.com/repos/openssl/openssl/languages","stargazers_url":"https://api.github.com/repos/openssl/openssl/stargazers","contributors_url":"https://api.github.com/repos/openssl/openssl/contributors","subscribers_url":"https://api.github.com/repos/openssl/openssl/subscribers","subscription_url":"https://api.github.com/repos/openssl/openssl/subscription","commits_url":"https://api.github.com/repos/openssl/openssl/commits{/sha}","git_commits_url":"https://api.github.com/repos/openssl/openssl/git/commits{/sha}","comments_url":"https://api.github.com/repos/openssl/openssl/comments{/number}","issue_comment_url":"https://api.github.com/repos/openssl/openssl/issues/comments{/number}","contents_url":"https://api.github.com/repos/openssl/openssl/contents/{+path}","compare_url":"https://api.github.com/repos/openssl/openssl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openssl/openssl/merges","archive_url":"https://api.github.com/repos/openssl/openssl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openssl/openssl/downloads","issues_url":"https://api.github.com/repos/openssl/openssl/issues{/number}","pulls_url":"https://api.github.com/repos/openssl/openssl/pulls{/number}","milestones_url":"https://api.github.com/repos/openssl/openssl/milestones{/number}","notifications_url":"https://api.github.com/repos/openssl/openssl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openssl/openssl/labels{/name}","releases_url":"https://api.github.com/repos/openssl/openssl/releases{/id}","deployments_url":"https://api.github.com/repos/openssl/openssl/deployments","created_at":"2013-01-15T22:34:48Z","updated_at":"2016-10-21T14:13:00Z","pushed_at":"2016-10-21T14:29:42Z","git_url":"git://github.com/openssl/openssl.git","ssh_url":"git@github.com:openssl/openssl.git","clone_url":"https://github.com/openssl/openssl.git","svn_url":"https://github.com/openssl/openssl","homepage":"https://www.openssl.org","size":123310,"stargazers_count":3420,"watchers_count":3420,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1914,"mirror_url":null,"open_issues_count":202,"forks":1914,"open_issues":202,"watchers":3420,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openssl/openssl/pulls/1751"},"html":{"href":"https://github.com/openssl/openssl/pull/1751"},"issue":{"href":"https://api.github.com/repos/openssl/openssl/issues/1751"},"comments":{"href":"https://api.github.com/repos/openssl/openssl/issues/1751/comments"},"review_comments":{"href":"https://api.github.com/repos/openssl/openssl/pulls/1751/comments"},"review_comment":{"href":"https://api.github.com/repos/openssl/openssl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openssl/openssl/pulls/1751/commits"},"statuses":{"href":"https://api.github.com/repos/openssl/openssl/statuses/caa31742ce1c1029b2dc698616bf050b3f5ea31c"}}}}
{"actor":{"display_login":"richsalz"}}