{"action":"created","issue":{"url":"https://api.github.com/repos/Automattic/wp-calypso/issues/8697","repository_url":"https://api.github.com/repos/Automattic/wp-calypso","labels_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/8697/labels{/name}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/8697/comments","events_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/8697/events","html_url":"https://github.com/Automattic/wp-calypso/pull/8697","id":182652277,"number":8697,"title":"Settings/Framework: Remove HelloVote setting and notice","user":{"login":"nylen","id":227022,"avatar_url":"https://avatars.githubusercontent.com/u/227022?v=3","gravatar_id":"","url":"https://api.github.com/users/nylen","html_url":"https://github.com/nylen","followers_url":"https://api.github.com/users/nylen/followers","following_url":"https://api.github.com/users/nylen/following{/other_user}","gists_url":"https://api.github.com/users/nylen/gists{/gist_id}","starred_url":"https://api.github.com/users/nylen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nylen/subscriptions","organizations_url":"https://api.github.com/users/nylen/orgs","repos_url":"https://api.github.com/users/nylen/repos","events_url":"https://api.github.com/users/nylen/events{/privacy}","received_events_url":"https://api.github.com/users/nylen/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Automattic/wp-calypso/labels/Framework","name":"Framework","color":"006b75"},{"url":"https://api.github.com/repos/Automattic/wp-calypso/labels/Site%20Settings","name":"Site Settings","color":"006b75"},{"url":"https://api.github.com/repos/Automattic/wp-calypso/labels/[Status]%20Ready%20to%20Merge","name":"[Status] Ready to Merge","color":"d4fb79"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-10-12T22:42:38Z","updated_at":"2016-10-13T02:52:31Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/8697","html_url":"https://github.com/Automattic/wp-calypso/pull/8697","diff_url":"https://github.com/Automattic/wp-calypso/pull/8697.diff","patch_url":"https://github.com/Automattic/wp-calypso/pull/8697.patch"},"body":"Removes the HelloVote setting introduced in #8436 and notice introduced in #8423 (plus refinements in a few follow-up PRs).\r\n\r\n### Screenshot: Setting\r\n\r\n![image](https://cloud.githubusercontent.com/assets/227022/19062466/63dd2bea-89c8-11e6-9cbe-3ef566efe97c.png)\r\n\r\n### Screenshot: Notice\r\n\r\n![image](https://cloud.githubusercontent.com/assets/227022/19125497/467af2a6-8b05-11e6-8198-014e5685aa3a.png)\r\n\r\n### To test\r\n\r\nVisit `/settings/general/$site` for a non-Jetpack site.  Verify that the setting disappears and the other settings still work.\r\n\r\nVisit almost any site-specific page for a non-Jetpack site (editor, posts listing for example).  Verify that the HelloVote notice is not active and the main layout is not broken.  See #8423 for more detailed testing instructions for this feature.\r\n\r\n### Note\r\n\r\nThere's still one instance of HelloVote-related code: the [`helloVoteDismissed` user preference](https://github.com/Automattic/wp-calypso/blob/f6127fb/client/state/preferences/schema.js#L18) in the user preferences schema.  I left this here to avoid unnecessarily invalidating saved state."},"comment":{"url":"https://api.github.com/repos/Automattic/wp-calypso/issues/comments/253399937","html_url":"https://github.com/Automattic/wp-calypso/pull/8697#issuecomment-253399937","issue_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/8697","id":253399937,"user":{"login":"nylen","id":227022,"avatar_url":"https://avatars.githubusercontent.com/u/227022?v=3","gravatar_id":"","url":"https://api.github.com/users/nylen","html_url":"https://github.com/nylen","followers_url":"https://api.github.com/users/nylen/followers","following_url":"https://api.github.com/users/nylen/following{/other_user}","gists_url":"https://api.github.com/users/nylen/gists{/gist_id}","starred_url":"https://api.github.com/users/nylen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nylen/subscriptions","organizations_url":"https://api.github.com/users/nylen/orgs","repos_url":"https://api.github.com/users/nylen/repos","events_url":"https://api.github.com/users/nylen/events{/privacy}","received_events_url":"https://api.github.com/users/nylen/received_events","type":"User","site_admin":false},"created_at":"2016-10-13T02:52:31Z","updated_at":"2016-10-13T02:52:31Z","body":"Done, and good to know.  Thanks for taking a look!\r\n\r\nI still have `mediaItemsPerRow` in my preferences from early development of the media slider.  I agree it would be good to get rid of those."}}
{"actor":{"display_login":"nylen"}}