{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kops/pulls/comments/91691201","pull_request_review_id":12201463,"id":91691201,"diff_hunk":"@@ -10,13 +10,12 @@ we just expose it via DNS.\n \n The dns-controller recognizes annotations on nodes.\n \n-`dns.alpha.kubernetes.io/external` will set up records for accessing the resource externally\n-\n-`dns.alpha.kubernetes.io/internal` will set up records for accessing the resource internally\n+* `dns.alpha.kubernetes.io/external` will set up records for accessing the resource externally\n+* `dns.alpha.kubernetes.io/internal` will set up records for accessing the resource internally\n \n When added on `Service` controllers:\n \n-`dns.alpha.kubernetes.io/external` creates a Route53 A record with `public` IPs of all the nodes\n-`dns.alpha.kubernetes.io/internal` creates a Route53 A record with `private` IPs of all the nodes\n+* `dns.alpha.kubernetes.io/external` creates a Route53 A record with the IPs of the load balancer (type=LoadBalancer) or all the nodes (type=NodePort)\n+* `dns.alpha.kubernetes.io/internal` creates a Route53 A record with spec.clusterIP of the service","path":"dns-controller/README.md","position":15,"original_position":15,"commit_id":"6f690961c54174f39a9c72c5ad6699e13e4699aa","original_commit_id":"6f690961c54174f39a9c72c5ad6699e13e4699aa","user":{"login":"LEW21","id":9737,"avatar_url":"https://avatars.githubusercontent.com/u/9737?v=3","gravatar_id":"","url":"https://api.github.com/users/LEW21","html_url":"https://github.com/LEW21","followers_url":"https://api.github.com/users/LEW21/followers","following_url":"https://api.github.com/users/LEW21/following{/other_user}","gists_url":"https://api.github.com/users/LEW21/gists{/gist_id}","starred_url":"https://api.github.com/users/LEW21/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LEW21/subscriptions","organizations_url":"https://api.github.com/users/LEW21/orgs","repos_url":"https://api.github.com/users/LEW21/repos","events_url":"https://api.github.com/users/LEW21/events{/privacy}","received_events_url":"https://api.github.com/users/LEW21/received_events","type":"User","site_admin":false},"body":"We're experimenting with using Kubernetes's internal network as company's VPN. I'm currently pushing Kubernetes's DNS server as part of the VPN configuration, but standard domain names are not too friendly (gitlab.gitlab.svc.cluster.local for example), so I'm exploring alternatives for that.","created_at":"2016-12-09T10:23:00Z","updated_at":"2016-12-09T10:23:00Z","html_url":"https://github.com/kubernetes/kops/pull/1104#discussion_r91691201","pull_request_url":"https://api.github.com/repos/kubernetes/kops/pulls/1104","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kops/pulls/comments/91691201"},"html":{"href":"https://github.com/kubernetes/kops/pull/1104#discussion_r91691201"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kops/pulls/1104"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kops/pulls/1104","id":97166292,"html_url":"https://github.com/kubernetes/kops/pull/1104","diff_url":"https://github.com/kubernetes/kops/pull/1104.diff","patch_url":"https://github.com/kubernetes/kops/pull/1104.patch","issue_url":"https://api.github.com/repos/kubernetes/kops/issues/1104","number":1104,"state":"open","locked":false,"title":"Bind internal names for services to their ClusterIPs.","user":{"login":"LEW21","id":9737,"avatar_url":"https://avatars.githubusercontent.com/u/9737?v=3","gravatar_id":"","url":"https://api.github.com/users/LEW21","html_url":"https://github.com/LEW21","followers_url":"https://api.github.com/users/LEW21/followers","following_url":"https://api.github.com/users/LEW21/following{/other_user}","gists_url":"https://api.github.com/users/LEW21/gists{/gist_id}","starred_url":"https://api.github.com/users/LEW21/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LEW21/subscriptions","organizations_url":"https://api.github.com/users/LEW21/orgs","repos_url":"https://api.github.com/users/LEW21/repos","events_url":"https://api.github.com/users/LEW21/events{/privacy}","received_events_url":"https://api.github.com/users/LEW21/received_events","type":"User","site_admin":false},"body":"All types of services have clusterIPs, and that's the most performant way to access them internally, so they should be used for all internal records.\r\n\r\nSomewhat reverts https://github.com/kubernetes/kops/pull/922.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.kubernetes.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.kubernetes.io/reviews/kubernetes/kops/1104)\n<!-- Reviewable:end -->\n","created_at":"2016-12-08T17:31:25Z","updated_at":"2016-12-09T10:23:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0fcd72d321b7eb3553e29a84f2a39072d95e823a","assignee":{"login":"justinsb","id":100893,"avatar_url":"https://avatars.githubusercontent.com/u/100893?v=3","gravatar_id":"","url":"https://api.github.com/users/justinsb","html_url":"https://github.com/justinsb","followers_url":"https://api.github.com/users/justinsb/followers","following_url":"https://api.github.com/users/justinsb/following{/other_user}","gists_url":"https://api.github.com/users/justinsb/gists{/gist_id}","starred_url":"https://api.github.com/users/justinsb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinsb/subscriptions","organizations_url":"https://api.github.com/users/justinsb/orgs","repos_url":"https://api.github.com/users/justinsb/repos","events_url":"https://api.github.com/users/justinsb/events{/privacy}","received_events_url":"https://api.github.com/users/justinsb/received_events","type":"User","site_admin":false},"assignees":[{"login":"justinsb","id":100893,"avatar_url":"https://avatars.githubusercontent.com/u/100893?v=3","gravatar_id":"","url":"https://api.github.com/users/justinsb","html_url":"https://github.com/justinsb","followers_url":"https://api.github.com/users/justinsb/followers","following_url":"https://api.github.com/users/justinsb/following{/other_user}","gists_url":"https://api.github.com/users/justinsb/gists{/gist_id}","starred_url":"https://api.github.com/users/justinsb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinsb/subscriptions","organizations_url":"https://api.github.com/users/justinsb/orgs","repos_url":"https://api.github.com/users/justinsb/repos","events_url":"https://api.github.com/users/justinsb/events{/privacy}","received_events_url":"https://api.github.com/users/justinsb/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kops/pulls/1104/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kops/pulls/1104/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kops/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kops/issues/1104/comments","statuses_url":"https://api.github.com/repos/kubernetes/kops/statuses/6f690961c54174f39a9c72c5ad6699e13e4699aa","head":{"label":"LEW21:dns-service-clusterips","ref":"dns-service-clusterips","sha":"6f690961c54174f39a9c72c5ad6699e13e4699aa","user":{"login":"LEW21","id":9737,"avatar_url":"https://avatars.githubusercontent.com/u/9737?v=3","gravatar_id":"","url":"https://api.github.com/users/LEW21","html_url":"https://github.com/LEW21","followers_url":"https://api.github.com/users/LEW21/followers","following_url":"https://api.github.com/users/LEW21/following{/other_user}","gists_url":"https://api.github.com/users/LEW21/gists{/gist_id}","starred_url":"https://api.github.com/users/LEW21/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LEW21/subscriptions","organizations_url":"https://api.github.com/users/LEW21/orgs","repos_url":"https://api.github.com/users/LEW21/repos","events_url":"https://api.github.com/users/LEW21/events{/privacy}","received_events_url":"https://api.github.com/users/LEW21/received_events","type":"User","site_admin":false},"repo":{"id":75958890,"name":"kops","full_name":"LEW21/kops","owner":{"login":"LEW21","id":9737,"avatar_url":"https://avatars.githubusercontent.com/u/9737?v=3","gravatar_id":"","url":"https://api.github.com/users/LEW21","html_url":"https://github.com/LEW21","followers_url":"https://api.github.com/users/LEW21/followers","following_url":"https://api.github.com/users/LEW21/following{/other_user}","gists_url":"https://api.github.com/users/LEW21/gists{/gist_id}","starred_url":"https://api.github.com/users/LEW21/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LEW21/subscriptions","organizations_url":"https://api.github.com/users/LEW21/orgs","repos_url":"https://api.github.com/users/LEW21/repos","events_url":"https://api.github.com/users/LEW21/events{/privacy}","received_events_url":"https://api.github.com/users/LEW21/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/LEW21/kops","description":"Kubernetes Operations (kops) - Production Grade K8s Installation, Upgrades, and Management","fork":true,"url":"https://api.github.com/repos/LEW21/kops","forks_url":"https://api.github.com/repos/LEW21/kops/forks","keys_url":"https://api.github.com/repos/LEW21/kops/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LEW21/kops/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LEW21/kops/teams","hooks_url":"https://api.github.com/repos/LEW21/kops/hooks","issue_events_url":"https://api.github.com/repos/LEW21/kops/issues/events{/number}","events_url":"https://api.github.com/repos/LEW21/kops/events","assignees_url":"https://api.github.com/repos/LEW21/kops/assignees{/user}","branches_url":"https://api.github.com/repos/LEW21/kops/branches{/branch}","tags_url":"https://api.github.com/repos/LEW21/kops/tags","blobs_url":"https://api.github.com/repos/LEW21/kops/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LEW21/kops/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LEW21/kops/git/refs{/sha}","trees_url":"https://api.github.com/repos/LEW21/kops/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LEW21/kops/statuses/{sha}","languages_url":"https://api.github.com/repos/LEW21/kops/languages","stargazers_url":"https://api.github.com/repos/LEW21/kops/stargazers","contributors_url":"https://api.github.com/repos/LEW21/kops/contributors","subscribers_url":"https://api.github.com/repos/LEW21/kops/subscribers","subscription_url":"https://api.github.com/repos/LEW21/kops/subscription","commits_url":"https://api.github.com/repos/LEW21/kops/commits{/sha}","git_commits_url":"https://api.github.com/repos/LEW21/kops/git/commits{/sha}","comments_url":"https://api.github.com/repos/LEW21/kops/comments{/number}","issue_comment_url":"https://api.github.com/repos/LEW21/kops/issues/comments{/number}","contents_url":"https://api.github.com/repos/LEW21/kops/contents/{+path}","compare_url":"https://api.github.com/repos/LEW21/kops/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LEW21/kops/merges","archive_url":"https://api.github.com/repos/LEW21/kops/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LEW21/kops/downloads","issues_url":"https://api.github.com/repos/LEW21/kops/issues{/number}","pulls_url":"https://api.github.com/repos/LEW21/kops/pulls{/number}","milestones_url":"https://api.github.com/repos/LEW21/kops/milestones{/number}","notifications_url":"https://api.github.com/repos/LEW21/kops/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LEW21/kops/labels{/name}","releases_url":"https://api.github.com/repos/LEW21/kops/releases{/id}","deployments_url":"https://api.github.com/repos/LEW21/kops/deployments","created_at":"2016-12-08T17:14:51Z","updated_at":"2016-12-08T17:14:53Z","pushed_at":"2016-12-08T17:29:58Z","git_url":"git://github.com/LEW21/kops.git","ssh_url":"git@github.com:LEW21/kops.git","clone_url":"https://github.com/LEW21/kops.git","svn_url":"https://github.com/LEW21/kops","homepage":"","size":103851,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"23947ed44d26ccd1a83f193c8a270cf93b785bac","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":62091339,"name":"kops","full_name":"kubernetes/kops","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kops","description":"Kubernetes Operations (kops) - Production Grade K8s Installation, Upgrades, and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kops","forks_url":"https://api.github.com/repos/kubernetes/kops/forks","keys_url":"https://api.github.com/repos/kubernetes/kops/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kops/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kops/teams","hooks_url":"https://api.github.com/repos/kubernetes/kops/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kops/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kops/events","assignees_url":"https://api.github.com/repos/kubernetes/kops/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kops/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kops/tags","blobs_url":"https://api.github.com/repos/kubernetes/kops/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kops/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kops/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kops/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kops/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kops/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kops/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kops/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kops/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kops/subscription","commits_url":"https://api.github.com/repos/kubernetes/kops/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kops/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kops/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kops/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kops/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kops/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kops/merges","archive_url":"https://api.github.com/repos/kubernetes/kops/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kops/downloads","issues_url":"https://api.github.com/repos/kubernetes/kops/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kops/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kops/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kops/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kops/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kops/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kops/deployments","created_at":"2016-06-27T22:01:15Z","updated_at":"2016-12-09T08:32:54Z","pushed_at":"2016-12-09T03:26:26Z","git_url":"git://github.com/kubernetes/kops.git","ssh_url":"git@github.com:kubernetes/kops.git","clone_url":"https://github.com/kubernetes/kops.git","svn_url":"https://github.com/kubernetes/kops","homepage":"","size":104424,"stargazers_count":682,"watchers_count":682,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":125,"mirror_url":null,"open_issues_count":384,"forks":125,"open_issues":384,"watchers":682,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kops/pulls/1104"},"html":{"href":"https://github.com/kubernetes/kops/pull/1104"},"issue":{"href":"https://api.github.com/repos/kubernetes/kops/issues/1104"},"comments":{"href":"https://api.github.com/repos/kubernetes/kops/issues/1104/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kops/pulls/1104/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kops/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kops/pulls/1104/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kops/statuses/6f690961c54174f39a9c72c5ad6699e13e4699aa"}}}}
{"actor":{"display_login":"LEW21"}}