{"action":"created","comment":{"url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-cloudfoundry/pulls/comments/74960042","id":74960042,"diff_hunk":"@@ -116,6 +125,11 @@\n \tprivate long taskTimeout = 30L;\n \n \t/**\n+\t * Flag to indicate whether env variables are fed into SPRING_APPLICATION_JSON, or individually applied.","path":"src/main/java/org/springframework/cloud/deployer/spi/cloudfoundry/CloudFoundryDeployerProperties.java","position":27,"original_position":27,"commit_id":"122873607a1530f63506957d0aa766c43ee9c5ac","original_commit_id":"122873607a1530f63506957d0aa766c43ee9c5ac","user":{"login":"ericbottard","id":313494,"avatar_url":"https://avatars.githubusercontent.com/u/313494?v=3","gravatar_id":"","url":"https://api.github.com/users/ericbottard","html_url":"https://github.com/ericbottard","followers_url":"https://api.github.com/users/ericbottard/followers","following_url":"https://api.github.com/users/ericbottard/following{/other_user}","gists_url":"https://api.github.com/users/ericbottard/gists{/gist_id}","starred_url":"https://api.github.com/users/ericbottard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericbottard/subscriptions","organizations_url":"https://api.github.com/users/ericbottard/orgs","repos_url":"https://api.github.com/users/ericbottard/repos","events_url":"https://api.github.com/users/ericbottard/events{/privacy}","received_events_url":"https://api.github.com/users/ericbottard/received_events","type":"User","site_admin":false},"body":"Not a big fan of the term \"env variables\" here. Rather, deployer calls them \"application properties\" and *in turn*, they may end up as ENVIRONMENT VARIABLES, or SAJ, or something else theoretically ","created_at":"2016-08-16T15:37:00Z","updated_at":"2016-08-16T15:37:00Z","html_url":"https://github.com/spring-cloud/spring-cloud-deployer-cloudfoundry/pull/62#discussion_r74960042","pull_request_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-cloudfoundry/pulls/62","_links":{"self":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-cloudfoundry/pulls/comments/74960042"},"html":{"href":"https://github.com/spring-cloud/spring-cloud-deployer-cloudfoundry/pull/62#discussion_r74960042"},"pull_request":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-cloudfoundry/pulls/62"}}},"pull_request":{"url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-cloudfoundry/pulls/62","id":78529175,"html_url":"https://github.com/spring-cloud/spring-cloud-deployer-cloudfoundry/pull/62","diff_url":"https://github.com/spring-cloud/spring-cloud-deployer-cloudfoundry/pull/62.diff","patch_url":"https://github.com/spring-cloud/spring-cloud-deployer-cloudfoundry/pull/62.patch","issue_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-cloudfoundry/issues/62","number":62,"state":"open","locked":false,"title":"Allow overriding buildpack, and switching to direct env variables","user":{"login":"gregturn","id":311040,"avatar_url":"https://avatars.githubusercontent.com/u/311040?v=3","gravatar_id":"","url":"https://api.github.com/users/gregturn","html_url":"https://github.com/gregturn","followers_url":"https://api.github.com/users/gregturn/followers","following_url":"https://api.github.com/users/gregturn/following{/other_user}","gists_url":"https://api.github.com/users/gregturn/gists{/gist_id}","starred_url":"https://api.github.com/users/gregturn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregturn/subscriptions","organizations_url":"https://api.github.com/users/gregturn/orgs","repos_url":"https://api.github.com/users/gregturn/repos","events_url":"https://api.github.com/users/gregturn/events{/privacy}","received_events_url":"https://api.github.com/users/gregturn/received_events","type":"User","site_admin":false},"body":"* Override buildpack on a per-request basis with new deployment property\r\n* Provide option to use direct env variables instead of SPRING_APPLICATION_JSON for request env variables.\r\n\r\nResolves #36","created_at":"2016-07-22T19:38:03Z","updated_at":"2016-08-16T15:37:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5c9b91113f7a69d6afd445e3e63266b5d0a22592","assignee":{"login":"ericbottard","id":313494,"avatar_url":"https://avatars.githubusercontent.com/u/313494?v=3","gravatar_id":"","url":"https://api.github.com/users/ericbottard","html_url":"https://github.com/ericbottard","followers_url":"https://api.github.com/users/ericbottard/followers","following_url":"https://api.github.com/users/ericbottard/following{/other_user}","gists_url":"https://api.github.com/users/ericbottard/gists{/gist_id}","starred_url":"https://api.github.com/users/ericbottard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericbottard/subscriptions","organizations_url":"https://api.github.com/users/ericbottard/orgs","repos_url":"https://api.github.com/users/ericbottard/repos","events_url":"https://api.github.com/users/ericbottard/events{/privacy}","received_events_url":"https://api.github.com/users/ericbottard/received_events","type":"User","site_admin":false},"assignees":[{"login":"ericbottard","id":313494,"avatar_url":"https://avatars.githubusercontent.com/u/313494?v=3","gravatar_id":"","url":"https://api.github.com/users/ericbottard","html_url":"https://github.com/ericbottard","followers_url":"https://api.github.com/users/ericbottard/followers","following_url":"https://api.github.com/users/ericbottard/following{/other_user}","gists_url":"https://api.github.com/users/ericbottard/gists{/gist_id}","starred_url":"https://api.github.com/users/ericbottard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericbottard/subscriptions","organizations_url":"https://api.github.com/users/ericbottard/orgs","repos_url":"https://api.github.com/users/ericbottard/repos","events_url":"https://api.github.com/users/ericbottard/events{/privacy}","received_events_url":"https://api.github.com/users/ericbottard/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-cloudfoundry/pulls/62/commits","review_comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-cloudfoundry/pulls/62/comments","review_comment_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-cloudfoundry/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-cloudfoundry/issues/62/comments","statuses_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-cloudfoundry/statuses/122873607a1530f63506957d0aa766c43ee9c5ac","head":{"label":"gregturn:saj-and-buildpack-overrides","ref":"saj-and-buildpack-overrides","sha":"122873607a1530f63506957d0aa766c43ee9c5ac","user":{"login":"gregturn","id":311040,"avatar_url":"https://avatars.githubusercontent.com/u/311040?v=3","gravatar_id":"","url":"https://api.github.com/users/gregturn","html_url":"https://github.com/gregturn","followers_url":"https://api.github.com/users/gregturn/followers","following_url":"https://api.github.com/users/gregturn/following{/other_user}","gists_url":"https://api.github.com/users/gregturn/gists{/gist_id}","starred_url":"https://api.github.com/users/gregturn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregturn/subscriptions","organizations_url":"https://api.github.com/users/gregturn/orgs","repos_url":"https://api.github.com/users/gregturn/repos","events_url":"https://api.github.com/users/gregturn/events{/privacy}","received_events_url":"https://api.github.com/users/gregturn/received_events","type":"User","site_admin":false},"repo":{"id":56786261,"name":"spring-cloud-cloudfoundry-deployer","full_name":"gregturn/spring-cloud-cloudfoundry-deployer","owner":{"login":"gregturn","id":311040,"avatar_url":"https://avatars.githubusercontent.com/u/311040?v=3","gravatar_id":"","url":"https://api.github.com/users/gregturn","html_url":"https://github.com/gregturn","followers_url":"https://api.github.com/users/gregturn/followers","following_url":"https://api.github.com/users/gregturn/following{/other_user}","gists_url":"https://api.github.com/users/gregturn/gists{/gist_id}","starred_url":"https://api.github.com/users/gregturn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregturn/subscriptions","organizations_url":"https://api.github.com/users/gregturn/orgs","repos_url":"https://api.github.com/users/gregturn/repos","events_url":"https://api.github.com/users/gregturn/events{/privacy}","received_events_url":"https://api.github.com/users/gregturn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gregturn/spring-cloud-cloudfoundry-deployer","description":"","fork":true,"url":"https://api.github.com/repos/gregturn/spring-cloud-cloudfoundry-deployer","forks_url":"https://api.github.com/repos/gregturn/spring-cloud-cloudfoundry-deployer/forks","keys_url":"https://api.github.com/repos/gregturn/spring-cloud-cloudfoundry-deployer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gregturn/spring-cloud-cloudfoundry-deployer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gregturn/spring-cloud-cloudfoundry-deployer/teams","hooks_url":"https://api.github.com/repos/gregturn/spring-cloud-cloudfoundry-deployer/hooks","issue_events_url":"https://api.github.com/repos/gregturn/spring-cloud-cloudfoundry-deployer/issues/events{/number}","events_url":"https://api.github.com/repos/gregturn/spring-cloud-cloudfoundry-deployer/events","assignees_url":"https://api.github.com/repos/gregturn/spring-cloud-cloudfoundry-deployer/assignees{/user}","branches_url":"https://api.github.com/repos/gregturn/spring-cloud-cloudfoundry-deployer/branches{/branch}","tags_url":"https://api.github.com/repos/gregturn/spring-cloud-cloudfoundry-deployer/tags","blobs_url":"https://api.github.com/repos/gregturn/spring-cloud-cloudfoundry-deployer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gregturn/spring-cloud-cloudfoundry-deployer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gregturn/spring-cloud-cloudfoundry-deployer/git/refs{/sha}","trees_url":"https://api.github.com/repos/gregturn/spring-cloud-cloudfoundry-deployer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gregturn/spring-cloud-cloudfoundry-deployer/statuses/{sha}","languages_url":"https://api.github.com/repos/gregturn/spring-cloud-cloudfoundry-deployer/languages","stargazers_url":"https://api.github.com/repos/gregturn/spring-cloud-cloudfoundry-deployer/stargazers","contributors_url":"https://api.github.com/repos/gregturn/spring-cloud-cloudfoundry-deployer/contributors","subscribers_url":"https://api.github.com/repos/gregturn/spring-cloud-cloudfoundry-deployer/subscribers","subscription_url":"https://api.github.com/repos/gregturn/spring-cloud-cloudfoundry-deployer/subscription","commits_url":"https://api.github.com/repos/gregturn/spring-cloud-cloudfoundry-deployer/commits{/sha}","git_commits_url":"https://api.github.com/repos/gregturn/spring-cloud-cloudfoundry-deployer/git/commits{/sha}","comments_url":"https://api.github.com/repos/gregturn/spring-cloud-cloudfoundry-deployer/comments{/number}","issue_comment_url":"https://api.github.com/repos/gregturn/spring-cloud-cloudfoundry-deployer/issues/comments{/number}","contents_url":"https://api.github.com/repos/gregturn/spring-cloud-cloudfoundry-deployer/contents/{+path}","compare_url":"https://api.github.com/repos/gregturn/spring-cloud-cloudfoundry-deployer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gregturn/spring-cloud-cloudfoundry-deployer/merges","archive_url":"https://api.github.com/repos/gregturn/spring-cloud-cloudfoundry-deployer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gregturn/spring-cloud-cloudfoundry-deployer/downloads","issues_url":"https://api.github.com/repos/gregturn/spring-cloud-cloudfoundry-deployer/issues{/number}","pulls_url":"https://api.github.com/repos/gregturn/spring-cloud-cloudfoundry-deployer/pulls{/number}","milestones_url":"https://api.github.com/repos/gregturn/spring-cloud-cloudfoundry-deployer/milestones{/number}","notifications_url":"https://api.github.com/repos/gregturn/spring-cloud-cloudfoundry-deployer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gregturn/spring-cloud-cloudfoundry-deployer/labels{/name}","releases_url":"https://api.github.com/repos/gregturn/spring-cloud-cloudfoundry-deployer/releases{/id}","deployments_url":"https://api.github.com/repos/gregturn/spring-cloud-cloudfoundry-deployer/deployments","created_at":"2016-04-21T15:42:50Z","updated_at":"2016-04-21T15:42:51Z","pushed_at":"2016-08-16T15:15:01Z","git_url":"git://github.com/gregturn/spring-cloud-cloudfoundry-deployer.git","ssh_url":"git@github.com:gregturn/spring-cloud-cloudfoundry-deployer.git","clone_url":"https://github.com/gregturn/spring-cloud-cloudfoundry-deployer.git","svn_url":"https://github.com/gregturn/spring-cloud-cloudfoundry-deployer","homepage":null,"size":33492,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spring-cloud:master","ref":"master","sha":"4702a99bd63073d6d49e15161d0ccd17acdcddd4","user":{"login":"spring-cloud","id":7815877,"avatar_url":"https://avatars.githubusercontent.com/u/7815877?v=3","gravatar_id":"","url":"https://api.github.com/users/spring-cloud","html_url":"https://github.com/spring-cloud","followers_url":"https://api.github.com/users/spring-cloud/followers","following_url":"https://api.github.com/users/spring-cloud/following{/other_user}","gists_url":"https://api.github.com/users/spring-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-cloud/subscriptions","organizations_url":"https://api.github.com/users/spring-cloud/orgs","repos_url":"https://api.github.com/users/spring-cloud/repos","events_url":"https://api.github.com/users/spring-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/spring-cloud/received_events","type":"Organization","site_admin":false},"repo":{"id":52798744,"name":"spring-cloud-deployer-cloudfoundry","full_name":"spring-cloud/spring-cloud-deployer-cloudfoundry","owner":{"login":"spring-cloud","id":7815877,"avatar_url":"https://avatars.githubusercontent.com/u/7815877?v=3","gravatar_id":"","url":"https://api.github.com/users/spring-cloud","html_url":"https://github.com/spring-cloud","followers_url":"https://api.github.com/users/spring-cloud/followers","following_url":"https://api.github.com/users/spring-cloud/following{/other_user}","gists_url":"https://api.github.com/users/spring-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-cloud/subscriptions","organizations_url":"https://api.github.com/users/spring-cloud/orgs","repos_url":"https://api.github.com/users/spring-cloud/repos","events_url":"https://api.github.com/users/spring-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/spring-cloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spring-cloud/spring-cloud-deployer-cloudfoundry","description":"The Spring Cloud Deployer implementation for Cloud Foundry","fork":false,"url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-cloudfoundry","forks_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-cloudfoundry/forks","keys_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-cloudfoundry/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-cloudfoundry/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-cloudfoundry/teams","hooks_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-cloudfoundry/hooks","issue_events_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-cloudfoundry/issues/events{/number}","events_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-cloudfoundry/events","assignees_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-cloudfoundry/assignees{/user}","branches_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-cloudfoundry/branches{/branch}","tags_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-cloudfoundry/tags","blobs_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-cloudfoundry/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-cloudfoundry/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-cloudfoundry/git/refs{/sha}","trees_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-cloudfoundry/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-cloudfoundry/statuses/{sha}","languages_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-cloudfoundry/languages","stargazers_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-cloudfoundry/stargazers","contributors_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-cloudfoundry/contributors","subscribers_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-cloudfoundry/subscribers","subscription_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-cloudfoundry/subscription","commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-cloudfoundry/commits{/sha}","git_commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-cloudfoundry/git/commits{/sha}","comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-cloudfoundry/comments{/number}","issue_comment_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-cloudfoundry/issues/comments{/number}","contents_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-cloudfoundry/contents/{+path}","compare_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-cloudfoundry/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-cloudfoundry/merges","archive_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-cloudfoundry/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-cloudfoundry/downloads","issues_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-cloudfoundry/issues{/number}","pulls_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-cloudfoundry/pulls{/number}","milestones_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-cloudfoundry/milestones{/number}","notifications_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-cloudfoundry/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-cloudfoundry/labels{/name}","releases_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-cloudfoundry/releases{/id}","deployments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-cloudfoundry/deployments","created_at":"2016-02-29T14:46:17Z","updated_at":"2016-05-05T13:25:56Z","pushed_at":"2016-08-16T15:15:01Z","git_url":"git://github.com/spring-cloud/spring-cloud-deployer-cloudfoundry.git","ssh_url":"git@github.com:spring-cloud/spring-cloud-deployer-cloudfoundry.git","clone_url":"https://github.com/spring-cloud/spring-cloud-deployer-cloudfoundry.git","svn_url":"https://github.com/spring-cloud/spring-cloud-deployer-cloudfoundry","homepage":"","size":38175,"stargazers_count":4,"watchers_count":4,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":16,"forks":12,"open_issues":16,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-cloudfoundry/pulls/62"},"html":{"href":"https://github.com/spring-cloud/spring-cloud-deployer-cloudfoundry/pull/62"},"issue":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-cloudfoundry/issues/62"},"comments":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-cloudfoundry/issues/62/comments"},"review_comments":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-cloudfoundry/pulls/62/comments"},"review_comment":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-cloudfoundry/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-cloudfoundry/pulls/62/commits"},"statuses":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-cloudfoundry/statuses/122873607a1530f63506957d0aa766c43ee9c5ac"}}}}
{"actor":{"display_login":"ericbottard"}}