{"action":"created","issue":{"url":"https://api.github.com/repos/dcos/dcos-ui/issues/1316","repository_url":"https://api.github.com/repos/dcos/dcos-ui","labels_url":"https://api.github.com/repos/dcos/dcos-ui/issues/1316/labels{/name}","comments_url":"https://api.github.com/repos/dcos/dcos-ui/issues/1316/comments","events_url":"https://api.github.com/repos/dcos/dcos-ui/issues/1316/events","html_url":"https://github.com/dcos/dcos-ui/pull/1316","id":186644564,"number":1316,"title":"[Service create form 1 of 2] Introduce fields: input and textarea","user":{"login":"mlunoe","id":1097941,"avatar_url":"https://avatars.githubusercontent.com/u/1097941?v=3","gravatar_id":"","url":"https://api.github.com/users/mlunoe","html_url":"https://github.com/mlunoe","followers_url":"https://api.github.com/users/mlunoe/followers","following_url":"https://api.github.com/users/mlunoe/following{/other_user}","gists_url":"https://api.github.com/users/mlunoe/gists{/gist_id}","starred_url":"https://api.github.com/users/mlunoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlunoe/subscriptions","organizations_url":"https://api.github.com/users/mlunoe/orgs","repos_url":"https://api.github.com/users/mlunoe/repos","events_url":"https://api.github.com/users/mlunoe/events{/privacy}","received_events_url":"https://api.github.com/users/mlunoe/received_events","type":"User","site_admin":false},"labels":[{"id":360296450,"url":"https://api.github.com/repos/dcos/dcos-ui/labels/reviewer","name":"reviewer","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":{"login":"philipnrmn","id":2989362,"avatar_url":"https://avatars.githubusercontent.com/u/2989362?v=3","gravatar_id":"","url":"https://api.github.com/users/philipnrmn","html_url":"https://github.com/philipnrmn","followers_url":"https://api.github.com/users/philipnrmn/followers","following_url":"https://api.github.com/users/philipnrmn/following{/other_user}","gists_url":"https://api.github.com/users/philipnrmn/gists{/gist_id}","starred_url":"https://api.github.com/users/philipnrmn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philipnrmn/subscriptions","organizations_url":"https://api.github.com/users/philipnrmn/orgs","repos_url":"https://api.github.com/users/philipnrmn/repos","events_url":"https://api.github.com/users/philipnrmn/events{/privacy}","received_events_url":"https://api.github.com/users/philipnrmn/received_events","type":"User","site_admin":false},"assignees":[{"login":"MatApple","id":465022,"avatar_url":"https://avatars.githubusercontent.com/u/465022?v=3","gravatar_id":"","url":"https://api.github.com/users/MatApple","html_url":"https://github.com/MatApple","followers_url":"https://api.github.com/users/MatApple/followers","following_url":"https://api.github.com/users/MatApple/following{/other_user}","gists_url":"https://api.github.com/users/MatApple/gists{/gist_id}","starred_url":"https://api.github.com/users/MatApple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MatApple/subscriptions","organizations_url":"https://api.github.com/users/MatApple/orgs","repos_url":"https://api.github.com/users/MatApple/repos","events_url":"https://api.github.com/users/MatApple/events{/privacy}","received_events_url":"https://api.github.com/users/MatApple/received_events","type":"User","site_admin":false},{"login":"philipnrmn","id":2989362,"avatar_url":"https://avatars.githubusercontent.com/u/2989362?v=3","gravatar_id":"","url":"https://api.github.com/users/philipnrmn","html_url":"https://github.com/philipnrmn","followers_url":"https://api.github.com/users/philipnrmn/followers","following_url":"https://api.github.com/users/philipnrmn/following{/other_user}","gists_url":"https://api.github.com/users/philipnrmn/gists{/gist_id}","starred_url":"https://api.github.com/users/philipnrmn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philipnrmn/subscriptions","organizations_url":"https://api.github.com/users/philipnrmn/orgs","repos_url":"https://api.github.com/users/philipnrmn/repos","events_url":"https://api.github.com/users/philipnrmn/events{/privacy}","received_events_url":"https://api.github.com/users/philipnrmn/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2016-11-01T20:55:16Z","updated_at":"2016-11-03T16:41:04Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dcos/dcos-ui/pulls/1316","html_url":"https://github.com/dcos/dcos-ui/pull/1316","diff_url":"https://github.com/dcos/dcos-ui/pull/1316.diff","patch_url":"https://github.com/dcos/dcos-ui/pull/1316.patch"},"body":"This PR introduces two fields; FieldInput and FieldTextarea.\r\n\r\nThey are both fairly simple; they do not hold state and are only concerned with rendering"},"comment":{"url":"https://api.github.com/repos/dcos/dcos-ui/issues/comments/258199702","html_url":"https://github.com/dcos/dcos-ui/pull/1316#issuecomment-258199702","issue_url":"https://api.github.com/repos/dcos/dcos-ui/issues/1316","id":258199702,"user":{"login":"orlandohohmeier","id":647035,"avatar_url":"https://avatars.githubusercontent.com/u/647035?v=3","gravatar_id":"","url":"https://api.github.com/users/orlandohohmeier","html_url":"https://github.com/orlandohohmeier","followers_url":"https://api.github.com/users/orlandohohmeier/followers","following_url":"https://api.github.com/users/orlandohohmeier/following{/other_user}","gists_url":"https://api.github.com/users/orlandohohmeier/gists{/gist_id}","starred_url":"https://api.github.com/users/orlandohohmeier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orlandohohmeier/subscriptions","organizations_url":"https://api.github.com/users/orlandohohmeier/orgs","repos_url":"https://api.github.com/users/orlandohohmeier/repos","events_url":"https://api.github.com/users/orlandohohmeier/events{/privacy}","received_events_url":"https://api.github.com/users/orlandohohmeier/received_events","type":"User","site_admin":false},"created_at":"2016-11-03T16:41:04Z","updated_at":"2016-11-03T16:41:04Z","body":"I'm worrying that by modeling the form element by inheritance and providing a large chunk for configuration isn't really an improvement over the component that we have today. I'd love to see us composing those form elements from a wrapping `FormElement` and a set components like an error, help, and the actual form element (e.g. input) similar to the tab components. \r\n\r\n```\r\n<FormElement>\r\n   <FormElementLabel>Email</FormElementLabel>\r\n   <FormElementError>Oh shit something went wrong</FormElementError>\r\n   <FormElementHelp>Just enter your email..</FormElementHelp>\r\n   <input type=\"email\">\r\n</FormElement>\r\n```\r\n\r\nAnyway, I'm ok to merge the PR as it, to unblock you as the code looks good to me."}}
{"actor":{"display_login":"orlandohohmeier"}}