{"action":"created","comment":{"url":"https://api.github.com/repos/flutter/flutter/pulls/comments/86255501","pull_request_review_id":6922689,"id":86255501,"diff_hunk":"@@ -164,6 +164,16 @@ String runCheckedSync(List<String> cmd, {\n   );\n }\n \n+/// Run cmd and return stdout on success.\n+///\n+/// Throws the standard error output if cmd exits with a non-zero value.\n+String runSyncAndThrowStdErrOnError(List<String> cmd) {","path":"packages/flutter_tools/lib/src/base/process.dart","position":7,"original_position":7,"commit_id":"9288233f6196b86da52803272f40220bf03fd97e","original_commit_id":"9288233f6196b86da52803272f40220bf03fd97e","user":{"login":"Hixie","id":551196,"avatar_url":"https://avatars.githubusercontent.com/u/551196?v=3","gravatar_id":"","url":"https://api.github.com/users/Hixie","html_url":"https://github.com/Hixie","followers_url":"https://api.github.com/users/Hixie/followers","following_url":"https://api.github.com/users/Hixie/following{/other_user}","gists_url":"https://api.github.com/users/Hixie/gists{/gist_id}","starred_url":"https://api.github.com/users/Hixie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hixie/subscriptions","organizations_url":"https://api.github.com/users/Hixie/orgs","repos_url":"https://api.github.com/users/Hixie/repos","events_url":"https://api.github.com/users/Hixie/events{/privacy}","received_events_url":"https://api.github.com/users/Hixie/received_events","type":"User","site_admin":false},"body":"we really should avoid adding more ways to run subprocesses... I don't suppose I can get you to embrace a yak shave that involves cleaning up this file, can I? :-)","created_at":"2016-11-02T22:19:06Z","updated_at":"2016-11-02T22:19:06Z","html_url":"https://github.com/flutter/flutter/pull/6668#discussion_r86255501","pull_request_url":"https://api.github.com/repos/flutter/flutter/pulls/6668","_links":{"self":{"href":"https://api.github.com/repos/flutter/flutter/pulls/comments/86255501"},"html":{"href":"https://github.com/flutter/flutter/pull/6668#discussion_r86255501"},"pull_request":{"href":"https://api.github.com/repos/flutter/flutter/pulls/6668"}}},"pull_request":{"url":"https://api.github.com/repos/flutter/flutter/pulls/6668","id":92065766,"html_url":"https://github.com/flutter/flutter/pull/6668","diff_url":"https://github.com/flutter/flutter/pull/6668.diff","patch_url":"https://github.com/flutter/flutter/pull/6668.patch","issue_url":"https://api.github.com/repos/flutter/flutter/issues/6668","number":6668,"state":"open","locked":false,"title":"Only synchronize used Dart sources to DevFS.","user":{"login":"johnmccutchan","id":224266,"avatar_url":"https://avatars.githubusercontent.com/u/224266?v=3","gravatar_id":"","url":"https://api.github.com/users/johnmccutchan","html_url":"https://github.com/johnmccutchan","followers_url":"https://api.github.com/users/johnmccutchan/followers","following_url":"https://api.github.com/users/johnmccutchan/following{/other_user}","gists_url":"https://api.github.com/users/johnmccutchan/gists{/gist_id}","starred_url":"https://api.github.com/users/johnmccutchan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnmccutchan/subscriptions","organizations_url":"https://api.github.com/users/johnmccutchan/orgs","repos_url":"https://api.github.com/users/johnmccutchan/repos","events_url":"https://api.github.com/users/johnmccutchan/events{/privacy}","received_events_url":"https://api.github.com/users/johnmccutchan/received_events","type":"User","site_admin":false},"body":"- [x] Remove the second full-sync on startup.\r\n- [x] Always invoke the snapshotter to determine the minimal set of Dart sources used.\r\n- [x] Only synchronize the *used* Dart sources to DevFS.\r\n- [x] Detect syntax / file missing errors on the host and gate reloads / restarts.","created_at":"2016-11-02T22:12:35Z","updated_at":"2016-11-02T22:19:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"812cd9c6c8bab745ffbe9835580899cf0eff5ec7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/flutter/flutter/pulls/6668/commits","review_comments_url":"https://api.github.com/repos/flutter/flutter/pulls/6668/comments","review_comment_url":"https://api.github.com/repos/flutter/flutter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flutter/flutter/issues/6668/comments","statuses_url":"https://api.github.com/repos/flutter/flutter/statuses/9288233f6196b86da52803272f40220bf03fd97e","head":{"label":"johnmccutchan:only_sync_used_dart_sources","ref":"only_sync_used_dart_sources","sha":"9288233f6196b86da52803272f40220bf03fd97e","user":{"login":"johnmccutchan","id":224266,"avatar_url":"https://avatars.githubusercontent.com/u/224266?v=3","gravatar_id":"","url":"https://api.github.com/users/johnmccutchan","html_url":"https://github.com/johnmccutchan","followers_url":"https://api.github.com/users/johnmccutchan/followers","following_url":"https://api.github.com/users/johnmccutchan/following{/other_user}","gists_url":"https://api.github.com/users/johnmccutchan/gists{/gist_id}","starred_url":"https://api.github.com/users/johnmccutchan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnmccutchan/subscriptions","organizations_url":"https://api.github.com/users/johnmccutchan/orgs","repos_url":"https://api.github.com/users/johnmccutchan/repos","events_url":"https://api.github.com/users/johnmccutchan/events{/privacy}","received_events_url":"https://api.github.com/users/johnmccutchan/received_events","type":"User","site_admin":false},"repo":{"id":46145254,"name":"flutter","full_name":"johnmccutchan/flutter","owner":{"login":"johnmccutchan","id":224266,"avatar_url":"https://avatars.githubusercontent.com/u/224266?v=3","gravatar_id":"","url":"https://api.github.com/users/johnmccutchan","html_url":"https://github.com/johnmccutchan","followers_url":"https://api.github.com/users/johnmccutchan/followers","following_url":"https://api.github.com/users/johnmccutchan/following{/other_user}","gists_url":"https://api.github.com/users/johnmccutchan/gists{/gist_id}","starred_url":"https://api.github.com/users/johnmccutchan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnmccutchan/subscriptions","organizations_url":"https://api.github.com/users/johnmccutchan/orgs","repos_url":"https://api.github.com/users/johnmccutchan/repos","events_url":"https://api.github.com/users/johnmccutchan/events{/privacy}","received_events_url":"https://api.github.com/users/johnmccutchan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/johnmccutchan/flutter","description":"The Flutter framework","fork":true,"url":"https://api.github.com/repos/johnmccutchan/flutter","forks_url":"https://api.github.com/repos/johnmccutchan/flutter/forks","keys_url":"https://api.github.com/repos/johnmccutchan/flutter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/johnmccutchan/flutter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/johnmccutchan/flutter/teams","hooks_url":"https://api.github.com/repos/johnmccutchan/flutter/hooks","issue_events_url":"https://api.github.com/repos/johnmccutchan/flutter/issues/events{/number}","events_url":"https://api.github.com/repos/johnmccutchan/flutter/events","assignees_url":"https://api.github.com/repos/johnmccutchan/flutter/assignees{/user}","branches_url":"https://api.github.com/repos/johnmccutchan/flutter/branches{/branch}","tags_url":"https://api.github.com/repos/johnmccutchan/flutter/tags","blobs_url":"https://api.github.com/repos/johnmccutchan/flutter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/johnmccutchan/flutter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/johnmccutchan/flutter/git/refs{/sha}","trees_url":"https://api.github.com/repos/johnmccutchan/flutter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/johnmccutchan/flutter/statuses/{sha}","languages_url":"https://api.github.com/repos/johnmccutchan/flutter/languages","stargazers_url":"https://api.github.com/repos/johnmccutchan/flutter/stargazers","contributors_url":"https://api.github.com/repos/johnmccutchan/flutter/contributors","subscribers_url":"https://api.github.com/repos/johnmccutchan/flutter/subscribers","subscription_url":"https://api.github.com/repos/johnmccutchan/flutter/subscription","commits_url":"https://api.github.com/repos/johnmccutchan/flutter/commits{/sha}","git_commits_url":"https://api.github.com/repos/johnmccutchan/flutter/git/commits{/sha}","comments_url":"https://api.github.com/repos/johnmccutchan/flutter/comments{/number}","issue_comment_url":"https://api.github.com/repos/johnmccutchan/flutter/issues/comments{/number}","contents_url":"https://api.github.com/repos/johnmccutchan/flutter/contents/{+path}","compare_url":"https://api.github.com/repos/johnmccutchan/flutter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/johnmccutchan/flutter/merges","archive_url":"https://api.github.com/repos/johnmccutchan/flutter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/johnmccutchan/flutter/downloads","issues_url":"https://api.github.com/repos/johnmccutchan/flutter/issues{/number}","pulls_url":"https://api.github.com/repos/johnmccutchan/flutter/pulls{/number}","milestones_url":"https://api.github.com/repos/johnmccutchan/flutter/milestones{/number}","notifications_url":"https://api.github.com/repos/johnmccutchan/flutter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/johnmccutchan/flutter/labels{/name}","releases_url":"https://api.github.com/repos/johnmccutchan/flutter/releases{/id}","deployments_url":"https://api.github.com/repos/johnmccutchan/flutter/deployments","created_at":"2015-11-13T20:21:52Z","updated_at":"2016-10-11T18:59:39Z","pushed_at":"2016-11-02T22:12:22Z","git_url":"git://github.com/johnmccutchan/flutter.git","ssh_url":"git@github.com:johnmccutchan/flutter.git","clone_url":"https://github.com/johnmccutchan/flutter.git","svn_url":"https://github.com/johnmccutchan/flutter","homepage":"http://flutter.io","size":20268,"stargazers_count":0,"watchers_count":0,"language":"Dart","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"flutter:master","ref":"master","sha":"32c9b4cd8067f42bc60d148232fbff329c127f14","user":{"login":"flutter","id":14101776,"avatar_url":"https://avatars.githubusercontent.com/u/14101776?v=3","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"repo":{"id":31792824,"name":"flutter","full_name":"flutter/flutter","owner":{"login":"flutter","id":14101776,"avatar_url":"https://avatars.githubusercontent.com/u/14101776?v=3","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/flutter/flutter","description":"Framework for building high-performance, high-fidelity iOS and Android apps.","fork":false,"url":"https://api.github.com/repos/flutter/flutter","forks_url":"https://api.github.com/repos/flutter/flutter/forks","keys_url":"https://api.github.com/repos/flutter/flutter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flutter/flutter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flutter/flutter/teams","hooks_url":"https://api.github.com/repos/flutter/flutter/hooks","issue_events_url":"https://api.github.com/repos/flutter/flutter/issues/events{/number}","events_url":"https://api.github.com/repos/flutter/flutter/events","assignees_url":"https://api.github.com/repos/flutter/flutter/assignees{/user}","branches_url":"https://api.github.com/repos/flutter/flutter/branches{/branch}","tags_url":"https://api.github.com/repos/flutter/flutter/tags","blobs_url":"https://api.github.com/repos/flutter/flutter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flutter/flutter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flutter/flutter/git/refs{/sha}","trees_url":"https://api.github.com/repos/flutter/flutter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flutter/flutter/statuses/{sha}","languages_url":"https://api.github.com/repos/flutter/flutter/languages","stargazers_url":"https://api.github.com/repos/flutter/flutter/stargazers","contributors_url":"https://api.github.com/repos/flutter/flutter/contributors","subscribers_url":"https://api.github.com/repos/flutter/flutter/subscribers","subscription_url":"https://api.github.com/repos/flutter/flutter/subscription","commits_url":"https://api.github.com/repos/flutter/flutter/commits{/sha}","git_commits_url":"https://api.github.com/repos/flutter/flutter/git/commits{/sha}","comments_url":"https://api.github.com/repos/flutter/flutter/comments{/number}","issue_comment_url":"https://api.github.com/repos/flutter/flutter/issues/comments{/number}","contents_url":"https://api.github.com/repos/flutter/flutter/contents/{+path}","compare_url":"https://api.github.com/repos/flutter/flutter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flutter/flutter/merges","archive_url":"https://api.github.com/repos/flutter/flutter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flutter/flutter/downloads","issues_url":"https://api.github.com/repos/flutter/flutter/issues{/number}","pulls_url":"https://api.github.com/repos/flutter/flutter/pulls{/number}","milestones_url":"https://api.github.com/repos/flutter/flutter/milestones{/number}","notifications_url":"https://api.github.com/repos/flutter/flutter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flutter/flutter/labels{/name}","releases_url":"https://api.github.com/repos/flutter/flutter/releases{/id}","deployments_url":"https://api.github.com/repos/flutter/flutter/deployments","created_at":"2015-03-06T22:54:58Z","updated_at":"2016-11-02T22:14:10Z","pushed_at":"2016-11-02T22:12:35Z","git_url":"git://github.com/flutter/flutter.git","ssh_url":"git@github.com:flutter/flutter.git","clone_url":"https://github.com/flutter/flutter.git","svn_url":"https://github.com/flutter/flutter","homepage":"https://flutter.io","size":116787,"stargazers_count":3493,"watchers_count":3493,"language":"Dart","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":366,"mirror_url":null,"open_issues_count":1359,"forks":366,"open_issues":1359,"watchers":3493,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flutter/flutter/pulls/6668"},"html":{"href":"https://github.com/flutter/flutter/pull/6668"},"issue":{"href":"https://api.github.com/repos/flutter/flutter/issues/6668"},"comments":{"href":"https://api.github.com/repos/flutter/flutter/issues/6668/comments"},"review_comments":{"href":"https://api.github.com/repos/flutter/flutter/pulls/6668/comments"},"review_comment":{"href":"https://api.github.com/repos/flutter/flutter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flutter/flutter/pulls/6668/commits"},"statuses":{"href":"https://api.github.com/repos/flutter/flutter/statuses/9288233f6196b86da52803272f40220bf03fd97e"}}}}
{"actor":{"display_login":"Hixie"}}