{"action":"created","comment":{"url":"https://api.github.com/repos/CruGlobal/GTViewController/pulls/comments/61428118","id":61428118,"diff_hunk":"@@ -345,7 +347,12 @@ - (void)pageEventDetected:(NSNotification *)notification {\n         \n         // dismiss a follow up modal if it is present and displayed\n         if (self.followupViewController) {\n-            [self dismissViewControllerAnimated:YES completion:nil];\n+            self.bypassPresentingNavbar = YES;\n+            __weak typeof(self) weakSelf = self;\n+            \n+            [self dismissViewControllerAnimated:YES completion:^{","path":"GTViewController/Classes/Nav Classes/GTViewController.m","position":17,"original_position":17,"commit_id":"0a2ff44760f51d469f7a71c4469a1da61b49d5df","original_commit_id":"0a2ff44760f51d469f7a71c4469a1da61b49d5df","user":{"login":"michaelharro","id":318260,"avatar_url":"https://avatars.githubusercontent.com/u/318260?v=3","gravatar_id":"","url":"https://api.github.com/users/michaelharro","html_url":"https://github.com/michaelharro","followers_url":"https://api.github.com/users/michaelharro/followers","following_url":"https://api.github.com/users/michaelharro/following{/other_user}","gists_url":"https://api.github.com/users/michaelharro/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelharro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelharro/subscriptions","organizations_url":"https://api.github.com/users/michaelharro/orgs","repos_url":"https://api.github.com/users/michaelharro/repos","events_url":"https://api.github.com/users/michaelharro/events{/privacy}","received_events_url":"https://api.github.com/users/michaelharro/received_events","type":"User","site_admin":false},"body":"I would call this method on self.followupViewController instead of self. dismissViewControllerAnimated either will dismiss the view controller the current view controller presented or if there is no presented view controller it will ask the parent view controller to dismiss the current view controller. calling the method on self.followupViewController means there is no chance of you accidentally dismissing the current view controller if the state got messed up. https://developer.apple.com/library/ios/documentation/UIKit/Reference/UIViewController_Class/#//apple_ref/occ/instm/UIViewController/dismissViewControllerAnimated:completion:","created_at":"2016-04-28T13:40:32Z","updated_at":"2016-04-28T13:40:32Z","html_url":"https://github.com/CruGlobal/GTViewController/pull/11#discussion_r61428118","pull_request_url":"https://api.github.com/repos/CruGlobal/GTViewController/pulls/11","_links":{"self":{"href":"https://api.github.com/repos/CruGlobal/GTViewController/pulls/comments/61428118"},"html":{"href":"https://github.com/CruGlobal/GTViewController/pull/11#discussion_r61428118"},"pull_request":{"href":"https://api.github.com/repos/CruGlobal/GTViewController/pulls/11"}}},"pull_request":{"url":"https://api.github.com/repos/CruGlobal/GTViewController/pulls/11","id":68115141,"html_url":"https://github.com/CruGlobal/GTViewController/pull/11","diff_url":"https://github.com/CruGlobal/GTViewController/pull/11.diff","patch_url":"https://github.com/CruGlobal/GTViewController/pull/11.patch","issue_url":"https://api.github.com/repos/CruGlobal/GTViewController/issues/11","number":11,"state":"open","locked":false,"title":"Minor improvements from user feedback","user":{"login":"ryancarlson","id":3768029,"avatar_url":"https://avatars.githubusercontent.com/u/3768029?v=3","gravatar_id":"","url":"https://api.github.com/users/ryancarlson","html_url":"https://github.com/ryancarlson","followers_url":"https://api.github.com/users/ryancarlson/followers","following_url":"https://api.github.com/users/ryancarlson/following{/other_user}","gists_url":"https://api.github.com/users/ryancarlson/gists{/gist_id}","starred_url":"https://api.github.com/users/ryancarlson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryancarlson/subscriptions","organizations_url":"https://api.github.com/users/ryancarlson/orgs","repos_url":"https://api.github.com/users/ryancarlson/repos","events_url":"https://api.github.com/users/ryancarlson/events{/privacy}","received_events_url":"https://api.github.com/users/ryancarlson/received_events","type":"User","site_admin":false},"body":"For follow up modal views\r\n- Followup views will now adjust their height and y position to ensure that the keyboard doesn't hide the data input field that's being interacted with\r\n- The next button will hop from one input field to the next.  It will change to 'Done' when on the last field\r\n- The nav bar will not be shown when the follow up view modal dismisses\r\n\r\nFor the entire renderer:\r\n- a single tap anywhere on the screen (besides an element of any kind) will hide the navbar if it's shown\r\n- a double tap anywhere on the screen (besides an element of any kind will show the navbar.\r\n- this fixes an annoyance that exists in production where the navbar will hide and immediately reshow itself on a single tap\r\n- twenty taps exhibits some random behavior.  further investigation required..","created_at":"2016-04-27T20:00:58Z","updated_at":"2016-04-28T13:40:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"49bc26144c100b7a35b9e6442fa7a4cb1345f0b8","assignee":{"login":"michaelharro","id":318260,"avatar_url":"https://avatars.githubusercontent.com/u/318260?v=3","gravatar_id":"","url":"https://api.github.com/users/michaelharro","html_url":"https://github.com/michaelharro","followers_url":"https://api.github.com/users/michaelharro/followers","following_url":"https://api.github.com/users/michaelharro/following{/other_user}","gists_url":"https://api.github.com/users/michaelharro/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelharro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelharro/subscriptions","organizations_url":"https://api.github.com/users/michaelharro/orgs","repos_url":"https://api.github.com/users/michaelharro/repos","events_url":"https://api.github.com/users/michaelharro/events{/privacy}","received_events_url":"https://api.github.com/users/michaelharro/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/CruGlobal/GTViewController/pulls/11/commits","review_comments_url":"https://api.github.com/repos/CruGlobal/GTViewController/pulls/11/comments","review_comment_url":"https://api.github.com/repos/CruGlobal/GTViewController/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CruGlobal/GTViewController/issues/11/comments","statuses_url":"https://api.github.com/repos/CruGlobal/GTViewController/statuses/0a2ff44760f51d469f7a71c4469a1da61b49d5df","head":{"label":"CruGlobal:fix/menu-glitches","ref":"fix/menu-glitches","sha":"0a2ff44760f51d469f7a71c4469a1da61b49d5df","user":{"login":"CruGlobal","id":1785912,"avatar_url":"https://avatars.githubusercontent.com/u/1785912?v=3","gravatar_id":"","url":"https://api.github.com/users/CruGlobal","html_url":"https://github.com/CruGlobal","followers_url":"https://api.github.com/users/CruGlobal/followers","following_url":"https://api.github.com/users/CruGlobal/following{/other_user}","gists_url":"https://api.github.com/users/CruGlobal/gists{/gist_id}","starred_url":"https://api.github.com/users/CruGlobal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CruGlobal/subscriptions","organizations_url":"https://api.github.com/users/CruGlobal/orgs","repos_url":"https://api.github.com/users/CruGlobal/repos","events_url":"https://api.github.com/users/CruGlobal/events{/privacy}","received_events_url":"https://api.github.com/users/CruGlobal/received_events","type":"Organization","site_admin":false},"repo":{"id":19160271,"name":"GTViewController","full_name":"CruGlobal/GTViewController","owner":{"login":"CruGlobal","id":1785912,"avatar_url":"https://avatars.githubusercontent.com/u/1785912?v=3","gravatar_id":"","url":"https://api.github.com/users/CruGlobal","html_url":"https://github.com/CruGlobal","followers_url":"https://api.github.com/users/CruGlobal/followers","following_url":"https://api.github.com/users/CruGlobal/following{/other_user}","gists_url":"https://api.github.com/users/CruGlobal/gists{/gist_id}","starred_url":"https://api.github.com/users/CruGlobal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CruGlobal/subscriptions","organizations_url":"https://api.github.com/users/CruGlobal/orgs","repos_url":"https://api.github.com/users/CruGlobal/repos","events_url":"https://api.github.com/users/CruGlobal/events{/privacy}","received_events_url":"https://api.github.com/users/CruGlobal/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CruGlobal/GTViewController","description":"iOS pod to render God Tools packages","fork":false,"url":"https://api.github.com/repos/CruGlobal/GTViewController","forks_url":"https://api.github.com/repos/CruGlobal/GTViewController/forks","keys_url":"https://api.github.com/repos/CruGlobal/GTViewController/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CruGlobal/GTViewController/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CruGlobal/GTViewController/teams","hooks_url":"https://api.github.com/repos/CruGlobal/GTViewController/hooks","issue_events_url":"https://api.github.com/repos/CruGlobal/GTViewController/issues/events{/number}","events_url":"https://api.github.com/repos/CruGlobal/GTViewController/events","assignees_url":"https://api.github.com/repos/CruGlobal/GTViewController/assignees{/user}","branches_url":"https://api.github.com/repos/CruGlobal/GTViewController/branches{/branch}","tags_url":"https://api.github.com/repos/CruGlobal/GTViewController/tags","blobs_url":"https://api.github.com/repos/CruGlobal/GTViewController/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CruGlobal/GTViewController/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CruGlobal/GTViewController/git/refs{/sha}","trees_url":"https://api.github.com/repos/CruGlobal/GTViewController/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CruGlobal/GTViewController/statuses/{sha}","languages_url":"https://api.github.com/repos/CruGlobal/GTViewController/languages","stargazers_url":"https://api.github.com/repos/CruGlobal/GTViewController/stargazers","contributors_url":"https://api.github.com/repos/CruGlobal/GTViewController/contributors","subscribers_url":"https://api.github.com/repos/CruGlobal/GTViewController/subscribers","subscription_url":"https://api.github.com/repos/CruGlobal/GTViewController/subscription","commits_url":"https://api.github.com/repos/CruGlobal/GTViewController/commits{/sha}","git_commits_url":"https://api.github.com/repos/CruGlobal/GTViewController/git/commits{/sha}","comments_url":"https://api.github.com/repos/CruGlobal/GTViewController/comments{/number}","issue_comment_url":"https://api.github.com/repos/CruGlobal/GTViewController/issues/comments{/number}","contents_url":"https://api.github.com/repos/CruGlobal/GTViewController/contents/{+path}","compare_url":"https://api.github.com/repos/CruGlobal/GTViewController/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CruGlobal/GTViewController/merges","archive_url":"https://api.github.com/repos/CruGlobal/GTViewController/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CruGlobal/GTViewController/downloads","issues_url":"https://api.github.com/repos/CruGlobal/GTViewController/issues{/number}","pulls_url":"https://api.github.com/repos/CruGlobal/GTViewController/pulls{/number}","milestones_url":"https://api.github.com/repos/CruGlobal/GTViewController/milestones{/number}","notifications_url":"https://api.github.com/repos/CruGlobal/GTViewController/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CruGlobal/GTViewController/labels{/name}","releases_url":"https://api.github.com/repos/CruGlobal/GTViewController/releases{/id}","deployments_url":"https://api.github.com/repos/CruGlobal/GTViewController/deployments","created_at":"2014-04-25T20:46:45Z","updated_at":"2016-03-28T20:48:07Z","pushed_at":"2016-04-27T20:00:58Z","git_url":"git://github.com/CruGlobal/GTViewController.git","ssh_url":"git@github.com:CruGlobal/GTViewController.git","clone_url":"https://github.com/CruGlobal/GTViewController.git","svn_url":"https://github.com/CruGlobal/GTViewController","homepage":null,"size":2544,"stargazers_count":1,"watchers_count":1,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"CruGlobal:develop","ref":"develop","sha":"3c4fa90bac986d4615617174587f13a0fabd7b0a","user":{"login":"CruGlobal","id":1785912,"avatar_url":"https://avatars.githubusercontent.com/u/1785912?v=3","gravatar_id":"","url":"https://api.github.com/users/CruGlobal","html_url":"https://github.com/CruGlobal","followers_url":"https://api.github.com/users/CruGlobal/followers","following_url":"https://api.github.com/users/CruGlobal/following{/other_user}","gists_url":"https://api.github.com/users/CruGlobal/gists{/gist_id}","starred_url":"https://api.github.com/users/CruGlobal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CruGlobal/subscriptions","organizations_url":"https://api.github.com/users/CruGlobal/orgs","repos_url":"https://api.github.com/users/CruGlobal/repos","events_url":"https://api.github.com/users/CruGlobal/events{/privacy}","received_events_url":"https://api.github.com/users/CruGlobal/received_events","type":"Organization","site_admin":false},"repo":{"id":19160271,"name":"GTViewController","full_name":"CruGlobal/GTViewController","owner":{"login":"CruGlobal","id":1785912,"avatar_url":"https://avatars.githubusercontent.com/u/1785912?v=3","gravatar_id":"","url":"https://api.github.com/users/CruGlobal","html_url":"https://github.com/CruGlobal","followers_url":"https://api.github.com/users/CruGlobal/followers","following_url":"https://api.github.com/users/CruGlobal/following{/other_user}","gists_url":"https://api.github.com/users/CruGlobal/gists{/gist_id}","starred_url":"https://api.github.com/users/CruGlobal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CruGlobal/subscriptions","organizations_url":"https://api.github.com/users/CruGlobal/orgs","repos_url":"https://api.github.com/users/CruGlobal/repos","events_url":"https://api.github.com/users/CruGlobal/events{/privacy}","received_events_url":"https://api.github.com/users/CruGlobal/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CruGlobal/GTViewController","description":"iOS pod to render God Tools packages","fork":false,"url":"https://api.github.com/repos/CruGlobal/GTViewController","forks_url":"https://api.github.com/repos/CruGlobal/GTViewController/forks","keys_url":"https://api.github.com/repos/CruGlobal/GTViewController/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CruGlobal/GTViewController/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CruGlobal/GTViewController/teams","hooks_url":"https://api.github.com/repos/CruGlobal/GTViewController/hooks","issue_events_url":"https://api.github.com/repos/CruGlobal/GTViewController/issues/events{/number}","events_url":"https://api.github.com/repos/CruGlobal/GTViewController/events","assignees_url":"https://api.github.com/repos/CruGlobal/GTViewController/assignees{/user}","branches_url":"https://api.github.com/repos/CruGlobal/GTViewController/branches{/branch}","tags_url":"https://api.github.com/repos/CruGlobal/GTViewController/tags","blobs_url":"https://api.github.com/repos/CruGlobal/GTViewController/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CruGlobal/GTViewController/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CruGlobal/GTViewController/git/refs{/sha}","trees_url":"https://api.github.com/repos/CruGlobal/GTViewController/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CruGlobal/GTViewController/statuses/{sha}","languages_url":"https://api.github.com/repos/CruGlobal/GTViewController/languages","stargazers_url":"https://api.github.com/repos/CruGlobal/GTViewController/stargazers","contributors_url":"https://api.github.com/repos/CruGlobal/GTViewController/contributors","subscribers_url":"https://api.github.com/repos/CruGlobal/GTViewController/subscribers","subscription_url":"https://api.github.com/repos/CruGlobal/GTViewController/subscription","commits_url":"https://api.github.com/repos/CruGlobal/GTViewController/commits{/sha}","git_commits_url":"https://api.github.com/repos/CruGlobal/GTViewController/git/commits{/sha}","comments_url":"https://api.github.com/repos/CruGlobal/GTViewController/comments{/number}","issue_comment_url":"https://api.github.com/repos/CruGlobal/GTViewController/issues/comments{/number}","contents_url":"https://api.github.com/repos/CruGlobal/GTViewController/contents/{+path}","compare_url":"https://api.github.com/repos/CruGlobal/GTViewController/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CruGlobal/GTViewController/merges","archive_url":"https://api.github.com/repos/CruGlobal/GTViewController/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CruGlobal/GTViewController/downloads","issues_url":"https://api.github.com/repos/CruGlobal/GTViewController/issues{/number}","pulls_url":"https://api.github.com/repos/CruGlobal/GTViewController/pulls{/number}","milestones_url":"https://api.github.com/repos/CruGlobal/GTViewController/milestones{/number}","notifications_url":"https://api.github.com/repos/CruGlobal/GTViewController/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CruGlobal/GTViewController/labels{/name}","releases_url":"https://api.github.com/repos/CruGlobal/GTViewController/releases{/id}","deployments_url":"https://api.github.com/repos/CruGlobal/GTViewController/deployments","created_at":"2014-04-25T20:46:45Z","updated_at":"2016-03-28T20:48:07Z","pushed_at":"2016-04-27T20:00:58Z","git_url":"git://github.com/CruGlobal/GTViewController.git","ssh_url":"git@github.com:CruGlobal/GTViewController.git","clone_url":"https://github.com/CruGlobal/GTViewController.git","svn_url":"https://github.com/CruGlobal/GTViewController","homepage":null,"size":2544,"stargazers_count":1,"watchers_count":1,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CruGlobal/GTViewController/pulls/11"},"html":{"href":"https://github.com/CruGlobal/GTViewController/pull/11"},"issue":{"href":"https://api.github.com/repos/CruGlobal/GTViewController/issues/11"},"comments":{"href":"https://api.github.com/repos/CruGlobal/GTViewController/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/CruGlobal/GTViewController/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/CruGlobal/GTViewController/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CruGlobal/GTViewController/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/CruGlobal/GTViewController/statuses/0a2ff44760f51d469f7a71c4469a1da61b49d5df"}}}}