{"action":"created","issue":{"url":"https://api.github.com/repos/libuv/libuv/issues/1090","repository_url":"https://api.github.com/repos/libuv/libuv","labels_url":"https://api.github.com/repos/libuv/libuv/issues/1090/labels{/name}","comments_url":"https://api.github.com/repos/libuv/libuv/issues/1090/comments","events_url":"https://api.github.com/repos/libuv/libuv/issues/1090/events","html_url":"https://github.com/libuv/libuv/pull/1090","id":183036978,"number":1090,"title":" win: avoid undefined `DUMMYUNIONNAME` macro in winapi","user":{"login":"bradking","id":87268,"avatar_url":"https://avatars.githubusercontent.com/u/87268?v=3","gravatar_id":"","url":"https://api.github.com/users/bradking","html_url":"https://github.com/bradking","followers_url":"https://api.github.com/users/bradking/followers","following_url":"https://api.github.com/users/bradking/following{/other_user}","gists_url":"https://api.github.com/users/bradking/gists{/gist_id}","starred_url":"https://api.github.com/users/bradking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bradking/subscriptions","organizations_url":"https://api.github.com/users/bradking/orgs","repos_url":"https://api.github.com/users/bradking/repos","events_url":"https://api.github.com/users/bradking/events{/privacy}","received_events_url":"https://api.github.com/users/bradking/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2016-10-14T12:24:52Z","updated_at":"2016-10-18T21:56:52Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/libuv/libuv/pulls/1090","html_url":"https://github.com/libuv/libuv/pull/1090","diff_url":"https://github.com/libuv/libuv/pull/1090.diff","patch_url":"https://github.com/libuv/libuv/pull/1090.patch"},"body":"Remove use of the `DUMMYUNIONNAME` macro from our definitions of internal winapi anonymous unions....\r\n\r\nEDIT:\r\n\r\nOur definitions of some internal winapi anonymous unions reference the `DUMMYUNIONNAME` macro.  This macro was added to `winternl.h` in Windows SDK v7.0a in combination with a conditional definition of `DUMMYUNIONNAME` to either **empty** or `u` depending on compiler support.  We support some compilers, such as VS 2008, whose windows headers do not define the `DUMMYUNIONNAME` macro.  Avoid using the undefined macro by defining one ourselves.  Avoid conflicts with windows headers that do define it (before or after our winapi.h is included) by renaming ours to `UV_DUMMYUNIONNAME`.\r\n"},"comment":{"url":"https://api.github.com/repos/libuv/libuv/issues/comments/254651443","html_url":"https://github.com/libuv/libuv/pull/1090#issuecomment-254651443","issue_url":"https://api.github.com/repos/libuv/libuv/issues/1090","id":254651443,"user":{"login":"saghul","id":317464,"avatar_url":"https://avatars.githubusercontent.com/u/317464?v=3","gravatar_id":"","url":"https://api.github.com/users/saghul","html_url":"https://github.com/saghul","followers_url":"https://api.github.com/users/saghul/followers","following_url":"https://api.github.com/users/saghul/following{/other_user}","gists_url":"https://api.github.com/users/saghul/gists{/gist_id}","starred_url":"https://api.github.com/users/saghul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saghul/subscriptions","organizations_url":"https://api.github.com/users/saghul/orgs","repos_url":"https://api.github.com/users/saghul/repos","events_url":"https://api.github.com/users/saghul/events{/privacy}","received_events_url":"https://api.github.com/users/saghul/received_events","type":"User","site_admin":false},"created_at":"2016-10-18T21:56:52Z","updated_at":"2016-10-18T21:56:52Z","body":"Okidoki, let's get rid of it then."}}
{"actor":{"display_login":"saghul"}}