{"action":"created","comment":{"url":"https://api.github.com/repos/tlswg/tls13-spec/pulls/comments/62923822","id":62923822,"diff_hunk":"@@ -3450,60 +3409,74 @@ the sources from the table above.\n   - HkdfLabel.label is \"TLS 1.3, \" + Label\n   - HkdfLabel.hash_value is HashValue.\n \n-  1. xSS = HKDF-Extract(0, SS). Note that HKDF-Extract always\n-     produces a value the same length as the underlying hash\n-     function.\n-\n-  2. xES = HKDF-Extract(0, ES)\n-\n-  3. mSS = HKDF-Expand-Label(xSS, \"expanded static secret\",\n-                             handshake_hash, L)\n-\n-  4. mES = HKDF-Expand-Label(xES, \"expanded ephemeral secret\",\n-                             handshake_hash, L)\n-\n-  5. master_secret = HKDF-Extract(mSS, mES)\n-\n-\n-  6. traffic_secret_0 = HKDF-Expand-Label(master_secret,\n-                                          \"traffic secret\",\n-                                          handshake_hash, L)\n-\n-  Where handshake_hash includes all messages up through the\n-  server CertificateVerify message, but not including any\n-  0-RTT handshake messages (the server's Finished is not\n-  included because the master_secret is needed to compute\n-  the finished key). [[OPEN ISSUE: Should we be including\n-  0-RTT handshake messages here and below?.\n-  https://github.com/tlswg/tls13-spec/issues/351\n-  ]] At this point,\n-  SS, ES, xSS, xES, mSS, and mES SHOULD be securely deleted,\n-  along with any ephemeral (EC)DH secrets.\n-\n-  7. resumption_secret = HKDF-Expand-Label(master_secret,\n-                                           \"resumption master secret\"\n-                                           handshake_hash, L)\n-\n-  8. exporter_secret = HKDF-Expand-Label(master_secret,\n-                                         \"exporter master secret\",\n-                                         handshake_hash, L)\n-\n-\n-  Where handshake_hash contains the entire handshake up to\n-  and including the client's Finished, but not including\n-  any 0-RTT handshake messages or post-handshake messages.\n-  AT this point master_secret SHOULD be securely deleted.\n-~~~\n+  Add-Secret(Secret, InputSecret) =","path":"draft-ietf-tls-tls13.md","position":273,"original_position":273,"commit_id":"91249236c7342f5074f343e6c9e89f35c14ece53","original_commit_id":"91249236c7342f5074f343e6c9e89f35c14ece53","user":{"login":"davegarrett","id":8292199,"avatar_url":"https://avatars.githubusercontent.com/u/8292199?v=3","gravatar_id":"","url":"https://api.github.com/users/davegarrett","html_url":"https://github.com/davegarrett","followers_url":"https://api.github.com/users/davegarrett/followers","following_url":"https://api.github.com/users/davegarrett/following{/other_user}","gists_url":"https://api.github.com/users/davegarrett/gists{/gist_id}","starred_url":"https://api.github.com/users/davegarrett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davegarrett/subscriptions","organizations_url":"https://api.github.com/users/davegarrett/orgs","repos_url":"https://api.github.com/users/davegarrett/repos","events_url":"https://api.github.com/users/davegarrett/events{/privacy}","received_events_url":"https://api.github.com/users/davegarrett/received_events","type":"User","site_admin":false},"body":"I'd suggest something simpler without the word \"Secret\" on this line 3 times, e.g.\r\nCombine-Secret(old, new)","created_at":"2016-05-11T20:48:29Z","updated_at":"2016-05-11T20:48:29Z","html_url":"https://github.com/tlswg/tls13-spec/pull/453#discussion_r62923822","pull_request_url":"https://api.github.com/repos/tlswg/tls13-spec/pulls/453","_links":{"self":{"href":"https://api.github.com/repos/tlswg/tls13-spec/pulls/comments/62923822"},"html":{"href":"https://github.com/tlswg/tls13-spec/pull/453#discussion_r62923822"},"pull_request":{"href":"https://api.github.com/repos/tlswg/tls13-spec/pulls/453"}}},"pull_request":{"url":"https://api.github.com/repos/tlswg/tls13-spec/pulls/453","id":69655191,"html_url":"https://github.com/tlswg/tls13-spec/pull/453","diff_url":"https://github.com/tlswg/tls13-spec/pull/453.diff","patch_url":"https://github.com/tlswg/tls13-spec/pull/453.patch","issue_url":"https://api.github.com/repos/tlswg/tls13-spec/issues/453","number":453,"state":"open","locked":false,"title":"Wip new key schedule","user":{"login":"ekr","id":1111457,"avatar_url":"https://avatars.githubusercontent.com/u/1111457?v=3","gravatar_id":"","url":"https://api.github.com/users/ekr","html_url":"https://github.com/ekr","followers_url":"https://api.github.com/users/ekr/followers","following_url":"https://api.github.com/users/ekr/following{/other_user}","gists_url":"https://api.github.com/users/ekr/gists{/gist_id}","starred_url":"https://api.github.com/users/ekr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ekr/subscriptions","organizations_url":"https://api.github.com/users/ekr/orgs","repos_url":"https://api.github.com/users/ekr/repos","events_url":"https://api.github.com/users/ekr/events{/privacy}","received_events_url":"https://api.github.com/users/ekr/received_events","type":"User","site_admin":false},"body":"First cut at a new, more linear key schedule. WIP so possible I missed something serious.\r\n\r\n@martinthomson @bifurcation, comments, please? Does this seem more straightforward","created_at":"2016-05-11T11:22:51Z","updated_at":"2016-05-11T20:48:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"04a17b5459ede4b2d05d7653296cc427b11c4ed0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/tlswg/tls13-spec/pulls/453/commits","review_comments_url":"https://api.github.com/repos/tlswg/tls13-spec/pulls/453/comments","review_comment_url":"https://api.github.com/repos/tlswg/tls13-spec/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tlswg/tls13-spec/issues/453/comments","statuses_url":"https://api.github.com/repos/tlswg/tls13-spec/statuses/91249236c7342f5074f343e6c9e89f35c14ece53","head":{"label":"ekr:WIP_new_key_schedule","ref":"WIP_new_key_schedule","sha":"91249236c7342f5074f343e6c9e89f35c14ece53","user":{"login":"ekr","id":1111457,"avatar_url":"https://avatars.githubusercontent.com/u/1111457?v=3","gravatar_id":"","url":"https://api.github.com/users/ekr","html_url":"https://github.com/ekr","followers_url":"https://api.github.com/users/ekr/followers","following_url":"https://api.github.com/users/ekr/following{/other_user}","gists_url":"https://api.github.com/users/ekr/gists{/gist_id}","starred_url":"https://api.github.com/users/ekr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ekr/subscriptions","organizations_url":"https://api.github.com/users/ekr/orgs","repos_url":"https://api.github.com/users/ekr/repos","events_url":"https://api.github.com/users/ekr/events{/privacy}","received_events_url":"https://api.github.com/users/ekr/received_events","type":"User","site_admin":false},"repo":{"id":19185500,"name":"tls13-spec","full_name":"ekr/tls13-spec","owner":{"login":"ekr","id":1111457,"avatar_url":"https://avatars.githubusercontent.com/u/1111457?v=3","gravatar_id":"","url":"https://api.github.com/users/ekr","html_url":"https://github.com/ekr","followers_url":"https://api.github.com/users/ekr/followers","following_url":"https://api.github.com/users/ekr/following{/other_user}","gists_url":"https://api.github.com/users/ekr/gists{/gist_id}","starred_url":"https://api.github.com/users/ekr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ekr/subscriptions","organizations_url":"https://api.github.com/users/ekr/orgs","repos_url":"https://api.github.com/users/ekr/repos","events_url":"https://api.github.com/users/ekr/events{/privacy}","received_events_url":"https://api.github.com/users/ekr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ekr/tls13-spec","description":"TLS 1.3 Specification","fork":true,"url":"https://api.github.com/repos/ekr/tls13-spec","forks_url":"https://api.github.com/repos/ekr/tls13-spec/forks","keys_url":"https://api.github.com/repos/ekr/tls13-spec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ekr/tls13-spec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ekr/tls13-spec/teams","hooks_url":"https://api.github.com/repos/ekr/tls13-spec/hooks","issue_events_url":"https://api.github.com/repos/ekr/tls13-spec/issues/events{/number}","events_url":"https://api.github.com/repos/ekr/tls13-spec/events","assignees_url":"https://api.github.com/repos/ekr/tls13-spec/assignees{/user}","branches_url":"https://api.github.com/repos/ekr/tls13-spec/branches{/branch}","tags_url":"https://api.github.com/repos/ekr/tls13-spec/tags","blobs_url":"https://api.github.com/repos/ekr/tls13-spec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ekr/tls13-spec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ekr/tls13-spec/git/refs{/sha}","trees_url":"https://api.github.com/repos/ekr/tls13-spec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ekr/tls13-spec/statuses/{sha}","languages_url":"https://api.github.com/repos/ekr/tls13-spec/languages","stargazers_url":"https://api.github.com/repos/ekr/tls13-spec/stargazers","contributors_url":"https://api.github.com/repos/ekr/tls13-spec/contributors","subscribers_url":"https://api.github.com/repos/ekr/tls13-spec/subscribers","subscription_url":"https://api.github.com/repos/ekr/tls13-spec/subscription","commits_url":"https://api.github.com/repos/ekr/tls13-spec/commits{/sha}","git_commits_url":"https://api.github.com/repos/ekr/tls13-spec/git/commits{/sha}","comments_url":"https://api.github.com/repos/ekr/tls13-spec/comments{/number}","issue_comment_url":"https://api.github.com/repos/ekr/tls13-spec/issues/comments{/number}","contents_url":"https://api.github.com/repos/ekr/tls13-spec/contents/{+path}","compare_url":"https://api.github.com/repos/ekr/tls13-spec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ekr/tls13-spec/merges","archive_url":"https://api.github.com/repos/ekr/tls13-spec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ekr/tls13-spec/downloads","issues_url":"https://api.github.com/repos/ekr/tls13-spec/issues{/number}","pulls_url":"https://api.github.com/repos/ekr/tls13-spec/pulls{/number}","milestones_url":"https://api.github.com/repos/ekr/tls13-spec/milestones{/number}","notifications_url":"https://api.github.com/repos/ekr/tls13-spec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ekr/tls13-spec/labels{/name}","releases_url":"https://api.github.com/repos/ekr/tls13-spec/releases{/id}","deployments_url":"https://api.github.com/repos/ekr/tls13-spec/deployments","created_at":"2014-04-26T18:47:51Z","updated_at":"2014-07-07T21:30:20Z","pushed_at":"2016-05-11T11:44:54Z","git_url":"git://github.com/ekr/tls13-spec.git","ssh_url":"git@github.com:ekr/tls13-spec.git","clone_url":"https://github.com/ekr/tls13-spec.git","svn_url":"https://github.com/ekr/tls13-spec","homepage":null,"size":2441,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":8,"forks":3,"open_issues":8,"watchers":0,"default_branch":"master"}},"base":{"label":"tlswg:master","ref":"master","sha":"4b92793b6a0ca687d6841359a6b8992fc7887c4d","user":{"login":"tlswg","id":6699659,"avatar_url":"https://avatars.githubusercontent.com/u/6699659?v=3","gravatar_id":"","url":"https://api.github.com/users/tlswg","html_url":"https://github.com/tlswg","followers_url":"https://api.github.com/users/tlswg/followers","following_url":"https://api.github.com/users/tlswg/following{/other_user}","gists_url":"https://api.github.com/users/tlswg/gists{/gist_id}","starred_url":"https://api.github.com/users/tlswg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tlswg/subscriptions","organizations_url":"https://api.github.com/users/tlswg/orgs","repos_url":"https://api.github.com/users/tlswg/repos","events_url":"https://api.github.com/users/tlswg/events{/privacy}","received_events_url":"https://api.github.com/users/tlswg/received_events","type":"Organization","site_admin":false},"repo":{"id":18887842,"name":"tls13-spec","full_name":"tlswg/tls13-spec","owner":{"login":"tlswg","id":6699659,"avatar_url":"https://avatars.githubusercontent.com/u/6699659?v=3","gravatar_id":"","url":"https://api.github.com/users/tlswg","html_url":"https://github.com/tlswg","followers_url":"https://api.github.com/users/tlswg/followers","following_url":"https://api.github.com/users/tlswg/following{/other_user}","gists_url":"https://api.github.com/users/tlswg/gists{/gist_id}","starred_url":"https://api.github.com/users/tlswg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tlswg/subscriptions","organizations_url":"https://api.github.com/users/tlswg/orgs","repos_url":"https://api.github.com/users/tlswg/repos","events_url":"https://api.github.com/users/tlswg/events{/privacy}","received_events_url":"https://api.github.com/users/tlswg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tlswg/tls13-spec","description":"TLS 1.3 Specification","fork":false,"url":"https://api.github.com/repos/tlswg/tls13-spec","forks_url":"https://api.github.com/repos/tlswg/tls13-spec/forks","keys_url":"https://api.github.com/repos/tlswg/tls13-spec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tlswg/tls13-spec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tlswg/tls13-spec/teams","hooks_url":"https://api.github.com/repos/tlswg/tls13-spec/hooks","issue_events_url":"https://api.github.com/repos/tlswg/tls13-spec/issues/events{/number}","events_url":"https://api.github.com/repos/tlswg/tls13-spec/events","assignees_url":"https://api.github.com/repos/tlswg/tls13-spec/assignees{/user}","branches_url":"https://api.github.com/repos/tlswg/tls13-spec/branches{/branch}","tags_url":"https://api.github.com/repos/tlswg/tls13-spec/tags","blobs_url":"https://api.github.com/repos/tlswg/tls13-spec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tlswg/tls13-spec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tlswg/tls13-spec/git/refs{/sha}","trees_url":"https://api.github.com/repos/tlswg/tls13-spec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tlswg/tls13-spec/statuses/{sha}","languages_url":"https://api.github.com/repos/tlswg/tls13-spec/languages","stargazers_url":"https://api.github.com/repos/tlswg/tls13-spec/stargazers","contributors_url":"https://api.github.com/repos/tlswg/tls13-spec/contributors","subscribers_url":"https://api.github.com/repos/tlswg/tls13-spec/subscribers","subscription_url":"https://api.github.com/repos/tlswg/tls13-spec/subscription","commits_url":"https://api.github.com/repos/tlswg/tls13-spec/commits{/sha}","git_commits_url":"https://api.github.com/repos/tlswg/tls13-spec/git/commits{/sha}","comments_url":"https://api.github.com/repos/tlswg/tls13-spec/comments{/number}","issue_comment_url":"https://api.github.com/repos/tlswg/tls13-spec/issues/comments{/number}","contents_url":"https://api.github.com/repos/tlswg/tls13-spec/contents/{+path}","compare_url":"https://api.github.com/repos/tlswg/tls13-spec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tlswg/tls13-spec/merges","archive_url":"https://api.github.com/repos/tlswg/tls13-spec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tlswg/tls13-spec/downloads","issues_url":"https://api.github.com/repos/tlswg/tls13-spec/issues{/number}","pulls_url":"https://api.github.com/repos/tlswg/tls13-spec/pulls{/number}","milestones_url":"https://api.github.com/repos/tlswg/tls13-spec/milestones{/number}","notifications_url":"https://api.github.com/repos/tlswg/tls13-spec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tlswg/tls13-spec/labels{/name}","releases_url":"https://api.github.com/repos/tlswg/tls13-spec/releases{/id}","deployments_url":"https://api.github.com/repos/tlswg/tls13-spec/deployments","created_at":"2014-04-17T17:52:32Z","updated_at":"2016-05-11T20:30:41Z","pushed_at":"2016-05-11T11:47:05Z","git_url":"git://github.com/tlswg/tls13-spec.git","ssh_url":"git@github.com:tlswg/tls13-spec.git","clone_url":"https://github.com/tlswg/tls13-spec.git","svn_url":"https://github.com/tlswg/tls13-spec","homepage":null,"size":2669,"stargazers_count":135,"watchers_count":135,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":58,"mirror_url":null,"open_issues_count":48,"forks":58,"open_issues":48,"watchers":135,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tlswg/tls13-spec/pulls/453"},"html":{"href":"https://github.com/tlswg/tls13-spec/pull/453"},"issue":{"href":"https://api.github.com/repos/tlswg/tls13-spec/issues/453"},"comments":{"href":"https://api.github.com/repos/tlswg/tls13-spec/issues/453/comments"},"review_comments":{"href":"https://api.github.com/repos/tlswg/tls13-spec/pulls/453/comments"},"review_comment":{"href":"https://api.github.com/repos/tlswg/tls13-spec/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tlswg/tls13-spec/pulls/453/commits"},"statuses":{"href":"https://api.github.com/repos/tlswg/tls13-spec/statuses/91249236c7342f5074f343e6c9e89f35c14ece53"}}}}