{"action":"closed","number":169,"pull_request":{"url":"https://api.github.com/repos/ealeksandrov/EAIntroView/pulls/169","id":71941708,"html_url":"https://github.com/ealeksandrov/EAIntroView/pull/169","diff_url":"https://github.com/ealeksandrov/EAIntroView/pull/169.diff","patch_url":"https://github.com/ealeksandrov/EAIntroView/pull/169.patch","issue_url":"https://api.github.com/repos/ealeksandrov/EAIntroView/issues/169","number":169,"state":"closed","locked":false,"title":"Remove global state from EAIntroView's constructor","user":{"login":"x1024","id":113459,"avatar_url":"https://avatars.githubusercontent.com/u/113459?v=3","gravatar_id":"","url":"https://api.github.com/users/x1024","html_url":"https://github.com/x1024","followers_url":"https://api.github.com/users/x1024/followers","following_url":"https://api.github.com/users/x1024/following{/other_user}","gists_url":"https://api.github.com/users/x1024/gists{/gist_id}","starred_url":"https://api.github.com/users/x1024/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/x1024/subscriptions","organizations_url":"https://api.github.com/users/x1024/orgs","repos_url":"https://api.github.com/users/x1024/repos","events_url":"https://api.github.com/users/x1024/events{/privacy}","received_events_url":"https://api.github.com/users/x1024/received_events","type":"User","site_admin":false},"body":"The code that modifies global state has been moved into the willMoveIntoSuperView: method.\r\nThis fixes a crash on iOS <= 8.\r\nIt also fixes an issue where the device would generate Device Orientation Notifications when it shouldn't.\r\n\r\nPreviously, if an EAIntroView was removed by removing its parent view (or ViewContrroller) - the cleanup code for the EAIntroView wasn't being called.\r\nThe same issue existed for an EAIntroView that was created, but not added to a view hierarchy.\r\n\r\nFixes #168","created_at":"2016-05-30T22:27:11Z","updated_at":"2016-05-31T09:02:54Z","closed_at":"2016-05-31T09:02:54Z","merged_at":"2016-05-31T09:02:54Z","merge_commit_sha":"0614ff15d65ef205e9088a787e7a4471b69d53be","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ealeksandrov/EAIntroView/pulls/169/commits","review_comments_url":"https://api.github.com/repos/ealeksandrov/EAIntroView/pulls/169/comments","review_comment_url":"https://api.github.com/repos/ealeksandrov/EAIntroView/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ealeksandrov/EAIntroView/issues/169/comments","statuses_url":"https://api.github.com/repos/ealeksandrov/EAIntroView/statuses/75a5eaf86abc8a263b48735b18174088ac03b838","head":{"label":"x1024:patch-1","ref":"patch-1","sha":"75a5eaf86abc8a263b48735b18174088ac03b838","user":{"login":"x1024","id":113459,"avatar_url":"https://avatars.githubusercontent.com/u/113459?v=3","gravatar_id":"","url":"https://api.github.com/users/x1024","html_url":"https://github.com/x1024","followers_url":"https://api.github.com/users/x1024/followers","following_url":"https://api.github.com/users/x1024/following{/other_user}","gists_url":"https://api.github.com/users/x1024/gists{/gist_id}","starred_url":"https://api.github.com/users/x1024/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/x1024/subscriptions","organizations_url":"https://api.github.com/users/x1024/orgs","repos_url":"https://api.github.com/users/x1024/repos","events_url":"https://api.github.com/users/x1024/events{/privacy}","received_events_url":"https://api.github.com/users/x1024/received_events","type":"User","site_admin":false},"repo":{"id":60041569,"name":"EAIntroView","full_name":"x1024/EAIntroView","owner":{"login":"x1024","id":113459,"avatar_url":"https://avatars.githubusercontent.com/u/113459?v=3","gravatar_id":"","url":"https://api.github.com/users/x1024","html_url":"https://github.com/x1024","followers_url":"https://api.github.com/users/x1024/followers","following_url":"https://api.github.com/users/x1024/following{/other_user}","gists_url":"https://api.github.com/users/x1024/gists{/gist_id}","starred_url":"https://api.github.com/users/x1024/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/x1024/subscriptions","organizations_url":"https://api.github.com/users/x1024/orgs","repos_url":"https://api.github.com/users/x1024/repos","events_url":"https://api.github.com/users/x1024/events{/privacy}","received_events_url":"https://api.github.com/users/x1024/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/x1024/EAIntroView","description":"Highly customizable drop-in solution for introduction views.","fork":true,"url":"https://api.github.com/repos/x1024/EAIntroView","forks_url":"https://api.github.com/repos/x1024/EAIntroView/forks","keys_url":"https://api.github.com/repos/x1024/EAIntroView/keys{/key_id}","collaborators_url":"https://api.github.com/repos/x1024/EAIntroView/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/x1024/EAIntroView/teams","hooks_url":"https://api.github.com/repos/x1024/EAIntroView/hooks","issue_events_url":"https://api.github.com/repos/x1024/EAIntroView/issues/events{/number}","events_url":"https://api.github.com/repos/x1024/EAIntroView/events","assignees_url":"https://api.github.com/repos/x1024/EAIntroView/assignees{/user}","branches_url":"https://api.github.com/repos/x1024/EAIntroView/branches{/branch}","tags_url":"https://api.github.com/repos/x1024/EAIntroView/tags","blobs_url":"https://api.github.com/repos/x1024/EAIntroView/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/x1024/EAIntroView/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/x1024/EAIntroView/git/refs{/sha}","trees_url":"https://api.github.com/repos/x1024/EAIntroView/git/trees{/sha}","statuses_url":"https://api.github.com/repos/x1024/EAIntroView/statuses/{sha}","languages_url":"https://api.github.com/repos/x1024/EAIntroView/languages","stargazers_url":"https://api.github.com/repos/x1024/EAIntroView/stargazers","contributors_url":"https://api.github.com/repos/x1024/EAIntroView/contributors","subscribers_url":"https://api.github.com/repos/x1024/EAIntroView/subscribers","subscription_url":"https://api.github.com/repos/x1024/EAIntroView/subscription","commits_url":"https://api.github.com/repos/x1024/EAIntroView/commits{/sha}","git_commits_url":"https://api.github.com/repos/x1024/EAIntroView/git/commits{/sha}","comments_url":"https://api.github.com/repos/x1024/EAIntroView/comments{/number}","issue_comment_url":"https://api.github.com/repos/x1024/EAIntroView/issues/comments{/number}","contents_url":"https://api.github.com/repos/x1024/EAIntroView/contents/{+path}","compare_url":"https://api.github.com/repos/x1024/EAIntroView/compare/{base}...{head}","merges_url":"https://api.github.com/repos/x1024/EAIntroView/merges","archive_url":"https://api.github.com/repos/x1024/EAIntroView/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/x1024/EAIntroView/downloads","issues_url":"https://api.github.com/repos/x1024/EAIntroView/issues{/number}","pulls_url":"https://api.github.com/repos/x1024/EAIntroView/pulls{/number}","milestones_url":"https://api.github.com/repos/x1024/EAIntroView/milestones{/number}","notifications_url":"https://api.github.com/repos/x1024/EAIntroView/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/x1024/EAIntroView/labels{/name}","releases_url":"https://api.github.com/repos/x1024/EAIntroView/releases{/id}","deployments_url":"https://api.github.com/repos/x1024/EAIntroView/deployments","created_at":"2016-05-30T22:06:56Z","updated_at":"2016-05-30T22:06:57Z","pushed_at":"2016-05-30T22:26:39Z","git_url":"git://github.com/x1024/EAIntroView.git","ssh_url":"git@github.com:x1024/EAIntroView.git","clone_url":"https://github.com/x1024/EAIntroView.git","svn_url":"https://github.com/x1024/EAIntroView","homepage":null,"size":3045,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ealeksandrov:master","ref":"master","sha":"b3c24268c20e3c9cc08bd3fa97139fa580125694","user":{"login":"ealeksandrov","id":3132438,"avatar_url":"https://avatars.githubusercontent.com/u/3132438?v=3","gravatar_id":"","url":"https://api.github.com/users/ealeksandrov","html_url":"https://github.com/ealeksandrov","followers_url":"https://api.github.com/users/ealeksandrov/followers","following_url":"https://api.github.com/users/ealeksandrov/following{/other_user}","gists_url":"https://api.github.com/users/ealeksandrov/gists{/gist_id}","starred_url":"https://api.github.com/users/ealeksandrov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ealeksandrov/subscriptions","organizations_url":"https://api.github.com/users/ealeksandrov/orgs","repos_url":"https://api.github.com/users/ealeksandrov/repos","events_url":"https://api.github.com/users/ealeksandrov/events{/privacy}","received_events_url":"https://api.github.com/users/ealeksandrov/received_events","type":"User","site_admin":false},"repo":{"id":12827225,"name":"EAIntroView","full_name":"ealeksandrov/EAIntroView","owner":{"login":"ealeksandrov","id":3132438,"avatar_url":"https://avatars.githubusercontent.com/u/3132438?v=3","gravatar_id":"","url":"https://api.github.com/users/ealeksandrov","html_url":"https://github.com/ealeksandrov","followers_url":"https://api.github.com/users/ealeksandrov/followers","following_url":"https://api.github.com/users/ealeksandrov/following{/other_user}","gists_url":"https://api.github.com/users/ealeksandrov/gists{/gist_id}","starred_url":"https://api.github.com/users/ealeksandrov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ealeksandrov/subscriptions","organizations_url":"https://api.github.com/users/ealeksandrov/orgs","repos_url":"https://api.github.com/users/ealeksandrov/repos","events_url":"https://api.github.com/users/ealeksandrov/events{/privacy}","received_events_url":"https://api.github.com/users/ealeksandrov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ealeksandrov/EAIntroView","description":"Highly customizable drop-in solution for introduction views.","fork":false,"url":"https://api.github.com/repos/ealeksandrov/EAIntroView","forks_url":"https://api.github.com/repos/ealeksandrov/EAIntroView/forks","keys_url":"https://api.github.com/repos/ealeksandrov/EAIntroView/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ealeksandrov/EAIntroView/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ealeksandrov/EAIntroView/teams","hooks_url":"https://api.github.com/repos/ealeksandrov/EAIntroView/hooks","issue_events_url":"https://api.github.com/repos/ealeksandrov/EAIntroView/issues/events{/number}","events_url":"https://api.github.com/repos/ealeksandrov/EAIntroView/events","assignees_url":"https://api.github.com/repos/ealeksandrov/EAIntroView/assignees{/user}","branches_url":"https://api.github.com/repos/ealeksandrov/EAIntroView/branches{/branch}","tags_url":"https://api.github.com/repos/ealeksandrov/EAIntroView/tags","blobs_url":"https://api.github.com/repos/ealeksandrov/EAIntroView/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ealeksandrov/EAIntroView/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ealeksandrov/EAIntroView/git/refs{/sha}","trees_url":"https://api.github.com/repos/ealeksandrov/EAIntroView/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ealeksandrov/EAIntroView/statuses/{sha}","languages_url":"https://api.github.com/repos/ealeksandrov/EAIntroView/languages","stargazers_url":"https://api.github.com/repos/ealeksandrov/EAIntroView/stargazers","contributors_url":"https://api.github.com/repos/ealeksandrov/EAIntroView/contributors","subscribers_url":"https://api.github.com/repos/ealeksandrov/EAIntroView/subscribers","subscription_url":"https://api.github.com/repos/ealeksandrov/EAIntroView/subscription","commits_url":"https://api.github.com/repos/ealeksandrov/EAIntroView/commits{/sha}","git_commits_url":"https://api.github.com/repos/ealeksandrov/EAIntroView/git/commits{/sha}","comments_url":"https://api.github.com/repos/ealeksandrov/EAIntroView/comments{/number}","issue_comment_url":"https://api.github.com/repos/ealeksandrov/EAIntroView/issues/comments{/number}","contents_url":"https://api.github.com/repos/ealeksandrov/EAIntroView/contents/{+path}","compare_url":"https://api.github.com/repos/ealeksandrov/EAIntroView/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ealeksandrov/EAIntroView/merges","archive_url":"https://api.github.com/repos/ealeksandrov/EAIntroView/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ealeksandrov/EAIntroView/downloads","issues_url":"https://api.github.com/repos/ealeksandrov/EAIntroView/issues{/number}","pulls_url":"https://api.github.com/repos/ealeksandrov/EAIntroView/pulls{/number}","milestones_url":"https://api.github.com/repos/ealeksandrov/EAIntroView/milestones{/number}","notifications_url":"https://api.github.com/repos/ealeksandrov/EAIntroView/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ealeksandrov/EAIntroView/labels{/name}","releases_url":"https://api.github.com/repos/ealeksandrov/EAIntroView/releases{/id}","deployments_url":"https://api.github.com/repos/ealeksandrov/EAIntroView/deployments","created_at":"2013-09-14T09:41:55Z","updated_at":"2016-05-31T05:54:50Z","pushed_at":"2016-05-31T09:02:54Z","git_url":"git://github.com/ealeksandrov/EAIntroView.git","ssh_url":"git@github.com:ealeksandrov/EAIntroView.git","clone_url":"https://github.com/ealeksandrov/EAIntroView.git","svn_url":"https://github.com/ealeksandrov/EAIntroView","homepage":null,"size":3193,"stargazers_count":2904,"watchers_count":2904,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":417,"mirror_url":null,"open_issues_count":20,"forks":417,"open_issues":20,"watchers":2904,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ealeksandrov/EAIntroView/pulls/169"},"html":{"href":"https://github.com/ealeksandrov/EAIntroView/pull/169"},"issue":{"href":"https://api.github.com/repos/ealeksandrov/EAIntroView/issues/169"},"comments":{"href":"https://api.github.com/repos/ealeksandrov/EAIntroView/issues/169/comments"},"review_comments":{"href":"https://api.github.com/repos/ealeksandrov/EAIntroView/pulls/169/comments"},"review_comment":{"href":"https://api.github.com/repos/ealeksandrov/EAIntroView/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ealeksandrov/EAIntroView/pulls/169/commits"},"statuses":{"href":"https://api.github.com/repos/ealeksandrov/EAIntroView/statuses/75a5eaf86abc8a263b48735b18174088ac03b838"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"ealeksandrov","id":3132438,"avatar_url":"https://avatars.githubusercontent.com/u/3132438?v=3","gravatar_id":"","url":"https://api.github.com/users/ealeksandrov","html_url":"https://github.com/ealeksandrov","followers_url":"https://api.github.com/users/ealeksandrov/followers","following_url":"https://api.github.com/users/ealeksandrov/following{/other_user}","gists_url":"https://api.github.com/users/ealeksandrov/gists{/gist_id}","starred_url":"https://api.github.com/users/ealeksandrov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ealeksandrov/subscriptions","organizations_url":"https://api.github.com/users/ealeksandrov/orgs","repos_url":"https://api.github.com/users/ealeksandrov/repos","events_url":"https://api.github.com/users/ealeksandrov/events{/privacy}","received_events_url":"https://api.github.com/users/ealeksandrov/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":16,"deletions":11,"changed_files":1}}
{"actor":{"display_login":"ealeksandrov"}}