{"action":"created","comment":{"url":"https://api.github.com/repos/theforeman/foreman/pulls/comments/59534715","id":59534715,"diff_hunk":"@@ -49,6 +50,7 @@ def create\n       param :id, :number, :desc => 'Subnet numeric identifier', :required => true\n       param :subnet, Hash, :required => true do\n         param :name, String, :desc => 'Subnet name'\n+        param :type, String, :desc => 'Type or protocol, Subnet::Ipv4 or Subnet::Ipv6'","path":"app/controllers/api/v1/subnets_controller.rb","position":12,"original_position":12,"commit_id":"6200d76b45fd066628870c7e684e4cd47c0473cb","original_commit_id":"6200d76b45fd066628870c7e684e4cd47c0473cb","user":{"login":"dLobatog","id":598891,"avatar_url":"https://avatars.githubusercontent.com/u/598891?v=3","gravatar_id":"","url":"https://api.github.com/users/dLobatog","html_url":"https://github.com/dLobatog","followers_url":"https://api.github.com/users/dLobatog/followers","following_url":"https://api.github.com/users/dLobatog/following{/other_user}","gists_url":"https://api.github.com/users/dLobatog/gists{/gist_id}","starred_url":"https://api.github.com/users/dLobatog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dLobatog/subscriptions","organizations_url":"https://api.github.com/users/dLobatog/orgs","repos_url":"https://api.github.com/users/dLobatog/repos","events_url":"https://api.github.com/users/dLobatog/events{/privacy}","received_events_url":"https://api.github.com/users/dLobatog/received_events","type":"User","site_admin":false},"body":"Ditto","created_at":"2016-04-13T11:53:52Z","updated_at":"2016-04-13T11:53:52Z","html_url":"https://github.com/theforeman/foreman/pull/3420#discussion_r59534715","pull_request_url":"https://api.github.com/repos/theforeman/foreman/pulls/3420","_links":{"self":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/comments/59534715"},"html":{"href":"https://github.com/theforeman/foreman/pull/3420#discussion_r59534715"},"pull_request":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/3420"}}},"pull_request":{"url":"https://api.github.com/repos/theforeman/foreman/pulls/3420","id":66169787,"html_url":"https://github.com/theforeman/foreman/pull/3420","diff_url":"https://github.com/theforeman/foreman/pull/3420.diff","patch_url":"https://github.com/theforeman/foreman/pull/3420.patch","issue_url":"https://api.github.com/repos/theforeman/foreman/issues/3420","number":3420,"state":"open","locked":false,"title":"fixes #2315 - add ipv6 support","user":{"login":"timogoebel","id":4107560,"avatar_url":"https://avatars.githubusercontent.com/u/4107560?v=3","gravatar_id":"","url":"https://api.github.com/users/timogoebel","html_url":"https://github.com/timogoebel","followers_url":"https://api.github.com/users/timogoebel/followers","following_url":"https://api.github.com/users/timogoebel/following{/other_user}","gists_url":"https://api.github.com/users/timogoebel/gists{/gist_id}","starred_url":"https://api.github.com/users/timogoebel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timogoebel/subscriptions","organizations_url":"https://api.github.com/users/timogoebel/orgs","repos_url":"https://api.github.com/users/timogoebel/repos","events_url":"https://api.github.com/users/timogoebel/events{/privacy}","received_events_url":"https://api.github.com/users/timogoebel/received_events","type":"User","site_admin":false},"body":"This PR adds basic IPv6 support to Foreman.\r\nA Host can have an IPv6 Subnet attached and the address is either set manually, generated via EUI64 (the same way it's done in SLAAC) or internal db. A AAAA-Record and PTR-Record is then set via Smart Proxy for that address.\r\n\r\nThis is based on @domcleal 's ipv6 branch: https://github.com/theforeman/foreman/compare/develop...domcleal:2315-ipv6\r\n\r\nI haven't tested dns orchestration with the smart proxy PR, yet.\r\n\r\nThinks, I consider pretty ugly and ask for help with are:\r\n* STI in General. I followed Dominic's branch to use STI to implement an IPv4 or IPv6 subnet. This made ```Subnet``` something like an abstract class. I have changed the casting in ```app/models/concerns/foreman/sti.rb``` to default to ```Subnet::Ipv4``` if not type is set. This is not looking and working great. I tried to implement it like ```app/models/hosts.rb``` with ```method_missing```. This felt like the dark path as well. Any suggestions?\r\n* Autocompletion for the Subnet STI on the Host-Model. scoped_search does not seem to support STI. I have tried to workaround this. You can see my efforts in the code. Are there any better suggestions?\r\n\r\nThis has already been a huge amount of work and I'd love to have all the feedback I can get to make this rock solid. Thanks in advance.","created_at":"2016-04-12T14:42:51Z","updated_at":"2016-04-13T11:53:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"72d85627fa18ae1b6fea7f96a98eb5e5de2b8b77","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/theforeman/foreman/pulls/3420/commits","review_comments_url":"https://api.github.com/repos/theforeman/foreman/pulls/3420/comments","review_comment_url":"https://api.github.com/repos/theforeman/foreman/pulls/comments{/number}","comments_url":"https://api.github.com/repos/theforeman/foreman/issues/3420/comments","statuses_url":"https://api.github.com/repos/theforeman/foreman/statuses/6200d76b45fd066628870c7e684e4cd47c0473cb","head":{"label":"timogoebel:2315-ipv6","ref":"2315-ipv6","sha":"6200d76b45fd066628870c7e684e4cd47c0473cb","user":{"login":"timogoebel","id":4107560,"avatar_url":"https://avatars.githubusercontent.com/u/4107560?v=3","gravatar_id":"","url":"https://api.github.com/users/timogoebel","html_url":"https://github.com/timogoebel","followers_url":"https://api.github.com/users/timogoebel/followers","following_url":"https://api.github.com/users/timogoebel/following{/other_user}","gists_url":"https://api.github.com/users/timogoebel/gists{/gist_id}","starred_url":"https://api.github.com/users/timogoebel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timogoebel/subscriptions","organizations_url":"https://api.github.com/users/timogoebel/orgs","repos_url":"https://api.github.com/users/timogoebel/repos","events_url":"https://api.github.com/users/timogoebel/events{/privacy}","received_events_url":"https://api.github.com/users/timogoebel/received_events","type":"User","site_admin":false},"repo":{"id":39135770,"name":"foreman","full_name":"timogoebel/foreman","owner":{"login":"timogoebel","id":4107560,"avatar_url":"https://avatars.githubusercontent.com/u/4107560?v=3","gravatar_id":"","url":"https://api.github.com/users/timogoebel","html_url":"https://github.com/timogoebel","followers_url":"https://api.github.com/users/timogoebel/followers","following_url":"https://api.github.com/users/timogoebel/following{/other_user}","gists_url":"https://api.github.com/users/timogoebel/gists{/gist_id}","starred_url":"https://api.github.com/users/timogoebel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timogoebel/subscriptions","organizations_url":"https://api.github.com/users/timogoebel/orgs","repos_url":"https://api.github.com/users/timogoebel/repos","events_url":"https://api.github.com/users/timogoebel/events{/privacy}","received_events_url":"https://api.github.com/users/timogoebel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/timogoebel/foreman","description":"an application that automates the lifecycle of servers ","fork":true,"url":"https://api.github.com/repos/timogoebel/foreman","forks_url":"https://api.github.com/repos/timogoebel/foreman/forks","keys_url":"https://api.github.com/repos/timogoebel/foreman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/timogoebel/foreman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/timogoebel/foreman/teams","hooks_url":"https://api.github.com/repos/timogoebel/foreman/hooks","issue_events_url":"https://api.github.com/repos/timogoebel/foreman/issues/events{/number}","events_url":"https://api.github.com/repos/timogoebel/foreman/events","assignees_url":"https://api.github.com/repos/timogoebel/foreman/assignees{/user}","branches_url":"https://api.github.com/repos/timogoebel/foreman/branches{/branch}","tags_url":"https://api.github.com/repos/timogoebel/foreman/tags","blobs_url":"https://api.github.com/repos/timogoebel/foreman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/timogoebel/foreman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/timogoebel/foreman/git/refs{/sha}","trees_url":"https://api.github.com/repos/timogoebel/foreman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/timogoebel/foreman/statuses/{sha}","languages_url":"https://api.github.com/repos/timogoebel/foreman/languages","stargazers_url":"https://api.github.com/repos/timogoebel/foreman/stargazers","contributors_url":"https://api.github.com/repos/timogoebel/foreman/contributors","subscribers_url":"https://api.github.com/repos/timogoebel/foreman/subscribers","subscription_url":"https://api.github.com/repos/timogoebel/foreman/subscription","commits_url":"https://api.github.com/repos/timogoebel/foreman/commits{/sha}","git_commits_url":"https://api.github.com/repos/timogoebel/foreman/git/commits{/sha}","comments_url":"https://api.github.com/repos/timogoebel/foreman/comments{/number}","issue_comment_url":"https://api.github.com/repos/timogoebel/foreman/issues/comments{/number}","contents_url":"https://api.github.com/repos/timogoebel/foreman/contents/{+path}","compare_url":"https://api.github.com/repos/timogoebel/foreman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/timogoebel/foreman/merges","archive_url":"https://api.github.com/repos/timogoebel/foreman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/timogoebel/foreman/downloads","issues_url":"https://api.github.com/repos/timogoebel/foreman/issues{/number}","pulls_url":"https://api.github.com/repos/timogoebel/foreman/pulls{/number}","milestones_url":"https://api.github.com/repos/timogoebel/foreman/milestones{/number}","notifications_url":"https://api.github.com/repos/timogoebel/foreman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/timogoebel/foreman/labels{/name}","releases_url":"https://api.github.com/repos/timogoebel/foreman/releases{/id}","deployments_url":"https://api.github.com/repos/timogoebel/foreman/deployments","created_at":"2015-07-15T12:33:09Z","updated_at":"2015-07-15T12:33:14Z","pushed_at":"2016-04-12T14:35:09Z","git_url":"git://github.com/timogoebel/foreman.git","ssh_url":"git@github.com:timogoebel/foreman.git","clone_url":"https://github.com/timogoebel/foreman.git","svn_url":"https://github.com/timogoebel/foreman","homepage":"http://theforeman.org","size":44618,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"theforeman:develop","ref":"develop","sha":"a322a96e9a948f3b3638fd8af8b84c4d70bcb4d7","user":{"login":"theforeman","id":1439844,"avatar_url":"https://avatars.githubusercontent.com/u/1439844?v=3","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"repo":{"id":258750,"name":"foreman","full_name":"theforeman/foreman","owner":{"login":"theforeman","id":1439844,"avatar_url":"https://avatars.githubusercontent.com/u/1439844?v=3","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/theforeman/foreman","description":"an application that automates the lifecycle of servers ","fork":false,"url":"https://api.github.com/repos/theforeman/foreman","forks_url":"https://api.github.com/repos/theforeman/foreman/forks","keys_url":"https://api.github.com/repos/theforeman/foreman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theforeman/foreman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theforeman/foreman/teams","hooks_url":"https://api.github.com/repos/theforeman/foreman/hooks","issue_events_url":"https://api.github.com/repos/theforeman/foreman/issues/events{/number}","events_url":"https://api.github.com/repos/theforeman/foreman/events","assignees_url":"https://api.github.com/repos/theforeman/foreman/assignees{/user}","branches_url":"https://api.github.com/repos/theforeman/foreman/branches{/branch}","tags_url":"https://api.github.com/repos/theforeman/foreman/tags","blobs_url":"https://api.github.com/repos/theforeman/foreman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theforeman/foreman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theforeman/foreman/git/refs{/sha}","trees_url":"https://api.github.com/repos/theforeman/foreman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theforeman/foreman/statuses/{sha}","languages_url":"https://api.github.com/repos/theforeman/foreman/languages","stargazers_url":"https://api.github.com/repos/theforeman/foreman/stargazers","contributors_url":"https://api.github.com/repos/theforeman/foreman/contributors","subscribers_url":"https://api.github.com/repos/theforeman/foreman/subscribers","subscription_url":"https://api.github.com/repos/theforeman/foreman/subscription","commits_url":"https://api.github.com/repos/theforeman/foreman/commits{/sha}","git_commits_url":"https://api.github.com/repos/theforeman/foreman/git/commits{/sha}","comments_url":"https://api.github.com/repos/theforeman/foreman/comments{/number}","issue_comment_url":"https://api.github.com/repos/theforeman/foreman/issues/comments{/number}","contents_url":"https://api.github.com/repos/theforeman/foreman/contents/{+path}","compare_url":"https://api.github.com/repos/theforeman/foreman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theforeman/foreman/merges","archive_url":"https://api.github.com/repos/theforeman/foreman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theforeman/foreman/downloads","issues_url":"https://api.github.com/repos/theforeman/foreman/issues{/number}","pulls_url":"https://api.github.com/repos/theforeman/foreman/pulls{/number}","milestones_url":"https://api.github.com/repos/theforeman/foreman/milestones{/number}","notifications_url":"https://api.github.com/repos/theforeman/foreman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theforeman/foreman/labels{/name}","releases_url":"https://api.github.com/repos/theforeman/foreman/releases{/id}","deployments_url":"https://api.github.com/repos/theforeman/foreman/deployments","created_at":"2009-07-23T15:07:00Z","updated_at":"2016-04-13T00:30:18Z","pushed_at":"2016-04-13T10:32:29Z","git_url":"git://github.com/theforeman/foreman.git","ssh_url":"git@github.com:theforeman/foreman.git","clone_url":"https://github.com/theforeman/foreman.git","svn_url":"https://github.com/theforeman/foreman","homepage":"http://theforeman.org","size":65107,"stargazers_count":984,"watchers_count":984,"language":"Ruby","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":503,"mirror_url":null,"open_issues_count":69,"forks":503,"open_issues":69,"watchers":984,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/3420"},"html":{"href":"https://github.com/theforeman/foreman/pull/3420"},"issue":{"href":"https://api.github.com/repos/theforeman/foreman/issues/3420"},"comments":{"href":"https://api.github.com/repos/theforeman/foreman/issues/3420/comments"},"review_comments":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/3420/comments"},"review_comment":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/3420/commits"},"statuses":{"href":"https://api.github.com/repos/theforeman/foreman/statuses/6200d76b45fd066628870c7e684e4cd47c0473cb"}}}}