{"action":"created","comment":{"url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments/59162788","id":59162788,"diff_hunk":"@@ -330,6 +341,25 @@ bool ControllerEngine::internalExecute(QScriptValue thisObject,\n                      scriptCode);\n \n         scriptErrorDialog(error);\n+        m_pEngine->clearExceptions();\n+        return false;\n+    }\n+    return true;\n+}\n+\n+/* -------- ------------------------------------------------------\n+Purpose: Evaluate & run script code\n+Input:   'this' object if applicable, Code string\n+Output:  false if an exception\n+-------- ------------------------------------------------------ */\n+bool ControllerEngine::internalExecute(QScriptValue thisObject,\n+                                       const QString& scriptCode) {\n+    // A special version of safeExecute since we're evaluating strings, not actual functions\n+    //  (execute() would print an error that it's not a function every time a timer fires.)\n+    if (m_pEngine == nullptr)\n+        return false;\n+\n+    if (!syntaxIsValid(scriptCode)) {","path":"src/controllers/controllerengine.cpp","position":126,"original_position":126,"commit_id":"9d3df5171374c08b5329c3bbbeedc47de375aee7","original_commit_id":"9d3df5171374c08b5329c3bbbeedc47de375aee7","user":{"login":"daschuer","id":1777442,"avatar_url":"https://avatars.githubusercontent.com/u/1777442?v=3","gravatar_id":"","url":"https://api.github.com/users/daschuer","html_url":"https://github.com/daschuer","followers_url":"https://api.github.com/users/daschuer/followers","following_url":"https://api.github.com/users/daschuer/following{/other_user}","gists_url":"https://api.github.com/users/daschuer/gists{/gist_id}","starred_url":"https://api.github.com/users/daschuer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daschuer/subscriptions","organizations_url":"https://api.github.com/users/daschuer/orgs","repos_url":"https://api.github.com/users/daschuer/repos","events_url":"https://api.github.com/users/daschuer/events{/privacy}","received_events_url":"https://api.github.com/users/daschuer/received_events","type":"User","site_admin":false},"body":"This call along with the wrapper generation should be done earlier, just after evaluating the QScriptValue as string places like: \r\nControllerEngine::beginTimer ","created_at":"2016-04-11T07:23:22Z","updated_at":"2016-04-11T07:23:22Z","html_url":"https://github.com/mixxxdj/mixxx/pull/919#discussion_r59162788","pull_request_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/919","_links":{"self":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments/59162788"},"html":{"href":"https://github.com/mixxxdj/mixxx/pull/919#discussion_r59162788"},"pull_request":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/919"}}},"pull_request":{"url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/919","id":65693854,"html_url":"https://github.com/mixxxdj/mixxx/pull/919","diff_url":"https://github.com/mixxxdj/mixxx/pull/919.diff","patch_url":"https://github.com/mixxxdj/mixxx/pull/919.patch","issue_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/919","number":919,"state":"open","locked":false,"title":"call MIDI input script functions with appropriate \"this\" object","user":{"login":"Be-ing","id":9455094,"avatar_url":"https://avatars.githubusercontent.com/u/9455094?v=3","gravatar_id":"","url":"https://api.github.com/users/Be-ing","html_url":"https://github.com/Be-ing","followers_url":"https://api.github.com/users/Be-ing/followers","following_url":"https://api.github.com/users/Be-ing/following{/other_user}","gists_url":"https://api.github.com/users/Be-ing/gists{/gist_id}","starred_url":"https://api.github.com/users/Be-ing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Be-ing/subscriptions","organizations_url":"https://api.github.com/users/Be-ing/orgs","repos_url":"https://api.github.com/users/Be-ing/repos","events_url":"https://api.github.com/users/Be-ing/events{/privacy}","received_events_url":"https://api.github.com/users/Be-ing/received_events","type":"User","site_admin":false},"body":"Fixing bug https://bugs.launchpad.net/mixxx/+bug/1567203","created_at":"2016-04-07T20:26:33Z","updated_at":"2016-04-11T07:23:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"654abb1f6d1156d6a85360c8e4bd7d4611a9c119","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/919/commits","review_comments_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/919/comments","review_comment_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/919/comments","statuses_url":"https://api.github.com/repos/mixxxdj/mixxx/statuses/9d3df5171374c08b5329c3bbbeedc47de375aee7","head":{"label":"Be-ing:fix_this","ref":"fix_this","sha":"9d3df5171374c08b5329c3bbbeedc47de375aee7","user":{"login":"Be-ing","id":9455094,"avatar_url":"https://avatars.githubusercontent.com/u/9455094?v=3","gravatar_id":"","url":"https://api.github.com/users/Be-ing","html_url":"https://github.com/Be-ing","followers_url":"https://api.github.com/users/Be-ing/followers","following_url":"https://api.github.com/users/Be-ing/following{/other_user}","gists_url":"https://api.github.com/users/Be-ing/gists{/gist_id}","starred_url":"https://api.github.com/users/Be-ing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Be-ing/subscriptions","organizations_url":"https://api.github.com/users/Be-ing/orgs","repos_url":"https://api.github.com/users/Be-ing/repos","events_url":"https://api.github.com/users/Be-ing/events{/privacy}","received_events_url":"https://api.github.com/users/Be-ing/received_events","type":"User","site_admin":false},"repo":{"id":36947294,"name":"mixxx","full_name":"Be-ing/mixxx","owner":{"login":"Be-ing","id":9455094,"avatar_url":"https://avatars.githubusercontent.com/u/9455094?v=3","gravatar_id":"","url":"https://api.github.com/users/Be-ing","html_url":"https://github.com/Be-ing","followers_url":"https://api.github.com/users/Be-ing/followers","following_url":"https://api.github.com/users/Be-ing/following{/other_user}","gists_url":"https://api.github.com/users/Be-ing/gists{/gist_id}","starred_url":"https://api.github.com/users/Be-ing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Be-ing/subscriptions","organizations_url":"https://api.github.com/users/Be-ing/orgs","repos_url":"https://api.github.com/users/Be-ing/repos","events_url":"https://api.github.com/users/Be-ing/events{/privacy}","received_events_url":"https://api.github.com/users/Be-ing/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Be-ing/mixxx","description":"Mixxx is Free DJ software that gives you everything you need to perform live mixes.","fork":true,"url":"https://api.github.com/repos/Be-ing/mixxx","forks_url":"https://api.github.com/repos/Be-ing/mixxx/forks","keys_url":"https://api.github.com/repos/Be-ing/mixxx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Be-ing/mixxx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Be-ing/mixxx/teams","hooks_url":"https://api.github.com/repos/Be-ing/mixxx/hooks","issue_events_url":"https://api.github.com/repos/Be-ing/mixxx/issues/events{/number}","events_url":"https://api.github.com/repos/Be-ing/mixxx/events","assignees_url":"https://api.github.com/repos/Be-ing/mixxx/assignees{/user}","branches_url":"https://api.github.com/repos/Be-ing/mixxx/branches{/branch}","tags_url":"https://api.github.com/repos/Be-ing/mixxx/tags","blobs_url":"https://api.github.com/repos/Be-ing/mixxx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Be-ing/mixxx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Be-ing/mixxx/git/refs{/sha}","trees_url":"https://api.github.com/repos/Be-ing/mixxx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Be-ing/mixxx/statuses/{sha}","languages_url":"https://api.github.com/repos/Be-ing/mixxx/languages","stargazers_url":"https://api.github.com/repos/Be-ing/mixxx/stargazers","contributors_url":"https://api.github.com/repos/Be-ing/mixxx/contributors","subscribers_url":"https://api.github.com/repos/Be-ing/mixxx/subscribers","subscription_url":"https://api.github.com/repos/Be-ing/mixxx/subscription","commits_url":"https://api.github.com/repos/Be-ing/mixxx/commits{/sha}","git_commits_url":"https://api.github.com/repos/Be-ing/mixxx/git/commits{/sha}","comments_url":"https://api.github.com/repos/Be-ing/mixxx/comments{/number}","issue_comment_url":"https://api.github.com/repos/Be-ing/mixxx/issues/comments{/number}","contents_url":"https://api.github.com/repos/Be-ing/mixxx/contents/{+path}","compare_url":"https://api.github.com/repos/Be-ing/mixxx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Be-ing/mixxx/merges","archive_url":"https://api.github.com/repos/Be-ing/mixxx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Be-ing/mixxx/downloads","issues_url":"https://api.github.com/repos/Be-ing/mixxx/issues{/number}","pulls_url":"https://api.github.com/repos/Be-ing/mixxx/pulls{/number}","milestones_url":"https://api.github.com/repos/Be-ing/mixxx/milestones{/number}","notifications_url":"https://api.github.com/repos/Be-ing/mixxx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Be-ing/mixxx/labels{/name}","releases_url":"https://api.github.com/repos/Be-ing/mixxx/releases{/id}","deployments_url":"https://api.github.com/repos/Be-ing/mixxx/deployments","created_at":"2015-06-05T18:00:37Z","updated_at":"2016-04-01T05:21:17Z","pushed_at":"2016-04-11T05:56:27Z","git_url":"git://github.com/Be-ing/mixxx.git","ssh_url":"git@github.com:Be-ing/mixxx.git","clone_url":"https://github.com/Be-ing/mixxx.git","svn_url":"https://github.com/Be-ing/mixxx","homepage":"http://mixxx.org","size":252714,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"tweaker_mapping"}},"base":{"label":"mixxxdj:master","ref":"master","sha":"ca341a84ae81eb2fdba09a2096914b01d3a230c1","user":{"login":"mixxxdj","id":1743769,"avatar_url":"https://avatars.githubusercontent.com/u/1743769?v=3","gravatar_id":"","url":"https://api.github.com/users/mixxxdj","html_url":"https://github.com/mixxxdj","followers_url":"https://api.github.com/users/mixxxdj/followers","following_url":"https://api.github.com/users/mixxxdj/following{/other_user}","gists_url":"https://api.github.com/users/mixxxdj/gists{/gist_id}","starred_url":"https://api.github.com/users/mixxxdj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mixxxdj/subscriptions","organizations_url":"https://api.github.com/users/mixxxdj/orgs","repos_url":"https://api.github.com/users/mixxxdj/repos","events_url":"https://api.github.com/users/mixxxdj/events{/privacy}","received_events_url":"https://api.github.com/users/mixxxdj/received_events","type":"Organization","site_admin":false},"repo":{"id":10126031,"name":"mixxx","full_name":"mixxxdj/mixxx","owner":{"login":"mixxxdj","id":1743769,"avatar_url":"https://avatars.githubusercontent.com/u/1743769?v=3","gravatar_id":"","url":"https://api.github.com/users/mixxxdj","html_url":"https://github.com/mixxxdj","followers_url":"https://api.github.com/users/mixxxdj/followers","following_url":"https://api.github.com/users/mixxxdj/following{/other_user}","gists_url":"https://api.github.com/users/mixxxdj/gists{/gist_id}","starred_url":"https://api.github.com/users/mixxxdj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mixxxdj/subscriptions","organizations_url":"https://api.github.com/users/mixxxdj/orgs","repos_url":"https://api.github.com/users/mixxxdj/repos","events_url":"https://api.github.com/users/mixxxdj/events{/privacy}","received_events_url":"https://api.github.com/users/mixxxdj/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mixxxdj/mixxx","description":"Mixxx is Free DJ software that gives you everything you need to perform live mixes.","fork":false,"url":"https://api.github.com/repos/mixxxdj/mixxx","forks_url":"https://api.github.com/repos/mixxxdj/mixxx/forks","keys_url":"https://api.github.com/repos/mixxxdj/mixxx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mixxxdj/mixxx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mixxxdj/mixxx/teams","hooks_url":"https://api.github.com/repos/mixxxdj/mixxx/hooks","issue_events_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/events{/number}","events_url":"https://api.github.com/repos/mixxxdj/mixxx/events","assignees_url":"https://api.github.com/repos/mixxxdj/mixxx/assignees{/user}","branches_url":"https://api.github.com/repos/mixxxdj/mixxx/branches{/branch}","tags_url":"https://api.github.com/repos/mixxxdj/mixxx/tags","blobs_url":"https://api.github.com/repos/mixxxdj/mixxx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mixxxdj/mixxx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mixxxdj/mixxx/git/refs{/sha}","trees_url":"https://api.github.com/repos/mixxxdj/mixxx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mixxxdj/mixxx/statuses/{sha}","languages_url":"https://api.github.com/repos/mixxxdj/mixxx/languages","stargazers_url":"https://api.github.com/repos/mixxxdj/mixxx/stargazers","contributors_url":"https://api.github.com/repos/mixxxdj/mixxx/contributors","subscribers_url":"https://api.github.com/repos/mixxxdj/mixxx/subscribers","subscription_url":"https://api.github.com/repos/mixxxdj/mixxx/subscription","commits_url":"https://api.github.com/repos/mixxxdj/mixxx/commits{/sha}","git_commits_url":"https://api.github.com/repos/mixxxdj/mixxx/git/commits{/sha}","comments_url":"https://api.github.com/repos/mixxxdj/mixxx/comments{/number}","issue_comment_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/comments{/number}","contents_url":"https://api.github.com/repos/mixxxdj/mixxx/contents/{+path}","compare_url":"https://api.github.com/repos/mixxxdj/mixxx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mixxxdj/mixxx/merges","archive_url":"https://api.github.com/repos/mixxxdj/mixxx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mixxxdj/mixxx/downloads","issues_url":"https://api.github.com/repos/mixxxdj/mixxx/issues{/number}","pulls_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls{/number}","milestones_url":"https://api.github.com/repos/mixxxdj/mixxx/milestones{/number}","notifications_url":"https://api.github.com/repos/mixxxdj/mixxx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mixxxdj/mixxx/labels{/name}","releases_url":"https://api.github.com/repos/mixxxdj/mixxx/releases{/id}","deployments_url":"https://api.github.com/repos/mixxxdj/mixxx/deployments","created_at":"2013-05-17T15:14:38Z","updated_at":"2016-04-10T19:02:29Z","pushed_at":"2016-04-11T05:56:29Z","git_url":"git://github.com/mixxxdj/mixxx.git","ssh_url":"git@github.com:mixxxdj/mixxx.git","clone_url":"https://github.com/mixxxdj/mixxx.git","svn_url":"https://github.com/mixxxdj/mixxx","homepage":"http://mixxx.org","size":269461,"stargazers_count":493,"watchers_count":493,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":316,"mirror_url":null,"open_issues_count":61,"forks":316,"open_issues":61,"watchers":493,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/919"},"html":{"href":"https://github.com/mixxxdj/mixxx/pull/919"},"issue":{"href":"https://api.github.com/repos/mixxxdj/mixxx/issues/919"},"comments":{"href":"https://api.github.com/repos/mixxxdj/mixxx/issues/919/comments"},"review_comments":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/919/comments"},"review_comment":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/919/commits"},"statuses":{"href":"https://api.github.com/repos/mixxxdj/mixxx/statuses/9d3df5171374c08b5329c3bbbeedc47de375aee7"}}}}