{"action":"created","issue":{"url":"https://api.github.com/repos/mobile-shell/mosh/issues/733","repository_url":"https://api.github.com/repos/mobile-shell/mosh","labels_url":"https://api.github.com/repos/mobile-shell/mosh/issues/733/labels{/name}","comments_url":"https://api.github.com/repos/mobile-shell/mosh/issues/733/comments","events_url":"https://api.github.com/repos/mobile-shell/mosh/issues/733/events","html_url":"https://github.com/mobile-shell/mosh/pull/733","id":142008147,"number":733,"title":"configure.ac:  Do s/-pthreads -lpthreads/-pthreads/ for protobuf","user":{"login":"cgull","id":1934797,"avatar_url":"https://avatars.githubusercontent.com/u/1934797?v=3","gravatar_id":"","url":"https://api.github.com/users/cgull","html_url":"https://github.com/cgull","followers_url":"https://api.github.com/users/cgull/followers","following_url":"https://api.github.com/users/cgull/following{/other_user}","gists_url":"https://api.github.com/users/cgull/gists{/gist_id}","starred_url":"https://api.github.com/users/cgull/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgull/subscriptions","organizations_url":"https://api.github.com/users/cgull/orgs","repos_url":"https://api.github.com/users/cgull/repos","events_url":"https://api.github.com/users/cgull/events{/privacy}","received_events_url":"https://api.github.com/users/cgull/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-03-19T00:34:25Z","updated_at":"2016-03-19T01:03:20Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mobile-shell/mosh/pulls/733","html_url":"https://github.com/mobile-shell/mosh/pull/733","diff_url":"https://github.com/mobile-shell/mosh/pull/733.diff","patch_url":"https://github.com/mobile-shell/mosh/pull/733.patch"},"body":"protobuf uses an obsolete automake pthreads detection macro,\r\nwhich results in \"pkgconfig --libs protobuf\" returning\r\n\"-lprotobuf -pthread -lpthread\" on Linux.  Remove\r\nthe unnecessary and dangerous -lpthread in that case.\r\n\r\nFixes #727, mosh-server crash in libutempter on Debian Sid."},"comment":{"url":"https://api.github.com/repos/mobile-shell/mosh/issues/comments/198596816","html_url":"https://github.com/mobile-shell/mosh/pull/733#issuecomment-198596816","issue_url":"https://api.github.com/repos/mobile-shell/mosh/issues/733","id":198596816,"user":{"login":"cgull","id":1934797,"avatar_url":"https://avatars.githubusercontent.com/u/1934797?v=3","gravatar_id":"","url":"https://api.github.com/users/cgull","html_url":"https://github.com/cgull","followers_url":"https://api.github.com/users/cgull/followers","following_url":"https://api.github.com/users/cgull/following{/other_user}","gists_url":"https://api.github.com/users/cgull/gists{/gist_id}","starred_url":"https://api.github.com/users/cgull/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgull/subscriptions","organizations_url":"https://api.github.com/users/cgull/orgs","repos_url":"https://api.github.com/users/cgull/repos","events_url":"https://api.github.com/users/cgull/events{/privacy}","received_events_url":"https://api.github.com/users/cgull/received_events","type":"User","site_admin":false},"created_at":"2016-03-19T01:03:20Z","updated_at":"2016-03-19T01:03:20Z","body":"The protobuf `configure.ac` uses an ancient `ax_pthread.m4` macro, which Autoconf obsoleted and renamed to `acx_pthread.m4` back in 2009.  Google's made a few updates to their file, GNU Autoconf...a lot more.  The variables that macro sets are used to substitute `protobuf.pc`.\r\n\r\nSwapping in `acx_pthread.m4` makes protobuf.pc more correct.\r\n\r\nI will loudly kvetch that autoconf is a pile of accreted...stuff that seems to hinder portability as much as it helps; having the .m4 files be embedded by autoconf users rather than distributed with autoconf doesn't exactly help maintainability.  It won't do any good, the OSS world is kind of stuck with it now."}}