{"action":"created","issue":{"url":"https://api.github.com/repos/caskdata/cdap/issues/6139","repository_url":"https://api.github.com/repos/caskdata/cdap","labels_url":"https://api.github.com/repos/caskdata/cdap/issues/6139/labels{/name}","comments_url":"https://api.github.com/repos/caskdata/cdap/issues/6139/comments","events_url":"https://api.github.com/repos/caskdata/cdap/issues/6139/events","html_url":"https://github.com/caskdata/cdap/pull/6139","id":166947482,"number":6139,"title":"Make LogSaver use NamespacedLocationFactory","user":{"login":"rohitsinha54","id":1472867,"avatar_url":"https://avatars.githubusercontent.com/u/1472867?v=3","gravatar_id":"","url":"https://api.github.com/users/rohitsinha54","html_url":"https://github.com/rohitsinha54","followers_url":"https://api.github.com/users/rohitsinha54/followers","following_url":"https://api.github.com/users/rohitsinha54/following{/other_user}","gists_url":"https://api.github.com/users/rohitsinha54/gists{/gist_id}","starred_url":"https://api.github.com/users/rohitsinha54/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rohitsinha54/subscriptions","organizations_url":"https://api.github.com/users/rohitsinha54/orgs","repos_url":"https://api.github.com/users/rohitsinha54/repos","events_url":"https://api.github.com/users/rohitsinha54/events{/privacy}","received_events_url":"https://api.github.com/users/rohitsinha54/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/caskdata/cdap/labels/3.5","name":"3.5","color":"ff6600"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/caskdata/cdap/milestones/25","html_url":"https://github.com/caskdata/cdap/milestones/3.5","labels_url":"https://api.github.com/repos/caskdata/cdap/milestones/25/labels","id":1745860,"number":25,"title":"3.5","description":null,"creator":{"login":"rohitsinha54","id":1472867,"avatar_url":"https://avatars.githubusercontent.com/u/1472867?v=3","gravatar_id":"","url":"https://api.github.com/users/rohitsinha54","html_url":"https://github.com/rohitsinha54","followers_url":"https://api.github.com/users/rohitsinha54/followers","following_url":"https://api.github.com/users/rohitsinha54/following{/other_user}","gists_url":"https://api.github.com/users/rohitsinha54/gists{/gist_id}","starred_url":"https://api.github.com/users/rohitsinha54/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rohitsinha54/subscriptions","organizations_url":"https://api.github.com/users/rohitsinha54/orgs","repos_url":"https://api.github.com/users/rohitsinha54/repos","events_url":"https://api.github.com/users/rohitsinha54/events{/privacy}","received_events_url":"https://api.github.com/users/rohitsinha54/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":70,"state":"open","created_at":"2016-05-03T18:02:56Z","updated_at":"2016-07-22T21:34:08Z","due_on":null,"closed_at":null},"comments":6,"created_at":"2016-07-22T00:34:21Z","updated_at":"2016-07-22T23:39:04Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/caskdata/cdap/pulls/6139","html_url":"https://github.com/caskdata/cdap/pull/6139","diff_url":"https://github.com/caskdata/cdap/pull/6139.diff","patch_url":"https://github.com/caskdata/cdap/pull/6139.patch"},"body":"Issue: https://issues.cask.co/browse/CDAP-6548\r\nBuild: http://builds.cask.co/browse/CDAP-DUT4469-1\r\nITN: http://builds.cask.co/browse/CDAP-ITM-21\r\n\r\n- CDAP LogSaver now uses NamespacedLocationFactory\r\n- This change is required because the logs of custom mapped namespaces should go to the custom location. Currently, they went into cdap/namespaces directory since log saver was not using NamespacedLocationFactory\r\n- LogCleanup and FileMetadataManager classes now also need RootLocationFactory because for custom mapped locations the log files can only accessed if we work with  location factory based on root of filesystem"},"comment":{"url":"https://api.github.com/repos/caskdata/cdap/issues/comments/234682123","html_url":"https://github.com/caskdata/cdap/pull/6139#issuecomment-234682123","issue_url":"https://api.github.com/repos/caskdata/cdap/issues/6139","id":234682123,"user":{"login":"poornachandra","id":3181212,"avatar_url":"https://avatars.githubusercontent.com/u/3181212?v=3","gravatar_id":"","url":"https://api.github.com/users/poornachandra","html_url":"https://github.com/poornachandra","followers_url":"https://api.github.com/users/poornachandra/followers","following_url":"https://api.github.com/users/poornachandra/following{/other_user}","gists_url":"https://api.github.com/users/poornachandra/gists{/gist_id}","starred_url":"https://api.github.com/users/poornachandra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poornachandra/subscriptions","organizations_url":"https://api.github.com/users/poornachandra/orgs","repos_url":"https://api.github.com/users/poornachandra/repos","events_url":"https://api.github.com/users/poornachandra/events{/privacy}","received_events_url":"https://api.github.com/users/poornachandra/received_events","type":"User","site_admin":false},"created_at":"2016-07-22T23:39:04Z","updated_at":"2016-07-22T23:39:04Z","body":"Would be a good idea to test log files cleanup with custom namespaces."}}
{"actor":{"display_login":"poornachandra"}}