{"action":"created","comment":{"url":"https://api.github.com/repos/cake-build/cake/pulls/comments/78827701","id":78827701,"diff_hunk":"@@ -0,0 +1,112 @@\n+﻿// Licensed to the .NET Foundation under one or more agreements.\n+// The .NET Foundation licenses this file to you under the MIT license.\n+// See the LICENSE file in the project root for more information.\n+\n+using System.Linq;\n+using Cake.NuGet.Tests.Fixtures;\n+using Cake.Testing;\n+using Xunit;\n+\n+namespace Cake.NuGet.Tests.Unit\n+{\n+    public sealed class NuGetContentResolverTests\n+    {\n+        public sealed class Tools\n+        {\n+            [Fact]\n+            public void Should_Return_Exe_Files_By_Default()\n+            {\n+                // Given\n+                var fixture = new NuGetToolContentResolverFixture(\"nuget:?package=Foo\");\n+                fixture.FileSystem.CreateFile(\"/Working/tools/Foo/Foo.exe\");\n+                fixture.FileSystem.CreateFile(\"/Working/tools/Foo/Foo.pdb\");\n+                fixture.FileSystem.CreateFile(\"/Working/tools/Foo/Foo.XML\");\n+\n+                // When\n+                var files = fixture.GetFiles();\n+\n+                // Then\n+                Assert.Equal(1, files.Count);\n+                Assert.Equal(\"/Working/tools/Foo/Foo.exe\", files.First().Path.FullPath);\n+            }\n+\n+            [Fact]\n+            public void Should_Return_Dll_Files_By_Default()\n+            {\n+                // Given\n+                var fixture = new NuGetToolContentResolverFixture(\"nuget:?package=Foo\");\n+                fixture.FileSystem.CreateFile(\"/Working/tools/Foo/Foo.dll\");\n+                fixture.FileSystem.CreateFile(\"/Working/tools/Foo/Foo.pdb\");\n+                fixture.FileSystem.CreateFile(\"/Working/tools/Foo/Foo.XML\");\n+\n+                // When\n+                var files = fixture.GetFiles();\n+\n+                // Then\n+                Assert.Equal(1, files.Count);\n+                Assert.Equal(\"/Working/tools/Foo/Foo.dll\", files.First().Path.FullPath);\n+            }\n+\n+            [Theory]\n+            [InlineData(\"nuget:?package=Foo&include=/**/*.XML\")]\n+            [InlineData(\"nuget:?package=Foo&include=**/*.XML\")]\n+            [InlineData(\"nuget:?package=Foo&include=./**/*.XML\")]","path":"src/Cake.NuGet.Tests/Unit/NuGetContentResolverTests.cs","position":53,"original_position":53,"commit_id":"05002184e8127c1089100094427617d8d42943ce","original_commit_id":"05002184e8127c1089100094427617d8d42943ce","user":{"login":"patriksvensson","id":357872,"avatar_url":"https://avatars.githubusercontent.com/u/357872?v=3","gravatar_id":"","url":"https://api.github.com/users/patriksvensson","html_url":"https://github.com/patriksvensson","followers_url":"https://api.github.com/users/patriksvensson/followers","following_url":"https://api.github.com/users/patriksvensson/following{/other_user}","gists_url":"https://api.github.com/users/patriksvensson/gists{/gist_id}","starred_url":"https://api.github.com/users/patriksvensson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patriksvensson/subscriptions","organizations_url":"https://api.github.com/users/patriksvensson/orgs","repos_url":"https://api.github.com/users/patriksvensson/repos","events_url":"https://api.github.com/users/patriksvensson/events{/privacy}","received_events_url":"https://api.github.com/users/patriksvensson/received_events","type":"User","site_admin":false},"body":"We could change the interface for `IGlobber` to take a `PathComparer` and move the existing method to an extension method (that uses the default comparer). A breaking change, but something that would be useful in general. Or we could extend globbing to accept regex expressions, like here: https://en.wikipedia.org/wiki/Glob_(programming)","created_at":"2016-09-14T20:03:17Z","updated_at":"2016-09-14T20:03:17Z","html_url":"https://github.com/cake-build/cake/pull/1202#discussion_r78827701","pull_request_url":"https://api.github.com/repos/cake-build/cake/pulls/1202","_links":{"self":{"href":"https://api.github.com/repos/cake-build/cake/pulls/comments/78827701"},"html":{"href":"https://github.com/cake-build/cake/pull/1202#discussion_r78827701"},"pull_request":{"href":"https://api.github.com/repos/cake-build/cake/pulls/1202"}}},"pull_request":{"url":"https://api.github.com/repos/cake-build/cake/pulls/1202","id":83233154,"html_url":"https://github.com/cake-build/cake/pull/1202","diff_url":"https://github.com/cake-build/cake/pull/1202.diff","patch_url":"https://github.com/cake-build/cake/pull/1202.patch","issue_url":"https://api.github.com/repos/cake-build/cake/issues/1202","number":1202,"state":"open","locked":false,"title":"GH1184: Added support for manually including/excluding files for tools","user":{"login":"patriksvensson","id":357872,"avatar_url":"https://avatars.githubusercontent.com/u/357872?v=3","gravatar_id":"","url":"https://api.github.com/users/patriksvensson","html_url":"https://github.com/patriksvensson","followers_url":"https://api.github.com/users/patriksvensson/followers","following_url":"https://api.github.com/users/patriksvensson/following{/other_user}","gists_url":"https://api.github.com/users/patriksvensson/gists{/gist_id}","starred_url":"https://api.github.com/users/patriksvensson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patriksvensson/subscriptions","organizations_url":"https://api.github.com/users/patriksvensson/orgs","repos_url":"https://api.github.com/users/patriksvensson/repos","events_url":"https://api.github.com/users/patriksvensson/events{/privacy}","received_events_url":"https://api.github.com/users/patriksvensson/received_events","type":"User","site_admin":false},"body":"- [x] Query string should support multiple parameters with same name\r\n- [x] Add include/exclude parameter\r\n- [x] Better error messages\r\n- [x] Tests","created_at":"2016-08-30T09:02:40Z","updated_at":"2016-09-14T20:03:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6f90325de7b30b5d345b7a2db146c5d85788614d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/cake-build/cake/pulls/1202/commits","review_comments_url":"https://api.github.com/repos/cake-build/cake/pulls/1202/comments","review_comment_url":"https://api.github.com/repos/cake-build/cake/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cake-build/cake/issues/1202/comments","statuses_url":"https://api.github.com/repos/cake-build/cake/statuses/05002184e8127c1089100094427617d8d42943ce","head":{"label":"patriksvensson:feature/GH1184","ref":"feature/GH1184","sha":"05002184e8127c1089100094427617d8d42943ce","user":{"login":"patriksvensson","id":357872,"avatar_url":"https://avatars.githubusercontent.com/u/357872?v=3","gravatar_id":"","url":"https://api.github.com/users/patriksvensson","html_url":"https://github.com/patriksvensson","followers_url":"https://api.github.com/users/patriksvensson/followers","following_url":"https://api.github.com/users/patriksvensson/following{/other_user}","gists_url":"https://api.github.com/users/patriksvensson/gists{/gist_id}","starred_url":"https://api.github.com/users/patriksvensson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patriksvensson/subscriptions","organizations_url":"https://api.github.com/users/patriksvensson/orgs","repos_url":"https://api.github.com/users/patriksvensson/repos","events_url":"https://api.github.com/users/patriksvensson/events{/privacy}","received_events_url":"https://api.github.com/users/patriksvensson/received_events","type":"User","site_admin":false},"repo":{"id":51225732,"name":"cake","full_name":"patriksvensson/cake","owner":{"login":"patriksvensson","id":357872,"avatar_url":"https://avatars.githubusercontent.com/u/357872?v=3","gravatar_id":"","url":"https://api.github.com/users/patriksvensson","html_url":"https://github.com/patriksvensson","followers_url":"https://api.github.com/users/patriksvensson/followers","following_url":"https://api.github.com/users/patriksvensson/following{/other_user}","gists_url":"https://api.github.com/users/patriksvensson/gists{/gist_id}","starred_url":"https://api.github.com/users/patriksvensson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patriksvensson/subscriptions","organizations_url":"https://api.github.com/users/patriksvensson/orgs","repos_url":"https://api.github.com/users/patriksvensson/repos","events_url":"https://api.github.com/users/patriksvensson/events{/privacy}","received_events_url":"https://api.github.com/users/patriksvensson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/patriksvensson/cake","description":"Cake (C# Make) is a cross platform build automation system.","fork":true,"url":"https://api.github.com/repos/patriksvensson/cake","forks_url":"https://api.github.com/repos/patriksvensson/cake/forks","keys_url":"https://api.github.com/repos/patriksvensson/cake/keys{/key_id}","collaborators_url":"https://api.github.com/repos/patriksvensson/cake/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/patriksvensson/cake/teams","hooks_url":"https://api.github.com/repos/patriksvensson/cake/hooks","issue_events_url":"https://api.github.com/repos/patriksvensson/cake/issues/events{/number}","events_url":"https://api.github.com/repos/patriksvensson/cake/events","assignees_url":"https://api.github.com/repos/patriksvensson/cake/assignees{/user}","branches_url":"https://api.github.com/repos/patriksvensson/cake/branches{/branch}","tags_url":"https://api.github.com/repos/patriksvensson/cake/tags","blobs_url":"https://api.github.com/repos/patriksvensson/cake/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/patriksvensson/cake/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/patriksvensson/cake/git/refs{/sha}","trees_url":"https://api.github.com/repos/patriksvensson/cake/git/trees{/sha}","statuses_url":"https://api.github.com/repos/patriksvensson/cake/statuses/{sha}","languages_url":"https://api.github.com/repos/patriksvensson/cake/languages","stargazers_url":"https://api.github.com/repos/patriksvensson/cake/stargazers","contributors_url":"https://api.github.com/repos/patriksvensson/cake/contributors","subscribers_url":"https://api.github.com/repos/patriksvensson/cake/subscribers","subscription_url":"https://api.github.com/repos/patriksvensson/cake/subscription","commits_url":"https://api.github.com/repos/patriksvensson/cake/commits{/sha}","git_commits_url":"https://api.github.com/repos/patriksvensson/cake/git/commits{/sha}","comments_url":"https://api.github.com/repos/patriksvensson/cake/comments{/number}","issue_comment_url":"https://api.github.com/repos/patriksvensson/cake/issues/comments{/number}","contents_url":"https://api.github.com/repos/patriksvensson/cake/contents/{+path}","compare_url":"https://api.github.com/repos/patriksvensson/cake/compare/{base}...{head}","merges_url":"https://api.github.com/repos/patriksvensson/cake/merges","archive_url":"https://api.github.com/repos/patriksvensson/cake/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/patriksvensson/cake/downloads","issues_url":"https://api.github.com/repos/patriksvensson/cake/issues{/number}","pulls_url":"https://api.github.com/repos/patriksvensson/cake/pulls{/number}","milestones_url":"https://api.github.com/repos/patriksvensson/cake/milestones{/number}","notifications_url":"https://api.github.com/repos/patriksvensson/cake/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/patriksvensson/cake/labels{/name}","releases_url":"https://api.github.com/repos/patriksvensson/cake/releases{/id}","deployments_url":"https://api.github.com/repos/patriksvensson/cake/deployments","created_at":"2016-02-06T22:44:16Z","updated_at":"2016-02-06T22:44:18Z","pushed_at":"2016-09-14T08:17:09Z","git_url":"git://github.com/patriksvensson/cake.git","ssh_url":"git@github.com:patriksvensson/cake.git","clone_url":"https://github.com/patriksvensson/cake.git","svn_url":"https://github.com/patriksvensson/cake","homepage":"http://cakebuild.net/","size":6126,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"cake-build:develop","ref":"develop","sha":"94626aef8c51a1c29ff2578aeade873a9660e2f0","user":{"login":"cake-build","id":7738262,"avatar_url":"https://avatars.githubusercontent.com/u/7738262?v=3","gravatar_id":"","url":"https://api.github.com/users/cake-build","html_url":"https://github.com/cake-build","followers_url":"https://api.github.com/users/cake-build/followers","following_url":"https://api.github.com/users/cake-build/following{/other_user}","gists_url":"https://api.github.com/users/cake-build/gists{/gist_id}","starred_url":"https://api.github.com/users/cake-build/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cake-build/subscriptions","organizations_url":"https://api.github.com/users/cake-build/orgs","repos_url":"https://api.github.com/users/cake-build/repos","events_url":"https://api.github.com/users/cake-build/events{/privacy}","received_events_url":"https://api.github.com/users/cake-build/received_events","type":"Organization","site_admin":false},"repo":{"id":20094029,"name":"cake","full_name":"cake-build/cake","owner":{"login":"cake-build","id":7738262,"avatar_url":"https://avatars.githubusercontent.com/u/7738262?v=3","gravatar_id":"","url":"https://api.github.com/users/cake-build","html_url":"https://github.com/cake-build","followers_url":"https://api.github.com/users/cake-build/followers","following_url":"https://api.github.com/users/cake-build/following{/other_user}","gists_url":"https://api.github.com/users/cake-build/gists{/gist_id}","starred_url":"https://api.github.com/users/cake-build/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cake-build/subscriptions","organizations_url":"https://api.github.com/users/cake-build/orgs","repos_url":"https://api.github.com/users/cake-build/repos","events_url":"https://api.github.com/users/cake-build/events{/privacy}","received_events_url":"https://api.github.com/users/cake-build/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cake-build/cake","description":"Cake (C# Make) is a cross platform build automation system.","fork":false,"url":"https://api.github.com/repos/cake-build/cake","forks_url":"https://api.github.com/repos/cake-build/cake/forks","keys_url":"https://api.github.com/repos/cake-build/cake/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cake-build/cake/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cake-build/cake/teams","hooks_url":"https://api.github.com/repos/cake-build/cake/hooks","issue_events_url":"https://api.github.com/repos/cake-build/cake/issues/events{/number}","events_url":"https://api.github.com/repos/cake-build/cake/events","assignees_url":"https://api.github.com/repos/cake-build/cake/assignees{/user}","branches_url":"https://api.github.com/repos/cake-build/cake/branches{/branch}","tags_url":"https://api.github.com/repos/cake-build/cake/tags","blobs_url":"https://api.github.com/repos/cake-build/cake/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cake-build/cake/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cake-build/cake/git/refs{/sha}","trees_url":"https://api.github.com/repos/cake-build/cake/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cake-build/cake/statuses/{sha}","languages_url":"https://api.github.com/repos/cake-build/cake/languages","stargazers_url":"https://api.github.com/repos/cake-build/cake/stargazers","contributors_url":"https://api.github.com/repos/cake-build/cake/contributors","subscribers_url":"https://api.github.com/repos/cake-build/cake/subscribers","subscription_url":"https://api.github.com/repos/cake-build/cake/subscription","commits_url":"https://api.github.com/repos/cake-build/cake/commits{/sha}","git_commits_url":"https://api.github.com/repos/cake-build/cake/git/commits{/sha}","comments_url":"https://api.github.com/repos/cake-build/cake/comments{/number}","issue_comment_url":"https://api.github.com/repos/cake-build/cake/issues/comments{/number}","contents_url":"https://api.github.com/repos/cake-build/cake/contents/{+path}","compare_url":"https://api.github.com/repos/cake-build/cake/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cake-build/cake/merges","archive_url":"https://api.github.com/repos/cake-build/cake/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cake-build/cake/downloads","issues_url":"https://api.github.com/repos/cake-build/cake/issues{/number}","pulls_url":"https://api.github.com/repos/cake-build/cake/pulls{/number}","milestones_url":"https://api.github.com/repos/cake-build/cake/milestones{/number}","notifications_url":"https://api.github.com/repos/cake-build/cake/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cake-build/cake/labels{/name}","releases_url":"https://api.github.com/repos/cake-build/cake/releases{/id}","deployments_url":"https://api.github.com/repos/cake-build/cake/deployments","created_at":"2014-05-23T09:26:54Z","updated_at":"2016-09-14T19:26:42Z","pushed_at":"2016-09-14T19:28:12Z","git_url":"git://github.com/cake-build/cake.git","ssh_url":"git@github.com:cake-build/cake.git","clone_url":"https://github.com/cake-build/cake.git","svn_url":"https://github.com/cake-build/cake","homepage":"http://cakebuild.net/","size":9137,"stargazers_count":797,"watchers_count":797,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":200,"mirror_url":null,"open_issues_count":140,"forks":200,"open_issues":140,"watchers":797,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/cake-build/cake/pulls/1202"},"html":{"href":"https://github.com/cake-build/cake/pull/1202"},"issue":{"href":"https://api.github.com/repos/cake-build/cake/issues/1202"},"comments":{"href":"https://api.github.com/repos/cake-build/cake/issues/1202/comments"},"review_comments":{"href":"https://api.github.com/repos/cake-build/cake/pulls/1202/comments"},"review_comment":{"href":"https://api.github.com/repos/cake-build/cake/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cake-build/cake/pulls/1202/commits"},"statuses":{"href":"https://api.github.com/repos/cake-build/cake/statuses/05002184e8127c1089100094427617d8d42943ce"}}}}
{"actor":{"display_login":"patriksvensson"}}