{"action":"opened","issue":{"url":"https://api.github.com/repos/zihanzzz/Flicks/issues/1","repository_url":"https://api.github.com/repos/zihanzzz/Flicks","labels_url":"https://api.github.com/repos/zihanzzz/Flicks/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/zihanzzz/Flicks/issues/1/comments","events_url":"https://api.github.com/repos/zihanzzz/Flicks/issues/1/events","html_url":"https://github.com/zihanzzz/Flicks/issues/1","id":183501022,"number":1,"title":"Project Feedback!","user":{"login":"codepathreview","id":7917093,"avatar_url":"https://avatars.githubusercontent.com/u/7917093?v=3","gravatar_id":"","url":"https://api.github.com/users/codepathreview","html_url":"https://github.com/codepathreview","followers_url":"https://api.github.com/users/codepathreview/followers","following_url":"https://api.github.com/users/codepathreview/following{/other_user}","gists_url":"https://api.github.com/users/codepathreview/gists{/gist_id}","starred_url":"https://api.github.com/users/codepathreview/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codepathreview/subscriptions","organizations_url":"https://api.github.com/users/codepathreview/orgs","repos_url":"https://api.github.com/users/codepathreview/repos","events_url":"https://api.github.com/users/codepathreview/events{/privacy}","received_events_url":"https://api.github.com/users/codepathreview/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-10-17T19:10:39Z","updated_at":"2016-10-17T19:10:39Z","closed_at":null,"body":":+1: great job! The point of this homework was to explore a simple example of a full MVC application with a RESTful API. Excellent job tackling many of the optional features. The more optional features you tackle, the more of the framework you'll be able to explore by the end of the class.\r\n\r\nHere's a checklist of things that I'm looking for in this project. You should review the checklist, and make any changes to your project, if necessary.\r\n\r\n- **Code styling**. Check out the [Ray Wenderlich Swift Style Guide](https://github.com/raywenderlich/swift-style-guide) and the [Github Swift Style Guide](https://github.com/github/swift-style-guide)\r\n- **Using groups to organize your source files**. It's pretty common to organize your source files into [Groups](https://developer.apple.com/library/ios/recipes/xcode_help-structure_navigator/articles/Creating_a_Group.html), especially for larger projects. You can organize by type of class (i.e. View Controllers, Views, etc) or for larger apps by functionality (i.e. Home Screen, Search Screen, etc).\r\n- **Minimize the number of public functions and properties in your classes**. You should always try to minimize the number of properties and functions that are public or internal. If unspecified, the scope is internal.\r\n- **Set the Content Mode for your ImageViews**. By default the [UIContentMode](https://developer.apple.com/library/ios/documentation/UIKit/Reference/UIView_Class/#//apple_ref/c/tdef/UIViewContentMode) will stretch the image to match the dimensions of the image view, which is probably not what you want. You usually want it set to Aspect Fill with clip subviews.\r\n- **Avoid naming collisions inside of your UITableViewCell**. When creating a custom cell make sure to never name a property imageView, titleLabel, or subtitleLabel. Those are already defined by UITableViewCell and using them in your custom cell will cause subtle things to happen such as image views not loading until you click on the cell.\r\n- **Model classes**. Creating a `Movie` model class will allow you move the deserialization code out of the view controller. You should also create a `movie` property in your custom cell and use a property observer to update the cell's subviews. There are certain libraries like [SwiftyJSON](https://github.com/SwiftyJSON/SwiftyJSON) that remove the need for a lot of boilerplate code and make it easier to convert from JSON to your model objects. Other popular repositories include [Argo](https://github.com/thoughtbot/Argo), [ObjectMapper](https://github.com/Hearst-DD/ObjectMapper), and [Decodable](https://github.com/Anviking/Decodable)\r\n- Next week, we'll cover how to use Auto Layout constraints to implement dynamic height rows and adjust to synopsis of different length.\r\n\r\nIn general, you should challenge yourself to create visually polished applications. That's where you'll find all the rough edges of the iOS framework and earn the next level of mastery.\r\n\r\n"}}
{"actor":{"display_login":"codepathreview"}}