{"action":"created","comment":{"url":"https://api.github.com/repos/dneg/openvdb_points_dev/pulls/comments/74349530","id":74349530,"diff_hunk":"@@ -922,9 +959,9 @@ template<typename ValueType_, typename Codec_>\n typename TypedAttributeArray<ValueType_, Codec_>::ValueType\n TypedAttributeArray<ValueType_, Codec_>::get(Index n) const\n {\n-    if (this->isCompressed())           const_cast<TypedAttributeArray*>(this)->decompress();\n-    else if (this->isOutOfCore())       this->doLoad();\n-    else if (n >= this->size())         OPENVDB_THROW(IndexError, \"Out-of-range access.\");\n+    if (this->isCompressed())                       const_cast<TypedAttributeArray*>(this)->decompress();\n+    else if (this->isOutOfCore())                   this->doLoad();\n+    else if (n >= this->size() * this->stride())    OPENVDB_THROW(IndexError, \"Out-of-range access.\");","path":"openvdb_points/tools/AttributeArray.h","position":293,"original_position":293,"commit_id":"a72f5619b9ff61b1bfd2f992b567d769bdd693b0","original_commit_id":"a72f5619b9ff61b1bfd2f992b567d769bdd693b0","user":{"login":"danrbailey","id":5251654,"avatar_url":"https://avatars.githubusercontent.com/u/5251654?v=3","gravatar_id":"","url":"https://api.github.com/users/danrbailey","html_url":"https://github.com/danrbailey","followers_url":"https://api.github.com/users/danrbailey/followers","following_url":"https://api.github.com/users/danrbailey/following{/other_user}","gists_url":"https://api.github.com/users/danrbailey/gists{/gist_id}","starred_url":"https://api.github.com/users/danrbailey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danrbailey/subscriptions","organizations_url":"https://api.github.com/users/danrbailey/orgs","repos_url":"https://api.github.com/users/danrbailey/repos","events_url":"https://api.github.com/users/danrbailey/events{/privacy}","received_events_url":"https://api.github.com/users/danrbailey/received_events","type":"User","site_admin":false},"body":"Good point, changed this now.","created_at":"2016-08-10T23:24:44Z","updated_at":"2016-08-10T23:24:44Z","html_url":"https://github.com/dneg/openvdb_points_dev/pull/47#discussion_r74349530","pull_request_url":"https://api.github.com/repos/dneg/openvdb_points_dev/pulls/47","_links":{"self":{"href":"https://api.github.com/repos/dneg/openvdb_points_dev/pulls/comments/74349530"},"html":{"href":"https://github.com/dneg/openvdb_points_dev/pull/47#discussion_r74349530"},"pull_request":{"href":"https://api.github.com/repos/dneg/openvdb_points_dev/pulls/47"}}},"pull_request":{"url":"https://api.github.com/repos/dneg/openvdb_points_dev/pulls/47","id":80010528,"html_url":"https://github.com/dneg/openvdb_points_dev/pull/47","diff_url":"https://github.com/dneg/openvdb_points_dev/pull/47.diff","patch_url":"https://github.com/dneg/openvdb_points_dev/pull/47.patch","issue_url":"https://api.github.com/repos/dneg/openvdb_points_dev/issues/47","number":47,"state":"open","locked":false,"title":"Add striding and interleaving to AttributeArrays","user":{"login":"danrbailey","id":5251654,"avatar_url":"https://avatars.githubusercontent.com/u/5251654?v=3","gravatar_id":"","url":"https://api.github.com/users/danrbailey","html_url":"https://github.com/danrbailey","followers_url":"https://api.github.com/users/danrbailey/followers","following_url":"https://api.github.com/users/danrbailey/following{/other_user}","gists_url":"https://api.github.com/users/danrbailey/gists{/gist_id}","starred_url":"https://api.github.com/users/danrbailey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danrbailey/subscriptions","organizations_url":"https://api.github.com/users/danrbailey/orgs","repos_url":"https://api.github.com/users/danrbailey/repos","events_url":"https://api.github.com/users/danrbailey/events{/privacy}","received_events_url":"https://api.github.com/users/danrbailey/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-08-04T02:44:45Z","updated_at":"2016-08-10T23:24:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"16e8fcb7d17fbead79db45f8ae52d2463ae55f67","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dneg/openvdb_points_dev/pulls/47/commits","review_comments_url":"https://api.github.com/repos/dneg/openvdb_points_dev/pulls/47/comments","review_comment_url":"https://api.github.com/repos/dneg/openvdb_points_dev/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dneg/openvdb_points_dev/issues/47/comments","statuses_url":"https://api.github.com/repos/dneg/openvdb_points_dev/statuses/a72f5619b9ff61b1bfd2f992b567d769bdd693b0","head":{"label":"dneg:stride","ref":"stride","sha":"a72f5619b9ff61b1bfd2f992b567d769bdd693b0","user":{"login":"dneg","id":5524887,"avatar_url":"https://avatars.githubusercontent.com/u/5524887?v=3","gravatar_id":"","url":"https://api.github.com/users/dneg","html_url":"https://github.com/dneg","followers_url":"https://api.github.com/users/dneg/followers","following_url":"https://api.github.com/users/dneg/following{/other_user}","gists_url":"https://api.github.com/users/dneg/gists{/gist_id}","starred_url":"https://api.github.com/users/dneg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dneg/subscriptions","organizations_url":"https://api.github.com/users/dneg/orgs","repos_url":"https://api.github.com/users/dneg/repos","events_url":"https://api.github.com/users/dneg/events{/privacy}","received_events_url":"https://api.github.com/users/dneg/received_events","type":"Organization","site_admin":false},"repo":{"id":35619792,"name":"openvdb_points_dev","full_name":"dneg/openvdb_points_dev","owner":{"login":"dneg","id":5524887,"avatar_url":"https://avatars.githubusercontent.com/u/5524887?v=3","gravatar_id":"","url":"https://api.github.com/users/dneg","html_url":"https://github.com/dneg","followers_url":"https://api.github.com/users/dneg/followers","following_url":"https://api.github.com/users/dneg/following{/other_user}","gists_url":"https://api.github.com/users/dneg/gists{/gist_id}","starred_url":"https://api.github.com/users/dneg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dneg/subscriptions","organizations_url":"https://api.github.com/users/dneg/orgs","repos_url":"https://api.github.com/users/dneg/repos","events_url":"https://api.github.com/users/dneg/events{/privacy}","received_events_url":"https://api.github.com/users/dneg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dneg/openvdb_points_dev","description":"OpenVDB Points Development Repository","fork":false,"url":"https://api.github.com/repos/dneg/openvdb_points_dev","forks_url":"https://api.github.com/repos/dneg/openvdb_points_dev/forks","keys_url":"https://api.github.com/repos/dneg/openvdb_points_dev/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dneg/openvdb_points_dev/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dneg/openvdb_points_dev/teams","hooks_url":"https://api.github.com/repos/dneg/openvdb_points_dev/hooks","issue_events_url":"https://api.github.com/repos/dneg/openvdb_points_dev/issues/events{/number}","events_url":"https://api.github.com/repos/dneg/openvdb_points_dev/events","assignees_url":"https://api.github.com/repos/dneg/openvdb_points_dev/assignees{/user}","branches_url":"https://api.github.com/repos/dneg/openvdb_points_dev/branches{/branch}","tags_url":"https://api.github.com/repos/dneg/openvdb_points_dev/tags","blobs_url":"https://api.github.com/repos/dneg/openvdb_points_dev/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dneg/openvdb_points_dev/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dneg/openvdb_points_dev/git/refs{/sha}","trees_url":"https://api.github.com/repos/dneg/openvdb_points_dev/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dneg/openvdb_points_dev/statuses/{sha}","languages_url":"https://api.github.com/repos/dneg/openvdb_points_dev/languages","stargazers_url":"https://api.github.com/repos/dneg/openvdb_points_dev/stargazers","contributors_url":"https://api.github.com/repos/dneg/openvdb_points_dev/contributors","subscribers_url":"https://api.github.com/repos/dneg/openvdb_points_dev/subscribers","subscription_url":"https://api.github.com/repos/dneg/openvdb_points_dev/subscription","commits_url":"https://api.github.com/repos/dneg/openvdb_points_dev/commits{/sha}","git_commits_url":"https://api.github.com/repos/dneg/openvdb_points_dev/git/commits{/sha}","comments_url":"https://api.github.com/repos/dneg/openvdb_points_dev/comments{/number}","issue_comment_url":"https://api.github.com/repos/dneg/openvdb_points_dev/issues/comments{/number}","contents_url":"https://api.github.com/repos/dneg/openvdb_points_dev/contents/{+path}","compare_url":"https://api.github.com/repos/dneg/openvdb_points_dev/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dneg/openvdb_points_dev/merges","archive_url":"https://api.github.com/repos/dneg/openvdb_points_dev/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dneg/openvdb_points_dev/downloads","issues_url":"https://api.github.com/repos/dneg/openvdb_points_dev/issues{/number}","pulls_url":"https://api.github.com/repos/dneg/openvdb_points_dev/pulls{/number}","milestones_url":"https://api.github.com/repos/dneg/openvdb_points_dev/milestones{/number}","notifications_url":"https://api.github.com/repos/dneg/openvdb_points_dev/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dneg/openvdb_points_dev/labels{/name}","releases_url":"https://api.github.com/repos/dneg/openvdb_points_dev/releases{/id}","deployments_url":"https://api.github.com/repos/dneg/openvdb_points_dev/deployments","created_at":"2015-05-14T15:38:43Z","updated_at":"2016-08-01T05:02:53Z","pushed_at":"2016-08-10T23:06:01Z","git_url":"git://github.com/dneg/openvdb_points_dev.git","ssh_url":"git@github.com:dneg/openvdb_points_dev.git","clone_url":"https://github.com/dneg/openvdb_points_dev.git","svn_url":"https://github.com/dneg/openvdb_points_dev","homepage":"","size":1784,"stargazers_count":34,"watchers_count":34,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":15,"mirror_url":null,"open_issues_count":2,"forks":15,"open_issues":2,"watchers":34,"default_branch":"master"}},"base":{"label":"dneg:master","ref":"master","sha":"6eab550a1f81b303e2709caefa1e61ea6fba76a7","user":{"login":"dneg","id":5524887,"avatar_url":"https://avatars.githubusercontent.com/u/5524887?v=3","gravatar_id":"","url":"https://api.github.com/users/dneg","html_url":"https://github.com/dneg","followers_url":"https://api.github.com/users/dneg/followers","following_url":"https://api.github.com/users/dneg/following{/other_user}","gists_url":"https://api.github.com/users/dneg/gists{/gist_id}","starred_url":"https://api.github.com/users/dneg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dneg/subscriptions","organizations_url":"https://api.github.com/users/dneg/orgs","repos_url":"https://api.github.com/users/dneg/repos","events_url":"https://api.github.com/users/dneg/events{/privacy}","received_events_url":"https://api.github.com/users/dneg/received_events","type":"Organization","site_admin":false},"repo":{"id":35619792,"name":"openvdb_points_dev","full_name":"dneg/openvdb_points_dev","owner":{"login":"dneg","id":5524887,"avatar_url":"https://avatars.githubusercontent.com/u/5524887?v=3","gravatar_id":"","url":"https://api.github.com/users/dneg","html_url":"https://github.com/dneg","followers_url":"https://api.github.com/users/dneg/followers","following_url":"https://api.github.com/users/dneg/following{/other_user}","gists_url":"https://api.github.com/users/dneg/gists{/gist_id}","starred_url":"https://api.github.com/users/dneg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dneg/subscriptions","organizations_url":"https://api.github.com/users/dneg/orgs","repos_url":"https://api.github.com/users/dneg/repos","events_url":"https://api.github.com/users/dneg/events{/privacy}","received_events_url":"https://api.github.com/users/dneg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dneg/openvdb_points_dev","description":"OpenVDB Points Development Repository","fork":false,"url":"https://api.github.com/repos/dneg/openvdb_points_dev","forks_url":"https://api.github.com/repos/dneg/openvdb_points_dev/forks","keys_url":"https://api.github.com/repos/dneg/openvdb_points_dev/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dneg/openvdb_points_dev/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dneg/openvdb_points_dev/teams","hooks_url":"https://api.github.com/repos/dneg/openvdb_points_dev/hooks","issue_events_url":"https://api.github.com/repos/dneg/openvdb_points_dev/issues/events{/number}","events_url":"https://api.github.com/repos/dneg/openvdb_points_dev/events","assignees_url":"https://api.github.com/repos/dneg/openvdb_points_dev/assignees{/user}","branches_url":"https://api.github.com/repos/dneg/openvdb_points_dev/branches{/branch}","tags_url":"https://api.github.com/repos/dneg/openvdb_points_dev/tags","blobs_url":"https://api.github.com/repos/dneg/openvdb_points_dev/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dneg/openvdb_points_dev/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dneg/openvdb_points_dev/git/refs{/sha}","trees_url":"https://api.github.com/repos/dneg/openvdb_points_dev/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dneg/openvdb_points_dev/statuses/{sha}","languages_url":"https://api.github.com/repos/dneg/openvdb_points_dev/languages","stargazers_url":"https://api.github.com/repos/dneg/openvdb_points_dev/stargazers","contributors_url":"https://api.github.com/repos/dneg/openvdb_points_dev/contributors","subscribers_url":"https://api.github.com/repos/dneg/openvdb_points_dev/subscribers","subscription_url":"https://api.github.com/repos/dneg/openvdb_points_dev/subscription","commits_url":"https://api.github.com/repos/dneg/openvdb_points_dev/commits{/sha}","git_commits_url":"https://api.github.com/repos/dneg/openvdb_points_dev/git/commits{/sha}","comments_url":"https://api.github.com/repos/dneg/openvdb_points_dev/comments{/number}","issue_comment_url":"https://api.github.com/repos/dneg/openvdb_points_dev/issues/comments{/number}","contents_url":"https://api.github.com/repos/dneg/openvdb_points_dev/contents/{+path}","compare_url":"https://api.github.com/repos/dneg/openvdb_points_dev/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dneg/openvdb_points_dev/merges","archive_url":"https://api.github.com/repos/dneg/openvdb_points_dev/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dneg/openvdb_points_dev/downloads","issues_url":"https://api.github.com/repos/dneg/openvdb_points_dev/issues{/number}","pulls_url":"https://api.github.com/repos/dneg/openvdb_points_dev/pulls{/number}","milestones_url":"https://api.github.com/repos/dneg/openvdb_points_dev/milestones{/number}","notifications_url":"https://api.github.com/repos/dneg/openvdb_points_dev/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dneg/openvdb_points_dev/labels{/name}","releases_url":"https://api.github.com/repos/dneg/openvdb_points_dev/releases{/id}","deployments_url":"https://api.github.com/repos/dneg/openvdb_points_dev/deployments","created_at":"2015-05-14T15:38:43Z","updated_at":"2016-08-01T05:02:53Z","pushed_at":"2016-08-10T23:06:01Z","git_url":"git://github.com/dneg/openvdb_points_dev.git","ssh_url":"git@github.com:dneg/openvdb_points_dev.git","clone_url":"https://github.com/dneg/openvdb_points_dev.git","svn_url":"https://github.com/dneg/openvdb_points_dev","homepage":"","size":1784,"stargazers_count":34,"watchers_count":34,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":15,"mirror_url":null,"open_issues_count":2,"forks":15,"open_issues":2,"watchers":34,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dneg/openvdb_points_dev/pulls/47"},"html":{"href":"https://github.com/dneg/openvdb_points_dev/pull/47"},"issue":{"href":"https://api.github.com/repos/dneg/openvdb_points_dev/issues/47"},"comments":{"href":"https://api.github.com/repos/dneg/openvdb_points_dev/issues/47/comments"},"review_comments":{"href":"https://api.github.com/repos/dneg/openvdb_points_dev/pulls/47/comments"},"review_comment":{"href":"https://api.github.com/repos/dneg/openvdb_points_dev/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dneg/openvdb_points_dev/pulls/47/commits"},"statuses":{"href":"https://api.github.com/repos/dneg/openvdb_points_dev/statuses/a72f5619b9ff61b1bfd2f992b567d769bdd693b0"}}}}
{"actor":{"display_login":"danrbailey"}}