{"action":"created","comment":{"url":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/comments/71689999","id":71689999,"diff_hunk":"@@ -62,11 +62,20 @@ internal final class _NSCFConstantString : _NSCFString {\n         let ptr = unsafeAddress(of: self) + sizeof(OpaquePointer.self) + sizeof(Int32.self) + sizeof(Int32.self) + sizeof(_CFInfo.self)\n         return UnsafePointer<UnsafePointer<UInt8>>(ptr).pointee\n     }\n+\n+#if arch(s390x)\n+    internal var _length : UInt64 {\n+        let offset = sizeof(OpaquePointer.self) + sizeof(Int32.self) + sizeof(Int32.self) + sizeof(_CFInfo.self) + sizeof(UnsafePointer<UInt8>.self)\n+        let ptr = unsafeAddress(of: self) + offset\n+        return UnsafePointer<UInt64>(ptr).pointee\n+    }\n+#else\n     internal var _length : UInt32 {\n         let offset = sizeof(OpaquePointer.self) + sizeof(Int32.self) + sizeof(Int32.self) + sizeof(_CFInfo.self) + sizeof(UnsafePointer<UInt8>.self)\n         let ptr = unsafeAddress(of: self) + offset\n         return UnsafePointer<UInt32>(ptr).pointee","path":"Foundation/NSCFString.swift","position":15,"original_position":15,"commit_id":"3eb8c79f4f007ff371998e2b1c2f2bb99188c986","original_commit_id":"3eb8c79f4f007ff371998e2b1c2f2bb99188c986","user":{"login":"garyliu1","id":8801690,"avatar_url":"https://avatars.githubusercontent.com/u/8801690?v=3","gravatar_id":"","url":"https://api.github.com/users/garyliu1","html_url":"https://github.com/garyliu1","followers_url":"https://api.github.com/users/garyliu1/followers","following_url":"https://api.github.com/users/garyliu1/following{/other_user}","gists_url":"https://api.github.com/users/garyliu1/gists{/gist_id}","starred_url":"https://api.github.com/users/garyliu1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garyliu1/subscriptions","organizations_url":"https://api.github.com/users/garyliu1/orgs","repos_url":"https://api.github.com/users/garyliu1/repos","events_url":"https://api.github.com/users/garyliu1/events{/privacy}","received_events_url":"https://api.github.com/users/garyliu1/received_events","type":"User","site_admin":false},"body":"Thanks for the comment @parkera, how about something like this instead?\r\n```\r\n    private var _lenPtr : UnsafePointer<Void> {\r\n        let offset = sizeof(OpaquePointer.self) + sizeof(Int32.self) + sizeof(Int32.self) + sizeof(_CFInfo.self) + sizeof(UnsafePointer<UInt8>.self)\r\n        return unsafeAddress(of: self) + offset\r\n    }\r\n\r\n#if arch(s390x)\r\n    internal var _length : UInt64 {\r\n        return UnsafePointer<UInt64>(_lenPtr).pointee\r\n    }\r\n#else\r\n    internal var _length : UInt32 {\r\n        return UnsafePointer<UInt32>(_lenPtr).pointee\r\n    }\r\n#endif\r\n```\r\n","created_at":"2016-07-21T11:39:56Z","updated_at":"2016-07-21T11:39:56Z","html_url":"https://github.com/apple/swift-corelibs-foundation/pull/457#discussion_r71689999","pull_request_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/457","_links":{"self":{"href":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/comments/71689999"},"html":{"href":"https://github.com/apple/swift-corelibs-foundation/pull/457#discussion_r71689999"},"pull_request":{"href":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/457"}}},"pull_request":{"url":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/457","id":78168432,"html_url":"https://github.com/apple/swift-corelibs-foundation/pull/457","diff_url":"https://github.com/apple/swift-corelibs-foundation/pull/457.diff","patch_url":"https://github.com/apple/swift-corelibs-foundation/pull/457.patch","issue_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/issues/457","number":457,"state":"open","locked":false,"title":"Fix _length access on CF_CONST_STRING for s390x","user":{"login":"garyliu1","id":8801690,"avatar_url":"https://avatars.githubusercontent.com/u/8801690?v=3","gravatar_id":"","url":"https://api.github.com/users/garyliu1","html_url":"https://github.com/garyliu1","followers_url":"https://api.github.com/users/garyliu1/followers","following_url":"https://api.github.com/users/garyliu1/following{/other_user}","gists_url":"https://api.github.com/users/garyliu1/gists{/gist_id}","starred_url":"https://api.github.com/users/garyliu1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garyliu1/subscriptions","organizations_url":"https://api.github.com/users/garyliu1/orgs","repos_url":"https://api.github.com/users/garyliu1/repos","events_url":"https://api.github.com/users/garyliu1/events{/privacy}","received_events_url":"https://api.github.com/users/garyliu1/received_events","type":"User","site_admin":false},"body":"Previous s390x PR #386 has a change to make the `_length` field of `CF_CONST_STRING` to `uint64_t`.  This requires a subsequent change to access the field correctly in `_NSCFConstantString`.\r\n\r\nThis change has been tested and verified to have no regression on x86-64.  On s390x, we see a good pass rate jump including TestNSURL, TestNSCalendar and TestNSNotificationQueue","created_at":"2016-07-20T15:30:26Z","updated_at":"2016-07-21T11:39:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"93416e5105157f933604432ff52a0ef9429824ab","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/457/commits","review_comments_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/457/comments","review_comment_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/issues/457/comments","statuses_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/statuses/3eb8c79f4f007ff371998e2b1c2f2bb99188c986","head":{"label":"linux-on-ibm-z:master-s390x","ref":"master-s390x","sha":"3eb8c79f4f007ff371998e2b1c2f2bb99188c986","user":{"login":"linux-on-ibm-z","id":11740175,"avatar_url":"https://avatars.githubusercontent.com/u/11740175?v=3","gravatar_id":"","url":"https://api.github.com/users/linux-on-ibm-z","html_url":"https://github.com/linux-on-ibm-z","followers_url":"https://api.github.com/users/linux-on-ibm-z/followers","following_url":"https://api.github.com/users/linux-on-ibm-z/following{/other_user}","gists_url":"https://api.github.com/users/linux-on-ibm-z/gists{/gist_id}","starred_url":"https://api.github.com/users/linux-on-ibm-z/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linux-on-ibm-z/subscriptions","organizations_url":"https://api.github.com/users/linux-on-ibm-z/orgs","repos_url":"https://api.github.com/users/linux-on-ibm-z/repos","events_url":"https://api.github.com/users/linux-on-ibm-z/events{/privacy}","received_events_url":"https://api.github.com/users/linux-on-ibm-z/received_events","type":"Organization","site_admin":false},"repo":{"id":59230829,"name":"swift-corelibs-foundation","full_name":"linux-on-ibm-z/swift-corelibs-foundation","owner":{"login":"linux-on-ibm-z","id":11740175,"avatar_url":"https://avatars.githubusercontent.com/u/11740175?v=3","gravatar_id":"","url":"https://api.github.com/users/linux-on-ibm-z","html_url":"https://github.com/linux-on-ibm-z","followers_url":"https://api.github.com/users/linux-on-ibm-z/followers","following_url":"https://api.github.com/users/linux-on-ibm-z/following{/other_user}","gists_url":"https://api.github.com/users/linux-on-ibm-z/gists{/gist_id}","starred_url":"https://api.github.com/users/linux-on-ibm-z/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linux-on-ibm-z/subscriptions","organizations_url":"https://api.github.com/users/linux-on-ibm-z/orgs","repos_url":"https://api.github.com/users/linux-on-ibm-z/repos","events_url":"https://api.github.com/users/linux-on-ibm-z/events{/privacy}","received_events_url":"https://api.github.com/users/linux-on-ibm-z/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/linux-on-ibm-z/swift-corelibs-foundation","description":"The Foundation Project, providing core utilities, internationalization, and OS independence","fork":true,"url":"https://api.github.com/repos/linux-on-ibm-z/swift-corelibs-foundation","forks_url":"https://api.github.com/repos/linux-on-ibm-z/swift-corelibs-foundation/forks","keys_url":"https://api.github.com/repos/linux-on-ibm-z/swift-corelibs-foundation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linux-on-ibm-z/swift-corelibs-foundation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linux-on-ibm-z/swift-corelibs-foundation/teams","hooks_url":"https://api.github.com/repos/linux-on-ibm-z/swift-corelibs-foundation/hooks","issue_events_url":"https://api.github.com/repos/linux-on-ibm-z/swift-corelibs-foundation/issues/events{/number}","events_url":"https://api.github.com/repos/linux-on-ibm-z/swift-corelibs-foundation/events","assignees_url":"https://api.github.com/repos/linux-on-ibm-z/swift-corelibs-foundation/assignees{/user}","branches_url":"https://api.github.com/repos/linux-on-ibm-z/swift-corelibs-foundation/branches{/branch}","tags_url":"https://api.github.com/repos/linux-on-ibm-z/swift-corelibs-foundation/tags","blobs_url":"https://api.github.com/repos/linux-on-ibm-z/swift-corelibs-foundation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linux-on-ibm-z/swift-corelibs-foundation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linux-on-ibm-z/swift-corelibs-foundation/git/refs{/sha}","trees_url":"https://api.github.com/repos/linux-on-ibm-z/swift-corelibs-foundation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linux-on-ibm-z/swift-corelibs-foundation/statuses/{sha}","languages_url":"https://api.github.com/repos/linux-on-ibm-z/swift-corelibs-foundation/languages","stargazers_url":"https://api.github.com/repos/linux-on-ibm-z/swift-corelibs-foundation/stargazers","contributors_url":"https://api.github.com/repos/linux-on-ibm-z/swift-corelibs-foundation/contributors","subscribers_url":"https://api.github.com/repos/linux-on-ibm-z/swift-corelibs-foundation/subscribers","subscription_url":"https://api.github.com/repos/linux-on-ibm-z/swift-corelibs-foundation/subscription","commits_url":"https://api.github.com/repos/linux-on-ibm-z/swift-corelibs-foundation/commits{/sha}","git_commits_url":"https://api.github.com/repos/linux-on-ibm-z/swift-corelibs-foundation/git/commits{/sha}","comments_url":"https://api.github.com/repos/linux-on-ibm-z/swift-corelibs-foundation/comments{/number}","issue_comment_url":"https://api.github.com/repos/linux-on-ibm-z/swift-corelibs-foundation/issues/comments{/number}","contents_url":"https://api.github.com/repos/linux-on-ibm-z/swift-corelibs-foundation/contents/{+path}","compare_url":"https://api.github.com/repos/linux-on-ibm-z/swift-corelibs-foundation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linux-on-ibm-z/swift-corelibs-foundation/merges","archive_url":"https://api.github.com/repos/linux-on-ibm-z/swift-corelibs-foundation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linux-on-ibm-z/swift-corelibs-foundation/downloads","issues_url":"https://api.github.com/repos/linux-on-ibm-z/swift-corelibs-foundation/issues{/number}","pulls_url":"https://api.github.com/repos/linux-on-ibm-z/swift-corelibs-foundation/pulls{/number}","milestones_url":"https://api.github.com/repos/linux-on-ibm-z/swift-corelibs-foundation/milestones{/number}","notifications_url":"https://api.github.com/repos/linux-on-ibm-z/swift-corelibs-foundation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linux-on-ibm-z/swift-corelibs-foundation/labels{/name}","releases_url":"https://api.github.com/repos/linux-on-ibm-z/swift-corelibs-foundation/releases{/id}","deployments_url":"https://api.github.com/repos/linux-on-ibm-z/swift-corelibs-foundation/deployments","created_at":"2016-05-19T18:14:32Z","updated_at":"2016-05-19T18:14:37Z","pushed_at":"2016-07-20T15:00:57Z","git_url":"git://github.com/linux-on-ibm-z/swift-corelibs-foundation.git","ssh_url":"git@github.com:linux-on-ibm-z/swift-corelibs-foundation.git","clone_url":"https://github.com/linux-on-ibm-z/swift-corelibs-foundation.git","svn_url":"https://github.com/linux-on-ibm-z/swift-corelibs-foundation","homepage":"swift.org","size":5902,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apple:master","ref":"master","sha":"686d9b6db204a330f8bacf792e552dbd2f5f82df","user":{"login":"apple","id":10639145,"avatar_url":"https://avatars.githubusercontent.com/u/10639145?v=3","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":45863890,"name":"swift-corelibs-foundation","full_name":"apple/swift-corelibs-foundation","owner":{"login":"apple","id":10639145,"avatar_url":"https://avatars.githubusercontent.com/u/10639145?v=3","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apple/swift-corelibs-foundation","description":"The Foundation Project, providing core utilities, internationalization, and OS independence","fork":false,"url":"https://api.github.com/repos/apple/swift-corelibs-foundation","forks_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/forks","keys_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/teams","hooks_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/hooks","issue_events_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/events","assignees_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/tags","blobs_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/languages","stargazers_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/stargazers","contributors_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/contributors","subscribers_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/subscribers","subscription_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/subscription","commits_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/merges","archive_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/downloads","issues_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/deployments","created_at":"2015-11-09T20:12:23Z","updated_at":"2016-07-21T09:22:13Z","pushed_at":"2016-07-21T04:37:53Z","git_url":"git://github.com/apple/swift-corelibs-foundation.git","ssh_url":"git@github.com:apple/swift-corelibs-foundation.git","clone_url":"https://github.com/apple/swift-corelibs-foundation.git","svn_url":"https://github.com/apple/swift-corelibs-foundation","homepage":"swift.org","size":7074,"stargazers_count":2006,"watchers_count":2006,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":424,"mirror_url":null,"open_issues_count":24,"forks":424,"open_issues":24,"watchers":2006,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/457"},"html":{"href":"https://github.com/apple/swift-corelibs-foundation/pull/457"},"issue":{"href":"https://api.github.com/repos/apple/swift-corelibs-foundation/issues/457"},"comments":{"href":"https://api.github.com/repos/apple/swift-corelibs-foundation/issues/457/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/457/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/457/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift-corelibs-foundation/statuses/3eb8c79f4f007ff371998e2b1c2f2bb99188c986"}}}}
{"actor":{"display_login":"garyliu1"}}