{"action":"created","issue":{"url":"https://api.github.com/repos/uber/tchannel-python/issues/426","repository_url":"https://api.github.com/repos/uber/tchannel-python","labels_url":"https://api.github.com/repos/uber/tchannel-python/issues/426/labels{/name}","comments_url":"https://api.github.com/repos/uber/tchannel-python/issues/426/comments","events_url":"https://api.github.com/repos/uber/tchannel-python/issues/426/events","html_url":"https://github.com/uber/tchannel-python/pull/426","id":169980876,"number":426,"title":"Add crossdock-based integration tests for tracing propagation","user":{"login":"yurishkuro","id":3523016,"avatar_url":"https://avatars.githubusercontent.com/u/3523016?v=3","gravatar_id":"","url":"https://api.github.com/users/yurishkuro","html_url":"https://github.com/yurishkuro","followers_url":"https://api.github.com/users/yurishkuro/followers","following_url":"https://api.github.com/users/yurishkuro/following{/other_user}","gists_url":"https://api.github.com/users/yurishkuro/gists{/gist_id}","starred_url":"https://api.github.com/users/yurishkuro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yurishkuro/subscriptions","organizations_url":"https://api.github.com/users/yurishkuro/orgs","repos_url":"https://api.github.com/users/yurishkuro/repos","events_url":"https://api.github.com/users/yurishkuro/events{/privacy}","received_events_url":"https://api.github.com/users/yurishkuro/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2016-08-08T17:37:53Z","updated_at":"2016-08-10T02:56:16Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/uber/tchannel-python/pulls/426","html_url":"https://github.com/uber/tchannel-python/pull/426","diff_url":"https://github.com/uber/tchannel-python/pull/426.diff","patch_url":"https://github.com/uber/tchannel-python/pull/426.patch"},"body":"There is a unit test that exercises Python-only permutations. The actual crossdock tests are not yet running as part of the CI, because I would like to do that in separate PRs.  Here's a small snippet of the results of running locally (with the corresponding Go PR https://github.com/uber/tchannel-go/pull/467)\r\n\r\n```\r\n✓ [trace] go→ (s1name=go s2encoding=json s2name=python s3encoding=thrift s3name=python sampled=true) (11/11 passed, 0/11 skipped)\r\n   ├ ✓ ⇒ Trace ID should not be empty in S1(go)\r\n   ├ ✓ ⇒ Trace ID must match in S1(go)\r\n   ├ ✓ ⇒ Baggage must match in S1(go)\r\n   ├ ✓ ⇒ Sampled must match in S1(go)\r\n   ├ ✓ ⇒ Trace ID must match in S2(python:8081)\r\n   ├ ✓ ⇒ Baggage must match in S2(python:8081)\r\n   ├ ✓ ⇒ Sampled must match in S2(python:8081)\r\n   ├ ✓ ⇒ Trace ID must match in S3(python:8081)\r\n   ├ ✓ ⇒ Baggage must match in S3(python:8081)\r\n   ├ ✓ ⇒ Sampled must match in S3(python:8081)\r\n   └ ✓ ⇒ trace checks out\r\n✓ [trace] go→ (s1name=go s2encoding=thrift s2name=python s3encoding=thrift s3name=python sampled=true) (11/11 passed, 0/11 skipped)\r\n   ├ ✓ ⇒ Trace ID should not be empty in S1(go)\r\n   ├ ✓ ⇒ Trace ID must match in S1(go)\r\n   ├ ✓ ⇒ Baggage must match in S1(go)\r\n   ├ ✓ ⇒ Sampled must match in S1(go)\r\n   ├ ✓ ⇒ Trace ID must match in S2(python:8081)\r\n   ├ ✓ ⇒ Baggage must match in S2(python:8081)\r\n   ├ ✓ ⇒ Sampled must match in S2(python:8081)\r\n   ├ ✓ ⇒ Trace ID must match in S3(python:8081)\r\n   ├ ✓ ⇒ Baggage must match in S3(python:8081)\r\n   ├ ✓ ⇒ Sampled must match in S3(python:8081)\r\n   └ ✓ ⇒ trace checks out\r\n\r\n352/352 passed (0/352 skipped)\r\n\r\nTests passed!\r\n```\r\n\r\n * [x] HTTP server for health endpoint\r\n * [x] Start tchannel server that serves JSON endpoint\r\n * [x] Write test that hits JSON endpoint\r\n * [x] JSON endpoint must return observed span\r\n * [x] JSON endpoint must call downstream\r\n * [x] Write temp file with simple.thrift and create a service\r\n * [x] Add Thrift endpoint to do the same as JSON endpoint\r\n * [x] Update make file\r\n * [x] Test with Go image\r\n * [x] Docker Hub account\r\n * [ ] Run crossdock test in Travis\r\n * [ ] Pull real Go image\r\n * [ ] Publish Python image\r\n"},"comment":{"url":"https://api.github.com/repos/uber/tchannel-python/issues/comments/238752719","html_url":"https://github.com/uber/tchannel-python/pull/426#issuecomment-238752719","issue_url":"https://api.github.com/repos/uber/tchannel-python/issues/426","id":238752719,"user":{"login":"coveralls","id":2354108,"avatar_url":"https://avatars.githubusercontent.com/u/2354108?v=3","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2016-08-10T02:56:15Z","updated_at":"2016-08-10T02:56:15Z","body":"\n[![Coverage Status](https://coveralls.io/builds/7380100/badge)](https://coveralls.io/builds/7380100)\n\nCoverage decreased (-0.2%) to 93.738% when pulling **b8c5f4fcc0a2161f9a1aa4e2cf6434a779ec2856 on crossdock-for-tracing** into **a03f741bd83967062f489711a2238b97c4f2d468 on master**.\n"}}
{"actor":{"display_login":"coveralls"}}