{"action":"created","issue":{"url":"https://api.github.com/repos/CoolProp/CoolProp/issues/1369","repository_url":"https://api.github.com/repos/CoolProp/CoolProp","labels_url":"https://api.github.com/repos/CoolProp/CoolProp/issues/1369/labels{/name}","comments_url":"https://api.github.com/repos/CoolProp/CoolProp/issues/1369/comments","events_url":"https://api.github.com/repos/CoolProp/CoolProp/issues/1369/events","html_url":"https://github.com/CoolProp/CoolProp/pull/1369","id":193479540,"number":1369,"title":"Return 'n/a'  REFPROP version when not loaded or supported.","user":{"login":"bremme","id":6715707,"avatar_url":"https://avatars.githubusercontent.com/u/6715707?v=3","gravatar_id":"","url":"https://api.github.com/users/bremme","html_url":"https://github.com/bremme","followers_url":"https://api.github.com/users/bremme/followers","following_url":"https://api.github.com/users/bremme/following{/other_user}","gists_url":"https://api.github.com/users/bremme/gists{/gist_id}","starred_url":"https://api.github.com/users/bremme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bremme/subscriptions","organizations_url":"https://api.github.com/users/bremme/orgs","repos_url":"https://api.github.com/users/bremme/repos","events_url":"https://api.github.com/users/bremme/events{/privacy}","received_events_url":"https://api.github.com/users/bremme/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-12-05T12:03:08Z","updated_at":"2016-12-06T09:44:53Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/CoolProp/CoolProp/pulls/1369","html_url":"https://github.com/CoolProp/CoolProp/pull/1369","diff_url":"https://github.com/CoolProp/CoolProp/pull/1369.diff","patch_url":"https://github.com/CoolProp/CoolProp/pull/1369.patch"},"body":"Create a pull request to solve issue #1368. When the `REFPROPMixtureBackend::version()` is called, the method will return `n\\a` when `REFPROPMixtureBackend::REFPROP_supported()` returns `false`. This should prevent the segmentation fault when getting the REFPROP version if REFPROP is not installed. What do you think? Is returning 'n/a' a good solution or do you prefer to raise a ValueError when `SETUPdll == NULL`? My reasoning behind this implementation is that a complete check if REFPROP is supported and safe to load was already implemented in `REFPROP_supported()`, so it would make sense to just trust the value it returns.\r\n\r\nP.S. I noticed that my editor removed some trailing white spaces I hope this is not a problem?"},"comment":{"url":"https://api.github.com/repos/CoolProp/CoolProp/issues/comments/265105543","html_url":"https://github.com/CoolProp/CoolProp/pull/1369#issuecomment-265105543","issue_url":"https://api.github.com/repos/CoolProp/CoolProp/issues/1369","id":265105543,"user":{"login":"bremme","id":6715707,"avatar_url":"https://avatars.githubusercontent.com/u/6715707?v=3","gravatar_id":"","url":"https://api.github.com/users/bremme","html_url":"https://github.com/bremme","followers_url":"https://api.github.com/users/bremme/followers","following_url":"https://api.github.com/users/bremme/following{/other_user}","gists_url":"https://api.github.com/users/bremme/gists{/gist_id}","starred_url":"https://api.github.com/users/bremme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bremme/subscriptions","organizations_url":"https://api.github.com/users/bremme/orgs","repos_url":"https://api.github.com/users/bremme/repos","events_url":"https://api.github.com/users/bremme/events{/privacy}","received_events_url":"https://api.github.com/users/bremme/received_events","type":"User","site_admin":false},"created_at":"2016-12-06T09:44:53Z","updated_at":"2016-12-06T09:44:53Z","body":"No problem, I will do that! I guess I'm just so used to not having trailing white spaces that I didn't even knew my editor removed them by default. I did found the setting that caused is though: \r\n![image](https://cloud.githubusercontent.com/assets/6715707/20920585/dc90059e-bba0-11e6-9197-73c04dec3dba.png)\r\n\r\nWill turn it off and make a new commit, sorry for the hassle. \r\n"}}
{"actor":{"display_login":"bremme"}}