{"action":"created","issue":{"url":"https://api.github.com/repos/xbmc/xbmc/issues/10830","repository_url":"https://api.github.com/repos/xbmc/xbmc","labels_url":"https://api.github.com/repos/xbmc/xbmc/issues/10830/labels{/name}","comments_url":"https://api.github.com/repos/xbmc/xbmc/issues/10830/comments","events_url":"https://api.github.com/repos/xbmc/xbmc/issues/10830/events","html_url":"https://github.com/xbmc/xbmc/pull/10830","id":186313855,"number":10830,"title":"FIX: [rar] deadlock with cbr + net vfs (credit @notspiff)","user":{"login":"koying","id":164740,"avatar_url":"https://avatars.githubusercontent.com/u/164740?v=3","gravatar_id":"","url":"https://api.github.com/users/koying","html_url":"https://github.com/koying","followers_url":"https://api.github.com/users/koying/followers","following_url":"https://api.github.com/users/koying/following{/other_user}","gists_url":"https://api.github.com/users/koying/gists{/gist_id}","starred_url":"https://api.github.com/users/koying/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koying/subscriptions","organizations_url":"https://api.github.com/users/koying/orgs","repos_url":"https://api.github.com/users/koying/repos","events_url":"https://api.github.com/users/koying/events{/privacy}","received_events_url":"https://api.github.com/users/koying/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-10-31T15:29:48Z","updated_at":"2016-10-31T15:30:13Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/10830","html_url":"https://github.com/xbmc/xbmc/pull/10830","diff_url":"https://github.com/xbmc/xbmc/pull/10830.diff","patch_url":"https://github.com/xbmc/xbmc/pull/10830.patch"},"body":"<!--- Provide a general summary of your change in the Title above -->\r\n\r\n## Description\r\n<!--- Describe your change in detail -->\r\nfrom notspiff:\r\n\r\nspecifically we are called off-thread with the main thread waiting on us while holding the gui lock. so it will deadlock on obtaining dialog. the bt was funkily confusing though, as it will actually show a \"downstream\" deadlock on the rar manager, as there's two concurrent calls to it (to preload/load images). the deadlock that was triggered in the debugger was the second call to the rar manager spinning on the rar manager lock, which is held by the first call to rar manager, which again is spinning on the gui lock.\r\n\r\noh, and using a \"exotic\" vfs was only part of the problem to the extent that it's slower so the timeout on the progress dialog kicked in.\r\n## Motivation and Context\r\n<!--- Why is this change required? What problem does it solve? -->\r\n<!--- If it fixes an open issue, please link to the issue here -->\r\n\r\n## How Has This Been Tested?\r\n<!--- Please describe in detail how you tested your change -->\r\n<!--- Include details of your testing environment, and the tests you ran to -->\r\n<!--- see how your change affects other areas of the code, etc -->\r\n\r\n## Screenshots (if appropriate):\r\n\r\n## Types of change\r\n<!--- What type of change does your code introduce? Put an `x` in all the boxes that apply like this: [X] -->\r\n- [X] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply like this: [X] -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [ ] My code follows the [Code guidelines](https://codedocs.xyz/xbmc/xbmc/code_guidelines.html) of this project \r\n- [ ] My change requires a change to the documentation, either Doxygen or wiki\r\n- [ ] I have updated the documentation accordingly\r\n- [ ] I have read the [CONTRIBUTING](https://github.com/xbmc/xbmc/blob/master/CONTRIBUTING.md) document\r\n- [ ] I have added tests to cover my change\r\n- [ ] All new and existing tests passed\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/xbmc/xbmc/issues/comments/257325913","html_url":"https://github.com/xbmc/xbmc/pull/10830#issuecomment-257325913","issue_url":"https://api.github.com/repos/xbmc/xbmc/issues/10830","id":257325913,"user":{"login":"koying","id":164740,"avatar_url":"https://avatars.githubusercontent.com/u/164740?v=3","gravatar_id":"","url":"https://api.github.com/users/koying","html_url":"https://github.com/koying","followers_url":"https://api.github.com/users/koying/followers","following_url":"https://api.github.com/users/koying/following{/other_user}","gists_url":"https://api.github.com/users/koying/gists{/gist_id}","starred_url":"https://api.github.com/users/koying/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koying/subscriptions","organizations_url":"https://api.github.com/users/koying/orgs","repos_url":"https://api.github.com/users/koying/repos","events_url":"https://api.github.com/users/koying/events{/privacy}","received_events_url":"https://api.github.com/users/koying/received_events","type":"User","site_admin":false},"created_at":"2016-10-31T15:30:13Z","updated_at":"2016-10-31T15:30:13Z","body":"jenkins build this please"}}
{"actor":{"display_login":"koying"}}