{"action":"created","issue":{"url":"https://api.github.com/repos/tdunning/log-synth/issues/27","repository_url":"https://api.github.com/repos/tdunning/log-synth","labels_url":"https://api.github.com/repos/tdunning/log-synth/issues/27/labels{/name}","comments_url":"https://api.github.com/repos/tdunning/log-synth/issues/27/comments","events_url":"https://api.github.com/repos/tdunning/log-synth/issues/27/events","html_url":"https://github.com/tdunning/log-synth/pull/27","id":186379590,"number":27,"title":"update ArrivalSampler to optionally create events with millis ","user":{"login":"vicenteg","id":1098760,"avatar_url":"https://avatars.githubusercontent.com/u/1098760?v=3","gravatar_id":"","url":"https://api.github.com/users/vicenteg","html_url":"https://github.com/vicenteg","followers_url":"https://api.github.com/users/vicenteg/followers","following_url":"https://api.github.com/users/vicenteg/following{/other_user}","gists_url":"https://api.github.com/users/vicenteg/gists{/gist_id}","starred_url":"https://api.github.com/users/vicenteg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vicenteg/subscriptions","organizations_url":"https://api.github.com/users/vicenteg/orgs","repos_url":"https://api.github.com/users/vicenteg/repos","events_url":"https://api.github.com/users/vicenteg/events{/privacy}","received_events_url":"https://api.github.com/users/vicenteg/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-10-31T19:48:59Z","updated_at":"2016-11-01T13:02:57Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/tdunning/log-synth/pulls/27","html_url":"https://github.com/tdunning/log-synth/pull/27","diff_url":"https://github.com/tdunning/log-synth/pull/27.diff","patch_url":"https://github.com/tdunning/log-synth/pull/27.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/tdunning/log-synth/issues/comments/257560970","html_url":"https://github.com/tdunning/log-synth/pull/27#issuecomment-257560970","issue_url":"https://api.github.com/repos/tdunning/log-synth/issues/27","id":257560970,"user":{"login":"vicenteg","id":1098760,"avatar_url":"https://avatars.githubusercontent.com/u/1098760?v=3","gravatar_id":"","url":"https://api.github.com/users/vicenteg","html_url":"https://github.com/vicenteg","followers_url":"https://api.github.com/users/vicenteg/followers","following_url":"https://api.github.com/users/vicenteg/following{/other_user}","gists_url":"https://api.github.com/users/vicenteg/gists{/gist_id}","starred_url":"https://api.github.com/users/vicenteg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vicenteg/subscriptions","organizations_url":"https://api.github.com/users/vicenteg/orgs","repos_url":"https://api.github.com/users/vicenteg/repos","events_url":"https://api.github.com/users/vicenteg/events{/privacy}","received_events_url":"https://api.github.com/users/vicenteg/received_events","type":"User","site_admin":false},"created_at":"2016-11-01T13:02:56Z","updated_at":"2016-11-01T13:02:56Z","body":"Yes, makes sense - I was struggling with a sensible way to select between\nseconds and milliseconds. I'll give it a shot and send a new PR.\n\nOn Monday, October 31, 2016, Ted Dunning <notifications@github.com> wrote:\n\n> What do you think about adding two new format characters? (q for\n> milliseconds to match String.format and ? something else for seconds)\n> Dealing with these formats would be done with an if much like what you just\n> provided.\n>\n> The rationale is that\n>\n> 1) this is really just a formatting thing any what\n>\n> 2) we need both seconds and milliseconds since epoch.\n>\n>\n>\n> On Mon, Oct 31, 2016 at 12:48 PM, Vince Gonzalez <notifications@github.com\n> <javascript:_e(%7B%7D,'cvml','notifications@github.com');>>\n> wrote:\n>\n> > ------------------------------\n> > You can view, comment on, or merge this pull request online at:\n> >\n> > https://github.com/tdunning/log-synth/pull/27\n> > Commit Summary\n> >\n> > - update ArrivalSampler to optionally create events with millis since\n> > epoch\n> > - remove unused Instant import\n> >\n> > File Changes\n> >\n> > - *M* README.md\n> > <https://github.com/tdunning/log-synth/pull/27/files#diff-0> (4)\n> > - *M* src/main/java/com/mapr/synth/samplers/ArrivalSampler.java\n> > <https://github.com/tdunning/log-synth/pull/27/files#diff-1> (16)\n> >\n> > Patch Links:\n> >\n> > - https://github.com/tdunning/log-synth/pull/27.patch\n> > - https://github.com/tdunning/log-synth/pull/27.diff\n> >\n> > —\n> > You are receiving this because you are subscribed to this thread.\n> > Reply to this email directly, view it on GitHub\n> > <https://github.com/tdunning/log-synth/pull/27>, or mute the thread\n> > <https://github.com/notifications/unsubscribe-auth/\n> AAPSehtWmVaOIvfqlMQvaCUIq8zpzNJAks5q5kYrgaJpZM4KlbXK>\n> > .\n> >\n>\n> —\n> You are receiving this because you authored the thread.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/tdunning/log-synth/pull/27#issuecomment-257449196>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/ABDECM7V7GQW4GZ2B7r8LXICG6Ki_qtSks5q5njFgaJpZM4KlbXK>\n> .\n>\n\n\n--\n"}}
{"actor":{"display_login":"vicenteg"}}