{"action":"created","comment":{"url":"https://api.github.com/repos/hibernate/hibernate-search/pulls/comments/88655248","pull_request_review_id":9223080,"id":88655248,"diff_hunk":"@@ -314,13 +314,8 @@ The default (field) name in case `@Spatial` is placed on the entity level is `or\n [NOTE]\n .Distance projection and null values\n ====\n-Using distance projection on non `@Spatial` enabled entities and/or with a non spatial Query will have\n-unexpected results as entities not spatially indexed and/or having `null` values for latitude or\n-longitude will be considered to be at (0,0)/(lat,0)/(0,long).\n-\n-Using distance projection with a spatial query on spatially indexed entities having, eventually,\n-`null` values for latitude and/or longitude is safe as they will not be found by the spatial query\n-and won't have distance calculated.\n+When a spatial field on an entity has a `null` value for either its latitude or longitude (or both),\n+the resulting projected distance will always be `Double.MAX_VALUE` (`1.7976931348623157e+308`).","path":"documentation/src/main/asciidoc/spatial.asciidoc","position":12,"original_position":12,"commit_id":"0ff9cf275d8bc5bfeda2ae16e090c9109d6c3db0","original_commit_id":"0ff9cf275d8bc5bfeda2ae16e090c9109d6c3db0","user":{"login":"yrodiere","id":412878,"avatar_url":"https://avatars.githubusercontent.com/u/412878?v=3","gravatar_id":"","url":"https://api.github.com/users/yrodiere","html_url":"https://github.com/yrodiere","followers_url":"https://api.github.com/users/yrodiere/followers","following_url":"https://api.github.com/users/yrodiere/following{/other_user}","gists_url":"https://api.github.com/users/yrodiere/gists{/gist_id}","starred_url":"https://api.github.com/users/yrodiere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yrodiere/subscriptions","organizations_url":"https://api.github.com/users/yrodiere/orgs","repos_url":"https://api.github.com/users/yrodiere/repos","events_url":"https://api.github.com/users/yrodiere/events{/privacy}","received_events_url":"https://api.github.com/users/yrodiere/received_events","type":"User","site_admin":false},"body":"Maybe... But we'd have to convert the `Double.MAX_VALUE` returned by Elasticsearch to `null`, in that case. I'll see if it can be done reliably. One thing that bothers me is I'm not sure I will be able to do the same with sorts (consider the value is null), and I'd rather have the projection and sorts be consistent.","created_at":"2016-11-18T13:20:08Z","updated_at":"2016-11-18T13:28:11Z","html_url":"https://github.com/hibernate/hibernate-search/pull/1221#discussion_r88655248","pull_request_url":"https://api.github.com/repos/hibernate/hibernate-search/pulls/1221","_links":{"self":{"href":"https://api.github.com/repos/hibernate/hibernate-search/pulls/comments/88655248"},"html":{"href":"https://github.com/hibernate/hibernate-search/pull/1221#discussion_r88655248"},"pull_request":{"href":"https://api.github.com/repos/hibernate/hibernate-search/pulls/1221"}}},"pull_request":{"url":"https://api.github.com/repos/hibernate/hibernate-search/pulls/1221","id":93978753,"html_url":"https://github.com/hibernate/hibernate-search/pull/1221","diff_url":"https://github.com/hibernate/hibernate-search/pull/1221.diff","patch_url":"https://github.com/hibernate/hibernate-search/pull/1221.patch","issue_url":"https://api.github.com/repos/hibernate/hibernate-search/issues/1221","number":1221,"state":"open","locked":false,"title":"HSEARCH-2324 Use Double.MAX_VALUE as the default distance in spatial queries","user":{"login":"yrodiere","id":412878,"avatar_url":"https://avatars.githubusercontent.com/u/412878?v=3","gravatar_id":"","url":"https://api.github.com/users/yrodiere","html_url":"https://github.com/yrodiere","followers_url":"https://api.github.com/users/yrodiere/followers","following_url":"https://api.github.com/users/yrodiere/following{/other_user}","gists_url":"https://api.github.com/users/yrodiere/gists{/gist_id}","starred_url":"https://api.github.com/users/yrodiere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yrodiere/subscriptions","organizations_url":"https://api.github.com/users/yrodiere/orgs","repos_url":"https://api.github.com/users/yrodiere/repos","events_url":"https://api.github.com/users/yrodiere/events{/privacy}","received_events_url":"https://api.github.com/users/yrodiere/received_events","type":"User","site_admin":false},"body":"…  (when missing the latitude and/or longitude)\r\n\r\nhttps://hibernate.atlassian.net/browse/HSEARCH-2324\r\n\r\nThe issue was that distance computation worked differently with our custom spatial layer on Lucene than with Elasticsearch. It was solved by aligning our spatial layer on Elasticsearch's behavior, which seems more sensible. That required to detect missing longitudes/latitudes, which were previously silently replaced by `0`.\r\n\r\nI also replaced some sentences in the docs: I had to re-read that several time before I understood it was about the behavior when doing distance projection or distance sort on non-spatial fields. Which essentially won't work. Which isn't surprising, so is it really worth mentioning... ?","created_at":"2016-11-16T14:44:23Z","updated_at":"2016-11-18T13:28:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4713411deb5585049e8e0a5f036d8964ba129cbb","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/hibernate/hibernate-search/pulls/1221/commits","review_comments_url":"https://api.github.com/repos/hibernate/hibernate-search/pulls/1221/comments","review_comment_url":"https://api.github.com/repos/hibernate/hibernate-search/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hibernate/hibernate-search/issues/1221/comments","statuses_url":"https://api.github.com/repos/hibernate/hibernate-search/statuses/0ff9cf275d8bc5bfeda2ae16e090c9109d6c3db0","head":{"label":"yrodiere:HSEARCH-2324","ref":"HSEARCH-2324","sha":"0ff9cf275d8bc5bfeda2ae16e090c9109d6c3db0","user":{"login":"yrodiere","id":412878,"avatar_url":"https://avatars.githubusercontent.com/u/412878?v=3","gravatar_id":"","url":"https://api.github.com/users/yrodiere","html_url":"https://github.com/yrodiere","followers_url":"https://api.github.com/users/yrodiere/followers","following_url":"https://api.github.com/users/yrodiere/following{/other_user}","gists_url":"https://api.github.com/users/yrodiere/gists{/gist_id}","starred_url":"https://api.github.com/users/yrodiere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yrodiere/subscriptions","organizations_url":"https://api.github.com/users/yrodiere/orgs","repos_url":"https://api.github.com/users/yrodiere/repos","events_url":"https://api.github.com/users/yrodiere/events{/privacy}","received_events_url":"https://api.github.com/users/yrodiere/received_events","type":"User","site_admin":false},"repo":{"id":56803577,"name":"hibernate-search","full_name":"yrodiere/hibernate-search","owner":{"login":"yrodiere","id":412878,"avatar_url":"https://avatars.githubusercontent.com/u/412878?v=3","gravatar_id":"","url":"https://api.github.com/users/yrodiere","html_url":"https://github.com/yrodiere","followers_url":"https://api.github.com/users/yrodiere/followers","following_url":"https://api.github.com/users/yrodiere/following{/other_user}","gists_url":"https://api.github.com/users/yrodiere/gists{/gist_id}","starred_url":"https://api.github.com/users/yrodiere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yrodiere/subscriptions","organizations_url":"https://api.github.com/users/yrodiere/orgs","repos_url":"https://api.github.com/users/yrodiere/repos","events_url":"https://api.github.com/users/yrodiere/events{/privacy}","received_events_url":"https://api.github.com/users/yrodiere/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yrodiere/hibernate-search","description":"Hibernate Search: full-text search for domain model","fork":true,"url":"https://api.github.com/repos/yrodiere/hibernate-search","forks_url":"https://api.github.com/repos/yrodiere/hibernate-search/forks","keys_url":"https://api.github.com/repos/yrodiere/hibernate-search/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yrodiere/hibernate-search/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yrodiere/hibernate-search/teams","hooks_url":"https://api.github.com/repos/yrodiere/hibernate-search/hooks","issue_events_url":"https://api.github.com/repos/yrodiere/hibernate-search/issues/events{/number}","events_url":"https://api.github.com/repos/yrodiere/hibernate-search/events","assignees_url":"https://api.github.com/repos/yrodiere/hibernate-search/assignees{/user}","branches_url":"https://api.github.com/repos/yrodiere/hibernate-search/branches{/branch}","tags_url":"https://api.github.com/repos/yrodiere/hibernate-search/tags","blobs_url":"https://api.github.com/repos/yrodiere/hibernate-search/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yrodiere/hibernate-search/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yrodiere/hibernate-search/git/refs{/sha}","trees_url":"https://api.github.com/repos/yrodiere/hibernate-search/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yrodiere/hibernate-search/statuses/{sha}","languages_url":"https://api.github.com/repos/yrodiere/hibernate-search/languages","stargazers_url":"https://api.github.com/repos/yrodiere/hibernate-search/stargazers","contributors_url":"https://api.github.com/repos/yrodiere/hibernate-search/contributors","subscribers_url":"https://api.github.com/repos/yrodiere/hibernate-search/subscribers","subscription_url":"https://api.github.com/repos/yrodiere/hibernate-search/subscription","commits_url":"https://api.github.com/repos/yrodiere/hibernate-search/commits{/sha}","git_commits_url":"https://api.github.com/repos/yrodiere/hibernate-search/git/commits{/sha}","comments_url":"https://api.github.com/repos/yrodiere/hibernate-search/comments{/number}","issue_comment_url":"https://api.github.com/repos/yrodiere/hibernate-search/issues/comments{/number}","contents_url":"https://api.github.com/repos/yrodiere/hibernate-search/contents/{+path}","compare_url":"https://api.github.com/repos/yrodiere/hibernate-search/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yrodiere/hibernate-search/merges","archive_url":"https://api.github.com/repos/yrodiere/hibernate-search/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yrodiere/hibernate-search/downloads","issues_url":"https://api.github.com/repos/yrodiere/hibernate-search/issues{/number}","pulls_url":"https://api.github.com/repos/yrodiere/hibernate-search/pulls{/number}","milestones_url":"https://api.github.com/repos/yrodiere/hibernate-search/milestones{/number}","notifications_url":"https://api.github.com/repos/yrodiere/hibernate-search/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yrodiere/hibernate-search/labels{/name}","releases_url":"https://api.github.com/repos/yrodiere/hibernate-search/releases{/id}","deployments_url":"https://api.github.com/repos/yrodiere/hibernate-search/deployments","created_at":"2016-04-21T20:27:30Z","updated_at":"2016-04-21T20:27:35Z","pushed_at":"2016-11-18T13:05:11Z","git_url":"git://github.com/yrodiere/hibernate-search.git","ssh_url":"git@github.com:yrodiere/hibernate-search.git","clone_url":"https://github.com/yrodiere/hibernate-search.git","svn_url":"https://github.com/yrodiere/hibernate-search","homepage":"http://search.hibernate.org","size":46615,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hibernate:master","ref":"master","sha":"4f1d9392d303facc391e136f446138a29d5864d2","user":{"login":"hibernate","id":348262,"avatar_url":"https://avatars.githubusercontent.com/u/348262?v=3","gravatar_id":"","url":"https://api.github.com/users/hibernate","html_url":"https://github.com/hibernate","followers_url":"https://api.github.com/users/hibernate/followers","following_url":"https://api.github.com/users/hibernate/following{/other_user}","gists_url":"https://api.github.com/users/hibernate/gists{/gist_id}","starred_url":"https://api.github.com/users/hibernate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hibernate/subscriptions","organizations_url":"https://api.github.com/users/hibernate/orgs","repos_url":"https://api.github.com/users/hibernate/repos","events_url":"https://api.github.com/users/hibernate/events{/privacy}","received_events_url":"https://api.github.com/users/hibernate/received_events","type":"Organization","site_admin":false},"repo":{"id":990281,"name":"hibernate-search","full_name":"hibernate/hibernate-search","owner":{"login":"hibernate","id":348262,"avatar_url":"https://avatars.githubusercontent.com/u/348262?v=3","gravatar_id":"","url":"https://api.github.com/users/hibernate","html_url":"https://github.com/hibernate","followers_url":"https://api.github.com/users/hibernate/followers","following_url":"https://api.github.com/users/hibernate/following{/other_user}","gists_url":"https://api.github.com/users/hibernate/gists{/gist_id}","starred_url":"https://api.github.com/users/hibernate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hibernate/subscriptions","organizations_url":"https://api.github.com/users/hibernate/orgs","repos_url":"https://api.github.com/users/hibernate/repos","events_url":"https://api.github.com/users/hibernate/events{/privacy}","received_events_url":"https://api.github.com/users/hibernate/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hibernate/hibernate-search","description":"Hibernate Search: full-text search for domain model","fork":false,"url":"https://api.github.com/repos/hibernate/hibernate-search","forks_url":"https://api.github.com/repos/hibernate/hibernate-search/forks","keys_url":"https://api.github.com/repos/hibernate/hibernate-search/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hibernate/hibernate-search/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hibernate/hibernate-search/teams","hooks_url":"https://api.github.com/repos/hibernate/hibernate-search/hooks","issue_events_url":"https://api.github.com/repos/hibernate/hibernate-search/issues/events{/number}","events_url":"https://api.github.com/repos/hibernate/hibernate-search/events","assignees_url":"https://api.github.com/repos/hibernate/hibernate-search/assignees{/user}","branches_url":"https://api.github.com/repos/hibernate/hibernate-search/branches{/branch}","tags_url":"https://api.github.com/repos/hibernate/hibernate-search/tags","blobs_url":"https://api.github.com/repos/hibernate/hibernate-search/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hibernate/hibernate-search/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hibernate/hibernate-search/git/refs{/sha}","trees_url":"https://api.github.com/repos/hibernate/hibernate-search/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hibernate/hibernate-search/statuses/{sha}","languages_url":"https://api.github.com/repos/hibernate/hibernate-search/languages","stargazers_url":"https://api.github.com/repos/hibernate/hibernate-search/stargazers","contributors_url":"https://api.github.com/repos/hibernate/hibernate-search/contributors","subscribers_url":"https://api.github.com/repos/hibernate/hibernate-search/subscribers","subscription_url":"https://api.github.com/repos/hibernate/hibernate-search/subscription","commits_url":"https://api.github.com/repos/hibernate/hibernate-search/commits{/sha}","git_commits_url":"https://api.github.com/repos/hibernate/hibernate-search/git/commits{/sha}","comments_url":"https://api.github.com/repos/hibernate/hibernate-search/comments{/number}","issue_comment_url":"https://api.github.com/repos/hibernate/hibernate-search/issues/comments{/number}","contents_url":"https://api.github.com/repos/hibernate/hibernate-search/contents/{+path}","compare_url":"https://api.github.com/repos/hibernate/hibernate-search/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hibernate/hibernate-search/merges","archive_url":"https://api.github.com/repos/hibernate/hibernate-search/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hibernate/hibernate-search/downloads","issues_url":"https://api.github.com/repos/hibernate/hibernate-search/issues{/number}","pulls_url":"https://api.github.com/repos/hibernate/hibernate-search/pulls{/number}","milestones_url":"https://api.github.com/repos/hibernate/hibernate-search/milestones{/number}","notifications_url":"https://api.github.com/repos/hibernate/hibernate-search/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hibernate/hibernate-search/labels{/name}","releases_url":"https://api.github.com/repos/hibernate/hibernate-search/releases{/id}","deployments_url":"https://api.github.com/repos/hibernate/hibernate-search/deployments","created_at":"2010-10-15T15:55:09Z","updated_at":"2016-11-17T14:39:20Z","pushed_at":"2016-11-17T16:57:07Z","git_url":"git://github.com/hibernate/hibernate-search.git","ssh_url":"git@github.com:hibernate/hibernate-search.git","clone_url":"https://github.com/hibernate/hibernate-search.git","svn_url":"https://github.com/hibernate/hibernate-search","homepage":"http://search.hibernate.org","size":56094,"stargazers_count":197,"watchers_count":197,"language":"Java","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":144,"mirror_url":null,"open_issues_count":10,"forks":144,"open_issues":10,"watchers":197,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hibernate/hibernate-search/pulls/1221"},"html":{"href":"https://github.com/hibernate/hibernate-search/pull/1221"},"issue":{"href":"https://api.github.com/repos/hibernate/hibernate-search/issues/1221"},"comments":{"href":"https://api.github.com/repos/hibernate/hibernate-search/issues/1221/comments"},"review_comments":{"href":"https://api.github.com/repos/hibernate/hibernate-search/pulls/1221/comments"},"review_comment":{"href":"https://api.github.com/repos/hibernate/hibernate-search/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hibernate/hibernate-search/pulls/1221/commits"},"statuses":{"href":"https://api.github.com/repos/hibernate/hibernate-search/statuses/0ff9cf275d8bc5bfeda2ae16e090c9109d6c3db0"}}}}
{"actor":{"display_login":"yrodiere"}}