{"action":"created","issue":{"url":"https://api.github.com/repos/svnpenn/mp4v2/issues/147","repository_url":"https://api.github.com/repos/svnpenn/mp4v2","labels_url":"https://api.github.com/repos/svnpenn/mp4v2/issues/147/labels{/name}","comments_url":"https://api.github.com/repos/svnpenn/mp4v2/issues/147/comments","events_url":"https://api.github.com/repos/svnpenn/mp4v2/issues/147/events","html_url":"https://github.com/svnpenn/mp4v2/issues/147","id":145455707,"number":147,"title":"[patch] Workiaround for issue #138 (custom FileProvider not working)","user":{"login":"GoogleCodeExporter","id":9614759,"avatar_url":"https://avatars.githubusercontent.com/u/9614759?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCodeExporter","html_url":"https://github.com/GoogleCodeExporter","followers_url":"https://api.github.com/users/GoogleCodeExporter/followers","following_url":"https://api.github.com/users/GoogleCodeExporter/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCodeExporter/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCodeExporter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCodeExporter/subscriptions","organizations_url":"https://api.github.com/users/GoogleCodeExporter/orgs","repos_url":"https://api.github.com/users/GoogleCodeExporter/repos","events_url":"https://api.github.com/users/GoogleCodeExporter/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCodeExporter/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/svnpenn/mp4v2/labels/auto-migrated","name":"auto-migrated","color":"ededed"},{"url":"https://api.github.com/repos/svnpenn/mp4v2/labels/Priority-Medium","name":"Priority-Medium","color":"ededed"},{"url":"https://api.github.com/repos/svnpenn/mp4v2/labels/Type-Defect","name":"Type-Defect","color":"ededed"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2016-04-03T05:15:56Z","updated_at":"2016-04-13T13:56:39Z","closed_at":"2016-04-13T13:56:39Z","body":"```\nPatch is attached.\nBasically this patch does the following:\n\n1) Modified libplatform::io::File not to call FileSystem::getFileSize() when a \ncustom provider is passed to the constructor. Instead, member variable _size is \nset to SIZE_UNKNOWN (maximum value of 64bit signed integer).\n2) With the above modification, libmp4v2 now tries to read next atom after \nhitting EOF and it fails. This happens inside of ReadChildAtoms() loop for the \nroot atom. Therefore, I modified ReadChildAtoms() not to throw exception in \nthis case, and to gracefully break the loop (and modify m_end variable to the \ncorrect value) instead.\n\nI didn't tested much, but as far as I can see it works, and is not platform \ndependent.\n```\n\nOriginal issue reported on code.google.com by `honeycom...@gmail.com` on 5 Nov 2012 at 5:07\n\nAttachments:\n* [provider.patch](https://storage.googleapis.com/google-code-attachments/mp4v2/issue-147/comment-0/provider.patch)\n"},"comment":{"url":"https://api.github.com/repos/svnpenn/mp4v2/issues/comments/209453727","html_url":"https://github.com/svnpenn/mp4v2/issues/147#issuecomment-209453727","issue_url":"https://api.github.com/repos/svnpenn/mp4v2/issues/147","id":209453727,"user":{"login":"svnpenn","id":926619,"avatar_url":"https://avatars.githubusercontent.com/u/926619?v=3","gravatar_id":"","url":"https://api.github.com/users/svnpenn","html_url":"https://github.com/svnpenn","followers_url":"https://api.github.com/users/svnpenn/followers","following_url":"https://api.github.com/users/svnpenn/following{/other_user}","gists_url":"https://api.github.com/users/svnpenn/gists{/gist_id}","starred_url":"https://api.github.com/users/svnpenn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/svnpenn/subscriptions","organizations_url":"https://api.github.com/users/svnpenn/orgs","repos_url":"https://api.github.com/users/svnpenn/repos","events_url":"https://api.github.com/users/svnpenn/events{/privacy}","received_events_url":"https://api.github.com/users/svnpenn/received_events","type":"User","site_admin":false},"created_at":"2016-04-13T13:56:39Z","updated_at":"2016-04-13T13:56:39Z","body":"I am closing all old issues. If you still need this fixed, add a comment and I will reopen"}}