{"action":"opened","issue":{"url":"https://api.github.com/repos/jingwen-z/bigdata-ucsd/issues/1","repository_url":"https://api.github.com/repos/jingwen-z/bigdata-ucsd","labels_url":"https://api.github.com/repos/jingwen-z/bigdata-ucsd/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/jingwen-z/bigdata-ucsd/issues/1/comments","events_url":"https://api.github.com/repos/jingwen-z/bigdata-ucsd/issues/1/events","html_url":"https://github.com/jingwen-z/bigdata-ucsd/issues/1","id":197973759,"number":1,"title":"prefer using simple quote over double quote ","user":{"login":"mincong-h","id":10179217,"avatar_url":"https://avatars.githubusercontent.com/u/10179217?v=3","gravatar_id":"","url":"https://api.github.com/users/mincong-h","html_url":"https://github.com/mincong-h","followers_url":"https://api.github.com/users/mincong-h/followers","following_url":"https://api.github.com/users/mincong-h/following{/other_user}","gists_url":"https://api.github.com/users/mincong-h/gists{/gist_id}","starred_url":"https://api.github.com/users/mincong-h/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mincong-h/subscriptions","organizations_url":"https://api.github.com/users/mincong-h/orgs","repos_url":"https://api.github.com/users/mincong-h/repos","events_url":"https://api.github.com/users/mincong-h/events{/privacy}","received_events_url":"https://api.github.com/users/mincong-h/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-12-29T08:50:19Z","updated_at":"2016-12-29T08:50:19Z","closed_at":null,"body":"Hi @jingwen-z,\r\n\r\nI saw that you're using both simple quote `'` and double quote `\"` inside your python scripts. Both of the are valid syntax. However, I would prefer using simple quote for all the string expression which gives an unicity of the script.\r\n\r\n### Bad\r\n\r\n```python\r\ndf.describe('rain_accumulation_9am').show()\r\ndf.count() - 1089\r\n...\r\ndf.stat.corr(\"relative_humidity_9am\", \"relative_humidity_3pm\")\r\n```\r\n\r\n### Good\r\n\r\n```python\r\ndf.describe('rain_accumulation_9am').show()\r\ndf.count() - 1089\r\n...\r\ndf.stat.corr('relative_humidity_9am', 'relative_humidity_3pm')\r\n```\r\n\r\nThe only exception will be for documentation string: according to [PEP 257][257], double quote `\"\"\"` is preferred over `'''`.\r\n\r\n[257]: https://www.python.org/dev/peps/pep-0257/"}}
{"actor":{"display_login":"mincong-h"}}