{"action":"closed","number":630,"pull_request":{"url":"https://api.github.com/repos/feross/webtorrent/pulls/630","id":60035805,"html_url":"https://github.com/feross/webtorrent/pull/630","diff_url":"https://github.com/feross/webtorrent/pull/630.diff","patch_url":"https://github.com/feross/webtorrent/pull/630.patch","issue_url":"https://api.github.com/repos/feross/webtorrent/issues/630","number":630,"state":"closed","locked":false,"title":"call unref only when present","user":{"login":"substack","id":12631,"avatar_url":"https://avatars.githubusercontent.com/u/12631?v=3","gravatar_id":"","url":"https://api.github.com/users/substack","html_url":"https://github.com/substack","followers_url":"https://api.github.com/users/substack/followers","following_url":"https://api.github.com/users/substack/following{/other_user}","gists_url":"https://api.github.com/users/substack/gists{/gist_id}","starred_url":"https://api.github.com/users/substack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/substack/subscriptions","organizations_url":"https://api.github.com/users/substack/orgs","repos_url":"https://api.github.com/users/substack/repos","events_url":"https://api.github.com/users/substack/events{/privacy}","received_events_url":"https://api.github.com/users/substack/received_events","type":"User","site_admin":false},"body":"This patch to the command-line client guards calls to `.unref()` so unref is only called when present. Electron doesn't appear to have `.unref()` methods. Now with this patch I can do:\r\n\r\n```\r\n$ electron-spawn `which webtorrent` MAGNET\r\n```\r\n\r\nto download a magnet over webrtc from the command-line using webtorrent.","created_at":"2016-02-20T03:24:37Z","updated_at":"2016-02-21T04:26:04Z","closed_at":"2016-02-21T04:26:04Z","merged_at":"2016-02-21T04:26:04Z","merge_commit_sha":"46738eab3ce6df14ce4ef9a8e2e7f04340ff81e2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/feross/webtorrent/pulls/630/commits","review_comments_url":"https://api.github.com/repos/feross/webtorrent/pulls/630/comments","review_comment_url":"https://api.github.com/repos/feross/webtorrent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/feross/webtorrent/issues/630/comments","statuses_url":"https://api.github.com/repos/feross/webtorrent/statuses/e8634ac4a7235d01c2c05a06dacb36199046e3c4","head":{"label":"substack:unref","ref":"unref","sha":"e8634ac4a7235d01c2c05a06dacb36199046e3c4","user":{"login":"substack","id":12631,"avatar_url":"https://avatars.githubusercontent.com/u/12631?v=3","gravatar_id":"","url":"https://api.github.com/users/substack","html_url":"https://github.com/substack","followers_url":"https://api.github.com/users/substack/followers","following_url":"https://api.github.com/users/substack/following{/other_user}","gists_url":"https://api.github.com/users/substack/gists{/gist_id}","starred_url":"https://api.github.com/users/substack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/substack/subscriptions","organizations_url":"https://api.github.com/users/substack/orgs","repos_url":"https://api.github.com/users/substack/repos","events_url":"https://api.github.com/users/substack/events{/privacy}","received_events_url":"https://api.github.com/users/substack/received_events","type":"User","site_admin":false},"repo":{"id":51397053,"name":"webtorrent","full_name":"substack/webtorrent","owner":{"login":"substack","id":12631,"avatar_url":"https://avatars.githubusercontent.com/u/12631?v=3","gravatar_id":"","url":"https://api.github.com/users/substack","html_url":"https://github.com/substack","followers_url":"https://api.github.com/users/substack/followers","following_url":"https://api.github.com/users/substack/following{/other_user}","gists_url":"https://api.github.com/users/substack/gists{/gist_id}","starred_url":"https://api.github.com/users/substack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/substack/subscriptions","organizations_url":"https://api.github.com/users/substack/orgs","repos_url":"https://api.github.com/users/substack/repos","events_url":"https://api.github.com/users/substack/events{/privacy}","received_events_url":"https://api.github.com/users/substack/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/substack/webtorrent","description":":zap: Streaming torrent client for the web","fork":true,"url":"https://api.github.com/repos/substack/webtorrent","forks_url":"https://api.github.com/repos/substack/webtorrent/forks","keys_url":"https://api.github.com/repos/substack/webtorrent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/substack/webtorrent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/substack/webtorrent/teams","hooks_url":"https://api.github.com/repos/substack/webtorrent/hooks","issue_events_url":"https://api.github.com/repos/substack/webtorrent/issues/events{/number}","events_url":"https://api.github.com/repos/substack/webtorrent/events","assignees_url":"https://api.github.com/repos/substack/webtorrent/assignees{/user}","branches_url":"https://api.github.com/repos/substack/webtorrent/branches{/branch}","tags_url":"https://api.github.com/repos/substack/webtorrent/tags","blobs_url":"https://api.github.com/repos/substack/webtorrent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/substack/webtorrent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/substack/webtorrent/git/refs{/sha}","trees_url":"https://api.github.com/repos/substack/webtorrent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/substack/webtorrent/statuses/{sha}","languages_url":"https://api.github.com/repos/substack/webtorrent/languages","stargazers_url":"https://api.github.com/repos/substack/webtorrent/stargazers","contributors_url":"https://api.github.com/repos/substack/webtorrent/contributors","subscribers_url":"https://api.github.com/repos/substack/webtorrent/subscribers","subscription_url":"https://api.github.com/repos/substack/webtorrent/subscription","commits_url":"https://api.github.com/repos/substack/webtorrent/commits{/sha}","git_commits_url":"https://api.github.com/repos/substack/webtorrent/git/commits{/sha}","comments_url":"https://api.github.com/repos/substack/webtorrent/comments{/number}","issue_comment_url":"https://api.github.com/repos/substack/webtorrent/issues/comments{/number}","contents_url":"https://api.github.com/repos/substack/webtorrent/contents/{+path}","compare_url":"https://api.github.com/repos/substack/webtorrent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/substack/webtorrent/merges","archive_url":"https://api.github.com/repos/substack/webtorrent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/substack/webtorrent/downloads","issues_url":"https://api.github.com/repos/substack/webtorrent/issues{/number}","pulls_url":"https://api.github.com/repos/substack/webtorrent/pulls{/number}","milestones_url":"https://api.github.com/repos/substack/webtorrent/milestones{/number}","notifications_url":"https://api.github.com/repos/substack/webtorrent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/substack/webtorrent/labels{/name}","releases_url":"https://api.github.com/repos/substack/webtorrent/releases{/id}","deployments_url":"https://api.github.com/repos/substack/webtorrent/deployments","created_at":"2016-02-09T20:24:25Z","updated_at":"2016-02-10T01:37:29Z","pushed_at":"2016-02-20T03:21:09Z","git_url":"git://github.com/substack/webtorrent.git","ssh_url":"git@github.com:substack/webtorrent.git","clone_url":"https://github.com/substack/webtorrent.git","svn_url":"https://github.com/substack/webtorrent","homepage":"https://webtorrent.io","size":4304,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"feross:master","ref":"master","sha":"1ef81384dcab01800f14cf620171762091897735","user":{"login":"feross","id":121766,"avatar_url":"https://avatars.githubusercontent.com/u/121766?v=3","gravatar_id":"","url":"https://api.github.com/users/feross","html_url":"https://github.com/feross","followers_url":"https://api.github.com/users/feross/followers","following_url":"https://api.github.com/users/feross/following{/other_user}","gists_url":"https://api.github.com/users/feross/gists{/gist_id}","starred_url":"https://api.github.com/users/feross/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feross/subscriptions","organizations_url":"https://api.github.com/users/feross/orgs","repos_url":"https://api.github.com/users/feross/repos","events_url":"https://api.github.com/users/feross/events{/privacy}","received_events_url":"https://api.github.com/users/feross/received_events","type":"User","site_admin":false},"repo":{"id":13584262,"name":"webtorrent","full_name":"feross/webtorrent","owner":{"login":"feross","id":121766,"avatar_url":"https://avatars.githubusercontent.com/u/121766?v=3","gravatar_id":"","url":"https://api.github.com/users/feross","html_url":"https://github.com/feross","followers_url":"https://api.github.com/users/feross/followers","following_url":"https://api.github.com/users/feross/following{/other_user}","gists_url":"https://api.github.com/users/feross/gists{/gist_id}","starred_url":"https://api.github.com/users/feross/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feross/subscriptions","organizations_url":"https://api.github.com/users/feross/orgs","repos_url":"https://api.github.com/users/feross/repos","events_url":"https://api.github.com/users/feross/events{/privacy}","received_events_url":"https://api.github.com/users/feross/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/feross/webtorrent","description":":zap: Streaming torrent client for the web","fork":false,"url":"https://api.github.com/repos/feross/webtorrent","forks_url":"https://api.github.com/repos/feross/webtorrent/forks","keys_url":"https://api.github.com/repos/feross/webtorrent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/feross/webtorrent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/feross/webtorrent/teams","hooks_url":"https://api.github.com/repos/feross/webtorrent/hooks","issue_events_url":"https://api.github.com/repos/feross/webtorrent/issues/events{/number}","events_url":"https://api.github.com/repos/feross/webtorrent/events","assignees_url":"https://api.github.com/repos/feross/webtorrent/assignees{/user}","branches_url":"https://api.github.com/repos/feross/webtorrent/branches{/branch}","tags_url":"https://api.github.com/repos/feross/webtorrent/tags","blobs_url":"https://api.github.com/repos/feross/webtorrent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/feross/webtorrent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/feross/webtorrent/git/refs{/sha}","trees_url":"https://api.github.com/repos/feross/webtorrent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/feross/webtorrent/statuses/{sha}","languages_url":"https://api.github.com/repos/feross/webtorrent/languages","stargazers_url":"https://api.github.com/repos/feross/webtorrent/stargazers","contributors_url":"https://api.github.com/repos/feross/webtorrent/contributors","subscribers_url":"https://api.github.com/repos/feross/webtorrent/subscribers","subscription_url":"https://api.github.com/repos/feross/webtorrent/subscription","commits_url":"https://api.github.com/repos/feross/webtorrent/commits{/sha}","git_commits_url":"https://api.github.com/repos/feross/webtorrent/git/commits{/sha}","comments_url":"https://api.github.com/repos/feross/webtorrent/comments{/number}","issue_comment_url":"https://api.github.com/repos/feross/webtorrent/issues/comments{/number}","contents_url":"https://api.github.com/repos/feross/webtorrent/contents/{+path}","compare_url":"https://api.github.com/repos/feross/webtorrent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/feross/webtorrent/merges","archive_url":"https://api.github.com/repos/feross/webtorrent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/feross/webtorrent/downloads","issues_url":"https://api.github.com/repos/feross/webtorrent/issues{/number}","pulls_url":"https://api.github.com/repos/feross/webtorrent/pulls{/number}","milestones_url":"https://api.github.com/repos/feross/webtorrent/milestones{/number}","notifications_url":"https://api.github.com/repos/feross/webtorrent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/feross/webtorrent/labels{/name}","releases_url":"https://api.github.com/repos/feross/webtorrent/releases{/id}","deployments_url":"https://api.github.com/repos/feross/webtorrent/deployments","created_at":"2013-10-15T08:16:40Z","updated_at":"2016-02-20T21:18:09Z","pushed_at":"2016-02-21T04:26:05Z","git_url":"git://github.com/feross/webtorrent.git","ssh_url":"git@github.com:feross/webtorrent.git","clone_url":"https://github.com/feross/webtorrent.git","svn_url":"https://github.com/feross/webtorrent","homepage":"https://webtorrent.io","size":6121,"stargazers_count":9077,"watchers_count":9077,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":660,"mirror_url":null,"open_issues_count":80,"forks":660,"open_issues":80,"watchers":9077,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/feross/webtorrent/pulls/630"},"html":{"href":"https://github.com/feross/webtorrent/pull/630"},"issue":{"href":"https://api.github.com/repos/feross/webtorrent/issues/630"},"comments":{"href":"https://api.github.com/repos/feross/webtorrent/issues/630/comments"},"review_comments":{"href":"https://api.github.com/repos/feross/webtorrent/pulls/630/comments"},"review_comment":{"href":"https://api.github.com/repos/feross/webtorrent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/feross/webtorrent/pulls/630/commits"},"statuses":{"href":"https://api.github.com/repos/feross/webtorrent/statuses/e8634ac4a7235d01c2c05a06dacb36199046e3c4"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"feross","id":121766,"avatar_url":"https://avatars.githubusercontent.com/u/121766?v=3","gravatar_id":"","url":"https://api.github.com/users/feross","html_url":"https://github.com/feross","followers_url":"https://api.github.com/users/feross/followers","following_url":"https://api.github.com/users/feross/following{/other_user}","gists_url":"https://api.github.com/users/feross/gists{/gist_id}","starred_url":"https://api.github.com/users/feross/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feross/subscriptions","organizations_url":"https://api.github.com/users/feross/orgs","repos_url":"https://api.github.com/users/feross/repos","events_url":"https://api.github.com/users/feross/events{/privacy}","received_events_url":"https://api.github.com/users/feross/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":12,"deletions":8,"changed_files":1}}