{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/8040","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/8040/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/8040/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/8040/events","html_url":"https://github.com/nodejs/node/pull/8040","id":170295323,"number":8040,"title":"Add crypto.timingSafeEqual()","user":{"login":"not-an-aardvark","id":11638619,"avatar_url":"https://avatars.githubusercontent.com/u/11638619?v=3","gravatar_id":"","url":"https://api.github.com/users/not-an-aardvark","html_url":"https://github.com/not-an-aardvark","followers_url":"https://api.github.com/users/not-an-aardvark/followers","following_url":"https://api.github.com/users/not-an-aardvark/following{/other_user}","gists_url":"https://api.github.com/users/not-an-aardvark/gists{/gist_id}","starred_url":"https://api.github.com/users/not-an-aardvark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/not-an-aardvark/subscriptions","organizations_url":"https://api.github.com/users/not-an-aardvark/orgs","repos_url":"https://api.github.com/users/not-an-aardvark/repos","events_url":"https://api.github.com/users/not-an-aardvark/events{/privacy}","received_events_url":"https://api.github.com/users/not-an-aardvark/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/nodejs/node/labels/c++","name":"c++","color":"e11d21"},{"url":"https://api.github.com/repos/nodejs/node/labels/crypto","name":"crypto","color":"009800"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":30,"created_at":"2016-08-09T23:32:06Z","updated_at":"2016-08-12T21:32:35Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/8040","html_url":"https://github.com/nodejs/node/pull/8040","diff_url":"https://github.com/nodejs/node/pull/8040.diff","patch_url":"https://github.com/nodejs/node/pull/8040.patch"},"body":"<!--\r\nThank you for your pull request. Please review below requirements.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test nosign` (Windows) passes\r\n- [x] tests and/or benchmarks are included\r\n- [x] documentation is changed or added\r\n- [x] commit message follows commit guidelines\r\n\r\n##### Affected core subsystem(s)\r\ncrypto\r\n\r\n\r\n##### Description of change\r\n\r\nRelates to #3073. This is an implementation of a timing-safe key comparison function, implemented on the C++ side as suggested in https://github.com/nodejs/node/pull/3073#issuecomment-226928136 and https://github.com/nodejs/node/pull/3073#issuecomment-227189024.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/239565017","html_url":"https://github.com/nodejs/node/pull/8040#issuecomment-239565017","issue_url":"https://api.github.com/repos/nodejs/node/issues/8040","id":239565017,"user":{"login":"addaleax","id":899444,"avatar_url":"https://avatars.githubusercontent.com/u/899444?v=3","gravatar_id":"","url":"https://api.github.com/users/addaleax","html_url":"https://github.com/addaleax","followers_url":"https://api.github.com/users/addaleax/followers","following_url":"https://api.github.com/users/addaleax/following{/other_user}","gists_url":"https://api.github.com/users/addaleax/gists{/gist_id}","starred_url":"https://api.github.com/users/addaleax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/addaleax/subscriptions","organizations_url":"https://api.github.com/users/addaleax/orgs","repos_url":"https://api.github.com/users/addaleax/repos","events_url":"https://api.github.com/users/addaleax/events{/privacy}","received_events_url":"https://api.github.com/users/addaleax/received_events","type":"User","site_admin":false},"created_at":"2016-08-12T21:32:35Z","updated_at":"2016-08-12T21:32:35Z","body":"I guess this is what James had in mind, yes. Unfortunately, the test currently *fails* often enough for me locally. This is pretty reliable, especially when turning up `numTrials` by one or two orders of magnitude, with the `equal` test almost always ending up about 2 % faster than the `unequal` test."}}
{"actor":{"display_login":"addaleax"}}