{"action":"created","issue":{"url":"https://api.github.com/repos/jekyll/jekyll/issues/5581","repository_url":"https://api.github.com/repos/jekyll/jekyll","labels_url":"https://api.github.com/repos/jekyll/jekyll/issues/5581/labels{/name}","comments_url":"https://api.github.com/repos/jekyll/jekyll/issues/5581/comments","events_url":"https://api.github.com/repos/jekyll/jekyll/issues/5581/events","html_url":"https://github.com/jekyll/jekyll/issues/5581","id":189298337,"number":5581,"title":"unnecessary gem for Windows","user":{"login":"ashmaroli","id":12479464,"avatar_url":"https://avatars.githubusercontent.com/u/12479464?v=3","gravatar_id":"","url":"https://api.github.com/users/ashmaroli","html_url":"https://github.com/ashmaroli","followers_url":"https://api.github.com/users/ashmaroli/followers","following_url":"https://api.github.com/users/ashmaroli/following{/other_user}","gists_url":"https://api.github.com/users/ashmaroli/gists{/gist_id}","starred_url":"https://api.github.com/users/ashmaroli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashmaroli/subscriptions","organizations_url":"https://api.github.com/users/ashmaroli/orgs","repos_url":"https://api.github.com/users/ashmaroli/repos","events_url":"https://api.github.com/users/ashmaroli/events{/privacy}","received_events_url":"https://api.github.com/users/ashmaroli/received_events","type":"User","site_admin":false},"labels":[{"id":151345987,"url":"https://api.github.com/repos/jekyll/jekyll/labels/windows","name":"windows","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":{"login":"parkr","id":237985,"avatar_url":"https://avatars.githubusercontent.com/u/237985?v=3","gravatar_id":"","url":"https://api.github.com/users/parkr","html_url":"https://github.com/parkr","followers_url":"https://api.github.com/users/parkr/followers","following_url":"https://api.github.com/users/parkr/following{/other_user}","gists_url":"https://api.github.com/users/parkr/gists{/gist_id}","starred_url":"https://api.github.com/users/parkr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parkr/subscriptions","organizations_url":"https://api.github.com/users/parkr/orgs","repos_url":"https://api.github.com/users/parkr/repos","events_url":"https://api.github.com/users/parkr/events{/privacy}","received_events_url":"https://api.github.com/users/parkr/received_events","type":"User","site_admin":true},"assignees":[{"login":"parkr","id":237985,"avatar_url":"https://avatars.githubusercontent.com/u/237985?v=3","gravatar_id":"","url":"https://api.github.com/users/parkr","html_url":"https://github.com/parkr","followers_url":"https://api.github.com/users/parkr/followers","following_url":"https://api.github.com/users/parkr/following{/other_user}","gists_url":"https://api.github.com/users/parkr/gists{/gist_id}","starred_url":"https://api.github.com/users/parkr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parkr/subscriptions","organizations_url":"https://api.github.com/users/parkr/orgs","repos_url":"https://api.github.com/users/parkr/repos","events_url":"https://api.github.com/users/parkr/events{/privacy}","received_events_url":"https://api.github.com/users/parkr/received_events","type":"User","site_admin":true}],"milestone":null,"comments":2,"created_at":"2016-11-15T04:39:05Z","updated_at":"2016-11-15T13:33:02Z","closed_at":null,"body":"Jekyll Version: **3.3.1**\r\nRuby Version: **Ruby 2.3.1p112**\r\nPlatform: **x86-mingw32**\r\n\r\nI definitely think the following is unnecessary for Windows:\r\n```\r\n  Please add the following to your Gemfile to avoid polling for changes:\r\n    gem 'wdm', '>= 0.1.0' if Gem.win_platform?\r\n```\r\n### Points To Consider\r\n- I can `serve` and `watch` without having that gem included in my **Gemfile** (an hence `bundle` context as well)\r\n- Perhaps it **may be necessary** for other *types of Ruby on Windows*, but then why does the console say: `to avoid polling for changes`, when the gem purportedly [enables polling](https://jekyllrb.com/docs/windows/#auto-regeneration) on the jekyll site on Windows?\r\n"},"comment":{"url":"https://api.github.com/repos/jekyll/jekyll/issues/comments/260641910","html_url":"https://github.com/jekyll/jekyll/issues/5581#issuecomment-260641910","issue_url":"https://api.github.com/repos/jekyll/jekyll/issues/5581","id":260641910,"user":{"login":"sverrirs","id":1184355,"avatar_url":"https://avatars.githubusercontent.com/u/1184355?v=3","gravatar_id":"","url":"https://api.github.com/users/sverrirs","html_url":"https://github.com/sverrirs","followers_url":"https://api.github.com/users/sverrirs/followers","following_url":"https://api.github.com/users/sverrirs/following{/other_user}","gists_url":"https://api.github.com/users/sverrirs/gists{/gist_id}","starred_url":"https://api.github.com/users/sverrirs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sverrirs/subscriptions","organizations_url":"https://api.github.com/users/sverrirs/orgs","repos_url":"https://api.github.com/users/sverrirs/repos","events_url":"https://api.github.com/users/sverrirs/events{/privacy}","received_events_url":"https://api.github.com/users/sverrirs/received_events","type":"User","site_admin":false},"created_at":"2016-11-15T13:33:02Z","updated_at":"2016-11-15T13:33:02Z","body":"@ashmaroli Agreed that the message is unnecessary to print out each time when you run Jekyll on Windows. However, can you point to where the `wdm` gem _enables polling_ as you claim. I've had a look but can't see it doing that.\r\n\r\nJudging by the source code at https://github.com/Maher4Ever/wdm/blob/master/ext/wdm/rb_monitor.c it seems to use a dedicated thread that depends on the native Windows function `ReadDirectoryChangesW` https://msdn.microsoft.com/en-us/library/windows/desktop/aa365465.aspx to set up a callback-based async monitoring for the directory contents. Should be as efficient as you can get on Windows (without using change journals)."}}
{"actor":{"display_login":"sverrirs"}}