{"action":"created","comment":{"url":"https://api.github.com/repos/bolt/Members/pulls/comments/78997089","id":78997089,"diff_hunk":"@@ -200,15 +200,20 @@ public function login(Application $app, Request $request)\n \n             // Initial login checks\n             $response = $handler->login($request);\n-            if ($response instanceof Response) {\n-                return $response;\n+            if ($response) {\n+                if ($response instanceof Response) {\n+                    return $response;\n+                }\n+\n+                // Process and check password, initiate the session is successful\n+                $response = $handler->process($request);\n+                if ($response) {\n+                    if ($response instanceof Response) {\n+                        return $response;\n+                    }\n+                }","path":"src/Controller/Authentication.php","position":17,"original_position":17,"commit_id":"70f4ac587b60f7ec5e8d0273a5cff56ed5973a81","original_commit_id":"70f4ac587b60f7ec5e8d0273a5cff56ed5973a81","user":{"login":"GawainLynch","id":1427081,"avatar_url":"https://avatars.githubusercontent.com/u/1427081?v=3","gravatar_id":"","url":"https://api.github.com/users/GawainLynch","html_url":"https://github.com/GawainLynch","followers_url":"https://api.github.com/users/GawainLynch/followers","following_url":"https://api.github.com/users/GawainLynch/following{/other_user}","gists_url":"https://api.github.com/users/GawainLynch/gists{/gist_id}","starred_url":"https://api.github.com/users/GawainLynch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GawainLynch/subscriptions","organizations_url":"https://api.github.com/users/GawainLynch/orgs","repos_url":"https://api.github.com/users/GawainLynch/repos","events_url":"https://api.github.com/users/GawainLynch/events{/privacy}","received_events_url":"https://api.github.com/users/GawainLynch/received_events","type":"User","site_admin":false},"body":"I'd prefer keeping the instance check, as we can't use return types yet.","created_at":"2016-09-15T15:48:52Z","updated_at":"2016-09-15T15:48:52Z","html_url":"https://github.com/bolt/Members/pull/43#discussion_r78997089","pull_request_url":"https://api.github.com/repos/bolt/Members/pulls/43","_links":{"self":{"href":"https://api.github.com/repos/bolt/Members/pulls/comments/78997089"},"html":{"href":"https://github.com/bolt/Members/pull/43#discussion_r78997089"},"pull_request":{"href":"https://api.github.com/repos/bolt/Members/pulls/43"}}},"pull_request":{"url":"https://api.github.com/repos/bolt/Members/pulls/43","id":85425194,"html_url":"https://github.com/bolt/Members/pull/43","diff_url":"https://github.com/bolt/Members/pull/43.diff","patch_url":"https://github.com/bolt/Members/pull/43.patch","issue_url":"https://api.github.com/repos/bolt/Members/issues/43","number":43,"state":"open","locked":false,"title":"login handler was crashing when using incorrect email","user":{"login":"dadaxr","id":1267495,"avatar_url":"https://avatars.githubusercontent.com/u/1267495?v=3","gravatar_id":"","url":"https://api.github.com/users/dadaxr","html_url":"https://github.com/dadaxr","followers_url":"https://api.github.com/users/dadaxr/followers","following_url":"https://api.github.com/users/dadaxr/following{/other_user}","gists_url":"https://api.github.com/users/dadaxr/gists{/gist_id}","starred_url":"https://api.github.com/users/dadaxr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dadaxr/subscriptions","organizations_url":"https://api.github.com/users/dadaxr/orgs","repos_url":"https://api.github.com/users/dadaxr/repos","events_url":"https://api.github.com/users/dadaxr/events{/privacy}","received_events_url":"https://api.github.com/users/dadaxr/received_events","type":"User","site_admin":false},"body":"fix login & process handlers return value to handle rightly bad credentials","created_at":"2016-09-15T15:23:02Z","updated_at":"2016-09-15T15:48:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6819aae368c84e9ec14c8020526e1010028f7d93","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/bolt/Members/pulls/43/commits","review_comments_url":"https://api.github.com/repos/bolt/Members/pulls/43/comments","review_comment_url":"https://api.github.com/repos/bolt/Members/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bolt/Members/issues/43/comments","statuses_url":"https://api.github.com/repos/bolt/Members/statuses/70f4ac587b60f7ec5e8d0273a5cff56ed5973a81","head":{"label":"dadaxr:master","ref":"master","sha":"70f4ac587b60f7ec5e8d0273a5cff56ed5973a81","user":{"login":"dadaxr","id":1267495,"avatar_url":"https://avatars.githubusercontent.com/u/1267495?v=3","gravatar_id":"","url":"https://api.github.com/users/dadaxr","html_url":"https://github.com/dadaxr","followers_url":"https://api.github.com/users/dadaxr/followers","following_url":"https://api.github.com/users/dadaxr/following{/other_user}","gists_url":"https://api.github.com/users/dadaxr/gists{/gist_id}","starred_url":"https://api.github.com/users/dadaxr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dadaxr/subscriptions","organizations_url":"https://api.github.com/users/dadaxr/orgs","repos_url":"https://api.github.com/users/dadaxr/repos","events_url":"https://api.github.com/users/dadaxr/events{/privacy}","received_events_url":"https://api.github.com/users/dadaxr/received_events","type":"User","site_admin":false},"repo":{"id":56610453,"name":"Members","full_name":"dadaxr/Members","owner":{"login":"dadaxr","id":1267495,"avatar_url":"https://avatars.githubusercontent.com/u/1267495?v=3","gravatar_id":"","url":"https://api.github.com/users/dadaxr","html_url":"https://github.com/dadaxr","followers_url":"https://api.github.com/users/dadaxr/followers","following_url":"https://api.github.com/users/dadaxr/following{/other_user}","gists_url":"https://api.github.com/users/dadaxr/gists{/gist_id}","starred_url":"https://api.github.com/users/dadaxr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dadaxr/subscriptions","organizations_url":"https://api.github.com/users/dadaxr/orgs","repos_url":"https://api.github.com/users/dadaxr/repos","events_url":"https://api.github.com/users/dadaxr/events{/privacy}","received_events_url":"https://api.github.com/users/dadaxr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dadaxr/Members","description":"Membership extension for Bolt","fork":true,"url":"https://api.github.com/repos/dadaxr/Members","forks_url":"https://api.github.com/repos/dadaxr/Members/forks","keys_url":"https://api.github.com/repos/dadaxr/Members/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dadaxr/Members/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dadaxr/Members/teams","hooks_url":"https://api.github.com/repos/dadaxr/Members/hooks","issue_events_url":"https://api.github.com/repos/dadaxr/Members/issues/events{/number}","events_url":"https://api.github.com/repos/dadaxr/Members/events","assignees_url":"https://api.github.com/repos/dadaxr/Members/assignees{/user}","branches_url":"https://api.github.com/repos/dadaxr/Members/branches{/branch}","tags_url":"https://api.github.com/repos/dadaxr/Members/tags","blobs_url":"https://api.github.com/repos/dadaxr/Members/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dadaxr/Members/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dadaxr/Members/git/refs{/sha}","trees_url":"https://api.github.com/repos/dadaxr/Members/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dadaxr/Members/statuses/{sha}","languages_url":"https://api.github.com/repos/dadaxr/Members/languages","stargazers_url":"https://api.github.com/repos/dadaxr/Members/stargazers","contributors_url":"https://api.github.com/repos/dadaxr/Members/contributors","subscribers_url":"https://api.github.com/repos/dadaxr/Members/subscribers","subscription_url":"https://api.github.com/repos/dadaxr/Members/subscription","commits_url":"https://api.github.com/repos/dadaxr/Members/commits{/sha}","git_commits_url":"https://api.github.com/repos/dadaxr/Members/git/commits{/sha}","comments_url":"https://api.github.com/repos/dadaxr/Members/comments{/number}","issue_comment_url":"https://api.github.com/repos/dadaxr/Members/issues/comments{/number}","contents_url":"https://api.github.com/repos/dadaxr/Members/contents/{+path}","compare_url":"https://api.github.com/repos/dadaxr/Members/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dadaxr/Members/merges","archive_url":"https://api.github.com/repos/dadaxr/Members/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dadaxr/Members/downloads","issues_url":"https://api.github.com/repos/dadaxr/Members/issues{/number}","pulls_url":"https://api.github.com/repos/dadaxr/Members/pulls{/number}","milestones_url":"https://api.github.com/repos/dadaxr/Members/milestones{/number}","notifications_url":"https://api.github.com/repos/dadaxr/Members/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dadaxr/Members/labels{/name}","releases_url":"https://api.github.com/repos/dadaxr/Members/releases{/id}","deployments_url":"https://api.github.com/repos/dadaxr/Members/deployments","created_at":"2016-04-19T15:47:49Z","updated_at":"2016-04-19T15:47:51Z","pushed_at":"2016-09-15T15:19:25Z","git_url":"git://github.com/dadaxr/Members.git","ssh_url":"git@github.com:dadaxr/Members.git","clone_url":"https://github.com/dadaxr/Members.git","svn_url":"https://github.com/dadaxr/Members","homepage":"http://bolt.cm","size":1172,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bolt:master","ref":"master","sha":"09b525904651bc933c6fcc54c97816e069697919","user":{"login":"bolt","id":3869752,"avatar_url":"https://avatars.githubusercontent.com/u/3869752?v=3","gravatar_id":"","url":"https://api.github.com/users/bolt","html_url":"https://github.com/bolt","followers_url":"https://api.github.com/users/bolt/followers","following_url":"https://api.github.com/users/bolt/following{/other_user}","gists_url":"https://api.github.com/users/bolt/gists{/gist_id}","starred_url":"https://api.github.com/users/bolt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bolt/subscriptions","organizations_url":"https://api.github.com/users/bolt/orgs","repos_url":"https://api.github.com/users/bolt/repos","events_url":"https://api.github.com/users/bolt/events{/privacy}","received_events_url":"https://api.github.com/users/bolt/received_events","type":"Organization","site_admin":false},"repo":{"id":23926853,"name":"Members","full_name":"bolt/Members","owner":{"login":"bolt","id":3869752,"avatar_url":"https://avatars.githubusercontent.com/u/3869752?v=3","gravatar_id":"","url":"https://api.github.com/users/bolt","html_url":"https://github.com/bolt","followers_url":"https://api.github.com/users/bolt/followers","following_url":"https://api.github.com/users/bolt/following{/other_user}","gists_url":"https://api.github.com/users/bolt/gists{/gist_id}","starred_url":"https://api.github.com/users/bolt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bolt/subscriptions","organizations_url":"https://api.github.com/users/bolt/orgs","repos_url":"https://api.github.com/users/bolt/repos","events_url":"https://api.github.com/users/bolt/events{/privacy}","received_events_url":"https://api.github.com/users/bolt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bolt/Members","description":"Membership extension for Bolt","fork":false,"url":"https://api.github.com/repos/bolt/Members","forks_url":"https://api.github.com/repos/bolt/Members/forks","keys_url":"https://api.github.com/repos/bolt/Members/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bolt/Members/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bolt/Members/teams","hooks_url":"https://api.github.com/repos/bolt/Members/hooks","issue_events_url":"https://api.github.com/repos/bolt/Members/issues/events{/number}","events_url":"https://api.github.com/repos/bolt/Members/events","assignees_url":"https://api.github.com/repos/bolt/Members/assignees{/user}","branches_url":"https://api.github.com/repos/bolt/Members/branches{/branch}","tags_url":"https://api.github.com/repos/bolt/Members/tags","blobs_url":"https://api.github.com/repos/bolt/Members/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bolt/Members/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bolt/Members/git/refs{/sha}","trees_url":"https://api.github.com/repos/bolt/Members/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bolt/Members/statuses/{sha}","languages_url":"https://api.github.com/repos/bolt/Members/languages","stargazers_url":"https://api.github.com/repos/bolt/Members/stargazers","contributors_url":"https://api.github.com/repos/bolt/Members/contributors","subscribers_url":"https://api.github.com/repos/bolt/Members/subscribers","subscription_url":"https://api.github.com/repos/bolt/Members/subscription","commits_url":"https://api.github.com/repos/bolt/Members/commits{/sha}","git_commits_url":"https://api.github.com/repos/bolt/Members/git/commits{/sha}","comments_url":"https://api.github.com/repos/bolt/Members/comments{/number}","issue_comment_url":"https://api.github.com/repos/bolt/Members/issues/comments{/number}","contents_url":"https://api.github.com/repos/bolt/Members/contents/{+path}","compare_url":"https://api.github.com/repos/bolt/Members/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bolt/Members/merges","archive_url":"https://api.github.com/repos/bolt/Members/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bolt/Members/downloads","issues_url":"https://api.github.com/repos/bolt/Members/issues{/number}","pulls_url":"https://api.github.com/repos/bolt/Members/pulls{/number}","milestones_url":"https://api.github.com/repos/bolt/Members/milestones{/number}","notifications_url":"https://api.github.com/repos/bolt/Members/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bolt/Members/labels{/name}","releases_url":"https://api.github.com/repos/bolt/Members/releases{/id}","deployments_url":"https://api.github.com/repos/bolt/Members/deployments","created_at":"2014-09-11T16:46:09Z","updated_at":"2016-08-15T17:23:27Z","pushed_at":"2016-09-15T15:23:02Z","git_url":"git://github.com/bolt/Members.git","ssh_url":"git@github.com:bolt/Members.git","clone_url":"https://github.com/bolt/Members.git","svn_url":"https://github.com/bolt/Members","homepage":"http://bolt.cm","size":1532,"stargazers_count":19,"watchers_count":19,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":5,"forks":5,"open_issues":5,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bolt/Members/pulls/43"},"html":{"href":"https://github.com/bolt/Members/pull/43"},"issue":{"href":"https://api.github.com/repos/bolt/Members/issues/43"},"comments":{"href":"https://api.github.com/repos/bolt/Members/issues/43/comments"},"review_comments":{"href":"https://api.github.com/repos/bolt/Members/pulls/43/comments"},"review_comment":{"href":"https://api.github.com/repos/bolt/Members/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bolt/Members/pulls/43/commits"},"statuses":{"href":"https://api.github.com/repos/bolt/Members/statuses/70f4ac587b60f7ec5e8d0273a5cff56ed5973a81"}}}}
{"actor":{"display_login":"GawainLynch"}}