{"action":"created","comment":{"url":"https://api.github.com/repos/xtuple/qt-client/pulls/comments/68442162","id":68442162,"diff_hunk":"@@ -589,6 +623,26 @@ bool display::closeVisible() const\n   return _data->_closeAct->isVisible();\n }\n \n+void display::setExpandVisible(bool show)\n+{\n+  _data->_expandAct->setVisible(show);\n+}\n+\n+bool display::expandVisible() const\n+{\n+  return _data->_expandAct->isVisible();\n+}\n+\n+void display::setCollapseVisible(bool show)\n+{\n+  _data->_collapseAct->setVisible(show);\n+}\n+\n+bool display::collapseVisible() const\n+{\n+  return _data->_collapseAct->isVisible();\n+}\n+","path":"guiclient/display.cpp","position":110,"original_position":110,"commit_id":"49acaf7abf73fc975d194eb9902c435901eaca3b","original_commit_id":"49acaf7abf73fc975d194eb9902c435901eaca3b","user":{"login":"davidbeauchamp","id":1675112,"avatar_url":"https://avatars.githubusercontent.com/u/1675112?v=3","gravatar_id":"","url":"https://api.github.com/users/davidbeauchamp","html_url":"https://github.com/davidbeauchamp","followers_url":"https://api.github.com/users/davidbeauchamp/followers","following_url":"https://api.github.com/users/davidbeauchamp/following{/other_user}","gists_url":"https://api.github.com/users/davidbeauchamp/gists{/gist_id}","starred_url":"https://api.github.com/users/davidbeauchamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidbeauchamp/subscriptions","organizations_url":"https://api.github.com/users/davidbeauchamp/orgs","repos_url":"https://api.github.com/users/davidbeauchamp/repos","events_url":"https://api.github.com/users/davidbeauchamp/events{/privacy}","received_events_url":"https://api.github.com/users/davidbeauchamp/received_events","type":"User","site_admin":false},"body":"I was conflicted about this, but I just know someone is going to want them individually controllable. One thing I considered was adding a setExpandAndCollapseVisible(bool) as a convenience function. ","created_at":"2016-06-24T18:34:10Z","updated_at":"2016-06-24T18:34:10Z","html_url":"https://github.com/xtuple/qt-client/pull/1278#discussion_r68442162","pull_request_url":"https://api.github.com/repos/xtuple/qt-client/pulls/1278","_links":{"self":{"href":"https://api.github.com/repos/xtuple/qt-client/pulls/comments/68442162"},"html":{"href":"https://github.com/xtuple/qt-client/pull/1278#discussion_r68442162"},"pull_request":{"href":"https://api.github.com/repos/xtuple/qt-client/pulls/1278"}}},"pull_request":{"url":"https://api.github.com/repos/xtuple/qt-client/pulls/1278","id":75024559,"html_url":"https://github.com/xtuple/qt-client/pull/1278","diff_url":"https://github.com/xtuple/qt-client/pull/1278.diff","patch_url":"https://github.com/xtuple/qt-client/pull/1278.patch","issue_url":"https://api.github.com/repos/xtuple/qt-client/issues/1278","number":1278,"state":"open","locked":false,"title":"Issue #28134: Add expand/collapse buttons to display class controllable from C++ and script","user":{"login":"davidbeauchamp","id":1675112,"avatar_url":"https://avatars.githubusercontent.com/u/1675112?v=3","gravatar_id":"","url":"https://api.github.com/users/davidbeauchamp","html_url":"https://github.com/davidbeauchamp","followers_url":"https://api.github.com/users/davidbeauchamp/followers","following_url":"https://api.github.com/users/davidbeauchamp/following{/other_user}","gists_url":"https://api.github.com/users/davidbeauchamp/gists{/gist_id}","starred_url":"https://api.github.com/users/davidbeauchamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidbeauchamp/subscriptions","organizations_url":"https://api.github.com/users/davidbeauchamp/orgs","repos_url":"https://api.github.com/users/davidbeauchamp/repos","events_url":"https://api.github.com/users/davidbeauchamp/events{/privacy}","received_events_url":"https://api.github.com/users/davidbeauchamp/received_events","type":"User","site_admin":false},"body":"Buttons are hidden by default. To enable In C++ display class window:\r\n`setExpandVisible(true);`\r\n`setCollapseVisible(true);`\r\n\r\nIn QtScript:\r\n`mywindow.setExpandVisible(true);`\r\n`mywindow.setCollapseVisible(true);`","created_at":"2016-06-23T20:47:53Z","updated_at":"2016-06-24T18:34:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d4e1693bbe35faef381c4d4f793148dab1750661","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/xtuple/qt-client/pulls/1278/commits","review_comments_url":"https://api.github.com/repos/xtuple/qt-client/pulls/1278/comments","review_comment_url":"https://api.github.com/repos/xtuple/qt-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xtuple/qt-client/issues/1278/comments","statuses_url":"https://api.github.com/repos/xtuple/qt-client/statuses/49acaf7abf73fc975d194eb9902c435901eaca3b","head":{"label":"davidbeauchamp:expandcollapse","ref":"expandcollapse","sha":"49acaf7abf73fc975d194eb9902c435901eaca3b","user":{"login":"davidbeauchamp","id":1675112,"avatar_url":"https://avatars.githubusercontent.com/u/1675112?v=3","gravatar_id":"","url":"https://api.github.com/users/davidbeauchamp","html_url":"https://github.com/davidbeauchamp","followers_url":"https://api.github.com/users/davidbeauchamp/followers","following_url":"https://api.github.com/users/davidbeauchamp/following{/other_user}","gists_url":"https://api.github.com/users/davidbeauchamp/gists{/gist_id}","starred_url":"https://api.github.com/users/davidbeauchamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidbeauchamp/subscriptions","organizations_url":"https://api.github.com/users/davidbeauchamp/orgs","repos_url":"https://api.github.com/users/davidbeauchamp/repos","events_url":"https://api.github.com/users/davidbeauchamp/events{/privacy}","received_events_url":"https://api.github.com/users/davidbeauchamp/received_events","type":"User","site_admin":false},"repo":{"id":38171312,"name":"qt-client","full_name":"davidbeauchamp/qt-client","owner":{"login":"davidbeauchamp","id":1675112,"avatar_url":"https://avatars.githubusercontent.com/u/1675112?v=3","gravatar_id":"","url":"https://api.github.com/users/davidbeauchamp","html_url":"https://github.com/davidbeauchamp","followers_url":"https://api.github.com/users/davidbeauchamp/followers","following_url":"https://api.github.com/users/davidbeauchamp/following{/other_user}","gists_url":"https://api.github.com/users/davidbeauchamp/gists{/gist_id}","starred_url":"https://api.github.com/users/davidbeauchamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidbeauchamp/subscriptions","organizations_url":"https://api.github.com/users/davidbeauchamp/orgs","repos_url":"https://api.github.com/users/davidbeauchamp/repos","events_url":"https://api.github.com/users/davidbeauchamp/events{/privacy}","received_events_url":"https://api.github.com/users/davidbeauchamp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/davidbeauchamp/qt-client","description":"This repository contains the source code for the Desktop client. The Desktop client is built using the Qt framework for C++. The client can be extended or customized using JavaScript. This client is used by all editions of xTuple ERP.","fork":true,"url":"https://api.github.com/repos/davidbeauchamp/qt-client","forks_url":"https://api.github.com/repos/davidbeauchamp/qt-client/forks","keys_url":"https://api.github.com/repos/davidbeauchamp/qt-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/davidbeauchamp/qt-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/davidbeauchamp/qt-client/teams","hooks_url":"https://api.github.com/repos/davidbeauchamp/qt-client/hooks","issue_events_url":"https://api.github.com/repos/davidbeauchamp/qt-client/issues/events{/number}","events_url":"https://api.github.com/repos/davidbeauchamp/qt-client/events","assignees_url":"https://api.github.com/repos/davidbeauchamp/qt-client/assignees{/user}","branches_url":"https://api.github.com/repos/davidbeauchamp/qt-client/branches{/branch}","tags_url":"https://api.github.com/repos/davidbeauchamp/qt-client/tags","blobs_url":"https://api.github.com/repos/davidbeauchamp/qt-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/davidbeauchamp/qt-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/davidbeauchamp/qt-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/davidbeauchamp/qt-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/davidbeauchamp/qt-client/statuses/{sha}","languages_url":"https://api.github.com/repos/davidbeauchamp/qt-client/languages","stargazers_url":"https://api.github.com/repos/davidbeauchamp/qt-client/stargazers","contributors_url":"https://api.github.com/repos/davidbeauchamp/qt-client/contributors","subscribers_url":"https://api.github.com/repos/davidbeauchamp/qt-client/subscribers","subscription_url":"https://api.github.com/repos/davidbeauchamp/qt-client/subscription","commits_url":"https://api.github.com/repos/davidbeauchamp/qt-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/davidbeauchamp/qt-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/davidbeauchamp/qt-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/davidbeauchamp/qt-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/davidbeauchamp/qt-client/contents/{+path}","compare_url":"https://api.github.com/repos/davidbeauchamp/qt-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/davidbeauchamp/qt-client/merges","archive_url":"https://api.github.com/repos/davidbeauchamp/qt-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/davidbeauchamp/qt-client/downloads","issues_url":"https://api.github.com/repos/davidbeauchamp/qt-client/issues{/number}","pulls_url":"https://api.github.com/repos/davidbeauchamp/qt-client/pulls{/number}","milestones_url":"https://api.github.com/repos/davidbeauchamp/qt-client/milestones{/number}","notifications_url":"https://api.github.com/repos/davidbeauchamp/qt-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/davidbeauchamp/qt-client/labels{/name}","releases_url":"https://api.github.com/repos/davidbeauchamp/qt-client/releases{/id}","deployments_url":"https://api.github.com/repos/davidbeauchamp/qt-client/deployments","created_at":"2015-06-27T18:49:49Z","updated_at":"2016-01-16T00:52:38Z","pushed_at":"2016-06-24T15:19:54Z","git_url":"git://github.com/davidbeauchamp/qt-client.git","ssh_url":"git@github.com:davidbeauchamp/qt-client.git","clone_url":"https://github.com/davidbeauchamp/qt-client.git","svn_url":"https://github.com/davidbeauchamp/qt-client","homepage":"","size":91065,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"4_10_x"}},"base":{"label":"xtuple:4_10_x","ref":"4_10_x","sha":"ba01b672f856f139a07df8fec131da71ae710615","user":{"login":"xtuple","id":703922,"avatar_url":"https://avatars.githubusercontent.com/u/703922?v=3","gravatar_id":"","url":"https://api.github.com/users/xtuple","html_url":"https://github.com/xtuple","followers_url":"https://api.github.com/users/xtuple/followers","following_url":"https://api.github.com/users/xtuple/following{/other_user}","gists_url":"https://api.github.com/users/xtuple/gists{/gist_id}","starred_url":"https://api.github.com/users/xtuple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xtuple/subscriptions","organizations_url":"https://api.github.com/users/xtuple/orgs","repos_url":"https://api.github.com/users/xtuple/repos","events_url":"https://api.github.com/users/xtuple/events{/privacy}","received_events_url":"https://api.github.com/users/xtuple/received_events","type":"Organization","site_admin":false},"repo":{"id":10383821,"name":"qt-client","full_name":"xtuple/qt-client","owner":{"login":"xtuple","id":703922,"avatar_url":"https://avatars.githubusercontent.com/u/703922?v=3","gravatar_id":"","url":"https://api.github.com/users/xtuple","html_url":"https://github.com/xtuple","followers_url":"https://api.github.com/users/xtuple/followers","following_url":"https://api.github.com/users/xtuple/following{/other_user}","gists_url":"https://api.github.com/users/xtuple/gists{/gist_id}","starred_url":"https://api.github.com/users/xtuple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xtuple/subscriptions","organizations_url":"https://api.github.com/users/xtuple/orgs","repos_url":"https://api.github.com/users/xtuple/repos","events_url":"https://api.github.com/users/xtuple/events{/privacy}","received_events_url":"https://api.github.com/users/xtuple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xtuple/qt-client","description":"This repository contains the source code for the Desktop client. The Desktop client is built using the Qt framework for C++. The client can be extended or customized using JavaScript. This client is used by all editions of xTuple ERP.","fork":false,"url":"https://api.github.com/repos/xtuple/qt-client","forks_url":"https://api.github.com/repos/xtuple/qt-client/forks","keys_url":"https://api.github.com/repos/xtuple/qt-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xtuple/qt-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xtuple/qt-client/teams","hooks_url":"https://api.github.com/repos/xtuple/qt-client/hooks","issue_events_url":"https://api.github.com/repos/xtuple/qt-client/issues/events{/number}","events_url":"https://api.github.com/repos/xtuple/qt-client/events","assignees_url":"https://api.github.com/repos/xtuple/qt-client/assignees{/user}","branches_url":"https://api.github.com/repos/xtuple/qt-client/branches{/branch}","tags_url":"https://api.github.com/repos/xtuple/qt-client/tags","blobs_url":"https://api.github.com/repos/xtuple/qt-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xtuple/qt-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xtuple/qt-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/xtuple/qt-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xtuple/qt-client/statuses/{sha}","languages_url":"https://api.github.com/repos/xtuple/qt-client/languages","stargazers_url":"https://api.github.com/repos/xtuple/qt-client/stargazers","contributors_url":"https://api.github.com/repos/xtuple/qt-client/contributors","subscribers_url":"https://api.github.com/repos/xtuple/qt-client/subscribers","subscription_url":"https://api.github.com/repos/xtuple/qt-client/subscription","commits_url":"https://api.github.com/repos/xtuple/qt-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/xtuple/qt-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/xtuple/qt-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/xtuple/qt-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/xtuple/qt-client/contents/{+path}","compare_url":"https://api.github.com/repos/xtuple/qt-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xtuple/qt-client/merges","archive_url":"https://api.github.com/repos/xtuple/qt-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xtuple/qt-client/downloads","issues_url":"https://api.github.com/repos/xtuple/qt-client/issues{/number}","pulls_url":"https://api.github.com/repos/xtuple/qt-client/pulls{/number}","milestones_url":"https://api.github.com/repos/xtuple/qt-client/milestones{/number}","notifications_url":"https://api.github.com/repos/xtuple/qt-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xtuple/qt-client/labels{/name}","releases_url":"https://api.github.com/repos/xtuple/qt-client/releases{/id}","deployments_url":"https://api.github.com/repos/xtuple/qt-client/deployments","created_at":"2013-05-30T13:54:04Z","updated_at":"2016-06-23T01:37:51Z","pushed_at":"2016-06-24T15:24:49Z","git_url":"git://github.com/xtuple/qt-client.git","ssh_url":"git@github.com:xtuple/qt-client.git","clone_url":"https://github.com/xtuple/qt-client.git","svn_url":"https://github.com/xtuple/qt-client","homepage":"","size":111727,"stargazers_count":46,"watchers_count":46,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":132,"mirror_url":null,"open_issues_count":3,"forks":132,"open_issues":3,"watchers":46,"default_branch":"4_10_x"}},"_links":{"self":{"href":"https://api.github.com/repos/xtuple/qt-client/pulls/1278"},"html":{"href":"https://github.com/xtuple/qt-client/pull/1278"},"issue":{"href":"https://api.github.com/repos/xtuple/qt-client/issues/1278"},"comments":{"href":"https://api.github.com/repos/xtuple/qt-client/issues/1278/comments"},"review_comments":{"href":"https://api.github.com/repos/xtuple/qt-client/pulls/1278/comments"},"review_comment":{"href":"https://api.github.com/repos/xtuple/qt-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xtuple/qt-client/pulls/1278/commits"},"statuses":{"href":"https://api.github.com/repos/xtuple/qt-client/statuses/49acaf7abf73fc975d194eb9902c435901eaca3b"}}}}
{"actor":{"display_login":"davidbeauchamp"}}