{"action":"created","comment":{"url":"https://api.github.com/repos/apple/swift/pulls/comments/74694342","id":74694342,"diff_hunk":"@@ -1578,11 +1595,9 @@ bool TypeChecker::coerceParameterListToType(ParameterList *P, DeclContext *DC,\n   // The number of elements must match exactly.\n   // TODO: incomplete tuple patterns, with some syntax.\n   if (!hadError && tupleTy->getNumElements() != P->size()) {\n-    if (P->size() == 1)\n-      return handleParameter(P->get(0), paramListType);\n-    \n-    diagnose(P->getStartLoc(), diag::tuple_pattern_length_mismatch,\n-             paramListType);\n+    auto fnType = FunctionType::get(paramListType->getDesugaredType(), FN->getResult());\n+    diagnose(P->getStartLoc(), diag::closure_argument_list_tuple,\n+             fnType, tupleTy->getNumElements(), P->size(), (P->size() > 1));","path":"lib/Sema/TypeCheckPattern.cpp","position":55,"original_position":55,"commit_id":"c9ecb4420ded7d917d1fe32be5344b52f551c31b","original_commit_id":"c9ecb4420ded7d917d1fe32be5344b52f551c31b","user":{"login":"CodaFi","id":1896383,"avatar_url":"https://avatars.githubusercontent.com/u/1896383?v=3","gravatar_id":"","url":"https://api.github.com/users/CodaFi","html_url":"https://github.com/CodaFi","followers_url":"https://api.github.com/users/CodaFi/followers","following_url":"https://api.github.com/users/CodaFi/following{/other_user}","gists_url":"https://api.github.com/users/CodaFi/gists{/gist_id}","starred_url":"https://api.github.com/users/CodaFi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CodaFi/subscriptions","organizations_url":"https://api.github.com/users/CodaFi/orgs","repos_url":"https://api.github.com/users/CodaFi/repos","events_url":"https://api.github.com/users/CodaFi/events{/privacy}","received_events_url":"https://api.github.com/users/CodaFi/received_events","type":"User","site_admin":false},"body":"Just to be future-proof: Invert the select and make the `P->size() > 1` into `P->size() ==1` so we can report 0 in the (bizarre) plural correctly.","created_at":"2016-08-14T01:02:03Z","updated_at":"2016-08-14T01:02:03Z","html_url":"https://github.com/apple/swift/pull/4102#discussion_r74694342","pull_request_url":"https://api.github.com/repos/apple/swift/pulls/4102","_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/comments/74694342"},"html":{"href":"https://github.com/apple/swift/pull/4102#discussion_r74694342"},"pull_request":{"href":"https://api.github.com/repos/apple/swift/pulls/4102"}}},"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/4102","id":80456936,"html_url":"https://github.com/apple/swift/pull/4102","diff_url":"https://github.com/apple/swift/pull/4102.diff","patch_url":"https://github.com/apple/swift/pull/4102.patch","issue_url":"https://api.github.com/repos/apple/swift/issues/4102","number":4102,"state":"open","locked":false,"title":"[Sema] Implement SE-0110","user":{"login":"MnO2","id":64175,"avatar_url":"https://avatars.githubusercontent.com/u/64175?v=3","gravatar_id":"","url":"https://api.github.com/users/MnO2","html_url":"https://github.com/MnO2","followers_url":"https://api.github.com/users/MnO2/followers","following_url":"https://api.github.com/users/MnO2/following{/other_user}","gists_url":"https://api.github.com/users/MnO2/gists{/gist_id}","starred_url":"https://api.github.com/users/MnO2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MnO2/subscriptions","organizations_url":"https://api.github.com/users/MnO2/orgs","repos_url":"https://api.github.com/users/MnO2/repos","events_url":"https://api.github.com/users/MnO2/events{/privacy}","received_events_url":"https://api.github.com/users/MnO2/received_events","type":"User","site_admin":false},"body":"#### What's in this pull request?\r\n[Sema] Implement SE-0010\r\n\r\nThis commit built upon the work of Pull Request 3895 by @dduan. Apart from the work to make the following work\r\n\r\n```swift\r\nlet f: (Int, Int) -> Void = { x in  } // this is now an error\r\n```\r\n\r\nThis patch also implement the part 2 mentioned in the #3895\r\n\r\n```swift\r\nlet g: ((Int, Int)) -> Void = { y in  } // y should have type (Int, Int)\r\n```\r\n\r\n#### Resolved bug number: ([SR-2008](https://bugs.swift.org/browse/SR-2008))\r\n\r\n* * * *\r\n\r\n<!-- This selection should only be completed by Swift admin -->\r\nBefore merging this pull request to apple/swift repository:\r\n- [ ] Test pull request on Swift continuous integration.\r\n\r\n<details>\r\n  <summary>Triggering Swift CI</summary>\r\n\r\nThe swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:\r\n\r\n**Smoke Testing**\r\n\r\n        Platform     | Comment\r\n        ------------ | -------------\r\n        All supported platforms     | @swift-ci Please smoke test\r\n        All supported platforms     | @swift-ci Please smoke test and merge\r\n        OS X platform               | @swift-ci Please smoke test OS X platform\r\n        Linux platform              | @swift-ci Please smoke test Linux platform\r\n\r\nA smoke test on macOS does the following:\r\n\r\n1. Builds the compiler incrementally.\r\n2. Builds the standard library only for macOS. Simulator standard libraries and\r\n   device standard libraries are not built.\r\n3. lldb is not built.\r\n4. The test and validation-test targets are run only for macOS. The optimized\r\n   version of these tests are not run.\r\n\r\nA smoke test on Linux does the following:\r\n\r\n1. Builds the compiler incrementally.\r\n2. Builds the standard library incrementally.\r\n3. lldb is built incrementally.\r\n4. The swift test and validation-test targets are run. The optimized version of these\r\n   tests are not run.\r\n5. lldb is tested.\r\n\r\n**Validation Testing**\r\n\r\n        Platform     | Comment\r\n        ------------ | -------------\r\n        All supported platforms     | @swift-ci Please test\r\n        All supported platforms     | @swift-ci Please test and merge\r\n        OS X platform               | @swift-ci Please test OS X platform\r\n        OS X platform               | @swift-ci Please benchmark\r\n        Linux platform              | @swift-ci Please test Linux platform\r\n\r\n\r\n**Lint Testing**\r\n\r\n        Language     | Comment\r\n        ------------ | -------------\r\n        Python       | @swift-ci Please Python lint\r\n\r\nNote: Only members of the Apple organization can trigger swift-ci.\r\n</details>\r\n<!-- Thank you for your contribution to Swift! -->\r\n\r\nThis commit built upon the work of Pull Request 3895. Apart from the\r\nwork to make the following work\r\n\r\n```swift\r\nlet f: (Int, Int) -> Void = { x in  } // this is now an error\r\n```\r\n\r\nThis patch also implement the part 2 mentioned in the #3895\r\n\r\n```swift\r\nlet g: ((Int, Int)) -> Void = { y in  } // y should have type (Int, Int)\r\n```","created_at":"2016-08-08T14:06:47Z","updated_at":"2016-08-14T01:02:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b19c02a5c062472793c2b57e84aec94092ac9f67","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift/pulls/4102/commits","review_comments_url":"https://api.github.com/repos/apple/swift/pulls/4102/comments","review_comment_url":"https://api.github.com/repos/apple/swift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift/issues/4102/comments","statuses_url":"https://api.github.com/repos/apple/swift/statuses/c9ecb4420ded7d917d1fe32be5344b52f551c31b","head":{"label":"MnO2:master","ref":"master","sha":"c9ecb4420ded7d917d1fe32be5344b52f551c31b","user":{"login":"MnO2","id":64175,"avatar_url":"https://avatars.githubusercontent.com/u/64175?v=3","gravatar_id":"","url":"https://api.github.com/users/MnO2","html_url":"https://github.com/MnO2","followers_url":"https://api.github.com/users/MnO2/followers","following_url":"https://api.github.com/users/MnO2/following{/other_user}","gists_url":"https://api.github.com/users/MnO2/gists{/gist_id}","starred_url":"https://api.github.com/users/MnO2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MnO2/subscriptions","organizations_url":"https://api.github.com/users/MnO2/orgs","repos_url":"https://api.github.com/users/MnO2/repos","events_url":"https://api.github.com/users/MnO2/events{/privacy}","received_events_url":"https://api.github.com/users/MnO2/received_events","type":"User","site_admin":false},"repo":{"id":65026109,"name":"swift","full_name":"MnO2/swift","owner":{"login":"MnO2","id":64175,"avatar_url":"https://avatars.githubusercontent.com/u/64175?v=3","gravatar_id":"","url":"https://api.github.com/users/MnO2","html_url":"https://github.com/MnO2","followers_url":"https://api.github.com/users/MnO2/followers","following_url":"https://api.github.com/users/MnO2/following{/other_user}","gists_url":"https://api.github.com/users/MnO2/gists{/gist_id}","starred_url":"https://api.github.com/users/MnO2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MnO2/subscriptions","organizations_url":"https://api.github.com/users/MnO2/orgs","repos_url":"https://api.github.com/users/MnO2/repos","events_url":"https://api.github.com/users/MnO2/events{/privacy}","received_events_url":"https://api.github.com/users/MnO2/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MnO2/swift","description":"The Swift Programming Language","fork":true,"url":"https://api.github.com/repos/MnO2/swift","forks_url":"https://api.github.com/repos/MnO2/swift/forks","keys_url":"https://api.github.com/repos/MnO2/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MnO2/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MnO2/swift/teams","hooks_url":"https://api.github.com/repos/MnO2/swift/hooks","issue_events_url":"https://api.github.com/repos/MnO2/swift/issues/events{/number}","events_url":"https://api.github.com/repos/MnO2/swift/events","assignees_url":"https://api.github.com/repos/MnO2/swift/assignees{/user}","branches_url":"https://api.github.com/repos/MnO2/swift/branches{/branch}","tags_url":"https://api.github.com/repos/MnO2/swift/tags","blobs_url":"https://api.github.com/repos/MnO2/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MnO2/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MnO2/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/MnO2/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MnO2/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/MnO2/swift/languages","stargazers_url":"https://api.github.com/repos/MnO2/swift/stargazers","contributors_url":"https://api.github.com/repos/MnO2/swift/contributors","subscribers_url":"https://api.github.com/repos/MnO2/swift/subscribers","subscription_url":"https://api.github.com/repos/MnO2/swift/subscription","commits_url":"https://api.github.com/repos/MnO2/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/MnO2/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/MnO2/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/MnO2/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/MnO2/swift/contents/{+path}","compare_url":"https://api.github.com/repos/MnO2/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MnO2/swift/merges","archive_url":"https://api.github.com/repos/MnO2/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MnO2/swift/downloads","issues_url":"https://api.github.com/repos/MnO2/swift/issues{/number}","pulls_url":"https://api.github.com/repos/MnO2/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/MnO2/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/MnO2/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MnO2/swift/labels{/name}","releases_url":"https://api.github.com/repos/MnO2/swift/releases{/id}","deployments_url":"https://api.github.com/repos/MnO2/swift/deployments","created_at":"2016-08-05T14:43:48Z","updated_at":"2016-08-05T14:44:12Z","pushed_at":"2016-08-13T16:25:04Z","git_url":"git://github.com/MnO2/swift.git","ssh_url":"git@github.com:MnO2/swift.git","clone_url":"https://github.com/MnO2/swift.git","svn_url":"https://github.com/MnO2/swift","homepage":"https://swift.org/","size":114907,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apple:master","ref":"master","sha":"c8fbfb782e8a1d92b77cef3ffde86677385095d4","user":{"login":"apple","id":10639145,"avatar_url":"https://avatars.githubusercontent.com/u/10639145?v=3","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":44838949,"name":"swift","full_name":"apple/swift","owner":{"login":"apple","id":10639145,"avatar_url":"https://avatars.githubusercontent.com/u/10639145?v=3","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apple/swift","description":"The Swift Programming Language","fork":false,"url":"https://api.github.com/repos/apple/swift","forks_url":"https://api.github.com/repos/apple/swift/forks","keys_url":"https://api.github.com/repos/apple/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift/teams","hooks_url":"https://api.github.com/repos/apple/swift/hooks","issue_events_url":"https://api.github.com/repos/apple/swift/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift/events","assignees_url":"https://api.github.com/repos/apple/swift/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift/tags","blobs_url":"https://api.github.com/repos/apple/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift/languages","stargazers_url":"https://api.github.com/repos/apple/swift/stargazers","contributors_url":"https://api.github.com/repos/apple/swift/contributors","subscribers_url":"https://api.github.com/repos/apple/swift/subscribers","subscription_url":"https://api.github.com/repos/apple/swift/subscription","commits_url":"https://api.github.com/repos/apple/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift/merges","archive_url":"https://api.github.com/repos/apple/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift/downloads","issues_url":"https://api.github.com/repos/apple/swift/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift/deployments","created_at":"2015-10-23T21:15:07Z","updated_at":"2016-08-13T23:59:55Z","pushed_at":"2016-08-14T00:57:09Z","git_url":"git://github.com/apple/swift.git","ssh_url":"git@github.com:apple/swift.git","clone_url":"https://github.com/apple/swift.git","svn_url":"https://github.com/apple/swift","homepage":"https://swift.org/","size":174692,"stargazers_count":33152,"watchers_count":33152,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4651,"mirror_url":null,"open_issues_count":87,"forks":4651,"open_issues":87,"watchers":33152,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/4102"},"html":{"href":"https://github.com/apple/swift/pull/4102"},"issue":{"href":"https://api.github.com/repos/apple/swift/issues/4102"},"comments":{"href":"https://api.github.com/repos/apple/swift/issues/4102/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift/pulls/4102/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift/pulls/4102/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift/statuses/c9ecb4420ded7d917d1fe32be5344b52f551c31b"}}}}
{"actor":{"display_login":"CodaFi"}}