{"action":"created","comment":{"url":"https://api.github.com/repos/tangrams/eraser-map/pulls/comments/48914641","id":48914641,"diff_hunk":"@@ -1624,7 +1620,7 @@ layers:\n                         outline:\n                             color: [0.827,0.827,0.827]\n                             # todo: look at zoom 13 width\n-                            width: [[12, 0px], [13, 0px], [14, 0px], [15, 0px], [16, 1.0px], [18, 3.5px]]\n+                            width: [[15, 0], [16, 1.0px], [18, 3.5px]]","path":"eraser-map.yaml","position":79,"original_position":79,"commit_id":"52dad731ae317952ff18debf16b9877d657ff51c","original_commit_id":"52dad731ae317952ff18debf16b9877d657ff51c","user":{"login":"nvkelso","id":853051,"avatar_url":"https://avatars.githubusercontent.com/u/853051?v=3","gravatar_id":"","url":"https://api.github.com/users/nvkelso","html_url":"https://github.com/nvkelso","followers_url":"https://api.github.com/users/nvkelso/followers","following_url":"https://api.github.com/users/nvkelso/following{/other_user}","gists_url":"https://api.github.com/users/nvkelso/gists{/gist_id}","starred_url":"https://api.github.com/users/nvkelso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nvkelso/subscriptions","organizations_url":"https://api.github.com/users/nvkelso/orgs","repos_url":"https://api.github.com/users/nvkelso/repos","events_url":"https://api.github.com/users/nvkelso/events{/privacy}","received_events_url":"https://api.github.com/users/nvkelso/received_events","type":"User","site_admin":false},"body":"We use px everywhere else but here:\r\n\r\n[[15, 0px],","created_at":"2016-01-06T00:18:33Z","updated_at":"2016-01-06T00:18:33Z","html_url":"https://github.com/tangrams/eraser-map/pull/132#discussion_r48914641","pull_request_url":"https://api.github.com/repos/tangrams/eraser-map/pulls/132","_links":{"self":{"href":"https://api.github.com/repos/tangrams/eraser-map/pulls/comments/48914641"},"html":{"href":"https://github.com/tangrams/eraser-map/pull/132#discussion_r48914641"},"pull_request":{"href":"https://api.github.com/repos/tangrams/eraser-map/pulls/132"}}},"pull_request":{"url":"https://api.github.com/repos/tangrams/eraser-map/pulls/132","id":55155737,"html_url":"https://github.com/tangrams/eraser-map/pull/132","diff_url":"https://github.com/tangrams/eraser-map/pull/132.diff","patch_url":"https://github.com/tangrams/eraser-map/pull/132.patch","issue_url":"https://api.github.com/repos/tangrams/eraser-map/issues/132","number":132,"state":"open","locked":false,"title":"Reduce outlines with minimal visual impact","user":{"login":"bcamper","id":16733,"avatar_url":"https://avatars.githubusercontent.com/u/16733?v=3","gravatar_id":"","url":"https://api.github.com/users/bcamper","html_url":"https://github.com/bcamper","followers_url":"https://api.github.com/users/bcamper/followers","following_url":"https://api.github.com/users/bcamper/following{/other_user}","gists_url":"https://api.github.com/users/bcamper/gists{/gist_id}","starred_url":"https://api.github.com/users/bcamper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcamper/subscriptions","organizations_url":"https://api.github.com/users/bcamper/orgs","repos_url":"https://api.github.com/users/bcamper/repos","events_url":"https://api.github.com/users/bcamper/events{/privacy}","received_events_url":"https://api.github.com/users/bcamper/received_events","type":"User","site_admin":false},"body":"I've found that there are a lot of reaaaally thin outlines that had minimal (practically imperceptible) visual contribution to the scene. particularly at some lower zooms. By slightly cutting down on these (introducing them a bit later), we can get some substantial geometry count / performance benefits. This PR also includes a few syntax clean-ups done while reviewing outlines, such as removing redundant zoom stops (e.g. `[9, 0.0px], [11, 0px], [12, 0px], [14, 0px]` becomes just `[14, 0px]`). Examples below. These are fairly conservative, with a more intentional design eye we could probably cut them down further.\r\n\r\n**z8**: 277k -> 209k polys (**-68k polys**)\r\n![z8](https://cloud.githubusercontent.com/assets/16733/12130052/b3351708-b3d5-11e5-83cb-e35396c06efb.gif)\r\n\r\n**z9**: 435k -> 399k polys (**-36k polys**)\r\n![z9](https://cloud.githubusercontent.com/assets/16733/12130053/b3366982-b3d5-11e5-8796-040fb387bbec.gif)\r\n\r\n**z10**: 285k -> 267k polys (**-18k polys**)\r\n![z10](https://cloud.githubusercontent.com/assets/16733/12130050/b3345566-b3d5-11e5-866a-af70d9cecec1.gif)\r\n\r\n**z11**: 194k -> 182k polys (**-12k polys**)\r\n![z11](https://cloud.githubusercontent.com/assets/16733/12130054/b3367328-b3d5-11e5-9904-22d512b5e953.gif)\r\n\r\n**z12**: 251k -> 247k polys (**-4k polys**)\r\n![z12](https://cloud.githubusercontent.com/assets/16733/12130051/b334d73e-b3d5-11e5-87a7-fa98fc7caefe.gif)","created_at":"2016-01-05T23:02:04Z","updated_at":"2016-01-06T00:18:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e14ba48cda5a24ca096dc542ce7de0999ce14896","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/tangrams/eraser-map/pulls/132/commits","review_comments_url":"https://api.github.com/repos/tangrams/eraser-map/pulls/132/comments","review_comment_url":"https://api.github.com/repos/tangrams/eraser-map/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tangrams/eraser-map/issues/132/comments","statuses_url":"https://api.github.com/repos/tangrams/eraser-map/statuses/52dad731ae317952ff18debf16b9877d657ff51c","head":{"label":"tangrams:cull-outlines","ref":"cull-outlines","sha":"52dad731ae317952ff18debf16b9877d657ff51c","user":{"login":"tangrams","id":8495302,"avatar_url":"https://avatars.githubusercontent.com/u/8495302?v=3","gravatar_id":"","url":"https://api.github.com/users/tangrams","html_url":"https://github.com/tangrams","followers_url":"https://api.github.com/users/tangrams/followers","following_url":"https://api.github.com/users/tangrams/following{/other_user}","gists_url":"https://api.github.com/users/tangrams/gists{/gist_id}","starred_url":"https://api.github.com/users/tangrams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tangrams/subscriptions","organizations_url":"https://api.github.com/users/tangrams/orgs","repos_url":"https://api.github.com/users/tangrams/repos","events_url":"https://api.github.com/users/tangrams/events{/privacy}","received_events_url":"https://api.github.com/users/tangrams/received_events","type":"Organization","site_admin":false},"repo":{"id":42327421,"name":"eraser-map","full_name":"tangrams/eraser-map","owner":{"login":"tangrams","id":8495302,"avatar_url":"https://avatars.githubusercontent.com/u/8495302?v=3","gravatar_id":"","url":"https://api.github.com/users/tangrams","html_url":"https://github.com/tangrams","followers_url":"https://api.github.com/users/tangrams/followers","following_url":"https://api.github.com/users/tangrams/following{/other_user}","gists_url":"https://api.github.com/users/tangrams/gists{/gist_id}","starred_url":"https://api.github.com/users/tangrams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tangrams/subscriptions","organizations_url":"https://api.github.com/users/tangrams/orgs","repos_url":"https://api.github.com/users/tangrams/repos","events_url":"https://api.github.com/users/tangrams/events{/privacy}","received_events_url":"https://api.github.com/users/tangrams/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tangrams/eraser-map","description":"Basemap style for Eraser Map app","fork":false,"url":"https://api.github.com/repos/tangrams/eraser-map","forks_url":"https://api.github.com/repos/tangrams/eraser-map/forks","keys_url":"https://api.github.com/repos/tangrams/eraser-map/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tangrams/eraser-map/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tangrams/eraser-map/teams","hooks_url":"https://api.github.com/repos/tangrams/eraser-map/hooks","issue_events_url":"https://api.github.com/repos/tangrams/eraser-map/issues/events{/number}","events_url":"https://api.github.com/repos/tangrams/eraser-map/events","assignees_url":"https://api.github.com/repos/tangrams/eraser-map/assignees{/user}","branches_url":"https://api.github.com/repos/tangrams/eraser-map/branches{/branch}","tags_url":"https://api.github.com/repos/tangrams/eraser-map/tags","blobs_url":"https://api.github.com/repos/tangrams/eraser-map/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tangrams/eraser-map/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tangrams/eraser-map/git/refs{/sha}","trees_url":"https://api.github.com/repos/tangrams/eraser-map/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tangrams/eraser-map/statuses/{sha}","languages_url":"https://api.github.com/repos/tangrams/eraser-map/languages","stargazers_url":"https://api.github.com/repos/tangrams/eraser-map/stargazers","contributors_url":"https://api.github.com/repos/tangrams/eraser-map/contributors","subscribers_url":"https://api.github.com/repos/tangrams/eraser-map/subscribers","subscription_url":"https://api.github.com/repos/tangrams/eraser-map/subscription","commits_url":"https://api.github.com/repos/tangrams/eraser-map/commits{/sha}","git_commits_url":"https://api.github.com/repos/tangrams/eraser-map/git/commits{/sha}","comments_url":"https://api.github.com/repos/tangrams/eraser-map/comments{/number}","issue_comment_url":"https://api.github.com/repos/tangrams/eraser-map/issues/comments{/number}","contents_url":"https://api.github.com/repos/tangrams/eraser-map/contents/{+path}","compare_url":"https://api.github.com/repos/tangrams/eraser-map/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tangrams/eraser-map/merges","archive_url":"https://api.github.com/repos/tangrams/eraser-map/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tangrams/eraser-map/downloads","issues_url":"https://api.github.com/repos/tangrams/eraser-map/issues{/number}","pulls_url":"https://api.github.com/repos/tangrams/eraser-map/pulls{/number}","milestones_url":"https://api.github.com/repos/tangrams/eraser-map/milestones{/number}","notifications_url":"https://api.github.com/repos/tangrams/eraser-map/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tangrams/eraser-map/labels{/name}","releases_url":"https://api.github.com/repos/tangrams/eraser-map/releases{/id}","created_at":"2015-09-11T19:11:33Z","updated_at":"2015-12-15T19:38:02Z","pushed_at":"2016-01-05T23:02:04Z","git_url":"git://github.com/tangrams/eraser-map.git","ssh_url":"git@github.com:tangrams/eraser-map.git","clone_url":"https://github.com/tangrams/eraser-map.git","svn_url":"https://github.com/tangrams/eraser-map","homepage":"http://tangrams.github.io/eraser-map/","size":5154,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":38,"forks":1,"open_issues":38,"watchers":3,"default_branch":"gh-pages"}},"base":{"label":"tangrams:gh-pages","ref":"gh-pages","sha":"fb695bf8de92d22054d6fa4c863b26cf78b48c58","user":{"login":"tangrams","id":8495302,"avatar_url":"https://avatars.githubusercontent.com/u/8495302?v=3","gravatar_id":"","url":"https://api.github.com/users/tangrams","html_url":"https://github.com/tangrams","followers_url":"https://api.github.com/users/tangrams/followers","following_url":"https://api.github.com/users/tangrams/following{/other_user}","gists_url":"https://api.github.com/users/tangrams/gists{/gist_id}","starred_url":"https://api.github.com/users/tangrams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tangrams/subscriptions","organizations_url":"https://api.github.com/users/tangrams/orgs","repos_url":"https://api.github.com/users/tangrams/repos","events_url":"https://api.github.com/users/tangrams/events{/privacy}","received_events_url":"https://api.github.com/users/tangrams/received_events","type":"Organization","site_admin":false},"repo":{"id":42327421,"name":"eraser-map","full_name":"tangrams/eraser-map","owner":{"login":"tangrams","id":8495302,"avatar_url":"https://avatars.githubusercontent.com/u/8495302?v=3","gravatar_id":"","url":"https://api.github.com/users/tangrams","html_url":"https://github.com/tangrams","followers_url":"https://api.github.com/users/tangrams/followers","following_url":"https://api.github.com/users/tangrams/following{/other_user}","gists_url":"https://api.github.com/users/tangrams/gists{/gist_id}","starred_url":"https://api.github.com/users/tangrams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tangrams/subscriptions","organizations_url":"https://api.github.com/users/tangrams/orgs","repos_url":"https://api.github.com/users/tangrams/repos","events_url":"https://api.github.com/users/tangrams/events{/privacy}","received_events_url":"https://api.github.com/users/tangrams/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tangrams/eraser-map","description":"Basemap style for Eraser Map app","fork":false,"url":"https://api.github.com/repos/tangrams/eraser-map","forks_url":"https://api.github.com/repos/tangrams/eraser-map/forks","keys_url":"https://api.github.com/repos/tangrams/eraser-map/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tangrams/eraser-map/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tangrams/eraser-map/teams","hooks_url":"https://api.github.com/repos/tangrams/eraser-map/hooks","issue_events_url":"https://api.github.com/repos/tangrams/eraser-map/issues/events{/number}","events_url":"https://api.github.com/repos/tangrams/eraser-map/events","assignees_url":"https://api.github.com/repos/tangrams/eraser-map/assignees{/user}","branches_url":"https://api.github.com/repos/tangrams/eraser-map/branches{/branch}","tags_url":"https://api.github.com/repos/tangrams/eraser-map/tags","blobs_url":"https://api.github.com/repos/tangrams/eraser-map/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tangrams/eraser-map/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tangrams/eraser-map/git/refs{/sha}","trees_url":"https://api.github.com/repos/tangrams/eraser-map/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tangrams/eraser-map/statuses/{sha}","languages_url":"https://api.github.com/repos/tangrams/eraser-map/languages","stargazers_url":"https://api.github.com/repos/tangrams/eraser-map/stargazers","contributors_url":"https://api.github.com/repos/tangrams/eraser-map/contributors","subscribers_url":"https://api.github.com/repos/tangrams/eraser-map/subscribers","subscription_url":"https://api.github.com/repos/tangrams/eraser-map/subscription","commits_url":"https://api.github.com/repos/tangrams/eraser-map/commits{/sha}","git_commits_url":"https://api.github.com/repos/tangrams/eraser-map/git/commits{/sha}","comments_url":"https://api.github.com/repos/tangrams/eraser-map/comments{/number}","issue_comment_url":"https://api.github.com/repos/tangrams/eraser-map/issues/comments{/number}","contents_url":"https://api.github.com/repos/tangrams/eraser-map/contents/{+path}","compare_url":"https://api.github.com/repos/tangrams/eraser-map/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tangrams/eraser-map/merges","archive_url":"https://api.github.com/repos/tangrams/eraser-map/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tangrams/eraser-map/downloads","issues_url":"https://api.github.com/repos/tangrams/eraser-map/issues{/number}","pulls_url":"https://api.github.com/repos/tangrams/eraser-map/pulls{/number}","milestones_url":"https://api.github.com/repos/tangrams/eraser-map/milestones{/number}","notifications_url":"https://api.github.com/repos/tangrams/eraser-map/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tangrams/eraser-map/labels{/name}","releases_url":"https://api.github.com/repos/tangrams/eraser-map/releases{/id}","created_at":"2015-09-11T19:11:33Z","updated_at":"2015-12-15T19:38:02Z","pushed_at":"2016-01-05T23:02:04Z","git_url":"git://github.com/tangrams/eraser-map.git","ssh_url":"git@github.com:tangrams/eraser-map.git","clone_url":"https://github.com/tangrams/eraser-map.git","svn_url":"https://github.com/tangrams/eraser-map","homepage":"http://tangrams.github.io/eraser-map/","size":5154,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":38,"forks":1,"open_issues":38,"watchers":3,"default_branch":"gh-pages"}},"_links":{"self":{"href":"https://api.github.com/repos/tangrams/eraser-map/pulls/132"},"html":{"href":"https://github.com/tangrams/eraser-map/pull/132"},"issue":{"href":"https://api.github.com/repos/tangrams/eraser-map/issues/132"},"comments":{"href":"https://api.github.com/repos/tangrams/eraser-map/issues/132/comments"},"review_comments":{"href":"https://api.github.com/repos/tangrams/eraser-map/pulls/132/comments"},"review_comment":{"href":"https://api.github.com/repos/tangrams/eraser-map/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tangrams/eraser-map/pulls/132/commits"},"statuses":{"href":"https://api.github.com/repos/tangrams/eraser-map/statuses/52dad731ae317952ff18debf16b9877d657ff51c"}}}}