{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/react-native/issues/11136","repository_url":"https://api.github.com/repos/facebook/react-native","labels_url":"https://api.github.com/repos/facebook/react-native/issues/11136/labels{/name}","comments_url":"https://api.github.com/repos/facebook/react-native/issues/11136/comments","events_url":"https://api.github.com/repos/facebook/react-native/issues/11136/events","html_url":"https://github.com/facebook/react-native/pull/11136","id":191739184,"number":11136,"title":"Adds `touchSoundEnabled` prop to Touchables","user":{"login":"doomsower","id":12031673,"avatar_url":"https://avatars.githubusercontent.com/u/12031673?v=3","gravatar_id":"","url":"https://api.github.com/users/doomsower","html_url":"https://github.com/doomsower","followers_url":"https://api.github.com/users/doomsower/followers","following_url":"https://api.github.com/users/doomsower/following{/other_user}","gists_url":"https://api.github.com/users/doomsower/gists{/gist_id}","starred_url":"https://api.github.com/users/doomsower/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doomsower/subscriptions","organizations_url":"https://api.github.com/users/doomsower/orgs","repos_url":"https://api.github.com/users/doomsower/repos","events_url":"https://api.github.com/users/doomsower/events{/privacy}","received_events_url":"https://api.github.com/users/doomsower/received_events","type":"User","site_admin":false},"labels":[{"id":196858975,"url":"https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed","name":"CLA Signed","color":"e7e7e7","default":false},{"id":172176599,"url":"https://api.github.com/repos/facebook/react-native/labels/GH%20Review:%20review-needed","name":"GH Review: review-needed","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-11-25T16:48:37Z","updated_at":"2016-11-28T10:40:32Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/facebook/react-native/pulls/11136","html_url":"https://github.com/facebook/react-native/pull/11136","diff_url":"https://github.com/facebook/react-native/pull/11136.diff","patch_url":"https://github.com/facebook/react-native/pull/11136.patch"},"body":"This PR addresses issue #6188\r\nIt allows touchables to play system default sound when touched, and adds a prop to control this behavior (off by default)\r\nIt also allows to play default touch sound by calling `UIManager.playTouchSound()`, which can be used manually in gesture responders.\r\n\r\n**Test plan (required)**\r\n\r\nTested this manually on following code fragment on both iOS and Android physical devices:\r\n```\r\n        <TouchableOpacity onPress={this.handlePress.bind(this, 'button')} touchSoundEnabled={true}>\r\n          <View style={styles.btn}>\r\n            <Text>Button</Text>\r\n          </View>\r\n        </TouchableOpacity>\r\n        <Text style={styles.instructions} onPress={this.handlePress.bind(this, 'text2')}>\r\n          <Text onPress={this.handlePress.bind(this, 'nested1')}>link</Text>\r\n          {' text '}\r\n          <Text onPress={this.handlePress.bind(this, 'nested2')} touchSoundEnabled={true}>link</Text>\r\n        </Text>\r\n``` "},"comment":{"url":"https://api.github.com/repos/facebook/react-native/issues/comments/263238668","html_url":"https://github.com/facebook/react-native/pull/11136#issuecomment-263238668","issue_url":"https://api.github.com/repos/facebook/react-native/issues/11136","id":263238668,"user":{"login":"mkonicek","id":346214,"avatar_url":"https://avatars.githubusercontent.com/u/346214?v=3","gravatar_id":"","url":"https://api.github.com/users/mkonicek","html_url":"https://github.com/mkonicek","followers_url":"https://api.github.com/users/mkonicek/followers","following_url":"https://api.github.com/users/mkonicek/following{/other_user}","gists_url":"https://api.github.com/users/mkonicek/gists{/gist_id}","starred_url":"https://api.github.com/users/mkonicek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkonicek/subscriptions","organizations_url":"https://api.github.com/users/mkonicek/orgs","repos_url":"https://api.github.com/users/mkonicek/repos","events_url":"https://api.github.com/users/mkonicek/events{/privacy}","received_events_url":"https://api.github.com/users/mkonicek/received_events","type":"User","site_admin":false},"created_at":"2016-11-28T10:40:32Z","updated_at":"2016-11-28T10:40:32Z","body":"Check Brent's question:\r\n\r\n> is this actually doing anything on Text?"}}
{"actor":{"display_login":"mkonicek"}}