{"action":"created","comment":{"url":"https://api.github.com/repos/livecode/livecode/pulls/comments/75445725","id":75445725,"diff_hunk":"@@ -412,8 +412,13 @@ MCButton::~MCButton()\n \n void MCButton::removelink(MCObject *optr)\n {\n-\tif (optr == menu)\n+\tif (menu.IsValid() && optr == menu)\n+    {\n+        MCValueRelease(menuname);\n+        menuname = MCValueRetain(kMCEmptyName);","path":"engine/src/button.cpp","position":8,"original_position":8,"commit_id":"c4738b17733002313071bea04204bf26c121d958","original_commit_id":"c4738b17733002313071bea04204bf26c121d958","user":{"login":"livecodeali","id":3985854,"avatar_url":"https://avatars.githubusercontent.com/u/3985854?v=3","gravatar_id":"","url":"https://api.github.com/users/livecodeali","html_url":"https://github.com/livecodeali","followers_url":"https://api.github.com/users/livecodeali/followers","following_url":"https://api.github.com/users/livecodeali/following{/other_user}","gists_url":"https://api.github.com/users/livecodeali/gists{/gist_id}","starred_url":"https://api.github.com/users/livecodeali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/livecodeali/subscriptions","organizations_url":"https://api.github.com/users/livecodeali/orgs","repos_url":"https://api.github.com/users/livecodeali/repos","events_url":"https://api.github.com/users/livecodeali/events{/privacy}","received_events_url":"https://api.github.com/users/livecodeali/received_events","type":"User","site_admin":false},"body":"You can just use `MCValueAssign` here","created_at":"2016-08-19T08:36:39Z","updated_at":"2016-08-19T08:36:39Z","html_url":"https://github.com/livecode/livecode/pull/4392#discussion_r75445725","pull_request_url":"https://api.github.com/repos/livecode/livecode/pulls/4392","_links":{"self":{"href":"https://api.github.com/repos/livecode/livecode/pulls/comments/75445725"},"html":{"href":"https://github.com/livecode/livecode/pull/4392#discussion_r75445725"},"pull_request":{"href":"https://api.github.com/repos/livecode/livecode/pulls/4392"}}},"pull_request":{"url":"https://api.github.com/repos/livecode/livecode/pulls/4392","id":81725525,"html_url":"https://github.com/livecode/livecode/pull/4392","diff_url":"https://github.com/livecode/livecode/pull/4392.diff","patch_url":"https://github.com/livecode/livecode/pull/4392.patch","issue_url":"https://api.github.com/repos/livecode/livecode/issues/4392","number":4392,"state":"open","locked":false,"title":"[[ ButtonMenuObjectHandle ]] Use MCObjectHandle for button menu","user":{"login":"montegoulding","id":351144,"avatar_url":"https://avatars.githubusercontent.com/u/351144?v=3","gravatar_id":"","url":"https://api.github.com/users/montegoulding","html_url":"https://github.com/montegoulding","followers_url":"https://api.github.com/users/montegoulding/followers","following_url":"https://api.github.com/users/montegoulding/following{/other_user}","gists_url":"https://api.github.com/users/montegoulding/gists{/gist_id}","starred_url":"https://api.github.com/users/montegoulding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/montegoulding/subscriptions","organizations_url":"https://api.github.com/users/montegoulding/orgs","repos_url":"https://api.github.com/users/montegoulding/repos","events_url":"https://api.github.com/users/montegoulding/events{/privacy}","received_events_url":"https://api.github.com/users/montegoulding/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-08-17T22:05:58Z","updated_at":"2016-08-19T08:36:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fab6af6c68e72af0e0d9bab9664f7523e291d0d9","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/livecode/livecode/milestones/115","html_url":"https://github.com/livecode/livecode/milestones/8.1.0-rc-1","labels_url":"https://api.github.com/repos/livecode/livecode/milestones/115/labels","id":1911937,"number":115,"title":"8.1.0-rc-1","description":"","creator":{"login":"livecodeali","id":3985854,"avatar_url":"https://avatars.githubusercontent.com/u/3985854?v=3","gravatar_id":"","url":"https://api.github.com/users/livecodeali","html_url":"https://github.com/livecodeali","followers_url":"https://api.github.com/users/livecodeali/followers","following_url":"https://api.github.com/users/livecodeali/following{/other_user}","gists_url":"https://api.github.com/users/livecodeali/gists{/gist_id}","starred_url":"https://api.github.com/users/livecodeali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/livecodeali/subscriptions","organizations_url":"https://api.github.com/users/livecodeali/orgs","repos_url":"https://api.github.com/users/livecodeali/repos","events_url":"https://api.github.com/users/livecodeali/events{/privacy}","received_events_url":"https://api.github.com/users/livecodeali/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":71,"state":"open","created_at":"2016-07-29T15:44:17Z","updated_at":"2016-08-18T20:02:06Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/livecode/livecode/pulls/4392/commits","review_comments_url":"https://api.github.com/repos/livecode/livecode/pulls/4392/comments","review_comment_url":"https://api.github.com/repos/livecode/livecode/pulls/comments{/number}","comments_url":"https://api.github.com/repos/livecode/livecode/issues/4392/comments","statuses_url":"https://api.github.com/repos/livecode/livecode/statuses/c4738b17733002313071bea04204bf26c121d958","head":{"label":"montegoulding:menucrash","ref":"menucrash","sha":"c4738b17733002313071bea04204bf26c121d958","user":{"login":"montegoulding","id":351144,"avatar_url":"https://avatars.githubusercontent.com/u/351144?v=3","gravatar_id":"","url":"https://api.github.com/users/montegoulding","html_url":"https://github.com/montegoulding","followers_url":"https://api.github.com/users/montegoulding/followers","following_url":"https://api.github.com/users/montegoulding/following{/other_user}","gists_url":"https://api.github.com/users/montegoulding/gists{/gist_id}","starred_url":"https://api.github.com/users/montegoulding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/montegoulding/subscriptions","organizations_url":"https://api.github.com/users/montegoulding/orgs","repos_url":"https://api.github.com/users/montegoulding/repos","events_url":"https://api.github.com/users/montegoulding/events{/privacy}","received_events_url":"https://api.github.com/users/montegoulding/received_events","type":"User","site_admin":false},"repo":{"id":9335660,"name":"livecode","full_name":"montegoulding/livecode","owner":{"login":"montegoulding","id":351144,"avatar_url":"https://avatars.githubusercontent.com/u/351144?v=3","gravatar_id":"","url":"https://api.github.com/users/montegoulding","html_url":"https://github.com/montegoulding","followers_url":"https://api.github.com/users/montegoulding/followers","following_url":"https://api.github.com/users/montegoulding/following{/other_user}","gists_url":"https://api.github.com/users/montegoulding/gists{/gist_id}","starred_url":"https://api.github.com/users/montegoulding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/montegoulding/subscriptions","organizations_url":"https://api.github.com/users/montegoulding/orgs","repos_url":"https://api.github.com/users/montegoulding/repos","events_url":"https://api.github.com/users/montegoulding/events{/privacy}","received_events_url":"https://api.github.com/users/montegoulding/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/montegoulding/livecode","description":"","fork":true,"url":"https://api.github.com/repos/montegoulding/livecode","forks_url":"https://api.github.com/repos/montegoulding/livecode/forks","keys_url":"https://api.github.com/repos/montegoulding/livecode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/montegoulding/livecode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/montegoulding/livecode/teams","hooks_url":"https://api.github.com/repos/montegoulding/livecode/hooks","issue_events_url":"https://api.github.com/repos/montegoulding/livecode/issues/events{/number}","events_url":"https://api.github.com/repos/montegoulding/livecode/events","assignees_url":"https://api.github.com/repos/montegoulding/livecode/assignees{/user}","branches_url":"https://api.github.com/repos/montegoulding/livecode/branches{/branch}","tags_url":"https://api.github.com/repos/montegoulding/livecode/tags","blobs_url":"https://api.github.com/repos/montegoulding/livecode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/montegoulding/livecode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/montegoulding/livecode/git/refs{/sha}","trees_url":"https://api.github.com/repos/montegoulding/livecode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/montegoulding/livecode/statuses/{sha}","languages_url":"https://api.github.com/repos/montegoulding/livecode/languages","stargazers_url":"https://api.github.com/repos/montegoulding/livecode/stargazers","contributors_url":"https://api.github.com/repos/montegoulding/livecode/contributors","subscribers_url":"https://api.github.com/repos/montegoulding/livecode/subscribers","subscription_url":"https://api.github.com/repos/montegoulding/livecode/subscription","commits_url":"https://api.github.com/repos/montegoulding/livecode/commits{/sha}","git_commits_url":"https://api.github.com/repos/montegoulding/livecode/git/commits{/sha}","comments_url":"https://api.github.com/repos/montegoulding/livecode/comments{/number}","issue_comment_url":"https://api.github.com/repos/montegoulding/livecode/issues/comments{/number}","contents_url":"https://api.github.com/repos/montegoulding/livecode/contents/{+path}","compare_url":"https://api.github.com/repos/montegoulding/livecode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/montegoulding/livecode/merges","archive_url":"https://api.github.com/repos/montegoulding/livecode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/montegoulding/livecode/downloads","issues_url":"https://api.github.com/repos/montegoulding/livecode/issues{/number}","pulls_url":"https://api.github.com/repos/montegoulding/livecode/pulls{/number}","milestones_url":"https://api.github.com/repos/montegoulding/livecode/milestones{/number}","notifications_url":"https://api.github.com/repos/montegoulding/livecode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/montegoulding/livecode/labels{/name}","releases_url":"https://api.github.com/repos/montegoulding/livecode/releases{/id}","deployments_url":"https://api.github.com/repos/montegoulding/livecode/deployments","created_at":"2013-04-10T01:45:36Z","updated_at":"2014-09-12T04:52:48Z","pushed_at":"2016-08-18T11:26:11Z","git_url":"git://github.com/montegoulding/livecode.git","ssh_url":"git@github.com:montegoulding/livecode.git","clone_url":"https://github.com/montegoulding/livecode.git","svn_url":"https://github.com/montegoulding/livecode","homepage":null,"size":120384,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"livecode:develop","ref":"develop","sha":"768e5f6b23e053f48e67dc18c1f41081f0d9e40f","user":{"login":"livecode","id":3985749,"avatar_url":"https://avatars.githubusercontent.com/u/3985749?v=3","gravatar_id":"","url":"https://api.github.com/users/livecode","html_url":"https://github.com/livecode","followers_url":"https://api.github.com/users/livecode/followers","following_url":"https://api.github.com/users/livecode/following{/other_user}","gists_url":"https://api.github.com/users/livecode/gists{/gist_id}","starred_url":"https://api.github.com/users/livecode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/livecode/subscriptions","organizations_url":"https://api.github.com/users/livecode/orgs","repos_url":"https://api.github.com/users/livecode/repos","events_url":"https://api.github.com/users/livecode/events{/privacy}","received_events_url":"https://api.github.com/users/livecode/received_events","type":"Organization","site_admin":false},"repo":{"id":9334445,"name":"livecode","full_name":"livecode/livecode","owner":{"login":"livecode","id":3985749,"avatar_url":"https://avatars.githubusercontent.com/u/3985749?v=3","gravatar_id":"","url":"https://api.github.com/users/livecode","html_url":"https://github.com/livecode","followers_url":"https://api.github.com/users/livecode/followers","following_url":"https://api.github.com/users/livecode/following{/other_user}","gists_url":"https://api.github.com/users/livecode/gists{/gist_id}","starred_url":"https://api.github.com/users/livecode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/livecode/subscriptions","organizations_url":"https://api.github.com/users/livecode/orgs","repos_url":"https://api.github.com/users/livecode/repos","events_url":"https://api.github.com/users/livecode/events{/privacy}","received_events_url":"https://api.github.com/users/livecode/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/livecode/livecode","description":"LiveCode cross-platform development environment (engine)","fork":false,"url":"https://api.github.com/repos/livecode/livecode","forks_url":"https://api.github.com/repos/livecode/livecode/forks","keys_url":"https://api.github.com/repos/livecode/livecode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/livecode/livecode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/livecode/livecode/teams","hooks_url":"https://api.github.com/repos/livecode/livecode/hooks","issue_events_url":"https://api.github.com/repos/livecode/livecode/issues/events{/number}","events_url":"https://api.github.com/repos/livecode/livecode/events","assignees_url":"https://api.github.com/repos/livecode/livecode/assignees{/user}","branches_url":"https://api.github.com/repos/livecode/livecode/branches{/branch}","tags_url":"https://api.github.com/repos/livecode/livecode/tags","blobs_url":"https://api.github.com/repos/livecode/livecode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/livecode/livecode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/livecode/livecode/git/refs{/sha}","trees_url":"https://api.github.com/repos/livecode/livecode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/livecode/livecode/statuses/{sha}","languages_url":"https://api.github.com/repos/livecode/livecode/languages","stargazers_url":"https://api.github.com/repos/livecode/livecode/stargazers","contributors_url":"https://api.github.com/repos/livecode/livecode/contributors","subscribers_url":"https://api.github.com/repos/livecode/livecode/subscribers","subscription_url":"https://api.github.com/repos/livecode/livecode/subscription","commits_url":"https://api.github.com/repos/livecode/livecode/commits{/sha}","git_commits_url":"https://api.github.com/repos/livecode/livecode/git/commits{/sha}","comments_url":"https://api.github.com/repos/livecode/livecode/comments{/number}","issue_comment_url":"https://api.github.com/repos/livecode/livecode/issues/comments{/number}","contents_url":"https://api.github.com/repos/livecode/livecode/contents/{+path}","compare_url":"https://api.github.com/repos/livecode/livecode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/livecode/livecode/merges","archive_url":"https://api.github.com/repos/livecode/livecode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/livecode/livecode/downloads","issues_url":"https://api.github.com/repos/livecode/livecode/issues{/number}","pulls_url":"https://api.github.com/repos/livecode/livecode/pulls{/number}","milestones_url":"https://api.github.com/repos/livecode/livecode/milestones{/number}","notifications_url":"https://api.github.com/repos/livecode/livecode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/livecode/livecode/labels{/name}","releases_url":"https://api.github.com/repos/livecode/livecode/releases{/id}","deployments_url":"https://api.github.com/repos/livecode/livecode/deployments","created_at":"2013-04-10T00:15:57Z","updated_at":"2016-08-04T17:35:59Z","pushed_at":"2016-08-19T05:21:39Z","git_url":"git://github.com/livecode/livecode.git","ssh_url":"git@github.com:livecode/livecode.git","clone_url":"https://github.com/livecode/livecode.git","svn_url":"https://github.com/livecode/livecode","homepage":"https://livecode.com/","size":181445,"stargazers_count":134,"watchers_count":134,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":108,"mirror_url":null,"open_issues_count":58,"forks":108,"open_issues":58,"watchers":134,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/livecode/livecode/pulls/4392"},"html":{"href":"https://github.com/livecode/livecode/pull/4392"},"issue":{"href":"https://api.github.com/repos/livecode/livecode/issues/4392"},"comments":{"href":"https://api.github.com/repos/livecode/livecode/issues/4392/comments"},"review_comments":{"href":"https://api.github.com/repos/livecode/livecode/pulls/4392/comments"},"review_comment":{"href":"https://api.github.com/repos/livecode/livecode/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/livecode/livecode/pulls/4392/commits"},"statuses":{"href":"https://api.github.com/repos/livecode/livecode/statuses/c4738b17733002313071bea04204bf26c121d958"}}}}
{"actor":{"display_login":"livecodeali"}}