{"action":"created","issue":{"url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/2393","labels_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/2393/labels{/name}","comments_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/2393/comments","events_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/2393/events","html_url":"https://github.com/MinecraftForge/MinecraftForge/pull/2393","id":127767948,"number":2393,"title":"Updated NBTTagString.toString() to escape '\\'","user":{"login":"Mathe172","id":3540742,"avatar_url":"https://avatars.githubusercontent.com/u/3540742?v=3","gravatar_id":"","url":"https://api.github.com/users/Mathe172","html_url":"https://github.com/Mathe172","followers_url":"https://api.github.com/users/Mathe172/followers","following_url":"https://api.github.com/users/Mathe172/following{/other_user}","gists_url":"https://api.github.com/users/Mathe172/gists{/gist_id}","starred_url":"https://api.github.com/users/Mathe172/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mathe172/subscriptions","organizations_url":"https://api.github.com/users/Mathe172/orgs","repos_url":"https://api.github.com/users/Mathe172/repos","events_url":"https://api.github.com/users/Mathe172/events{/privacy}","received_events_url":"https://api.github.com/users/Mathe172/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-01-20T19:44:31Z","updated_at":"2016-01-31T14:15:30Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/2393","html_url":"https://github.com/MinecraftForge/MinecraftForge/pull/2393","diff_url":"https://github.com/MinecraftForge/MinecraftForge/pull/2393.diff","patch_url":"https://github.com/MinecraftForge/MinecraftForge/pull/2393.patch"},"body":"This change ensures that NBTTagString.toString() generates  valid NBT. Without this, the output of commands like BlockData is invalid. Currently, quotation marks are escaped, but not backslashes, which is extremely inconsistent"},"comment":{"url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/comments/177508785","html_url":"https://github.com/MinecraftForge/MinecraftForge/pull/2393#issuecomment-177508785","issue_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/2393","id":177508785,"user":{"login":"asiekierka","id":113514,"avatar_url":"https://avatars.githubusercontent.com/u/113514?v=3","gravatar_id":"","url":"https://api.github.com/users/asiekierka","html_url":"https://github.com/asiekierka","followers_url":"https://api.github.com/users/asiekierka/followers","following_url":"https://api.github.com/users/asiekierka/following{/other_user}","gists_url":"https://api.github.com/users/asiekierka/gists{/gist_id}","starred_url":"https://api.github.com/users/asiekierka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asiekierka/subscriptions","organizations_url":"https://api.github.com/users/asiekierka/orgs","repos_url":"https://api.github.com/users/asiekierka/repos","events_url":"https://api.github.com/users/asiekierka/events{/privacy}","received_events_url":"https://api.github.com/users/asiekierka/received_events","type":"User","site_admin":false},"created_at":"2016-01-31T14:15:30Z","updated_at":"2016-01-31T14:15:30Z","body":"Why would you use a hackjob over a true, portable object notation format,\nespecially if vanilla uses NBT->JSON->String itself?\n\nYOU'RE NOT SUPPOSED TO USE TOSTRING AS OBJECT CONVERSION. It's like using a\nnickname in place of a Social Security Number.\n\n2016-01-31 15:03 GMT+01:00 Mathe172 <notifications@github.com>:\n\n> In theory, this would be possible, yes. But why would you ever use\n> NBT->JSON->String if vanilla provides us with a NBT->String (although\n> broken)? There is also another problem (and this is not a matter of \"it\n> would be nice if...\"): Consider a String inside an NBT ending with a \\.\n> This String would return something broken when calling toString.\n> But considering that you do not have to escape \\ inside NBTs in vanilla\n> (although you can, and you have to if they're followed by \") the problem\n> might be bigger than just having a broken toString method...\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/MinecraftForge/MinecraftForge/pull/2393#issuecomment-177508012>\n> .\n>\n"}}