{"action":"created","comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/60998718","id":60998718,"diff_hunk":"@@ -2477,7 +2477,17 @@ in modules // {\n     };\n   };\n \n-  boto3 = buildPythonPackage rec {\n+  boto3 = let\n+    # Version >=1.3,<1.4 is required by boto3.\n+    botocore-1_3 = self.botocore.override rec {\n+      name = \"botocore-${version}\";\n+      version = \"1.3.30\";\n+      src = pkgs.fetchurl {\n+        url = \"https://pypi.python.org/packages/6c/79/5d3abfb9fffe4a8cb0a113f088c1012743cf40db805aaac625b2e3cf2111/botocore-1.3.30.tar.gz\";","path":"pkgs/top-level/python-packages.nix","position":11,"original_position":11,"commit_id":"4a0bebc1d056ba4f56fb0acd5656b0bfdd8e83e2","original_commit_id":"4a0bebc1d056ba4f56fb0acd5656b0bfdd8e83e2","user":{"login":"adnelson","id":5091511,"avatar_url":"https://avatars.githubusercontent.com/u/5091511?v=3","gravatar_id":"","url":"https://api.github.com/users/adnelson","html_url":"https://github.com/adnelson","followers_url":"https://api.github.com/users/adnelson/followers","following_url":"https://api.github.com/users/adnelson/following{/other_user}","gists_url":"https://api.github.com/users/adnelson/gists{/gist_id}","starred_url":"https://api.github.com/users/adnelson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adnelson/subscriptions","organizations_url":"https://api.github.com/users/adnelson/orgs","repos_url":"https://api.github.com/users/adnelson/repos","events_url":"https://api.github.com/users/adnelson/events{/privacy}","received_events_url":"https://api.github.com/users/adnelson/received_events","type":"User","site_admin":false},"body":"I see that. I'd prefer to just have a generic \"buildPypiUrl\" function (actually I have a `pypiPackage` function in my company's nix code for this reason). The reason I'm a bit ambivalent is that it's not possible to \"accidentally\" get out of sync because of the SHA. But it's fine.","created_at":"2016-04-25T22:10:24Z","updated_at":"2016-04-25T22:10:24Z","html_url":"https://github.com/NixOS/nixpkgs/pull/14985#discussion_r60998718","pull_request_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/14985","_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/60998718"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/14985#discussion_r60998718"},"pull_request":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/14985"}}},"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/14985","id":67760429,"html_url":"https://github.com/NixOS/nixpkgs/pull/14985","diff_url":"https://github.com/NixOS/nixpkgs/pull/14985.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/14985.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/14985","number":14985,"state":"open","locked":false,"title":"boto3: enable unit tests, correct version of botocore","user":{"login":"adnelson","id":5091511,"avatar_url":"https://avatars.githubusercontent.com/u/5091511?v=3","gravatar_id":"","url":"https://api.github.com/users/adnelson","html_url":"https://github.com/adnelson","followers_url":"https://api.github.com/users/adnelson/followers","following_url":"https://api.github.com/users/adnelson/following{/other_user}","gists_url":"https://api.github.com/users/adnelson/gists{/gist_id}","starred_url":"https://api.github.com/users/adnelson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adnelson/subscriptions","organizations_url":"https://api.github.com/users/adnelson/orgs","repos_url":"https://api.github.com/users/adnelson/repos","events_url":"https://api.github.com/users/adnelson/events{/privacy}","received_events_url":"https://api.github.com/users/adnelson/received_events","type":"User","site_admin":false},"body":"This allows boto3 to work (with unit tests) with python2.7 and python3.4.\r\n\r\n###### Things done\r\n\r\n- [ ] Tested using sandboxing (`nix-build --option build-use-sandbox true` or [nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS)\r\n- Built on platform(s)\r\n   - [X] NixOS\r\n   - [ ] OS X\r\n   - [X] Linux\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [ ] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\n\r\n","created_at":"2016-04-25T17:50:55Z","updated_at":"2016-04-25T22:10:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8b7b70e6cc6d4db787dc4338c90d70f6c5332bc2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/14985/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/14985/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/14985/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/4a0bebc1d056ba4f56fb0acd5656b0bfdd8e83e2","head":{"label":"adnelson:enable_boto3","ref":"enable_boto3","sha":"4a0bebc1d056ba4f56fb0acd5656b0bfdd8e83e2","user":{"login":"adnelson","id":5091511,"avatar_url":"https://avatars.githubusercontent.com/u/5091511?v=3","gravatar_id":"","url":"https://api.github.com/users/adnelson","html_url":"https://github.com/adnelson","followers_url":"https://api.github.com/users/adnelson/followers","following_url":"https://api.github.com/users/adnelson/following{/other_user}","gists_url":"https://api.github.com/users/adnelson/gists{/gist_id}","starred_url":"https://api.github.com/users/adnelson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adnelson/subscriptions","organizations_url":"https://api.github.com/users/adnelson/orgs","repos_url":"https://api.github.com/users/adnelson/repos","events_url":"https://api.github.com/users/adnelson/events{/privacy}","received_events_url":"https://api.github.com/users/adnelson/received_events","type":"User","site_admin":false},"repo":{"id":35304947,"name":"nixpkgs","full_name":"adnelson/nixpkgs","owner":{"login":"adnelson","id":5091511,"avatar_url":"https://avatars.githubusercontent.com/u/5091511?v=3","gravatar_id":"","url":"https://api.github.com/users/adnelson","html_url":"https://github.com/adnelson","followers_url":"https://api.github.com/users/adnelson/followers","following_url":"https://api.github.com/users/adnelson/following{/other_user}","gists_url":"https://api.github.com/users/adnelson/gists{/gist_id}","starred_url":"https://api.github.com/users/adnelson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adnelson/subscriptions","organizations_url":"https://api.github.com/users/adnelson/orgs","repos_url":"https://api.github.com/users/adnelson/repos","events_url":"https://api.github.com/users/adnelson/events{/privacy}","received_events_url":"https://api.github.com/users/adnelson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/adnelson/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/adnelson/nixpkgs","forks_url":"https://api.github.com/repos/adnelson/nixpkgs/forks","keys_url":"https://api.github.com/repos/adnelson/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adnelson/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adnelson/nixpkgs/teams","hooks_url":"https://api.github.com/repos/adnelson/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/adnelson/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/adnelson/nixpkgs/events","assignees_url":"https://api.github.com/repos/adnelson/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/adnelson/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/adnelson/nixpkgs/tags","blobs_url":"https://api.github.com/repos/adnelson/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adnelson/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adnelson/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/adnelson/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adnelson/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/adnelson/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/adnelson/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/adnelson/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/adnelson/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/adnelson/nixpkgs/subscription","commits_url":"https://api.github.com/repos/adnelson/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/adnelson/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/adnelson/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/adnelson/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/adnelson/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/adnelson/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adnelson/nixpkgs/merges","archive_url":"https://api.github.com/repos/adnelson/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adnelson/nixpkgs/downloads","issues_url":"https://api.github.com/repos/adnelson/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/adnelson/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/adnelson/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/adnelson/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adnelson/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/adnelson/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/adnelson/nixpkgs/deployments","created_at":"2015-05-08T22:29:41Z","updated_at":"2016-04-22T22:32:09Z","pushed_at":"2016-04-25T21:25:45Z","git_url":"git://github.com/adnelson/nixpkgs.git","ssh_url":"git@github.com:adnelson/nixpkgs.git","clone_url":"https://github.com/adnelson/nixpkgs.git","svn_url":"https://github.com/adnelson/nixpkgs","homepage":null,"size":317978,"stargazers_count":0,"watchers_count":0,"language":"Nix","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"NixOS:master","ref":"master","sha":"618c75de7b15d159f0414ce2b940c30ad13efa6c","user":{"login":"NixOS","id":487568,"avatar_url":"https://avatars.githubusercontent.com/u/487568?v=3","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"name":"nixpkgs","full_name":"NixOS/nixpkgs","owner":{"login":"NixOS","id":487568,"avatar_url":"https://avatars.githubusercontent.com/u/487568?v=3","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/NixOS/nixpkgs/deployments","created_at":"2012-06-04T02:49:46Z","updated_at":"2016-04-25T20:42:23Z","pushed_at":"2016-04-25T21:54:45Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":517852,"stargazers_count":1053,"watchers_count":1053,"language":"Nix","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1365,"mirror_url":null,"open_issues_count":1295,"forks":1365,"open_issues":1295,"watchers":1053,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/14985"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/14985"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/14985"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/14985/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/14985/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/14985/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/4a0bebc1d056ba4f56fb0acd5656b0bfdd8e83e2"}}}}