{"action":"created","comment":{"url":"https://api.github.com/repos/UNINETT/mod_auth_mellon/pulls/comments/68205319","id":68205319,"diff_hunk":"@@ -390,7 +390,7 @@ int am_httpclient_get(request_rec *r, const char *uri,\n         return HTTP_INTERNAL_SERVER_ERROR;\n     }\n \n-    res = curl_easy_setopt(curl, CURLOPT_TIMEOUT, timeout);\n+    res = curl_easy_setopt(curl, CURLOPT_TIMEOUT, timeout * 1L);","path":"auth_mellon_httpclient.c","position":23,"original_position":23,"commit_id":"58401116b7cb1ec345cdccf7903fd61a70bfa073","original_commit_id":"58401116b7cb1ec345cdccf7903fd61a70bfa073","user":{"login":"rainerjung","id":701263,"avatar_url":"https://avatars.githubusercontent.com/u/701263?v=3","gravatar_id":"","url":"https://api.github.com/users/rainerjung","html_url":"https://github.com/rainerjung","followers_url":"https://api.github.com/users/rainerjung/followers","following_url":"https://api.github.com/users/rainerjung/following{/other_user}","gists_url":"https://api.github.com/users/rainerjung/gists{/gist_id}","starred_url":"https://api.github.com/users/rainerjung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rainerjung/subscriptions","organizations_url":"https://api.github.com/users/rainerjung/orgs","repos_url":"https://api.github.com/users/rainerjung/repos","events_url":"https://api.github.com/users/rainerjung/events{/privacy}","received_events_url":"https://api.github.com/users/rainerjung/received_events","type":"User","site_admin":false},"body":"Agreed.","created_at":"2016-06-23T09:44:40Z","updated_at":"2016-06-23T09:44:40Z","html_url":"https://github.com/UNINETT/mod_auth_mellon/pull/89#discussion_r68205319","pull_request_url":"https://api.github.com/repos/UNINETT/mod_auth_mellon/pulls/89","_links":{"self":{"href":"https://api.github.com/repos/UNINETT/mod_auth_mellon/pulls/comments/68205319"},"html":{"href":"https://github.com/UNINETT/mod_auth_mellon/pull/89#discussion_r68205319"},"pull_request":{"href":"https://api.github.com/repos/UNINETT/mod_auth_mellon/pulls/89"}}},"pull_request":{"url":"https://api.github.com/repos/UNINETT/mod_auth_mellon/pulls/89","id":74852982,"html_url":"https://github.com/UNINETT/mod_auth_mellon/pull/89","diff_url":"https://github.com/UNINETT/mod_auth_mellon/pull/89.diff","patch_url":"https://github.com/UNINETT/mod_auth_mellon/pull/89.patch","issue_url":"https://api.github.com/repos/UNINETT/mod_auth_mellon/issues/89","number":89,"state":"open","locked":false,"title":"Use \"long\" type in curl_easy_setopt for timeouts","user":{"login":"rainerjung","id":701263,"avatar_url":"https://avatars.githubusercontent.com/u/701263?v=3","gravatar_id":"","url":"https://api.github.com/users/rainerjung","html_url":"https://github.com/rainerjung","followers_url":"https://api.github.com/users/rainerjung/followers","following_url":"https://api.github.com/users/rainerjung/following{/other_user}","gists_url":"https://api.github.com/users/rainerjung/gists{/gist_id}","starred_url":"https://api.github.com/users/rainerjung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rainerjung/subscriptions","organizations_url":"https://api.github.com/users/rainerjung/orgs","repos_url":"https://api.github.com/users/rainerjung/repos","events_url":"https://api.github.com/users/rainerjung/events{/privacy}","received_events_url":"https://api.github.com/users/rainerjung/received_events","type":"User","site_admin":false},"body":"Curl timeouts in auth_mellon_httpclient should be given as long\r\nvalues and have semantic meaning of seconds.\r\n\r\nThe code currently passes them in as apr_time_t type which\r\ncontains seconds, although apr_time_t should contain\r\nmicroseconds.\r\n\r\nI suggest to not use apr_time_t here, because it is misleading,\r\nand instead use a plain int. The code calling httpclient already\r\nprepares the value as an int. Furthermore convert the value to a\r\nlong when curl_easy_setopt() is being called.","created_at":"2016-06-22T20:37:38Z","updated_at":"2016-06-23T09:44:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fbae73375d4208c3562a0613d28899d690700013","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/UNINETT/mod_auth_mellon/pulls/89/commits","review_comments_url":"https://api.github.com/repos/UNINETT/mod_auth_mellon/pulls/89/comments","review_comment_url":"https://api.github.com/repos/UNINETT/mod_auth_mellon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/UNINETT/mod_auth_mellon/issues/89/comments","statuses_url":"https://api.github.com/repos/UNINETT/mod_auth_mellon/statuses/58401116b7cb1ec345cdccf7903fd61a70bfa073","head":{"label":"rainerjung:curlopt_type_long_timeout","ref":"curlopt_type_long_timeout","sha":"58401116b7cb1ec345cdccf7903fd61a70bfa073","user":{"login":"rainerjung","id":701263,"avatar_url":"https://avatars.githubusercontent.com/u/701263?v=3","gravatar_id":"","url":"https://api.github.com/users/rainerjung","html_url":"https://github.com/rainerjung","followers_url":"https://api.github.com/users/rainerjung/followers","following_url":"https://api.github.com/users/rainerjung/following{/other_user}","gists_url":"https://api.github.com/users/rainerjung/gists{/gist_id}","starred_url":"https://api.github.com/users/rainerjung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rainerjung/subscriptions","organizations_url":"https://api.github.com/users/rainerjung/orgs","repos_url":"https://api.github.com/users/rainerjung/repos","events_url":"https://api.github.com/users/rainerjung/events{/privacy}","received_events_url":"https://api.github.com/users/rainerjung/received_events","type":"User","site_admin":false},"repo":{"id":61743111,"name":"mod_auth_mellon","full_name":"rainerjung/mod_auth_mellon","owner":{"login":"rainerjung","id":701263,"avatar_url":"https://avatars.githubusercontent.com/u/701263?v=3","gravatar_id":"","url":"https://api.github.com/users/rainerjung","html_url":"https://github.com/rainerjung","followers_url":"https://api.github.com/users/rainerjung/followers","following_url":"https://api.github.com/users/rainerjung/following{/other_user}","gists_url":"https://api.github.com/users/rainerjung/gists{/gist_id}","starred_url":"https://api.github.com/users/rainerjung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rainerjung/subscriptions","organizations_url":"https://api.github.com/users/rainerjung/orgs","repos_url":"https://api.github.com/users/rainerjung/repos","events_url":"https://api.github.com/users/rainerjung/events{/privacy}","received_events_url":"https://api.github.com/users/rainerjung/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rainerjung/mod_auth_mellon","description":"An Apache module with a simple SAML 2.0 service provider","fork":true,"url":"https://api.github.com/repos/rainerjung/mod_auth_mellon","forks_url":"https://api.github.com/repos/rainerjung/mod_auth_mellon/forks","keys_url":"https://api.github.com/repos/rainerjung/mod_auth_mellon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rainerjung/mod_auth_mellon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rainerjung/mod_auth_mellon/teams","hooks_url":"https://api.github.com/repos/rainerjung/mod_auth_mellon/hooks","issue_events_url":"https://api.github.com/repos/rainerjung/mod_auth_mellon/issues/events{/number}","events_url":"https://api.github.com/repos/rainerjung/mod_auth_mellon/events","assignees_url":"https://api.github.com/repos/rainerjung/mod_auth_mellon/assignees{/user}","branches_url":"https://api.github.com/repos/rainerjung/mod_auth_mellon/branches{/branch}","tags_url":"https://api.github.com/repos/rainerjung/mod_auth_mellon/tags","blobs_url":"https://api.github.com/repos/rainerjung/mod_auth_mellon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rainerjung/mod_auth_mellon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rainerjung/mod_auth_mellon/git/refs{/sha}","trees_url":"https://api.github.com/repos/rainerjung/mod_auth_mellon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rainerjung/mod_auth_mellon/statuses/{sha}","languages_url":"https://api.github.com/repos/rainerjung/mod_auth_mellon/languages","stargazers_url":"https://api.github.com/repos/rainerjung/mod_auth_mellon/stargazers","contributors_url":"https://api.github.com/repos/rainerjung/mod_auth_mellon/contributors","subscribers_url":"https://api.github.com/repos/rainerjung/mod_auth_mellon/subscribers","subscription_url":"https://api.github.com/repos/rainerjung/mod_auth_mellon/subscription","commits_url":"https://api.github.com/repos/rainerjung/mod_auth_mellon/commits{/sha}","git_commits_url":"https://api.github.com/repos/rainerjung/mod_auth_mellon/git/commits{/sha}","comments_url":"https://api.github.com/repos/rainerjung/mod_auth_mellon/comments{/number}","issue_comment_url":"https://api.github.com/repos/rainerjung/mod_auth_mellon/issues/comments{/number}","contents_url":"https://api.github.com/repos/rainerjung/mod_auth_mellon/contents/{+path}","compare_url":"https://api.github.com/repos/rainerjung/mod_auth_mellon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rainerjung/mod_auth_mellon/merges","archive_url":"https://api.github.com/repos/rainerjung/mod_auth_mellon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rainerjung/mod_auth_mellon/downloads","issues_url":"https://api.github.com/repos/rainerjung/mod_auth_mellon/issues{/number}","pulls_url":"https://api.github.com/repos/rainerjung/mod_auth_mellon/pulls{/number}","milestones_url":"https://api.github.com/repos/rainerjung/mod_auth_mellon/milestones{/number}","notifications_url":"https://api.github.com/repos/rainerjung/mod_auth_mellon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rainerjung/mod_auth_mellon/labels{/name}","releases_url":"https://api.github.com/repos/rainerjung/mod_auth_mellon/releases{/id}","deployments_url":"https://api.github.com/repos/rainerjung/mod_auth_mellon/deployments","created_at":"2016-06-22T18:42:51Z","updated_at":"2016-06-22T18:42:52Z","pushed_at":"2016-06-22T20:36:31Z","git_url":"git://github.com/rainerjung/mod_auth_mellon.git","ssh_url":"git@github.com:rainerjung/mod_auth_mellon.git","clone_url":"https://github.com/rainerjung/mod_auth_mellon.git","svn_url":"https://github.com/rainerjung/mod_auth_mellon","homepage":null,"size":384,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"UNINETT:master","ref":"master","sha":"6bdda9170a8f1757dabc5b109958657417728018","user":{"login":"UNINETT","id":778970,"avatar_url":"https://avatars.githubusercontent.com/u/778970?v=3","gravatar_id":"","url":"https://api.github.com/users/UNINETT","html_url":"https://github.com/UNINETT","followers_url":"https://api.github.com/users/UNINETT/followers","following_url":"https://api.github.com/users/UNINETT/following{/other_user}","gists_url":"https://api.github.com/users/UNINETT/gists{/gist_id}","starred_url":"https://api.github.com/users/UNINETT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UNINETT/subscriptions","organizations_url":"https://api.github.com/users/UNINETT/orgs","repos_url":"https://api.github.com/users/UNINETT/repos","events_url":"https://api.github.com/users/UNINETT/events{/privacy}","received_events_url":"https://api.github.com/users/UNINETT/received_events","type":"Organization","site_admin":false},"repo":{"id":21158038,"name":"mod_auth_mellon","full_name":"UNINETT/mod_auth_mellon","owner":{"login":"UNINETT","id":778970,"avatar_url":"https://avatars.githubusercontent.com/u/778970?v=3","gravatar_id":"","url":"https://api.github.com/users/UNINETT","html_url":"https://github.com/UNINETT","followers_url":"https://api.github.com/users/UNINETT/followers","following_url":"https://api.github.com/users/UNINETT/following{/other_user}","gists_url":"https://api.github.com/users/UNINETT/gists{/gist_id}","starred_url":"https://api.github.com/users/UNINETT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UNINETT/subscriptions","organizations_url":"https://api.github.com/users/UNINETT/orgs","repos_url":"https://api.github.com/users/UNINETT/repos","events_url":"https://api.github.com/users/UNINETT/events{/privacy}","received_events_url":"https://api.github.com/users/UNINETT/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/UNINETT/mod_auth_mellon","description":"An Apache module with a simple SAML 2.0 service provider","fork":false,"url":"https://api.github.com/repos/UNINETT/mod_auth_mellon","forks_url":"https://api.github.com/repos/UNINETT/mod_auth_mellon/forks","keys_url":"https://api.github.com/repos/UNINETT/mod_auth_mellon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UNINETT/mod_auth_mellon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UNINETT/mod_auth_mellon/teams","hooks_url":"https://api.github.com/repos/UNINETT/mod_auth_mellon/hooks","issue_events_url":"https://api.github.com/repos/UNINETT/mod_auth_mellon/issues/events{/number}","events_url":"https://api.github.com/repos/UNINETT/mod_auth_mellon/events","assignees_url":"https://api.github.com/repos/UNINETT/mod_auth_mellon/assignees{/user}","branches_url":"https://api.github.com/repos/UNINETT/mod_auth_mellon/branches{/branch}","tags_url":"https://api.github.com/repos/UNINETT/mod_auth_mellon/tags","blobs_url":"https://api.github.com/repos/UNINETT/mod_auth_mellon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UNINETT/mod_auth_mellon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UNINETT/mod_auth_mellon/git/refs{/sha}","trees_url":"https://api.github.com/repos/UNINETT/mod_auth_mellon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UNINETT/mod_auth_mellon/statuses/{sha}","languages_url":"https://api.github.com/repos/UNINETT/mod_auth_mellon/languages","stargazers_url":"https://api.github.com/repos/UNINETT/mod_auth_mellon/stargazers","contributors_url":"https://api.github.com/repos/UNINETT/mod_auth_mellon/contributors","subscribers_url":"https://api.github.com/repos/UNINETT/mod_auth_mellon/subscribers","subscription_url":"https://api.github.com/repos/UNINETT/mod_auth_mellon/subscription","commits_url":"https://api.github.com/repos/UNINETT/mod_auth_mellon/commits{/sha}","git_commits_url":"https://api.github.com/repos/UNINETT/mod_auth_mellon/git/commits{/sha}","comments_url":"https://api.github.com/repos/UNINETT/mod_auth_mellon/comments{/number}","issue_comment_url":"https://api.github.com/repos/UNINETT/mod_auth_mellon/issues/comments{/number}","contents_url":"https://api.github.com/repos/UNINETT/mod_auth_mellon/contents/{+path}","compare_url":"https://api.github.com/repos/UNINETT/mod_auth_mellon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UNINETT/mod_auth_mellon/merges","archive_url":"https://api.github.com/repos/UNINETT/mod_auth_mellon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UNINETT/mod_auth_mellon/downloads","issues_url":"https://api.github.com/repos/UNINETT/mod_auth_mellon/issues{/number}","pulls_url":"https://api.github.com/repos/UNINETT/mod_auth_mellon/pulls{/number}","milestones_url":"https://api.github.com/repos/UNINETT/mod_auth_mellon/milestones{/number}","notifications_url":"https://api.github.com/repos/UNINETT/mod_auth_mellon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UNINETT/mod_auth_mellon/labels{/name}","releases_url":"https://api.github.com/repos/UNINETT/mod_auth_mellon/releases{/id}","deployments_url":"https://api.github.com/repos/UNINETT/mod_auth_mellon/deployments","created_at":"2014-06-24T08:44:12Z","updated_at":"2016-06-16T21:29:49Z","pushed_at":"2016-06-23T07:20:09Z","git_url":"git://github.com/UNINETT/mod_auth_mellon.git","ssh_url":"git@github.com:UNINETT/mod_auth_mellon.git","clone_url":"https://github.com/UNINETT/mod_auth_mellon.git","svn_url":"https://github.com/UNINETT/mod_auth_mellon","homepage":null,"size":543,"stargazers_count":69,"watchers_count":69,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"open_issues_count":7,"forks":22,"open_issues":7,"watchers":69,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/UNINETT/mod_auth_mellon/pulls/89"},"html":{"href":"https://github.com/UNINETT/mod_auth_mellon/pull/89"},"issue":{"href":"https://api.github.com/repos/UNINETT/mod_auth_mellon/issues/89"},"comments":{"href":"https://api.github.com/repos/UNINETT/mod_auth_mellon/issues/89/comments"},"review_comments":{"href":"https://api.github.com/repos/UNINETT/mod_auth_mellon/pulls/89/comments"},"review_comment":{"href":"https://api.github.com/repos/UNINETT/mod_auth_mellon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/UNINETT/mod_auth_mellon/pulls/89/commits"},"statuses":{"href":"https://api.github.com/repos/UNINETT/mod_auth_mellon/statuses/58401116b7cb1ec345cdccf7903fd61a70bfa073"}}}}
{"actor":{"display_login":"rainerjung"}}