{"action":"created","comment":{"url":"https://api.github.com/repos/EiffelSoftware/EiffelStudio/pulls/comments/84829780","pull_request_review_id":5581318,"id":84829780,"diff_hunk":"@@ -775,11 +778,108 @@ EIF_INTEGER c_put_stream_noexception(EIF_INTEGER fd, EIF_POINTER stream_pointer,\n }\n \n void c_put_stream(EIF_INTEGER fd, EIF_POINTER stream_pointer, EIF_INTEGER length)\n-\t/*x transmission of string s of size size trought socket fd */\n+\t/*x transmission of string s of size length throught socket fd */\n {\n \teif_net_check(c_put_stream_noexception(fd, stream_pointer, length));\n }\n \n+EIF_INTEGER c_unoptimized_sendfile_noexception(EIF_INTEGER out_fd, FILE* f, EIF_INTEGER length)","path":"Src/library/net/Clib/network.c","position":53,"original_position":53,"commit_id":"95fc313433120546b7c87247b2a500f3e0f7db02","original_commit_id":"95fc313433120546b7c87247b2a500f3e0f7db02","user":{"login":"manuseiffel","id":441358,"avatar_url":"https://avatars.githubusercontent.com/u/441358?v=3","gravatar_id":"","url":"https://api.github.com/users/manuseiffel","html_url":"https://github.com/manuseiffel","followers_url":"https://api.github.com/users/manuseiffel/followers","following_url":"https://api.github.com/users/manuseiffel/following{/other_user}","gists_url":"https://api.github.com/users/manuseiffel/gists{/gist_id}","starred_url":"https://api.github.com/users/manuseiffel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manuseiffel/subscriptions","organizations_url":"https://api.github.com/users/manuseiffel/orgs","repos_url":"https://api.github.com/users/manuseiffel/repos","events_url":"https://api.github.com/users/manuseiffel/events{/privacy}","received_events_url":"https://api.github.com/users/manuseiffel/received_events","type":"User","site_admin":false},"body":"We should reject a length of 0 by default. If the file needs to be calculated, we should do that in the Eiffel code. This will avoid the need of refering `eif_file.h' which is runtime specific for EiffelBase and should not be used anywhere else.","created_at":"2016-10-25T04:38:26Z","updated_at":"2016-10-25T04:38:26Z","html_url":"https://github.com/EiffelSoftware/EiffelStudio/pull/9#discussion_r84829780","pull_request_url":"https://api.github.com/repos/EiffelSoftware/EiffelStudio/pulls/9","_links":{"self":{"href":"https://api.github.com/repos/EiffelSoftware/EiffelStudio/pulls/comments/84829780"},"html":{"href":"https://github.com/EiffelSoftware/EiffelStudio/pull/9#discussion_r84829780"},"pull_request":{"href":"https://api.github.com/repos/EiffelSoftware/EiffelStudio/pulls/9"}}},"pull_request":{"url":"https://api.github.com/repos/EiffelSoftware/EiffelStudio/pulls/9","id":90685175,"html_url":"https://github.com/EiffelSoftware/EiffelStudio/pull/9","diff_url":"https://github.com/EiffelSoftware/EiffelStudio/pull/9.diff","patch_url":"https://github.com/EiffelSoftware/EiffelStudio/pull/9.patch","issue_url":"https://api.github.com/repos/EiffelSoftware/EiffelStudio/issues/9","number":9,"state":"open","locked":false,"title":"Added support for `TransmitFile` (on Windows) or `sendfile`.","user":{"login":"jocelyn","id":31598,"avatar_url":"https://avatars.githubusercontent.com/u/31598?v=3","gravatar_id":"","url":"https://api.github.com/users/jocelyn","html_url":"https://github.com/jocelyn","followers_url":"https://api.github.com/users/jocelyn/followers","following_url":"https://api.github.com/users/jocelyn/following{/other_user}","gists_url":"https://api.github.com/users/jocelyn/gists{/gist_id}","starred_url":"https://api.github.com/users/jocelyn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jocelyn/subscriptions","organizations_url":"https://api.github.com/users/jocelyn/orgs","repos_url":"https://api.github.com/users/jocelyn/repos","events_url":"https://api.github.com/users/jocelyn/events{/privacy}","received_events_url":"https://api.github.com/users/jocelyn/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-10-24T20:21:36Z","updated_at":"2016-10-25T04:38:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a8229d77d543469cc5e31125da92ed1b40ad3986","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/EiffelSoftware/EiffelStudio/pulls/9/commits","review_comments_url":"https://api.github.com/repos/EiffelSoftware/EiffelStudio/pulls/9/comments","review_comment_url":"https://api.github.com/repos/EiffelSoftware/EiffelStudio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/EiffelSoftware/EiffelStudio/issues/9/comments","statuses_url":"https://api.github.com/repos/EiffelSoftware/EiffelStudio/statuses/95fc313433120546b7c87247b2a500f3e0f7db02","head":{"label":"jocelyn:net_sendfile","ref":"net_sendfile","sha":"95fc313433120546b7c87247b2a500f3e0f7db02","user":{"login":"jocelyn","id":31598,"avatar_url":"https://avatars.githubusercontent.com/u/31598?v=3","gravatar_id":"","url":"https://api.github.com/users/jocelyn","html_url":"https://github.com/jocelyn","followers_url":"https://api.github.com/users/jocelyn/followers","following_url":"https://api.github.com/users/jocelyn/following{/other_user}","gists_url":"https://api.github.com/users/jocelyn/gists{/gist_id}","starred_url":"https://api.github.com/users/jocelyn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jocelyn/subscriptions","organizations_url":"https://api.github.com/users/jocelyn/orgs","repos_url":"https://api.github.com/users/jocelyn/repos","events_url":"https://api.github.com/users/jocelyn/events{/privacy}","received_events_url":"https://api.github.com/users/jocelyn/received_events","type":"User","site_admin":false},"repo":{"id":61017838,"name":"EiffelStudio","full_name":"jocelyn/EiffelStudio","owner":{"login":"jocelyn","id":31598,"avatar_url":"https://avatars.githubusercontent.com/u/31598?v=3","gravatar_id":"","url":"https://api.github.com/users/jocelyn","html_url":"https://github.com/jocelyn","followers_url":"https://api.github.com/users/jocelyn/followers","following_url":"https://api.github.com/users/jocelyn/following{/other_user}","gists_url":"https://api.github.com/users/jocelyn/gists{/gist_id}","starred_url":"https://api.github.com/users/jocelyn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jocelyn/subscriptions","organizations_url":"https://api.github.com/users/jocelyn/orgs","repos_url":"https://api.github.com/users/jocelyn/repos","events_url":"https://api.github.com/users/jocelyn/events{/privacy}","received_events_url":"https://api.github.com/users/jocelyn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jocelyn/EiffelStudio","description":"Mirror of https://svn.eiffel.com/eiffelstudio/trunk","fork":true,"url":"https://api.github.com/repos/jocelyn/EiffelStudio","forks_url":"https://api.github.com/repos/jocelyn/EiffelStudio/forks","keys_url":"https://api.github.com/repos/jocelyn/EiffelStudio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jocelyn/EiffelStudio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jocelyn/EiffelStudio/teams","hooks_url":"https://api.github.com/repos/jocelyn/EiffelStudio/hooks","issue_events_url":"https://api.github.com/repos/jocelyn/EiffelStudio/issues/events{/number}","events_url":"https://api.github.com/repos/jocelyn/EiffelStudio/events","assignees_url":"https://api.github.com/repos/jocelyn/EiffelStudio/assignees{/user}","branches_url":"https://api.github.com/repos/jocelyn/EiffelStudio/branches{/branch}","tags_url":"https://api.github.com/repos/jocelyn/EiffelStudio/tags","blobs_url":"https://api.github.com/repos/jocelyn/EiffelStudio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jocelyn/EiffelStudio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jocelyn/EiffelStudio/git/refs{/sha}","trees_url":"https://api.github.com/repos/jocelyn/EiffelStudio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jocelyn/EiffelStudio/statuses/{sha}","languages_url":"https://api.github.com/repos/jocelyn/EiffelStudio/languages","stargazers_url":"https://api.github.com/repos/jocelyn/EiffelStudio/stargazers","contributors_url":"https://api.github.com/repos/jocelyn/EiffelStudio/contributors","subscribers_url":"https://api.github.com/repos/jocelyn/EiffelStudio/subscribers","subscription_url":"https://api.github.com/repos/jocelyn/EiffelStudio/subscription","commits_url":"https://api.github.com/repos/jocelyn/EiffelStudio/commits{/sha}","git_commits_url":"https://api.github.com/repos/jocelyn/EiffelStudio/git/commits{/sha}","comments_url":"https://api.github.com/repos/jocelyn/EiffelStudio/comments{/number}","issue_comment_url":"https://api.github.com/repos/jocelyn/EiffelStudio/issues/comments{/number}","contents_url":"https://api.github.com/repos/jocelyn/EiffelStudio/contents/{+path}","compare_url":"https://api.github.com/repos/jocelyn/EiffelStudio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jocelyn/EiffelStudio/merges","archive_url":"https://api.github.com/repos/jocelyn/EiffelStudio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jocelyn/EiffelStudio/downloads","issues_url":"https://api.github.com/repos/jocelyn/EiffelStudio/issues{/number}","pulls_url":"https://api.github.com/repos/jocelyn/EiffelStudio/pulls{/number}","milestones_url":"https://api.github.com/repos/jocelyn/EiffelStudio/milestones{/number}","notifications_url":"https://api.github.com/repos/jocelyn/EiffelStudio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jocelyn/EiffelStudio/labels{/name}","releases_url":"https://api.github.com/repos/jocelyn/EiffelStudio/releases{/id}","deployments_url":"https://api.github.com/repos/jocelyn/EiffelStudio/deployments","created_at":"2016-06-13T07:53:02Z","updated_at":"2016-06-13T07:56:48Z","pushed_at":"2016-10-24T20:21:15Z","git_url":"git://github.com/jocelyn/EiffelStudio.git","ssh_url":"git@github.com:jocelyn/EiffelStudio.git","clone_url":"https://github.com/jocelyn/EiffelStudio.git","svn_url":"https://github.com/jocelyn/EiffelStudio","homepage":"","size":567939,"stargazers_count":0,"watchers_count":0,"language":"Eiffel","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"EiffelSoftware:master","ref":"master","sha":"d6eedcb30ca54bb702a09322ea64213c2e8a8df6","user":{"login":"EiffelSoftware","id":318837,"avatar_url":"https://avatars.githubusercontent.com/u/318837?v=3","gravatar_id":"","url":"https://api.github.com/users/EiffelSoftware","html_url":"https://github.com/EiffelSoftware","followers_url":"https://api.github.com/users/EiffelSoftware/followers","following_url":"https://api.github.com/users/EiffelSoftware/following{/other_user}","gists_url":"https://api.github.com/users/EiffelSoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/EiffelSoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EiffelSoftware/subscriptions","organizations_url":"https://api.github.com/users/EiffelSoftware/orgs","repos_url":"https://api.github.com/users/EiffelSoftware/repos","events_url":"https://api.github.com/users/EiffelSoftware/events{/privacy}","received_events_url":"https://api.github.com/users/EiffelSoftware/received_events","type":"Organization","site_admin":false},"repo":{"id":60939647,"name":"EiffelStudio","full_name":"EiffelSoftware/EiffelStudio","owner":{"login":"EiffelSoftware","id":318837,"avatar_url":"https://avatars.githubusercontent.com/u/318837?v=3","gravatar_id":"","url":"https://api.github.com/users/EiffelSoftware","html_url":"https://github.com/EiffelSoftware","followers_url":"https://api.github.com/users/EiffelSoftware/followers","following_url":"https://api.github.com/users/EiffelSoftware/following{/other_user}","gists_url":"https://api.github.com/users/EiffelSoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/EiffelSoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EiffelSoftware/subscriptions","organizations_url":"https://api.github.com/users/EiffelSoftware/orgs","repos_url":"https://api.github.com/users/EiffelSoftware/repos","events_url":"https://api.github.com/users/EiffelSoftware/events{/privacy}","received_events_url":"https://api.github.com/users/EiffelSoftware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/EiffelSoftware/EiffelStudio","description":"Mirror of https://svn.eiffel.com/eiffelstudio/trunk","fork":false,"url":"https://api.github.com/repos/EiffelSoftware/EiffelStudio","forks_url":"https://api.github.com/repos/EiffelSoftware/EiffelStudio/forks","keys_url":"https://api.github.com/repos/EiffelSoftware/EiffelStudio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/EiffelSoftware/EiffelStudio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/EiffelSoftware/EiffelStudio/teams","hooks_url":"https://api.github.com/repos/EiffelSoftware/EiffelStudio/hooks","issue_events_url":"https://api.github.com/repos/EiffelSoftware/EiffelStudio/issues/events{/number}","events_url":"https://api.github.com/repos/EiffelSoftware/EiffelStudio/events","assignees_url":"https://api.github.com/repos/EiffelSoftware/EiffelStudio/assignees{/user}","branches_url":"https://api.github.com/repos/EiffelSoftware/EiffelStudio/branches{/branch}","tags_url":"https://api.github.com/repos/EiffelSoftware/EiffelStudio/tags","blobs_url":"https://api.github.com/repos/EiffelSoftware/EiffelStudio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/EiffelSoftware/EiffelStudio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/EiffelSoftware/EiffelStudio/git/refs{/sha}","trees_url":"https://api.github.com/repos/EiffelSoftware/EiffelStudio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/EiffelSoftware/EiffelStudio/statuses/{sha}","languages_url":"https://api.github.com/repos/EiffelSoftware/EiffelStudio/languages","stargazers_url":"https://api.github.com/repos/EiffelSoftware/EiffelStudio/stargazers","contributors_url":"https://api.github.com/repos/EiffelSoftware/EiffelStudio/contributors","subscribers_url":"https://api.github.com/repos/EiffelSoftware/EiffelStudio/subscribers","subscription_url":"https://api.github.com/repos/EiffelSoftware/EiffelStudio/subscription","commits_url":"https://api.github.com/repos/EiffelSoftware/EiffelStudio/commits{/sha}","git_commits_url":"https://api.github.com/repos/EiffelSoftware/EiffelStudio/git/commits{/sha}","comments_url":"https://api.github.com/repos/EiffelSoftware/EiffelStudio/comments{/number}","issue_comment_url":"https://api.github.com/repos/EiffelSoftware/EiffelStudio/issues/comments{/number}","contents_url":"https://api.github.com/repos/EiffelSoftware/EiffelStudio/contents/{+path}","compare_url":"https://api.github.com/repos/EiffelSoftware/EiffelStudio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/EiffelSoftware/EiffelStudio/merges","archive_url":"https://api.github.com/repos/EiffelSoftware/EiffelStudio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/EiffelSoftware/EiffelStudio/downloads","issues_url":"https://api.github.com/repos/EiffelSoftware/EiffelStudio/issues{/number}","pulls_url":"https://api.github.com/repos/EiffelSoftware/EiffelStudio/pulls{/number}","milestones_url":"https://api.github.com/repos/EiffelSoftware/EiffelStudio/milestones{/number}","notifications_url":"https://api.github.com/repos/EiffelSoftware/EiffelStudio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/EiffelSoftware/EiffelStudio/labels{/name}","releases_url":"https://api.github.com/repos/EiffelSoftware/EiffelStudio/releases{/id}","deployments_url":"https://api.github.com/repos/EiffelSoftware/EiffelStudio/deployments","created_at":"2016-06-12T03:16:16Z","updated_at":"2016-10-24T13:00:48Z","pushed_at":"2016-10-24T20:21:46Z","git_url":"git://github.com/EiffelSoftware/EiffelStudio.git","ssh_url":"git@github.com:EiffelSoftware/EiffelStudio.git","clone_url":"https://github.com/EiffelSoftware/EiffelStudio.git","svn_url":"https://github.com/EiffelSoftware/EiffelStudio","homepage":"","size":601655,"stargazers_count":6,"watchers_count":6,"language":"Eiffel","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":4,"forks":5,"open_issues":4,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/EiffelSoftware/EiffelStudio/pulls/9"},"html":{"href":"https://github.com/EiffelSoftware/EiffelStudio/pull/9"},"issue":{"href":"https://api.github.com/repos/EiffelSoftware/EiffelStudio/issues/9"},"comments":{"href":"https://api.github.com/repos/EiffelSoftware/EiffelStudio/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/EiffelSoftware/EiffelStudio/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/EiffelSoftware/EiffelStudio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/EiffelSoftware/EiffelStudio/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/EiffelSoftware/EiffelStudio/statuses/95fc313433120546b7c87247b2a500f3e0f7db02"}}}}
{"actor":{"display_login":"manuseiffel"}}