{"action":"created","issue":{"url":"https://api.github.com/repos/bvaughn/react-virtualized/issues/341","repository_url":"https://api.github.com/repos/bvaughn/react-virtualized","labels_url":"https://api.github.com/repos/bvaughn/react-virtualized/issues/341/labels{/name}","comments_url":"https://api.github.com/repos/bvaughn/react-virtualized/issues/341/comments","events_url":"https://api.github.com/repos/bvaughn/react-virtualized/issues/341/events","html_url":"https://github.com/bvaughn/react-virtualized/issues/341","id":169951504,"number":341,"title":"CellMeasurer optimizations","user":{"login":"kof","id":52824,"avatar_url":"https://avatars.githubusercontent.com/u/52824?v=3","gravatar_id":"","url":"https://api.github.com/users/kof","html_url":"https://github.com/kof","followers_url":"https://api.github.com/users/kof/followers","following_url":"https://api.github.com/users/kof/following{/other_user}","gists_url":"https://api.github.com/users/kof/gists{/gist_id}","starred_url":"https://api.github.com/users/kof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kof/subscriptions","organizations_url":"https://api.github.com/users/kof/orgs","repos_url":"https://api.github.com/users/kof/repos","events_url":"https://api.github.com/users/kof/events{/privacy}","received_events_url":"https://api.github.com/users/kof/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-08-08T15:28:51Z","updated_at":"2016-08-08T16:09:57Z","closed_at":null,"body":"Hey, I have seen you did a great job already. I am now about to drop my own custom implementation of the measurer and port everything to the latest react-virtualized.\r\n\r\nA few things I noticed are not good enough for my use case:\r\n\r\n## Row height caching.\r\n\r\nCurrent row height caching is done using the index. However in my case, it is not possible to cache by index, I need a different caching mechanism based on custom id's. \r\n\r\n## Row element caching.\r\n\r\nCurrently you create a row element twice, once for measuring, once for representation. I can introduce a caching in the user code, so element creation happens only once, however you might want to solve this in the library.\r\n\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/bvaughn/react-virtualized/issues/comments/238286559","html_url":"https://github.com/bvaughn/react-virtualized/issues/341#issuecomment-238286559","issue_url":"https://api.github.com/repos/bvaughn/react-virtualized/issues/341","id":238286559,"user":{"login":"bvaughn","id":29597,"avatar_url":"https://avatars.githubusercontent.com/u/29597?v=3","gravatar_id":"","url":"https://api.github.com/users/bvaughn","html_url":"https://github.com/bvaughn","followers_url":"https://api.github.com/users/bvaughn/followers","following_url":"https://api.github.com/users/bvaughn/following{/other_user}","gists_url":"https://api.github.com/users/bvaughn/gists{/gist_id}","starred_url":"https://api.github.com/users/bvaughn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bvaughn/subscriptions","organizations_url":"https://api.github.com/users/bvaughn/orgs","repos_url":"https://api.github.com/users/bvaughn/repos","events_url":"https://api.github.com/users/bvaughn/events{/privacy}","received_events_url":"https://api.github.com/users/bvaughn/received_events","type":"User","site_admin":false},"created_at":"2016-08-08T16:09:57Z","updated_at":"2016-08-08T16:09:57Z","body":"Hey @kof,\r\n\r\nNot sure how I could accommodate cache-by-id, since react-virtualized doesn't know anything about the underlying data (only that there's a collection of N items). Do you have a proposal in mind? Let's chat about it. :)\r\n\r\nI understand the appeal of managing row-element caching in the base library, but I'm not sure how it would be possible given the HOC approach of `CellMeasurer`. Again I would be open to suggestions here, but at least caching in user land is an option for the time being. :)"}}
{"actor":{"display_login":"bvaughn"}}