{"action":"created","issue":{"url":"https://api.github.com/repos/mapbox/mapbox-gl-js/issues/2172","repository_url":"https://api.github.com/repos/mapbox/mapbox-gl-js","labels_url":"https://api.github.com/repos/mapbox/mapbox-gl-js/issues/2172/labels{/name}","comments_url":"https://api.github.com/repos/mapbox/mapbox-gl-js/issues/2172/comments","events_url":"https://api.github.com/repos/mapbox/mapbox-gl-js/issues/2172/events","html_url":"https://github.com/mapbox/mapbox-gl-js/issues/2172","id":135563771,"number":2172,"title":"name of `shader` property of buckets","user":{"login":"ansis","id":1421652,"avatar_url":"https://avatars.githubusercontent.com/u/1421652?v=3","gravatar_id":"","url":"https://api.github.com/users/ansis","html_url":"https://github.com/ansis","followers_url":"https://api.github.com/users/ansis/followers","following_url":"https://api.github.com/users/ansis/following{/other_user}","gists_url":"https://api.github.com/users/ansis/gists{/gist_id}","starred_url":"https://api.github.com/users/ansis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansis/subscriptions","organizations_url":"https://api.github.com/users/ansis/orgs","repos_url":"https://api.github.com/users/ansis/repos","events_url":"https://api.github.com/users/ansis/events{/privacy}","received_events_url":"https://api.github.com/users/ansis/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-02-22T22:22:14Z","updated_at":"2016-02-22T23:20:44Z","closed_at":null,"body":"I'm not sure `shader` is the right name for [shader property of buckets](https://github.com/mapbox/mapbox-gl-js/blob/1ad40725cf925c61db2a6a80d18ff50144e85067/js/data/symbol_bucket.js#L83-L95). The buffers aren't necessarily 1-to-1 with a shader. `icon` could be rendered with either the sdf shader or the bitmap icon shader. Lines currently have one `shader` type in the bucket but three different shaders.\r\n\r\n@lucaswoj "},"comment":{"url":"https://api.github.com/repos/mapbox/mapbox-gl-js/issues/comments/187433232","html_url":"https://github.com/mapbox/mapbox-gl-js/issues/2172#issuecomment-187433232","issue_url":"https://api.github.com/repos/mapbox/mapbox-gl-js/issues/2172","id":187433232,"user":{"login":"ansis","id":1421652,"avatar_url":"https://avatars.githubusercontent.com/u/1421652?v=3","gravatar_id":"","url":"https://api.github.com/users/ansis","html_url":"https://github.com/ansis","followers_url":"https://api.github.com/users/ansis/followers","following_url":"https://api.github.com/users/ansis/following{/other_user}","gists_url":"https://api.github.com/users/ansis/gists{/gist_id}","starred_url":"https://api.github.com/users/ansis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansis/subscriptions","organizations_url":"https://api.github.com/users/ansis/orgs","repos_url":"https://api.github.com/users/ansis/repos","events_url":"https://api.github.com/users/ansis/events{/privacy}","received_events_url":"https://api.github.com/users/ansis/received_events","type":"User","site_admin":false},"created_at":"2016-02-22T23:20:44Z","updated_at":"2016-02-22T23:20:44Z","body":"> Do you think shaderInterfaces is a better name?\r\n\r\nSounds good to me. That one extra word clarified it a ton for me.\r\n\r\n> It is currently a 1-to-n relationship.\r\n\r\nIt's currently n-to-n.\r\n\r\n> Yes, that is why there are two entires in the shaders data structure. (glyph and icon)\r\n\r\nThe `icon` shader interface is used with two shaders. `sdf` can be true or false for icons: https://github.com/mapbox/mapbox-gl-js/blob/master/js/render/draw_symbol.js#L111-L115\r\n\r\nIcons and glyphs should have one shared shader interface but two separate buffer instances. The shader instances and buffer/elementgroup instances should be 1-to-n.\r\n\r\nThis isn't anything urgent. It just confused me for a bit."}}