{"action":"created","comment":{"url":"https://api.github.com/repos/eslint/eslint/pulls/comments/50923423","id":50923423,"diff_hunk":"@@ -1063,6 +1064,43 @@ target.checkGitCommit = function() {\n };\n \n /**\n+ * Downloads a repository which has many js files to test performance with multi files.\n+ * Here, it's eslint@1.10.3 (450 files)\n+ * @param {function} cb - A callback function.\n+ * @returns {void}\n+ */\n+function downloadMultifilesTestTarget(cb) {","path":"Makefile.js","position":33,"original_position":33,"commit_id":"274ab194f903eeb4a1ffd6b9a889b89b92187115","original_commit_id":"274ab194f903eeb4a1ffd6b9a889b89b92187115","user":{"login":"mysticatea","id":1937871,"avatar_url":"https://avatars.githubusercontent.com/u/1937871?v=3","gravatar_id":"","url":"https://api.github.com/users/mysticatea","html_url":"https://github.com/mysticatea","followers_url":"https://api.github.com/users/mysticatea/followers","following_url":"https://api.github.com/users/mysticatea/following{/other_user}","gists_url":"https://api.github.com/users/mysticatea/gists{/gist_id}","starred_url":"https://api.github.com/users/mysticatea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mysticatea/subscriptions","organizations_url":"https://api.github.com/users/mysticatea/orgs","repos_url":"https://api.github.com/users/mysticatea/repos","events_url":"https://api.github.com/users/mysticatea/events{/privacy}","received_events_url":"https://api.github.com/users/mysticatea/received_events","type":"User","site_admin":false},"body":"Make sense. I had forgotten the temp directory exists.","created_at":"2016-01-27T00:11:01Z","updated_at":"2016-01-27T00:11:01Z","html_url":"https://github.com/eslint/eslint/pull/5061#discussion_r50923423","pull_request_url":"https://api.github.com/repos/eslint/eslint/pulls/5061","_links":{"self":{"href":"https://api.github.com/repos/eslint/eslint/pulls/comments/50923423"},"html":{"href":"https://github.com/eslint/eslint/pull/5061#discussion_r50923423"},"pull_request":{"href":"https://api.github.com/repos/eslint/eslint/pulls/5061"}}},"pull_request":{"url":"https://api.github.com/repos/eslint/eslint/pulls/5061","id":57060282,"html_url":"https://github.com/eslint/eslint/pull/5061","diff_url":"https://github.com/eslint/eslint/pull/5061.diff","patch_url":"https://github.com/eslint/eslint/pull/5061.patch","issue_url":"https://api.github.com/repos/eslint/eslint/issues/5061","number":5061,"state":"open","locked":false,"title":"Build: Improve `npm run perf` command (fixes #5028)","user":{"login":"mysticatea","id":1937871,"avatar_url":"https://avatars.githubusercontent.com/u/1937871?v=3","gravatar_id":"","url":"https://api.github.com/users/mysticatea","html_url":"https://github.com/mysticatea","followers_url":"https://api.github.com/users/mysticatea/followers","following_url":"https://api.github.com/users/mysticatea/following{/other_user}","gists_url":"https://api.github.com/users/mysticatea/gists{/gist_id}","starred_url":"https://api.github.com/users/mysticatea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mysticatea/subscriptions","organizations_url":"https://api.github.com/users/mysticatea/orgs","repos_url":"https://api.github.com/users/mysticatea/repos","events_url":"https://api.github.com/users/mysticatea/events{/privacy}","received_events_url":"https://api.github.com/users/mysticatea/received_events","type":"User","site_admin":false},"body":"Fixes #5028.\r\n\r\n- A performance test for multi files was added. \r\n  This test is using `eslint@1.10.3` as the test target.\r\n  This repository has 450 js files in `lib` and `tests/lib` :)\r\n- `.eslintrc` of performance tests came to turn all rules on.\r\n\r\nThis is new output of this PR:\r\n\r\n```\r\n> eslint@2.0.0-beta.2 perf C:\\Users\\t-nagashima.AD\\Documents\\GitHub\\eslint\r\n> node Makefile.js perf\r\n\r\nLoading:\r\n  Load performance Run #1:  193.219655ms\r\n  Load performance Run #2:  193.38688ms\r\n  Load performance Run #3:  191.784973ms\r\n  Load performance Run #4:  191.239836ms\r\n  Load performance Run #5:  203.159501ms\r\n\r\n  Load Performance median:  193.219655ms\r\n\r\n\r\nSingle File:\r\n  CPU Speed is 3392 with multiplier 13000000\r\n  Performance Run #1:  3749.119887ms\r\n  Performance Run #2:  3758.879529ms\r\n  Performance Run #3:  3745.368525ms\r\n  Performance Run #4:  3815.086891ms\r\n  Performance Run #5:  3864.7341969999998ms\r\n\r\n  Performance budget ok:  3758.879529ms (limit: 3832.5471698113206ms)\r\n\r\n\r\nMulti Files (450 files):\r\n  CPU Speed is 3392 with multiplier 39000000\r\n  Performance Run #1:  9994.710723ms\r\n  Performance Run #2:  9995.715573ms\r\n  Performance Run #3:  10048.651208ms\r\n  Performance Run #4:  10047.002517ms\r\n  Performance Run #5:  9964.838064ms\r\n\r\n  Performance budget ok:  9995.715573ms (limit: 11497.641509433963ms)\r\n```\r\n\r\nThe loading performance test is the fastest, so I moved it to the first.","created_at":"2016-01-25T11:42:13Z","updated_at":"2016-01-27T00:11:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b7b1ccb7a4a7b443cfa9362f253977c0d9b8404e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/eslint/eslint/pulls/5061/commits","review_comments_url":"https://api.github.com/repos/eslint/eslint/pulls/5061/comments","review_comment_url":"https://api.github.com/repos/eslint/eslint/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eslint/eslint/issues/5061/comments","statuses_url":"https://api.github.com/repos/eslint/eslint/statuses/274ab194f903eeb4a1ffd6b9a889b89b92187115","head":{"label":"mysticatea:infra/improve-npm-run-perf","ref":"infra/improve-npm-run-perf","sha":"274ab194f903eeb4a1ffd6b9a889b89b92187115","user":{"login":"mysticatea","id":1937871,"avatar_url":"https://avatars.githubusercontent.com/u/1937871?v=3","gravatar_id":"","url":"https://api.github.com/users/mysticatea","html_url":"https://github.com/mysticatea","followers_url":"https://api.github.com/users/mysticatea/followers","following_url":"https://api.github.com/users/mysticatea/following{/other_user}","gists_url":"https://api.github.com/users/mysticatea/gists{/gist_id}","starred_url":"https://api.github.com/users/mysticatea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mysticatea/subscriptions","organizations_url":"https://api.github.com/users/mysticatea/orgs","repos_url":"https://api.github.com/users/mysticatea/repos","events_url":"https://api.github.com/users/mysticatea/events{/privacy}","received_events_url":"https://api.github.com/users/mysticatea/received_events","type":"User","site_admin":false},"repo":{"id":34937068,"name":"eslint","full_name":"mysticatea/eslint","owner":{"login":"mysticatea","id":1937871,"avatar_url":"https://avatars.githubusercontent.com/u/1937871?v=3","gravatar_id":"","url":"https://api.github.com/users/mysticatea","html_url":"https://github.com/mysticatea","followers_url":"https://api.github.com/users/mysticatea/followers","following_url":"https://api.github.com/users/mysticatea/following{/other_user}","gists_url":"https://api.github.com/users/mysticatea/gists{/gist_id}","starred_url":"https://api.github.com/users/mysticatea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mysticatea/subscriptions","organizations_url":"https://api.github.com/users/mysticatea/orgs","repos_url":"https://api.github.com/users/mysticatea/repos","events_url":"https://api.github.com/users/mysticatea/events{/privacy}","received_events_url":"https://api.github.com/users/mysticatea/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mysticatea/eslint","description":"A fully pluggable tool for identifying and reporting on patterns in JavaScript.","fork":true,"url":"https://api.github.com/repos/mysticatea/eslint","forks_url":"https://api.github.com/repos/mysticatea/eslint/forks","keys_url":"https://api.github.com/repos/mysticatea/eslint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mysticatea/eslint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mysticatea/eslint/teams","hooks_url":"https://api.github.com/repos/mysticatea/eslint/hooks","issue_events_url":"https://api.github.com/repos/mysticatea/eslint/issues/events{/number}","events_url":"https://api.github.com/repos/mysticatea/eslint/events","assignees_url":"https://api.github.com/repos/mysticatea/eslint/assignees{/user}","branches_url":"https://api.github.com/repos/mysticatea/eslint/branches{/branch}","tags_url":"https://api.github.com/repos/mysticatea/eslint/tags","blobs_url":"https://api.github.com/repos/mysticatea/eslint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mysticatea/eslint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mysticatea/eslint/git/refs{/sha}","trees_url":"https://api.github.com/repos/mysticatea/eslint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mysticatea/eslint/statuses/{sha}","languages_url":"https://api.github.com/repos/mysticatea/eslint/languages","stargazers_url":"https://api.github.com/repos/mysticatea/eslint/stargazers","contributors_url":"https://api.github.com/repos/mysticatea/eslint/contributors","subscribers_url":"https://api.github.com/repos/mysticatea/eslint/subscribers","subscription_url":"https://api.github.com/repos/mysticatea/eslint/subscription","commits_url":"https://api.github.com/repos/mysticatea/eslint/commits{/sha}","git_commits_url":"https://api.github.com/repos/mysticatea/eslint/git/commits{/sha}","comments_url":"https://api.github.com/repos/mysticatea/eslint/comments{/number}","issue_comment_url":"https://api.github.com/repos/mysticatea/eslint/issues/comments{/number}","contents_url":"https://api.github.com/repos/mysticatea/eslint/contents/{+path}","compare_url":"https://api.github.com/repos/mysticatea/eslint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mysticatea/eslint/merges","archive_url":"https://api.github.com/repos/mysticatea/eslint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mysticatea/eslint/downloads","issues_url":"https://api.github.com/repos/mysticatea/eslint/issues{/number}","pulls_url":"https://api.github.com/repos/mysticatea/eslint/pulls{/number}","milestones_url":"https://api.github.com/repos/mysticatea/eslint/milestones{/number}","notifications_url":"https://api.github.com/repos/mysticatea/eslint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mysticatea/eslint/labels{/name}","releases_url":"https://api.github.com/repos/mysticatea/eslint/releases{/id}","deployments_url":"https://api.github.com/repos/mysticatea/eslint/deployments","created_at":"2015-05-02T05:43:17Z","updated_at":"2015-05-02T05:43:21Z","pushed_at":"2016-01-25T20:05:26Z","git_url":"git://github.com/mysticatea/eslint.git","ssh_url":"git@github.com:mysticatea/eslint.git","clone_url":"https://github.com/mysticatea/eslint.git","svn_url":"https://github.com/mysticatea/eslint","homepage":"http://eslint.org","size":9358,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"block-scoped-var/scratch-log"}},"base":{"label":"eslint:master","ref":"master","sha":"8c870e4f505d63ec9163c9376dda6eb9e58c12ab","user":{"login":"eslint","id":6019716,"avatar_url":"https://avatars.githubusercontent.com/u/6019716?v=3","gravatar_id":"","url":"https://api.github.com/users/eslint","html_url":"https://github.com/eslint","followers_url":"https://api.github.com/users/eslint/followers","following_url":"https://api.github.com/users/eslint/following{/other_user}","gists_url":"https://api.github.com/users/eslint/gists{/gist_id}","starred_url":"https://api.github.com/users/eslint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eslint/subscriptions","organizations_url":"https://api.github.com/users/eslint/orgs","repos_url":"https://api.github.com/users/eslint/repos","events_url":"https://api.github.com/users/eslint/events{/privacy}","received_events_url":"https://api.github.com/users/eslint/received_events","type":"Organization","site_admin":false},"repo":{"id":11061773,"name":"eslint","full_name":"eslint/eslint","owner":{"login":"eslint","id":6019716,"avatar_url":"https://avatars.githubusercontent.com/u/6019716?v=3","gravatar_id":"","url":"https://api.github.com/users/eslint","html_url":"https://github.com/eslint","followers_url":"https://api.github.com/users/eslint/followers","following_url":"https://api.github.com/users/eslint/following{/other_user}","gists_url":"https://api.github.com/users/eslint/gists{/gist_id}","starred_url":"https://api.github.com/users/eslint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eslint/subscriptions","organizations_url":"https://api.github.com/users/eslint/orgs","repos_url":"https://api.github.com/users/eslint/repos","events_url":"https://api.github.com/users/eslint/events{/privacy}","received_events_url":"https://api.github.com/users/eslint/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eslint/eslint","description":"A fully pluggable tool for identifying and reporting on patterns in JavaScript.","fork":false,"url":"https://api.github.com/repos/eslint/eslint","forks_url":"https://api.github.com/repos/eslint/eslint/forks","keys_url":"https://api.github.com/repos/eslint/eslint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eslint/eslint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eslint/eslint/teams","hooks_url":"https://api.github.com/repos/eslint/eslint/hooks","issue_events_url":"https://api.github.com/repos/eslint/eslint/issues/events{/number}","events_url":"https://api.github.com/repos/eslint/eslint/events","assignees_url":"https://api.github.com/repos/eslint/eslint/assignees{/user}","branches_url":"https://api.github.com/repos/eslint/eslint/branches{/branch}","tags_url":"https://api.github.com/repos/eslint/eslint/tags","blobs_url":"https://api.github.com/repos/eslint/eslint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eslint/eslint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eslint/eslint/git/refs{/sha}","trees_url":"https://api.github.com/repos/eslint/eslint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eslint/eslint/statuses/{sha}","languages_url":"https://api.github.com/repos/eslint/eslint/languages","stargazers_url":"https://api.github.com/repos/eslint/eslint/stargazers","contributors_url":"https://api.github.com/repos/eslint/eslint/contributors","subscribers_url":"https://api.github.com/repos/eslint/eslint/subscribers","subscription_url":"https://api.github.com/repos/eslint/eslint/subscription","commits_url":"https://api.github.com/repos/eslint/eslint/commits{/sha}","git_commits_url":"https://api.github.com/repos/eslint/eslint/git/commits{/sha}","comments_url":"https://api.github.com/repos/eslint/eslint/comments{/number}","issue_comment_url":"https://api.github.com/repos/eslint/eslint/issues/comments{/number}","contents_url":"https://api.github.com/repos/eslint/eslint/contents/{+path}","compare_url":"https://api.github.com/repos/eslint/eslint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eslint/eslint/merges","archive_url":"https://api.github.com/repos/eslint/eslint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eslint/eslint/downloads","issues_url":"https://api.github.com/repos/eslint/eslint/issues{/number}","pulls_url":"https://api.github.com/repos/eslint/eslint/pulls{/number}","milestones_url":"https://api.github.com/repos/eslint/eslint/milestones{/number}","notifications_url":"https://api.github.com/repos/eslint/eslint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eslint/eslint/labels{/name}","releases_url":"https://api.github.com/repos/eslint/eslint/releases{/id}","deployments_url":"https://api.github.com/repos/eslint/eslint/deployments","created_at":"2013-06-29T23:59:48Z","updated_at":"2016-01-27T00:05:15Z","pushed_at":"2016-01-26T21:51:20Z","git_url":"git://github.com/eslint/eslint.git","ssh_url":"git@github.com:eslint/eslint.git","clone_url":"https://github.com/eslint/eslint.git","svn_url":"https://github.com/eslint/eslint","homepage":"http://eslint.org","size":12324,"stargazers_count":3858,"watchers_count":3858,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":746,"mirror_url":null,"open_issues_count":164,"forks":746,"open_issues":164,"watchers":3858,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eslint/eslint/pulls/5061"},"html":{"href":"https://github.com/eslint/eslint/pull/5061"},"issue":{"href":"https://api.github.com/repos/eslint/eslint/issues/5061"},"comments":{"href":"https://api.github.com/repos/eslint/eslint/issues/5061/comments"},"review_comments":{"href":"https://api.github.com/repos/eslint/eslint/pulls/5061/comments"},"review_comment":{"href":"https://api.github.com/repos/eslint/eslint/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eslint/eslint/pulls/5061/commits"},"statuses":{"href":"https://api.github.com/repos/eslint/eslint/statuses/274ab194f903eeb4a1ffd6b9a889b89b92187115"}}}}