{"action":"created","comment":{"url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/pulls/comments/57334294","id":57334294,"diff_hunk":"@@ -150,13 +143,24 @@ public void Prepare(CancellationToken token)\n                 }\n \n                 RuleSetInformation info = keyValue.Value;\n-                RuleSetGroup group = keyValue.Key;\n-                Debug.Assert(info.NewRuleSetFilePath == null, \"Not expected to be called twice\");\n+                Debug.Assert(!string.IsNullOrWhiteSpace(info.NewRuleSetFilePath), \"Expected to be set during registration time\");\n \n-                info.NewRuleSetFilePath = this.QueueWriteSolutionLevelRuleSet(this.SolutionFullPath, info.RuleSet, fileNameSuffix: group.ToString());\n+                this.sourceControlledFileSystem.QueueFileWrite(info.NewRuleSetFilePath, () =>\n+                {\n+                    string ruleSetDirectoryPath = Path.GetDirectoryName(info.NewRuleSetFilePath);\n+                    if (!this.sourceControlledFileSystem.DirectoryExists(ruleSetDirectoryPath))\n+                    {\n+                        this.sourceControlledFileSystem.CreateDirectory(ruleSetDirectoryPath);","path":"src/Integration/Binding/SolutionBindingOperation.cs","position":123,"original_position":123,"commit_id":"697d251c995cefc6ea0379abac5f28c08837509f","original_commit_id":"697d251c995cefc6ea0379abac5f28c08837509f","user":{"login":"mjcheetham","id":5658207,"avatar_url":"https://avatars.githubusercontent.com/u/5658207?v=3","gravatar_id":"","url":"https://api.github.com/users/mjcheetham","html_url":"https://github.com/mjcheetham","followers_url":"https://api.github.com/users/mjcheetham/followers","following_url":"https://api.github.com/users/mjcheetham/following{/other_user}","gists_url":"https://api.github.com/users/mjcheetham/gists{/gist_id}","starred_url":"https://api.github.com/users/mjcheetham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjcheetham/subscriptions","organizations_url":"https://api.github.com/users/mjcheetham/orgs","repos_url":"https://api.github.com/users/mjcheetham/repos","events_url":"https://api.github.com/users/mjcheetham/events{/privacy}","received_events_url":"https://api.github.com/users/mjcheetham/received_events","type":"User","site_admin":false},"body":"No need to check if the directory exists first. Create will be a no-op is it exists.","created_at":"2016-03-24T15:25:30Z","updated_at":"2016-03-24T15:25:30Z","html_url":"https://github.com/SonarSource-VisualStudio/sonarlint-visualstudio/pull/37#discussion_r57334294","pull_request_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/pulls/37","_links":{"self":{"href":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/pulls/comments/57334294"},"html":{"href":"https://github.com/SonarSource-VisualStudio/sonarlint-visualstudio/pull/37#discussion_r57334294"},"pull_request":{"href":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/pulls/37"}}},"pull_request":{"url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/pulls/37","id":64020559,"html_url":"https://github.com/SonarSource-VisualStudio/sonarlint-visualstudio/pull/37","diff_url":"https://github.com/SonarSource-VisualStudio/sonarlint-visualstudio/pull/37.diff","patch_url":"https://github.com/SonarSource-VisualStudio/sonarlint-visualstudio/pull/37.patch","issue_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/issues/37","number":37,"state":"open","locked":false,"title":"[SVS-7] preparation for solution level conflict detection (will be done after this one)","user":{"login":"eyalantzMS","id":16574964,"avatar_url":"https://avatars.githubusercontent.com/u/16574964?v=3","gravatar_id":"","url":"https://api.github.com/users/eyalantzMS","html_url":"https://github.com/eyalantzMS","followers_url":"https://api.github.com/users/eyalantzMS/followers","following_url":"https://api.github.com/users/eyalantzMS/following{/other_user}","gists_url":"https://api.github.com/users/eyalantzMS/gists{/gist_id}","starred_url":"https://api.github.com/users/eyalantzMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eyalantzMS/subscriptions","organizations_url":"https://api.github.com/users/eyalantzMS/orgs","repos_url":"https://api.github.com/users/eyalantzMS/repos","events_url":"https://api.github.com/users/eyalantzMS/events{/privacy}","received_events_url":"https://api.github.com/users/eyalantzMS/received_events","type":"User","site_admin":false},"body":"1. Moved all the service-liked interfaces to be serviced by the host - this helped to simplify the test specific service injection and simplified the product code that in most cases no longer needs those interfaces to be passed from an internal constructor.\r\nNote: this was done only for binding bits, and we should do something similar next time when working on the connection bits.\r\n\r\n2. Extracted the logic from binding into a service that will be used in the last piece (i.e. find and fix conflicts in the entire solution).\r\n\r\n[EDIT] 3: Added support for pulling rule set directories (another property) and to pass it into conflicts finding/fixing API.\r\n\r\nI also included a code example (BindingController.CheckForConflicts) that I'll be aiming for in the last PR for this feature. In general there will be a service that I can invoke from other places and not just after binding, although in those case we will need to address some of the edge cases which I don't plan on handling at first (need to get initial feedback from Jean-Marc first).","created_at":"2016-03-24T11:24:08Z","updated_at":"2016-03-24T15:25:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6699dbca84870a3e7e0e7d5f8b6ddf1db8845747","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/pulls/37/commits","review_comments_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/pulls/37/comments","review_comment_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/issues/37/comments","statuses_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/statuses/697d251c995cefc6ea0379abac5f28c08837509f","head":{"label":"SonarSource-VisualStudio:SVS-7","ref":"SVS-7","sha":"697d251c995cefc6ea0379abac5f28c08837509f","user":{"login":"SonarSource-VisualStudio","id":16780579,"avatar_url":"https://avatars.githubusercontent.com/u/16780579?v=3","gravatar_id":"","url":"https://api.github.com/users/SonarSource-VisualStudio","html_url":"https://github.com/SonarSource-VisualStudio","followers_url":"https://api.github.com/users/SonarSource-VisualStudio/followers","following_url":"https://api.github.com/users/SonarSource-VisualStudio/following{/other_user}","gists_url":"https://api.github.com/users/SonarSource-VisualStudio/gists{/gist_id}","starred_url":"https://api.github.com/users/SonarSource-VisualStudio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SonarSource-VisualStudio/subscriptions","organizations_url":"https://api.github.com/users/SonarSource-VisualStudio/orgs","repos_url":"https://api.github.com/users/SonarSource-VisualStudio/repos","events_url":"https://api.github.com/users/SonarSource-VisualStudio/events{/privacy}","received_events_url":"https://api.github.com/users/SonarSource-VisualStudio/received_events","type":"Organization","site_admin":false},"repo":{"id":50510037,"name":"sonarlint-visualstudio","full_name":"SonarSource-VisualStudio/sonarlint-visualstudio","owner":{"login":"SonarSource-VisualStudio","id":16780579,"avatar_url":"https://avatars.githubusercontent.com/u/16780579?v=3","gravatar_id":"","url":"https://api.github.com/users/SonarSource-VisualStudio","html_url":"https://github.com/SonarSource-VisualStudio","followers_url":"https://api.github.com/users/SonarSource-VisualStudio/followers","following_url":"https://api.github.com/users/SonarSource-VisualStudio/following{/other_user}","gists_url":"https://api.github.com/users/SonarSource-VisualStudio/gists{/gist_id}","starred_url":"https://api.github.com/users/SonarSource-VisualStudio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SonarSource-VisualStudio/subscriptions","organizations_url":"https://api.github.com/users/SonarSource-VisualStudio/orgs","repos_url":"https://api.github.com/users/SonarSource-VisualStudio/repos","events_url":"https://api.github.com/users/SonarSource-VisualStudio/events{/privacy}","received_events_url":"https://api.github.com/users/SonarSource-VisualStudio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SonarSource-VisualStudio/sonarlint-visualstudio","description":"","fork":false,"url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio","forks_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/forks","keys_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/teams","hooks_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/hooks","issue_events_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/issues/events{/number}","events_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/events","assignees_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/assignees{/user}","branches_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/branches{/branch}","tags_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/tags","blobs_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/git/refs{/sha}","trees_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/statuses/{sha}","languages_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/languages","stargazers_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/stargazers","contributors_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/contributors","subscribers_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/subscribers","subscription_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/subscription","commits_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/commits{/sha}","git_commits_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/git/commits{/sha}","comments_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/comments{/number}","issue_comment_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/issues/comments{/number}","contents_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/contents/{+path}","compare_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/merges","archive_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/downloads","issues_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/issues{/number}","pulls_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/pulls{/number}","milestones_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/milestones{/number}","notifications_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/labels{/name}","releases_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/releases{/id}","deployments_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/deployments","created_at":"2016-01-27T13:44:12Z","updated_at":"2016-03-16T22:01:55Z","pushed_at":"2016-03-24T11:24:09Z","git_url":"git://github.com/SonarSource-VisualStudio/sonarlint-visualstudio.git","ssh_url":"git@github.com:SonarSource-VisualStudio/sonarlint-visualstudio.git","clone_url":"https://github.com/SonarSource-VisualStudio/sonarlint-visualstudio.git","svn_url":"https://github.com/SonarSource-VisualStudio/sonarlint-visualstudio","homepage":null,"size":1029,"stargazers_count":4,"watchers_count":4,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":1,"forks":5,"open_issues":1,"watchers":4,"default_branch":"master"}},"base":{"label":"SonarSource-VisualStudio:master","ref":"master","sha":"e692bd9b346073d0e2ac3531b40b989f4b57bf4d","user":{"login":"SonarSource-VisualStudio","id":16780579,"avatar_url":"https://avatars.githubusercontent.com/u/16780579?v=3","gravatar_id":"","url":"https://api.github.com/users/SonarSource-VisualStudio","html_url":"https://github.com/SonarSource-VisualStudio","followers_url":"https://api.github.com/users/SonarSource-VisualStudio/followers","following_url":"https://api.github.com/users/SonarSource-VisualStudio/following{/other_user}","gists_url":"https://api.github.com/users/SonarSource-VisualStudio/gists{/gist_id}","starred_url":"https://api.github.com/users/SonarSource-VisualStudio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SonarSource-VisualStudio/subscriptions","organizations_url":"https://api.github.com/users/SonarSource-VisualStudio/orgs","repos_url":"https://api.github.com/users/SonarSource-VisualStudio/repos","events_url":"https://api.github.com/users/SonarSource-VisualStudio/events{/privacy}","received_events_url":"https://api.github.com/users/SonarSource-VisualStudio/received_events","type":"Organization","site_admin":false},"repo":{"id":50510037,"name":"sonarlint-visualstudio","full_name":"SonarSource-VisualStudio/sonarlint-visualstudio","owner":{"login":"SonarSource-VisualStudio","id":16780579,"avatar_url":"https://avatars.githubusercontent.com/u/16780579?v=3","gravatar_id":"","url":"https://api.github.com/users/SonarSource-VisualStudio","html_url":"https://github.com/SonarSource-VisualStudio","followers_url":"https://api.github.com/users/SonarSource-VisualStudio/followers","following_url":"https://api.github.com/users/SonarSource-VisualStudio/following{/other_user}","gists_url":"https://api.github.com/users/SonarSource-VisualStudio/gists{/gist_id}","starred_url":"https://api.github.com/users/SonarSource-VisualStudio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SonarSource-VisualStudio/subscriptions","organizations_url":"https://api.github.com/users/SonarSource-VisualStudio/orgs","repos_url":"https://api.github.com/users/SonarSource-VisualStudio/repos","events_url":"https://api.github.com/users/SonarSource-VisualStudio/events{/privacy}","received_events_url":"https://api.github.com/users/SonarSource-VisualStudio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SonarSource-VisualStudio/sonarlint-visualstudio","description":"","fork":false,"url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio","forks_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/forks","keys_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/teams","hooks_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/hooks","issue_events_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/issues/events{/number}","events_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/events","assignees_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/assignees{/user}","branches_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/branches{/branch}","tags_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/tags","blobs_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/git/refs{/sha}","trees_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/statuses/{sha}","languages_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/languages","stargazers_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/stargazers","contributors_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/contributors","subscribers_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/subscribers","subscription_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/subscription","commits_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/commits{/sha}","git_commits_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/git/commits{/sha}","comments_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/comments{/number}","issue_comment_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/issues/comments{/number}","contents_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/contents/{+path}","compare_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/merges","archive_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/downloads","issues_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/issues{/number}","pulls_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/pulls{/number}","milestones_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/milestones{/number}","notifications_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/labels{/name}","releases_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/releases{/id}","deployments_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/deployments","created_at":"2016-01-27T13:44:12Z","updated_at":"2016-03-16T22:01:55Z","pushed_at":"2016-03-24T11:24:09Z","git_url":"git://github.com/SonarSource-VisualStudio/sonarlint-visualstudio.git","ssh_url":"git@github.com:SonarSource-VisualStudio/sonarlint-visualstudio.git","clone_url":"https://github.com/SonarSource-VisualStudio/sonarlint-visualstudio.git","svn_url":"https://github.com/SonarSource-VisualStudio/sonarlint-visualstudio","homepage":null,"size":1029,"stargazers_count":4,"watchers_count":4,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":1,"forks":5,"open_issues":1,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/pulls/37"},"html":{"href":"https://github.com/SonarSource-VisualStudio/sonarlint-visualstudio/pull/37"},"issue":{"href":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/issues/37"},"comments":{"href":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/issues/37/comments"},"review_comments":{"href":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/pulls/37/comments"},"review_comment":{"href":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/pulls/37/commits"},"statuses":{"href":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/statuses/697d251c995cefc6ea0379abac5f28c08837509f"}}}}