{"action":"created","comment":{"url":"https://api.github.com/repos/JMRI/JMRI/pulls/comments/86272574","pull_request_review_id":6938513,"id":86272574,"diff_hunk":"@@ -233,6 +237,7 @@ Origin          = Origin: {0}\n Halt            = Halt\n Resume          = Resume\n Retry           = Move into next block\n+Stop\t\t\t= Stop","path":"java/src/jmri/jmrit/logix/WarrantBundle.properties","position":40,"original_position":40,"commit_id":"a21cb47be05725970079cd75b0e873f5bcae0a1a","original_commit_id":"a21cb47be05725970079cd75b0e873f5bcae0a1a","user":{"login":"petecressman","id":14208129,"avatar_url":"https://avatars.githubusercontent.com/u/14208129?v=3","gravatar_id":"","url":"https://api.github.com/users/petecressman","html_url":"https://github.com/petecressman","followers_url":"https://api.github.com/users/petecressman/followers","following_url":"https://api.github.com/users/petecressman/following{/other_user}","gists_url":"https://api.github.com/users/petecressman/gists{/gist_id}","starred_url":"https://api.github.com/users/petecressman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petecressman/subscriptions","organizations_url":"https://api.github.com/users/petecressman/orgs","repos_url":"https://api.github.com/users/petecressman/repos","events_url":"https://api.github.com/users/petecressman/events{/privacy}","received_events_url":"https://api.github.com/users/petecressman/received_events","type":"User","site_admin":false},"body":"Arrrg.. last minute add after testing.","created_at":"2016-11-03T00:47:05Z","updated_at":"2016-11-03T00:47:05Z","html_url":"https://github.com/JMRI/JMRI/pull/2457#discussion_r86272574","pull_request_url":"https://api.github.com/repos/JMRI/JMRI/pulls/2457","_links":{"self":{"href":"https://api.github.com/repos/JMRI/JMRI/pulls/comments/86272574"},"html":{"href":"https://github.com/JMRI/JMRI/pull/2457#discussion_r86272574"},"pull_request":{"href":"https://api.github.com/repos/JMRI/JMRI/pulls/2457"}}},"pull_request":{"url":"https://api.github.com/repos/JMRI/JMRI/pulls/2457","id":92061080,"html_url":"https://github.com/JMRI/JMRI/pull/2457","diff_url":"https://github.com/JMRI/JMRI/pull/2457.diff","patch_url":"https://github.com/JMRI/JMRI/pull/2457.patch","issue_url":"https://api.github.com/repos/JMRI/JMRI/issues/2457","number":2457,"state":"open","locked":false,"title":"Pete c double property change event","user":{"login":"petecressman","id":14208129,"avatar_url":"https://avatars.githubusercontent.com/u/14208129?v=3","gravatar_id":"","url":"https://api.github.com/users/petecressman","html_url":"https://github.com/petecressman","followers_url":"https://api.github.com/users/petecressman/followers","following_url":"https://api.github.com/users/petecressman/following{/other_user}","gists_url":"https://api.github.com/users/petecressman/gists{/gist_id}","starred_url":"https://api.github.com/users/petecressman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petecressman/subscriptions","organizations_url":"https://api.github.com/users/petecressman/orgs","repos_url":"https://api.github.com/users/petecressman/repos","events_url":"https://api.github.com/users/petecressman/events{/privacy}","received_events_url":"https://api.github.com/users/petecressman/received_events","type":"User","site_admin":false},"body":"Re-implemented the ramping code.  Should be more robust than the current version in handling signal and block occupancy speed restrictions and user interventions.\r\nNew features;\r\n1. The \"Halt\" GUI command now ramps down.  This makes user overrides a lot more prototypical looking, by bringing the train down to a stop smoothy\r\n2. A \"Stop\" GUI command has been added.   This is an EStop, similar to the old Halt command that was an immediate change to speed 0.\r\n3. The \"Resume\" GUI command now does a ramp up rather than immediate restoration of former speed.\r\n4. Ramps will use as many blocks as they need to change speed.  Previous ramp down code did not look ahead properly.  \r\n5. More running messages are supplied.\r\n6. Several bug fixes e.g: no more double entry in the session log.  Rogue occupancy while halted now accounted for.\r\n7. Rouge entry into a warrant route now changes the icon color.\r\n8.  Warrants can be started, ended and pass through Dark blocks.\r\n\r\n","created_at":"2016-11-02T21:40:42Z","updated_at":"2016-11-03T00:47:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4119c8d5291dbfc251176dd2023fdefc50594d72","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/JMRI/JMRI/pulls/2457/commits","review_comments_url":"https://api.github.com/repos/JMRI/JMRI/pulls/2457/comments","review_comment_url":"https://api.github.com/repos/JMRI/JMRI/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JMRI/JMRI/issues/2457/comments","statuses_url":"https://api.github.com/repos/JMRI/JMRI/statuses/a21cb47be05725970079cd75b0e873f5bcae0a1a","head":{"label":"petecressman:peteC-doublePropertyChangeEvent","ref":"peteC-doublePropertyChangeEvent","sha":"a21cb47be05725970079cd75b0e873f5bcae0a1a","user":{"login":"petecressman","id":14208129,"avatar_url":"https://avatars.githubusercontent.com/u/14208129?v=3","gravatar_id":"","url":"https://api.github.com/users/petecressman","html_url":"https://github.com/petecressman","followers_url":"https://api.github.com/users/petecressman/followers","following_url":"https://api.github.com/users/petecressman/following{/other_user}","gists_url":"https://api.github.com/users/petecressman/gists{/gist_id}","starred_url":"https://api.github.com/users/petecressman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petecressman/subscriptions","organizations_url":"https://api.github.com/users/petecressman/orgs","repos_url":"https://api.github.com/users/petecressman/repos","events_url":"https://api.github.com/users/petecressman/events{/privacy}","received_events_url":"https://api.github.com/users/petecressman/received_events","type":"User","site_admin":false},"repo":{"id":43786409,"name":"JMRI","full_name":"petecressman/JMRI","owner":{"login":"petecressman","id":14208129,"avatar_url":"https://avatars.githubusercontent.com/u/14208129?v=3","gravatar_id":"","url":"https://api.github.com/users/petecressman","html_url":"https://github.com/petecressman","followers_url":"https://api.github.com/users/petecressman/followers","following_url":"https://api.github.com/users/petecressman/following{/other_user}","gists_url":"https://api.github.com/users/petecressman/gists{/gist_id}","starred_url":"https://api.github.com/users/petecressman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petecressman/subscriptions","organizations_url":"https://api.github.com/users/petecressman/orgs","repos_url":"https://api.github.com/users/petecressman/repos","events_url":"https://api.github.com/users/petecressman/events{/privacy}","received_events_url":"https://api.github.com/users/petecressman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/petecressman/JMRI","description":"JMRI model railroad digital command & control software","fork":true,"url":"https://api.github.com/repos/petecressman/JMRI","forks_url":"https://api.github.com/repos/petecressman/JMRI/forks","keys_url":"https://api.github.com/repos/petecressman/JMRI/keys{/key_id}","collaborators_url":"https://api.github.com/repos/petecressman/JMRI/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/petecressman/JMRI/teams","hooks_url":"https://api.github.com/repos/petecressman/JMRI/hooks","issue_events_url":"https://api.github.com/repos/petecressman/JMRI/issues/events{/number}","events_url":"https://api.github.com/repos/petecressman/JMRI/events","assignees_url":"https://api.github.com/repos/petecressman/JMRI/assignees{/user}","branches_url":"https://api.github.com/repos/petecressman/JMRI/branches{/branch}","tags_url":"https://api.github.com/repos/petecressman/JMRI/tags","blobs_url":"https://api.github.com/repos/petecressman/JMRI/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/petecressman/JMRI/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/petecressman/JMRI/git/refs{/sha}","trees_url":"https://api.github.com/repos/petecressman/JMRI/git/trees{/sha}","statuses_url":"https://api.github.com/repos/petecressman/JMRI/statuses/{sha}","languages_url":"https://api.github.com/repos/petecressman/JMRI/languages","stargazers_url":"https://api.github.com/repos/petecressman/JMRI/stargazers","contributors_url":"https://api.github.com/repos/petecressman/JMRI/contributors","subscribers_url":"https://api.github.com/repos/petecressman/JMRI/subscribers","subscription_url":"https://api.github.com/repos/petecressman/JMRI/subscription","commits_url":"https://api.github.com/repos/petecressman/JMRI/commits{/sha}","git_commits_url":"https://api.github.com/repos/petecressman/JMRI/git/commits{/sha}","comments_url":"https://api.github.com/repos/petecressman/JMRI/comments{/number}","issue_comment_url":"https://api.github.com/repos/petecressman/JMRI/issues/comments{/number}","contents_url":"https://api.github.com/repos/petecressman/JMRI/contents/{+path}","compare_url":"https://api.github.com/repos/petecressman/JMRI/compare/{base}...{head}","merges_url":"https://api.github.com/repos/petecressman/JMRI/merges","archive_url":"https://api.github.com/repos/petecressman/JMRI/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/petecressman/JMRI/downloads","issues_url":"https://api.github.com/repos/petecressman/JMRI/issues{/number}","pulls_url":"https://api.github.com/repos/petecressman/JMRI/pulls{/number}","milestones_url":"https://api.github.com/repos/petecressman/JMRI/milestones{/number}","notifications_url":"https://api.github.com/repos/petecressman/JMRI/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/petecressman/JMRI/labels{/name}","releases_url":"https://api.github.com/repos/petecressman/JMRI/releases{/id}","deployments_url":"https://api.github.com/repos/petecressman/JMRI/deployments","created_at":"2015-10-07T00:18:32Z","updated_at":"2016-10-26T02:07:06Z","pushed_at":"2016-11-02T18:13:58Z","git_url":"git://github.com/petecressman/JMRI.git","ssh_url":"git@github.com:petecressman/JMRI.git","clone_url":"https://github.com/petecressman/JMRI.git","svn_url":"https://github.com/petecressman/JMRI","homepage":"http://jmri.org","size":1389532,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JMRI:master","ref":"master","sha":"7111ec41fea5489bd5629874eb76d99a8d75f324","user":{"login":"JMRI","id":13712710,"avatar_url":"https://avatars.githubusercontent.com/u/13712710?v=3","gravatar_id":"","url":"https://api.github.com/users/JMRI","html_url":"https://github.com/JMRI","followers_url":"https://api.github.com/users/JMRI/followers","following_url":"https://api.github.com/users/JMRI/following{/other_user}","gists_url":"https://api.github.com/users/JMRI/gists{/gist_id}","starred_url":"https://api.github.com/users/JMRI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JMRI/subscriptions","organizations_url":"https://api.github.com/users/JMRI/orgs","repos_url":"https://api.github.com/users/JMRI/repos","events_url":"https://api.github.com/users/JMRI/events{/privacy}","received_events_url":"https://api.github.com/users/JMRI/received_events","type":"Organization","site_admin":false},"repo":{"id":42789514,"name":"JMRI","full_name":"JMRI/JMRI","owner":{"login":"JMRI","id":13712710,"avatar_url":"https://avatars.githubusercontent.com/u/13712710?v=3","gravatar_id":"","url":"https://api.github.com/users/JMRI","html_url":"https://github.com/JMRI","followers_url":"https://api.github.com/users/JMRI/followers","following_url":"https://api.github.com/users/JMRI/following{/other_user}","gists_url":"https://api.github.com/users/JMRI/gists{/gist_id}","starred_url":"https://api.github.com/users/JMRI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JMRI/subscriptions","organizations_url":"https://api.github.com/users/JMRI/orgs","repos_url":"https://api.github.com/users/JMRI/repos","events_url":"https://api.github.com/users/JMRI/events{/privacy}","received_events_url":"https://api.github.com/users/JMRI/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JMRI/JMRI","description":"JMRI model railroad digital command & control software","fork":false,"url":"https://api.github.com/repos/JMRI/JMRI","forks_url":"https://api.github.com/repos/JMRI/JMRI/forks","keys_url":"https://api.github.com/repos/JMRI/JMRI/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JMRI/JMRI/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JMRI/JMRI/teams","hooks_url":"https://api.github.com/repos/JMRI/JMRI/hooks","issue_events_url":"https://api.github.com/repos/JMRI/JMRI/issues/events{/number}","events_url":"https://api.github.com/repos/JMRI/JMRI/events","assignees_url":"https://api.github.com/repos/JMRI/JMRI/assignees{/user}","branches_url":"https://api.github.com/repos/JMRI/JMRI/branches{/branch}","tags_url":"https://api.github.com/repos/JMRI/JMRI/tags","blobs_url":"https://api.github.com/repos/JMRI/JMRI/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JMRI/JMRI/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JMRI/JMRI/git/refs{/sha}","trees_url":"https://api.github.com/repos/JMRI/JMRI/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JMRI/JMRI/statuses/{sha}","languages_url":"https://api.github.com/repos/JMRI/JMRI/languages","stargazers_url":"https://api.github.com/repos/JMRI/JMRI/stargazers","contributors_url":"https://api.github.com/repos/JMRI/JMRI/contributors","subscribers_url":"https://api.github.com/repos/JMRI/JMRI/subscribers","subscription_url":"https://api.github.com/repos/JMRI/JMRI/subscription","commits_url":"https://api.github.com/repos/JMRI/JMRI/commits{/sha}","git_commits_url":"https://api.github.com/repos/JMRI/JMRI/git/commits{/sha}","comments_url":"https://api.github.com/repos/JMRI/JMRI/comments{/number}","issue_comment_url":"https://api.github.com/repos/JMRI/JMRI/issues/comments{/number}","contents_url":"https://api.github.com/repos/JMRI/JMRI/contents/{+path}","compare_url":"https://api.github.com/repos/JMRI/JMRI/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JMRI/JMRI/merges","archive_url":"https://api.github.com/repos/JMRI/JMRI/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JMRI/JMRI/downloads","issues_url":"https://api.github.com/repos/JMRI/JMRI/issues{/number}","pulls_url":"https://api.github.com/repos/JMRI/JMRI/pulls{/number}","milestones_url":"https://api.github.com/repos/JMRI/JMRI/milestones{/number}","notifications_url":"https://api.github.com/repos/JMRI/JMRI/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JMRI/JMRI/labels{/name}","releases_url":"https://api.github.com/repos/JMRI/JMRI/releases{/id}","deployments_url":"https://api.github.com/repos/JMRI/JMRI/deployments","created_at":"2015-09-19T21:01:07Z","updated_at":"2016-10-26T20:05:43Z","pushed_at":"2016-11-02T21:40:42Z","git_url":"git://github.com/JMRI/JMRI.git","ssh_url":"git@github.com:JMRI/JMRI.git","clone_url":"https://github.com/JMRI/JMRI.git","svn_url":"https://github.com/JMRI/JMRI","homepage":"http://jmri.org","size":1408823,"stargazers_count":27,"watchers_count":27,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":69,"mirror_url":null,"open_issues_count":68,"forks":69,"open_issues":68,"watchers":27,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JMRI/JMRI/pulls/2457"},"html":{"href":"https://github.com/JMRI/JMRI/pull/2457"},"issue":{"href":"https://api.github.com/repos/JMRI/JMRI/issues/2457"},"comments":{"href":"https://api.github.com/repos/JMRI/JMRI/issues/2457/comments"},"review_comments":{"href":"https://api.github.com/repos/JMRI/JMRI/pulls/2457/comments"},"review_comment":{"href":"https://api.github.com/repos/JMRI/JMRI/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JMRI/JMRI/pulls/2457/commits"},"statuses":{"href":"https://api.github.com/repos/JMRI/JMRI/statuses/a21cb47be05725970079cd75b0e873f5bcae0a1a"}}}}
{"actor":{"display_login":"petecressman"}}