{"action":"created","issue":{"url":"https://api.github.com/repos/tildeio/glimmer/issues/154","repository_url":"https://api.github.com/repos/tildeio/glimmer","labels_url":"https://api.github.com/repos/tildeio/glimmer/issues/154/labels{/name}","comments_url":"https://api.github.com/repos/tildeio/glimmer/issues/154/comments","events_url":"https://api.github.com/repos/tildeio/glimmer/issues/154/events","html_url":"https://github.com/tildeio/glimmer/pull/154","id":151935139,"number":154,"title":"added benchmark.js script tag to demos","user":{"login":"thomaspink","id":1368032,"avatar_url":"https://avatars.githubusercontent.com/u/1368032?v=3","gravatar_id":"","url":"https://api.github.com/users/thomaspink","html_url":"https://github.com/thomaspink","followers_url":"https://api.github.com/users/thomaspink/followers","following_url":"https://api.github.com/users/thomaspink/following{/other_user}","gists_url":"https://api.github.com/users/thomaspink/gists{/gist_id}","starred_url":"https://api.github.com/users/thomaspink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomaspink/subscriptions","organizations_url":"https://api.github.com/users/thomaspink/orgs","repos_url":"https://api.github.com/users/thomaspink/repos","events_url":"https://api.github.com/users/thomaspink/events{/privacy}","received_events_url":"https://api.github.com/users/thomaspink/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-04-29T18:07:32Z","updated_at":"2016-04-30T12:31:56Z","closed_at":"2016-04-29T21:59:29Z","pull_request":{"url":"https://api.github.com/repos/tildeio/glimmer/pulls/154","html_url":"https://github.com/tildeio/glimmer/pull/154","diff_url":"https://github.com/tildeio/glimmer/pull/154.diff","patch_url":"https://github.com/tildeio/glimmer/pull/154.patch"},"body":"fixes #153 "},"comment":{"url":"https://api.github.com/repos/tildeio/glimmer/issues/comments/215960697","html_url":"https://github.com/tildeio/glimmer/pull/154#issuecomment-215960697","issue_url":"https://api.github.com/repos/tildeio/glimmer/issues/154","id":215960697,"user":{"login":"thomaspink","id":1368032,"avatar_url":"https://avatars.githubusercontent.com/u/1368032?v=3","gravatar_id":"","url":"https://api.github.com/users/thomaspink","html_url":"https://github.com/thomaspink","followers_url":"https://api.github.com/users/thomaspink/followers","following_url":"https://api.github.com/users/thomaspink/following{/other_user}","gists_url":"https://api.github.com/users/thomaspink/gists{/gist_id}","starred_url":"https://api.github.com/users/thomaspink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomaspink/subscriptions","organizations_url":"https://api.github.com/users/thomaspink/orgs","repos_url":"https://api.github.com/users/thomaspink/repos","events_url":"https://api.github.com/users/thomaspink/events{/privacy}","received_events_url":"https://api.github.com/users/thomaspink/received_events","type":"User","site_admin":false},"created_at":"2016-04-30T12:31:56Z","updated_at":"2016-04-30T12:31:56Z","body":"@chancancode \r\nThe demos Visualizer, Conways, Uptime Boxes and ripples have a js-error. Benchmarks demo works fine.\r\nError (callstack below): `Uncaught ReferenceError: Benchmark is not defined`     \r\nThe demo is falling in the packages/glimmer-demos/lib/bench.ts on line 10 (https://github.com/tildeio/glimmer/blob/master/packages/glimmer-demos/lib/bench.ts#L10): \r\n`Benchmark.support.decompilation = false;`\r\n\r\nI don't know where Benchmark object in the bench.ts should come from, but it is not imported in this file (is it a global object, but how do . I only found the line:\r\n`export const Benchmark = benchmark;'\r\nin the packages/glimmer-demos/index.ts (https://github.com/thomaspink/glimmer/blob/master/packages/glimmer-demos/index.ts#L13)\r\n\r\nShouldn't the Benchmark object be imported in bench.ts if it is used, or where does it come from?\r\n\r\ncallstack:\r\n````\r\nloader.js:81 Uncaught ReferenceError: Benchmark is not defined\r\n(anonymous function) @ bench.ts:10\r\nModule.exports @ loader.js:81\r\nModule.build @ loader.js:131\r\nfindModule @ loader.js:179\r\nModule.reify @ loader.js:113\r\nModule.build @ loader.js:131\r\nfindModule @ loader.js:179\r\nModule.reify @ loader.js:113\r\nModule.build @ loader.js:131\r\nfindModule @ loader.js:179\r\nrequireModule @ loader.js:166\r\n(anonymous function) @ visualizer.html:194\r\n````"}}