{"action":"created","issue":{"url":"https://api.github.com/repos/libstorage/libstoragemgmt/issues/85","repository_url":"https://api.github.com/repos/libstorage/libstoragemgmt","labels_url":"https://api.github.com/repos/libstorage/libstoragemgmt/issues/85/labels{/name}","comments_url":"https://api.github.com/repos/libstorage/libstoragemgmt/issues/85/comments","events_url":"https://api.github.com/repos/libstorage/libstoragemgmt/issues/85/events","html_url":"https://github.com/libstorage/libstoragemgmt/pull/85","id":126415117,"number":85,"title":"[PATCH 0/13] Querying disk rotation speed and link type","user":{"login":"cathay4t","id":934948,"avatar_url":"https://avatars.githubusercontent.com/u/934948?v=3","gravatar_id":"","url":"https://api.github.com/users/cathay4t","html_url":"https://github.com/cathay4t","followers_url":"https://api.github.com/users/cathay4t/followers","following_url":"https://api.github.com/users/cathay4t/following{/other_user}","gists_url":"https://api.github.com/users/cathay4t/gists{/gist_id}","starred_url":"https://api.github.com/users/cathay4t/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cathay4t/subscriptions","organizations_url":"https://api.github.com/users/cathay4t/orgs","repos_url":"https://api.github.com/users/cathay4t/repos","events_url":"https://api.github.com/users/cathay4t/events{/privacy}","received_events_url":"https://api.github.com/users/cathay4t/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/libstorage/libstoragemgmt/milestones/1","html_url":"https://github.com/libstorage/libstoragemgmt/milestones/1.3","labels_url":"https://api.github.com/repos/libstorage/libstoragemgmt/milestones/1/labels","id":1137995,"number":1,"title":"1.3","description":"","creator":{"login":"cathay4t","id":934948,"avatar_url":"https://avatars.githubusercontent.com/u/934948?v=3","gravatar_id":"","url":"https://api.github.com/users/cathay4t","html_url":"https://github.com/cathay4t","followers_url":"https://api.github.com/users/cathay4t/followers","following_url":"https://api.github.com/users/cathay4t/following{/other_user}","gists_url":"https://api.github.com/users/cathay4t/gists{/gist_id}","starred_url":"https://api.github.com/users/cathay4t/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cathay4t/subscriptions","organizations_url":"https://api.github.com/users/cathay4t/orgs","repos_url":"https://api.github.com/users/cathay4t/repos","events_url":"https://api.github.com/users/cathay4t/events{/privacy}","received_events_url":"https://api.github.com/users/cathay4t/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":0,"state":"open","created_at":"2015-05-28T13:45:18Z","updated_at":"2016-02-17T01:05:27Z","due_on":"2016-04-30T16:00:00Z","closed_at":null},"comments":14,"created_at":"2016-01-13T13:10:54Z","updated_at":"2016-02-18T13:34:16Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/libstorage/libstoragemgmt/pulls/85","html_url":"https://github.com/libstorage/libstoragemgmt/pull/85","diff_url":"https://github.com/libstorage/libstoragemgmt/pull/85.diff","patch_url":"https://github.com/libstorage/libstoragemgmt/pull/85.patch"},"body":"Hightlights:\r\n\r\n * Query local disk rotation speed -- `lsm_scsi_rpm_of_disk_path()`.\r\n * Query local disk link type -- `lsm_scsi_link_type_of_disk_path()`.\r\n * Use macro _wrapper() to remove duplicate code in `_scsi_clib.c`.\r\n * New lsmcli command -- `lsmcli lsd` to list all local scsi disks.\r\n\r\nFAQ:\r\n * Why not use udev for RPM which does not need root privilege?\r\n\r\n   Udev does not support SAS disk RPM query yet.\r\n   Should we create a patch to udev or use this SCSI standard way?\r\n\r\n * Why need root privilege?\r\n\r\n   Required by SGIO IOCTL. \r\n   If kernel could expose more VPD pages (like 0xb1and 0x00) via sysfs like they do for VPD 0x83, \r\n   we don't need to do SGIO any more.\r\n\r\n * Why create your own SGIO function instead of using libsgutils2?\r\n\r\n    IMHO, libsgutils2 is too heavy for our simple use here and SGIO is not that complex."},"comment":{"url":"https://api.github.com/repos/libstorage/libstoragemgmt/issues/comments/185720224","html_url":"https://github.com/libstorage/libstoragemgmt/pull/85#issuecomment-185720224","issue_url":"https://api.github.com/repos/libstorage/libstoragemgmt/issues/85","id":185720224,"user":{"login":"cathay4t","id":934948,"avatar_url":"https://avatars.githubusercontent.com/u/934948?v=3","gravatar_id":"","url":"https://api.github.com/users/cathay4t","html_url":"https://github.com/cathay4t","followers_url":"https://api.github.com/users/cathay4t/followers","following_url":"https://api.github.com/users/cathay4t/following{/other_user}","gists_url":"https://api.github.com/users/cathay4t/gists{/gist_id}","starred_url":"https://api.github.com/users/cathay4t/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cathay4t/subscriptions","organizations_url":"https://api.github.com/users/cathay4t/orgs","repos_url":"https://api.github.com/users/cathay4t/repos","events_url":"https://api.github.com/users/cathay4t/events{/privacy}","received_events_url":"https://api.github.com/users/cathay4t/received_events","type":"User","site_admin":false},"created_at":"2016-02-18T13:34:16Z","updated_at":"2016-02-18T13:34:16Z","body":"I have moved some unrelated patches from this PR to #92 and will back to this PR after that.\r\n\r\nThank you."}}