{"action":"created","issue":{"url":"https://api.github.com/repos/Particular/NServiceBus/issues/3712","repository_url":"https://api.github.com/repos/Particular/NServiceBus","labels_url":"https://api.github.com/repos/Particular/NServiceBus/issues/3712/labels{/name}","comments_url":"https://api.github.com/repos/Particular/NServiceBus/issues/3712/comments","events_url":"https://api.github.com/repos/Particular/NServiceBus/issues/3712/events","html_url":"https://github.com/Particular/NServiceBus/pull/3712","id":151583766,"number":3712,"title":"Fix flaky Acceptance Tests","user":{"login":"timbussmann","id":3524870,"avatar_url":"https://avatars.githubusercontent.com/u/3524870?v=3","gravatar_id":"","url":"https://api.github.com/users/timbussmann","html_url":"https://github.com/timbussmann","followers_url":"https://api.github.com/users/timbussmann/followers","following_url":"https://api.github.com/users/timbussmann/following{/other_user}","gists_url":"https://api.github.com/users/timbussmann/gists{/gist_id}","starred_url":"https://api.github.com/users/timbussmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timbussmann/subscriptions","organizations_url":"https://api.github.com/users/timbussmann/orgs","repos_url":"https://api.github.com/users/timbussmann/repos","events_url":"https://api.github.com/users/timbussmann/events{/privacy}","received_events_url":"https://api.github.com/users/timbussmann/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Particular/NServiceBus/labels/State:%20In%20Progress","name":"State: In Progress","color":"ededed"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2016-04-28T08:53:24Z","updated_at":"2016-04-28T10:13:59Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Particular/NServiceBus/pulls/3712","html_url":"https://github.com/Particular/NServiceBus/pull/3712","diff_url":"https://github.com/Particular/NServiceBus/pull/3712.diff","patch_url":"https://github.com/Particular/NServiceBus/pull/3712.patch"},"body":"temporary fix for `When_auto_correlated_property_is_changed` reported by #3711 :+1: - changed done condition to `FailedMessages.Any()`. Because of the changed mechanism how we send messages to error queues, it's possible that the done condition is met and the endpoint is shut down before the message to be sent to the error queue is consumed again by the endpoint. The new condition ends the test only if a (any) message has been sent to the error queue. This test also seemed to fail for RabbitMQ PR https://github.com/Particular/NServiceBus.RabbitMQ/pull/136\r\n\r\nAlso fixes `When_performing_slr_with_flr_disabled` which failed on https://github.com/Particular/NServiceBus.RabbitMQ/pull/136 too. I can't remember why the test assumes only 2 retries? Maybe @MarcinHoppe remembers?\r\n\r\n/cc @johnsimons @bording @SimonCropp \r\n\r\nping @Particular/nservicebus-maintainers \r\n"},"comment":{"url":"https://api.github.com/repos/Particular/NServiceBus/issues/comments/215377384","html_url":"https://github.com/Particular/NServiceBus/pull/3712#issuecomment-215377384","issue_url":"https://api.github.com/repos/Particular/NServiceBus/issues/3712","id":215377384,"user":{"login":"MarcinHoppe","id":475629,"avatar_url":"https://avatars.githubusercontent.com/u/475629?v=3","gravatar_id":"","url":"https://api.github.com/users/MarcinHoppe","html_url":"https://github.com/MarcinHoppe","followers_url":"https://api.github.com/users/MarcinHoppe/followers","following_url":"https://api.github.com/users/MarcinHoppe/following{/other_user}","gists_url":"https://api.github.com/users/MarcinHoppe/gists{/gist_id}","starred_url":"https://api.github.com/users/MarcinHoppe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarcinHoppe/subscriptions","organizations_url":"https://api.github.com/users/MarcinHoppe/orgs","repos_url":"https://api.github.com/users/MarcinHoppe/repos","events_url":"https://api.github.com/users/MarcinHoppe/events{/privacy}","received_events_url":"https://api.github.com/users/MarcinHoppe/received_events","type":"User","site_admin":false},"created_at":"2016-04-28T10:13:59Z","updated_at":"2016-04-28T10:13:59Z","body":"Awesome :fire:."}}