{"action":"created","comment":{"url":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/comments/79558509","id":79558509,"diff_hunk":"@@ -140,27 +140,43 @@\n     gl.enableVertexAttribArray(positionLoc);\n     // Draw two triangles. They are almost right-triangles: one is actually an obtuse triangle. The other is actually an acute triangle.\n     // This means that some egdes of the triangles almost parallel with x-axis and y-axis. So they can show the alias.\n-    var positions = new Float32Array([\n+    /* var positions = new Float32Array([\n          0.85, -0.90,\n         -0.90,  0.85,\n         -0.87, -0.87,\n          0.90, -0.85,\n          0.93,  0.93,\n         -0.85,  0.90,\n+    ]);*/\n+    var positions = new Float32Array([\n+         1.0, -1.0,\n+        -1.0,  1.0,\n+        -1.0, -1.0,\n+         1.0, -1.0,\n+         1.0,  1.0,\n+        -1.0,  1.0,\n     ]);\n     var positionBuffer = gl.createBuffer();\n     gl.bindBuffer(gl.ARRAY_BUFFER, positionBuffer);\n     gl.bufferData(gl.ARRAY_BUFFER, positions, gl.STATIC_DRAW);\n     gl.vertexAttribPointer(positionLoc, 2, gl.FLOAT, false, 0, 0);\n \n     gl.enableVertexAttribArray(colorLoc);\n-    var colors = [\n+    /* var colors = [\n         [255, 0, 0, 255],\n         [0, 255, 0, 255],\n         [0, 0, 255, 255],\n         [253, 122, 5, 255],\n         [6, 252, 120, 255],\n         [118, 4, 254, 255]\n+    ];*/\n+    var colors = [\n+        [255, 0, 0, 255],\n+        [0, 255, 0, 255],\n+        [0, 0, 255, 255],\n+        [255, 0, 0, 255],\n+        [0, 0, 255, 255],\n+        [0, 255, 0, 255],","path":"sdk/tests/conformance2/rendering/blitframebuffer-multisampled-readbuffer.html","position":null,"original_position":51,"commit_id":"19b3bb6a26c9b6bca24715869612568291dde090","original_commit_id":"87a0cb4e2db3f39531dc7611f6865317fd6806c7","user":{"login":"Richard-Yunchao","id":11435653,"avatar_url":"https://avatars.githubusercontent.com/u/11435653?v=3","gravatar_id":"","url":"https://api.github.com/users/Richard-Yunchao","html_url":"https://github.com/Richard-Yunchao","followers_url":"https://api.github.com/users/Richard-Yunchao/followers","following_url":"https://api.github.com/users/Richard-Yunchao/following{/other_user}","gists_url":"https://api.github.com/users/Richard-Yunchao/gists{/gist_id}","starred_url":"https://api.github.com/users/Richard-Yunchao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Richard-Yunchao/subscriptions","organizations_url":"https://api.github.com/users/Richard-Yunchao/orgs","repos_url":"https://api.github.com/users/Richard-Yunchao/repos","events_url":"https://api.github.com/users/Richard-Yunchao/events{/privacy}","received_events_url":"https://api.github.com/users/Richard-Yunchao/received_events","type":"User","site_admin":false},"body":"Good suggestion, let's fill a rectangle with solid color and draw to a multisampled srgb draw buffer. It is simple and direct. ","created_at":"2016-09-20T08:24:34Z","updated_at":"2016-09-20T08:24:34Z","html_url":"https://github.com/KhronosGroup/WebGL/pull/2034#discussion_r79558509","pull_request_url":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/2034","_links":{"self":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/comments/79558509"},"html":{"href":"https://github.com/KhronosGroup/WebGL/pull/2034#discussion_r79558509"},"pull_request":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/2034"}}},"pull_request":{"url":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/2034","id":85733365,"html_url":"https://github.com/KhronosGroup/WebGL/pull/2034","diff_url":"https://github.com/KhronosGroup/WebGL/pull/2034.diff","patch_url":"https://github.com/KhronosGroup/WebGL/pull/2034.patch","issue_url":"https://api.github.com/repos/KhronosGroup/WebGL/issues/2034","number":2034,"state":"open","locked":false,"title":"Add test cases to test blitframebuffer against multisampled srgb image","user":{"login":"Richard-Yunchao","id":11435653,"avatar_url":"https://avatars.githubusercontent.com/u/11435653?v=3","gravatar_id":"","url":"https://api.github.com/users/Richard-Yunchao","html_url":"https://github.com/Richard-Yunchao","followers_url":"https://api.github.com/users/Richard-Yunchao/followers","following_url":"https://api.github.com/users/Richard-Yunchao/following{/other_user}","gists_url":"https://api.github.com/users/Richard-Yunchao/gists{/gist_id}","starred_url":"https://api.github.com/users/Richard-Yunchao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Richard-Yunchao/subscriptions","organizations_url":"https://api.github.com/users/Richard-Yunchao/orgs","repos_url":"https://api.github.com/users/Richard-Yunchao/repos","events_url":"https://api.github.com/users/Richard-Yunchao/events{/privacy}","received_events_url":"https://api.github.com/users/Richard-Yunchao/received_events","type":"User","site_admin":false},"body":"@kenrussell , PTAL. Thanks a lot!\r\n\r\nPer the discussion in this Chromium CL: https://codereview.chromium.org/2286593002/.  We have no tests to blit multisampled srgb to a srgb image. So this test comes, it can expose some errors in Mac (OGL 4.1). ","created_at":"2016-09-19T02:59:36Z","updated_at":"2016-09-20T08:24:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"11f482dad774176131a4c04d449d25c0579fd80e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/2034/commits","review_comments_url":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/2034/comments","review_comment_url":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/comments{/number}","comments_url":"https://api.github.com/repos/KhronosGroup/WebGL/issues/2034/comments","statuses_url":"https://api.github.com/repos/KhronosGroup/WebGL/statuses/19b3bb6a26c9b6bca24715869612568291dde090","head":{"label":"Richard-Yunchao:blitframebuffer-msaa-srgb","ref":"blitframebuffer-msaa-srgb","sha":"19b3bb6a26c9b6bca24715869612568291dde090","user":{"login":"Richard-Yunchao","id":11435653,"avatar_url":"https://avatars.githubusercontent.com/u/11435653?v=3","gravatar_id":"","url":"https://api.github.com/users/Richard-Yunchao","html_url":"https://github.com/Richard-Yunchao","followers_url":"https://api.github.com/users/Richard-Yunchao/followers","following_url":"https://api.github.com/users/Richard-Yunchao/following{/other_user}","gists_url":"https://api.github.com/users/Richard-Yunchao/gists{/gist_id}","starred_url":"https://api.github.com/users/Richard-Yunchao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Richard-Yunchao/subscriptions","organizations_url":"https://api.github.com/users/Richard-Yunchao/orgs","repos_url":"https://api.github.com/users/Richard-Yunchao/repos","events_url":"https://api.github.com/users/Richard-Yunchao/events{/privacy}","received_events_url":"https://api.github.com/users/Richard-Yunchao/received_events","type":"User","site_admin":false},"repo":{"id":32059852,"name":"WebGL","full_name":"Richard-Yunchao/WebGL","owner":{"login":"Richard-Yunchao","id":11435653,"avatar_url":"https://avatars.githubusercontent.com/u/11435653?v=3","gravatar_id":"","url":"https://api.github.com/users/Richard-Yunchao","html_url":"https://github.com/Richard-Yunchao","followers_url":"https://api.github.com/users/Richard-Yunchao/followers","following_url":"https://api.github.com/users/Richard-Yunchao/following{/other_user}","gists_url":"https://api.github.com/users/Richard-Yunchao/gists{/gist_id}","starred_url":"https://api.github.com/users/Richard-Yunchao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Richard-Yunchao/subscriptions","organizations_url":"https://api.github.com/users/Richard-Yunchao/orgs","repos_url":"https://api.github.com/users/Richard-Yunchao/repos","events_url":"https://api.github.com/users/Richard-Yunchao/events{/privacy}","received_events_url":"https://api.github.com/users/Richard-Yunchao/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Richard-Yunchao/WebGL","description":"The Official Khronos WebGL Repository","fork":true,"url":"https://api.github.com/repos/Richard-Yunchao/WebGL","forks_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/forks","keys_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/teams","hooks_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/hooks","issue_events_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/issues/events{/number}","events_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/events","assignees_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/assignees{/user}","branches_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/branches{/branch}","tags_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/tags","blobs_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/git/refs{/sha}","trees_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/statuses/{sha}","languages_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/languages","stargazers_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/stargazers","contributors_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/contributors","subscribers_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/subscribers","subscription_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/subscription","commits_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/commits{/sha}","git_commits_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/git/commits{/sha}","comments_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/comments{/number}","issue_comment_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/issues/comments{/number}","contents_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/contents/{+path}","compare_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/merges","archive_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/downloads","issues_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/issues{/number}","pulls_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/pulls{/number}","milestones_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/milestones{/number}","notifications_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/labels{/name}","releases_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/releases{/id}","deployments_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/deployments","created_at":"2015-03-12T05:57:15Z","updated_at":"2015-03-16T06:06:31Z","pushed_at":"2016-09-20T08:16:05Z","git_url":"git://github.com/Richard-Yunchao/WebGL.git","ssh_url":"git@github.com:Richard-Yunchao/WebGL.git","clone_url":"https://github.com/Richard-Yunchao/WebGL.git","svn_url":"https://github.com/Richard-Yunchao/WebGL","homepage":null,"size":22863,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"KhronosGroup:master","ref":"master","sha":"1950a322ceea6d2d87069ff7354e04455e2fc8da","user":{"login":"KhronosGroup","id":1608701,"avatar_url":"https://avatars.githubusercontent.com/u/1608701?v=3","gravatar_id":"","url":"https://api.github.com/users/KhronosGroup","html_url":"https://github.com/KhronosGroup","followers_url":"https://api.github.com/users/KhronosGroup/followers","following_url":"https://api.github.com/users/KhronosGroup/following{/other_user}","gists_url":"https://api.github.com/users/KhronosGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/KhronosGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KhronosGroup/subscriptions","organizations_url":"https://api.github.com/users/KhronosGroup/orgs","repos_url":"https://api.github.com/users/KhronosGroup/repos","events_url":"https://api.github.com/users/KhronosGroup/events{/privacy}","received_events_url":"https://api.github.com/users/KhronosGroup/received_events","type":"Organization","site_admin":false},"repo":{"id":5207280,"name":"WebGL","full_name":"KhronosGroup/WebGL","owner":{"login":"KhronosGroup","id":1608701,"avatar_url":"https://avatars.githubusercontent.com/u/1608701?v=3","gravatar_id":"","url":"https://api.github.com/users/KhronosGroup","html_url":"https://github.com/KhronosGroup","followers_url":"https://api.github.com/users/KhronosGroup/followers","following_url":"https://api.github.com/users/KhronosGroup/following{/other_user}","gists_url":"https://api.github.com/users/KhronosGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/KhronosGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KhronosGroup/subscriptions","organizations_url":"https://api.github.com/users/KhronosGroup/orgs","repos_url":"https://api.github.com/users/KhronosGroup/repos","events_url":"https://api.github.com/users/KhronosGroup/events{/privacy}","received_events_url":"https://api.github.com/users/KhronosGroup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/KhronosGroup/WebGL","description":"The Official Khronos WebGL Repository","fork":false,"url":"https://api.github.com/repos/KhronosGroup/WebGL","forks_url":"https://api.github.com/repos/KhronosGroup/WebGL/forks","keys_url":"https://api.github.com/repos/KhronosGroup/WebGL/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KhronosGroup/WebGL/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KhronosGroup/WebGL/teams","hooks_url":"https://api.github.com/repos/KhronosGroup/WebGL/hooks","issue_events_url":"https://api.github.com/repos/KhronosGroup/WebGL/issues/events{/number}","events_url":"https://api.github.com/repos/KhronosGroup/WebGL/events","assignees_url":"https://api.github.com/repos/KhronosGroup/WebGL/assignees{/user}","branches_url":"https://api.github.com/repos/KhronosGroup/WebGL/branches{/branch}","tags_url":"https://api.github.com/repos/KhronosGroup/WebGL/tags","blobs_url":"https://api.github.com/repos/KhronosGroup/WebGL/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KhronosGroup/WebGL/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KhronosGroup/WebGL/git/refs{/sha}","trees_url":"https://api.github.com/repos/KhronosGroup/WebGL/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KhronosGroup/WebGL/statuses/{sha}","languages_url":"https://api.github.com/repos/KhronosGroup/WebGL/languages","stargazers_url":"https://api.github.com/repos/KhronosGroup/WebGL/stargazers","contributors_url":"https://api.github.com/repos/KhronosGroup/WebGL/contributors","subscribers_url":"https://api.github.com/repos/KhronosGroup/WebGL/subscribers","subscription_url":"https://api.github.com/repos/KhronosGroup/WebGL/subscription","commits_url":"https://api.github.com/repos/KhronosGroup/WebGL/commits{/sha}","git_commits_url":"https://api.github.com/repos/KhronosGroup/WebGL/git/commits{/sha}","comments_url":"https://api.github.com/repos/KhronosGroup/WebGL/comments{/number}","issue_comment_url":"https://api.github.com/repos/KhronosGroup/WebGL/issues/comments{/number}","contents_url":"https://api.github.com/repos/KhronosGroup/WebGL/contents/{+path}","compare_url":"https://api.github.com/repos/KhronosGroup/WebGL/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KhronosGroup/WebGL/merges","archive_url":"https://api.github.com/repos/KhronosGroup/WebGL/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KhronosGroup/WebGL/downloads","issues_url":"https://api.github.com/repos/KhronosGroup/WebGL/issues{/number}","pulls_url":"https://api.github.com/repos/KhronosGroup/WebGL/pulls{/number}","milestones_url":"https://api.github.com/repos/KhronosGroup/WebGL/milestones{/number}","notifications_url":"https://api.github.com/repos/KhronosGroup/WebGL/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KhronosGroup/WebGL/labels{/name}","releases_url":"https://api.github.com/repos/KhronosGroup/WebGL/releases{/id}","deployments_url":"https://api.github.com/repos/KhronosGroup/WebGL/deployments","created_at":"2012-07-27T17:21:51Z","updated_at":"2016-09-19T14:47:37Z","pushed_at":"2016-09-20T08:16:06Z","git_url":"git://github.com/KhronosGroup/WebGL.git","ssh_url":"git@github.com:KhronosGroup/WebGL.git","clone_url":"https://github.com/KhronosGroup/WebGL.git","svn_url":"https://github.com/KhronosGroup/WebGL","homepage":null,"size":29870,"stargazers_count":675,"watchers_count":675,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":325,"mirror_url":null,"open_issues_count":82,"forks":325,"open_issues":82,"watchers":675,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/2034"},"html":{"href":"https://github.com/KhronosGroup/WebGL/pull/2034"},"issue":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/issues/2034"},"comments":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/issues/2034/comments"},"review_comments":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/2034/comments"},"review_comment":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/2034/commits"},"statuses":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/statuses/19b3bb6a26c9b6bca24715869612568291dde090"}}}}
{"actor":{"display_login":"Richard-Yunchao"}}