{"action":"created","issue":{"url":"https://api.github.com/repos/symfony/symfony/issues/19648","repository_url":"https://api.github.com/repos/symfony/symfony","labels_url":"https://api.github.com/repos/symfony/symfony/issues/19648/labels{/name}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/19648/comments","events_url":"https://api.github.com/repos/symfony/symfony/issues/19648/events","html_url":"https://github.com/symfony/symfony/pull/19648","id":171623563,"number":19648,"title":"Bootstrap4 support for Twig form theme","user":{"login":"hiddewie","id":1073881,"avatar_url":"https://avatars.githubusercontent.com/u/1073881?v=3","gravatar_id":"","url":"https://api.github.com/users/hiddewie","html_url":"https://github.com/hiddewie","followers_url":"https://api.github.com/users/hiddewie/followers","following_url":"https://api.github.com/users/hiddewie/following{/other_user}","gists_url":"https://api.github.com/users/hiddewie/gists{/gist_id}","starred_url":"https://api.github.com/users/hiddewie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hiddewie/subscriptions","organizations_url":"https://api.github.com/users/hiddewie/orgs","repos_url":"https://api.github.com/users/hiddewie/repos","events_url":"https://api.github.com/users/hiddewie/events{/privacy}","received_events_url":"https://api.github.com/users/hiddewie/received_events","type":"User","site_admin":false},"labels":[{"id":100378,"url":"https://api.github.com/repos/symfony/symfony/labels/Feature","name":"Feature","color":"02e10c","default":false},{"id":237003792,"url":"https://api.github.com/repos/symfony/symfony/labels/Status:%20Needs%20Review","name":"Status: Needs Review","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":26,"created_at":"2016-08-17T10:22:18Z","updated_at":"2016-11-06T17:44:28Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/19648","html_url":"https://github.com/symfony/symfony/pull/19648","diff_url":"https://github.com/symfony/symfony/pull/19648.diff","patch_url":"https://github.com/symfony/symfony/pull/19648.patch"},"body":"| Q | A |\n| --- | --- |\n| Branch? | master |\n| Bug fix? | no |\n| New feature? | yes |\n| BC breaks? | no |\n| Deprecations? | no |\n| Tests pass? | yes |\n| Fixed tickets | #16289 |\n| License | MIT |\n| Doc PR | - |\n\nI have made a port of the Twig form theming code for Bootstrap 3 to the α-3 version of Bootstrap 4.\n- The (inheritance) structure of the form theming files has changed because a number of blocks are the same between BS 3 and 4. They have been migrated to `bootstrap_base_layout.html.twig`. \n  The new tree is as follows:\n\n```\nbootstrap_base_layout.html.twig\n|-- bootstrap_3_layout.html.twig\n|   `-- bootstrap_3_horizontal_layout.html.twig\n`-- bootstrap_4_layout.html.twig\n    `-- bootstrap_4_horizontal_layout.html.twig\n```\n- Any occurances of `.form-horizontal` have been removed from the BS 4 code.\n- Checkboxes and radio buttons have been stacked using the `.form-check`, `.form-check-label` and `.form-check-input` classes. There is now no distinction between checkboxes and radio buttons in the markdown.\n- All layout tests have been added and updated for BS4. The inheritance tree is as follows:\n\n```\nAbstractLayoutTest\n`-- AbstractBootstrap3LayoutTest\n    |-- AbstractBootstrap3HorizontalLayoutTest\n    `-- AbstractBootstrap4LayoutTest\n        `-- AbstractBootstrap4HorizontalLayoutTest\n```\n\nAll tests pass. The classes `FormExtensionBootstrap4LayoutTest` and `FormExtensionBootstrap4HorizontalLayoutTest` have been created similarly to the BS 3 versions.\n- ~~The label coloring on an validation is not correct. I've made an issue (twbs/bootstrap#20535) of the problem.~~\n- No [custom form elements](http://v4-alpha.getbootstrap.com/components/forms/#custom-forms) have been used. \n- A docs PR can be created if this PR is accepted.\n- The new code might have to be updated if large changes occur in the BS 4 α.\n\nScreenshot of BS3 and 4 comparison for the same form: \n\n![1](https://cloud.githubusercontent.com/assets/1073881/17732594/dfcb50d6-6472-11e6-8e96-c46987809322.PNG)\n"},"comment":{"url":"https://api.github.com/repos/symfony/symfony/issues/comments/258696984","html_url":"https://github.com/symfony/symfony/pull/19648#issuecomment-258696984","issue_url":"https://api.github.com/repos/symfony/symfony/issues/19648","id":258696984,"user":{"login":"hiddewie","id":1073881,"avatar_url":"https://avatars.githubusercontent.com/u/1073881?v=3","gravatar_id":"","url":"https://api.github.com/users/hiddewie","html_url":"https://github.com/hiddewie","followers_url":"https://api.github.com/users/hiddewie/followers","following_url":"https://api.github.com/users/hiddewie/following{/other_user}","gists_url":"https://api.github.com/users/hiddewie/gists{/gist_id}","starred_url":"https://api.github.com/users/hiddewie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hiddewie/subscriptions","organizations_url":"https://api.github.com/users/hiddewie/orgs","repos_url":"https://api.github.com/users/hiddewie/repos","events_url":"https://api.github.com/users/hiddewie/events{/privacy}","received_events_url":"https://api.github.com/users/hiddewie/received_events","type":"User","site_admin":false},"created_at":"2016-11-06T17:44:28Z","updated_at":"2016-11-06T17:44:28Z","body":"I've tried to fix all comments up to now, both code style and code content. \r\n\r\nIf there are more new or existing comments I have missed, then I will of course process them. "}}
{"actor":{"display_login":"hiddewie"}}