{"action":"closed","issue":{"url":"https://api.github.com/repos/mesosphere/marathon/issues/4811","repository_url":"https://api.github.com/repos/mesosphere/marathon","labels_url":"https://api.github.com/repos/mesosphere/marathon/issues/4811/labels{/name}","comments_url":"https://api.github.com/repos/mesosphere/marathon/issues/4811/comments","events_url":"https://api.github.com/repos/mesosphere/marathon/issues/4811/events","html_url":"https://github.com/mesosphere/marathon/issues/4811","id":194393704,"number":4811,"title":"Some properties aren't properly marked as optional in RAML","user":{"login":"orlandohohmeier","id":647035,"avatar_url":"https://avatars.githubusercontent.com/u/647035?v=3","gravatar_id":"","url":"https://api.github.com/users/orlandohohmeier","html_url":"https://github.com/orlandohohmeier","followers_url":"https://api.github.com/users/orlandohohmeier/followers","following_url":"https://api.github.com/users/orlandohohmeier/following{/other_user}","gists_url":"https://api.github.com/users/orlandohohmeier/gists{/gist_id}","starred_url":"https://api.github.com/users/orlandohohmeier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orlandohohmeier/subscriptions","organizations_url":"https://api.github.com/users/orlandohohmeier/orgs","repos_url":"https://api.github.com/users/orlandohohmeier/repos","events_url":"https://api.github.com/users/orlandohohmeier/events{/privacy}","received_events_url":"https://api.github.com/users/orlandohohmeier/received_events","type":"User","site_admin":false},"labels":[{"id":125137438,"url":"https://api.github.com/repos/mesosphere/marathon/labels/blocker","name":"blocker","color":"333333","default":false},{"id":44984380,"url":"https://api.github.com/repos/mesosphere/marathon/labels/bug","name":"bug","color":"fc2929","default":true},{"id":75023057,"url":"https://api.github.com/repos/mesosphere/marathon/labels/in%20progress","name":"in progress","color":"5319e7","default":false},{"id":227628310,"url":"https://api.github.com/repos/mesosphere/marathon/labels/service","name":"service","color":"eb6420","default":false}],"state":"closed","locked":false,"assignee":{"login":"orlandohohmeier","id":647035,"avatar_url":"https://avatars.githubusercontent.com/u/647035?v=3","gravatar_id":"","url":"https://api.github.com/users/orlandohohmeier","html_url":"https://github.com/orlandohohmeier","followers_url":"https://api.github.com/users/orlandohohmeier/followers","following_url":"https://api.github.com/users/orlandohohmeier/following{/other_user}","gists_url":"https://api.github.com/users/orlandohohmeier/gists{/gist_id}","starred_url":"https://api.github.com/users/orlandohohmeier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orlandohohmeier/subscriptions","organizations_url":"https://api.github.com/users/orlandohohmeier/orgs","repos_url":"https://api.github.com/users/orlandohohmeier/repos","events_url":"https://api.github.com/users/orlandohohmeier/events{/privacy}","received_events_url":"https://api.github.com/users/orlandohohmeier/received_events","type":"User","site_admin":false},"assignees":[{"login":"orlandohohmeier","id":647035,"avatar_url":"https://avatars.githubusercontent.com/u/647035?v=3","gravatar_id":"","url":"https://api.github.com/users/orlandohohmeier","html_url":"https://github.com/orlandohohmeier","followers_url":"https://api.github.com/users/orlandohohmeier/followers","following_url":"https://api.github.com/users/orlandohohmeier/following{/other_user}","gists_url":"https://api.github.com/users/orlandohohmeier/gists{/gist_id}","starred_url":"https://api.github.com/users/orlandohohmeier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orlandohohmeier/subscriptions","organizations_url":"https://api.github.com/users/orlandohohmeier/orgs","repos_url":"https://api.github.com/users/orlandohohmeier/repos","events_url":"https://api.github.com/users/orlandohohmeier/events{/privacy}","received_events_url":"https://api.github.com/users/orlandohohmeier/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/mesosphere/marathon/milestones/31","html_url":"https://github.com/mesosphere/marathon/milestone/31","labels_url":"https://api.github.com/repos/mesosphere/marathon/milestones/31/labels","id":1984007,"number":31,"title":"Marathon 1.4","description":"","creator":{"login":"aquamatthias","id":330485,"avatar_url":"https://avatars.githubusercontent.com/u/330485?v=3","gravatar_id":"","url":"https://api.github.com/users/aquamatthias","html_url":"https://github.com/aquamatthias","followers_url":"https://api.github.com/users/aquamatthias/followers","following_url":"https://api.github.com/users/aquamatthias/following{/other_user}","gists_url":"https://api.github.com/users/aquamatthias/gists{/gist_id}","starred_url":"https://api.github.com/users/aquamatthias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aquamatthias/subscriptions","organizations_url":"https://api.github.com/users/aquamatthias/orgs","repos_url":"https://api.github.com/users/aquamatthias/repos","events_url":"https://api.github.com/users/aquamatthias/events{/privacy}","received_events_url":"https://api.github.com/users/aquamatthias/received_events","type":"User","site_admin":false},"open_issues":32,"closed_issues":149,"state":"open","created_at":"2016-09-05T11:40:53Z","updated_at":"2016-12-11T14:17:04Z","due_on":"2017-01-31T00:00:00Z","closed_at":null},"comments":0,"created_at":"2016-12-08T17:16:39Z","updated_at":"2016-12-11T14:17:04Z","closed_at":"2016-12-11T14:17:03Z","body":"Some of the health check properties as well as potentially others aren't properly marked as optional values. This leads to confusion as they aren't required and to validation issues in the DC/OS Service UI which is using RAML to validate app definitions.\r\n\r\n**Example**\r\n```\r\n maxConsecutiveFailures:\r\n        type: integer\r\n        format: int32\r\n        description: |\r\n          Number of consecutive health check failures after which the\r\n          unhealthy task should be killed.\r\n        minimum: 0\r\n        default: 3\r\n```\r\n_https://github.com/mesosphere/marathon/blob/master/docs/docs/rest-api/public/api/v2/types/healthCheck.raml#L103_\r\n\r\n`maxConsecutiveFailures` has a default values and is as thus implicitly optional but is not marked as an optional value."}}
{"actor":{"display_login":"jdef"}}