{"action":"created","comment":{"url":"https://api.github.com/repos/line/armeria/pulls/comments/63009192","id":63009192,"diff_hunk":"@@ -0,0 +1,64 @@\n+/*\n+ * Copyright 2016 LINE Corporation\n+ *\n+ * LINE Corporation licenses this file to you under the Apache License,\n+ * version 2.0 (the \"License\"); you may not use this file except in compliance\n+ * with the License. You may obtain a copy of the License at:\n+ *\n+ *   http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT\n+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the\n+ * License for the specific language governing permissions and limitations\n+ * under the License.\n+ */\n+package com.linecorp.armeria.client.routing;\n+\n+import com.google.common.collect.ImmutableList;\n+\n+import static java.util.Objects.requireNonNull;\n+\n+import java.util.List;\n+\n+public final class StaticServerGroup<T extends Node> implements ServerGroup<T> {\n+\n+    private final ImmutableList<T> nodes;","path":"src/main/java/com/linecorp/armeria/client/routing/StaticServerGroup.java","position":26,"original_position":26,"commit_id":"8855ce0c18ac20b9b2ec76fe810f0ba14750d7ef","original_commit_id":"8855ce0c18ac20b9b2ec76fe810f0ba14750d7ef","user":{"login":"trustin","id":173918,"avatar_url":"https://avatars.githubusercontent.com/u/173918?v=3","gravatar_id":"","url":"https://api.github.com/users/trustin","html_url":"https://github.com/trustin","followers_url":"https://api.github.com/users/trustin/followers","following_url":"https://api.github.com/users/trustin/following{/other_user}","gists_url":"https://api.github.com/users/trustin/gists{/gist_id}","starred_url":"https://api.github.com/users/trustin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trustin/subscriptions","organizations_url":"https://api.github.com/users/trustin/orgs","repos_url":"https://api.github.com/users/trustin/repos","events_url":"https://api.github.com/users/trustin/events{/privacy}","received_events_url":"https://api.github.com/users/trustin/received_events","type":"User","site_admin":false},"body":"    List<T> nodes = ImmutableList.of(...);\r\n\r\n`nodes` is still immutable. I wasn't asking to change the implementation of `nodes` to a mutable one. :-)","created_at":"2016-05-12T12:13:54Z","updated_at":"2016-05-12T12:13:54Z","html_url":"https://github.com/line/armeria/pull/144#discussion_r63009192","pull_request_url":"https://api.github.com/repos/line/armeria/pulls/144","_links":{"self":{"href":"https://api.github.com/repos/line/armeria/pulls/comments/63009192"},"html":{"href":"https://github.com/line/armeria/pull/144#discussion_r63009192"},"pull_request":{"href":"https://api.github.com/repos/line/armeria/pulls/144"}}},"pull_request":{"url":"https://api.github.com/repos/line/armeria/pulls/144","id":66758546,"html_url":"https://github.com/line/armeria/pull/144","diff_url":"https://github.com/line/armeria/pull/144.diff","patch_url":"https://github.com/line/armeria/pull/144.patch","issue_url":"https://api.github.com/repos/line/armeria/issues/144","number":144,"state":"open","locked":false,"title":"Client side load balancer","user":{"login":"shelocks","id":732687,"avatar_url":"https://avatars.githubusercontent.com/u/732687?v=3","gravatar_id":"","url":"https://api.github.com/users/shelocks","html_url":"https://github.com/shelocks","followers_url":"https://api.github.com/users/shelocks/followers","following_url":"https://api.github.com/users/shelocks/following{/other_user}","gists_url":"https://api.github.com/users/shelocks/gists{/gist_id}","starred_url":"https://api.github.com/users/shelocks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shelocks/subscriptions","organizations_url":"https://api.github.com/users/shelocks/orgs","repos_url":"https://api.github.com/users/shelocks/repos","events_url":"https://api.github.com/users/shelocks/events{/privacy}","received_events_url":"https://api.github.com/users/shelocks/received_events","type":"User","site_admin":false},"body":"#87 ","created_at":"2016-04-17T05:01:55Z","updated_at":"2016-05-12T12:13:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"57bba3d33b11c0b17fccb5c1b5b2224506dc50c1","assignee":{"login":"trustin","id":173918,"avatar_url":"https://avatars.githubusercontent.com/u/173918?v=3","gravatar_id":"","url":"https://api.github.com/users/trustin","html_url":"https://github.com/trustin","followers_url":"https://api.github.com/users/trustin/followers","following_url":"https://api.github.com/users/trustin/following{/other_user}","gists_url":"https://api.github.com/users/trustin/gists{/gist_id}","starred_url":"https://api.github.com/users/trustin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trustin/subscriptions","organizations_url":"https://api.github.com/users/trustin/orgs","repos_url":"https://api.github.com/users/trustin/repos","events_url":"https://api.github.com/users/trustin/events{/privacy}","received_events_url":"https://api.github.com/users/trustin/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/line/armeria/milestones/25","html_url":"https://github.com/line/armeria/milestones/0.17.0.Final","labels_url":"https://api.github.com/repos/line/armeria/milestones/25/labels","id":1735439,"number":25,"title":"0.17.0.Final","description":null,"creator":{"login":"trustin","id":173918,"avatar_url":"https://avatars.githubusercontent.com/u/173918?v=3","gravatar_id":"","url":"https://api.github.com/users/trustin","html_url":"https://github.com/trustin","followers_url":"https://api.github.com/users/trustin/followers","following_url":"https://api.github.com/users/trustin/following{/other_user}","gists_url":"https://api.github.com/users/trustin/gists{/gist_id}","starred_url":"https://api.github.com/users/trustin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trustin/subscriptions","organizations_url":"https://api.github.com/users/trustin/orgs","repos_url":"https://api.github.com/users/trustin/repos","events_url":"https://api.github.com/users/trustin/events{/privacy}","received_events_url":"https://api.github.com/users/trustin/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":2,"state":"open","created_at":"2016-04-28T03:17:24Z","updated_at":"2016-05-12T12:07:45Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/line/armeria/pulls/144/commits","review_comments_url":"https://api.github.com/repos/line/armeria/pulls/144/comments","review_comment_url":"https://api.github.com/repos/line/armeria/pulls/comments{/number}","comments_url":"https://api.github.com/repos/line/armeria/issues/144/comments","statuses_url":"https://api.github.com/repos/line/armeria/statuses/8855ce0c18ac20b9b2ec76fe810f0ba14750d7ef","head":{"label":"shelocks:client-side-load-balancer","ref":"client-side-load-balancer","sha":"8855ce0c18ac20b9b2ec76fe810f0ba14750d7ef","user":{"login":"shelocks","id":732687,"avatar_url":"https://avatars.githubusercontent.com/u/732687?v=3","gravatar_id":"","url":"https://api.github.com/users/shelocks","html_url":"https://github.com/shelocks","followers_url":"https://api.github.com/users/shelocks/followers","following_url":"https://api.github.com/users/shelocks/following{/other_user}","gists_url":"https://api.github.com/users/shelocks/gists{/gist_id}","starred_url":"https://api.github.com/users/shelocks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shelocks/subscriptions","organizations_url":"https://api.github.com/users/shelocks/orgs","repos_url":"https://api.github.com/users/shelocks/repos","events_url":"https://api.github.com/users/shelocks/events{/privacy}","received_events_url":"https://api.github.com/users/shelocks/received_events","type":"User","site_admin":false},"repo":{"id":53329652,"name":"armeria","full_name":"shelocks/armeria","owner":{"login":"shelocks","id":732687,"avatar_url":"https://avatars.githubusercontent.com/u/732687?v=3","gravatar_id":"","url":"https://api.github.com/users/shelocks","html_url":"https://github.com/shelocks","followers_url":"https://api.github.com/users/shelocks/followers","following_url":"https://api.github.com/users/shelocks/following{/other_user}","gists_url":"https://api.github.com/users/shelocks/gists{/gist_id}","starred_url":"https://api.github.com/users/shelocks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shelocks/subscriptions","organizations_url":"https://api.github.com/users/shelocks/orgs","repos_url":"https://api.github.com/users/shelocks/repos","events_url":"https://api.github.com/users/shelocks/events{/privacy}","received_events_url":"https://api.github.com/users/shelocks/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shelocks/armeria","description":"Asynchronous RPC/API client/server library built on top of Java 8, Netty 4.1, HTTP/2, and Thrift","fork":true,"url":"https://api.github.com/repos/shelocks/armeria","forks_url":"https://api.github.com/repos/shelocks/armeria/forks","keys_url":"https://api.github.com/repos/shelocks/armeria/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shelocks/armeria/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shelocks/armeria/teams","hooks_url":"https://api.github.com/repos/shelocks/armeria/hooks","issue_events_url":"https://api.github.com/repos/shelocks/armeria/issues/events{/number}","events_url":"https://api.github.com/repos/shelocks/armeria/events","assignees_url":"https://api.github.com/repos/shelocks/armeria/assignees{/user}","branches_url":"https://api.github.com/repos/shelocks/armeria/branches{/branch}","tags_url":"https://api.github.com/repos/shelocks/armeria/tags","blobs_url":"https://api.github.com/repos/shelocks/armeria/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shelocks/armeria/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shelocks/armeria/git/refs{/sha}","trees_url":"https://api.github.com/repos/shelocks/armeria/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shelocks/armeria/statuses/{sha}","languages_url":"https://api.github.com/repos/shelocks/armeria/languages","stargazers_url":"https://api.github.com/repos/shelocks/armeria/stargazers","contributors_url":"https://api.github.com/repos/shelocks/armeria/contributors","subscribers_url":"https://api.github.com/repos/shelocks/armeria/subscribers","subscription_url":"https://api.github.com/repos/shelocks/armeria/subscription","commits_url":"https://api.github.com/repos/shelocks/armeria/commits{/sha}","git_commits_url":"https://api.github.com/repos/shelocks/armeria/git/commits{/sha}","comments_url":"https://api.github.com/repos/shelocks/armeria/comments{/number}","issue_comment_url":"https://api.github.com/repos/shelocks/armeria/issues/comments{/number}","contents_url":"https://api.github.com/repos/shelocks/armeria/contents/{+path}","compare_url":"https://api.github.com/repos/shelocks/armeria/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shelocks/armeria/merges","archive_url":"https://api.github.com/repos/shelocks/armeria/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shelocks/armeria/downloads","issues_url":"https://api.github.com/repos/shelocks/armeria/issues{/number}","pulls_url":"https://api.github.com/repos/shelocks/armeria/pulls{/number}","milestones_url":"https://api.github.com/repos/shelocks/armeria/milestones{/number}","notifications_url":"https://api.github.com/repos/shelocks/armeria/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shelocks/armeria/labels{/name}","releases_url":"https://api.github.com/repos/shelocks/armeria/releases{/id}","deployments_url":"https://api.github.com/repos/shelocks/armeria/deployments","created_at":"2016-03-07T13:59:45Z","updated_at":"2016-03-07T13:59:47Z","pushed_at":"2016-05-04T09:41:54Z","git_url":"git://github.com/shelocks/armeria.git","ssh_url":"git@github.com:shelocks/armeria.git","clone_url":"https://github.com/shelocks/armeria.git","svn_url":"https://github.com/shelocks/armeria","homepage":"http://line.github.io/armeria/","size":10536,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"line:master","ref":"master","sha":"389b35b23ab7e65c5ffe7d77cc2dd6f41d3c4a14","user":{"login":"line","id":13128444,"avatar_url":"https://avatars.githubusercontent.com/u/13128444?v=3","gravatar_id":"","url":"https://api.github.com/users/line","html_url":"https://github.com/line","followers_url":"https://api.github.com/users/line/followers","following_url":"https://api.github.com/users/line/following{/other_user}","gists_url":"https://api.github.com/users/line/gists{/gist_id}","starred_url":"https://api.github.com/users/line/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/line/subscriptions","organizations_url":"https://api.github.com/users/line/orgs","repos_url":"https://api.github.com/users/line/repos","events_url":"https://api.github.com/users/line/events{/privacy}","received_events_url":"https://api.github.com/users/line/received_events","type":"Organization","site_admin":false},"repo":{"id":46251204,"name":"armeria","full_name":"line/armeria","owner":{"login":"line","id":13128444,"avatar_url":"https://avatars.githubusercontent.com/u/13128444?v=3","gravatar_id":"","url":"https://api.github.com/users/line","html_url":"https://github.com/line","followers_url":"https://api.github.com/users/line/followers","following_url":"https://api.github.com/users/line/following{/other_user}","gists_url":"https://api.github.com/users/line/gists{/gist_id}","starred_url":"https://api.github.com/users/line/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/line/subscriptions","organizations_url":"https://api.github.com/users/line/orgs","repos_url":"https://api.github.com/users/line/repos","events_url":"https://api.github.com/users/line/events{/privacy}","received_events_url":"https://api.github.com/users/line/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/line/armeria","description":"Asynchronous RPC/API client/server library built on top of Java 8, Netty 4.1, HTTP/2, and Thrift","fork":false,"url":"https://api.github.com/repos/line/armeria","forks_url":"https://api.github.com/repos/line/armeria/forks","keys_url":"https://api.github.com/repos/line/armeria/keys{/key_id}","collaborators_url":"https://api.github.com/repos/line/armeria/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/line/armeria/teams","hooks_url":"https://api.github.com/repos/line/armeria/hooks","issue_events_url":"https://api.github.com/repos/line/armeria/issues/events{/number}","events_url":"https://api.github.com/repos/line/armeria/events","assignees_url":"https://api.github.com/repos/line/armeria/assignees{/user}","branches_url":"https://api.github.com/repos/line/armeria/branches{/branch}","tags_url":"https://api.github.com/repos/line/armeria/tags","blobs_url":"https://api.github.com/repos/line/armeria/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/line/armeria/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/line/armeria/git/refs{/sha}","trees_url":"https://api.github.com/repos/line/armeria/git/trees{/sha}","statuses_url":"https://api.github.com/repos/line/armeria/statuses/{sha}","languages_url":"https://api.github.com/repos/line/armeria/languages","stargazers_url":"https://api.github.com/repos/line/armeria/stargazers","contributors_url":"https://api.github.com/repos/line/armeria/contributors","subscribers_url":"https://api.github.com/repos/line/armeria/subscribers","subscription_url":"https://api.github.com/repos/line/armeria/subscription","commits_url":"https://api.github.com/repos/line/armeria/commits{/sha}","git_commits_url":"https://api.github.com/repos/line/armeria/git/commits{/sha}","comments_url":"https://api.github.com/repos/line/armeria/comments{/number}","issue_comment_url":"https://api.github.com/repos/line/armeria/issues/comments{/number}","contents_url":"https://api.github.com/repos/line/armeria/contents/{+path}","compare_url":"https://api.github.com/repos/line/armeria/compare/{base}...{head}","merges_url":"https://api.github.com/repos/line/armeria/merges","archive_url":"https://api.github.com/repos/line/armeria/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/line/armeria/downloads","issues_url":"https://api.github.com/repos/line/armeria/issues{/number}","pulls_url":"https://api.github.com/repos/line/armeria/pulls{/number}","milestones_url":"https://api.github.com/repos/line/armeria/milestones{/number}","notifications_url":"https://api.github.com/repos/line/armeria/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/line/armeria/labels{/name}","releases_url":"https://api.github.com/repos/line/armeria/releases{/id}","deployments_url":"https://api.github.com/repos/line/armeria/deployments","created_at":"2015-11-16T04:04:01Z","updated_at":"2016-05-12T10:50:52Z","pushed_at":"2016-05-12T12:07:45Z","git_url":"git://github.com/line/armeria.git","ssh_url":"git@github.com:line/armeria.git","clone_url":"https://github.com/line/armeria.git","svn_url":"https://github.com/line/armeria","homepage":"http://line.github.io/armeria/","size":10812,"stargazers_count":373,"watchers_count":373,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":78,"mirror_url":null,"open_issues_count":25,"forks":78,"open_issues":25,"watchers":373,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/line/armeria/pulls/144"},"html":{"href":"https://github.com/line/armeria/pull/144"},"issue":{"href":"https://api.github.com/repos/line/armeria/issues/144"},"comments":{"href":"https://api.github.com/repos/line/armeria/issues/144/comments"},"review_comments":{"href":"https://api.github.com/repos/line/armeria/pulls/144/comments"},"review_comment":{"href":"https://api.github.com/repos/line/armeria/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/line/armeria/pulls/144/commits"},"statuses":{"href":"https://api.github.com/repos/line/armeria/statuses/8855ce0c18ac20b9b2ec76fe810f0ba14750d7ef"}}}}