{"action":"created","comment":{"url":"https://api.github.com/repos/goadesign/goa/pulls/comments/92101541","pull_request_review_id":12610149,"id":92101541,"diff_hunk":"@@ -260,6 +260,7 @@ func ValidationChecker(att *design.AttributeDefinition, nonzero, required, hasDe\n \t\t\"context\":   context,\n \t\t\"target\":    target,\n \t\t\"targetVal\": t,\n+\t\t\"string\":    att.Type.Name() == \"string\",","path":"goagen/codegen/validation.go","position":4,"original_position":4,"commit_id":"7b80871c10aa696fa3cf8ac8ac9ec214ed411e39","original_commit_id":"7b80871c10aa696fa3cf8ac8ac9ec214ed411e39","user":{"login":"raphael","id":36822,"avatar_url":"https://avatars.githubusercontent.com/u/36822?v=3","gravatar_id":"","url":"https://api.github.com/users/raphael","html_url":"https://github.com/raphael","followers_url":"https://api.github.com/users/raphael/followers","following_url":"https://api.github.com/users/raphael/following{/other_user}","gists_url":"https://api.github.com/users/raphael/gists{/gist_id}","starred_url":"https://api.github.com/users/raphael/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raphael/subscriptions","organizations_url":"https://api.github.com/users/raphael/orgs","repos_url":"https://api.github.com/users/raphael/repos","events_url":"https://api.github.com/users/raphael/events{/privacy}","received_events_url":"https://api.github.com/users/raphael/received_events","type":"User","site_admin":false},"body":"Small thing: do you think you could use `att.Type.Kind() == design.StringKind` instead ? Thank you!","created_at":"2016-12-13T05:47:03Z","updated_at":"2016-12-13T05:47:03Z","html_url":"https://github.com/goadesign/goa/pull/962#discussion_r92101541","pull_request_url":"https://api.github.com/repos/goadesign/goa/pulls/962","_links":{"self":{"href":"https://api.github.com/repos/goadesign/goa/pulls/comments/92101541"},"html":{"href":"https://github.com/goadesign/goa/pull/962#discussion_r92101541"},"pull_request":{"href":"https://api.github.com/repos/goadesign/goa/pulls/962"}}},"pull_request":{"url":"https://api.github.com/repos/goadesign/goa/pulls/962","id":97681968,"html_url":"https://github.com/goadesign/goa/pull/962","diff_url":"https://github.com/goadesign/goa/pull/962.diff","patch_url":"https://github.com/goadesign/goa/pull/962.patch","issue_url":"https://api.github.com/repos/goadesign/goa/issues/962","number":962,"state":"open","locked":false,"title":"Fix the generation of length validation for strings that contain multi-byte UTF-8 characters.","user":{"login":"ikawaha","id":4232165,"avatar_url":"https://avatars.githubusercontent.com/u/4232165?v=3","gravatar_id":"","url":"https://api.github.com/users/ikawaha","html_url":"https://github.com/ikawaha","followers_url":"https://api.github.com/users/ikawaha/followers","following_url":"https://api.github.com/users/ikawaha/following{/other_user}","gists_url":"https://api.github.com/users/ikawaha/gists{/gist_id}","starred_url":"https://api.github.com/users/ikawaha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ikawaha/subscriptions","organizations_url":"https://api.github.com/users/ikawaha/orgs","repos_url":"https://api.github.com/users/ikawaha/repos","events_url":"https://api.github.com/users/ikawaha/events{/privacy}","received_events_url":"https://api.github.com/users/ikawaha/received_events","type":"User","site_admin":false},"body":"Checking the difference of v1.1.0, I noticed that #740 is not backporting to the v1 branch.\r\n","created_at":"2016-12-13T03:47:39Z","updated_at":"2016-12-13T05:47:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b5c9a1fe59d90e2365fd4dbbb483d9c0abde2d0c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/goadesign/goa/pulls/962/commits","review_comments_url":"https://api.github.com/repos/goadesign/goa/pulls/962/comments","review_comment_url":"https://api.github.com/repos/goadesign/goa/pulls/comments{/number}","comments_url":"https://api.github.com/repos/goadesign/goa/issues/962/comments","statuses_url":"https://api.github.com/repos/goadesign/goa/statuses/7b80871c10aa696fa3cf8ac8ac9ec214ed411e39","head":{"label":"ikawaha:fix/740_backport_v1","ref":"fix/740_backport_v1","sha":"7b80871c10aa696fa3cf8ac8ac9ec214ed411e39","user":{"login":"ikawaha","id":4232165,"avatar_url":"https://avatars.githubusercontent.com/u/4232165?v=3","gravatar_id":"","url":"https://api.github.com/users/ikawaha","html_url":"https://github.com/ikawaha","followers_url":"https://api.github.com/users/ikawaha/followers","following_url":"https://api.github.com/users/ikawaha/following{/other_user}","gists_url":"https://api.github.com/users/ikawaha/gists{/gist_id}","starred_url":"https://api.github.com/users/ikawaha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ikawaha/subscriptions","organizations_url":"https://api.github.com/users/ikawaha/orgs","repos_url":"https://api.github.com/users/ikawaha/repos","events_url":"https://api.github.com/users/ikawaha/events{/privacy}","received_events_url":"https://api.github.com/users/ikawaha/received_events","type":"User","site_admin":false},"repo":{"id":56056019,"name":"goa","full_name":"ikawaha/goa","owner":{"login":"ikawaha","id":4232165,"avatar_url":"https://avatars.githubusercontent.com/u/4232165?v=3","gravatar_id":"","url":"https://api.github.com/users/ikawaha","html_url":"https://github.com/ikawaha","followers_url":"https://api.github.com/users/ikawaha/followers","following_url":"https://api.github.com/users/ikawaha/following{/other_user}","gists_url":"https://api.github.com/users/ikawaha/gists{/gist_id}","starred_url":"https://api.github.com/users/ikawaha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ikawaha/subscriptions","organizations_url":"https://api.github.com/users/ikawaha/orgs","repos_url":"https://api.github.com/users/ikawaha/repos","events_url":"https://api.github.com/users/ikawaha/events{/privacy}","received_events_url":"https://api.github.com/users/ikawaha/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ikawaha/goa","description":"Design-based microservices in Go","fork":true,"url":"https://api.github.com/repos/ikawaha/goa","forks_url":"https://api.github.com/repos/ikawaha/goa/forks","keys_url":"https://api.github.com/repos/ikawaha/goa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ikawaha/goa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ikawaha/goa/teams","hooks_url":"https://api.github.com/repos/ikawaha/goa/hooks","issue_events_url":"https://api.github.com/repos/ikawaha/goa/issues/events{/number}","events_url":"https://api.github.com/repos/ikawaha/goa/events","assignees_url":"https://api.github.com/repos/ikawaha/goa/assignees{/user}","branches_url":"https://api.github.com/repos/ikawaha/goa/branches{/branch}","tags_url":"https://api.github.com/repos/ikawaha/goa/tags","blobs_url":"https://api.github.com/repos/ikawaha/goa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ikawaha/goa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ikawaha/goa/git/refs{/sha}","trees_url":"https://api.github.com/repos/ikawaha/goa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ikawaha/goa/statuses/{sha}","languages_url":"https://api.github.com/repos/ikawaha/goa/languages","stargazers_url":"https://api.github.com/repos/ikawaha/goa/stargazers","contributors_url":"https://api.github.com/repos/ikawaha/goa/contributors","subscribers_url":"https://api.github.com/repos/ikawaha/goa/subscribers","subscription_url":"https://api.github.com/repos/ikawaha/goa/subscription","commits_url":"https://api.github.com/repos/ikawaha/goa/commits{/sha}","git_commits_url":"https://api.github.com/repos/ikawaha/goa/git/commits{/sha}","comments_url":"https://api.github.com/repos/ikawaha/goa/comments{/number}","issue_comment_url":"https://api.github.com/repos/ikawaha/goa/issues/comments{/number}","contents_url":"https://api.github.com/repos/ikawaha/goa/contents/{+path}","compare_url":"https://api.github.com/repos/ikawaha/goa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ikawaha/goa/merges","archive_url":"https://api.github.com/repos/ikawaha/goa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ikawaha/goa/downloads","issues_url":"https://api.github.com/repos/ikawaha/goa/issues{/number}","pulls_url":"https://api.github.com/repos/ikawaha/goa/pulls{/number}","milestones_url":"https://api.github.com/repos/ikawaha/goa/milestones{/number}","notifications_url":"https://api.github.com/repos/ikawaha/goa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ikawaha/goa/labels{/name}","releases_url":"https://api.github.com/repos/ikawaha/goa/releases{/id}","deployments_url":"https://api.github.com/repos/ikawaha/goa/deployments","created_at":"2016-04-12T11:12:36Z","updated_at":"2016-04-12T11:12:59Z","pushed_at":"2016-12-13T03:31:55Z","git_url":"git://github.com/ikawaha/goa.git","ssh_url":"git@github.com:ikawaha/goa.git","clone_url":"https://github.com/ikawaha/goa.git","svn_url":"https://github.com/ikawaha/goa","homepage":"http://goa.design","size":13854,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"goadesign:v1","ref":"v1","sha":"7fc6b55040a7f8a800500c44c547692a0d7aed77","user":{"login":"goadesign","id":16568515,"avatar_url":"https://avatars.githubusercontent.com/u/16568515?v=3","gravatar_id":"","url":"https://api.github.com/users/goadesign","html_url":"https://github.com/goadesign","followers_url":"https://api.github.com/users/goadesign/followers","following_url":"https://api.github.com/users/goadesign/following{/other_user}","gists_url":"https://api.github.com/users/goadesign/gists{/gist_id}","starred_url":"https://api.github.com/users/goadesign/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goadesign/subscriptions","organizations_url":"https://api.github.com/users/goadesign/orgs","repos_url":"https://api.github.com/users/goadesign/repos","events_url":"https://api.github.com/users/goadesign/events{/privacy}","received_events_url":"https://api.github.com/users/goadesign/received_events","type":"Organization","site_admin":false},"repo":{"id":27579614,"name":"goa","full_name":"goadesign/goa","owner":{"login":"goadesign","id":16568515,"avatar_url":"https://avatars.githubusercontent.com/u/16568515?v=3","gravatar_id":"","url":"https://api.github.com/users/goadesign","html_url":"https://github.com/goadesign","followers_url":"https://api.github.com/users/goadesign/followers","following_url":"https://api.github.com/users/goadesign/following{/other_user}","gists_url":"https://api.github.com/users/goadesign/gists{/gist_id}","starred_url":"https://api.github.com/users/goadesign/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goadesign/subscriptions","organizations_url":"https://api.github.com/users/goadesign/orgs","repos_url":"https://api.github.com/users/goadesign/repos","events_url":"https://api.github.com/users/goadesign/events{/privacy}","received_events_url":"https://api.github.com/users/goadesign/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/goadesign/goa","description":"Design-based APIs and microservices in Go","fork":false,"url":"https://api.github.com/repos/goadesign/goa","forks_url":"https://api.github.com/repos/goadesign/goa/forks","keys_url":"https://api.github.com/repos/goadesign/goa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/goadesign/goa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/goadesign/goa/teams","hooks_url":"https://api.github.com/repos/goadesign/goa/hooks","issue_events_url":"https://api.github.com/repos/goadesign/goa/issues/events{/number}","events_url":"https://api.github.com/repos/goadesign/goa/events","assignees_url":"https://api.github.com/repos/goadesign/goa/assignees{/user}","branches_url":"https://api.github.com/repos/goadesign/goa/branches{/branch}","tags_url":"https://api.github.com/repos/goadesign/goa/tags","blobs_url":"https://api.github.com/repos/goadesign/goa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/goadesign/goa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/goadesign/goa/git/refs{/sha}","trees_url":"https://api.github.com/repos/goadesign/goa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/goadesign/goa/statuses/{sha}","languages_url":"https://api.github.com/repos/goadesign/goa/languages","stargazers_url":"https://api.github.com/repos/goadesign/goa/stargazers","contributors_url":"https://api.github.com/repos/goadesign/goa/contributors","subscribers_url":"https://api.github.com/repos/goadesign/goa/subscribers","subscription_url":"https://api.github.com/repos/goadesign/goa/subscription","commits_url":"https://api.github.com/repos/goadesign/goa/commits{/sha}","git_commits_url":"https://api.github.com/repos/goadesign/goa/git/commits{/sha}","comments_url":"https://api.github.com/repos/goadesign/goa/comments{/number}","issue_comment_url":"https://api.github.com/repos/goadesign/goa/issues/comments{/number}","contents_url":"https://api.github.com/repos/goadesign/goa/contents/{+path}","compare_url":"https://api.github.com/repos/goadesign/goa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/goadesign/goa/merges","archive_url":"https://api.github.com/repos/goadesign/goa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/goadesign/goa/downloads","issues_url":"https://api.github.com/repos/goadesign/goa/issues{/number}","pulls_url":"https://api.github.com/repos/goadesign/goa/pulls{/number}","milestones_url":"https://api.github.com/repos/goadesign/goa/milestones{/number}","notifications_url":"https://api.github.com/repos/goadesign/goa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/goadesign/goa/labels{/name}","releases_url":"https://api.github.com/repos/goadesign/goa/releases{/id}","deployments_url":"https://api.github.com/repos/goadesign/goa/deployments","created_at":"2014-12-05T07:17:53Z","updated_at":"2016-12-13T01:52:15Z","pushed_at":"2016-12-13T03:47:39Z","git_url":"git://github.com/goadesign/goa.git","ssh_url":"git@github.com:goadesign/goa.git","clone_url":"https://github.com/goadesign/goa.git","svn_url":"https://github.com/goadesign/goa","homepage":"https://goa.design","size":16963,"stargazers_count":1597,"watchers_count":1597,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":138,"mirror_url":null,"open_issues_count":48,"forks":138,"open_issues":48,"watchers":1597,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/goadesign/goa/pulls/962"},"html":{"href":"https://github.com/goadesign/goa/pull/962"},"issue":{"href":"https://api.github.com/repos/goadesign/goa/issues/962"},"comments":{"href":"https://api.github.com/repos/goadesign/goa/issues/962/comments"},"review_comments":{"href":"https://api.github.com/repos/goadesign/goa/pulls/962/comments"},"review_comment":{"href":"https://api.github.com/repos/goadesign/goa/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/goadesign/goa/pulls/962/commits"},"statuses":{"href":"https://api.github.com/repos/goadesign/goa/statuses/7b80871c10aa696fa3cf8ac8ac9ec214ed411e39"}}}}
{"actor":{"display_login":"raphael"}}