{"action":"created","comment":{"url":"https://api.github.com/repos/ros2/rcl/pulls/comments/52571427","id":52571427,"diff_hunk":"@@ -0,0 +1,90 @@\n+# Copyright 2016 Open Source Robotics Foundation, Inc.\n+#\n+# Licensed under the Apache License, Version 2.0 (the \"License\");\n+# you may not use this file except in compliance with the License.\n+# You may obtain a copy of the License at\n+#\n+#     http://www.apache.org/licenses/LICENSE-2.0\n+#\n+# Unless required by applicable law or agreed to in writing, software\n+# distributed under the License is distributed on an \"AS IS\" BASIS,\n+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+# See the License for the specific language governing permissions and\n+# limitations under the License.\n+\n+#\n+# Get all information abut rcl for a specific RMW implementation.\n+#\n+# It sets the common variables _DEFINITIONS, _INCLUDE_DIRS and _LIBRARIES\n+# with the given prefix.\n+#\n+# :param rmw_implementation: the RMW implementation name\n+# :type target: string\n+# :param var_prefix: the prefix of all output variable names\n+# :type var_prefix: string\n+#\n+# Copy/pasted from rclcpp/cmake/get_rclcpp_information.cmake.\n+# Code duplication is evil. Don't do this at home, kids.\n+\n+macro(get_rcl_information rmw_implementation var_prefix)\n+  # pretend to be a \"package\"\n+  # so that the variables can be used by various functions / macros\n+  set(${var_prefix}_FOUND TRUE)\n+\n+  # include directories\n+  set(${var_prefix}_INCLUDE_DIRS \"${rcl_DIR}/../../../include\")\n+\n+  # libraries\n+  set(_libs)\n+  # search for library relative to this CMake file\n+  set(_library_target \"rcl\")\n+  get_available_rmw_implementations(_rmw_impls)\n+  list(LENGTH _rmw_impls _rmw_impls_length)\n+  if(_rmw_impls_length GREATER 1)\n+    set(_library_target \"${_library_target}__${rmw_implementation}\")\n+  endif()\n+  set(_lib \"NOTFOUND\")\n+  find_library(\n+    _lib NAMES \"${_library_target}\"\n+    PATHS \"${rcl_DIR}/../../../lib\"\n+    NO_DEFAULT_PATH NO_CMAKE_FIND_ROOT_PATH\n+  )\n+  if(NOT _lib)\n+    # warn about not existing library and ignore it\n+    message(FATAL_ERROR \"Package 'rcl' doesn't contain the library '${_library_target}'\")\n+  elseif(NOT IS_ABSOLUTE \"${_lib}\")\n+    # the found library must be an absolute path\n+    message(FATAL_ERROR \"Package 'rcl' found the library '${_library_target}' at '${_lib}' which is not an absolute path\")\n+  elseif(NOT EXISTS \"${_lib}\")\n+    # the found library must exist\n+    message(FATAL_ERROR \"Package 'rcl' found the library '${_lib}' which doesn't exist\")\n+  else()\n+    list(APPEND _libs \"${_lib}\")\n+  endif()\n+\n+  # dependencies\n+  set(_exported_dependencies\n+    \"rcl_interfaces\"\n+    \"rmw\"\n+    \"${rmw_implementation}\"\n+    \"rosidl_generator_c\")\n+  set(${var_prefix}_DEFINITIONS)\n+  foreach(_dep ${_exported_dependencies})\n+    if(NOT ${_dep}_FOUND)\n+      find_package(\"${_dep}\" QUIET REQUIRED)\n+    endif()\n+    if(${_dep}_DEFINITIONS)\n+      list_append_unique(${var_prefix}_DEFINITIONS \"${${_dep}_DEFINITIONS}\")","path":"rcl/cmake/get_rcl_information.cmake","position":77,"original_position":77,"commit_id":"fb819fbf264bf64cfa663082b4390eab077b23b6","original_commit_id":"fb819fbf264bf64cfa663082b4390eab077b23b6","user":{"login":"dirk-thomas","id":1335366,"avatar_url":"https://avatars.githubusercontent.com/u/1335366?v=3","gravatar_id":"","url":"https://api.github.com/users/dirk-thomas","html_url":"https://github.com/dirk-thomas","followers_url":"https://api.github.com/users/dirk-thomas/followers","following_url":"https://api.github.com/users/dirk-thomas/following{/other_user}","gists_url":"https://api.github.com/users/dirk-thomas/gists{/gist_id}","starred_url":"https://api.github.com/users/dirk-thomas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dirk-thomas/subscriptions","organizations_url":"https://api.github.com/users/dirk-thomas/orgs","repos_url":"https://api.github.com/users/dirk-thomas/repos","events_url":"https://api.github.com/users/dirk-thomas/events{/privacy}","received_events_url":"https://api.github.com/users/dirk-thomas/received_events","type":"User","site_admin":false},"body":"In order to use these functions the package should exec_depend on `ament_cmake` and also export the dep in CMake.","created_at":"2016-02-11T08:00:37Z","updated_at":"2016-02-11T08:00:37Z","html_url":"https://github.com/ros2/rcl/pull/21#discussion_r52571427","pull_request_url":"https://api.github.com/repos/ros2/rcl/pulls/21","_links":{"self":{"href":"https://api.github.com/repos/ros2/rcl/pulls/comments/52571427"},"html":{"href":"https://github.com/ros2/rcl/pull/21#discussion_r52571427"},"pull_request":{"href":"https://api.github.com/repos/ros2/rcl/pulls/21"}}},"pull_request":{"url":"https://api.github.com/repos/ros2/rcl/pulls/21","id":58809796,"html_url":"https://github.com/ros2/rcl/pull/21","diff_url":"https://github.com/ros2/rcl/pull/21.diff","patch_url":"https://github.com/ros2/rcl/pull/21.patch","issue_url":"https://api.github.com/repos/ros2/rcl/issues/21","number":21,"state":"open","locked":false,"title":"C typesupport tests","user":{"login":"wjwwood","id":100427,"avatar_url":"https://avatars.githubusercontent.com/u/100427?v=3","gravatar_id":"","url":"https://api.github.com/users/wjwwood","html_url":"https://github.com/wjwwood","followers_url":"https://api.github.com/users/wjwwood/followers","following_url":"https://api.github.com/users/wjwwood/following{/other_user}","gists_url":"https://api.github.com/users/wjwwood/gists{/gist_id}","starred_url":"https://api.github.com/users/wjwwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wjwwood/subscriptions","organizations_url":"https://api.github.com/users/wjwwood/orgs","repos_url":"https://api.github.com/users/wjwwood/repos","events_url":"https://api.github.com/users/wjwwood/events{/privacy}","received_events_url":"https://api.github.com/users/wjwwood/received_events","type":"User","site_admin":false},"body":"This pull request adds more tests to test the end to end functionality of C type support.\r\n\r\nThere are some temporary hacks to limit the tests to the type support implementations that support C properly (OpenSplice and Connext static).\r\n\r\nThere are two related pull requests:\r\n\r\n- https://github.com/ros2/rmw_opensplice/pull/110\r\n- https://github.com/ros2/rmw_connext/pull/130\r\n\r\nAlso the `examples` repository has a branch that matches this one, but I do not propose we merge that right now. It was mostly a test to run locally and I believe the tests in `rcl` now cover the same functionality of the code.","created_at":"2016-02-09T21:15:22Z","updated_at":"2016-02-11T08:00:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"20a0ce02d9232043f61fddfc83fb2db91a594eb2","assignee":{"login":"wjwwood","id":100427,"avatar_url":"https://avatars.githubusercontent.com/u/100427?v=3","gravatar_id":"","url":"https://api.github.com/users/wjwwood","html_url":"https://github.com/wjwwood","followers_url":"https://api.github.com/users/wjwwood/followers","following_url":"https://api.github.com/users/wjwwood/following{/other_user}","gists_url":"https://api.github.com/users/wjwwood/gists{/gist_id}","starred_url":"https://api.github.com/users/wjwwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wjwwood/subscriptions","organizations_url":"https://api.github.com/users/wjwwood/orgs","repos_url":"https://api.github.com/users/wjwwood/repos","events_url":"https://api.github.com/users/wjwwood/events{/privacy}","received_events_url":"https://api.github.com/users/wjwwood/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/ros2/rcl/pulls/21/commits","review_comments_url":"https://api.github.com/repos/ros2/rcl/pulls/21/comments","review_comment_url":"https://api.github.com/repos/ros2/rcl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ros2/rcl/issues/21/comments","statuses_url":"https://api.github.com/repos/ros2/rcl/statuses/fb819fbf264bf64cfa663082b4390eab077b23b6","head":{"label":"ros2:c_typesupport_tests","ref":"c_typesupport_tests","sha":"fb819fbf264bf64cfa663082b4390eab077b23b6","user":{"login":"ros2","id":3979232,"avatar_url":"https://avatars.githubusercontent.com/u/3979232?v=3","gravatar_id":"","url":"https://api.github.com/users/ros2","html_url":"https://github.com/ros2","followers_url":"https://api.github.com/users/ros2/followers","following_url":"https://api.github.com/users/ros2/following{/other_user}","gists_url":"https://api.github.com/users/ros2/gists{/gist_id}","starred_url":"https://api.github.com/users/ros2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros2/subscriptions","organizations_url":"https://api.github.com/users/ros2/orgs","repos_url":"https://api.github.com/users/ros2/repos","events_url":"https://api.github.com/users/ros2/events{/privacy}","received_events_url":"https://api.github.com/users/ros2/received_events","type":"Organization","site_admin":false},"repo":{"id":31091419,"name":"rcl","full_name":"ros2/rcl","owner":{"login":"ros2","id":3979232,"avatar_url":"https://avatars.githubusercontent.com/u/3979232?v=3","gravatar_id":"","url":"https://api.github.com/users/ros2","html_url":"https://github.com/ros2","followers_url":"https://api.github.com/users/ros2/followers","following_url":"https://api.github.com/users/ros2/following{/other_user}","gists_url":"https://api.github.com/users/ros2/gists{/gist_id}","starred_url":"https://api.github.com/users/ros2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros2/subscriptions","organizations_url":"https://api.github.com/users/ros2/orgs","repos_url":"https://api.github.com/users/ros2/repos","events_url":"https://api.github.com/users/ros2/events{/privacy}","received_events_url":"https://api.github.com/users/ros2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ros2/rcl","description":"Library to support implementation of language specific ROS Client Libraries.","fork":false,"url":"https://api.github.com/repos/ros2/rcl","forks_url":"https://api.github.com/repos/ros2/rcl/forks","keys_url":"https://api.github.com/repos/ros2/rcl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ros2/rcl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ros2/rcl/teams","hooks_url":"https://api.github.com/repos/ros2/rcl/hooks","issue_events_url":"https://api.github.com/repos/ros2/rcl/issues/events{/number}","events_url":"https://api.github.com/repos/ros2/rcl/events","assignees_url":"https://api.github.com/repos/ros2/rcl/assignees{/user}","branches_url":"https://api.github.com/repos/ros2/rcl/branches{/branch}","tags_url":"https://api.github.com/repos/ros2/rcl/tags","blobs_url":"https://api.github.com/repos/ros2/rcl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ros2/rcl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ros2/rcl/git/refs{/sha}","trees_url":"https://api.github.com/repos/ros2/rcl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ros2/rcl/statuses/{sha}","languages_url":"https://api.github.com/repos/ros2/rcl/languages","stargazers_url":"https://api.github.com/repos/ros2/rcl/stargazers","contributors_url":"https://api.github.com/repos/ros2/rcl/contributors","subscribers_url":"https://api.github.com/repos/ros2/rcl/subscribers","subscription_url":"https://api.github.com/repos/ros2/rcl/subscription","commits_url":"https://api.github.com/repos/ros2/rcl/commits{/sha}","git_commits_url":"https://api.github.com/repos/ros2/rcl/git/commits{/sha}","comments_url":"https://api.github.com/repos/ros2/rcl/comments{/number}","issue_comment_url":"https://api.github.com/repos/ros2/rcl/issues/comments{/number}","contents_url":"https://api.github.com/repos/ros2/rcl/contents/{+path}","compare_url":"https://api.github.com/repos/ros2/rcl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ros2/rcl/merges","archive_url":"https://api.github.com/repos/ros2/rcl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ros2/rcl/downloads","issues_url":"https://api.github.com/repos/ros2/rcl/issues{/number}","pulls_url":"https://api.github.com/repos/ros2/rcl/pulls{/number}","milestones_url":"https://api.github.com/repos/ros2/rcl/milestones{/number}","notifications_url":"https://api.github.com/repos/ros2/rcl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ros2/rcl/labels{/name}","releases_url":"https://api.github.com/repos/ros2/rcl/releases{/id}","deployments_url":"https://api.github.com/repos/ros2/rcl/deployments","created_at":"2015-02-21T00:06:40Z","updated_at":"2016-01-13T01:48:19Z","pushed_at":"2016-02-11T07:56:53Z","git_url":"git://github.com/ros2/rcl.git","ssh_url":"git@github.com:ros2/rcl.git","clone_url":"https://github.com/ros2/rcl.git","svn_url":"https://github.com/ros2/rcl","homepage":null,"size":242,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":4,"forks":2,"open_issues":4,"watchers":2,"default_branch":"master"}},"base":{"label":"ros2:master","ref":"master","sha":"d16c76ded66710f849c1d1cf0f9d4a5e802fa25c","user":{"login":"ros2","id":3979232,"avatar_url":"https://avatars.githubusercontent.com/u/3979232?v=3","gravatar_id":"","url":"https://api.github.com/users/ros2","html_url":"https://github.com/ros2","followers_url":"https://api.github.com/users/ros2/followers","following_url":"https://api.github.com/users/ros2/following{/other_user}","gists_url":"https://api.github.com/users/ros2/gists{/gist_id}","starred_url":"https://api.github.com/users/ros2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros2/subscriptions","organizations_url":"https://api.github.com/users/ros2/orgs","repos_url":"https://api.github.com/users/ros2/repos","events_url":"https://api.github.com/users/ros2/events{/privacy}","received_events_url":"https://api.github.com/users/ros2/received_events","type":"Organization","site_admin":false},"repo":{"id":31091419,"name":"rcl","full_name":"ros2/rcl","owner":{"login":"ros2","id":3979232,"avatar_url":"https://avatars.githubusercontent.com/u/3979232?v=3","gravatar_id":"","url":"https://api.github.com/users/ros2","html_url":"https://github.com/ros2","followers_url":"https://api.github.com/users/ros2/followers","following_url":"https://api.github.com/users/ros2/following{/other_user}","gists_url":"https://api.github.com/users/ros2/gists{/gist_id}","starred_url":"https://api.github.com/users/ros2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros2/subscriptions","organizations_url":"https://api.github.com/users/ros2/orgs","repos_url":"https://api.github.com/users/ros2/repos","events_url":"https://api.github.com/users/ros2/events{/privacy}","received_events_url":"https://api.github.com/users/ros2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ros2/rcl","description":"Library to support implementation of language specific ROS Client Libraries.","fork":false,"url":"https://api.github.com/repos/ros2/rcl","forks_url":"https://api.github.com/repos/ros2/rcl/forks","keys_url":"https://api.github.com/repos/ros2/rcl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ros2/rcl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ros2/rcl/teams","hooks_url":"https://api.github.com/repos/ros2/rcl/hooks","issue_events_url":"https://api.github.com/repos/ros2/rcl/issues/events{/number}","events_url":"https://api.github.com/repos/ros2/rcl/events","assignees_url":"https://api.github.com/repos/ros2/rcl/assignees{/user}","branches_url":"https://api.github.com/repos/ros2/rcl/branches{/branch}","tags_url":"https://api.github.com/repos/ros2/rcl/tags","blobs_url":"https://api.github.com/repos/ros2/rcl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ros2/rcl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ros2/rcl/git/refs{/sha}","trees_url":"https://api.github.com/repos/ros2/rcl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ros2/rcl/statuses/{sha}","languages_url":"https://api.github.com/repos/ros2/rcl/languages","stargazers_url":"https://api.github.com/repos/ros2/rcl/stargazers","contributors_url":"https://api.github.com/repos/ros2/rcl/contributors","subscribers_url":"https://api.github.com/repos/ros2/rcl/subscribers","subscription_url":"https://api.github.com/repos/ros2/rcl/subscription","commits_url":"https://api.github.com/repos/ros2/rcl/commits{/sha}","git_commits_url":"https://api.github.com/repos/ros2/rcl/git/commits{/sha}","comments_url":"https://api.github.com/repos/ros2/rcl/comments{/number}","issue_comment_url":"https://api.github.com/repos/ros2/rcl/issues/comments{/number}","contents_url":"https://api.github.com/repos/ros2/rcl/contents/{+path}","compare_url":"https://api.github.com/repos/ros2/rcl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ros2/rcl/merges","archive_url":"https://api.github.com/repos/ros2/rcl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ros2/rcl/downloads","issues_url":"https://api.github.com/repos/ros2/rcl/issues{/number}","pulls_url":"https://api.github.com/repos/ros2/rcl/pulls{/number}","milestones_url":"https://api.github.com/repos/ros2/rcl/milestones{/number}","notifications_url":"https://api.github.com/repos/ros2/rcl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ros2/rcl/labels{/name}","releases_url":"https://api.github.com/repos/ros2/rcl/releases{/id}","deployments_url":"https://api.github.com/repos/ros2/rcl/deployments","created_at":"2015-02-21T00:06:40Z","updated_at":"2016-01-13T01:48:19Z","pushed_at":"2016-02-11T07:56:53Z","git_url":"git://github.com/ros2/rcl.git","ssh_url":"git@github.com:ros2/rcl.git","clone_url":"https://github.com/ros2/rcl.git","svn_url":"https://github.com/ros2/rcl","homepage":null,"size":242,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":4,"forks":2,"open_issues":4,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ros2/rcl/pulls/21"},"html":{"href":"https://github.com/ros2/rcl/pull/21"},"issue":{"href":"https://api.github.com/repos/ros2/rcl/issues/21"},"comments":{"href":"https://api.github.com/repos/ros2/rcl/issues/21/comments"},"review_comments":{"href":"https://api.github.com/repos/ros2/rcl/pulls/21/comments"},"review_comment":{"href":"https://api.github.com/repos/ros2/rcl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ros2/rcl/pulls/21/commits"},"statuses":{"href":"https://api.github.com/repos/ros2/rcl/statuses/fb819fbf264bf64cfa663082b4390eab077b23b6"}}}}