{"action":"created","issue":{"url":"https://api.github.com/repos/lesshint/lesshint/issues/253","repository_url":"https://api.github.com/repos/lesshint/lesshint","labels_url":"https://api.github.com/repos/lesshint/lesshint/issues/253/labels{/name}","comments_url":"https://api.github.com/repos/lesshint/lesshint/issues/253/comments","events_url":"https://api.github.com/repos/lesshint/lesshint/issues/253/events","html_url":"https://github.com/lesshint/lesshint/pull/253","id":176380918,"number":253,"title":"Ignore errors from bad symlinks","user":{"login":"runarberg","id":3984600,"avatar_url":"https://avatars.githubusercontent.com/u/3984600?v=3","gravatar_id":"","url":"https://api.github.com/users/runarberg","html_url":"https://github.com/runarberg","followers_url":"https://api.github.com/users/runarberg/followers","following_url":"https://api.github.com/users/runarberg/following{/other_user}","gists_url":"https://api.github.com/users/runarberg/gists{/gist_id}","starred_url":"https://api.github.com/users/runarberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/runarberg/subscriptions","organizations_url":"https://api.github.com/users/runarberg/orgs","repos_url":"https://api.github.com/users/runarberg/repos","events_url":"https://api.github.com/users/runarberg/events{/privacy}","received_events_url":"https://api.github.com/users/runarberg/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-09-12T13:52:58Z","updated_at":"2016-09-12T18:04:47Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/lesshint/lesshint/pulls/253","html_url":"https://github.com/lesshint/lesshint/pull/253","diff_url":"https://github.com/lesshint/lesshint/pull/253.diff","patch_url":"https://github.com/lesshint/lesshint/pull/253.patch"},"body":"Fixes #251"},"comment":{"url":"https://api.github.com/repos/lesshint/lesshint/issues/comments/246436734","html_url":"https://github.com/lesshint/lesshint/pull/253#issuecomment-246436734","issue_url":"https://api.github.com/repos/lesshint/lesshint/issues/253","id":246436734,"user":{"login":"jwilsson","id":567607,"avatar_url":"https://avatars.githubusercontent.com/u/567607?v=3","gravatar_id":"","url":"https://api.github.com/users/jwilsson","html_url":"https://github.com/jwilsson","followers_url":"https://api.github.com/users/jwilsson/followers","following_url":"https://api.github.com/users/jwilsson/following{/other_user}","gists_url":"https://api.github.com/users/jwilsson/gists{/gist_id}","starred_url":"https://api.github.com/users/jwilsson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwilsson/subscriptions","organizations_url":"https://api.github.com/users/jwilsson/orgs","repos_url":"https://api.github.com/users/jwilsson/repos","events_url":"https://api.github.com/users/jwilsson/events{/privacy}","received_events_url":"https://api.github.com/users/jwilsson/received_events","type":"User","site_admin":false},"created_at":"2016-09-12T18:04:47Z","updated_at":"2016-09-12T18:04:47Z","body":"Thanks for working on this!\r\n\r\nI'm not sure if just blindly ignoring all symlinks is the way to go. I see three possible solutions.\r\n\r\n1. I did some quick testing and while a `vow-fs.exists()` method exists, it doesn't follow symlinks but just checks whether the thing passed to it exists. However, the core `fs.access()` method does follow symlinks and will allow us to check if regular files exist too. Unfortunately, `vow-fs` doesn't expose `access` but we can always check if that's something that could be added to that library. If not, it's easy to add that check ourselves using the core `fs` module.\r\n\r\n2. We add a option via `.lesshintrc` called `ignoreSymlinks` (or similar of course) which defaults to `false` for backward compatibility reasons. Meaning it won't ignore symlinks by default.\r\n\r\n3. We simply ignore all symlinks."}}
{"actor":{"display_login":"jwilsson"}}