{"action":"closed","number":35,"pull_request":{"url":"https://api.github.com/repos/jenkins-pipeline/jenkins-pipeline/pulls/35","id":58383793,"html_url":"https://github.com/jenkins-pipeline/jenkins-pipeline/pull/35","diff_url":"https://github.com/jenkins-pipeline/jenkins-pipeline/pull/35.diff","patch_url":"https://github.com/jenkins-pipeline/jenkins-pipeline/pull/35.patch","issue_url":"https://api.github.com/repos/jenkins-pipeline/jenkins-pipeline/issues/35","number":35,"state":"closed","locked":false,"title":"Fetch pipelines async","user":{"login":"junior-ales","id":868481,"avatar_url":"https://avatars.githubusercontent.com/u/868481?v=3","gravatar_id":"","url":"https://api.github.com/users/junior-ales","html_url":"https://github.com/junior-ales","followers_url":"https://api.github.com/users/junior-ales/followers","following_url":"https://api.github.com/users/junior-ales/following{/other_user}","gists_url":"https://api.github.com/users/junior-ales/gists{/gist_id}","starred_url":"https://api.github.com/users/junior-ales/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/junior-ales/subscriptions","organizations_url":"https://api.github.com/users/junior-ales/orgs","repos_url":"https://api.github.com/users/junior-ales/repos","events_url":"https://api.github.com/users/junior-ales/events{/privacy}","received_events_url":"https://api.github.com/users/junior-ales/received_events","type":"User","site_admin":false},"body":"Adding the feature to fetch all pipelines asynchronously. Some caveats:\r\n\r\n* I added a feature toggle so it doesn't break the current implementation and it's made by a query parameter in the URL. For example, a request to `http://localhost:4567` will fetch the pipelines synchronously, as it was before. A request to `http://localhost:4567/?env=dev` will fetch the pipelines asynchronously.\r\n\r\n* If you only tried the step above and it didn't work it's OK, you should read the entire instructions.\r\n\r\n*  In order to see it working you need to edit your yml files in the config directory. More precisely the property `url` of each file and they need to match the **hardcoded** values of the function `pipelineNames` in the `client/app/views/index.js`. In my case I have three yml files and I added the values _'Digital Service'_ in one, _'Transversal Service'_ in another and _'Web Application'_ in the last one.\r\n\r\n* Once the yml files are edited remember to make the request with the query parameter as explained above.\r\n\r\nI think it's very clear that this is not optimal but the good news is that it's temporary. As soon as the #31 is done, the function `pipelineNames` can be replaced by a call to the end point listing available pipelines thus we can remove the feature toggle in the `index.js` file and point the `init` function to `fetchPipelinesAsync`.","created_at":"2016-02-05T03:18:46Z","updated_at":"2016-02-05T12:05:13Z","closed_at":"2016-02-05T12:05:13Z","merged_at":"2016-02-05T12:05:13Z","merge_commit_sha":"408dea77989169b47d87a1fa3ac5a964f6566618","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jenkins-pipeline/jenkins-pipeline/pulls/35/commits","review_comments_url":"https://api.github.com/repos/jenkins-pipeline/jenkins-pipeline/pulls/35/comments","review_comment_url":"https://api.github.com/repos/jenkins-pipeline/jenkins-pipeline/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jenkins-pipeline/jenkins-pipeline/issues/35/comments","statuses_url":"https://api.github.com/repos/jenkins-pipeline/jenkins-pipeline/statuses/7160d3dceecce99528045911376b94c7d30ef809","head":{"label":"junior-ales:fetch-pipelines-async","ref":"fetch-pipelines-async","sha":"7160d3dceecce99528045911376b94c7d30ef809","user":{"login":"junior-ales","id":868481,"avatar_url":"https://avatars.githubusercontent.com/u/868481?v=3","gravatar_id":"","url":"https://api.github.com/users/junior-ales","html_url":"https://github.com/junior-ales","followers_url":"https://api.github.com/users/junior-ales/followers","following_url":"https://api.github.com/users/junior-ales/following{/other_user}","gists_url":"https://api.github.com/users/junior-ales/gists{/gist_id}","starred_url":"https://api.github.com/users/junior-ales/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/junior-ales/subscriptions","organizations_url":"https://api.github.com/users/junior-ales/orgs","repos_url":"https://api.github.com/users/junior-ales/repos","events_url":"https://api.github.com/users/junior-ales/events{/privacy}","received_events_url":"https://api.github.com/users/junior-ales/received_events","type":"User","site_admin":false},"repo":{"id":50043984,"name":"jenkins-pipeline","full_name":"junior-ales/jenkins-pipeline","owner":{"login":"junior-ales","id":868481,"avatar_url":"https://avatars.githubusercontent.com/u/868481?v=3","gravatar_id":"","url":"https://api.github.com/users/junior-ales","html_url":"https://github.com/junior-ales","followers_url":"https://api.github.com/users/junior-ales/followers","following_url":"https://api.github.com/users/junior-ales/following{/other_user}","gists_url":"https://api.github.com/users/junior-ales/gists{/gist_id}","starred_url":"https://api.github.com/users/junior-ales/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/junior-ales/subscriptions","organizations_url":"https://api.github.com/users/junior-ales/orgs","repos_url":"https://api.github.com/users/junior-ales/repos","events_url":"https://api.github.com/users/junior-ales/events{/privacy}","received_events_url":"https://api.github.com/users/junior-ales/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/junior-ales/jenkins-pipeline","description":"A web app that provides a pipeline view to jenkins","fork":true,"url":"https://api.github.com/repos/junior-ales/jenkins-pipeline","forks_url":"https://api.github.com/repos/junior-ales/jenkins-pipeline/forks","keys_url":"https://api.github.com/repos/junior-ales/jenkins-pipeline/keys{/key_id}","collaborators_url":"https://api.github.com/repos/junior-ales/jenkins-pipeline/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/junior-ales/jenkins-pipeline/teams","hooks_url":"https://api.github.com/repos/junior-ales/jenkins-pipeline/hooks","issue_events_url":"https://api.github.com/repos/junior-ales/jenkins-pipeline/issues/events{/number}","events_url":"https://api.github.com/repos/junior-ales/jenkins-pipeline/events","assignees_url":"https://api.github.com/repos/junior-ales/jenkins-pipeline/assignees{/user}","branches_url":"https://api.github.com/repos/junior-ales/jenkins-pipeline/branches{/branch}","tags_url":"https://api.github.com/repos/junior-ales/jenkins-pipeline/tags","blobs_url":"https://api.github.com/repos/junior-ales/jenkins-pipeline/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/junior-ales/jenkins-pipeline/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/junior-ales/jenkins-pipeline/git/refs{/sha}","trees_url":"https://api.github.com/repos/junior-ales/jenkins-pipeline/git/trees{/sha}","statuses_url":"https://api.github.com/repos/junior-ales/jenkins-pipeline/statuses/{sha}","languages_url":"https://api.github.com/repos/junior-ales/jenkins-pipeline/languages","stargazers_url":"https://api.github.com/repos/junior-ales/jenkins-pipeline/stargazers","contributors_url":"https://api.github.com/repos/junior-ales/jenkins-pipeline/contributors","subscribers_url":"https://api.github.com/repos/junior-ales/jenkins-pipeline/subscribers","subscription_url":"https://api.github.com/repos/junior-ales/jenkins-pipeline/subscription","commits_url":"https://api.github.com/repos/junior-ales/jenkins-pipeline/commits{/sha}","git_commits_url":"https://api.github.com/repos/junior-ales/jenkins-pipeline/git/commits{/sha}","comments_url":"https://api.github.com/repos/junior-ales/jenkins-pipeline/comments{/number}","issue_comment_url":"https://api.github.com/repos/junior-ales/jenkins-pipeline/issues/comments{/number}","contents_url":"https://api.github.com/repos/junior-ales/jenkins-pipeline/contents/{+path}","compare_url":"https://api.github.com/repos/junior-ales/jenkins-pipeline/compare/{base}...{head}","merges_url":"https://api.github.com/repos/junior-ales/jenkins-pipeline/merges","archive_url":"https://api.github.com/repos/junior-ales/jenkins-pipeline/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/junior-ales/jenkins-pipeline/downloads","issues_url":"https://api.github.com/repos/junior-ales/jenkins-pipeline/issues{/number}","pulls_url":"https://api.github.com/repos/junior-ales/jenkins-pipeline/pulls{/number}","milestones_url":"https://api.github.com/repos/junior-ales/jenkins-pipeline/milestones{/number}","notifications_url":"https://api.github.com/repos/junior-ales/jenkins-pipeline/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/junior-ales/jenkins-pipeline/labels{/name}","releases_url":"https://api.github.com/repos/junior-ales/jenkins-pipeline/releases{/id}","deployments_url":"https://api.github.com/repos/junior-ales/jenkins-pipeline/deployments","created_at":"2016-01-20T16:40:50Z","updated_at":"2016-02-04T14:10:48Z","pushed_at":"2016-02-05T02:58:12Z","git_url":"git://github.com/junior-ales/jenkins-pipeline.git","ssh_url":"git@github.com:junior-ales/jenkins-pipeline.git","clone_url":"https://github.com/junior-ales/jenkins-pipeline.git","svn_url":"https://github.com/junior-ales/jenkins-pipeline","homepage":"","size":1963,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jenkins-pipeline:master","ref":"master","sha":"2160372cefc1a0f11e43bd43f466a17b2a9b57d7","user":{"login":"jenkins-pipeline","id":16955706,"avatar_url":"https://avatars.githubusercontent.com/u/16955706?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkins-pipeline","html_url":"https://github.com/jenkins-pipeline","followers_url":"https://api.github.com/users/jenkins-pipeline/followers","following_url":"https://api.github.com/users/jenkins-pipeline/following{/other_user}","gists_url":"https://api.github.com/users/jenkins-pipeline/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkins-pipeline/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkins-pipeline/subscriptions","organizations_url":"https://api.github.com/users/jenkins-pipeline/orgs","repos_url":"https://api.github.com/users/jenkins-pipeline/repos","events_url":"https://api.github.com/users/jenkins-pipeline/events{/privacy}","received_events_url":"https://api.github.com/users/jenkins-pipeline/received_events","type":"Organization","site_admin":false},"repo":{"id":49158568,"name":"jenkins-pipeline","full_name":"jenkins-pipeline/jenkins-pipeline","owner":{"login":"jenkins-pipeline","id":16955706,"avatar_url":"https://avatars.githubusercontent.com/u/16955706?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkins-pipeline","html_url":"https://github.com/jenkins-pipeline","followers_url":"https://api.github.com/users/jenkins-pipeline/followers","following_url":"https://api.github.com/users/jenkins-pipeline/following{/other_user}","gists_url":"https://api.github.com/users/jenkins-pipeline/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkins-pipeline/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkins-pipeline/subscriptions","organizations_url":"https://api.github.com/users/jenkins-pipeline/orgs","repos_url":"https://api.github.com/users/jenkins-pipeline/repos","events_url":"https://api.github.com/users/jenkins-pipeline/events{/privacy}","received_events_url":"https://api.github.com/users/jenkins-pipeline/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jenkins-pipeline/jenkins-pipeline","description":"A web app that provides a pipeline view to jenkins","fork":false,"url":"https://api.github.com/repos/jenkins-pipeline/jenkins-pipeline","forks_url":"https://api.github.com/repos/jenkins-pipeline/jenkins-pipeline/forks","keys_url":"https://api.github.com/repos/jenkins-pipeline/jenkins-pipeline/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jenkins-pipeline/jenkins-pipeline/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jenkins-pipeline/jenkins-pipeline/teams","hooks_url":"https://api.github.com/repos/jenkins-pipeline/jenkins-pipeline/hooks","issue_events_url":"https://api.github.com/repos/jenkins-pipeline/jenkins-pipeline/issues/events{/number}","events_url":"https://api.github.com/repos/jenkins-pipeline/jenkins-pipeline/events","assignees_url":"https://api.github.com/repos/jenkins-pipeline/jenkins-pipeline/assignees{/user}","branches_url":"https://api.github.com/repos/jenkins-pipeline/jenkins-pipeline/branches{/branch}","tags_url":"https://api.github.com/repos/jenkins-pipeline/jenkins-pipeline/tags","blobs_url":"https://api.github.com/repos/jenkins-pipeline/jenkins-pipeline/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jenkins-pipeline/jenkins-pipeline/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jenkins-pipeline/jenkins-pipeline/git/refs{/sha}","trees_url":"https://api.github.com/repos/jenkins-pipeline/jenkins-pipeline/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jenkins-pipeline/jenkins-pipeline/statuses/{sha}","languages_url":"https://api.github.com/repos/jenkins-pipeline/jenkins-pipeline/languages","stargazers_url":"https://api.github.com/repos/jenkins-pipeline/jenkins-pipeline/stargazers","contributors_url":"https://api.github.com/repos/jenkins-pipeline/jenkins-pipeline/contributors","subscribers_url":"https://api.github.com/repos/jenkins-pipeline/jenkins-pipeline/subscribers","subscription_url":"https://api.github.com/repos/jenkins-pipeline/jenkins-pipeline/subscription","commits_url":"https://api.github.com/repos/jenkins-pipeline/jenkins-pipeline/commits{/sha}","git_commits_url":"https://api.github.com/repos/jenkins-pipeline/jenkins-pipeline/git/commits{/sha}","comments_url":"https://api.github.com/repos/jenkins-pipeline/jenkins-pipeline/comments{/number}","issue_comment_url":"https://api.github.com/repos/jenkins-pipeline/jenkins-pipeline/issues/comments{/number}","contents_url":"https://api.github.com/repos/jenkins-pipeline/jenkins-pipeline/contents/{+path}","compare_url":"https://api.github.com/repos/jenkins-pipeline/jenkins-pipeline/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jenkins-pipeline/jenkins-pipeline/merges","archive_url":"https://api.github.com/repos/jenkins-pipeline/jenkins-pipeline/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jenkins-pipeline/jenkins-pipeline/downloads","issues_url":"https://api.github.com/repos/jenkins-pipeline/jenkins-pipeline/issues{/number}","pulls_url":"https://api.github.com/repos/jenkins-pipeline/jenkins-pipeline/pulls{/number}","milestones_url":"https://api.github.com/repos/jenkins-pipeline/jenkins-pipeline/milestones{/number}","notifications_url":"https://api.github.com/repos/jenkins-pipeline/jenkins-pipeline/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jenkins-pipeline/jenkins-pipeline/labels{/name}","releases_url":"https://api.github.com/repos/jenkins-pipeline/jenkins-pipeline/releases{/id}","deployments_url":"https://api.github.com/repos/jenkins-pipeline/jenkins-pipeline/deployments","created_at":"2016-01-06T20:05:49Z","updated_at":"2016-02-05T06:24:43Z","pushed_at":"2016-02-05T12:05:13Z","git_url":"git://github.com/jenkins-pipeline/jenkins-pipeline.git","ssh_url":"git@github.com:jenkins-pipeline/jenkins-pipeline.git","clone_url":"https://github.com/jenkins-pipeline/jenkins-pipeline.git","svn_url":"https://github.com/jenkins-pipeline/jenkins-pipeline","homepage":"","size":1960,"stargazers_count":8,"watchers_count":8,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":7,"forks":6,"open_issues":7,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jenkins-pipeline/jenkins-pipeline/pulls/35"},"html":{"href":"https://github.com/jenkins-pipeline/jenkins-pipeline/pull/35"},"issue":{"href":"https://api.github.com/repos/jenkins-pipeline/jenkins-pipeline/issues/35"},"comments":{"href":"https://api.github.com/repos/jenkins-pipeline/jenkins-pipeline/issues/35/comments"},"review_comments":{"href":"https://api.github.com/repos/jenkins-pipeline/jenkins-pipeline/pulls/35/comments"},"review_comment":{"href":"https://api.github.com/repos/jenkins-pipeline/jenkins-pipeline/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jenkins-pipeline/jenkins-pipeline/pulls/35/commits"},"statuses":{"href":"https://api.github.com/repos/jenkins-pipeline/jenkins-pipeline/statuses/7160d3dceecce99528045911376b94c7d30ef809"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"thiagoxvo","id":37016,"avatar_url":"https://avatars.githubusercontent.com/u/37016?v=3","gravatar_id":"","url":"https://api.github.com/users/thiagoxvo","html_url":"https://github.com/thiagoxvo","followers_url":"https://api.github.com/users/thiagoxvo/followers","following_url":"https://api.github.com/users/thiagoxvo/following{/other_user}","gists_url":"https://api.github.com/users/thiagoxvo/gists{/gist_id}","starred_url":"https://api.github.com/users/thiagoxvo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thiagoxvo/subscriptions","organizations_url":"https://api.github.com/users/thiagoxvo/orgs","repos_url":"https://api.github.com/users/thiagoxvo/repos","events_url":"https://api.github.com/users/thiagoxvo/events{/privacy}","received_events_url":"https://api.github.com/users/thiagoxvo/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":3,"additions":99,"deletions":23,"changed_files":5}}