{"action":"created","issue":{"url":"https://api.github.com/repos/thunderer/Shortcode/issues/35","repository_url":"https://api.github.com/repos/thunderer/Shortcode","labels_url":"https://api.github.com/repos/thunderer/Shortcode/issues/35/labels{/name}","comments_url":"https://api.github.com/repos/thunderer/Shortcode/issues/35/comments","events_url":"https://api.github.com/repos/thunderer/Shortcode/issues/35/events","html_url":"https://github.com/thunderer/Shortcode/issues/35","id":131277150,"number":35,"title":"Underscores in tag names not matched","user":{"login":"rossriley","id":5082,"avatar_url":"https://avatars.githubusercontent.com/u/5082?v=3","gravatar_id":"","url":"https://api.github.com/users/rossriley","html_url":"https://github.com/rossriley","followers_url":"https://api.github.com/users/rossriley/followers","following_url":"https://api.github.com/users/rossriley/following{/other_user}","gists_url":"https://api.github.com/users/rossriley/gists{/gist_id}","starred_url":"https://api.github.com/users/rossriley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rossriley/subscriptions","organizations_url":"https://api.github.com/users/rossriley/orgs","repos_url":"https://api.github.com/users/rossriley/repos","events_url":"https://api.github.com/users/rossriley/events{/privacy}","received_events_url":"https://api.github.com/users/rossriley/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2016-02-04T08:28:18Z","updated_at":"2016-02-04T08:55:29Z","closed_at":null,"body":"Wasn't sure if this was a deliberate decision but in parsing tags containing underscores aren't matched.\r\n\r\neg: `[testtag]` works but `[test_tag]` does not.\r\n\r\nBoth the regular parser here:\r\nhttps://github.com/thunderer/Shortcode/blob/master/src/Parser/RegularParser.php#L81\r\nand the Wordpress parser here:\r\nhttps://github.com/thunderer/Shortcode/blob/master/src/Parser/WordpressParser.php#L27\r\n\r\nuse a slightly different match syntax but neither contain the `_` character. \r\n\r\nReason I ask is because I'm trying to use this library to make a content importer from Wordpress and Wordpress does seem to parse them correctly.\r\n"},"comment":{"url":"https://api.github.com/repos/thunderer/Shortcode/issues/comments/179714565","html_url":"https://github.com/thunderer/Shortcode/issues/35#issuecomment-179714565","issue_url":"https://api.github.com/repos/thunderer/Shortcode/issues/35","id":179714565,"user":{"login":"thunderer","id":1087180,"avatar_url":"https://avatars.githubusercontent.com/u/1087180?v=3","gravatar_id":"","url":"https://api.github.com/users/thunderer","html_url":"https://github.com/thunderer","followers_url":"https://api.github.com/users/thunderer/followers","following_url":"https://api.github.com/users/thunderer/following{/other_user}","gists_url":"https://api.github.com/users/thunderer/gists{/gist_id}","starred_url":"https://api.github.com/users/thunderer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thunderer/subscriptions","organizations_url":"https://api.github.com/users/thunderer/orgs","repos_url":"https://api.github.com/users/thunderer/repos","events_url":"https://api.github.com/users/thunderer/events{/privacy}","received_events_url":"https://api.github.com/users/thunderer/received_events","type":"User","site_admin":false},"created_at":"2016-02-04T08:55:29Z","updated_at":"2016-02-04T08:55:29Z","body":"Hi, I recently fixed inconsistent behavior between `RegexParser` and `RegularParser` and removed support for underscores `_` in shortcode names. Those changes were introduced in https://github.com/thunderer/Shortcode/commit/a22cd63eb8b9642465b87c0df386e57131c73114 and https://github.com/thunderer/Shortcode/commit/3a8d53780dc4c2cd823ba0c7c25f1131045337d8 . I'm curious about `WordpressParser` because it contains verbatim copy of WordPress' code that is exactly meant to work like in WordPress. There is [a test](https://github.com/thunderer/Shortcode/blob/master/tests/ParserTest.php#L185) that happily passes on all parsers and catches no shortcode. Does your WordPress parse those shortcodes with underscores? Can you show me the sample input and the desired output?"}}