{"action":"created","issue":{"url":"https://api.github.com/repos/triplea-game/triplea/issues/766","repository_url":"https://api.github.com/repos/triplea-game/triplea","labels_url":"https://api.github.com/repos/triplea-game/triplea/issues/766/labels{/name}","comments_url":"https://api.github.com/repos/triplea-game/triplea/issues/766/comments","events_url":"https://api.github.com/repos/triplea-game/triplea/issues/766/events","html_url":"https://github.com/triplea-game/triplea/pull/766","id":157962010,"number":766,"title":" Deprecation Clean-up","user":{"login":"RoiEXLab","id":8350879,"avatar_url":"https://avatars.githubusercontent.com/u/8350879?v=3","gravatar_id":"","url":"https://api.github.com/users/RoiEXLab","html_url":"https://github.com/RoiEXLab","followers_url":"https://api.github.com/users/RoiEXLab/followers","following_url":"https://api.github.com/users/RoiEXLab/following{/other_user}","gists_url":"https://api.github.com/users/RoiEXLab/gists{/gist_id}","starred_url":"https://api.github.com/users/RoiEXLab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RoiEXLab/subscriptions","organizations_url":"https://api.github.com/users/RoiEXLab/orgs","repos_url":"https://api.github.com/users/RoiEXLab/repos","events_url":"https://api.github.com/users/RoiEXLab/events{/privacy}","received_events_url":"https://api.github.com/users/RoiEXLab/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-06-01T17:22:32Z","updated_at":"2016-06-02T01:03:08Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/triplea-game/triplea/pulls/766","html_url":"https://github.com/triplea-game/triplea/pull/766","diff_url":"https://github.com/triplea-game/triplea/pull/766.diff","patch_url":"https://github.com/triplea-game/triplea/pull/766.patch"},"body":"1. I removed Suppressed deprecation annontations\r\n2. \"Deprecated correctly\" (as described in the wiki - I added that entry)on some of those \"still in use deprecated methods\r\n3. Removed unused imports\r\n4. Remove one unused local variable\r\n5. removed unused or \"uneccesary\"(those method which have a replacement) deprecated methods / classes\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"35\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/triplea-game/triplea/766)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/triplea-game/triplea/issues/comments/223169107","html_url":"https://github.com/triplea-game/triplea/pull/766#issuecomment-223169107","issue_url":"https://api.github.com/repos/triplea-game/triplea/issues/766","id":223169107,"user":{"login":"DanVanAtta","id":12397753,"avatar_url":"https://avatars.githubusercontent.com/u/12397753?v=3","gravatar_id":"","url":"https://api.github.com/users/DanVanAtta","html_url":"https://github.com/DanVanAtta","followers_url":"https://api.github.com/users/DanVanAtta/followers","following_url":"https://api.github.com/users/DanVanAtta/following{/other_user}","gists_url":"https://api.github.com/users/DanVanAtta/gists{/gist_id}","starred_url":"https://api.github.com/users/DanVanAtta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanVanAtta/subscriptions","organizations_url":"https://api.github.com/users/DanVanAtta/orgs","repos_url":"https://api.github.com/users/DanVanAtta/repos","events_url":"https://api.github.com/users/DanVanAtta/events{/privacy}","received_events_url":"https://api.github.com/users/DanVanAtta/received_events","type":"User","site_admin":false},"created_at":"2016-06-02T01:03:08Z","updated_at":"2016-06-02T01:03:08Z","body":"Looks close:\r\n- fix GMT string print out\r\n- verify this works with a reasonable number of maps, and/or search the maps for things that were removed and may have been used from the XML>\r\n\r\nPerhaps one of the biggest problems in the TripleA code base is there are two or three cases where things are not compile time checked:\r\n- serialization, either from loading save games and/or from network communication\r\n- reflection, used in a couple of ways, but also used to invoke game functions from the map XMLs\r\n\r\nSo - a map breaking when you remove a function means that the function *is* used, and it should not be removed. It would be great to get all of those things to be compile-time checked, so we would always know what we can change safely. So if you spot any such methods, please comment on them that they are used from a map xml. #766 to further discussing that topic."}}
{"actor":{"display_login":"DanVanAtta"}}