{"action":"created","issue":{"url":"https://api.github.com/repos/influxdata/telegraf/issues/1970","repository_url":"https://api.github.com/repos/influxdata/telegraf","labels_url":"https://api.github.com/repos/influxdata/telegraf/issues/1970/labels{/name}","comments_url":"https://api.github.com/repos/influxdata/telegraf/issues/1970/comments","events_url":"https://api.github.com/repos/influxdata/telegraf/issues/1970/events","html_url":"https://github.com/influxdata/telegraf/pull/1970","id":186032929,"number":1970,"title":"ES Add basic authentication (Shield) + make it compatible with older ES versions","user":{"login":"somnair","id":22946073,"avatar_url":"https://avatars.githubusercontent.com/u/22946073?v=3","gravatar_id":"","url":"https://api.github.com/users/somnair","html_url":"https://github.com/somnair","followers_url":"https://api.github.com/users/somnair/followers","following_url":"https://api.github.com/users/somnair/following{/other_user}","gists_url":"https://api.github.com/users/somnair/gists{/gist_id}","starred_url":"https://api.github.com/users/somnair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/somnair/subscriptions","organizations_url":"https://api.github.com/users/somnair/orgs","repos_url":"https://api.github.com/users/somnair/repos","events_url":"https://api.github.com/users/somnair/events{/privacy}","received_events_url":"https://api.github.com/users/somnair/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-10-28T22:07:39Z","updated_at":"2016-11-02T11:32:54Z","closed_at":"2016-11-02T11:32:54Z","pull_request":{"url":"https://api.github.com/repos/influxdata/telegraf/pulls/1970","html_url":"https://github.com/influxdata/telegraf/pull/1970","diff_url":"https://github.com/influxdata/telegraf/pull/1970.diff","patch_url":"https://github.com/influxdata/telegraf/pull/1970.patch"},"body":"### Required for all PRs:\n- [ ] CHANGELOG.md updated (we recommend not updating this until the PR has been approved by a maintainer)\n- [ ] Sign [CLA](https://influxdata.com/community/cla/) (if not already signed)\n- [ ] README.md updated (if adding a new plugin)\n\nWhy\n1. With ES 0.19.9 nodeStats doesn't return all the data\n2. The plugin doesn't work with authentication set up for ES with Shield\n\nHow\n1. gatherNodeStats()\n     Include input parameter stats\n    - stats = [\"indices\", \"os\", \"process\", \"jvm\", \"thread_pool\",\"fs\",\"transport\",\"http\",\"breakers\"]\n    - https://www.elastic.co/guide/en/elasticsearch/reference/current/cluster-nodes-stats.html\n     Reasons for the refactor\n         - The syntax for printing out the the default option of all varies between versions\n         - ES 0.19.9 requires all=true whereas later versions don't need that option to  print  defaults \n        - Gives flexibility to output fewer metrics\n        - Added a switch statement in routine gatherNodeStats to construct url dynamically based on the input parameter stats from the config file\n2. gatherData()\n    Changes in routine gatherData to setup BasicAuth with the username passowrd from the config \n3. Gather()\n     This ensure higher level metrics are not interrupted if any of the nodelevel stats error out\n"},"comment":{"url":"https://api.github.com/repos/influxdata/telegraf/issues/comments/257840027","html_url":"https://github.com/influxdata/telegraf/pull/1970#issuecomment-257840027","issue_url":"https://api.github.com/repos/influxdata/telegraf/issues/1970","id":257840027,"user":{"login":"sparrc","id":7155926,"avatar_url":"https://avatars.githubusercontent.com/u/7155926?v=3","gravatar_id":"","url":"https://api.github.com/users/sparrc","html_url":"https://github.com/sparrc","followers_url":"https://api.github.com/users/sparrc/followers","following_url":"https://api.github.com/users/sparrc/following{/other_user}","gists_url":"https://api.github.com/users/sparrc/gists{/gist_id}","starred_url":"https://api.github.com/users/sparrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sparrc/subscriptions","organizations_url":"https://api.github.com/users/sparrc/orgs","repos_url":"https://api.github.com/users/sparrc/repos","events_url":"https://api.github.com/users/sparrc/events{/privacy}","received_events_url":"https://api.github.com/users/sparrc/received_events","type":"User","site_admin":false},"created_at":"2016-11-02T11:32:53Z","updated_at":"2016-11-02T11:32:53Z","body":"please split this out into two separate PRs, first being the Shield auth support.\r\n\r\nFor the other part of the change, I'm not sure if we want to support very old versions of ES. Can you explain why you are using 0.19 and why we should support it?"}}
{"actor":{"display_login":"sparrc"}}