{"action":"created","issue":{"url":"https://api.github.com/repos/SCOREC/core/issues/46","repository_url":"https://api.github.com/repos/SCOREC/core","labels_url":"https://api.github.com/repos/SCOREC/core/issues/46/labels{/name}","comments_url":"https://api.github.com/repos/SCOREC/core/issues/46/comments","events_url":"https://api.github.com/repos/SCOREC/core/issues/46/events","html_url":"https://github.com/SCOREC/core/issues/46","id":181903609,"number":46,"title":"Use bob.cmake to set some default cxx flags","user":{"login":"bgranzow","id":5702945,"avatar_url":"https://avatars.githubusercontent.com/u/5702945?v=3","gravatar_id":"","url":"https://api.github.com/users/bgranzow","html_url":"https://github.com/bgranzow","followers_url":"https://api.github.com/users/bgranzow/followers","following_url":"https://api.github.com/users/bgranzow/following{/other_user}","gists_url":"https://api.github.com/users/bgranzow/gists{/gist_id}","starred_url":"https://api.github.com/users/bgranzow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgranzow/subscriptions","organizations_url":"https://api.github.com/users/bgranzow/orgs","repos_url":"https://api.github.com/users/bgranzow/repos","events_url":"https://api.github.com/users/bgranzow/events{/privacy}","received_events_url":"https://api.github.com/users/bgranzow/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"bgranzow","id":5702945,"avatar_url":"https://avatars.githubusercontent.com/u/5702945?v=3","gravatar_id":"","url":"https://api.github.com/users/bgranzow","html_url":"https://github.com/bgranzow","followers_url":"https://api.github.com/users/bgranzow/followers","following_url":"https://api.github.com/users/bgranzow/following{/other_user}","gists_url":"https://api.github.com/users/bgranzow/gists{/gist_id}","starred_url":"https://api.github.com/users/bgranzow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgranzow/subscriptions","organizations_url":"https://api.github.com/users/bgranzow/orgs","repos_url":"https://api.github.com/users/bgranzow/repos","events_url":"https://api.github.com/users/bgranzow/events{/privacy}","received_events_url":"https://api.github.com/users/bgranzow/received_events","type":"User","site_admin":false},"assignees":[{"login":"bgranzow","id":5702945,"avatar_url":"https://avatars.githubusercontent.com/u/5702945?v=3","gravatar_id":"","url":"https://api.github.com/users/bgranzow","html_url":"https://github.com/bgranzow","followers_url":"https://api.github.com/users/bgranzow/followers","following_url":"https://api.github.com/users/bgranzow/following{/other_user}","gists_url":"https://api.github.com/users/bgranzow/gists{/gist_id}","starred_url":"https://api.github.com/users/bgranzow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgranzow/subscriptions","organizations_url":"https://api.github.com/users/bgranzow/orgs","repos_url":"https://api.github.com/users/bgranzow/repos","events_url":"https://api.github.com/users/bgranzow/events{/privacy}","received_events_url":"https://api.github.com/users/bgranzow/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2016-10-09T18:49:26Z","updated_at":"2016-10-09T19:09:58Z","closed_at":null,"body":"Seems like it would prevent some manual intervention after commits if all developers used the compile flags,  `-Wall -Wextra -Werror` at a minimum. This could easily be accomplished by setting the commands\r\n\r\n```\r\nbob_begin_cxx_flags()\r\nbob_end_cxx_flags()\r\n```\r\n\r\nsomewhere in the top-level CMakeLists.txt. The default flags for Clang compilers in the `bob.cmake` package are a bit too strict, though, and it would take a lot of unneeded effort to get SCOREC/core to compile under those flags. I propose switching the Clang compile flags to `-Wall -Wextra -Werror` locally in cmake/bob.cmake, as well.\r\n\r\nAny objections? If not, I'll push this change to develop."},"comment":{"url":"https://api.github.com/repos/SCOREC/core/issues/comments/252505828","html_url":"https://github.com/SCOREC/core/issues/46#issuecomment-252505828","issue_url":"https://api.github.com/repos/SCOREC/core/issues/46","id":252505828,"user":{"login":"ibaned","id":971921,"avatar_url":"https://avatars.githubusercontent.com/u/971921?v=3","gravatar_id":"","url":"https://api.github.com/users/ibaned","html_url":"https://github.com/ibaned","followers_url":"https://api.github.com/users/ibaned/followers","following_url":"https://api.github.com/users/ibaned/following{/other_user}","gists_url":"https://api.github.com/users/ibaned/gists{/gist_id}","starred_url":"https://api.github.com/users/ibaned/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibaned/subscriptions","organizations_url":"https://api.github.com/users/ibaned/orgs","repos_url":"https://api.github.com/users/ibaned/repos","events_url":"https://api.github.com/users/ibaned/events{/privacy}","received_events_url":"https://api.github.com/users/ibaned/received_events","type":"User","site_admin":false},"created_at":"2016-10-09T19:09:58Z","updated_at":"2016-10-09T19:09:58Z","body":"You'll also want to document that setting CMAKE_CXX_FLAGS in config now does nothing, and people need to specify SCOREC_[EXTRA_]CXX_FLAGS to get something in there. I think this is the place to document it:\r\nhttps://github.com/SCOREC/core/wiki/General-Build-instructions"}}
{"actor":{"display_login":"ibaned"}}