{"action":"created","comment":{"url":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/pulls/comments/61518017","id":61518017,"diff_hunk":"@@ -119,6 +119,9 @@ class LogStash::Filters::GeoIP < LogStash::Filters::Base\n   # to having multiple caches for different instances at different points in the pipeline, that would just increase the\n   # number of cache misses and waste memory.\n   config :lru_cache_size, :validate => :number, :default => 1000\n+  \n+  # Tags the event on failure to look up geo information. This can be used in later analysis.\n+  config :tag_on_failure, :validate => :array, :default => [\"_geoip_lookup_failure\"]","path":"lib/logstash/filters/geoip.rb","position":6,"original_position":6,"commit_id":"c8f689d6b83893e339e3c5c5e7d09cba4c24e4b9","original_commit_id":"c8f689d6b83893e339e3c5c5e7d09cba4c24e4b9","user":{"login":"talevy","id":388837,"avatar_url":"https://avatars.githubusercontent.com/u/388837?v=3","gravatar_id":"","url":"https://api.github.com/users/talevy","html_url":"https://github.com/talevy","followers_url":"https://api.github.com/users/talevy/followers","following_url":"https://api.github.com/users/talevy/following{/other_user}","gists_url":"https://api.github.com/users/talevy/gists{/gist_id}","starred_url":"https://api.github.com/users/talevy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/talevy/subscriptions","organizations_url":"https://api.github.com/users/talevy/orgs","repos_url":"https://api.github.com/users/talevy/repos","events_url":"https://api.github.com/users/talevy/events{/privacy}","received_events_url":"https://api.github.com/users/talevy/received_events","type":"User","site_admin":false},"body":"maybe this should be a boolean?","created_at":"2016-04-28T23:22:32Z","updated_at":"2016-04-28T23:22:32Z","html_url":"https://github.com/logstash-plugins/logstash-filter-geoip/pull/73#discussion_r61518017","pull_request_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/pulls/73","_links":{"self":{"href":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/pulls/comments/61518017"},"html":{"href":"https://github.com/logstash-plugins/logstash-filter-geoip/pull/73#discussion_r61518017"},"pull_request":{"href":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/pulls/73"}}},"pull_request":{"url":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/pulls/73","id":68305022,"html_url":"https://github.com/logstash-plugins/logstash-filter-geoip/pull/73","diff_url":"https://github.com/logstash-plugins/logstash-filter-geoip/pull/73.diff","patch_url":"https://github.com/logstash-plugins/logstash-filter-geoip/pull/73.patch","issue_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/issues/73","number":73,"state":"open","locked":false,"title":"Use empty result when location is nil","user":{"login":"suyograo","id":1595958,"avatar_url":"https://avatars.githubusercontent.com/u/1595958?v=3","gravatar_id":"","url":"https://api.github.com/users/suyograo","html_url":"https://github.com/suyograo","followers_url":"https://api.github.com/users/suyograo/followers","following_url":"https://api.github.com/users/suyograo/following{/other_user}","gists_url":"https://api.github.com/users/suyograo/gists{/gist_id}","starred_url":"https://api.github.com/users/suyograo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/suyograo/subscriptions","organizations_url":"https://api.github.com/users/suyograo/orgs","repos_url":"https://api.github.com/users/suyograo/repos","events_url":"https://api.github.com/users/suyograo/events{/privacy}","received_events_url":"https://api.github.com/users/suyograo/received_events","type":"User","site_admin":false},"body":"For some IPs location and most fields are nil. Its better to return empty geoip than Elasticsearch barfing with mapping errors.\r\n\r\nAlso added tests for IPv6 now that GeoIP2 supports it\r\nFixes #70","created_at":"2016-04-28T23:11:27Z","updated_at":"2016-04-28T23:22:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e08136d126fed18bca5b53e1ae9c83ef44da3194","assignee":{"login":"talevy","id":388837,"avatar_url":"https://avatars.githubusercontent.com/u/388837?v=3","gravatar_id":"","url":"https://api.github.com/users/talevy","html_url":"https://github.com/talevy","followers_url":"https://api.github.com/users/talevy/followers","following_url":"https://api.github.com/users/talevy/following{/other_user}","gists_url":"https://api.github.com/users/talevy/gists{/gist_id}","starred_url":"https://api.github.com/users/talevy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/talevy/subscriptions","organizations_url":"https://api.github.com/users/talevy/orgs","repos_url":"https://api.github.com/users/talevy/repos","events_url":"https://api.github.com/users/talevy/events{/privacy}","received_events_url":"https://api.github.com/users/talevy/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/pulls/73/commits","review_comments_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/pulls/73/comments","review_comment_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/pulls/comments{/number}","comments_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/issues/73/comments","statuses_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/statuses/c8f689d6b83893e339e3c5c5e7d09cba4c24e4b9","head":{"label":"suyograo:fix/70","ref":"fix/70","sha":"c8f689d6b83893e339e3c5c5e7d09cba4c24e4b9","user":{"login":"suyograo","id":1595958,"avatar_url":"https://avatars.githubusercontent.com/u/1595958?v=3","gravatar_id":"","url":"https://api.github.com/users/suyograo","html_url":"https://github.com/suyograo","followers_url":"https://api.github.com/users/suyograo/followers","following_url":"https://api.github.com/users/suyograo/following{/other_user}","gists_url":"https://api.github.com/users/suyograo/gists{/gist_id}","starred_url":"https://api.github.com/users/suyograo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/suyograo/subscriptions","organizations_url":"https://api.github.com/users/suyograo/orgs","repos_url":"https://api.github.com/users/suyograo/repos","events_url":"https://api.github.com/users/suyograo/events{/privacy}","received_events_url":"https://api.github.com/users/suyograo/received_events","type":"User","site_admin":false},"repo":{"id":54297774,"name":"logstash-filter-geoip","full_name":"suyograo/logstash-filter-geoip","owner":{"login":"suyograo","id":1595958,"avatar_url":"https://avatars.githubusercontent.com/u/1595958?v=3","gravatar_id":"","url":"https://api.github.com/users/suyograo","html_url":"https://github.com/suyograo","followers_url":"https://api.github.com/users/suyograo/followers","following_url":"https://api.github.com/users/suyograo/following{/other_user}","gists_url":"https://api.github.com/users/suyograo/gists{/gist_id}","starred_url":"https://api.github.com/users/suyograo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/suyograo/subscriptions","organizations_url":"https://api.github.com/users/suyograo/orgs","repos_url":"https://api.github.com/users/suyograo/repos","events_url":"https://api.github.com/users/suyograo/events{/privacy}","received_events_url":"https://api.github.com/users/suyograo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/suyograo/logstash-filter-geoip","description":null,"fork":true,"url":"https://api.github.com/repos/suyograo/logstash-filter-geoip","forks_url":"https://api.github.com/repos/suyograo/logstash-filter-geoip/forks","keys_url":"https://api.github.com/repos/suyograo/logstash-filter-geoip/keys{/key_id}","collaborators_url":"https://api.github.com/repos/suyograo/logstash-filter-geoip/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/suyograo/logstash-filter-geoip/teams","hooks_url":"https://api.github.com/repos/suyograo/logstash-filter-geoip/hooks","issue_events_url":"https://api.github.com/repos/suyograo/logstash-filter-geoip/issues/events{/number}","events_url":"https://api.github.com/repos/suyograo/logstash-filter-geoip/events","assignees_url":"https://api.github.com/repos/suyograo/logstash-filter-geoip/assignees{/user}","branches_url":"https://api.github.com/repos/suyograo/logstash-filter-geoip/branches{/branch}","tags_url":"https://api.github.com/repos/suyograo/logstash-filter-geoip/tags","blobs_url":"https://api.github.com/repos/suyograo/logstash-filter-geoip/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/suyograo/logstash-filter-geoip/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/suyograo/logstash-filter-geoip/git/refs{/sha}","trees_url":"https://api.github.com/repos/suyograo/logstash-filter-geoip/git/trees{/sha}","statuses_url":"https://api.github.com/repos/suyograo/logstash-filter-geoip/statuses/{sha}","languages_url":"https://api.github.com/repos/suyograo/logstash-filter-geoip/languages","stargazers_url":"https://api.github.com/repos/suyograo/logstash-filter-geoip/stargazers","contributors_url":"https://api.github.com/repos/suyograo/logstash-filter-geoip/contributors","subscribers_url":"https://api.github.com/repos/suyograo/logstash-filter-geoip/subscribers","subscription_url":"https://api.github.com/repos/suyograo/logstash-filter-geoip/subscription","commits_url":"https://api.github.com/repos/suyograo/logstash-filter-geoip/commits{/sha}","git_commits_url":"https://api.github.com/repos/suyograo/logstash-filter-geoip/git/commits{/sha}","comments_url":"https://api.github.com/repos/suyograo/logstash-filter-geoip/comments{/number}","issue_comment_url":"https://api.github.com/repos/suyograo/logstash-filter-geoip/issues/comments{/number}","contents_url":"https://api.github.com/repos/suyograo/logstash-filter-geoip/contents/{+path}","compare_url":"https://api.github.com/repos/suyograo/logstash-filter-geoip/compare/{base}...{head}","merges_url":"https://api.github.com/repos/suyograo/logstash-filter-geoip/merges","archive_url":"https://api.github.com/repos/suyograo/logstash-filter-geoip/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/suyograo/logstash-filter-geoip/downloads","issues_url":"https://api.github.com/repos/suyograo/logstash-filter-geoip/issues{/number}","pulls_url":"https://api.github.com/repos/suyograo/logstash-filter-geoip/pulls{/number}","milestones_url":"https://api.github.com/repos/suyograo/logstash-filter-geoip/milestones{/number}","notifications_url":"https://api.github.com/repos/suyograo/logstash-filter-geoip/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/suyograo/logstash-filter-geoip/labels{/name}","releases_url":"https://api.github.com/repos/suyograo/logstash-filter-geoip/releases{/id}","deployments_url":"https://api.github.com/repos/suyograo/logstash-filter-geoip/deployments","created_at":"2016-03-20T03:00:20Z","updated_at":"2016-03-20T03:00:21Z","pushed_at":"2016-04-28T23:18:12Z","git_url":"git://github.com/suyograo/logstash-filter-geoip.git","ssh_url":"git@github.com:suyograo/logstash-filter-geoip.git","clone_url":"https://github.com/suyograo/logstash-filter-geoip.git","svn_url":"https://github.com/suyograo/logstash-filter-geoip","homepage":null,"size":3783,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"logstash-plugins:master","ref":"master","sha":"ccf4057ba9a1207bae66b86c5c82ad1b6819ff5d","user":{"login":"logstash-plugins","id":8961934,"avatar_url":"https://avatars.githubusercontent.com/u/8961934?v=3","gravatar_id":"","url":"https://api.github.com/users/logstash-plugins","html_url":"https://github.com/logstash-plugins","followers_url":"https://api.github.com/users/logstash-plugins/followers","following_url":"https://api.github.com/users/logstash-plugins/following{/other_user}","gists_url":"https://api.github.com/users/logstash-plugins/gists{/gist_id}","starred_url":"https://api.github.com/users/logstash-plugins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/logstash-plugins/subscriptions","organizations_url":"https://api.github.com/users/logstash-plugins/orgs","repos_url":"https://api.github.com/users/logstash-plugins/repos","events_url":"https://api.github.com/users/logstash-plugins/events{/privacy}","received_events_url":"https://api.github.com/users/logstash-plugins/received_events","type":"Organization","site_admin":false},"repo":{"id":24894901,"name":"logstash-filter-geoip","full_name":"logstash-plugins/logstash-filter-geoip","owner":{"login":"logstash-plugins","id":8961934,"avatar_url":"https://avatars.githubusercontent.com/u/8961934?v=3","gravatar_id":"","url":"https://api.github.com/users/logstash-plugins","html_url":"https://github.com/logstash-plugins","followers_url":"https://api.github.com/users/logstash-plugins/followers","following_url":"https://api.github.com/users/logstash-plugins/following{/other_user}","gists_url":"https://api.github.com/users/logstash-plugins/gists{/gist_id}","starred_url":"https://api.github.com/users/logstash-plugins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/logstash-plugins/subscriptions","organizations_url":"https://api.github.com/users/logstash-plugins/orgs","repos_url":"https://api.github.com/users/logstash-plugins/repos","events_url":"https://api.github.com/users/logstash-plugins/events{/privacy}","received_events_url":"https://api.github.com/users/logstash-plugins/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/logstash-plugins/logstash-filter-geoip","description":null,"fork":false,"url":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip","forks_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/forks","keys_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/keys{/key_id}","collaborators_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/teams","hooks_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/hooks","issue_events_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/issues/events{/number}","events_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/events","assignees_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/assignees{/user}","branches_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/branches{/branch}","tags_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/tags","blobs_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/git/refs{/sha}","trees_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/git/trees{/sha}","statuses_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/statuses/{sha}","languages_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/languages","stargazers_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/stargazers","contributors_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/contributors","subscribers_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/subscribers","subscription_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/subscription","commits_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/commits{/sha}","git_commits_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/git/commits{/sha}","comments_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/comments{/number}","issue_comment_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/issues/comments{/number}","contents_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/contents/{+path}","compare_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/compare/{base}...{head}","merges_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/merges","archive_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/downloads","issues_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/issues{/number}","pulls_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/pulls{/number}","milestones_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/milestones{/number}","notifications_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/labels{/name}","releases_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/releases{/id}","deployments_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/deployments","created_at":"2014-10-07T14:46:42Z","updated_at":"2016-03-01T07:09:10Z","pushed_at":"2016-04-28T23:18:13Z","git_url":"git://github.com/logstash-plugins/logstash-filter-geoip.git","ssh_url":"git@github.com:logstash-plugins/logstash-filter-geoip.git","clone_url":"https://github.com/logstash-plugins/logstash-filter-geoip.git","svn_url":"https://github.com/logstash-plugins/logstash-filter-geoip","homepage":null,"size":3813,"stargazers_count":10,"watchers_count":10,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":33,"mirror_url":null,"open_issues_count":26,"forks":33,"open_issues":26,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/pulls/73"},"html":{"href":"https://github.com/logstash-plugins/logstash-filter-geoip/pull/73"},"issue":{"href":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/issues/73"},"comments":{"href":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/issues/73/comments"},"review_comments":{"href":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/pulls/73/comments"},"review_comment":{"href":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/pulls/73/commits"},"statuses":{"href":"https://api.github.com/repos/logstash-plugins/logstash-filter-geoip/statuses/c8f689d6b83893e339e3c5c5e7d09cba4c24e4b9"}}}}