{"action":"created","comment":{"url":"https://api.github.com/repos/interledger/five-bells-ledger/pulls/comments/53837678","id":53837678,"diff_hunk":"@@ -1,33 +1,5 @@\n 'use strict'\n \n-const Config = require('five-bells-shared').Config\n-const envPrefix = 'ledger'\n+const loadConfig = require('../lib/config')\n \n-function isRunningTests () {\n-  return process.argv[0].endsWith('mocha') ||\n-    (process.argv.length > 1 && process.argv[0].endsWith('node') &&\n-     process.argv[1].endsWith('mocha'))\n-}\n-\n-const localConfig = {}\n-const admin_user = Config.getEnv(envPrefix, 'ADMIN_USER') || 'admin'\n-const admin_pass = Config.getEnv(envPrefix, 'ADMIN_PASS')\n-\n-if (admin_pass) {\n-  localConfig.default_admin = {\n-    user: admin_user,\n-    pass: admin_pass\n-  }\n-}\n-\n-if (isRunningTests()) {\n-  localConfig.keys = {\n-    ed25519: {\n-      secret: 'iMx6i3D3acJPc4aJlK0iT/pkJP3T+Dqte9wg6hXpXEv08CpNQSm1J5AI6n/' +\n-        'QVBObeuQWdQVpgRQTAJzLLJJA/Q==',\n-      public: '9PAqTUEptSeQCOp/0FQTm3rkFnUFaYEUEwCcyyySQP0='\n-    }\n-  }\n-}\n-\n-module.exports = Config.loadConfig(envPrefix, localConfig)\n+module.exports = loadConfig()","path":"src/services/config.js","position":35,"original_position":35,"commit_id":"96c4aa28f768f190a4ff8f09d79555aff3fe2733","original_commit_id":"756ea55146cbb15746d223d04e7eab6d11739c20","user":{"login":"lumberj","id":1812196,"avatar_url":"https://avatars.githubusercontent.com/u/1812196?v=3","gravatar_id":"","url":"https://api.github.com/users/lumberj","html_url":"https://github.com/lumberj","followers_url":"https://api.github.com/users/lumberj/followers","following_url":"https://api.github.com/users/lumberj/following{/other_user}","gists_url":"https://api.github.com/users/lumberj/gists{/gist_id}","starred_url":"https://api.github.com/users/lumberj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lumberj/subscriptions","organizations_url":"https://api.github.com/users/lumberj/orgs","repos_url":"https://api.github.com/users/lumberj/repos","events_url":"https://api.github.com/users/lumberj/events{/privacy}","received_events_url":"https://api.github.com/users/lumberj/received_events","type":"User","site_admin":false},"body":"To be consistent with the existing paradigm, I would add `config` to the constructor of NotificationWorker","created_at":"2016-02-23T19:44:12Z","updated_at":"2016-02-23T19:44:12Z","html_url":"https://github.com/interledger/five-bells-ledger/pull/165#discussion_r53837678","pull_request_url":"https://api.github.com/repos/interledger/five-bells-ledger/pulls/165","_links":{"self":{"href":"https://api.github.com/repos/interledger/five-bells-ledger/pulls/comments/53837678"},"html":{"href":"https://github.com/interledger/five-bells-ledger/pull/165#discussion_r53837678"},"pull_request":{"href":"https://api.github.com/repos/interledger/five-bells-ledger/pulls/165"}}},"pull_request":{"url":"https://api.github.com/repos/interledger/five-bells-ledger/pulls/165","id":60289673,"html_url":"https://github.com/interledger/five-bells-ledger/pull/165","diff_url":"https://github.com/interledger/five-bells-ledger/pull/165.diff","patch_url":"https://github.com/interledger/five-bells-ledger/pull/165.patch","issue_url":"https://api.github.com/repos/interledger/five-bells-ledger/issues/165","number":165,"state":"open","locked":false,"title":"Allow TLS client auth for subscription notifications","user":{"login":"lumberj","id":1812196,"avatar_url":"https://avatars.githubusercontent.com/u/1812196?v=3","gravatar_id":"","url":"https://api.github.com/users/lumberj","html_url":"https://github.com/lumberj","followers_url":"https://api.github.com/users/lumberj/followers","following_url":"https://api.github.com/users/lumberj/following{/other_user}","gists_url":"https://api.github.com/users/lumberj/gists{/gist_id}","starred_url":"https://api.github.com/users/lumberj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lumberj/subscriptions","organizations_url":"https://api.github.com/users/lumberj/orgs","repos_url":"https://api.github.com/users/lumberj/repos","events_url":"https://api.github.com/users/lumberj/events{/privacy}","received_events_url":"https://api.github.com/users/lumberj/received_events","type":"User","site_admin":false},"body":"~~Depends on https://github.com/interledger/five-bells-ledger/pull/166~~","created_at":"2016-02-23T05:22:27Z","updated_at":"2016-02-23T19:44:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"136dd0a5f5375d6388cabd51ae7ca48c1e35a121","assignee":{"login":"clark800","id":1238722,"avatar_url":"https://avatars.githubusercontent.com/u/1238722?v=3","gravatar_id":"","url":"https://api.github.com/users/clark800","html_url":"https://github.com/clark800","followers_url":"https://api.github.com/users/clark800/followers","following_url":"https://api.github.com/users/clark800/following{/other_user}","gists_url":"https://api.github.com/users/clark800/gists{/gist_id}","starred_url":"https://api.github.com/users/clark800/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clark800/subscriptions","organizations_url":"https://api.github.com/users/clark800/orgs","repos_url":"https://api.github.com/users/clark800/repos","events_url":"https://api.github.com/users/clark800/events{/privacy}","received_events_url":"https://api.github.com/users/clark800/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/interledger/five-bells-ledger/pulls/165/commits","review_comments_url":"https://api.github.com/repos/interledger/five-bells-ledger/pulls/165/comments","review_comment_url":"https://api.github.com/repos/interledger/five-bells-ledger/pulls/comments{/number}","comments_url":"https://api.github.com/repos/interledger/five-bells-ledger/issues/165/comments","statuses_url":"https://api.github.com/repos/interledger/five-bells-ledger/statuses/96c4aa28f768f190a4ff8f09d79555aff3fe2733","head":{"label":"lumberj:subscription-client-auth","ref":"subscription-client-auth","sha":"96c4aa28f768f190a4ff8f09d79555aff3fe2733","user":{"login":"lumberj","id":1812196,"avatar_url":"https://avatars.githubusercontent.com/u/1812196?v=3","gravatar_id":"","url":"https://api.github.com/users/lumberj","html_url":"https://github.com/lumberj","followers_url":"https://api.github.com/users/lumberj/followers","following_url":"https://api.github.com/users/lumberj/following{/other_user}","gists_url":"https://api.github.com/users/lumberj/gists{/gist_id}","starred_url":"https://api.github.com/users/lumberj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lumberj/subscriptions","organizations_url":"https://api.github.com/users/lumberj/orgs","repos_url":"https://api.github.com/users/lumberj/repos","events_url":"https://api.github.com/users/lumberj/events{/privacy}","received_events_url":"https://api.github.com/users/lumberj/received_events","type":"User","site_admin":false},"repo":{"id":49240165,"name":"five-bells-ledger","full_name":"lumberj/five-bells-ledger","owner":{"login":"lumberj","id":1812196,"avatar_url":"https://avatars.githubusercontent.com/u/1812196?v=3","gravatar_id":"","url":"https://api.github.com/users/lumberj","html_url":"https://github.com/lumberj","followers_url":"https://api.github.com/users/lumberj/followers","following_url":"https://api.github.com/users/lumberj/following{/other_user}","gists_url":"https://api.github.com/users/lumberj/gists{/gist_id}","starred_url":"https://api.github.com/users/lumberj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lumberj/subscriptions","organizations_url":"https://api.github.com/users/lumberj/orgs","repos_url":"https://api.github.com/users/lumberj/repos","events_url":"https://api.github.com/users/lumberj/events{/privacy}","received_events_url":"https://api.github.com/users/lumberj/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lumberj/five-bells-ledger","description":"An implementation of the Five Bells ledger interface.","fork":true,"url":"https://api.github.com/repos/lumberj/five-bells-ledger","forks_url":"https://api.github.com/repos/lumberj/five-bells-ledger/forks","keys_url":"https://api.github.com/repos/lumberj/five-bells-ledger/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lumberj/five-bells-ledger/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lumberj/five-bells-ledger/teams","hooks_url":"https://api.github.com/repos/lumberj/five-bells-ledger/hooks","issue_events_url":"https://api.github.com/repos/lumberj/five-bells-ledger/issues/events{/number}","events_url":"https://api.github.com/repos/lumberj/five-bells-ledger/events","assignees_url":"https://api.github.com/repos/lumberj/five-bells-ledger/assignees{/user}","branches_url":"https://api.github.com/repos/lumberj/five-bells-ledger/branches{/branch}","tags_url":"https://api.github.com/repos/lumberj/five-bells-ledger/tags","blobs_url":"https://api.github.com/repos/lumberj/five-bells-ledger/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lumberj/five-bells-ledger/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lumberj/five-bells-ledger/git/refs{/sha}","trees_url":"https://api.github.com/repos/lumberj/five-bells-ledger/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lumberj/five-bells-ledger/statuses/{sha}","languages_url":"https://api.github.com/repos/lumberj/five-bells-ledger/languages","stargazers_url":"https://api.github.com/repos/lumberj/five-bells-ledger/stargazers","contributors_url":"https://api.github.com/repos/lumberj/five-bells-ledger/contributors","subscribers_url":"https://api.github.com/repos/lumberj/five-bells-ledger/subscribers","subscription_url":"https://api.github.com/repos/lumberj/five-bells-ledger/subscription","commits_url":"https://api.github.com/repos/lumberj/five-bells-ledger/commits{/sha}","git_commits_url":"https://api.github.com/repos/lumberj/five-bells-ledger/git/commits{/sha}","comments_url":"https://api.github.com/repos/lumberj/five-bells-ledger/comments{/number}","issue_comment_url":"https://api.github.com/repos/lumberj/five-bells-ledger/issues/comments{/number}","contents_url":"https://api.github.com/repos/lumberj/five-bells-ledger/contents/{+path}","compare_url":"https://api.github.com/repos/lumberj/five-bells-ledger/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lumberj/five-bells-ledger/merges","archive_url":"https://api.github.com/repos/lumberj/five-bells-ledger/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lumberj/five-bells-ledger/downloads","issues_url":"https://api.github.com/repos/lumberj/five-bells-ledger/issues{/number}","pulls_url":"https://api.github.com/repos/lumberj/five-bells-ledger/pulls{/number}","milestones_url":"https://api.github.com/repos/lumberj/five-bells-ledger/milestones{/number}","notifications_url":"https://api.github.com/repos/lumberj/five-bells-ledger/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lumberj/five-bells-ledger/labels{/name}","releases_url":"https://api.github.com/repos/lumberj/five-bells-ledger/releases{/id}","deployments_url":"https://api.github.com/repos/lumberj/five-bells-ledger/deployments","created_at":"2016-01-08T00:53:53Z","updated_at":"2016-01-08T00:53:54Z","pushed_at":"2016-02-23T19:40:45Z","git_url":"git://github.com/lumberj/five-bells-ledger.git","ssh_url":"git@github.com:lumberj/five-bells-ledger.git","clone_url":"https://github.com/lumberj/five-bells-ledger.git","svn_url":"https://github.com/lumberj/five-bells-ledger","homepage":null,"size":852,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"interledger:master","ref":"master","sha":"15dd69d77c997cb66c2ea3f65d9376adffd88def","user":{"login":"interledger","id":14062960,"avatar_url":"https://avatars.githubusercontent.com/u/14062960?v=3","gravatar_id":"","url":"https://api.github.com/users/interledger","html_url":"https://github.com/interledger","followers_url":"https://api.github.com/users/interledger/followers","following_url":"https://api.github.com/users/interledger/following{/other_user}","gists_url":"https://api.github.com/users/interledger/gists{/gist_id}","starred_url":"https://api.github.com/users/interledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/interledger/subscriptions","organizations_url":"https://api.github.com/users/interledger/orgs","repos_url":"https://api.github.com/users/interledger/repos","events_url":"https://api.github.com/users/interledger/events{/privacy}","received_events_url":"https://api.github.com/users/interledger/received_events","type":"Organization","site_admin":false},"repo":{"id":30608771,"name":"five-bells-ledger","full_name":"interledger/five-bells-ledger","owner":{"login":"interledger","id":14062960,"avatar_url":"https://avatars.githubusercontent.com/u/14062960?v=3","gravatar_id":"","url":"https://api.github.com/users/interledger","html_url":"https://github.com/interledger","followers_url":"https://api.github.com/users/interledger/followers","following_url":"https://api.github.com/users/interledger/following{/other_user}","gists_url":"https://api.github.com/users/interledger/gists{/gist_id}","starred_url":"https://api.github.com/users/interledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/interledger/subscriptions","organizations_url":"https://api.github.com/users/interledger/orgs","repos_url":"https://api.github.com/users/interledger/repos","events_url":"https://api.github.com/users/interledger/events{/privacy}","received_events_url":"https://api.github.com/users/interledger/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/interledger/five-bells-ledger","description":"An implementation of the Five Bells ledger interface.","fork":false,"url":"https://api.github.com/repos/interledger/five-bells-ledger","forks_url":"https://api.github.com/repos/interledger/five-bells-ledger/forks","keys_url":"https://api.github.com/repos/interledger/five-bells-ledger/keys{/key_id}","collaborators_url":"https://api.github.com/repos/interledger/five-bells-ledger/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/interledger/five-bells-ledger/teams","hooks_url":"https://api.github.com/repos/interledger/five-bells-ledger/hooks","issue_events_url":"https://api.github.com/repos/interledger/five-bells-ledger/issues/events{/number}","events_url":"https://api.github.com/repos/interledger/five-bells-ledger/events","assignees_url":"https://api.github.com/repos/interledger/five-bells-ledger/assignees{/user}","branches_url":"https://api.github.com/repos/interledger/five-bells-ledger/branches{/branch}","tags_url":"https://api.github.com/repos/interledger/five-bells-ledger/tags","blobs_url":"https://api.github.com/repos/interledger/five-bells-ledger/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/interledger/five-bells-ledger/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/interledger/five-bells-ledger/git/refs{/sha}","trees_url":"https://api.github.com/repos/interledger/five-bells-ledger/git/trees{/sha}","statuses_url":"https://api.github.com/repos/interledger/five-bells-ledger/statuses/{sha}","languages_url":"https://api.github.com/repos/interledger/five-bells-ledger/languages","stargazers_url":"https://api.github.com/repos/interledger/five-bells-ledger/stargazers","contributors_url":"https://api.github.com/repos/interledger/five-bells-ledger/contributors","subscribers_url":"https://api.github.com/repos/interledger/five-bells-ledger/subscribers","subscription_url":"https://api.github.com/repos/interledger/five-bells-ledger/subscription","commits_url":"https://api.github.com/repos/interledger/five-bells-ledger/commits{/sha}","git_commits_url":"https://api.github.com/repos/interledger/five-bells-ledger/git/commits{/sha}","comments_url":"https://api.github.com/repos/interledger/five-bells-ledger/comments{/number}","issue_comment_url":"https://api.github.com/repos/interledger/five-bells-ledger/issues/comments{/number}","contents_url":"https://api.github.com/repos/interledger/five-bells-ledger/contents/{+path}","compare_url":"https://api.github.com/repos/interledger/five-bells-ledger/compare/{base}...{head}","merges_url":"https://api.github.com/repos/interledger/five-bells-ledger/merges","archive_url":"https://api.github.com/repos/interledger/five-bells-ledger/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/interledger/five-bells-ledger/downloads","issues_url":"https://api.github.com/repos/interledger/five-bells-ledger/issues{/number}","pulls_url":"https://api.github.com/repos/interledger/five-bells-ledger/pulls{/number}","milestones_url":"https://api.github.com/repos/interledger/five-bells-ledger/milestones{/number}","notifications_url":"https://api.github.com/repos/interledger/five-bells-ledger/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/interledger/five-bells-ledger/labels{/name}","releases_url":"https://api.github.com/repos/interledger/five-bells-ledger/releases{/id}","deployments_url":"https://api.github.com/repos/interledger/five-bells-ledger/deployments","created_at":"2015-02-10T18:59:20Z","updated_at":"2016-02-12T17:53:05Z","pushed_at":"2016-02-23T19:40:45Z","git_url":"git://github.com/interledger/five-bells-ledger.git","ssh_url":"git@github.com:interledger/five-bells-ledger.git","clone_url":"https://github.com/interledger/five-bells-ledger.git","svn_url":"https://github.com/interledger/five-bells-ledger","homepage":null,"size":897,"stargazers_count":6,"watchers_count":6,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":17,"forks":6,"open_issues":17,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/interledger/five-bells-ledger/pulls/165"},"html":{"href":"https://github.com/interledger/five-bells-ledger/pull/165"},"issue":{"href":"https://api.github.com/repos/interledger/five-bells-ledger/issues/165"},"comments":{"href":"https://api.github.com/repos/interledger/five-bells-ledger/issues/165/comments"},"review_comments":{"href":"https://api.github.com/repos/interledger/five-bells-ledger/pulls/165/comments"},"review_comment":{"href":"https://api.github.com/repos/interledger/five-bells-ledger/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/interledger/five-bells-ledger/pulls/165/commits"},"statuses":{"href":"https://api.github.com/repos/interledger/five-bells-ledger/statuses/96c4aa28f768f190a4ff8f09d79555aff3fe2733"}}}}