{"action":"created","issue":{"url":"https://api.github.com/repos/bloomberg/bqplot/issues/272","repository_url":"https://api.github.com/repos/bloomberg/bqplot","labels_url":"https://api.github.com/repos/bloomberg/bqplot/issues/272/labels{/name}","comments_url":"https://api.github.com/repos/bloomberg/bqplot/issues/272/comments","events_url":"https://api.github.com/repos/bloomberg/bqplot/issues/272/events","html_url":"https://github.com/bloomberg/bqplot/pull/272","id":171259347,"number":272,"title":"Fixing issue with Pandas data frame trait","user":{"login":"ssunkara1","id":6981114,"avatar_url":"https://avatars.githubusercontent.com/u/6981114?v=3","gravatar_id":"","url":"https://api.github.com/users/ssunkara1","html_url":"https://github.com/ssunkara1","followers_url":"https://api.github.com/users/ssunkara1/followers","following_url":"https://api.github.com/users/ssunkara1/following{/other_user}","gists_url":"https://api.github.com/users/ssunkara1/gists{/gist_id}","starred_url":"https://api.github.com/users/ssunkara1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssunkara1/subscriptions","organizations_url":"https://api.github.com/users/ssunkara1/orgs","repos_url":"https://api.github.com/users/ssunkara1/repos","events_url":"https://api.github.com/users/ssunkara1/events{/privacy}","received_events_url":"https://api.github.com/users/ssunkara1/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/bloomberg/bqplot/labels/bug","name":"bug","color":"fc2929"},{"url":"https://api.github.com/repos/bloomberg/bqplot/labels/Next%20Release","name":"Next Release","color":"fbca04"}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-08-15T20:53:16Z","updated_at":"2016-08-16T08:41:18Z","closed_at":"2016-08-15T22:45:11Z","pull_request":{"url":"https://api.github.com/repos/bloomberg/bqplot/pulls/272","html_url":"https://github.com/bloomberg/bqplot/pull/272","diff_url":"https://github.com/bloomberg/bqplot/pull/272.diff","patch_url":"https://github.com/bloomberg/bqplot/pull/272.patch"},"body":"There was a bug in `PandasDataFrame` trait where we were assuming that the index is not named. This PR fixes that issue. Because of this, we were getting the issue in `MarketMap` when we click on the cell.\r\n\r\nThere is another reason why this issue surfaced only now. Previously in `ipywidgets`, only attributes whose value changed were sent across to the python side on call of `.touch` function. But now, in the first and second calls, many more attributes are sent across. @jasongrout is looking at the issue on the `ipywidgets` side. "},"comment":{"url":"https://api.github.com/repos/bloomberg/bqplot/issues/comments/240039315","html_url":"https://github.com/bloomberg/bqplot/pull/272#issuecomment-240039315","issue_url":"https://api.github.com/repos/bloomberg/bqplot/issues/272","id":240039315,"user":{"login":"jasongrout","id":192614,"avatar_url":"https://avatars.githubusercontent.com/u/192614?v=3","gravatar_id":"","url":"https://api.github.com/users/jasongrout","html_url":"https://github.com/jasongrout","followers_url":"https://api.github.com/users/jasongrout/followers","following_url":"https://api.github.com/users/jasongrout/following{/other_user}","gists_url":"https://api.github.com/users/jasongrout/gists{/gist_id}","starred_url":"https://api.github.com/users/jasongrout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasongrout/subscriptions","organizations_url":"https://api.github.com/users/jasongrout/orgs","repos_url":"https://api.github.com/users/jasongrout/repos","events_url":"https://api.github.com/users/jasongrout/events{/privacy}","received_events_url":"https://api.github.com/users/jasongrout/received_events","type":"User","site_admin":false},"created_at":"2016-08-16T08:41:17Z","updated_at":"2016-08-16T08:41:17Z","body":"`model.defaults` doesn't *have* to change to a function. But anything that refers to the defaults from the base widget should use `_.result` (http://underscorejs.org/#result) or the equivalent, just like backbone does (http://backbonejs.org/docs/backbone.html#section-54). This is backwards compatible and covers the case where defaults is a function or an attribute.\r\n\r\nSo, for example, https://github.com/bloomberg/bqplot/blob/2d597baf9b3c581905f8d75f7b5c44ed09b7b4db/js/src/HandDrawModel.js#L22 would be (I think, without testing...)\r\n```javascript\r\ndefaults: _.extend({}, _.result(widgets.WidgetModel.prototype, 'defaults'), {\r\n```"}}
{"actor":{"display_login":"jasongrout"}}