{"action":"closed","number":236,"pull_request":{"url":"https://api.github.com/repos/neovim/python-client/pulls/236","id":92959824,"html_url":"https://github.com/neovim/python-client/pull/236","diff_url":"https://github.com/neovim/python-client/pull/236.diff","patch_url":"https://github.com/neovim/python-client/pull/236.patch","issue_url":"https://api.github.com/repos/neovim/python-client/issues/236","number":236,"state":"closed","locked":false,"title":"api: export Object.handle and make Buffer.number non-blocking","user":{"login":"bfredl","id":1363104,"avatar_url":"https://avatars.githubusercontent.com/u/1363104?v=3","gravatar_id":"","url":"https://api.github.com/users/bfredl","html_url":"https://github.com/bfredl","followers_url":"https://api.github.com/users/bfredl/followers","following_url":"https://api.github.com/users/bfredl/following{/other_user}","gists_url":"https://api.github.com/users/bfredl/gists{/gist_id}","starred_url":"https://api.github.com/users/bfredl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bfredl/subscriptions","organizations_url":"https://api.github.com/users/bfredl/orgs","repos_url":"https://api.github.com/users/bfredl/repos","events_url":"https://api.github.com/users/bfredl/events{/privacy}","received_events_url":"https://api.github.com/users/bfredl/received_events","type":"User","site_admin":false},"body":"In conversion with @justinmk (on gitter), we decided to \"freeze\" the current msgpack EXT representation objects, which simply is the handle (buffer number, window id) of the object. This means `nvim_buf_get_number` is very unneccesery, it takes the (doubly-encoded) number and just echoes the same number back, single-encoded.\r\n\r\nThis makes `buffer.number` deduce the number from the `code_data`, instead of using a blocking rpc call. This means it can be safely used in async handlers and threads, for instance buffer change notifications (neovim/neovim#5269) will send a buffer object in async notifications, but one might want to use the number for bookkeeping etc.\r\n\r\nThis also exposes Object.handle, I think it is very unlikely that vim will introduce something conflicting here, if anythink they might add `Window.winid` which we can alias the same way.","created_at":"2016-11-09T13:04:38Z","updated_at":"2016-11-10T17:18:17Z","closed_at":"2016-11-10T17:18:17Z","merged_at":"2016-11-10T17:18:17Z","merge_commit_sha":"562eac95a8e8217bcead3418b9babdaddaf94c67","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/neovim/python-client/pulls/236/commits","review_comments_url":"https://api.github.com/repos/neovim/python-client/pulls/236/comments","review_comment_url":"https://api.github.com/repos/neovim/python-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/neovim/python-client/issues/236/comments","statuses_url":"https://api.github.com/repos/neovim/python-client/statuses/317abdaf26b95c73b67d94c6b75f4028826dfd38","head":{"label":"bfredl:handle","ref":"handle","sha":"317abdaf26b95c73b67d94c6b75f4028826dfd38","user":{"login":"bfredl","id":1363104,"avatar_url":"https://avatars.githubusercontent.com/u/1363104?v=3","gravatar_id":"","url":"https://api.github.com/users/bfredl","html_url":"https://github.com/bfredl","followers_url":"https://api.github.com/users/bfredl/followers","following_url":"https://api.github.com/users/bfredl/following{/other_user}","gists_url":"https://api.github.com/users/bfredl/gists{/gist_id}","starred_url":"https://api.github.com/users/bfredl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bfredl/subscriptions","organizations_url":"https://api.github.com/users/bfredl/orgs","repos_url":"https://api.github.com/users/bfredl/repos","events_url":"https://api.github.com/users/bfredl/events{/privacy}","received_events_url":"https://api.github.com/users/bfredl/received_events","type":"User","site_admin":false},"repo":{"id":25154759,"name":"python-client","full_name":"bfredl/python-client","owner":{"login":"bfredl","id":1363104,"avatar_url":"https://avatars.githubusercontent.com/u/1363104?v=3","gravatar_id":"","url":"https://api.github.com/users/bfredl","html_url":"https://github.com/bfredl","followers_url":"https://api.github.com/users/bfredl/followers","following_url":"https://api.github.com/users/bfredl/following{/other_user}","gists_url":"https://api.github.com/users/bfredl/gists{/gist_id}","starred_url":"https://api.github.com/users/bfredl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bfredl/subscriptions","organizations_url":"https://api.github.com/users/bfredl/orgs","repos_url":"https://api.github.com/users/bfredl/repos","events_url":"https://api.github.com/users/bfredl/events{/privacy}","received_events_url":"https://api.github.com/users/bfredl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bfredl/python-client","description":"Python client for Neovim","fork":true,"url":"https://api.github.com/repos/bfredl/python-client","forks_url":"https://api.github.com/repos/bfredl/python-client/forks","keys_url":"https://api.github.com/repos/bfredl/python-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bfredl/python-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bfredl/python-client/teams","hooks_url":"https://api.github.com/repos/bfredl/python-client/hooks","issue_events_url":"https://api.github.com/repos/bfredl/python-client/issues/events{/number}","events_url":"https://api.github.com/repos/bfredl/python-client/events","assignees_url":"https://api.github.com/repos/bfredl/python-client/assignees{/user}","branches_url":"https://api.github.com/repos/bfredl/python-client/branches{/branch}","tags_url":"https://api.github.com/repos/bfredl/python-client/tags","blobs_url":"https://api.github.com/repos/bfredl/python-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bfredl/python-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bfredl/python-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/bfredl/python-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bfredl/python-client/statuses/{sha}","languages_url":"https://api.github.com/repos/bfredl/python-client/languages","stargazers_url":"https://api.github.com/repos/bfredl/python-client/stargazers","contributors_url":"https://api.github.com/repos/bfredl/python-client/contributors","subscribers_url":"https://api.github.com/repos/bfredl/python-client/subscribers","subscription_url":"https://api.github.com/repos/bfredl/python-client/subscription","commits_url":"https://api.github.com/repos/bfredl/python-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/bfredl/python-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/bfredl/python-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/bfredl/python-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/bfredl/python-client/contents/{+path}","compare_url":"https://api.github.com/repos/bfredl/python-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bfredl/python-client/merges","archive_url":"https://api.github.com/repos/bfredl/python-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bfredl/python-client/downloads","issues_url":"https://api.github.com/repos/bfredl/python-client/issues{/number}","pulls_url":"https://api.github.com/repos/bfredl/python-client/pulls{/number}","milestones_url":"https://api.github.com/repos/bfredl/python-client/milestones{/number}","notifications_url":"https://api.github.com/repos/bfredl/python-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bfredl/python-client/labels{/name}","releases_url":"https://api.github.com/repos/bfredl/python-client/releases{/id}","deployments_url":"https://api.github.com/repos/bfredl/python-client/deployments","created_at":"2014-10-13T10:50:37Z","updated_at":"2016-03-09T13:12:59Z","pushed_at":"2016-11-09T13:41:25Z","git_url":"git://github.com/bfredl/python-client.git","ssh_url":"git@github.com:bfredl/python-client.git","clone_url":"https://github.com/bfredl/python-client.git","svn_url":"https://github.com/bfredl/python-client","homepage":null,"size":379,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"neovim:master","ref":"master","sha":"7692502e6ffcbedf4d2a64f03dcf33b695c30686","user":{"login":"neovim","id":6471485,"avatar_url":"https://avatars.githubusercontent.com/u/6471485?v=3","gravatar_id":"","url":"https://api.github.com/users/neovim","html_url":"https://github.com/neovim","followers_url":"https://api.github.com/users/neovim/followers","following_url":"https://api.github.com/users/neovim/following{/other_user}","gists_url":"https://api.github.com/users/neovim/gists{/gist_id}","starred_url":"https://api.github.com/users/neovim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neovim/subscriptions","organizations_url":"https://api.github.com/users/neovim/orgs","repos_url":"https://api.github.com/users/neovim/repos","events_url":"https://api.github.com/users/neovim/events{/privacy}","received_events_url":"https://api.github.com/users/neovim/received_events","type":"Organization","site_admin":false},"repo":{"id":19548750,"name":"python-client","full_name":"neovim/python-client","owner":{"login":"neovim","id":6471485,"avatar_url":"https://avatars.githubusercontent.com/u/6471485?v=3","gravatar_id":"","url":"https://api.github.com/users/neovim","html_url":"https://github.com/neovim","followers_url":"https://api.github.com/users/neovim/followers","following_url":"https://api.github.com/users/neovim/following{/other_user}","gists_url":"https://api.github.com/users/neovim/gists{/gist_id}","starred_url":"https://api.github.com/users/neovim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neovim/subscriptions","organizations_url":"https://api.github.com/users/neovim/orgs","repos_url":"https://api.github.com/users/neovim/repos","events_url":"https://api.github.com/users/neovim/events{/privacy}","received_events_url":"https://api.github.com/users/neovim/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/neovim/python-client","description":"Python client for Neovim","fork":false,"url":"https://api.github.com/repos/neovim/python-client","forks_url":"https://api.github.com/repos/neovim/python-client/forks","keys_url":"https://api.github.com/repos/neovim/python-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neovim/python-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neovim/python-client/teams","hooks_url":"https://api.github.com/repos/neovim/python-client/hooks","issue_events_url":"https://api.github.com/repos/neovim/python-client/issues/events{/number}","events_url":"https://api.github.com/repos/neovim/python-client/events","assignees_url":"https://api.github.com/repos/neovim/python-client/assignees{/user}","branches_url":"https://api.github.com/repos/neovim/python-client/branches{/branch}","tags_url":"https://api.github.com/repos/neovim/python-client/tags","blobs_url":"https://api.github.com/repos/neovim/python-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neovim/python-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neovim/python-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/neovim/python-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neovim/python-client/statuses/{sha}","languages_url":"https://api.github.com/repos/neovim/python-client/languages","stargazers_url":"https://api.github.com/repos/neovim/python-client/stargazers","contributors_url":"https://api.github.com/repos/neovim/python-client/contributors","subscribers_url":"https://api.github.com/repos/neovim/python-client/subscribers","subscription_url":"https://api.github.com/repos/neovim/python-client/subscription","commits_url":"https://api.github.com/repos/neovim/python-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/neovim/python-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/neovim/python-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/neovim/python-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/neovim/python-client/contents/{+path}","compare_url":"https://api.github.com/repos/neovim/python-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neovim/python-client/merges","archive_url":"https://api.github.com/repos/neovim/python-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neovim/python-client/downloads","issues_url":"https://api.github.com/repos/neovim/python-client/issues{/number}","pulls_url":"https://api.github.com/repos/neovim/python-client/pulls{/number}","milestones_url":"https://api.github.com/repos/neovim/python-client/milestones{/number}","notifications_url":"https://api.github.com/repos/neovim/python-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neovim/python-client/labels{/name}","releases_url":"https://api.github.com/repos/neovim/python-client/releases{/id}","deployments_url":"https://api.github.com/repos/neovim/python-client/deployments","created_at":"2014-05-07T20:13:49Z","updated_at":"2016-11-10T05:09:39Z","pushed_at":"2016-11-10T17:18:16Z","git_url":"git://github.com/neovim/python-client.git","ssh_url":"git@github.com:neovim/python-client.git","clone_url":"https://github.com/neovim/python-client.git","svn_url":"https://github.com/neovim/python-client","homepage":null,"size":436,"stargazers_count":276,"watchers_count":276,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":56,"mirror_url":null,"open_issues_count":17,"forks":56,"open_issues":17,"watchers":276,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/neovim/python-client/pulls/236"},"html":{"href":"https://github.com/neovim/python-client/pull/236"},"issue":{"href":"https://api.github.com/repos/neovim/python-client/issues/236"},"comments":{"href":"https://api.github.com/repos/neovim/python-client/issues/236/comments"},"review_comments":{"href":"https://api.github.com/repos/neovim/python-client/pulls/236/comments"},"review_comment":{"href":"https://api.github.com/repos/neovim/python-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/neovim/python-client/pulls/236/commits"},"statuses":{"href":"https://api.github.com/repos/neovim/python-client/statuses/317abdaf26b95c73b67d94c6b75f4028826dfd38"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"bfredl","id":1363104,"avatar_url":"https://avatars.githubusercontent.com/u/1363104?v=3","gravatar_id":"","url":"https://api.github.com/users/bfredl","html_url":"https://github.com/bfredl","followers_url":"https://api.github.com/users/bfredl/followers","following_url":"https://api.github.com/users/bfredl/following{/other_user}","gists_url":"https://api.github.com/users/bfredl/gists{/gist_id}","starred_url":"https://api.github.com/users/bfredl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bfredl/subscriptions","organizations_url":"https://api.github.com/users/bfredl/orgs","repos_url":"https://api.github.com/users/bfredl/repos","events_url":"https://api.github.com/users/bfredl/events{/privacy}","received_events_url":"https://api.github.com/users/bfredl/received_events","type":"User","site_admin":false},"comments":0,"review_comments":2,"commits":1,"additions":18,"deletions":1,"changed_files":3}}
{"actor":{"display_login":"bfredl"}}