{"action":"created","comment":{"url":"https://api.github.com/repos/google/blockly/pulls/comments/74630913","id":74630913,"diff_hunk":"@@ -383,7 +377,6 @@ AppController.prototype.assignFactoryClickHandlers = function() {\n       });\n   document.getElementById('createNewBlockButton')\n     .addEventListener('click', function() {\n-        BlockFactory.mainWorkspace.clear();","path":"demos/blocklyfactory/app_controller.js","position":84,"original_position":84,"commit_id":"fcb3d3ebdc5c7b39c2b231e14520f3fd9158a9b8","original_commit_id":"fcb3d3ebdc5c7b39c2b231e14520f3fd9158a9b8","user":{"login":"picklesrus","id":15675877,"avatar_url":"https://avatars.githubusercontent.com/u/15675877?v=3","gravatar_id":"","url":"https://api.github.com/users/picklesrus","html_url":"https://github.com/picklesrus","followers_url":"https://api.github.com/users/picklesrus/followers","following_url":"https://api.github.com/users/picklesrus/following{/other_user}","gists_url":"https://api.github.com/users/picklesrus/gists{/gist_id}","starred_url":"https://api.github.com/users/picklesrus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/picklesrus/subscriptions","organizations_url":"https://api.github.com/users/picklesrus/orgs","repos_url":"https://api.github.com/users/picklesrus/repos","events_url":"https://api.github.com/users/picklesrus/events{/privacy}","received_events_url":"https://api.github.com/users/picklesrus/received_events","type":"User","site_admin":false},"body":"why did you remove this?","created_at":"2016-08-12T17:42:56Z","updated_at":"2016-08-12T17:42:56Z","html_url":"https://github.com/google/blockly/pull/535#discussion_r74630913","pull_request_url":"https://api.github.com/repos/google/blockly/pulls/535","_links":{"self":{"href":"https://api.github.com/repos/google/blockly/pulls/comments/74630913"},"html":{"href":"https://github.com/google/blockly/pull/535#discussion_r74630913"},"pull_request":{"href":"https://api.github.com/repos/google/blockly/pulls/535"}}},"pull_request":{"url":"https://api.github.com/repos/google/blockly/pulls/535","id":80911887,"html_url":"https://github.com/google/blockly/pull/535","diff_url":"https://github.com/google/blockly/pull/535.diff","patch_url":"https://github.com/google/blockly/pull/535.patch","issue_url":"https://api.github.com/repos/google/blockly/issues/535","number":535,"state":"open","locked":false,"title":"Workspace Factory Integration #1","user":{"login":"quachtina96","id":10423718,"avatar_url":"https://avatars.githubusercontent.com/u/10423718?v=3","gravatar_id":"","url":"https://api.github.com/users/quachtina96","html_url":"https://github.com/quachtina96","followers_url":"https://api.github.com/users/quachtina96/followers","following_url":"https://api.github.com/users/quachtina96/following{/other_user}","gists_url":"https://api.github.com/users/quachtina96/gists{/gist_id}","starred_url":"https://api.github.com/users/quachtina96/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quachtina96/subscriptions","organizations_url":"https://api.github.com/users/quachtina96/orgs","repos_url":"https://api.github.com/users/quachtina96/repos","events_url":"https://api.github.com/users/quachtina96/events{/privacy}","received_events_url":"https://api.github.com/users/quachtina96/received_events","type":"User","site_admin":false},"body":"# Overview\r\n- pulled functions out of factory.js (BlockFactory) and into factory_utils.js (FactoryUtils), to share useful generator code between the different apps within Blockly Factory. \r\n- added category generating functions to both BlockExporter and WFactory_generator.\r\n- added a helper function to be used for Add All Used Blocks Button once that functionality has been implemented in WFactory_generator.\r\n- removed unnecessary download buttons from Block Factory.\r\n- deleting from and clearing Block Library now visibly affect the Block Factory workspace--to show the starter block as seen below.\r\n\r\n<img width=\"1438\" alt=\"screen shot 2016-08-11 at 12 03 08 am\" src=\"https://cloud.githubusercontent.com/assets/10423718/17580917/255161e8-5f57-11e6-9fd4-1d6895b2e35d.png\">\r\n\r\n# More Specifically\r\n## wfactory_generator.js \r\n- added generateCategoryFromBlockDefs function to generate category xml from imported files.\r\n- added two helper functions for that.\r\n\r\n## factory.js and factory_utils.js\r\n- removed console.log calls\r\n- deprecated the functions in factory.js related to downloading the single blocks block def and generator stub.\r\n- pulled code generating functionality used both in and outside of block factory out of factory.js and into new factory_utils.js file\r\n- factory_utils.js houses code generation functions used for the block factory, workspace factory, and exporter.\r\n\r\n## block_library_controller.js\r\n- deleting a block or clearing the block library also resets Block Factory's main workspace to show the starter block.\r\n\r\n## app_controller.js, block_exporter_controller.js\r\n-  require FactoryUtils and call functions from it.\r\n\r\n## block_exporter_tools.js\r\n-  require FactoryUtils and call functions from it.\r\n-  moved getDefinedBlock out to FactoryUtils so that WFactoryGenerator may use it for generating a category from imported block definitions\r\n- added function to generate category xml from block library blocks\r\n- added getSharedTypes_ function, a helper function to be used for 'Add All Used Blocks' Button\r\n\r\n## block_exporter_view.js\r\n- call the now public workspace.cleanUp() method\r\n\r\n## index.html\r\n- removed the alert that tells users that the block library is empty\r\n- removed download\r\n- shortened button names\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/google/blockly/535)\n<!-- Reviewable:end -->\n","created_at":"2016-08-11T07:04:58Z","updated_at":"2016-08-12T17:42:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9643d242ca4c66dc3c8e9b72274e1f78dae704f0","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/google/blockly/pulls/535/commits","review_comments_url":"https://api.github.com/repos/google/blockly/pulls/535/comments","review_comment_url":"https://api.github.com/repos/google/blockly/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/blockly/issues/535/comments","statuses_url":"https://api.github.com/repos/google/blockly/statuses/fcb3d3ebdc5c7b39c2b231e14520f3fd9158a9b8","head":{"label":"quachtina96:develop-export","ref":"develop-export","sha":"fcb3d3ebdc5c7b39c2b231e14520f3fd9158a9b8","user":{"login":"quachtina96","id":10423718,"avatar_url":"https://avatars.githubusercontent.com/u/10423718?v=3","gravatar_id":"","url":"https://api.github.com/users/quachtina96","html_url":"https://github.com/quachtina96","followers_url":"https://api.github.com/users/quachtina96/followers","following_url":"https://api.github.com/users/quachtina96/following{/other_user}","gists_url":"https://api.github.com/users/quachtina96/gists{/gist_id}","starred_url":"https://api.github.com/users/quachtina96/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quachtina96/subscriptions","organizations_url":"https://api.github.com/users/quachtina96/orgs","repos_url":"https://api.github.com/users/quachtina96/repos","events_url":"https://api.github.com/users/quachtina96/events{/privacy}","received_events_url":"https://api.github.com/users/quachtina96/received_events","type":"User","site_admin":false},"repo":{"id":61349936,"name":"blockly","full_name":"quachtina96/blockly","owner":{"login":"quachtina96","id":10423718,"avatar_url":"https://avatars.githubusercontent.com/u/10423718?v=3","gravatar_id":"","url":"https://api.github.com/users/quachtina96","html_url":"https://github.com/quachtina96","followers_url":"https://api.github.com/users/quachtina96/followers","following_url":"https://api.github.com/users/quachtina96/following{/other_user}","gists_url":"https://api.github.com/users/quachtina96/gists{/gist_id}","starred_url":"https://api.github.com/users/quachtina96/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quachtina96/subscriptions","organizations_url":"https://api.github.com/users/quachtina96/orgs","repos_url":"https://api.github.com/users/quachtina96/repos","events_url":"https://api.github.com/users/quachtina96/events{/privacy}","received_events_url":"https://api.github.com/users/quachtina96/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/quachtina96/blockly","description":"The web-based visual programming editor.","fork":true,"url":"https://api.github.com/repos/quachtina96/blockly","forks_url":"https://api.github.com/repos/quachtina96/blockly/forks","keys_url":"https://api.github.com/repos/quachtina96/blockly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/quachtina96/blockly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/quachtina96/blockly/teams","hooks_url":"https://api.github.com/repos/quachtina96/blockly/hooks","issue_events_url":"https://api.github.com/repos/quachtina96/blockly/issues/events{/number}","events_url":"https://api.github.com/repos/quachtina96/blockly/events","assignees_url":"https://api.github.com/repos/quachtina96/blockly/assignees{/user}","branches_url":"https://api.github.com/repos/quachtina96/blockly/branches{/branch}","tags_url":"https://api.github.com/repos/quachtina96/blockly/tags","blobs_url":"https://api.github.com/repos/quachtina96/blockly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/quachtina96/blockly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/quachtina96/blockly/git/refs{/sha}","trees_url":"https://api.github.com/repos/quachtina96/blockly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/quachtina96/blockly/statuses/{sha}","languages_url":"https://api.github.com/repos/quachtina96/blockly/languages","stargazers_url":"https://api.github.com/repos/quachtina96/blockly/stargazers","contributors_url":"https://api.github.com/repos/quachtina96/blockly/contributors","subscribers_url":"https://api.github.com/repos/quachtina96/blockly/subscribers","subscription_url":"https://api.github.com/repos/quachtina96/blockly/subscription","commits_url":"https://api.github.com/repos/quachtina96/blockly/commits{/sha}","git_commits_url":"https://api.github.com/repos/quachtina96/blockly/git/commits{/sha}","comments_url":"https://api.github.com/repos/quachtina96/blockly/comments{/number}","issue_comment_url":"https://api.github.com/repos/quachtina96/blockly/issues/comments{/number}","contents_url":"https://api.github.com/repos/quachtina96/blockly/contents/{+path}","compare_url":"https://api.github.com/repos/quachtina96/blockly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/quachtina96/blockly/merges","archive_url":"https://api.github.com/repos/quachtina96/blockly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/quachtina96/blockly/downloads","issues_url":"https://api.github.com/repos/quachtina96/blockly/issues{/number}","pulls_url":"https://api.github.com/repos/quachtina96/blockly/pulls{/number}","milestones_url":"https://api.github.com/repos/quachtina96/blockly/milestones{/number}","notifications_url":"https://api.github.com/repos/quachtina96/blockly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/quachtina96/blockly/labels{/name}","releases_url":"https://api.github.com/repos/quachtina96/blockly/releases{/id}","deployments_url":"https://api.github.com/repos/quachtina96/blockly/deployments","created_at":"2016-06-17T06:12:22Z","updated_at":"2016-06-17T06:12:25Z","pushed_at":"2016-08-12T04:30:30Z","git_url":"git://github.com/quachtina96/blockly.git","ssh_url":"git@github.com:quachtina96/blockly.git","clone_url":"https://github.com/quachtina96/blockly.git","svn_url":"https://github.com/quachtina96/blockly","homepage":"https://developers.google.com/blockly/","size":71761,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:develop","ref":"develop","sha":"3a1d9cdec11232d5a645ba48df81ff6d99a281eb","user":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":13872231,"name":"blockly","full_name":"google/blockly","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/blockly","description":"The web-based visual programming editor.","fork":false,"url":"https://api.github.com/repos/google/blockly","forks_url":"https://api.github.com/repos/google/blockly/forks","keys_url":"https://api.github.com/repos/google/blockly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/blockly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/blockly/teams","hooks_url":"https://api.github.com/repos/google/blockly/hooks","issue_events_url":"https://api.github.com/repos/google/blockly/issues/events{/number}","events_url":"https://api.github.com/repos/google/blockly/events","assignees_url":"https://api.github.com/repos/google/blockly/assignees{/user}","branches_url":"https://api.github.com/repos/google/blockly/branches{/branch}","tags_url":"https://api.github.com/repos/google/blockly/tags","blobs_url":"https://api.github.com/repos/google/blockly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/blockly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/blockly/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/blockly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/blockly/statuses/{sha}","languages_url":"https://api.github.com/repos/google/blockly/languages","stargazers_url":"https://api.github.com/repos/google/blockly/stargazers","contributors_url":"https://api.github.com/repos/google/blockly/contributors","subscribers_url":"https://api.github.com/repos/google/blockly/subscribers","subscription_url":"https://api.github.com/repos/google/blockly/subscription","commits_url":"https://api.github.com/repos/google/blockly/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/blockly/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/blockly/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/blockly/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/blockly/contents/{+path}","compare_url":"https://api.github.com/repos/google/blockly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/blockly/merges","archive_url":"https://api.github.com/repos/google/blockly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/blockly/downloads","issues_url":"https://api.github.com/repos/google/blockly/issues{/number}","pulls_url":"https://api.github.com/repos/google/blockly/pulls{/number}","milestones_url":"https://api.github.com/repos/google/blockly/milestones{/number}","notifications_url":"https://api.github.com/repos/google/blockly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/blockly/labels{/name}","releases_url":"https://api.github.com/repos/google/blockly/releases{/id}","deployments_url":"https://api.github.com/repos/google/blockly/deployments","created_at":"2013-10-25T21:13:33Z","updated_at":"2016-08-12T08:55:24Z","pushed_at":"2016-08-12T17:40:24Z","git_url":"git://github.com/google/blockly.git","ssh_url":"git@github.com:google/blockly.git","clone_url":"https://github.com/google/blockly.git","svn_url":"https://github.com/google/blockly","homepage":"https://developers.google.com/blockly/","size":107295,"stargazers_count":2534,"watchers_count":2534,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":857,"mirror_url":null,"open_issues_count":124,"forks":857,"open_issues":124,"watchers":2534,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/blockly/pulls/535"},"html":{"href":"https://github.com/google/blockly/pull/535"},"issue":{"href":"https://api.github.com/repos/google/blockly/issues/535"},"comments":{"href":"https://api.github.com/repos/google/blockly/issues/535/comments"},"review_comments":{"href":"https://api.github.com/repos/google/blockly/pulls/535/comments"},"review_comment":{"href":"https://api.github.com/repos/google/blockly/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/blockly/pulls/535/commits"},"statuses":{"href":"https://api.github.com/repos/google/blockly/statuses/fcb3d3ebdc5c7b39c2b231e14520f3fd9158a9b8"}}}}
{"actor":{"display_login":"picklesrus"}}