{"action":"created","comment":{"url":"https://api.github.com/repos/opencontainers/image-spec/pulls/comments/92508825","pull_request_review_id":13026171,"id":92508825,"diff_hunk":"@@ -0,0 +1,62 @@\n+// Copyright 2016 The Linux Foundation\n+//\n+// Licensed under the Apache License, Version 2.0 (the \"License\");\n+// you may not use this file except in compliance with the License.\n+// You may obtain a copy of the License at\n+//\n+//     http://www.apache.org/licenses/LICENSE-2.0\n+//\n+// Unless required by applicable law or agreed to in writing, software\n+// distributed under the License is distributed on an \"AS IS\" BASIS,\n+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+// See the License for the specific language governing permissions and\n+// limitations under the License.\n+\n+// Package chain provides implementations of the ChainID calculation used in\n+// identifying the result of subsequent layer applications.\n+package chain\n+\n+import \"github.com/docker/distribution/digest\"","path":"specs-go/chain/chainid.go","position":19,"original_position":19,"commit_id":"45ca19ace738ae389edd757f5ac9b0e7f4d66997","original_commit_id":"45ca19ace738ae389edd757f5ac9b0e7f4d66997","user":{"login":"stevvooe","id":120601,"avatar_url":"https://avatars.githubusercontent.com/u/120601?v=3","gravatar_id":"","url":"https://api.github.com/users/stevvooe","html_url":"https://github.com/stevvooe","followers_url":"https://api.github.com/users/stevvooe/followers","following_url":"https://api.github.com/users/stevvooe/following{/other_user}","gists_url":"https://api.github.com/users/stevvooe/gists{/gist_id}","starred_url":"https://api.github.com/users/stevvooe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevvooe/subscriptions","organizations_url":"https://api.github.com/users/stevvooe/orgs","repos_url":"https://api.github.com/users/stevvooe/repos","events_url":"https://api.github.com/users/stevvooe/events{/privacy}","received_events_url":"https://api.github.com/users/stevvooe/received_events","type":"User","site_admin":false},"body":"Given we have a solid package and mature implementation, I'm thinking that we can bring the `distribution/digest` into OCI. I'm seeing some disconcerting patterns being propagated that this package solves.","created_at":"2016-12-14T22:53:15Z","updated_at":"2016-12-14T22:53:15Z","html_url":"https://github.com/opencontainers/image-spec/pull/486#discussion_r92508825","pull_request_url":"https://api.github.com/repos/opencontainers/image-spec/pulls/486","_links":{"self":{"href":"https://api.github.com/repos/opencontainers/image-spec/pulls/comments/92508825"},"html":{"href":"https://github.com/opencontainers/image-spec/pull/486#discussion_r92508825"},"pull_request":{"href":"https://api.github.com/repos/opencontainers/image-spec/pulls/486"}}},"pull_request":{"url":"https://api.github.com/repos/opencontainers/image-spec/pulls/486","id":97206177,"html_url":"https://github.com/opencontainers/image-spec/pull/486","diff_url":"https://github.com/opencontainers/image-spec/pull/486.diff","patch_url":"https://github.com/opencontainers/image-spec/pull/486.patch","issue_url":"https://api.github.com/repos/opencontainers/image-spec/issues/486","number":486,"state":"open","locked":false,"title":"chain: add implementation of ChainID","user":{"login":"stevvooe","id":120601,"avatar_url":"https://avatars.githubusercontent.com/u/120601?v=3","gravatar_id":"","url":"https://api.github.com/users/stevvooe","html_url":"https://github.com/stevvooe","followers_url":"https://api.github.com/users/stevvooe/followers","following_url":"https://api.github.com/users/stevvooe/following{/other_user}","gists_url":"https://api.github.com/users/stevvooe/gists{/gist_id}","starred_url":"https://api.github.com/users/stevvooe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevvooe/subscriptions","organizations_url":"https://api.github.com/users/stevvooe/orgs","repos_url":"https://api.github.com/users/stevvooe/repos","events_url":"https://api.github.com/users/stevvooe/events{/privacy}","received_events_url":"https://api.github.com/users/stevvooe/received_events","type":"User","site_admin":false},"body":"The specification defines an algorithm to calculate a `ChainID`, which\r\ncan be used to identify the result of subsequent applications of layers.\r\nBecause this algorithm is subtle and only needs to implemented in a\r\nsingle place, we provide a reference implementation.\r\n\r\nFor convenience, we provide functions that calculate all the chain ids\r\nand just the top-level one. It is is integrated with the\r\ndistribution/digest type for safety and convenience.\r\n\r\nTests are formulated based on pre-calculation of chain identifiers to\r\nensure correctness.\r\n\r\nSigned-off-by: Stephen J Day <stephen.day@docker.com>\r\n\r\nRelates to #482.\r\nRequires #487.","created_at":"2016-12-08T21:40:08Z","updated_at":"2016-12-14T22:53:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"17b6e28604a8be191b213d4d549799d5d8ba00e7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/opencontainers/image-spec/pulls/486/commits","review_comments_url":"https://api.github.com/repos/opencontainers/image-spec/pulls/486/comments","review_comment_url":"https://api.github.com/repos/opencontainers/image-spec/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opencontainers/image-spec/issues/486/comments","statuses_url":"https://api.github.com/repos/opencontainers/image-spec/statuses/45ca19ace738ae389edd757f5ac9b0e7f4d66997","head":{"label":"stevvooe:chainid-implementation","ref":"chainid-implementation","sha":"45ca19ace738ae389edd757f5ac9b0e7f4d66997","user":{"login":"stevvooe","id":120601,"avatar_url":"https://avatars.githubusercontent.com/u/120601?v=3","gravatar_id":"","url":"https://api.github.com/users/stevvooe","html_url":"https://github.com/stevvooe","followers_url":"https://api.github.com/users/stevvooe/followers","following_url":"https://api.github.com/users/stevvooe/following{/other_user}","gists_url":"https://api.github.com/users/stevvooe/gists{/gist_id}","starred_url":"https://api.github.com/users/stevvooe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevvooe/subscriptions","organizations_url":"https://api.github.com/users/stevvooe/orgs","repos_url":"https://api.github.com/users/stevvooe/repos","events_url":"https://api.github.com/users/stevvooe/events{/privacy}","received_events_url":"https://api.github.com/users/stevvooe/received_events","type":"User","site_admin":false},"repo":{"id":56352084,"name":"image-spec","full_name":"stevvooe/image-spec","owner":{"login":"stevvooe","id":120601,"avatar_url":"https://avatars.githubusercontent.com/u/120601?v=3","gravatar_id":"","url":"https://api.github.com/users/stevvooe","html_url":"https://github.com/stevvooe","followers_url":"https://api.github.com/users/stevvooe/followers","following_url":"https://api.github.com/users/stevvooe/following{/other_user}","gists_url":"https://api.github.com/users/stevvooe/gists{/gist_id}","starred_url":"https://api.github.com/users/stevvooe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevvooe/subscriptions","organizations_url":"https://api.github.com/users/stevvooe/orgs","repos_url":"https://api.github.com/users/stevvooe/repos","events_url":"https://api.github.com/users/stevvooe/events{/privacy}","received_events_url":"https://api.github.com/users/stevvooe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stevvooe/image-spec","description":"OCI Image Format","fork":true,"url":"https://api.github.com/repos/stevvooe/image-spec","forks_url":"https://api.github.com/repos/stevvooe/image-spec/forks","keys_url":"https://api.github.com/repos/stevvooe/image-spec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stevvooe/image-spec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stevvooe/image-spec/teams","hooks_url":"https://api.github.com/repos/stevvooe/image-spec/hooks","issue_events_url":"https://api.github.com/repos/stevvooe/image-spec/issues/events{/number}","events_url":"https://api.github.com/repos/stevvooe/image-spec/events","assignees_url":"https://api.github.com/repos/stevvooe/image-spec/assignees{/user}","branches_url":"https://api.github.com/repos/stevvooe/image-spec/branches{/branch}","tags_url":"https://api.github.com/repos/stevvooe/image-spec/tags","blobs_url":"https://api.github.com/repos/stevvooe/image-spec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stevvooe/image-spec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stevvooe/image-spec/git/refs{/sha}","trees_url":"https://api.github.com/repos/stevvooe/image-spec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stevvooe/image-spec/statuses/{sha}","languages_url":"https://api.github.com/repos/stevvooe/image-spec/languages","stargazers_url":"https://api.github.com/repos/stevvooe/image-spec/stargazers","contributors_url":"https://api.github.com/repos/stevvooe/image-spec/contributors","subscribers_url":"https://api.github.com/repos/stevvooe/image-spec/subscribers","subscription_url":"https://api.github.com/repos/stevvooe/image-spec/subscription","commits_url":"https://api.github.com/repos/stevvooe/image-spec/commits{/sha}","git_commits_url":"https://api.github.com/repos/stevvooe/image-spec/git/commits{/sha}","comments_url":"https://api.github.com/repos/stevvooe/image-spec/comments{/number}","issue_comment_url":"https://api.github.com/repos/stevvooe/image-spec/issues/comments{/number}","contents_url":"https://api.github.com/repos/stevvooe/image-spec/contents/{+path}","compare_url":"https://api.github.com/repos/stevvooe/image-spec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stevvooe/image-spec/merges","archive_url":"https://api.github.com/repos/stevvooe/image-spec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stevvooe/image-spec/downloads","issues_url":"https://api.github.com/repos/stevvooe/image-spec/issues{/number}","pulls_url":"https://api.github.com/repos/stevvooe/image-spec/pulls{/number}","milestones_url":"https://api.github.com/repos/stevvooe/image-spec/milestones{/number}","notifications_url":"https://api.github.com/repos/stevvooe/image-spec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stevvooe/image-spec/labels{/name}","releases_url":"https://api.github.com/repos/stevvooe/image-spec/releases{/id}","deployments_url":"https://api.github.com/repos/stevvooe/image-spec/deployments","created_at":"2016-04-15T21:56:19Z","updated_at":"2016-04-15T21:56:19Z","pushed_at":"2016-12-14T22:15:58Z","git_url":"git://github.com/stevvooe/image-spec.git","ssh_url":"git@github.com:stevvooe/image-spec.git","clone_url":"https://github.com/stevvooe/image-spec.git","svn_url":"https://github.com/stevvooe/image-spec","homepage":"https://www.opencontainers.org/","size":1013,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"opencontainers:master","ref":"master","sha":"656fb2f82121e8bd611b5aae4a6a3471e1bfe078","user":{"login":"opencontainers","id":12563465,"avatar_url":"https://avatars.githubusercontent.com/u/12563465?v=3","gravatar_id":"","url":"https://api.github.com/users/opencontainers","html_url":"https://github.com/opencontainers","followers_url":"https://api.github.com/users/opencontainers/followers","following_url":"https://api.github.com/users/opencontainers/following{/other_user}","gists_url":"https://api.github.com/users/opencontainers/gists{/gist_id}","starred_url":"https://api.github.com/users/opencontainers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opencontainers/subscriptions","organizations_url":"https://api.github.com/users/opencontainers/orgs","repos_url":"https://api.github.com/users/opencontainers/repos","events_url":"https://api.github.com/users/opencontainers/events{/privacy}","received_events_url":"https://api.github.com/users/opencontainers/received_events","type":"Organization","site_admin":false},"repo":{"id":54503347,"name":"image-spec","full_name":"opencontainers/image-spec","owner":{"login":"opencontainers","id":12563465,"avatar_url":"https://avatars.githubusercontent.com/u/12563465?v=3","gravatar_id":"","url":"https://api.github.com/users/opencontainers","html_url":"https://github.com/opencontainers","followers_url":"https://api.github.com/users/opencontainers/followers","following_url":"https://api.github.com/users/opencontainers/following{/other_user}","gists_url":"https://api.github.com/users/opencontainers/gists{/gist_id}","starred_url":"https://api.github.com/users/opencontainers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opencontainers/subscriptions","organizations_url":"https://api.github.com/users/opencontainers/orgs","repos_url":"https://api.github.com/users/opencontainers/repos","events_url":"https://api.github.com/users/opencontainers/events{/privacy}","received_events_url":"https://api.github.com/users/opencontainers/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opencontainers/image-spec","description":"OCI Image Format","fork":false,"url":"https://api.github.com/repos/opencontainers/image-spec","forks_url":"https://api.github.com/repos/opencontainers/image-spec/forks","keys_url":"https://api.github.com/repos/opencontainers/image-spec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opencontainers/image-spec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opencontainers/image-spec/teams","hooks_url":"https://api.github.com/repos/opencontainers/image-spec/hooks","issue_events_url":"https://api.github.com/repos/opencontainers/image-spec/issues/events{/number}","events_url":"https://api.github.com/repos/opencontainers/image-spec/events","assignees_url":"https://api.github.com/repos/opencontainers/image-spec/assignees{/user}","branches_url":"https://api.github.com/repos/opencontainers/image-spec/branches{/branch}","tags_url":"https://api.github.com/repos/opencontainers/image-spec/tags","blobs_url":"https://api.github.com/repos/opencontainers/image-spec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opencontainers/image-spec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opencontainers/image-spec/git/refs{/sha}","trees_url":"https://api.github.com/repos/opencontainers/image-spec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opencontainers/image-spec/statuses/{sha}","languages_url":"https://api.github.com/repos/opencontainers/image-spec/languages","stargazers_url":"https://api.github.com/repos/opencontainers/image-spec/stargazers","contributors_url":"https://api.github.com/repos/opencontainers/image-spec/contributors","subscribers_url":"https://api.github.com/repos/opencontainers/image-spec/subscribers","subscription_url":"https://api.github.com/repos/opencontainers/image-spec/subscription","commits_url":"https://api.github.com/repos/opencontainers/image-spec/commits{/sha}","git_commits_url":"https://api.github.com/repos/opencontainers/image-spec/git/commits{/sha}","comments_url":"https://api.github.com/repos/opencontainers/image-spec/comments{/number}","issue_comment_url":"https://api.github.com/repos/opencontainers/image-spec/issues/comments{/number}","contents_url":"https://api.github.com/repos/opencontainers/image-spec/contents/{+path}","compare_url":"https://api.github.com/repos/opencontainers/image-spec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opencontainers/image-spec/merges","archive_url":"https://api.github.com/repos/opencontainers/image-spec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opencontainers/image-spec/downloads","issues_url":"https://api.github.com/repos/opencontainers/image-spec/issues{/number}","pulls_url":"https://api.github.com/repos/opencontainers/image-spec/pulls{/number}","milestones_url":"https://api.github.com/repos/opencontainers/image-spec/milestones{/number}","notifications_url":"https://api.github.com/repos/opencontainers/image-spec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opencontainers/image-spec/labels{/name}","releases_url":"https://api.github.com/repos/opencontainers/image-spec/releases{/id}","deployments_url":"https://api.github.com/repos/opencontainers/image-spec/deployments","created_at":"2016-03-22T19:34:41Z","updated_at":"2016-12-14T20:11:00Z","pushed_at":"2016-12-14T22:00:50Z","git_url":"git://github.com/opencontainers/image-spec.git","ssh_url":"git@github.com:opencontainers/image-spec.git","clone_url":"https://github.com/opencontainers/image-spec.git","svn_url":"https://github.com/opencontainers/image-spec","homepage":"https://www.opencontainers.org/","size":1837,"stargazers_count":167,"watchers_count":167,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":47,"mirror_url":null,"open_issues_count":66,"forks":47,"open_issues":66,"watchers":167,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opencontainers/image-spec/pulls/486"},"html":{"href":"https://github.com/opencontainers/image-spec/pull/486"},"issue":{"href":"https://api.github.com/repos/opencontainers/image-spec/issues/486"},"comments":{"href":"https://api.github.com/repos/opencontainers/image-spec/issues/486/comments"},"review_comments":{"href":"https://api.github.com/repos/opencontainers/image-spec/pulls/486/comments"},"review_comment":{"href":"https://api.github.com/repos/opencontainers/image-spec/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opencontainers/image-spec/pulls/486/commits"},"statuses":{"href":"https://api.github.com/repos/opencontainers/image-spec/statuses/45ca19ace738ae389edd757f5ac9b0e7f4d66997"}}}}
{"actor":{"display_login":"stevvooe"}}