{"action":"closed","number":5739,"pull_request":{"url":"https://api.github.com/repos/brave/browser-laptop/pulls/5739","id":94480147,"html_url":"https://github.com/brave/browser-laptop/pull/5739","diff_url":"https://github.com/brave/browser-laptop/pull/5739.diff","patch_url":"https://github.com/brave/browser-laptop/pull/5739.patch","issue_url":"https://api.github.com/repos/brave/browser-laptop/issues/5739","number":5739,"state":"closed","locked":false,"title":"Aligned the bookmark icon on the navbar","user":{"login":"luixxiul","id":3362943,"avatar_url":"https://avatars.githubusercontent.com/u/3362943?v=3","gravatar_id":"","url":"https://api.github.com/users/luixxiul","html_url":"https://github.com/luixxiul","followers_url":"https://api.github.com/users/luixxiul/followers","following_url":"https://api.github.com/users/luixxiul/following{/other_user}","gists_url":"https://api.github.com/users/luixxiul/gists{/gist_id}","starred_url":"https://api.github.com/users/luixxiul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luixxiul/subscriptions","organizations_url":"https://api.github.com/users/luixxiul/orgs","repos_url":"https://api.github.com/users/luixxiul/repos","events_url":"https://api.github.com/users/luixxiul/events{/privacy}","received_events_url":"https://api.github.com/users/luixxiul/received_events","type":"User","site_admin":false},"body":"- [x] Submitted a [ticket](https://github.com/brave/browser-laptop/issues) for my issue if one did not already exist.\r\n- [x] Used Github [auto-closing keywords](https://help.github.com/articles/closing-issues-via-commit-messages/) in the commit message.\r\n- [x] Added/updated tests for this change (for new code or code which already has tests).\r\n- [x] Ran `git rebase -i` to squash commits (if needed).\r\n\r\nThis PR addresses the issue which was caused by introducing SVG toolbar icons and placing them with pixels, by removing margins around the bookmark icon and setting `background-size`.\r\n\r\nFixes #5632\r\n\r\nAuditors: @bradleyrichter\r\n\r\nTest Plan: make sure the bookmark icon is properly aligned on each platforms\r\n\r\nImage 1: on Ubuntu\r\n![pasted image at 2016_11_03 01_37 pm](https://cloud.githubusercontent.com/assets/3362943/20455330/b76a0456-ae9c-11e6-8589-36a09b232a03.png)\r\n\r\nImage 2: on macOS\r\n<img width=\"193\" alt=\"screenshot 2016-11-19 21 12 26\" src=\"https://cloud.githubusercontent.com/assets/3362943/20455350/01976c80-ae9d-11e6-8933-826a22121091.png\">\r\n\r\nRelated: #5173 #4852","created_at":"2016-11-19T12:12:07Z","updated_at":"2016-11-29T02:31:59Z","closed_at":"2016-11-29T02:31:59Z","merged_at":"2016-11-29T02:31:59Z","merge_commit_sha":"34783b02cd7aea2e4980658da3f980ac938b7ccf","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/brave/browser-laptop/milestones/45","html_url":"https://github.com/brave/browser-laptop/milestones/0.13.0","labels_url":"https://api.github.com/repos/brave/browser-laptop/milestones/45/labels","id":2117716,"number":45,"title":"0.13.0","description":"Freeze Nov. 28\r\nFeatured: WebTorrent, Chromium 54 ","creator":{"login":"bbondy","id":831718,"avatar_url":"https://avatars.githubusercontent.com/u/831718?v=3","gravatar_id":"","url":"https://api.github.com/users/bbondy","html_url":"https://github.com/bbondy","followers_url":"https://api.github.com/users/bbondy/followers","following_url":"https://api.github.com/users/bbondy/following{/other_user}","gists_url":"https://api.github.com/users/bbondy/gists{/gist_id}","starred_url":"https://api.github.com/users/bbondy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbondy/subscriptions","organizations_url":"https://api.github.com/users/bbondy/orgs","repos_url":"https://api.github.com/users/bbondy/repos","events_url":"https://api.github.com/users/bbondy/events{/privacy}","received_events_url":"https://api.github.com/users/bbondy/received_events","type":"User","site_admin":false},"open_issues":34,"closed_issues":69,"state":"open","created_at":"2016-11-07T01:52:19Z","updated_at":"2016-11-29T02:31:59Z","due_on":"2016-11-30T00:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/brave/browser-laptop/pulls/5739/commits","review_comments_url":"https://api.github.com/repos/brave/browser-laptop/pulls/5739/comments","review_comment_url":"https://api.github.com/repos/brave/browser-laptop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/brave/browser-laptop/issues/5739/comments","statuses_url":"https://api.github.com/repos/brave/browser-laptop/statuses/8c3df600fbb55cbdec844aba750d5a8fdfca228b","head":{"label":"luixxiul:bookmark-icon-alignment","ref":"bookmark-icon-alignment","sha":"8c3df600fbb55cbdec844aba750d5a8fdfca228b","user":{"login":"luixxiul","id":3362943,"avatar_url":"https://avatars.githubusercontent.com/u/3362943?v=3","gravatar_id":"","url":"https://api.github.com/users/luixxiul","html_url":"https://github.com/luixxiul","followers_url":"https://api.github.com/users/luixxiul/followers","following_url":"https://api.github.com/users/luixxiul/following{/other_user}","gists_url":"https://api.github.com/users/luixxiul/gists{/gist_id}","starred_url":"https://api.github.com/users/luixxiul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luixxiul/subscriptions","organizations_url":"https://api.github.com/users/luixxiul/orgs","repos_url":"https://api.github.com/users/luixxiul/repos","events_url":"https://api.github.com/users/luixxiul/events{/privacy}","received_events_url":"https://api.github.com/users/luixxiul/received_events","type":"User","site_admin":false},"repo":{"id":59339519,"name":"browser-laptop","full_name":"luixxiul/browser-laptop","owner":{"login":"luixxiul","id":3362943,"avatar_url":"https://avatars.githubusercontent.com/u/3362943?v=3","gravatar_id":"","url":"https://api.github.com/users/luixxiul","html_url":"https://github.com/luixxiul","followers_url":"https://api.github.com/users/luixxiul/followers","following_url":"https://api.github.com/users/luixxiul/following{/other_user}","gists_url":"https://api.github.com/users/luixxiul/gists{/gist_id}","starred_url":"https://api.github.com/users/luixxiul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luixxiul/subscriptions","organizations_url":"https://api.github.com/users/luixxiul/orgs","repos_url":"https://api.github.com/users/luixxiul/repos","events_url":"https://api.github.com/users/luixxiul/events{/privacy}","received_events_url":"https://api.github.com/users/luixxiul/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/luixxiul/browser-laptop","description":"Forked repo","fork":true,"url":"https://api.github.com/repos/luixxiul/browser-laptop","forks_url":"https://api.github.com/repos/luixxiul/browser-laptop/forks","keys_url":"https://api.github.com/repos/luixxiul/browser-laptop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/luixxiul/browser-laptop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/luixxiul/browser-laptop/teams","hooks_url":"https://api.github.com/repos/luixxiul/browser-laptop/hooks","issue_events_url":"https://api.github.com/repos/luixxiul/browser-laptop/issues/events{/number}","events_url":"https://api.github.com/repos/luixxiul/browser-laptop/events","assignees_url":"https://api.github.com/repos/luixxiul/browser-laptop/assignees{/user}","branches_url":"https://api.github.com/repos/luixxiul/browser-laptop/branches{/branch}","tags_url":"https://api.github.com/repos/luixxiul/browser-laptop/tags","blobs_url":"https://api.github.com/repos/luixxiul/browser-laptop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/luixxiul/browser-laptop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/luixxiul/browser-laptop/git/refs{/sha}","trees_url":"https://api.github.com/repos/luixxiul/browser-laptop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/luixxiul/browser-laptop/statuses/{sha}","languages_url":"https://api.github.com/repos/luixxiul/browser-laptop/languages","stargazers_url":"https://api.github.com/repos/luixxiul/browser-laptop/stargazers","contributors_url":"https://api.github.com/repos/luixxiul/browser-laptop/contributors","subscribers_url":"https://api.github.com/repos/luixxiul/browser-laptop/subscribers","subscription_url":"https://api.github.com/repos/luixxiul/browser-laptop/subscription","commits_url":"https://api.github.com/repos/luixxiul/browser-laptop/commits{/sha}","git_commits_url":"https://api.github.com/repos/luixxiul/browser-laptop/git/commits{/sha}","comments_url":"https://api.github.com/repos/luixxiul/browser-laptop/comments{/number}","issue_comment_url":"https://api.github.com/repos/luixxiul/browser-laptop/issues/comments{/number}","contents_url":"https://api.github.com/repos/luixxiul/browser-laptop/contents/{+path}","compare_url":"https://api.github.com/repos/luixxiul/browser-laptop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/luixxiul/browser-laptop/merges","archive_url":"https://api.github.com/repos/luixxiul/browser-laptop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/luixxiul/browser-laptop/downloads","issues_url":"https://api.github.com/repos/luixxiul/browser-laptop/issues{/number}","pulls_url":"https://api.github.com/repos/luixxiul/browser-laptop/pulls{/number}","milestones_url":"https://api.github.com/repos/luixxiul/browser-laptop/milestones{/number}","notifications_url":"https://api.github.com/repos/luixxiul/browser-laptop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/luixxiul/browser-laptop/labels{/name}","releases_url":"https://api.github.com/repos/luixxiul/browser-laptop/releases{/id}","deployments_url":"https://api.github.com/repos/luixxiul/browser-laptop/deployments","created_at":"2016-05-21T03:21:58Z","updated_at":"2016-10-28T05:13:30Z","pushed_at":"2016-11-29T02:30:39Z","git_url":"git://github.com/luixxiul/browser-laptop.git","ssh_url":"git@github.com:luixxiul/browser-laptop.git","clone_url":"https://github.com/luixxiul/browser-laptop.git","svn_url":"https://github.com/luixxiul/browser-laptop","homepage":"","size":39212,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"brave:master","ref":"master","sha":"7b7772009f67e480fed7db63cf53ef6274ce00ed","user":{"login":"brave","id":12301619,"avatar_url":"https://avatars.githubusercontent.com/u/12301619?v=3","gravatar_id":"","url":"https://api.github.com/users/brave","html_url":"https://github.com/brave","followers_url":"https://api.github.com/users/brave/followers","following_url":"https://api.github.com/users/brave/following{/other_user}","gists_url":"https://api.github.com/users/brave/gists{/gist_id}","starred_url":"https://api.github.com/users/brave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brave/subscriptions","organizations_url":"https://api.github.com/users/brave/orgs","repos_url":"https://api.github.com/users/brave/repos","events_url":"https://api.github.com/users/brave/events{/privacy}","received_events_url":"https://api.github.com/users/brave/received_events","type":"Organization","site_admin":false},"repo":{"id":46891997,"name":"browser-laptop","full_name":"brave/browser-laptop","owner":{"login":"brave","id":12301619,"avatar_url":"https://avatars.githubusercontent.com/u/12301619?v=3","gravatar_id":"","url":"https://api.github.com/users/brave","html_url":"https://github.com/brave","followers_url":"https://api.github.com/users/brave/followers","following_url":"https://api.github.com/users/brave/following{/other_user}","gists_url":"https://api.github.com/users/brave/gists{/gist_id}","starred_url":"https://api.github.com/users/brave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brave/subscriptions","organizations_url":"https://api.github.com/users/brave/orgs","repos_url":"https://api.github.com/users/brave/repos","events_url":"https://api.github.com/users/brave/events{/privacy}","received_events_url":"https://api.github.com/users/brave/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/brave/browser-laptop","description":"Brave browser for Desktop and Laptop computers running Windows, OSX, and Linux","fork":false,"url":"https://api.github.com/repos/brave/browser-laptop","forks_url":"https://api.github.com/repos/brave/browser-laptop/forks","keys_url":"https://api.github.com/repos/brave/browser-laptop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brave/browser-laptop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brave/browser-laptop/teams","hooks_url":"https://api.github.com/repos/brave/browser-laptop/hooks","issue_events_url":"https://api.github.com/repos/brave/browser-laptop/issues/events{/number}","events_url":"https://api.github.com/repos/brave/browser-laptop/events","assignees_url":"https://api.github.com/repos/brave/browser-laptop/assignees{/user}","branches_url":"https://api.github.com/repos/brave/browser-laptop/branches{/branch}","tags_url":"https://api.github.com/repos/brave/browser-laptop/tags","blobs_url":"https://api.github.com/repos/brave/browser-laptop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brave/browser-laptop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brave/browser-laptop/git/refs{/sha}","trees_url":"https://api.github.com/repos/brave/browser-laptop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brave/browser-laptop/statuses/{sha}","languages_url":"https://api.github.com/repos/brave/browser-laptop/languages","stargazers_url":"https://api.github.com/repos/brave/browser-laptop/stargazers","contributors_url":"https://api.github.com/repos/brave/browser-laptop/contributors","subscribers_url":"https://api.github.com/repos/brave/browser-laptop/subscribers","subscription_url":"https://api.github.com/repos/brave/browser-laptop/subscription","commits_url":"https://api.github.com/repos/brave/browser-laptop/commits{/sha}","git_commits_url":"https://api.github.com/repos/brave/browser-laptop/git/commits{/sha}","comments_url":"https://api.github.com/repos/brave/browser-laptop/comments{/number}","issue_comment_url":"https://api.github.com/repos/brave/browser-laptop/issues/comments{/number}","contents_url":"https://api.github.com/repos/brave/browser-laptop/contents/{+path}","compare_url":"https://api.github.com/repos/brave/browser-laptop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brave/browser-laptop/merges","archive_url":"https://api.github.com/repos/brave/browser-laptop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brave/browser-laptop/downloads","issues_url":"https://api.github.com/repos/brave/browser-laptop/issues{/number}","pulls_url":"https://api.github.com/repos/brave/browser-laptop/pulls{/number}","milestones_url":"https://api.github.com/repos/brave/browser-laptop/milestones{/number}","notifications_url":"https://api.github.com/repos/brave/browser-laptop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brave/browser-laptop/labels{/name}","releases_url":"https://api.github.com/repos/brave/browser-laptop/releases{/id}","deployments_url":"https://api.github.com/repos/brave/browser-laptop/deployments","created_at":"2015-11-25T22:55:10Z","updated_at":"2016-11-28T19:48:37Z","pushed_at":"2016-11-29T02:31:59Z","git_url":"git://github.com/brave/browser-laptop.git","ssh_url":"git@github.com:brave/browser-laptop.git","clone_url":"https://github.com/brave/browser-laptop.git","svn_url":"https://github.com/brave/browser-laptop","homepage":"https://www.brave.com","size":47159,"stargazers_count":3869,"watchers_count":3869,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":442,"mirror_url":null,"open_issues_count":1572,"forks":442,"open_issues":1572,"watchers":3869,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/brave/browser-laptop/pulls/5739"},"html":{"href":"https://github.com/brave/browser-laptop/pull/5739"},"issue":{"href":"https://api.github.com/repos/brave/browser-laptop/issues/5739"},"comments":{"href":"https://api.github.com/repos/brave/browser-laptop/issues/5739/comments"},"review_comments":{"href":"https://api.github.com/repos/brave/browser-laptop/pulls/5739/comments"},"review_comment":{"href":"https://api.github.com/repos/brave/browser-laptop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/brave/browser-laptop/pulls/5739/commits"},"statuses":{"href":"https://api.github.com/repos/brave/browser-laptop/statuses/8c3df600fbb55cbdec844aba750d5a8fdfca228b"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"bbondy","id":831718,"avatar_url":"https://avatars.githubusercontent.com/u/831718?v=3","gravatar_id":"","url":"https://api.github.com/users/bbondy","html_url":"https://github.com/bbondy","followers_url":"https://api.github.com/users/bbondy/followers","following_url":"https://api.github.com/users/bbondy/following{/other_user}","gists_url":"https://api.github.com/users/bbondy/gists{/gist_id}","starred_url":"https://api.github.com/users/bbondy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbondy/subscriptions","organizations_url":"https://api.github.com/users/bbondy/orgs","repos_url":"https://api.github.com/users/bbondy/repos","events_url":"https://api.github.com/users/bbondy/events{/privacy}","received_events_url":"https://api.github.com/users/bbondy/received_events","type":"User","site_admin":false},"comments":6,"review_comments":1,"commits":1,"additions":11,"deletions":8,"changed_files":2}}
{"actor":{"display_login":"bbondy"}}