{"action":"created","comment":{"url":"https://api.github.com/repos/cake-build/cake/pulls/comments/84591988","pull_request_review_id":5361888,"id":84591988,"diff_hunk":"@@ -802,6 +802,69 @@ public void Should_Append_Logger_To_Process_Arguments()\n                 Assert.Equal(\"/v:normal /target:Build /logger:B,A;C /logger:E,D /logger:F \" +\n                              \"\\\"/Working/src/Solution.sln\\\"\", result.Args);\n             }\n+\n+            [Fact]\n+            public void Should_Append_FileLogger_To_Process_Arguments()\n+            {\n+                // Given\n+                var fixture = new MSBuildRunnerFixture(false);\n+                fixture.Settings.AddFileLogger(new MSBuildFileLogger { AppendToLogFile = false, Encoding = \"E\", HideVerboseItemAndPropertyList = false, LogFile = \"A\", MSBuildFileLoggerOutput = MSBuildFileLoggerOutput.All, PerformanceSummaryEnabled = false, ShowCommandLine = false, ShowEventId = false, ShowTimestamp = false, SummaryDisabled = false, Verbosity = Verbosity.Diagnostic });\n+\n+                fixture.Settings.AddFileLogger(new MSBuildFileLogger { AppendToLogFile = true, HideVerboseItemAndPropertyList = true, MSBuildFileLoggerOutput = MSBuildFileLoggerOutput.ErrorsOnly, PerformanceSummaryEnabled = true, ShowCommandLine = true, ShowEventId = true, ShowTimestamp = true, SummaryDisabled = true, Verbosity = Verbosity.Minimal });\n+\n+                fixture.Settings.AddFileLogger(new MSBuildFileLogger { MSBuildFileLoggerOutput = MSBuildFileLoggerOutput.WarningsOnly, Verbosity = Verbosity.Normal });\n+\n+                fixture.Settings.AddFileLogger(new MSBuildFileLogger { Verbosity = Verbosity.Quiet });\n+\n+                fixture.Settings.AddFileLogger(new MSBuildFileLogger { Verbosity = Verbosity.Verbose });\n+\n+                fixture.Settings.AddFileLogger(new MSBuildFileLogger { });\n+","path":"src/Cake.Common.Tests/Unit/Tools/MSBuild/MSBuildRunnerTests.cs","position":21,"original_position":21,"commit_id":"4d12531c6c295b47b510c0d1f31ded27d25873a5","original_commit_id":"4d12531c6c295b47b510c0d1f31ded27d25873a5","user":{"login":"patriksvensson","id":357872,"avatar_url":"https://avatars.githubusercontent.com/u/357872?v=3","gravatar_id":"","url":"https://api.github.com/users/patriksvensson","html_url":"https://github.com/patriksvensson","followers_url":"https://api.github.com/users/patriksvensson/followers","following_url":"https://api.github.com/users/patriksvensson/following{/other_user}","gists_url":"https://api.github.com/users/patriksvensson/gists{/gist_id}","starred_url":"https://api.github.com/users/patriksvensson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patriksvensson/subscriptions","organizations_url":"https://api.github.com/users/patriksvensson/orgs","repos_url":"https://api.github.com/users/patriksvensson/repos","events_url":"https://api.github.com/users/patriksvensson/events{/privacy}","received_events_url":"https://api.github.com/users/patriksvensson/received_events","type":"User","site_admin":false},"body":"Remove line break.","created_at":"2016-10-23T08:19:43Z","updated_at":"2016-10-23T08:37:20Z","html_url":"https://github.com/cake-build/cake/pull/1215#discussion_r84591988","pull_request_url":"https://api.github.com/repos/cake-build/cake/pulls/1215","_links":{"self":{"href":"https://api.github.com/repos/cake-build/cake/pulls/comments/84591988"},"html":{"href":"https://github.com/cake-build/cake/pull/1215#discussion_r84591988"},"pull_request":{"href":"https://api.github.com/repos/cake-build/cake/pulls/1215"}}},"pull_request":{"url":"https://api.github.com/repos/cake-build/cake/pulls/1215","id":84567754,"html_url":"https://github.com/cake-build/cake/pull/1215","diff_url":"https://github.com/cake-build/cake/pull/1215.diff","patch_url":"https://github.com/cake-build/cake/pull/1215.patch","issue_url":"https://api.github.com/repos/cake-build/cake/issues/1215","number":1215,"state":"open","locked":false,"title":"GH703: Add FileLogger switches to MSBuild Runner","user":{"login":"bradtwurst","id":310216,"avatar_url":"https://avatars.githubusercontent.com/u/310216?v=3","gravatar_id":"","url":"https://api.github.com/users/bradtwurst","html_url":"https://github.com/bradtwurst","followers_url":"https://api.github.com/users/bradtwurst/followers","following_url":"https://api.github.com/users/bradtwurst/following{/other_user}","gists_url":"https://api.github.com/users/bradtwurst/gists{/gist_id}","starred_url":"https://api.github.com/users/bradtwurst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bradtwurst/subscriptions","organizations_url":"https://api.github.com/users/bradtwurst/orgs","repos_url":"https://api.github.com/users/bradtwurst/repos","events_url":"https://api.github.com/users/bradtwurst/events{/privacy}","received_events_url":"https://api.github.com/users/bradtwurst/received_events","type":"User","site_admin":false},"body":"Addresses issue #703\r\n\r\nProvides the ability to add FileLogger parameters to the MsBuild command\r\nline.  The various fileloggerparameters (flp) can also be specified.\r\n\r\nThe parameters that can be created are /fl, /fl[1 thru 9], /flp, and\r\n/flp[1 thru 9]","created_at":"2016-09-08T22:51:21Z","updated_at":"2016-10-23T08:37:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"44cf69b228cf00a99fc19b4f7a7e4f95b71b2a16","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/cake-build/cake/pulls/1215/commits","review_comments_url":"https://api.github.com/repos/cake-build/cake/pulls/1215/comments","review_comment_url":"https://api.github.com/repos/cake-build/cake/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cake-build/cake/issues/1215/comments","statuses_url":"https://api.github.com/repos/cake-build/cake/statuses/4d12531c6c295b47b510c0d1f31ded27d25873a5","head":{"label":"bradtwurst:develop-msbuild-filelogger","ref":"develop-msbuild-filelogger","sha":"4d12531c6c295b47b510c0d1f31ded27d25873a5","user":{"login":"bradtwurst","id":310216,"avatar_url":"https://avatars.githubusercontent.com/u/310216?v=3","gravatar_id":"","url":"https://api.github.com/users/bradtwurst","html_url":"https://github.com/bradtwurst","followers_url":"https://api.github.com/users/bradtwurst/followers","following_url":"https://api.github.com/users/bradtwurst/following{/other_user}","gists_url":"https://api.github.com/users/bradtwurst/gists{/gist_id}","starred_url":"https://api.github.com/users/bradtwurst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bradtwurst/subscriptions","organizations_url":"https://api.github.com/users/bradtwurst/orgs","repos_url":"https://api.github.com/users/bradtwurst/repos","events_url":"https://api.github.com/users/bradtwurst/events{/privacy}","received_events_url":"https://api.github.com/users/bradtwurst/received_events","type":"User","site_admin":false},"repo":{"id":67719908,"name":"cake","full_name":"bradtwurst/cake","owner":{"login":"bradtwurst","id":310216,"avatar_url":"https://avatars.githubusercontent.com/u/310216?v=3","gravatar_id":"","url":"https://api.github.com/users/bradtwurst","html_url":"https://github.com/bradtwurst","followers_url":"https://api.github.com/users/bradtwurst/followers","following_url":"https://api.github.com/users/bradtwurst/following{/other_user}","gists_url":"https://api.github.com/users/bradtwurst/gists{/gist_id}","starred_url":"https://api.github.com/users/bradtwurst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bradtwurst/subscriptions","organizations_url":"https://api.github.com/users/bradtwurst/orgs","repos_url":"https://api.github.com/users/bradtwurst/repos","events_url":"https://api.github.com/users/bradtwurst/events{/privacy}","received_events_url":"https://api.github.com/users/bradtwurst/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bradtwurst/cake","description":"Cake (C# Make) is a cross platform build automation system.","fork":true,"url":"https://api.github.com/repos/bradtwurst/cake","forks_url":"https://api.github.com/repos/bradtwurst/cake/forks","keys_url":"https://api.github.com/repos/bradtwurst/cake/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bradtwurst/cake/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bradtwurst/cake/teams","hooks_url":"https://api.github.com/repos/bradtwurst/cake/hooks","issue_events_url":"https://api.github.com/repos/bradtwurst/cake/issues/events{/number}","events_url":"https://api.github.com/repos/bradtwurst/cake/events","assignees_url":"https://api.github.com/repos/bradtwurst/cake/assignees{/user}","branches_url":"https://api.github.com/repos/bradtwurst/cake/branches{/branch}","tags_url":"https://api.github.com/repos/bradtwurst/cake/tags","blobs_url":"https://api.github.com/repos/bradtwurst/cake/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bradtwurst/cake/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bradtwurst/cake/git/refs{/sha}","trees_url":"https://api.github.com/repos/bradtwurst/cake/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bradtwurst/cake/statuses/{sha}","languages_url":"https://api.github.com/repos/bradtwurst/cake/languages","stargazers_url":"https://api.github.com/repos/bradtwurst/cake/stargazers","contributors_url":"https://api.github.com/repos/bradtwurst/cake/contributors","subscribers_url":"https://api.github.com/repos/bradtwurst/cake/subscribers","subscription_url":"https://api.github.com/repos/bradtwurst/cake/subscription","commits_url":"https://api.github.com/repos/bradtwurst/cake/commits{/sha}","git_commits_url":"https://api.github.com/repos/bradtwurst/cake/git/commits{/sha}","comments_url":"https://api.github.com/repos/bradtwurst/cake/comments{/number}","issue_comment_url":"https://api.github.com/repos/bradtwurst/cake/issues/comments{/number}","contents_url":"https://api.github.com/repos/bradtwurst/cake/contents/{+path}","compare_url":"https://api.github.com/repos/bradtwurst/cake/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bradtwurst/cake/merges","archive_url":"https://api.github.com/repos/bradtwurst/cake/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bradtwurst/cake/downloads","issues_url":"https://api.github.com/repos/bradtwurst/cake/issues{/number}","pulls_url":"https://api.github.com/repos/bradtwurst/cake/pulls{/number}","milestones_url":"https://api.github.com/repos/bradtwurst/cake/milestones{/number}","notifications_url":"https://api.github.com/repos/bradtwurst/cake/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bradtwurst/cake/labels{/name}","releases_url":"https://api.github.com/repos/bradtwurst/cake/releases{/id}","deployments_url":"https://api.github.com/repos/bradtwurst/cake/deployments","created_at":"2016-09-08T16:16:29Z","updated_at":"2016-09-08T16:16:32Z","pushed_at":"2016-09-09T16:11:14Z","git_url":"git://github.com/bradtwurst/cake.git","ssh_url":"git@github.com:bradtwurst/cake.git","clone_url":"https://github.com/bradtwurst/cake.git","svn_url":"https://github.com/bradtwurst/cake","homepage":"http://cakebuild.net/","size":6125,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"cake-build:develop","ref":"develop","sha":"e9f8f5e06310a5edb653b824ecb6a0d835e1f9fa","user":{"login":"cake-build","id":7738262,"avatar_url":"https://avatars.githubusercontent.com/u/7738262?v=3","gravatar_id":"","url":"https://api.github.com/users/cake-build","html_url":"https://github.com/cake-build","followers_url":"https://api.github.com/users/cake-build/followers","following_url":"https://api.github.com/users/cake-build/following{/other_user}","gists_url":"https://api.github.com/users/cake-build/gists{/gist_id}","starred_url":"https://api.github.com/users/cake-build/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cake-build/subscriptions","organizations_url":"https://api.github.com/users/cake-build/orgs","repos_url":"https://api.github.com/users/cake-build/repos","events_url":"https://api.github.com/users/cake-build/events{/privacy}","received_events_url":"https://api.github.com/users/cake-build/received_events","type":"Organization","site_admin":false},"repo":{"id":20094029,"name":"cake","full_name":"cake-build/cake","owner":{"login":"cake-build","id":7738262,"avatar_url":"https://avatars.githubusercontent.com/u/7738262?v=3","gravatar_id":"","url":"https://api.github.com/users/cake-build","html_url":"https://github.com/cake-build","followers_url":"https://api.github.com/users/cake-build/followers","following_url":"https://api.github.com/users/cake-build/following{/other_user}","gists_url":"https://api.github.com/users/cake-build/gists{/gist_id}","starred_url":"https://api.github.com/users/cake-build/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cake-build/subscriptions","organizations_url":"https://api.github.com/users/cake-build/orgs","repos_url":"https://api.github.com/users/cake-build/repos","events_url":"https://api.github.com/users/cake-build/events{/privacy}","received_events_url":"https://api.github.com/users/cake-build/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cake-build/cake","description":"Cake (C# Make) is a cross platform build automation system.","fork":false,"url":"https://api.github.com/repos/cake-build/cake","forks_url":"https://api.github.com/repos/cake-build/cake/forks","keys_url":"https://api.github.com/repos/cake-build/cake/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cake-build/cake/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cake-build/cake/teams","hooks_url":"https://api.github.com/repos/cake-build/cake/hooks","issue_events_url":"https://api.github.com/repos/cake-build/cake/issues/events{/number}","events_url":"https://api.github.com/repos/cake-build/cake/events","assignees_url":"https://api.github.com/repos/cake-build/cake/assignees{/user}","branches_url":"https://api.github.com/repos/cake-build/cake/branches{/branch}","tags_url":"https://api.github.com/repos/cake-build/cake/tags","blobs_url":"https://api.github.com/repos/cake-build/cake/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cake-build/cake/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cake-build/cake/git/refs{/sha}","trees_url":"https://api.github.com/repos/cake-build/cake/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cake-build/cake/statuses/{sha}","languages_url":"https://api.github.com/repos/cake-build/cake/languages","stargazers_url":"https://api.github.com/repos/cake-build/cake/stargazers","contributors_url":"https://api.github.com/repos/cake-build/cake/contributors","subscribers_url":"https://api.github.com/repos/cake-build/cake/subscribers","subscription_url":"https://api.github.com/repos/cake-build/cake/subscription","commits_url":"https://api.github.com/repos/cake-build/cake/commits{/sha}","git_commits_url":"https://api.github.com/repos/cake-build/cake/git/commits{/sha}","comments_url":"https://api.github.com/repos/cake-build/cake/comments{/number}","issue_comment_url":"https://api.github.com/repos/cake-build/cake/issues/comments{/number}","contents_url":"https://api.github.com/repos/cake-build/cake/contents/{+path}","compare_url":"https://api.github.com/repos/cake-build/cake/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cake-build/cake/merges","archive_url":"https://api.github.com/repos/cake-build/cake/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cake-build/cake/downloads","issues_url":"https://api.github.com/repos/cake-build/cake/issues{/number}","pulls_url":"https://api.github.com/repos/cake-build/cake/pulls{/number}","milestones_url":"https://api.github.com/repos/cake-build/cake/milestones{/number}","notifications_url":"https://api.github.com/repos/cake-build/cake/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cake-build/cake/labels{/name}","releases_url":"https://api.github.com/repos/cake-build/cake/releases{/id}","deployments_url":"https://api.github.com/repos/cake-build/cake/deployments","created_at":"2014-05-23T09:26:54Z","updated_at":"2016-10-22T11:53:54Z","pushed_at":"2016-10-22T21:11:23Z","git_url":"git://github.com/cake-build/cake.git","ssh_url":"git@github.com:cake-build/cake.git","clone_url":"https://github.com/cake-build/cake.git","svn_url":"https://github.com/cake-build/cake","homepage":"http://cakebuild.net/","size":9317,"stargazers_count":877,"watchers_count":877,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":219,"mirror_url":null,"open_issues_count":144,"forks":219,"open_issues":144,"watchers":877,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/cake-build/cake/pulls/1215"},"html":{"href":"https://github.com/cake-build/cake/pull/1215"},"issue":{"href":"https://api.github.com/repos/cake-build/cake/issues/1215"},"comments":{"href":"https://api.github.com/repos/cake-build/cake/issues/1215/comments"},"review_comments":{"href":"https://api.github.com/repos/cake-build/cake/pulls/1215/comments"},"review_comment":{"href":"https://api.github.com/repos/cake-build/cake/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cake-build/cake/pulls/1215/commits"},"statuses":{"href":"https://api.github.com/repos/cake-build/cake/statuses/4d12531c6c295b47b510c0d1f31ded27d25873a5"}}}}
{"actor":{"display_login":"patriksvensson"}}