{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/64465075","id":64465075,"diff_hunk":"@@ -99,3 +99,32 @@ PROVIDER_UTILS=\"${KUBE_ROOT}/cluster/${KUBERNETES_PROVIDER}/util.sh\"\n if [ -f ${PROVIDER_UTILS} ]; then\n     source \"${PROVIDER_UTILS}\"\n fi\n+\n+# Federated utils","path":"cluster/kube-util.sh","position":5,"original_position":5,"commit_id":"783ac48f7093bd7da485100039d6c373fe4607ed","original_commit_id":"783ac48f7093bd7da485100039d6c373fe4607ed","user":{"login":"nikhiljindal","id":10199099,"avatar_url":"https://avatars.githubusercontent.com/u/10199099?v=3","gravatar_id":"","url":"https://api.github.com/users/nikhiljindal","html_url":"https://github.com/nikhiljindal","followers_url":"https://api.github.com/users/nikhiljindal/followers","following_url":"https://api.github.com/users/nikhiljindal/following{/other_user}","gists_url":"https://api.github.com/users/nikhiljindal/gists{/gist_id}","starred_url":"https://api.github.com/users/nikhiljindal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikhiljindal/subscriptions","organizations_url":"https://api.github.com/users/nikhiljindal/orgs","repos_url":"https://api.github.com/users/nikhiljindal/repos","events_url":"https://api.github.com/users/nikhiljindal/events{/privacy}","received_events_url":"https://api.github.com/users/nikhiljindal/received_events","type":"User","site_admin":false},"body":"yes +1","created_at":"2016-05-24T20:11:09Z","updated_at":"2016-05-24T20:11:09Z","html_url":"https://github.com/kubernetes/kubernetes/pull/25125#discussion_r64465075","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25125","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/64465075"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/25125#discussion_r64465075"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25125"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25125","id":68825457,"html_url":"https://github.com/kubernetes/kubernetes/pull/25125","diff_url":"https://github.com/kubernetes/kubernetes/pull/25125.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/25125.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/25125","number":25125,"state":"open","locked":false,"title":"[WIP] e2e tests for federated-apiserver","user":{"login":"colhom","id":1075028,"avatar_url":"https://avatars.githubusercontent.com/u/1075028?v=3","gravatar_id":"","url":"https://api.github.com/users/colhom","html_url":"https://github.com/colhom","followers_url":"https://api.github.com/users/colhom/followers","following_url":"https://api.github.com/users/colhom/following{/other_user}","gists_url":"https://api.github.com/users/colhom/gists{/gist_id}","starred_url":"https://api.github.com/users/colhom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colhom/subscriptions","organizations_url":"https://api.github.com/users/colhom/orgs","repos_url":"https://api.github.com/users/colhom/repos","events_url":"https://api.github.com/users/colhom/events{/privacy}","received_events_url":"https://api.github.com/users/colhom/received_events","type":"User","site_admin":false},"body":"#24880 \r\n\r\nHere we have federated-apiserver wired up into the e2e testing framework. I've pulled in #24016 and #24943 so that the cluster create/get/delete gingko routine can use a `FederationClient`.\r\n\r\nThere are a few remaining items to address:\r\n* [x] ~~integrate with `kube-up` such that federated-apiserver deploy option is controlled via an env var. now you have to run `federation/cluster/federated-push.sh` on your own after the build, but before the tests start~~ While the federated binaries/images are built alongside the rest of the components, pushing those images to repository and deploying the federated containers is now a decoupled procedure using scripts in `federation/cluster`.\r\n\r\n* [x] make this work with GCE and AWS. (Any other providers we should make sure are in the initial PR?), and error out explicitly for the rest.\r\n\r\n* [x] Detect lack of federated-apiserver deploy option and skip federated framework tests automatically.\r\n\r\n\\cc @nikhiljindal @quinton-hoole \r\n","created_at":"2016-05-04T08:21:52Z","updated_at":"2016-05-24T20:11:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3e4ccfd35dbcc2e8c576dc7cf32ba09d24be5b2b","assignee":{"login":"quinton-hoole","id":10390785,"avatar_url":"https://avatars.githubusercontent.com/u/10390785?v=3","gravatar_id":"","url":"https://api.github.com/users/quinton-hoole","html_url":"https://github.com/quinton-hoole","followers_url":"https://api.github.com/users/quinton-hoole/followers","following_url":"https://api.github.com/users/quinton-hoole/following{/other_user}","gists_url":"https://api.github.com/users/quinton-hoole/gists{/gist_id}","starred_url":"https://api.github.com/users/quinton-hoole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quinton-hoole/subscriptions","organizations_url":"https://api.github.com/users/quinton-hoole/orgs","repos_url":"https://api.github.com/users/quinton-hoole/repos","events_url":"https://api.github.com/users/quinton-hoole/events{/privacy}","received_events_url":"https://api.github.com/users/quinton-hoole/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/18","html_url":"https://github.com/kubernetes/kubernetes/milestones/v1.3","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/18/labels","id":1638460,"number":18,"title":"v1.3","description":"https://github.com/kubernetes/kubernetes/wiki/Release-1.3","creator":{"login":"bgrant0607","id":7725777,"avatar_url":"https://avatars.githubusercontent.com/u/7725777?v=3","gravatar_id":"","url":"https://api.github.com/users/bgrant0607","html_url":"https://github.com/bgrant0607","followers_url":"https://api.github.com/users/bgrant0607/followers","following_url":"https://api.github.com/users/bgrant0607/following{/other_user}","gists_url":"https://api.github.com/users/bgrant0607/gists{/gist_id}","starred_url":"https://api.github.com/users/bgrant0607/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgrant0607/subscriptions","organizations_url":"https://api.github.com/users/bgrant0607/orgs","repos_url":"https://api.github.com/users/bgrant0607/repos","events_url":"https://api.github.com/users/bgrant0607/events{/privacy}","received_events_url":"https://api.github.com/users/bgrant0607/received_events","type":"User","site_admin":false},"open_issues":237,"closed_issues":197,"state":"open","created_at":"2016-03-11T07:40:20Z","updated_at":"2016-05-24T19:48:19Z","due_on":"2016-06-24T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25125/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25125/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/25125/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/783ac48f7093bd7da485100039d6c373fe4607ed","head":{"label":"colhom:federation-e2e","ref":"federation-e2e","sha":"783ac48f7093bd7da485100039d6c373fe4607ed","user":{"login":"colhom","id":1075028,"avatar_url":"https://avatars.githubusercontent.com/u/1075028?v=3","gravatar_id":"","url":"https://api.github.com/users/colhom","html_url":"https://github.com/colhom","followers_url":"https://api.github.com/users/colhom/followers","following_url":"https://api.github.com/users/colhom/following{/other_user}","gists_url":"https://api.github.com/users/colhom/gists{/gist_id}","starred_url":"https://api.github.com/users/colhom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colhom/subscriptions","organizations_url":"https://api.github.com/users/colhom/orgs","repos_url":"https://api.github.com/users/colhom/repos","events_url":"https://api.github.com/users/colhom/events{/privacy}","received_events_url":"https://api.github.com/users/colhom/received_events","type":"User","site_admin":false},"repo":{"id":54661545,"name":"kubernetes","full_name":"colhom/kubernetes","owner":{"login":"colhom","id":1075028,"avatar_url":"https://avatars.githubusercontent.com/u/1075028?v=3","gravatar_id":"","url":"https://api.github.com/users/colhom","html_url":"https://github.com/colhom","followers_url":"https://api.github.com/users/colhom/followers","following_url":"https://api.github.com/users/colhom/following{/other_user}","gists_url":"https://api.github.com/users/colhom/gists{/gist_id}","starred_url":"https://api.github.com/users/colhom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colhom/subscriptions","organizations_url":"https://api.github.com/users/colhom/orgs","repos_url":"https://api.github.com/users/colhom/repos","events_url":"https://api.github.com/users/colhom/events{/privacy}","received_events_url":"https://api.github.com/users/colhom/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/colhom/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/colhom/kubernetes","forks_url":"https://api.github.com/repos/colhom/kubernetes/forks","keys_url":"https://api.github.com/repos/colhom/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/colhom/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/colhom/kubernetes/teams","hooks_url":"https://api.github.com/repos/colhom/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/colhom/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/colhom/kubernetes/events","assignees_url":"https://api.github.com/repos/colhom/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/colhom/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/colhom/kubernetes/tags","blobs_url":"https://api.github.com/repos/colhom/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/colhom/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/colhom/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/colhom/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/colhom/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/colhom/kubernetes/languages","stargazers_url":"https://api.github.com/repos/colhom/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/colhom/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/colhom/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/colhom/kubernetes/subscription","commits_url":"https://api.github.com/repos/colhom/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/colhom/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/colhom/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/colhom/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/colhom/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/colhom/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/colhom/kubernetes/merges","archive_url":"https://api.github.com/repos/colhom/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/colhom/kubernetes/downloads","issues_url":"https://api.github.com/repos/colhom/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/colhom/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/colhom/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/colhom/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/colhom/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/colhom/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/colhom/kubernetes/deployments","created_at":"2016-03-24T17:35:38Z","updated_at":"2016-03-24T17:35:51Z","pushed_at":"2016-05-21T00:21:06Z","git_url":"git://github.com/colhom/kubernetes.git","ssh_url":"git@github.com:colhom/kubernetes.git","clone_url":"https://github.com/colhom/kubernetes.git","svn_url":"https://github.com/colhom/kubernetes","homepage":"http://kubernetes.io","size":240197,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"9625926852e215caa35e278c2cd7926744532291","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-05-24T20:00:30Z","pushed_at":"2016-05-24T20:07:51Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":446378,"stargazers_count":14537,"watchers_count":14537,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4422,"mirror_url":null,"open_issues_count":3671,"forks":4422,"open_issues":3671,"watchers":14537,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25125"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/25125"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/25125"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/25125/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25125/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25125/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/783ac48f7093bd7da485100039d6c373fe4607ed"}}}}
{"actor":{"display_login":"nikhiljindal"}}