{"action":"created","comment":{"url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/comments/81315373","pull_request_review_id":2303717,"id":81315373,"diff_hunk":"@@ -15,26 +14,16 @@ class Jless < Formula\n     sha256 \"614093a58873090cc70f51e5e0ff0fb7b3ee76214c619879258679502c9ee750\" => :mavericks\n   end\n \n-  [\n-    %w[258 0681485f47237aeee42a34bbf0ab55215933c7713d1be80ac202a31c7a6fdc31],\n-    %w[258-259 845bb97f407727febd4ee4014618715884bf393d1531089e18faf4e895e19cec],\n-    %w[259-260 e81a5de1fdc276cf0f189c674f37459cf1a7314ac1b804c077e23c519df87ec8],\n-    %w[260-261 b595378ae65a5a7256df3b6279d755d6fdce66ab6ea0bba4f51eeb9ee0307c03],\n-    %w[261-262 e7249de419acc3b8c4a11bed376d778711fd031887d0df0624d62a6d07356842],\n-    %w[262.ext03 82fb77f21ea1f3281224fcbfad073aeab12fb40d6623c9b40698be952401f821],\n-  ].each do |name, sha|\n-    patch do\n-      url \"https://ftp.netbsd.org/pub/pkgsrc/distfiles/less-382-iso#{name}.patch.gz\"\n-      sha256 sha\n-    end\n-  end\n-\n   def install\n     system \"./configure\", \"--prefix=#{prefix}\", \"--mandir=#{man}\"\n-    system \"make install binprefix=j manprefix=j\"\n+    system \"make\", \"install\", \"binprefix=j\", \"manprefix=j\"\n   end\n \n   def caveats\n     \"You may need to set the environment variable 'JLESSCHARSET' to japanese-utf8\"\n   end\n+\n+  test do\n+    assert_match version.to_s, shell_output(\"#{bin}/jless --version\")","path":"Formula/jless.rb","position":46,"original_position":46,"commit_id":"02b07602c5844c5812c3873a4cd8478c885e31a4","original_commit_id":"02b07602c5844c5812c3873a4cd8478c885e31a4","user":{"login":"zmwangx","id":4149852,"avatar_url":"https://avatars.githubusercontent.com/u/4149852?v=3","gravatar_id":"","url":"https://api.github.com/users/zmwangx","html_url":"https://github.com/zmwangx","followers_url":"https://api.github.com/users/zmwangx/followers","following_url":"https://api.github.com/users/zmwangx/following{/other_user}","gists_url":"https://api.github.com/users/zmwangx/gists{/gist_id}","starred_url":"https://api.github.com/users/zmwangx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zmwangx/subscriptions","organizations_url":"https://api.github.com/users/zmwangx/orgs","repos_url":"https://api.github.com/users/zmwangx/repos","events_url":"https://api.github.com/users/zmwangx/events{/privacy}","received_events_url":"https://api.github.com/users/zmwangx/received_events","type":"User","site_admin":false},"body":"Since this is just an implementation of `less` it doesn't really work in a dumb term.","created_at":"2016-09-30T10:30:29Z","updated_at":"2016-09-30T10:30:29Z","html_url":"https://github.com/Homebrew/homebrew-core/pull/5394#discussion_r81315373","pull_request_url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/5394","_links":{"self":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/comments/81315373"},"html":{"href":"https://github.com/Homebrew/homebrew-core/pull/5394#discussion_r81315373"},"pull_request":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/5394"}}},"pull_request":{"url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/5394","id":87378746,"html_url":"https://github.com/Homebrew/homebrew-core/pull/5394","diff_url":"https://github.com/Homebrew/homebrew-core/pull/5394.diff","patch_url":"https://github.com/Homebrew/homebrew-core/pull/5394.patch","issue_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/5394","number":5394,"state":"open","locked":false,"title":"jless 481","user":{"login":"zmwangx","id":4149852,"avatar_url":"https://avatars.githubusercontent.com/u/4149852?v=3","gravatar_id":"","url":"https://api.github.com/users/zmwangx","html_url":"https://github.com/zmwangx","followers_url":"https://api.github.com/users/zmwangx/followers","following_url":"https://api.github.com/users/zmwangx/following{/other_user}","gists_url":"https://api.github.com/users/zmwangx/gists{/gist_id}","starred_url":"https://api.github.com/users/zmwangx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zmwangx/subscriptions","organizations_url":"https://api.github.com/users/zmwangx/orgs","repos_url":"https://api.github.com/users/zmwangx/repos","events_url":"https://api.github.com/users/zmwangx/events{/privacy}","received_events_url":"https://api.github.com/users/zmwangx/received_events","type":"User","site_admin":false},"body":"- [x] Have you followed the guidelines in our [Contributing](https://github.com/Homebrew/homebrew-core/blob/master/CONTRIBUTING.md) document?\r\n- [x] Have you checked to ensure there aren't other open [Pull Requests](https://github.com/Homebrew/homebrew-core/pulls) for the same formula update/change?\r\n- [x] Have you built your formula locally prior to submission with `brew install <formula>` (where `<formula>` is the name of the formula you're submitting)?\r\n- [x] Does your submission pass `brew audit --new-formula <formula>` (after doing `brew install <formula>`)?\r\n\r\n-----\r\n\r\nI noticed this due to broken download URL during bottling. First reaction was to boneyard since this hasn't been updated since 2012 (and Debian has hardly updated either except for removing `jless_382-iso262.orig.tar.gz` in favor of `jless_382-iso262-3.tar.gz`). However, after checking out its homepage I realized it's still going strong and has undergone dozens of beta and stable releases. It no longer needs patching. Also, there are still a few people installing this software...","created_at":"2016-09-29T19:34:15Z","updated_at":"2016-09-30T10:30:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"251cefe88992a2e59d75a701004ed1a81dcc169c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/5394/commits","review_comments_url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/5394/comments","review_comment_url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/5394/comments","statuses_url":"https://api.github.com/repos/Homebrew/homebrew-core/statuses/02b07602c5844c5812c3873a4cd8478c885e31a4","head":{"label":"zmwangx:jless-481","ref":"jless-481","sha":"02b07602c5844c5812c3873a4cd8478c885e31a4","user":{"login":"zmwangx","id":4149852,"avatar_url":"https://avatars.githubusercontent.com/u/4149852?v=3","gravatar_id":"","url":"https://api.github.com/users/zmwangx","html_url":"https://github.com/zmwangx","followers_url":"https://api.github.com/users/zmwangx/followers","following_url":"https://api.github.com/users/zmwangx/following{/other_user}","gists_url":"https://api.github.com/users/zmwangx/gists{/gist_id}","starred_url":"https://api.github.com/users/zmwangx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zmwangx/subscriptions","organizations_url":"https://api.github.com/users/zmwangx/orgs","repos_url":"https://api.github.com/users/zmwangx/repos","events_url":"https://api.github.com/users/zmwangx/events{/privacy}","received_events_url":"https://api.github.com/users/zmwangx/received_events","type":"User","site_admin":false},"repo":{"id":55401272,"name":"homebrew-core","full_name":"zmwangx/homebrew-core","owner":{"login":"zmwangx","id":4149852,"avatar_url":"https://avatars.githubusercontent.com/u/4149852?v=3","gravatar_id":"","url":"https://api.github.com/users/zmwangx","html_url":"https://github.com/zmwangx","followers_url":"https://api.github.com/users/zmwangx/followers","following_url":"https://api.github.com/users/zmwangx/following{/other_user}","gists_url":"https://api.github.com/users/zmwangx/gists{/gist_id}","starred_url":"https://api.github.com/users/zmwangx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zmwangx/subscriptions","organizations_url":"https://api.github.com/users/zmwangx/orgs","repos_url":"https://api.github.com/users/zmwangx/repos","events_url":"https://api.github.com/users/zmwangx/events{/privacy}","received_events_url":"https://api.github.com/users/zmwangx/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zmwangx/homebrew-core","description":":beers: Core formulae for the Homebrew package manager","fork":true,"url":"https://api.github.com/repos/zmwangx/homebrew-core","forks_url":"https://api.github.com/repos/zmwangx/homebrew-core/forks","keys_url":"https://api.github.com/repos/zmwangx/homebrew-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zmwangx/homebrew-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zmwangx/homebrew-core/teams","hooks_url":"https://api.github.com/repos/zmwangx/homebrew-core/hooks","issue_events_url":"https://api.github.com/repos/zmwangx/homebrew-core/issues/events{/number}","events_url":"https://api.github.com/repos/zmwangx/homebrew-core/events","assignees_url":"https://api.github.com/repos/zmwangx/homebrew-core/assignees{/user}","branches_url":"https://api.github.com/repos/zmwangx/homebrew-core/branches{/branch}","tags_url":"https://api.github.com/repos/zmwangx/homebrew-core/tags","blobs_url":"https://api.github.com/repos/zmwangx/homebrew-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zmwangx/homebrew-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zmwangx/homebrew-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/zmwangx/homebrew-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zmwangx/homebrew-core/statuses/{sha}","languages_url":"https://api.github.com/repos/zmwangx/homebrew-core/languages","stargazers_url":"https://api.github.com/repos/zmwangx/homebrew-core/stargazers","contributors_url":"https://api.github.com/repos/zmwangx/homebrew-core/contributors","subscribers_url":"https://api.github.com/repos/zmwangx/homebrew-core/subscribers","subscription_url":"https://api.github.com/repos/zmwangx/homebrew-core/subscription","commits_url":"https://api.github.com/repos/zmwangx/homebrew-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/zmwangx/homebrew-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/zmwangx/homebrew-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/zmwangx/homebrew-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/zmwangx/homebrew-core/contents/{+path}","compare_url":"https://api.github.com/repos/zmwangx/homebrew-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zmwangx/homebrew-core/merges","archive_url":"https://api.github.com/repos/zmwangx/homebrew-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zmwangx/homebrew-core/downloads","issues_url":"https://api.github.com/repos/zmwangx/homebrew-core/issues{/number}","pulls_url":"https://api.github.com/repos/zmwangx/homebrew-core/pulls{/number}","milestones_url":"https://api.github.com/repos/zmwangx/homebrew-core/milestones{/number}","notifications_url":"https://api.github.com/repos/zmwangx/homebrew-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zmwangx/homebrew-core/labels{/name}","releases_url":"https://api.github.com/repos/zmwangx/homebrew-core/releases{/id}","deployments_url":"https://api.github.com/repos/zmwangx/homebrew-core/deployments","created_at":"2016-04-04T10:04:01Z","updated_at":"2016-04-04T10:04:16Z","pushed_at":"2016-09-29T23:36:58Z","git_url":"git://github.com/zmwangx/homebrew-core.git","ssh_url":"git@github.com:zmwangx/homebrew-core.git","clone_url":"https://github.com/zmwangx/homebrew-core.git","svn_url":"https://github.com/zmwangx/homebrew-core","homepage":"http://brew.sh","size":80558,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Homebrew:master","ref":"master","sha":"1f5d0a3eb8eb8a50fc8f915761235d7cfcbc8685","user":{"login":"Homebrew","id":1503512,"avatar_url":"https://avatars.githubusercontent.com/u/1503512?v=3","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"repo":{"id":52855516,"name":"homebrew-core","full_name":"Homebrew/homebrew-core","owner":{"login":"Homebrew","id":1503512,"avatar_url":"https://avatars.githubusercontent.com/u/1503512?v=3","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Homebrew/homebrew-core","description":":beers: Core formulae for the Homebrew package manager","fork":false,"url":"https://api.github.com/repos/Homebrew/homebrew-core","forks_url":"https://api.github.com/repos/Homebrew/homebrew-core/forks","keys_url":"https://api.github.com/repos/Homebrew/homebrew-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Homebrew/homebrew-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Homebrew/homebrew-core/teams","hooks_url":"https://api.github.com/repos/Homebrew/homebrew-core/hooks","issue_events_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/events{/number}","events_url":"https://api.github.com/repos/Homebrew/homebrew-core/events","assignees_url":"https://api.github.com/repos/Homebrew/homebrew-core/assignees{/user}","branches_url":"https://api.github.com/repos/Homebrew/homebrew-core/branches{/branch}","tags_url":"https://api.github.com/repos/Homebrew/homebrew-core/tags","blobs_url":"https://api.github.com/repos/Homebrew/homebrew-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Homebrew/homebrew-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Homebrew/homebrew-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/Homebrew/homebrew-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Homebrew/homebrew-core/statuses/{sha}","languages_url":"https://api.github.com/repos/Homebrew/homebrew-core/languages","stargazers_url":"https://api.github.com/repos/Homebrew/homebrew-core/stargazers","contributors_url":"https://api.github.com/repos/Homebrew/homebrew-core/contributors","subscribers_url":"https://api.github.com/repos/Homebrew/homebrew-core/subscribers","subscription_url":"https://api.github.com/repos/Homebrew/homebrew-core/subscription","commits_url":"https://api.github.com/repos/Homebrew/homebrew-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/Homebrew/homebrew-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/Homebrew/homebrew-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/Homebrew/homebrew-core/contents/{+path}","compare_url":"https://api.github.com/repos/Homebrew/homebrew-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Homebrew/homebrew-core/merges","archive_url":"https://api.github.com/repos/Homebrew/homebrew-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Homebrew/homebrew-core/downloads","issues_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues{/number}","pulls_url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls{/number}","milestones_url":"https://api.github.com/repos/Homebrew/homebrew-core/milestones{/number}","notifications_url":"https://api.github.com/repos/Homebrew/homebrew-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Homebrew/homebrew-core/labels{/name}","releases_url":"https://api.github.com/repos/Homebrew/homebrew-core/releases{/id}","deployments_url":"https://api.github.com/repos/Homebrew/homebrew-core/deployments","created_at":"2016-03-01T06:58:36Z","updated_at":"2016-09-30T09:18:36Z","pushed_at":"2016-09-30T08:53:08Z","git_url":"git://github.com/Homebrew/homebrew-core.git","ssh_url":"git@github.com:Homebrew/homebrew-core.git","clone_url":"https://github.com/Homebrew/homebrew-core.git","svn_url":"https://github.com/Homebrew/homebrew-core","homepage":"http://brew.sh","size":130675,"stargazers_count":835,"watchers_count":835,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1423,"mirror_url":null,"open_issues_count":171,"forks":1423,"open_issues":171,"watchers":835,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/5394"},"html":{"href":"https://github.com/Homebrew/homebrew-core/pull/5394"},"issue":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/issues/5394"},"comments":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/issues/5394/comments"},"review_comments":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/5394/comments"},"review_comment":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/5394/commits"},"statuses":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/statuses/02b07602c5844c5812c3873a4cd8478c885e31a4"}}}}
{"actor":{"display_login":"zmwangx"}}