{"action":"created","comment":{"url":"https://api.github.com/repos/angular/angular.js/pulls/comments/78231768","id":78231768,"diff_hunk":"@@ -262,7 +262,7 @@ function publishExternalAPI(angular) {\n         $window: $WindowProvider,\n         $$rAF: $$RAFProvider,\n         $$jqLite: $$jqLiteProvider,\n-        $$HashMap: $$HashMapProvider,\n+        $$Map: $$MapProvider,","path":"src/AngularPublic.js","position":21,"original_position":21,"commit_id":"dcbb7075a2a521f8c87d4d76c4a3cd59d5f1593d","original_commit_id":"dcbb7075a2a521f8c87d4d76c4a3cd59d5f1593d","user":{"login":"gkalpak","id":8604205,"avatar_url":"https://avatars.githubusercontent.com/u/8604205?v=3","gravatar_id":"","url":"https://api.github.com/users/gkalpak","html_url":"https://github.com/gkalpak","followers_url":"https://api.github.com/users/gkalpak/followers","following_url":"https://api.github.com/users/gkalpak/following{/other_user}","gists_url":"https://api.github.com/users/gkalpak/gists{/gist_id}","starred_url":"https://api.github.com/users/gkalpak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gkalpak/subscriptions","organizations_url":"https://api.github.com/users/gkalpak/orgs","repos_url":"https://api.github.com/users/gkalpak/repos","events_url":"https://api.github.com/users/gkalpak/events{/privacy}","received_events_url":"https://api.github.com/users/gkalpak/received_events","type":"User","site_admin":false},"body":"This is a private service, so no breaking change (theoretically). It is used by `ngAnimate` (which doesn't have access to the closure).","created_at":"2016-09-09T18:59:12Z","updated_at":"2016-09-09T18:59:12Z","html_url":"https://github.com/angular/angular.js/pull/15114#discussion_r78231768","pull_request_url":"https://api.github.com/repos/angular/angular.js/pulls/15114","_links":{"self":{"href":"https://api.github.com/repos/angular/angular.js/pulls/comments/78231768"},"html":{"href":"https://github.com/angular/angular.js/pull/15114#discussion_r78231768"},"pull_request":{"href":"https://api.github.com/repos/angular/angular.js/pulls/15114"}}},"pull_request":{"url":"https://api.github.com/repos/angular/angular.js/pulls/15114","id":84692363,"html_url":"https://github.com/angular/angular.js/pull/15114","diff_url":"https://github.com/angular/angular.js/pull/15114.diff","patch_url":"https://github.com/angular/angular.js/pull/15114.patch","issue_url":"https://api.github.com/repos/angular/angular.js/issues/15114","number":15114,"state":"open","locked":false,"title":"Replace arrays and `HashMap` with native `Map` (with a fallback shim implementation)","user":{"login":"gkalpak","id":8604205,"avatar_url":"https://avatars.githubusercontent.com/u/8604205?v=3","gravatar_id":"","url":"https://api.github.com/users/gkalpak","html_url":"https://github.com/gkalpak","followers_url":"https://api.github.com/users/gkalpak/followers","following_url":"https://api.github.com/users/gkalpak/following{/other_user}","gists_url":"https://api.github.com/users/gkalpak/gists{/gist_id}","starred_url":"https://api.github.com/users/gkalpak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gkalpak/subscriptions","organizations_url":"https://api.github.com/users/gkalpak/orgs","repos_url":"https://api.github.com/users/gkalpak/repos","events_url":"https://api.github.com/users/gkalpak/events{/privacy}","received_events_url":"https://api.github.com/users/gkalpak/received_events","type":"User","site_admin":false},"body":"**What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)**\r\nPerf improvement (from incorporating #13209) and several refactorings.\r\n\r\n\r\n**What is the current behavior? (You can also link to an open issue here)**\r\nSame old, same old.\r\n\r\n\r\n**What is the new behavior (if this is a feature change)?**\r\nSee #13209. On top of that, the internal `HashMap`/`$$HashMap` is replaced with native `Map`/`NgMapShim`, which should improve performance when native implementations are available (i.e. in most cases) and probably slightly decrease speed when falling back to the shim (tbd).\r\n\r\n\r\n**Does this PR introduce a breaking change?**\r\nNo.\r\n\r\n\r\n**Please check if the PR fulfills these requirements**\r\n- [x] The commit message follows our guidelines: https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md#commit-message-format\r\n- [x] Tests for the changes have been added (for bug fixes / features)\r\n- [ ] ~~Docs have been added / updated (for bug fixes / features)~~\r\n\r\n**Other information**:\r\nThis incorporates and builds on top of #13209.","created_at":"2016-09-09T18:00:51Z","updated_at":"2016-09-09T18:59:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a1de553086b737868bb81c964f403a090bfd423e","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/angular/angular.js/milestones/27","html_url":"https://github.com/angular/angular.js/milestones/Backlog","labels_url":"https://api.github.com/repos/angular/angular.js/milestones/27/labels","id":489171,"number":27,"title":"Backlog","description":"Holds the backlog of issues and pull requests that have been triaged.\r\n\r\nBefore assigning items to this milestone they should be labelled, at the very least with the correct \"type\" label (i.e. \"issue\", \"pr\", \"bug\", \"regression\", \"chore\", \"docs\", etc).  Preferably you should also check for duplicate issues/PRs, note CLA status and assign \"complexity\" and \"impact\" labels too.","creator":{"login":"IgorMinar","id":216296,"avatar_url":"https://avatars.githubusercontent.com/u/216296?v=3","gravatar_id":"","url":"https://api.github.com/users/IgorMinar","html_url":"https://github.com/IgorMinar","followers_url":"https://api.github.com/users/IgorMinar/followers","following_url":"https://api.github.com/users/IgorMinar/following{/other_user}","gists_url":"https://api.github.com/users/IgorMinar/gists{/gist_id}","starred_url":"https://api.github.com/users/IgorMinar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IgorMinar/subscriptions","organizations_url":"https://api.github.com/users/IgorMinar/orgs","repos_url":"https://api.github.com/users/IgorMinar/repos","events_url":"https://api.github.com/users/IgorMinar/events{/privacy}","received_events_url":"https://api.github.com/users/IgorMinar/received_events","type":"User","site_admin":false},"open_issues":495,"closed_issues":1411,"state":"open","created_at":"2013-11-18T23:30:35Z","updated_at":"2016-09-09T18:00:51Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/angular/angular.js/pulls/15114/commits","review_comments_url":"https://api.github.com/repos/angular/angular.js/pulls/15114/comments","review_comment_url":"https://api.github.com/repos/angular/angular.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/angular.js/issues/15114/comments","statuses_url":"https://api.github.com/repos/angular/angular.js/statuses/dcbb7075a2a521f8c87d4d76c4a3cd59d5f1593d","head":{"label":"gkalpak:refactor-HashMap-use-ES6Map","ref":"refactor-HashMap-use-ES6Map","sha":"dcbb7075a2a521f8c87d4d76c4a3cd59d5f1593d","user":{"login":"gkalpak","id":8604205,"avatar_url":"https://avatars.githubusercontent.com/u/8604205?v=3","gravatar_id":"","url":"https://api.github.com/users/gkalpak","html_url":"https://github.com/gkalpak","followers_url":"https://api.github.com/users/gkalpak/followers","following_url":"https://api.github.com/users/gkalpak/following{/other_user}","gists_url":"https://api.github.com/users/gkalpak/gists{/gist_id}","starred_url":"https://api.github.com/users/gkalpak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gkalpak/subscriptions","organizations_url":"https://api.github.com/users/gkalpak/orgs","repos_url":"https://api.github.com/users/gkalpak/repos","events_url":"https://api.github.com/users/gkalpak/events{/privacy}","received_events_url":"https://api.github.com/users/gkalpak/received_events","type":"User","site_admin":false},"repo":{"id":23513120,"name":"angular.js","full_name":"gkalpak/angular.js","owner":{"login":"gkalpak","id":8604205,"avatar_url":"https://avatars.githubusercontent.com/u/8604205?v=3","gravatar_id":"","url":"https://api.github.com/users/gkalpak","html_url":"https://github.com/gkalpak","followers_url":"https://api.github.com/users/gkalpak/followers","following_url":"https://api.github.com/users/gkalpak/following{/other_user}","gists_url":"https://api.github.com/users/gkalpak/gists{/gist_id}","starred_url":"https://api.github.com/users/gkalpak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gkalpak/subscriptions","organizations_url":"https://api.github.com/users/gkalpak/orgs","repos_url":"https://api.github.com/users/gkalpak/repos","events_url":"https://api.github.com/users/gkalpak/events{/privacy}","received_events_url":"https://api.github.com/users/gkalpak/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gkalpak/angular.js","description":"HTML enhanced for web apps","fork":true,"url":"https://api.github.com/repos/gkalpak/angular.js","forks_url":"https://api.github.com/repos/gkalpak/angular.js/forks","keys_url":"https://api.github.com/repos/gkalpak/angular.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gkalpak/angular.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gkalpak/angular.js/teams","hooks_url":"https://api.github.com/repos/gkalpak/angular.js/hooks","issue_events_url":"https://api.github.com/repos/gkalpak/angular.js/issues/events{/number}","events_url":"https://api.github.com/repos/gkalpak/angular.js/events","assignees_url":"https://api.github.com/repos/gkalpak/angular.js/assignees{/user}","branches_url":"https://api.github.com/repos/gkalpak/angular.js/branches{/branch}","tags_url":"https://api.github.com/repos/gkalpak/angular.js/tags","blobs_url":"https://api.github.com/repos/gkalpak/angular.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gkalpak/angular.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gkalpak/angular.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/gkalpak/angular.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gkalpak/angular.js/statuses/{sha}","languages_url":"https://api.github.com/repos/gkalpak/angular.js/languages","stargazers_url":"https://api.github.com/repos/gkalpak/angular.js/stargazers","contributors_url":"https://api.github.com/repos/gkalpak/angular.js/contributors","subscribers_url":"https://api.github.com/repos/gkalpak/angular.js/subscribers","subscription_url":"https://api.github.com/repos/gkalpak/angular.js/subscription","commits_url":"https://api.github.com/repos/gkalpak/angular.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/gkalpak/angular.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/gkalpak/angular.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/gkalpak/angular.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/gkalpak/angular.js/contents/{+path}","compare_url":"https://api.github.com/repos/gkalpak/angular.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gkalpak/angular.js/merges","archive_url":"https://api.github.com/repos/gkalpak/angular.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gkalpak/angular.js/downloads","issues_url":"https://api.github.com/repos/gkalpak/angular.js/issues{/number}","pulls_url":"https://api.github.com/repos/gkalpak/angular.js/pulls{/number}","milestones_url":"https://api.github.com/repos/gkalpak/angular.js/milestones{/number}","notifications_url":"https://api.github.com/repos/gkalpak/angular.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gkalpak/angular.js/labels{/name}","releases_url":"https://api.github.com/repos/gkalpak/angular.js/releases{/id}","deployments_url":"https://api.github.com/repos/gkalpak/angular.js/deployments","created_at":"2014-08-31T12:31:10Z","updated_at":"2016-01-11T10:14:26Z","pushed_at":"2016-09-09T17:52:33Z","git_url":"git://github.com/gkalpak/angular.js.git","ssh_url":"git@github.com:gkalpak/angular.js.git","clone_url":"https://github.com/gkalpak/angular.js.git","svn_url":"https://github.com/gkalpak/angular.js","homepage":"http://angularjs.org","size":74196,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"51a2eb7d6fe62ad2d7ba0866cfbde0e69cab82eb","user":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":460078,"name":"angular.js","full_name":"angular/angular.js","owner":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/angular.js","description":"HTML enhanced for web apps","fork":false,"url":"https://api.github.com/repos/angular/angular.js","forks_url":"https://api.github.com/repos/angular/angular.js/forks","keys_url":"https://api.github.com/repos/angular/angular.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/angular.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/angular.js/teams","hooks_url":"https://api.github.com/repos/angular/angular.js/hooks","issue_events_url":"https://api.github.com/repos/angular/angular.js/issues/events{/number}","events_url":"https://api.github.com/repos/angular/angular.js/events","assignees_url":"https://api.github.com/repos/angular/angular.js/assignees{/user}","branches_url":"https://api.github.com/repos/angular/angular.js/branches{/branch}","tags_url":"https://api.github.com/repos/angular/angular.js/tags","blobs_url":"https://api.github.com/repos/angular/angular.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/angular.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/angular.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/angular.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/angular.js/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/angular.js/languages","stargazers_url":"https://api.github.com/repos/angular/angular.js/stargazers","contributors_url":"https://api.github.com/repos/angular/angular.js/contributors","subscribers_url":"https://api.github.com/repos/angular/angular.js/subscribers","subscription_url":"https://api.github.com/repos/angular/angular.js/subscription","commits_url":"https://api.github.com/repos/angular/angular.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/angular.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/angular.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/angular.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/angular.js/contents/{+path}","compare_url":"https://api.github.com/repos/angular/angular.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/angular.js/merges","archive_url":"https://api.github.com/repos/angular/angular.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/angular.js/downloads","issues_url":"https://api.github.com/repos/angular/angular.js/issues{/number}","pulls_url":"https://api.github.com/repos/angular/angular.js/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/angular.js/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/angular.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/angular.js/labels{/name}","releases_url":"https://api.github.com/repos/angular/angular.js/releases{/id}","deployments_url":"https://api.github.com/repos/angular/angular.js/deployments","created_at":"2010-01-06T00:34:37Z","updated_at":"2016-09-09T18:18:48Z","pushed_at":"2016-09-09T18:00:51Z","git_url":"git://github.com/angular/angular.js.git","ssh_url":"git@github.com:angular/angular.js.git","clone_url":"https://github.com/angular/angular.js.git","svn_url":"https://github.com/angular/angular.js","homepage":"http://angularjs.org","size":178911,"stargazers_count":52007,"watchers_count":52007,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25545,"mirror_url":null,"open_issues_count":866,"forks":25545,"open_issues":866,"watchers":52007,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/angular.js/pulls/15114"},"html":{"href":"https://github.com/angular/angular.js/pull/15114"},"issue":{"href":"https://api.github.com/repos/angular/angular.js/issues/15114"},"comments":{"href":"https://api.github.com/repos/angular/angular.js/issues/15114/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/angular.js/pulls/15114/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/angular.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/angular.js/pulls/15114/commits"},"statuses":{"href":"https://api.github.com/repos/angular/angular.js/statuses/dcbb7075a2a521f8c87d4d76c4a3cd59d5f1593d"}}}}
{"actor":{"display_login":"gkalpak"}}