{"action":"created","comment":{"url":"https://api.github.com/repos/canonical-ols/javan-rhino/pulls/comments/88897817","pull_request_review_id":9454980,"id":88897817,"diff_hunk":"@@ -0,0 +1,18 @@\n+import fs from 'fs';\n+\n+// location and name of file is consistent across projects\n+const filename = './version-info.txt';","path":"src/server/middleware/set-revision-header.js","position":4,"original_position":4,"commit_id":"3de49e00bf694a5ef0a76de5889465b60ccb3b97","original_commit_id":"14e711dac49125bbe878dd7d633f9d8d1bf7303c","user":{"login":"earnubs","id":167440,"avatar_url":"https://avatars.githubusercontent.com/u/167440?v=3","gravatar_id":"","url":"https://api.github.com/users/earnubs","html_url":"https://github.com/earnubs","followers_url":"https://api.github.com/users/earnubs/followers","following_url":"https://api.github.com/users/earnubs/following{/other_user}","gists_url":"https://api.github.com/users/earnubs/gists{/gist_id}","starred_url":"https://api.github.com/users/earnubs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/earnubs/subscriptions","organizations_url":"https://api.github.com/users/earnubs/orgs","repos_url":"https://api.github.com/users/earnubs/repos","events_url":"https://api.github.com/users/earnubs/events{/privacy}","received_events_url":"https://api.github.com/users/earnubs/received_events","type":"User","site_admin":false},"body":"Good question. File is written by the Makefile as part of build, so by default it's not there for us in dev and the header value is 'unknown'. \r\n\r\nSo, I think no, it shouldn't be under version control as it's a build artefact.","created_at":"2016-11-21T13:54:41Z","updated_at":"2016-11-21T13:54:41Z","html_url":"https://github.com/canonical-ols/javan-rhino/pull/213#discussion_r88897817","pull_request_url":"https://api.github.com/repos/canonical-ols/javan-rhino/pulls/213","_links":{"self":{"href":"https://api.github.com/repos/canonical-ols/javan-rhino/pulls/comments/88897817"},"html":{"href":"https://github.com/canonical-ols/javan-rhino/pull/213#discussion_r88897817"},"pull_request":{"href":"https://api.github.com/repos/canonical-ols/javan-rhino/pulls/213"}}},"pull_request":{"url":"https://api.github.com/repos/canonical-ols/javan-rhino/pulls/213","id":94395284,"html_url":"https://github.com/canonical-ols/javan-rhino/pull/213","diff_url":"https://github.com/canonical-ols/javan-rhino/pull/213.diff","patch_url":"https://github.com/canonical-ols/javan-rhino/pull/213.patch","issue_url":"https://api.github.com/repos/canonical-ols/javan-rhino/issues/213","number":213,"state":"open","locked":false,"title":"Set x-vcs-revision header","user":{"login":"earnubs","id":167440,"avatar_url":"https://avatars.githubusercontent.com/u/167440?v=3","gravatar_id":"","url":"https://api.github.com/users/earnubs","html_url":"https://github.com/earnubs","followers_url":"https://api.github.com/users/earnubs/followers","following_url":"https://api.github.com/users/earnubs/following{/other_user}","gists_url":"https://api.github.com/users/earnubs/gists{/gist_id}","starred_url":"https://api.github.com/users/earnubs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/earnubs/subscriptions","organizations_url":"https://api.github.com/users/earnubs/orgs","repos_url":"https://api.github.com/users/earnubs/repos","events_url":"https://api.github.com/users/earnubs/events{/privacy}","received_events_url":"https://api.github.com/users/earnubs/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-11-18T16:43:51Z","updated_at":"2016-11-21T13:54:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"05474ad04f7c55ea9e544ac71da01b9663e11826","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/canonical-ols/javan-rhino/pulls/213/commits","review_comments_url":"https://api.github.com/repos/canonical-ols/javan-rhino/pulls/213/comments","review_comment_url":"https://api.github.com/repos/canonical-ols/javan-rhino/pulls/comments{/number}","comments_url":"https://api.github.com/repos/canonical-ols/javan-rhino/issues/213/comments","statuses_url":"https://api.github.com/repos/canonical-ols/javan-rhino/statuses/3de49e00bf694a5ef0a76de5889465b60ccb3b97","head":{"label":"canonical-ols:set-x-vcs-revision-header","ref":"set-x-vcs-revision-header","sha":"3de49e00bf694a5ef0a76de5889465b60ccb3b97","user":{"login":"canonical-ols","id":17836138,"avatar_url":"https://avatars.githubusercontent.com/u/17836138?v=3","gravatar_id":"","url":"https://api.github.com/users/canonical-ols","html_url":"https://github.com/canonical-ols","followers_url":"https://api.github.com/users/canonical-ols/followers","following_url":"https://api.github.com/users/canonical-ols/following{/other_user}","gists_url":"https://api.github.com/users/canonical-ols/gists{/gist_id}","starred_url":"https://api.github.com/users/canonical-ols/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/canonical-ols/subscriptions","organizations_url":"https://api.github.com/users/canonical-ols/orgs","repos_url":"https://api.github.com/users/canonical-ols/repos","events_url":"https://api.github.com/users/canonical-ols/events{/privacy}","received_events_url":"https://api.github.com/users/canonical-ols/received_events","type":"Organization","site_admin":false},"repo":{"id":65722766,"name":"javan-rhino","full_name":"canonical-ols/javan-rhino","owner":{"login":"canonical-ols","id":17836138,"avatar_url":"https://avatars.githubusercontent.com/u/17836138?v=3","gravatar_id":"","url":"https://api.github.com/users/canonical-ols","html_url":"https://github.com/canonical-ols","followers_url":"https://api.github.com/users/canonical-ols/followers","following_url":"https://api.github.com/users/canonical-ols/following{/other_user}","gists_url":"https://api.github.com/users/canonical-ols/gists{/gist_id}","starred_url":"https://api.github.com/users/canonical-ols/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/canonical-ols/subscriptions","organizations_url":"https://api.github.com/users/canonical-ols/orgs","repos_url":"https://api.github.com/users/canonical-ols/repos","events_url":"https://api.github.com/users/canonical-ols/events{/privacy}","received_events_url":"https://api.github.com/users/canonical-ols/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/canonical-ols/javan-rhino","description":null,"fork":false,"url":"https://api.github.com/repos/canonical-ols/javan-rhino","forks_url":"https://api.github.com/repos/canonical-ols/javan-rhino/forks","keys_url":"https://api.github.com/repos/canonical-ols/javan-rhino/keys{/key_id}","collaborators_url":"https://api.github.com/repos/canonical-ols/javan-rhino/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/canonical-ols/javan-rhino/teams","hooks_url":"https://api.github.com/repos/canonical-ols/javan-rhino/hooks","issue_events_url":"https://api.github.com/repos/canonical-ols/javan-rhino/issues/events{/number}","events_url":"https://api.github.com/repos/canonical-ols/javan-rhino/events","assignees_url":"https://api.github.com/repos/canonical-ols/javan-rhino/assignees{/user}","branches_url":"https://api.github.com/repos/canonical-ols/javan-rhino/branches{/branch}","tags_url":"https://api.github.com/repos/canonical-ols/javan-rhino/tags","blobs_url":"https://api.github.com/repos/canonical-ols/javan-rhino/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/canonical-ols/javan-rhino/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/canonical-ols/javan-rhino/git/refs{/sha}","trees_url":"https://api.github.com/repos/canonical-ols/javan-rhino/git/trees{/sha}","statuses_url":"https://api.github.com/repos/canonical-ols/javan-rhino/statuses/{sha}","languages_url":"https://api.github.com/repos/canonical-ols/javan-rhino/languages","stargazers_url":"https://api.github.com/repos/canonical-ols/javan-rhino/stargazers","contributors_url":"https://api.github.com/repos/canonical-ols/javan-rhino/contributors","subscribers_url":"https://api.github.com/repos/canonical-ols/javan-rhino/subscribers","subscription_url":"https://api.github.com/repos/canonical-ols/javan-rhino/subscription","commits_url":"https://api.github.com/repos/canonical-ols/javan-rhino/commits{/sha}","git_commits_url":"https://api.github.com/repos/canonical-ols/javan-rhino/git/commits{/sha}","comments_url":"https://api.github.com/repos/canonical-ols/javan-rhino/comments{/number}","issue_comment_url":"https://api.github.com/repos/canonical-ols/javan-rhino/issues/comments{/number}","contents_url":"https://api.github.com/repos/canonical-ols/javan-rhino/contents/{+path}","compare_url":"https://api.github.com/repos/canonical-ols/javan-rhino/compare/{base}...{head}","merges_url":"https://api.github.com/repos/canonical-ols/javan-rhino/merges","archive_url":"https://api.github.com/repos/canonical-ols/javan-rhino/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/canonical-ols/javan-rhino/downloads","issues_url":"https://api.github.com/repos/canonical-ols/javan-rhino/issues{/number}","pulls_url":"https://api.github.com/repos/canonical-ols/javan-rhino/pulls{/number}","milestones_url":"https://api.github.com/repos/canonical-ols/javan-rhino/milestones{/number}","notifications_url":"https://api.github.com/repos/canonical-ols/javan-rhino/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/canonical-ols/javan-rhino/labels{/name}","releases_url":"https://api.github.com/repos/canonical-ols/javan-rhino/releases{/id}","deployments_url":"https://api.github.com/repos/canonical-ols/javan-rhino/deployments","created_at":"2016-08-15T09:59:59Z","updated_at":"2016-11-07T17:48:49Z","pushed_at":"2016-11-21T13:46:02Z","git_url":"git://github.com/canonical-ols/javan-rhino.git","ssh_url":"git@github.com:canonical-ols/javan-rhino.git","clone_url":"https://github.com/canonical-ols/javan-rhino.git","svn_url":"https://github.com/canonical-ols/javan-rhino","homepage":"https://my.ubuntu.com","size":1610,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":13,"forks":3,"open_issues":13,"watchers":1,"default_branch":"master"}},"base":{"label":"canonical-ols:master","ref":"master","sha":"d21e2f6fc06104a8860604de5b06e3bbdd32c60d","user":{"login":"canonical-ols","id":17836138,"avatar_url":"https://avatars.githubusercontent.com/u/17836138?v=3","gravatar_id":"","url":"https://api.github.com/users/canonical-ols","html_url":"https://github.com/canonical-ols","followers_url":"https://api.github.com/users/canonical-ols/followers","following_url":"https://api.github.com/users/canonical-ols/following{/other_user}","gists_url":"https://api.github.com/users/canonical-ols/gists{/gist_id}","starred_url":"https://api.github.com/users/canonical-ols/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/canonical-ols/subscriptions","organizations_url":"https://api.github.com/users/canonical-ols/orgs","repos_url":"https://api.github.com/users/canonical-ols/repos","events_url":"https://api.github.com/users/canonical-ols/events{/privacy}","received_events_url":"https://api.github.com/users/canonical-ols/received_events","type":"Organization","site_admin":false},"repo":{"id":65722766,"name":"javan-rhino","full_name":"canonical-ols/javan-rhino","owner":{"login":"canonical-ols","id":17836138,"avatar_url":"https://avatars.githubusercontent.com/u/17836138?v=3","gravatar_id":"","url":"https://api.github.com/users/canonical-ols","html_url":"https://github.com/canonical-ols","followers_url":"https://api.github.com/users/canonical-ols/followers","following_url":"https://api.github.com/users/canonical-ols/following{/other_user}","gists_url":"https://api.github.com/users/canonical-ols/gists{/gist_id}","starred_url":"https://api.github.com/users/canonical-ols/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/canonical-ols/subscriptions","organizations_url":"https://api.github.com/users/canonical-ols/orgs","repos_url":"https://api.github.com/users/canonical-ols/repos","events_url":"https://api.github.com/users/canonical-ols/events{/privacy}","received_events_url":"https://api.github.com/users/canonical-ols/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/canonical-ols/javan-rhino","description":null,"fork":false,"url":"https://api.github.com/repos/canonical-ols/javan-rhino","forks_url":"https://api.github.com/repos/canonical-ols/javan-rhino/forks","keys_url":"https://api.github.com/repos/canonical-ols/javan-rhino/keys{/key_id}","collaborators_url":"https://api.github.com/repos/canonical-ols/javan-rhino/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/canonical-ols/javan-rhino/teams","hooks_url":"https://api.github.com/repos/canonical-ols/javan-rhino/hooks","issue_events_url":"https://api.github.com/repos/canonical-ols/javan-rhino/issues/events{/number}","events_url":"https://api.github.com/repos/canonical-ols/javan-rhino/events","assignees_url":"https://api.github.com/repos/canonical-ols/javan-rhino/assignees{/user}","branches_url":"https://api.github.com/repos/canonical-ols/javan-rhino/branches{/branch}","tags_url":"https://api.github.com/repos/canonical-ols/javan-rhino/tags","blobs_url":"https://api.github.com/repos/canonical-ols/javan-rhino/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/canonical-ols/javan-rhino/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/canonical-ols/javan-rhino/git/refs{/sha}","trees_url":"https://api.github.com/repos/canonical-ols/javan-rhino/git/trees{/sha}","statuses_url":"https://api.github.com/repos/canonical-ols/javan-rhino/statuses/{sha}","languages_url":"https://api.github.com/repos/canonical-ols/javan-rhino/languages","stargazers_url":"https://api.github.com/repos/canonical-ols/javan-rhino/stargazers","contributors_url":"https://api.github.com/repos/canonical-ols/javan-rhino/contributors","subscribers_url":"https://api.github.com/repos/canonical-ols/javan-rhino/subscribers","subscription_url":"https://api.github.com/repos/canonical-ols/javan-rhino/subscription","commits_url":"https://api.github.com/repos/canonical-ols/javan-rhino/commits{/sha}","git_commits_url":"https://api.github.com/repos/canonical-ols/javan-rhino/git/commits{/sha}","comments_url":"https://api.github.com/repos/canonical-ols/javan-rhino/comments{/number}","issue_comment_url":"https://api.github.com/repos/canonical-ols/javan-rhino/issues/comments{/number}","contents_url":"https://api.github.com/repos/canonical-ols/javan-rhino/contents/{+path}","compare_url":"https://api.github.com/repos/canonical-ols/javan-rhino/compare/{base}...{head}","merges_url":"https://api.github.com/repos/canonical-ols/javan-rhino/merges","archive_url":"https://api.github.com/repos/canonical-ols/javan-rhino/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/canonical-ols/javan-rhino/downloads","issues_url":"https://api.github.com/repos/canonical-ols/javan-rhino/issues{/number}","pulls_url":"https://api.github.com/repos/canonical-ols/javan-rhino/pulls{/number}","milestones_url":"https://api.github.com/repos/canonical-ols/javan-rhino/milestones{/number}","notifications_url":"https://api.github.com/repos/canonical-ols/javan-rhino/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/canonical-ols/javan-rhino/labels{/name}","releases_url":"https://api.github.com/repos/canonical-ols/javan-rhino/releases{/id}","deployments_url":"https://api.github.com/repos/canonical-ols/javan-rhino/deployments","created_at":"2016-08-15T09:59:59Z","updated_at":"2016-11-07T17:48:49Z","pushed_at":"2016-11-21T13:46:02Z","git_url":"git://github.com/canonical-ols/javan-rhino.git","ssh_url":"git@github.com:canonical-ols/javan-rhino.git","clone_url":"https://github.com/canonical-ols/javan-rhino.git","svn_url":"https://github.com/canonical-ols/javan-rhino","homepage":"https://my.ubuntu.com","size":1610,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":13,"forks":3,"open_issues":13,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/canonical-ols/javan-rhino/pulls/213"},"html":{"href":"https://github.com/canonical-ols/javan-rhino/pull/213"},"issue":{"href":"https://api.github.com/repos/canonical-ols/javan-rhino/issues/213"},"comments":{"href":"https://api.github.com/repos/canonical-ols/javan-rhino/issues/213/comments"},"review_comments":{"href":"https://api.github.com/repos/canonical-ols/javan-rhino/pulls/213/comments"},"review_comment":{"href":"https://api.github.com/repos/canonical-ols/javan-rhino/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/canonical-ols/javan-rhino/pulls/213/commits"},"statuses":{"href":"https://api.github.com/repos/canonical-ols/javan-rhino/statuses/3de49e00bf694a5ef0a76de5889465b60ccb3b97"}}}}
{"actor":{"display_login":"earnubs"}}