{"action":"created","issue":{"url":"https://api.github.com/repos/sensu/sensu-chef/issues/455","repository_url":"https://api.github.com/repos/sensu/sensu-chef","labels_url":"https://api.github.com/repos/sensu/sensu-chef/issues/455/labels{/name}","comments_url":"https://api.github.com/repos/sensu/sensu-chef/issues/455/comments","events_url":"https://api.github.com/repos/sensu/sensu-chef/issues/455/events","html_url":"https://github.com/sensu/sensu-chef/pull/455","id":158431743,"number":455,"title":"Make .Net Framework installation optional, \"outsource\" it to ms_dotnet cookbook","user":{"login":"cwjohnston","id":148017,"avatar_url":"https://avatars.githubusercontent.com/u/148017?v=3","gravatar_id":"","url":"https://api.github.com/users/cwjohnston","html_url":"https://github.com/cwjohnston","followers_url":"https://api.github.com/users/cwjohnston/followers","following_url":"https://api.github.com/users/cwjohnston/following{/other_user}","gists_url":"https://api.github.com/users/cwjohnston/gists{/gist_id}","starred_url":"https://api.github.com/users/cwjohnston/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cwjohnston/subscriptions","organizations_url":"https://api.github.com/users/cwjohnston/orgs","repos_url":"https://api.github.com/users/cwjohnston/repos","events_url":"https://api.github.com/users/cwjohnston/events{/privacy}","received_events_url":"https://api.github.com/users/cwjohnston/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/sensu/sensu-chef/milestones/1","html_url":"https://github.com/sensu/sensu-chef/milestones/3.0.0","labels_url":"https://api.github.com/repos/sensu/sensu-chef/milestones/1/labels","id":1623246,"number":1,"title":"3.0.0","description":"","creator":{"login":"cwjohnston","id":148017,"avatar_url":"https://avatars.githubusercontent.com/u/148017?v=3","gravatar_id":"","url":"https://api.github.com/users/cwjohnston","html_url":"https://github.com/cwjohnston","followers_url":"https://api.github.com/users/cwjohnston/followers","following_url":"https://api.github.com/users/cwjohnston/following{/other_user}","gists_url":"https://api.github.com/users/cwjohnston/gists{/gist_id}","starred_url":"https://api.github.com/users/cwjohnston/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cwjohnston/subscriptions","organizations_url":"https://api.github.com/users/cwjohnston/orgs","repos_url":"https://api.github.com/users/cwjohnston/repos","events_url":"https://api.github.com/users/cwjohnston/events{/privacy}","received_events_url":"https://api.github.com/users/cwjohnston/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":10,"state":"open","created_at":"2016-03-04T22:46:58Z","updated_at":"2016-06-09T18:51:57Z","due_on":null,"closed_at":null},"comments":1,"created_at":"2016-06-03T18:56:07Z","updated_at":"2016-06-20T22:30:59Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/sensu/sensu-chef/pulls/455","html_url":"https://github.com/sensu/sensu-chef/pull/455","diff_url":"https://github.com/sensu/sensu-chef/pull/455.diff","patch_url":"https://github.com/sensu/sensu-chef/pull/455.patch"},"body":"## Description\r\n\r\nThis PR proposes the following changes:\r\n\r\n* Add dependency on `ms_dotnet` cookbook\r\n* Make installation of .Net Framework optional, controlled by new `node[\"sensu\"][\"windows\"][\"install_dotnet\"]` attribute.\r\n* Use value of new `node[\"sensu\"][\"windows\"][\"dotnet_major_version\"]` for determining which recipe to include from `ms_dotnet` cookbook\r\n* Add windows-2008r2 to test-kitchen platforms\r\n* Update test-kitchen and add gems to support use of [WinRM elevated transport](https://github.com/test-kitchen/test-kitchen/pull/1012)\r\n* Add indirection helper methods around Windows-specific modules to make ChefSpec testing more straight-forward. Without these methods we have to use Rspec stubs on the include_recipe, which makes testing some things much more difficult.\r\n\r\n## Motivation and Context\r\n\r\nAs described in https://github.com/sensu/sensu-chef/issues/423#issuecomment-193914272, I believe it is desirable to make .Net Framework installation optional, and to \"outsource\" the installation to another cookbook which is responsible for the isolated logic of that operation.\r\n\r\n## How Has This Been Tested?\r\n\r\nThe `default` suite is passing on both windows-2008r2 and windows-2012r2 in my local test-kitchen environment. Unit tests are also passing.\r\n\r\n## Screenshots (if appropriate):\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [X] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [X] My change requires a change to the documentation.\r\n- [X] I have updated the documentation accordingly.\r\n- [X] I have read the **CONTRIBUTING** document."},"comment":{"url":"https://api.github.com/repos/sensu/sensu-chef/issues/comments/227289816","html_url":"https://github.com/sensu/sensu-chef/pull/455#issuecomment-227289816","issue_url":"https://api.github.com/repos/sensu/sensu-chef/issues/455","id":227289816,"user":{"login":"majormoses","id":3145127,"avatar_url":"https://avatars.githubusercontent.com/u/3145127?v=3","gravatar_id":"","url":"https://api.github.com/users/majormoses","html_url":"https://github.com/majormoses","followers_url":"https://api.github.com/users/majormoses/followers","following_url":"https://api.github.com/users/majormoses/following{/other_user}","gists_url":"https://api.github.com/users/majormoses/gists{/gist_id}","starred_url":"https://api.github.com/users/majormoses/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/majormoses/subscriptions","organizations_url":"https://api.github.com/users/majormoses/orgs","repos_url":"https://api.github.com/users/majormoses/repos","events_url":"https://api.github.com/users/majormoses/events{/privacy}","received_events_url":"https://api.github.com/users/majormoses/received_events","type":"User","site_admin":false},"created_at":"2016-06-20T22:30:58Z","updated_at":"2016-06-20T22:30:58Z","body":"@cwjohnston imho it feels out of scope to install .net here in this cookbook. I feel like the Elasticsearch cookbook approach might be better here...require users to install java, ruby, .net, etc via other means. "}}
{"actor":{"display_login":"majormoses"}}