{"action":"created","comment":{"url":"https://api.github.com/repos/lxde/lxqt-session/pulls/comments/57777394","id":57777394,"diff_hunk":"@@ -106,6 +106,6 @@ int main(int argc, char *argv[])\n                 Qt::AlignCenter,\n                 dialog.size(),\n                 qApp->desktop()->screenGeometry(QCursor::pos())));\n-    dialog.setMaximumSize(dialog.minimumSize());\n+    dialog.setMaximumSize(dialog.size());","path":"lxqt-leave/main.cpp","position":5,"original_position":5,"commit_id":"477faf5bf0c381ad457095247a46fe037ae24817","original_commit_id":"477faf5bf0c381ad457095247a46fe037ae24817","user":{"login":"paulolieuthier","id":1238157,"avatar_url":"https://avatars.githubusercontent.com/u/1238157?v=3","gravatar_id":"","url":"https://api.github.com/users/paulolieuthier","html_url":"https://github.com/paulolieuthier","followers_url":"https://api.github.com/users/paulolieuthier/followers","following_url":"https://api.github.com/users/paulolieuthier/following{/other_user}","gists_url":"https://api.github.com/users/paulolieuthier/gists{/gist_id}","starred_url":"https://api.github.com/users/paulolieuthier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulolieuthier/subscriptions","organizations_url":"https://api.github.com/users/paulolieuthier/orgs","repos_url":"https://api.github.com/users/paulolieuthier/repos","events_url":"https://api.github.com/users/paulolieuthier/events{/privacy}","received_events_url":"https://api.github.com/users/paulolieuthier/received_events","type":"User","site_admin":false},"body":"Yeah, I thought that. And tested. `sizeHint()` returned a smaller size than `size()`. As you can see, `size()` has been used in the previous function call. We can set `minimumSize` to `sizeHint()` and rest assured, do you agree?","created_at":"2016-03-29T18:41:45Z","updated_at":"2016-03-29T18:41:45Z","html_url":"https://github.com/lxde/lxqt-session/pull/65#discussion_r57777394","pull_request_url":"https://api.github.com/repos/lxde/lxqt-session/pulls/65","_links":{"self":{"href":"https://api.github.com/repos/lxde/lxqt-session/pulls/comments/57777394"},"html":{"href":"https://github.com/lxde/lxqt-session/pull/65#discussion_r57777394"},"pull_request":{"href":"https://api.github.com/repos/lxde/lxqt-session/pulls/65"}}},"pull_request":{"url":"https://api.github.com/repos/lxde/lxqt-session/pulls/65","id":64339382,"html_url":"https://github.com/lxde/lxqt-session/pull/65","diff_url":"https://github.com/lxde/lxqt-session/pull/65.diff","patch_url":"https://github.com/lxde/lxqt-session/pull/65.patch","issue_url":"https://api.github.com/repos/lxde/lxqt-session/issues/65","number":65,"state":"open","locked":false,"title":"Fix lxqt-leave's dialog to not set maximum size as minimum size","user":{"login":"paulolieuthier","id":1238157,"avatar_url":"https://avatars.githubusercontent.com/u/1238157?v=3","gravatar_id":"","url":"https://api.github.com/users/paulolieuthier","html_url":"https://github.com/paulolieuthier","followers_url":"https://api.github.com/users/paulolieuthier/followers","following_url":"https://api.github.com/users/paulolieuthier/following{/other_user}","gists_url":"https://api.github.com/users/paulolieuthier/gists{/gist_id}","starred_url":"https://api.github.com/users/paulolieuthier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulolieuthier/subscriptions","organizations_url":"https://api.github.com/users/paulolieuthier/orgs","repos_url":"https://api.github.com/users/paulolieuthier/repos","events_url":"https://api.github.com/users/paulolieuthier/events{/privacy}","received_events_url":"https://api.github.com/users/paulolieuthier/received_events","type":"User","site_admin":false},"body":"That leads to a zero-sized window.","created_at":"2016-03-28T16:21:21Z","updated_at":"2016-03-29T18:41:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e8091937ed5fe4ad840c239e42c6d82a5e4a8ee5","assignee":{"login":"pmattern","id":9860801,"avatar_url":"https://avatars.githubusercontent.com/u/9860801?v=3","gravatar_id":"","url":"https://api.github.com/users/pmattern","html_url":"https://github.com/pmattern","followers_url":"https://api.github.com/users/pmattern/followers","following_url":"https://api.github.com/users/pmattern/following{/other_user}","gists_url":"https://api.github.com/users/pmattern/gists{/gist_id}","starred_url":"https://api.github.com/users/pmattern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmattern/subscriptions","organizations_url":"https://api.github.com/users/pmattern/orgs","repos_url":"https://api.github.com/users/pmattern/repos","events_url":"https://api.github.com/users/pmattern/events{/privacy}","received_events_url":"https://api.github.com/users/pmattern/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/lxde/lxqt-session/pulls/65/commits","review_comments_url":"https://api.github.com/repos/lxde/lxqt-session/pulls/65/comments","review_comment_url":"https://api.github.com/repos/lxde/lxqt-session/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lxde/lxqt-session/issues/65/comments","statuses_url":"https://api.github.com/repos/lxde/lxqt-session/statuses/477faf5bf0c381ad457095247a46fe037ae24817","head":{"label":"lxde:fix-leave-dialog","ref":"fix-leave-dialog","sha":"477faf5bf0c381ad457095247a46fe037ae24817","user":{"login":"lxde","id":4973989,"avatar_url":"https://avatars.githubusercontent.com/u/4973989?v=3","gravatar_id":"","url":"https://api.github.com/users/lxde","html_url":"https://github.com/lxde","followers_url":"https://api.github.com/users/lxde/followers","following_url":"https://api.github.com/users/lxde/following{/other_user}","gists_url":"https://api.github.com/users/lxde/gists{/gist_id}","starred_url":"https://api.github.com/users/lxde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lxde/subscriptions","organizations_url":"https://api.github.com/users/lxde/orgs","repos_url":"https://api.github.com/users/lxde/repos","events_url":"https://api.github.com/users/lxde/events{/privacy}","received_events_url":"https://api.github.com/users/lxde/received_events","type":"Organization","site_admin":false},"repo":{"id":15647808,"name":"lxqt-session","full_name":"lxde/lxqt-session","owner":{"login":"lxde","id":4973989,"avatar_url":"https://avatars.githubusercontent.com/u/4973989?v=3","gravatar_id":"","url":"https://api.github.com/users/lxde","html_url":"https://github.com/lxde","followers_url":"https://api.github.com/users/lxde/followers","following_url":"https://api.github.com/users/lxde/following{/other_user}","gists_url":"https://api.github.com/users/lxde/gists{/gist_id}","starred_url":"https://api.github.com/users/lxde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lxde/subscriptions","organizations_url":"https://api.github.com/users/lxde/orgs","repos_url":"https://api.github.com/users/lxde/repos","events_url":"https://api.github.com/users/lxde/events{/privacy}","received_events_url":"https://api.github.com/users/lxde/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lxde/lxqt-session","description":"An alternative session manager ported from the original razor-session","fork":false,"url":"https://api.github.com/repos/lxde/lxqt-session","forks_url":"https://api.github.com/repos/lxde/lxqt-session/forks","keys_url":"https://api.github.com/repos/lxde/lxqt-session/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lxde/lxqt-session/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lxde/lxqt-session/teams","hooks_url":"https://api.github.com/repos/lxde/lxqt-session/hooks","issue_events_url":"https://api.github.com/repos/lxde/lxqt-session/issues/events{/number}","events_url":"https://api.github.com/repos/lxde/lxqt-session/events","assignees_url":"https://api.github.com/repos/lxde/lxqt-session/assignees{/user}","branches_url":"https://api.github.com/repos/lxde/lxqt-session/branches{/branch}","tags_url":"https://api.github.com/repos/lxde/lxqt-session/tags","blobs_url":"https://api.github.com/repos/lxde/lxqt-session/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lxde/lxqt-session/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lxde/lxqt-session/git/refs{/sha}","trees_url":"https://api.github.com/repos/lxde/lxqt-session/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lxde/lxqt-session/statuses/{sha}","languages_url":"https://api.github.com/repos/lxde/lxqt-session/languages","stargazers_url":"https://api.github.com/repos/lxde/lxqt-session/stargazers","contributors_url":"https://api.github.com/repos/lxde/lxqt-session/contributors","subscribers_url":"https://api.github.com/repos/lxde/lxqt-session/subscribers","subscription_url":"https://api.github.com/repos/lxde/lxqt-session/subscription","commits_url":"https://api.github.com/repos/lxde/lxqt-session/commits{/sha}","git_commits_url":"https://api.github.com/repos/lxde/lxqt-session/git/commits{/sha}","comments_url":"https://api.github.com/repos/lxde/lxqt-session/comments{/number}","issue_comment_url":"https://api.github.com/repos/lxde/lxqt-session/issues/comments{/number}","contents_url":"https://api.github.com/repos/lxde/lxqt-session/contents/{+path}","compare_url":"https://api.github.com/repos/lxde/lxqt-session/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lxde/lxqt-session/merges","archive_url":"https://api.github.com/repos/lxde/lxqt-session/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lxde/lxqt-session/downloads","issues_url":"https://api.github.com/repos/lxde/lxqt-session/issues{/number}","pulls_url":"https://api.github.com/repos/lxde/lxqt-session/pulls{/number}","milestones_url":"https://api.github.com/repos/lxde/lxqt-session/milestones{/number}","notifications_url":"https://api.github.com/repos/lxde/lxqt-session/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lxde/lxqt-session/labels{/name}","releases_url":"https://api.github.com/repos/lxde/lxqt-session/releases{/id}","deployments_url":"https://api.github.com/repos/lxde/lxqt-session/deployments","created_at":"2014-01-05T08:16:16Z","updated_at":"2016-01-13T10:50:13Z","pushed_at":"2016-03-29T13:56:37Z","git_url":"git://github.com/lxde/lxqt-session.git","ssh_url":"git@github.com:lxde/lxqt-session.git","clone_url":"https://github.com/lxde/lxqt-session.git","svn_url":"https://github.com/lxde/lxqt-session","homepage":null,"size":918,"stargazers_count":12,"watchers_count":12,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":24,"mirror_url":null,"open_issues_count":2,"forks":24,"open_issues":2,"watchers":12,"default_branch":"master"}},"base":{"label":"lxde:master","ref":"master","sha":"a69de25fe6a2a178a1318d805dbde1353c3af5ea","user":{"login":"lxde","id":4973989,"avatar_url":"https://avatars.githubusercontent.com/u/4973989?v=3","gravatar_id":"","url":"https://api.github.com/users/lxde","html_url":"https://github.com/lxde","followers_url":"https://api.github.com/users/lxde/followers","following_url":"https://api.github.com/users/lxde/following{/other_user}","gists_url":"https://api.github.com/users/lxde/gists{/gist_id}","starred_url":"https://api.github.com/users/lxde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lxde/subscriptions","organizations_url":"https://api.github.com/users/lxde/orgs","repos_url":"https://api.github.com/users/lxde/repos","events_url":"https://api.github.com/users/lxde/events{/privacy}","received_events_url":"https://api.github.com/users/lxde/received_events","type":"Organization","site_admin":false},"repo":{"id":15647808,"name":"lxqt-session","full_name":"lxde/lxqt-session","owner":{"login":"lxde","id":4973989,"avatar_url":"https://avatars.githubusercontent.com/u/4973989?v=3","gravatar_id":"","url":"https://api.github.com/users/lxde","html_url":"https://github.com/lxde","followers_url":"https://api.github.com/users/lxde/followers","following_url":"https://api.github.com/users/lxde/following{/other_user}","gists_url":"https://api.github.com/users/lxde/gists{/gist_id}","starred_url":"https://api.github.com/users/lxde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lxde/subscriptions","organizations_url":"https://api.github.com/users/lxde/orgs","repos_url":"https://api.github.com/users/lxde/repos","events_url":"https://api.github.com/users/lxde/events{/privacy}","received_events_url":"https://api.github.com/users/lxde/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lxde/lxqt-session","description":"An alternative session manager ported from the original razor-session","fork":false,"url":"https://api.github.com/repos/lxde/lxqt-session","forks_url":"https://api.github.com/repos/lxde/lxqt-session/forks","keys_url":"https://api.github.com/repos/lxde/lxqt-session/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lxde/lxqt-session/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lxde/lxqt-session/teams","hooks_url":"https://api.github.com/repos/lxde/lxqt-session/hooks","issue_events_url":"https://api.github.com/repos/lxde/lxqt-session/issues/events{/number}","events_url":"https://api.github.com/repos/lxde/lxqt-session/events","assignees_url":"https://api.github.com/repos/lxde/lxqt-session/assignees{/user}","branches_url":"https://api.github.com/repos/lxde/lxqt-session/branches{/branch}","tags_url":"https://api.github.com/repos/lxde/lxqt-session/tags","blobs_url":"https://api.github.com/repos/lxde/lxqt-session/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lxde/lxqt-session/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lxde/lxqt-session/git/refs{/sha}","trees_url":"https://api.github.com/repos/lxde/lxqt-session/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lxde/lxqt-session/statuses/{sha}","languages_url":"https://api.github.com/repos/lxde/lxqt-session/languages","stargazers_url":"https://api.github.com/repos/lxde/lxqt-session/stargazers","contributors_url":"https://api.github.com/repos/lxde/lxqt-session/contributors","subscribers_url":"https://api.github.com/repos/lxde/lxqt-session/subscribers","subscription_url":"https://api.github.com/repos/lxde/lxqt-session/subscription","commits_url":"https://api.github.com/repos/lxde/lxqt-session/commits{/sha}","git_commits_url":"https://api.github.com/repos/lxde/lxqt-session/git/commits{/sha}","comments_url":"https://api.github.com/repos/lxde/lxqt-session/comments{/number}","issue_comment_url":"https://api.github.com/repos/lxde/lxqt-session/issues/comments{/number}","contents_url":"https://api.github.com/repos/lxde/lxqt-session/contents/{+path}","compare_url":"https://api.github.com/repos/lxde/lxqt-session/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lxde/lxqt-session/merges","archive_url":"https://api.github.com/repos/lxde/lxqt-session/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lxde/lxqt-session/downloads","issues_url":"https://api.github.com/repos/lxde/lxqt-session/issues{/number}","pulls_url":"https://api.github.com/repos/lxde/lxqt-session/pulls{/number}","milestones_url":"https://api.github.com/repos/lxde/lxqt-session/milestones{/number}","notifications_url":"https://api.github.com/repos/lxde/lxqt-session/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lxde/lxqt-session/labels{/name}","releases_url":"https://api.github.com/repos/lxde/lxqt-session/releases{/id}","deployments_url":"https://api.github.com/repos/lxde/lxqt-session/deployments","created_at":"2014-01-05T08:16:16Z","updated_at":"2016-01-13T10:50:13Z","pushed_at":"2016-03-29T13:56:37Z","git_url":"git://github.com/lxde/lxqt-session.git","ssh_url":"git@github.com:lxde/lxqt-session.git","clone_url":"https://github.com/lxde/lxqt-session.git","svn_url":"https://github.com/lxde/lxqt-session","homepage":null,"size":918,"stargazers_count":12,"watchers_count":12,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":24,"mirror_url":null,"open_issues_count":2,"forks":24,"open_issues":2,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lxde/lxqt-session/pulls/65"},"html":{"href":"https://github.com/lxde/lxqt-session/pull/65"},"issue":{"href":"https://api.github.com/repos/lxde/lxqt-session/issues/65"},"comments":{"href":"https://api.github.com/repos/lxde/lxqt-session/issues/65/comments"},"review_comments":{"href":"https://api.github.com/repos/lxde/lxqt-session/pulls/65/comments"},"review_comment":{"href":"https://api.github.com/repos/lxde/lxqt-session/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lxde/lxqt-session/pulls/65/commits"},"statuses":{"href":"https://api.github.com/repos/lxde/lxqt-session/statuses/477faf5bf0c381ad457095247a46fe037ae24817"}}}}