{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/90588068","pull_request_review_id":11107371,"id":90588068,"diff_hunk":"@@ -3429,6 +3431,19 @@ void CodeGen::genReportEH()\n \n         CORINFO_EH_CLAUSE_FLAGS flags = ToCORINFO_EH_CLAUSE_FLAGS(HBtab->ebdHandlerType);\n \n+        if (isCoreRTABI && (XTnum > 0))\n+        {\n+            // For CoreRT, CORINFO_EH_CLAUSE_SAMETRY flag means that the current clause covers same\n+            // try block as the previous one. The runtime cannot reliably infer this information from\n+            // native code offsets because of different try blocks can have same offsets. Alternative\n+            // solution to this problem would be inserting extra nops to ensure that different try\n+            // blocks have different offsets.\n+            if (EHblkDsc::ebdIsSameTry(HBtab, HBtab - 1))\n+            {\n+                flags = (CORINFO_EH_CLAUSE_FLAGS)(flags | CORINFO_EH_CLAUSE_SAMETRY);","path":"src/jit/codegencommon.cpp","position":null,"original_position":40,"commit_id":"9e54ff2b390991b8d3e15b8cd0a071b1a7edb745","original_commit_id":"2ae1226a5306c7f3c38dceae8153b7df40b43b9c","user":{"login":"jkotas","id":6668460,"avatar_url":"https://avatars.githubusercontent.com/u/6668460?v=3","gravatar_id":"","url":"https://api.github.com/users/jkotas","html_url":"https://github.com/jkotas","followers_url":"https://api.github.com/users/jkotas/followers","following_url":"https://api.github.com/users/jkotas/following{/other_user}","gists_url":"https://api.github.com/users/jkotas/gists{/gist_id}","starred_url":"https://api.github.com/users/jkotas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkotas/subscriptions","organizations_url":"https://api.github.com/users/jkotas/orgs","repos_url":"https://api.github.com/users/jkotas/repos","events_url":"https://api.github.com/users/jkotas/events{/privacy}","received_events_url":"https://api.github.com/users/jkotas/received_events","type":"User","site_admin":false},"body":"Thanks - I have added assert for `HasCatchHandler()`.\r\n\r\nI will think about good asserts in the CoreRT side. The runtime won't actually see this bit as is. The whole table is compressed with variable length encoding, and there is no natural place for this bit in the compressed form. [My current implementation](https://github.com/dotnet/corert/pull/2288/files) is inserting empty clauses in the compressed form if it is necessary to explicitly separate runs with the same offset.","created_at":"2016-12-02T05:14:24Z","updated_at":"2016-12-02T05:14:24Z","html_url":"https://github.com/dotnet/coreclr/pull/8422#discussion_r90588068","pull_request_url":"https://api.github.com/repos/dotnet/coreclr/pulls/8422","_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/90588068"},"html":{"href":"https://github.com/dotnet/coreclr/pull/8422#discussion_r90588068"},"pull_request":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/8422"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/8422","id":96212949,"html_url":"https://github.com/dotnet/coreclr/pull/8422","diff_url":"https://github.com/dotnet/coreclr/pull/8422.diff","patch_url":"https://github.com/dotnet/coreclr/pull/8422.patch","issue_url":"https://api.github.com/repos/dotnet/coreclr/issues/8422","number":8422,"state":"open","locked":false,"title":"Introduce CORINFO_EH_CLAUSE_SAMETRY flag for CoreRT ABI","user":{"login":"jkotas","id":6668460,"avatar_url":"https://avatars.githubusercontent.com/u/6668460?v=3","gravatar_id":"","url":"https://api.github.com/users/jkotas","html_url":"https://github.com/jkotas","followers_url":"https://api.github.com/users/jkotas/followers","following_url":"https://api.github.com/users/jkotas/following{/other_user}","gists_url":"https://api.github.com/users/jkotas/gists{/gist_id}","starred_url":"https://api.github.com/users/jkotas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkotas/subscriptions","organizations_url":"https://api.github.com/users/jkotas/orgs","repos_url":"https://api.github.com/users/jkotas/repos","events_url":"https://api.github.com/users/jkotas/events{/privacy}","received_events_url":"https://api.github.com/users/jkotas/received_events","type":"User","site_admin":false},"body":"CORINFO_EH_CLAUSE_SAMEBLOCK flag is returned on mutually protecting EH clauses for CoreRT ABI. It is set on EH clauses that cover same try block as the previous one. The runtime cannot reliably infer this information from native code offsets without full description of duplicate clauses because of different try blocks can have same offsets. Alternative solution to this problem would be inserting extra nops to ensure that different try blocks have different offsets.","created_at":"2016-12-02T02:56:01Z","updated_at":"2016-12-02T05:14:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"408cf9e4fba55cdaa38a522007f3c509092304b8","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/coreclr/pulls/8422/commits","review_comments_url":"https://api.github.com/repos/dotnet/coreclr/pulls/8422/comments","review_comment_url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/coreclr/issues/8422/comments","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/9e54ff2b390991b8d3e15b8cd0a071b1a7edb745","head":{"label":"jkotas:CoreRT-EH","ref":"CoreRT-EH","sha":"9e54ff2b390991b8d3e15b8cd0a071b1a7edb745","user":{"login":"jkotas","id":6668460,"avatar_url":"https://avatars.githubusercontent.com/u/6668460?v=3","gravatar_id":"","url":"https://api.github.com/users/jkotas","html_url":"https://github.com/jkotas","followers_url":"https://api.github.com/users/jkotas/followers","following_url":"https://api.github.com/users/jkotas/following{/other_user}","gists_url":"https://api.github.com/users/jkotas/gists{/gist_id}","starred_url":"https://api.github.com/users/jkotas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkotas/subscriptions","organizations_url":"https://api.github.com/users/jkotas/orgs","repos_url":"https://api.github.com/users/jkotas/repos","events_url":"https://api.github.com/users/jkotas/events{/privacy}","received_events_url":"https://api.github.com/users/jkotas/received_events","type":"User","site_admin":false},"repo":{"id":30278571,"name":"coreclr","full_name":"jkotas/coreclr","owner":{"login":"jkotas","id":6668460,"avatar_url":"https://avatars.githubusercontent.com/u/6668460?v=3","gravatar_id":"","url":"https://api.github.com/users/jkotas","html_url":"https://github.com/jkotas","followers_url":"https://api.github.com/users/jkotas/followers","following_url":"https://api.github.com/users/jkotas/following{/other_user}","gists_url":"https://api.github.com/users/jkotas/gists{/gist_id}","starred_url":"https://api.github.com/users/jkotas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkotas/subscriptions","organizations_url":"https://api.github.com/users/jkotas/orgs","repos_url":"https://api.github.com/users/jkotas/repos","events_url":"https://api.github.com/users/jkotas/events{/privacy}","received_events_url":"https://api.github.com/users/jkotas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jkotas/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR. It is an execution engine for .NET apps, performing functions such as IL byte code loading, compilation to machine code and garbage collection. The repo contains the complete up-to-date CoreCLR codebase.","fork":true,"url":"https://api.github.com/repos/jkotas/coreclr","forks_url":"https://api.github.com/repos/jkotas/coreclr/forks","keys_url":"https://api.github.com/repos/jkotas/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jkotas/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jkotas/coreclr/teams","hooks_url":"https://api.github.com/repos/jkotas/coreclr/hooks","issue_events_url":"https://api.github.com/repos/jkotas/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/jkotas/coreclr/events","assignees_url":"https://api.github.com/repos/jkotas/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/jkotas/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/jkotas/coreclr/tags","blobs_url":"https://api.github.com/repos/jkotas/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jkotas/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jkotas/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/jkotas/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jkotas/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/jkotas/coreclr/languages","stargazers_url":"https://api.github.com/repos/jkotas/coreclr/stargazers","contributors_url":"https://api.github.com/repos/jkotas/coreclr/contributors","subscribers_url":"https://api.github.com/repos/jkotas/coreclr/subscribers","subscription_url":"https://api.github.com/repos/jkotas/coreclr/subscription","commits_url":"https://api.github.com/repos/jkotas/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/jkotas/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/jkotas/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/jkotas/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/jkotas/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/jkotas/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jkotas/coreclr/merges","archive_url":"https://api.github.com/repos/jkotas/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jkotas/coreclr/downloads","issues_url":"https://api.github.com/repos/jkotas/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/jkotas/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/jkotas/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/jkotas/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jkotas/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/jkotas/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/jkotas/coreclr/deployments","created_at":"2015-02-04T03:09:04Z","updated_at":"2016-10-22T02:46:15Z","pushed_at":"2016-12-02T04:59:35Z","git_url":"git://github.com/jkotas/coreclr.git","ssh_url":"git@github.com:jkotas/coreclr.git","clone_url":"https://github.com/jkotas/coreclr.git","svn_url":"https://github.com/jkotas/coreclr","homepage":"","size":120618,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"cb4ac230e8d0a55a7a972fa7e433703fc25629f1","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":30092893,"name":"coreclr","full_name":"dotnet/coreclr","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called mscorlib. It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes.","fork":false,"url":"https://api.github.com/repos/dotnet/coreclr","forks_url":"https://api.github.com/repos/dotnet/coreclr/forks","keys_url":"https://api.github.com/repos/dotnet/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/coreclr/teams","hooks_url":"https://api.github.com/repos/dotnet/coreclr/hooks","issue_events_url":"https://api.github.com/repos/dotnet/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/coreclr/events","assignees_url":"https://api.github.com/repos/dotnet/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/coreclr/tags","blobs_url":"https://api.github.com/repos/dotnet/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/coreclr/languages","stargazers_url":"https://api.github.com/repos/dotnet/coreclr/stargazers","contributors_url":"https://api.github.com/repos/dotnet/coreclr/contributors","subscribers_url":"https://api.github.com/repos/dotnet/coreclr/subscribers","subscription_url":"https://api.github.com/repos/dotnet/coreclr/subscription","commits_url":"https://api.github.com/repos/dotnet/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/coreclr/merges","archive_url":"https://api.github.com/repos/dotnet/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/coreclr/downloads","issues_url":"https://api.github.com/repos/dotnet/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/coreclr/deployments","created_at":"2015-01-30T22:10:02Z","updated_at":"2016-12-01T18:00:37Z","pushed_at":"2016-12-02T04:59:36Z","git_url":"git://github.com/dotnet/coreclr.git","ssh_url":"git@github.com:dotnet/coreclr.git","clone_url":"https://github.com/dotnet/coreclr.git","svn_url":"https://github.com/dotnet/coreclr","homepage":"https://docs.microsoft.com/dotnet/","size":137462,"stargazers_count":7108,"watchers_count":7108,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1728,"mirror_url":null,"open_issues_count":1040,"forks":1728,"open_issues":1040,"watchers":7108,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/8422"},"html":{"href":"https://github.com/dotnet/coreclr/pull/8422"},"issue":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/8422"},"comments":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/8422/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/8422/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/8422/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/coreclr/statuses/9e54ff2b390991b8d3e15b8cd0a071b1a7edb745"}}}}
{"actor":{"display_login":"jkotas"}}