{"action":"created","issue":{"url":"https://api.github.com/repos/haiwen/seafile/issues/1696","repository_url":"https://api.github.com/repos/haiwen/seafile","labels_url":"https://api.github.com/repos/haiwen/seafile/issues/1696/labels{/name}","comments_url":"https://api.github.com/repos/haiwen/seafile/issues/1696/comments","events_url":"https://api.github.com/repos/haiwen/seafile/issues/1696/events","html_url":"https://github.com/haiwen/seafile/issues/1696","id":161258419,"number":1696,"title":"Windows client - Local worktree not getting deleted if \"do not unsync\" is checked.","user":{"login":"Lonsarg","id":6533833,"avatar_url":"https://avatars.githubusercontent.com/u/6533833?v=3","gravatar_id":"","url":"https://api.github.com/users/Lonsarg","html_url":"https://github.com/Lonsarg","followers_url":"https://api.github.com/users/Lonsarg/followers","following_url":"https://api.github.com/users/Lonsarg/following{/other_user}","gists_url":"https://api.github.com/users/Lonsarg/gists{/gist_id}","starred_url":"https://api.github.com/users/Lonsarg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lonsarg/subscriptions","organizations_url":"https://api.github.com/users/Lonsarg/orgs","repos_url":"https://api.github.com/users/Lonsarg/repos","events_url":"https://api.github.com/users/Lonsarg/events{/privacy}","received_events_url":"https://api.github.com/users/Lonsarg/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-06-20T18:11:14Z","updated_at":"2016-06-21T19:04:38Z","closed_at":"2016-06-20T20:34:49Z","body":"Hi, i think i found a little bug. I had \"Do not automatically unsync a library\" checked, which should only prevent unsynching if local directory is missing. But what this setting was also cousing was A LOT of warning in log(and probably wasting CPU time): \r\nrepo-mgr.c(760): Failed to access worktree C:/Users/rober/Seafile\\Šodr for repo 'Šodr'(8096df76)\r\n\r\nAfter i removed this checkbox and restarted Seafile i got this:\r\nrepo-mgr.c(7085): Worktree for repo \"Šodr\" is invalid, delete it.\r\n\r\nAfter this even if i checked setting again warning did not produce itself anymore, so i have concluded that a side effect of this setting is preventing local worktrees for deleted libraries(it was deleted on both client and server) from clearing."},"comment":{"url":"https://api.github.com/repos/haiwen/seafile/issues/comments/227539458","html_url":"https://github.com/haiwen/seafile/issues/1696#issuecomment-227539458","issue_url":"https://api.github.com/repos/haiwen/seafile/issues/1696","id":227539458,"user":{"login":"Lonsarg","id":6533833,"avatar_url":"https://avatars.githubusercontent.com/u/6533833?v=3","gravatar_id":"","url":"https://api.github.com/users/Lonsarg","html_url":"https://github.com/Lonsarg","followers_url":"https://api.github.com/users/Lonsarg/followers","following_url":"https://api.github.com/users/Lonsarg/following{/other_user}","gists_url":"https://api.github.com/users/Lonsarg/gists{/gist_id}","starred_url":"https://api.github.com/users/Lonsarg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lonsarg/subscriptions","organizations_url":"https://api.github.com/users/Lonsarg/orgs","repos_url":"https://api.github.com/users/Lonsarg/repos","events_url":"https://api.github.com/users/Lonsarg/events{/privacy}","received_events_url":"https://api.github.com/users/Lonsarg/received_events","type":"User","site_admin":false},"created_at":"2016-06-21T19:04:38Z","updated_at":"2016-06-21T19:04:38Z","body":"Ok i may have not completely understood the issue. Now i see my case is very rare, because i had both unsync prevention(local and server) set when library was deleted and only later unchecked the server one. If i had this settings from begining everything would work as intended.\r\n\r\nStill, first setting(prevent unsync if local folder missing) could be smart to check if library exists on server and not fire up if it does not, cause we already have second setting for that(prevent unsync if server library missing). But since this case is rare, it is probably not worth the time."}}
{"actor":{"display_login":"Lonsarg"}}