{"action":"created","comment":{"url":"https://api.github.com/repos/docker/machine/pulls/comments/75711768","id":75711768,"diff_hunk":"@@ -1103,14 +1104,15 @@ func (d *Driver) configureSecurityGroupPermissions(group *ec2.SecurityGroup) ([]\n \t}\n \n \tfor _, p := range d.OpenPorts {\n-\t\tport, protocol, err := splitPortProto(p)\n+\t\tport, protocol := driverutil.SplitPortProto(p)\n+\t\tportNum, err := strconv.Atoi(port)","path":"drivers/amazonec2/amazonec2.go","position":14,"original_position":14,"commit_id":"dd6aba6f35878bfe06802646a3306b95d3015382","original_commit_id":"dd6aba6f35878bfe06802646a3306b95d3015382","user":{"login":"ahmetalpbalkan","id":159209,"avatar_url":"https://avatars.githubusercontent.com/u/159209?v=3","gravatar_id":"","url":"https://api.github.com/users/ahmetalpbalkan","html_url":"https://github.com/ahmetalpbalkan","followers_url":"https://api.github.com/users/ahmetalpbalkan/followers","following_url":"https://api.github.com/users/ahmetalpbalkan/following{/other_user}","gists_url":"https://api.github.com/users/ahmetalpbalkan/gists{/gist_id}","starred_url":"https://api.github.com/users/ahmetalpbalkan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahmetalpbalkan/subscriptions","organizations_url":"https://api.github.com/users/ahmetalpbalkan/orgs","repos_url":"https://api.github.com/users/ahmetalpbalkan/repos","events_url":"https://api.github.com/users/ahmetalpbalkan/events{/privacy}","received_events_url":"https://api.github.com/users/ahmetalpbalkan/received_events","type":"User","site_admin":false},"body":"use strconv.ParseInt, it already returns int64 so you dont have to typecast again below.","created_at":"2016-08-22T16:35:27Z","updated_at":"2016-08-22T16:35:27Z","html_url":"https://github.com/docker/machine/pull/3687#discussion_r75711768","pull_request_url":"https://api.github.com/repos/docker/machine/pulls/3687","_links":{"self":{"href":"https://api.github.com/repos/docker/machine/pulls/comments/75711768"},"html":{"href":"https://github.com/docker/machine/pull/3687#discussion_r75711768"},"pull_request":{"href":"https://api.github.com/repos/docker/machine/pulls/3687"}}},"pull_request":{"url":"https://api.github.com/repos/docker/machine/pulls/3687","id":82087708,"html_url":"https://github.com/docker/machine/pull/3687","diff_url":"https://github.com/docker/machine/pull/3687.diff","patch_url":"https://github.com/docker/machine/pull/3687.patch","issue_url":"https://api.github.com/repos/docker/machine/issues/3687","number":3687,"state":"open","locked":false,"title":"azure: add --azure-open-port support for custom protocol","user":{"login":"andrestc","id":2944739,"avatar_url":"https://avatars.githubusercontent.com/u/2944739?v=3","gravatar_id":"","url":"https://api.github.com/users/andrestc","html_url":"https://github.com/andrestc","followers_url":"https://api.github.com/users/andrestc/followers","following_url":"https://api.github.com/users/andrestc/following{/other_user}","gists_url":"https://api.github.com/users/andrestc/gists{/gist_id}","starred_url":"https://api.github.com/users/andrestc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrestc/subscriptions","organizations_url":"https://api.github.com/users/andrestc/orgs","repos_url":"https://api.github.com/users/andrestc/repos","events_url":"https://api.github.com/users/andrestc/events{/privacy}","received_events_url":"https://api.github.com/users/andrestc/received_events","type":"User","site_admin":false},"body":"This continues the work discussed in #3642 and makes the azure flag compatible with the one implemented on the amazonec2 driver in #3671.\r\n\r\nThe `SplitPortProto` function was moved to a utility package so other drivers can use it; as I couldn't find a package to place it, I created a new one.\r\n\r\ncc @nathanleclaire, @ahmetalpbalkan for review.","created_at":"2016-08-20T19:47:04Z","updated_at":"2016-08-22T16:35:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"17285e382fa545b4abaae9fa9c8b01b7d8a99f83","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/docker/machine/pulls/3687/commits","review_comments_url":"https://api.github.com/repos/docker/machine/pulls/3687/comments","review_comment_url":"https://api.github.com/repos/docker/machine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/machine/issues/3687/comments","statuses_url":"https://api.github.com/repos/docker/machine/statuses/dd6aba6f35878bfe06802646a3306b95d3015382","head":{"label":"andrestc:3642-azure-open-ports-custom-protocol","ref":"3642-azure-open-ports-custom-protocol","sha":"dd6aba6f35878bfe06802646a3306b95d3015382","user":{"login":"andrestc","id":2944739,"avatar_url":"https://avatars.githubusercontent.com/u/2944739?v=3","gravatar_id":"","url":"https://api.github.com/users/andrestc","html_url":"https://github.com/andrestc","followers_url":"https://api.github.com/users/andrestc/followers","following_url":"https://api.github.com/users/andrestc/following{/other_user}","gists_url":"https://api.github.com/users/andrestc/gists{/gist_id}","starred_url":"https://api.github.com/users/andrestc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrestc/subscriptions","organizations_url":"https://api.github.com/users/andrestc/orgs","repos_url":"https://api.github.com/users/andrestc/repos","events_url":"https://api.github.com/users/andrestc/events{/privacy}","received_events_url":"https://api.github.com/users/andrestc/received_events","type":"User","site_admin":false},"repo":{"id":63813609,"name":"machine","full_name":"andrestc/machine","owner":{"login":"andrestc","id":2944739,"avatar_url":"https://avatars.githubusercontent.com/u/2944739?v=3","gravatar_id":"","url":"https://api.github.com/users/andrestc","html_url":"https://github.com/andrestc","followers_url":"https://api.github.com/users/andrestc/followers","following_url":"https://api.github.com/users/andrestc/following{/other_user}","gists_url":"https://api.github.com/users/andrestc/gists{/gist_id}","starred_url":"https://api.github.com/users/andrestc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrestc/subscriptions","organizations_url":"https://api.github.com/users/andrestc/orgs","repos_url":"https://api.github.com/users/andrestc/repos","events_url":"https://api.github.com/users/andrestc/events{/privacy}","received_events_url":"https://api.github.com/users/andrestc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andrestc/machine","description":"Machine management for a container-centric world","fork":true,"url":"https://api.github.com/repos/andrestc/machine","forks_url":"https://api.github.com/repos/andrestc/machine/forks","keys_url":"https://api.github.com/repos/andrestc/machine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andrestc/machine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andrestc/machine/teams","hooks_url":"https://api.github.com/repos/andrestc/machine/hooks","issue_events_url":"https://api.github.com/repos/andrestc/machine/issues/events{/number}","events_url":"https://api.github.com/repos/andrestc/machine/events","assignees_url":"https://api.github.com/repos/andrestc/machine/assignees{/user}","branches_url":"https://api.github.com/repos/andrestc/machine/branches{/branch}","tags_url":"https://api.github.com/repos/andrestc/machine/tags","blobs_url":"https://api.github.com/repos/andrestc/machine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andrestc/machine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andrestc/machine/git/refs{/sha}","trees_url":"https://api.github.com/repos/andrestc/machine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andrestc/machine/statuses/{sha}","languages_url":"https://api.github.com/repos/andrestc/machine/languages","stargazers_url":"https://api.github.com/repos/andrestc/machine/stargazers","contributors_url":"https://api.github.com/repos/andrestc/machine/contributors","subscribers_url":"https://api.github.com/repos/andrestc/machine/subscribers","subscription_url":"https://api.github.com/repos/andrestc/machine/subscription","commits_url":"https://api.github.com/repos/andrestc/machine/commits{/sha}","git_commits_url":"https://api.github.com/repos/andrestc/machine/git/commits{/sha}","comments_url":"https://api.github.com/repos/andrestc/machine/comments{/number}","issue_comment_url":"https://api.github.com/repos/andrestc/machine/issues/comments{/number}","contents_url":"https://api.github.com/repos/andrestc/machine/contents/{+path}","compare_url":"https://api.github.com/repos/andrestc/machine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andrestc/machine/merges","archive_url":"https://api.github.com/repos/andrestc/machine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andrestc/machine/downloads","issues_url":"https://api.github.com/repos/andrestc/machine/issues{/number}","pulls_url":"https://api.github.com/repos/andrestc/machine/pulls{/number}","milestones_url":"https://api.github.com/repos/andrestc/machine/milestones{/number}","notifications_url":"https://api.github.com/repos/andrestc/machine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andrestc/machine/labels{/name}","releases_url":"https://api.github.com/repos/andrestc/machine/releases{/id}","deployments_url":"https://api.github.com/repos/andrestc/machine/deployments","created_at":"2016-07-20T20:51:45Z","updated_at":"2016-07-20T20:51:47Z","pushed_at":"2016-08-22T12:59:38Z","git_url":"git://github.com/andrestc/machine.git","ssh_url":"git@github.com:andrestc/machine.git","clone_url":"https://github.com/andrestc/machine.git","svn_url":"https://github.com/andrestc/machine","homepage":"https://docs.docker.com/machine/","size":15839,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"b0020f2dc45a4c29833296e4afbf100b1527aab7","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":27494663,"name":"machine","full_name":"docker/machine","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/machine","description":"Machine management for a container-centric world","fork":false,"url":"https://api.github.com/repos/docker/machine","forks_url":"https://api.github.com/repos/docker/machine/forks","keys_url":"https://api.github.com/repos/docker/machine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/machine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/machine/teams","hooks_url":"https://api.github.com/repos/docker/machine/hooks","issue_events_url":"https://api.github.com/repos/docker/machine/issues/events{/number}","events_url":"https://api.github.com/repos/docker/machine/events","assignees_url":"https://api.github.com/repos/docker/machine/assignees{/user}","branches_url":"https://api.github.com/repos/docker/machine/branches{/branch}","tags_url":"https://api.github.com/repos/docker/machine/tags","blobs_url":"https://api.github.com/repos/docker/machine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/machine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/machine/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/machine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/machine/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/machine/languages","stargazers_url":"https://api.github.com/repos/docker/machine/stargazers","contributors_url":"https://api.github.com/repos/docker/machine/contributors","subscribers_url":"https://api.github.com/repos/docker/machine/subscribers","subscription_url":"https://api.github.com/repos/docker/machine/subscription","commits_url":"https://api.github.com/repos/docker/machine/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/machine/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/machine/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/machine/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/machine/contents/{+path}","compare_url":"https://api.github.com/repos/docker/machine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/machine/merges","archive_url":"https://api.github.com/repos/docker/machine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/machine/downloads","issues_url":"https://api.github.com/repos/docker/machine/issues{/number}","pulls_url":"https://api.github.com/repos/docker/machine/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/machine/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/machine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/machine/labels{/name}","releases_url":"https://api.github.com/repos/docker/machine/releases{/id}","deployments_url":"https://api.github.com/repos/docker/machine/deployments","created_at":"2014-12-03T15:52:06Z","updated_at":"2016-08-22T14:20:12Z","pushed_at":"2016-08-22T12:59:39Z","git_url":"git://github.com/docker/machine.git","ssh_url":"git@github.com:docker/machine.git","clone_url":"https://github.com/docker/machine.git","svn_url":"https://github.com/docker/machine","homepage":"https://docs.docker.com/machine/","size":41970,"stargazers_count":3456,"watchers_count":3456,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":927,"mirror_url":null,"open_issues_count":528,"forks":927,"open_issues":528,"watchers":3456,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/machine/pulls/3687"},"html":{"href":"https://github.com/docker/machine/pull/3687"},"issue":{"href":"https://api.github.com/repos/docker/machine/issues/3687"},"comments":{"href":"https://api.github.com/repos/docker/machine/issues/3687/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/machine/pulls/3687/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/machine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/machine/pulls/3687/commits"},"statuses":{"href":"https://api.github.com/repos/docker/machine/statuses/dd6aba6f35878bfe06802646a3306b95d3015382"}}}}
{"actor":{"display_login":"ahmetalpbalkan"}}