{"action":"created","comment":{"url":"https://api.github.com/repos/os-autoinst/openQA/pulls/comments/88655417","pull_request_review_id":9223240,"id":88655417,"diff_hunk":"@@ -115,9 +114,9 @@ sub livelog {\n     # logfile and send them to the client, plus a utility function to\n     # close the connection if anything goes wrong.\n     my $id;\n-    my $close = sub {\n+    local *doclose = sub {","path":"lib/OpenQA/WebAPI/Controller/Running.pm","position":30,"original_position":30,"commit_id":"e91986e50a5adadc896785bec6fee00a4aa51ab4","original_commit_id":"e91986e50a5adadc896785bec6fee00a4aa51ab4","user":{"login":"kraih","id":30094,"avatar_url":"https://avatars.githubusercontent.com/u/30094?v=3","gravatar_id":"","url":"https://api.github.com/users/kraih","html_url":"https://github.com/kraih","followers_url":"https://api.github.com/users/kraih/followers","following_url":"https://api.github.com/users/kraih/following{/other_user}","gists_url":"https://api.github.com/users/kraih/gists{/gist_id}","starred_url":"https://api.github.com/users/kraih/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kraih/subscriptions","organizations_url":"https://api.github.com/users/kraih/orgs","repos_url":"https://api.github.com/users/kraih/repos","events_url":"https://api.github.com/users/kraih/events{/privacy}","received_events_url":"https://api.github.com/users/kraih/received_events","type":"User","site_admin":false},"body":"This looks a bit awkward to me, what makes the glob a better choice than a lexical scalar here?","created_at":"2016-11-18T13:21:22Z","updated_at":"2016-11-18T13:21:22Z","html_url":"https://github.com/os-autoinst/openQA/pull/1019#discussion_r88655417","pull_request_url":"https://api.github.com/repos/os-autoinst/openQA/pulls/1019","_links":{"self":{"href":"https://api.github.com/repos/os-autoinst/openQA/pulls/comments/88655417"},"html":{"href":"https://github.com/os-autoinst/openQA/pull/1019#discussion_r88655417"},"pull_request":{"href":"https://api.github.com/repos/os-autoinst/openQA/pulls/1019"}}},"pull_request":{"url":"https://api.github.com/repos/os-autoinst/openQA/pulls/1019","id":94337826,"html_url":"https://github.com/os-autoinst/openQA/pull/1019","diff_url":"https://github.com/os-autoinst/openQA/pull/1019.diff","patch_url":"https://github.com/os-autoinst/openQA/pull/1019.patch","issue_url":"https://api.github.com/repos/os-autoinst/openQA/issues/1019","number":1019,"state":"open","locked":false,"title":"WIP: Add serial terminal output to live view","user":{"login":"richiejp","id":988098,"avatar_url":"https://avatars.githubusercontent.com/u/988098?v=3","gravatar_id":"","url":"https://api.github.com/users/richiejp","html_url":"https://github.com/richiejp","followers_url":"https://api.github.com/users/richiejp/followers","following_url":"https://api.github.com/users/richiejp/following{/other_user}","gists_url":"https://api.github.com/users/richiejp/gists{/gist_id}","starred_url":"https://api.github.com/users/richiejp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richiejp/subscriptions","organizations_url":"https://api.github.com/users/richiejp/orgs","repos_url":"https://api.github.com/users/richiejp/repos","events_url":"https://api.github.com/users/richiejp/events{/privacy}","received_events_url":"https://api.github.com/users/richiejp/received_events","type":"User","site_admin":false},"body":"This is my initial attempt at adding serial console/terminal output to the live view in the same vein as Travis CI's output although much more simple.\r\n\r\nRequires: https://github.com/os-autoinst/os-autoinst/pull/644\r\n\r\nFeature request: https://progress.opensuse.org/issues/14690","created_at":"2016-11-18T10:33:17Z","updated_at":"2016-11-18T13:21:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"77a4265c3b7c92f2c8961d36a1c15be667e79eee","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/os-autoinst/openQA/pulls/1019/commits","review_comments_url":"https://api.github.com/repos/os-autoinst/openQA/pulls/1019/comments","review_comment_url":"https://api.github.com/repos/os-autoinst/openQA/pulls/comments{/number}","comments_url":"https://api.github.com/repos/os-autoinst/openQA/issues/1019/comments","statuses_url":"https://api.github.com/repos/os-autoinst/openQA/statuses/e91986e50a5adadc896785bec6fee00a4aa51ab4","head":{"label":"richiejp:liveterm","ref":"liveterm","sha":"e91986e50a5adadc896785bec6fee00a4aa51ab4","user":{"login":"richiejp","id":988098,"avatar_url":"https://avatars.githubusercontent.com/u/988098?v=3","gravatar_id":"","url":"https://api.github.com/users/richiejp","html_url":"https://github.com/richiejp","followers_url":"https://api.github.com/users/richiejp/followers","following_url":"https://api.github.com/users/richiejp/following{/other_user}","gists_url":"https://api.github.com/users/richiejp/gists{/gist_id}","starred_url":"https://api.github.com/users/richiejp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richiejp/subscriptions","organizations_url":"https://api.github.com/users/richiejp/orgs","repos_url":"https://api.github.com/users/richiejp/repos","events_url":"https://api.github.com/users/richiejp/events{/privacy}","received_events_url":"https://api.github.com/users/richiejp/received_events","type":"User","site_admin":false},"repo":{"id":63702633,"name":"openQA","full_name":"richiejp/openQA","owner":{"login":"richiejp","id":988098,"avatar_url":"https://avatars.githubusercontent.com/u/988098?v=3","gravatar_id":"","url":"https://api.github.com/users/richiejp","html_url":"https://github.com/richiejp","followers_url":"https://api.github.com/users/richiejp/followers","following_url":"https://api.github.com/users/richiejp/following{/other_user}","gists_url":"https://api.github.com/users/richiejp/gists{/gist_id}","starred_url":"https://api.github.com/users/richiejp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richiejp/subscriptions","organizations_url":"https://api.github.com/users/richiejp/orgs","repos_url":"https://api.github.com/users/richiejp/repos","events_url":"https://api.github.com/users/richiejp/events{/privacy}","received_events_url":"https://api.github.com/users/richiejp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/richiejp/openQA","description":"openQA web-frontend, scheduler and tools","fork":true,"url":"https://api.github.com/repos/richiejp/openQA","forks_url":"https://api.github.com/repos/richiejp/openQA/forks","keys_url":"https://api.github.com/repos/richiejp/openQA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/richiejp/openQA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/richiejp/openQA/teams","hooks_url":"https://api.github.com/repos/richiejp/openQA/hooks","issue_events_url":"https://api.github.com/repos/richiejp/openQA/issues/events{/number}","events_url":"https://api.github.com/repos/richiejp/openQA/events","assignees_url":"https://api.github.com/repos/richiejp/openQA/assignees{/user}","branches_url":"https://api.github.com/repos/richiejp/openQA/branches{/branch}","tags_url":"https://api.github.com/repos/richiejp/openQA/tags","blobs_url":"https://api.github.com/repos/richiejp/openQA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/richiejp/openQA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/richiejp/openQA/git/refs{/sha}","trees_url":"https://api.github.com/repos/richiejp/openQA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/richiejp/openQA/statuses/{sha}","languages_url":"https://api.github.com/repos/richiejp/openQA/languages","stargazers_url":"https://api.github.com/repos/richiejp/openQA/stargazers","contributors_url":"https://api.github.com/repos/richiejp/openQA/contributors","subscribers_url":"https://api.github.com/repos/richiejp/openQA/subscribers","subscription_url":"https://api.github.com/repos/richiejp/openQA/subscription","commits_url":"https://api.github.com/repos/richiejp/openQA/commits{/sha}","git_commits_url":"https://api.github.com/repos/richiejp/openQA/git/commits{/sha}","comments_url":"https://api.github.com/repos/richiejp/openQA/comments{/number}","issue_comment_url":"https://api.github.com/repos/richiejp/openQA/issues/comments{/number}","contents_url":"https://api.github.com/repos/richiejp/openQA/contents/{+path}","compare_url":"https://api.github.com/repos/richiejp/openQA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/richiejp/openQA/merges","archive_url":"https://api.github.com/repos/richiejp/openQA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/richiejp/openQA/downloads","issues_url":"https://api.github.com/repos/richiejp/openQA/issues{/number}","pulls_url":"https://api.github.com/repos/richiejp/openQA/pulls{/number}","milestones_url":"https://api.github.com/repos/richiejp/openQA/milestones{/number}","notifications_url":"https://api.github.com/repos/richiejp/openQA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/richiejp/openQA/labels{/name}","releases_url":"https://api.github.com/repos/richiejp/openQA/releases{/id}","deployments_url":"https://api.github.com/repos/richiejp/openQA/deployments","created_at":"2016-07-19T14:49:28Z","updated_at":"2016-07-19T14:49:33Z","pushed_at":"2016-11-18T10:32:00Z","git_url":"git://github.com/richiejp/openQA.git","ssh_url":"git@github.com:richiejp/openQA.git","clone_url":"https://github.com/richiejp/openQA.git","svn_url":"https://github.com/richiejp/openQA","homepage":"http://openqa.opensuse.org/","size":15921,"stargazers_count":0,"watchers_count":0,"language":"Perl","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"os-autoinst:master","ref":"master","sha":"43bd5742132ee1d451acb3330343c62717b86bf1","user":{"login":"os-autoinst","id":6918706,"avatar_url":"https://avatars.githubusercontent.com/u/6918706?v=3","gravatar_id":"","url":"https://api.github.com/users/os-autoinst","html_url":"https://github.com/os-autoinst","followers_url":"https://api.github.com/users/os-autoinst/followers","following_url":"https://api.github.com/users/os-autoinst/following{/other_user}","gists_url":"https://api.github.com/users/os-autoinst/gists{/gist_id}","starred_url":"https://api.github.com/users/os-autoinst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/os-autoinst/subscriptions","organizations_url":"https://api.github.com/users/os-autoinst/orgs","repos_url":"https://api.github.com/users/os-autoinst/repos","events_url":"https://api.github.com/users/os-autoinst/events{/privacy}","received_events_url":"https://api.github.com/users/os-autoinst/received_events","type":"Organization","site_admin":false},"repo":{"id":20883829,"name":"openQA","full_name":"os-autoinst/openQA","owner":{"login":"os-autoinst","id":6918706,"avatar_url":"https://avatars.githubusercontent.com/u/6918706?v=3","gravatar_id":"","url":"https://api.github.com/users/os-autoinst","html_url":"https://github.com/os-autoinst","followers_url":"https://api.github.com/users/os-autoinst/followers","following_url":"https://api.github.com/users/os-autoinst/following{/other_user}","gists_url":"https://api.github.com/users/os-autoinst/gists{/gist_id}","starred_url":"https://api.github.com/users/os-autoinst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/os-autoinst/subscriptions","organizations_url":"https://api.github.com/users/os-autoinst/orgs","repos_url":"https://api.github.com/users/os-autoinst/repos","events_url":"https://api.github.com/users/os-autoinst/events{/privacy}","received_events_url":"https://api.github.com/users/os-autoinst/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/os-autoinst/openQA","description":"openQA web-frontend, scheduler and tools","fork":false,"url":"https://api.github.com/repos/os-autoinst/openQA","forks_url":"https://api.github.com/repos/os-autoinst/openQA/forks","keys_url":"https://api.github.com/repos/os-autoinst/openQA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/os-autoinst/openQA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/os-autoinst/openQA/teams","hooks_url":"https://api.github.com/repos/os-autoinst/openQA/hooks","issue_events_url":"https://api.github.com/repos/os-autoinst/openQA/issues/events{/number}","events_url":"https://api.github.com/repos/os-autoinst/openQA/events","assignees_url":"https://api.github.com/repos/os-autoinst/openQA/assignees{/user}","branches_url":"https://api.github.com/repos/os-autoinst/openQA/branches{/branch}","tags_url":"https://api.github.com/repos/os-autoinst/openQA/tags","blobs_url":"https://api.github.com/repos/os-autoinst/openQA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/os-autoinst/openQA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/os-autoinst/openQA/git/refs{/sha}","trees_url":"https://api.github.com/repos/os-autoinst/openQA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/os-autoinst/openQA/statuses/{sha}","languages_url":"https://api.github.com/repos/os-autoinst/openQA/languages","stargazers_url":"https://api.github.com/repos/os-autoinst/openQA/stargazers","contributors_url":"https://api.github.com/repos/os-autoinst/openQA/contributors","subscribers_url":"https://api.github.com/repos/os-autoinst/openQA/subscribers","subscription_url":"https://api.github.com/repos/os-autoinst/openQA/subscription","commits_url":"https://api.github.com/repos/os-autoinst/openQA/commits{/sha}","git_commits_url":"https://api.github.com/repos/os-autoinst/openQA/git/commits{/sha}","comments_url":"https://api.github.com/repos/os-autoinst/openQA/comments{/number}","issue_comment_url":"https://api.github.com/repos/os-autoinst/openQA/issues/comments{/number}","contents_url":"https://api.github.com/repos/os-autoinst/openQA/contents/{+path}","compare_url":"https://api.github.com/repos/os-autoinst/openQA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/os-autoinst/openQA/merges","archive_url":"https://api.github.com/repos/os-autoinst/openQA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/os-autoinst/openQA/downloads","issues_url":"https://api.github.com/repos/os-autoinst/openQA/issues{/number}","pulls_url":"https://api.github.com/repos/os-autoinst/openQA/pulls{/number}","milestones_url":"https://api.github.com/repos/os-autoinst/openQA/milestones{/number}","notifications_url":"https://api.github.com/repos/os-autoinst/openQA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/os-autoinst/openQA/labels{/name}","releases_url":"https://api.github.com/repos/os-autoinst/openQA/releases{/id}","deployments_url":"https://api.github.com/repos/os-autoinst/openQA/deployments","created_at":"2014-06-16T12:23:22Z","updated_at":"2016-11-16T19:43:39Z","pushed_at":"2016-11-18T10:33:17Z","git_url":"git://github.com/os-autoinst/openQA.git","ssh_url":"git@github.com:os-autoinst/openQA.git","clone_url":"https://github.com/os-autoinst/openQA.git","svn_url":"https://github.com/os-autoinst/openQA","homepage":"http://openqa.opensuse.org/","size":17455,"stargazers_count":73,"watchers_count":73,"language":"Perl","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":57,"mirror_url":null,"open_issues_count":21,"forks":57,"open_issues":21,"watchers":73,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/os-autoinst/openQA/pulls/1019"},"html":{"href":"https://github.com/os-autoinst/openQA/pull/1019"},"issue":{"href":"https://api.github.com/repos/os-autoinst/openQA/issues/1019"},"comments":{"href":"https://api.github.com/repos/os-autoinst/openQA/issues/1019/comments"},"review_comments":{"href":"https://api.github.com/repos/os-autoinst/openQA/pulls/1019/comments"},"review_comment":{"href":"https://api.github.com/repos/os-autoinst/openQA/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/os-autoinst/openQA/pulls/1019/commits"},"statuses":{"href":"https://api.github.com/repos/os-autoinst/openQA/statuses/e91986e50a5adadc896785bec6fee00a4aa51ab4"}}}}
{"actor":{"display_login":"kraih"}}