{"action":"created","comment":{"url":"https://api.github.com/repos/meanjs/mean/pulls/comments/55146905","id":55146905,"diff_hunk":"@@ -155,9 +159,11 @@ angular.module('core').service('Menus', [\n \n       // Search for menu item to remove\n       for (var itemIndex in this.menus[menuId].items) {\n-        for (var subitemIndex in this.menus[menuId].items[itemIndex].items) {\n-          if (this.menus[menuId].items[itemIndex].items[subitemIndex].state === submenuItemState) {\n-            this.menus[menuId].items[itemIndex].items.splice(subitemIndex, 1);\n+        if (this.menus[menuId].items.hasOwnProperty(itemIndex)) {\n+          for (var subitemIndex in this.menus[menuId].items[itemIndex].items) {","path":"modules/core/client/services/menus.client.service.js","position":58,"original_position":58,"commit_id":"3368ff3ef46e4517bf887dd0cc12c287deb0966f","original_commit_id":"ce237327a1676d5026046a6e5da8e185d192f457","user":{"login":"ilanbiala","id":3695164,"avatar_url":"https://avatars.githubusercontent.com/u/3695164?v=3","gravatar_id":"","url":"https://api.github.com/users/ilanbiala","html_url":"https://github.com/ilanbiala","followers_url":"https://api.github.com/users/ilanbiala/followers","following_url":"https://api.github.com/users/ilanbiala/following{/other_user}","gists_url":"https://api.github.com/users/ilanbiala/gists{/gist_id}","starred_url":"https://api.github.com/users/ilanbiala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilanbiala/subscriptions","organizations_url":"https://api.github.com/users/ilanbiala/orgs","repos_url":"https://api.github.com/users/ilanbiala/repos","events_url":"https://api.github.com/users/ilanbiala/events{/privacy}","received_events_url":"https://api.github.com/users/ilanbiala/received_events","type":"User","site_admin":false},"body":"Yes, but it's missing in the inner one, no? I think we need to add 1 here is what I'm saying.","created_at":"2016-03-06T19:52:52Z","updated_at":"2016-03-06T19:52:52Z","html_url":"https://github.com/meanjs/mean/pull/1097#discussion_r55146905","pull_request_url":"https://api.github.com/repos/meanjs/mean/pulls/1097","_links":{"self":{"href":"https://api.github.com/repos/meanjs/mean/pulls/comments/55146905"},"html":{"href":"https://github.com/meanjs/mean/pull/1097#discussion_r55146905"},"pull_request":{"href":"https://api.github.com/repos/meanjs/mean/pulls/1097"}}},"pull_request":{"url":"https://api.github.com/repos/meanjs/mean/pulls/1097","id":53308946,"html_url":"https://github.com/meanjs/mean/pull/1097","diff_url":"https://github.com/meanjs/mean/pull/1097.diff","patch_url":"https://github.com/meanjs/mean/pull/1097.patch","issue_url":"https://api.github.com/repos/meanjs/mean/issues/1097","number":1097,"state":"open","locked":false,"title":"feat(config): Deprecate JSHint in favor of ESLint","user":{"login":"feimosi","id":5721520,"avatar_url":"https://avatars.githubusercontent.com/u/5721520?v=3","gravatar_id":"","url":"https://api.github.com/users/feimosi","html_url":"https://github.com/feimosi","followers_url":"https://api.github.com/users/feimosi/followers","following_url":"https://api.github.com/users/feimosi/following{/other_user}","gists_url":"https://api.github.com/users/feimosi/gists{/gist_id}","starred_url":"https://api.github.com/users/feimosi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feimosi/subscriptions","organizations_url":"https://api.github.com/users/feimosi/orgs","repos_url":"https://api.github.com/users/feimosi/repos","events_url":"https://api.github.com/users/feimosi/events{/privacy}","received_events_url":"https://api.github.com/users/feimosi/received_events","type":"User","site_admin":false},"body":"This is the basic ESLint setup extending well-known Airbnb code style and dedicated Angular rules.\r\nWhat also has changed:\r\n- removed eslint task from `client.views` path in gulp watch, possibly we can think of using some html linter\r\n- changed most of the globals by `environment` property, still I'd recommend not using / limit the use of global variables by dependency injection\r\n- the previous contributor's rules are left in place, but we need to review them to make the migration seamless. For now it's not consistent with JSHint, so someone with longer experiences in the project could help convert all the rules - docs are quite well-written\r\n- I haven't used Grunt much, so even though it was a basic change, someone could take a closer look :)\r\n\r\nReferences #1072 \r\n","created_at":"2015-12-10T20:03:18Z","updated_at":"2016-03-06T19:52:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8e2337202074627a7d2da317a53d0f5f5b3c620e","assignee":{"login":"ilanbiala","id":3695164,"avatar_url":"https://avatars.githubusercontent.com/u/3695164?v=3","gravatar_id":"","url":"https://api.github.com/users/ilanbiala","html_url":"https://github.com/ilanbiala","followers_url":"https://api.github.com/users/ilanbiala/followers","following_url":"https://api.github.com/users/ilanbiala/following{/other_user}","gists_url":"https://api.github.com/users/ilanbiala/gists{/gist_id}","starred_url":"https://api.github.com/users/ilanbiala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilanbiala/subscriptions","organizations_url":"https://api.github.com/users/ilanbiala/orgs","repos_url":"https://api.github.com/users/ilanbiala/repos","events_url":"https://api.github.com/users/ilanbiala/events{/privacy}","received_events_url":"https://api.github.com/users/ilanbiala/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/meanjs/mean/milestones/6","html_url":"https://github.com/meanjs/mean/milestones/0.5.0","labels_url":"https://api.github.com/repos/meanjs/mean/milestones/6/labels","id":1213421,"number":6,"title":"0.5.0","description":"","creator":{"login":"ilanbiala","id":3695164,"avatar_url":"https://avatars.githubusercontent.com/u/3695164?v=3","gravatar_id":"","url":"https://api.github.com/users/ilanbiala","html_url":"https://github.com/ilanbiala","followers_url":"https://api.github.com/users/ilanbiala/followers","following_url":"https://api.github.com/users/ilanbiala/following{/other_user}","gists_url":"https://api.github.com/users/ilanbiala/gists{/gist_id}","starred_url":"https://api.github.com/users/ilanbiala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilanbiala/subscriptions","organizations_url":"https://api.github.com/users/ilanbiala/orgs","repos_url":"https://api.github.com/users/ilanbiala/repos","events_url":"https://api.github.com/users/ilanbiala/events{/privacy}","received_events_url":"https://api.github.com/users/ilanbiala/received_events","type":"User","site_admin":false},"open_issues":39,"closed_issues":109,"state":"open","created_at":"2015-07-17T18:54:42Z","updated_at":"2016-03-06T18:47:29Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/meanjs/mean/pulls/1097/commits","review_comments_url":"https://api.github.com/repos/meanjs/mean/pulls/1097/comments","review_comment_url":"https://api.github.com/repos/meanjs/mean/pulls/comments{/number}","comments_url":"https://api.github.com/repos/meanjs/mean/issues/1097/comments","statuses_url":"https://api.github.com/repos/meanjs/mean/statuses/3368ff3ef46e4517bf887dd0cc12c287deb0966f","head":{"label":"feimosi:eslint-integration","ref":"eslint-integration","sha":"3368ff3ef46e4517bf887dd0cc12c287deb0966f","user":{"login":"feimosi","id":5721520,"avatar_url":"https://avatars.githubusercontent.com/u/5721520?v=3","gravatar_id":"","url":"https://api.github.com/users/feimosi","html_url":"https://github.com/feimosi","followers_url":"https://api.github.com/users/feimosi/followers","following_url":"https://api.github.com/users/feimosi/following{/other_user}","gists_url":"https://api.github.com/users/feimosi/gists{/gist_id}","starred_url":"https://api.github.com/users/feimosi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feimosi/subscriptions","organizations_url":"https://api.github.com/users/feimosi/orgs","repos_url":"https://api.github.com/users/feimosi/repos","events_url":"https://api.github.com/users/feimosi/events{/privacy}","received_events_url":"https://api.github.com/users/feimosi/received_events","type":"User","site_admin":false},"repo":{"id":47783183,"name":"mean","full_name":"feimosi/mean","owner":{"login":"feimosi","id":5721520,"avatar_url":"https://avatars.githubusercontent.com/u/5721520?v=3","gravatar_id":"","url":"https://api.github.com/users/feimosi","html_url":"https://github.com/feimosi","followers_url":"https://api.github.com/users/feimosi/followers","following_url":"https://api.github.com/users/feimosi/following{/other_user}","gists_url":"https://api.github.com/users/feimosi/gists{/gist_id}","starred_url":"https://api.github.com/users/feimosi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feimosi/subscriptions","organizations_url":"https://api.github.com/users/feimosi/orgs","repos_url":"https://api.github.com/users/feimosi/repos","events_url":"https://api.github.com/users/feimosi/events{/privacy}","received_events_url":"https://api.github.com/users/feimosi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/feimosi/mean","description":"MEAN.JS - Full-Stack JavaScript Using MongoDB, Express, AngularJS, and Node.js - ","fork":true,"url":"https://api.github.com/repos/feimosi/mean","forks_url":"https://api.github.com/repos/feimosi/mean/forks","keys_url":"https://api.github.com/repos/feimosi/mean/keys{/key_id}","collaborators_url":"https://api.github.com/repos/feimosi/mean/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/feimosi/mean/teams","hooks_url":"https://api.github.com/repos/feimosi/mean/hooks","issue_events_url":"https://api.github.com/repos/feimosi/mean/issues/events{/number}","events_url":"https://api.github.com/repos/feimosi/mean/events","assignees_url":"https://api.github.com/repos/feimosi/mean/assignees{/user}","branches_url":"https://api.github.com/repos/feimosi/mean/branches{/branch}","tags_url":"https://api.github.com/repos/feimosi/mean/tags","blobs_url":"https://api.github.com/repos/feimosi/mean/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/feimosi/mean/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/feimosi/mean/git/refs{/sha}","trees_url":"https://api.github.com/repos/feimosi/mean/git/trees{/sha}","statuses_url":"https://api.github.com/repos/feimosi/mean/statuses/{sha}","languages_url":"https://api.github.com/repos/feimosi/mean/languages","stargazers_url":"https://api.github.com/repos/feimosi/mean/stargazers","contributors_url":"https://api.github.com/repos/feimosi/mean/contributors","subscribers_url":"https://api.github.com/repos/feimosi/mean/subscribers","subscription_url":"https://api.github.com/repos/feimosi/mean/subscription","commits_url":"https://api.github.com/repos/feimosi/mean/commits{/sha}","git_commits_url":"https://api.github.com/repos/feimosi/mean/git/commits{/sha}","comments_url":"https://api.github.com/repos/feimosi/mean/comments{/number}","issue_comment_url":"https://api.github.com/repos/feimosi/mean/issues/comments{/number}","contents_url":"https://api.github.com/repos/feimosi/mean/contents/{+path}","compare_url":"https://api.github.com/repos/feimosi/mean/compare/{base}...{head}","merges_url":"https://api.github.com/repos/feimosi/mean/merges","archive_url":"https://api.github.com/repos/feimosi/mean/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/feimosi/mean/downloads","issues_url":"https://api.github.com/repos/feimosi/mean/issues{/number}","pulls_url":"https://api.github.com/repos/feimosi/mean/pulls{/number}","milestones_url":"https://api.github.com/repos/feimosi/mean/milestones{/number}","notifications_url":"https://api.github.com/repos/feimosi/mean/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/feimosi/mean/labels{/name}","releases_url":"https://api.github.com/repos/feimosi/mean/releases{/id}","deployments_url":"https://api.github.com/repos/feimosi/mean/deployments","created_at":"2015-12-10T19:35:24Z","updated_at":"2016-03-02T16:34:03Z","pushed_at":"2016-03-06T13:42:57Z","git_url":"git://github.com/feimosi/mean.git","ssh_url":"git@github.com:feimosi/mean.git","clone_url":"https://github.com/feimosi/mean.git","svn_url":"https://github.com/feimosi/mean","homepage":"http://meanjs.org","size":2605,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"meanjs:master","ref":"master","sha":"8f00edcd8270203fcc026bfc4e6796678ff1c4e2","user":{"login":"meanjs","id":6232122,"avatar_url":"https://avatars.githubusercontent.com/u/6232122?v=3","gravatar_id":"","url":"https://api.github.com/users/meanjs","html_url":"https://github.com/meanjs","followers_url":"https://api.github.com/users/meanjs/followers","following_url":"https://api.github.com/users/meanjs/following{/other_user}","gists_url":"https://api.github.com/users/meanjs/gists{/gist_id}","starred_url":"https://api.github.com/users/meanjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meanjs/subscriptions","organizations_url":"https://api.github.com/users/meanjs/orgs","repos_url":"https://api.github.com/users/meanjs/repos","events_url":"https://api.github.com/users/meanjs/events{/privacy}","received_events_url":"https://api.github.com/users/meanjs/received_events","type":"Organization","site_admin":false},"repo":{"id":15508537,"name":"mean","full_name":"meanjs/mean","owner":{"login":"meanjs","id":6232122,"avatar_url":"https://avatars.githubusercontent.com/u/6232122?v=3","gravatar_id":"","url":"https://api.github.com/users/meanjs","html_url":"https://github.com/meanjs","followers_url":"https://api.github.com/users/meanjs/followers","following_url":"https://api.github.com/users/meanjs/following{/other_user}","gists_url":"https://api.github.com/users/meanjs/gists{/gist_id}","starred_url":"https://api.github.com/users/meanjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meanjs/subscriptions","organizations_url":"https://api.github.com/users/meanjs/orgs","repos_url":"https://api.github.com/users/meanjs/repos","events_url":"https://api.github.com/users/meanjs/events{/privacy}","received_events_url":"https://api.github.com/users/meanjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/meanjs/mean","description":"MEAN.JS - Full-Stack JavaScript Using MongoDB, Express, AngularJS, and Node.js - ","fork":false,"url":"https://api.github.com/repos/meanjs/mean","forks_url":"https://api.github.com/repos/meanjs/mean/forks","keys_url":"https://api.github.com/repos/meanjs/mean/keys{/key_id}","collaborators_url":"https://api.github.com/repos/meanjs/mean/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/meanjs/mean/teams","hooks_url":"https://api.github.com/repos/meanjs/mean/hooks","issue_events_url":"https://api.github.com/repos/meanjs/mean/issues/events{/number}","events_url":"https://api.github.com/repos/meanjs/mean/events","assignees_url":"https://api.github.com/repos/meanjs/mean/assignees{/user}","branches_url":"https://api.github.com/repos/meanjs/mean/branches{/branch}","tags_url":"https://api.github.com/repos/meanjs/mean/tags","blobs_url":"https://api.github.com/repos/meanjs/mean/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/meanjs/mean/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/meanjs/mean/git/refs{/sha}","trees_url":"https://api.github.com/repos/meanjs/mean/git/trees{/sha}","statuses_url":"https://api.github.com/repos/meanjs/mean/statuses/{sha}","languages_url":"https://api.github.com/repos/meanjs/mean/languages","stargazers_url":"https://api.github.com/repos/meanjs/mean/stargazers","contributors_url":"https://api.github.com/repos/meanjs/mean/contributors","subscribers_url":"https://api.github.com/repos/meanjs/mean/subscribers","subscription_url":"https://api.github.com/repos/meanjs/mean/subscription","commits_url":"https://api.github.com/repos/meanjs/mean/commits{/sha}","git_commits_url":"https://api.github.com/repos/meanjs/mean/git/commits{/sha}","comments_url":"https://api.github.com/repos/meanjs/mean/comments{/number}","issue_comment_url":"https://api.github.com/repos/meanjs/mean/issues/comments{/number}","contents_url":"https://api.github.com/repos/meanjs/mean/contents/{+path}","compare_url":"https://api.github.com/repos/meanjs/mean/compare/{base}...{head}","merges_url":"https://api.github.com/repos/meanjs/mean/merges","archive_url":"https://api.github.com/repos/meanjs/mean/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/meanjs/mean/downloads","issues_url":"https://api.github.com/repos/meanjs/mean/issues{/number}","pulls_url":"https://api.github.com/repos/meanjs/mean/pulls{/number}","milestones_url":"https://api.github.com/repos/meanjs/mean/milestones{/number}","notifications_url":"https://api.github.com/repos/meanjs/mean/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/meanjs/mean/labels{/name}","releases_url":"https://api.github.com/repos/meanjs/mean/releases{/id}","deployments_url":"https://api.github.com/repos/meanjs/mean/deployments","created_at":"2013-12-29T13:01:15Z","updated_at":"2016-03-06T18:30:22Z","pushed_at":"2016-03-06T19:37:25Z","git_url":"git://github.com/meanjs/mean.git","ssh_url":"git@github.com:meanjs/mean.git","clone_url":"https://github.com/meanjs/mean.git","svn_url":"https://github.com/meanjs/mean","homepage":"http://meanjs.org","size":5240,"stargazers_count":3156,"watchers_count":3156,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1207,"mirror_url":null,"open_issues_count":75,"forks":1207,"open_issues":75,"watchers":3156,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/meanjs/mean/pulls/1097"},"html":{"href":"https://github.com/meanjs/mean/pull/1097"},"issue":{"href":"https://api.github.com/repos/meanjs/mean/issues/1097"},"comments":{"href":"https://api.github.com/repos/meanjs/mean/issues/1097/comments"},"review_comments":{"href":"https://api.github.com/repos/meanjs/mean/pulls/1097/comments"},"review_comment":{"href":"https://api.github.com/repos/meanjs/mean/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/meanjs/mean/pulls/1097/commits"},"statuses":{"href":"https://api.github.com/repos/meanjs/mean/statuses/3368ff3ef46e4517bf887dd0cc12c287deb0966f"}}}}