{"action":"closed","number":3199,"pull_request":{"url":"https://api.github.com/repos/theforeman/foreman/pulls/3199","id":59656342,"html_url":"https://github.com/theforeman/foreman/pull/3199","diff_url":"https://github.com/theforeman/foreman/pull/3199.diff","patch_url":"https://github.com/theforeman/foreman/pull/3199.patch","issue_url":"https://api.github.com/repos/theforeman/foreman/issues/3199","number":3199,"state":"closed","locked":false,"title":"Fixes #13293 - Make tests use a shared AR db connection","user":{"login":"dLobatog","id":598891,"avatar_url":"https://avatars.githubusercontent.com/u/598891?v=3","gravatar_id":"","url":"https://api.github.com/users/dLobatog","html_url":"https://github.com/dLobatog","followers_url":"https://api.github.com/users/dLobatog/followers","following_url":"https://api.github.com/users/dLobatog/following{/other_user}","gists_url":"https://api.github.com/users/dLobatog/gists{/gist_id}","starred_url":"https://api.github.com/users/dLobatog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dLobatog/subscriptions","organizations_url":"https://api.github.com/users/dLobatog/orgs","repos_url":"https://api.github.com/users/dLobatog/repos","events_url":"https://api.github.com/users/dLobatog/events{/privacy}","received_events_url":"https://api.github.com/users/dLobatog/received_events","type":"User","site_admin":false},"body":"Initially this PR contained capybara-screenshot so I could investigate a bit more what was the cause for our spotty integration tests. I found it easier to get rid of truncating the db using DatabaseCleaner and using transactional fixtures again. Integration tests run much faster, but more importantly they're easier to debug. Concurrency problems are more unlikely than before because all threads are sharing the same connection to the database.","created_at":"2016-02-17T15:05:24Z","updated_at":"2016-03-07T10:03:01Z","closed_at":"2016-03-07T10:03:01Z","merged_at":null,"merge_commit_sha":"7867da4ee8b86877d544cf047ec153febec8eec0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/theforeman/foreman/pulls/3199/commits","review_comments_url":"https://api.github.com/repos/theforeman/foreman/pulls/3199/comments","review_comment_url":"https://api.github.com/repos/theforeman/foreman/pulls/comments{/number}","comments_url":"https://api.github.com/repos/theforeman/foreman/issues/3199/comments","statuses_url":"https://api.github.com/repos/theforeman/foreman/statuses/d80b72b05ee8e29988ff45820c5aa9dc5adce3f0","head":{"label":"dLobatog:13111","ref":"13111","sha":"d80b72b05ee8e29988ff45820c5aa9dc5adce3f0","user":{"login":"dLobatog","id":598891,"avatar_url":"https://avatars.githubusercontent.com/u/598891?v=3","gravatar_id":"","url":"https://api.github.com/users/dLobatog","html_url":"https://github.com/dLobatog","followers_url":"https://api.github.com/users/dLobatog/followers","following_url":"https://api.github.com/users/dLobatog/following{/other_user}","gists_url":"https://api.github.com/users/dLobatog/gists{/gist_id}","starred_url":"https://api.github.com/users/dLobatog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dLobatog/subscriptions","organizations_url":"https://api.github.com/users/dLobatog/orgs","repos_url":"https://api.github.com/users/dLobatog/repos","events_url":"https://api.github.com/users/dLobatog/events{/privacy}","received_events_url":"https://api.github.com/users/dLobatog/received_events","type":"User","site_admin":false},"repo":{"id":5842097,"name":"foreman","full_name":"dLobatog/foreman","owner":{"login":"dLobatog","id":598891,"avatar_url":"https://avatars.githubusercontent.com/u/598891?v=3","gravatar_id":"","url":"https://api.github.com/users/dLobatog","html_url":"https://github.com/dLobatog","followers_url":"https://api.github.com/users/dLobatog/followers","following_url":"https://api.github.com/users/dLobatog/following{/other_user}","gists_url":"https://api.github.com/users/dLobatog/gists{/gist_id}","starred_url":"https://api.github.com/users/dLobatog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dLobatog/subscriptions","organizations_url":"https://api.github.com/users/dLobatog/orgs","repos_url":"https://api.github.com/users/dLobatog/repos","events_url":"https://api.github.com/users/dLobatog/events{/privacy}","received_events_url":"https://api.github.com/users/dLobatog/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dLobatog/foreman","description":"an application that automates the lifecycle of servers ","fork":true,"url":"https://api.github.com/repos/dLobatog/foreman","forks_url":"https://api.github.com/repos/dLobatog/foreman/forks","keys_url":"https://api.github.com/repos/dLobatog/foreman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dLobatog/foreman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dLobatog/foreman/teams","hooks_url":"https://api.github.com/repos/dLobatog/foreman/hooks","issue_events_url":"https://api.github.com/repos/dLobatog/foreman/issues/events{/number}","events_url":"https://api.github.com/repos/dLobatog/foreman/events","assignees_url":"https://api.github.com/repos/dLobatog/foreman/assignees{/user}","branches_url":"https://api.github.com/repos/dLobatog/foreman/branches{/branch}","tags_url":"https://api.github.com/repos/dLobatog/foreman/tags","blobs_url":"https://api.github.com/repos/dLobatog/foreman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dLobatog/foreman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dLobatog/foreman/git/refs{/sha}","trees_url":"https://api.github.com/repos/dLobatog/foreman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dLobatog/foreman/statuses/{sha}","languages_url":"https://api.github.com/repos/dLobatog/foreman/languages","stargazers_url":"https://api.github.com/repos/dLobatog/foreman/stargazers","contributors_url":"https://api.github.com/repos/dLobatog/foreman/contributors","subscribers_url":"https://api.github.com/repos/dLobatog/foreman/subscribers","subscription_url":"https://api.github.com/repos/dLobatog/foreman/subscription","commits_url":"https://api.github.com/repos/dLobatog/foreman/commits{/sha}","git_commits_url":"https://api.github.com/repos/dLobatog/foreman/git/commits{/sha}","comments_url":"https://api.github.com/repos/dLobatog/foreman/comments{/number}","issue_comment_url":"https://api.github.com/repos/dLobatog/foreman/issues/comments{/number}","contents_url":"https://api.github.com/repos/dLobatog/foreman/contents/{+path}","compare_url":"https://api.github.com/repos/dLobatog/foreman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dLobatog/foreman/merges","archive_url":"https://api.github.com/repos/dLobatog/foreman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dLobatog/foreman/downloads","issues_url":"https://api.github.com/repos/dLobatog/foreman/issues{/number}","pulls_url":"https://api.github.com/repos/dLobatog/foreman/pulls{/number}","milestones_url":"https://api.github.com/repos/dLobatog/foreman/milestones{/number}","notifications_url":"https://api.github.com/repos/dLobatog/foreman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dLobatog/foreman/labels{/name}","releases_url":"https://api.github.com/repos/dLobatog/foreman/releases{/id}","deployments_url":"https://api.github.com/repos/dLobatog/foreman/deployments","created_at":"2012-09-17T14:23:49Z","updated_at":"2015-05-06T16:17:15Z","pushed_at":"2016-03-03T11:14:06Z","git_url":"git://github.com/dLobatog/foreman.git","ssh_url":"git@github.com:dLobatog/foreman.git","clone_url":"https://github.com/dLobatog/foreman.git","svn_url":"https://github.com/dLobatog/foreman","homepage":"http://theforeman.org","size":38033,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"develop"}},"base":{"label":"theforeman:develop","ref":"develop","sha":"6fdd5bf52e923c33bc82ecc0d0c8be3d71eb71e0","user":{"login":"theforeman","id":1439844,"avatar_url":"https://avatars.githubusercontent.com/u/1439844?v=3","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"repo":{"id":258750,"name":"foreman","full_name":"theforeman/foreman","owner":{"login":"theforeman","id":1439844,"avatar_url":"https://avatars.githubusercontent.com/u/1439844?v=3","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/theforeman/foreman","description":"an application that automates the lifecycle of servers ","fork":false,"url":"https://api.github.com/repos/theforeman/foreman","forks_url":"https://api.github.com/repos/theforeman/foreman/forks","keys_url":"https://api.github.com/repos/theforeman/foreman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theforeman/foreman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theforeman/foreman/teams","hooks_url":"https://api.github.com/repos/theforeman/foreman/hooks","issue_events_url":"https://api.github.com/repos/theforeman/foreman/issues/events{/number}","events_url":"https://api.github.com/repos/theforeman/foreman/events","assignees_url":"https://api.github.com/repos/theforeman/foreman/assignees{/user}","branches_url":"https://api.github.com/repos/theforeman/foreman/branches{/branch}","tags_url":"https://api.github.com/repos/theforeman/foreman/tags","blobs_url":"https://api.github.com/repos/theforeman/foreman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theforeman/foreman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theforeman/foreman/git/refs{/sha}","trees_url":"https://api.github.com/repos/theforeman/foreman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theforeman/foreman/statuses/{sha}","languages_url":"https://api.github.com/repos/theforeman/foreman/languages","stargazers_url":"https://api.github.com/repos/theforeman/foreman/stargazers","contributors_url":"https://api.github.com/repos/theforeman/foreman/contributors","subscribers_url":"https://api.github.com/repos/theforeman/foreman/subscribers","subscription_url":"https://api.github.com/repos/theforeman/foreman/subscription","commits_url":"https://api.github.com/repos/theforeman/foreman/commits{/sha}","git_commits_url":"https://api.github.com/repos/theforeman/foreman/git/commits{/sha}","comments_url":"https://api.github.com/repos/theforeman/foreman/comments{/number}","issue_comment_url":"https://api.github.com/repos/theforeman/foreman/issues/comments{/number}","contents_url":"https://api.github.com/repos/theforeman/foreman/contents/{+path}","compare_url":"https://api.github.com/repos/theforeman/foreman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theforeman/foreman/merges","archive_url":"https://api.github.com/repos/theforeman/foreman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theforeman/foreman/downloads","issues_url":"https://api.github.com/repos/theforeman/foreman/issues{/number}","pulls_url":"https://api.github.com/repos/theforeman/foreman/pulls{/number}","milestones_url":"https://api.github.com/repos/theforeman/foreman/milestones{/number}","notifications_url":"https://api.github.com/repos/theforeman/foreman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theforeman/foreman/labels{/name}","releases_url":"https://api.github.com/repos/theforeman/foreman/releases{/id}","deployments_url":"https://api.github.com/repos/theforeman/foreman/deployments","created_at":"2009-07-23T15:07:00Z","updated_at":"2016-03-06T00:45:34Z","pushed_at":"2016-03-07T09:32:50Z","git_url":"git://github.com/theforeman/foreman.git","ssh_url":"git@github.com:theforeman/foreman.git","clone_url":"https://github.com/theforeman/foreman.git","svn_url":"https://github.com/theforeman/foreman","homepage":"http://theforeman.org","size":58198,"stargazers_count":956,"watchers_count":956,"language":"Ruby","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":488,"mirror_url":null,"open_issues_count":99,"forks":488,"open_issues":99,"watchers":956,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/3199"},"html":{"href":"https://github.com/theforeman/foreman/pull/3199"},"issue":{"href":"https://api.github.com/repos/theforeman/foreman/issues/3199"},"comments":{"href":"https://api.github.com/repos/theforeman/foreman/issues/3199/comments"},"review_comments":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/3199/comments"},"review_comment":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/3199/commits"},"statuses":{"href":"https://api.github.com/repos/theforeman/foreman/statuses/d80b72b05ee8e29988ff45820c5aa9dc5adce3f0"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":13,"review_comments":10,"commits":1,"additions":26,"deletions":25,"changed_files":5}}