{"push_id":1229338799,"size":18,"distinct_size":18,"ref":"refs/heads/master","head":"ae616308f83458cfce286303ea34022810c7ec72","before":"63ba5e620bfa172e864bc03cc1891964e98ad918","commits":[{"sha":"77ab097b7322ff0c81d91acc7ab6dbe782e5b977","author":{"name":"Guy Harris","email":"797b6f4d9d75383359da362ebbb69879a87cae81@alum.mit.edu"},"message":"Re-impose some of Winsock's limitations on sock_recv().\n\nIn Winsock, recv() takes an int as the size argument and returns an int\nas a return value, so it can't read more than INT_MAX bytes.  Have it\ntake a size_t as an argument (so you don't have to cast away warnings\nabout narrowing sizeof values), return an error if it's bigger than\nINT_MAX (which it can be even on ILP32 platforms, as size_t is\nunsigned), and have the count of remaining bytes be an int.","distinct":true,"url":"https://api.github.com/repos/fxlb/libpcap/commits/77ab097b7322ff0c81d91acc7ab6dbe782e5b977"},{"sha":"57d5e0a94a67d80d662fb6f65d31179dd4e58732","author":{"name":"Guy Harris","email":"797b6f4d9d75383359da362ebbb69879a87cae81@alum.mit.edu"},"message":"Properly check for sock_recv() errors.\n\nAlways assign its value to an int (that being its return value) and\ncheck it against -1.  Use a separate variable to keep track of the total\nnumber of bytes read when reading the message.\n\nClean up indentation, and remove extra blank lines, while we're at it.\n\npcap-int.h includes pcap.h, so there's no need to include both.\n\nGet rid of some unnecessary braces in case clauses.","distinct":true,"url":"https://api.github.com/repos/fxlb/libpcap/commits/57d5e0a94a67d80d662fb6f65d31179dd4e58732"},{"sha":"702525cddb6fe5107592b3413db9e69b7a0de9ec","author":{"name":"Guy Harris","email":"797b6f4d9d75383359da362ebbb69879a87cae81@alum.mit.edu"},"message":"Clean up white space.","distinct":true,"url":"https://api.github.com/repos/fxlb/libpcap/commits/702525cddb6fe5107592b3413db9e69b7a0de9ec"},{"sha":"42bba9e4c0707bd68a93d98f952fa67b6849bc23","author":{"name":"Guy Harris","email":"797b6f4d9d75383359da362ebbb69879a87cae81@alum.mit.edu"},"message":"No need to cast the bufsize member of a pcap_t to unsigned.\n\nIt's now a u_int, so it's already unsigned.","distinct":true,"url":"https://api.github.com/repos/fxlb/libpcap/commits/42bba9e4c0707bd68a93d98f952fa67b6849bc23"},{"sha":"ca682fd83c9ea1dc0e16e5c938faeb253dccbaae","author":{"name":"Guy Harris","email":"797b6f4d9d75383359da362ebbb69879a87cae81@alum.mit.edu"},"message":"No sockutils.h API uses ssize_t, so define it in sockutils.c.","distinct":true,"url":"https://api.github.com/repos/fxlb/libpcap/commits/ca682fd83c9ea1dc0e16e5c938faeb253dccbaae"},{"sha":"6da501fb98c80c40cf5b63e632c7db92e9de56bc","author":{"name":"Guy Harris","email":"797b6f4d9d75383359da362ebbb69879a87cae81@alum.mit.edu"},"message":"Rename pcap-remote.[ch] to pcap-rpcap.[ch].\n\nThey're not for remote capture in general, they're just for remote\ncapture using the rpcap protocol.","distinct":true,"url":"https://api.github.com/repos/fxlb/libpcap/commits/6da501fb98c80c40cf5b63e632c7db92e9de56bc"},{"sha":"d0d485b87b1eec8f8ff24d79c7aacee07a551d96","author":{"name":"Guy Harris","email":"797b6f4d9d75383359da362ebbb69879a87cae81@alum.mit.edu"},"message":"Give sock_cleanup() a definition to match the prototype.","distinct":true,"url":"https://api.github.com/repos/fxlb/libpcap/commits/d0d485b87b1eec8f8ff24d79c7aacee07a551d96"},{"sha":"ba39a70e56fa7109a8c06904f1dd37f3f4083718","author":{"name":"Guy Harris","email":"797b6f4d9d75383359da362ebbb69879a87cae81@alum.mit.edu"},"message":"Check against INVALID_SOCKET when checking for sock_open() errors.\n\nA SOCKET is unsigned in Windows, and INVALID_SOCKET is defined so that\nyou can compare a SOCKET against it without complaints.","distinct":true,"url":"https://api.github.com/repos/fxlb/libpcap/commits/ba39a70e56fa7109a8c06904f1dd37f3f4083718"},{"sha":"c2ae3aef82e16073cf38f55bcb22a6c54fad4dd5","author":{"name":"Guy Harris","email":"797b6f4d9d75383359da362ebbb69879a87cae81@alum.mit.edu"},"message":"Cast away a warning.\n\nAlso, make some style consistency changes.","distinct":true,"url":"https://api.github.com/repos/fxlb/libpcap/commits/c2ae3aef82e16073cf38f55bcb22a6c54fad4dd5"},{"sha":"c8aedc6ce50cbc5a05208926854c2aae7ed13194","author":{"name":"Guy Harris","email":"797b6f4d9d75383359da362ebbb69879a87cae81@alum.mit.edu"},"message":"Assorted cleanups.\n\nAs done in pcap-rpcap.c, assign the result of sock_recv() to a variable,\nand check that variable against -1, rather than *adding* it to a\nvariable and checking the *sum* against -1.\n\nClean up the finalldevs code to avoid a \"used but not set\" error.\n\nRemove extra blank lines.","distinct":true,"url":"https://api.github.com/repos/fxlb/libpcap/commits/c8aedc6ce50cbc5a05208926854c2aae7ed13194"},{"sha":"7967e21f43dccb23cb8532476560249dc6f76eae","author":{"name":"Guy Harris","email":"797b6f4d9d75383359da362ebbb69879a87cae81@alum.mit.edu"},"message":"Add a variable that should have been in the previous commit.","distinct":true,"url":"https://api.github.com/repos/fxlb/libpcap/commits/7967e21f43dccb23cb8532476560249dc6f76eae"},{"sha":"64cac4dee60d29acc10e2bf40cad8fa1d31e55d0","author":{"name":"Guy Harris","email":"797b6f4d9d75383359da362ebbb69879a87cae81@alum.mit.edu"},"message":"A pointer to an array is never null, so don't check if it is.","distinct":true,"url":"https://api.github.com/repos/fxlb/libpcap/commits/64cac4dee60d29acc10e2bf40cad8fa1d31e55d0"},{"sha":"4e409107fef941a49df3f3222652412fd0877bd4","author":{"name":"Guy Harris","email":"797b6f4d9d75383359da362ebbb69879a87cae81@alum.mit.edu"},"message":"White space and line length cleanups.","distinct":true,"url":"https://api.github.com/repos/fxlb/libpcap/commits/4e409107fef941a49df3f3222652412fd0877bd4"},{"sha":"55340b77dfc11f469ad10b8e7f90501bef314648","author":{"name":"Guy Harris","email":"797b6f4d9d75383359da362ebbb69879a87cae81@alum.mit.edu"},"message":"Remove another extra blank line.","distinct":true,"url":"https://api.github.com/repos/fxlb/libpcap/commits/55340b77dfc11f469ad10b8e7f90501bef314648"},{"sha":"460ed6a30e7708b0e10d1501cdb5d6165adf1f4d","author":{"name":"Guy Harris","email":"797b6f4d9d75383359da362ebbb69879a87cae81@alum.mit.edu"},"message":"Use strdup() to make mallocated copies of strings.","distinct":true,"url":"https://api.github.com/repos/fxlb/libpcap/commits/460ed6a30e7708b0e10d1501cdb5d6165adf1f4d"},{"sha":"30e23f3cf3df60a681bc14dd4fb7fba642e29039","author":{"name":"Guy Harris","email":"797b6f4d9d75383359da362ebbb69879a87cae81@alum.mit.edu"},"message":"Give a better discussion of possible errors.\n\nGive each warning and error code its own paragraph.\n\nNote that, in the future, additional warning and error codes may be\nadded, so programs should treat *all* positive return codes as warnings\nand *all* negative return codes as errors, and, if the warning or error\ncode isn't one the program specifically checks for, and isn't\nPCAP_WARNING or PCAP_ERROR, it should use pcap_statustostr() to report\nthe warning or error.\n\n(Yes, we've added additional return codes in the past, subsequent to\nrelease 1.0, so it's not as if we're changing anything with this\nannouncement.)","distinct":true,"url":"https://api.github.com/repos/fxlb/libpcap/commits/30e23f3cf3df60a681bc14dd4fb7fba642e29039"},{"sha":"c20155c1872b6d07ee01f07899dd75bcd6e65ec1","author":{"name":"Guy Harris","email":"797b6f4d9d75383359da362ebbb69879a87cae81@alum.mit.edu"},"message":"Fix a typo.","distinct":true,"url":"https://api.github.com/repos/fxlb/libpcap/commits/c20155c1872b6d07ee01f07899dd75bcd6e65ec1"},{"sha":"ae616308f83458cfce286303ea34022810c7ec72","author":{"name":"Guy Harris","email":"797b6f4d9d75383359da362ebbb69879a87cae81@alum.mit.edu"},"message":"Give a better discussion of possible errors.\n\nGive each warning and error code its own paragraph.\n\nNote that, in the future, additional warning and error codes may be\nadded, so programs should treat *all* negative return codes as errors,\nand, if the warning or error code isn't one the program specifically\nchecks for, and isn't PCAP_ERROR, it should use pcap_statustostr() to\nreport the error.\n\n(Yes, we've added additional return codes in the past, subsequent to\nrelease 1.0, so it's not as if we're changing anything with this\nannouncement.)","distinct":true,"url":"https://api.github.com/repos/fxlb/libpcap/commits/ae616308f83458cfce286303ea34022810c7ec72"}]}
{"actor":{"display_login":"fxlb"}}