{"action":"opened","number":6,"pull_request":{"url":"https://api.github.com/repos/BlackCoyote/dScripts/pulls/6","id":91481251,"html_url":"https://github.com/BlackCoyote/dScripts/pull/6","diff_url":"https://github.com/BlackCoyote/dScripts/pull/6.diff","patch_url":"https://github.com/BlackCoyote/dScripts/pull/6.patch","issue_url":"https://api.github.com/repos/BlackCoyote/dScripts/issues/6","number":6,"state":"open","locked":false,"title":"New features, and a couple of small cleanups","user":{"login":"Tendrid","id":279527,"avatar_url":"https://avatars.githubusercontent.com/u/279527?v=3","gravatar_id":"","url":"https://api.github.com/users/Tendrid","html_url":"https://github.com/Tendrid","followers_url":"https://api.github.com/users/Tendrid/followers","following_url":"https://api.github.com/users/Tendrid/following{/other_user}","gists_url":"https://api.github.com/users/Tendrid/gists{/gist_id}","starred_url":"https://api.github.com/users/Tendrid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tendrid/subscriptions","organizations_url":"https://api.github.com/users/Tendrid/orgs","repos_url":"https://api.github.com/users/Tendrid/repos","events_url":"https://api.github.com/users/Tendrid/events{/privacy}","received_events_url":"https://api.github.com/users/Tendrid/received_events","type":"User","site_admin":false},"body":"This PR is less of a request to merge this code, and more of a start of dialog on contributing to dTowns.  In the two commits, i've done a couple of things that i should probably explain.\r\n\r\n1:\r\nI noticed a lot of referencing of the config file, followed with an ||some_default.  I assumed this was done, because the config is admin editable, and its possible that they could remove a key, and you want to return a default.  The defaults were defined in many places, so i took a wack at moving all of the defaults up to the top, in a more protected space (a server flag), which populates the default config file.  I also added a getter, so that you dont have to reference the config file directly.  The getter tries to get the value from the config, but returns the default (defined in the server flag) if its not there.  Its the exact same workflow, however the default values only exist in one place.\r\n\r\n2:\r\nI moved all of the default rules into the server flag constants.  I dont think i went through and changed the default returns yet, but its something i'd like to do.  I also want to check to make sure the rule being set/get is a valid rule defined in the rules list (in the server flags)\r\n\r\n3:\r\ni added the ability to set a towns welcome message, which is displayed when you enter a new town.\r\n\r\n4:\r\ni added the idea of the \"Wilderness\", an idea that is stable, but the features (imho) are incomplete.  This allows you to set rules for the land that _isnt_ in a town.  (i have some more rules i'd like to add like fire_spread, and creeper damage.  both of which i've already written in a stand-alone plugin, i can easily port it over)\r\n\r\n5:\r\ni changed the welcome message to display the name of the town, and the welcome message.  It also works with the Wilderness.  This mimics the welcome message functionality of Factions, and is better suited for a Wilderness, or towns that are right next to each other.  (two towns next to each other would present a Leaving message at the same town as a Welcome message)\r\n\r\nNote:\r\ni added some new lines to the language file (command-welcome-info, must-specify-townwelcome, town-welcome-changed), but the Spanish and French lines are in English, and will need translation. \r\n\r\nI really want to expand on the Wilderness idea, as well as some potential town ideas.  I think it would be cool if you could set your towns color.  A color that would be used as the title color when you enter your town, as well as the color of your towns name in chat.\r\n\r\nI have several other ideas, but i kinda wanted to start small here, just so we could figure out the best way for me to contrib.  If you dont want my changes, you're not going to hurt my feelings, so feel free to reject them :).  I'll just keep my own fork, and use the plugin on my server.\r\n\r\nEither way, let me know what you think!  (FYI:  I'm just getting back in to Denizen, so feel free to tell me if i'm doing something stupid)","created_at":"2016-10-29T06:54:33Z","updated_at":"2016-10-29T06:54:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/BlackCoyote/dScripts/pulls/6/commits","review_comments_url":"https://api.github.com/repos/BlackCoyote/dScripts/pulls/6/comments","review_comment_url":"https://api.github.com/repos/BlackCoyote/dScripts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/BlackCoyote/dScripts/issues/6/comments","statuses_url":"https://api.github.com/repos/BlackCoyote/dScripts/statuses/130d6696f1df9d88b69740b9492a836755fd888d","head":{"label":"Tendrid:master","ref":"master","sha":"130d6696f1df9d88b69740b9492a836755fd888d","user":{"login":"Tendrid","id":279527,"avatar_url":"https://avatars.githubusercontent.com/u/279527?v=3","gravatar_id":"","url":"https://api.github.com/users/Tendrid","html_url":"https://github.com/Tendrid","followers_url":"https://api.github.com/users/Tendrid/followers","following_url":"https://api.github.com/users/Tendrid/following{/other_user}","gists_url":"https://api.github.com/users/Tendrid/gists{/gist_id}","starred_url":"https://api.github.com/users/Tendrid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tendrid/subscriptions","organizations_url":"https://api.github.com/users/Tendrid/orgs","repos_url":"https://api.github.com/users/Tendrid/repos","events_url":"https://api.github.com/users/Tendrid/events{/privacy}","received_events_url":"https://api.github.com/users/Tendrid/received_events","type":"User","site_admin":false},"repo":{"id":72261494,"name":"dScripts","full_name":"Tendrid/dScripts","owner":{"login":"Tendrid","id":279527,"avatar_url":"https://avatars.githubusercontent.com/u/279527?v=3","gravatar_id":"","url":"https://api.github.com/users/Tendrid","html_url":"https://github.com/Tendrid","followers_url":"https://api.github.com/users/Tendrid/followers","following_url":"https://api.github.com/users/Tendrid/following{/other_user}","gists_url":"https://api.github.com/users/Tendrid/gists{/gist_id}","starred_url":"https://api.github.com/users/Tendrid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tendrid/subscriptions","organizations_url":"https://api.github.com/users/Tendrid/orgs","repos_url":"https://api.github.com/users/Tendrid/repos","events_url":"https://api.github.com/users/Tendrid/events{/privacy}","received_events_url":"https://api.github.com/users/Tendrid/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Tendrid/dScripts","description":null,"fork":true,"url":"https://api.github.com/repos/Tendrid/dScripts","forks_url":"https://api.github.com/repos/Tendrid/dScripts/forks","keys_url":"https://api.github.com/repos/Tendrid/dScripts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Tendrid/dScripts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Tendrid/dScripts/teams","hooks_url":"https://api.github.com/repos/Tendrid/dScripts/hooks","issue_events_url":"https://api.github.com/repos/Tendrid/dScripts/issues/events{/number}","events_url":"https://api.github.com/repos/Tendrid/dScripts/events","assignees_url":"https://api.github.com/repos/Tendrid/dScripts/assignees{/user}","branches_url":"https://api.github.com/repos/Tendrid/dScripts/branches{/branch}","tags_url":"https://api.github.com/repos/Tendrid/dScripts/tags","blobs_url":"https://api.github.com/repos/Tendrid/dScripts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Tendrid/dScripts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Tendrid/dScripts/git/refs{/sha}","trees_url":"https://api.github.com/repos/Tendrid/dScripts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Tendrid/dScripts/statuses/{sha}","languages_url":"https://api.github.com/repos/Tendrid/dScripts/languages","stargazers_url":"https://api.github.com/repos/Tendrid/dScripts/stargazers","contributors_url":"https://api.github.com/repos/Tendrid/dScripts/contributors","subscribers_url":"https://api.github.com/repos/Tendrid/dScripts/subscribers","subscription_url":"https://api.github.com/repos/Tendrid/dScripts/subscription","commits_url":"https://api.github.com/repos/Tendrid/dScripts/commits{/sha}","git_commits_url":"https://api.github.com/repos/Tendrid/dScripts/git/commits{/sha}","comments_url":"https://api.github.com/repos/Tendrid/dScripts/comments{/number}","issue_comment_url":"https://api.github.com/repos/Tendrid/dScripts/issues/comments{/number}","contents_url":"https://api.github.com/repos/Tendrid/dScripts/contents/{+path}","compare_url":"https://api.github.com/repos/Tendrid/dScripts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Tendrid/dScripts/merges","archive_url":"https://api.github.com/repos/Tendrid/dScripts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Tendrid/dScripts/downloads","issues_url":"https://api.github.com/repos/Tendrid/dScripts/issues{/number}","pulls_url":"https://api.github.com/repos/Tendrid/dScripts/pulls{/number}","milestones_url":"https://api.github.com/repos/Tendrid/dScripts/milestones{/number}","notifications_url":"https://api.github.com/repos/Tendrid/dScripts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Tendrid/dScripts/labels{/name}","releases_url":"https://api.github.com/repos/Tendrid/dScripts/releases{/id}","deployments_url":"https://api.github.com/repos/Tendrid/dScripts/deployments","created_at":"2016-10-29T02:57:37Z","updated_at":"2016-06-06T07:36:43Z","pushed_at":"2016-10-29T06:38:20Z","git_url":"git://github.com/Tendrid/dScripts.git","ssh_url":"git@github.com:Tendrid/dScripts.git","clone_url":"https://github.com/Tendrid/dScripts.git","svn_url":"https://github.com/Tendrid/dScripts","homepage":null,"size":110,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"BlackCoyote:master","ref":"master","sha":"421665b5444bc9f93f544854fb9cb33c0085fd74","user":{"login":"BlackCoyote","id":6047423,"avatar_url":"https://avatars.githubusercontent.com/u/6047423?v=3","gravatar_id":"","url":"https://api.github.com/users/BlackCoyote","html_url":"https://github.com/BlackCoyote","followers_url":"https://api.github.com/users/BlackCoyote/followers","following_url":"https://api.github.com/users/BlackCoyote/following{/other_user}","gists_url":"https://api.github.com/users/BlackCoyote/gists{/gist_id}","starred_url":"https://api.github.com/users/BlackCoyote/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BlackCoyote/subscriptions","organizations_url":"https://api.github.com/users/BlackCoyote/orgs","repos_url":"https://api.github.com/users/BlackCoyote/repos","events_url":"https://api.github.com/users/BlackCoyote/events{/privacy}","received_events_url":"https://api.github.com/users/BlackCoyote/received_events","type":"User","site_admin":false},"repo":{"id":60508094,"name":"dScripts","full_name":"BlackCoyote/dScripts","owner":{"login":"BlackCoyote","id":6047423,"avatar_url":"https://avatars.githubusercontent.com/u/6047423?v=3","gravatar_id":"","url":"https://api.github.com/users/BlackCoyote","html_url":"https://github.com/BlackCoyote","followers_url":"https://api.github.com/users/BlackCoyote/followers","following_url":"https://api.github.com/users/BlackCoyote/following{/other_user}","gists_url":"https://api.github.com/users/BlackCoyote/gists{/gist_id}","starred_url":"https://api.github.com/users/BlackCoyote/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BlackCoyote/subscriptions","organizations_url":"https://api.github.com/users/BlackCoyote/orgs","repos_url":"https://api.github.com/users/BlackCoyote/repos","events_url":"https://api.github.com/users/BlackCoyote/events{/privacy}","received_events_url":"https://api.github.com/users/BlackCoyote/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/BlackCoyote/dScripts","description":null,"fork":false,"url":"https://api.github.com/repos/BlackCoyote/dScripts","forks_url":"https://api.github.com/repos/BlackCoyote/dScripts/forks","keys_url":"https://api.github.com/repos/BlackCoyote/dScripts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BlackCoyote/dScripts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BlackCoyote/dScripts/teams","hooks_url":"https://api.github.com/repos/BlackCoyote/dScripts/hooks","issue_events_url":"https://api.github.com/repos/BlackCoyote/dScripts/issues/events{/number}","events_url":"https://api.github.com/repos/BlackCoyote/dScripts/events","assignees_url":"https://api.github.com/repos/BlackCoyote/dScripts/assignees{/user}","branches_url":"https://api.github.com/repos/BlackCoyote/dScripts/branches{/branch}","tags_url":"https://api.github.com/repos/BlackCoyote/dScripts/tags","blobs_url":"https://api.github.com/repos/BlackCoyote/dScripts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BlackCoyote/dScripts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BlackCoyote/dScripts/git/refs{/sha}","trees_url":"https://api.github.com/repos/BlackCoyote/dScripts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BlackCoyote/dScripts/statuses/{sha}","languages_url":"https://api.github.com/repos/BlackCoyote/dScripts/languages","stargazers_url":"https://api.github.com/repos/BlackCoyote/dScripts/stargazers","contributors_url":"https://api.github.com/repos/BlackCoyote/dScripts/contributors","subscribers_url":"https://api.github.com/repos/BlackCoyote/dScripts/subscribers","subscription_url":"https://api.github.com/repos/BlackCoyote/dScripts/subscription","commits_url":"https://api.github.com/repos/BlackCoyote/dScripts/commits{/sha}","git_commits_url":"https://api.github.com/repos/BlackCoyote/dScripts/git/commits{/sha}","comments_url":"https://api.github.com/repos/BlackCoyote/dScripts/comments{/number}","issue_comment_url":"https://api.github.com/repos/BlackCoyote/dScripts/issues/comments{/number}","contents_url":"https://api.github.com/repos/BlackCoyote/dScripts/contents/{+path}","compare_url":"https://api.github.com/repos/BlackCoyote/dScripts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BlackCoyote/dScripts/merges","archive_url":"https://api.github.com/repos/BlackCoyote/dScripts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BlackCoyote/dScripts/downloads","issues_url":"https://api.github.com/repos/BlackCoyote/dScripts/issues{/number}","pulls_url":"https://api.github.com/repos/BlackCoyote/dScripts/pulls{/number}","milestones_url":"https://api.github.com/repos/BlackCoyote/dScripts/milestones{/number}","notifications_url":"https://api.github.com/repos/BlackCoyote/dScripts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BlackCoyote/dScripts/labels{/name}","releases_url":"https://api.github.com/repos/BlackCoyote/dScripts/releases{/id}","deployments_url":"https://api.github.com/repos/BlackCoyote/dScripts/deployments","created_at":"2016-06-06T07:36:43Z","updated_at":"2016-06-06T07:36:43Z","pushed_at":"2016-10-28T19:59:35Z","git_url":"git://github.com/BlackCoyote/dScripts.git","ssh_url":"git@github.com:BlackCoyote/dScripts.git","clone_url":"https://github.com/BlackCoyote/dScripts.git","svn_url":"https://github.com/BlackCoyote/dScripts","homepage":null,"size":109,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/BlackCoyote/dScripts/pulls/6"},"html":{"href":"https://github.com/BlackCoyote/dScripts/pull/6"},"issue":{"href":"https://api.github.com/repos/BlackCoyote/dScripts/issues/6"},"comments":{"href":"https://api.github.com/repos/BlackCoyote/dScripts/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/BlackCoyote/dScripts/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/BlackCoyote/dScripts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/BlackCoyote/dScripts/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/BlackCoyote/dScripts/statuses/130d6696f1df9d88b69740b9492a836755fd888d"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":163,"deletions":48,"changed_files":1}}
{"actor":{"display_login":"Tendrid"}}