{"action":"created","issue":{"url":"https://api.github.com/repos/restic/restic/issues/649","repository_url":"https://api.github.com/repos/restic/restic","labels_url":"https://api.github.com/repos/restic/restic/issues/649/labels{/name}","comments_url":"https://api.github.com/repos/restic/restic/issues/649/comments","events_url":"https://api.github.com/repos/restic/restic/issues/649/events","html_url":"https://github.com/restic/restic/issues/649","id":184770001,"number":649,"title":"Typos in S3 backend?","user":{"login":"justinclift","id":406299,"avatar_url":"https://avatars.githubusercontent.com/u/406299?v=3","gravatar_id":"","url":"https://api.github.com/users/justinclift","html_url":"https://github.com/justinclift","followers_url":"https://api.github.com/users/justinclift/followers","following_url":"https://api.github.com/users/justinclift/following{/other_user}","gists_url":"https://api.github.com/users/justinclift/gists{/gist_id}","starred_url":"https://api.github.com/users/justinclift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinclift/subscriptions","organizations_url":"https://api.github.com/users/justinclift/orgs","repos_url":"https://api.github.com/users/justinclift/repos","events_url":"https://api.github.com/users/justinclift/events{/privacy}","received_events_url":"https://api.github.com/users/justinclift/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/restic/restic/labels/question","name":"question","color":"cc317c"}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-10-24T07:43:18Z","updated_at":"2016-10-24T12:32:35Z","closed_at":"2016-10-24T12:00:00Z","body":"Looking through the S3 backend code, these two seem potentially not quite right:\r\n\r\n* https://github.com/restic/restic/blob/master/src/restic/backend/s3/s3.go#L97-L100\r\n* https://github.com/restic/restic/blob/master/src/restic/backend/s3/s3.go#L194-L196\r\n\r\nComparing those with this, which seems like it's ok:\r\n\r\n* https://github.com/restic/restic/blob/master/src/restic/backend/sftp/sftp.go#L348\r\n\r\nIs not checking the value of `e` needed for the S3 backend?\r\n\r\nNote - still getting into Golang though, so it's completely possible I'm not seeing something. :smile:\r\n"},"comment":{"url":"https://api.github.com/repos/restic/restic/issues/comments/255727360","html_url":"https://github.com/restic/restic/issues/649#issuecomment-255727360","issue_url":"https://api.github.com/repos/restic/restic/issues/649","id":255727360,"user":{"login":"fd0","id":123276,"avatar_url":"https://avatars.githubusercontent.com/u/123276?v=3","gravatar_id":"","url":"https://api.github.com/users/fd0","html_url":"https://github.com/fd0","followers_url":"https://api.github.com/users/fd0/followers","following_url":"https://api.github.com/users/fd0/following{/other_user}","gists_url":"https://api.github.com/users/fd0/gists{/gist_id}","starred_url":"https://api.github.com/users/fd0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fd0/subscriptions","organizations_url":"https://api.github.com/users/fd0/orgs","repos_url":"https://api.github.com/users/fd0/repos","events_url":"https://api.github.com/users/fd0/events{/privacy}","received_events_url":"https://api.github.com/users/fd0/received_events","type":"User","site_admin":false},"created_at":"2016-10-24T12:32:35Z","updated_at":"2016-10-24T12:32:35Z","body":"I'd accept a PR if you'd like to do one ;)"}}
{"actor":{"display_login":"fd0"}}