{"action":"created","issue":{"url":"https://api.github.com/repos/sourcegraph/appdash/issues/104","labels_url":"https://api.github.com/repos/sourcegraph/appdash/issues/104/labels{/name}","comments_url":"https://api.github.com/repos/sourcegraph/appdash/issues/104/comments","events_url":"https://api.github.com/repos/sourcegraph/appdash/issues/104/events","html_url":"https://github.com/sourcegraph/appdash/pull/104","id":128426929,"number":104,"title":"Improves TestChunkedCollector.","user":{"login":"chris-ramon","id":1000404,"avatar_url":"https://avatars.githubusercontent.com/u/1000404?v=3","gravatar_id":"","url":"https://api.github.com/users/chris-ramon","html_url":"https://github.com/chris-ramon","followers_url":"https://api.github.com/users/chris-ramon/followers","following_url":"https://api.github.com/users/chris-ramon/following{/other_user}","gists_url":"https://api.github.com/users/chris-ramon/gists{/gist_id}","starred_url":"https://api.github.com/users/chris-ramon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chris-ramon/subscriptions","organizations_url":"https://api.github.com/users/chris-ramon/orgs","repos_url":"https://api.github.com/users/chris-ramon/repos","events_url":"https://api.github.com/users/chris-ramon/events{/privacy}","received_events_url":"https://api.github.com/users/chris-ramon/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-01-24T21:37:43Z","updated_at":"2016-01-25T17:09:35Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/sourcegraph/appdash/pulls/104","html_url":"https://github.com/sourcegraph/appdash/pull/104","diff_url":"https://github.com/sourcegraph/appdash/pull/104.diff","patch_url":"https://github.com/sourcegraph/appdash/pull/104.patch"},"body":"#### Details\r\n\r\nIssue: #101 \r\n\r\n- Improves `TestChunkedCollector` - it does intermittently fails becase `reflect.DeepEqual` cares about element position when comparing, so `expected` & `actual` variables being compare sometimes might have the same elements but in different order.\r\n- [x] Adds `type byTraceID` which we do use to sort `[]*wire.CollectPacket` within `TestChunkedCollector`."},"comment":{"url":"https://api.github.com/repos/sourcegraph/appdash/issues/comments/174588364","html_url":"https://github.com/sourcegraph/appdash/pull/104#issuecomment-174588364","issue_url":"https://api.github.com/repos/sourcegraph/appdash/issues/104","id":174588364,"user":{"login":"slimsag","id":3173176,"avatar_url":"https://avatars.githubusercontent.com/u/3173176?v=3","gravatar_id":"","url":"https://api.github.com/users/slimsag","html_url":"https://github.com/slimsag","followers_url":"https://api.github.com/users/slimsag/followers","following_url":"https://api.github.com/users/slimsag/following{/other_user}","gists_url":"https://api.github.com/users/slimsag/gists{/gist_id}","starred_url":"https://api.github.com/users/slimsag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slimsag/subscriptions","organizations_url":"https://api.github.com/users/slimsag/orgs","repos_url":"https://api.github.com/users/slimsag/repos","events_url":"https://api.github.com/users/slimsag/events{/privacy}","received_events_url":"https://api.github.com/users/slimsag/received_events","type":"User","site_admin":false},"created_at":"2016-01-25T17:09:35Z","updated_at":"2016-01-25T17:09:35Z","body":"Thanks @chris-ramon -- LGTM.\r\n\r\n@shurcooL yeah, the order is non-deterministic. We were seeing builds fail randomly (see #101) and not deterministically. Out of my curiosity, and for your record, I fact checked. The reason this happens is because ChunkedCollector.Collect uses a map for internally storing these. You can see that here (look for `pendingBySpanID`): https://sourcegraph.com/github.com/sourcegraph/appdash@master/.GoPackage/github.com/sourcegraph/appdash/.def/ChunkedCollector/Collect\r\n\r\n"}}