{"action":"created","issue":{"url":"https://api.github.com/repos/manala/manala/issues/19","repository_url":"https://api.github.com/repos/manala/manala","labels_url":"https://api.github.com/repos/manala/manala/issues/19/labels{/name}","comments_url":"https://api.github.com/repos/manala/manala/issues/19/comments","events_url":"https://api.github.com/repos/manala/manala/issues/19/events","html_url":"https://github.com/manala/manala/pull/19","id":178832965,"number":19,"title":"Add Requirement checks command","user":{"login":"xavier-rdo","id":1587796,"avatar_url":"https://avatars.githubusercontent.com/u/1587796?v=3","gravatar_id":"","url":"https://api.github.com/users/xavier-rdo","html_url":"https://github.com/xavier-rdo","followers_url":"https://api.github.com/users/xavier-rdo/followers","following_url":"https://api.github.com/users/xavier-rdo/following{/other_user}","gists_url":"https://api.github.com/users/xavier-rdo/gists{/gist_id}","starred_url":"https://api.github.com/users/xavier-rdo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xavier-rdo/subscriptions","organizations_url":"https://api.github.com/users/xavier-rdo/orgs","repos_url":"https://api.github.com/users/xavier-rdo/repos","events_url":"https://api.github.com/users/xavier-rdo/events{/privacy}","received_events_url":"https://api.github.com/users/xavier-rdo/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/manala/manala/labels/Needs%20review","name":"Needs review","color":"333333"}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2016-09-23T09:49:30Z","updated_at":"2016-09-30T21:42:52Z","closed_at":"2016-09-30T21:42:25Z","pull_request":{"url":"https://api.github.com/repos/manala/manala/pulls/19","html_url":"https://github.com/manala/manala/pull/19","diff_url":"https://github.com/manala/manala/pull/19.diff","patch_url":"https://github.com/manala/manala/pull/19.patch"},"body":"**Acceptance criteria:**\r\n\r\n- [x] Distinguish between requirements & suggestions (1)\r\n- [x] Introduce checking processors that can be mocked (to make tests environment-agnostic) (2)\r\n- [x] Introduce different checker types : binary checker, vagrant plugin checker, etc. (3)\r\n- [x] Required version: semver-formatted (4)\r\n- [x] Unit tests\r\n- [x] Console output colored according to requirement level (required, recommended, etc.)\r\n\r\n(1) vagrant & vagrant plugin landrush are required, ansible is suggested (required to deploy, not to provision VM)\r\n\r\n(2) Processing a binary != processing a vagrant plugin\r\n\r\n(3) Check vagrant & ansible (binaries) but also check landrush (vagrant plugin) : \r\n\r\n* check that a binary is OK: `<binary> --version`\r\n* check that a vagrant plugin is OK: `vagrant plugin list` and check that the expected plugin is in the list\r\n\r\n(4) See https://github.com/composer/semver ; Example: \"~1.8\"\r\n\r\nTODO LATER : \r\n\r\n- Functional test (with venv - virtual environments - https://docs.python.org/3/library/venv.html ?)"},"comment":{"url":"https://api.github.com/repos/manala/manala/issues/comments/250859341","html_url":"https://github.com/manala/manala/pull/19#issuecomment-250859341","issue_url":"https://api.github.com/repos/manala/manala/issues/19","id":250859341,"user":{"login":"chalasr","id":7502063,"avatar_url":"https://avatars.githubusercontent.com/u/7502063?v=3","gravatar_id":"","url":"https://api.github.com/users/chalasr","html_url":"https://github.com/chalasr","followers_url":"https://api.github.com/users/chalasr/followers","following_url":"https://api.github.com/users/chalasr/following{/other_user}","gists_url":"https://api.github.com/users/chalasr/gists{/gist_id}","starred_url":"https://api.github.com/users/chalasr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chalasr/subscriptions","organizations_url":"https://api.github.com/users/chalasr/orgs","repos_url":"https://api.github.com/users/chalasr/repos","events_url":"https://api.github.com/users/chalasr/events{/privacy}","received_events_url":"https://api.github.com/users/chalasr/received_events","type":"User","site_admin":false},"created_at":"2016-09-30T21:42:52Z","updated_at":"2016-09-30T21:42:52Z","body":"Thank you @xavier-rdo "}}
{"actor":{"display_login":"chalasr"}}