{"action":"created","comment":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/comments/65330636","id":65330636,"diff_hunk":"@@ -202,10 +202,22 @@ pub fn run_compiler_with_file_loader<'a, L>(args: &[String],\n     let codemap = Rc::new(CodeMap::with_file_loader(loader));\n     let sess = session::build_session_with_codemap(sopts,\n                                                    &dep_graph,\n-                                                   input_file_path,\n+                                                   input_file_path.clone(),\n                                                    descriptions,\n                                                    cstore.clone(),\n                                                    codemap);\n+\n+    // This isn't used later in the compilation process, it's only used to check for overwrites of\n+    // the source file.\n+    let output_filenames = driver::build_output_filenames(&input, &odir, &ofile, &[], &sess);\n+    match input_file_path {\n+        Some(ifile) => if output_filenames.path(OutputType::Exe) == ifile {","path":"src/librustc_driver/lib.rs","position":14,"original_position":14,"commit_id":"c29b8ded6fd95c82786c78fd17848cc085a204b6","original_commit_id":"c29b8ded6fd95c82786c78fd17848cc085a204b6","user":{"login":"LeoTestard","id":907750,"avatar_url":"https://avatars.githubusercontent.com/u/907750?v=3","gravatar_id":"","url":"https://api.github.com/users/LeoTestard","html_url":"https://github.com/LeoTestard","followers_url":"https://api.github.com/users/LeoTestard/followers","following_url":"https://api.github.com/users/LeoTestard/following{/other_user}","gists_url":"https://api.github.com/users/LeoTestard/gists{/gist_id}","starred_url":"https://api.github.com/users/LeoTestard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LeoTestard/subscriptions","organizations_url":"https://api.github.com/users/LeoTestard/orgs","repos_url":"https://api.github.com/users/LeoTestard/repos","events_url":"https://api.github.com/users/LeoTestard/events{/privacy}","received_events_url":"https://api.github.com/users/LeoTestard/received_events","type":"User","site_admin":false},"body":"Hmm... Why checking only the executable output type? Rust can generate bytecode or assembly too and, as far as I know, all could overwrite the input file.","created_at":"2016-06-01T09:40:24Z","updated_at":"2016-06-01T09:40:24Z","html_url":"https://github.com/rust-lang/rust/pull/34005#discussion_r65330636","pull_request_url":"https://api.github.com/repos/rust-lang/rust/pulls/34005","_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments/65330636"},"html":{"href":"https://github.com/rust-lang/rust/pull/34005#discussion_r65330636"},"pull_request":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/34005"}}},"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/34005","id":72142100,"html_url":"https://github.com/rust-lang/rust/pull/34005","diff_url":"https://github.com/rust-lang/rust/pull/34005.diff","patch_url":"https://github.com/rust-lang/rust/pull/34005.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/34005","number":34005,"state":"open","locked":false,"title":"Do not overwrite input file if it has no extension","user":{"login":"estebank","id":1606434,"avatar_url":"https://avatars.githubusercontent.com/u/1606434?v=3","gravatar_id":"","url":"https://api.github.com/users/estebank","html_url":"https://github.com/estebank","followers_url":"https://api.github.com/users/estebank/followers","following_url":"https://api.github.com/users/estebank/following{/other_user}","gists_url":"https://api.github.com/users/estebank/gists{/gist_id}","starred_url":"https://api.github.com/users/estebank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/estebank/subscriptions","organizations_url":"https://api.github.com/users/estebank/orgs","repos_url":"https://api.github.com/users/estebank/repos","events_url":"https://api.github.com/users/estebank/events{/privacy}","received_events_url":"https://api.github.com/users/estebank/received_events","type":"User","site_admin":false},"body":"Check wether the source file has the same path as the executable to be\r\ngenerated and fail early if it would overwrite the source file with the\r\nexecutable.\r\n\r\n```bash\r\n% echo 'fn main(){}' > file && ./rustc file\r\nerror: the input file would be overwritten by the generated executable\r\nerror: aborting due to previous error\r\n```\r\n\r\nFixes #13019","created_at":"2016-06-01T08:40:53Z","updated_at":"2016-06-01T09:40:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4ec001f90cc0b71b065f0d13e9e24c29fc482af9","assignee":{"login":"Aatch","id":342416,"avatar_url":"https://avatars.githubusercontent.com/u/342416?v=3","gravatar_id":"","url":"https://api.github.com/users/Aatch","html_url":"https://github.com/Aatch","followers_url":"https://api.github.com/users/Aatch/followers","following_url":"https://api.github.com/users/Aatch/following{/other_user}","gists_url":"https://api.github.com/users/Aatch/gists{/gist_id}","starred_url":"https://api.github.com/users/Aatch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Aatch/subscriptions","organizations_url":"https://api.github.com/users/Aatch/orgs","repos_url":"https://api.github.com/users/Aatch/repos","events_url":"https://api.github.com/users/Aatch/events{/privacy}","received_events_url":"https://api.github.com/users/Aatch/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/34005/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/34005/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/34005/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/c29b8ded6fd95c82786c78fd17848cc085a204b6","head":{"label":"estebank:sourcefilecheck","ref":"sourcefilecheck","sha":"c29b8ded6fd95c82786c78fd17848cc085a204b6","user":{"login":"estebank","id":1606434,"avatar_url":"https://avatars.githubusercontent.com/u/1606434?v=3","gravatar_id":"","url":"https://api.github.com/users/estebank","html_url":"https://github.com/estebank","followers_url":"https://api.github.com/users/estebank/followers","following_url":"https://api.github.com/users/estebank/following{/other_user}","gists_url":"https://api.github.com/users/estebank/gists{/gist_id}","starred_url":"https://api.github.com/users/estebank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/estebank/subscriptions","organizations_url":"https://api.github.com/users/estebank/orgs","repos_url":"https://api.github.com/users/estebank/repos","events_url":"https://api.github.com/users/estebank/events{/privacy}","received_events_url":"https://api.github.com/users/estebank/received_events","type":"User","site_admin":false},"repo":{"id":59872990,"name":"rust","full_name":"estebank/rust","owner":{"login":"estebank","id":1606434,"avatar_url":"https://avatars.githubusercontent.com/u/1606434?v=3","gravatar_id":"","url":"https://api.github.com/users/estebank","html_url":"https://github.com/estebank","followers_url":"https://api.github.com/users/estebank/followers","following_url":"https://api.github.com/users/estebank/following{/other_user}","gists_url":"https://api.github.com/users/estebank/gists{/gist_id}","starred_url":"https://api.github.com/users/estebank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/estebank/subscriptions","organizations_url":"https://api.github.com/users/estebank/orgs","repos_url":"https://api.github.com/users/estebank/repos","events_url":"https://api.github.com/users/estebank/events{/privacy}","received_events_url":"https://api.github.com/users/estebank/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/estebank/rust","description":"A safe, concurrent, practical language.","fork":true,"url":"https://api.github.com/repos/estebank/rust","forks_url":"https://api.github.com/repos/estebank/rust/forks","keys_url":"https://api.github.com/repos/estebank/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/estebank/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/estebank/rust/teams","hooks_url":"https://api.github.com/repos/estebank/rust/hooks","issue_events_url":"https://api.github.com/repos/estebank/rust/issues/events{/number}","events_url":"https://api.github.com/repos/estebank/rust/events","assignees_url":"https://api.github.com/repos/estebank/rust/assignees{/user}","branches_url":"https://api.github.com/repos/estebank/rust/branches{/branch}","tags_url":"https://api.github.com/repos/estebank/rust/tags","blobs_url":"https://api.github.com/repos/estebank/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/estebank/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/estebank/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/estebank/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/estebank/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/estebank/rust/languages","stargazers_url":"https://api.github.com/repos/estebank/rust/stargazers","contributors_url":"https://api.github.com/repos/estebank/rust/contributors","subscribers_url":"https://api.github.com/repos/estebank/rust/subscribers","subscription_url":"https://api.github.com/repos/estebank/rust/subscription","commits_url":"https://api.github.com/repos/estebank/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/estebank/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/estebank/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/estebank/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/estebank/rust/contents/{+path}","compare_url":"https://api.github.com/repos/estebank/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/estebank/rust/merges","archive_url":"https://api.github.com/repos/estebank/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/estebank/rust/downloads","issues_url":"https://api.github.com/repos/estebank/rust/issues{/number}","pulls_url":"https://api.github.com/repos/estebank/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/estebank/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/estebank/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/estebank/rust/labels{/name}","releases_url":"https://api.github.com/repos/estebank/rust/releases{/id}","deployments_url":"https://api.github.com/repos/estebank/rust/deployments","created_at":"2016-05-28T02:09:15Z","updated_at":"2016-05-28T02:09:33Z","pushed_at":"2016-06-01T08:48:42Z","git_url":"git://github.com/estebank/rust.git","ssh_url":"git@github.com:estebank/rust.git","clone_url":"https://github.com/estebank/rust.git","svn_url":"https://github.com/estebank/rust","homepage":"https://www.rust-lang.org","size":293971,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"433d70cda2e6d61d5bbb20423f0937a643cf34b4","user":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"name":"rust","full_name":"rust-lang/rust","owner":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/rust","description":"A safe, concurrent, practical language.","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","deployments_url":"https://api.github.com/repos/rust-lang/rust/deployments","created_at":"2010-06-16T20:39:03Z","updated_at":"2016-06-01T09:11:03Z","pushed_at":"2016-06-01T08:40:53Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"git@github.com:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"https://www.rust-lang.org","size":495392,"stargazers_count":16912,"watchers_count":16912,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3219,"mirror_url":null,"open_issues_count":2525,"forks":3219,"open_issues":2525,"watchers":16912,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/34005"},"html":{"href":"https://github.com/rust-lang/rust/pull/34005"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/34005"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/34005/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/34005/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/34005/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/c29b8ded6fd95c82786c78fd17848cc085a204b6"}}}}
{"actor":{"display_login":"LeoTestard"}}