{"action":"created","comment":{"url":"https://api.github.com/repos/vatesfr/xo-server/pulls/comments/50519722","id":50519722,"diff_hunk":"@@ -0,0 +1,49 @@\n+export default class RemoteHandlerAbstract {\n+  constructor (remote) {\n+    this._remote = remote\n+  }\n+\n+  set (remote) {\n+    this._remote = remote\n+  }\n+\n+  async sync () {","path":"src/remote-handlers/abstract.js","position":10,"original_position":10,"commit_id":"57015341c38060d2085e24af6adf9d3c31d19078","original_commit_id":"57015341c38060d2085e24af6adf9d3c31d19078","user":{"login":"julien-f","id":298721,"avatar_url":"https://avatars.githubusercontent.com/u/298721?v=3","gravatar_id":"","url":"https://api.github.com/users/julien-f","html_url":"https://github.com/julien-f","followers_url":"https://api.github.com/users/julien-f/followers","following_url":"https://api.github.com/users/julien-f/following{/other_user}","gists_url":"https://api.github.com/users/julien-f/gists{/gist_id}","starred_url":"https://api.github.com/users/julien-f/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julien-f/subscriptions","organizations_url":"https://api.github.com/users/julien-f/orgs","repos_url":"https://api.github.com/users/julien-f/repos","events_url":"https://api.github.com/users/julien-f/events{/privacy}","received_events_url":"https://api.github.com/users/julien-f/received_events","type":"User","site_admin":false},"body":"A common pattern is to have all public methods call private methods which are meant to be defined in inherited classes:\r\n\r\n```js\r\nsync () {\r\n  return this._sync()\r\n}\r\n_sync () {\r\n  throw new Error('not implemented')\r\n}\r\n```\r\n\r\nIt is handy because it allows us to add some common code around the specific implementations (e.g. [collection.js](/vatesfr/xo-server/blob/next-release/src/collection.js)).","created_at":"2016-01-22T10:03:23Z","updated_at":"2016-01-22T10:03:23Z","html_url":"https://github.com/vatesfr/xo-server/pull/159#discussion_r50519722","pull_request_url":"https://api.github.com/repos/vatesfr/xo-server/pulls/159","_links":{"self":{"href":"https://api.github.com/repos/vatesfr/xo-server/pulls/comments/50519722"},"html":{"href":"https://github.com/vatesfr/xo-server/pull/159#discussion_r50519722"},"pull_request":{"href":"https://api.github.com/repos/vatesfr/xo-server/pulls/159"}}},"pull_request":{"url":"https://api.github.com/repos/vatesfr/xo-server/pulls/159","id":52863838,"html_url":"https://github.com/vatesfr/xo-server/pull/159","diff_url":"https://github.com/vatesfr/xo-server/pull/159.diff","patch_url":"https://github.com/vatesfr/xo-server/pull/159.patch","issue_url":"https://api.github.com/repos/vatesfr/xo-server/issues/159","number":159,"state":"open","locked":false,"title":"Smb remote","user":{"login":"marsaud","id":1221675,"avatar_url":"https://avatars.githubusercontent.com/u/1221675?v=3","gravatar_id":"","url":"https://api.github.com/users/marsaud","html_url":"https://github.com/marsaud","followers_url":"https://api.github.com/users/marsaud/followers","following_url":"https://api.github.com/users/marsaud/following{/other_user}","gists_url":"https://api.github.com/users/marsaud/gists{/gist_id}","starred_url":"https://api.github.com/users/marsaud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marsaud/subscriptions","organizations_url":"https://api.github.com/users/marsaud/orgs","repos_url":"https://api.github.com/users/marsaud/repos","events_url":"https://api.github.com/users/marsaud/events{/privacy}","received_events_url":"https://api.github.com/users/marsaud/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-12-07T16:08:52Z","updated_at":"2016-01-22T10:03:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0cc5b53f760df000542ba8d0f279b9130921d6ca","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/vatesfr/xo-server/pulls/159/commits","review_comments_url":"https://api.github.com/repos/vatesfr/xo-server/pulls/159/comments","review_comment_url":"https://api.github.com/repos/vatesfr/xo-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vatesfr/xo-server/issues/159/comments","statuses_url":"https://api.github.com/repos/vatesfr/xo-server/statuses/57015341c38060d2085e24af6adf9d3c31d19078","head":{"label":"vatesfr:marsaudf-smb-mounts#338","ref":"marsaudf-smb-mounts#338","sha":"57015341c38060d2085e24af6adf9d3c31d19078","user":{"login":"vatesfr","id":2064170,"avatar_url":"https://avatars.githubusercontent.com/u/2064170?v=3","gravatar_id":"","url":"https://api.github.com/users/vatesfr","html_url":"https://github.com/vatesfr","followers_url":"https://api.github.com/users/vatesfr/followers","following_url":"https://api.github.com/users/vatesfr/following{/other_user}","gists_url":"https://api.github.com/users/vatesfr/gists{/gist_id}","starred_url":"https://api.github.com/users/vatesfr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vatesfr/subscriptions","organizations_url":"https://api.github.com/users/vatesfr/orgs","repos_url":"https://api.github.com/users/vatesfr/repos","events_url":"https://api.github.com/users/vatesfr/events{/privacy}","received_events_url":"https://api.github.com/users/vatesfr/received_events","type":"Organization","site_admin":false},"repo":{"id":7262203,"name":"xo-server","full_name":"vatesfr/xo-server","owner":{"login":"vatesfr","id":2064170,"avatar_url":"https://avatars.githubusercontent.com/u/2064170?v=3","gravatar_id":"","url":"https://api.github.com/users/vatesfr","html_url":"https://github.com/vatesfr","followers_url":"https://api.github.com/users/vatesfr/followers","following_url":"https://api.github.com/users/vatesfr/following{/other_user}","gists_url":"https://api.github.com/users/vatesfr/gists{/gist_id}","starred_url":"https://api.github.com/users/vatesfr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vatesfr/subscriptions","organizations_url":"https://api.github.com/users/vatesfr/orgs","repos_url":"https://api.github.com/users/vatesfr/repos","events_url":"https://api.github.com/users/vatesfr/events{/privacy}","received_events_url":"https://api.github.com/users/vatesfr/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vatesfr/xo-server","description":"Server part of Xen Orchestra.","fork":false,"url":"https://api.github.com/repos/vatesfr/xo-server","forks_url":"https://api.github.com/repos/vatesfr/xo-server/forks","keys_url":"https://api.github.com/repos/vatesfr/xo-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vatesfr/xo-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vatesfr/xo-server/teams","hooks_url":"https://api.github.com/repos/vatesfr/xo-server/hooks","issue_events_url":"https://api.github.com/repos/vatesfr/xo-server/issues/events{/number}","events_url":"https://api.github.com/repos/vatesfr/xo-server/events","assignees_url":"https://api.github.com/repos/vatesfr/xo-server/assignees{/user}","branches_url":"https://api.github.com/repos/vatesfr/xo-server/branches{/branch}","tags_url":"https://api.github.com/repos/vatesfr/xo-server/tags","blobs_url":"https://api.github.com/repos/vatesfr/xo-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vatesfr/xo-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vatesfr/xo-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/vatesfr/xo-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vatesfr/xo-server/statuses/{sha}","languages_url":"https://api.github.com/repos/vatesfr/xo-server/languages","stargazers_url":"https://api.github.com/repos/vatesfr/xo-server/stargazers","contributors_url":"https://api.github.com/repos/vatesfr/xo-server/contributors","subscribers_url":"https://api.github.com/repos/vatesfr/xo-server/subscribers","subscription_url":"https://api.github.com/repos/vatesfr/xo-server/subscription","commits_url":"https://api.github.com/repos/vatesfr/xo-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/vatesfr/xo-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/vatesfr/xo-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/vatesfr/xo-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/vatesfr/xo-server/contents/{+path}","compare_url":"https://api.github.com/repos/vatesfr/xo-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vatesfr/xo-server/merges","archive_url":"https://api.github.com/repos/vatesfr/xo-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vatesfr/xo-server/downloads","issues_url":"https://api.github.com/repos/vatesfr/xo-server/issues{/number}","pulls_url":"https://api.github.com/repos/vatesfr/xo-server/pulls{/number}","milestones_url":"https://api.github.com/repos/vatesfr/xo-server/milestones{/number}","notifications_url":"https://api.github.com/repos/vatesfr/xo-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vatesfr/xo-server/labels{/name}","releases_url":"https://api.github.com/repos/vatesfr/xo-server/releases{/id}","deployments_url":"https://api.github.com/repos/vatesfr/xo-server/deployments","created_at":"2012-12-20T18:23:37Z","updated_at":"2016-01-21T19:35:31Z","pushed_at":"2016-01-22T09:51:42Z","git_url":"git://github.com/vatesfr/xo-server.git","ssh_url":"git@github.com:vatesfr/xo-server.git","clone_url":"https://github.com/vatesfr/xo-server.git","svn_url":"https://github.com/vatesfr/xo-server","homepage":"","size":1917,"stargazers_count":50,"watchers_count":50,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"open_issues_count":28,"forks":23,"open_issues":28,"watchers":50,"default_branch":"next-release"}},"base":{"label":"vatesfr:next-release","ref":"next-release","sha":"4bdd6f972c41fea9082b2033276cc0c975207c69","user":{"login":"vatesfr","id":2064170,"avatar_url":"https://avatars.githubusercontent.com/u/2064170?v=3","gravatar_id":"","url":"https://api.github.com/users/vatesfr","html_url":"https://github.com/vatesfr","followers_url":"https://api.github.com/users/vatesfr/followers","following_url":"https://api.github.com/users/vatesfr/following{/other_user}","gists_url":"https://api.github.com/users/vatesfr/gists{/gist_id}","starred_url":"https://api.github.com/users/vatesfr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vatesfr/subscriptions","organizations_url":"https://api.github.com/users/vatesfr/orgs","repos_url":"https://api.github.com/users/vatesfr/repos","events_url":"https://api.github.com/users/vatesfr/events{/privacy}","received_events_url":"https://api.github.com/users/vatesfr/received_events","type":"Organization","site_admin":false},"repo":{"id":7262203,"name":"xo-server","full_name":"vatesfr/xo-server","owner":{"login":"vatesfr","id":2064170,"avatar_url":"https://avatars.githubusercontent.com/u/2064170?v=3","gravatar_id":"","url":"https://api.github.com/users/vatesfr","html_url":"https://github.com/vatesfr","followers_url":"https://api.github.com/users/vatesfr/followers","following_url":"https://api.github.com/users/vatesfr/following{/other_user}","gists_url":"https://api.github.com/users/vatesfr/gists{/gist_id}","starred_url":"https://api.github.com/users/vatesfr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vatesfr/subscriptions","organizations_url":"https://api.github.com/users/vatesfr/orgs","repos_url":"https://api.github.com/users/vatesfr/repos","events_url":"https://api.github.com/users/vatesfr/events{/privacy}","received_events_url":"https://api.github.com/users/vatesfr/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vatesfr/xo-server","description":"Server part of Xen Orchestra.","fork":false,"url":"https://api.github.com/repos/vatesfr/xo-server","forks_url":"https://api.github.com/repos/vatesfr/xo-server/forks","keys_url":"https://api.github.com/repos/vatesfr/xo-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vatesfr/xo-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vatesfr/xo-server/teams","hooks_url":"https://api.github.com/repos/vatesfr/xo-server/hooks","issue_events_url":"https://api.github.com/repos/vatesfr/xo-server/issues/events{/number}","events_url":"https://api.github.com/repos/vatesfr/xo-server/events","assignees_url":"https://api.github.com/repos/vatesfr/xo-server/assignees{/user}","branches_url":"https://api.github.com/repos/vatesfr/xo-server/branches{/branch}","tags_url":"https://api.github.com/repos/vatesfr/xo-server/tags","blobs_url":"https://api.github.com/repos/vatesfr/xo-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vatesfr/xo-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vatesfr/xo-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/vatesfr/xo-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vatesfr/xo-server/statuses/{sha}","languages_url":"https://api.github.com/repos/vatesfr/xo-server/languages","stargazers_url":"https://api.github.com/repos/vatesfr/xo-server/stargazers","contributors_url":"https://api.github.com/repos/vatesfr/xo-server/contributors","subscribers_url":"https://api.github.com/repos/vatesfr/xo-server/subscribers","subscription_url":"https://api.github.com/repos/vatesfr/xo-server/subscription","commits_url":"https://api.github.com/repos/vatesfr/xo-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/vatesfr/xo-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/vatesfr/xo-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/vatesfr/xo-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/vatesfr/xo-server/contents/{+path}","compare_url":"https://api.github.com/repos/vatesfr/xo-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vatesfr/xo-server/merges","archive_url":"https://api.github.com/repos/vatesfr/xo-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vatesfr/xo-server/downloads","issues_url":"https://api.github.com/repos/vatesfr/xo-server/issues{/number}","pulls_url":"https://api.github.com/repos/vatesfr/xo-server/pulls{/number}","milestones_url":"https://api.github.com/repos/vatesfr/xo-server/milestones{/number}","notifications_url":"https://api.github.com/repos/vatesfr/xo-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vatesfr/xo-server/labels{/name}","releases_url":"https://api.github.com/repos/vatesfr/xo-server/releases{/id}","deployments_url":"https://api.github.com/repos/vatesfr/xo-server/deployments","created_at":"2012-12-20T18:23:37Z","updated_at":"2016-01-21T19:35:31Z","pushed_at":"2016-01-22T09:51:42Z","git_url":"git://github.com/vatesfr/xo-server.git","ssh_url":"git@github.com:vatesfr/xo-server.git","clone_url":"https://github.com/vatesfr/xo-server.git","svn_url":"https://github.com/vatesfr/xo-server","homepage":"","size":1917,"stargazers_count":50,"watchers_count":50,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"open_issues_count":28,"forks":23,"open_issues":28,"watchers":50,"default_branch":"next-release"}},"_links":{"self":{"href":"https://api.github.com/repos/vatesfr/xo-server/pulls/159"},"html":{"href":"https://github.com/vatesfr/xo-server/pull/159"},"issue":{"href":"https://api.github.com/repos/vatesfr/xo-server/issues/159"},"comments":{"href":"https://api.github.com/repos/vatesfr/xo-server/issues/159/comments"},"review_comments":{"href":"https://api.github.com/repos/vatesfr/xo-server/pulls/159/comments"},"review_comment":{"href":"https://api.github.com/repos/vatesfr/xo-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vatesfr/xo-server/pulls/159/commits"},"statuses":{"href":"https://api.github.com/repos/vatesfr/xo-server/statuses/57015341c38060d2085e24af6adf9d3c31d19078"}}}}