{"action":"created","comment":{"url":"https://api.github.com/repos/akkadotnet/akka.net/pulls/comments/49943471","id":49943471,"diff_hunk":"@@ -164,13 +164,22 @@ private static EventAdapters Create(ExtendedActorSystem system, IDictionary<stri\n \n             // bindings is a enumerable of key-val representing the mapping from Type to handler.\n             // It is primarily ordered by the most specific classes first, and secondly in the configured order.\n+\n             var bindings = Sort(adapterBindings.Select(kv =>\n             {\n-                var type = Type.GetType(kv.Key);\n-                var adapter = kv.Value.Length == 1\n-                    ? handlers[kv.Value[0]]\n-                    : new CombinedReadEventAdapter(kv.Value.Select(h => handlers[h]));\n-                return new KeyValuePair<Type, IEventAdapter>(type, adapter);\n+                try\n+                {\n+                    var type = Type.GetType(kv.Key, true);\n+                    var adapter = kv.Value.Length == 1\n+                            ? handlers[kv.Value[0]]\n+                            : new CombinedReadEventAdapter(kv.Value.Select(h => handlers[h]));\n+                    return new KeyValuePair<Type, IEventAdapter>(type, adapter);\n+                }\n+                catch (Exception ex)\n+                {\n+                    var msgException = string.Format(\"Could not find type '{0}'\", kv.Key);\n+                    throw new TypeLoadException(msgException, ex);","path":"src/core/Akka.Persistence/Journal/EventAdapters.cs","position":23,"original_position":23,"commit_id":"4075462552ec50428b35dd294bf09ef1c0f04a2a","original_commit_id":"4075462552ec50428b35dd294bf09ef1c0f04a2a","user":{"login":"rogeralsing","id":647031,"avatar_url":"https://avatars.githubusercontent.com/u/647031?v=3","gravatar_id":"","url":"https://api.github.com/users/rogeralsing","html_url":"https://github.com/rogeralsing","followers_url":"https://api.github.com/users/rogeralsing/followers","following_url":"https://api.github.com/users/rogeralsing/following{/other_user}","gists_url":"https://api.github.com/users/rogeralsing/gists{/gist_id}","starred_url":"https://api.github.com/users/rogeralsing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rogeralsing/subscriptions","organizations_url":"https://api.github.com/users/rogeralsing/orgs","repos_url":"https://api.github.com/users/rogeralsing/repos","events_url":"https://api.github.com/users/rogeralsing/events{/privacy}","received_events_url":"https://api.github.com/users/rogeralsing/received_events","type":"User","site_admin":false},"body":"@Horusiath what would be the correct messages here?","created_at":"2016-01-17T09:10:51Z","updated_at":"2016-01-17T09:10:51Z","html_url":"https://github.com/akkadotnet/akka.net/pull/1602#discussion_r49943471","pull_request_url":"https://api.github.com/repos/akkadotnet/akka.net/pulls/1602","_links":{"self":{"href":"https://api.github.com/repos/akkadotnet/akka.net/pulls/comments/49943471"},"html":{"href":"https://github.com/akkadotnet/akka.net/pull/1602#discussion_r49943471"},"pull_request":{"href":"https://api.github.com/repos/akkadotnet/akka.net/pulls/1602"}}},"pull_request":{"url":"https://api.github.com/repos/akkadotnet/akka.net/pulls/1602","id":54606126,"html_url":"https://github.com/akkadotnet/akka.net/pull/1602","diff_url":"https://github.com/akkadotnet/akka.net/pull/1602.diff","patch_url":"https://github.com/akkadotnet/akka.net/pull/1602.patch","issue_url":"https://api.github.com/repos/akkadotnet/akka.net/issues/1602","number":1602,"state":"open","locked":false,"title":"adding TypeLoadException handling","user":{"login":"alex-kondrashov","id":4246666,"avatar_url":"https://avatars.githubusercontent.com/u/4246666?v=3","gravatar_id":"","url":"https://api.github.com/users/alex-kondrashov","html_url":"https://github.com/alex-kondrashov","followers_url":"https://api.github.com/users/alex-kondrashov/followers","following_url":"https://api.github.com/users/alex-kondrashov/following{/other_user}","gists_url":"https://api.github.com/users/alex-kondrashov/gists{/gist_id}","starred_url":"https://api.github.com/users/alex-kondrashov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alex-kondrashov/subscriptions","organizations_url":"https://api.github.com/users/alex-kondrashov/orgs","repos_url":"https://api.github.com/users/alex-kondrashov/repos","events_url":"https://api.github.com/users/alex-kondrashov/events{/privacy}","received_events_url":"https://api.github.com/users/alex-kondrashov/received_events","type":"User","site_admin":false},"body":"These fixes relate to this issue #1300.\r\n\r\nBasically I corrected all the places that I've found. The main idea behind those fixes is\r\n wrapping Type.GetType statement with try-catch and handling of TypeLoadException\r\n\r\nThere is only one commit with all the changes included.\r\n","created_at":"2015-12-26T19:06:48Z","updated_at":"2016-01-17T09:10:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e461784d67eebb2a6afea34433fb0ce66c01342e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/akkadotnet/akka.net/pulls/1602/commits","review_comments_url":"https://api.github.com/repos/akkadotnet/akka.net/pulls/1602/comments","review_comment_url":"https://api.github.com/repos/akkadotnet/akka.net/pulls/comments{/number}","comments_url":"https://api.github.com/repos/akkadotnet/akka.net/issues/1602/comments","statuses_url":"https://api.github.com/repos/akkadotnet/akka.net/statuses/4075462552ec50428b35dd294bf09ef1c0f04a2a","head":{"label":"alex-kondrashov:1300-throwing-type-exception2","ref":"1300-throwing-type-exception2","sha":"4075462552ec50428b35dd294bf09ef1c0f04a2a","user":{"login":"alex-kondrashov","id":4246666,"avatar_url":"https://avatars.githubusercontent.com/u/4246666?v=3","gravatar_id":"","url":"https://api.github.com/users/alex-kondrashov","html_url":"https://github.com/alex-kondrashov","followers_url":"https://api.github.com/users/alex-kondrashov/followers","following_url":"https://api.github.com/users/alex-kondrashov/following{/other_user}","gists_url":"https://api.github.com/users/alex-kondrashov/gists{/gist_id}","starred_url":"https://api.github.com/users/alex-kondrashov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alex-kondrashov/subscriptions","organizations_url":"https://api.github.com/users/alex-kondrashov/orgs","repos_url":"https://api.github.com/users/alex-kondrashov/repos","events_url":"https://api.github.com/users/alex-kondrashov/events{/privacy}","received_events_url":"https://api.github.com/users/alex-kondrashov/received_events","type":"User","site_admin":false},"repo":{"id":41698820,"name":"akka.net","full_name":"alex-kondrashov/akka.net","owner":{"login":"alex-kondrashov","id":4246666,"avatar_url":"https://avatars.githubusercontent.com/u/4246666?v=3","gravatar_id":"","url":"https://api.github.com/users/alex-kondrashov","html_url":"https://github.com/alex-kondrashov","followers_url":"https://api.github.com/users/alex-kondrashov/followers","following_url":"https://api.github.com/users/alex-kondrashov/following{/other_user}","gists_url":"https://api.github.com/users/alex-kondrashov/gists{/gist_id}","starred_url":"https://api.github.com/users/alex-kondrashov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alex-kondrashov/subscriptions","organizations_url":"https://api.github.com/users/alex-kondrashov/orgs","repos_url":"https://api.github.com/users/alex-kondrashov/repos","events_url":"https://api.github.com/users/alex-kondrashov/events{/privacy}","received_events_url":"https://api.github.com/users/alex-kondrashov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alex-kondrashov/akka.net","description":"Port of Akka actors for .NET","fork":true,"url":"https://api.github.com/repos/alex-kondrashov/akka.net","forks_url":"https://api.github.com/repos/alex-kondrashov/akka.net/forks","keys_url":"https://api.github.com/repos/alex-kondrashov/akka.net/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alex-kondrashov/akka.net/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alex-kondrashov/akka.net/teams","hooks_url":"https://api.github.com/repos/alex-kondrashov/akka.net/hooks","issue_events_url":"https://api.github.com/repos/alex-kondrashov/akka.net/issues/events{/number}","events_url":"https://api.github.com/repos/alex-kondrashov/akka.net/events","assignees_url":"https://api.github.com/repos/alex-kondrashov/akka.net/assignees{/user}","branches_url":"https://api.github.com/repos/alex-kondrashov/akka.net/branches{/branch}","tags_url":"https://api.github.com/repos/alex-kondrashov/akka.net/tags","blobs_url":"https://api.github.com/repos/alex-kondrashov/akka.net/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alex-kondrashov/akka.net/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alex-kondrashov/akka.net/git/refs{/sha}","trees_url":"https://api.github.com/repos/alex-kondrashov/akka.net/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alex-kondrashov/akka.net/statuses/{sha}","languages_url":"https://api.github.com/repos/alex-kondrashov/akka.net/languages","stargazers_url":"https://api.github.com/repos/alex-kondrashov/akka.net/stargazers","contributors_url":"https://api.github.com/repos/alex-kondrashov/akka.net/contributors","subscribers_url":"https://api.github.com/repos/alex-kondrashov/akka.net/subscribers","subscription_url":"https://api.github.com/repos/alex-kondrashov/akka.net/subscription","commits_url":"https://api.github.com/repos/alex-kondrashov/akka.net/commits{/sha}","git_commits_url":"https://api.github.com/repos/alex-kondrashov/akka.net/git/commits{/sha}","comments_url":"https://api.github.com/repos/alex-kondrashov/akka.net/comments{/number}","issue_comment_url":"https://api.github.com/repos/alex-kondrashov/akka.net/issues/comments{/number}","contents_url":"https://api.github.com/repos/alex-kondrashov/akka.net/contents/{+path}","compare_url":"https://api.github.com/repos/alex-kondrashov/akka.net/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alex-kondrashov/akka.net/merges","archive_url":"https://api.github.com/repos/alex-kondrashov/akka.net/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alex-kondrashov/akka.net/downloads","issues_url":"https://api.github.com/repos/alex-kondrashov/akka.net/issues{/number}","pulls_url":"https://api.github.com/repos/alex-kondrashov/akka.net/pulls{/number}","milestones_url":"https://api.github.com/repos/alex-kondrashov/akka.net/milestones{/number}","notifications_url":"https://api.github.com/repos/alex-kondrashov/akka.net/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alex-kondrashov/akka.net/labels{/name}","releases_url":"https://api.github.com/repos/alex-kondrashov/akka.net/releases{/id}","created_at":"2015-08-31T20:28:11Z","updated_at":"2015-09-26T20:23:20Z","pushed_at":"2016-01-10T01:00:08Z","git_url":"git://github.com/alex-kondrashov/akka.net.git","ssh_url":"git@github.com:alex-kondrashov/akka.net.git","clone_url":"https://github.com/alex-kondrashov/akka.net.git","svn_url":"https://github.com/alex-kondrashov/akka.net","homepage":"http://getakka.net","size":47421,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"akkadotnet:dev","ref":"dev","sha":"e7b9d42ce7e7565cd662253050b772abb81a3919","user":{"login":"akkadotnet","id":7003835,"avatar_url":"https://avatars.githubusercontent.com/u/7003835?v=3","gravatar_id":"","url":"https://api.github.com/users/akkadotnet","html_url":"https://github.com/akkadotnet","followers_url":"https://api.github.com/users/akkadotnet/followers","following_url":"https://api.github.com/users/akkadotnet/following{/other_user}","gists_url":"https://api.github.com/users/akkadotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/akkadotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akkadotnet/subscriptions","organizations_url":"https://api.github.com/users/akkadotnet/orgs","repos_url":"https://api.github.com/users/akkadotnet/repos","events_url":"https://api.github.com/users/akkadotnet/events{/privacy}","received_events_url":"https://api.github.com/users/akkadotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":15509440,"name":"akka.net","full_name":"akkadotnet/akka.net","owner":{"login":"akkadotnet","id":7003835,"avatar_url":"https://avatars.githubusercontent.com/u/7003835?v=3","gravatar_id":"","url":"https://api.github.com/users/akkadotnet","html_url":"https://github.com/akkadotnet","followers_url":"https://api.github.com/users/akkadotnet/followers","following_url":"https://api.github.com/users/akkadotnet/following{/other_user}","gists_url":"https://api.github.com/users/akkadotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/akkadotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akkadotnet/subscriptions","organizations_url":"https://api.github.com/users/akkadotnet/orgs","repos_url":"https://api.github.com/users/akkadotnet/repos","events_url":"https://api.github.com/users/akkadotnet/events{/privacy}","received_events_url":"https://api.github.com/users/akkadotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/akkadotnet/akka.net","description":"Port of Akka actors for .NET","fork":false,"url":"https://api.github.com/repos/akkadotnet/akka.net","forks_url":"https://api.github.com/repos/akkadotnet/akka.net/forks","keys_url":"https://api.github.com/repos/akkadotnet/akka.net/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akkadotnet/akka.net/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akkadotnet/akka.net/teams","hooks_url":"https://api.github.com/repos/akkadotnet/akka.net/hooks","issue_events_url":"https://api.github.com/repos/akkadotnet/akka.net/issues/events{/number}","events_url":"https://api.github.com/repos/akkadotnet/akka.net/events","assignees_url":"https://api.github.com/repos/akkadotnet/akka.net/assignees{/user}","branches_url":"https://api.github.com/repos/akkadotnet/akka.net/branches{/branch}","tags_url":"https://api.github.com/repos/akkadotnet/akka.net/tags","blobs_url":"https://api.github.com/repos/akkadotnet/akka.net/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akkadotnet/akka.net/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akkadotnet/akka.net/git/refs{/sha}","trees_url":"https://api.github.com/repos/akkadotnet/akka.net/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akkadotnet/akka.net/statuses/{sha}","languages_url":"https://api.github.com/repos/akkadotnet/akka.net/languages","stargazers_url":"https://api.github.com/repos/akkadotnet/akka.net/stargazers","contributors_url":"https://api.github.com/repos/akkadotnet/akka.net/contributors","subscribers_url":"https://api.github.com/repos/akkadotnet/akka.net/subscribers","subscription_url":"https://api.github.com/repos/akkadotnet/akka.net/subscription","commits_url":"https://api.github.com/repos/akkadotnet/akka.net/commits{/sha}","git_commits_url":"https://api.github.com/repos/akkadotnet/akka.net/git/commits{/sha}","comments_url":"https://api.github.com/repos/akkadotnet/akka.net/comments{/number}","issue_comment_url":"https://api.github.com/repos/akkadotnet/akka.net/issues/comments{/number}","contents_url":"https://api.github.com/repos/akkadotnet/akka.net/contents/{+path}","compare_url":"https://api.github.com/repos/akkadotnet/akka.net/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akkadotnet/akka.net/merges","archive_url":"https://api.github.com/repos/akkadotnet/akka.net/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akkadotnet/akka.net/downloads","issues_url":"https://api.github.com/repos/akkadotnet/akka.net/issues{/number}","pulls_url":"https://api.github.com/repos/akkadotnet/akka.net/pulls{/number}","milestones_url":"https://api.github.com/repos/akkadotnet/akka.net/milestones{/number}","notifications_url":"https://api.github.com/repos/akkadotnet/akka.net/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akkadotnet/akka.net/labels{/name}","releases_url":"https://api.github.com/repos/akkadotnet/akka.net/releases{/id}","created_at":"2013-12-29T14:17:38Z","updated_at":"2016-01-17T01:05:25Z","pushed_at":"2016-01-16T13:59:47Z","git_url":"git://github.com/akkadotnet/akka.net.git","ssh_url":"git@github.com:akkadotnet/akka.net.git","clone_url":"https://github.com/akkadotnet/akka.net.git","svn_url":"https://github.com/akkadotnet/akka.net","homepage":"http://getakka.net","size":48969,"stargazers_count":1508,"watchers_count":1508,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":381,"mirror_url":null,"open_issues_count":193,"forks":381,"open_issues":193,"watchers":1508,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/akkadotnet/akka.net/pulls/1602"},"html":{"href":"https://github.com/akkadotnet/akka.net/pull/1602"},"issue":{"href":"https://api.github.com/repos/akkadotnet/akka.net/issues/1602"},"comments":{"href":"https://api.github.com/repos/akkadotnet/akka.net/issues/1602/comments"},"review_comments":{"href":"https://api.github.com/repos/akkadotnet/akka.net/pulls/1602/comments"},"review_comment":{"href":"https://api.github.com/repos/akkadotnet/akka.net/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/akkadotnet/akka.net/pulls/1602/commits"},"statuses":{"href":"https://api.github.com/repos/akkadotnet/akka.net/statuses/4075462552ec50428b35dd294bf09ef1c0f04a2a"}}}}