{"push_id":1344013743,"size":15,"distinct_size":15,"ref":"refs/heads/master","head":"9bf0df8f323baa58b5f6010b7a240f1f7e0041fb","before":"aba152a8be0f87387b123e9388472d4367ffb713","commits":[{"sha":"9b8da4eb026c0945671f9304fe3fe8fd8d1ce992","author":{"name":"Jean-Philippe Andre","email":"5d25186dcc75ca42fa89e6c16912b892d281f76f@samsung.com"},"message":"group: Replace group_no_render by object no_render\n\nMost of the smart functions \"Efl.Canvas.Group.group_xxx\" should\nnot exist and be overrides of the base object function instead.\nCleaning this up is necessary if we want an EO API for custom\nsmart objects. This patch is the first attempt at removing a\nmethod (the simplest one).\n\nAs for no_render, I wonder if propagating to the children\nreally is necessary. evas_render should skip them already.","distinct":true,"url":"https://api.github.com/repos/tasn/efl/commits/9b8da4eb026c0945671f9304fe3fe8fd8d1ce992"},{"sha":"fe14ab64f3906009287c5d9213274b49f2f034ba","author":{"name":"Jean-Philippe Andre","email":"5d25186dcc75ca42fa89e6c16912b892d281f76f@samsung.com"},"message":"evas: Small simplification of object color_set","distinct":true,"url":"https://api.github.com/repos/tasn/efl/commits/fe14ab64f3906009287c5d9213274b49f2f034ba"},{"sha":"f06c8b08f3947032238525f500a664676aaba820","author":{"name":"Jean-Philippe Andre","email":"5d25186dcc75ca42fa89e6c16912b892d281f76f@samsung.com"},"message":"evas: Move group color_set after checking for change\n\nI can't see why the group (smart object) color_set function\nwas called even if the color hadn't change. Let's test and\nsee if this breaks anything :)","distinct":true,"url":"https://api.github.com/repos/tasn/efl/commits/f06c8b08f3947032238525f500a664676aaba820"},{"sha":"9e235faf904a079c92513a8a50fa4b0796ca515d","author":{"name":"Jean-Philippe Andre","email":"5d25186dcc75ca42fa89e6c16912b892d281f76f@samsung.com"},"message":"evas_data: Fix safety checks in evas_object_data\n\nThis relies on efl_isa rather than the broken magic check\n(by broken I mean it only checks for NULL).","distinct":true,"url":"https://api.github.com/repos/tasn/efl/commits/9e235faf904a079c92513a8a50fa4b0796ca515d"},{"sha":"af38880451152514ffe72f34026276364472e35d","author":{"name":"Jean-Philippe Andre","email":"5d25186dcc75ca42fa89e6c16912b892d281f76f@samsung.com"},"message":"evas: Move intercept function types to legacy header","distinct":true,"url":"https://api.github.com/repos/tasn/efl/commits/af38880451152514ffe72f34026276364472e35d"},{"sha":"dfc3f9deab7d0a937a04ddc0fc6230dd322f3216","author":{"name":"Jean-Philippe Andre","email":"5d25186dcc75ca42fa89e6c16912b892d281f76f@samsung.com"},"message":"evas: Simplify code with intercept macros","distinct":true,"url":"https://api.github.com/repos/tasn/efl/commits/dfc3f9deab7d0a937a04ddc0fc6230dd322f3216"},{"sha":"39949b022d72c8a867f51ea2cadf04c0e8f1368e","author":{"name":"Jean-Philippe Andre","email":"5d25186dcc75ca42fa89e6c16912b892d281f76f@samsung.com"},"message":"evas: Add pseudo-internal API to intercept basic calls\n\nThis is a poor man's solution to get rid of group functions such\nas clip_set, clip_unset, color_set, etc... See the following\ncommits.\n\nThis API needs to be EAPI for elementary but shouldn't be used\noutside EFL. This is required purely for legacy compatibility.\n\nHere's the call flow, inside show(obj):\n1. if (intercept_show(obj)) return;\n2. show(super(obj));\n3. do other stuff","distinct":true,"url":"https://api.github.com/repos/tasn/efl/commits/39949b022d72c8a867f51ea2cadf04c0e8f1368e"},{"sha":"52969ccd9beec884c330736b15e2776d4faf5154","author":{"name":"Jean-Philippe Andre","email":"5d25186dcc75ca42fa89e6c16912b892d281f76f@samsung.com"},"message":"evas: Remove method group_color_set\n\nWidgets should simply override efl_gfx_color_set and call\nsuper all the way up to evas object.\n\nLegacy compatibility with call interceptors and early call\nabortion (eg. delete_me or obj->layer == NULL) are implemented\nwith an internal call. See the previous commit introducing the\nAPI.","distinct":true,"url":"https://api.github.com/repos/tasn/efl/commits/52969ccd9beec884c330736b15e2776d4faf5154"},{"sha":"c60cc50f5a0cf76a287380eb89df117efc71cca8","author":{"name":"Jean-Philippe Andre","email":"5d25186dcc75ca42fa89e6c16912b892d281f76f@samsung.com"},"message":"evas: Remove inexisting private function declarations","distinct":true,"url":"https://api.github.com/repos/tasn/efl/commits/c60cc50f5a0cf76a287380eb89df117efc71cca8"},{"sha":"62abe2cbff0aa809a474f7a89452256f5371ebc3","author":{"name":"Jean-Philippe Andre","email":"5d25186dcc75ca42fa89e6c16912b892d281f76f@samsung.com"},"message":"evas: Move clip_unset to legacy, remove group_clip\n\nSimilarly to group_color_set, group_clip_[un]set should not\nexist and should be a result of efl_super and inheritance.\n\nThis patch also removes clip_unset from the EO API and keeps\nonly clip_set(NULL). The reason is that it will avoid bad overrides\nof clip_unset() vs. clip_unset(NULL). This also simplifies the code\na bit. Ideally we should be able to reintroduce clip_unset in EO\nif we can have a \"@final\" tag (like java's final keyword), to\nprevent overrides.","distinct":true,"url":"https://api.github.com/repos/tasn/efl/commits/62abe2cbff0aa809a474f7a89452256f5371ebc3"},{"sha":"97c9fa64a461ccf60e63fd8a8982c9b8c5c6290e","author":{"name":"Jean-Philippe Andre","email":"5d25186dcc75ca42fa89e6c16912b892d281f76f@samsung.com"},"message":"evas/elm: Remove group_show and group_hide\n\nThese should be just overrides of Efl.Gfx.visible.set. Many\nwidgets were handling smart show() and hide() manually, which\nmeans this patch is quite large.\n\nHopefully this doesn't break anything, obviously. But here are\nsome widgets known to be problematic, as the old code flow was\nreally strange (sometimes not calling the efl_super function):\n - window\n - notify","distinct":true,"url":"https://api.github.com/repos/tasn/efl/commits/97c9fa64a461ccf60e63fd8a8982c9b8c5c6290e"},{"sha":"a0b8408021fc0dd46e5e4d8425755448d4d28c53","author":{"name":"Jean-Philippe Andre","email":"5d25186dcc75ca42fa89e6c16912b892d281f76f@samsung.com"},"message":"evas: Move move_children_relative to legacy only\n\nWhile this kind of API seems to make sense with smart objects\n(relative coordinates), it is currently not used apart from\nthe smart object class itself.\n\nSo, for now, I'm moving this to legacy to clean up Efl.Canvas.Group\nand we can later add the equivalent in a clean \"group\" API.","distinct":true,"url":"https://api.github.com/repos/tasn/efl/commits/a0b8408021fc0dd46e5e4d8425755448d4d28c53"},{"sha":"11b7cf6b728001dbcd42ce41d5ac2e129a835fd8","author":{"name":"Jean-Philippe Andre","email":"5d25186dcc75ca42fa89e6c16912b892d281f76f@samsung.com"},"message":"evas/elm: Remove function group_move\n\nThis is an override of efl_gfx_position_set.\nAs for the other patches, I hope I didn't break anything.\n\nA problem likely to happen is that the super call was inserted\ntoo early or too late in the call flow. For instance:\n\n  _myclass_position_set(obj, x, y) {\n    position_set(super(obj), x, y);\n    position_get(obj, &prevx, &prevy);\n    do_something_with_delta_xy();\n  }\n\nThe above code flow is obvisouly wrong, but may have crept in this\npatch (such a bug sneaked in inside smart object, breaking\neverything at first).","distinct":true,"url":"https://api.github.com/repos/tasn/efl/commits/11b7cf6b728001dbcd42ce41d5ac2e129a835fd8"},{"sha":"8a9f0bd603aaaf3abd3ca9aa87675c9199fe9d09","author":{"name":"Jean-Philippe Andre","email":"5d25186dcc75ca42fa89e6c16912b892d281f76f@samsung.com"},"message":"evas/elm: Remove function group_resize\n\nThis is an override of efl_gfx_size_set. Same as before, the\norder of operations matter so it is possible that a corner\ncase will break. In particular, legacy code was:\n - intercept\n - smart resize (do stuff), super, super, super\n - evas object resize\n\nThe new code is more like:\n - intercept\n - super, super, super, evas object resize\n - do stuff\n\nBut unfortunately this broke elm_widget (read: all widgets) as\nthe internal resize was done before the object resize. So,\ninside the resize event cb, the resize_obj size would not match\nthe smart object size. >_<","distinct":true,"url":"https://api.github.com/repos/tasn/efl/commits/8a9f0bd603aaaf3abd3ca9aa87675c9199fe9d09"},{"sha":"9bf0df8f323baa58b5f6010b7a240f1f7e0041fb","author":{"name":"Jean-Philippe Andre","email":"5d25186dcc75ca42fa89e6c16912b892d281f76f@samsung.com"},"message":"evas: Mark group_add/del as internal\n\nLacking a proper internal tag, I'm using both protected (it is\nin fact a protected access function) and beta (to mark as unstable,\nnot real API).\n\nNew smart objects based on EO only should rely on constructor,\nfinalize and destructor exclusively. In theory, this should be fine.\n\nUnfortunately it may be impossible to inherit from the Efl.Ui.Win\nclass as it uses a really bad hack and calls super.constructor\ninside the finalize method.","distinct":true,"url":"https://api.github.com/repos/tasn/efl/commits/9bf0df8f323baa58b5f6010b7a240f1f7e0041fb"}]}
{"actor":{"display_login":"tasnbot"}}