{"action":"closed","number":19,"pull_request":{"url":"https://api.github.com/repos/scrogson/romeo/pulls/19","id":85631083,"html_url":"https://github.com/scrogson/romeo/pull/19","diff_url":"https://github.com/scrogson/romeo/pull/19.diff","patch_url":"https://github.com/scrogson/romeo/pull/19.patch","issue_url":"https://api.github.com/repos/scrogson/romeo/issues/19","number":19,"state":"closed","locked":false,"title":"Ignore whitespace keepalive messages","user":{"login":"jbr","id":13301,"avatar_url":"https://avatars.githubusercontent.com/u/13301?v=3","gravatar_id":"","url":"https://api.github.com/users/jbr","html_url":"https://github.com/jbr","followers_url":"https://api.github.com/users/jbr/followers","following_url":"https://api.github.com/users/jbr/following{/other_user}","gists_url":"https://api.github.com/users/jbr/gists{/gist_id}","starred_url":"https://api.github.com/users/jbr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbr/subscriptions","organizations_url":"https://api.github.com/users/jbr/orgs","repos_url":"https://api.github.com/users/jbr/repos","events_url":"https://api.github.com/users/jbr/events{/privacy}","received_events_url":"https://api.github.com/users/jbr/received_events","type":"User","site_admin":false},"body":"As per ~~https://xmpp.org/extensions/xep-0304.html~~ https://tools.ietf.org/html/rfc5626#section-4.4.\r\n\r\nAt some point we might actually want to check their frequency/period against the server-provided keep alive interval and use that information for connection status.  For now, we should not crash if we receive a whitespace message.\r\n\r\nIt's also worth noting that https://github.com/futureflynet/romeo/commit/41726c9924d44d8e04efa0222cae14acf990873d attempts to address the same problem, but that fix does not seem sufficient.","created_at":"2016-09-16T19:59:04Z","updated_at":"2016-09-17T02:14:53Z","closed_at":"2016-09-17T02:14:53Z","merged_at":"2016-09-17T02:14:53Z","merge_commit_sha":"fe92d500a030555ad5ed0b36ac75c6a14f33935e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/scrogson/romeo/pulls/19/commits","review_comments_url":"https://api.github.com/repos/scrogson/romeo/pulls/19/comments","review_comment_url":"https://api.github.com/repos/scrogson/romeo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scrogson/romeo/issues/19/comments","statuses_url":"https://api.github.com/repos/scrogson/romeo/statuses/0990f3ef85fcf7b1b89b8485308ee5067ab32ceb","head":{"label":"jbr:whitespace-keepalive","ref":"whitespace-keepalive","sha":"0990f3ef85fcf7b1b89b8485308ee5067ab32ceb","user":{"login":"jbr","id":13301,"avatar_url":"https://avatars.githubusercontent.com/u/13301?v=3","gravatar_id":"","url":"https://api.github.com/users/jbr","html_url":"https://github.com/jbr","followers_url":"https://api.github.com/users/jbr/followers","following_url":"https://api.github.com/users/jbr/following{/other_user}","gists_url":"https://api.github.com/users/jbr/gists{/gist_id}","starred_url":"https://api.github.com/users/jbr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbr/subscriptions","organizations_url":"https://api.github.com/users/jbr/orgs","repos_url":"https://api.github.com/users/jbr/repos","events_url":"https://api.github.com/users/jbr/events{/privacy}","received_events_url":"https://api.github.com/users/jbr/received_events","type":"User","site_admin":false},"repo":{"id":67638737,"name":"romeo","full_name":"jbr/romeo","owner":{"login":"jbr","id":13301,"avatar_url":"https://avatars.githubusercontent.com/u/13301?v=3","gravatar_id":"","url":"https://api.github.com/users/jbr","html_url":"https://github.com/jbr","followers_url":"https://api.github.com/users/jbr/followers","following_url":"https://api.github.com/users/jbr/following{/other_user}","gists_url":"https://api.github.com/users/jbr/gists{/gist_id}","starred_url":"https://api.github.com/users/jbr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbr/subscriptions","organizations_url":"https://api.github.com/users/jbr/orgs","repos_url":"https://api.github.com/users/jbr/repos","events_url":"https://api.github.com/users/jbr/events{/privacy}","received_events_url":"https://api.github.com/users/jbr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jbr/romeo","description":"An XMPP Client for Elixir","fork":true,"url":"https://api.github.com/repos/jbr/romeo","forks_url":"https://api.github.com/repos/jbr/romeo/forks","keys_url":"https://api.github.com/repos/jbr/romeo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jbr/romeo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jbr/romeo/teams","hooks_url":"https://api.github.com/repos/jbr/romeo/hooks","issue_events_url":"https://api.github.com/repos/jbr/romeo/issues/events{/number}","events_url":"https://api.github.com/repos/jbr/romeo/events","assignees_url":"https://api.github.com/repos/jbr/romeo/assignees{/user}","branches_url":"https://api.github.com/repos/jbr/romeo/branches{/branch}","tags_url":"https://api.github.com/repos/jbr/romeo/tags","blobs_url":"https://api.github.com/repos/jbr/romeo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jbr/romeo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jbr/romeo/git/refs{/sha}","trees_url":"https://api.github.com/repos/jbr/romeo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jbr/romeo/statuses/{sha}","languages_url":"https://api.github.com/repos/jbr/romeo/languages","stargazers_url":"https://api.github.com/repos/jbr/romeo/stargazers","contributors_url":"https://api.github.com/repos/jbr/romeo/contributors","subscribers_url":"https://api.github.com/repos/jbr/romeo/subscribers","subscription_url":"https://api.github.com/repos/jbr/romeo/subscription","commits_url":"https://api.github.com/repos/jbr/romeo/commits{/sha}","git_commits_url":"https://api.github.com/repos/jbr/romeo/git/commits{/sha}","comments_url":"https://api.github.com/repos/jbr/romeo/comments{/number}","issue_comment_url":"https://api.github.com/repos/jbr/romeo/issues/comments{/number}","contents_url":"https://api.github.com/repos/jbr/romeo/contents/{+path}","compare_url":"https://api.github.com/repos/jbr/romeo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jbr/romeo/merges","archive_url":"https://api.github.com/repos/jbr/romeo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jbr/romeo/downloads","issues_url":"https://api.github.com/repos/jbr/romeo/issues{/number}","pulls_url":"https://api.github.com/repos/jbr/romeo/pulls{/number}","milestones_url":"https://api.github.com/repos/jbr/romeo/milestones{/number}","notifications_url":"https://api.github.com/repos/jbr/romeo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jbr/romeo/labels{/name}","releases_url":"https://api.github.com/repos/jbr/romeo/releases{/id}","deployments_url":"https://api.github.com/repos/jbr/romeo/deployments","created_at":"2016-09-07T19:53:56Z","updated_at":"2016-09-07T19:53:57Z","pushed_at":"2016-09-17T00:13:41Z","git_url":"git://github.com/jbr/romeo.git","ssh_url":"git@github.com:jbr/romeo.git","clone_url":"https://github.com/jbr/romeo.git","svn_url":"https://github.com/jbr/romeo","homepage":"","size":107,"stargazers_count":0,"watchers_count":0,"language":"Elixir","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"scrogson:master","ref":"master","sha":"64e7d373321bb1cf025079700820fc7a6a8a2f1f","user":{"login":"scrogson","id":53274,"avatar_url":"https://avatars.githubusercontent.com/u/53274?v=3","gravatar_id":"","url":"https://api.github.com/users/scrogson","html_url":"https://github.com/scrogson","followers_url":"https://api.github.com/users/scrogson/followers","following_url":"https://api.github.com/users/scrogson/following{/other_user}","gists_url":"https://api.github.com/users/scrogson/gists{/gist_id}","starred_url":"https://api.github.com/users/scrogson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scrogson/subscriptions","organizations_url":"https://api.github.com/users/scrogson/orgs","repos_url":"https://api.github.com/users/scrogson/repos","events_url":"https://api.github.com/users/scrogson/events{/privacy}","received_events_url":"https://api.github.com/users/scrogson/received_events","type":"User","site_admin":false},"repo":{"id":46234958,"name":"romeo","full_name":"scrogson/romeo","owner":{"login":"scrogson","id":53274,"avatar_url":"https://avatars.githubusercontent.com/u/53274?v=3","gravatar_id":"","url":"https://api.github.com/users/scrogson","html_url":"https://github.com/scrogson","followers_url":"https://api.github.com/users/scrogson/followers","following_url":"https://api.github.com/users/scrogson/following{/other_user}","gists_url":"https://api.github.com/users/scrogson/gists{/gist_id}","starred_url":"https://api.github.com/users/scrogson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scrogson/subscriptions","organizations_url":"https://api.github.com/users/scrogson/orgs","repos_url":"https://api.github.com/users/scrogson/repos","events_url":"https://api.github.com/users/scrogson/events{/privacy}","received_events_url":"https://api.github.com/users/scrogson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/scrogson/romeo","description":"An XMPP Client for Elixir","fork":false,"url":"https://api.github.com/repos/scrogson/romeo","forks_url":"https://api.github.com/repos/scrogson/romeo/forks","keys_url":"https://api.github.com/repos/scrogson/romeo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scrogson/romeo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scrogson/romeo/teams","hooks_url":"https://api.github.com/repos/scrogson/romeo/hooks","issue_events_url":"https://api.github.com/repos/scrogson/romeo/issues/events{/number}","events_url":"https://api.github.com/repos/scrogson/romeo/events","assignees_url":"https://api.github.com/repos/scrogson/romeo/assignees{/user}","branches_url":"https://api.github.com/repos/scrogson/romeo/branches{/branch}","tags_url":"https://api.github.com/repos/scrogson/romeo/tags","blobs_url":"https://api.github.com/repos/scrogson/romeo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scrogson/romeo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scrogson/romeo/git/refs{/sha}","trees_url":"https://api.github.com/repos/scrogson/romeo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scrogson/romeo/statuses/{sha}","languages_url":"https://api.github.com/repos/scrogson/romeo/languages","stargazers_url":"https://api.github.com/repos/scrogson/romeo/stargazers","contributors_url":"https://api.github.com/repos/scrogson/romeo/contributors","subscribers_url":"https://api.github.com/repos/scrogson/romeo/subscribers","subscription_url":"https://api.github.com/repos/scrogson/romeo/subscription","commits_url":"https://api.github.com/repos/scrogson/romeo/commits{/sha}","git_commits_url":"https://api.github.com/repos/scrogson/romeo/git/commits{/sha}","comments_url":"https://api.github.com/repos/scrogson/romeo/comments{/number}","issue_comment_url":"https://api.github.com/repos/scrogson/romeo/issues/comments{/number}","contents_url":"https://api.github.com/repos/scrogson/romeo/contents/{+path}","compare_url":"https://api.github.com/repos/scrogson/romeo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scrogson/romeo/merges","archive_url":"https://api.github.com/repos/scrogson/romeo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scrogson/romeo/downloads","issues_url":"https://api.github.com/repos/scrogson/romeo/issues{/number}","pulls_url":"https://api.github.com/repos/scrogson/romeo/pulls{/number}","milestones_url":"https://api.github.com/repos/scrogson/romeo/milestones{/number}","notifications_url":"https://api.github.com/repos/scrogson/romeo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scrogson/romeo/labels{/name}","releases_url":"https://api.github.com/repos/scrogson/romeo/releases{/id}","deployments_url":"https://api.github.com/repos/scrogson/romeo/deployments","created_at":"2015-11-15T20:42:26Z","updated_at":"2016-09-13T23:53:34Z","pushed_at":"2016-09-17T02:14:53Z","git_url":"git://github.com/scrogson/romeo.git","ssh_url":"git@github.com:scrogson/romeo.git","clone_url":"https://github.com/scrogson/romeo.git","svn_url":"https://github.com/scrogson/romeo","homepage":"","size":115,"stargazers_count":23,"watchers_count":23,"language":"Elixir","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":3,"forks":11,"open_issues":3,"watchers":23,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scrogson/romeo/pulls/19"},"html":{"href":"https://github.com/scrogson/romeo/pull/19"},"issue":{"href":"https://api.github.com/repos/scrogson/romeo/issues/19"},"comments":{"href":"https://api.github.com/repos/scrogson/romeo/issues/19/comments"},"review_comments":{"href":"https://api.github.com/repos/scrogson/romeo/pulls/19/comments"},"review_comment":{"href":"https://api.github.com/repos/scrogson/romeo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scrogson/romeo/pulls/19/commits"},"statuses":{"href":"https://api.github.com/repos/scrogson/romeo/statuses/0990f3ef85fcf7b1b89b8485308ee5067ab32ceb"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"scrogson","id":53274,"avatar_url":"https://avatars.githubusercontent.com/u/53274?v=3","gravatar_id":"","url":"https://api.github.com/users/scrogson","html_url":"https://github.com/scrogson","followers_url":"https://api.github.com/users/scrogson/followers","following_url":"https://api.github.com/users/scrogson/following{/other_user}","gists_url":"https://api.github.com/users/scrogson/gists{/gist_id}","starred_url":"https://api.github.com/users/scrogson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scrogson/subscriptions","organizations_url":"https://api.github.com/users/scrogson/orgs","repos_url":"https://api.github.com/users/scrogson/repos","events_url":"https://api.github.com/users/scrogson/events{/privacy}","received_events_url":"https://api.github.com/users/scrogson/received_events","type":"User","site_admin":false},"comments":5,"review_comments":0,"commits":3,"additions":20,"deletions":6,"changed_files":1}}
{"actor":{"display_login":"scrogson"}}