{"action":"created","comment":{"url":"https://api.github.com/repos/arvidn/libtorrent/pulls/comments/76169279","id":76169279,"diff_hunk":"@@ -222,8 +231,8 @@ int sha512_update (sha512_context * md, const unsigned char *in, size_t inlen)\n    @param out [out] The destination of the hash (64 bytes)\n    @return 0 if successful\n */\n-   int sha512_final(sha512_context * md, unsigned char *out)\n-   {\n+int SHA512_final(std::uint8_t* out, sha512_ctx* md)","path":"src/sha512.cpp","position":62,"original_position":62,"commit_id":"c5e056272c9229efbd7063a429db0440b9c22f46","original_commit_id":"c5e056272c9229efbd7063a429db0440b9c22f46","user":{"login":"arvidn","id":661450,"avatar_url":"https://avatars.githubusercontent.com/u/661450?v=3","gravatar_id":"","url":"https://api.github.com/users/arvidn","html_url":"https://github.com/arvidn","followers_url":"https://api.github.com/users/arvidn/followers","following_url":"https://api.github.com/users/arvidn/following{/other_user}","gists_url":"https://api.github.com/users/arvidn/gists{/gist_id}","starred_url":"https://api.github.com/users/arvidn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arvidn/subscriptions","organizations_url":"https://api.github.com/users/arvidn/orgs","repos_url":"https://api.github.com/users/arvidn/repos","events_url":"https://api.github.com/users/arvidn/events{/privacy}","received_events_url":"https://api.github.com/users/arvidn/received_events","type":"User","site_admin":false},"body":"I suppose it keeps things simple for now, to leave these functions like this","created_at":"2016-08-25T01:47:40Z","updated_at":"2016-08-25T01:47:40Z","html_url":"https://github.com/arvidn/libtorrent/pull/1028#discussion_r76169279","pull_request_url":"https://api.github.com/repos/arvidn/libtorrent/pulls/1028","_links":{"self":{"href":"https://api.github.com/repos/arvidn/libtorrent/pulls/comments/76169279"},"html":{"href":"https://github.com/arvidn/libtorrent/pull/1028#discussion_r76169279"},"pull_request":{"href":"https://api.github.com/repos/arvidn/libtorrent/pulls/1028"}}},"pull_request":{"url":"https://api.github.com/repos/arvidn/libtorrent/pulls/1028","id":82267021,"html_url":"https://github.com/arvidn/libtorrent/pull/1028","diff_url":"https://github.com/arvidn/libtorrent/pull/1028.diff","patch_url":"https://github.com/arvidn/libtorrent/pull/1028.patch","issue_url":"https://api.github.com/repos/arvidn/libtorrent/issues/1028","number":1028,"state":"open","locked":false,"title":"adding support for a more configurable sha512 hasher","user":{"login":"aldenml","id":143813,"avatar_url":"https://avatars.githubusercontent.com/u/143813?v=3","gravatar_id":"","url":"https://api.github.com/users/aldenml","html_url":"https://github.com/aldenml","followers_url":"https://api.github.com/users/aldenml/followers","following_url":"https://api.github.com/users/aldenml/following{/other_user}","gists_url":"https://api.github.com/users/aldenml/gists{/gist_id}","starred_url":"https://api.github.com/users/aldenml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aldenml/subscriptions","organizations_url":"https://api.github.com/users/aldenml/orgs","repos_url":"https://api.github.com/users/aldenml/repos","events_url":"https://api.github.com/users/aldenml/events{/privacy}","received_events_url":"https://api.github.com/users/aldenml/received_events","type":"User","site_admin":false},"body":"This PR only adds a `hasher512` that it's very similar to the sha1 based `hasher`. For now, it helps only to test the correctness of the current sha512 implementation used in `ed25519`, since the file `sha512.cpp` is a copy from that.\r\n\r\nIf this PR is merged, the natural next step is remove the old sha512 inside `ed25519` to use the new `hasher512` which takes advantage of third party libraries if configured.\r\n\r\nThe ultimate goal is bring up to date the `ed25519` with the latest `ref10` implementation, with unit tests that easy the path for future upgrades.","created_at":"2016-08-22T21:30:59Z","updated_at":"2016-08-25T01:47:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"719f6c3f4ac6a0e56cce51e5e1e053c1e09fb4e0","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/arvidn/libtorrent/pulls/1028/commits","review_comments_url":"https://api.github.com/repos/arvidn/libtorrent/pulls/1028/comments","review_comment_url":"https://api.github.com/repos/arvidn/libtorrent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/arvidn/libtorrent/issues/1028/comments","statuses_url":"https://api.github.com/repos/arvidn/libtorrent/statuses/c5e056272c9229efbd7063a429db0440b9c22f46","head":{"label":"aldenml:sha512-1.2","ref":"sha512-1.2","sha":"c5e056272c9229efbd7063a429db0440b9c22f46","user":{"login":"aldenml","id":143813,"avatar_url":"https://avatars.githubusercontent.com/u/143813?v=3","gravatar_id":"","url":"https://api.github.com/users/aldenml","html_url":"https://github.com/aldenml","followers_url":"https://api.github.com/users/aldenml/followers","following_url":"https://api.github.com/users/aldenml/following{/other_user}","gists_url":"https://api.github.com/users/aldenml/gists{/gist_id}","starred_url":"https://api.github.com/users/aldenml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aldenml/subscriptions","organizations_url":"https://api.github.com/users/aldenml/orgs","repos_url":"https://api.github.com/users/aldenml/repos","events_url":"https://api.github.com/users/aldenml/events{/privacy}","received_events_url":"https://api.github.com/users/aldenml/received_events","type":"User","site_admin":false},"repo":{"id":37677407,"name":"libtorrent","full_name":"aldenml/libtorrent","owner":{"login":"aldenml","id":143813,"avatar_url":"https://avatars.githubusercontent.com/u/143813?v=3","gravatar_id":"","url":"https://api.github.com/users/aldenml","html_url":"https://github.com/aldenml","followers_url":"https://api.github.com/users/aldenml/followers","following_url":"https://api.github.com/users/aldenml/following{/other_user}","gists_url":"https://api.github.com/users/aldenml/gists{/gist_id}","starred_url":"https://api.github.com/users/aldenml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aldenml/subscriptions","organizations_url":"https://api.github.com/users/aldenml/orgs","repos_url":"https://api.github.com/users/aldenml/repos","events_url":"https://api.github.com/users/aldenml/events{/privacy}","received_events_url":"https://api.github.com/users/aldenml/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aldenml/libtorrent","description":"an efficient feature complete C++ bittorrent implementation","fork":true,"url":"https://api.github.com/repos/aldenml/libtorrent","forks_url":"https://api.github.com/repos/aldenml/libtorrent/forks","keys_url":"https://api.github.com/repos/aldenml/libtorrent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aldenml/libtorrent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aldenml/libtorrent/teams","hooks_url":"https://api.github.com/repos/aldenml/libtorrent/hooks","issue_events_url":"https://api.github.com/repos/aldenml/libtorrent/issues/events{/number}","events_url":"https://api.github.com/repos/aldenml/libtorrent/events","assignees_url":"https://api.github.com/repos/aldenml/libtorrent/assignees{/user}","branches_url":"https://api.github.com/repos/aldenml/libtorrent/branches{/branch}","tags_url":"https://api.github.com/repos/aldenml/libtorrent/tags","blobs_url":"https://api.github.com/repos/aldenml/libtorrent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aldenml/libtorrent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aldenml/libtorrent/git/refs{/sha}","trees_url":"https://api.github.com/repos/aldenml/libtorrent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aldenml/libtorrent/statuses/{sha}","languages_url":"https://api.github.com/repos/aldenml/libtorrent/languages","stargazers_url":"https://api.github.com/repos/aldenml/libtorrent/stargazers","contributors_url":"https://api.github.com/repos/aldenml/libtorrent/contributors","subscribers_url":"https://api.github.com/repos/aldenml/libtorrent/subscribers","subscription_url":"https://api.github.com/repos/aldenml/libtorrent/subscription","commits_url":"https://api.github.com/repos/aldenml/libtorrent/commits{/sha}","git_commits_url":"https://api.github.com/repos/aldenml/libtorrent/git/commits{/sha}","comments_url":"https://api.github.com/repos/aldenml/libtorrent/comments{/number}","issue_comment_url":"https://api.github.com/repos/aldenml/libtorrent/issues/comments{/number}","contents_url":"https://api.github.com/repos/aldenml/libtorrent/contents/{+path}","compare_url":"https://api.github.com/repos/aldenml/libtorrent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aldenml/libtorrent/merges","archive_url":"https://api.github.com/repos/aldenml/libtorrent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aldenml/libtorrent/downloads","issues_url":"https://api.github.com/repos/aldenml/libtorrent/issues{/number}","pulls_url":"https://api.github.com/repos/aldenml/libtorrent/pulls{/number}","milestones_url":"https://api.github.com/repos/aldenml/libtorrent/milestones{/number}","notifications_url":"https://api.github.com/repos/aldenml/libtorrent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aldenml/libtorrent/labels{/name}","releases_url":"https://api.github.com/repos/aldenml/libtorrent/releases{/id}","deployments_url":"https://api.github.com/repos/aldenml/libtorrent/deployments","created_at":"2015-06-18T18:31:58Z","updated_at":"2016-01-11T13:58:25Z","pushed_at":"2016-08-24T15:18:28Z","git_url":"git://github.com/aldenml/libtorrent.git","ssh_url":"git@github.com:aldenml/libtorrent.git","clone_url":"https://github.com/aldenml/libtorrent.git","svn_url":"https://github.com/aldenml/libtorrent","homepage":"http://libtorrent.org","size":41352,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"arvidn:master","ref":"master","sha":"73d6ba6ae31cffd3882c41a09f8b9a854d07eb4f","user":{"login":"arvidn","id":661450,"avatar_url":"https://avatars.githubusercontent.com/u/661450?v=3","gravatar_id":"","url":"https://api.github.com/users/arvidn","html_url":"https://github.com/arvidn","followers_url":"https://api.github.com/users/arvidn/followers","following_url":"https://api.github.com/users/arvidn/following{/other_user}","gists_url":"https://api.github.com/users/arvidn/gists{/gist_id}","starred_url":"https://api.github.com/users/arvidn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arvidn/subscriptions","organizations_url":"https://api.github.com/users/arvidn/orgs","repos_url":"https://api.github.com/users/arvidn/repos","events_url":"https://api.github.com/users/arvidn/events{/privacy}","received_events_url":"https://api.github.com/users/arvidn/received_events","type":"User","site_admin":false},"repo":{"id":36781769,"name":"libtorrent","full_name":"arvidn/libtorrent","owner":{"login":"arvidn","id":661450,"avatar_url":"https://avatars.githubusercontent.com/u/661450?v=3","gravatar_id":"","url":"https://api.github.com/users/arvidn","html_url":"https://github.com/arvidn","followers_url":"https://api.github.com/users/arvidn/followers","following_url":"https://api.github.com/users/arvidn/following{/other_user}","gists_url":"https://api.github.com/users/arvidn/gists{/gist_id}","starred_url":"https://api.github.com/users/arvidn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arvidn/subscriptions","organizations_url":"https://api.github.com/users/arvidn/orgs","repos_url":"https://api.github.com/users/arvidn/repos","events_url":"https://api.github.com/users/arvidn/events{/privacy}","received_events_url":"https://api.github.com/users/arvidn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/arvidn/libtorrent","description":"an efficient feature complete C++ bittorrent implementation","fork":false,"url":"https://api.github.com/repos/arvidn/libtorrent","forks_url":"https://api.github.com/repos/arvidn/libtorrent/forks","keys_url":"https://api.github.com/repos/arvidn/libtorrent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arvidn/libtorrent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arvidn/libtorrent/teams","hooks_url":"https://api.github.com/repos/arvidn/libtorrent/hooks","issue_events_url":"https://api.github.com/repos/arvidn/libtorrent/issues/events{/number}","events_url":"https://api.github.com/repos/arvidn/libtorrent/events","assignees_url":"https://api.github.com/repos/arvidn/libtorrent/assignees{/user}","branches_url":"https://api.github.com/repos/arvidn/libtorrent/branches{/branch}","tags_url":"https://api.github.com/repos/arvidn/libtorrent/tags","blobs_url":"https://api.github.com/repos/arvidn/libtorrent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arvidn/libtorrent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arvidn/libtorrent/git/refs{/sha}","trees_url":"https://api.github.com/repos/arvidn/libtorrent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arvidn/libtorrent/statuses/{sha}","languages_url":"https://api.github.com/repos/arvidn/libtorrent/languages","stargazers_url":"https://api.github.com/repos/arvidn/libtorrent/stargazers","contributors_url":"https://api.github.com/repos/arvidn/libtorrent/contributors","subscribers_url":"https://api.github.com/repos/arvidn/libtorrent/subscribers","subscription_url":"https://api.github.com/repos/arvidn/libtorrent/subscription","commits_url":"https://api.github.com/repos/arvidn/libtorrent/commits{/sha}","git_commits_url":"https://api.github.com/repos/arvidn/libtorrent/git/commits{/sha}","comments_url":"https://api.github.com/repos/arvidn/libtorrent/comments{/number}","issue_comment_url":"https://api.github.com/repos/arvidn/libtorrent/issues/comments{/number}","contents_url":"https://api.github.com/repos/arvidn/libtorrent/contents/{+path}","compare_url":"https://api.github.com/repos/arvidn/libtorrent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arvidn/libtorrent/merges","archive_url":"https://api.github.com/repos/arvidn/libtorrent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arvidn/libtorrent/downloads","issues_url":"https://api.github.com/repos/arvidn/libtorrent/issues{/number}","pulls_url":"https://api.github.com/repos/arvidn/libtorrent/pulls{/number}","milestones_url":"https://api.github.com/repos/arvidn/libtorrent/milestones{/number}","notifications_url":"https://api.github.com/repos/arvidn/libtorrent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arvidn/libtorrent/labels{/name}","releases_url":"https://api.github.com/repos/arvidn/libtorrent/releases{/id}","deployments_url":"https://api.github.com/repos/arvidn/libtorrent/deployments","created_at":"2015-06-03T05:22:03Z","updated_at":"2016-08-24T06:04:06Z","pushed_at":"2016-08-24T06:40:18Z","git_url":"git://github.com/arvidn/libtorrent.git","ssh_url":"git@github.com:arvidn/libtorrent.git","clone_url":"https://github.com/arvidn/libtorrent.git","svn_url":"https://github.com/arvidn/libtorrent","homepage":"http://libtorrent.org","size":72994,"stargazers_count":503,"watchers_count":503,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":154,"mirror_url":null,"open_issues_count":69,"forks":154,"open_issues":69,"watchers":503,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/arvidn/libtorrent/pulls/1028"},"html":{"href":"https://github.com/arvidn/libtorrent/pull/1028"},"issue":{"href":"https://api.github.com/repos/arvidn/libtorrent/issues/1028"},"comments":{"href":"https://api.github.com/repos/arvidn/libtorrent/issues/1028/comments"},"review_comments":{"href":"https://api.github.com/repos/arvidn/libtorrent/pulls/1028/comments"},"review_comment":{"href":"https://api.github.com/repos/arvidn/libtorrent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/arvidn/libtorrent/pulls/1028/commits"},"statuses":{"href":"https://api.github.com/repos/arvidn/libtorrent/statuses/c5e056272c9229efbd7063a429db0440b9c22f46"}}}}
{"actor":{"display_login":"arvidn"}}