{"action":"created","comment":{"url":"https://api.github.com/repos/moonlight-stream/moonlight-chrome/pulls/comments/59584177","id":59584177,"diff_hunk":"@@ -0,0 +1,28 @@\n+{\n+  \"name\": \"moonlight-chrome\",\n+  \"version\": \"1.0.0\",\n+  \"description\": \"Chrome extension for Moonlight, the open source Nvidia Stream app\",\n+  \"main\": \"index.js\",\n+  \"scripts\": {\n+    \"test\": \"echo \\\"Error: no test specified\\\" && exit 1\"\n+  },\n+  \"repository\": {\n+    \"type\": \"git\",\n+    \"url\": \"git+https://github.com/moonlight-stream/moonlight-chrome.git\"\n+  },\n+  \"keywords\": [\n+    \"moonlight\",\n+    \"chrome\",\n+    \"nvidia\"","path":"package.json","position":16,"original_position":16,"commit_id":"0a77a03cea70f37d5cd1df05475265bdd16ca911","original_commit_id":"0a77a03cea70f37d5cd1df05475265bdd16ca911","user":{"login":"cgutman","id":2695644,"avatar_url":"https://avatars.githubusercontent.com/u/2695644?v=3","gravatar_id":"","url":"https://api.github.com/users/cgutman","html_url":"https://github.com/cgutman","followers_url":"https://api.github.com/users/cgutman/followers","following_url":"https://api.github.com/users/cgutman/following{/other_user}","gists_url":"https://api.github.com/users/cgutman/gists{/gist_id}","starred_url":"https://api.github.com/users/cgutman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgutman/subscriptions","organizations_url":"https://api.github.com/users/cgutman/orgs","repos_url":"https://api.github.com/users/cgutman/repos","events_url":"https://api.github.com/users/cgutman/events{/privacy}","received_events_url":"https://api.github.com/users/cgutman/received_events","type":"User","site_admin":false},"body":"Change to \"gamestream\"","created_at":"2016-04-13T16:54:24Z","updated_at":"2016-04-13T16:54:24Z","html_url":"https://github.com/moonlight-stream/moonlight-chrome/pull/36#discussion_r59584177","pull_request_url":"https://api.github.com/repos/moonlight-stream/moonlight-chrome/pulls/36","_links":{"self":{"href":"https://api.github.com/repos/moonlight-stream/moonlight-chrome/pulls/comments/59584177"},"html":{"href":"https://github.com/moonlight-stream/moonlight-chrome/pull/36#discussion_r59584177"},"pull_request":{"href":"https://api.github.com/repos/moonlight-stream/moonlight-chrome/pulls/36"}}},"pull_request":{"url":"https://api.github.com/repos/moonlight-stream/moonlight-chrome/pulls/36","id":66252297,"html_url":"https://github.com/moonlight-stream/moonlight-chrome/pull/36","diff_url":"https://github.com/moonlight-stream/moonlight-chrome/pull/36.diff","patch_url":"https://github.com/moonlight-stream/moonlight-chrome/pull/36.patch","issue_url":"https://api.github.com/repos/moonlight-stream/moonlight-chrome/issues/36","number":36,"state":"open","locked":false,"title":"Cleaned up CSS, Brought in NPM, Removed static css js files","user":{"login":"Aghassi","id":3680126,"avatar_url":"https://avatars.githubusercontent.com/u/3680126?v=3","gravatar_id":"","url":"https://api.github.com/users/Aghassi","html_url":"https://github.com/Aghassi","followers_url":"https://api.github.com/users/Aghassi/followers","following_url":"https://api.github.com/users/Aghassi/following{/other_user}","gists_url":"https://api.github.com/users/Aghassi/gists{/gist_id}","starred_url":"https://api.github.com/users/Aghassi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Aghassi/subscriptions","organizations_url":"https://api.github.com/users/Aghassi/orgs","repos_url":"https://api.github.com/users/Aghassi/repos","events_url":"https://api.github.com/users/Aghassi/events{/privacy}","received_events_url":"https://api.github.com/users/Aghassi/received_events","type":"User","site_admin":false},"body":"I'm submitting this because I would like a code review on what I have been doing. I spent the last few hours cleaning up the CSS to comply with CSSLint (which I will probably implement in the future using Gulp or Grunt). I have also:\r\n\r\n* Removed the use of `!important` because it is not good practice. It forces cascading to break and defeats the purpose of the stylesheet. It can also lead to problems that are hard to debug. I did this in as many places as possible.\r\n* Removed use of `#` in CSS and instead made classes for the IDs to find the items (good practice to have a class for everything).\r\n* Updated `manifest.json` to support the `node_modules` directory\r\n* Created `packages.json` for `npm` so we can have dependency management for our JS/CSS\r\n* Updated `README` to add `npm install` step\r\n\r\nThe one visible change I have had with these changes is the color seems to have changed, but I am not worried about that because the functionality is still the same (though the game stream client sometimes freaks out, not sure if that was my doing). More to come as I work through things. Looking for any feedback on what I have right now. I won't push anymore until this is merged or hashed out.","created_at":"2016-04-13T01:07:48Z","updated_at":"2016-04-13T16:54:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a9297c43a31d518f3b3f9d2188ce390530b75b16","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/moonlight-stream/moonlight-chrome/pulls/36/commits","review_comments_url":"https://api.github.com/repos/moonlight-stream/moonlight-chrome/pulls/36/comments","review_comment_url":"https://api.github.com/repos/moonlight-stream/moonlight-chrome/pulls/comments{/number}","comments_url":"https://api.github.com/repos/moonlight-stream/moonlight-chrome/issues/36/comments","statuses_url":"https://api.github.com/repos/moonlight-stream/moonlight-chrome/statuses/0a77a03cea70f37d5cd1df05475265bdd16ca911","head":{"label":"Aghassi:clean-up","ref":"clean-up","sha":"0a77a03cea70f37d5cd1df05475265bdd16ca911","user":{"login":"Aghassi","id":3680126,"avatar_url":"https://avatars.githubusercontent.com/u/3680126?v=3","gravatar_id":"","url":"https://api.github.com/users/Aghassi","html_url":"https://github.com/Aghassi","followers_url":"https://api.github.com/users/Aghassi/followers","following_url":"https://api.github.com/users/Aghassi/following{/other_user}","gists_url":"https://api.github.com/users/Aghassi/gists{/gist_id}","starred_url":"https://api.github.com/users/Aghassi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Aghassi/subscriptions","organizations_url":"https://api.github.com/users/Aghassi/orgs","repos_url":"https://api.github.com/users/Aghassi/repos","events_url":"https://api.github.com/users/Aghassi/events{/privacy}","received_events_url":"https://api.github.com/users/Aghassi/received_events","type":"User","site_admin":false},"repo":{"id":56094998,"name":"moonlight-chrome","full_name":"Aghassi/moonlight-chrome","owner":{"login":"Aghassi","id":3680126,"avatar_url":"https://avatars.githubusercontent.com/u/3680126?v=3","gravatar_id":"","url":"https://api.github.com/users/Aghassi","html_url":"https://github.com/Aghassi","followers_url":"https://api.github.com/users/Aghassi/followers","following_url":"https://api.github.com/users/Aghassi/following{/other_user}","gists_url":"https://api.github.com/users/Aghassi/gists{/gist_id}","starred_url":"https://api.github.com/users/Aghassi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Aghassi/subscriptions","organizations_url":"https://api.github.com/users/Aghassi/orgs","repos_url":"https://api.github.com/users/Aghassi/repos","events_url":"https://api.github.com/users/Aghassi/events{/privacy}","received_events_url":"https://api.github.com/users/Aghassi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Aghassi/moonlight-chrome","description":"GameStream client for Chrome","fork":true,"url":"https://api.github.com/repos/Aghassi/moonlight-chrome","forks_url":"https://api.github.com/repos/Aghassi/moonlight-chrome/forks","keys_url":"https://api.github.com/repos/Aghassi/moonlight-chrome/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Aghassi/moonlight-chrome/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Aghassi/moonlight-chrome/teams","hooks_url":"https://api.github.com/repos/Aghassi/moonlight-chrome/hooks","issue_events_url":"https://api.github.com/repos/Aghassi/moonlight-chrome/issues/events{/number}","events_url":"https://api.github.com/repos/Aghassi/moonlight-chrome/events","assignees_url":"https://api.github.com/repos/Aghassi/moonlight-chrome/assignees{/user}","branches_url":"https://api.github.com/repos/Aghassi/moonlight-chrome/branches{/branch}","tags_url":"https://api.github.com/repos/Aghassi/moonlight-chrome/tags","blobs_url":"https://api.github.com/repos/Aghassi/moonlight-chrome/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Aghassi/moonlight-chrome/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Aghassi/moonlight-chrome/git/refs{/sha}","trees_url":"https://api.github.com/repos/Aghassi/moonlight-chrome/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Aghassi/moonlight-chrome/statuses/{sha}","languages_url":"https://api.github.com/repos/Aghassi/moonlight-chrome/languages","stargazers_url":"https://api.github.com/repos/Aghassi/moonlight-chrome/stargazers","contributors_url":"https://api.github.com/repos/Aghassi/moonlight-chrome/contributors","subscribers_url":"https://api.github.com/repos/Aghassi/moonlight-chrome/subscribers","subscription_url":"https://api.github.com/repos/Aghassi/moonlight-chrome/subscription","commits_url":"https://api.github.com/repos/Aghassi/moonlight-chrome/commits{/sha}","git_commits_url":"https://api.github.com/repos/Aghassi/moonlight-chrome/git/commits{/sha}","comments_url":"https://api.github.com/repos/Aghassi/moonlight-chrome/comments{/number}","issue_comment_url":"https://api.github.com/repos/Aghassi/moonlight-chrome/issues/comments{/number}","contents_url":"https://api.github.com/repos/Aghassi/moonlight-chrome/contents/{+path}","compare_url":"https://api.github.com/repos/Aghassi/moonlight-chrome/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Aghassi/moonlight-chrome/merges","archive_url":"https://api.github.com/repos/Aghassi/moonlight-chrome/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Aghassi/moonlight-chrome/downloads","issues_url":"https://api.github.com/repos/Aghassi/moonlight-chrome/issues{/number}","pulls_url":"https://api.github.com/repos/Aghassi/moonlight-chrome/pulls{/number}","milestones_url":"https://api.github.com/repos/Aghassi/moonlight-chrome/milestones{/number}","notifications_url":"https://api.github.com/repos/Aghassi/moonlight-chrome/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Aghassi/moonlight-chrome/labels{/name}","releases_url":"https://api.github.com/repos/Aghassi/moonlight-chrome/releases{/id}","deployments_url":"https://api.github.com/repos/Aghassi/moonlight-chrome/deployments","created_at":"2016-04-12T20:21:02Z","updated_at":"2016-04-12T20:21:05Z","pushed_at":"2016-04-13T01:07:29Z","git_url":"git://github.com/Aghassi/moonlight-chrome.git","ssh_url":"git@github.com:Aghassi/moonlight-chrome.git","clone_url":"https://github.com/Aghassi/moonlight-chrome.git","svn_url":"https://github.com/Aghassi/moonlight-chrome","homepage":"","size":6168,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"moonlight-stream:master","ref":"master","sha":"5da04bbb8ae9143e8dc700d3c701f7bcb967c7dc","user":{"login":"moonlight-stream","id":6118379,"avatar_url":"https://avatars.githubusercontent.com/u/6118379?v=3","gravatar_id":"","url":"https://api.github.com/users/moonlight-stream","html_url":"https://github.com/moonlight-stream","followers_url":"https://api.github.com/users/moonlight-stream/followers","following_url":"https://api.github.com/users/moonlight-stream/following{/other_user}","gists_url":"https://api.github.com/users/moonlight-stream/gists{/gist_id}","starred_url":"https://api.github.com/users/moonlight-stream/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moonlight-stream/subscriptions","organizations_url":"https://api.github.com/users/moonlight-stream/orgs","repos_url":"https://api.github.com/users/moonlight-stream/repos","events_url":"https://api.github.com/users/moonlight-stream/events{/privacy}","received_events_url":"https://api.github.com/users/moonlight-stream/received_events","type":"Organization","site_admin":false},"repo":{"id":51626956,"name":"moonlight-chrome","full_name":"moonlight-stream/moonlight-chrome","owner":{"login":"moonlight-stream","id":6118379,"avatar_url":"https://avatars.githubusercontent.com/u/6118379?v=3","gravatar_id":"","url":"https://api.github.com/users/moonlight-stream","html_url":"https://github.com/moonlight-stream","followers_url":"https://api.github.com/users/moonlight-stream/followers","following_url":"https://api.github.com/users/moonlight-stream/following{/other_user}","gists_url":"https://api.github.com/users/moonlight-stream/gists{/gist_id}","starred_url":"https://api.github.com/users/moonlight-stream/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moonlight-stream/subscriptions","organizations_url":"https://api.github.com/users/moonlight-stream/orgs","repos_url":"https://api.github.com/users/moonlight-stream/repos","events_url":"https://api.github.com/users/moonlight-stream/events{/privacy}","received_events_url":"https://api.github.com/users/moonlight-stream/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/moonlight-stream/moonlight-chrome","description":"GameStream client for Chrome","fork":false,"url":"https://api.github.com/repos/moonlight-stream/moonlight-chrome","forks_url":"https://api.github.com/repos/moonlight-stream/moonlight-chrome/forks","keys_url":"https://api.github.com/repos/moonlight-stream/moonlight-chrome/keys{/key_id}","collaborators_url":"https://api.github.com/repos/moonlight-stream/moonlight-chrome/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/moonlight-stream/moonlight-chrome/teams","hooks_url":"https://api.github.com/repos/moonlight-stream/moonlight-chrome/hooks","issue_events_url":"https://api.github.com/repos/moonlight-stream/moonlight-chrome/issues/events{/number}","events_url":"https://api.github.com/repos/moonlight-stream/moonlight-chrome/events","assignees_url":"https://api.github.com/repos/moonlight-stream/moonlight-chrome/assignees{/user}","branches_url":"https://api.github.com/repos/moonlight-stream/moonlight-chrome/branches{/branch}","tags_url":"https://api.github.com/repos/moonlight-stream/moonlight-chrome/tags","blobs_url":"https://api.github.com/repos/moonlight-stream/moonlight-chrome/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/moonlight-stream/moonlight-chrome/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/moonlight-stream/moonlight-chrome/git/refs{/sha}","trees_url":"https://api.github.com/repos/moonlight-stream/moonlight-chrome/git/trees{/sha}","statuses_url":"https://api.github.com/repos/moonlight-stream/moonlight-chrome/statuses/{sha}","languages_url":"https://api.github.com/repos/moonlight-stream/moonlight-chrome/languages","stargazers_url":"https://api.github.com/repos/moonlight-stream/moonlight-chrome/stargazers","contributors_url":"https://api.github.com/repos/moonlight-stream/moonlight-chrome/contributors","subscribers_url":"https://api.github.com/repos/moonlight-stream/moonlight-chrome/subscribers","subscription_url":"https://api.github.com/repos/moonlight-stream/moonlight-chrome/subscription","commits_url":"https://api.github.com/repos/moonlight-stream/moonlight-chrome/commits{/sha}","git_commits_url":"https://api.github.com/repos/moonlight-stream/moonlight-chrome/git/commits{/sha}","comments_url":"https://api.github.com/repos/moonlight-stream/moonlight-chrome/comments{/number}","issue_comment_url":"https://api.github.com/repos/moonlight-stream/moonlight-chrome/issues/comments{/number}","contents_url":"https://api.github.com/repos/moonlight-stream/moonlight-chrome/contents/{+path}","compare_url":"https://api.github.com/repos/moonlight-stream/moonlight-chrome/compare/{base}...{head}","merges_url":"https://api.github.com/repos/moonlight-stream/moonlight-chrome/merges","archive_url":"https://api.github.com/repos/moonlight-stream/moonlight-chrome/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/moonlight-stream/moonlight-chrome/downloads","issues_url":"https://api.github.com/repos/moonlight-stream/moonlight-chrome/issues{/number}","pulls_url":"https://api.github.com/repos/moonlight-stream/moonlight-chrome/pulls{/number}","milestones_url":"https://api.github.com/repos/moonlight-stream/moonlight-chrome/milestones{/number}","notifications_url":"https://api.github.com/repos/moonlight-stream/moonlight-chrome/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/moonlight-stream/moonlight-chrome/labels{/name}","releases_url":"https://api.github.com/repos/moonlight-stream/moonlight-chrome/releases{/id}","deployments_url":"https://api.github.com/repos/moonlight-stream/moonlight-chrome/deployments","created_at":"2016-02-13T01:28:41Z","updated_at":"2016-04-12T20:21:01Z","pushed_at":"2016-04-13T01:07:49Z","git_url":"git://github.com/moonlight-stream/moonlight-chrome.git","ssh_url":"git@github.com:moonlight-stream/moonlight-chrome.git","clone_url":"https://github.com/moonlight-stream/moonlight-chrome.git","svn_url":"https://github.com/moonlight-stream/moonlight-chrome","homepage":"","size":6159,"stargazers_count":19,"watchers_count":19,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":9,"forks":5,"open_issues":9,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/moonlight-stream/moonlight-chrome/pulls/36"},"html":{"href":"https://github.com/moonlight-stream/moonlight-chrome/pull/36"},"issue":{"href":"https://api.github.com/repos/moonlight-stream/moonlight-chrome/issues/36"},"comments":{"href":"https://api.github.com/repos/moonlight-stream/moonlight-chrome/issues/36/comments"},"review_comments":{"href":"https://api.github.com/repos/moonlight-stream/moonlight-chrome/pulls/36/comments"},"review_comment":{"href":"https://api.github.com/repos/moonlight-stream/moonlight-chrome/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/moonlight-stream/moonlight-chrome/pulls/36/commits"},"statuses":{"href":"https://api.github.com/repos/moonlight-stream/moonlight-chrome/statuses/0a77a03cea70f37d5cd1df05475265bdd16ca911"}}}}