{"action":"created","comment":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/comments/55940961","id":55940961,"diff_hunk":"@@ -609,7 +609,11 @@ pub fn trans_intrinsic_call<'a, 'blk, 'tcx>(mut bcx: Block<'blk, 'tcx>,\n         (_, \"volatile_store\") => {\n             let tp_ty = *substs.types.get(FnSpace, 0);\n             let ptr = to_arg_ty_ptr(bcx, llargs[0], tp_ty);\n-            let val = from_arg_ty(bcx, llargs[1], tp_ty);\n+            let val = if type_is_immediate(bcx.ccx(), tp_ty) {\n+                from_arg_ty(bcx, llargs[1], tp_ty)\n+            } else {\n+                Load(bcx, from_arg_ty(bcx, llargs[1], tp_ty))","path":"src/librustc_trans/trans/intrinsic.rs","position":8,"original_position":8,"commit_id":"ff372dc77731de202b40dce8c434fb1e3d300b53","original_commit_id":"ff372dc77731de202b40dce8c434fb1e3d300b53","user":{"login":"Amanieu","id":278509,"avatar_url":"https://avatars.githubusercontent.com/u/278509?v=3","gravatar_id":"","url":"https://api.github.com/users/Amanieu","html_url":"https://github.com/Amanieu","followers_url":"https://api.github.com/users/Amanieu/followers","following_url":"https://api.github.com/users/Amanieu/following{/other_user}","gists_url":"https://api.github.com/users/Amanieu/gists{/gist_id}","starred_url":"https://api.github.com/users/Amanieu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Amanieu/subscriptions","organizations_url":"https://api.github.com/users/Amanieu/orgs","repos_url":"https://api.github.com/users/Amanieu/repos","events_url":"https://api.github.com/users/Amanieu/events{/privacy}","received_events_url":"https://api.github.com/users/Amanieu/received_events","type":"User","site_admin":false},"body":"`llargs[1]` is the *value* that needs to be stored. `llargs[0]` is the pointer to the store destination.","created_at":"2016-03-13T17:54:52Z","updated_at":"2016-03-13T17:54:52Z","html_url":"https://github.com/rust-lang/rust/pull/32233#discussion_r55940961","pull_request_url":"https://api.github.com/repos/rust-lang/rust/pulls/32233","_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments/55940961"},"html":{"href":"https://github.com/rust-lang/rust/pull/32233#discussion_r55940961"},"pull_request":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/32233"}}},"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/32233","id":62675719,"html_url":"https://github.com/rust-lang/rust/pull/32233","diff_url":"https://github.com/rust-lang/rust/pull/32233.diff","patch_url":"https://github.com/rust-lang/rust/pull/32233.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/32233","number":32233,"state":"open","locked":false,"title":"Fix LLVM assert with write_volatile","user":{"login":"Amanieu","id":278509,"avatar_url":"https://avatars.githubusercontent.com/u/278509?v=3","gravatar_id":"","url":"https://api.github.com/users/Amanieu","html_url":"https://github.com/Amanieu","followers_url":"https://api.github.com/users/Amanieu/followers","following_url":"https://api.github.com/users/Amanieu/following{/other_user}","gists_url":"https://api.github.com/users/Amanieu/gists{/gist_id}","starred_url":"https://api.github.com/users/Amanieu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Amanieu/subscriptions","organizations_url":"https://api.github.com/users/Amanieu/orgs","repos_url":"https://api.github.com/users/Amanieu/repos","events_url":"https://api.github.com/users/Amanieu/events{/privacy}","received_events_url":"https://api.github.com/users/Amanieu/received_events","type":"User","site_admin":false},"body":"Fixes #29663 ","created_at":"2016-03-13T16:42:07Z","updated_at":"2016-03-13T17:54:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"439ef330b3b8b5417d34e93ea5c45d546682025d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/32233/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/32233/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/32233/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/ff372dc77731de202b40dce8c434fb1e3d300b53","head":{"label":"Amanieu:volatile_store","ref":"volatile_store","sha":"ff372dc77731de202b40dce8c434fb1e3d300b53","user":{"login":"Amanieu","id":278509,"avatar_url":"https://avatars.githubusercontent.com/u/278509?v=3","gravatar_id":"","url":"https://api.github.com/users/Amanieu","html_url":"https://github.com/Amanieu","followers_url":"https://api.github.com/users/Amanieu/followers","following_url":"https://api.github.com/users/Amanieu/following{/other_user}","gists_url":"https://api.github.com/users/Amanieu/gists{/gist_id}","starred_url":"https://api.github.com/users/Amanieu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Amanieu/subscriptions","organizations_url":"https://api.github.com/users/Amanieu/orgs","repos_url":"https://api.github.com/users/Amanieu/repos","events_url":"https://api.github.com/users/Amanieu/events{/privacy}","received_events_url":"https://api.github.com/users/Amanieu/received_events","type":"User","site_admin":false},"repo":{"id":45469588,"name":"rust","full_name":"Amanieu/rust","owner":{"login":"Amanieu","id":278509,"avatar_url":"https://avatars.githubusercontent.com/u/278509?v=3","gravatar_id":"","url":"https://api.github.com/users/Amanieu","html_url":"https://github.com/Amanieu","followers_url":"https://api.github.com/users/Amanieu/followers","following_url":"https://api.github.com/users/Amanieu/following{/other_user}","gists_url":"https://api.github.com/users/Amanieu/gists{/gist_id}","starred_url":"https://api.github.com/users/Amanieu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Amanieu/subscriptions","organizations_url":"https://api.github.com/users/Amanieu/orgs","repos_url":"https://api.github.com/users/Amanieu/repos","events_url":"https://api.github.com/users/Amanieu/events{/privacy}","received_events_url":"https://api.github.com/users/Amanieu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Amanieu/rust","description":"A safe, concurrent, practical language.","fork":true,"url":"https://api.github.com/repos/Amanieu/rust","forks_url":"https://api.github.com/repos/Amanieu/rust/forks","keys_url":"https://api.github.com/repos/Amanieu/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Amanieu/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Amanieu/rust/teams","hooks_url":"https://api.github.com/repos/Amanieu/rust/hooks","issue_events_url":"https://api.github.com/repos/Amanieu/rust/issues/events{/number}","events_url":"https://api.github.com/repos/Amanieu/rust/events","assignees_url":"https://api.github.com/repos/Amanieu/rust/assignees{/user}","branches_url":"https://api.github.com/repos/Amanieu/rust/branches{/branch}","tags_url":"https://api.github.com/repos/Amanieu/rust/tags","blobs_url":"https://api.github.com/repos/Amanieu/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Amanieu/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Amanieu/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/Amanieu/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Amanieu/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/Amanieu/rust/languages","stargazers_url":"https://api.github.com/repos/Amanieu/rust/stargazers","contributors_url":"https://api.github.com/repos/Amanieu/rust/contributors","subscribers_url":"https://api.github.com/repos/Amanieu/rust/subscribers","subscription_url":"https://api.github.com/repos/Amanieu/rust/subscription","commits_url":"https://api.github.com/repos/Amanieu/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/Amanieu/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/Amanieu/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/Amanieu/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/Amanieu/rust/contents/{+path}","compare_url":"https://api.github.com/repos/Amanieu/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Amanieu/rust/merges","archive_url":"https://api.github.com/repos/Amanieu/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Amanieu/rust/downloads","issues_url":"https://api.github.com/repos/Amanieu/rust/issues{/number}","pulls_url":"https://api.github.com/repos/Amanieu/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/Amanieu/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/Amanieu/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Amanieu/rust/labels{/name}","releases_url":"https://api.github.com/repos/Amanieu/rust/releases{/id}","deployments_url":"https://api.github.com/repos/Amanieu/rust/deployments","created_at":"2015-11-03T13:52:04Z","updated_at":"2016-03-13T16:41:55Z","pushed_at":"2016-03-13T16:41:19Z","git_url":"git://github.com/Amanieu/rust.git","ssh_url":"git@github.com:Amanieu/rust.git","clone_url":"https://github.com/Amanieu/rust.git","svn_url":"https://github.com/Amanieu/rust","homepage":"http://www.rust-lang.org","size":282983,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"1c8b245928c3f2463b45fbddd862a0a70882d087","user":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"name":"rust","full_name":"rust-lang/rust","owner":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/rust","description":"A safe, concurrent, practical language.","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","deployments_url":"https://api.github.com/repos/rust-lang/rust/deployments","created_at":"2010-06-16T20:39:03Z","updated_at":"2016-03-13T16:34:40Z","pushed_at":"2016-03-13T16:42:07Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"git@github.com:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"http://www.rust-lang.org","size":478129,"stargazers_count":15632,"watchers_count":15632,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3013,"mirror_url":null,"open_issues_count":2326,"forks":3013,"open_issues":2326,"watchers":15632,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/32233"},"html":{"href":"https://github.com/rust-lang/rust/pull/32233"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/32233"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/32233/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/32233/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/32233/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/ff372dc77731de202b40dce8c434fb1e3d300b53"}}}}