{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/origin-web-console/pulls/comments/71518298","id":71518298,"diff_hunk":"@@ -1,25 +1,40 @@\n 'use strict';\n \n angular.module('openshiftConsole')\n-  .directive('sidebar', function(HawtioNav) {\n+  .directive('sidebar', function($location, Constants) {\n+    var itemMatchesPath = function(item, path) {\n+      return (item.href === path) || _.some(item.prefixes, function(prefix) {","path":"app/scripts/directives/nav.js","position":7,"original_position":7,"commit_id":"8a54df0017e2a54096496708e53c38d610a0e488","original_commit_id":"8a54df0017e2a54096496708e53c38d610a0e488","user":{"login":"spadgett","id":1167259,"avatar_url":"https://avatars.githubusercontent.com/u/1167259?v=3","gravatar_id":"","url":"https://api.github.com/users/spadgett","html_url":"https://github.com/spadgett","followers_url":"https://api.github.com/users/spadgett/followers","following_url":"https://api.github.com/users/spadgett/following{/other_user}","gists_url":"https://api.github.com/users/spadgett/gists{/gist_id}","starred_url":"https://api.github.com/users/spadgett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spadgett/subscriptions","organizations_url":"https://api.github.com/users/spadgett/orgs","repos_url":"https://api.github.com/users/spadgett/repos","events_url":"https://api.github.com/users/spadgett/events{/privacy}","received_events_url":"https://api.github.com/users/spadgett/received_events","type":"User","site_admin":false},"body":"I was wondering if we should try to normalize URLs as well with `URI.normalizePath`, but probably not worth it. We had some performance problems before doing URL manipulation to highlight nav items.","created_at":"2016-07-20T12:54:03Z","updated_at":"2016-07-20T12:54:03Z","html_url":"https://github.com/openshift/origin-web-console/pull/180#discussion_r71518298","pull_request_url":"https://api.github.com/repos/openshift/origin-web-console/pulls/180","_links":{"self":{"href":"https://api.github.com/repos/openshift/origin-web-console/pulls/comments/71518298"},"html":{"href":"https://github.com/openshift/origin-web-console/pull/180#discussion_r71518298"},"pull_request":{"href":"https://api.github.com/repos/openshift/origin-web-console/pulls/180"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/origin-web-console/pulls/180","id":77670588,"html_url":"https://github.com/openshift/origin-web-console/pull/180","diff_url":"https://github.com/openshift/origin-web-console/pull/180.diff","patch_url":"https://github.com/openshift/origin-web-console/pull/180.patch","issue_url":"https://api.github.com/repos/openshift/origin-web-console/issues/180","number":180,"state":"open","locked":false,"title":"Project primary and secondary navigation restructure","user":{"login":"jwforres","id":1467629,"avatar_url":"https://avatars.githubusercontent.com/u/1467629?v=3","gravatar_id":"","url":"https://api.github.com/users/jwforres","html_url":"https://github.com/jwforres","followers_url":"https://api.github.com/users/jwforres/followers","following_url":"https://api.github.com/users/jwforres/following{/other_user}","gists_url":"https://api.github.com/users/jwforres/gists{/gist_id}","starred_url":"https://api.github.com/users/jwforres/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwforres/subscriptions","organizations_url":"https://api.github.com/users/jwforres/orgs","repos_url":"https://api.github.com/users/jwforres/repos","events_url":"https://api.github.com/users/jwforres/events{/privacy}","received_events_url":"https://api.github.com/users/jwforres/received_events","type":"User","site_admin":false},"body":"Implements https://trello.com/c/dWIKyBWi\r\n\r\nJS TODOs:\r\n\r\n- [x] Add project name / description editor to the project list\r\n- [ ] Find a home for name/description editor within the context of the project\r\n- [ ] Builds page vs Pipeline Builds page\r\n- [ ] Monitoring -> Logs page\r\n- [ ] Monitoring -> Metrics page\r\n\r\nVisual TODOs:\r\n\r\n- [x] Sub-menu indicator at smaller screen resolutions\r\n- [x] Smallest icon+text primary nav needs to be wider for new longer menu names\r\n- [x] Fix icon alignment for pficons\r\n- [x] Secondary section header styling, regular and mobile","created_at":"2016-07-15T20:05:28Z","updated_at":"2016-07-20T12:54:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"57fd41f621821561088e892a855f863004e8c40e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin-web-console/pulls/180/commits","review_comments_url":"https://api.github.com/repos/openshift/origin-web-console/pulls/180/comments","review_comment_url":"https://api.github.com/repos/openshift/origin-web-console/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin-web-console/issues/180/comments","statuses_url":"https://api.github.com/repos/openshift/origin-web-console/statuses/8a54df0017e2a54096496708e53c38d610a0e488","head":{"label":"jwforres:nav_changes","ref":"nav_changes","sha":"8a54df0017e2a54096496708e53c38d610a0e488","user":{"login":"jwforres","id":1467629,"avatar_url":"https://avatars.githubusercontent.com/u/1467629?v=3","gravatar_id":"","url":"https://api.github.com/users/jwforres","html_url":"https://github.com/jwforres","followers_url":"https://api.github.com/users/jwforres/followers","following_url":"https://api.github.com/users/jwforres/following{/other_user}","gists_url":"https://api.github.com/users/jwforres/gists{/gist_id}","starred_url":"https://api.github.com/users/jwforres/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwforres/subscriptions","organizations_url":"https://api.github.com/users/jwforres/orgs","repos_url":"https://api.github.com/users/jwforres/repos","events_url":"https://api.github.com/users/jwforres/events{/privacy}","received_events_url":"https://api.github.com/users/jwforres/received_events","type":"User","site_admin":false},"repo":{"id":58489461,"name":"origin-web-console","full_name":"jwforres/origin-web-console","owner":{"login":"jwforres","id":1467629,"avatar_url":"https://avatars.githubusercontent.com/u/1467629?v=3","gravatar_id":"","url":"https://api.github.com/users/jwforres","html_url":"https://github.com/jwforres","followers_url":"https://api.github.com/users/jwforres/followers","following_url":"https://api.github.com/users/jwforres/following{/other_user}","gists_url":"https://api.github.com/users/jwforres/gists{/gist_id}","starred_url":"https://api.github.com/users/jwforres/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwforres/subscriptions","organizations_url":"https://api.github.com/users/jwforres/orgs","repos_url":"https://api.github.com/users/jwforres/repos","events_url":"https://api.github.com/users/jwforres/events{/privacy}","received_events_url":"https://api.github.com/users/jwforres/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jwforres/origin-web-console","description":"","fork":true,"url":"https://api.github.com/repos/jwforres/origin-web-console","forks_url":"https://api.github.com/repos/jwforres/origin-web-console/forks","keys_url":"https://api.github.com/repos/jwforres/origin-web-console/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jwforres/origin-web-console/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jwforres/origin-web-console/teams","hooks_url":"https://api.github.com/repos/jwforres/origin-web-console/hooks","issue_events_url":"https://api.github.com/repos/jwforres/origin-web-console/issues/events{/number}","events_url":"https://api.github.com/repos/jwforres/origin-web-console/events","assignees_url":"https://api.github.com/repos/jwforres/origin-web-console/assignees{/user}","branches_url":"https://api.github.com/repos/jwforres/origin-web-console/branches{/branch}","tags_url":"https://api.github.com/repos/jwforres/origin-web-console/tags","blobs_url":"https://api.github.com/repos/jwforres/origin-web-console/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jwforres/origin-web-console/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jwforres/origin-web-console/git/refs{/sha}","trees_url":"https://api.github.com/repos/jwforres/origin-web-console/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jwforres/origin-web-console/statuses/{sha}","languages_url":"https://api.github.com/repos/jwforres/origin-web-console/languages","stargazers_url":"https://api.github.com/repos/jwforres/origin-web-console/stargazers","contributors_url":"https://api.github.com/repos/jwforres/origin-web-console/contributors","subscribers_url":"https://api.github.com/repos/jwforres/origin-web-console/subscribers","subscription_url":"https://api.github.com/repos/jwforres/origin-web-console/subscription","commits_url":"https://api.github.com/repos/jwforres/origin-web-console/commits{/sha}","git_commits_url":"https://api.github.com/repos/jwforres/origin-web-console/git/commits{/sha}","comments_url":"https://api.github.com/repos/jwforres/origin-web-console/comments{/number}","issue_comment_url":"https://api.github.com/repos/jwforres/origin-web-console/issues/comments{/number}","contents_url":"https://api.github.com/repos/jwforres/origin-web-console/contents/{+path}","compare_url":"https://api.github.com/repos/jwforres/origin-web-console/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jwforres/origin-web-console/merges","archive_url":"https://api.github.com/repos/jwforres/origin-web-console/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jwforres/origin-web-console/downloads","issues_url":"https://api.github.com/repos/jwforres/origin-web-console/issues{/number}","pulls_url":"https://api.github.com/repos/jwforres/origin-web-console/pulls{/number}","milestones_url":"https://api.github.com/repos/jwforres/origin-web-console/milestones{/number}","notifications_url":"https://api.github.com/repos/jwforres/origin-web-console/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jwforres/origin-web-console/labels{/name}","releases_url":"https://api.github.com/repos/jwforres/origin-web-console/releases{/id}","deployments_url":"https://api.github.com/repos/jwforres/origin-web-console/deployments","created_at":"2016-05-10T19:52:39Z","updated_at":"2016-05-10T19:52:41Z","pushed_at":"2016-07-19T21:10:12Z","git_url":"git://github.com/jwforres/origin-web-console.git","ssh_url":"git@github.com:jwforres/origin-web-console.git","clone_url":"https://github.com/jwforres/origin-web-console.git","svn_url":"https://github.com/jwforres/origin-web-console","homepage":null,"size":7896,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"bad6254aed5b173baf6e01f1a86ef4f47b4e15d4","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":58488264,"name":"origin-web-console","full_name":"openshift/origin-web-console","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin-web-console","description":"","fork":false,"url":"https://api.github.com/repos/openshift/origin-web-console","forks_url":"https://api.github.com/repos/openshift/origin-web-console/forks","keys_url":"https://api.github.com/repos/openshift/origin-web-console/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin-web-console/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin-web-console/teams","hooks_url":"https://api.github.com/repos/openshift/origin-web-console/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin-web-console/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin-web-console/events","assignees_url":"https://api.github.com/repos/openshift/origin-web-console/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin-web-console/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin-web-console/tags","blobs_url":"https://api.github.com/repos/openshift/origin-web-console/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin-web-console/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin-web-console/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin-web-console/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin-web-console/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin-web-console/languages","stargazers_url":"https://api.github.com/repos/openshift/origin-web-console/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin-web-console/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin-web-console/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin-web-console/subscription","commits_url":"https://api.github.com/repos/openshift/origin-web-console/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin-web-console/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin-web-console/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin-web-console/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin-web-console/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin-web-console/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin-web-console/merges","archive_url":"https://api.github.com/repos/openshift/origin-web-console/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin-web-console/downloads","issues_url":"https://api.github.com/repos/openshift/origin-web-console/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin-web-console/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin-web-console/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin-web-console/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin-web-console/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin-web-console/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/origin-web-console/deployments","created_at":"2016-05-10T19:31:50Z","updated_at":"2016-06-20T16:37:07Z","pushed_at":"2016-07-20T12:30:26Z","git_url":"git://github.com/openshift/origin-web-console.git","ssh_url":"git@github.com:openshift/origin-web-console.git","clone_url":"https://github.com/openshift/origin-web-console.git","svn_url":"https://github.com/openshift/origin-web-console","homepage":null,"size":7821,"stargazers_count":13,"watchers_count":13,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":28,"mirror_url":null,"open_issues_count":36,"forks":28,"open_issues":36,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin-web-console/pulls/180"},"html":{"href":"https://github.com/openshift/origin-web-console/pull/180"},"issue":{"href":"https://api.github.com/repos/openshift/origin-web-console/issues/180"},"comments":{"href":"https://api.github.com/repos/openshift/origin-web-console/issues/180/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin-web-console/pulls/180/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin-web-console/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin-web-console/pulls/180/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin-web-console/statuses/8a54df0017e2a54096496708e53c38d610a0e488"}}}}
{"actor":{"display_login":"spadgett"}}