{"action":"created","comment":{"url":"https://api.github.com/repos/coreos/kube-aws/pulls/comments/92318290","pull_request_review_id":12830898,"id":92318290,"diff_hunk":"@@ -731,6 +737,14 @@ func (c Cluster) valid() error {\n \t\treturn err\n \t}\n \n+\tif c.WorkerTenancy != \"default\" && c.Worker.SpotFleet.Enabled {","path":"config/config.go","position":52,"original_position":52,"commit_id":"d93ea0ec1f2f3b0dc4abca551ca935a4c74d4554","original_commit_id":"d93ea0ec1f2f3b0dc4abca551ca935a4c74d4554","user":{"login":"mumoshu","id":22009,"avatar_url":"https://avatars.githubusercontent.com/u/22009?v=3","gravatar_id":"","url":"https://api.github.com/users/mumoshu","html_url":"https://github.com/mumoshu","followers_url":"https://api.github.com/users/mumoshu/followers","following_url":"https://api.github.com/users/mumoshu/following{/other_user}","gists_url":"https://api.github.com/users/mumoshu/gists{/gist_id}","starred_url":"https://api.github.com/users/mumoshu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mumoshu/subscriptions","organizations_url":"https://api.github.com/users/mumoshu/orgs","repos_url":"https://api.github.com/users/mumoshu/repos","events_url":"https://api.github.com/users/mumoshu/events{/privacy}","received_events_url":"https://api.github.com/users/mumoshu/received_events","type":"User","site_admin":false},"body":"To follow the recent change in master, `c.Worker.SpotFleet.Enabled` should now be `c.Worker.SpotFleet.Enabled()`","created_at":"2016-12-14T03:47:17Z","updated_at":"2016-12-14T03:47:17Z","html_url":"https://github.com/coreos/kube-aws/pull/146#discussion_r92318290","pull_request_url":"https://api.github.com/repos/coreos/kube-aws/pulls/146","_links":{"self":{"href":"https://api.github.com/repos/coreos/kube-aws/pulls/comments/92318290"},"html":{"href":"https://github.com/coreos/kube-aws/pull/146#discussion_r92318290"},"pull_request":{"href":"https://api.github.com/repos/coreos/kube-aws/pulls/146"}}},"pull_request":{"url":"https://api.github.com/repos/coreos/kube-aws/pulls/146","id":97401562,"html_url":"https://github.com/coreos/kube-aws/pull/146","diff_url":"https://github.com/coreos/kube-aws/pull/146.diff","patch_url":"https://github.com/coreos/kube-aws/pull/146.patch","issue_url":"https://api.github.com/repos/coreos/kube-aws/issues/146","number":146,"state":"open","locked":false,"title":"Add configurable instance tenancy","user":{"login":"iameli","id":257909,"avatar_url":"https://avatars.githubusercontent.com/u/257909?v=3","gravatar_id":"","url":"https://api.github.com/users/iameli","html_url":"https://github.com/iameli","followers_url":"https://api.github.com/users/iameli/followers","following_url":"https://api.github.com/users/iameli/following{/other_user}","gists_url":"https://api.github.com/users/iameli/gists{/gist_id}","starred_url":"https://api.github.com/users/iameli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iameli/subscriptions","organizations_url":"https://api.github.com/users/iameli/orgs","repos_url":"https://api.github.com/users/iameli/repos","events_url":"https://api.github.com/users/iameli/events{/privacy}","received_events_url":"https://api.github.com/users/iameli/received_events","type":"User","site_admin":false},"body":"Return of [my PR on the coreos-kubernetes repo](https://github.com/coreos/coreos-kubernetes/pull/252), this time with node-pool support added.\r\n\r\nLet me know if you'd like tests or anything. The only thing slightly tricky about dedicated tenancy is that it's mutually exclusive with spot instances, I could potentially add a check for that.","created_at":"2016-12-10T00:03:27Z","updated_at":"2016-12-14T03:47:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f39fc3c6b2f43680a71f1e52b0358e2d3a592f21","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/coreos/kube-aws/pulls/146/commits","review_comments_url":"https://api.github.com/repos/coreos/kube-aws/pulls/146/comments","review_comment_url":"https://api.github.com/repos/coreos/kube-aws/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coreos/kube-aws/issues/146/comments","statuses_url":"https://api.github.com/repos/coreos/kube-aws/statuses/d93ea0ec1f2f3b0dc4abca551ca935a4c74d4554","head":{"label":"csats:master","ref":"master","sha":"d93ea0ec1f2f3b0dc4abca551ca935a4c74d4554","user":{"login":"csats","id":8420250,"avatar_url":"https://avatars.githubusercontent.com/u/8420250?v=3","gravatar_id":"","url":"https://api.github.com/users/csats","html_url":"https://github.com/csats","followers_url":"https://api.github.com/users/csats/followers","following_url":"https://api.github.com/users/csats/following{/other_user}","gists_url":"https://api.github.com/users/csats/gists{/gist_id}","starred_url":"https://api.github.com/users/csats/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csats/subscriptions","organizations_url":"https://api.github.com/users/csats/orgs","repos_url":"https://api.github.com/users/csats/repos","events_url":"https://api.github.com/users/csats/events{/privacy}","received_events_url":"https://api.github.com/users/csats/received_events","type":"Organization","site_admin":false},"repo":{"id":76076888,"name":"kube-aws","full_name":"csats/kube-aws","owner":{"login":"csats","id":8420250,"avatar_url":"https://avatars.githubusercontent.com/u/8420250?v=3","gravatar_id":"","url":"https://api.github.com/users/csats","html_url":"https://github.com/csats","followers_url":"https://api.github.com/users/csats/followers","following_url":"https://api.github.com/users/csats/following{/other_user}","gists_url":"https://api.github.com/users/csats/gists{/gist_id}","starred_url":"https://api.github.com/users/csats/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csats/subscriptions","organizations_url":"https://api.github.com/users/csats/orgs","repos_url":"https://api.github.com/users/csats/repos","events_url":"https://api.github.com/users/csats/events{/privacy}","received_events_url":"https://api.github.com/users/csats/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/csats/kube-aws","description":"CoreOS Kubernetes on AWS","fork":true,"url":"https://api.github.com/repos/csats/kube-aws","forks_url":"https://api.github.com/repos/csats/kube-aws/forks","keys_url":"https://api.github.com/repos/csats/kube-aws/keys{/key_id}","collaborators_url":"https://api.github.com/repos/csats/kube-aws/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/csats/kube-aws/teams","hooks_url":"https://api.github.com/repos/csats/kube-aws/hooks","issue_events_url":"https://api.github.com/repos/csats/kube-aws/issues/events{/number}","events_url":"https://api.github.com/repos/csats/kube-aws/events","assignees_url":"https://api.github.com/repos/csats/kube-aws/assignees{/user}","branches_url":"https://api.github.com/repos/csats/kube-aws/branches{/branch}","tags_url":"https://api.github.com/repos/csats/kube-aws/tags","blobs_url":"https://api.github.com/repos/csats/kube-aws/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/csats/kube-aws/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/csats/kube-aws/git/refs{/sha}","trees_url":"https://api.github.com/repos/csats/kube-aws/git/trees{/sha}","statuses_url":"https://api.github.com/repos/csats/kube-aws/statuses/{sha}","languages_url":"https://api.github.com/repos/csats/kube-aws/languages","stargazers_url":"https://api.github.com/repos/csats/kube-aws/stargazers","contributors_url":"https://api.github.com/repos/csats/kube-aws/contributors","subscribers_url":"https://api.github.com/repos/csats/kube-aws/subscribers","subscription_url":"https://api.github.com/repos/csats/kube-aws/subscription","commits_url":"https://api.github.com/repos/csats/kube-aws/commits{/sha}","git_commits_url":"https://api.github.com/repos/csats/kube-aws/git/commits{/sha}","comments_url":"https://api.github.com/repos/csats/kube-aws/comments{/number}","issue_comment_url":"https://api.github.com/repos/csats/kube-aws/issues/comments{/number}","contents_url":"https://api.github.com/repos/csats/kube-aws/contents/{+path}","compare_url":"https://api.github.com/repos/csats/kube-aws/compare/{base}...{head}","merges_url":"https://api.github.com/repos/csats/kube-aws/merges","archive_url":"https://api.github.com/repos/csats/kube-aws/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/csats/kube-aws/downloads","issues_url":"https://api.github.com/repos/csats/kube-aws/issues{/number}","pulls_url":"https://api.github.com/repos/csats/kube-aws/pulls{/number}","milestones_url":"https://api.github.com/repos/csats/kube-aws/milestones{/number}","notifications_url":"https://api.github.com/repos/csats/kube-aws/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/csats/kube-aws/labels{/name}","releases_url":"https://api.github.com/repos/csats/kube-aws/releases{/id}","deployments_url":"https://api.github.com/repos/csats/kube-aws/deployments","created_at":"2016-12-09T23:05:15Z","updated_at":"2016-12-09T23:05:16Z","pushed_at":"2016-12-14T00:33:11Z","git_url":"git://github.com/csats/kube-aws.git","ssh_url":"git@github.com:csats/kube-aws.git","clone_url":"https://github.com/csats/kube-aws.git","svn_url":"https://github.com/csats/kube-aws","homepage":null,"size":19087,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"coreos:master","ref":"master","sha":"56f08d529e5972a39f432d1c9de27ef35013dae7","user":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"repo":{"id":70860688,"name":"kube-aws","full_name":"coreos/kube-aws","owner":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coreos/kube-aws","description":"CoreOS Kubernetes on AWS","fork":false,"url":"https://api.github.com/repos/coreos/kube-aws","forks_url":"https://api.github.com/repos/coreos/kube-aws/forks","keys_url":"https://api.github.com/repos/coreos/kube-aws/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coreos/kube-aws/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coreos/kube-aws/teams","hooks_url":"https://api.github.com/repos/coreos/kube-aws/hooks","issue_events_url":"https://api.github.com/repos/coreos/kube-aws/issues/events{/number}","events_url":"https://api.github.com/repos/coreos/kube-aws/events","assignees_url":"https://api.github.com/repos/coreos/kube-aws/assignees{/user}","branches_url":"https://api.github.com/repos/coreos/kube-aws/branches{/branch}","tags_url":"https://api.github.com/repos/coreos/kube-aws/tags","blobs_url":"https://api.github.com/repos/coreos/kube-aws/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coreos/kube-aws/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coreos/kube-aws/git/refs{/sha}","trees_url":"https://api.github.com/repos/coreos/kube-aws/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coreos/kube-aws/statuses/{sha}","languages_url":"https://api.github.com/repos/coreos/kube-aws/languages","stargazers_url":"https://api.github.com/repos/coreos/kube-aws/stargazers","contributors_url":"https://api.github.com/repos/coreos/kube-aws/contributors","subscribers_url":"https://api.github.com/repos/coreos/kube-aws/subscribers","subscription_url":"https://api.github.com/repos/coreos/kube-aws/subscription","commits_url":"https://api.github.com/repos/coreos/kube-aws/commits{/sha}","git_commits_url":"https://api.github.com/repos/coreos/kube-aws/git/commits{/sha}","comments_url":"https://api.github.com/repos/coreos/kube-aws/comments{/number}","issue_comment_url":"https://api.github.com/repos/coreos/kube-aws/issues/comments{/number}","contents_url":"https://api.github.com/repos/coreos/kube-aws/contents/{+path}","compare_url":"https://api.github.com/repos/coreos/kube-aws/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coreos/kube-aws/merges","archive_url":"https://api.github.com/repos/coreos/kube-aws/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coreos/kube-aws/downloads","issues_url":"https://api.github.com/repos/coreos/kube-aws/issues{/number}","pulls_url":"https://api.github.com/repos/coreos/kube-aws/pulls{/number}","milestones_url":"https://api.github.com/repos/coreos/kube-aws/milestones{/number}","notifications_url":"https://api.github.com/repos/coreos/kube-aws/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coreos/kube-aws/labels{/name}","releases_url":"https://api.github.com/repos/coreos/kube-aws/releases{/id}","deployments_url":"https://api.github.com/repos/coreos/kube-aws/deployments","created_at":"2016-10-14T00:57:33Z","updated_at":"2016-12-13T19:35:15Z","pushed_at":"2016-12-14T03:33:10Z","git_url":"git://github.com/coreos/kube-aws.git","ssh_url":"git@github.com:coreos/kube-aws.git","clone_url":"https://github.com/coreos/kube-aws.git","svn_url":"https://github.com/coreos/kube-aws","homepage":null,"size":19154,"stargazers_count":104,"watchers_count":104,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":29,"mirror_url":null,"open_issues_count":40,"forks":29,"open_issues":40,"watchers":104,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coreos/kube-aws/pulls/146"},"html":{"href":"https://github.com/coreos/kube-aws/pull/146"},"issue":{"href":"https://api.github.com/repos/coreos/kube-aws/issues/146"},"comments":{"href":"https://api.github.com/repos/coreos/kube-aws/issues/146/comments"},"review_comments":{"href":"https://api.github.com/repos/coreos/kube-aws/pulls/146/comments"},"review_comment":{"href":"https://api.github.com/repos/coreos/kube-aws/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coreos/kube-aws/pulls/146/commits"},"statuses":{"href":"https://api.github.com/repos/coreos/kube-aws/statuses/d93ea0ec1f2f3b0dc4abca551ca935a4c74d4554"}}}}
{"actor":{"display_login":"mumoshu"}}