{"action":"created","comment":{"url":"https://api.github.com/repos/nest/nest-simulator/pulls/comments/81911982","pull_request_review_id":2855967,"id":81911982,"diff_hunk":"@@ -234,18 +234,29 @@ aeif_cond_alpha_multisynapse::Parameters_::set( const DictionaryDatum& d )\n     HMIN = tmp;\n   }\n \n-  if ( Delta_T != 0. && V_peak_ <= V_th )\n+  if ( V_peak_ <= V_th )\n   {\n     throw BadProperty( \"V_peak must be larger than threshold.\" );\n   }\n-  else if ( Delta_T == 0. )\n+\n+  if ( Delta_T < 0. )\n   {\n-    updateValue< double >( d, names::V_peak, V_th ); // expected behaviour\n+    throw BadProperty( \"Delta_T must be positive.\" );\n   }\n-\n-  if ( V_reset_ >= V_peak_ )\n+  else if ( Delta_T > 0. )\n   {\n-    throw BadProperty( \"Ensure that: V_reset < V_peak .\" );\n+    // check for possible numerical overflow with the exponential divergence at\n+    // spike time, keep a 1e20 margin for the subsequent calculations\n+    const double max_exp_arg =\n+      std::log( std::numeric_limits< double >::max() ) - 20.;","path":"models/aeif_cond_alpha_multisynapse.cpp","position":null,"original_position":24,"commit_id":"87ee81cabc9566e8fe128170ccedefff4d375068","original_commit_id":"87ee81cabc9566e8fe128170ccedefff4d375068","user":{"login":"heplesser","id":1059644,"avatar_url":"https://avatars.githubusercontent.com/u/1059644?v=3","gravatar_id":"","url":"https://api.github.com/users/heplesser","html_url":"https://github.com/heplesser","followers_url":"https://api.github.com/users/heplesser/followers","following_url":"https://api.github.com/users/heplesser/following{/other_user}","gists_url":"https://api.github.com/users/heplesser/gists{/gist_id}","starred_url":"https://api.github.com/users/heplesser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heplesser/subscriptions","organizations_url":"https://api.github.com/users/heplesser/orgs","repos_url":"https://api.github.com/users/heplesser/repos","events_url":"https://api.github.com/users/heplesser/events{/privacy}","received_events_url":"https://api.github.com/users/heplesser/received_events","type":"User","site_admin":false},"body":"See comment on `aeif_cond_alpha`.","created_at":"2016-10-05T07:13:32Z","updated_at":"2016-10-05T07:13:32Z","html_url":"https://github.com/nest/nest-simulator/pull/474#discussion_r81911982","pull_request_url":"https://api.github.com/repos/nest/nest-simulator/pulls/474","_links":{"self":{"href":"https://api.github.com/repos/nest/nest-simulator/pulls/comments/81911982"},"html":{"href":"https://github.com/nest/nest-simulator/pull/474#discussion_r81911982"},"pull_request":{"href":"https://api.github.com/repos/nest/nest-simulator/pulls/474"}}},"pull_request":{"url":"https://api.github.com/repos/nest/nest-simulator/pulls/474","id":84459462,"html_url":"https://github.com/nest/nest-simulator/pull/474","diff_url":"https://github.com/nest/nest-simulator/pull/474.diff","patch_url":"https://github.com/nest/nest-simulator/pull/474.patch","issue_url":"https://api.github.com/repos/nest/nest-simulator/issues/474","number":474,"state":"open","locked":false,"title":"V-bounded implementation for AEIF + fixed Delta_T=0","user":{"login":"Silmathoron","id":8523051,"avatar_url":"https://avatars.githubusercontent.com/u/8523051?v=3","gravatar_id":"","url":"https://api.github.com/users/Silmathoron","html_url":"https://github.com/Silmathoron","followers_url":"https://api.github.com/users/Silmathoron/followers","following_url":"https://api.github.com/users/Silmathoron/following{/other_user}","gists_url":"https://api.github.com/users/Silmathoron/gists{/gist_id}","starred_url":"https://api.github.com/users/Silmathoron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Silmathoron/subscriptions","organizations_url":"https://api.github.com/users/Silmathoron/orgs","repos_url":"https://api.github.com/users/Silmathoron/repos","events_url":"https://api.github.com/users/Silmathoron/events{/privacy}","received_events_url":"https://api.github.com/users/Silmathoron/received_events","type":"User","site_admin":false},"body":"This PR proposes a corrected implementation of the existing AEIF models that leads to a solution which is closer to the reference LSODAR implementation (see discussion in PR #229 and provided notebook).\r\nIt also includes a fix for issue [#114](https://github.com/nest/nest-simulator/issues/114) by setting a separate implementation for the case of ``Delta_T == 0``.\r\n\r\n**Remaining question:** currently the argument of the exponential is not bounded anymore (except for the ``multisynapse`` implementation because the numerical instability test is different), which means that numerical overflow _will_ occur when ``Delta_T`` becomes small enough.\r\nShould we consider this an unavoidable issue of the model and consider that the domain where it occurs are not biologically relevant anyway? Or should the exponential still be bounded?\r\nIf it should be bounded, I propose to use ``numeric_limits`` and ``MAX_DOUBLE`` instead of an ad hoc value, but it should be noted that in those cases, the model _will_ deviate from the real solution anyway...","created_at":"2016-09-08T11:23:23Z","updated_at":"2016-10-05T07:13:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ada26578b15e2706cb984a216980d6bc06c07cb5","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/nest/nest-simulator/pulls/474/commits","review_comments_url":"https://api.github.com/repos/nest/nest-simulator/pulls/474/comments","review_comment_url":"https://api.github.com/repos/nest/nest-simulator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nest/nest-simulator/issues/474/comments","statuses_url":"https://api.github.com/repos/nest/nest-simulator/statuses/87ee81cabc9566e8fe128170ccedefff4d375068","head":{"label":"Silmathoron:aeif-v-bounded","ref":"aeif-v-bounded","sha":"87ee81cabc9566e8fe128170ccedefff4d375068","user":{"login":"Silmathoron","id":8523051,"avatar_url":"https://avatars.githubusercontent.com/u/8523051?v=3","gravatar_id":"","url":"https://api.github.com/users/Silmathoron","html_url":"https://github.com/Silmathoron","followers_url":"https://api.github.com/users/Silmathoron/followers","following_url":"https://api.github.com/users/Silmathoron/following{/other_user}","gists_url":"https://api.github.com/users/Silmathoron/gists{/gist_id}","starred_url":"https://api.github.com/users/Silmathoron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Silmathoron/subscriptions","organizations_url":"https://api.github.com/users/Silmathoron/orgs","repos_url":"https://api.github.com/users/Silmathoron/repos","events_url":"https://api.github.com/users/Silmathoron/events{/privacy}","received_events_url":"https://api.github.com/users/Silmathoron/received_events","type":"User","site_admin":false},"repo":{"id":47562139,"name":"nest-simulator","full_name":"Silmathoron/nest-simulator","owner":{"login":"Silmathoron","id":8523051,"avatar_url":"https://avatars.githubusercontent.com/u/8523051?v=3","gravatar_id":"","url":"https://api.github.com/users/Silmathoron","html_url":"https://github.com/Silmathoron","followers_url":"https://api.github.com/users/Silmathoron/followers","following_url":"https://api.github.com/users/Silmathoron/following{/other_user}","gists_url":"https://api.github.com/users/Silmathoron/gists{/gist_id}","starred_url":"https://api.github.com/users/Silmathoron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Silmathoron/subscriptions","organizations_url":"https://api.github.com/users/Silmathoron/orgs","repos_url":"https://api.github.com/users/Silmathoron/repos","events_url":"https://api.github.com/users/Silmathoron/events{/privacy}","received_events_url":"https://api.github.com/users/Silmathoron/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Silmathoron/nest-simulator","description":"The NEST simulator","fork":true,"url":"https://api.github.com/repos/Silmathoron/nest-simulator","forks_url":"https://api.github.com/repos/Silmathoron/nest-simulator/forks","keys_url":"https://api.github.com/repos/Silmathoron/nest-simulator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Silmathoron/nest-simulator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Silmathoron/nest-simulator/teams","hooks_url":"https://api.github.com/repos/Silmathoron/nest-simulator/hooks","issue_events_url":"https://api.github.com/repos/Silmathoron/nest-simulator/issues/events{/number}","events_url":"https://api.github.com/repos/Silmathoron/nest-simulator/events","assignees_url":"https://api.github.com/repos/Silmathoron/nest-simulator/assignees{/user}","branches_url":"https://api.github.com/repos/Silmathoron/nest-simulator/branches{/branch}","tags_url":"https://api.github.com/repos/Silmathoron/nest-simulator/tags","blobs_url":"https://api.github.com/repos/Silmathoron/nest-simulator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Silmathoron/nest-simulator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Silmathoron/nest-simulator/git/refs{/sha}","trees_url":"https://api.github.com/repos/Silmathoron/nest-simulator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Silmathoron/nest-simulator/statuses/{sha}","languages_url":"https://api.github.com/repos/Silmathoron/nest-simulator/languages","stargazers_url":"https://api.github.com/repos/Silmathoron/nest-simulator/stargazers","contributors_url":"https://api.github.com/repos/Silmathoron/nest-simulator/contributors","subscribers_url":"https://api.github.com/repos/Silmathoron/nest-simulator/subscribers","subscription_url":"https://api.github.com/repos/Silmathoron/nest-simulator/subscription","commits_url":"https://api.github.com/repos/Silmathoron/nest-simulator/commits{/sha}","git_commits_url":"https://api.github.com/repos/Silmathoron/nest-simulator/git/commits{/sha}","comments_url":"https://api.github.com/repos/Silmathoron/nest-simulator/comments{/number}","issue_comment_url":"https://api.github.com/repos/Silmathoron/nest-simulator/issues/comments{/number}","contents_url":"https://api.github.com/repos/Silmathoron/nest-simulator/contents/{+path}","compare_url":"https://api.github.com/repos/Silmathoron/nest-simulator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Silmathoron/nest-simulator/merges","archive_url":"https://api.github.com/repos/Silmathoron/nest-simulator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Silmathoron/nest-simulator/downloads","issues_url":"https://api.github.com/repos/Silmathoron/nest-simulator/issues{/number}","pulls_url":"https://api.github.com/repos/Silmathoron/nest-simulator/pulls{/number}","milestones_url":"https://api.github.com/repos/Silmathoron/nest-simulator/milestones{/number}","notifications_url":"https://api.github.com/repos/Silmathoron/nest-simulator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Silmathoron/nest-simulator/labels{/name}","releases_url":"https://api.github.com/repos/Silmathoron/nest-simulator/releases{/id}","deployments_url":"https://api.github.com/repos/Silmathoron/nest-simulator/deployments","created_at":"2015-12-07T15:50:56Z","updated_at":"2016-02-17T16:31:27Z","pushed_at":"2016-10-04T12:33:51Z","git_url":"git://github.com/Silmathoron/nest-simulator.git","ssh_url":"git@github.com:Silmathoron/nest-simulator.git","clone_url":"https://github.com/Silmathoron/nest-simulator.git","svn_url":"https://github.com/Silmathoron/nest-simulator","homepage":"https://travis-ci.org/Silmathoron/nest-simulator/branches","size":24866,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nest:master","ref":"master","sha":"0d58accc82b6b44801c82e502976889e3c37d80b","user":{"login":"nest","id":2377019,"avatar_url":"https://avatars.githubusercontent.com/u/2377019?v=3","gravatar_id":"","url":"https://api.github.com/users/nest","html_url":"https://github.com/nest","followers_url":"https://api.github.com/users/nest/followers","following_url":"https://api.github.com/users/nest/following{/other_user}","gists_url":"https://api.github.com/users/nest/gists{/gist_id}","starred_url":"https://api.github.com/users/nest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nest/subscriptions","organizations_url":"https://api.github.com/users/nest/orgs","repos_url":"https://api.github.com/users/nest/repos","events_url":"https://api.github.com/users/nest/events{/privacy}","received_events_url":"https://api.github.com/users/nest/received_events","type":"Organization","site_admin":false},"repo":{"id":33933892,"name":"nest-simulator","full_name":"nest/nest-simulator","owner":{"login":"nest","id":2377019,"avatar_url":"https://avatars.githubusercontent.com/u/2377019?v=3","gravatar_id":"","url":"https://api.github.com/users/nest","html_url":"https://github.com/nest","followers_url":"https://api.github.com/users/nest/followers","following_url":"https://api.github.com/users/nest/following{/other_user}","gists_url":"https://api.github.com/users/nest/gists{/gist_id}","starred_url":"https://api.github.com/users/nest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nest/subscriptions","organizations_url":"https://api.github.com/users/nest/orgs","repos_url":"https://api.github.com/users/nest/repos","events_url":"https://api.github.com/users/nest/events{/privacy}","received_events_url":"https://api.github.com/users/nest/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nest/nest-simulator","description":"The NEST simulator","fork":false,"url":"https://api.github.com/repos/nest/nest-simulator","forks_url":"https://api.github.com/repos/nest/nest-simulator/forks","keys_url":"https://api.github.com/repos/nest/nest-simulator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nest/nest-simulator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nest/nest-simulator/teams","hooks_url":"https://api.github.com/repos/nest/nest-simulator/hooks","issue_events_url":"https://api.github.com/repos/nest/nest-simulator/issues/events{/number}","events_url":"https://api.github.com/repos/nest/nest-simulator/events","assignees_url":"https://api.github.com/repos/nest/nest-simulator/assignees{/user}","branches_url":"https://api.github.com/repos/nest/nest-simulator/branches{/branch}","tags_url":"https://api.github.com/repos/nest/nest-simulator/tags","blobs_url":"https://api.github.com/repos/nest/nest-simulator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nest/nest-simulator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nest/nest-simulator/git/refs{/sha}","trees_url":"https://api.github.com/repos/nest/nest-simulator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nest/nest-simulator/statuses/{sha}","languages_url":"https://api.github.com/repos/nest/nest-simulator/languages","stargazers_url":"https://api.github.com/repos/nest/nest-simulator/stargazers","contributors_url":"https://api.github.com/repos/nest/nest-simulator/contributors","subscribers_url":"https://api.github.com/repos/nest/nest-simulator/subscribers","subscription_url":"https://api.github.com/repos/nest/nest-simulator/subscription","commits_url":"https://api.github.com/repos/nest/nest-simulator/commits{/sha}","git_commits_url":"https://api.github.com/repos/nest/nest-simulator/git/commits{/sha}","comments_url":"https://api.github.com/repos/nest/nest-simulator/comments{/number}","issue_comment_url":"https://api.github.com/repos/nest/nest-simulator/issues/comments{/number}","contents_url":"https://api.github.com/repos/nest/nest-simulator/contents/{+path}","compare_url":"https://api.github.com/repos/nest/nest-simulator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nest/nest-simulator/merges","archive_url":"https://api.github.com/repos/nest/nest-simulator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nest/nest-simulator/downloads","issues_url":"https://api.github.com/repos/nest/nest-simulator/issues{/number}","pulls_url":"https://api.github.com/repos/nest/nest-simulator/pulls{/number}","milestones_url":"https://api.github.com/repos/nest/nest-simulator/milestones{/number}","notifications_url":"https://api.github.com/repos/nest/nest-simulator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nest/nest-simulator/labels{/name}","releases_url":"https://api.github.com/repos/nest/nest-simulator/releases{/id}","deployments_url":"https://api.github.com/repos/nest/nest-simulator/deployments","created_at":"2015-04-14T13:39:12Z","updated_at":"2016-09-30T00:55:47Z","pushed_at":"2016-10-05T07:09:27Z","git_url":"git://github.com/nest/nest-simulator.git","ssh_url":"git@github.com:nest/nest-simulator.git","clone_url":"https://github.com/nest/nest-simulator.git","svn_url":"https://github.com/nest/nest-simulator","homepage":null,"size":33510,"stargazers_count":87,"watchers_count":87,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":87,"mirror_url":null,"open_issues_count":156,"forks":87,"open_issues":156,"watchers":87,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nest/nest-simulator/pulls/474"},"html":{"href":"https://github.com/nest/nest-simulator/pull/474"},"issue":{"href":"https://api.github.com/repos/nest/nest-simulator/issues/474"},"comments":{"href":"https://api.github.com/repos/nest/nest-simulator/issues/474/comments"},"review_comments":{"href":"https://api.github.com/repos/nest/nest-simulator/pulls/474/comments"},"review_comment":{"href":"https://api.github.com/repos/nest/nest-simulator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nest/nest-simulator/pulls/474/commits"},"statuses":{"href":"https://api.github.com/repos/nest/nest-simulator/statuses/87ee81cabc9566e8fe128170ccedefff4d375068"}}}}
{"actor":{"display_login":"heplesser"}}