{"action":"created","issue":{"url":"https://api.github.com/repos/zencart/zencart/issues/1315","repository_url":"https://api.github.com/repos/zencart/zencart","labels_url":"https://api.github.com/repos/zencart/zencart/issues/1315/labels{/name}","comments_url":"https://api.github.com/repos/zencart/zencart/issues/1315/comments","events_url":"https://api.github.com/repos/zencart/zencart/issues/1315/events","html_url":"https://github.com/zencart/zencart/issues/1315","id":182899945,"number":1315,"title":"Align the \"query\" and \"cart\" methods in the order class","user":{"login":"lat9","id":2685585,"avatar_url":"https://avatars.githubusercontent.com/u/2685585?v=3","gravatar_id":"","url":"https://api.github.com/users/lat9","html_url":"https://github.com/lat9","followers_url":"https://api.github.com/users/lat9/followers","following_url":"https://api.github.com/users/lat9/following{/other_user}","gists_url":"https://api.github.com/users/lat9/gists{/gist_id}","starred_url":"https://api.github.com/users/lat9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lat9/subscriptions","organizations_url":"https://api.github.com/users/lat9/orgs","repos_url":"https://api.github.com/users/lat9/repos","events_url":"https://api.github.com/users/lat9/events{/privacy}","received_events_url":"https://api.github.com/users/lat9/received_events","type":"User","site_admin":false},"labels":[{"id":113585429,"url":"https://api.github.com/repos/zencart/zencart/labels/[Issue%20Type]%20refactoring/optimizing","name":"[Issue Type] refactoring/optimizing","color":"f9d0c4","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/zencart/zencart/milestones/1","html_url":"https://github.com/zencart/zencart/milestones/v1.6.0","labels_url":"https://api.github.com/repos/zencart/zencart/milestones/1/labels","id":487388,"number":1,"title":"v1.6.0","description":"","creator":{"login":"drbyte","id":404472,"avatar_url":"https://avatars.githubusercontent.com/u/404472?v=3","gravatar_id":"","url":"https://api.github.com/users/drbyte","html_url":"https://github.com/drbyte","followers_url":"https://api.github.com/users/drbyte/followers","following_url":"https://api.github.com/users/drbyte/following{/other_user}","gists_url":"https://api.github.com/users/drbyte/gists{/gist_id}","starred_url":"https://api.github.com/users/drbyte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drbyte/subscriptions","organizations_url":"https://api.github.com/users/drbyte/orgs","repos_url":"https://api.github.com/users/drbyte/repos","events_url":"https://api.github.com/users/drbyte/events{/privacy}","received_events_url":"https://api.github.com/users/drbyte/received_events","type":"User","site_admin":false},"open_issues":26,"closed_issues":186,"state":"open","created_at":"2013-11-17T03:11:42Z","updated_at":"2016-11-17T19:19:34Z","due_on":null,"closed_at":null},"comments":9,"created_at":"2016-10-13T21:01:27Z","updated_at":"2016-11-30T03:46:06Z","closed_at":null,"body":"Question about differences between admin/storefront orders.php class query function:\n\nI've seen that the two classes will be combined (yeah!) in 1.6.0, but is there a reason why the admin version's `totals` array contains the floating-point value and the storefront one doesn't?\n"},"comment":{"url":"https://api.github.com/repos/zencart/zencart/issues/comments/263775677","html_url":"https://github.com/zencart/zencart/issues/1315#issuecomment-263775677","issue_url":"https://api.github.com/repos/zencart/zencart/issues/1315","id":263775677,"user":{"login":"drbyte","id":404472,"avatar_url":"https://avatars.githubusercontent.com/u/404472?v=3","gravatar_id":"","url":"https://api.github.com/users/drbyte","html_url":"https://github.com/drbyte","followers_url":"https://api.github.com/users/drbyte/followers","following_url":"https://api.github.com/users/drbyte/following{/other_user}","gists_url":"https://api.github.com/users/drbyte/gists{/gist_id}","starred_url":"https://api.github.com/users/drbyte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drbyte/subscriptions","organizations_url":"https://api.github.com/users/drbyte/orgs","repos_url":"https://api.github.com/users/drbyte/repos","events_url":"https://api.github.com/users/drbyte/events{/privacy}","received_events_url":"https://api.github.com/users/drbyte/received_events","type":"User","site_admin":false},"created_at":"2016-11-30T03:46:06Z","updated_at":"2016-11-30T03:46:06Z","body":"@lat9 wrote:\r\n> Question about differences between admin/storefront orders.php class query function:\r\n\r\n> I've seen that the two classes will be combined (yeah!) in 1.6.0, but is there a reason why the admin version's totals array contains the floating-point value and the storefront one doesn't?\r\n\r\n>  It's just been kicking my butt with Edit Orders, where the storefront version of the class is used but the value is \"expected\".\r\n\r\n> For 1.6.0, other than the create function which pushes the order to the database, are all versions (whether via query or cart) of the order-class output going to \"look\" the same?\r\n\r\n\r\nI was just looking through the code trying to find disparity on this, but it appears the `order_total` code deals with `value` and `text` the same for both `create` and `query`.\r\n\r\n"}}
{"actor":{"display_login":"drbyte"}}