{"action":"created","comment":{"url":"https://api.github.com/repos/symfony/symfony/pulls/comments/56491078","id":56491078,"diff_hunk":"@@ -121,7 +124,7 @@ public function onKernelResponse(FilterResponseEvent $event)\n         $request = $event->getRequest();\n         $session = $request->getSession();\n \n-        if ((null === $token = $this->tokenStorage->getToken()) || ($token instanceof AnonymousToken)) {\n+        if ((null === $token = $this->tokenStorage->getToken()) || ($this->trustResolver->isAnonymous($token))) {","path":"src/Symfony/Component/Security/Http/Firewall/ContextListener.php","position":null,"original_position":34,"commit_id":"225180b6a34745290bf61e1b8ba64219efcc3565","original_commit_id":"a6956526b8d97aa158b97f3f007504cecbaec12a","user":{"login":"WouterJ","id":749025,"avatar_url":"https://avatars.githubusercontent.com/u/749025?v=3","gravatar_id":"","url":"https://api.github.com/users/WouterJ","html_url":"https://github.com/WouterJ","followers_url":"https://api.github.com/users/WouterJ/followers","following_url":"https://api.github.com/users/WouterJ/following{/other_user}","gists_url":"https://api.github.com/users/WouterJ/gists{/gist_id}","starred_url":"https://api.github.com/users/WouterJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WouterJ/subscriptions","organizations_url":"https://api.github.com/users/WouterJ/orgs","repos_url":"https://api.github.com/users/WouterJ/repos","events_url":"https://api.github.com/users/WouterJ/events{/privacy}","received_events_url":"https://api.github.com/users/WouterJ/received_events","type":"User","site_admin":false},"body":"done","created_at":"2016-03-17T11:43:55Z","updated_at":"2016-03-17T11:43:55Z","html_url":"https://github.com/symfony/symfony/pull/18211#discussion_r56491078","pull_request_url":"https://api.github.com/repos/symfony/symfony/pulls/18211","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/56491078"},"html":{"href":"https://github.com/symfony/symfony/pull/18211#discussion_r56491078"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony/pulls/18211"}}},"pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/18211","id":63191205,"html_url":"https://github.com/symfony/symfony/pull/18211","diff_url":"https://github.com/symfony/symfony/pull/18211.diff","patch_url":"https://github.com/symfony/symfony/pull/18211.patch","issue_url":"https://api.github.com/repos/symfony/symfony/issues/18211","number":18211,"state":"open","locked":false,"title":"[Security] Use auth trust resolver to determine anonymous in ContextListener","user":{"login":"WouterJ","id":749025,"avatar_url":"https://avatars.githubusercontent.com/u/749025?v=3","gravatar_id":"","url":"https://api.github.com/users/WouterJ","html_url":"https://github.com/WouterJ","followers_url":"https://api.github.com/users/WouterJ/followers","following_url":"https://api.github.com/users/WouterJ/following{/other_user}","gists_url":"https://api.github.com/users/WouterJ/gists{/gist_id}","starred_url":"https://api.github.com/users/WouterJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WouterJ/subscriptions","organizations_url":"https://api.github.com/users/WouterJ/orgs","repos_url":"https://api.github.com/users/WouterJ/repos","events_url":"https://api.github.com/users/WouterJ/events{/privacy}","received_events_url":"https://api.github.com/users/WouterJ/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Branch?       | master\r\n| Bug fix?      | no\r\n| New feature?  | yes\r\n| BC breaks?    | no\r\n| Deprecations? | no\r\n| Tests pass?   | yes\r\n| Fixed tickets | -\r\n| License       | MIT\r\n| Doc PR        | not done yet\r\n\r\nThere is a nice class in Symfony that is used to check whether a token is anonymously: `AuthenticationTrustResolver`. However, its logic was still hard coded in the `ContextListener`, making it impossible to customize it (e.g. using another anonymous token class). I think it makes lots of sense to use the dedicated class.","created_at":"2016-03-17T09:05:29Z","updated_at":"2016-03-17T11:43:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4914c00c75df2e784429d9e4dfa82bc15e6bfdb2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/symfony/symfony/pulls/18211/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony/pulls/18211/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/18211/comments","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/225180b6a34745290bf61e1b8ba64219efcc3565","head":{"label":"WouterJ:security-remember_me_trust_resolver","ref":"security-remember_me_trust_resolver","sha":"225180b6a34745290bf61e1b8ba64219efcc3565","user":{"login":"WouterJ","id":749025,"avatar_url":"https://avatars.githubusercontent.com/u/749025?v=3","gravatar_id":"","url":"https://api.github.com/users/WouterJ","html_url":"https://github.com/WouterJ","followers_url":"https://api.github.com/users/WouterJ/followers","following_url":"https://api.github.com/users/WouterJ/following{/other_user}","gists_url":"https://api.github.com/users/WouterJ/gists{/gist_id}","starred_url":"https://api.github.com/users/WouterJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WouterJ/subscriptions","organizations_url":"https://api.github.com/users/WouterJ/orgs","repos_url":"https://api.github.com/users/WouterJ/repos","events_url":"https://api.github.com/users/WouterJ/events{/privacy}","received_events_url":"https://api.github.com/users/WouterJ/received_events","type":"User","site_admin":false},"repo":{"id":5615183,"name":"symfony","full_name":"WouterJ/symfony","owner":{"login":"WouterJ","id":749025,"avatar_url":"https://avatars.githubusercontent.com/u/749025?v=3","gravatar_id":"","url":"https://api.github.com/users/WouterJ","html_url":"https://github.com/WouterJ","followers_url":"https://api.github.com/users/WouterJ/followers","following_url":"https://api.github.com/users/WouterJ/following{/other_user}","gists_url":"https://api.github.com/users/WouterJ/gists{/gist_id}","starred_url":"https://api.github.com/users/WouterJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WouterJ/subscriptions","organizations_url":"https://api.github.com/users/WouterJ/orgs","repos_url":"https://api.github.com/users/WouterJ/repos","events_url":"https://api.github.com/users/WouterJ/events{/privacy}","received_events_url":"https://api.github.com/users/WouterJ/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/WouterJ/symfony","description":"The Symfony2 PHP framework","fork":true,"url":"https://api.github.com/repos/WouterJ/symfony","forks_url":"https://api.github.com/repos/WouterJ/symfony/forks","keys_url":"https://api.github.com/repos/WouterJ/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WouterJ/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WouterJ/symfony/teams","hooks_url":"https://api.github.com/repos/WouterJ/symfony/hooks","issue_events_url":"https://api.github.com/repos/WouterJ/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/WouterJ/symfony/events","assignees_url":"https://api.github.com/repos/WouterJ/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/WouterJ/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/WouterJ/symfony/tags","blobs_url":"https://api.github.com/repos/WouterJ/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WouterJ/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WouterJ/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/WouterJ/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WouterJ/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/WouterJ/symfony/languages","stargazers_url":"https://api.github.com/repos/WouterJ/symfony/stargazers","contributors_url":"https://api.github.com/repos/WouterJ/symfony/contributors","subscribers_url":"https://api.github.com/repos/WouterJ/symfony/subscribers","subscription_url":"https://api.github.com/repos/WouterJ/symfony/subscription","commits_url":"https://api.github.com/repos/WouterJ/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/WouterJ/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/WouterJ/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/WouterJ/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/WouterJ/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/WouterJ/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WouterJ/symfony/merges","archive_url":"https://api.github.com/repos/WouterJ/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WouterJ/symfony/downloads","issues_url":"https://api.github.com/repos/WouterJ/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/WouterJ/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/WouterJ/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/WouterJ/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WouterJ/symfony/labels{/name}","releases_url":"https://api.github.com/repos/WouterJ/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/WouterJ/symfony/deployments","created_at":"2012-08-30T13:24:57Z","updated_at":"2014-08-16T18:38:32Z","pushed_at":"2016-03-17T11:43:46Z","git_url":"git://github.com/WouterJ/symfony.git","ssh_url":"git@github.com:WouterJ/symfony.git","clone_url":"https://github.com/WouterJ/symfony.git","svn_url":"https://github.com/WouterJ/symfony","homepage":"symfony.com","size":69641,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"symfony:master","ref":"master","sha":"83ebf97df3a65199ce9ee218d176758104f2ac23","user":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":458058,"name":"symfony","full_name":"symfony/symfony","owner":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony/symfony","description":"The Symfony PHP framework","fork":false,"url":"https://api.github.com/repos/symfony/symfony","forks_url":"https://api.github.com/repos/symfony/symfony/forks","keys_url":"https://api.github.com/repos/symfony/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony/teams","hooks_url":"https://api.github.com/repos/symfony/symfony/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony/events","assignees_url":"https://api.github.com/repos/symfony/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony/tags","blobs_url":"https://api.github.com/repos/symfony/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony/subscription","commits_url":"https://api.github.com/repos/symfony/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony/merges","archive_url":"https://api.github.com/repos/symfony/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony/downloads","issues_url":"https://api.github.com/repos/symfony/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/symfony/symfony/deployments","created_at":"2010-01-04T14:21:21Z","updated_at":"2016-03-17T09:47:07Z","pushed_at":"2016-03-17T11:43:47Z","git_url":"git://github.com/symfony/symfony.git","ssh_url":"git@github.com:symfony/symfony.git","clone_url":"https://github.com/symfony/symfony.git","svn_url":"https://github.com/symfony/symfony","homepage":"symfony.com","size":104393,"stargazers_count":11940,"watchers_count":11940,"language":"PHP","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":4705,"mirror_url":null,"open_issues_count":707,"forks":4705,"open_issues":707,"watchers":11940,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/18211"},"html":{"href":"https://github.com/symfony/symfony/pull/18211"},"issue":{"href":"https://api.github.com/repos/symfony/symfony/issues/18211"},"comments":{"href":"https://api.github.com/repos/symfony/symfony/issues/18211/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony/pulls/18211/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony/pulls/18211/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony/statuses/225180b6a34745290bf61e1b8ba64219efcc3565"}}}}