{"action":"closed","number":7722,"pull_request":{"url":"https://api.github.com/repos/spring-projects/spring-boot/pulls/7722","id":98997415,"html_url":"https://github.com/spring-projects/spring-boot/pull/7722","diff_url":"https://github.com/spring-projects/spring-boot/pull/7722.diff","patch_url":"https://github.com/spring-projects/spring-boot/pull/7722.patch","issue_url":"https://api.github.com/repos/spring-projects/spring-boot/issues/7722","number":7722,"state":"closed","locked":false,"title":"Refactoring for Spring Integration Metrics","user":{"login":"artembilan","id":1071590,"avatar_url":"https://avatars.githubusercontent.com/u/1071590?v=3","gravatar_id":"","url":"https://api.github.com/users/artembilan","html_url":"https://github.com/artembilan","followers_url":"https://api.github.com/users/artembilan/followers","following_url":"https://api.github.com/users/artembilan/following{/other_user}","gists_url":"https://api.github.com/users/artembilan/gists{/gist_id}","starred_url":"https://api.github.com/users/artembilan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artembilan/subscriptions","organizations_url":"https://api.github.com/users/artembilan/orgs","repos_url":"https://api.github.com/users/artembilan/repos","events_url":"https://api.github.com/users/artembilan/events{/privacy}","received_events_url":"https://api.github.com/users/artembilan/received_events","type":"User","site_admin":false},"body":"Starting with Spring Integration `4.3.6` we don't need SI-JMX any more to enable `MessageChannel`, `MessageHandler` and `MessageSource` metrics\r\n\r\n* Add `IntegrationManagementConfiguration` conditional auto-configuration to provide `@EnableIntegrationManagement` when JMX is `enabled` or there is no `IntegrationManagementConfigurer.MANAGEMENT_CONFIGURER_NAME` bean.\r\nBy default this bean doesn't exist and you explicitly should declare it (e.g. via `@EnableIntegrationManagement`) if you would like to collect metrics.\r\nBut at the same time Spring Integration enables it when JMX management is present.\r\nThat is a purpose of that new `IntegrationManagementConfiguration`\r\n* Change `SpringIntegrationMetricReader` to read metrics from the `IntegrationManagementConfigurer`, not `IntegrationMBeanExporter`\r\n* Change `PublicMetricsAutoConfiguration` to register `IntegrationManagementConfigurer.MANAGEMENT_CONFIGURER_NAME` bean if not present.\r\nSince we are here in `actuator`, therefore we are interested in the metrics for SI as well\r\n* Since we don't need JMX for the metrics any more, remove SI-JMX dependency from the `spring-boot-starter-integration`\r\n\r\n**Cherry-pick to master**","created_at":"2016-12-21T20:14:40Z","updated_at":"2016-12-22T06:33:12Z","closed_at":"2016-12-22T06:33:12Z","merged_at":null,"merge_commit_sha":"b1ee78e6e837a75cf287667a39944c3f3e7dd889","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/spring-projects/spring-boot/milestones/69","html_url":"https://github.com/spring-projects/spring-boot/milestone/69","labels_url":"https://api.github.com/repos/spring-projects/spring-boot/milestones/69/labels","id":1786365,"number":69,"title":"1.5.0 RC1","description":"","creator":{"login":"philwebb","id":519772,"avatar_url":"https://avatars.githubusercontent.com/u/519772?v=3","gravatar_id":"","url":"https://api.github.com/users/philwebb","html_url":"https://github.com/philwebb","followers_url":"https://api.github.com/users/philwebb/followers","following_url":"https://api.github.com/users/philwebb/following{/other_user}","gists_url":"https://api.github.com/users/philwebb/gists{/gist_id}","starred_url":"https://api.github.com/users/philwebb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philwebb/subscriptions","organizations_url":"https://api.github.com/users/philwebb/orgs","repos_url":"https://api.github.com/users/philwebb/repos","events_url":"https://api.github.com/users/philwebb/events{/privacy}","received_events_url":"https://api.github.com/users/philwebb/received_events","type":"User","site_admin":false},"open_issues":33,"closed_issues":145,"state":"open","created_at":"2016-05-25T01:02:30Z","updated_at":"2016-12-22T06:33:12Z","due_on":"2017-01-04T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/spring-projects/spring-boot/pulls/7722/commits","review_comments_url":"https://api.github.com/repos/spring-projects/spring-boot/pulls/7722/comments","review_comment_url":"https://api.github.com/repos/spring-projects/spring-boot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spring-projects/spring-boot/issues/7722/comments","statuses_url":"https://api.github.com/repos/spring-projects/spring-boot/statuses/851f38bd24b50fb996cf350360e27f66e11b4cba","head":{"label":"artembilan:IntegrationManagement","ref":"IntegrationManagement","sha":"851f38bd24b50fb996cf350360e27f66e11b4cba","user":{"login":"artembilan","id":1071590,"avatar_url":"https://avatars.githubusercontent.com/u/1071590?v=3","gravatar_id":"","url":"https://api.github.com/users/artembilan","html_url":"https://github.com/artembilan","followers_url":"https://api.github.com/users/artembilan/followers","following_url":"https://api.github.com/users/artembilan/following{/other_user}","gists_url":"https://api.github.com/users/artembilan/gists{/gist_id}","starred_url":"https://api.github.com/users/artembilan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artembilan/subscriptions","organizations_url":"https://api.github.com/users/artembilan/orgs","repos_url":"https://api.github.com/users/artembilan/repos","events_url":"https://api.github.com/users/artembilan/events{/privacy}","received_events_url":"https://api.github.com/users/artembilan/received_events","type":"User","site_admin":false},"repo":{"id":15391150,"name":"spring-boot","full_name":"artembilan/spring-boot","owner":{"login":"artembilan","id":1071590,"avatar_url":"https://avatars.githubusercontent.com/u/1071590?v=3","gravatar_id":"","url":"https://api.github.com/users/artembilan","html_url":"https://github.com/artembilan","followers_url":"https://api.github.com/users/artembilan/followers","following_url":"https://api.github.com/users/artembilan/following{/other_user}","gists_url":"https://api.github.com/users/artembilan/gists{/gist_id}","starred_url":"https://api.github.com/users/artembilan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artembilan/subscriptions","organizations_url":"https://api.github.com/users/artembilan/orgs","repos_url":"https://api.github.com/users/artembilan/repos","events_url":"https://api.github.com/users/artembilan/events{/privacy}","received_events_url":"https://api.github.com/users/artembilan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/artembilan/spring-boot","description":"Spring Boot","fork":true,"url":"https://api.github.com/repos/artembilan/spring-boot","forks_url":"https://api.github.com/repos/artembilan/spring-boot/forks","keys_url":"https://api.github.com/repos/artembilan/spring-boot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/artembilan/spring-boot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/artembilan/spring-boot/teams","hooks_url":"https://api.github.com/repos/artembilan/spring-boot/hooks","issue_events_url":"https://api.github.com/repos/artembilan/spring-boot/issues/events{/number}","events_url":"https://api.github.com/repos/artembilan/spring-boot/events","assignees_url":"https://api.github.com/repos/artembilan/spring-boot/assignees{/user}","branches_url":"https://api.github.com/repos/artembilan/spring-boot/branches{/branch}","tags_url":"https://api.github.com/repos/artembilan/spring-boot/tags","blobs_url":"https://api.github.com/repos/artembilan/spring-boot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/artembilan/spring-boot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/artembilan/spring-boot/git/refs{/sha}","trees_url":"https://api.github.com/repos/artembilan/spring-boot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/artembilan/spring-boot/statuses/{sha}","languages_url":"https://api.github.com/repos/artembilan/spring-boot/languages","stargazers_url":"https://api.github.com/repos/artembilan/spring-boot/stargazers","contributors_url":"https://api.github.com/repos/artembilan/spring-boot/contributors","subscribers_url":"https://api.github.com/repos/artembilan/spring-boot/subscribers","subscription_url":"https://api.github.com/repos/artembilan/spring-boot/subscription","commits_url":"https://api.github.com/repos/artembilan/spring-boot/commits{/sha}","git_commits_url":"https://api.github.com/repos/artembilan/spring-boot/git/commits{/sha}","comments_url":"https://api.github.com/repos/artembilan/spring-boot/comments{/number}","issue_comment_url":"https://api.github.com/repos/artembilan/spring-boot/issues/comments{/number}","contents_url":"https://api.github.com/repos/artembilan/spring-boot/contents/{+path}","compare_url":"https://api.github.com/repos/artembilan/spring-boot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/artembilan/spring-boot/merges","archive_url":"https://api.github.com/repos/artembilan/spring-boot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/artembilan/spring-boot/downloads","issues_url":"https://api.github.com/repos/artembilan/spring-boot/issues{/number}","pulls_url":"https://api.github.com/repos/artembilan/spring-boot/pulls{/number}","milestones_url":"https://api.github.com/repos/artembilan/spring-boot/milestones{/number}","notifications_url":"https://api.github.com/repos/artembilan/spring-boot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/artembilan/spring-boot/labels{/name}","releases_url":"https://api.github.com/repos/artembilan/spring-boot/releases{/id}","deployments_url":"https://api.github.com/repos/artembilan/spring-boot/deployments","created_at":"2013-12-23T08:37:02Z","updated_at":"2015-06-24T01:42:25Z","pushed_at":"2016-12-21T22:12:58Z","git_url":"git://github.com/artembilan/spring-boot.git","ssh_url":"git@github.com:artembilan/spring-boot.git","clone_url":"https://github.com/artembilan/spring-boot.git","svn_url":"https://github.com/artembilan/spring-boot","homepage":"","size":41863,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spring-projects:1.5.x","ref":"1.5.x","sha":"33a655791c26e417fc89843ea742df46d95b2aea","user":{"login":"spring-projects","id":317776,"avatar_url":"https://avatars.githubusercontent.com/u/317776?v=3","gravatar_id":"","url":"https://api.github.com/users/spring-projects","html_url":"https://github.com/spring-projects","followers_url":"https://api.github.com/users/spring-projects/followers","following_url":"https://api.github.com/users/spring-projects/following{/other_user}","gists_url":"https://api.github.com/users/spring-projects/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-projects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-projects/subscriptions","organizations_url":"https://api.github.com/users/spring-projects/orgs","repos_url":"https://api.github.com/users/spring-projects/repos","events_url":"https://api.github.com/users/spring-projects/events{/privacy}","received_events_url":"https://api.github.com/users/spring-projects/received_events","type":"Organization","site_admin":false},"repo":{"id":6296790,"name":"spring-boot","full_name":"spring-projects/spring-boot","owner":{"login":"spring-projects","id":317776,"avatar_url":"https://avatars.githubusercontent.com/u/317776?v=3","gravatar_id":"","url":"https://api.github.com/users/spring-projects","html_url":"https://github.com/spring-projects","followers_url":"https://api.github.com/users/spring-projects/followers","following_url":"https://api.github.com/users/spring-projects/following{/other_user}","gists_url":"https://api.github.com/users/spring-projects/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-projects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-projects/subscriptions","organizations_url":"https://api.github.com/users/spring-projects/orgs","repos_url":"https://api.github.com/users/spring-projects/repos","events_url":"https://api.github.com/users/spring-projects/events{/privacy}","received_events_url":"https://api.github.com/users/spring-projects/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spring-projects/spring-boot","description":"Spring Boot","fork":false,"url":"https://api.github.com/repos/spring-projects/spring-boot","forks_url":"https://api.github.com/repos/spring-projects/spring-boot/forks","keys_url":"https://api.github.com/repos/spring-projects/spring-boot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spring-projects/spring-boot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spring-projects/spring-boot/teams","hooks_url":"https://api.github.com/repos/spring-projects/spring-boot/hooks","issue_events_url":"https://api.github.com/repos/spring-projects/spring-boot/issues/events{/number}","events_url":"https://api.github.com/repos/spring-projects/spring-boot/events","assignees_url":"https://api.github.com/repos/spring-projects/spring-boot/assignees{/user}","branches_url":"https://api.github.com/repos/spring-projects/spring-boot/branches{/branch}","tags_url":"https://api.github.com/repos/spring-projects/spring-boot/tags","blobs_url":"https://api.github.com/repos/spring-projects/spring-boot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spring-projects/spring-boot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spring-projects/spring-boot/git/refs{/sha}","trees_url":"https://api.github.com/repos/spring-projects/spring-boot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spring-projects/spring-boot/statuses/{sha}","languages_url":"https://api.github.com/repos/spring-projects/spring-boot/languages","stargazers_url":"https://api.github.com/repos/spring-projects/spring-boot/stargazers","contributors_url":"https://api.github.com/repos/spring-projects/spring-boot/contributors","subscribers_url":"https://api.github.com/repos/spring-projects/spring-boot/subscribers","subscription_url":"https://api.github.com/repos/spring-projects/spring-boot/subscription","commits_url":"https://api.github.com/repos/spring-projects/spring-boot/commits{/sha}","git_commits_url":"https://api.github.com/repos/spring-projects/spring-boot/git/commits{/sha}","comments_url":"https://api.github.com/repos/spring-projects/spring-boot/comments{/number}","issue_comment_url":"https://api.github.com/repos/spring-projects/spring-boot/issues/comments{/number}","contents_url":"https://api.github.com/repos/spring-projects/spring-boot/contents/{+path}","compare_url":"https://api.github.com/repos/spring-projects/spring-boot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spring-projects/spring-boot/merges","archive_url":"https://api.github.com/repos/spring-projects/spring-boot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spring-projects/spring-boot/downloads","issues_url":"https://api.github.com/repos/spring-projects/spring-boot/issues{/number}","pulls_url":"https://api.github.com/repos/spring-projects/spring-boot/pulls{/number}","milestones_url":"https://api.github.com/repos/spring-projects/spring-boot/milestones{/number}","notifications_url":"https://api.github.com/repos/spring-projects/spring-boot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spring-projects/spring-boot/labels{/name}","releases_url":"https://api.github.com/repos/spring-projects/spring-boot/releases{/id}","deployments_url":"https://api.github.com/repos/spring-projects/spring-boot/deployments","created_at":"2012-10-19T15:02:57Z","updated_at":"2016-12-22T05:47:35Z","pushed_at":"2016-12-22T06:33:03Z","git_url":"git://github.com/spring-projects/spring-boot.git","ssh_url":"git@github.com:spring-projects/spring-boot.git","clone_url":"https://github.com/spring-projects/spring-boot.git","svn_url":"https://github.com/spring-projects/spring-boot","homepage":"http://projects.spring.io/spring-boot","size":45130,"stargazers_count":9122,"watchers_count":9122,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":8757,"mirror_url":null,"open_issues_count":628,"forks":8757,"open_issues":628,"watchers":9122,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spring-projects/spring-boot/pulls/7722"},"html":{"href":"https://github.com/spring-projects/spring-boot/pull/7722"},"issue":{"href":"https://api.github.com/repos/spring-projects/spring-boot/issues/7722"},"comments":{"href":"https://api.github.com/repos/spring-projects/spring-boot/issues/7722/comments"},"review_comments":{"href":"https://api.github.com/repos/spring-projects/spring-boot/pulls/7722/comments"},"review_comment":{"href":"https://api.github.com/repos/spring-projects/spring-boot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spring-projects/spring-boot/pulls/7722/commits"},"statuses":{"href":"https://api.github.com/repos/spring-projects/spring-boot/statuses/851f38bd24b50fb996cf350360e27f66e11b4cba"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":151,"deletions":62,"changed_files":9}}
{"actor":{"display_login":"philwebb"}}