{"action":"opened","number":829,"pull_request":{"url":"https://api.github.com/repos/vmware/docker-volume-vsphere/pulls/829","id":98418920,"html_url":"https://github.com/vmware/docker-volume-vsphere/pull/829","diff_url":"https://github.com/vmware/docker-volume-vsphere/pull/829.diff","patch_url":"https://github.com/vmware/docker-volume-vsphere/pull/829.patch","issue_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/issues/829","number":829,"state":"open","locked":false,"title":"A trivial fix for supporting volume size in KB","user":{"login":"shuklanirdesh82","id":22988730,"avatar_url":"https://avatars.githubusercontent.com/u/22988730?v=3","gravatar_id":"","url":"https://api.github.com/users/shuklanirdesh82","html_url":"https://github.com/shuklanirdesh82","followers_url":"https://api.github.com/users/shuklanirdesh82/followers","following_url":"https://api.github.com/users/shuklanirdesh82/following{/other_user}","gists_url":"https://api.github.com/users/shuklanirdesh82/gists{/gist_id}","starred_url":"https://api.github.com/users/shuklanirdesh82/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shuklanirdesh82/subscriptions","organizations_url":"https://api.github.com/users/shuklanirdesh82/orgs","repos_url":"https://api.github.com/users/shuklanirdesh82/repos","events_url":"https://api.github.com/users/shuklanirdesh82/events{/privacy}","received_events_url":"https://api.github.com/users/shuklanirdesh82/received_events","type":"User","site_admin":false},"body":"Currently our driver is silently ignoring the value passed in KB and coverts into MB due a bug in covert.py: this PR is proposed to handle -o size parameter correctly while passing the input in KB.\r\n\r\nTesting done: Yes (see below)\r\n\r\ntested the proposed code with following volume creation commands:\r\n\r\n```\r\nroot@photon-EHiCjpUvt [ ~ ]# docker volume create --driver=vmdk --name=MyVol8 -o size=4000kb\r\nMyVol8\r\nroot@photon-EHiCjpUvt [ ~ ]# docker volume create --driver=vmdk --name=MyVol9 -o size=2000kb\r\nMyVol9\r\nroot@photon-EHiCjpUvt [ ~ ]# docker volume create --driver=vmdk --name=MyVol10 -o size=1100kb\r\nMyVol10\r\n```\r\n\r\n```\r\n[root@promc-2n-dhcp105-97:~] /usr/lib/vmware/vmdkops/bin/vmdkops_admin.py ls\r\nVolume   Datastore       Created By VM  Created                   Attached To VM  Policy  Capacity   Used      Disk Format  Filesystem Type  Access      Attach As               \r\n-------  --------------  -------------  ------------------------  --------------  ------  ---------  --------  -----------  ---------------  ----------  ----------------------  \r\nMyVol8   TestDatastore1  photon2        Fri Dec 16 23:03:49 2016  detached        N/A     3.00MB     3.00MB    thin         ext4             read-write  independent_persistent  \r\nMyVol9   TestDatastore1  photon2        Fri Dec 16 23:05:01 2016  detached        N/A     1.00MB     2.00MB    thin         ext4             read-write  independent_persistent  \r\nMyVol10  TestDatastore1  photon2        Fri Dec 16 23:05:26 2016  detached        N/A     1.00MB     2.00MB    thin         ext4             read-write  independent_persistent  \r\n```\r\n\r\nwhile working on this PR came to know about the limitation from the ESX server that we can't create vmdk < 1024 KB going to file a separate issue to initiate the discussion for the same.\r\n\r\n/CC: @ashahi1 ","created_at":"2016-12-16T23:18:39Z","updated_at":"2016-12-16T23:18:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":{"login":"shuklanirdesh82","id":22988730,"avatar_url":"https://avatars.githubusercontent.com/u/22988730?v=3","gravatar_id":"","url":"https://api.github.com/users/shuklanirdesh82","html_url":"https://github.com/shuklanirdesh82","followers_url":"https://api.github.com/users/shuklanirdesh82/followers","following_url":"https://api.github.com/users/shuklanirdesh82/following{/other_user}","gists_url":"https://api.github.com/users/shuklanirdesh82/gists{/gist_id}","starred_url":"https://api.github.com/users/shuklanirdesh82/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shuklanirdesh82/subscriptions","organizations_url":"https://api.github.com/users/shuklanirdesh82/orgs","repos_url":"https://api.github.com/users/shuklanirdesh82/repos","events_url":"https://api.github.com/users/shuklanirdesh82/events{/privacy}","received_events_url":"https://api.github.com/users/shuklanirdesh82/received_events","type":"User","site_admin":false},"assignees":[{"login":"shuklanirdesh82","id":22988730,"avatar_url":"https://avatars.githubusercontent.com/u/22988730?v=3","gravatar_id":"","url":"https://api.github.com/users/shuklanirdesh82","html_url":"https://github.com/shuklanirdesh82","followers_url":"https://api.github.com/users/shuklanirdesh82/followers","following_url":"https://api.github.com/users/shuklanirdesh82/following{/other_user}","gists_url":"https://api.github.com/users/shuklanirdesh82/gists{/gist_id}","starred_url":"https://api.github.com/users/shuklanirdesh82/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shuklanirdesh82/subscriptions","organizations_url":"https://api.github.com/users/shuklanirdesh82/orgs","repos_url":"https://api.github.com/users/shuklanirdesh82/repos","events_url":"https://api.github.com/users/shuklanirdesh82/events{/privacy}","received_events_url":"https://api.github.com/users/shuklanirdesh82/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/pulls/829/commits","review_comments_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/pulls/829/comments","review_comment_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/issues/829/comments","statuses_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/statuses/3336235903ffc7db7dd8dfadb8241839fb668b91","head":{"label":"shuklanirdesh82:volSizeInKB_fix.shuklanirdesh82","ref":"volSizeInKB_fix.shuklanirdesh82","sha":"3336235903ffc7db7dd8dfadb8241839fb668b91","user":{"login":"shuklanirdesh82","id":22988730,"avatar_url":"https://avatars.githubusercontent.com/u/22988730?v=3","gravatar_id":"","url":"https://api.github.com/users/shuklanirdesh82","html_url":"https://github.com/shuklanirdesh82","followers_url":"https://api.github.com/users/shuklanirdesh82/followers","following_url":"https://api.github.com/users/shuklanirdesh82/following{/other_user}","gists_url":"https://api.github.com/users/shuklanirdesh82/gists{/gist_id}","starred_url":"https://api.github.com/users/shuklanirdesh82/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shuklanirdesh82/subscriptions","organizations_url":"https://api.github.com/users/shuklanirdesh82/orgs","repos_url":"https://api.github.com/users/shuklanirdesh82/repos","events_url":"https://api.github.com/users/shuklanirdesh82/events{/privacy}","received_events_url":"https://api.github.com/users/shuklanirdesh82/received_events","type":"User","site_admin":false},"repo":{"id":72140364,"name":"docker-volume-vsphere","full_name":"shuklanirdesh82/docker-volume-vsphere","owner":{"login":"shuklanirdesh82","id":22988730,"avatar_url":"https://avatars.githubusercontent.com/u/22988730?v=3","gravatar_id":"","url":"https://api.github.com/users/shuklanirdesh82","html_url":"https://github.com/shuklanirdesh82","followers_url":"https://api.github.com/users/shuklanirdesh82/followers","following_url":"https://api.github.com/users/shuklanirdesh82/following{/other_user}","gists_url":"https://api.github.com/users/shuklanirdesh82/gists{/gist_id}","starred_url":"https://api.github.com/users/shuklanirdesh82/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shuklanirdesh82/subscriptions","organizations_url":"https://api.github.com/users/shuklanirdesh82/orgs","repos_url":"https://api.github.com/users/shuklanirdesh82/repos","events_url":"https://api.github.com/users/shuklanirdesh82/events{/privacy}","received_events_url":"https://api.github.com/users/shuklanirdesh82/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shuklanirdesh82/docker-volume-vsphere","description":"Docker Volume Driver for vSphere.","fork":true,"url":"https://api.github.com/repos/shuklanirdesh82/docker-volume-vsphere","forks_url":"https://api.github.com/repos/shuklanirdesh82/docker-volume-vsphere/forks","keys_url":"https://api.github.com/repos/shuklanirdesh82/docker-volume-vsphere/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shuklanirdesh82/docker-volume-vsphere/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shuklanirdesh82/docker-volume-vsphere/teams","hooks_url":"https://api.github.com/repos/shuklanirdesh82/docker-volume-vsphere/hooks","issue_events_url":"https://api.github.com/repos/shuklanirdesh82/docker-volume-vsphere/issues/events{/number}","events_url":"https://api.github.com/repos/shuklanirdesh82/docker-volume-vsphere/events","assignees_url":"https://api.github.com/repos/shuklanirdesh82/docker-volume-vsphere/assignees{/user}","branches_url":"https://api.github.com/repos/shuklanirdesh82/docker-volume-vsphere/branches{/branch}","tags_url":"https://api.github.com/repos/shuklanirdesh82/docker-volume-vsphere/tags","blobs_url":"https://api.github.com/repos/shuklanirdesh82/docker-volume-vsphere/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shuklanirdesh82/docker-volume-vsphere/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shuklanirdesh82/docker-volume-vsphere/git/refs{/sha}","trees_url":"https://api.github.com/repos/shuklanirdesh82/docker-volume-vsphere/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shuklanirdesh82/docker-volume-vsphere/statuses/{sha}","languages_url":"https://api.github.com/repos/shuklanirdesh82/docker-volume-vsphere/languages","stargazers_url":"https://api.github.com/repos/shuklanirdesh82/docker-volume-vsphere/stargazers","contributors_url":"https://api.github.com/repos/shuklanirdesh82/docker-volume-vsphere/contributors","subscribers_url":"https://api.github.com/repos/shuklanirdesh82/docker-volume-vsphere/subscribers","subscription_url":"https://api.github.com/repos/shuklanirdesh82/docker-volume-vsphere/subscription","commits_url":"https://api.github.com/repos/shuklanirdesh82/docker-volume-vsphere/commits{/sha}","git_commits_url":"https://api.github.com/repos/shuklanirdesh82/docker-volume-vsphere/git/commits{/sha}","comments_url":"https://api.github.com/repos/shuklanirdesh82/docker-volume-vsphere/comments{/number}","issue_comment_url":"https://api.github.com/repos/shuklanirdesh82/docker-volume-vsphere/issues/comments{/number}","contents_url":"https://api.github.com/repos/shuklanirdesh82/docker-volume-vsphere/contents/{+path}","compare_url":"https://api.github.com/repos/shuklanirdesh82/docker-volume-vsphere/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shuklanirdesh82/docker-volume-vsphere/merges","archive_url":"https://api.github.com/repos/shuklanirdesh82/docker-volume-vsphere/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shuklanirdesh82/docker-volume-vsphere/downloads","issues_url":"https://api.github.com/repos/shuklanirdesh82/docker-volume-vsphere/issues{/number}","pulls_url":"https://api.github.com/repos/shuklanirdesh82/docker-volume-vsphere/pulls{/number}","milestones_url":"https://api.github.com/repos/shuklanirdesh82/docker-volume-vsphere/milestones{/number}","notifications_url":"https://api.github.com/repos/shuklanirdesh82/docker-volume-vsphere/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shuklanirdesh82/docker-volume-vsphere/labels{/name}","releases_url":"https://api.github.com/repos/shuklanirdesh82/docker-volume-vsphere/releases{/id}","deployments_url":"https://api.github.com/repos/shuklanirdesh82/docker-volume-vsphere/deployments","created_at":"2016-10-27T19:18:41Z","updated_at":"2016-10-27T19:18:42Z","pushed_at":"2016-12-16T23:10:30Z","git_url":"git://github.com/shuklanirdesh82/docker-volume-vsphere.git","ssh_url":"git@github.com:shuklanirdesh82/docker-volume-vsphere.git","clone_url":"https://github.com/shuklanirdesh82/docker-volume-vsphere.git","svn_url":"https://github.com/shuklanirdesh82/docker-volume-vsphere","homepage":"https://vmware.github.io/docker-volume-vsphere","size":7641,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"vmware:master","ref":"master","sha":"1a47eb816851e8bf71dc9425051368af9fe9ae4a","user":{"login":"vmware","id":473334,"avatar_url":"https://avatars.githubusercontent.com/u/473334?v=3","gravatar_id":"","url":"https://api.github.com/users/vmware","html_url":"https://github.com/vmware","followers_url":"https://api.github.com/users/vmware/followers","following_url":"https://api.github.com/users/vmware/following{/other_user}","gists_url":"https://api.github.com/users/vmware/gists{/gist_id}","starred_url":"https://api.github.com/users/vmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmware/subscriptions","organizations_url":"https://api.github.com/users/vmware/orgs","repos_url":"https://api.github.com/users/vmware/repos","events_url":"https://api.github.com/users/vmware/events{/privacy}","received_events_url":"https://api.github.com/users/vmware/received_events","type":"Organization","site_admin":false},"repo":{"id":49599693,"name":"docker-volume-vsphere","full_name":"vmware/docker-volume-vsphere","owner":{"login":"vmware","id":473334,"avatar_url":"https://avatars.githubusercontent.com/u/473334?v=3","gravatar_id":"","url":"https://api.github.com/users/vmware","html_url":"https://github.com/vmware","followers_url":"https://api.github.com/users/vmware/followers","following_url":"https://api.github.com/users/vmware/following{/other_user}","gists_url":"https://api.github.com/users/vmware/gists{/gist_id}","starred_url":"https://api.github.com/users/vmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmware/subscriptions","organizations_url":"https://api.github.com/users/vmware/orgs","repos_url":"https://api.github.com/users/vmware/repos","events_url":"https://api.github.com/users/vmware/events{/privacy}","received_events_url":"https://api.github.com/users/vmware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vmware/docker-volume-vsphere","description":"vSphere Docker Volume Service","fork":false,"url":"https://api.github.com/repos/vmware/docker-volume-vsphere","forks_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/forks","keys_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/teams","hooks_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/hooks","issue_events_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/issues/events{/number}","events_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/events","assignees_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/assignees{/user}","branches_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/branches{/branch}","tags_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/tags","blobs_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/git/refs{/sha}","trees_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/statuses/{sha}","languages_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/languages","stargazers_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/stargazers","contributors_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/contributors","subscribers_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/subscribers","subscription_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/subscription","commits_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/commits{/sha}","git_commits_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/git/commits{/sha}","comments_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/comments{/number}","issue_comment_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/issues/comments{/number}","contents_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/contents/{+path}","compare_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/merges","archive_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/downloads","issues_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/issues{/number}","pulls_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/pulls{/number}","milestones_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/milestones{/number}","notifications_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/labels{/name}","releases_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/releases{/id}","deployments_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/deployments","created_at":"2016-01-13T20:25:36Z","updated_at":"2016-12-14T16:23:22Z","pushed_at":"2016-12-16T22:18:10Z","git_url":"git://github.com/vmware/docker-volume-vsphere.git","ssh_url":"git@github.com:vmware/docker-volume-vsphere.git","clone_url":"https://github.com/vmware/docker-volume-vsphere.git","svn_url":"https://github.com/vmware/docker-volume-vsphere","homepage":"https://vmware.github.io/docker-volume-vsphere","size":9065,"stargazers_count":93,"watchers_count":93,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":22,"mirror_url":null,"open_issues_count":122,"forks":22,"open_issues":122,"watchers":93,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vmware/docker-volume-vsphere/pulls/829"},"html":{"href":"https://github.com/vmware/docker-volume-vsphere/pull/829"},"issue":{"href":"https://api.github.com/repos/vmware/docker-volume-vsphere/issues/829"},"comments":{"href":"https://api.github.com/repos/vmware/docker-volume-vsphere/issues/829/comments"},"review_comments":{"href":"https://api.github.com/repos/vmware/docker-volume-vsphere/pulls/829/comments"},"review_comment":{"href":"https://api.github.com/repos/vmware/docker-volume-vsphere/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vmware/docker-volume-vsphere/pulls/829/commits"},"statuses":{"href":"https://api.github.com/repos/vmware/docker-volume-vsphere/statuses/3336235903ffc7db7dd8dfadb8241839fb668b91"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":5,"deletions":1,"changed_files":2}}
{"actor":{"display_login":"shuklanirdesh82"}}