{"action":"created","comment":{"url":"https://api.github.com/repos/vsimon/webrtcbuilds/pulls/comments/76372892","id":76372892,"diff_hunk":"@@ -42,10 +42,15 @@ PATH=$DEPOT_TOOLS_DIR:$DEPOT_TOOLS_DIR/python276_bin:$PATH\n mkdir -p $OUTDIR\n OUTDIR=$(readlink -f $OUTDIR)\n \n+# This is a hack to force use of Microsoft Visual C++ 2013.\n+# More sophisticated code would look first for Visual C++ 2015, then 2013.\n+export GYP_MSVS_VERSION='2013'\n+echo GYP_MSVS_VERSION $GYP_MSVS_VERSION\n+\n set-platform\n clean $OUTDIR\n-check::deps $PLATFORM $DEPOT_TOOLS_DIR\n check::depot-tools $PLATFORM $DEPOT_TOOLS_URL $DEPOT_TOOLS_DIR\n+check::deps $PLATFORM $DEPOT_TOOLS_DIR","path":"build.sh","position":13,"original_position":13,"commit_id":"0f3b9c98e49acf157d778c307da2050fafda38da","original_commit_id":"0f3b9c98e49acf157d778c307da2050fafda38da","user":{"login":"vsimon","id":137727,"avatar_url":"https://avatars.githubusercontent.com/u/137727?v=3","gravatar_id":"","url":"https://api.github.com/users/vsimon","html_url":"https://github.com/vsimon","followers_url":"https://api.github.com/users/vsimon/followers","following_url":"https://api.github.com/users/vsimon/following{/other_user}","gists_url":"https://api.github.com/users/vsimon/gists{/gist_id}","starred_url":"https://api.github.com/users/vsimon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vsimon/subscriptions","organizations_url":"https://api.github.com/users/vsimon/orgs","repos_url":"https://api.github.com/users/vsimon/repos","events_url":"https://api.github.com/users/vsimon/events{/privacy}","received_events_url":"https://api.github.com/users/vsimon/received_events","type":"User","site_admin":false},"body":"The implication of putting ::deps after ::depot-tools is that ::depot-tools uses git would not be available yet. In a CI environment like travis/gitlab-ci this will fail the build.\r\n\r\nFortunately, looking things over again, we don't need jq anymore (it was a vestige from before when this repo would parse JSON to upload packages using the Github API)\r\nhttps://github.com/vsimon/webrtcbuilds/pull/13\r\n\r\nAfter this pull request is merged, check::depot_tools should now see that depot_tools is empty.","created_at":"2016-08-26T07:06:29Z","updated_at":"2016-08-26T07:06:29Z","html_url":"https://github.com/vsimon/webrtcbuilds/pull/11#discussion_r76372892","pull_request_url":"https://api.github.com/repos/vsimon/webrtcbuilds/pulls/11","_links":{"self":{"href":"https://api.github.com/repos/vsimon/webrtcbuilds/pulls/comments/76372892"},"html":{"href":"https://github.com/vsimon/webrtcbuilds/pull/11#discussion_r76372892"},"pull_request":{"href":"https://api.github.com/repos/vsimon/webrtcbuilds/pulls/11"}}},"pull_request":{"url":"https://api.github.com/repos/vsimon/webrtcbuilds/pulls/11","id":82788155,"html_url":"https://github.com/vsimon/webrtcbuilds/pull/11","diff_url":"https://github.com/vsimon/webrtcbuilds/pull/11.diff","patch_url":"https://github.com/vsimon/webrtcbuilds/pull/11.patch","issue_url":"https://api.github.com/repos/vsimon/webrtcbuilds/issues/11","number":11,"state":"open","locked":false,"title":"Dtb 20160823","user":{"login":"DanielTBrown","id":12141206,"avatar_url":"https://avatars.githubusercontent.com/u/12141206?v=3","gravatar_id":"","url":"https://api.github.com/users/DanielTBrown","html_url":"https://github.com/DanielTBrown","followers_url":"https://api.github.com/users/DanielTBrown/followers","following_url":"https://api.github.com/users/DanielTBrown/following{/other_user}","gists_url":"https://api.github.com/users/DanielTBrown/gists{/gist_id}","starred_url":"https://api.github.com/users/DanielTBrown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanielTBrown/subscriptions","organizations_url":"https://api.github.com/users/DanielTBrown/orgs","repos_url":"https://api.github.com/users/DanielTBrown/repos","events_url":"https://api.github.com/users/DanielTBrown/events{/privacy}","received_events_url":"https://api.github.com/users/DanielTBrown/received_events","type":"User","site_admin":false},"body":"This is an update to build.sh and util.sh to build under Microsoft Windows using the git bash shell and Microsoft Visual C++ 2013. The change to force use of Visual C++ 2013 is a hack, and should be improved.\r\n\r\nChanges to build.sh:\r\n\r\n* Add export GYP_MSVS_VERSION='2013' to force use of Microsoft Visual C++ 2013. This is a hack, and should be improved. GYP_MSVS_VERSION must be defined early in the build process, because it is used before the compile step.\r\n* Call check::depot_tools before check::deps, because check::depot_tools requires that depot_tools be empty, but check::deps loads a file into depot_tools.\r\n\r\nChanges to util.sh:\r\n\r\n* Recognize $OSTYPE value 'msys' as git bash running under Microsoft Windows, build for Microsoft Windows.\r\n* Run gclient.bat directly, not through schtasks, because schtasks is restricted to use by an administrator.\r\n* Perform mkdir $depot_tools_dir/python276_bin, because curl --create-dirs does not appear to work. Presumably this is a hack that can someday be removed. However, it works and is clear.\r\n\r\nAs this is written, the compilation does not complete with the current revision of the WebRTC source code. However, that problem is unrelated to these changes.","created_at":"2016-08-25T20:32:52Z","updated_at":"2016-08-26T07:06:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a8e5f42b28d6ef68b6142128eec088d459bb56f7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/vsimon/webrtcbuilds/pulls/11/commits","review_comments_url":"https://api.github.com/repos/vsimon/webrtcbuilds/pulls/11/comments","review_comment_url":"https://api.github.com/repos/vsimon/webrtcbuilds/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vsimon/webrtcbuilds/issues/11/comments","statuses_url":"https://api.github.com/repos/vsimon/webrtcbuilds/statuses/0f3b9c98e49acf157d778c307da2050fafda38da","head":{"label":"DanielTBrown:DTB-20160823","ref":"DTB-20160823","sha":"0f3b9c98e49acf157d778c307da2050fafda38da","user":{"login":"DanielTBrown","id":12141206,"avatar_url":"https://avatars.githubusercontent.com/u/12141206?v=3","gravatar_id":"","url":"https://api.github.com/users/DanielTBrown","html_url":"https://github.com/DanielTBrown","followers_url":"https://api.github.com/users/DanielTBrown/followers","following_url":"https://api.github.com/users/DanielTBrown/following{/other_user}","gists_url":"https://api.github.com/users/DanielTBrown/gists{/gist_id}","starred_url":"https://api.github.com/users/DanielTBrown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanielTBrown/subscriptions","organizations_url":"https://api.github.com/users/DanielTBrown/orgs","repos_url":"https://api.github.com/users/DanielTBrown/repos","events_url":"https://api.github.com/users/DanielTBrown/events{/privacy}","received_events_url":"https://api.github.com/users/DanielTBrown/received_events","type":"User","site_admin":false},"repo":{"id":66385659,"name":"webrtcbuilds","full_name":"DanielTBrown/webrtcbuilds","owner":{"login":"DanielTBrown","id":12141206,"avatar_url":"https://avatars.githubusercontent.com/u/12141206?v=3","gravatar_id":"","url":"https://api.github.com/users/DanielTBrown","html_url":"https://github.com/DanielTBrown","followers_url":"https://api.github.com/users/DanielTBrown/followers","following_url":"https://api.github.com/users/DanielTBrown/following{/other_user}","gists_url":"https://api.github.com/users/DanielTBrown/gists{/gist_id}","starred_url":"https://api.github.com/users/DanielTBrown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanielTBrown/subscriptions","organizations_url":"https://api.github.com/users/DanielTBrown/orgs","repos_url":"https://api.github.com/users/DanielTBrown/repos","events_url":"https://api.github.com/users/DanielTBrown/events{/privacy}","received_events_url":"https://api.github.com/users/DanielTBrown/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DanielTBrown/webrtcbuilds","description":"Getting started with WebRTC natively is no easy picnic. The goal of webrtcbuilds is to provide a single standalone WebRTC static library and package. Since webrtc has migrated to git, there is no longer a need for a git mirror and the builder has been migrated here. 2016/06/22","fork":true,"url":"https://api.github.com/repos/DanielTBrown/webrtcbuilds","forks_url":"https://api.github.com/repos/DanielTBrown/webrtcbuilds/forks","keys_url":"https://api.github.com/repos/DanielTBrown/webrtcbuilds/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DanielTBrown/webrtcbuilds/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DanielTBrown/webrtcbuilds/teams","hooks_url":"https://api.github.com/repos/DanielTBrown/webrtcbuilds/hooks","issue_events_url":"https://api.github.com/repos/DanielTBrown/webrtcbuilds/issues/events{/number}","events_url":"https://api.github.com/repos/DanielTBrown/webrtcbuilds/events","assignees_url":"https://api.github.com/repos/DanielTBrown/webrtcbuilds/assignees{/user}","branches_url":"https://api.github.com/repos/DanielTBrown/webrtcbuilds/branches{/branch}","tags_url":"https://api.github.com/repos/DanielTBrown/webrtcbuilds/tags","blobs_url":"https://api.github.com/repos/DanielTBrown/webrtcbuilds/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DanielTBrown/webrtcbuilds/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DanielTBrown/webrtcbuilds/git/refs{/sha}","trees_url":"https://api.github.com/repos/DanielTBrown/webrtcbuilds/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DanielTBrown/webrtcbuilds/statuses/{sha}","languages_url":"https://api.github.com/repos/DanielTBrown/webrtcbuilds/languages","stargazers_url":"https://api.github.com/repos/DanielTBrown/webrtcbuilds/stargazers","contributors_url":"https://api.github.com/repos/DanielTBrown/webrtcbuilds/contributors","subscribers_url":"https://api.github.com/repos/DanielTBrown/webrtcbuilds/subscribers","subscription_url":"https://api.github.com/repos/DanielTBrown/webrtcbuilds/subscription","commits_url":"https://api.github.com/repos/DanielTBrown/webrtcbuilds/commits{/sha}","git_commits_url":"https://api.github.com/repos/DanielTBrown/webrtcbuilds/git/commits{/sha}","comments_url":"https://api.github.com/repos/DanielTBrown/webrtcbuilds/comments{/number}","issue_comment_url":"https://api.github.com/repos/DanielTBrown/webrtcbuilds/issues/comments{/number}","contents_url":"https://api.github.com/repos/DanielTBrown/webrtcbuilds/contents/{+path}","compare_url":"https://api.github.com/repos/DanielTBrown/webrtcbuilds/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DanielTBrown/webrtcbuilds/merges","archive_url":"https://api.github.com/repos/DanielTBrown/webrtcbuilds/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DanielTBrown/webrtcbuilds/downloads","issues_url":"https://api.github.com/repos/DanielTBrown/webrtcbuilds/issues{/number}","pulls_url":"https://api.github.com/repos/DanielTBrown/webrtcbuilds/pulls{/number}","milestones_url":"https://api.github.com/repos/DanielTBrown/webrtcbuilds/milestones{/number}","notifications_url":"https://api.github.com/repos/DanielTBrown/webrtcbuilds/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DanielTBrown/webrtcbuilds/labels{/name}","releases_url":"https://api.github.com/repos/DanielTBrown/webrtcbuilds/releases{/id}","deployments_url":"https://api.github.com/repos/DanielTBrown/webrtcbuilds/deployments","created_at":"2016-08-23T16:50:07Z","updated_at":"2016-08-23T16:50:09Z","pushed_at":"2016-08-25T19:56:52Z","git_url":"git://github.com/DanielTBrown/webrtcbuilds.git","ssh_url":"git@github.com:DanielTBrown/webrtcbuilds.git","clone_url":"https://github.com/DanielTBrown/webrtcbuilds.git","svn_url":"https://github.com/DanielTBrown/webrtcbuilds","homepage":"https://github.com/vsimon/webrtcbuilds/wiki","size":107274,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"vsimon:master","ref":"master","sha":"6f790cdce76979d853e873d64c8bd917ca893c4f","user":{"login":"vsimon","id":137727,"avatar_url":"https://avatars.githubusercontent.com/u/137727?v=3","gravatar_id":"","url":"https://api.github.com/users/vsimon","html_url":"https://github.com/vsimon","followers_url":"https://api.github.com/users/vsimon/followers","following_url":"https://api.github.com/users/vsimon/following{/other_user}","gists_url":"https://api.github.com/users/vsimon/gists{/gist_id}","starred_url":"https://api.github.com/users/vsimon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vsimon/subscriptions","organizations_url":"https://api.github.com/users/vsimon/orgs","repos_url":"https://api.github.com/users/vsimon/repos","events_url":"https://api.github.com/users/vsimon/events{/privacy}","received_events_url":"https://api.github.com/users/vsimon/received_events","type":"User","site_admin":false},"repo":{"id":26531387,"name":"webrtcbuilds","full_name":"vsimon/webrtcbuilds","owner":{"login":"vsimon","id":137727,"avatar_url":"https://avatars.githubusercontent.com/u/137727?v=3","gravatar_id":"","url":"https://api.github.com/users/vsimon","html_url":"https://github.com/vsimon","followers_url":"https://api.github.com/users/vsimon/followers","following_url":"https://api.github.com/users/vsimon/following{/other_user}","gists_url":"https://api.github.com/users/vsimon/gists{/gist_id}","starred_url":"https://api.github.com/users/vsimon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vsimon/subscriptions","organizations_url":"https://api.github.com/users/vsimon/orgs","repos_url":"https://api.github.com/users/vsimon/repos","events_url":"https://api.github.com/users/vsimon/events{/privacy}","received_events_url":"https://api.github.com/users/vsimon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vsimon/webrtcbuilds","description":"Getting started with WebRTC natively is no easy picnic. The goal of webrtcbuilds is to provide a single standalone WebRTC static library and package. Since webrtc has migrated to git, there is no longer a need for a git mirror and the builder has been migrated here. 2016/06/22","fork":false,"url":"https://api.github.com/repos/vsimon/webrtcbuilds","forks_url":"https://api.github.com/repos/vsimon/webrtcbuilds/forks","keys_url":"https://api.github.com/repos/vsimon/webrtcbuilds/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vsimon/webrtcbuilds/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vsimon/webrtcbuilds/teams","hooks_url":"https://api.github.com/repos/vsimon/webrtcbuilds/hooks","issue_events_url":"https://api.github.com/repos/vsimon/webrtcbuilds/issues/events{/number}","events_url":"https://api.github.com/repos/vsimon/webrtcbuilds/events","assignees_url":"https://api.github.com/repos/vsimon/webrtcbuilds/assignees{/user}","branches_url":"https://api.github.com/repos/vsimon/webrtcbuilds/branches{/branch}","tags_url":"https://api.github.com/repos/vsimon/webrtcbuilds/tags","blobs_url":"https://api.github.com/repos/vsimon/webrtcbuilds/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vsimon/webrtcbuilds/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vsimon/webrtcbuilds/git/refs{/sha}","trees_url":"https://api.github.com/repos/vsimon/webrtcbuilds/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vsimon/webrtcbuilds/statuses/{sha}","languages_url":"https://api.github.com/repos/vsimon/webrtcbuilds/languages","stargazers_url":"https://api.github.com/repos/vsimon/webrtcbuilds/stargazers","contributors_url":"https://api.github.com/repos/vsimon/webrtcbuilds/contributors","subscribers_url":"https://api.github.com/repos/vsimon/webrtcbuilds/subscribers","subscription_url":"https://api.github.com/repos/vsimon/webrtcbuilds/subscription","commits_url":"https://api.github.com/repos/vsimon/webrtcbuilds/commits{/sha}","git_commits_url":"https://api.github.com/repos/vsimon/webrtcbuilds/git/commits{/sha}","comments_url":"https://api.github.com/repos/vsimon/webrtcbuilds/comments{/number}","issue_comment_url":"https://api.github.com/repos/vsimon/webrtcbuilds/issues/comments{/number}","contents_url":"https://api.github.com/repos/vsimon/webrtcbuilds/contents/{+path}","compare_url":"https://api.github.com/repos/vsimon/webrtcbuilds/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vsimon/webrtcbuilds/merges","archive_url":"https://api.github.com/repos/vsimon/webrtcbuilds/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vsimon/webrtcbuilds/downloads","issues_url":"https://api.github.com/repos/vsimon/webrtcbuilds/issues{/number}","pulls_url":"https://api.github.com/repos/vsimon/webrtcbuilds/pulls{/number}","milestones_url":"https://api.github.com/repos/vsimon/webrtcbuilds/milestones{/number}","notifications_url":"https://api.github.com/repos/vsimon/webrtcbuilds/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vsimon/webrtcbuilds/labels{/name}","releases_url":"https://api.github.com/repos/vsimon/webrtcbuilds/releases{/id}","deployments_url":"https://api.github.com/repos/vsimon/webrtcbuilds/deployments","created_at":"2014-11-12T10:43:58Z","updated_at":"2016-08-09T20:14:11Z","pushed_at":"2016-08-26T06:57:23Z","git_url":"git://github.com/vsimon/webrtcbuilds.git","ssh_url":"git@github.com:vsimon/webrtcbuilds.git","clone_url":"https://github.com/vsimon/webrtcbuilds.git","svn_url":"https://github.com/vsimon/webrtcbuilds","homepage":"https://github.com/vsimon/webrtcbuilds/wiki","size":115244,"stargazers_count":57,"watchers_count":57,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"open_issues_count":6,"forks":25,"open_issues":6,"watchers":57,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vsimon/webrtcbuilds/pulls/11"},"html":{"href":"https://github.com/vsimon/webrtcbuilds/pull/11"},"issue":{"href":"https://api.github.com/repos/vsimon/webrtcbuilds/issues/11"},"comments":{"href":"https://api.github.com/repos/vsimon/webrtcbuilds/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/vsimon/webrtcbuilds/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/vsimon/webrtcbuilds/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vsimon/webrtcbuilds/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/vsimon/webrtcbuilds/statuses/0f3b9c98e49acf157d778c307da2050fafda38da"}}}}
{"actor":{"display_login":"vsimon"}}