{"action":"created","issue":{"url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/2170","repository_url":"https://api.github.com/repos/cfpb/cfgov-refresh","labels_url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/2170/labels{/name}","comments_url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/2170/comments","events_url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/2170/events","html_url":"https://github.com/cfpb/cfgov-refresh/pull/2170","id":158927985,"number":2170,"title":"Creates nonresponsive header script for non-v1 sections of the site","user":{"login":"jimmynotjim","id":1280430,"avatar_url":"https://avatars.githubusercontent.com/u/1280430?v=3","gravatar_id":"","url":"https://api.github.com/users/jimmynotjim","html_url":"https://github.com/jimmynotjim","followers_url":"https://api.github.com/users/jimmynotjim/followers","following_url":"https://api.github.com/users/jimmynotjim/following{/other_user}","gists_url":"https://api.github.com/users/jimmynotjim/gists{/gist_id}","starred_url":"https://api.github.com/users/jimmynotjim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimmynotjim/subscriptions","organizations_url":"https://api.github.com/users/jimmynotjim/orgs","repos_url":"https://api.github.com/users/jimmynotjim/repos","events_url":"https://api.github.com/users/jimmynotjim/events{/privacy}","received_events_url":"https://api.github.com/users/jimmynotjim/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-06-07T13:49:44Z","updated_at":"2016-06-13T15:38:00Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls/2170","html_url":"https://github.com/cfpb/cfgov-refresh/pull/2170","diff_url":"https://github.com/cfpb/cfgov-refresh/pull/2170.diff","patch_url":"https://github.com/cfpb/cfgov-refresh/pull/2170.patch"},"body":"PR #2160 only addressed non-responsive styles, leading to incorrect behavior at smaller screens on the non-responsive test fixture. Added a gulp task to create a nonresponsive script that rewrites `isInDesktop` to always return true.\r\n\r\n## Additions\r\n\r\n- Added gulp task for nonresponsive scripts\r\n- Added webpack config for nonresponsive gulp task\r\n\r\n## Changes\r\n\r\n- Moved `isInDesktop` to breakpoint state file to resolve TODOs\r\n\r\n## Testing\r\n\r\n- `gulp scripts:ondemand && gulp styles:ondemand`\r\n- navigate to `http://localhost:8000/test-fixture/?atomic=header&suffix=nonresponsive` \r\n\r\n## Review\r\n\r\n- @KimberlyMunoz \r\n- @anselmbradford \r\n- @rosskarchner \r\n\r\n## Screenshots\r\n\r\n<img width=\"736\" alt=\"screen shot 2016-06-07 at 8 49 22 am\" src=\"https://cloud.githubusercontent.com/assets/1280430/15859947/c16f5dee-2c8c-11e6-89ac-4f781660d6b6.png\">\r\n\r\n# Notes\r\n\r\n- We should wait for #2164 & #2166 to be merged to make sure this PR doesn't break the existing functionality\r\n\r\n## Checklist\r\n\r\n* [x] Changes are limited to a single goal (no scope creep)\r\n* [x] Code can be automatically merged (no conflicts)\r\n* [x] Code follows the standards laid out in the [front end playbook](https://github.com/cfpb/front-end)\r\n* [x] Passes all existing automated tests\r\n* [x] New functions include new tests\r\n* [x] New functions are documented (with a description, list of inputs, and expected output)\r\n* [x] Placeholder code is flagged\r\n* [x] Visually tested in supported browsers and devices\r\n* [ ] Project documentation has been updated (including the \"Unreleased\" section of the CHANGELOG)"},"comment":{"url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/comments/225619213","html_url":"https://github.com/cfpb/cfgov-refresh/pull/2170#issuecomment-225619213","issue_url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/2170","id":225619213,"user":{"login":"anselmbradford","id":704760,"avatar_url":"https://avatars.githubusercontent.com/u/704760?v=3","gravatar_id":"","url":"https://api.github.com/users/anselmbradford","html_url":"https://github.com/anselmbradford","followers_url":"https://api.github.com/users/anselmbradford/followers","following_url":"https://api.github.com/users/anselmbradford/following{/other_user}","gists_url":"https://api.github.com/users/anselmbradford/gists{/gist_id}","starred_url":"https://api.github.com/users/anselmbradford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anselmbradford/subscriptions","organizations_url":"https://api.github.com/users/anselmbradford/orgs","repos_url":"https://api.github.com/users/anselmbradford/repos","events_url":"https://api.github.com/users/anselmbradford/events{/privacy}","received_events_url":"https://api.github.com/users/anselmbradford/received_events","type":"User","site_admin":false},"created_at":"2016-06-13T15:38:00Z","updated_at":"2016-06-13T15:38:00Z","body":"👍 "}}
{"actor":{"display_login":"anselmbradford"}}