{"action":"created","comment":{"url":"https://api.github.com/repos/apache/parquet-mr/pulls/comments/53542329","id":53542329,"diff_hunk":"@@ -126,10 +126,8 @@\n   abstract public void addDouble(double value);\n \n   /**\n-   * NoOps by default\n-   * Subclass class can implement its own flushing logic\n+   * subclass class should implement its own flushing logic\n    */\n-  public void flush() {\n-  }\n+  abstract public void flush();","path":"parquet-column/src/main/java/org/apache/parquet/io/api/RecordConsumer.java","position":null,"original_position":10,"commit_id":"2c90740ef265cc37f3fe7a4c83b35823da63617e","original_commit_id":"8776e3a48616d1a9ed860103c4c57acf670dca4e","user":{"login":"proflin","id":15843379,"avatar_url":"https://avatars.githubusercontent.com/u/15843379?v=3","gravatar_id":"","url":"https://api.github.com/users/proflin","html_url":"https://github.com/proflin","followers_url":"https://api.github.com/users/proflin/followers","following_url":"https://api.github.com/users/proflin/following{/other_user}","gists_url":"https://api.github.com/users/proflin/gists{/gist_id}","starred_url":"https://api.github.com/users/proflin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/proflin/subscriptions","organizations_url":"https://api.github.com/users/proflin/orgs","repos_url":"https://api.github.com/users/proflin/repos","events_url":"https://api.github.com/users/proflin/events{/privacy}","received_events_url":"https://api.github.com/users/proflin/received_events","type":"User","site_admin":false},"body":"@julienledem \r\nSure. I've issued another commit reverting it back to be non-_abstract_. Is there any need we make it _abstract_ in a major release, like 2.0?","created_at":"2016-02-20T02:16:54Z","updated_at":"2016-02-20T02:16:54Z","html_url":"https://github.com/apache/parquet-mr/pull/325#discussion_r53542329","pull_request_url":"https://api.github.com/repos/apache/parquet-mr/pulls/325","_links":{"self":{"href":"https://api.github.com/repos/apache/parquet-mr/pulls/comments/53542329"},"html":{"href":"https://github.com/apache/parquet-mr/pull/325#discussion_r53542329"},"pull_request":{"href":"https://api.github.com/repos/apache/parquet-mr/pulls/325"}}},"pull_request":{"url":"https://api.github.com/repos/apache/parquet-mr/pulls/325","id":59291704,"html_url":"https://github.com/apache/parquet-mr/pull/325","diff_url":"https://github.com/apache/parquet-mr/pull/325.diff","patch_url":"https://github.com/apache/parquet-mr/pull/325.patch","issue_url":"https://api.github.com/repos/apache/parquet-mr/issues/325","number":325,"state":"open","locked":false,"title":"PARQUET-528: Fix flush() for RecordConsumer and implementations","user":{"login":"proflin","id":15843379,"avatar_url":"https://avatars.githubusercontent.com/u/15843379?v=3","gravatar_id":"","url":"https://api.github.com/users/proflin","html_url":"https://github.com/proflin","followers_url":"https://api.github.com/users/proflin/followers","following_url":"https://api.github.com/users/proflin/following{/other_user}","gists_url":"https://api.github.com/users/proflin/gists{/gist_id}","starred_url":"https://api.github.com/users/proflin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/proflin/subscriptions","organizations_url":"https://api.github.com/users/proflin/orgs","repos_url":"https://api.github.com/users/proflin/repos","events_url":"https://api.github.com/users/proflin/events{/privacy}","received_events_url":"https://api.github.com/users/proflin/received_events","type":"User","site_admin":false},"body":"`flush()` was added in `RecordConsumer` and `MessageColumnIO` to help implementing nulls caching.\r\n\r\nHowever, other `RecordConsumer` implementations should also implements `flush()` properly. For instance, `RecordConsumerLoggingWrapper` and `ValidatingRecordConsumer` should call `delegate.flush()` in their `flush()` methods, otherwise data might be mistakenly truncated.\r\n\r\nThis PR:\r\n- makes `flush()` abstract in `RecordConsumer`\r\n- implements `flush()` properly for all `RecordConsumer` subclasses, specifically:\r\n - `RecordConsumerLoggingWrapper`\r\n - `ValidatingRecordConsumer`\r\n - `ConverterConsumer `\r\n - `ExpectationValidatingRecordConsumer `","created_at":"2016-02-14T09:55:31Z","updated_at":"2016-02-20T02:16:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c971f953105ad9af18f3efd41e65530cdc2981a5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/parquet-mr/pulls/325/commits","review_comments_url":"https://api.github.com/repos/apache/parquet-mr/pulls/325/comments","review_comment_url":"https://api.github.com/repos/apache/parquet-mr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/parquet-mr/issues/325/comments","statuses_url":"https://api.github.com/repos/apache/parquet-mr/statuses/2c90740ef265cc37f3fe7a4c83b35823da63617e","head":{"label":"proflin:PARQUET-528","ref":"PARQUET-528","sha":"2c90740ef265cc37f3fe7a4c83b35823da63617e","user":{"login":"proflin","id":15843379,"avatar_url":"https://avatars.githubusercontent.com/u/15843379?v=3","gravatar_id":"","url":"https://api.github.com/users/proflin","html_url":"https://github.com/proflin","followers_url":"https://api.github.com/users/proflin/followers","following_url":"https://api.github.com/users/proflin/following{/other_user}","gists_url":"https://api.github.com/users/proflin/gists{/gist_id}","starred_url":"https://api.github.com/users/proflin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/proflin/subscriptions","organizations_url":"https://api.github.com/users/proflin/orgs","repos_url":"https://api.github.com/users/proflin/repos","events_url":"https://api.github.com/users/proflin/events{/privacy}","received_events_url":"https://api.github.com/users/proflin/received_events","type":"User","site_admin":false},"repo":{"id":49350412,"name":"parquet-mr","full_name":"proflin/parquet-mr","owner":{"login":"proflin","id":15843379,"avatar_url":"https://avatars.githubusercontent.com/u/15843379?v=3","gravatar_id":"","url":"https://api.github.com/users/proflin","html_url":"https://github.com/proflin","followers_url":"https://api.github.com/users/proflin/followers","following_url":"https://api.github.com/users/proflin/following{/other_user}","gists_url":"https://api.github.com/users/proflin/gists{/gist_id}","starred_url":"https://api.github.com/users/proflin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/proflin/subscriptions","organizations_url":"https://api.github.com/users/proflin/orgs","repos_url":"https://api.github.com/users/proflin/repos","events_url":"https://api.github.com/users/proflin/events{/privacy}","received_events_url":"https://api.github.com/users/proflin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/proflin/parquet-mr","description":"Mirror of Apache Parquet","fork":true,"url":"https://api.github.com/repos/proflin/parquet-mr","forks_url":"https://api.github.com/repos/proflin/parquet-mr/forks","keys_url":"https://api.github.com/repos/proflin/parquet-mr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/proflin/parquet-mr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/proflin/parquet-mr/teams","hooks_url":"https://api.github.com/repos/proflin/parquet-mr/hooks","issue_events_url":"https://api.github.com/repos/proflin/parquet-mr/issues/events{/number}","events_url":"https://api.github.com/repos/proflin/parquet-mr/events","assignees_url":"https://api.github.com/repos/proflin/parquet-mr/assignees{/user}","branches_url":"https://api.github.com/repos/proflin/parquet-mr/branches{/branch}","tags_url":"https://api.github.com/repos/proflin/parquet-mr/tags","blobs_url":"https://api.github.com/repos/proflin/parquet-mr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/proflin/parquet-mr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/proflin/parquet-mr/git/refs{/sha}","trees_url":"https://api.github.com/repos/proflin/parquet-mr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/proflin/parquet-mr/statuses/{sha}","languages_url":"https://api.github.com/repos/proflin/parquet-mr/languages","stargazers_url":"https://api.github.com/repos/proflin/parquet-mr/stargazers","contributors_url":"https://api.github.com/repos/proflin/parquet-mr/contributors","subscribers_url":"https://api.github.com/repos/proflin/parquet-mr/subscribers","subscription_url":"https://api.github.com/repos/proflin/parquet-mr/subscription","commits_url":"https://api.github.com/repos/proflin/parquet-mr/commits{/sha}","git_commits_url":"https://api.github.com/repos/proflin/parquet-mr/git/commits{/sha}","comments_url":"https://api.github.com/repos/proflin/parquet-mr/comments{/number}","issue_comment_url":"https://api.github.com/repos/proflin/parquet-mr/issues/comments{/number}","contents_url":"https://api.github.com/repos/proflin/parquet-mr/contents/{+path}","compare_url":"https://api.github.com/repos/proflin/parquet-mr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/proflin/parquet-mr/merges","archive_url":"https://api.github.com/repos/proflin/parquet-mr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/proflin/parquet-mr/downloads","issues_url":"https://api.github.com/repos/proflin/parquet-mr/issues{/number}","pulls_url":"https://api.github.com/repos/proflin/parquet-mr/pulls{/number}","milestones_url":"https://api.github.com/repos/proflin/parquet-mr/milestones{/number}","notifications_url":"https://api.github.com/repos/proflin/parquet-mr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/proflin/parquet-mr/labels{/name}","releases_url":"https://api.github.com/repos/proflin/parquet-mr/releases{/id}","deployments_url":"https://api.github.com/repos/proflin/parquet-mr/deployments","created_at":"2016-01-10T02:34:49Z","updated_at":"2016-01-13T06:24:27Z","pushed_at":"2016-02-20T02:12:20Z","git_url":"git://github.com/proflin/parquet-mr.git","ssh_url":"git@github.com:proflin/parquet-mr.git","clone_url":"https://github.com/proflin/parquet-mr.git","svn_url":"https://github.com/proflin/parquet-mr","homepage":null,"size":13725,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"c26fa78817f30cc3eb91165b783e07fb80d80f59","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":20675636,"name":"parquet-mr","full_name":"apache/parquet-mr","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/parquet-mr","description":"Mirror of Apache Parquet","fork":false,"url":"https://api.github.com/repos/apache/parquet-mr","forks_url":"https://api.github.com/repos/apache/parquet-mr/forks","keys_url":"https://api.github.com/repos/apache/parquet-mr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/parquet-mr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/parquet-mr/teams","hooks_url":"https://api.github.com/repos/apache/parquet-mr/hooks","issue_events_url":"https://api.github.com/repos/apache/parquet-mr/issues/events{/number}","events_url":"https://api.github.com/repos/apache/parquet-mr/events","assignees_url":"https://api.github.com/repos/apache/parquet-mr/assignees{/user}","branches_url":"https://api.github.com/repos/apache/parquet-mr/branches{/branch}","tags_url":"https://api.github.com/repos/apache/parquet-mr/tags","blobs_url":"https://api.github.com/repos/apache/parquet-mr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/parquet-mr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/parquet-mr/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/parquet-mr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/parquet-mr/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/parquet-mr/languages","stargazers_url":"https://api.github.com/repos/apache/parquet-mr/stargazers","contributors_url":"https://api.github.com/repos/apache/parquet-mr/contributors","subscribers_url":"https://api.github.com/repos/apache/parquet-mr/subscribers","subscription_url":"https://api.github.com/repos/apache/parquet-mr/subscription","commits_url":"https://api.github.com/repos/apache/parquet-mr/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/parquet-mr/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/parquet-mr/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/parquet-mr/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/parquet-mr/contents/{+path}","compare_url":"https://api.github.com/repos/apache/parquet-mr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/parquet-mr/merges","archive_url":"https://api.github.com/repos/apache/parquet-mr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/parquet-mr/downloads","issues_url":"https://api.github.com/repos/apache/parquet-mr/issues{/number}","pulls_url":"https://api.github.com/repos/apache/parquet-mr/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/parquet-mr/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/parquet-mr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/parquet-mr/labels{/name}","releases_url":"https://api.github.com/repos/apache/parquet-mr/releases{/id}","deployments_url":"https://api.github.com/repos/apache/parquet-mr/deployments","created_at":"2014-06-10T07:00:07Z","updated_at":"2016-02-19T12:39:13Z","pushed_at":"2016-02-20T02:12:21Z","git_url":"git://github.com/apache/parquet-mr.git","ssh_url":"git@github.com:apache/parquet-mr.git","clone_url":"https://github.com/apache/parquet-mr.git","svn_url":"https://github.com/apache/parquet-mr","homepage":null,"size":17489,"stargazers_count":192,"watchers_count":192,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":190,"mirror_url":"git://git.apache.org/parquet-mr.git","open_issues_count":58,"forks":190,"open_issues":58,"watchers":192,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/parquet-mr/pulls/325"},"html":{"href":"https://github.com/apache/parquet-mr/pull/325"},"issue":{"href":"https://api.github.com/repos/apache/parquet-mr/issues/325"},"comments":{"href":"https://api.github.com/repos/apache/parquet-mr/issues/325/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/parquet-mr/pulls/325/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/parquet-mr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/parquet-mr/pulls/325/commits"},"statuses":{"href":"https://api.github.com/repos/apache/parquet-mr/statuses/2c90740ef265cc37f3fe7a4c83b35823da63617e"}}}}