{"action":"created","comment":{"url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/pulls/comments/56900539","id":56900539,"diff_hunk":"@@ -298,8 +298,8 @@ bool MenuModeConfigureSeats::comboChanged(const CEGUI::EventArgs& ea)\n     CEGUI::ListboxItem* selItem = comboSel->getSelectedItem();\n     if((selItem != nullptr) &&\n        (comboSel->getName().compare(0, COMBOBOX_PLAYER_PREFIX.length(), COMBOBOX_PLAYER_PREFIX) == 0) &&\n-       (selItem->getID() != 0) && // Can be several inactive players\n-       (selItem->getID() != 1)) // Can be several AI players\n+       (static_cast<int32_t>(selItem->getID()) >= Seat::PLAYER_ID_HUMAN_MIN) && // Can be several AI players\n+       (static_cast<int32_t>(selItem->getID()) != Seat::PLAYER_TYPE_INACTIVE_ID)) // Can be several inactive players","path":"source/modes/MenuModeConfigureSeats.cpp","position":7,"original_position":7,"commit_id":"7ddd29e8b401a6f91ae8fe7b545403e6050b73ba","original_commit_id":"8b69218b464f84396b7bacf44b2548e808ec017c","user":{"login":"hwoarangmy","id":7493706,"avatar_url":"https://avatars.githubusercontent.com/u/7493706?v=3","gravatar_id":"","url":"https://api.github.com/users/hwoarangmy","html_url":"https://github.com/hwoarangmy","followers_url":"https://api.github.com/users/hwoarangmy/followers","following_url":"https://api.github.com/users/hwoarangmy/following{/other_user}","gists_url":"https://api.github.com/users/hwoarangmy/gists{/gist_id}","starred_url":"https://api.github.com/users/hwoarangmy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hwoarangmy/subscriptions","organizations_url":"https://api.github.com/users/hwoarangmy/orgs","repos_url":"https://api.github.com/users/hwoarangmy/repos","events_url":"https://api.github.com/users/hwoarangmy/events{/privacy}","received_events_url":"https://api.github.com/users/hwoarangmy/received_events","type":"User","site_admin":false},"body":"Yes. It would have avoided to forget as I did ^^","created_at":"2016-03-21T21:26:58Z","updated_at":"2016-03-21T21:26:58Z","html_url":"https://github.com/OpenDungeons/OpenDungeons/pull/1130#discussion_r56900539","pull_request_url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/pulls/1130","_links":{"self":{"href":"https://api.github.com/repos/OpenDungeons/OpenDungeons/pulls/comments/56900539"},"html":{"href":"https://github.com/OpenDungeons/OpenDungeons/pull/1130#discussion_r56900539"},"pull_request":{"href":"https://api.github.com/repos/OpenDungeons/OpenDungeons/pulls/1130"}}},"pull_request":{"url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/pulls/1130","id":63626079,"html_url":"https://github.com/OpenDungeons/OpenDungeons/pull/1130","diff_url":"https://github.com/OpenDungeons/OpenDungeons/pull/1130.diff","patch_url":"https://github.com/OpenDungeons/OpenDungeons/pull/1130.patch","issue_url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/issues/1130","number":1130,"state":"open","locked":false,"title":"Small fixes + 1 new multiplayer level","user":{"login":"hwoarangmy","id":7493706,"avatar_url":"https://avatars.githubusercontent.com/u/7493706?v=3","gravatar_id":"","url":"https://api.github.com/users/hwoarangmy","html_url":"https://github.com/hwoarangmy","followers_url":"https://api.github.com/users/hwoarangmy/followers","following_url":"https://api.github.com/users/hwoarangmy/following{/other_user}","gists_url":"https://api.github.com/users/hwoarangmy/gists{/gist_id}","starred_url":"https://api.github.com/users/hwoarangmy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hwoarangmy/subscriptions","organizations_url":"https://api.github.com/users/hwoarangmy/orgs","repos_url":"https://api.github.com/users/hwoarangmy/repos","events_url":"https://api.github.com/users/hwoarangmy/events{/privacy}","received_events_url":"https://api.github.com/users/hwoarangmy/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-03-21T20:21:52Z","updated_at":"2016-03-21T21:26:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0748c427dce85221fec217f3f1c2d38151d36080","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/pulls/1130/commits","review_comments_url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/pulls/1130/comments","review_comment_url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/issues/1130/comments","statuses_url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/statuses/7ddd29e8b401a6f91ae8fe7b545403e6050b73ba","head":{"label":"hwoarangmy:development","ref":"development","sha":"7ddd29e8b401a6f91ae8fe7b545403e6050b73ba","user":{"login":"hwoarangmy","id":7493706,"avatar_url":"https://avatars.githubusercontent.com/u/7493706?v=3","gravatar_id":"","url":"https://api.github.com/users/hwoarangmy","html_url":"https://github.com/hwoarangmy","followers_url":"https://api.github.com/users/hwoarangmy/followers","following_url":"https://api.github.com/users/hwoarangmy/following{/other_user}","gists_url":"https://api.github.com/users/hwoarangmy/gists{/gist_id}","starred_url":"https://api.github.com/users/hwoarangmy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hwoarangmy/subscriptions","organizations_url":"https://api.github.com/users/hwoarangmy/orgs","repos_url":"https://api.github.com/users/hwoarangmy/repos","events_url":"https://api.github.com/users/hwoarangmy/events{/privacy}","received_events_url":"https://api.github.com/users/hwoarangmy/received_events","type":"User","site_admin":false},"repo":{"id":32954377,"name":"OpenDungeons","full_name":"hwoarangmy/OpenDungeons","owner":{"login":"hwoarangmy","id":7493706,"avatar_url":"https://avatars.githubusercontent.com/u/7493706?v=3","gravatar_id":"","url":"https://api.github.com/users/hwoarangmy","html_url":"https://github.com/hwoarangmy","followers_url":"https://api.github.com/users/hwoarangmy/followers","following_url":"https://api.github.com/users/hwoarangmy/following{/other_user}","gists_url":"https://api.github.com/users/hwoarangmy/gists{/gist_id}","starred_url":"https://api.github.com/users/hwoarangmy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hwoarangmy/subscriptions","organizations_url":"https://api.github.com/users/hwoarangmy/orgs","repos_url":"https://api.github.com/users/hwoarangmy/repos","events_url":"https://api.github.com/users/hwoarangmy/events{/privacy}","received_events_url":"https://api.github.com/users/hwoarangmy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hwoarangmy/OpenDungeons","description":"Open source game inspired by Dungeon Keeper - Dark, damp and dangerous...","fork":true,"url":"https://api.github.com/repos/hwoarangmy/OpenDungeons","forks_url":"https://api.github.com/repos/hwoarangmy/OpenDungeons/forks","keys_url":"https://api.github.com/repos/hwoarangmy/OpenDungeons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hwoarangmy/OpenDungeons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hwoarangmy/OpenDungeons/teams","hooks_url":"https://api.github.com/repos/hwoarangmy/OpenDungeons/hooks","issue_events_url":"https://api.github.com/repos/hwoarangmy/OpenDungeons/issues/events{/number}","events_url":"https://api.github.com/repos/hwoarangmy/OpenDungeons/events","assignees_url":"https://api.github.com/repos/hwoarangmy/OpenDungeons/assignees{/user}","branches_url":"https://api.github.com/repos/hwoarangmy/OpenDungeons/branches{/branch}","tags_url":"https://api.github.com/repos/hwoarangmy/OpenDungeons/tags","blobs_url":"https://api.github.com/repos/hwoarangmy/OpenDungeons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hwoarangmy/OpenDungeons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hwoarangmy/OpenDungeons/git/refs{/sha}","trees_url":"https://api.github.com/repos/hwoarangmy/OpenDungeons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hwoarangmy/OpenDungeons/statuses/{sha}","languages_url":"https://api.github.com/repos/hwoarangmy/OpenDungeons/languages","stargazers_url":"https://api.github.com/repos/hwoarangmy/OpenDungeons/stargazers","contributors_url":"https://api.github.com/repos/hwoarangmy/OpenDungeons/contributors","subscribers_url":"https://api.github.com/repos/hwoarangmy/OpenDungeons/subscribers","subscription_url":"https://api.github.com/repos/hwoarangmy/OpenDungeons/subscription","commits_url":"https://api.github.com/repos/hwoarangmy/OpenDungeons/commits{/sha}","git_commits_url":"https://api.github.com/repos/hwoarangmy/OpenDungeons/git/commits{/sha}","comments_url":"https://api.github.com/repos/hwoarangmy/OpenDungeons/comments{/number}","issue_comment_url":"https://api.github.com/repos/hwoarangmy/OpenDungeons/issues/comments{/number}","contents_url":"https://api.github.com/repos/hwoarangmy/OpenDungeons/contents/{+path}","compare_url":"https://api.github.com/repos/hwoarangmy/OpenDungeons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hwoarangmy/OpenDungeons/merges","archive_url":"https://api.github.com/repos/hwoarangmy/OpenDungeons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hwoarangmy/OpenDungeons/downloads","issues_url":"https://api.github.com/repos/hwoarangmy/OpenDungeons/issues{/number}","pulls_url":"https://api.github.com/repos/hwoarangmy/OpenDungeons/pulls{/number}","milestones_url":"https://api.github.com/repos/hwoarangmy/OpenDungeons/milestones{/number}","notifications_url":"https://api.github.com/repos/hwoarangmy/OpenDungeons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hwoarangmy/OpenDungeons/labels{/name}","releases_url":"https://api.github.com/repos/hwoarangmy/OpenDungeons/releases{/id}","deployments_url":"https://api.github.com/repos/hwoarangmy/OpenDungeons/deployments","created_at":"2015-03-26T22:05:18Z","updated_at":"2016-01-11T19:34:16Z","pushed_at":"2016-03-21T20:21:02Z","git_url":"git://github.com/hwoarangmy/OpenDungeons.git","ssh_url":"git@github.com:hwoarangmy/OpenDungeons.git","clone_url":"https://github.com/hwoarangmy/OpenDungeons.git","svn_url":"https://github.com/hwoarangmy/OpenDungeons","homepage":"http://opendungeons.sourceforge.net/","size":327789,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"development"}},"base":{"label":"OpenDungeons:development","ref":"development","sha":"a88666d084c2070e11596c4f1ea7bc7018843324","user":{"login":"OpenDungeons","id":8298376,"avatar_url":"https://avatars.githubusercontent.com/u/8298376?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenDungeons","html_url":"https://github.com/OpenDungeons","followers_url":"https://api.github.com/users/OpenDungeons/followers","following_url":"https://api.github.com/users/OpenDungeons/following{/other_user}","gists_url":"https://api.github.com/users/OpenDungeons/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenDungeons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenDungeons/subscriptions","organizations_url":"https://api.github.com/users/OpenDungeons/orgs","repos_url":"https://api.github.com/users/OpenDungeons/repos","events_url":"https://api.github.com/users/OpenDungeons/events{/privacy}","received_events_url":"https://api.github.com/users/OpenDungeons/received_events","type":"Organization","site_admin":false},"repo":{"id":22376157,"name":"OpenDungeons","full_name":"OpenDungeons/OpenDungeons","owner":{"login":"OpenDungeons","id":8298376,"avatar_url":"https://avatars.githubusercontent.com/u/8298376?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenDungeons","html_url":"https://github.com/OpenDungeons","followers_url":"https://api.github.com/users/OpenDungeons/followers","following_url":"https://api.github.com/users/OpenDungeons/following{/other_user}","gists_url":"https://api.github.com/users/OpenDungeons/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenDungeons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenDungeons/subscriptions","organizations_url":"https://api.github.com/users/OpenDungeons/orgs","repos_url":"https://api.github.com/users/OpenDungeons/repos","events_url":"https://api.github.com/users/OpenDungeons/events{/privacy}","received_events_url":"https://api.github.com/users/OpenDungeons/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenDungeons/OpenDungeons","description":"Open source game inspired by Dungeon Keeper - Dark, damp and dangerous...","fork":false,"url":"https://api.github.com/repos/OpenDungeons/OpenDungeons","forks_url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/forks","keys_url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/teams","hooks_url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/hooks","issue_events_url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/issues/events{/number}","events_url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/events","assignees_url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/assignees{/user}","branches_url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/branches{/branch}","tags_url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/tags","blobs_url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/languages","stargazers_url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/stargazers","contributors_url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/contributors","subscribers_url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/subscribers","subscription_url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/subscription","commits_url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/contents/{+path}","compare_url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/merges","archive_url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/downloads","issues_url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/issues{/number}","pulls_url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/labels{/name}","releases_url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/releases{/id}","deployments_url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/deployments","created_at":"2014-07-29T10:24:41Z","updated_at":"2016-03-19T23:29:02Z","pushed_at":"2016-03-21T20:21:52Z","git_url":"git://github.com/OpenDungeons/OpenDungeons.git","ssh_url":"git@github.com:OpenDungeons/OpenDungeons.git","clone_url":"https://github.com/OpenDungeons/OpenDungeons.git","svn_url":"https://github.com/OpenDungeons/OpenDungeons","homepage":"http://opendungeons.github.io","size":331737,"stargazers_count":70,"watchers_count":70,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"open_issues_count":80,"forks":20,"open_issues":80,"watchers":70,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenDungeons/OpenDungeons/pulls/1130"},"html":{"href":"https://github.com/OpenDungeons/OpenDungeons/pull/1130"},"issue":{"href":"https://api.github.com/repos/OpenDungeons/OpenDungeons/issues/1130"},"comments":{"href":"https://api.github.com/repos/OpenDungeons/OpenDungeons/issues/1130/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenDungeons/OpenDungeons/pulls/1130/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenDungeons/OpenDungeons/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenDungeons/OpenDungeons/pulls/1130/commits"},"statuses":{"href":"https://api.github.com/repos/OpenDungeons/OpenDungeons/statuses/7ddd29e8b401a6f91ae8fe7b545403e6050b73ba"}}}}