{"action":"created","comment":{"url":"https://api.github.com/repos/Binaryvector/HarvestMap/pulls/comments/76908560","id":76908560,"diff_hunk":"@@ -542,9 +574,24 @@ end\n -- @param pinTypeId type of resource from event.\n -- @param itemId unique id of item.\n --\n-function Harvest.ProcessData( map, x, y, measurement, pinTypeId, itemId )\n-\tlocal nodeAdded, nodeUpdated = Harvest.SaveData( map, x, y, measurement, pinTypeId )\n+function Harvest.ProcessData(map, x, y, measurement, pinTypeId, itemId)\n+\tlocal nodeAdded, nodeUpdated, node = Harvest.SaveData(map, x, y, measurement, pinTypeId)\n+\tlocal pinType = Harvest.GetPinType(pinTypeId)\n+\tif (nodeAdded or nodeUpdated) and Harvest.IsHiddenOnHarvest() then\n+\t\t-- If node updated. its pin already removed TODO fix this behavior.\\\n+\t\t-- don't redraw the pin, if the respawn timer is used for recently harvested ressources\n+\t\tif not node.hidden then\n+\t\t\tHarvest.Debug( \"respawn timer has hidden a pin of pin type \" .. tostring(pinType) )\n+\t\t\tnode.hidden = true\n+\t\tend\n+\t\tHarvest.Debug( \"Pin hidden because its harvested just now.\")\n+\t\tnode.time = GetFrameTimeSeconds()\n+\telseif (nodeAdded or nodeUpdated) then\n+\t\tnode.hidden = false","path":"HarvestMap/HarvestMap.lua","position":329,"original_position":329,"commit_id":"457ee93a445061e9e7f969c7960e17854dfdd6e6","original_commit_id":"457ee93a445061e9e7f969c7960e17854dfdd6e6","user":{"login":"MrUpyachka","id":8611542,"avatar_url":"https://avatars.githubusercontent.com/u/8611542?v=3","gravatar_id":"","url":"https://api.github.com/users/MrUpyachka","html_url":"https://github.com/MrUpyachka","followers_url":"https://api.github.com/users/MrUpyachka/followers","following_url":"https://api.github.com/users/MrUpyachka/following{/other_user}","gists_url":"https://api.github.com/users/MrUpyachka/gists{/gist_id}","starred_url":"https://api.github.com/users/MrUpyachka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrUpyachka/subscriptions","organizations_url":"https://api.github.com/users/MrUpyachka/orgs","repos_url":"https://api.github.com/users/MrUpyachka/repos","events_url":"https://api.github.com/users/MrUpyachka/events{/privacy}","received_events_url":"https://api.github.com/users/MrUpyachka/received_events","type":"User","site_admin":false},"body":"Actually not, is it possible to remove pins if x and y in data already changed? Seems that not so we still need to remove pin first for existing node and only after update x and y. See line 419. Or maybe I'm wrong. Why do we need to specify x and Y for remove function of compass and map?","created_at":"2016-08-31T01:07:31Z","updated_at":"2016-08-31T01:07:31Z","html_url":"https://github.com/Binaryvector/HarvestMap/pull/3#discussion_r76908560","pull_request_url":"https://api.github.com/repos/Binaryvector/HarvestMap/pulls/3","_links":{"self":{"href":"https://api.github.com/repos/Binaryvector/HarvestMap/pulls/comments/76908560"},"html":{"href":"https://github.com/Binaryvector/HarvestMap/pull/3#discussion_r76908560"},"pull_request":{"href":"https://api.github.com/repos/Binaryvector/HarvestMap/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/Binaryvector/HarvestMap/pulls/3","id":83143909,"html_url":"https://github.com/Binaryvector/HarvestMap/pull/3","diff_url":"https://github.com/Binaryvector/HarvestMap/pull/3.diff","patch_url":"https://github.com/Binaryvector/HarvestMap/pull/3.patch","issue_url":"https://api.github.com/repos/Binaryvector/HarvestMap/issues/3","number":3,"state":"open","locked":false,"title":"Indev","user":{"login":"MrUpyachka","id":8611542,"avatar_url":"https://avatars.githubusercontent.com/u/8611542?v=3","gravatar_id":"","url":"https://api.github.com/users/MrUpyachka","html_url":"https://github.com/MrUpyachka","followers_url":"https://api.github.com/users/MrUpyachka/followers","following_url":"https://api.github.com/users/MrUpyachka/following{/other_user}","gists_url":"https://api.github.com/users/MrUpyachka/gists{/gist_id}","starred_url":"https://api.github.com/users/MrUpyachka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrUpyachka/subscriptions","organizations_url":"https://api.github.com/users/MrUpyachka/orgs","repos_url":"https://api.github.com/users/MrUpyachka/repos","events_url":"https://api.github.com/users/MrUpyachka/events{/privacy}","received_events_url":"https://api.github.com/users/MrUpyachka/received_events","type":"User","site_admin":false},"body":"Hello,\r\nI hope that i'm not intrusive. \r\nAs soon as you have multiple pin controllers/managers - better to operate with them through an adapter. This will help you with refactoring or any update of code - you do need to fix in multiple places, only inside one function.","created_at":"2016-08-29T18:25:49Z","updated_at":"2016-08-31T01:07:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Binaryvector/HarvestMap/pulls/3/commits","review_comments_url":"https://api.github.com/repos/Binaryvector/HarvestMap/pulls/3/comments","review_comment_url":"https://api.github.com/repos/Binaryvector/HarvestMap/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Binaryvector/HarvestMap/issues/3/comments","statuses_url":"https://api.github.com/repos/Binaryvector/HarvestMap/statuses/457ee93a445061e9e7f969c7960e17854dfdd6e6","head":{"label":"MrUpyachka:indev","ref":"indev","sha":"457ee93a445061e9e7f969c7960e17854dfdd6e6","user":{"login":"MrUpyachka","id":8611542,"avatar_url":"https://avatars.githubusercontent.com/u/8611542?v=3","gravatar_id":"","url":"https://api.github.com/users/MrUpyachka","html_url":"https://github.com/MrUpyachka","followers_url":"https://api.github.com/users/MrUpyachka/followers","following_url":"https://api.github.com/users/MrUpyachka/following{/other_user}","gists_url":"https://api.github.com/users/MrUpyachka/gists{/gist_id}","starred_url":"https://api.github.com/users/MrUpyachka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrUpyachka/subscriptions","organizations_url":"https://api.github.com/users/MrUpyachka/orgs","repos_url":"https://api.github.com/users/MrUpyachka/repos","events_url":"https://api.github.com/users/MrUpyachka/events{/privacy}","received_events_url":"https://api.github.com/users/MrUpyachka/received_events","type":"User","site_admin":false},"repo":{"id":66851527,"name":"HarvestMap","full_name":"MrUpyachka/HarvestMap","owner":{"login":"MrUpyachka","id":8611542,"avatar_url":"https://avatars.githubusercontent.com/u/8611542?v=3","gravatar_id":"","url":"https://api.github.com/users/MrUpyachka","html_url":"https://github.com/MrUpyachka","followers_url":"https://api.github.com/users/MrUpyachka/followers","following_url":"https://api.github.com/users/MrUpyachka/following{/other_user}","gists_url":"https://api.github.com/users/MrUpyachka/gists{/gist_id}","starred_url":"https://api.github.com/users/MrUpyachka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrUpyachka/subscriptions","organizations_url":"https://api.github.com/users/MrUpyachka/orgs","repos_url":"https://api.github.com/users/MrUpyachka/repos","events_url":"https://api.github.com/users/MrUpyachka/events{/privacy}","received_events_url":"https://api.github.com/users/MrUpyachka/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MrUpyachka/HarvestMap","description":null,"fork":true,"url":"https://api.github.com/repos/MrUpyachka/HarvestMap","forks_url":"https://api.github.com/repos/MrUpyachka/HarvestMap/forks","keys_url":"https://api.github.com/repos/MrUpyachka/HarvestMap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MrUpyachka/HarvestMap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MrUpyachka/HarvestMap/teams","hooks_url":"https://api.github.com/repos/MrUpyachka/HarvestMap/hooks","issue_events_url":"https://api.github.com/repos/MrUpyachka/HarvestMap/issues/events{/number}","events_url":"https://api.github.com/repos/MrUpyachka/HarvestMap/events","assignees_url":"https://api.github.com/repos/MrUpyachka/HarvestMap/assignees{/user}","branches_url":"https://api.github.com/repos/MrUpyachka/HarvestMap/branches{/branch}","tags_url":"https://api.github.com/repos/MrUpyachka/HarvestMap/tags","blobs_url":"https://api.github.com/repos/MrUpyachka/HarvestMap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MrUpyachka/HarvestMap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MrUpyachka/HarvestMap/git/refs{/sha}","trees_url":"https://api.github.com/repos/MrUpyachka/HarvestMap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MrUpyachka/HarvestMap/statuses/{sha}","languages_url":"https://api.github.com/repos/MrUpyachka/HarvestMap/languages","stargazers_url":"https://api.github.com/repos/MrUpyachka/HarvestMap/stargazers","contributors_url":"https://api.github.com/repos/MrUpyachka/HarvestMap/contributors","subscribers_url":"https://api.github.com/repos/MrUpyachka/HarvestMap/subscribers","subscription_url":"https://api.github.com/repos/MrUpyachka/HarvestMap/subscription","commits_url":"https://api.github.com/repos/MrUpyachka/HarvestMap/commits{/sha}","git_commits_url":"https://api.github.com/repos/MrUpyachka/HarvestMap/git/commits{/sha}","comments_url":"https://api.github.com/repos/MrUpyachka/HarvestMap/comments{/number}","issue_comment_url":"https://api.github.com/repos/MrUpyachka/HarvestMap/issues/comments{/number}","contents_url":"https://api.github.com/repos/MrUpyachka/HarvestMap/contents/{+path}","compare_url":"https://api.github.com/repos/MrUpyachka/HarvestMap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MrUpyachka/HarvestMap/merges","archive_url":"https://api.github.com/repos/MrUpyachka/HarvestMap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MrUpyachka/HarvestMap/downloads","issues_url":"https://api.github.com/repos/MrUpyachka/HarvestMap/issues{/number}","pulls_url":"https://api.github.com/repos/MrUpyachka/HarvestMap/pulls{/number}","milestones_url":"https://api.github.com/repos/MrUpyachka/HarvestMap/milestones{/number}","notifications_url":"https://api.github.com/repos/MrUpyachka/HarvestMap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MrUpyachka/HarvestMap/labels{/name}","releases_url":"https://api.github.com/repos/MrUpyachka/HarvestMap/releases{/id}","deployments_url":"https://api.github.com/repos/MrUpyachka/HarvestMap/deployments","created_at":"2016-08-29T14:33:52Z","updated_at":"2016-08-29T14:33:54Z","pushed_at":"2016-08-29T21:56:39Z","git_url":"git://github.com/MrUpyachka/HarvestMap.git","ssh_url":"git@github.com:MrUpyachka/HarvestMap.git","clone_url":"https://github.com/MrUpyachka/HarvestMap.git","svn_url":"https://github.com/MrUpyachka/HarvestMap","homepage":"http://www.esoui.com/downloads/fileinfo.php?id=57","size":319,"stargazers_count":0,"watchers_count":0,"language":"Lua","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Binaryvector:indev","ref":"indev","sha":"074ccb06376f6666bed4ca6c8798f09ab9c3aaf9","user":{"login":"Binaryvector","id":5149088,"avatar_url":"https://avatars.githubusercontent.com/u/5149088?v=3","gravatar_id":"","url":"https://api.github.com/users/Binaryvector","html_url":"https://github.com/Binaryvector","followers_url":"https://api.github.com/users/Binaryvector/followers","following_url":"https://api.github.com/users/Binaryvector/following{/other_user}","gists_url":"https://api.github.com/users/Binaryvector/gists{/gist_id}","starred_url":"https://api.github.com/users/Binaryvector/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Binaryvector/subscriptions","organizations_url":"https://api.github.com/users/Binaryvector/orgs","repos_url":"https://api.github.com/users/Binaryvector/repos","events_url":"https://api.github.com/users/Binaryvector/events{/privacy}","received_events_url":"https://api.github.com/users/Binaryvector/received_events","type":"User","site_admin":false},"repo":{"id":66766330,"name":"HarvestMap","full_name":"Binaryvector/HarvestMap","owner":{"login":"Binaryvector","id":5149088,"avatar_url":"https://avatars.githubusercontent.com/u/5149088?v=3","gravatar_id":"","url":"https://api.github.com/users/Binaryvector","html_url":"https://github.com/Binaryvector","followers_url":"https://api.github.com/users/Binaryvector/followers","following_url":"https://api.github.com/users/Binaryvector/following{/other_user}","gists_url":"https://api.github.com/users/Binaryvector/gists{/gist_id}","starred_url":"https://api.github.com/users/Binaryvector/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Binaryvector/subscriptions","organizations_url":"https://api.github.com/users/Binaryvector/orgs","repos_url":"https://api.github.com/users/Binaryvector/repos","events_url":"https://api.github.com/users/Binaryvector/events{/privacy}","received_events_url":"https://api.github.com/users/Binaryvector/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Binaryvector/HarvestMap","description":null,"fork":false,"url":"https://api.github.com/repos/Binaryvector/HarvestMap","forks_url":"https://api.github.com/repos/Binaryvector/HarvestMap/forks","keys_url":"https://api.github.com/repos/Binaryvector/HarvestMap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Binaryvector/HarvestMap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Binaryvector/HarvestMap/teams","hooks_url":"https://api.github.com/repos/Binaryvector/HarvestMap/hooks","issue_events_url":"https://api.github.com/repos/Binaryvector/HarvestMap/issues/events{/number}","events_url":"https://api.github.com/repos/Binaryvector/HarvestMap/events","assignees_url":"https://api.github.com/repos/Binaryvector/HarvestMap/assignees{/user}","branches_url":"https://api.github.com/repos/Binaryvector/HarvestMap/branches{/branch}","tags_url":"https://api.github.com/repos/Binaryvector/HarvestMap/tags","blobs_url":"https://api.github.com/repos/Binaryvector/HarvestMap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Binaryvector/HarvestMap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Binaryvector/HarvestMap/git/refs{/sha}","trees_url":"https://api.github.com/repos/Binaryvector/HarvestMap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Binaryvector/HarvestMap/statuses/{sha}","languages_url":"https://api.github.com/repos/Binaryvector/HarvestMap/languages","stargazers_url":"https://api.github.com/repos/Binaryvector/HarvestMap/stargazers","contributors_url":"https://api.github.com/repos/Binaryvector/HarvestMap/contributors","subscribers_url":"https://api.github.com/repos/Binaryvector/HarvestMap/subscribers","subscription_url":"https://api.github.com/repos/Binaryvector/HarvestMap/subscription","commits_url":"https://api.github.com/repos/Binaryvector/HarvestMap/commits{/sha}","git_commits_url":"https://api.github.com/repos/Binaryvector/HarvestMap/git/commits{/sha}","comments_url":"https://api.github.com/repos/Binaryvector/HarvestMap/comments{/number}","issue_comment_url":"https://api.github.com/repos/Binaryvector/HarvestMap/issues/comments{/number}","contents_url":"https://api.github.com/repos/Binaryvector/HarvestMap/contents/{+path}","compare_url":"https://api.github.com/repos/Binaryvector/HarvestMap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Binaryvector/HarvestMap/merges","archive_url":"https://api.github.com/repos/Binaryvector/HarvestMap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Binaryvector/HarvestMap/downloads","issues_url":"https://api.github.com/repos/Binaryvector/HarvestMap/issues{/number}","pulls_url":"https://api.github.com/repos/Binaryvector/HarvestMap/pulls{/number}","milestones_url":"https://api.github.com/repos/Binaryvector/HarvestMap/milestones{/number}","notifications_url":"https://api.github.com/repos/Binaryvector/HarvestMap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Binaryvector/HarvestMap/labels{/name}","releases_url":"https://api.github.com/repos/Binaryvector/HarvestMap/releases{/id}","deployments_url":"https://api.github.com/repos/Binaryvector/HarvestMap/deployments","created_at":"2016-08-28T12:11:54Z","updated_at":"2016-08-28T19:03:54Z","pushed_at":"2016-08-30T22:55:56Z","git_url":"git://github.com/Binaryvector/HarvestMap.git","ssh_url":"git@github.com:Binaryvector/HarvestMap.git","clone_url":"https://github.com/Binaryvector/HarvestMap.git","svn_url":"https://github.com/Binaryvector/HarvestMap","homepage":"http://www.esoui.com/downloads/fileinfo.php?id=57","size":337,"stargazers_count":1,"watchers_count":1,"language":"Lua","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Binaryvector/HarvestMap/pulls/3"},"html":{"href":"https://github.com/Binaryvector/HarvestMap/pull/3"},"issue":{"href":"https://api.github.com/repos/Binaryvector/HarvestMap/issues/3"},"comments":{"href":"https://api.github.com/repos/Binaryvector/HarvestMap/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/Binaryvector/HarvestMap/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/Binaryvector/HarvestMap/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Binaryvector/HarvestMap/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/Binaryvector/HarvestMap/statuses/457ee93a445061e9e7f969c7960e17854dfdd6e6"}}}}
{"actor":{"display_login":"MrUpyachka"}}