{"action":"created","comment":{"url":"https://api.github.com/repos/php/php-src/pulls/comments/75600341","id":75600341,"diff_hunk":"@@ -2445,6 +2445,66 @@ PHP_FUNCTION(substr)\n }\n /* }}} */\n \n+/* {{{ proto boolean str_begin(string search_value, string str)\n+   Checks if str begins with search_value */\n+PHP_FUNCTION(str_begin) {\n+\tzend_string *str, *search_value;\n+\tint i;\n+\n+\tif (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, \"SS\", &search_value, &str) == FAILURE) \n+\t\tRETURN_NULL();\n+\n+\tfor (i = 0; i < search_value->len; i++) \n+\t\tif (str->val[i] != search_value->val[i]) ","path":"ext/standard/string.c","position":14,"original_position":14,"commit_id":"65f9b81629d80df33f0477e70620c7f6c99bafa3","original_commit_id":"65f9b81629d80df33f0477e70620c7f6c99bafa3","user":{"login":"BePsvPT","id":8221099,"avatar_url":"https://avatars.githubusercontent.com/u/8221099?v=3","gravatar_id":"","url":"https://api.github.com/users/BePsvPT","html_url":"https://github.com/BePsvPT","followers_url":"https://api.github.com/users/BePsvPT/followers","following_url":"https://api.github.com/users/BePsvPT/following{/other_user}","gists_url":"https://api.github.com/users/BePsvPT/gists{/gist_id}","starred_url":"https://api.github.com/users/BePsvPT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BePsvPT/subscriptions","organizations_url":"https://api.github.com/users/BePsvPT/orgs","repos_url":"https://api.github.com/users/BePsvPT/repos","events_url":"https://api.github.com/users/BePsvPT/events{/privacy}","received_events_url":"https://api.github.com/users/BePsvPT/received_events","type":"User","site_admin":false},"body":"When the length of search_value is greater than str, maybe it will access out of bounds?","created_at":"2016-08-21T18:08:56Z","updated_at":"2016-08-21T18:08:56Z","html_url":"https://github.com/php/php-src/pull/2049#discussion_r75600341","pull_request_url":"https://api.github.com/repos/php/php-src/pulls/2049","_links":{"self":{"href":"https://api.github.com/repos/php/php-src/pulls/comments/75600341"},"html":{"href":"https://github.com/php/php-src/pull/2049#discussion_r75600341"},"pull_request":{"href":"https://api.github.com/repos/php/php-src/pulls/2049"}}},"pull_request":{"url":"https://api.github.com/repos/php/php-src/pulls/2049","id":79649657,"html_url":"https://github.com/php/php-src/pull/2049","diff_url":"https://github.com/php/php-src/pull/2049.diff","patch_url":"https://github.com/php/php-src/pull/2049.patch","issue_url":"https://api.github.com/repos/php/php-src/issues/2049","number":2049,"state":"open","locked":false,"title":"Patch add str begins and ends","user":{"login":"wkhudgins92","id":12834376,"avatar_url":"https://avatars.githubusercontent.com/u/12834376?v=3","gravatar_id":"","url":"https://api.github.com/users/wkhudgins92","html_url":"https://github.com/wkhudgins92","followers_url":"https://api.github.com/users/wkhudgins92/followers","following_url":"https://api.github.com/users/wkhudgins92/following{/other_user}","gists_url":"https://api.github.com/users/wkhudgins92/gists{/gist_id}","starred_url":"https://api.github.com/users/wkhudgins92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wkhudgins92/subscriptions","organizations_url":"https://api.github.com/users/wkhudgins92/orgs","repos_url":"https://api.github.com/users/wkhudgins92/repos","events_url":"https://api.github.com/users/wkhudgins92/events{/privacy}","received_events_url":"https://api.github.com/users/wkhudgins92/received_events","type":"User","site_admin":false},"body":"This is the patch for RFC\r\nhttps://wiki.php.net/rfc/add_str_begin_and_end_functions\r\n\r\nThis PR contains the implementations of str_begins() and str_ends() and also the phpt tests.","created_at":"2016-08-01T22:46:30Z","updated_at":"2016-08-21T18:08:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"679b9655347dc4a2bcc5481c09f3528b4e47f934","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/php/php-src/pulls/2049/commits","review_comments_url":"https://api.github.com/repos/php/php-src/pulls/2049/comments","review_comment_url":"https://api.github.com/repos/php/php-src/pulls/comments{/number}","comments_url":"https://api.github.com/repos/php/php-src/issues/2049/comments","statuses_url":"https://api.github.com/repos/php/php-src/statuses/65f9b81629d80df33f0477e70620c7f6c99bafa3","head":{"label":"wkhudgins92:patch-add-str_begins-and-ends","ref":"patch-add-str_begins-and-ends","sha":"65f9b81629d80df33f0477e70620c7f6c99bafa3","user":{"login":"wkhudgins92","id":12834376,"avatar_url":"https://avatars.githubusercontent.com/u/12834376?v=3","gravatar_id":"","url":"https://api.github.com/users/wkhudgins92","html_url":"https://github.com/wkhudgins92","followers_url":"https://api.github.com/users/wkhudgins92/followers","following_url":"https://api.github.com/users/wkhudgins92/following{/other_user}","gists_url":"https://api.github.com/users/wkhudgins92/gists{/gist_id}","starred_url":"https://api.github.com/users/wkhudgins92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wkhudgins92/subscriptions","organizations_url":"https://api.github.com/users/wkhudgins92/orgs","repos_url":"https://api.github.com/users/wkhudgins92/repos","events_url":"https://api.github.com/users/wkhudgins92/events{/privacy}","received_events_url":"https://api.github.com/users/wkhudgins92/received_events","type":"User","site_admin":false},"repo":{"id":64154383,"name":"php-src","full_name":"wkhudgins92/php-src","owner":{"login":"wkhudgins92","id":12834376,"avatar_url":"https://avatars.githubusercontent.com/u/12834376?v=3","gravatar_id":"","url":"https://api.github.com/users/wkhudgins92","html_url":"https://github.com/wkhudgins92","followers_url":"https://api.github.com/users/wkhudgins92/followers","following_url":"https://api.github.com/users/wkhudgins92/following{/other_user}","gists_url":"https://api.github.com/users/wkhudgins92/gists{/gist_id}","starred_url":"https://api.github.com/users/wkhudgins92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wkhudgins92/subscriptions","organizations_url":"https://api.github.com/users/wkhudgins92/orgs","repos_url":"https://api.github.com/users/wkhudgins92/repos","events_url":"https://api.github.com/users/wkhudgins92/events{/privacy}","received_events_url":"https://api.github.com/users/wkhudgins92/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wkhudgins92/php-src","description":"The PHP Interpreter","fork":true,"url":"https://api.github.com/repos/wkhudgins92/php-src","forks_url":"https://api.github.com/repos/wkhudgins92/php-src/forks","keys_url":"https://api.github.com/repos/wkhudgins92/php-src/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wkhudgins92/php-src/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wkhudgins92/php-src/teams","hooks_url":"https://api.github.com/repos/wkhudgins92/php-src/hooks","issue_events_url":"https://api.github.com/repos/wkhudgins92/php-src/issues/events{/number}","events_url":"https://api.github.com/repos/wkhudgins92/php-src/events","assignees_url":"https://api.github.com/repos/wkhudgins92/php-src/assignees{/user}","branches_url":"https://api.github.com/repos/wkhudgins92/php-src/branches{/branch}","tags_url":"https://api.github.com/repos/wkhudgins92/php-src/tags","blobs_url":"https://api.github.com/repos/wkhudgins92/php-src/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wkhudgins92/php-src/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wkhudgins92/php-src/git/refs{/sha}","trees_url":"https://api.github.com/repos/wkhudgins92/php-src/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wkhudgins92/php-src/statuses/{sha}","languages_url":"https://api.github.com/repos/wkhudgins92/php-src/languages","stargazers_url":"https://api.github.com/repos/wkhudgins92/php-src/stargazers","contributors_url":"https://api.github.com/repos/wkhudgins92/php-src/contributors","subscribers_url":"https://api.github.com/repos/wkhudgins92/php-src/subscribers","subscription_url":"https://api.github.com/repos/wkhudgins92/php-src/subscription","commits_url":"https://api.github.com/repos/wkhudgins92/php-src/commits{/sha}","git_commits_url":"https://api.github.com/repos/wkhudgins92/php-src/git/commits{/sha}","comments_url":"https://api.github.com/repos/wkhudgins92/php-src/comments{/number}","issue_comment_url":"https://api.github.com/repos/wkhudgins92/php-src/issues/comments{/number}","contents_url":"https://api.github.com/repos/wkhudgins92/php-src/contents/{+path}","compare_url":"https://api.github.com/repos/wkhudgins92/php-src/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wkhudgins92/php-src/merges","archive_url":"https://api.github.com/repos/wkhudgins92/php-src/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wkhudgins92/php-src/downloads","issues_url":"https://api.github.com/repos/wkhudgins92/php-src/issues{/number}","pulls_url":"https://api.github.com/repos/wkhudgins92/php-src/pulls{/number}","milestones_url":"https://api.github.com/repos/wkhudgins92/php-src/milestones{/number}","notifications_url":"https://api.github.com/repos/wkhudgins92/php-src/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wkhudgins92/php-src/labels{/name}","releases_url":"https://api.github.com/repos/wkhudgins92/php-src/releases{/id}","deployments_url":"https://api.github.com/repos/wkhudgins92/php-src/deployments","created_at":"2016-07-25T17:29:02Z","updated_at":"2016-07-25T17:30:02Z","pushed_at":"2016-08-12T22:45:19Z","git_url":"git://github.com/wkhudgins92/php-src.git","ssh_url":"git@github.com:wkhudgins92/php-src.git","clone_url":"https://github.com/wkhudgins92/php-src.git","svn_url":"https://github.com/wkhudgins92/php-src","homepage":"http://www.php.net","size":250087,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"php:master","ref":"master","sha":"7b4157d2c46c90b9d2b3430f4e2e417e1f70876b","user":{"login":"php","id":25158,"avatar_url":"https://avatars.githubusercontent.com/u/25158?v=3","gravatar_id":"","url":"https://api.github.com/users/php","html_url":"https://github.com/php","followers_url":"https://api.github.com/users/php/followers","following_url":"https://api.github.com/users/php/following{/other_user}","gists_url":"https://api.github.com/users/php/gists{/gist_id}","starred_url":"https://api.github.com/users/php/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/php/subscriptions","organizations_url":"https://api.github.com/users/php/orgs","repos_url":"https://api.github.com/users/php/repos","events_url":"https://api.github.com/users/php/events{/privacy}","received_events_url":"https://api.github.com/users/php/received_events","type":"Organization","site_admin":false},"repo":{"id":1903522,"name":"php-src","full_name":"php/php-src","owner":{"login":"php","id":25158,"avatar_url":"https://avatars.githubusercontent.com/u/25158?v=3","gravatar_id":"","url":"https://api.github.com/users/php","html_url":"https://github.com/php","followers_url":"https://api.github.com/users/php/followers","following_url":"https://api.github.com/users/php/following{/other_user}","gists_url":"https://api.github.com/users/php/gists{/gist_id}","starred_url":"https://api.github.com/users/php/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/php/subscriptions","organizations_url":"https://api.github.com/users/php/orgs","repos_url":"https://api.github.com/users/php/repos","events_url":"https://api.github.com/users/php/events{/privacy}","received_events_url":"https://api.github.com/users/php/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/php/php-src","description":"The PHP Interpreter","fork":false,"url":"https://api.github.com/repos/php/php-src","forks_url":"https://api.github.com/repos/php/php-src/forks","keys_url":"https://api.github.com/repos/php/php-src/keys{/key_id}","collaborators_url":"https://api.github.com/repos/php/php-src/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/php/php-src/teams","hooks_url":"https://api.github.com/repos/php/php-src/hooks","issue_events_url":"https://api.github.com/repos/php/php-src/issues/events{/number}","events_url":"https://api.github.com/repos/php/php-src/events","assignees_url":"https://api.github.com/repos/php/php-src/assignees{/user}","branches_url":"https://api.github.com/repos/php/php-src/branches{/branch}","tags_url":"https://api.github.com/repos/php/php-src/tags","blobs_url":"https://api.github.com/repos/php/php-src/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/php/php-src/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/php/php-src/git/refs{/sha}","trees_url":"https://api.github.com/repos/php/php-src/git/trees{/sha}","statuses_url":"https://api.github.com/repos/php/php-src/statuses/{sha}","languages_url":"https://api.github.com/repos/php/php-src/languages","stargazers_url":"https://api.github.com/repos/php/php-src/stargazers","contributors_url":"https://api.github.com/repos/php/php-src/contributors","subscribers_url":"https://api.github.com/repos/php/php-src/subscribers","subscription_url":"https://api.github.com/repos/php/php-src/subscription","commits_url":"https://api.github.com/repos/php/php-src/commits{/sha}","git_commits_url":"https://api.github.com/repos/php/php-src/git/commits{/sha}","comments_url":"https://api.github.com/repos/php/php-src/comments{/number}","issue_comment_url":"https://api.github.com/repos/php/php-src/issues/comments{/number}","contents_url":"https://api.github.com/repos/php/php-src/contents/{+path}","compare_url":"https://api.github.com/repos/php/php-src/compare/{base}...{head}","merges_url":"https://api.github.com/repos/php/php-src/merges","archive_url":"https://api.github.com/repos/php/php-src/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/php/php-src/downloads","issues_url":"https://api.github.com/repos/php/php-src/issues{/number}","pulls_url":"https://api.github.com/repos/php/php-src/pulls{/number}","milestones_url":"https://api.github.com/repos/php/php-src/milestones{/number}","notifications_url":"https://api.github.com/repos/php/php-src/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/php/php-src/labels{/name}","releases_url":"https://api.github.com/repos/php/php-src/releases{/id}","deployments_url":"https://api.github.com/repos/php/php-src/deployments","created_at":"2011-06-16T01:52:25Z","updated_at":"2016-08-21T17:58:43Z","pushed_at":"2016-08-21T18:07:36Z","git_url":"git://github.com/php/php-src.git","ssh_url":"git@github.com:php/php-src.git","clone_url":"https://github.com/php/php-src.git","svn_url":"https://github.com/php/php-src","homepage":"http://www.php.net","size":411341,"stargazers_count":9787,"watchers_count":9787,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3425,"mirror_url":null,"open_issues_count":323,"forks":3425,"open_issues":323,"watchers":9787,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/php/php-src/pulls/2049"},"html":{"href":"https://github.com/php/php-src/pull/2049"},"issue":{"href":"https://api.github.com/repos/php/php-src/issues/2049"},"comments":{"href":"https://api.github.com/repos/php/php-src/issues/2049/comments"},"review_comments":{"href":"https://api.github.com/repos/php/php-src/pulls/2049/comments"},"review_comment":{"href":"https://api.github.com/repos/php/php-src/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/php/php-src/pulls/2049/commits"},"statuses":{"href":"https://api.github.com/repos/php/php-src/statuses/65f9b81629d80df33f0477e70620c7f6c99bafa3"}}}}
{"actor":{"display_login":"BePsvPT"}}