{"action":"created","comment":{"url":"https://api.github.com/repos/erlang/otp/pulls/comments/56643493","id":56643493,"diff_hunk":"@@ -224,13 +240,10 @@ start(Config, MgrAgentConfName, SnmpAppConfName) ->\n     application:start(snmp),\n \n     manager_register(StartManager, MgrAgentConfName).\n- \n-%%% @spec stop(Config) -> ok\n-%%%      Config = [{Key, Value}]\n-%%%      Key = atom()\n-%%%      Value = term()\n-%%%\n+\n %%% @doc Stops the snmp manager and/or agent removes all files created.\n+-spec stop(Config) -> ok when\n+      Config :: agent_config().","path":"lib/common_test/src/ct_snmp.erl","position":151,"original_position":151,"commit_id":"6c2642601555d2b58045a99c985111d7d89b40aa","original_commit_id":"6c2642601555d2b58045a99c985111d7d89b40aa","user":{"login":"sirihansen","id":3234528,"avatar_url":"https://avatars.githubusercontent.com/u/3234528?v=3","gravatar_id":"","url":"https://api.github.com/users/sirihansen","html_url":"https://github.com/sirihansen","followers_url":"https://api.github.com/users/sirihansen/followers","following_url":"https://api.github.com/users/sirihansen/following{/other_user}","gists_url":"https://api.github.com/users/sirihansen/gists{/gist_id}","starred_url":"https://api.github.com/users/sirihansen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sirihansen/subscriptions","organizations_url":"https://api.github.com/users/sirihansen/orgs","repos_url":"https://api.github.com/users/sirihansen/repos","events_url":"https://api.github.com/users/sirihansen/events{/privacy}","received_events_url":"https://api.github.com/users/sirihansen/received_events","type":"User","site_admin":false},"body":"This should not be agent_config(). It is the Config variable from the test case, defined as [{Key,Value}], where Key::atom(), Value::term().","created_at":"2016-03-18T11:31:24Z","updated_at":"2016-03-18T11:31:24Z","html_url":"https://github.com/erlang/otp/pull/935#discussion_r56643493","pull_request_url":"https://api.github.com/repos/erlang/otp/pulls/935","_links":{"self":{"href":"https://api.github.com/repos/erlang/otp/pulls/comments/56643493"},"html":{"href":"https://github.com/erlang/otp/pull/935#discussion_r56643493"},"pull_request":{"href":"https://api.github.com/repos/erlang/otp/pulls/935"}}},"pull_request":{"url":"https://api.github.com/repos/erlang/otp/pulls/935","id":55633714,"html_url":"https://github.com/erlang/otp/pull/935","diff_url":"https://github.com/erlang/otp/pull/935.diff","patch_url":"https://github.com/erlang/otp/pull/935.patch","issue_url":"https://api.github.com/repos/erlang/otp/issues/935","number":935,"state":"open","locked":false,"title":"Declare documented but undeclared types","user":{"login":"fenollp","id":278727,"avatar_url":"https://avatars.githubusercontent.com/u/278727?v=3","gravatar_id":"","url":"https://api.github.com/users/fenollp","html_url":"https://github.com/fenollp","followers_url":"https://api.github.com/users/fenollp/followers","following_url":"https://api.github.com/users/fenollp/following{/other_user}","gists_url":"https://api.github.com/users/fenollp/gists{/gist_id}","starred_url":"https://api.github.com/users/fenollp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fenollp/subscriptions","organizations_url":"https://api.github.com/users/fenollp/orgs","repos_url":"https://api.github.com/users/fenollp/repos","events_url":"https://api.github.com/users/fenollp/events{/privacy}","received_events_url":"https://api.github.com/users/fenollp/received_events","type":"User","site_admin":false},"body":"Found while toying with github.com/erldocs/erldocs","created_at":"2016-01-11T15:14:15Z","updated_at":"2016-03-18T11:31:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5b26f5c28d58434bcd4fe44225cc7dd22fd455d6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/erlang/otp/pulls/935/commits","review_comments_url":"https://api.github.com/repos/erlang/otp/pulls/935/comments","review_comment_url":"https://api.github.com/repos/erlang/otp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/erlang/otp/issues/935/comments","statuses_url":"https://api.github.com/repos/erlang/otp/statuses/6c2642601555d2b58045a99c985111d7d89b40aa","head":{"label":"fenollp:declare-documented-types","ref":"declare-documented-types","sha":"6c2642601555d2b58045a99c985111d7d89b40aa","user":{"login":"fenollp","id":278727,"avatar_url":"https://avatars.githubusercontent.com/u/278727?v=3","gravatar_id":"","url":"https://api.github.com/users/fenollp","html_url":"https://github.com/fenollp","followers_url":"https://api.github.com/users/fenollp/followers","following_url":"https://api.github.com/users/fenollp/following{/other_user}","gists_url":"https://api.github.com/users/fenollp/gists{/gist_id}","starred_url":"https://api.github.com/users/fenollp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fenollp/subscriptions","organizations_url":"https://api.github.com/users/fenollp/orgs","repos_url":"https://api.github.com/users/fenollp/repos","events_url":"https://api.github.com/users/fenollp/events{/privacy}","received_events_url":"https://api.github.com/users/fenollp/received_events","type":"User","site_admin":false},"repo":{"id":12706868,"name":"otp","full_name":"fenollp/otp","owner":{"login":"fenollp","id":278727,"avatar_url":"https://avatars.githubusercontent.com/u/278727?v=3","gravatar_id":"","url":"https://api.github.com/users/fenollp","html_url":"https://github.com/fenollp","followers_url":"https://api.github.com/users/fenollp/followers","following_url":"https://api.github.com/users/fenollp/following{/other_user}","gists_url":"https://api.github.com/users/fenollp/gists{/gist_id}","starred_url":"https://api.github.com/users/fenollp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fenollp/subscriptions","organizations_url":"https://api.github.com/users/fenollp/orgs","repos_url":"https://api.github.com/users/fenollp/repos","events_url":"https://api.github.com/users/fenollp/events{/privacy}","received_events_url":"https://api.github.com/users/fenollp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fenollp/otp","description":"Erlang/OTP","fork":true,"url":"https://api.github.com/repos/fenollp/otp","forks_url":"https://api.github.com/repos/fenollp/otp/forks","keys_url":"https://api.github.com/repos/fenollp/otp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fenollp/otp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fenollp/otp/teams","hooks_url":"https://api.github.com/repos/fenollp/otp/hooks","issue_events_url":"https://api.github.com/repos/fenollp/otp/issues/events{/number}","events_url":"https://api.github.com/repos/fenollp/otp/events","assignees_url":"https://api.github.com/repos/fenollp/otp/assignees{/user}","branches_url":"https://api.github.com/repos/fenollp/otp/branches{/branch}","tags_url":"https://api.github.com/repos/fenollp/otp/tags","blobs_url":"https://api.github.com/repos/fenollp/otp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fenollp/otp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fenollp/otp/git/refs{/sha}","trees_url":"https://api.github.com/repos/fenollp/otp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fenollp/otp/statuses/{sha}","languages_url":"https://api.github.com/repos/fenollp/otp/languages","stargazers_url":"https://api.github.com/repos/fenollp/otp/stargazers","contributors_url":"https://api.github.com/repos/fenollp/otp/contributors","subscribers_url":"https://api.github.com/repos/fenollp/otp/subscribers","subscription_url":"https://api.github.com/repos/fenollp/otp/subscription","commits_url":"https://api.github.com/repos/fenollp/otp/commits{/sha}","git_commits_url":"https://api.github.com/repos/fenollp/otp/git/commits{/sha}","comments_url":"https://api.github.com/repos/fenollp/otp/comments{/number}","issue_comment_url":"https://api.github.com/repos/fenollp/otp/issues/comments{/number}","contents_url":"https://api.github.com/repos/fenollp/otp/contents/{+path}","compare_url":"https://api.github.com/repos/fenollp/otp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fenollp/otp/merges","archive_url":"https://api.github.com/repos/fenollp/otp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fenollp/otp/downloads","issues_url":"https://api.github.com/repos/fenollp/otp/issues{/number}","pulls_url":"https://api.github.com/repos/fenollp/otp/pulls{/number}","milestones_url":"https://api.github.com/repos/fenollp/otp/milestones{/number}","notifications_url":"https://api.github.com/repos/fenollp/otp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fenollp/otp/labels{/name}","releases_url":"https://api.github.com/repos/fenollp/otp/releases{/id}","deployments_url":"https://api.github.com/repos/fenollp/otp/deployments","created_at":"2013-09-09T16:48:37Z","updated_at":"2015-08-27T17:22:02Z","pushed_at":"2016-01-14T03:13:20Z","git_url":"git://github.com/fenollp/otp.git","ssh_url":"git@github.com:fenollp/otp.git","clone_url":"https://github.com/fenollp/otp.git","svn_url":"https://github.com/fenollp/otp","homepage":"http://erlang.org","size":141963,"stargazers_count":0,"watchers_count":0,"language":"Erlang","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"maint"}},"base":{"label":"erlang:maint","ref":"maint","sha":"12dffc7f0c85aa4662b97cba4af2c9ae2ba74083","user":{"login":"erlang","id":153393,"avatar_url":"https://avatars.githubusercontent.com/u/153393?v=3","gravatar_id":"","url":"https://api.github.com/users/erlang","html_url":"https://github.com/erlang","followers_url":"https://api.github.com/users/erlang/followers","following_url":"https://api.github.com/users/erlang/following{/other_user}","gists_url":"https://api.github.com/users/erlang/gists{/gist_id}","starred_url":"https://api.github.com/users/erlang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erlang/subscriptions","organizations_url":"https://api.github.com/users/erlang/orgs","repos_url":"https://api.github.com/users/erlang/repos","events_url":"https://api.github.com/users/erlang/events{/privacy}","received_events_url":"https://api.github.com/users/erlang/received_events","type":"Organization","site_admin":false},"repo":{"id":374927,"name":"otp","full_name":"erlang/otp","owner":{"login":"erlang","id":153393,"avatar_url":"https://avatars.githubusercontent.com/u/153393?v=3","gravatar_id":"","url":"https://api.github.com/users/erlang","html_url":"https://github.com/erlang","followers_url":"https://api.github.com/users/erlang/followers","following_url":"https://api.github.com/users/erlang/following{/other_user}","gists_url":"https://api.github.com/users/erlang/gists{/gist_id}","starred_url":"https://api.github.com/users/erlang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erlang/subscriptions","organizations_url":"https://api.github.com/users/erlang/orgs","repos_url":"https://api.github.com/users/erlang/repos","events_url":"https://api.github.com/users/erlang/events{/privacy}","received_events_url":"https://api.github.com/users/erlang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/erlang/otp","description":"Erlang/OTP","fork":false,"url":"https://api.github.com/repos/erlang/otp","forks_url":"https://api.github.com/repos/erlang/otp/forks","keys_url":"https://api.github.com/repos/erlang/otp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/erlang/otp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/erlang/otp/teams","hooks_url":"https://api.github.com/repos/erlang/otp/hooks","issue_events_url":"https://api.github.com/repos/erlang/otp/issues/events{/number}","events_url":"https://api.github.com/repos/erlang/otp/events","assignees_url":"https://api.github.com/repos/erlang/otp/assignees{/user}","branches_url":"https://api.github.com/repos/erlang/otp/branches{/branch}","tags_url":"https://api.github.com/repos/erlang/otp/tags","blobs_url":"https://api.github.com/repos/erlang/otp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/erlang/otp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/erlang/otp/git/refs{/sha}","trees_url":"https://api.github.com/repos/erlang/otp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/erlang/otp/statuses/{sha}","languages_url":"https://api.github.com/repos/erlang/otp/languages","stargazers_url":"https://api.github.com/repos/erlang/otp/stargazers","contributors_url":"https://api.github.com/repos/erlang/otp/contributors","subscribers_url":"https://api.github.com/repos/erlang/otp/subscribers","subscription_url":"https://api.github.com/repos/erlang/otp/subscription","commits_url":"https://api.github.com/repos/erlang/otp/commits{/sha}","git_commits_url":"https://api.github.com/repos/erlang/otp/git/commits{/sha}","comments_url":"https://api.github.com/repos/erlang/otp/comments{/number}","issue_comment_url":"https://api.github.com/repos/erlang/otp/issues/comments{/number}","contents_url":"https://api.github.com/repos/erlang/otp/contents/{+path}","compare_url":"https://api.github.com/repos/erlang/otp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/erlang/otp/merges","archive_url":"https://api.github.com/repos/erlang/otp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/erlang/otp/downloads","issues_url":"https://api.github.com/repos/erlang/otp/issues{/number}","pulls_url":"https://api.github.com/repos/erlang/otp/pulls{/number}","milestones_url":"https://api.github.com/repos/erlang/otp/milestones{/number}","notifications_url":"https://api.github.com/repos/erlang/otp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/erlang/otp/labels{/name}","releases_url":"https://api.github.com/repos/erlang/otp/releases{/id}","deployments_url":"https://api.github.com/repos/erlang/otp/deployments","created_at":"2009-11-16T17:17:57Z","updated_at":"2016-03-18T08:31:55Z","pushed_at":"2016-03-18T10:49:27Z","git_url":"git://github.com/erlang/otp.git","ssh_url":"git@github.com:erlang/otp.git","clone_url":"https://github.com/erlang/otp.git","svn_url":"https://github.com/erlang/otp","homepage":"http://erlang.org","size":193000,"stargazers_count":4301,"watchers_count":4301,"language":"Erlang","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":1276,"mirror_url":null,"open_issues_count":45,"forks":1276,"open_issues":45,"watchers":4301,"default_branch":"maint"}},"_links":{"self":{"href":"https://api.github.com/repos/erlang/otp/pulls/935"},"html":{"href":"https://github.com/erlang/otp/pull/935"},"issue":{"href":"https://api.github.com/repos/erlang/otp/issues/935"},"comments":{"href":"https://api.github.com/repos/erlang/otp/issues/935/comments"},"review_comments":{"href":"https://api.github.com/repos/erlang/otp/pulls/935/comments"},"review_comment":{"href":"https://api.github.com/repos/erlang/otp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/erlang/otp/pulls/935/commits"},"statuses":{"href":"https://api.github.com/repos/erlang/otp/statuses/6c2642601555d2b58045a99c985111d7d89b40aa"}}}}