{"action":"created","comment":{"url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/comments/61883072","id":61883072,"diff_hunk":"@@ -84,7 +88,9 @@\n     insecure keystone_settings[\"insecure\"]\n     host keystone_settings[\"internal_url_host\"]\n     port keystone_settings[\"admin_port\"]\n-    token keystone_settings[\"admin_token\"]\n+    auth({ user: keystone_settings[\"admin_user\"],","path":"chef/cookbooks/tempest/recipes/config.rb","position":27,"original_position":27,"commit_id":"2597c0daa052e1cf7863e7173c7a42ad5e63b320","original_commit_id":"2597c0daa052e1cf7863e7173c7a42ad5e63b320","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Style/BracesAroundHashParameters: Redundant curly braces around a hash parameter.","created_at":"2016-05-03T13:45:44Z","updated_at":"2016-05-03T13:45:44Z","html_url":"https://github.com/crowbar/crowbar-openstack/pull/366#discussion_r61883072","pull_request_url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/366","_links":{"self":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/comments/61883072"},"html":{"href":"https://github.com/crowbar/crowbar-openstack/pull/366#discussion_r61883072"},"pull_request":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/366"}}},"pull_request":{"url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/366","id":68707754,"html_url":"https://github.com/crowbar/crowbar-openstack/pull/366","diff_url":"https://github.com/crowbar/crowbar-openstack/pull/366.diff","patch_url":"https://github.com/crowbar/crowbar-openstack/pull/366.patch","issue_url":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/366","number":366,"state":"open","locked":false,"title":"[UNTESTED] Avoid usage of admin_token in cookbooks","user":{"login":"mmnelemane","id":13483069,"avatar_url":"https://avatars.githubusercontent.com/u/13483069?v=3","gravatar_id":"","url":"https://api.github.com/users/mmnelemane","html_url":"https://github.com/mmnelemane","followers_url":"https://api.github.com/users/mmnelemane/followers","following_url":"https://api.github.com/users/mmnelemane/following{/other_user}","gists_url":"https://api.github.com/users/mmnelemane/gists{/gist_id}","starred_url":"https://api.github.com/users/mmnelemane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmnelemane/subscriptions","organizations_url":"https://api.github.com/users/mmnelemane/orgs","repos_url":"https://api.github.com/users/mmnelemane/repos","events_url":"https://api.github.com/users/mmnelemane/events{/privacy}","received_events_url":"https://api.github.com/users/mmnelemane/received_events","type":"User","site_admin":false},"body":"Keystone register is modified to generate token from user name and password and all the cookbooks (except Trove and Keystone) use this logic instead of directly using the admin_token. There is a follow-up card to handle bootstrapping for Trove and Keystone cookbooks here https://trello.com/c/ipXUuRQl/1052-adapt-usage-of-keystone-manage-bootstrap-for-bootstrapping-keystone-service.","created_at":"2016-05-03T13:45:24Z","updated_at":"2016-05-03T13:45:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3480a26b17b40ca359c79de0b29bbc5d459c6e12","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/366/commits","review_comments_url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/366/comments","review_comment_url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/366/comments","statuses_url":"https://api.github.com/repos/crowbar/crowbar-openstack/statuses/2597c0daa052e1cf7863e7173c7a42ad5e63b320","head":{"label":"mmnelemane:admin_token","ref":"admin_token","sha":"2597c0daa052e1cf7863e7173c7a42ad5e63b320","user":{"login":"mmnelemane","id":13483069,"avatar_url":"https://avatars.githubusercontent.com/u/13483069?v=3","gravatar_id":"","url":"https://api.github.com/users/mmnelemane","html_url":"https://github.com/mmnelemane","followers_url":"https://api.github.com/users/mmnelemane/followers","following_url":"https://api.github.com/users/mmnelemane/following{/other_user}","gists_url":"https://api.github.com/users/mmnelemane/gists{/gist_id}","starred_url":"https://api.github.com/users/mmnelemane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmnelemane/subscriptions","organizations_url":"https://api.github.com/users/mmnelemane/orgs","repos_url":"https://api.github.com/users/mmnelemane/repos","events_url":"https://api.github.com/users/mmnelemane/events{/privacy}","received_events_url":"https://api.github.com/users/mmnelemane/received_events","type":"User","site_admin":false},"repo":{"id":45601858,"name":"crowbar-openstack","full_name":"mmnelemane/crowbar-openstack","owner":{"login":"mmnelemane","id":13483069,"avatar_url":"https://avatars.githubusercontent.com/u/13483069?v=3","gravatar_id":"","url":"https://api.github.com/users/mmnelemane","html_url":"https://github.com/mmnelemane","followers_url":"https://api.github.com/users/mmnelemane/followers","following_url":"https://api.github.com/users/mmnelemane/following{/other_user}","gists_url":"https://api.github.com/users/mmnelemane/gists{/gist_id}","starred_url":"https://api.github.com/users/mmnelemane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmnelemane/subscriptions","organizations_url":"https://api.github.com/users/mmnelemane/orgs","repos_url":"https://api.github.com/users/mmnelemane/repos","events_url":"https://api.github.com/users/mmnelemane/events{/privacy}","received_events_url":"https://api.github.com/users/mmnelemane/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mmnelemane/crowbar-openstack","description":"Openstack deployment for Crowbar","fork":true,"url":"https://api.github.com/repos/mmnelemane/crowbar-openstack","forks_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/forks","keys_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/teams","hooks_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/hooks","issue_events_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/issues/events{/number}","events_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/events","assignees_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/assignees{/user}","branches_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/branches{/branch}","tags_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/tags","blobs_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/statuses/{sha}","languages_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/languages","stargazers_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/stargazers","contributors_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/contributors","subscribers_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/subscribers","subscription_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/subscription","commits_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/issues/comments{/number}","contents_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/contents/{+path}","compare_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/merges","archive_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/downloads","issues_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/issues{/number}","pulls_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/pulls{/number}","milestones_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/milestones{/number}","notifications_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/labels{/name}","releases_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/releases{/id}","deployments_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/deployments","created_at":"2015-11-05T09:43:10Z","updated_at":"2016-01-20T16:50:50Z","pushed_at":"2016-05-03T12:54:07Z","git_url":"git://github.com/mmnelemane/crowbar-openstack.git","ssh_url":"git@github.com:mmnelemane/crowbar-openstack.git","clone_url":"https://github.com/mmnelemane/crowbar-openstack.git","svn_url":"https://github.com/mmnelemane/crowbar-openstack","homepage":null,"size":16622,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"crowbar:master","ref":"master","sha":"a1733ab231a5c34817a72f4d5af8fd2a6f018210","user":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars.githubusercontent.com/u/2910205?v=3","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"repo":{"id":39006903,"name":"crowbar-openstack","full_name":"crowbar/crowbar-openstack","owner":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars.githubusercontent.com/u/2910205?v=3","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crowbar/crowbar-openstack","description":"Openstack deployment for Crowbar","fork":false,"url":"https://api.github.com/repos/crowbar/crowbar-openstack","forks_url":"https://api.github.com/repos/crowbar/crowbar-openstack/forks","keys_url":"https://api.github.com/repos/crowbar/crowbar-openstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crowbar/crowbar-openstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crowbar/crowbar-openstack/teams","hooks_url":"https://api.github.com/repos/crowbar/crowbar-openstack/hooks","issue_events_url":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/events{/number}","events_url":"https://api.github.com/repos/crowbar/crowbar-openstack/events","assignees_url":"https://api.github.com/repos/crowbar/crowbar-openstack/assignees{/user}","branches_url":"https://api.github.com/repos/crowbar/crowbar-openstack/branches{/branch}","tags_url":"https://api.github.com/repos/crowbar/crowbar-openstack/tags","blobs_url":"https://api.github.com/repos/crowbar/crowbar-openstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crowbar/crowbar-openstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crowbar/crowbar-openstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/crowbar/crowbar-openstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crowbar/crowbar-openstack/statuses/{sha}","languages_url":"https://api.github.com/repos/crowbar/crowbar-openstack/languages","stargazers_url":"https://api.github.com/repos/crowbar/crowbar-openstack/stargazers","contributors_url":"https://api.github.com/repos/crowbar/crowbar-openstack/contributors","subscribers_url":"https://api.github.com/repos/crowbar/crowbar-openstack/subscribers","subscription_url":"https://api.github.com/repos/crowbar/crowbar-openstack/subscription","commits_url":"https://api.github.com/repos/crowbar/crowbar-openstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/crowbar/crowbar-openstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/crowbar/crowbar-openstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/comments{/number}","contents_url":"https://api.github.com/repos/crowbar/crowbar-openstack/contents/{+path}","compare_url":"https://api.github.com/repos/crowbar/crowbar-openstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crowbar/crowbar-openstack/merges","archive_url":"https://api.github.com/repos/crowbar/crowbar-openstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crowbar/crowbar-openstack/downloads","issues_url":"https://api.github.com/repos/crowbar/crowbar-openstack/issues{/number}","pulls_url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls{/number}","milestones_url":"https://api.github.com/repos/crowbar/crowbar-openstack/milestones{/number}","notifications_url":"https://api.github.com/repos/crowbar/crowbar-openstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crowbar/crowbar-openstack/labels{/name}","releases_url":"https://api.github.com/repos/crowbar/crowbar-openstack/releases{/id}","deployments_url":"https://api.github.com/repos/crowbar/crowbar-openstack/deployments","created_at":"2015-07-13T10:55:33Z","updated_at":"2016-01-11T12:29:07Z","pushed_at":"2016-05-03T13:45:24Z","git_url":"git://github.com/crowbar/crowbar-openstack.git","ssh_url":"git@github.com:crowbar/crowbar-openstack.git","clone_url":"https://github.com/crowbar/crowbar-openstack.git","svn_url":"https://github.com/crowbar/crowbar-openstack","homepage":null,"size":16907,"stargazers_count":2,"watchers_count":2,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":25,"mirror_url":null,"open_issues_count":24,"forks":25,"open_issues":24,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/366"},"html":{"href":"https://github.com/crowbar/crowbar-openstack/pull/366"},"issue":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/366"},"comments":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/366/comments"},"review_comments":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/366/comments"},"review_comment":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/366/commits"},"statuses":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/statuses/2597c0daa052e1cf7863e7173c7a42ad5e63b320"}}}}