{"action":"closed","issue":{"url":"https://api.github.com/repos/mantidproject/mantid/issues/16876","repository_url":"https://api.github.com/repos/mantidproject/mantid","labels_url":"https://api.github.com/repos/mantidproject/mantid/issues/16876/labels{/name}","comments_url":"https://api.github.com/repos/mantidproject/mantid/issues/16876/comments","events_url":"https://api.github.com/repos/mantidproject/mantid/issues/16876/events","html_url":"https://github.com/mantidproject/mantid/issues/16876","id":165529765,"number":16876,"title":"HistogramData Rollout: FrameWork/Algorithms/ScaleX","user":{"login":"LamarMoore","id":15360272,"avatar_url":"https://avatars.githubusercontent.com/u/15360272?v=3","gravatar_id":"","url":"https://api.github.com/users/LamarMoore","html_url":"https://github.com/LamarMoore","followers_url":"https://api.github.com/users/LamarMoore/followers","following_url":"https://api.github.com/users/LamarMoore/following{/other_user}","gists_url":"https://api.github.com/users/LamarMoore/gists{/gist_id}","starred_url":"https://api.github.com/users/LamarMoore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LamarMoore/subscriptions","organizations_url":"https://api.github.com/users/LamarMoore/orgs","repos_url":"https://api.github.com/users/LamarMoore/repos","events_url":"https://api.github.com/users/LamarMoore/events{/privacy}","received_events_url":"https://api.github.com/users/LamarMoore/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/mantidproject/mantid/labels/Component:%20Framework","name":"Component: Framework","color":"009800"},{"url":"https://api.github.com/repos/mantidproject/mantid/labels/Misc:%20Easy","name":"Misc: Easy","color":"d4c5f9"},{"url":"https://api.github.com/repos/mantidproject/mantid/labels/Misc:%20Maintenance","name":"Misc: Maintenance","color":"d4c5f9"}],"state":"closed","locked":false,"assignee":{"login":"FedeMPouzols","id":5257172,"avatar_url":"https://avatars.githubusercontent.com/u/5257172?v=3","gravatar_id":"","url":"https://api.github.com/users/FedeMPouzols","html_url":"https://github.com/FedeMPouzols","followers_url":"https://api.github.com/users/FedeMPouzols/followers","following_url":"https://api.github.com/users/FedeMPouzols/following{/other_user}","gists_url":"https://api.github.com/users/FedeMPouzols/gists{/gist_id}","starred_url":"https://api.github.com/users/FedeMPouzols/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FedeMPouzols/subscriptions","organizations_url":"https://api.github.com/users/FedeMPouzols/orgs","repos_url":"https://api.github.com/users/FedeMPouzols/repos","events_url":"https://api.github.com/users/FedeMPouzols/events{/privacy}","received_events_url":"https://api.github.com/users/FedeMPouzols/received_events","type":"User","site_admin":false},"assignees":[{"login":"FedeMPouzols","id":5257172,"avatar_url":"https://avatars.githubusercontent.com/u/5257172?v=3","gravatar_id":"","url":"https://api.github.com/users/FedeMPouzols","html_url":"https://github.com/FedeMPouzols","followers_url":"https://api.github.com/users/FedeMPouzols/followers","following_url":"https://api.github.com/users/FedeMPouzols/following{/other_user}","gists_url":"https://api.github.com/users/FedeMPouzols/gists{/gist_id}","starred_url":"https://api.github.com/users/FedeMPouzols/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FedeMPouzols/subscriptions","organizations_url":"https://api.github.com/users/FedeMPouzols/orgs","repos_url":"https://api.github.com/users/FedeMPouzols/repos","events_url":"https://api.github.com/users/FedeMPouzols/events{/privacy}","received_events_url":"https://api.github.com/users/FedeMPouzols/received_events","type":"User","site_admin":false},{"login":"DimitarTasev","id":9135965,"avatar_url":"https://avatars.githubusercontent.com/u/9135965?v=3","gravatar_id":"","url":"https://api.github.com/users/DimitarTasev","html_url":"https://github.com/DimitarTasev","followers_url":"https://api.github.com/users/DimitarTasev/followers","following_url":"https://api.github.com/users/DimitarTasev/following{/other_user}","gists_url":"https://api.github.com/users/DimitarTasev/gists{/gist_id}","starred_url":"https://api.github.com/users/DimitarTasev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DimitarTasev/subscriptions","organizations_url":"https://api.github.com/users/DimitarTasev/orgs","repos_url":"https://api.github.com/users/DimitarTasev/repos","events_url":"https://api.github.com/users/DimitarTasev/events{/privacy}","received_events_url":"https://api.github.com/users/DimitarTasev/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/mantidproject/mantid/milestones/58","html_url":"https://github.com/mantidproject/mantid/milestones/Release%203.8","labels_url":"https://api.github.com/repos/mantidproject/mantid/milestones/58/labels","id":1505614,"number":58,"title":"Release 3.8","description":"","creator":{"login":"granrothge","id":5910574,"avatar_url":"https://avatars.githubusercontent.com/u/5910574?v=3","gravatar_id":"","url":"https://api.github.com/users/granrothge","html_url":"https://github.com/granrothge","followers_url":"https://api.github.com/users/granrothge/followers","following_url":"https://api.github.com/users/granrothge/following{/other_user}","gists_url":"https://api.github.com/users/granrothge/gists{/gist_id}","starred_url":"https://api.github.com/users/granrothge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/granrothge/subscriptions","organizations_url":"https://api.github.com/users/granrothge/orgs","repos_url":"https://api.github.com/users/granrothge/repos","events_url":"https://api.github.com/users/granrothge/events{/privacy}","received_events_url":"https://api.github.com/users/granrothge/received_events","type":"User","site_admin":false},"open_issues":675,"closed_issues":407,"state":"open","created_at":"2016-01-13T20:00:53Z","updated_at":"2016-07-22T16:03:00Z","due_on":"2016-10-09T23:00:00Z","closed_at":null},"comments":0,"created_at":"2016-07-14T10:33:58Z","updated_at":"2016-07-22T16:03:00Z","closed_at":"2016-07-22T16:03:00Z","body":"This issue relates to the broader HistogramData rollout see [here](http://docs.mantidproject.org/nightly/concepts/HistogramData.html#rollout-status) and [here](https://github.com/mantidproject/mantid/issues/16872). We are currently refactoring code in order to make use of the new interface by replacing references to the old interface and making a few improvements where possible. In this issue you will be modifying ScaleX.cpp.\r\n\r\n### Examples\r\n\r\nExamples of changes include:\r\n - `MantidVec &X = inputWS->dataX(0);` becomes `auto &X = inputWS->mutableX(0);`\r\n - `outputWS->dataX(i) = inputWS->readX(i);` becomes `outputWS->setSharedX(i, inputWS->sharedX(i));`\r\n - \r\n```c \r\noutputWS->setX(i, inputWS->refX(i));\r\noutputWS->dataY(i) = inputWS->readY(i);\r\noutputWS->dataE(i) = intputWS->readE(i);\r\n```\r\nbecomes\r\n```\r\noutputWS->setHistogram(i, inputWS->histogram(i));\r\n```\r\n### Tasks\r\nThere are a few tasks which should be completed when working on these files:\r\n1.Add performance tests where they may be missing. Read [this](http://www.mantidproject.org/Writing_Performance_Tests) document carefully for information on how to create and run performance tests.\r\n2. Run the SystemTest/PerformanceTest for the algorithm before making any changes and make a note of the execution time. How to run unit tests can be found [here](http://www.mantidproject.org/Running_the_unit_tests).\r\n3. Modify ScaleX.cpp as well as its unit test (ScaleXTest.cpp/ScaleXTestPerformance.cpp) to conform to the new Histogram standard.\r\n3. After making changes run the SystemTest/Performance test and make sure the execution time has not increased significantly.\r\n\r\n"}}
{"actor":{"display_login":"FedeMPouzols"}}