{"action":"created","issue":{"url":"https://api.github.com/repos/GrahamCampbell/Laravel-Flysystem/issues/81","repository_url":"https://api.github.com/repos/GrahamCampbell/Laravel-Flysystem","labels_url":"https://api.github.com/repos/GrahamCampbell/Laravel-Flysystem/issues/81/labels{/name}","comments_url":"https://api.github.com/repos/GrahamCampbell/Laravel-Flysystem/issues/81/comments","events_url":"https://api.github.com/repos/GrahamCampbell/Laravel-Flysystem/issues/81/events","html_url":"https://github.com/GrahamCampbell/Laravel-Flysystem/pull/81","id":191338933,"number":81,"title":"Makes AWS credentials optional.","user":{"login":"emigm","id":6826578,"avatar_url":"https://avatars.githubusercontent.com/u/6826578?v=3","gravatar_id":"","url":"https://api.github.com/users/emigm","html_url":"https://github.com/emigm","followers_url":"https://api.github.com/users/emigm/followers","following_url":"https://api.github.com/users/emigm/following{/other_user}","gists_url":"https://api.github.com/users/emigm/gists{/gist_id}","starred_url":"https://api.github.com/users/emigm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emigm/subscriptions","organizations_url":"https://api.github.com/users/emigm/orgs","repos_url":"https://api.github.com/users/emigm/repos","events_url":"https://api.github.com/users/emigm/events{/privacy}","received_events_url":"https://api.github.com/users/emigm/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-11-23T17:41:55Z","updated_at":"2016-11-23T21:33:31Z","closed_at":"2016-11-23T20:00:33Z","pull_request":{"url":"https://api.github.com/repos/GrahamCampbell/Laravel-Flysystem/pulls/81","html_url":"https://github.com/GrahamCampbell/Laravel-Flysystem/pull/81","diff_url":"https://github.com/GrahamCampbell/Laravel-Flysystem/pull/81.diff","patch_url":"https://github.com/GrahamCampbell/Laravel-Flysystem/pull/81.patch"},"body":"### What does this Pull Request Do?\r\n\r\nIt makes the AWS credentials optional to follow the AWS [guidelines](http://docs.aws.amazon.com/aws-sdk-php/v2/guide/credentials.html#credential-profiles) for providing credentials for the SKD.\r\n\r\n### Associated issue\r\n\r\n[82](https://github.com/GrahamCampbell/Laravel-Flysystem/issues/82)"},"comment":{"url":"https://api.github.com/repos/GrahamCampbell/Laravel-Flysystem/issues/comments/262635235","html_url":"https://github.com/GrahamCampbell/Laravel-Flysystem/pull/81#issuecomment-262635235","issue_url":"https://api.github.com/repos/GrahamCampbell/Laravel-Flysystem/issues/81","id":262635235,"user":{"login":"emigm","id":6826578,"avatar_url":"https://avatars.githubusercontent.com/u/6826578?v=3","gravatar_id":"","url":"https://api.github.com/users/emigm","html_url":"https://github.com/emigm","followers_url":"https://api.github.com/users/emigm/followers","following_url":"https://api.github.com/users/emigm/following{/other_user}","gists_url":"https://api.github.com/users/emigm/gists{/gist_id}","starred_url":"https://api.github.com/users/emigm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emigm/subscriptions","organizations_url":"https://api.github.com/users/emigm/orgs","repos_url":"https://api.github.com/users/emigm/repos","events_url":"https://api.github.com/users/emigm/events{/privacy}","received_events_url":"https://api.github.com/users/emigm/received_events","type":"User","site_admin":false},"created_at":"2016-11-23T21:33:31Z","updated_at":"2016-11-23T21:33:31Z","body":"I totally disagree with you due to this fix only gives to the developer another way to configure the AWS credentials making the implementation compliant with the AWS guidelines.\r\nAlso, it allows the developer to forget about the credentials and let the operation team to worry about them.\r\nFinally, it also encourage good practices in terms of security due to the credentials are not committed in the repository."}}
{"actor":{"display_login":"emigm"}}