{"action":"created","comment":{"url":"https://api.github.com/repos/citusdata/citus/pulls/comments/71484314","id":71484314,"diff_hunk":"@@ -63,6 +63,13 @@ RelayEventExtendNames(Node *parseTree, uint64 shardId)\n \t\t{\n \t\t\tAlterSeqStmt *alterSeqStmt = (AlterSeqStmt *) parseTree;\n \t\t\tchar **sequenceName = &(alterSeqStmt->sequence->relname);\n+\t\t\tchar **sequenceSchemaName = &(alterSeqStmt->sequence->schemaname);","path":"src/backend/distributed/relay/relay_event_utility.c","position":13,"original_position":13,"commit_id":"4f4850d9982e515302bfe2d9f0b16200bb4ff110","original_commit_id":"4f4850d9982e515302bfe2d9f0b16200bb4ff110","user":{"login":"metdos","id":149191,"avatar_url":"https://avatars.githubusercontent.com/u/149191?v=3","gravatar_id":"","url":"https://api.github.com/users/metdos","html_url":"https://github.com/metdos","followers_url":"https://api.github.com/users/metdos/followers","following_url":"https://api.github.com/users/metdos/following{/other_user}","gists_url":"https://api.github.com/users/metdos/gists{/gist_id}","starred_url":"https://api.github.com/users/metdos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metdos/subscriptions","organizations_url":"https://api.github.com/users/metdos/orgs","repos_url":"https://api.github.com/users/metdos/repos","events_url":"https://api.github.com/users/metdos/events{/privacy}","received_events_url":"https://api.github.com/users/metdos/received_events","type":"User","site_admin":false},"body":"> We create sequenceSchemaName, but never use it?\r\n> \r\n> We talked about this, but do you know if we the code path hits here? It seems we don't support distributed sequences, still, we can ask the team for historical notes on this code path.\r\n\r\nOhh, I see we update parse tree in place! Deleting the comment.","created_at":"2016-07-20T08:27:39Z","updated_at":"2016-07-20T08:27:39Z","html_url":"https://github.com/citusdata/citus/pull/643#discussion_r71484314","pull_request_url":"https://api.github.com/repos/citusdata/citus/pulls/643","_links":{"self":{"href":"https://api.github.com/repos/citusdata/citus/pulls/comments/71484314"},"html":{"href":"https://github.com/citusdata/citus/pull/643#discussion_r71484314"},"pull_request":{"href":"https://api.github.com/repos/citusdata/citus/pulls/643"}}},"pull_request":{"url":"https://api.github.com/repos/citusdata/citus/pulls/643","id":77124950,"html_url":"https://github.com/citusdata/citus/pull/643","diff_url":"https://github.com/citusdata/citus/pull/643.diff","patch_url":"https://github.com/citusdata/citus/pull/643.patch","issue_url":"https://api.github.com/repos/citusdata/citus/issues/643","number":643,"state":"open","locked":false,"title":"Add schema name to worker apply shard ddl command","user":{"login":"byucesoy","id":2082070,"avatar_url":"https://avatars.githubusercontent.com/u/2082070?v=3","gravatar_id":"","url":"https://api.github.com/users/byucesoy","html_url":"https://github.com/byucesoy","followers_url":"https://api.github.com/users/byucesoy/followers","following_url":"https://api.github.com/users/byucesoy/following{/other_user}","gists_url":"https://api.github.com/users/byucesoy/gists{/gist_id}","starred_url":"https://api.github.com/users/byucesoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/byucesoy/subscriptions","organizations_url":"https://api.github.com/users/byucesoy/orgs","repos_url":"https://api.github.com/users/byucesoy/repos","events_url":"https://api.github.com/users/byucesoy/events{/privacy}","received_events_url":"https://api.github.com/users/byucesoy/received_events","type":"User","site_admin":false},"body":"Fixes #565\r\nFixes #626\r\n\r\nTo add schema support to citus, we need to schema-prefix all table names, object names etc.\r\nin the queries sent to worker nodes. However; query deparsing is not available for most of\r\nDDL commands, therefore it is not easy to generate worker query in the master node.\r\n\r\nAs a solution we are sending schema names along with shard id and query to run to worker\r\nnodes with worker_apply_shard_ddl_command.\r\n\r\nSince \\STAGE will be deprecated anyway, we use public schema while calling \r\nworker_apply_shard_ddl_command everything to make it work with new signature. Please note \r\nthat if user specifies schema name, this will not override it, because we prioritize schema names\r\ngiven in the query in worker_apply_shard_ddl_command.","created_at":"2016-07-12T14:00:15Z","updated_at":"2016-07-20T08:27:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"435b4075fcd4a7292d75379b38817a2afcc7046e","assignee":{"login":"metdos","id":149191,"avatar_url":"https://avatars.githubusercontent.com/u/149191?v=3","gravatar_id":"","url":"https://api.github.com/users/metdos","html_url":"https://github.com/metdos","followers_url":"https://api.github.com/users/metdos/followers","following_url":"https://api.github.com/users/metdos/following{/other_user}","gists_url":"https://api.github.com/users/metdos/gists{/gist_id}","starred_url":"https://api.github.com/users/metdos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metdos/subscriptions","organizations_url":"https://api.github.com/users/metdos/orgs","repos_url":"https://api.github.com/users/metdos/repos","events_url":"https://api.github.com/users/metdos/events{/privacy}","received_events_url":"https://api.github.com/users/metdos/received_events","type":"User","site_admin":false},"assignees":[{"login":"metdos","id":149191,"avatar_url":"https://avatars.githubusercontent.com/u/149191?v=3","gravatar_id":"","url":"https://api.github.com/users/metdos","html_url":"https://github.com/metdos","followers_url":"https://api.github.com/users/metdos/followers","following_url":"https://api.github.com/users/metdos/following{/other_user}","gists_url":"https://api.github.com/users/metdos/gists{/gist_id}","starred_url":"https://api.github.com/users/metdos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metdos/subscriptions","organizations_url":"https://api.github.com/users/metdos/orgs","repos_url":"https://api.github.com/users/metdos/repos","events_url":"https://api.github.com/users/metdos/events{/privacy}","received_events_url":"https://api.github.com/users/metdos/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/citusdata/citus/pulls/643/commits","review_comments_url":"https://api.github.com/repos/citusdata/citus/pulls/643/comments","review_comment_url":"https://api.github.com/repos/citusdata/citus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/citusdata/citus/issues/643/comments","statuses_url":"https://api.github.com/repos/citusdata/citus/statuses/4f4850d9982e515302bfe2d9f0b16200bb4ff110","head":{"label":"citusdata:add_schema_name_to_worker_apply_shard_ddl_command","ref":"add_schema_name_to_worker_apply_shard_ddl_command","sha":"4f4850d9982e515302bfe2d9f0b16200bb4ff110","user":{"login":"citusdata","id":2545424,"avatar_url":"https://avatars.githubusercontent.com/u/2545424?v=3","gravatar_id":"","url":"https://api.github.com/users/citusdata","html_url":"https://github.com/citusdata","followers_url":"https://api.github.com/users/citusdata/followers","following_url":"https://api.github.com/users/citusdata/following{/other_user}","gists_url":"https://api.github.com/users/citusdata/gists{/gist_id}","starred_url":"https://api.github.com/users/citusdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/citusdata/subscriptions","organizations_url":"https://api.github.com/users/citusdata/orgs","repos_url":"https://api.github.com/users/citusdata/repos","events_url":"https://api.github.com/users/citusdata/events{/privacy}","received_events_url":"https://api.github.com/users/citusdata/received_events","type":"Organization","site_admin":false},"repo":{"id":50874442,"name":"citus","full_name":"citusdata/citus","owner":{"login":"citusdata","id":2545424,"avatar_url":"https://avatars.githubusercontent.com/u/2545424?v=3","gravatar_id":"","url":"https://api.github.com/users/citusdata","html_url":"https://github.com/citusdata","followers_url":"https://api.github.com/users/citusdata/followers","following_url":"https://api.github.com/users/citusdata/following{/other_user}","gists_url":"https://api.github.com/users/citusdata/gists{/gist_id}","starred_url":"https://api.github.com/users/citusdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/citusdata/subscriptions","organizations_url":"https://api.github.com/users/citusdata/orgs","repos_url":"https://api.github.com/users/citusdata/repos","events_url":"https://api.github.com/users/citusdata/events{/privacy}","received_events_url":"https://api.github.com/users/citusdata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/citusdata/citus","description":"Scalable PostgreSQL for real-time workloads","fork":false,"url":"https://api.github.com/repos/citusdata/citus","forks_url":"https://api.github.com/repos/citusdata/citus/forks","keys_url":"https://api.github.com/repos/citusdata/citus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/citusdata/citus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/citusdata/citus/teams","hooks_url":"https://api.github.com/repos/citusdata/citus/hooks","issue_events_url":"https://api.github.com/repos/citusdata/citus/issues/events{/number}","events_url":"https://api.github.com/repos/citusdata/citus/events","assignees_url":"https://api.github.com/repos/citusdata/citus/assignees{/user}","branches_url":"https://api.github.com/repos/citusdata/citus/branches{/branch}","tags_url":"https://api.github.com/repos/citusdata/citus/tags","blobs_url":"https://api.github.com/repos/citusdata/citus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/citusdata/citus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/citusdata/citus/git/refs{/sha}","trees_url":"https://api.github.com/repos/citusdata/citus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/citusdata/citus/statuses/{sha}","languages_url":"https://api.github.com/repos/citusdata/citus/languages","stargazers_url":"https://api.github.com/repos/citusdata/citus/stargazers","contributors_url":"https://api.github.com/repos/citusdata/citus/contributors","subscribers_url":"https://api.github.com/repos/citusdata/citus/subscribers","subscription_url":"https://api.github.com/repos/citusdata/citus/subscription","commits_url":"https://api.github.com/repos/citusdata/citus/commits{/sha}","git_commits_url":"https://api.github.com/repos/citusdata/citus/git/commits{/sha}","comments_url":"https://api.github.com/repos/citusdata/citus/comments{/number}","issue_comment_url":"https://api.github.com/repos/citusdata/citus/issues/comments{/number}","contents_url":"https://api.github.com/repos/citusdata/citus/contents/{+path}","compare_url":"https://api.github.com/repos/citusdata/citus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/citusdata/citus/merges","archive_url":"https://api.github.com/repos/citusdata/citus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/citusdata/citus/downloads","issues_url":"https://api.github.com/repos/citusdata/citus/issues{/number}","pulls_url":"https://api.github.com/repos/citusdata/citus/pulls{/number}","milestones_url":"https://api.github.com/repos/citusdata/citus/milestones{/number}","notifications_url":"https://api.github.com/repos/citusdata/citus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/citusdata/citus/labels{/name}","releases_url":"https://api.github.com/repos/citusdata/citus/releases{/id}","deployments_url":"https://api.github.com/repos/citusdata/citus/deployments","created_at":"2016-02-01T21:58:39Z","updated_at":"2016-07-20T06:59:02Z","pushed_at":"2016-07-20T07:47:07Z","git_url":"git://github.com/citusdata/citus.git","ssh_url":"git@github.com:citusdata/citus.git","clone_url":"https://github.com/citusdata/citus.git","svn_url":"https://github.com/citusdata/citus","homepage":"https://www.citusdata.com","size":3063,"stargazers_count":1469,"watchers_count":1469,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":104,"mirror_url":null,"open_issues_count":359,"forks":104,"open_issues":359,"watchers":1469,"default_branch":"master"}},"base":{"label":"citusdata:master","ref":"master","sha":"b01d19db3dcab95ac6a9aaf6f24c0a88594f7b26","user":{"login":"citusdata","id":2545424,"avatar_url":"https://avatars.githubusercontent.com/u/2545424?v=3","gravatar_id":"","url":"https://api.github.com/users/citusdata","html_url":"https://github.com/citusdata","followers_url":"https://api.github.com/users/citusdata/followers","following_url":"https://api.github.com/users/citusdata/following{/other_user}","gists_url":"https://api.github.com/users/citusdata/gists{/gist_id}","starred_url":"https://api.github.com/users/citusdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/citusdata/subscriptions","organizations_url":"https://api.github.com/users/citusdata/orgs","repos_url":"https://api.github.com/users/citusdata/repos","events_url":"https://api.github.com/users/citusdata/events{/privacy}","received_events_url":"https://api.github.com/users/citusdata/received_events","type":"Organization","site_admin":false},"repo":{"id":50874442,"name":"citus","full_name":"citusdata/citus","owner":{"login":"citusdata","id":2545424,"avatar_url":"https://avatars.githubusercontent.com/u/2545424?v=3","gravatar_id":"","url":"https://api.github.com/users/citusdata","html_url":"https://github.com/citusdata","followers_url":"https://api.github.com/users/citusdata/followers","following_url":"https://api.github.com/users/citusdata/following{/other_user}","gists_url":"https://api.github.com/users/citusdata/gists{/gist_id}","starred_url":"https://api.github.com/users/citusdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/citusdata/subscriptions","organizations_url":"https://api.github.com/users/citusdata/orgs","repos_url":"https://api.github.com/users/citusdata/repos","events_url":"https://api.github.com/users/citusdata/events{/privacy}","received_events_url":"https://api.github.com/users/citusdata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/citusdata/citus","description":"Scalable PostgreSQL for real-time workloads","fork":false,"url":"https://api.github.com/repos/citusdata/citus","forks_url":"https://api.github.com/repos/citusdata/citus/forks","keys_url":"https://api.github.com/repos/citusdata/citus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/citusdata/citus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/citusdata/citus/teams","hooks_url":"https://api.github.com/repos/citusdata/citus/hooks","issue_events_url":"https://api.github.com/repos/citusdata/citus/issues/events{/number}","events_url":"https://api.github.com/repos/citusdata/citus/events","assignees_url":"https://api.github.com/repos/citusdata/citus/assignees{/user}","branches_url":"https://api.github.com/repos/citusdata/citus/branches{/branch}","tags_url":"https://api.github.com/repos/citusdata/citus/tags","blobs_url":"https://api.github.com/repos/citusdata/citus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/citusdata/citus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/citusdata/citus/git/refs{/sha}","trees_url":"https://api.github.com/repos/citusdata/citus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/citusdata/citus/statuses/{sha}","languages_url":"https://api.github.com/repos/citusdata/citus/languages","stargazers_url":"https://api.github.com/repos/citusdata/citus/stargazers","contributors_url":"https://api.github.com/repos/citusdata/citus/contributors","subscribers_url":"https://api.github.com/repos/citusdata/citus/subscribers","subscription_url":"https://api.github.com/repos/citusdata/citus/subscription","commits_url":"https://api.github.com/repos/citusdata/citus/commits{/sha}","git_commits_url":"https://api.github.com/repos/citusdata/citus/git/commits{/sha}","comments_url":"https://api.github.com/repos/citusdata/citus/comments{/number}","issue_comment_url":"https://api.github.com/repos/citusdata/citus/issues/comments{/number}","contents_url":"https://api.github.com/repos/citusdata/citus/contents/{+path}","compare_url":"https://api.github.com/repos/citusdata/citus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/citusdata/citus/merges","archive_url":"https://api.github.com/repos/citusdata/citus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/citusdata/citus/downloads","issues_url":"https://api.github.com/repos/citusdata/citus/issues{/number}","pulls_url":"https://api.github.com/repos/citusdata/citus/pulls{/number}","milestones_url":"https://api.github.com/repos/citusdata/citus/milestones{/number}","notifications_url":"https://api.github.com/repos/citusdata/citus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/citusdata/citus/labels{/name}","releases_url":"https://api.github.com/repos/citusdata/citus/releases{/id}","deployments_url":"https://api.github.com/repos/citusdata/citus/deployments","created_at":"2016-02-01T21:58:39Z","updated_at":"2016-07-20T06:59:02Z","pushed_at":"2016-07-20T07:47:07Z","git_url":"git://github.com/citusdata/citus.git","ssh_url":"git@github.com:citusdata/citus.git","clone_url":"https://github.com/citusdata/citus.git","svn_url":"https://github.com/citusdata/citus","homepage":"https://www.citusdata.com","size":3063,"stargazers_count":1469,"watchers_count":1469,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":104,"mirror_url":null,"open_issues_count":359,"forks":104,"open_issues":359,"watchers":1469,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/citusdata/citus/pulls/643"},"html":{"href":"https://github.com/citusdata/citus/pull/643"},"issue":{"href":"https://api.github.com/repos/citusdata/citus/issues/643"},"comments":{"href":"https://api.github.com/repos/citusdata/citus/issues/643/comments"},"review_comments":{"href":"https://api.github.com/repos/citusdata/citus/pulls/643/comments"},"review_comment":{"href":"https://api.github.com/repos/citusdata/citus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/citusdata/citus/pulls/643/commits"},"statuses":{"href":"https://api.github.com/repos/citusdata/citus/statuses/4f4850d9982e515302bfe2d9f0b16200bb4ff110"}}}}
{"actor":{"display_login":"metdos"}}