{"action":"closed","number":2799,"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/2799","id":72110779,"html_url":"https://github.com/apple/swift/pull/2799","diff_url":"https://github.com/apple/swift/pull/2799.diff","patch_url":"https://github.com/apple/swift/pull/2799.patch","issue_url":"https://api.github.com/repos/apple/swift/issues/2799","number":2799,"state":"closed","locked":false,"title":"Provide fix-its when implementing a protocol method with bridged types.","user":{"login":"jrose-apple","id":15097531,"avatar_url":"https://avatars.githubusercontent.com/u/15097531?v=3","gravatar_id":"","url":"https://api.github.com/users/jrose-apple","html_url":"https://github.com/jrose-apple","followers_url":"https://api.github.com/users/jrose-apple/followers","following_url":"https://api.github.com/users/jrose-apple/following{/other_user}","gists_url":"https://api.github.com/users/jrose-apple/gists{/gist_id}","starred_url":"https://api.github.com/users/jrose-apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrose-apple/subscriptions","organizations_url":"https://api.github.com/users/jrose-apple/orgs","repos_url":"https://api.github.com/users/jrose-apple/repos","events_url":"https://api.github.com/users/jrose-apple/events{/privacy}","received_events_url":"https://api.github.com/users/jrose-apple/received_events","type":"User","site_admin":false},"body":"This is the protocol version of 7bfdd4a2: if a protocol requirement has a newly-bridged type (say, 'URL' instead of `NSURL`), then any conforming types will need to update their implementations of the requirement. Reuse the override-checking mechanism to do so when we're reasonably confident about it.\r\n\r\nThis slots the checking into the existing protocol diagnostics, which\r\ndoesn't result in the best user experience.\r\n\r\n    note: protocol requires property 'prop' with type 'Refrigerator?'\r\n      var prop: Refrigerator? { get }\r\n          ^\r\n    note: candidate has non-matching type 'APPRefrigerator?'\r\n      var prop: APPRefrigerator? {\r\n          ^     ~~~~~~~~~~~~~~~~\r\n                Refrigerator?\r\n\r\nBut we can come back and improve that later; right now this is better\r\nthan nothing.\r\n\r\nrdar://problem/26237030\r\n* * * *\r\n\r\n<!-- This selection should only be completed by Swift admin -->\r\nBefore merging this pull request to apple/swift repository:\r\n- [ ] Test pull request on Swift continuous integration.\r\n\r\n<details>\r\n  <summary>Triggering Swift CI</summary>\r\n\r\nThe swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:\r\n\r\n**Smoke Testing**\r\n\r\n        Platform     | Comment\r\n        ------------ | -------------\r\n        All supported platforms     | @swift-ci Please smoke test\r\n        All supported platforms     | @swift-ci Please smoke test and merge\r\n        OS X platform               | @swift-ci Please smoke test OS X platform\r\n        Linux platform              | @swift-ci Please smoke test Linux platform\r\n\r\n**Validation Testing**\r\n\r\n        Platform     | Comment\r\n        ------------ | -------------\r\n        All supported platforms     | @swift-ci Please test\r\n        All supported platforms     | @swift-ci Please test and merge\r\n        OS X platform               | @swift-ci Please test OS X platform\r\n        OS X platform               | @swift-ci Please benchmark\r\n        Linux platform              | @swift-ci Please test Linux platform\r\n\r\n\r\n**Lint Testing**\r\n\r\n        Language     | Comment\r\n        ------------ | -------------\r\n        Python       | @swift-ci Please Python lint\r\n\r\nNote: Only members of the Apple organization can trigger swift-ci.\r\n</details>\r\n<!-- Thank you for your contribution to Swift! -->","created_at":"2016-06-01T01:33:27Z","updated_at":"2016-06-01T21:03:21Z","closed_at":"2016-06-01T21:03:21Z","merged_at":"2016-06-01T21:03:21Z","merge_commit_sha":"258e2bb45cd248f7d0bb1a9bfaaba443dab05e5f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift/pulls/2799/commits","review_comments_url":"https://api.github.com/repos/apple/swift/pulls/2799/comments","review_comment_url":"https://api.github.com/repos/apple/swift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift/issues/2799/comments","statuses_url":"https://api.github.com/repos/apple/swift/statuses/18b0fce2337b0717bdd42d7a43737d6006402884","head":{"label":"jrose-apple:fix-it-value-type-witnesses","ref":"fix-it-value-type-witnesses","sha":"18b0fce2337b0717bdd42d7a43737d6006402884","user":{"login":"jrose-apple","id":15097531,"avatar_url":"https://avatars.githubusercontent.com/u/15097531?v=3","gravatar_id":"","url":"https://api.github.com/users/jrose-apple","html_url":"https://github.com/jrose-apple","followers_url":"https://api.github.com/users/jrose-apple/followers","following_url":"https://api.github.com/users/jrose-apple/following{/other_user}","gists_url":"https://api.github.com/users/jrose-apple/gists{/gist_id}","starred_url":"https://api.github.com/users/jrose-apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrose-apple/subscriptions","organizations_url":"https://api.github.com/users/jrose-apple/orgs","repos_url":"https://api.github.com/users/jrose-apple/repos","events_url":"https://api.github.com/users/jrose-apple/events{/privacy}","received_events_url":"https://api.github.com/users/jrose-apple/received_events","type":"User","site_admin":false},"repo":{"id":47434397,"name":"swift","full_name":"jrose-apple/swift","owner":{"login":"jrose-apple","id":15097531,"avatar_url":"https://avatars.githubusercontent.com/u/15097531?v=3","gravatar_id":"","url":"https://api.github.com/users/jrose-apple","html_url":"https://github.com/jrose-apple","followers_url":"https://api.github.com/users/jrose-apple/followers","following_url":"https://api.github.com/users/jrose-apple/following{/other_user}","gists_url":"https://api.github.com/users/jrose-apple/gists{/gist_id}","starred_url":"https://api.github.com/users/jrose-apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrose-apple/subscriptions","organizations_url":"https://api.github.com/users/jrose-apple/orgs","repos_url":"https://api.github.com/users/jrose-apple/repos","events_url":"https://api.github.com/users/jrose-apple/events{/privacy}","received_events_url":"https://api.github.com/users/jrose-apple/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jrose-apple/swift","description":"The Swift Programming Language","fork":true,"url":"https://api.github.com/repos/jrose-apple/swift","forks_url":"https://api.github.com/repos/jrose-apple/swift/forks","keys_url":"https://api.github.com/repos/jrose-apple/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jrose-apple/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jrose-apple/swift/teams","hooks_url":"https://api.github.com/repos/jrose-apple/swift/hooks","issue_events_url":"https://api.github.com/repos/jrose-apple/swift/issues/events{/number}","events_url":"https://api.github.com/repos/jrose-apple/swift/events","assignees_url":"https://api.github.com/repos/jrose-apple/swift/assignees{/user}","branches_url":"https://api.github.com/repos/jrose-apple/swift/branches{/branch}","tags_url":"https://api.github.com/repos/jrose-apple/swift/tags","blobs_url":"https://api.github.com/repos/jrose-apple/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jrose-apple/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jrose-apple/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/jrose-apple/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jrose-apple/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/jrose-apple/swift/languages","stargazers_url":"https://api.github.com/repos/jrose-apple/swift/stargazers","contributors_url":"https://api.github.com/repos/jrose-apple/swift/contributors","subscribers_url":"https://api.github.com/repos/jrose-apple/swift/subscribers","subscription_url":"https://api.github.com/repos/jrose-apple/swift/subscription","commits_url":"https://api.github.com/repos/jrose-apple/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/jrose-apple/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/jrose-apple/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/jrose-apple/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/jrose-apple/swift/contents/{+path}","compare_url":"https://api.github.com/repos/jrose-apple/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jrose-apple/swift/merges","archive_url":"https://api.github.com/repos/jrose-apple/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jrose-apple/swift/downloads","issues_url":"https://api.github.com/repos/jrose-apple/swift/issues{/number}","pulls_url":"https://api.github.com/repos/jrose-apple/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/jrose-apple/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/jrose-apple/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jrose-apple/swift/labels{/name}","releases_url":"https://api.github.com/repos/jrose-apple/swift/releases{/id}","deployments_url":"https://api.github.com/repos/jrose-apple/swift/deployments","created_at":"2015-12-04T23:42:49Z","updated_at":"2016-01-23T08:12:32Z","pushed_at":"2016-06-01T01:32:35Z","git_url":"git://github.com/jrose-apple/swift.git","ssh_url":"git@github.com:jrose-apple/swift.git","clone_url":"https://github.com/jrose-apple/swift.git","svn_url":"https://github.com/jrose-apple/swift","homepage":"","size":100349,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"empty"}},"base":{"label":"apple:master","ref":"master","sha":"000d413a628a6acbd96243f913c7b2013788782e","user":{"login":"apple","id":10639145,"avatar_url":"https://avatars.githubusercontent.com/u/10639145?v=3","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":44838949,"name":"swift","full_name":"apple/swift","owner":{"login":"apple","id":10639145,"avatar_url":"https://avatars.githubusercontent.com/u/10639145?v=3","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apple/swift","description":"The Swift Programming Language","fork":false,"url":"https://api.github.com/repos/apple/swift","forks_url":"https://api.github.com/repos/apple/swift/forks","keys_url":"https://api.github.com/repos/apple/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift/teams","hooks_url":"https://api.github.com/repos/apple/swift/hooks","issue_events_url":"https://api.github.com/repos/apple/swift/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift/events","assignees_url":"https://api.github.com/repos/apple/swift/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift/tags","blobs_url":"https://api.github.com/repos/apple/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift/languages","stargazers_url":"https://api.github.com/repos/apple/swift/stargazers","contributors_url":"https://api.github.com/repos/apple/swift/contributors","subscribers_url":"https://api.github.com/repos/apple/swift/subscribers","subscription_url":"https://api.github.com/repos/apple/swift/subscription","commits_url":"https://api.github.com/repos/apple/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift/merges","archive_url":"https://api.github.com/repos/apple/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift/downloads","issues_url":"https://api.github.com/repos/apple/swift/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift/deployments","created_at":"2015-10-23T21:15:07Z","updated_at":"2016-06-01T19:57:33Z","pushed_at":"2016-06-01T21:03:21Z","git_url":"git://github.com/apple/swift.git","ssh_url":"git@github.com:apple/swift.git","clone_url":"https://github.com/apple/swift.git","svn_url":"https://github.com/apple/swift","homepage":"https://swift.org/","size":156291,"stargazers_count":30816,"watchers_count":30816,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4205,"mirror_url":null,"open_issues_count":102,"forks":4205,"open_issues":102,"watchers":30816,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/2799"},"html":{"href":"https://github.com/apple/swift/pull/2799"},"issue":{"href":"https://api.github.com/repos/apple/swift/issues/2799"},"comments":{"href":"https://api.github.com/repos/apple/swift/issues/2799/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift/pulls/2799/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift/pulls/2799/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift/statuses/18b0fce2337b0717bdd42d7a43737d6006402884"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"jrose-apple","id":15097531,"avatar_url":"https://avatars.githubusercontent.com/u/15097531?v=3","gravatar_id":"","url":"https://api.github.com/users/jrose-apple","html_url":"https://github.com/jrose-apple","followers_url":"https://api.github.com/users/jrose-apple/followers","following_url":"https://api.github.com/users/jrose-apple/following{/other_user}","gists_url":"https://api.github.com/users/jrose-apple/gists{/gist_id}","starred_url":"https://api.github.com/users/jrose-apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrose-apple/subscriptions","organizations_url":"https://api.github.com/users/jrose-apple/orgs","repos_url":"https://api.github.com/users/jrose-apple/repos","events_url":"https://api.github.com/users/jrose-apple/events{/privacy}","received_events_url":"https://api.github.com/users/jrose-apple/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":1,"additions":249,"deletions":114,"changed_files":5}}
{"actor":{"display_login":"jrose-apple"}}