{"action":"created","comment":{"url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/comments/55158467","id":55158467,"diff_hunk":"@@ -261,6 +262,31 @@ def test_nanscatter():\n     ax.grid(True)\n \n \n+@image_comparison(baseline_images=['not_covering_scatter'], extensions=['png'])\n+def test_not_covering_scatter():\n+    colors = ['b','g','r']\n+\n+    for n in range(3):\n+        plt.scatter([n,], [n,], color=colors[n])\n+\n+    plt.legend(['foo', 'foo', 'foo'], loc='best')\n+    plt.gca().set_xlim(-0.5, 2.2)\n+    plt.gca().set_ylim(-0.5, 2.2)\n+\n+\n+@image_comparison(baseline_images=['not_covering_scatter_transform'], extensions=['png'])","path":"lib/matplotlib/tests/test_legend.py","position":null,"original_position":24,"commit_id":"da49463b506d3b5a52b1d05ccb7388429b8712e1","original_commit_id":"58679a1452a0073c388ba1b901b1a8d42419286f","user":{"login":"QuLogic","id":302469,"avatar_url":"https://avatars.githubusercontent.com/u/302469?v=3","gravatar_id":"","url":"https://api.github.com/users/QuLogic","html_url":"https://github.com/QuLogic","followers_url":"https://api.github.com/users/QuLogic/followers","following_url":"https://api.github.com/users/QuLogic/following{/other_user}","gists_url":"https://api.github.com/users/QuLogic/gists{/gist_id}","starred_url":"https://api.github.com/users/QuLogic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/QuLogic/subscriptions","organizations_url":"https://api.github.com/users/QuLogic/orgs","repos_url":"https://api.github.com/users/QuLogic/repos","events_url":"https://api.github.com/users/QuLogic/events{/privacy}","received_events_url":"https://api.github.com/users/QuLogic/received_events","type":"User","site_admin":false},"body":"It's actually fixed in another PR that I might just give a little nudge to some time...","created_at":"2016-03-07T03:11:02Z","updated_at":"2016-03-07T03:11:02Z","html_url":"https://github.com/matplotlib/matplotlib/pull/6110#discussion_r55158467","pull_request_url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/6110","_links":{"self":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/comments/55158467"},"html":{"href":"https://github.com/matplotlib/matplotlib/pull/6110#discussion_r55158467"},"pull_request":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/6110"}}},"pull_request":{"url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/6110","id":61817755,"html_url":"https://github.com/matplotlib/matplotlib/pull/6110","diff_url":"https://github.com/matplotlib/matplotlib/pull/6110.diff","patch_url":"https://github.com/matplotlib/matplotlib/pull/6110.patch","issue_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/6110","number":6110,"state":"open","locked":false,"title":"Fixes matplotlib/matplotlib#1235","user":{"login":"nansonzheng","id":14435972,"avatar_url":"https://avatars.githubusercontent.com/u/14435972?v=3","gravatar_id":"","url":"https://api.github.com/users/nansonzheng","html_url":"https://github.com/nansonzheng","followers_url":"https://api.github.com/users/nansonzheng/followers","following_url":"https://api.github.com/users/nansonzheng/following{/other_user}","gists_url":"https://api.github.com/users/nansonzheng/gists{/gist_id}","starred_url":"https://api.github.com/users/nansonzheng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nansonzheng/subscriptions","organizations_url":"https://api.github.com/users/nansonzheng/orgs","repos_url":"https://api.github.com/users/nansonzheng/repos","events_url":"https://api.github.com/users/nansonzheng/events{/privacy}","received_events_url":"https://api.github.com/users/nansonzheng/received_events","type":"User","site_admin":false},"body":"Credit to @dashed, fixes #1235, supercedes #2857 \r\n\r\nThe problem is that _find_best_position does not receive positions of (transformed) points from _auto_legend_data. We attempted to fix it by adding the offsets of points, after preparing the points and transforming them, and calling legendBox.count_contains on offsets.","created_at":"2016-03-05T17:15:07Z","updated_at":"2016-03-07T03:11:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5cf099c3dcef41dfb1cc7e168f819c2ff698fd6c","assignee":null,"milestone":{"url":"https://api.github.com/repos/matplotlib/matplotlib/milestones/14","html_url":"https://github.com/matplotlib/matplotlib/milestones/2.0%20(style%20change%20major%20release)","labels_url":"https://api.github.com/repos/matplotlib/matplotlib/milestones/14/labels","id":662004,"number":14,"title":"2.0 (style change major release)","description":"Style changes only","creator":{"login":"tacaswell","id":199813,"avatar_url":"https://avatars.githubusercontent.com/u/199813?v=3","gravatar_id":"","url":"https://api.github.com/users/tacaswell","html_url":"https://github.com/tacaswell","followers_url":"https://api.github.com/users/tacaswell/followers","following_url":"https://api.github.com/users/tacaswell/following{/other_user}","gists_url":"https://api.github.com/users/tacaswell/gists{/gist_id}","starred_url":"https://api.github.com/users/tacaswell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tacaswell/subscriptions","organizations_url":"https://api.github.com/users/tacaswell/orgs","repos_url":"https://api.github.com/users/tacaswell/repos","events_url":"https://api.github.com/users/tacaswell/events{/privacy}","received_events_url":"https://api.github.com/users/tacaswell/received_events","type":"User","site_admin":false},"open_issues":78,"closed_issues":197,"state":"open","created_at":"2014-05-17T14:28:22Z","updated_at":"2016-03-07T01:52:51Z","due_on":"2016-02-01T05:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/6110/commits","review_comments_url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/6110/comments","review_comment_url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/6110/comments","statuses_url":"https://api.github.com/repos/matplotlib/matplotlib/statuses/da49463b506d3b5a52b1d05ccb7388429b8712e1","head":{"label":"nansonzheng:1235-fix-proposal","ref":"1235-fix-proposal","sha":"da49463b506d3b5a52b1d05ccb7388429b8712e1","user":{"login":"nansonzheng","id":14435972,"avatar_url":"https://avatars.githubusercontent.com/u/14435972?v=3","gravatar_id":"","url":"https://api.github.com/users/nansonzheng","html_url":"https://github.com/nansonzheng","followers_url":"https://api.github.com/users/nansonzheng/followers","following_url":"https://api.github.com/users/nansonzheng/following{/other_user}","gists_url":"https://api.github.com/users/nansonzheng/gists{/gist_id}","starred_url":"https://api.github.com/users/nansonzheng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nansonzheng/subscriptions","organizations_url":"https://api.github.com/users/nansonzheng/orgs","repos_url":"https://api.github.com/users/nansonzheng/repos","events_url":"https://api.github.com/users/nansonzheng/events{/privacy}","received_events_url":"https://api.github.com/users/nansonzheng/received_events","type":"User","site_admin":false},"repo":{"id":53207666,"name":"matplotlib","full_name":"nansonzheng/matplotlib","owner":{"login":"nansonzheng","id":14435972,"avatar_url":"https://avatars.githubusercontent.com/u/14435972?v=3","gravatar_id":"","url":"https://api.github.com/users/nansonzheng","html_url":"https://github.com/nansonzheng","followers_url":"https://api.github.com/users/nansonzheng/followers","following_url":"https://api.github.com/users/nansonzheng/following{/other_user}","gists_url":"https://api.github.com/users/nansonzheng/gists{/gist_id}","starred_url":"https://api.github.com/users/nansonzheng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nansonzheng/subscriptions","organizations_url":"https://api.github.com/users/nansonzheng/orgs","repos_url":"https://api.github.com/users/nansonzheng/repos","events_url":"https://api.github.com/users/nansonzheng/events{/privacy}","received_events_url":"https://api.github.com/users/nansonzheng/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nansonzheng/matplotlib","description":"matplotlib: plotting with Python","fork":true,"url":"https://api.github.com/repos/nansonzheng/matplotlib","forks_url":"https://api.github.com/repos/nansonzheng/matplotlib/forks","keys_url":"https://api.github.com/repos/nansonzheng/matplotlib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nansonzheng/matplotlib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nansonzheng/matplotlib/teams","hooks_url":"https://api.github.com/repos/nansonzheng/matplotlib/hooks","issue_events_url":"https://api.github.com/repos/nansonzheng/matplotlib/issues/events{/number}","events_url":"https://api.github.com/repos/nansonzheng/matplotlib/events","assignees_url":"https://api.github.com/repos/nansonzheng/matplotlib/assignees{/user}","branches_url":"https://api.github.com/repos/nansonzheng/matplotlib/branches{/branch}","tags_url":"https://api.github.com/repos/nansonzheng/matplotlib/tags","blobs_url":"https://api.github.com/repos/nansonzheng/matplotlib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nansonzheng/matplotlib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nansonzheng/matplotlib/git/refs{/sha}","trees_url":"https://api.github.com/repos/nansonzheng/matplotlib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nansonzheng/matplotlib/statuses/{sha}","languages_url":"https://api.github.com/repos/nansonzheng/matplotlib/languages","stargazers_url":"https://api.github.com/repos/nansonzheng/matplotlib/stargazers","contributors_url":"https://api.github.com/repos/nansonzheng/matplotlib/contributors","subscribers_url":"https://api.github.com/repos/nansonzheng/matplotlib/subscribers","subscription_url":"https://api.github.com/repos/nansonzheng/matplotlib/subscription","commits_url":"https://api.github.com/repos/nansonzheng/matplotlib/commits{/sha}","git_commits_url":"https://api.github.com/repos/nansonzheng/matplotlib/git/commits{/sha}","comments_url":"https://api.github.com/repos/nansonzheng/matplotlib/comments{/number}","issue_comment_url":"https://api.github.com/repos/nansonzheng/matplotlib/issues/comments{/number}","contents_url":"https://api.github.com/repos/nansonzheng/matplotlib/contents/{+path}","compare_url":"https://api.github.com/repos/nansonzheng/matplotlib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nansonzheng/matplotlib/merges","archive_url":"https://api.github.com/repos/nansonzheng/matplotlib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nansonzheng/matplotlib/downloads","issues_url":"https://api.github.com/repos/nansonzheng/matplotlib/issues{/number}","pulls_url":"https://api.github.com/repos/nansonzheng/matplotlib/pulls{/number}","milestones_url":"https://api.github.com/repos/nansonzheng/matplotlib/milestones{/number}","notifications_url":"https://api.github.com/repos/nansonzheng/matplotlib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nansonzheng/matplotlib/labels{/name}","releases_url":"https://api.github.com/repos/nansonzheng/matplotlib/releases{/id}","deployments_url":"https://api.github.com/repos/nansonzheng/matplotlib/deployments","created_at":"2016-03-05T15:19:05Z","updated_at":"2016-03-05T15:19:15Z","pushed_at":"2016-03-07T02:55:26Z","git_url":"git://github.com/nansonzheng/matplotlib.git","ssh_url":"git@github.com:nansonzheng/matplotlib.git","clone_url":"https://github.com/nansonzheng/matplotlib.git","svn_url":"https://github.com/nansonzheng/matplotlib","homepage":"http://matplotlib.org/","size":276334,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"matplotlib:master","ref":"master","sha":"963e51d4df44fa58bf89840b19f2d0f12a0e605a","user":{"login":"matplotlib","id":215947,"avatar_url":"https://avatars.githubusercontent.com/u/215947?v=3","gravatar_id":"","url":"https://api.github.com/users/matplotlib","html_url":"https://github.com/matplotlib","followers_url":"https://api.github.com/users/matplotlib/followers","following_url":"https://api.github.com/users/matplotlib/following{/other_user}","gists_url":"https://api.github.com/users/matplotlib/gists{/gist_id}","starred_url":"https://api.github.com/users/matplotlib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matplotlib/subscriptions","organizations_url":"https://api.github.com/users/matplotlib/orgs","repos_url":"https://api.github.com/users/matplotlib/repos","events_url":"https://api.github.com/users/matplotlib/events{/privacy}","received_events_url":"https://api.github.com/users/matplotlib/received_events","type":"Organization","site_admin":false},"repo":{"id":1385122,"name":"matplotlib","full_name":"matplotlib/matplotlib","owner":{"login":"matplotlib","id":215947,"avatar_url":"https://avatars.githubusercontent.com/u/215947?v=3","gravatar_id":"","url":"https://api.github.com/users/matplotlib","html_url":"https://github.com/matplotlib","followers_url":"https://api.github.com/users/matplotlib/followers","following_url":"https://api.github.com/users/matplotlib/following{/other_user}","gists_url":"https://api.github.com/users/matplotlib/gists{/gist_id}","starred_url":"https://api.github.com/users/matplotlib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matplotlib/subscriptions","organizations_url":"https://api.github.com/users/matplotlib/orgs","repos_url":"https://api.github.com/users/matplotlib/repos","events_url":"https://api.github.com/users/matplotlib/events{/privacy}","received_events_url":"https://api.github.com/users/matplotlib/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/matplotlib/matplotlib","description":"matplotlib: plotting with Python","fork":false,"url":"https://api.github.com/repos/matplotlib/matplotlib","forks_url":"https://api.github.com/repos/matplotlib/matplotlib/forks","keys_url":"https://api.github.com/repos/matplotlib/matplotlib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matplotlib/matplotlib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matplotlib/matplotlib/teams","hooks_url":"https://api.github.com/repos/matplotlib/matplotlib/hooks","issue_events_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/events{/number}","events_url":"https://api.github.com/repos/matplotlib/matplotlib/events","assignees_url":"https://api.github.com/repos/matplotlib/matplotlib/assignees{/user}","branches_url":"https://api.github.com/repos/matplotlib/matplotlib/branches{/branch}","tags_url":"https://api.github.com/repos/matplotlib/matplotlib/tags","blobs_url":"https://api.github.com/repos/matplotlib/matplotlib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matplotlib/matplotlib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matplotlib/matplotlib/git/refs{/sha}","trees_url":"https://api.github.com/repos/matplotlib/matplotlib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matplotlib/matplotlib/statuses/{sha}","languages_url":"https://api.github.com/repos/matplotlib/matplotlib/languages","stargazers_url":"https://api.github.com/repos/matplotlib/matplotlib/stargazers","contributors_url":"https://api.github.com/repos/matplotlib/matplotlib/contributors","subscribers_url":"https://api.github.com/repos/matplotlib/matplotlib/subscribers","subscription_url":"https://api.github.com/repos/matplotlib/matplotlib/subscription","commits_url":"https://api.github.com/repos/matplotlib/matplotlib/commits{/sha}","git_commits_url":"https://api.github.com/repos/matplotlib/matplotlib/git/commits{/sha}","comments_url":"https://api.github.com/repos/matplotlib/matplotlib/comments{/number}","issue_comment_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/comments{/number}","contents_url":"https://api.github.com/repos/matplotlib/matplotlib/contents/{+path}","compare_url":"https://api.github.com/repos/matplotlib/matplotlib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matplotlib/matplotlib/merges","archive_url":"https://api.github.com/repos/matplotlib/matplotlib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matplotlib/matplotlib/downloads","issues_url":"https://api.github.com/repos/matplotlib/matplotlib/issues{/number}","pulls_url":"https://api.github.com/repos/matplotlib/matplotlib/pulls{/number}","milestones_url":"https://api.github.com/repos/matplotlib/matplotlib/milestones{/number}","notifications_url":"https://api.github.com/repos/matplotlib/matplotlib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matplotlib/matplotlib/labels{/name}","releases_url":"https://api.github.com/repos/matplotlib/matplotlib/releases{/id}","deployments_url":"https://api.github.com/repos/matplotlib/matplotlib/deployments","created_at":"2011-02-19T03:17:12Z","updated_at":"2016-03-06T09:46:02Z","pushed_at":"2016-03-07T03:03:26Z","git_url":"git://github.com/matplotlib/matplotlib.git","ssh_url":"git@github.com:matplotlib/matplotlib.git","clone_url":"https://github.com/matplotlib/matplotlib.git","svn_url":"https://github.com/matplotlib/matplotlib","homepage":"http://matplotlib.org/","size":388481,"stargazers_count":3363,"watchers_count":3363,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1714,"mirror_url":null,"open_issues_count":860,"forks":1714,"open_issues":860,"watchers":3363,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/6110"},"html":{"href":"https://github.com/matplotlib/matplotlib/pull/6110"},"issue":{"href":"https://api.github.com/repos/matplotlib/matplotlib/issues/6110"},"comments":{"href":"https://api.github.com/repos/matplotlib/matplotlib/issues/6110/comments"},"review_comments":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/6110/comments"},"review_comment":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/6110/commits"},"statuses":{"href":"https://api.github.com/repos/matplotlib/matplotlib/statuses/da49463b506d3b5a52b1d05ccb7388429b8712e1"}}}}