{"action":"opened","number":32,"pull_request":{"url":"https://api.github.com/repos/sebastiaanvisser/fclabels/pulls/32","id":59007770,"html_url":"https://github.com/sebastiaanvisser/fclabels/pull/32","diff_url":"https://github.com/sebastiaanvisser/fclabels/pull/32.diff","patch_url":"https://github.com/sebastiaanvisser/fclabels/pull/32.patch","issue_url":"https://api.github.com/repos/sebastiaanvisser/fclabels/issues/32","number":32,"state":"open","locked":false,"title":"Ghc 8 support (again)","user":{"login":"hesselink","id":75477,"avatar_url":"https://avatars.githubusercontent.com/u/75477?v=3","gravatar_id":"","url":"https://api.github.com/users/hesselink","html_url":"https://github.com/hesselink","followers_url":"https://api.github.com/users/hesselink/followers","following_url":"https://api.github.com/users/hesselink/following{/other_user}","gists_url":"https://api.github.com/users/hesselink/gists{/gist_id}","starred_url":"https://api.github.com/users/hesselink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hesselink/subscriptions","organizations_url":"https://api.github.com/users/hesselink/orgs","repos_url":"https://api.github.com/users/hesselink/repos","events_url":"https://api.github.com/users/hesselink/events{/privacy}","received_events_url":"https://api.github.com/users/hesselink/received_events","type":"User","site_admin":false},"body":"I started working on this due to #30, but ended up writing the changes from scratch to understand things better. It turns out that due to the way the representation of GADTs has changed (from a data type with an equality constraint in the context, to a special constructor with the result type) there are some changes in the code generation required. Additionally, the transformers 0.5 release removed the `MonadPlus (Either String)` instance needed for `Failing.Lens String`. I've moved the instance into the test suite for now, but perhaps we consider moving to `Except` there at some point.\r\n\r\nThe last thing that remains to be done, is that the `total` boolean doesn't seem to be computed correctly for GADTs at this point for GHC 8, resulting in warnings in the generated code that weren't there before. I haven't looked at that yet, I'll rebase this when I've fixed that.","created_at":"2016-02-11T09:46:06Z","updated_at":"2016-02-11T09:46:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sebastiaanvisser/fclabels/pulls/32/commits","review_comments_url":"https://api.github.com/repos/sebastiaanvisser/fclabels/pulls/32/comments","review_comment_url":"https://api.github.com/repos/sebastiaanvisser/fclabels/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sebastiaanvisser/fclabels/issues/32/comments","statuses_url":"https://api.github.com/repos/sebastiaanvisser/fclabels/statuses/a4538fa44ab7284513dd5b9e4416e0ed7783d224","head":{"label":"sebastiaanvisser:ghc-8","ref":"ghc-8","sha":"a4538fa44ab7284513dd5b9e4416e0ed7783d224","user":{"login":"sebastiaanvisser","id":54288,"avatar_url":"https://avatars.githubusercontent.com/u/54288?v=3","gravatar_id":"","url":"https://api.github.com/users/sebastiaanvisser","html_url":"https://github.com/sebastiaanvisser","followers_url":"https://api.github.com/users/sebastiaanvisser/followers","following_url":"https://api.github.com/users/sebastiaanvisser/following{/other_user}","gists_url":"https://api.github.com/users/sebastiaanvisser/gists{/gist_id}","starred_url":"https://api.github.com/users/sebastiaanvisser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebastiaanvisser/subscriptions","organizations_url":"https://api.github.com/users/sebastiaanvisser/orgs","repos_url":"https://api.github.com/users/sebastiaanvisser/repos","events_url":"https://api.github.com/users/sebastiaanvisser/events{/privacy}","received_events_url":"https://api.github.com/users/sebastiaanvisser/received_events","type":"User","site_admin":false},"repo":{"id":271630,"name":"fclabels","full_name":"sebastiaanvisser/fclabels","owner":{"login":"sebastiaanvisser","id":54288,"avatar_url":"https://avatars.githubusercontent.com/u/54288?v=3","gravatar_id":"","url":"https://api.github.com/users/sebastiaanvisser","html_url":"https://github.com/sebastiaanvisser","followers_url":"https://api.github.com/users/sebastiaanvisser/followers","following_url":"https://api.github.com/users/sebastiaanvisser/following{/other_user}","gists_url":"https://api.github.com/users/sebastiaanvisser/gists{/gist_id}","starred_url":"https://api.github.com/users/sebastiaanvisser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebastiaanvisser/subscriptions","organizations_url":"https://api.github.com/users/sebastiaanvisser/orgs","repos_url":"https://api.github.com/users/sebastiaanvisser/repos","events_url":"https://api.github.com/users/sebastiaanvisser/events{/privacy}","received_events_url":"https://api.github.com/users/sebastiaanvisser/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sebastiaanvisser/fclabels","description":"First class composable record labels for Haskell.","fork":false,"url":"https://api.github.com/repos/sebastiaanvisser/fclabels","forks_url":"https://api.github.com/repos/sebastiaanvisser/fclabels/forks","keys_url":"https://api.github.com/repos/sebastiaanvisser/fclabels/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sebastiaanvisser/fclabels/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sebastiaanvisser/fclabels/teams","hooks_url":"https://api.github.com/repos/sebastiaanvisser/fclabels/hooks","issue_events_url":"https://api.github.com/repos/sebastiaanvisser/fclabels/issues/events{/number}","events_url":"https://api.github.com/repos/sebastiaanvisser/fclabels/events","assignees_url":"https://api.github.com/repos/sebastiaanvisser/fclabels/assignees{/user}","branches_url":"https://api.github.com/repos/sebastiaanvisser/fclabels/branches{/branch}","tags_url":"https://api.github.com/repos/sebastiaanvisser/fclabels/tags","blobs_url":"https://api.github.com/repos/sebastiaanvisser/fclabels/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sebastiaanvisser/fclabels/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sebastiaanvisser/fclabels/git/refs{/sha}","trees_url":"https://api.github.com/repos/sebastiaanvisser/fclabels/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sebastiaanvisser/fclabels/statuses/{sha}","languages_url":"https://api.github.com/repos/sebastiaanvisser/fclabels/languages","stargazers_url":"https://api.github.com/repos/sebastiaanvisser/fclabels/stargazers","contributors_url":"https://api.github.com/repos/sebastiaanvisser/fclabels/contributors","subscribers_url":"https://api.github.com/repos/sebastiaanvisser/fclabels/subscribers","subscription_url":"https://api.github.com/repos/sebastiaanvisser/fclabels/subscription","commits_url":"https://api.github.com/repos/sebastiaanvisser/fclabels/commits{/sha}","git_commits_url":"https://api.github.com/repos/sebastiaanvisser/fclabels/git/commits{/sha}","comments_url":"https://api.github.com/repos/sebastiaanvisser/fclabels/comments{/number}","issue_comment_url":"https://api.github.com/repos/sebastiaanvisser/fclabels/issues/comments{/number}","contents_url":"https://api.github.com/repos/sebastiaanvisser/fclabels/contents/{+path}","compare_url":"https://api.github.com/repos/sebastiaanvisser/fclabels/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sebastiaanvisser/fclabels/merges","archive_url":"https://api.github.com/repos/sebastiaanvisser/fclabels/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sebastiaanvisser/fclabels/downloads","issues_url":"https://api.github.com/repos/sebastiaanvisser/fclabels/issues{/number}","pulls_url":"https://api.github.com/repos/sebastiaanvisser/fclabels/pulls{/number}","milestones_url":"https://api.github.com/repos/sebastiaanvisser/fclabels/milestones{/number}","notifications_url":"https://api.github.com/repos/sebastiaanvisser/fclabels/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sebastiaanvisser/fclabels/labels{/name}","releases_url":"https://api.github.com/repos/sebastiaanvisser/fclabels/releases{/id}","deployments_url":"https://api.github.com/repos/sebastiaanvisser/fclabels/deployments","created_at":"2009-08-07T12:49:06Z","updated_at":"2016-01-25T12:46:57Z","pushed_at":"2016-02-11T09:41:33Z","git_url":"git://github.com/sebastiaanvisser/fclabels.git","ssh_url":"git@github.com:sebastiaanvisser/fclabels.git","clone_url":"https://github.com/sebastiaanvisser/fclabels.git","svn_url":"https://github.com/sebastiaanvisser/fclabels","homepage":"","size":344,"stargazers_count":56,"watchers_count":56,"language":"Haskell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":6,"forks":18,"open_issues":6,"watchers":56,"default_branch":"master"}},"base":{"label":"sebastiaanvisser:master","ref":"master","sha":"c11d768fad15148f05c28e6dc26e390f637ff7e4","user":{"login":"sebastiaanvisser","id":54288,"avatar_url":"https://avatars.githubusercontent.com/u/54288?v=3","gravatar_id":"","url":"https://api.github.com/users/sebastiaanvisser","html_url":"https://github.com/sebastiaanvisser","followers_url":"https://api.github.com/users/sebastiaanvisser/followers","following_url":"https://api.github.com/users/sebastiaanvisser/following{/other_user}","gists_url":"https://api.github.com/users/sebastiaanvisser/gists{/gist_id}","starred_url":"https://api.github.com/users/sebastiaanvisser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebastiaanvisser/subscriptions","organizations_url":"https://api.github.com/users/sebastiaanvisser/orgs","repos_url":"https://api.github.com/users/sebastiaanvisser/repos","events_url":"https://api.github.com/users/sebastiaanvisser/events{/privacy}","received_events_url":"https://api.github.com/users/sebastiaanvisser/received_events","type":"User","site_admin":false},"repo":{"id":271630,"name":"fclabels","full_name":"sebastiaanvisser/fclabels","owner":{"login":"sebastiaanvisser","id":54288,"avatar_url":"https://avatars.githubusercontent.com/u/54288?v=3","gravatar_id":"","url":"https://api.github.com/users/sebastiaanvisser","html_url":"https://github.com/sebastiaanvisser","followers_url":"https://api.github.com/users/sebastiaanvisser/followers","following_url":"https://api.github.com/users/sebastiaanvisser/following{/other_user}","gists_url":"https://api.github.com/users/sebastiaanvisser/gists{/gist_id}","starred_url":"https://api.github.com/users/sebastiaanvisser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebastiaanvisser/subscriptions","organizations_url":"https://api.github.com/users/sebastiaanvisser/orgs","repos_url":"https://api.github.com/users/sebastiaanvisser/repos","events_url":"https://api.github.com/users/sebastiaanvisser/events{/privacy}","received_events_url":"https://api.github.com/users/sebastiaanvisser/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sebastiaanvisser/fclabels","description":"First class composable record labels for Haskell.","fork":false,"url":"https://api.github.com/repos/sebastiaanvisser/fclabels","forks_url":"https://api.github.com/repos/sebastiaanvisser/fclabels/forks","keys_url":"https://api.github.com/repos/sebastiaanvisser/fclabels/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sebastiaanvisser/fclabels/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sebastiaanvisser/fclabels/teams","hooks_url":"https://api.github.com/repos/sebastiaanvisser/fclabels/hooks","issue_events_url":"https://api.github.com/repos/sebastiaanvisser/fclabels/issues/events{/number}","events_url":"https://api.github.com/repos/sebastiaanvisser/fclabels/events","assignees_url":"https://api.github.com/repos/sebastiaanvisser/fclabels/assignees{/user}","branches_url":"https://api.github.com/repos/sebastiaanvisser/fclabels/branches{/branch}","tags_url":"https://api.github.com/repos/sebastiaanvisser/fclabels/tags","blobs_url":"https://api.github.com/repos/sebastiaanvisser/fclabels/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sebastiaanvisser/fclabels/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sebastiaanvisser/fclabels/git/refs{/sha}","trees_url":"https://api.github.com/repos/sebastiaanvisser/fclabels/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sebastiaanvisser/fclabels/statuses/{sha}","languages_url":"https://api.github.com/repos/sebastiaanvisser/fclabels/languages","stargazers_url":"https://api.github.com/repos/sebastiaanvisser/fclabels/stargazers","contributors_url":"https://api.github.com/repos/sebastiaanvisser/fclabels/contributors","subscribers_url":"https://api.github.com/repos/sebastiaanvisser/fclabels/subscribers","subscription_url":"https://api.github.com/repos/sebastiaanvisser/fclabels/subscription","commits_url":"https://api.github.com/repos/sebastiaanvisser/fclabels/commits{/sha}","git_commits_url":"https://api.github.com/repos/sebastiaanvisser/fclabels/git/commits{/sha}","comments_url":"https://api.github.com/repos/sebastiaanvisser/fclabels/comments{/number}","issue_comment_url":"https://api.github.com/repos/sebastiaanvisser/fclabels/issues/comments{/number}","contents_url":"https://api.github.com/repos/sebastiaanvisser/fclabels/contents/{+path}","compare_url":"https://api.github.com/repos/sebastiaanvisser/fclabels/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sebastiaanvisser/fclabels/merges","archive_url":"https://api.github.com/repos/sebastiaanvisser/fclabels/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sebastiaanvisser/fclabels/downloads","issues_url":"https://api.github.com/repos/sebastiaanvisser/fclabels/issues{/number}","pulls_url":"https://api.github.com/repos/sebastiaanvisser/fclabels/pulls{/number}","milestones_url":"https://api.github.com/repos/sebastiaanvisser/fclabels/milestones{/number}","notifications_url":"https://api.github.com/repos/sebastiaanvisser/fclabels/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sebastiaanvisser/fclabels/labels{/name}","releases_url":"https://api.github.com/repos/sebastiaanvisser/fclabels/releases{/id}","deployments_url":"https://api.github.com/repos/sebastiaanvisser/fclabels/deployments","created_at":"2009-08-07T12:49:06Z","updated_at":"2016-01-25T12:46:57Z","pushed_at":"2016-02-11T09:41:33Z","git_url":"git://github.com/sebastiaanvisser/fclabels.git","ssh_url":"git@github.com:sebastiaanvisser/fclabels.git","clone_url":"https://github.com/sebastiaanvisser/fclabels.git","svn_url":"https://github.com/sebastiaanvisser/fclabels","homepage":"","size":344,"stargazers_count":56,"watchers_count":56,"language":"Haskell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":6,"forks":18,"open_issues":6,"watchers":56,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sebastiaanvisser/fclabels/pulls/32"},"html":{"href":"https://github.com/sebastiaanvisser/fclabels/pull/32"},"issue":{"href":"https://api.github.com/repos/sebastiaanvisser/fclabels/issues/32"},"comments":{"href":"https://api.github.com/repos/sebastiaanvisser/fclabels/issues/32/comments"},"review_comments":{"href":"https://api.github.com/repos/sebastiaanvisser/fclabels/pulls/32/comments"},"review_comment":{"href":"https://api.github.com/repos/sebastiaanvisser/fclabels/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sebastiaanvisser/fclabels/pulls/32/commits"},"statuses":{"href":"https://api.github.com/repos/sebastiaanvisser/fclabels/statuses/a4538fa44ab7284513dd5b9e4416e0ed7783d224"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":118,"deletions":32,"changed_files":3}}