{"comment":{"url":"https://api.github.com/repos/hachikuji/kafka/comments/15456977","html_url":"https://github.com/hachikuji/kafka/commit/5246ceb9260743ca3b1c5418bb398e56c0727c1d#commitcomment-15456977","id":15456977,"user":{"login":"hachikuji","id":12502538,"avatar_url":"https://avatars.githubusercontent.com/u/12502538?v=3","gravatar_id":"","url":"https://api.github.com/users/hachikuji","html_url":"https://github.com/hachikuji","followers_url":"https://api.github.com/users/hachikuji/followers","following_url":"https://api.github.com/users/hachikuji/following{/other_user}","gists_url":"https://api.github.com/users/hachikuji/gists{/gist_id}","starred_url":"https://api.github.com/users/hachikuji/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hachikuji/subscriptions","organizations_url":"https://api.github.com/users/hachikuji/orgs","repos_url":"https://api.github.com/users/hachikuji/repos","events_url":"https://api.github.com/users/hachikuji/events{/privacy}","received_events_url":"https://api.github.com/users/hachikuji/received_events","type":"User","site_admin":false},"position":7,"line":38,"path":"clients/src/main/java/org/apache/kafka/common/Cluster.java","commit_id":"5246ceb9260743ca3b1c5418bb398e56c0727c1d","created_at":"2016-01-14T18:14:01Z","updated_at":"2016-01-14T18:14:01Z","body":"Yes, I changed it because I needed a way to get the Node from a String nodeId in NetworkClient and there didn't seem to be any need in the code for using the integer version. But it's not really clear what the \"right\" thing to do is. The broker ids are usually represented by integers, but the whole networking layer depends on strings. Perhaps we should change Selector/NetworkClient to only use Node instances?"}}