{"action":"created","issue":{"url":"https://api.github.com/repos/gmag11/NtpClient/issues/17","repository_url":"https://api.github.com/repos/gmag11/NtpClient","labels_url":"https://api.github.com/repos/gmag11/NtpClient/issues/17/labels{/name}","comments_url":"https://api.github.com/repos/gmag11/NtpClient/issues/17/comments","events_url":"https://api.github.com/repos/gmag11/NtpClient/issues/17/events","html_url":"https://github.com/gmag11/NtpClient/issues/17","id":190632664,"number":17,"title":"onNTPSyncEvent() is called before system time is updated.","user":{"login":"1n5aN1aC","id":735325,"avatar_url":"https://avatars.githubusercontent.com/u/735325?v=3","gravatar_id":"","url":"https://api.github.com/users/1n5aN1aC","html_url":"https://github.com/1n5aN1aC","followers_url":"https://api.github.com/users/1n5aN1aC/followers","following_url":"https://api.github.com/users/1n5aN1aC/following{/other_user}","gists_url":"https://api.github.com/users/1n5aN1aC/gists{/gist_id}","starred_url":"https://api.github.com/users/1n5aN1aC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/1n5aN1aC/subscriptions","organizations_url":"https://api.github.com/users/1n5aN1aC/orgs","repos_url":"https://api.github.com/users/1n5aN1aC/repos","events_url":"https://api.github.com/users/1n5aN1aC/events{/privacy}","received_events_url":"https://api.github.com/users/1n5aN1aC/received_events","type":"User","site_admin":false},"labels":[{"id":302310945,"url":"https://api.github.com/repos/gmag11/NtpClient/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"state":"closed","locked":false,"assignee":{"login":"gmag11","id":6190183,"avatar_url":"https://avatars.githubusercontent.com/u/6190183?v=3","gravatar_id":"","url":"https://api.github.com/users/gmag11","html_url":"https://github.com/gmag11","followers_url":"https://api.github.com/users/gmag11/followers","following_url":"https://api.github.com/users/gmag11/following{/other_user}","gists_url":"https://api.github.com/users/gmag11/gists{/gist_id}","starred_url":"https://api.github.com/users/gmag11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmag11/subscriptions","organizations_url":"https://api.github.com/users/gmag11/orgs","repos_url":"https://api.github.com/users/gmag11/repos","events_url":"https://api.github.com/users/gmag11/events{/privacy}","received_events_url":"https://api.github.com/users/gmag11/received_events","type":"User","site_admin":false},"assignees":[{"login":"gmag11","id":6190183,"avatar_url":"https://avatars.githubusercontent.com/u/6190183?v=3","gravatar_id":"","url":"https://api.github.com/users/gmag11","html_url":"https://github.com/gmag11","followers_url":"https://api.github.com/users/gmag11/followers","following_url":"https://api.github.com/users/gmag11/following{/other_user}","gists_url":"https://api.github.com/users/gmag11/gists{/gist_id}","starred_url":"https://api.github.com/users/gmag11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmag11/subscriptions","organizations_url":"https://api.github.com/users/gmag11/orgs","repos_url":"https://api.github.com/users/gmag11/repos","events_url":"https://api.github.com/users/gmag11/events{/privacy}","received_events_url":"https://api.github.com/users/gmag11/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2016-11-21T06:46:30Z","updated_at":"2016-12-16T18:44:53Z","closed_at":"2016-12-16T18:44:53Z","body":"As title.  when a NTP sync occurs, onNTPSyncEvent() is called before it finishes updating the 'system' time.  This can cause extreme confusion to people who expect to be able to use now() and get the updated value within it.\r\n\r\nI confirmed this while playing with an RTC, and setting the RTC on NTPsync wasn't working.  Then on a whim, I changed the interval to 30 seconds, and lo and behold, on second sync it worked!\r\n\r\nNote that I later found you can use getLastNTPSync() inside the event, so you can close & ignore this if you would like, it's just misleading for new users."},"comment":{"url":"https://api.github.com/repos/gmag11/NtpClient/issues/comments/267666413","html_url":"https://github.com/gmag11/NtpClient/issues/17#issuecomment-267666413","issue_url":"https://api.github.com/repos/gmag11/NtpClient/issues/17","id":267666413,"user":{"login":"gmag11","id":6190183,"avatar_url":"https://avatars.githubusercontent.com/u/6190183?v=3","gravatar_id":"","url":"https://api.github.com/users/gmag11","html_url":"https://github.com/gmag11","followers_url":"https://api.github.com/users/gmag11/followers","following_url":"https://api.github.com/users/gmag11/following{/other_user}","gists_url":"https://api.github.com/users/gmag11/gists{/gist_id}","starred_url":"https://api.github.com/users/gmag11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmag11/subscriptions","organizations_url":"https://api.github.com/users/gmag11/orgs","repos_url":"https://api.github.com/users/gmag11/repos","events_url":"https://api.github.com/users/gmag11/events{/privacy}","received_events_url":"https://api.github.com/users/gmag11/received_events","type":"User","site_admin":false},"created_at":"2016-12-16T18:44:53Z","updated_at":"2016-12-16T18:44:53Z","body":"The problem is that forking Time Library may be confusing too. I think having my own version of TimeLib gives not much benefit to overall behaviour.\r\nThanks for your interest."}}
{"actor":{"display_login":"gmag11"}}