{"action":"created","comment":{"url":"https://api.github.com/repos/Chorus/chorus/pulls/comments/60527999","id":60527999,"diff_hunk":"@@ -1,4 +1,10 @@\n describe(\"chorus.pages.WorkspaceDatasetShowPage\", function() {\n+    var workspace;\n+    var dataset;\n+    var columnSet;\n+    var datasetId;\n+    var page;","path":"components/frontend/spec/javascripts/pages/dataset/workspace_dataset_show_page_spec.js","position":6,"original_position":6,"commit_id":"1369f9f3dee82440a9a0a761826950866268f39d","original_commit_id":"1369f9f3dee82440a9a0a761826950866268f39d","user":{"login":"mmilano","id":60168,"avatar_url":"https://avatars.githubusercontent.com/u/60168?v=3","gravatar_id":"","url":"https://api.github.com/users/mmilano","html_url":"https://github.com/mmilano","followers_url":"https://api.github.com/users/mmilano/followers","following_url":"https://api.github.com/users/mmilano/following{/other_user}","gists_url":"https://api.github.com/users/mmilano/gists{/gist_id}","starred_url":"https://api.github.com/users/mmilano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmilano/subscriptions","organizations_url":"https://api.github.com/users/mmilano/orgs","repos_url":"https://api.github.com/users/mmilano/repos","events_url":"https://api.github.com/users/mmilano/events{/privacy}","received_events_url":"https://api.github.com/users/mmilano/received_events","type":"User","site_admin":false},"body":"@imccarter re: the var definitions. this is something i have been adding to the spec.js files here and there, opportunistically, as i happen to edit those files.\r\nin general, it does no harm, and is correct js practice anyway. \r\n i am using it as a sort of experiment to see if it has a beneficial long term effect - the spec suite often will crash and run out of memory because of GC issues in the java heap (i.e. the jruby environment). i was hoping that maybe small effects like this could have some positive impact. probably not, but it doesnt hurt.","created_at":"2016-04-21T05:30:22Z","updated_at":"2016-04-21T05:30:22Z","html_url":"https://github.com/Chorus/chorus/pull/282#discussion_r60527999","pull_request_url":"https://api.github.com/repos/Chorus/chorus/pulls/282","_links":{"self":{"href":"https://api.github.com/repos/Chorus/chorus/pulls/comments/60527999"},"html":{"href":"https://github.com/Chorus/chorus/pull/282#discussion_r60527999"},"pull_request":{"href":"https://api.github.com/repos/Chorus/chorus/pulls/282"}}},"pull_request":{"url":"https://api.github.com/repos/Chorus/chorus/pulls/282","id":64582794,"html_url":"https://github.com/Chorus/chorus/pull/282","diff_url":"https://github.com/Chorus/chorus/pull/282.diff","patch_url":"https://github.com/Chorus/chorus/pull/282.patch","issue_url":"https://api.github.com/repos/Chorus/chorus/issues/282","number":282,"state":"open","locked":false,"title":"Workspace header icon","user":{"login":"mmilano","id":60168,"avatar_url":"https://avatars.githubusercontent.com/u/60168?v=3","gravatar_id":"","url":"https://api.github.com/users/mmilano","html_url":"https://github.com/mmilano","followers_url":"https://api.github.com/users/mmilano/followers","following_url":"https://api.github.com/users/mmilano/following{/other_user}","gists_url":"https://api.github.com/users/mmilano/gists{/gist_id}","starred_url":"https://api.github.com/users/mmilano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmilano/subscriptions","organizations_url":"https://api.github.com/users/mmilano/orgs","repos_url":"https://api.github.com/users/mmilano/repos","events_url":"https://api.github.com/users/mmilano/events{/privacy}","received_events_url":"https://api.github.com/users/mmilano/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-03-30T07:31:13Z","updated_at":"2016-04-21T05:30:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5fb4c981bcf8407141fd766aab63b40119893806","assignee":{"login":"imccarter","id":9735592,"avatar_url":"https://avatars.githubusercontent.com/u/9735592?v=3","gravatar_id":"","url":"https://api.github.com/users/imccarter","html_url":"https://github.com/imccarter","followers_url":"https://api.github.com/users/imccarter/followers","following_url":"https://api.github.com/users/imccarter/following{/other_user}","gists_url":"https://api.github.com/users/imccarter/gists{/gist_id}","starred_url":"https://api.github.com/users/imccarter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imccarter/subscriptions","organizations_url":"https://api.github.com/users/imccarter/orgs","repos_url":"https://api.github.com/users/imccarter/repos","events_url":"https://api.github.com/users/imccarter/events{/privacy}","received_events_url":"https://api.github.com/users/imccarter/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/Chorus/chorus/milestones/3","html_url":"https://github.com/Chorus/chorus/milestones/R1%20code%20review","labels_url":"https://api.github.com/repos/Chorus/chorus/milestones/3/labels","id":1721555,"number":3,"title":"R1 code review","description":"","creator":{"login":"mmilano","id":60168,"avatar_url":"https://avatars.githubusercontent.com/u/60168?v=3","gravatar_id":"","url":"https://api.github.com/users/mmilano","html_url":"https://github.com/mmilano","followers_url":"https://api.github.com/users/mmilano/followers","following_url":"https://api.github.com/users/mmilano/following{/other_user}","gists_url":"https://api.github.com/users/mmilano/gists{/gist_id}","starred_url":"https://api.github.com/users/mmilano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmilano/subscriptions","organizations_url":"https://api.github.com/users/mmilano/orgs","repos_url":"https://api.github.com/users/mmilano/repos","events_url":"https://api.github.com/users/mmilano/events{/privacy}","received_events_url":"https://api.github.com/users/mmilano/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":0,"state":"open","created_at":"2016-04-20T21:41:46Z","updated_at":"2016-04-20T21:44:31Z","due_on":"2016-04-21T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/Chorus/chorus/pulls/282/commits","review_comments_url":"https://api.github.com/repos/Chorus/chorus/pulls/282/comments","review_comment_url":"https://api.github.com/repos/Chorus/chorus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Chorus/chorus/issues/282/comments","statuses_url":"https://api.github.com/repos/Chorus/chorus/statuses/1369f9f3dee82440a9a0a761826950866268f39d","head":{"label":"Chorus:workspace-header-icon","ref":"workspace-header-icon","sha":"1369f9f3dee82440a9a0a761826950866268f39d","user":{"login":"Chorus","id":5614676,"avatar_url":"https://avatars.githubusercontent.com/u/5614676?v=3","gravatar_id":"","url":"https://api.github.com/users/Chorus","html_url":"https://github.com/Chorus","followers_url":"https://api.github.com/users/Chorus/followers","following_url":"https://api.github.com/users/Chorus/following{/other_user}","gists_url":"https://api.github.com/users/Chorus/gists{/gist_id}","starred_url":"https://api.github.com/users/Chorus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Chorus/subscriptions","organizations_url":"https://api.github.com/users/Chorus/orgs","repos_url":"https://api.github.com/users/Chorus/repos","events_url":"https://api.github.com/users/Chorus/events{/privacy}","received_events_url":"https://api.github.com/users/Chorus/received_events","type":"Organization","site_admin":false},"repo":{"id":2751440,"name":"chorus","full_name":"Chorus/chorus","owner":{"login":"Chorus","id":5614676,"avatar_url":"https://avatars.githubusercontent.com/u/5614676?v=3","gravatar_id":"","url":"https://api.github.com/users/Chorus","html_url":"https://github.com/Chorus","followers_url":"https://api.github.com/users/Chorus/followers","following_url":"https://api.github.com/users/Chorus/following{/other_user}","gists_url":"https://api.github.com/users/Chorus/gists{/gist_id}","starred_url":"https://api.github.com/users/Chorus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Chorus/subscriptions","organizations_url":"https://api.github.com/users/Chorus/orgs","repos_url":"https://api.github.com/users/Chorus/repos","events_url":"https://api.github.com/users/Chorus/events{/privacy}","received_events_url":"https://api.github.com/users/Chorus/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Chorus/chorus","description":"Chorus allows customers, partners, developers, and data scientists to collaboratively realize the potential of Big Data.","fork":false,"url":"https://api.github.com/repos/Chorus/chorus","forks_url":"https://api.github.com/repos/Chorus/chorus/forks","keys_url":"https://api.github.com/repos/Chorus/chorus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Chorus/chorus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Chorus/chorus/teams","hooks_url":"https://api.github.com/repos/Chorus/chorus/hooks","issue_events_url":"https://api.github.com/repos/Chorus/chorus/issues/events{/number}","events_url":"https://api.github.com/repos/Chorus/chorus/events","assignees_url":"https://api.github.com/repos/Chorus/chorus/assignees{/user}","branches_url":"https://api.github.com/repos/Chorus/chorus/branches{/branch}","tags_url":"https://api.github.com/repos/Chorus/chorus/tags","blobs_url":"https://api.github.com/repos/Chorus/chorus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Chorus/chorus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Chorus/chorus/git/refs{/sha}","trees_url":"https://api.github.com/repos/Chorus/chorus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Chorus/chorus/statuses/{sha}","languages_url":"https://api.github.com/repos/Chorus/chorus/languages","stargazers_url":"https://api.github.com/repos/Chorus/chorus/stargazers","contributors_url":"https://api.github.com/repos/Chorus/chorus/contributors","subscribers_url":"https://api.github.com/repos/Chorus/chorus/subscribers","subscription_url":"https://api.github.com/repos/Chorus/chorus/subscription","commits_url":"https://api.github.com/repos/Chorus/chorus/commits{/sha}","git_commits_url":"https://api.github.com/repos/Chorus/chorus/git/commits{/sha}","comments_url":"https://api.github.com/repos/Chorus/chorus/comments{/number}","issue_comment_url":"https://api.github.com/repos/Chorus/chorus/issues/comments{/number}","contents_url":"https://api.github.com/repos/Chorus/chorus/contents/{+path}","compare_url":"https://api.github.com/repos/Chorus/chorus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Chorus/chorus/merges","archive_url":"https://api.github.com/repos/Chorus/chorus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Chorus/chorus/downloads","issues_url":"https://api.github.com/repos/Chorus/chorus/issues{/number}","pulls_url":"https://api.github.com/repos/Chorus/chorus/pulls{/number}","milestones_url":"https://api.github.com/repos/Chorus/chorus/milestones{/number}","notifications_url":"https://api.github.com/repos/Chorus/chorus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Chorus/chorus/labels{/name}","releases_url":"https://api.github.com/repos/Chorus/chorus/releases{/id}","deployments_url":"https://api.github.com/repos/Chorus/chorus/deployments","created_at":"2011-11-10T20:30:13Z","updated_at":"2016-04-05T14:28:50Z","pushed_at":"2016-04-21T03:59:53Z","git_url":"git://github.com/Chorus/chorus.git","ssh_url":"git@github.com:Chorus/chorus.git","clone_url":"https://github.com/Chorus/chorus.git","svn_url":"https://github.com/Chorus/chorus","homepage":"","size":907947,"stargazers_count":182,"watchers_count":182,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":73,"mirror_url":null,"open_issues_count":14,"forks":73,"open_issues":14,"watchers":182,"default_branch":"master"}},"base":{"label":"Chorus:master","ref":"master","sha":"678e3bd90c8d4916004ee7eb93bc9c629d69223d","user":{"login":"Chorus","id":5614676,"avatar_url":"https://avatars.githubusercontent.com/u/5614676?v=3","gravatar_id":"","url":"https://api.github.com/users/Chorus","html_url":"https://github.com/Chorus","followers_url":"https://api.github.com/users/Chorus/followers","following_url":"https://api.github.com/users/Chorus/following{/other_user}","gists_url":"https://api.github.com/users/Chorus/gists{/gist_id}","starred_url":"https://api.github.com/users/Chorus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Chorus/subscriptions","organizations_url":"https://api.github.com/users/Chorus/orgs","repos_url":"https://api.github.com/users/Chorus/repos","events_url":"https://api.github.com/users/Chorus/events{/privacy}","received_events_url":"https://api.github.com/users/Chorus/received_events","type":"Organization","site_admin":false},"repo":{"id":2751440,"name":"chorus","full_name":"Chorus/chorus","owner":{"login":"Chorus","id":5614676,"avatar_url":"https://avatars.githubusercontent.com/u/5614676?v=3","gravatar_id":"","url":"https://api.github.com/users/Chorus","html_url":"https://github.com/Chorus","followers_url":"https://api.github.com/users/Chorus/followers","following_url":"https://api.github.com/users/Chorus/following{/other_user}","gists_url":"https://api.github.com/users/Chorus/gists{/gist_id}","starred_url":"https://api.github.com/users/Chorus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Chorus/subscriptions","organizations_url":"https://api.github.com/users/Chorus/orgs","repos_url":"https://api.github.com/users/Chorus/repos","events_url":"https://api.github.com/users/Chorus/events{/privacy}","received_events_url":"https://api.github.com/users/Chorus/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Chorus/chorus","description":"Chorus allows customers, partners, developers, and data scientists to collaboratively realize the potential of Big Data.","fork":false,"url":"https://api.github.com/repos/Chorus/chorus","forks_url":"https://api.github.com/repos/Chorus/chorus/forks","keys_url":"https://api.github.com/repos/Chorus/chorus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Chorus/chorus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Chorus/chorus/teams","hooks_url":"https://api.github.com/repos/Chorus/chorus/hooks","issue_events_url":"https://api.github.com/repos/Chorus/chorus/issues/events{/number}","events_url":"https://api.github.com/repos/Chorus/chorus/events","assignees_url":"https://api.github.com/repos/Chorus/chorus/assignees{/user}","branches_url":"https://api.github.com/repos/Chorus/chorus/branches{/branch}","tags_url":"https://api.github.com/repos/Chorus/chorus/tags","blobs_url":"https://api.github.com/repos/Chorus/chorus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Chorus/chorus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Chorus/chorus/git/refs{/sha}","trees_url":"https://api.github.com/repos/Chorus/chorus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Chorus/chorus/statuses/{sha}","languages_url":"https://api.github.com/repos/Chorus/chorus/languages","stargazers_url":"https://api.github.com/repos/Chorus/chorus/stargazers","contributors_url":"https://api.github.com/repos/Chorus/chorus/contributors","subscribers_url":"https://api.github.com/repos/Chorus/chorus/subscribers","subscription_url":"https://api.github.com/repos/Chorus/chorus/subscription","commits_url":"https://api.github.com/repos/Chorus/chorus/commits{/sha}","git_commits_url":"https://api.github.com/repos/Chorus/chorus/git/commits{/sha}","comments_url":"https://api.github.com/repos/Chorus/chorus/comments{/number}","issue_comment_url":"https://api.github.com/repos/Chorus/chorus/issues/comments{/number}","contents_url":"https://api.github.com/repos/Chorus/chorus/contents/{+path}","compare_url":"https://api.github.com/repos/Chorus/chorus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Chorus/chorus/merges","archive_url":"https://api.github.com/repos/Chorus/chorus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Chorus/chorus/downloads","issues_url":"https://api.github.com/repos/Chorus/chorus/issues{/number}","pulls_url":"https://api.github.com/repos/Chorus/chorus/pulls{/number}","milestones_url":"https://api.github.com/repos/Chorus/chorus/milestones{/number}","notifications_url":"https://api.github.com/repos/Chorus/chorus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Chorus/chorus/labels{/name}","releases_url":"https://api.github.com/repos/Chorus/chorus/releases{/id}","deployments_url":"https://api.github.com/repos/Chorus/chorus/deployments","created_at":"2011-11-10T20:30:13Z","updated_at":"2016-04-05T14:28:50Z","pushed_at":"2016-04-21T03:59:53Z","git_url":"git://github.com/Chorus/chorus.git","ssh_url":"git@github.com:Chorus/chorus.git","clone_url":"https://github.com/Chorus/chorus.git","svn_url":"https://github.com/Chorus/chorus","homepage":"","size":907947,"stargazers_count":182,"watchers_count":182,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":73,"mirror_url":null,"open_issues_count":14,"forks":73,"open_issues":14,"watchers":182,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Chorus/chorus/pulls/282"},"html":{"href":"https://github.com/Chorus/chorus/pull/282"},"issue":{"href":"https://api.github.com/repos/Chorus/chorus/issues/282"},"comments":{"href":"https://api.github.com/repos/Chorus/chorus/issues/282/comments"},"review_comments":{"href":"https://api.github.com/repos/Chorus/chorus/pulls/282/comments"},"review_comment":{"href":"https://api.github.com/repos/Chorus/chorus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Chorus/chorus/pulls/282/commits"},"statuses":{"href":"https://api.github.com/repos/Chorus/chorus/statuses/1369f9f3dee82440a9a0a761826950866268f39d"}}}}