{"action":"created","issue":{"url":"https://api.github.com/repos/kennethreitz/requests/issues/3385","repository_url":"https://api.github.com/repos/kennethreitz/requests","labels_url":"https://api.github.com/repos/kennethreitz/requests/issues/3385/labels{/name}","comments_url":"https://api.github.com/repos/kennethreitz/requests/issues/3385/comments","events_url":"https://api.github.com/repos/kennethreitz/requests/issues/3385/events","html_url":"https://github.com/kennethreitz/requests/pull/3385","id":163801538,"number":3385,"title":"Support responses like `HTTP/1.1 404 öööööööö`","user":{"login":"gugu","id":75169,"avatar_url":"https://avatars.githubusercontent.com/u/75169?v=3","gravatar_id":"","url":"https://api.github.com/users/gugu","html_url":"https://github.com/gugu","followers_url":"https://api.github.com/users/gugu/followers","following_url":"https://api.github.com/users/gugu/following{/other_user}","gists_url":"https://api.github.com/users/gugu/gists{/gist_id}","starred_url":"https://api.github.com/users/gugu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gugu/subscriptions","organizations_url":"https://api.github.com/users/gugu/orgs","repos_url":"https://api.github.com/users/gugu/repos","events_url":"https://api.github.com/users/gugu/events{/privacy}","received_events_url":"https://api.github.com/users/gugu/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-07-05T08:54:17Z","updated_at":"2016-07-05T08:59:04Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kennethreitz/requests/pulls/3385","html_url":"https://github.com/kennethreitz/requests/pull/3385","diff_url":"https://github.com/kennethreitz/requests/pull/3385.diff","patch_url":"https://github.com/kennethreitz/requests/pull/3385.patch"},"body":"Currently this code raises UnicodeDecodeError:\r\n\r\n`requests.get('http://www.voice.fi//lampaan-kiveksia-ja-coca-cola-hulluutta-5-asiaa-joita-et-tiennyt-islannista-122015?utm_source=feed&utm_medium=feed&utm_content=article_link&utm_campaign=feed').ok`\r\n\r\nHere is their status:\r\n`HTTP/1.1 404 Komponenttia ei löydy`\r\n\r\nThis pull request allow module to handle URLs like this correctly"},"comment":{"url":"https://api.github.com/repos/kennethreitz/requests/issues/comments/230423914","html_url":"https://github.com/kennethreitz/requests/pull/3385#issuecomment-230423914","issue_url":"https://api.github.com/repos/kennethreitz/requests/issues/3385","id":230423914,"user":{"login":"Lukasa","id":1382556,"avatar_url":"https://avatars.githubusercontent.com/u/1382556?v=3","gravatar_id":"","url":"https://api.github.com/users/Lukasa","html_url":"https://github.com/Lukasa","followers_url":"https://api.github.com/users/Lukasa/followers","following_url":"https://api.github.com/users/Lukasa/following{/other_user}","gists_url":"https://api.github.com/users/Lukasa/gists{/gist_id}","starred_url":"https://api.github.com/users/Lukasa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lukasa/subscriptions","organizations_url":"https://api.github.com/users/Lukasa/orgs","repos_url":"https://api.github.com/users/Lukasa/repos","events_url":"https://api.github.com/users/Lukasa/events{/privacy}","received_events_url":"https://api.github.com/users/Lukasa/received_events","type":"User","site_admin":false},"created_at":"2016-07-05T08:59:04Z","updated_at":"2016-07-05T08:59:04Z","body":"Generally speaking I'm not too interested in supporting this kind of logic: servers are really not supposed to be sending non-ASCII-bytes in the reason phrase, and choosing to assume that UTF-8 is being used is really fairly optimistic.\r\n\r\nHowever, in the case of `raise_for_status`, we're exploding in a situation that we don't need to. RFC 7230 says we should ignore the reason phrase, and we're choosing not to do that, so the least we should do is *not* explode if it's weird. For that reason, I'm in favour of a patch like this, though I'd like us to change the decode logic to make sure that we will *always* successfully decode the reason phrase, even if we decode it to gibberish."}}
{"actor":{"display_login":"Lukasa"}}