{"action":"created","comment":{"url":"https://api.github.com/repos/mholt/caddy/pulls/comments/90151597","pull_request_review_id":10675230,"id":90151597,"diff_hunk":"@@ -53,15 +53,13 @@ func fastcgiParse(c *caddy.Controller) ([]Rule, error) {\n \tvar rules []Rule\n \n \tfor c.Next() {\n-\t\tvar rule Rule\n-\n \t\targs := c.RemainingArgs()\n \n \t\tif len(args) < 2 || len(args) > 3 {\n \t\t\treturn rules, c.ArgErr()\n \t\t}\n \n-\t\trule.Path = args[0]\n+\t\trule := Rule{Path: args[0], ReadTimeout: 60 * time.Second}","path":"caddyhttp/fastcgi/setup.go","position":13,"original_position":13,"commit_id":"32fa0ce6a08a61d4fcd912a348a38f8665177e99","original_commit_id":"b8722d9af3b09944ef905e80bcd0a84515af24f2","user":{"login":"ericdreeves","id":12223463,"avatar_url":"https://avatars.githubusercontent.com/u/12223463?v=3","gravatar_id":"","url":"https://api.github.com/users/ericdreeves","html_url":"https://github.com/ericdreeves","followers_url":"https://api.github.com/users/ericdreeves/followers","following_url":"https://api.github.com/users/ericdreeves/following{/other_user}","gists_url":"https://api.github.com/users/ericdreeves/gists{/gist_id}","starred_url":"https://api.github.com/users/ericdreeves/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericdreeves/subscriptions","organizations_url":"https://api.github.com/users/ericdreeves/orgs","repos_url":"https://api.github.com/users/ericdreeves/repos","events_url":"https://api.github.com/users/ericdreeves/events{/privacy}","received_events_url":"https://api.github.com/users/ericdreeves/received_events","type":"User","site_admin":false},"body":"Thanks for the feedback.\r\n\r\nSpeaking of documentation, I'm happy to make those changes as well.","created_at":"2016-11-30T01:14:01Z","updated_at":"2016-11-30T01:14:01Z","html_url":"https://github.com/mholt/caddy/pull/1274#discussion_r90151597","pull_request_url":"https://api.github.com/repos/mholt/caddy/pulls/1274","_links":{"self":{"href":"https://api.github.com/repos/mholt/caddy/pulls/comments/90151597"},"html":{"href":"https://github.com/mholt/caddy/pull/1274#discussion_r90151597"},"pull_request":{"href":"https://api.github.com/repos/mholt/caddy/pulls/1274"}}},"pull_request":{"url":"https://api.github.com/repos/mholt/caddy/pulls/1274","id":95329023,"html_url":"https://github.com/mholt/caddy/pull/1274","diff_url":"https://github.com/mholt/caddy/pull/1274.diff","patch_url":"https://github.com/mholt/caddy/pull/1274.patch","issue_url":"https://api.github.com/repos/mholt/caddy/issues/1274","number":1274,"state":"closed","locked":false,"title":"Fix read timeout and add default timeout values.","user":{"login":"ericdreeves","id":12223463,"avatar_url":"https://avatars.githubusercontent.com/u/12223463?v=3","gravatar_id":"","url":"https://api.github.com/users/ericdreeves","html_url":"https://github.com/ericdreeves","followers_url":"https://api.github.com/users/ericdreeves/followers","following_url":"https://api.github.com/users/ericdreeves/following{/other_user}","gists_url":"https://api.github.com/users/ericdreeves/gists{/gist_id}","starred_url":"https://api.github.com/users/ericdreeves/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericdreeves/subscriptions","organizations_url":"https://api.github.com/users/ericdreeves/orgs","repos_url":"https://api.github.com/users/ericdreeves/repos","events_url":"https://api.github.com/users/ericdreeves/events{/privacy}","received_events_url":"https://api.github.com/users/ericdreeves/received_events","type":"User","site_admin":false},"body":"By setting the read deadline in streamReader.Read(), the deadline was\r\nextended by the read timeout on each subsequent call. To avoid this, the\r\ndeadline is set in FCGIClient.Request(), before the first read occurs.\r\n\r\nAdditionally, the read_timeout and connect_timeout properties now have a\r\ndefault value of 60 seconds.\r\n\r\nSee #1094.","created_at":"2016-11-25T16:38:23Z","updated_at":"2016-11-30T01:14:01Z","closed_at":"2016-11-30T01:13:12Z","merged_at":"2016-11-30T01:13:12Z","merge_commit_sha":"76f12f475ba4b9b332320779f050273bc044d25c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mholt/caddy/pulls/1274/commits","review_comments_url":"https://api.github.com/repos/mholt/caddy/pulls/1274/comments","review_comment_url":"https://api.github.com/repos/mholt/caddy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mholt/caddy/issues/1274/comments","statuses_url":"https://api.github.com/repos/mholt/caddy/statuses/32fa0ce6a08a61d4fcd912a348a38f8665177e99","head":{"label":"mholt:fastcgi-timeout-defaults","ref":"fastcgi-timeout-defaults","sha":"32fa0ce6a08a61d4fcd912a348a38f8665177e99","user":{"login":"mholt","id":1128849,"avatar_url":"https://avatars.githubusercontent.com/u/1128849?v=3","gravatar_id":"","url":"https://api.github.com/users/mholt","html_url":"https://github.com/mholt","followers_url":"https://api.github.com/users/mholt/followers","following_url":"https://api.github.com/users/mholt/following{/other_user}","gists_url":"https://api.github.com/users/mholt/gists{/gist_id}","starred_url":"https://api.github.com/users/mholt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mholt/subscriptions","organizations_url":"https://api.github.com/users/mholt/orgs","repos_url":"https://api.github.com/users/mholt/repos","events_url":"https://api.github.com/users/mholt/events{/privacy}","received_events_url":"https://api.github.com/users/mholt/received_events","type":"User","site_admin":false},"repo":{"id":29207621,"name":"caddy","full_name":"mholt/caddy","owner":{"login":"mholt","id":1128849,"avatar_url":"https://avatars.githubusercontent.com/u/1128849?v=3","gravatar_id":"","url":"https://api.github.com/users/mholt","html_url":"https://github.com/mholt","followers_url":"https://api.github.com/users/mholt/followers","following_url":"https://api.github.com/users/mholt/following{/other_user}","gists_url":"https://api.github.com/users/mholt/gists{/gist_id}","starred_url":"https://api.github.com/users/mholt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mholt/subscriptions","organizations_url":"https://api.github.com/users/mholt/orgs","repos_url":"https://api.github.com/users/mholt/repos","events_url":"https://api.github.com/users/mholt/events{/privacy}","received_events_url":"https://api.github.com/users/mholt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mholt/caddy","description":"Fast, cross-platform HTTP/2 web server with automatic HTTPS","fork":false,"url":"https://api.github.com/repos/mholt/caddy","forks_url":"https://api.github.com/repos/mholt/caddy/forks","keys_url":"https://api.github.com/repos/mholt/caddy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mholt/caddy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mholt/caddy/teams","hooks_url":"https://api.github.com/repos/mholt/caddy/hooks","issue_events_url":"https://api.github.com/repos/mholt/caddy/issues/events{/number}","events_url":"https://api.github.com/repos/mholt/caddy/events","assignees_url":"https://api.github.com/repos/mholt/caddy/assignees{/user}","branches_url":"https://api.github.com/repos/mholt/caddy/branches{/branch}","tags_url":"https://api.github.com/repos/mholt/caddy/tags","blobs_url":"https://api.github.com/repos/mholt/caddy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mholt/caddy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mholt/caddy/git/refs{/sha}","trees_url":"https://api.github.com/repos/mholt/caddy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mholt/caddy/statuses/{sha}","languages_url":"https://api.github.com/repos/mholt/caddy/languages","stargazers_url":"https://api.github.com/repos/mholt/caddy/stargazers","contributors_url":"https://api.github.com/repos/mholt/caddy/contributors","subscribers_url":"https://api.github.com/repos/mholt/caddy/subscribers","subscription_url":"https://api.github.com/repos/mholt/caddy/subscription","commits_url":"https://api.github.com/repos/mholt/caddy/commits{/sha}","git_commits_url":"https://api.github.com/repos/mholt/caddy/git/commits{/sha}","comments_url":"https://api.github.com/repos/mholt/caddy/comments{/number}","issue_comment_url":"https://api.github.com/repos/mholt/caddy/issues/comments{/number}","contents_url":"https://api.github.com/repos/mholt/caddy/contents/{+path}","compare_url":"https://api.github.com/repos/mholt/caddy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mholt/caddy/merges","archive_url":"https://api.github.com/repos/mholt/caddy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mholt/caddy/downloads","issues_url":"https://api.github.com/repos/mholt/caddy/issues{/number}","pulls_url":"https://api.github.com/repos/mholt/caddy/pulls{/number}","milestones_url":"https://api.github.com/repos/mholt/caddy/milestones{/number}","notifications_url":"https://api.github.com/repos/mholt/caddy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mholt/caddy/labels{/name}","releases_url":"https://api.github.com/repos/mholt/caddy/releases{/id}","deployments_url":"https://api.github.com/repos/mholt/caddy/deployments","created_at":"2015-01-13T19:45:03Z","updated_at":"2016-11-30T00:37:09Z","pushed_at":"2016-11-30T01:13:12Z","git_url":"git://github.com/mholt/caddy.git","ssh_url":"git@github.com:mholt/caddy.git","clone_url":"https://github.com/mholt/caddy.git","svn_url":"https://github.com/mholt/caddy","homepage":"https://caddyserver.com","size":3814,"stargazers_count":9096,"watchers_count":9096,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":587,"mirror_url":null,"open_issues_count":56,"forks":587,"open_issues":56,"watchers":9096,"default_branch":"master"}},"base":{"label":"mholt:master","ref":"master","sha":"80eb45fcfb73be7ecf55caba443c0c2fcfbd278c","user":{"login":"mholt","id":1128849,"avatar_url":"https://avatars.githubusercontent.com/u/1128849?v=3","gravatar_id":"","url":"https://api.github.com/users/mholt","html_url":"https://github.com/mholt","followers_url":"https://api.github.com/users/mholt/followers","following_url":"https://api.github.com/users/mholt/following{/other_user}","gists_url":"https://api.github.com/users/mholt/gists{/gist_id}","starred_url":"https://api.github.com/users/mholt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mholt/subscriptions","organizations_url":"https://api.github.com/users/mholt/orgs","repos_url":"https://api.github.com/users/mholt/repos","events_url":"https://api.github.com/users/mholt/events{/privacy}","received_events_url":"https://api.github.com/users/mholt/received_events","type":"User","site_admin":false},"repo":{"id":29207621,"name":"caddy","full_name":"mholt/caddy","owner":{"login":"mholt","id":1128849,"avatar_url":"https://avatars.githubusercontent.com/u/1128849?v=3","gravatar_id":"","url":"https://api.github.com/users/mholt","html_url":"https://github.com/mholt","followers_url":"https://api.github.com/users/mholt/followers","following_url":"https://api.github.com/users/mholt/following{/other_user}","gists_url":"https://api.github.com/users/mholt/gists{/gist_id}","starred_url":"https://api.github.com/users/mholt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mholt/subscriptions","organizations_url":"https://api.github.com/users/mholt/orgs","repos_url":"https://api.github.com/users/mholt/repos","events_url":"https://api.github.com/users/mholt/events{/privacy}","received_events_url":"https://api.github.com/users/mholt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mholt/caddy","description":"Fast, cross-platform HTTP/2 web server with automatic HTTPS","fork":false,"url":"https://api.github.com/repos/mholt/caddy","forks_url":"https://api.github.com/repos/mholt/caddy/forks","keys_url":"https://api.github.com/repos/mholt/caddy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mholt/caddy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mholt/caddy/teams","hooks_url":"https://api.github.com/repos/mholt/caddy/hooks","issue_events_url":"https://api.github.com/repos/mholt/caddy/issues/events{/number}","events_url":"https://api.github.com/repos/mholt/caddy/events","assignees_url":"https://api.github.com/repos/mholt/caddy/assignees{/user}","branches_url":"https://api.github.com/repos/mholt/caddy/branches{/branch}","tags_url":"https://api.github.com/repos/mholt/caddy/tags","blobs_url":"https://api.github.com/repos/mholt/caddy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mholt/caddy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mholt/caddy/git/refs{/sha}","trees_url":"https://api.github.com/repos/mholt/caddy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mholt/caddy/statuses/{sha}","languages_url":"https://api.github.com/repos/mholt/caddy/languages","stargazers_url":"https://api.github.com/repos/mholt/caddy/stargazers","contributors_url":"https://api.github.com/repos/mholt/caddy/contributors","subscribers_url":"https://api.github.com/repos/mholt/caddy/subscribers","subscription_url":"https://api.github.com/repos/mholt/caddy/subscription","commits_url":"https://api.github.com/repos/mholt/caddy/commits{/sha}","git_commits_url":"https://api.github.com/repos/mholt/caddy/git/commits{/sha}","comments_url":"https://api.github.com/repos/mholt/caddy/comments{/number}","issue_comment_url":"https://api.github.com/repos/mholt/caddy/issues/comments{/number}","contents_url":"https://api.github.com/repos/mholt/caddy/contents/{+path}","compare_url":"https://api.github.com/repos/mholt/caddy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mholt/caddy/merges","archive_url":"https://api.github.com/repos/mholt/caddy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mholt/caddy/downloads","issues_url":"https://api.github.com/repos/mholt/caddy/issues{/number}","pulls_url":"https://api.github.com/repos/mholt/caddy/pulls{/number}","milestones_url":"https://api.github.com/repos/mholt/caddy/milestones{/number}","notifications_url":"https://api.github.com/repos/mholt/caddy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mholt/caddy/labels{/name}","releases_url":"https://api.github.com/repos/mholt/caddy/releases{/id}","deployments_url":"https://api.github.com/repos/mholt/caddy/deployments","created_at":"2015-01-13T19:45:03Z","updated_at":"2016-11-30T00:37:09Z","pushed_at":"2016-11-30T01:13:12Z","git_url":"git://github.com/mholt/caddy.git","ssh_url":"git@github.com:mholt/caddy.git","clone_url":"https://github.com/mholt/caddy.git","svn_url":"https://github.com/mholt/caddy","homepage":"https://caddyserver.com","size":3814,"stargazers_count":9096,"watchers_count":9096,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":587,"mirror_url":null,"open_issues_count":56,"forks":587,"open_issues":56,"watchers":9096,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mholt/caddy/pulls/1274"},"html":{"href":"https://github.com/mholt/caddy/pull/1274"},"issue":{"href":"https://api.github.com/repos/mholt/caddy/issues/1274"},"comments":{"href":"https://api.github.com/repos/mholt/caddy/issues/1274/comments"},"review_comments":{"href":"https://api.github.com/repos/mholt/caddy/pulls/1274/comments"},"review_comment":{"href":"https://api.github.com/repos/mholt/caddy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mholt/caddy/pulls/1274/commits"},"statuses":{"href":"https://api.github.com/repos/mholt/caddy/statuses/32fa0ce6a08a61d4fcd912a348a38f8665177e99"}}}}
{"actor":{"display_login":"ericdreeves"}}