{"action":"created","issue":{"url":"https://api.github.com/repos/graphql-go/graphql/issues/117","repository_url":"https://api.github.com/repos/graphql-go/graphql","labels_url":"https://api.github.com/repos/graphql-go/graphql/issues/117/labels{/name}","comments_url":"https://api.github.com/repos/graphql-go/graphql/issues/117/comments","events_url":"https://api.github.com/repos/graphql-go/graphql/issues/117/events","html_url":"https://github.com/graphql-go/graphql/pull/117","id":138925592,"number":117,"title":"Port changes from `graphql-js` v0.4.18 (Oct 2015 spec)","user":{"login":"sogko","id":78585,"avatar_url":"https://avatars.githubusercontent.com/u/78585?v=3","gravatar_id":"","url":"https://api.github.com/users/sogko","html_url":"https://github.com/sogko","followers_url":"https://api.github.com/users/sogko/followers","following_url":"https://api.github.com/users/sogko/following{/other_user}","gists_url":"https://api.github.com/users/sogko/gists{/gist_id}","starred_url":"https://api.github.com/users/sogko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sogko/subscriptions","organizations_url":"https://api.github.com/users/sogko/orgs","repos_url":"https://api.github.com/users/sogko/repos","events_url":"https://api.github.com/users/sogko/events{/privacy}","received_events_url":"https://api.github.com/users/sogko/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/graphql-go/graphql/milestones/2","html_url":"https://github.com/graphql-go/graphql/milestones/0.4.18","labels_url":"https://api.github.com/repos/graphql-go/graphql/milestones/2/labels","id":1625887,"number":2,"title":"0.4.18","description":"","creator":{"login":"sogko","id":78585,"avatar_url":"https://avatars.githubusercontent.com/u/78585?v=3","gravatar_id":"","url":"https://api.github.com/users/sogko","html_url":"https://github.com/sogko","followers_url":"https://api.github.com/users/sogko/followers","following_url":"https://api.github.com/users/sogko/following{/other_user}","gists_url":"https://api.github.com/users/sogko/gists{/gist_id}","starred_url":"https://api.github.com/users/sogko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sogko/subscriptions","organizations_url":"https://api.github.com/users/sogko/orgs","repos_url":"https://api.github.com/users/sogko/repos","events_url":"https://api.github.com/users/sogko/events{/privacy}","received_events_url":"https://api.github.com/users/sogko/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":2,"state":"open","created_at":"2016-03-07T11:23:07Z","updated_at":"2016-03-16T16:48:58Z","due_on":null,"closed_at":null},"comments":3,"created_at":"2016-03-07T09:07:29Z","updated_at":"2016-05-05T04:07:29Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/graphql-go/graphql/pulls/117","html_url":"https://github.com/graphql-go/graphql/pull/117","diff_url":"https://github.com/graphql-go/graphql/pull/117.diff","patch_url":"https://github.com/graphql-go/graphql/pull/117.patch"},"body":"Started work on porting changes from `graphql-js` v0.4.18 which is based on the latest Oct 2015 spec.\r\n\r\nPrevious port was based on v0.4.3.\r\n\r\n----\r\n\r\n__Plan:__\r\n- [x] error/\r\n- [x] languages/\r\n- [x] types/\r\n- [x] execution/\r\n- [x] validation/\r\n- [x] Fix `go lint` warnings _(Fixed all warnings except for missing comments for exported functions or vars etc)_\r\n\r\n---\r\n\r\n__Notable changes:__\r\n- Move the extension definition out of type definition\r\n\r\n- [RFC] Type condition optional on inline fragments.\r\n   - Implements https://github.com/facebook/graphql/pull/100\r\n\r\n- [RFC] Make operation name optional.\r\n  - Implements https://github.com/facebook/graphql/pull/99\r\n\r\n- Spec compliant Int sizing https://github.com/graphql/graphql-js/commit/06f97b67491f0215df7536aac50361bd90d5097d\r\n  - Affects PR #83  previously contributed by @bbuck \r\n  - WIP Port at: https://github.com/sogko/graphql/commit/c129ede581ccdfa08981c28954208fae18b051e3\r\n  -  `graphql.Int` now enforces strict compliance to the spec.\r\n  - `int` and `uint` that exceeds 2^32 will be considered as invalid `graphql.Int`\r\n  - Added/updated `scalars_serialization_test.go` to reflect the changes\r\n  - /cc @chris-ramon @bbuck \r\n\r\n- Experimental: customisable validation: 5a6ab116cadafbaf613387dd22a8e4b7b36738e2 [5a6ab11]\r\n  - Changed function signature for `graphql.NewTypeInfo()` to accept a struct.\r\n  - Allows the possibility to remove the experimental `FieldDefFn` params\r\n\r\n\r\n__Changes to public/exported vars / func__\r\n\r\nPrevious | New | Risk\r\n---------|-----|-------\r\n`graphql.NAME_REGEXP` | `graphql.NameRegExp` | Low\r\n`graphql.CollectFieldsParam.OperationType` | `graphql.CollectFieldsParam.RuntimeType` | Low\r\n`graphql.GetVisitFn(*visitorOptions, bool, string)` | `graphql.GetVisitFn(*visitorOptions, string, bool)`  | Low\r\n`graphql.NewTypeInfo(*Schema)` | `graphql.NewTypeInfo(*TypeInfoConfig)`  | Low\r\n\r\n\r\n---\r\n\r\nUpdate: After a certain point, the coverage starts to decrease by around 6%. I'll work on it after porting the whole thing.\r\nUpdate: Coverage went back up +3%\r\n\r\n\r\n\r\nCheers!"},"comment":{"url":"https://api.github.com/repos/graphql-go/graphql/issues/comments/217072962","html_url":"https://github.com/graphql-go/graphql/pull/117#issuecomment-217072962","issue_url":"https://api.github.com/repos/graphql-go/graphql/issues/117","id":217072962,"user":{"login":"coveralls","id":2354108,"avatar_url":"https://avatars.githubusercontent.com/u/2354108?v=3","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2016-05-05T04:07:29Z","updated_at":"2016-05-05T04:07:29Z","body":"\n[![Coverage Status](https://coveralls.io/builds/6057470/badge)](https://coveralls.io/builds/6057470)\n\nCoverage increased (+3.2%) to 90.751% when pulling **c4394ae0505d26b7e7c3f548f345984f6db4373e on sogko:sogko/0.4.18** into **909ca9f800e7ab67307b4f9f1d56394346acb33c on graphql-go:master**.\n"}}