{"action":"created","issue":{"url":"https://api.github.com/repos/KeplerGO/K2fov/issues/15","repository_url":"https://api.github.com/repos/KeplerGO/K2fov","labels_url":"https://api.github.com/repos/KeplerGO/K2fov/issues/15/labels{/name}","comments_url":"https://api.github.com/repos/KeplerGO/K2fov/issues/15/comments","events_url":"https://api.github.com/repos/KeplerGO/K2fov/issues/15/events","html_url":"https://github.com/KeplerGO/K2fov/issues/15","id":137729267,"number":15,"title":"Unexpected gap between contiguous channels","user":{"login":"barentsen","id":817669,"avatar_url":"https://avatars.githubusercontent.com/u/817669?v=3","gravatar_id":"","url":"https://api.github.com/users/barentsen","html_url":"https://github.com/barentsen","followers_url":"https://api.github.com/users/barentsen/followers","following_url":"https://api.github.com/users/barentsen/following{/other_user}","gists_url":"https://api.github.com/users/barentsen/gists{/gist_id}","starred_url":"https://api.github.com/users/barentsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/barentsen/subscriptions","organizations_url":"https://api.github.com/users/barentsen/orgs","repos_url":"https://api.github.com/users/barentsen/repos","events_url":"https://api.github.com/users/barentsen/events{/privacy}","received_events_url":"https://api.github.com/users/barentsen/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"mrtommyb","id":1900573,"avatar_url":"https://avatars.githubusercontent.com/u/1900573?v=3","gravatar_id":"","url":"https://api.github.com/users/mrtommyb","html_url":"https://github.com/mrtommyb","followers_url":"https://api.github.com/users/mrtommyb/followers","following_url":"https://api.github.com/users/mrtommyb/following{/other_user}","gists_url":"https://api.github.com/users/mrtommyb/gists{/gist_id}","starred_url":"https://api.github.com/users/mrtommyb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrtommyb/subscriptions","organizations_url":"https://api.github.com/users/mrtommyb/orgs","repos_url":"https://api.github.com/users/mrtommyb/repos","events_url":"https://api.github.com/users/mrtommyb/events{/privacy}","received_events_url":"https://api.github.com/users/mrtommyb/received_events","type":"User","site_admin":false},"milestone":null,"comments":6,"created_at":"2016-03-02T00:08:02Z","updated_at":"2016-03-31T18:16:28Z","closed_at":null,"body":"When plotting a campaign using K2fov's `plotPointing`, a gap of ~10-15px is apparent in between channels that are expected to be contiguous.\r\n\r\nFor example, coordinate (ra, dec) = (185.87, -9.44924) falls inside the \"gap\" between channels 33 and 34 during Campaign 10.  There should be no gap between 33 and 34 however, they are the same ccd.\r\n\r\nThis behavior affects the functionality of `isOnSilicon`:\r\n```\r\nIn [19]: from K2fov.fields import getKeplerFov\r\nIn [20]: c10fov = getKeplerFov(10)\r\nIn [21]: c10fov.isOnSilicon(185.87, -9.44924, 0)\r\nOut[21]: False\r\n```\r\n(the expected result above is `True`)\r\n\r\nThe impact on target management is likely non-existent because of padding and inability to observe targets near edges.  However it may be worth understanding the behavior as it may expose a minor bug."},"comment":{"url":"https://api.github.com/repos/KeplerGO/K2fov/issues/comments/204062186","html_url":"https://github.com/KeplerGO/K2fov/issues/15#issuecomment-204062186","issue_url":"https://api.github.com/repos/KeplerGO/K2fov/issues/15","id":204062186,"user":{"login":"barentsen","id":817669,"avatar_url":"https://avatars.githubusercontent.com/u/817669?v=3","gravatar_id":"","url":"https://api.github.com/users/barentsen","html_url":"https://github.com/barentsen","followers_url":"https://api.github.com/users/barentsen/followers","following_url":"https://api.github.com/users/barentsen/following{/other_user}","gists_url":"https://api.github.com/users/barentsen/gists{/gist_id}","starred_url":"https://api.github.com/users/barentsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/barentsen/subscriptions","organizations_url":"https://api.github.com/users/barentsen/orgs","repos_url":"https://api.github.com/users/barentsen/repos","events_url":"https://api.github.com/users/barentsen/events{/privacy}","received_events_url":"https://api.github.com/users/barentsen/received_events","type":"User","site_admin":false},"created_at":"2016-03-31T18:16:28Z","updated_at":"2016-03-31T18:16:28Z","body":"What is the way  forward on this?  Should we, at minimum, increase the padding?\r\n\r\nThe default padding is currently defined in `__init__.py` as follows:\r\n\r\n```Python\r\n# Optical distortions can cause the results from K2fov to be off by a bit.\r\n# The padding parameter compensates for this; setting padding > 0 means\r\n# that objects that are computed to lie a small amount off silicon will\r\n# be considered on silicon.\r\nDEFAULT_PADDING = 3  # pixels\r\n```"}}