{"action":"created","issue":{"url":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues/448","repository_url":"https://api.github.com/repos/xamarin/Xamarin.Forms","labels_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues/448/labels{/name}","comments_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues/448/comments","events_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues/448/events","html_url":"https://github.com/xamarin/Xamarin.Forms/pull/448","id":182329396,"number":448,"title":"[iOS] Fix extra tab icon appearing in iOS for TabbedPage","user":{"login":"ckimes89","id":1936066,"avatar_url":"https://avatars.githubusercontent.com/u/1936066?v=3","gravatar_id":"","url":"https://api.github.com/users/ckimes89","html_url":"https://github.com/ckimes89","followers_url":"https://api.github.com/users/ckimes89/followers","following_url":"https://api.github.com/users/ckimes89/following{/other_user}","gists_url":"https://api.github.com/users/ckimes89/gists{/gist_id}","starred_url":"https://api.github.com/users/ckimes89/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckimes89/subscriptions","organizations_url":"https://api.github.com/users/ckimes89/orgs","repos_url":"https://api.github.com/users/ckimes89/repos","events_url":"https://api.github.com/users/ckimes89/events{/privacy}","received_events_url":"https://api.github.com/users/ckimes89/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/xamarin/Xamarin.Forms/labels/cla-signed","name":"cla-signed","color":"207de5"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-10-11T17:48:36Z","updated_at":"2016-10-11T20:03:02Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/448","html_url":"https://github.com/xamarin/Xamarin.Forms/pull/448","diff_url":"https://github.com/xamarin/Xamarin.Forms/pull/448.diff","patch_url":"https://github.com/xamarin/Xamarin.Forms/pull/448.patch"},"body":"### Description of Change ###\r\n\r\nThis adds a workaround for an iOS 10 bug that displays extra icons in a `UITabBarController` when the `UITabBarItem.Title` property is changed. More info here: http://stackoverflow.com/questions/38776978/ios-10-uitabbar-more-items-visible-after-setting-title\r\n\r\n### Bugs Fixed ###\r\n\r\nhttps://bugzilla.xamarin.com/show_bug.cgi?id=45284\r\n\r\n### API Changes ###\r\n\r\nAdded:\r\n - Forms.IsiOS10OrNewer { get; } // internal\r\n\r\n### Behavioral Changes ###\r\n\r\nNone\r\n\r\n### PR Checklist ###\r\n\r\n- [ ] Has tests (if omitted, state reason in description)\r\n- [ ] Rebased on top of master at time of PR\r\n- [ ] Changes adhere to coding standard\r\n- [ ] Consolidate commits as makes sense\r\n"},"comment":{"url":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues/comments/253028959","html_url":"https://github.com/xamarin/Xamarin.Forms/pull/448#issuecomment-253028959","issue_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues/448","id":253028959,"user":{"login":"ckimes89","id":1936066,"avatar_url":"https://avatars.githubusercontent.com/u/1936066?v=3","gravatar_id":"","url":"https://api.github.com/users/ckimes89","html_url":"https://github.com/ckimes89","followers_url":"https://api.github.com/users/ckimes89/followers","following_url":"https://api.github.com/users/ckimes89/following{/other_user}","gists_url":"https://api.github.com/users/ckimes89/gists{/gist_id}","starred_url":"https://api.github.com/users/ckimes89/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckimes89/subscriptions","organizations_url":"https://api.github.com/users/ckimes89/orgs","repos_url":"https://api.github.com/users/ckimes89/repos","events_url":"https://api.github.com/users/ckimes89/events{/privacy}","received_events_url":"https://api.github.com/users/ckimes89/received_events","type":"User","site_admin":false},"created_at":"2016-10-11T20:03:02Z","updated_at":"2016-10-11T20:03:02Z","body":"I considered that at first, but I didn't know if there were any performance considerations to build a new `UITabBarItem` with a new `UIImage` every time we changed just the title. Given that, I opted to limit the impact by gating it around iOS 10 only. If there's no noticeable performance impact then it would make sense to simplify the code and just always do the same thing for both properties."}}
{"actor":{"display_login":"ckimes89"}}