{"action":"created","issue":{"url":"https://api.github.com/repos/php/php-src/issues/1924","repository_url":"https://api.github.com/repos/php/php-src","labels_url":"https://api.github.com/repos/php/php-src/issues/1924/labels{/name}","comments_url":"https://api.github.com/repos/php/php-src/issues/1924/comments","events_url":"https://api.github.com/repos/php/php-src/issues/1924/events","html_url":"https://github.com/php/php-src/pull/1924","id":157362630,"number":1924,"title":"add php_create_socket/php_destroy_socket PHP_SOCKETS_API","user":{"login":"mcarbonneaux","id":8479023,"avatar_url":"https://avatars.githubusercontent.com/u/8479023?v=3","gravatar_id":"","url":"https://api.github.com/users/mcarbonneaux","html_url":"https://github.com/mcarbonneaux","followers_url":"https://api.github.com/users/mcarbonneaux/followers","following_url":"https://api.github.com/users/mcarbonneaux/following{/other_user}","gists_url":"https://api.github.com/users/mcarbonneaux/gists{/gist_id}","starred_url":"https://api.github.com/users/mcarbonneaux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcarbonneaux/subscriptions","organizations_url":"https://api.github.com/users/mcarbonneaux/orgs","repos_url":"https://api.github.com/users/mcarbonneaux/repos","events_url":"https://api.github.com/users/mcarbonneaux/events{/privacy}","received_events_url":"https://api.github.com/users/mcarbonneaux/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2016-05-29T00:15:46Z","updated_at":"2016-06-05T14:17:51Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/php/php-src/pulls/1924","html_url":"https://github.com/php/php-src/pull/1924","diff_url":"https://github.com/php/php-src/pull/1924.diff","patch_url":"https://github.com/php/php-src/pull/1924.patch"},"body":"add php_create_socket/php_destroy_socket PHP_SOCKETS_API to abel to create socket ressource in other extension."},"comment":{"url":"https://api.github.com/repos/php/php-src/issues/comments/223815552","html_url":"https://github.com/php/php-src/pull/1924#issuecomment-223815552","issue_url":"https://api.github.com/repos/php/php-src/issues/1924","id":223815552,"user":{"login":"bukka","id":137594,"avatar_url":"https://avatars.githubusercontent.com/u/137594?v=3","gravatar_id":"","url":"https://api.github.com/users/bukka","html_url":"https://github.com/bukka","followers_url":"https://api.github.com/users/bukka/followers","following_url":"https://api.github.com/users/bukka/following{/other_user}","gists_url":"https://api.github.com/users/bukka/gists{/gist_id}","starred_url":"https://api.github.com/users/bukka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bukka/subscriptions","organizations_url":"https://api.github.com/users/bukka/orgs","repos_url":"https://api.github.com/users/bukka/repos","events_url":"https://api.github.com/users/bukka/events{/privacy}","received_events_url":"https://api.github.com/users/bukka/received_events","type":"User","site_admin":false},"created_at":"2016-06-05T14:17:51Z","updated_at":"2016-06-05T14:17:51Z","body":"I'm not saying that it is not good to export the function which has been added to 7.0. I just don't think we should export it in bug fixing release because this is not a bug. It's just a missing feature that you can easily recreate in your ext. Adding it to 5.6.23 would mean that you still need to add it if you want to support 5.6.22- which is usually the case for most extensions. The problem is when there are more such features and you want to make extension compatible for all versions. Then you need to be checking if some features was added (e.g. some functions exported) in the bug fixing release which is really annoying.\r\n\r\nI'm not really bothered about this specific case but I think that we need to have a general rule to limit ABI additions in the bug fixing releases. It means not to backport anything that is not a bug fix and can be easily added to the extension."}}
{"actor":{"display_login":"bukka"}}