{"push_id":1258756231,"size":14,"distinct_size":3,"ref":"refs/heads/feature/cache-phpcs-runs-in-tests","head":"8571fe84b9f97e7095eab48f08b325cba1201609","before":"b8fe7f11595c378bdbe3f199180f409c15ecfeab","commits":[{"sha":"c4b513465cf09e09edfd368a43071809c21770ee","author":{"name":"jrfnl","email":"8631ff63bb8c036ee2665ede44adf9e43253d2c0@adviesenzo.nl"},"message":"Improve `ForbiddenBreakContinueVariableArguments` sniff (code review).\n\n* Bug fix: Throw error on closures. Looks like the intend was for this to be implemented, but the reality was that it wasn't working.\n* Break out of the `foreach()` as soon as we've determined there is an error, no need to go through the rest of the tokens.\n* Bow out early if check is not applicable.\n* Minor code simplification.\n* Add a number of additional unit test cases & simplified the test case file.\n* Reorganised the unit tests to data providers and moved the documentation for the various tests to the test case file.","distinct":false,"url":"https://api.github.com/repos/jrfnl/PHPCompatibility/commits/c4b513465cf09e09edfd368a43071809c21770ee"},{"sha":"73214b8b5e2fa0b9f7cd30ab2342dc04d2e1bf10","author":{"name":"jrfnl","email":"8631ff63bb8c036ee2665ede44adf9e43253d2c0@adviesenzo.nl"},"message":"Minor improvements to the `ForbiddenFunctionParametersWithSameName` sniff (code review).\n\n* Don't use function call in loop construct.\n* `getMethodParameters()` could return false or an empty array. Bow out early in that case.","distinct":false,"url":"https://api.github.com/repos/jrfnl/PHPCompatibility/commits/73214b8b5e2fa0b9f7cd30ab2342dc04d2e1bf10"},{"sha":"964eccdb708c7b36b8ac268d8a3fd7464b80d34a","author":{"name":"jrfnl","email":"8631ff63bb8c036ee2665ede44adf9e43253d2c0@adviesenzo.nl"},"message":"Minor improvements to `ForbiddenNamesAsInvokedFunctions` sniff (code review).\n\n* Some code simplification.\n* Some more strict checking.\n* Defer to native `PHP_CodeSniffer_Tokens::$emptyTokens` variable.","distinct":false,"url":"https://api.github.com/repos/jrfnl/PHPCompatibility/commits/964eccdb708c7b36b8ac268d8a3fd7464b80d34a"},{"sha":"f756fd1c23c437032cf5de41300ad3d817c184da","author":{"name":"Wim Godden","email":"b731def8552107795a4f1f571f9b9ccae7d7cf61@wimgodden.be"},"message":"Merge pull request #171 from jrfnl/feature/improve-break-continue\n\nImprove `ForbiddenBreakContinueVariableArguments` sniff (code review).","distinct":false,"url":"https://api.github.com/repos/jrfnl/PHPCompatibility/commits/f756fd1c23c437032cf5de41300ad3d817c184da"},{"sha":"31f795211c48db978550795fc92a7d97518fa432","author":{"name":"Wim Godden","email":"b731def8552107795a4f1f571f9b9ccae7d7cf61@wimgodden.be"},"message":"Merge pull request #178 from jrfnl/feature/improve-function-params-same-name\n\nMinor improvements to the `ForbiddenFunctionParametersWithSameName` sniff (code review).","distinct":false,"url":"https://api.github.com/repos/jrfnl/PHPCompatibility/commits/31f795211c48db978550795fc92a7d97518fa432"},{"sha":"2c50e46bbee032e4e0f166d7f1af0d571e0edede","author":{"name":"Wim Godden","email":"b731def8552107795a4f1f571f9b9ccae7d7cf61@wimgodden.be"},"message":"Merge pull request #179 from jrfnl/feature/improve-forbidden-function-name-invoked\n\nMinor improvements to `ForbiddenNamesAsInvokedFunctions` sniff (code review).","distinct":false,"url":"https://api.github.com/repos/jrfnl/PHPCompatibility/commits/2c50e46bbee032e4e0f166d7f1af0d571e0edede"},{"sha":"d3df138f19587b2e99e3c5c4a4cd464db04e847e","author":{"name":"Wim Godden","email":"b731def8552107795a4f1f571f9b9ccae7d7cf61@wimgodden.be"},"message":"Added coverage","distinct":false,"url":"https://api.github.com/repos/jrfnl/PHPCompatibility/commits/d3df138f19587b2e99e3c5c4a4cd464db04e847e"},{"sha":"16a0a8fdee5170af114b7d15d7123f9e7fa54995","author":{"name":"jrfnl","email":"8631ff63bb8c036ee2665ede44adf9e43253d2c0@adviesenzo.nl"},"message":"Add sniff for detecting alternative PHP open tags.\n\nASP and Script open tags were removed in PHP 7.","distinct":false,"url":"https://api.github.com/repos/jrfnl/PHPCompatibility/commits/16a0a8fdee5170af114b7d15d7123f9e7fa54995"},{"sha":"44d76b0bbd42294fe02d29113bb847926048071e","author":{"name":"jrfnl","email":"8631ff63bb8c036ee2665ede44adf9e43253d2c0@adviesenzo.nl"},"message":"Minor fix in ForbiddenNamesAsInvokedFunctionsSniff.\n\nArray keys are case-sensitive, while keywords when used wrong might not always use lowercase, so let's do a lowercase compare as the array in the sniff is all lowercase.","distinct":false,"url":"https://api.github.com/repos/jrfnl/PHPCompatibility/commits/44d76b0bbd42294fe02d29113bb847926048071e"},{"sha":"6197e38fad23693486b5415f746edc8dff124082","author":{"name":"Wim Godden","email":"b731def8552107795a4f1f571f9b9ccae7d7cf61@wimgodden.be"},"message":"Merge pull request #186 from jrfnl/feature/minor-fix-keywords\n\nMinor fix in ForbiddenNamesAsInvokedFunctionsSniff.","distinct":false,"url":"https://api.github.com/repos/jrfnl/PHPCompatibility/commits/6197e38fad23693486b5415f746edc8dff124082"},{"sha":"ea73b8c9c7b359c2d696f561d750d03d64dc1245","author":{"name":"Wim Godden","email":"b731def8552107795a4f1f571f9b9ccae7d7cf61@wimgodden.be"},"message":"Merge pull request #184 from jrfnl/feature/deprecated-alternative-php-tags\n\nAdd sniff for detecting alternative PHP open tags.","distinct":false,"url":"https://api.github.com/repos/jrfnl/PHPCompatibility/commits/ea73b8c9c7b359c2d696f561d750d03d64dc1245"},{"sha":"39cdb0fb5363978d370f844b1e4ae2a233da0b39","author":{"name":"jrfnl","email":"8631ff63bb8c036ee2665ede44adf9e43253d2c0@adviesenzo.nl"},"message":"Add new sniff to check for use of `empty()` with non-variable arguments.\n\n> Prior to PHP 5.5, empty() only supports variables; anything else will result in a parse error. In other words, the following will not work: empty(trim($name)). Instead, use trim($name) == false.\n\nRef: http://php.net/manual/en/function.empty.php","distinct":true,"url":"https://api.github.com/repos/jrfnl/PHPCompatibility/commits/39cdb0fb5363978d370f844b1e4ae2a233da0b39"},{"sha":"dfa1010f47e8962b6d3b21cd9ee2cd544f421cb5","author":{"name":"Wim Godden","email":"b731def8552107795a4f1f571f9b9ccae7d7cf61@wimgodden.be"},"message":"Merge pull request #187 from jrfnl/feature/new-empty-allow-non-vars\n\nAdd new sniff to check for use of `empty()` with non-variable arguments.","distinct":true,"url":"https://api.github.com/repos/jrfnl/PHPCompatibility/commits/dfa1010f47e8962b6d3b21cd9ee2cd544f421cb5"},{"sha":"8571fe84b9f97e7095eab48f08b325cba1201609","author":{"name":"jrfnl","email":"8631ff63bb8c036ee2665ede44adf9e43253d2c0@adviesenzo.nl"},"message":"Share the PHPCS instance between tests in the same class & cache run results.\n\nSee if I can make the tests run a bit faster by caching the results of the PHPCS runs.","distinct":true,"url":"https://api.github.com/repos/jrfnl/PHPCompatibility/commits/8571fe84b9f97e7095eab48f08b325cba1201609"}]}
{"actor":{"display_login":"jrfnl"}}