{"action":"created","issue":{"url":"https://api.github.com/repos/LLNL/RAJA/issues/74","repository_url":"https://api.github.com/repos/LLNL/RAJA","labels_url":"https://api.github.com/repos/LLNL/RAJA/issues/74/labels{/name}","comments_url":"https://api.github.com/repos/LLNL/RAJA/issues/74/comments","events_url":"https://api.github.com/repos/LLNL/RAJA/issues/74/events","html_url":"https://github.com/LLNL/RAJA/pull/74","id":163016052,"number":74,"title":"adding pullapprove configuration","user":{"login":"trws","id":660149,"avatar_url":"https://avatars.githubusercontent.com/u/660149?v=3","gravatar_id":"","url":"https://api.github.com/users/trws","html_url":"https://github.com/trws","followers_url":"https://api.github.com/users/trws/followers","following_url":"https://api.github.com/users/trws/following{/other_user}","gists_url":"https://api.github.com/users/trws/gists{/gist_id}","starred_url":"https://api.github.com/users/trws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trws/subscriptions","organizations_url":"https://api.github.com/users/trws/orgs","repos_url":"https://api.github.com/users/trws/repos","events_url":"https://api.github.com/users/trws/events{/privacy}","received_events_url":"https://api.github.com/users/trws/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":11,"created_at":"2016-06-29T20:14:12Z","updated_at":"2016-06-29T20:48:57Z","closed_at":"2016-06-29T20:36:48Z","pull_request":{"url":"https://api.github.com/repos/LLNL/RAJA/pulls/74","html_url":"https://github.com/LLNL/RAJA/pull/74","diff_url":"https://github.com/LLNL/RAJA/pull/74.diff","patch_url":"https://github.com/LLNL/RAJA/pull/74.patch"},"body":"This adds a pullapprove configuration.  You can read the YAML for full details, but PRs will require two approvals from the group @ajkunen, @keasler, @rhornung67, and @trws (this is arbitrary and temporary, let me know who all should be on the list).  This system can also let us say one reviewer from a given group and one review from another to merge, so I'll be happy to set that up but I need to know what the preference is.\r\n\r\nTo use it, you can link through to pullapprove to approve or reject, or you can use a github comment to get the same effect.  I adjusted the approval regex to hit the common items, but you will need to have a line that starts with one of:\r\n\r\n*  `:+1:` or `:thumbsup:` or the unicode equivalent thereto (:+1:)\r\n*  `:shipit:` (:shipit:)\r\n* Approved\r\n* I approve\r\n\r\nTo reject, it needs a line starting with \"Rejected\" currently.\r\n\r\nI would appreciate feedback and preferences from folks on how they would like this to work.  It's already enabled with a default non-yaml config so we can actually try it out on this PR.\r\n\r\nCC: @DavidPoliakoff, @davidbeckingsale, @jonesholger "},"comment":{"url":"https://api.github.com/repos/LLNL/RAJA/issues/comments/229483967","html_url":"https://github.com/LLNL/RAJA/pull/74#issuecomment-229483967","issue_url":"https://api.github.com/repos/LLNL/RAJA/issues/74","id":229483967,"user":{"login":"trws","id":660149,"avatar_url":"https://avatars.githubusercontent.com/u/660149?v=3","gravatar_id":"","url":"https://api.github.com/users/trws","html_url":"https://github.com/trws","followers_url":"https://api.github.com/users/trws/followers","following_url":"https://api.github.com/users/trws/following{/other_user}","gists_url":"https://api.github.com/users/trws/gists{/gist_id}","starred_url":"https://api.github.com/users/trws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trws/subscriptions","organizations_url":"https://api.github.com/users/trws/orgs","repos_url":"https://api.github.com/users/trws/repos","events_url":"https://api.github.com/users/trws/events{/privacy}","received_events_url":"https://api.github.com/users/trws/received_events","type":"User","site_admin":false},"created_at":"2016-06-29T20:48:57Z","updated_at":"2016-06-29T20:48:57Z","body":"Got it.  Updated to 1 and 2, seems to be giving what I'm after now.  Not \nsure why the reviewninja sigils are sticking around, I've removed that \nintegration, but it must be sticky on existing PRs or something.\n\nOn 29 Jun 2016, at 13:45, David Beckingsale wrote:\n\n> It counts twice. See #73\n>\n> We can probably just set the count of the \"everyone\" to 2 and it will \n> work as expected.\n>\n> ---\n> You are receiving this because you modified the open/close state.\n> Reply to this email directly or view it on GitHub:\n> https://github.com/LLNL/RAJA/pull/74#issuecomment-229483081\n\n\n"}}
{"actor":{"display_login":"trws"}}