{"action":"created","comment":{"url":"https://api.github.com/repos/apache/nifi/pulls/comments/90279351","pull_request_review_id":10800963,"id":90279351,"diff_hunk":"@@ -300,7 +307,7 @@ public static Schema createSchema(final ResultSet rs, String recordName, boolean\n                     // Check the precision of the BIGINT. Some databases allow arbitrary precision (> 19), but Avro won't handle that.\n                     // If the precision > 19 (or is negative), use a string for the type, otherwise use a long. The object(s) will be converted\n                     // to strings as necessary\n-                    int precision = meta.getPrecision(i);\n+                    int precision = dbAdapter.getSupportsMetaDataColumnGetPrecision()?meta.getPrecision(i):0;","path":"nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/util/JdbcCommon.java","position":61,"original_position":61,"commit_id":"b11b10029caeeccdfcf7f16fed4c0ab57e15ee72","original_commit_id":"b11b10029caeeccdfcf7f16fed4c0ab57e15ee72","user":{"login":"patricker","id":1015990,"avatar_url":"https://avatars.githubusercontent.com/u/1015990?v=3","gravatar_id":"","url":"https://api.github.com/users/patricker","html_url":"https://github.com/patricker","followers_url":"https://api.github.com/users/patricker/followers","following_url":"https://api.github.com/users/patricker/following{/other_user}","gists_url":"https://api.github.com/users/patricker/gists{/gist_id}","starred_url":"https://api.github.com/users/patricker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patricker/subscriptions","organizations_url":"https://api.github.com/users/patricker/orgs","repos_url":"https://api.github.com/users/patricker/repos","events_url":"https://api.github.com/users/patricker/events{/privacy}","received_events_url":"https://api.github.com/users/patricker/received_events","type":"User","site_admin":false},"body":"Probably `-1` would be a safer choice. If we can't retrieve precision, and especially since HIVE supports up to Decimal 38... we don't want to accidentally lose data or start throwing exceptions for overflows.","created_at":"2016-11-30T17:09:49Z","updated_at":"2016-11-30T17:09:49Z","html_url":"https://github.com/apache/nifi/pull/1281#discussion_r90279351","pull_request_url":"https://api.github.com/repos/apache/nifi/pulls/1281","_links":{"self":{"href":"https://api.github.com/repos/apache/nifi/pulls/comments/90279351"},"html":{"href":"https://github.com/apache/nifi/pull/1281#discussion_r90279351"},"pull_request":{"href":"https://api.github.com/repos/apache/nifi/pulls/1281"}}},"pull_request":{"url":"https://api.github.com/repos/apache/nifi/pulls/1281","id":95785304,"html_url":"https://github.com/apache/nifi/pull/1281","diff_url":"https://github.com/apache/nifi/pull/1281.diff","patch_url":"https://github.com/apache/nifi/pull/1281.patch","issue_url":"https://api.github.com/repos/apache/nifi/issues/1281","number":1281,"state":"open","locked":false,"title":"NIFI-3093 HIVE Support for QueryDatabaseTable","user":{"login":"patricker","id":1015990,"avatar_url":"https://avatars.githubusercontent.com/u/1015990?v=3","gravatar_id":"","url":"https://api.github.com/users/patricker","html_url":"https://github.com/patricker","followers_url":"https://api.github.com/users/patricker/followers","following_url":"https://api.github.com/users/patricker/following{/other_user}","gists_url":"https://api.github.com/users/patricker/gists{/gist_id}","starred_url":"https://api.github.com/users/patricker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patricker/subscriptions","organizations_url":"https://api.github.com/users/patricker/orgs","repos_url":"https://api.github.com/users/patricker/repos","events_url":"https://api.github.com/users/patricker/events{/privacy}","received_events_url":"https://api.github.com/users/patricker/received_events","type":"User","site_admin":false},"body":"This update adds HIVE support to `QueryDatabaseTable`.\r\n\r\nI included a few changes to `GenerateTableFetch`, but these were only for compatability with the new properties added to the DB Adapter interface. This does NOT add support to `GenerateTableFetch` for HIVE (as I don't think paging HIVE is possible).\r\n\r\nI'm expecting this will need a few tweaks, just let me know.\r\n\r\n### For all changes:\r\n- [x] Is there a JIRA ticket associated with this PR? Is it referenced \r\n     in the commit message?\r\n\r\n- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen \"-\" character.\r\n\r\n- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?\r\n\r\n- [x] Is your initial contribution a single, squashed commit?\r\n\r\n### For code changes:\r\n- [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?\r\n- [ ] Have you written or updated unit tests to verify your changes?\r\n- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? \r\n- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?\r\n- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?\r\n- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?\r\n\r\n### For documentation related changes:\r\n- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?\r\n\r\n","created_at":"2016-11-29T22:03:34Z","updated_at":"2016-11-30T17:09:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f62182c677fd0ed245a60ec250e539a1da9a35bf","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/nifi/pulls/1281/commits","review_comments_url":"https://api.github.com/repos/apache/nifi/pulls/1281/comments","review_comment_url":"https://api.github.com/repos/apache/nifi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/nifi/issues/1281/comments","statuses_url":"https://api.github.com/repos/apache/nifi/statuses/b11b10029caeeccdfcf7f16fed4c0ab57e15ee72","head":{"label":"patricker:NIFI-3093","ref":"NIFI-3093","sha":"b11b10029caeeccdfcf7f16fed4c0ab57e15ee72","user":{"login":"patricker","id":1015990,"avatar_url":"https://avatars.githubusercontent.com/u/1015990?v=3","gravatar_id":"","url":"https://api.github.com/users/patricker","html_url":"https://github.com/patricker","followers_url":"https://api.github.com/users/patricker/followers","following_url":"https://api.github.com/users/patricker/following{/other_user}","gists_url":"https://api.github.com/users/patricker/gists{/gist_id}","starred_url":"https://api.github.com/users/patricker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patricker/subscriptions","organizations_url":"https://api.github.com/users/patricker/orgs","repos_url":"https://api.github.com/users/patricker/repos","events_url":"https://api.github.com/users/patricker/events{/privacy}","received_events_url":"https://api.github.com/users/patricker/received_events","type":"User","site_admin":false},"repo":{"id":64414654,"name":"nifi","full_name":"patricker/nifi","owner":{"login":"patricker","id":1015990,"avatar_url":"https://avatars.githubusercontent.com/u/1015990?v=3","gravatar_id":"","url":"https://api.github.com/users/patricker","html_url":"https://github.com/patricker","followers_url":"https://api.github.com/users/patricker/followers","following_url":"https://api.github.com/users/patricker/following{/other_user}","gists_url":"https://api.github.com/users/patricker/gists{/gist_id}","starred_url":"https://api.github.com/users/patricker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patricker/subscriptions","organizations_url":"https://api.github.com/users/patricker/orgs","repos_url":"https://api.github.com/users/patricker/repos","events_url":"https://api.github.com/users/patricker/events{/privacy}","received_events_url":"https://api.github.com/users/patricker/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/patricker/nifi","description":"Mirror of Apache NiFi","fork":true,"url":"https://api.github.com/repos/patricker/nifi","forks_url":"https://api.github.com/repos/patricker/nifi/forks","keys_url":"https://api.github.com/repos/patricker/nifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/patricker/nifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/patricker/nifi/teams","hooks_url":"https://api.github.com/repos/patricker/nifi/hooks","issue_events_url":"https://api.github.com/repos/patricker/nifi/issues/events{/number}","events_url":"https://api.github.com/repos/patricker/nifi/events","assignees_url":"https://api.github.com/repos/patricker/nifi/assignees{/user}","branches_url":"https://api.github.com/repos/patricker/nifi/branches{/branch}","tags_url":"https://api.github.com/repos/patricker/nifi/tags","blobs_url":"https://api.github.com/repos/patricker/nifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/patricker/nifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/patricker/nifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/patricker/nifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/patricker/nifi/statuses/{sha}","languages_url":"https://api.github.com/repos/patricker/nifi/languages","stargazers_url":"https://api.github.com/repos/patricker/nifi/stargazers","contributors_url":"https://api.github.com/repos/patricker/nifi/contributors","subscribers_url":"https://api.github.com/repos/patricker/nifi/subscribers","subscription_url":"https://api.github.com/repos/patricker/nifi/subscription","commits_url":"https://api.github.com/repos/patricker/nifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/patricker/nifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/patricker/nifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/patricker/nifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/patricker/nifi/contents/{+path}","compare_url":"https://api.github.com/repos/patricker/nifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/patricker/nifi/merges","archive_url":"https://api.github.com/repos/patricker/nifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/patricker/nifi/downloads","issues_url":"https://api.github.com/repos/patricker/nifi/issues{/number}","pulls_url":"https://api.github.com/repos/patricker/nifi/pulls{/number}","milestones_url":"https://api.github.com/repos/patricker/nifi/milestones{/number}","notifications_url":"https://api.github.com/repos/patricker/nifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/patricker/nifi/labels{/name}","releases_url":"https://api.github.com/repos/patricker/nifi/releases{/id}","deployments_url":"https://api.github.com/repos/patricker/nifi/deployments","created_at":"2016-07-28T17:23:02Z","updated_at":"2016-07-28T17:23:16Z","pushed_at":"2016-11-30T15:11:12Z","git_url":"git://github.com/patricker/nifi.git","ssh_url":"git@github.com:patricker/nifi.git","clone_url":"https://github.com/patricker/nifi.git","svn_url":"https://github.com/patricker/nifi","homepage":"","size":72454,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"9d6ca6e1e60e604852cb3ad46eba6d58189b0864","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":27911088,"name":"nifi","full_name":"apache/nifi","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/nifi","description":"Mirror of Apache NiFi","fork":false,"url":"https://api.github.com/repos/apache/nifi","forks_url":"https://api.github.com/repos/apache/nifi/forks","keys_url":"https://api.github.com/repos/apache/nifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/nifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/nifi/teams","hooks_url":"https://api.github.com/repos/apache/nifi/hooks","issue_events_url":"https://api.github.com/repos/apache/nifi/issues/events{/number}","events_url":"https://api.github.com/repos/apache/nifi/events","assignees_url":"https://api.github.com/repos/apache/nifi/assignees{/user}","branches_url":"https://api.github.com/repos/apache/nifi/branches{/branch}","tags_url":"https://api.github.com/repos/apache/nifi/tags","blobs_url":"https://api.github.com/repos/apache/nifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/nifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/nifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/nifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/nifi/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/nifi/languages","stargazers_url":"https://api.github.com/repos/apache/nifi/stargazers","contributors_url":"https://api.github.com/repos/apache/nifi/contributors","subscribers_url":"https://api.github.com/repos/apache/nifi/subscribers","subscription_url":"https://api.github.com/repos/apache/nifi/subscription","commits_url":"https://api.github.com/repos/apache/nifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/nifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/nifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/nifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/nifi/contents/{+path}","compare_url":"https://api.github.com/repos/apache/nifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/nifi/merges","archive_url":"https://api.github.com/repos/apache/nifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/nifi/downloads","issues_url":"https://api.github.com/repos/apache/nifi/issues{/number}","pulls_url":"https://api.github.com/repos/apache/nifi/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/nifi/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/nifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/nifi/labels{/name}","releases_url":"https://api.github.com/repos/apache/nifi/releases{/id}","deployments_url":"https://api.github.com/repos/apache/nifi/deployments","created_at":"2014-12-12T08:00:05Z","updated_at":"2016-11-30T02:54:21Z","pushed_at":"2016-11-30T16:17:20Z","git_url":"git://github.com/apache/nifi.git","ssh_url":"git@github.com:apache/nifi.git","clone_url":"https://github.com/apache/nifi.git","svn_url":"https://github.com/apache/nifi","homepage":"","size":100908,"stargazers_count":404,"watchers_count":404,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":369,"mirror_url":"git://git.apache.org/nifi.git","open_issues_count":62,"forks":369,"open_issues":62,"watchers":404,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/nifi/pulls/1281"},"html":{"href":"https://github.com/apache/nifi/pull/1281"},"issue":{"href":"https://api.github.com/repos/apache/nifi/issues/1281"},"comments":{"href":"https://api.github.com/repos/apache/nifi/issues/1281/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/nifi/pulls/1281/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/nifi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/nifi/pulls/1281/commits"},"statuses":{"href":"https://api.github.com/repos/apache/nifi/statuses/b11b10029caeeccdfcf7f16fed4c0ab57e15ee72"}}}}
{"actor":{"display_login":"patricker"}}