{"action":"created","comment":{"url":"https://api.github.com/repos/google/openhtf/pulls/comments/60331470","id":60331470,"diff_hunk":"@@ -145,49 +141,29 @@ def _Discover(self):\n                                FLAGS.discovery_port,\n                                FLAGS.discovery_ttl)\n     for host, response in responses:\n+      port = None\n       try:\n         port = json.loads(response)[PING_RESPONSE_KEY]\n         self._Track(host, port)","path":"openhtf/io/frontend/__main__.py","position":122,"original_position":122,"commit_id":"fa0df841cb354e6d82c684b21a57653948b64293","original_commit_id":"fa0df841cb354e6d82c684b21a57653948b64293","user":{"login":"jettisonjoe","id":8150422,"avatar_url":"https://avatars.githubusercontent.com/u/8150422?v=3","gravatar_id":"","url":"https://api.github.com/users/jettisonjoe","html_url":"https://github.com/jettisonjoe","followers_url":"https://api.github.com/users/jettisonjoe/followers","following_url":"https://api.github.com/users/jettisonjoe/following{/other_user}","gists_url":"https://api.github.com/users/jettisonjoe/gists{/gist_id}","starred_url":"https://api.github.com/users/jettisonjoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jettisonjoe/subscriptions","organizations_url":"https://api.github.com/users/jettisonjoe/orgs","repos_url":"https://api.github.com/users/jettisonjoe/repos","events_url":"https://api.github.com/users/jettisonjoe/events{/privacy}","received_events_url":"https://api.github.com/users/jettisonjoe/received_events","type":"User","site_admin":false},"body":"Done.","created_at":"2016-04-19T23:48:59Z","updated_at":"2016-04-19T23:48:59Z","html_url":"https://github.com/google/openhtf/pull/195#discussion_r60331470","pull_request_url":"https://api.github.com/repos/google/openhtf/pulls/195","_links":{"self":{"href":"https://api.github.com/repos/google/openhtf/pulls/comments/60331470"},"html":{"href":"https://github.com/google/openhtf/pull/195#discussion_r60331470"},"pull_request":{"href":"https://api.github.com/repos/google/openhtf/pulls/195"}}},"pull_request":{"url":"https://api.github.com/repos/google/openhtf/pulls/195","id":64211822,"html_url":"https://github.com/google/openhtf/pull/195","diff_url":"https://github.com/google/openhtf/pull/195.diff","patch_url":"https://github.com/google/openhtf/pull/195.patch","issue_url":"https://api.github.com/repos/google/openhtf/issues/195","number":195,"state":"open","locked":false,"title":"Refactor multicast discovery mechanism.","user":{"login":"jettisonjoe","id":8150422,"avatar_url":"https://avatars.githubusercontent.com/u/8150422?v=3","gravatar_id":"","url":"https://api.github.com/users/jettisonjoe","html_url":"https://github.com/jettisonjoe","followers_url":"https://api.github.com/users/jettisonjoe/followers","following_url":"https://api.github.com/users/jettisonjoe/following{/other_user}","gists_url":"https://api.github.com/users/jettisonjoe/gists{/gist_id}","starred_url":"https://api.github.com/users/jettisonjoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jettisonjoe/subscriptions","organizations_url":"https://api.github.com/users/jettisonjoe/orgs","repos_url":"https://api.github.com/users/jettisonjoe/repos","events_url":"https://api.github.com/users/jettisonjoe/events{/privacy}","received_events_url":"https://api.github.com/users/jettisonjoe/received_events","type":"User","site_admin":false},"body":"This change moves the port binding side of multicast discovery to the frontend server, and the sender side to the framework instances. This results in slightly more network traffic, but enables multiple framework instances on a single host to all be discovered by a single frontend.\r\n\r\nAs a side note, this also makes frontend SIGINT response instantaneous, because the multicast listener is now a daemon thread, and the store itself is just an object.\r\n\r\nAlso addresses an (unfiled) bug where the entire contents of HTTP GET responses are sent as one long header.","created_at":"2016-03-25T21:52:48Z","updated_at":"2016-04-19T23:48:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"250585e920096746482b68252a4d79422a89db89","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/google/openhtf/pulls/195/commits","review_comments_url":"https://api.github.com/repos/google/openhtf/pulls/195/comments","review_comment_url":"https://api.github.com/repos/google/openhtf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/openhtf/issues/195/comments","statuses_url":"https://api.github.com/repos/google/openhtf/statuses/fa0df841cb354e6d82c684b21a57653948b64293","head":{"label":"jettisonjoe:master","ref":"master","sha":"fa0df841cb354e6d82c684b21a57653948b64293","user":{"login":"jettisonjoe","id":8150422,"avatar_url":"https://avatars.githubusercontent.com/u/8150422?v=3","gravatar_id":"","url":"https://api.github.com/users/jettisonjoe","html_url":"https://github.com/jettisonjoe","followers_url":"https://api.github.com/users/jettisonjoe/followers","following_url":"https://api.github.com/users/jettisonjoe/following{/other_user}","gists_url":"https://api.github.com/users/jettisonjoe/gists{/gist_id}","starred_url":"https://api.github.com/users/jettisonjoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jettisonjoe/subscriptions","organizations_url":"https://api.github.com/users/jettisonjoe/orgs","repos_url":"https://api.github.com/users/jettisonjoe/repos","events_url":"https://api.github.com/users/jettisonjoe/events{/privacy}","received_events_url":"https://api.github.com/users/jettisonjoe/received_events","type":"User","site_admin":false},"repo":{"id":41824189,"name":"openhtf","full_name":"jettisonjoe/openhtf","owner":{"login":"jettisonjoe","id":8150422,"avatar_url":"https://avatars.githubusercontent.com/u/8150422?v=3","gravatar_id":"","url":"https://api.github.com/users/jettisonjoe","html_url":"https://github.com/jettisonjoe","followers_url":"https://api.github.com/users/jettisonjoe/followers","following_url":"https://api.github.com/users/jettisonjoe/following{/other_user}","gists_url":"https://api.github.com/users/jettisonjoe/gists{/gist_id}","starred_url":"https://api.github.com/users/jettisonjoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jettisonjoe/subscriptions","organizations_url":"https://api.github.com/users/jettisonjoe/orgs","repos_url":"https://api.github.com/users/jettisonjoe/repos","events_url":"https://api.github.com/users/jettisonjoe/events{/privacy}","received_events_url":"https://api.github.com/users/jettisonjoe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jettisonjoe/openhtf","description":null,"fork":true,"url":"https://api.github.com/repos/jettisonjoe/openhtf","forks_url":"https://api.github.com/repos/jettisonjoe/openhtf/forks","keys_url":"https://api.github.com/repos/jettisonjoe/openhtf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jettisonjoe/openhtf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jettisonjoe/openhtf/teams","hooks_url":"https://api.github.com/repos/jettisonjoe/openhtf/hooks","issue_events_url":"https://api.github.com/repos/jettisonjoe/openhtf/issues/events{/number}","events_url":"https://api.github.com/repos/jettisonjoe/openhtf/events","assignees_url":"https://api.github.com/repos/jettisonjoe/openhtf/assignees{/user}","branches_url":"https://api.github.com/repos/jettisonjoe/openhtf/branches{/branch}","tags_url":"https://api.github.com/repos/jettisonjoe/openhtf/tags","blobs_url":"https://api.github.com/repos/jettisonjoe/openhtf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jettisonjoe/openhtf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jettisonjoe/openhtf/git/refs{/sha}","trees_url":"https://api.github.com/repos/jettisonjoe/openhtf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jettisonjoe/openhtf/statuses/{sha}","languages_url":"https://api.github.com/repos/jettisonjoe/openhtf/languages","stargazers_url":"https://api.github.com/repos/jettisonjoe/openhtf/stargazers","contributors_url":"https://api.github.com/repos/jettisonjoe/openhtf/contributors","subscribers_url":"https://api.github.com/repos/jettisonjoe/openhtf/subscribers","subscription_url":"https://api.github.com/repos/jettisonjoe/openhtf/subscription","commits_url":"https://api.github.com/repos/jettisonjoe/openhtf/commits{/sha}","git_commits_url":"https://api.github.com/repos/jettisonjoe/openhtf/git/commits{/sha}","comments_url":"https://api.github.com/repos/jettisonjoe/openhtf/comments{/number}","issue_comment_url":"https://api.github.com/repos/jettisonjoe/openhtf/issues/comments{/number}","contents_url":"https://api.github.com/repos/jettisonjoe/openhtf/contents/{+path}","compare_url":"https://api.github.com/repos/jettisonjoe/openhtf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jettisonjoe/openhtf/merges","archive_url":"https://api.github.com/repos/jettisonjoe/openhtf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jettisonjoe/openhtf/downloads","issues_url":"https://api.github.com/repos/jettisonjoe/openhtf/issues{/number}","pulls_url":"https://api.github.com/repos/jettisonjoe/openhtf/pulls{/number}","milestones_url":"https://api.github.com/repos/jettisonjoe/openhtf/milestones{/number}","notifications_url":"https://api.github.com/repos/jettisonjoe/openhtf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jettisonjoe/openhtf/labels{/name}","releases_url":"https://api.github.com/repos/jettisonjoe/openhtf/releases{/id}","deployments_url":"https://api.github.com/repos/jettisonjoe/openhtf/deployments","created_at":"2015-09-02T19:50:25Z","updated_at":"2016-01-12T23:54:07Z","pushed_at":"2016-04-19T23:11:45Z","git_url":"git://github.com/jettisonjoe/openhtf.git","ssh_url":"git@github.com:jettisonjoe/openhtf.git","clone_url":"https://github.com/jettisonjoe/openhtf.git","svn_url":"https://github.com/jettisonjoe/openhtf","homepage":null,"size":18612,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"8934c1d20a93d6879d37c9793caa57538de4b02e","user":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":41519483,"name":"openhtf","full_name":"google/openhtf","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/openhtf","description":null,"fork":false,"url":"https://api.github.com/repos/google/openhtf","forks_url":"https://api.github.com/repos/google/openhtf/forks","keys_url":"https://api.github.com/repos/google/openhtf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/openhtf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/openhtf/teams","hooks_url":"https://api.github.com/repos/google/openhtf/hooks","issue_events_url":"https://api.github.com/repos/google/openhtf/issues/events{/number}","events_url":"https://api.github.com/repos/google/openhtf/events","assignees_url":"https://api.github.com/repos/google/openhtf/assignees{/user}","branches_url":"https://api.github.com/repos/google/openhtf/branches{/branch}","tags_url":"https://api.github.com/repos/google/openhtf/tags","blobs_url":"https://api.github.com/repos/google/openhtf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/openhtf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/openhtf/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/openhtf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/openhtf/statuses/{sha}","languages_url":"https://api.github.com/repos/google/openhtf/languages","stargazers_url":"https://api.github.com/repos/google/openhtf/stargazers","contributors_url":"https://api.github.com/repos/google/openhtf/contributors","subscribers_url":"https://api.github.com/repos/google/openhtf/subscribers","subscription_url":"https://api.github.com/repos/google/openhtf/subscription","commits_url":"https://api.github.com/repos/google/openhtf/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/openhtf/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/openhtf/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/openhtf/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/openhtf/contents/{+path}","compare_url":"https://api.github.com/repos/google/openhtf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/openhtf/merges","archive_url":"https://api.github.com/repos/google/openhtf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/openhtf/downloads","issues_url":"https://api.github.com/repos/google/openhtf/issues{/number}","pulls_url":"https://api.github.com/repos/google/openhtf/pulls{/number}","milestones_url":"https://api.github.com/repos/google/openhtf/milestones{/number}","notifications_url":"https://api.github.com/repos/google/openhtf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/openhtf/labels{/name}","releases_url":"https://api.github.com/repos/google/openhtf/releases{/id}","deployments_url":"https://api.github.com/repos/google/openhtf/deployments","created_at":"2015-08-28T01:14:17Z","updated_at":"2016-04-16T04:16:27Z","pushed_at":"2016-04-19T23:05:32Z","git_url":"git://github.com/google/openhtf.git","ssh_url":"git@github.com:google/openhtf.git","clone_url":"https://github.com/google/openhtf.git","svn_url":"https://github.com/google/openhtf","homepage":null,"size":18695,"stargazers_count":21,"watchers_count":21,"language":"Python","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":73,"forks":17,"open_issues":73,"watchers":21,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/openhtf/pulls/195"},"html":{"href":"https://github.com/google/openhtf/pull/195"},"issue":{"href":"https://api.github.com/repos/google/openhtf/issues/195"},"comments":{"href":"https://api.github.com/repos/google/openhtf/issues/195/comments"},"review_comments":{"href":"https://api.github.com/repos/google/openhtf/pulls/195/comments"},"review_comment":{"href":"https://api.github.com/repos/google/openhtf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/openhtf/pulls/195/commits"},"statuses":{"href":"https://api.github.com/repos/google/openhtf/statuses/fa0df841cb354e6d82c684b21a57653948b64293"}}}}