{"action":"created","comment":{"url":"https://api.github.com/repos/angular/material/pulls/comments/77881324","id":77881324,"diff_hunk":"@@ -0,0 +1,44 @@\n+<div ng-controller=\"PanelGroupsCtrl as ctrl\" ng-cloak>\n+\n+  <md-toolbar class=\"md-accent\">\n+    <div class=\"md-toolbar-tools\">\n+      <md-button\n+        class=\"md-icon-button\"\n+        aria-label=\"Settings\"\n+        ng-click=\"ctrl.showMenu($event, 'settings', 'toolbar')\">","path":"src/components/panel/demoGroups/index.html","position":8,"original_position":8,"commit_id":"4e10a9083340aee6781b9a372298774d3dc2fd78","original_commit_id":"4e10a9083340aee6781b9a372298774d3dc2fd78","user":{"login":"ErinCoughlan","id":2660421,"avatar_url":"https://avatars.githubusercontent.com/u/2660421?v=3","gravatar_id":"","url":"https://api.github.com/users/ErinCoughlan","html_url":"https://github.com/ErinCoughlan","followers_url":"https://api.github.com/users/ErinCoughlan/followers","following_url":"https://api.github.com/users/ErinCoughlan/following{/other_user}","gists_url":"https://api.github.com/users/ErinCoughlan/gists{/gist_id}","starred_url":"https://api.github.com/users/ErinCoughlan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ErinCoughlan/subscriptions","organizations_url":"https://api.github.com/users/ErinCoughlan/orgs","repos_url":"https://api.github.com/users/ErinCoughlan/repos","events_url":"https://api.github.com/users/ErinCoughlan/events{/privacy}","received_events_url":"https://api.github.com/users/ErinCoughlan/received_events","type":"User","site_admin":false},"body":"Use constants from the controller instead of strings for 'settings', 'favorite', and 'more'. It's a better code example. (More robust, less likely for typos or errors.)\r\n\r\nAlso since all of these are \"toolbar\" groups, I'd expect a more common use case is to declare the group name directly in the open function rather then passing it in. I would think when a user calls open, it's mapped to one method that knows what group it should be.","created_at":"2016-09-07T18:46:30Z","updated_at":"2016-09-07T18:46:30Z","html_url":"https://github.com/angular/material/pull/9538#discussion_r77881324","pull_request_url":"https://api.github.com/repos/angular/material/pulls/9538","_links":{"self":{"href":"https://api.github.com/repos/angular/material/pulls/comments/77881324"},"html":{"href":"https://github.com/angular/material/pull/9538#discussion_r77881324"},"pull_request":{"href":"https://api.github.com/repos/angular/material/pulls/9538"}}},"pull_request":{"url":"https://api.github.com/repos/angular/material/pulls/9538","id":84230163,"html_url":"https://github.com/angular/material/pull/9538","diff_url":"https://github.com/angular/material/pull/9538.diff","patch_url":"https://github.com/angular/material/pull/9538.patch","issue_url":"https://api.github.com/repos/angular/material/issues/9538","number":9538,"state":"open","locked":false,"title":"feat(panel): Panel grouping","user":{"login":"bradrich","id":3429878,"avatar_url":"https://avatars.githubusercontent.com/u/3429878?v=3","gravatar_id":"","url":"https://api.github.com/users/bradrich","html_url":"https://github.com/bradrich","followers_url":"https://api.github.com/users/bradrich/followers","following_url":"https://api.github.com/users/bradrich/following{/other_user}","gists_url":"https://api.github.com/users/bradrich/gists{/gist_id}","starred_url":"https://api.github.com/users/bradrich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bradrich/subscriptions","organizations_url":"https://api.github.com/users/bradrich/orgs","repos_url":"https://api.github.com/users/bradrich/repos","events_url":"https://api.github.com/users/bradrich/events{/privacy}","received_events_url":"https://api.github.com/users/bradrich/received_events","type":"User","site_admin":false},"body":"Panels are now capable of being grouped together by any designation the user sees fit. Grouping allows the user to specify logic for a collection of panels. For instance, all popups in the header can be considered one group with a maximum of one popup open at a time. Dialogs within dialogs are another example of groups. This implementation prevents the panel from storing a ridiculous amount of data in memory or polluting the DOM with several panels. This helps performance and gives the user more flexibility about how to use panels.\r\n\r\nFixes #8971\r\n\r\nPing @ErinCoughlan","created_at":"2016-09-07T03:12:31Z","updated_at":"2016-09-07T18:46:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a0257fe5c5a97e0c3cda93a7c189ba067ca4c8a0","assignee":{"login":"ErinCoughlan","id":2660421,"avatar_url":"https://avatars.githubusercontent.com/u/2660421?v=3","gravatar_id":"","url":"https://api.github.com/users/ErinCoughlan","html_url":"https://github.com/ErinCoughlan","followers_url":"https://api.github.com/users/ErinCoughlan/followers","following_url":"https://api.github.com/users/ErinCoughlan/following{/other_user}","gists_url":"https://api.github.com/users/ErinCoughlan/gists{/gist_id}","starred_url":"https://api.github.com/users/ErinCoughlan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ErinCoughlan/subscriptions","organizations_url":"https://api.github.com/users/ErinCoughlan/orgs","repos_url":"https://api.github.com/users/ErinCoughlan/repos","events_url":"https://api.github.com/users/ErinCoughlan/events{/privacy}","received_events_url":"https://api.github.com/users/ErinCoughlan/received_events","type":"User","site_admin":false},"assignees":[{"login":"ErinCoughlan","id":2660421,"avatar_url":"https://avatars.githubusercontent.com/u/2660421?v=3","gravatar_id":"","url":"https://api.github.com/users/ErinCoughlan","html_url":"https://github.com/ErinCoughlan","followers_url":"https://api.github.com/users/ErinCoughlan/followers","following_url":"https://api.github.com/users/ErinCoughlan/following{/other_user}","gists_url":"https://api.github.com/users/ErinCoughlan/gists{/gist_id}","starred_url":"https://api.github.com/users/ErinCoughlan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ErinCoughlan/subscriptions","organizations_url":"https://api.github.com/users/ErinCoughlan/orgs","repos_url":"https://api.github.com/users/ErinCoughlan/repos","events_url":"https://api.github.com/users/ErinCoughlan/events{/privacy}","received_events_url":"https://api.github.com/users/ErinCoughlan/received_events","type":"User","site_admin":false},{"login":"crisbeto","id":4450522,"avatar_url":"https://avatars.githubusercontent.com/u/4450522?v=3","gravatar_id":"","url":"https://api.github.com/users/crisbeto","html_url":"https://github.com/crisbeto","followers_url":"https://api.github.com/users/crisbeto/followers","following_url":"https://api.github.com/users/crisbeto/following{/other_user}","gists_url":"https://api.github.com/users/crisbeto/gists{/gist_id}","starred_url":"https://api.github.com/users/crisbeto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crisbeto/subscriptions","organizations_url":"https://api.github.com/users/crisbeto/orgs","repos_url":"https://api.github.com/users/crisbeto/repos","events_url":"https://api.github.com/users/crisbeto/events{/privacy}","received_events_url":"https://api.github.com/users/crisbeto/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/angular/material/milestones/36","html_url":"https://github.com/angular/material/milestones/1.1.2","labels_url":"https://api.github.com/repos/angular/material/milestones/36/labels","id":1485958,"number":36,"title":"1.1.2","description":"","creator":{"login":"ThomasBurleson","id":210413,"avatar_url":"https://avatars.githubusercontent.com/u/210413?v=3","gravatar_id":"","url":"https://api.github.com/users/ThomasBurleson","html_url":"https://github.com/ThomasBurleson","followers_url":"https://api.github.com/users/ThomasBurleson/followers","following_url":"https://api.github.com/users/ThomasBurleson/following{/other_user}","gists_url":"https://api.github.com/users/ThomasBurleson/gists{/gist_id}","starred_url":"https://api.github.com/users/ThomasBurleson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThomasBurleson/subscriptions","organizations_url":"https://api.github.com/users/ThomasBurleson/orgs","repos_url":"https://api.github.com/users/ThomasBurleson/repos","events_url":"https://api.github.com/users/ThomasBurleson/events{/privacy}","received_events_url":"https://api.github.com/users/ThomasBurleson/received_events","type":"User","site_admin":false},"open_issues":54,"closed_issues":6,"state":"open","created_at":"2016-01-05T21:40:38Z","updated_at":"2016-09-07T17:57:51Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/angular/material/pulls/9538/commits","review_comments_url":"https://api.github.com/repos/angular/material/pulls/9538/comments","review_comment_url":"https://api.github.com/repos/angular/material/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/material/issues/9538/comments","statuses_url":"https://api.github.com/repos/angular/material/statuses/4e10a9083340aee6781b9a372298774d3dc2fd78","head":{"label":"bradrich:feat/panel-grouping","ref":"feat/panel-grouping","sha":"4e10a9083340aee6781b9a372298774d3dc2fd78","user":{"login":"bradrich","id":3429878,"avatar_url":"https://avatars.githubusercontent.com/u/3429878?v=3","gravatar_id":"","url":"https://api.github.com/users/bradrich","html_url":"https://github.com/bradrich","followers_url":"https://api.github.com/users/bradrich/followers","following_url":"https://api.github.com/users/bradrich/following{/other_user}","gists_url":"https://api.github.com/users/bradrich/gists{/gist_id}","starred_url":"https://api.github.com/users/bradrich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bradrich/subscriptions","organizations_url":"https://api.github.com/users/bradrich/orgs","repos_url":"https://api.github.com/users/bradrich/repos","events_url":"https://api.github.com/users/bradrich/events{/privacy}","received_events_url":"https://api.github.com/users/bradrich/received_events","type":"User","site_admin":false},"repo":{"id":61638631,"name":"material","full_name":"bradrich/material","owner":{"login":"bradrich","id":3429878,"avatar_url":"https://avatars.githubusercontent.com/u/3429878?v=3","gravatar_id":"","url":"https://api.github.com/users/bradrich","html_url":"https://github.com/bradrich","followers_url":"https://api.github.com/users/bradrich/followers","following_url":"https://api.github.com/users/bradrich/following{/other_user}","gists_url":"https://api.github.com/users/bradrich/gists{/gist_id}","starred_url":"https://api.github.com/users/bradrich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bradrich/subscriptions","organizations_url":"https://api.github.com/users/bradrich/orgs","repos_url":"https://api.github.com/users/bradrich/repos","events_url":"https://api.github.com/users/bradrich/events{/privacy}","received_events_url":"https://api.github.com/users/bradrich/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bradrich/material","description":"Material design for Angular","fork":true,"url":"https://api.github.com/repos/bradrich/material","forks_url":"https://api.github.com/repos/bradrich/material/forks","keys_url":"https://api.github.com/repos/bradrich/material/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bradrich/material/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bradrich/material/teams","hooks_url":"https://api.github.com/repos/bradrich/material/hooks","issue_events_url":"https://api.github.com/repos/bradrich/material/issues/events{/number}","events_url":"https://api.github.com/repos/bradrich/material/events","assignees_url":"https://api.github.com/repos/bradrich/material/assignees{/user}","branches_url":"https://api.github.com/repos/bradrich/material/branches{/branch}","tags_url":"https://api.github.com/repos/bradrich/material/tags","blobs_url":"https://api.github.com/repos/bradrich/material/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bradrich/material/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bradrich/material/git/refs{/sha}","trees_url":"https://api.github.com/repos/bradrich/material/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bradrich/material/statuses/{sha}","languages_url":"https://api.github.com/repos/bradrich/material/languages","stargazers_url":"https://api.github.com/repos/bradrich/material/stargazers","contributors_url":"https://api.github.com/repos/bradrich/material/contributors","subscribers_url":"https://api.github.com/repos/bradrich/material/subscribers","subscription_url":"https://api.github.com/repos/bradrich/material/subscription","commits_url":"https://api.github.com/repos/bradrich/material/commits{/sha}","git_commits_url":"https://api.github.com/repos/bradrich/material/git/commits{/sha}","comments_url":"https://api.github.com/repos/bradrich/material/comments{/number}","issue_comment_url":"https://api.github.com/repos/bradrich/material/issues/comments{/number}","contents_url":"https://api.github.com/repos/bradrich/material/contents/{+path}","compare_url":"https://api.github.com/repos/bradrich/material/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bradrich/material/merges","archive_url":"https://api.github.com/repos/bradrich/material/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bradrich/material/downloads","issues_url":"https://api.github.com/repos/bradrich/material/issues{/number}","pulls_url":"https://api.github.com/repos/bradrich/material/pulls{/number}","milestones_url":"https://api.github.com/repos/bradrich/material/milestones{/number}","notifications_url":"https://api.github.com/repos/bradrich/material/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bradrich/material/labels{/name}","releases_url":"https://api.github.com/repos/bradrich/material/releases{/id}","deployments_url":"https://api.github.com/repos/bradrich/material/deployments","created_at":"2016-06-21T14:04:28Z","updated_at":"2016-06-21T14:04:32Z","pushed_at":"2016-09-07T03:11:10Z","git_url":"git://github.com/bradrich/material.git","ssh_url":"git@github.com:bradrich/material.git","clone_url":"https://github.com/bradrich/material.git","svn_url":"https://github.com/bradrich/material","homepage":"https://material.angularjs.org/","size":44724,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"151378de4e2ce2d39a0a453fb2daea8c753dd8a2","user":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":21399598,"name":"material","full_name":"angular/material","owner":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/material","description":"Material design for Angular","fork":false,"url":"https://api.github.com/repos/angular/material","forks_url":"https://api.github.com/repos/angular/material/forks","keys_url":"https://api.github.com/repos/angular/material/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/material/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/material/teams","hooks_url":"https://api.github.com/repos/angular/material/hooks","issue_events_url":"https://api.github.com/repos/angular/material/issues/events{/number}","events_url":"https://api.github.com/repos/angular/material/events","assignees_url":"https://api.github.com/repos/angular/material/assignees{/user}","branches_url":"https://api.github.com/repos/angular/material/branches{/branch}","tags_url":"https://api.github.com/repos/angular/material/tags","blobs_url":"https://api.github.com/repos/angular/material/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/material/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/material/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/material/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/material/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/material/languages","stargazers_url":"https://api.github.com/repos/angular/material/stargazers","contributors_url":"https://api.github.com/repos/angular/material/contributors","subscribers_url":"https://api.github.com/repos/angular/material/subscribers","subscription_url":"https://api.github.com/repos/angular/material/subscription","commits_url":"https://api.github.com/repos/angular/material/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/material/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/material/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/material/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/material/contents/{+path}","compare_url":"https://api.github.com/repos/angular/material/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/material/merges","archive_url":"https://api.github.com/repos/angular/material/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/material/downloads","issues_url":"https://api.github.com/repos/angular/material/issues{/number}","pulls_url":"https://api.github.com/repos/angular/material/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/material/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/material/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/material/labels{/name}","releases_url":"https://api.github.com/repos/angular/material/releases{/id}","deployments_url":"https://api.github.com/repos/angular/material/deployments","created_at":"2014-07-01T19:20:06Z","updated_at":"2016-09-07T16:31:06Z","pushed_at":"2016-09-07T03:12:31Z","git_url":"git://github.com/angular/material.git","ssh_url":"git@github.com:angular/material.git","clone_url":"https://github.com/angular/material.git","svn_url":"https://github.com/angular/material","homepage":"https://material.angularjs.org/","size":81815,"stargazers_count":14385,"watchers_count":14385,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3033,"mirror_url":null,"open_issues_count":313,"forks":3033,"open_issues":313,"watchers":14385,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/material/pulls/9538"},"html":{"href":"https://github.com/angular/material/pull/9538"},"issue":{"href":"https://api.github.com/repos/angular/material/issues/9538"},"comments":{"href":"https://api.github.com/repos/angular/material/issues/9538/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/material/pulls/9538/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/material/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/material/pulls/9538/commits"},"statuses":{"href":"https://api.github.com/repos/angular/material/statuses/4e10a9083340aee6781b9a372298774d3dc2fd78"}}}}
{"actor":{"display_login":"ErinCoughlan"}}