{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/82101398","pull_request_review_id":3032111,"id":82101398,"diff_hunk":"@@ -0,0 +1,46 @@\n+// Licensed to the .NET Foundation under one or more agreements.\n+// The .NET Foundation licenses this file to you under the MIT license.\n+// See the LICENSE file in the project root for more information.\n+\n+namespace System.Security.Cryptography\n+{\n+    /// <summary>\n+    ///     Wrapper for public key material passed between parties during Diffie-Hellman key material generation\n+    /// </summary>\n+    [Serializable]\n+    public abstract class ECDiffieHellmanPublicKey : IDisposable\n+    {\n+        private byte[] _keyBlob;\n+\n+        protected ECDiffieHellmanPublicKey(byte[] keyBlob)\n+        {\n+            if (keyBlob == null)\n+            {\n+                throw new ArgumentNullException(nameof(keyBlob));\n+            }\n+\n+            _keyBlob = keyBlob.Clone() as byte[];\n+        }\n+\n+        public void Dispose()\n+        {\n+            Dispose(true);\n+        }\n+\n+        protected virtual void Dispose(bool disposing)\n+        {\n+            return;","path":"src/System.Security.Cryptography.Algorithms/src/System/Security/Cryptography/ECDiffieHellmanPublicKey.cs","position":32,"original_position":32,"commit_id":"78ac751327529b8719bf963ffe35650b2dd740dc","original_commit_id":"78ac751327529b8719bf963ffe35650b2dd740dc","user":{"login":"justinvp","id":710598,"avatar_url":"https://avatars.githubusercontent.com/u/710598?v=3","gravatar_id":"","url":"https://api.github.com/users/justinvp","html_url":"https://github.com/justinvp","followers_url":"https://api.github.com/users/justinvp/followers","following_url":"https://api.github.com/users/justinvp/following{/other_user}","gists_url":"https://api.github.com/users/justinvp/gists{/gist_id}","starred_url":"https://api.github.com/users/justinvp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinvp/subscriptions","organizations_url":"https://api.github.com/users/justinvp/orgs","repos_url":"https://api.github.com/users/justinvp/repos","events_url":"https://api.github.com/users/justinvp/events{/privacy}","received_events_url":"https://api.github.com/users/justinvp/received_events","type":"User","site_admin":false},"body":"Nit: the `return` isn't necessary","created_at":"2016-10-06T01:00:15Z","updated_at":"2016-10-06T01:00:15Z","html_url":"https://github.com/dotnet/corefx/pull/12410#discussion_r82101398","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/12410","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/82101398"},"html":{"href":"https://github.com/dotnet/corefx/pull/12410#discussion_r82101398"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/12410"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/12410","id":88182179,"html_url":"https://github.com/dotnet/corefx/pull/12410","diff_url":"https://github.com/dotnet/corefx/pull/12410.diff","patch_url":"https://github.com/dotnet/corefx/pull/12410.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/12410","number":12410,"state":"open","locked":false,"title":"S.S.C.Algorithms and .Encoding ns2.0 misc additions","user":{"login":"steveharter","id":6986755,"avatar_url":"https://avatars.githubusercontent.com/u/6986755?v=3","gravatar_id":"","url":"https://api.github.com/users/steveharter","html_url":"https://github.com/steveharter","followers_url":"https://api.github.com/users/steveharter/followers","following_url":"https://api.github.com/users/steveharter/following{/other_user}","gists_url":"https://api.github.com/users/steveharter/gists{/gist_id}","starred_url":"https://api.github.com/users/steveharter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steveharter/subscriptions","organizations_url":"https://api.github.com/users/steveharter/orgs","repos_url":"https://api.github.com/users/steveharter/repos","events_url":"https://api.github.com/users/steveharter/events{/privacy}","received_events_url":"https://api.github.com/users/steveharter/received_events","type":"User","site_admin":false},"body":"A collection of trivial changes for ns2.0 contract work.\r\n\r\n@morganbr please review (@bartonjs OOF)\r\n\r\nS.S.C.Algorithms:\r\n#11121 M:System.Security.Cryptography.HMACSHA1.#ctor(System.Byte[],System.Boolean)\r\n#12363 Port System.Security.Cryptography.ECDiffieHellmanPublicKey\r\n\r\nS.S.C.Encoding:\r\n#12365 Port System.Security.Cryptography.Oid#ctor\r\n#12325 Make ICollection members non-explicit on AsnEncodedDataCollection and OidCollection","created_at":"2016-10-06T00:41:26Z","updated_at":"2016-10-06T01:00:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8563beee963bc10a985bfed6eca12810c538db0f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/12410/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/12410/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/12410/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/78ac751327529b8719bf963ffe35650b2dd740dc","head":{"label":"steveharter:Ns20Misc","ref":"Ns20Misc","sha":"78ac751327529b8719bf963ffe35650b2dd740dc","user":{"login":"steveharter","id":6986755,"avatar_url":"https://avatars.githubusercontent.com/u/6986755?v=3","gravatar_id":"","url":"https://api.github.com/users/steveharter","html_url":"https://github.com/steveharter","followers_url":"https://api.github.com/users/steveharter/followers","following_url":"https://api.github.com/users/steveharter/following{/other_user}","gists_url":"https://api.github.com/users/steveharter/gists{/gist_id}","starred_url":"https://api.github.com/users/steveharter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steveharter/subscriptions","organizations_url":"https://api.github.com/users/steveharter/orgs","repos_url":"https://api.github.com/users/steveharter/repos","events_url":"https://api.github.com/users/steveharter/events{/privacy}","received_events_url":"https://api.github.com/users/steveharter/received_events","type":"User","site_admin":false},"repo":{"id":39029448,"name":"dotnet_corefx","full_name":"steveharter/dotnet_corefx","owner":{"login":"steveharter","id":6986755,"avatar_url":"https://avatars.githubusercontent.com/u/6986755?v=3","gravatar_id":"","url":"https://api.github.com/users/steveharter","html_url":"https://github.com/steveharter","followers_url":"https://api.github.com/users/steveharter/followers","following_url":"https://api.github.com/users/steveharter/following{/other_user}","gists_url":"https://api.github.com/users/steveharter/gists{/gist_id}","starred_url":"https://api.github.com/users/steveharter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steveharter/subscriptions","organizations_url":"https://api.github.com/users/steveharter/orgs","repos_url":"https://api.github.com/users/steveharter/repos","events_url":"https://api.github.com/users/steveharter/events{/privacy}","received_events_url":"https://api.github.com/users/steveharter/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/steveharter/dotnet_corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":true,"url":"https://api.github.com/repos/steveharter/dotnet_corefx","forks_url":"https://api.github.com/repos/steveharter/dotnet_corefx/forks","keys_url":"https://api.github.com/repos/steveharter/dotnet_corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/steveharter/dotnet_corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/steveharter/dotnet_corefx/teams","hooks_url":"https://api.github.com/repos/steveharter/dotnet_corefx/hooks","issue_events_url":"https://api.github.com/repos/steveharter/dotnet_corefx/issues/events{/number}","events_url":"https://api.github.com/repos/steveharter/dotnet_corefx/events","assignees_url":"https://api.github.com/repos/steveharter/dotnet_corefx/assignees{/user}","branches_url":"https://api.github.com/repos/steveharter/dotnet_corefx/branches{/branch}","tags_url":"https://api.github.com/repos/steveharter/dotnet_corefx/tags","blobs_url":"https://api.github.com/repos/steveharter/dotnet_corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/steveharter/dotnet_corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/steveharter/dotnet_corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/steveharter/dotnet_corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/steveharter/dotnet_corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/steveharter/dotnet_corefx/languages","stargazers_url":"https://api.github.com/repos/steveharter/dotnet_corefx/stargazers","contributors_url":"https://api.github.com/repos/steveharter/dotnet_corefx/contributors","subscribers_url":"https://api.github.com/repos/steveharter/dotnet_corefx/subscribers","subscription_url":"https://api.github.com/repos/steveharter/dotnet_corefx/subscription","commits_url":"https://api.github.com/repos/steveharter/dotnet_corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/steveharter/dotnet_corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/steveharter/dotnet_corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/steveharter/dotnet_corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/steveharter/dotnet_corefx/contents/{+path}","compare_url":"https://api.github.com/repos/steveharter/dotnet_corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/steveharter/dotnet_corefx/merges","archive_url":"https://api.github.com/repos/steveharter/dotnet_corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/steveharter/dotnet_corefx/downloads","issues_url":"https://api.github.com/repos/steveharter/dotnet_corefx/issues{/number}","pulls_url":"https://api.github.com/repos/steveharter/dotnet_corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/steveharter/dotnet_corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/steveharter/dotnet_corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/steveharter/dotnet_corefx/labels{/name}","releases_url":"https://api.github.com/repos/steveharter/dotnet_corefx/releases{/id}","deployments_url":"https://api.github.com/repos/steveharter/dotnet_corefx/deployments","created_at":"2015-07-13T18:20:31Z","updated_at":"2016-01-13T22:53:29Z","pushed_at":"2016-10-06T00:56:36Z","git_url":"git://github.com/steveharter/dotnet_corefx.git","ssh_url":"git@github.com:steveharter/dotnet_corefx.git","clone_url":"https://github.com/steveharter/dotnet_corefx.git","svn_url":"https://github.com/steveharter/dotnet_corefx","homepage":"http://dotnet.github.io/core/","size":101270,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"8ab0f6fefc11cb307ac7718b21fee52938bcb88d","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/corefx/deployments","created_at":"2014-11-06T23:42:48Z","updated_at":"2016-10-05T12:12:49Z","pushed_at":"2016-10-06T01:00:08Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"https://docs.microsoft.com/dotnet/","size":147984,"stargazers_count":10605,"watchers_count":10605,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2656,"mirror_url":null,"open_issues_count":1542,"forks":2656,"open_issues":1542,"watchers":10605,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/12410"},"html":{"href":"https://github.com/dotnet/corefx/pull/12410"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/12410"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/12410/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/12410/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/12410/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/78ac751327529b8719bf963ffe35650b2dd740dc"}}}}
{"actor":{"display_login":"justinvp"}}