{"action":"created","comment":{"url":"https://api.github.com/repos/quattor/CAF/pulls/comments/89691587","pull_request_review_id":10231829,"id":89691587,"diff_hunk":"@@ -0,0 +1,31 @@\n+package filetools;\n+\n+use strict;\n+use warnings;\n+\n+use parent qw(Exporter);\n+use File::Basename qw(dirname);\n+use File::Path qw(mkpath);\n+\n+our @EXPORT_OK = qw(readfile makefile);\n+\n+# cannot use mocked filewriter\n+sub makefile\n+{\n+    my $fn = shift;\n+    my $dir = dirname($fn);\n+    mkpath $dir if ! -d $dir;\n+    open(FH, \">$fn\");\n+    print FH (shift || \"ok\");\n+    close(FH);","path":"src/test/perl/modules/filetools.pm","position":20,"original_position":20,"commit_id":"1756d4d63e3793cbcf1121427feadc724b02433c","original_commit_id":"1756d4d63e3793cbcf1121427feadc724b02433c","user":{"login":"ned21","id":278425,"avatar_url":"https://avatars.githubusercontent.com/u/278425?v=3","gravatar_id":"","url":"https://api.github.com/users/ned21","html_url":"https://github.com/ned21","followers_url":"https://api.github.com/users/ned21/followers","following_url":"https://api.github.com/users/ned21/following{/other_user}","gists_url":"https://api.github.com/users/ned21/gists{/gist_id}","starred_url":"https://api.github.com/users/ned21/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ned21/subscriptions","organizations_url":"https://api.github.com/users/ned21/orgs","repos_url":"https://api.github.com/users/ned21/repos","events_url":"https://api.github.com/users/ned21/events{/privacy}","received_events_url":"https://api.github.com/users/ned21/received_events","type":"User","site_admin":false},"body":"Neither open() nor close() do any error handling which is generally bad, although given this is a unit test helper function, perhaps it's not bad in this specific case? ","created_at":"2016-11-27T14:50:24Z","updated_at":"2016-11-27T14:50:53Z","html_url":"https://github.com/quattor/CAF/pull/202#discussion_r89691587","pull_request_url":"https://api.github.com/repos/quattor/CAF/pulls/202","_links":{"self":{"href":"https://api.github.com/repos/quattor/CAF/pulls/comments/89691587"},"html":{"href":"https://github.com/quattor/CAF/pull/202#discussion_r89691587"},"pull_request":{"href":"https://api.github.com/repos/quattor/CAF/pulls/202"}}},"pull_request":{"url":"https://api.github.com/repos/quattor/CAF/pulls/202","id":95379431,"html_url":"https://github.com/quattor/CAF/pull/202","diff_url":"https://github.com/quattor/CAF/pull/202.diff","patch_url":"https://github.com/quattor/CAF/pull/202.patch","issue_url":"https://api.github.com/repos/quattor/CAF/issues/202","number":202,"state":"open","locked":false,"title":"FileWriter: use atomic write","user":{"login":"stdweird","id":1517606,"avatar_url":"https://avatars.githubusercontent.com/u/1517606?v=3","gravatar_id":"","url":"https://api.github.com/users/stdweird","html_url":"https://github.com/stdweird","followers_url":"https://api.github.com/users/stdweird/followers","following_url":"https://api.github.com/users/stdweird/following{/other_user}","gists_url":"https://api.github.com/users/stdweird/gists{/gist_id}","starred_url":"https://api.github.com/users/stdweird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stdweird/subscriptions","organizations_url":"https://api.github.com/users/stdweird/orgs","repos_url":"https://api.github.com/users/stdweird/repos","events_url":"https://api.github.com/users/stdweird/events{/privacy}","received_events_url":"https://api.github.com/users/stdweird/received_events","type":"User","site_admin":false},"body":"Fixes #148\r\nAlso fixes #189 \r\n\r\n`File::AtomicWrite` requires 0.18, rpm can be build using `cpanspec -b --packager quattor File::AtomicWrite --force`","created_at":"2016-11-26T18:46:24Z","updated_at":"2016-11-27T14:50:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6607a7760785fe3f18a36ba0a3f99c6d767a3daa","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/quattor/CAF/milestones/14","html_url":"https://github.com/quattor/CAF/milestones/16.12","labels_url":"https://api.github.com/repos/quattor/CAF/milestones/14/labels","id":2052443,"number":14,"title":"16.12","description":null,"creator":{"login":"jrha","id":323309,"avatar_url":"https://avatars.githubusercontent.com/u/323309?v=3","gravatar_id":"","url":"https://api.github.com/users/jrha","html_url":"https://github.com/jrha","followers_url":"https://api.github.com/users/jrha/followers","following_url":"https://api.github.com/users/jrha/following{/other_user}","gists_url":"https://api.github.com/users/jrha/gists{/gist_id}","starred_url":"https://api.github.com/users/jrha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrha/subscriptions","organizations_url":"https://api.github.com/users/jrha/orgs","repos_url":"https://api.github.com/users/jrha/repos","events_url":"https://api.github.com/users/jrha/events{/privacy}","received_events_url":"https://api.github.com/users/jrha/received_events","type":"User","site_admin":false},"open_issues":8,"closed_issues":0,"state":"open","created_at":"2016-10-06T14:21:50Z","updated_at":"2016-11-26T18:46:24Z","due_on":"2016-12-31T00:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/quattor/CAF/pulls/202/commits","review_comments_url":"https://api.github.com/repos/quattor/CAF/pulls/202/comments","review_comment_url":"https://api.github.com/repos/quattor/CAF/pulls/comments{/number}","comments_url":"https://api.github.com/repos/quattor/CAF/issues/202/comments","statuses_url":"https://api.github.com/repos/quattor/CAF/statuses/1756d4d63e3793cbcf1121427feadc724b02433c","head":{"label":"stdweird:record_diff","ref":"record_diff","sha":"1756d4d63e3793cbcf1121427feadc724b02433c","user":{"login":"stdweird","id":1517606,"avatar_url":"https://avatars.githubusercontent.com/u/1517606?v=3","gravatar_id":"","url":"https://api.github.com/users/stdweird","html_url":"https://github.com/stdweird","followers_url":"https://api.github.com/users/stdweird/followers","following_url":"https://api.github.com/users/stdweird/following{/other_user}","gists_url":"https://api.github.com/users/stdweird/gists{/gist_id}","starred_url":"https://api.github.com/users/stdweird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stdweird/subscriptions","organizations_url":"https://api.github.com/users/stdweird/orgs","repos_url":"https://api.github.com/users/stdweird/repos","events_url":"https://api.github.com/users/stdweird/events{/privacy}","received_events_url":"https://api.github.com/users/stdweird/received_events","type":"User","site_admin":false},"repo":{"id":17901500,"name":"CAF","full_name":"stdweird/CAF","owner":{"login":"stdweird","id":1517606,"avatar_url":"https://avatars.githubusercontent.com/u/1517606?v=3","gravatar_id":"","url":"https://api.github.com/users/stdweird","html_url":"https://github.com/stdweird","followers_url":"https://api.github.com/users/stdweird/followers","following_url":"https://api.github.com/users/stdweird/following{/other_user}","gists_url":"https://api.github.com/users/stdweird/gists{/gist_id}","starred_url":"https://api.github.com/users/stdweird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stdweird/subscriptions","organizations_url":"https://api.github.com/users/stdweird/orgs","repos_url":"https://api.github.com/users/stdweird/repos","events_url":"https://api.github.com/users/stdweird/events{/privacy}","received_events_url":"https://api.github.com/users/stdweird/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stdweird/CAF","description":"Perl Common Application Framework","fork":true,"url":"https://api.github.com/repos/stdweird/CAF","forks_url":"https://api.github.com/repos/stdweird/CAF/forks","keys_url":"https://api.github.com/repos/stdweird/CAF/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stdweird/CAF/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stdweird/CAF/teams","hooks_url":"https://api.github.com/repos/stdweird/CAF/hooks","issue_events_url":"https://api.github.com/repos/stdweird/CAF/issues/events{/number}","events_url":"https://api.github.com/repos/stdweird/CAF/events","assignees_url":"https://api.github.com/repos/stdweird/CAF/assignees{/user}","branches_url":"https://api.github.com/repos/stdweird/CAF/branches{/branch}","tags_url":"https://api.github.com/repos/stdweird/CAF/tags","blobs_url":"https://api.github.com/repos/stdweird/CAF/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stdweird/CAF/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stdweird/CAF/git/refs{/sha}","trees_url":"https://api.github.com/repos/stdweird/CAF/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stdweird/CAF/statuses/{sha}","languages_url":"https://api.github.com/repos/stdweird/CAF/languages","stargazers_url":"https://api.github.com/repos/stdweird/CAF/stargazers","contributors_url":"https://api.github.com/repos/stdweird/CAF/contributors","subscribers_url":"https://api.github.com/repos/stdweird/CAF/subscribers","subscription_url":"https://api.github.com/repos/stdweird/CAF/subscription","commits_url":"https://api.github.com/repos/stdweird/CAF/commits{/sha}","git_commits_url":"https://api.github.com/repos/stdweird/CAF/git/commits{/sha}","comments_url":"https://api.github.com/repos/stdweird/CAF/comments{/number}","issue_comment_url":"https://api.github.com/repos/stdweird/CAF/issues/comments{/number}","contents_url":"https://api.github.com/repos/stdweird/CAF/contents/{+path}","compare_url":"https://api.github.com/repos/stdweird/CAF/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stdweird/CAF/merges","archive_url":"https://api.github.com/repos/stdweird/CAF/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stdweird/CAF/downloads","issues_url":"https://api.github.com/repos/stdweird/CAF/issues{/number}","pulls_url":"https://api.github.com/repos/stdweird/CAF/pulls{/number}","milestones_url":"https://api.github.com/repos/stdweird/CAF/milestones{/number}","notifications_url":"https://api.github.com/repos/stdweird/CAF/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stdweird/CAF/labels{/name}","releases_url":"https://api.github.com/repos/stdweird/CAF/releases{/id}","deployments_url":"https://api.github.com/repos/stdweird/CAF/deployments","created_at":"2014-03-19T11:17:52Z","updated_at":"2014-07-31T06:42:46Z","pushed_at":"2016-11-26T18:43:42Z","git_url":"git://github.com/stdweird/CAF.git","ssh_url":"git@github.com:stdweird/CAF.git","clone_url":"https://github.com/stdweird/CAF.git","svn_url":"https://github.com/stdweird/CAF","homepage":"www.quattor.org","size":836,"stargazers_count":0,"watchers_count":0,"language":"Perl","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"quattor:master","ref":"master","sha":"53518817277e639264340653e3b7a84a1d5a7678","user":{"login":"quattor","id":1557169,"avatar_url":"https://avatars.githubusercontent.com/u/1557169?v=3","gravatar_id":"","url":"https://api.github.com/users/quattor","html_url":"https://github.com/quattor","followers_url":"https://api.github.com/users/quattor/followers","following_url":"https://api.github.com/users/quattor/following{/other_user}","gists_url":"https://api.github.com/users/quattor/gists{/gist_id}","starred_url":"https://api.github.com/users/quattor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quattor/subscriptions","organizations_url":"https://api.github.com/users/quattor/orgs","repos_url":"https://api.github.com/users/quattor/repos","events_url":"https://api.github.com/users/quattor/events{/privacy}","received_events_url":"https://api.github.com/users/quattor/received_events","type":"Organization","site_admin":false},"repo":{"id":3835363,"name":"CAF","full_name":"quattor/CAF","owner":{"login":"quattor","id":1557169,"avatar_url":"https://avatars.githubusercontent.com/u/1557169?v=3","gravatar_id":"","url":"https://api.github.com/users/quattor","html_url":"https://github.com/quattor","followers_url":"https://api.github.com/users/quattor/followers","following_url":"https://api.github.com/users/quattor/following{/other_user}","gists_url":"https://api.github.com/users/quattor/gists{/gist_id}","starred_url":"https://api.github.com/users/quattor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quattor/subscriptions","organizations_url":"https://api.github.com/users/quattor/orgs","repos_url":"https://api.github.com/users/quattor/repos","events_url":"https://api.github.com/users/quattor/events{/privacy}","received_events_url":"https://api.github.com/users/quattor/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/quattor/CAF","description":"Perl Common Application Framework","fork":false,"url":"https://api.github.com/repos/quattor/CAF","forks_url":"https://api.github.com/repos/quattor/CAF/forks","keys_url":"https://api.github.com/repos/quattor/CAF/keys{/key_id}","collaborators_url":"https://api.github.com/repos/quattor/CAF/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/quattor/CAF/teams","hooks_url":"https://api.github.com/repos/quattor/CAF/hooks","issue_events_url":"https://api.github.com/repos/quattor/CAF/issues/events{/number}","events_url":"https://api.github.com/repos/quattor/CAF/events","assignees_url":"https://api.github.com/repos/quattor/CAF/assignees{/user}","branches_url":"https://api.github.com/repos/quattor/CAF/branches{/branch}","tags_url":"https://api.github.com/repos/quattor/CAF/tags","blobs_url":"https://api.github.com/repos/quattor/CAF/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/quattor/CAF/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/quattor/CAF/git/refs{/sha}","trees_url":"https://api.github.com/repos/quattor/CAF/git/trees{/sha}","statuses_url":"https://api.github.com/repos/quattor/CAF/statuses/{sha}","languages_url":"https://api.github.com/repos/quattor/CAF/languages","stargazers_url":"https://api.github.com/repos/quattor/CAF/stargazers","contributors_url":"https://api.github.com/repos/quattor/CAF/contributors","subscribers_url":"https://api.github.com/repos/quattor/CAF/subscribers","subscription_url":"https://api.github.com/repos/quattor/CAF/subscription","commits_url":"https://api.github.com/repos/quattor/CAF/commits{/sha}","git_commits_url":"https://api.github.com/repos/quattor/CAF/git/commits{/sha}","comments_url":"https://api.github.com/repos/quattor/CAF/comments{/number}","issue_comment_url":"https://api.github.com/repos/quattor/CAF/issues/comments{/number}","contents_url":"https://api.github.com/repos/quattor/CAF/contents/{+path}","compare_url":"https://api.github.com/repos/quattor/CAF/compare/{base}...{head}","merges_url":"https://api.github.com/repos/quattor/CAF/merges","archive_url":"https://api.github.com/repos/quattor/CAF/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/quattor/CAF/downloads","issues_url":"https://api.github.com/repos/quattor/CAF/issues{/number}","pulls_url":"https://api.github.com/repos/quattor/CAF/pulls{/number}","milestones_url":"https://api.github.com/repos/quattor/CAF/milestones{/number}","notifications_url":"https://api.github.com/repos/quattor/CAF/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/quattor/CAF/labels{/name}","releases_url":"https://api.github.com/repos/quattor/CAF/releases{/id}","deployments_url":"https://api.github.com/repos/quattor/CAF/deployments","created_at":"2012-03-26T17:26:06Z","updated_at":"2016-10-24T10:43:28Z","pushed_at":"2016-11-26T18:46:25Z","git_url":"git://github.com/quattor/CAF.git","ssh_url":"git@github.com:quattor/CAF.git","clone_url":"https://github.com/quattor/CAF.git","svn_url":"https://github.com/quattor/CAF","homepage":"www.quattor.org","size":1171,"stargazers_count":4,"watchers_count":4,"language":"Perl","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":31,"forks":11,"open_issues":31,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/quattor/CAF/pulls/202"},"html":{"href":"https://github.com/quattor/CAF/pull/202"},"issue":{"href":"https://api.github.com/repos/quattor/CAF/issues/202"},"comments":{"href":"https://api.github.com/repos/quattor/CAF/issues/202/comments"},"review_comments":{"href":"https://api.github.com/repos/quattor/CAF/pulls/202/comments"},"review_comment":{"href":"https://api.github.com/repos/quattor/CAF/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/quattor/CAF/pulls/202/commits"},"statuses":{"href":"https://api.github.com/repos/quattor/CAF/statuses/1756d4d63e3793cbcf1121427feadc724b02433c"}}}}
{"actor":{"display_login":"ned21"}}