{"action":"created","issue":{"url":"https://api.github.com/repos/frctl/mandelbrot/issues/32","repository_url":"https://api.github.com/repos/frctl/mandelbrot","labels_url":"https://api.github.com/repos/frctl/mandelbrot/issues/32/labels{/name}","comments_url":"https://api.github.com/repos/frctl/mandelbrot/issues/32/comments","events_url":"https://api.github.com/repos/frctl/mandelbrot/issues/32/events","html_url":"https://github.com/frctl/mandelbrot/pull/32","id":167744646,"number":32,"title":"Theme updates to support v1.0 feature additions","user":{"login":"paulrobertlloyd","id":813383,"avatar_url":"https://avatars.githubusercontent.com/u/813383?v=3","gravatar_id":"","url":"https://api.github.com/users/paulrobertlloyd","html_url":"https://github.com/paulrobertlloyd","followers_url":"https://api.github.com/users/paulrobertlloyd/followers","following_url":"https://api.github.com/users/paulrobertlloyd/following{/other_user}","gists_url":"https://api.github.com/users/paulrobertlloyd/gists{/gist_id}","starred_url":"https://api.github.com/users/paulrobertlloyd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulrobertlloyd/subscriptions","organizations_url":"https://api.github.com/users/paulrobertlloyd/orgs","repos_url":"https://api.github.com/users/paulrobertlloyd/repos","events_url":"https://api.github.com/users/paulrobertlloyd/events{/privacy}","received_events_url":"https://api.github.com/users/paulrobertlloyd/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-07-27T00:47:46Z","updated_at":"2016-07-27T00:53:28Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/frctl/mandelbrot/pulls/32","html_url":"https://github.com/frctl/mandelbrot/pull/32","diff_url":"https://github.com/frctl/mandelbrot/pull/32.diff","patch_url":"https://github.com/frctl/mandelbrot/pull/32.patch"},"body":"Reviewing the Mandelbrot theme in light of the feature additions made since my last set of updates. Changes include:\r\n\r\n* Deleted deprecated (and unused) icons, some found in the assets folder, and a few duplicates found in the views folder.\r\n* Reviewed CSS to ensure code style is consistent i.e. use typographic and i18n mixins, (r)ems instead of px, new lines between rules etc.\r\n* Tweaked the design of the new asset and info (`.Meta`) views. No great amount of testing, but this should fix #24 (was the `white-space: nowrap` rule trying to fix another issue…?)\r\n* Slightly tweaked the design of error messages.\r\n* Replaced the open in new window icon with the previous version, which to my mind, is more universally understood.\r\n* …and potentially controversial (!): removed icons from the tabs (fixing #22 with a hammer!). Upon reflection, I’m not sure any of those icons add any value (especially those which are _super_ abstract). Reminded of this post from GDS: https://gds.blog.gov.uk/2013/06/18/retiring-our-icons/\r\n\r\nYou might want to run this against some of your installs to check I haven’t broken anything. In a later pull, I’d like to:\r\n\r\n* Review `.AssetList` styles (you’ll need to show me where this appears).\r\n* …and maybe revert to using the default browser `<select>`, with some light styling. Not sure if select2 brings much to the table, but perhaps you have some thoughts about what the resource menu will need to support in the future.\r\n\r\n![screen shot 2016-07-27 at 01 45 27](https://cloud.githubusercontent.com/assets/813383/17160277/dabdf0b8-539b-11e6-94af-bb7a2da7075b.png)"},"comment":{"url":"https://api.github.com/repos/frctl/mandelbrot/issues/comments/235450583","html_url":"https://github.com/frctl/mandelbrot/pull/32#issuecomment-235450583","issue_url":"https://api.github.com/repos/frctl/mandelbrot/issues/32","id":235450583,"user":{"login":"paulrobertlloyd","id":813383,"avatar_url":"https://avatars.githubusercontent.com/u/813383?v=3","gravatar_id":"","url":"https://api.github.com/users/paulrobertlloyd","html_url":"https://github.com/paulrobertlloyd","followers_url":"https://api.github.com/users/paulrobertlloyd/followers","following_url":"https://api.github.com/users/paulrobertlloyd/following{/other_user}","gists_url":"https://api.github.com/users/paulrobertlloyd/gists{/gist_id}","starred_url":"https://api.github.com/users/paulrobertlloyd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulrobertlloyd/subscriptions","organizations_url":"https://api.github.com/users/paulrobertlloyd/orgs","repos_url":"https://api.github.com/users/paulrobertlloyd/repos","events_url":"https://api.github.com/users/paulrobertlloyd/events{/privacy}","received_events_url":"https://api.github.com/users/paulrobertlloyd/received_events","type":"User","site_admin":false},"created_at":"2016-07-27T00:53:28Z","updated_at":"2016-07-27T00:53:28Z","body":"Oh, and we need to talk about the logo… 😉"}}
{"actor":{"display_login":"paulrobertlloyd"}}