{"action":"created","comment":{"url":"https://api.github.com/repos/pulp/pulp/pulls/comments/56867888","id":56867888,"diff_hunk":"@@ -95,16 +95,15 @@ def download_failed(self, report):\n         :param report: The download report for this request.\n         :type  report: nectar.report.DownloadReport\n         \"\"\"\n-        error_report = report.error_report.copy()\n-        error_report['url'] = report.url\n-        logger.info(_('Download of %(url)s failed: HTTP %(response_code)s '\n-                      '%(response_msg)s' % error_report))","path":"streamer/pulp/streamer/server.py","position":14,"original_position":14,"commit_id":"74bd56aa725159716f336279227135bab1720226","original_commit_id":"74bd56aa725159716f336279227135bab1720226","user":{"login":"jeremycline","id":1977525,"avatar_url":"https://avatars.githubusercontent.com/u/1977525?v=3","gravatar_id":"","url":"https://api.github.com/users/jeremycline","html_url":"https://github.com/jeremycline","followers_url":"https://api.github.com/users/jeremycline/followers","following_url":"https://api.github.com/users/jeremycline/following{/other_user}","gists_url":"https://api.github.com/users/jeremycline/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremycline/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremycline/subscriptions","organizations_url":"https://api.github.com/users/jeremycline/orgs","repos_url":"https://api.github.com/users/jeremycline/repos","events_url":"https://api.github.com/users/jeremycline/events{/privacy}","received_events_url":"https://api.github.com/users/jeremycline/received_events","type":"User","site_admin":false},"body":"I thought about keeping it, but did some manual testing and realized that Nectar will log pretty much the same thing (https://github.com/pulp/nectar/blob/master/nectar/downloaders/threaded.py#L225-L226) if it's an HTTP status that isn't 200, and urllib3 logs connection-related problems.","created_at":"2016-03-21T18:03:10Z","updated_at":"2016-03-21T18:03:10Z","html_url":"https://github.com/pulp/pulp/pull/2485#discussion_r56867888","pull_request_url":"https://api.github.com/repos/pulp/pulp/pulls/2485","_links":{"self":{"href":"https://api.github.com/repos/pulp/pulp/pulls/comments/56867888"},"html":{"href":"https://github.com/pulp/pulp/pull/2485#discussion_r56867888"},"pull_request":{"href":"https://api.github.com/repos/pulp/pulp/pulls/2485"}}},"pull_request":{"url":"https://api.github.com/repos/pulp/pulp/pulls/2485","id":62814445,"html_url":"https://github.com/pulp/pulp/pull/2485","diff_url":"https://github.com/pulp/pulp/pull/2485.diff","patch_url":"https://github.com/pulp/pulp/pull/2485.patch","issue_url":"https://api.github.com/repos/pulp/pulp/issues/2485","number":2485,"state":"open","locked":false,"title":"Ensure a proper HTTP status code in the streamer on failure","user":{"login":"jeremycline","id":1977525,"avatar_url":"https://avatars.githubusercontent.com/u/1977525?v=3","gravatar_id":"","url":"https://api.github.com/users/jeremycline","html_url":"https://github.com/jeremycline","followers_url":"https://api.github.com/users/jeremycline/followers","following_url":"https://api.github.com/users/jeremycline/following{/other_user}","gists_url":"https://api.github.com/users/jeremycline/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremycline/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremycline/subscriptions","organizations_url":"https://api.github.com/users/jeremycline/orgs","repos_url":"https://api.github.com/users/jeremycline/repos","events_url":"https://api.github.com/users/jeremycline/events{/privacy}","received_events_url":"https://api.github.com/users/jeremycline/received_events","type":"User","site_admin":false},"body":"If a non-HTTP error occurs in Nectar the streamer would fail to return a\r\nreasonable status code. An example of this is if the domain name is\r\nunresolvable or the host is not accepting connections. This resulted in\r\nan HTTP 200 from the streamer. It is now a HTTP 503.\r\n\r\ncloses #1734","created_at":"2016-03-14T20:45:58Z","updated_at":"2016-03-21T18:03:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d4fcfdfa503d64b2f70674ba9fd8e42b9a6f2a89","assignee":{"login":"jeremycline","id":1977525,"avatar_url":"https://avatars.githubusercontent.com/u/1977525?v=3","gravatar_id":"","url":"https://api.github.com/users/jeremycline","html_url":"https://github.com/jeremycline","followers_url":"https://api.github.com/users/jeremycline/followers","following_url":"https://api.github.com/users/jeremycline/following{/other_user}","gists_url":"https://api.github.com/users/jeremycline/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremycline/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremycline/subscriptions","organizations_url":"https://api.github.com/users/jeremycline/orgs","repos_url":"https://api.github.com/users/jeremycline/repos","events_url":"https://api.github.com/users/jeremycline/events{/privacy}","received_events_url":"https://api.github.com/users/jeremycline/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/pulp/pulp/pulls/2485/commits","review_comments_url":"https://api.github.com/repos/pulp/pulp/pulls/2485/comments","review_comment_url":"https://api.github.com/repos/pulp/pulp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pulp/pulp/issues/2485/comments","statuses_url":"https://api.github.com/repos/pulp/pulp/statuses/74bd56aa725159716f336279227135bab1720226","head":{"label":"jeremycline:streamer-traceback","ref":"streamer-traceback","sha":"74bd56aa725159716f336279227135bab1720226","user":{"login":"jeremycline","id":1977525,"avatar_url":"https://avatars.githubusercontent.com/u/1977525?v=3","gravatar_id":"","url":"https://api.github.com/users/jeremycline","html_url":"https://github.com/jeremycline","followers_url":"https://api.github.com/users/jeremycline/followers","following_url":"https://api.github.com/users/jeremycline/following{/other_user}","gists_url":"https://api.github.com/users/jeremycline/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremycline/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremycline/subscriptions","organizations_url":"https://api.github.com/users/jeremycline/orgs","repos_url":"https://api.github.com/users/jeremycline/repos","events_url":"https://api.github.com/users/jeremycline/events{/privacy}","received_events_url":"https://api.github.com/users/jeremycline/received_events","type":"User","site_admin":false},"repo":{"id":24958984,"name":"pulp","full_name":"jeremycline/pulp","owner":{"login":"jeremycline","id":1977525,"avatar_url":"https://avatars.githubusercontent.com/u/1977525?v=3","gravatar_id":"","url":"https://api.github.com/users/jeremycline","html_url":"https://github.com/jeremycline","followers_url":"https://api.github.com/users/jeremycline/followers","following_url":"https://api.github.com/users/jeremycline/following{/other_user}","gists_url":"https://api.github.com/users/jeremycline/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremycline/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremycline/subscriptions","organizations_url":"https://api.github.com/users/jeremycline/orgs","repos_url":"https://api.github.com/users/jeremycline/repos","events_url":"https://api.github.com/users/jeremycline/events{/privacy}","received_events_url":"https://api.github.com/users/jeremycline/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jeremycline/pulp","description":"Repository for Pulp platform code, including the server and base admin and consumer clients","fork":true,"url":"https://api.github.com/repos/jeremycline/pulp","forks_url":"https://api.github.com/repos/jeremycline/pulp/forks","keys_url":"https://api.github.com/repos/jeremycline/pulp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jeremycline/pulp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jeremycline/pulp/teams","hooks_url":"https://api.github.com/repos/jeremycline/pulp/hooks","issue_events_url":"https://api.github.com/repos/jeremycline/pulp/issues/events{/number}","events_url":"https://api.github.com/repos/jeremycline/pulp/events","assignees_url":"https://api.github.com/repos/jeremycline/pulp/assignees{/user}","branches_url":"https://api.github.com/repos/jeremycline/pulp/branches{/branch}","tags_url":"https://api.github.com/repos/jeremycline/pulp/tags","blobs_url":"https://api.github.com/repos/jeremycline/pulp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jeremycline/pulp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jeremycline/pulp/git/refs{/sha}","trees_url":"https://api.github.com/repos/jeremycline/pulp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jeremycline/pulp/statuses/{sha}","languages_url":"https://api.github.com/repos/jeremycline/pulp/languages","stargazers_url":"https://api.github.com/repos/jeremycline/pulp/stargazers","contributors_url":"https://api.github.com/repos/jeremycline/pulp/contributors","subscribers_url":"https://api.github.com/repos/jeremycline/pulp/subscribers","subscription_url":"https://api.github.com/repos/jeremycline/pulp/subscription","commits_url":"https://api.github.com/repos/jeremycline/pulp/commits{/sha}","git_commits_url":"https://api.github.com/repos/jeremycline/pulp/git/commits{/sha}","comments_url":"https://api.github.com/repos/jeremycline/pulp/comments{/number}","issue_comment_url":"https://api.github.com/repos/jeremycline/pulp/issues/comments{/number}","contents_url":"https://api.github.com/repos/jeremycline/pulp/contents/{+path}","compare_url":"https://api.github.com/repos/jeremycline/pulp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jeremycline/pulp/merges","archive_url":"https://api.github.com/repos/jeremycline/pulp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jeremycline/pulp/downloads","issues_url":"https://api.github.com/repos/jeremycline/pulp/issues{/number}","pulls_url":"https://api.github.com/repos/jeremycline/pulp/pulls{/number}","milestones_url":"https://api.github.com/repos/jeremycline/pulp/milestones{/number}","notifications_url":"https://api.github.com/repos/jeremycline/pulp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jeremycline/pulp/labels{/name}","releases_url":"https://api.github.com/repos/jeremycline/pulp/releases{/id}","deployments_url":"https://api.github.com/repos/jeremycline/pulp/deployments","created_at":"2014-10-08T20:18:50Z","updated_at":"2015-01-15T14:25:50Z","pushed_at":"2016-03-21T17:47:41Z","git_url":"git://github.com/jeremycline/pulp.git","ssh_url":"git@github.com:jeremycline/pulp.git","clone_url":"https://github.com/jeremycline/pulp.git","svn_url":"https://github.com/jeremycline/pulp","homepage":"","size":91127,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pulp:master","ref":"master","sha":"90ba7fd0512b262e39983c25513cd61610a576d7","user":{"login":"pulp","id":2103606,"avatar_url":"https://avatars.githubusercontent.com/u/2103606?v=3","gravatar_id":"","url":"https://api.github.com/users/pulp","html_url":"https://github.com/pulp","followers_url":"https://api.github.com/users/pulp/followers","following_url":"https://api.github.com/users/pulp/following{/other_user}","gists_url":"https://api.github.com/users/pulp/gists{/gist_id}","starred_url":"https://api.github.com/users/pulp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pulp/subscriptions","organizations_url":"https://api.github.com/users/pulp/orgs","repos_url":"https://api.github.com/users/pulp/repos","events_url":"https://api.github.com/users/pulp/events{/privacy}","received_events_url":"https://api.github.com/users/pulp/received_events","type":"Organization","site_admin":false},"repo":{"id":5314652,"name":"pulp","full_name":"pulp/pulp","owner":{"login":"pulp","id":2103606,"avatar_url":"https://avatars.githubusercontent.com/u/2103606?v=3","gravatar_id":"","url":"https://api.github.com/users/pulp","html_url":"https://github.com/pulp","followers_url":"https://api.github.com/users/pulp/followers","following_url":"https://api.github.com/users/pulp/following{/other_user}","gists_url":"https://api.github.com/users/pulp/gists{/gist_id}","starred_url":"https://api.github.com/users/pulp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pulp/subscriptions","organizations_url":"https://api.github.com/users/pulp/orgs","repos_url":"https://api.github.com/users/pulp/repos","events_url":"https://api.github.com/users/pulp/events{/privacy}","received_events_url":"https://api.github.com/users/pulp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pulp/pulp","description":"Repository for Pulp platform code, including the server and base admin and consumer clients","fork":false,"url":"https://api.github.com/repos/pulp/pulp","forks_url":"https://api.github.com/repos/pulp/pulp/forks","keys_url":"https://api.github.com/repos/pulp/pulp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pulp/pulp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pulp/pulp/teams","hooks_url":"https://api.github.com/repos/pulp/pulp/hooks","issue_events_url":"https://api.github.com/repos/pulp/pulp/issues/events{/number}","events_url":"https://api.github.com/repos/pulp/pulp/events","assignees_url":"https://api.github.com/repos/pulp/pulp/assignees{/user}","branches_url":"https://api.github.com/repos/pulp/pulp/branches{/branch}","tags_url":"https://api.github.com/repos/pulp/pulp/tags","blobs_url":"https://api.github.com/repos/pulp/pulp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pulp/pulp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pulp/pulp/git/refs{/sha}","trees_url":"https://api.github.com/repos/pulp/pulp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pulp/pulp/statuses/{sha}","languages_url":"https://api.github.com/repos/pulp/pulp/languages","stargazers_url":"https://api.github.com/repos/pulp/pulp/stargazers","contributors_url":"https://api.github.com/repos/pulp/pulp/contributors","subscribers_url":"https://api.github.com/repos/pulp/pulp/subscribers","subscription_url":"https://api.github.com/repos/pulp/pulp/subscription","commits_url":"https://api.github.com/repos/pulp/pulp/commits{/sha}","git_commits_url":"https://api.github.com/repos/pulp/pulp/git/commits{/sha}","comments_url":"https://api.github.com/repos/pulp/pulp/comments{/number}","issue_comment_url":"https://api.github.com/repos/pulp/pulp/issues/comments{/number}","contents_url":"https://api.github.com/repos/pulp/pulp/contents/{+path}","compare_url":"https://api.github.com/repos/pulp/pulp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pulp/pulp/merges","archive_url":"https://api.github.com/repos/pulp/pulp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pulp/pulp/downloads","issues_url":"https://api.github.com/repos/pulp/pulp/issues{/number}","pulls_url":"https://api.github.com/repos/pulp/pulp/pulls{/number}","milestones_url":"https://api.github.com/repos/pulp/pulp/milestones{/number}","notifications_url":"https://api.github.com/repos/pulp/pulp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pulp/pulp/labels{/name}","releases_url":"https://api.github.com/repos/pulp/pulp/releases{/id}","deployments_url":"https://api.github.com/repos/pulp/pulp/deployments","created_at":"2012-08-06T13:49:20Z","updated_at":"2016-03-21T00:29:36Z","pushed_at":"2016-03-21T17:48:01Z","git_url":"git://github.com/pulp/pulp.git","ssh_url":"git@github.com:pulp/pulp.git","clone_url":"https://github.com/pulp/pulp.git","svn_url":"https://github.com/pulp/pulp","homepage":"","size":102719,"stargazers_count":264,"watchers_count":264,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":99,"mirror_url":null,"open_issues_count":13,"forks":99,"open_issues":13,"watchers":264,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pulp/pulp/pulls/2485"},"html":{"href":"https://github.com/pulp/pulp/pull/2485"},"issue":{"href":"https://api.github.com/repos/pulp/pulp/issues/2485"},"comments":{"href":"https://api.github.com/repos/pulp/pulp/issues/2485/comments"},"review_comments":{"href":"https://api.github.com/repos/pulp/pulp/pulls/2485/comments"},"review_comment":{"href":"https://api.github.com/repos/pulp/pulp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pulp/pulp/pulls/2485/commits"},"statuses":{"href":"https://api.github.com/repos/pulp/pulp/statuses/74bd56aa725159716f336279227135bab1720226"}}}}