{"action":"created","comment":{"url":"https://api.github.com/repos/rackerlabs/blueflood/pulls/comments/65943443","id":65943443,"diff_hunk":"@@ -45,48 +39,6 @@\n \n public class IntegrationTestBase {\n \n-    public static class AstyanaxTester extends AstyanaxIO {","path":"blueflood-core/src/integration-test/java/com/rackspacecloud/blueflood/io/IntegrationTestBase.java","position":23,"original_position":23,"commit_id":"b3e26653a5e634eff4ea1937fd322a14831d1c79","original_commit_id":"b3e26653a5e634eff4ea1937fd322a14831d1c79","user":{"login":"shintasmith","id":3640870,"avatar_url":"https://avatars.githubusercontent.com/u/3640870?v=3","gravatar_id":"","url":"https://api.github.com/users/shintasmith","html_url":"https://github.com/shintasmith","followers_url":"https://api.github.com/users/shintasmith/followers","following_url":"https://api.github.com/users/shintasmith/following{/other_user}","gists_url":"https://api.github.com/users/shintasmith/gists{/gist_id}","starred_url":"https://api.github.com/users/shintasmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shintasmith/subscriptions","organizations_url":"https://api.github.com/users/shintasmith/orgs","repos_url":"https://api.github.com/users/shintasmith/repos","events_url":"https://api.github.com/users/shintasmith/events{/privacy}","received_events_url":"https://api.github.com/users/shintasmith/received_events","type":"User","site_admin":false},"body":"The logic in this class were moved to AstyanaxCassandraUtilsIO.java.","created_at":"2016-06-06T18:32:54Z","updated_at":"2016-06-06T18:32:54Z","html_url":"https://github.com/rackerlabs/blueflood/pull/699#discussion_r65943443","pull_request_url":"https://api.github.com/repos/rackerlabs/blueflood/pulls/699","_links":{"self":{"href":"https://api.github.com/repos/rackerlabs/blueflood/pulls/comments/65943443"},"html":{"href":"https://github.com/rackerlabs/blueflood/pull/699#discussion_r65943443"},"pull_request":{"href":"https://api.github.com/repos/rackerlabs/blueflood/pulls/699"}}},"pull_request":{"url":"https://api.github.com/repos/rackerlabs/blueflood/pulls/699","id":72755410,"html_url":"https://github.com/rackerlabs/blueflood/pull/699","diff_url":"https://github.com/rackerlabs/blueflood/pull/699.diff","patch_url":"https://github.com/rackerlabs/blueflood/pull/699.patch","issue_url":"https://api.github.com/repos/rackerlabs/blueflood/issues/699","number":699,"state":"open","locked":false,"title":"Wire datastax","user":{"login":"shintasmith","id":3640870,"avatar_url":"https://avatars.githubusercontent.com/u/3640870?v=3","gravatar_id":"","url":"https://api.github.com/users/shintasmith","html_url":"https://github.com/shintasmith","followers_url":"https://api.github.com/users/shintasmith/followers","following_url":"https://api.github.com/users/shintasmith/following{/other_user}","gists_url":"https://api.github.com/users/shintasmith/gists{/gist_id}","starred_url":"https://api.github.com/users/shintasmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shintasmith/subscriptions","organizations_url":"https://api.github.com/users/shintasmith/orgs","repos_url":"https://api.github.com/users/shintasmith/repos","events_url":"https://api.github.com/users/shintasmith/events{/privacy}","received_events_url":"https://api.github.com/users/shintasmith/received_events","type":"User","site_admin":false},"body":"This PR replaces direct calls to Astyanax classes with wrapper classes that knows when to switch driver from Astyanax to Datastax, based on the configuration: ```CASSANDRA_DRIVER```.\r\n\r\nThe majority of the services classes (those outside the io package) should now be using the wrapper classes, mainly:\r\n* DBasicMetricsRW and ABasicMetricsRW for basic metrics\r\n* DPreaggregatedMetricsRW and APreaggregatedMetricsRW for preaggregated metrics\r\n\r\nobtained via call to ```IOContainer.fromConfig().getXXXX()```\r\n\r\nServices classes are to use the above classes polymorphicly via AbstractMetricsRW or MetricsRW.\r\n\r\nWith this PR, we are now executing our Integration tests (when run from ```mvn verify```) using Datastax driver, except for those who are specifically testing Astyanax driver classes.\r\n\r\nFrom IntelliJ, you will have to specify ```-DCASSANDRA_DRIVER=datastax``` in order to activate the Datastax driver, until we change the default value of this property in CoreConfig to datastax from what is currently astyanax.\r\n\r\n","created_at":"2016-06-06T18:29:50Z","updated_at":"2016-06-06T18:32:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"513b28b56502ad9764183431fb6290e0fe8bff0c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rackerlabs/blueflood/pulls/699/commits","review_comments_url":"https://api.github.com/repos/rackerlabs/blueflood/pulls/699/comments","review_comment_url":"https://api.github.com/repos/rackerlabs/blueflood/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rackerlabs/blueflood/issues/699/comments","statuses_url":"https://api.github.com/repos/rackerlabs/blueflood/statuses/b3e26653a5e634eff4ea1937fd322a14831d1c79","head":{"label":"shintasmith:wire_datastax","ref":"wire_datastax","sha":"b3e26653a5e634eff4ea1937fd322a14831d1c79","user":{"login":"shintasmith","id":3640870,"avatar_url":"https://avatars.githubusercontent.com/u/3640870?v=3","gravatar_id":"","url":"https://api.github.com/users/shintasmith","html_url":"https://github.com/shintasmith","followers_url":"https://api.github.com/users/shintasmith/followers","following_url":"https://api.github.com/users/shintasmith/following{/other_user}","gists_url":"https://api.github.com/users/shintasmith/gists{/gist_id}","starred_url":"https://api.github.com/users/shintasmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shintasmith/subscriptions","organizations_url":"https://api.github.com/users/shintasmith/orgs","repos_url":"https://api.github.com/users/shintasmith/repos","events_url":"https://api.github.com/users/shintasmith/events{/privacy}","received_events_url":"https://api.github.com/users/shintasmith/received_events","type":"User","site_admin":false},"repo":{"id":45861100,"name":"blueflood","full_name":"shintasmith/blueflood","owner":{"login":"shintasmith","id":3640870,"avatar_url":"https://avatars.githubusercontent.com/u/3640870?v=3","gravatar_id":"","url":"https://api.github.com/users/shintasmith","html_url":"https://github.com/shintasmith","followers_url":"https://api.github.com/users/shintasmith/followers","following_url":"https://api.github.com/users/shintasmith/following{/other_user}","gists_url":"https://api.github.com/users/shintasmith/gists{/gist_id}","starred_url":"https://api.github.com/users/shintasmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shintasmith/subscriptions","organizations_url":"https://api.github.com/users/shintasmith/orgs","repos_url":"https://api.github.com/users/shintasmith/repos","events_url":"https://api.github.com/users/shintasmith/events{/privacy}","received_events_url":"https://api.github.com/users/shintasmith/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shintasmith/blueflood","description":"A distributed system designed to ingest and process time series data","fork":true,"url":"https://api.github.com/repos/shintasmith/blueflood","forks_url":"https://api.github.com/repos/shintasmith/blueflood/forks","keys_url":"https://api.github.com/repos/shintasmith/blueflood/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shintasmith/blueflood/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shintasmith/blueflood/teams","hooks_url":"https://api.github.com/repos/shintasmith/blueflood/hooks","issue_events_url":"https://api.github.com/repos/shintasmith/blueflood/issues/events{/number}","events_url":"https://api.github.com/repos/shintasmith/blueflood/events","assignees_url":"https://api.github.com/repos/shintasmith/blueflood/assignees{/user}","branches_url":"https://api.github.com/repos/shintasmith/blueflood/branches{/branch}","tags_url":"https://api.github.com/repos/shintasmith/blueflood/tags","blobs_url":"https://api.github.com/repos/shintasmith/blueflood/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shintasmith/blueflood/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shintasmith/blueflood/git/refs{/sha}","trees_url":"https://api.github.com/repos/shintasmith/blueflood/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shintasmith/blueflood/statuses/{sha}","languages_url":"https://api.github.com/repos/shintasmith/blueflood/languages","stargazers_url":"https://api.github.com/repos/shintasmith/blueflood/stargazers","contributors_url":"https://api.github.com/repos/shintasmith/blueflood/contributors","subscribers_url":"https://api.github.com/repos/shintasmith/blueflood/subscribers","subscription_url":"https://api.github.com/repos/shintasmith/blueflood/subscription","commits_url":"https://api.github.com/repos/shintasmith/blueflood/commits{/sha}","git_commits_url":"https://api.github.com/repos/shintasmith/blueflood/git/commits{/sha}","comments_url":"https://api.github.com/repos/shintasmith/blueflood/comments{/number}","issue_comment_url":"https://api.github.com/repos/shintasmith/blueflood/issues/comments{/number}","contents_url":"https://api.github.com/repos/shintasmith/blueflood/contents/{+path}","compare_url":"https://api.github.com/repos/shintasmith/blueflood/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shintasmith/blueflood/merges","archive_url":"https://api.github.com/repos/shintasmith/blueflood/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shintasmith/blueflood/downloads","issues_url":"https://api.github.com/repos/shintasmith/blueflood/issues{/number}","pulls_url":"https://api.github.com/repos/shintasmith/blueflood/pulls{/number}","milestones_url":"https://api.github.com/repos/shintasmith/blueflood/milestones{/number}","notifications_url":"https://api.github.com/repos/shintasmith/blueflood/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shintasmith/blueflood/labels{/name}","releases_url":"https://api.github.com/repos/shintasmith/blueflood/releases{/id}","deployments_url":"https://api.github.com/repos/shintasmith/blueflood/deployments","created_at":"2015-11-09T19:22:42Z","updated_at":"2016-01-12T19:55:23Z","pushed_at":"2016-06-06T18:15:13Z","git_url":"git://github.com/shintasmith/blueflood.git","ssh_url":"git@github.com:shintasmith/blueflood.git","clone_url":"https://github.com/shintasmith/blueflood.git","svn_url":"https://github.com/shintasmith/blueflood","homepage":"http://www.blueflood.io","size":10143,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rackerlabs:master","ref":"master","sha":"3c4c1ccab2256c70560d89cf1000820120f74363","user":{"login":"rackerlabs","id":84293,"avatar_url":"https://avatars.githubusercontent.com/u/84293?v=3","gravatar_id":"","url":"https://api.github.com/users/rackerlabs","html_url":"https://github.com/rackerlabs","followers_url":"https://api.github.com/users/rackerlabs/followers","following_url":"https://api.github.com/users/rackerlabs/following{/other_user}","gists_url":"https://api.github.com/users/rackerlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/rackerlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rackerlabs/subscriptions","organizations_url":"https://api.github.com/users/rackerlabs/orgs","repos_url":"https://api.github.com/users/rackerlabs/repos","events_url":"https://api.github.com/users/rackerlabs/events{/privacy}","received_events_url":"https://api.github.com/users/rackerlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":10081109,"name":"blueflood","full_name":"rackerlabs/blueflood","owner":{"login":"rackerlabs","id":84293,"avatar_url":"https://avatars.githubusercontent.com/u/84293?v=3","gravatar_id":"","url":"https://api.github.com/users/rackerlabs","html_url":"https://github.com/rackerlabs","followers_url":"https://api.github.com/users/rackerlabs/followers","following_url":"https://api.github.com/users/rackerlabs/following{/other_user}","gists_url":"https://api.github.com/users/rackerlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/rackerlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rackerlabs/subscriptions","organizations_url":"https://api.github.com/users/rackerlabs/orgs","repos_url":"https://api.github.com/users/rackerlabs/repos","events_url":"https://api.github.com/users/rackerlabs/events{/privacy}","received_events_url":"https://api.github.com/users/rackerlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rackerlabs/blueflood","description":"A distributed system designed to ingest and process time series data","fork":false,"url":"https://api.github.com/repos/rackerlabs/blueflood","forks_url":"https://api.github.com/repos/rackerlabs/blueflood/forks","keys_url":"https://api.github.com/repos/rackerlabs/blueflood/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rackerlabs/blueflood/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rackerlabs/blueflood/teams","hooks_url":"https://api.github.com/repos/rackerlabs/blueflood/hooks","issue_events_url":"https://api.github.com/repos/rackerlabs/blueflood/issues/events{/number}","events_url":"https://api.github.com/repos/rackerlabs/blueflood/events","assignees_url":"https://api.github.com/repos/rackerlabs/blueflood/assignees{/user}","branches_url":"https://api.github.com/repos/rackerlabs/blueflood/branches{/branch}","tags_url":"https://api.github.com/repos/rackerlabs/blueflood/tags","blobs_url":"https://api.github.com/repos/rackerlabs/blueflood/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rackerlabs/blueflood/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rackerlabs/blueflood/git/refs{/sha}","trees_url":"https://api.github.com/repos/rackerlabs/blueflood/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rackerlabs/blueflood/statuses/{sha}","languages_url":"https://api.github.com/repos/rackerlabs/blueflood/languages","stargazers_url":"https://api.github.com/repos/rackerlabs/blueflood/stargazers","contributors_url":"https://api.github.com/repos/rackerlabs/blueflood/contributors","subscribers_url":"https://api.github.com/repos/rackerlabs/blueflood/subscribers","subscription_url":"https://api.github.com/repos/rackerlabs/blueflood/subscription","commits_url":"https://api.github.com/repos/rackerlabs/blueflood/commits{/sha}","git_commits_url":"https://api.github.com/repos/rackerlabs/blueflood/git/commits{/sha}","comments_url":"https://api.github.com/repos/rackerlabs/blueflood/comments{/number}","issue_comment_url":"https://api.github.com/repos/rackerlabs/blueflood/issues/comments{/number}","contents_url":"https://api.github.com/repos/rackerlabs/blueflood/contents/{+path}","compare_url":"https://api.github.com/repos/rackerlabs/blueflood/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rackerlabs/blueflood/merges","archive_url":"https://api.github.com/repos/rackerlabs/blueflood/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rackerlabs/blueflood/downloads","issues_url":"https://api.github.com/repos/rackerlabs/blueflood/issues{/number}","pulls_url":"https://api.github.com/repos/rackerlabs/blueflood/pulls{/number}","milestones_url":"https://api.github.com/repos/rackerlabs/blueflood/milestones{/number}","notifications_url":"https://api.github.com/repos/rackerlabs/blueflood/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rackerlabs/blueflood/labels{/name}","releases_url":"https://api.github.com/repos/rackerlabs/blueflood/releases{/id}","deployments_url":"https://api.github.com/repos/rackerlabs/blueflood/deployments","created_at":"2013-05-15T14:50:39Z","updated_at":"2016-06-06T16:43:33Z","pushed_at":"2016-06-06T18:29:50Z","git_url":"git://github.com/rackerlabs/blueflood.git","ssh_url":"git@github.com:rackerlabs/blueflood.git","clone_url":"https://github.com/rackerlabs/blueflood.git","svn_url":"https://github.com/rackerlabs/blueflood","homepage":"http://www.blueflood.io","size":13361,"stargazers_count":438,"watchers_count":438,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":63,"mirror_url":null,"open_issues_count":29,"forks":63,"open_issues":29,"watchers":438,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rackerlabs/blueflood/pulls/699"},"html":{"href":"https://github.com/rackerlabs/blueflood/pull/699"},"issue":{"href":"https://api.github.com/repos/rackerlabs/blueflood/issues/699"},"comments":{"href":"https://api.github.com/repos/rackerlabs/blueflood/issues/699/comments"},"review_comments":{"href":"https://api.github.com/repos/rackerlabs/blueflood/pulls/699/comments"},"review_comment":{"href":"https://api.github.com/repos/rackerlabs/blueflood/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rackerlabs/blueflood/pulls/699/commits"},"statuses":{"href":"https://api.github.com/repos/rackerlabs/blueflood/statuses/b3e26653a5e634eff4ea1937fd322a14831d1c79"}}}}
{"actor":{"display_login":"shintasmith"}}