{"action":"created","issue":{"url":"https://api.github.com/repos/Homebrew/brew/issues/1593","repository_url":"https://api.github.com/repos/Homebrew/brew","labels_url":"https://api.github.com/repos/Homebrew/brew/issues/1593/labels{/name}","comments_url":"https://api.github.com/repos/Homebrew/brew/issues/1593/comments","events_url":"https://api.github.com/repos/Homebrew/brew/issues/1593/events","html_url":"https://github.com/Homebrew/brew/pull/1593","id":192365670,"number":1593,"title":"Add --ask option to prompt for further action","user":{"login":"muellermartin","id":343302,"avatar_url":"https://avatars.githubusercontent.com/u/343302?v=3","gravatar_id":"","url":"https://api.github.com/users/muellermartin","html_url":"https://github.com/muellermartin","followers_url":"https://api.github.com/users/muellermartin/followers","following_url":"https://api.github.com/users/muellermartin/following{/other_user}","gists_url":"https://api.github.com/users/muellermartin/gists{/gist_id}","starred_url":"https://api.github.com/users/muellermartin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muellermartin/subscriptions","organizations_url":"https://api.github.com/users/muellermartin/orgs","repos_url":"https://api.github.com/users/muellermartin/repos","events_url":"https://api.github.com/users/muellermartin/events{/privacy}","received_events_url":"https://api.github.com/users/muellermartin/received_events","type":"User","site_admin":false},"labels":[{"id":351931983,"url":"https://api.github.com/repos/Homebrew/brew/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-11-29T18:46:31Z","updated_at":"2016-11-30T08:59:34Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Homebrew/brew/pulls/1593","html_url":"https://github.com/Homebrew/brew/pull/1593","diff_url":"https://github.com/Homebrew/brew/pull/1593.diff","patch_url":"https://github.com/Homebrew/brew/pull/1593.patch"},"body":"- [x] Have you followed the guidelines in our [Contributing](https://github.com/Homebrew/brew/blob/master/CONTRIBUTING.md) document?\r\n- [x] Have you checked to ensure there aren't other open [Pull Requests](https://github.com/Homebrew/brew/pulls) for the same change?\r\n- [x] Have you added an explanation of what your changes do and why you'd like us to include them?\r\n- [ ] Have you written new tests for your changes? [Here's an example](https://github.com/Homebrew/homebrew/pull/49031).\r\n- [x] Have you successfully run `brew tests` with your changes locally?\r\n\r\n-----\r\n\r\nThis option shall be used for several functions like upgrade, install,\r\nremove etc. to prompt the user before potentially long lasting\r\noperations or as small safety measure.\r\n\r\nThis commit only affects the upgrade command, but it is designed to be\r\nusable by other commands.\r\n\r\nTechnically the --ask option only sets the environment variable\r\nHOMEBREW_ASK to 1 which then can be checked against in each command. To\r\nnot affect further commands, the option is removed from the option list.\r\n\r\nCredits to the Stack Overflow answer\r\nhttp://stackoverflow.com/a/6278862/1532986\r\nfor the prompt() function.\r\n\r\nEdit: There is an ongoing discussion at http://discourse.brew.sh/t/features-from-gentoos-portage/463 about this and similar features"},"comment":{"url":"https://api.github.com/repos/Homebrew/brew/issues/comments/263818768","html_url":"https://github.com/Homebrew/brew/pull/1593#issuecomment-263818768","issue_url":"https://api.github.com/repos/Homebrew/brew/issues/1593","id":263818768,"user":{"login":"MikeMcQuaid","id":125011,"avatar_url":"https://avatars.githubusercontent.com/u/125011?v=3","gravatar_id":"","url":"https://api.github.com/users/MikeMcQuaid","html_url":"https://github.com/MikeMcQuaid","followers_url":"https://api.github.com/users/MikeMcQuaid/followers","following_url":"https://api.github.com/users/MikeMcQuaid/following{/other_user}","gists_url":"https://api.github.com/users/MikeMcQuaid/gists{/gist_id}","starred_url":"https://api.github.com/users/MikeMcQuaid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikeMcQuaid/subscriptions","organizations_url":"https://api.github.com/users/MikeMcQuaid/orgs","repos_url":"https://api.github.com/users/MikeMcQuaid/repos","events_url":"https://api.github.com/users/MikeMcQuaid/events{/privacy}","received_events_url":"https://api.github.com/users/MikeMcQuaid/received_events","type":"User","site_admin":true},"created_at":"2016-11-30T08:59:34Z","updated_at":"2016-11-30T08:59:34Z","body":"> This feature was discussed on the discourse thread linked in the OP and there you said \"Those all seem like cool features. They are probably in the category of things we'd accept pull-requests for rather than actively work on, though.\"\r\n\r\nSorry, I didn't tie the usernames together and would have left this open for longer and more discussion. I should have been clearer but the \"probably\" there was relevant.\r\n\r\nThis (the `--ask)  is probably my least favourite of the mentioned ideas because of previous Homebrew consistency due to the design choice. The implementation seems sound. That said, if this remains a non-default option then it could be OK. I'll leave this open for a bit and see if others have thoughts there.\r\n\r\n> show progress in title (e.g. 5/21 qt5) to see where the update progress is\r\n> show progress between packages (e.g. Updating package 5 of 21: qt5)\r\n> show post-install messages (\"Caveats\", build errors etc.) after installing all the updates instead after each one\r\n\r\nTo me these are all pretty unambiguously positive and in the spirit of Homebrew's current design."}}
{"actor":{"display_login":"MikeMcQuaid"}}