{"push_id":1128017281,"size":1,"distinct_size":1,"ref":"refs/heads/master","head":"9558ce5a3e9ce8b43e4dc4d59442fbbdfad175f6","before":"4655e61c2840798dc202f027aab149d9530c3859","commits":[{"sha":"9558ce5a3e9ce8b43e4dc4d59442fbbdfad175f6","author":{"email":"f56adeef18cb5eed56cd82d8c7100e80f36f6b8b@fb.com","name":"Avik Chaudhuri"},"message":"don't add properties to dictionary types\n\nSummary:\nSetting a property on an object type with a dictionary would add the property to\nthe object type if it didn't already exist. The motivation was to track the type\nof the property more precisely.\n\nUnfortunately, this led to some surprising consequences: we would report some\nerrors only when we saw constraints in a particular order. Since this order is\nin general not correlated to the order in which code gets executed at run time,\nwe consider \"races\" like this to be bugs.\n\nWorse, considering dictionary types to be unsealed like this would sometimes\ncause us to miss real type incompatibility errors: a set along one path would\nsilence errors on gets along different paths.\n\nThis diff fixes by closely following what happens with dictionaries on gets.\n\nFixes https://github.com/facebook/flow/issues/1745\n\nReviewed By: samwgoldman\n\nDifferential Revision: D3322062\n\nfbshipit-source-id: e37ac3eb8459b4a176575d2f4dfa35a9eb02ad53","distinct":true,"url":"https://api.github.com/repos/facebook/flow/commits/9558ce5a3e9ce8b43e4dc4d59442fbbdfad175f6"}]}
{"actor":{"display_login":"facebook-github-bot-1"}}