{"action":"created","issue":{"url":"https://api.github.com/repos/mozilla/datomish/issues/18","repository_url":"https://api.github.com/repos/mozilla/datomish","labels_url":"https://api.github.com/repos/mozilla/datomish/issues/18/labels{/name}","comments_url":"https://api.github.com/repos/mozilla/datomish/issues/18/comments","events_url":"https://api.github.com/repos/mozilla/datomish/issues/18/events","html_url":"https://github.com/mozilla/datomish/pull/18","id":167966983,"number":18,"title":"Transact rewrite","user":{"login":"ncalexan","id":1097182,"avatar_url":"https://avatars.githubusercontent.com/u/1097182?v=3","gravatar_id":"","url":"https://api.github.com/users/ncalexan","html_url":"https://github.com/ncalexan","followers_url":"https://api.github.com/users/ncalexan/followers","following_url":"https://api.github.com/users/ncalexan/following{/other_user}","gists_url":"https://api.github.com/users/ncalexan/gists{/gist_id}","starred_url":"https://api.github.com/users/ncalexan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ncalexan/subscriptions","organizations_url":"https://api.github.com/users/ncalexan/orgs","repos_url":"https://api.github.com/users/ncalexan/repos","events_url":"https://api.github.com/users/ncalexan/events{/privacy}","received_events_url":"https://api.github.com/users/ncalexan/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-07-27T21:59:59Z","updated_at":"2016-08-05T19:48:05Z","closed_at":"2016-08-05T19:46:04Z","pull_request":{"url":"https://api.github.com/repos/mozilla/datomish/pulls/18","html_url":"https://github.com/mozilla/datomish/pull/18","diff_url":"https://github.com/mozilla/datomish/pull/18.diff","patch_url":"https://github.com/mozilla/datomish/pull/18.patch"},"body":"@rnewman okay, first commit here is ready for first review.  Still lots to do, but it's a start.  I'm happy to land something like this as a first step, mostly so you can use the bits here to generate test data; or I'm happy to build it up further before landing.\r\n\r\nSome of the stuff I'll be working on next, some of which are noted with TODOs:\r\n\r\n- [ ] Implement parts, or revert to DataScript-like negative integers.\r\n- [ ] Persist idents, parts, entity id counters, transaction indices in SQLite.\r\n- [ ] Implement `:db/value` type checks throughout.\r\n- [ ] Implement lookup refs for real.\r\n- [ ] Finish implementing map properties (reverse refs, sequential values, etc).\r\n- [ ] Set `:db/txInstant` correctly; ensure tx timestamps are reasonable.\r\n- [ ] Work out the story around using `#dm/id[:db.part/tx]` to refer to the current transaction, or revert to DataScript-like \":db/currentTx\"."},"comment":{"url":"https://api.github.com/repos/mozilla/datomish/issues/comments/237945657","html_url":"https://github.com/mozilla/datomish/pull/18#issuecomment-237945657","issue_url":"https://api.github.com/repos/mozilla/datomish/issues/18","id":237945657,"user":{"login":"ncalexan","id":1097182,"avatar_url":"https://avatars.githubusercontent.com/u/1097182?v=3","gravatar_id":"","url":"https://api.github.com/users/ncalexan","html_url":"https://github.com/ncalexan","followers_url":"https://api.github.com/users/ncalexan/followers","following_url":"https://api.github.com/users/ncalexan/following{/other_user}","gists_url":"https://api.github.com/users/ncalexan/gists{/gist_id}","starred_url":"https://api.github.com/users/ncalexan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ncalexan/subscriptions","organizations_url":"https://api.github.com/users/ncalexan/orgs","repos_url":"https://api.github.com/users/ncalexan/repos","events_url":"https://api.github.com/users/ncalexan/events{/privacy}","received_events_url":"https://api.github.com/users/ncalexan/received_events","type":"User","site_admin":false},"created_at":"2016-08-05T19:48:05Z","updated_at":"2016-08-05T19:48:05Z","body":"To summarize:\r\n\r\n> Implement parts, or revert to DataScript-like negative integers.\r\n\r\nThis isn't done.\r\n\r\n>     Persist idents, parts, entity id counters, transaction indices in SQLite.\r\n\r\nIdents and transaction indices are done; entity IDs are not done (those are under the banner of parts above).\r\n\r\n>     Implement :db/value type checks throughout.\r\n\r\nDone!\r\n\r\n>     Implement lookup refs for real.\r\n\r\nNot done.  This is somewhat orthogonal to the rest of the work; it's a nice to have.\r\n\r\n>     Finish implementing map properties (reverse refs, sequential values, etc).\r\n\r\nDone!\r\n\r\n>     Set :db/txInstant correctly; ensure tx timestamps are reasonable.\r\n\r\nDone.\r\n\r\n>     Work out the story around using #dm/id[:db.part/tx] to refer to the current transaction, or revert to DataScript-like \":db/currentTx\".\r\n\r\nI ended doing a DS-like `:db/tx` rather than copy Datomic's `:db.part/tx`, which seemed to me very inconsistent."}}
{"actor":{"display_login":"ncalexan"}}