{"action":"closed","number":4177,"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/4177","id":80720479,"html_url":"https://github.com/apple/swift/pull/4177","diff_url":"https://github.com/apple/swift/pull/4177.diff","patch_url":"https://github.com/apple/swift/pull/4177.patch","issue_url":"https://api.github.com/repos/apple/swift/issues/4177","number":4177,"state":"closed","locked":false,"title":"[SourceKit] Fix typo in `sourcekitd-test` error handler response","user":{"login":"RLovelett","id":335572,"avatar_url":"https://avatars.githubusercontent.com/u/335572?v=3","gravatar_id":"","url":"https://api.github.com/users/RLovelett","html_url":"https://github.com/RLovelett","followers_url":"https://api.github.com/users/RLovelett/followers","following_url":"https://api.github.com/users/RLovelett/following{/other_user}","gists_url":"https://api.github.com/users/RLovelett/gists{/gist_id}","starred_url":"https://api.github.com/users/RLovelett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RLovelett/subscriptions","organizations_url":"https://api.github.com/users/RLovelett/orgs","repos_url":"https://api.github.com/users/RLovelett/repos","events_url":"https://api.github.com/users/RLovelett/events{/privacy}","received_events_url":"https://api.github.com/users/RLovelett/received_events","type":"User","site_admin":false},"body":"- Explanation: This change was proposed and accepted into master in #3862. @gribozavr suggested that I could propose this change for the Swift 3.0 branch. Here we are.\r\n\r\nCurrently if you type in a malformed pos argument, e.g., `sourcekitd-test -req=complete -pos=9,10 source.swift -- source.swift` it responds with:\r\n\r\n    wrong pos format, it should be '<line>:<column'\r\n\r\nAfter the change it responds with:\r\n\r\n    wrong pos format, it should be '<line>:<column>'\r\n\r\n- Scope: It should only impact those running the `sourcekit-test` executable during test. AFAIK the executable is not distributed so the impact _should_ be minimal.\r\n\r\n- SR Issue: None\r\n\r\n- Risk: Low because the executable is not distributed.\r\n\r\n- Testing: It is covered by and a part of the Swift test suite already.","created_at":"2016-08-10T01:12:28Z","updated_at":"2016-08-10T04:24:29Z","closed_at":"2016-08-10T04:24:29Z","merged_at":"2016-08-10T04:24:29Z","merge_commit_sha":"12a9b6c46ced65ac807c3564bbd1c004de313c3a","assignee":{"login":"tkremenek","id":3087023,"avatar_url":"https://avatars.githubusercontent.com/u/3087023?v=3","gravatar_id":"","url":"https://api.github.com/users/tkremenek","html_url":"https://github.com/tkremenek","followers_url":"https://api.github.com/users/tkremenek/followers","following_url":"https://api.github.com/users/tkremenek/following{/other_user}","gists_url":"https://api.github.com/users/tkremenek/gists{/gist_id}","starred_url":"https://api.github.com/users/tkremenek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkremenek/subscriptions","organizations_url":"https://api.github.com/users/tkremenek/orgs","repos_url":"https://api.github.com/users/tkremenek/repos","events_url":"https://api.github.com/users/tkremenek/events{/privacy}","received_events_url":"https://api.github.com/users/tkremenek/received_events","type":"User","site_admin":false},"assignees":[{"login":"tkremenek","id":3087023,"avatar_url":"https://avatars.githubusercontent.com/u/3087023?v=3","gravatar_id":"","url":"https://api.github.com/users/tkremenek","html_url":"https://github.com/tkremenek","followers_url":"https://api.github.com/users/tkremenek/followers","following_url":"https://api.github.com/users/tkremenek/following{/other_user}","gists_url":"https://api.github.com/users/tkremenek/gists{/gist_id}","starred_url":"https://api.github.com/users/tkremenek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkremenek/subscriptions","organizations_url":"https://api.github.com/users/tkremenek/orgs","repos_url":"https://api.github.com/users/tkremenek/repos","events_url":"https://api.github.com/users/tkremenek/events{/privacy}","received_events_url":"https://api.github.com/users/tkremenek/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/apple/swift/milestones/7","html_url":"https://github.com/apple/swift/milestones/Swift%203.0","labels_url":"https://api.github.com/repos/apple/swift/milestones/7/labels","id":1921538,"number":7,"title":"Swift 3.0","description":null,"creator":{"login":"shahmishal","id":2727770,"avatar_url":"https://avatars.githubusercontent.com/u/2727770?v=3","gravatar_id":"","url":"https://api.github.com/users/shahmishal","html_url":"https://github.com/shahmishal","followers_url":"https://api.github.com/users/shahmishal/followers","following_url":"https://api.github.com/users/shahmishal/following{/other_user}","gists_url":"https://api.github.com/users/shahmishal/gists{/gist_id}","starred_url":"https://api.github.com/users/shahmishal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shahmishal/subscriptions","organizations_url":"https://api.github.com/users/shahmishal/orgs","repos_url":"https://api.github.com/users/shahmishal/repos","events_url":"https://api.github.com/users/shahmishal/events{/privacy}","received_events_url":"https://api.github.com/users/shahmishal/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":32,"state":"open","created_at":"2016-08-03T18:11:11Z","updated_at":"2016-08-10T04:24:29Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/apple/swift/pulls/4177/commits","review_comments_url":"https://api.github.com/repos/apple/swift/pulls/4177/comments","review_comment_url":"https://api.github.com/repos/apple/swift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift/issues/4177/comments","statuses_url":"https://api.github.com/repos/apple/swift/statuses/793398b199657d520bc6b9eda4a9475a6e0307ac","head":{"label":"RLovelett:bugfix/typo-in-sourcekitd-test","ref":"bugfix/typo-in-sourcekitd-test","sha":"793398b199657d520bc6b9eda4a9475a6e0307ac","user":{"login":"RLovelett","id":335572,"avatar_url":"https://avatars.githubusercontent.com/u/335572?v=3","gravatar_id":"","url":"https://api.github.com/users/RLovelett","html_url":"https://github.com/RLovelett","followers_url":"https://api.github.com/users/RLovelett/followers","following_url":"https://api.github.com/users/RLovelett/following{/other_user}","gists_url":"https://api.github.com/users/RLovelett/gists{/gist_id}","starred_url":"https://api.github.com/users/RLovelett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RLovelett/subscriptions","organizations_url":"https://api.github.com/users/RLovelett/orgs","repos_url":"https://api.github.com/users/RLovelett/repos","events_url":"https://api.github.com/users/RLovelett/events{/privacy}","received_events_url":"https://api.github.com/users/RLovelett/received_events","type":"User","site_admin":false},"repo":{"id":47842086,"name":"swift","full_name":"RLovelett/swift","owner":{"login":"RLovelett","id":335572,"avatar_url":"https://avatars.githubusercontent.com/u/335572?v=3","gravatar_id":"","url":"https://api.github.com/users/RLovelett","html_url":"https://github.com/RLovelett","followers_url":"https://api.github.com/users/RLovelett/followers","following_url":"https://api.github.com/users/RLovelett/following{/other_user}","gists_url":"https://api.github.com/users/RLovelett/gists{/gist_id}","starred_url":"https://api.github.com/users/RLovelett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RLovelett/subscriptions","organizations_url":"https://api.github.com/users/RLovelett/orgs","repos_url":"https://api.github.com/users/RLovelett/repos","events_url":"https://api.github.com/users/RLovelett/events{/privacy}","received_events_url":"https://api.github.com/users/RLovelett/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/RLovelett/swift","description":"The Swift Programming Language","fork":true,"url":"https://api.github.com/repos/RLovelett/swift","forks_url":"https://api.github.com/repos/RLovelett/swift/forks","keys_url":"https://api.github.com/repos/RLovelett/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RLovelett/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RLovelett/swift/teams","hooks_url":"https://api.github.com/repos/RLovelett/swift/hooks","issue_events_url":"https://api.github.com/repos/RLovelett/swift/issues/events{/number}","events_url":"https://api.github.com/repos/RLovelett/swift/events","assignees_url":"https://api.github.com/repos/RLovelett/swift/assignees{/user}","branches_url":"https://api.github.com/repos/RLovelett/swift/branches{/branch}","tags_url":"https://api.github.com/repos/RLovelett/swift/tags","blobs_url":"https://api.github.com/repos/RLovelett/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RLovelett/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RLovelett/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/RLovelett/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RLovelett/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/RLovelett/swift/languages","stargazers_url":"https://api.github.com/repos/RLovelett/swift/stargazers","contributors_url":"https://api.github.com/repos/RLovelett/swift/contributors","subscribers_url":"https://api.github.com/repos/RLovelett/swift/subscribers","subscription_url":"https://api.github.com/repos/RLovelett/swift/subscription","commits_url":"https://api.github.com/repos/RLovelett/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/RLovelett/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/RLovelett/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/RLovelett/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/RLovelett/swift/contents/{+path}","compare_url":"https://api.github.com/repos/RLovelett/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RLovelett/swift/merges","archive_url":"https://api.github.com/repos/RLovelett/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RLovelett/swift/downloads","issues_url":"https://api.github.com/repos/RLovelett/swift/issues{/number}","pulls_url":"https://api.github.com/repos/RLovelett/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/RLovelett/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/RLovelett/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RLovelett/swift/labels{/name}","releases_url":"https://api.github.com/repos/RLovelett/swift/releases{/id}","deployments_url":"https://api.github.com/repos/RLovelett/swift/deployments","created_at":"2015-12-11T17:50:41Z","updated_at":"2016-01-12T03:32:09Z","pushed_at":"2016-08-10T01:00:55Z","git_url":"git://github.com/RLovelett/swift.git","ssh_url":"git@github.com:RLovelett/swift.git","clone_url":"https://github.com/RLovelett/swift.git","svn_url":"https://github.com/RLovelett/swift","homepage":"https://swift.org/","size":109845,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apple:swift-3.0-branch","ref":"swift-3.0-branch","sha":"0efecd94f2a815781d06c90ca93186d96318ff1e","user":{"login":"apple","id":10639145,"avatar_url":"https://avatars.githubusercontent.com/u/10639145?v=3","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":44838949,"name":"swift","full_name":"apple/swift","owner":{"login":"apple","id":10639145,"avatar_url":"https://avatars.githubusercontent.com/u/10639145?v=3","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apple/swift","description":"The Swift Programming Language","fork":false,"url":"https://api.github.com/repos/apple/swift","forks_url":"https://api.github.com/repos/apple/swift/forks","keys_url":"https://api.github.com/repos/apple/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift/teams","hooks_url":"https://api.github.com/repos/apple/swift/hooks","issue_events_url":"https://api.github.com/repos/apple/swift/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift/events","assignees_url":"https://api.github.com/repos/apple/swift/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift/tags","blobs_url":"https://api.github.com/repos/apple/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift/languages","stargazers_url":"https://api.github.com/repos/apple/swift/stargazers","contributors_url":"https://api.github.com/repos/apple/swift/contributors","subscribers_url":"https://api.github.com/repos/apple/swift/subscribers","subscription_url":"https://api.github.com/repos/apple/swift/subscription","commits_url":"https://api.github.com/repos/apple/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift/merges","archive_url":"https://api.github.com/repos/apple/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift/downloads","issues_url":"https://api.github.com/repos/apple/swift/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift/deployments","created_at":"2015-10-23T21:15:07Z","updated_at":"2016-08-10T03:32:32Z","pushed_at":"2016-08-10T04:24:29Z","git_url":"git://github.com/apple/swift.git","ssh_url":"git@github.com:apple/swift.git","clone_url":"https://github.com/apple/swift.git","svn_url":"https://github.com/apple/swift","homepage":"https://swift.org/","size":172893,"stargazers_count":33054,"watchers_count":33054,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4636,"mirror_url":null,"open_issues_count":89,"forks":4636,"open_issues":89,"watchers":33054,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/4177"},"html":{"href":"https://github.com/apple/swift/pull/4177"},"issue":{"href":"https://api.github.com/repos/apple/swift/issues/4177"},"comments":{"href":"https://api.github.com/repos/apple/swift/issues/4177/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift/pulls/4177/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift/pulls/4177/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift/statuses/793398b199657d520bc6b9eda4a9475a6e0307ac"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"tkremenek","id":3087023,"avatar_url":"https://avatars.githubusercontent.com/u/3087023?v=3","gravatar_id":"","url":"https://api.github.com/users/tkremenek","html_url":"https://github.com/tkremenek","followers_url":"https://api.github.com/users/tkremenek/followers","following_url":"https://api.github.com/users/tkremenek/following{/other_user}","gists_url":"https://api.github.com/users/tkremenek/gists{/gist_id}","starred_url":"https://api.github.com/users/tkremenek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkremenek/subscriptions","organizations_url":"https://api.github.com/users/tkremenek/orgs","repos_url":"https://api.github.com/users/tkremenek/repos","events_url":"https://api.github.com/users/tkremenek/events{/privacy}","received_events_url":"https://api.github.com/users/tkremenek/received_events","type":"User","site_admin":false},"comments":4,"review_comments":0,"commits":1,"additions":6,"deletions":6,"changed_files":2}}
{"actor":{"display_login":"tkremenek"}}