{"action":"created","issue":{"url":"https://api.github.com/repos/demot/RandomOrgJson-RPC/issues/3","repository_url":"https://api.github.com/repos/demot/RandomOrgJson-RPC","labels_url":"https://api.github.com/repos/demot/RandomOrgJson-RPC/issues/3/labels{/name}","comments_url":"https://api.github.com/repos/demot/RandomOrgJson-RPC/issues/3/comments","events_url":"https://api.github.com/repos/demot/RandomOrgJson-RPC/issues/3/events","html_url":"https://github.com/demot/RandomOrgJson-RPC/issues/3","id":188401024,"number":3,"title":"GenerateBlobs - format error","user":{"login":"kuiperzone","id":17156238,"avatar_url":"https://avatars.githubusercontent.com/u/17156238?v=3","gravatar_id":"","url":"https://api.github.com/users/kuiperzone","html_url":"https://github.com/kuiperzone","followers_url":"https://api.github.com/users/kuiperzone/followers","following_url":"https://api.github.com/users/kuiperzone/following{/other_user}","gists_url":"https://api.github.com/users/kuiperzone/gists{/gist_id}","starred_url":"https://api.github.com/users/kuiperzone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kuiperzone/subscriptions","organizations_url":"https://api.github.com/users/kuiperzone/orgs","repos_url":"https://api.github.com/users/kuiperzone/repos","events_url":"https://api.github.com/users/kuiperzone/events{/privacy}","received_events_url":"https://api.github.com/users/kuiperzone/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-11-10T01:55:53Z","updated_at":"2016-11-10T21:25:07Z","closed_at":null,"body":"In the following method in RandomOrgApiClient.cs:\r\n        public Response GenerateBlobs(int n, int size, int id, bool signed, string format = \"base64\") {\r\n\r\nfails due to this line:\r\n            if(format != \"base64\" || format != \"hex\")\r\n\r\nNeeds to be:\r\n            if(format != \"base64\" && format != \"hex\")\r\n\r\nHas this code been unit tested at all?"},"comment":{"url":"https://api.github.com/repos/demot/RandomOrgJson-RPC/issues/comments/259811783","html_url":"https://github.com/demot/RandomOrgJson-RPC/issues/3#issuecomment-259811783","issue_url":"https://api.github.com/repos/demot/RandomOrgJson-RPC/issues/3","id":259811783,"user":{"login":"demot","id":5091221,"avatar_url":"https://avatars.githubusercontent.com/u/5091221?v=3","gravatar_id":"","url":"https://api.github.com/users/demot","html_url":"https://github.com/demot","followers_url":"https://api.github.com/users/demot/followers","following_url":"https://api.github.com/users/demot/following{/other_user}","gists_url":"https://api.github.com/users/demot/gists{/gist_id}","starred_url":"https://api.github.com/users/demot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/demot/subscriptions","organizations_url":"https://api.github.com/users/demot/orgs","repos_url":"https://api.github.com/users/demot/repos","events_url":"https://api.github.com/users/demot/events{/privacy}","received_events_url":"https://api.github.com/users/demot/received_events","type":"User","site_admin":false},"created_at":"2016-11-10T21:25:07Z","updated_at":"2016-11-10T21:25:07Z","body":"That line is kind of nonsense, you are right.\r\nThe code itself is not unit tested because of a lack of experience with unit tests in that time. I will commit a change to that format nonsense condition soon, but the overall issue of untested parts of the code still remains, due to a lack of time right now."}}
{"actor":{"display_login":"demot"}}