{"action":"opened","number":287,"pull_request":{"url":"https://api.github.com/repos/xamarin/xamarin-android/pulls/287","id":92947241,"html_url":"https://github.com/xamarin/xamarin-android/pull/287","diff_url":"https://github.com/xamarin/xamarin-android/pull/287.diff","patch_url":"https://github.com/xamarin/xamarin-android/pull/287.patch","issue_url":"https://api.github.com/repos/xamarin/xamarin-android/issues/287","number":287,"state":"open","locked":false,"title":"[mono-runtimes] DO NOT USE `-ldl` on Windows.","user":{"login":"jonpryor","id":155958,"avatar_url":"https://avatars.githubusercontent.com/u/155958?v=3","gravatar_id":"","url":"https://api.github.com/users/jonpryor","html_url":"https://github.com/jonpryor","followers_url":"https://api.github.com/users/jonpryor/followers","following_url":"https://api.github.com/users/jonpryor/following{/other_user}","gists_url":"https://api.github.com/users/jonpryor/gists{/gist_id}","starred_url":"https://api.github.com/users/jonpryor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonpryor/subscriptions","organizations_url":"https://api.github.com/users/jonpryor/orgs","repos_url":"https://api.github.com/users/jonpryor/repos","events_url":"https://api.github.com/users/jonpryor/events{/privacy}","received_events_url":"https://api.github.com/users/jonpryor/received_events","type":"User","site_admin":false},"body":"Fix a [Build][0] [Break][1]:\r\n\r\n\tmono-runtimes.targets: error : Cannot copy\r\n\t.../xamarin-android/build-tools/mono-runtimes/obj/Debug//host-mxe-Win64/mono/mini/.libs/libmonosgen-2.0.dll\r\n\tto\r\n\t.../xamarin-android/bin/Debug/lib/xbuild/Xamarin/Android/lib/host-mxe-Win64/libmonosgen-2.0.dll,\r\n\tas the source file doesn't exist.\r\n\r\nThis is caused by an earlier *warning* in the build log:\r\n\r\n\t*** Warning: linker path does not have real file for library -ldl.\r\n\t*** I have the capability to make that library automatically link in when\r\n\t*** you link to this library.  But I can only do this if you have a\r\n\t*** shared version of the library, which you do not appear to have\r\n\t*** because I did check the linker path looking for a file starting\r\n\t*** with libdl and none of the candidates passed a file format test\r\n\t*** using a file magic. Last file checked: /Users/jon/android-toolchain/mxe/x86_64-w64-mingw32.static/lib/libdl.a\r\n\t*** The inter-library dependencies that have been dropped here will be\r\n\t*** automatically added whenever a program is linked with this library\r\n\t*** or is declared to -dlopen it.\r\n\t*** Since this library must not contain undefined symbols,\r\n\t*** because either the platform does not support them or\r\n\t*** it was explicitly requested with -no-undefined,\r\n\t*** libtool will only create a static version of it.\r\n\r\nWhich means that when attempting to link `libmonosgen-2.0.dll`,\r\n`-ldl` was provided. The problem there is that our MXE build provides\r\na `libdl.a` archive, but not exports for a `DL.DLL` Windows library.\r\n\r\nWhat was *really* puzzling, to me, was that our internal system\r\nbuilds, using the \"same\" setup: an MXE cross compiler.\r\n\r\nDeeper investigation showed that our internal system and the public\r\nsystem are *not* the same, in one crucial way. The internal setup has\r\n*two* MXE builds, `mxe` and `mxe-full`. The difference between them is\r\nthat `mxe` is used to build `libmonosgen-2.0.dll`, while `mxe-full`\r\n(1) adds the `dlfcn-win32` MXE \"package\", and (2) is used to build\r\n`libmono-android*.dll`.\r\n\r\nThus the cause of the breakage is commit a9bd478a, which added\r\n`dlfcn-win32` to the MXE build, but we *want* this change so that we\r\ncan build `src/monodroid` for Windows.\r\n\r\nHow do we split this difference?\r\n\r\nThere are two plausible solutions:\r\n\r\n1. Have *two* MXE environments, just like we do internally. One would\r\n    include the `dlfcn-win32` files, the other wouldn't.\r\n\r\n2. Tell `configure` to *not* use `-ldl` on Windows.\r\n\r\n(2) is far easier, and involves augmenting the Windows configure with:\r\n\r\n\tac_cv_search_dlopen=no\r\n\r\nThis prevents the `-ldl` check from being done in the first place,\r\nallowing xamarin-android to have a *single* MXE installation that is\r\nusable for both `build-tools/mono-runtimes` and `src/monodroid`.\r\n\r\n[0]: https://jenkins.mono-project.com/view/Xamarin.Android/job/xamarin-android/135/\r\n[1]: https://jenkins.mono-project.com/view/Xamarin.Android/job/xamarin-android/135/consoleText","created_at":"2016-11-09T11:33:07Z","updated_at":"2016-11-09T11:33:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/xamarin/xamarin-android/pulls/287/commits","review_comments_url":"https://api.github.com/repos/xamarin/xamarin-android/pulls/287/comments","review_comment_url":"https://api.github.com/repos/xamarin/xamarin-android/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xamarin/xamarin-android/issues/287/comments","statuses_url":"https://api.github.com/repos/xamarin/xamarin-android/statuses/a7436d651d7a039ff7bea1b3ea5ae798911a3ece","head":{"label":"jonpryor:jonp-fix-build-a569cfc59f28400f0780b8fd1ea066eb1820ccf","ref":"jonp-fix-build-a569cfc59f28400f0780b8fd1ea066eb1820ccf","sha":"a7436d651d7a039ff7bea1b3ea5ae798911a3ece","user":{"login":"jonpryor","id":155958,"avatar_url":"https://avatars.githubusercontent.com/u/155958?v=3","gravatar_id":"","url":"https://api.github.com/users/jonpryor","html_url":"https://github.com/jonpryor","followers_url":"https://api.github.com/users/jonpryor/followers","following_url":"https://api.github.com/users/jonpryor/following{/other_user}","gists_url":"https://api.github.com/users/jonpryor/gists{/gist_id}","starred_url":"https://api.github.com/users/jonpryor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonpryor/subscriptions","organizations_url":"https://api.github.com/users/jonpryor/orgs","repos_url":"https://api.github.com/users/jonpryor/repos","events_url":"https://api.github.com/users/jonpryor/events{/privacy}","received_events_url":"https://api.github.com/users/jonpryor/received_events","type":"User","site_admin":false},"repo":{"id":57242763,"name":"xamarin-android","full_name":"jonpryor/xamarin-android","owner":{"login":"jonpryor","id":155958,"avatar_url":"https://avatars.githubusercontent.com/u/155958?v=3","gravatar_id":"","url":"https://api.github.com/users/jonpryor","html_url":"https://github.com/jonpryor","followers_url":"https://api.github.com/users/jonpryor/followers","following_url":"https://api.github.com/users/jonpryor/following{/other_user}","gists_url":"https://api.github.com/users/jonpryor/gists{/gist_id}","starred_url":"https://api.github.com/users/jonpryor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonpryor/subscriptions","organizations_url":"https://api.github.com/users/jonpryor/orgs","repos_url":"https://api.github.com/users/jonpryor/repos","events_url":"https://api.github.com/users/jonpryor/events{/privacy}","received_events_url":"https://api.github.com/users/jonpryor/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jonpryor/xamarin-android","description":null,"fork":true,"url":"https://api.github.com/repos/jonpryor/xamarin-android","forks_url":"https://api.github.com/repos/jonpryor/xamarin-android/forks","keys_url":"https://api.github.com/repos/jonpryor/xamarin-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jonpryor/xamarin-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jonpryor/xamarin-android/teams","hooks_url":"https://api.github.com/repos/jonpryor/xamarin-android/hooks","issue_events_url":"https://api.github.com/repos/jonpryor/xamarin-android/issues/events{/number}","events_url":"https://api.github.com/repos/jonpryor/xamarin-android/events","assignees_url":"https://api.github.com/repos/jonpryor/xamarin-android/assignees{/user}","branches_url":"https://api.github.com/repos/jonpryor/xamarin-android/branches{/branch}","tags_url":"https://api.github.com/repos/jonpryor/xamarin-android/tags","blobs_url":"https://api.github.com/repos/jonpryor/xamarin-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jonpryor/xamarin-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jonpryor/xamarin-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/jonpryor/xamarin-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jonpryor/xamarin-android/statuses/{sha}","languages_url":"https://api.github.com/repos/jonpryor/xamarin-android/languages","stargazers_url":"https://api.github.com/repos/jonpryor/xamarin-android/stargazers","contributors_url":"https://api.github.com/repos/jonpryor/xamarin-android/contributors","subscribers_url":"https://api.github.com/repos/jonpryor/xamarin-android/subscribers","subscription_url":"https://api.github.com/repos/jonpryor/xamarin-android/subscription","commits_url":"https://api.github.com/repos/jonpryor/xamarin-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/jonpryor/xamarin-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/jonpryor/xamarin-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/jonpryor/xamarin-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/jonpryor/xamarin-android/contents/{+path}","compare_url":"https://api.github.com/repos/jonpryor/xamarin-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jonpryor/xamarin-android/merges","archive_url":"https://api.github.com/repos/jonpryor/xamarin-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jonpryor/xamarin-android/downloads","issues_url":"https://api.github.com/repos/jonpryor/xamarin-android/issues{/number}","pulls_url":"https://api.github.com/repos/jonpryor/xamarin-android/pulls{/number}","milestones_url":"https://api.github.com/repos/jonpryor/xamarin-android/milestones{/number}","notifications_url":"https://api.github.com/repos/jonpryor/xamarin-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jonpryor/xamarin-android/labels{/name}","releases_url":"https://api.github.com/repos/jonpryor/xamarin-android/releases{/id}","deployments_url":"https://api.github.com/repos/jonpryor/xamarin-android/deployments","created_at":"2016-04-27T19:46:01Z","updated_at":"2016-04-27T19:46:03Z","pushed_at":"2016-11-09T11:32:51Z","git_url":"git://github.com/jonpryor/xamarin-android.git","ssh_url":"git@github.com:jonpryor/xamarin-android.git","clone_url":"https://github.com/jonpryor/xamarin-android.git","svn_url":"https://github.com/jonpryor/xamarin-android","homepage":null,"size":6099,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xamarin:master","ref":"master","sha":"1ee4cab25a95e8e0391012f182c6284706962ea8","user":{"login":"xamarin","id":790012,"avatar_url":"https://avatars.githubusercontent.com/u/790012?v=3","gravatar_id":"","url":"https://api.github.com/users/xamarin","html_url":"https://github.com/xamarin","followers_url":"https://api.github.com/users/xamarin/followers","following_url":"https://api.github.com/users/xamarin/following{/other_user}","gists_url":"https://api.github.com/users/xamarin/gists{/gist_id}","starred_url":"https://api.github.com/users/xamarin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xamarin/subscriptions","organizations_url":"https://api.github.com/users/xamarin/orgs","repos_url":"https://api.github.com/users/xamarin/repos","events_url":"https://api.github.com/users/xamarin/events{/privacy}","received_events_url":"https://api.github.com/users/xamarin/received_events","type":"Organization","site_admin":false},"repo":{"id":55075302,"name":"xamarin-android","full_name":"xamarin/xamarin-android","owner":{"login":"xamarin","id":790012,"avatar_url":"https://avatars.githubusercontent.com/u/790012?v=3","gravatar_id":"","url":"https://api.github.com/users/xamarin","html_url":"https://github.com/xamarin","followers_url":"https://api.github.com/users/xamarin/followers","following_url":"https://api.github.com/users/xamarin/following{/other_user}","gists_url":"https://api.github.com/users/xamarin/gists{/gist_id}","starred_url":"https://api.github.com/users/xamarin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xamarin/subscriptions","organizations_url":"https://api.github.com/users/xamarin/orgs","repos_url":"https://api.github.com/users/xamarin/repos","events_url":"https://api.github.com/users/xamarin/events{/privacy}","received_events_url":"https://api.github.com/users/xamarin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xamarin/xamarin-android","description":null,"fork":false,"url":"https://api.github.com/repos/xamarin/xamarin-android","forks_url":"https://api.github.com/repos/xamarin/xamarin-android/forks","keys_url":"https://api.github.com/repos/xamarin/xamarin-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xamarin/xamarin-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xamarin/xamarin-android/teams","hooks_url":"https://api.github.com/repos/xamarin/xamarin-android/hooks","issue_events_url":"https://api.github.com/repos/xamarin/xamarin-android/issues/events{/number}","events_url":"https://api.github.com/repos/xamarin/xamarin-android/events","assignees_url":"https://api.github.com/repos/xamarin/xamarin-android/assignees{/user}","branches_url":"https://api.github.com/repos/xamarin/xamarin-android/branches{/branch}","tags_url":"https://api.github.com/repos/xamarin/xamarin-android/tags","blobs_url":"https://api.github.com/repos/xamarin/xamarin-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xamarin/xamarin-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xamarin/xamarin-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/xamarin/xamarin-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xamarin/xamarin-android/statuses/{sha}","languages_url":"https://api.github.com/repos/xamarin/xamarin-android/languages","stargazers_url":"https://api.github.com/repos/xamarin/xamarin-android/stargazers","contributors_url":"https://api.github.com/repos/xamarin/xamarin-android/contributors","subscribers_url":"https://api.github.com/repos/xamarin/xamarin-android/subscribers","subscription_url":"https://api.github.com/repos/xamarin/xamarin-android/subscription","commits_url":"https://api.github.com/repos/xamarin/xamarin-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/xamarin/xamarin-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/xamarin/xamarin-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/xamarin/xamarin-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/xamarin/xamarin-android/contents/{+path}","compare_url":"https://api.github.com/repos/xamarin/xamarin-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xamarin/xamarin-android/merges","archive_url":"https://api.github.com/repos/xamarin/xamarin-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xamarin/xamarin-android/downloads","issues_url":"https://api.github.com/repos/xamarin/xamarin-android/issues{/number}","pulls_url":"https://api.github.com/repos/xamarin/xamarin-android/pulls{/number}","milestones_url":"https://api.github.com/repos/xamarin/xamarin-android/milestones{/number}","notifications_url":"https://api.github.com/repos/xamarin/xamarin-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xamarin/xamarin-android/labels{/name}","releases_url":"https://api.github.com/repos/xamarin/xamarin-android/releases{/id}","deployments_url":"https://api.github.com/repos/xamarin/xamarin-android/deployments","created_at":"2016-03-30T15:37:14Z","updated_at":"2016-11-05T19:55:19Z","pushed_at":"2016-11-09T11:33:07Z","git_url":"git://github.com/xamarin/xamarin-android.git","ssh_url":"git@github.com:xamarin/xamarin-android.git","clone_url":"https://github.com/xamarin/xamarin-android.git","svn_url":"https://github.com/xamarin/xamarin-android","homepage":null,"size":6526,"stargazers_count":635,"watchers_count":635,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":157,"mirror_url":null,"open_issues_count":10,"forks":157,"open_issues":10,"watchers":635,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xamarin/xamarin-android/pulls/287"},"html":{"href":"https://github.com/xamarin/xamarin-android/pull/287"},"issue":{"href":"https://api.github.com/repos/xamarin/xamarin-android/issues/287"},"comments":{"href":"https://api.github.com/repos/xamarin/xamarin-android/issues/287/comments"},"review_comments":{"href":"https://api.github.com/repos/xamarin/xamarin-android/pulls/287/comments"},"review_comment":{"href":"https://api.github.com/repos/xamarin/xamarin-android/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xamarin/xamarin-android/pulls/287/commits"},"statuses":{"href":"https://api.github.com/repos/xamarin/xamarin-android/statuses/a7436d651d7a039ff7bea1b3ea5ae798911a3ece"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"jonpryor"}}