{"action":"created","comment":{"url":"https://api.github.com/repos/nirizr/rematch/pulls/comments/88938093","pull_request_review_id":9493971,"id":88938093,"diff_hunk":"@@ -111,15 +113,18 @@ def query(method, url, server=None, token=None, params=None, json=False):\n def get_server(server):\n   \"\"\"getting and finalzing server address\"\"\"\n \n-  if not server:\n-    if 'server' not in config or not config['server']:\n+  try:\n+   if not server:\n+    if 'server' not in config and not config['login']['server']:\n       raise exceptions.QueryException()\n-    server = config['server']\n-  if not (server.startswith(\"http://\") or server.startswith(\"http://\")):\n-    server = \"http://\" + server\n-  if not server.endswith(\"/\"):\n-    server = server + \"/\"\n-\n+    server = config['login']['server']\n+   if not (server.startswith(\"http://\") or server.startswith(\"http://\")):\n+     server = \"http://\" + server\n+   if not server.endswith(\"/\"):\n+     server = server + \"/\"\n+  except Exception as e:\n+    import traceback\n+    logger.network('network').error(traceback.print_exc())","path":"idaplugin/rematch/network.py","position":48,"original_position":48,"commit_id":"889672fe43b542985437511c94fd85e5d34d0176","original_commit_id":"889672fe43b542985437511c94fd85e5d34d0176","user":{"login":"shiftre","id":303679,"avatar_url":"https://avatars.githubusercontent.com/u/303679?v=3","gravatar_id":"","url":"https://api.github.com/users/shiftre","html_url":"https://github.com/shiftre","followers_url":"https://api.github.com/users/shiftre/followers","following_url":"https://api.github.com/users/shiftre/following{/other_user}","gists_url":"https://api.github.com/users/shiftre/gists{/gist_id}","starred_url":"https://api.github.com/users/shiftre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shiftre/subscriptions","organizations_url":"https://api.github.com/users/shiftre/orgs","repos_url":"https://api.github.com/users/shiftre/repos","events_url":"https://api.github.com/users/shiftre/events{/privacy}","received_events_url":"https://api.github.com/users/shiftre/received_events","type":"User","site_admin":false},"body":"Yes.","created_at":"2016-11-21T16:54:09Z","updated_at":"2016-11-21T16:54:09Z","html_url":"https://github.com/nirizr/rematch/pull/117#discussion_r88938093","pull_request_url":"https://api.github.com/repos/nirizr/rematch/pulls/117","_links":{"self":{"href":"https://api.github.com/repos/nirizr/rematch/pulls/comments/88938093"},"html":{"href":"https://github.com/nirizr/rematch/pull/117#discussion_r88938093"},"pull_request":{"href":"https://api.github.com/repos/nirizr/rematch/pulls/117"}}},"pull_request":{"url":"https://api.github.com/repos/nirizr/rematch/pulls/117","id":93676202,"html_url":"https://github.com/nirizr/rematch/pull/117","diff_url":"https://github.com/nirizr/rematch/pull/117.diff","patch_url":"https://github.com/nirizr/rematch/pull/117.patch","issue_url":"https://api.github.com/repos/nirizr/rematch/issues/117","number":117,"state":"open","locked":false,"title":"Guy/fix login config","user":{"login":"shiftre","id":303679,"avatar_url":"https://avatars.githubusercontent.com/u/303679?v=3","gravatar_id":"","url":"https://api.github.com/users/shiftre","html_url":"https://github.com/shiftre","followers_url":"https://api.github.com/users/shiftre/followers","following_url":"https://api.github.com/users/shiftre/following{/other_user}","gists_url":"https://api.github.com/users/shiftre/gists{/gist_id}","starred_url":"https://api.github.com/users/shiftre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shiftre/subscriptions","organizations_url":"https://api.github.com/users/shiftre/orgs","repos_url":"https://api.github.com/users/shiftre/repos","events_url":"https://api.github.com/users/shiftre/events{/privacy}","received_events_url":"https://api.github.com/users/shiftre/received_events","type":"User","site_admin":false},"body":"During a clean install of REmatch, REmatch just doesn't work.\r\n\r\nIt started off simply by adding the right dict key ( [\"login\"][\"username\"] ), but for some reason many things do not work now:\r\n\r\n- [x] \"Bind current project\" which consists of netnode  work.\r\n- [x] Make user.py more aware whether it has anything configured or not.\r\n- [x] \"Make coday / flake not complain about the re-import of Config during exception.\r\n- [ ] Make codacy scoring great again.\r\n- [x] Remember to add full stops at the end of the sentence.\r\n\r\nCurrent fix is hackish.\r\nWIP\r\n\r\nI added default values to the config.py to write them if the config doesn't exist.\r\nHowever, if the server doesn't exist yet ,(doesn't respond), the dialogs won't load, this is \r\na partially different issue which must be addressed.","created_at":"2016-11-15T00:20:41Z","updated_at":"2016-11-21T16:55:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6985e036308de3dbbcfc33df7765df18f4664955","assignee":{"login":"shiftre","id":303679,"avatar_url":"https://avatars.githubusercontent.com/u/303679?v=3","gravatar_id":"","url":"https://api.github.com/users/shiftre","html_url":"https://github.com/shiftre","followers_url":"https://api.github.com/users/shiftre/followers","following_url":"https://api.github.com/users/shiftre/following{/other_user}","gists_url":"https://api.github.com/users/shiftre/gists{/gist_id}","starred_url":"https://api.github.com/users/shiftre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shiftre/subscriptions","organizations_url":"https://api.github.com/users/shiftre/orgs","repos_url":"https://api.github.com/users/shiftre/repos","events_url":"https://api.github.com/users/shiftre/events{/privacy}","received_events_url":"https://api.github.com/users/shiftre/received_events","type":"User","site_admin":false},"assignees":[{"login":"shiftre","id":303679,"avatar_url":"https://avatars.githubusercontent.com/u/303679?v=3","gravatar_id":"","url":"https://api.github.com/users/shiftre","html_url":"https://github.com/shiftre","followers_url":"https://api.github.com/users/shiftre/followers","following_url":"https://api.github.com/users/shiftre/following{/other_user}","gists_url":"https://api.github.com/users/shiftre/gists{/gist_id}","starred_url":"https://api.github.com/users/shiftre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shiftre/subscriptions","organizations_url":"https://api.github.com/users/shiftre/orgs","repos_url":"https://api.github.com/users/shiftre/repos","events_url":"https://api.github.com/users/shiftre/events{/privacy}","received_events_url":"https://api.github.com/users/shiftre/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/nirizr/rematch/pulls/117/commits","review_comments_url":"https://api.github.com/repos/nirizr/rematch/pulls/117/comments","review_comment_url":"https://api.github.com/repos/nirizr/rematch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nirizr/rematch/issues/117/comments","statuses_url":"https://api.github.com/repos/nirizr/rematch/statuses/889672fe43b542985437511c94fd85e5d34d0176","head":{"label":"nirizr:guy/fix_login_config","ref":"guy/fix_login_config","sha":"889672fe43b542985437511c94fd85e5d34d0176","user":{"login":"nirizr","id":3631703,"avatar_url":"https://avatars.githubusercontent.com/u/3631703?v=3","gravatar_id":"","url":"https://api.github.com/users/nirizr","html_url":"https://github.com/nirizr","followers_url":"https://api.github.com/users/nirizr/followers","following_url":"https://api.github.com/users/nirizr/following{/other_user}","gists_url":"https://api.github.com/users/nirizr/gists{/gist_id}","starred_url":"https://api.github.com/users/nirizr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nirizr/subscriptions","organizations_url":"https://api.github.com/users/nirizr/orgs","repos_url":"https://api.github.com/users/nirizr/repos","events_url":"https://api.github.com/users/nirizr/events{/privacy}","received_events_url":"https://api.github.com/users/nirizr/received_events","type":"User","site_admin":false},"repo":{"id":65547773,"name":"rematch","full_name":"nirizr/rematch","owner":{"login":"nirizr","id":3631703,"avatar_url":"https://avatars.githubusercontent.com/u/3631703?v=3","gravatar_id":"","url":"https://api.github.com/users/nirizr","html_url":"https://github.com/nirizr","followers_url":"https://api.github.com/users/nirizr/followers","following_url":"https://api.github.com/users/nirizr/following{/other_user}","gists_url":"https://api.github.com/users/nirizr/gists{/gist_id}","starred_url":"https://api.github.com/users/nirizr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nirizr/subscriptions","organizations_url":"https://api.github.com/users/nirizr/orgs","repos_url":"https://api.github.com/users/nirizr/repos","events_url":"https://api.github.com/users/nirizr/events{/privacy}","received_events_url":"https://api.github.com/users/nirizr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nirizr/rematch","description":"REmatch, a simple binary diffing utility that just works.","fork":false,"url":"https://api.github.com/repos/nirizr/rematch","forks_url":"https://api.github.com/repos/nirizr/rematch/forks","keys_url":"https://api.github.com/repos/nirizr/rematch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nirizr/rematch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nirizr/rematch/teams","hooks_url":"https://api.github.com/repos/nirizr/rematch/hooks","issue_events_url":"https://api.github.com/repos/nirizr/rematch/issues/events{/number}","events_url":"https://api.github.com/repos/nirizr/rematch/events","assignees_url":"https://api.github.com/repos/nirizr/rematch/assignees{/user}","branches_url":"https://api.github.com/repos/nirizr/rematch/branches{/branch}","tags_url":"https://api.github.com/repos/nirizr/rematch/tags","blobs_url":"https://api.github.com/repos/nirizr/rematch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nirizr/rematch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nirizr/rematch/git/refs{/sha}","trees_url":"https://api.github.com/repos/nirizr/rematch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nirizr/rematch/statuses/{sha}","languages_url":"https://api.github.com/repos/nirizr/rematch/languages","stargazers_url":"https://api.github.com/repos/nirizr/rematch/stargazers","contributors_url":"https://api.github.com/repos/nirizr/rematch/contributors","subscribers_url":"https://api.github.com/repos/nirizr/rematch/subscribers","subscription_url":"https://api.github.com/repos/nirizr/rematch/subscription","commits_url":"https://api.github.com/repos/nirizr/rematch/commits{/sha}","git_commits_url":"https://api.github.com/repos/nirizr/rematch/git/commits{/sha}","comments_url":"https://api.github.com/repos/nirizr/rematch/comments{/number}","issue_comment_url":"https://api.github.com/repos/nirizr/rematch/issues/comments{/number}","contents_url":"https://api.github.com/repos/nirizr/rematch/contents/{+path}","compare_url":"https://api.github.com/repos/nirizr/rematch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nirizr/rematch/merges","archive_url":"https://api.github.com/repos/nirizr/rematch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nirizr/rematch/downloads","issues_url":"https://api.github.com/repos/nirizr/rematch/issues{/number}","pulls_url":"https://api.github.com/repos/nirizr/rematch/pulls{/number}","milestones_url":"https://api.github.com/repos/nirizr/rematch/milestones{/number}","notifications_url":"https://api.github.com/repos/nirizr/rematch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nirizr/rematch/labels{/name}","releases_url":"https://api.github.com/repos/nirizr/rematch/releases{/id}","deployments_url":"https://api.github.com/repos/nirizr/rematch/deployments","created_at":"2016-08-12T11:15:44Z","updated_at":"2016-10-30T00:47:49Z","pushed_at":"2016-11-21T16:49:33Z","git_url":"git://github.com/nirizr/rematch.git","ssh_url":"git@github.com:nirizr/rematch.git","clone_url":"https://github.com/nirizr/rematch.git","svn_url":"https://github.com/nirizr/rematch","homepage":"","size":332,"stargazers_count":4,"watchers_count":4,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":35,"forks":2,"open_issues":35,"watchers":4,"default_branch":"master"}},"base":{"label":"nirizr:master","ref":"master","sha":"f01ce4fad7770e11849bc59e647a25fdc282e9e1","user":{"login":"nirizr","id":3631703,"avatar_url":"https://avatars.githubusercontent.com/u/3631703?v=3","gravatar_id":"","url":"https://api.github.com/users/nirizr","html_url":"https://github.com/nirizr","followers_url":"https://api.github.com/users/nirizr/followers","following_url":"https://api.github.com/users/nirizr/following{/other_user}","gists_url":"https://api.github.com/users/nirizr/gists{/gist_id}","starred_url":"https://api.github.com/users/nirizr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nirizr/subscriptions","organizations_url":"https://api.github.com/users/nirizr/orgs","repos_url":"https://api.github.com/users/nirizr/repos","events_url":"https://api.github.com/users/nirizr/events{/privacy}","received_events_url":"https://api.github.com/users/nirizr/received_events","type":"User","site_admin":false},"repo":{"id":65547773,"name":"rematch","full_name":"nirizr/rematch","owner":{"login":"nirizr","id":3631703,"avatar_url":"https://avatars.githubusercontent.com/u/3631703?v=3","gravatar_id":"","url":"https://api.github.com/users/nirizr","html_url":"https://github.com/nirizr","followers_url":"https://api.github.com/users/nirizr/followers","following_url":"https://api.github.com/users/nirizr/following{/other_user}","gists_url":"https://api.github.com/users/nirizr/gists{/gist_id}","starred_url":"https://api.github.com/users/nirizr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nirizr/subscriptions","organizations_url":"https://api.github.com/users/nirizr/orgs","repos_url":"https://api.github.com/users/nirizr/repos","events_url":"https://api.github.com/users/nirizr/events{/privacy}","received_events_url":"https://api.github.com/users/nirizr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nirizr/rematch","description":"REmatch, a simple binary diffing utility that just works.","fork":false,"url":"https://api.github.com/repos/nirizr/rematch","forks_url":"https://api.github.com/repos/nirizr/rematch/forks","keys_url":"https://api.github.com/repos/nirizr/rematch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nirizr/rematch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nirizr/rematch/teams","hooks_url":"https://api.github.com/repos/nirizr/rematch/hooks","issue_events_url":"https://api.github.com/repos/nirizr/rematch/issues/events{/number}","events_url":"https://api.github.com/repos/nirizr/rematch/events","assignees_url":"https://api.github.com/repos/nirizr/rematch/assignees{/user}","branches_url":"https://api.github.com/repos/nirizr/rematch/branches{/branch}","tags_url":"https://api.github.com/repos/nirizr/rematch/tags","blobs_url":"https://api.github.com/repos/nirizr/rematch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nirizr/rematch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nirizr/rematch/git/refs{/sha}","trees_url":"https://api.github.com/repos/nirizr/rematch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nirizr/rematch/statuses/{sha}","languages_url":"https://api.github.com/repos/nirizr/rematch/languages","stargazers_url":"https://api.github.com/repos/nirizr/rematch/stargazers","contributors_url":"https://api.github.com/repos/nirizr/rematch/contributors","subscribers_url":"https://api.github.com/repos/nirizr/rematch/subscribers","subscription_url":"https://api.github.com/repos/nirizr/rematch/subscription","commits_url":"https://api.github.com/repos/nirizr/rematch/commits{/sha}","git_commits_url":"https://api.github.com/repos/nirizr/rematch/git/commits{/sha}","comments_url":"https://api.github.com/repos/nirizr/rematch/comments{/number}","issue_comment_url":"https://api.github.com/repos/nirizr/rematch/issues/comments{/number}","contents_url":"https://api.github.com/repos/nirizr/rematch/contents/{+path}","compare_url":"https://api.github.com/repos/nirizr/rematch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nirizr/rematch/merges","archive_url":"https://api.github.com/repos/nirizr/rematch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nirizr/rematch/downloads","issues_url":"https://api.github.com/repos/nirizr/rematch/issues{/number}","pulls_url":"https://api.github.com/repos/nirizr/rematch/pulls{/number}","milestones_url":"https://api.github.com/repos/nirizr/rematch/milestones{/number}","notifications_url":"https://api.github.com/repos/nirizr/rematch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nirizr/rematch/labels{/name}","releases_url":"https://api.github.com/repos/nirizr/rematch/releases{/id}","deployments_url":"https://api.github.com/repos/nirizr/rematch/deployments","created_at":"2016-08-12T11:15:44Z","updated_at":"2016-10-30T00:47:49Z","pushed_at":"2016-11-21T16:49:33Z","git_url":"git://github.com/nirizr/rematch.git","ssh_url":"git@github.com:nirizr/rematch.git","clone_url":"https://github.com/nirizr/rematch.git","svn_url":"https://github.com/nirizr/rematch","homepage":"","size":332,"stargazers_count":4,"watchers_count":4,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":35,"forks":2,"open_issues":35,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nirizr/rematch/pulls/117"},"html":{"href":"https://github.com/nirizr/rematch/pull/117"},"issue":{"href":"https://api.github.com/repos/nirizr/rematch/issues/117"},"comments":{"href":"https://api.github.com/repos/nirizr/rematch/issues/117/comments"},"review_comments":{"href":"https://api.github.com/repos/nirizr/rematch/pulls/117/comments"},"review_comment":{"href":"https://api.github.com/repos/nirizr/rematch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nirizr/rematch/pulls/117/commits"},"statuses":{"href":"https://api.github.com/repos/nirizr/rematch/statuses/889672fe43b542985437511c94fd85e5d34d0176"}}}}
{"actor":{"display_login":"shiftre"}}