{"action":"created","issue":{"url":"https://api.github.com/repos/vufind-org/vufind/issues/722","repository_url":"https://api.github.com/repos/vufind-org/vufind","labels_url":"https://api.github.com/repos/vufind-org/vufind/issues/722/labels{/name}","comments_url":"https://api.github.com/repos/vufind-org/vufind/issues/722/comments","events_url":"https://api.github.com/repos/vufind-org/vufind/issues/722/events","html_url":"https://github.com/vufind-org/vufind/pull/722","id":159802064,"number":722,"title":"Geographic search and display","user":{"login":"lmgonzales","id":13055057,"avatar_url":"https://avatars.githubusercontent.com/u/13055057?v=3","gravatar_id":"","url":"https://api.github.com/users/lmgonzales","html_url":"https://github.com/lmgonzales","followers_url":"https://api.github.com/users/lmgonzales/followers","following_url":"https://api.github.com/users/lmgonzales/following{/other_user}","gists_url":"https://api.github.com/users/lmgonzales/gists{/gist_id}","starred_url":"https://api.github.com/users/lmgonzales/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lmgonzales/subscriptions","organizations_url":"https://api.github.com/users/lmgonzales/orgs","repos_url":"https://api.github.com/users/lmgonzales/repos","events_url":"https://api.github.com/users/lmgonzales/events{/privacy}","received_events_url":"https://api.github.com/users/lmgonzales/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/vufind-org/vufind/labels/new%20feature","name":"new feature","color":"c5def5"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/vufind-org/vufind/milestones/2","html_url":"https://github.com/vufind-org/vufind/milestones/3.1","labels_url":"https://api.github.com/repos/vufind-org/vufind/milestones/2/labels","id":1739037,"number":2,"title":"3.1","description":"","creator":{"login":"crhallberg","id":451107,"avatar_url":"https://avatars.githubusercontent.com/u/451107?v=3","gravatar_id":"","url":"https://api.github.com/users/crhallberg","html_url":"https://github.com/crhallberg","followers_url":"https://api.github.com/users/crhallberg/followers","following_url":"https://api.github.com/users/crhallberg/following{/other_user}","gists_url":"https://api.github.com/users/crhallberg/gists{/gist_id}","starred_url":"https://api.github.com/users/crhallberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crhallberg/subscriptions","organizations_url":"https://api.github.com/users/crhallberg/orgs","repos_url":"https://api.github.com/users/crhallberg/repos","events_url":"https://api.github.com/users/crhallberg/events{/privacy}","received_events_url":"https://api.github.com/users/crhallberg/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":11,"state":"open","created_at":"2016-04-29T17:31:54Z","updated_at":"2016-09-15T16:45:21Z","due_on":"2016-09-26T04:00:00Z","closed_at":null},"comments":121,"created_at":"2016-06-12T01:31:29Z","updated_at":"2016-09-16T17:55:50Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/vufind-org/vufind/pulls/722","html_url":"https://github.com/vufind-org/vufind/pull/722","diff_url":"https://github.com/vufind-org/vufind/pull/722.diff","patch_url":"https://github.com/vufind-org/vufind/pull/722.patch"},"body":"**Notes:** \r\n- Geographic search code was based on Moravian Library/ Vaclay Rozceky code implementation (OpenLayers2 and Solr 4.) \r\n- Records can have multiple coordinate sets that are either points or rectangles. \r\n- All coordinates are stored and queried as WENS. \r\n- For display of geographic features in OpenLayers3, coordinates must be ordered as WSEN.\r\n- OpenLayers3 has a bug that causes polygons smaller than .4 decimal degrees to appear/disappear if they are located very far apart. The workaround implemented in this code displays any coordinates sets  as a point where N-S < 0.4 decimal degrees and E-W < 0.4 decimal degrees. \r\n- Point coordinates have coordinate values that match W to E and N to S. \r\n- Lat/Lon values are stored to the latlon_coordinate field. \r\n- Decimal degrees values are stored to the bbox_geo field. \r\n\r\n**To Do List**\r\n- [x] Update searches.ini comments to describe new module.\r\n- [x] Decide whether/how to save old Google-based functionality. NOTE:  Opted to save it. \r\n- [x] Display search results on map if the number of results is below a certain threshold or look into OpenLayers3 clustering of results so that all results could feasibly be displayed in a clustered fashion. \r\n- [x] Fix ESLint style issues\r\n- [x] Re-write indexing and getter methods to handle a universal set of fields for geographic coordinate and associated data so that either Google or OpenLayers can be used for the Map Tab.\r\n- [x] Convert BeanShell to Java and include in SolrMarc.\r\n- [x] Upgrade SolrMarc in master before merging.\r\n- [x] Internationalization: make pop-up alert help box in Geographic Search utilize standard help system; make sure that all new text strings are included in language files and subject to translation. \r\n- [ ] Internationalization of Javascript (\"Records at this location:\" should use existing \"map_results_label\" label)."},"comment":{"url":"https://api.github.com/repos/vufind-org/vufind/issues/comments/247665648","html_url":"https://github.com/vufind-org/vufind/pull/722#issuecomment-247665648","issue_url":"https://api.github.com/repos/vufind-org/vufind/issues/722","id":247665648,"user":{"login":"demiankatz","id":309069,"avatar_url":"https://avatars.githubusercontent.com/u/309069?v=3","gravatar_id":"","url":"https://api.github.com/users/demiankatz","html_url":"https://github.com/demiankatz","followers_url":"https://api.github.com/users/demiankatz/followers","following_url":"https://api.github.com/users/demiankatz/following{/other_user}","gists_url":"https://api.github.com/users/demiankatz/gists{/gist_id}","starred_url":"https://api.github.com/users/demiankatz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/demiankatz/subscriptions","organizations_url":"https://api.github.com/users/demiankatz/orgs","repos_url":"https://api.github.com/users/demiankatz/repos","events_url":"https://api.github.com/users/demiankatz/events{/privacy}","received_events_url":"https://api.github.com/users/demiankatz/received_events","type":"User","site_admin":false},"created_at":"2016-09-16T17:55:50Z","updated_at":"2016-09-16T17:55:50Z","body":"@lmgonzales, thanks a lot! I'll give this a closer look on Monday. If nothing new comes up in the way of problems, I think we'll be able to merge it."}}
{"actor":{"display_login":"demiankatz"}}