{"action":"created","issue":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/11778","repository_url":"https://api.github.com/repos/cockroachdb/cockroach","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/11778/labels{/name}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/11778/comments","events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/11778/events","html_url":"https://github.com/cockroachdb/cockroach/pull/11778","id":193134129,"number":11778,"title":"util/log: various micro optimizations to log tags","user":{"login":"petermattis","id":6201335,"avatar_url":"https://avatars.githubusercontent.com/u/6201335?v=3","gravatar_id":"","url":"https://api.github.com/users/petermattis","html_url":"https://github.com/petermattis","followers_url":"https://api.github.com/users/petermattis/followers","following_url":"https://api.github.com/users/petermattis/following{/other_user}","gists_url":"https://api.github.com/users/petermattis/gists{/gist_id}","starred_url":"https://api.github.com/users/petermattis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petermattis/subscriptions","organizations_url":"https://api.github.com/users/petermattis/orgs","repos_url":"https://api.github.com/users/petermattis/repos","events_url":"https://api.github.com/users/petermattis/events{/privacy}","received_events_url":"https://api.github.com/users/petermattis/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"RaduBerinde","id":16544120,"avatar_url":"https://avatars.githubusercontent.com/u/16544120?v=3","gravatar_id":"","url":"https://api.github.com/users/RaduBerinde","html_url":"https://github.com/RaduBerinde","followers_url":"https://api.github.com/users/RaduBerinde/followers","following_url":"https://api.github.com/users/RaduBerinde/following{/other_user}","gists_url":"https://api.github.com/users/RaduBerinde/gists{/gist_id}","starred_url":"https://api.github.com/users/RaduBerinde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RaduBerinde/subscriptions","organizations_url":"https://api.github.com/users/RaduBerinde/orgs","repos_url":"https://api.github.com/users/RaduBerinde/repos","events_url":"https://api.github.com/users/RaduBerinde/events{/privacy}","received_events_url":"https://api.github.com/users/RaduBerinde/received_events","type":"User","site_admin":false},"assignees":[{"login":"RaduBerinde","id":16544120,"avatar_url":"https://avatars.githubusercontent.com/u/16544120?v=3","gravatar_id":"","url":"https://api.github.com/users/RaduBerinde","html_url":"https://github.com/RaduBerinde","followers_url":"https://api.github.com/users/RaduBerinde/followers","following_url":"https://api.github.com/users/RaduBerinde/following{/other_user}","gists_url":"https://api.github.com/users/RaduBerinde/gists{/gist_id}","starred_url":"https://api.github.com/users/RaduBerinde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RaduBerinde/subscriptions","organizations_url":"https://api.github.com/users/RaduBerinde/orgs","repos_url":"https://api.github.com/users/RaduBerinde/repos","events_url":"https://api.github.com/users/RaduBerinde/events{/privacy}","received_events_url":"https://api.github.com/users/RaduBerinde/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2016-12-02T14:51:31Z","updated_at":"2016-12-02T15:17:23Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/11778","html_url":"https://github.com/cockroachdb/cockroach/pull/11778","diff_url":"https://github.com/cockroachdb/cockroach/pull/11778.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/11778.patch"},"body":"Remove log.Events from RangeIterator and RangeCache that were\nrepetitive, mildly expensive and not terribly interesting: logging an\nevent on each iteration of range lookup and logging an event when we\nfound a range in the cache.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/cockroachdb/cockroach/11778)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments/264477492","html_url":"https://github.com/cockroachdb/cockroach/pull/11778#issuecomment-264477492","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/11778","id":264477492,"user":{"login":"petermattis","id":6201335,"avatar_url":"https://avatars.githubusercontent.com/u/6201335?v=3","gravatar_id":"","url":"https://api.github.com/users/petermattis","html_url":"https://github.com/petermattis","followers_url":"https://api.github.com/users/petermattis/followers","following_url":"https://api.github.com/users/petermattis/following{/other_user}","gists_url":"https://api.github.com/users/petermattis/gists{/gist_id}","starred_url":"https://api.github.com/users/petermattis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petermattis/subscriptions","organizations_url":"https://api.github.com/users/petermattis/orgs","repos_url":"https://api.github.com/users/petermattis/repos","events_url":"https://api.github.com/users/petermattis/events{/privacy}","received_events_url":"https://api.github.com/users/petermattis/received_events","type":"User","site_admin":false},"created_at":"2016-12-02T15:17:23Z","updated_at":"2016-12-02T15:17:23Z","body":"\n\n\n\nReview status: 0 of 4 files reviewed at latest revision, 1 unresolved discussion.\n\n---\n\n*[pkg/util/log/log_context.go, line 53 at r1](https://reviewable.io:443/reviews/cockroachdb/cockroach/11778#-KY-1zh-tW_SgoWc8Sjl:-KY-5yF5HLZRR1ShB9cK:b-896fix) ([raw file](https://github.com/cockroachdb/cockroach/blob/3b4821b38f808bc04e238d31fbff5106be28edc8/pkg/util/log/log_context.go#L53)):*\n<details><summary><i>Previously, RaduBerinde wrote…</i></summary><blockquote>\n\ncan you add a comment (sorry, I realize I didn't either haha), maybe\n// contextLogTags returns the tags in the context in order. The given tags buffer is potentially used to avoid allocations.\n</blockquote></details>\n\nDone.\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/cockroachdb/cockroach/11778)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"petermattis"}}