{"action":"created","comment":{"url":"https://api.github.com/repos/collectd/collectd/pulls/comments/74436989","id":74436989,"diff_hunk":"@@ -1014,6 +1091,8 @@ static int mysql_read (user_data_t *ud)\n \n \t\tgauge_submit (\"cache_size\", \"qcache\",\n \t\t\t\tqcache_queries_in_cache, db);\n+ \t\tgauge_submit (\"cache_queries\", \"qcache-free-memory\",","path":"src/mysql.c","position":109,"original_position":109,"commit_id":"298b235e52ae98e89e0a41a7b3b7b4a14e14dcb8","original_commit_id":"e903e45ca8c3511bb828e021a1407cd0447aa0d9","user":{"login":"octo","id":116087,"avatar_url":"https://avatars.githubusercontent.com/u/116087?v=3","gravatar_id":"","url":"https://api.github.com/users/octo","html_url":"https://github.com/octo","followers_url":"https://api.github.com/users/octo/followers","following_url":"https://api.github.com/users/octo/following{/other_user}","gists_url":"https://api.github.com/users/octo/gists{/gist_id}","starred_url":"https://api.github.com/users/octo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/octo/subscriptions","organizations_url":"https://api.github.com/users/octo/orgs","repos_url":"https://api.github.com/users/octo/repos","events_url":"https://api.github.com/users/octo/events{/privacy}","received_events_url":"https://api.github.com/users/octo/received_events","type":"User","site_admin":false},"body":"The *memory* type is for bytes held in memory, which is *exactly* what this metric is afaIk. If you're afraid that this might clash with memory metrics that are not related to the query cache, let's use the *type instance* \"qcache-free\".\r\n\r\nAdding a new type \"cache_memory\" is not justified.","created_at":"2016-08-11T14:52:14Z","updated_at":"2016-08-11T14:52:14Z","html_url":"https://github.com/collectd/collectd/pull/1849#discussion_r74436989","pull_request_url":"https://api.github.com/repos/collectd/collectd/pulls/1849","_links":{"self":{"href":"https://api.github.com/repos/collectd/collectd/pulls/comments/74436989"},"html":{"href":"https://github.com/collectd/collectd/pull/1849#discussion_r74436989"},"pull_request":{"href":"https://api.github.com/repos/collectd/collectd/pulls/1849"}}},"pull_request":{"url":"https://api.github.com/repos/collectd/collectd/pulls/1849","id":80244022,"html_url":"https://github.com/collectd/collectd/pull/1849","diff_url":"https://github.com/collectd/collectd/pull/1849.diff","patch_url":"https://github.com/collectd/collectd/pull/1849.patch","issue_url":"https://api.github.com/repos/collectd/collectd/issues/1849","number":1849,"state":"open","locked":false,"title":"mysql plugin: extend global status metrics","user":{"login":"xinity","id":1799009,"avatar_url":"https://avatars.githubusercontent.com/u/1799009?v=3","gravatar_id":"","url":"https://api.github.com/users/xinity","html_url":"https://github.com/xinity","followers_url":"https://api.github.com/users/xinity/followers","following_url":"https://api.github.com/users/xinity/following{/other_user}","gists_url":"https://api.github.com/users/xinity/gists{/gist_id}","starred_url":"https://api.github.com/users/xinity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xinity/subscriptions","organizations_url":"https://api.github.com/users/xinity/orgs","repos_url":"https://api.github.com/users/xinity/repos","events_url":"https://api.github.com/users/xinity/events{/privacy}","received_events_url":"https://api.github.com/users/xinity/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-08-05T13:35:31Z","updated_at":"2016-08-11T14:52:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"54afdbafe463e0a85965f2073db38498957332c0","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/collectd/collectd/milestones/5","html_url":"https://github.com/collectd/collectd/milestones/Features","labels_url":"https://api.github.com/repos/collectd/collectd/milestones/5/labels","id":220922,"number":5,"title":"Features","description":"This \"milestone\" is used for new features, i.e. changes that should go into a feature release.","creator":{"login":"octo","id":116087,"avatar_url":"https://avatars.githubusercontent.com/u/116087?v=3","gravatar_id":"","url":"https://api.github.com/users/octo","html_url":"https://github.com/octo","followers_url":"https://api.github.com/users/octo/followers","following_url":"https://api.github.com/users/octo/following{/other_user}","gists_url":"https://api.github.com/users/octo/gists{/gist_id}","starred_url":"https://api.github.com/users/octo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/octo/subscriptions","organizations_url":"https://api.github.com/users/octo/orgs","repos_url":"https://api.github.com/users/octo/repos","events_url":"https://api.github.com/users/octo/events{/privacy}","received_events_url":"https://api.github.com/users/octo/received_events","type":"User","site_admin":false},"open_issues":92,"closed_issues":137,"state":"open","created_at":"2012-11-29T06:44:37Z","updated_at":"2016-08-09T19:47:53Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/collectd/collectd/pulls/1849/commits","review_comments_url":"https://api.github.com/repos/collectd/collectd/pulls/1849/comments","review_comment_url":"https://api.github.com/repos/collectd/collectd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/collectd/collectd/issues/1849/comments","statuses_url":"https://api.github.com/repos/collectd/collectd/statuses/298b235e52ae98e89e0a41a7b3b7b4a14e14dcb8","head":{"label":"xinity:mysql55_global_status","ref":"mysql55_global_status","sha":"298b235e52ae98e89e0a41a7b3b7b4a14e14dcb8","user":{"login":"xinity","id":1799009,"avatar_url":"https://avatars.githubusercontent.com/u/1799009?v=3","gravatar_id":"","url":"https://api.github.com/users/xinity","html_url":"https://github.com/xinity","followers_url":"https://api.github.com/users/xinity/followers","following_url":"https://api.github.com/users/xinity/following{/other_user}","gists_url":"https://api.github.com/users/xinity/gists{/gist_id}","starred_url":"https://api.github.com/users/xinity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xinity/subscriptions","organizations_url":"https://api.github.com/users/xinity/orgs","repos_url":"https://api.github.com/users/xinity/repos","events_url":"https://api.github.com/users/xinity/events{/privacy}","received_events_url":"https://api.github.com/users/xinity/received_events","type":"User","site_admin":false},"repo":{"id":63535408,"name":"collectd","full_name":"xinity/collectd","owner":{"login":"xinity","id":1799009,"avatar_url":"https://avatars.githubusercontent.com/u/1799009?v=3","gravatar_id":"","url":"https://api.github.com/users/xinity","html_url":"https://github.com/xinity","followers_url":"https://api.github.com/users/xinity/followers","following_url":"https://api.github.com/users/xinity/following{/other_user}","gists_url":"https://api.github.com/users/xinity/gists{/gist_id}","starred_url":"https://api.github.com/users/xinity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xinity/subscriptions","organizations_url":"https://api.github.com/users/xinity/orgs","repos_url":"https://api.github.com/users/xinity/repos","events_url":"https://api.github.com/users/xinity/events{/privacy}","received_events_url":"https://api.github.com/users/xinity/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xinity/collectd","description":"The system statistics collection daemon. Mirror of the canonical repository (updated automatically). Please send Pull Requests here!","fork":true,"url":"https://api.github.com/repos/xinity/collectd","forks_url":"https://api.github.com/repos/xinity/collectd/forks","keys_url":"https://api.github.com/repos/xinity/collectd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xinity/collectd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xinity/collectd/teams","hooks_url":"https://api.github.com/repos/xinity/collectd/hooks","issue_events_url":"https://api.github.com/repos/xinity/collectd/issues/events{/number}","events_url":"https://api.github.com/repos/xinity/collectd/events","assignees_url":"https://api.github.com/repos/xinity/collectd/assignees{/user}","branches_url":"https://api.github.com/repos/xinity/collectd/branches{/branch}","tags_url":"https://api.github.com/repos/xinity/collectd/tags","blobs_url":"https://api.github.com/repos/xinity/collectd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xinity/collectd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xinity/collectd/git/refs{/sha}","trees_url":"https://api.github.com/repos/xinity/collectd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xinity/collectd/statuses/{sha}","languages_url":"https://api.github.com/repos/xinity/collectd/languages","stargazers_url":"https://api.github.com/repos/xinity/collectd/stargazers","contributors_url":"https://api.github.com/repos/xinity/collectd/contributors","subscribers_url":"https://api.github.com/repos/xinity/collectd/subscribers","subscription_url":"https://api.github.com/repos/xinity/collectd/subscription","commits_url":"https://api.github.com/repos/xinity/collectd/commits{/sha}","git_commits_url":"https://api.github.com/repos/xinity/collectd/git/commits{/sha}","comments_url":"https://api.github.com/repos/xinity/collectd/comments{/number}","issue_comment_url":"https://api.github.com/repos/xinity/collectd/issues/comments{/number}","contents_url":"https://api.github.com/repos/xinity/collectd/contents/{+path}","compare_url":"https://api.github.com/repos/xinity/collectd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xinity/collectd/merges","archive_url":"https://api.github.com/repos/xinity/collectd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xinity/collectd/downloads","issues_url":"https://api.github.com/repos/xinity/collectd/issues{/number}","pulls_url":"https://api.github.com/repos/xinity/collectd/pulls{/number}","milestones_url":"https://api.github.com/repos/xinity/collectd/milestones{/number}","notifications_url":"https://api.github.com/repos/xinity/collectd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xinity/collectd/labels{/name}","releases_url":"https://api.github.com/repos/xinity/collectd/releases{/id}","deployments_url":"https://api.github.com/repos/xinity/collectd/deployments","created_at":"2016-07-17T14:16:37Z","updated_at":"2016-07-17T14:16:40Z","pushed_at":"2016-08-09T19:44:18Z","git_url":"git://github.com/xinity/collectd.git","ssh_url":"git@github.com:xinity/collectd.git","clone_url":"https://github.com/xinity/collectd.git","svn_url":"https://github.com/xinity/collectd","homepage":"http://collectd.org/","size":14070,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"collectd:master","ref":"master","sha":"37d3677e95febc653d8f67fc19f67eb4110910eb","user":{"login":"collectd","id":1027481,"avatar_url":"https://avatars.githubusercontent.com/u/1027481?v=3","gravatar_id":"","url":"https://api.github.com/users/collectd","html_url":"https://github.com/collectd","followers_url":"https://api.github.com/users/collectd/followers","following_url":"https://api.github.com/users/collectd/following{/other_user}","gists_url":"https://api.github.com/users/collectd/gists{/gist_id}","starred_url":"https://api.github.com/users/collectd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/collectd/subscriptions","organizations_url":"https://api.github.com/users/collectd/orgs","repos_url":"https://api.github.com/users/collectd/repos","events_url":"https://api.github.com/users/collectd/events{/privacy}","received_events_url":"https://api.github.com/users/collectd/received_events","type":"Organization","site_admin":false},"repo":{"id":3208640,"name":"collectd","full_name":"collectd/collectd","owner":{"login":"collectd","id":1027481,"avatar_url":"https://avatars.githubusercontent.com/u/1027481?v=3","gravatar_id":"","url":"https://api.github.com/users/collectd","html_url":"https://github.com/collectd","followers_url":"https://api.github.com/users/collectd/followers","following_url":"https://api.github.com/users/collectd/following{/other_user}","gists_url":"https://api.github.com/users/collectd/gists{/gist_id}","starred_url":"https://api.github.com/users/collectd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/collectd/subscriptions","organizations_url":"https://api.github.com/users/collectd/orgs","repos_url":"https://api.github.com/users/collectd/repos","events_url":"https://api.github.com/users/collectd/events{/privacy}","received_events_url":"https://api.github.com/users/collectd/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/collectd/collectd","description":"The system statistics collection daemon. Mirror of the canonical repository (updated automatically). Please send Pull Requests here!","fork":false,"url":"https://api.github.com/repos/collectd/collectd","forks_url":"https://api.github.com/repos/collectd/collectd/forks","keys_url":"https://api.github.com/repos/collectd/collectd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/collectd/collectd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/collectd/collectd/teams","hooks_url":"https://api.github.com/repos/collectd/collectd/hooks","issue_events_url":"https://api.github.com/repos/collectd/collectd/issues/events{/number}","events_url":"https://api.github.com/repos/collectd/collectd/events","assignees_url":"https://api.github.com/repos/collectd/collectd/assignees{/user}","branches_url":"https://api.github.com/repos/collectd/collectd/branches{/branch}","tags_url":"https://api.github.com/repos/collectd/collectd/tags","blobs_url":"https://api.github.com/repos/collectd/collectd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/collectd/collectd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/collectd/collectd/git/refs{/sha}","trees_url":"https://api.github.com/repos/collectd/collectd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/collectd/collectd/statuses/{sha}","languages_url":"https://api.github.com/repos/collectd/collectd/languages","stargazers_url":"https://api.github.com/repos/collectd/collectd/stargazers","contributors_url":"https://api.github.com/repos/collectd/collectd/contributors","subscribers_url":"https://api.github.com/repos/collectd/collectd/subscribers","subscription_url":"https://api.github.com/repos/collectd/collectd/subscription","commits_url":"https://api.github.com/repos/collectd/collectd/commits{/sha}","git_commits_url":"https://api.github.com/repos/collectd/collectd/git/commits{/sha}","comments_url":"https://api.github.com/repos/collectd/collectd/comments{/number}","issue_comment_url":"https://api.github.com/repos/collectd/collectd/issues/comments{/number}","contents_url":"https://api.github.com/repos/collectd/collectd/contents/{+path}","compare_url":"https://api.github.com/repos/collectd/collectd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/collectd/collectd/merges","archive_url":"https://api.github.com/repos/collectd/collectd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/collectd/collectd/downloads","issues_url":"https://api.github.com/repos/collectd/collectd/issues{/number}","pulls_url":"https://api.github.com/repos/collectd/collectd/pulls{/number}","milestones_url":"https://api.github.com/repos/collectd/collectd/milestones{/number}","notifications_url":"https://api.github.com/repos/collectd/collectd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/collectd/collectd/labels{/name}","releases_url":"https://api.github.com/repos/collectd/collectd/releases{/id}","deployments_url":"https://api.github.com/repos/collectd/collectd/deployments","created_at":"2012-01-18T13:07:51Z","updated_at":"2016-08-09T14:03:49Z","pushed_at":"2016-08-11T13:33:44Z","git_url":"git://github.com/collectd/collectd.git","ssh_url":"git@github.com:collectd/collectd.git","clone_url":"https://github.com/collectd/collectd.git","svn_url":"https://github.com/collectd/collectd","homepage":"http://collectd.org/","size":27311,"stargazers_count":1220,"watchers_count":1220,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":694,"mirror_url":null,"open_issues_count":311,"forks":694,"open_issues":311,"watchers":1220,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/collectd/collectd/pulls/1849"},"html":{"href":"https://github.com/collectd/collectd/pull/1849"},"issue":{"href":"https://api.github.com/repos/collectd/collectd/issues/1849"},"comments":{"href":"https://api.github.com/repos/collectd/collectd/issues/1849/comments"},"review_comments":{"href":"https://api.github.com/repos/collectd/collectd/pulls/1849/comments"},"review_comment":{"href":"https://api.github.com/repos/collectd/collectd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/collectd/collectd/pulls/1849/commits"},"statuses":{"href":"https://api.github.com/repos/collectd/collectd/statuses/298b235e52ae98e89e0a41a7b3b7b4a14e14dcb8"}}}}
{"actor":{"display_login":"octo"}}