{"action":"created","issue":{"url":"https://api.github.com/repos/tspenov/maycamp_arena/issues/1","repository_url":"https://api.github.com/repos/tspenov/maycamp_arena","labels_url":"https://api.github.com/repos/tspenov/maycamp_arena/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/tspenov/maycamp_arena/issues/1/comments","events_url":"https://api.github.com/repos/tspenov/maycamp_arena/issues/1/events","html_url":"https://github.com/tspenov/maycamp_arena/pull/1","id":138678330,"number":1,"title":"Google oauth login feature","user":{"login":"tspenov","id":122794,"avatar_url":"https://avatars.githubusercontent.com/u/122794?v=3","gravatar_id":"","url":"https://api.github.com/users/tspenov","html_url":"https://github.com/tspenov","followers_url":"https://api.github.com/users/tspenov/followers","following_url":"https://api.github.com/users/tspenov/following{/other_user}","gists_url":"https://api.github.com/users/tspenov/gists{/gist_id}","starred_url":"https://api.github.com/users/tspenov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tspenov/subscriptions","organizations_url":"https://api.github.com/users/tspenov/orgs","repos_url":"https://api.github.com/users/tspenov/repos","events_url":"https://api.github.com/users/tspenov/events{/privacy}","received_events_url":"https://api.github.com/users/tspenov/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-03-05T13:22:53Z","updated_at":"2016-03-14T08:02:07Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/tspenov/maycamp_arena/pulls/1","html_url":"https://github.com/tspenov/maycamp_arena/pull/1","diff_url":"https://github.com/tspenov/maycamp_arena/pull/1.diff","patch_url":"https://github.com/tspenov/maycamp_arena/pull/1.patch"},"body":"**Done:**\r\n- Implemented sign in with google for existing users, logging the last user in the db with equivalent email\r\n- Used devise and omniauth-google-oauth2\r\n- The google key and secret are in ENV var (_initializers/devise.rb_)\r\n\r\n**Questions:**\r\n- Should I register nonexistent users when signing in with google for the first time ?\r\n- if yes: how should I fill city and login (_first_name.latinize.downcase ?_)\r\n- should I write some tests ?\r\n"},"comment":{"url":"https://api.github.com/repos/tspenov/maycamp_arena/issues/comments/196190126","html_url":"https://github.com/tspenov/maycamp_arena/pull/1#issuecomment-196190126","issue_url":"https://api.github.com/repos/tspenov/maycamp_arena/issues/1","id":196190126,"user":{"login":"valo","id":47639,"avatar_url":"https://avatars.githubusercontent.com/u/47639?v=3","gravatar_id":"","url":"https://api.github.com/users/valo","html_url":"https://github.com/valo","followers_url":"https://api.github.com/users/valo/followers","following_url":"https://api.github.com/users/valo/following{/other_user}","gists_url":"https://api.github.com/users/valo/gists{/gist_id}","starred_url":"https://api.github.com/users/valo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/valo/subscriptions","organizations_url":"https://api.github.com/users/valo/orgs","repos_url":"https://api.github.com/users/valo/repos","events_url":"https://api.github.com/users/valo/events{/privacy}","received_events_url":"https://api.github.com/users/valo/received_events","type":"User","site_admin":false},"created_at":"2016-03-14T08:02:06Z","updated_at":"2016-03-14T08:02:06Z","body":"Apart from the small cosmetic changes I think we are good to go :) :+1: "}}