{"push_id":1043261708,"size":8,"distinct_size":8,"ref":"refs/heads/chore-improve-bh-date-editor","head":"f9ec4d33620904bde38ed83b93ae183de695a6d9","before":"dc1d02b3cf7e15c74aa0f5e04af34be4df7b3043","commits":[{"sha":"9091e8b788e2d0cbed13ef198a3926da8a5799ee","author":{"email":"855e8969467e9189e86400b4025ed7d8e7eb6c08@imaworldhealth.org","name":"Steven Fountain"},"message":"Prototype initial core posting journal files\n\nThis commit introduces the initial files for the 2.x client side\nposting journal. It proposes a structure for how the core UI grid\nshould be configured and sets up the testing framework.\n\nTesting - A page object is used to abstract methods on the page\ncomponents (primarily the grid), currently this provides a method to\nverify the total number of rows that can be accesed by the test runner\n(journal.spec.js). This method is taken from the test utilities provided\nby Angular UI Grid, this is a fully featured set of tools however the\nactual expect behaviour is configured for a different testing framework.\n\nService Infrastructure - A service 'TransactionService' has been\ncreated to interface with the server journal end point and provide any\nutility methods required to manipulate transactions. Seperating models\nand functionality into services will be a key aspect of how the\ncontroller and module achieves modularity.\n\nRouting - app.js is updated such that /#/journal points to the new 2.x\njournal files. Once the updated posting journal is stable it will\ncompletely replace the previous implementation; this should be reflected\nin the file structure.","distinct":true,"url":"https://api.github.com/repos/jniles/bhima-2.X/commits/9091e8b788e2d0cbed13ef198a3926da8a5799ee"},{"sha":"ef3c0559042fd2474e1195c8c1e220b9c416fe86","author":{"email":"855e8969467e9189e86400b4025ed7d8e7eb6c08@imaworldhealth.org","name":"Steven Fountain"},"message":"(Chore) Mock transaction data algorithm\n\nThis commit adds methods to mock development data required for testing\nand validating grid functionality. These methods will be depricated once\nthe system is able to produce the data through its core components.\n\nJournal column definitions are updated to match something like the current\nposting journal database; there are a number of changes that will have to be made;\ninv_po_id -> reference\ncurrency_symbol -> currency\ncc -> cost_center\npc -> cost_center\n\nUpdated tests to reflect new mock data.\n\nThe mock transaction algorithm requires refining to handle the following\ncases:\n* Balanced transactions given a total cost\n* Sensible account assignment with each cost\n* Assigning debitors and creditors\n* Assigning reference documents\n\nOnce this is completed a static set of test data can be generated and\nused to populate models/test/data.sql","distinct":true,"url":"https://api.github.com/repos/jniles/bhima-2.X/commits/ef3c0559042fd2474e1195c8c1e220b9c416fe86"},{"sha":"281f1ffa396a5f44638d59b94420f10eb2e43887","author":{"email":"855e8969467e9189e86400b4025ed7d8e7eb6c08@imaworldhealth.org","name":"Steven Fountain"},"message":"Propose modular service based architecture - Sort\n\nThis commit proposes a service based approach for each of the utilities the\njournal will require. In this proposal sorting is implemented by creating the\nJournalSortingService. This service is responsible for\n- Configuring the global gridOptions object\n- Providing helper functions for complex sorting\n\nTransactionService was renamed to journal/TransactionService, this service\nwill still be available to any controllers that require however the current\nimplementation is directly intended for the posting journal.","distinct":true,"url":"https://api.github.com/repos/jniles/bhima-2.X/commits/281f1ffa396a5f44638d59b94420f10eb2e43887"},{"sha":"326cc77067d28fe7f3b87d7afb36832a2e360cb0","author":{"email":"855e8969467e9189e86400b4025ed7d8e7eb6c08@imaworldhealth.org","name":"Steven Fountain"},"message":"Implemented additional feature service (Grouping)\n\nThis commit adds basic grouping into the core posting journal. Grouping\ncurrently sets default values and extends the grid with two basic\nfeatures:\n- Selecting a group header selects each of the children for that row\n- Grid groups are expanded on initialise\n\nThe sort algorithm was updated to support grouping on transaction IDs.\nAngular UI Grid does not pass an row object to the sorting method for\ngroup header rows (because it is just a UI object - there is no\nunderlying data for these rows). Previously the sort worked by comparing\nthe rows `reference` attribute - the algorithm now parses this from the\ntransaction ID string if it is a group header (the only information\npassed to headers).\n\nProposed onRegisterApi callback method allows services to register a\ncallback and retrieve the API; once they have completed that they call\nany method that was registrered before them.\n\nAdded:\n- Column resizing\n- Column moving\n- Column selection","distinct":true,"url":"https://api.github.com/repos/jniles/bhima-2.X/commits/326cc77067d28fe7f3b87d7afb36832a2e360cb0"},{"sha":"25a84b068b9ed863eb6284bb749b6b4c13ba0d57","author":{"email":"855e8969467e9189e86400b4025ed7d8e7eb6c08@imaworldhealth.org","name":"Steven Fountain"},"message":"Implement pagination service\n\nThis commit adds the files required for the journal pagination service,\nproviding a number of global configurations as well as helper methods to\nsettup correct pagination.\n\nJournalPagination can be configured to specify if the service should use\nexternal (custom) pagination (as defined in the\nJournalPaginationService) or to use the default Angular UI Grid\npagination. Custom pagination (driven by the method `fetchPages`)\nrespects transactions and will not split a transaction across multiple\npages; this means the page size is dependent on the current page of\ntrnnsactions.\n\nCurrently isExternalPagination is set to false; until the jounral\nrequires features from the custom pagination this will be set - there\nare many corner cases to consider with pagination (sorting, selection,\ncacheing) that will require a very careful tested design.\n\n- Updated column definitions go group (and sort) on transactions by\n  default. This gives the core view into the posting journal.","distinct":true,"url":"https://api.github.com/repos/jniles/bhima-2.X/commits/25a84b068b9ed863eb6284bb749b6b4c13ba0d57"},{"sha":"e9572f49be11d0269eea71f003fcd443c971be46","author":{"email":"855e8969467e9189e86400b4025ed7d8e7eb6c08@imaworldhealth.org","name":"Steven Fountain"},"message":"(Chore) Fixed typos and removed legacy routes\n\nThis commit removes the old 1.x journal routes. These can be recovered\nby checking the files out of git history. Minor typo fixes in\nJournalGrouping (row -> header).","distinct":true,"url":"https://api.github.com/repos/jniles/bhima-2.X/commits/e9572f49be11d0269eea71f003fcd443c971be46"},{"sha":"cb5cbc3099c13fe13109667240040574b43ed793","author":{"email":"855e8969467e9189e86400b4025ed7d8e7eb6c08@imaworldhealth.org","name":"Steven Fountain"},"message":"Merge pull request #215 from sfount/feature-journal-core\n\nFeature(journal core): Introduce core posting journal","distinct":true,"url":"https://api.github.com/repos/jniles/bhima-2.X/commits/cb5cbc3099c13fe13109667240040574b43ed793"},{"sha":"f9ec4d33620904bde38ed83b93ae183de695a6d9","author":{"email":"7022cbf74ccd213cd285435a702c593c02b94194@gmail.com","name":"Jonathan Niles"},"message":"chore(bhDateEditor): iterate on date editor comp\n\nThis commit iterates on and improves the date editor component.  It closes\nevery single checkbox in issue #174.\n\n - [x] The input should be be `readonly` instead of `disabled`, like the\n `bhFindPatientComponent`.  The disabled state can be confused with actually\n disabling the input.\n - [x] The component doesn't enforce `max-date` or `min-date`.  It should either:\n  1. disallow the user to input the max date or min date OR\n  2. show an error message that the date is too great or small\n - [x] The buttons should be `i18n`.\n - [x] If possible, remove the option to \"clear\" the date.\n - [x] Include the label \"Date\" in the component by default.  Support the binding\n `label-key` to allow a controller to alter the label to another text.  The\n `label-key` will be passed through the translation filter in the view.\n - [x] Make the test harness actually work.\n\nNotes from the this iteration:\n 1. Instead of `label-key`, I've opted to call the binding `label` for\n simplicity.  However, translation still works as described.\n 2. The buttons have been completedly removed, per a suggestion of\n @sfount.\n 3. The date-format binding has been changed to reading in a string.  If\n there is anyone relying on this, we can easily revert the change.  It\n seems to me the date format shouldn't change dynamically anyway.\n\nCloses #174.  Any new suggestions or bugs should be reported as their\nown issue.","distinct":true,"url":"https://api.github.com/repos/jniles/bhima-2.X/commits/f9ec4d33620904bde38ed83b93ae183de695a6d9"}]}