{"action":"created","issue":{"url":"https://api.github.com/repos/joomla-extensions/weblinks/issues/208","repository_url":"https://api.github.com/repos/joomla-extensions/weblinks","labels_url":"https://api.github.com/repos/joomla-extensions/weblinks/issues/208/labels{/name}","comments_url":"https://api.github.com/repos/joomla-extensions/weblinks/issues/208/comments","events_url":"https://api.github.com/repos/joomla-extensions/weblinks/issues/208/events","html_url":"https://github.com/joomla-extensions/weblinks/pull/208","id":152583718,"number":208,"title":"Implements searchtools, filters, dropdown actions and counting","user":{"login":"andrepereiradasilva","id":9630530,"avatar_url":"https://avatars.githubusercontent.com/u/9630530?v=3","gravatar_id":"","url":"https://api.github.com/users/andrepereiradasilva","html_url":"https://github.com/andrepereiradasilva","followers_url":"https://api.github.com/users/andrepereiradasilva/followers","following_url":"https://api.github.com/users/andrepereiradasilva/following{/other_user}","gists_url":"https://api.github.com/users/andrepereiradasilva/gists{/gist_id}","starred_url":"https://api.github.com/users/andrepereiradasilva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrepereiradasilva/subscriptions","organizations_url":"https://api.github.com/users/andrepereiradasilva/orgs","repos_url":"https://api.github.com/users/andrepereiradasilva/repos","events_url":"https://api.github.com/users/andrepereiradasilva/events{/privacy}","received_events_url":"https://api.github.com/users/andrepereiradasilva/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2016-05-02T15:58:24Z","updated_at":"2016-05-02T19:20:00Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/joomla-extensions/weblinks/pulls/208","html_url":"https://github.com/joomla-extensions/weblinks/pull/208","diff_url":"https://github.com/joomla-extensions/weblinks/pull/208.diff","patch_url":"https://github.com/joomla-extensions/weblinks/pull/208.patch"},"body":"#### Summary of Changes\r\n\r\nThis PR, as done in all other core list views, implements swearchtools in weblinks.\r\n\r\nAlso:\r\n- Some minor code improvements\r\n- Add max level filter (as done for other core views)\r\n- Add dropdown actions (as done for other core views)\r\n- Integrates the other two PR: (as done for other core views)\r\n - Category counting https://github.com/joomla-extensions/weblinks/pull/207\r\n - Category text https://github.com/joomla-extensions/weblinks/pull/177\r\n\r\nThis PR as a whole, will put com_weblinks in line with the other core views.\r\n\r\n###### Web Links view\r\n\r\n\r\nBefore PR\r\n\r\n![image](https://cloud.githubusercontent.com/assets/9630530/14959363/ef9e5836-1086-11e6-8da7-999a2f098043.png)\r\n\r\nAfter PR\r\n\r\n![image](https://cloud.githubusercontent.com/assets/9630530/14959305/9dfe4734-1086-11e6-92fd-d4906135f2fe.png)\r\n\r\n###### Web Links categories view\r\n\r\nBefore PR\r\n\r\n![image](https://cloud.githubusercontent.com/assets/9630530/14959338/d45279cc-1086-11e6-8052-174c905e8c3d.png)\r\n\r\nAfter PR\r\n\r\n![image](https://cloud.githubusercontent.com/assets/9630530/14959316/ad4ba916-1086-11e6-8072-05fe4eb40d3a.png)\r\n\r\n#### How to test\r\n\r\n1. Install the custom weblinks from URL https://github.com/andrepereiradasilva/update.joomla.org/raw/master/pkg-weblinks-3.5.0.zip\r\n2. Create some weblinks\r\n3. Test searchtools (seacrh, filters, orderings, pagination)\r\n4. Test dropdown actions\r\n5. Go to Categories and test the counting and their links"},"comment":{"url":"https://api.github.com/repos/joomla-extensions/weblinks/issues/comments/216334560","html_url":"https://github.com/joomla-extensions/weblinks/pull/208#issuecomment-216334560","issue_url":"https://api.github.com/repos/joomla-extensions/weblinks/issues/208","id":216334560,"user":{"login":"yvesh","id":897638,"avatar_url":"https://avatars.githubusercontent.com/u/897638?v=3","gravatar_id":"","url":"https://api.github.com/users/yvesh","html_url":"https://github.com/yvesh","followers_url":"https://api.github.com/users/yvesh/followers","following_url":"https://api.github.com/users/yvesh/following{/other_user}","gists_url":"https://api.github.com/users/yvesh/gists{/gist_id}","starred_url":"https://api.github.com/users/yvesh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yvesh/subscriptions","organizations_url":"https://api.github.com/users/yvesh/orgs","repos_url":"https://api.github.com/users/yvesh/repos","events_url":"https://api.github.com/users/yvesh/events{/privacy}","received_events_url":"https://api.github.com/users/yvesh/received_events","type":"User","site_admin":false},"created_at":"2016-05-02T19:19:59Z","updated_at":"2016-05-02T19:19:59Z","body":"@andrepereiradasilva The following should fix it, if you want i can also make a pull request to your repository.\r\n\r\n```php\r\n$I->click('Search Tools');\r\n$I->wait(2);\r\n$I->selectOptionInChosenById('filter_published', 'Trashed');\r\n```\r\n\r\nReplace line 102 in tests/acceptance/administrator/AdministratorWeblinksCest.php with that.\r\n\r\nhttps://github.com/joomla-extensions/weblinks/blob/master/tests/acceptance/administrator/AdministratorWeblinksCest.php#L102\r\n\r\nYou also need to update your fork repositor, else you run into new troubles! :-)\r\n\r\n> This branch is 6 commits ahead, 5 commits behind joomla-extensions:master"}}