{"action":"created","comment":{"url":"https://api.github.com/repos/caskdata/cdap/pulls/comments/71093633","id":71093633,"diff_hunk":"@@ -50,30 +50,37 @@\n   </div>\n \n   <!-- LOGS TIMELINE -->\n-  <my-timeline timeline-data=\"LogViewer.data\"></my-timeline>\n-\n+  <my-timeline\n+    ng-if=\"!LogViewer.loading\"\n+    namespace-id=\"{{LogViewer.namespaceId}}\"\n+    app-id=\"{{LogViewer.appId}}\"\n+    program-type=\"{{LogViewer.programType}}\"\n+    program-id=\"{{LogViewer.programId}}\"\n+    run-id=\"{{LogViewer.runId}}\">\n+  </my-timeline>\n+\n+  <!-- NO DATA MESSAGE -->\n+  <div ng-if=\"LogViewer.data.length === 0\" class=\"well well-lg\">\n+    No logs to be displayed.\n+  </div>\n+  <div ng-if=\"LogViewer.loading\" class=\"jumbotron well well-lg\">\n+    Loading Logs...\n+  </div>\n   <!-- LOGS TABLE -->\n-  <div class=\"logs-table\">\n-    <table class=\"table table-bordered\">\n+  <div ng-if=\"LogViewer.data.length > 0 && !LogViewer.loading\" class=\"logs-table\">\n+    <table class=\"table table-bordered scroll scroll-table\">\n       <thead>\n-        <th class=\"time log-header\"\n+        <th class=\"time time-header log-header\"\n             ng-if=\"LogViewer.configOptions.time && !LogViewer.hiddenColumns.time\">\n           Time\n         </th>\n \n-        <th class=\"level log-header header-level\"\n+        <th class='level level-header'","path":"cdap-ui/app/directives/log-viewer/log-viewer.html","position":35,"original_position":35,"commit_id":"b3d88b147a9eb188126fd71d98858bc43d7a0f41","original_commit_id":"b3d88b147a9eb188126fd71d98858bc43d7a0f41","user":{"login":"ajainarayanan","id":1452845,"avatar_url":"https://avatars.githubusercontent.com/u/1452845?v=3","gravatar_id":"","url":"https://api.github.com/users/ajainarayanan","html_url":"https://github.com/ajainarayanan","followers_url":"https://api.github.com/users/ajainarayanan/followers","following_url":"https://api.github.com/users/ajainarayanan/following{/other_user}","gists_url":"https://api.github.com/users/ajainarayanan/gists{/gist_id}","starred_url":"https://api.github.com/users/ajainarayanan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajainarayanan/subscriptions","organizations_url":"https://api.github.com/users/ajainarayanan/orgs","repos_url":"https://api.github.com/users/ajainarayanan/repos","events_url":"https://api.github.com/users/ajainarayanan/events{/privacy}","received_events_url":"https://api.github.com/users/ajainarayanan/received_events","type":"User","site_admin":false},"body":"Fix single quotes.","created_at":"2016-07-18T01:03:44Z","updated_at":"2016-07-18T01:03:44Z","html_url":"https://github.com/caskdata/cdap/pull/6019#discussion_r71093633","pull_request_url":"https://api.github.com/repos/caskdata/cdap/pulls/6019","_links":{"self":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/comments/71093633"},"html":{"href":"https://github.com/caskdata/cdap/pull/6019#discussion_r71093633"},"pull_request":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/6019"}}},"pull_request":{"url":"https://api.github.com/repos/caskdata/cdap/pulls/6019","id":77037927,"html_url":"https://github.com/caskdata/cdap/pull/6019","diff_url":"https://github.com/caskdata/cdap/pull/6019.diff","patch_url":"https://github.com/caskdata/cdap/pull/6019.patch","issue_url":"https://api.github.com/repos/caskdata/cdap/issues/6019","number":6019,"state":"open","locked":false,"title":"[CDAP-6174] Feature/ui new log viewer integration","user":{"login":"PGuimarais","id":7697583,"avatar_url":"https://avatars.githubusercontent.com/u/7697583?v=3","gravatar_id":"","url":"https://api.github.com/users/PGuimarais","html_url":"https://github.com/PGuimarais","followers_url":"https://api.github.com/users/PGuimarais/followers","following_url":"https://api.github.com/users/PGuimarais/following{/other_user}","gists_url":"https://api.github.com/users/PGuimarais/gists{/gist_id}","starred_url":"https://api.github.com/users/PGuimarais/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PGuimarais/subscriptions","organizations_url":"https://api.github.com/users/PGuimarais/orgs","repos_url":"https://api.github.com/users/PGuimarais/repos","events_url":"https://api.github.com/users/PGuimarais/events{/privacy}","received_events_url":"https://api.github.com/users/PGuimarais/received_events","type":"User","site_admin":false},"body":"LogViewer Table:\r\n- Populates table with data from backend endpoint\r\n- Makes table fixed height and scrollable\r\n\r\nTimeline:\r\n- Renders timeline with backend endpoint\r\n- Dynamically repaints timeline for running applications\r\n- Filters table based on slider position","created_at":"2016-07-11T23:07:14Z","updated_at":"2016-07-18T01:03:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cfa79516a6ea30ae622371406fb1cb33ec109c6e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/caskdata/cdap/pulls/6019/commits","review_comments_url":"https://api.github.com/repos/caskdata/cdap/pulls/6019/comments","review_comment_url":"https://api.github.com/repos/caskdata/cdap/pulls/comments{/number}","comments_url":"https://api.github.com/repos/caskdata/cdap/issues/6019/comments","statuses_url":"https://api.github.com/repos/caskdata/cdap/statuses/b3d88b147a9eb188126fd71d98858bc43d7a0f41","head":{"label":"caskdata:feature/ui-new-log-viewer-integration","ref":"feature/ui-new-log-viewer-integration","sha":"b3d88b147a9eb188126fd71d98858bc43d7a0f41","user":{"login":"caskdata","id":8123023,"avatar_url":"https://avatars.githubusercontent.com/u/8123023?v=3","gravatar_id":"","url":"https://api.github.com/users/caskdata","html_url":"https://github.com/caskdata","followers_url":"https://api.github.com/users/caskdata/followers","following_url":"https://api.github.com/users/caskdata/following{/other_user}","gists_url":"https://api.github.com/users/caskdata/gists{/gist_id}","starred_url":"https://api.github.com/users/caskdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caskdata/subscriptions","organizations_url":"https://api.github.com/users/caskdata/orgs","repos_url":"https://api.github.com/users/caskdata/repos","events_url":"https://api.github.com/users/caskdata/events{/privacy}","received_events_url":"https://api.github.com/users/caskdata/received_events","type":"Organization","site_admin":false},"repo":{"id":22542759,"name":"cdap","full_name":"caskdata/cdap","owner":{"login":"caskdata","id":8123023,"avatar_url":"https://avatars.githubusercontent.com/u/8123023?v=3","gravatar_id":"","url":"https://api.github.com/users/caskdata","html_url":"https://github.com/caskdata","followers_url":"https://api.github.com/users/caskdata/followers","following_url":"https://api.github.com/users/caskdata/following{/other_user}","gists_url":"https://api.github.com/users/caskdata/gists{/gist_id}","starred_url":"https://api.github.com/users/caskdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caskdata/subscriptions","organizations_url":"https://api.github.com/users/caskdata/orgs","repos_url":"https://api.github.com/users/caskdata/repos","events_url":"https://api.github.com/users/caskdata/events{/privacy}","received_events_url":"https://api.github.com/users/caskdata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/caskdata/cdap","description":"Cask Data Application Platform (CDAP)","fork":false,"url":"https://api.github.com/repos/caskdata/cdap","forks_url":"https://api.github.com/repos/caskdata/cdap/forks","keys_url":"https://api.github.com/repos/caskdata/cdap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/caskdata/cdap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/caskdata/cdap/teams","hooks_url":"https://api.github.com/repos/caskdata/cdap/hooks","issue_events_url":"https://api.github.com/repos/caskdata/cdap/issues/events{/number}","events_url":"https://api.github.com/repos/caskdata/cdap/events","assignees_url":"https://api.github.com/repos/caskdata/cdap/assignees{/user}","branches_url":"https://api.github.com/repos/caskdata/cdap/branches{/branch}","tags_url":"https://api.github.com/repos/caskdata/cdap/tags","blobs_url":"https://api.github.com/repos/caskdata/cdap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/caskdata/cdap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/caskdata/cdap/git/refs{/sha}","trees_url":"https://api.github.com/repos/caskdata/cdap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/caskdata/cdap/statuses/{sha}","languages_url":"https://api.github.com/repos/caskdata/cdap/languages","stargazers_url":"https://api.github.com/repos/caskdata/cdap/stargazers","contributors_url":"https://api.github.com/repos/caskdata/cdap/contributors","subscribers_url":"https://api.github.com/repos/caskdata/cdap/subscribers","subscription_url":"https://api.github.com/repos/caskdata/cdap/subscription","commits_url":"https://api.github.com/repos/caskdata/cdap/commits{/sha}","git_commits_url":"https://api.github.com/repos/caskdata/cdap/git/commits{/sha}","comments_url":"https://api.github.com/repos/caskdata/cdap/comments{/number}","issue_comment_url":"https://api.github.com/repos/caskdata/cdap/issues/comments{/number}","contents_url":"https://api.github.com/repos/caskdata/cdap/contents/{+path}","compare_url":"https://api.github.com/repos/caskdata/cdap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/caskdata/cdap/merges","archive_url":"https://api.github.com/repos/caskdata/cdap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/caskdata/cdap/downloads","issues_url":"https://api.github.com/repos/caskdata/cdap/issues{/number}","pulls_url":"https://api.github.com/repos/caskdata/cdap/pulls{/number}","milestones_url":"https://api.github.com/repos/caskdata/cdap/milestones{/number}","notifications_url":"https://api.github.com/repos/caskdata/cdap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/caskdata/cdap/labels{/name}","releases_url":"https://api.github.com/repos/caskdata/cdap/releases{/id}","deployments_url":"https://api.github.com/repos/caskdata/cdap/deployments","created_at":"2014-08-02T09:00:10Z","updated_at":"2016-07-16T03:40:41Z","pushed_at":"2016-07-18T00:54:08Z","git_url":"git://github.com/caskdata/cdap.git","ssh_url":"git@github.com:caskdata/cdap.git","clone_url":"https://github.com/caskdata/cdap.git","svn_url":"https://github.com/caskdata/cdap","homepage":"http://cdap.io","size":624140,"stargazers_count":135,"watchers_count":135,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":48,"mirror_url":null,"open_issues_count":26,"forks":48,"open_issues":26,"watchers":135,"default_branch":"develop"}},"base":{"label":"caskdata:develop","ref":"develop","sha":"0dfdd85b03d477763715d7d3a257368bd9710cba","user":{"login":"caskdata","id":8123023,"avatar_url":"https://avatars.githubusercontent.com/u/8123023?v=3","gravatar_id":"","url":"https://api.github.com/users/caskdata","html_url":"https://github.com/caskdata","followers_url":"https://api.github.com/users/caskdata/followers","following_url":"https://api.github.com/users/caskdata/following{/other_user}","gists_url":"https://api.github.com/users/caskdata/gists{/gist_id}","starred_url":"https://api.github.com/users/caskdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caskdata/subscriptions","organizations_url":"https://api.github.com/users/caskdata/orgs","repos_url":"https://api.github.com/users/caskdata/repos","events_url":"https://api.github.com/users/caskdata/events{/privacy}","received_events_url":"https://api.github.com/users/caskdata/received_events","type":"Organization","site_admin":false},"repo":{"id":22542759,"name":"cdap","full_name":"caskdata/cdap","owner":{"login":"caskdata","id":8123023,"avatar_url":"https://avatars.githubusercontent.com/u/8123023?v=3","gravatar_id":"","url":"https://api.github.com/users/caskdata","html_url":"https://github.com/caskdata","followers_url":"https://api.github.com/users/caskdata/followers","following_url":"https://api.github.com/users/caskdata/following{/other_user}","gists_url":"https://api.github.com/users/caskdata/gists{/gist_id}","starred_url":"https://api.github.com/users/caskdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caskdata/subscriptions","organizations_url":"https://api.github.com/users/caskdata/orgs","repos_url":"https://api.github.com/users/caskdata/repos","events_url":"https://api.github.com/users/caskdata/events{/privacy}","received_events_url":"https://api.github.com/users/caskdata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/caskdata/cdap","description":"Cask Data Application Platform (CDAP)","fork":false,"url":"https://api.github.com/repos/caskdata/cdap","forks_url":"https://api.github.com/repos/caskdata/cdap/forks","keys_url":"https://api.github.com/repos/caskdata/cdap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/caskdata/cdap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/caskdata/cdap/teams","hooks_url":"https://api.github.com/repos/caskdata/cdap/hooks","issue_events_url":"https://api.github.com/repos/caskdata/cdap/issues/events{/number}","events_url":"https://api.github.com/repos/caskdata/cdap/events","assignees_url":"https://api.github.com/repos/caskdata/cdap/assignees{/user}","branches_url":"https://api.github.com/repos/caskdata/cdap/branches{/branch}","tags_url":"https://api.github.com/repos/caskdata/cdap/tags","blobs_url":"https://api.github.com/repos/caskdata/cdap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/caskdata/cdap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/caskdata/cdap/git/refs{/sha}","trees_url":"https://api.github.com/repos/caskdata/cdap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/caskdata/cdap/statuses/{sha}","languages_url":"https://api.github.com/repos/caskdata/cdap/languages","stargazers_url":"https://api.github.com/repos/caskdata/cdap/stargazers","contributors_url":"https://api.github.com/repos/caskdata/cdap/contributors","subscribers_url":"https://api.github.com/repos/caskdata/cdap/subscribers","subscription_url":"https://api.github.com/repos/caskdata/cdap/subscription","commits_url":"https://api.github.com/repos/caskdata/cdap/commits{/sha}","git_commits_url":"https://api.github.com/repos/caskdata/cdap/git/commits{/sha}","comments_url":"https://api.github.com/repos/caskdata/cdap/comments{/number}","issue_comment_url":"https://api.github.com/repos/caskdata/cdap/issues/comments{/number}","contents_url":"https://api.github.com/repos/caskdata/cdap/contents/{+path}","compare_url":"https://api.github.com/repos/caskdata/cdap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/caskdata/cdap/merges","archive_url":"https://api.github.com/repos/caskdata/cdap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/caskdata/cdap/downloads","issues_url":"https://api.github.com/repos/caskdata/cdap/issues{/number}","pulls_url":"https://api.github.com/repos/caskdata/cdap/pulls{/number}","milestones_url":"https://api.github.com/repos/caskdata/cdap/milestones{/number}","notifications_url":"https://api.github.com/repos/caskdata/cdap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/caskdata/cdap/labels{/name}","releases_url":"https://api.github.com/repos/caskdata/cdap/releases{/id}","deployments_url":"https://api.github.com/repos/caskdata/cdap/deployments","created_at":"2014-08-02T09:00:10Z","updated_at":"2016-07-16T03:40:41Z","pushed_at":"2016-07-18T00:54:08Z","git_url":"git://github.com/caskdata/cdap.git","ssh_url":"git@github.com:caskdata/cdap.git","clone_url":"https://github.com/caskdata/cdap.git","svn_url":"https://github.com/caskdata/cdap","homepage":"http://cdap.io","size":624140,"stargazers_count":135,"watchers_count":135,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":48,"mirror_url":null,"open_issues_count":26,"forks":48,"open_issues":26,"watchers":135,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/6019"},"html":{"href":"https://github.com/caskdata/cdap/pull/6019"},"issue":{"href":"https://api.github.com/repos/caskdata/cdap/issues/6019"},"comments":{"href":"https://api.github.com/repos/caskdata/cdap/issues/6019/comments"},"review_comments":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/6019/comments"},"review_comment":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/6019/commits"},"statuses":{"href":"https://api.github.com/repos/caskdata/cdap/statuses/b3d88b147a9eb188126fd71d98858bc43d7a0f41"}}}}
{"actor":{"display_login":"ajainarayanan"}}