{"action":"created","comment":{"url":"https://api.github.com/repos/infinispan/infinispan/pulls/comments/80415068","id":80415068,"diff_hunk":"@@ -0,0 +1,24 @@\n+package org.infinispan.health;\n+\n+/**\n+ * General Health status.\n+ *\n+ * @author Sebastian Łaskawiec\n+ * @since 9.0\n+ */\n+public enum HealthStatus {\n+    /**\n+     * Given entity is unhealthy.\n+     */\n+    RED,\n+\n+    /**\n+     * Given entity is healthy.\n+     */\n+    GREEN,\n+\n+    /**\n+     * Given entity is healthy but a rebalance is in progress.\n+     */\n+    YELLOW","path":"core/src/main/java/org/infinispan/health/HealthStatus.java","position":23,"original_position":23,"commit_id":"822d5a975347bc7f655d9d0fe167036164a232eb","original_commit_id":"98085403de77a201c137c001da55a67f915c0e79","user":{"login":"tristantarrant","id":392478,"avatar_url":"https://avatars.githubusercontent.com/u/392478?v=3","gravatar_id":"","url":"https://api.github.com/users/tristantarrant","html_url":"https://github.com/tristantarrant","followers_url":"https://api.github.com/users/tristantarrant/followers","following_url":"https://api.github.com/users/tristantarrant/following{/other_user}","gists_url":"https://api.github.com/users/tristantarrant/gists{/gist_id}","starred_url":"https://api.github.com/users/tristantarrant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tristantarrant/subscriptions","organizations_url":"https://api.github.com/users/tristantarrant/orgs","repos_url":"https://api.github.com/users/tristantarrant/repos","events_url":"https://api.github.com/users/tristantarrant/events{/privacy}","received_events_url":"https://api.github.com/users/tristantarrant/received_events","type":"User","site_admin":false},"body":"The review process is here to catch things at any time. I didn't think much about it at the time, but I do agree with @danberindei , although I'd probably change the middle state to something more specific than YELLOW but also less specific than REBALANCING (BUSY / REPAIRING, IN_MAINTENANCE ?), since we might want to indicate other situations where the cluster is best left (temporarily) alone. ","created_at":"2016-09-26T06:43:47Z","updated_at":"2016-09-26T06:43:47Z","html_url":"https://github.com/infinispan/infinispan/pull/4499#discussion_r80415068","pull_request_url":"https://api.github.com/repos/infinispan/infinispan/pulls/4499","_links":{"self":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/comments/80415068"},"html":{"href":"https://github.com/infinispan/infinispan/pull/4499#discussion_r80415068"},"pull_request":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/4499"}}},"pull_request":{"url":"https://api.github.com/repos/infinispan/infinispan/pulls/4499","id":80778507,"html_url":"https://github.com/infinispan/infinispan/pull/4499","diff_url":"https://github.com/infinispan/infinispan/pull/4499.diff","patch_url":"https://github.com/infinispan/infinispan/pull/4499.patch","issue_url":"https://api.github.com/repos/infinispan/infinispan/issues/4499","number":4499,"state":"open","locked":false,"title":"ISPN-6679 Healthcheck API","user":{"login":"slaskawi","id":8417158,"avatar_url":"https://avatars.githubusercontent.com/u/8417158?v=3","gravatar_id":"","url":"https://api.github.com/users/slaskawi","html_url":"https://github.com/slaskawi","followers_url":"https://api.github.com/users/slaskawi/followers","following_url":"https://api.github.com/users/slaskawi/following{/other_user}","gists_url":"https://api.github.com/users/slaskawi/gists{/gist_id}","starred_url":"https://api.github.com/users/slaskawi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slaskawi/subscriptions","organizations_url":"https://api.github.com/users/slaskawi/orgs","repos_url":"https://api.github.com/users/slaskawi/repos","events_url":"https://api.github.com/users/slaskawi/events{/privacy}","received_events_url":"https://api.github.com/users/slaskawi/received_events","type":"User","site_admin":false},"body":"JIRA: https://issues.jboss.org/browse/ISPN-6679\r\nDesign: https://github.com/infinispan/infinispan/wiki/Health-check-API\r\n\r\nHighlights:\r\n* The API can be accessed using CLI/JMX/REST and also programatically.\r\n* I decided to implement reading logs by my own (instead of using logging subsystem). The implementation is much simpler, shorter and does exactly what I need.\r\n* The WF integration bits are based on Metrics (runtime resources which are read only). I couldn't find any advantage of using Operations for this.\r\n","created_at":"2016-08-10T11:34:48Z","updated_at":"2016-09-26T06:43:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ffc70d2b18da24b384e7ea879c40693c0ae6ff01","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/infinispan/infinispan/pulls/4499/commits","review_comments_url":"https://api.github.com/repos/infinispan/infinispan/pulls/4499/comments","review_comment_url":"https://api.github.com/repos/infinispan/infinispan/pulls/comments{/number}","comments_url":"https://api.github.com/repos/infinispan/infinispan/issues/4499/comments","statuses_url":"https://api.github.com/repos/infinispan/infinispan/statuses/822d5a975347bc7f655d9d0fe167036164a232eb","head":{"label":"slaskawi:ISPN-6679/Healthcheck_api","ref":"ISPN-6679/Healthcheck_api","sha":"822d5a975347bc7f655d9d0fe167036164a232eb","user":{"login":"slaskawi","id":8417158,"avatar_url":"https://avatars.githubusercontent.com/u/8417158?v=3","gravatar_id":"","url":"https://api.github.com/users/slaskawi","html_url":"https://github.com/slaskawi","followers_url":"https://api.github.com/users/slaskawi/followers","following_url":"https://api.github.com/users/slaskawi/following{/other_user}","gists_url":"https://api.github.com/users/slaskawi/gists{/gist_id}","starred_url":"https://api.github.com/users/slaskawi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slaskawi/subscriptions","organizations_url":"https://api.github.com/users/slaskawi/orgs","repos_url":"https://api.github.com/users/slaskawi/repos","events_url":"https://api.github.com/users/slaskawi/events{/privacy}","received_events_url":"https://api.github.com/users/slaskawi/received_events","type":"User","site_admin":false},"repo":{"id":23697744,"name":"infinispan","full_name":"slaskawi/infinispan","owner":{"login":"slaskawi","id":8417158,"avatar_url":"https://avatars.githubusercontent.com/u/8417158?v=3","gravatar_id":"","url":"https://api.github.com/users/slaskawi","html_url":"https://github.com/slaskawi","followers_url":"https://api.github.com/users/slaskawi/followers","following_url":"https://api.github.com/users/slaskawi/following{/other_user}","gists_url":"https://api.github.com/users/slaskawi/gists{/gist_id}","starred_url":"https://api.github.com/users/slaskawi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slaskawi/subscriptions","organizations_url":"https://api.github.com/users/slaskawi/orgs","repos_url":"https://api.github.com/users/slaskawi/repos","events_url":"https://api.github.com/users/slaskawi/events{/privacy}","received_events_url":"https://api.github.com/users/slaskawi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/slaskawi/infinispan","description":"Infinispan is an open source data grid platform and highly scalable NoSQL cloud data store.","fork":true,"url":"https://api.github.com/repos/slaskawi/infinispan","forks_url":"https://api.github.com/repos/slaskawi/infinispan/forks","keys_url":"https://api.github.com/repos/slaskawi/infinispan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/slaskawi/infinispan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/slaskawi/infinispan/teams","hooks_url":"https://api.github.com/repos/slaskawi/infinispan/hooks","issue_events_url":"https://api.github.com/repos/slaskawi/infinispan/issues/events{/number}","events_url":"https://api.github.com/repos/slaskawi/infinispan/events","assignees_url":"https://api.github.com/repos/slaskawi/infinispan/assignees{/user}","branches_url":"https://api.github.com/repos/slaskawi/infinispan/branches{/branch}","tags_url":"https://api.github.com/repos/slaskawi/infinispan/tags","blobs_url":"https://api.github.com/repos/slaskawi/infinispan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/slaskawi/infinispan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/slaskawi/infinispan/git/refs{/sha}","trees_url":"https://api.github.com/repos/slaskawi/infinispan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/slaskawi/infinispan/statuses/{sha}","languages_url":"https://api.github.com/repos/slaskawi/infinispan/languages","stargazers_url":"https://api.github.com/repos/slaskawi/infinispan/stargazers","contributors_url":"https://api.github.com/repos/slaskawi/infinispan/contributors","subscribers_url":"https://api.github.com/repos/slaskawi/infinispan/subscribers","subscription_url":"https://api.github.com/repos/slaskawi/infinispan/subscription","commits_url":"https://api.github.com/repos/slaskawi/infinispan/commits{/sha}","git_commits_url":"https://api.github.com/repos/slaskawi/infinispan/git/commits{/sha}","comments_url":"https://api.github.com/repos/slaskawi/infinispan/comments{/number}","issue_comment_url":"https://api.github.com/repos/slaskawi/infinispan/issues/comments{/number}","contents_url":"https://api.github.com/repos/slaskawi/infinispan/contents/{+path}","compare_url":"https://api.github.com/repos/slaskawi/infinispan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/slaskawi/infinispan/merges","archive_url":"https://api.github.com/repos/slaskawi/infinispan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/slaskawi/infinispan/downloads","issues_url":"https://api.github.com/repos/slaskawi/infinispan/issues{/number}","pulls_url":"https://api.github.com/repos/slaskawi/infinispan/pulls{/number}","milestones_url":"https://api.github.com/repos/slaskawi/infinispan/milestones{/number}","notifications_url":"https://api.github.com/repos/slaskawi/infinispan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/slaskawi/infinispan/labels{/name}","releases_url":"https://api.github.com/repos/slaskawi/infinispan/releases{/id}","deployments_url":"https://api.github.com/repos/slaskawi/infinispan/deployments","created_at":"2014-09-05T09:35:13Z","updated_at":"2015-01-22T12:12:41Z","pushed_at":"2016-09-26T06:18:55Z","git_url":"git://github.com/slaskawi/infinispan.git","ssh_url":"git@github.com:slaskawi/infinispan.git","clone_url":"https://github.com/slaskawi/infinispan.git","svn_url":"https://github.com/slaskawi/infinispan","homepage":"http://www.infinispan.org","size":84900,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"infinispan:master","ref":"master","sha":"432e33ed5191dd3e9c312b0d39ca8043e9f71daa","user":{"login":"infinispan","id":458093,"avatar_url":"https://avatars.githubusercontent.com/u/458093?v=3","gravatar_id":"","url":"https://api.github.com/users/infinispan","html_url":"https://github.com/infinispan","followers_url":"https://api.github.com/users/infinispan/followers","following_url":"https://api.github.com/users/infinispan/following{/other_user}","gists_url":"https://api.github.com/users/infinispan/gists{/gist_id}","starred_url":"https://api.github.com/users/infinispan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infinispan/subscriptions","organizations_url":"https://api.github.com/users/infinispan/orgs","repos_url":"https://api.github.com/users/infinispan/repos","events_url":"https://api.github.com/users/infinispan/events{/privacy}","received_events_url":"https://api.github.com/users/infinispan/received_events","type":"Organization","site_admin":false},"repo":{"id":1050944,"name":"infinispan","full_name":"infinispan/infinispan","owner":{"login":"infinispan","id":458093,"avatar_url":"https://avatars.githubusercontent.com/u/458093?v=3","gravatar_id":"","url":"https://api.github.com/users/infinispan","html_url":"https://github.com/infinispan","followers_url":"https://api.github.com/users/infinispan/followers","following_url":"https://api.github.com/users/infinispan/following{/other_user}","gists_url":"https://api.github.com/users/infinispan/gists{/gist_id}","starred_url":"https://api.github.com/users/infinispan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infinispan/subscriptions","organizations_url":"https://api.github.com/users/infinispan/orgs","repos_url":"https://api.github.com/users/infinispan/repos","events_url":"https://api.github.com/users/infinispan/events{/privacy}","received_events_url":"https://api.github.com/users/infinispan/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/infinispan/infinispan","description":"Infinispan is an open source data grid platform and highly scalable NoSQL cloud data store.","fork":false,"url":"https://api.github.com/repos/infinispan/infinispan","forks_url":"https://api.github.com/repos/infinispan/infinispan/forks","keys_url":"https://api.github.com/repos/infinispan/infinispan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/infinispan/infinispan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/infinispan/infinispan/teams","hooks_url":"https://api.github.com/repos/infinispan/infinispan/hooks","issue_events_url":"https://api.github.com/repos/infinispan/infinispan/issues/events{/number}","events_url":"https://api.github.com/repos/infinispan/infinispan/events","assignees_url":"https://api.github.com/repos/infinispan/infinispan/assignees{/user}","branches_url":"https://api.github.com/repos/infinispan/infinispan/branches{/branch}","tags_url":"https://api.github.com/repos/infinispan/infinispan/tags","blobs_url":"https://api.github.com/repos/infinispan/infinispan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/infinispan/infinispan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/infinispan/infinispan/git/refs{/sha}","trees_url":"https://api.github.com/repos/infinispan/infinispan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/infinispan/infinispan/statuses/{sha}","languages_url":"https://api.github.com/repos/infinispan/infinispan/languages","stargazers_url":"https://api.github.com/repos/infinispan/infinispan/stargazers","contributors_url":"https://api.github.com/repos/infinispan/infinispan/contributors","subscribers_url":"https://api.github.com/repos/infinispan/infinispan/subscribers","subscription_url":"https://api.github.com/repos/infinispan/infinispan/subscription","commits_url":"https://api.github.com/repos/infinispan/infinispan/commits{/sha}","git_commits_url":"https://api.github.com/repos/infinispan/infinispan/git/commits{/sha}","comments_url":"https://api.github.com/repos/infinispan/infinispan/comments{/number}","issue_comment_url":"https://api.github.com/repos/infinispan/infinispan/issues/comments{/number}","contents_url":"https://api.github.com/repos/infinispan/infinispan/contents/{+path}","compare_url":"https://api.github.com/repos/infinispan/infinispan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/infinispan/infinispan/merges","archive_url":"https://api.github.com/repos/infinispan/infinispan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/infinispan/infinispan/downloads","issues_url":"https://api.github.com/repos/infinispan/infinispan/issues{/number}","pulls_url":"https://api.github.com/repos/infinispan/infinispan/pulls{/number}","milestones_url":"https://api.github.com/repos/infinispan/infinispan/milestones{/number}","notifications_url":"https://api.github.com/repos/infinispan/infinispan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/infinispan/infinispan/labels{/name}","releases_url":"https://api.github.com/repos/infinispan/infinispan/releases{/id}","deployments_url":"https://api.github.com/repos/infinispan/infinispan/deployments","created_at":"2010-11-04T12:33:19Z","updated_at":"2016-09-25T05:20:36Z","pushed_at":"2016-09-26T06:18:57Z","git_url":"git://github.com/infinispan/infinispan.git","ssh_url":"git@github.com:infinispan/infinispan.git","clone_url":"https://github.com/infinispan/infinispan.git","svn_url":"https://github.com/infinispan/infinispan","homepage":"http://www.infinispan.org","size":101696,"stargazers_count":494,"watchers_count":494,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":363,"mirror_url":null,"open_issues_count":31,"forks":363,"open_issues":31,"watchers":494,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/4499"},"html":{"href":"https://github.com/infinispan/infinispan/pull/4499"},"issue":{"href":"https://api.github.com/repos/infinispan/infinispan/issues/4499"},"comments":{"href":"https://api.github.com/repos/infinispan/infinispan/issues/4499/comments"},"review_comments":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/4499/comments"},"review_comment":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/4499/commits"},"statuses":{"href":"https://api.github.com/repos/infinispan/infinispan/statuses/822d5a975347bc7f655d9d0fe167036164a232eb"}}}}
{"actor":{"display_login":"tristantarrant"}}