{"action":"created","comment":{"url":"https://api.github.com/repos/redhataccess/insights-client/pulls/comments/75383148","id":75383148,"diff_hunk":"@@ -169,6 +153,13 @@ def get_proxies(self, config):\n                 conf_proxy = scheme + location\n             logger.debug(\"CONF Proxy: %s\", conf_proxy)\n             proxies = {\"https\": conf_proxy}\n+\n+        if os.environ.get('NO_PROXY') and conf_proxy:\n+            logger.debug(\"Invalid Proxy configuration. \"\n+                         \"You have environment variable NO_PROXY set \"\n+                         \"as well as 'proxy' set in your configuration file. \"\n+                         \"This is invalid. Do not expect normal results.\")","path":"redhat_access_insights/connection.py","position":null,"original_position":43,"commit_id":"69e0533fb2e094787c2cf36be613c543349dba38","original_commit_id":"ed68c2c6fbc72831151c68fe2269243a12e3e446","user":{"login":"iphands","id":129737,"avatar_url":"https://avatars.githubusercontent.com/u/129737?v=3","gravatar_id":"","url":"https://api.github.com/users/iphands","html_url":"https://github.com/iphands","followers_url":"https://api.github.com/users/iphands/followers","following_url":"https://api.github.com/users/iphands/following{/other_user}","gists_url":"https://api.github.com/users/iphands/gists{/gist_id}","starred_url":"https://api.github.com/users/iphands/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iphands/subscriptions","organizations_url":"https://api.github.com/users/iphands/orgs","repos_url":"https://api.github.com/users/iphands/repos","events_url":"https://api.github.com/users/iphands/events{/privacy}","received_events_url":"https://api.github.com/users/iphands/received_events","type":"User","site_admin":false},"body":"Wait nvm, the config file proxy setting is incompatible with NO_PROXY, the HTTPS_PROXY is compatible.\r\n\r\n@lphiri what if we say \"If you want to use NO_PROXY, use HTTPS_PROXY instead of the config file(/etc/path/to/file.conf) proxy setting.\"","created_at":"2016-08-18T20:30:07Z","updated_at":"2016-08-18T20:30:07Z","html_url":"https://github.com/redhataccess/insights-client/pull/74#discussion_r75383148","pull_request_url":"https://api.github.com/repos/redhataccess/insights-client/pulls/74","_links":{"self":{"href":"https://api.github.com/repos/redhataccess/insights-client/pulls/comments/75383148"},"html":{"href":"https://github.com/redhataccess/insights-client/pull/74#discussion_r75383148"},"pull_request":{"href":"https://api.github.com/repos/redhataccess/insights-client/pulls/74"}}},"pull_request":{"url":"https://api.github.com/repos/redhataccess/insights-client/pulls/74","id":81864816,"html_url":"https://github.com/redhataccess/insights-client/pull/74","diff_url":"https://github.com/redhataccess/insights-client/pull/74.diff","patch_url":"https://github.com/redhataccess/insights-client/pull/74.patch","issue_url":"https://api.github.com/repos/redhataccess/insights-client/issues/74","number":74,"state":"open","locked":false,"title":"NO_PROXY now works as expected.","user":{"login":"brantleyr","id":1706212,"avatar_url":"https://avatars.githubusercontent.com/u/1706212?v=3","gravatar_id":"","url":"https://api.github.com/users/brantleyr","html_url":"https://github.com/brantleyr","followers_url":"https://api.github.com/users/brantleyr/followers","following_url":"https://api.github.com/users/brantleyr/following{/other_user}","gists_url":"https://api.github.com/users/brantleyr/gists{/gist_id}","starred_url":"https://api.github.com/users/brantleyr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brantleyr/subscriptions","organizations_url":"https://api.github.com/users/brantleyr/orgs","repos_url":"https://api.github.com/users/brantleyr/repos","events_url":"https://api.github.com/users/brantleyr/events{/privacy}","received_events_url":"https://api.github.com/users/brantleyr/received_events","type":"User","site_admin":false},"body":"Proposed changes.","created_at":"2016-08-18T18:30:50Z","updated_at":"2016-08-18T20:30:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f3273742d7ee3f1f1ae7f5e89b19cbc5dfab2283","assignee":{"login":"gravitypriest","id":11755952,"avatar_url":"https://avatars.githubusercontent.com/u/11755952?v=3","gravatar_id":"","url":"https://api.github.com/users/gravitypriest","html_url":"https://github.com/gravitypriest","followers_url":"https://api.github.com/users/gravitypriest/followers","following_url":"https://api.github.com/users/gravitypriest/following{/other_user}","gists_url":"https://api.github.com/users/gravitypriest/gists{/gist_id}","starred_url":"https://api.github.com/users/gravitypriest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gravitypriest/subscriptions","organizations_url":"https://api.github.com/users/gravitypriest/orgs","repos_url":"https://api.github.com/users/gravitypriest/repos","events_url":"https://api.github.com/users/gravitypriest/events{/privacy}","received_events_url":"https://api.github.com/users/gravitypriest/received_events","type":"User","site_admin":false},"assignees":[{"login":"gravitypriest","id":11755952,"avatar_url":"https://avatars.githubusercontent.com/u/11755952?v=3","gravatar_id":"","url":"https://api.github.com/users/gravitypriest","html_url":"https://github.com/gravitypriest","followers_url":"https://api.github.com/users/gravitypriest/followers","following_url":"https://api.github.com/users/gravitypriest/following{/other_user}","gists_url":"https://api.github.com/users/gravitypriest/gists{/gist_id}","starred_url":"https://api.github.com/users/gravitypriest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gravitypriest/subscriptions","organizations_url":"https://api.github.com/users/gravitypriest/orgs","repos_url":"https://api.github.com/users/gravitypriest/repos","events_url":"https://api.github.com/users/gravitypriest/events{/privacy}","received_events_url":"https://api.github.com/users/gravitypriest/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/redhataccess/insights-client/pulls/74/commits","review_comments_url":"https://api.github.com/repos/redhataccess/insights-client/pulls/74/comments","review_comment_url":"https://api.github.com/repos/redhataccess/insights-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/redhataccess/insights-client/issues/74/comments","statuses_url":"https://api.github.com/repos/redhataccess/insights-client/statuses/69e0533fb2e094787c2cf36be613c543349dba38","head":{"label":"redhataccess:FixNoProxyEnvWoes","ref":"FixNoProxyEnvWoes","sha":"69e0533fb2e094787c2cf36be613c543349dba38","user":{"login":"redhataccess","id":6578594,"avatar_url":"https://avatars.githubusercontent.com/u/6578594?v=3","gravatar_id":"","url":"https://api.github.com/users/redhataccess","html_url":"https://github.com/redhataccess","followers_url":"https://api.github.com/users/redhataccess/followers","following_url":"https://api.github.com/users/redhataccess/following{/other_user}","gists_url":"https://api.github.com/users/redhataccess/gists{/gist_id}","starred_url":"https://api.github.com/users/redhataccess/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redhataccess/subscriptions","organizations_url":"https://api.github.com/users/redhataccess/orgs","repos_url":"https://api.github.com/users/redhataccess/repos","events_url":"https://api.github.com/users/redhataccess/events{/privacy}","received_events_url":"https://api.github.com/users/redhataccess/received_events","type":"Organization","site_admin":false},"repo":{"id":34472397,"name":"insights-client","full_name":"redhataccess/insights-client","owner":{"login":"redhataccess","id":6578594,"avatar_url":"https://avatars.githubusercontent.com/u/6578594?v=3","gravatar_id":"","url":"https://api.github.com/users/redhataccess","html_url":"https://github.com/redhataccess","followers_url":"https://api.github.com/users/redhataccess/followers","following_url":"https://api.github.com/users/redhataccess/following{/other_user}","gists_url":"https://api.github.com/users/redhataccess/gists{/gist_id}","starred_url":"https://api.github.com/users/redhataccess/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redhataccess/subscriptions","organizations_url":"https://api.github.com/users/redhataccess/orgs","repos_url":"https://api.github.com/users/redhataccess/repos","events_url":"https://api.github.com/users/redhataccess/events{/privacy}","received_events_url":"https://api.github.com/users/redhataccess/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/redhataccess/insights-client","description":"Red Hat Insights Client","fork":false,"url":"https://api.github.com/repos/redhataccess/insights-client","forks_url":"https://api.github.com/repos/redhataccess/insights-client/forks","keys_url":"https://api.github.com/repos/redhataccess/insights-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/redhataccess/insights-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/redhataccess/insights-client/teams","hooks_url":"https://api.github.com/repos/redhataccess/insights-client/hooks","issue_events_url":"https://api.github.com/repos/redhataccess/insights-client/issues/events{/number}","events_url":"https://api.github.com/repos/redhataccess/insights-client/events","assignees_url":"https://api.github.com/repos/redhataccess/insights-client/assignees{/user}","branches_url":"https://api.github.com/repos/redhataccess/insights-client/branches{/branch}","tags_url":"https://api.github.com/repos/redhataccess/insights-client/tags","blobs_url":"https://api.github.com/repos/redhataccess/insights-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/redhataccess/insights-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/redhataccess/insights-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/redhataccess/insights-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/redhataccess/insights-client/statuses/{sha}","languages_url":"https://api.github.com/repos/redhataccess/insights-client/languages","stargazers_url":"https://api.github.com/repos/redhataccess/insights-client/stargazers","contributors_url":"https://api.github.com/repos/redhataccess/insights-client/contributors","subscribers_url":"https://api.github.com/repos/redhataccess/insights-client/subscribers","subscription_url":"https://api.github.com/repos/redhataccess/insights-client/subscription","commits_url":"https://api.github.com/repos/redhataccess/insights-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/redhataccess/insights-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/redhataccess/insights-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/redhataccess/insights-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/redhataccess/insights-client/contents/{+path}","compare_url":"https://api.github.com/repos/redhataccess/insights-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/redhataccess/insights-client/merges","archive_url":"https://api.github.com/repos/redhataccess/insights-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/redhataccess/insights-client/downloads","issues_url":"https://api.github.com/repos/redhataccess/insights-client/issues{/number}","pulls_url":"https://api.github.com/repos/redhataccess/insights-client/pulls{/number}","milestones_url":"https://api.github.com/repos/redhataccess/insights-client/milestones{/number}","notifications_url":"https://api.github.com/repos/redhataccess/insights-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/redhataccess/insights-client/labels{/name}","releases_url":"https://api.github.com/repos/redhataccess/insights-client/releases{/id}","deployments_url":"https://api.github.com/repos/redhataccess/insights-client/deployments","created_at":"2015-04-23T17:54:11Z","updated_at":"2016-08-16T03:55:04Z","pushed_at":"2016-08-18T19:51:41Z","git_url":"git://github.com/redhataccess/insights-client.git","ssh_url":"git@github.com:redhataccess/insights-client.git","clone_url":"https://github.com/redhataccess/insights-client.git","svn_url":"https://github.com/redhataccess/insights-client","homepage":"https://access.redhat.com/insights","size":661,"stargazers_count":9,"watchers_count":9,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":4,"forks":11,"open_issues":4,"watchers":9,"default_branch":"master"}},"base":{"label":"redhataccess:rhel-7","ref":"rhel-7","sha":"c2207b5f45caa1a76e083204fd162882b8933719","user":{"login":"redhataccess","id":6578594,"avatar_url":"https://avatars.githubusercontent.com/u/6578594?v=3","gravatar_id":"","url":"https://api.github.com/users/redhataccess","html_url":"https://github.com/redhataccess","followers_url":"https://api.github.com/users/redhataccess/followers","following_url":"https://api.github.com/users/redhataccess/following{/other_user}","gists_url":"https://api.github.com/users/redhataccess/gists{/gist_id}","starred_url":"https://api.github.com/users/redhataccess/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redhataccess/subscriptions","organizations_url":"https://api.github.com/users/redhataccess/orgs","repos_url":"https://api.github.com/users/redhataccess/repos","events_url":"https://api.github.com/users/redhataccess/events{/privacy}","received_events_url":"https://api.github.com/users/redhataccess/received_events","type":"Organization","site_admin":false},"repo":{"id":34472397,"name":"insights-client","full_name":"redhataccess/insights-client","owner":{"login":"redhataccess","id":6578594,"avatar_url":"https://avatars.githubusercontent.com/u/6578594?v=3","gravatar_id":"","url":"https://api.github.com/users/redhataccess","html_url":"https://github.com/redhataccess","followers_url":"https://api.github.com/users/redhataccess/followers","following_url":"https://api.github.com/users/redhataccess/following{/other_user}","gists_url":"https://api.github.com/users/redhataccess/gists{/gist_id}","starred_url":"https://api.github.com/users/redhataccess/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redhataccess/subscriptions","organizations_url":"https://api.github.com/users/redhataccess/orgs","repos_url":"https://api.github.com/users/redhataccess/repos","events_url":"https://api.github.com/users/redhataccess/events{/privacy}","received_events_url":"https://api.github.com/users/redhataccess/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/redhataccess/insights-client","description":"Red Hat Insights Client","fork":false,"url":"https://api.github.com/repos/redhataccess/insights-client","forks_url":"https://api.github.com/repos/redhataccess/insights-client/forks","keys_url":"https://api.github.com/repos/redhataccess/insights-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/redhataccess/insights-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/redhataccess/insights-client/teams","hooks_url":"https://api.github.com/repos/redhataccess/insights-client/hooks","issue_events_url":"https://api.github.com/repos/redhataccess/insights-client/issues/events{/number}","events_url":"https://api.github.com/repos/redhataccess/insights-client/events","assignees_url":"https://api.github.com/repos/redhataccess/insights-client/assignees{/user}","branches_url":"https://api.github.com/repos/redhataccess/insights-client/branches{/branch}","tags_url":"https://api.github.com/repos/redhataccess/insights-client/tags","blobs_url":"https://api.github.com/repos/redhataccess/insights-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/redhataccess/insights-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/redhataccess/insights-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/redhataccess/insights-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/redhataccess/insights-client/statuses/{sha}","languages_url":"https://api.github.com/repos/redhataccess/insights-client/languages","stargazers_url":"https://api.github.com/repos/redhataccess/insights-client/stargazers","contributors_url":"https://api.github.com/repos/redhataccess/insights-client/contributors","subscribers_url":"https://api.github.com/repos/redhataccess/insights-client/subscribers","subscription_url":"https://api.github.com/repos/redhataccess/insights-client/subscription","commits_url":"https://api.github.com/repos/redhataccess/insights-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/redhataccess/insights-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/redhataccess/insights-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/redhataccess/insights-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/redhataccess/insights-client/contents/{+path}","compare_url":"https://api.github.com/repos/redhataccess/insights-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/redhataccess/insights-client/merges","archive_url":"https://api.github.com/repos/redhataccess/insights-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/redhataccess/insights-client/downloads","issues_url":"https://api.github.com/repos/redhataccess/insights-client/issues{/number}","pulls_url":"https://api.github.com/repos/redhataccess/insights-client/pulls{/number}","milestones_url":"https://api.github.com/repos/redhataccess/insights-client/milestones{/number}","notifications_url":"https://api.github.com/repos/redhataccess/insights-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/redhataccess/insights-client/labels{/name}","releases_url":"https://api.github.com/repos/redhataccess/insights-client/releases{/id}","deployments_url":"https://api.github.com/repos/redhataccess/insights-client/deployments","created_at":"2015-04-23T17:54:11Z","updated_at":"2016-08-16T03:55:04Z","pushed_at":"2016-08-18T19:51:41Z","git_url":"git://github.com/redhataccess/insights-client.git","ssh_url":"git@github.com:redhataccess/insights-client.git","clone_url":"https://github.com/redhataccess/insights-client.git","svn_url":"https://github.com/redhataccess/insights-client","homepage":"https://access.redhat.com/insights","size":661,"stargazers_count":9,"watchers_count":9,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":4,"forks":11,"open_issues":4,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/redhataccess/insights-client/pulls/74"},"html":{"href":"https://github.com/redhataccess/insights-client/pull/74"},"issue":{"href":"https://api.github.com/repos/redhataccess/insights-client/issues/74"},"comments":{"href":"https://api.github.com/repos/redhataccess/insights-client/issues/74/comments"},"review_comments":{"href":"https://api.github.com/repos/redhataccess/insights-client/pulls/74/comments"},"review_comment":{"href":"https://api.github.com/repos/redhataccess/insights-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/redhataccess/insights-client/pulls/74/commits"},"statuses":{"href":"https://api.github.com/repos/redhataccess/insights-client/statuses/69e0533fb2e094787c2cf36be613c543349dba38"}}}}
{"actor":{"display_login":"iphands"}}