{"action":"created","comment":{"url":"https://api.github.com/repos/alphagov/specialist-publisher/pulls/comments/56688664","id":56688664,"diff_hunk":"@@ -0,0 +1,9 @@\n+<%= form_for(@attachment, :url => document_attachments_path(params[:document_type], params[:document_content_id])) do |f| %>","path":"app/views/attachments/new.html.erb","position":1,"original_position":1,"commit_id":"abb90634d3c10f1290289bd7042dfc710f3f0bd1","original_commit_id":"abb90634d3c10f1290289bd7042dfc710f3f0bd1","user":{"login":"danielroseman","id":131395,"avatar_url":"https://avatars.githubusercontent.com/u/131395?v=3","gravatar_id":"","url":"https://api.github.com/users/danielroseman","html_url":"https://github.com/danielroseman","followers_url":"https://api.github.com/users/danielroseman/followers","following_url":"https://api.github.com/users/danielroseman/following{/other_user}","gists_url":"https://api.github.com/users/danielroseman/gists{/gist_id}","starred_url":"https://api.github.com/users/danielroseman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielroseman/subscriptions","organizations_url":"https://api.github.com/users/danielroseman/orgs","repos_url":"https://api.github.com/users/danielroseman/repos","events_url":"https://api.github.com/users/danielroseman/events{/privacy}","received_events_url":"https://api.github.com/users/danielroseman/received_events","type":"User","site_admin":false},"body":"Styling on this page doesn't seem right - we are missing the surrounding page elements. In the original app the form was in _form.html.erb and there is extra stuff in the new/edit views.","created_at":"2016-03-18T17:03:15Z","updated_at":"2016-03-18T17:03:15Z","html_url":"https://github.com/alphagov/specialist-publisher/pull/680#discussion_r56688664","pull_request_url":"https://api.github.com/repos/alphagov/specialist-publisher/pulls/680","_links":{"self":{"href":"https://api.github.com/repos/alphagov/specialist-publisher/pulls/comments/56688664"},"html":{"href":"https://github.com/alphagov/specialist-publisher/pull/680#discussion_r56688664"},"pull_request":{"href":"https://api.github.com/repos/alphagov/specialist-publisher/pulls/680"}}},"pull_request":{"url":"https://api.github.com/repos/alphagov/specialist-publisher/pulls/680","id":63375667,"html_url":"https://github.com/alphagov/specialist-publisher/pull/680","diff_url":"https://github.com/alphagov/specialist-publisher/pull/680.diff","patch_url":"https://github.com/alphagov/specialist-publisher/pull/680.patch","issue_url":"https://api.github.com/repos/alphagov/specialist-publisher/issues/680","number":680,"state":"open","locked":false,"title":"Add attachment to specialist-document","user":{"login":"mathildathompson","id":3854347,"avatar_url":"https://avatars.githubusercontent.com/u/3854347?v=3","gravatar_id":"","url":"https://api.github.com/users/mathildathompson","html_url":"https://github.com/mathildathompson","followers_url":"https://api.github.com/users/mathildathompson/followers","following_url":"https://api.github.com/users/mathildathompson/following{/other_user}","gists_url":"https://api.github.com/users/mathildathompson/gists{/gist_id}","starred_url":"https://api.github.com/users/mathildathompson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mathildathompson/subscriptions","organizations_url":"https://api.github.com/users/mathildathompson/orgs","repos_url":"https://api.github.com/users/mathildathompson/repos","events_url":"https://api.github.com/users/mathildathompson/events{/privacy}","received_events_url":"https://api.github.com/users/mathildathompson/received_events","type":"User","site_admin":false},"body":"- Attachment uploaded to asset-manager\r\n- Attachment added to specialist-document content-schema (nested inside details hash)\r\n- Attachment controller added to render new attachment form and handle attachment being saved inside specialist-document content-item\r\n- Feature and unit test for attachment_presenter, attachment model and document model\r\n\r\n@danielroseman I have currently only added: \"#save! with attachments\", \"#upload\" to cma_case_spec, I want to check this is correct before I duplicate it inside all the other tests;\r\n\r\n- Do I need to add controller test, or are the feature test sufficient to cover this?\r\n- I still need to complete attachment edit functionality, but there is a lot in here so though it would be a good idea to get it reviewed; ","created_at":"2016-03-18T13:43:09Z","updated_at":"2016-03-18T17:03:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"81981ec707c215c00150810a8b261c2a628e5200","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/alphagov/specialist-publisher/pulls/680/commits","review_comments_url":"https://api.github.com/repos/alphagov/specialist-publisher/pulls/680/comments","review_comment_url":"https://api.github.com/repos/alphagov/specialist-publisher/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alphagov/specialist-publisher/issues/680/comments","statuses_url":"https://api.github.com/repos/alphagov/specialist-publisher/statuses/abb90634d3c10f1290289bd7042dfc710f3f0bd1","head":{"label":"alphagov:add-attachments-to-specialist-documents","ref":"add-attachments-to-specialist-documents","sha":"abb90634d3c10f1290289bd7042dfc710f3f0bd1","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":16176198,"name":"specialist-publisher","full_name":"alphagov/specialist-publisher","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/specialist-publisher","description":"Publishing App for Specialist Documents and Manuals on GOV.UK","fork":false,"url":"https://api.github.com/repos/alphagov/specialist-publisher","forks_url":"https://api.github.com/repos/alphagov/specialist-publisher/forks","keys_url":"https://api.github.com/repos/alphagov/specialist-publisher/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/specialist-publisher/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/specialist-publisher/teams","hooks_url":"https://api.github.com/repos/alphagov/specialist-publisher/hooks","issue_events_url":"https://api.github.com/repos/alphagov/specialist-publisher/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/specialist-publisher/events","assignees_url":"https://api.github.com/repos/alphagov/specialist-publisher/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/specialist-publisher/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/specialist-publisher/tags","blobs_url":"https://api.github.com/repos/alphagov/specialist-publisher/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/specialist-publisher/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/specialist-publisher/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/specialist-publisher/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/specialist-publisher/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/specialist-publisher/languages","stargazers_url":"https://api.github.com/repos/alphagov/specialist-publisher/stargazers","contributors_url":"https://api.github.com/repos/alphagov/specialist-publisher/contributors","subscribers_url":"https://api.github.com/repos/alphagov/specialist-publisher/subscribers","subscription_url":"https://api.github.com/repos/alphagov/specialist-publisher/subscription","commits_url":"https://api.github.com/repos/alphagov/specialist-publisher/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/specialist-publisher/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/specialist-publisher/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/specialist-publisher/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/specialist-publisher/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/specialist-publisher/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/specialist-publisher/merges","archive_url":"https://api.github.com/repos/alphagov/specialist-publisher/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/specialist-publisher/downloads","issues_url":"https://api.github.com/repos/alphagov/specialist-publisher/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/specialist-publisher/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/specialist-publisher/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/specialist-publisher/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/specialist-publisher/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/specialist-publisher/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/specialist-publisher/deployments","created_at":"2014-01-23T15:21:42Z","updated_at":"2016-01-13T12:00:31Z","pushed_at":"2016-03-18T16:57:53Z","git_url":"git://github.com/alphagov/specialist-publisher.git","ssh_url":"git@github.com:alphagov/specialist-publisher.git","clone_url":"https://github.com/alphagov/specialist-publisher.git","svn_url":"https://github.com/alphagov/specialist-publisher","homepage":"","size":5544,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":9,"forks":10,"open_issues":9,"watchers":3,"default_branch":"master"}},"base":{"label":"alphagov:phase-two","ref":"phase-two","sha":"468bb4f574190522d9d54bba5b21893d810219b6","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":16176198,"name":"specialist-publisher","full_name":"alphagov/specialist-publisher","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/specialist-publisher","description":"Publishing App for Specialist Documents and Manuals on GOV.UK","fork":false,"url":"https://api.github.com/repos/alphagov/specialist-publisher","forks_url":"https://api.github.com/repos/alphagov/specialist-publisher/forks","keys_url":"https://api.github.com/repos/alphagov/specialist-publisher/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/specialist-publisher/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/specialist-publisher/teams","hooks_url":"https://api.github.com/repos/alphagov/specialist-publisher/hooks","issue_events_url":"https://api.github.com/repos/alphagov/specialist-publisher/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/specialist-publisher/events","assignees_url":"https://api.github.com/repos/alphagov/specialist-publisher/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/specialist-publisher/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/specialist-publisher/tags","blobs_url":"https://api.github.com/repos/alphagov/specialist-publisher/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/specialist-publisher/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/specialist-publisher/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/specialist-publisher/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/specialist-publisher/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/specialist-publisher/languages","stargazers_url":"https://api.github.com/repos/alphagov/specialist-publisher/stargazers","contributors_url":"https://api.github.com/repos/alphagov/specialist-publisher/contributors","subscribers_url":"https://api.github.com/repos/alphagov/specialist-publisher/subscribers","subscription_url":"https://api.github.com/repos/alphagov/specialist-publisher/subscription","commits_url":"https://api.github.com/repos/alphagov/specialist-publisher/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/specialist-publisher/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/specialist-publisher/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/specialist-publisher/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/specialist-publisher/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/specialist-publisher/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/specialist-publisher/merges","archive_url":"https://api.github.com/repos/alphagov/specialist-publisher/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/specialist-publisher/downloads","issues_url":"https://api.github.com/repos/alphagov/specialist-publisher/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/specialist-publisher/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/specialist-publisher/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/specialist-publisher/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/specialist-publisher/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/specialist-publisher/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/specialist-publisher/deployments","created_at":"2014-01-23T15:21:42Z","updated_at":"2016-01-13T12:00:31Z","pushed_at":"2016-03-18T16:57:53Z","git_url":"git://github.com/alphagov/specialist-publisher.git","ssh_url":"git@github.com:alphagov/specialist-publisher.git","clone_url":"https://github.com/alphagov/specialist-publisher.git","svn_url":"https://github.com/alphagov/specialist-publisher","homepage":"","size":5544,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":9,"forks":10,"open_issues":9,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alphagov/specialist-publisher/pulls/680"},"html":{"href":"https://github.com/alphagov/specialist-publisher/pull/680"},"issue":{"href":"https://api.github.com/repos/alphagov/specialist-publisher/issues/680"},"comments":{"href":"https://api.github.com/repos/alphagov/specialist-publisher/issues/680/comments"},"review_comments":{"href":"https://api.github.com/repos/alphagov/specialist-publisher/pulls/680/comments"},"review_comment":{"href":"https://api.github.com/repos/alphagov/specialist-publisher/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alphagov/specialist-publisher/pulls/680/commits"},"statuses":{"href":"https://api.github.com/repos/alphagov/specialist-publisher/statuses/abb90634d3c10f1290289bd7042dfc710f3f0bd1"}}}}