{"action":"created","issue":{"url":"https://api.github.com/repos/kolodny/jsan/issues/7","repository_url":"https://api.github.com/repos/kolodny/jsan","labels_url":"https://api.github.com/repos/kolodny/jsan/issues/7/labels{/name}","comments_url":"https://api.github.com/repos/kolodny/jsan/issues/7/comments","events_url":"https://api.github.com/repos/kolodny/jsan/issues/7/events","html_url":"https://github.com/kolodny/jsan/issues/7","id":190550017,"number":7,"title":"Strip circular references","user":{"login":"zalmoxisus","id":7957859,"avatar_url":"https://avatars.githubusercontent.com/u/7957859?v=3","gravatar_id":"","url":"https://api.github.com/users/zalmoxisus","html_url":"https://github.com/zalmoxisus","followers_url":"https://api.github.com/users/zalmoxisus/followers","following_url":"https://api.github.com/users/zalmoxisus/following{/other_user}","gists_url":"https://api.github.com/users/zalmoxisus/gists{/gist_id}","starred_url":"https://api.github.com/users/zalmoxisus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zalmoxisus/subscriptions","organizations_url":"https://api.github.com/users/zalmoxisus/orgs","repos_url":"https://api.github.com/users/zalmoxisus/repos","events_url":"https://api.github.com/users/zalmoxisus/events{/privacy}","received_events_url":"https://api.github.com/users/zalmoxisus/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-11-20T10:14:48Z","updated_at":"2016-11-21T03:50:07Z","closed_at":null,"body":"While it's great that jsan can restore circular references, in many cases we want them stripped as it will affect rendering perf and [could hang object traversing](https://github.com/alexkuz/redux-devtools-inspector/pull/40).\r\n\r\nIt would be useful to have an additional parameter to use it like so:\r\n```js\r\njsan.parse(obj, null, '[CIRCULAR]');\r\n```\r\nOr if it is more performant we could strip them while stringifying. I couldn't wrap my head around it, but it seems that it would be easier to do while parsing inside `retrocycle`."},"comment":{"url":"https://api.github.com/repos/kolodny/jsan/issues/comments/261836184","html_url":"https://github.com/kolodny/jsan/issues/7#issuecomment-261836184","issue_url":"https://api.github.com/repos/kolodny/jsan/issues/7","id":261836184,"user":{"login":"kolodny","id":1187604,"avatar_url":"https://avatars.githubusercontent.com/u/1187604?v=3","gravatar_id":"","url":"https://api.github.com/users/kolodny","html_url":"https://github.com/kolodny","followers_url":"https://api.github.com/users/kolodny/followers","following_url":"https://api.github.com/users/kolodny/following{/other_user}","gists_url":"https://api.github.com/users/kolodny/gists{/gist_id}","starred_url":"https://api.github.com/users/kolodny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kolodny/subscriptions","organizations_url":"https://api.github.com/users/kolodny/orgs","repos_url":"https://api.github.com/users/kolodny/repos","events_url":"https://api.github.com/users/kolodny/events{/privacy}","received_events_url":"https://api.github.com/users/kolodny/received_events","type":"User","site_admin":false},"created_at":"2016-11-21T03:50:07Z","updated_at":"2016-11-21T03:50:07Z","body":"Hmm, that's not a trivial problem. I guess we can detect something like that by checking that `path.indexOf(foundPath) === 0` by https://github.com/kolodny/jsan/blob/0867ecfda1b0815a4538c658805e54c2610e36c1/lib/cycle.js#L79 but I'm not sold on baking that into jsan. Can you think of a less hacky implementation?"}}
{"actor":{"display_login":"kolodny"}}