{"action":"created","comment":{"url":"https://api.github.com/repos/universal-ctags/ctags/pulls/comments/75585129","id":75585129,"diff_hunk":"@@ -135,6 +135,13 @@ extern unsigned long getInputLineNumber (void)\n \treturn File.input.lineNumber;\n }\n \n+extern int getInputLineOffset (void)\n+{\n+\tunsigned char *base = (unsigned char *) vStringValue (File.line);\n+\tint ret = File.currentLine - base - File.ungetchIdx;\n+\treturn ret >= 0 ? ret : 0;","path":"main/read.c","position":8,"original_position":8,"commit_id":"5f9b8780d800390fb240ba147d466ce5a01a109c","original_commit_id":"c90cd07a3005635fc28362cb870b47400747aca8","user":{"login":"b4n","id":793526,"avatar_url":"https://avatars.githubusercontent.com/u/793526?v=3","gravatar_id":"","url":"https://api.github.com/users/b4n","html_url":"https://github.com/b4n","followers_url":"https://api.github.com/users/b4n/followers","following_url":"https://api.github.com/users/b4n/following{/other_user}","gists_url":"https://api.github.com/users/b4n/gists{/gist_id}","starred_url":"https://api.github.com/users/b4n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/b4n/subscriptions","organizations_url":"https://api.github.com/users/b4n/orgs","repos_url":"https://api.github.com/users/b4n/repos","events_url":"https://api.github.com/users/b4n/events{/privacy}","received_events_url":"https://api.github.com/users/b4n/received_events","type":"User","site_admin":false},"body":"Agreed it's unlikely to really matter (even more so as it's likely to be 1 byte at most), but we never know until it bites :)\r\n\r\nAnyway, not a blocker, it's a mere comment on a current limitation.","created_at":"2016-08-20T21:35:41Z","updated_at":"2016-08-20T21:35:41Z","html_url":"https://github.com/universal-ctags/ctags/pull/1079#discussion_r75585129","pull_request_url":"https://api.github.com/repos/universal-ctags/ctags/pulls/1079","_links":{"self":{"href":"https://api.github.com/repos/universal-ctags/ctags/pulls/comments/75585129"},"html":{"href":"https://github.com/universal-ctags/ctags/pull/1079#discussion_r75585129"},"pull_request":{"href":"https://api.github.com/repos/universal-ctags/ctags/pulls/1079"}}},"pull_request":{"url":"https://api.github.com/repos/universal-ctags/ctags/pulls/1079","id":81532351,"html_url":"https://github.com/universal-ctags/ctags/pull/1079","diff_url":"https://github.com/universal-ctags/ctags/pull/1079.diff","patch_url":"https://github.com/universal-ctags/ctags/pull/1079.patch","issue_url":"https://api.github.com/repos/universal-ctags/ctags/issues/1079","number":1079,"state":"open","locked":false,"title":"Token-based HTML parser","user":{"login":"techee","id":713965,"avatar_url":"https://avatars.githubusercontent.com/u/713965?v=3","gravatar_id":"","url":"https://api.github.com/users/techee","html_url":"https://github.com/techee","followers_url":"https://api.github.com/users/techee/followers","following_url":"https://api.github.com/users/techee/following{/other_user}","gists_url":"https://api.github.com/users/techee/gists{/gist_id}","starred_url":"https://api.github.com/users/techee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/techee/subscriptions","organizations_url":"https://api.github.com/users/techee/orgs","repos_url":"https://api.github.com/users/techee/repos","events_url":"https://api.github.com/users/techee/events{/privacy}","received_events_url":"https://api.github.com/users/techee/received_events","type":"User","site_admin":false},"body":"This is a new token-based HTML parser. Apart from the usual advantages like comment detection and EOL independence the main goals of creating it were:\r\n\r\n- support of additional tags we have in Geany (h1, h2, h3) \r\n- speed - for universal-ctags it brings the parsing speed of the boost library html documentation from 5.5s to 3.2s (in Geany the speed difference is even bigger because for h1, h2, h3 tags we have additional 3 regexes which make the parsing speed about 2x slow in the original regex-based parser)\r\n- good error recovery when run on invalid input - this is important for Geany where using real XML parser would be probably too strict during typing and would end with an error so the symbol list would be probably empty most of the time\r\n\r\nI didn't really want to spend much time on parsing embedded javascript code so the parser just simulates the original regex for the javascript functions with all its limitations.\r\n\r\nIt should be quite easy to further extend the parser and detect additional tags and attributes.\r\n\r\ncc @b4n ","created_at":"2016-08-16T19:45:26Z","updated_at":"2016-08-20T21:35:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ed49ab9e3008b2bf896ed48f6e156762bf5ebca4","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/universal-ctags/ctags/pulls/1079/commits","review_comments_url":"https://api.github.com/repos/universal-ctags/ctags/pulls/1079/comments","review_comment_url":"https://api.github.com/repos/universal-ctags/ctags/pulls/comments{/number}","comments_url":"https://api.github.com/repos/universal-ctags/ctags/issues/1079/comments","statuses_url":"https://api.github.com/repos/universal-ctags/ctags/statuses/5f9b8780d800390fb240ba147d466ce5a01a109c","head":{"label":"techee:html_parser","ref":"html_parser","sha":"5f9b8780d800390fb240ba147d466ce5a01a109c","user":{"login":"techee","id":713965,"avatar_url":"https://avatars.githubusercontent.com/u/713965?v=3","gravatar_id":"","url":"https://api.github.com/users/techee","html_url":"https://github.com/techee","followers_url":"https://api.github.com/users/techee/followers","following_url":"https://api.github.com/users/techee/following{/other_user}","gists_url":"https://api.github.com/users/techee/gists{/gist_id}","starred_url":"https://api.github.com/users/techee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/techee/subscriptions","organizations_url":"https://api.github.com/users/techee/orgs","repos_url":"https://api.github.com/users/techee/repos","events_url":"https://api.github.com/users/techee/events{/privacy}","received_events_url":"https://api.github.com/users/techee/received_events","type":"User","site_admin":false},"repo":{"id":27652831,"name":"ctags","full_name":"techee/ctags","owner":{"login":"techee","id":713965,"avatar_url":"https://avatars.githubusercontent.com/u/713965?v=3","gravatar_id":"","url":"https://api.github.com/users/techee","html_url":"https://github.com/techee","followers_url":"https://api.github.com/users/techee/followers","following_url":"https://api.github.com/users/techee/following{/other_user}","gists_url":"https://api.github.com/users/techee/gists{/gist_id}","starred_url":"https://api.github.com/users/techee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/techee/subscriptions","organizations_url":"https://api.github.com/users/techee/orgs","repos_url":"https://api.github.com/users/techee/repos","events_url":"https://api.github.com/users/techee/events{/privacy}","received_events_url":"https://api.github.com/users/techee/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/techee/ctags","description":"clone of official ctags repo with obj-c and css patches added","fork":true,"url":"https://api.github.com/repos/techee/ctags","forks_url":"https://api.github.com/repos/techee/ctags/forks","keys_url":"https://api.github.com/repos/techee/ctags/keys{/key_id}","collaborators_url":"https://api.github.com/repos/techee/ctags/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/techee/ctags/teams","hooks_url":"https://api.github.com/repos/techee/ctags/hooks","issue_events_url":"https://api.github.com/repos/techee/ctags/issues/events{/number}","events_url":"https://api.github.com/repos/techee/ctags/events","assignees_url":"https://api.github.com/repos/techee/ctags/assignees{/user}","branches_url":"https://api.github.com/repos/techee/ctags/branches{/branch}","tags_url":"https://api.github.com/repos/techee/ctags/tags","blobs_url":"https://api.github.com/repos/techee/ctags/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/techee/ctags/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/techee/ctags/git/refs{/sha}","trees_url":"https://api.github.com/repos/techee/ctags/git/trees{/sha}","statuses_url":"https://api.github.com/repos/techee/ctags/statuses/{sha}","languages_url":"https://api.github.com/repos/techee/ctags/languages","stargazers_url":"https://api.github.com/repos/techee/ctags/stargazers","contributors_url":"https://api.github.com/repos/techee/ctags/contributors","subscribers_url":"https://api.github.com/repos/techee/ctags/subscribers","subscription_url":"https://api.github.com/repos/techee/ctags/subscription","commits_url":"https://api.github.com/repos/techee/ctags/commits{/sha}","git_commits_url":"https://api.github.com/repos/techee/ctags/git/commits{/sha}","comments_url":"https://api.github.com/repos/techee/ctags/comments{/number}","issue_comment_url":"https://api.github.com/repos/techee/ctags/issues/comments{/number}","contents_url":"https://api.github.com/repos/techee/ctags/contents/{+path}","compare_url":"https://api.github.com/repos/techee/ctags/compare/{base}...{head}","merges_url":"https://api.github.com/repos/techee/ctags/merges","archive_url":"https://api.github.com/repos/techee/ctags/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/techee/ctags/downloads","issues_url":"https://api.github.com/repos/techee/ctags/issues{/number}","pulls_url":"https://api.github.com/repos/techee/ctags/pulls{/number}","milestones_url":"https://api.github.com/repos/techee/ctags/milestones{/number}","notifications_url":"https://api.github.com/repos/techee/ctags/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/techee/ctags/labels{/name}","releases_url":"https://api.github.com/repos/techee/ctags/releases{/id}","deployments_url":"https://api.github.com/repos/techee/ctags/deployments","created_at":"2014-12-06T23:29:21Z","updated_at":"2014-12-06T23:29:24Z","pushed_at":"2016-08-20T21:25:39Z","git_url":"git://github.com/techee/ctags.git","ssh_url":"git@github.com:techee/ctags.git","clone_url":"https://github.com/techee/ctags.git","svn_url":"https://github.com/techee/ctags","homepage":"","size":8076,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"universal-ctags:master","ref":"master","sha":"2ca6b9e5418f2359d809414d6546ddc4deddde81","user":{"login":"universal-ctags","id":9616766,"avatar_url":"https://avatars.githubusercontent.com/u/9616766?v=3","gravatar_id":"","url":"https://api.github.com/users/universal-ctags","html_url":"https://github.com/universal-ctags","followers_url":"https://api.github.com/users/universal-ctags/followers","following_url":"https://api.github.com/users/universal-ctags/following{/other_user}","gists_url":"https://api.github.com/users/universal-ctags/gists{/gist_id}","starred_url":"https://api.github.com/users/universal-ctags/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/universal-ctags/subscriptions","organizations_url":"https://api.github.com/users/universal-ctags/orgs","repos_url":"https://api.github.com/users/universal-ctags/repos","events_url":"https://api.github.com/users/universal-ctags/events{/privacy}","received_events_url":"https://api.github.com/users/universal-ctags/received_events","type":"Organization","site_admin":false},"repo":{"id":578839,"name":"ctags","full_name":"universal-ctags/ctags","owner":{"login":"universal-ctags","id":9616766,"avatar_url":"https://avatars.githubusercontent.com/u/9616766?v=3","gravatar_id":"","url":"https://api.github.com/users/universal-ctags","html_url":"https://github.com/universal-ctags","followers_url":"https://api.github.com/users/universal-ctags/followers","following_url":"https://api.github.com/users/universal-ctags/following{/other_user}","gists_url":"https://api.github.com/users/universal-ctags/gists{/gist_id}","starred_url":"https://api.github.com/users/universal-ctags/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/universal-ctags/subscriptions","organizations_url":"https://api.github.com/users/universal-ctags/orgs","repos_url":"https://api.github.com/users/universal-ctags/repos","events_url":"https://api.github.com/users/universal-ctags/events{/privacy}","received_events_url":"https://api.github.com/users/universal-ctags/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/universal-ctags/ctags","description":"A maintained ctags implementation","fork":false,"url":"https://api.github.com/repos/universal-ctags/ctags","forks_url":"https://api.github.com/repos/universal-ctags/ctags/forks","keys_url":"https://api.github.com/repos/universal-ctags/ctags/keys{/key_id}","collaborators_url":"https://api.github.com/repos/universal-ctags/ctags/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/universal-ctags/ctags/teams","hooks_url":"https://api.github.com/repos/universal-ctags/ctags/hooks","issue_events_url":"https://api.github.com/repos/universal-ctags/ctags/issues/events{/number}","events_url":"https://api.github.com/repos/universal-ctags/ctags/events","assignees_url":"https://api.github.com/repos/universal-ctags/ctags/assignees{/user}","branches_url":"https://api.github.com/repos/universal-ctags/ctags/branches{/branch}","tags_url":"https://api.github.com/repos/universal-ctags/ctags/tags","blobs_url":"https://api.github.com/repos/universal-ctags/ctags/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/universal-ctags/ctags/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/universal-ctags/ctags/git/refs{/sha}","trees_url":"https://api.github.com/repos/universal-ctags/ctags/git/trees{/sha}","statuses_url":"https://api.github.com/repos/universal-ctags/ctags/statuses/{sha}","languages_url":"https://api.github.com/repos/universal-ctags/ctags/languages","stargazers_url":"https://api.github.com/repos/universal-ctags/ctags/stargazers","contributors_url":"https://api.github.com/repos/universal-ctags/ctags/contributors","subscribers_url":"https://api.github.com/repos/universal-ctags/ctags/subscribers","subscription_url":"https://api.github.com/repos/universal-ctags/ctags/subscription","commits_url":"https://api.github.com/repos/universal-ctags/ctags/commits{/sha}","git_commits_url":"https://api.github.com/repos/universal-ctags/ctags/git/commits{/sha}","comments_url":"https://api.github.com/repos/universal-ctags/ctags/comments{/number}","issue_comment_url":"https://api.github.com/repos/universal-ctags/ctags/issues/comments{/number}","contents_url":"https://api.github.com/repos/universal-ctags/ctags/contents/{+path}","compare_url":"https://api.github.com/repos/universal-ctags/ctags/compare/{base}...{head}","merges_url":"https://api.github.com/repos/universal-ctags/ctags/merges","archive_url":"https://api.github.com/repos/universal-ctags/ctags/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/universal-ctags/ctags/downloads","issues_url":"https://api.github.com/repos/universal-ctags/ctags/issues{/number}","pulls_url":"https://api.github.com/repos/universal-ctags/ctags/pulls{/number}","milestones_url":"https://api.github.com/repos/universal-ctags/ctags/milestones{/number}","notifications_url":"https://api.github.com/repos/universal-ctags/ctags/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/universal-ctags/ctags/labels{/name}","releases_url":"https://api.github.com/repos/universal-ctags/ctags/releases{/id}","deployments_url":"https://api.github.com/repos/universal-ctags/ctags/deployments","created_at":"2010-03-25T10:43:13Z","updated_at":"2016-08-19T21:17:53Z","pushed_at":"2016-08-20T21:25:39Z","git_url":"git://github.com/universal-ctags/ctags.git","ssh_url":"git@github.com:universal-ctags/ctags.git","clone_url":"https://github.com/universal-ctags/ctags.git","svn_url":"https://github.com/universal-ctags/ctags","homepage":"https://ctags.io","size":10546,"stargazers_count":807,"watchers_count":807,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":153,"mirror_url":null,"open_issues_count":109,"forks":153,"open_issues":109,"watchers":807,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/universal-ctags/ctags/pulls/1079"},"html":{"href":"https://github.com/universal-ctags/ctags/pull/1079"},"issue":{"href":"https://api.github.com/repos/universal-ctags/ctags/issues/1079"},"comments":{"href":"https://api.github.com/repos/universal-ctags/ctags/issues/1079/comments"},"review_comments":{"href":"https://api.github.com/repos/universal-ctags/ctags/pulls/1079/comments"},"review_comment":{"href":"https://api.github.com/repos/universal-ctags/ctags/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/universal-ctags/ctags/pulls/1079/commits"},"statuses":{"href":"https://api.github.com/repos/universal-ctags/ctags/statuses/5f9b8780d800390fb240ba147d466ce5a01a109c"}}}}
{"actor":{"display_login":"b4n"}}