{"push_id":1096652850,"size":1,"distinct_size":1,"ref":"refs/heads/master","head":"0968d59602ce3ef0f511b5344be19c58f96154c0","before":"3d37ac8ed55a91f8a0b647b553cb926c9be4915c","commits":[{"sha":"0968d59602ce3ef0f511b5344be19c58f96154c0","author":{"email":"51e95e227ef3ba952acba345ca25f95087ddc46f@ccs.neu.edu","name":"Rohan Garg"},"message":"fileconnection: Fix checkpointing of unlinked files opened with O_WRONLY\n\nThis patch fixes an issue where DMTCP would incorrectly restore\nfiles that were unlinked after opening with O_WRONLY.\n\nThe policy for checkpoint-restore of such files was first defined\nin the commit 5c3dd0a as follows:\n\n a) DMTCP should not checkpoint such files, regardless of the\n    --checkpoint-open-files flags; and\n b) On restart, DMTCP should open such files with (O_WRONLY|O_CREAT)\n    and unlink them.\n\nHowever, the implementaiton never achieved these goals. We did end up\ndoing the first part correctly, but never really got the second path right.\n\nWith the above commit, files would be opened with (O_WRONLY|O_CREAT)\non restart but were never unlinked because the commit overlooked an\nif-clause in the `FileConnection::resume()` method. The if-clause would\ncall unlink() only if a file had the `_ckpted_file` flag set to true.\n\nLater, the commit: 8514737 worsened the situation. It introduced a bug\nin the `FileConnection::refill()` method that would prevent us from even\nopening write-only, unlinked files on restart.","distinct":true,"url":"https://api.github.com/repos/dmtcp/dmtcp/commits/0968d59602ce3ef0f511b5344be19c58f96154c0"}]}