{"action":"created","issue":{"url":"https://api.github.com/repos/saltstack/salt/issues/36555","repository_url":"https://api.github.com/repos/saltstack/salt","labels_url":"https://api.github.com/repos/saltstack/salt/issues/36555/labels{/name}","comments_url":"https://api.github.com/repos/saltstack/salt/issues/36555/comments","events_url":"https://api.github.com/repos/saltstack/salt/issues/36555/events","html_url":"https://github.com/saltstack/salt/pull/36555","id":179032551,"number":36555,"title":"Bugs/35480 master shutdown","user":{"login":"DmitryKuzmenko","id":4807387,"avatar_url":"https://avatars.githubusercontent.com/u/4807387?v=3","gravatar_id":"","url":"https://api.github.com/users/DmitryKuzmenko","html_url":"https://github.com/DmitryKuzmenko","followers_url":"https://api.github.com/users/DmitryKuzmenko/followers","following_url":"https://api.github.com/users/DmitryKuzmenko/following{/other_user}","gists_url":"https://api.github.com/users/DmitryKuzmenko/gists{/gist_id}","starred_url":"https://api.github.com/users/DmitryKuzmenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DmitryKuzmenko/subscriptions","organizations_url":"https://api.github.com/users/DmitryKuzmenko/orgs","repos_url":"https://api.github.com/users/DmitryKuzmenko/repos","events_url":"https://api.github.com/users/DmitryKuzmenko/events{/privacy}","received_events_url":"https://api.github.com/users/DmitryKuzmenko/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-09-24T14:23:52Z","updated_at":"2016-10-25T21:58:41Z","closed_at":"2016-09-26T09:25:43Z","pull_request":{"url":"https://api.github.com/repos/saltstack/salt/pulls/36555","html_url":"https://github.com/saltstack/salt/pull/36555","diff_url":"https://github.com/saltstack/salt/pull/36555.diff","patch_url":"https://github.com/saltstack/salt/pull/36555.patch"},"body":"### What does this PR do?\r\nThe second couple of fixes for master shutdown:\r\n1) Don't run Logging Queue with the daemon flag, because it's shutdown is already under the control of the ProcessManager and it shuts the Logging Queue faster than Python internals, so there is an error occurs in the python code.\r\n```\r\nError in atexit._run_exitfuncs:\r\nTraceback (most recent call last):\r\n  File \"/usr/lib/python2.7/atexit.py\", line 24, in _run_exitfuncs\r\n    func(*targs, **kargs)\r\n  File \"/usr/lib/python2.7/multiprocessing/util.py\", line 322, in _exit_function\r\n    p._popen.terminate()\r\n  File \"/usr/lib/python2.7/multiprocessing/forking.py\", line 172, in terminate\r\n    os.kill(self.pid, signal.SIGTERM)\r\nOSError: [Errno 3] No such process\r\n```\r\n2) Give the main `ProcessManager` more time to wait before kill because there is a child running a `ProcessManager` too (`ReqServer_ProcessManager`) so it needs more time to kill all subprocesses.\r\n\r\n### What issues does this PR fix or reference?\r\n#35480\r\n\r\n### Tests written?\r\nNo"},"comment":{"url":"https://api.github.com/repos/saltstack/salt/issues/comments/256189308","html_url":"https://github.com/saltstack/salt/pull/36555#issuecomment-256189308","issue_url":"https://api.github.com/repos/saltstack/salt/issues/36555","id":256189308,"user":{"login":"twangboy","id":9383935,"avatar_url":"https://avatars.githubusercontent.com/u/9383935?v=3","gravatar_id":"","url":"https://api.github.com/users/twangboy","html_url":"https://github.com/twangboy","followers_url":"https://api.github.com/users/twangboy/followers","following_url":"https://api.github.com/users/twangboy/following{/other_user}","gists_url":"https://api.github.com/users/twangboy/gists{/gist_id}","starred_url":"https://api.github.com/users/twangboy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twangboy/subscriptions","organizations_url":"https://api.github.com/users/twangboy/orgs","repos_url":"https://api.github.com/users/twangboy/repos","events_url":"https://api.github.com/users/twangboy/events{/privacy}","received_events_url":"https://api.github.com/users/twangboy/received_events","type":"User","site_admin":false},"created_at":"2016-10-25T21:58:41Z","updated_at":"2016-10-25T21:58:41Z","body":"The same error occurs from a cmd prompt as well."}}
{"actor":{"display_login":"twangboy"}}