{"action":"created","comment":{"url":"https://api.github.com/repos/telefonicaid/fiware-orion/pulls/comments/57554715","id":57554715,"diff_hunk":"@@ -211,7 +210,28 @@ ConnectionInfo::~ConnectionInfo()\n   servicePathV.clear();\n }\n \n-void ConnectionInfo::modify(const std::string &_url, const std::string &_verb, const std::string &_payload, const HttpHeaders &head)\n+void ConnectionInfo::reset()","path":"src/lib/rest/ConnectionInfo.cpp","position":13,"original_position":13,"commit_id":"def7d282f1bc46b66b823021767c2a3e9ae68f3d","original_commit_id":"def7d282f1bc46b66b823021767c2a3e9ae68f3d","user":{"login":"fgalan","id":1534240,"avatar_url":"https://avatars.githubusercontent.com/u/1534240?v=3","gravatar_id":"","url":"https://api.github.com/users/fgalan","html_url":"https://github.com/fgalan","followers_url":"https://api.github.com/users/fgalan/followers","following_url":"https://api.github.com/users/fgalan/following{/other_user}","gists_url":"https://api.github.com/users/fgalan/gists{/gist_id}","starred_url":"https://api.github.com/users/fgalan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fgalan/subscriptions","organizations_url":"https://api.github.com/users/fgalan/orgs","repos_url":"https://api.github.com/users/fgalan/repos","events_url":"https://api.github.com/users/fgalan/events{/privacy}","received_events_url":"https://api.github.com/users/fgalan/received_events","type":"User","site_admin":false},"body":"I understand that both modify() and reset() methods has been included in the ConnectionInfo for the feature/1181_websockets and are used from the ws library. It would be great if you could provide a function preamble for each of them, in order to provide some documentation about the purpose of the method, how it is used, etc. I doesn't need to be too much detailed, but explain at least a little about the method.\r\n\r\nE.g (in this same file):\r\n\r\n```\r\n`/* ****************************************************************************\r\n*\r\n* uriParamTypesParse - parse the URI param 'type' into uriParamTypes vector\r\n*/\r\n```","created_at":"2016-03-28T08:37:20Z","updated_at":"2016-03-28T08:37:20Z","html_url":"https://github.com/telefonicaid/fiware-orion/pull/1951#discussion_r57554715","pull_request_url":"https://api.github.com/repos/telefonicaid/fiware-orion/pulls/1951","_links":{"self":{"href":"https://api.github.com/repos/telefonicaid/fiware-orion/pulls/comments/57554715"},"html":{"href":"https://github.com/telefonicaid/fiware-orion/pull/1951#discussion_r57554715"},"pull_request":{"href":"https://api.github.com/repos/telefonicaid/fiware-orion/pulls/1951"}}},"pull_request":{"url":"https://api.github.com/repos/telefonicaid/fiware-orion/pulls/1951","id":64043686,"html_url":"https://github.com/telefonicaid/fiware-orion/pull/1951","diff_url":"https://github.com/telefonicaid/fiware-orion/pull/1951.diff","patch_url":"https://github.com/telefonicaid/fiware-orion/pull/1951.patch","issue_url":"https://api.github.com/repos/telefonicaid/fiware-orion/issues/1951","number":1951,"state":"open","locked":false,"title":"Fix problems after update branch","user":{"login":"fortizc","id":4274353,"avatar_url":"https://avatars.githubusercontent.com/u/4274353?v=3","gravatar_id":"","url":"https://api.github.com/users/fortizc","html_url":"https://github.com/fortizc","followers_url":"https://api.github.com/users/fortizc/followers","following_url":"https://api.github.com/users/fortizc/following{/other_user}","gists_url":"https://api.github.com/users/fortizc/gists{/gist_id}","starred_url":"https://api.github.com/users/fortizc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fortizc/subscriptions","organizations_url":"https://api.github.com/users/fortizc/orgs","repos_url":"https://api.github.com/users/fortizc/repos","events_url":"https://api.github.com/users/fortizc/events{/privacy}","received_events_url":"https://api.github.com/users/fortizc/received_events","type":"User","site_admin":false},"body":"Fix some problems found after update  feature/1181_websockets from develop","created_at":"2016-03-24T14:44:17Z","updated_at":"2016-03-28T08:37:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"77cdee49d5af897c82473fd1f97ecb7cda1a24f5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/telefonicaid/fiware-orion/pulls/1951/commits","review_comments_url":"https://api.github.com/repos/telefonicaid/fiware-orion/pulls/1951/comments","review_comment_url":"https://api.github.com/repos/telefonicaid/fiware-orion/pulls/comments{/number}","comments_url":"https://api.github.com/repos/telefonicaid/fiware-orion/issues/1951/comments","statuses_url":"https://api.github.com/repos/telefonicaid/fiware-orion/statuses/def7d282f1bc46b66b823021767c2a3e9ae68f3d","head":{"label":"fortizc:ws","ref":"ws","sha":"def7d282f1bc46b66b823021767c2a3e9ae68f3d","user":{"login":"fortizc","id":4274353,"avatar_url":"https://avatars.githubusercontent.com/u/4274353?v=3","gravatar_id":"","url":"https://api.github.com/users/fortizc","html_url":"https://github.com/fortizc","followers_url":"https://api.github.com/users/fortizc/followers","following_url":"https://api.github.com/users/fortizc/following{/other_user}","gists_url":"https://api.github.com/users/fortizc/gists{/gist_id}","starred_url":"https://api.github.com/users/fortizc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fortizc/subscriptions","organizations_url":"https://api.github.com/users/fortizc/orgs","repos_url":"https://api.github.com/users/fortizc/repos","events_url":"https://api.github.com/users/fortizc/events{/privacy}","received_events_url":"https://api.github.com/users/fortizc/received_events","type":"User","site_admin":false},"repo":{"id":41307203,"name":"fiware-orion","full_name":"fortizc/fiware-orion","owner":{"login":"fortizc","id":4274353,"avatar_url":"https://avatars.githubusercontent.com/u/4274353?v=3","gravatar_id":"","url":"https://api.github.com/users/fortizc","html_url":"https://github.com/fortizc","followers_url":"https://api.github.com/users/fortizc/followers","following_url":"https://api.github.com/users/fortizc/following{/other_user}","gists_url":"https://api.github.com/users/fortizc/gists{/gist_id}","starred_url":"https://api.github.com/users/fortizc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fortizc/subscriptions","organizations_url":"https://api.github.com/users/fortizc/orgs","repos_url":"https://api.github.com/users/fortizc/repos","events_url":"https://api.github.com/users/fortizc/events{/privacy}","received_events_url":"https://api.github.com/users/fortizc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fortizc/fiware-orion","description":"FIWARE Orion Context Broker","fork":true,"url":"https://api.github.com/repos/fortizc/fiware-orion","forks_url":"https://api.github.com/repos/fortizc/fiware-orion/forks","keys_url":"https://api.github.com/repos/fortizc/fiware-orion/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fortizc/fiware-orion/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fortizc/fiware-orion/teams","hooks_url":"https://api.github.com/repos/fortizc/fiware-orion/hooks","issue_events_url":"https://api.github.com/repos/fortizc/fiware-orion/issues/events{/number}","events_url":"https://api.github.com/repos/fortizc/fiware-orion/events","assignees_url":"https://api.github.com/repos/fortizc/fiware-orion/assignees{/user}","branches_url":"https://api.github.com/repos/fortizc/fiware-orion/branches{/branch}","tags_url":"https://api.github.com/repos/fortizc/fiware-orion/tags","blobs_url":"https://api.github.com/repos/fortizc/fiware-orion/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fortizc/fiware-orion/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fortizc/fiware-orion/git/refs{/sha}","trees_url":"https://api.github.com/repos/fortizc/fiware-orion/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fortizc/fiware-orion/statuses/{sha}","languages_url":"https://api.github.com/repos/fortizc/fiware-orion/languages","stargazers_url":"https://api.github.com/repos/fortizc/fiware-orion/stargazers","contributors_url":"https://api.github.com/repos/fortizc/fiware-orion/contributors","subscribers_url":"https://api.github.com/repos/fortizc/fiware-orion/subscribers","subscription_url":"https://api.github.com/repos/fortizc/fiware-orion/subscription","commits_url":"https://api.github.com/repos/fortizc/fiware-orion/commits{/sha}","git_commits_url":"https://api.github.com/repos/fortizc/fiware-orion/git/commits{/sha}","comments_url":"https://api.github.com/repos/fortizc/fiware-orion/comments{/number}","issue_comment_url":"https://api.github.com/repos/fortizc/fiware-orion/issues/comments{/number}","contents_url":"https://api.github.com/repos/fortizc/fiware-orion/contents/{+path}","compare_url":"https://api.github.com/repos/fortizc/fiware-orion/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fortizc/fiware-orion/merges","archive_url":"https://api.github.com/repos/fortizc/fiware-orion/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fortizc/fiware-orion/downloads","issues_url":"https://api.github.com/repos/fortizc/fiware-orion/issues{/number}","pulls_url":"https://api.github.com/repos/fortizc/fiware-orion/pulls{/number}","milestones_url":"https://api.github.com/repos/fortizc/fiware-orion/milestones{/number}","notifications_url":"https://api.github.com/repos/fortizc/fiware-orion/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fortizc/fiware-orion/labels{/name}","releases_url":"https://api.github.com/repos/fortizc/fiware-orion/releases{/id}","deployments_url":"https://api.github.com/repos/fortizc/fiware-orion/deployments","created_at":"2015-08-24T14:17:39Z","updated_at":"2015-08-24T14:17:47Z","pushed_at":"2016-03-26T05:41:10Z","git_url":"git://github.com/fortizc/fiware-orion.git","ssh_url":"git@github.com:fortizc/fiware-orion.git","clone_url":"https://github.com/fortizc/fiware-orion.git","svn_url":"https://github.com/fortizc/fiware-orion","homepage":"http://catalogue.fiware.org/enablers/publishsubscribe-context-broker-orion-context-broker","size":20480,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"telefonicaid:feature/1181_websockets","ref":"feature/1181_websockets","sha":"7e463130bc3526ec13a2a5550d95b36730d67369","user":{"login":"telefonicaid","id":968363,"avatar_url":"https://avatars.githubusercontent.com/u/968363?v=3","gravatar_id":"","url":"https://api.github.com/users/telefonicaid","html_url":"https://github.com/telefonicaid","followers_url":"https://api.github.com/users/telefonicaid/followers","following_url":"https://api.github.com/users/telefonicaid/following{/other_user}","gists_url":"https://api.github.com/users/telefonicaid/gists{/gist_id}","starred_url":"https://api.github.com/users/telefonicaid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/telefonicaid/subscriptions","organizations_url":"https://api.github.com/users/telefonicaid/orgs","repos_url":"https://api.github.com/users/telefonicaid/repos","events_url":"https://api.github.com/users/telefonicaid/events{/privacy}","received_events_url":"https://api.github.com/users/telefonicaid/received_events","type":"Organization","site_admin":false},"repo":{"id":12808420,"name":"fiware-orion","full_name":"telefonicaid/fiware-orion","owner":{"login":"telefonicaid","id":968363,"avatar_url":"https://avatars.githubusercontent.com/u/968363?v=3","gravatar_id":"","url":"https://api.github.com/users/telefonicaid","html_url":"https://github.com/telefonicaid","followers_url":"https://api.github.com/users/telefonicaid/followers","following_url":"https://api.github.com/users/telefonicaid/following{/other_user}","gists_url":"https://api.github.com/users/telefonicaid/gists{/gist_id}","starred_url":"https://api.github.com/users/telefonicaid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/telefonicaid/subscriptions","organizations_url":"https://api.github.com/users/telefonicaid/orgs","repos_url":"https://api.github.com/users/telefonicaid/repos","events_url":"https://api.github.com/users/telefonicaid/events{/privacy}","received_events_url":"https://api.github.com/users/telefonicaid/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/telefonicaid/fiware-orion","description":"FIWARE Orion Context Broker","fork":false,"url":"https://api.github.com/repos/telefonicaid/fiware-orion","forks_url":"https://api.github.com/repos/telefonicaid/fiware-orion/forks","keys_url":"https://api.github.com/repos/telefonicaid/fiware-orion/keys{/key_id}","collaborators_url":"https://api.github.com/repos/telefonicaid/fiware-orion/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/telefonicaid/fiware-orion/teams","hooks_url":"https://api.github.com/repos/telefonicaid/fiware-orion/hooks","issue_events_url":"https://api.github.com/repos/telefonicaid/fiware-orion/issues/events{/number}","events_url":"https://api.github.com/repos/telefonicaid/fiware-orion/events","assignees_url":"https://api.github.com/repos/telefonicaid/fiware-orion/assignees{/user}","branches_url":"https://api.github.com/repos/telefonicaid/fiware-orion/branches{/branch}","tags_url":"https://api.github.com/repos/telefonicaid/fiware-orion/tags","blobs_url":"https://api.github.com/repos/telefonicaid/fiware-orion/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/telefonicaid/fiware-orion/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/telefonicaid/fiware-orion/git/refs{/sha}","trees_url":"https://api.github.com/repos/telefonicaid/fiware-orion/git/trees{/sha}","statuses_url":"https://api.github.com/repos/telefonicaid/fiware-orion/statuses/{sha}","languages_url":"https://api.github.com/repos/telefonicaid/fiware-orion/languages","stargazers_url":"https://api.github.com/repos/telefonicaid/fiware-orion/stargazers","contributors_url":"https://api.github.com/repos/telefonicaid/fiware-orion/contributors","subscribers_url":"https://api.github.com/repos/telefonicaid/fiware-orion/subscribers","subscription_url":"https://api.github.com/repos/telefonicaid/fiware-orion/subscription","commits_url":"https://api.github.com/repos/telefonicaid/fiware-orion/commits{/sha}","git_commits_url":"https://api.github.com/repos/telefonicaid/fiware-orion/git/commits{/sha}","comments_url":"https://api.github.com/repos/telefonicaid/fiware-orion/comments{/number}","issue_comment_url":"https://api.github.com/repos/telefonicaid/fiware-orion/issues/comments{/number}","contents_url":"https://api.github.com/repos/telefonicaid/fiware-orion/contents/{+path}","compare_url":"https://api.github.com/repos/telefonicaid/fiware-orion/compare/{base}...{head}","merges_url":"https://api.github.com/repos/telefonicaid/fiware-orion/merges","archive_url":"https://api.github.com/repos/telefonicaid/fiware-orion/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/telefonicaid/fiware-orion/downloads","issues_url":"https://api.github.com/repos/telefonicaid/fiware-orion/issues{/number}","pulls_url":"https://api.github.com/repos/telefonicaid/fiware-orion/pulls{/number}","milestones_url":"https://api.github.com/repos/telefonicaid/fiware-orion/milestones{/number}","notifications_url":"https://api.github.com/repos/telefonicaid/fiware-orion/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/telefonicaid/fiware-orion/labels{/name}","releases_url":"https://api.github.com/repos/telefonicaid/fiware-orion/releases{/id}","deployments_url":"https://api.github.com/repos/telefonicaid/fiware-orion/deployments","created_at":"2013-09-13T11:55:25Z","updated_at":"2016-03-18T13:36:08Z","pushed_at":"2016-03-28T07:56:16Z","git_url":"git://github.com/telefonicaid/fiware-orion.git","ssh_url":"git@github.com:telefonicaid/fiware-orion.git","clone_url":"https://github.com/telefonicaid/fiware-orion.git","svn_url":"https://github.com/telefonicaid/fiware-orion","homepage":"http://catalogue.fiware.org/enablers/publishsubscribe-context-broker-orion-context-broker","size":22688,"stargazers_count":38,"watchers_count":38,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":59,"mirror_url":null,"open_issues_count":292,"forks":59,"open_issues":292,"watchers":38,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/telefonicaid/fiware-orion/pulls/1951"},"html":{"href":"https://github.com/telefonicaid/fiware-orion/pull/1951"},"issue":{"href":"https://api.github.com/repos/telefonicaid/fiware-orion/issues/1951"},"comments":{"href":"https://api.github.com/repos/telefonicaid/fiware-orion/issues/1951/comments"},"review_comments":{"href":"https://api.github.com/repos/telefonicaid/fiware-orion/pulls/1951/comments"},"review_comment":{"href":"https://api.github.com/repos/telefonicaid/fiware-orion/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/telefonicaid/fiware-orion/pulls/1951/commits"},"statuses":{"href":"https://api.github.com/repos/telefonicaid/fiware-orion/statuses/def7d282f1bc46b66b823021767c2a3e9ae68f3d"}}}}