{"action":"created","comment":{"url":"https://api.github.com/repos/annulen/webkit/pulls/comments/53383140","id":53383140,"diff_hunk":"@@ -136,7 +136,7 @@ JS_EXPORT void JSGarbageCollect(JSContextRef ctx);\n \n /* Enable the Objective-C API for platforms with a modern runtime. */\n #if !defined(JSC_OBJC_API_ENABLED)\n-#define JSC_OBJC_API_ENABLED (defined(__clang__) && defined(__APPLE__) && !defined(BUILDING_GTK__) && ((defined(__MAC_OS_X_VERSION_MIN_REQUIRED) && !defined(__i386__)) || (defined(TARGET_OS_IPHONE) && TARGET_OS_IPHONE)))\n+#define JSC_OBJC_API_ENABLED (defined(__clang__) && defined(__APPLE__) && !defined(BUILDING_GTK__) && !defined(BUILDING_QT__) && ((defined(__MAC_OS_X_VERSION_MIN_REQUIRED) && !defined(__i386__)) || (defined(TARGET_OS_IPHONE) && TARGET_OS_IPHONE)))","path":"Source/JavaScriptCore/API/JSBase.h","position":5,"original_position":5,"commit_id":"51b8c3f8b6e6be0a054e231cb82232a41e8650fb","original_commit_id":"51b8c3f8b6e6be0a054e231cb82232a41e8650fb","user":{"login":"annulen","id":102544,"avatar_url":"https://avatars.githubusercontent.com/u/102544?v=3","gravatar_id":"","url":"https://api.github.com/users/annulen","html_url":"https://github.com/annulen","followers_url":"https://api.github.com/users/annulen/followers","following_url":"https://api.github.com/users/annulen/following{/other_user}","gists_url":"https://api.github.com/users/annulen/gists{/gist_id}","starred_url":"https://api.github.com/users/annulen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/annulen/subscriptions","organizations_url":"https://api.github.com/users/annulen/orgs","repos_url":"https://api.github.com/users/annulen/repos","events_url":"https://api.github.com/users/annulen/events{/privacy}","received_events_url":"https://api.github.com/users/annulen/received_events","type":"User","site_admin":false},"body":"Couldn't we get away just defining JSC_OBJC_API_ENABLED=0, e.g. in JavaScriptCore/PlatfromQt.cmake?","created_at":"2016-02-18T21:12:59Z","updated_at":"2016-02-18T21:12:59Z","html_url":"https://github.com/annulen/webkit/pull/23#discussion_r53383140","pull_request_url":"https://api.github.com/repos/annulen/webkit/pulls/23","_links":{"self":{"href":"https://api.github.com/repos/annulen/webkit/pulls/comments/53383140"},"html":{"href":"https://github.com/annulen/webkit/pull/23#discussion_r53383140"},"pull_request":{"href":"https://api.github.com/repos/annulen/webkit/pulls/23"}}},"pull_request":{"url":"https://api.github.com/repos/annulen/webkit/pulls/23","id":59855211,"html_url":"https://github.com/annulen/webkit/pull/23","diff_url":"https://github.com/annulen/webkit/pull/23.diff","patch_url":"https://github.com/annulen/webkit/pull/23.patch","issue_url":"https://api.github.com/repos/annulen/webkit/issues/23","number":23,"state":"open","locked":false,"title":"Build QT version on OS X","user":{"login":"mepard","id":1104874,"avatar_url":"https://avatars.githubusercontent.com/u/1104874?v=3","gravatar_id":"","url":"https://api.github.com/users/mepard","html_url":"https://github.com/mepard","followers_url":"https://api.github.com/users/mepard/followers","following_url":"https://api.github.com/users/mepard/following{/other_user}","gists_url":"https://api.github.com/users/mepard/gists{/gist_id}","starred_url":"https://api.github.com/users/mepard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mepard/subscriptions","organizations_url":"https://api.github.com/users/mepard/orgs","repos_url":"https://api.github.com/users/mepard/repos","events_url":"https://api.github.com/users/mepard/events{/privacy}","received_events_url":"https://api.github.com/users/mepard/received_events","type":"User","site_admin":false},"body":"Changes to get WTF, WebCore, and JavaScriptCore to build for QT on OS\r\nX. WebKit is not yet building.","created_at":"2016-02-18T20:06:27Z","updated_at":"2016-02-18T21:12:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"612d3cd214dd2b6b4316d88ce9c558c301148d86","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/annulen/webkit/pulls/23/commits","review_comments_url":"https://api.github.com/repos/annulen/webkit/pulls/23/comments","review_comment_url":"https://api.github.com/repos/annulen/webkit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/annulen/webkit/issues/23/comments","statuses_url":"https://api.github.com/repos/annulen/webkit/statuses/51b8c3f8b6e6be0a054e231cb82232a41e8650fb","head":{"label":"mepard:qtwebkit-1-osx","ref":"qtwebkit-1-osx","sha":"51b8c3f8b6e6be0a054e231cb82232a41e8650fb","user":{"login":"mepard","id":1104874,"avatar_url":"https://avatars.githubusercontent.com/u/1104874?v=3","gravatar_id":"","url":"https://api.github.com/users/mepard","html_url":"https://github.com/mepard","followers_url":"https://api.github.com/users/mepard/followers","following_url":"https://api.github.com/users/mepard/following{/other_user}","gists_url":"https://api.github.com/users/mepard/gists{/gist_id}","starred_url":"https://api.github.com/users/mepard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mepard/subscriptions","organizations_url":"https://api.github.com/users/mepard/orgs","repos_url":"https://api.github.com/users/mepard/repos","events_url":"https://api.github.com/users/mepard/events{/privacy}","received_events_url":"https://api.github.com/users/mepard/received_events","type":"User","site_admin":false},"repo":{"id":52016753,"name":"webkit","full_name":"mepard/webkit","owner":{"login":"mepard","id":1104874,"avatar_url":"https://avatars.githubusercontent.com/u/1104874?v=3","gravatar_id":"","url":"https://api.github.com/users/mepard","html_url":"https://github.com/mepard","followers_url":"https://api.github.com/users/mepard/followers","following_url":"https://api.github.com/users/mepard/following{/other_user}","gists_url":"https://api.github.com/users/mepard/gists{/gist_id}","starred_url":"https://api.github.com/users/mepard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mepard/subscriptions","organizations_url":"https://api.github.com/users/mepard/orgs","repos_url":"https://api.github.com/users/mepard/repos","events_url":"https://api.github.com/users/mepard/events{/privacy}","received_events_url":"https://api.github.com/users/mepard/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mepard/webkit","description":"Unofficial mirror of the WebKit SVN repository","fork":true,"url":"https://api.github.com/repos/mepard/webkit","forks_url":"https://api.github.com/repos/mepard/webkit/forks","keys_url":"https://api.github.com/repos/mepard/webkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mepard/webkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mepard/webkit/teams","hooks_url":"https://api.github.com/repos/mepard/webkit/hooks","issue_events_url":"https://api.github.com/repos/mepard/webkit/issues/events{/number}","events_url":"https://api.github.com/repos/mepard/webkit/events","assignees_url":"https://api.github.com/repos/mepard/webkit/assignees{/user}","branches_url":"https://api.github.com/repos/mepard/webkit/branches{/branch}","tags_url":"https://api.github.com/repos/mepard/webkit/tags","blobs_url":"https://api.github.com/repos/mepard/webkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mepard/webkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mepard/webkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/mepard/webkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mepard/webkit/statuses/{sha}","languages_url":"https://api.github.com/repos/mepard/webkit/languages","stargazers_url":"https://api.github.com/repos/mepard/webkit/stargazers","contributors_url":"https://api.github.com/repos/mepard/webkit/contributors","subscribers_url":"https://api.github.com/repos/mepard/webkit/subscribers","subscription_url":"https://api.github.com/repos/mepard/webkit/subscription","commits_url":"https://api.github.com/repos/mepard/webkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/mepard/webkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/mepard/webkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/mepard/webkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/mepard/webkit/contents/{+path}","compare_url":"https://api.github.com/repos/mepard/webkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mepard/webkit/merges","archive_url":"https://api.github.com/repos/mepard/webkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mepard/webkit/downloads","issues_url":"https://api.github.com/repos/mepard/webkit/issues{/number}","pulls_url":"https://api.github.com/repos/mepard/webkit/pulls{/number}","milestones_url":"https://api.github.com/repos/mepard/webkit/milestones{/number}","notifications_url":"https://api.github.com/repos/mepard/webkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mepard/webkit/labels{/name}","releases_url":"https://api.github.com/repos/mepard/webkit/releases{/id}","deployments_url":"https://api.github.com/repos/mepard/webkit/deployments","created_at":"2016-02-18T15:22:43Z","updated_at":"2016-02-15T21:06:30Z","pushed_at":"2016-02-18T20:04:46Z","git_url":"git://github.com/mepard/webkit.git","ssh_url":"git@github.com:mepard/webkit.git","clone_url":"https://github.com/mepard/webkit.git","svn_url":"https://github.com/mepard/webkit","homepage":"http://www.webkit.org/","size":7136799,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"annulen:qtwebkit-1","ref":"qtwebkit-1","sha":"18476b02639596b65c421a2cf383b385ef7fb877","user":{"login":"annulen","id":102544,"avatar_url":"https://avatars.githubusercontent.com/u/102544?v=3","gravatar_id":"","url":"https://api.github.com/users/annulen","html_url":"https://github.com/annulen","followers_url":"https://api.github.com/users/annulen/followers","following_url":"https://api.github.com/users/annulen/following{/other_user}","gists_url":"https://api.github.com/users/annulen/gists{/gist_id}","starred_url":"https://api.github.com/users/annulen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/annulen/subscriptions","organizations_url":"https://api.github.com/users/annulen/orgs","repos_url":"https://api.github.com/users/annulen/repos","events_url":"https://api.github.com/users/annulen/events{/privacy}","received_events_url":"https://api.github.com/users/annulen/received_events","type":"User","site_admin":false},"repo":{"id":48857348,"name":"webkit","full_name":"annulen/webkit","owner":{"login":"annulen","id":102544,"avatar_url":"https://avatars.githubusercontent.com/u/102544?v=3","gravatar_id":"","url":"https://api.github.com/users/annulen","html_url":"https://github.com/annulen","followers_url":"https://api.github.com/users/annulen/followers","following_url":"https://api.github.com/users/annulen/following{/other_user}","gists_url":"https://api.github.com/users/annulen/gists{/gist_id}","starred_url":"https://api.github.com/users/annulen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/annulen/subscriptions","organizations_url":"https://api.github.com/users/annulen/orgs","repos_url":"https://api.github.com/users/annulen/repos","events_url":"https://api.github.com/users/annulen/events{/privacy}","received_events_url":"https://api.github.com/users/annulen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/annulen/webkit","description":"Unofficial mirror of the WebKit SVN repository","fork":true,"url":"https://api.github.com/repos/annulen/webkit","forks_url":"https://api.github.com/repos/annulen/webkit/forks","keys_url":"https://api.github.com/repos/annulen/webkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/annulen/webkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/annulen/webkit/teams","hooks_url":"https://api.github.com/repos/annulen/webkit/hooks","issue_events_url":"https://api.github.com/repos/annulen/webkit/issues/events{/number}","events_url":"https://api.github.com/repos/annulen/webkit/events","assignees_url":"https://api.github.com/repos/annulen/webkit/assignees{/user}","branches_url":"https://api.github.com/repos/annulen/webkit/branches{/branch}","tags_url":"https://api.github.com/repos/annulen/webkit/tags","blobs_url":"https://api.github.com/repos/annulen/webkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/annulen/webkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/annulen/webkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/annulen/webkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/annulen/webkit/statuses/{sha}","languages_url":"https://api.github.com/repos/annulen/webkit/languages","stargazers_url":"https://api.github.com/repos/annulen/webkit/stargazers","contributors_url":"https://api.github.com/repos/annulen/webkit/contributors","subscribers_url":"https://api.github.com/repos/annulen/webkit/subscribers","subscription_url":"https://api.github.com/repos/annulen/webkit/subscription","commits_url":"https://api.github.com/repos/annulen/webkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/annulen/webkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/annulen/webkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/annulen/webkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/annulen/webkit/contents/{+path}","compare_url":"https://api.github.com/repos/annulen/webkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/annulen/webkit/merges","archive_url":"https://api.github.com/repos/annulen/webkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/annulen/webkit/downloads","issues_url":"https://api.github.com/repos/annulen/webkit/issues{/number}","pulls_url":"https://api.github.com/repos/annulen/webkit/pulls{/number}","milestones_url":"https://api.github.com/repos/annulen/webkit/milestones{/number}","notifications_url":"https://api.github.com/repos/annulen/webkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/annulen/webkit/labels{/name}","releases_url":"https://api.github.com/repos/annulen/webkit/releases{/id}","deployments_url":"https://api.github.com/repos/annulen/webkit/deployments","created_at":"2015-12-31T17:38:35Z","updated_at":"2016-02-15T21:06:30Z","pushed_at":"2016-02-18T21:06:06Z","git_url":"git://github.com/annulen/webkit.git","ssh_url":"git@github.com:annulen/webkit.git","clone_url":"https://github.com/annulen/webkit.git","svn_url":"https://github.com/annulen/webkit","homepage":"http://www.webkit.org/","size":7143756,"stargazers_count":6,"watchers_count":6,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":17,"forks":2,"open_issues":17,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/annulen/webkit/pulls/23"},"html":{"href":"https://github.com/annulen/webkit/pull/23"},"issue":{"href":"https://api.github.com/repos/annulen/webkit/issues/23"},"comments":{"href":"https://api.github.com/repos/annulen/webkit/issues/23/comments"},"review_comments":{"href":"https://api.github.com/repos/annulen/webkit/pulls/23/comments"},"review_comment":{"href":"https://api.github.com/repos/annulen/webkit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/annulen/webkit/pulls/23/commits"},"statuses":{"href":"https://api.github.com/repos/annulen/webkit/statuses/51b8c3f8b6e6be0a054e231cb82232a41e8650fb"}}}}