{"action":"created","comment":{"url":"https://api.github.com/repos/acquaman/acquaman/pulls/comments/65727072","id":65727072,"diff_hunk":"@@ -58,6 +70,13 @@ class PGMAppController : public CLSAppController\n \tvirtual void createDetectorPanes();\n \t/// create pane for the scan configuration views\n \tvirtual void createScanConfigurationPanes();\n+\n+\t/// Returns true if the list of regions of interest contains the given ROI.\n+\tbool containsRegionOfInterest(QList<AMRegionOfInterest*> roiList, AMRegionOfInterest *regionOfInterest) const;","path":"source/application/PGM/PGMAppController.h","position":32,"original_position":32,"commit_id":"0ed9e26ecb2cd8704796ae14874899bc77fca53f","original_commit_id":"0ed9e26ecb2cd8704796ae14874899bc77fca53f","user":{"login":"XuetaoLiu-CLS","id":8292610,"avatar_url":"https://avatars.githubusercontent.com/u/8292610?v=3","gravatar_id":"","url":"https://api.github.com/users/XuetaoLiu-CLS","html_url":"https://github.com/XuetaoLiu-CLS","followers_url":"https://api.github.com/users/XuetaoLiu-CLS/followers","following_url":"https://api.github.com/users/XuetaoLiu-CLS/following{/other_user}","gists_url":"https://api.github.com/users/XuetaoLiu-CLS/gists{/gist_id}","starred_url":"https://api.github.com/users/XuetaoLiu-CLS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/XuetaoLiu-CLS/subscriptions","organizations_url":"https://api.github.com/users/XuetaoLiu-CLS/orgs","repos_url":"https://api.github.com/users/XuetaoLiu-CLS/repos","events_url":"https://api.github.com/users/XuetaoLiu-CLS/events{/privacy}","received_events_url":"https://api.github.com/users/XuetaoLiu-CLS/received_events","type":"User","site_admin":false},"body":"There are two usages for this function now (PGM and BioXAS). Then I think it would be nicer to move this function to both AMXRFDetector and AMUserConfiguration, and call this function in is  addRegion function, instead of here, with two reasons:\r\n- from OO design, it would be nicer that the classes can be encrypted well. The interfaces/functions provided will let callers DO the job without worrying about how. For this case, the caller will only care about addRegion() and don't need to worry about whether I should add it. It's up to the AMXRFDetector and the UserConfiguration to worry about it;\r\n- from the functionality view, if we add the check in AMXRFDetector and UserConfiguration, all the beamlines will benefit from this without code changes (this is also the intention of the OO design. As long as the interfaces are the same, the classes can change the implementation without affecting the callers)","created_at":"2016-06-03T15:31:28Z","updated_at":"2016-06-03T15:31:28Z","html_url":"https://github.com/acquaman/acquaman/pull/2369#discussion_r65727072","pull_request_url":"https://api.github.com/repos/acquaman/acquaman/pulls/2369","_links":{"self":{"href":"https://api.github.com/repos/acquaman/acquaman/pulls/comments/65727072"},"html":{"href":"https://github.com/acquaman/acquaman/pull/2369#discussion_r65727072"},"pull_request":{"href":"https://api.github.com/repos/acquaman/acquaman/pulls/2369"}}},"pull_request":{"url":"https://api.github.com/repos/acquaman/acquaman/pulls/2369","id":72422449,"html_url":"https://github.com/acquaman/acquaman/pull/2369","diff_url":"https://github.com/acquaman/acquaman/pull/2369.diff","patch_url":"https://github.com/acquaman/acquaman/pull/2369.patch","issue_url":"https://api.github.com/repos/acquaman/acquaman/issues/2369","number":2369,"state":"open","locked":false,"title":"Pull Request for Issue2178: Adding basic user configuration","user":{"login":"helfrij","id":5216607,"avatar_url":"https://avatars.githubusercontent.com/u/5216607?v=3","gravatar_id":"","url":"https://api.github.com/users/helfrij","html_url":"https://github.com/helfrij","followers_url":"https://api.github.com/users/helfrij/followers","following_url":"https://api.github.com/users/helfrij/following{/other_user}","gists_url":"https://api.github.com/users/helfrij/gists{/gist_id}","starred_url":"https://api.github.com/users/helfrij/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helfrij/subscriptions","organizations_url":"https://api.github.com/users/helfrij/orgs","repos_url":"https://api.github.com/users/helfrij/repos","events_url":"https://api.github.com/users/helfrij/events{/privacy}","received_events_url":"https://api.github.com/users/helfrij/received_events","type":"User","site_admin":false},"body":"- Created new class for the PGM user configuration.\r\n- Added instance to PGMAppController, with support methods.","created_at":"2016-06-02T21:42:21Z","updated_at":"2016-06-03T15:31:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c1ac9ff55adbef1d38498d21382110f238515b92","assignee":{"login":"XuetaoLiu-CLS","id":8292610,"avatar_url":"https://avatars.githubusercontent.com/u/8292610?v=3","gravatar_id":"","url":"https://api.github.com/users/XuetaoLiu-CLS","html_url":"https://github.com/XuetaoLiu-CLS","followers_url":"https://api.github.com/users/XuetaoLiu-CLS/followers","following_url":"https://api.github.com/users/XuetaoLiu-CLS/following{/other_user}","gists_url":"https://api.github.com/users/XuetaoLiu-CLS/gists{/gist_id}","starred_url":"https://api.github.com/users/XuetaoLiu-CLS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/XuetaoLiu-CLS/subscriptions","organizations_url":"https://api.github.com/users/XuetaoLiu-CLS/orgs","repos_url":"https://api.github.com/users/XuetaoLiu-CLS/repos","events_url":"https://api.github.com/users/XuetaoLiu-CLS/events{/privacy}","received_events_url":"https://api.github.com/users/XuetaoLiu-CLS/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/acquaman/acquaman/milestones/19","html_url":"https://github.com/acquaman/acquaman/milestones/PGM%20Implementation","labels_url":"https://api.github.com/repos/acquaman/acquaman/milestones/19/labels","id":1664382,"number":19,"title":"PGM Implementation","description":"This will hold all the PGM issues for the implementation to be done in the June shutdown.","creator":{"login":"dretrex","id":602741,"avatar_url":"https://avatars.githubusercontent.com/u/602741?v=3","gravatar_id":"","url":"https://api.github.com/users/dretrex","html_url":"https://github.com/dretrex","followers_url":"https://api.github.com/users/dretrex/followers","following_url":"https://api.github.com/users/dretrex/following{/other_user}","gists_url":"https://api.github.com/users/dretrex/gists{/gist_id}","starred_url":"https://api.github.com/users/dretrex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dretrex/subscriptions","organizations_url":"https://api.github.com/users/dretrex/orgs","repos_url":"https://api.github.com/users/dretrex/repos","events_url":"https://api.github.com/users/dretrex/events{/privacy}","received_events_url":"https://api.github.com/users/dretrex/received_events","type":"User","site_admin":false},"open_issues":10,"closed_issues":18,"state":"open","created_at":"2016-03-24T17:30:16Z","updated_at":"2016-06-03T15:14:12Z","due_on":"2016-06-08T05:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/acquaman/acquaman/pulls/2369/commits","review_comments_url":"https://api.github.com/repos/acquaman/acquaman/pulls/2369/comments","review_comment_url":"https://api.github.com/repos/acquaman/acquaman/pulls/comments{/number}","comments_url":"https://api.github.com/repos/acquaman/acquaman/issues/2369/comments","statuses_url":"https://api.github.com/repos/acquaman/acquaman/statuses/0ed9e26ecb2cd8704796ae14874899bc77fca53f","head":{"label":"acquaman:Issue2178","ref":"Issue2178","sha":"0ed9e26ecb2cd8704796ae14874899bc77fca53f","user":{"login":"acquaman","id":602716,"avatar_url":"https://avatars.githubusercontent.com/u/602716?v=3","gravatar_id":"","url":"https://api.github.com/users/acquaman","html_url":"https://github.com/acquaman","followers_url":"https://api.github.com/users/acquaman/followers","following_url":"https://api.github.com/users/acquaman/following{/other_user}","gists_url":"https://api.github.com/users/acquaman/gists{/gist_id}","starred_url":"https://api.github.com/users/acquaman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acquaman/subscriptions","organizations_url":"https://api.github.com/users/acquaman/orgs","repos_url":"https://api.github.com/users/acquaman/repos","events_url":"https://api.github.com/users/acquaman/events{/privacy}","received_events_url":"https://api.github.com/users/acquaman/received_events","type":"Organization","site_admin":false},"repo":{"id":1333343,"name":"acquaman","full_name":"acquaman/acquaman","owner":{"login":"acquaman","id":602716,"avatar_url":"https://avatars.githubusercontent.com/u/602716?v=3","gravatar_id":"","url":"https://api.github.com/users/acquaman","html_url":"https://github.com/acquaman","followers_url":"https://api.github.com/users/acquaman/followers","following_url":"https://api.github.com/users/acquaman/following{/other_user}","gists_url":"https://api.github.com/users/acquaman/gists{/gist_id}","starred_url":"https://api.github.com/users/acquaman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acquaman/subscriptions","organizations_url":"https://api.github.com/users/acquaman/orgs","repos_url":"https://api.github.com/users/acquaman/repos","events_url":"https://api.github.com/users/acquaman/events{/privacy}","received_events_url":"https://api.github.com/users/acquaman/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/acquaman/acquaman","description":"Acquisition and Data Management for Big Science","fork":false,"url":"https://api.github.com/repos/acquaman/acquaman","forks_url":"https://api.github.com/repos/acquaman/acquaman/forks","keys_url":"https://api.github.com/repos/acquaman/acquaman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/acquaman/acquaman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/acquaman/acquaman/teams","hooks_url":"https://api.github.com/repos/acquaman/acquaman/hooks","issue_events_url":"https://api.github.com/repos/acquaman/acquaman/issues/events{/number}","events_url":"https://api.github.com/repos/acquaman/acquaman/events","assignees_url":"https://api.github.com/repos/acquaman/acquaman/assignees{/user}","branches_url":"https://api.github.com/repos/acquaman/acquaman/branches{/branch}","tags_url":"https://api.github.com/repos/acquaman/acquaman/tags","blobs_url":"https://api.github.com/repos/acquaman/acquaman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/acquaman/acquaman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/acquaman/acquaman/git/refs{/sha}","trees_url":"https://api.github.com/repos/acquaman/acquaman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/acquaman/acquaman/statuses/{sha}","languages_url":"https://api.github.com/repos/acquaman/acquaman/languages","stargazers_url":"https://api.github.com/repos/acquaman/acquaman/stargazers","contributors_url":"https://api.github.com/repos/acquaman/acquaman/contributors","subscribers_url":"https://api.github.com/repos/acquaman/acquaman/subscribers","subscription_url":"https://api.github.com/repos/acquaman/acquaman/subscription","commits_url":"https://api.github.com/repos/acquaman/acquaman/commits{/sha}","git_commits_url":"https://api.github.com/repos/acquaman/acquaman/git/commits{/sha}","comments_url":"https://api.github.com/repos/acquaman/acquaman/comments{/number}","issue_comment_url":"https://api.github.com/repos/acquaman/acquaman/issues/comments{/number}","contents_url":"https://api.github.com/repos/acquaman/acquaman/contents/{+path}","compare_url":"https://api.github.com/repos/acquaman/acquaman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/acquaman/acquaman/merges","archive_url":"https://api.github.com/repos/acquaman/acquaman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/acquaman/acquaman/downloads","issues_url":"https://api.github.com/repos/acquaman/acquaman/issues{/number}","pulls_url":"https://api.github.com/repos/acquaman/acquaman/pulls{/number}","milestones_url":"https://api.github.com/repos/acquaman/acquaman/milestones{/number}","notifications_url":"https://api.github.com/repos/acquaman/acquaman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/acquaman/acquaman/labels{/name}","releases_url":"https://api.github.com/repos/acquaman/acquaman/releases{/id}","deployments_url":"https://api.github.com/repos/acquaman/acquaman/deployments","created_at":"2011-02-06T02:19:01Z","updated_at":"2016-05-02T21:52:12Z","pushed_at":"2016-06-03T15:05:26Z","git_url":"git://github.com/acquaman/acquaman.git","ssh_url":"git@github.com:acquaman/acquaman.git","clone_url":"https://github.com/acquaman/acquaman.git","svn_url":"https://github.com/acquaman/acquaman","homepage":"","size":144584,"stargazers_count":10,"watchers_count":10,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":207,"forks":2,"open_issues":207,"watchers":10,"default_branch":"master"}},"base":{"label":"acquaman:master","ref":"master","sha":"fc2ceb03ef3d9c56e2016929a5a7bde3759340ab","user":{"login":"acquaman","id":602716,"avatar_url":"https://avatars.githubusercontent.com/u/602716?v=3","gravatar_id":"","url":"https://api.github.com/users/acquaman","html_url":"https://github.com/acquaman","followers_url":"https://api.github.com/users/acquaman/followers","following_url":"https://api.github.com/users/acquaman/following{/other_user}","gists_url":"https://api.github.com/users/acquaman/gists{/gist_id}","starred_url":"https://api.github.com/users/acquaman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acquaman/subscriptions","organizations_url":"https://api.github.com/users/acquaman/orgs","repos_url":"https://api.github.com/users/acquaman/repos","events_url":"https://api.github.com/users/acquaman/events{/privacy}","received_events_url":"https://api.github.com/users/acquaman/received_events","type":"Organization","site_admin":false},"repo":{"id":1333343,"name":"acquaman","full_name":"acquaman/acquaman","owner":{"login":"acquaman","id":602716,"avatar_url":"https://avatars.githubusercontent.com/u/602716?v=3","gravatar_id":"","url":"https://api.github.com/users/acquaman","html_url":"https://github.com/acquaman","followers_url":"https://api.github.com/users/acquaman/followers","following_url":"https://api.github.com/users/acquaman/following{/other_user}","gists_url":"https://api.github.com/users/acquaman/gists{/gist_id}","starred_url":"https://api.github.com/users/acquaman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acquaman/subscriptions","organizations_url":"https://api.github.com/users/acquaman/orgs","repos_url":"https://api.github.com/users/acquaman/repos","events_url":"https://api.github.com/users/acquaman/events{/privacy}","received_events_url":"https://api.github.com/users/acquaman/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/acquaman/acquaman","description":"Acquisition and Data Management for Big Science","fork":false,"url":"https://api.github.com/repos/acquaman/acquaman","forks_url":"https://api.github.com/repos/acquaman/acquaman/forks","keys_url":"https://api.github.com/repos/acquaman/acquaman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/acquaman/acquaman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/acquaman/acquaman/teams","hooks_url":"https://api.github.com/repos/acquaman/acquaman/hooks","issue_events_url":"https://api.github.com/repos/acquaman/acquaman/issues/events{/number}","events_url":"https://api.github.com/repos/acquaman/acquaman/events","assignees_url":"https://api.github.com/repos/acquaman/acquaman/assignees{/user}","branches_url":"https://api.github.com/repos/acquaman/acquaman/branches{/branch}","tags_url":"https://api.github.com/repos/acquaman/acquaman/tags","blobs_url":"https://api.github.com/repos/acquaman/acquaman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/acquaman/acquaman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/acquaman/acquaman/git/refs{/sha}","trees_url":"https://api.github.com/repos/acquaman/acquaman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/acquaman/acquaman/statuses/{sha}","languages_url":"https://api.github.com/repos/acquaman/acquaman/languages","stargazers_url":"https://api.github.com/repos/acquaman/acquaman/stargazers","contributors_url":"https://api.github.com/repos/acquaman/acquaman/contributors","subscribers_url":"https://api.github.com/repos/acquaman/acquaman/subscribers","subscription_url":"https://api.github.com/repos/acquaman/acquaman/subscription","commits_url":"https://api.github.com/repos/acquaman/acquaman/commits{/sha}","git_commits_url":"https://api.github.com/repos/acquaman/acquaman/git/commits{/sha}","comments_url":"https://api.github.com/repos/acquaman/acquaman/comments{/number}","issue_comment_url":"https://api.github.com/repos/acquaman/acquaman/issues/comments{/number}","contents_url":"https://api.github.com/repos/acquaman/acquaman/contents/{+path}","compare_url":"https://api.github.com/repos/acquaman/acquaman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/acquaman/acquaman/merges","archive_url":"https://api.github.com/repos/acquaman/acquaman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/acquaman/acquaman/downloads","issues_url":"https://api.github.com/repos/acquaman/acquaman/issues{/number}","pulls_url":"https://api.github.com/repos/acquaman/acquaman/pulls{/number}","milestones_url":"https://api.github.com/repos/acquaman/acquaman/milestones{/number}","notifications_url":"https://api.github.com/repos/acquaman/acquaman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/acquaman/acquaman/labels{/name}","releases_url":"https://api.github.com/repos/acquaman/acquaman/releases{/id}","deployments_url":"https://api.github.com/repos/acquaman/acquaman/deployments","created_at":"2011-02-06T02:19:01Z","updated_at":"2016-05-02T21:52:12Z","pushed_at":"2016-06-03T15:05:26Z","git_url":"git://github.com/acquaman/acquaman.git","ssh_url":"git@github.com:acquaman/acquaman.git","clone_url":"https://github.com/acquaman/acquaman.git","svn_url":"https://github.com/acquaman/acquaman","homepage":"","size":144584,"stargazers_count":10,"watchers_count":10,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":207,"forks":2,"open_issues":207,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/acquaman/acquaman/pulls/2369"},"html":{"href":"https://github.com/acquaman/acquaman/pull/2369"},"issue":{"href":"https://api.github.com/repos/acquaman/acquaman/issues/2369"},"comments":{"href":"https://api.github.com/repos/acquaman/acquaman/issues/2369/comments"},"review_comments":{"href":"https://api.github.com/repos/acquaman/acquaman/pulls/2369/comments"},"review_comment":{"href":"https://api.github.com/repos/acquaman/acquaman/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/acquaman/acquaman/pulls/2369/commits"},"statuses":{"href":"https://api.github.com/repos/acquaman/acquaman/statuses/0ed9e26ecb2cd8704796ae14874899bc77fca53f"}}}}
{"actor":{"display_login":"XuetaoLiu-CLS"}}