{"action":"created","comment":{"url":"https://api.github.com/repos/almighty/almighty-core/pulls/comments/74234538","id":74234538,"diff_hunk":"@@ -53,7 +55,16 @@ func (field FieldDefinition) ConvertToModel(name string, value interface{}) (int\n \tif field.Required && value == nil {","path":"models/field_definition.go","position":10,"original_position":10,"commit_id":"e5f6de7ed6add35e229bcaebfea1af7b16b9e209","original_commit_id":"e5f6de7ed6add35e229bcaebfea1af7b16b9e209","user":{"login":"aslakknutsen","id":132158,"avatar_url":"https://avatars.githubusercontent.com/u/132158?v=3","gravatar_id":"","url":"https://api.github.com/users/aslakknutsen","html_url":"https://github.com/aslakknutsen","followers_url":"https://api.github.com/users/aslakknutsen/followers","following_url":"https://api.github.com/users/aslakknutsen/following{/other_user}","gists_url":"https://api.github.com/users/aslakknutsen/gists{/gist_id}","starred_url":"https://api.github.com/users/aslakknutsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aslakknutsen/subscriptions","organizations_url":"https://api.github.com/users/aslakknutsen/orgs","repos_url":"https://api.github.com/users/aslakknutsen/repos","events_url":"https://api.github.com/users/aslakknutsen/events{/privacy}","received_events_url":"https://api.github.com/users/aslakknutsen/received_events","type":"User","site_admin":false},"body":"Wouldn't Required be another Validation?","created_at":"2016-08-10T12:32:24Z","updated_at":"2016-08-10T12:32:24Z","html_url":"https://github.com/almighty/almighty-core/pull/106#discussion_r74234538","pull_request_url":"https://api.github.com/repos/almighty/almighty-core/pulls/106","_links":{"self":{"href":"https://api.github.com/repos/almighty/almighty-core/pulls/comments/74234538"},"html":{"href":"https://github.com/almighty/almighty-core/pull/106#discussion_r74234538"},"pull_request":{"href":"https://api.github.com/repos/almighty/almighty-core/pulls/106"}}},"pull_request":{"url":"https://api.github.com/repos/almighty/almighty-core/pulls/106","id":80784705,"html_url":"https://github.com/almighty/almighty-core/pull/106","diff_url":"https://github.com/almighty/almighty-core/pull/106.diff","patch_url":"https://github.com/almighty/almighty-core/pull/106.patch","issue_url":"https://api.github.com/repos/almighty/almighty-core/issues/106","number":106,"state":"open","locked":false,"title":"WIP Iss-77","user":{"login":"pranavgore09","id":2026565,"avatar_url":"https://avatars.githubusercontent.com/u/2026565?v=3","gravatar_id":"","url":"https://api.github.com/users/pranavgore09","html_url":"https://github.com/pranavgore09","followers_url":"https://api.github.com/users/pranavgore09/followers","following_url":"https://api.github.com/users/pranavgore09/following{/other_user}","gists_url":"https://api.github.com/users/pranavgore09/gists{/gist_id}","starred_url":"https://api.github.com/users/pranavgore09/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pranavgore09/subscriptions","organizations_url":"https://api.github.com/users/pranavgore09/orgs","repos_url":"https://api.github.com/users/pranavgore09/repos","events_url":"https://api.github.com/users/pranavgore09/events{/privacy}","received_events_url":"https://api.github.com/users/pranavgore09/received_events","type":"User","site_admin":false},"body":"As of now validated only URL field.\r\n`Validate` method is added to the interface and hence will be implemented by SimpleTypes.\r\nThis method is responsible for validating all possible combinations of the item, as of now it is only KIND but there can be multiple like MIN, MAX, LENGTH etc.\r\nLet me know if the flow is correct. So I can proceed accordingly.\r\nAlso, just to mention, using `govalidator`.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/almighty/almighty-core/106)\n<!-- Reviewable:end -->\n","created_at":"2016-08-10T12:26:17Z","updated_at":"2016-08-10T12:32:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"99c6a6cd45137bc87432fec012588d75ed954782","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/almighty/almighty-core/pulls/106/commits","review_comments_url":"https://api.github.com/repos/almighty/almighty-core/pulls/106/comments","review_comment_url":"https://api.github.com/repos/almighty/almighty-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/almighty/almighty-core/issues/106/comments","statuses_url":"https://api.github.com/repos/almighty/almighty-core/statuses/e5f6de7ed6add35e229bcaebfea1af7b16b9e209","head":{"label":"pranavgore09:iss-77","ref":"iss-77","sha":"e5f6de7ed6add35e229bcaebfea1af7b16b9e209","user":{"login":"pranavgore09","id":2026565,"avatar_url":"https://avatars.githubusercontent.com/u/2026565?v=3","gravatar_id":"","url":"https://api.github.com/users/pranavgore09","html_url":"https://github.com/pranavgore09","followers_url":"https://api.github.com/users/pranavgore09/followers","following_url":"https://api.github.com/users/pranavgore09/following{/other_user}","gists_url":"https://api.github.com/users/pranavgore09/gists{/gist_id}","starred_url":"https://api.github.com/users/pranavgore09/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pranavgore09/subscriptions","organizations_url":"https://api.github.com/users/pranavgore09/orgs","repos_url":"https://api.github.com/users/pranavgore09/repos","events_url":"https://api.github.com/users/pranavgore09/events{/privacy}","received_events_url":"https://api.github.com/users/pranavgore09/received_events","type":"User","site_admin":false},"repo":{"id":64831426,"name":"almighty-core","full_name":"pranavgore09/almighty-core","owner":{"login":"pranavgore09","id":2026565,"avatar_url":"https://avatars.githubusercontent.com/u/2026565?v=3","gravatar_id":"","url":"https://api.github.com/users/pranavgore09","html_url":"https://github.com/pranavgore09","followers_url":"https://api.github.com/users/pranavgore09/followers","following_url":"https://api.github.com/users/pranavgore09/following{/other_user}","gists_url":"https://api.github.com/users/pranavgore09/gists{/gist_id}","starred_url":"https://api.github.com/users/pranavgore09/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pranavgore09/subscriptions","organizations_url":"https://api.github.com/users/pranavgore09/orgs","repos_url":"https://api.github.com/users/pranavgore09/repos","events_url":"https://api.github.com/users/pranavgore09/events{/privacy}","received_events_url":"https://api.github.com/users/pranavgore09/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pranavgore09/almighty-core","description":null,"fork":true,"url":"https://api.github.com/repos/pranavgore09/almighty-core","forks_url":"https://api.github.com/repos/pranavgore09/almighty-core/forks","keys_url":"https://api.github.com/repos/pranavgore09/almighty-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pranavgore09/almighty-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pranavgore09/almighty-core/teams","hooks_url":"https://api.github.com/repos/pranavgore09/almighty-core/hooks","issue_events_url":"https://api.github.com/repos/pranavgore09/almighty-core/issues/events{/number}","events_url":"https://api.github.com/repos/pranavgore09/almighty-core/events","assignees_url":"https://api.github.com/repos/pranavgore09/almighty-core/assignees{/user}","branches_url":"https://api.github.com/repos/pranavgore09/almighty-core/branches{/branch}","tags_url":"https://api.github.com/repos/pranavgore09/almighty-core/tags","blobs_url":"https://api.github.com/repos/pranavgore09/almighty-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pranavgore09/almighty-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pranavgore09/almighty-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/pranavgore09/almighty-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pranavgore09/almighty-core/statuses/{sha}","languages_url":"https://api.github.com/repos/pranavgore09/almighty-core/languages","stargazers_url":"https://api.github.com/repos/pranavgore09/almighty-core/stargazers","contributors_url":"https://api.github.com/repos/pranavgore09/almighty-core/contributors","subscribers_url":"https://api.github.com/repos/pranavgore09/almighty-core/subscribers","subscription_url":"https://api.github.com/repos/pranavgore09/almighty-core/subscription","commits_url":"https://api.github.com/repos/pranavgore09/almighty-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/pranavgore09/almighty-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/pranavgore09/almighty-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/pranavgore09/almighty-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/pranavgore09/almighty-core/contents/{+path}","compare_url":"https://api.github.com/repos/pranavgore09/almighty-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pranavgore09/almighty-core/merges","archive_url":"https://api.github.com/repos/pranavgore09/almighty-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pranavgore09/almighty-core/downloads","issues_url":"https://api.github.com/repos/pranavgore09/almighty-core/issues{/number}","pulls_url":"https://api.github.com/repos/pranavgore09/almighty-core/pulls{/number}","milestones_url":"https://api.github.com/repos/pranavgore09/almighty-core/milestones{/number}","notifications_url":"https://api.github.com/repos/pranavgore09/almighty-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pranavgore09/almighty-core/labels{/name}","releases_url":"https://api.github.com/repos/pranavgore09/almighty-core/releases{/id}","deployments_url":"https://api.github.com/repos/pranavgore09/almighty-core/deployments","created_at":"2016-08-03T09:01:01Z","updated_at":"2016-08-03T09:01:02Z","pushed_at":"2016-08-10T09:20:18Z","git_url":"git://github.com/pranavgore09/almighty-core.git","ssh_url":"git@github.com:pranavgore09/almighty-core.git","clone_url":"https://github.com/pranavgore09/almighty-core.git","svn_url":"https://github.com/pranavgore09/almighty-core","homepage":null,"size":154,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"almighty:master","ref":"master","sha":"5d8220b512897cc825b24f62865f7ed6f31355e8","user":{"login":"almighty","id":17783151,"avatar_url":"https://avatars.githubusercontent.com/u/17783151?v=3","gravatar_id":"","url":"https://api.github.com/users/almighty","html_url":"https://github.com/almighty","followers_url":"https://api.github.com/users/almighty/followers","following_url":"https://api.github.com/users/almighty/following{/other_user}","gists_url":"https://api.github.com/users/almighty/gists{/gist_id}","starred_url":"https://api.github.com/users/almighty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/almighty/subscriptions","organizations_url":"https://api.github.com/users/almighty/orgs","repos_url":"https://api.github.com/users/almighty/repos","events_url":"https://api.github.com/users/almighty/events{/privacy}","received_events_url":"https://api.github.com/users/almighty/received_events","type":"Organization","site_admin":false},"repo":{"id":54260706,"name":"almighty-core","full_name":"almighty/almighty-core","owner":{"login":"almighty","id":17783151,"avatar_url":"https://avatars.githubusercontent.com/u/17783151?v=3","gravatar_id":"","url":"https://api.github.com/users/almighty","html_url":"https://github.com/almighty","followers_url":"https://api.github.com/users/almighty/followers","following_url":"https://api.github.com/users/almighty/following{/other_user}","gists_url":"https://api.github.com/users/almighty/gists{/gist_id}","starred_url":"https://api.github.com/users/almighty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/almighty/subscriptions","organizations_url":"https://api.github.com/users/almighty/orgs","repos_url":"https://api.github.com/users/almighty/repos","events_url":"https://api.github.com/users/almighty/events{/privacy}","received_events_url":"https://api.github.com/users/almighty/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/almighty/almighty-core","description":"","fork":false,"url":"https://api.github.com/repos/almighty/almighty-core","forks_url":"https://api.github.com/repos/almighty/almighty-core/forks","keys_url":"https://api.github.com/repos/almighty/almighty-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/almighty/almighty-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/almighty/almighty-core/teams","hooks_url":"https://api.github.com/repos/almighty/almighty-core/hooks","issue_events_url":"https://api.github.com/repos/almighty/almighty-core/issues/events{/number}","events_url":"https://api.github.com/repos/almighty/almighty-core/events","assignees_url":"https://api.github.com/repos/almighty/almighty-core/assignees{/user}","branches_url":"https://api.github.com/repos/almighty/almighty-core/branches{/branch}","tags_url":"https://api.github.com/repos/almighty/almighty-core/tags","blobs_url":"https://api.github.com/repos/almighty/almighty-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/almighty/almighty-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/almighty/almighty-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/almighty/almighty-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/almighty/almighty-core/statuses/{sha}","languages_url":"https://api.github.com/repos/almighty/almighty-core/languages","stargazers_url":"https://api.github.com/repos/almighty/almighty-core/stargazers","contributors_url":"https://api.github.com/repos/almighty/almighty-core/contributors","subscribers_url":"https://api.github.com/repos/almighty/almighty-core/subscribers","subscription_url":"https://api.github.com/repos/almighty/almighty-core/subscription","commits_url":"https://api.github.com/repos/almighty/almighty-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/almighty/almighty-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/almighty/almighty-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/almighty/almighty-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/almighty/almighty-core/contents/{+path}","compare_url":"https://api.github.com/repos/almighty/almighty-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/almighty/almighty-core/merges","archive_url":"https://api.github.com/repos/almighty/almighty-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/almighty/almighty-core/downloads","issues_url":"https://api.github.com/repos/almighty/almighty-core/issues{/number}","pulls_url":"https://api.github.com/repos/almighty/almighty-core/pulls{/number}","milestones_url":"https://api.github.com/repos/almighty/almighty-core/milestones{/number}","notifications_url":"https://api.github.com/repos/almighty/almighty-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/almighty/almighty-core/labels{/name}","releases_url":"https://api.github.com/repos/almighty/almighty-core/releases{/id}","deployments_url":"https://api.github.com/repos/almighty/almighty-core/deployments","created_at":"2016-03-19T10:42:15Z","updated_at":"2016-08-05T08:45:34Z","pushed_at":"2016-08-10T12:26:21Z","git_url":"git://github.com/almighty/almighty-core.git","ssh_url":"git@github.com:almighty/almighty-core.git","clone_url":"https://github.com/almighty/almighty-core.git","svn_url":"https://github.com/almighty/almighty-core","homepage":"http://devdoc.almighty.io/","size":297,"stargazers_count":4,"watchers_count":4,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":50,"forks":16,"open_issues":50,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/almighty/almighty-core/pulls/106"},"html":{"href":"https://github.com/almighty/almighty-core/pull/106"},"issue":{"href":"https://api.github.com/repos/almighty/almighty-core/issues/106"},"comments":{"href":"https://api.github.com/repos/almighty/almighty-core/issues/106/comments"},"review_comments":{"href":"https://api.github.com/repos/almighty/almighty-core/pulls/106/comments"},"review_comment":{"href":"https://api.github.com/repos/almighty/almighty-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/almighty/almighty-core/pulls/106/commits"},"statuses":{"href":"https://api.github.com/repos/almighty/almighty-core/statuses/e5f6de7ed6add35e229bcaebfea1af7b16b9e209"}}}}
{"actor":{"display_login":"aslakknutsen"}}