{"action":"created","issue":{"url":"https://api.github.com/repos/apache/parquet-cpp/issues/16","labels_url":"https://api.github.com/repos/apache/parquet-cpp/issues/16/labels{/name}","comments_url":"https://api.github.com/repos/apache/parquet-cpp/issues/16/comments","events_url":"https://api.github.com/repos/apache/parquet-cpp/issues/16/events","html_url":"https://github.com/apache/parquet-cpp/pull/16","id":125689365,"number":16,"title":"PARQUET-267: Detach thirdparty code from build configuration.","user":{"login":"kalaxy","id":974752,"avatar_url":"https://avatars.githubusercontent.com/u/974752?v=3","gravatar_id":"","url":"https://api.github.com/users/kalaxy","html_url":"https://github.com/kalaxy","followers_url":"https://api.github.com/users/kalaxy/followers","following_url":"https://api.github.com/users/kalaxy/following{/other_user}","gists_url":"https://api.github.com/users/kalaxy/gists{/gist_id}","starred_url":"https://api.github.com/users/kalaxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kalaxy/subscriptions","organizations_url":"https://api.github.com/users/kalaxy/orgs","repos_url":"https://api.github.com/users/kalaxy/repos","events_url":"https://api.github.com/users/kalaxy/events{/privacy}","received_events_url":"https://api.github.com/users/kalaxy/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-01-08T20:38:37Z","updated_at":"2016-01-12T02:10:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/parquet-cpp/pulls/16","html_url":"https://github.com/apache/parquet-cpp/pull/16","diff_url":"https://github.com/apache/parquet-cpp/pull/16.diff","patch_url":"https://github.com/apache/parquet-cpp/pull/16.patch"},"body":"This is based off of pull request https://github.com/apache/parquet-cpp/pull/14."},"comment":{"url":"https://api.github.com/repos/apache/parquet-cpp/issues/comments/170759372","html_url":"https://github.com/apache/parquet-cpp/pull/16#issuecomment-170759372","issue_url":"https://api.github.com/repos/apache/parquet-cpp/issues/16","id":170759372,"user":{"login":"nongli","id":242468,"avatar_url":"https://avatars.githubusercontent.com/u/242468?v=3","gravatar_id":"","url":"https://api.github.com/users/nongli","html_url":"https://github.com/nongli","followers_url":"https://api.github.com/users/nongli/followers","following_url":"https://api.github.com/users/nongli/following{/other_user}","gists_url":"https://api.github.com/users/nongli/gists{/gist_id}","starred_url":"https://api.github.com/users/nongli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nongli/subscriptions","organizations_url":"https://api.github.com/users/nongli/orgs","repos_url":"https://api.github.com/users/nongli/repos","events_url":"https://api.github.com/users/nongli/events{/privacy}","received_events_url":"https://api.github.com/users/nongli/received_events","type":"User","site_admin":false},"created_at":"2016-01-12T02:10:48Z","updated_at":"2016-01-12T02:10:48Z","body":"I think it would be helpful to add something like this and update the README for the simple path (with some more error checking):\r\n\r\n```\r\n~/Projects/parquet-cpp $ cat setup.sh\r\n#!/bin/bash\r\n\r\nTP_DIR=$(cd \"$(dirname \"$BASH_SOURCE\")\"; pwd)\r\n\r\nmkdir -p $TP_DIR/build\r\ncp -r $TP_DIR/thirdparty $TP_DIR/build\r\ncd $TP_DIR/build\r\n./thirdparty/download_thirdparty.sh\r\n./thirdparty/build_thirdparty.sh\r\n\r\nexport SNAPPY_HOME=$TP_DIR/build/thirdparty/installed\r\nexport LZ4_HOME=$TP_DIR/build/thirdparty/installed\r\n\r\ncd $TP_DIR\r\n```\r\n\r\nI tried to build thrift with these steps and it didn't work (error below). If this works for you, I can try to track down what's wrong with my env (OSX). I'm also fine if we don't manage thrift in this patch.\r\n\r\n```\r\nn file included from src/thrift/concurrency/ThreadManager.cpp:22:\r\nIn file included from ./src/thrift/concurrency/ThreadManager.h:24:\r\n./src/thrift/cxxfunctional.h:93:18: error: no member named 'bind' in namespace 'std'; did you mean 'find'?\r\n    using ::std::bind;\r\n          ~~~~~~~^~~~\r\n                 find\r\n/Library/Developer/CommandLineTools/usr/bin/../include/c++/v1/algorithm:862:1: note: 'find' declared here\r\nfind(_InputIterator __first, _InputIterator __last, const _Tp& __value_)\r\n^\r\nIn file included from src/thrift/concurrency/ThreadManager.cpp:22:\r\n./src/thrift/concurrency/ThreadManager.h:193:9: warning: class member cannot be redeclared [-Wredeclared-class-member]\r\n  class Task;\r\n```"}}