{"action":"created","issue":{"url":"https://api.github.com/repos/TokTok/tox-spec/issues/19","repository_url":"https://api.github.com/repos/TokTok/tox-spec","labels_url":"https://api.github.com/repos/TokTok/tox-spec/issues/19/labels{/name}","comments_url":"https://api.github.com/repos/TokTok/tox-spec/issues/19/comments","events_url":"https://api.github.com/repos/TokTok/tox-spec/issues/19/events","html_url":"https://github.com/TokTok/tox-spec/pull/19","id":137304231,"number":19,"title":"Add top level protocol packet description.","user":{"login":"iphydf","id":10647936,"avatar_url":"https://avatars.githubusercontent.com/u/10647936?v=3","gravatar_id":"","url":"https://api.github.com/users/iphydf","html_url":"https://github.com/iphydf","followers_url":"https://api.github.com/users/iphydf/followers","following_url":"https://api.github.com/users/iphydf/following{/other_user}","gists_url":"https://api.github.com/users/iphydf/gists{/gist_id}","starred_url":"https://api.github.com/users/iphydf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iphydf/subscriptions","organizations_url":"https://api.github.com/users/iphydf/orgs","repos_url":"https://api.github.com/users/iphydf/repos","events_url":"https://api.github.com/users/iphydf/events{/privacy}","received_events_url":"https://api.github.com/users/iphydf/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"zetok","id":3148759,"avatar_url":"https://avatars.githubusercontent.com/u/3148759?v=3","gravatar_id":"","url":"https://api.github.com/users/zetok","html_url":"https://github.com/zetok","followers_url":"https://api.github.com/users/zetok/followers","following_url":"https://api.github.com/users/zetok/following{/other_user}","gists_url":"https://api.github.com/users/zetok/gists{/gist_id}","starred_url":"https://api.github.com/users/zetok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zetok/subscriptions","organizations_url":"https://api.github.com/users/zetok/orgs","repos_url":"https://api.github.com/users/zetok/repos","events_url":"https://api.github.com/users/zetok/events{/privacy}","received_events_url":"https://api.github.com/users/zetok/received_events","type":"User","site_admin":false},"milestone":null,"comments":2,"created_at":"2016-02-29T16:39:40Z","updated_at":"2016-02-29T19:59:19Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/TokTok/tox-spec/pulls/19","html_url":"https://github.com/TokTok/tox-spec/pull/19","diff_url":"https://github.com/TokTok/tox-spec/pull/19.diff","patch_url":"https://github.com/TokTok/tox-spec/pull/19.patch"},"body":"All other packets sit inside this packet.\r\nYes, there will be redundancy between this part of the spec and the\r\ndetailed sections on each packet format, as both will define the packet\r\nkind number. I think this is acceptable. Maybe later we'll decide that\r\nit's not, but for now the table seems useful for implementations\r\n(perhaps we can generate it later).\n\n<!-- Reviewable:start -->\n[<img src=\"https://reviewable.io/review_button.svg\" height=\"40\" alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/toktok/tox-spec/19)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/TokTok/tox-spec/issues/comments/190356543","html_url":"https://github.com/TokTok/tox-spec/pull/19#issuecomment-190356543","issue_url":"https://api.github.com/repos/TokTok/tox-spec/issues/19","id":190356543,"user":{"login":"iphydf","id":10647936,"avatar_url":"https://avatars.githubusercontent.com/u/10647936?v=3","gravatar_id":"","url":"https://api.github.com/users/iphydf","html_url":"https://github.com/iphydf","followers_url":"https://api.github.com/users/iphydf/followers","following_url":"https://api.github.com/users/iphydf/following{/other_user}","gists_url":"https://api.github.com/users/iphydf/gists{/gist_id}","starred_url":"https://api.github.com/users/iphydf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iphydf/subscriptions","organizations_url":"https://api.github.com/users/iphydf/orgs","repos_url":"https://api.github.com/users/iphydf/repos","events_url":"https://api.github.com/users/iphydf/events{/privacy}","received_events_url":"https://api.github.com/users/iphydf/received_events","type":"User","site_admin":false},"created_at":"2016-02-29T19:59:19Z","updated_at":"2016-02-29T19:59:19Z","body":"\n\n\n\nReview status: 0 of 1 files reviewed at latest revision, 4 unresolved discussions.\n\n---\n\n*[spec.md, line 204 \\[r1\\]](https://reviewable.io:443/reviews/toktok/tox-spec/19#-KBiFKZa9wKw5x_Hx_IS:-KBiZ9I8cKvafqvYhemq:593266148) ([raw file](https://github.com/toktok/tox-spec/blob/5f58d90bc95fafef27e7708cf025ce920283b9c3/spec.md#L204)):*\nRewrote the section a bit and changed Protocol in the previous section to Transport Protocol as disambiguation.\n\n---\n\n*[spec.md, line 235 \\[r1\\]](https://reviewable.io:443/reviews/toktok/tox-spec/19#-KBiNwvOunhn3IOZowjB:-KBiZLg3w6aSDr6liJFX:76022575) ([raw file](https://github.com/toktok/tox-spec/blob/5f58d90bc95fafef27e7708cf025ce920283b9c3/spec.md#L235)):*\nThose are all inside other packets, not in the top level Protocol Packet. The packet kinds you pointed at are inside TCP client packets. There are a number of other packet types with their own kinds (messenger has some, group chat has yet another nested packet format). This list is exhaustive for the top level packet kinds.\n\n---\n\n*[spec.md, line 239 \\[r1\\]](https://reviewable.io:443/reviews/toktok/tox-spec/19#-KBiLf87glc-m6kiPcJA:-KBi_VlqOObiVqINKcZ4:1992371134) ([raw file](https://github.com/toktok/tox-spec/blob/5f58d90bc95fafef27e7708cf025ce920283b9c3/spec.md#L239)):*\nTrue, the Crypto packet in this list is the DHT Request packet. I'll change that. I do think Crypto Data is a good name, though.\n\n---\n\n*[spec.md, line 240 \\[r1\\]](https://reviewable.io:443/reviews/toktok/tox-spec/19#-KBiKJDv48ZhUlzo0_fl:-KBi_iiggn8dLSu7PbSS:-499146009) ([raw file](https://github.com/toktok/tox-spec/blob/5f58d90bc95fafef27e7708cf025ce920283b9c3/spec.md#L240)):*\nDone.\n\n---\n\n\n*Comments from the [review on Reviewable.io](https://reviewable.io:443/reviews/toktok/tox-spec/19)*\n<!-- Sent from Reviewable.io -->\n"}}