{"action":"created","comment":{"url":"https://api.github.com/repos/akka/alpakka/pulls/comments/89994777","pull_request_review_id":10519355,"id":89994777,"diff_hunk":"@@ -60,25 +61,30 @@ private[alpakka] final class S3Stream(credentials: AWSCredentials, region: Strin\n    * Uploads a stream of ByteStrings to a specified location as a multipart upload.\n    *\n    * @param s3Location\n+   * @param contentType The Content-Type to apply to the object\n+   * @param cannedAcl The canned ACL to apply to the object\n    * @param chunkSize\n    * @param chunkingParallelism\n    * @return","path":"s3/src/main/scala/akka/stream/alpakka/s3/impl/S3Stream.scala","position":21,"original_position":21,"commit_id":"b642f6518e9b08365b282aef5ca5bc9255b80d95","original_commit_id":"b642f6518e9b08365b282aef5ca5bc9255b80d95","user":{"login":"johanandren","id":666915,"avatar_url":"https://avatars.githubusercontent.com/u/666915?v=3","gravatar_id":"","url":"https://api.github.com/users/johanandren","html_url":"https://github.com/johanandren","followers_url":"https://api.github.com/users/johanandren/followers","following_url":"https://api.github.com/users/johanandren/following{/other_user}","gists_url":"https://api.github.com/users/johanandren/gists{/gist_id}","starred_url":"https://api.github.com/users/johanandren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johanandren/subscriptions","organizations_url":"https://api.github.com/users/johanandren/orgs","repos_url":"https://api.github.com/users/johanandren/repos","events_url":"https://api.github.com/users/johanandren/events{/privacy}","received_events_url":"https://api.github.com/users/johanandren/received_events","type":"User","site_admin":false},"body":"remove empty annotations thanks","created_at":"2016-11-29T11:56:40Z","updated_at":"2016-11-29T12:01:17Z","html_url":"https://github.com/akka/alpakka/pull/93#discussion_r89994777","pull_request_url":"https://api.github.com/repos/akka/alpakka/pulls/93","_links":{"self":{"href":"https://api.github.com/repos/akka/alpakka/pulls/comments/89994777"},"html":{"href":"https://github.com/akka/alpakka/pull/93#discussion_r89994777"},"pull_request":{"href":"https://api.github.com/repos/akka/alpakka/pulls/93"}}},"pull_request":{"url":"https://api.github.com/repos/akka/alpakka/pulls/93","id":95570436,"html_url":"https://github.com/akka/alpakka/pull/93","diff_url":"https://github.com/akka/alpakka/pull/93.diff","patch_url":"https://github.com/akka/alpakka/pull/93.patch","issue_url":"https://api.github.com/repos/akka/alpakka/issues/93","number":93,"state":"open","locked":false,"title":"Tune S3 (ACL, safe keys, object content type)","user":{"login":"TimothyKlim","id":387270,"avatar_url":"https://avatars.githubusercontent.com/u/387270?v=3","gravatar_id":"","url":"https://api.github.com/users/TimothyKlim","html_url":"https://github.com/TimothyKlim","followers_url":"https://api.github.com/users/TimothyKlim/followers","following_url":"https://api.github.com/users/TimothyKlim/following{/other_user}","gists_url":"https://api.github.com/users/TimothyKlim/gists{/gist_id}","starred_url":"https://api.github.com/users/TimothyKlim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TimothyKlim/subscriptions","organizations_url":"https://api.github.com/users/TimothyKlim/orgs","repos_url":"https://api.github.com/users/TimothyKlim/repos","events_url":"https://api.github.com/users/TimothyKlim/events{/privacy}","received_events_url":"https://api.github.com/users/TimothyKlim/received_events","type":"User","site_admin":false},"body":"- [x] Added [Canned ACL](http://docs.aws.amazon.com/AmazonS3/latest/dev/acl-overview.html#CannedACL) (https://github.com/akka/alpakka/issues/90)\r\n- [x] Ability to pass a content type of object\r\n- [x] Fixed signer error when an object key is not url safe (image@2x as an example)\r\n\r\nAnd thanks for this awesome library!\r\n\r\n/cc @johanandren @2m @patriknw","created_at":"2016-11-28T20:26:45Z","updated_at":"2016-11-29T12:01:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5ce1520bbc7e7b3810bae76594b34bf57cfe2978","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/akka/alpakka/pulls/93/commits","review_comments_url":"https://api.github.com/repos/akka/alpakka/pulls/93/comments","review_comment_url":"https://api.github.com/repos/akka/alpakka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/akka/alpakka/issues/93/comments","statuses_url":"https://api.github.com/repos/akka/alpakka/statuses/b642f6518e9b08365b282aef5ca5bc9255b80d95","head":{"label":"TimothyKlim:feature/s3_acl","ref":"feature/s3_acl","sha":"b642f6518e9b08365b282aef5ca5bc9255b80d95","user":{"login":"TimothyKlim","id":387270,"avatar_url":"https://avatars.githubusercontent.com/u/387270?v=3","gravatar_id":"","url":"https://api.github.com/users/TimothyKlim","html_url":"https://github.com/TimothyKlim","followers_url":"https://api.github.com/users/TimothyKlim/followers","following_url":"https://api.github.com/users/TimothyKlim/following{/other_user}","gists_url":"https://api.github.com/users/TimothyKlim/gists{/gist_id}","starred_url":"https://api.github.com/users/TimothyKlim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TimothyKlim/subscriptions","organizations_url":"https://api.github.com/users/TimothyKlim/orgs","repos_url":"https://api.github.com/users/TimothyKlim/repos","events_url":"https://api.github.com/users/TimothyKlim/events{/privacy}","received_events_url":"https://api.github.com/users/TimothyKlim/received_events","type":"User","site_admin":false},"repo":{"id":74960804,"name":"alpakka","full_name":"TimothyKlim/alpakka","owner":{"login":"TimothyKlim","id":387270,"avatar_url":"https://avatars.githubusercontent.com/u/387270?v=3","gravatar_id":"","url":"https://api.github.com/users/TimothyKlim","html_url":"https://github.com/TimothyKlim","followers_url":"https://api.github.com/users/TimothyKlim/followers","following_url":"https://api.github.com/users/TimothyKlim/following{/other_user}","gists_url":"https://api.github.com/users/TimothyKlim/gists{/gist_id}","starred_url":"https://api.github.com/users/TimothyKlim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TimothyKlim/subscriptions","organizations_url":"https://api.github.com/users/TimothyKlim/orgs","repos_url":"https://api.github.com/users/TimothyKlim/repos","events_url":"https://api.github.com/users/TimothyKlim/events{/privacy}","received_events_url":"https://api.github.com/users/TimothyKlim/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TimothyKlim/alpakka","description":"Akka Streams Connectors - Alpakka","fork":true,"url":"https://api.github.com/repos/TimothyKlim/alpakka","forks_url":"https://api.github.com/repos/TimothyKlim/alpakka/forks","keys_url":"https://api.github.com/repos/TimothyKlim/alpakka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TimothyKlim/alpakka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TimothyKlim/alpakka/teams","hooks_url":"https://api.github.com/repos/TimothyKlim/alpakka/hooks","issue_events_url":"https://api.github.com/repos/TimothyKlim/alpakka/issues/events{/number}","events_url":"https://api.github.com/repos/TimothyKlim/alpakka/events","assignees_url":"https://api.github.com/repos/TimothyKlim/alpakka/assignees{/user}","branches_url":"https://api.github.com/repos/TimothyKlim/alpakka/branches{/branch}","tags_url":"https://api.github.com/repos/TimothyKlim/alpakka/tags","blobs_url":"https://api.github.com/repos/TimothyKlim/alpakka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TimothyKlim/alpakka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TimothyKlim/alpakka/git/refs{/sha}","trees_url":"https://api.github.com/repos/TimothyKlim/alpakka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TimothyKlim/alpakka/statuses/{sha}","languages_url":"https://api.github.com/repos/TimothyKlim/alpakka/languages","stargazers_url":"https://api.github.com/repos/TimothyKlim/alpakka/stargazers","contributors_url":"https://api.github.com/repos/TimothyKlim/alpakka/contributors","subscribers_url":"https://api.github.com/repos/TimothyKlim/alpakka/subscribers","subscription_url":"https://api.github.com/repos/TimothyKlim/alpakka/subscription","commits_url":"https://api.github.com/repos/TimothyKlim/alpakka/commits{/sha}","git_commits_url":"https://api.github.com/repos/TimothyKlim/alpakka/git/commits{/sha}","comments_url":"https://api.github.com/repos/TimothyKlim/alpakka/comments{/number}","issue_comment_url":"https://api.github.com/repos/TimothyKlim/alpakka/issues/comments{/number}","contents_url":"https://api.github.com/repos/TimothyKlim/alpakka/contents/{+path}","compare_url":"https://api.github.com/repos/TimothyKlim/alpakka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TimothyKlim/alpakka/merges","archive_url":"https://api.github.com/repos/TimothyKlim/alpakka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TimothyKlim/alpakka/downloads","issues_url":"https://api.github.com/repos/TimothyKlim/alpakka/issues{/number}","pulls_url":"https://api.github.com/repos/TimothyKlim/alpakka/pulls{/number}","milestones_url":"https://api.github.com/repos/TimothyKlim/alpakka/milestones{/number}","notifications_url":"https://api.github.com/repos/TimothyKlim/alpakka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TimothyKlim/alpakka/labels{/name}","releases_url":"https://api.github.com/repos/TimothyKlim/alpakka/releases{/id}","deployments_url":"https://api.github.com/repos/TimothyKlim/alpakka/deployments","created_at":"2016-11-28T10:11:54Z","updated_at":"2016-11-28T10:11:55Z","pushed_at":"2016-11-29T11:05:57Z","git_url":"git://github.com/TimothyKlim/alpakka.git","ssh_url":"git@github.com:TimothyKlim/alpakka.git","clone_url":"https://github.com/TimothyKlim/alpakka.git","svn_url":"https://github.com/TimothyKlim/alpakka","homepage":"http://developer.lightbend.com/docs/alpakka/latest/","size":6657,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"akka:master","ref":"master","sha":"a2a20e8d6af11accca7595dc8e7877b937d72da8","user":{"login":"akka","id":1496237,"avatar_url":"https://avatars.githubusercontent.com/u/1496237?v=3","gravatar_id":"","url":"https://api.github.com/users/akka","html_url":"https://github.com/akka","followers_url":"https://api.github.com/users/akka/followers","following_url":"https://api.github.com/users/akka/following{/other_user}","gists_url":"https://api.github.com/users/akka/gists{/gist_id}","starred_url":"https://api.github.com/users/akka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akka/subscriptions","organizations_url":"https://api.github.com/users/akka/orgs","repos_url":"https://api.github.com/users/akka/repos","events_url":"https://api.github.com/users/akka/events{/privacy}","received_events_url":"https://api.github.com/users/akka/received_events","type":"Organization","site_admin":false},"repo":{"id":70807477,"name":"alpakka","full_name":"akka/alpakka","owner":{"login":"akka","id":1496237,"avatar_url":"https://avatars.githubusercontent.com/u/1496237?v=3","gravatar_id":"","url":"https://api.github.com/users/akka","html_url":"https://github.com/akka","followers_url":"https://api.github.com/users/akka/followers","following_url":"https://api.github.com/users/akka/following{/other_user}","gists_url":"https://api.github.com/users/akka/gists{/gist_id}","starred_url":"https://api.github.com/users/akka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akka/subscriptions","organizations_url":"https://api.github.com/users/akka/orgs","repos_url":"https://api.github.com/users/akka/repos","events_url":"https://api.github.com/users/akka/events{/privacy}","received_events_url":"https://api.github.com/users/akka/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/akka/alpakka","description":"Akka Streams Connectors - Alpakka","fork":false,"url":"https://api.github.com/repos/akka/alpakka","forks_url":"https://api.github.com/repos/akka/alpakka/forks","keys_url":"https://api.github.com/repos/akka/alpakka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akka/alpakka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akka/alpakka/teams","hooks_url":"https://api.github.com/repos/akka/alpakka/hooks","issue_events_url":"https://api.github.com/repos/akka/alpakka/issues/events{/number}","events_url":"https://api.github.com/repos/akka/alpakka/events","assignees_url":"https://api.github.com/repos/akka/alpakka/assignees{/user}","branches_url":"https://api.github.com/repos/akka/alpakka/branches{/branch}","tags_url":"https://api.github.com/repos/akka/alpakka/tags","blobs_url":"https://api.github.com/repos/akka/alpakka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akka/alpakka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akka/alpakka/git/refs{/sha}","trees_url":"https://api.github.com/repos/akka/alpakka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akka/alpakka/statuses/{sha}","languages_url":"https://api.github.com/repos/akka/alpakka/languages","stargazers_url":"https://api.github.com/repos/akka/alpakka/stargazers","contributors_url":"https://api.github.com/repos/akka/alpakka/contributors","subscribers_url":"https://api.github.com/repos/akka/alpakka/subscribers","subscription_url":"https://api.github.com/repos/akka/alpakka/subscription","commits_url":"https://api.github.com/repos/akka/alpakka/commits{/sha}","git_commits_url":"https://api.github.com/repos/akka/alpakka/git/commits{/sha}","comments_url":"https://api.github.com/repos/akka/alpakka/comments{/number}","issue_comment_url":"https://api.github.com/repos/akka/alpakka/issues/comments{/number}","contents_url":"https://api.github.com/repos/akka/alpakka/contents/{+path}","compare_url":"https://api.github.com/repos/akka/alpakka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akka/alpakka/merges","archive_url":"https://api.github.com/repos/akka/alpakka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akka/alpakka/downloads","issues_url":"https://api.github.com/repos/akka/alpakka/issues{/number}","pulls_url":"https://api.github.com/repos/akka/alpakka/pulls{/number}","milestones_url":"https://api.github.com/repos/akka/alpakka/milestones{/number}","notifications_url":"https://api.github.com/repos/akka/alpakka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akka/alpakka/labels{/name}","releases_url":"https://api.github.com/repos/akka/alpakka/releases{/id}","deployments_url":"https://api.github.com/repos/akka/alpakka/deployments","created_at":"2016-10-13T13:08:14Z","updated_at":"2016-11-28T15:17:35Z","pushed_at":"2016-11-29T11:05:58Z","git_url":"git://github.com/akka/alpakka.git","ssh_url":"git@github.com:akka/alpakka.git","clone_url":"https://github.com/akka/alpakka.git","svn_url":"https://github.com/akka/alpakka","homepage":"http://developer.lightbend.com/docs/alpakka/0.1/","size":6867,"stargazers_count":122,"watchers_count":122,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"open_issues_count":41,"forks":24,"open_issues":41,"watchers":122,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/akka/alpakka/pulls/93"},"html":{"href":"https://github.com/akka/alpakka/pull/93"},"issue":{"href":"https://api.github.com/repos/akka/alpakka/issues/93"},"comments":{"href":"https://api.github.com/repos/akka/alpakka/issues/93/comments"},"review_comments":{"href":"https://api.github.com/repos/akka/alpakka/pulls/93/comments"},"review_comment":{"href":"https://api.github.com/repos/akka/alpakka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/akka/alpakka/pulls/93/commits"},"statuses":{"href":"https://api.github.com/repos/akka/alpakka/statuses/b642f6518e9b08365b282aef5ca5bc9255b80d95"}}}}
{"actor":{"display_login":"johanandren"}}