{"action":"created","issue":{"url":"https://api.github.com/repos/xbmc/xbmc/issues/10074","repository_url":"https://api.github.com/repos/xbmc/xbmc","labels_url":"https://api.github.com/repos/xbmc/xbmc/issues/10074/labels{/name}","comments_url":"https://api.github.com/repos/xbmc/xbmc/issues/10074/comments","events_url":"https://api.github.com/repos/xbmc/xbmc/issues/10074/events","html_url":"https://github.com/xbmc/xbmc/pull/10074","id":164060450,"number":10074,"title":"[PVR][json-rpc] change/fix timer API, sync pvr types fields with current implementation","user":{"login":"ksooo","id":3226626,"avatar_url":"https://avatars.githubusercontent.com/u/3226626?v=3","gravatar_id":"","url":"https://api.github.com/users/ksooo","html_url":"https://github.com/ksooo","followers_url":"https://api.github.com/users/ksooo/followers","following_url":"https://api.github.com/users/ksooo/following{/other_user}","gists_url":"https://api.github.com/users/ksooo/gists{/gist_id}","starred_url":"https://api.github.com/users/ksooo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ksooo/subscriptions","organizations_url":"https://api.github.com/users/ksooo/orgs","repos_url":"https://api.github.com/users/ksooo/repos","events_url":"https://api.github.com/users/ksooo/events{/privacy}","received_events_url":"https://api.github.com/users/ksooo/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/xbmc/xbmc/labels/Fix","name":"Fix","color":"0b02e1"},{"url":"https://api.github.com/repos/xbmc/xbmc/labels/Improvement","name":"Improvement","color":"0b02e1"},{"url":"https://api.github.com/repos/xbmc/xbmc/labels/JSON-RPC%20API%20Change","name":"JSON-RPC API Change","color":"e11d21"},{"url":"https://api.github.com/repos/xbmc/xbmc/labels/Krypton","name":"Krypton","color":"fbca04"},{"url":"https://api.github.com/repos/xbmc/xbmc/labels/PVR","name":"PVR","color":"009800"}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/xbmc/xbmc/milestones/86","html_url":"https://github.com/xbmc/xbmc/milestones/Krypton%2017.0-alpha3","labels_url":"https://api.github.com/repos/xbmc/xbmc/milestones/86/labels","id":1837954,"number":86,"title":"Krypton 17.0-alpha3","description":"","creator":{"login":"MartijnKaijser","id":907436,"avatar_url":"https://avatars.githubusercontent.com/u/907436?v=3","gravatar_id":"","url":"https://api.github.com/users/MartijnKaijser","html_url":"https://github.com/MartijnKaijser","followers_url":"https://api.github.com/users/MartijnKaijser/followers","following_url":"https://api.github.com/users/MartijnKaijser/following{/other_user}","gists_url":"https://api.github.com/users/MartijnKaijser/gists{/gist_id}","starred_url":"https://api.github.com/users/MartijnKaijser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MartijnKaijser/subscriptions","organizations_url":"https://api.github.com/users/MartijnKaijser/orgs","repos_url":"https://api.github.com/users/MartijnKaijser/repos","events_url":"https://api.github.com/users/MartijnKaijser/events{/privacy}","received_events_url":"https://api.github.com/users/MartijnKaijser/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":110,"state":"open","created_at":"2016-06-20T12:10:23Z","updated_at":"2016-07-25T20:01:11Z","due_on":"2016-07-30T22:00:00Z","closed_at":null},"comments":16,"created_at":"2016-07-06T12:04:51Z","updated_at":"2016-07-26T10:19:45Z","closed_at":"2016-07-18T14:36:17Z","pull_request":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/10074","html_url":"https://github.com/xbmc/xbmc/pull/10074","diff_url":"https://github.com/xbmc/xbmc/pull/10074.diff","patch_url":"https://github.com/xbmc/xbmc/pull/10074.patch"},"body":"This PR superseeds #10058. It changes/fixes the current json-rpc pvr timer methods.\r\n\r\nFurthermore it synchronizes the json-rpc fields for the various pvr types (timers, epg tags, channels, recordings) with it's current implementation.\r\n\r\n@Tolriq @joethefox : could you test this, please?"},"comment":{"url":"https://api.github.com/repos/xbmc/xbmc/issues/comments/235228038","html_url":"https://github.com/xbmc/xbmc/pull/10074#issuecomment-235228038","issue_url":"https://api.github.com/repos/xbmc/xbmc/issues/10074","id":235228038,"user":{"login":"joethefox","id":1732455,"avatar_url":"https://avatars.githubusercontent.com/u/1732455?v=3","gravatar_id":"","url":"https://api.github.com/users/joethefox","html_url":"https://github.com/joethefox","followers_url":"https://api.github.com/users/joethefox/followers","following_url":"https://api.github.com/users/joethefox/following{/other_user}","gists_url":"https://api.github.com/users/joethefox/gists{/gist_id}","starred_url":"https://api.github.com/users/joethefox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joethefox/subscriptions","organizations_url":"https://api.github.com/users/joethefox/orgs","repos_url":"https://api.github.com/users/joethefox/repos","events_url":"https://api.github.com/users/joethefox/events{/privacy}","received_events_url":"https://api.github.com/users/joethefox/received_events","type":"User","site_admin":false},"created_at":"2016-07-26T10:19:45Z","updated_at":"2016-07-26T10:19:45Z","body":"Tested all the changes and I can confirm that I haven't noticed any regressions so far.\r\n\r\nThe issue I've found is when calling PVR.SetTimer method with \"timerrule\" set to TRUE. \r\nThe resulting timer is created but seems invalid: \"Search guide for\" is empty (default is the same as the \"Name\" field), the \"Days of week\" are empty, \"Start any time\" and \"End any time\" are not enabled by default with the result that no one broadcast is actually programmed to be recorded."}}
{"actor":{"display_login":"joethefox"}}