{"action":"opened","number":1465,"pull_request":{"url":"https://api.github.com/repos/linkedin/gobblin/pulls/1465","id":98188673,"html_url":"https://github.com/linkedin/gobblin/pull/1465","diff_url":"https://github.com/linkedin/gobblin/pull/1465.diff","patch_url":"https://github.com/linkedin/gobblin/pull/1465.patch","issue_url":"https://api.github.com/repos/linkedin/gobblin/issues/1465","number":1465,"state":"open","locked":false,"title":"Fix PartitionLevelWatermarkerTest time initialization gap...","user":{"login":"agepati","id":4252260,"avatar_url":"https://avatars.githubusercontent.com/u/4252260?v=3","gravatar_id":"","url":"https://api.github.com/users/agepati","html_url":"https://github.com/agepati","followers_url":"https://api.github.com/users/agepati/followers","following_url":"https://api.github.com/users/agepati/following{/other_user}","gists_url":"https://api.github.com/users/agepati/gists{/gist_id}","starred_url":"https://api.github.com/users/agepati/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agepati/subscriptions","organizations_url":"https://api.github.com/users/agepati/orgs","repos_url":"https://api.github.com/users/agepati/repos","events_url":"https://api.github.com/users/agepati/events{/privacy}","received_events_url":"https://api.github.com/users/agepati/received_events","type":"User","site_admin":false},"body":"…between test and code\r\n\r\nThere is a transient test failure in: gobblin.data.management.conversion.hive.watermarker.PartitionLevelWatermarkerTest\r\n\r\njava.lang.AssertionError: Maps do not have the same size:0 != 3\r\n\tat org.testng.Assert.fail(Assert.java:94)\r\n\tat org.testng.Assert.assertEquals(Assert.java:803)\r\n\tat gobblin.data.management.conversion.hive.watermarker.PartitionLevelWatermarkerTest.testRecentlyModifiedPartitionWatermarks(PartitionLevelWatermarkerTest.java:323)\r\n\tat sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)\r\n\tat sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)\r\n\tat sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)\r\n\tat java.lang.reflect.Method.invoke(Method.java:498)\r\n\r\nThis seems to be happening because there is a time gap between the initialization of time5DaysAgo in the test and the leastWatermarkToPersistInState in the PartitionLevelWatermarker. Right now the test data is spaced around 100ms, but the time between these two times in ranging from <100 ms, in which case the test succeeds up to ~2000ms, in which case the test fails because all the test watermark times are older than the very recently initialized leastWatermarkToPersistInState.\r\n\r\nThis fix uses the same time for both the test and the leastWatermarkToPersistInState to help the test succeed consistently.","created_at":"2016-12-15T16:52:52Z","updated_at":"2016-12-15T16:52:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/linkedin/gobblin/pulls/1465/commits","review_comments_url":"https://api.github.com/repos/linkedin/gobblin/pulls/1465/comments","review_comment_url":"https://api.github.com/repos/linkedin/gobblin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/linkedin/gobblin/issues/1465/comments","statuses_url":"https://api.github.com/repos/linkedin/gobblin/statuses/809967c947205658c38bc7dc79ab9b544d4a685f","head":{"label":"agepati:agepati-watermark-test-fix","ref":"agepati-watermark-test-fix","sha":"809967c947205658c38bc7dc79ab9b544d4a685f","user":{"login":"agepati","id":4252260,"avatar_url":"https://avatars.githubusercontent.com/u/4252260?v=3","gravatar_id":"","url":"https://api.github.com/users/agepati","html_url":"https://github.com/agepati","followers_url":"https://api.github.com/users/agepati/followers","following_url":"https://api.github.com/users/agepati/following{/other_user}","gists_url":"https://api.github.com/users/agepati/gists{/gist_id}","starred_url":"https://api.github.com/users/agepati/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agepati/subscriptions","organizations_url":"https://api.github.com/users/agepati/orgs","repos_url":"https://api.github.com/users/agepati/repos","events_url":"https://api.github.com/users/agepati/events{/privacy}","received_events_url":"https://api.github.com/users/agepati/received_events","type":"User","site_admin":false},"repo":{"id":76574658,"name":"gobblin","full_name":"agepati/gobblin","owner":{"login":"agepati","id":4252260,"avatar_url":"https://avatars.githubusercontent.com/u/4252260?v=3","gravatar_id":"","url":"https://api.github.com/users/agepati","html_url":"https://github.com/agepati","followers_url":"https://api.github.com/users/agepati/followers","following_url":"https://api.github.com/users/agepati/following{/other_user}","gists_url":"https://api.github.com/users/agepati/gists{/gist_id}","starred_url":"https://api.github.com/users/agepati/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agepati/subscriptions","organizations_url":"https://api.github.com/users/agepati/orgs","repos_url":"https://api.github.com/users/agepati/repos","events_url":"https://api.github.com/users/agepati/events{/privacy}","received_events_url":"https://api.github.com/users/agepati/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/agepati/gobblin","description":"Universal data ingestion framework for Hadoop.","fork":true,"url":"https://api.github.com/repos/agepati/gobblin","forks_url":"https://api.github.com/repos/agepati/gobblin/forks","keys_url":"https://api.github.com/repos/agepati/gobblin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/agepati/gobblin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/agepati/gobblin/teams","hooks_url":"https://api.github.com/repos/agepati/gobblin/hooks","issue_events_url":"https://api.github.com/repos/agepati/gobblin/issues/events{/number}","events_url":"https://api.github.com/repos/agepati/gobblin/events","assignees_url":"https://api.github.com/repos/agepati/gobblin/assignees{/user}","branches_url":"https://api.github.com/repos/agepati/gobblin/branches{/branch}","tags_url":"https://api.github.com/repos/agepati/gobblin/tags","blobs_url":"https://api.github.com/repos/agepati/gobblin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/agepati/gobblin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/agepati/gobblin/git/refs{/sha}","trees_url":"https://api.github.com/repos/agepati/gobblin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/agepati/gobblin/statuses/{sha}","languages_url":"https://api.github.com/repos/agepati/gobblin/languages","stargazers_url":"https://api.github.com/repos/agepati/gobblin/stargazers","contributors_url":"https://api.github.com/repos/agepati/gobblin/contributors","subscribers_url":"https://api.github.com/repos/agepati/gobblin/subscribers","subscription_url":"https://api.github.com/repos/agepati/gobblin/subscription","commits_url":"https://api.github.com/repos/agepati/gobblin/commits{/sha}","git_commits_url":"https://api.github.com/repos/agepati/gobblin/git/commits{/sha}","comments_url":"https://api.github.com/repos/agepati/gobblin/comments{/number}","issue_comment_url":"https://api.github.com/repos/agepati/gobblin/issues/comments{/number}","contents_url":"https://api.github.com/repos/agepati/gobblin/contents/{+path}","compare_url":"https://api.github.com/repos/agepati/gobblin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/agepati/gobblin/merges","archive_url":"https://api.github.com/repos/agepati/gobblin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/agepati/gobblin/downloads","issues_url":"https://api.github.com/repos/agepati/gobblin/issues{/number}","pulls_url":"https://api.github.com/repos/agepati/gobblin/pulls{/number}","milestones_url":"https://api.github.com/repos/agepati/gobblin/milestones{/number}","notifications_url":"https://api.github.com/repos/agepati/gobblin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/agepati/gobblin/labels{/name}","releases_url":"https://api.github.com/repos/agepati/gobblin/releases{/id}","deployments_url":"https://api.github.com/repos/agepati/gobblin/deployments","created_at":"2016-12-15T16:05:51Z","updated_at":"2016-12-15T16:05:57Z","pushed_at":"2016-12-15T16:49:58Z","git_url":"git://github.com/agepati/gobblin.git","ssh_url":"git@github.com:agepati/gobblin.git","clone_url":"https://github.com/agepati/gobblin.git","svn_url":"https://github.com/agepati/gobblin","homepage":"https://github.com/linkedin/gobblin/wiki","size":102725,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"linkedin:master","ref":"master","sha":"0bbf6db27e1dd3f0a1eb93b35d95bb429f52639d","user":{"login":"linkedin","id":357098,"avatar_url":"https://avatars.githubusercontent.com/u/357098?v=3","gravatar_id":"","url":"https://api.github.com/users/linkedin","html_url":"https://github.com/linkedin","followers_url":"https://api.github.com/users/linkedin/followers","following_url":"https://api.github.com/users/linkedin/following{/other_user}","gists_url":"https://api.github.com/users/linkedin/gists{/gist_id}","starred_url":"https://api.github.com/users/linkedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkedin/subscriptions","organizations_url":"https://api.github.com/users/linkedin/orgs","repos_url":"https://api.github.com/users/linkedin/repos","events_url":"https://api.github.com/users/linkedin/events{/privacy}","received_events_url":"https://api.github.com/users/linkedin/received_events","type":"Organization","site_admin":false},"repo":{"id":27392543,"name":"gobblin","full_name":"linkedin/gobblin","owner":{"login":"linkedin","id":357098,"avatar_url":"https://avatars.githubusercontent.com/u/357098?v=3","gravatar_id":"","url":"https://api.github.com/users/linkedin","html_url":"https://github.com/linkedin","followers_url":"https://api.github.com/users/linkedin/followers","following_url":"https://api.github.com/users/linkedin/following{/other_user}","gists_url":"https://api.github.com/users/linkedin/gists{/gist_id}","starred_url":"https://api.github.com/users/linkedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkedin/subscriptions","organizations_url":"https://api.github.com/users/linkedin/orgs","repos_url":"https://api.github.com/users/linkedin/repos","events_url":"https://api.github.com/users/linkedin/events{/privacy}","received_events_url":"https://api.github.com/users/linkedin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/linkedin/gobblin","description":"Universal data ingestion framework for Hadoop.","fork":false,"url":"https://api.github.com/repos/linkedin/gobblin","forks_url":"https://api.github.com/repos/linkedin/gobblin/forks","keys_url":"https://api.github.com/repos/linkedin/gobblin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linkedin/gobblin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linkedin/gobblin/teams","hooks_url":"https://api.github.com/repos/linkedin/gobblin/hooks","issue_events_url":"https://api.github.com/repos/linkedin/gobblin/issues/events{/number}","events_url":"https://api.github.com/repos/linkedin/gobblin/events","assignees_url":"https://api.github.com/repos/linkedin/gobblin/assignees{/user}","branches_url":"https://api.github.com/repos/linkedin/gobblin/branches{/branch}","tags_url":"https://api.github.com/repos/linkedin/gobblin/tags","blobs_url":"https://api.github.com/repos/linkedin/gobblin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linkedin/gobblin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linkedin/gobblin/git/refs{/sha}","trees_url":"https://api.github.com/repos/linkedin/gobblin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linkedin/gobblin/statuses/{sha}","languages_url":"https://api.github.com/repos/linkedin/gobblin/languages","stargazers_url":"https://api.github.com/repos/linkedin/gobblin/stargazers","contributors_url":"https://api.github.com/repos/linkedin/gobblin/contributors","subscribers_url":"https://api.github.com/repos/linkedin/gobblin/subscribers","subscription_url":"https://api.github.com/repos/linkedin/gobblin/subscription","commits_url":"https://api.github.com/repos/linkedin/gobblin/commits{/sha}","git_commits_url":"https://api.github.com/repos/linkedin/gobblin/git/commits{/sha}","comments_url":"https://api.github.com/repos/linkedin/gobblin/comments{/number}","issue_comment_url":"https://api.github.com/repos/linkedin/gobblin/issues/comments{/number}","contents_url":"https://api.github.com/repos/linkedin/gobblin/contents/{+path}","compare_url":"https://api.github.com/repos/linkedin/gobblin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linkedin/gobblin/merges","archive_url":"https://api.github.com/repos/linkedin/gobblin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linkedin/gobblin/downloads","issues_url":"https://api.github.com/repos/linkedin/gobblin/issues{/number}","pulls_url":"https://api.github.com/repos/linkedin/gobblin/pulls{/number}","milestones_url":"https://api.github.com/repos/linkedin/gobblin/milestones{/number}","notifications_url":"https://api.github.com/repos/linkedin/gobblin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linkedin/gobblin/labels{/name}","releases_url":"https://api.github.com/repos/linkedin/gobblin/releases{/id}","deployments_url":"https://api.github.com/repos/linkedin/gobblin/deployments","created_at":"2014-12-01T18:10:50Z","updated_at":"2016-12-15T12:44:44Z","pushed_at":"2016-12-15T13:49:46Z","git_url":"git://github.com/linkedin/gobblin.git","ssh_url":"git@github.com:linkedin/gobblin.git","clone_url":"https://github.com/linkedin/gobblin.git","svn_url":"https://github.com/linkedin/gobblin","homepage":"https://github.com/linkedin/gobblin/wiki","size":102725,"stargazers_count":789,"watchers_count":789,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":332,"mirror_url":null,"open_issues_count":142,"forks":332,"open_issues":142,"watchers":789,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/linkedin/gobblin/pulls/1465"},"html":{"href":"https://github.com/linkedin/gobblin/pull/1465"},"issue":{"href":"https://api.github.com/repos/linkedin/gobblin/issues/1465"},"comments":{"href":"https://api.github.com/repos/linkedin/gobblin/issues/1465/comments"},"review_comments":{"href":"https://api.github.com/repos/linkedin/gobblin/pulls/1465/comments"},"review_comment":{"href":"https://api.github.com/repos/linkedin/gobblin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/linkedin/gobblin/pulls/1465/commits"},"statuses":{"href":"https://api.github.com/repos/linkedin/gobblin/statuses/809967c947205658c38bc7dc79ab9b544d4a685f"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":22,"deletions":6,"changed_files":2}}
{"actor":{"display_login":"agepati"}}