{"action":"created","comment":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/comments/68951580","id":68951580,"diff_hunk":"@@ -1,43 +1,52 @@\n-<form class=\"choicegroup capa_inputtype\" id=\"inputtype_${id}\">\n+<form class=\"choicegroup capa_inputtype\" id=\"${id}-form\">\n     <fieldset role=\"${input_type}group\" aria-label=\"${label}\">\n+      % if response_data['label']:\n+        <legend id=\"${id}-legend\" class=\"response-fieldset-legend field-group-hd\">${response_data['label']}</legend>\n+      % endif\n         % for choice_id, choice_description in choices:\n-        <label for=\"input_${id}_${choice_id}\"\n-            ## If the student has selected this choice...\n-            % if input_type == 'radio' and ( (isinstance(value, basestring) and (choice_id == value))  or  (not isinstance(value, basestring) and choice_id in value) ):\n+          <div class=\"field\" aria-live=\"polite\" aria-atomic=\"true\">\n             <%\n-                if status == 'correct':\n-                    correctness = 'correct'\n-                elif status == 'partially-correct':\n-                    correctness = 'partially-correct'\n-                elif status == 'incorrect':\n-                    correctness = 'incorrect'\n-                else:\n-                    correctness = None\n+              label_class = 'response-label field-label label-inline'\n             %>\n-            % if correctness and not show_correctness=='never':\n-            class=\"choicegroup_${correctness}\"\n-            % endif\n-            % endif\n-            >\n-            <input type=\"${input_type}\" name=\"input_${id}${name_array_suffix}\" id=\"input_${id}_${choice_id}\" aria-role=\"radio\" aria-describedby=\"answer_${id}\" value=\"${choice_id}\"\n-            ## If the student selected this choice...\n-            % if input_type == 'radio' and ( (isinstance(value, basestring) and (choice_id == value))  or  (not isinstance(value, basestring) and choice_id in value) ):\n-            checked=\"true\"\n-            % elif input_type != 'radio' and choice_id in value:\n-            checked=\"true\"\n-            % endif\n-            % if input_type != 'radio':\n-            aria-multiselectable=\"true\"\n-            % endif\n+            <label id=\"${id}-{$choice_id}-label\"\n+                ## If the student has selected this choice...\n+                % if input_type == 'radio' and ( (isinstance(value, basestring) and (choice_id == value))  or  (not isinstance(value, basestring) and choice_id in value) ):","path":"common/lib/capa/capa/templates/choicegroup.html","position":40,"original_position":40,"commit_id":"1ab4da24248b95d0b24364271e09c10f639e94ab","original_commit_id":"1ab4da24248b95d0b24364271e09c10f639e94ab","user":{"login":"ehteshamkafeel","id":1213123,"avatar_url":"https://avatars.githubusercontent.com/u/1213123?v=3","gravatar_id":"","url":"https://api.github.com/users/ehteshamkafeel","html_url":"https://github.com/ehteshamkafeel","followers_url":"https://api.github.com/users/ehteshamkafeel/followers","following_url":"https://api.github.com/users/ehteshamkafeel/following{/other_user}","gists_url":"https://api.github.com/users/ehteshamkafeel/gists{/gist_id}","starred_url":"https://api.github.com/users/ehteshamkafeel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ehteshamkafeel/subscriptions","organizations_url":"https://api.github.com/users/ehteshamkafeel/orgs","repos_url":"https://api.github.com/users/ehteshamkafeel/repos","events_url":"https://api.github.com/users/ehteshamkafeel/events{/privacy}","received_events_url":"https://api.github.com/users/ehteshamkafeel/received_events","type":"User","site_admin":false},"body":"@cptvitamin this templates covers both `radio` and `checkbox` as input type. If we go with hardcoding the input types and making the templates more specific then we will need to make a separate template for checkbox. Do you think this is how we should proceed?","created_at":"2016-06-29T14:06:51Z","updated_at":"2016-06-29T14:06:51Z","html_url":"https://github.com/edx/edx-platform/pull/12814#discussion_r68951580","pull_request_url":"https://api.github.com/repos/edx/edx-platform/pulls/12814","_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments/68951580"},"html":{"href":"https://github.com/edx/edx-platform/pull/12814#discussion_r68951580"},"pull_request":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/12814"}}},"pull_request":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/12814","id":74594884,"html_url":"https://github.com/edx/edx-platform/pull/12814","diff_url":"https://github.com/edx/edx-platform/pull/12814.diff","patch_url":"https://github.com/edx/edx-platform/pull/12814.patch","issue_url":"https://api.github.com/repos/edx/edx-platform/issues/12814","number":12814,"state":"open","locked":false,"title":"WIP FEDX-161make CAPA problems (MultipleChoice and Checkboxes) accessible","user":{"login":"ehteshamkafeel","id":1213123,"avatar_url":"https://avatars.githubusercontent.com/u/1213123?v=3","gravatar_id":"","url":"https://api.github.com/users/ehteshamkafeel","html_url":"https://github.com/ehteshamkafeel","followers_url":"https://api.github.com/users/ehteshamkafeel/followers","following_url":"https://api.github.com/users/ehteshamkafeel/following{/other_user}","gists_url":"https://api.github.com/users/ehteshamkafeel/gists{/gist_id}","starred_url":"https://api.github.com/users/ehteshamkafeel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ehteshamkafeel/subscriptions","organizations_url":"https://api.github.com/users/ehteshamkafeel/orgs","repos_url":"https://api.github.com/users/ehteshamkafeel/repos","events_url":"https://api.github.com/users/ehteshamkafeel/events{/privacy}","received_events_url":"https://api.github.com/users/ehteshamkafeel/received_events","type":"User","site_admin":false},"body":"This PR includes changes to make choicegroup CAPA problems accessible according to this [sample HTML](http://codepen.io/cptvitamin/pen/ZWgaqp?editors=1000).\r\n\r\n## Related Story\r\nhttps://openedx.atlassian.net/browse/FEDX-161\r\n\r\n## Post-review\r\n- [ ] Squash commits into discrete sets of changes with descriptive commit messages.\r\n\r\n## Reviewers\r\n- [ ] @cptvitamin \r\n- [ ] @clrux\r\n\r\n## Sandbox\r\nhttp://multiplechoice.sandbox.edx.org/\r\n\r\n@muzaffaryousaf FYI","created_at":"2016-06-21T11:29:51Z","updated_at":"2016-06-29T14:06:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"094c02289d82be6155ebd66368d7bb72075cb16f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/edx/edx-platform/pulls/12814/commits","review_comments_url":"https://api.github.com/repos/edx/edx-platform/pulls/12814/comments","review_comment_url":"https://api.github.com/repos/edx/edx-platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/edx/edx-platform/issues/12814/comments","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/1ab4da24248b95d0b24364271e09c10f639e94ab","head":{"label":"edx:ekafeel/fedx-161","ref":"ekafeel/fedx-161","sha":"1ab4da24248b95d0b24364271e09c10f639e94ab","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":10391073,"name":"edx-platform","full_name":"edx/edx-platform","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-platform","description":"The Open edX platform, the software that powers edX!","fork":false,"url":"https://api.github.com/repos/edx/edx-platform","forks_url":"https://api.github.com/repos/edx/edx-platform/forks","keys_url":"https://api.github.com/repos/edx/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-platform/teams","hooks_url":"https://api.github.com/repos/edx/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-platform/events","assignees_url":"https://api.github.com/repos/edx/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-platform/tags","blobs_url":"https://api.github.com/repos/edx/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-platform/languages","stargazers_url":"https://api.github.com/repos/edx/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-platform/subscription","commits_url":"https://api.github.com/repos/edx/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-platform/merges","archive_url":"https://api.github.com/repos/edx/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-platform/downloads","issues_url":"https://api.github.com/repos/edx/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-platform/releases{/id}","deployments_url":"https://api.github.com/repos/edx/edx-platform/deployments","created_at":"2013-05-30T20:20:38Z","updated_at":"2016-06-29T02:17:28Z","pushed_at":"2016-06-29T13:43:32Z","git_url":"git://github.com/edx/edx-platform.git","ssh_url":"git@github.com:edx/edx-platform.git","clone_url":"https://github.com/edx/edx-platform.git","svn_url":"https://github.com/edx/edx-platform","homepage":"http://open.edx.org/","size":779579,"stargazers_count":2649,"watchers_count":2649,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1606,"mirror_url":null,"open_issues_count":179,"forks":1606,"open_issues":179,"watchers":2649,"default_branch":"master"}},"base":{"label":"edx:ammar/poc","ref":"ammar/poc","sha":"1949c31e7fee040d41354965dae2da3db3a89e35","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":10391073,"name":"edx-platform","full_name":"edx/edx-platform","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-platform","description":"The Open edX platform, the software that powers edX!","fork":false,"url":"https://api.github.com/repos/edx/edx-platform","forks_url":"https://api.github.com/repos/edx/edx-platform/forks","keys_url":"https://api.github.com/repos/edx/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-platform/teams","hooks_url":"https://api.github.com/repos/edx/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-platform/events","assignees_url":"https://api.github.com/repos/edx/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-platform/tags","blobs_url":"https://api.github.com/repos/edx/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-platform/languages","stargazers_url":"https://api.github.com/repos/edx/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-platform/subscription","commits_url":"https://api.github.com/repos/edx/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-platform/merges","archive_url":"https://api.github.com/repos/edx/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-platform/downloads","issues_url":"https://api.github.com/repos/edx/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-platform/releases{/id}","deployments_url":"https://api.github.com/repos/edx/edx-platform/deployments","created_at":"2013-05-30T20:20:38Z","updated_at":"2016-06-29T02:17:28Z","pushed_at":"2016-06-29T13:43:32Z","git_url":"git://github.com/edx/edx-platform.git","ssh_url":"git@github.com:edx/edx-platform.git","clone_url":"https://github.com/edx/edx-platform.git","svn_url":"https://github.com/edx/edx-platform","homepage":"http://open.edx.org/","size":779579,"stargazers_count":2649,"watchers_count":2649,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1606,"mirror_url":null,"open_issues_count":179,"forks":1606,"open_issues":179,"watchers":2649,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/12814"},"html":{"href":"https://github.com/edx/edx-platform/pull/12814"},"issue":{"href":"https://api.github.com/repos/edx/edx-platform/issues/12814"},"comments":{"href":"https://api.github.com/repos/edx/edx-platform/issues/12814/comments"},"review_comments":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/12814/comments"},"review_comment":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/12814/commits"},"statuses":{"href":"https://api.github.com/repos/edx/edx-platform/statuses/1ab4da24248b95d0b24364271e09c10f639e94ab"}}}}
{"actor":{"display_login":"ehteshamkafeel"}}