{"action":"created","issue":{"url":"https://api.github.com/repos/firehol/netdata/issues/255","repository_url":"https://api.github.com/repos/firehol/netdata","labels_url":"https://api.github.com/repos/firehol/netdata/issues/255/labels{/name}","comments_url":"https://api.github.com/repos/firehol/netdata/issues/255/comments","events_url":"https://api.github.com/repos/firehol/netdata/issues/255/events","html_url":"https://github.com/firehol/netdata/issues/255","id":148967415,"number":255,"title":"My small contribution...","user":{"login":"fredericopissarra","id":6617952,"avatar_url":"https://avatars.githubusercontent.com/u/6617952?v=3","gravatar_id":"","url":"https://api.github.com/users/fredericopissarra","html_url":"https://github.com/fredericopissarra","followers_url":"https://api.github.com/users/fredericopissarra/followers","following_url":"https://api.github.com/users/fredericopissarra/following{/other_user}","gists_url":"https://api.github.com/users/fredericopissarra/gists{/gist_id}","starred_url":"https://api.github.com/users/fredericopissarra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fredericopissarra/subscriptions","organizations_url":"https://api.github.com/users/fredericopissarra/orgs","repos_url":"https://api.github.com/users/fredericopissarra/repos","events_url":"https://api.github.com/users/fredericopissarra/events{/privacy}","received_events_url":"https://api.github.com/users/fredericopissarra/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-04-17T16:23:08Z","updated_at":"2016-04-17T18:21:30Z","closed_at":null,"body":"On src/web_buffer.c I notice two routines commented as \"the fastest way possible\" (buffer_jsdate & buffer_date). Without using assembly language there is a minor enhancement which will quadruple the speed for such routines. Take a look at this small test:\r\n\r\nhttps://ghostbin.com/paste/k5fz6\r\n\r\n[]s\r\nFred"},"comment":{"url":"https://api.github.com/repos/firehol/netdata/issues/comments/211075289","html_url":"https://github.com/firehol/netdata/issues/255#issuecomment-211075289","issue_url":"https://api.github.com/repos/firehol/netdata/issues/255","id":211075289,"user":{"login":"Ubiquitous","id":483041,"avatar_url":"https://avatars.githubusercontent.com/u/483041?v=3","gravatar_id":"","url":"https://api.github.com/users/Ubiquitous","html_url":"https://github.com/Ubiquitous","followers_url":"https://api.github.com/users/Ubiquitous/followers","following_url":"https://api.github.com/users/Ubiquitous/following{/other_user}","gists_url":"https://api.github.com/users/Ubiquitous/gists{/gist_id}","starred_url":"https://api.github.com/users/Ubiquitous/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ubiquitous/subscriptions","organizations_url":"https://api.github.com/users/Ubiquitous/orgs","repos_url":"https://api.github.com/users/Ubiquitous/repos","events_url":"https://api.github.com/users/Ubiquitous/events{/privacy}","received_events_url":"https://api.github.com/users/Ubiquitous/received_events","type":"User","site_admin":false},"created_at":"2016-04-17T18:21:30Z","updated_at":"2016-04-17T18:21:30Z","body":"That is definitely faster... on line 187\r\n```\r\n p = (unsigned char *)r - 1;\r\n```\r\nconsider changing to:\r\n```\r\n p = (char *)r - 1;\r\n```\r\notherwise it converts between pointers to integer types with different sign."}}