{"action":"created","issue":{"url":"https://api.github.com/repos/Ericsson/puppet-module-cgroups/issues/7","repository_url":"https://api.github.com/repos/Ericsson/puppet-module-cgroups","labels_url":"https://api.github.com/repos/Ericsson/puppet-module-cgroups/issues/7/labels{/name}","comments_url":"https://api.github.com/repos/Ericsson/puppet-module-cgroups/issues/7/comments","events_url":"https://api.github.com/repos/Ericsson/puppet-module-cgroups/issues/7/events","html_url":"https://github.com/Ericsson/puppet-module-cgroups/pull/7","id":156479574,"number":7,"title":"Refactor of module for proposed  2.0.0 release","user":{"login":"crayfishx","id":837815,"avatar_url":"https://avatars.githubusercontent.com/u/837815?v=3","gravatar_id":"","url":"https://api.github.com/users/crayfishx","html_url":"https://github.com/crayfishx","followers_url":"https://api.github.com/users/crayfishx/followers","following_url":"https://api.github.com/users/crayfishx/following{/other_user}","gists_url":"https://api.github.com/users/crayfishx/gists{/gist_id}","starred_url":"https://api.github.com/users/crayfishx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crayfishx/subscriptions","organizations_url":"https://api.github.com/users/crayfishx/orgs","repos_url":"https://api.github.com/users/crayfishx/repos","events_url":"https://api.github.com/users/crayfishx/events{/privacy}","received_events_url":"https://api.github.com/users/crayfishx/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":17,"created_at":"2016-05-24T11:04:01Z","updated_at":"2016-05-25T14:02:51Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Ericsson/puppet-module-cgroups/pulls/7","html_url":"https://github.com/Ericsson/puppet-module-cgroups/pull/7","diff_url":"https://github.com/Ericsson/puppet-module-cgroups/pull/7.diff","patch_url":"https://github.com/Ericsson/puppet-module-cgroups/pull/7.patch"},"body":"## Description \r\nI'm currently running off this fork as I made some major changes to make groups more configurable.  It would be nice to get this merged upstream and released (as a 2.0.0) - also I note this module is not on the forge, if accepted, could you release it please?\r\n\r\n## Main changes\r\n\r\n### RHEL 7 allowed\r\nWhilst it's true that a lot of libcgroup configuration is obsolete on Redhat 7 there are still use cases for configuring stuff in cgconfig.conf/.d... namely groups therefore the fail condition for RedHat 7.0+ has been removed\r\n\r\n### cgroups::group defined resource type\r\nPreviously this module just took a blob of static data in the `cgconfig_content` parameter and dumped it into cgconfig.conf.  While the cgconfig_content parameter still exists, the aim is that this should be used just for edge cases.  A `cgconfig::group` defined type has been added to allow more structured, cleaner, handling of group definitions and they are placed in the .d directory rather than in the main config file.\r\n\r\n### mount{} configuration made optional\r\nPreviously the module would always require a cpu controller mounted in the mount {} section of cgconfig.conf.  As per above, there are very limited cases for doing this in cgconfig.conf now so this has been changed to default to not configuring this section.  An optional configuration parameter of `mounts` has been added to allow users to add mounts they require.\r\n\r\n### Internal cleanup\r\nA few things have been tweaked internally to make the module conform better to best practice, including removing the questionable 'USE_DEFAULTS' default setting in favour of undef, and changing resource titles to be the namevar rather than using a different name for the service and config file - there was no real reason to do this and it added confusion.\r\n\r\n### Other\r\n* Documentation and rspec updates to support the new/modified functionality.\r\n* Removed ruby 1.8.7 from test coverage (the world has moved on)\r\n\r\n## Detailed breakdown (from commit):\r\n\r\n* Removed failure condition for Redhat 7.0+\r\n* Added cgroups::group defined resource type\r\n* BREAK: removed 'cfconfig_mount' parameter to cgroups class\r\n* Added mounts parameter for optionally adding mount{} to config\r\n* Added groups parameter for optionally adding cgroups::group types\r\n* Changed 'USE_DEFAULTS' to better handling using undef\r\n* Use actual resource titles as namevars rather than arb names\r\n* Added 'config_d_path' parameter option\r\n* DOC: removed example code showing groups in big data blob\r\n* DOC: added documentation for the cgroups::group type\r\n* DOC: added documentation for the mounts parameter\r\n* RSPEC: modified tests for file contents (mount)\r\n* RSPEC: modified tests to look for correct service titles\r\n* RSPEC: added rspec tests for the cgroups::group define"},"comment":{"url":"https://api.github.com/repos/Ericsson/puppet-module-cgroups/issues/comments/221585825","html_url":"https://github.com/Ericsson/puppet-module-cgroups/pull/7#issuecomment-221585825","issue_url":"https://api.github.com/repos/Ericsson/puppet-module-cgroups/issues/7","id":221585825,"user":{"login":"ghoneycutt","id":313891,"avatar_url":"https://avatars.githubusercontent.com/u/313891?v=3","gravatar_id":"","url":"https://api.github.com/users/ghoneycutt","html_url":"https://github.com/ghoneycutt","followers_url":"https://api.github.com/users/ghoneycutt/followers","following_url":"https://api.github.com/users/ghoneycutt/following{/other_user}","gists_url":"https://api.github.com/users/ghoneycutt/gists{/gist_id}","starred_url":"https://api.github.com/users/ghoneycutt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghoneycutt/subscriptions","organizations_url":"https://api.github.com/users/ghoneycutt/orgs","repos_url":"https://api.github.com/users/ghoneycutt/repos","events_url":"https://api.github.com/users/ghoneycutt/events{/privacy}","received_events_url":"https://api.github.com/users/ghoneycutt/received_events","type":"User","site_admin":false},"created_at":"2016-05-25T14:02:51Z","updated_at":"2016-05-25T14:02:51Z","body":"+1 to dropping the backward compatibility by default since the old functionality is documented."}}
{"actor":{"display_login":"ghoneycutt"}}