{"action":"created","comment":{"url":"https://api.github.com/repos/ceph/ceph/pulls/comments/69766949","id":69766949,"diff_hunk":"@@ -1870,7 +1870,9 @@ bool PG::op_has_sufficient_caps(OpRequestRef& op)\n \t\t\t     op->need_read_cap(),\n \t\t\t     op->need_write_cap(),\n \t\t\t     op->need_class_read_cap(),\n-\t\t\t     op->need_class_write_cap());\n+\t\t\t     op->need_class_write_cap(),\n+\t\t\t     op->class_name(),\n+\t\t\t     op->class_whitelisted());","path":"src/osd/PG.cc","position":7,"original_position":7,"commit_id":"bfd4887de2b7d105cd4e215e84396d56c9e6eb71","original_commit_id":"bfd4887de2b7d105cd4e215e84396d56c9e6eb71","user":{"login":"noahdesu","id":242417,"avatar_url":"https://avatars.githubusercontent.com/u/242417?v=3","gravatar_id":"","url":"https://api.github.com/users/noahdesu","html_url":"https://github.com/noahdesu","followers_url":"https://api.github.com/users/noahdesu/followers","following_url":"https://api.github.com/users/noahdesu/following{/other_user}","gists_url":"https://api.github.com/users/noahdesu/gists{/gist_id}","starred_url":"https://api.github.com/users/noahdesu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noahdesu/subscriptions","organizations_url":"https://api.github.com/users/noahdesu/orgs","repos_url":"https://api.github.com/users/noahdesu/repos","events_url":"https://api.github.com/users/noahdesu/events{/privacy}","received_events_url":"https://api.github.com/users/noahdesu/received_events","type":"User","site_admin":false},"body":"Oh I had only considered the case of classes calling other classes in which case they were transitively permitted. Are you referring to using multiple ObjectOperation::exec?","created_at":"2016-07-06T16:43:49Z","updated_at":"2016-07-06T16:43:49Z","html_url":"https://github.com/ceph/ceph/pull/9972#discussion_r69766949","pull_request_url":"https://api.github.com/repos/ceph/ceph/pulls/9972","_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments/69766949"},"html":{"href":"https://github.com/ceph/ceph/pull/9972#discussion_r69766949"},"pull_request":{"href":"https://api.github.com/repos/ceph/ceph/pulls/9972"}}},"pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/9972","id":75381937,"html_url":"https://github.com/ceph/ceph/pull/9972","diff_url":"https://github.com/ceph/ceph/pull/9972.diff","patch_url":"https://github.com/ceph/ceph/pull/9972.patch","issue_url":"https://api.github.com/repos/ceph/ceph/issues/9972","number":9972,"state":"open","locked":false,"title":"osd: object class loading and execution permissions","user":{"login":"noahdesu","id":242417,"avatar_url":"https://avatars.githubusercontent.com/u/242417?v=3","gravatar_id":"","url":"https://api.github.com/users/noahdesu","html_url":"https://github.com/noahdesu","followers_url":"https://api.github.com/users/noahdesu/followers","following_url":"https://api.github.com/users/noahdesu/following{/other_user}","gists_url":"https://api.github.com/users/noahdesu/gists{/gist_id}","starred_url":"https://api.github.com/users/noahdesu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noahdesu/subscriptions","organizations_url":"https://api.github.com/users/noahdesu/orgs","repos_url":"https://api.github.com/users/noahdesu/repos","events_url":"https://api.github.com/users/noahdesu/events{/privacy}","received_events_url":"https://api.github.com/users/noahdesu/received_events","type":"User","site_admin":false},"body":"This adds options 'osd class load list' that is a list of classes allowed to be loaded (or * for all), and 'osd class default list' which is a list of classes (or * for all) that may be used without explicit permission.","created_at":"2016-06-27T21:21:22Z","updated_at":"2016-07-06T16:43:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7ff476d41018984aaa4ace9b16fd415c145a526d","assignee":{"login":"liewegas","id":433031,"avatar_url":"https://avatars.githubusercontent.com/u/433031?v=3","gravatar_id":"","url":"https://api.github.com/users/liewegas","html_url":"https://github.com/liewegas","followers_url":"https://api.github.com/users/liewegas/followers","following_url":"https://api.github.com/users/liewegas/following{/other_user}","gists_url":"https://api.github.com/users/liewegas/gists{/gist_id}","starred_url":"https://api.github.com/users/liewegas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liewegas/subscriptions","organizations_url":"https://api.github.com/users/liewegas/orgs","repos_url":"https://api.github.com/users/liewegas/repos","events_url":"https://api.github.com/users/liewegas/events{/privacy}","received_events_url":"https://api.github.com/users/liewegas/received_events","type":"User","site_admin":false},"assignees":[{"login":"liewegas","id":433031,"avatar_url":"https://avatars.githubusercontent.com/u/433031?v=3","gravatar_id":"","url":"https://api.github.com/users/liewegas","html_url":"https://github.com/liewegas","followers_url":"https://api.github.com/users/liewegas/followers","following_url":"https://api.github.com/users/liewegas/following{/other_user}","gists_url":"https://api.github.com/users/liewegas/gists{/gist_id}","starred_url":"https://api.github.com/users/liewegas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liewegas/subscriptions","organizations_url":"https://api.github.com/users/liewegas/orgs","repos_url":"https://api.github.com/users/liewegas/repos","events_url":"https://api.github.com/users/liewegas/events{/privacy}","received_events_url":"https://api.github.com/users/liewegas/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ceph/ceph/pulls/9972/commits","review_comments_url":"https://api.github.com/repos/ceph/ceph/pulls/9972/comments","review_comment_url":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/9972/comments","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/bfd4887de2b7d105cd4e215e84396d56c9e6eb71","head":{"label":"ceph:objclass-perm","ref":"objclass-perm","sha":"bfd4887de2b7d105cd4e215e84396d56c9e6eb71","user":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":2310495,"name":"ceph","full_name":"ceph/ceph","owner":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ceph/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":false,"url":"https://api.github.com/repos/ceph/ceph","forks_url":"https://api.github.com/repos/ceph/ceph/forks","keys_url":"https://api.github.com/repos/ceph/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph/teams","hooks_url":"https://api.github.com/repos/ceph/ceph/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph/events","assignees_url":"https://api.github.com/repos/ceph/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph/tags","blobs_url":"https://api.github.com/repos/ceph/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph/subscription","commits_url":"https://api.github.com/repos/ceph/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph/merges","archive_url":"https://api.github.com/repos/ceph/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph/downloads","issues_url":"https://api.github.com/repos/ceph/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/ceph/ceph/deployments","created_at":"2011-09-01T21:41:26Z","updated_at":"2016-07-06T12:17:08Z","pushed_at":"2016-07-06T15:51:02Z","git_url":"git://github.com/ceph/ceph.git","ssh_url":"git@github.com:ceph/ceph.git","clone_url":"https://github.com/ceph/ceph.git","svn_url":"https://github.com/ceph/ceph","homepage":"http://ceph.com","size":225946,"stargazers_count":2286,"watchers_count":2286,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1356,"mirror_url":null,"open_issues_count":462,"forks":1356,"open_issues":462,"watchers":2286,"default_branch":"master"}},"base":{"label":"ceph:master","ref":"master","sha":"ab869ae3fbe2050065799c2b12d5f9b9ddaacada","user":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":2310495,"name":"ceph","full_name":"ceph/ceph","owner":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ceph/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":false,"url":"https://api.github.com/repos/ceph/ceph","forks_url":"https://api.github.com/repos/ceph/ceph/forks","keys_url":"https://api.github.com/repos/ceph/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph/teams","hooks_url":"https://api.github.com/repos/ceph/ceph/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph/events","assignees_url":"https://api.github.com/repos/ceph/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph/tags","blobs_url":"https://api.github.com/repos/ceph/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph/subscription","commits_url":"https://api.github.com/repos/ceph/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph/merges","archive_url":"https://api.github.com/repos/ceph/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph/downloads","issues_url":"https://api.github.com/repos/ceph/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/ceph/ceph/deployments","created_at":"2011-09-01T21:41:26Z","updated_at":"2016-07-06T12:17:08Z","pushed_at":"2016-07-06T15:51:02Z","git_url":"git://github.com/ceph/ceph.git","ssh_url":"git@github.com:ceph/ceph.git","clone_url":"https://github.com/ceph/ceph.git","svn_url":"https://github.com/ceph/ceph","homepage":"http://ceph.com","size":225946,"stargazers_count":2286,"watchers_count":2286,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1356,"mirror_url":null,"open_issues_count":462,"forks":1356,"open_issues":462,"watchers":2286,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/9972"},"html":{"href":"https://github.com/ceph/ceph/pull/9972"},"issue":{"href":"https://api.github.com/repos/ceph/ceph/issues/9972"},"comments":{"href":"https://api.github.com/repos/ceph/ceph/issues/9972/comments"},"review_comments":{"href":"https://api.github.com/repos/ceph/ceph/pulls/9972/comments"},"review_comment":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ceph/ceph/pulls/9972/commits"},"statuses":{"href":"https://api.github.com/repos/ceph/ceph/statuses/bfd4887de2b7d105cd4e215e84396d56c9e6eb71"}}}}
{"actor":{"display_login":"noahdesu"}}