{"action":"created","comment":{"url":"https://api.github.com/repos/symengine/symengine/pulls/comments/55400852","id":55400852,"diff_hunk":"@@ -2647,6 +2661,29 @@ std::size_t LeviCivita::__hash__() const\n     return seed;\n }\n \n+RCP<const Basic> LeviCivita::subs(const map_basic_basic &subs_dict) const\n+{\n+    auto it = subs_dict.find(rcp_from_this());\n+    if (it != subs_dict.end())\n+        return it->second;\n+    vec_basic arg(arg_.size());\n+    bool this_rcp = true;\n+    auto it2 = arg.begin();\n+    for (const auto& it: arg_) {\n+        *it2 = ((it)->subs(subs_dict));\n+        if (this_rcp) {","path":"symengine/functions.cpp","position":35,"original_position":35,"commit_id":"a33bd9635b6b790d5f720b872490f50d3eeaeeaf","original_commit_id":"a33bd9635b6b790d5f720b872490f50d3eeaeeaf","user":{"login":"abhinavagarwal07","id":8086316,"avatar_url":"https://avatars.githubusercontent.com/u/8086316?v=3","gravatar_id":"","url":"https://api.github.com/users/abhinavagarwal07","html_url":"https://github.com/abhinavagarwal07","followers_url":"https://api.github.com/users/abhinavagarwal07/followers","following_url":"https://api.github.com/users/abhinavagarwal07/following{/other_user}","gists_url":"https://api.github.com/users/abhinavagarwal07/gists{/gist_id}","starred_url":"https://api.github.com/users/abhinavagarwal07/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abhinavagarwal07/subscriptions","organizations_url":"https://api.github.com/users/abhinavagarwal07/orgs","repos_url":"https://api.github.com/users/abhinavagarwal07/repos","events_url":"https://api.github.com/users/abhinavagarwal07/events{/privacy}","received_events_url":"https://api.github.com/users/abhinavagarwal07/received_events","type":"User","site_admin":false},"body":"tests fail with this\r\n```c++\r\nRCP<const Basic> LeviCivita::subs(const map_basic_basic &subs_dict) const\r\n{\r\n    auto it = subs_dict.find(rcp_from_this());\r\n    if (it != subs_dict.end())\r\n        return it->second;\r\n    bool this_rcp = true;\r\n    for (auto it: arg_) {\r\n        auto temp = ((it)->subs(subs_dict));\r\n        if (this_rcp) {\r\n            if (not eq(*temp, *it))\r\n                this_rcp = false;\r\n        }\r\n        it = temp;\r\n    }\r\n\r\n    if (this_rcp)\r\n         return rcp_from_this();\r\n    else\r\n        return levi_civita(arg_);\r\n}\r\n```","created_at":"2016-03-08T18:12:20Z","updated_at":"2016-03-08T18:12:20Z","html_url":"https://github.com/symengine/symengine/pull/836#discussion_r55400852","pull_request_url":"https://api.github.com/repos/symengine/symengine/pulls/836","_links":{"self":{"href":"https://api.github.com/repos/symengine/symengine/pulls/comments/55400852"},"html":{"href":"https://github.com/symengine/symengine/pull/836#discussion_r55400852"},"pull_request":{"href":"https://api.github.com/repos/symengine/symengine/pulls/836"}}},"pull_request":{"url":"https://api.github.com/repos/symengine/symengine/pulls/836","id":60990885,"html_url":"https://github.com/symengine/symengine/pull/836","diff_url":"https://github.com/symengine/symengine/pull/836.diff","patch_url":"https://github.com/symengine/symengine/pull/836.patch","issue_url":"https://api.github.com/repos/symengine/symengine/issues/836","number":836,"state":"open","locked":false,"title":"(WIP) Implement subs for special functions","user":{"login":"abhinavagarwal07","id":8086316,"avatar_url":"https://avatars.githubusercontent.com/u/8086316?v=3","gravatar_id":"","url":"https://api.github.com/users/abhinavagarwal07","html_url":"https://github.com/abhinavagarwal07","followers_url":"https://api.github.com/users/abhinavagarwal07/followers","following_url":"https://api.github.com/users/abhinavagarwal07/following{/other_user}","gists_url":"https://api.github.com/users/abhinavagarwal07/gists{/gist_id}","starred_url":"https://api.github.com/users/abhinavagarwal07/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abhinavagarwal07/subscriptions","organizations_url":"https://api.github.com/users/abhinavagarwal07/orgs","repos_url":"https://api.github.com/users/abhinavagarwal07/repos","events_url":"https://api.github.com/users/abhinavagarwal07/events{/privacy}","received_events_url":"https://api.github.com/users/abhinavagarwal07/received_events","type":"User","site_admin":false},"body":"- [x]  KroneckerDelta\r\n- [x]  LeviCivita\r\n- [x]  Gamma\r\n- [x]  LowerGamma\r\n- [x]  UpperGamma\r\n- [x]  Beta\r\n- [x]  PolyGamma\r\n- [ ]  Abs\r\n- [ ]  Min\r\n- [ ]  Max\r\n\r\n\r\nFixes #833","created_at":"2016-02-28T13:08:21Z","updated_at":"2016-03-08T18:12:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e413b320e490eaec13df17a89d896eff0bade5a0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/symengine/symengine/pulls/836/commits","review_comments_url":"https://api.github.com/repos/symengine/symengine/pulls/836/comments","review_comment_url":"https://api.github.com/repos/symengine/symengine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symengine/symengine/issues/836/comments","statuses_url":"https://api.github.com/repos/symengine/symengine/statuses/a33bd9635b6b790d5f720b872490f50d3eeaeeaf","head":{"label":"abhinavagarwal07:implement-subs","ref":"implement-subs","sha":"a33bd9635b6b790d5f720b872490f50d3eeaeeaf","user":{"login":"abhinavagarwal07","id":8086316,"avatar_url":"https://avatars.githubusercontent.com/u/8086316?v=3","gravatar_id":"","url":"https://api.github.com/users/abhinavagarwal07","html_url":"https://github.com/abhinavagarwal07","followers_url":"https://api.github.com/users/abhinavagarwal07/followers","following_url":"https://api.github.com/users/abhinavagarwal07/following{/other_user}","gists_url":"https://api.github.com/users/abhinavagarwal07/gists{/gist_id}","starred_url":"https://api.github.com/users/abhinavagarwal07/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abhinavagarwal07/subscriptions","organizations_url":"https://api.github.com/users/abhinavagarwal07/orgs","repos_url":"https://api.github.com/users/abhinavagarwal07/repos","events_url":"https://api.github.com/users/abhinavagarwal07/events{/privacy}","received_events_url":"https://api.github.com/users/abhinavagarwal07/received_events","type":"User","site_admin":false},"repo":{"id":52506554,"name":"symengine","full_name":"abhinavagarwal07/symengine","owner":{"login":"abhinavagarwal07","id":8086316,"avatar_url":"https://avatars.githubusercontent.com/u/8086316?v=3","gravatar_id":"","url":"https://api.github.com/users/abhinavagarwal07","html_url":"https://github.com/abhinavagarwal07","followers_url":"https://api.github.com/users/abhinavagarwal07/followers","following_url":"https://api.github.com/users/abhinavagarwal07/following{/other_user}","gists_url":"https://api.github.com/users/abhinavagarwal07/gists{/gist_id}","starred_url":"https://api.github.com/users/abhinavagarwal07/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abhinavagarwal07/subscriptions","organizations_url":"https://api.github.com/users/abhinavagarwal07/orgs","repos_url":"https://api.github.com/users/abhinavagarwal07/repos","events_url":"https://api.github.com/users/abhinavagarwal07/events{/privacy}","received_events_url":"https://api.github.com/users/abhinavagarwal07/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/abhinavagarwal07/symengine","description":"SymEngine is a fast symbolic manipulation library, written in C++","fork":true,"url":"https://api.github.com/repos/abhinavagarwal07/symengine","forks_url":"https://api.github.com/repos/abhinavagarwal07/symengine/forks","keys_url":"https://api.github.com/repos/abhinavagarwal07/symengine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/abhinavagarwal07/symengine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/abhinavagarwal07/symengine/teams","hooks_url":"https://api.github.com/repos/abhinavagarwal07/symengine/hooks","issue_events_url":"https://api.github.com/repos/abhinavagarwal07/symengine/issues/events{/number}","events_url":"https://api.github.com/repos/abhinavagarwal07/symengine/events","assignees_url":"https://api.github.com/repos/abhinavagarwal07/symengine/assignees{/user}","branches_url":"https://api.github.com/repos/abhinavagarwal07/symengine/branches{/branch}","tags_url":"https://api.github.com/repos/abhinavagarwal07/symengine/tags","blobs_url":"https://api.github.com/repos/abhinavagarwal07/symengine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/abhinavagarwal07/symengine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/abhinavagarwal07/symengine/git/refs{/sha}","trees_url":"https://api.github.com/repos/abhinavagarwal07/symengine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/abhinavagarwal07/symengine/statuses/{sha}","languages_url":"https://api.github.com/repos/abhinavagarwal07/symengine/languages","stargazers_url":"https://api.github.com/repos/abhinavagarwal07/symengine/stargazers","contributors_url":"https://api.github.com/repos/abhinavagarwal07/symengine/contributors","subscribers_url":"https://api.github.com/repos/abhinavagarwal07/symengine/subscribers","subscription_url":"https://api.github.com/repos/abhinavagarwal07/symengine/subscription","commits_url":"https://api.github.com/repos/abhinavagarwal07/symengine/commits{/sha}","git_commits_url":"https://api.github.com/repos/abhinavagarwal07/symengine/git/commits{/sha}","comments_url":"https://api.github.com/repos/abhinavagarwal07/symengine/comments{/number}","issue_comment_url":"https://api.github.com/repos/abhinavagarwal07/symengine/issues/comments{/number}","contents_url":"https://api.github.com/repos/abhinavagarwal07/symengine/contents/{+path}","compare_url":"https://api.github.com/repos/abhinavagarwal07/symengine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/abhinavagarwal07/symengine/merges","archive_url":"https://api.github.com/repos/abhinavagarwal07/symengine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/abhinavagarwal07/symengine/downloads","issues_url":"https://api.github.com/repos/abhinavagarwal07/symengine/issues{/number}","pulls_url":"https://api.github.com/repos/abhinavagarwal07/symengine/pulls{/number}","milestones_url":"https://api.github.com/repos/abhinavagarwal07/symengine/milestones{/number}","notifications_url":"https://api.github.com/repos/abhinavagarwal07/symengine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/abhinavagarwal07/symengine/labels{/name}","releases_url":"https://api.github.com/repos/abhinavagarwal07/symengine/releases{/id}","deployments_url":"https://api.github.com/repos/abhinavagarwal07/symengine/deployments","created_at":"2016-02-25T07:46:28Z","updated_at":"2016-02-25T07:46:30Z","pushed_at":"2016-03-08T17:10:17Z","git_url":"git://github.com/abhinavagarwal07/symengine.git","ssh_url":"git@github.com:abhinavagarwal07/symengine.git","clone_url":"https://github.com/abhinavagarwal07/symengine.git","svn_url":"https://github.com/abhinavagarwal07/symengine","homepage":"http://sympy.org","size":4237,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"symengine:master","ref":"master","sha":"f71dd1bfcebffce76c7f0b0e8a78b0ca3bd27e8e","user":{"login":"symengine","id":11509221,"avatar_url":"https://avatars.githubusercontent.com/u/11509221?v=3","gravatar_id":"","url":"https://api.github.com/users/symengine","html_url":"https://github.com/symengine","followers_url":"https://api.github.com/users/symengine/followers","following_url":"https://api.github.com/users/symengine/following{/other_user}","gists_url":"https://api.github.com/users/symengine/gists{/gist_id}","starred_url":"https://api.github.com/users/symengine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symengine/subscriptions","organizations_url":"https://api.github.com/users/symengine/orgs","repos_url":"https://api.github.com/users/symengine/repos","events_url":"https://api.github.com/users/symengine/events{/privacy}","received_events_url":"https://api.github.com/users/symengine/received_events","type":"Organization","site_admin":false},"repo":{"id":42376,"name":"symengine","full_name":"symengine/symengine","owner":{"login":"symengine","id":11509221,"avatar_url":"https://avatars.githubusercontent.com/u/11509221?v=3","gravatar_id":"","url":"https://api.github.com/users/symengine","html_url":"https://github.com/symengine","followers_url":"https://api.github.com/users/symengine/followers","following_url":"https://api.github.com/users/symengine/following{/other_user}","gists_url":"https://api.github.com/users/symengine/gists{/gist_id}","starred_url":"https://api.github.com/users/symengine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symengine/subscriptions","organizations_url":"https://api.github.com/users/symengine/orgs","repos_url":"https://api.github.com/users/symengine/repos","events_url":"https://api.github.com/users/symengine/events{/privacy}","received_events_url":"https://api.github.com/users/symengine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symengine/symengine","description":"SymEngine is a fast symbolic manipulation library, written in C++","fork":false,"url":"https://api.github.com/repos/symengine/symengine","forks_url":"https://api.github.com/repos/symengine/symengine/forks","keys_url":"https://api.github.com/repos/symengine/symengine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symengine/symengine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symengine/symengine/teams","hooks_url":"https://api.github.com/repos/symengine/symengine/hooks","issue_events_url":"https://api.github.com/repos/symengine/symengine/issues/events{/number}","events_url":"https://api.github.com/repos/symengine/symengine/events","assignees_url":"https://api.github.com/repos/symengine/symengine/assignees{/user}","branches_url":"https://api.github.com/repos/symengine/symengine/branches{/branch}","tags_url":"https://api.github.com/repos/symengine/symengine/tags","blobs_url":"https://api.github.com/repos/symengine/symengine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symengine/symengine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symengine/symengine/git/refs{/sha}","trees_url":"https://api.github.com/repos/symengine/symengine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symengine/symengine/statuses/{sha}","languages_url":"https://api.github.com/repos/symengine/symengine/languages","stargazers_url":"https://api.github.com/repos/symengine/symengine/stargazers","contributors_url":"https://api.github.com/repos/symengine/symengine/contributors","subscribers_url":"https://api.github.com/repos/symengine/symengine/subscribers","subscription_url":"https://api.github.com/repos/symengine/symengine/subscription","commits_url":"https://api.github.com/repos/symengine/symengine/commits{/sha}","git_commits_url":"https://api.github.com/repos/symengine/symengine/git/commits{/sha}","comments_url":"https://api.github.com/repos/symengine/symengine/comments{/number}","issue_comment_url":"https://api.github.com/repos/symengine/symengine/issues/comments{/number}","contents_url":"https://api.github.com/repos/symengine/symengine/contents/{+path}","compare_url":"https://api.github.com/repos/symengine/symengine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symengine/symengine/merges","archive_url":"https://api.github.com/repos/symengine/symengine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symengine/symengine/downloads","issues_url":"https://api.github.com/repos/symengine/symengine/issues{/number}","pulls_url":"https://api.github.com/repos/symengine/symengine/pulls{/number}","milestones_url":"https://api.github.com/repos/symengine/symengine/milestones{/number}","notifications_url":"https://api.github.com/repos/symengine/symengine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symengine/symengine/labels{/name}","releases_url":"https://api.github.com/repos/symengine/symengine/releases{/id}","deployments_url":"https://api.github.com/repos/symengine/symengine/deployments","created_at":"2008-08-13T18:40:14Z","updated_at":"2016-03-03T09:03:06Z","pushed_at":"2016-03-08T17:30:38Z","git_url":"git://github.com/symengine/symengine.git","ssh_url":"git@github.com:symengine/symengine.git","clone_url":"https://github.com/symengine/symengine.git","svn_url":"https://github.com/symengine/symengine","homepage":"http://sympy.org","size":33890,"stargazers_count":122,"watchers_count":122,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":98,"mirror_url":null,"open_issues_count":105,"forks":98,"open_issues":105,"watchers":122,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symengine/symengine/pulls/836"},"html":{"href":"https://github.com/symengine/symengine/pull/836"},"issue":{"href":"https://api.github.com/repos/symengine/symengine/issues/836"},"comments":{"href":"https://api.github.com/repos/symengine/symengine/issues/836/comments"},"review_comments":{"href":"https://api.github.com/repos/symengine/symengine/pulls/836/comments"},"review_comment":{"href":"https://api.github.com/repos/symengine/symengine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symengine/symengine/pulls/836/commits"},"statuses":{"href":"https://api.github.com/repos/symengine/symengine/statuses/a33bd9635b6b790d5f720b872490f50d3eeaeeaf"}}}}