{"action":"created","issue":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/9817","repository_url":"https://api.github.com/repos/joomla/joomla-cms","labels_url":"https://api.github.com/repos/joomla/joomla-cms/issues/9817/labels{/name}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/9817/comments","events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/9817/events","html_url":"https://github.com/joomla/joomla-cms/pull/9817","id":147152727,"number":9817,"title":"Redo Fix modal scrolling #9140 + fix for Batch","user":{"login":"JoomliC","id":2385058,"avatar_url":"https://avatars.githubusercontent.com/u/2385058?v=3","gravatar_id":"","url":"https://api.github.com/users/JoomliC","html_url":"https://github.com/JoomliC","followers_url":"https://api.github.com/users/JoomliC/followers","following_url":"https://api.github.com/users/JoomliC/following{/other_user}","gists_url":"https://api.github.com/users/JoomliC/gists{/gist_id}","starred_url":"https://api.github.com/users/JoomliC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoomliC/subscriptions","organizations_url":"https://api.github.com/users/JoomliC/orgs","repos_url":"https://api.github.com/users/JoomliC/repos","events_url":"https://api.github.com/users/JoomliC/events{/privacy}","received_events_url":"https://api.github.com/users/JoomliC/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/joomla/joomla-cms/labels/PR-staging","name":"PR-staging","color":"c7def8"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":9,"created_at":"2016-04-09T18:53:35Z","updated_at":"2016-04-10T11:18:08Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/9817","html_url":"https://github.com/joomla/joomla-cms/pull/9817","diff_url":"https://github.com/joomla/joomla-cms/pull/9817.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/9817.patch"},"body":"**Redo Fix modal scrolling** #9140 + fix for Batch\r\nThe scrolling issue on iOS is a known issue of BS2 and BS3 modals.\r\n\r\nPull Request too for **Batch overflow Issues**: #9683, #9807, #9772, #9551, #9709.\r\n\r\n\r\n#### Summary of Changes\r\n- remove css of PR #9140 previously added to fix scrolling on iOS after addition of BS modals in 3.5.0 RC (now managed by main.php layout of the BS modal).\r\n- change modal event handler to shown.bs.modal and hide.bs.modal (http://getbootstrap.com/javascript/#modals-events) to be able to check height when modal has been made visible to the user, and then apply some changes (max-height and overflow) only if window viewport height is too small for the rendered modal.\r\n- apply max-height and over-flow when needed on modal body, to allow scrolling inside a modal when on small devices.\r\n\r\n#### Testing Instructions\r\n- test on as many browsers and devices as you can (desktop, tablet, mobile, FF, IE, Chrome, Safari...)\r\n- test all modal types : User, Batch (test dropdown!), article Versions (iframe url)...\r\n- test on admin and frontend, with Isis, Protostar, and other templates...\r\nYou should be able to scroll inside and use modals on all devices.\r\n\r\nDetails on browsers, platform and devices used for testing are welcomed ;-)\r\n\r\nThanks!\r\n"},"comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments/207963843","html_url":"https://github.com/joomla/joomla-cms/pull/9817#issuecomment-207963843","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/9817","id":207963843,"user":{"login":"franz-wohlkoenig","id":8235763,"avatar_url":"https://avatars.githubusercontent.com/u/8235763?v=3","gravatar_id":"","url":"https://api.github.com/users/franz-wohlkoenig","html_url":"https://github.com/franz-wohlkoenig","followers_url":"https://api.github.com/users/franz-wohlkoenig/followers","following_url":"https://api.github.com/users/franz-wohlkoenig/following{/other_user}","gists_url":"https://api.github.com/users/franz-wohlkoenig/gists{/gist_id}","starred_url":"https://api.github.com/users/franz-wohlkoenig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/franz-wohlkoenig/subscriptions","organizations_url":"https://api.github.com/users/franz-wohlkoenig/orgs","repos_url":"https://api.github.com/users/franz-wohlkoenig/repos","events_url":"https://api.github.com/users/franz-wohlkoenig/events{/privacy}","received_events_url":"https://api.github.com/users/franz-wohlkoenig/received_events","type":"User","site_admin":false},"created_at":"2016-04-10T11:18:08Z","updated_at":"2016-04-10T11:18:08Z","body":"@brianteeman Browser-Cache is cleared. A screen recording at https://youtu.be/SxfQaw8iP14 show what happens when click on select boxes.\r\n\r\n\r\n\r\n"}}