{"action":"created","comment":{"url":"https://api.github.com/repos/theforeman/foreman/pulls/comments/49589449","id":49589449,"diff_hunk":"@@ -69,6 +70,26 @@ def datastores(opts = {})\n       end\n     end\n \n+    def storage_pods(opts = {})\n+      if opts[:storage_pod]\n+        begin\n+          dc.storage_pods.get(opts[:storage_pod])\n+        rescue RbVmomi::VIM::InvalidArgument\n+          {}\n+        end\n+      else\n+        begin\n+          name_sort(dc.storage_pods.all())\n+        rescue RbVmomi::VIM::InvalidArgument","path":"app/models/compute_resources/foreman/model/vmware.rb","position":21,"original_position":21,"commit_id":"36b25b94297f9bee717a4e8ab976d545cc1a1380","original_commit_id":"36b25b94297f9bee717a4e8ab976d545cc1a1380","user":{"login":"dLobatog","id":598891,"avatar_url":"https://avatars.githubusercontent.com/u/598891?v=3","gravatar_id":"","url":"https://api.github.com/users/dLobatog","html_url":"https://github.com/dLobatog","followers_url":"https://api.github.com/users/dLobatog/followers","following_url":"https://api.github.com/users/dLobatog/following{/other_user}","gists_url":"https://api.github.com/users/dLobatog/gists{/gist_id}","starred_url":"https://api.github.com/users/dLobatog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dLobatog/subscriptions","organizations_url":"https://api.github.com/users/dLobatog/orgs","repos_url":"https://api.github.com/users/dLobatog/repos","events_url":"https://api.github.com/users/dLobatog/events{/privacy}","received_events_url":"https://api.github.com/users/dLobatog/received_events","type":"User","site_admin":false},"body":"Kinda confused at these rescues, why does one of them return a hash & the other returns an array? I'd assume the first one would return an array containing the storage pod when you pass the option, and the second one would return an array of all storage pods.","created_at":"2016-01-13T13:31:08Z","updated_at":"2016-01-13T13:31:08Z","html_url":"https://github.com/theforeman/foreman/pull/2915#discussion_r49589449","pull_request_url":"https://api.github.com/repos/theforeman/foreman/pulls/2915","_links":{"self":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/comments/49589449"},"html":{"href":"https://github.com/theforeman/foreman/pull/2915#discussion_r49589449"},"pull_request":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/2915"}}},"pull_request":{"url":"https://api.github.com/repos/theforeman/foreman/pulls/2915","id":50825966,"html_url":"https://github.com/theforeman/foreman/pull/2915","diff_url":"https://github.com/theforeman/foreman/pull/2915.diff","patch_url":"https://github.com/theforeman/foreman/pull/2915.patch","issue_url":"https://api.github.com/repos/theforeman/foreman/issues/2915","number":2915,"state":"open","locked":false,"title":"fixes #12436 - as a user I want to deploy vSphere vms on a storage pod","user":{"login":"timogoebel","id":4107560,"avatar_url":"https://avatars.githubusercontent.com/u/4107560?v=3","gravatar_id":"","url":"https://api.github.com/users/timogoebel","html_url":"https://github.com/timogoebel","followers_url":"https://api.github.com/users/timogoebel/followers","following_url":"https://api.github.com/users/timogoebel/following{/other_user}","gists_url":"https://api.github.com/users/timogoebel/gists{/gist_id}","starred_url":"https://api.github.com/users/timogoebel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timogoebel/subscriptions","organizations_url":"https://api.github.com/users/timogoebel/orgs","repos_url":"https://api.github.com/users/timogoebel/repos","events_url":"https://api.github.com/users/timogoebel/events{/privacy}","received_events_url":"https://api.github.com/users/timogoebel/received_events","type":"User","site_admin":false},"body":"This PR implements creating and cloning a vm on a datastore cluster instead of a datastore and adds datastore clusters to the api.\r\n\r\nCreating on a datastore:\r\n![image](https://cloud.githubusercontent.com/assets/4107560/11186272/34a4d660-8c81-11e5-88ba-7ec4b2396146.png)\r\n\r\nCreating on a datastore cluster:\r\n![image](https://cloud.githubusercontent.com/assets/4107560/11186298/482c7288-8c81-11e5-80db-ef7d42630f1f.png)\r\n\r\n\r\n@brandonweeks: Mind to take a look? What do you think?","created_at":"2015-11-16T15:44:49Z","updated_at":"2016-01-13T13:31:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fefe06522ed845c15defa16d8675a45cfe20374c","assignee":{"login":"dLobatog","id":598891,"avatar_url":"https://avatars.githubusercontent.com/u/598891?v=3","gravatar_id":"","url":"https://api.github.com/users/dLobatog","html_url":"https://github.com/dLobatog","followers_url":"https://api.github.com/users/dLobatog/followers","following_url":"https://api.github.com/users/dLobatog/following{/other_user}","gists_url":"https://api.github.com/users/dLobatog/gists{/gist_id}","starred_url":"https://api.github.com/users/dLobatog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dLobatog/subscriptions","organizations_url":"https://api.github.com/users/dLobatog/orgs","repos_url":"https://api.github.com/users/dLobatog/repos","events_url":"https://api.github.com/users/dLobatog/events{/privacy}","received_events_url":"https://api.github.com/users/dLobatog/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/theforeman/foreman/pulls/2915/commits","review_comments_url":"https://api.github.com/repos/theforeman/foreman/pulls/2915/comments","review_comment_url":"https://api.github.com/repos/theforeman/foreman/pulls/comments{/number}","comments_url":"https://api.github.com/repos/theforeman/foreman/issues/2915/comments","statuses_url":"https://api.github.com/repos/theforeman/foreman/statuses/36b25b94297f9bee717a4e8ab976d545cc1a1380","head":{"label":"timogoebel:feature_vsphere_storage_pools","ref":"feature_vsphere_storage_pools","sha":"36b25b94297f9bee717a4e8ab976d545cc1a1380","user":{"login":"timogoebel","id":4107560,"avatar_url":"https://avatars.githubusercontent.com/u/4107560?v=3","gravatar_id":"","url":"https://api.github.com/users/timogoebel","html_url":"https://github.com/timogoebel","followers_url":"https://api.github.com/users/timogoebel/followers","following_url":"https://api.github.com/users/timogoebel/following{/other_user}","gists_url":"https://api.github.com/users/timogoebel/gists{/gist_id}","starred_url":"https://api.github.com/users/timogoebel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timogoebel/subscriptions","organizations_url":"https://api.github.com/users/timogoebel/orgs","repos_url":"https://api.github.com/users/timogoebel/repos","events_url":"https://api.github.com/users/timogoebel/events{/privacy}","received_events_url":"https://api.github.com/users/timogoebel/received_events","type":"User","site_admin":false},"repo":{"id":39135770,"name":"foreman","full_name":"timogoebel/foreman","owner":{"login":"timogoebel","id":4107560,"avatar_url":"https://avatars.githubusercontent.com/u/4107560?v=3","gravatar_id":"","url":"https://api.github.com/users/timogoebel","html_url":"https://github.com/timogoebel","followers_url":"https://api.github.com/users/timogoebel/followers","following_url":"https://api.github.com/users/timogoebel/following{/other_user}","gists_url":"https://api.github.com/users/timogoebel/gists{/gist_id}","starred_url":"https://api.github.com/users/timogoebel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timogoebel/subscriptions","organizations_url":"https://api.github.com/users/timogoebel/orgs","repos_url":"https://api.github.com/users/timogoebel/repos","events_url":"https://api.github.com/users/timogoebel/events{/privacy}","received_events_url":"https://api.github.com/users/timogoebel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/timogoebel/foreman","description":"an application that automates the lifecycle of servers ","fork":true,"url":"https://api.github.com/repos/timogoebel/foreman","forks_url":"https://api.github.com/repos/timogoebel/foreman/forks","keys_url":"https://api.github.com/repos/timogoebel/foreman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/timogoebel/foreman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/timogoebel/foreman/teams","hooks_url":"https://api.github.com/repos/timogoebel/foreman/hooks","issue_events_url":"https://api.github.com/repos/timogoebel/foreman/issues/events{/number}","events_url":"https://api.github.com/repos/timogoebel/foreman/events","assignees_url":"https://api.github.com/repos/timogoebel/foreman/assignees{/user}","branches_url":"https://api.github.com/repos/timogoebel/foreman/branches{/branch}","tags_url":"https://api.github.com/repos/timogoebel/foreman/tags","blobs_url":"https://api.github.com/repos/timogoebel/foreman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/timogoebel/foreman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/timogoebel/foreman/git/refs{/sha}","trees_url":"https://api.github.com/repos/timogoebel/foreman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/timogoebel/foreman/statuses/{sha}","languages_url":"https://api.github.com/repos/timogoebel/foreman/languages","stargazers_url":"https://api.github.com/repos/timogoebel/foreman/stargazers","contributors_url":"https://api.github.com/repos/timogoebel/foreman/contributors","subscribers_url":"https://api.github.com/repos/timogoebel/foreman/subscribers","subscription_url":"https://api.github.com/repos/timogoebel/foreman/subscription","commits_url":"https://api.github.com/repos/timogoebel/foreman/commits{/sha}","git_commits_url":"https://api.github.com/repos/timogoebel/foreman/git/commits{/sha}","comments_url":"https://api.github.com/repos/timogoebel/foreman/comments{/number}","issue_comment_url":"https://api.github.com/repos/timogoebel/foreman/issues/comments{/number}","contents_url":"https://api.github.com/repos/timogoebel/foreman/contents/{+path}","compare_url":"https://api.github.com/repos/timogoebel/foreman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/timogoebel/foreman/merges","archive_url":"https://api.github.com/repos/timogoebel/foreman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/timogoebel/foreman/downloads","issues_url":"https://api.github.com/repos/timogoebel/foreman/issues{/number}","pulls_url":"https://api.github.com/repos/timogoebel/foreman/pulls{/number}","milestones_url":"https://api.github.com/repos/timogoebel/foreman/milestones{/number}","notifications_url":"https://api.github.com/repos/timogoebel/foreman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/timogoebel/foreman/labels{/name}","releases_url":"https://api.github.com/repos/timogoebel/foreman/releases{/id}","created_at":"2015-07-15T12:33:09Z","updated_at":"2015-07-15T12:33:14Z","pushed_at":"2016-01-12T14:04:15Z","git_url":"git://github.com/timogoebel/foreman.git","ssh_url":"git@github.com:timogoebel/foreman.git","clone_url":"https://github.com/timogoebel/foreman.git","svn_url":"https://github.com/timogoebel/foreman","homepage":"http://theforeman.org","size":38179,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"theforeman:develop","ref":"develop","sha":"24f70e14f1da00760b46ce2377db1147d849cf73","user":{"login":"theforeman","id":1439844,"avatar_url":"https://avatars.githubusercontent.com/u/1439844?v=3","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"repo":{"id":258750,"name":"foreman","full_name":"theforeman/foreman","owner":{"login":"theforeman","id":1439844,"avatar_url":"https://avatars.githubusercontent.com/u/1439844?v=3","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/theforeman/foreman","description":"an application that automates the lifecycle of servers ","fork":false,"url":"https://api.github.com/repos/theforeman/foreman","forks_url":"https://api.github.com/repos/theforeman/foreman/forks","keys_url":"https://api.github.com/repos/theforeman/foreman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theforeman/foreman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theforeman/foreman/teams","hooks_url":"https://api.github.com/repos/theforeman/foreman/hooks","issue_events_url":"https://api.github.com/repos/theforeman/foreman/issues/events{/number}","events_url":"https://api.github.com/repos/theforeman/foreman/events","assignees_url":"https://api.github.com/repos/theforeman/foreman/assignees{/user}","branches_url":"https://api.github.com/repos/theforeman/foreman/branches{/branch}","tags_url":"https://api.github.com/repos/theforeman/foreman/tags","blobs_url":"https://api.github.com/repos/theforeman/foreman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theforeman/foreman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theforeman/foreman/git/refs{/sha}","trees_url":"https://api.github.com/repos/theforeman/foreman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theforeman/foreman/statuses/{sha}","languages_url":"https://api.github.com/repos/theforeman/foreman/languages","stargazers_url":"https://api.github.com/repos/theforeman/foreman/stargazers","contributors_url":"https://api.github.com/repos/theforeman/foreman/contributors","subscribers_url":"https://api.github.com/repos/theforeman/foreman/subscribers","subscription_url":"https://api.github.com/repos/theforeman/foreman/subscription","commits_url":"https://api.github.com/repos/theforeman/foreman/commits{/sha}","git_commits_url":"https://api.github.com/repos/theforeman/foreman/git/commits{/sha}","comments_url":"https://api.github.com/repos/theforeman/foreman/comments{/number}","issue_comment_url":"https://api.github.com/repos/theforeman/foreman/issues/comments{/number}","contents_url":"https://api.github.com/repos/theforeman/foreman/contents/{+path}","compare_url":"https://api.github.com/repos/theforeman/foreman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theforeman/foreman/merges","archive_url":"https://api.github.com/repos/theforeman/foreman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theforeman/foreman/downloads","issues_url":"https://api.github.com/repos/theforeman/foreman/issues{/number}","pulls_url":"https://api.github.com/repos/theforeman/foreman/pulls{/number}","milestones_url":"https://api.github.com/repos/theforeman/foreman/milestones{/number}","notifications_url":"https://api.github.com/repos/theforeman/foreman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theforeman/foreman/labels{/name}","releases_url":"https://api.github.com/repos/theforeman/foreman/releases{/id}","created_at":"2009-07-23T15:07:00Z","updated_at":"2016-01-13T07:37:15Z","pushed_at":"2016-01-13T13:22:22Z","git_url":"git://github.com/theforeman/foreman.git","ssh_url":"git@github.com:theforeman/foreman.git","clone_url":"https://github.com/theforeman/foreman.git","svn_url":"https://github.com/theforeman/foreman","homepage":"http://theforeman.org","size":55296,"stargazers_count":924,"watchers_count":924,"language":"Ruby","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":463,"mirror_url":null,"open_issues_count":86,"forks":463,"open_issues":86,"watchers":924,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/2915"},"html":{"href":"https://github.com/theforeman/foreman/pull/2915"},"issue":{"href":"https://api.github.com/repos/theforeman/foreman/issues/2915"},"comments":{"href":"https://api.github.com/repos/theforeman/foreman/issues/2915/comments"},"review_comments":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/2915/comments"},"review_comment":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/2915/commits"},"statuses":{"href":"https://api.github.com/repos/theforeman/foreman/statuses/36b25b94297f9bee717a4e8ab976d545cc1a1380"}}}}