{"action":"created","issue":{"url":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/issues/109","repository_url":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity","labels_url":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/issues/109/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/issues/109/comments","events_url":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/issues/109/events","html_url":"https://github.com/Microsoft/HoloToolkit-Unity/pull/109","id":164808638,"number":109,"title":"Add UnityEvent support (also some ManualCameraControl fixes)","user":{"login":"stbertou","id":19978490,"avatar_url":"https://avatars.githubusercontent.com/u/19978490?v=3","gravatar_id":"","url":"https://api.github.com/users/stbertou","html_url":"https://github.com/stbertou","followers_url":"https://api.github.com/users/stbertou/followers","following_url":"https://api.github.com/users/stbertou/following{/other_user}","gists_url":"https://api.github.com/users/stbertou/gists{/gist_id}","starred_url":"https://api.github.com/users/stbertou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stbertou/subscriptions","organizations_url":"https://api.github.com/users/stbertou/orgs","repos_url":"https://api.github.com/users/stbertou/repos","events_url":"https://api.github.com/users/stbertou/events{/privacy}","received_events_url":"https://api.github.com/users/stbertou/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/labels/cla-already-signed","name":"cla-already-signed","color":"009800"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2016-07-11T10:43:06Z","updated_at":"2016-07-12T16:29:24Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/pulls/109","html_url":"https://github.com/Microsoft/HoloToolkit-Unity/pull/109","diff_url":"https://github.com/Microsoft/HoloToolkit-Unity/pull/109.diff","patch_url":"https://github.com/Microsoft/HoloToolkit-Unity/pull/109.patch"},"body":"PR for https://github.com/Microsoft/HoloToolkit-Unity/issues/107\r\n\r\nAdded OnSelect and OnGazeEnter/Leave unity events hook    \r\n\r\nVarious fixes to ManualCameraControl :\r\n- no need to check for GetKeyDir up/down AND GetAxis horizontal/vertical\r\n- moved new walk code where it's supposed to be\r\n- exposed fast control key (instead of always using left shit)\r\n- also commented an annoying debug statement\r\n \r\n"},"comment":{"url":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/issues/comments/232100937","html_url":"https://github.com/Microsoft/HoloToolkit-Unity/pull/109#issuecomment-232100937","issue_url":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/issues/109","id":232100937,"user":{"login":"jbienzms","id":5230670,"avatar_url":"https://avatars.githubusercontent.com/u/5230670?v=3","gravatar_id":"","url":"https://api.github.com/users/jbienzms","html_url":"https://github.com/jbienzms","followers_url":"https://api.github.com/users/jbienzms/followers","following_url":"https://api.github.com/users/jbienzms/following{/other_user}","gists_url":"https://api.github.com/users/jbienzms/gists{/gist_id}","starred_url":"https://api.github.com/users/jbienzms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbienzms/subscriptions","organizations_url":"https://api.github.com/users/jbienzms/orgs","repos_url":"https://api.github.com/users/jbienzms/repos","events_url":"https://api.github.com/users/jbienzms/events{/privacy}","received_events_url":"https://api.github.com/users/jbienzms/received_events","type":"User","site_admin":false},"created_at":"2016-07-12T16:27:42Z","updated_at":"2016-07-12T16:29:24Z","body":"These changes look good to me. I personally would prefer to have the ManualCameraControl changes submitted in a separate pull request but I'm not the final decision maker (I just volunteer with code reviews).\r\n\r\nFor the sake of argument, is there a reason to keep these behaviours each in their own separate classes? Meaning, couldn't OnSelect, OnEnter and OnLeave all be part of one behaviour? I understand that would mean that you couldn't disable one event without disabling the others, but I'm wondering how useful of a scenario that is to be able to control input at that level. I feel like most scenarios that want gaze input are probably going to want more than one and though they can add each individual behaviour it starts to clutter up the inspector area. Conversely, just because an event is there doesn't mean it has to be used.\r\n\r\nThis is just a suggestion / something to ponder. Would love to hear your thoughts on it."}}
{"actor":{"display_login":"jbienzms"}}