{"action":"closed","number":2020,"pull_request":{"url":"https://api.github.com/repos/django-oscar/django-oscar/pulls/2020","id":63859788,"html_url":"https://github.com/django-oscar/django-oscar/pull/2020","diff_url":"https://github.com/django-oscar/django-oscar/pull/2020.diff","patch_url":"https://github.com/django-oscar/django-oscar/pull/2020.patch","issue_url":"https://api.github.com/repos/django-oscar/django-oscar/issues/2020","number":2020,"state":"closed","locked":false,"title":"Proposal: show 404 pages for inactive offers","user":{"login":"vdboor","id":200303,"avatar_url":"https://avatars.githubusercontent.com/u/200303?v=3","gravatar_id":"","url":"https://api.github.com/users/vdboor","html_url":"https://github.com/vdboor","followers_url":"https://api.github.com/users/vdboor/followers","following_url":"https://api.github.com/users/vdboor/following{/other_user}","gists_url":"https://api.github.com/users/vdboor/gists{/gist_id}","starred_url":"https://api.github.com/users/vdboor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdboor/subscriptions","organizations_url":"https://api.github.com/users/vdboor/orgs","repos_url":"https://api.github.com/users/vdboor/repos","events_url":"https://api.github.com/users/vdboor/events{/privacy}","received_events_url":"https://api.github.com/users/vdboor/received_events","type":"User","site_admin":false},"body":"Offers that are suspended are not visible in the list view, but will still be shown as detail page.\r\nI wonder whether this is intended, or accidentally.\r\n\r\nOne of my clients requested to hide such pages (as I've done in the project code).\r\n\r\nWith this PR I'd hope to receive feedback on whether this should be the default, or not.","created_at":"2016-03-23T10:27:06Z","updated_at":"2016-08-01T20:52:39Z","closed_at":"2016-08-01T20:52:39Z","merged_at":"2016-08-01T20:52:39Z","merge_commit_sha":"3e3dafb2653f5304d68234f83e0dd6c3bf70b711","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/django-oscar/django-oscar/pulls/2020/commits","review_comments_url":"https://api.github.com/repos/django-oscar/django-oscar/pulls/2020/comments","review_comment_url":"https://api.github.com/repos/django-oscar/django-oscar/pulls/comments{/number}","comments_url":"https://api.github.com/repos/django-oscar/django-oscar/issues/2020/comments","statuses_url":"https://api.github.com/repos/django-oscar/django-oscar/statuses/a4923fd32ddd1b4dd9be10df3f24cf82493210d4","head":{"label":"edoburu:fix/offer-detail","ref":"fix/offer-detail","sha":"a4923fd32ddd1b4dd9be10df3f24cf82493210d4","user":{"login":"edoburu","id":738973,"avatar_url":"https://avatars.githubusercontent.com/u/738973?v=3","gravatar_id":"","url":"https://api.github.com/users/edoburu","html_url":"https://github.com/edoburu","followers_url":"https://api.github.com/users/edoburu/followers","following_url":"https://api.github.com/users/edoburu/following{/other_user}","gists_url":"https://api.github.com/users/edoburu/gists{/gist_id}","starred_url":"https://api.github.com/users/edoburu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edoburu/subscriptions","organizations_url":"https://api.github.com/users/edoburu/orgs","repos_url":"https://api.github.com/users/edoburu/repos","events_url":"https://api.github.com/users/edoburu/events{/privacy}","received_events_url":"https://api.github.com/users/edoburu/received_events","type":"Organization","site_admin":false},"repo":{"id":46723842,"name":"django-oscar","full_name":"edoburu/django-oscar","owner":{"login":"edoburu","id":738973,"avatar_url":"https://avatars.githubusercontent.com/u/738973?v=3","gravatar_id":"","url":"https://api.github.com/users/edoburu","html_url":"https://github.com/edoburu","followers_url":"https://api.github.com/users/edoburu/followers","following_url":"https://api.github.com/users/edoburu/following{/other_user}","gists_url":"https://api.github.com/users/edoburu/gists{/gist_id}","starred_url":"https://api.github.com/users/edoburu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edoburu/subscriptions","organizations_url":"https://api.github.com/users/edoburu/orgs","repos_url":"https://api.github.com/users/edoburu/repos","events_url":"https://api.github.com/users/edoburu/events{/privacy}","received_events_url":"https://api.github.com/users/edoburu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edoburu/django-oscar","description":"Domain-driven e-commerce for Django","fork":true,"url":"https://api.github.com/repos/edoburu/django-oscar","forks_url":"https://api.github.com/repos/edoburu/django-oscar/forks","keys_url":"https://api.github.com/repos/edoburu/django-oscar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edoburu/django-oscar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edoburu/django-oscar/teams","hooks_url":"https://api.github.com/repos/edoburu/django-oscar/hooks","issue_events_url":"https://api.github.com/repos/edoburu/django-oscar/issues/events{/number}","events_url":"https://api.github.com/repos/edoburu/django-oscar/events","assignees_url":"https://api.github.com/repos/edoburu/django-oscar/assignees{/user}","branches_url":"https://api.github.com/repos/edoburu/django-oscar/branches{/branch}","tags_url":"https://api.github.com/repos/edoburu/django-oscar/tags","blobs_url":"https://api.github.com/repos/edoburu/django-oscar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edoburu/django-oscar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edoburu/django-oscar/git/refs{/sha}","trees_url":"https://api.github.com/repos/edoburu/django-oscar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edoburu/django-oscar/statuses/{sha}","languages_url":"https://api.github.com/repos/edoburu/django-oscar/languages","stargazers_url":"https://api.github.com/repos/edoburu/django-oscar/stargazers","contributors_url":"https://api.github.com/repos/edoburu/django-oscar/contributors","subscribers_url":"https://api.github.com/repos/edoburu/django-oscar/subscribers","subscription_url":"https://api.github.com/repos/edoburu/django-oscar/subscription","commits_url":"https://api.github.com/repos/edoburu/django-oscar/commits{/sha}","git_commits_url":"https://api.github.com/repos/edoburu/django-oscar/git/commits{/sha}","comments_url":"https://api.github.com/repos/edoburu/django-oscar/comments{/number}","issue_comment_url":"https://api.github.com/repos/edoburu/django-oscar/issues/comments{/number}","contents_url":"https://api.github.com/repos/edoburu/django-oscar/contents/{+path}","compare_url":"https://api.github.com/repos/edoburu/django-oscar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edoburu/django-oscar/merges","archive_url":"https://api.github.com/repos/edoburu/django-oscar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edoburu/django-oscar/downloads","issues_url":"https://api.github.com/repos/edoburu/django-oscar/issues{/number}","pulls_url":"https://api.github.com/repos/edoburu/django-oscar/pulls{/number}","milestones_url":"https://api.github.com/repos/edoburu/django-oscar/milestones{/number}","notifications_url":"https://api.github.com/repos/edoburu/django-oscar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edoburu/django-oscar/labels{/name}","releases_url":"https://api.github.com/repos/edoburu/django-oscar/releases{/id}","deployments_url":"https://api.github.com/repos/edoburu/django-oscar/deployments","created_at":"2015-11-23T13:59:14Z","updated_at":"2016-03-23T10:28:20Z","pushed_at":"2016-03-23T10:28:12Z","git_url":"git://github.com/edoburu/django-oscar.git","ssh_url":"git@github.com:edoburu/django-oscar.git","clone_url":"https://github.com/edoburu/django-oscar.git","svn_url":"https://github.com/edoburu/django-oscar","homepage":"http://oscarcommerce.com","size":83910,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"django-oscar:master","ref":"master","sha":"68367ee742d0bd115a1849d2cc6ab6c6e6415334","user":{"login":"django-oscar","id":9057806,"avatar_url":"https://avatars.githubusercontent.com/u/9057806?v=3","gravatar_id":"","url":"https://api.github.com/users/django-oscar","html_url":"https://github.com/django-oscar","followers_url":"https://api.github.com/users/django-oscar/followers","following_url":"https://api.github.com/users/django-oscar/following{/other_user}","gists_url":"https://api.github.com/users/django-oscar/gists{/gist_id}","starred_url":"https://api.github.com/users/django-oscar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/django-oscar/subscriptions","organizations_url":"https://api.github.com/users/django-oscar/orgs","repos_url":"https://api.github.com/users/django-oscar/repos","events_url":"https://api.github.com/users/django-oscar/events{/privacy}","received_events_url":"https://api.github.com/users/django-oscar/received_events","type":"Organization","site_admin":false},"repo":{"id":1151051,"name":"django-oscar","full_name":"django-oscar/django-oscar","owner":{"login":"django-oscar","id":9057806,"avatar_url":"https://avatars.githubusercontent.com/u/9057806?v=3","gravatar_id":"","url":"https://api.github.com/users/django-oscar","html_url":"https://github.com/django-oscar","followers_url":"https://api.github.com/users/django-oscar/followers","following_url":"https://api.github.com/users/django-oscar/following{/other_user}","gists_url":"https://api.github.com/users/django-oscar/gists{/gist_id}","starred_url":"https://api.github.com/users/django-oscar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/django-oscar/subscriptions","organizations_url":"https://api.github.com/users/django-oscar/orgs","repos_url":"https://api.github.com/users/django-oscar/repos","events_url":"https://api.github.com/users/django-oscar/events{/privacy}","received_events_url":"https://api.github.com/users/django-oscar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/django-oscar/django-oscar","description":"Domain-driven e-commerce for Django","fork":false,"url":"https://api.github.com/repos/django-oscar/django-oscar","forks_url":"https://api.github.com/repos/django-oscar/django-oscar/forks","keys_url":"https://api.github.com/repos/django-oscar/django-oscar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/django-oscar/django-oscar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/django-oscar/django-oscar/teams","hooks_url":"https://api.github.com/repos/django-oscar/django-oscar/hooks","issue_events_url":"https://api.github.com/repos/django-oscar/django-oscar/issues/events{/number}","events_url":"https://api.github.com/repos/django-oscar/django-oscar/events","assignees_url":"https://api.github.com/repos/django-oscar/django-oscar/assignees{/user}","branches_url":"https://api.github.com/repos/django-oscar/django-oscar/branches{/branch}","tags_url":"https://api.github.com/repos/django-oscar/django-oscar/tags","blobs_url":"https://api.github.com/repos/django-oscar/django-oscar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/django-oscar/django-oscar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/django-oscar/django-oscar/git/refs{/sha}","trees_url":"https://api.github.com/repos/django-oscar/django-oscar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/django-oscar/django-oscar/statuses/{sha}","languages_url":"https://api.github.com/repos/django-oscar/django-oscar/languages","stargazers_url":"https://api.github.com/repos/django-oscar/django-oscar/stargazers","contributors_url":"https://api.github.com/repos/django-oscar/django-oscar/contributors","subscribers_url":"https://api.github.com/repos/django-oscar/django-oscar/subscribers","subscription_url":"https://api.github.com/repos/django-oscar/django-oscar/subscription","commits_url":"https://api.github.com/repos/django-oscar/django-oscar/commits{/sha}","git_commits_url":"https://api.github.com/repos/django-oscar/django-oscar/git/commits{/sha}","comments_url":"https://api.github.com/repos/django-oscar/django-oscar/comments{/number}","issue_comment_url":"https://api.github.com/repos/django-oscar/django-oscar/issues/comments{/number}","contents_url":"https://api.github.com/repos/django-oscar/django-oscar/contents/{+path}","compare_url":"https://api.github.com/repos/django-oscar/django-oscar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/django-oscar/django-oscar/merges","archive_url":"https://api.github.com/repos/django-oscar/django-oscar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/django-oscar/django-oscar/downloads","issues_url":"https://api.github.com/repos/django-oscar/django-oscar/issues{/number}","pulls_url":"https://api.github.com/repos/django-oscar/django-oscar/pulls{/number}","milestones_url":"https://api.github.com/repos/django-oscar/django-oscar/milestones{/number}","notifications_url":"https://api.github.com/repos/django-oscar/django-oscar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/django-oscar/django-oscar/labels{/name}","releases_url":"https://api.github.com/repos/django-oscar/django-oscar/releases{/id}","deployments_url":"https://api.github.com/repos/django-oscar/django-oscar/deployments","created_at":"2010-12-08T21:30:32Z","updated_at":"2016-08-01T20:37:53Z","pushed_at":"2016-08-01T20:52:39Z","git_url":"git://github.com/django-oscar/django-oscar.git","ssh_url":"git@github.com:django-oscar/django-oscar.git","clone_url":"https://github.com/django-oscar/django-oscar.git","svn_url":"https://github.com/django-oscar/django-oscar","homepage":"http://oscarcommerce.com","size":100387,"stargazers_count":2096,"watchers_count":2096,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":848,"mirror_url":null,"open_issues_count":259,"forks":848,"open_issues":259,"watchers":2096,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/django-oscar/django-oscar/pulls/2020"},"html":{"href":"https://github.com/django-oscar/django-oscar/pull/2020"},"issue":{"href":"https://api.github.com/repos/django-oscar/django-oscar/issues/2020"},"comments":{"href":"https://api.github.com/repos/django-oscar/django-oscar/issues/2020/comments"},"review_comments":{"href":"https://api.github.com/repos/django-oscar/django-oscar/pulls/2020/comments"},"review_comment":{"href":"https://api.github.com/repos/django-oscar/django-oscar/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/django-oscar/django-oscar/pulls/2020/commits"},"statuses":{"href":"https://api.github.com/repos/django-oscar/django-oscar/statuses/a4923fd32ddd1b4dd9be10df3f24cf82493210d4"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"mvantellingen","id":245297,"avatar_url":"https://avatars.githubusercontent.com/u/245297?v=3","gravatar_id":"","url":"https://api.github.com/users/mvantellingen","html_url":"https://github.com/mvantellingen","followers_url":"https://api.github.com/users/mvantellingen/followers","following_url":"https://api.github.com/users/mvantellingen/following{/other_user}","gists_url":"https://api.github.com/users/mvantellingen/gists{/gist_id}","starred_url":"https://api.github.com/users/mvantellingen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mvantellingen/subscriptions","organizations_url":"https://api.github.com/users/mvantellingen/orgs","repos_url":"https://api.github.com/users/mvantellingen/repos","events_url":"https://api.github.com/users/mvantellingen/events{/privacy}","received_events_url":"https://api.github.com/users/mvantellingen/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"mvantellingen"}}