{"action":"created","comment":{"url":"https://api.github.com/repos/krakenjs/generator-swaggerize/pulls/comments/70533889","id":70533889,"diff_hunk":"@@ -55,11 +55,5 @@\n     \"swagger-parser\": \"^3.4.1\",\n     \"underscore.string\": \"^3.3.4\",\n     \"yeoman-generator\": \"^0.21.2\"\n-  },\n-  \"files\": [\n-    \"generators/app\",\n-    \"generators/data\",\n-    \"generators/handler\",\n-    \"generators/test\"\n-  ]\n+  }","path":"package.json","position":19,"original_position":19,"commit_id":"f63977cadd728e2da28426c09dbc11579389e6d2","original_commit_id":"f63977cadd728e2da28426c09dbc11579389e6d2","user":{"login":"subeeshcbabu","id":1707119,"avatar_url":"https://avatars.githubusercontent.com/u/1707119?v=3","gravatar_id":"","url":"https://api.github.com/users/subeeshcbabu","html_url":"https://github.com/subeeshcbabu","followers_url":"https://api.github.com/users/subeeshcbabu/followers","following_url":"https://api.github.com/users/subeeshcbabu/following{/other_user}","gists_url":"https://api.github.com/users/subeeshcbabu/gists{/gist_id}","starred_url":"https://api.github.com/users/subeeshcbabu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/subeeshcbabu/subscriptions","organizations_url":"https://api.github.com/users/subeeshcbabu/orgs","repos_url":"https://api.github.com/users/subeeshcbabu/repos","events_url":"https://api.github.com/users/subeeshcbabu/events{/privacy}","received_events_url":"https://api.github.com/users/subeeshcbabu/received_events","type":"User","site_admin":false},"body":"`files` is an alternative approach to `.npmignore`; instead of the exclude pattern, `files` uses include pattern. Started the work on this generator version from the yeoman standards and they had `files` defined, so I ended up using that. However, it will be difficult to maintain this include pattern, every time you make changes to the project, so went ahead with the ignore pattern.","created_at":"2016-07-12T22:25:34Z","updated_at":"2016-07-12T22:25:34Z","html_url":"https://github.com/krakenjs/generator-swaggerize/pull/86#discussion_r70533889","pull_request_url":"https://api.github.com/repos/krakenjs/generator-swaggerize/pulls/86","_links":{"self":{"href":"https://api.github.com/repos/krakenjs/generator-swaggerize/pulls/comments/70533889"},"html":{"href":"https://github.com/krakenjs/generator-swaggerize/pull/86#discussion_r70533889"},"pull_request":{"href":"https://api.github.com/repos/krakenjs/generator-swaggerize/pulls/86"}}},"pull_request":{"url":"https://api.github.com/repos/krakenjs/generator-swaggerize/pulls/86","id":76832357,"html_url":"https://github.com/krakenjs/generator-swaggerize/pull/86","diff_url":"https://github.com/krakenjs/generator-swaggerize/pull/86.diff","patch_url":"https://github.com/krakenjs/generator-swaggerize/pull/86.patch","issue_url":"https://api.github.com/repos/krakenjs/generator-swaggerize/issues/86","number":86,"state":"open","locked":false,"title":"Unit test - send data for all the methods with body param","user":{"login":"subeeshcbabu","id":1707119,"avatar_url":"https://avatars.githubusercontent.com/u/1707119?v=3","gravatar_id":"","url":"https://api.github.com/users/subeeshcbabu","html_url":"https://github.com/subeeshcbabu","followers_url":"https://api.github.com/users/subeeshcbabu/followers","following_url":"https://api.github.com/users/subeeshcbabu/following{/other_user}","gists_url":"https://api.github.com/users/subeeshcbabu/gists{/gist_id}","starred_url":"https://api.github.com/users/subeeshcbabu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/subeeshcbabu/subscriptions","organizations_url":"https://api.github.com/users/subeeshcbabu/orgs","repos_url":"https://api.github.com/users/subeeshcbabu/repos","events_url":"https://api.github.com/users/subeeshcbabu/events{/privacy}","received_events_url":"https://api.github.com/users/subeeshcbabu/received_events","type":"User","site_admin":false},"body":"- Send data for all the methods with body param (not just `post` and `put`). Operations like `patch` and `delete` also could define `body` parameter.\r\n\r\n- Get rid off the `files` from `package.json` because the project has `.npmignore` to control the file list.","created_at":"2016-07-09T00:50:29Z","updated_at":"2016-07-12T22:25:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"77d6518a42d587f82bb12cf9fa903502e2c53858","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/krakenjs/generator-swaggerize/pulls/86/commits","review_comments_url":"https://api.github.com/repos/krakenjs/generator-swaggerize/pulls/86/comments","review_comment_url":"https://api.github.com/repos/krakenjs/generator-swaggerize/pulls/comments{/number}","comments_url":"https://api.github.com/repos/krakenjs/generator-swaggerize/issues/86/comments","statuses_url":"https://api.github.com/repos/krakenjs/generator-swaggerize/statuses/f63977cadd728e2da28426c09dbc11579389e6d2","head":{"label":"subeeshcbabu:bugfix3.0.0","ref":"bugfix3.0.0","sha":"f63977cadd728e2da28426c09dbc11579389e6d2","user":{"login":"subeeshcbabu","id":1707119,"avatar_url":"https://avatars.githubusercontent.com/u/1707119?v=3","gravatar_id":"","url":"https://api.github.com/users/subeeshcbabu","html_url":"https://github.com/subeeshcbabu","followers_url":"https://api.github.com/users/subeeshcbabu/followers","following_url":"https://api.github.com/users/subeeshcbabu/following{/other_user}","gists_url":"https://api.github.com/users/subeeshcbabu/gists{/gist_id}","starred_url":"https://api.github.com/users/subeeshcbabu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/subeeshcbabu/subscriptions","organizations_url":"https://api.github.com/users/subeeshcbabu/orgs","repos_url":"https://api.github.com/users/subeeshcbabu/repos","events_url":"https://api.github.com/users/subeeshcbabu/events{/privacy}","received_events_url":"https://api.github.com/users/subeeshcbabu/received_events","type":"User","site_admin":false},"repo":{"id":39051200,"name":"generator-swaggerize","full_name":"subeeshcbabu/generator-swaggerize","owner":{"login":"subeeshcbabu","id":1707119,"avatar_url":"https://avatars.githubusercontent.com/u/1707119?v=3","gravatar_id":"","url":"https://api.github.com/users/subeeshcbabu","html_url":"https://github.com/subeeshcbabu","followers_url":"https://api.github.com/users/subeeshcbabu/followers","following_url":"https://api.github.com/users/subeeshcbabu/following{/other_user}","gists_url":"https://api.github.com/users/subeeshcbabu/gists{/gist_id}","starred_url":"https://api.github.com/users/subeeshcbabu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/subeeshcbabu/subscriptions","organizations_url":"https://api.github.com/users/subeeshcbabu/orgs","repos_url":"https://api.github.com/users/subeeshcbabu/repos","events_url":"https://api.github.com/users/subeeshcbabu/events{/privacy}","received_events_url":"https://api.github.com/users/subeeshcbabu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/subeeshcbabu/generator-swaggerize","description":"Yeoman generator for design-driven apis with swagger 2.0 and krakenjs/swaggerize tools.","fork":true,"url":"https://api.github.com/repos/subeeshcbabu/generator-swaggerize","forks_url":"https://api.github.com/repos/subeeshcbabu/generator-swaggerize/forks","keys_url":"https://api.github.com/repos/subeeshcbabu/generator-swaggerize/keys{/key_id}","collaborators_url":"https://api.github.com/repos/subeeshcbabu/generator-swaggerize/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/subeeshcbabu/generator-swaggerize/teams","hooks_url":"https://api.github.com/repos/subeeshcbabu/generator-swaggerize/hooks","issue_events_url":"https://api.github.com/repos/subeeshcbabu/generator-swaggerize/issues/events{/number}","events_url":"https://api.github.com/repos/subeeshcbabu/generator-swaggerize/events","assignees_url":"https://api.github.com/repos/subeeshcbabu/generator-swaggerize/assignees{/user}","branches_url":"https://api.github.com/repos/subeeshcbabu/generator-swaggerize/branches{/branch}","tags_url":"https://api.github.com/repos/subeeshcbabu/generator-swaggerize/tags","blobs_url":"https://api.github.com/repos/subeeshcbabu/generator-swaggerize/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/subeeshcbabu/generator-swaggerize/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/subeeshcbabu/generator-swaggerize/git/refs{/sha}","trees_url":"https://api.github.com/repos/subeeshcbabu/generator-swaggerize/git/trees{/sha}","statuses_url":"https://api.github.com/repos/subeeshcbabu/generator-swaggerize/statuses/{sha}","languages_url":"https://api.github.com/repos/subeeshcbabu/generator-swaggerize/languages","stargazers_url":"https://api.github.com/repos/subeeshcbabu/generator-swaggerize/stargazers","contributors_url":"https://api.github.com/repos/subeeshcbabu/generator-swaggerize/contributors","subscribers_url":"https://api.github.com/repos/subeeshcbabu/generator-swaggerize/subscribers","subscription_url":"https://api.github.com/repos/subeeshcbabu/generator-swaggerize/subscription","commits_url":"https://api.github.com/repos/subeeshcbabu/generator-swaggerize/commits{/sha}","git_commits_url":"https://api.github.com/repos/subeeshcbabu/generator-swaggerize/git/commits{/sha}","comments_url":"https://api.github.com/repos/subeeshcbabu/generator-swaggerize/comments{/number}","issue_comment_url":"https://api.github.com/repos/subeeshcbabu/generator-swaggerize/issues/comments{/number}","contents_url":"https://api.github.com/repos/subeeshcbabu/generator-swaggerize/contents/{+path}","compare_url":"https://api.github.com/repos/subeeshcbabu/generator-swaggerize/compare/{base}...{head}","merges_url":"https://api.github.com/repos/subeeshcbabu/generator-swaggerize/merges","archive_url":"https://api.github.com/repos/subeeshcbabu/generator-swaggerize/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/subeeshcbabu/generator-swaggerize/downloads","issues_url":"https://api.github.com/repos/subeeshcbabu/generator-swaggerize/issues{/number}","pulls_url":"https://api.github.com/repos/subeeshcbabu/generator-swaggerize/pulls{/number}","milestones_url":"https://api.github.com/repos/subeeshcbabu/generator-swaggerize/milestones{/number}","notifications_url":"https://api.github.com/repos/subeeshcbabu/generator-swaggerize/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/subeeshcbabu/generator-swaggerize/labels{/name}","releases_url":"https://api.github.com/repos/subeeshcbabu/generator-swaggerize/releases{/id}","deployments_url":"https://api.github.com/repos/subeeshcbabu/generator-swaggerize/deployments","created_at":"2015-07-14T03:22:28Z","updated_at":"2016-01-14T02:25:10Z","pushed_at":"2016-07-11T23:14:04Z","git_url":"git://github.com/subeeshcbabu/generator-swaggerize.git","ssh_url":"git@github.com:subeeshcbabu/generator-swaggerize.git","clone_url":"https://github.com/subeeshcbabu/generator-swaggerize.git","svn_url":"https://github.com/subeeshcbabu/generator-swaggerize","homepage":"","size":154,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"krakenjs:v3.x","ref":"v3.x","sha":"e6b9c3fb4d10d0cea476182d00d0613f67b9a578","user":{"login":"krakenjs","id":7001600,"avatar_url":"https://avatars.githubusercontent.com/u/7001600?v=3","gravatar_id":"","url":"https://api.github.com/users/krakenjs","html_url":"https://github.com/krakenjs","followers_url":"https://api.github.com/users/krakenjs/followers","following_url":"https://api.github.com/users/krakenjs/following{/other_user}","gists_url":"https://api.github.com/users/krakenjs/gists{/gist_id}","starred_url":"https://api.github.com/users/krakenjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krakenjs/subscriptions","organizations_url":"https://api.github.com/users/krakenjs/orgs","repos_url":"https://api.github.com/users/krakenjs/repos","events_url":"https://api.github.com/users/krakenjs/events{/privacy}","received_events_url":"https://api.github.com/users/krakenjs/received_events","type":"Organization","site_admin":false},"repo":{"id":25485575,"name":"generator-swaggerize","full_name":"krakenjs/generator-swaggerize","owner":{"login":"krakenjs","id":7001600,"avatar_url":"https://avatars.githubusercontent.com/u/7001600?v=3","gravatar_id":"","url":"https://api.github.com/users/krakenjs","html_url":"https://github.com/krakenjs","followers_url":"https://api.github.com/users/krakenjs/followers","following_url":"https://api.github.com/users/krakenjs/following{/other_user}","gists_url":"https://api.github.com/users/krakenjs/gists{/gist_id}","starred_url":"https://api.github.com/users/krakenjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krakenjs/subscriptions","organizations_url":"https://api.github.com/users/krakenjs/orgs","repos_url":"https://api.github.com/users/krakenjs/repos","events_url":"https://api.github.com/users/krakenjs/events{/privacy}","received_events_url":"https://api.github.com/users/krakenjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/krakenjs/generator-swaggerize","description":"Yeoman generator for design-driven apis with swagger 2.0 and krakenjs/swaggerize tools.","fork":false,"url":"https://api.github.com/repos/krakenjs/generator-swaggerize","forks_url":"https://api.github.com/repos/krakenjs/generator-swaggerize/forks","keys_url":"https://api.github.com/repos/krakenjs/generator-swaggerize/keys{/key_id}","collaborators_url":"https://api.github.com/repos/krakenjs/generator-swaggerize/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/krakenjs/generator-swaggerize/teams","hooks_url":"https://api.github.com/repos/krakenjs/generator-swaggerize/hooks","issue_events_url":"https://api.github.com/repos/krakenjs/generator-swaggerize/issues/events{/number}","events_url":"https://api.github.com/repos/krakenjs/generator-swaggerize/events","assignees_url":"https://api.github.com/repos/krakenjs/generator-swaggerize/assignees{/user}","branches_url":"https://api.github.com/repos/krakenjs/generator-swaggerize/branches{/branch}","tags_url":"https://api.github.com/repos/krakenjs/generator-swaggerize/tags","blobs_url":"https://api.github.com/repos/krakenjs/generator-swaggerize/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/krakenjs/generator-swaggerize/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/krakenjs/generator-swaggerize/git/refs{/sha}","trees_url":"https://api.github.com/repos/krakenjs/generator-swaggerize/git/trees{/sha}","statuses_url":"https://api.github.com/repos/krakenjs/generator-swaggerize/statuses/{sha}","languages_url":"https://api.github.com/repos/krakenjs/generator-swaggerize/languages","stargazers_url":"https://api.github.com/repos/krakenjs/generator-swaggerize/stargazers","contributors_url":"https://api.github.com/repos/krakenjs/generator-swaggerize/contributors","subscribers_url":"https://api.github.com/repos/krakenjs/generator-swaggerize/subscribers","subscription_url":"https://api.github.com/repos/krakenjs/generator-swaggerize/subscription","commits_url":"https://api.github.com/repos/krakenjs/generator-swaggerize/commits{/sha}","git_commits_url":"https://api.github.com/repos/krakenjs/generator-swaggerize/git/commits{/sha}","comments_url":"https://api.github.com/repos/krakenjs/generator-swaggerize/comments{/number}","issue_comment_url":"https://api.github.com/repos/krakenjs/generator-swaggerize/issues/comments{/number}","contents_url":"https://api.github.com/repos/krakenjs/generator-swaggerize/contents/{+path}","compare_url":"https://api.github.com/repos/krakenjs/generator-swaggerize/compare/{base}...{head}","merges_url":"https://api.github.com/repos/krakenjs/generator-swaggerize/merges","archive_url":"https://api.github.com/repos/krakenjs/generator-swaggerize/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/krakenjs/generator-swaggerize/downloads","issues_url":"https://api.github.com/repos/krakenjs/generator-swaggerize/issues{/number}","pulls_url":"https://api.github.com/repos/krakenjs/generator-swaggerize/pulls{/number}","milestones_url":"https://api.github.com/repos/krakenjs/generator-swaggerize/milestones{/number}","notifications_url":"https://api.github.com/repos/krakenjs/generator-swaggerize/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/krakenjs/generator-swaggerize/labels{/name}","releases_url":"https://api.github.com/repos/krakenjs/generator-swaggerize/releases{/id}","deployments_url":"https://api.github.com/repos/krakenjs/generator-swaggerize/deployments","created_at":"2014-10-20T20:38:57Z","updated_at":"2016-07-09T08:20:19Z","pushed_at":"2016-07-11T23:14:04Z","git_url":"git://github.com/krakenjs/generator-swaggerize.git","ssh_url":"git@github.com:krakenjs/generator-swaggerize.git","clone_url":"https://github.com/krakenjs/generator-swaggerize.git","svn_url":"https://github.com/krakenjs/generator-swaggerize","homepage":"","size":160,"stargazers_count":29,"watchers_count":29,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"open_issues_count":22,"forks":22,"open_issues":22,"watchers":29,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/krakenjs/generator-swaggerize/pulls/86"},"html":{"href":"https://github.com/krakenjs/generator-swaggerize/pull/86"},"issue":{"href":"https://api.github.com/repos/krakenjs/generator-swaggerize/issues/86"},"comments":{"href":"https://api.github.com/repos/krakenjs/generator-swaggerize/issues/86/comments"},"review_comments":{"href":"https://api.github.com/repos/krakenjs/generator-swaggerize/pulls/86/comments"},"review_comment":{"href":"https://api.github.com/repos/krakenjs/generator-swaggerize/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/krakenjs/generator-swaggerize/pulls/86/commits"},"statuses":{"href":"https://api.github.com/repos/krakenjs/generator-swaggerize/statuses/f63977cadd728e2da28426c09dbc11579389e6d2"}}}}
{"actor":{"display_login":"subeeshcbabu"}}