{"action":"created","comment":{"url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/pulls/comments/86368803","pull_request_review_id":7031023,"id":86368803,"diff_hunk":"@@ -16782,9 +16782,40 @@ True\n </object>\n <!-- ('', 'zport', 'dmd', 'Events', 'Status', 'Winrm') -->\n <object id='/zport/dmd/Events/Status/Winrm' module='Products.ZenEvents.EventClass' class='EventClass'>\n+<object id='Ping' module='Products.ZenEvents.EventClass' class='EventClass'>\n+</object>\n+<object id='Auth' module='Products.ZenEvents.EventClass' class='EventClass'>\n+<object id='PasswordExpired' module='Products.ZenEvents.EventClass' class='EventClass'>\n+<tomanycont id='instances'>\n+<object id='Password Expired Default' module='Products.ZenEvents.EventClassInst' class='EventClassInst'>\n+<property type=\"string\" id=\"eventClassKey\" mode=\"w\" >\n+defaultmapping","path":"ZenPacks/zenoss/Microsoft/Windows/objects/objects.xml","position":11,"original_position":11,"commit_id":"392e33a1cab45e5a2dfca3e803f10f1d6c4e9325","original_commit_id":"392e33a1cab45e5a2dfca3e803f10f1d6c4e9325","user":{"login":"cluther","id":86579,"avatar_url":"https://avatars.githubusercontent.com/u/86579?v=3","gravatar_id":"","url":"https://api.github.com/users/cluther","html_url":"https://github.com/cluther","followers_url":"https://api.github.com/users/cluther/followers","following_url":"https://api.github.com/users/cluther/following{/other_user}","gists_url":"https://api.github.com/users/cluther/gists{/gist_id}","starred_url":"https://api.github.com/users/cluther/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cluther/subscriptions","organizations_url":"https://api.github.com/users/cluther/orgs","repos_url":"https://api.github.com/users/cluther/repos","events_url":"https://api.github.com/users/cluther/events{/privacy}","received_events_url":"https://api.github.com/users/cluther/received_events","type":"User","site_admin":false},"body":"This should be _MW|PasswordExpired_ instead of _defaultmapping_. Using defaultmapping is more costly when processing events, and should only be used when necessary.","created_at":"2016-11-03T15:23:28Z","updated_at":"2016-11-03T15:23:28Z","html_url":"https://github.com/zenoss/ZenPacks.zenoss.Microsoft.Windows/pull/644#discussion_r86368803","pull_request_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/pulls/644","_links":{"self":{"href":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/pulls/comments/86368803"},"html":{"href":"https://github.com/zenoss/ZenPacks.zenoss.Microsoft.Windows/pull/644#discussion_r86368803"},"pull_request":{"href":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/pulls/644"}}},"pull_request":{"url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/pulls/644","id":91999067,"html_url":"https://github.com/zenoss/ZenPacks.zenoss.Microsoft.Windows/pull/644","diff_url":"https://github.com/zenoss/ZenPacks.zenoss.Microsoft.Windows/pull/644.diff","patch_url":"https://github.com/zenoss/ZenPacks.zenoss.Microsoft.Windows/pull/644.patch","issue_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/issues/644","number":644,"state":"open","locked":false,"title":"Added additional event classes to cover connection errors.","user":{"login":"itshane","id":1818322,"avatar_url":"https://avatars.githubusercontent.com/u/1818322?v=3","gravatar_id":"","url":"https://api.github.com/users/itshane","html_url":"https://github.com/itshane","followers_url":"https://api.github.com/users/itshane/followers","following_url":"https://api.github.com/users/itshane/following{/other_user}","gists_url":"https://api.github.com/users/itshane/gists{/gist_id}","starred_url":"https://api.github.com/users/itshane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/itshane/subscriptions","organizations_url":"https://api.github.com/users/itshane/orgs","repos_url":"https://api.github.com/users/itshane/repos","events_url":"https://api.github.com/users/itshane/events{/privacy}","received_events_url":"https://api.github.com/users/itshane/received_events","type":"User","site_admin":false},"body":"Fixes ZEN-25700","created_at":"2016-11-02T15:55:55Z","updated_at":"2016-11-03T15:24:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f654b37492d267c35168352da5e710f41484dca2","assignee":{"login":"cluther","id":86579,"avatar_url":"https://avatars.githubusercontent.com/u/86579?v=3","gravatar_id":"","url":"https://api.github.com/users/cluther","html_url":"https://github.com/cluther","followers_url":"https://api.github.com/users/cluther/followers","following_url":"https://api.github.com/users/cluther/following{/other_user}","gists_url":"https://api.github.com/users/cluther/gists{/gist_id}","starred_url":"https://api.github.com/users/cluther/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cluther/subscriptions","organizations_url":"https://api.github.com/users/cluther/orgs","repos_url":"https://api.github.com/users/cluther/repos","events_url":"https://api.github.com/users/cluther/events{/privacy}","received_events_url":"https://api.github.com/users/cluther/received_events","type":"User","site_admin":false},"assignees":[{"login":"cluther","id":86579,"avatar_url":"https://avatars.githubusercontent.com/u/86579?v=3","gravatar_id":"","url":"https://api.github.com/users/cluther","html_url":"https://github.com/cluther","followers_url":"https://api.github.com/users/cluther/followers","following_url":"https://api.github.com/users/cluther/following{/other_user}","gists_url":"https://api.github.com/users/cluther/gists{/gist_id}","starred_url":"https://api.github.com/users/cluther/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cluther/subscriptions","organizations_url":"https://api.github.com/users/cluther/orgs","repos_url":"https://api.github.com/users/cluther/repos","events_url":"https://api.github.com/users/cluther/events{/privacy}","received_events_url":"https://api.github.com/users/cluther/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/pulls/644/commits","review_comments_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/pulls/644/comments","review_comment_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/issues/644/comments","statuses_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/statuses/392e33a1cab45e5a2dfca3e803f10f1d6c4e9325","head":{"label":"zenoss:feature/ZEN-25700","ref":"feature/ZEN-25700","sha":"392e33a1cab45e5a2dfca3e803f10f1d6c4e9325","user":{"login":"zenoss","id":243767,"avatar_url":"https://avatars.githubusercontent.com/u/243767?v=3","gravatar_id":"","url":"https://api.github.com/users/zenoss","html_url":"https://github.com/zenoss","followers_url":"https://api.github.com/users/zenoss/followers","following_url":"https://api.github.com/users/zenoss/following{/other_user}","gists_url":"https://api.github.com/users/zenoss/gists{/gist_id}","starred_url":"https://api.github.com/users/zenoss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zenoss/subscriptions","organizations_url":"https://api.github.com/users/zenoss/orgs","repos_url":"https://api.github.com/users/zenoss/repos","events_url":"https://api.github.com/users/zenoss/events{/privacy}","received_events_url":"https://api.github.com/users/zenoss/received_events","type":"Organization","site_admin":false},"repo":{"id":9173686,"name":"ZenPacks.zenoss.Microsoft.Windows","full_name":"zenoss/ZenPacks.zenoss.Microsoft.Windows","owner":{"login":"zenoss","id":243767,"avatar_url":"https://avatars.githubusercontent.com/u/243767?v=3","gravatar_id":"","url":"https://api.github.com/users/zenoss","html_url":"https://github.com/zenoss","followers_url":"https://api.github.com/users/zenoss/followers","following_url":"https://api.github.com/users/zenoss/following{/other_user}","gists_url":"https://api.github.com/users/zenoss/gists{/gist_id}","starred_url":"https://api.github.com/users/zenoss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zenoss/subscriptions","organizations_url":"https://api.github.com/users/zenoss/orgs","repos_url":"https://api.github.com/users/zenoss/repos","events_url":"https://api.github.com/users/zenoss/events{/privacy}","received_events_url":"https://api.github.com/users/zenoss/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zenoss/ZenPacks.zenoss.Microsoft.Windows","description":"Microsoft Windows ZenPack","fork":false,"url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows","forks_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/forks","keys_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/teams","hooks_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/hooks","issue_events_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/issues/events{/number}","events_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/events","assignees_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/assignees{/user}","branches_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/branches{/branch}","tags_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/tags","blobs_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/git/refs{/sha}","trees_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/statuses/{sha}","languages_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/languages","stargazers_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/stargazers","contributors_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/contributors","subscribers_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/subscribers","subscription_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/subscription","commits_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/commits{/sha}","git_commits_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/git/commits{/sha}","comments_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/comments{/number}","issue_comment_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/issues/comments{/number}","contents_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/contents/{+path}","compare_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/merges","archive_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/downloads","issues_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/issues{/number}","pulls_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/pulls{/number}","milestones_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/milestones{/number}","notifications_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/labels{/name}","releases_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/releases{/id}","deployments_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/deployments","created_at":"2013-04-02T15:42:21Z","updated_at":"2016-10-25T10:58:11Z","pushed_at":"2016-11-03T15:02:37Z","git_url":"git://github.com/zenoss/ZenPacks.zenoss.Microsoft.Windows.git","ssh_url":"git@github.com:zenoss/ZenPacks.zenoss.Microsoft.Windows.git","clone_url":"https://github.com/zenoss/ZenPacks.zenoss.Microsoft.Windows.git","svn_url":"https://github.com/zenoss/ZenPacks.zenoss.Microsoft.Windows","homepage":null,"size":13884,"stargazers_count":11,"watchers_count":11,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":26,"forks":14,"open_issues":26,"watchers":11,"default_branch":"develop"}},"base":{"label":"zenoss:hotfix/2.6.6","ref":"hotfix/2.6.6","sha":"99a7b0d128d519cfc9fe0c51a2d006d4a192ed13","user":{"login":"zenoss","id":243767,"avatar_url":"https://avatars.githubusercontent.com/u/243767?v=3","gravatar_id":"","url":"https://api.github.com/users/zenoss","html_url":"https://github.com/zenoss","followers_url":"https://api.github.com/users/zenoss/followers","following_url":"https://api.github.com/users/zenoss/following{/other_user}","gists_url":"https://api.github.com/users/zenoss/gists{/gist_id}","starred_url":"https://api.github.com/users/zenoss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zenoss/subscriptions","organizations_url":"https://api.github.com/users/zenoss/orgs","repos_url":"https://api.github.com/users/zenoss/repos","events_url":"https://api.github.com/users/zenoss/events{/privacy}","received_events_url":"https://api.github.com/users/zenoss/received_events","type":"Organization","site_admin":false},"repo":{"id":9173686,"name":"ZenPacks.zenoss.Microsoft.Windows","full_name":"zenoss/ZenPacks.zenoss.Microsoft.Windows","owner":{"login":"zenoss","id":243767,"avatar_url":"https://avatars.githubusercontent.com/u/243767?v=3","gravatar_id":"","url":"https://api.github.com/users/zenoss","html_url":"https://github.com/zenoss","followers_url":"https://api.github.com/users/zenoss/followers","following_url":"https://api.github.com/users/zenoss/following{/other_user}","gists_url":"https://api.github.com/users/zenoss/gists{/gist_id}","starred_url":"https://api.github.com/users/zenoss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zenoss/subscriptions","organizations_url":"https://api.github.com/users/zenoss/orgs","repos_url":"https://api.github.com/users/zenoss/repos","events_url":"https://api.github.com/users/zenoss/events{/privacy}","received_events_url":"https://api.github.com/users/zenoss/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zenoss/ZenPacks.zenoss.Microsoft.Windows","description":"Microsoft Windows ZenPack","fork":false,"url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows","forks_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/forks","keys_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/teams","hooks_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/hooks","issue_events_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/issues/events{/number}","events_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/events","assignees_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/assignees{/user}","branches_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/branches{/branch}","tags_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/tags","blobs_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/git/refs{/sha}","trees_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/statuses/{sha}","languages_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/languages","stargazers_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/stargazers","contributors_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/contributors","subscribers_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/subscribers","subscription_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/subscription","commits_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/commits{/sha}","git_commits_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/git/commits{/sha}","comments_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/comments{/number}","issue_comment_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/issues/comments{/number}","contents_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/contents/{+path}","compare_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/merges","archive_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/downloads","issues_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/issues{/number}","pulls_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/pulls{/number}","milestones_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/milestones{/number}","notifications_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/labels{/name}","releases_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/releases{/id}","deployments_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/deployments","created_at":"2013-04-02T15:42:21Z","updated_at":"2016-10-25T10:58:11Z","pushed_at":"2016-11-03T15:02:37Z","git_url":"git://github.com/zenoss/ZenPacks.zenoss.Microsoft.Windows.git","ssh_url":"git@github.com:zenoss/ZenPacks.zenoss.Microsoft.Windows.git","clone_url":"https://github.com/zenoss/ZenPacks.zenoss.Microsoft.Windows.git","svn_url":"https://github.com/zenoss/ZenPacks.zenoss.Microsoft.Windows","homepage":null,"size":13884,"stargazers_count":11,"watchers_count":11,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":26,"forks":14,"open_issues":26,"watchers":11,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/pulls/644"},"html":{"href":"https://github.com/zenoss/ZenPacks.zenoss.Microsoft.Windows/pull/644"},"issue":{"href":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/issues/644"},"comments":{"href":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/issues/644/comments"},"review_comments":{"href":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/pulls/644/comments"},"review_comment":{"href":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/pulls/644/commits"},"statuses":{"href":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/statuses/392e33a1cab45e5a2dfca3e803f10f1d6c4e9325"}}}}
{"actor":{"display_login":"cluther"}}