{"action":"created","comment":{"url":"https://api.github.com/repos/mapstruct/mapstruct/pulls/comments/93519901","pull_request_review_id":14049591,"id":93519901,"diff_hunk":"@@ -0,0 +1,120 @@\n+/**\n+ *  Copyright 2012-2016 Gunnar Morling (http://www.gunnarmorling.de/)\n+ *  and/or other contributors as indicated by the @authors tag. See the\n+ *  copyright.txt file in the distribution for a full listing of all\n+ *  contributors.\n+ *\n+ *  Licensed under the Apache License, Version 2.0 (the \"License\");\n+ *  you may not use this file except in compliance with the License.\n+ *  You may obtain a copy of the License at\n+ *\n+ *      http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ *  Unless required by applicable law or agreed to in writing, software\n+ *  distributed under the License is distributed on an \"AS IS\" BASIS,\n+ *  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ *  See the License for the specific language governing permissions and\n+ *  limitations under the License.\n+ */\n+package org.mapstruct.ap.test.java8stream.forged;\n+\n+import static org.assertj.core.api.Assertions.assertThat;\n+\n+import javax.tools.Diagnostic.Kind;\n+\n+import org.junit.Test;\n+import org.junit.runner.RunWith;\n+import org.mapstruct.ap.internal.util.Collections;\n+import org.mapstruct.ap.testutil.IssueKey;\n+import org.mapstruct.ap.testutil.WithClasses;\n+import org.mapstruct.ap.testutil.compilation.annotation.CompilationResult;\n+import org.mapstruct.ap.testutil.compilation.annotation.Diagnostic;\n+import org.mapstruct.ap.testutil.compilation.annotation.ExpectedCompilationOutcome;\n+import org.mapstruct.ap.testutil.runner.AnnotationProcessorTestRunner;\n+\n+/**\n+ * Test for mappings between collection and stream types,\n+ *\n+ * @author Filip Hrisafov\n+ */\n+@IssueKey(\"962\")\n+@RunWith(AnnotationProcessorTestRunner.class)\n+public class StreamMappingTest {","path":"processor/src/test/java/org/mapstruct/ap/test/java8stream/forged/StreamMappingTest.java","position":42,"original_position":42,"commit_id":"cae7f3d4f84adc56698512cffcc3598c7c0b3f8c","original_commit_id":"cae7f3d4f84adc56698512cffcc3598c7c0b3f8c","user":{"login":"gunnarmorling","id":28612,"avatar_url":"https://avatars.githubusercontent.com/u/28612?v=3","gravatar_id":"","url":"https://api.github.com/users/gunnarmorling","html_url":"https://github.com/gunnarmorling","followers_url":"https://api.github.com/users/gunnarmorling/followers","following_url":"https://api.github.com/users/gunnarmorling/following{/other_user}","gists_url":"https://api.github.com/users/gunnarmorling/gists{/gist_id}","starred_url":"https://api.github.com/users/gunnarmorling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gunnarmorling/subscriptions","organizations_url":"https://api.github.com/users/gunnarmorling/orgs","repos_url":"https://api.github.com/users/gunnarmorling/repos","events_url":"https://api.github.com/users/gunnarmorling/events{/privacy}","received_events_url":"https://api.github.com/users/gunnarmorling/received_events","type":"User","site_admin":false},"body":"Could you use a distinct name for this test? There's another one of the same name.","created_at":"2016-12-21T21:08:29Z","updated_at":"2016-12-21T21:08:29Z","html_url":"https://github.com/mapstruct/mapstruct/pull/964#discussion_r93519901","pull_request_url":"https://api.github.com/repos/mapstruct/mapstruct/pulls/964","_links":{"self":{"href":"https://api.github.com/repos/mapstruct/mapstruct/pulls/comments/93519901"},"html":{"href":"https://github.com/mapstruct/mapstruct/pull/964#discussion_r93519901"},"pull_request":{"href":"https://api.github.com/repos/mapstruct/mapstruct/pulls/964"}}},"pull_request":{"url":"https://api.github.com/repos/mapstruct/mapstruct/pulls/964","id":94897045,"html_url":"https://github.com/mapstruct/mapstruct/pull/964","diff_url":"https://github.com/mapstruct/mapstruct/pull/964.diff","patch_url":"https://github.com/mapstruct/mapstruct/pull/964.patch","issue_url":"https://api.github.com/repos/mapstruct/mapstruct/issues/964","number":964,"state":"open","locked":false,"title":"#962 Java 8 Stream conversions to Collections","user":{"login":"filiphr","id":6012094,"avatar_url":"https://avatars.githubusercontent.com/u/6012094?v=3","gravatar_id":"","url":"https://api.github.com/users/filiphr","html_url":"https://github.com/filiphr","followers_url":"https://api.github.com/users/filiphr/followers","following_url":"https://api.github.com/users/filiphr/following{/other_user}","gists_url":"https://api.github.com/users/filiphr/gists{/gist_id}","starred_url":"https://api.github.com/users/filiphr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/filiphr/subscriptions","organizations_url":"https://api.github.com/users/filiphr/orgs","repos_url":"https://api.github.com/users/filiphr/repos","events_url":"https://api.github.com/users/filiphr/events{/privacy}","received_events_url":"https://api.github.com/users/filiphr/received_events","type":"User","site_admin":false},"body":"This PR covers the easier part of #962 (converting a `Stream` to some collection type).  The implementation type are same as for the [collection mappings](http://mapstruct.org/documentation/1.1/reference/html/index.html#implementation-types-for-collection-mappings) (without the `Map` implementations of course 😄)\r\n\r\nDocumentation is not updated, once this is resolved I will update the documentation.\r\n\r\nAlso I am not sure why, but in the generated mappers there are no null checks for the Stream conversions. What am I doing wrong?\r\n\r\n","created_at":"2016-11-22T21:00:08Z","updated_at":"2016-12-21T21:23:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8e2896f1df36c823a1ca637fd15a462c939b85bb","assignee":{"login":"gunnarmorling","id":28612,"avatar_url":"https://avatars.githubusercontent.com/u/28612?v=3","gravatar_id":"","url":"https://api.github.com/users/gunnarmorling","html_url":"https://github.com/gunnarmorling","followers_url":"https://api.github.com/users/gunnarmorling/followers","following_url":"https://api.github.com/users/gunnarmorling/following{/other_user}","gists_url":"https://api.github.com/users/gunnarmorling/gists{/gist_id}","starred_url":"https://api.github.com/users/gunnarmorling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gunnarmorling/subscriptions","organizations_url":"https://api.github.com/users/gunnarmorling/orgs","repos_url":"https://api.github.com/users/gunnarmorling/repos","events_url":"https://api.github.com/users/gunnarmorling/events{/privacy}","received_events_url":"https://api.github.com/users/gunnarmorling/received_events","type":"User","site_admin":false},"assignees":[{"login":"gunnarmorling","id":28612,"avatar_url":"https://avatars.githubusercontent.com/u/28612?v=3","gravatar_id":"","url":"https://api.github.com/users/gunnarmorling","html_url":"https://github.com/gunnarmorling","followers_url":"https://api.github.com/users/gunnarmorling/followers","following_url":"https://api.github.com/users/gunnarmorling/following{/other_user}","gists_url":"https://api.github.com/users/gunnarmorling/gists{/gist_id}","starred_url":"https://api.github.com/users/gunnarmorling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gunnarmorling/subscriptions","organizations_url":"https://api.github.com/users/gunnarmorling/orgs","repos_url":"https://api.github.com/users/gunnarmorling/repos","events_url":"https://api.github.com/users/gunnarmorling/events{/privacy}","received_events_url":"https://api.github.com/users/gunnarmorling/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/mapstruct/mapstruct/pulls/964/commits","review_comments_url":"https://api.github.com/repos/mapstruct/mapstruct/pulls/964/comments","review_comment_url":"https://api.github.com/repos/mapstruct/mapstruct/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mapstruct/mapstruct/issues/964/comments","statuses_url":"https://api.github.com/repos/mapstruct/mapstruct/statuses/cae7f3d4f84adc56698512cffcc3598c7c0b3f8c","head":{"label":"filiphr:java8-stream-conversions","ref":"java8-stream-conversions","sha":"cae7f3d4f84adc56698512cffcc3598c7c0b3f8c","user":{"login":"filiphr","id":6012094,"avatar_url":"https://avatars.githubusercontent.com/u/6012094?v=3","gravatar_id":"","url":"https://api.github.com/users/filiphr","html_url":"https://github.com/filiphr","followers_url":"https://api.github.com/users/filiphr/followers","following_url":"https://api.github.com/users/filiphr/following{/other_user}","gists_url":"https://api.github.com/users/filiphr/gists{/gist_id}","starred_url":"https://api.github.com/users/filiphr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/filiphr/subscriptions","organizations_url":"https://api.github.com/users/filiphr/orgs","repos_url":"https://api.github.com/users/filiphr/repos","events_url":"https://api.github.com/users/filiphr/events{/privacy}","received_events_url":"https://api.github.com/users/filiphr/received_events","type":"User","site_admin":false},"repo":{"id":66302052,"name":"mapstruct","full_name":"filiphr/mapstruct","owner":{"login":"filiphr","id":6012094,"avatar_url":"https://avatars.githubusercontent.com/u/6012094?v=3","gravatar_id":"","url":"https://api.github.com/users/filiphr","html_url":"https://github.com/filiphr","followers_url":"https://api.github.com/users/filiphr/followers","following_url":"https://api.github.com/users/filiphr/following{/other_user}","gists_url":"https://api.github.com/users/filiphr/gists{/gist_id}","starred_url":"https://api.github.com/users/filiphr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/filiphr/subscriptions","organizations_url":"https://api.github.com/users/filiphr/orgs","repos_url":"https://api.github.com/users/filiphr/repos","events_url":"https://api.github.com/users/filiphr/events{/privacy}","received_events_url":"https://api.github.com/users/filiphr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/filiphr/mapstruct","description":"An annotation processor for generating type-safe bean mappers","fork":true,"url":"https://api.github.com/repos/filiphr/mapstruct","forks_url":"https://api.github.com/repos/filiphr/mapstruct/forks","keys_url":"https://api.github.com/repos/filiphr/mapstruct/keys{/key_id}","collaborators_url":"https://api.github.com/repos/filiphr/mapstruct/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/filiphr/mapstruct/teams","hooks_url":"https://api.github.com/repos/filiphr/mapstruct/hooks","issue_events_url":"https://api.github.com/repos/filiphr/mapstruct/issues/events{/number}","events_url":"https://api.github.com/repos/filiphr/mapstruct/events","assignees_url":"https://api.github.com/repos/filiphr/mapstruct/assignees{/user}","branches_url":"https://api.github.com/repos/filiphr/mapstruct/branches{/branch}","tags_url":"https://api.github.com/repos/filiphr/mapstruct/tags","blobs_url":"https://api.github.com/repos/filiphr/mapstruct/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/filiphr/mapstruct/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/filiphr/mapstruct/git/refs{/sha}","trees_url":"https://api.github.com/repos/filiphr/mapstruct/git/trees{/sha}","statuses_url":"https://api.github.com/repos/filiphr/mapstruct/statuses/{sha}","languages_url":"https://api.github.com/repos/filiphr/mapstruct/languages","stargazers_url":"https://api.github.com/repos/filiphr/mapstruct/stargazers","contributors_url":"https://api.github.com/repos/filiphr/mapstruct/contributors","subscribers_url":"https://api.github.com/repos/filiphr/mapstruct/subscribers","subscription_url":"https://api.github.com/repos/filiphr/mapstruct/subscription","commits_url":"https://api.github.com/repos/filiphr/mapstruct/commits{/sha}","git_commits_url":"https://api.github.com/repos/filiphr/mapstruct/git/commits{/sha}","comments_url":"https://api.github.com/repos/filiphr/mapstruct/comments{/number}","issue_comment_url":"https://api.github.com/repos/filiphr/mapstruct/issues/comments{/number}","contents_url":"https://api.github.com/repos/filiphr/mapstruct/contents/{+path}","compare_url":"https://api.github.com/repos/filiphr/mapstruct/compare/{base}...{head}","merges_url":"https://api.github.com/repos/filiphr/mapstruct/merges","archive_url":"https://api.github.com/repos/filiphr/mapstruct/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/filiphr/mapstruct/downloads","issues_url":"https://api.github.com/repos/filiphr/mapstruct/issues{/number}","pulls_url":"https://api.github.com/repos/filiphr/mapstruct/pulls{/number}","milestones_url":"https://api.github.com/repos/filiphr/mapstruct/milestones{/number}","notifications_url":"https://api.github.com/repos/filiphr/mapstruct/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/filiphr/mapstruct/labels{/name}","releases_url":"https://api.github.com/repos/filiphr/mapstruct/releases{/id}","deployments_url":"https://api.github.com/repos/filiphr/mapstruct/deployments","created_at":"2016-08-22T19:31:05Z","updated_at":"2016-08-22T19:31:12Z","pushed_at":"2016-12-20T22:48:54Z","git_url":"git://github.com/filiphr/mapstruct.git","ssh_url":"git@github.com:filiphr/mapstruct.git","clone_url":"https://github.com/filiphr/mapstruct.git","svn_url":"https://github.com/filiphr/mapstruct","homepage":"http://mapstruct.org/","size":5066,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mapstruct:master","ref":"master","sha":"ea6493d983c9182b56b0f85cbdafe50c73947382","user":{"login":"mapstruct","id":4086779,"avatar_url":"https://avatars.githubusercontent.com/u/4086779?v=3","gravatar_id":"","url":"https://api.github.com/users/mapstruct","html_url":"https://github.com/mapstruct","followers_url":"https://api.github.com/users/mapstruct/followers","following_url":"https://api.github.com/users/mapstruct/following{/other_user}","gists_url":"https://api.github.com/users/mapstruct/gists{/gist_id}","starred_url":"https://api.github.com/users/mapstruct/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapstruct/subscriptions","organizations_url":"https://api.github.com/users/mapstruct/orgs","repos_url":"https://api.github.com/users/mapstruct/repos","events_url":"https://api.github.com/users/mapstruct/events{/privacy}","received_events_url":"https://api.github.com/users/mapstruct/received_events","type":"Organization","site_admin":false},"repo":{"id":4470435,"name":"mapstruct","full_name":"mapstruct/mapstruct","owner":{"login":"mapstruct","id":4086779,"avatar_url":"https://avatars.githubusercontent.com/u/4086779?v=3","gravatar_id":"","url":"https://api.github.com/users/mapstruct","html_url":"https://github.com/mapstruct","followers_url":"https://api.github.com/users/mapstruct/followers","following_url":"https://api.github.com/users/mapstruct/following{/other_user}","gists_url":"https://api.github.com/users/mapstruct/gists{/gist_id}","starred_url":"https://api.github.com/users/mapstruct/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapstruct/subscriptions","organizations_url":"https://api.github.com/users/mapstruct/orgs","repos_url":"https://api.github.com/users/mapstruct/repos","events_url":"https://api.github.com/users/mapstruct/events{/privacy}","received_events_url":"https://api.github.com/users/mapstruct/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mapstruct/mapstruct","description":"An annotation processor for generating type-safe bean mappers","fork":false,"url":"https://api.github.com/repos/mapstruct/mapstruct","forks_url":"https://api.github.com/repos/mapstruct/mapstruct/forks","keys_url":"https://api.github.com/repos/mapstruct/mapstruct/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapstruct/mapstruct/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapstruct/mapstruct/teams","hooks_url":"https://api.github.com/repos/mapstruct/mapstruct/hooks","issue_events_url":"https://api.github.com/repos/mapstruct/mapstruct/issues/events{/number}","events_url":"https://api.github.com/repos/mapstruct/mapstruct/events","assignees_url":"https://api.github.com/repos/mapstruct/mapstruct/assignees{/user}","branches_url":"https://api.github.com/repos/mapstruct/mapstruct/branches{/branch}","tags_url":"https://api.github.com/repos/mapstruct/mapstruct/tags","blobs_url":"https://api.github.com/repos/mapstruct/mapstruct/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapstruct/mapstruct/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapstruct/mapstruct/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapstruct/mapstruct/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapstruct/mapstruct/statuses/{sha}","languages_url":"https://api.github.com/repos/mapstruct/mapstruct/languages","stargazers_url":"https://api.github.com/repos/mapstruct/mapstruct/stargazers","contributors_url":"https://api.github.com/repos/mapstruct/mapstruct/contributors","subscribers_url":"https://api.github.com/repos/mapstruct/mapstruct/subscribers","subscription_url":"https://api.github.com/repos/mapstruct/mapstruct/subscription","commits_url":"https://api.github.com/repos/mapstruct/mapstruct/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapstruct/mapstruct/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapstruct/mapstruct/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapstruct/mapstruct/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapstruct/mapstruct/contents/{+path}","compare_url":"https://api.github.com/repos/mapstruct/mapstruct/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapstruct/mapstruct/merges","archive_url":"https://api.github.com/repos/mapstruct/mapstruct/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapstruct/mapstruct/downloads","issues_url":"https://api.github.com/repos/mapstruct/mapstruct/issues{/number}","pulls_url":"https://api.github.com/repos/mapstruct/mapstruct/pulls{/number}","milestones_url":"https://api.github.com/repos/mapstruct/mapstruct/milestones{/number}","notifications_url":"https://api.github.com/repos/mapstruct/mapstruct/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapstruct/mapstruct/labels{/name}","releases_url":"https://api.github.com/repos/mapstruct/mapstruct/releases{/id}","deployments_url":"https://api.github.com/repos/mapstruct/mapstruct/deployments","created_at":"2012-05-28T12:42:42Z","updated_at":"2016-12-21T14:17:53Z","pushed_at":"2016-12-21T21:20:48Z","git_url":"git://github.com/mapstruct/mapstruct.git","ssh_url":"git@github.com:mapstruct/mapstruct.git","clone_url":"https://github.com/mapstruct/mapstruct.git","svn_url":"https://github.com/mapstruct/mapstruct","homepage":"http://mapstruct.org/","size":5029,"stargazers_count":543,"watchers_count":543,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":128,"mirror_url":null,"open_issues_count":165,"forks":128,"open_issues":165,"watchers":543,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mapstruct/mapstruct/pulls/964"},"html":{"href":"https://github.com/mapstruct/mapstruct/pull/964"},"issue":{"href":"https://api.github.com/repos/mapstruct/mapstruct/issues/964"},"comments":{"href":"https://api.github.com/repos/mapstruct/mapstruct/issues/964/comments"},"review_comments":{"href":"https://api.github.com/repos/mapstruct/mapstruct/pulls/964/comments"},"review_comment":{"href":"https://api.github.com/repos/mapstruct/mapstruct/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mapstruct/mapstruct/pulls/964/commits"},"statuses":{"href":"https://api.github.com/repos/mapstruct/mapstruct/statuses/cae7f3d4f84adc56698512cffcc3598c7c0b3f8c"}}}}
{"actor":{"display_login":"gunnarmorling"}}