{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/react-native/issues/9287","repository_url":"https://api.github.com/repos/facebook/react-native","labels_url":"https://api.github.com/repos/facebook/react-native/issues/9287/labels{/name}","comments_url":"https://api.github.com/repos/facebook/react-native/issues/9287/comments","events_url":"https://api.github.com/repos/facebook/react-native/issues/9287/events","html_url":"https://github.com/facebook/react-native/pull/9287","id":169905207,"number":9287,"title":"[NavigationExperimental] Fix the NavigationTransitioner animation bug","user":{"login":"gitim","id":3778452,"avatar_url":"https://avatars.githubusercontent.com/u/3778452?v=3","gravatar_id":"","url":"https://api.github.com/users/gitim","html_url":"https://github.com/gitim","followers_url":"https://api.github.com/users/gitim/followers","following_url":"https://api.github.com/users/gitim/following{/other_user}","gists_url":"https://api.github.com/users/gitim/gists{/gist_id}","starred_url":"https://api.github.com/users/gitim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gitim/subscriptions","organizations_url":"https://api.github.com/users/gitim/orgs","repos_url":"https://api.github.com/users/gitim/repos","events_url":"https://api.github.com/users/gitim/events{/privacy}","received_events_url":"https://api.github.com/users/gitim/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed","name":"CLA Signed","color":"e7e7e7"},{"url":"https://api.github.com/repos/facebook/react-native/labels/GH%20Review:%20review-needed","name":"GH Review: review-needed","color":"fbca04"}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2016-08-08T11:53:20Z","updated_at":"2016-08-18T09:15:10Z","closed_at":"2016-08-18T09:15:10Z","pull_request":{"url":"https://api.github.com/repos/facebook/react-native/pulls/9287","html_url":"https://github.com/facebook/react-native/pull/9287","diff_url":"https://github.com/facebook/react-native/pull/9287.diff","patch_url":"https://github.com/facebook/react-native/pull/9287.patch"},"body":"Hi, there is a problem in the NavigationTransitioner, if navigate to the next scene before the end of the navigation animation of the current scene, the next scene is not rendered while transitioning:\r\n\r\n![-08-2016 13-30-16](https://cloud.githubusercontent.com/assets/3778452/17477434/5e98e102-5d76-11e6-9d97-f843f0ca0360.gif)\r\n\r\nThis is can not be reproduced manually, but it happens when navigating automatically, for example after some loading completed.\r\n\r\nI made some investigation and found that in the [componentWillReceiveProps](https://github.com/facebook/react-native/blob/master/Libraries/NavigationExperimental/NavigationTransitioner.js#L104) of the NavigationTransitioner when execution reaches  [setValue](https://github.com/facebook/react-native/blob/master/Libraries/NavigationExperimental/NavigationTransitioner.js#L144)  [_onTransitionEnd](https://github.com/facebook/react-native/blob/master/Libraries/NavigationExperimental/NavigationTransitioner.js#L210) is called, where an old _transitionProps with previous navigationState [replaces](https://github.com/facebook/react-native/blob/master/Libraries/NavigationExperimental/NavigationTransitioner.js#L219) a new _transitionProps which was previously set in [componentWillReceiveProps](https://github.com/facebook/react-native/blob/master/Libraries/NavigationExperimental/NavigationTransitioner.js#L121). It seems that progress should be reseted before building the new _transitionProps.\r\n\r\n**Test plan**\r\nHere https://github.com/gitim/react-native/commit/4e49a9ffb3ddb75571c59e314c322e7857eb1e30 I modified an example from the UIExplorer to reproduce the bug, you can copy this lines and run it."},"comment":{"url":"https://api.github.com/repos/facebook/react-native/issues/comments/240668153","html_url":"https://github.com/facebook/react-native/pull/9287#issuecomment-240668153","issue_url":"https://api.github.com/repos/facebook/react-native/issues/9287","id":240668153,"user":{"login":"gitim","id":3778452,"avatar_url":"https://avatars.githubusercontent.com/u/3778452?v=3","gravatar_id":"","url":"https://api.github.com/users/gitim","html_url":"https://github.com/gitim","followers_url":"https://api.github.com/users/gitim/followers","following_url":"https://api.github.com/users/gitim/following{/other_user}","gists_url":"https://api.github.com/users/gitim/gists{/gist_id}","starred_url":"https://api.github.com/users/gitim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gitim/subscriptions","organizations_url":"https://api.github.com/users/gitim/orgs","repos_url":"https://api.github.com/users/gitim/repos","events_url":"https://api.github.com/users/gitim/events{/privacy}","received_events_url":"https://api.github.com/users/gitim/received_events","type":"User","site_admin":false},"created_at":"2016-08-18T09:15:10Z","updated_at":"2016-08-18T09:15:10Z","body":"seems it was fixed in https://github.com/facebook/react-native/pull/8709"}}
{"actor":{"display_login":"gitim"}}