{"action":"created","issue":{"url":"https://api.github.com/repos/facebookincubator/create-react-app/issues/405","repository_url":"https://api.github.com/repos/facebookincubator/create-react-app","labels_url":"https://api.github.com/repos/facebookincubator/create-react-app/issues/405/labels{/name}","comments_url":"https://api.github.com/repos/facebookincubator/create-react-app/issues/405/comments","events_url":"https://api.github.com/repos/facebookincubator/create-react-app/issues/405/events","html_url":"https://github.com/facebookincubator/create-react-app/pull/405","id":170016115,"number":405,"title":"multipackage monorepo base configuration","user":{"login":"ryanyogan","id":41596,"avatar_url":"https://avatars.githubusercontent.com/u/41596?v=3","gravatar_id":"","url":"https://api.github.com/users/ryanyogan","html_url":"https://github.com/ryanyogan","followers_url":"https://api.github.com/users/ryanyogan/followers","following_url":"https://api.github.com/users/ryanyogan/following{/other_user}","gists_url":"https://api.github.com/users/ryanyogan/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanyogan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanyogan/subscriptions","organizations_url":"https://api.github.com/users/ryanyogan/orgs","repos_url":"https://api.github.com/users/ryanyogan/repos","events_url":"https://api.github.com/users/ryanyogan/events{/privacy}","received_events_url":"https://api.github.com/users/ryanyogan/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/facebookincubator/create-react-app/labels/CLA%20Signed","name":"CLA Signed","color":"009900"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-08-08T20:22:19Z","updated_at":"2016-08-09T03:08:09Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/facebookincubator/create-react-app/pulls/405","html_url":"https://github.com/facebookincubator/create-react-app/pull/405","diff_url":"https://github.com/facebookincubator/create-react-app/pull/405.diff","patch_url":"https://github.com/facebookincubator/create-react-app/pull/405.patch"},"body":"#### Monorepo basic configuration in reference to #403 \r\n\r\nChanges made to directory structure\r\n\r\n|- packages (new root directory)\r\n|-- create-react-app (was parent directory)\r\n|-- react-scripts (was global-cli)\r\n\r\n#### Testing\r\nTo test as you would use `npm i create-react-app -g`\r\n`cd packages/create-react-app && npm i . -g` to install locally or `npm link`\r\n`create-react-app my-app` should work as before\r\n\r\nTo test the build process\r\n`cd packages/react-scripts && npm i && npm run build`\r\n\r\n##### Notes\r\nThis is just the directory structure changes, perhaps a little discussion around @hzoo's comment regarding Lerna Independant is warranted? \r\n\r\n````\r\n# or global?\r\nnpm install lerna --save-dev\r\n./node_modules/.bin/lerna init (add lerna.json)\r\n./node_modules/.bin/lerna bootstrap (npm installs packages, links)\r\n# when publish is necessary\r\n./node_modules/.bin/lerna publish --independent\r\n````\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/facebookincubator/create-react-app/issues/comments/238441339","html_url":"https://github.com/facebookincubator/create-react-app/pull/405#issuecomment-238441339","issue_url":"https://api.github.com/repos/facebookincubator/create-react-app/issues/405","id":238441339,"user":{"login":"ryanyogan","id":41596,"avatar_url":"https://avatars.githubusercontent.com/u/41596?v=3","gravatar_id":"","url":"https://api.github.com/users/ryanyogan","html_url":"https://github.com/ryanyogan","followers_url":"https://api.github.com/users/ryanyogan/followers","following_url":"https://api.github.com/users/ryanyogan/following{/other_user}","gists_url":"https://api.github.com/users/ryanyogan/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanyogan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanyogan/subscriptions","organizations_url":"https://api.github.com/users/ryanyogan/orgs","repos_url":"https://api.github.com/users/ryanyogan/repos","events_url":"https://api.github.com/users/ryanyogan/events{/privacy}","received_events_url":"https://api.github.com/users/ryanyogan/received_events","type":"User","site_admin":false},"created_at":"2016-08-09T03:08:08Z","updated_at":"2016-08-09T03:08:08Z","body":"I think I have it pegged, sorry about the delay, thanks for the help!\n\nOn Aug 8, 2016 5:52 PM, \"Dan Abramov\" <notifications@github.com> wrote:\n\n> Try running sh tasks/e2e.sh locally and see why React doesn’t end up in\n> node_modules?\n>\n> —\n> You are receiving this because you authored the thread.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/facebookincubator/create-react-app/pull/405#issuecomment-238402168>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/AACifKGN8iULTMarLOx3y1gT5k90HeK_ks5qd7MzgaJpZM4JfbzM>\n> .\n>\n"}}
{"actor":{"display_login":"ryanyogan"}}