{"action":"created","issue":{"url":"https://api.github.com/repos/hyperspy/hyperspy/issues/1043","repository_url":"https://api.github.com/repos/hyperspy/hyperspy","labels_url":"https://api.github.com/repos/hyperspy/hyperspy/issues/1043/labels{/name}","comments_url":"https://api.github.com/repos/hyperspy/hyperspy/issues/1043/comments","events_url":"https://api.github.com/repos/hyperspy/hyperspy/issues/1043/events","html_url":"https://github.com/hyperspy/hyperspy/pull/1043","id":157494606,"number":1043,"title":"Add support for writing/reading scale and unit to tif files to be read with ImageJ or DigitalMicrograph","user":{"login":"ericpre","id":11851990,"avatar_url":"https://avatars.githubusercontent.com/u/11851990?v=3","gravatar_id":"","url":"https://api.github.com/users/ericpre","html_url":"https://github.com/ericpre","followers_url":"https://api.github.com/users/ericpre/followers","following_url":"https://api.github.com/users/ericpre/following{/other_user}","gists_url":"https://api.github.com/users/ericpre/gists{/gist_id}","starred_url":"https://api.github.com/users/ericpre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericpre/subscriptions","organizations_url":"https://api.github.com/users/ericpre/orgs","repos_url":"https://api.github.com/users/ericpre/repos","events_url":"https://api.github.com/users/ericpre/events{/privacy}","received_events_url":"https://api.github.com/users/ericpre/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/hyperspy/hyperspy/labels/enhancement","name":"enhancement","color":"02e10c"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2016-05-30T12:36:24Z","updated_at":"2016-05-31T09:29:42Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/hyperspy/hyperspy/pulls/1043","html_url":"https://github.com/hyperspy/hyperspy/pull/1043","diff_url":"https://github.com/hyperspy/hyperspy/pull/1043.diff","patch_url":"https://github.com/hyperspy/hyperspy/pull/1043.patch"},"body":"This PR aims at improving the tif compatibility between Hyperspy and ImageJ/DigitalMicrograph by writing/reading the scale and the unit.\r\n\r\n- update local tifffile.py library (necessary to allow writing custom tags required by DM)\r\n- add option to the tif ioplugin to use local tifffile.py when necessary (in case the skimage tifffile.py library is too old)\r\n- add tests\r\n- fix a bug that occurs when reading a tif files using newer version of tifffile.py (API change)\r\n\r\n- [ ] improve the unit reading (still a bug with \"um\" unit...)\r\n\r\nI updated the tifffile.py file using the @magnunor suggestion in #787 regarding credit to authors. I hope this was the proper way to do it?\r\n\r\nThere are still a few details to polish, but if you could already comment/start review it, that would be great! Thanks!"},"comment":{"url":"https://api.github.com/repos/hyperspy/hyperspy/issues/comments/222637960","html_url":"https://github.com/hyperspy/hyperspy/pull/1043#issuecomment-222637960","issue_url":"https://api.github.com/repos/hyperspy/hyperspy/issues/1043","id":222637960,"user":{"login":"ericpre","id":11851990,"avatar_url":"https://avatars.githubusercontent.com/u/11851990?v=3","gravatar_id":"","url":"https://api.github.com/users/ericpre","html_url":"https://github.com/ericpre","followers_url":"https://api.github.com/users/ericpre/followers","following_url":"https://api.github.com/users/ericpre/following{/other_user}","gists_url":"https://api.github.com/users/ericpre/gists{/gist_id}","starred_url":"https://api.github.com/users/ericpre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericpre/subscriptions","organizations_url":"https://api.github.com/users/ericpre/orgs","repos_url":"https://api.github.com/users/ericpre/repos","events_url":"https://api.github.com/users/ericpre/events{/privacy}","received_events_url":"https://api.github.com/users/ericpre/received_events","type":"User","site_admin":false},"created_at":"2016-05-31T09:29:42Z","updated_at":"2016-05-31T09:29:42Z","body":"Actually, I remember that some TEM camera providers save images using tiff files, at least a few years back, the software shipped with Tietz camera used to do that. I don't know it it's still the case, thought. I have some files for this case, so I will add support for the scale and units (at least).\r\n\r\nDoes anybody have similar cases? From SEM or optical?\r\n\r\nI have just checked some SEM images and some of them are using OME-metadata, so I will work on that.\r\n\r\nHere, a link about how ImageJ can read the scale and unit of SEM images:\r\nhttp://imagej.1557.x6.nabble.com/Importing-SEM-images-with-scale-td3689900.html\r\n"}}
{"actor":{"display_login":"ericpre"}}