{"action":"created","issue":{"url":"https://api.github.com/repos/rrag/react-stockcharts/issues/103","repository_url":"https://api.github.com/repos/rrag/react-stockcharts","labels_url":"https://api.github.com/repos/rrag/react-stockcharts/issues/103/labels{/name}","comments_url":"https://api.github.com/repos/rrag/react-stockcharts/issues/103/comments","events_url":"https://api.github.com/repos/rrag/react-stockcharts/issues/103/events","html_url":"https://github.com/rrag/react-stockcharts/issues/103","id":166012325,"number":103,"title":"is svg support really necessary?","user":{"login":"rrag","id":10691183,"avatar_url":"https://avatars.githubusercontent.com/u/10691183?v=3","gravatar_id":"","url":"https://api.github.com/users/rrag","html_url":"https://github.com/rrag","followers_url":"https://api.github.com/users/rrag/followers","following_url":"https://api.github.com/users/rrag/following{/other_user}","gists_url":"https://api.github.com/users/rrag/gists{/gist_id}","starred_url":"https://api.github.com/users/rrag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rrag/subscriptions","organizations_url":"https://api.github.com/users/rrag/orgs","repos_url":"https://api.github.com/users/rrag/repos","events_url":"https://api.github.com/users/rrag/events{/privacy}","received_events_url":"https://api.github.com/users/rrag/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-07-18T03:09:20Z","updated_at":"2016-07-18T12:51:56Z","closed_at":null,"body":"I am thinking of removing `svg` support completely in a future version,\r\n\r\nBenefits:\r\n\r\n1. smaller library size, because all code related to svg will be removed\r\n1. less testing time, possibly faster development of the library as no svg related code to write or test\r\n\r\nDrawbacks:\r\n\r\n1. vector graphics mean ability to create resolution independent charts, so I could server render a chart with svg and create high resolution images\r\n1. no server side rendering to svg, server side rendering to canvas is possible with node-canvas though I have never tested it myself\r\n1. when developing new components I usually start with svg as it is easier to develop and troubleshoot, so development might become a little harder initially till we get used to developing with canvas first\r\n1. doing interactive components on canvas is much more difficult, and needs to be explored if it is even possible with the current design\r\n\r\nThe main motivation behind this thought is that, in order to improve the performance on pan actions, there are some hacks in place for canvas, and these hacks are getting bigger and complex to deal with to support both svg and canvas. I think most users don't really care if it is svg or canvas, they care about performance and usability.\r\n\r\nThoughts?"},"comment":{"url":"https://api.github.com/repos/rrag/react-stockcharts/issues/comments/233319438","html_url":"https://github.com/rrag/react-stockcharts/issues/103#issuecomment-233319438","issue_url":"https://api.github.com/repos/rrag/react-stockcharts/issues/103","id":233319438,"user":{"login":"yinhm","id":14960,"avatar_url":"https://avatars.githubusercontent.com/u/14960?v=3","gravatar_id":"","url":"https://api.github.com/users/yinhm","html_url":"https://github.com/yinhm","followers_url":"https://api.github.com/users/yinhm/followers","following_url":"https://api.github.com/users/yinhm/following{/other_user}","gists_url":"https://api.github.com/users/yinhm/gists{/gist_id}","starred_url":"https://api.github.com/users/yinhm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yinhm/subscriptions","organizations_url":"https://api.github.com/users/yinhm/orgs","repos_url":"https://api.github.com/users/yinhm/repos","events_url":"https://api.github.com/users/yinhm/events{/privacy}","received_events_url":"https://api.github.com/users/yinhm/received_events","type":"User","site_admin":false},"created_at":"2016-07-18T12:51:56Z","updated_at":"2016-07-18T12:51:56Z","body":"+1 for performance and faster development"}}
{"actor":{"display_login":"yinhm"}}