{"action":"created","issue":{"url":"https://api.github.com/repos/wireload/screenly-ose/issues/347","labels_url":"https://api.github.com/repos/wireload/screenly-ose/issues/347/labels{/name}","comments_url":"https://api.github.com/repos/wireload/screenly-ose/issues/347/comments","events_url":"https://api.github.com/repos/wireload/screenly-ose/issues/347/events","html_url":"https://github.com/wireload/screenly-ose/pull/347","id":126122792,"number":347,"title":"Use custom text handler in bottle templates. Decode strings as unicode","user":{"login":"over64","id":2621273,"avatar_url":"https://avatars.githubusercontent.com/u/2621273?v=3","gravatar_id":"","url":"https://api.github.com/users/over64","html_url":"https://github.com/over64","followers_url":"https://api.github.com/users/over64/followers","following_url":"https://api.github.com/users/over64/following{/other_user}","gists_url":"https://api.github.com/users/over64/gists{/gist_id}","starred_url":"https://api.github.com/users/over64/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/over64/subscriptions","organizations_url":"https://api.github.com/users/over64/orgs","repos_url":"https://api.github.com/users/over64/repos","events_url":"https://api.github.com/users/over64/events{/privacy}","received_events_url":"https://api.github.com/users/over64/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-01-12T08:12:35Z","updated_at":"2016-01-12T13:08:52Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/wireload/screenly-ose/pulls/347","html_url":"https://github.com/wireload/screenly-ose/pull/347","diff_url":"https://github.com/wireload/screenly-ose/pull/347.diff","patch_url":"https://github.com/wireload/screenly-ose/pull/347.patch"},"body":"\n\n<!-- Reviewable:start -->\n[<img src=\"https://reviewable.io/review_button.png\" height=40 alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/wireload/screenly-ose/347)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/wireload/screenly-ose/issues/comments/170906730","html_url":"https://github.com/wireload/screenly-ose/pull/347#issuecomment-170906730","issue_url":"https://api.github.com/repos/wireload/screenly-ose/issues/347","id":170906730,"user":{"login":"femdom","id":13913521,"avatar_url":"https://avatars.githubusercontent.com/u/13913521?v=3","gravatar_id":"","url":"https://api.github.com/users/femdom","html_url":"https://github.com/femdom","followers_url":"https://api.github.com/users/femdom/followers","following_url":"https://api.github.com/users/femdom/following{/other_user}","gists_url":"https://api.github.com/users/femdom/gists{/gist_id}","starred_url":"https://api.github.com/users/femdom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/femdom/subscriptions","organizations_url":"https://api.github.com/users/femdom/orgs","repos_url":"https://api.github.com/users/femdom/repos","events_url":"https://api.github.com/users/femdom/events{/privacy}","received_events_url":"https://api.github.com/users/femdom/received_events","type":"User","site_admin":false},"created_at":"2016-01-12T13:08:52Z","updated_at":"2016-01-12T13:08:52Z","body":"\n\n\n\nReview status: 0 of 2 files reviewed at latest revision, 4 unresolved discussions.\n\n---\n\n*[server.py, line 98 \\[r1\\]](https://reviewable.io:443/reviews/wireload/screenly-ose/347#-K7pwrjbkU1dU0Z17wK4:-K7pwrjbkU1dU0Z17wK5:1895404228) ([raw file](https://github.com/wireload/screenly-ose/blob/d0ad3dc4af94ac9065a410feb9d7725d7e097f8e/server.py#L98)):*\nConsider adding a comma in the end after this line.\n\n---\n\n*[utils.py, line 104 \\[r1\\]](https://reviewable.io:443/reviews/wireload/screenly-ose/347#-K7puPC8UCyvg4lpRZaw:-K7puPC8UCyvg4lpRZax:307330646) ([raw file](https://github.com/wireload/screenly-ose/blob/d0ad3dc4af94ac9065a410feb9d7725d7e097f8e/utils.py#L104)):*\nWe don't use builtins as variable names. I used to use it in the past, but now I believe that naming a variable with a name other than built-in is worth of time spent.  \n\n---\n\n*[utils.py, line 105 \\[r1\\]](https://reviewable.io:443/reviews/wireload/screenly-ose/347#-K7pvYu95qdBD42UK0X3:-K7pvYu95qdBD42UK0X4:981235608) ([raw file](https://github.com/wireload/screenly-ose/blob/d0ad3dc4af94ac9065a410feb9d7725d7e097f8e/utils.py#L105)):*\nImagine that you get str=u\"Строка\"\n\n    In [16]: unicode(s.decode(u\"Строка\"))\n    ---------------------------------------------------------------------------\n    UnicodeEncodeError                        Traceback (most recent call last)\n    <ipython-input-16-b2ab93379b58> in <module>()\n    ----> 1 unicode(s.decode(u\"Строка\"))\n\n    UnicodeEncodeError: 'ascii' codec can't encode characters in position 0-5: ordinal not in range(128)\n\n---\n\n*[utils.py, line 106 \\[r1\\]](https://reviewable.io:443/reviews/wireload/screenly-ose/347#-K7pwgs07cmoabFcIaB-:-K7pwgs07cmoabFcIaB0:2083438697) ([raw file](https://github.com/wireload/screenly-ose/blob/d0ad3dc4af94ac9065a410feb9d7725d7e097f8e/utils.py#L106)):*\nNot necessary to wrap value with unicode after str.decode\n\n---\n\n\n*Comments from the [review on Reviewable.io](https://reviewable.io:443/reviews/wireload/screenly-ose/347)*\n<!-- Sent from Reviewable.io -->\n"}}