{"action":"created","issue":{"url":"https://api.github.com/repos/joshuah/sol-redis-pool/issues/19","repository_url":"https://api.github.com/repos/joshuah/sol-redis-pool","labels_url":"https://api.github.com/repos/joshuah/sol-redis-pool/issues/19/labels{/name}","comments_url":"https://api.github.com/repos/joshuah/sol-redis-pool/issues/19/comments","events_url":"https://api.github.com/repos/joshuah/sol-redis-pool/issues/19/events","html_url":"https://github.com/joshuah/sol-redis-pool/pull/19","id":171965098,"number":19,"title":"Adding method to destroy client in pool","user":{"login":"afrasso","id":3944808,"avatar_url":"https://avatars.githubusercontent.com/u/3944808?v=3","gravatar_id":"","url":"https://api.github.com/users/afrasso","html_url":"https://github.com/afrasso","followers_url":"https://api.github.com/users/afrasso/followers","following_url":"https://api.github.com/users/afrasso/following{/other_user}","gists_url":"https://api.github.com/users/afrasso/gists{/gist_id}","starred_url":"https://api.github.com/users/afrasso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afrasso/subscriptions","organizations_url":"https://api.github.com/users/afrasso/orgs","repos_url":"https://api.github.com/users/afrasso/repos","events_url":"https://api.github.com/users/afrasso/events{/privacy}","received_events_url":"https://api.github.com/users/afrasso/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":17,"created_at":"2016-08-18T18:11:31Z","updated_at":"2016-08-30T17:04:12Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/joshuah/sol-redis-pool/pulls/19","html_url":"https://github.com/joshuah/sol-redis-pool/pull/19","diff_url":"https://github.com/joshuah/sol-redis-pool/pull/19.diff","patch_url":"https://github.com/joshuah/sol-redis-pool/pull/19.patch"},"body":"And also adding retry_strategy option as supported option.\r\n\r\nThis is related to https://github.com/joshuah/sol-redis-pool/issues/18.\r\n\r\nAs stated in the issue, if I use any of the redis settings to stop retrying the connection (e.g., max_attempts, retry_strategy, etc) the connection becomes closed but it still served up by the pool. In order to prevent this I believe I need a way to destroy the connection in the pool. This way, if the redis server comes back up I can attempt to reconnect.\r\n\r\n(If this is not the right approach to this, please do let me know.)\r\n"},"comment":{"url":"https://api.github.com/repos/joshuah/sol-redis-pool/issues/comments/243508443","html_url":"https://github.com/joshuah/sol-redis-pool/pull/19#issuecomment-243508443","issue_url":"https://api.github.com/repos/joshuah/sol-redis-pool/issues/19","id":243508443,"user":{"login":"joshuah","id":606846,"avatar_url":"https://avatars.githubusercontent.com/u/606846?v=3","gravatar_id":"","url":"https://api.github.com/users/joshuah","html_url":"https://github.com/joshuah","followers_url":"https://api.github.com/users/joshuah/followers","following_url":"https://api.github.com/users/joshuah/following{/other_user}","gists_url":"https://api.github.com/users/joshuah/gists{/gist_id}","starred_url":"https://api.github.com/users/joshuah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshuah/subscriptions","organizations_url":"https://api.github.com/users/joshuah/orgs","repos_url":"https://api.github.com/users/joshuah/repos","events_url":"https://api.github.com/users/joshuah/events{/privacy}","received_events_url":"https://api.github.com/users/joshuah/received_events","type":"User","site_admin":false},"created_at":"2016-08-30T17:04:12Z","updated_at":"2016-08-30T17:04:12Z","body":"I was planning on the next day or so. \n\n> On Aug 30, 2016, at 12:14 PM, Anthony Frasso <notifications@github.com> wrote:\n> \n> Hey Joshua, just checking in. Any ETA on the fix?\n> \n> On Mon, Aug 29, 2016 at 4:39 PM, Anthony Frasso <anf4@cornell.edu> wrote:\n> \n> > yep, perfect!\n> >\n> > On Mon, Aug 29, 2016 at 4:39 PM, Joshua Heiks <notifications@github.com>\n> > wrote:\n> >\n> >> Yes in combination with a strategy that will return undefined;.\n> >>\n> >> —\n> >> You are receiving this because you authored the thread.\n> >> Reply to this email directly, view it on GitHub\n> >> <https://github.com/joshuah/sol-redis-pool/pull/19#issuecomment-243248316>,\n> >> or mute the thread\n> >> <https://github.com/notifications/unsubscribe-auth/ADwxaFi0mv7im196RrUoPQMQkx9YpTVRks5qk0NxgaJpZM4Jnw2e>\n> >> .\n> >>\n> >\n> >\n> —\n> You are receiving this because you modified the open/close state.\n> Reply to this email directly, view it on GitHub, or mute the thread.\n> \n"}}
{"actor":{"display_login":"joshuah"}}