{"action":"closed","issue":{"url":"https://api.github.com/repos/lexik/LexikJWTAuthenticationBundle/issues/256","repository_url":"https://api.github.com/repos/lexik/LexikJWTAuthenticationBundle","labels_url":"https://api.github.com/repos/lexik/LexikJWTAuthenticationBundle/issues/256/labels{/name}","comments_url":"https://api.github.com/repos/lexik/LexikJWTAuthenticationBundle/issues/256/comments","events_url":"https://api.github.com/repos/lexik/LexikJWTAuthenticationBundle/issues/256/events","html_url":"https://github.com/lexik/LexikJWTAuthenticationBundle/issues/256","id":184272079,"number":256,"title":"Mark the exik_jwt_authentication.encoder.default service as autowire default for JWTEncoderInterface","user":{"login":"weaverryan","id":121003,"avatar_url":"https://avatars.githubusercontent.com/u/121003?v=3","gravatar_id":"","url":"https://api.github.com/users/weaverryan","html_url":"https://github.com/weaverryan","followers_url":"https://api.github.com/users/weaverryan/followers","following_url":"https://api.github.com/users/weaverryan/following{/other_user}","gists_url":"https://api.github.com/users/weaverryan/gists{/gist_id}","starred_url":"https://api.github.com/users/weaverryan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weaverryan/subscriptions","organizations_url":"https://api.github.com/users/weaverryan/orgs","repos_url":"https://api.github.com/users/weaverryan/repos","events_url":"https://api.github.com/users/weaverryan/events{/privacy}","received_events_url":"https://api.github.com/users/weaverryan/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-10-20T16:04:25Z","updated_at":"2016-10-20T18:49:50Z","closed_at":"2016-10-20T18:49:50Z","body":"First, congrats on 2.0! I'm looking forward to checkout out all the changes!\r\n\r\nOn KnpU, since we use this bundle, I just had one user mention a small change in 2.0 that I think we can make smoother. Specifically, we use autowiring on a service that has `JWTEncoderInterface` as an argument. With 2.0, this gives the following exception:\r\n\r\n>\r\nUnable to autowire argument of type \"Lexik\\Bundle\\JWTAuthenticationBundle\\Encoder\\JWTEncoderInterface\" for the service \"app.security.jwt_token_authenticator\". Multiple services exist for this interface (lexik_jwt_authentication.encoder.default, lexik_jwt_authentication.encoder.lcobucci).\r\n\r\nCould we mark the `lexik_jwt_authentication.encoder.default` as the correct autowiring service for this interface? We would just need an `autowiring_types` key added to that service (http://symfony.com/doc/current/components/dependency_injection/autowiring.html) - this is done in other places, like MonologBundle to mark `@logger` as the default `LoggerInterface` service.\r\n\r\nThanks!"}}
{"actor":{"display_login":"chalasr"}}