{"action":"created","comment":{"url":"https://api.github.com/repos/weecology/retriever/pulls/comments/71085658","id":71085658,"diff_hunk":"@@ -39,7 +53,28 @@ def teardown_module():\n     for test in tests:\n         shutil.rmtree(os.path.join(HOME_DIR, \"raw_data\", test['name']))\n         os.remove(os.path.join(HOME_DIR, \"scripts\", test['name'] + '.script'))\n-        os.remove(test['name']+'_'+test['name']+'.txt')\n+        os.system(\"rm -r *{}\".format(test['name']))\n+        os.system(\"rm testdb.sqlite\")\n+\n+def get_output_as_csv(dataset, engines, tmpdir, db):\n+    \"\"\"Install dataset and return the output as a string version of the csv\n+    The string version of the csv output returned by this function can be compared","path":"test/test_integration.py","position":68,"original_position":68,"commit_id":"3852607e9c11c9b5b4207afe82c99646a480a213","original_commit_id":"3852607e9c11c9b5b4207afe82c99646a480a213","user":{"login":"ethanwhite","id":744427,"avatar_url":"https://avatars.githubusercontent.com/u/744427?v=3","gravatar_id":"","url":"https://api.github.com/users/ethanwhite","html_url":"https://github.com/ethanwhite","followers_url":"https://api.github.com/users/ethanwhite/followers","following_url":"https://api.github.com/users/ethanwhite/following{/other_user}","gists_url":"https://api.github.com/users/ethanwhite/gists{/gist_id}","starred_url":"https://api.github.com/users/ethanwhite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethanwhite/subscriptions","organizations_url":"https://api.github.com/users/ethanwhite/orgs","repos_url":"https://api.github.com/users/ethanwhite/repos","events_url":"https://api.github.com/users/ethanwhite/events{/privacy}","received_events_url":"https://api.github.com/users/ethanwhite/received_events","type":"User","site_admin":false},"body":"There should be a blank line after the first line of the docstring.","created_at":"2016-07-17T17:04:51Z","updated_at":"2016-07-17T17:04:51Z","html_url":"https://github.com/weecology/retriever/pull/569#discussion_r71085658","pull_request_url":"https://api.github.com/repos/weecology/retriever/pulls/569","_links":{"self":{"href":"https://api.github.com/repos/weecology/retriever/pulls/comments/71085658"},"html":{"href":"https://github.com/weecology/retriever/pull/569#discussion_r71085658"},"pull_request":{"href":"https://api.github.com/repos/weecology/retriever/pulls/569"}}},"pull_request":{"url":"https://api.github.com/repos/weecology/retriever/pulls/569","id":77722865,"html_url":"https://github.com/weecology/retriever/pull/569","diff_url":"https://github.com/weecology/retriever/pull/569.diff","patch_url":"https://github.com/weecology/retriever/pull/569.patch","issue_url":"https://api.github.com/repos/weecology/retriever/issues/569","number":569,"state":"open","locked":false,"title":"Improve integration tests and SQlite engine bulk insert.","user":{"login":"henrykironde","id":5192965,"avatar_url":"https://avatars.githubusercontent.com/u/5192965?v=3","gravatar_id":"","url":"https://api.github.com/users/henrykironde","html_url":"https://github.com/henrykironde","followers_url":"https://api.github.com/users/henrykironde/followers","following_url":"https://api.github.com/users/henrykironde/following{/other_user}","gists_url":"https://api.github.com/users/henrykironde/gists{/gist_id}","starred_url":"https://api.github.com/users/henrykironde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/henrykironde/subscriptions","organizations_url":"https://api.github.com/users/henrykironde/orgs","repos_url":"https://api.github.com/users/henrykironde/repos","events_url":"https://api.github.com/users/henrykironde/events{/privacy}","received_events_url":"https://api.github.com/users/henrykironde/received_events","type":"User","site_admin":false},"body":"We have improved  integration tests and have\r\nadded integration for all engines.\r\n\r\nSQlite engine improvement:\r\n\r\nDuring bulk insert, SQlite included endofline characters\r\nin the row. `(1,2,\"3\\n\")` instead of `(1,2,3)`.\r\nThis PR removes the endofline characters.\r\nThis issue was not visible when creating the table.\r\nA select on the created table would reveal the issue.\r\n\r\nfixes #310\r\n","created_at":"2016-07-17T00:17:31Z","updated_at":"2016-07-17T17:04:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a81fee73f81b0d3fa4c82f4e7e54430a1578ba24","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/weecology/retriever/pulls/569/commits","review_comments_url":"https://api.github.com/repos/weecology/retriever/pulls/569/comments","review_comment_url":"https://api.github.com/repos/weecology/retriever/pulls/comments{/number}","comments_url":"https://api.github.com/repos/weecology/retriever/issues/569/comments","statuses_url":"https://api.github.com/repos/weecology/retriever/statuses/3852607e9c11c9b5b4207afe82c99646a480a213","head":{"label":"henrykironde:integration","ref":"integration","sha":"3852607e9c11c9b5b4207afe82c99646a480a213","user":{"login":"henrykironde","id":5192965,"avatar_url":"https://avatars.githubusercontent.com/u/5192965?v=3","gravatar_id":"","url":"https://api.github.com/users/henrykironde","html_url":"https://github.com/henrykironde","followers_url":"https://api.github.com/users/henrykironde/followers","following_url":"https://api.github.com/users/henrykironde/following{/other_user}","gists_url":"https://api.github.com/users/henrykironde/gists{/gist_id}","starred_url":"https://api.github.com/users/henrykironde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/henrykironde/subscriptions","organizations_url":"https://api.github.com/users/henrykironde/orgs","repos_url":"https://api.github.com/users/henrykironde/repos","events_url":"https://api.github.com/users/henrykironde/events{/privacy}","received_events_url":"https://api.github.com/users/henrykironde/received_events","type":"User","site_admin":false},"repo":{"id":36955143,"name":"retriever","full_name":"henrykironde/retriever","owner":{"login":"henrykironde","id":5192965,"avatar_url":"https://avatars.githubusercontent.com/u/5192965?v=3","gravatar_id":"","url":"https://api.github.com/users/henrykironde","html_url":"https://github.com/henrykironde","followers_url":"https://api.github.com/users/henrykironde/followers","following_url":"https://api.github.com/users/henrykironde/following{/other_user}","gists_url":"https://api.github.com/users/henrykironde/gists{/gist_id}","starred_url":"https://api.github.com/users/henrykironde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/henrykironde/subscriptions","organizations_url":"https://api.github.com/users/henrykironde/orgs","repos_url":"https://api.github.com/users/henrykironde/repos","events_url":"https://api.github.com/users/henrykironde/events{/privacy}","received_events_url":"https://api.github.com/users/henrykironde/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/henrykironde/retriever","description":"Quickly download, clean up, and install ecological datasets into a database management system","fork":true,"url":"https://api.github.com/repos/henrykironde/retriever","forks_url":"https://api.github.com/repos/henrykironde/retriever/forks","keys_url":"https://api.github.com/repos/henrykironde/retriever/keys{/key_id}","collaborators_url":"https://api.github.com/repos/henrykironde/retriever/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/henrykironde/retriever/teams","hooks_url":"https://api.github.com/repos/henrykironde/retriever/hooks","issue_events_url":"https://api.github.com/repos/henrykironde/retriever/issues/events{/number}","events_url":"https://api.github.com/repos/henrykironde/retriever/events","assignees_url":"https://api.github.com/repos/henrykironde/retriever/assignees{/user}","branches_url":"https://api.github.com/repos/henrykironde/retriever/branches{/branch}","tags_url":"https://api.github.com/repos/henrykironde/retriever/tags","blobs_url":"https://api.github.com/repos/henrykironde/retriever/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/henrykironde/retriever/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/henrykironde/retriever/git/refs{/sha}","trees_url":"https://api.github.com/repos/henrykironde/retriever/git/trees{/sha}","statuses_url":"https://api.github.com/repos/henrykironde/retriever/statuses/{sha}","languages_url":"https://api.github.com/repos/henrykironde/retriever/languages","stargazers_url":"https://api.github.com/repos/henrykironde/retriever/stargazers","contributors_url":"https://api.github.com/repos/henrykironde/retriever/contributors","subscribers_url":"https://api.github.com/repos/henrykironde/retriever/subscribers","subscription_url":"https://api.github.com/repos/henrykironde/retriever/subscription","commits_url":"https://api.github.com/repos/henrykironde/retriever/commits{/sha}","git_commits_url":"https://api.github.com/repos/henrykironde/retriever/git/commits{/sha}","comments_url":"https://api.github.com/repos/henrykironde/retriever/comments{/number}","issue_comment_url":"https://api.github.com/repos/henrykironde/retriever/issues/comments{/number}","contents_url":"https://api.github.com/repos/henrykironde/retriever/contents/{+path}","compare_url":"https://api.github.com/repos/henrykironde/retriever/compare/{base}...{head}","merges_url":"https://api.github.com/repos/henrykironde/retriever/merges","archive_url":"https://api.github.com/repos/henrykironde/retriever/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/henrykironde/retriever/downloads","issues_url":"https://api.github.com/repos/henrykironde/retriever/issues{/number}","pulls_url":"https://api.github.com/repos/henrykironde/retriever/pulls{/number}","milestones_url":"https://api.github.com/repos/henrykironde/retriever/milestones{/number}","notifications_url":"https://api.github.com/repos/henrykironde/retriever/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/henrykironde/retriever/labels{/name}","releases_url":"https://api.github.com/repos/henrykironde/retriever/releases{/id}","deployments_url":"https://api.github.com/repos/henrykironde/retriever/deployments","created_at":"2015-06-05T21:00:14Z","updated_at":"2016-07-10T20:33:02Z","pushed_at":"2016-07-17T16:30:08Z","git_url":"git://github.com/henrykironde/retriever.git","ssh_url":"git@github.com:henrykironde/retriever.git","clone_url":"https://github.com/henrykironde/retriever.git","svn_url":"https://github.com/henrykironde/retriever","homepage":"http://ecodataretriever.org","size":28156,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":7,"forks":1,"open_issues":7,"watchers":0,"default_branch":"master"}},"base":{"label":"weecology:master","ref":"master","sha":"d8633b5b3e691bbacdf70addbd4d10c938750e27","user":{"login":"weecology","id":1156696,"avatar_url":"https://avatars.githubusercontent.com/u/1156696?v=3","gravatar_id":"","url":"https://api.github.com/users/weecology","html_url":"https://github.com/weecology","followers_url":"https://api.github.com/users/weecology/followers","following_url":"https://api.github.com/users/weecology/following{/other_user}","gists_url":"https://api.github.com/users/weecology/gists{/gist_id}","starred_url":"https://api.github.com/users/weecology/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weecology/subscriptions","organizations_url":"https://api.github.com/users/weecology/orgs","repos_url":"https://api.github.com/users/weecology/repos","events_url":"https://api.github.com/users/weecology/events{/privacy}","received_events_url":"https://api.github.com/users/weecology/received_events","type":"Organization","site_admin":false},"repo":{"id":1968190,"name":"retriever","full_name":"weecology/retriever","owner":{"login":"weecology","id":1156696,"avatar_url":"https://avatars.githubusercontent.com/u/1156696?v=3","gravatar_id":"","url":"https://api.github.com/users/weecology","html_url":"https://github.com/weecology","followers_url":"https://api.github.com/users/weecology/followers","following_url":"https://api.github.com/users/weecology/following{/other_user}","gists_url":"https://api.github.com/users/weecology/gists{/gist_id}","starred_url":"https://api.github.com/users/weecology/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weecology/subscriptions","organizations_url":"https://api.github.com/users/weecology/orgs","repos_url":"https://api.github.com/users/weecology/repos","events_url":"https://api.github.com/users/weecology/events{/privacy}","received_events_url":"https://api.github.com/users/weecology/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/weecology/retriever","description":"Quickly download, clean up, and install ecological datasets into a database management system","fork":false,"url":"https://api.github.com/repos/weecology/retriever","forks_url":"https://api.github.com/repos/weecology/retriever/forks","keys_url":"https://api.github.com/repos/weecology/retriever/keys{/key_id}","collaborators_url":"https://api.github.com/repos/weecology/retriever/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/weecology/retriever/teams","hooks_url":"https://api.github.com/repos/weecology/retriever/hooks","issue_events_url":"https://api.github.com/repos/weecology/retriever/issues/events{/number}","events_url":"https://api.github.com/repos/weecology/retriever/events","assignees_url":"https://api.github.com/repos/weecology/retriever/assignees{/user}","branches_url":"https://api.github.com/repos/weecology/retriever/branches{/branch}","tags_url":"https://api.github.com/repos/weecology/retriever/tags","blobs_url":"https://api.github.com/repos/weecology/retriever/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/weecology/retriever/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/weecology/retriever/git/refs{/sha}","trees_url":"https://api.github.com/repos/weecology/retriever/git/trees{/sha}","statuses_url":"https://api.github.com/repos/weecology/retriever/statuses/{sha}","languages_url":"https://api.github.com/repos/weecology/retriever/languages","stargazers_url":"https://api.github.com/repos/weecology/retriever/stargazers","contributors_url":"https://api.github.com/repos/weecology/retriever/contributors","subscribers_url":"https://api.github.com/repos/weecology/retriever/subscribers","subscription_url":"https://api.github.com/repos/weecology/retriever/subscription","commits_url":"https://api.github.com/repos/weecology/retriever/commits{/sha}","git_commits_url":"https://api.github.com/repos/weecology/retriever/git/commits{/sha}","comments_url":"https://api.github.com/repos/weecology/retriever/comments{/number}","issue_comment_url":"https://api.github.com/repos/weecology/retriever/issues/comments{/number}","contents_url":"https://api.github.com/repos/weecology/retriever/contents/{+path}","compare_url":"https://api.github.com/repos/weecology/retriever/compare/{base}...{head}","merges_url":"https://api.github.com/repos/weecology/retriever/merges","archive_url":"https://api.github.com/repos/weecology/retriever/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/weecology/retriever/downloads","issues_url":"https://api.github.com/repos/weecology/retriever/issues{/number}","pulls_url":"https://api.github.com/repos/weecology/retriever/pulls{/number}","milestones_url":"https://api.github.com/repos/weecology/retriever/milestones{/number}","notifications_url":"https://api.github.com/repos/weecology/retriever/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/weecology/retriever/labels{/name}","releases_url":"https://api.github.com/repos/weecology/retriever/releases{/id}","deployments_url":"https://api.github.com/repos/weecology/retriever/deployments","created_at":"2011-06-28T19:01:15Z","updated_at":"2016-06-29T19:16:54Z","pushed_at":"2016-07-17T17:00:15Z","git_url":"git://github.com/weecology/retriever.git","ssh_url":"git@github.com:weecology/retriever.git","clone_url":"https://github.com/weecology/retriever.git","svn_url":"https://github.com/weecology/retriever","homepage":"http://ecodataretriever.org","size":48036,"stargazers_count":68,"watchers_count":68,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":34,"mirror_url":null,"open_issues_count":68,"forks":34,"open_issues":68,"watchers":68,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/weecology/retriever/pulls/569"},"html":{"href":"https://github.com/weecology/retriever/pull/569"},"issue":{"href":"https://api.github.com/repos/weecology/retriever/issues/569"},"comments":{"href":"https://api.github.com/repos/weecology/retriever/issues/569/comments"},"review_comments":{"href":"https://api.github.com/repos/weecology/retriever/pulls/569/comments"},"review_comment":{"href":"https://api.github.com/repos/weecology/retriever/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/weecology/retriever/pulls/569/commits"},"statuses":{"href":"https://api.github.com/repos/weecology/retriever/statuses/3852607e9c11c9b5b4207afe82c99646a480a213"}}}}
{"actor":{"display_login":"ethanwhite"}}