{"action":"created","comment":{"url":"https://api.github.com/repos/linkedin/pinot/pulls/comments/90720326","pull_request_review_id":11241049,"id":90720326,"diff_hunk":"@@ -37,6 +37,8 @@\n     PERCENTILEEST_QUANTILEDIGEST\n   }\n \n+  void accept(AggregationFunctionVisitorBase visitor);","path":"pinot-core/src/main/java/com/linkedin/pinot/core/operator/aggregation/function/AggregationFunction.java","position":4,"original_position":4,"commit_id":"f8a3adcf29d574dd71c617840ca39e0577929ad1","original_commit_id":"f8a3adcf29d574dd71c617840ca39e0577929ad1","user":{"login":"antumbde","id":1058374,"avatar_url":"https://avatars.githubusercontent.com/u/1058374?v=3","gravatar_id":"","url":"https://api.github.com/users/antumbde","html_url":"https://github.com/antumbde","followers_url":"https://api.github.com/users/antumbde/followers","following_url":"https://api.github.com/users/antumbde/following{/other_user}","gists_url":"https://api.github.com/users/antumbde/gists{/gist_id}","starred_url":"https://api.github.com/users/antumbde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antumbde/subscriptions","organizations_url":"https://api.github.com/users/antumbde/orgs","repos_url":"https://api.github.com/users/antumbde/repos","events_url":"https://api.github.com/users/antumbde/events{/privacy}","received_events_url":"https://api.github.com/users/antumbde/received_events","type":"User","site_admin":false},"body":"The AggregationFunctionVisitorBase is a no-op base class that allows creation of specialized classes overriding only relevant methods. Interface will require every derived class to implement all the methods.","created_at":"2016-12-02T21:11:24Z","updated_at":"2016-12-02T21:11:24Z","html_url":"https://github.com/linkedin/pinot/pull/871#discussion_r90720326","pull_request_url":"https://api.github.com/repos/linkedin/pinot/pulls/871","_links":{"self":{"href":"https://api.github.com/repos/linkedin/pinot/pulls/comments/90720326"},"html":{"href":"https://github.com/linkedin/pinot/pull/871#discussion_r90720326"},"pull_request":{"href":"https://api.github.com/repos/linkedin/pinot/pulls/871"}}},"pull_request":{"url":"https://api.github.com/repos/linkedin/pinot/pulls/871","id":96129450,"html_url":"https://github.com/linkedin/pinot/pull/871","diff_url":"https://github.com/linkedin/pinot/pull/871.diff","patch_url":"https://github.com/linkedin/pinot/pull/871.patch","issue_url":"https://api.github.com/repos/linkedin/pinot/issues/871","number":871,"state":"open","locked":false,"title":"WIP: Support aggregation function arguments","user":{"login":"atumbde","id":2695139,"avatar_url":"https://avatars.githubusercontent.com/u/2695139?v=3","gravatar_id":"","url":"https://api.github.com/users/atumbde","html_url":"https://github.com/atumbde","followers_url":"https://api.github.com/users/atumbde/followers","following_url":"https://api.github.com/users/atumbde/following{/other_user}","gists_url":"https://api.github.com/users/atumbde/gists{/gist_id}","starred_url":"https://api.github.com/users/atumbde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atumbde/subscriptions","organizations_url":"https://api.github.com/users/atumbde/orgs","repos_url":"https://api.github.com/users/atumbde/repos","events_url":"https://api.github.com/users/atumbde/events{/privacy}","received_events_url":"https://api.github.com/users/atumbde/received_events","type":"User","site_admin":false},"body":null,"created_at":"2016-12-01T17:03:56Z","updated_at":"2016-12-02T21:11:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"33a930addc1a7ad17fe0c3ba2687c9a139d8e86d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/linkedin/pinot/pulls/871/commits","review_comments_url":"https://api.github.com/repos/linkedin/pinot/pulls/871/comments","review_comment_url":"https://api.github.com/repos/linkedin/pinot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/linkedin/pinot/issues/871/comments","statuses_url":"https://api.github.com/repos/linkedin/pinot/statuses/f8a3adcf29d574dd71c617840ca39e0577929ad1","head":{"label":"linkedin:func_args","ref":"func_args","sha":"f8a3adcf29d574dd71c617840ca39e0577929ad1","user":{"login":"linkedin","id":357098,"avatar_url":"https://avatars.githubusercontent.com/u/357098?v=3","gravatar_id":"","url":"https://api.github.com/users/linkedin","html_url":"https://github.com/linkedin","followers_url":"https://api.github.com/users/linkedin/followers","following_url":"https://api.github.com/users/linkedin/following{/other_user}","gists_url":"https://api.github.com/users/linkedin/gists{/gist_id}","starred_url":"https://api.github.com/users/linkedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkedin/subscriptions","organizations_url":"https://api.github.com/users/linkedin/orgs","repos_url":"https://api.github.com/users/linkedin/repos","events_url":"https://api.github.com/users/linkedin/events{/privacy}","received_events_url":"https://api.github.com/users/linkedin/received_events","type":"Organization","site_admin":false},"repo":{"id":19961085,"name":"pinot","full_name":"linkedin/pinot","owner":{"login":"linkedin","id":357098,"avatar_url":"https://avatars.githubusercontent.com/u/357098?v=3","gravatar_id":"","url":"https://api.github.com/users/linkedin","html_url":"https://github.com/linkedin","followers_url":"https://api.github.com/users/linkedin/followers","following_url":"https://api.github.com/users/linkedin/following{/other_user}","gists_url":"https://api.github.com/users/linkedin/gists{/gist_id}","starred_url":"https://api.github.com/users/linkedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkedin/subscriptions","organizations_url":"https://api.github.com/users/linkedin/orgs","repos_url":"https://api.github.com/users/linkedin/repos","events_url":"https://api.github.com/users/linkedin/events{/privacy}","received_events_url":"https://api.github.com/users/linkedin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/linkedin/pinot","description":"A realtime distributed OLAP datastore","fork":false,"url":"https://api.github.com/repos/linkedin/pinot","forks_url":"https://api.github.com/repos/linkedin/pinot/forks","keys_url":"https://api.github.com/repos/linkedin/pinot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linkedin/pinot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linkedin/pinot/teams","hooks_url":"https://api.github.com/repos/linkedin/pinot/hooks","issue_events_url":"https://api.github.com/repos/linkedin/pinot/issues/events{/number}","events_url":"https://api.github.com/repos/linkedin/pinot/events","assignees_url":"https://api.github.com/repos/linkedin/pinot/assignees{/user}","branches_url":"https://api.github.com/repos/linkedin/pinot/branches{/branch}","tags_url":"https://api.github.com/repos/linkedin/pinot/tags","blobs_url":"https://api.github.com/repos/linkedin/pinot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linkedin/pinot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linkedin/pinot/git/refs{/sha}","trees_url":"https://api.github.com/repos/linkedin/pinot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linkedin/pinot/statuses/{sha}","languages_url":"https://api.github.com/repos/linkedin/pinot/languages","stargazers_url":"https://api.github.com/repos/linkedin/pinot/stargazers","contributors_url":"https://api.github.com/repos/linkedin/pinot/contributors","subscribers_url":"https://api.github.com/repos/linkedin/pinot/subscribers","subscription_url":"https://api.github.com/repos/linkedin/pinot/subscription","commits_url":"https://api.github.com/repos/linkedin/pinot/commits{/sha}","git_commits_url":"https://api.github.com/repos/linkedin/pinot/git/commits{/sha}","comments_url":"https://api.github.com/repos/linkedin/pinot/comments{/number}","issue_comment_url":"https://api.github.com/repos/linkedin/pinot/issues/comments{/number}","contents_url":"https://api.github.com/repos/linkedin/pinot/contents/{+path}","compare_url":"https://api.github.com/repos/linkedin/pinot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linkedin/pinot/merges","archive_url":"https://api.github.com/repos/linkedin/pinot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linkedin/pinot/downloads","issues_url":"https://api.github.com/repos/linkedin/pinot/issues{/number}","pulls_url":"https://api.github.com/repos/linkedin/pinot/pulls{/number}","milestones_url":"https://api.github.com/repos/linkedin/pinot/milestones{/number}","notifications_url":"https://api.github.com/repos/linkedin/pinot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linkedin/pinot/labels{/name}","releases_url":"https://api.github.com/repos/linkedin/pinot/releases{/id}","deployments_url":"https://api.github.com/repos/linkedin/pinot/deployments","created_at":"2014-05-19T23:27:48Z","updated_at":"2016-12-01T19:57:24Z","pushed_at":"2016-12-02T19:35:58Z","git_url":"git://github.com/linkedin/pinot.git","ssh_url":"git@github.com:linkedin/pinot.git","clone_url":"https://github.com/linkedin/pinot.git","svn_url":"https://github.com/linkedin/pinot","homepage":"https://github.com/linkedin/pinot/wiki","size":148273,"stargazers_count":1373,"watchers_count":1373,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":233,"mirror_url":null,"open_issues_count":92,"forks":233,"open_issues":92,"watchers":1373,"default_branch":"master"}},"base":{"label":"linkedin:master","ref":"master","sha":"3c743051dee39e0b81504f2319beac4b4071ce0d","user":{"login":"linkedin","id":357098,"avatar_url":"https://avatars.githubusercontent.com/u/357098?v=3","gravatar_id":"","url":"https://api.github.com/users/linkedin","html_url":"https://github.com/linkedin","followers_url":"https://api.github.com/users/linkedin/followers","following_url":"https://api.github.com/users/linkedin/following{/other_user}","gists_url":"https://api.github.com/users/linkedin/gists{/gist_id}","starred_url":"https://api.github.com/users/linkedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkedin/subscriptions","organizations_url":"https://api.github.com/users/linkedin/orgs","repos_url":"https://api.github.com/users/linkedin/repos","events_url":"https://api.github.com/users/linkedin/events{/privacy}","received_events_url":"https://api.github.com/users/linkedin/received_events","type":"Organization","site_admin":false},"repo":{"id":19961085,"name":"pinot","full_name":"linkedin/pinot","owner":{"login":"linkedin","id":357098,"avatar_url":"https://avatars.githubusercontent.com/u/357098?v=3","gravatar_id":"","url":"https://api.github.com/users/linkedin","html_url":"https://github.com/linkedin","followers_url":"https://api.github.com/users/linkedin/followers","following_url":"https://api.github.com/users/linkedin/following{/other_user}","gists_url":"https://api.github.com/users/linkedin/gists{/gist_id}","starred_url":"https://api.github.com/users/linkedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkedin/subscriptions","organizations_url":"https://api.github.com/users/linkedin/orgs","repos_url":"https://api.github.com/users/linkedin/repos","events_url":"https://api.github.com/users/linkedin/events{/privacy}","received_events_url":"https://api.github.com/users/linkedin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/linkedin/pinot","description":"A realtime distributed OLAP datastore","fork":false,"url":"https://api.github.com/repos/linkedin/pinot","forks_url":"https://api.github.com/repos/linkedin/pinot/forks","keys_url":"https://api.github.com/repos/linkedin/pinot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linkedin/pinot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linkedin/pinot/teams","hooks_url":"https://api.github.com/repos/linkedin/pinot/hooks","issue_events_url":"https://api.github.com/repos/linkedin/pinot/issues/events{/number}","events_url":"https://api.github.com/repos/linkedin/pinot/events","assignees_url":"https://api.github.com/repos/linkedin/pinot/assignees{/user}","branches_url":"https://api.github.com/repos/linkedin/pinot/branches{/branch}","tags_url":"https://api.github.com/repos/linkedin/pinot/tags","blobs_url":"https://api.github.com/repos/linkedin/pinot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linkedin/pinot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linkedin/pinot/git/refs{/sha}","trees_url":"https://api.github.com/repos/linkedin/pinot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linkedin/pinot/statuses/{sha}","languages_url":"https://api.github.com/repos/linkedin/pinot/languages","stargazers_url":"https://api.github.com/repos/linkedin/pinot/stargazers","contributors_url":"https://api.github.com/repos/linkedin/pinot/contributors","subscribers_url":"https://api.github.com/repos/linkedin/pinot/subscribers","subscription_url":"https://api.github.com/repos/linkedin/pinot/subscription","commits_url":"https://api.github.com/repos/linkedin/pinot/commits{/sha}","git_commits_url":"https://api.github.com/repos/linkedin/pinot/git/commits{/sha}","comments_url":"https://api.github.com/repos/linkedin/pinot/comments{/number}","issue_comment_url":"https://api.github.com/repos/linkedin/pinot/issues/comments{/number}","contents_url":"https://api.github.com/repos/linkedin/pinot/contents/{+path}","compare_url":"https://api.github.com/repos/linkedin/pinot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linkedin/pinot/merges","archive_url":"https://api.github.com/repos/linkedin/pinot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linkedin/pinot/downloads","issues_url":"https://api.github.com/repos/linkedin/pinot/issues{/number}","pulls_url":"https://api.github.com/repos/linkedin/pinot/pulls{/number}","milestones_url":"https://api.github.com/repos/linkedin/pinot/milestones{/number}","notifications_url":"https://api.github.com/repos/linkedin/pinot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linkedin/pinot/labels{/name}","releases_url":"https://api.github.com/repos/linkedin/pinot/releases{/id}","deployments_url":"https://api.github.com/repos/linkedin/pinot/deployments","created_at":"2014-05-19T23:27:48Z","updated_at":"2016-12-01T19:57:24Z","pushed_at":"2016-12-02T19:35:58Z","git_url":"git://github.com/linkedin/pinot.git","ssh_url":"git@github.com:linkedin/pinot.git","clone_url":"https://github.com/linkedin/pinot.git","svn_url":"https://github.com/linkedin/pinot","homepage":"https://github.com/linkedin/pinot/wiki","size":148273,"stargazers_count":1373,"watchers_count":1373,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":233,"mirror_url":null,"open_issues_count":92,"forks":233,"open_issues":92,"watchers":1373,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/linkedin/pinot/pulls/871"},"html":{"href":"https://github.com/linkedin/pinot/pull/871"},"issue":{"href":"https://api.github.com/repos/linkedin/pinot/issues/871"},"comments":{"href":"https://api.github.com/repos/linkedin/pinot/issues/871/comments"},"review_comments":{"href":"https://api.github.com/repos/linkedin/pinot/pulls/871/comments"},"review_comment":{"href":"https://api.github.com/repos/linkedin/pinot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/linkedin/pinot/pulls/871/commits"},"statuses":{"href":"https://api.github.com/repos/linkedin/pinot/statuses/f8a3adcf29d574dd71c617840ca39e0577929ad1"}}}}
{"actor":{"display_login":"antumbde"}}