{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/65678696","id":65678696,"diff_hunk":"@@ -1,31 +1,31 @@\n-Copyright (c) 2009 by the Jinja Team, see AUTHORS for more details.\n-\n-Some rights reserved.\n-\n-Redistribution and use in source and binary forms, with or without\n-modification, are permitted provided that the following conditions are\n-met:\n-\n-    * Redistributions of source code must retain the above copyright\n-      notice, this list of conditions and the following disclaimer.\n-\n-    * Redistributions in binary form must reproduce the above\n-      copyright notice, this list of conditions and the following\n-      disclaimer in the documentation and/or other materials provided\n-      with the distribution.\n-\n-    * The names of the contributors may not be used to endorse or\n-      promote products derived from this software without specific\n-      prior written permission.\n-\n-THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS\n-\"AS IS\" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT\n-LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR\n-A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT\n-OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,\n-SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT\n-LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,\n-DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY\n-THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT\n-(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE\n-OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.\n+Copyright (c) 2009 by the Jinja Team, see AUTHORS for more details.\r\n+\r\n+Some rights reserved.\r\n+\r\n+Redistribution and use in source and binary forms, with or without\r\n+modification, are permitted provided that the following conditions are\r\n+met:\r\n+\r\n+    * Redistributions of source code must retain the above copyright\r\n+      notice, this list of conditions and the following disclaimer.\r\n+\r\n+    * Redistributions in binary form must reproduce the above\r\n+      copyright notice, this list of conditions and the following\r\n+      disclaimer in the documentation and/or other materials provided\r\n+      with the distribution.\r\n+\r\n+    * The names of the contributors may not be used to endorse or\r\n+      promote products derived from this software without specific\r\n+      prior written permission.\r\n+\r\n+THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS\r\n+\"AS IS\" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT\r\n+LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR\r\n+A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT\r\n+OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,\r\n+SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT\r\n+LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,\r\n+DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY\r\n+THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT\r\n+(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE\r\n+OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.\r","path":"deps/v8_inspector/deps/jinja2/LICENSE","position":62,"original_position":62,"commit_id":"d303134e3e709acc2ce6b41d5d0f119316adc73e","original_commit_id":"d303134e3e709acc2ce6b41d5d0f119316adc73e","user":{"login":"bnoordhuis","id":275871,"avatar_url":"https://avatars.githubusercontent.com/u/275871?v=3","gravatar_id":"","url":"https://api.github.com/users/bnoordhuis","html_url":"https://github.com/bnoordhuis","followers_url":"https://api.github.com/users/bnoordhuis/followers","following_url":"https://api.github.com/users/bnoordhuis/following{/other_user}","gists_url":"https://api.github.com/users/bnoordhuis/gists{/gist_id}","starred_url":"https://api.github.com/users/bnoordhuis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bnoordhuis/subscriptions","organizations_url":"https://api.github.com/users/bnoordhuis/orgs","repos_url":"https://api.github.com/users/bnoordhuis/repos","events_url":"https://api.github.com/users/bnoordhuis/events{/privacy}","received_events_url":"https://api.github.com/users/bnoordhuis/received_events","type":"User","site_admin":false},"body":"Can you undo the LF -> CRLF changes in this file?","created_at":"2016-06-03T09:17:35Z","updated_at":"2016-06-03T09:17:35Z","html_url":"https://github.com/nodejs/node/pull/7118#discussion_r65678696","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/7118","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/65678696"},"html":{"href":"https://github.com/nodejs/node/pull/7118#discussion_r65678696"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/7118"}}},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/7118","id":72436396,"html_url":"https://github.com/nodejs/node/pull/7118","diff_url":"https://github.com/nodejs/node/pull/7118.diff","patch_url":"https://github.com/nodejs/node/pull/7118.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/7118","number":7118,"state":"open","locked":false,"title":"deps: update v8_inspector","user":{"login":"ofrobots","id":79017,"avatar_url":"https://avatars.githubusercontent.com/u/79017?v=3","gravatar_id":"","url":"https://api.github.com/users/ofrobots","html_url":"https://github.com/ofrobots","followers_url":"https://api.github.com/users/ofrobots/followers","following_url":"https://api.github.com/users/ofrobots/following{/other_user}","gists_url":"https://api.github.com/users/ofrobots/gists{/gist_id}","starred_url":"https://api.github.com/users/ofrobots/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ofrobots/subscriptions","organizations_url":"https://api.github.com/users/ofrobots/orgs","repos_url":"https://api.github.com/users/ofrobots/repos","events_url":"https://api.github.com/users/ofrobots/events{/privacy}","received_events_url":"https://api.github.com/users/ofrobots/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you for your pull request. Please review below requirements.\r\n\r\nRun tests with `make -j4 test` on UNIX or `vcbuild test nosign` on Windows.\r\n\r\nIf this aims to fix a regression or you’re adding a feature, make sure you also\r\nwrite a test. If possible, include a benchmark that quantifies your changes.\r\n\r\nFinally, read through our contributors guide and make adjustments as necessary:\r\nhttps://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [X] tests and code linting passes\r\n- [X] the commit message follows commit guidelines\r\n\r\n##### Affected core subsystem(s)\r\n<!-- provide affected core subsystem(s) (like doc, cluster, crypto, etc) -->\r\ndeps\r\n\r\n##### Description of change\r\n<!-- provide a description of the change below this comment -->\r\n\r\nPick the latest v8_inspector [1].\r\n* V8 5.1 compatibility\r\n* Modify parse builder templates to make coverity happy\r\n* The whitespace differences in the jinja2 sub-depenency do exist\r\n  upstream. I am not sure how I missed them in the original import\r\n  (https://github.com/nodejs/node/commit/ed2eacb).\r\n\r\n[1] https://github.com/pavelfeldman/v8_inspector/commit/3b56732\r\n\r\n/cc @targos, @pavelfeldman, @bnoordhuis \r\nEDIT: CI: https://ci.nodejs.org/job/node-test-pull-request/2909/","created_at":"2016-06-02T23:59:22Z","updated_at":"2016-06-03T09:17:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"24574bdc2cae9c91adfb4e4fc099983bb8a87665","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/7118/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/7118/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/7118/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/d303134e3e709acc2ce6b41d5d0f119316adc73e","head":{"label":"ofrobots:inspector-update","ref":"inspector-update","sha":"d303134e3e709acc2ce6b41d5d0f119316adc73e","user":{"login":"ofrobots","id":79017,"avatar_url":"https://avatars.githubusercontent.com/u/79017?v=3","gravatar_id":"","url":"https://api.github.com/users/ofrobots","html_url":"https://github.com/ofrobots","followers_url":"https://api.github.com/users/ofrobots/followers","following_url":"https://api.github.com/users/ofrobots/following{/other_user}","gists_url":"https://api.github.com/users/ofrobots/gists{/gist_id}","starred_url":"https://api.github.com/users/ofrobots/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ofrobots/subscriptions","organizations_url":"https://api.github.com/users/ofrobots/orgs","repos_url":"https://api.github.com/users/ofrobots/repos","events_url":"https://api.github.com/users/ofrobots/events{/privacy}","received_events_url":"https://api.github.com/users/ofrobots/received_events","type":"User","site_admin":false},"repo":{"id":30940664,"name":"node","full_name":"ofrobots/node","owner":{"login":"ofrobots","id":79017,"avatar_url":"https://avatars.githubusercontent.com/u/79017?v=3","gravatar_id":"","url":"https://api.github.com/users/ofrobots","html_url":"https://github.com/ofrobots","followers_url":"https://api.github.com/users/ofrobots/followers","following_url":"https://api.github.com/users/ofrobots/following{/other_user}","gists_url":"https://api.github.com/users/ofrobots/gists{/gist_id}","starred_url":"https://api.github.com/users/ofrobots/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ofrobots/subscriptions","organizations_url":"https://api.github.com/users/ofrobots/orgs","repos_url":"https://api.github.com/users/ofrobots/repos","events_url":"https://api.github.com/users/ofrobots/events{/privacy}","received_events_url":"https://api.github.com/users/ofrobots/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ofrobots/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles: https://nodejs.org","fork":true,"url":"https://api.github.com/repos/ofrobots/node","forks_url":"https://api.github.com/repos/ofrobots/node/forks","keys_url":"https://api.github.com/repos/ofrobots/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ofrobots/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ofrobots/node/teams","hooks_url":"https://api.github.com/repos/ofrobots/node/hooks","issue_events_url":"https://api.github.com/repos/ofrobots/node/issues/events{/number}","events_url":"https://api.github.com/repos/ofrobots/node/events","assignees_url":"https://api.github.com/repos/ofrobots/node/assignees{/user}","branches_url":"https://api.github.com/repos/ofrobots/node/branches{/branch}","tags_url":"https://api.github.com/repos/ofrobots/node/tags","blobs_url":"https://api.github.com/repos/ofrobots/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ofrobots/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ofrobots/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/ofrobots/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ofrobots/node/statuses/{sha}","languages_url":"https://api.github.com/repos/ofrobots/node/languages","stargazers_url":"https://api.github.com/repos/ofrobots/node/stargazers","contributors_url":"https://api.github.com/repos/ofrobots/node/contributors","subscribers_url":"https://api.github.com/repos/ofrobots/node/subscribers","subscription_url":"https://api.github.com/repos/ofrobots/node/subscription","commits_url":"https://api.github.com/repos/ofrobots/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/ofrobots/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/ofrobots/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/ofrobots/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/ofrobots/node/contents/{+path}","compare_url":"https://api.github.com/repos/ofrobots/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ofrobots/node/merges","archive_url":"https://api.github.com/repos/ofrobots/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ofrobots/node/downloads","issues_url":"https://api.github.com/repos/ofrobots/node/issues{/number}","pulls_url":"https://api.github.com/repos/ofrobots/node/pulls{/number}","milestones_url":"https://api.github.com/repos/ofrobots/node/milestones{/number}","notifications_url":"https://api.github.com/repos/ofrobots/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ofrobots/node/labels{/name}","releases_url":"https://api.github.com/repos/ofrobots/node/releases{/id}","deployments_url":"https://api.github.com/repos/ofrobots/node/deployments","created_at":"2015-02-17T22:14:04Z","updated_at":"2016-05-12T17:46:59Z","pushed_at":"2016-06-02T23:55:50Z","git_url":"git://github.com/ofrobots/node.git","ssh_url":"git@github.com:ofrobots/node.git","clone_url":"https://github.com/ofrobots/node.git","svn_url":"https://github.com/ofrobots/node","homepage":"https://nodejs.org","size":216350,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"83e32266b6ebf60b7c5f31dbaa4f90fa4b2e0a06","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2016-06-03T09:07:16Z","pushed_at":"2016-06-03T08:38:42Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":278849,"stargazers_count":23765,"watchers_count":23765,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3442,"mirror_url":null,"open_issues_count":696,"forks":3442,"open_issues":696,"watchers":23765,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/7118"},"html":{"href":"https://github.com/nodejs/node/pull/7118"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/7118"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/7118/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/7118/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/7118/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/d303134e3e709acc2ce6b41d5d0f119316adc73e"}}}}
{"actor":{"display_login":"bnoordhuis"}}