{"push_id":1137825553,"size":45,"distinct_size":45,"ref":"refs/heads/master","head":"ba505c03f92b7224a953f150d01dbd9246e51205","before":"36006bcb8fcbc1e1b38cbc94e0cf4aa259d7d18c","commits":[{"sha":"08bea1d363fd6b51098b6687f0c7603b2a7f2faa","author":{"name":"epriestley","email":"5bf00c93c9250d44d769b81890fa6584403ae7e0@epriestley.com"},"message":"Add ViewController and SearchEngine for SSH Public Keys\n\nSummary:\nRef T10917. This primarily prepares these for transactions by giving us a place to:\n\n  - review old deactivated keys; and\n  - review changes to keys.\n\nFuture changes will add transactions and a timeline so key changes are recorded exhaustively and can be more easily audited.\n\nTest Plan:\n{F1652089}\n\n{F1652090}\n\n{F1652091}\n\n{F1652092}\n\nReviewers: chad\n\nReviewed By: chad\n\nManiphest Tasks: T10917\n\nDifferential Revision: https://secure.phabricator.com/D15946","distinct":true,"url":"https://api.github.com/repos/folsom-labs/phabricator/commits/08bea1d363fd6b51098b6687f0c7603b2a7f2faa"},{"sha":"9385ddaf828770b73e701d5a598eaf973cfdf541","author":{"name":"epriestley","email":"5bf00c93c9250d44d769b81890fa6584403ae7e0@epriestley.com"},"message":"Fix bad documentation link in clustering intro doc\n\nSummary: Fixes T10991.\n\nTest Plan: Previewed harder, clicked link.\n\nReviewers: chad\n\nReviewed By: chad\n\nManiphest Tasks: T10991\n\nDifferential Revision: https://secure.phabricator.com/D15949","distinct":true,"url":"https://api.github.com/repos/folsom-labs/phabricator/commits/9385ddaf828770b73e701d5a598eaf973cfdf541"},{"sha":"da6b3de65c142bda62b5bc425c6cc8f08c5094ea","author":{"name":"epriestley","email":"5bf00c93c9250d44d769b81890fa6584403ae7e0@epriestley.com"},"message":"Use transactions to apply web UI SSH key edits\n\nSummary:\nRef T10917. Converts web UI edits to transactions.\n\nThis is about 95% \"the right way\", and then I cheated on the last 5% instead of building a real EditEngine. We don't need it for anything else right now and some of the dialog workflows here are a little weird so I'm just planning to skip it for the moment unless it ends up being easier to do after the next phase (mail notifications) or something like that.\n\nTest Plan: {F1652160}\n\nReviewers: chad\n\nReviewed By: chad\n\nManiphest Tasks: T10917\n\nDifferential Revision: https://secure.phabricator.com/D15947","distinct":true,"url":"https://api.github.com/repos/folsom-labs/phabricator/commits/da6b3de65c142bda62b5bc425c6cc8f08c5094ea"},{"sha":"6f6ca0102daa2ac39c19a2c9b6867c921e1021ef","author":{"name":"epriestley","email":"5bf00c93c9250d44d769b81890fa6584403ae7e0@epriestley.com"},"message":"Send forced mail on SSH key edits\n\nSummary:\nRef T10917. This cheats fairly heavily to generate SSH key mail:\n\n  - Generate normal transaction mail.\n  - Force it to go to the user.\n  - Use `setForceDelivery()` to force it to actually be delivered.\n  - Add some warning language to the mail body.\n\nThis doesn't move us much closer to Glorious Infrastructure for this whole class of events, but should do what it needs to for now and doesn't really require anything sketchy.\n\nTest Plan: Created and edited SSH keys, got security notice mail.\n\nReviewers: chad\n\nReviewed By: chad\n\nManiphest Tasks: T10917\n\nDifferential Revision: https://secure.phabricator.com/D15948","distinct":true,"url":"https://api.github.com/repos/folsom-labs/phabricator/commits/6f6ca0102daa2ac39c19a2c9b6867c921e1021ef"},{"sha":"0fad3847271c76213b85cc2ae86ac62a75dcd3a1","author":{"name":"epriestley","email":"5bf00c93c9250d44d769b81890fa6584403ae7e0@epriestley.com"},"message":"Fix minor section formatting mishap in SSH key email\n\nSummary: Ref T10917. This is getting added as a link right now, which causes it to get `<a href>`'d in HTML mail. Add it as text instead.\n\nTest Plan: Edited a key, examined HTML mail body carefully.\n\nReviewers: chad\n\nReviewed By: chad\n\nManiphest Tasks: T10917\n\nDifferential Revision: https://secure.phabricator.com/D15952","distinct":true,"url":"https://api.github.com/repos/folsom-labs/phabricator/commits/0fad3847271c76213b85cc2ae86ac62a75dcd3a1"},{"sha":"7ae33d14ec7b682fc664e397fcd011992211ce86","author":{"name":"epriestley","email":"5bf00c93c9250d44d769b81890fa6584403ae7e0@epriestley.com"},"message":"Use new Differential bucketing logic on default (non-dashboard) homepage\n\nSummary:\nRef T10939. If you haven't installed a dashboard, we show an \"Active Revisions\" panel on the homepage by default. I waited a bit to update this, but the new buckets don't seem to have caused any major problems so far.\n\nUpdate this to use the new logic. I'm just showing \"must review\" + \"should review\", which is similar to the old beahvior.\n\nAlso replace the notification count with this same number. This is a little different from the old behavior, but simpler, and I think we should probably move toward getting rid of these counts completely.\n\nTest Plan:\n  - Viewed homepage as logged-in user, saw my revisions (including revisions I have authority over only because of project membership).\n  - Saw consistent notification count.\n  - Grepped for removed method.\n\nReviewers: chad\n\nReviewed By: chad\n\nManiphest Tasks: T10939\n\nDifferential Revision: https://secure.phabricator.com/D15950","distinct":true,"url":"https://api.github.com/repos/folsom-labs/phabricator/commits/7ae33d14ec7b682fc664e397fcd011992211ce86"},{"sha":"45718268a96ef8290ec1e5bed0ab5b978ca9f1a2","author":{"name":"epriestley","email":"5bf00c93c9250d44d769b81890fa6584403ae7e0@epriestley.com"},"message":"Restore viewer() function to \"Responsible Users\" tokenizer in Differential\n\nSummary:\nRef T10939. This makes the `viewer()` function work again. It retains its own meaning (viewer, plus all their projects and packages).\n\nThere's no `exact-viewer()` function; we could conceivably add one eventually if we need it.\n\nTest Plan:\n  - Queried for `viewer()`, got the same results as querying by my own username.\n  - Browsed function in token browser.\n  - Reviewed autogenerated documentation.\n\nReviewers: chad\n\nReviewed By: chad\n\nManiphest Tasks: T10939\n\nDifferential Revision: https://secure.phabricator.com/D15951","distinct":true,"url":"https://api.github.com/repos/folsom-labs/phabricator/commits/45718268a96ef8290ec1e5bed0ab5b978ca9f1a2"},{"sha":"58aa3fdc9d44da3afed8e308656c6ba1af5a9c4d","author":{"name":"Chad Little","email":"309b338a702206971e2989de6d1d8db3503bf8c3@chadsdomain.com"},"message":"Make View Revision in Mail a little more resilient\n\nSummary: Converts to table so text wraps on long strings well, button always stays top right, better spacing underneath.\n\nTest Plan: Mail, Gmail, mobile\n\nReviewers: epriestley\n\nReviewed By: epriestley\n\nSubscribers: Korvin\n\nDifferential Revision: https://secure.phabricator.com/D15955","distinct":true,"url":"https://api.github.com/repos/folsom-labs/phabricator/commits/58aa3fdc9d44da3afed8e308656c6ba1af5a9c4d"},{"sha":"969d3be035eda9d887b84ae886dcf9162a611578","author":{"name":"Chad Little","email":"309b338a702206971e2989de6d1d8db3503bf8c3@chadsdomain.com"},"message":"Clean up \"points\" display on workboards\n\nSummary: Couple of edge cases here I never cleaned up. This inlines points and projects better, with spacing and use of grey to better differentate from project tag colors.\n\nTest Plan:\nReview edge cases on workboard with multiple short and long project names.\n\n{F1653998}\n\n{F1653999}\n\nReviewers: epriestley\n\nReviewed By: epriestley\n\nSubscribers: Korvin\n\nDifferential Revision: https://secure.phabricator.com/D15956","distinct":true,"url":"https://api.github.com/repos/folsom-labs/phabricator/commits/969d3be035eda9d887b84ae886dcf9162a611578"},{"sha":"804a5db41a9a874d8d323118a578e1cfbf0b6fb0","author":{"name":"Chad Little","email":"309b338a702206971e2989de6d1d8db3503bf8c3@chadsdomain.com"},"message":"Add transparency to Pholio Edit thumbs\n\nSummary: Makes the background transparent for uploaded thumbs. This page in general needs lots of work, but here's the minimum. Fixes T10986\n\nTest Plan: Edit a Mock with a transparent jeff.\n\nReviewers: epriestley\n\nReviewed By: epriestley\n\nSubscribers: Korvin\n\nManiphest Tasks: T10986\n\nDifferential Revision: https://secure.phabricator.com/D15957","distinct":true,"url":"https://api.github.com/repos/folsom-labs/phabricator/commits/804a5db41a9a874d8d323118a578e1cfbf0b6fb0"},{"sha":"f2c36a934ec8a6914a6cfa739568bcd076a514a8","author":{"name":"epriestley","email":"5bf00c93c9250d44d769b81890fa6584403ae7e0@epriestley.com"},"message":"Provide an `<input type=\"file\">` control in Remarkup for mobile and users with esoteric windowing systems\n\nSummary:\nRef T5187. This definitely feels a bit flimsy and I'm going to hold it until I cut the release since it changes a couple of things about Workflow in general, but it seems to work OK and most of it is fine.\n\nThe intent is described in T5187#176236.\n\nIn practice, most of that works like I describe, then the `phui-file-upload` behavior gets some weird glue to figure out if the input is part of the form. Not the most elegant system, but I think it'll hold until we come up with many reasons to write a lot more Javascript.\n\nTest Plan:\nUsed both drag-and-drop and the upload dialog to upload files in Safari, Firefox and Chrome.\n\n{F1653716}\n\nReviewers: chad\n\nReviewed By: chad\n\nManiphest Tasks: T5187\n\nDifferential Revision: https://secure.phabricator.com/D15953","distinct":true,"url":"https://api.github.com/repos/folsom-labs/phabricator/commits/f2c36a934ec8a6914a6cfa739568bcd076a514a8"},{"sha":"ed92d1d8448381af5a947fba76047bd3f394c03e","author":{"name":"epriestley","email":"5bf00c93c9250d44d769b81890fa6584403ae7e0@epriestley.com"},"message":"Regenerate the Celerity map.\n\nAuditors: chad","distinct":true,"url":"https://api.github.com/repos/folsom-labs/phabricator/commits/ed92d1d8448381af5a947fba76047bd3f394c03e"},{"sha":"e902fc0e2a646476af486d73faf6617316eb5030","author":{"name":"Chad Little","email":"309b338a702206971e2989de6d1d8db3503bf8c3@chadsdomain.com"},"message":"Move Tablet breakpoint from 768 -> 920\n\nSummary: Bumping this up higher since two column views get extra tight fast below 900 px. This felt most correct to me, dialing it back from first attempt at 960. Mostly I don't want to ever accidentally trigger it when I'm on the 12\" MacBook. Ref T10926\n\nTest Plan: Durable Column, Workboards, Dashboards, Tasks.\n\nReviewers: epriestley\n\nReviewed By: epriestley\n\nSubscribers: avivey, Korvin\n\nManiphest Tasks: T10926\n\nDifferential Revision: https://secure.phabricator.com/D15960","distinct":true,"url":"https://api.github.com/repos/folsom-labs/phabricator/commits/e902fc0e2a646476af486d73faf6617316eb5030"},{"sha":"a91004ef1ba3bb09c3302cac3d6340e147ae7fe5","author":{"name":"epriestley","email":"5bf00c93c9250d44d769b81890fa6584403ae7e0@epriestley.com"},"message":"Detect timezone discrepancies and prompt users to reconcile them\n\nSummary: Ref T3025. This adds a check for different client/server timezone offsets and gives users an option to fix them or ignore them.\n\nTest Plan:\n  - Fiddled with timezone in Settings and System Preferences.\n  - Got appropriate prompts and behavior after simulating various trips to and from exotic locales.\n\nIn particular, this slightly tricky case seems to work correctly:\n\n  - Travel to NY.\n  - Ignore discrepancy (you're only there for a couple hours for an important meeting, and returning to SF on a later flight).\n  - Return to SF for a few days.\n  - Travel back to NY.\n  - You should be prompted again, since you left the timezone after you ignored the discrepancy.\n\n{F1654528}\n\n{F1654529}\n\n{F1654530}\n\nReviewers: chad\n\nReviewed By: chad\n\nManiphest Tasks: T3025\n\nDifferential Revision: https://secure.phabricator.com/D15961","distinct":true,"url":"https://api.github.com/repos/folsom-labs/phabricator/commits/a91004ef1ba3bb09c3302cac3d6340e147ae7fe5"},{"sha":"8b9df5e90f014ebc2bfcb4a20d95107c86177106","author":{"name":"epriestley","email":"5bf00c93c9250d44d769b81890fa6584403ae7e0@epriestley.com"},"message":"Update Celerity map.","distinct":true,"url":"https://api.github.com/repos/folsom-labs/phabricator/commits/8b9df5e90f014ebc2bfcb4a20d95107c86177106"},{"sha":"5d30ea56cf5e58f8e0a4af6af315d31f4b31407e","author":{"name":"epriestley","email":"5bf00c93c9250d44d769b81890fa6584403ae7e0@epriestley.com"},"message":"Add a modern `user.search` Conduit API method\n\nSummary: Ref T10512. This is fairly bare-bones but appears to work.\n\nTest Plan: Queried all users, queried some stuff by constraints.\n\nReviewers: chad\n\nReviewed By: chad\n\nManiphest Tasks: T10512\n\nDifferential Revision: https://secure.phabricator.com/D15959","distinct":true,"url":"https://api.github.com/repos/folsom-labs/phabricator/commits/5d30ea56cf5e58f8e0a4af6af315d31f4b31407e"},{"sha":"2a00f185eb2f938917b79f8b372696bf913d01c1","author":{"name":"epriestley","email":"5bf00c93c9250d44d769b81890fa6584403ae7e0@epriestley.com"},"message":"When the JS \"Intl\" API is available, use it to guess the timezone\n\nSummary:\nRef T3025. Chrome gives us an easily-accessible, much better guess at which timezone the user is in.\n\nFirefox also exposes \"Intl\" but this doesn't seem to be a reliable method to read the timezone.\n\nTest Plan:\nIn Chrome, swapped my system date/time between zones, clicked the \"reconcile\" popup, got the dropdown prefilled accurately.\n\nIn Safari (no `Intl` API) got the normal flow with no default selected.\n\nReviewers: chad\n\nReviewed By: chad\n\nManiphest Tasks: T3025\n\nDifferential Revision: https://secure.phabricator.com/D15962","distinct":true,"url":"https://api.github.com/repos/folsom-labs/phabricator/commits/2a00f185eb2f938917b79f8b372696bf913d01c1"},{"sha":"3d3fff4991ab921853fd0d1fc96f8b1e65b962d7","author":{"name":"epriestley","email":"5bf00c93c9250d44d769b81890fa6584403ae7e0@epriestley.com"},"message":"Fix weird remarkup linewrapping on a few instructions forms, plus move toward fixing Phame/CORGI remarkup issues\n\nSummary:\nFixes T10381. When we converted to `PHUIRemarkupView`, some instructional text got linebreaks added when it shouldn't have them (the source is written in PHP and wrapped at 80 characters, but the output should flow naturally).\n\nFix this so we don't preserve linebreaks.\n\nThis also makes `PHUIRemarkupView` a little more powerful and inches us toward fixing Phame/CORGI remarkup issues, getting rid of `PhabricatorMarkupInterface` / `PhabricatorMarkupOneOff`, and dropping all the application hard-coding in `PhabricatorMarkupEngine`.\n\nTest Plan:\n  - Grepped for all callsites, looking for callsites which accept remarkup written in `<<<HEREDOC` format.\n  - Viewed form instructions, Conduit API methods, HTTP parameter edit instructions.\n\nReviewers: chad\n\nReviewed By: chad\n\nManiphest Tasks: T10381\n\nDifferential Revision: https://secure.phabricator.com/D15963","distinct":true,"url":"https://api.github.com/repos/folsom-labs/phabricator/commits/3d3fff4991ab921853fd0d1fc96f8b1e65b962d7"},{"sha":"efd001b42fd524f254d22cfd0b44a68b8a19330c","author":{"name":"epriestley","email":"5bf00c93c9250d44d769b81890fa6584403ae7e0@epriestley.com"},"message":"Wordsmith the timezone selection UX\n\nSummary:\nRef T3025.\n\n  - Show current zone to make the current vs new more clear.\n  - Tweak some text.\n\nTest Plan: {F1656534}\n\nReviewers: chad\n\nReviewed By: chad\n\nManiphest Tasks: T3025\n\nDifferential Revision: https://secure.phabricator.com/D15965","distinct":true,"url":"https://api.github.com/repos/folsom-labs/phabricator/commits/efd001b42fd524f254d22cfd0b44a68b8a19330c"},{"sha":"de645301b57f9e62e47f29ac331c7d5a69416e1d","author":{"name":"lkassianik","email":"03fe4e8e6986926ba1222f0b75551245daa36a5c@gmail.com"},"message":"Adding a calendar preview panel to people profile\n\nSummary: Ref T9606\n\nTest Plan: Open people profile for a user with events today/tomorrow, see a panel under badges panel with event list\n\nReviewers: chad, epriestley, #blessed_reviewers\n\nReviewed By: epriestley, #blessed_reviewers\n\nSubscribers: Korvin\n\nManiphest Tasks: T9606\n\nDifferential Revision: https://secure.phabricator.com/D15851","distinct":true,"url":"https://api.github.com/repos/folsom-labs/phabricator/commits/de645301b57f9e62e47f29ac331c7d5a69416e1d"}]}
{"actor":{"display_login":"tals"}}