{"action":"created","comment":{"url":"https://api.github.com/repos/Expensify/Bedrock/pulls/comments/82315687","pull_request_review_id":3232964,"id":82315687,"diff_hunk":"@@ -67,7 +63,6 @@ BedrockNode::BedrockNode(const SData& args, BedrockServer* server_)\n     SINFO(\"BedrockNode constructor\");\n }\n \n-// --------------------------------------------------------------------------","path":"BedrockNode.cpp","position":28,"original_position":28,"commit_id":"aac4f86cc06079e58e07da6bf9659a047c5728ee","original_commit_id":"aac4f86cc06079e58e07da6bf9659a047c5728ee","user":{"login":"quinthar","id":575186,"avatar_url":"https://avatars.githubusercontent.com/u/575186?v=3","gravatar_id":"","url":"https://api.github.com/users/quinthar","html_url":"https://github.com/quinthar","followers_url":"https://api.github.com/users/quinthar/followers","following_url":"https://api.github.com/users/quinthar/following{/other_user}","gists_url":"https://api.github.com/users/quinthar/gists{/gist_id}","starred_url":"https://api.github.com/users/quinthar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quinthar/subscriptions","organizations_url":"https://api.github.com/users/quinthar/orgs","repos_url":"https://api.github.com/users/quinthar/repos","events_url":"https://api.github.com/users/quinthar/events{/privacy}","received_events_url":"https://api.github.com/users/quinthar/received_events","type":"User","site_admin":false},"body":"Why remove these?  I personally find it helpful to break up the sections visually, and would recommend we do it reliably rather than remove it.","created_at":"2016-10-07T01:12:12Z","updated_at":"2016-10-07T01:13:07Z","html_url":"https://github.com/Expensify/Bedrock/pull/9#discussion_r82315687","pull_request_url":"https://api.github.com/repos/Expensify/Bedrock/pulls/9","_links":{"self":{"href":"https://api.github.com/repos/Expensify/Bedrock/pulls/comments/82315687"},"html":{"href":"https://github.com/Expensify/Bedrock/pull/9#discussion_r82315687"},"pull_request":{"href":"https://api.github.com/repos/Expensify/Bedrock/pulls/9"}}},"pull_request":{"url":"https://api.github.com/repos/Expensify/Bedrock/pulls/9","id":88337544,"html_url":"https://github.com/Expensify/Bedrock/pull/9","diff_url":"https://github.com/Expensify/Bedrock/pull/9.diff","patch_url":"https://github.com/Expensify/Bedrock/pull/9.patch","issue_url":"https://api.github.com/repos/Expensify/Bedrock/issues/9","number":9,"state":"open","locked":false,"title":"Refactor Bedrock Plugin Code","user":{"login":"tylerkaraszewski","id":705000,"avatar_url":"https://avatars.githubusercontent.com/u/705000?v=3","gravatar_id":"","url":"https://api.github.com/users/tylerkaraszewski","html_url":"https://github.com/tylerkaraszewski","followers_url":"https://api.github.com/users/tylerkaraszewski/followers","following_url":"https://api.github.com/users/tylerkaraszewski/following{/other_user}","gists_url":"https://api.github.com/users/tylerkaraszewski/gists{/gist_id}","starred_url":"https://api.github.com/users/tylerkaraszewski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tylerkaraszewski/subscriptions","organizations_url":"https://api.github.com/users/tylerkaraszewski/orgs","repos_url":"https://api.github.com/users/tylerkaraszewski/repos","events_url":"https://api.github.com/users/tylerkaraszewski/events{/privacy}","received_events_url":"https://api.github.com/users/tylerkaraszewski/received_events","type":"User","site_admin":false},"body":"@flodnv \r\ncc @cead22 @quinthar \r\n\r\nOk, so this didn't *need* to be done, but I was looking at how best to make it possible for a plugin to choose whether or not the BedrockServer would log when it's commands are too slow, and I just decided I'd refactor this a bit to make it easier to work on.\r\n\r\nThis:\r\n\r\n* Moves `BedrockNode::Plugin` to `BedrockPlugin.h`, and in doing so, *renames it `BedrockPlugin`*. I feel like this might be controversial (I'm not sure if it will be, but I'll try and justify it anyway), I feel like as we've moved auth into being a Bedrock plugin, we've enabled more communication between plugins and BedrockServer, which to me makes it not a plugin to a Node, so much as a plugin to Bedrock itself, so I think the name is actually more accurate. Further, nested classes are often just confusing, and I feel like this is more straightforward to understand.\r\n* Removes some unused macros, turns others into static functions and constants.\r\n* Makes the global list of plugins not a pointer (it doesn't need to be).\r\n* Cleans up some comments and formatting.\r\n\r\nHopefully people agree that this looks nicer and is easier to understand.\r\n\r\nThere will be another PR for Auth that depends on this, as the plugin now needs to inherit from `BedrockPlugin` instead of `BedrockNode::Plugin`.","created_at":"2016-10-06T20:44:50Z","updated_at":"2016-10-07T01:13:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"48f5e1d364ae086039d46f66bd1901e00a3170ca","assignee":{"login":"flodnv","id":4164921,"avatar_url":"https://avatars.githubusercontent.com/u/4164921?v=3","gravatar_id":"","url":"https://api.github.com/users/flodnv","html_url":"https://github.com/flodnv","followers_url":"https://api.github.com/users/flodnv/followers","following_url":"https://api.github.com/users/flodnv/following{/other_user}","gists_url":"https://api.github.com/users/flodnv/gists{/gist_id}","starred_url":"https://api.github.com/users/flodnv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flodnv/subscriptions","organizations_url":"https://api.github.com/users/flodnv/orgs","repos_url":"https://api.github.com/users/flodnv/repos","events_url":"https://api.github.com/users/flodnv/events{/privacy}","received_events_url":"https://api.github.com/users/flodnv/received_events","type":"User","site_admin":false},"assignees":[{"login":"flodnv","id":4164921,"avatar_url":"https://avatars.githubusercontent.com/u/4164921?v=3","gravatar_id":"","url":"https://api.github.com/users/flodnv","html_url":"https://github.com/flodnv","followers_url":"https://api.github.com/users/flodnv/followers","following_url":"https://api.github.com/users/flodnv/following{/other_user}","gists_url":"https://api.github.com/users/flodnv/gists{/gist_id}","starred_url":"https://api.github.com/users/flodnv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flodnv/subscriptions","organizations_url":"https://api.github.com/users/flodnv/orgs","repos_url":"https://api.github.com/users/flodnv/repos","events_url":"https://api.github.com/users/flodnv/events{/privacy}","received_events_url":"https://api.github.com/users/flodnv/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Expensify/Bedrock/pulls/9/commits","review_comments_url":"https://api.github.com/repos/Expensify/Bedrock/pulls/9/comments","review_comment_url":"https://api.github.com/repos/Expensify/Bedrock/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Expensify/Bedrock/issues/9/comments","statuses_url":"https://api.github.com/repos/Expensify/Bedrock/statuses/aac4f86cc06079e58e07da6bf9659a047c5728ee","head":{"label":"Expensify:tyler-plugin-refactor","ref":"tyler-plugin-refactor","sha":"aac4f86cc06079e58e07da6bf9659a047c5728ee","user":{"login":"Expensify","id":476779,"avatar_url":"https://avatars.githubusercontent.com/u/476779?v=3","gravatar_id":"","url":"https://api.github.com/users/Expensify","html_url":"https://github.com/Expensify","followers_url":"https://api.github.com/users/Expensify/followers","following_url":"https://api.github.com/users/Expensify/following{/other_user}","gists_url":"https://api.github.com/users/Expensify/gists{/gist_id}","starred_url":"https://api.github.com/users/Expensify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Expensify/subscriptions","organizations_url":"https://api.github.com/users/Expensify/orgs","repos_url":"https://api.github.com/users/Expensify/repos","events_url":"https://api.github.com/users/Expensify/events{/privacy}","received_events_url":"https://api.github.com/users/Expensify/received_events","type":"Organization","site_admin":false},"repo":{"id":67904342,"name":"Bedrock","full_name":"Expensify/Bedrock","owner":{"login":"Expensify","id":476779,"avatar_url":"https://avatars.githubusercontent.com/u/476779?v=3","gravatar_id":"","url":"https://api.github.com/users/Expensify","html_url":"https://github.com/Expensify","followers_url":"https://api.github.com/users/Expensify/followers","following_url":"https://api.github.com/users/Expensify/following{/other_user}","gists_url":"https://api.github.com/users/Expensify/gists{/gist_id}","starred_url":"https://api.github.com/users/Expensify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Expensify/subscriptions","organizations_url":"https://api.github.com/users/Expensify/orgs","repos_url":"https://api.github.com/users/Expensify/repos","events_url":"https://api.github.com/users/Expensify/events{/privacy}","received_events_url":"https://api.github.com/users/Expensify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Expensify/Bedrock","description":null,"fork":false,"url":"https://api.github.com/repos/Expensify/Bedrock","forks_url":"https://api.github.com/repos/Expensify/Bedrock/forks","keys_url":"https://api.github.com/repos/Expensify/Bedrock/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Expensify/Bedrock/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Expensify/Bedrock/teams","hooks_url":"https://api.github.com/repos/Expensify/Bedrock/hooks","issue_events_url":"https://api.github.com/repos/Expensify/Bedrock/issues/events{/number}","events_url":"https://api.github.com/repos/Expensify/Bedrock/events","assignees_url":"https://api.github.com/repos/Expensify/Bedrock/assignees{/user}","branches_url":"https://api.github.com/repos/Expensify/Bedrock/branches{/branch}","tags_url":"https://api.github.com/repos/Expensify/Bedrock/tags","blobs_url":"https://api.github.com/repos/Expensify/Bedrock/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Expensify/Bedrock/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Expensify/Bedrock/git/refs{/sha}","trees_url":"https://api.github.com/repos/Expensify/Bedrock/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Expensify/Bedrock/statuses/{sha}","languages_url":"https://api.github.com/repos/Expensify/Bedrock/languages","stargazers_url":"https://api.github.com/repos/Expensify/Bedrock/stargazers","contributors_url":"https://api.github.com/repos/Expensify/Bedrock/contributors","subscribers_url":"https://api.github.com/repos/Expensify/Bedrock/subscribers","subscription_url":"https://api.github.com/repos/Expensify/Bedrock/subscription","commits_url":"https://api.github.com/repos/Expensify/Bedrock/commits{/sha}","git_commits_url":"https://api.github.com/repos/Expensify/Bedrock/git/commits{/sha}","comments_url":"https://api.github.com/repos/Expensify/Bedrock/comments{/number}","issue_comment_url":"https://api.github.com/repos/Expensify/Bedrock/issues/comments{/number}","contents_url":"https://api.github.com/repos/Expensify/Bedrock/contents/{+path}","compare_url":"https://api.github.com/repos/Expensify/Bedrock/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Expensify/Bedrock/merges","archive_url":"https://api.github.com/repos/Expensify/Bedrock/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Expensify/Bedrock/downloads","issues_url":"https://api.github.com/repos/Expensify/Bedrock/issues{/number}","pulls_url":"https://api.github.com/repos/Expensify/Bedrock/pulls{/number}","milestones_url":"https://api.github.com/repos/Expensify/Bedrock/milestones{/number}","notifications_url":"https://api.github.com/repos/Expensify/Bedrock/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Expensify/Bedrock/labels{/name}","releases_url":"https://api.github.com/repos/Expensify/Bedrock/releases{/id}","deployments_url":"https://api.github.com/repos/Expensify/Bedrock/deployments","created_at":"2016-09-11T01:55:45Z","updated_at":"2016-09-22T17:14:38Z","pushed_at":"2016-10-06T22:13:57Z","git_url":"git://github.com/Expensify/Bedrock.git","ssh_url":"git@github.com:Expensify/Bedrock.git","clone_url":"https://github.com/Expensify/Bedrock.git","svn_url":"https://github.com/Expensify/Bedrock","homepage":null,"size":2367,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":1,"default_branch":"master"}},"base":{"label":"Expensify:master","ref":"master","sha":"b8ca9079b0e908fc8bae5d739d433a726aa5f002","user":{"login":"Expensify","id":476779,"avatar_url":"https://avatars.githubusercontent.com/u/476779?v=3","gravatar_id":"","url":"https://api.github.com/users/Expensify","html_url":"https://github.com/Expensify","followers_url":"https://api.github.com/users/Expensify/followers","following_url":"https://api.github.com/users/Expensify/following{/other_user}","gists_url":"https://api.github.com/users/Expensify/gists{/gist_id}","starred_url":"https://api.github.com/users/Expensify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Expensify/subscriptions","organizations_url":"https://api.github.com/users/Expensify/orgs","repos_url":"https://api.github.com/users/Expensify/repos","events_url":"https://api.github.com/users/Expensify/events{/privacy}","received_events_url":"https://api.github.com/users/Expensify/received_events","type":"Organization","site_admin":false},"repo":{"id":67904342,"name":"Bedrock","full_name":"Expensify/Bedrock","owner":{"login":"Expensify","id":476779,"avatar_url":"https://avatars.githubusercontent.com/u/476779?v=3","gravatar_id":"","url":"https://api.github.com/users/Expensify","html_url":"https://github.com/Expensify","followers_url":"https://api.github.com/users/Expensify/followers","following_url":"https://api.github.com/users/Expensify/following{/other_user}","gists_url":"https://api.github.com/users/Expensify/gists{/gist_id}","starred_url":"https://api.github.com/users/Expensify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Expensify/subscriptions","organizations_url":"https://api.github.com/users/Expensify/orgs","repos_url":"https://api.github.com/users/Expensify/repos","events_url":"https://api.github.com/users/Expensify/events{/privacy}","received_events_url":"https://api.github.com/users/Expensify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Expensify/Bedrock","description":null,"fork":false,"url":"https://api.github.com/repos/Expensify/Bedrock","forks_url":"https://api.github.com/repos/Expensify/Bedrock/forks","keys_url":"https://api.github.com/repos/Expensify/Bedrock/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Expensify/Bedrock/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Expensify/Bedrock/teams","hooks_url":"https://api.github.com/repos/Expensify/Bedrock/hooks","issue_events_url":"https://api.github.com/repos/Expensify/Bedrock/issues/events{/number}","events_url":"https://api.github.com/repos/Expensify/Bedrock/events","assignees_url":"https://api.github.com/repos/Expensify/Bedrock/assignees{/user}","branches_url":"https://api.github.com/repos/Expensify/Bedrock/branches{/branch}","tags_url":"https://api.github.com/repos/Expensify/Bedrock/tags","blobs_url":"https://api.github.com/repos/Expensify/Bedrock/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Expensify/Bedrock/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Expensify/Bedrock/git/refs{/sha}","trees_url":"https://api.github.com/repos/Expensify/Bedrock/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Expensify/Bedrock/statuses/{sha}","languages_url":"https://api.github.com/repos/Expensify/Bedrock/languages","stargazers_url":"https://api.github.com/repos/Expensify/Bedrock/stargazers","contributors_url":"https://api.github.com/repos/Expensify/Bedrock/contributors","subscribers_url":"https://api.github.com/repos/Expensify/Bedrock/subscribers","subscription_url":"https://api.github.com/repos/Expensify/Bedrock/subscription","commits_url":"https://api.github.com/repos/Expensify/Bedrock/commits{/sha}","git_commits_url":"https://api.github.com/repos/Expensify/Bedrock/git/commits{/sha}","comments_url":"https://api.github.com/repos/Expensify/Bedrock/comments{/number}","issue_comment_url":"https://api.github.com/repos/Expensify/Bedrock/issues/comments{/number}","contents_url":"https://api.github.com/repos/Expensify/Bedrock/contents/{+path}","compare_url":"https://api.github.com/repos/Expensify/Bedrock/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Expensify/Bedrock/merges","archive_url":"https://api.github.com/repos/Expensify/Bedrock/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Expensify/Bedrock/downloads","issues_url":"https://api.github.com/repos/Expensify/Bedrock/issues{/number}","pulls_url":"https://api.github.com/repos/Expensify/Bedrock/pulls{/number}","milestones_url":"https://api.github.com/repos/Expensify/Bedrock/milestones{/number}","notifications_url":"https://api.github.com/repos/Expensify/Bedrock/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Expensify/Bedrock/labels{/name}","releases_url":"https://api.github.com/repos/Expensify/Bedrock/releases{/id}","deployments_url":"https://api.github.com/repos/Expensify/Bedrock/deployments","created_at":"2016-09-11T01:55:45Z","updated_at":"2016-09-22T17:14:38Z","pushed_at":"2016-10-06T22:13:57Z","git_url":"git://github.com/Expensify/Bedrock.git","ssh_url":"git@github.com:Expensify/Bedrock.git","clone_url":"https://github.com/Expensify/Bedrock.git","svn_url":"https://github.com/Expensify/Bedrock","homepage":null,"size":2367,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Expensify/Bedrock/pulls/9"},"html":{"href":"https://github.com/Expensify/Bedrock/pull/9"},"issue":{"href":"https://api.github.com/repos/Expensify/Bedrock/issues/9"},"comments":{"href":"https://api.github.com/repos/Expensify/Bedrock/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/Expensify/Bedrock/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/Expensify/Bedrock/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Expensify/Bedrock/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/Expensify/Bedrock/statuses/aac4f86cc06079e58e07da6bf9659a047c5728ee"}}}}
{"actor":{"display_login":"quinthar"}}