{"action":"created","comment":{"url":"https://api.github.com/repos/OpenModelica/OMCompiler/pulls/comments/80901551","pull_request_review_id":1921217,"id":80901551,"diff_hunk":"@@ -639,7 +639,8 @@ algorithm\n \n     case (DAE.BINARY(exp1, DAE.MUL(), exp2), (HtCr2U, HtS2U, HtU2S), _) equation\n       (Unit.MASTER(), (HtCr2U, HtS2U, HtU2S), expListList) = insertUnitInEquation(exp1, (HtCr2U, HtS2U, HtU2S), Unit.MASTER({}));\n-      (Unit.MASTER(), (HtCr2U, HtS2U, HtU2S), _) = insertUnitInEquation(exp2, (HtCr2U, HtS2U, HtU2S), Unit.MASTER({}));\n+      (Unit.MASTER(), (HtCr2U, HtS2U, HtU2S), expListList2) = insertUnitInEquation(exp2, (HtCr2U, HtS2U, HtU2S), Unit.MASTER({}));\n+      expListList = listAppend(expListList, expListList2);","path":"Compiler/BackEnd/UnitCheck.mo","position":6,"original_position":6,"commit_id":"e4eee95ef040ced23358e51f2c89ae0bbce2be05","original_commit_id":"e4eee95ef040ced23358e51f2c89ae0bbce2be05","user":{"login":"lochel","id":8457302,"avatar_url":"https://avatars.githubusercontent.com/u/8457302?v=3","gravatar_id":"","url":"https://api.github.com/users/lochel","html_url":"https://github.com/lochel","followers_url":"https://api.github.com/users/lochel/followers","following_url":"https://api.github.com/users/lochel/following{/other_user}","gists_url":"https://api.github.com/users/lochel/gists{/gist_id}","starred_url":"https://api.github.com/users/lochel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lochel/subscriptions","organizations_url":"https://api.github.com/users/lochel/orgs","repos_url":"https://api.github.com/users/lochel/repos","events_url":"https://api.github.com/users/lochel/events{/privacy}","received_events_url":"https://api.github.com/users/lochel/received_events","type":"User","site_admin":false},"body":"I can improve the implementation once this module is moved to the front end.","created_at":"2016-09-28T12:15:57Z","updated_at":"2016-09-28T12:15:57Z","html_url":"https://github.com/OpenModelica/OMCompiler/pull/1087#discussion_r80901551","pull_request_url":"https://api.github.com/repos/OpenModelica/OMCompiler/pulls/1087","_links":{"self":{"href":"https://api.github.com/repos/OpenModelica/OMCompiler/pulls/comments/80901551"},"html":{"href":"https://github.com/OpenModelica/OMCompiler/pull/1087#discussion_r80901551"},"pull_request":{"href":"https://api.github.com/repos/OpenModelica/OMCompiler/pulls/1087"}}},"pull_request":{"url":"https://api.github.com/repos/OpenModelica/OMCompiler/pulls/1087","id":87104495,"html_url":"https://github.com/OpenModelica/OMCompiler/pull/1087","diff_url":"https://github.com/OpenModelica/OMCompiler/pull/1087.diff","patch_url":"https://github.com/OpenModelica/OMCompiler/pull/1087.patch","issue_url":"https://api.github.com/repos/OpenModelica/OMCompiler/issues/1087","number":1087,"state":"closed","locked":false,"title":"Fix unit checking for products","user":{"login":"lochel","id":8457302,"avatar_url":"https://avatars.githubusercontent.com/u/8457302?v=3","gravatar_id":"","url":"https://api.github.com/users/lochel","html_url":"https://github.com/lochel","followers_url":"https://api.github.com/users/lochel/followers","following_url":"https://api.github.com/users/lochel/following{/other_user}","gists_url":"https://api.github.com/users/lochel/gists{/gist_id}","starred_url":"https://api.github.com/users/lochel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lochel/subscriptions","organizations_url":"https://api.github.com/users/lochel/orgs","repos_url":"https://api.github.com/users/lochel/repos","events_url":"https://api.github.com/users/lochel/events{/privacy}","received_events_url":"https://api.github.com/users/lochel/received_events","type":"User","site_admin":false},"body":"See [ticket:3939](https://trac.openmodelica.org/OpenModelica/ticket/3939).","created_at":"2016-09-28T11:51:55Z","updated_at":"2016-09-28T12:15:57Z","closed_at":"2016-09-28T12:05:17Z","merged_at":"2016-09-28T12:05:17Z","merge_commit_sha":"e4eee95ef040ced23358e51f2c89ae0bbce2be05","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/OpenModelica/OMCompiler/pulls/1087/commits","review_comments_url":"https://api.github.com/repos/OpenModelica/OMCompiler/pulls/1087/comments","review_comment_url":"https://api.github.com/repos/OpenModelica/OMCompiler/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenModelica/OMCompiler/issues/1087/comments","statuses_url":"https://api.github.com/repos/OpenModelica/OMCompiler/statuses/e4eee95ef040ced23358e51f2c89ae0bbce2be05","head":{"label":"lochel:unit-checking","ref":"unit-checking","sha":"e4eee95ef040ced23358e51f2c89ae0bbce2be05","user":{"login":"lochel","id":8457302,"avatar_url":"https://avatars.githubusercontent.com/u/8457302?v=3","gravatar_id":"","url":"https://api.github.com/users/lochel","html_url":"https://github.com/lochel","followers_url":"https://api.github.com/users/lochel/followers","following_url":"https://api.github.com/users/lochel/following{/other_user}","gists_url":"https://api.github.com/users/lochel/gists{/gist_id}","starred_url":"https://api.github.com/users/lochel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lochel/subscriptions","organizations_url":"https://api.github.com/users/lochel/orgs","repos_url":"https://api.github.com/users/lochel/repos","events_url":"https://api.github.com/users/lochel/events{/privacy}","received_events_url":"https://api.github.com/users/lochel/received_events","type":"User","site_admin":false},"repo":{"id":35080771,"name":"OMCompiler","full_name":"lochel/OMCompiler","owner":{"login":"lochel","id":8457302,"avatar_url":"https://avatars.githubusercontent.com/u/8457302?v=3","gravatar_id":"","url":"https://api.github.com/users/lochel","html_url":"https://github.com/lochel","followers_url":"https://api.github.com/users/lochel/followers","following_url":"https://api.github.com/users/lochel/following{/other_user}","gists_url":"https://api.github.com/users/lochel/gists{/gist_id}","starred_url":"https://api.github.com/users/lochel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lochel/subscriptions","organizations_url":"https://api.github.com/users/lochel/orgs","repos_url":"https://api.github.com/users/lochel/repos","events_url":"https://api.github.com/users/lochel/events{/privacy}","received_events_url":"https://api.github.com/users/lochel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lochel/OMCompiler","description":"The OpenModelica Compiler is the core of the OpenModelica project, which is an open-source Modelica-based modeling and simulation environment intended for industrial and academic usage.","fork":true,"url":"https://api.github.com/repos/lochel/OMCompiler","forks_url":"https://api.github.com/repos/lochel/OMCompiler/forks","keys_url":"https://api.github.com/repos/lochel/OMCompiler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lochel/OMCompiler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lochel/OMCompiler/teams","hooks_url":"https://api.github.com/repos/lochel/OMCompiler/hooks","issue_events_url":"https://api.github.com/repos/lochel/OMCompiler/issues/events{/number}","events_url":"https://api.github.com/repos/lochel/OMCompiler/events","assignees_url":"https://api.github.com/repos/lochel/OMCompiler/assignees{/user}","branches_url":"https://api.github.com/repos/lochel/OMCompiler/branches{/branch}","tags_url":"https://api.github.com/repos/lochel/OMCompiler/tags","blobs_url":"https://api.github.com/repos/lochel/OMCompiler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lochel/OMCompiler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lochel/OMCompiler/git/refs{/sha}","trees_url":"https://api.github.com/repos/lochel/OMCompiler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lochel/OMCompiler/statuses/{sha}","languages_url":"https://api.github.com/repos/lochel/OMCompiler/languages","stargazers_url":"https://api.github.com/repos/lochel/OMCompiler/stargazers","contributors_url":"https://api.github.com/repos/lochel/OMCompiler/contributors","subscribers_url":"https://api.github.com/repos/lochel/OMCompiler/subscribers","subscription_url":"https://api.github.com/repos/lochel/OMCompiler/subscription","commits_url":"https://api.github.com/repos/lochel/OMCompiler/commits{/sha}","git_commits_url":"https://api.github.com/repos/lochel/OMCompiler/git/commits{/sha}","comments_url":"https://api.github.com/repos/lochel/OMCompiler/comments{/number}","issue_comment_url":"https://api.github.com/repos/lochel/OMCompiler/issues/comments{/number}","contents_url":"https://api.github.com/repos/lochel/OMCompiler/contents/{+path}","compare_url":"https://api.github.com/repos/lochel/OMCompiler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lochel/OMCompiler/merges","archive_url":"https://api.github.com/repos/lochel/OMCompiler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lochel/OMCompiler/downloads","issues_url":"https://api.github.com/repos/lochel/OMCompiler/issues{/number}","pulls_url":"https://api.github.com/repos/lochel/OMCompiler/pulls{/number}","milestones_url":"https://api.github.com/repos/lochel/OMCompiler/milestones{/number}","notifications_url":"https://api.github.com/repos/lochel/OMCompiler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lochel/OMCompiler/labels{/name}","releases_url":"https://api.github.com/repos/lochel/OMCompiler/releases{/id}","deployments_url":"https://api.github.com/repos/lochel/OMCompiler/deployments","created_at":"2015-05-05T05:56:31Z","updated_at":"2016-01-14T19:18:52Z","pushed_at":"2016-09-28T12:09:29Z","git_url":"git://github.com/lochel/OMCompiler.git","ssh_url":"git@github.com:lochel/OMCompiler.git","clone_url":"https://github.com/lochel/OMCompiler.git","svn_url":"https://github.com/lochel/OMCompiler","homepage":null,"size":61431,"stargazers_count":0,"watchers_count":0,"language":"Modelica","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OpenModelica:master","ref":"master","sha":"99952ed7df8ae342f2d24bec7c17747c7c357e84","user":{"login":"OpenModelica","id":4006504,"avatar_url":"https://avatars.githubusercontent.com/u/4006504?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenModelica","html_url":"https://github.com/OpenModelica","followers_url":"https://api.github.com/users/OpenModelica/followers","following_url":"https://api.github.com/users/OpenModelica/following{/other_user}","gists_url":"https://api.github.com/users/OpenModelica/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenModelica/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenModelica/subscriptions","organizations_url":"https://api.github.com/users/OpenModelica/orgs","repos_url":"https://api.github.com/users/OpenModelica/repos","events_url":"https://api.github.com/users/OpenModelica/events{/privacy}","received_events_url":"https://api.github.com/users/OpenModelica/received_events","type":"Organization","site_admin":false},"repo":{"id":35014743,"name":"OMCompiler","full_name":"OpenModelica/OMCompiler","owner":{"login":"OpenModelica","id":4006504,"avatar_url":"https://avatars.githubusercontent.com/u/4006504?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenModelica","html_url":"https://github.com/OpenModelica","followers_url":"https://api.github.com/users/OpenModelica/followers","following_url":"https://api.github.com/users/OpenModelica/following{/other_user}","gists_url":"https://api.github.com/users/OpenModelica/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenModelica/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenModelica/subscriptions","organizations_url":"https://api.github.com/users/OpenModelica/orgs","repos_url":"https://api.github.com/users/OpenModelica/repos","events_url":"https://api.github.com/users/OpenModelica/events{/privacy}","received_events_url":"https://api.github.com/users/OpenModelica/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenModelica/OMCompiler","description":"The OpenModelica Compiler is the core of the OpenModelica project, which is an open-source Modelica-based modeling and simulation environment intended for industrial and academic usage.","fork":false,"url":"https://api.github.com/repos/OpenModelica/OMCompiler","forks_url":"https://api.github.com/repos/OpenModelica/OMCompiler/forks","keys_url":"https://api.github.com/repos/OpenModelica/OMCompiler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenModelica/OMCompiler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenModelica/OMCompiler/teams","hooks_url":"https://api.github.com/repos/OpenModelica/OMCompiler/hooks","issue_events_url":"https://api.github.com/repos/OpenModelica/OMCompiler/issues/events{/number}","events_url":"https://api.github.com/repos/OpenModelica/OMCompiler/events","assignees_url":"https://api.github.com/repos/OpenModelica/OMCompiler/assignees{/user}","branches_url":"https://api.github.com/repos/OpenModelica/OMCompiler/branches{/branch}","tags_url":"https://api.github.com/repos/OpenModelica/OMCompiler/tags","blobs_url":"https://api.github.com/repos/OpenModelica/OMCompiler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenModelica/OMCompiler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenModelica/OMCompiler/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenModelica/OMCompiler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenModelica/OMCompiler/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenModelica/OMCompiler/languages","stargazers_url":"https://api.github.com/repos/OpenModelica/OMCompiler/stargazers","contributors_url":"https://api.github.com/repos/OpenModelica/OMCompiler/contributors","subscribers_url":"https://api.github.com/repos/OpenModelica/OMCompiler/subscribers","subscription_url":"https://api.github.com/repos/OpenModelica/OMCompiler/subscription","commits_url":"https://api.github.com/repos/OpenModelica/OMCompiler/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenModelica/OMCompiler/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenModelica/OMCompiler/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenModelica/OMCompiler/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenModelica/OMCompiler/contents/{+path}","compare_url":"https://api.github.com/repos/OpenModelica/OMCompiler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenModelica/OMCompiler/merges","archive_url":"https://api.github.com/repos/OpenModelica/OMCompiler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenModelica/OMCompiler/downloads","issues_url":"https://api.github.com/repos/OpenModelica/OMCompiler/issues{/number}","pulls_url":"https://api.github.com/repos/OpenModelica/OMCompiler/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenModelica/OMCompiler/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenModelica/OMCompiler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenModelica/OMCompiler/labels{/name}","releases_url":"https://api.github.com/repos/OpenModelica/OMCompiler/releases{/id}","deployments_url":"https://api.github.com/repos/OpenModelica/OMCompiler/deployments","created_at":"2015-05-04T04:53:52Z","updated_at":"2016-09-16T18:33:17Z","pushed_at":"2016-09-28T12:10:06Z","git_url":"git://github.com/OpenModelica/OMCompiler.git","ssh_url":"git@github.com:OpenModelica/OMCompiler.git","clone_url":"https://github.com/OpenModelica/OMCompiler.git","svn_url":"https://github.com/OpenModelica/OMCompiler","homepage":"https://trac.openmodelica.org/OpenModelica","size":69463,"stargazers_count":14,"watchers_count":14,"language":"Modelica","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":39,"mirror_url":null,"open_issues_count":12,"forks":39,"open_issues":12,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenModelica/OMCompiler/pulls/1087"},"html":{"href":"https://github.com/OpenModelica/OMCompiler/pull/1087"},"issue":{"href":"https://api.github.com/repos/OpenModelica/OMCompiler/issues/1087"},"comments":{"href":"https://api.github.com/repos/OpenModelica/OMCompiler/issues/1087/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenModelica/OMCompiler/pulls/1087/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenModelica/OMCompiler/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenModelica/OMCompiler/pulls/1087/commits"},"statuses":{"href":"https://api.github.com/repos/OpenModelica/OMCompiler/statuses/e4eee95ef040ced23358e51f2c89ae0bbce2be05"}}}}
{"actor":{"display_login":"lochel"}}