{"action":"created","comment":{"url":"https://api.github.com/repos/coreos/rkt/pulls/comments/67867727","id":67867727,"diff_hunk":"@@ -81,6 +84,7 @@ func init() {\n \tcmdRun.Flags().BoolVar(&flagNoOverlay, \"no-overlay\", false, \"disable overlay filesystem\")\n \tcmdRun.Flags().BoolVar(&flagPrivateUsers, \"private-users\", false, \"run within user namespaces.\")\n \tcmdRun.Flags().Var(&flagExplicitEnv, \"set-env\", \"environment variable to set for apps in the form name=value\")\n+\tcmdRun.Flags().Var(&flagEnvFromFile, \"set-env-file\", \"path to an environment variables file.\")","path":"rkt/run.go","position":22,"original_position":22,"commit_id":"cac74de35f4220f9c31ae1e485a1911762d79724","original_commit_id":"cac74de35f4220f9c31ae1e485a1911762d79724","user":{"login":"alban","id":27575,"avatar_url":"https://avatars.githubusercontent.com/u/27575?v=3","gravatar_id":"","url":"https://api.github.com/users/alban","html_url":"https://github.com/alban","followers_url":"https://api.github.com/users/alban/followers","following_url":"https://api.github.com/users/alban/following{/other_user}","gists_url":"https://api.github.com/users/alban/gists{/gist_id}","starred_url":"https://api.github.com/users/alban/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alban/subscriptions","organizations_url":"https://api.github.com/users/alban/orgs","repos_url":"https://api.github.com/users/alban/repos","events_url":"https://api.github.com/users/alban/events{/privacy}","received_events_url":"https://api.github.com/users/alban/received_events","type":"User","site_admin":false},"body":"To stay consistent, the help string should not finish with a dot.\r\n\r\nI see that --interactive and --private-users have a dot. To fix in another PR?","created_at":"2016-06-21T13:30:53Z","updated_at":"2016-06-21T13:30:53Z","html_url":"https://github.com/coreos/rkt/pull/2816#discussion_r67867727","pull_request_url":"https://api.github.com/repos/coreos/rkt/pulls/2816","_links":{"self":{"href":"https://api.github.com/repos/coreos/rkt/pulls/comments/67867727"},"html":{"href":"https://github.com/coreos/rkt/pull/2816#discussion_r67867727"},"pull_request":{"href":"https://api.github.com/repos/coreos/rkt/pulls/2816"}}},"pull_request":{"url":"https://api.github.com/repos/coreos/rkt/pulls/2816","id":74463974,"html_url":"https://github.com/coreos/rkt/pull/2816","diff_url":"https://github.com/coreos/rkt/pull/2816.diff","patch_url":"https://github.com/coreos/rkt/pull/2816.patch","issue_url":"https://api.github.com/repos/coreos/rkt/issues/2816","number":2816,"state":"open","locked":false,"title":"rkt/run: added --set-env-file switch and priorities for environments","user":{"login":"alepuccetti","id":6577391,"avatar_url":"https://avatars.githubusercontent.com/u/6577391?v=3","gravatar_id":"","url":"https://api.github.com/users/alepuccetti","html_url":"https://github.com/alepuccetti","followers_url":"https://api.github.com/users/alepuccetti/followers","following_url":"https://api.github.com/users/alepuccetti/following{/other_user}","gists_url":"https://api.github.com/users/alepuccetti/gists{/gist_id}","starred_url":"https://api.github.com/users/alepuccetti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alepuccetti/subscriptions","organizations_url":"https://api.github.com/users/alepuccetti/orgs","repos_url":"https://api.github.com/users/alepuccetti/repos","events_url":"https://api.github.com/users/alepuccetti/events{/privacy}","received_events_url":"https://api.github.com/users/alepuccetti/received_events","type":"User","site_admin":false},"body":"--set-env-file gets an environment variables file path in the format \"VAR=VALUE\\n...\".\r\nThis switch may be used multiple times on the command line to provide multiple\r\nenvironment files. When it used multiple times, it merges each environment file\r\nin a single environment and it returns an error if the same variable is set multiple\r\ntimes (either in different files or in the same file).\r\n\r\nThis patch implements priorities among the various way to specify\r\nenvironment variables, from highest to least priority:\r\n1. Command line (--set-env)\r\n2. From files (--set-env-file)\r\n3. Image Manifest\r\n4. Inherit (--inherit-env)\r\nA variable in a group with an higher priority will override the value\r\nof a variable with the same name in groups with lower priority without\r\nproducing any error. Variables with unique names will be always preserved.\r\n\r\nFixes https://github.com/coreos/rkt/issues/647","created_at":"2016-06-20T15:35:51Z","updated_at":"2016-06-21T13:30:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"50a8c758016cf23240cfed4910b4361a852b947f","assignee":null,"milestone":{"url":"https://api.github.com/repos/coreos/rkt/milestones/41","html_url":"https://github.com/coreos/rkt/milestones/v1.9.0","labels_url":"https://api.github.com/repos/coreos/rkt/milestones/41/labels","id":1782386,"number":41,"title":"v1.9.0","description":"","creator":{"login":"jonboulle","id":2601015,"avatar_url":"https://avatars.githubusercontent.com/u/2601015?v=3","gravatar_id":"","url":"https://api.github.com/users/jonboulle","html_url":"https://github.com/jonboulle","followers_url":"https://api.github.com/users/jonboulle/followers","following_url":"https://api.github.com/users/jonboulle/following{/other_user}","gists_url":"https://api.github.com/users/jonboulle/gists{/gist_id}","starred_url":"https://api.github.com/users/jonboulle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonboulle/subscriptions","organizations_url":"https://api.github.com/users/jonboulle/orgs","repos_url":"https://api.github.com/users/jonboulle/repos","events_url":"https://api.github.com/users/jonboulle/events{/privacy}","received_events_url":"https://api.github.com/users/jonboulle/received_events","type":"User","site_admin":false},"open_issues":42,"closed_issues":36,"state":"open","created_at":"2016-05-23T10:26:08Z","updated_at":"2016-06-21T13:12:01Z","due_on":"2016-06-22T22:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/coreos/rkt/pulls/2816/commits","review_comments_url":"https://api.github.com/repos/coreos/rkt/pulls/2816/comments","review_comment_url":"https://api.github.com/repos/coreos/rkt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coreos/rkt/issues/2816/comments","statuses_url":"https://api.github.com/repos/coreos/rkt/statuses/cac74de35f4220f9c31ae1e485a1911762d79724","head":{"label":"kinvolk:alessandro/env-vars","ref":"alessandro/env-vars","sha":"cac74de35f4220f9c31ae1e485a1911762d79724","user":{"login":"kinvolk","id":14073052,"avatar_url":"https://avatars.githubusercontent.com/u/14073052?v=3","gravatar_id":"","url":"https://api.github.com/users/kinvolk","html_url":"https://github.com/kinvolk","followers_url":"https://api.github.com/users/kinvolk/followers","following_url":"https://api.github.com/users/kinvolk/following{/other_user}","gists_url":"https://api.github.com/users/kinvolk/gists{/gist_id}","starred_url":"https://api.github.com/users/kinvolk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kinvolk/subscriptions","organizations_url":"https://api.github.com/users/kinvolk/orgs","repos_url":"https://api.github.com/users/kinvolk/repos","events_url":"https://api.github.com/users/kinvolk/events{/privacy}","received_events_url":"https://api.github.com/users/kinvolk/received_events","type":"Organization","site_admin":false},"repo":{"id":45149715,"name":"rkt","full_name":"kinvolk/rkt","owner":{"login":"kinvolk","id":14073052,"avatar_url":"https://avatars.githubusercontent.com/u/14073052?v=3","gravatar_id":"","url":"https://api.github.com/users/kinvolk","html_url":"https://github.com/kinvolk","followers_url":"https://api.github.com/users/kinvolk/followers","following_url":"https://api.github.com/users/kinvolk/following{/other_user}","gists_url":"https://api.github.com/users/kinvolk/gists{/gist_id}","starred_url":"https://api.github.com/users/kinvolk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kinvolk/subscriptions","organizations_url":"https://api.github.com/users/kinvolk/orgs","repos_url":"https://api.github.com/users/kinvolk/repos","events_url":"https://api.github.com/users/kinvolk/events{/privacy}","received_events_url":"https://api.github.com/users/kinvolk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kinvolk/rkt","description":"rkt is an App Container runtime for Linux","fork":true,"url":"https://api.github.com/repos/kinvolk/rkt","forks_url":"https://api.github.com/repos/kinvolk/rkt/forks","keys_url":"https://api.github.com/repos/kinvolk/rkt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kinvolk/rkt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kinvolk/rkt/teams","hooks_url":"https://api.github.com/repos/kinvolk/rkt/hooks","issue_events_url":"https://api.github.com/repos/kinvolk/rkt/issues/events{/number}","events_url":"https://api.github.com/repos/kinvolk/rkt/events","assignees_url":"https://api.github.com/repos/kinvolk/rkt/assignees{/user}","branches_url":"https://api.github.com/repos/kinvolk/rkt/branches{/branch}","tags_url":"https://api.github.com/repos/kinvolk/rkt/tags","blobs_url":"https://api.github.com/repos/kinvolk/rkt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kinvolk/rkt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kinvolk/rkt/git/refs{/sha}","trees_url":"https://api.github.com/repos/kinvolk/rkt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kinvolk/rkt/statuses/{sha}","languages_url":"https://api.github.com/repos/kinvolk/rkt/languages","stargazers_url":"https://api.github.com/repos/kinvolk/rkt/stargazers","contributors_url":"https://api.github.com/repos/kinvolk/rkt/contributors","subscribers_url":"https://api.github.com/repos/kinvolk/rkt/subscribers","subscription_url":"https://api.github.com/repos/kinvolk/rkt/subscription","commits_url":"https://api.github.com/repos/kinvolk/rkt/commits{/sha}","git_commits_url":"https://api.github.com/repos/kinvolk/rkt/git/commits{/sha}","comments_url":"https://api.github.com/repos/kinvolk/rkt/comments{/number}","issue_comment_url":"https://api.github.com/repos/kinvolk/rkt/issues/comments{/number}","contents_url":"https://api.github.com/repos/kinvolk/rkt/contents/{+path}","compare_url":"https://api.github.com/repos/kinvolk/rkt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kinvolk/rkt/merges","archive_url":"https://api.github.com/repos/kinvolk/rkt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kinvolk/rkt/downloads","issues_url":"https://api.github.com/repos/kinvolk/rkt/issues{/number}","pulls_url":"https://api.github.com/repos/kinvolk/rkt/pulls{/number}","milestones_url":"https://api.github.com/repos/kinvolk/rkt/milestones{/number}","notifications_url":"https://api.github.com/repos/kinvolk/rkt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kinvolk/rkt/labels{/name}","releases_url":"https://api.github.com/repos/kinvolk/rkt/releases{/id}","deployments_url":"https://api.github.com/repos/kinvolk/rkt/deployments","created_at":"2015-10-29T00:17:06Z","updated_at":"2016-06-06T12:54:39Z","pushed_at":"2016-06-21T10:01:51Z","git_url":"git://github.com/kinvolk/rkt.git","ssh_url":"git@github.com:kinvolk/rkt.git","clone_url":"https://github.com/kinvolk/rkt.git","svn_url":"https://github.com/kinvolk/rkt","homepage":"","size":22223,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"coreos:master","ref":"master","sha":"f4f5380e1d6497fadd504e7483aab7978cdd4122","user":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"repo":{"id":26509369,"name":"rkt","full_name":"coreos/rkt","owner":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coreos/rkt","description":"rkt is an App Container runtime for Linux","fork":false,"url":"https://api.github.com/repos/coreos/rkt","forks_url":"https://api.github.com/repos/coreos/rkt/forks","keys_url":"https://api.github.com/repos/coreos/rkt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coreos/rkt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coreos/rkt/teams","hooks_url":"https://api.github.com/repos/coreos/rkt/hooks","issue_events_url":"https://api.github.com/repos/coreos/rkt/issues/events{/number}","events_url":"https://api.github.com/repos/coreos/rkt/events","assignees_url":"https://api.github.com/repos/coreos/rkt/assignees{/user}","branches_url":"https://api.github.com/repos/coreos/rkt/branches{/branch}","tags_url":"https://api.github.com/repos/coreos/rkt/tags","blobs_url":"https://api.github.com/repos/coreos/rkt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coreos/rkt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coreos/rkt/git/refs{/sha}","trees_url":"https://api.github.com/repos/coreos/rkt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coreos/rkt/statuses/{sha}","languages_url":"https://api.github.com/repos/coreos/rkt/languages","stargazers_url":"https://api.github.com/repos/coreos/rkt/stargazers","contributors_url":"https://api.github.com/repos/coreos/rkt/contributors","subscribers_url":"https://api.github.com/repos/coreos/rkt/subscribers","subscription_url":"https://api.github.com/repos/coreos/rkt/subscription","commits_url":"https://api.github.com/repos/coreos/rkt/commits{/sha}","git_commits_url":"https://api.github.com/repos/coreos/rkt/git/commits{/sha}","comments_url":"https://api.github.com/repos/coreos/rkt/comments{/number}","issue_comment_url":"https://api.github.com/repos/coreos/rkt/issues/comments{/number}","contents_url":"https://api.github.com/repos/coreos/rkt/contents/{+path}","compare_url":"https://api.github.com/repos/coreos/rkt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coreos/rkt/merges","archive_url":"https://api.github.com/repos/coreos/rkt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coreos/rkt/downloads","issues_url":"https://api.github.com/repos/coreos/rkt/issues{/number}","pulls_url":"https://api.github.com/repos/coreos/rkt/pulls{/number}","milestones_url":"https://api.github.com/repos/coreos/rkt/milestones{/number}","notifications_url":"https://api.github.com/repos/coreos/rkt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coreos/rkt/labels{/name}","releases_url":"https://api.github.com/repos/coreos/rkt/releases{/id}","deployments_url":"https://api.github.com/repos/coreos/rkt/deployments","created_at":"2014-11-11T23:13:18Z","updated_at":"2016-06-21T13:00:00Z","pushed_at":"2016-06-21T13:12:02Z","git_url":"git://github.com/coreos/rkt.git","ssh_url":"git@github.com:coreos/rkt.git","clone_url":"https://github.com/coreos/rkt.git","svn_url":"https://github.com/coreos/rkt","homepage":"","size":28307,"stargazers_count":5628,"watchers_count":5628,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":530,"mirror_url":null,"open_issues_count":334,"forks":530,"open_issues":334,"watchers":5628,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coreos/rkt/pulls/2816"},"html":{"href":"https://github.com/coreos/rkt/pull/2816"},"issue":{"href":"https://api.github.com/repos/coreos/rkt/issues/2816"},"comments":{"href":"https://api.github.com/repos/coreos/rkt/issues/2816/comments"},"review_comments":{"href":"https://api.github.com/repos/coreos/rkt/pulls/2816/comments"},"review_comment":{"href":"https://api.github.com/repos/coreos/rkt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coreos/rkt/pulls/2816/commits"},"statuses":{"href":"https://api.github.com/repos/coreos/rkt/statuses/cac74de35f4220f9c31ae1e485a1911762d79724"}}}}
{"actor":{"display_login":"alban"}}