{"action":"created","issue":{"url":"https://api.github.com/repos/ethereum/go-ethereum/issues/3158","repository_url":"https://api.github.com/repos/ethereum/go-ethereum","labels_url":"https://api.github.com/repos/ethereum/go-ethereum/issues/3158/labels{/name}","comments_url":"https://api.github.com/repos/ethereum/go-ethereum/issues/3158/comments","events_url":"https://api.github.com/repos/ethereum/go-ethereum/issues/3158/events","html_url":"https://github.com/ethereum/go-ethereum/pull/3158","id":183620159,"number":3158,"title":"common, core, eth/downloader: adjust import log formatting","user":{"login":"karalabe","id":129561,"avatar_url":"https://avatars.githubusercontent.com/u/129561?v=3","gravatar_id":"","url":"https://api.github.com/users/karalabe","html_url":"https://github.com/karalabe","followers_url":"https://api.github.com/users/karalabe/followers","following_url":"https://api.github.com/users/karalabe/following{/other_user}","gists_url":"https://api.github.com/users/karalabe/gists{/gist_id}","starred_url":"https://api.github.com/users/karalabe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karalabe/subscriptions","organizations_url":"https://api.github.com/users/karalabe/orgs","repos_url":"https://api.github.com/users/karalabe/repos","events_url":"https://api.github.com/users/karalabe/events{/privacy}","received_events_url":"https://api.github.com/users/karalabe/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-10-18T08:24:33Z","updated_at":"2016-10-18T08:24:35Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ethereum/go-ethereum/pulls/3158","html_url":"https://github.com/ethereum/go-ethereum/pull/3158","diff_url":"https://github.com/ethereum/go-ethereum/pull/3158.diff","patch_url":"https://github.com/ethereum/go-ethereum/pull/3158.patch"},"body":"This PR adjust the `import xxx` log lines a bit:\r\n\r\n * Introduces a `commin.PrettyDuration` type that serializes with 2 decimal precision, not the crazy 9 version of the stock Go.\r\n * Transaction counts are expanded to 5 digits to cater for aligned import logs during syncs.\r\n * Time values are expanded to 8 characters to again cater for aligned import logs during syncs.\r\n\r\nIn addition, the PR drops part of a previously added feature which printed an import log after every `1025` blocks (yes, 1025 :P). The reason why this is not needed is because we import in batches of 2048 anyway, so those are always printed and the 8sec print timeout still in place should be enough to show progress. (Removing it also results in cleaner logs when import batches are not multiples of 1025 ( :P ), like during import from a dumped chain)."},"comment":{"url":"https://api.github.com/repos/ethereum/go-ethereum/issues/comments/254440343","html_url":"https://github.com/ethereum/go-ethereum/pull/3158#issuecomment-254440343","issue_url":"https://api.github.com/repos/ethereum/go-ethereum/issues/3158","id":254440343,"user":{"login":"mention-bot","id":15710697,"avatar_url":"https://avatars.githubusercontent.com/u/15710697?v=3","gravatar_id":"","url":"https://api.github.com/users/mention-bot","html_url":"https://github.com/mention-bot","followers_url":"https://api.github.com/users/mention-bot/followers","following_url":"https://api.github.com/users/mention-bot/following{/other_user}","gists_url":"https://api.github.com/users/mention-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/mention-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mention-bot/subscriptions","organizations_url":"https://api.github.com/users/mention-bot/orgs","repos_url":"https://api.github.com/users/mention-bot/repos","events_url":"https://api.github.com/users/mention-bot/events{/privacy}","received_events_url":"https://api.github.com/users/mention-bot/received_events","type":"User","site_admin":false},"created_at":"2016-10-18T08:24:35Z","updated_at":"2016-10-18T08:24:35Z","body":"@karalabe, thanks for your PR! By analyzing the history of the files in this pull request, we identified @fjl, @zsfelfoldi and @obscuren to be potential reviewers."}}
{"actor":{"display_login":"mention-bot"}}