{"action":"created","comment":{"url":"https://api.github.com/repos/qubole/qds-sdk-java/pulls/comments/82341350","pull_request_review_id":3256168,"id":82341350,"diff_hunk":"@@ -56,10 +57,11 @@\n     private final DbTapApiImpl dbTapsApi;\n     private final ReportApiImpl reportApi;\n     private final SchedulerApiImpl schedulerApi;\n+    private final AppApiImpl appApi;\n \n     private static final ObjectMapper MAPPER = new ObjectMapper();\n \n-    static ObjectMapper getMapper()\n+    public static ObjectMapper getMapper()","path":"src/main/java/com/qubole/qds/sdk/java/details/QdsClientImpl.java","position":27,"original_position":27,"commit_id":"54062f9742b928f648f4a6709a52eecf658c9bed","original_commit_id":"26ca70b1c6d6a69c52a2567449bc87d23aa38322","user":{"login":"amoghmargoor","id":12805533,"avatar_url":"https://avatars.githubusercontent.com/u/12805533?v=3","gravatar_id":"","url":"https://api.github.com/users/amoghmargoor","html_url":"https://github.com/amoghmargoor","followers_url":"https://api.github.com/users/amoghmargoor/followers","following_url":"https://api.github.com/users/amoghmargoor/following{/other_user}","gists_url":"https://api.github.com/users/amoghmargoor/gists{/gist_id}","starred_url":"https://api.github.com/users/amoghmargoor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amoghmargoor/subscriptions","organizations_url":"https://api.github.com/users/amoghmargoor/orgs","repos_url":"https://api.github.com/users/amoghmargoor/repos","events_url":"https://api.github.com/users/amoghmargoor/events{/privacy}","received_events_url":"https://api.github.com/users/amoghmargoor/received_events","type":"User","site_admin":false},"body":"Ok actually my question was why is even being shared as there can be threading issues. But looks like ObjectMapper is safe and can be shared across different threads., so thats fine.","created_at":"2016-10-07T07:35:13Z","updated_at":"2016-10-07T07:35:13Z","html_url":"https://github.com/qubole/qds-sdk-java/pull/52#discussion_r82341350","pull_request_url":"https://api.github.com/repos/qubole/qds-sdk-java/pulls/52","_links":{"self":{"href":"https://api.github.com/repos/qubole/qds-sdk-java/pulls/comments/82341350"},"html":{"href":"https://github.com/qubole/qds-sdk-java/pull/52#discussion_r82341350"},"pull_request":{"href":"https://api.github.com/repos/qubole/qds-sdk-java/pulls/52"}}},"pull_request":{"url":"https://api.github.com/repos/qubole/qds-sdk-java/pulls/52","id":50603257,"html_url":"https://github.com/qubole/qds-sdk-java/pull/52","diff_url":"https://github.com/qubole/qds-sdk-java/pull/52.diff","patch_url":"https://github.com/qubole/qds-sdk-java/pull/52.patch","issue_url":"https://api.github.com/repos/qubole/qds-sdk-java/issues/52","number":52,"state":"open","locked":false,"title":"SDK-56: Java SDK support for Spark Job Server","user":{"login":"abhisheksr8","id":3108843,"avatar_url":"https://avatars.githubusercontent.com/u/3108843?v=3","gravatar_id":"","url":"https://api.github.com/users/abhisheksr8","html_url":"https://github.com/abhisheksr8","followers_url":"https://api.github.com/users/abhisheksr8/followers","following_url":"https://api.github.com/users/abhisheksr8/following{/other_user}","gists_url":"https://api.github.com/users/abhisheksr8/gists{/gist_id}","starred_url":"https://api.github.com/users/abhisheksr8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abhisheksr8/subscriptions","organizations_url":"https://api.github.com/users/abhisheksr8/orgs","repos_url":"https://api.github.com/users/abhisheksr8/repos","events_url":"https://api.github.com/users/abhisheksr8/events{/privacy}","received_events_url":"https://api.github.com/users/abhisheksr8/received_events","type":"User","site_admin":false},"body":"Support for spark job server","created_at":"2015-11-13T04:22:36Z","updated_at":"2016-10-07T07:35:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d7db075b7f2dfac74427b6ef7dee0be846dee730","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/qubole/qds-sdk-java/pulls/52/commits","review_comments_url":"https://api.github.com/repos/qubole/qds-sdk-java/pulls/52/comments","review_comment_url":"https://api.github.com/repos/qubole/qds-sdk-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/qubole/qds-sdk-java/issues/52/comments","statuses_url":"https://api.github.com/repos/qubole/qds-sdk-java/statuses/54062f9742b928f648f4a6709a52eecf658c9bed","head":{"label":"abhisheksr8:SDK-56","ref":"SDK-56","sha":"54062f9742b928f648f4a6709a52eecf658c9bed","user":{"login":"abhisheksr8","id":3108843,"avatar_url":"https://avatars.githubusercontent.com/u/3108843?v=3","gravatar_id":"","url":"https://api.github.com/users/abhisheksr8","html_url":"https://github.com/abhisheksr8","followers_url":"https://api.github.com/users/abhisheksr8/followers","following_url":"https://api.github.com/users/abhisheksr8/following{/other_user}","gists_url":"https://api.github.com/users/abhisheksr8/gists{/gist_id}","starred_url":"https://api.github.com/users/abhisheksr8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abhisheksr8/subscriptions","organizations_url":"https://api.github.com/users/abhisheksr8/orgs","repos_url":"https://api.github.com/users/abhisheksr8/repos","events_url":"https://api.github.com/users/abhisheksr8/events{/privacy}","received_events_url":"https://api.github.com/users/abhisheksr8/received_events","type":"User","site_admin":false},"repo":{"id":43794515,"name":"qds-sdk-java","full_name":"abhisheksr8/qds-sdk-java","owner":{"login":"abhisheksr8","id":3108843,"avatar_url":"https://avatars.githubusercontent.com/u/3108843?v=3","gravatar_id":"","url":"https://api.github.com/users/abhisheksr8","html_url":"https://github.com/abhisheksr8","followers_url":"https://api.github.com/users/abhisheksr8/followers","following_url":"https://api.github.com/users/abhisheksr8/following{/other_user}","gists_url":"https://api.github.com/users/abhisheksr8/gists{/gist_id}","starred_url":"https://api.github.com/users/abhisheksr8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abhisheksr8/subscriptions","organizations_url":"https://api.github.com/users/abhisheksr8/orgs","repos_url":"https://api.github.com/users/abhisheksr8/repos","events_url":"https://api.github.com/users/abhisheksr8/events{/privacy}","received_events_url":"https://api.github.com/users/abhisheksr8/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/abhisheksr8/qds-sdk-java","description":"A Java library that provides the tools you need to authenticate with, and use the Qubole Data Service API.","fork":true,"url":"https://api.github.com/repos/abhisheksr8/qds-sdk-java","forks_url":"https://api.github.com/repos/abhisheksr8/qds-sdk-java/forks","keys_url":"https://api.github.com/repos/abhisheksr8/qds-sdk-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/abhisheksr8/qds-sdk-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/abhisheksr8/qds-sdk-java/teams","hooks_url":"https://api.github.com/repos/abhisheksr8/qds-sdk-java/hooks","issue_events_url":"https://api.github.com/repos/abhisheksr8/qds-sdk-java/issues/events{/number}","events_url":"https://api.github.com/repos/abhisheksr8/qds-sdk-java/events","assignees_url":"https://api.github.com/repos/abhisheksr8/qds-sdk-java/assignees{/user}","branches_url":"https://api.github.com/repos/abhisheksr8/qds-sdk-java/branches{/branch}","tags_url":"https://api.github.com/repos/abhisheksr8/qds-sdk-java/tags","blobs_url":"https://api.github.com/repos/abhisheksr8/qds-sdk-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/abhisheksr8/qds-sdk-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/abhisheksr8/qds-sdk-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/abhisheksr8/qds-sdk-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/abhisheksr8/qds-sdk-java/statuses/{sha}","languages_url":"https://api.github.com/repos/abhisheksr8/qds-sdk-java/languages","stargazers_url":"https://api.github.com/repos/abhisheksr8/qds-sdk-java/stargazers","contributors_url":"https://api.github.com/repos/abhisheksr8/qds-sdk-java/contributors","subscribers_url":"https://api.github.com/repos/abhisheksr8/qds-sdk-java/subscribers","subscription_url":"https://api.github.com/repos/abhisheksr8/qds-sdk-java/subscription","commits_url":"https://api.github.com/repos/abhisheksr8/qds-sdk-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/abhisheksr8/qds-sdk-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/abhisheksr8/qds-sdk-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/abhisheksr8/qds-sdk-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/abhisheksr8/qds-sdk-java/contents/{+path}","compare_url":"https://api.github.com/repos/abhisheksr8/qds-sdk-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/abhisheksr8/qds-sdk-java/merges","archive_url":"https://api.github.com/repos/abhisheksr8/qds-sdk-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/abhisheksr8/qds-sdk-java/downloads","issues_url":"https://api.github.com/repos/abhisheksr8/qds-sdk-java/issues{/number}","pulls_url":"https://api.github.com/repos/abhisheksr8/qds-sdk-java/pulls{/number}","milestones_url":"https://api.github.com/repos/abhisheksr8/qds-sdk-java/milestones{/number}","notifications_url":"https://api.github.com/repos/abhisheksr8/qds-sdk-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/abhisheksr8/qds-sdk-java/labels{/name}","releases_url":"https://api.github.com/repos/abhisheksr8/qds-sdk-java/releases{/id}","deployments_url":"https://api.github.com/repos/abhisheksr8/qds-sdk-java/deployments","created_at":"2015-10-07T04:11:44Z","updated_at":"2016-04-24T04:30:56Z","pushed_at":"2016-10-07T06:59:10Z","git_url":"git://github.com/abhisheksr8/qds-sdk-java.git","ssh_url":"git@github.com:abhisheksr8/qds-sdk-java.git","clone_url":"https://github.com/abhisheksr8/qds-sdk-java.git","svn_url":"https://github.com/abhisheksr8/qds-sdk-java","homepage":"https://api.qubole.com","size":2125,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"qubole:master","ref":"master","sha":"2fa21c558614d3119d7630fa3caf8d9190f749a8","user":{"login":"qubole","id":1259448,"avatar_url":"https://avatars.githubusercontent.com/u/1259448?v=3","gravatar_id":"","url":"https://api.github.com/users/qubole","html_url":"https://github.com/qubole","followers_url":"https://api.github.com/users/qubole/followers","following_url":"https://api.github.com/users/qubole/following{/other_user}","gists_url":"https://api.github.com/users/qubole/gists{/gist_id}","starred_url":"https://api.github.com/users/qubole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qubole/subscriptions","organizations_url":"https://api.github.com/users/qubole/orgs","repos_url":"https://api.github.com/users/qubole/repos","events_url":"https://api.github.com/users/qubole/events{/privacy}","received_events_url":"https://api.github.com/users/qubole/received_events","type":"Organization","site_admin":false},"repo":{"id":18344410,"name":"qds-sdk-java","full_name":"qubole/qds-sdk-java","owner":{"login":"qubole","id":1259448,"avatar_url":"https://avatars.githubusercontent.com/u/1259448?v=3","gravatar_id":"","url":"https://api.github.com/users/qubole","html_url":"https://github.com/qubole","followers_url":"https://api.github.com/users/qubole/followers","following_url":"https://api.github.com/users/qubole/following{/other_user}","gists_url":"https://api.github.com/users/qubole/gists{/gist_id}","starred_url":"https://api.github.com/users/qubole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qubole/subscriptions","organizations_url":"https://api.github.com/users/qubole/orgs","repos_url":"https://api.github.com/users/qubole/repos","events_url":"https://api.github.com/users/qubole/events{/privacy}","received_events_url":"https://api.github.com/users/qubole/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/qubole/qds-sdk-java","description":"A Java library that provides the tools you need to authenticate with, and use the Qubole Data Service API.","fork":false,"url":"https://api.github.com/repos/qubole/qds-sdk-java","forks_url":"https://api.github.com/repos/qubole/qds-sdk-java/forks","keys_url":"https://api.github.com/repos/qubole/qds-sdk-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qubole/qds-sdk-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qubole/qds-sdk-java/teams","hooks_url":"https://api.github.com/repos/qubole/qds-sdk-java/hooks","issue_events_url":"https://api.github.com/repos/qubole/qds-sdk-java/issues/events{/number}","events_url":"https://api.github.com/repos/qubole/qds-sdk-java/events","assignees_url":"https://api.github.com/repos/qubole/qds-sdk-java/assignees{/user}","branches_url":"https://api.github.com/repos/qubole/qds-sdk-java/branches{/branch}","tags_url":"https://api.github.com/repos/qubole/qds-sdk-java/tags","blobs_url":"https://api.github.com/repos/qubole/qds-sdk-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qubole/qds-sdk-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qubole/qds-sdk-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/qubole/qds-sdk-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qubole/qds-sdk-java/statuses/{sha}","languages_url":"https://api.github.com/repos/qubole/qds-sdk-java/languages","stargazers_url":"https://api.github.com/repos/qubole/qds-sdk-java/stargazers","contributors_url":"https://api.github.com/repos/qubole/qds-sdk-java/contributors","subscribers_url":"https://api.github.com/repos/qubole/qds-sdk-java/subscribers","subscription_url":"https://api.github.com/repos/qubole/qds-sdk-java/subscription","commits_url":"https://api.github.com/repos/qubole/qds-sdk-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/qubole/qds-sdk-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/qubole/qds-sdk-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/qubole/qds-sdk-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/qubole/qds-sdk-java/contents/{+path}","compare_url":"https://api.github.com/repos/qubole/qds-sdk-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qubole/qds-sdk-java/merges","archive_url":"https://api.github.com/repos/qubole/qds-sdk-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qubole/qds-sdk-java/downloads","issues_url":"https://api.github.com/repos/qubole/qds-sdk-java/issues{/number}","pulls_url":"https://api.github.com/repos/qubole/qds-sdk-java/pulls{/number}","milestones_url":"https://api.github.com/repos/qubole/qds-sdk-java/milestones{/number}","notifications_url":"https://api.github.com/repos/qubole/qds-sdk-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qubole/qds-sdk-java/labels{/name}","releases_url":"https://api.github.com/repos/qubole/qds-sdk-java/releases{/id}","deployments_url":"https://api.github.com/repos/qubole/qds-sdk-java/deployments","created_at":"2014-04-01T20:49:52Z","updated_at":"2016-04-05T15:48:07Z","pushed_at":"2016-10-07T07:24:41Z","git_url":"git://github.com/qubole/qds-sdk-java.git","ssh_url":"git@github.com:qubole/qds-sdk-java.git","clone_url":"https://github.com/qubole/qds-sdk-java.git","svn_url":"https://github.com/qubole/qds-sdk-java","homepage":"https://api.qubole.com","size":2394,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":28,"mirror_url":null,"open_issues_count":6,"forks":28,"open_issues":6,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/qubole/qds-sdk-java/pulls/52"},"html":{"href":"https://github.com/qubole/qds-sdk-java/pull/52"},"issue":{"href":"https://api.github.com/repos/qubole/qds-sdk-java/issues/52"},"comments":{"href":"https://api.github.com/repos/qubole/qds-sdk-java/issues/52/comments"},"review_comments":{"href":"https://api.github.com/repos/qubole/qds-sdk-java/pulls/52/comments"},"review_comment":{"href":"https://api.github.com/repos/qubole/qds-sdk-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/qubole/qds-sdk-java/pulls/52/commits"},"statuses":{"href":"https://api.github.com/repos/qubole/qds-sdk-java/statuses/54062f9742b928f648f4a6709a52eecf658c9bed"}}}}
{"actor":{"display_login":"amoghmargoor"}}