{"action":"created","comment":{"url":"https://api.github.com/repos/cambridgeweblab/common-ui/pulls/comments/91703386","pull_request_review_id":12213845,"id":91703386,"diff_hunk":"@@ -0,0 +1,34 @@\n+/* GENERIC WEB-COMPONENT OVERRIDES */\n+ca-treeview { display: inline-block; vertical-align: top; border-right: none !important; background-color: #E5E8EC; margin: 0; padding: 0.5em; position: absolute; box-sizing: border-box; width: 200px; }","path":"components/ca-treeview.css","position":2,"original_position":2,"commit_id":"fee6c9e08cc5fe7de5dbdb063abc6cfa835fe3b3","original_commit_id":"fee6c9e08cc5fe7de5dbdb063abc6cfa835fe3b3","user":{"login":"norisalsaadie","id":15940602,"avatar_url":"https://avatars.githubusercontent.com/u/15940602?v=3","gravatar_id":"","url":"https://api.github.com/users/norisalsaadie","html_url":"https://github.com/norisalsaadie","followers_url":"https://api.github.com/users/norisalsaadie/followers","following_url":"https://api.github.com/users/norisalsaadie/following{/other_user}","gists_url":"https://api.github.com/users/norisalsaadie/gists{/gist_id}","starred_url":"https://api.github.com/users/norisalsaadie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/norisalsaadie/subscriptions","organizations_url":"https://api.github.com/users/norisalsaadie/orgs","repos_url":"https://api.github.com/users/norisalsaadie/repos","events_url":"https://api.github.com/users/norisalsaadie/events{/privacy}","received_events_url":"https://api.github.com/users/norisalsaadie/received_events","type":"User","site_admin":false},"body":"Yep, my view as well. But this is a copy pasta. I'm less fussed about the CSS initially.","created_at":"2016-12-09T11:48:46Z","updated_at":"2016-12-09T11:48:47Z","html_url":"https://github.com/cambridgeweblab/common-ui/pull/5#discussion_r91703386","pull_request_url":"https://api.github.com/repos/cambridgeweblab/common-ui/pulls/5","_links":{"self":{"href":"https://api.github.com/repos/cambridgeweblab/common-ui/pulls/comments/91703386"},"html":{"href":"https://github.com/cambridgeweblab/common-ui/pull/5#discussion_r91703386"},"pull_request":{"href":"https://api.github.com/repos/cambridgeweblab/common-ui/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/cambridgeweblab/common-ui/pulls/5","id":97197493,"html_url":"https://github.com/cambridgeweblab/common-ui/pull/5","diff_url":"https://github.com/cambridgeweblab/common-ui/pull/5.diff","patch_url":"https://github.com/cambridgeweblab/common-ui/pull/5.patch","issue_url":"https://api.github.com/repos/cambridgeweblab/common-ui/issues/5","number":5,"state":"open","locked":false,"title":"CA TreeView","user":{"login":"norisalsaadie","id":15940602,"avatar_url":"https://avatars.githubusercontent.com/u/15940602?v=3","gravatar_id":"","url":"https://api.github.com/users/norisalsaadie","html_url":"https://github.com/norisalsaadie","followers_url":"https://api.github.com/users/norisalsaadie/followers","following_url":"https://api.github.com/users/norisalsaadie/following{/other_user}","gists_url":"https://api.github.com/users/norisalsaadie/gists{/gist_id}","starred_url":"https://api.github.com/users/norisalsaadie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/norisalsaadie/subscriptions","organizations_url":"https://api.github.com/users/norisalsaadie/orgs","repos_url":"https://api.github.com/users/norisalsaadie/repos","events_url":"https://api.github.com/users/norisalsaadie/events{/privacy}","received_events_url":"https://api.github.com/users/norisalsaadie/received_events","type":"User","site_admin":false},"body":"Migrating the ca-treeview web component to the common-UI project.\r\nThis required migrating Ajax and secure Ajax, as well as other components.\r\nFiles were updated against new linting rules, and where possible, logic change was avoided\r\n\r\nChanges:\r\n.eslintrc -> adding ajax as global until a better solution is found.\r\ncomponents/ca-treeview.css -> tree-view css from old private repo\r\ncomponents/ca-treeview.js -> tree-view from old private repo, migrated to ES6.\r\ncomponents/helpers/ajax.js -> moved and cleaned a little, no AMD module yet.\r\ncomponents/helpers/secureajax.js -> moved and cleaned a little, no AMD module yet.\r\ncomponents/helpers/cancel-event.js -> migrate from old helpers.js.\r\ncomponents/helpers/clear-element.js -> migrated from old helpers.js.\r\ncomponents/helpers/parent-by-attribute.js -> migrated from old helpers.js.\r\nexamples/ca-treeview.html -> moved example, had to use promises due to AMD.\r\ntest/ca-tree-view-test.html -> migrated the old tests and refactored.\r\ntest/helpers/cancel-event-test.html -> placeholder tests with TODO.\r\ntest/helpers/clear-element-test.html -> placeholder tests with TODO.\r\ntest/helpers/parent-by-attribute-test.html -> placeholder tests with TODO.","created_at":"2016-12-08T20:46:14Z","updated_at":"2016-12-09T11:48:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8df7dcfc40bb967c8b5376147c9b8418b5f4e348","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/cambridgeweblab/common-ui/pulls/5/commits","review_comments_url":"https://api.github.com/repos/cambridgeweblab/common-ui/pulls/5/comments","review_comment_url":"https://api.github.com/repos/cambridgeweblab/common-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cambridgeweblab/common-ui/issues/5/comments","statuses_url":"https://api.github.com/repos/cambridgeweblab/common-ui/statuses/fee6c9e08cc5fe7de5dbdb063abc6cfa835fe3b3","head":{"label":"cambridgeweblab:feature/tree-view","ref":"feature/tree-view","sha":"fee6c9e08cc5fe7de5dbdb063abc6cfa835fe3b3","user":{"login":"cambridgeweblab","id":21372192,"avatar_url":"https://avatars.githubusercontent.com/u/21372192?v=3","gravatar_id":"","url":"https://api.github.com/users/cambridgeweblab","html_url":"https://github.com/cambridgeweblab","followers_url":"https://api.github.com/users/cambridgeweblab/followers","following_url":"https://api.github.com/users/cambridgeweblab/following{/other_user}","gists_url":"https://api.github.com/users/cambridgeweblab/gists{/gist_id}","starred_url":"https://api.github.com/users/cambridgeweblab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cambridgeweblab/subscriptions","organizations_url":"https://api.github.com/users/cambridgeweblab/orgs","repos_url":"https://api.github.com/users/cambridgeweblab/repos","events_url":"https://api.github.com/users/cambridgeweblab/events{/privacy}","received_events_url":"https://api.github.com/users/cambridgeweblab/received_events","type":"Organization","site_admin":false},"repo":{"id":69026771,"name":"common-ui","full_name":"cambridgeweblab/common-ui","owner":{"login":"cambridgeweblab","id":21372192,"avatar_url":"https://avatars.githubusercontent.com/u/21372192?v=3","gravatar_id":"","url":"https://api.github.com/users/cambridgeweblab","html_url":"https://github.com/cambridgeweblab","followers_url":"https://api.github.com/users/cambridgeweblab/followers","following_url":"https://api.github.com/users/cambridgeweblab/following{/other_user}","gists_url":"https://api.github.com/users/cambridgeweblab/gists{/gist_id}","starred_url":"https://api.github.com/users/cambridgeweblab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cambridgeweblab/subscriptions","organizations_url":"https://api.github.com/users/cambridgeweblab/orgs","repos_url":"https://api.github.com/users/cambridgeweblab/repos","events_url":"https://api.github.com/users/cambridgeweblab/events{/privacy}","received_events_url":"https://api.github.com/users/cambridgeweblab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cambridgeweblab/common-ui","description":"A collection of common web components","fork":false,"url":"https://api.github.com/repos/cambridgeweblab/common-ui","forks_url":"https://api.github.com/repos/cambridgeweblab/common-ui/forks","keys_url":"https://api.github.com/repos/cambridgeweblab/common-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cambridgeweblab/common-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cambridgeweblab/common-ui/teams","hooks_url":"https://api.github.com/repos/cambridgeweblab/common-ui/hooks","issue_events_url":"https://api.github.com/repos/cambridgeweblab/common-ui/issues/events{/number}","events_url":"https://api.github.com/repos/cambridgeweblab/common-ui/events","assignees_url":"https://api.github.com/repos/cambridgeweblab/common-ui/assignees{/user}","branches_url":"https://api.github.com/repos/cambridgeweblab/common-ui/branches{/branch}","tags_url":"https://api.github.com/repos/cambridgeweblab/common-ui/tags","blobs_url":"https://api.github.com/repos/cambridgeweblab/common-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cambridgeweblab/common-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cambridgeweblab/common-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/cambridgeweblab/common-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cambridgeweblab/common-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/cambridgeweblab/common-ui/languages","stargazers_url":"https://api.github.com/repos/cambridgeweblab/common-ui/stargazers","contributors_url":"https://api.github.com/repos/cambridgeweblab/common-ui/contributors","subscribers_url":"https://api.github.com/repos/cambridgeweblab/common-ui/subscribers","subscription_url":"https://api.github.com/repos/cambridgeweblab/common-ui/subscription","commits_url":"https://api.github.com/repos/cambridgeweblab/common-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/cambridgeweblab/common-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/cambridgeweblab/common-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/cambridgeweblab/common-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/cambridgeweblab/common-ui/contents/{+path}","compare_url":"https://api.github.com/repos/cambridgeweblab/common-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cambridgeweblab/common-ui/merges","archive_url":"https://api.github.com/repos/cambridgeweblab/common-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cambridgeweblab/common-ui/downloads","issues_url":"https://api.github.com/repos/cambridgeweblab/common-ui/issues{/number}","pulls_url":"https://api.github.com/repos/cambridgeweblab/common-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/cambridgeweblab/common-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/cambridgeweblab/common-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cambridgeweblab/common-ui/labels{/name}","releases_url":"https://api.github.com/repos/cambridgeweblab/common-ui/releases{/id}","deployments_url":"https://api.github.com/repos/cambridgeweblab/common-ui/deployments","created_at":"2016-09-23T13:22:08Z","updated_at":"2016-10-13T09:37:02Z","pushed_at":"2016-12-09T10:36:01Z","git_url":"git://github.com/cambridgeweblab/common-ui.git","ssh_url":"git@github.com:cambridgeweblab/common-ui.git","clone_url":"https://github.com/cambridgeweblab/common-ui.git","svn_url":"https://github.com/cambridgeweblab/common-ui","homepage":null,"size":48,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"cambridgeweblab:master","ref":"master","sha":"d55f106cbd7a1cf3ad65165082fbd2b3ac4a0cb6","user":{"login":"cambridgeweblab","id":21372192,"avatar_url":"https://avatars.githubusercontent.com/u/21372192?v=3","gravatar_id":"","url":"https://api.github.com/users/cambridgeweblab","html_url":"https://github.com/cambridgeweblab","followers_url":"https://api.github.com/users/cambridgeweblab/followers","following_url":"https://api.github.com/users/cambridgeweblab/following{/other_user}","gists_url":"https://api.github.com/users/cambridgeweblab/gists{/gist_id}","starred_url":"https://api.github.com/users/cambridgeweblab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cambridgeweblab/subscriptions","organizations_url":"https://api.github.com/users/cambridgeweblab/orgs","repos_url":"https://api.github.com/users/cambridgeweblab/repos","events_url":"https://api.github.com/users/cambridgeweblab/events{/privacy}","received_events_url":"https://api.github.com/users/cambridgeweblab/received_events","type":"Organization","site_admin":false},"repo":{"id":69026771,"name":"common-ui","full_name":"cambridgeweblab/common-ui","owner":{"login":"cambridgeweblab","id":21372192,"avatar_url":"https://avatars.githubusercontent.com/u/21372192?v=3","gravatar_id":"","url":"https://api.github.com/users/cambridgeweblab","html_url":"https://github.com/cambridgeweblab","followers_url":"https://api.github.com/users/cambridgeweblab/followers","following_url":"https://api.github.com/users/cambridgeweblab/following{/other_user}","gists_url":"https://api.github.com/users/cambridgeweblab/gists{/gist_id}","starred_url":"https://api.github.com/users/cambridgeweblab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cambridgeweblab/subscriptions","organizations_url":"https://api.github.com/users/cambridgeweblab/orgs","repos_url":"https://api.github.com/users/cambridgeweblab/repos","events_url":"https://api.github.com/users/cambridgeweblab/events{/privacy}","received_events_url":"https://api.github.com/users/cambridgeweblab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cambridgeweblab/common-ui","description":"A collection of common web components","fork":false,"url":"https://api.github.com/repos/cambridgeweblab/common-ui","forks_url":"https://api.github.com/repos/cambridgeweblab/common-ui/forks","keys_url":"https://api.github.com/repos/cambridgeweblab/common-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cambridgeweblab/common-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cambridgeweblab/common-ui/teams","hooks_url":"https://api.github.com/repos/cambridgeweblab/common-ui/hooks","issue_events_url":"https://api.github.com/repos/cambridgeweblab/common-ui/issues/events{/number}","events_url":"https://api.github.com/repos/cambridgeweblab/common-ui/events","assignees_url":"https://api.github.com/repos/cambridgeweblab/common-ui/assignees{/user}","branches_url":"https://api.github.com/repos/cambridgeweblab/common-ui/branches{/branch}","tags_url":"https://api.github.com/repos/cambridgeweblab/common-ui/tags","blobs_url":"https://api.github.com/repos/cambridgeweblab/common-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cambridgeweblab/common-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cambridgeweblab/common-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/cambridgeweblab/common-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cambridgeweblab/common-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/cambridgeweblab/common-ui/languages","stargazers_url":"https://api.github.com/repos/cambridgeweblab/common-ui/stargazers","contributors_url":"https://api.github.com/repos/cambridgeweblab/common-ui/contributors","subscribers_url":"https://api.github.com/repos/cambridgeweblab/common-ui/subscribers","subscription_url":"https://api.github.com/repos/cambridgeweblab/common-ui/subscription","commits_url":"https://api.github.com/repos/cambridgeweblab/common-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/cambridgeweblab/common-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/cambridgeweblab/common-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/cambridgeweblab/common-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/cambridgeweblab/common-ui/contents/{+path}","compare_url":"https://api.github.com/repos/cambridgeweblab/common-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cambridgeweblab/common-ui/merges","archive_url":"https://api.github.com/repos/cambridgeweblab/common-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cambridgeweblab/common-ui/downloads","issues_url":"https://api.github.com/repos/cambridgeweblab/common-ui/issues{/number}","pulls_url":"https://api.github.com/repos/cambridgeweblab/common-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/cambridgeweblab/common-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/cambridgeweblab/common-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cambridgeweblab/common-ui/labels{/name}","releases_url":"https://api.github.com/repos/cambridgeweblab/common-ui/releases{/id}","deployments_url":"https://api.github.com/repos/cambridgeweblab/common-ui/deployments","created_at":"2016-09-23T13:22:08Z","updated_at":"2016-10-13T09:37:02Z","pushed_at":"2016-12-09T10:36:01Z","git_url":"git://github.com/cambridgeweblab/common-ui.git","ssh_url":"git@github.com:cambridgeweblab/common-ui.git","clone_url":"https://github.com/cambridgeweblab/common-ui.git","svn_url":"https://github.com/cambridgeweblab/common-ui","homepage":null,"size":48,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cambridgeweblab/common-ui/pulls/5"},"html":{"href":"https://github.com/cambridgeweblab/common-ui/pull/5"},"issue":{"href":"https://api.github.com/repos/cambridgeweblab/common-ui/issues/5"},"comments":{"href":"https://api.github.com/repos/cambridgeweblab/common-ui/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/cambridgeweblab/common-ui/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/cambridgeweblab/common-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cambridgeweblab/common-ui/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/cambridgeweblab/common-ui/statuses/fee6c9e08cc5fe7de5dbdb063abc6cfa835fe3b3"}}}}
{"actor":{"display_login":"norisalsaadie"}}