{"action":"created","issue":{"url":"https://api.github.com/repos/zeit/hyperterm/issues/204","repository_url":"https://api.github.com/repos/zeit/hyperterm","labels_url":"https://api.github.com/repos/zeit/hyperterm/issues/204/labels{/name}","comments_url":"https://api.github.com/repos/zeit/hyperterm/issues/204/comments","events_url":"https://api.github.com/repos/zeit/hyperterm/issues/204/events","html_url":"https://github.com/zeit/hyperterm/pull/204","id":165983575,"number":204,"title":"Config option to silence bell","user":{"login":"bekher","id":9370623,"avatar_url":"https://avatars.githubusercontent.com/u/9370623?v=3","gravatar_id":"","url":"https://api.github.com/users/bekher","html_url":"https://github.com/bekher","followers_url":"https://api.github.com/users/bekher/followers","following_url":"https://api.github.com/users/bekher/following{/other_user}","gists_url":"https://api.github.com/users/bekher/gists{/gist_id}","starred_url":"https://api.github.com/users/bekher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bekher/subscriptions","organizations_url":"https://api.github.com/users/bekher/orgs","repos_url":"https://api.github.com/users/bekher/repos","events_url":"https://api.github.com/users/bekher/events{/privacy}","received_events_url":"https://api.github.com/users/bekher/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-07-17T16:22:18Z","updated_at":"2016-07-25T22:02:03Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/zeit/hyperterm/pulls/204","html_url":"https://github.com/zeit/hyperterm/pull/204","diff_url":"https://github.com/zeit/hyperterm/pull/204.diff","patch_url":"https://github.com/zeit/hyperterm/pull/204.patch"},"body":"Add a config option `audibleBell` and handlers to silence the bell by muting hterm's bell audio. This is achieved by toggling `this.term.bellAudio_.muted` in app/lib/components/term.js. \r\n\r\nWe leave the bell on by default so users with out of date config files will not wonder where their bell audio went. \r\n\r\nCloses issue #125 "},"comment":{"url":"https://api.github.com/repos/zeit/hyperterm/issues/comments/235099804","html_url":"https://github.com/zeit/hyperterm/pull/204#issuecomment-235099804","issue_url":"https://api.github.com/repos/zeit/hyperterm/issues/204","id":235099804,"user":{"login":"albinekb","id":5027156,"avatar_url":"https://avatars.githubusercontent.com/u/5027156?v=3","gravatar_id":"","url":"https://api.github.com/users/albinekb","html_url":"https://github.com/albinekb","followers_url":"https://api.github.com/users/albinekb/followers","following_url":"https://api.github.com/users/albinekb/following{/other_user}","gists_url":"https://api.github.com/users/albinekb/gists{/gist_id}","starred_url":"https://api.github.com/users/albinekb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/albinekb/subscriptions","organizations_url":"https://api.github.com/users/albinekb/orgs","repos_url":"https://api.github.com/users/albinekb/repos","events_url":"https://api.github.com/users/albinekb/events{/privacy}","received_events_url":"https://api.github.com/users/albinekb/received_events","type":"User","site_admin":false},"created_at":"2016-07-25T22:02:03Z","updated_at":"2016-07-25T22:02:03Z","body":"Does it make sense to start grouping the settings? ex:\r\n\r\n```\r\nbell: {\r\n  path: 'lib-resource:hterm/audio/bell',\r\n  audible: true\r\n}\r\n```\r\n\r\nand later you could group window-settings etc, what do you think?\r\n\r\nProbably for another PR but why not start here 👼 "}}
{"actor":{"display_login":"albinekb"}}