{"action":"opened","number":1743,"pull_request":{"url":"https://api.github.com/repos/Homebrew/brew/pulls/1743","id":99579447,"html_url":"https://github.com/Homebrew/brew/pull/1743","diff_url":"https://github.com/Homebrew/brew/pull/1743.diff","patch_url":"https://github.com/Homebrew/brew/pull/1743.patch","issue_url":"https://api.github.com/repos/Homebrew/brew/issues/1743","number":1743,"state":"open","locked":false,"title":"Delete pkgutil directories that are really files.","user":{"login":"toonetown","id":97324,"avatar_url":"https://avatars.githubusercontent.com/u/97324?v=3","gravatar_id":"","url":"https://api.github.com/users/toonetown","html_url":"https://github.com/toonetown","followers_url":"https://api.github.com/users/toonetown/followers","following_url":"https://api.github.com/users/toonetown/following{/other_user}","gists_url":"https://api.github.com/users/toonetown/gists{/gist_id}","starred_url":"https://api.github.com/users/toonetown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toonetown/subscriptions","organizations_url":"https://api.github.com/users/toonetown/orgs","repos_url":"https://api.github.com/users/toonetown/repos","events_url":"https://api.github.com/users/toonetown/events{/privacy}","received_events_url":"https://api.github.com/users/toonetown/received_events","type":"User","site_admin":false},"body":"- [x] Have you followed the guidelines in our [Contributing](https://github.com/Homebrew/brew/blob/master/CONTRIBUTING.md) document?\r\n- [x] Have you checked to ensure there aren't other open [Pull Requests](https://github.com/Homebrew/brew/pulls) for the same change?\r\n- [x] Have you added an explanation of what your changes do and why you'd like us to include them?\r\n- [x] Have you written new tests for your changes? [Here's an example](https://github.com/Homebrew/homebrew/pull/49031).\r\n- [x] Have you successfully run `brew tests` with your changes locally?\r\n- [x] Have you successfully run `brew cask-tests` with your changes locally?\r\n\r\n-----\r\n\r\nSometimes, pkgutil will return actual files (usually .nib files) as if they were part of the directory.  Microsoft Office is an example of this: in a recent update the file `/Library/Application Support/Microsoft/MAU2.0/Microsoft AutoUpdate.app/Contents/SharedSupport/Microsoft Error Reporting.app/Contents/Resources/en.lproj/MainWindowAlt.nib` was returning from `/usr/sbin/pkgutil --only-dirs --files com.microsoft.package.component` even though it should have been a file instead of a directory.  This caused the `rmdir` command to fail.\r\n\r\nThis patch will check if we are trying to delete a “directory” that is really a “file” - and if we are, we just delete the file instead.  This will allow packages that get in this state to be uninstalled cleanly.\r\n","created_at":"2016-12-28T18:35:36Z","updated_at":"2016-12-28T18:35:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Homebrew/brew/pulls/1743/commits","review_comments_url":"https://api.github.com/repos/Homebrew/brew/pulls/1743/comments","review_comment_url":"https://api.github.com/repos/Homebrew/brew/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Homebrew/brew/issues/1743/comments","statuses_url":"https://api.github.com/repos/Homebrew/brew/statuses/d6bad843e7333806c280761831c35b8cf3eae6d5","head":{"label":"toonetown:robust-pkgutil-cleanup","ref":"robust-pkgutil-cleanup","sha":"d6bad843e7333806c280761831c35b8cf3eae6d5","user":{"login":"toonetown","id":97324,"avatar_url":"https://avatars.githubusercontent.com/u/97324?v=3","gravatar_id":"","url":"https://api.github.com/users/toonetown","html_url":"https://github.com/toonetown","followers_url":"https://api.github.com/users/toonetown/followers","following_url":"https://api.github.com/users/toonetown/following{/other_user}","gists_url":"https://api.github.com/users/toonetown/gists{/gist_id}","starred_url":"https://api.github.com/users/toonetown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toonetown/subscriptions","organizations_url":"https://api.github.com/users/toonetown/orgs","repos_url":"https://api.github.com/users/toonetown/repos","events_url":"https://api.github.com/users/toonetown/events{/privacy}","received_events_url":"https://api.github.com/users/toonetown/received_events","type":"User","site_admin":false},"repo":{"id":69301496,"name":"homebrew","full_name":"toonetown/homebrew","owner":{"login":"toonetown","id":97324,"avatar_url":"https://avatars.githubusercontent.com/u/97324?v=3","gravatar_id":"","url":"https://api.github.com/users/toonetown","html_url":"https://github.com/toonetown","followers_url":"https://api.github.com/users/toonetown/followers","following_url":"https://api.github.com/users/toonetown/following{/other_user}","gists_url":"https://api.github.com/users/toonetown/gists{/gist_id}","starred_url":"https://api.github.com/users/toonetown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toonetown/subscriptions","organizations_url":"https://api.github.com/users/toonetown/orgs","repos_url":"https://api.github.com/users/toonetown/repos","events_url":"https://api.github.com/users/toonetown/events{/privacy}","received_events_url":"https://api.github.com/users/toonetown/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/toonetown/homebrew","description":":beer: The missing package manager for macOS","fork":true,"url":"https://api.github.com/repos/toonetown/homebrew","forks_url":"https://api.github.com/repos/toonetown/homebrew/forks","keys_url":"https://api.github.com/repos/toonetown/homebrew/keys{/key_id}","collaborators_url":"https://api.github.com/repos/toonetown/homebrew/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/toonetown/homebrew/teams","hooks_url":"https://api.github.com/repos/toonetown/homebrew/hooks","issue_events_url":"https://api.github.com/repos/toonetown/homebrew/issues/events{/number}","events_url":"https://api.github.com/repos/toonetown/homebrew/events","assignees_url":"https://api.github.com/repos/toonetown/homebrew/assignees{/user}","branches_url":"https://api.github.com/repos/toonetown/homebrew/branches{/branch}","tags_url":"https://api.github.com/repos/toonetown/homebrew/tags","blobs_url":"https://api.github.com/repos/toonetown/homebrew/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/toonetown/homebrew/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/toonetown/homebrew/git/refs{/sha}","trees_url":"https://api.github.com/repos/toonetown/homebrew/git/trees{/sha}","statuses_url":"https://api.github.com/repos/toonetown/homebrew/statuses/{sha}","languages_url":"https://api.github.com/repos/toonetown/homebrew/languages","stargazers_url":"https://api.github.com/repos/toonetown/homebrew/stargazers","contributors_url":"https://api.github.com/repos/toonetown/homebrew/contributors","subscribers_url":"https://api.github.com/repos/toonetown/homebrew/subscribers","subscription_url":"https://api.github.com/repos/toonetown/homebrew/subscription","commits_url":"https://api.github.com/repos/toonetown/homebrew/commits{/sha}","git_commits_url":"https://api.github.com/repos/toonetown/homebrew/git/commits{/sha}","comments_url":"https://api.github.com/repos/toonetown/homebrew/comments{/number}","issue_comment_url":"https://api.github.com/repos/toonetown/homebrew/issues/comments{/number}","contents_url":"https://api.github.com/repos/toonetown/homebrew/contents/{+path}","compare_url":"https://api.github.com/repos/toonetown/homebrew/compare/{base}...{head}","merges_url":"https://api.github.com/repos/toonetown/homebrew/merges","archive_url":"https://api.github.com/repos/toonetown/homebrew/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/toonetown/homebrew/downloads","issues_url":"https://api.github.com/repos/toonetown/homebrew/issues{/number}","pulls_url":"https://api.github.com/repos/toonetown/homebrew/pulls{/number}","milestones_url":"https://api.github.com/repos/toonetown/homebrew/milestones{/number}","notifications_url":"https://api.github.com/repos/toonetown/homebrew/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/toonetown/homebrew/labels{/name}","releases_url":"https://api.github.com/repos/toonetown/homebrew/releases{/id}","deployments_url":"https://api.github.com/repos/toonetown/homebrew/deployments","created_at":"2016-09-26T23:34:10Z","updated_at":"2016-09-26T23:34:22Z","pushed_at":"2016-12-28T18:33:50Z","git_url":"git://github.com/toonetown/homebrew.git","ssh_url":"git@github.com:toonetown/homebrew.git","clone_url":"https://github.com/toonetown/homebrew.git","svn_url":"https://github.com/toonetown/homebrew","homepage":"http://brew.sh","size":16905,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Homebrew:master","ref":"master","sha":"6648ff130781279de560ad1ac77379a6250d16e4","user":{"login":"Homebrew","id":1503512,"avatar_url":"https://avatars.githubusercontent.com/u/1503512?v=3","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"repo":{"id":53238813,"name":"brew","full_name":"Homebrew/brew","owner":{"login":"Homebrew","id":1503512,"avatar_url":"https://avatars.githubusercontent.com/u/1503512?v=3","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Homebrew/brew","description":":beer: The missing package manager for macOS","fork":false,"url":"https://api.github.com/repos/Homebrew/brew","forks_url":"https://api.github.com/repos/Homebrew/brew/forks","keys_url":"https://api.github.com/repos/Homebrew/brew/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Homebrew/brew/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Homebrew/brew/teams","hooks_url":"https://api.github.com/repos/Homebrew/brew/hooks","issue_events_url":"https://api.github.com/repos/Homebrew/brew/issues/events{/number}","events_url":"https://api.github.com/repos/Homebrew/brew/events","assignees_url":"https://api.github.com/repos/Homebrew/brew/assignees{/user}","branches_url":"https://api.github.com/repos/Homebrew/brew/branches{/branch}","tags_url":"https://api.github.com/repos/Homebrew/brew/tags","blobs_url":"https://api.github.com/repos/Homebrew/brew/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Homebrew/brew/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Homebrew/brew/git/refs{/sha}","trees_url":"https://api.github.com/repos/Homebrew/brew/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Homebrew/brew/statuses/{sha}","languages_url":"https://api.github.com/repos/Homebrew/brew/languages","stargazers_url":"https://api.github.com/repos/Homebrew/brew/stargazers","contributors_url":"https://api.github.com/repos/Homebrew/brew/contributors","subscribers_url":"https://api.github.com/repos/Homebrew/brew/subscribers","subscription_url":"https://api.github.com/repos/Homebrew/brew/subscription","commits_url":"https://api.github.com/repos/Homebrew/brew/commits{/sha}","git_commits_url":"https://api.github.com/repos/Homebrew/brew/git/commits{/sha}","comments_url":"https://api.github.com/repos/Homebrew/brew/comments{/number}","issue_comment_url":"https://api.github.com/repos/Homebrew/brew/issues/comments{/number}","contents_url":"https://api.github.com/repos/Homebrew/brew/contents/{+path}","compare_url":"https://api.github.com/repos/Homebrew/brew/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Homebrew/brew/merges","archive_url":"https://api.github.com/repos/Homebrew/brew/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Homebrew/brew/downloads","issues_url":"https://api.github.com/repos/Homebrew/brew/issues{/number}","pulls_url":"https://api.github.com/repos/Homebrew/brew/pulls{/number}","milestones_url":"https://api.github.com/repos/Homebrew/brew/milestones{/number}","notifications_url":"https://api.github.com/repos/Homebrew/brew/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Homebrew/brew/labels{/name}","releases_url":"https://api.github.com/repos/Homebrew/brew/releases{/id}","deployments_url":"https://api.github.com/repos/Homebrew/brew/deployments","created_at":"2016-03-06T05:08:38Z","updated_at":"2016-12-28T18:33:48Z","pushed_at":"2016-12-28T05:05:34Z","git_url":"git://github.com/Homebrew/brew.git","ssh_url":"git@github.com:Homebrew/brew.git","clone_url":"https://github.com/Homebrew/brew.git","svn_url":"https://github.com/Homebrew/brew","homepage":"http://brew.sh","size":18045,"stargazers_count":5399,"watchers_count":5399,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1478,"mirror_url":null,"open_issues_count":67,"forks":1478,"open_issues":67,"watchers":5399,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Homebrew/brew/pulls/1743"},"html":{"href":"https://github.com/Homebrew/brew/pull/1743"},"issue":{"href":"https://api.github.com/repos/Homebrew/brew/issues/1743"},"comments":{"href":"https://api.github.com/repos/Homebrew/brew/issues/1743/comments"},"review_comments":{"href":"https://api.github.com/repos/Homebrew/brew/pulls/1743/comments"},"review_comment":{"href":"https://api.github.com/repos/Homebrew/brew/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Homebrew/brew/pulls/1743/commits"},"statuses":{"href":"https://api.github.com/repos/Homebrew/brew/statuses/d6bad843e7333806c280761831c35b8cf3eae6d5"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":25,"deletions":0,"changed_files":2}}
{"actor":{"display_login":"toonetown"}}