{"action":"created","issue":{"url":"https://api.github.com/repos/brianc/node-postgres/issues/1059","repository_url":"https://api.github.com/repos/brianc/node-postgres","labels_url":"https://api.github.com/repos/brianc/node-postgres/issues/1059/labels{/name}","comments_url":"https://api.github.com/repos/brianc/node-postgres/issues/1059/comments","events_url":"https://api.github.com/repos/brianc/node-postgres/issues/1059/events","html_url":"https://github.com/brianc/node-postgres/issues/1059","id":161577174,"number":1059,"title":"5.2 breaking changes","user":{"login":"sibedge","id":15840872,"avatar_url":"https://avatars.githubusercontent.com/u/15840872?v=3","gravatar_id":"","url":"https://api.github.com/users/sibedge","html_url":"https://github.com/sibedge","followers_url":"https://api.github.com/users/sibedge/followers","following_url":"https://api.github.com/users/sibedge/following{/other_user}","gists_url":"https://api.github.com/users/sibedge/gists{/gist_id}","starred_url":"https://api.github.com/users/sibedge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sibedge/subscriptions","organizations_url":"https://api.github.com/users/sibedge/orgs","repos_url":"https://api.github.com/users/sibedge/repos","events_url":"https://api.github.com/users/sibedge/events{/privacy}","received_events_url":"https://api.github.com/users/sibedge/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-06-22T01:50:27Z","updated_at":"2016-06-22T02:39:52Z","closed_at":null,"body":"5.2 broke my tests all over the place, with changes not documented anywhere.\r\n\r\nMy test errors show that now when we call `pg.connect`, the library modifies the original connection object.\r\n\r\nI think I'm just the first one running into this, and there will be more.\r\n"},"comment":{"url":"https://api.github.com/repos/brianc/node-postgres/issues/comments/227628069","html_url":"https://github.com/brianc/node-postgres/issues/1059#issuecomment-227628069","issue_url":"https://api.github.com/repos/brianc/node-postgres/issues/1059","id":227628069,"user":{"login":"sibedge","id":15840872,"avatar_url":"https://avatars.githubusercontent.com/u/15840872?v=3","gravatar_id":"","url":"https://api.github.com/users/sibedge","html_url":"https://github.com/sibedge","followers_url":"https://api.github.com/users/sibedge/followers","following_url":"https://api.github.com/users/sibedge/following{/other_user}","gists_url":"https://api.github.com/users/sibedge/gists{/gist_id}","starred_url":"https://api.github.com/users/sibedge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sibedge/subscriptions","organizations_url":"https://api.github.com/users/sibedge/orgs","repos_url":"https://api.github.com/users/sibedge/repos","events_url":"https://api.github.com/users/sibedge/events{/privacy}","received_events_url":"https://api.github.com/users/sibedge/received_events","type":"User","site_admin":false},"created_at":"2016-06-22T02:39:52Z","updated_at":"2016-06-22T02:39:52Z","body":">why are you dependent on the actual object not being\r\nmodified?\r\n\r\nI have many tests where the connection object is passed around, persisted and tested against the original, to make sure that at any point we are trying to establish the correct connection.\r\n\r\nNow that the original connection object suddenly mutates, we no longer can figure out whether it still represents the same connection or something else. It is an integrity break.\r\n"}}
{"actor":{"display_login":"sibedge"}}