{"action":"created","issue":{"url":"https://api.github.com/repos/reactjs/react-modal/issues/243","repository_url":"https://api.github.com/repos/reactjs/react-modal","labels_url":"https://api.github.com/repos/reactjs/react-modal/issues/243/labels{/name}","comments_url":"https://api.github.com/repos/reactjs/react-modal/issues/243/comments","events_url":"https://api.github.com/repos/reactjs/react-modal/issues/243/events","html_url":"https://github.com/reactjs/react-modal/pull/243","id":181828536,"number":243,"title":"[added] Add contentLabel prop to put aria-label on modal content","user":{"login":"claydiffrient","id":606262,"avatar_url":"https://avatars.githubusercontent.com/u/606262?v=3","gravatar_id":"","url":"https://api.github.com/users/claydiffrient","html_url":"https://github.com/claydiffrient","followers_url":"https://api.github.com/users/claydiffrient/followers","following_url":"https://api.github.com/users/claydiffrient/following{/other_user}","gists_url":"https://api.github.com/users/claydiffrient/gists{/gist_id}","starred_url":"https://api.github.com/users/claydiffrient/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/claydiffrient/subscriptions","organizations_url":"https://api.github.com/users/claydiffrient/orgs","repos_url":"https://api.github.com/users/claydiffrient/repos","events_url":"https://api.github.com/users/claydiffrient/events{/privacy}","received_events_url":"https://api.github.com/users/claydiffrient/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-10-08T14:20:20Z","updated_at":"2016-10-15T14:39:45Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/reactjs/react-modal/pulls/243","html_url":"https://github.com/reactjs/react-modal/pull/243","diff_url":"https://github.com/reactjs/react-modal/pull/243.diff","patch_url":"https://github.com/reactjs/react-modal/pull/243.patch"},"body":"Fixes #236.\r\n\r\nChanges proposed:\r\n- Add a aria-label to the modal content\r\n\r\nUpgrade Path (for changed or removed APIs):\r\n - Existing modals should add a `contentLabel` prop describing the modal content\r\n\r\n\r\nAcceptance Checklist:\r\n- [x] All commits have been squashed to one.\r\n- [x] The commit message follows the guidelines in `CONTRIBUTING.md`.\r\n- [x] Documentation (README.md) and examples have been updated as needed.\r\n- [x] If this is a code change, a spec testing the functionality has been added.\r\n- [x] If the commit message has [changed] or [removed], there is an upgrade path above."},"comment":{"url":"https://api.github.com/repos/reactjs/react-modal/issues/comments/253988176","html_url":"https://github.com/reactjs/react-modal/pull/243#issuecomment-253988176","issue_url":"https://api.github.com/repos/reactjs/react-modal/issues/243","id":253988176,"user":{"login":"claydiffrient","id":606262,"avatar_url":"https://avatars.githubusercontent.com/u/606262?v=3","gravatar_id":"","url":"https://api.github.com/users/claydiffrient","html_url":"https://github.com/claydiffrient","followers_url":"https://api.github.com/users/claydiffrient/followers","following_url":"https://api.github.com/users/claydiffrient/following{/other_user}","gists_url":"https://api.github.com/users/claydiffrient/gists{/gist_id}","starred_url":"https://api.github.com/users/claydiffrient/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/claydiffrient/subscriptions","organizations_url":"https://api.github.com/users/claydiffrient/orgs","repos_url":"https://api.github.com/users/claydiffrient/repos","events_url":"https://api.github.com/users/claydiffrient/events{/privacy}","received_events_url":"https://api.github.com/users/claydiffrient/received_events","type":"User","site_admin":false},"created_at":"2016-10-15T14:39:45Z","updated_at":"2016-10-15T14:39:45Z","body":"@diasbruno It doesn't look like #230 support all props just custom props.  I think this is acceptable to make sure that the aria-label can be applied.  I think once the merge conflicts are resolved on #230 then we can merge it as well."}}
{"actor":{"display_login":"claydiffrient"}}