{"action":"created","comment":{"url":"https://api.github.com/repos/apache/parquet-cpp/pulls/comments/52829415","id":52829415,"diff_hunk":"@@ -62,14 +64,14 @@ class Scanner {\n     return reader_->descr();\n   }\n \n-  size_t batch_size() const { return batch_size_;}\n+  int32_t batch_size() const { return batch_size_;}\n \n-  void SetBatchSize(size_t batch_size) {\n+  void SetBatchSize(int32_t batch_size) {\n     batch_size_ = batch_size;\n   }\n \n  protected:\n-  size_t batch_size_;\n+  int32_t batch_size_;","path":"src/parquet/column/scanner.h","position":53,"original_position":53,"commit_id":"503b1c1533e1d45320f5bfaa0375f334619d172d","original_commit_id":"503b1c1533e1d45320f5bfaa0375f334619d172d","user":{"login":"majetideepak","id":5091159,"avatar_url":"https://avatars.githubusercontent.com/u/5091159?v=3","gravatar_id":"","url":"https://api.github.com/users/majetideepak","html_url":"https://github.com/majetideepak","followers_url":"https://api.github.com/users/majetideepak/followers","following_url":"https://api.github.com/users/majetideepak/following{/other_user}","gists_url":"https://api.github.com/users/majetideepak/gists{/gist_id}","starred_url":"https://api.github.com/users/majetideepak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/majetideepak/subscriptions","organizations_url":"https://api.github.com/users/majetideepak/orgs","repos_url":"https://api.github.com/users/majetideepak/repos","events_url":"https://api.github.com/users/majetideepak/events{/privacy}","received_events_url":"https://api.github.com/users/majetideepak/received_events","type":"User","site_admin":false},"body":"Can we keep this `int64_t`? Why should we limit the `batch_size` to 2GB of a byte type?","created_at":"2016-02-13T15:39:13Z","updated_at":"2016-02-13T15:39:13Z","html_url":"https://github.com/apache/parquet-cpp/pull/49#discussion_r52829415","pull_request_url":"https://api.github.com/repos/apache/parquet-cpp/pulls/49","_links":{"self":{"href":"https://api.github.com/repos/apache/parquet-cpp/pulls/comments/52829415"},"html":{"href":"https://github.com/apache/parquet-cpp/pull/49#discussion_r52829415"},"pull_request":{"href":"https://api.github.com/repos/apache/parquet-cpp/pulls/49"}}},"pull_request":{"url":"https://api.github.com/repos/apache/parquet-cpp/pulls/49","id":59245476,"html_url":"https://github.com/apache/parquet-cpp/pull/49","diff_url":"https://github.com/apache/parquet-cpp/pull/49.diff","patch_url":"https://github.com/apache/parquet-cpp/pull/49.patch","issue_url":"https://api.github.com/repos/apache/parquet-cpp/issues/49","number":49,"state":"open","locked":false,"title":"PARQUET-446: Hide Thrift and Boost compiled headers from public API, #include scrubbing","user":{"login":"wesm","id":329591,"avatar_url":"https://avatars.githubusercontent.com/u/329591?v=3","gravatar_id":"","url":"https://api.github.com/users/wesm","html_url":"https://github.com/wesm","followers_url":"https://api.github.com/users/wesm/followers","following_url":"https://api.github.com/users/wesm/following{/other_user}","gists_url":"https://api.github.com/users/wesm/gists{/gist_id}","starred_url":"https://api.github.com/users/wesm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wesm/subscriptions","organizations_url":"https://api.github.com/users/wesm/orgs","repos_url":"https://api.github.com/users/wesm/repos","events_url":"https://api.github.com/users/wesm/events{/privacy}","received_events_url":"https://api.github.com/users/wesm/received_events","type":"User","site_admin":false},"body":"This is the completion of work I started in PARQUET-442. This also resolves PARQUET-277 as no boost headers are included in the public API anymore. \r\n\r\nI've done some scrubbing of #includes using Google's Clang-based include-what-you-use tool. PARQUET-522 can also be resolved when this is merged.","created_at":"2016-02-12T23:21:44Z","updated_at":"2016-02-13T15:39:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"20017e6df8ba22d70273b43a280adb4740b22eb8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/parquet-cpp/pulls/49/commits","review_comments_url":"https://api.github.com/repos/apache/parquet-cpp/pulls/49/comments","review_comment_url":"https://api.github.com/repos/apache/parquet-cpp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/parquet-cpp/issues/49/comments","statuses_url":"https://api.github.com/repos/apache/parquet-cpp/statuses/503b1c1533e1d45320f5bfaa0375f334619d172d","head":{"label":"wesm:PARQUET-446","ref":"PARQUET-446","sha":"503b1c1533e1d45320f5bfaa0375f334619d172d","user":{"login":"wesm","id":329591,"avatar_url":"https://avatars.githubusercontent.com/u/329591?v=3","gravatar_id":"","url":"https://api.github.com/users/wesm","html_url":"https://github.com/wesm","followers_url":"https://api.github.com/users/wesm/followers","following_url":"https://api.github.com/users/wesm/following{/other_user}","gists_url":"https://api.github.com/users/wesm/gists{/gist_id}","starred_url":"https://api.github.com/users/wesm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wesm/subscriptions","organizations_url":"https://api.github.com/users/wesm/orgs","repos_url":"https://api.github.com/users/wesm/repos","events_url":"https://api.github.com/users/wesm/events{/privacy}","received_events_url":"https://api.github.com/users/wesm/received_events","type":"User","site_admin":false},"repo":{"id":48463753,"name":"parquet-cpp","full_name":"wesm/parquet-cpp","owner":{"login":"wesm","id":329591,"avatar_url":"https://avatars.githubusercontent.com/u/329591?v=3","gravatar_id":"","url":"https://api.github.com/users/wesm","html_url":"https://github.com/wesm","followers_url":"https://api.github.com/users/wesm/followers","following_url":"https://api.github.com/users/wesm/following{/other_user}","gists_url":"https://api.github.com/users/wesm/gists{/gist_id}","starred_url":"https://api.github.com/users/wesm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wesm/subscriptions","organizations_url":"https://api.github.com/users/wesm/orgs","repos_url":"https://api.github.com/users/wesm/repos","events_url":"https://api.github.com/users/wesm/events{/privacy}","received_events_url":"https://api.github.com/users/wesm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wesm/parquet-cpp","description":"Mirror of Apache Parquet","fork":true,"url":"https://api.github.com/repos/wesm/parquet-cpp","forks_url":"https://api.github.com/repos/wesm/parquet-cpp/forks","keys_url":"https://api.github.com/repos/wesm/parquet-cpp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wesm/parquet-cpp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wesm/parquet-cpp/teams","hooks_url":"https://api.github.com/repos/wesm/parquet-cpp/hooks","issue_events_url":"https://api.github.com/repos/wesm/parquet-cpp/issues/events{/number}","events_url":"https://api.github.com/repos/wesm/parquet-cpp/events","assignees_url":"https://api.github.com/repos/wesm/parquet-cpp/assignees{/user}","branches_url":"https://api.github.com/repos/wesm/parquet-cpp/branches{/branch}","tags_url":"https://api.github.com/repos/wesm/parquet-cpp/tags","blobs_url":"https://api.github.com/repos/wesm/parquet-cpp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wesm/parquet-cpp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wesm/parquet-cpp/git/refs{/sha}","trees_url":"https://api.github.com/repos/wesm/parquet-cpp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wesm/parquet-cpp/statuses/{sha}","languages_url":"https://api.github.com/repos/wesm/parquet-cpp/languages","stargazers_url":"https://api.github.com/repos/wesm/parquet-cpp/stargazers","contributors_url":"https://api.github.com/repos/wesm/parquet-cpp/contributors","subscribers_url":"https://api.github.com/repos/wesm/parquet-cpp/subscribers","subscription_url":"https://api.github.com/repos/wesm/parquet-cpp/subscription","commits_url":"https://api.github.com/repos/wesm/parquet-cpp/commits{/sha}","git_commits_url":"https://api.github.com/repos/wesm/parquet-cpp/git/commits{/sha}","comments_url":"https://api.github.com/repos/wesm/parquet-cpp/comments{/number}","issue_comment_url":"https://api.github.com/repos/wesm/parquet-cpp/issues/comments{/number}","contents_url":"https://api.github.com/repos/wesm/parquet-cpp/contents/{+path}","compare_url":"https://api.github.com/repos/wesm/parquet-cpp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wesm/parquet-cpp/merges","archive_url":"https://api.github.com/repos/wesm/parquet-cpp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wesm/parquet-cpp/downloads","issues_url":"https://api.github.com/repos/wesm/parquet-cpp/issues{/number}","pulls_url":"https://api.github.com/repos/wesm/parquet-cpp/pulls{/number}","milestones_url":"https://api.github.com/repos/wesm/parquet-cpp/milestones{/number}","notifications_url":"https://api.github.com/repos/wesm/parquet-cpp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wesm/parquet-cpp/labels{/name}","releases_url":"https://api.github.com/repos/wesm/parquet-cpp/releases{/id}","deployments_url":"https://api.github.com/repos/wesm/parquet-cpp/deployments","created_at":"2015-12-23T02:08:59Z","updated_at":"2016-01-11T19:24:28Z","pushed_at":"2016-02-13T04:25:13Z","git_url":"git://github.com/wesm/parquet-cpp.git","ssh_url":"git@github.com:wesm/parquet-cpp.git","clone_url":"https://github.com/wesm/parquet-cpp.git","svn_url":"https://github.com/wesm/parquet-cpp","homepage":null,"size":485,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"05cd4ec2806316f6397857bd9e58263a0de38e32","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":20675634,"name":"parquet-cpp","full_name":"apache/parquet-cpp","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/parquet-cpp","description":"Mirror of Apache Parquet","fork":false,"url":"https://api.github.com/repos/apache/parquet-cpp","forks_url":"https://api.github.com/repos/apache/parquet-cpp/forks","keys_url":"https://api.github.com/repos/apache/parquet-cpp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/parquet-cpp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/parquet-cpp/teams","hooks_url":"https://api.github.com/repos/apache/parquet-cpp/hooks","issue_events_url":"https://api.github.com/repos/apache/parquet-cpp/issues/events{/number}","events_url":"https://api.github.com/repos/apache/parquet-cpp/events","assignees_url":"https://api.github.com/repos/apache/parquet-cpp/assignees{/user}","branches_url":"https://api.github.com/repos/apache/parquet-cpp/branches{/branch}","tags_url":"https://api.github.com/repos/apache/parquet-cpp/tags","blobs_url":"https://api.github.com/repos/apache/parquet-cpp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/parquet-cpp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/parquet-cpp/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/parquet-cpp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/parquet-cpp/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/parquet-cpp/languages","stargazers_url":"https://api.github.com/repos/apache/parquet-cpp/stargazers","contributors_url":"https://api.github.com/repos/apache/parquet-cpp/contributors","subscribers_url":"https://api.github.com/repos/apache/parquet-cpp/subscribers","subscription_url":"https://api.github.com/repos/apache/parquet-cpp/subscription","commits_url":"https://api.github.com/repos/apache/parquet-cpp/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/parquet-cpp/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/parquet-cpp/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/parquet-cpp/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/parquet-cpp/contents/{+path}","compare_url":"https://api.github.com/repos/apache/parquet-cpp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/parquet-cpp/merges","archive_url":"https://api.github.com/repos/apache/parquet-cpp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/parquet-cpp/downloads","issues_url":"https://api.github.com/repos/apache/parquet-cpp/issues{/number}","pulls_url":"https://api.github.com/repos/apache/parquet-cpp/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/parquet-cpp/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/parquet-cpp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/parquet-cpp/labels{/name}","releases_url":"https://api.github.com/repos/apache/parquet-cpp/releases{/id}","deployments_url":"https://api.github.com/repos/apache/parquet-cpp/deployments","created_at":"2014-06-10T07:00:07Z","updated_at":"2016-02-09T04:29:23Z","pushed_at":"2016-02-13T04:25:13Z","git_url":"git://github.com/apache/parquet-cpp.git","ssh_url":"git@github.com:apache/parquet-cpp.git","clone_url":"https://github.com/apache/parquet-cpp.git","svn_url":"https://github.com/apache/parquet-cpp","homepage":null,"size":662,"stargazers_count":23,"watchers_count":23,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":20,"mirror_url":"git://git.apache.org/parquet-cpp.git","open_issues_count":2,"forks":20,"open_issues":2,"watchers":23,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/parquet-cpp/pulls/49"},"html":{"href":"https://github.com/apache/parquet-cpp/pull/49"},"issue":{"href":"https://api.github.com/repos/apache/parquet-cpp/issues/49"},"comments":{"href":"https://api.github.com/repos/apache/parquet-cpp/issues/49/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/parquet-cpp/pulls/49/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/parquet-cpp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/parquet-cpp/pulls/49/commits"},"statuses":{"href":"https://api.github.com/repos/apache/parquet-cpp/statuses/503b1c1533e1d45320f5bfaa0375f334619d172d"}}}}