{"action":"closed","issue":{"url":"https://api.github.com/repos/imagej/imagej1/issues/12","repository_url":"https://api.github.com/repos/imagej/imagej1","labels_url":"https://api.github.com/repos/imagej/imagej1/issues/12/labels{/name}","comments_url":"https://api.github.com/repos/imagej/imagej1/issues/12/comments","events_url":"https://api.github.com/repos/imagej/imagej1/issues/12/events","html_url":"https://github.com/imagej/imagej1/issues/12","id":145500953,"number":12,"title":"Convolver class on floating point image data ","user":{"login":"erexhepa","id":3286025,"avatar_url":"https://avatars.githubusercontent.com/u/3286025?v=3","gravatar_id":"","url":"https://api.github.com/users/erexhepa","html_url":"https://github.com/erexhepa","followers_url":"https://api.github.com/users/erexhepa/followers","following_url":"https://api.github.com/users/erexhepa/following{/other_user}","gists_url":"https://api.github.com/users/erexhepa/gists{/gist_id}","starred_url":"https://api.github.com/users/erexhepa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erexhepa/subscriptions","organizations_url":"https://api.github.com/users/erexhepa/orgs","repos_url":"https://api.github.com/users/erexhepa/repos","events_url":"https://api.github.com/users/erexhepa/events{/privacy}","received_events_url":"https://api.github.com/users/erexhepa/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2016-04-03T13:34:50Z","updated_at":"2016-04-05T05:33:30Z","closed_at":"2016-04-05T05:33:30Z","body":"Hi,\r\n\r\nWe are working on a plugin for ImageJ and while using some of the built-in classes of ImageJ I found an issue with the class ij/plugin/filter/Convolver.java. What I was trying to do is to apply a 2D convolution with a 2D filter and I was calling the method convolveFloat from the class Convolver.java. However it doesn't perform the convolution as it try to get get a ROI from the image if the image doesn't have a ROI defined it doesn't get into the loops performing the convolution. \r\n\r\nIt's OK if you run it from the ImageJ interface because it goes through a roiReset and set's the ROI to to the entire image. However if you instantiate a Convolver object from inside another class you need to call roiReset before. I guess it is useful to keep the ROI in case you want to run the convolution in a specific ROI but maybe if there is no ROI the reset should be done automatically or indicate it in method documentation that the user should do it.\r\n\r\n Elton"}}