{"action":"created","comment":{"url":"https://api.github.com/repos/cartazio/arithmoi/pulls/comments/50057942","id":50057942,"diff_hunk":"@@ -61,9 +61,9 @@ integerCubeRoot n\n --   that is, the largest integer @r@ such that @r^3 <= n@.\n --   The precondition @n >= 0@ is not checked.\n {-# RULES\n-\"integerCubeRoot'/Int\"  integerCubeRoot' = cubeRootInt'\n-\"integerCubeRoot'/Word\" integerCubeRoot' = cubeRootWord\n-\"integerCubeRoot'/Igr\"  integerCubeRoot' = cubeRootIgr\n+\"integerCubeRoot'/Int\"     integerCubeRoot' = cubeRootInt'\n+\"integerCubeRoot'/Word\"    integerCubeRoot' = cubeRootWord\n+\"integerCubeRoot'/Integer\" integerCubeRoot' = cubeRootIgr","path":"Math/NumberTheory/Powers/Cubes.hs","position":9,"original_position":9,"commit_id":"eb1c506c66604286bb8b52c95f42e3d5a17e4f0f","original_commit_id":"eb1c506c66604286bb8b52c95f42e3d5a17e4f0f","user":{"login":"cartazio","id":4290,"avatar_url":"https://avatars.githubusercontent.com/u/4290?v=3","gravatar_id":"","url":"https://api.github.com/users/cartazio","html_url":"https://github.com/cartazio","followers_url":"https://api.github.com/users/cartazio/followers","following_url":"https://api.github.com/users/cartazio/following{/other_user}","gists_url":"https://api.github.com/users/cartazio/gists{/gist_id}","starred_url":"https://api.github.com/users/cartazio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cartazio/subscriptions","organizations_url":"https://api.github.com/users/cartazio/orgs","repos_url":"https://api.github.com/users/cartazio/repos","events_url":"https://api.github.com/users/cartazio/events{/privacy}","received_events_url":"https://api.github.com/users/cartazio/received_events","type":"User","site_admin":false},"body":"nice cleanup\r\n","created_at":"2016-01-18T23:54:35Z","updated_at":"2016-01-18T23:54:35Z","html_url":"https://github.com/cartazio/arithmoi/pull/14#discussion_r50057942","pull_request_url":"https://api.github.com/repos/cartazio/arithmoi/pulls/14","_links":{"self":{"href":"https://api.github.com/repos/cartazio/arithmoi/pulls/comments/50057942"},"html":{"href":"https://github.com/cartazio/arithmoi/pull/14#discussion_r50057942"},"pull_request":{"href":"https://api.github.com/repos/cartazio/arithmoi/pulls/14"}}},"pull_request":{"url":"https://api.github.com/repos/cartazio/arithmoi/pulls/14","id":55012606,"html_url":"https://github.com/cartazio/arithmoi/pull/14","diff_url":"https://github.com/cartazio/arithmoi/pull/14.diff","patch_url":"https://github.com/cartazio/arithmoi/pull/14.patch","issue_url":"https://api.github.com/repos/cartazio/arithmoi/issues/14","number":14,"state":"open","locked":false,"title":"Test and bug fixes for Math.NumberTheory.Powers","user":{"login":"Bodigrim","id":2293557,"avatar_url":"https://avatars.githubusercontent.com/u/2293557?v=3","gravatar_id":"","url":"https://api.github.com/users/Bodigrim","html_url":"https://github.com/Bodigrim","followers_url":"https://api.github.com/users/Bodigrim/followers","following_url":"https://api.github.com/users/Bodigrim/following{/other_user}","gists_url":"https://api.github.com/users/Bodigrim/gists{/gist_id}","starred_url":"https://api.github.com/users/Bodigrim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bodigrim/subscriptions","organizations_url":"https://api.github.com/users/Bodigrim/orgs","repos_url":"https://api.github.com/users/Bodigrim/repos","events_url":"https://api.github.com/users/Bodigrim/events{/privacy}","received_events_url":"https://api.github.com/users/Bodigrim/received_events","type":"User","site_admin":false},"body":"I have written some basic tests for `Math.NumberTheory.Powers` modules. They triggered two bugs, which I have fixed.\r\n\r\nFirst bug (and the nasty one) was caused by `unP` subroutine from `Math.NumberTheory.Powers`. Since its test expression did not depend on its arguments, it could cycle forever. \r\n\r\nSecond bug is concerned with integer roots of high degree (64 and more) from `Word`. In such case intermediate computations in `newtonK` involved numbers far beyond `maxBound`, which caused either division by 0, or incorrect answers. \r\n\r\nHere is Travis build: https://travis-ci.org/Bodigrim/arithmoi/builds/100183595","created_at":"2016-01-04T19:35:18Z","updated_at":"2016-01-18T23:54:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"647b317355da9d6dbd4991466840c518a0228d51","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cartazio/arithmoi/pulls/14/commits","review_comments_url":"https://api.github.com/repos/cartazio/arithmoi/pulls/14/comments","review_comment_url":"https://api.github.com/repos/cartazio/arithmoi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cartazio/arithmoi/issues/14/comments","statuses_url":"https://api.github.com/repos/cartazio/arithmoi/statuses/eb1c506c66604286bb8b52c95f42e3d5a17e4f0f","head":{"label":"Bodigrim:master","ref":"master","sha":"eb1c506c66604286bb8b52c95f42e3d5a17e4f0f","user":{"login":"Bodigrim","id":2293557,"avatar_url":"https://avatars.githubusercontent.com/u/2293557?v=3","gravatar_id":"","url":"https://api.github.com/users/Bodigrim","html_url":"https://github.com/Bodigrim","followers_url":"https://api.github.com/users/Bodigrim/followers","following_url":"https://api.github.com/users/Bodigrim/following{/other_user}","gists_url":"https://api.github.com/users/Bodigrim/gists{/gist_id}","starred_url":"https://api.github.com/users/Bodigrim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bodigrim/subscriptions","organizations_url":"https://api.github.com/users/Bodigrim/orgs","repos_url":"https://api.github.com/users/Bodigrim/repos","events_url":"https://api.github.com/users/Bodigrim/events{/privacy}","received_events_url":"https://api.github.com/users/Bodigrim/received_events","type":"User","site_admin":false},"repo":{"id":48952245,"name":"arithmoi","full_name":"Bodigrim/arithmoi","owner":{"login":"Bodigrim","id":2293557,"avatar_url":"https://avatars.githubusercontent.com/u/2293557?v=3","gravatar_id":"","url":"https://api.github.com/users/Bodigrim","html_url":"https://github.com/Bodigrim","followers_url":"https://api.github.com/users/Bodigrim/followers","following_url":"https://api.github.com/users/Bodigrim/following{/other_user}","gists_url":"https://api.github.com/users/Bodigrim/gists{/gist_id}","starred_url":"https://api.github.com/users/Bodigrim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bodigrim/subscriptions","organizations_url":"https://api.github.com/users/Bodigrim/orgs","repos_url":"https://api.github.com/users/Bodigrim/repos","events_url":"https://api.github.com/users/Bodigrim/events{/privacy}","received_events_url":"https://api.github.com/users/Bodigrim/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Bodigrim/arithmoi","description":"arithmoi is currently maintained here ","fork":true,"url":"https://api.github.com/repos/Bodigrim/arithmoi","forks_url":"https://api.github.com/repos/Bodigrim/arithmoi/forks","keys_url":"https://api.github.com/repos/Bodigrim/arithmoi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Bodigrim/arithmoi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Bodigrim/arithmoi/teams","hooks_url":"https://api.github.com/repos/Bodigrim/arithmoi/hooks","issue_events_url":"https://api.github.com/repos/Bodigrim/arithmoi/issues/events{/number}","events_url":"https://api.github.com/repos/Bodigrim/arithmoi/events","assignees_url":"https://api.github.com/repos/Bodigrim/arithmoi/assignees{/user}","branches_url":"https://api.github.com/repos/Bodigrim/arithmoi/branches{/branch}","tags_url":"https://api.github.com/repos/Bodigrim/arithmoi/tags","blobs_url":"https://api.github.com/repos/Bodigrim/arithmoi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Bodigrim/arithmoi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Bodigrim/arithmoi/git/refs{/sha}","trees_url":"https://api.github.com/repos/Bodigrim/arithmoi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Bodigrim/arithmoi/statuses/{sha}","languages_url":"https://api.github.com/repos/Bodigrim/arithmoi/languages","stargazers_url":"https://api.github.com/repos/Bodigrim/arithmoi/stargazers","contributors_url":"https://api.github.com/repos/Bodigrim/arithmoi/contributors","subscribers_url":"https://api.github.com/repos/Bodigrim/arithmoi/subscribers","subscription_url":"https://api.github.com/repos/Bodigrim/arithmoi/subscription","commits_url":"https://api.github.com/repos/Bodigrim/arithmoi/commits{/sha}","git_commits_url":"https://api.github.com/repos/Bodigrim/arithmoi/git/commits{/sha}","comments_url":"https://api.github.com/repos/Bodigrim/arithmoi/comments{/number}","issue_comment_url":"https://api.github.com/repos/Bodigrim/arithmoi/issues/comments{/number}","contents_url":"https://api.github.com/repos/Bodigrim/arithmoi/contents/{+path}","compare_url":"https://api.github.com/repos/Bodigrim/arithmoi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Bodigrim/arithmoi/merges","archive_url":"https://api.github.com/repos/Bodigrim/arithmoi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Bodigrim/arithmoi/downloads","issues_url":"https://api.github.com/repos/Bodigrim/arithmoi/issues{/number}","pulls_url":"https://api.github.com/repos/Bodigrim/arithmoi/pulls{/number}","milestones_url":"https://api.github.com/repos/Bodigrim/arithmoi/milestones{/number}","notifications_url":"https://api.github.com/repos/Bodigrim/arithmoi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Bodigrim/arithmoi/labels{/name}","releases_url":"https://api.github.com/repos/Bodigrim/arithmoi/releases{/id}","created_at":"2016-01-03T16:17:23Z","updated_at":"2016-01-03T16:17:24Z","pushed_at":"2016-01-04T19:03:17Z","git_url":"git://github.com/Bodigrim/arithmoi.git","ssh_url":"git@github.com:Bodigrim/arithmoi.git","clone_url":"https://github.com/Bodigrim/arithmoi.git","svn_url":"https://github.com/Bodigrim/arithmoi","homepage":null,"size":652,"stargazers_count":0,"watchers_count":0,"language":"Haskell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cartazio:master","ref":"master","sha":"e500a4413ed01092fd3d74cf7b0030153f195e59","user":{"login":"cartazio","id":4290,"avatar_url":"https://avatars.githubusercontent.com/u/4290?v=3","gravatar_id":"","url":"https://api.github.com/users/cartazio","html_url":"https://github.com/cartazio","followers_url":"https://api.github.com/users/cartazio/followers","following_url":"https://api.github.com/users/cartazio/following{/other_user}","gists_url":"https://api.github.com/users/cartazio/gists{/gist_id}","starred_url":"https://api.github.com/users/cartazio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cartazio/subscriptions","organizations_url":"https://api.github.com/users/cartazio/orgs","repos_url":"https://api.github.com/users/cartazio/repos","events_url":"https://api.github.com/users/cartazio/events{/privacy}","received_events_url":"https://api.github.com/users/cartazio/received_events","type":"User","site_admin":false},"repo":{"id":33020002,"name":"arithmoi","full_name":"cartazio/arithmoi","owner":{"login":"cartazio","id":4290,"avatar_url":"https://avatars.githubusercontent.com/u/4290?v=3","gravatar_id":"","url":"https://api.github.com/users/cartazio","html_url":"https://github.com/cartazio","followers_url":"https://api.github.com/users/cartazio/followers","following_url":"https://api.github.com/users/cartazio/following{/other_user}","gists_url":"https://api.github.com/users/cartazio/gists{/gist_id}","starred_url":"https://api.github.com/users/cartazio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cartazio/subscriptions","organizations_url":"https://api.github.com/users/cartazio/orgs","repos_url":"https://api.github.com/users/cartazio/repos","events_url":"https://api.github.com/users/cartazio/events{/privacy}","received_events_url":"https://api.github.com/users/cartazio/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cartazio/arithmoi","description":"arithmoi is currently maintained here ","fork":false,"url":"https://api.github.com/repos/cartazio/arithmoi","forks_url":"https://api.github.com/repos/cartazio/arithmoi/forks","keys_url":"https://api.github.com/repos/cartazio/arithmoi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cartazio/arithmoi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cartazio/arithmoi/teams","hooks_url":"https://api.github.com/repos/cartazio/arithmoi/hooks","issue_events_url":"https://api.github.com/repos/cartazio/arithmoi/issues/events{/number}","events_url":"https://api.github.com/repos/cartazio/arithmoi/events","assignees_url":"https://api.github.com/repos/cartazio/arithmoi/assignees{/user}","branches_url":"https://api.github.com/repos/cartazio/arithmoi/branches{/branch}","tags_url":"https://api.github.com/repos/cartazio/arithmoi/tags","blobs_url":"https://api.github.com/repos/cartazio/arithmoi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cartazio/arithmoi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cartazio/arithmoi/git/refs{/sha}","trees_url":"https://api.github.com/repos/cartazio/arithmoi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cartazio/arithmoi/statuses/{sha}","languages_url":"https://api.github.com/repos/cartazio/arithmoi/languages","stargazers_url":"https://api.github.com/repos/cartazio/arithmoi/stargazers","contributors_url":"https://api.github.com/repos/cartazio/arithmoi/contributors","subscribers_url":"https://api.github.com/repos/cartazio/arithmoi/subscribers","subscription_url":"https://api.github.com/repos/cartazio/arithmoi/subscription","commits_url":"https://api.github.com/repos/cartazio/arithmoi/commits{/sha}","git_commits_url":"https://api.github.com/repos/cartazio/arithmoi/git/commits{/sha}","comments_url":"https://api.github.com/repos/cartazio/arithmoi/comments{/number}","issue_comment_url":"https://api.github.com/repos/cartazio/arithmoi/issues/comments{/number}","contents_url":"https://api.github.com/repos/cartazio/arithmoi/contents/{+path}","compare_url":"https://api.github.com/repos/cartazio/arithmoi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cartazio/arithmoi/merges","archive_url":"https://api.github.com/repos/cartazio/arithmoi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cartazio/arithmoi/downloads","issues_url":"https://api.github.com/repos/cartazio/arithmoi/issues{/number}","pulls_url":"https://api.github.com/repos/cartazio/arithmoi/pulls{/number}","milestones_url":"https://api.github.com/repos/cartazio/arithmoi/milestones{/number}","notifications_url":"https://api.github.com/repos/cartazio/arithmoi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cartazio/arithmoi/labels{/name}","releases_url":"https://api.github.com/repos/cartazio/arithmoi/releases{/id}","created_at":"2015-03-28T03:45:13Z","updated_at":"2015-07-27T08:49:43Z","pushed_at":"2016-01-04T19:35:19Z","git_url":"git://github.com/cartazio/arithmoi.git","ssh_url":"git@github.com:cartazio/arithmoi.git","clone_url":"https://github.com/cartazio/arithmoi.git","svn_url":"https://github.com/cartazio/arithmoi","homepage":null,"size":943,"stargazers_count":7,"watchers_count":7,"language":"Haskell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":10,"forks":8,"open_issues":10,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cartazio/arithmoi/pulls/14"},"html":{"href":"https://github.com/cartazio/arithmoi/pull/14"},"issue":{"href":"https://api.github.com/repos/cartazio/arithmoi/issues/14"},"comments":{"href":"https://api.github.com/repos/cartazio/arithmoi/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/cartazio/arithmoi/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/cartazio/arithmoi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cartazio/arithmoi/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/cartazio/arithmoi/statuses/eb1c506c66604286bb8b52c95f42e3d5a17e4f0f"}}}}