{"push_id":1297268830,"size":19,"distinct_size":19,"ref":"refs/heads/master","head":"3ee3c3198ae0c79a698f9037975a17c6fca31a69","before":"8a74bb24f521b2112979325fd3b6342d48788951","commits":[{"sha":"e330b6923aafa0c68b44eec6cacfbe1d8ff9d378","author":{"name":"Jonathan Druart","email":"b8e3b888c23b54255e26fdc644fc18f5231e8886@bugs.koha-community.org"},"message":"Bug 15407: Remove 'No method selected!' warnings\n\nFrom reserves_stats.pl, there is no library pre-selected.\n\nSigned-off-by: Kyle M Hall <kyle@bywatersolutions.com>","distinct":true,"url":"https://api.github.com/repos/PTFS-Europe/koha/commits/e330b6923aafa0c68b44eec6cacfbe1d8ff9d378"},{"sha":"7535b28f77269a3f0efecf9055477a345c9a63c4","author":{"name":"Sophie Meynieux","email":"f2ab7a4939158deb77c42d82a39e5d3686a332bf@biblibre.com"},"message":"Bug 13914 : Fix UNION in SQL request for reserves statistics\n\nTest plan\n=========\nOn Reports > reservations, select all statuses as line, pickup library as column (empty) and a range of hold date. Keep the results\nRun the same reports but with statuses as column and pickup library as line\nYou should get the same results on another display.\n\n* Without patch, if you've got representative data, most of the time you can observe significant differences between both results\n\n* With the patch, results are always the same (and right if you request directly your database)\n\nSigned-off-by: Chris Cormack <chrisc@catalyst.net.nz>\n\nSigned-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>\n\nSigned-off-by: Kyle M Hall <kyle@bywatersolutions.com>","distinct":true,"url":"https://api.github.com/repos/PTFS-Europe/koha/commits/7535b28f77269a3f0efecf9055477a345c9a63c4"},{"sha":"af2918045f3323f9a558eb463165bb4ef331e477","author":{"name":"Nick Clemens","email":"3095c93d6ea7c5200e557b6036c9a91ff7a76ed2@bywatersolutions.com"},"message":"Bug 17295 - Missed variable removal in subscription-add.pl from Bug 15758\n\nTo test:\nLoad subscription-add.pl\nGet an error\nApply patch\nReload\nKoha is less sad (page loads okay)\nVerify that normal functions work\n\nSigned-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>\n\nSigned-off-by: Kyle M Hall <kyle@bywatersolutions.com>","distinct":true,"url":"https://api.github.com/repos/PTFS-Europe/koha/commits/af2918045f3323f9a558eb463165bb4ef331e477"},{"sha":"75c61b94f34d406aaa8ac862024ccfd3d9030cc8","author":{"name":"Sophie Meynieux","email":"f2ab7a4939158deb77c42d82a39e5d3686a332bf@biblibre.com"},"message":"Bug 10227 : Fix GetMessagingPreferences when digest is possible\n\nThis bug is a bit tricky to test, as the result is somehow  random, depending on the order of rows returned by sql request. You've got to change the preferences several times to see bad results.\n\nEnable EnhancedMessaging preferences\nSet preferences for a borrower or a category.\nrun misc/cronjobs/advance_notices.pl and look in message_queue table the letter_code of the generated messages.\nChange digest selection and do the test again several times\n\nWithout patch, for message where digest is allowed (Advance_Notice, Item_Due), for a borrower or a category with 'wants_digest' selected, GetBorrowerMessagingPreferences returns sometimes letter_code with DGST and sometimes not.\n\nWith the patch, letter_code returned is always correct depending on digest selected or not\n\nSigned-off-by: Chris Cormack <chrisc@catalyst.net.nz>\n\nSigned-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>\n\nSigned-off-by: Kyle M Hall <kyle@bywatersolutions.com>","distinct":true,"url":"https://api.github.com/repos/PTFS-Europe/koha/commits/75c61b94f34d406aaa8ac862024ccfd3d9030cc8"},{"sha":"bdcbada8b892c3e322c1a9378d9343b4eb9f2089","author":{"name":"Nick Clemens","email":"3095c93d6ea7c5200e557b6036c9a91ff7a76ed2@bywatersolutions.com"},"message":"Bug 14752 - Add multiple copies to a basket at once\n\nThis patch add an 'Add multiple copies' button on the new order page in\nacquisitions.  While processing the multiple copies a modal is\ndisplayed.\n\nTo test:\n1 - Add an order to an acquisitions basket\n2 - Choose to add multiple items\n3 - A modal shouold warn about ignoring UniqueItemFields from syspref\n4 - When submitting the modal should popup until all items are processed.\n5 - The modal should disappear after items are added.\n6 - Items should be cloned, minus unique fields\n7 - Enable autoBarcode for various formats, ensure you are warned that\nbarcodes will be generated, and ensure they are generated correctly\n\nSponsored by: Middletown Township Public Library (http://www.mtpl.org)\n\nSigned-off-by: sonia BOUIS <sonia.bouis@univ-lyon3.fr>\n\nSigned-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>\n\nSigned-off-by: Kyle M Hall <kyle@bywatersolutions.com>","distinct":true,"url":"https://api.github.com/repos/PTFS-Europe/koha/commits/bdcbada8b892c3e322c1a9378d9343b4eb9f2089"},{"sha":"1d546c57b1be3677263639ff330061fce33dde34","author":{"name":"Nick Clemens","email":"3095c93d6ea7c5200e557b6036c9a91ff7a76ed2@bywatersolutions.com"},"message":"Bug 14752 - (QA followup) Remove annoying modal, use dialog box instead\n\n- Uses a dialog box to warn of unique fields not copying, dialog was in\nplace for barcode generation so removed the extar modal completey\n- Fixes a problem when barcode was undefined and autobarcode on\n- deleted an extra space in Barcodes/hbymmincr.pm\n\nSigned-off-by: sonia BOUIS <sonia.bouis@univ-lyon3.fr>\n\nSigned-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>\n\nSigned-off-by: Kyle M Hall <kyle@bywatersolutions.com>","distinct":true,"url":"https://api.github.com/repos/PTFS-Europe/koha/commits/1d546c57b1be3677263639ff330061fce33dde34"},{"sha":"99f6116f3595f4d58307fc3249f3be98550d99a9","author":{"name":"Nick Clemens","email":"3095c93d6ea7c5200e557b6036c9a91ff7a76ed2@bywatersolutions.com"},"message":"Bug 16732 - Add audio alerts (custom sound notifications) to web based self checkout\n\nThis patch adds the infrastructure needed to allow audio alerts, as\nconfigured in administration, to affect the sco module\n\nThis patch allows only for the use of sounds with a full URL to be used\nand does not allow for the Koha standard sounds to be accessed via the\nSCO\n\nTo test:\nEnsure you have the preference AudioAlerts enabled\nEnsure you can hear normal sounds from the staff module\nDefine an audio alert such as:\n    Selector: .sco_entry\n    Sound: https://archive.org/download/Doorbell_1/doorbell.ogg\nLoad the SCO module\nYou should hear the doorbell noise (everytime you reload even!)\nTest that the default sounds are not activated for the SCO, you must\nsepcifically define them\n\nSigned-off-by: Owen Leonard <oleonard@myacpl.org>\n\nSigned-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>\n\nSigned-off-by: Kyle M Hall <kyle@bywatersolutions.com>","distinct":true,"url":"https://api.github.com/repos/PTFS-Europe/koha/commits/99f6116f3595f4d58307fc3249f3be98550d99a9"},{"sha":"645b1f52379966e489f417e0173d5950e4ebc8f9","author":{"name":"Aleisha","email":"934fbebf63797f261a218fe8902264ad1e62817b@hotmail.com"},"message":"Bug 16949: Batch record deletion says success when no records have been passed in\n\nThe reason this happens is because the page will say success when the\ntotal number of records given equals the total number of successful\ndeletions. If you pass in no records, there are no successful deletions\n--> 0 = 0 --> it thinks it has been successful. This patch adds a check\nthat validates if any checkboxes were selected before submitting the\nfinal form.\n\nI have removed the check for if any records were selected AFTER the form\nhas been submitted because it seemed unnecessary if the form can't be\nsubmitted without selection of records anyway.\n\nTo test:\n1) Go to Tools -> Batch record deletion\n2) Put in a record number and click Continue\n3) Deselect the record so that it doesn't actually delete and click\n   Delete selected records\n4) Page says 'All records have been deleted successfully!'\n5) Apply patch. Go back and repeat step 3\n6) Form should not submit and you should receive an alert saying that no\n   records have been selected.\n7) If you try selecting and deleting a record after this alert, it\n   should still work\n\nNote: Have also changed the wording of error in Step 1 when you are\nentering record numbers to delete.\n\nSponsored-by: Catalyst IT\n\nSigned-off-by: Owen Leonard <oleonard@myacpl.org>\n\nSigned-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>\n\nSigned-off-by: Kyle M Hall <kyle@bywatersolutions.com>","distinct":true,"url":"https://api.github.com/repos/PTFS-Europe/koha/commits/645b1f52379966e489f417e0173d5950e4ebc8f9"},{"sha":"57f66d5132fe059c76740b5e2e743d3082d25303","author":{"name":"Jonathan Druart","email":"b8e3b888c23b54255e26fdc644fc18f5231e8886@bugs.koha-community.org"},"message":"Bug 16949: Simplify the checkbox checked condition\n\nIt's easier to use jQuery selector to know if checkboxes are checked.\n\nSigned-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>\n\nSigned-off-by: Kyle M Hall <kyle@bywatersolutions.com>","distinct":true,"url":"https://api.github.com/repos/PTFS-Europe/koha/commits/57f66d5132fe059c76740b5e2e743d3082d25303"},{"sha":"c78c927695fdcb0dfa060f9dba2fc2933eb57b8b","author":{"name":"Owen Leonard","email":"49b694e103543696a2f066bc69b1b85179a169fc@myacpl.org"},"message":"Bug 17147 [Revised] Streamline messages following batch record modification\n\nThis patch changes the display of informational messages during and\nafter the batch record modification process. Instead of showing a\nseparate dialog for each record modified, messages are now grouped into\none dialog.\n\nTo test, apply the patch and clear your browser cache if necessary. You\nmust have at least one MARC modification template defined.\n\n- Go to Tools -> Batch record modification.\n- Submit a list of biblionumbers which contains at least one number\n  which doesn't exist in your database.\n- Confirm that warning and success messages are grouped instead of\n  showing in separate dialogs.\n- Submit a list of biblionumbers using a MARC modification template\n  which contains no actions. Confirm that the resulting error message is\n  correctly formatted.\n\nRevision formats the error messages without the unordered list, which\nwas giving them padding which didn't look correct inside a dialog.\n\nSigned-off-by: Aleisha Amohia <aleishaamohia@hotmail.com>\n\nEdit for QA: Removed obsolete changes to CSS.\n\nSigned-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>\n\nSigned-off-by: Kyle M Hall <kyle@bywatersolutions.com>","distinct":true,"url":"https://api.github.com/repos/PTFS-Europe/koha/commits/c78c927695fdcb0dfa060f9dba2fc2933eb57b8b"},{"sha":"f234d1586bff62d2c4e58807cd62ec3187d94f69","author":{"name":"Jonathan Druart","email":"b8e3b888c23b54255e26fdc644fc18f5231e8886@bugs.koha-community.org"},"message":"Bug 16276: Update borrowers.lastseen when a patron is active\n\nIn order to add the ability to delete patrons who have been inactive for\nmore than a given time, we need to track down the last time they were\nactive.\nTo do that, we need a new DB column in the borrowers table (lastseen).\nNote that the borrowers.lastseen column will not be initialised for existing\ninstallations (set to NULL) so inactive existing patrons will never be\ndeleted.\nA workaround would be to init them at the date when the new column will\nbe added.\n\nTest plan:\n0/ Set the new pref TrackLastPatronActivity on\n1/ Log in as a patron (staff or OPAC)\n2/ Check that the borrowers.lastseen field has been updated with the\ncurrent time\n\nSponsored-by: BULAC - http://www.bulac.fr/\nSigned-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr>\n\nhttps://bugs.koha-community.org/show_bug.cgi?id=12276\n\nSigned-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>\n\nSigned-off-by: Kyle M Hall <kyle@bywatersolutions.com>","distinct":true,"url":"https://api.github.com/repos/PTFS-Europe/koha/commits/f234d1586bff62d2c4e58807cd62ec3187d94f69"},{"sha":"93ff61c10d671afb6c7be2dd24076383b839f182","author":{"name":"Jonathan Druart","email":"b8e3b888c23b54255e26fdc644fc18f5231e8886@bugs.koha-community.org"},"message":"Bug 16276: Make delete_patrons.pl deal with --last_seen\n\nThis patch modify the delete_patrons.pl cronjob to deal with the\nlast_seen option.\n\nTo test it, you just have to use the --last_seen option and pass a valid\ndate (iso format)\n\nExample:\n  perl misc/cronjobs/delete_patrons.pl --last_seen=\"1984-02-04\" --confirm\nwill delete all the patrons who do not have been active since this date.\n\nSponsored-by: BULAC - http://www.bulac.fr/\nSigned-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr>\n\nhttps://bugs.koha-community.org/show_bug.cgi?id=12276\n\nSigned-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>\n\nSigned-off-by: Kyle M Hall <kyle@bywatersolutions.com>","distinct":true,"url":"https://api.github.com/repos/PTFS-Europe/koha/commits/93ff61c10d671afb6c7be2dd24076383b839f182"},{"sha":"1d50d8cc0c4190bd5dd3ba8a555fba916e946c88","author":{"name":"Jonathan Druart","email":"b8e3b888c23b54255e26fdc644fc18f5231e8886@bugs.koha-community.org"},"message":"Bug 16276: Change to GetBorrowersToExpunge to take last_seen into account\n\nSponsored-by: BULAC - http://www.bulac.fr/\nSigned-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr>\nWith small change: number of tests in t/db_dependent/Members.t\n\nhttps://bugs.koha-community.org/show_bug.cgi?id=12276\n\nSigned-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>\n\nSigned-off-by: Kyle M Hall <kyle@bywatersolutions.com>","distinct":true,"url":"https://api.github.com/repos/PTFS-Europe/koha/commits/1d50d8cc0c4190bd5dd3ba8a555fba916e946c88"},{"sha":"7acb7e14faed07ff987e58356d3faaa95a2cf194","author":{"name":"Jonathan Druart","email":"b8e3b888c23b54255e26fdc644fc18f5231e8886@bugs.koha-community.org"},"message":"Bug 16276: Make the batch patron deletion tool deal with last_seen\n\nThis patch adds the same change as the previous one to the batch patron\ndeletion tool.\n\nIf the pref TrackLastPatronActivity is enabled, the librarians will be\nable to delete patrons who do not have been connected since a given\ntime.\n\nTest plan:\nDefine a date for the \"who have not been connected since\" options and\nconfirm that it works as expected.\n\nSponsored-by: BULAC - http://www.bulac.fr/\nSigned-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr>\n\nhttps://bugs.koha-community.org/show_bug.cgi?id=12276\n\nSigned-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>\n\nSigned-off-by: Kyle M Hall <kyle@bywatersolutions.com>","distinct":true,"url":"https://api.github.com/repos/PTFS-Europe/koha/commits/7acb7e14faed07ff987e58356d3faaa95a2cf194"},{"sha":"b6fe9f23ccb678917bfb90950668cd1efbc4848f","author":{"name":"Jonathan Druart","email":"b8e3b888c23b54255e26fdc644fc18f5231e8886@bugs.koha-community.org"},"message":"Bug 16276: Add a new pref TrackLastPatronActivity and new column borrowers.lastseen\n\nSponsored-by: BULAC - http://www.bulac.fr/\nSigned-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr>\n\nhttps://bugs.koha-community.org/show_bug.cgi?id=12276\n\nSigned-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>\n\nSigned-off-by: Kyle M Hall <kyle@bywatersolutions.com>","distinct":true,"url":"https://api.github.com/repos/PTFS-Europe/koha/commits/b6fe9f23ccb678917bfb90950668cd1efbc4848f"},{"sha":"183fdc83f04484eab831be58b5bdef9f14aec963","author":{"name":"Marcel de Rooy","email":"7eab020898e2d4d9802958d4ce1ff45d78acfe54@rijksmuseum.nl"},"message":"Bug 16276: [QA Follow-up] Number of tests corrected\n\nApplies to t/db_dependent/Members.t\n\nSigned-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>\n\nSigned-off-by: Kyle M Hall <kyle@bywatersolutions.com>","distinct":true,"url":"https://api.github.com/repos/PTFS-Europe/koha/commits/183fdc83f04484eab831be58b5bdef9f14aec963"},{"sha":"95fe4347581cba70bdf36c3f3f1c43e1b765c2d7","author":{"name":"Marcel de Rooy","email":"7eab020898e2d4d9802958d4ce1ff45d78acfe54@rijksmuseum.nl"},"message":"Bug 16276: [QA Follow-up] Only track when pref is enabled\n\nDo not track when the pref has not been enabled.\nThis patch moves the conditional update in Auth.pm to Koha::Patron.\nAnd adds a test for the new track_login method.\n\nSigned-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>\n\nSigned-off-by: Kyle M Hall <kyle@bywatersolutions.com>","distinct":true,"url":"https://api.github.com/repos/PTFS-Europe/koha/commits/95fe4347581cba70bdf36c3f3f1c43e1b765c2d7"},{"sha":"89bae5f368bb9bf2e28172945852a1cd0e42a120","author":{"name":"Kyle M Hall","email":"d0ff38e6f73256704c61d16b0f8fbefe41e0c8dc@bywatersolutions.com"},"message":"Bug 16276 - DBRev 16.06.00.027\n\nSigned-off-by: Kyle M Hall <kyle@bywatersolutions.com>","distinct":true,"url":"https://api.github.com/repos/PTFS-Europe/koha/commits/89bae5f368bb9bf2e28172945852a1cd0e42a120"},{"sha":"3ee3c3198ae0c79a698f9037975a17c6fca31a69","author":{"name":"Kyle M Hall","email":"d0ff38e6f73256704c61d16b0f8fbefe41e0c8dc@bywatersolutions.com"},"message":"Bug 16276 - Update schema\n\nSigned-off-by: Kyle M Hall <kyle@bywatersolutions.com>","distinct":true,"url":"https://api.github.com/repos/PTFS-Europe/koha/commits/3ee3c3198ae0c79a698f9037975a17c6fca31a69"}]}
{"actor":{"display_login":"mrenvoize"}}