{"action":"created","comment":{"url":"https://api.github.com/repos/woju/qubes-core-admin/pulls/comments/60747860","id":60747860,"diff_hunk":"@@ -79,6 +80,17 @@\n def main(args=None):\n     args = parser.parse_args(args)\n \n+    if args.pool:\n+        args.properties['volume_config'] = {}\n+        for pool_vol in args.pool:\n+            try:\n+                pool_name, volume_name = pool_vol.split(':')","path":"qubes/tools/qvm_create.py","position":22,"original_position":22,"commit_id":"38d1ed698163451e46b4265ded3e45f389030b06","original_commit_id":"38d1ed698163451e46b4265ded3e45f389030b06","user":{"login":"kalkin","id":145191,"avatar_url":"https://avatars.githubusercontent.com/u/145191?v=3","gravatar_id":"","url":"https://api.github.com/users/kalkin","html_url":"https://github.com/kalkin","followers_url":"https://api.github.com/users/kalkin/followers","following_url":"https://api.github.com/users/kalkin/following{/other_user}","gists_url":"https://api.github.com/users/kalkin/gists{/gist_id}","starred_url":"https://api.github.com/users/kalkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kalkin/subscriptions","organizations_url":"https://api.github.com/users/kalkin/orgs","repos_url":"https://api.github.com/users/kalkin/repos","events_url":"https://api.github.com/users/kalkin/events{/privacy}","received_events_url":"https://api.github.com/users/kalkin/received_events","type":"User","site_admin":false},"body":"I just noticed `try: except` approach is already implemented. So i keep everything as it is?","created_at":"2016-04-22T14:30:50Z","updated_at":"2016-04-22T14:30:50Z","html_url":"https://github.com/woju/qubes-core-admin/pull/5#discussion_r60747860","pull_request_url":"https://api.github.com/repos/woju/qubes-core-admin/pulls/5","_links":{"self":{"href":"https://api.github.com/repos/woju/qubes-core-admin/pulls/comments/60747860"},"html":{"href":"https://github.com/woju/qubes-core-admin/pull/5#discussion_r60747860"},"pull_request":{"href":"https://api.github.com/repos/woju/qubes-core-admin/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/woju/qubes-core-admin/pulls/5","id":66842601,"html_url":"https://github.com/woju/qubes-core-admin/pull/5","diff_url":"https://github.com/woju/qubes-core-admin/pull/5.diff","patch_url":"https://github.com/woju/qubes-core-admin/pull/5.patch","issue_url":"https://api.github.com/repos/woju/qubes-core-admin/issues/5","number":5,"state":"open","locked":false,"title":"Storage Subsystem Design R4","user":{"login":"kalkin","id":145191,"avatar_url":"https://avatars.githubusercontent.com/u/145191?v=3","gravatar_id":"","url":"https://api.github.com/users/kalkin","html_url":"https://github.com/kalkin","followers_url":"https://api.github.com/users/kalkin/followers","following_url":"https://api.github.com/users/kalkin/following{/other_user}","gists_url":"https://api.github.com/users/kalkin/gists{/gist_id}","starred_url":"https://api.github.com/users/kalkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kalkin/subscriptions","organizations_url":"https://api.github.com/users/kalkin/orgs","repos_url":"https://api.github.com/users/kalkin/repos","events_url":"https://api.github.com/users/kalkin/events{/privacy}","received_events_url":"https://api.github.com/users/kalkin/received_events","type":"User","site_admin":false},"body":"Storage Subsystem Design R4\r\n\r\nThis PR contains all the discussed storage changes from\r\nQubesOS/qubes-issues#1842 & woju/qubes-core-admin/pull/2 :\r\n\r\n- Pools shouldn't hold a a reference to the vm object.\r\n- The domain reference should only be passed on `Pool.init_volume`\r\n- Rewrote the logic for discovering the root image of an AppVM\r\n\r\nI also squashed and rebased from 80 commits down to more manageable ~40\r\n\r\nThis pr depends on the woju/qubes-core-admin/pull/4","created_at":"2016-04-18T12:10:31Z","updated_at":"2016-04-22T14:30:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6000c9161bcc75cf42d8e6fbf38f7da06e352d51","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/woju/qubes-core-admin/pulls/5/commits","review_comments_url":"https://api.github.com/repos/woju/qubes-core-admin/pulls/5/comments","review_comment_url":"https://api.github.com/repos/woju/qubes-core-admin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/woju/qubes-core-admin/issues/5/comments","statuses_url":"https://api.github.com/repos/woju/qubes-core-admin/statuses/38d1ed698163451e46b4265ded3e45f389030b06","head":{"label":"kalkin:storage-subsystem-rewrite","ref":"storage-subsystem-rewrite","sha":"38d1ed698163451e46b4265ded3e45f389030b06","user":{"login":"kalkin","id":145191,"avatar_url":"https://avatars.githubusercontent.com/u/145191?v=3","gravatar_id":"","url":"https://api.github.com/users/kalkin","html_url":"https://github.com/kalkin","followers_url":"https://api.github.com/users/kalkin/followers","following_url":"https://api.github.com/users/kalkin/following{/other_user}","gists_url":"https://api.github.com/users/kalkin/gists{/gist_id}","starred_url":"https://api.github.com/users/kalkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kalkin/subscriptions","organizations_url":"https://api.github.com/users/kalkin/orgs","repos_url":"https://api.github.com/users/kalkin/repos","events_url":"https://api.github.com/users/kalkin/events{/privacy}","received_events_url":"https://api.github.com/users/kalkin/received_events","type":"User","site_admin":false},"repo":{"id":30782377,"name":"qubes-core-admin","full_name":"kalkin/qubes-core-admin","owner":{"login":"kalkin","id":145191,"avatar_url":"https://avatars.githubusercontent.com/u/145191?v=3","gravatar_id":"","url":"https://api.github.com/users/kalkin","html_url":"https://github.com/kalkin","followers_url":"https://api.github.com/users/kalkin/followers","following_url":"https://api.github.com/users/kalkin/following{/other_user}","gists_url":"https://api.github.com/users/kalkin/gists{/gist_id}","starred_url":"https://api.github.com/users/kalkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kalkin/subscriptions","organizations_url":"https://api.github.com/users/kalkin/orgs","repos_url":"https://api.github.com/users/kalkin/repos","events_url":"https://api.github.com/users/kalkin/events{/privacy}","received_events_url":"https://api.github.com/users/kalkin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kalkin/qubes-core-admin","description":"Qubes component: core-admin","fork":true,"url":"https://api.github.com/repos/kalkin/qubes-core-admin","forks_url":"https://api.github.com/repos/kalkin/qubes-core-admin/forks","keys_url":"https://api.github.com/repos/kalkin/qubes-core-admin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kalkin/qubes-core-admin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kalkin/qubes-core-admin/teams","hooks_url":"https://api.github.com/repos/kalkin/qubes-core-admin/hooks","issue_events_url":"https://api.github.com/repos/kalkin/qubes-core-admin/issues/events{/number}","events_url":"https://api.github.com/repos/kalkin/qubes-core-admin/events","assignees_url":"https://api.github.com/repos/kalkin/qubes-core-admin/assignees{/user}","branches_url":"https://api.github.com/repos/kalkin/qubes-core-admin/branches{/branch}","tags_url":"https://api.github.com/repos/kalkin/qubes-core-admin/tags","blobs_url":"https://api.github.com/repos/kalkin/qubes-core-admin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kalkin/qubes-core-admin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kalkin/qubes-core-admin/git/refs{/sha}","trees_url":"https://api.github.com/repos/kalkin/qubes-core-admin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kalkin/qubes-core-admin/statuses/{sha}","languages_url":"https://api.github.com/repos/kalkin/qubes-core-admin/languages","stargazers_url":"https://api.github.com/repos/kalkin/qubes-core-admin/stargazers","contributors_url":"https://api.github.com/repos/kalkin/qubes-core-admin/contributors","subscribers_url":"https://api.github.com/repos/kalkin/qubes-core-admin/subscribers","subscription_url":"https://api.github.com/repos/kalkin/qubes-core-admin/subscription","commits_url":"https://api.github.com/repos/kalkin/qubes-core-admin/commits{/sha}","git_commits_url":"https://api.github.com/repos/kalkin/qubes-core-admin/git/commits{/sha}","comments_url":"https://api.github.com/repos/kalkin/qubes-core-admin/comments{/number}","issue_comment_url":"https://api.github.com/repos/kalkin/qubes-core-admin/issues/comments{/number}","contents_url":"https://api.github.com/repos/kalkin/qubes-core-admin/contents/{+path}","compare_url":"https://api.github.com/repos/kalkin/qubes-core-admin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kalkin/qubes-core-admin/merges","archive_url":"https://api.github.com/repos/kalkin/qubes-core-admin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kalkin/qubes-core-admin/downloads","issues_url":"https://api.github.com/repos/kalkin/qubes-core-admin/issues{/number}","pulls_url":"https://api.github.com/repos/kalkin/qubes-core-admin/pulls{/number}","milestones_url":"https://api.github.com/repos/kalkin/qubes-core-admin/milestones{/number}","notifications_url":"https://api.github.com/repos/kalkin/qubes-core-admin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kalkin/qubes-core-admin/labels{/name}","releases_url":"https://api.github.com/repos/kalkin/qubes-core-admin/releases{/id}","deployments_url":"https://api.github.com/repos/kalkin/qubes-core-admin/deployments","created_at":"2015-02-14T00:36:10Z","updated_at":"2016-04-20T12:40:29Z","pushed_at":"2016-04-18T12:18:33Z","git_url":"git://github.com/kalkin/qubes-core-admin.git","ssh_url":"git@github.com:kalkin/qubes-core-admin.git","clone_url":"https://github.com/kalkin/qubes-core-admin.git","svn_url":"https://github.com/kalkin/qubes-core-admin","homepage":null,"size":9902,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"woju:core3-devel","ref":"core3-devel","sha":"540942de475706143f1c86362e96c9fa6eb461bd","user":{"login":"woju","id":1550337,"avatar_url":"https://avatars.githubusercontent.com/u/1550337?v=3","gravatar_id":"","url":"https://api.github.com/users/woju","html_url":"https://github.com/woju","followers_url":"https://api.github.com/users/woju/followers","following_url":"https://api.github.com/users/woju/following{/other_user}","gists_url":"https://api.github.com/users/woju/gists{/gist_id}","starred_url":"https://api.github.com/users/woju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/woju/subscriptions","organizations_url":"https://api.github.com/users/woju/orgs","repos_url":"https://api.github.com/users/woju/repos","events_url":"https://api.github.com/users/woju/events{/privacy}","received_events_url":"https://api.github.com/users/woju/received_events","type":"User","site_admin":false},"repo":{"id":31896140,"name":"qubes-core-admin","full_name":"woju/qubes-core-admin","owner":{"login":"woju","id":1550337,"avatar_url":"https://avatars.githubusercontent.com/u/1550337?v=3","gravatar_id":"","url":"https://api.github.com/users/woju","html_url":"https://github.com/woju","followers_url":"https://api.github.com/users/woju/followers","following_url":"https://api.github.com/users/woju/following{/other_user}","gists_url":"https://api.github.com/users/woju/gists{/gist_id}","starred_url":"https://api.github.com/users/woju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/woju/subscriptions","organizations_url":"https://api.github.com/users/woju/orgs","repos_url":"https://api.github.com/users/woju/repos","events_url":"https://api.github.com/users/woju/events{/privacy}","received_events_url":"https://api.github.com/users/woju/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/woju/qubes-core-admin","description":"Qubes component: core-admin","fork":true,"url":"https://api.github.com/repos/woju/qubes-core-admin","forks_url":"https://api.github.com/repos/woju/qubes-core-admin/forks","keys_url":"https://api.github.com/repos/woju/qubes-core-admin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/woju/qubes-core-admin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/woju/qubes-core-admin/teams","hooks_url":"https://api.github.com/repos/woju/qubes-core-admin/hooks","issue_events_url":"https://api.github.com/repos/woju/qubes-core-admin/issues/events{/number}","events_url":"https://api.github.com/repos/woju/qubes-core-admin/events","assignees_url":"https://api.github.com/repos/woju/qubes-core-admin/assignees{/user}","branches_url":"https://api.github.com/repos/woju/qubes-core-admin/branches{/branch}","tags_url":"https://api.github.com/repos/woju/qubes-core-admin/tags","blobs_url":"https://api.github.com/repos/woju/qubes-core-admin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/woju/qubes-core-admin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/woju/qubes-core-admin/git/refs{/sha}","trees_url":"https://api.github.com/repos/woju/qubes-core-admin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/woju/qubes-core-admin/statuses/{sha}","languages_url":"https://api.github.com/repos/woju/qubes-core-admin/languages","stargazers_url":"https://api.github.com/repos/woju/qubes-core-admin/stargazers","contributors_url":"https://api.github.com/repos/woju/qubes-core-admin/contributors","subscribers_url":"https://api.github.com/repos/woju/qubes-core-admin/subscribers","subscription_url":"https://api.github.com/repos/woju/qubes-core-admin/subscription","commits_url":"https://api.github.com/repos/woju/qubes-core-admin/commits{/sha}","git_commits_url":"https://api.github.com/repos/woju/qubes-core-admin/git/commits{/sha}","comments_url":"https://api.github.com/repos/woju/qubes-core-admin/comments{/number}","issue_comment_url":"https://api.github.com/repos/woju/qubes-core-admin/issues/comments{/number}","contents_url":"https://api.github.com/repos/woju/qubes-core-admin/contents/{+path}","compare_url":"https://api.github.com/repos/woju/qubes-core-admin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/woju/qubes-core-admin/merges","archive_url":"https://api.github.com/repos/woju/qubes-core-admin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/woju/qubes-core-admin/downloads","issues_url":"https://api.github.com/repos/woju/qubes-core-admin/issues{/number}","pulls_url":"https://api.github.com/repos/woju/qubes-core-admin/pulls{/number}","milestones_url":"https://api.github.com/repos/woju/qubes-core-admin/milestones{/number}","notifications_url":"https://api.github.com/repos/woju/qubes-core-admin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/woju/qubes-core-admin/labels{/name}","releases_url":"https://api.github.com/repos/woju/qubes-core-admin/releases{/id}","deployments_url":"https://api.github.com/repos/woju/qubes-core-admin/deployments","created_at":"2015-03-09T12:04:24Z","updated_at":"2016-01-29T16:57:09Z","pushed_at":"2016-04-22T14:22:52Z","git_url":"git://github.com/woju/qubes-core-admin.git","ssh_url":"git@github.com:woju/qubes-core-admin.git","clone_url":"https://github.com/woju/qubes-core-admin.git","svn_url":"https://github.com/woju/qubes-core-admin","homepage":null,"size":11803,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"core3-devel"}},"_links":{"self":{"href":"https://api.github.com/repos/woju/qubes-core-admin/pulls/5"},"html":{"href":"https://github.com/woju/qubes-core-admin/pull/5"},"issue":{"href":"https://api.github.com/repos/woju/qubes-core-admin/issues/5"},"comments":{"href":"https://api.github.com/repos/woju/qubes-core-admin/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/woju/qubes-core-admin/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/woju/qubes-core-admin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/woju/qubes-core-admin/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/woju/qubes-core-admin/statuses/38d1ed698163451e46b4265ded3e45f389030b06"}}}}