{"action":"created","issue":{"url":"https://api.github.com/repos/enigma-dev/enigma-dev/issues/999","repository_url":"https://api.github.com/repos/enigma-dev/enigma-dev","labels_url":"https://api.github.com/repos/enigma-dev/enigma-dev/issues/999/labels{/name}","comments_url":"https://api.github.com/repos/enigma-dev/enigma-dev/issues/999/comments","events_url":"https://api.github.com/repos/enigma-dev/enigma-dev/issues/999/events","html_url":"https://github.com/enigma-dev/enigma-dev/pull/999","id":171032312,"number":999,"title":"Fix `with()` smashing","user":{"login":"JoshDreamland","id":164340,"avatar_url":"https://avatars.githubusercontent.com/u/164340?v=3","gravatar_id":"","url":"https://api.github.com/users/JoshDreamland","html_url":"https://github.com/JoshDreamland","followers_url":"https://api.github.com/users/JoshDreamland/followers","following_url":"https://api.github.com/users/JoshDreamland/following{/other_user}","gists_url":"https://api.github.com/users/JoshDreamland/gists{/gist_id}","starred_url":"https://api.github.com/users/JoshDreamland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoshDreamland/subscriptions","organizations_url":"https://api.github.com/users/JoshDreamland/orgs","repos_url":"https://api.github.com/users/JoshDreamland/repos","events_url":"https://api.github.com/users/JoshDreamland/events{/privacy}","received_events_url":"https://api.github.com/users/JoshDreamland/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-08-13T23:09:30Z","updated_at":"2016-08-15T15:33:12Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/enigma-dev/enigma-dev/pulls/999","html_url":"https://github.com/enigma-dev/enigma-dev/pull/999","diff_url":"https://github.com/enigma-dev/enigma-dev/pull/999.diff","patch_url":"https://github.com/enigma-dev/enigma-dev/pull/999.patch"},"body":"As noted in #983, there are some visibility issues with the current iterator class that allowed a stacked pointer to be persisted in another object past its lifetime. This caused segfaults when cleaning up after a `with()` execution. This change simplifies that system a bit, and hides those members to make this problem impossible in the future.\r\n\r\nI have verified that this change builds on Arch Linux. I have no information on whether it will build on Windows, or whether it will break old games. Robert, if you would, please test it against games that use instance creation code, and games that use `with()` heavily, in addition to the case in #983.\r\n\r\nThis branch contains #998; merge it, first."},"comment":{"url":"https://api.github.com/repos/enigma-dev/enigma-dev/issues/comments/239834297","html_url":"https://github.com/enigma-dev/enigma-dev/pull/999#issuecomment-239834297","issue_url":"https://api.github.com/repos/enigma-dev/enigma-dev/issues/999","id":239834297,"user":{"login":"JoshDreamland","id":164340,"avatar_url":"https://avatars.githubusercontent.com/u/164340?v=3","gravatar_id":"","url":"https://api.github.com/users/JoshDreamland","html_url":"https://github.com/JoshDreamland","followers_url":"https://api.github.com/users/JoshDreamland/followers","following_url":"https://api.github.com/users/JoshDreamland/following{/other_user}","gists_url":"https://api.github.com/users/JoshDreamland/gists{/gist_id}","starred_url":"https://api.github.com/users/JoshDreamland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoshDreamland/subscriptions","organizations_url":"https://api.github.com/users/JoshDreamland/orgs","repos_url":"https://api.github.com/users/JoshDreamland/repos","events_url":"https://api.github.com/users/JoshDreamland/events{/privacy}","received_events_url":"https://api.github.com/users/JoshDreamland/received_events","type":"User","site_admin":false},"created_at":"2016-08-15T15:33:12Z","updated_at":"2016-08-15T15:33:12Z","body":"Also, please get that diffbase (#998) merged, first, so the diff of this change is useful."}}
{"actor":{"display_login":"JoshDreamland"}}