{"action":"created","issue":{"url":"https://api.github.com/repos/DFHack/dfhack/issues/907","repository_url":"https://api.github.com/repos/DFHack/dfhack","labels_url":"https://api.github.com/repos/DFHack/dfhack/issues/907/labels{/name}","comments_url":"https://api.github.com/repos/DFHack/dfhack/issues/907/comments","events_url":"https://api.github.com/repos/DFHack/dfhack/issues/907/events","html_url":"https://github.com/DFHack/dfhack/issues/907","id":150699304,"number":907,"title":"Move Sphinx build directory to inside CMake build directory","user":{"login":"lethosor","id":3719547,"avatar_url":"https://avatars.githubusercontent.com/u/3719547?v=3","gravatar_id":"","url":"https://api.github.com/users/lethosor","html_url":"https://github.com/lethosor","followers_url":"https://api.github.com/users/lethosor/followers","following_url":"https://api.github.com/users/lethosor/following{/other_user}","gists_url":"https://api.github.com/users/lethosor/gists{/gist_id}","starred_url":"https://api.github.com/users/lethosor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lethosor/subscriptions","organizations_url":"https://api.github.com/users/lethosor/orgs","repos_url":"https://api.github.com/users/lethosor/repos","events_url":"https://api.github.com/users/lethosor/events{/privacy}","received_events_url":"https://api.github.com/users/lethosor/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/DFHack/dfhack/labels/build","name":"build","color":"ff0066"},{"url":"https://api.github.com/repos/DFHack/dfhack/labels/documentation","name":"documentation","color":"009900"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/DFHack/dfhack/milestones/6","html_url":"https://github.com/DFHack/dfhack/milestones/0.42.xx-r2","labels_url":"https://api.github.com/repos/DFHack/dfhack/milestones/6/labels","id":1467480,"number":6,"title":"0.42.xx-r2","description":"Next feature release","creator":{"login":"lethosor","id":3719547,"avatar_url":"https://avatars.githubusercontent.com/u/3719547?v=3","gravatar_id":"","url":"https://api.github.com/users/lethosor","html_url":"https://github.com/lethosor","followers_url":"https://api.github.com/users/lethosor/followers","following_url":"https://api.github.com/users/lethosor/following{/other_user}","gists_url":"https://api.github.com/users/lethosor/gists{/gist_id}","starred_url":"https://api.github.com/users/lethosor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lethosor/subscriptions","organizations_url":"https://api.github.com/users/lethosor/orgs","repos_url":"https://api.github.com/users/lethosor/repos","events_url":"https://api.github.com/users/lethosor/events{/privacy}","received_events_url":"https://api.github.com/users/lethosor/received_events","type":"User","site_admin":false},"open_issues":8,"closed_issues":0,"state":"open","created_at":"2015-12-18T23:57:45Z","updated_at":"2016-04-24T21:00:08Z","due_on":null,"closed_at":null},"comments":1,"created_at":"2016-04-24T21:00:08Z","updated_at":"2016-04-24T21:13:42Z","closed_at":null,"body":"It's generally better to have anything generated at build time inside the current CMake build folder ($CMAKE_BINARY_DIR, e.g. `build`, `build-osx`, `build-cross-linux`, `build-gcc4x`, etc.) instead of in the DFHack source tree. When multiple build directories are being used in the same DFHack clone, a build step in one writing to files in the source tree (outside of the current build folder) can cause the build process in all other build folders to re-run jobs that depend on those files unnecessarily. I'm not entirely sure if anything does depend on the generated HTML files (there shouldn't be anything, ideally, aside from the installation process), and the HTML files should be consistent regardless of the build directory, but it would be good practice nonetheless.\r\n\r\n(I ran into a similar issue with protobuf's testHashMap.cpp being placed in the source tree, which meant that switching build directories and running `make` would re-run `cmake` every time, since testHashMap.cpp had been changed from the other build folder.)"},"comment":{"url":"https://api.github.com/repos/DFHack/dfhack/issues/comments/214038261","html_url":"https://github.com/DFHack/dfhack/issues/907#issuecomment-214038261","issue_url":"https://api.github.com/repos/DFHack/dfhack/issues/907","id":214038261,"user":{"login":"lethosor","id":3719547,"avatar_url":"https://avatars.githubusercontent.com/u/3719547?v=3","gravatar_id":"","url":"https://api.github.com/users/lethosor","html_url":"https://github.com/lethosor","followers_url":"https://api.github.com/users/lethosor/followers","following_url":"https://api.github.com/users/lethosor/following{/other_user}","gists_url":"https://api.github.com/users/lethosor/gists{/gist_id}","starred_url":"https://api.github.com/users/lethosor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lethosor/subscriptions","organizations_url":"https://api.github.com/users/lethosor/orgs","repos_url":"https://api.github.com/users/lethosor/repos","events_url":"https://api.github.com/users/lethosor/events{/privacy}","received_events_url":"https://api.github.com/users/lethosor/received_events","type":"User","site_admin":false},"created_at":"2016-04-24T21:13:42Z","updated_at":"2016-04-24T21:13:42Z","body":"Actually, Sphinx is smart enough to not rebuild anything if the docs haven't changed since another build process built them. Not sure if this is necessary at all, then."}}