{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corert/pulls/comments/62589110","id":62589110,"diff_hunk":"@@ -2168,13 +2218,35 @@ public int GetLowerBound(int dimension)\n \n             if (this.Rank != 1)\n                 throw new PlatformNotSupportedException(SR.Rank_MultiDimNotSupported);\n+#endif\n             if (dimension != 0)\n                 throw new IndexOutOfRangeException();\n             return 0;\n         }\n \n         public int GetUpperBound(int dimension)\n         {\n+#if CORERT","path":"src/System.Private.CoreLib/src/System/Array.cs","position":104,"original_position":104,"commit_id":"daa33e2284eda6d74630d18e716443019ec51081","original_commit_id":"daa33e2284eda6d74630d18e716443019ec51081","user":{"login":"jkotas","id":6668460,"avatar_url":"https://avatars.githubusercontent.com/u/6668460?v=3","gravatar_id":"","url":"https://api.github.com/users/jkotas","html_url":"https://github.com/jkotas","followers_url":"https://api.github.com/users/jkotas/followers","following_url":"https://api.github.com/users/jkotas/following{/other_user}","gists_url":"https://api.github.com/users/jkotas/gists{/gist_id}","starred_url":"https://api.github.com/users/jkotas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkotas/subscriptions","organizations_url":"https://api.github.com/users/jkotas/orgs","repos_url":"https://api.github.com/users/jkotas/repos","events_url":"https://api.github.com/users/jkotas/events{/privacy}","received_events_url":"https://api.github.com/users/jkotas/received_events","type":"User","site_admin":false},"body":"I think it would be worth it to have unique #define for it, so that we have easier time cleaning it up later once we unify.","created_at":"2016-05-09T23:13:43Z","updated_at":"2016-05-09T23:13:43Z","html_url":"https://github.com/dotnet/corert/pull/1263#discussion_r62589110","pull_request_url":"https://api.github.com/repos/dotnet/corert/pulls/1263","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corert/pulls/comments/62589110"},"html":{"href":"https://github.com/dotnet/corert/pull/1263#discussion_r62589110"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corert/pulls/1263"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corert/pulls/1263","id":69419233,"html_url":"https://github.com/dotnet/corert/pull/1263","diff_url":"https://github.com/dotnet/corert/pull/1263.diff","patch_url":"https://github.com/dotnet/corert/pull/1263.patch","issue_url":"https://api.github.com/repos/dotnet/corert/issues/1263","number":1263,"state":"open","locked":false,"title":"Fix handling of multi-dim arrays in `System.Array`","user":{"login":"MichalStrehovsky","id":13110571,"avatar_url":"https://avatars.githubusercontent.com/u/13110571?v=3","gravatar_id":"","url":"https://api.github.com/users/MichalStrehovsky","html_url":"https://github.com/MichalStrehovsky","followers_url":"https://api.github.com/users/MichalStrehovsky/followers","following_url":"https://api.github.com/users/MichalStrehovsky/following{/other_user}","gists_url":"https://api.github.com/users/MichalStrehovsky/gists{/gist_id}","starred_url":"https://api.github.com/users/MichalStrehovsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MichalStrehovsky/subscriptions","organizations_url":"https://api.github.com/users/MichalStrehovsky/orgs","repos_url":"https://api.github.com/users/MichalStrehovsky/repos","events_url":"https://api.github.com/users/MichalStrehovsky/events{/privacy}","received_events_url":"https://api.github.com/users/MichalStrehovsky/received_events","type":"User","site_admin":false},"body":"On CoreRT we diverged from Project N by treating multi-dim arrays same\r\nas CLR. BCL needs to be fixed to reflect that.\r\n\r\nThings that still need fixing:\r\n* Various Copy details\r\n* Enumerator\r\n* SetValue(params)/GetValue(params)\r\n\r\nI'll do those in a later pull request - the more code this has, the harder it is to review it. I'll keep #1103 open.","created_at":"2016-05-09T22:08:25Z","updated_at":"2016-05-09T23:13:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"74e86a3f5069218009388607982e466a0e7e4532","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corert/pulls/1263/commits","review_comments_url":"https://api.github.com/repos/dotnet/corert/pulls/1263/comments","review_comment_url":"https://api.github.com/repos/dotnet/corert/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corert/issues/1263/comments","statuses_url":"https://api.github.com/repos/dotnet/corert/statuses/daa33e2284eda6d74630d18e716443019ec51081","head":{"label":"MichalStrehovsky:mdArrayFixes","ref":"mdArrayFixes","sha":"daa33e2284eda6d74630d18e716443019ec51081","user":{"login":"MichalStrehovsky","id":13110571,"avatar_url":"https://avatars.githubusercontent.com/u/13110571?v=3","gravatar_id":"","url":"https://api.github.com/users/MichalStrehovsky","html_url":"https://github.com/MichalStrehovsky","followers_url":"https://api.github.com/users/MichalStrehovsky/followers","following_url":"https://api.github.com/users/MichalStrehovsky/following{/other_user}","gists_url":"https://api.github.com/users/MichalStrehovsky/gists{/gist_id}","starred_url":"https://api.github.com/users/MichalStrehovsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MichalStrehovsky/subscriptions","organizations_url":"https://api.github.com/users/MichalStrehovsky/orgs","repos_url":"https://api.github.com/users/MichalStrehovsky/repos","events_url":"https://api.github.com/users/MichalStrehovsky/events{/privacy}","received_events_url":"https://api.github.com/users/MichalStrehovsky/received_events","type":"User","site_admin":false},"repo":{"id":46432791,"name":"corert","full_name":"MichalStrehovsky/corert","owner":{"login":"MichalStrehovsky","id":13110571,"avatar_url":"https://avatars.githubusercontent.com/u/13110571?v=3","gravatar_id":"","url":"https://api.github.com/users/MichalStrehovsky","html_url":"https://github.com/MichalStrehovsky","followers_url":"https://api.github.com/users/MichalStrehovsky/followers","following_url":"https://api.github.com/users/MichalStrehovsky/following{/other_user}","gists_url":"https://api.github.com/users/MichalStrehovsky/gists{/gist_id}","starred_url":"https://api.github.com/users/MichalStrehovsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MichalStrehovsky/subscriptions","organizations_url":"https://api.github.com/users/MichalStrehovsky/orgs","repos_url":"https://api.github.com/users/MichalStrehovsky/repos","events_url":"https://api.github.com/users/MichalStrehovsky/events{/privacy}","received_events_url":"https://api.github.com/users/MichalStrehovsky/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MichalStrehovsky/corert","description":"This repo contains CoreRT, a .NET Core runtime optimized for AOT (ahead of time compilation) scenarios, with the accompanying .NET Native compiler toolchain.","fork":true,"url":"https://api.github.com/repos/MichalStrehovsky/corert","forks_url":"https://api.github.com/repos/MichalStrehovsky/corert/forks","keys_url":"https://api.github.com/repos/MichalStrehovsky/corert/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MichalStrehovsky/corert/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MichalStrehovsky/corert/teams","hooks_url":"https://api.github.com/repos/MichalStrehovsky/corert/hooks","issue_events_url":"https://api.github.com/repos/MichalStrehovsky/corert/issues/events{/number}","events_url":"https://api.github.com/repos/MichalStrehovsky/corert/events","assignees_url":"https://api.github.com/repos/MichalStrehovsky/corert/assignees{/user}","branches_url":"https://api.github.com/repos/MichalStrehovsky/corert/branches{/branch}","tags_url":"https://api.github.com/repos/MichalStrehovsky/corert/tags","blobs_url":"https://api.github.com/repos/MichalStrehovsky/corert/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MichalStrehovsky/corert/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MichalStrehovsky/corert/git/refs{/sha}","trees_url":"https://api.github.com/repos/MichalStrehovsky/corert/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MichalStrehovsky/corert/statuses/{sha}","languages_url":"https://api.github.com/repos/MichalStrehovsky/corert/languages","stargazers_url":"https://api.github.com/repos/MichalStrehovsky/corert/stargazers","contributors_url":"https://api.github.com/repos/MichalStrehovsky/corert/contributors","subscribers_url":"https://api.github.com/repos/MichalStrehovsky/corert/subscribers","subscription_url":"https://api.github.com/repos/MichalStrehovsky/corert/subscription","commits_url":"https://api.github.com/repos/MichalStrehovsky/corert/commits{/sha}","git_commits_url":"https://api.github.com/repos/MichalStrehovsky/corert/git/commits{/sha}","comments_url":"https://api.github.com/repos/MichalStrehovsky/corert/comments{/number}","issue_comment_url":"https://api.github.com/repos/MichalStrehovsky/corert/issues/comments{/number}","contents_url":"https://api.github.com/repos/MichalStrehovsky/corert/contents/{+path}","compare_url":"https://api.github.com/repos/MichalStrehovsky/corert/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MichalStrehovsky/corert/merges","archive_url":"https://api.github.com/repos/MichalStrehovsky/corert/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MichalStrehovsky/corert/downloads","issues_url":"https://api.github.com/repos/MichalStrehovsky/corert/issues{/number}","pulls_url":"https://api.github.com/repos/MichalStrehovsky/corert/pulls{/number}","milestones_url":"https://api.github.com/repos/MichalStrehovsky/corert/milestones{/number}","notifications_url":"https://api.github.com/repos/MichalStrehovsky/corert/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MichalStrehovsky/corert/labels{/name}","releases_url":"https://api.github.com/repos/MichalStrehovsky/corert/releases{/id}","deployments_url":"https://api.github.com/repos/MichalStrehovsky/corert/deployments","created_at":"2015-11-18T16:45:32Z","updated_at":"2016-01-14T03:31:37Z","pushed_at":"2016-05-09T22:47:49Z","git_url":"git://github.com/MichalStrehovsky/corert.git","ssh_url":"git@github.com:MichalStrehovsky/corert.git","clone_url":"https://github.com/MichalStrehovsky/corert.git","svn_url":"https://github.com/MichalStrehovsky/corert","homepage":"http://dotnet.github.io/","size":9166,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"8974bd09e2b430a5ee0aaaa25ac0f2162c3a048a","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":42552143,"name":"corert","full_name":"dotnet/corert","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corert","description":"This repo contains CoreRT, a .NET Core runtime optimized for AOT (ahead of time compilation) scenarios, with the accompanying .NET Native compiler toolchain.","fork":false,"url":"https://api.github.com/repos/dotnet/corert","forks_url":"https://api.github.com/repos/dotnet/corert/forks","keys_url":"https://api.github.com/repos/dotnet/corert/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corert/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corert/teams","hooks_url":"https://api.github.com/repos/dotnet/corert/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corert/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corert/events","assignees_url":"https://api.github.com/repos/dotnet/corert/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corert/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corert/tags","blobs_url":"https://api.github.com/repos/dotnet/corert/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corert/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corert/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corert/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corert/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corert/languages","stargazers_url":"https://api.github.com/repos/dotnet/corert/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corert/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corert/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corert/subscription","commits_url":"https://api.github.com/repos/dotnet/corert/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corert/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corert/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corert/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corert/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corert/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corert/merges","archive_url":"https://api.github.com/repos/dotnet/corert/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corert/downloads","issues_url":"https://api.github.com/repos/dotnet/corert/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corert/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corert/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corert/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corert/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corert/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/corert/deployments","created_at":"2015-09-15T23:10:53Z","updated_at":"2016-05-08T21:42:19Z","pushed_at":"2016-05-09T22:47:49Z","git_url":"git://github.com/dotnet/corert.git","ssh_url":"git@github.com:dotnet/corert.git","clone_url":"https://github.com/dotnet/corert.git","svn_url":"https://github.com/dotnet/corert","homepage":"http://dotnet.github.io/","size":17375,"stargazers_count":331,"watchers_count":331,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":95,"mirror_url":null,"open_issues_count":141,"forks":95,"open_issues":141,"watchers":331,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corert/pulls/1263"},"html":{"href":"https://github.com/dotnet/corert/pull/1263"},"issue":{"href":"https://api.github.com/repos/dotnet/corert/issues/1263"},"comments":{"href":"https://api.github.com/repos/dotnet/corert/issues/1263/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corert/pulls/1263/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corert/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corert/pulls/1263/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corert/statuses/daa33e2284eda6d74630d18e716443019ec51081"}}}}