{"action":"created","comment":{"url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/comments/58199986","id":58199986,"diff_hunk":"@@ -1,11 +1,13 @@\n /**\n  * External dependencies\n  */\n-import React from 'react';\n+import React, { PropTypes } from 'react';\n+import PureRenderMixin from 'react-pure-render/mixin';\n import classnames from 'classnames';\n import { connect } from 'react-redux';\n import { bindActionCreators } from 'redux';\n import get from 'lodash/get';\n+import noop from 'lodash/noop';\n import { translate } from 'lib/mixins/i18n';","path":"client/post-editor/editor-sidebar/header.jsx","position":12,"original_position":12,"commit_id":"35923635c2c80fa89b0d3fa203c0f3cfc6641994","original_commit_id":"35923635c2c80fa89b0d3fa203c0f3cfc6641994","user":{"login":"aduth","id":1779930,"avatar_url":"https://avatars.githubusercontent.com/u/1779930?v=3","gravatar_id":"","url":"https://api.github.com/users/aduth","html_url":"https://github.com/aduth","followers_url":"https://api.github.com/users/aduth/followers","following_url":"https://api.github.com/users/aduth/following{/other_user}","gists_url":"https://api.github.com/users/aduth/gists{/gist_id}","starred_url":"https://api.github.com/users/aduth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aduth/subscriptions","organizations_url":"https://api.github.com/users/aduth/orgs","repos_url":"https://api.github.com/users/aduth/repos","events_url":"https://api.github.com/users/aduth/events{/privacy}","received_events_url":"https://api.github.com/users/aduth/received_events","type":"User","site_admin":false},"body":"Wah, this should've never been external (my fault). In any case, two things to note: _If_ we did define this component using `React.createClass`, we could use the global `this.translate` mixin instead. However, more recently I'm evangelizing the [`localize` higher-order component](https://github.com/Automattic/wp-calypso/tree/master/client/lib/mixins/i18n/localize), even for `React.createClass`, as it's much less magical and easier to test, while still being straight-forward to use.","created_at":"2016-04-01T12:44:47Z","updated_at":"2016-04-01T12:44:47Z","html_url":"https://github.com/Automattic/wp-calypso/pull/4456#discussion_r58199986","pull_request_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/4456","_links":{"self":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/comments/58199986"},"html":{"href":"https://github.com/Automattic/wp-calypso/pull/4456#discussion_r58199986"},"pull_request":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/4456"}}},"pull_request":{"url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/4456","id":64853783,"html_url":"https://github.com/Automattic/wp-calypso/pull/4456","diff_url":"https://github.com/Automattic/wp-calypso/pull/4456.diff","patch_url":"https://github.com/Automattic/wp-calypso/pull/4456.patch","issue_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/4456","number":4456,"state":"open","locked":false,"title":"Editor: Mobile editor redesign (WIP)","user":{"login":"DanReyLop","id":1715800,"avatar_url":"https://avatars.githubusercontent.com/u/1715800?v=3","gravatar_id":"","url":"https://api.github.com/users/DanReyLop","html_url":"https://github.com/DanReyLop","followers_url":"https://api.github.com/users/DanReyLop/followers","following_url":"https://api.github.com/users/DanReyLop/following{/other_user}","gists_url":"https://api.github.com/users/DanReyLop/gists{/gist_id}","starred_url":"https://api.github.com/users/DanReyLop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanReyLop/subscriptions","organizations_url":"https://api.github.com/users/DanReyLop/orgs","repos_url":"https://api.github.com/users/DanReyLop/repos","events_url":"https://api.github.com/users/DanReyLop/events{/privacy}","received_events_url":"https://api.github.com/users/DanReyLop/received_events","type":"User","site_admin":false},"body":"I'm working on #4266, the UI revamp of the mobile post editor. This is by far the most complex task I've started yet, so I'm submitting what I have for now to have early feedback.\r\n\r\nThe main problem here is that with the new UI (see #4266), desktop and mobile are diverging more and more. I'm trying to tackle it by splitting the editor and sidebar into even smaller components.\r\n\r\nWhat is done:\r\n* Changed the mobile action bar to the new 'tab navigation'. Since with the new design the sidebar will be no longer be a sidebar _per se_, but another tab at the same level as the editor, I've removed the sidebar open/close animation.\r\n* Extracted the whole editor sidebar to its own component.\r\n* Extracted the \"Publish\" button to its own component, since it will have to be rendered both in the sidebar (desktop) and in the navigation header (mobile).\r\n* Some cleaning of the `EditorSidebarHeader` component, since now it's going to be a desktop-specific component.\r\n\r\nThe main UI changes are not yet implemented, so the \"mobile\" sidebar is still the old one (just now is rendered as a tab). There's still a lot of work to do, but if you could just take a look and tell me if you see something terribly wrong it would be great, so I don't lose time coding the wrong approach to this.\r\n\r\n@aduth Feel free to add who you consider relevant to this PR.","created_at":"2016-03-31T20:31:19Z","updated_at":"2016-04-01T12:44:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8dabe2c9b92867a8f55f2eedf92750897d2666d5","assignee":{"login":"DanReyLop","id":1715800,"avatar_url":"https://avatars.githubusercontent.com/u/1715800?v=3","gravatar_id":"","url":"https://api.github.com/users/DanReyLop","html_url":"https://github.com/DanReyLop","followers_url":"https://api.github.com/users/DanReyLop/followers","following_url":"https://api.github.com/users/DanReyLop/following{/other_user}","gists_url":"https://api.github.com/users/DanReyLop/gists{/gist_id}","starred_url":"https://api.github.com/users/DanReyLop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanReyLop/subscriptions","organizations_url":"https://api.github.com/users/DanReyLop/orgs","repos_url":"https://api.github.com/users/DanReyLop/repos","events_url":"https://api.github.com/users/DanReyLop/events{/privacy}","received_events_url":"https://api.github.com/users/DanReyLop/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/4456/commits","review_comments_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/4456/comments","review_comment_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/4456/comments","statuses_url":"https://api.github.com/repos/Automattic/wp-calypso/statuses/35923635c2c80fa89b0d3fa203c0f3cfc6641994","head":{"label":"Automattic:update/4266-mobile-editor-redesign","ref":"update/4266-mobile-editor-redesign","sha":"35923635c2c80fa89b0d3fa203c0f3cfc6641994","user":{"login":"Automattic","id":887802,"avatar_url":"https://avatars.githubusercontent.com/u/887802?v=3","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"repo":{"id":45936895,"name":"wp-calypso","full_name":"Automattic/wp-calypso","owner":{"login":"Automattic","id":887802,"avatar_url":"https://avatars.githubusercontent.com/u/887802?v=3","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Automattic/wp-calypso","description":"The new JavaScript- and API-powered WordPress.com","fork":false,"url":"https://api.github.com/repos/Automattic/wp-calypso","forks_url":"https://api.github.com/repos/Automattic/wp-calypso/forks","keys_url":"https://api.github.com/repos/Automattic/wp-calypso/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Automattic/wp-calypso/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Automattic/wp-calypso/teams","hooks_url":"https://api.github.com/repos/Automattic/wp-calypso/hooks","issue_events_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/events{/number}","events_url":"https://api.github.com/repos/Automattic/wp-calypso/events","assignees_url":"https://api.github.com/repos/Automattic/wp-calypso/assignees{/user}","branches_url":"https://api.github.com/repos/Automattic/wp-calypso/branches{/branch}","tags_url":"https://api.github.com/repos/Automattic/wp-calypso/tags","blobs_url":"https://api.github.com/repos/Automattic/wp-calypso/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Automattic/wp-calypso/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Automattic/wp-calypso/git/refs{/sha}","trees_url":"https://api.github.com/repos/Automattic/wp-calypso/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Automattic/wp-calypso/statuses/{sha}","languages_url":"https://api.github.com/repos/Automattic/wp-calypso/languages","stargazers_url":"https://api.github.com/repos/Automattic/wp-calypso/stargazers","contributors_url":"https://api.github.com/repos/Automattic/wp-calypso/contributors","subscribers_url":"https://api.github.com/repos/Automattic/wp-calypso/subscribers","subscription_url":"https://api.github.com/repos/Automattic/wp-calypso/subscription","commits_url":"https://api.github.com/repos/Automattic/wp-calypso/commits{/sha}","git_commits_url":"https://api.github.com/repos/Automattic/wp-calypso/git/commits{/sha}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/comments{/number}","issue_comment_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/comments{/number}","contents_url":"https://api.github.com/repos/Automattic/wp-calypso/contents/{+path}","compare_url":"https://api.github.com/repos/Automattic/wp-calypso/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Automattic/wp-calypso/merges","archive_url":"https://api.github.com/repos/Automattic/wp-calypso/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Automattic/wp-calypso/downloads","issues_url":"https://api.github.com/repos/Automattic/wp-calypso/issues{/number}","pulls_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls{/number}","milestones_url":"https://api.github.com/repos/Automattic/wp-calypso/milestones{/number}","notifications_url":"https://api.github.com/repos/Automattic/wp-calypso/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Automattic/wp-calypso/labels{/name}","releases_url":"https://api.github.com/repos/Automattic/wp-calypso/releases{/id}","deployments_url":"https://api.github.com/repos/Automattic/wp-calypso/deployments","created_at":"2015-11-10T20:00:16Z","updated_at":"2016-04-01T12:32:52Z","pushed_at":"2016-04-01T12:34:33Z","git_url":"git://github.com/Automattic/wp-calypso.git","ssh_url":"git@github.com:Automattic/wp-calypso.git","clone_url":"https://github.com/Automattic/wp-calypso.git","svn_url":"https://github.com/Automattic/wp-calypso","homepage":"https://developer.wordpress.com/calypso/","size":72908,"stargazers_count":7090,"watchers_count":7090,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":844,"mirror_url":null,"open_issues_count":1298,"forks":844,"open_issues":1298,"watchers":7090,"default_branch":"master"}},"base":{"label":"Automattic:master","ref":"master","sha":"c8e5482d1c4c1cbf9131d222690fe555dc1c60b0","user":{"login":"Automattic","id":887802,"avatar_url":"https://avatars.githubusercontent.com/u/887802?v=3","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"repo":{"id":45936895,"name":"wp-calypso","full_name":"Automattic/wp-calypso","owner":{"login":"Automattic","id":887802,"avatar_url":"https://avatars.githubusercontent.com/u/887802?v=3","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Automattic/wp-calypso","description":"The new JavaScript- and API-powered WordPress.com","fork":false,"url":"https://api.github.com/repos/Automattic/wp-calypso","forks_url":"https://api.github.com/repos/Automattic/wp-calypso/forks","keys_url":"https://api.github.com/repos/Automattic/wp-calypso/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Automattic/wp-calypso/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Automattic/wp-calypso/teams","hooks_url":"https://api.github.com/repos/Automattic/wp-calypso/hooks","issue_events_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/events{/number}","events_url":"https://api.github.com/repos/Automattic/wp-calypso/events","assignees_url":"https://api.github.com/repos/Automattic/wp-calypso/assignees{/user}","branches_url":"https://api.github.com/repos/Automattic/wp-calypso/branches{/branch}","tags_url":"https://api.github.com/repos/Automattic/wp-calypso/tags","blobs_url":"https://api.github.com/repos/Automattic/wp-calypso/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Automattic/wp-calypso/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Automattic/wp-calypso/git/refs{/sha}","trees_url":"https://api.github.com/repos/Automattic/wp-calypso/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Automattic/wp-calypso/statuses/{sha}","languages_url":"https://api.github.com/repos/Automattic/wp-calypso/languages","stargazers_url":"https://api.github.com/repos/Automattic/wp-calypso/stargazers","contributors_url":"https://api.github.com/repos/Automattic/wp-calypso/contributors","subscribers_url":"https://api.github.com/repos/Automattic/wp-calypso/subscribers","subscription_url":"https://api.github.com/repos/Automattic/wp-calypso/subscription","commits_url":"https://api.github.com/repos/Automattic/wp-calypso/commits{/sha}","git_commits_url":"https://api.github.com/repos/Automattic/wp-calypso/git/commits{/sha}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/comments{/number}","issue_comment_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/comments{/number}","contents_url":"https://api.github.com/repos/Automattic/wp-calypso/contents/{+path}","compare_url":"https://api.github.com/repos/Automattic/wp-calypso/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Automattic/wp-calypso/merges","archive_url":"https://api.github.com/repos/Automattic/wp-calypso/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Automattic/wp-calypso/downloads","issues_url":"https://api.github.com/repos/Automattic/wp-calypso/issues{/number}","pulls_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls{/number}","milestones_url":"https://api.github.com/repos/Automattic/wp-calypso/milestones{/number}","notifications_url":"https://api.github.com/repos/Automattic/wp-calypso/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Automattic/wp-calypso/labels{/name}","releases_url":"https://api.github.com/repos/Automattic/wp-calypso/releases{/id}","deployments_url":"https://api.github.com/repos/Automattic/wp-calypso/deployments","created_at":"2015-11-10T20:00:16Z","updated_at":"2016-04-01T12:32:52Z","pushed_at":"2016-04-01T12:34:33Z","git_url":"git://github.com/Automattic/wp-calypso.git","ssh_url":"git@github.com:Automattic/wp-calypso.git","clone_url":"https://github.com/Automattic/wp-calypso.git","svn_url":"https://github.com/Automattic/wp-calypso","homepage":"https://developer.wordpress.com/calypso/","size":72908,"stargazers_count":7090,"watchers_count":7090,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":844,"mirror_url":null,"open_issues_count":1298,"forks":844,"open_issues":1298,"watchers":7090,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/4456"},"html":{"href":"https://github.com/Automattic/wp-calypso/pull/4456"},"issue":{"href":"https://api.github.com/repos/Automattic/wp-calypso/issues/4456"},"comments":{"href":"https://api.github.com/repos/Automattic/wp-calypso/issues/4456/comments"},"review_comments":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/4456/comments"},"review_comment":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/4456/commits"},"statuses":{"href":"https://api.github.com/repos/Automattic/wp-calypso/statuses/35923635c2c80fa89b0d3fa203c0f3cfc6641994"}}}}