{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/clj-i18n/pulls/comments/60679233","id":60679233,"diff_hunk":"@@ -101,12 +101,16 @@ On Red Hat-based operating systems, including Fedora, install gettext via\n \n 1. In your `project.clj`, add `puppetlabs/i18n` to the `:dependencies` and to\n    the `plugins`\n-1. Run `lein i18n init`. This will","path":"README.md","position":4,"original_position":4,"commit_id":"1dfab03dab7f02133f3428d5c546e147e87bd576","original_commit_id":"1dfab03dab7f02133f3428d5c546e147e87bd576","user":{"login":"MikaelSmith","id":8162496,"avatar_url":"https://avatars.githubusercontent.com/u/8162496?v=3","gravatar_id":"","url":"https://api.github.com/users/MikaelSmith","html_url":"https://github.com/MikaelSmith","followers_url":"https://api.github.com/users/MikaelSmith/followers","following_url":"https://api.github.com/users/MikaelSmith/following{/other_user}","gists_url":"https://api.github.com/users/MikaelSmith/gists{/gist_id}","starred_url":"https://api.github.com/users/MikaelSmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikaelSmith/subscriptions","organizations_url":"https://api.github.com/users/MikaelSmith/orgs","repos_url":"https://api.github.com/users/MikaelSmith/repos","events_url":"https://api.github.com/users/MikaelSmith/events{/privacy}","received_events_url":"https://api.github.com/users/MikaelSmith/received_events","type":"User","site_admin":false},"body":"Hmm, markdown should support automatically filling in list indices from `1.\\n1.\\n1.\\n`.","created_at":"2016-04-22T01:14:34Z","updated_at":"2016-04-22T01:14:34Z","html_url":"https://github.com/puppetlabs/clj-i18n/pull/13#discussion_r60679233","pull_request_url":"https://api.github.com/repos/puppetlabs/clj-i18n/pulls/13","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/clj-i18n/pulls/comments/60679233"},"html":{"href":"https://github.com/puppetlabs/clj-i18n/pull/13#discussion_r60679233"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/clj-i18n/pulls/13"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/clj-i18n/pulls/13","id":67095488,"html_url":"https://github.com/puppetlabs/clj-i18n/pull/13","diff_url":"https://github.com/puppetlabs/clj-i18n/pull/13.diff","patch_url":"https://github.com/puppetlabs/clj-i18n/pull/13.patch","issue_url":"https://api.github.com/repos/puppetlabs/clj-i18n/issues/13","number":13,"state":"closed","locked":false,"title":"(INTL-1) Support for multiple packages in locales.clj","user":{"login":"mruzicka","id":562920,"avatar_url":"https://avatars.githubusercontent.com/u/562920?v=3","gravatar_id":"","url":"https://api.github.com/users/mruzicka","html_url":"https://github.com/mruzicka","followers_url":"https://api.github.com/users/mruzicka/followers","following_url":"https://api.github.com/users/mruzicka/following{/other_user}","gists_url":"https://api.github.com/users/mruzicka/gists{/gist_id}","starred_url":"https://api.github.com/users/mruzicka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mruzicka/subscriptions","organizations_url":"https://api.github.com/users/mruzicka/orgs","repos_url":"https://api.github.com/users/mruzicka/repos","events_url":"https://api.github.com/users/mruzicka/events{/privacy}","received_events_url":"https://api.github.com/users/mruzicka/received_events","type":"User","site_admin":false},"body":"Prior to this commit the ```:package``` key in the ```locales.clj``` file as generated by the Makefile was set to a value derived from the project name.\r\nThis didn't work at least for the following projects:\r\n\r\n* [puppetlabs/pcp-common](https://github.com/puppetlabs/clj-pcp-common)\r\n* [puppetlabs/pcp-client](https://github.com/puppetlabs/clj-pcp-client)\r\n\r\nwhich don't use the assumed prefixes of ```puppetlabs.pcp_common``` and ```puppetlabs.pcp_client``` respectively for their namespaces but rather define different namespaces under the common root of ```puppetlabs.pcp```.\r\nTo be able to support that, this patch redefines the structure of the ```locales.clj``` such that it can now contain the ```:packages``` key (as opposed to the original ```:package```) which is expected to contain a collection of packages covered by the associated ```:bundle```.\r\n\r\nThe Makefile is updated to support this new structure. There are couple of user impacting changes:\r\n\r\n* the Makefile's ```PACKAGE``` variable is renamed to ```BUNDLE```\r\n* a new variable named ```PACKAGES``` (note the plural) is introduced; it defines the list of packages supported by the resource bundle; by default it is set to ```$(BUNDLE)``` to mimic the original behavior, but it can be overridden by the user should the project need it","created_at":"2016-04-19T21:46:29Z","updated_at":"2016-04-22T01:14:34Z","closed_at":"2016-04-21T22:41:01Z","merged_at":"2016-04-21T22:41:01Z","merge_commit_sha":"a20f56a4a69bf8ac9df2786baf2e3f99ba6497d4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/clj-i18n/pulls/13/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/clj-i18n/pulls/13/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/clj-i18n/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/clj-i18n/issues/13/comments","statuses_url":"https://api.github.com/repos/puppetlabs/clj-i18n/statuses/1dfab03dab7f02133f3428d5c546e147e87bd576","head":{"label":"mruzicka:INTL-1_multiple_namespaces_support","ref":"INTL-1_multiple_namespaces_support","sha":"1dfab03dab7f02133f3428d5c546e147e87bd576","user":{"login":"mruzicka","id":562920,"avatar_url":"https://avatars.githubusercontent.com/u/562920?v=3","gravatar_id":"","url":"https://api.github.com/users/mruzicka","html_url":"https://github.com/mruzicka","followers_url":"https://api.github.com/users/mruzicka/followers","following_url":"https://api.github.com/users/mruzicka/following{/other_user}","gists_url":"https://api.github.com/users/mruzicka/gists{/gist_id}","starred_url":"https://api.github.com/users/mruzicka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mruzicka/subscriptions","organizations_url":"https://api.github.com/users/mruzicka/orgs","repos_url":"https://api.github.com/users/mruzicka/repos","events_url":"https://api.github.com/users/mruzicka/events{/privacy}","received_events_url":"https://api.github.com/users/mruzicka/received_events","type":"User","site_admin":false},"repo":{"id":56258009,"name":"clj-i18n","full_name":"mruzicka/clj-i18n","owner":{"login":"mruzicka","id":562920,"avatar_url":"https://avatars.githubusercontent.com/u/562920?v=3","gravatar_id":"","url":"https://api.github.com/users/mruzicka","html_url":"https://github.com/mruzicka","followers_url":"https://api.github.com/users/mruzicka/followers","following_url":"https://api.github.com/users/mruzicka/following{/other_user}","gists_url":"https://api.github.com/users/mruzicka/gists{/gist_id}","starred_url":"https://api.github.com/users/mruzicka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mruzicka/subscriptions","organizations_url":"https://api.github.com/users/mruzicka/orgs","repos_url":"https://api.github.com/users/mruzicka/repos","events_url":"https://api.github.com/users/mruzicka/events{/privacy}","received_events_url":"https://api.github.com/users/mruzicka/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mruzicka/clj-i18n","description":"Clojure i18n library and utilities","fork":true,"url":"https://api.github.com/repos/mruzicka/clj-i18n","forks_url":"https://api.github.com/repos/mruzicka/clj-i18n/forks","keys_url":"https://api.github.com/repos/mruzicka/clj-i18n/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mruzicka/clj-i18n/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mruzicka/clj-i18n/teams","hooks_url":"https://api.github.com/repos/mruzicka/clj-i18n/hooks","issue_events_url":"https://api.github.com/repos/mruzicka/clj-i18n/issues/events{/number}","events_url":"https://api.github.com/repos/mruzicka/clj-i18n/events","assignees_url":"https://api.github.com/repos/mruzicka/clj-i18n/assignees{/user}","branches_url":"https://api.github.com/repos/mruzicka/clj-i18n/branches{/branch}","tags_url":"https://api.github.com/repos/mruzicka/clj-i18n/tags","blobs_url":"https://api.github.com/repos/mruzicka/clj-i18n/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mruzicka/clj-i18n/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mruzicka/clj-i18n/git/refs{/sha}","trees_url":"https://api.github.com/repos/mruzicka/clj-i18n/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mruzicka/clj-i18n/statuses/{sha}","languages_url":"https://api.github.com/repos/mruzicka/clj-i18n/languages","stargazers_url":"https://api.github.com/repos/mruzicka/clj-i18n/stargazers","contributors_url":"https://api.github.com/repos/mruzicka/clj-i18n/contributors","subscribers_url":"https://api.github.com/repos/mruzicka/clj-i18n/subscribers","subscription_url":"https://api.github.com/repos/mruzicka/clj-i18n/subscription","commits_url":"https://api.github.com/repos/mruzicka/clj-i18n/commits{/sha}","git_commits_url":"https://api.github.com/repos/mruzicka/clj-i18n/git/commits{/sha}","comments_url":"https://api.github.com/repos/mruzicka/clj-i18n/comments{/number}","issue_comment_url":"https://api.github.com/repos/mruzicka/clj-i18n/issues/comments{/number}","contents_url":"https://api.github.com/repos/mruzicka/clj-i18n/contents/{+path}","compare_url":"https://api.github.com/repos/mruzicka/clj-i18n/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mruzicka/clj-i18n/merges","archive_url":"https://api.github.com/repos/mruzicka/clj-i18n/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mruzicka/clj-i18n/downloads","issues_url":"https://api.github.com/repos/mruzicka/clj-i18n/issues{/number}","pulls_url":"https://api.github.com/repos/mruzicka/clj-i18n/pulls{/number}","milestones_url":"https://api.github.com/repos/mruzicka/clj-i18n/milestones{/number}","notifications_url":"https://api.github.com/repos/mruzicka/clj-i18n/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mruzicka/clj-i18n/labels{/name}","releases_url":"https://api.github.com/repos/mruzicka/clj-i18n/releases{/id}","deployments_url":"https://api.github.com/repos/mruzicka/clj-i18n/deployments","created_at":"2016-04-14T17:44:41Z","updated_at":"2016-04-14T17:44:42Z","pushed_at":"2016-04-20T22:36:52Z","git_url":"git://github.com/mruzicka/clj-i18n.git","ssh_url":"git@github.com:mruzicka/clj-i18n.git","clone_url":"https://github.com/mruzicka/clj-i18n.git","svn_url":"https://github.com/mruzicka/clj-i18n","homepage":null,"size":83,"stargazers_count":0,"watchers_count":0,"language":"Clojure","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"f664d31e0c0088fab3220e84586dd4617b57ed5c","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":34360399,"name":"clj-i18n","full_name":"puppetlabs/clj-i18n","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/clj-i18n","description":"Clojure i18n library and utilities","fork":false,"url":"https://api.github.com/repos/puppetlabs/clj-i18n","forks_url":"https://api.github.com/repos/puppetlabs/clj-i18n/forks","keys_url":"https://api.github.com/repos/puppetlabs/clj-i18n/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/clj-i18n/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/clj-i18n/teams","hooks_url":"https://api.github.com/repos/puppetlabs/clj-i18n/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/clj-i18n/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/clj-i18n/events","assignees_url":"https://api.github.com/repos/puppetlabs/clj-i18n/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/clj-i18n/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/clj-i18n/tags","blobs_url":"https://api.github.com/repos/puppetlabs/clj-i18n/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/clj-i18n/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/clj-i18n/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/clj-i18n/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/clj-i18n/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/clj-i18n/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/clj-i18n/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/clj-i18n/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/clj-i18n/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/clj-i18n/subscription","commits_url":"https://api.github.com/repos/puppetlabs/clj-i18n/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/clj-i18n/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/clj-i18n/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/clj-i18n/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/clj-i18n/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/clj-i18n/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/clj-i18n/merges","archive_url":"https://api.github.com/repos/puppetlabs/clj-i18n/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/clj-i18n/downloads","issues_url":"https://api.github.com/repos/puppetlabs/clj-i18n/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/clj-i18n/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/clj-i18n/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/clj-i18n/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/clj-i18n/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/clj-i18n/releases{/id}","deployments_url":"https://api.github.com/repos/puppetlabs/clj-i18n/deployments","created_at":"2015-04-22T00:59:04Z","updated_at":"2016-04-01T00:11:07Z","pushed_at":"2016-04-21T22:41:01Z","git_url":"git://github.com/puppetlabs/clj-i18n.git","ssh_url":"git@github.com:puppetlabs/clj-i18n.git","clone_url":"https://github.com/puppetlabs/clj-i18n.git","svn_url":"https://github.com/puppetlabs/clj-i18n","homepage":null,"size":84,"stargazers_count":0,"watchers_count":0,"language":"Clojure","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":0,"forks":9,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/clj-i18n/pulls/13"},"html":{"href":"https://github.com/puppetlabs/clj-i18n/pull/13"},"issue":{"href":"https://api.github.com/repos/puppetlabs/clj-i18n/issues/13"},"comments":{"href":"https://api.github.com/repos/puppetlabs/clj-i18n/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/clj-i18n/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/clj-i18n/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/clj-i18n/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/clj-i18n/statuses/1dfab03dab7f02133f3428d5c546e147e87bd576"}}}}