{"action":"created","comment":{"url":"https://api.github.com/repos/mono/mono/pulls/comments/63456746","id":63456746,"diff_hunk":"@@ -132,7 +150,10 @@ mono_handle_domain (MonoHandle handle)\n #define MONO_HANDLE_TYPE_DECL(type)      typedef struct { type *__private_obj; } type ## HandleStorage ; \\\n \ttypedef type ## HandleStorage * type ## Handle\n #define MONO_HANDLE_TYPE(type)           type ## Handle\n-#define MONO_HANDLE_NEW(type,obj)        ((type ## Handle) mono_handle_new ((MonoObject*) (obj)))\n+#define MONO_HANDLE_NEW(type,obj)        ((MONO_HANDLE_TYPE(type)) mono_handle_new ((MonoObject*) (obj)))\n+\n+#define MONO_HANDLE_DCL(type,name)\tMONO_HANDLE_TYPE(type) name = MONO_HANDLE_NEW(type,name ## _raw)","path":"mono/metadata/handle.h","position":32,"original_position":32,"commit_id":"611c1b27c670e7085929309cdf08111cfe4f7a1e","original_commit_id":"52d8f8e7092d54eb0f0a1710f29f7448a5914411","user":{"login":"kumpera","id":5738,"avatar_url":"https://avatars.githubusercontent.com/u/5738?v=3","gravatar_id":"","url":"https://api.github.com/users/kumpera","html_url":"https://github.com/kumpera","followers_url":"https://api.github.com/users/kumpera/followers","following_url":"https://api.github.com/users/kumpera/following{/other_user}","gists_url":"https://api.github.com/users/kumpera/gists{/gist_id}","starred_url":"https://api.github.com/users/kumpera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kumpera/subscriptions","organizations_url":"https://api.github.com/users/kumpera/orgs","repos_url":"https://api.github.com/users/kumpera/repos","events_url":"https://api.github.com/users/kumpera/events{/privacy}","received_events_url":"https://api.github.com/users/kumpera/received_events","type":"User","site_admin":false},"body":"This is fine as it's to be used on icalls, where we dictate a simple convention.\r\n\r\nThe _raw prefix has the advantage of make it weird to use.","created_at":"2016-05-17T02:25:51Z","updated_at":"2016-05-17T02:25:51Z","html_url":"https://github.com/mono/mono/pull/2956#discussion_r63456746","pull_request_url":"https://api.github.com/repos/mono/mono/pulls/2956","_links":{"self":{"href":"https://api.github.com/repos/mono/mono/pulls/comments/63456746"},"html":{"href":"https://github.com/mono/mono/pull/2956#discussion_r63456746"},"pull_request":{"href":"https://api.github.com/repos/mono/mono/pulls/2956"}}},"pull_request":{"url":"https://api.github.com/repos/mono/mono/pulls/2956","id":67774466,"html_url":"https://github.com/mono/mono/pull/2956","diff_url":"https://github.com/mono/mono/pull/2956.diff","patch_url":"https://github.com/mono/mono/pull/2956.patch","issue_url":"https://api.github.com/repos/mono/mono/issues/2956","number":2956,"state":"open","locked":false,"title":"[DO NOT MERGE] Hacking on icall handles","user":{"login":"lambdageek","id":480437,"avatar_url":"https://avatars.githubusercontent.com/u/480437?v=3","gravatar_id":"","url":"https://api.github.com/users/lambdageek","html_url":"https://github.com/lambdageek","followers_url":"https://api.github.com/users/lambdageek/followers","following_url":"https://api.github.com/users/lambdageek/following{/other_user}","gists_url":"https://api.github.com/users/lambdageek/gists{/gist_id}","starred_url":"https://api.github.com/users/lambdageek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lambdageek/subscriptions","organizations_url":"https://api.github.com/users/lambdageek/orgs","repos_url":"https://api.github.com/users/lambdageek/repos","events_url":"https://api.github.com/users/lambdageek/events{/privacy}","received_events_url":"https://api.github.com/users/lambdageek/received_events","type":"User","site_admin":false},"body":"**DO NOT MERGE**\r\n\r\nOkay, let's resurrect the icall handles stuff from last year and see how it looks with MonoError now.\r\n\r\n/cc @ludovic-henry @kumpera ","created_at":"2016-04-25T19:28:55Z","updated_at":"2016-05-17T02:25:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a7e4b45d0ce03b48219689983e6faa9cde741aa1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mono/mono/pulls/2956/commits","review_comments_url":"https://api.github.com/repos/mono/mono/pulls/2956/comments","review_comment_url":"https://api.github.com/repos/mono/mono/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mono/mono/issues/2956/comments","statuses_url":"https://api.github.com/repos/mono/mono/statuses/611c1b27c670e7085929309cdf08111cfe4f7a1e","head":{"label":"lambdageek:hack/icall-handles","ref":"hack/icall-handles","sha":"611c1b27c670e7085929309cdf08111cfe4f7a1e","user":{"login":"lambdageek","id":480437,"avatar_url":"https://avatars.githubusercontent.com/u/480437?v=3","gravatar_id":"","url":"https://api.github.com/users/lambdageek","html_url":"https://github.com/lambdageek","followers_url":"https://api.github.com/users/lambdageek/followers","following_url":"https://api.github.com/users/lambdageek/following{/other_user}","gists_url":"https://api.github.com/users/lambdageek/gists{/gist_id}","starred_url":"https://api.github.com/users/lambdageek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lambdageek/subscriptions","organizations_url":"https://api.github.com/users/lambdageek/orgs","repos_url":"https://api.github.com/users/lambdageek/repos","events_url":"https://api.github.com/users/lambdageek/events{/privacy}","received_events_url":"https://api.github.com/users/lambdageek/received_events","type":"User","site_admin":false},"repo":{"id":40153659,"name":"mono","full_name":"lambdageek/mono","owner":{"login":"lambdageek","id":480437,"avatar_url":"https://avatars.githubusercontent.com/u/480437?v=3","gravatar_id":"","url":"https://api.github.com/users/lambdageek","html_url":"https://github.com/lambdageek","followers_url":"https://api.github.com/users/lambdageek/followers","following_url":"https://api.github.com/users/lambdageek/following{/other_user}","gists_url":"https://api.github.com/users/lambdageek/gists{/gist_id}","starred_url":"https://api.github.com/users/lambdageek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lambdageek/subscriptions","organizations_url":"https://api.github.com/users/lambdageek/orgs","repos_url":"https://api.github.com/users/lambdageek/repos","events_url":"https://api.github.com/users/lambdageek/events{/privacy}","received_events_url":"https://api.github.com/users/lambdageek/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lambdageek/mono","description":"Mono open source ECMA CLI, C# and .NET implementation.","fork":true,"url":"https://api.github.com/repos/lambdageek/mono","forks_url":"https://api.github.com/repos/lambdageek/mono/forks","keys_url":"https://api.github.com/repos/lambdageek/mono/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lambdageek/mono/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lambdageek/mono/teams","hooks_url":"https://api.github.com/repos/lambdageek/mono/hooks","issue_events_url":"https://api.github.com/repos/lambdageek/mono/issues/events{/number}","events_url":"https://api.github.com/repos/lambdageek/mono/events","assignees_url":"https://api.github.com/repos/lambdageek/mono/assignees{/user}","branches_url":"https://api.github.com/repos/lambdageek/mono/branches{/branch}","tags_url":"https://api.github.com/repos/lambdageek/mono/tags","blobs_url":"https://api.github.com/repos/lambdageek/mono/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lambdageek/mono/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lambdageek/mono/git/refs{/sha}","trees_url":"https://api.github.com/repos/lambdageek/mono/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lambdageek/mono/statuses/{sha}","languages_url":"https://api.github.com/repos/lambdageek/mono/languages","stargazers_url":"https://api.github.com/repos/lambdageek/mono/stargazers","contributors_url":"https://api.github.com/repos/lambdageek/mono/contributors","subscribers_url":"https://api.github.com/repos/lambdageek/mono/subscribers","subscription_url":"https://api.github.com/repos/lambdageek/mono/subscription","commits_url":"https://api.github.com/repos/lambdageek/mono/commits{/sha}","git_commits_url":"https://api.github.com/repos/lambdageek/mono/git/commits{/sha}","comments_url":"https://api.github.com/repos/lambdageek/mono/comments{/number}","issue_comment_url":"https://api.github.com/repos/lambdageek/mono/issues/comments{/number}","contents_url":"https://api.github.com/repos/lambdageek/mono/contents/{+path}","compare_url":"https://api.github.com/repos/lambdageek/mono/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lambdageek/mono/merges","archive_url":"https://api.github.com/repos/lambdageek/mono/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lambdageek/mono/downloads","issues_url":"https://api.github.com/repos/lambdageek/mono/issues{/number}","pulls_url":"https://api.github.com/repos/lambdageek/mono/pulls{/number}","milestones_url":"https://api.github.com/repos/lambdageek/mono/milestones{/number}","notifications_url":"https://api.github.com/repos/lambdageek/mono/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lambdageek/mono/labels{/name}","releases_url":"https://api.github.com/repos/lambdageek/mono/releases{/id}","deployments_url":"https://api.github.com/repos/lambdageek/mono/deployments","created_at":"2015-08-03T23:55:25Z","updated_at":"2015-11-13T23:53:24Z","pushed_at":"2016-05-16T23:11:01Z","git_url":"git://github.com/lambdageek/mono.git","ssh_url":"git@github.com:lambdageek/mono.git","clone_url":"https://github.com/lambdageek/mono.git","svn_url":"https://github.com/lambdageek/mono","homepage":"http://www.mono-project.com/","size":399279,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mono:master","ref":"master","sha":"65ab352de4d4818baa4b167a1bbb0c45e0062c99","user":{"login":"mono","id":53395,"avatar_url":"https://avatars.githubusercontent.com/u/53395?v=3","gravatar_id":"","url":"https://api.github.com/users/mono","html_url":"https://github.com/mono","followers_url":"https://api.github.com/users/mono/followers","following_url":"https://api.github.com/users/mono/following{/other_user}","gists_url":"https://api.github.com/users/mono/gists{/gist_id}","starred_url":"https://api.github.com/users/mono/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mono/subscriptions","organizations_url":"https://api.github.com/users/mono/orgs","repos_url":"https://api.github.com/users/mono/repos","events_url":"https://api.github.com/users/mono/events{/privacy}","received_events_url":"https://api.github.com/users/mono/received_events","type":"Organization","site_admin":false},"repo":{"id":791611,"name":"mono","full_name":"mono/mono","owner":{"login":"mono","id":53395,"avatar_url":"https://avatars.githubusercontent.com/u/53395?v=3","gravatar_id":"","url":"https://api.github.com/users/mono","html_url":"https://github.com/mono","followers_url":"https://api.github.com/users/mono/followers","following_url":"https://api.github.com/users/mono/following{/other_user}","gists_url":"https://api.github.com/users/mono/gists{/gist_id}","starred_url":"https://api.github.com/users/mono/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mono/subscriptions","organizations_url":"https://api.github.com/users/mono/orgs","repos_url":"https://api.github.com/users/mono/repos","events_url":"https://api.github.com/users/mono/events{/privacy}","received_events_url":"https://api.github.com/users/mono/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mono/mono","description":"Mono open source ECMA CLI, C# and .NET implementation.","fork":false,"url":"https://api.github.com/repos/mono/mono","forks_url":"https://api.github.com/repos/mono/mono/forks","keys_url":"https://api.github.com/repos/mono/mono/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mono/mono/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mono/mono/teams","hooks_url":"https://api.github.com/repos/mono/mono/hooks","issue_events_url":"https://api.github.com/repos/mono/mono/issues/events{/number}","events_url":"https://api.github.com/repos/mono/mono/events","assignees_url":"https://api.github.com/repos/mono/mono/assignees{/user}","branches_url":"https://api.github.com/repos/mono/mono/branches{/branch}","tags_url":"https://api.github.com/repos/mono/mono/tags","blobs_url":"https://api.github.com/repos/mono/mono/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mono/mono/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mono/mono/git/refs{/sha}","trees_url":"https://api.github.com/repos/mono/mono/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mono/mono/statuses/{sha}","languages_url":"https://api.github.com/repos/mono/mono/languages","stargazers_url":"https://api.github.com/repos/mono/mono/stargazers","contributors_url":"https://api.github.com/repos/mono/mono/contributors","subscribers_url":"https://api.github.com/repos/mono/mono/subscribers","subscription_url":"https://api.github.com/repos/mono/mono/subscription","commits_url":"https://api.github.com/repos/mono/mono/commits{/sha}","git_commits_url":"https://api.github.com/repos/mono/mono/git/commits{/sha}","comments_url":"https://api.github.com/repos/mono/mono/comments{/number}","issue_comment_url":"https://api.github.com/repos/mono/mono/issues/comments{/number}","contents_url":"https://api.github.com/repos/mono/mono/contents/{+path}","compare_url":"https://api.github.com/repos/mono/mono/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mono/mono/merges","archive_url":"https://api.github.com/repos/mono/mono/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mono/mono/downloads","issues_url":"https://api.github.com/repos/mono/mono/issues{/number}","pulls_url":"https://api.github.com/repos/mono/mono/pulls{/number}","milestones_url":"https://api.github.com/repos/mono/mono/milestones{/number}","notifications_url":"https://api.github.com/repos/mono/mono/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mono/mono/labels{/name}","releases_url":"https://api.github.com/repos/mono/mono/releases{/id}","deployments_url":"https://api.github.com/repos/mono/mono/deployments","created_at":"2010-07-22T18:06:36Z","updated_at":"2016-05-16T08:35:18Z","pushed_at":"2016-05-17T02:07:50Z","git_url":"git://github.com/mono/mono.git","ssh_url":"git@github.com:mono/mono.git","clone_url":"https://github.com/mono/mono.git","svn_url":"https://github.com/mono/mono","homepage":"http://www.mono-project.com/","size":493821,"stargazers_count":4618,"watchers_count":4618,"language":"C#","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":2192,"mirror_url":null,"open_issues_count":115,"forks":2192,"open_issues":115,"watchers":4618,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mono/mono/pulls/2956"},"html":{"href":"https://github.com/mono/mono/pull/2956"},"issue":{"href":"https://api.github.com/repos/mono/mono/issues/2956"},"comments":{"href":"https://api.github.com/repos/mono/mono/issues/2956/comments"},"review_comments":{"href":"https://api.github.com/repos/mono/mono/pulls/2956/comments"},"review_comment":{"href":"https://api.github.com/repos/mono/mono/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mono/mono/pulls/2956/commits"},"statuses":{"href":"https://api.github.com/repos/mono/mono/statuses/611c1b27c670e7085929309cdf08111cfe4f7a1e"}}}}