{"action":"closed","number":13557,"pull_request":{"url":"https://api.github.com/repos/Baystation12/Baystation12/pulls/13557","id":76049871,"html_url":"https://github.com/Baystation12/Baystation12/pull/13557","diff_url":"https://github.com/Baystation12/Baystation12/pull/13557.diff","patch_url":"https://github.com/Baystation12/Baystation12/pull/13557.patch","issue_url":"https://api.github.com/repos/Baystation12/Baystation12/issues/13557","number":13557,"state":"closed","locked":false,"title":"Player age restriction tweaks.","user":{"login":"atlantiscze","id":5147960,"avatar_url":"https://avatars.githubusercontent.com/u/5147960?v=3","gravatar_id":"","url":"https://api.github.com/users/atlantiscze","html_url":"https://github.com/atlantiscze","followers_url":"https://api.github.com/users/atlantiscze/followers","following_url":"https://api.github.com/users/atlantiscze/following{/other_user}","gists_url":"https://api.github.com/users/atlantiscze/gists{/gist_id}","starred_url":"https://api.github.com/users/atlantiscze/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atlantiscze/subscriptions","organizations_url":"https://api.github.com/users/atlantiscze/orgs","repos_url":"https://api.github.com/users/atlantiscze/repos","events_url":"https://api.github.com/users/atlantiscze/events{/privacy}","received_events_url":"https://api.github.com/users/atlantiscze/received_events","type":"User","site_admin":false},"body":"- This PR tweaks the minimal client age (amount of days played on server) for some roles. The intention is to make more complex/dangerous roles take slightly longer to reach. As we have various trainee positions as alt-titles for assistants now it shouldn't bother anyone.\r\n- This PR also adds support for antag-specific restrictions. This system is linked to the config option that controls job-specific restrictions too. I was unable to test this as i lack a player age database, but it should work smoothly. I would appreciate if someone could do a quick test though, just to be sure.\r\n\r\nAll (hopefully) specific changes below:\r\n- Antagonist: All antagonists, unless specified otherwise below, have age restriction of 14 days.\r\n- Antagonist: Wizard, Ninja and Rampant AI have age restriction of 18 days (usually a single antag per round, idea is to let people try out other antag roles first to get used to antagonizing)\r\n- Antagonist: Mercenary and Raider now have age restriction of 21 days (these antags need higher level of coordination, so players should be familiar with other things by now)\r\n- Jobs: AI, Research Director, Chief Medical Officer, Chief Engineer and Head of Personnel now have age restriction of 14 days. (all heads of staff, including captain are unified on this value)\r\n- Jobs: Engineer, Atmospheric Technician, Chemist, Paramedic, Geneticist(is that even used?), Security officer, Detective, Warden and Cyborg now have age restriction of 7 days. (Generally risky/harder jobs, players should be already familiar with basics of the game at this point)\r\n- Jobs: Quartermaster, Medical Doctor and Psychiatrist now have age restriction of 3 days. (Jobs that require at least some degree of game understanding. I mean, who would want to be treated by a doctor who doesn't know how to open a container such as medikit? We have assistant trainees/interns for this.)","created_at":"2016-07-02T00:08:33Z","updated_at":"2016-07-11T12:57:21Z","closed_at":"2016-07-11T12:57:21Z","merged_at":"2016-07-11T12:57:21Z","merge_commit_sha":"a2faba2d2f67f8e7011b94c3483ebf449b2e6da3","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Baystation12/Baystation12/pulls/13557/commits","review_comments_url":"https://api.github.com/repos/Baystation12/Baystation12/pulls/13557/comments","review_comment_url":"https://api.github.com/repos/Baystation12/Baystation12/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Baystation12/Baystation12/issues/13557/comments","statuses_url":"https://api.github.com/repos/Baystation12/Baystation12/statuses/7d0929bd09e0d4f553ccf9c6725a79fe5a1f0e48","head":{"label":"atlantiscze:2016-07-02-RestrictionRebalance","ref":"2016-07-02-RestrictionRebalance","sha":"7d0929bd09e0d4f553ccf9c6725a79fe5a1f0e48","user":{"login":"atlantiscze","id":5147960,"avatar_url":"https://avatars.githubusercontent.com/u/5147960?v=3","gravatar_id":"","url":"https://api.github.com/users/atlantiscze","html_url":"https://github.com/atlantiscze","followers_url":"https://api.github.com/users/atlantiscze/followers","following_url":"https://api.github.com/users/atlantiscze/following{/other_user}","gists_url":"https://api.github.com/users/atlantiscze/gists{/gist_id}","starred_url":"https://api.github.com/users/atlantiscze/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atlantiscze/subscriptions","organizations_url":"https://api.github.com/users/atlantiscze/orgs","repos_url":"https://api.github.com/users/atlantiscze/repos","events_url":"https://api.github.com/users/atlantiscze/events{/privacy}","received_events_url":"https://api.github.com/users/atlantiscze/received_events","type":"User","site_admin":false},"repo":{"id":21876216,"name":"Baystation12","full_name":"atlantiscze/Baystation12","owner":{"login":"atlantiscze","id":5147960,"avatar_url":"https://avatars.githubusercontent.com/u/5147960?v=3","gravatar_id":"","url":"https://api.github.com/users/atlantiscze","html_url":"https://github.com/atlantiscze","followers_url":"https://api.github.com/users/atlantiscze/followers","following_url":"https://api.github.com/users/atlantiscze/following{/other_user}","gists_url":"https://api.github.com/users/atlantiscze/gists{/gist_id}","starred_url":"https://api.github.com/users/atlantiscze/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atlantiscze/subscriptions","organizations_url":"https://api.github.com/users/atlantiscze/orgs","repos_url":"https://api.github.com/users/atlantiscze/repos","events_url":"https://api.github.com/users/atlantiscze/events{/privacy}","received_events_url":"https://api.github.com/users/atlantiscze/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/atlantiscze/Baystation12","description":"The code for Baystation12's branch of SS13","fork":true,"url":"https://api.github.com/repos/atlantiscze/Baystation12","forks_url":"https://api.github.com/repos/atlantiscze/Baystation12/forks","keys_url":"https://api.github.com/repos/atlantiscze/Baystation12/keys{/key_id}","collaborators_url":"https://api.github.com/repos/atlantiscze/Baystation12/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/atlantiscze/Baystation12/teams","hooks_url":"https://api.github.com/repos/atlantiscze/Baystation12/hooks","issue_events_url":"https://api.github.com/repos/atlantiscze/Baystation12/issues/events{/number}","events_url":"https://api.github.com/repos/atlantiscze/Baystation12/events","assignees_url":"https://api.github.com/repos/atlantiscze/Baystation12/assignees{/user}","branches_url":"https://api.github.com/repos/atlantiscze/Baystation12/branches{/branch}","tags_url":"https://api.github.com/repos/atlantiscze/Baystation12/tags","blobs_url":"https://api.github.com/repos/atlantiscze/Baystation12/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/atlantiscze/Baystation12/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/atlantiscze/Baystation12/git/refs{/sha}","trees_url":"https://api.github.com/repos/atlantiscze/Baystation12/git/trees{/sha}","statuses_url":"https://api.github.com/repos/atlantiscze/Baystation12/statuses/{sha}","languages_url":"https://api.github.com/repos/atlantiscze/Baystation12/languages","stargazers_url":"https://api.github.com/repos/atlantiscze/Baystation12/stargazers","contributors_url":"https://api.github.com/repos/atlantiscze/Baystation12/contributors","subscribers_url":"https://api.github.com/repos/atlantiscze/Baystation12/subscribers","subscription_url":"https://api.github.com/repos/atlantiscze/Baystation12/subscription","commits_url":"https://api.github.com/repos/atlantiscze/Baystation12/commits{/sha}","git_commits_url":"https://api.github.com/repos/atlantiscze/Baystation12/git/commits{/sha}","comments_url":"https://api.github.com/repos/atlantiscze/Baystation12/comments{/number}","issue_comment_url":"https://api.github.com/repos/atlantiscze/Baystation12/issues/comments{/number}","contents_url":"https://api.github.com/repos/atlantiscze/Baystation12/contents/{+path}","compare_url":"https://api.github.com/repos/atlantiscze/Baystation12/compare/{base}...{head}","merges_url":"https://api.github.com/repos/atlantiscze/Baystation12/merges","archive_url":"https://api.github.com/repos/atlantiscze/Baystation12/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/atlantiscze/Baystation12/downloads","issues_url":"https://api.github.com/repos/atlantiscze/Baystation12/issues{/number}","pulls_url":"https://api.github.com/repos/atlantiscze/Baystation12/pulls{/number}","milestones_url":"https://api.github.com/repos/atlantiscze/Baystation12/milestones{/number}","notifications_url":"https://api.github.com/repos/atlantiscze/Baystation12/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/atlantiscze/Baystation12/labels{/name}","releases_url":"https://api.github.com/repos/atlantiscze/Baystation12/releases{/id}","deployments_url":"https://api.github.com/repos/atlantiscze/Baystation12/deployments","created_at":"2014-07-15T21:17:06Z","updated_at":"2016-01-17T03:45:38Z","pushed_at":"2016-07-10T18:30:53Z","git_url":"git://github.com/atlantiscze/Baystation12.git","ssh_url":"git@github.com:atlantiscze/Baystation12.git","clone_url":"https://github.com/atlantiscze/Baystation12.git","svn_url":"https://github.com/atlantiscze/Baystation12","homepage":"http://baystation12.net/","size":603918,"stargazers_count":1,"watchers_count":1,"language":"DM","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"_BAY-Dev"}},"base":{"label":"Baystation12:dev","ref":"dev","sha":"ebfc849dd46a320614f9eb9e0fde2360c8129b10","user":{"login":"Baystation12","id":1174322,"avatar_url":"https://avatars.githubusercontent.com/u/1174322?v=3","gravatar_id":"","url":"https://api.github.com/users/Baystation12","html_url":"https://github.com/Baystation12","followers_url":"https://api.github.com/users/Baystation12/followers","following_url":"https://api.github.com/users/Baystation12/following{/other_user}","gists_url":"https://api.github.com/users/Baystation12/gists{/gist_id}","starred_url":"https://api.github.com/users/Baystation12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Baystation12/subscriptions","organizations_url":"https://api.github.com/users/Baystation12/orgs","repos_url":"https://api.github.com/users/Baystation12/repos","events_url":"https://api.github.com/users/Baystation12/events{/privacy}","received_events_url":"https://api.github.com/users/Baystation12/received_events","type":"Organization","site_admin":false},"repo":{"id":2715933,"name":"Baystation12","full_name":"Baystation12/Baystation12","owner":{"login":"Baystation12","id":1174322,"avatar_url":"https://avatars.githubusercontent.com/u/1174322?v=3","gravatar_id":"","url":"https://api.github.com/users/Baystation12","html_url":"https://github.com/Baystation12","followers_url":"https://api.github.com/users/Baystation12/followers","following_url":"https://api.github.com/users/Baystation12/following{/other_user}","gists_url":"https://api.github.com/users/Baystation12/gists{/gist_id}","starred_url":"https://api.github.com/users/Baystation12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Baystation12/subscriptions","organizations_url":"https://api.github.com/users/Baystation12/orgs","repos_url":"https://api.github.com/users/Baystation12/repos","events_url":"https://api.github.com/users/Baystation12/events{/privacy}","received_events_url":"https://api.github.com/users/Baystation12/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Baystation12/Baystation12","description":"The code for Baystation12's branch of SS13","fork":false,"url":"https://api.github.com/repos/Baystation12/Baystation12","forks_url":"https://api.github.com/repos/Baystation12/Baystation12/forks","keys_url":"https://api.github.com/repos/Baystation12/Baystation12/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Baystation12/Baystation12/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Baystation12/Baystation12/teams","hooks_url":"https://api.github.com/repos/Baystation12/Baystation12/hooks","issue_events_url":"https://api.github.com/repos/Baystation12/Baystation12/issues/events{/number}","events_url":"https://api.github.com/repos/Baystation12/Baystation12/events","assignees_url":"https://api.github.com/repos/Baystation12/Baystation12/assignees{/user}","branches_url":"https://api.github.com/repos/Baystation12/Baystation12/branches{/branch}","tags_url":"https://api.github.com/repos/Baystation12/Baystation12/tags","blobs_url":"https://api.github.com/repos/Baystation12/Baystation12/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Baystation12/Baystation12/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Baystation12/Baystation12/git/refs{/sha}","trees_url":"https://api.github.com/repos/Baystation12/Baystation12/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Baystation12/Baystation12/statuses/{sha}","languages_url":"https://api.github.com/repos/Baystation12/Baystation12/languages","stargazers_url":"https://api.github.com/repos/Baystation12/Baystation12/stargazers","contributors_url":"https://api.github.com/repos/Baystation12/Baystation12/contributors","subscribers_url":"https://api.github.com/repos/Baystation12/Baystation12/subscribers","subscription_url":"https://api.github.com/repos/Baystation12/Baystation12/subscription","commits_url":"https://api.github.com/repos/Baystation12/Baystation12/commits{/sha}","git_commits_url":"https://api.github.com/repos/Baystation12/Baystation12/git/commits{/sha}","comments_url":"https://api.github.com/repos/Baystation12/Baystation12/comments{/number}","issue_comment_url":"https://api.github.com/repos/Baystation12/Baystation12/issues/comments{/number}","contents_url":"https://api.github.com/repos/Baystation12/Baystation12/contents/{+path}","compare_url":"https://api.github.com/repos/Baystation12/Baystation12/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Baystation12/Baystation12/merges","archive_url":"https://api.github.com/repos/Baystation12/Baystation12/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Baystation12/Baystation12/downloads","issues_url":"https://api.github.com/repos/Baystation12/Baystation12/issues{/number}","pulls_url":"https://api.github.com/repos/Baystation12/Baystation12/pulls{/number}","milestones_url":"https://api.github.com/repos/Baystation12/Baystation12/milestones{/number}","notifications_url":"https://api.github.com/repos/Baystation12/Baystation12/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Baystation12/Baystation12/labels{/name}","releases_url":"https://api.github.com/repos/Baystation12/Baystation12/releases{/id}","deployments_url":"https://api.github.com/repos/Baystation12/Baystation12/deployments","created_at":"2011-11-05T16:12:41Z","updated_at":"2016-07-08T02:18:57Z","pushed_at":"2016-07-11T12:57:22Z","git_url":"git://github.com/Baystation12/Baystation12.git","ssh_url":"git@github.com:Baystation12/Baystation12.git","clone_url":"https://github.com/Baystation12/Baystation12.git","svn_url":"https://github.com/Baystation12/Baystation12","homepage":"http://baystation12.net/","size":1683388,"stargazers_count":219,"watchers_count":219,"language":"DM","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":709,"mirror_url":null,"open_issues_count":432,"forks":709,"open_issues":432,"watchers":219,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/Baystation12/Baystation12/pulls/13557"},"html":{"href":"https://github.com/Baystation12/Baystation12/pull/13557"},"issue":{"href":"https://api.github.com/repos/Baystation12/Baystation12/issues/13557"},"comments":{"href":"https://api.github.com/repos/Baystation12/Baystation12/issues/13557/comments"},"review_comments":{"href":"https://api.github.com/repos/Baystation12/Baystation12/pulls/13557/comments"},"review_comment":{"href":"https://api.github.com/repos/Baystation12/Baystation12/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Baystation12/Baystation12/pulls/13557/commits"},"statuses":{"href":"https://api.github.com/repos/Baystation12/Baystation12/statuses/7d0929bd09e0d4f553ccf9c6725a79fe5a1f0e48"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"NullSnapshot","id":5078676,"avatar_url":"https://avatars.githubusercontent.com/u/5078676?v=3","gravatar_id":"","url":"https://api.github.com/users/NullSnapshot","html_url":"https://github.com/NullSnapshot","followers_url":"https://api.github.com/users/NullSnapshot/followers","following_url":"https://api.github.com/users/NullSnapshot/following{/other_user}","gists_url":"https://api.github.com/users/NullSnapshot/gists{/gist_id}","starred_url":"https://api.github.com/users/NullSnapshot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NullSnapshot/subscriptions","organizations_url":"https://api.github.com/users/NullSnapshot/orgs","repos_url":"https://api.github.com/users/NullSnapshot/repos","events_url":"https://api.github.com/users/NullSnapshot/events{/privacy}","received_events_url":"https://api.github.com/users/NullSnapshot/received_events","type":"User","site_admin":false},"comments":9,"review_comments":2,"commits":4,"additions":30,"deletions":13,"changed_files":14}}
{"actor":{"display_login":"NullSnapshot"}}