{"action":"created","issue":{"url":"https://api.github.com/repos/fish-shell/fish-shell/issues/3587","repository_url":"https://api.github.com/repos/fish-shell/fish-shell","labels_url":"https://api.github.com/repos/fish-shell/fish-shell/issues/3587/labels{/name}","comments_url":"https://api.github.com/repos/fish-shell/fish-shell/issues/3587/comments","events_url":"https://api.github.com/repos/fish-shell/fish-shell/issues/3587/events","html_url":"https://github.com/fish-shell/fish-shell/issues/3587","id":191840158,"number":3587,"title":"shmem polling fails on BSD and Cygwin","user":{"login":"krader1961","id":7545917,"avatar_url":"https://avatars.githubusercontent.com/u/7545917?v=3","gravatar_id":"","url":"https://api.github.com/users/krader1961","html_url":"https://github.com/krader1961","followers_url":"https://api.github.com/users/krader1961/followers","following_url":"https://api.github.com/users/krader1961/following{/other_user}","gists_url":"https://api.github.com/users/krader1961/gists{/gist_id}","starred_url":"https://api.github.com/users/krader1961/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krader1961/subscriptions","organizations_url":"https://api.github.com/users/krader1961/orgs","repos_url":"https://api.github.com/users/krader1961/repos","events_url":"https://api.github.com/users/krader1961/events{/privacy}","received_events_url":"https://api.github.com/users/krader1961/received_events","type":"User","site_admin":false},"labels":[{"id":4724778,"url":"https://api.github.com/repos/fish-shell/fish-shell/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"state":"open","locked":false,"assignee":{"login":"krader1961","id":7545917,"avatar_url":"https://avatars.githubusercontent.com/u/7545917?v=3","gravatar_id":"","url":"https://api.github.com/users/krader1961","html_url":"https://github.com/krader1961","followers_url":"https://api.github.com/users/krader1961/followers","following_url":"https://api.github.com/users/krader1961/following{/other_user}","gists_url":"https://api.github.com/users/krader1961/gists{/gist_id}","starred_url":"https://api.github.com/users/krader1961/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krader1961/subscriptions","organizations_url":"https://api.github.com/users/krader1961/orgs","repos_url":"https://api.github.com/users/krader1961/repos","events_url":"https://api.github.com/users/krader1961/events{/privacy}","received_events_url":"https://api.github.com/users/krader1961/received_events","type":"User","site_admin":false},"assignees":[{"login":"krader1961","id":7545917,"avatar_url":"https://avatars.githubusercontent.com/u/7545917?v=3","gravatar_id":"","url":"https://api.github.com/users/krader1961","html_url":"https://github.com/krader1961","followers_url":"https://api.github.com/users/krader1961/followers","following_url":"https://api.github.com/users/krader1961/following{/other_user}","gists_url":"https://api.github.com/users/krader1961/gists{/gist_id}","starred_url":"https://api.github.com/users/krader1961/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krader1961/subscriptions","organizations_url":"https://api.github.com/users/krader1961/orgs","repos_url":"https://api.github.com/users/krader1961/repos","events_url":"https://api.github.com/users/krader1961/events{/privacy}","received_events_url":"https://api.github.com/users/krader1961/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/fish-shell/fish-shell/milestones/4","html_url":"https://github.com/fish-shell/fish-shell/milestone/4","labels_url":"https://api.github.com/repos/fish-shell/fish-shell/milestones/4/labels","id":130257,"number":4,"title":"fish-future","description":"These are issues that are not targeted for an upcoming minor or major release. After a release, we will re-examine these issues and pull any in that we think are good targets; that is retarget them to the next minor (or major) release.\r\n\r\nIf you can provide a fix for an issue in this milestone, we'll generally accept it for the next release even if the issue is not targeted for the release.","creator":{"login":"ridiculousfish","id":920838,"avatar_url":"https://avatars.githubusercontent.com/u/920838?v=3","gravatar_id":"","url":"https://api.github.com/users/ridiculousfish","html_url":"https://github.com/ridiculousfish","followers_url":"https://api.github.com/users/ridiculousfish/followers","following_url":"https://api.github.com/users/ridiculousfish/following{/other_user}","gists_url":"https://api.github.com/users/ridiculousfish/gists{/gist_id}","starred_url":"https://api.github.com/users/ridiculousfish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ridiculousfish/subscriptions","organizations_url":"https://api.github.com/users/ridiculousfish/orgs","repos_url":"https://api.github.com/users/ridiculousfish/repos","events_url":"https://api.github.com/users/ridiculousfish/events{/privacy}","received_events_url":"https://api.github.com/users/ridiculousfish/received_events","type":"User","site_admin":false},"open_issues":375,"closed_issues":11,"state":"open","created_at":"2012-06-11T02:25:13Z","updated_at":"2016-12-25T00:35:39Z","due_on":null,"closed_at":null},"comments":4,"created_at":"2016-11-27T03:34:23Z","updated_at":"2016-12-26T03:42:13Z","closed_at":null,"body":"This is not a new problem but I was compelled to open it after seeing that commit df12ac24b2, \"Fix build on systems without shm_open()\", didn't stop errors like the following from `make test` on DragonflyBSD 4.4 (but strangely not FreeBSD 12.0), and Cygwin on MS Windows 10 (but not WSL):\r\n\r\n```\r\nError: Universal variable notifier (1) 0x801032700 polled failed to notice changes, with strategy 1\r\n```\r\n\r\nWe need to fix this because it is important that `make test` only fail for problems that require an immediate \"drop everything else and fix the broken build\"."},"comment":{"url":"https://api.github.com/repos/fish-shell/fish-shell/issues/comments/269155812","html_url":"https://github.com/fish-shell/fish-shell/issues/3587#issuecomment-269155812","issue_url":"https://api.github.com/repos/fish-shell/fish-shell/issues/3587","id":269155812,"user":{"login":"krader1961","id":7545917,"avatar_url":"https://avatars.githubusercontent.com/u/7545917?v=3","gravatar_id":"","url":"https://api.github.com/users/krader1961","html_url":"https://github.com/krader1961","followers_url":"https://api.github.com/users/krader1961/followers","following_url":"https://api.github.com/users/krader1961/following{/other_user}","gists_url":"https://api.github.com/users/krader1961/gists{/gist_id}","starred_url":"https://api.github.com/users/krader1961/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krader1961/subscriptions","organizations_url":"https://api.github.com/users/krader1961/orgs","repos_url":"https://api.github.com/users/krader1961/repos","events_url":"https://api.github.com/users/krader1961/events{/privacy}","received_events_url":"https://api.github.com/users/krader1961/received_events","type":"User","site_admin":false},"created_at":"2016-12-26T03:42:12Z","updated_at":"2016-12-26T03:42:12Z","body":"I now understand what it going on. The core issue is that *src/fish_tests* attempts to test uvar notifier methods that may not be valid for the platform. For example, SysV shared memory on BSD. Since the implementation only allows fish to use a single mechanism that defaults to a value appropriate for the platform, with no fallback, fish_tests should do the same and only test that default notifier mechanism. Making that change allows it to succeed on Dragonfly BSD.\r\n\r\nThe universal tests are still failing randomly on Cygwin. Sometimes they pass but when they fail it's always with different errors. So it looks we have a threading race due to inadequate locking when using the shared memory notifier."}}
{"actor":{"display_login":"krader1961"}}