{"action":"created","comment":{"url":"https://api.github.com/repos/NunyaOS/Nunya/pulls/comments/59485932","id":59485932,"diff_hunk":"@@ -0,0 +1,119 @@\n+/*\n+Copyright (C) 2015 The University of Notre Dame\n+This software is distributed under the GNU General Public License.\n+See the file LICENSE for details.\n+*/\n+\n+\n+#include \"kerneltypes.h\"\n+#include \"kmalloc.h\"\n+#include \"permissions_template.h\"\n+#include \"console.h\"\n+\n+#define MAX_NUMBER_OF_PERMISSIONS 169 // temporary, for now they'll be statically allocated\n+\n+static uint32_t template_counter = 1;\n+static struct permissions_template* permissions_table[MAX_NUMBER_OF_PERMISSIONS]; // statically allocated array of templates\n+\n+uint32_t generate_new_identifier() {\n+    return template_counter++;","path":"src/permissions_template.c","position":19,"original_position":19,"commit_id":"cd4a6c3c5e885406ff94c9c2fb7cb09d17b842e2","original_commit_id":"cd4a6c3c5e885406ff94c9c2fb7cb09d17b842e2","user":{"login":"kkoser","id":3112115,"avatar_url":"https://avatars.githubusercontent.com/u/3112115?v=3","gravatar_id":"","url":"https://api.github.com/users/kkoser","html_url":"https://github.com/kkoser","followers_url":"https://api.github.com/users/kkoser/followers","following_url":"https://api.github.com/users/kkoser/following{/other_user}","gists_url":"https://api.github.com/users/kkoser/gists{/gist_id}","starred_url":"https://api.github.com/users/kkoser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kkoser/subscriptions","organizations_url":"https://api.github.com/users/kkoser/orgs","repos_url":"https://api.github.com/users/kkoser/repos","events_url":"https://api.github.com/users/kkoser/events{/privacy}","received_events_url":"https://api.github.com/users/kkoser/received_events","type":"User","site_admin":false},"body":"We should discuss a way to hash these identifiers or similar. If they follow a predictable pattern, it opens the possibility for processes to request modifications to permissions that they did not create.","created_at":"2016-04-13T02:43:15Z","updated_at":"2016-04-13T02:43:15Z","html_url":"https://github.com/NunyaOS/Nunya/pull/61#discussion_r59485932","pull_request_url":"https://api.github.com/repos/NunyaOS/Nunya/pulls/61","_links":{"self":{"href":"https://api.github.com/repos/NunyaOS/Nunya/pulls/comments/59485932"},"html":{"href":"https://github.com/NunyaOS/Nunya/pull/61#discussion_r59485932"},"pull_request":{"href":"https://api.github.com/repos/NunyaOS/Nunya/pulls/61"}}},"pull_request":{"url":"https://api.github.com/repos/NunyaOS/Nunya/pulls/61","id":66228114,"html_url":"https://github.com/NunyaOS/Nunya/pull/61","diff_url":"https://github.com/NunyaOS/Nunya/pull/61.diff","patch_url":"https://github.com/NunyaOS/Nunya/pull/61.patch","issue_url":"https://api.github.com/repos/NunyaOS/Nunya/issues/61","number":61,"state":"open","locked":false,"title":"Add permission template and process execution syscalls","user":{"login":"zachwaterson","id":6846536,"avatar_url":"https://avatars.githubusercontent.com/u/6846536?v=3","gravatar_id":"","url":"https://api.github.com/users/zachwaterson","html_url":"https://github.com/zachwaterson","followers_url":"https://api.github.com/users/zachwaterson/followers","following_url":"https://api.github.com/users/zachwaterson/following{/other_user}","gists_url":"https://api.github.com/users/zachwaterson/gists{/gist_id}","starred_url":"https://api.github.com/users/zachwaterson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zachwaterson/subscriptions","organizations_url":"https://api.github.com/users/zachwaterson/orgs","repos_url":"https://api.github.com/users/zachwaterson/repos","events_url":"https://api.github.com/users/zachwaterson/events{/privacy}","received_events_url":"https://api.github.com/users/zachwaterson/received_events","type":"User","site_admin":false},"body":"We're back with an even more monstrous commit. The module for permissions templates is created, and the process lifecycle syscalls are updated to use it. This commit also reflects the new code organization schema for syscalls and creates a binary folder for us to store user-level binaries. These binaries will be automatically copied over into files.iso. \r\n\r\nKnown todos: the run() syscall requires that the executable be in ATA 3; this will need to be made more robust by people who know the filesystem better than me. \r\n\r\nWe also need to make it so killing a process kills its children, but I want to talk to Thain about the best way to do that first.","created_at":"2016-04-12T21:06:28Z","updated_at":"2016-04-13T02:43:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f5c96de309ef5f507e2ee8bc0a8f4664bc1905a8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/NunyaOS/Nunya/pulls/61/commits","review_comments_url":"https://api.github.com/repos/NunyaOS/Nunya/pulls/61/comments","review_comment_url":"https://api.github.com/repos/NunyaOS/Nunya/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NunyaOS/Nunya/issues/61/comments","statuses_url":"https://api.github.com/repos/NunyaOS/Nunya/statuses/cd4a6c3c5e885406ff94c9c2fb7cb09d17b842e2","head":{"label":"zachwaterson:run_syscall","ref":"run_syscall","sha":"cd4a6c3c5e885406ff94c9c2fb7cb09d17b842e2","user":{"login":"zachwaterson","id":6846536,"avatar_url":"https://avatars.githubusercontent.com/u/6846536?v=3","gravatar_id":"","url":"https://api.github.com/users/zachwaterson","html_url":"https://github.com/zachwaterson","followers_url":"https://api.github.com/users/zachwaterson/followers","following_url":"https://api.github.com/users/zachwaterson/following{/other_user}","gists_url":"https://api.github.com/users/zachwaterson/gists{/gist_id}","starred_url":"https://api.github.com/users/zachwaterson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zachwaterson/subscriptions","organizations_url":"https://api.github.com/users/zachwaterson/orgs","repos_url":"https://api.github.com/users/zachwaterson/repos","events_url":"https://api.github.com/users/zachwaterson/events{/privacy}","received_events_url":"https://api.github.com/users/zachwaterson/received_events","type":"User","site_admin":false},"repo":{"id":49786309,"name":"Nunya","full_name":"zachwaterson/Nunya","owner":{"login":"zachwaterson","id":6846536,"avatar_url":"https://avatars.githubusercontent.com/u/6846536?v=3","gravatar_id":"","url":"https://api.github.com/users/zachwaterson","html_url":"https://github.com/zachwaterson","followers_url":"https://api.github.com/users/zachwaterson/followers","following_url":"https://api.github.com/users/zachwaterson/following{/other_user}","gists_url":"https://api.github.com/users/zachwaterson/gists{/gist_id}","starred_url":"https://api.github.com/users/zachwaterson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zachwaterson/subscriptions","organizations_url":"https://api.github.com/users/zachwaterson/orgs","repos_url":"https://api.github.com/users/zachwaterson/repos","events_url":"https://api.github.com/users/zachwaterson/events{/privacy}","received_events_url":"https://api.github.com/users/zachwaterson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zachwaterson/Nunya","description":"","fork":true,"url":"https://api.github.com/repos/zachwaterson/Nunya","forks_url":"https://api.github.com/repos/zachwaterson/Nunya/forks","keys_url":"https://api.github.com/repos/zachwaterson/Nunya/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zachwaterson/Nunya/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zachwaterson/Nunya/teams","hooks_url":"https://api.github.com/repos/zachwaterson/Nunya/hooks","issue_events_url":"https://api.github.com/repos/zachwaterson/Nunya/issues/events{/number}","events_url":"https://api.github.com/repos/zachwaterson/Nunya/events","assignees_url":"https://api.github.com/repos/zachwaterson/Nunya/assignees{/user}","branches_url":"https://api.github.com/repos/zachwaterson/Nunya/branches{/branch}","tags_url":"https://api.github.com/repos/zachwaterson/Nunya/tags","blobs_url":"https://api.github.com/repos/zachwaterson/Nunya/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zachwaterson/Nunya/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zachwaterson/Nunya/git/refs{/sha}","trees_url":"https://api.github.com/repos/zachwaterson/Nunya/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zachwaterson/Nunya/statuses/{sha}","languages_url":"https://api.github.com/repos/zachwaterson/Nunya/languages","stargazers_url":"https://api.github.com/repos/zachwaterson/Nunya/stargazers","contributors_url":"https://api.github.com/repos/zachwaterson/Nunya/contributors","subscribers_url":"https://api.github.com/repos/zachwaterson/Nunya/subscribers","subscription_url":"https://api.github.com/repos/zachwaterson/Nunya/subscription","commits_url":"https://api.github.com/repos/zachwaterson/Nunya/commits{/sha}","git_commits_url":"https://api.github.com/repos/zachwaterson/Nunya/git/commits{/sha}","comments_url":"https://api.github.com/repos/zachwaterson/Nunya/comments{/number}","issue_comment_url":"https://api.github.com/repos/zachwaterson/Nunya/issues/comments{/number}","contents_url":"https://api.github.com/repos/zachwaterson/Nunya/contents/{+path}","compare_url":"https://api.github.com/repos/zachwaterson/Nunya/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zachwaterson/Nunya/merges","archive_url":"https://api.github.com/repos/zachwaterson/Nunya/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zachwaterson/Nunya/downloads","issues_url":"https://api.github.com/repos/zachwaterson/Nunya/issues{/number}","pulls_url":"https://api.github.com/repos/zachwaterson/Nunya/pulls{/number}","milestones_url":"https://api.github.com/repos/zachwaterson/Nunya/milestones{/number}","notifications_url":"https://api.github.com/repos/zachwaterson/Nunya/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zachwaterson/Nunya/labels{/name}","releases_url":"https://api.github.com/repos/zachwaterson/Nunya/releases{/id}","deployments_url":"https://api.github.com/repos/zachwaterson/Nunya/deployments","created_at":"2016-01-16T18:49:57Z","updated_at":"2016-01-16T18:49:59Z","pushed_at":"2016-04-12T21:20:39Z","git_url":"git://github.com/zachwaterson/Nunya.git","ssh_url":"git@github.com:zachwaterson/Nunya.git","clone_url":"https://github.com/zachwaterson/Nunya.git","svn_url":"https://github.com/zachwaterson/Nunya","homepage":null,"size":2338,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NunyaOS:master","ref":"master","sha":"77230b315d909186d83aeb9cb824a5df03570e89","user":{"login":"NunyaOS","id":16707703,"avatar_url":"https://avatars.githubusercontent.com/u/16707703?v=3","gravatar_id":"","url":"https://api.github.com/users/NunyaOS","html_url":"https://github.com/NunyaOS","followers_url":"https://api.github.com/users/NunyaOS/followers","following_url":"https://api.github.com/users/NunyaOS/following{/other_user}","gists_url":"https://api.github.com/users/NunyaOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NunyaOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NunyaOS/subscriptions","organizations_url":"https://api.github.com/users/NunyaOS/orgs","repos_url":"https://api.github.com/users/NunyaOS/repos","events_url":"https://api.github.com/users/NunyaOS/events{/privacy}","received_events_url":"https://api.github.com/users/NunyaOS/received_events","type":"Organization","site_admin":false},"repo":{"id":49665082,"name":"Nunya","full_name":"NunyaOS/Nunya","owner":{"login":"NunyaOS","id":16707703,"avatar_url":"https://avatars.githubusercontent.com/u/16707703?v=3","gravatar_id":"","url":"https://api.github.com/users/NunyaOS","html_url":"https://github.com/NunyaOS","followers_url":"https://api.github.com/users/NunyaOS/followers","following_url":"https://api.github.com/users/NunyaOS/following{/other_user}","gists_url":"https://api.github.com/users/NunyaOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NunyaOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NunyaOS/subscriptions","organizations_url":"https://api.github.com/users/NunyaOS/orgs","repos_url":"https://api.github.com/users/NunyaOS/repos","events_url":"https://api.github.com/users/NunyaOS/events{/privacy}","received_events_url":"https://api.github.com/users/NunyaOS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NunyaOS/Nunya","description":"","fork":false,"url":"https://api.github.com/repos/NunyaOS/Nunya","forks_url":"https://api.github.com/repos/NunyaOS/Nunya/forks","keys_url":"https://api.github.com/repos/NunyaOS/Nunya/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NunyaOS/Nunya/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NunyaOS/Nunya/teams","hooks_url":"https://api.github.com/repos/NunyaOS/Nunya/hooks","issue_events_url":"https://api.github.com/repos/NunyaOS/Nunya/issues/events{/number}","events_url":"https://api.github.com/repos/NunyaOS/Nunya/events","assignees_url":"https://api.github.com/repos/NunyaOS/Nunya/assignees{/user}","branches_url":"https://api.github.com/repos/NunyaOS/Nunya/branches{/branch}","tags_url":"https://api.github.com/repos/NunyaOS/Nunya/tags","blobs_url":"https://api.github.com/repos/NunyaOS/Nunya/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NunyaOS/Nunya/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NunyaOS/Nunya/git/refs{/sha}","trees_url":"https://api.github.com/repos/NunyaOS/Nunya/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NunyaOS/Nunya/statuses/{sha}","languages_url":"https://api.github.com/repos/NunyaOS/Nunya/languages","stargazers_url":"https://api.github.com/repos/NunyaOS/Nunya/stargazers","contributors_url":"https://api.github.com/repos/NunyaOS/Nunya/contributors","subscribers_url":"https://api.github.com/repos/NunyaOS/Nunya/subscribers","subscription_url":"https://api.github.com/repos/NunyaOS/Nunya/subscription","commits_url":"https://api.github.com/repos/NunyaOS/Nunya/commits{/sha}","git_commits_url":"https://api.github.com/repos/NunyaOS/Nunya/git/commits{/sha}","comments_url":"https://api.github.com/repos/NunyaOS/Nunya/comments{/number}","issue_comment_url":"https://api.github.com/repos/NunyaOS/Nunya/issues/comments{/number}","contents_url":"https://api.github.com/repos/NunyaOS/Nunya/contents/{+path}","compare_url":"https://api.github.com/repos/NunyaOS/Nunya/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NunyaOS/Nunya/merges","archive_url":"https://api.github.com/repos/NunyaOS/Nunya/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NunyaOS/Nunya/downloads","issues_url":"https://api.github.com/repos/NunyaOS/Nunya/issues{/number}","pulls_url":"https://api.github.com/repos/NunyaOS/Nunya/pulls{/number}","milestones_url":"https://api.github.com/repos/NunyaOS/Nunya/milestones{/number}","notifications_url":"https://api.github.com/repos/NunyaOS/Nunya/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NunyaOS/Nunya/labels{/name}","releases_url":"https://api.github.com/repos/NunyaOS/Nunya/releases{/id}","deployments_url":"https://api.github.com/repos/NunyaOS/Nunya/deployments","created_at":"2016-01-14T18:02:40Z","updated_at":"2016-02-10T13:22:21Z","pushed_at":"2016-04-12T21:32:30Z","git_url":"git://github.com/NunyaOS/Nunya.git","ssh_url":"git@github.com:NunyaOS/Nunya.git","clone_url":"https://github.com/NunyaOS/Nunya.git","svn_url":"https://github.com/NunyaOS/Nunya","homepage":"nunyaos.github.io","size":2504,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":4,"forks":7,"open_issues":4,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NunyaOS/Nunya/pulls/61"},"html":{"href":"https://github.com/NunyaOS/Nunya/pull/61"},"issue":{"href":"https://api.github.com/repos/NunyaOS/Nunya/issues/61"},"comments":{"href":"https://api.github.com/repos/NunyaOS/Nunya/issues/61/comments"},"review_comments":{"href":"https://api.github.com/repos/NunyaOS/Nunya/pulls/61/comments"},"review_comment":{"href":"https://api.github.com/repos/NunyaOS/Nunya/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NunyaOS/Nunya/pulls/61/commits"},"statuses":{"href":"https://api.github.com/repos/NunyaOS/Nunya/statuses/cd4a6c3c5e885406ff94c9c2fb7cb09d17b842e2"}}}}