{"action":"created","comment":{"url":"https://api.github.com/repos/ceph/ceph/pulls/comments/89950848","pull_request_review_id":10477866,"id":89950848,"diff_hunk":"@@ -234,6 +234,13 @@ option(WITH_KVS \"Key value store is here\" ON)\n # remote block storage\n option(WITH_RBD \"Remote block storage is here\" ON)\n \n+# embedded ceph daemon static library\n+# NOTE: Ceph is mostly LGPL (see COPYING), which means that\n+# static linking brings with it restrictions. Please be sure\n+# to look at the LGPL license carefully before linking this library to\n+# your code. See http://www.gnu.org/licenses/gpl-faq.html#LGPLStaticVsDynamic.\n+option(WITH_EMBEDDED \"build the embedded ceph daemon library\" ON)","path":"CMakeLists.txt","position":9,"original_position":9,"commit_id":"29140112e0427a396b80df3dd94c7b58d6533d81","original_commit_id":"152e81c328e54e0dddc94b649f0276b60fb8b2b3","user":{"login":"tchaikov","id":59071,"avatar_url":"https://avatars.githubusercontent.com/u/59071?v=3","gravatar_id":"","url":"https://api.github.com/users/tchaikov","html_url":"https://github.com/tchaikov","followers_url":"https://api.github.com/users/tchaikov/followers","following_url":"https://api.github.com/users/tchaikov/following{/other_user}","gists_url":"https://api.github.com/users/tchaikov/gists{/gist_id}","starred_url":"https://api.github.com/users/tchaikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tchaikov/subscriptions","organizations_url":"https://api.github.com/users/tchaikov/orgs","repos_url":"https://api.github.com/users/tchaikov/repos","events_url":"https://api.github.com/users/tchaikov/events{/privacy}","received_events_url":"https://api.github.com/users/tchaikov/received_events","type":"User","site_admin":false},"body":"@bassamtabbara ping.","created_at":"2016-11-29T07:04:05Z","updated_at":"2016-11-29T07:04:05Z","html_url":"https://github.com/ceph/ceph/pull/11764#discussion_r89950848","pull_request_url":"https://api.github.com/repos/ceph/ceph/pulls/11764","_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments/89950848"},"html":{"href":"https://github.com/ceph/ceph/pull/11764#discussion_r89950848"},"pull_request":{"href":"https://api.github.com/repos/ceph/ceph/pulls/11764"}}},"pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/11764","id":92157058,"html_url":"https://github.com/ceph/ceph/pull/11764","diff_url":"https://github.com/ceph/ceph/pull/11764.diff","patch_url":"https://github.com/ceph/ceph/pull/11764.patch","issue_url":"https://api.github.com/repos/ceph/ceph/issues/11764","number":11764,"state":"open","locked":false,"title":"cmake: Support for embedding Ceph Daemons","user":{"login":"bassamtabbara","id":1463491,"avatar_url":"https://avatars.githubusercontent.com/u/1463491?v=3","gravatar_id":"","url":"https://api.github.com/users/bassamtabbara","html_url":"https://github.com/bassamtabbara","followers_url":"https://api.github.com/users/bassamtabbara/followers","following_url":"https://api.github.com/users/bassamtabbara/following{/other_user}","gists_url":"https://api.github.com/users/bassamtabbara/gists{/gist_id}","starred_url":"https://api.github.com/users/bassamtabbara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bassamtabbara/subscriptions","organizations_url":"https://api.github.com/users/bassamtabbara/orgs","repos_url":"https://api.github.com/users/bassamtabbara/repos","events_url":"https://api.github.com/users/bassamtabbara/events{/privacy}","received_events_url":"https://api.github.com/users/bassamtabbara/received_events","type":"User","site_admin":false},"body":"This PR adds support for embedding Ceph Daemons. Currently only MON and OSD are supported. See http://pad.ceph.com/p/embedded-ceph for more context.\r\n\r\nNote that WITH_EMBEDDED is set to on by default to ensure that the bits don't go stale. I plan on adding unit tests in a separate PR for this work.\r\n\r\nTo ease the review, I recommend you look at each commit in order.","created_at":"2016-11-03T13:51:32Z","updated_at":"2016-11-29T07:04:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f50e24b77102909ee6ae409c251b0b03dfb08986","assignee":{"login":"tchaikov","id":59071,"avatar_url":"https://avatars.githubusercontent.com/u/59071?v=3","gravatar_id":"","url":"https://api.github.com/users/tchaikov","html_url":"https://github.com/tchaikov","followers_url":"https://api.github.com/users/tchaikov/followers","following_url":"https://api.github.com/users/tchaikov/following{/other_user}","gists_url":"https://api.github.com/users/tchaikov/gists{/gist_id}","starred_url":"https://api.github.com/users/tchaikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tchaikov/subscriptions","organizations_url":"https://api.github.com/users/tchaikov/orgs","repos_url":"https://api.github.com/users/tchaikov/repos","events_url":"https://api.github.com/users/tchaikov/events{/privacy}","received_events_url":"https://api.github.com/users/tchaikov/received_events","type":"User","site_admin":false},"assignees":[{"login":"tchaikov","id":59071,"avatar_url":"https://avatars.githubusercontent.com/u/59071?v=3","gravatar_id":"","url":"https://api.github.com/users/tchaikov","html_url":"https://github.com/tchaikov","followers_url":"https://api.github.com/users/tchaikov/followers","following_url":"https://api.github.com/users/tchaikov/following{/other_user}","gists_url":"https://api.github.com/users/tchaikov/gists{/gist_id}","starred_url":"https://api.github.com/users/tchaikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tchaikov/subscriptions","organizations_url":"https://api.github.com/users/tchaikov/orgs","repos_url":"https://api.github.com/users/tchaikov/repos","events_url":"https://api.github.com/users/tchaikov/events{/privacy}","received_events_url":"https://api.github.com/users/tchaikov/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/ceph/ceph/milestones/9","html_url":"https://github.com/ceph/ceph/milestones/kraken","labels_url":"https://api.github.com/repos/ceph/ceph/milestones/9/labels","id":1642631,"number":9,"title":"kraken","description":"","creator":{"login":"liewegas","id":433031,"avatar_url":"https://avatars.githubusercontent.com/u/433031?v=3","gravatar_id":"","url":"https://api.github.com/users/liewegas","html_url":"https://github.com/liewegas","followers_url":"https://api.github.com/users/liewegas/followers","following_url":"https://api.github.com/users/liewegas/following{/other_user}","gists_url":"https://api.github.com/users/liewegas/gists{/gist_id}","starred_url":"https://api.github.com/users/liewegas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liewegas/subscriptions","organizations_url":"https://api.github.com/users/liewegas/orgs","repos_url":"https://api.github.com/users/liewegas/repos","events_url":"https://api.github.com/users/liewegas/events{/privacy}","received_events_url":"https://api.github.com/users/liewegas/received_events","type":"User","site_admin":false},"open_issues":16,"closed_issues":159,"state":"open","created_at":"2016-03-14T12:28:24Z","updated_at":"2016-11-29T06:14:52Z","due_on":"2016-12-11T00:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/ceph/ceph/pulls/11764/commits","review_comments_url":"https://api.github.com/repos/ceph/ceph/pulls/11764/comments","review_comment_url":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/11764/comments","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/29140112e0427a396b80df3dd94c7b58d6533d81","head":{"label":"bassamtabbara:wip-embedded","ref":"wip-embedded","sha":"29140112e0427a396b80df3dd94c7b58d6533d81","user":{"login":"bassamtabbara","id":1463491,"avatar_url":"https://avatars.githubusercontent.com/u/1463491?v=3","gravatar_id":"","url":"https://api.github.com/users/bassamtabbara","html_url":"https://github.com/bassamtabbara","followers_url":"https://api.github.com/users/bassamtabbara/followers","following_url":"https://api.github.com/users/bassamtabbara/following{/other_user}","gists_url":"https://api.github.com/users/bassamtabbara/gists{/gist_id}","starred_url":"https://api.github.com/users/bassamtabbara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bassamtabbara/subscriptions","organizations_url":"https://api.github.com/users/bassamtabbara/orgs","repos_url":"https://api.github.com/users/bassamtabbara/repos","events_url":"https://api.github.com/users/bassamtabbara/events{/privacy}","received_events_url":"https://api.github.com/users/bassamtabbara/received_events","type":"User","site_admin":false},"repo":{"id":67741532,"name":"ceph","full_name":"bassamtabbara/ceph","owner":{"login":"bassamtabbara","id":1463491,"avatar_url":"https://avatars.githubusercontent.com/u/1463491?v=3","gravatar_id":"","url":"https://api.github.com/users/bassamtabbara","html_url":"https://github.com/bassamtabbara","followers_url":"https://api.github.com/users/bassamtabbara/followers","following_url":"https://api.github.com/users/bassamtabbara/following{/other_user}","gists_url":"https://api.github.com/users/bassamtabbara/gists{/gist_id}","starred_url":"https://api.github.com/users/bassamtabbara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bassamtabbara/subscriptions","organizations_url":"https://api.github.com/users/bassamtabbara/orgs","repos_url":"https://api.github.com/users/bassamtabbara/repos","events_url":"https://api.github.com/users/bassamtabbara/events{/privacy}","received_events_url":"https://api.github.com/users/bassamtabbara/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bassamtabbara/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":true,"url":"https://api.github.com/repos/bassamtabbara/ceph","forks_url":"https://api.github.com/repos/bassamtabbara/ceph/forks","keys_url":"https://api.github.com/repos/bassamtabbara/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bassamtabbara/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bassamtabbara/ceph/teams","hooks_url":"https://api.github.com/repos/bassamtabbara/ceph/hooks","issue_events_url":"https://api.github.com/repos/bassamtabbara/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/bassamtabbara/ceph/events","assignees_url":"https://api.github.com/repos/bassamtabbara/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/bassamtabbara/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/bassamtabbara/ceph/tags","blobs_url":"https://api.github.com/repos/bassamtabbara/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bassamtabbara/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bassamtabbara/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/bassamtabbara/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bassamtabbara/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/bassamtabbara/ceph/languages","stargazers_url":"https://api.github.com/repos/bassamtabbara/ceph/stargazers","contributors_url":"https://api.github.com/repos/bassamtabbara/ceph/contributors","subscribers_url":"https://api.github.com/repos/bassamtabbara/ceph/subscribers","subscription_url":"https://api.github.com/repos/bassamtabbara/ceph/subscription","commits_url":"https://api.github.com/repos/bassamtabbara/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/bassamtabbara/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/bassamtabbara/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/bassamtabbara/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/bassamtabbara/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/bassamtabbara/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bassamtabbara/ceph/merges","archive_url":"https://api.github.com/repos/bassamtabbara/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bassamtabbara/ceph/downloads","issues_url":"https://api.github.com/repos/bassamtabbara/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/bassamtabbara/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/bassamtabbara/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/bassamtabbara/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bassamtabbara/ceph/labels{/name}","releases_url":"https://api.github.com/repos/bassamtabbara/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/bassamtabbara/ceph/deployments","created_at":"2016-09-08T21:26:48Z","updated_at":"2016-09-08T21:27:26Z","pushed_at":"2016-11-23T07:14:12Z","git_url":"git://github.com/bassamtabbara/ceph.git","ssh_url":"git@github.com:bassamtabbara/ceph.git","clone_url":"https://github.com/bassamtabbara/ceph.git","svn_url":"https://github.com/bassamtabbara/ceph","homepage":"http://ceph.com","size":186962,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ceph:master","ref":"master","sha":"335d50f17834320ac90816590fa9338fe8e2861c","user":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":2310495,"name":"ceph","full_name":"ceph/ceph","owner":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ceph/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":false,"url":"https://api.github.com/repos/ceph/ceph","forks_url":"https://api.github.com/repos/ceph/ceph/forks","keys_url":"https://api.github.com/repos/ceph/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph/teams","hooks_url":"https://api.github.com/repos/ceph/ceph/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph/events","assignees_url":"https://api.github.com/repos/ceph/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph/tags","blobs_url":"https://api.github.com/repos/ceph/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph/subscription","commits_url":"https://api.github.com/repos/ceph/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph/merges","archive_url":"https://api.github.com/repos/ceph/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph/downloads","issues_url":"https://api.github.com/repos/ceph/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/ceph/ceph/deployments","created_at":"2011-09-01T21:41:26Z","updated_at":"2016-11-29T04:06:33Z","pushed_at":"2016-11-29T06:58:45Z","git_url":"git://github.com/ceph/ceph.git","ssh_url":"git@github.com:ceph/ceph.git","clone_url":"https://github.com/ceph/ceph.git","svn_url":"https://github.com/ceph/ceph","homepage":"http://ceph.com","size":252536,"stargazers_count":2658,"watchers_count":2658,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1565,"mirror_url":null,"open_issues_count":326,"forks":1565,"open_issues":326,"watchers":2658,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/11764"},"html":{"href":"https://github.com/ceph/ceph/pull/11764"},"issue":{"href":"https://api.github.com/repos/ceph/ceph/issues/11764"},"comments":{"href":"https://api.github.com/repos/ceph/ceph/issues/11764/comments"},"review_comments":{"href":"https://api.github.com/repos/ceph/ceph/pulls/11764/comments"},"review_comment":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ceph/ceph/pulls/11764/commits"},"statuses":{"href":"https://api.github.com/repos/ceph/ceph/statuses/29140112e0427a396b80df3dd94c7b58d6533d81"}}}}
{"actor":{"display_login":"tchaikov"}}