{"action":"created","comment":{"url":"https://api.github.com/repos/joblib/joblib/pulls/comments/91762117","pull_request_review_id":12274250,"id":91762117,"diff_hunk":"@@ -81,58 +62,61 @@ def f(self, x):\n ###############################################################################\n # Tests\n \n-def test_filter_args():\n-    yield assert_equal, filter_args(f, [], (1, )), {'x': 1, 'y': 0}\n-    yield assert_equal, filter_args(f, ['x'], (1, )), {'y': 0}\n-    yield assert_equal, filter_args(f, ['y'], (0, )), {'x': 0}\n-    yield assert_equal, filter_args(f, ['y'], (0, ), dict(y=1)), {'x': 0}\n-    yield assert_equal, filter_args(f, ['x', 'y'], (0, )), {}\n-    yield assert_equal, filter_args(f, [], (0,), dict(y=1)), {'x': 0, 'y': 1}\n-    yield assert_equal, filter_args(f, ['y'], (), dict(x=2, y=1)), {'x': 2}\n \n-    yield assert_equal, filter_args(i, [], (2, )), {'x': 2}\n-    yield assert_equal, filter_args(f2, [], (), dict(x=1)), {'x': 1}\n+@parametrize(['funcname', 'args', 'filtered_args'],\n+             [('f', [[], (1, )], {'x': 1, 'y': 0}),","path":"joblib/test/test_func_inspect.py","position":114,"original_position":114,"commit_id":"4b36e896bd2de2d35dee80520d56a03bd8b47d4f","original_commit_id":"4dfa48474b8c1dac187afa9e45a96fb0dc1c7bd4","user":{"login":"karandesai-96","id":10494087,"avatar_url":"https://avatars.githubusercontent.com/u/10494087?v=3","gravatar_id":"","url":"https://api.github.com/users/karandesai-96","html_url":"https://github.com/karandesai-96","followers_url":"https://api.github.com/users/karandesai-96/followers","following_url":"https://api.github.com/users/karandesai-96/following{/other_user}","gists_url":"https://api.github.com/users/karandesai-96/gists{/gist_id}","starred_url":"https://api.github.com/users/karandesai-96/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karandesai-96/subscriptions","organizations_url":"https://api.github.com/users/karandesai-96/orgs","repos_url":"https://api.github.com/users/karandesai-96/repos","events_url":"https://api.github.com/users/karandesai-96/events{/privacy}","received_events_url":"https://api.github.com/users/karandesai-96/received_events","type":"User","site_admin":false},"body":"Yes, because `f2` depends on tmpdir. So would it be great if `f2` is enclosed in a fixture while other functions just stay there in global scope ?","created_at":"2016-12-09T17:47:57Z","updated_at":"2016-12-09T17:47:57Z","html_url":"https://github.com/joblib/joblib/pull/450#discussion_r91762117","pull_request_url":"https://api.github.com/repos/joblib/joblib/pulls/450","_links":{"self":{"href":"https://api.github.com/repos/joblib/joblib/pulls/comments/91762117"},"html":{"href":"https://github.com/joblib/joblib/pull/450#discussion_r91762117"},"pull_request":{"href":"https://api.github.com/repos/joblib/joblib/pulls/450"}}},"pull_request":{"url":"https://api.github.com/repos/joblib/joblib/pulls/450","id":97346439,"html_url":"https://github.com/joblib/joblib/pull/450","diff_url":"https://github.com/joblib/joblib/pull/450.diff","patch_url":"https://github.com/joblib/joblib/pull/450.patch","issue_url":"https://api.github.com/repos/joblib/joblib/issues/450","number":450,"state":"open","locked":false,"title":"[WIP] Refactor test_disk.py as per pytest design.","user":{"login":"karandesai-96","id":10494087,"avatar_url":"https://avatars.githubusercontent.com/u/10494087?v=3","gravatar_id":"","url":"https://api.github.com/users/karandesai-96","html_url":"https://github.com/karandesai-96","followers_url":"https://api.github.com/users/karandesai-96/followers","following_url":"https://api.github.com/users/karandesai-96/following{/other_user}","gists_url":"https://api.github.com/users/karandesai-96/gists{/gist_id}","starred_url":"https://api.github.com/users/karandesai-96/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karandesai-96/subscriptions","organizations_url":"https://api.github.com/users/karandesai-96/orgs","repos_url":"https://api.github.com/users/karandesai-96/repos","events_url":"https://api.github.com/users/karandesai-96/events{/privacy}","received_events_url":"https://api.github.com/users/karandesai-96/received_events","type":"User","site_admin":false},"body":"#### Third Phase PR on #411 (Succeeding PR #446)\r\n\r\nThis PR deals with refactor of tests in **test_func_inspect.py** to adopt the pytest flavor.\r\n\r\n* Prior to this PR, each method had several `yield` based statements where the test cases comprised of a set of functions with args and kwargs as well. I have proposed a `fixture` which returns a dictionary of functions to make `parametrization` easier.\r\n\r\n* `with_numpy` decorator is now a `pytest.skipif` marker.","created_at":"2016-12-09T17:15:21Z","updated_at":"2016-12-09T17:47:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"df8ecc58530e63058d22ee17ad5cb0644d45baf9","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/joblib/joblib/pulls/450/commits","review_comments_url":"https://api.github.com/repos/joblib/joblib/pulls/450/comments","review_comment_url":"https://api.github.com/repos/joblib/joblib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/joblib/joblib/issues/450/comments","statuses_url":"https://api.github.com/repos/joblib/joblib/statuses/4b36e896bd2de2d35dee80520d56a03bd8b47d4f","head":{"label":"karandesai-96:pytestify-test-func-inspect","ref":"pytestify-test-func-inspect","sha":"4b36e896bd2de2d35dee80520d56a03bd8b47d4f","user":{"login":"karandesai-96","id":10494087,"avatar_url":"https://avatars.githubusercontent.com/u/10494087?v=3","gravatar_id":"","url":"https://api.github.com/users/karandesai-96","html_url":"https://github.com/karandesai-96","followers_url":"https://api.github.com/users/karandesai-96/followers","following_url":"https://api.github.com/users/karandesai-96/following{/other_user}","gists_url":"https://api.github.com/users/karandesai-96/gists{/gist_id}","starred_url":"https://api.github.com/users/karandesai-96/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karandesai-96/subscriptions","organizations_url":"https://api.github.com/users/karandesai-96/orgs","repos_url":"https://api.github.com/users/karandesai-96/repos","events_url":"https://api.github.com/users/karandesai-96/events{/privacy}","received_events_url":"https://api.github.com/users/karandesai-96/received_events","type":"User","site_admin":false},"repo":{"id":72710695,"name":"joblib","full_name":"karandesai-96/joblib","owner":{"login":"karandesai-96","id":10494087,"avatar_url":"https://avatars.githubusercontent.com/u/10494087?v=3","gravatar_id":"","url":"https://api.github.com/users/karandesai-96","html_url":"https://github.com/karandesai-96","followers_url":"https://api.github.com/users/karandesai-96/followers","following_url":"https://api.github.com/users/karandesai-96/following{/other_user}","gists_url":"https://api.github.com/users/karandesai-96/gists{/gist_id}","starred_url":"https://api.github.com/users/karandesai-96/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karandesai-96/subscriptions","organizations_url":"https://api.github.com/users/karandesai-96/orgs","repos_url":"https://api.github.com/users/karandesai-96/repos","events_url":"https://api.github.com/users/karandesai-96/events{/privacy}","received_events_url":"https://api.github.com/users/karandesai-96/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/karandesai-96/joblib","description":"Python function as pipeline jobs.","fork":true,"url":"https://api.github.com/repos/karandesai-96/joblib","forks_url":"https://api.github.com/repos/karandesai-96/joblib/forks","keys_url":"https://api.github.com/repos/karandesai-96/joblib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/karandesai-96/joblib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/karandesai-96/joblib/teams","hooks_url":"https://api.github.com/repos/karandesai-96/joblib/hooks","issue_events_url":"https://api.github.com/repos/karandesai-96/joblib/issues/events{/number}","events_url":"https://api.github.com/repos/karandesai-96/joblib/events","assignees_url":"https://api.github.com/repos/karandesai-96/joblib/assignees{/user}","branches_url":"https://api.github.com/repos/karandesai-96/joblib/branches{/branch}","tags_url":"https://api.github.com/repos/karandesai-96/joblib/tags","blobs_url":"https://api.github.com/repos/karandesai-96/joblib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/karandesai-96/joblib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/karandesai-96/joblib/git/refs{/sha}","trees_url":"https://api.github.com/repos/karandesai-96/joblib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/karandesai-96/joblib/statuses/{sha}","languages_url":"https://api.github.com/repos/karandesai-96/joblib/languages","stargazers_url":"https://api.github.com/repos/karandesai-96/joblib/stargazers","contributors_url":"https://api.github.com/repos/karandesai-96/joblib/contributors","subscribers_url":"https://api.github.com/repos/karandesai-96/joblib/subscribers","subscription_url":"https://api.github.com/repos/karandesai-96/joblib/subscription","commits_url":"https://api.github.com/repos/karandesai-96/joblib/commits{/sha}","git_commits_url":"https://api.github.com/repos/karandesai-96/joblib/git/commits{/sha}","comments_url":"https://api.github.com/repos/karandesai-96/joblib/comments{/number}","issue_comment_url":"https://api.github.com/repos/karandesai-96/joblib/issues/comments{/number}","contents_url":"https://api.github.com/repos/karandesai-96/joblib/contents/{+path}","compare_url":"https://api.github.com/repos/karandesai-96/joblib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/karandesai-96/joblib/merges","archive_url":"https://api.github.com/repos/karandesai-96/joblib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/karandesai-96/joblib/downloads","issues_url":"https://api.github.com/repos/karandesai-96/joblib/issues{/number}","pulls_url":"https://api.github.com/repos/karandesai-96/joblib/pulls{/number}","milestones_url":"https://api.github.com/repos/karandesai-96/joblib/milestones{/number}","notifications_url":"https://api.github.com/repos/karandesai-96/joblib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/karandesai-96/joblib/labels{/name}","releases_url":"https://api.github.com/repos/karandesai-96/joblib/releases{/id}","deployments_url":"https://api.github.com/repos/karandesai-96/joblib/deployments","created_at":"2016-11-03T05:08:11Z","updated_at":"2016-11-03T05:08:15Z","pushed_at":"2016-12-09T17:45:56Z","git_url":"git://github.com/karandesai-96/joblib.git","ssh_url":"git@github.com:karandesai-96/joblib.git","clone_url":"https://github.com/karandesai-96/joblib.git","svn_url":"https://github.com/karandesai-96/joblib","homepage":"http://packages.python.org/joblib/","size":2601,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"joblib:master","ref":"master","sha":"8ed58ebd57a4d97da9e43568734c72310fd7be54","user":{"login":"joblib","id":332661,"avatar_url":"https://avatars.githubusercontent.com/u/332661?v=3","gravatar_id":"","url":"https://api.github.com/users/joblib","html_url":"https://github.com/joblib","followers_url":"https://api.github.com/users/joblib/followers","following_url":"https://api.github.com/users/joblib/following{/other_user}","gists_url":"https://api.github.com/users/joblib/gists{/gist_id}","starred_url":"https://api.github.com/users/joblib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joblib/subscriptions","organizations_url":"https://api.github.com/users/joblib/orgs","repos_url":"https://api.github.com/users/joblib/repos","events_url":"https://api.github.com/users/joblib/events{/privacy}","received_events_url":"https://api.github.com/users/joblib/received_events","type":"Organization","site_admin":false},"repo":{"id":654608,"name":"joblib","full_name":"joblib/joblib","owner":{"login":"joblib","id":332661,"avatar_url":"https://avatars.githubusercontent.com/u/332661?v=3","gravatar_id":"","url":"https://api.github.com/users/joblib","html_url":"https://github.com/joblib","followers_url":"https://api.github.com/users/joblib/followers","following_url":"https://api.github.com/users/joblib/following{/other_user}","gists_url":"https://api.github.com/users/joblib/gists{/gist_id}","starred_url":"https://api.github.com/users/joblib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joblib/subscriptions","organizations_url":"https://api.github.com/users/joblib/orgs","repos_url":"https://api.github.com/users/joblib/repos","events_url":"https://api.github.com/users/joblib/events{/privacy}","received_events_url":"https://api.github.com/users/joblib/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/joblib/joblib","description":"Python function as pipeline jobs.","fork":false,"url":"https://api.github.com/repos/joblib/joblib","forks_url":"https://api.github.com/repos/joblib/joblib/forks","keys_url":"https://api.github.com/repos/joblib/joblib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joblib/joblib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joblib/joblib/teams","hooks_url":"https://api.github.com/repos/joblib/joblib/hooks","issue_events_url":"https://api.github.com/repos/joblib/joblib/issues/events{/number}","events_url":"https://api.github.com/repos/joblib/joblib/events","assignees_url":"https://api.github.com/repos/joblib/joblib/assignees{/user}","branches_url":"https://api.github.com/repos/joblib/joblib/branches{/branch}","tags_url":"https://api.github.com/repos/joblib/joblib/tags","blobs_url":"https://api.github.com/repos/joblib/joblib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joblib/joblib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joblib/joblib/git/refs{/sha}","trees_url":"https://api.github.com/repos/joblib/joblib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joblib/joblib/statuses/{sha}","languages_url":"https://api.github.com/repos/joblib/joblib/languages","stargazers_url":"https://api.github.com/repos/joblib/joblib/stargazers","contributors_url":"https://api.github.com/repos/joblib/joblib/contributors","subscribers_url":"https://api.github.com/repos/joblib/joblib/subscribers","subscription_url":"https://api.github.com/repos/joblib/joblib/subscription","commits_url":"https://api.github.com/repos/joblib/joblib/commits{/sha}","git_commits_url":"https://api.github.com/repos/joblib/joblib/git/commits{/sha}","comments_url":"https://api.github.com/repos/joblib/joblib/comments{/number}","issue_comment_url":"https://api.github.com/repos/joblib/joblib/issues/comments{/number}","contents_url":"https://api.github.com/repos/joblib/joblib/contents/{+path}","compare_url":"https://api.github.com/repos/joblib/joblib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joblib/joblib/merges","archive_url":"https://api.github.com/repos/joblib/joblib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joblib/joblib/downloads","issues_url":"https://api.github.com/repos/joblib/joblib/issues{/number}","pulls_url":"https://api.github.com/repos/joblib/joblib/pulls{/number}","milestones_url":"https://api.github.com/repos/joblib/joblib/milestones{/number}","notifications_url":"https://api.github.com/repos/joblib/joblib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joblib/joblib/labels{/name}","releases_url":"https://api.github.com/repos/joblib/joblib/releases{/id}","deployments_url":"https://api.github.com/repos/joblib/joblib/deployments","created_at":"2010-05-07T06:48:26Z","updated_at":"2016-12-08T08:58:45Z","pushed_at":"2016-12-09T17:45:56Z","git_url":"git://github.com/joblib/joblib.git","ssh_url":"git@github.com:joblib/joblib.git","clone_url":"https://github.com/joblib/joblib.git","svn_url":"https://github.com/joblib/joblib","homepage":"http://packages.python.org/joblib/","size":3636,"stargazers_count":799,"watchers_count":799,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":123,"mirror_url":null,"open_issues_count":111,"forks":123,"open_issues":111,"watchers":799,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/joblib/joblib/pulls/450"},"html":{"href":"https://github.com/joblib/joblib/pull/450"},"issue":{"href":"https://api.github.com/repos/joblib/joblib/issues/450"},"comments":{"href":"https://api.github.com/repos/joblib/joblib/issues/450/comments"},"review_comments":{"href":"https://api.github.com/repos/joblib/joblib/pulls/450/comments"},"review_comment":{"href":"https://api.github.com/repos/joblib/joblib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/joblib/joblib/pulls/450/commits"},"statuses":{"href":"https://api.github.com/repos/joblib/joblib/statuses/4b36e896bd2de2d35dee80520d56a03bd8b47d4f"}}}}
{"actor":{"display_login":"karandesai-96"}}