{"action":"created","comment":{"url":"https://api.github.com/repos/qooxdoo/qooxdoo/pulls/comments/91028202","pull_request_review_id":11538275,"id":91028202,"diff_hunk":"@@ -118,6 +118,17 @@ qx.Class.define(\"qx.ui.form.Spinner\",\n     } else {\n       this.initValue();\n     }\n+\n+    // forward the focusin and focusout events to the textfield. The textfield\n+    // is not focusable so the events need to be forwarded manually.\n+    this.addListener(\"focusin\", function(e) {\n+      textField.fireNonBubblingEvent(\"focusin\", qx.event.type.Focus);\n+      textField.selectAllText();","path":"framework/source/class/qx/ui/form/Spinner.js","position":null,"original_position":18,"commit_id":"f5328208b941efb456f100230aeec905aef0cc6d","original_commit_id":"08f05c08ed9a09e3161bb15f4fee0beb498b378d","user":{"login":"cajus","id":722353,"avatar_url":"https://avatars.githubusercontent.com/u/722353?v=3","gravatar_id":"","url":"https://api.github.com/users/cajus","html_url":"https://github.com/cajus","followers_url":"https://api.github.com/users/cajus/followers","following_url":"https://api.github.com/users/cajus/following{/other_user}","gists_url":"https://api.github.com/users/cajus/gists{/gist_id}","starred_url":"https://api.github.com/users/cajus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cajus/subscriptions","organizations_url":"https://api.github.com/users/cajus/orgs","repos_url":"https://api.github.com/users/cajus/repos","events_url":"https://api.github.com/users/cajus/events{/privacy}","received_events_url":"https://api.github.com/users/cajus/received_events","type":"User","site_admin":false},"body":"I personally would prefer a \"cursor after text\" in all textfield related widgets.","created_at":"2016-12-06T08:10:56Z","updated_at":"2016-12-06T08:10:56Z","html_url":"https://github.com/qooxdoo/qooxdoo/pull/9246#discussion_r91028202","pull_request_url":"https://api.github.com/repos/qooxdoo/qooxdoo/pulls/9246","_links":{"self":{"href":"https://api.github.com/repos/qooxdoo/qooxdoo/pulls/comments/91028202"},"html":{"href":"https://github.com/qooxdoo/qooxdoo/pull/9246#discussion_r91028202"},"pull_request":{"href":"https://api.github.com/repos/qooxdoo/qooxdoo/pulls/9246"}}},"pull_request":{"url":"https://api.github.com/repos/qooxdoo/qooxdoo/pulls/9246","id":96540583,"html_url":"https://github.com/qooxdoo/qooxdoo/pull/9246","diff_url":"https://github.com/qooxdoo/qooxdoo/pull/9246.diff","patch_url":"https://github.com/qooxdoo/qooxdoo/pull/9246.patch","issue_url":"https://api.github.com/repos/qooxdoo/qooxdoo/issues/9246","number":9246,"state":"open","locked":false,"title":"Issue #9245: Fix spinner focus handling","user":{"login":"cajus","id":722353,"avatar_url":"https://avatars.githubusercontent.com/u/722353?v=3","gravatar_id":"","url":"https://api.github.com/users/cajus","html_url":"https://github.com/cajus","followers_url":"https://api.github.com/users/cajus/followers","following_url":"https://api.github.com/users/cajus/following{/other_user}","gists_url":"https://api.github.com/users/cajus/gists{/gist_id}","starred_url":"https://api.github.com/users/cajus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cajus/subscriptions","organizations_url":"https://api.github.com/users/cajus/orgs","repos_url":"https://api.github.com/users/cajus/repos","events_url":"https://api.github.com/users/cajus/events{/privacy}","received_events_url":"https://api.github.com/users/cajus/received_events","type":"User","site_admin":false},"body":"Do the focus handling more or less analogue like it's done in the DateField.\r\n\r\nFixes #9245","created_at":"2016-12-05T14:41:24Z","updated_at":"2016-12-06T08:10:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5f71f6eff26cc2d09013dbe46d28f342b1e169ca","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/qooxdoo/qooxdoo/pulls/9246/commits","review_comments_url":"https://api.github.com/repos/qooxdoo/qooxdoo/pulls/9246/comments","review_comment_url":"https://api.github.com/repos/qooxdoo/qooxdoo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/qooxdoo/qooxdoo/issues/9246/comments","statuses_url":"https://api.github.com/repos/qooxdoo/qooxdoo/statuses/f5328208b941efb456f100230aeec905aef0cc6d","head":{"label":"cajus:fix-9245","ref":"fix-9245","sha":"f5328208b941efb456f100230aeec905aef0cc6d","user":{"login":"cajus","id":722353,"avatar_url":"https://avatars.githubusercontent.com/u/722353?v=3","gravatar_id":"","url":"https://api.github.com/users/cajus","html_url":"https://github.com/cajus","followers_url":"https://api.github.com/users/cajus/followers","following_url":"https://api.github.com/users/cajus/following{/other_user}","gists_url":"https://api.github.com/users/cajus/gists{/gist_id}","starred_url":"https://api.github.com/users/cajus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cajus/subscriptions","organizations_url":"https://api.github.com/users/cajus/orgs","repos_url":"https://api.github.com/users/cajus/repos","events_url":"https://api.github.com/users/cajus/events{/privacy}","received_events_url":"https://api.github.com/users/cajus/received_events","type":"User","site_admin":false},"repo":{"id":55986488,"name":"qooxdoo","full_name":"cajus/qooxdoo","owner":{"login":"cajus","id":722353,"avatar_url":"https://avatars.githubusercontent.com/u/722353?v=3","gravatar_id":"","url":"https://api.github.com/users/cajus","html_url":"https://github.com/cajus","followers_url":"https://api.github.com/users/cajus/followers","following_url":"https://api.github.com/users/cajus/following{/other_user}","gists_url":"https://api.github.com/users/cajus/gists{/gist_id}","starred_url":"https://api.github.com/users/cajus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cajus/subscriptions","organizations_url":"https://api.github.com/users/cajus/orgs","repos_url":"https://api.github.com/users/cajus/repos","events_url":"https://api.github.com/users/cajus/events{/privacy}","received_events_url":"https://api.github.com/users/cajus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cajus/qooxdoo","description":"qooxdoo - Universal JavaScript Framework","fork":true,"url":"https://api.github.com/repos/cajus/qooxdoo","forks_url":"https://api.github.com/repos/cajus/qooxdoo/forks","keys_url":"https://api.github.com/repos/cajus/qooxdoo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cajus/qooxdoo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cajus/qooxdoo/teams","hooks_url":"https://api.github.com/repos/cajus/qooxdoo/hooks","issue_events_url":"https://api.github.com/repos/cajus/qooxdoo/issues/events{/number}","events_url":"https://api.github.com/repos/cajus/qooxdoo/events","assignees_url":"https://api.github.com/repos/cajus/qooxdoo/assignees{/user}","branches_url":"https://api.github.com/repos/cajus/qooxdoo/branches{/branch}","tags_url":"https://api.github.com/repos/cajus/qooxdoo/tags","blobs_url":"https://api.github.com/repos/cajus/qooxdoo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cajus/qooxdoo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cajus/qooxdoo/git/refs{/sha}","trees_url":"https://api.github.com/repos/cajus/qooxdoo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cajus/qooxdoo/statuses/{sha}","languages_url":"https://api.github.com/repos/cajus/qooxdoo/languages","stargazers_url":"https://api.github.com/repos/cajus/qooxdoo/stargazers","contributors_url":"https://api.github.com/repos/cajus/qooxdoo/contributors","subscribers_url":"https://api.github.com/repos/cajus/qooxdoo/subscribers","subscription_url":"https://api.github.com/repos/cajus/qooxdoo/subscription","commits_url":"https://api.github.com/repos/cajus/qooxdoo/commits{/sha}","git_commits_url":"https://api.github.com/repos/cajus/qooxdoo/git/commits{/sha}","comments_url":"https://api.github.com/repos/cajus/qooxdoo/comments{/number}","issue_comment_url":"https://api.github.com/repos/cajus/qooxdoo/issues/comments{/number}","contents_url":"https://api.github.com/repos/cajus/qooxdoo/contents/{+path}","compare_url":"https://api.github.com/repos/cajus/qooxdoo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cajus/qooxdoo/merges","archive_url":"https://api.github.com/repos/cajus/qooxdoo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cajus/qooxdoo/downloads","issues_url":"https://api.github.com/repos/cajus/qooxdoo/issues{/number}","pulls_url":"https://api.github.com/repos/cajus/qooxdoo/pulls{/number}","milestones_url":"https://api.github.com/repos/cajus/qooxdoo/milestones{/number}","notifications_url":"https://api.github.com/repos/cajus/qooxdoo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cajus/qooxdoo/labels{/name}","releases_url":"https://api.github.com/repos/cajus/qooxdoo/releases{/id}","deployments_url":"https://api.github.com/repos/cajus/qooxdoo/deployments","created_at":"2016-04-11T15:55:03Z","updated_at":"2016-04-11T15:55:14Z","pushed_at":"2016-12-06T08:04:02Z","git_url":"git://github.com/cajus/qooxdoo.git","ssh_url":"git@github.com:cajus/qooxdoo.git","clone_url":"https://github.com/cajus/qooxdoo.git","svn_url":"https://github.com/cajus/qooxdoo","homepage":"http://qooxdoo.org","size":233713,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"qooxdoo:master","ref":"master","sha":"7d9aadcc79a1f144a52ac1ea8506baf65b4a2370","user":{"login":"qooxdoo","id":105118,"avatar_url":"https://avatars.githubusercontent.com/u/105118?v=3","gravatar_id":"","url":"https://api.github.com/users/qooxdoo","html_url":"https://github.com/qooxdoo","followers_url":"https://api.github.com/users/qooxdoo/followers","following_url":"https://api.github.com/users/qooxdoo/following{/other_user}","gists_url":"https://api.github.com/users/qooxdoo/gists{/gist_id}","starred_url":"https://api.github.com/users/qooxdoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qooxdoo/subscriptions","organizations_url":"https://api.github.com/users/qooxdoo/orgs","repos_url":"https://api.github.com/users/qooxdoo/repos","events_url":"https://api.github.com/users/qooxdoo/events{/privacy}","received_events_url":"https://api.github.com/users/qooxdoo/received_events","type":"Organization","site_admin":false},"repo":{"id":548213,"name":"qooxdoo","full_name":"qooxdoo/qooxdoo","owner":{"login":"qooxdoo","id":105118,"avatar_url":"https://avatars.githubusercontent.com/u/105118?v=3","gravatar_id":"","url":"https://api.github.com/users/qooxdoo","html_url":"https://github.com/qooxdoo","followers_url":"https://api.github.com/users/qooxdoo/followers","following_url":"https://api.github.com/users/qooxdoo/following{/other_user}","gists_url":"https://api.github.com/users/qooxdoo/gists{/gist_id}","starred_url":"https://api.github.com/users/qooxdoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qooxdoo/subscriptions","organizations_url":"https://api.github.com/users/qooxdoo/orgs","repos_url":"https://api.github.com/users/qooxdoo/repos","events_url":"https://api.github.com/users/qooxdoo/events{/privacy}","received_events_url":"https://api.github.com/users/qooxdoo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/qooxdoo/qooxdoo","description":"qooxdoo - Universal JavaScript Framework","fork":false,"url":"https://api.github.com/repos/qooxdoo/qooxdoo","forks_url":"https://api.github.com/repos/qooxdoo/qooxdoo/forks","keys_url":"https://api.github.com/repos/qooxdoo/qooxdoo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qooxdoo/qooxdoo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qooxdoo/qooxdoo/teams","hooks_url":"https://api.github.com/repos/qooxdoo/qooxdoo/hooks","issue_events_url":"https://api.github.com/repos/qooxdoo/qooxdoo/issues/events{/number}","events_url":"https://api.github.com/repos/qooxdoo/qooxdoo/events","assignees_url":"https://api.github.com/repos/qooxdoo/qooxdoo/assignees{/user}","branches_url":"https://api.github.com/repos/qooxdoo/qooxdoo/branches{/branch}","tags_url":"https://api.github.com/repos/qooxdoo/qooxdoo/tags","blobs_url":"https://api.github.com/repos/qooxdoo/qooxdoo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qooxdoo/qooxdoo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qooxdoo/qooxdoo/git/refs{/sha}","trees_url":"https://api.github.com/repos/qooxdoo/qooxdoo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qooxdoo/qooxdoo/statuses/{sha}","languages_url":"https://api.github.com/repos/qooxdoo/qooxdoo/languages","stargazers_url":"https://api.github.com/repos/qooxdoo/qooxdoo/stargazers","contributors_url":"https://api.github.com/repos/qooxdoo/qooxdoo/contributors","subscribers_url":"https://api.github.com/repos/qooxdoo/qooxdoo/subscribers","subscription_url":"https://api.github.com/repos/qooxdoo/qooxdoo/subscription","commits_url":"https://api.github.com/repos/qooxdoo/qooxdoo/commits{/sha}","git_commits_url":"https://api.github.com/repos/qooxdoo/qooxdoo/git/commits{/sha}","comments_url":"https://api.github.com/repos/qooxdoo/qooxdoo/comments{/number}","issue_comment_url":"https://api.github.com/repos/qooxdoo/qooxdoo/issues/comments{/number}","contents_url":"https://api.github.com/repos/qooxdoo/qooxdoo/contents/{+path}","compare_url":"https://api.github.com/repos/qooxdoo/qooxdoo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qooxdoo/qooxdoo/merges","archive_url":"https://api.github.com/repos/qooxdoo/qooxdoo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qooxdoo/qooxdoo/downloads","issues_url":"https://api.github.com/repos/qooxdoo/qooxdoo/issues{/number}","pulls_url":"https://api.github.com/repos/qooxdoo/qooxdoo/pulls{/number}","milestones_url":"https://api.github.com/repos/qooxdoo/qooxdoo/milestones{/number}","notifications_url":"https://api.github.com/repos/qooxdoo/qooxdoo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qooxdoo/qooxdoo/labels{/name}","releases_url":"https://api.github.com/repos/qooxdoo/qooxdoo/releases{/id}","deployments_url":"https://api.github.com/repos/qooxdoo/qooxdoo/deployments","created_at":"2010-03-05T10:01:27Z","updated_at":"2016-12-03T03:46:21Z","pushed_at":"2016-12-06T08:04:02Z","git_url":"git://github.com/qooxdoo/qooxdoo.git","ssh_url":"git@github.com:qooxdoo/qooxdoo.git","clone_url":"https://github.com/qooxdoo/qooxdoo.git","svn_url":"https://github.com/qooxdoo/qooxdoo","homepage":"http://qooxdoo.org","size":268747,"stargazers_count":543,"watchers_count":543,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":193,"mirror_url":null,"open_issues_count":49,"forks":193,"open_issues":49,"watchers":543,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/qooxdoo/qooxdoo/pulls/9246"},"html":{"href":"https://github.com/qooxdoo/qooxdoo/pull/9246"},"issue":{"href":"https://api.github.com/repos/qooxdoo/qooxdoo/issues/9246"},"comments":{"href":"https://api.github.com/repos/qooxdoo/qooxdoo/issues/9246/comments"},"review_comments":{"href":"https://api.github.com/repos/qooxdoo/qooxdoo/pulls/9246/comments"},"review_comment":{"href":"https://api.github.com/repos/qooxdoo/qooxdoo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/qooxdoo/qooxdoo/pulls/9246/commits"},"statuses":{"href":"https://api.github.com/repos/qooxdoo/qooxdoo/statuses/f5328208b941efb456f100230aeec905aef0cc6d"}}}}
{"actor":{"display_login":"cajus"}}