{"action":"created","issue":{"url":"https://api.github.com/repos/hyperledger/fabric/issues/1576","repository_url":"https://api.github.com/repos/hyperledger/fabric","labels_url":"https://api.github.com/repos/hyperledger/fabric/issues/1576/labels{/name}","comments_url":"https://api.github.com/repos/hyperledger/fabric/issues/1576/comments","events_url":"https://api.github.com/repos/hyperledger/fabric/issues/1576/events","html_url":"https://github.com/hyperledger/fabric/pull/1576","id":156654630,"number":1576,"title":"Adding deprecation warning messages for /devops endpoint","user":{"login":"angrbrd","id":14612437,"avatar_url":"https://avatars.githubusercontent.com/u/14612437?v=3","gravatar_id":"","url":"https://api.github.com/users/angrbrd","html_url":"https://github.com/angrbrd","followers_url":"https://api.github.com/users/angrbrd/followers","following_url":"https://api.github.com/users/angrbrd/following{/other_user}","gists_url":"https://api.github.com/users/angrbrd/gists{/gist_id}","starred_url":"https://api.github.com/users/angrbrd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angrbrd/subscriptions","organizations_url":"https://api.github.com/users/angrbrd/orgs","repos_url":"https://api.github.com/users/angrbrd/repos","events_url":"https://api.github.com/users/angrbrd/events{/privacy}","received_events_url":"https://api.github.com/users/angrbrd/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-05-25T03:16:29Z","updated_at":"2016-05-25T18:32:22Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/hyperledger/fabric/pulls/1576","html_url":"https://github.com/hyperledger/fabric/pull/1576","diff_url":"https://github.com/hyperledger/fabric/pull/1576.diff","patch_url":"https://github.com/hyperledger/fabric/pull/1576.patch"},"body":"## Description\r\nAdding three warning level messages that will appear in the peer logs whenever the deprecated /devops endpoint receives a REST request. Specifically, whenever the /devops/deploy, /devops/invoke, or /devops/query endpoints receive a request the below messages will be seen in the logs.\r\n\r\n> [rest] Deploy -> WARN 017 /devops/deploy endpoint has been deprecated. Use /chaincode endpoint instead.\r\n> [rest] Invoke -> WARN 01b /devops/invoke endpoint has been deprecated. Use /chaincode endpoint instead.\r\n> [rest] Query -> WARN 01e /devops/query endpoint has been deprecated. Use /chaincode endpoint instead.\r\n\r\n## Motivation and Context\r\nThis change is necessary to warn users of the REST API that the /devops endpoint is being deprecated and is now superceeded by the /chaincode endpoint. Users should transition to using the /chaincode endpoint as the /devops endpoint will eventually be removed.\r\n\r\nFixes #1101\r\n\r\n## How Has This Been Tested?\r\nI tested this change by sending requests to the /devops/deploy, /devops/invoke, and /devops/query endpoints and confirming that the correct warning messages are seen in the peer logs. This issue does not require new test cases as the code change simply adds new logging messages, not new functionality.\r\n\r\n## Checklist:\r\n- [x] I have added a [Signed-off-by](https://github.com/hyperledger/fabric/blob/master/CONTRIBUTING.md#legal-stuff)\r\n- [x] Either no new documentation is required by this change, OR I added new documentation\r\n- [x] Either no new tests are required by this change, OR I added new tests\r\n- [x] I have run [goimports](https://godoc.org/golang.org/x/tools/cmd/goimports), [go vet](https://golang.org/cmd/vet/), and [golint](https://github.com/golang/lint). I have cleaned up all valid errors and warnings in code I have added or modified. These tools may generate false positives. Don't be worried about ignoring some errors or warnings. The goal is clean, consistent, and readable code.\r\n\r\nAdding a warning message whenever the deprecated /devops endpoint\r\nreceives a REST request.\r\n\r\nFixes #1101.\r\n\r\nSigned-off-by: Anna D Derbakova <adderbak@us.ibm.com>"},"comment":{"url":"https://api.github.com/repos/hyperledger/fabric/issues/comments/221665468","html_url":"https://github.com/hyperledger/fabric/pull/1576#issuecomment-221665468","issue_url":"https://api.github.com/repos/hyperledger/fabric/issues/1576","id":221665468,"user":{"login":"tamasblummer","id":4289351,"avatar_url":"https://avatars.githubusercontent.com/u/4289351?v=3","gravatar_id":"","url":"https://api.github.com/users/tamasblummer","html_url":"https://github.com/tamasblummer","followers_url":"https://api.github.com/users/tamasblummer/followers","following_url":"https://api.github.com/users/tamasblummer/following{/other_user}","gists_url":"https://api.github.com/users/tamasblummer/gists{/gist_id}","starred_url":"https://api.github.com/users/tamasblummer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tamasblummer/subscriptions","organizations_url":"https://api.github.com/users/tamasblummer/orgs","repos_url":"https://api.github.com/users/tamasblummer/repos","events_url":"https://api.github.com/users/tamasblummer/events{/privacy}","received_events_url":"https://api.github.com/users/tamasblummer/received_events","type":"User","site_admin":false},"created_at":"2016-05-25T18:32:22Z","updated_at":"2016-05-25T18:32:22Z","body":"fabric-api has, but awaits implementation.\n\n    /**\n     * retrieves client version\n     *\n     * @return client version e.g. 4.0.0\n     */\n    String getClientVersion() throws HLAPIException;\n\n    /**\n     * retrieves server version\n     *\n     * @return server version e.g. 4.0.0\n     */\n    String getServerVersion() throws HLAPIException;\n\nTamas Blummer\nCHIEF LEDGER ARCHITECT\n\n\n\n\nT: +36 1 883 0300 \nE: tamas@digitalasset.com <mailto:address@digitalasset.com> | W: digitalasset.com <http://www.digitalasset.com/>\n> On 25 May 2016, at 19:34, Christopher Ferris <notifications@github.com> wrote:\n> \n> not that it needs to be addressed here and now, but we really should be considering some mechanism that a client can express the version of an API that it is expecting and that the API endpoint can respond back with some sort of compatibility expression. What I am suggesting is that we need more than some obscure log warning to manage versioning of the APIs and clients/SDKs that consume them. @srderson <https://github.com/srderson> @binhn <https://github.com/binhn> @ghaskins <https://github.com/ghaskins> @tamasblummer <https://github.com/tamasblummer>\n> —\n> You are receiving this because you were mentioned.\n> Reply to this email directly or view it on GitHub <https://github.com/hyperledger/fabric/pull/1576#issuecomment-221646878>\n\n\n-- \nThis message, and any attachments, is for the intended recipient(s) only, \nmay contain information that is privileged, confidential and/or proprietary \nand subject to important terms and conditions available at \nhttp://www.digitalasset.com/emaildisclaimer.html. If you are not the \nintended recipient, please delete this message.\n"}}
{"actor":{"display_login":"tamasblummer"}}