{"action":"closed","number":874,"pull_request":{"url":"https://api.github.com/repos/btcsuite/btcd/pulls/874","id":96389904,"html_url":"https://github.com/btcsuite/btcd/pull/874","diff_url":"https://github.com/btcsuite/btcd/pull/874.diff","patch_url":"https://github.com/btcsuite/btcd/pull/874.patch","issue_url":"https://api.github.com/repos/btcsuite/btcd/issues/874","number":874,"state":"closed","locked":false,"title":"txscript: Only do CSV txver check if enabled.","user":{"login":"davecgh","id":2115102,"avatar_url":"https://avatars.githubusercontent.com/u/2115102?v=3","gravatar_id":"","url":"https://api.github.com/users/davecgh","html_url":"https://github.com/davecgh","followers_url":"https://api.github.com/users/davecgh/followers","following_url":"https://api.github.com/users/davecgh/following{/other_user}","gists_url":"https://api.github.com/users/davecgh/gists{/gist_id}","starred_url":"https://api.github.com/users/davecgh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davecgh/subscriptions","organizations_url":"https://api.github.com/users/davecgh/orgs","repos_url":"https://api.github.com/users/davecgh/repos","events_url":"https://api.github.com/users/davecgh/events{/privacy}","received_events_url":"https://api.github.com/users/davecgh/received_events","type":"User","site_admin":false},"body":"The CSV consensus rules dictate that the opcode fails when the transaction version is not at least version 2, however that only applies if the disable flag is not set in the sequence.\r\n\r\nThis is not an issue at the current time because we do not yet enforce CSV at a consensus level, however, I noticed this discrepancy when doing a thorough audit of the CSV paths due to the ongoing work to add full\r\nconsensus-enforced CSV support.\r\n\r\nAs a result, this must be merged prior to enabling consensus enforcement for CSV or it would open up the potential for a hard fork.","created_at":"2016-12-03T07:22:39Z","updated_at":"2016-12-03T19:27:12Z","closed_at":"2016-12-03T19:27:12Z","merged_at":"2016-12-03T19:27:12Z","merge_commit_sha":"bc576b13b4d3abd1df98f35fc7d30e9500048b7b","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/btcsuite/btcd/milestones/1","html_url":"https://github.com/btcsuite/btcd/milestones/0.13.0","labels_url":"https://api.github.com/repos/btcsuite/btcd/milestones/1/labels","id":2087437,"number":1,"title":"0.13.0","description":"Release 0.1.3.0","creator":{"login":"dajohi","id":3308193,"avatar_url":"https://avatars.githubusercontent.com/u/3308193?v=3","gravatar_id":"","url":"https://api.github.com/users/dajohi","html_url":"https://github.com/dajohi","followers_url":"https://api.github.com/users/dajohi/followers","following_url":"https://api.github.com/users/dajohi/following{/other_user}","gists_url":"https://api.github.com/users/dajohi/gists{/gist_id}","starred_url":"https://api.github.com/users/dajohi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dajohi/subscriptions","organizations_url":"https://api.github.com/users/dajohi/orgs","repos_url":"https://api.github.com/users/dajohi/repos","events_url":"https://api.github.com/users/dajohi/events{/privacy}","received_events_url":"https://api.github.com/users/dajohi/received_events","type":"User","site_admin":false},"open_issues":21,"closed_issues":87,"state":"open","created_at":"2016-10-23T17:50:30Z","updated_at":"2016-12-03T19:27:12Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/btcsuite/btcd/pulls/874/commits","review_comments_url":"https://api.github.com/repos/btcsuite/btcd/pulls/874/comments","review_comment_url":"https://api.github.com/repos/btcsuite/btcd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/btcsuite/btcd/issues/874/comments","statuses_url":"https://api.github.com/repos/btcsuite/btcd/statuses/bc576b13b4d3abd1df98f35fc7d30e9500048b7b","head":{"label":"davecgh:txscript_csv_tx_version_check","ref":"txscript_csv_tx_version_check","sha":"bc576b13b4d3abd1df98f35fc7d30e9500048b7b","user":{"login":"davecgh","id":2115102,"avatar_url":"https://avatars.githubusercontent.com/u/2115102?v=3","gravatar_id":"","url":"https://api.github.com/users/davecgh","html_url":"https://github.com/davecgh","followers_url":"https://api.github.com/users/davecgh/followers","following_url":"https://api.github.com/users/davecgh/following{/other_user}","gists_url":"https://api.github.com/users/davecgh/gists{/gist_id}","starred_url":"https://api.github.com/users/davecgh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davecgh/subscriptions","organizations_url":"https://api.github.com/users/davecgh/orgs","repos_url":"https://api.github.com/users/davecgh/repos","events_url":"https://api.github.com/users/davecgh/events{/privacy}","received_events_url":"https://api.github.com/users/davecgh/received_events","type":"User","site_admin":false},"repo":{"id":16972952,"name":"btcd","full_name":"davecgh/btcd","owner":{"login":"davecgh","id":2115102,"avatar_url":"https://avatars.githubusercontent.com/u/2115102?v=3","gravatar_id":"","url":"https://api.github.com/users/davecgh","html_url":"https://github.com/davecgh","followers_url":"https://api.github.com/users/davecgh/followers","following_url":"https://api.github.com/users/davecgh/following{/other_user}","gists_url":"https://api.github.com/users/davecgh/gists{/gist_id}","starred_url":"https://api.github.com/users/davecgh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davecgh/subscriptions","organizations_url":"https://api.github.com/users/davecgh/orgs","repos_url":"https://api.github.com/users/davecgh/repos","events_url":"https://api.github.com/users/davecgh/events{/privacy}","received_events_url":"https://api.github.com/users/davecgh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/davecgh/btcd","description":"An alternative full node bitcoin implementation written in Go (golang)","fork":true,"url":"https://api.github.com/repos/davecgh/btcd","forks_url":"https://api.github.com/repos/davecgh/btcd/forks","keys_url":"https://api.github.com/repos/davecgh/btcd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/davecgh/btcd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/davecgh/btcd/teams","hooks_url":"https://api.github.com/repos/davecgh/btcd/hooks","issue_events_url":"https://api.github.com/repos/davecgh/btcd/issues/events{/number}","events_url":"https://api.github.com/repos/davecgh/btcd/events","assignees_url":"https://api.github.com/repos/davecgh/btcd/assignees{/user}","branches_url":"https://api.github.com/repos/davecgh/btcd/branches{/branch}","tags_url":"https://api.github.com/repos/davecgh/btcd/tags","blobs_url":"https://api.github.com/repos/davecgh/btcd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/davecgh/btcd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/davecgh/btcd/git/refs{/sha}","trees_url":"https://api.github.com/repos/davecgh/btcd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/davecgh/btcd/statuses/{sha}","languages_url":"https://api.github.com/repos/davecgh/btcd/languages","stargazers_url":"https://api.github.com/repos/davecgh/btcd/stargazers","contributors_url":"https://api.github.com/repos/davecgh/btcd/contributors","subscribers_url":"https://api.github.com/repos/davecgh/btcd/subscribers","subscription_url":"https://api.github.com/repos/davecgh/btcd/subscription","commits_url":"https://api.github.com/repos/davecgh/btcd/commits{/sha}","git_commits_url":"https://api.github.com/repos/davecgh/btcd/git/commits{/sha}","comments_url":"https://api.github.com/repos/davecgh/btcd/comments{/number}","issue_comment_url":"https://api.github.com/repos/davecgh/btcd/issues/comments{/number}","contents_url":"https://api.github.com/repos/davecgh/btcd/contents/{+path}","compare_url":"https://api.github.com/repos/davecgh/btcd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/davecgh/btcd/merges","archive_url":"https://api.github.com/repos/davecgh/btcd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/davecgh/btcd/downloads","issues_url":"https://api.github.com/repos/davecgh/btcd/issues{/number}","pulls_url":"https://api.github.com/repos/davecgh/btcd/pulls{/number}","milestones_url":"https://api.github.com/repos/davecgh/btcd/milestones{/number}","notifications_url":"https://api.github.com/repos/davecgh/btcd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/davecgh/btcd/labels{/name}","releases_url":"https://api.github.com/repos/davecgh/btcd/releases{/id}","deployments_url":"https://api.github.com/repos/davecgh/btcd/deployments","created_at":"2014-02-19T03:45:51Z","updated_at":"2015-04-21T20:13:13Z","pushed_at":"2016-12-03T18:34:14Z","git_url":"git://github.com/davecgh/btcd.git","ssh_url":"git@github.com:davecgh/btcd.git","clone_url":"https://github.com/davecgh/btcd.git","svn_url":"https://github.com/davecgh/btcd","homepage":null,"size":19571,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"btcsuite:master","ref":"master","sha":"318c4760c02d494542d0b7ea9b636351a99fe458","user":{"login":"btcsuite","id":10235229,"avatar_url":"https://avatars.githubusercontent.com/u/10235229?v=3","gravatar_id":"","url":"https://api.github.com/users/btcsuite","html_url":"https://github.com/btcsuite","followers_url":"https://api.github.com/users/btcsuite/followers","following_url":"https://api.github.com/users/btcsuite/following{/other_user}","gists_url":"https://api.github.com/users/btcsuite/gists{/gist_id}","starred_url":"https://api.github.com/users/btcsuite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/btcsuite/subscriptions","organizations_url":"https://api.github.com/users/btcsuite/orgs","repos_url":"https://api.github.com/users/btcsuite/repos","events_url":"https://api.github.com/users/btcsuite/events{/privacy}","received_events_url":"https://api.github.com/users/btcsuite/received_events","type":"Organization","site_admin":false},"repo":{"id":11931032,"name":"btcd","full_name":"btcsuite/btcd","owner":{"login":"btcsuite","id":10235229,"avatar_url":"https://avatars.githubusercontent.com/u/10235229?v=3","gravatar_id":"","url":"https://api.github.com/users/btcsuite","html_url":"https://github.com/btcsuite","followers_url":"https://api.github.com/users/btcsuite/followers","following_url":"https://api.github.com/users/btcsuite/following{/other_user}","gists_url":"https://api.github.com/users/btcsuite/gists{/gist_id}","starred_url":"https://api.github.com/users/btcsuite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/btcsuite/subscriptions","organizations_url":"https://api.github.com/users/btcsuite/orgs","repos_url":"https://api.github.com/users/btcsuite/repos","events_url":"https://api.github.com/users/btcsuite/events{/privacy}","received_events_url":"https://api.github.com/users/btcsuite/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/btcsuite/btcd","description":"An alternative full node bitcoin implementation written in Go (golang)","fork":false,"url":"https://api.github.com/repos/btcsuite/btcd","forks_url":"https://api.github.com/repos/btcsuite/btcd/forks","keys_url":"https://api.github.com/repos/btcsuite/btcd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/btcsuite/btcd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/btcsuite/btcd/teams","hooks_url":"https://api.github.com/repos/btcsuite/btcd/hooks","issue_events_url":"https://api.github.com/repos/btcsuite/btcd/issues/events{/number}","events_url":"https://api.github.com/repos/btcsuite/btcd/events","assignees_url":"https://api.github.com/repos/btcsuite/btcd/assignees{/user}","branches_url":"https://api.github.com/repos/btcsuite/btcd/branches{/branch}","tags_url":"https://api.github.com/repos/btcsuite/btcd/tags","blobs_url":"https://api.github.com/repos/btcsuite/btcd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/btcsuite/btcd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/btcsuite/btcd/git/refs{/sha}","trees_url":"https://api.github.com/repos/btcsuite/btcd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/btcsuite/btcd/statuses/{sha}","languages_url":"https://api.github.com/repos/btcsuite/btcd/languages","stargazers_url":"https://api.github.com/repos/btcsuite/btcd/stargazers","contributors_url":"https://api.github.com/repos/btcsuite/btcd/contributors","subscribers_url":"https://api.github.com/repos/btcsuite/btcd/subscribers","subscription_url":"https://api.github.com/repos/btcsuite/btcd/subscription","commits_url":"https://api.github.com/repos/btcsuite/btcd/commits{/sha}","git_commits_url":"https://api.github.com/repos/btcsuite/btcd/git/commits{/sha}","comments_url":"https://api.github.com/repos/btcsuite/btcd/comments{/number}","issue_comment_url":"https://api.github.com/repos/btcsuite/btcd/issues/comments{/number}","contents_url":"https://api.github.com/repos/btcsuite/btcd/contents/{+path}","compare_url":"https://api.github.com/repos/btcsuite/btcd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/btcsuite/btcd/merges","archive_url":"https://api.github.com/repos/btcsuite/btcd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/btcsuite/btcd/downloads","issues_url":"https://api.github.com/repos/btcsuite/btcd/issues{/number}","pulls_url":"https://api.github.com/repos/btcsuite/btcd/pulls{/number}","milestones_url":"https://api.github.com/repos/btcsuite/btcd/milestones{/number}","notifications_url":"https://api.github.com/repos/btcsuite/btcd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/btcsuite/btcd/labels{/name}","releases_url":"https://api.github.com/repos/btcsuite/btcd/releases{/id}","deployments_url":"https://api.github.com/repos/btcsuite/btcd/deployments","created_at":"2013-08-06T18:10:52Z","updated_at":"2016-12-01T11:29:33Z","pushed_at":"2016-12-03T19:27:11Z","git_url":"git://github.com/btcsuite/btcd.git","ssh_url":"git@github.com:btcsuite/btcd.git","clone_url":"https://github.com/btcsuite/btcd.git","svn_url":"https://github.com/btcsuite/btcd","homepage":"https://github.com/btcsuite/btcd/blob/master/docs/README.md","size":18685,"stargazers_count":991,"watchers_count":991,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":277,"mirror_url":null,"open_issues_count":60,"forks":277,"open_issues":60,"watchers":991,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/btcsuite/btcd/pulls/874"},"html":{"href":"https://github.com/btcsuite/btcd/pull/874"},"issue":{"href":"https://api.github.com/repos/btcsuite/btcd/issues/874"},"comments":{"href":"https://api.github.com/repos/btcsuite/btcd/issues/874/comments"},"review_comments":{"href":"https://api.github.com/repos/btcsuite/btcd/pulls/874/comments"},"review_comment":{"href":"https://api.github.com/repos/btcsuite/btcd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/btcsuite/btcd/pulls/874/commits"},"statuses":{"href":"https://api.github.com/repos/btcsuite/btcd/statuses/bc576b13b4d3abd1df98f35fc7d30e9500048b7b"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"davecgh","id":2115102,"avatar_url":"https://avatars.githubusercontent.com/u/2115102?v=3","gravatar_id":"","url":"https://api.github.com/users/davecgh","html_url":"https://github.com/davecgh","followers_url":"https://api.github.com/users/davecgh/followers","following_url":"https://api.github.com/users/davecgh/following{/other_user}","gists_url":"https://api.github.com/users/davecgh/gists{/gist_id}","starred_url":"https://api.github.com/users/davecgh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davecgh/subscriptions","organizations_url":"https://api.github.com/users/davecgh/orgs","repos_url":"https://api.github.com/users/davecgh/repos","events_url":"https://api.github.com/users/davecgh/events{/privacy}","received_events_url":"https://api.github.com/users/davecgh/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":7,"deletions":5,"changed_files":1}}
{"actor":{"display_login":"davecgh"}}