{"action":"created","issue":{"url":"https://api.github.com/repos/phetsims/chipper/issues/500","repository_url":"https://api.github.com/repos/phetsims/chipper","labels_url":"https://api.github.com/repos/phetsims/chipper/issues/500/labels{/name}","comments_url":"https://api.github.com/repos/phetsims/chipper/issues/500/comments","events_url":"https://api.github.com/repos/phetsims/chipper/issues/500/events","html_url":"https://github.com/phetsims/chipper/issues/500","id":179539721,"number":500,"title":"SyntaxError: Use of const in strict mode.","user":{"login":"samreid","id":679486,"avatar_url":"https://avatars.githubusercontent.com/u/679486?v=3","gravatar_id":"","url":"https://api.github.com/users/samreid","html_url":"https://github.com/samreid","followers_url":"https://api.github.com/users/samreid/followers","following_url":"https://api.github.com/users/samreid/following{/other_user}","gists_url":"https://api.github.com/users/samreid/gists{/gist_id}","starred_url":"https://api.github.com/users/samreid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samreid/subscriptions","organizations_url":"https://api.github.com/users/samreid/orgs","repos_url":"https://api.github.com/users/samreid/repos","events_url":"https://api.github.com/users/samreid/events{/privacy}","received_events_url":"https://api.github.com/users/samreid/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"mattpen","id":11747676,"avatar_url":"https://avatars.githubusercontent.com/u/11747676?v=3","gravatar_id":"","url":"https://api.github.com/users/mattpen","html_url":"https://github.com/mattpen","followers_url":"https://api.github.com/users/mattpen/followers","following_url":"https://api.github.com/users/mattpen/following{/other_user}","gists_url":"https://api.github.com/users/mattpen/gists{/gist_id}","starred_url":"https://api.github.com/users/mattpen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattpen/subscriptions","organizations_url":"https://api.github.com/users/mattpen/orgs","repos_url":"https://api.github.com/users/mattpen/repos","events_url":"https://api.github.com/users/mattpen/events{/privacy}","received_events_url":"https://api.github.com/users/mattpen/received_events","type":"User","site_admin":false},"assignees":[{"login":"mattpen","id":11747676,"avatar_url":"https://avatars.githubusercontent.com/u/11747676?v=3","gravatar_id":"","url":"https://api.github.com/users/mattpen","html_url":"https://github.com/mattpen","followers_url":"https://api.github.com/users/mattpen/followers","following_url":"https://api.github.com/users/mattpen/following{/other_user}","gists_url":"https://api.github.com/users/mattpen/gists{/gist_id}","starred_url":"https://api.github.com/users/mattpen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattpen/subscriptions","organizations_url":"https://api.github.com/users/mattpen/orgs","repos_url":"https://api.github.com/users/mattpen/repos","events_url":"https://api.github.com/users/mattpen/events{/privacy}","received_events_url":"https://api.github.com/users/mattpen/received_events","type":"User","site_admin":false}],"milestone":null,"comments":9,"created_at":"2016-09-27T16:11:38Z","updated_at":"2016-09-28T03:50:23Z","closed_at":null,"body":"Yesterday @jonathanolson identified that one of our new dependencies requires a newer node/npm than the one he previously had.\r\n\r\nHere are my npm/node versions which are known to work:\r\n```\r\n[9/26/16, 12:39:11 PM] Sam Reid: ~/github/molecule-shapes$ npm --version\r\n3.10.7\r\n[9/26/16, 12:39:18 PM] Sam Reid: ~/github/molecule-shapes$ node --version\r\nv4.2.1\r\n```\r\n\r\nHere are @jonathanolson node/npm versions which are known to not work:\r\n```\r\n:~/phet/git/molecule-shapes # npm --version\r\n1.4.9\r\n:~/phet/git/molecule-shapes # node --version\r\nv0.10.28\r\n```\r\n\r\nHere is our transcript:\r\n\r\n[9/26/16, 12:33:15 PM] Jonathan Olson: btw, am I missing some lint commits from dot/kite related to extra break statements? I don't mind fixing them at all, just grunt lint is failing out for a sim\r\n[9/26/16, 12:33:34 PM] Jonathan Olson: my apologies if somehow my repos aren't up to date, but I did pull everything\r\n[9/26/16, 12:33:35 PM] Sam Reid: which sim?\r\n[9/26/16, 12:33:41 PM] Jonathan Olson: molecule-shapes was the one I tested\r\n[9/26/16, 12:33:45 PM] Sam Reid: testing...\r\n[9/26/16, 12:35:09 PM] Sam Reid: what is your eslint version?\r\n[9/26/16, 12:35:25 PM] Jonathan Olson: bah, let me wipe node_modules\r\n[9/26/16, 12:37:07 PM] Jonathan Olson: not sure how to tell, but now:\r\n\r\n/Users/jon/phet/git/molecule-shapes/node_modules/grunt-eslint/tasks/eslint.js:2\r\nconst chalk = require('chalk');\r\n^^^^^\r\nLoading \"eslint.js\" tasks...ERROR\r\n>> SyntaxError: Use of const in strict mode.\r\nWarning: Task \"eslint:allFiles\" not found. Use --force to continue.\r\n\r\nAborted due to warnings.\r\n[9/26/16, 12:37:26 PM] Sam Reid: You got some ES6 code in there?\r\n[9/26/16, 12:37:36 PM] Jonathan Olson: wiped chipper and molecule-shapes' node_modules and re-npm-installed\r\n[9/26/16, 12:37:40 PM] Jonathan Olson: I dont think so\r\n[9/26/16, 12:38:04 PM] Jonathan Olson: is my node itself too old or something?\r\n[9/26/16, 12:38:16 PM] Sam Reid: I’m not sure what the trouble is.  Can you Skype me the lint errors?\r\n[9/26/16, 12:38:26 PM] Jonathan Olson: that's now the only error (that it shows)\r\n[9/26/16, 12:38:45 PM] Sam Reid: > related to extra break statements?\r\n[9/26/16, 12:38:51 PM] Sam Reid: oh I see\r\n[9/26/16, 12:38:55 PM] Jonathan Olson: those went away when I wiped node_modules\r\n[9/26/16, 12:38:59 PM] Jonathan Olson: replaced by just that error\r\n[9/26/16, 12:39:11 PM] Sam Reid: ~/github/molecule-shapes$ npm --version\r\n3.10.7\r\n[9/26/16, 12:39:18 PM] Sam Reid: ~/github/molecule-shapes$ node --version\r\nv4.2.1\r\n[9/26/16, 12:39:23 PM] Jonathan Olson: silver:~/phet/git/molecule-shapes # npm --version\r\n1.4.9\r\nsilver:~/phet/git/molecule-shapes # node --version\r\nv0.10.28\r\nsilver:~/phet/git/molecule-shapes #\r\n[9/26/16, 12:39:56 PM] Jonathan Olson: I'll look into updating then\r\n[9/26/16, 12:40:00 PM] Sam Reid: ~/github/molecule-shapes$ node node_modules/eslint/bin/eslint.js --version\r\nv3.6.0\r\n[9/26/16, 12:40:17 PM] Sam Reid: That may help if you have a node that is too old for const.\r\n[9/26/16, 12:40:38 PM] Jonathan Olson: Error: Cannot find module '/Users/jon/phet/git/molecule-shapes/node_modules/eslint/bin/eslint.js'\r\n[9/26/16, 12:40:43 PM] Jonathan Olson: file doesn't exist\r\n[9/26/16, 12:40:49 PM] Jonathan Olson: no node_modules/eslint\r\n[9/26/16, 12:40:53 PM] Sam Reid: hmmm\r\n[9/26/16, 12:41:00 PM] Jonathan Olson: package.json doesn't mention it\r\n[9/26/16, 12:41:12 PM] Sam Reid: it is a dependency of grunt-eslint\r\n[9/26/16, 12:41:26 PM] Jonathan Olson: which would be nested under grunt-eslint/node_modules in my version of node\r\n[9/26/16, 12:41:35 PM] Sam Reid: ah I see… checking...\r\n[9/26/16, 12:42:00 PM] Jonathan Olson: found the file\r\n[9/26/16, 12:42:01 PM] Jonathan Olson: silver:~/phet/git/molecule-shapes # node node_modules/grunt-eslint/node_modules/eslint/bin/eslint.js --version\r\n\r\n/Users/jon/phet/git/molecule-shapes/node_modules/grunt-eslint/node_modules/eslint/lib/cli.js:18\r\nconst fs = require(\"fs\"),\r\n^^^^^\r\nSyntaxError: Use of const in strict mode.\r\n    at Module._compile (module.js:439:25)\r\n    at Object.Module._extensions..js (module.js:474:10)\r\n    at Module.load (module.js:356:32)\r\n    at Function.Module._load (module.js:312:12)\r\n    at Module.require (module.js:364:17)\r\n    at require (module.js:380:17)\r\n    at Object.<anonymous> (/Users/jon/phet/git/molecule-shapes/node_modules/grunt-eslint/node_modules/eslint/bin/eslint.js:29:11)\r\n    at Module._compile (module.js:456:26)\r\n    at Object.Module._extensions..js (module.js:474:10)\r\n    at Module.load (module.js:356:32)\r\n[9/26/16, 12:42:12 PM] Jonathan Olson: ok, so I'll look into upgrading node/npm\r\n[9/26/16, 12:42:19 PM] Jonathan Olson: presumably should fix it\r\n[9/26/16, 12:42:20 PM] Jonathan Olson: thanks!\r\n[9/26/16, 12:42:22 PM] Sam Reid: I hope so!"},"comment":{"url":"https://api.github.com/repos/phetsims/chipper/issues/comments/250065018","html_url":"https://github.com/phetsims/chipper/issues/500#issuecomment-250065018","issue_url":"https://api.github.com/repos/phetsims/chipper/issues/500","id":250065018,"user":{"login":"mattpen","id":11747676,"avatar_url":"https://avatars.githubusercontent.com/u/11747676?v=3","gravatar_id":"","url":"https://api.github.com/users/mattpen","html_url":"https://github.com/mattpen","followers_url":"https://api.github.com/users/mattpen/followers","following_url":"https://api.github.com/users/mattpen/following{/other_user}","gists_url":"https://api.github.com/users/mattpen/gists{/gist_id}","starred_url":"https://api.github.com/users/mattpen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattpen/subscriptions","organizations_url":"https://api.github.com/users/mattpen/orgs","repos_url":"https://api.github.com/users/mattpen/repos","events_url":"https://api.github.com/users/mattpen/events{/privacy}","received_events_url":"https://api.github.com/users/mattpen/received_events","type":"User","site_admin":false},"created_at":"2016-09-28T03:50:23Z","updated_at":"2016-09-28T03:50:23Z","body":"```\r\n[root@phet-server perennial]# node --version\r\nv4.5.0\r\n[root@phet-server perennial]# npm --version\r\n2.15.9\r\n```\r\n\r\nnode/npm were updated on phet-server and phet-server-dev tonight, and I restarted rosetta and build-server afterwards without error.  The servers were previously running node v0.10.X, but v4.X.X should be backwards compatible."}}
{"actor":{"display_login":"mattpen"}}