{"action":"created","issue":{"url":"https://api.github.com/repos/mila-udem/blocks/issues/877","labels_url":"https://api.github.com/repos/mila-udem/blocks/issues/877/labels{/name}","comments_url":"https://api.github.com/repos/mila-udem/blocks/issues/877/comments","events_url":"https://api.github.com/repos/mila-udem/blocks/issues/877/events","html_url":"https://github.com/mila-udem/blocks/pull/877","id":112654403,"number":877,"title":"WIP: New serialization","user":{"login":"Thrandis","id":10479248,"avatar_url":"https://avatars.githubusercontent.com/u/10479248?v=3","gravatar_id":"","url":"https://api.github.com/users/Thrandis","html_url":"https://github.com/Thrandis","followers_url":"https://api.github.com/users/Thrandis/followers","following_url":"https://api.github.com/users/Thrandis/following{/other_user}","gists_url":"https://api.github.com/users/Thrandis/gists{/gist_id}","starred_url":"https://api.github.com/users/Thrandis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Thrandis/subscriptions","organizations_url":"https://api.github.com/users/Thrandis/orgs","repos_url":"https://api.github.com/users/Thrandis/repos","events_url":"https://api.github.com/users/Thrandis/events{/privacy}","received_events_url":"https://api.github.com/users/Thrandis/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2015-10-21T18:47:56Z","updated_at":"2016-01-15T15:51:09Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mila-udem/blocks/pulls/877","html_url":"https://github.com/mila-udem/blocks/pull/877","diff_url":"https://github.com/mila-udem/blocks/pull/877.diff","patch_url":"https://github.com/mila-udem/blocks/pull/877.patch"},"body":"(Fixes #829)\r\n\r\nRegarding the previous todo list:\r\n\r\n- [x] documentation is missing for many functions\r\n- [x] handle usual shared variables (not created by bricks)\r\n- [x] handle shared variables without names\r\n- [x] handle variables with duplicate names\r\n- [x] support CUDA\r\n\r\nWhat I still need to do:\r\n\r\n- [ ] write the tests\r\n- [ ] complete the docstring\r\n- [x] fix the hack in add_to_dump\r\n- [x] add the protocol to pickle\r\n\r\nFinally, when we move to the current blocks version:\r\n\r\n- [ ] adapt existing interface\r\n- [ ] adapt the tempdir\r\n\r\nFinally, I don't really like the name `parameters`, because it is not general enough. It is true that in practice we will use it to save the parameters of our models separately, but I think it would be better to use something like `separated_parts` and `separated_shared_variables`. The name is long though."},"comment":{"url":"https://api.github.com/repos/mila-udem/blocks/issues/comments/171997318","html_url":"https://github.com/mila-udem/blocks/pull/877#issuecomment-171997318","issue_url":"https://api.github.com/repos/mila-udem/blocks/issues/877","id":171997318,"user":{"login":"Thrandis","id":10479248,"avatar_url":"https://avatars.githubusercontent.com/u/10479248?v=3","gravatar_id":"","url":"https://api.github.com/users/Thrandis","html_url":"https://github.com/Thrandis","followers_url":"https://api.github.com/users/Thrandis/followers","following_url":"https://api.github.com/users/Thrandis/following{/other_user}","gists_url":"https://api.github.com/users/Thrandis/gists{/gist_id}","starred_url":"https://api.github.com/users/Thrandis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Thrandis/subscriptions","organizations_url":"https://api.github.com/users/Thrandis/orgs","repos_url":"https://api.github.com/users/Thrandis/repos","events_url":"https://api.github.com/users/Thrandis/events{/privacy}","received_events_url":"https://api.github.com/users/Thrandis/received_events","type":"User","site_admin":false},"created_at":"2016-01-15T15:51:09Z","updated_at":"2016-01-15T15:51:09Z","body":"@rizar I fixed the naming issues and the bug in `add_to_dump` using your proposed trick!"}}