{"action":"opened","number":5,"pull_request":{"url":"https://api.github.com/repos/mandy-kate/mixBank/pulls/5","id":83362856,"html_url":"https://github.com/mandy-kate/mixBank/pull/5","diff_url":"https://github.com/mandy-kate/mixBank/pull/5.diff","patch_url":"https://github.com/mandy-kate/mixBank/pull/5.patch","issue_url":"https://api.github.com/repos/mandy-kate/mixBank/issues/5","number":5,"state":"open","locked":false,"title":"Comments and tidy up.","user":{"login":"pietgeursen","id":10556538,"avatar_url":"https://avatars.githubusercontent.com/u/10556538?v=3","gravatar_id":"","url":"https://api.github.com/users/pietgeursen","html_url":"https://github.com/pietgeursen","followers_url":"https://api.github.com/users/pietgeursen/followers","following_url":"https://api.github.com/users/pietgeursen/following{/other_user}","gists_url":"https://api.github.com/users/pietgeursen/gists{/gist_id}","starred_url":"https://api.github.com/users/pietgeursen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pietgeursen/subscriptions","organizations_url":"https://api.github.com/users/pietgeursen/orgs","repos_url":"https://api.github.com/users/pietgeursen/repos","events_url":"https://api.github.com/users/pietgeursen/events{/privacy}","received_events_url":"https://api.github.com/users/pietgeursen/received_events","type":"User","site_admin":false},"body":"# Thoughts\r\n- Add db setup steps to the readme (knex migrate and seed are needed to pass tests)\r\n- Remove console.log from app.js:14\r\n- Project structure mushes the server and the client code together. Bare minimum consider a client folder and have all the client code in there. \r\n- This PR has merge conflicts and can't be merged. You need to fix that.\r\n- You don't have redux set up at all. That's a priority!\r\n- getTransactionsForAccount in queries hard codes the id. Write a test that will fail because of this, THEN fix it.","created_at":"2016-08-30T23:05:00Z","updated_at":"2016-08-30T23:05:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mandy-kate/mixBank/pulls/5/commits","review_comments_url":"https://api.github.com/repos/mandy-kate/mixBank/pulls/5/comments","review_comment_url":"https://api.github.com/repos/mandy-kate/mixBank/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mandy-kate/mixBank/issues/5/comments","statuses_url":"https://api.github.com/repos/mandy-kate/mixBank/statuses/12e124cb57a41bd9b66f7cbefcc655672f32796b","head":{"label":"pietgeursen:testing","ref":"testing","sha":"12e124cb57a41bd9b66f7cbefcc655672f32796b","user":{"login":"pietgeursen","id":10556538,"avatar_url":"https://avatars.githubusercontent.com/u/10556538?v=3","gravatar_id":"","url":"https://api.github.com/users/pietgeursen","html_url":"https://github.com/pietgeursen","followers_url":"https://api.github.com/users/pietgeursen/followers","following_url":"https://api.github.com/users/pietgeursen/following{/other_user}","gists_url":"https://api.github.com/users/pietgeursen/gists{/gist_id}","starred_url":"https://api.github.com/users/pietgeursen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pietgeursen/subscriptions","organizations_url":"https://api.github.com/users/pietgeursen/orgs","repos_url":"https://api.github.com/users/pietgeursen/repos","events_url":"https://api.github.com/users/pietgeursen/events{/privacy}","received_events_url":"https://api.github.com/users/pietgeursen/received_events","type":"User","site_admin":false},"repo":{"id":66983407,"name":"mixBank","full_name":"pietgeursen/mixBank","owner":{"login":"pietgeursen","id":10556538,"avatar_url":"https://avatars.githubusercontent.com/u/10556538?v=3","gravatar_id":"","url":"https://api.github.com/users/pietgeursen","html_url":"https://github.com/pietgeursen","followers_url":"https://api.github.com/users/pietgeursen/followers","following_url":"https://api.github.com/users/pietgeursen/following{/other_user}","gists_url":"https://api.github.com/users/pietgeursen/gists{/gist_id}","starred_url":"https://api.github.com/users/pietgeursen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pietgeursen/subscriptions","organizations_url":"https://api.github.com/users/pietgeursen/orgs","repos_url":"https://api.github.com/users/pietgeursen/repos","events_url":"https://api.github.com/users/pietgeursen/events{/privacy}","received_events_url":"https://api.github.com/users/pietgeursen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pietgeursen/mixBank","description":null,"fork":true,"url":"https://api.github.com/repos/pietgeursen/mixBank","forks_url":"https://api.github.com/repos/pietgeursen/mixBank/forks","keys_url":"https://api.github.com/repos/pietgeursen/mixBank/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pietgeursen/mixBank/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pietgeursen/mixBank/teams","hooks_url":"https://api.github.com/repos/pietgeursen/mixBank/hooks","issue_events_url":"https://api.github.com/repos/pietgeursen/mixBank/issues/events{/number}","events_url":"https://api.github.com/repos/pietgeursen/mixBank/events","assignees_url":"https://api.github.com/repos/pietgeursen/mixBank/assignees{/user}","branches_url":"https://api.github.com/repos/pietgeursen/mixBank/branches{/branch}","tags_url":"https://api.github.com/repos/pietgeursen/mixBank/tags","blobs_url":"https://api.github.com/repos/pietgeursen/mixBank/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pietgeursen/mixBank/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pietgeursen/mixBank/git/refs{/sha}","trees_url":"https://api.github.com/repos/pietgeursen/mixBank/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pietgeursen/mixBank/statuses/{sha}","languages_url":"https://api.github.com/repos/pietgeursen/mixBank/languages","stargazers_url":"https://api.github.com/repos/pietgeursen/mixBank/stargazers","contributors_url":"https://api.github.com/repos/pietgeursen/mixBank/contributors","subscribers_url":"https://api.github.com/repos/pietgeursen/mixBank/subscribers","subscription_url":"https://api.github.com/repos/pietgeursen/mixBank/subscription","commits_url":"https://api.github.com/repos/pietgeursen/mixBank/commits{/sha}","git_commits_url":"https://api.github.com/repos/pietgeursen/mixBank/git/commits{/sha}","comments_url":"https://api.github.com/repos/pietgeursen/mixBank/comments{/number}","issue_comment_url":"https://api.github.com/repos/pietgeursen/mixBank/issues/comments{/number}","contents_url":"https://api.github.com/repos/pietgeursen/mixBank/contents/{+path}","compare_url":"https://api.github.com/repos/pietgeursen/mixBank/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pietgeursen/mixBank/merges","archive_url":"https://api.github.com/repos/pietgeursen/mixBank/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pietgeursen/mixBank/downloads","issues_url":"https://api.github.com/repos/pietgeursen/mixBank/issues{/number}","pulls_url":"https://api.github.com/repos/pietgeursen/mixBank/pulls{/number}","milestones_url":"https://api.github.com/repos/pietgeursen/mixBank/milestones{/number}","notifications_url":"https://api.github.com/repos/pietgeursen/mixBank/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pietgeursen/mixBank/labels{/name}","releases_url":"https://api.github.com/repos/pietgeursen/mixBank/releases{/id}","deployments_url":"https://api.github.com/repos/pietgeursen/mixBank/deployments","created_at":"2016-08-30T22:52:11Z","updated_at":"2016-08-30T22:52:12Z","pushed_at":"2016-08-30T23:04:24Z","git_url":"git://github.com/pietgeursen/mixBank.git","ssh_url":"git@github.com:pietgeursen/mixBank.git","clone_url":"https://github.com/pietgeursen/mixBank.git","svn_url":"https://github.com/pietgeursen/mixBank","homepage":null,"size":28,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mandy-kate:testing","ref":"testing","sha":"10b454d77ff5ae6b57173ab11c33a523b45fa369","user":{"login":"mandy-kate","id":18361499,"avatar_url":"https://avatars.githubusercontent.com/u/18361499?v=3","gravatar_id":"","url":"https://api.github.com/users/mandy-kate","html_url":"https://github.com/mandy-kate","followers_url":"https://api.github.com/users/mandy-kate/followers","following_url":"https://api.github.com/users/mandy-kate/following{/other_user}","gists_url":"https://api.github.com/users/mandy-kate/gists{/gist_id}","starred_url":"https://api.github.com/users/mandy-kate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mandy-kate/subscriptions","organizations_url":"https://api.github.com/users/mandy-kate/orgs","repos_url":"https://api.github.com/users/mandy-kate/repos","events_url":"https://api.github.com/users/mandy-kate/events{/privacy}","received_events_url":"https://api.github.com/users/mandy-kate/received_events","type":"User","site_admin":false},"repo":{"id":66704181,"name":"mixBank","full_name":"mandy-kate/mixBank","owner":{"login":"mandy-kate","id":18361499,"avatar_url":"https://avatars.githubusercontent.com/u/18361499?v=3","gravatar_id":"","url":"https://api.github.com/users/mandy-kate","html_url":"https://github.com/mandy-kate","followers_url":"https://api.github.com/users/mandy-kate/followers","following_url":"https://api.github.com/users/mandy-kate/following{/other_user}","gists_url":"https://api.github.com/users/mandy-kate/gists{/gist_id}","starred_url":"https://api.github.com/users/mandy-kate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mandy-kate/subscriptions","organizations_url":"https://api.github.com/users/mandy-kate/orgs","repos_url":"https://api.github.com/users/mandy-kate/repos","events_url":"https://api.github.com/users/mandy-kate/events{/privacy}","received_events_url":"https://api.github.com/users/mandy-kate/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mandy-kate/mixBank","description":null,"fork":false,"url":"https://api.github.com/repos/mandy-kate/mixBank","forks_url":"https://api.github.com/repos/mandy-kate/mixBank/forks","keys_url":"https://api.github.com/repos/mandy-kate/mixBank/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mandy-kate/mixBank/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mandy-kate/mixBank/teams","hooks_url":"https://api.github.com/repos/mandy-kate/mixBank/hooks","issue_events_url":"https://api.github.com/repos/mandy-kate/mixBank/issues/events{/number}","events_url":"https://api.github.com/repos/mandy-kate/mixBank/events","assignees_url":"https://api.github.com/repos/mandy-kate/mixBank/assignees{/user}","branches_url":"https://api.github.com/repos/mandy-kate/mixBank/branches{/branch}","tags_url":"https://api.github.com/repos/mandy-kate/mixBank/tags","blobs_url":"https://api.github.com/repos/mandy-kate/mixBank/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mandy-kate/mixBank/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mandy-kate/mixBank/git/refs{/sha}","trees_url":"https://api.github.com/repos/mandy-kate/mixBank/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mandy-kate/mixBank/statuses/{sha}","languages_url":"https://api.github.com/repos/mandy-kate/mixBank/languages","stargazers_url":"https://api.github.com/repos/mandy-kate/mixBank/stargazers","contributors_url":"https://api.github.com/repos/mandy-kate/mixBank/contributors","subscribers_url":"https://api.github.com/repos/mandy-kate/mixBank/subscribers","subscription_url":"https://api.github.com/repos/mandy-kate/mixBank/subscription","commits_url":"https://api.github.com/repos/mandy-kate/mixBank/commits{/sha}","git_commits_url":"https://api.github.com/repos/mandy-kate/mixBank/git/commits{/sha}","comments_url":"https://api.github.com/repos/mandy-kate/mixBank/comments{/number}","issue_comment_url":"https://api.github.com/repos/mandy-kate/mixBank/issues/comments{/number}","contents_url":"https://api.github.com/repos/mandy-kate/mixBank/contents/{+path}","compare_url":"https://api.github.com/repos/mandy-kate/mixBank/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mandy-kate/mixBank/merges","archive_url":"https://api.github.com/repos/mandy-kate/mixBank/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mandy-kate/mixBank/downloads","issues_url":"https://api.github.com/repos/mandy-kate/mixBank/issues{/number}","pulls_url":"https://api.github.com/repos/mandy-kate/mixBank/pulls{/number}","milestones_url":"https://api.github.com/repos/mandy-kate/mixBank/milestones{/number}","notifications_url":"https://api.github.com/repos/mandy-kate/mixBank/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mandy-kate/mixBank/labels{/name}","releases_url":"https://api.github.com/repos/mandy-kate/mixBank/releases{/id}","deployments_url":"https://api.github.com/repos/mandy-kate/mixBank/deployments","created_at":"2016-08-27T08:24:07Z","updated_at":"2016-08-27T09:45:06Z","pushed_at":"2016-08-30T23:05:00Z","git_url":"git://github.com/mandy-kate/mixBank.git","ssh_url":"git@github.com:mandy-kate/mixBank.git","clone_url":"https://github.com/mandy-kate/mixBank.git","svn_url":"https://github.com/mandy-kate/mixBank","homepage":null,"size":28,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mandy-kate/mixBank/pulls/5"},"html":{"href":"https://github.com/mandy-kate/mixBank/pull/5"},"issue":{"href":"https://api.github.com/repos/mandy-kate/mixBank/issues/5"},"comments":{"href":"https://api.github.com/repos/mandy-kate/mixBank/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/mandy-kate/mixBank/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/mandy-kate/mixBank/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mandy-kate/mixBank/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/mandy-kate/mixBank/statuses/12e124cb57a41bd9b66f7cbefcc655672f32796b"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":11,"deletions":15,"changed_files":3}}
{"actor":{"display_login":"pietgeursen"}}