{"action":"created","issue":{"url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/issues/618","repository_url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui","labels_url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/issues/618/labels{/name}","comments_url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/issues/618/comments","events_url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/issues/618/events","html_url":"https://github.com/pentaho/pentaho-platform-plugin-common-ui/pull/618","id":131535727,"number":618,"title":"[CLEANUP] - Moving common-ui tests to test-js folder","user":{"login":"dcleao","id":284983,"avatar_url":"https://avatars.githubusercontent.com/u/284983?v=3","gravatar_id":"","url":"https://api.github.com/users/dcleao","html_url":"https://github.com/dcleao","followers_url":"https://api.github.com/users/dcleao/followers","following_url":"https://api.github.com/users/dcleao/following{/other_user}","gists_url":"https://api.github.com/users/dcleao/gists{/gist_id}","starred_url":"https://api.github.com/users/dcleao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcleao/subscriptions","organizations_url":"https://api.github.com/users/dcleao/orgs","repos_url":"https://api.github.com/users/dcleao/repos","events_url":"https://api.github.com/users/dcleao/events{/privacy}","received_events_url":"https://api.github.com/users/dcleao/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-02-05T02:18:13Z","updated_at":"2016-02-05T14:23:06Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/pulls/618","html_url":"https://github.com/pentaho/pentaho-platform-plugin-common-ui/pull/618","diff_url":"https://github.com/pentaho/pentaho-platform-plugin-common-ui/pull/618.diff","patch_url":"https://github.com/pentaho/pentaho-platform-plugin-common-ui/pull/618.patch"},"body":"#### Commit 1\r\n* Moved `config/require-config.js` to `test-js/unit/require-config.js`.\r\n  All other tool config files remain in the config folder.\r\n* The file `test-js/unit/require-config.js` now only contains per-project,\r\n  specific AMD configurations.\r\n* The new file `config/context-end.js` now contains all of the code\r\n  necessary to bootstrap the the tests and contains no project specific\r\n  AMD configuration\r\n* The old `config/context.js` was aptly renamed to `config/context-begin.js` and\r\n  now contains two new handy dev-time configuration variables (check them out!)\r\n* Merged one of the `models-mqlSpec.js` with the other same named,\r\n  but in a different folder test file\r\n* Moved some test files to match the source folders of the files being tested\r\n\r\n#### Commit 2\r\n\r\nI noticed that if only the prompting api tests were ran, these would fail, apparently, randomly. This had to do with some lost `jQuery` identifiers, and some undeclared `$` dependencies. Also, there's a strange test explicitly spying on `window.$` (accepting it as global?), that was failing.\r\nSo I propose these fixes. @pentaho/orlandocalisbon tell me if you agree with these. Note that the tests work if all common-ui tests are run.\r\n\r\n@pentaho-nbaker, @pamval, @pentaho/millenniumfalcon, @pentaho/orlandocalisbon please review."},"comment":{"url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/issues/comments/180377302","html_url":"https://github.com/pentaho/pentaho-platform-plugin-common-ui/pull/618#issuecomment-180377302","issue_url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/issues/618","id":180377302,"user":{"login":"dcleao","id":284983,"avatar_url":"https://avatars.githubusercontent.com/u/284983?v=3","gravatar_id":"","url":"https://api.github.com/users/dcleao","html_url":"https://github.com/dcleao","followers_url":"https://api.github.com/users/dcleao/followers","following_url":"https://api.github.com/users/dcleao/following{/other_user}","gists_url":"https://api.github.com/users/dcleao/gists{/gist_id}","starred_url":"https://api.github.com/users/dcleao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcleao/subscriptions","organizations_url":"https://api.github.com/users/dcleao/orgs","repos_url":"https://api.github.com/users/dcleao/repos","events_url":"https://api.github.com/users/dcleao/events{/privacy}","received_events_url":"https://api.github.com/users/dcleao/received_events","type":"User","site_admin":false},"created_at":"2016-02-05T14:23:06Z","updated_at":"2016-02-05T14:23:06Z","body":"Hi guys, I removed the 2nd commit, and will initiate a separate PR with that alone. They are actually independent issues. Sorry for that."}}