{"action":"created","comment":{"url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/pulls/comments/81075924","pull_request_review_id":2082013,"id":81075924,"diff_hunk":"@@ -198,7 +198,20 @@ def configure_step(self):\n \n         # GCC and Clang are installed in different prefixes and Clang will not\n         # find the GCC installation on its own.\n-        self.cfg['configopts'] += \"-DGCC_INSTALL_PREFIX='%s' \" % get_software_root('GCC')\n+        # First try with GCCcore, as GCC built on top of GCCcore is just a wrapper for GCCcore and binutils,\n+        # instead of a full-fledge compiler\n+        gcc_prefix = get_software_root('GCCcore')\n+\n+        # If that doesn't work, try with GCC\n+        if gcc_prefix == None:","path":"easybuild/easyblocks/c/clang.py","position":10,"original_position":10,"commit_id":"2074f2f16e68d4365c2f84b4b14d575c57fb8491","original_commit_id":"2074f2f16e68d4365c2f84b4b14d575c57fb8491","user":{"login":"boegel","id":620876,"avatar_url":"https://avatars.githubusercontent.com/u/620876?v=3","gravatar_id":"","url":"https://api.github.com/users/boegel","html_url":"https://github.com/boegel","followers_url":"https://api.github.com/users/boegel/followers","following_url":"https://api.github.com/users/boegel/following{/other_user}","gists_url":"https://api.github.com/users/boegel/gists{/gist_id}","starred_url":"https://api.github.com/users/boegel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boegel/subscriptions","organizations_url":"https://api.github.com/users/boegel/orgs","repos_url":"https://api.github.com/users/boegel/repos","events_url":"https://api.github.com/users/boegel/events{/privacy}","received_events_url":"https://api.github.com/users/boegel/received_events","type":"User","site_admin":false},"body":"@damianam please use `if gcc_prefix is None` (style nitpicking); same below","created_at":"2016-09-29T07:06:04Z","updated_at":"2016-09-29T07:08:12Z","html_url":"https://github.com/hpcugent/easybuild-easyblocks/pull/1002#discussion_r81075924","pull_request_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/pulls/1002","_links":{"self":{"href":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/pulls/comments/81075924"},"html":{"href":"https://github.com/hpcugent/easybuild-easyblocks/pull/1002#discussion_r81075924"},"pull_request":{"href":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/pulls/1002"}}},"pull_request":{"url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/pulls/1002","id":87102590,"html_url":"https://github.com/hpcugent/easybuild-easyblocks/pull/1002","diff_url":"https://github.com/hpcugent/easybuild-easyblocks/pull/1002.diff","patch_url":"https://github.com/hpcugent/easybuild-easyblocks/pull/1002.patch","issue_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/issues/1002","number":1002,"state":"open","locked":false,"title":"Enable GCCcore as toolchain for clang, add logging, and fail if no proper prefix is found","user":{"login":"damianam","id":10760206,"avatar_url":"https://avatars.githubusercontent.com/u/10760206?v=3","gravatar_id":"","url":"https://api.github.com/users/damianam","html_url":"https://github.com/damianam","followers_url":"https://api.github.com/users/damianam/followers","following_url":"https://api.github.com/users/damianam/following{/other_user}","gists_url":"https://api.github.com/users/damianam/gists{/gist_id}","starred_url":"https://api.github.com/users/damianam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damianam/subscriptions","organizations_url":"https://api.github.com/users/damianam/orgs","repos_url":"https://api.github.com/users/damianam/repos","events_url":"https://api.github.com/users/damianam/events{/privacy}","received_events_url":"https://api.github.com/users/damianam/received_events","type":"User","site_admin":false},"body":"This PR implements the following changes:\r\n\r\n-Enables the use of `GCCcore` as base GCC for clang\r\n-Adds logging to show which path was used as `GCC_INSTALL_PREFIX`\r\n-If no correct path is found, it fails instead of keep going with `-DGCC_INSTALL_PREFIX='None'`","created_at":"2016-09-28T11:37:32Z","updated_at":"2016-09-29T07:08:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c923a2f637456e43ab24c4815b8877cbba808040","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/milestones/26","html_url":"https://github.com/hpcugent/easybuild-easyblocks/milestones/v3.0","labels_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/milestones/26/labels","id":1538603,"number":26,"title":"v3.0","description":"","creator":{"login":"boegel","id":620876,"avatar_url":"https://avatars.githubusercontent.com/u/620876?v=3","gravatar_id":"","url":"https://api.github.com/users/boegel","html_url":"https://github.com/boegel","followers_url":"https://api.github.com/users/boegel/followers","following_url":"https://api.github.com/users/boegel/following{/other_user}","gists_url":"https://api.github.com/users/boegel/gists{/gist_id}","starred_url":"https://api.github.com/users/boegel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boegel/subscriptions","organizations_url":"https://api.github.com/users/boegel/orgs","repos_url":"https://api.github.com/users/boegel/repos","events_url":"https://api.github.com/users/boegel/events{/privacy}","received_events_url":"https://api.github.com/users/boegel/received_events","type":"User","site_admin":false},"open_issues":13,"closed_issues":3,"state":"open","created_at":"2016-01-23T13:29:50Z","updated_at":"2016-09-29T07:04:24Z","due_on":"2016-11-16T00:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/pulls/1002/commits","review_comments_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/pulls/1002/comments","review_comment_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/issues/1002/comments","statuses_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/statuses/2074f2f16e68d4365c2f84b4b14d575c57fb8491","head":{"label":"damianam:clang","ref":"clang","sha":"2074f2f16e68d4365c2f84b4b14d575c57fb8491","user":{"login":"damianam","id":10760206,"avatar_url":"https://avatars.githubusercontent.com/u/10760206?v=3","gravatar_id":"","url":"https://api.github.com/users/damianam","html_url":"https://github.com/damianam","followers_url":"https://api.github.com/users/damianam/followers","following_url":"https://api.github.com/users/damianam/following{/other_user}","gists_url":"https://api.github.com/users/damianam/gists{/gist_id}","starred_url":"https://api.github.com/users/damianam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damianam/subscriptions","organizations_url":"https://api.github.com/users/damianam/orgs","repos_url":"https://api.github.com/users/damianam/repos","events_url":"https://api.github.com/users/damianam/events{/privacy}","received_events_url":"https://api.github.com/users/damianam/received_events","type":"User","site_admin":false},"repo":{"id":46984921,"name":"easybuild-easyblocks","full_name":"damianam/easybuild-easyblocks","owner":{"login":"damianam","id":10760206,"avatar_url":"https://avatars.githubusercontent.com/u/10760206?v=3","gravatar_id":"","url":"https://api.github.com/users/damianam","html_url":"https://github.com/damianam","followers_url":"https://api.github.com/users/damianam/followers","following_url":"https://api.github.com/users/damianam/following{/other_user}","gists_url":"https://api.github.com/users/damianam/gists{/gist_id}","starred_url":"https://api.github.com/users/damianam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damianam/subscriptions","organizations_url":"https://api.github.com/users/damianam/orgs","repos_url":"https://api.github.com/users/damianam/repos","events_url":"https://api.github.com/users/damianam/events{/privacy}","received_events_url":"https://api.github.com/users/damianam/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/damianam/easybuild-easyblocks","description":"Collection of easyblocks that implement support for building and installing software with EasyBuild.","fork":true,"url":"https://api.github.com/repos/damianam/easybuild-easyblocks","forks_url":"https://api.github.com/repos/damianam/easybuild-easyblocks/forks","keys_url":"https://api.github.com/repos/damianam/easybuild-easyblocks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/damianam/easybuild-easyblocks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/damianam/easybuild-easyblocks/teams","hooks_url":"https://api.github.com/repos/damianam/easybuild-easyblocks/hooks","issue_events_url":"https://api.github.com/repos/damianam/easybuild-easyblocks/issues/events{/number}","events_url":"https://api.github.com/repos/damianam/easybuild-easyblocks/events","assignees_url":"https://api.github.com/repos/damianam/easybuild-easyblocks/assignees{/user}","branches_url":"https://api.github.com/repos/damianam/easybuild-easyblocks/branches{/branch}","tags_url":"https://api.github.com/repos/damianam/easybuild-easyblocks/tags","blobs_url":"https://api.github.com/repos/damianam/easybuild-easyblocks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/damianam/easybuild-easyblocks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/damianam/easybuild-easyblocks/git/refs{/sha}","trees_url":"https://api.github.com/repos/damianam/easybuild-easyblocks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/damianam/easybuild-easyblocks/statuses/{sha}","languages_url":"https://api.github.com/repos/damianam/easybuild-easyblocks/languages","stargazers_url":"https://api.github.com/repos/damianam/easybuild-easyblocks/stargazers","contributors_url":"https://api.github.com/repos/damianam/easybuild-easyblocks/contributors","subscribers_url":"https://api.github.com/repos/damianam/easybuild-easyblocks/subscribers","subscription_url":"https://api.github.com/repos/damianam/easybuild-easyblocks/subscription","commits_url":"https://api.github.com/repos/damianam/easybuild-easyblocks/commits{/sha}","git_commits_url":"https://api.github.com/repos/damianam/easybuild-easyblocks/git/commits{/sha}","comments_url":"https://api.github.com/repos/damianam/easybuild-easyblocks/comments{/number}","issue_comment_url":"https://api.github.com/repos/damianam/easybuild-easyblocks/issues/comments{/number}","contents_url":"https://api.github.com/repos/damianam/easybuild-easyblocks/contents/{+path}","compare_url":"https://api.github.com/repos/damianam/easybuild-easyblocks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/damianam/easybuild-easyblocks/merges","archive_url":"https://api.github.com/repos/damianam/easybuild-easyblocks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/damianam/easybuild-easyblocks/downloads","issues_url":"https://api.github.com/repos/damianam/easybuild-easyblocks/issues{/number}","pulls_url":"https://api.github.com/repos/damianam/easybuild-easyblocks/pulls{/number}","milestones_url":"https://api.github.com/repos/damianam/easybuild-easyblocks/milestones{/number}","notifications_url":"https://api.github.com/repos/damianam/easybuild-easyblocks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/damianam/easybuild-easyblocks/labels{/name}","releases_url":"https://api.github.com/repos/damianam/easybuild-easyblocks/releases{/id}","deployments_url":"https://api.github.com/repos/damianam/easybuild-easyblocks/deployments","created_at":"2015-11-27T14:40:00Z","updated_at":"2015-11-27T14:40:02Z","pushed_at":"2016-09-28T12:15:42Z","git_url":"git://github.com/damianam/easybuild-easyblocks.git","ssh_url":"git@github.com:damianam/easybuild-easyblocks.git","clone_url":"https://github.com/damianam/easybuild-easyblocks.git","svn_url":"https://github.com/damianam/easybuild-easyblocks","homepage":"http://hpcugent.github.com/easybuild/","size":7944,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hpcugent:develop","ref":"develop","sha":"b20c08e3b4e300081d64e2c7f613466cb274c86a","user":{"login":"hpcugent","id":1515263,"avatar_url":"https://avatars.githubusercontent.com/u/1515263?v=3","gravatar_id":"","url":"https://api.github.com/users/hpcugent","html_url":"https://github.com/hpcugent","followers_url":"https://api.github.com/users/hpcugent/followers","following_url":"https://api.github.com/users/hpcugent/following{/other_user}","gists_url":"https://api.github.com/users/hpcugent/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcugent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcugent/subscriptions","organizations_url":"https://api.github.com/users/hpcugent/orgs","repos_url":"https://api.github.com/users/hpcugent/repos","events_url":"https://api.github.com/users/hpcugent/events{/privacy}","received_events_url":"https://api.github.com/users/hpcugent/received_events","type":"Organization","site_admin":false},"repo":{"id":6228378,"name":"easybuild-easyblocks","full_name":"hpcugent/easybuild-easyblocks","owner":{"login":"hpcugent","id":1515263,"avatar_url":"https://avatars.githubusercontent.com/u/1515263?v=3","gravatar_id":"","url":"https://api.github.com/users/hpcugent","html_url":"https://github.com/hpcugent","followers_url":"https://api.github.com/users/hpcugent/followers","following_url":"https://api.github.com/users/hpcugent/following{/other_user}","gists_url":"https://api.github.com/users/hpcugent/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcugent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcugent/subscriptions","organizations_url":"https://api.github.com/users/hpcugent/orgs","repos_url":"https://api.github.com/users/hpcugent/repos","events_url":"https://api.github.com/users/hpcugent/events{/privacy}","received_events_url":"https://api.github.com/users/hpcugent/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hpcugent/easybuild-easyblocks","description":"Collection of easyblocks that implement support for building and installing software with EasyBuild.","fork":false,"url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks","forks_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/forks","keys_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/teams","hooks_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/hooks","issue_events_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/issues/events{/number}","events_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/events","assignees_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/assignees{/user}","branches_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/branches{/branch}","tags_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/tags","blobs_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/git/refs{/sha}","trees_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/statuses/{sha}","languages_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/languages","stargazers_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/stargazers","contributors_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/contributors","subscribers_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/subscribers","subscription_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/subscription","commits_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/commits{/sha}","git_commits_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/git/commits{/sha}","comments_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/comments{/number}","issue_comment_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/issues/comments{/number}","contents_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/contents/{+path}","compare_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/merges","archive_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/downloads","issues_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/issues{/number}","pulls_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/pulls{/number}","milestones_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/milestones{/number}","notifications_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/labels{/name}","releases_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/releases{/id}","deployments_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/deployments","created_at":"2012-10-15T14:31:19Z","updated_at":"2016-08-23T20:26:32Z","pushed_at":"2016-09-28T12:15:47Z","git_url":"git://github.com/hpcugent/easybuild-easyblocks.git","ssh_url":"git@github.com:hpcugent/easybuild-easyblocks.git","clone_url":"https://github.com/hpcugent/easybuild-easyblocks.git","svn_url":"https://github.com/hpcugent/easybuild-easyblocks","homepage":"http://hpcugent.github.com/easybuild/","size":12401,"stargazers_count":36,"watchers_count":36,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":108,"mirror_url":null,"open_issues_count":122,"forks":108,"open_issues":122,"watchers":36,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/pulls/1002"},"html":{"href":"https://github.com/hpcugent/easybuild-easyblocks/pull/1002"},"issue":{"href":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/issues/1002"},"comments":{"href":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/issues/1002/comments"},"review_comments":{"href":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/pulls/1002/comments"},"review_comment":{"href":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/pulls/1002/commits"},"statuses":{"href":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/statuses/2074f2f16e68d4365c2f84b4b14d575c57fb8491"}}}}
{"actor":{"display_login":"boegel"}}