{"action":"created","comment":{"url":"https://api.github.com/repos/theforeman/foreman-installer/pulls/comments/60181630","id":60181630,"diff_hunk":"@@ -14,14 +14,23 @@ DATAROOTDIR = DATADIR = ENV['DATAROOTDIR'] || \"#{PREFIX}/share\"\n MANDIR = ENV['MANDIR'] || \"#{DATAROOTDIR}/man\"\n PKGDIR = ENV['PKGDIR'] || File.expand_path('pkg')\n \n+exporter = ENV['PATH'].split(':').push(\n+  '/usr/bin',\n+  ENV['KAFO_EXPORTER']).find do |exporter|","path":"Rakefile","position":null,"original_position":6,"commit_id":"0a62c866668d0e9d24bfaee16ef68e6c889ba4bc","original_commit_id":"161494c452f571a92fa7d358ed2f867fa7e8e392","user":{"login":"domcleal","id":482089,"avatar_url":"https://avatars.githubusercontent.com/u/482089?v=3","gravatar_id":"","url":"https://api.github.com/users/domcleal","html_url":"https://github.com/domcleal","followers_url":"https://api.github.com/users/domcleal/followers","following_url":"https://api.github.com/users/domcleal/following{/other_user}","gists_url":"https://api.github.com/users/domcleal/gists{/gist_id}","starred_url":"https://api.github.com/users/domcleal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/domcleal/subscriptions","organizations_url":"https://api.github.com/users/domcleal/orgs","repos_url":"https://api.github.com/users/domcleal/repos","events_url":"https://api.github.com/users/domcleal/events{/privacy}","received_events_url":"https://api.github.com/users/domcleal/received_events","type":"User","site_admin":false},"body":"Yep, fixed the variable name and I've split up the line to make it more readable.","created_at":"2016-04-19T07:04:30Z","updated_at":"2016-04-19T07:04:30Z","html_url":"https://github.com/theforeman/foreman-installer/pull/172#discussion_r60181630","pull_request_url":"https://api.github.com/repos/theforeman/foreman-installer/pulls/172","_links":{"self":{"href":"https://api.github.com/repos/theforeman/foreman-installer/pulls/comments/60181630"},"html":{"href":"https://github.com/theforeman/foreman-installer/pull/172#discussion_r60181630"},"pull_request":{"href":"https://api.github.com/repos/theforeman/foreman-installer/pulls/172"}}},"pull_request":{"url":"https://api.github.com/repos/theforeman/foreman-installer/pulls/172","id":66868401,"html_url":"https://github.com/theforeman/foreman-installer/pull/172","diff_url":"https://github.com/theforeman/foreman-installer/pull/172.diff","patch_url":"https://github.com/theforeman/foreman-installer/pull/172.patch","issue_url":"https://api.github.com/repos/theforeman/foreman-installer/issues/172","number":172,"state":"open","locked":false,"title":"fixes #14453 - build and install Kafo parser cache","user":{"login":"domcleal","id":482089,"avatar_url":"https://avatars.githubusercontent.com/u/482089?v=3","gravatar_id":"","url":"https://api.github.com/users/domcleal","html_url":"https://github.com/domcleal","followers_url":"https://api.github.com/users/domcleal/followers","following_url":"https://api.github.com/users/domcleal/following{/other_user}","gists_url":"https://api.github.com/users/domcleal/gists{/gist_id}","starred_url":"https://api.github.com/users/domcleal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/domcleal/subscriptions","organizations_url":"https://api.github.com/users/domcleal/orgs","repos_url":"https://api.github.com/users/domcleal/repos","events_url":"https://api.github.com/users/domcleal/events{/privacy}","received_events_url":"https://api.github.com/users/domcleal/received_events","type":"User","site_admin":false},"body":"The parser cache will provide support for Puppet in AIO in the near\r\nfuture with Kafo by not loading Puppet or puppet-strings, and provides\r\na performance boost to the installer startup. Requires Kafo 0.7.3.\r\n\r\nBe careful to preserve mtimes of manifest files to ensure the cache\r\nvalidity. Extra kafo-export-params search dirs were removed as all\r\ncurrent packages install correctly into /usr/bin or PATH, and it is\r\nnow required to build.","created_at":"2016-04-18T15:01:39Z","updated_at":"2016-04-19T07:04:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7c893cdd7be6872b129bea1428e750ea7fd9f3f5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/theforeman/foreman-installer/pulls/172/commits","review_comments_url":"https://api.github.com/repos/theforeman/foreman-installer/pulls/172/comments","review_comment_url":"https://api.github.com/repos/theforeman/foreman-installer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/theforeman/foreman-installer/issues/172/comments","statuses_url":"https://api.github.com/repos/theforeman/foreman-installer/statuses/0a62c866668d0e9d24bfaee16ef68e6c889ba4bc","head":{"label":"domcleal:14453-parser-cache","ref":"14453-parser-cache","sha":"0a62c866668d0e9d24bfaee16ef68e6c889ba4bc","user":{"login":"domcleal","id":482089,"avatar_url":"https://avatars.githubusercontent.com/u/482089?v=3","gravatar_id":"","url":"https://api.github.com/users/domcleal","html_url":"https://github.com/domcleal","followers_url":"https://api.github.com/users/domcleal/followers","following_url":"https://api.github.com/users/domcleal/following{/other_user}","gists_url":"https://api.github.com/users/domcleal/gists{/gist_id}","starred_url":"https://api.github.com/users/domcleal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/domcleal/subscriptions","organizations_url":"https://api.github.com/users/domcleal/orgs","repos_url":"https://api.github.com/users/domcleal/repos","events_url":"https://api.github.com/users/domcleal/events{/privacy}","received_events_url":"https://api.github.com/users/domcleal/received_events","type":"User","site_admin":false},"repo":{"id":6612498,"name":"foreman-installer","full_name":"domcleal/foreman-installer","owner":{"login":"domcleal","id":482089,"avatar_url":"https://avatars.githubusercontent.com/u/482089?v=3","gravatar_id":"","url":"https://api.github.com/users/domcleal","html_url":"https://github.com/domcleal","followers_url":"https://api.github.com/users/domcleal/followers","following_url":"https://api.github.com/users/domcleal/following{/other_user}","gists_url":"https://api.github.com/users/domcleal/gists{/gist_id}","starred_url":"https://api.github.com/users/domcleal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/domcleal/subscriptions","organizations_url":"https://api.github.com/users/domcleal/orgs","repos_url":"https://api.github.com/users/domcleal/repos","events_url":"https://api.github.com/users/domcleal/events{/privacy}","received_events_url":"https://api.github.com/users/domcleal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/domcleal/foreman-installer","description":"Automated Foreman installation and configuration","fork":true,"url":"https://api.github.com/repos/domcleal/foreman-installer","forks_url":"https://api.github.com/repos/domcleal/foreman-installer/forks","keys_url":"https://api.github.com/repos/domcleal/foreman-installer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/domcleal/foreman-installer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/domcleal/foreman-installer/teams","hooks_url":"https://api.github.com/repos/domcleal/foreman-installer/hooks","issue_events_url":"https://api.github.com/repos/domcleal/foreman-installer/issues/events{/number}","events_url":"https://api.github.com/repos/domcleal/foreman-installer/events","assignees_url":"https://api.github.com/repos/domcleal/foreman-installer/assignees{/user}","branches_url":"https://api.github.com/repos/domcleal/foreman-installer/branches{/branch}","tags_url":"https://api.github.com/repos/domcleal/foreman-installer/tags","blobs_url":"https://api.github.com/repos/domcleal/foreman-installer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/domcleal/foreman-installer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/domcleal/foreman-installer/git/refs{/sha}","trees_url":"https://api.github.com/repos/domcleal/foreman-installer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/domcleal/foreman-installer/statuses/{sha}","languages_url":"https://api.github.com/repos/domcleal/foreman-installer/languages","stargazers_url":"https://api.github.com/repos/domcleal/foreman-installer/stargazers","contributors_url":"https://api.github.com/repos/domcleal/foreman-installer/contributors","subscribers_url":"https://api.github.com/repos/domcleal/foreman-installer/subscribers","subscription_url":"https://api.github.com/repos/domcleal/foreman-installer/subscription","commits_url":"https://api.github.com/repos/domcleal/foreman-installer/commits{/sha}","git_commits_url":"https://api.github.com/repos/domcleal/foreman-installer/git/commits{/sha}","comments_url":"https://api.github.com/repos/domcleal/foreman-installer/comments{/number}","issue_comment_url":"https://api.github.com/repos/domcleal/foreman-installer/issues/comments{/number}","contents_url":"https://api.github.com/repos/domcleal/foreman-installer/contents/{+path}","compare_url":"https://api.github.com/repos/domcleal/foreman-installer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/domcleal/foreman-installer/merges","archive_url":"https://api.github.com/repos/domcleal/foreman-installer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/domcleal/foreman-installer/downloads","issues_url":"https://api.github.com/repos/domcleal/foreman-installer/issues{/number}","pulls_url":"https://api.github.com/repos/domcleal/foreman-installer/pulls{/number}","milestones_url":"https://api.github.com/repos/domcleal/foreman-installer/milestones{/number}","notifications_url":"https://api.github.com/repos/domcleal/foreman-installer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/domcleal/foreman-installer/labels{/name}","releases_url":"https://api.github.com/repos/domcleal/foreman-installer/releases{/id}","deployments_url":"https://api.github.com/repos/domcleal/foreman-installer/deployments","created_at":"2012-11-09T11:27:21Z","updated_at":"2014-06-19T08:26:55Z","pushed_at":"2016-04-19T07:04:02Z","git_url":"git://github.com/domcleal/foreman-installer.git","ssh_url":"git@github.com:domcleal/foreman-installer.git","clone_url":"https://github.com/domcleal/foreman-installer.git","svn_url":"https://github.com/domcleal/foreman-installer","homepage":"http://theforeman.org/projects/foreman/wiki/Using_Puppet_Module_ready_to_use","size":198,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"theforeman:develop","ref":"develop","sha":"b39edbb4b3836d1dc6d896919dc7641021ec8f42","user":{"login":"theforeman","id":1439844,"avatar_url":"https://avatars.githubusercontent.com/u/1439844?v=3","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"repo":{"id":3449530,"name":"foreman-installer","full_name":"theforeman/foreman-installer","owner":{"login":"theforeman","id":1439844,"avatar_url":"https://avatars.githubusercontent.com/u/1439844?v=3","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/theforeman/foreman-installer","description":"Automated Foreman installation and configuration","fork":false,"url":"https://api.github.com/repos/theforeman/foreman-installer","forks_url":"https://api.github.com/repos/theforeman/foreman-installer/forks","keys_url":"https://api.github.com/repos/theforeman/foreman-installer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theforeman/foreman-installer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theforeman/foreman-installer/teams","hooks_url":"https://api.github.com/repos/theforeman/foreman-installer/hooks","issue_events_url":"https://api.github.com/repos/theforeman/foreman-installer/issues/events{/number}","events_url":"https://api.github.com/repos/theforeman/foreman-installer/events","assignees_url":"https://api.github.com/repos/theforeman/foreman-installer/assignees{/user}","branches_url":"https://api.github.com/repos/theforeman/foreman-installer/branches{/branch}","tags_url":"https://api.github.com/repos/theforeman/foreman-installer/tags","blobs_url":"https://api.github.com/repos/theforeman/foreman-installer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theforeman/foreman-installer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theforeman/foreman-installer/git/refs{/sha}","trees_url":"https://api.github.com/repos/theforeman/foreman-installer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theforeman/foreman-installer/statuses/{sha}","languages_url":"https://api.github.com/repos/theforeman/foreman-installer/languages","stargazers_url":"https://api.github.com/repos/theforeman/foreman-installer/stargazers","contributors_url":"https://api.github.com/repos/theforeman/foreman-installer/contributors","subscribers_url":"https://api.github.com/repos/theforeman/foreman-installer/subscribers","subscription_url":"https://api.github.com/repos/theforeman/foreman-installer/subscription","commits_url":"https://api.github.com/repos/theforeman/foreman-installer/commits{/sha}","git_commits_url":"https://api.github.com/repos/theforeman/foreman-installer/git/commits{/sha}","comments_url":"https://api.github.com/repos/theforeman/foreman-installer/comments{/number}","issue_comment_url":"https://api.github.com/repos/theforeman/foreman-installer/issues/comments{/number}","contents_url":"https://api.github.com/repos/theforeman/foreman-installer/contents/{+path}","compare_url":"https://api.github.com/repos/theforeman/foreman-installer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theforeman/foreman-installer/merges","archive_url":"https://api.github.com/repos/theforeman/foreman-installer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theforeman/foreman-installer/downloads","issues_url":"https://api.github.com/repos/theforeman/foreman-installer/issues{/number}","pulls_url":"https://api.github.com/repos/theforeman/foreman-installer/pulls{/number}","milestones_url":"https://api.github.com/repos/theforeman/foreman-installer/milestones{/number}","notifications_url":"https://api.github.com/repos/theforeman/foreman-installer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theforeman/foreman-installer/labels{/name}","releases_url":"https://api.github.com/repos/theforeman/foreman-installer/releases{/id}","deployments_url":"https://api.github.com/repos/theforeman/foreman-installer/deployments","created_at":"2012-02-15T13:10:32Z","updated_at":"2016-01-31T09:30:12Z","pushed_at":"2016-04-19T07:04:02Z","git_url":"git://github.com/theforeman/foreman-installer.git","ssh_url":"git@github.com:theforeman/foreman-installer.git","clone_url":"https://github.com/theforeman/foreman-installer.git","svn_url":"https://github.com/theforeman/foreman-installer","homepage":"http://theforeman.org/manuals/latest/index.html#3.InstallingForeman","size":283,"stargazers_count":70,"watchers_count":70,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":67,"mirror_url":null,"open_issues_count":4,"forks":67,"open_issues":4,"watchers":70,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/theforeman/foreman-installer/pulls/172"},"html":{"href":"https://github.com/theforeman/foreman-installer/pull/172"},"issue":{"href":"https://api.github.com/repos/theforeman/foreman-installer/issues/172"},"comments":{"href":"https://api.github.com/repos/theforeman/foreman-installer/issues/172/comments"},"review_comments":{"href":"https://api.github.com/repos/theforeman/foreman-installer/pulls/172/comments"},"review_comment":{"href":"https://api.github.com/repos/theforeman/foreman-installer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/theforeman/foreman-installer/pulls/172/commits"},"statuses":{"href":"https://api.github.com/repos/theforeman/foreman-installer/statuses/0a62c866668d0e9d24bfaee16ef68e6c889ba4bc"}}}}