{"action":"created","issue":{"url":"https://api.github.com/repos/chmln/flatpickr/issues/396","repository_url":"https://api.github.com/repos/chmln/flatpickr","labels_url":"https://api.github.com/repos/chmln/flatpickr/issues/396/labels{/name}","comments_url":"https://api.github.com/repos/chmln/flatpickr/issues/396/comments","events_url":"https://api.github.com/repos/chmln/flatpickr/issues/396/events","html_url":"https://github.com/chmln/flatpickr/issues/396","id":187823573,"number":396,"title":"JS source is using ES6 features, file should be renamed to prevent confusion","user":{"login":"apolzon","id":223493,"avatar_url":"https://avatars.githubusercontent.com/u/223493?v=3","gravatar_id":"","url":"https://api.github.com/users/apolzon","html_url":"https://github.com/apolzon","followers_url":"https://api.github.com/users/apolzon/followers","following_url":"https://api.github.com/users/apolzon/following{/other_user}","gists_url":"https://api.github.com/users/apolzon/gists{/gist_id}","starred_url":"https://api.github.com/users/apolzon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apolzon/subscriptions","organizations_url":"https://api.github.com/users/apolzon/orgs","repos_url":"https://api.github.com/users/apolzon/repos","events_url":"https://api.github.com/users/apolzon/events{/privacy}","received_events_url":"https://api.github.com/users/apolzon/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-11-07T20:50:18Z","updated_at":"2016-11-07T23:56:47Z","closed_at":null,"body":"<!--- Provide a general summary of the issue in the Title above -->\r\n\r\n## Expected Behavior\r\nAdding the current JS source to a Rails project should not throw unexpected precompile errors\r\n<!--- If you're describing a bug, tell us what should happen -->\r\n<!--- If you're suggesting a change/improvement, tell us how it should work -->\r\n\r\n## Current Behavior\r\nSince the JS source uses fat arrows (=>), an ES6 feature, adding flatpickr.js to a rails asset pipeline will cause the precompile phase to fail.\r\n<!--- If describing a bug, tell us what happens instead of the expected behavior -->\r\n<!--- If suggesting a change/improvement, explain the difference from current behavior -->\r\n\r\n## Possible Solution\r\nPlease rename the src/flatpickr.js file to flatpickr.es6 to make es6 usage explicit.\r\n<!--- Not obligatory, but suggest a fix/reason for the bug, -->\r\n<!--- or ideas how to implement the addition or change -->\r\n\r\n## Steps to Reproduce (for bugs)\r\n<!--- Provide a link to a live example, or an unambiguous set of steps to -->\r\n<!--- reproduce this bug. Include code to reproduce, if relevant -->\r\n1.\r\n2.\r\n3.\r\n4.\r\n\r\n## Context\r\n<!--- How has this issue affected you? What are you trying to accomplish? -->\r\n<!--- Providing context helps us come up with a solution that is most useful in the real world -->\r\n\r\n## Your Environment\r\n<!--- Include as many relevant details about the environment you experienced the bug in -->\r\n* Version used:\r\n* Browser Name and version:\r\n* Operating System and version (desktop or mobile):\r\n* Link to your project:\r\n"},"comment":{"url":"https://api.github.com/repos/chmln/flatpickr/issues/comments/259002654","html_url":"https://github.com/chmln/flatpickr/issues/396#issuecomment-259002654","issue_url":"https://api.github.com/repos/chmln/flatpickr/issues/396","id":259002654,"user":{"login":"developit","id":105127,"avatar_url":"https://avatars.githubusercontent.com/u/105127?v=3","gravatar_id":"","url":"https://api.github.com/users/developit","html_url":"https://github.com/developit","followers_url":"https://api.github.com/users/developit/followers","following_url":"https://api.github.com/users/developit/following{/other_user}","gists_url":"https://api.github.com/users/developit/gists{/gist_id}","starred_url":"https://api.github.com/users/developit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/developit/subscriptions","organizations_url":"https://api.github.com/users/developit/orgs","repos_url":"https://api.github.com/users/developit/repos","events_url":"https://api.github.com/users/developit/events{/privacy}","received_events_url":"https://api.github.com/users/developit/received_events","type":"User","site_admin":false},"created_at":"2016-11-07T23:56:47Z","updated_at":"2016-11-07T23:56:47Z","body":"`.es6` is not a recognized file extension. The current version of JavaScript (the file format `.js` refers to) includes arrow functions, there is no reason to invent a new file extension to accommodate out of date build systems.\r\n\r\nAlso: there is a `dist/` directory in the repository root containing the library's transpiled JavaScript. You should be using that."}}
{"actor":{"display_login":"developit"}}