{"action":"closed","issue":{"url":"https://api.github.com/repos/ccpgames/ccpwgl/issues/97","labels_url":"https://api.github.com/repos/ccpgames/ccpwgl/issues/97/labels{/name}","comments_url":"https://api.github.com/repos/ccpgames/ccpwgl/issues/97/comments","events_url":"https://api.github.com/repos/ccpgames/ccpwgl/issues/97/events","html_url":"https://github.com/ccpgames/ccpwgl/issues/97","id":128317256,"number":97,"title":"Tw2TransformTrack - Undefined Variable `orientation`","user":{"login":"cppctamber","id":7591350,"avatar_url":"https://avatars.githubusercontent.com/u/7591350?v=3","gravatar_id":"","url":"https://api.github.com/users/cppctamber","html_url":"https://github.com/cppctamber","followers_url":"https://api.github.com/users/cppctamber/followers","following_url":"https://api.github.com/users/cppctamber/following{/other_user}","gists_url":"https://api.github.com/users/cppctamber/gists{/gist_id}","starred_url":"https://api.github.com/users/cppctamber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cppctamber/subscriptions","organizations_url":"https://api.github.com/users/cppctamber/orgs","repos_url":"https://api.github.com/users/cppctamber/repos","events_url":"https://api.github.com/users/cppctamber/events{/privacy}","received_events_url":"https://api.github.com/users/cppctamber/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-01-23T09:26:08Z","updated_at":"2016-01-23T11:23:47Z","closed_at":"2016-01-23T11:23:47Z","body":"- There is an undefined variable `orientation` in `Tw2TransformTrack`'s prototype `UpdateValue` which is probably supposed to be `this.rotation`\r\n- there are two if statements for `(!this.positionCurve)` directly after one another, not sure if this is a mistake and there should just be one or if one of these variables is incorrect\r\n\r\n```\r\n/**\r\n * Updates a value at a specific time\r\n * TODO: Undefined variable orientation\r\n * @param {number} time\r\n * @prototype\r\n */\r\nTw2TransformTrack.prototype.UpdateValue = function (time)\r\n{\r\n    if (!this.res || !this.res.IsGood())\r\n    {\r\n        return;\r\n    }\r\n    if (!this.positionCurve)\r\n    {\r\n        this.FindTracks();\r\n    }\r\n    if (!this.positionCurve) //<----------------- Duplicate if statement conditions\r\n    {\r\n        return;\r\n    }\r\n\r\n    if (this.cycle)\r\n    {\r\n        time = time % this.duration;\r\n    }\r\n    if (time > this.duration || time < 0)\r\n    {\r\n        return;\r\n    }\r\n\r\n    this.EvaluateCurve(this.positionCurve, time, this.translation, this.cycle, this.duration);\r\n    this.EvaluateCurve(this.orientationCurve, time, this.rotation, this.cycle, this.duration);\r\n    quat4.normalize(orientation); //<------------------------ Undefined variable\r\n    this.EvaluateCurve(this.scaleCurve, time, this._scaleShear, this.cycle, this.duration);\r\n    this.scale[0] = vec3.length(this.scaleCurve);\r\n    this.scale[1] = vec3.length(this.scaleCurve.subarray(3, 6));\r\n    this.scale[2] = vec3.length(this.scaleCurve.subarray(6, 9));\r\n};\r\n```"}}