{"push_id":1026228684,"size":13,"distinct_size":1,"ref":"refs/heads/fix-unlink-after-openwronly","head":"d1165776f1cdd8e0f2aec5e35f2c1bc161e87381","before":"3f9642201e35708a436d86bc3b005a10286acece","commits":[{"sha":"aa63b279b4766f5271e3735fc685913ce11de658","author":{"email":"51e95e227ef3ba952acba345ca25f95087ddc46f@ccs.neu.edu","name":"Rohan Garg"},"message":"jtimer: Fix subtraction of time values","distinct":false,"url":"https://api.github.com/repos/rohgarg/dmtcp-1/commits/aa63b279b4766f5271e3735fc685913ce11de658"},{"sha":"5b6f8a2f3b362c0b665a0604dbc1f8c15de4235a","author":{"email":"fcab423c2227a33f4bf84a110c77c7c6fbee6d79@ccs.neu.edu","name":"Kapil Arya"},"message":"Added new PRIVATE barriers.\n\nThese are not synchronized with other processes and essentially provide\na notification mechanism for the plugins.","distinct":false,"url":"https://api.github.com/repos/rohgarg/dmtcp-1/commits/5b6f8a2f3b362c0b665a0604dbc1f8c15de4235a"},{"sha":"30ff90de6020be69fd804faea8bd8278ddd58eb9","author":{"email":"fcab423c2227a33f4bf84a110c77c7c6fbee6d79@ccs.neu.edu","name":"Kapil Arya"},"message":"Separate file and pty wrappers into separate files.","distinct":false,"url":"https://api.github.com/repos/rohgarg/dmtcp-1/commits/30ff90de6020be69fd804faea8bd8278ddd58eb9"},{"sha":"27fa639d7fcdc131410cc808af870537ee522002","author":{"email":"fcab423c2227a33f4bf84a110c77c7c6fbee6d79@ccs.neu.edu","name":"Kapil Arya"},"message":"Added Util::isPseudoTty().","distinct":false,"url":"https://api.github.com/repos/rohgarg/dmtcp-1/commits/27fa639d7fcdc131410cc808af870537ee522002"},{"sha":"0029f500fabc98e204042251d7fd9c4309cd25f5","author":{"email":"fcab423c2227a33f4bf84a110c77c7c6fbee6d79@ccs.neu.edu","name":"Kapil Arya"},"message":"IPC: Created PTY subplugin.\n\nMoved Pty-specific code to separate files.","distinct":false,"url":"https://api.github.com/repos/rohgarg/dmtcp-1/commits/0029f500fabc98e204042251d7fd9c4309cd25f5"},{"sha":"a6dfa4a33645216d3b513595ab27bad1ebea0566","author":{"email":"fcab423c2227a33f4bf84a110c77c7c6fbee6d79@ccs.neu.edu","name":"Kapil Arya"},"message":"Revamped a bit of PTY code; re-enabled pty1 test.","distinct":false,"url":"https://api.github.com/repos/rohgarg/dmtcp-1/commits/a6dfa4a33645216d3b513595ab27bad1ebea0566"},{"sha":"3688db6fa2a68a35ae9c4f6554450220df061a68","author":{"email":"fcab423c2227a33f4bf84a110c77c7c6fbee6d79@ccs.neu.edu","name":"Kapil Arya"},"message":"Fixed fcntl(F_DUPFD) bug.","distinct":false,"url":"https://api.github.com/repos/rohgarg/dmtcp-1/commits/3688db6fa2a68a35ae9c4f6554450220df061a68"},{"sha":"a8991049a37f5bf3c3dc9ff345bb488a57cafe62","author":{"email":"fcab423c2227a33f4bf84a110c77c7c6fbee6d79@ccs.neu.edu","name":"Kapil Arya"},"message":"Fixed a typo in PtyConnList.","distinct":false,"url":"https://api.github.com/repos/rohgarg/dmtcp-1/commits/a8991049a37f5bf3c3dc9ff345bb488a57cafe62"},{"sha":"8beec0f3ccb640fc7ac1826c1c62dafcdc4bc6b8","author":{"email":"fcab423c2227a33f4bf84a110c77c7c6fbee6d79@ccs.neu.edu","name":"Kapil Arya"},"message":"Added wrapper for daemon().","distinct":false,"url":"https://api.github.com/repos/rohgarg/dmtcp-1/commits/8beec0f3ccb640fc7ac1826c1c62dafcdc4bc6b8"},{"sha":"8a436d3964ae47d8410c7c3cc6822b040f2bc419","author":{"email":"fcab423c2227a33f4bf84a110c77c7c6fbee6d79@ccs.neu.edu","name":"Kapil Arya"},"message":"Added PTY_EXTERNAL type.","distinct":false,"url":"https://api.github.com/repos/rohgarg/dmtcp-1/commits/8a436d3964ae47d8410c7c3cc6822b040f2bc419"},{"sha":"9d9a5d97b815e144725791fc57696fd532ad0f78","author":{"email":"fcab423c2227a33f4bf84a110c77c7c6fbee6d79@ccs.neu.edu","name":"Kapil Arya"},"message":"Merge pull request #345 from karya0/pty\n\nReorganized PTY code","distinct":false,"url":"https://api.github.com/repos/rohgarg/dmtcp-1/commits/9d9a5d97b815e144725791fc57696fd532ad0f78"},{"sha":"c2b451132dc7cd01647e6c3e07ad704d0c195b67","author":{"email":"51e95e227ef3ba952acba345ca25f95087ddc46f@ccs.neu.edu","name":"Rohan Garg"},"message":"dmtcp_coordinator: Fix restart timing\n\nThis patch fixes an issue with the coordinator where\nit would fail to record restart timing information when\nconfigured with --enable-timing.\n\nThe issue was due to recent changes in the barrier API. The\nnew implementation would first check if the coordinator had\nreleased all the requested global barriers, and if not, it would\nexecute a barrier and increment a counter that keeps track of\nthe number of executed barriers. However, the implementation\nfailed to stop and record the restart timer when the global\ncounter (or the number of executed barriers) became equal to\nthe number of requested global barriers.","distinct":false,"url":"https://api.github.com/repos/rohgarg/dmtcp-1/commits/c2b451132dc7cd01647e6c3e07ad704d0c195b67"},{"sha":"d1165776f1cdd8e0f2aec5e35f2c1bc161e87381","author":{"email":"51e95e227ef3ba952acba345ca25f95087ddc46f@ccs.neu.edu","name":"Rohan Garg"},"message":"fileconnection: Fix checkpointing of unlinked files opened with O_WRONLY\n\nThis patch fixes an issue where DMTCP would incorrectly restore\nfiles that were unlinked after opening with O_WRONLY.\n\nThe policy for checkpoint-restore of such files was first defined\nin the commit 5c3dd0a as follows:\n\n a) DMTCP should not checkpoint such files, regardless of the\n    --checkpoint-open-files flags; and\n b) On restart, DMTCP should open such files with (O_WRONLY|O_CREAT)\n    and unlink them.\n\nHowever, the implementaiton never achieved these goals. We did end up\ndoing the first part correctly, but never really got the second path right.\n\nWith the above commit, files would be opened with (O_WRONLY|O_CREAT)\non restart but were never unlinked because the commit overlooked an\nif-clause in the `FileConnection::resume()` method. The if-clause would\ncall unlink() only if a file had the `_ckpted_file` flag set to true.\n\nLater, the commit: 8514737 worsened the situation. It introduced a bug\nin the `FileConnection::refill()` method that would prevent us from even\nopening write-only, unlinked files on restart.","distinct":true,"url":"https://api.github.com/repos/rohgarg/dmtcp-1/commits/d1165776f1cdd8e0f2aec5e35f2c1bc161e87381"}]}