{"action":"created","comment":{"url":"https://api.github.com/repos/nipy/PySurfer/pulls/comments/70241014","id":70241014,"diff_hunk":"@@ -492,6 +510,77 @@ def _set_window_properties(self, size, background, foreground):\n         fg_color_rgb = colorConverter.to_rgb(foreground)\n         self._fg_color = fg_color_rgb\n \n+    def _get_geo_params(self, cortex, alpha=1.0):\n+        \"\"\"Return keyword arguments and other parameters for surface\n+        rendering.\n+\n+        Parameters\n+        ----------\n+        cortex : {classic, high_contrast, low_contrast, bone, tuple}\n+            The name of one of the preset cortex styles, or a tuple\n+            with four entries as described in the return vales.","path":"surfer/viz.py","position":106,"original_position":106,"commit_id":"85d5df68e2dacc88f5643f9fa1d60eae0f0f8d7d","original_commit_id":"85d5df68e2dacc88f5643f9fa1d60eae0f0f8d7d","user":{"login":"mwaskom","id":315810,"avatar_url":"https://avatars.githubusercontent.com/u/315810?v=3","gravatar_id":"","url":"https://api.github.com/users/mwaskom","html_url":"https://github.com/mwaskom","followers_url":"https://api.github.com/users/mwaskom/followers","following_url":"https://api.github.com/users/mwaskom/following{/other_user}","gists_url":"https://api.github.com/users/mwaskom/gists{/gist_id}","starred_url":"https://api.github.com/users/mwaskom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwaskom/subscriptions","organizations_url":"https://api.github.com/users/mwaskom/orgs","repos_url":"https://api.github.com/users/mwaskom/repos","events_url":"https://api.github.com/users/mwaskom/events{/privacy}","received_events_url":"https://api.github.com/users/mwaskom/received_events","type":"User","site_admin":false},"body":"Looking at the return values documentation, it's not clear what the tuple entries should be. (There are three return values for this function).","created_at":"2016-07-11T11:27:50Z","updated_at":"2016-07-11T11:27:50Z","html_url":"https://github.com/nipy/PySurfer/pull/159#discussion_r70241014","pull_request_url":"https://api.github.com/repos/nipy/PySurfer/pulls/159","_links":{"self":{"href":"https://api.github.com/repos/nipy/PySurfer/pulls/comments/70241014"},"html":{"href":"https://github.com/nipy/PySurfer/pull/159#discussion_r70241014"},"pull_request":{"href":"https://api.github.com/repos/nipy/PySurfer/pulls/159"}}},"pull_request":{"url":"https://api.github.com/repos/nipy/PySurfer/pulls/159","id":76858435,"html_url":"https://github.com/nipy/PySurfer/pull/159","diff_url":"https://github.com/nipy/PySurfer/pull/159.diff","patch_url":"https://github.com/nipy/PySurfer/pull/159.patch","issue_url":"https://api.github.com/repos/nipy/PySurfer/issues/159","number":159,"state":"open","locked":false,"title":"NF: added the option to specify alpha transparency for Brain binarized curvature rendering","user":{"login":"ctw","id":1034035,"avatar_url":"https://avatars.githubusercontent.com/u/1034035?v=3","gravatar_id":"","url":"https://api.github.com/users/ctw","html_url":"https://github.com/ctw","followers_url":"https://api.github.com/users/ctw/followers","following_url":"https://api.github.com/users/ctw/following{/other_user}","gists_url":"https://api.github.com/users/ctw/gists{/gist_id}","starred_url":"https://api.github.com/users/ctw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ctw/subscriptions","organizations_url":"https://api.github.com/users/ctw/orgs","repos_url":"https://api.github.com/users/ctw/repos","events_url":"https://api.github.com/users/ctw/events{/privacy}","received_events_url":"https://api.github.com/users/ctw/received_events","type":"User","site_admin":false},"body":"I have added the option to specify alpha transparency for Brain binarized curvature rendering. This can be useful when plotting foci in internal structures that are otherwise obscured by the brain surface. I had considered adding an \"alpha\" keyword to the Brain interface, but opted instead to allow for alpha transparency to be specified in the cortex keyword. I've implemented the chance in a way that should ensure backward compatibility with code specifying the cortex keyword as a 4-tuple or string (in these cases alpha defaults to 1.0). Using a new alpha transparency keyword for the Brain constructor might make this feature more accessible and I'm happy to change the implementation accordingly if that's preferred.","created_at":"2016-07-09T22:12:14Z","updated_at":"2016-07-11T11:27:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e7732afcabe77cfccd789de3f587f84102c014f3","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/nipy/PySurfer/pulls/159/commits","review_comments_url":"https://api.github.com/repos/nipy/PySurfer/pulls/159/comments","review_comment_url":"https://api.github.com/repos/nipy/PySurfer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nipy/PySurfer/issues/159/comments","statuses_url":"https://api.github.com/repos/nipy/PySurfer/statuses/85d5df68e2dacc88f5643f9fa1d60eae0f0f8d7d","head":{"label":"ctw:addalpha","ref":"addalpha","sha":"85d5df68e2dacc88f5643f9fa1d60eae0f0f8d7d","user":{"login":"ctw","id":1034035,"avatar_url":"https://avatars.githubusercontent.com/u/1034035?v=3","gravatar_id":"","url":"https://api.github.com/users/ctw","html_url":"https://github.com/ctw","followers_url":"https://api.github.com/users/ctw/followers","following_url":"https://api.github.com/users/ctw/following{/other_user}","gists_url":"https://api.github.com/users/ctw/gists{/gist_id}","starred_url":"https://api.github.com/users/ctw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ctw/subscriptions","organizations_url":"https://api.github.com/users/ctw/orgs","repos_url":"https://api.github.com/users/ctw/repos","events_url":"https://api.github.com/users/ctw/events{/privacy}","received_events_url":"https://api.github.com/users/ctw/received_events","type":"User","site_admin":false},"repo":{"id":62970181,"name":"PySurfer","full_name":"ctw/PySurfer","owner":{"login":"ctw","id":1034035,"avatar_url":"https://avatars.githubusercontent.com/u/1034035?v=3","gravatar_id":"","url":"https://api.github.com/users/ctw","html_url":"https://github.com/ctw","followers_url":"https://api.github.com/users/ctw/followers","following_url":"https://api.github.com/users/ctw/following{/other_user}","gists_url":"https://api.github.com/users/ctw/gists{/gist_id}","starred_url":"https://api.github.com/users/ctw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ctw/subscriptions","organizations_url":"https://api.github.com/users/ctw/orgs","repos_url":"https://api.github.com/users/ctw/repos","events_url":"https://api.github.com/users/ctw/events{/privacy}","received_events_url":"https://api.github.com/users/ctw/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ctw/PySurfer","description":"Cortical neuroimaging visualization in Python","fork":true,"url":"https://api.github.com/repos/ctw/PySurfer","forks_url":"https://api.github.com/repos/ctw/PySurfer/forks","keys_url":"https://api.github.com/repos/ctw/PySurfer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ctw/PySurfer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ctw/PySurfer/teams","hooks_url":"https://api.github.com/repos/ctw/PySurfer/hooks","issue_events_url":"https://api.github.com/repos/ctw/PySurfer/issues/events{/number}","events_url":"https://api.github.com/repos/ctw/PySurfer/events","assignees_url":"https://api.github.com/repos/ctw/PySurfer/assignees{/user}","branches_url":"https://api.github.com/repos/ctw/PySurfer/branches{/branch}","tags_url":"https://api.github.com/repos/ctw/PySurfer/tags","blobs_url":"https://api.github.com/repos/ctw/PySurfer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ctw/PySurfer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ctw/PySurfer/git/refs{/sha}","trees_url":"https://api.github.com/repos/ctw/PySurfer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ctw/PySurfer/statuses/{sha}","languages_url":"https://api.github.com/repos/ctw/PySurfer/languages","stargazers_url":"https://api.github.com/repos/ctw/PySurfer/stargazers","contributors_url":"https://api.github.com/repos/ctw/PySurfer/contributors","subscribers_url":"https://api.github.com/repos/ctw/PySurfer/subscribers","subscription_url":"https://api.github.com/repos/ctw/PySurfer/subscription","commits_url":"https://api.github.com/repos/ctw/PySurfer/commits{/sha}","git_commits_url":"https://api.github.com/repos/ctw/PySurfer/git/commits{/sha}","comments_url":"https://api.github.com/repos/ctw/PySurfer/comments{/number}","issue_comment_url":"https://api.github.com/repos/ctw/PySurfer/issues/comments{/number}","contents_url":"https://api.github.com/repos/ctw/PySurfer/contents/{+path}","compare_url":"https://api.github.com/repos/ctw/PySurfer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ctw/PySurfer/merges","archive_url":"https://api.github.com/repos/ctw/PySurfer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ctw/PySurfer/downloads","issues_url":"https://api.github.com/repos/ctw/PySurfer/issues{/number}","pulls_url":"https://api.github.com/repos/ctw/PySurfer/pulls{/number}","milestones_url":"https://api.github.com/repos/ctw/PySurfer/milestones{/number}","notifications_url":"https://api.github.com/repos/ctw/PySurfer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ctw/PySurfer/labels{/name}","releases_url":"https://api.github.com/repos/ctw/PySurfer/releases{/id}","deployments_url":"https://api.github.com/repos/ctw/PySurfer/deployments","created_at":"2016-07-09T21:37:38Z","updated_at":"2016-07-09T21:37:38Z","pushed_at":"2016-07-11T01:41:33Z","git_url":"git://github.com/ctw/PySurfer.git","ssh_url":"git@github.com:ctw/PySurfer.git","clone_url":"https://github.com/ctw/PySurfer.git","svn_url":"https://github.com/ctw/PySurfer","homepage":"http://pysurfer.github.com","size":16922,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nipy:master","ref":"master","sha":"d6350fd9192dd8d4cccfef92706dd5d7cb217010","user":{"login":"nipy","id":233707,"avatar_url":"https://avatars.githubusercontent.com/u/233707?v=3","gravatar_id":"","url":"https://api.github.com/users/nipy","html_url":"https://github.com/nipy","followers_url":"https://api.github.com/users/nipy/followers","following_url":"https://api.github.com/users/nipy/following{/other_user}","gists_url":"https://api.github.com/users/nipy/gists{/gist_id}","starred_url":"https://api.github.com/users/nipy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nipy/subscriptions","organizations_url":"https://api.github.com/users/nipy/orgs","repos_url":"https://api.github.com/users/nipy/repos","events_url":"https://api.github.com/users/nipy/events{/privacy}","received_events_url":"https://api.github.com/users/nipy/received_events","type":"Organization","site_admin":false},"repo":{"id":1551431,"name":"PySurfer","full_name":"nipy/PySurfer","owner":{"login":"nipy","id":233707,"avatar_url":"https://avatars.githubusercontent.com/u/233707?v=3","gravatar_id":"","url":"https://api.github.com/users/nipy","html_url":"https://github.com/nipy","followers_url":"https://api.github.com/users/nipy/followers","following_url":"https://api.github.com/users/nipy/following{/other_user}","gists_url":"https://api.github.com/users/nipy/gists{/gist_id}","starred_url":"https://api.github.com/users/nipy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nipy/subscriptions","organizations_url":"https://api.github.com/users/nipy/orgs","repos_url":"https://api.github.com/users/nipy/repos","events_url":"https://api.github.com/users/nipy/events{/privacy}","received_events_url":"https://api.github.com/users/nipy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nipy/PySurfer","description":"Cortical neuroimaging visualization in Python","fork":false,"url":"https://api.github.com/repos/nipy/PySurfer","forks_url":"https://api.github.com/repos/nipy/PySurfer/forks","keys_url":"https://api.github.com/repos/nipy/PySurfer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nipy/PySurfer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nipy/PySurfer/teams","hooks_url":"https://api.github.com/repos/nipy/PySurfer/hooks","issue_events_url":"https://api.github.com/repos/nipy/PySurfer/issues/events{/number}","events_url":"https://api.github.com/repos/nipy/PySurfer/events","assignees_url":"https://api.github.com/repos/nipy/PySurfer/assignees{/user}","branches_url":"https://api.github.com/repos/nipy/PySurfer/branches{/branch}","tags_url":"https://api.github.com/repos/nipy/PySurfer/tags","blobs_url":"https://api.github.com/repos/nipy/PySurfer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nipy/PySurfer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nipy/PySurfer/git/refs{/sha}","trees_url":"https://api.github.com/repos/nipy/PySurfer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nipy/PySurfer/statuses/{sha}","languages_url":"https://api.github.com/repos/nipy/PySurfer/languages","stargazers_url":"https://api.github.com/repos/nipy/PySurfer/stargazers","contributors_url":"https://api.github.com/repos/nipy/PySurfer/contributors","subscribers_url":"https://api.github.com/repos/nipy/PySurfer/subscribers","subscription_url":"https://api.github.com/repos/nipy/PySurfer/subscription","commits_url":"https://api.github.com/repos/nipy/PySurfer/commits{/sha}","git_commits_url":"https://api.github.com/repos/nipy/PySurfer/git/commits{/sha}","comments_url":"https://api.github.com/repos/nipy/PySurfer/comments{/number}","issue_comment_url":"https://api.github.com/repos/nipy/PySurfer/issues/comments{/number}","contents_url":"https://api.github.com/repos/nipy/PySurfer/contents/{+path}","compare_url":"https://api.github.com/repos/nipy/PySurfer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nipy/PySurfer/merges","archive_url":"https://api.github.com/repos/nipy/PySurfer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nipy/PySurfer/downloads","issues_url":"https://api.github.com/repos/nipy/PySurfer/issues{/number}","pulls_url":"https://api.github.com/repos/nipy/PySurfer/pulls{/number}","milestones_url":"https://api.github.com/repos/nipy/PySurfer/milestones{/number}","notifications_url":"https://api.github.com/repos/nipy/PySurfer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nipy/PySurfer/labels{/name}","releases_url":"https://api.github.com/repos/nipy/PySurfer/releases{/id}","deployments_url":"https://api.github.com/repos/nipy/PySurfer/deployments","created_at":"2011-03-31T15:30:51Z","updated_at":"2016-07-09T20:36:12Z","pushed_at":"2016-07-11T01:41:33Z","git_url":"git://github.com/nipy/PySurfer.git","ssh_url":"git@github.com:nipy/PySurfer.git","clone_url":"https://github.com/nipy/PySurfer.git","svn_url":"https://github.com/nipy/PySurfer","homepage":"http://pysurfer.github.com","size":19845,"stargazers_count":55,"watchers_count":55,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":40,"mirror_url":null,"open_issues_count":16,"forks":40,"open_issues":16,"watchers":55,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nipy/PySurfer/pulls/159"},"html":{"href":"https://github.com/nipy/PySurfer/pull/159"},"issue":{"href":"https://api.github.com/repos/nipy/PySurfer/issues/159"},"comments":{"href":"https://api.github.com/repos/nipy/PySurfer/issues/159/comments"},"review_comments":{"href":"https://api.github.com/repos/nipy/PySurfer/pulls/159/comments"},"review_comment":{"href":"https://api.github.com/repos/nipy/PySurfer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nipy/PySurfer/pulls/159/commits"},"statuses":{"href":"https://api.github.com/repos/nipy/PySurfer/statuses/85d5df68e2dacc88f5643f9fa1d60eae0f0f8d7d"}}}}
{"actor":{"display_login":"mwaskom"}}