{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/pulls/comments/75683331","id":75683331,"diff_hunk":"@@ -262,267 +279,262 @@ function Bigtable(options) {\n     return new Bigtable(options);\n   }\n \n-  if (!options.cluster) {\n-    throw new Error('A cluster must be provided to interact with Bigtable.');\n-  }\n-\n-  if (!options.zone) {\n-    throw new Error('A zone must be provided to interact with Bigtable.');\n-  }\n-\n-  options = extend({}, options, {\n-    zone: options.zone.name || options.zone\n-  });\n-\n-  this.clusterName = format(\n-    'projects/{projectId}/zones/{zone}/clusters/{cluster}',\n-    options\n-  );\n+  var adminBaseUrl = 'bigtableadmin.googleapis.com';\n \n   var config = {\n     baseUrl: 'bigtable.googleapis.com',\n     service: 'bigtable',\n-    apiVersion: 'v1',\n+    apiVersion: 'v2',\n     protoServices: {\n-      BigtableService: googleProtoFiles.bigtable.v1,\n-      BigtableTableService: {\n-        path: googleProtoFiles.bigtable.admin,\n-        service: 'bigtable.admin.table'\n+      Bigtable: googleProtoFiles.bigtable.v2,","path":"packages/bigtable/src/index.js","position":143,"original_position":143,"commit_id":"9b6a34775cf707b3273c96175e1c65d573952e38","original_commit_id":"9b6a34775cf707b3273c96175e1c65d573952e38","user":{"login":"callmehiphop","id":1707267,"avatar_url":"https://avatars.githubusercontent.com/u/1707267?v=3","gravatar_id":"","url":"https://api.github.com/users/callmehiphop","html_url":"https://github.com/callmehiphop","followers_url":"https://api.github.com/users/callmehiphop/followers","following_url":"https://api.github.com/users/callmehiphop/following{/other_user}","gists_url":"https://api.github.com/users/callmehiphop/gists{/gist_id}","starred_url":"https://api.github.com/users/callmehiphop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/callmehiphop/subscriptions","organizations_url":"https://api.github.com/users/callmehiphop/orgs","repos_url":"https://api.github.com/users/callmehiphop/repos","events_url":"https://api.github.com/users/callmehiphop/events{/privacy}","received_events_url":"https://api.github.com/users/callmehiphop/received_events","type":"User","site_admin":false},"body":"We could always just export the proto files in common or else add a getter somewhere in there. Thoughts?","created_at":"2016-08-22T14:06:13Z","updated_at":"2016-08-22T14:06:13Z","html_url":"https://github.com/GoogleCloudPlatform/gcloud-node/pull/1439#discussion_r75683331","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/pulls/1439","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/pulls/comments/75683331"},"html":{"href":"https://github.com/GoogleCloudPlatform/gcloud-node/pull/1439#discussion_r75683331"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/pulls/1439"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/pulls/1439","id":77846939,"html_url":"https://github.com/GoogleCloudPlatform/gcloud-node/pull/1439","diff_url":"https://github.com/GoogleCloudPlatform/gcloud-node/pull/1439.diff","patch_url":"https://github.com/GoogleCloudPlatform/gcloud-node/pull/1439.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/issues/1439","number":1439,"state":"open","locked":false,"title":"bigtable: v2 support","user":{"login":"callmehiphop","id":1707267,"avatar_url":"https://avatars.githubusercontent.com/u/1707267?v=3","gravatar_id":"","url":"https://api.github.com/users/callmehiphop","html_url":"https://github.com/callmehiphop","followers_url":"https://api.github.com/users/callmehiphop/followers","following_url":"https://api.github.com/users/callmehiphop/following{/other_user}","gists_url":"https://api.github.com/users/callmehiphop/gists{/gist_id}","starred_url":"https://api.github.com/users/callmehiphop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/callmehiphop/subscriptions","organizations_url":"https://api.github.com/users/callmehiphop/orgs","repos_url":"https://api.github.com/users/callmehiphop/repos","events_url":"https://api.github.com/users/callmehiphop/events{/privacy}","received_events_url":"https://api.github.com/users/callmehiphop/received_events","type":"User","site_admin":false},"body":"Moving Bigtable to v2!\r\n---\r\n\r\n##### TODOS:\r\n\r\n- [x] New APIs\r\n  - [x] Instance\r\n  - [x] Cluster\r\n  - [x] grpc Operations\r\n- [x] Old API Updates\r\n  - [x] ReadRows\r\n- [x] Refactor request options for existing APIs (where applicable)\r\n- [x] Tests\r\n  - [x] Linted\r\n  - [x] Unit\r\n    - [x] Update outdated tests\r\n    - [x] Add tests for new APIs\r\n  - [x] System\r\n- [x] Documentation\r\n  - [x] Add docs for new APIs\r\n  - [x] Update old docs to reflect param changes, etc.\r\n\r\n===\r\n\r\n[Docs Demo](http://callmehiphop.github.io/gcloud-node/#/docs/bigtable/master/bigtable)","created_at":"2016-07-18T17:34:54Z","updated_at":"2016-08-22T14:06:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c49c07da977c6c805100a24d1b23586951d58a27","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/pulls/1439/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/pulls/1439/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/issues/1439/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/statuses/9b6a34775cf707b3273c96175e1c65d573952e38","head":{"label":"callmehiphop:bigtable-v2","ref":"bigtable-v2","sha":"9b6a34775cf707b3273c96175e1c65d573952e38","user":{"login":"callmehiphop","id":1707267,"avatar_url":"https://avatars.githubusercontent.com/u/1707267?v=3","gravatar_id":"","url":"https://api.github.com/users/callmehiphop","html_url":"https://github.com/callmehiphop","followers_url":"https://api.github.com/users/callmehiphop/followers","following_url":"https://api.github.com/users/callmehiphop/following{/other_user}","gists_url":"https://api.github.com/users/callmehiphop/gists{/gist_id}","starred_url":"https://api.github.com/users/callmehiphop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/callmehiphop/subscriptions","organizations_url":"https://api.github.com/users/callmehiphop/orgs","repos_url":"https://api.github.com/users/callmehiphop/repos","events_url":"https://api.github.com/users/callmehiphop/events{/privacy}","received_events_url":"https://api.github.com/users/callmehiphop/received_events","type":"User","site_admin":false},"repo":{"id":39030018,"name":"gcloud-node","full_name":"callmehiphop/gcloud-node","owner":{"login":"callmehiphop","id":1707267,"avatar_url":"https://avatars.githubusercontent.com/u/1707267?v=3","gravatar_id":"","url":"https://api.github.com/users/callmehiphop","html_url":"https://github.com/callmehiphop","followers_url":"https://api.github.com/users/callmehiphop/followers","following_url":"https://api.github.com/users/callmehiphop/following{/other_user}","gists_url":"https://api.github.com/users/callmehiphop/gists{/gist_id}","starred_url":"https://api.github.com/users/callmehiphop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/callmehiphop/subscriptions","organizations_url":"https://api.github.com/users/callmehiphop/orgs","repos_url":"https://api.github.com/users/callmehiphop/repos","events_url":"https://api.github.com/users/callmehiphop/events{/privacy}","received_events_url":"https://api.github.com/users/callmehiphop/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/callmehiphop/gcloud-node","description":"Google Cloud Client Library for Node.js","fork":true,"url":"https://api.github.com/repos/callmehiphop/gcloud-node","forks_url":"https://api.github.com/repos/callmehiphop/gcloud-node/forks","keys_url":"https://api.github.com/repos/callmehiphop/gcloud-node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/callmehiphop/gcloud-node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/callmehiphop/gcloud-node/teams","hooks_url":"https://api.github.com/repos/callmehiphop/gcloud-node/hooks","issue_events_url":"https://api.github.com/repos/callmehiphop/gcloud-node/issues/events{/number}","events_url":"https://api.github.com/repos/callmehiphop/gcloud-node/events","assignees_url":"https://api.github.com/repos/callmehiphop/gcloud-node/assignees{/user}","branches_url":"https://api.github.com/repos/callmehiphop/gcloud-node/branches{/branch}","tags_url":"https://api.github.com/repos/callmehiphop/gcloud-node/tags","blobs_url":"https://api.github.com/repos/callmehiphop/gcloud-node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/callmehiphop/gcloud-node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/callmehiphop/gcloud-node/git/refs{/sha}","trees_url":"https://api.github.com/repos/callmehiphop/gcloud-node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/callmehiphop/gcloud-node/statuses/{sha}","languages_url":"https://api.github.com/repos/callmehiphop/gcloud-node/languages","stargazers_url":"https://api.github.com/repos/callmehiphop/gcloud-node/stargazers","contributors_url":"https://api.github.com/repos/callmehiphop/gcloud-node/contributors","subscribers_url":"https://api.github.com/repos/callmehiphop/gcloud-node/subscribers","subscription_url":"https://api.github.com/repos/callmehiphop/gcloud-node/subscription","commits_url":"https://api.github.com/repos/callmehiphop/gcloud-node/commits{/sha}","git_commits_url":"https://api.github.com/repos/callmehiphop/gcloud-node/git/commits{/sha}","comments_url":"https://api.github.com/repos/callmehiphop/gcloud-node/comments{/number}","issue_comment_url":"https://api.github.com/repos/callmehiphop/gcloud-node/issues/comments{/number}","contents_url":"https://api.github.com/repos/callmehiphop/gcloud-node/contents/{+path}","compare_url":"https://api.github.com/repos/callmehiphop/gcloud-node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/callmehiphop/gcloud-node/merges","archive_url":"https://api.github.com/repos/callmehiphop/gcloud-node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/callmehiphop/gcloud-node/downloads","issues_url":"https://api.github.com/repos/callmehiphop/gcloud-node/issues{/number}","pulls_url":"https://api.github.com/repos/callmehiphop/gcloud-node/pulls{/number}","milestones_url":"https://api.github.com/repos/callmehiphop/gcloud-node/milestones{/number}","notifications_url":"https://api.github.com/repos/callmehiphop/gcloud-node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/callmehiphop/gcloud-node/labels{/name}","releases_url":"https://api.github.com/repos/callmehiphop/gcloud-node/releases{/id}","deployments_url":"https://api.github.com/repos/callmehiphop/gcloud-node/deployments","created_at":"2015-07-13T18:32:45Z","updated_at":"2016-06-24T15:31:14Z","pushed_at":"2016-08-22T13:15:44Z","git_url":"git://github.com/callmehiphop/gcloud-node.git","ssh_url":"git@github.com:callmehiphop/gcloud-node.git","clone_url":"https://github.com/callmehiphop/gcloud-node.git","svn_url":"https://github.com/callmehiphop/gcloud-node","homepage":"https://googlecloudplatform.github.io/gcloud-node/","size":16229,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"b061d82b5a2c58843e54d930e313784592cfb8e4","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":19483273,"name":"gcloud-node","full_name":"GoogleCloudPlatform/gcloud-node","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/gcloud-node","description":"Google Cloud Client Library for Node.js","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/deployments","created_at":"2014-05-06T06:18:00Z","updated_at":"2016-08-22T03:59:26Z","pushed_at":"2016-08-22T13:00:27Z","git_url":"git://github.com/GoogleCloudPlatform/gcloud-node.git","ssh_url":"git@github.com:GoogleCloudPlatform/gcloud-node.git","clone_url":"https://github.com/GoogleCloudPlatform/gcloud-node.git","svn_url":"https://github.com/GoogleCloudPlatform/gcloud-node","homepage":"https://googlecloudplatform.github.io/gcloud-node/","size":17916,"stargazers_count":869,"watchers_count":869,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":199,"mirror_url":null,"open_issues_count":63,"forks":199,"open_issues":63,"watchers":869,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/pulls/1439"},"html":{"href":"https://github.com/GoogleCloudPlatform/gcloud-node/pull/1439"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/issues/1439"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/issues/1439/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/pulls/1439/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/pulls/1439/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/statuses/9b6a34775cf707b3273c96175e1c65d573952e38"}}}}
{"actor":{"display_login":"callmehiphop"}}