{"action":"created","comment":{"url":"https://api.github.com/repos/pysal/pysal/pulls/comments/64243214","id":64243214,"diff_hunk":"@@ -9,38 +9,44 @@\n import pysal as ps\n import matplotlib.pyplot as plt\n \n-\n-def moran(var, w, xlabel='', ylabel='', title='', custom=(5,5)):\n-\t'''\n+def mplot(m, xlabel='', ylabel='', title='', custom=(7,7)):\n+    '''\n     Produce basic Moran Plot \n     ...\n-    Arguments\n+    Parameters\n     ---------\n-    var\t            : array\n-                      values of variable\n-    w       \t    : spatial weight\n+    m            : array","path":"pysal/contrib/viz/plot.py","position":null,"original_position":17,"commit_id":"6da47d169b5d14cf5d35592c41601653f4cc11b7","original_commit_id":"6da47d169b5d14cf5d35592c41601653f4cc11b7","user":{"login":"Makosak","id":4277692,"avatar_url":"https://avatars.githubusercontent.com/u/4277692?v=3","gravatar_id":"","url":"https://api.github.com/users/Makosak","html_url":"https://github.com/Makosak","followers_url":"https://api.github.com/users/Makosak/followers","following_url":"https://api.github.com/users/Makosak/following{/other_user}","gists_url":"https://api.github.com/users/Makosak/gists{/gist_id}","starred_url":"https://api.github.com/users/Makosak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Makosak/subscriptions","organizations_url":"https://api.github.com/users/Makosak/orgs","repos_url":"https://api.github.com/users/Makosak/repos","events_url":"https://api.github.com/users/Makosak/events{/privacy}","received_events_url":"https://api.github.com/users/Makosak/received_events","type":"User","site_admin":false},"body":"But, that doesn't seem to be causing any real issues -- sorry to confuse! :P\n\nOn Mon, May 23, 2016 at 10:39 AM, Marynia Kolak <marynia.kolak@gmail.com>\nwrote:\n\n> No worries, I know -- it was my mistake! I can update it later today.\n>\n> I was referencing a potential issue with how m is defined, and how the\n> class is being inherited (or not). I'm still getting familiar with under\n> the hood of PySal, and when I queried the structure of \"m\" :\n>\n> > type(m)\n> > instance\n>\n> The output was *instance*, which upon further reading, indicates that the\n> class might not be inheriting correctly. In other words, \"type(m)\" should\n> output the class object as a type, not \"instance\" (according to those\n> discussion and readings I linked earlier.\n>\n> On Mon, May 23, 2016 at 10:30 AM, Dani Arribas-Bel <\n> notifications@github.com> wrote:\n>\n>> In pysal/contrib/viz/plot.py\n>> <https://github.com/pysal/pysal/pull/797#discussion_r64241013>:\n>>\n>> >      ---------\n>> > -    var\t            : array\n>> > -                      values of variable\n>> > -    w       \t    : spatial weight\n>> > +    m            : array\n>>\n>> Not sure I understand your view. Mine was really that we need to give the\n>> user some guidance as to what to pass in as m for the function. Right\n>> now, it's asking for a (numpy) array, but what it really takes is the\n>> output of ps.Moran, hence my suggestion to use that in the documentation.\n>>\n>> —\n>> You are receiving this because you were mentioned.\n>> Reply to this email directly or view it on GitHub\n>> <https://github.com/pysal/pysal/pull/797/files/beace6676894fa61fd6a1328b8b0cc08e1fd8b49..6da47d169b5d14cf5d35592c41601653f4cc11b7#r64241013>\n>>\n>\n>\n","created_at":"2016-05-23T15:48:40Z","updated_at":"2016-05-23T15:48:40Z","html_url":"https://github.com/pysal/pysal/pull/797#discussion_r64243214","pull_request_url":"https://api.github.com/repos/pysal/pysal/pulls/797","_links":{"self":{"href":"https://api.github.com/repos/pysal/pysal/pulls/comments/64243214"},"html":{"href":"https://github.com/pysal/pysal/pull/797#discussion_r64243214"},"pull_request":{"href":"https://api.github.com/repos/pysal/pysal/pulls/797"}}},"pull_request":{"url":"https://api.github.com/repos/pysal/pysal/pulls/797","id":67449196,"html_url":"https://github.com/pysal/pysal/pull/797","diff_url":"https://github.com/pysal/pysal/pull/797.diff","patch_url":"https://github.com/pysal/pysal/pull/797.patch","issue_url":"https://api.github.com/repos/pysal/pysal/issues/797","number":797,"state":"closed","locked":false,"title":"working moran plot func","user":{"login":"Makosak","id":4277692,"avatar_url":"https://avatars.githubusercontent.com/u/4277692?v=3","gravatar_id":"","url":"https://api.github.com/users/Makosak","html_url":"https://github.com/Makosak","followers_url":"https://api.github.com/users/Makosak/followers","following_url":"https://api.github.com/users/Makosak/following{/other_user}","gists_url":"https://api.github.com/users/Makosak/gists{/gist_id}","starred_url":"https://api.github.com/users/Makosak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Makosak/subscriptions","organizations_url":"https://api.github.com/users/Makosak/orgs","repos_url":"https://api.github.com/users/Makosak/repos","events_url":"https://api.github.com/users/Makosak/events{/privacy}","received_events_url":"https://api.github.com/users/Makosak/received_events","type":"User","site_admin":false},"body":"Hello! Please make sure to check all these boxes before submitting a Pull Request\r\n(PR). Once you have checked the boxes, feel free to remove all text except the\r\njustification in point 5. \r\n\r\n1. [ X] You have run tests on this submission, either by using [Travis Continuous Integration testing](https://github.com/pysal/pysal/wiki/GitHub-Standard-Operating-Procedures#automated-testing-w-travis-ci) testing or running `nosetests` on your changes?\r\n2. [ X] This pull request is directed to the `pysal/dev` branch.\r\n3. [ X] This pull introduces new functionality covered by\r\n   [docstrings](https://en.wikipedia.org/wiki/Docstring#Python) and\r\n   [unittests](https://docs.python.org/2/library/unittest.html)? \r\n4. [ - ] You have [assigned a\r\n   reviewer](https://help.github.com/articles/assigning-issues-and-pull-requests-to-other-github-users/) and added relevant [labels](https://help.github.com/articles/applying-labels-to-issues-and-pull-requests/) [[ No option for assignee? Cant find it on my fork in issues or pull screen?? ]]\r\n5. [ X] The justification for this PR is: \r\nAdding Moran Plot view to contrib module. Will add additional functionality. In Progress\r\n","created_at":"2016-04-22T02:04:28Z","updated_at":"2016-05-23T15:48:41Z","closed_at":"2016-05-21T20:22:36Z","merged_at":"2016-05-21T20:22:36Z","merge_commit_sha":"635d5a41487791b9d60cff3b250558844ebf8499","assignee":{"login":"darribas","id":417363,"avatar_url":"https://avatars.githubusercontent.com/u/417363?v=3","gravatar_id":"","url":"https://api.github.com/users/darribas","html_url":"https://github.com/darribas","followers_url":"https://api.github.com/users/darribas/followers","following_url":"https://api.github.com/users/darribas/following{/other_user}","gists_url":"https://api.github.com/users/darribas/gists{/gist_id}","starred_url":"https://api.github.com/users/darribas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darribas/subscriptions","organizations_url":"https://api.github.com/users/darribas/orgs","repos_url":"https://api.github.com/users/darribas/repos","events_url":"https://api.github.com/users/darribas/events{/privacy}","received_events_url":"https://api.github.com/users/darribas/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/pysal/pysal/pulls/797/commits","review_comments_url":"https://api.github.com/repos/pysal/pysal/pulls/797/comments","review_comment_url":"https://api.github.com/repos/pysal/pysal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pysal/pysal/issues/797/comments","statuses_url":"https://api.github.com/repos/pysal/pysal/statuses/6da47d169b5d14cf5d35592c41601653f4cc11b7","head":{"label":"Makosak:master","ref":"master","sha":"6da47d169b5d14cf5d35592c41601653f4cc11b7","user":{"login":"Makosak","id":4277692,"avatar_url":"https://avatars.githubusercontent.com/u/4277692?v=3","gravatar_id":"","url":"https://api.github.com/users/Makosak","html_url":"https://github.com/Makosak","followers_url":"https://api.github.com/users/Makosak/followers","following_url":"https://api.github.com/users/Makosak/following{/other_user}","gists_url":"https://api.github.com/users/Makosak/gists{/gist_id}","starred_url":"https://api.github.com/users/Makosak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Makosak/subscriptions","organizations_url":"https://api.github.com/users/Makosak/orgs","repos_url":"https://api.github.com/users/Makosak/repos","events_url":"https://api.github.com/users/Makosak/events{/privacy}","received_events_url":"https://api.github.com/users/Makosak/received_events","type":"User","site_admin":false},"repo":{"id":56818045,"name":"pysal","full_name":"Makosak/pysal","owner":{"login":"Makosak","id":4277692,"avatar_url":"https://avatars.githubusercontent.com/u/4277692?v=3","gravatar_id":"","url":"https://api.github.com/users/Makosak","html_url":"https://github.com/Makosak","followers_url":"https://api.github.com/users/Makosak/followers","following_url":"https://api.github.com/users/Makosak/following{/other_user}","gists_url":"https://api.github.com/users/Makosak/gists{/gist_id}","starred_url":"https://api.github.com/users/Makosak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Makosak/subscriptions","organizations_url":"https://api.github.com/users/Makosak/orgs","repos_url":"https://api.github.com/users/Makosak/repos","events_url":"https://api.github.com/users/Makosak/events{/privacy}","received_events_url":"https://api.github.com/users/Makosak/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Makosak/pysal","description":"PySAL is an open source cross-platform library of spatial analysis functions written in Python. It is intended to support the development of high level applications for spatial analysis.","fork":true,"url":"https://api.github.com/repos/Makosak/pysal","forks_url":"https://api.github.com/repos/Makosak/pysal/forks","keys_url":"https://api.github.com/repos/Makosak/pysal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Makosak/pysal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Makosak/pysal/teams","hooks_url":"https://api.github.com/repos/Makosak/pysal/hooks","issue_events_url":"https://api.github.com/repos/Makosak/pysal/issues/events{/number}","events_url":"https://api.github.com/repos/Makosak/pysal/events","assignees_url":"https://api.github.com/repos/Makosak/pysal/assignees{/user}","branches_url":"https://api.github.com/repos/Makosak/pysal/branches{/branch}","tags_url":"https://api.github.com/repos/Makosak/pysal/tags","blobs_url":"https://api.github.com/repos/Makosak/pysal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Makosak/pysal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Makosak/pysal/git/refs{/sha}","trees_url":"https://api.github.com/repos/Makosak/pysal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Makosak/pysal/statuses/{sha}","languages_url":"https://api.github.com/repos/Makosak/pysal/languages","stargazers_url":"https://api.github.com/repos/Makosak/pysal/stargazers","contributors_url":"https://api.github.com/repos/Makosak/pysal/contributors","subscribers_url":"https://api.github.com/repos/Makosak/pysal/subscribers","subscription_url":"https://api.github.com/repos/Makosak/pysal/subscription","commits_url":"https://api.github.com/repos/Makosak/pysal/commits{/sha}","git_commits_url":"https://api.github.com/repos/Makosak/pysal/git/commits{/sha}","comments_url":"https://api.github.com/repos/Makosak/pysal/comments{/number}","issue_comment_url":"https://api.github.com/repos/Makosak/pysal/issues/comments{/number}","contents_url":"https://api.github.com/repos/Makosak/pysal/contents/{+path}","compare_url":"https://api.github.com/repos/Makosak/pysal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Makosak/pysal/merges","archive_url":"https://api.github.com/repos/Makosak/pysal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Makosak/pysal/downloads","issues_url":"https://api.github.com/repos/Makosak/pysal/issues{/number}","pulls_url":"https://api.github.com/repos/Makosak/pysal/pulls{/number}","milestones_url":"https://api.github.com/repos/Makosak/pysal/milestones{/number}","notifications_url":"https://api.github.com/repos/Makosak/pysal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Makosak/pysal/labels{/name}","releases_url":"https://api.github.com/repos/Makosak/pysal/releases{/id}","deployments_url":"https://api.github.com/repos/Makosak/pysal/deployments","created_at":"2016-04-22T01:53:02Z","updated_at":"2016-04-22T01:53:05Z","pushed_at":"2016-05-21T10:39:36Z","git_url":"git://github.com/Makosak/pysal.git","ssh_url":"git@github.com:Makosak/pysal.git","clone_url":"https://github.com/Makosak/pysal.git","svn_url":"https://github.com/Makosak/pysal","homepage":"http://pysal.org","size":41602,"stargazers_count":0,"watchers_count":0,"language":"Jupyter Notebook","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pysal:dev","ref":"dev","sha":"ccc0fa20bb620763ae69cb643f3c4992ccb4baff","user":{"login":"pysal","id":3769919,"avatar_url":"https://avatars.githubusercontent.com/u/3769919?v=3","gravatar_id":"","url":"https://api.github.com/users/pysal","html_url":"https://github.com/pysal","followers_url":"https://api.github.com/users/pysal/followers","following_url":"https://api.github.com/users/pysal/following{/other_user}","gists_url":"https://api.github.com/users/pysal/gists{/gist_id}","starred_url":"https://api.github.com/users/pysal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pysal/subscriptions","organizations_url":"https://api.github.com/users/pysal/orgs","repos_url":"https://api.github.com/users/pysal/repos","events_url":"https://api.github.com/users/pysal/events{/privacy}","received_events_url":"https://api.github.com/users/pysal/received_events","type":"Organization","site_admin":false},"repo":{"id":8295380,"name":"pysal","full_name":"pysal/pysal","owner":{"login":"pysal","id":3769919,"avatar_url":"https://avatars.githubusercontent.com/u/3769919?v=3","gravatar_id":"","url":"https://api.github.com/users/pysal","html_url":"https://github.com/pysal","followers_url":"https://api.github.com/users/pysal/followers","following_url":"https://api.github.com/users/pysal/following{/other_user}","gists_url":"https://api.github.com/users/pysal/gists{/gist_id}","starred_url":"https://api.github.com/users/pysal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pysal/subscriptions","organizations_url":"https://api.github.com/users/pysal/orgs","repos_url":"https://api.github.com/users/pysal/repos","events_url":"https://api.github.com/users/pysal/events{/privacy}","received_events_url":"https://api.github.com/users/pysal/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pysal/pysal","description":"PySAL is an open source cross-platform library of spatial analysis functions written in Python. It is intended to support the development of high level applications for spatial analysis.","fork":false,"url":"https://api.github.com/repos/pysal/pysal","forks_url":"https://api.github.com/repos/pysal/pysal/forks","keys_url":"https://api.github.com/repos/pysal/pysal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pysal/pysal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pysal/pysal/teams","hooks_url":"https://api.github.com/repos/pysal/pysal/hooks","issue_events_url":"https://api.github.com/repos/pysal/pysal/issues/events{/number}","events_url":"https://api.github.com/repos/pysal/pysal/events","assignees_url":"https://api.github.com/repos/pysal/pysal/assignees{/user}","branches_url":"https://api.github.com/repos/pysal/pysal/branches{/branch}","tags_url":"https://api.github.com/repos/pysal/pysal/tags","blobs_url":"https://api.github.com/repos/pysal/pysal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pysal/pysal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pysal/pysal/git/refs{/sha}","trees_url":"https://api.github.com/repos/pysal/pysal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pysal/pysal/statuses/{sha}","languages_url":"https://api.github.com/repos/pysal/pysal/languages","stargazers_url":"https://api.github.com/repos/pysal/pysal/stargazers","contributors_url":"https://api.github.com/repos/pysal/pysal/contributors","subscribers_url":"https://api.github.com/repos/pysal/pysal/subscribers","subscription_url":"https://api.github.com/repos/pysal/pysal/subscription","commits_url":"https://api.github.com/repos/pysal/pysal/commits{/sha}","git_commits_url":"https://api.github.com/repos/pysal/pysal/git/commits{/sha}","comments_url":"https://api.github.com/repos/pysal/pysal/comments{/number}","issue_comment_url":"https://api.github.com/repos/pysal/pysal/issues/comments{/number}","contents_url":"https://api.github.com/repos/pysal/pysal/contents/{+path}","compare_url":"https://api.github.com/repos/pysal/pysal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pysal/pysal/merges","archive_url":"https://api.github.com/repos/pysal/pysal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pysal/pysal/downloads","issues_url":"https://api.github.com/repos/pysal/pysal/issues{/number}","pulls_url":"https://api.github.com/repos/pysal/pysal/pulls{/number}","milestones_url":"https://api.github.com/repos/pysal/pysal/milestones{/number}","notifications_url":"https://api.github.com/repos/pysal/pysal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pysal/pysal/labels{/name}","releases_url":"https://api.github.com/repos/pysal/pysal/releases{/id}","deployments_url":"https://api.github.com/repos/pysal/pysal/deployments","created_at":"2013-02-19T17:27:42Z","updated_at":"2016-05-19T14:51:01Z","pushed_at":"2016-05-22T04:02:18Z","git_url":"git://github.com/pysal/pysal.git","ssh_url":"git@github.com:pysal/pysal.git","clone_url":"https://github.com/pysal/pysal.git","svn_url":"https://github.com/pysal/pysal","homepage":"http://pysal.org","size":57735,"stargazers_count":206,"watchers_count":206,"language":"Jupyter Notebook","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":91,"mirror_url":null,"open_issues_count":68,"forks":91,"open_issues":68,"watchers":206,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pysal/pysal/pulls/797"},"html":{"href":"https://github.com/pysal/pysal/pull/797"},"issue":{"href":"https://api.github.com/repos/pysal/pysal/issues/797"},"comments":{"href":"https://api.github.com/repos/pysal/pysal/issues/797/comments"},"review_comments":{"href":"https://api.github.com/repos/pysal/pysal/pulls/797/comments"},"review_comment":{"href":"https://api.github.com/repos/pysal/pysal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pysal/pysal/pulls/797/commits"},"statuses":{"href":"https://api.github.com/repos/pysal/pysal/statuses/6da47d169b5d14cf5d35592c41601653f4cc11b7"}}}}
{"actor":{"display_login":"Makosak"}}