{"action":"created","comment":{"url":"https://api.github.com/repos/spinnaker/spinnaker/pulls/comments/80385324","id":80385324,"diff_hunk":"@@ -689,7 +689,7 @@ if [[ \"$INSTALL_CASSANDRA\" != \"false\" ]]; then\n fi\n \n ## Packer\n-mkdir /tmp/packer && pushd /tmp/packer\n+mkdir -p /tmp/packer && pushd /tmp/packer","path":"InstallSpinnaker.sh","position":5,"original_position":5,"commit_id":"d8afdbadfa1c2cd22e1d0b656886574a78c6ed3e","original_commit_id":"d8afdbadfa1c2cd22e1d0b656886574a78c6ed3e","user":{"login":"ewiseblatt","id":4367384,"avatar_url":"https://avatars.githubusercontent.com/u/4367384?v=3","gravatar_id":"","url":"https://api.github.com/users/ewiseblatt","html_url":"https://github.com/ewiseblatt","followers_url":"https://api.github.com/users/ewiseblatt/followers","following_url":"https://api.github.com/users/ewiseblatt/following{/other_user}","gists_url":"https://api.github.com/users/ewiseblatt/gists{/gist_id}","starred_url":"https://api.github.com/users/ewiseblatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ewiseblatt/subscriptions","organizations_url":"https://api.github.com/users/ewiseblatt/orgs","repos_url":"https://api.github.com/users/ewiseblatt/repos","events_url":"https://api.github.com/users/ewiseblatt/events{/privacy}","received_events_url":"https://api.github.com/users/ewiseblatt/received_events","type":"User","site_admin":false},"body":"Perhaps this should be something like:\r\n\r\nPACKER_DIR=$(mktemp -d)\r\npushd $PACKER_DIR\r\n..\r\nrm -rf $PACKER_DIR\r\n\r\nAnd I see there are other mkdir calls in this script, which are susceptable to the same issue.\r\nMaybe wrap the whole script in a TEMPDIR=$(mktemp -d installspinnaker.XXXX) up top and rm -rf $TEMPDIR below and have each of the internal mkdir calls (including this) use $TEMPDIR instead of /tmp","created_at":"2016-09-25T15:50:52Z","updated_at":"2016-09-25T15:50:53Z","html_url":"https://github.com/spinnaker/spinnaker/pull/1168#discussion_r80385324","pull_request_url":"https://api.github.com/repos/spinnaker/spinnaker/pulls/1168","_links":{"self":{"href":"https://api.github.com/repos/spinnaker/spinnaker/pulls/comments/80385324"},"html":{"href":"https://github.com/spinnaker/spinnaker/pull/1168#discussion_r80385324"},"pull_request":{"href":"https://api.github.com/repos/spinnaker/spinnaker/pulls/1168"}}},"pull_request":{"url":"https://api.github.com/repos/spinnaker/spinnaker/pulls/1168","id":86615090,"html_url":"https://github.com/spinnaker/spinnaker/pull/1168","diff_url":"https://github.com/spinnaker/spinnaker/pull/1168.diff","patch_url":"https://github.com/spinnaker/spinnaker/pull/1168.patch","issue_url":"https://api.github.com/repos/spinnaker/spinnaker/issues/1168","number":1168,"state":"open","locked":false,"title":"add -p to mkdir to fix errors when re-run Installer","user":{"login":"tony612","id":1253659,"avatar_url":"https://avatars.githubusercontent.com/u/1253659?v=3","gravatar_id":"","url":"https://api.github.com/users/tony612","html_url":"https://github.com/tony612","followers_url":"https://api.github.com/users/tony612/followers","following_url":"https://api.github.com/users/tony612/following{/other_user}","gists_url":"https://api.github.com/users/tony612/gists{/gist_id}","starred_url":"https://api.github.com/users/tony612/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tony612/subscriptions","organizations_url":"https://api.github.com/users/tony612/orgs","repos_url":"https://api.github.com/users/tony612/repos","events_url":"https://api.github.com/users/tony612/events{/privacy}","received_events_url":"https://api.github.com/users/tony612/received_events","type":"User","site_admin":false},"body":"We prefer small, well tested pull requests.\r\n\r\nPlease refer to [Contributing to Spinnaker](http://spinnaker.io/online_docs/community/contributing_guidelines.html) and [On Collaborative Development](http://spinnaker.io/documentation/collab_dev.html).\r\n\r\nWhen filling out a pull request, please consider the following:\r\n\r\n* Provide a descriptive title for your changes.\r\n* If it fixes a bug or resolves a feature request, be sure to link to that issue.\r\n* Add inline code comments to changes that might not be obvious.\r\n* Squash your commits as you keep adding changes.\r\n* Add a comment to @spinnaker/reviewers for review if your issue has been outstanding for more than 3 days. \r\n\r\nNote that we are unlikely to accept pull requests that add features without prior discussion. The best way to propose a feature is to open an issue first and discuss your ideas there before implementing them.\r\n","created_at":"2016-09-24T11:02:00Z","updated_at":"2016-09-25T15:50:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c57eaa85ccea3d53c96518aa4e5b2cbe7983adcb","assignee":{"login":"ewiseblatt","id":4367384,"avatar_url":"https://avatars.githubusercontent.com/u/4367384?v=3","gravatar_id":"","url":"https://api.github.com/users/ewiseblatt","html_url":"https://github.com/ewiseblatt","followers_url":"https://api.github.com/users/ewiseblatt/followers","following_url":"https://api.github.com/users/ewiseblatt/following{/other_user}","gists_url":"https://api.github.com/users/ewiseblatt/gists{/gist_id}","starred_url":"https://api.github.com/users/ewiseblatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ewiseblatt/subscriptions","organizations_url":"https://api.github.com/users/ewiseblatt/orgs","repos_url":"https://api.github.com/users/ewiseblatt/repos","events_url":"https://api.github.com/users/ewiseblatt/events{/privacy}","received_events_url":"https://api.github.com/users/ewiseblatt/received_events","type":"User","site_admin":false},"assignees":[{"login":"ewiseblatt","id":4367384,"avatar_url":"https://avatars.githubusercontent.com/u/4367384?v=3","gravatar_id":"","url":"https://api.github.com/users/ewiseblatt","html_url":"https://github.com/ewiseblatt","followers_url":"https://api.github.com/users/ewiseblatt/followers","following_url":"https://api.github.com/users/ewiseblatt/following{/other_user}","gists_url":"https://api.github.com/users/ewiseblatt/gists{/gist_id}","starred_url":"https://api.github.com/users/ewiseblatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ewiseblatt/subscriptions","organizations_url":"https://api.github.com/users/ewiseblatt/orgs","repos_url":"https://api.github.com/users/ewiseblatt/repos","events_url":"https://api.github.com/users/ewiseblatt/events{/privacy}","received_events_url":"https://api.github.com/users/ewiseblatt/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/spinnaker/spinnaker/pulls/1168/commits","review_comments_url":"https://api.github.com/repos/spinnaker/spinnaker/pulls/1168/comments","review_comment_url":"https://api.github.com/repos/spinnaker/spinnaker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spinnaker/spinnaker/issues/1168/comments","statuses_url":"https://api.github.com/repos/spinnaker/spinnaker/statuses/d8afdbadfa1c2cd22e1d0b656886574a78c6ed3e","head":{"label":"tony612:fix-re-run-install","ref":"fix-re-run-install","sha":"d8afdbadfa1c2cd22e1d0b656886574a78c6ed3e","user":{"login":"tony612","id":1253659,"avatar_url":"https://avatars.githubusercontent.com/u/1253659?v=3","gravatar_id":"","url":"https://api.github.com/users/tony612","html_url":"https://github.com/tony612","followers_url":"https://api.github.com/users/tony612/followers","following_url":"https://api.github.com/users/tony612/following{/other_user}","gists_url":"https://api.github.com/users/tony612/gists{/gist_id}","starred_url":"https://api.github.com/users/tony612/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tony612/subscriptions","organizations_url":"https://api.github.com/users/tony612/orgs","repos_url":"https://api.github.com/users/tony612/repos","events_url":"https://api.github.com/users/tony612/events{/privacy}","received_events_url":"https://api.github.com/users/tony612/received_events","type":"User","site_admin":false},"repo":{"id":69096933,"name":"spinnaker","full_name":"tony612/spinnaker","owner":{"login":"tony612","id":1253659,"avatar_url":"https://avatars.githubusercontent.com/u/1253659?v=3","gravatar_id":"","url":"https://api.github.com/users/tony612","html_url":"https://github.com/tony612","followers_url":"https://api.github.com/users/tony612/followers","following_url":"https://api.github.com/users/tony612/following{/other_user}","gists_url":"https://api.github.com/users/tony612/gists{/gist_id}","starred_url":"https://api.github.com/users/tony612/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tony612/subscriptions","organizations_url":"https://api.github.com/users/tony612/orgs","repos_url":"https://api.github.com/users/tony612/repos","events_url":"https://api.github.com/users/tony612/events{/privacy}","received_events_url":"https://api.github.com/users/tony612/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tony612/spinnaker","description":"Spinnaker is an open source, multi-cloud continuous delivery platform for releasing software changes with high velocity and confidence.","fork":true,"url":"https://api.github.com/repos/tony612/spinnaker","forks_url":"https://api.github.com/repos/tony612/spinnaker/forks","keys_url":"https://api.github.com/repos/tony612/spinnaker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tony612/spinnaker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tony612/spinnaker/teams","hooks_url":"https://api.github.com/repos/tony612/spinnaker/hooks","issue_events_url":"https://api.github.com/repos/tony612/spinnaker/issues/events{/number}","events_url":"https://api.github.com/repos/tony612/spinnaker/events","assignees_url":"https://api.github.com/repos/tony612/spinnaker/assignees{/user}","branches_url":"https://api.github.com/repos/tony612/spinnaker/branches{/branch}","tags_url":"https://api.github.com/repos/tony612/spinnaker/tags","blobs_url":"https://api.github.com/repos/tony612/spinnaker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tony612/spinnaker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tony612/spinnaker/git/refs{/sha}","trees_url":"https://api.github.com/repos/tony612/spinnaker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tony612/spinnaker/statuses/{sha}","languages_url":"https://api.github.com/repos/tony612/spinnaker/languages","stargazers_url":"https://api.github.com/repos/tony612/spinnaker/stargazers","contributors_url":"https://api.github.com/repos/tony612/spinnaker/contributors","subscribers_url":"https://api.github.com/repos/tony612/spinnaker/subscribers","subscription_url":"https://api.github.com/repos/tony612/spinnaker/subscription","commits_url":"https://api.github.com/repos/tony612/spinnaker/commits{/sha}","git_commits_url":"https://api.github.com/repos/tony612/spinnaker/git/commits{/sha}","comments_url":"https://api.github.com/repos/tony612/spinnaker/comments{/number}","issue_comment_url":"https://api.github.com/repos/tony612/spinnaker/issues/comments{/number}","contents_url":"https://api.github.com/repos/tony612/spinnaker/contents/{+path}","compare_url":"https://api.github.com/repos/tony612/spinnaker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tony612/spinnaker/merges","archive_url":"https://api.github.com/repos/tony612/spinnaker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tony612/spinnaker/downloads","issues_url":"https://api.github.com/repos/tony612/spinnaker/issues{/number}","pulls_url":"https://api.github.com/repos/tony612/spinnaker/pulls{/number}","milestones_url":"https://api.github.com/repos/tony612/spinnaker/milestones{/number}","notifications_url":"https://api.github.com/repos/tony612/spinnaker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tony612/spinnaker/labels{/name}","releases_url":"https://api.github.com/repos/tony612/spinnaker/releases{/id}","deployments_url":"https://api.github.com/repos/tony612/spinnaker/deployments","created_at":"2016-09-24T10:57:30Z","updated_at":"2016-09-24T10:57:31Z","pushed_at":"2016-09-24T11:00:25Z","git_url":"git://github.com/tony612/spinnaker.git","ssh_url":"git@github.com:tony612/spinnaker.git","clone_url":"https://github.com/tony612/spinnaker.git","svn_url":"https://github.com/tony612/spinnaker","homepage":"","size":1481,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spinnaker:master","ref":"master","sha":"aafb50b2931f54c4ebb6fb6a1457a8e5d8e0a296","user":{"login":"spinnaker","id":7634182,"avatar_url":"https://avatars.githubusercontent.com/u/7634182?v=3","gravatar_id":"","url":"https://api.github.com/users/spinnaker","html_url":"https://github.com/spinnaker","followers_url":"https://api.github.com/users/spinnaker/followers","following_url":"https://api.github.com/users/spinnaker/following{/other_user}","gists_url":"https://api.github.com/users/spinnaker/gists{/gist_id}","starred_url":"https://api.github.com/users/spinnaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spinnaker/subscriptions","organizations_url":"https://api.github.com/users/spinnaker/orgs","repos_url":"https://api.github.com/users/spinnaker/repos","events_url":"https://api.github.com/users/spinnaker/events{/privacy}","received_events_url":"https://api.github.com/users/spinnaker/received_events","type":"Organization","site_admin":false},"repo":{"id":21436816,"name":"spinnaker","full_name":"spinnaker/spinnaker","owner":{"login":"spinnaker","id":7634182,"avatar_url":"https://avatars.githubusercontent.com/u/7634182?v=3","gravatar_id":"","url":"https://api.github.com/users/spinnaker","html_url":"https://github.com/spinnaker","followers_url":"https://api.github.com/users/spinnaker/followers","following_url":"https://api.github.com/users/spinnaker/following{/other_user}","gists_url":"https://api.github.com/users/spinnaker/gists{/gist_id}","starred_url":"https://api.github.com/users/spinnaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spinnaker/subscriptions","organizations_url":"https://api.github.com/users/spinnaker/orgs","repos_url":"https://api.github.com/users/spinnaker/repos","events_url":"https://api.github.com/users/spinnaker/events{/privacy}","received_events_url":"https://api.github.com/users/spinnaker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spinnaker/spinnaker","description":"Spinnaker is an open source, multi-cloud continuous delivery platform for releasing software changes with high velocity and confidence.","fork":false,"url":"https://api.github.com/repos/spinnaker/spinnaker","forks_url":"https://api.github.com/repos/spinnaker/spinnaker/forks","keys_url":"https://api.github.com/repos/spinnaker/spinnaker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spinnaker/spinnaker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spinnaker/spinnaker/teams","hooks_url":"https://api.github.com/repos/spinnaker/spinnaker/hooks","issue_events_url":"https://api.github.com/repos/spinnaker/spinnaker/issues/events{/number}","events_url":"https://api.github.com/repos/spinnaker/spinnaker/events","assignees_url":"https://api.github.com/repos/spinnaker/spinnaker/assignees{/user}","branches_url":"https://api.github.com/repos/spinnaker/spinnaker/branches{/branch}","tags_url":"https://api.github.com/repos/spinnaker/spinnaker/tags","blobs_url":"https://api.github.com/repos/spinnaker/spinnaker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spinnaker/spinnaker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spinnaker/spinnaker/git/refs{/sha}","trees_url":"https://api.github.com/repos/spinnaker/spinnaker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spinnaker/spinnaker/statuses/{sha}","languages_url":"https://api.github.com/repos/spinnaker/spinnaker/languages","stargazers_url":"https://api.github.com/repos/spinnaker/spinnaker/stargazers","contributors_url":"https://api.github.com/repos/spinnaker/spinnaker/contributors","subscribers_url":"https://api.github.com/repos/spinnaker/spinnaker/subscribers","subscription_url":"https://api.github.com/repos/spinnaker/spinnaker/subscription","commits_url":"https://api.github.com/repos/spinnaker/spinnaker/commits{/sha}","git_commits_url":"https://api.github.com/repos/spinnaker/spinnaker/git/commits{/sha}","comments_url":"https://api.github.com/repos/spinnaker/spinnaker/comments{/number}","issue_comment_url":"https://api.github.com/repos/spinnaker/spinnaker/issues/comments{/number}","contents_url":"https://api.github.com/repos/spinnaker/spinnaker/contents/{+path}","compare_url":"https://api.github.com/repos/spinnaker/spinnaker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spinnaker/spinnaker/merges","archive_url":"https://api.github.com/repos/spinnaker/spinnaker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spinnaker/spinnaker/downloads","issues_url":"https://api.github.com/repos/spinnaker/spinnaker/issues{/number}","pulls_url":"https://api.github.com/repos/spinnaker/spinnaker/pulls{/number}","milestones_url":"https://api.github.com/repos/spinnaker/spinnaker/milestones{/number}","notifications_url":"https://api.github.com/repos/spinnaker/spinnaker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spinnaker/spinnaker/labels{/name}","releases_url":"https://api.github.com/repos/spinnaker/spinnaker/releases{/id}","deployments_url":"https://api.github.com/repos/spinnaker/spinnaker/deployments","created_at":"2014-07-02T19:02:36Z","updated_at":"2016-09-24T07:32:29Z","pushed_at":"2016-09-24T11:02:00Z","git_url":"git://github.com/spinnaker/spinnaker.git","ssh_url":"git@github.com:spinnaker/spinnaker.git","clone_url":"https://github.com/spinnaker/spinnaker.git","svn_url":"https://github.com/spinnaker/spinnaker","homepage":"","size":3172,"stargazers_count":2362,"watchers_count":2362,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":314,"mirror_url":null,"open_issues_count":135,"forks":314,"open_issues":135,"watchers":2362,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spinnaker/spinnaker/pulls/1168"},"html":{"href":"https://github.com/spinnaker/spinnaker/pull/1168"},"issue":{"href":"https://api.github.com/repos/spinnaker/spinnaker/issues/1168"},"comments":{"href":"https://api.github.com/repos/spinnaker/spinnaker/issues/1168/comments"},"review_comments":{"href":"https://api.github.com/repos/spinnaker/spinnaker/pulls/1168/comments"},"review_comment":{"href":"https://api.github.com/repos/spinnaker/spinnaker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spinnaker/spinnaker/pulls/1168/commits"},"statuses":{"href":"https://api.github.com/repos/spinnaker/spinnaker/statuses/d8afdbadfa1c2cd22e1d0b656886574a78c6ed3e"}}}}
{"actor":{"display_login":"ewiseblatt"}}