{"action":"created","issue":{"url":"https://api.github.com/repos/telegramdesktop/tdesktop/issues/2350","repository_url":"https://api.github.com/repos/telegramdesktop/tdesktop","labels_url":"https://api.github.com/repos/telegramdesktop/tdesktop/issues/2350/labels{/name}","comments_url":"https://api.github.com/repos/telegramdesktop/tdesktop/issues/2350/comments","events_url":"https://api.github.com/repos/telegramdesktop/tdesktop/issues/2350/events","html_url":"https://github.com/telegramdesktop/tdesktop/issues/2350","id":170740068,"number":2350,"title":"Dll hijacking with COMBASE.DLL","user":{"login":"FILIPEXOLIVEIRA","id":17012809,"avatar_url":"https://avatars.githubusercontent.com/u/17012809?v=3","gravatar_id":"","url":"https://api.github.com/users/FILIPEXOLIVEIRA","html_url":"https://github.com/FILIPEXOLIVEIRA","followers_url":"https://api.github.com/users/FILIPEXOLIVEIRA/followers","following_url":"https://api.github.com/users/FILIPEXOLIVEIRA/following{/other_user}","gists_url":"https://api.github.com/users/FILIPEXOLIVEIRA/gists{/gist_id}","starred_url":"https://api.github.com/users/FILIPEXOLIVEIRA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FILIPEXOLIVEIRA/subscriptions","organizations_url":"https://api.github.com/users/FILIPEXOLIVEIRA/orgs","repos_url":"https://api.github.com/users/FILIPEXOLIVEIRA/repos","events_url":"https://api.github.com/users/FILIPEXOLIVEIRA/events{/privacy}","received_events_url":"https://api.github.com/users/FILIPEXOLIVEIRA/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-08-11T20:36:59Z","updated_at":"2016-08-13T08:47:56Z","closed_at":null,"body":"Telegram Desktop version 0.10.1 is vulnerable to DLL Hijack, it tries to load \"COMBASE.dll\" without supplying the absolute path, thus relying upon the presence of such DLL on the system directory.\r\n\r\nThe issue is aggravated on Windows 7 because the DLL is not present, resulting in an exploitable DLL Hijack vulnerability, even tho the SafeDllSerchMode flag is enabled.\r\n\r\nI have tested on 3 distinct Windows 7 installations, and none of them ships the COMBASE.dll. I cant confirm why or on what circumstances the dll is/isnt available on Windows 7. But a patch to the LoadLibrary call, made by Telegram Desktop, supplying \"C:\\Windows\\system32\\COMBASE.dll\" should mitigate the issue on the vulnerable scenarios.\r\n\r\nOn Windows 10 however, the dll is present in the system32 directory."},"comment":{"url":"https://api.github.com/repos/telegramdesktop/tdesktop/issues/comments/239610475","html_url":"https://github.com/telegramdesktop/tdesktop/issues/2350#issuecomment-239610475","issue_url":"https://api.github.com/repos/telegramdesktop/tdesktop/issues/2350","id":239610475,"user":{"login":"john-preston","id":17900494,"avatar_url":"https://avatars.githubusercontent.com/u/17900494?v=3","gravatar_id":"","url":"https://api.github.com/users/john-preston","html_url":"https://github.com/john-preston","followers_url":"https://api.github.com/users/john-preston/followers","following_url":"https://api.github.com/users/john-preston/following{/other_user}","gists_url":"https://api.github.com/users/john-preston/gists{/gist_id}","starred_url":"https://api.github.com/users/john-preston/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/john-preston/subscriptions","organizations_url":"https://api.github.com/users/john-preston/orgs","repos_url":"https://api.github.com/users/john-preston/repos","events_url":"https://api.github.com/users/john-preston/events{/privacy}","received_events_url":"https://api.github.com/users/john-preston/received_events","type":"User","site_admin":false},"created_at":"2016-08-13T08:47:56Z","updated_at":"2016-08-13T08:47:56Z","body":"@FILIPEXOLIVEIRA I can't find any of those loading in tdesktop code."}}
{"actor":{"display_login":"john-preston"}}