{"action":"closed","number":10425,"pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/10425","id":69691196,"html_url":"https://github.com/joomla/joomla-cms/pull/10425","diff_url":"https://github.com/joomla/joomla-cms/pull/10425.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/10425.patch","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/10425","number":10425,"state":"closed","locked":false,"title":"[com_config] Error?/Success? messages on save","user":{"login":"andrepereiradasilva","id":9630530,"avatar_url":"https://avatars.githubusercontent.com/u/9630530?v=3","gravatar_id":"","url":"https://api.github.com/users/andrepereiradasilva","html_url":"https://github.com/andrepereiradasilva","followers_url":"https://api.github.com/users/andrepereiradasilva/followers","following_url":"https://api.github.com/users/andrepereiradasilva/following{/other_user}","gists_url":"https://api.github.com/users/andrepereiradasilva/gists{/gist_id}","starred_url":"https://api.github.com/users/andrepereiradasilva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrepereiradasilva/subscriptions","organizations_url":"https://api.github.com/users/andrepereiradasilva/orgs","repos_url":"https://api.github.com/users/andrepereiradasilva/repos","events_url":"https://api.github.com/users/andrepereiradasilva/events{/privacy}","received_events_url":"https://api.github.com/users/andrepereiradasilva/received_events","type":"User","site_admin":false},"body":"#### Summary of Changes\r\n\r\nIn com_config when we get an error on save (ex: bad session token or no permission) we get a green (aka success) message.\r\n\r\nThis is a bad UX problem:\r\n- Green messages are for success\r\n- Blue messages are for information\r\n- Yellow messages are for warnings\r\n- Red messages are for errors or very importing stuff\r\n\r\nThis PR corrects that.\r\n\r\n#### Testing Instructions\r\n\r\nCode review, or, for instance:\r\n1.  (browser Tab 1) Go to global config form, don't save\r\n2.  (browser Tab 2) Open a new browser tab, go to backend, logout and login again\r\n3. (browser Tab 1) Press \"Save\" or \"Save and Close\" in the global config to save.\r\n4. You'll notice you get and invalid token message and the message is green and from a user perspective it's associated with action success.\r\n ![image](https://cloud.githubusercontent.com/assets/9630530/15186255/34de2070-1794-11e6-9482-ffc8377ee40c.png)\r\n5. Apply patch, repeat process 1 to 3. Now the message is red.\r\n ![image](https://cloud.githubusercontent.com/assets/9630530/15186223/1813023a-1794-11e6-9c3d-9491e1c71ade.png)","created_at":"2016-05-11T15:21:49Z","updated_at":"2016-05-16T16:03:32Z","closed_at":"2016-05-16T16:03:31Z","merged_at":"2016-05-16T16:03:31Z","merge_commit_sha":"09b624cd9cbd95bf9d12b2b5e15c75240fa2b9c5","assignee":null,"milestone":{"url":"https://api.github.com/repos/joomla/joomla-cms/milestones/12","html_url":"https://github.com/joomla/joomla-cms/milestones/Joomla%203.6.0","labels_url":"https://api.github.com/repos/joomla/joomla-cms/milestones/12/labels","id":1360635,"number":12,"title":"Joomla 3.6.0","description":"","creator":{"login":"roland-d","id":359377,"avatar_url":"https://avatars.githubusercontent.com/u/359377?v=3","gravatar_id":"","url":"https://api.github.com/users/roland-d","html_url":"https://github.com/roland-d","followers_url":"https://api.github.com/users/roland-d/followers","following_url":"https://api.github.com/users/roland-d/following{/other_user}","gists_url":"https://api.github.com/users/roland-d/gists{/gist_id}","starred_url":"https://api.github.com/users/roland-d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roland-d/subscriptions","organizations_url":"https://api.github.com/users/roland-d/orgs","repos_url":"https://api.github.com/users/roland-d/repos","events_url":"https://api.github.com/users/roland-d/events{/privacy}","received_events_url":"https://api.github.com/users/roland-d/received_events","type":"User","site_admin":false},"open_issues":28,"closed_issues":548,"state":"open","created_at":"2015-10-17T07:57:38Z","updated_at":"2016-05-16T16:03:31Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/10425/commits","review_comments_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/10425/comments","review_comment_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/10425/comments","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/d7b3fdbb15feca337bb27df643a939c089ea05fb","head":{"label":"andrepereiradasilva:com_config-save-messages-ux","ref":"com_config-save-messages-ux","sha":"d7b3fdbb15feca337bb27df643a939c089ea05fb","user":{"login":"andrepereiradasilva","id":9630530,"avatar_url":"https://avatars.githubusercontent.com/u/9630530?v=3","gravatar_id":"","url":"https://api.github.com/users/andrepereiradasilva","html_url":"https://github.com/andrepereiradasilva","followers_url":"https://api.github.com/users/andrepereiradasilva/followers","following_url":"https://api.github.com/users/andrepereiradasilva/following{/other_user}","gists_url":"https://api.github.com/users/andrepereiradasilva/gists{/gist_id}","starred_url":"https://api.github.com/users/andrepereiradasilva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrepereiradasilva/subscriptions","organizations_url":"https://api.github.com/users/andrepereiradasilva/orgs","repos_url":"https://api.github.com/users/andrepereiradasilva/repos","events_url":"https://api.github.com/users/andrepereiradasilva/events{/privacy}","received_events_url":"https://api.github.com/users/andrepereiradasilva/received_events","type":"User","site_admin":false},"repo":{"id":46170295,"name":"joomla-cms","full_name":"andrepereiradasilva/joomla-cms","owner":{"login":"andrepereiradasilva","id":9630530,"avatar_url":"https://avatars.githubusercontent.com/u/9630530?v=3","gravatar_id":"","url":"https://api.github.com/users/andrepereiradasilva","html_url":"https://github.com/andrepereiradasilva","followers_url":"https://api.github.com/users/andrepereiradasilva/followers","following_url":"https://api.github.com/users/andrepereiradasilva/following{/other_user}","gists_url":"https://api.github.com/users/andrepereiradasilva/gists{/gist_id}","starred_url":"https://api.github.com/users/andrepereiradasilva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrepereiradasilva/subscriptions","organizations_url":"https://api.github.com/users/andrepereiradasilva/orgs","repos_url":"https://api.github.com/users/andrepereiradasilva/repos","events_url":"https://api.github.com/users/andrepereiradasilva/events{/privacy}","received_events_url":"https://api.github.com/users/andrepereiradasilva/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andrepereiradasilva/joomla-cms","description":"Home of the Joomla! Content Management System","fork":true,"url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms","forks_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/forks","keys_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/teams","hooks_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/events","assignees_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/tags","blobs_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/subscription","commits_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/merges","archive_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/downloads","issues_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/releases{/id}","deployments_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/deployments","created_at":"2015-11-14T10:22:32Z","updated_at":"2016-03-03T00:12:42Z","pushed_at":"2016-05-16T15:05:15Z","git_url":"git://github.com/andrepereiradasilva/joomla-cms.git","ssh_url":"git@github.com:andrepereiradasilva/joomla-cms.git","clone_url":"https://github.com/andrepereiradasilva/joomla-cms.git","svn_url":"https://github.com/andrepereiradasilva/joomla-cms","homepage":"https://www.joomla.org","size":148647,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":15,"forks":0,"open_issues":15,"watchers":0,"default_branch":"staging"}},"base":{"label":"joomla:staging","ref":"staging","sha":"d9234b7e8050c2f55b90f0f38a456bd62cc77c44","user":{"login":"joomla","id":751633,"avatar_url":"https://avatars.githubusercontent.com/u/751633?v=3","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"repo":{"id":2464908,"name":"joomla-cms","full_name":"joomla/joomla-cms","owner":{"login":"joomla","id":751633,"avatar_url":"https://avatars.githubusercontent.com/u/751633?v=3","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/joomla/joomla-cms","description":"Home of the Joomla! Content Management System","fork":false,"url":"https://api.github.com/repos/joomla/joomla-cms","forks_url":"https://api.github.com/repos/joomla/joomla-cms/forks","keys_url":"https://api.github.com/repos/joomla/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joomla/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joomla/joomla-cms/teams","hooks_url":"https://api.github.com/repos/joomla/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/joomla/joomla-cms/events","assignees_url":"https://api.github.com/repos/joomla/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/joomla/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/joomla/joomla-cms/tags","blobs_url":"https://api.github.com/repos/joomla/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joomla/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joomla/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/joomla/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/joomla/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/joomla/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/joomla/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/joomla/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/joomla/joomla-cms/subscription","commits_url":"https://api.github.com/repos/joomla/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/joomla/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/joomla/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/joomla/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joomla/joomla-cms/merges","archive_url":"https://api.github.com/repos/joomla/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joomla/joomla-cms/downloads","issues_url":"https://api.github.com/repos/joomla/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/joomla/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/joomla/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/joomla/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joomla/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/joomla/joomla-cms/releases{/id}","deployments_url":"https://api.github.com/repos/joomla/joomla-cms/deployments","created_at":"2011-09-27T02:07:38Z","updated_at":"2016-05-16T02:25:50Z","pushed_at":"2016-05-16T16:03:31Z","git_url":"git://github.com/joomla/joomla-cms.git","ssh_url":"git@github.com:joomla/joomla-cms.git","clone_url":"https://github.com/joomla/joomla-cms.git","svn_url":"https://github.com/joomla/joomla-cms","homepage":"https://www.joomla.org","size":277894,"stargazers_count":2009,"watchers_count":2009,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2164,"mirror_url":null,"open_issues_count":388,"forks":2164,"open_issues":388,"watchers":2009,"default_branch":"staging"}},"_links":{"self":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/10425"},"html":{"href":"https://github.com/joomla/joomla-cms/pull/10425"},"issue":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/10425"},"comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/10425/comments"},"review_comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/10425/comments"},"review_comment":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/10425/commits"},"statuses":{"href":"https://api.github.com/repos/joomla/joomla-cms/statuses/d7b3fdbb15feca337bb27df643a939c089ea05fb"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"rdeutz","id":467356,"avatar_url":"https://avatars.githubusercontent.com/u/467356?v=3","gravatar_id":"","url":"https://api.github.com/users/rdeutz","html_url":"https://github.com/rdeutz","followers_url":"https://api.github.com/users/rdeutz/followers","following_url":"https://api.github.com/users/rdeutz/following{/other_user}","gists_url":"https://api.github.com/users/rdeutz/gists{/gist_id}","starred_url":"https://api.github.com/users/rdeutz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdeutz/subscriptions","organizations_url":"https://api.github.com/users/rdeutz/orgs","repos_url":"https://api.github.com/users/rdeutz/repos","events_url":"https://api.github.com/users/rdeutz/events{/privacy}","received_events_url":"https://api.github.com/users/rdeutz/received_events","type":"User","site_admin":false},"comments":9,"review_comments":0,"commits":3,"additions":6,"deletions":6,"changed_files":2}}