{"action":"created","comment":{"url":"https://api.github.com/repos/cubing/worldcubeassociation.org/pulls/comments/57084634","id":57084634,"diff_hunk":"@@ -293,6 +283,30 @@ def after_confirmation\n     end\n   end\n \n+  def software_team?\n+    team_member?('software')\n+  end\n+\n+  def results_team?\n+    team_member?('results')\n+  end\n+\n+  def wrc_team?\n+    team_member?('wrc')\n+  end\n+\n+  def wdc_team?\n+    team_member?('wdc')\n+  end\n+\n+  def team_member?(team)\n+    self.team_members.where(team_id: ( self.teams.find_by_friendly_id(team) ) ).any?(&:current_member?)\n+  end\n+\n+  def team_leader?(team)","path":"WcaOnRails/app/models/user.rb","position":64,"original_position":64,"commit_id":"2050f63d8d65bdf0aa5d0e99c22c0b378bf6ee11","original_commit_id":"2050f63d8d65bdf0aa5d0e99c22c0b378bf6ee11","user":{"login":"jfly","id":277474,"avatar_url":"https://avatars.githubusercontent.com/u/277474?v=3","gravatar_id":"","url":"https://api.github.com/users/jfly","html_url":"https://github.com/jfly","followers_url":"https://api.github.com/users/jfly/followers","following_url":"https://api.github.com/users/jfly/following{/other_user}","gists_url":"https://api.github.com/users/jfly/gists{/gist_id}","starred_url":"https://api.github.com/users/jfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfly/subscriptions","organizations_url":"https://api.github.com/users/jfly/orgs","repos_url":"https://api.github.com/users/jfly/repos","events_url":"https://api.github.com/users/jfly/events{/privacy}","received_events_url":"https://api.github.com/users/jfly/received_events","type":"User","site_admin":false},"body":"I feel that argument should be `team_friendly_id`, not `team.","created_at":"2016-03-22T22:59:38Z","updated_at":"2016-03-22T22:59:38Z","html_url":"https://github.com/cubing/worldcubeassociation.org/pull/390#discussion_r57084634","pull_request_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/pulls/390","_links":{"self":{"href":"https://api.github.com/repos/cubing/worldcubeassociation.org/pulls/comments/57084634"},"html":{"href":"https://github.com/cubing/worldcubeassociation.org/pull/390#discussion_r57084634"},"pull_request":{"href":"https://api.github.com/repos/cubing/worldcubeassociation.org/pulls/390"}}},"pull_request":{"url":"https://api.github.com/repos/cubing/worldcubeassociation.org/pulls/390","id":59887704,"html_url":"https://github.com/cubing/worldcubeassociation.org/pull/390","diff_url":"https://github.com/cubing/worldcubeassociation.org/pull/390.diff","patch_url":"https://github.com/cubing/worldcubeassociation.org/pull/390.patch","issue_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/issues/390","number":390,"state":"open","locked":false,"title":"Move teams to separate tables","user":{"login":"pedrosino","id":1881933,"avatar_url":"https://avatars.githubusercontent.com/u/1881933?v=3","gravatar_id":"","url":"https://api.github.com/users/pedrosino","html_url":"https://github.com/pedrosino","followers_url":"https://api.github.com/users/pedrosino/followers","following_url":"https://api.github.com/users/pedrosino/following{/other_user}","gists_url":"https://api.github.com/users/pedrosino/gists{/gist_id}","starred_url":"https://api.github.com/users/pedrosino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pedrosino/subscriptions","organizations_url":"https://api.github.com/users/pedrosino/orgs","repos_url":"https://api.github.com/users/pedrosino/repos","events_url":"https://api.github.com/users/pedrosino/events{/privacy}","received_events_url":"https://api.github.com/users/pedrosino/received_events","type":"User","site_admin":false},"body":"Fixes #185 \r\n\r\nThis is not done yet. Please alert me if I'm going into some wrong direction.\r\n\r\nWe have to consider also moving delegates to a \"team\" table. This could be tricky, because we have 4 types of them...\r\n\r\nThings to do:\r\n- [x] have the members be selected similar to how you select delegate(s) for a competition\r\n- [x] better styling on the member form (inline?)\r\n- [x] activate the datepicker and autocomplete when adding a new member\r\n- [x] migration to remove the old fields\r\n- [x] fix all the some_team? and can_something?\r\n\r\nFor the first one, I tried using as: :user_ids, only_one: true but it is trying to split the numeric id...","created_at":"2016-02-19T00:38:14Z","updated_at":"2016-03-22T22:59:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"44430bbe2a224e14ffc9ac4f67c0d4b33909079a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/pulls/390/commits","review_comments_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/pulls/390/comments","review_comment_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/issues/390/comments","statuses_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/statuses/2050f63d8d65bdf0aa5d0e99c22c0b378bf6ee11","head":{"label":"pedrosino:teams","ref":"teams","sha":"2050f63d8d65bdf0aa5d0e99c22c0b378bf6ee11","user":{"login":"pedrosino","id":1881933,"avatar_url":"https://avatars.githubusercontent.com/u/1881933?v=3","gravatar_id":"","url":"https://api.github.com/users/pedrosino","html_url":"https://github.com/pedrosino","followers_url":"https://api.github.com/users/pedrosino/followers","following_url":"https://api.github.com/users/pedrosino/following{/other_user}","gists_url":"https://api.github.com/users/pedrosino/gists{/gist_id}","starred_url":"https://api.github.com/users/pedrosino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pedrosino/subscriptions","organizations_url":"https://api.github.com/users/pedrosino/orgs","repos_url":"https://api.github.com/users/pedrosino/repos","events_url":"https://api.github.com/users/pedrosino/events{/privacy}","received_events_url":"https://api.github.com/users/pedrosino/received_events","type":"User","site_admin":false},"repo":{"id":45578783,"name":"worldcubeassociation.org","full_name":"pedrosino/worldcubeassociation.org","owner":{"login":"pedrosino","id":1881933,"avatar_url":"https://avatars.githubusercontent.com/u/1881933?v=3","gravatar_id":"","url":"https://api.github.com/users/pedrosino","html_url":"https://github.com/pedrosino","followers_url":"https://api.github.com/users/pedrosino/followers","following_url":"https://api.github.com/users/pedrosino/following{/other_user}","gists_url":"https://api.github.com/users/pedrosino/gists{/gist_id}","starred_url":"https://api.github.com/users/pedrosino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pedrosino/subscriptions","organizations_url":"https://api.github.com/users/pedrosino/orgs","repos_url":"https://api.github.com/users/pedrosino/repos","events_url":"https://api.github.com/users/pedrosino/events{/privacy}","received_events_url":"https://api.github.com/users/pedrosino/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pedrosino/worldcubeassociation.org","description":"[WCA Project] All of the code that runs on worldcubeassociation.org","fork":true,"url":"https://api.github.com/repos/pedrosino/worldcubeassociation.org","forks_url":"https://api.github.com/repos/pedrosino/worldcubeassociation.org/forks","keys_url":"https://api.github.com/repos/pedrosino/worldcubeassociation.org/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pedrosino/worldcubeassociation.org/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pedrosino/worldcubeassociation.org/teams","hooks_url":"https://api.github.com/repos/pedrosino/worldcubeassociation.org/hooks","issue_events_url":"https://api.github.com/repos/pedrosino/worldcubeassociation.org/issues/events{/number}","events_url":"https://api.github.com/repos/pedrosino/worldcubeassociation.org/events","assignees_url":"https://api.github.com/repos/pedrosino/worldcubeassociation.org/assignees{/user}","branches_url":"https://api.github.com/repos/pedrosino/worldcubeassociation.org/branches{/branch}","tags_url":"https://api.github.com/repos/pedrosino/worldcubeassociation.org/tags","blobs_url":"https://api.github.com/repos/pedrosino/worldcubeassociation.org/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pedrosino/worldcubeassociation.org/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pedrosino/worldcubeassociation.org/git/refs{/sha}","trees_url":"https://api.github.com/repos/pedrosino/worldcubeassociation.org/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pedrosino/worldcubeassociation.org/statuses/{sha}","languages_url":"https://api.github.com/repos/pedrosino/worldcubeassociation.org/languages","stargazers_url":"https://api.github.com/repos/pedrosino/worldcubeassociation.org/stargazers","contributors_url":"https://api.github.com/repos/pedrosino/worldcubeassociation.org/contributors","subscribers_url":"https://api.github.com/repos/pedrosino/worldcubeassociation.org/subscribers","subscription_url":"https://api.github.com/repos/pedrosino/worldcubeassociation.org/subscription","commits_url":"https://api.github.com/repos/pedrosino/worldcubeassociation.org/commits{/sha}","git_commits_url":"https://api.github.com/repos/pedrosino/worldcubeassociation.org/git/commits{/sha}","comments_url":"https://api.github.com/repos/pedrosino/worldcubeassociation.org/comments{/number}","issue_comment_url":"https://api.github.com/repos/pedrosino/worldcubeassociation.org/issues/comments{/number}","contents_url":"https://api.github.com/repos/pedrosino/worldcubeassociation.org/contents/{+path}","compare_url":"https://api.github.com/repos/pedrosino/worldcubeassociation.org/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pedrosino/worldcubeassociation.org/merges","archive_url":"https://api.github.com/repos/pedrosino/worldcubeassociation.org/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pedrosino/worldcubeassociation.org/downloads","issues_url":"https://api.github.com/repos/pedrosino/worldcubeassociation.org/issues{/number}","pulls_url":"https://api.github.com/repos/pedrosino/worldcubeassociation.org/pulls{/number}","milestones_url":"https://api.github.com/repos/pedrosino/worldcubeassociation.org/milestones{/number}","notifications_url":"https://api.github.com/repos/pedrosino/worldcubeassociation.org/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pedrosino/worldcubeassociation.org/labels{/name}","releases_url":"https://api.github.com/repos/pedrosino/worldcubeassociation.org/releases{/id}","deployments_url":"https://api.github.com/repos/pedrosino/worldcubeassociation.org/deployments","created_at":"2015-11-05T01:22:31Z","updated_at":"2016-01-11T18:58:19Z","pushed_at":"2016-03-22T22:37:10Z","git_url":"git://github.com/pedrosino/worldcubeassociation.org.git","ssh_url":"git@github.com:pedrosino/worldcubeassociation.org.git","clone_url":"https://github.com/pedrosino/worldcubeassociation.org.git","svn_url":"https://github.com/pedrosino/worldcubeassociation.org","homepage":"https://www.worldcubeassociation.org/","size":51009,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cubing:master","ref":"master","sha":"eebb99599b7ff98a4c25ffb8e2fca889dfefced1","user":{"login":"cubing","id":1092267,"avatar_url":"https://avatars.githubusercontent.com/u/1092267?v=3","gravatar_id":"","url":"https://api.github.com/users/cubing","html_url":"https://github.com/cubing","followers_url":"https://api.github.com/users/cubing/followers","following_url":"https://api.github.com/users/cubing/following{/other_user}","gists_url":"https://api.github.com/users/cubing/gists{/gist_id}","starred_url":"https://api.github.com/users/cubing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cubing/subscriptions","organizations_url":"https://api.github.com/users/cubing/orgs","repos_url":"https://api.github.com/users/cubing/repos","events_url":"https://api.github.com/users/cubing/events{/privacy}","received_events_url":"https://api.github.com/users/cubing/received_events","type":"Organization","site_admin":false},"repo":{"id":34161579,"name":"worldcubeassociation.org","full_name":"cubing/worldcubeassociation.org","owner":{"login":"cubing","id":1092267,"avatar_url":"https://avatars.githubusercontent.com/u/1092267?v=3","gravatar_id":"","url":"https://api.github.com/users/cubing","html_url":"https://github.com/cubing","followers_url":"https://api.github.com/users/cubing/followers","following_url":"https://api.github.com/users/cubing/following{/other_user}","gists_url":"https://api.github.com/users/cubing/gists{/gist_id}","starred_url":"https://api.github.com/users/cubing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cubing/subscriptions","organizations_url":"https://api.github.com/users/cubing/orgs","repos_url":"https://api.github.com/users/cubing/repos","events_url":"https://api.github.com/users/cubing/events{/privacy}","received_events_url":"https://api.github.com/users/cubing/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cubing/worldcubeassociation.org","description":"[WCA Project] All of the code that runs on worldcubeassociation.org","fork":false,"url":"https://api.github.com/repos/cubing/worldcubeassociation.org","forks_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/forks","keys_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/teams","hooks_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/hooks","issue_events_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/issues/events{/number}","events_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/events","assignees_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/assignees{/user}","branches_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/branches{/branch}","tags_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/tags","blobs_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/git/refs{/sha}","trees_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/statuses/{sha}","languages_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/languages","stargazers_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/stargazers","contributors_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/contributors","subscribers_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/subscribers","subscription_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/subscription","commits_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/commits{/sha}","git_commits_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/git/commits{/sha}","comments_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/comments{/number}","issue_comment_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/issues/comments{/number}","contents_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/contents/{+path}","compare_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/merges","archive_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/downloads","issues_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/issues{/number}","pulls_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/pulls{/number}","milestones_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/milestones{/number}","notifications_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/labels{/name}","releases_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/releases{/id}","deployments_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/deployments","created_at":"2015-04-18T10:21:53Z","updated_at":"2016-02-21T14:51:52Z","pushed_at":"2016-03-22T22:37:11Z","git_url":"git://github.com/cubing/worldcubeassociation.org.git","ssh_url":"git@github.com:cubing/worldcubeassociation.org.git","clone_url":"https://github.com/cubing/worldcubeassociation.org.git","svn_url":"https://github.com/cubing/worldcubeassociation.org","homepage":"https://www.worldcubeassociation.org/","size":51201,"stargazers_count":8,"watchers_count":8,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"open_issues_count":145,"forks":20,"open_issues":145,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cubing/worldcubeassociation.org/pulls/390"},"html":{"href":"https://github.com/cubing/worldcubeassociation.org/pull/390"},"issue":{"href":"https://api.github.com/repos/cubing/worldcubeassociation.org/issues/390"},"comments":{"href":"https://api.github.com/repos/cubing/worldcubeassociation.org/issues/390/comments"},"review_comments":{"href":"https://api.github.com/repos/cubing/worldcubeassociation.org/pulls/390/comments"},"review_comment":{"href":"https://api.github.com/repos/cubing/worldcubeassociation.org/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cubing/worldcubeassociation.org/pulls/390/commits"},"statuses":{"href":"https://api.github.com/repos/cubing/worldcubeassociation.org/statuses/2050f63d8d65bdf0aa5d0e99c22c0b378bf6ee11"}}}}