{"action":"created","comment":{"url":"https://api.github.com/repos/Nike-Inc/wingtips/pulls/comments/75570578","id":75570578,"diff_hunk":"@@ -260,6 +260,51 @@ public void fromRequestWithHeaders_sets_sampleable_to_attribute_value_if_sampled\n         assertThat(newSpan.isSampleable()).isFalse();\n     }\n \n+    @DataProvider(value = {","path":"wingtips-core/src/test/java/com/nike/wingtips/http/HttpRequestTracingUtilsTest.java","position":4,"original_position":4,"commit_id":"f037fd2cb5d00e196447cbaa83a39de830394e7b","original_commit_id":"f037fd2cb5d00e196447cbaa83a39de830394e7b","user":{"login":"adriancole","id":64215,"avatar_url":"https://avatars.githubusercontent.com/u/64215?v=3","gravatar_id":"","url":"https://api.github.com/users/adriancole","html_url":"https://github.com/adriancole","followers_url":"https://api.github.com/users/adriancole/followers","following_url":"https://api.github.com/users/adriancole/following{/other_user}","gists_url":"https://api.github.com/users/adriancole/gists{/gist_id}","starred_url":"https://api.github.com/users/adriancole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adriancole/subscriptions","organizations_url":"https://api.github.com/users/adriancole/orgs","repos_url":"https://api.github.com/users/adriancole/repos","events_url":"https://api.github.com/users/adriancole/events{/privacy}","received_events_url":"https://api.github.com/users/adriancole/received_events","type":"User","site_admin":false},"body":"haha how could I have missed that :)\n\nOn Sat, Aug 20, 2016 at 9:52 AM, Nic Munroe <notifications@github.com>\nwrote:\n\n> In wingtips-core/src/test/java/com/nike/wingtips/http/\n> HttpRequestTracingUtilsTest.java\n> <https://github.com/Nike-Inc/wingtips/pull/16#discussion_r75570549>:\n>\n> > @@ -260,6 +260,51 @@ public void fromRequestWithHeaders_sets_sampleable_to_attribute_value_if_sampled\n> >          assertThat(newSpan.isSampleable()).isFalse();\n> >      }\n> >\n> > +    @DataProvider(value = {\n>\n> There's an already-existing test that verifies missing/empty sampled\n> header coerces to true: fromRequestWithHeaders_sets_\n> sampleable_to_true_if_sampled_header_is_null_or_missing_\n> from_both_headers_and_attributes.\n>\n> There's a separate mechanism for determining whether new traces are\n> sampled: RootSpanSamplingStrategy.\n>\n> —\n> You are receiving this because you were mentioned.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/Nike-Inc/wingtips/pull/16/files/f037fd2cb5d00e196447cbaa83a39de830394e7b#r75570549>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/AAD612lNDUkV8E3uWSG7OylxgCSdno1Tks5qhl3XgaJpZM4Jo1BS>\n> .\n>\n","created_at":"2016-08-20T01:53:37Z","updated_at":"2016-08-20T01:53:37Z","html_url":"https://github.com/Nike-Inc/wingtips/pull/16#discussion_r75570578","pull_request_url":"https://api.github.com/repos/Nike-Inc/wingtips/pulls/16","_links":{"self":{"href":"https://api.github.com/repos/Nike-Inc/wingtips/pulls/comments/75570578"},"html":{"href":"https://github.com/Nike-Inc/wingtips/pull/16#discussion_r75570578"},"pull_request":{"href":"https://api.github.com/repos/Nike-Inc/wingtips/pulls/16"}}},"pull_request":{"url":"https://api.github.com/repos/Nike-Inc/wingtips/pulls/16","id":82041375,"html_url":"https://github.com/Nike-Inc/wingtips/pull/16","diff_url":"https://github.com/Nike-Inc/wingtips/pull/16.diff","patch_url":"https://github.com/Nike-Inc/wingtips/pull/16.patch","issue_url":"https://api.github.com/repos/Nike-Inc/wingtips/issues/16","number":16,"state":"open","locked":false,"title":"Feature/zipkin compatibility","user":{"login":"nicmunroe","id":15578205,"avatar_url":"https://avatars.githubusercontent.com/u/15578205?v=3","gravatar_id":"","url":"https://api.github.com/users/nicmunroe","html_url":"https://github.com/nicmunroe","followers_url":"https://api.github.com/users/nicmunroe/followers","following_url":"https://api.github.com/users/nicmunroe/following{/other_user}","gists_url":"https://api.github.com/users/nicmunroe/gists{/gist_id}","starred_url":"https://api.github.com/users/nicmunroe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicmunroe/subscriptions","organizations_url":"https://api.github.com/users/nicmunroe/orgs","repos_url":"https://api.github.com/users/nicmunroe/repos","events_url":"https://api.github.com/users/nicmunroe/events{/privacy}","received_events_url":"https://api.github.com/users/nicmunroe/received_events","type":"User","site_admin":false},"body":"This should fix issues #14 and #15.","created_at":"2016-08-19T20:31:39Z","updated_at":"2016-08-20T01:53:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dda041d46556eef05ebd6c0d5645d6ca46e2aac1","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Nike-Inc/wingtips/pulls/16/commits","review_comments_url":"https://api.github.com/repos/Nike-Inc/wingtips/pulls/16/comments","review_comment_url":"https://api.github.com/repos/Nike-Inc/wingtips/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Nike-Inc/wingtips/issues/16/comments","statuses_url":"https://api.github.com/repos/Nike-Inc/wingtips/statuses/f037fd2cb5d00e196447cbaa83a39de830394e7b","head":{"label":"nicmunroe:feature/zipkin-compatibility","ref":"feature/zipkin-compatibility","sha":"f037fd2cb5d00e196447cbaa83a39de830394e7b","user":{"login":"nicmunroe","id":15578205,"avatar_url":"https://avatars.githubusercontent.com/u/15578205?v=3","gravatar_id":"","url":"https://api.github.com/users/nicmunroe","html_url":"https://github.com/nicmunroe","followers_url":"https://api.github.com/users/nicmunroe/followers","following_url":"https://api.github.com/users/nicmunroe/following{/other_user}","gists_url":"https://api.github.com/users/nicmunroe/gists{/gist_id}","starred_url":"https://api.github.com/users/nicmunroe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicmunroe/subscriptions","organizations_url":"https://api.github.com/users/nicmunroe/orgs","repos_url":"https://api.github.com/users/nicmunroe/repos","events_url":"https://api.github.com/users/nicmunroe/events{/privacy}","received_events_url":"https://api.github.com/users/nicmunroe/received_events","type":"User","site_admin":false},"repo":{"id":62107218,"name":"wingtips","full_name":"nicmunroe/wingtips","owner":{"login":"nicmunroe","id":15578205,"avatar_url":"https://avatars.githubusercontent.com/u/15578205?v=3","gravatar_id":"","url":"https://api.github.com/users/nicmunroe","html_url":"https://github.com/nicmunroe","followers_url":"https://api.github.com/users/nicmunroe/followers","following_url":"https://api.github.com/users/nicmunroe/following{/other_user}","gists_url":"https://api.github.com/users/nicmunroe/gists{/gist_id}","starred_url":"https://api.github.com/users/nicmunroe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicmunroe/subscriptions","organizations_url":"https://api.github.com/users/nicmunroe/orgs","repos_url":"https://api.github.com/users/nicmunroe/repos","events_url":"https://api.github.com/users/nicmunroe/events{/privacy}","received_events_url":"https://api.github.com/users/nicmunroe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nicmunroe/wingtips","description":"WingTips is a distributed tracing solution for Java based on the Google Dapper paper.","fork":true,"url":"https://api.github.com/repos/nicmunroe/wingtips","forks_url":"https://api.github.com/repos/nicmunroe/wingtips/forks","keys_url":"https://api.github.com/repos/nicmunroe/wingtips/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nicmunroe/wingtips/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nicmunroe/wingtips/teams","hooks_url":"https://api.github.com/repos/nicmunroe/wingtips/hooks","issue_events_url":"https://api.github.com/repos/nicmunroe/wingtips/issues/events{/number}","events_url":"https://api.github.com/repos/nicmunroe/wingtips/events","assignees_url":"https://api.github.com/repos/nicmunroe/wingtips/assignees{/user}","branches_url":"https://api.github.com/repos/nicmunroe/wingtips/branches{/branch}","tags_url":"https://api.github.com/repos/nicmunroe/wingtips/tags","blobs_url":"https://api.github.com/repos/nicmunroe/wingtips/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nicmunroe/wingtips/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nicmunroe/wingtips/git/refs{/sha}","trees_url":"https://api.github.com/repos/nicmunroe/wingtips/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nicmunroe/wingtips/statuses/{sha}","languages_url":"https://api.github.com/repos/nicmunroe/wingtips/languages","stargazers_url":"https://api.github.com/repos/nicmunroe/wingtips/stargazers","contributors_url":"https://api.github.com/repos/nicmunroe/wingtips/contributors","subscribers_url":"https://api.github.com/repos/nicmunroe/wingtips/subscribers","subscription_url":"https://api.github.com/repos/nicmunroe/wingtips/subscription","commits_url":"https://api.github.com/repos/nicmunroe/wingtips/commits{/sha}","git_commits_url":"https://api.github.com/repos/nicmunroe/wingtips/git/commits{/sha}","comments_url":"https://api.github.com/repos/nicmunroe/wingtips/comments{/number}","issue_comment_url":"https://api.github.com/repos/nicmunroe/wingtips/issues/comments{/number}","contents_url":"https://api.github.com/repos/nicmunroe/wingtips/contents/{+path}","compare_url":"https://api.github.com/repos/nicmunroe/wingtips/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nicmunroe/wingtips/merges","archive_url":"https://api.github.com/repos/nicmunroe/wingtips/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nicmunroe/wingtips/downloads","issues_url":"https://api.github.com/repos/nicmunroe/wingtips/issues{/number}","pulls_url":"https://api.github.com/repos/nicmunroe/wingtips/pulls{/number}","milestones_url":"https://api.github.com/repos/nicmunroe/wingtips/milestones{/number}","notifications_url":"https://api.github.com/repos/nicmunroe/wingtips/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nicmunroe/wingtips/labels{/name}","releases_url":"https://api.github.com/repos/nicmunroe/wingtips/releases{/id}","deployments_url":"https://api.github.com/repos/nicmunroe/wingtips/deployments","created_at":"2016-06-28T03:28:53Z","updated_at":"2016-06-28T03:28:54Z","pushed_at":"2016-08-19T21:08:16Z","git_url":"git://github.com/nicmunroe/wingtips.git","ssh_url":"git@github.com:nicmunroe/wingtips.git","clone_url":"https://github.com/nicmunroe/wingtips.git","svn_url":"https://github.com/nicmunroe/wingtips","homepage":"","size":227,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Nike-Inc:master","ref":"master","sha":"91328ea08351d1ac17bde5d4f9d0721cdc6fa734","user":{"login":"Nike-Inc","id":1435711,"avatar_url":"https://avatars.githubusercontent.com/u/1435711?v=3","gravatar_id":"","url":"https://api.github.com/users/Nike-Inc","html_url":"https://github.com/Nike-Inc","followers_url":"https://api.github.com/users/Nike-Inc/followers","following_url":"https://api.github.com/users/Nike-Inc/following{/other_user}","gists_url":"https://api.github.com/users/Nike-Inc/gists{/gist_id}","starred_url":"https://api.github.com/users/Nike-Inc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nike-Inc/subscriptions","organizations_url":"https://api.github.com/users/Nike-Inc/orgs","repos_url":"https://api.github.com/users/Nike-Inc/repos","events_url":"https://api.github.com/users/Nike-Inc/events{/privacy}","received_events_url":"https://api.github.com/users/Nike-Inc/received_events","type":"Organization","site_admin":false},"repo":{"id":57251243,"name":"wingtips","full_name":"Nike-Inc/wingtips","owner":{"login":"Nike-Inc","id":1435711,"avatar_url":"https://avatars.githubusercontent.com/u/1435711?v=3","gravatar_id":"","url":"https://api.github.com/users/Nike-Inc","html_url":"https://github.com/Nike-Inc","followers_url":"https://api.github.com/users/Nike-Inc/followers","following_url":"https://api.github.com/users/Nike-Inc/following{/other_user}","gists_url":"https://api.github.com/users/Nike-Inc/gists{/gist_id}","starred_url":"https://api.github.com/users/Nike-Inc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nike-Inc/subscriptions","organizations_url":"https://api.github.com/users/Nike-Inc/orgs","repos_url":"https://api.github.com/users/Nike-Inc/repos","events_url":"https://api.github.com/users/Nike-Inc/events{/privacy}","received_events_url":"https://api.github.com/users/Nike-Inc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Nike-Inc/wingtips","description":"WingTips is a distributed tracing solution for Java based on the Google Dapper paper.","fork":false,"url":"https://api.github.com/repos/Nike-Inc/wingtips","forks_url":"https://api.github.com/repos/Nike-Inc/wingtips/forks","keys_url":"https://api.github.com/repos/Nike-Inc/wingtips/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Nike-Inc/wingtips/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Nike-Inc/wingtips/teams","hooks_url":"https://api.github.com/repos/Nike-Inc/wingtips/hooks","issue_events_url":"https://api.github.com/repos/Nike-Inc/wingtips/issues/events{/number}","events_url":"https://api.github.com/repos/Nike-Inc/wingtips/events","assignees_url":"https://api.github.com/repos/Nike-Inc/wingtips/assignees{/user}","branches_url":"https://api.github.com/repos/Nike-Inc/wingtips/branches{/branch}","tags_url":"https://api.github.com/repos/Nike-Inc/wingtips/tags","blobs_url":"https://api.github.com/repos/Nike-Inc/wingtips/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Nike-Inc/wingtips/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Nike-Inc/wingtips/git/refs{/sha}","trees_url":"https://api.github.com/repos/Nike-Inc/wingtips/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Nike-Inc/wingtips/statuses/{sha}","languages_url":"https://api.github.com/repos/Nike-Inc/wingtips/languages","stargazers_url":"https://api.github.com/repos/Nike-Inc/wingtips/stargazers","contributors_url":"https://api.github.com/repos/Nike-Inc/wingtips/contributors","subscribers_url":"https://api.github.com/repos/Nike-Inc/wingtips/subscribers","subscription_url":"https://api.github.com/repos/Nike-Inc/wingtips/subscription","commits_url":"https://api.github.com/repos/Nike-Inc/wingtips/commits{/sha}","git_commits_url":"https://api.github.com/repos/Nike-Inc/wingtips/git/commits{/sha}","comments_url":"https://api.github.com/repos/Nike-Inc/wingtips/comments{/number}","issue_comment_url":"https://api.github.com/repos/Nike-Inc/wingtips/issues/comments{/number}","contents_url":"https://api.github.com/repos/Nike-Inc/wingtips/contents/{+path}","compare_url":"https://api.github.com/repos/Nike-Inc/wingtips/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Nike-Inc/wingtips/merges","archive_url":"https://api.github.com/repos/Nike-Inc/wingtips/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Nike-Inc/wingtips/downloads","issues_url":"https://api.github.com/repos/Nike-Inc/wingtips/issues{/number}","pulls_url":"https://api.github.com/repos/Nike-Inc/wingtips/pulls{/number}","milestones_url":"https://api.github.com/repos/Nike-Inc/wingtips/milestones{/number}","notifications_url":"https://api.github.com/repos/Nike-Inc/wingtips/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Nike-Inc/wingtips/labels{/name}","releases_url":"https://api.github.com/repos/Nike-Inc/wingtips/releases{/id}","deployments_url":"https://api.github.com/repos/Nike-Inc/wingtips/deployments","created_at":"2016-04-27T21:50:02Z","updated_at":"2016-08-18T00:32:54Z","pushed_at":"2016-08-19T21:08:16Z","git_url":"git://github.com/Nike-Inc/wingtips.git","ssh_url":"git@github.com:Nike-Inc/wingtips.git","clone_url":"https://github.com/Nike-Inc/wingtips.git","svn_url":"https://github.com/Nike-Inc/wingtips","homepage":"","size":211,"stargazers_count":195,"watchers_count":195,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":30,"mirror_url":null,"open_issues_count":3,"forks":30,"open_issues":3,"watchers":195,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Nike-Inc/wingtips/pulls/16"},"html":{"href":"https://github.com/Nike-Inc/wingtips/pull/16"},"issue":{"href":"https://api.github.com/repos/Nike-Inc/wingtips/issues/16"},"comments":{"href":"https://api.github.com/repos/Nike-Inc/wingtips/issues/16/comments"},"review_comments":{"href":"https://api.github.com/repos/Nike-Inc/wingtips/pulls/16/comments"},"review_comment":{"href":"https://api.github.com/repos/Nike-Inc/wingtips/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Nike-Inc/wingtips/pulls/16/commits"},"statuses":{"href":"https://api.github.com/repos/Nike-Inc/wingtips/statuses/f037fd2cb5d00e196447cbaa83a39de830394e7b"}}}}
{"actor":{"display_login":"adriancole"}}