{"action":"created","comment":{"url":"https://api.github.com/repos/the-cheaters/up-all-knight/pulls/comments/89651123","pull_request_review_id":10195988,"id":89651123,"diff_hunk":"@@ -11,7 +11,7 @@\n #\n # It's strongly recommended that you check this file into your version control system.\n \n-ActiveRecord::Schema.define(version: 20161118012333) do\n+ActiveRecord::Schema.define(version: 20161115154942) do","path":"db/schema.rb","position":5,"original_position":5,"commit_id":"3e9432f7628131d2a0df6886acbfa9fd55ee114c","original_commit_id":"3e9432f7628131d2a0df6886acbfa9fd55ee114c","user":{"login":"lasley","id":7397578,"avatar_url":"https://avatars.githubusercontent.com/u/7397578?v=3","gravatar_id":"","url":"https://api.github.com/users/lasley","html_url":"https://github.com/lasley","followers_url":"https://api.github.com/users/lasley/followers","following_url":"https://api.github.com/users/lasley/following{/other_user}","gists_url":"https://api.github.com/users/lasley/gists{/gist_id}","starred_url":"https://api.github.com/users/lasley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lasley/subscriptions","organizations_url":"https://api.github.com/users/lasley/orgs","repos_url":"https://api.github.com/users/lasley/repos","events_url":"https://api.github.com/users/lasley/events{/privacy}","received_events_url":"https://api.github.com/users/lasley/received_events","type":"User","site_admin":false},"body":"Might want to watch out when staging files, this will cause conflicts with teammates for no real reason. Admittedly this file is one of my pain points with rails, because rake updates it even if there aren't changes 😦 ","created_at":"2016-11-25T19:12:04Z","updated_at":"2016-11-25T19:15:49Z","html_url":"https://github.com/the-cheaters/up-all-knight/pull/23#discussion_r89651123","pull_request_url":"https://api.github.com/repos/the-cheaters/up-all-knight/pulls/23","_links":{"self":{"href":"https://api.github.com/repos/the-cheaters/up-all-knight/pulls/comments/89651123"},"html":{"href":"https://github.com/the-cheaters/up-all-knight/pull/23#discussion_r89651123"},"pull_request":{"href":"https://api.github.com/repos/the-cheaters/up-all-knight/pulls/23"}}},"pull_request":{"url":"https://api.github.com/repos/the-cheaters/up-all-knight/pulls/23","id":95234598,"html_url":"https://github.com/the-cheaters/up-all-knight/pull/23","diff_url":"https://github.com/the-cheaters/up-all-knight/pull/23.diff","patch_url":"https://github.com/the-cheaters/up-all-knight/pull/23.patch","issue_url":"https://api.github.com/repos/the-cheaters/up-all-knight/issues/23","number":23,"state":"open","locked":false,"title":"Add valid_move? to piece superclass and king subclass","user":{"login":"kellylougheed","id":18649466,"avatar_url":"https://avatars.githubusercontent.com/u/18649466?v=3","gravatar_id":"","url":"https://api.github.com/users/kellylougheed","html_url":"https://github.com/kellylougheed","followers_url":"https://api.github.com/users/kellylougheed/followers","following_url":"https://api.github.com/users/kellylougheed/following{/other_user}","gists_url":"https://api.github.com/users/kellylougheed/gists{/gist_id}","starred_url":"https://api.github.com/users/kellylougheed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kellylougheed/subscriptions","organizations_url":"https://api.github.com/users/kellylougheed/orgs","repos_url":"https://api.github.com/users/kellylougheed/repos","events_url":"https://api.github.com/users/kellylougheed/events{/privacy}","received_events_url":"https://api.github.com/users/kellylougheed/received_events","type":"User","site_admin":false},"body":"- In piece.rb, I added a valid_move? method that checks if a piece is obstructed or if there is a piece of the same color in the destination square. It calls the is_obstructed? method which I wrote previously and also uses two new methods, get_color and get_game.\r\n\r\n- In king.rb, I added a valid_move? submethod that inherits from the superclass and checks to make sure that the king isn't moving more than one square away.\r\n\r\n- In piece_spec.rb, I refactored some of the code (there were a lot of rogue pieces running around that could interfere with future tests, so I put them in their proper context). I wrote two tests to check for a king's valid move and invalid move and three tests to check for a piece's valid move in general (expecting 'false' if it was obstructed or if there was a piece of the same color at the destination, and 'true' if there was no obstruction).\r\n\r\n- In factories.rb, I took the pawn and the king out of the 'piece' block because they aren't recognized as pawns and kings, respectively, if they're placed there.\r\n\r\nLet me know if there's any logic I should add and test for, or anything I forgot to consider!","created_at":"2016-11-24T23:34:25Z","updated_at":"2016-11-25T19:15:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8d6f905b0a2ff84ed5d60fdb6174e8a0b6acfa72","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/the-cheaters/up-all-knight/pulls/23/commits","review_comments_url":"https://api.github.com/repos/the-cheaters/up-all-knight/pulls/23/comments","review_comment_url":"https://api.github.com/repos/the-cheaters/up-all-knight/pulls/comments{/number}","comments_url":"https://api.github.com/repos/the-cheaters/up-all-knight/issues/23/comments","statuses_url":"https://api.github.com/repos/the-cheaters/up-all-knight/statuses/3e9432f7628131d2a0df6886acbfa9fd55ee114c","head":{"label":"the-cheaters:king-move","ref":"king-move","sha":"3e9432f7628131d2a0df6886acbfa9fd55ee114c","user":{"login":"the-cheaters","id":23323498,"avatar_url":"https://avatars.githubusercontent.com/u/23323498?v=3","gravatar_id":"","url":"https://api.github.com/users/the-cheaters","html_url":"https://github.com/the-cheaters","followers_url":"https://api.github.com/users/the-cheaters/followers","following_url":"https://api.github.com/users/the-cheaters/following{/other_user}","gists_url":"https://api.github.com/users/the-cheaters/gists{/gist_id}","starred_url":"https://api.github.com/users/the-cheaters/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/the-cheaters/subscriptions","organizations_url":"https://api.github.com/users/the-cheaters/orgs","repos_url":"https://api.github.com/users/the-cheaters/repos","events_url":"https://api.github.com/users/the-cheaters/events{/privacy}","received_events_url":"https://api.github.com/users/the-cheaters/received_events","type":"Organization","site_admin":false},"repo":{"id":73124016,"name":"up-all-knight","full_name":"the-cheaters/up-all-knight","owner":{"login":"the-cheaters","id":23323498,"avatar_url":"https://avatars.githubusercontent.com/u/23323498?v=3","gravatar_id":"","url":"https://api.github.com/users/the-cheaters","html_url":"https://github.com/the-cheaters","followers_url":"https://api.github.com/users/the-cheaters/followers","following_url":"https://api.github.com/users/the-cheaters/following{/other_user}","gists_url":"https://api.github.com/users/the-cheaters/gists{/gist_id}","starred_url":"https://api.github.com/users/the-cheaters/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/the-cheaters/subscriptions","organizations_url":"https://api.github.com/users/the-cheaters/orgs","repos_url":"https://api.github.com/users/the-cheaters/repos","events_url":"https://api.github.com/users/the-cheaters/events{/privacy}","received_events_url":"https://api.github.com/users/the-cheaters/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/the-cheaters/up-all-knight","description":null,"fork":false,"url":"https://api.github.com/repos/the-cheaters/up-all-knight","forks_url":"https://api.github.com/repos/the-cheaters/up-all-knight/forks","keys_url":"https://api.github.com/repos/the-cheaters/up-all-knight/keys{/key_id}","collaborators_url":"https://api.github.com/repos/the-cheaters/up-all-knight/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/the-cheaters/up-all-knight/teams","hooks_url":"https://api.github.com/repos/the-cheaters/up-all-knight/hooks","issue_events_url":"https://api.github.com/repos/the-cheaters/up-all-knight/issues/events{/number}","events_url":"https://api.github.com/repos/the-cheaters/up-all-knight/events","assignees_url":"https://api.github.com/repos/the-cheaters/up-all-knight/assignees{/user}","branches_url":"https://api.github.com/repos/the-cheaters/up-all-knight/branches{/branch}","tags_url":"https://api.github.com/repos/the-cheaters/up-all-knight/tags","blobs_url":"https://api.github.com/repos/the-cheaters/up-all-knight/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/the-cheaters/up-all-knight/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/the-cheaters/up-all-knight/git/refs{/sha}","trees_url":"https://api.github.com/repos/the-cheaters/up-all-knight/git/trees{/sha}","statuses_url":"https://api.github.com/repos/the-cheaters/up-all-knight/statuses/{sha}","languages_url":"https://api.github.com/repos/the-cheaters/up-all-knight/languages","stargazers_url":"https://api.github.com/repos/the-cheaters/up-all-knight/stargazers","contributors_url":"https://api.github.com/repos/the-cheaters/up-all-knight/contributors","subscribers_url":"https://api.github.com/repos/the-cheaters/up-all-knight/subscribers","subscription_url":"https://api.github.com/repos/the-cheaters/up-all-knight/subscription","commits_url":"https://api.github.com/repos/the-cheaters/up-all-knight/commits{/sha}","git_commits_url":"https://api.github.com/repos/the-cheaters/up-all-knight/git/commits{/sha}","comments_url":"https://api.github.com/repos/the-cheaters/up-all-knight/comments{/number}","issue_comment_url":"https://api.github.com/repos/the-cheaters/up-all-knight/issues/comments{/number}","contents_url":"https://api.github.com/repos/the-cheaters/up-all-knight/contents/{+path}","compare_url":"https://api.github.com/repos/the-cheaters/up-all-knight/compare/{base}...{head}","merges_url":"https://api.github.com/repos/the-cheaters/up-all-knight/merges","archive_url":"https://api.github.com/repos/the-cheaters/up-all-knight/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/the-cheaters/up-all-knight/downloads","issues_url":"https://api.github.com/repos/the-cheaters/up-all-knight/issues{/number}","pulls_url":"https://api.github.com/repos/the-cheaters/up-all-knight/pulls{/number}","milestones_url":"https://api.github.com/repos/the-cheaters/up-all-knight/milestones{/number}","notifications_url":"https://api.github.com/repos/the-cheaters/up-all-knight/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/the-cheaters/up-all-knight/labels{/name}","releases_url":"https://api.github.com/repos/the-cheaters/up-all-knight/releases{/id}","deployments_url":"https://api.github.com/repos/the-cheaters/up-all-knight/deployments","created_at":"2016-11-07T21:49:25Z","updated_at":"2016-11-15T03:50:11Z","pushed_at":"2016-11-25T19:07:00Z","git_url":"git://github.com/the-cheaters/up-all-knight.git","ssh_url":"git@github.com:the-cheaters/up-all-knight.git","clone_url":"https://github.com/the-cheaters/up-all-knight.git","svn_url":"https://github.com/the-cheaters/up-all-knight","homepage":null,"size":138,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":0,"default_branch":"master"}},"base":{"label":"the-cheaters:master","ref":"master","sha":"272670c26c510675416b85fcfc446707a81a00bb","user":{"login":"the-cheaters","id":23323498,"avatar_url":"https://avatars.githubusercontent.com/u/23323498?v=3","gravatar_id":"","url":"https://api.github.com/users/the-cheaters","html_url":"https://github.com/the-cheaters","followers_url":"https://api.github.com/users/the-cheaters/followers","following_url":"https://api.github.com/users/the-cheaters/following{/other_user}","gists_url":"https://api.github.com/users/the-cheaters/gists{/gist_id}","starred_url":"https://api.github.com/users/the-cheaters/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/the-cheaters/subscriptions","organizations_url":"https://api.github.com/users/the-cheaters/orgs","repos_url":"https://api.github.com/users/the-cheaters/repos","events_url":"https://api.github.com/users/the-cheaters/events{/privacy}","received_events_url":"https://api.github.com/users/the-cheaters/received_events","type":"Organization","site_admin":false},"repo":{"id":73124016,"name":"up-all-knight","full_name":"the-cheaters/up-all-knight","owner":{"login":"the-cheaters","id":23323498,"avatar_url":"https://avatars.githubusercontent.com/u/23323498?v=3","gravatar_id":"","url":"https://api.github.com/users/the-cheaters","html_url":"https://github.com/the-cheaters","followers_url":"https://api.github.com/users/the-cheaters/followers","following_url":"https://api.github.com/users/the-cheaters/following{/other_user}","gists_url":"https://api.github.com/users/the-cheaters/gists{/gist_id}","starred_url":"https://api.github.com/users/the-cheaters/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/the-cheaters/subscriptions","organizations_url":"https://api.github.com/users/the-cheaters/orgs","repos_url":"https://api.github.com/users/the-cheaters/repos","events_url":"https://api.github.com/users/the-cheaters/events{/privacy}","received_events_url":"https://api.github.com/users/the-cheaters/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/the-cheaters/up-all-knight","description":null,"fork":false,"url":"https://api.github.com/repos/the-cheaters/up-all-knight","forks_url":"https://api.github.com/repos/the-cheaters/up-all-knight/forks","keys_url":"https://api.github.com/repos/the-cheaters/up-all-knight/keys{/key_id}","collaborators_url":"https://api.github.com/repos/the-cheaters/up-all-knight/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/the-cheaters/up-all-knight/teams","hooks_url":"https://api.github.com/repos/the-cheaters/up-all-knight/hooks","issue_events_url":"https://api.github.com/repos/the-cheaters/up-all-knight/issues/events{/number}","events_url":"https://api.github.com/repos/the-cheaters/up-all-knight/events","assignees_url":"https://api.github.com/repos/the-cheaters/up-all-knight/assignees{/user}","branches_url":"https://api.github.com/repos/the-cheaters/up-all-knight/branches{/branch}","tags_url":"https://api.github.com/repos/the-cheaters/up-all-knight/tags","blobs_url":"https://api.github.com/repos/the-cheaters/up-all-knight/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/the-cheaters/up-all-knight/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/the-cheaters/up-all-knight/git/refs{/sha}","trees_url":"https://api.github.com/repos/the-cheaters/up-all-knight/git/trees{/sha}","statuses_url":"https://api.github.com/repos/the-cheaters/up-all-knight/statuses/{sha}","languages_url":"https://api.github.com/repos/the-cheaters/up-all-knight/languages","stargazers_url":"https://api.github.com/repos/the-cheaters/up-all-knight/stargazers","contributors_url":"https://api.github.com/repos/the-cheaters/up-all-knight/contributors","subscribers_url":"https://api.github.com/repos/the-cheaters/up-all-knight/subscribers","subscription_url":"https://api.github.com/repos/the-cheaters/up-all-knight/subscription","commits_url":"https://api.github.com/repos/the-cheaters/up-all-knight/commits{/sha}","git_commits_url":"https://api.github.com/repos/the-cheaters/up-all-knight/git/commits{/sha}","comments_url":"https://api.github.com/repos/the-cheaters/up-all-knight/comments{/number}","issue_comment_url":"https://api.github.com/repos/the-cheaters/up-all-knight/issues/comments{/number}","contents_url":"https://api.github.com/repos/the-cheaters/up-all-knight/contents/{+path}","compare_url":"https://api.github.com/repos/the-cheaters/up-all-knight/compare/{base}...{head}","merges_url":"https://api.github.com/repos/the-cheaters/up-all-knight/merges","archive_url":"https://api.github.com/repos/the-cheaters/up-all-knight/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/the-cheaters/up-all-knight/downloads","issues_url":"https://api.github.com/repos/the-cheaters/up-all-knight/issues{/number}","pulls_url":"https://api.github.com/repos/the-cheaters/up-all-knight/pulls{/number}","milestones_url":"https://api.github.com/repos/the-cheaters/up-all-knight/milestones{/number}","notifications_url":"https://api.github.com/repos/the-cheaters/up-all-knight/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/the-cheaters/up-all-knight/labels{/name}","releases_url":"https://api.github.com/repos/the-cheaters/up-all-knight/releases{/id}","deployments_url":"https://api.github.com/repos/the-cheaters/up-all-knight/deployments","created_at":"2016-11-07T21:49:25Z","updated_at":"2016-11-15T03:50:11Z","pushed_at":"2016-11-25T19:07:00Z","git_url":"git://github.com/the-cheaters/up-all-knight.git","ssh_url":"git@github.com:the-cheaters/up-all-knight.git","clone_url":"https://github.com/the-cheaters/up-all-knight.git","svn_url":"https://github.com/the-cheaters/up-all-knight","homepage":null,"size":138,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/the-cheaters/up-all-knight/pulls/23"},"html":{"href":"https://github.com/the-cheaters/up-all-knight/pull/23"},"issue":{"href":"https://api.github.com/repos/the-cheaters/up-all-knight/issues/23"},"comments":{"href":"https://api.github.com/repos/the-cheaters/up-all-knight/issues/23/comments"},"review_comments":{"href":"https://api.github.com/repos/the-cheaters/up-all-knight/pulls/23/comments"},"review_comment":{"href":"https://api.github.com/repos/the-cheaters/up-all-knight/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/the-cheaters/up-all-knight/pulls/23/commits"},"statuses":{"href":"https://api.github.com/repos/the-cheaters/up-all-knight/statuses/3e9432f7628131d2a0df6886acbfa9fd55ee114c"}}}}
{"actor":{"display_login":"lasley"}}