{"action":"created","comment":{"url":"https://api.github.com/repos/clementallen/arcadian/pulls/comments/82506229","pull_request_review_id":3411559,"id":82506229,"diff_hunk":"@@ -0,0 +1,28 @@\n+// arcadian.scss\r\n+\r\n+// To Do List / Ideas / Suggestions =============\r\n+//\r\n+// TODO: include bootstrap-sass as a dependency to compile from source. this will reduce bloat in the Arcadian sass source code, as a lot of the tweaks that are made here can be made in Bootstraps' _settings.scss file.\r\n+// TODO: refator a lot of code into their own components.\r\n+\r\n+// Variables ====================================\r\n+//\r\n+@import 'config/variables';\r\n+// @import 'config/settings'; // (generated by gulp during build process). this is usefull for quick tweaks and testing!\r","path":"assets/sass/arcadian.scss","position":11,"original_position":11,"commit_id":"6b6f7561adc6e1923a272aa7b22f3998f2dd0d1b","original_commit_id":"6b6f7561adc6e1923a272aa7b22f3998f2dd0d1b","user":{"login":"clementallen","id":6305750,"avatar_url":"https://avatars.githubusercontent.com/u/6305750?v=3","gravatar_id":"","url":"https://api.github.com/users/clementallen","html_url":"https://github.com/clementallen","followers_url":"https://api.github.com/users/clementallen/followers","following_url":"https://api.github.com/users/clementallen/following{/other_user}","gists_url":"https://api.github.com/users/clementallen/gists{/gist_id}","starred_url":"https://api.github.com/users/clementallen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clementallen/subscriptions","organizations_url":"https://api.github.com/users/clementallen/orgs","repos_url":"https://api.github.com/users/clementallen/repos","events_url":"https://api.github.com/users/clementallen/events{/privacy}","received_events_url":"https://api.github.com/users/clementallen/received_events","type":"User","site_admin":false},"body":"I'm happy with just having the `variables.scss` file","created_at":"2016-10-08T17:12:47Z","updated_at":"2016-10-08T17:12:47Z","html_url":"https://github.com/clementallen/arcadian/pull/30#discussion_r82506229","pull_request_url":"https://api.github.com/repos/clementallen/arcadian/pulls/30","_links":{"self":{"href":"https://api.github.com/repos/clementallen/arcadian/pulls/comments/82506229"},"html":{"href":"https://github.com/clementallen/arcadian/pull/30#discussion_r82506229"},"pull_request":{"href":"https://api.github.com/repos/clementallen/arcadian/pulls/30"}}},"pull_request":{"url":"https://api.github.com/repos/clementallen/arcadian/pulls/30","id":88533841,"html_url":"https://github.com/clementallen/arcadian/pull/30","diff_url":"https://github.com/clementallen/arcadian/pull/30.diff","patch_url":"https://github.com/clementallen/arcadian/pull/30.patch","issue_url":"https://api.github.com/repos/clementallen/arcadian/issues/30","number":30,"state":"open","locked":false,"title":"Arcadian LESS to SCSS conversion.","user":{"login":"jordanbrauer","id":18744334,"avatar_url":"https://avatars.githubusercontent.com/u/18744334?v=3","gravatar_id":"","url":"https://api.github.com/users/jordanbrauer","html_url":"https://github.com/jordanbrauer","followers_url":"https://api.github.com/users/jordanbrauer/followers","following_url":"https://api.github.com/users/jordanbrauer/following{/other_user}","gists_url":"https://api.github.com/users/jordanbrauer/gists{/gist_id}","starred_url":"https://api.github.com/users/jordanbrauer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jordanbrauer/subscriptions","organizations_url":"https://api.github.com/users/jordanbrauer/orgs","repos_url":"https://api.github.com/users/jordanbrauer/repos","events_url":"https://api.github.com/users/jordanbrauer/events{/privacy}","received_events_url":"https://api.github.com/users/jordanbrauer/received_events","type":"User","site_admin":false},"body":"Hey, here it is. \r\n\r\nThere are some things that I didn't get around to doing, but it's all done haha. I tried to comment and document as much as I could as I went along too. However I have some thoughts, specifically on the `_custom.scss` file.\r\n\r\n#### Notes:\r\nLots of stuff in here can either be attained from bootstrap natively,\r\nor should be it's own unique component to Arcadian.\r\nPersonally, I feel that Bootstrap-Sass should be a dependency for this project.\r\nYou seem to have a couple of small changes to their default code, so by using a settings file\r\nyou will have better control over those changes. Especially if you want to implement more custom\r\nstyles/ changes to Bootstraps' default styles.\r\nUnfortunately though, fixing up dependencies and compiling Bootstrap from source is\r\na little out of scope for this issue PR. Perhaps I will open up another issue after\r\nand you can make a decision yourself. :) Maybe label it hacktober again and assign me ;D\r\n\r\n\r\nLet m know if there is anything wrong, or you need some more explanation of my code. :) Thanks.","created_at":"2016-10-08T04:49:01Z","updated_at":"2016-10-08T17:12:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"91d0b4b3622f75c529dc3c54e40eb6f1c5b21e1f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/clementallen/arcadian/pulls/30/commits","review_comments_url":"https://api.github.com/repos/clementallen/arcadian/pulls/30/comments","review_comment_url":"https://api.github.com/repos/clementallen/arcadian/pulls/comments{/number}","comments_url":"https://api.github.com/repos/clementallen/arcadian/issues/30/comments","statuses_url":"https://api.github.com/repos/clementallen/arcadian/statuses/6b6f7561adc6e1923a272aa7b22f3998f2dd0d1b","head":{"label":"jordanbrauer:master","ref":"master","sha":"6b6f7561adc6e1923a272aa7b22f3998f2dd0d1b","user":{"login":"jordanbrauer","id":18744334,"avatar_url":"https://avatars.githubusercontent.com/u/18744334?v=3","gravatar_id":"","url":"https://api.github.com/users/jordanbrauer","html_url":"https://github.com/jordanbrauer","followers_url":"https://api.github.com/users/jordanbrauer/followers","following_url":"https://api.github.com/users/jordanbrauer/following{/other_user}","gists_url":"https://api.github.com/users/jordanbrauer/gists{/gist_id}","starred_url":"https://api.github.com/users/jordanbrauer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jordanbrauer/subscriptions","organizations_url":"https://api.github.com/users/jordanbrauer/orgs","repos_url":"https://api.github.com/users/jordanbrauer/repos","events_url":"https://api.github.com/users/jordanbrauer/events{/privacy}","received_events_url":"https://api.github.com/users/jordanbrauer/received_events","type":"User","site_admin":false},"repo":{"id":70172783,"name":"arcadian","full_name":"jordanbrauer/arcadian","owner":{"login":"jordanbrauer","id":18744334,"avatar_url":"https://avatars.githubusercontent.com/u/18744334?v=3","gravatar_id":"","url":"https://api.github.com/users/jordanbrauer","html_url":"https://github.com/jordanbrauer","followers_url":"https://api.github.com/users/jordanbrauer/followers","following_url":"https://api.github.com/users/jordanbrauer/following{/other_user}","gists_url":"https://api.github.com/users/jordanbrauer/gists{/gist_id}","starred_url":"https://api.github.com/users/jordanbrauer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jordanbrauer/subscriptions","organizations_url":"https://api.github.com/users/jordanbrauer/orgs","repos_url":"https://api.github.com/users/jordanbrauer/repos","events_url":"https://api.github.com/users/jordanbrauer/events{/privacy}","received_events_url":"https://api.github.com/users/jordanbrauer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jordanbrauer/arcadian","description":"Website of the band Arcadian","fork":true,"url":"https://api.github.com/repos/jordanbrauer/arcadian","forks_url":"https://api.github.com/repos/jordanbrauer/arcadian/forks","keys_url":"https://api.github.com/repos/jordanbrauer/arcadian/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jordanbrauer/arcadian/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jordanbrauer/arcadian/teams","hooks_url":"https://api.github.com/repos/jordanbrauer/arcadian/hooks","issue_events_url":"https://api.github.com/repos/jordanbrauer/arcadian/issues/events{/number}","events_url":"https://api.github.com/repos/jordanbrauer/arcadian/events","assignees_url":"https://api.github.com/repos/jordanbrauer/arcadian/assignees{/user}","branches_url":"https://api.github.com/repos/jordanbrauer/arcadian/branches{/branch}","tags_url":"https://api.github.com/repos/jordanbrauer/arcadian/tags","blobs_url":"https://api.github.com/repos/jordanbrauer/arcadian/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jordanbrauer/arcadian/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jordanbrauer/arcadian/git/refs{/sha}","trees_url":"https://api.github.com/repos/jordanbrauer/arcadian/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jordanbrauer/arcadian/statuses/{sha}","languages_url":"https://api.github.com/repos/jordanbrauer/arcadian/languages","stargazers_url":"https://api.github.com/repos/jordanbrauer/arcadian/stargazers","contributors_url":"https://api.github.com/repos/jordanbrauer/arcadian/contributors","subscribers_url":"https://api.github.com/repos/jordanbrauer/arcadian/subscribers","subscription_url":"https://api.github.com/repos/jordanbrauer/arcadian/subscription","commits_url":"https://api.github.com/repos/jordanbrauer/arcadian/commits{/sha}","git_commits_url":"https://api.github.com/repos/jordanbrauer/arcadian/git/commits{/sha}","comments_url":"https://api.github.com/repos/jordanbrauer/arcadian/comments{/number}","issue_comment_url":"https://api.github.com/repos/jordanbrauer/arcadian/issues/comments{/number}","contents_url":"https://api.github.com/repos/jordanbrauer/arcadian/contents/{+path}","compare_url":"https://api.github.com/repos/jordanbrauer/arcadian/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jordanbrauer/arcadian/merges","archive_url":"https://api.github.com/repos/jordanbrauer/arcadian/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jordanbrauer/arcadian/downloads","issues_url":"https://api.github.com/repos/jordanbrauer/arcadian/issues{/number}","pulls_url":"https://api.github.com/repos/jordanbrauer/arcadian/pulls{/number}","milestones_url":"https://api.github.com/repos/jordanbrauer/arcadian/milestones{/number}","notifications_url":"https://api.github.com/repos/jordanbrauer/arcadian/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jordanbrauer/arcadian/labels{/name}","releases_url":"https://api.github.com/repos/jordanbrauer/arcadian/releases{/id}","deployments_url":"https://api.github.com/repos/jordanbrauer/arcadian/deployments","created_at":"2016-10-06T16:37:53Z","updated_at":"2016-10-06T16:37:55Z","pushed_at":"2016-10-08T04:38:52Z","git_url":"git://github.com/jordanbrauer/arcadian.git","ssh_url":"git@github.com:jordanbrauer/arcadian.git","clone_url":"https://github.com/jordanbrauer/arcadian.git","svn_url":"https://github.com/jordanbrauer/arcadian","homepage":"http://arcadian.band","size":38891,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"clementallen:master","ref":"master","sha":"b88a6de27f0519b0987fb7a8782e8185d9c1c9c4","user":{"login":"clementallen","id":6305750,"avatar_url":"https://avatars.githubusercontent.com/u/6305750?v=3","gravatar_id":"","url":"https://api.github.com/users/clementallen","html_url":"https://github.com/clementallen","followers_url":"https://api.github.com/users/clementallen/followers","following_url":"https://api.github.com/users/clementallen/following{/other_user}","gists_url":"https://api.github.com/users/clementallen/gists{/gist_id}","starred_url":"https://api.github.com/users/clementallen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clementallen/subscriptions","organizations_url":"https://api.github.com/users/clementallen/orgs","repos_url":"https://api.github.com/users/clementallen/repos","events_url":"https://api.github.com/users/clementallen/events{/privacy}","received_events_url":"https://api.github.com/users/clementallen/received_events","type":"User","site_admin":false},"repo":{"id":48697536,"name":"arcadian","full_name":"clementallen/arcadian","owner":{"login":"clementallen","id":6305750,"avatar_url":"https://avatars.githubusercontent.com/u/6305750?v=3","gravatar_id":"","url":"https://api.github.com/users/clementallen","html_url":"https://github.com/clementallen","followers_url":"https://api.github.com/users/clementallen/followers","following_url":"https://api.github.com/users/clementallen/following{/other_user}","gists_url":"https://api.github.com/users/clementallen/gists{/gist_id}","starred_url":"https://api.github.com/users/clementallen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clementallen/subscriptions","organizations_url":"https://api.github.com/users/clementallen/orgs","repos_url":"https://api.github.com/users/clementallen/repos","events_url":"https://api.github.com/users/clementallen/events{/privacy}","received_events_url":"https://api.github.com/users/clementallen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/clementallen/arcadian","description":"Website of the band Arcadian","fork":false,"url":"https://api.github.com/repos/clementallen/arcadian","forks_url":"https://api.github.com/repos/clementallen/arcadian/forks","keys_url":"https://api.github.com/repos/clementallen/arcadian/keys{/key_id}","collaborators_url":"https://api.github.com/repos/clementallen/arcadian/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/clementallen/arcadian/teams","hooks_url":"https://api.github.com/repos/clementallen/arcadian/hooks","issue_events_url":"https://api.github.com/repos/clementallen/arcadian/issues/events{/number}","events_url":"https://api.github.com/repos/clementallen/arcadian/events","assignees_url":"https://api.github.com/repos/clementallen/arcadian/assignees{/user}","branches_url":"https://api.github.com/repos/clementallen/arcadian/branches{/branch}","tags_url":"https://api.github.com/repos/clementallen/arcadian/tags","blobs_url":"https://api.github.com/repos/clementallen/arcadian/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/clementallen/arcadian/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/clementallen/arcadian/git/refs{/sha}","trees_url":"https://api.github.com/repos/clementallen/arcadian/git/trees{/sha}","statuses_url":"https://api.github.com/repos/clementallen/arcadian/statuses/{sha}","languages_url":"https://api.github.com/repos/clementallen/arcadian/languages","stargazers_url":"https://api.github.com/repos/clementallen/arcadian/stargazers","contributors_url":"https://api.github.com/repos/clementallen/arcadian/contributors","subscribers_url":"https://api.github.com/repos/clementallen/arcadian/subscribers","subscription_url":"https://api.github.com/repos/clementallen/arcadian/subscription","commits_url":"https://api.github.com/repos/clementallen/arcadian/commits{/sha}","git_commits_url":"https://api.github.com/repos/clementallen/arcadian/git/commits{/sha}","comments_url":"https://api.github.com/repos/clementallen/arcadian/comments{/number}","issue_comment_url":"https://api.github.com/repos/clementallen/arcadian/issues/comments{/number}","contents_url":"https://api.github.com/repos/clementallen/arcadian/contents/{+path}","compare_url":"https://api.github.com/repos/clementallen/arcadian/compare/{base}...{head}","merges_url":"https://api.github.com/repos/clementallen/arcadian/merges","archive_url":"https://api.github.com/repos/clementallen/arcadian/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/clementallen/arcadian/downloads","issues_url":"https://api.github.com/repos/clementallen/arcadian/issues{/number}","pulls_url":"https://api.github.com/repos/clementallen/arcadian/pulls{/number}","milestones_url":"https://api.github.com/repos/clementallen/arcadian/milestones{/number}","notifications_url":"https://api.github.com/repos/clementallen/arcadian/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/clementallen/arcadian/labels{/name}","releases_url":"https://api.github.com/repos/clementallen/arcadian/releases{/id}","deployments_url":"https://api.github.com/repos/clementallen/arcadian/deployments","created_at":"2015-12-28T14:57:38Z","updated_at":"2016-06-04T15:13:17Z","pushed_at":"2016-10-08T11:16:12Z","git_url":"git://github.com/clementallen/arcadian.git","ssh_url":"git@github.com:clementallen/arcadian.git","clone_url":"https://github.com/clementallen/arcadian.git","svn_url":"https://github.com/clementallen/arcadian","homepage":"http://arcadian.band","size":38964,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/clementallen/arcadian/pulls/30"},"html":{"href":"https://github.com/clementallen/arcadian/pull/30"},"issue":{"href":"https://api.github.com/repos/clementallen/arcadian/issues/30"},"comments":{"href":"https://api.github.com/repos/clementallen/arcadian/issues/30/comments"},"review_comments":{"href":"https://api.github.com/repos/clementallen/arcadian/pulls/30/comments"},"review_comment":{"href":"https://api.github.com/repos/clementallen/arcadian/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/clementallen/arcadian/pulls/30/commits"},"statuses":{"href":"https://api.github.com/repos/clementallen/arcadian/statuses/6b6f7561adc6e1923a272aa7b22f3998f2dd0d1b"}}}}
{"actor":{"display_login":"clementallen"}}