{"action":"closed","number":1010,"pull_request":{"url":"https://api.github.com/repos/unl/wdntemplates/pulls/1010","id":77840217,"html_url":"https://github.com/unl/wdntemplates/pull/1010","diff_url":"https://github.com/unl/wdntemplates/pull/1010.diff","patch_url":"https://github.com/unl/wdntemplates/pull/1010.patch","issue_url":"https://api.github.com/repos/unl/wdntemplates/issues/1010","number":1010,"state":"closed","locked":false,"title":"WIP: A11y improvements","user":{"login":"mfairchild365","id":498678,"avatar_url":"https://avatars.githubusercontent.com/u/498678?v=3","gravatar_id":"","url":"https://api.github.com/users/mfairchild365","html_url":"https://github.com/mfairchild365","followers_url":"https://api.github.com/users/mfairchild365/followers","following_url":"https://api.github.com/users/mfairchild365/following{/other_user}","gists_url":"https://api.github.com/users/mfairchild365/gists{/gist_id}","starred_url":"https://api.github.com/users/mfairchild365/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfairchild365/subscriptions","organizations_url":"https://api.github.com/users/mfairchild365/orgs","repos_url":"https://api.github.com/users/mfairchild365/repos","events_url":"https://api.github.com/users/mfairchild365/events{/privacy}","received_events_url":"https://api.github.com/users/mfairchild365/received_events","type":"User","site_admin":false},"body":"NOTE: this PR is under development, do not merge yet. I've created this PR as a place to discuss and coordinate.\r\n\r\nThis aims to fix the following issues:\r\n\r\n- [x] - [dropdown widget controls (search, share, idm)] Convert the input-label style of buttons to just `<button>` elements. The css only input-label style has several a11y issues associated with it, including incorrect semantics, bad focus-management, inconsistent outlines, etc. I see little benefit to using the css-only trick here because we will need to use JS anyway (for aria) and the framework requires JS to work anyway.\r\n - [x] - [MF] update wdn-ui.js to reflect changes\r\n - [x] - [MF] update includes to reflect changes\r\n - [x] - [RD] update styles to hide/show containers based on the container's `aria-hidden` attribute.\r\n- [x] - [MF] [Navigation controls] replace the input-label style of buttons for the navigation toggle as well. This is slightly different than the dropdown widget controls and will require some extra consideration.\r\n\r\nIn a future release: Improve tab order of these controls as well. Because they are moved around with css at different widths, tab order is sometimes incorrect.\r\n\r\n","created_at":"2016-07-18T16:45:07Z","updated_at":"2016-09-06T13:27:09Z","closed_at":"2016-09-06T13:27:09Z","merged_at":"2016-09-06T13:27:09Z","merge_commit_sha":"833482a564611a73f571a555c949c4ed7912d949","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/unl/wdntemplates/pulls/1010/commits","review_comments_url":"https://api.github.com/repos/unl/wdntemplates/pulls/1010/comments","review_comment_url":"https://api.github.com/repos/unl/wdntemplates/pulls/comments{/number}","comments_url":"https://api.github.com/repos/unl/wdntemplates/issues/1010/comments","statuses_url":"https://api.github.com/repos/unl/wdntemplates/statuses/31dd48c6befc590f90bd083ef406082935198337","head":{"label":"unl:a11y-improvements","ref":"a11y-improvements","sha":"31dd48c6befc590f90bd083ef406082935198337","user":{"login":"unl","id":704049,"avatar_url":"https://avatars.githubusercontent.com/u/704049?v=3","gravatar_id":"","url":"https://api.github.com/users/unl","html_url":"https://github.com/unl","followers_url":"https://api.github.com/users/unl/followers","following_url":"https://api.github.com/users/unl/following{/other_user}","gists_url":"https://api.github.com/users/unl/gists{/gist_id}","starred_url":"https://api.github.com/users/unl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unl/subscriptions","organizations_url":"https://api.github.com/users/unl/orgs","repos_url":"https://api.github.com/users/unl/repos","events_url":"https://api.github.com/users/unl/events{/privacy}","received_events_url":"https://api.github.com/users/unl/received_events","type":"Organization","site_admin":false},"repo":{"id":2780949,"name":"wdntemplates","full_name":"unl/wdntemplates","owner":{"login":"unl","id":704049,"avatar_url":"https://avatars.githubusercontent.com/u/704049?v=3","gravatar_id":"","url":"https://api.github.com/users/unl","html_url":"https://github.com/unl","followers_url":"https://api.github.com/users/unl/followers","following_url":"https://api.github.com/users/unl/following{/other_user}","gists_url":"https://api.github.com/users/unl/gists{/gist_id}","starred_url":"https://api.github.com/users/unl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unl/subscriptions","organizations_url":"https://api.github.com/users/unl/orgs","repos_url":"https://api.github.com/users/unl/repos","events_url":"https://api.github.com/users/unl/events{/privacy}","received_events_url":"https://api.github.com/users/unl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/unl/wdntemplates","description":"Templates for the UNL website, coordinated by the Web Developer Network","fork":false,"url":"https://api.github.com/repos/unl/wdntemplates","forks_url":"https://api.github.com/repos/unl/wdntemplates/forks","keys_url":"https://api.github.com/repos/unl/wdntemplates/keys{/key_id}","collaborators_url":"https://api.github.com/repos/unl/wdntemplates/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/unl/wdntemplates/teams","hooks_url":"https://api.github.com/repos/unl/wdntemplates/hooks","issue_events_url":"https://api.github.com/repos/unl/wdntemplates/issues/events{/number}","events_url":"https://api.github.com/repos/unl/wdntemplates/events","assignees_url":"https://api.github.com/repos/unl/wdntemplates/assignees{/user}","branches_url":"https://api.github.com/repos/unl/wdntemplates/branches{/branch}","tags_url":"https://api.github.com/repos/unl/wdntemplates/tags","blobs_url":"https://api.github.com/repos/unl/wdntemplates/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/unl/wdntemplates/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/unl/wdntemplates/git/refs{/sha}","trees_url":"https://api.github.com/repos/unl/wdntemplates/git/trees{/sha}","statuses_url":"https://api.github.com/repos/unl/wdntemplates/statuses/{sha}","languages_url":"https://api.github.com/repos/unl/wdntemplates/languages","stargazers_url":"https://api.github.com/repos/unl/wdntemplates/stargazers","contributors_url":"https://api.github.com/repos/unl/wdntemplates/contributors","subscribers_url":"https://api.github.com/repos/unl/wdntemplates/subscribers","subscription_url":"https://api.github.com/repos/unl/wdntemplates/subscription","commits_url":"https://api.github.com/repos/unl/wdntemplates/commits{/sha}","git_commits_url":"https://api.github.com/repos/unl/wdntemplates/git/commits{/sha}","comments_url":"https://api.github.com/repos/unl/wdntemplates/comments{/number}","issue_comment_url":"https://api.github.com/repos/unl/wdntemplates/issues/comments{/number}","contents_url":"https://api.github.com/repos/unl/wdntemplates/contents/{+path}","compare_url":"https://api.github.com/repos/unl/wdntemplates/compare/{base}...{head}","merges_url":"https://api.github.com/repos/unl/wdntemplates/merges","archive_url":"https://api.github.com/repos/unl/wdntemplates/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/unl/wdntemplates/downloads","issues_url":"https://api.github.com/repos/unl/wdntemplates/issues{/number}","pulls_url":"https://api.github.com/repos/unl/wdntemplates/pulls{/number}","milestones_url":"https://api.github.com/repos/unl/wdntemplates/milestones{/number}","notifications_url":"https://api.github.com/repos/unl/wdntemplates/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/unl/wdntemplates/labels{/name}","releases_url":"https://api.github.com/repos/unl/wdntemplates/releases{/id}","deployments_url":"https://api.github.com/repos/unl/wdntemplates/deployments","created_at":"2011-11-15T15:19:04Z","updated_at":"2016-08-26T19:10:22Z","pushed_at":"2016-09-06T13:27:09Z","git_url":"git://github.com/unl/wdntemplates.git","ssh_url":"git@github.com:unl/wdntemplates.git","clone_url":"https://github.com/unl/wdntemplates.git","svn_url":"https://github.com/unl/wdntemplates","homepage":"http://wdn.unl.edu/","size":138694,"stargazers_count":17,"watchers_count":17,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":17,"forks":16,"open_issues":17,"watchers":17,"default_branch":"develop"}},"base":{"label":"unl:develop","ref":"develop","sha":"44a53ecdae880bba9060ab7a4b6c22e2a1d85601","user":{"login":"unl","id":704049,"avatar_url":"https://avatars.githubusercontent.com/u/704049?v=3","gravatar_id":"","url":"https://api.github.com/users/unl","html_url":"https://github.com/unl","followers_url":"https://api.github.com/users/unl/followers","following_url":"https://api.github.com/users/unl/following{/other_user}","gists_url":"https://api.github.com/users/unl/gists{/gist_id}","starred_url":"https://api.github.com/users/unl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unl/subscriptions","organizations_url":"https://api.github.com/users/unl/orgs","repos_url":"https://api.github.com/users/unl/repos","events_url":"https://api.github.com/users/unl/events{/privacy}","received_events_url":"https://api.github.com/users/unl/received_events","type":"Organization","site_admin":false},"repo":{"id":2780949,"name":"wdntemplates","full_name":"unl/wdntemplates","owner":{"login":"unl","id":704049,"avatar_url":"https://avatars.githubusercontent.com/u/704049?v=3","gravatar_id":"","url":"https://api.github.com/users/unl","html_url":"https://github.com/unl","followers_url":"https://api.github.com/users/unl/followers","following_url":"https://api.github.com/users/unl/following{/other_user}","gists_url":"https://api.github.com/users/unl/gists{/gist_id}","starred_url":"https://api.github.com/users/unl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unl/subscriptions","organizations_url":"https://api.github.com/users/unl/orgs","repos_url":"https://api.github.com/users/unl/repos","events_url":"https://api.github.com/users/unl/events{/privacy}","received_events_url":"https://api.github.com/users/unl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/unl/wdntemplates","description":"Templates for the UNL website, coordinated by the Web Developer Network","fork":false,"url":"https://api.github.com/repos/unl/wdntemplates","forks_url":"https://api.github.com/repos/unl/wdntemplates/forks","keys_url":"https://api.github.com/repos/unl/wdntemplates/keys{/key_id}","collaborators_url":"https://api.github.com/repos/unl/wdntemplates/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/unl/wdntemplates/teams","hooks_url":"https://api.github.com/repos/unl/wdntemplates/hooks","issue_events_url":"https://api.github.com/repos/unl/wdntemplates/issues/events{/number}","events_url":"https://api.github.com/repos/unl/wdntemplates/events","assignees_url":"https://api.github.com/repos/unl/wdntemplates/assignees{/user}","branches_url":"https://api.github.com/repos/unl/wdntemplates/branches{/branch}","tags_url":"https://api.github.com/repos/unl/wdntemplates/tags","blobs_url":"https://api.github.com/repos/unl/wdntemplates/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/unl/wdntemplates/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/unl/wdntemplates/git/refs{/sha}","trees_url":"https://api.github.com/repos/unl/wdntemplates/git/trees{/sha}","statuses_url":"https://api.github.com/repos/unl/wdntemplates/statuses/{sha}","languages_url":"https://api.github.com/repos/unl/wdntemplates/languages","stargazers_url":"https://api.github.com/repos/unl/wdntemplates/stargazers","contributors_url":"https://api.github.com/repos/unl/wdntemplates/contributors","subscribers_url":"https://api.github.com/repos/unl/wdntemplates/subscribers","subscription_url":"https://api.github.com/repos/unl/wdntemplates/subscription","commits_url":"https://api.github.com/repos/unl/wdntemplates/commits{/sha}","git_commits_url":"https://api.github.com/repos/unl/wdntemplates/git/commits{/sha}","comments_url":"https://api.github.com/repos/unl/wdntemplates/comments{/number}","issue_comment_url":"https://api.github.com/repos/unl/wdntemplates/issues/comments{/number}","contents_url":"https://api.github.com/repos/unl/wdntemplates/contents/{+path}","compare_url":"https://api.github.com/repos/unl/wdntemplates/compare/{base}...{head}","merges_url":"https://api.github.com/repos/unl/wdntemplates/merges","archive_url":"https://api.github.com/repos/unl/wdntemplates/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/unl/wdntemplates/downloads","issues_url":"https://api.github.com/repos/unl/wdntemplates/issues{/number}","pulls_url":"https://api.github.com/repos/unl/wdntemplates/pulls{/number}","milestones_url":"https://api.github.com/repos/unl/wdntemplates/milestones{/number}","notifications_url":"https://api.github.com/repos/unl/wdntemplates/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/unl/wdntemplates/labels{/name}","releases_url":"https://api.github.com/repos/unl/wdntemplates/releases{/id}","deployments_url":"https://api.github.com/repos/unl/wdntemplates/deployments","created_at":"2011-11-15T15:19:04Z","updated_at":"2016-08-26T19:10:22Z","pushed_at":"2016-09-06T13:27:09Z","git_url":"git://github.com/unl/wdntemplates.git","ssh_url":"git@github.com:unl/wdntemplates.git","clone_url":"https://github.com/unl/wdntemplates.git","svn_url":"https://github.com/unl/wdntemplates","homepage":"http://wdn.unl.edu/","size":138694,"stargazers_count":17,"watchers_count":17,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":17,"forks":16,"open_issues":17,"watchers":17,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/unl/wdntemplates/pulls/1010"},"html":{"href":"https://github.com/unl/wdntemplates/pull/1010"},"issue":{"href":"https://api.github.com/repos/unl/wdntemplates/issues/1010"},"comments":{"href":"https://api.github.com/repos/unl/wdntemplates/issues/1010/comments"},"review_comments":{"href":"https://api.github.com/repos/unl/wdntemplates/pulls/1010/comments"},"review_comment":{"href":"https://api.github.com/repos/unl/wdntemplates/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/unl/wdntemplates/pulls/1010/commits"},"statuses":{"href":"https://api.github.com/repos/unl/wdntemplates/statuses/31dd48c6befc590f90bd083ef406082935198337"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"kabel","id":675956,"avatar_url":"https://avatars.githubusercontent.com/u/675956?v=3","gravatar_id":"","url":"https://api.github.com/users/kabel","html_url":"https://github.com/kabel","followers_url":"https://api.github.com/users/kabel/followers","following_url":"https://api.github.com/users/kabel/following{/other_user}","gists_url":"https://api.github.com/users/kabel/gists{/gist_id}","starred_url":"https://api.github.com/users/kabel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kabel/subscriptions","organizations_url":"https://api.github.com/users/kabel/orgs","repos_url":"https://api.github.com/users/kabel/repos","events_url":"https://api.github.com/users/kabel/events{/privacy}","received_events_url":"https://api.github.com/users/kabel/received_events","type":"User","site_admin":false},"comments":2,"review_comments":10,"commits":57,"additions":292,"deletions":284,"changed_files":19}}
{"actor":{"display_login":"kabel"}}