{"action":"created","issue":{"url":"https://api.github.com/repos/mantidproject/mantid/issues/17016","repository_url":"https://api.github.com/repos/mantidproject/mantid","labels_url":"https://api.github.com/repos/mantidproject/mantid/issues/17016/labels{/name}","comments_url":"https://api.github.com/repos/mantidproject/mantid/issues/17016/comments","events_url":"https://api.github.com/repos/mantidproject/mantid/issues/17016/events","html_url":"https://github.com/mantidproject/mantid/pull/17016","id":167564058,"number":17016,"title":"Enable use of start and end times as log values","user":{"login":"tom-perkins","id":15363125,"avatar_url":"https://avatars.githubusercontent.com/u/15363125?v=3","gravatar_id":"","url":"https://api.github.com/users/tom-perkins","html_url":"https://github.com/tom-perkins","followers_url":"https://api.github.com/users/tom-perkins/followers","following_url":"https://api.github.com/users/tom-perkins/following{/other_user}","gists_url":"https://api.github.com/users/tom-perkins/gists{/gist_id}","starred_url":"https://api.github.com/users/tom-perkins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tom-perkins/subscriptions","organizations_url":"https://api.github.com/users/tom-perkins/orgs","repos_url":"https://api.github.com/users/tom-perkins/repos","events_url":"https://api.github.com/users/tom-perkins/events{/privacy}","received_events_url":"https://api.github.com/users/tom-perkins/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/mantidproject/mantid/labels/Component:%20Muon","name":"Component: Muon","color":"009800"}],"state":"open","locked":false,"assignee":{"login":"KarlPalmen","id":1133249,"avatar_url":"https://avatars.githubusercontent.com/u/1133249?v=3","gravatar_id":"","url":"https://api.github.com/users/KarlPalmen","html_url":"https://github.com/KarlPalmen","followers_url":"https://api.github.com/users/KarlPalmen/followers","following_url":"https://api.github.com/users/KarlPalmen/following{/other_user}","gists_url":"https://api.github.com/users/KarlPalmen/gists{/gist_id}","starred_url":"https://api.github.com/users/KarlPalmen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KarlPalmen/subscriptions","organizations_url":"https://api.github.com/users/KarlPalmen/orgs","repos_url":"https://api.github.com/users/KarlPalmen/repos","events_url":"https://api.github.com/users/KarlPalmen/events{/privacy}","received_events_url":"https://api.github.com/users/KarlPalmen/received_events","type":"User","site_admin":false},"assignees":[{"login":"KarlPalmen","id":1133249,"avatar_url":"https://avatars.githubusercontent.com/u/1133249?v=3","gravatar_id":"","url":"https://api.github.com/users/KarlPalmen","html_url":"https://github.com/KarlPalmen","followers_url":"https://api.github.com/users/KarlPalmen/followers","following_url":"https://api.github.com/users/KarlPalmen/following{/other_user}","gists_url":"https://api.github.com/users/KarlPalmen/gists{/gist_id}","starred_url":"https://api.github.com/users/KarlPalmen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KarlPalmen/subscriptions","organizations_url":"https://api.github.com/users/KarlPalmen/orgs","repos_url":"https://api.github.com/users/KarlPalmen/repos","events_url":"https://api.github.com/users/KarlPalmen/events{/privacy}","received_events_url":"https://api.github.com/users/KarlPalmen/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/mantidproject/mantid/milestones/58","html_url":"https://github.com/mantidproject/mantid/milestones/Release%203.8","labels_url":"https://api.github.com/repos/mantidproject/mantid/milestones/58/labels","id":1505614,"number":58,"title":"Release 3.8","description":"","creator":{"login":"granrothge","id":5910574,"avatar_url":"https://avatars.githubusercontent.com/u/5910574?v=3","gravatar_id":"","url":"https://api.github.com/users/granrothge","html_url":"https://github.com/granrothge","followers_url":"https://api.github.com/users/granrothge/followers","following_url":"https://api.github.com/users/granrothge/following{/other_user}","gists_url":"https://api.github.com/users/granrothge/gists{/gist_id}","starred_url":"https://api.github.com/users/granrothge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/granrothge/subscriptions","organizations_url":"https://api.github.com/users/granrothge/orgs","repos_url":"https://api.github.com/users/granrothge/repos","events_url":"https://api.github.com/users/granrothge/events{/privacy}","received_events_url":"https://api.github.com/users/granrothge/received_events","type":"User","site_admin":false},"open_issues":690,"closed_issues":437,"state":"open","created_at":"2016-01-13T20:00:53Z","updated_at":"2016-07-27T08:50:43Z","due_on":"2016-10-09T23:00:00Z","closed_at":null},"comments":2,"created_at":"2016-07-26T09:37:52Z","updated_at":"2016-07-27T08:54:39Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mantidproject/mantid/pulls/17016","html_url":"https://github.com/mantidproject/mantid/pull/17016","diff_url":"https://github.com/mantidproject/mantid/pull/17016.diff","patch_url":"https://github.com/mantidproject/mantid/pull/17016.patch"},"body":"Enable use of `run_start` and `run_end` in muon interfaces.\r\n\r\n`run_start` and `run_end` have been added to the list of log values that can be used in the results table in Muon Analysis. They are available either as strings or as numeric values (seconds since start time of first run).\r\n\r\nIn the ALC interface, using the log values `run_start` and `run_end` now works as it should - the numeric values are seconds since the start of the first run.\r\n\r\n- [Online documentation](http://www.mantidproject.org/MuonAnalysisResultsTable#Values) updated for Muon Analysis\r\n- RST documentation updated for ALC\r\n- RST documentation updated for `PlotAsymmetryByLogValue`\r\n\r\n**To test:**\r\n\r\n1. *Muon Analysis*\r\n  - Open *Interfaces/Muon/Muon Analysis*\r\n  - Load a dataset, for example `MUSR00015189.nxs` from test data (or any muon data)\r\n  - Fit the data on the \"Data Analysis\" tab. Repeat with a couple of other datasets, using the same fitting model for each.\r\n  - Go to \"Results table\" tab. In the top table, there should be options to select `run_start` and `run_end` as either text or seconds.\r\n  - Select these options and generate the results table\r\n  - Text should be ISO-formatted date/time string as a label column\r\n  - Seconds should be number of seconds since first run start as an X column\r\n\r\n2. *ALC*\r\n  - Open *Interfaces/Muon/ALC*\r\n  - Set first and last datasets, for example `MUSR00015189` and `MUSR00015191` (test data)\r\n  - Set the log value dropdown to either `run_start` or `run_end`\r\n  - Click \"Load\" and check data is loaded and plotted. The X axis should be number of seconds since the first run start.\r\n\r\nFixes #13195.\r\n\r\n[Release notes](https://github.com/mantidproject/mantid/blob/cca8fc32bfbf63955490420561a23676fba5b114/docs/source/release/v3.8.0/muon.rst) have been updated.\r\n\r\n---\r\n\r\n#### Reviewer ####\r\n\r\nPlease comment on the following ([full description](http://www.mantidproject.org/Individual_Ticket_Testing)):\r\n\r\n##### Code Review #####\r\n\r\n- [x] Is the code of an acceptable quality?\r\n- [x] Does the code conform to the [coding standards](http://www.mantidproject.org/Coding_Standards)? Is it well structured with small focussed classes/methods/functions?\r\n- [x] Are there unit/system tests in place? Are the unit tests small and test the a class in isolation?\r\n- [x] If there are changes in the release notes then do they describe the changes appropriately?\r\n\r\n##### Functional Tests #####\r\n\r\n- [ ] Do changes function as described? Add comments below that describe the tests performed?\r\n- [ ] How do the changes handle unexpected situations, e.g. bad input?\r\n- [ ] Has the relevant documentation been added/updated?\r\n- [ ] Is user-facing documentation written in a user-friendly manner?\r\n- [ ] Has developer documentation been updated if required?\r\n\r\n- Does everything look good? Comment with the ship it emoji but don't merge. A member of `@mantidproject/gatekeepers` will take care of it.\r\n"},"comment":{"url":"https://api.github.com/repos/mantidproject/mantid/issues/comments/235527014","html_url":"https://github.com/mantidproject/mantid/pull/17016#issuecomment-235527014","issue_url":"https://api.github.com/repos/mantidproject/mantid/issues/17016","id":235527014,"user":{"login":"KarlPalmen","id":1133249,"avatar_url":"https://avatars.githubusercontent.com/u/1133249?v=3","gravatar_id":"","url":"https://api.github.com/users/KarlPalmen","html_url":"https://github.com/KarlPalmen","followers_url":"https://api.github.com/users/KarlPalmen/followers","following_url":"https://api.github.com/users/KarlPalmen/following{/other_user}","gists_url":"https://api.github.com/users/KarlPalmen/gists{/gist_id}","starred_url":"https://api.github.com/users/KarlPalmen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KarlPalmen/subscriptions","organizations_url":"https://api.github.com/users/KarlPalmen/orgs","repos_url":"https://api.github.com/users/KarlPalmen/repos","events_url":"https://api.github.com/users/KarlPalmen/events{/privacy}","received_events_url":"https://api.github.com/users/KarlPalmen/received_events","type":"User","site_admin":false},"created_at":"2016-07-27T08:54:39Z","updated_at":"2016-07-27T08:54:39Z","body":"When running the ALC, run_start, it plots the first run at 0 as expected. If run_end is selected, it plots the first run at somewhere between 50 and 100."}}
{"actor":{"display_login":"KarlPalmen"}}