{"action":"created","comment":{"url":"https://api.github.com/repos/RoboCup-SSL/ssl-vision/pulls/comments/83667807","pull_request_review_id":4496065,"id":83667807,"diff_hunk":"@@ -364,7 +364,6 @@ void PluginDVR::slotMovieSave() {\n         if (output.getNumBytes() > 0) {\n           //write file:\n           QString num = QString::number(i);\n-          int n = max(5,num.length());","path":"src/app/plugins/plugin_dvr.cpp","position":4,"original_position":4,"commit_id":"0c5334232b959a3c8a5e8330eb31776edc1a4afa","original_commit_id":"0c5334232b959a3c8a5e8330eb31776edc1a4afa","user":{"login":"joydeep-b","id":3406269,"avatar_url":"https://avatars.githubusercontent.com/u/3406269?v=3","gravatar_id":"","url":"https://api.github.com/users/joydeep-b","html_url":"https://github.com/joydeep-b","followers_url":"https://api.github.com/users/joydeep-b/followers","following_url":"https://api.github.com/users/joydeep-b/following{/other_user}","gists_url":"https://api.github.com/users/joydeep-b/gists{/gist_id}","starred_url":"https://api.github.com/users/joydeep-b/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joydeep-b/subscriptions","organizations_url":"https://api.github.com/users/joydeep-b/orgs","repos_url":"https://api.github.com/users/joydeep-b/repos","events_url":"https://api.github.com/users/joydeep-b/events{/privacy}","received_events_url":"https://api.github.com/users/joydeep-b/received_events","type":"User","site_admin":false},"body":"Could you please explain why this is no longer required?","created_at":"2016-10-17T15:24:12Z","updated_at":"2016-10-17T15:24:12Z","html_url":"https://github.com/RoboCup-SSL/ssl-vision/pull/53#discussion_r83667807","pull_request_url":"https://api.github.com/repos/RoboCup-SSL/ssl-vision/pulls/53","_links":{"self":{"href":"https://api.github.com/repos/RoboCup-SSL/ssl-vision/pulls/comments/83667807"},"html":{"href":"https://github.com/RoboCup-SSL/ssl-vision/pull/53#discussion_r83667807"},"pull_request":{"href":"https://api.github.com/repos/RoboCup-SSL/ssl-vision/pulls/53"}}},"pull_request":{"url":"https://api.github.com/repos/RoboCup-SSL/ssl-vision/pulls/53","id":59076841,"html_url":"https://github.com/RoboCup-SSL/ssl-vision/pull/53","diff_url":"https://github.com/RoboCup-SSL/ssl-vision/pull/53.diff","patch_url":"https://github.com/RoboCup-SSL/ssl-vision/pull/53.patch","issue_url":"https://api.github.com/repos/RoboCup-SSL/ssl-vision/issues/53","number":53,"state":"open","locked":false,"title":"Fix compiler warnings and default to -Wall","user":{"login":"MichaelEischer","id":9106997,"avatar_url":"https://avatars.githubusercontent.com/u/9106997?v=3","gravatar_id":"","url":"https://api.github.com/users/MichaelEischer","html_url":"https://github.com/MichaelEischer","followers_url":"https://api.github.com/users/MichaelEischer/followers","following_url":"https://api.github.com/users/MichaelEischer/following{/other_user}","gists_url":"https://api.github.com/users/MichaelEischer/gists{/gist_id}","starred_url":"https://api.github.com/users/MichaelEischer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MichaelEischer/subscriptions","organizations_url":"https://api.github.com/users/MichaelEischer/orgs","repos_url":"https://api.github.com/users/MichaelEischer/repos","events_url":"https://api.github.com/users/MichaelEischer/events{/privacy}","received_events_url":"https://api.github.com/users/MichaelEischer/received_events","type":"User","site_admin":false},"body":"This fixes all compiler warnings using g++ 5.2.1 (Ubuntu 15.10). Compiling should now also be possible using clang, but that results in a strange linker error for me (probably an incompatibility between g++ 5 and clang related to std::string).\r\n\r\nMost changes are unsigned vs signed int, unused variables.\r\n\r\nSpecial ones:\r\n- Allocate marker array in _cmpattern_teamdetector.cpp_ using `new[]`. This allows compilation using clang\r\n- Remove the TeamDetectorInterface from _cmpattern_teamdetector.h_. The interface is not used and defines an update function that differs from the one that's actually used.\r\n- Used isnan from cmath in _glcamera.h_ .\r\n- Fix operators in _gvector.h_ : `+=` would expand to `x = x += p.x;`. g++ complains about possibly undefined behavior. Replaced with `x += p.x`\r\n- In _random.cpp_ : `if (!left < 0)` is always false according to clang. The correct implementation is probably `if (left < 0)","created_at":"2016-02-11T18:58:36Z","updated_at":"2016-10-17T15:57:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3b33788ed8f820a5be396bf9dc844d6239c17327","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/RoboCup-SSL/ssl-vision/pulls/53/commits","review_comments_url":"https://api.github.com/repos/RoboCup-SSL/ssl-vision/pulls/53/comments","review_comment_url":"https://api.github.com/repos/RoboCup-SSL/ssl-vision/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RoboCup-SSL/ssl-vision/issues/53/comments","statuses_url":"https://api.github.com/repos/RoboCup-SSL/ssl-vision/statuses/0c5334232b959a3c8a5e8330eb31776edc1a4afa","head":{"label":"MichaelEischer:fix-compiler-warnings","ref":"fix-compiler-warnings","sha":"0c5334232b959a3c8a5e8330eb31776edc1a4afa","user":{"login":"MichaelEischer","id":9106997,"avatar_url":"https://avatars.githubusercontent.com/u/9106997?v=3","gravatar_id":"","url":"https://api.github.com/users/MichaelEischer","html_url":"https://github.com/MichaelEischer","followers_url":"https://api.github.com/users/MichaelEischer/followers","following_url":"https://api.github.com/users/MichaelEischer/following{/other_user}","gists_url":"https://api.github.com/users/MichaelEischer/gists{/gist_id}","starred_url":"https://api.github.com/users/MichaelEischer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MichaelEischer/subscriptions","organizations_url":"https://api.github.com/users/MichaelEischer/orgs","repos_url":"https://api.github.com/users/MichaelEischer/repos","events_url":"https://api.github.com/users/MichaelEischer/events{/privacy}","received_events_url":"https://api.github.com/users/MichaelEischer/received_events","type":"User","site_admin":false},"repo":{"id":51458055,"name":"ssl-vision","full_name":"MichaelEischer/ssl-vision","owner":{"login":"MichaelEischer","id":9106997,"avatar_url":"https://avatars.githubusercontent.com/u/9106997?v=3","gravatar_id":"","url":"https://api.github.com/users/MichaelEischer","html_url":"https://github.com/MichaelEischer","followers_url":"https://api.github.com/users/MichaelEischer/followers","following_url":"https://api.github.com/users/MichaelEischer/following{/other_user}","gists_url":"https://api.github.com/users/MichaelEischer/gists{/gist_id}","starred_url":"https://api.github.com/users/MichaelEischer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MichaelEischer/subscriptions","organizations_url":"https://api.github.com/users/MichaelEischer/orgs","repos_url":"https://api.github.com/users/MichaelEischer/repos","events_url":"https://api.github.com/users/MichaelEischer/events{/privacy}","received_events_url":"https://api.github.com/users/MichaelEischer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MichaelEischer/ssl-vision","description":"Shared Vision System For The RoboCup Small Size League","fork":true,"url":"https://api.github.com/repos/MichaelEischer/ssl-vision","forks_url":"https://api.github.com/repos/MichaelEischer/ssl-vision/forks","keys_url":"https://api.github.com/repos/MichaelEischer/ssl-vision/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MichaelEischer/ssl-vision/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MichaelEischer/ssl-vision/teams","hooks_url":"https://api.github.com/repos/MichaelEischer/ssl-vision/hooks","issue_events_url":"https://api.github.com/repos/MichaelEischer/ssl-vision/issues/events{/number}","events_url":"https://api.github.com/repos/MichaelEischer/ssl-vision/events","assignees_url":"https://api.github.com/repos/MichaelEischer/ssl-vision/assignees{/user}","branches_url":"https://api.github.com/repos/MichaelEischer/ssl-vision/branches{/branch}","tags_url":"https://api.github.com/repos/MichaelEischer/ssl-vision/tags","blobs_url":"https://api.github.com/repos/MichaelEischer/ssl-vision/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MichaelEischer/ssl-vision/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MichaelEischer/ssl-vision/git/refs{/sha}","trees_url":"https://api.github.com/repos/MichaelEischer/ssl-vision/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MichaelEischer/ssl-vision/statuses/{sha}","languages_url":"https://api.github.com/repos/MichaelEischer/ssl-vision/languages","stargazers_url":"https://api.github.com/repos/MichaelEischer/ssl-vision/stargazers","contributors_url":"https://api.github.com/repos/MichaelEischer/ssl-vision/contributors","subscribers_url":"https://api.github.com/repos/MichaelEischer/ssl-vision/subscribers","subscription_url":"https://api.github.com/repos/MichaelEischer/ssl-vision/subscription","commits_url":"https://api.github.com/repos/MichaelEischer/ssl-vision/commits{/sha}","git_commits_url":"https://api.github.com/repos/MichaelEischer/ssl-vision/git/commits{/sha}","comments_url":"https://api.github.com/repos/MichaelEischer/ssl-vision/comments{/number}","issue_comment_url":"https://api.github.com/repos/MichaelEischer/ssl-vision/issues/comments{/number}","contents_url":"https://api.github.com/repos/MichaelEischer/ssl-vision/contents/{+path}","compare_url":"https://api.github.com/repos/MichaelEischer/ssl-vision/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MichaelEischer/ssl-vision/merges","archive_url":"https://api.github.com/repos/MichaelEischer/ssl-vision/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MichaelEischer/ssl-vision/downloads","issues_url":"https://api.github.com/repos/MichaelEischer/ssl-vision/issues{/number}","pulls_url":"https://api.github.com/repos/MichaelEischer/ssl-vision/pulls{/number}","milestones_url":"https://api.github.com/repos/MichaelEischer/ssl-vision/milestones{/number}","notifications_url":"https://api.github.com/repos/MichaelEischer/ssl-vision/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MichaelEischer/ssl-vision/labels{/name}","releases_url":"https://api.github.com/repos/MichaelEischer/ssl-vision/releases{/id}","deployments_url":"https://api.github.com/repos/MichaelEischer/ssl-vision/deployments","created_at":"2016-02-10T17:31:12Z","updated_at":"2016-02-10T17:31:13Z","pushed_at":"2016-10-16T15:11:32Z","git_url":"git://github.com/MichaelEischer/ssl-vision.git","ssh_url":"git@github.com:MichaelEischer/ssl-vision.git","clone_url":"https://github.com/MichaelEischer/ssl-vision.git","svn_url":"https://github.com/MichaelEischer/ssl-vision","homepage":"","size":2237,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"RoboCup-SSL:master","ref":"master","sha":"25439a8bacf9009aff2d37f0ae95bf9805d164d3","user":{"login":"RoboCup-SSL","id":12736301,"avatar_url":"https://avatars.githubusercontent.com/u/12736301?v=3","gravatar_id":"","url":"https://api.github.com/users/RoboCup-SSL","html_url":"https://github.com/RoboCup-SSL","followers_url":"https://api.github.com/users/RoboCup-SSL/followers","following_url":"https://api.github.com/users/RoboCup-SSL/following{/other_user}","gists_url":"https://api.github.com/users/RoboCup-SSL/gists{/gist_id}","starred_url":"https://api.github.com/users/RoboCup-SSL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RoboCup-SSL/subscriptions","organizations_url":"https://api.github.com/users/RoboCup-SSL/orgs","repos_url":"https://api.github.com/users/RoboCup-SSL/repos","events_url":"https://api.github.com/users/RoboCup-SSL/events{/privacy}","received_events_url":"https://api.github.com/users/RoboCup-SSL/received_events","type":"Organization","site_admin":false},"repo":{"id":36824082,"name":"ssl-vision","full_name":"RoboCup-SSL/ssl-vision","owner":{"login":"RoboCup-SSL","id":12736301,"avatar_url":"https://avatars.githubusercontent.com/u/12736301?v=3","gravatar_id":"","url":"https://api.github.com/users/RoboCup-SSL","html_url":"https://github.com/RoboCup-SSL","followers_url":"https://api.github.com/users/RoboCup-SSL/followers","following_url":"https://api.github.com/users/RoboCup-SSL/following{/other_user}","gists_url":"https://api.github.com/users/RoboCup-SSL/gists{/gist_id}","starred_url":"https://api.github.com/users/RoboCup-SSL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RoboCup-SSL/subscriptions","organizations_url":"https://api.github.com/users/RoboCup-SSL/orgs","repos_url":"https://api.github.com/users/RoboCup-SSL/repos","events_url":"https://api.github.com/users/RoboCup-SSL/events{/privacy}","received_events_url":"https://api.github.com/users/RoboCup-SSL/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RoboCup-SSL/ssl-vision","description":"Shared Vision System For The RoboCup Small Size League","fork":false,"url":"https://api.github.com/repos/RoboCup-SSL/ssl-vision","forks_url":"https://api.github.com/repos/RoboCup-SSL/ssl-vision/forks","keys_url":"https://api.github.com/repos/RoboCup-SSL/ssl-vision/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RoboCup-SSL/ssl-vision/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RoboCup-SSL/ssl-vision/teams","hooks_url":"https://api.github.com/repos/RoboCup-SSL/ssl-vision/hooks","issue_events_url":"https://api.github.com/repos/RoboCup-SSL/ssl-vision/issues/events{/number}","events_url":"https://api.github.com/repos/RoboCup-SSL/ssl-vision/events","assignees_url":"https://api.github.com/repos/RoboCup-SSL/ssl-vision/assignees{/user}","branches_url":"https://api.github.com/repos/RoboCup-SSL/ssl-vision/branches{/branch}","tags_url":"https://api.github.com/repos/RoboCup-SSL/ssl-vision/tags","blobs_url":"https://api.github.com/repos/RoboCup-SSL/ssl-vision/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RoboCup-SSL/ssl-vision/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RoboCup-SSL/ssl-vision/git/refs{/sha}","trees_url":"https://api.github.com/repos/RoboCup-SSL/ssl-vision/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RoboCup-SSL/ssl-vision/statuses/{sha}","languages_url":"https://api.github.com/repos/RoboCup-SSL/ssl-vision/languages","stargazers_url":"https://api.github.com/repos/RoboCup-SSL/ssl-vision/stargazers","contributors_url":"https://api.github.com/repos/RoboCup-SSL/ssl-vision/contributors","subscribers_url":"https://api.github.com/repos/RoboCup-SSL/ssl-vision/subscribers","subscription_url":"https://api.github.com/repos/RoboCup-SSL/ssl-vision/subscription","commits_url":"https://api.github.com/repos/RoboCup-SSL/ssl-vision/commits{/sha}","git_commits_url":"https://api.github.com/repos/RoboCup-SSL/ssl-vision/git/commits{/sha}","comments_url":"https://api.github.com/repos/RoboCup-SSL/ssl-vision/comments{/number}","issue_comment_url":"https://api.github.com/repos/RoboCup-SSL/ssl-vision/issues/comments{/number}","contents_url":"https://api.github.com/repos/RoboCup-SSL/ssl-vision/contents/{+path}","compare_url":"https://api.github.com/repos/RoboCup-SSL/ssl-vision/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RoboCup-SSL/ssl-vision/merges","archive_url":"https://api.github.com/repos/RoboCup-SSL/ssl-vision/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RoboCup-SSL/ssl-vision/downloads","issues_url":"https://api.github.com/repos/RoboCup-SSL/ssl-vision/issues{/number}","pulls_url":"https://api.github.com/repos/RoboCup-SSL/ssl-vision/pulls{/number}","milestones_url":"https://api.github.com/repos/RoboCup-SSL/ssl-vision/milestones{/number}","notifications_url":"https://api.github.com/repos/RoboCup-SSL/ssl-vision/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RoboCup-SSL/ssl-vision/labels{/name}","releases_url":"https://api.github.com/repos/RoboCup-SSL/ssl-vision/releases{/id}","deployments_url":"https://api.github.com/repos/RoboCup-SSL/ssl-vision/deployments","created_at":"2015-06-03T18:59:53Z","updated_at":"2016-10-16T22:13:41Z","pushed_at":"2016-10-17T10:47:47Z","git_url":"git://github.com/RoboCup-SSL/ssl-vision.git","ssh_url":"git@github.com:RoboCup-SSL/ssl-vision.git","clone_url":"https://github.com/RoboCup-SSL/ssl-vision.git","svn_url":"https://github.com/RoboCup-SSL/ssl-vision","homepage":"","size":9612,"stargazers_count":22,"watchers_count":22,"language":"C++","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"open_issues_count":23,"forks":20,"open_issues":23,"watchers":22,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RoboCup-SSL/ssl-vision/pulls/53"},"html":{"href":"https://github.com/RoboCup-SSL/ssl-vision/pull/53"},"issue":{"href":"https://api.github.com/repos/RoboCup-SSL/ssl-vision/issues/53"},"comments":{"href":"https://api.github.com/repos/RoboCup-SSL/ssl-vision/issues/53/comments"},"review_comments":{"href":"https://api.github.com/repos/RoboCup-SSL/ssl-vision/pulls/53/comments"},"review_comment":{"href":"https://api.github.com/repos/RoboCup-SSL/ssl-vision/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RoboCup-SSL/ssl-vision/pulls/53/commits"},"statuses":{"href":"https://api.github.com/repos/RoboCup-SSL/ssl-vision/statuses/0c5334232b959a3c8a5e8330eb31776edc1a4afa"}}}}
{"actor":{"display_login":"joydeep-b"}}