{"action":"closed","issue":{"url":"https://api.github.com/repos/sphinx-doc/sphinx/issues/3293","repository_url":"https://api.github.com/repos/sphinx-doc/sphinx","labels_url":"https://api.github.com/repos/sphinx-doc/sphinx/issues/3293/labels{/name}","comments_url":"https://api.github.com/repos/sphinx-doc/sphinx/issues/3293/comments","events_url":"https://api.github.com/repos/sphinx-doc/sphinx/issues/3293/events","html_url":"https://github.com/sphinx-doc/sphinx/issues/3293","id":198194673,"number":3293,"title":"Search fails (appears to hang because ellipsis is cycling)","user":{"login":"tbhartman","id":896331,"avatar_url":"https://avatars.githubusercontent.com/u/896331?v=3","gravatar_id":"","url":"https://api.github.com/users/tbhartman","html_url":"https://github.com/tbhartman","followers_url":"https://api.github.com/users/tbhartman/followers","following_url":"https://api.github.com/users/tbhartman/following{/other_user}","gists_url":"https://api.github.com/users/tbhartman/gists{/gist_id}","starred_url":"https://api.github.com/users/tbhartman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbhartman/subscriptions","organizations_url":"https://api.github.com/users/tbhartman/orgs","repos_url":"https://api.github.com/users/tbhartman/repos","events_url":"https://api.github.com/users/tbhartman/events{/privacy}","received_events_url":"https://api.github.com/users/tbhartman/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-12-30T21:07:08Z","updated_at":"2017-01-01T10:41:41Z","closed_at":"2017-01-01T10:41:41Z","body":"Subject: search is not working properly\r\n\r\n### Problem\r\n- When I try to search for something, I see \"Searching...\" with the ellipsis cycling.  Sometimes I get some results, sometimes none.\r\n\r\n#### Procedure to reproduce the problem\r\n\r\nI see that in \"searchtools.js\" is the following:\r\n\r\n```\r\nelse if (DOCUMENTATION_OPTIONS.HAS_SOURCE) {\r\n          var suffix = DOCUMENTATION_OPTIONS.SOURCELINK_SUFFIX;\r\n          $.ajax({url: DOCUMENTATION_OPTIONS.URL_ROOT + '_sources/' + item[5] + (item[5].slice(-suffix.length) === suffix ? '' : suffix),\r\n                  dataType: \"text\",\r\n                  complete: function(jqxhr, textstatus) {\r\n                    var data = jqxhr.responseText;\r\n                    if (data !== '' && data !== undefined) {\r\n                      listItem.append(Search.makeSearchSummary(data, searchterms, hlterms));\r\n                    }\r\n                    Search.output.append(listItem);\r\n                    listItem.slideDown(5, function() {\r\n                      displayNextItem();\r\n                    });\r\n                  }});\r\n        }\r\n```\r\n\r\nBut in the html...\r\n\r\n```\r\n    <script type=\"text/javascript\">\r\n        var DOCUMENTATION_OPTIONS = {\r\n            URL_ROOT:'./',\r\n            VERSION:'0.0',\r\n            COLLAPSE_INDEX:false,\r\n            FILE_SUFFIX:'.html',\r\n            HAS_SOURCE:  true\r\n        };\r\n    </script>\r\n```\r\n\r\n`DOCUMENTATION_OPTIONS` has no property `SOURCELINK_SUFFIX`.  If I modify the JS by adding the line:\r\n\r\n```\r\nvar suffix = '.txt';\r\n```\r\n\r\nthen search appears to work fine.\r\n\r\n### Environment info\r\n- OS: Win7\r\n- Python version: 2.7\r\n- Sphinx version: v1.5.1\r\n- Chrome (haven't tried others)\r\n"}}
{"actor":{"display_login":"tk0miya"}}