{"action":"closed","number":51,"pull_request":{"url":"https://api.github.com/repos/franz-see/Robotframework-Database-Library/pulls/51","id":40803285,"html_url":"https://github.com/franz-see/Robotframework-Database-Library/pull/51","diff_url":"https://github.com/franz-see/Robotframework-Database-Library/pull/51.diff","patch_url":"https://github.com/franz-see/Robotframework-Database-Library/pull/51.patch","issue_url":"https://api.github.com/repos/franz-see/Robotframework-Database-Library/issues/51","number":51,"state":"closed","locked":false,"title":"Sqlalchemy fork?","user":{"login":"edbrannin","id":121909,"avatar_url":"https://avatars.githubusercontent.com/u/121909?v=3","gravatar_id":"","url":"https://api.github.com/users/edbrannin","html_url":"https://github.com/edbrannin","followers_url":"https://api.github.com/users/edbrannin/followers","following_url":"https://api.github.com/users/edbrannin/following{/other_user}","gists_url":"https://api.github.com/users/edbrannin/gists{/gist_id}","starred_url":"https://api.github.com/users/edbrannin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edbrannin/subscriptions","organizations_url":"https://api.github.com/users/edbrannin/orgs","repos_url":"https://api.github.com/users/edbrannin/repos","events_url":"https://api.github.com/users/edbrannin/events{/privacy}","received_events_url":"https://api.github.com/users/edbrannin/received_events","type":"User","site_admin":false},"body":"re: https://github.com/franz-see/Robotframework-Database-Library/issues/43\r\n\r\nThis is an attempt to fork DatabaseLibrary as SQLAlchemyLibrary.  I'm sharing this as a pull request because you expressed interest in seeing the result of this attempt back in #43.  (Note to self: next time, maybe don't _start_ with renaming the package.)\r\n\r\nI don't expect you to actually merge this because of the dependency-change, but if you want to incorporate these changes into the main project I'd love to work with you on it somehow.\r\n\r\nConsidering the state of https://github.com/franz-see/Robotframework-Database-Library/pull/44 I also don't particularly expect to look at this anytime soon -- but I would like to publish this to PyPI to start using at work early next week, so if I don't hear anything before then I'll go ahead and do it.\r\n\r\n(If I do fork long-term, I'm not sure what to do about the copyright statements -- definitely leave yours there, but to add a line for myself before/after each?)\r\n\r\nWith all that said -- Here's my first attempt.  \r\n* Passes all the SQLite tests after only changing the connection method.\r\n    * It's only been tested against sqlite on Python2.7 (next step: learn tox or something), then test against Oracle.\r\n* All Query/execute keywords accept **named_args\r\n\r\nCaveats:\r\n* It's only been tested against sqlite on Python2.7 (next step: learn tox or something), but it passes all the SQLite tests after only changing the connection method.\r\n\r\nNext up:\r\n* Learn tox, test on other Pythons\r\n* Test on Oracle\r\n* Add new Query/Assert keywords based on things I've wrapped around DatabaseLibrary at work\r\n    * Query for Single Column (with bonus assert-mode)\r\n    * Query for Single Value (with bonus assert-mode)\r\n    * Probably some others","created_at":"2015-07-24T18:38:36Z","updated_at":"2016-06-20T15:55:57Z","closed_at":"2016-06-20T15:55:57Z","merged_at":null,"merge_commit_sha":"b7d1dbbb1c5101fcc523a7342164552fa3b9ed92","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/franz-see/Robotframework-Database-Library/pulls/51/commits","review_comments_url":"https://api.github.com/repos/franz-see/Robotframework-Database-Library/pulls/51/comments","review_comment_url":"https://api.github.com/repos/franz-see/Robotframework-Database-Library/pulls/comments{/number}","comments_url":"https://api.github.com/repos/franz-see/Robotframework-Database-Library/issues/51/comments","statuses_url":"https://api.github.com/repos/franz-see/Robotframework-Database-Library/statuses/9aada3312e42dddf219920f38349301a2c70898d","head":{"label":"edbrannin:sqlalchemy-fork","ref":"sqlalchemy-fork","sha":"9aada3312e42dddf219920f38349301a2c70898d","user":{"login":"edbrannin","id":121909,"avatar_url":"https://avatars.githubusercontent.com/u/121909?v=3","gravatar_id":"","url":"https://api.github.com/users/edbrannin","html_url":"https://github.com/edbrannin","followers_url":"https://api.github.com/users/edbrannin/followers","following_url":"https://api.github.com/users/edbrannin/following{/other_user}","gists_url":"https://api.github.com/users/edbrannin/gists{/gist_id}","starred_url":"https://api.github.com/users/edbrannin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edbrannin/subscriptions","organizations_url":"https://api.github.com/users/edbrannin/orgs","repos_url":"https://api.github.com/users/edbrannin/repos","events_url":"https://api.github.com/users/edbrannin/events{/privacy}","received_events_url":"https://api.github.com/users/edbrannin/received_events","type":"User","site_admin":false},"repo":{"id":30221338,"name":"Robotframework-Database-Library","full_name":"edbrannin/Robotframework-Database-Library","owner":{"login":"edbrannin","id":121909,"avatar_url":"https://avatars.githubusercontent.com/u/121909?v=3","gravatar_id":"","url":"https://api.github.com/users/edbrannin","html_url":"https://github.com/edbrannin","followers_url":"https://api.github.com/users/edbrannin/followers","following_url":"https://api.github.com/users/edbrannin/following{/other_user}","gists_url":"https://api.github.com/users/edbrannin/gists{/gist_id}","starred_url":"https://api.github.com/users/edbrannin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edbrannin/subscriptions","organizations_url":"https://api.github.com/users/edbrannin/orgs","repos_url":"https://api.github.com/users/edbrannin/repos","events_url":"https://api.github.com/users/edbrannin/events{/privacy}","received_events_url":"https://api.github.com/users/edbrannin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/edbrannin/Robotframework-Database-Library","description":"Database Library contains utilities meant for Robot Framework's usage. This can allow you to query your database after an action has been made to verify the results. This is compatible* with any Database API Specification 2.0 module.","fork":true,"url":"https://api.github.com/repos/edbrannin/Robotframework-Database-Library","forks_url":"https://api.github.com/repos/edbrannin/Robotframework-Database-Library/forks","keys_url":"https://api.github.com/repos/edbrannin/Robotframework-Database-Library/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edbrannin/Robotframework-Database-Library/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edbrannin/Robotframework-Database-Library/teams","hooks_url":"https://api.github.com/repos/edbrannin/Robotframework-Database-Library/hooks","issue_events_url":"https://api.github.com/repos/edbrannin/Robotframework-Database-Library/issues/events{/number}","events_url":"https://api.github.com/repos/edbrannin/Robotframework-Database-Library/events","assignees_url":"https://api.github.com/repos/edbrannin/Robotframework-Database-Library/assignees{/user}","branches_url":"https://api.github.com/repos/edbrannin/Robotframework-Database-Library/branches{/branch}","tags_url":"https://api.github.com/repos/edbrannin/Robotframework-Database-Library/tags","blobs_url":"https://api.github.com/repos/edbrannin/Robotframework-Database-Library/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edbrannin/Robotframework-Database-Library/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edbrannin/Robotframework-Database-Library/git/refs{/sha}","trees_url":"https://api.github.com/repos/edbrannin/Robotframework-Database-Library/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edbrannin/Robotframework-Database-Library/statuses/{sha}","languages_url":"https://api.github.com/repos/edbrannin/Robotframework-Database-Library/languages","stargazers_url":"https://api.github.com/repos/edbrannin/Robotframework-Database-Library/stargazers","contributors_url":"https://api.github.com/repos/edbrannin/Robotframework-Database-Library/contributors","subscribers_url":"https://api.github.com/repos/edbrannin/Robotframework-Database-Library/subscribers","subscription_url":"https://api.github.com/repos/edbrannin/Robotframework-Database-Library/subscription","commits_url":"https://api.github.com/repos/edbrannin/Robotframework-Database-Library/commits{/sha}","git_commits_url":"https://api.github.com/repos/edbrannin/Robotframework-Database-Library/git/commits{/sha}","comments_url":"https://api.github.com/repos/edbrannin/Robotframework-Database-Library/comments{/number}","issue_comment_url":"https://api.github.com/repos/edbrannin/Robotframework-Database-Library/issues/comments{/number}","contents_url":"https://api.github.com/repos/edbrannin/Robotframework-Database-Library/contents/{+path}","compare_url":"https://api.github.com/repos/edbrannin/Robotframework-Database-Library/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edbrannin/Robotframework-Database-Library/merges","archive_url":"https://api.github.com/repos/edbrannin/Robotframework-Database-Library/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edbrannin/Robotframework-Database-Library/downloads","issues_url":"https://api.github.com/repos/edbrannin/Robotframework-Database-Library/issues{/number}","pulls_url":"https://api.github.com/repos/edbrannin/Robotframework-Database-Library/pulls{/number}","milestones_url":"https://api.github.com/repos/edbrannin/Robotframework-Database-Library/milestones{/number}","notifications_url":"https://api.github.com/repos/edbrannin/Robotframework-Database-Library/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edbrannin/Robotframework-Database-Library/labels{/name}","releases_url":"https://api.github.com/repos/edbrannin/Robotframework-Database-Library/releases{/id}","deployments_url":"https://api.github.com/repos/edbrannin/Robotframework-Database-Library/deployments","created_at":"2015-02-03T02:49:30Z","updated_at":"2015-02-03T05:38:40Z","pushed_at":"2015-07-24T18:18:22Z","git_url":"git://github.com/edbrannin/Robotframework-Database-Library.git","ssh_url":"git@github.com:edbrannin/Robotframework-Database-Library.git","clone_url":"https://github.com/edbrannin/Robotframework-Database-Library.git","svn_url":"https://github.com/edbrannin/Robotframework-Database-Library","homepage":"http://franz-see.github.com/Robotframework-Database-Library/","size":393,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"franz-see:master","ref":"master","sha":"c2d74121dc29233de923284de8040f48100450c8","user":{"login":"franz-see","id":499668,"avatar_url":"https://avatars.githubusercontent.com/u/499668?v=3","gravatar_id":"","url":"https://api.github.com/users/franz-see","html_url":"https://github.com/franz-see","followers_url":"https://api.github.com/users/franz-see/followers","following_url":"https://api.github.com/users/franz-see/following{/other_user}","gists_url":"https://api.github.com/users/franz-see/gists{/gist_id}","starred_url":"https://api.github.com/users/franz-see/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/franz-see/subscriptions","organizations_url":"https://api.github.com/users/franz-see/orgs","repos_url":"https://api.github.com/users/franz-see/repos","events_url":"https://api.github.com/users/franz-see/events{/privacy}","received_events_url":"https://api.github.com/users/franz-see/received_events","type":"User","site_admin":false},"repo":{"id":1118374,"name":"Robotframework-Database-Library","full_name":"franz-see/Robotframework-Database-Library","owner":{"login":"franz-see","id":499668,"avatar_url":"https://avatars.githubusercontent.com/u/499668?v=3","gravatar_id":"","url":"https://api.github.com/users/franz-see","html_url":"https://github.com/franz-see","followers_url":"https://api.github.com/users/franz-see/followers","following_url":"https://api.github.com/users/franz-see/following{/other_user}","gists_url":"https://api.github.com/users/franz-see/gists{/gist_id}","starred_url":"https://api.github.com/users/franz-see/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/franz-see/subscriptions","organizations_url":"https://api.github.com/users/franz-see/orgs","repos_url":"https://api.github.com/users/franz-see/repos","events_url":"https://api.github.com/users/franz-see/events{/privacy}","received_events_url":"https://api.github.com/users/franz-see/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/franz-see/Robotframework-Database-Library","description":"Database Library contains utilities meant for Robot Framework's usage. This can allow you to query your database after an action has been made to verify the results. This is compatible* with any Database API Specification 2.0 module.","fork":false,"url":"https://api.github.com/repos/franz-see/Robotframework-Database-Library","forks_url":"https://api.github.com/repos/franz-see/Robotframework-Database-Library/forks","keys_url":"https://api.github.com/repos/franz-see/Robotframework-Database-Library/keys{/key_id}","collaborators_url":"https://api.github.com/repos/franz-see/Robotframework-Database-Library/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/franz-see/Robotframework-Database-Library/teams","hooks_url":"https://api.github.com/repos/franz-see/Robotframework-Database-Library/hooks","issue_events_url":"https://api.github.com/repos/franz-see/Robotframework-Database-Library/issues/events{/number}","events_url":"https://api.github.com/repos/franz-see/Robotframework-Database-Library/events","assignees_url":"https://api.github.com/repos/franz-see/Robotframework-Database-Library/assignees{/user}","branches_url":"https://api.github.com/repos/franz-see/Robotframework-Database-Library/branches{/branch}","tags_url":"https://api.github.com/repos/franz-see/Robotframework-Database-Library/tags","blobs_url":"https://api.github.com/repos/franz-see/Robotframework-Database-Library/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/franz-see/Robotframework-Database-Library/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/franz-see/Robotframework-Database-Library/git/refs{/sha}","trees_url":"https://api.github.com/repos/franz-see/Robotframework-Database-Library/git/trees{/sha}","statuses_url":"https://api.github.com/repos/franz-see/Robotframework-Database-Library/statuses/{sha}","languages_url":"https://api.github.com/repos/franz-see/Robotframework-Database-Library/languages","stargazers_url":"https://api.github.com/repos/franz-see/Robotframework-Database-Library/stargazers","contributors_url":"https://api.github.com/repos/franz-see/Robotframework-Database-Library/contributors","subscribers_url":"https://api.github.com/repos/franz-see/Robotframework-Database-Library/subscribers","subscription_url":"https://api.github.com/repos/franz-see/Robotframework-Database-Library/subscription","commits_url":"https://api.github.com/repos/franz-see/Robotframework-Database-Library/commits{/sha}","git_commits_url":"https://api.github.com/repos/franz-see/Robotframework-Database-Library/git/commits{/sha}","comments_url":"https://api.github.com/repos/franz-see/Robotframework-Database-Library/comments{/number}","issue_comment_url":"https://api.github.com/repos/franz-see/Robotframework-Database-Library/issues/comments{/number}","contents_url":"https://api.github.com/repos/franz-see/Robotframework-Database-Library/contents/{+path}","compare_url":"https://api.github.com/repos/franz-see/Robotframework-Database-Library/compare/{base}...{head}","merges_url":"https://api.github.com/repos/franz-see/Robotframework-Database-Library/merges","archive_url":"https://api.github.com/repos/franz-see/Robotframework-Database-Library/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/franz-see/Robotframework-Database-Library/downloads","issues_url":"https://api.github.com/repos/franz-see/Robotframework-Database-Library/issues{/number}","pulls_url":"https://api.github.com/repos/franz-see/Robotframework-Database-Library/pulls{/number}","milestones_url":"https://api.github.com/repos/franz-see/Robotframework-Database-Library/milestones{/number}","notifications_url":"https://api.github.com/repos/franz-see/Robotframework-Database-Library/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/franz-see/Robotframework-Database-Library/labels{/name}","releases_url":"https://api.github.com/repos/franz-see/Robotframework-Database-Library/releases{/id}","deployments_url":"https://api.github.com/repos/franz-see/Robotframework-Database-Library/deployments","created_at":"2010-11-28T04:37:50Z","updated_at":"2016-06-12T03:43:34Z","pushed_at":"2016-06-20T15:25:23Z","git_url":"git://github.com/franz-see/Robotframework-Database-Library.git","ssh_url":"git@github.com:franz-see/Robotframework-Database-Library.git","clone_url":"https://github.com/franz-see/Robotframework-Database-Library.git","svn_url":"https://github.com/franz-see/Robotframework-Database-Library","homepage":"http://franz-see.github.com/Robotframework-Database-Library/","size":381,"stargazers_count":41,"watchers_count":41,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":62,"mirror_url":null,"open_issues_count":11,"forks":62,"open_issues":11,"watchers":41,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/franz-see/Robotframework-Database-Library/pulls/51"},"html":{"href":"https://github.com/franz-see/Robotframework-Database-Library/pull/51"},"issue":{"href":"https://api.github.com/repos/franz-see/Robotframework-Database-Library/issues/51"},"comments":{"href":"https://api.github.com/repos/franz-see/Robotframework-Database-Library/issues/51/comments"},"review_comments":{"href":"https://api.github.com/repos/franz-see/Robotframework-Database-Library/pulls/51/comments"},"review_comment":{"href":"https://api.github.com/repos/franz-see/Robotframework-Database-Library/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/franz-see/Robotframework-Database-Library/pulls/51/commits"},"statuses":{"href":"https://api.github.com/repos/franz-see/Robotframework-Database-Library/statuses/9aada3312e42dddf219920f38349301a2c70898d"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":0,"review_comments":0,"commits":19,"additions":400,"deletions":238,"changed_files":11}}
{"actor":{"display_login":"jerry57"}}