{"action":"created","comment":{"url":"https://api.github.com/repos/edx/edx-app-android/pulls/comments/76253169","id":76253169,"diff_hunk":"@@ -195,10 +195,7 @@ public void run() {\n             }\n \n             String filepath = null;\n-            // check if file available on local\n-            if (video.isVideoForWebOnly) {","path":"VideoLocker/src/main/java/org/edx/mobile/view/VideoListActivity.java","position":5,"original_position":5,"commit_id":"c0b94d27ce5299ed65777e3b95c76f17fbf3807c","original_commit_id":"c0b94d27ce5299ed65777e3b95c76f17fbf3807c","user":{"login":"BenjiLee","id":7101723,"avatar_url":"https://avatars.githubusercontent.com/u/7101723?v=3","gravatar_id":"","url":"https://api.github.com/users/BenjiLee","html_url":"https://github.com/BenjiLee","followers_url":"https://api.github.com/users/BenjiLee/followers","following_url":"https://api.github.com/users/BenjiLee/following{/other_user}","gists_url":"https://api.github.com/users/BenjiLee/gists{/gist_id}","starred_url":"https://api.github.com/users/BenjiLee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BenjiLee/subscriptions","organizations_url":"https://api.github.com/users/BenjiLee/orgs","repos_url":"https://api.github.com/users/BenjiLee/repos","events_url":"https://api.github.com/users/BenjiLee/events{/privacy}","received_events_url":"https://api.github.com/users/BenjiLee/received_events","type":"User","site_admin":false},"body":"I see that it's a warning, but I believe the change you added changes the logic.","created_at":"2016-08-25T14:26:42Z","updated_at":"2016-08-25T14:26:42Z","html_url":"https://github.com/edx/edx-app-android/pull/794#discussion_r76253169","pull_request_url":"https://api.github.com/repos/edx/edx-app-android/pulls/794","_links":{"self":{"href":"https://api.github.com/repos/edx/edx-app-android/pulls/comments/76253169"},"html":{"href":"https://github.com/edx/edx-app-android/pull/794#discussion_r76253169"},"pull_request":{"href":"https://api.github.com/repos/edx/edx-app-android/pulls/794"}}},"pull_request":{"url":"https://api.github.com/repos/edx/edx-app-android/pulls/794","id":80486323,"html_url":"https://github.com/edx/edx-app-android/pull/794","diff_url":"https://github.com/edx/edx-app-android/pull/794.diff","patch_url":"https://github.com/edx/edx-app-android/pull/794.patch","issue_url":"https://api.github.com/repos/edx/edx-app-android/issues/794","number":794,"state":"open","locked":false,"title":"MA-2363: Replaced flying snackbar with alert dialog","user":{"login":"mdinino","id":18707535,"avatar_url":"https://avatars.githubusercontent.com/u/18707535?v=3","gravatar_id":"","url":"https://api.github.com/users/mdinino","html_url":"https://github.com/mdinino","followers_url":"https://api.github.com/users/mdinino/followers","following_url":"https://api.github.com/users/mdinino/following{/other_user}","gists_url":"https://api.github.com/users/mdinino/gists{/gist_id}","starred_url":"https://api.github.com/users/mdinino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdinino/subscriptions","organizations_url":"https://api.github.com/users/mdinino/orgs","repos_url":"https://api.github.com/users/mdinino/repos","events_url":"https://api.github.com/users/mdinino/events{/privacy}","received_events_url":"https://api.github.com/users/mdinino/received_events","type":"User","site_admin":false},"body":"### Description\r\n\r\n[MA-2363](https://openedx.atlassian.net/browse/MA-2363)\r\n\r\nReplaced \"flying snackbar\" with a non-cancelable dialog. The dialog displays the header and the error message given to us, as well as a single \"OK\" button.\r\n\r\nPreviously there were 2 variants of the \"flying snackbar\": one that was shown permanently (until the root cause went away), and one that was only shown for a second. Now, all alerts remain util the user clicks \"OK\". In the rare case that an alert is already being displayed and a new one should be displayed, the old one is hidden and the new one is shown.\r\n\r\n### Testing\r\n- [ ] Unit, integration, acceptance tests as appropriate\r\n - Ensured that all documented \"flying snackbar\" messages are replaced with the modal dialog (i.e. there are no regressions). The places circumstances and the error message where the \"flying snackbar previously\" appeared are documented in the JIRA ticket.\r\n- Ensured that error dialog is displayed unit it is acknowledged by the user.\r\n- Ensured that, when TalkBack mode is on, talkback properly reads the error message when it appears.\r\n\r\n### Reviewers\r\nIf you've been tagged for review, please check your corresponding box once you've given the :+1:.\r\n- [ ] Code review: @1zaman \r\n- [ ] Code review: @miankhalid \r\n- [x] Code review: @bguertin \r\n- [ ] UI strings/error msgs review: @catong (The strings have not changed, but they are displayed in a new format, thought to include you)\r\n- [ ] Accessibility review: @cptvitamin\r\n- [ ] UX review: @marcotuts\r\n- [ ] FYI @someone @andy-armstrong \r\n","created_at":"2016-08-08T17:03:16Z","updated_at":"2016-08-25T14:26:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d571babec7a724afdc5a1f1458d253c8206dfcc9","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/edx/edx-app-android/pulls/794/commits","review_comments_url":"https://api.github.com/repos/edx/edx-app-android/pulls/794/comments","review_comment_url":"https://api.github.com/repos/edx/edx-app-android/pulls/comments{/number}","comments_url":"https://api.github.com/repos/edx/edx-app-android/issues/794/comments","statuses_url":"https://api.github.com/repos/edx/edx-app-android/statuses/c0b94d27ce5299ed65777e3b95c76f17fbf3807c","head":{"label":"edx:mdinino/replace_flying_snackbar","ref":"mdinino/replace_flying_snackbar","sha":"c0b94d27ce5299ed65777e3b95c76f17fbf3807c","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":29251742,"name":"edx-app-android","full_name":"edx/edx-app-android","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-app-android","description":"","fork":false,"url":"https://api.github.com/repos/edx/edx-app-android","forks_url":"https://api.github.com/repos/edx/edx-app-android/forks","keys_url":"https://api.github.com/repos/edx/edx-app-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-app-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-app-android/teams","hooks_url":"https://api.github.com/repos/edx/edx-app-android/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-app-android/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-app-android/events","assignees_url":"https://api.github.com/repos/edx/edx-app-android/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-app-android/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-app-android/tags","blobs_url":"https://api.github.com/repos/edx/edx-app-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-app-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-app-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-app-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-app-android/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-app-android/languages","stargazers_url":"https://api.github.com/repos/edx/edx-app-android/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-app-android/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-app-android/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-app-android/subscription","commits_url":"https://api.github.com/repos/edx/edx-app-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-app-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-app-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-app-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-app-android/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-app-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-app-android/merges","archive_url":"https://api.github.com/repos/edx/edx-app-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-app-android/downloads","issues_url":"https://api.github.com/repos/edx/edx-app-android/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-app-android/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-app-android/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-app-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-app-android/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-app-android/releases{/id}","deployments_url":"https://api.github.com/repos/edx/edx-app-android/deployments","created_at":"2015-01-14T15:49:47Z","updated_at":"2016-08-23T15:17:22Z","pushed_at":"2016-08-24T21:33:03Z","git_url":"git://github.com/edx/edx-app-android.git","ssh_url":"git@github.com:edx/edx-app-android.git","clone_url":"https://github.com/edx/edx-app-android.git","svn_url":"https://github.com/edx/edx-app-android","homepage":null,"size":23827,"stargazers_count":90,"watchers_count":90,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":96,"mirror_url":null,"open_issues_count":15,"forks":96,"open_issues":15,"watchers":90,"default_branch":"master"}},"base":{"label":"edx:master","ref":"master","sha":"29ba0874f4d2f451f6a80dfa739816106c5f0e13","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":29251742,"name":"edx-app-android","full_name":"edx/edx-app-android","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-app-android","description":"","fork":false,"url":"https://api.github.com/repos/edx/edx-app-android","forks_url":"https://api.github.com/repos/edx/edx-app-android/forks","keys_url":"https://api.github.com/repos/edx/edx-app-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-app-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-app-android/teams","hooks_url":"https://api.github.com/repos/edx/edx-app-android/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-app-android/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-app-android/events","assignees_url":"https://api.github.com/repos/edx/edx-app-android/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-app-android/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-app-android/tags","blobs_url":"https://api.github.com/repos/edx/edx-app-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-app-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-app-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-app-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-app-android/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-app-android/languages","stargazers_url":"https://api.github.com/repos/edx/edx-app-android/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-app-android/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-app-android/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-app-android/subscription","commits_url":"https://api.github.com/repos/edx/edx-app-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-app-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-app-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-app-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-app-android/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-app-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-app-android/merges","archive_url":"https://api.github.com/repos/edx/edx-app-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-app-android/downloads","issues_url":"https://api.github.com/repos/edx/edx-app-android/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-app-android/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-app-android/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-app-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-app-android/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-app-android/releases{/id}","deployments_url":"https://api.github.com/repos/edx/edx-app-android/deployments","created_at":"2015-01-14T15:49:47Z","updated_at":"2016-08-23T15:17:22Z","pushed_at":"2016-08-24T21:33:03Z","git_url":"git://github.com/edx/edx-app-android.git","ssh_url":"git@github.com:edx/edx-app-android.git","clone_url":"https://github.com/edx/edx-app-android.git","svn_url":"https://github.com/edx/edx-app-android","homepage":null,"size":23827,"stargazers_count":90,"watchers_count":90,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":96,"mirror_url":null,"open_issues_count":15,"forks":96,"open_issues":15,"watchers":90,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edx/edx-app-android/pulls/794"},"html":{"href":"https://github.com/edx/edx-app-android/pull/794"},"issue":{"href":"https://api.github.com/repos/edx/edx-app-android/issues/794"},"comments":{"href":"https://api.github.com/repos/edx/edx-app-android/issues/794/comments"},"review_comments":{"href":"https://api.github.com/repos/edx/edx-app-android/pulls/794/comments"},"review_comment":{"href":"https://api.github.com/repos/edx/edx-app-android/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/edx/edx-app-android/pulls/794/commits"},"statuses":{"href":"https://api.github.com/repos/edx/edx-app-android/statuses/c0b94d27ce5299ed65777e3b95c76f17fbf3807c"}}}}
{"actor":{"display_login":"BenjiLee"}}