{"action":"created","issue":{"url":"https://api.github.com/repos/javaslang/javaslang/issues/1180","repository_url":"https://api.github.com/repos/javaslang/javaslang","labels_url":"https://api.github.com/repos/javaslang/javaslang/issues/1180/labels{/name}","comments_url":"https://api.github.com/repos/javaslang/javaslang/issues/1180/comments","events_url":"https://api.github.com/repos/javaslang/javaslang/issues/1180/events","html_url":"https://github.com/javaslang/javaslang/pull/1180","id":138973924,"number":1180,"title":"Try.isEmpty() returns false even when it's a Success with null value","user":{"login":"ggalmazor","id":205913,"avatar_url":"https://avatars.githubusercontent.com/u/205913?v=3","gravatar_id":"","url":"https://api.github.com/users/ggalmazor","html_url":"https://github.com/ggalmazor","followers_url":"https://api.github.com/users/ggalmazor/followers","following_url":"https://api.github.com/users/ggalmazor/following{/other_user}","gists_url":"https://api.github.com/users/ggalmazor/gists{/gist_id}","starred_url":"https://api.github.com/users/ggalmazor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ggalmazor/subscriptions","organizations_url":"https://api.github.com/users/ggalmazor/orgs","repos_url":"https://api.github.com/users/ggalmazor/repos","events_url":"https://api.github.com/users/ggalmazor/events{/privacy}","received_events_url":"https://api.github.com/users/ggalmazor/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2016-03-07T13:04:29Z","updated_at":"2016-03-08T09:13:12Z","closed_at":"2016-03-08T08:02:07Z","pull_request":{"url":"https://api.github.com/repos/javaslang/javaslang/pulls/1180","html_url":"https://github.com/javaslang/javaslang/pull/1180","diff_url":"https://github.com/javaslang/javaslang/pull/1180.diff","patch_url":"https://github.com/javaslang/javaslang/pull/1180.patch"},"body":"It should return true to comply with: \r\n```Option.of(null).isDefined == Try.of(()->null).toOption().isDefined()```\r\n\r\nThis is also broken on 1.x branch. I can prepare a patch for that as well\r\n\r\nAlso, should ```Try.isEmpty()``` check for types that have an ```isEmpty()``` (like String, List, etc.) implementation and delegate the results? Problem is that there is no common hierarchic ancestor that guarantees the presence of such method. We could just make the \"best effort\" with known types.\r\n"},"comment":{"url":"https://api.github.com/repos/javaslang/javaslang/issues/comments/193681325","html_url":"https://github.com/javaslang/javaslang/pull/1180#issuecomment-193681325","issue_url":"https://api.github.com/repos/javaslang/javaslang/issues/1180","id":193681325,"user":{"login":"ggalmazor","id":205913,"avatar_url":"https://avatars.githubusercontent.com/u/205913?v=3","gravatar_id":"","url":"https://api.github.com/users/ggalmazor","html_url":"https://github.com/ggalmazor","followers_url":"https://api.github.com/users/ggalmazor/followers","following_url":"https://api.github.com/users/ggalmazor/following{/other_user}","gists_url":"https://api.github.com/users/ggalmazor/gists{/gist_id}","starred_url":"https://api.github.com/users/ggalmazor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ggalmazor/subscriptions","organizations_url":"https://api.github.com/users/ggalmazor/orgs","repos_url":"https://api.github.com/users/ggalmazor/repos","events_url":"https://api.github.com/users/ggalmazor/events{/privacy}","received_events_url":"https://api.github.com/users/ggalmazor/received_events","type":"User","site_admin":false},"created_at":"2016-03-08T09:13:12Z","updated_at":"2016-03-08T09:13:12Z","body":"Ok... That's what I'm doing right now.\r\n\r\nI'd want to understand why you'd need a Some(null). Not trying to be rude... really :) Could you provide an example?"}}