{"action":"created","comment":{"url":"https://api.github.com/repos/mapbox/mapbox-gl-js/pulls/comments/82253717","pull_request_review_id":3174439,"id":82253717,"diff_hunk":"@@ -51,10 +51,13 @@ RasterTileSource.prototype = util.inherit(Evented, {\n         function done(err, img) {\n             delete tile.request;\n \n-            if (tile.aborted)\n-                return;\n+            if (tile.aborted) {\n+                this.state = 'unloaded';\n+                return callback(null);\n+            }","path":"js/source/raster_tile_source.js","position":9,"original_position":9,"commit_id":"770d28ebfc4cf98608792923b17ea6966dc321a9","original_commit_id":"770d28ebfc4cf98608792923b17ea6966dc321a9","user":{"login":"vicapow","id":583385,"avatar_url":"https://avatars.githubusercontent.com/u/583385?v=3","gravatar_id":"","url":"https://api.github.com/users/vicapow","html_url":"https://github.com/vicapow","followers_url":"https://api.github.com/users/vicapow/followers","following_url":"https://api.github.com/users/vicapow/following{/other_user}","gists_url":"https://api.github.com/users/vicapow/gists{/gist_id}","starred_url":"https://api.github.com/users/vicapow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vicapow/subscriptions","organizations_url":"https://api.github.com/users/vicapow/orgs","repos_url":"https://api.github.com/users/vicapow/repos","events_url":"https://api.github.com/users/vicapow/events{/privacy}","received_events_url":"https://api.github.com/users/vicapow/received_events","type":"User","site_admin":false},"body":"> I'm interested in working with you to fix one of those two blockers\r\n\r\nHappy to help with some guidance on how best to write tests for this.","created_at":"2016-10-06T18:30:30Z","updated_at":"2016-10-06T18:30:30Z","html_url":"https://github.com/mapbox/mapbox-gl-js/pull/3302#discussion_r82253717","pull_request_url":"https://api.github.com/repos/mapbox/mapbox-gl-js/pulls/3302","_links":{"self":{"href":"https://api.github.com/repos/mapbox/mapbox-gl-js/pulls/comments/82253717"},"html":{"href":"https://github.com/mapbox/mapbox-gl-js/pull/3302#discussion_r82253717"},"pull_request":{"href":"https://api.github.com/repos/mapbox/mapbox-gl-js/pulls/3302"}}},"pull_request":{"url":"https://api.github.com/repos/mapbox/mapbox-gl-js/pulls/3302","id":88218911,"html_url":"https://github.com/mapbox/mapbox-gl-js/pull/3302","diff_url":"https://github.com/mapbox/mapbox-gl-js/pull/3302.diff","patch_url":"https://github.com/mapbox/mapbox-gl-js/pull/3302.patch","issue_url":"https://api.github.com/repos/mapbox/mapbox-gl-js/issues/3302","number":3302,"state":"open","locked":false,"title":"Fix a bug preventing map.loaded() from returning true with raster tiles.","user":{"login":"vicapow","id":583385,"avatar_url":"https://avatars.githubusercontent.com/u/583385?v=3","gravatar_id":"","url":"https://api.github.com/users/vicapow","html_url":"https://github.com/vicapow","followers_url":"https://api.github.com/users/vicapow/followers","following_url":"https://api.github.com/users/vicapow/following{/other_user}","gists_url":"https://api.github.com/users/vicapow/gists{/gist_id}","starred_url":"https://api.github.com/users/vicapow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vicapow/subscriptions","organizations_url":"https://api.github.com/users/vicapow/orgs","repos_url":"https://api.github.com/users/vicapow/repos","events_url":"https://api.github.com/users/vicapow/events{/privacy}","received_events_url":"https://api.github.com/users/vicapow/received_events","type":"User","site_admin":false},"body":"## Launch Checklist\r\n\r\n* Uses a transparent png when there's no content from raster tiles.\r\n* Removes unused `return img;` because `getArrayBuffer` does nothing with the returned value from it's callback.\r\n* properly sets the tile state when the request is aborted or errors.\r\n","created_at":"2016-10-06T08:35:30Z","updated_at":"2016-10-06T18:30:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6bd57c6c814927714ca89ef11a39851f62319532","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mapbox/mapbox-gl-js/pulls/3302/commits","review_comments_url":"https://api.github.com/repos/mapbox/mapbox-gl-js/pulls/3302/comments","review_comment_url":"https://api.github.com/repos/mapbox/mapbox-gl-js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mapbox/mapbox-gl-js/issues/3302/comments","statuses_url":"https://api.github.com/repos/mapbox/mapbox-gl-js/statuses/770d28ebfc4cf98608792923b17ea6966dc321a9","head":{"label":"vicapow:master","ref":"master","sha":"770d28ebfc4cf98608792923b17ea6966dc321a9","user":{"login":"vicapow","id":583385,"avatar_url":"https://avatars.githubusercontent.com/u/583385?v=3","gravatar_id":"","url":"https://api.github.com/users/vicapow","html_url":"https://github.com/vicapow","followers_url":"https://api.github.com/users/vicapow/followers","following_url":"https://api.github.com/users/vicapow/following{/other_user}","gists_url":"https://api.github.com/users/vicapow/gists{/gist_id}","starred_url":"https://api.github.com/users/vicapow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vicapow/subscriptions","organizations_url":"https://api.github.com/users/vicapow/orgs","repos_url":"https://api.github.com/users/vicapow/repos","events_url":"https://api.github.com/users/vicapow/events{/privacy}","received_events_url":"https://api.github.com/users/vicapow/received_events","type":"User","site_admin":false},"repo":{"id":36156398,"name":"mapbox-gl-js","full_name":"vicapow/mapbox-gl-js","owner":{"login":"vicapow","id":583385,"avatar_url":"https://avatars.githubusercontent.com/u/583385?v=3","gravatar_id":"","url":"https://api.github.com/users/vicapow","html_url":"https://github.com/vicapow","followers_url":"https://api.github.com/users/vicapow/followers","following_url":"https://api.github.com/users/vicapow/following{/other_user}","gists_url":"https://api.github.com/users/vicapow/gists{/gist_id}","starred_url":"https://api.github.com/users/vicapow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vicapow/subscriptions","organizations_url":"https://api.github.com/users/vicapow/orgs","repos_url":"https://api.github.com/users/vicapow/repos","events_url":"https://api.github.com/users/vicapow/events{/privacy}","received_events_url":"https://api.github.com/users/vicapow/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vicapow/mapbox-gl-js","description":"JavaScript/WebGL vector maps library","fork":true,"url":"https://api.github.com/repos/vicapow/mapbox-gl-js","forks_url":"https://api.github.com/repos/vicapow/mapbox-gl-js/forks","keys_url":"https://api.github.com/repos/vicapow/mapbox-gl-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vicapow/mapbox-gl-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vicapow/mapbox-gl-js/teams","hooks_url":"https://api.github.com/repos/vicapow/mapbox-gl-js/hooks","issue_events_url":"https://api.github.com/repos/vicapow/mapbox-gl-js/issues/events{/number}","events_url":"https://api.github.com/repos/vicapow/mapbox-gl-js/events","assignees_url":"https://api.github.com/repos/vicapow/mapbox-gl-js/assignees{/user}","branches_url":"https://api.github.com/repos/vicapow/mapbox-gl-js/branches{/branch}","tags_url":"https://api.github.com/repos/vicapow/mapbox-gl-js/tags","blobs_url":"https://api.github.com/repos/vicapow/mapbox-gl-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vicapow/mapbox-gl-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vicapow/mapbox-gl-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/vicapow/mapbox-gl-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vicapow/mapbox-gl-js/statuses/{sha}","languages_url":"https://api.github.com/repos/vicapow/mapbox-gl-js/languages","stargazers_url":"https://api.github.com/repos/vicapow/mapbox-gl-js/stargazers","contributors_url":"https://api.github.com/repos/vicapow/mapbox-gl-js/contributors","subscribers_url":"https://api.github.com/repos/vicapow/mapbox-gl-js/subscribers","subscription_url":"https://api.github.com/repos/vicapow/mapbox-gl-js/subscription","commits_url":"https://api.github.com/repos/vicapow/mapbox-gl-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/vicapow/mapbox-gl-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/vicapow/mapbox-gl-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/vicapow/mapbox-gl-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/vicapow/mapbox-gl-js/contents/{+path}","compare_url":"https://api.github.com/repos/vicapow/mapbox-gl-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vicapow/mapbox-gl-js/merges","archive_url":"https://api.github.com/repos/vicapow/mapbox-gl-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vicapow/mapbox-gl-js/downloads","issues_url":"https://api.github.com/repos/vicapow/mapbox-gl-js/issues{/number}","pulls_url":"https://api.github.com/repos/vicapow/mapbox-gl-js/pulls{/number}","milestones_url":"https://api.github.com/repos/vicapow/mapbox-gl-js/milestones{/number}","notifications_url":"https://api.github.com/repos/vicapow/mapbox-gl-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vicapow/mapbox-gl-js/labels{/name}","releases_url":"https://api.github.com/repos/vicapow/mapbox-gl-js/releases{/id}","deployments_url":"https://api.github.com/repos/vicapow/mapbox-gl-js/deployments","created_at":"2015-05-24T04:46:04Z","updated_at":"2016-10-06T08:31:01Z","pushed_at":"2016-10-06T08:30:13Z","git_url":"git://github.com/vicapow/mapbox-gl-js.git","ssh_url":"git@github.com:vicapow/mapbox-gl-js.git","clone_url":"https://github.com/vicapow/mapbox-gl-js.git","svn_url":"https://github.com/vicapow/mapbox-gl-js","homepage":"https://www.mapbox.com/mapbox-gl/","size":15590,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mapbox:master","ref":"master","sha":"8fe56f50d48595b205d7230e8c4db01ae6e2709d","user":{"login":"mapbox","id":600935,"avatar_url":"https://avatars.githubusercontent.com/u/600935?v=3","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"repo":{"id":8629417,"name":"mapbox-gl-js","full_name":"mapbox/mapbox-gl-js","owner":{"login":"mapbox","id":600935,"avatar_url":"https://avatars.githubusercontent.com/u/600935?v=3","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mapbox/mapbox-gl-js","description":"Interactive vector maps in the browser, powered by WebGL","fork":false,"url":"https://api.github.com/repos/mapbox/mapbox-gl-js","forks_url":"https://api.github.com/repos/mapbox/mapbox-gl-js/forks","keys_url":"https://api.github.com/repos/mapbox/mapbox-gl-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapbox/mapbox-gl-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapbox/mapbox-gl-js/teams","hooks_url":"https://api.github.com/repos/mapbox/mapbox-gl-js/hooks","issue_events_url":"https://api.github.com/repos/mapbox/mapbox-gl-js/issues/events{/number}","events_url":"https://api.github.com/repos/mapbox/mapbox-gl-js/events","assignees_url":"https://api.github.com/repos/mapbox/mapbox-gl-js/assignees{/user}","branches_url":"https://api.github.com/repos/mapbox/mapbox-gl-js/branches{/branch}","tags_url":"https://api.github.com/repos/mapbox/mapbox-gl-js/tags","blobs_url":"https://api.github.com/repos/mapbox/mapbox-gl-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapbox/mapbox-gl-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapbox/mapbox-gl-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapbox/mapbox-gl-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapbox/mapbox-gl-js/statuses/{sha}","languages_url":"https://api.github.com/repos/mapbox/mapbox-gl-js/languages","stargazers_url":"https://api.github.com/repos/mapbox/mapbox-gl-js/stargazers","contributors_url":"https://api.github.com/repos/mapbox/mapbox-gl-js/contributors","subscribers_url":"https://api.github.com/repos/mapbox/mapbox-gl-js/subscribers","subscription_url":"https://api.github.com/repos/mapbox/mapbox-gl-js/subscription","commits_url":"https://api.github.com/repos/mapbox/mapbox-gl-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapbox/mapbox-gl-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapbox/mapbox-gl-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapbox/mapbox-gl-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapbox/mapbox-gl-js/contents/{+path}","compare_url":"https://api.github.com/repos/mapbox/mapbox-gl-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapbox/mapbox-gl-js/merges","archive_url":"https://api.github.com/repos/mapbox/mapbox-gl-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapbox/mapbox-gl-js/downloads","issues_url":"https://api.github.com/repos/mapbox/mapbox-gl-js/issues{/number}","pulls_url":"https://api.github.com/repos/mapbox/mapbox-gl-js/pulls{/number}","milestones_url":"https://api.github.com/repos/mapbox/mapbox-gl-js/milestones{/number}","notifications_url":"https://api.github.com/repos/mapbox/mapbox-gl-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapbox/mapbox-gl-js/labels{/name}","releases_url":"https://api.github.com/repos/mapbox/mapbox-gl-js/releases{/id}","deployments_url":"https://api.github.com/repos/mapbox/mapbox-gl-js/deployments","created_at":"2013-03-07T14:45:24Z","updated_at":"2016-10-06T15:20:48Z","pushed_at":"2016-10-06T17:58:54Z","git_url":"git://github.com/mapbox/mapbox-gl-js.git","ssh_url":"git@github.com:mapbox/mapbox-gl-js.git","clone_url":"https://github.com/mapbox/mapbox-gl-js.git","svn_url":"https://github.com/mapbox/mapbox-gl-js","homepage":"https://www.mapbox.com/mapbox-gl-js/","size":31641,"stargazers_count":1242,"watchers_count":1242,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":254,"mirror_url":null,"open_issues_count":295,"forks":254,"open_issues":295,"watchers":1242,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mapbox/mapbox-gl-js/pulls/3302"},"html":{"href":"https://github.com/mapbox/mapbox-gl-js/pull/3302"},"issue":{"href":"https://api.github.com/repos/mapbox/mapbox-gl-js/issues/3302"},"comments":{"href":"https://api.github.com/repos/mapbox/mapbox-gl-js/issues/3302/comments"},"review_comments":{"href":"https://api.github.com/repos/mapbox/mapbox-gl-js/pulls/3302/comments"},"review_comment":{"href":"https://api.github.com/repos/mapbox/mapbox-gl-js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mapbox/mapbox-gl-js/pulls/3302/commits"},"statuses":{"href":"https://api.github.com/repos/mapbox/mapbox-gl-js/statuses/770d28ebfc4cf98608792923b17ea6966dc321a9"}}}}
{"actor":{"display_login":"vicapow"}}