{"action":"closed","number":463,"pull_request":{"url":"https://api.github.com/repos/oasp/oasp4j/pulls/463","id":80207026,"html_url":"https://github.com/oasp/oasp4j/pull/463","diff_url":"https://github.com/oasp/oasp4j/pull/463.diff","patch_url":"https://github.com/oasp/oasp4j/pull/463.patch","issue_url":"https://api.github.com/repos/oasp/oasp4j/issues/463","number":463,"state":"closed","locked":false,"title":"Cleanup and restructure of the security","user":{"login":"sroeger","id":19531970,"avatar_url":"https://avatars.githubusercontent.com/u/19531970?v=3","gravatar_id":"","url":"https://api.github.com/users/sroeger","html_url":"https://github.com/sroeger","followers_url":"https://api.github.com/users/sroeger/followers","following_url":"https://api.github.com/users/sroeger/following{/other_user}","gists_url":"https://api.github.com/users/sroeger/gists{/gist_id}","starred_url":"https://api.github.com/users/sroeger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sroeger/subscriptions","organizations_url":"https://api.github.com/users/sroeger/orgs","repos_url":"https://api.github.com/users/sroeger/repos","events_url":"https://api.github.com/users/sroeger/events{/privacy}","received_events_url":"https://api.github.com/users/sroeger/received_events","type":"User","site_admin":false},"body":"This PR offers a solution to the Issue #424 and #456.\r\n\r\nI tried to use as many of Spring Security framework default function as possible. The problem is our customized access control which has to provide authorities to the user logging in.\r\nI propose a `BaseUserDetailsService` implementation of `UserDetailsService` to do this job. The already used in-memory authentication is kept but one has to use two `ProviderManager` s now with the same type of `AuthenticationProvider` implementations `DaoAuthenticationProvider` but different `UserDetailsService` s attached to them. Is this good practice?\r\nNow both login procedures work, the form login and the rest login at `../services/rest/login`.\r\nComments are appreciated.","created_at":"2016-08-05T08:29:49Z","updated_at":"2016-09-30T18:45:53Z","closed_at":"2016-09-30T18:45:53Z","merged_at":null,"merge_commit_sha":"1f63fdc8b6155de38011d48574c9ff9334ecd485","assignee":{"login":"jomora","id":5971366,"avatar_url":"https://avatars.githubusercontent.com/u/5971366?v=3","gravatar_id":"","url":"https://api.github.com/users/jomora","html_url":"https://github.com/jomora","followers_url":"https://api.github.com/users/jomora/followers","following_url":"https://api.github.com/users/jomora/following{/other_user}","gists_url":"https://api.github.com/users/jomora/gists{/gist_id}","starred_url":"https://api.github.com/users/jomora/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jomora/subscriptions","organizations_url":"https://api.github.com/users/jomora/orgs","repos_url":"https://api.github.com/users/jomora/repos","events_url":"https://api.github.com/users/jomora/events{/privacy}","received_events_url":"https://api.github.com/users/jomora/received_events","type":"User","site_admin":false},"assignees":[{"login":"jomora","id":5971366,"avatar_url":"https://avatars.githubusercontent.com/u/5971366?v=3","gravatar_id":"","url":"https://api.github.com/users/jomora","html_url":"https://github.com/jomora","followers_url":"https://api.github.com/users/jomora/followers","following_url":"https://api.github.com/users/jomora/following{/other_user}","gists_url":"https://api.github.com/users/jomora/gists{/gist_id}","starred_url":"https://api.github.com/users/jomora/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jomora/subscriptions","organizations_url":"https://api.github.com/users/jomora/orgs","repos_url":"https://api.github.com/users/jomora/repos","events_url":"https://api.github.com/users/jomora/events{/privacy}","received_events_url":"https://api.github.com/users/jomora/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/oasp/oasp4j/milestones/19","html_url":"https://github.com/oasp/oasp4j/milestones/oasp:2.2.0","labels_url":"https://api.github.com/repos/oasp/oasp4j/milestones/19/labels","id":1834862,"number":19,"title":"oasp:2.2.0","description":"","creator":{"login":"hohwille","id":1923119,"avatar_url":"https://avatars.githubusercontent.com/u/1923119?v=3","gravatar_id":"","url":"https://api.github.com/users/hohwille","html_url":"https://github.com/hohwille","followers_url":"https://api.github.com/users/hohwille/followers","following_url":"https://api.github.com/users/hohwille/following{/other_user}","gists_url":"https://api.github.com/users/hohwille/gists{/gist_id}","starred_url":"https://api.github.com/users/hohwille/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hohwille/subscriptions","organizations_url":"https://api.github.com/users/hohwille/orgs","repos_url":"https://api.github.com/users/hohwille/repos","events_url":"https://api.github.com/users/hohwille/events{/privacy}","received_events_url":"https://api.github.com/users/hohwille/received_events","type":"User","site_admin":false},"open_issues":13,"closed_issues":7,"state":"open","created_at":"2016-06-17T15:26:28Z","updated_at":"2016-09-30T18:45:53Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/oasp/oasp4j/pulls/463/commits","review_comments_url":"https://api.github.com/repos/oasp/oasp4j/pulls/463/comments","review_comment_url":"https://api.github.com/repos/oasp/oasp4j/pulls/comments{/number}","comments_url":"https://api.github.com/repos/oasp/oasp4j/issues/463/comments","statuses_url":"https://api.github.com/repos/oasp/oasp4j/statuses/b0af5f5e36e3a83225548774eed2fd1795f8adc1","head":{"label":"sroeger:newDevelop","ref":"newDevelop","sha":"b0af5f5e36e3a83225548774eed2fd1795f8adc1","user":{"login":"sroeger","id":19531970,"avatar_url":"https://avatars.githubusercontent.com/u/19531970?v=3","gravatar_id":"","url":"https://api.github.com/users/sroeger","html_url":"https://github.com/sroeger","followers_url":"https://api.github.com/users/sroeger/followers","following_url":"https://api.github.com/users/sroeger/following{/other_user}","gists_url":"https://api.github.com/users/sroeger/gists{/gist_id}","starred_url":"https://api.github.com/users/sroeger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sroeger/subscriptions","organizations_url":"https://api.github.com/users/sroeger/orgs","repos_url":"https://api.github.com/users/sroeger/repos","events_url":"https://api.github.com/users/sroeger/events{/privacy}","received_events_url":"https://api.github.com/users/sroeger/received_events","type":"User","site_admin":false},"repo":{"id":59480665,"name":"oasp4j","full_name":"sroeger/oasp4j","owner":{"login":"sroeger","id":19531970,"avatar_url":"https://avatars.githubusercontent.com/u/19531970?v=3","gravatar_id":"","url":"https://api.github.com/users/sroeger","html_url":"https://github.com/sroeger","followers_url":"https://api.github.com/users/sroeger/followers","following_url":"https://api.github.com/users/sroeger/following{/other_user}","gists_url":"https://api.github.com/users/sroeger/gists{/gist_id}","starred_url":"https://api.github.com/users/sroeger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sroeger/subscriptions","organizations_url":"https://api.github.com/users/sroeger/orgs","repos_url":"https://api.github.com/users/sroeger/repos","events_url":"https://api.github.com/users/sroeger/events{/privacy}","received_events_url":"https://api.github.com/users/sroeger/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sroeger/oasp4j","description":"The Open Application Standard Platform for Java","fork":true,"url":"https://api.github.com/repos/sroeger/oasp4j","forks_url":"https://api.github.com/repos/sroeger/oasp4j/forks","keys_url":"https://api.github.com/repos/sroeger/oasp4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sroeger/oasp4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sroeger/oasp4j/teams","hooks_url":"https://api.github.com/repos/sroeger/oasp4j/hooks","issue_events_url":"https://api.github.com/repos/sroeger/oasp4j/issues/events{/number}","events_url":"https://api.github.com/repos/sroeger/oasp4j/events","assignees_url":"https://api.github.com/repos/sroeger/oasp4j/assignees{/user}","branches_url":"https://api.github.com/repos/sroeger/oasp4j/branches{/branch}","tags_url":"https://api.github.com/repos/sroeger/oasp4j/tags","blobs_url":"https://api.github.com/repos/sroeger/oasp4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sroeger/oasp4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sroeger/oasp4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/sroeger/oasp4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sroeger/oasp4j/statuses/{sha}","languages_url":"https://api.github.com/repos/sroeger/oasp4j/languages","stargazers_url":"https://api.github.com/repos/sroeger/oasp4j/stargazers","contributors_url":"https://api.github.com/repos/sroeger/oasp4j/contributors","subscribers_url":"https://api.github.com/repos/sroeger/oasp4j/subscribers","subscription_url":"https://api.github.com/repos/sroeger/oasp4j/subscription","commits_url":"https://api.github.com/repos/sroeger/oasp4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/sroeger/oasp4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/sroeger/oasp4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/sroeger/oasp4j/issues/comments{/number}","contents_url":"https://api.github.com/repos/sroeger/oasp4j/contents/{+path}","compare_url":"https://api.github.com/repos/sroeger/oasp4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sroeger/oasp4j/merges","archive_url":"https://api.github.com/repos/sroeger/oasp4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sroeger/oasp4j/downloads","issues_url":"https://api.github.com/repos/sroeger/oasp4j/issues{/number}","pulls_url":"https://api.github.com/repos/sroeger/oasp4j/pulls{/number}","milestones_url":"https://api.github.com/repos/sroeger/oasp4j/milestones{/number}","notifications_url":"https://api.github.com/repos/sroeger/oasp4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sroeger/oasp4j/labels{/name}","releases_url":"https://api.github.com/repos/sroeger/oasp4j/releases{/id}","deployments_url":"https://api.github.com/repos/sroeger/oasp4j/deployments","created_at":"2016-05-23T12:24:23Z","updated_at":"2016-07-21T09:54:08Z","pushed_at":"2016-09-02T08:54:37Z","git_url":"git://github.com/sroeger/oasp4j.git","ssh_url":"git@github.com:sroeger/oasp4j.git","clone_url":"https://github.com/sroeger/oasp4j.git","svn_url":"https://github.com/sroeger/oasp4j","homepage":null,"size":2204,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"oasp:develop","ref":"develop","sha":"92c2a5ee1848cbf39bc12585e4c7c104d1ad213e","user":{"login":"oasp","id":9847033,"avatar_url":"https://avatars.githubusercontent.com/u/9847033?v=3","gravatar_id":"","url":"https://api.github.com/users/oasp","html_url":"https://github.com/oasp","followers_url":"https://api.github.com/users/oasp/followers","following_url":"https://api.github.com/users/oasp/following{/other_user}","gists_url":"https://api.github.com/users/oasp/gists{/gist_id}","starred_url":"https://api.github.com/users/oasp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oasp/subscriptions","organizations_url":"https://api.github.com/users/oasp/orgs","repos_url":"https://api.github.com/users/oasp/repos","events_url":"https://api.github.com/users/oasp/events{/privacy}","received_events_url":"https://api.github.com/users/oasp/received_events","type":"Organization","site_admin":false},"repo":{"id":20517345,"name":"oasp4j","full_name":"oasp/oasp4j","owner":{"login":"oasp","id":9847033,"avatar_url":"https://avatars.githubusercontent.com/u/9847033?v=3","gravatar_id":"","url":"https://api.github.com/users/oasp","html_url":"https://github.com/oasp","followers_url":"https://api.github.com/users/oasp/followers","following_url":"https://api.github.com/users/oasp/following{/other_user}","gists_url":"https://api.github.com/users/oasp/gists{/gist_id}","starred_url":"https://api.github.com/users/oasp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oasp/subscriptions","organizations_url":"https://api.github.com/users/oasp/orgs","repos_url":"https://api.github.com/users/oasp/repos","events_url":"https://api.github.com/users/oasp/events{/privacy}","received_events_url":"https://api.github.com/users/oasp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/oasp/oasp4j","description":"The Open Application Standard Platform for Java","fork":false,"url":"https://api.github.com/repos/oasp/oasp4j","forks_url":"https://api.github.com/repos/oasp/oasp4j/forks","keys_url":"https://api.github.com/repos/oasp/oasp4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oasp/oasp4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oasp/oasp4j/teams","hooks_url":"https://api.github.com/repos/oasp/oasp4j/hooks","issue_events_url":"https://api.github.com/repos/oasp/oasp4j/issues/events{/number}","events_url":"https://api.github.com/repos/oasp/oasp4j/events","assignees_url":"https://api.github.com/repos/oasp/oasp4j/assignees{/user}","branches_url":"https://api.github.com/repos/oasp/oasp4j/branches{/branch}","tags_url":"https://api.github.com/repos/oasp/oasp4j/tags","blobs_url":"https://api.github.com/repos/oasp/oasp4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oasp/oasp4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oasp/oasp4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/oasp/oasp4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oasp/oasp4j/statuses/{sha}","languages_url":"https://api.github.com/repos/oasp/oasp4j/languages","stargazers_url":"https://api.github.com/repos/oasp/oasp4j/stargazers","contributors_url":"https://api.github.com/repos/oasp/oasp4j/contributors","subscribers_url":"https://api.github.com/repos/oasp/oasp4j/subscribers","subscription_url":"https://api.github.com/repos/oasp/oasp4j/subscription","commits_url":"https://api.github.com/repos/oasp/oasp4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/oasp/oasp4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/oasp/oasp4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/oasp/oasp4j/issues/comments{/number}","contents_url":"https://api.github.com/repos/oasp/oasp4j/contents/{+path}","compare_url":"https://api.github.com/repos/oasp/oasp4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oasp/oasp4j/merges","archive_url":"https://api.github.com/repos/oasp/oasp4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oasp/oasp4j/downloads","issues_url":"https://api.github.com/repos/oasp/oasp4j/issues{/number}","pulls_url":"https://api.github.com/repos/oasp/oasp4j/pulls{/number}","milestones_url":"https://api.github.com/repos/oasp/oasp4j/milestones{/number}","notifications_url":"https://api.github.com/repos/oasp/oasp4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oasp/oasp4j/labels{/name}","releases_url":"https://api.github.com/repos/oasp/oasp4j/releases{/id}","deployments_url":"https://api.github.com/repos/oasp/oasp4j/deployments","created_at":"2014-06-05T08:20:28Z","updated_at":"2016-09-15T10:16:25Z","pushed_at":"2016-09-30T18:43:45Z","git_url":"git://github.com/oasp/oasp4j.git","ssh_url":"git@github.com:oasp/oasp4j.git","clone_url":"https://github.com/oasp/oasp4j.git","svn_url":"https://github.com/oasp/oasp4j","homepage":null,"size":4144,"stargazers_count":35,"watchers_count":35,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":257,"mirror_url":null,"open_issues_count":101,"forks":257,"open_issues":101,"watchers":35,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/oasp/oasp4j/pulls/463"},"html":{"href":"https://github.com/oasp/oasp4j/pull/463"},"issue":{"href":"https://api.github.com/repos/oasp/oasp4j/issues/463"},"comments":{"href":"https://api.github.com/repos/oasp/oasp4j/issues/463/comments"},"review_comments":{"href":"https://api.github.com/repos/oasp/oasp4j/pulls/463/comments"},"review_comment":{"href":"https://api.github.com/repos/oasp/oasp4j/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/oasp/oasp4j/pulls/463/commits"},"statuses":{"href":"https://api.github.com/repos/oasp/oasp4j/statuses/b0af5f5e36e3a83225548774eed2fd1795f8adc1"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":2,"review_comments":11,"commits":6,"additions":152,"deletions":194,"changed_files":6}}
{"actor":{"display_login":"jomora"}}