{"action":"created","comment":{"url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/comments/92123528","pull_request_review_id":12631611,"id":92123528,"diff_hunk":"@@ -33,6 +33,9 @@ class ApplicationController < ActionController::Base\n     Crowbar::Installer.successful? || \\\n     Rails.env.test?\n   }\n+  before_filter :upgrade, if: proc {\n+    File.exist?(\"/var/lib/crowbar/upgrade/progress.yml\")","path":"crowbar_framework/app/controllers/application_controller.rb","position":5,"original_position":5,"commit_id":"bdbff20235d72fec1f51f97f2a649146078e69e5","original_commit_id":"6dc45ca695549fd04073f18999ce08dfc0ccf821","user":{"login":"skazi0","id":2458112,"avatar_url":"https://avatars.githubusercontent.com/u/2458112?v=3","gravatar_id":"","url":"https://api.github.com/users/skazi0","html_url":"https://github.com/skazi0","followers_url":"https://api.github.com/users/skazi0/followers","following_url":"https://api.github.com/users/skazi0/following{/other_user}","gists_url":"https://api.github.com/users/skazi0/gists{/gist_id}","starred_url":"https://api.github.com/users/skazi0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skazi0/subscriptions","organizations_url":"https://api.github.com/users/skazi0/orgs","repos_url":"https://api.github.com/users/skazi0/repos","events_url":"https://api.github.com/users/skazi0/events{/privacy}","received_events_url":"https://api.github.com/users/skazi0/received_events","type":"User","site_admin":false},"body":"I think adding separate `running` file is the best of options so far. I don't like removing the status file after upgrade is `finished` as this would prevent us from even noticing this. As soon as the `current_step` would be set to `finished` the status API would stop responding.\r\nRemoving the `running` file should be pretty simple as it can be bound to step transition in status library. Removing the whole state of status file library is IMO more fragile.","created_at":"2016-12-13T09:06:55Z","updated_at":"2016-12-13T09:06:55Z","html_url":"https://github.com/crowbar/crowbar-core/pull/861#discussion_r92123528","pull_request_url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/861","_links":{"self":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/comments/92123528"},"html":{"href":"https://github.com/crowbar/crowbar-core/pull/861#discussion_r92123528"},"pull_request":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/861"}}},"pull_request":{"url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/861","id":96733317,"html_url":"https://github.com/crowbar/crowbar-core/pull/861","diff_url":"https://github.com/crowbar/crowbar-core/pull/861.diff","patch_url":"https://github.com/crowbar/crowbar-core/pull/861.patch","issue_url":"https://api.github.com/repos/crowbar/crowbar-core/issues/861","number":861,"state":"open","locked":false,"title":"upgrade: only allow requests to the upgrade api during the upgrade","user":{"login":"MaximilianMeister","id":5364817,"avatar_url":"https://avatars.githubusercontent.com/u/5364817?v=3","gravatar_id":"","url":"https://api.github.com/users/MaximilianMeister","html_url":"https://github.com/MaximilianMeister","followers_url":"https://api.github.com/users/MaximilianMeister/followers","following_url":"https://api.github.com/users/MaximilianMeister/following{/other_user}","gists_url":"https://api.github.com/users/MaximilianMeister/gists{/gist_id}","starred_url":"https://api.github.com/users/MaximilianMeister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaximilianMeister/subscriptions","organizations_url":"https://api.github.com/users/MaximilianMeister/orgs","repos_url":"https://api.github.com/users/MaximilianMeister/repos","events_url":"https://api.github.com/users/MaximilianMeister/events{/privacy}","received_events_url":"https://api.github.com/users/MaximilianMeister/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-12-06T14:26:44Z","updated_at":"2016-12-13T09:06:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f63021c8f7b02f2a00b66c1f8b1bb9a5ff8823dc","assignee":{"login":"jsuchome","id":910000,"avatar_url":"https://avatars.githubusercontent.com/u/910000?v=3","gravatar_id":"","url":"https://api.github.com/users/jsuchome","html_url":"https://github.com/jsuchome","followers_url":"https://api.github.com/users/jsuchome/followers","following_url":"https://api.github.com/users/jsuchome/following{/other_user}","gists_url":"https://api.github.com/users/jsuchome/gists{/gist_id}","starred_url":"https://api.github.com/users/jsuchome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsuchome/subscriptions","organizations_url":"https://api.github.com/users/jsuchome/orgs","repos_url":"https://api.github.com/users/jsuchome/repos","events_url":"https://api.github.com/users/jsuchome/events{/privacy}","received_events_url":"https://api.github.com/users/jsuchome/received_events","type":"User","site_admin":false},"assignees":[{"login":"jsuchome","id":910000,"avatar_url":"https://avatars.githubusercontent.com/u/910000?v=3","gravatar_id":"","url":"https://api.github.com/users/jsuchome","html_url":"https://github.com/jsuchome","followers_url":"https://api.github.com/users/jsuchome/followers","following_url":"https://api.github.com/users/jsuchome/following{/other_user}","gists_url":"https://api.github.com/users/jsuchome/gists{/gist_id}","starred_url":"https://api.github.com/users/jsuchome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsuchome/subscriptions","organizations_url":"https://api.github.com/users/jsuchome/orgs","repos_url":"https://api.github.com/users/jsuchome/repos","events_url":"https://api.github.com/users/jsuchome/events{/privacy}","received_events_url":"https://api.github.com/users/jsuchome/received_events","type":"User","site_admin":false},{"login":"vuntz","id":1758783,"avatar_url":"https://avatars.githubusercontent.com/u/1758783?v=3","gravatar_id":"","url":"https://api.github.com/users/vuntz","html_url":"https://github.com/vuntz","followers_url":"https://api.github.com/users/vuntz/followers","following_url":"https://api.github.com/users/vuntz/following{/other_user}","gists_url":"https://api.github.com/users/vuntz/gists{/gist_id}","starred_url":"https://api.github.com/users/vuntz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vuntz/subscriptions","organizations_url":"https://api.github.com/users/vuntz/orgs","repos_url":"https://api.github.com/users/vuntz/repos","events_url":"https://api.github.com/users/vuntz/events{/privacy}","received_events_url":"https://api.github.com/users/vuntz/received_events","type":"User","site_admin":false},{"login":"rsalevsky","id":4128547,"avatar_url":"https://avatars.githubusercontent.com/u/4128547?v=3","gravatar_id":"","url":"https://api.github.com/users/rsalevsky","html_url":"https://github.com/rsalevsky","followers_url":"https://api.github.com/users/rsalevsky/followers","following_url":"https://api.github.com/users/rsalevsky/following{/other_user}","gists_url":"https://api.github.com/users/rsalevsky/gists{/gist_id}","starred_url":"https://api.github.com/users/rsalevsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsalevsky/subscriptions","organizations_url":"https://api.github.com/users/rsalevsky/orgs","repos_url":"https://api.github.com/users/rsalevsky/repos","events_url":"https://api.github.com/users/rsalevsky/events{/privacy}","received_events_url":"https://api.github.com/users/rsalevsky/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/861/commits","review_comments_url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/861/comments","review_comment_url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/crowbar/crowbar-core/issues/861/comments","statuses_url":"https://api.github.com/repos/crowbar/crowbar-core/statuses/bdbff20235d72fec1f51f97f2a649146078e69e5","head":{"label":"MaximilianMeister:api-restriction-upgrade","ref":"api-restriction-upgrade","sha":"bdbff20235d72fec1f51f97f2a649146078e69e5","user":{"login":"MaximilianMeister","id":5364817,"avatar_url":"https://avatars.githubusercontent.com/u/5364817?v=3","gravatar_id":"","url":"https://api.github.com/users/MaximilianMeister","html_url":"https://github.com/MaximilianMeister","followers_url":"https://api.github.com/users/MaximilianMeister/followers","following_url":"https://api.github.com/users/MaximilianMeister/following{/other_user}","gists_url":"https://api.github.com/users/MaximilianMeister/gists{/gist_id}","starred_url":"https://api.github.com/users/MaximilianMeister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaximilianMeister/subscriptions","organizations_url":"https://api.github.com/users/MaximilianMeister/orgs","repos_url":"https://api.github.com/users/MaximilianMeister/repos","events_url":"https://api.github.com/users/MaximilianMeister/events{/privacy}","received_events_url":"https://api.github.com/users/MaximilianMeister/received_events","type":"User","site_admin":false},"repo":{"id":40901479,"name":"crowbar-core","full_name":"MaximilianMeister/crowbar-core","owner":{"login":"MaximilianMeister","id":5364817,"avatar_url":"https://avatars.githubusercontent.com/u/5364817?v=3","gravatar_id":"","url":"https://api.github.com/users/MaximilianMeister","html_url":"https://github.com/MaximilianMeister","followers_url":"https://api.github.com/users/MaximilianMeister/followers","following_url":"https://api.github.com/users/MaximilianMeister/following{/other_user}","gists_url":"https://api.github.com/users/MaximilianMeister/gists{/gist_id}","starred_url":"https://api.github.com/users/MaximilianMeister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaximilianMeister/subscriptions","organizations_url":"https://api.github.com/users/MaximilianMeister/orgs","repos_url":"https://api.github.com/users/MaximilianMeister/repos","events_url":"https://api.github.com/users/MaximilianMeister/events{/privacy}","received_events_url":"https://api.github.com/users/MaximilianMeister/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MaximilianMeister/crowbar-core","description":"Core deployment for Crowbar","fork":true,"url":"https://api.github.com/repos/MaximilianMeister/crowbar-core","forks_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/forks","keys_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/teams","hooks_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/hooks","issue_events_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/issues/events{/number}","events_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/events","assignees_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/assignees{/user}","branches_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/branches{/branch}","tags_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/tags","blobs_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/statuses/{sha}","languages_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/languages","stargazers_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/stargazers","contributors_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/contributors","subscribers_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/subscribers","subscription_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/subscription","commits_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/contents/{+path}","compare_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/merges","archive_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/downloads","issues_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/issues{/number}","pulls_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/pulls{/number}","milestones_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/milestones{/number}","notifications_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/labels{/name}","releases_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/releases{/id}","deployments_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/deployments","created_at":"2015-08-17T14:29:21Z","updated_at":"2015-08-17T14:29:23Z","pushed_at":"2016-12-12T15:43:26Z","git_url":"git://github.com/MaximilianMeister/crowbar-core.git","ssh_url":"git@github.com:MaximilianMeister/crowbar-core.git","clone_url":"https://github.com/MaximilianMeister/crowbar-core.git","svn_url":"https://github.com/MaximilianMeister/crowbar-core","homepage":null,"size":107546,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"crowbar:master","ref":"master","sha":"d0dbea6e9f0abc88bd00ee8b5e403f5973bfdb36","user":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars.githubusercontent.com/u/2910205?v=3","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"repo":{"id":39003227,"name":"crowbar-core","full_name":"crowbar/crowbar-core","owner":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars.githubusercontent.com/u/2910205?v=3","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crowbar/crowbar-core","description":"Core deployment for Crowbar","fork":false,"url":"https://api.github.com/repos/crowbar/crowbar-core","forks_url":"https://api.github.com/repos/crowbar/crowbar-core/forks","keys_url":"https://api.github.com/repos/crowbar/crowbar-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crowbar/crowbar-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crowbar/crowbar-core/teams","hooks_url":"https://api.github.com/repos/crowbar/crowbar-core/hooks","issue_events_url":"https://api.github.com/repos/crowbar/crowbar-core/issues/events{/number}","events_url":"https://api.github.com/repos/crowbar/crowbar-core/events","assignees_url":"https://api.github.com/repos/crowbar/crowbar-core/assignees{/user}","branches_url":"https://api.github.com/repos/crowbar/crowbar-core/branches{/branch}","tags_url":"https://api.github.com/repos/crowbar/crowbar-core/tags","blobs_url":"https://api.github.com/repos/crowbar/crowbar-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crowbar/crowbar-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crowbar/crowbar-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/crowbar/crowbar-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crowbar/crowbar-core/statuses/{sha}","languages_url":"https://api.github.com/repos/crowbar/crowbar-core/languages","stargazers_url":"https://api.github.com/repos/crowbar/crowbar-core/stargazers","contributors_url":"https://api.github.com/repos/crowbar/crowbar-core/contributors","subscribers_url":"https://api.github.com/repos/crowbar/crowbar-core/subscribers","subscription_url":"https://api.github.com/repos/crowbar/crowbar-core/subscription","commits_url":"https://api.github.com/repos/crowbar/crowbar-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/crowbar/crowbar-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/crowbar/crowbar-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/crowbar/crowbar-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/crowbar/crowbar-core/contents/{+path}","compare_url":"https://api.github.com/repos/crowbar/crowbar-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crowbar/crowbar-core/merges","archive_url":"https://api.github.com/repos/crowbar/crowbar-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crowbar/crowbar-core/downloads","issues_url":"https://api.github.com/repos/crowbar/crowbar-core/issues{/number}","pulls_url":"https://api.github.com/repos/crowbar/crowbar-core/pulls{/number}","milestones_url":"https://api.github.com/repos/crowbar/crowbar-core/milestones{/number}","notifications_url":"https://api.github.com/repos/crowbar/crowbar-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crowbar/crowbar-core/labels{/name}","releases_url":"https://api.github.com/repos/crowbar/crowbar-core/releases{/id}","deployments_url":"https://api.github.com/repos/crowbar/crowbar-core/deployments","created_at":"2015-07-13T09:31:28Z","updated_at":"2016-11-11T19:16:44Z","pushed_at":"2016-12-12T19:09:22Z","git_url":"git://github.com/crowbar/crowbar-core.git","ssh_url":"git@github.com:crowbar/crowbar-core.git","clone_url":"https://github.com/crowbar/crowbar-core.git","svn_url":"https://github.com/crowbar/crowbar-core","homepage":null,"size":122050,"stargazers_count":9,"watchers_count":9,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":39,"mirror_url":null,"open_issues_count":46,"forks":39,"open_issues":46,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/861"},"html":{"href":"https://github.com/crowbar/crowbar-core/pull/861"},"issue":{"href":"https://api.github.com/repos/crowbar/crowbar-core/issues/861"},"comments":{"href":"https://api.github.com/repos/crowbar/crowbar-core/issues/861/comments"},"review_comments":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/861/comments"},"review_comment":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/861/commits"},"statuses":{"href":"https://api.github.com/repos/crowbar/crowbar-core/statuses/bdbff20235d72fec1f51f97f2a649146078e69e5"}}}}
{"actor":{"display_login":"skazi0"}}