{"action":"created","issue":{"url":"https://api.github.com/repos/coreos/etcd/issues/6289","repository_url":"https://api.github.com/repos/coreos/etcd","labels_url":"https://api.github.com/repos/coreos/etcd/issues/6289/labels{/name}","comments_url":"https://api.github.com/repos/coreos/etcd/issues/6289/comments","events_url":"https://api.github.com/repos/coreos/etcd/issues/6289/events","html_url":"https://github.com/coreos/etcd/pull/6289","id":173703038,"number":6289,"title":"embed: Move the ReadyNotify() call to a more sane place","user":{"login":"purpleidea","id":135091,"avatar_url":"https://avatars.githubusercontent.com/u/135091?v=3","gravatar_id":"","url":"https://api.github.com/users/purpleidea","html_url":"https://github.com/purpleidea","followers_url":"https://api.github.com/users/purpleidea/followers","following_url":"https://api.github.com/users/purpleidea/following{/other_user}","gists_url":"https://api.github.com/users/purpleidea/gists{/gist_id}","starred_url":"https://api.github.com/users/purpleidea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/purpleidea/subscriptions","organizations_url":"https://api.github.com/users/purpleidea/orgs","repos_url":"https://api.github.com/users/purpleidea/repos","events_url":"https://api.github.com/users/purpleidea/events{/privacy}","received_events_url":"https://api.github.com/users/purpleidea/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-08-29T06:11:10Z","updated_at":"2016-08-29T16:04:13Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/coreos/etcd/pulls/6289","html_url":"https://github.com/coreos/etcd/pull/6289","diff_url":"https://github.com/coreos/etcd/pull/6289.diff","patch_url":"https://github.com/coreos/etcd/pull/6289.patch"},"body":"When using the embed functionality, you can't call the Server.Stop()\nfunction until StartEtcd returns, which can block until there is a call\nto Server.Stop() in error situations. Since we have a catch-22, the\nReadyNotify() can be called manually by the user if they wish to wait\nfor the server startup, or in parallel with a timeout if they wish to\ncancel it after some time.\n\nChzz pointed out that this is also more consistent with the\netcdserver.Start() behaviour too.\n\nPurpleidea pointed out that this is actually more correct too, because\nwe can now register the stop interrupt handler before we block on\nstartup."},"comment":{"url":"https://api.github.com/repos/coreos/etcd/issues/comments/243169520","html_url":"https://github.com/coreos/etcd/pull/6289#issuecomment-243169520","issue_url":"https://api.github.com/repos/coreos/etcd/issues/6289","id":243169520,"user":{"login":"heyitsanthony","id":16294350,"avatar_url":"https://avatars.githubusercontent.com/u/16294350?v=3","gravatar_id":"","url":"https://api.github.com/users/heyitsanthony","html_url":"https://github.com/heyitsanthony","followers_url":"https://api.github.com/users/heyitsanthony/followers","following_url":"https://api.github.com/users/heyitsanthony/following{/other_user}","gists_url":"https://api.github.com/users/heyitsanthony/gists{/gist_id}","starred_url":"https://api.github.com/users/heyitsanthony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heyitsanthony/subscriptions","organizations_url":"https://api.github.com/users/heyitsanthony/orgs","repos_url":"https://api.github.com/users/heyitsanthony/repos","events_url":"https://api.github.com/users/heyitsanthony/events{/privacy}","received_events_url":"https://api.github.com/users/heyitsanthony/received_events","type":"User","site_admin":false},"created_at":"2016-08-29T16:04:13Z","updated_at":"2016-08-29T16:04:13Z","body":"@purpleidea please fix up based on the comments and this should be ready to merge. Thanks!"}}
{"actor":{"display_login":"heyitsanthony"}}