{"action":"created","comment":{"url":"https://api.github.com/repos/TerriaJS/terriajs/pulls/comments/82918248","pull_request_review_id":3791910,"id":82918248,"diff_hunk":"@@ -515,14 +644,40 @@ WebMapServiceCatalogItem.prototype.updateFromCapabilities = function(capabilitie\n         myLayer = myLayer[0];\n         if (myLayer && myLayer.Style && myLayer.Style.length > 0) {\n           for (var j = 0; j < myLayer.Style.length; ++j) {\n-            if (!defined(this.isNcWMS) && myLayer.Style[j].Name && myLayer.Style[j].Name.match(/boxfill\\/rainbow/i)) {\n+            if (!defined(this.isNcWMS) && myLayer.Style[j].Name &&\n+                (myLayer.Style[j].Name.match(/boxfill\\/rainbow/i) ||\n+                 myLayer.Style[j].Name.match(/default-scalar\\/default/i) ||\n+                 myLayer.Style[j].Name.match(/default-vector\\/default/i))) {\n               this.isNcWMS = true;\n             }\n           }\n         }\n       }\n     }\n \n+    if (!defined(this.supportsColorScaleRange)) {\n+        this.supportsColorScaleRange = this.isNcWMS;\n+\n+        if (!this.supportsColorScaleRange) {\n+            var hasExtendedRequests = capabilities.Capability &&\n+                capabilities.Capability.ExtendedCapabilities &&\n+                capabilities.Capability.ExtendedCapabilities &&","path":"lib/Models/WebMapServiceCatalogItem.js","position":219,"original_position":219,"commit_id":"183856e4ddec9b9c30914ebcb7e09880db8dfda6","original_commit_id":"183856e4ddec9b9c30914ebcb7e09880db8dfda6","user":{"login":"RacingTadpole","id":1757858,"avatar_url":"https://avatars.githubusercontent.com/u/1757858?v=3","gravatar_id":"","url":"https://api.github.com/users/RacingTadpole","html_url":"https://github.com/RacingTadpole","followers_url":"https://api.github.com/users/RacingTadpole/followers","following_url":"https://api.github.com/users/RacingTadpole/following{/other_user}","gists_url":"https://api.github.com/users/RacingTadpole/gists{/gist_id}","starred_url":"https://api.github.com/users/RacingTadpole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RacingTadpole/subscriptions","organizations_url":"https://api.github.com/users/RacingTadpole/orgs","repos_url":"https://api.github.com/users/RacingTadpole/repos","events_url":"https://api.github.com/users/RacingTadpole/events{/privacy}","received_events_url":"https://api.github.com/users/RacingTadpole/received_events","type":"User","site_admin":false},"body":"I admire your desire to make this super thorough! But probably don't need the extra check for `capabilities.Capability.ExtendedCapabilities` :-)","created_at":"2016-10-12T00:42:07Z","updated_at":"2016-10-12T00:42:07Z","html_url":"https://github.com/TerriaJS/terriajs/pull/2158#discussion_r82918248","pull_request_url":"https://api.github.com/repos/TerriaJS/terriajs/pulls/2158","_links":{"self":{"href":"https://api.github.com/repos/TerriaJS/terriajs/pulls/comments/82918248"},"html":{"href":"https://github.com/TerriaJS/terriajs/pull/2158#discussion_r82918248"},"pull_request":{"href":"https://api.github.com/repos/TerriaJS/terriajs/pulls/2158"}}},"pull_request":{"url":"https://api.github.com/repos/TerriaJS/terriajs/pulls/2158","id":88609447,"html_url":"https://github.com/TerriaJS/terriajs/pull/2158","diff_url":"https://github.com/TerriaJS/terriajs/pull/2158.diff","patch_url":"https://github.com/TerriaJS/terriajs/pull/2158.patch","issue_url":"https://api.github.com/repos/TerriaJS/terriajs/issues/2158","number":2158,"state":"open","locked":false,"title":"Add the ability in the UI to select WMS dimensions like Elevation","user":{"login":"kring","id":924374,"avatar_url":"https://avatars.githubusercontent.com/u/924374?v=3","gravatar_id":"","url":"https://api.github.com/users/kring","html_url":"https://github.com/kring","followers_url":"https://api.github.com/users/kring/followers","following_url":"https://api.github.com/users/kring/following{/other_user}","gists_url":"https://api.github.com/users/kring/gists{/gist_id}","starred_url":"https://api.github.com/users/kring/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kring/subscriptions","organizations_url":"https://api.github.com/users/kring/orgs","repos_url":"https://api.github.com/users/kring/repos","events_url":"https://api.github.com/users/kring/events{/privacy}","received_events_url":"https://api.github.com/users/kring/received_events","type":"User","site_admin":false},"body":"Fixes #1512 \r\nFixes #1778\r\nFixes #1976\r\n\r\n![image](https://cloud.githubusercontent.com/assets/924374/19226984/c72c14d2-8efe-11e6-8705-423d0368140b.png)\r\n\r\n![image](https://cloud.githubusercontent.com/assets/924374/19226998/fdb1c95c-8efe-11e6-8ee7-0f8fa0eb627c.png)\r\n","created_at":"2016-10-10T04:34:25Z","updated_at":"2016-10-12T00:42:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"75ebadb8a338079393cf093015711d6377e110d2","assignee":{"login":"RacingTadpole","id":1757858,"avatar_url":"https://avatars.githubusercontent.com/u/1757858?v=3","gravatar_id":"","url":"https://api.github.com/users/RacingTadpole","html_url":"https://github.com/RacingTadpole","followers_url":"https://api.github.com/users/RacingTadpole/followers","following_url":"https://api.github.com/users/RacingTadpole/following{/other_user}","gists_url":"https://api.github.com/users/RacingTadpole/gists{/gist_id}","starred_url":"https://api.github.com/users/RacingTadpole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RacingTadpole/subscriptions","organizations_url":"https://api.github.com/users/RacingTadpole/orgs","repos_url":"https://api.github.com/users/RacingTadpole/repos","events_url":"https://api.github.com/users/RacingTadpole/events{/privacy}","received_events_url":"https://api.github.com/users/RacingTadpole/received_events","type":"User","site_admin":false},"assignees":[{"login":"RacingTadpole","id":1757858,"avatar_url":"https://avatars.githubusercontent.com/u/1757858?v=3","gravatar_id":"","url":"https://api.github.com/users/RacingTadpole","html_url":"https://github.com/RacingTadpole","followers_url":"https://api.github.com/users/RacingTadpole/followers","following_url":"https://api.github.com/users/RacingTadpole/following{/other_user}","gists_url":"https://api.github.com/users/RacingTadpole/gists{/gist_id}","starred_url":"https://api.github.com/users/RacingTadpole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RacingTadpole/subscriptions","organizations_url":"https://api.github.com/users/RacingTadpole/orgs","repos_url":"https://api.github.com/users/RacingTadpole/repos","events_url":"https://api.github.com/users/RacingTadpole/events{/privacy}","received_events_url":"https://api.github.com/users/RacingTadpole/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/TerriaJS/terriajs/pulls/2158/commits","review_comments_url":"https://api.github.com/repos/TerriaJS/terriajs/pulls/2158/comments","review_comment_url":"https://api.github.com/repos/TerriaJS/terriajs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TerriaJS/terriajs/issues/2158/comments","statuses_url":"https://api.github.com/repos/TerriaJS/terriajs/statuses/183856e4ddec9b9c30914ebcb7e09880db8dfda6","head":{"label":"TerriaJS:selectWmsElevation","ref":"selectWmsElevation","sha":"183856e4ddec9b9c30914ebcb7e09880db8dfda6","user":{"login":"TerriaJS","id":12078432,"avatar_url":"https://avatars.githubusercontent.com/u/12078432?v=3","gravatar_id":"","url":"https://api.github.com/users/TerriaJS","html_url":"https://github.com/TerriaJS","followers_url":"https://api.github.com/users/TerriaJS/followers","following_url":"https://api.github.com/users/TerriaJS/following{/other_user}","gists_url":"https://api.github.com/users/TerriaJS/gists{/gist_id}","starred_url":"https://api.github.com/users/TerriaJS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TerriaJS/subscriptions","organizations_url":"https://api.github.com/users/TerriaJS/orgs","repos_url":"https://api.github.com/users/TerriaJS/repos","events_url":"https://api.github.com/users/TerriaJS/events{/privacy}","received_events_url":"https://api.github.com/users/TerriaJS/received_events","type":"Organization","site_admin":false},"repo":{"id":17163720,"name":"terriajs","full_name":"TerriaJS/terriajs","owner":{"login":"TerriaJS","id":12078432,"avatar_url":"https://avatars.githubusercontent.com/u/12078432?v=3","gravatar_id":"","url":"https://api.github.com/users/TerriaJS","html_url":"https://github.com/TerriaJS","followers_url":"https://api.github.com/users/TerriaJS/followers","following_url":"https://api.github.com/users/TerriaJS/following{/other_user}","gists_url":"https://api.github.com/users/TerriaJS/gists{/gist_id}","starred_url":"https://api.github.com/users/TerriaJS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TerriaJS/subscriptions","organizations_url":"https://api.github.com/users/TerriaJS/orgs","repos_url":"https://api.github.com/users/TerriaJS/repos","events_url":"https://api.github.com/users/TerriaJS/events{/privacy}","received_events_url":"https://api.github.com/users/TerriaJS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TerriaJS/terriajs","description":"A library for building rich, web-based geospatial data explorers.","fork":false,"url":"https://api.github.com/repos/TerriaJS/terriajs","forks_url":"https://api.github.com/repos/TerriaJS/terriajs/forks","keys_url":"https://api.github.com/repos/TerriaJS/terriajs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TerriaJS/terriajs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TerriaJS/terriajs/teams","hooks_url":"https://api.github.com/repos/TerriaJS/terriajs/hooks","issue_events_url":"https://api.github.com/repos/TerriaJS/terriajs/issues/events{/number}","events_url":"https://api.github.com/repos/TerriaJS/terriajs/events","assignees_url":"https://api.github.com/repos/TerriaJS/terriajs/assignees{/user}","branches_url":"https://api.github.com/repos/TerriaJS/terriajs/branches{/branch}","tags_url":"https://api.github.com/repos/TerriaJS/terriajs/tags","blobs_url":"https://api.github.com/repos/TerriaJS/terriajs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TerriaJS/terriajs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TerriaJS/terriajs/git/refs{/sha}","trees_url":"https://api.github.com/repos/TerriaJS/terriajs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TerriaJS/terriajs/statuses/{sha}","languages_url":"https://api.github.com/repos/TerriaJS/terriajs/languages","stargazers_url":"https://api.github.com/repos/TerriaJS/terriajs/stargazers","contributors_url":"https://api.github.com/repos/TerriaJS/terriajs/contributors","subscribers_url":"https://api.github.com/repos/TerriaJS/terriajs/subscribers","subscription_url":"https://api.github.com/repos/TerriaJS/terriajs/subscription","commits_url":"https://api.github.com/repos/TerriaJS/terriajs/commits{/sha}","git_commits_url":"https://api.github.com/repos/TerriaJS/terriajs/git/commits{/sha}","comments_url":"https://api.github.com/repos/TerriaJS/terriajs/comments{/number}","issue_comment_url":"https://api.github.com/repos/TerriaJS/terriajs/issues/comments{/number}","contents_url":"https://api.github.com/repos/TerriaJS/terriajs/contents/{+path}","compare_url":"https://api.github.com/repos/TerriaJS/terriajs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TerriaJS/terriajs/merges","archive_url":"https://api.github.com/repos/TerriaJS/terriajs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TerriaJS/terriajs/downloads","issues_url":"https://api.github.com/repos/TerriaJS/terriajs/issues{/number}","pulls_url":"https://api.github.com/repos/TerriaJS/terriajs/pulls{/number}","milestones_url":"https://api.github.com/repos/TerriaJS/terriajs/milestones{/number}","notifications_url":"https://api.github.com/repos/TerriaJS/terriajs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TerriaJS/terriajs/labels{/name}","releases_url":"https://api.github.com/repos/TerriaJS/terriajs/releases{/id}","deployments_url":"https://api.github.com/repos/TerriaJS/terriajs/deployments","created_at":"2014-02-25T06:30:13Z","updated_at":"2016-10-08T15:49:18Z","pushed_at":"2016-10-12T00:39:46Z","git_url":"git://github.com/TerriaJS/terriajs.git","ssh_url":"git@github.com:TerriaJS/terriajs.git","clone_url":"https://github.com/TerriaJS/terriajs.git","svn_url":"https://github.com/TerriaJS/terriajs","homepage":"http://terria.io","size":59654,"stargazers_count":139,"watchers_count":139,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":73,"mirror_url":null,"open_issues_count":258,"forks":73,"open_issues":258,"watchers":139,"default_branch":"master"}},"base":{"label":"TerriaJS:master","ref":"master","sha":"c58bfa3b742a85a331b53f4ee4cb42049e973823","user":{"login":"TerriaJS","id":12078432,"avatar_url":"https://avatars.githubusercontent.com/u/12078432?v=3","gravatar_id":"","url":"https://api.github.com/users/TerriaJS","html_url":"https://github.com/TerriaJS","followers_url":"https://api.github.com/users/TerriaJS/followers","following_url":"https://api.github.com/users/TerriaJS/following{/other_user}","gists_url":"https://api.github.com/users/TerriaJS/gists{/gist_id}","starred_url":"https://api.github.com/users/TerriaJS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TerriaJS/subscriptions","organizations_url":"https://api.github.com/users/TerriaJS/orgs","repos_url":"https://api.github.com/users/TerriaJS/repos","events_url":"https://api.github.com/users/TerriaJS/events{/privacy}","received_events_url":"https://api.github.com/users/TerriaJS/received_events","type":"Organization","site_admin":false},"repo":{"id":17163720,"name":"terriajs","full_name":"TerriaJS/terriajs","owner":{"login":"TerriaJS","id":12078432,"avatar_url":"https://avatars.githubusercontent.com/u/12078432?v=3","gravatar_id":"","url":"https://api.github.com/users/TerriaJS","html_url":"https://github.com/TerriaJS","followers_url":"https://api.github.com/users/TerriaJS/followers","following_url":"https://api.github.com/users/TerriaJS/following{/other_user}","gists_url":"https://api.github.com/users/TerriaJS/gists{/gist_id}","starred_url":"https://api.github.com/users/TerriaJS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TerriaJS/subscriptions","organizations_url":"https://api.github.com/users/TerriaJS/orgs","repos_url":"https://api.github.com/users/TerriaJS/repos","events_url":"https://api.github.com/users/TerriaJS/events{/privacy}","received_events_url":"https://api.github.com/users/TerriaJS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TerriaJS/terriajs","description":"A library for building rich, web-based geospatial data explorers.","fork":false,"url":"https://api.github.com/repos/TerriaJS/terriajs","forks_url":"https://api.github.com/repos/TerriaJS/terriajs/forks","keys_url":"https://api.github.com/repos/TerriaJS/terriajs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TerriaJS/terriajs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TerriaJS/terriajs/teams","hooks_url":"https://api.github.com/repos/TerriaJS/terriajs/hooks","issue_events_url":"https://api.github.com/repos/TerriaJS/terriajs/issues/events{/number}","events_url":"https://api.github.com/repos/TerriaJS/terriajs/events","assignees_url":"https://api.github.com/repos/TerriaJS/terriajs/assignees{/user}","branches_url":"https://api.github.com/repos/TerriaJS/terriajs/branches{/branch}","tags_url":"https://api.github.com/repos/TerriaJS/terriajs/tags","blobs_url":"https://api.github.com/repos/TerriaJS/terriajs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TerriaJS/terriajs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TerriaJS/terriajs/git/refs{/sha}","trees_url":"https://api.github.com/repos/TerriaJS/terriajs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TerriaJS/terriajs/statuses/{sha}","languages_url":"https://api.github.com/repos/TerriaJS/terriajs/languages","stargazers_url":"https://api.github.com/repos/TerriaJS/terriajs/stargazers","contributors_url":"https://api.github.com/repos/TerriaJS/terriajs/contributors","subscribers_url":"https://api.github.com/repos/TerriaJS/terriajs/subscribers","subscription_url":"https://api.github.com/repos/TerriaJS/terriajs/subscription","commits_url":"https://api.github.com/repos/TerriaJS/terriajs/commits{/sha}","git_commits_url":"https://api.github.com/repos/TerriaJS/terriajs/git/commits{/sha}","comments_url":"https://api.github.com/repos/TerriaJS/terriajs/comments{/number}","issue_comment_url":"https://api.github.com/repos/TerriaJS/terriajs/issues/comments{/number}","contents_url":"https://api.github.com/repos/TerriaJS/terriajs/contents/{+path}","compare_url":"https://api.github.com/repos/TerriaJS/terriajs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TerriaJS/terriajs/merges","archive_url":"https://api.github.com/repos/TerriaJS/terriajs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TerriaJS/terriajs/downloads","issues_url":"https://api.github.com/repos/TerriaJS/terriajs/issues{/number}","pulls_url":"https://api.github.com/repos/TerriaJS/terriajs/pulls{/number}","milestones_url":"https://api.github.com/repos/TerriaJS/terriajs/milestones{/number}","notifications_url":"https://api.github.com/repos/TerriaJS/terriajs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TerriaJS/terriajs/labels{/name}","releases_url":"https://api.github.com/repos/TerriaJS/terriajs/releases{/id}","deployments_url":"https://api.github.com/repos/TerriaJS/terriajs/deployments","created_at":"2014-02-25T06:30:13Z","updated_at":"2016-10-08T15:49:18Z","pushed_at":"2016-10-12T00:39:46Z","git_url":"git://github.com/TerriaJS/terriajs.git","ssh_url":"git@github.com:TerriaJS/terriajs.git","clone_url":"https://github.com/TerriaJS/terriajs.git","svn_url":"https://github.com/TerriaJS/terriajs","homepage":"http://terria.io","size":59654,"stargazers_count":139,"watchers_count":139,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":73,"mirror_url":null,"open_issues_count":258,"forks":73,"open_issues":258,"watchers":139,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TerriaJS/terriajs/pulls/2158"},"html":{"href":"https://github.com/TerriaJS/terriajs/pull/2158"},"issue":{"href":"https://api.github.com/repos/TerriaJS/terriajs/issues/2158"},"comments":{"href":"https://api.github.com/repos/TerriaJS/terriajs/issues/2158/comments"},"review_comments":{"href":"https://api.github.com/repos/TerriaJS/terriajs/pulls/2158/comments"},"review_comment":{"href":"https://api.github.com/repos/TerriaJS/terriajs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TerriaJS/terriajs/pulls/2158/commits"},"statuses":{"href":"https://api.github.com/repos/TerriaJS/terriajs/statuses/183856e4ddec9b9c30914ebcb7e09880db8dfda6"}}}}
{"actor":{"display_login":"RacingTadpole"}}