{"action":"created","comment":{"url":"https://api.github.com/repos/docker/swarmkit/pulls/comments/84567044","pull_request_review_id":5340554,"id":84567044,"diff_hunk":"@@ -39,24 +42,26 @@ type statusReporterKey struct {\n }\n \n type worker struct {\n-\tdb        *bolt.DB\n-\texecutor  exec.Executor\n-\tpublisher exec.LogPublisher\n-\tlisteners map[*statusReporterKey]struct{}\n-\tsecrets   *secrets\n+\tdb                *bolt.DB\n+\ttaskevents        *events.Broadcaster","path":"agent/worker.go","position":null,"original_position":27,"commit_id":"d0dcf1bcfe434383d8426c97c92597afe98d4105","original_commit_id":"d0dcf1bcfe434383d8426c97c92597afe98d4105","user":{"login":"aaronlehmann","id":10601430,"avatar_url":"https://avatars.githubusercontent.com/u/10601430?v=3","gravatar_id":"","url":"https://api.github.com/users/aaronlehmann","html_url":"https://github.com/aaronlehmann","followers_url":"https://api.github.com/users/aaronlehmann/followers","following_url":"https://api.github.com/users/aaronlehmann/following{/other_user}","gists_url":"https://api.github.com/users/aaronlehmann/gists{/gist_id}","starred_url":"https://api.github.com/users/aaronlehmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaronlehmann/subscriptions","organizations_url":"https://api.github.com/users/aaronlehmann/orgs","repos_url":"https://api.github.com/users/aaronlehmann/repos","events_url":"https://api.github.com/users/aaronlehmann/events{/privacy}","received_events_url":"https://api.github.com/users/aaronlehmann/received_events","type":"User","site_admin":false},"body":"This needs to be closed once it is no longer being used, otherwise it will leak a goroutine.","created_at":"2016-10-22T01:28:29Z","updated_at":"2016-10-22T01:28:29Z","html_url":"https://github.com/docker/swarmkit/pull/1679#discussion_r84567044","pull_request_url":"https://api.github.com/repos/docker/swarmkit/pulls/1679","_links":{"self":{"href":"https://api.github.com/repos/docker/swarmkit/pulls/comments/84567044"},"html":{"href":"https://github.com/docker/swarmkit/pull/1679#discussion_r84567044"},"pull_request":{"href":"https://api.github.com/repos/docker/swarmkit/pulls/1679"}}},"pull_request":{"url":"https://api.github.com/repos/docker/swarmkit/pulls/1679","id":90464621,"html_url":"https://github.com/docker/swarmkit/pull/1679","diff_url":"https://github.com/docker/swarmkit/pull/1679.diff","patch_url":"https://github.com/docker/swarmkit/pull/1679.patch","issue_url":"https://api.github.com/repos/docker/swarmkit/issues/1679","number":1679,"state":"open","locked":false,"title":"[WIP] Log Management","user":{"login":"aluzzardi","id":179503,"avatar_url":"https://avatars.githubusercontent.com/u/179503?v=3","gravatar_id":"","url":"https://api.github.com/users/aluzzardi","html_url":"https://github.com/aluzzardi","followers_url":"https://api.github.com/users/aluzzardi/followers","following_url":"https://api.github.com/users/aluzzardi/following{/other_user}","gists_url":"https://api.github.com/users/aluzzardi/gists{/gist_id}","starred_url":"https://api.github.com/users/aluzzardi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aluzzardi/subscriptions","organizations_url":"https://api.github.com/users/aluzzardi/orgs","repos_url":"https://api.github.com/users/aluzzardi/repos","events_url":"https://api.github.com/users/aluzzardi/events{/privacy}","received_events_url":"https://api.github.com/users/aluzzardi/received_events","type":"User","site_admin":false},"body":"Depends on #1553 [please review just the last commit]\r\n\r\nThis change adds support for log management in the manager, agent and\r\nCLI.\r\n\r\nThe log broker is currently naive and broadcasts subscriptions to all\r\nagents, which in turn need to perform filtering to figure out if the\r\nsubscription is relevant to them.\r\n\r\nIn the future, the broker should be smarter and dispatch subscriptions\r\nonly to concerned agents.\r\n\r\nThe basic logging functionality works.\r\n\r\nFixes #1332\r\n\r\n/cc @stevvooe @aaronlehmann @diogomonica ","created_at":"2016-10-22T01:06:04Z","updated_at":"2016-10-22T01:28:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"69fb2e71795f693a3fcf01f58adb41ec76cf54cd","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/docker/swarmkit/pulls/1679/commits","review_comments_url":"https://api.github.com/repos/docker/swarmkit/pulls/1679/comments","review_comment_url":"https://api.github.com/repos/docker/swarmkit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/swarmkit/issues/1679/comments","statuses_url":"https://api.github.com/repos/docker/swarmkit/statuses/d0dcf1bcfe434383d8426c97c92597afe98d4105","head":{"label":"aluzzardi:logbroker","ref":"logbroker","sha":"d0dcf1bcfe434383d8426c97c92597afe98d4105","user":{"login":"aluzzardi","id":179503,"avatar_url":"https://avatars.githubusercontent.com/u/179503?v=3","gravatar_id":"","url":"https://api.github.com/users/aluzzardi","html_url":"https://github.com/aluzzardi","followers_url":"https://api.github.com/users/aluzzardi/followers","following_url":"https://api.github.com/users/aluzzardi/following{/other_user}","gists_url":"https://api.github.com/users/aluzzardi/gists{/gist_id}","starred_url":"https://api.github.com/users/aluzzardi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aluzzardi/subscriptions","organizations_url":"https://api.github.com/users/aluzzardi/orgs","repos_url":"https://api.github.com/users/aluzzardi/repos","events_url":"https://api.github.com/users/aluzzardi/events{/privacy}","received_events_url":"https://api.github.com/users/aluzzardi/received_events","type":"User","site_admin":false},"repo":{"id":60661626,"name":"swarmkit","full_name":"aluzzardi/swarmkit","owner":{"login":"aluzzardi","id":179503,"avatar_url":"https://avatars.githubusercontent.com/u/179503?v=3","gravatar_id":"","url":"https://api.github.com/users/aluzzardi","html_url":"https://github.com/aluzzardi","followers_url":"https://api.github.com/users/aluzzardi/followers","following_url":"https://api.github.com/users/aluzzardi/following{/other_user}","gists_url":"https://api.github.com/users/aluzzardi/gists{/gist_id}","starred_url":"https://api.github.com/users/aluzzardi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aluzzardi/subscriptions","organizations_url":"https://api.github.com/users/aluzzardi/orgs","repos_url":"https://api.github.com/users/aluzzardi/repos","events_url":"https://api.github.com/users/aluzzardi/events{/privacy}","received_events_url":"https://api.github.com/users/aluzzardi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aluzzardi/swarmkit","description":"A toolkit for embedding orchestration and cluster management capabilities in your application","fork":true,"url":"https://api.github.com/repos/aluzzardi/swarmkit","forks_url":"https://api.github.com/repos/aluzzardi/swarmkit/forks","keys_url":"https://api.github.com/repos/aluzzardi/swarmkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aluzzardi/swarmkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aluzzardi/swarmkit/teams","hooks_url":"https://api.github.com/repos/aluzzardi/swarmkit/hooks","issue_events_url":"https://api.github.com/repos/aluzzardi/swarmkit/issues/events{/number}","events_url":"https://api.github.com/repos/aluzzardi/swarmkit/events","assignees_url":"https://api.github.com/repos/aluzzardi/swarmkit/assignees{/user}","branches_url":"https://api.github.com/repos/aluzzardi/swarmkit/branches{/branch}","tags_url":"https://api.github.com/repos/aluzzardi/swarmkit/tags","blobs_url":"https://api.github.com/repos/aluzzardi/swarmkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aluzzardi/swarmkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aluzzardi/swarmkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/aluzzardi/swarmkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aluzzardi/swarmkit/statuses/{sha}","languages_url":"https://api.github.com/repos/aluzzardi/swarmkit/languages","stargazers_url":"https://api.github.com/repos/aluzzardi/swarmkit/stargazers","contributors_url":"https://api.github.com/repos/aluzzardi/swarmkit/contributors","subscribers_url":"https://api.github.com/repos/aluzzardi/swarmkit/subscribers","subscription_url":"https://api.github.com/repos/aluzzardi/swarmkit/subscription","commits_url":"https://api.github.com/repos/aluzzardi/swarmkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/aluzzardi/swarmkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/aluzzardi/swarmkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/aluzzardi/swarmkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/aluzzardi/swarmkit/contents/{+path}","compare_url":"https://api.github.com/repos/aluzzardi/swarmkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aluzzardi/swarmkit/merges","archive_url":"https://api.github.com/repos/aluzzardi/swarmkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aluzzardi/swarmkit/downloads","issues_url":"https://api.github.com/repos/aluzzardi/swarmkit/issues{/number}","pulls_url":"https://api.github.com/repos/aluzzardi/swarmkit/pulls{/number}","milestones_url":"https://api.github.com/repos/aluzzardi/swarmkit/milestones{/number}","notifications_url":"https://api.github.com/repos/aluzzardi/swarmkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aluzzardi/swarmkit/labels{/name}","releases_url":"https://api.github.com/repos/aluzzardi/swarmkit/releases{/id}","deployments_url":"https://api.github.com/repos/aluzzardi/swarmkit/deployments","created_at":"2016-06-08T02:19:36Z","updated_at":"2016-06-08T02:19:37Z","pushed_at":"2016-10-22T01:04:41Z","git_url":"git://github.com/aluzzardi/swarmkit.git","ssh_url":"git@github.com:aluzzardi/swarmkit.git","clone_url":"https://github.com/aluzzardi/swarmkit.git","svn_url":"https://github.com/aluzzardi/swarmkit","homepage":"","size":9878,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"8cf1a5479c063016e2e7f02dc1afea8e4b747032","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":51556828,"name":"swarmkit","full_name":"docker/swarmkit","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/swarmkit","description":"A toolkit for orchestrating distributed systems at any scale. It includes primitives for node discovery, raft-based consensus, task scheduling and more.","fork":false,"url":"https://api.github.com/repos/docker/swarmkit","forks_url":"https://api.github.com/repos/docker/swarmkit/forks","keys_url":"https://api.github.com/repos/docker/swarmkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/swarmkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/swarmkit/teams","hooks_url":"https://api.github.com/repos/docker/swarmkit/hooks","issue_events_url":"https://api.github.com/repos/docker/swarmkit/issues/events{/number}","events_url":"https://api.github.com/repos/docker/swarmkit/events","assignees_url":"https://api.github.com/repos/docker/swarmkit/assignees{/user}","branches_url":"https://api.github.com/repos/docker/swarmkit/branches{/branch}","tags_url":"https://api.github.com/repos/docker/swarmkit/tags","blobs_url":"https://api.github.com/repos/docker/swarmkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/swarmkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/swarmkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/swarmkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/swarmkit/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/swarmkit/languages","stargazers_url":"https://api.github.com/repos/docker/swarmkit/stargazers","contributors_url":"https://api.github.com/repos/docker/swarmkit/contributors","subscribers_url":"https://api.github.com/repos/docker/swarmkit/subscribers","subscription_url":"https://api.github.com/repos/docker/swarmkit/subscription","commits_url":"https://api.github.com/repos/docker/swarmkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/swarmkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/swarmkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/swarmkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/swarmkit/contents/{+path}","compare_url":"https://api.github.com/repos/docker/swarmkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/swarmkit/merges","archive_url":"https://api.github.com/repos/docker/swarmkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/swarmkit/downloads","issues_url":"https://api.github.com/repos/docker/swarmkit/issues{/number}","pulls_url":"https://api.github.com/repos/docker/swarmkit/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/swarmkit/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/swarmkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/swarmkit/labels{/name}","releases_url":"https://api.github.com/repos/docker/swarmkit/releases{/id}","deployments_url":"https://api.github.com/repos/docker/swarmkit/deployments","created_at":"2016-02-12T00:02:15Z","updated_at":"2016-10-21T23:11:57Z","pushed_at":"2016-10-22T01:23:12Z","git_url":"git://github.com/docker/swarmkit.git","ssh_url":"git@github.com:docker/swarmkit.git","clone_url":"https://github.com/docker/swarmkit.git","svn_url":"https://github.com/docker/swarmkit","homepage":"","size":22314,"stargazers_count":1003,"watchers_count":1003,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":191,"mirror_url":null,"open_issues_count":184,"forks":191,"open_issues":184,"watchers":1003,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/swarmkit/pulls/1679"},"html":{"href":"https://github.com/docker/swarmkit/pull/1679"},"issue":{"href":"https://api.github.com/repos/docker/swarmkit/issues/1679"},"comments":{"href":"https://api.github.com/repos/docker/swarmkit/issues/1679/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/swarmkit/pulls/1679/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/swarmkit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/swarmkit/pulls/1679/commits"},"statuses":{"href":"https://api.github.com/repos/docker/swarmkit/statuses/d0dcf1bcfe434383d8426c97c92597afe98d4105"}}}}
{"actor":{"display_login":"aaronlehmann"}}