{"action":"created","issue":{"url":"https://api.github.com/repos/nunit/nunit/issues/1202","labels_url":"https://api.github.com/repos/nunit/nunit/issues/1202/labels{/name}","comments_url":"https://api.github.com/repos/nunit/nunit/issues/1202/comments","events_url":"https://api.github.com/repos/nunit/nunit/issues/1202/events","html_url":"https://github.com/nunit/nunit/pull/1202","id":127097146,"number":1202,"title":"1187 stoprun fix","user":{"login":"oznetmaster","id":5798625,"avatar_url":"https://avatars.githubusercontent.com/u/5798625?v=3","gravatar_id":"","url":"https://api.github.com/users/oznetmaster","html_url":"https://github.com/oznetmaster","followers_url":"https://api.github.com/users/oznetmaster/followers","following_url":"https://api.github.com/users/oznetmaster/following{/other_user}","gists_url":"https://api.github.com/users/oznetmaster/gists{/gist_id}","starred_url":"https://api.github.com/users/oznetmaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oznetmaster/subscriptions","organizations_url":"https://api.github.com/users/oznetmaster/orgs","repos_url":"https://api.github.com/users/oznetmaster/repos","events_url":"https://api.github.com/users/oznetmaster/events{/privacy}","received_events_url":"https://api.github.com/users/oznetmaster/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":10,"created_at":"2016-01-17T14:04:22Z","updated_at":"2016-01-30T22:20:30Z","closed_at":"2016-01-25T17:02:07Z","pull_request":{"url":"https://api.github.com/repos/nunit/nunit/pulls/1202","html_url":"https://github.com/nunit/nunit/pull/1202","diff_url":"https://github.com/nunit/nunit/pull/1202.diff","patch_url":"https://github.com/nunit/nunit/pull/1202.patch"},"body":"This PR implement/fixes the IAssemblyTestRunner.StopRun method to work in all cases.\r\n\r\nIt does this by always running a WorkItem on its own thread, where previously that was only done in cases of timeout, a separate thread or specific thread type required .\r\n \r\nIt then only aborts the actual thread the test is running on, and allows everything else to clean up itself normally.\r\n\r\nThis eliminates almost all special handling for both abort and stop operations."},"comment":{"url":"https://api.github.com/repos/nunit/nunit/issues/comments/177319686","html_url":"https://github.com/nunit/nunit/pull/1202#issuecomment-177319686","issue_url":"https://api.github.com/repos/nunit/nunit/issues/1202","id":177319686,"user":{"login":"CharliePoole","id":2678661,"avatar_url":"https://avatars.githubusercontent.com/u/2678661?v=3","gravatar_id":"","url":"https://api.github.com/users/CharliePoole","html_url":"https://github.com/CharliePoole","followers_url":"https://api.github.com/users/CharliePoole/followers","following_url":"https://api.github.com/users/CharliePoole/following{/other_user}","gists_url":"https://api.github.com/users/CharliePoole/gists{/gist_id}","starred_url":"https://api.github.com/users/CharliePoole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CharliePoole/subscriptions","organizations_url":"https://api.github.com/users/CharliePoole/orgs","repos_url":"https://api.github.com/users/CharliePoole/repos","events_url":"https://api.github.com/users/CharliePoole/events{/privacy}","received_events_url":"https://api.github.com/users/CharliePoole/received_events","type":"User","site_admin":false},"created_at":"2016-01-30T22:20:30Z","updated_at":"2016-01-30T22:20:30Z","body":"It looks like our Silverlight tests have not run correctly under Silverlight since this merge. It slipped past me, because they do work when run from the console using nunitlite-runner. However, when run directly as a silverlight app using nunit.framework.tests.xap, the run hangs and never terminates.\r\n\r\nI have confirmed this by reseting to the commit prior to this merge and seeing the tests run and then to the merge commit itself and seeing them hang.\r\n\r\nSince I came across this while working on adding further tests under Silverlight and Portable, I'll continue to look at it and try to include a fix in the same PR. \r\n\r\n@rprouse I was planning to do this as a standalone PR but if you would prefer an issue that's fine as well."}}