{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/23213","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/23213/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/23213/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/23213/events","html_url":"https://github.com/kubernetes/kubernetes/pull/23213","id":141972337,"number":23213,"title":"provide best effort generation for struct field types even if parent types are asymmetrical","user":{"login":"pweil-","id":5230419,"avatar_url":"https://avatars.githubusercontent.com/u/5230419?v=3","gravatar_id":"","url":"https://api.github.com/users/pweil-","html_url":"https://github.com/pweil-","followers_url":"https://api.github.com/users/pweil-/followers","following_url":"https://api.github.com/users/pweil-/following{/other_user}","gists_url":"https://api.github.com/users/pweil-/gists{/gist_id}","starred_url":"https://api.github.com/users/pweil-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pweil-/subscriptions","organizations_url":"https://api.github.com/users/pweil-/orgs","repos_url":"https://api.github.com/users/pweil-/repos","events_url":"https://api.github.com/users/pweil-/events{/privacy}","received_events_url":"https://api.github.com/users/pweil-/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cla:%20yes","name":"cla: yes","color":"bfe5bf"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/lgtm","name":"lgtm","color":"15dd18"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/M","name":"size/M","color":"eebb00"}],"state":"open","locked":false,"assignee":{"login":"liggitt","id":980082,"avatar_url":"https://avatars.githubusercontent.com/u/980082?v=3","gravatar_id":"","url":"https://api.github.com/users/liggitt","html_url":"https://github.com/liggitt","followers_url":"https://api.github.com/users/liggitt/followers","following_url":"https://api.github.com/users/liggitt/following{/other_user}","gists_url":"https://api.github.com/users/liggitt/gists{/gist_id}","starred_url":"https://api.github.com/users/liggitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liggitt/subscriptions","organizations_url":"https://api.github.com/users/liggitt/orgs","repos_url":"https://api.github.com/users/liggitt/repos","events_url":"https://api.github.com/users/liggitt/events{/privacy}","received_events_url":"https://api.github.com/users/liggitt/received_events","type":"User","site_admin":false},"milestone":null,"comments":18,"created_at":"2016-03-18T20:39:58Z","updated_at":"2016-03-23T14:45:12Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/23213","html_url":"https://github.com/kubernetes/kubernetes/pull/23213","diff_url":"https://github.com/kubernetes/kubernetes/pull/23213.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/23213.patch"},"body":"@wojtek-t @liggitt I found that if I had an asymmetrical type being converted that not all the public conversions were being generated.  This appears to fix the issue.\r\n\r\nScenario:\r\n\r\nType A\r\n```\r\nv1.Foo {\r\n   Field1\r\n   OtherComplexStruct\r\n}\r\n```\r\n\r\nType B\r\n```\r\napi.Foo {\r\n   //no Field1\r\n   OtherComplexStruct\r\n}\r\n```\r\n\r\nThe resulting generation created an `autoConvert` function for `v1.Foo` that used reflection for `OtherComplexStruct`.  This change allowed it to generate the public conversions and `autoConvert` methods for `OtherComplexStruct`.\r\n\r\nNote: I did have conversions in `conversion.go` for both types and it correctly did not generate the public conversion methods in this case.  It was just the `autoConvert` functions that seemed to have an issue.\r\n\r\nPTAL"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/200375574","html_url":"https://github.com/kubernetes/kubernetes/pull/23213#issuecomment-200375574","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/23213","id":200375574,"user":{"login":"k8s-bot","id":12551979,"avatar_url":"https://avatars.githubusercontent.com/u/12551979?v=3","gravatar_id":"","url":"https://api.github.com/users/k8s-bot","html_url":"https://github.com/k8s-bot","followers_url":"https://api.github.com/users/k8s-bot/followers","following_url":"https://api.github.com/users/k8s-bot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-bot/subscriptions","organizations_url":"https://api.github.com/users/k8s-bot/orgs","repos_url":"https://api.github.com/users/k8s-bot/repos","events_url":"https://api.github.com/users/k8s-bot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-bot/received_events","type":"User","site_admin":false},"created_at":"2016-03-23T14:45:11Z","updated_at":"2016-03-23T14:45:11Z","body":"GCE e2e build/test **passed** for commit dd4ff1690d3dba672751f4bd088dda80d849cdb2.\n* [Build Log](http://pr-test.k8s.io/23213/kubernetes-pull-build-test-e2e-gce/33401/build-log.txt)\n* [Test Artifacts](https://console.developers.google.com/storage/browser/kubernetes-jenkins/pr-logs/pull/23213/kubernetes-pull-build-test-e2e-gce/33401/artifacts/)\n* [Internal Jenkins Results](http://goto.google.com/prkubekins/job/kubernetes-pull-build-test-e2e-gce//33401)\n"}}