{"action":"created","comment":{"url":"https://api.github.com/repos/yahoo/fili/pulls/comments/85777809","pull_request_review_id":6472970,"id":85777809,"diff_hunk":"@@ -0,0 +1,54 @@\n+// Copyright 2016 Yahoo Inc.\n+// Licensed under the terms of the Apache license. Please see LICENSE.md file distributed with this work for terms.\n+package com.yahoo.bard.webservice.logging;\n+\n+import com.yahoo.bard.webservice.config.SystemConfig;\n+import com.yahoo.bard.webservice.config.SystemConfigProvider;\n+import org.slf4j.Logger;\n+import org.slf4j.LoggerFactory;\n+\n+/**\n+ * A class to provide a log formatter instance.\n+ */\n+public class LogFormatterProvider {\n+\n+    private static final Logger LOG = LoggerFactory.getLogger(LogFormatterProvider.class);\n+    private static final SystemConfig SYSTEM_CONFIG = SystemConfigProvider.getInstance();\n+\n+    private static final String DEFAULT_LOG_FORMATTER_IMPL = JsonLogFormatter.class.getCanonicalName();\n+\n+    private static final String LOG_FORMATTER_IMPLEMENTATION_KEY = SystemConfigProvider.getInstance().getStringProperty(\n+            SYSTEM_CONFIG.getPackageVariableName(\"log_formatter_implementation\"),\n+            DEFAULT_LOG_FORMATTER_IMPL\n+    );\n+\n+    /**\n+     * The instance of the Log Formatter.\n+     */\n+    private static final LogFormatter LOG_FORMATTER = getInstance();\n+","path":"fili-core/src/main/java/com/yahoo/bard/webservice/logging/LogFormatterProvider.java","position":29,"original_position":29,"commit_id":"e2f8e5761c702585780cf58f36de95508ed1e1e1","original_commit_id":"e2f8e5761c702585780cf58f36de95508ed1e1e1","user":{"login":"michael-mclawhorn","id":4105159,"avatar_url":"https://avatars.githubusercontent.com/u/4105159?v=3","gravatar_id":"","url":"https://api.github.com/users/michael-mclawhorn","html_url":"https://github.com/michael-mclawhorn","followers_url":"https://api.github.com/users/michael-mclawhorn/followers","following_url":"https://api.github.com/users/michael-mclawhorn/following{/other_user}","gists_url":"https://api.github.com/users/michael-mclawhorn/gists{/gist_id}","starred_url":"https://api.github.com/users/michael-mclawhorn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michael-mclawhorn/subscriptions","organizations_url":"https://api.github.com/users/michael-mclawhorn/orgs","repos_url":"https://api.github.com/users/michael-mclawhorn/repos","events_url":"https://api.github.com/users/michael-mclawhorn/events{/privacy}","received_events_url":"https://api.github.com/users/michael-mclawhorn/received_events","type":"User","site_admin":false},"body":"I'm not convinced that final is the correct behavior here.  SystemConfig was intended to allow bootstrapping to more sophisticated configurations at runtime.  I'm not sure that it wouldn't make sense to allow this to do the same.","created_at":"2016-10-31T16:33:30Z","updated_at":"2016-10-31T16:34:15Z","html_url":"https://github.com/yahoo/fili/pull/81#discussion_r85777809","pull_request_url":"https://api.github.com/repos/yahoo/fili/pulls/81","_links":{"self":{"href":"https://api.github.com/repos/yahoo/fili/pulls/comments/85777809"},"html":{"href":"https://github.com/yahoo/fili/pull/81#discussion_r85777809"},"pull_request":{"href":"https://api.github.com/repos/yahoo/fili/pulls/81"}}},"pull_request":{"url":"https://api.github.com/repos/yahoo/fili/pulls/81","id":91403222,"html_url":"https://github.com/yahoo/fili/pull/81","diff_url":"https://github.com/yahoo/fili/pull/81.diff","patch_url":"https://github.com/yahoo/fili/pull/81.patch","issue_url":"https://api.github.com/repos/yahoo/fili/issues/81","number":81,"state":"open","locked":false,"title":"Implement log formatter","user":{"login":"QubitPi","id":16126939,"avatar_url":"https://avatars.githubusercontent.com/u/16126939?v=3","gravatar_id":"","url":"https://api.github.com/users/QubitPi","html_url":"https://github.com/QubitPi","followers_url":"https://api.github.com/users/QubitPi/followers","following_url":"https://api.github.com/users/QubitPi/following{/other_user}","gists_url":"https://api.github.com/users/QubitPi/gists{/gist_id}","starred_url":"https://api.github.com/users/QubitPi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/QubitPi/subscriptions","organizations_url":"https://api.github.com/users/QubitPi/orgs","repos_url":"https://api.github.com/users/QubitPi/repos","events_url":"https://api.github.com/users/QubitPi/events{/privacy}","received_events_url":"https://api.github.com/users/QubitPi/received_events","type":"User","site_admin":false},"body":"Issue https://github.com/yahoo/fili/issues/74\n","created_at":"2016-10-28T15:35:14Z","updated_at":"2016-10-31T16:37:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7622a1c5e11f6ac49855dfa8356b1fb45b0ddea5","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/yahoo/fili/pulls/81/commits","review_comments_url":"https://api.github.com/repos/yahoo/fili/pulls/81/comments","review_comment_url":"https://api.github.com/repos/yahoo/fili/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yahoo/fili/issues/81/comments","statuses_url":"https://api.github.com/repos/yahoo/fili/statuses/e2f8e5761c702585780cf58f36de95508ed1e1e1","head":{"label":"QubitPi:implement-logFormatter","ref":"implement-logFormatter","sha":"e2f8e5761c702585780cf58f36de95508ed1e1e1","user":{"login":"QubitPi","id":16126939,"avatar_url":"https://avatars.githubusercontent.com/u/16126939?v=3","gravatar_id":"","url":"https://api.github.com/users/QubitPi","html_url":"https://github.com/QubitPi","followers_url":"https://api.github.com/users/QubitPi/followers","following_url":"https://api.github.com/users/QubitPi/following{/other_user}","gists_url":"https://api.github.com/users/QubitPi/gists{/gist_id}","starred_url":"https://api.github.com/users/QubitPi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/QubitPi/subscriptions","organizations_url":"https://api.github.com/users/QubitPi/orgs","repos_url":"https://api.github.com/users/QubitPi/repos","events_url":"https://api.github.com/users/QubitPi/events{/privacy}","received_events_url":"https://api.github.com/users/QubitPi/received_events","type":"User","site_admin":false},"repo":{"id":72151582,"name":"fili","full_name":"QubitPi/fili","owner":{"login":"QubitPi","id":16126939,"avatar_url":"https://avatars.githubusercontent.com/u/16126939?v=3","gravatar_id":"","url":"https://api.github.com/users/QubitPi","html_url":"https://github.com/QubitPi","followers_url":"https://api.github.com/users/QubitPi/followers","following_url":"https://api.github.com/users/QubitPi/following{/other_user}","gists_url":"https://api.github.com/users/QubitPi/gists{/gist_id}","starred_url":"https://api.github.com/users/QubitPi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/QubitPi/subscriptions","organizations_url":"https://api.github.com/users/QubitPi/orgs","repos_url":"https://api.github.com/users/QubitPi/repos","events_url":"https://api.github.com/users/QubitPi/events{/privacy}","received_events_url":"https://api.github.com/users/QubitPi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/QubitPi/fili","description":"Easily make RESTful web services for time series reporting with Big Data analytics engines like Druid and Hive.","fork":true,"url":"https://api.github.com/repos/QubitPi/fili","forks_url":"https://api.github.com/repos/QubitPi/fili/forks","keys_url":"https://api.github.com/repos/QubitPi/fili/keys{/key_id}","collaborators_url":"https://api.github.com/repos/QubitPi/fili/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/QubitPi/fili/teams","hooks_url":"https://api.github.com/repos/QubitPi/fili/hooks","issue_events_url":"https://api.github.com/repos/QubitPi/fili/issues/events{/number}","events_url":"https://api.github.com/repos/QubitPi/fili/events","assignees_url":"https://api.github.com/repos/QubitPi/fili/assignees{/user}","branches_url":"https://api.github.com/repos/QubitPi/fili/branches{/branch}","tags_url":"https://api.github.com/repos/QubitPi/fili/tags","blobs_url":"https://api.github.com/repos/QubitPi/fili/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/QubitPi/fili/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/QubitPi/fili/git/refs{/sha}","trees_url":"https://api.github.com/repos/QubitPi/fili/git/trees{/sha}","statuses_url":"https://api.github.com/repos/QubitPi/fili/statuses/{sha}","languages_url":"https://api.github.com/repos/QubitPi/fili/languages","stargazers_url":"https://api.github.com/repos/QubitPi/fili/stargazers","contributors_url":"https://api.github.com/repos/QubitPi/fili/contributors","subscribers_url":"https://api.github.com/repos/QubitPi/fili/subscribers","subscription_url":"https://api.github.com/repos/QubitPi/fili/subscription","commits_url":"https://api.github.com/repos/QubitPi/fili/commits{/sha}","git_commits_url":"https://api.github.com/repos/QubitPi/fili/git/commits{/sha}","comments_url":"https://api.github.com/repos/QubitPi/fili/comments{/number}","issue_comment_url":"https://api.github.com/repos/QubitPi/fili/issues/comments{/number}","contents_url":"https://api.github.com/repos/QubitPi/fili/contents/{+path}","compare_url":"https://api.github.com/repos/QubitPi/fili/compare/{base}...{head}","merges_url":"https://api.github.com/repos/QubitPi/fili/merges","archive_url":"https://api.github.com/repos/QubitPi/fili/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/QubitPi/fili/downloads","issues_url":"https://api.github.com/repos/QubitPi/fili/issues{/number}","pulls_url":"https://api.github.com/repos/QubitPi/fili/pulls{/number}","milestones_url":"https://api.github.com/repos/QubitPi/fili/milestones{/number}","notifications_url":"https://api.github.com/repos/QubitPi/fili/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/QubitPi/fili/labels{/name}","releases_url":"https://api.github.com/repos/QubitPi/fili/releases{/id}","deployments_url":"https://api.github.com/repos/QubitPi/fili/deployments","created_at":"2016-10-27T21:59:07Z","updated_at":"2016-10-27T21:59:10Z","pushed_at":"2016-10-31T15:56:50Z","git_url":"git://github.com/QubitPi/fili.git","ssh_url":"git@github.com:QubitPi/fili.git","clone_url":"https://github.com/QubitPi/fili.git","svn_url":"https://github.com/QubitPi/fili","homepage":"","size":1333,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"yahoo:master","ref":"master","sha":"6bf54c9e4501046c9db61c48083fe1c75555e3a5","user":{"login":"yahoo","id":16574,"avatar_url":"https://avatars.githubusercontent.com/u/16574?v=3","gravatar_id":"","url":"https://api.github.com/users/yahoo","html_url":"https://github.com/yahoo","followers_url":"https://api.github.com/users/yahoo/followers","following_url":"https://api.github.com/users/yahoo/following{/other_user}","gists_url":"https://api.github.com/users/yahoo/gists{/gist_id}","starred_url":"https://api.github.com/users/yahoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yahoo/subscriptions","organizations_url":"https://api.github.com/users/yahoo/orgs","repos_url":"https://api.github.com/users/yahoo/repos","events_url":"https://api.github.com/users/yahoo/events{/privacy}","received_events_url":"https://api.github.com/users/yahoo/received_events","type":"Organization","site_admin":false},"repo":{"id":60879636,"name":"fili","full_name":"yahoo/fili","owner":{"login":"yahoo","id":16574,"avatar_url":"https://avatars.githubusercontent.com/u/16574?v=3","gravatar_id":"","url":"https://api.github.com/users/yahoo","html_url":"https://github.com/yahoo","followers_url":"https://api.github.com/users/yahoo/followers","following_url":"https://api.github.com/users/yahoo/following{/other_user}","gists_url":"https://api.github.com/users/yahoo/gists{/gist_id}","starred_url":"https://api.github.com/users/yahoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yahoo/subscriptions","organizations_url":"https://api.github.com/users/yahoo/orgs","repos_url":"https://api.github.com/users/yahoo/repos","events_url":"https://api.github.com/users/yahoo/events{/privacy}","received_events_url":"https://api.github.com/users/yahoo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yahoo/fili","description":"Easily make RESTful web services for time series reporting with Big Data analytics engines like Druid and Hive.","fork":false,"url":"https://api.github.com/repos/yahoo/fili","forks_url":"https://api.github.com/repos/yahoo/fili/forks","keys_url":"https://api.github.com/repos/yahoo/fili/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yahoo/fili/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yahoo/fili/teams","hooks_url":"https://api.github.com/repos/yahoo/fili/hooks","issue_events_url":"https://api.github.com/repos/yahoo/fili/issues/events{/number}","events_url":"https://api.github.com/repos/yahoo/fili/events","assignees_url":"https://api.github.com/repos/yahoo/fili/assignees{/user}","branches_url":"https://api.github.com/repos/yahoo/fili/branches{/branch}","tags_url":"https://api.github.com/repos/yahoo/fili/tags","blobs_url":"https://api.github.com/repos/yahoo/fili/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yahoo/fili/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yahoo/fili/git/refs{/sha}","trees_url":"https://api.github.com/repos/yahoo/fili/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yahoo/fili/statuses/{sha}","languages_url":"https://api.github.com/repos/yahoo/fili/languages","stargazers_url":"https://api.github.com/repos/yahoo/fili/stargazers","contributors_url":"https://api.github.com/repos/yahoo/fili/contributors","subscribers_url":"https://api.github.com/repos/yahoo/fili/subscribers","subscription_url":"https://api.github.com/repos/yahoo/fili/subscription","commits_url":"https://api.github.com/repos/yahoo/fili/commits{/sha}","git_commits_url":"https://api.github.com/repos/yahoo/fili/git/commits{/sha}","comments_url":"https://api.github.com/repos/yahoo/fili/comments{/number}","issue_comment_url":"https://api.github.com/repos/yahoo/fili/issues/comments{/number}","contents_url":"https://api.github.com/repos/yahoo/fili/contents/{+path}","compare_url":"https://api.github.com/repos/yahoo/fili/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yahoo/fili/merges","archive_url":"https://api.github.com/repos/yahoo/fili/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yahoo/fili/downloads","issues_url":"https://api.github.com/repos/yahoo/fili/issues{/number}","pulls_url":"https://api.github.com/repos/yahoo/fili/pulls{/number}","milestones_url":"https://api.github.com/repos/yahoo/fili/milestones{/number}","notifications_url":"https://api.github.com/repos/yahoo/fili/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yahoo/fili/labels{/name}","releases_url":"https://api.github.com/repos/yahoo/fili/releases{/id}","deployments_url":"https://api.github.com/repos/yahoo/fili/deployments","created_at":"2016-06-10T22:07:59Z","updated_at":"2016-10-28T15:47:36Z","pushed_at":"2016-10-31T15:56:51Z","git_url":"git://github.com/yahoo/fili.git","ssh_url":"git@github.com:yahoo/fili.git","clone_url":"https://github.com/yahoo/fili.git","svn_url":"https://github.com/yahoo/fili","homepage":"","size":1936,"stargazers_count":15,"watchers_count":15,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":20,"forks":13,"open_issues":20,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yahoo/fili/pulls/81"},"html":{"href":"https://github.com/yahoo/fili/pull/81"},"issue":{"href":"https://api.github.com/repos/yahoo/fili/issues/81"},"comments":{"href":"https://api.github.com/repos/yahoo/fili/issues/81/comments"},"review_comments":{"href":"https://api.github.com/repos/yahoo/fili/pulls/81/comments"},"review_comment":{"href":"https://api.github.com/repos/yahoo/fili/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yahoo/fili/pulls/81/commits"},"statuses":{"href":"https://api.github.com/repos/yahoo/fili/statuses/e2f8e5761c702585780cf58f36de95508ed1e1e1"}}}}
{"actor":{"display_login":"michael-mclawhorn"}}