{"action":"created","issue":{"url":"https://api.github.com/repos/Teradata/presto/issues/304","repository_url":"https://api.github.com/repos/Teradata/presto","labels_url":"https://api.github.com/repos/Teradata/presto/issues/304/labels{/name}","comments_url":"https://api.github.com/repos/Teradata/presto/issues/304/comments","events_url":"https://api.github.com/repos/Teradata/presto/issues/304/events","html_url":"https://github.com/Teradata/presto/pull/304","id":171487590,"number":304,"title":"Make the AST the canonical source for window frame information","user":{"login":"ebd2","id":12751788,"avatar_url":"https://avatars.githubusercontent.com/u/12751788?v=3","gravatar_id":"","url":"https://api.github.com/users/ebd2","html_url":"https://github.com/ebd2","followers_url":"https://api.github.com/users/ebd2/followers","following_url":"https://api.github.com/users/ebd2/following{/other_user}","gists_url":"https://api.github.com/users/ebd2/gists{/gist_id}","starred_url":"https://api.github.com/users/ebd2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebd2/subscriptions","organizations_url":"https://api.github.com/users/ebd2/orgs","repos_url":"https://api.github.com/users/ebd2/repos","events_url":"https://api.github.com/users/ebd2/events{/privacy}","received_events_url":"https://api.github.com/users/ebd2/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"maciejgrzybek","id":366501,"avatar_url":"https://avatars.githubusercontent.com/u/366501?v=3","gravatar_id":"","url":"https://api.github.com/users/maciejgrzybek","html_url":"https://github.com/maciejgrzybek","followers_url":"https://api.github.com/users/maciejgrzybek/followers","following_url":"https://api.github.com/users/maciejgrzybek/following{/other_user}","gists_url":"https://api.github.com/users/maciejgrzybek/gists{/gist_id}","starred_url":"https://api.github.com/users/maciejgrzybek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maciejgrzybek/subscriptions","organizations_url":"https://api.github.com/users/maciejgrzybek/orgs","repos_url":"https://api.github.com/users/maciejgrzybek/repos","events_url":"https://api.github.com/users/maciejgrzybek/events{/privacy}","received_events_url":"https://api.github.com/users/maciejgrzybek/received_events","type":"User","site_admin":false},"assignees":[{"login":"maciejgrzybek","id":366501,"avatar_url":"https://avatars.githubusercontent.com/u/366501?v=3","gravatar_id":"","url":"https://api.github.com/users/maciejgrzybek","html_url":"https://github.com/maciejgrzybek","followers_url":"https://api.github.com/users/maciejgrzybek/followers","following_url":"https://api.github.com/users/maciejgrzybek/following{/other_user}","gists_url":"https://api.github.com/users/maciejgrzybek/gists{/gist_id}","starred_url":"https://api.github.com/users/maciejgrzybek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maciejgrzybek/subscriptions","organizations_url":"https://api.github.com/users/maciejgrzybek/orgs","repos_url":"https://api.github.com/users/maciejgrzybek/repos","events_url":"https://api.github.com/users/maciejgrzybek/events{/privacy}","received_events_url":"https://api.github.com/users/maciejgrzybek/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2016-08-16T18:39:52Z","updated_at":"2016-08-16T19:02:18Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Teradata/presto/pulls/304","html_url":"https://github.com/Teradata/presto/pull/304","diff_url":"https://github.com/Teradata/presto/pull/304.diff","patch_url":"https://github.com/Teradata/presto/pull/304.patch"},"body":"The AST currently contains empty window frames and frame end bounds when none are specified. Later the planner creates WindowNodes containing window frames (and frame end bounds) with the SQL standard defaults when the AST has empty frames (or bounds).\r\n\r\nThis has two effects:\r\n1) the AST is not the canonical source for frame information\r\n2) The AST and the plan are inconsistent in terms of what they contain\r\n\r\nEnsuring that the AST contains the appropriate defaults resolves both of those and also simplifies a whole bunch of places in the analyzer and planner that currently have to handle the default window frame as a special case."},"comment":{"url":"https://api.github.com/repos/Teradata/presto/issues/comments/240204090","html_url":"https://github.com/Teradata/presto/pull/304#issuecomment-240204090","issue_url":"https://api.github.com/repos/Teradata/presto/issues/304","id":240204090,"user":{"login":"maciejgrzybek","id":366501,"avatar_url":"https://avatars.githubusercontent.com/u/366501?v=3","gravatar_id":"","url":"https://api.github.com/users/maciejgrzybek","html_url":"https://github.com/maciejgrzybek","followers_url":"https://api.github.com/users/maciejgrzybek/followers","following_url":"https://api.github.com/users/maciejgrzybek/following{/other_user}","gists_url":"https://api.github.com/users/maciejgrzybek/gists{/gist_id}","starred_url":"https://api.github.com/users/maciejgrzybek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maciejgrzybek/subscriptions","organizations_url":"https://api.github.com/users/maciejgrzybek/orgs","repos_url":"https://api.github.com/users/maciejgrzybek/repos","events_url":"https://api.github.com/users/maciejgrzybek/events{/privacy}","received_events_url":"https://api.github.com/users/maciejgrzybek/received_events","type":"User","site_admin":false},"created_at":"2016-08-16T19:02:18Z","updated_at":"2016-08-16T19:02:18Z","body":"I'd consider moving a60bf5c294f18e679db7b099c3a3aa7f9f21abec before f5a57febdbef7b62f1ef628aaede4c40d666c32b. Would look more consistent. But I won't insist."}}
{"actor":{"display_login":"maciejgrzybek"}}