{"action":"created","issue":{"url":"https://api.github.com/repos/Automattic/knox/issues/273","repository_url":"https://api.github.com/repos/Automattic/knox","labels_url":"https://api.github.com/repos/Automattic/knox/issues/273/labels{/name}","comments_url":"https://api.github.com/repos/Automattic/knox/issues/273/comments","events_url":"https://api.github.com/repos/Automattic/knox/issues/273/events","html_url":"https://github.com/Automattic/knox/pull/273","id":60582772,"number":273,"title":"AWS S3 Signature v4","user":{"login":"shfx","id":161365,"avatar_url":"https://avatars.githubusercontent.com/u/161365?v=3","gravatar_id":"","url":"https://api.github.com/users/shfx","html_url":"https://github.com/shfx","followers_url":"https://api.github.com/users/shfx/followers","following_url":"https://api.github.com/users/shfx/following{/other_user}","gists_url":"https://api.github.com/users/shfx/gists{/gist_id}","starred_url":"https://api.github.com/users/shfx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shfx/subscriptions","organizations_url":"https://api.github.com/users/shfx/orgs","repos_url":"https://api.github.com/users/shfx/repos","events_url":"https://api.github.com/users/shfx/events{/privacy}","received_events_url":"https://api.github.com/users/shfx/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":11,"created_at":"2015-03-10T22:51:06Z","updated_at":"2016-05-03T06:54:12Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Automattic/knox/pulls/273","html_url":"https://github.com/Automattic/knox/pull/273","diff_url":"https://github.com/Automattic/knox/pull/273.diff","patch_url":"https://github.com/Automattic/knox/pull/273.patch"},"body":"This PR holds implementation for [AWS S3 Signature v4](http://docs.aws.amazon.com/AmazonS3/latest/API/sig-v4-authenticating-requests.html) for each non-put requests. While main strength of Knox is streaming instead of buffering, I also reimplemented PUT stream to use [REST Multipart Upload](http://docs.aws.amazon.com/AmazonS3/latest/dev/UsingRESTAPImpUpload.html).\r\n\r\nInstead of rewriting `lib/auth.js` module to match the specification, I added [aws4](https://github.com/mhart/aws4) as a depedency and removed obsolete functions in `lib/auth.js` and coresponding tests from `test/auth.test.js`. One thing that I left in `lib/auth.js` was `signQuery()` mainly because aws4 library haven't got this implemented yet for some reason.\r\n\r\nDespite my effort to keep the API intact I suggest bumping the major version number, because this patch might break some existing code integrations (e.g if somebody was using the auth module that is exported in `lib/index.js`)  \r\n\r\nFixes #254\r\n\r\nFYI: This PR does not contain any optimisation, just pure implementation of Signature v4"},"comment":{"url":"https://api.github.com/repos/Automattic/knox/issues/comments/216453403","html_url":"https://github.com/Automattic/knox/pull/273#issuecomment-216453403","issue_url":"https://api.github.com/repos/Automattic/knox/issues/273","id":216453403,"user":{"login":"skatpgusskat","id":3580430,"avatar_url":"https://avatars.githubusercontent.com/u/3580430?v=3","gravatar_id":"","url":"https://api.github.com/users/skatpgusskat","html_url":"https://github.com/skatpgusskat","followers_url":"https://api.github.com/users/skatpgusskat/followers","following_url":"https://api.github.com/users/skatpgusskat/following{/other_user}","gists_url":"https://api.github.com/users/skatpgusskat/gists{/gist_id}","starred_url":"https://api.github.com/users/skatpgusskat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skatpgusskat/subscriptions","organizations_url":"https://api.github.com/users/skatpgusskat/orgs","repos_url":"https://api.github.com/users/skatpgusskat/repos","events_url":"https://api.github.com/users/skatpgusskat/events{/privacy}","received_events_url":"https://api.github.com/users/skatpgusskat/received_events","type":"User","site_admin":false},"created_at":"2016-05-03T06:54:12Z","updated_at":"2016-05-03T06:54:12Z","body":"still waiting..."}}