{"action":"created","issue":{"url":"https://api.github.com/repos/dteviot/WebToEpub/issues/69","repository_url":"https://api.github.com/repos/dteviot/WebToEpub","labels_url":"https://api.github.com/repos/dteviot/WebToEpub/issues/69/labels{/name}","comments_url":"https://api.github.com/repos/dteviot/WebToEpub/issues/69/comments","events_url":"https://api.github.com/repos/dteviot/WebToEpub/issues/69/events","html_url":"https://github.com/dteviot/WebToEpub/issues/69","id":171095796,"number":69,"title":"Do not call alert() inside a promise.","user":{"login":"dteviot","id":5157081,"avatar_url":"https://avatars.githubusercontent.com/u/5157081?v=3","gravatar_id":"","url":"https://api.github.com/users/dteviot","html_url":"https://github.com/dteviot","followers_url":"https://api.github.com/users/dteviot/followers","following_url":"https://api.github.com/users/dteviot/following{/other_user}","gists_url":"https://api.github.com/users/dteviot/gists{/gist_id}","starred_url":"https://api.github.com/users/dteviot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dteviot/subscriptions","organizations_url":"https://api.github.com/users/dteviot/orgs","repos_url":"https://api.github.com/users/dteviot/repos","events_url":"https://api.github.com/users/dteviot/events{/privacy}","received_events_url":"https://api.github.com/users/dteviot/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/dteviot/WebToEpub/labels/bug","name":"bug","color":"fc2929"},{"url":"https://api.github.com/repos/dteviot/WebToEpub/labels/medium%20priority","name":"medium priority","color":"0e8a16"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-08-15T02:01:19Z","updated_at":"2016-08-28T19:19:34Z","closed_at":null,"body":"Chrome v53 will not allow alert() to be called as part of a promise.\r\ne.g. This will fail.\r\n```javascript\r\nnew Promise(function(res,rej) { resolver = res }).then(function() { alert(42); });\r\nres(23);\r\n```\r\nSee: https://bugs.chromium.org/p/chromium/issues/detail?id=605517 for more details.\r\nSuggested solution: replace alert with\r\n```javascript\r\nsetTimeout(function() { alert('error occurred'); }, 0)\r\n```\r\n\r\nThis might be useful: https://developer.mozilla.org/en-US/docs/Web/API/notification"},"comment":{"url":"https://api.github.com/repos/dteviot/WebToEpub/issues/comments/242993684","html_url":"https://github.com/dteviot/WebToEpub/issues/69#issuecomment-242993684","issue_url":"https://api.github.com/repos/dteviot/WebToEpub/issues/69","id":242993684,"user":{"login":"typhoon71","id":1866248,"avatar_url":"https://avatars.githubusercontent.com/u/1866248?v=3","gravatar_id":"","url":"https://api.github.com/users/typhoon71","html_url":"https://github.com/typhoon71","followers_url":"https://api.github.com/users/typhoon71/followers","following_url":"https://api.github.com/users/typhoon71/following{/other_user}","gists_url":"https://api.github.com/users/typhoon71/gists{/gist_id}","starred_url":"https://api.github.com/users/typhoon71/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/typhoon71/subscriptions","organizations_url":"https://api.github.com/users/typhoon71/orgs","repos_url":"https://api.github.com/users/typhoon71/repos","events_url":"https://api.github.com/users/typhoon71/events{/privacy}","received_events_url":"https://api.github.com/users/typhoon71/received_events","type":"User","site_admin":false},"created_at":"2016-08-28T19:19:34Z","updated_at":"2016-08-28T19:19:34Z","body":"**Trying to parse a page there's no parser:** it correctly tells you there's no parser.\r\n\r\n**Taking the network out (midway):**\r\n\r\nfetch of URL(https://www.baka-tsuki.org/project/index.php?title=File:BloodSign_v02_008.jpg) failed. Error: Error: fetch of URL(https://www.baka-tsuki.org/project/index.php?title=File:BloodSign_v02_008.jpg) failed. Error: \r\nat HttpClient.onError (chrome-extension://agfpeiicolmhejoffeadiiildggjdkka/js/HttpClient.js:14:16)\r\nat XMLHttpRequest.xhr.onerror (chrome-extension://agfpeiicolmhejoffeadiiildggjdkka/js/HttpClient.js:24:51)\r\n\r\nWhich is expected. Similar error if net is disconnected afterthe addon loaded the page.\r\n\r\n**Dungeon Defense on RNL:** usual issue with images (wrong link):\r\n\r\nfetch of URL(https://shalvationtranslations.files.wordpress.com/2016/06/xcqoevp.jpg?w=700) failed. Error: Error: fetch of URL(https://shalvationtranslations.files.wordpress.com/2016/06/xcqoevp.jpg?w=700) failed. Error: \r\nat HttpClient.onError (chrome-extension://agfpeiicolmhejoffeadiiildggjdkka/js/HttpClient.js:14:16)\r\nat HttpClient.validateStatus (chrome-extension://agfpeiicolmhejoffeadiiildggjdkka/js/HttpClient.js:37:22)\r\nat HttpClient.onLoadHtml (chrome-extension://agfpeiicolmhejoffeadiiildggjdkka/js/HttpClient.js:47:18)\r\nat XMLHttpRequest.xhr.onload (chrome-extension://agfpeiicolmhejoffeadiiildggjdkka/js/HttpClient.js:23:50)\r\n\r\n**WuxiaWorld:** I checked WMW, if you launch the addon from the \"single\" chapter page it downloads stuff wrongly; I think it should be better if the addon would recognize the index pages only.\r\n\r\nThis is with chrome"}}
{"actor":{"display_login":"typhoon71"}}