{"action":"created","comment":{"url":"https://api.github.com/repos/F5Networks/f5-openstack-agent/pulls/comments/59287064","id":59287064,"diff_hunk":"@@ -266,6 +270,8 @@ def _delete_bigip_snats(self, bigip, subnetinfo, tenant_id):\n             if not snatpool.members:\n                 LOG.debug('Snat pool is empty - delete snatpool')\n                 snatpool.delete()\n+            else:","path":"f5_openstack_agent/lbaasv2/drivers/bigip/snats.py","position":42,"original_position":42,"commit_id":"7ae9ab11abad4a3629f2454a9c79d0eac90a9424","original_commit_id":"7ae9ab11abad4a3629f2454a9c79d0eac90a9424","user":{"login":"richbrowne","id":8740561,"avatar_url":"https://avatars.githubusercontent.com/u/8740561?v=3","gravatar_id":"","url":"https://api.github.com/users/richbrowne","html_url":"https://github.com/richbrowne","followers_url":"https://api.github.com/users/richbrowne/followers","following_url":"https://api.github.com/users/richbrowne/following{/other_user}","gists_url":"https://api.github.com/users/richbrowne/gists{/gist_id}","starred_url":"https://api.github.com/users/richbrowne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richbrowne/subscriptions","organizations_url":"https://api.github.com/users/richbrowne/orgs","repos_url":"https://api.github.com/users/richbrowne/repos","events_url":"https://api.github.com/users/richbrowne/events{/privacy}","received_events_url":"https://api.github.com/users/richbrowne/received_events","type":"User","site_admin":false},"body":"Exception handling?","created_at":"2016-04-11T21:43:56Z","updated_at":"2016-04-11T21:43:56Z","html_url":"https://github.com/F5Networks/f5-openstack-agent/pull/67#discussion_r59287064","pull_request_url":"https://api.github.com/repos/F5Networks/f5-openstack-agent/pulls/67","_links":{"self":{"href":"https://api.github.com/repos/F5Networks/f5-openstack-agent/pulls/comments/59287064"},"html":{"href":"https://github.com/F5Networks/f5-openstack-agent/pull/67#discussion_r59287064"},"pull_request":{"href":"https://api.github.com/repos/F5Networks/f5-openstack-agent/pulls/67"}}},"pull_request":{"url":"https://api.github.com/repos/F5Networks/f5-openstack-agent/pulls/67","id":66055575,"html_url":"https://github.com/F5Networks/f5-openstack-agent/pull/67","diff_url":"https://github.com/F5Networks/f5-openstack-agent/pull/67.diff","patch_url":"https://github.com/F5Networks/f5-openstack-agent/pull/67.patch","issue_url":"https://api.github.com/repos/F5Networks/f5-openstack-agent/issues/67","number":67,"state":"open","locked":false,"title":"Feature.cleanup","user":{"login":"jlongstaf","id":14281800,"avatar_url":"https://avatars.githubusercontent.com/u/14281800?v=3","gravatar_id":"","url":"https://api.github.com/users/jlongstaf","html_url":"https://github.com/jlongstaf","followers_url":"https://api.github.com/users/jlongstaf/followers","following_url":"https://api.github.com/users/jlongstaf/following{/other_user}","gists_url":"https://api.github.com/users/jlongstaf/gists{/gist_id}","starred_url":"https://api.github.com/users/jlongstaf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlongstaf/subscriptions","organizations_url":"https://api.github.com/users/jlongstaf/orgs","repos_url":"https://api.github.com/users/jlongstaf/repos","events_url":"https://api.github.com/users/jlongstaf/events{/privacy}","received_events_url":"https://api.github.com/users/jlongstaf/received_events","type":"User","site_admin":false},"body":"@richbrowne \r\n#### What issues does this address?\r\nFixes #66\r\n\r\n#### What's this change do?\r\nCleans up subnet objects when members and loadbalancer are deleted.\r\n\r\n#### Where should the reviewer start?\r\nStart with lbaas_builder.py and look at how subnethints are constructed. Also,\r\nclosely review network_helper.py changes.\r\n\r\n#### Any background context?\r\n","created_at":"2016-04-11T20:19:55Z","updated_at":"2016-04-11T21:43:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4f0fc273301b70a71c91b5c1b74990949533e002","assignee":{"login":"richbrowne","id":8740561,"avatar_url":"https://avatars.githubusercontent.com/u/8740561?v=3","gravatar_id":"","url":"https://api.github.com/users/richbrowne","html_url":"https://github.com/richbrowne","followers_url":"https://api.github.com/users/richbrowne/followers","following_url":"https://api.github.com/users/richbrowne/following{/other_user}","gists_url":"https://api.github.com/users/richbrowne/gists{/gist_id}","starred_url":"https://api.github.com/users/richbrowne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richbrowne/subscriptions","organizations_url":"https://api.github.com/users/richbrowne/orgs","repos_url":"https://api.github.com/users/richbrowne/repos","events_url":"https://api.github.com/users/richbrowne/events{/privacy}","received_events_url":"https://api.github.com/users/richbrowne/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/F5Networks/f5-openstack-agent/pulls/67/commits","review_comments_url":"https://api.github.com/repos/F5Networks/f5-openstack-agent/pulls/67/comments","review_comment_url":"https://api.github.com/repos/F5Networks/f5-openstack-agent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/F5Networks/f5-openstack-agent/issues/67/comments","statuses_url":"https://api.github.com/repos/F5Networks/f5-openstack-agent/statuses/7ae9ab11abad4a3629f2454a9c79d0eac90a9424","head":{"label":"jlongstaf:feature.cleanup","ref":"feature.cleanup","sha":"7ae9ab11abad4a3629f2454a9c79d0eac90a9424","user":{"login":"jlongstaf","id":14281800,"avatar_url":"https://avatars.githubusercontent.com/u/14281800?v=3","gravatar_id":"","url":"https://api.github.com/users/jlongstaf","html_url":"https://github.com/jlongstaf","followers_url":"https://api.github.com/users/jlongstaf/followers","following_url":"https://api.github.com/users/jlongstaf/following{/other_user}","gists_url":"https://api.github.com/users/jlongstaf/gists{/gist_id}","starred_url":"https://api.github.com/users/jlongstaf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlongstaf/subscriptions","organizations_url":"https://api.github.com/users/jlongstaf/orgs","repos_url":"https://api.github.com/users/jlongstaf/repos","events_url":"https://api.github.com/users/jlongstaf/events{/privacy}","received_events_url":"https://api.github.com/users/jlongstaf/received_events","type":"User","site_admin":false},"repo":{"id":51936634,"name":"f5-openstack-agent","full_name":"jlongstaf/f5-openstack-agent","owner":{"login":"jlongstaf","id":14281800,"avatar_url":"https://avatars.githubusercontent.com/u/14281800?v=3","gravatar_id":"","url":"https://api.github.com/users/jlongstaf","html_url":"https://github.com/jlongstaf","followers_url":"https://api.github.com/users/jlongstaf/followers","following_url":"https://api.github.com/users/jlongstaf/following{/other_user}","gists_url":"https://api.github.com/users/jlongstaf/gists{/gist_id}","starred_url":"https://api.github.com/users/jlongstaf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlongstaf/subscriptions","organizations_url":"https://api.github.com/users/jlongstaf/orgs","repos_url":"https://api.github.com/users/jlongstaf/repos","events_url":"https://api.github.com/users/jlongstaf/events{/privacy}","received_events_url":"https://api.github.com/users/jlongstaf/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jlongstaf/f5-openstack-agent","description":"The F5 OpenStack Agent allows you to deploy BIG-IP services in an OpenStack environment.","fork":true,"url":"https://api.github.com/repos/jlongstaf/f5-openstack-agent","forks_url":"https://api.github.com/repos/jlongstaf/f5-openstack-agent/forks","keys_url":"https://api.github.com/repos/jlongstaf/f5-openstack-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jlongstaf/f5-openstack-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jlongstaf/f5-openstack-agent/teams","hooks_url":"https://api.github.com/repos/jlongstaf/f5-openstack-agent/hooks","issue_events_url":"https://api.github.com/repos/jlongstaf/f5-openstack-agent/issues/events{/number}","events_url":"https://api.github.com/repos/jlongstaf/f5-openstack-agent/events","assignees_url":"https://api.github.com/repos/jlongstaf/f5-openstack-agent/assignees{/user}","branches_url":"https://api.github.com/repos/jlongstaf/f5-openstack-agent/branches{/branch}","tags_url":"https://api.github.com/repos/jlongstaf/f5-openstack-agent/tags","blobs_url":"https://api.github.com/repos/jlongstaf/f5-openstack-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jlongstaf/f5-openstack-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jlongstaf/f5-openstack-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/jlongstaf/f5-openstack-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jlongstaf/f5-openstack-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/jlongstaf/f5-openstack-agent/languages","stargazers_url":"https://api.github.com/repos/jlongstaf/f5-openstack-agent/stargazers","contributors_url":"https://api.github.com/repos/jlongstaf/f5-openstack-agent/contributors","subscribers_url":"https://api.github.com/repos/jlongstaf/f5-openstack-agent/subscribers","subscription_url":"https://api.github.com/repos/jlongstaf/f5-openstack-agent/subscription","commits_url":"https://api.github.com/repos/jlongstaf/f5-openstack-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/jlongstaf/f5-openstack-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/jlongstaf/f5-openstack-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/jlongstaf/f5-openstack-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/jlongstaf/f5-openstack-agent/contents/{+path}","compare_url":"https://api.github.com/repos/jlongstaf/f5-openstack-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jlongstaf/f5-openstack-agent/merges","archive_url":"https://api.github.com/repos/jlongstaf/f5-openstack-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jlongstaf/f5-openstack-agent/downloads","issues_url":"https://api.github.com/repos/jlongstaf/f5-openstack-agent/issues{/number}","pulls_url":"https://api.github.com/repos/jlongstaf/f5-openstack-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/jlongstaf/f5-openstack-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/jlongstaf/f5-openstack-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jlongstaf/f5-openstack-agent/labels{/name}","releases_url":"https://api.github.com/repos/jlongstaf/f5-openstack-agent/releases{/id}","deployments_url":"https://api.github.com/repos/jlongstaf/f5-openstack-agent/deployments","created_at":"2016-02-17T16:22:52Z","updated_at":"2016-03-21T19:40:20Z","pushed_at":"2016-04-11T20:17:07Z","git_url":"git://github.com/jlongstaf/f5-openstack-agent.git","ssh_url":"git@github.com:jlongstaf/f5-openstack-agent.git","clone_url":"https://github.com/jlongstaf/f5-openstack-agent.git","svn_url":"https://github.com/jlongstaf/f5-openstack-agent","homepage":"","size":421,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"F5Networks:master","ref":"master","sha":"8d0b95250f48d7ce887297a83ed0b0a2e54a63dc","user":{"login":"F5Networks","id":8935905,"avatar_url":"https://avatars.githubusercontent.com/u/8935905?v=3","gravatar_id":"","url":"https://api.github.com/users/F5Networks","html_url":"https://github.com/F5Networks","followers_url":"https://api.github.com/users/F5Networks/followers","following_url":"https://api.github.com/users/F5Networks/following{/other_user}","gists_url":"https://api.github.com/users/F5Networks/gists{/gist_id}","starred_url":"https://api.github.com/users/F5Networks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/F5Networks/subscriptions","organizations_url":"https://api.github.com/users/F5Networks/orgs","repos_url":"https://api.github.com/users/F5Networks/repos","events_url":"https://api.github.com/users/F5Networks/events{/privacy}","received_events_url":"https://api.github.com/users/F5Networks/received_events","type":"Organization","site_admin":false},"repo":{"id":44189799,"name":"f5-openstack-agent","full_name":"F5Networks/f5-openstack-agent","owner":{"login":"F5Networks","id":8935905,"avatar_url":"https://avatars.githubusercontent.com/u/8935905?v=3","gravatar_id":"","url":"https://api.github.com/users/F5Networks","html_url":"https://github.com/F5Networks","followers_url":"https://api.github.com/users/F5Networks/followers","following_url":"https://api.github.com/users/F5Networks/following{/other_user}","gists_url":"https://api.github.com/users/F5Networks/gists{/gist_id}","starred_url":"https://api.github.com/users/F5Networks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/F5Networks/subscriptions","organizations_url":"https://api.github.com/users/F5Networks/orgs","repos_url":"https://api.github.com/users/F5Networks/repos","events_url":"https://api.github.com/users/F5Networks/events{/privacy}","received_events_url":"https://api.github.com/users/F5Networks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/F5Networks/f5-openstack-agent","description":"The F5® OpenStack Agent allows you to deploy BIG-IP® services in an OpenStack environment.","fork":false,"url":"https://api.github.com/repos/F5Networks/f5-openstack-agent","forks_url":"https://api.github.com/repos/F5Networks/f5-openstack-agent/forks","keys_url":"https://api.github.com/repos/F5Networks/f5-openstack-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/F5Networks/f5-openstack-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/F5Networks/f5-openstack-agent/teams","hooks_url":"https://api.github.com/repos/F5Networks/f5-openstack-agent/hooks","issue_events_url":"https://api.github.com/repos/F5Networks/f5-openstack-agent/issues/events{/number}","events_url":"https://api.github.com/repos/F5Networks/f5-openstack-agent/events","assignees_url":"https://api.github.com/repos/F5Networks/f5-openstack-agent/assignees{/user}","branches_url":"https://api.github.com/repos/F5Networks/f5-openstack-agent/branches{/branch}","tags_url":"https://api.github.com/repos/F5Networks/f5-openstack-agent/tags","blobs_url":"https://api.github.com/repos/F5Networks/f5-openstack-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/F5Networks/f5-openstack-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/F5Networks/f5-openstack-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/F5Networks/f5-openstack-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/F5Networks/f5-openstack-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/F5Networks/f5-openstack-agent/languages","stargazers_url":"https://api.github.com/repos/F5Networks/f5-openstack-agent/stargazers","contributors_url":"https://api.github.com/repos/F5Networks/f5-openstack-agent/contributors","subscribers_url":"https://api.github.com/repos/F5Networks/f5-openstack-agent/subscribers","subscription_url":"https://api.github.com/repos/F5Networks/f5-openstack-agent/subscription","commits_url":"https://api.github.com/repos/F5Networks/f5-openstack-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/F5Networks/f5-openstack-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/F5Networks/f5-openstack-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/F5Networks/f5-openstack-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/F5Networks/f5-openstack-agent/contents/{+path}","compare_url":"https://api.github.com/repos/F5Networks/f5-openstack-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/F5Networks/f5-openstack-agent/merges","archive_url":"https://api.github.com/repos/F5Networks/f5-openstack-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/F5Networks/f5-openstack-agent/downloads","issues_url":"https://api.github.com/repos/F5Networks/f5-openstack-agent/issues{/number}","pulls_url":"https://api.github.com/repos/F5Networks/f5-openstack-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/F5Networks/f5-openstack-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/F5Networks/f5-openstack-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/F5Networks/f5-openstack-agent/labels{/name}","releases_url":"https://api.github.com/repos/F5Networks/f5-openstack-agent/releases{/id}","deployments_url":"https://api.github.com/repos/F5Networks/f5-openstack-agent/deployments","created_at":"2015-10-13T16:28:50Z","updated_at":"2016-04-01T22:11:45Z","pushed_at":"2016-04-11T20:19:55Z","git_url":"git://github.com/F5Networks/f5-openstack-agent.git","ssh_url":"git@github.com:F5Networks/f5-openstack-agent.git","clone_url":"https://github.com/F5Networks/f5-openstack-agent.git","svn_url":"https://github.com/F5Networks/f5-openstack-agent","homepage":"http://f5-openstack-lbaasv2.rtfd.org/en/","size":445,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":6,"forks":6,"open_issues":6,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/F5Networks/f5-openstack-agent/pulls/67"},"html":{"href":"https://github.com/F5Networks/f5-openstack-agent/pull/67"},"issue":{"href":"https://api.github.com/repos/F5Networks/f5-openstack-agent/issues/67"},"comments":{"href":"https://api.github.com/repos/F5Networks/f5-openstack-agent/issues/67/comments"},"review_comments":{"href":"https://api.github.com/repos/F5Networks/f5-openstack-agent/pulls/67/comments"},"review_comment":{"href":"https://api.github.com/repos/F5Networks/f5-openstack-agent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/F5Networks/f5-openstack-agent/pulls/67/commits"},"statuses":{"href":"https://api.github.com/repos/F5Networks/f5-openstack-agent/statuses/7ae9ab11abad4a3629f2454a9c79d0eac90a9424"}}}}