{"action":"created","issue":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/4553","labels_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/4553/labels{/name}","comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/4553/comments","events_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/4553/events","html_url":"https://github.com/RIOT-OS/RIOT/pull/4553","id":124000331,"number":4553,"title":"cpu: remove superfluous SystemCoreClockUpdate()","user":{"login":"DipSwitch","id":476484,"avatar_url":"https://avatars.githubusercontent.com/u/476484?v=3","gravatar_id":"","url":"https://api.github.com/users/DipSwitch","html_url":"https://github.com/DipSwitch","followers_url":"https://api.github.com/users/DipSwitch/followers","following_url":"https://api.github.com/users/DipSwitch/following{/other_user}","gists_url":"https://api.github.com/users/DipSwitch/gists{/gist_id}","starred_url":"https://api.github.com/users/DipSwitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DipSwitch/subscriptions","organizations_url":"https://api.github.com/users/DipSwitch/orgs","repos_url":"https://api.github.com/users/DipSwitch/repos","events_url":"https://api.github.com/users/DipSwitch/events{/privacy}","received_events_url":"https://api.github.com/users/DipSwitch/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/RIOT-OS/RIOT/labels/cleanup","name":"cleanup","color":"FF7c7c"},{"url":"https://api.github.com/repos/RIOT-OS/RIOT/labels/enhancement","name":"enhancement","color":"f17070"},{"url":"https://api.github.com/repos/RIOT-OS/RIOT/labels/Request%20for%20Comments","name":"Request for Comments","color":"23F823"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-12-27T23:10:16Z","updated_at":"2016-01-06T18:42:03Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/4553","html_url":"https://github.com/RIOT-OS/RIOT/pull/4553","diff_url":"https://github.com/RIOT-OS/RIOT/pull/4553.diff","patch_url":"https://github.com/RIOT-OS/RIOT/pull/4553.patch"},"body":"The functions calculated a lot but the values they assigned where never used.\r\n\r\nI propose to make an API call to request the configured clock speeds instead of always calculating it. Or include it in a define of `DEVHELP` and print it to the terminal. This to safe some space and keep the code cleaner. :)"},"comment":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/comments/169415762","html_url":"https://github.com/RIOT-OS/RIOT/pull/4553#issuecomment-169415762","issue_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/4553","id":169415762,"user":{"login":"haukepetersen","id":620834,"avatar_url":"https://avatars.githubusercontent.com/u/620834?v=3","gravatar_id":"","url":"https://api.github.com/users/haukepetersen","html_url":"https://github.com/haukepetersen","followers_url":"https://api.github.com/users/haukepetersen/followers","following_url":"https://api.github.com/users/haukepetersen/following{/other_user}","gists_url":"https://api.github.com/users/haukepetersen/gists{/gist_id}","starred_url":"https://api.github.com/users/haukepetersen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haukepetersen/subscriptions","organizations_url":"https://api.github.com/users/haukepetersen/orgs","repos_url":"https://api.github.com/users/haukepetersen/repos","events_url":"https://api.github.com/users/haukepetersen/events{/privacy}","received_events_url":"https://api.github.com/users/haukepetersen/received_events","type":"User","site_admin":false},"created_at":"2016-01-06T18:42:03Z","updated_at":"2016-01-06T18:42:03Z","body":"nice one! The `SystemCoreClock` variable and the `SystemCoreClockUpdate` function came actually from the ARM CMSIS files, but we dropped them already for almost all Cortex boards (as we wrote a slimmer version in `cpu_init()`). So removing these also from the rest of the boards make much sense! \r\n\r\n+1! for this change, though no ressources to review in detail until the release is out..."}}