{"action":"created","comment":{"url":"https://api.github.com/repos/BlueBrain/Livre/pulls/comments/76999937","id":76999937,"diff_hunk":"@@ -430,9 +429,13 @@ struct RayCastRenderer::Impl\n \n     void onFrameRender( const NodeIds& bricks )\n     {\n+        createAndFillVertexBuffer( bricks );\n         size_t index = 0;\n         for( const NodeId& brick: bricks )\n             renderBrick( brick, index++ );\n+\n+        glDeleteBuffers( 1, &_posVBO );\n+        glFlush();","path":"livre/eq/render/RayCastRenderer.cpp","position":18,"original_position":18,"commit_id":"f020c745cf865f49bd22534f9417c5d5c5738151","original_commit_id":"f020c745cf865f49bd22534f9417c5d5c5738151","user":{"login":"eile","id":354947,"avatar_url":"https://avatars.githubusercontent.com/u/354947?v=3","gravatar_id":"","url":"https://api.github.com/users/eile","html_url":"https://github.com/eile","followers_url":"https://api.github.com/users/eile/followers","following_url":"https://api.github.com/users/eile/following{/other_user}","gists_url":"https://api.github.com/users/eile/gists{/gist_id}","starred_url":"https://api.github.com/users/eile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eile/subscriptions","organizations_url":"https://api.github.com/users/eile/orgs","repos_url":"https://api.github.com/users/eile/repos","events_url":"https://api.github.com/users/eile/events{/privacy}","received_events_url":"https://api.github.com/users/eile/received_events","type":"User","site_admin":false},"body":"A lonely function returning (or worse creating and not returning) resources which have to be freed is always bad design. Sure the delete is only a one-liner, so?\r\n\r\nIn the end I'm fine if at least the fbo is returned to the caller and not stored as a member.","created_at":"2016-08-31T14:39:52Z","updated_at":"2016-08-31T14:39:52Z","html_url":"https://github.com/BlueBrain/Livre/pull/331#discussion_r76999937","pull_request_url":"https://api.github.com/repos/BlueBrain/Livre/pulls/331","_links":{"self":{"href":"https://api.github.com/repos/BlueBrain/Livre/pulls/comments/76999937"},"html":{"href":"https://github.com/BlueBrain/Livre/pull/331#discussion_r76999937"},"pull_request":{"href":"https://api.github.com/repos/BlueBrain/Livre/pulls/331"}}},"pull_request":{"url":"https://api.github.com/repos/BlueBrain/Livre/pulls/331","id":83444334,"html_url":"https://github.com/BlueBrain/Livre/pull/331","diff_url":"https://github.com/BlueBrain/Livre/pull/331.diff","patch_url":"https://github.com/BlueBrain/Livre/pull/331.patch","issue_url":"https://api.github.com/repos/BlueBrain/Livre/issues/331","number":331,"state":"open","locked":false,"title":"Livre now support offline rendering of infinite size volume","user":{"login":"chevtche","id":10452408,"avatar_url":"https://avatars.githubusercontent.com/u/10452408?v=3","gravatar_id":"","url":"https://api.github.com/users/chevtche","html_url":"https://github.com/chevtche","followers_url":"https://api.github.com/users/chevtche/followers","following_url":"https://api.github.com/users/chevtche/following{/other_user}","gists_url":"https://api.github.com/users/chevtche/gists{/gist_id}","starred_url":"https://api.github.com/users/chevtche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chevtche/subscriptions","organizations_url":"https://api.github.com/users/chevtche/orgs","repos_url":"https://api.github.com/users/chevtche/repos","events_url":"https://api.github.com/users/chevtche/events{/privacy}","received_events_url":"https://api.github.com/users/chevtche/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-08-31T12:38:01Z","updated_at":"2016-08-31T14:39:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"673c930ec6fdb87184070479de3fcfdd140ebd7c","assignee":{"login":"bilgili","id":1157568,"avatar_url":"https://avatars.githubusercontent.com/u/1157568?v=3","gravatar_id":"","url":"https://api.github.com/users/bilgili","html_url":"https://github.com/bilgili","followers_url":"https://api.github.com/users/bilgili/followers","following_url":"https://api.github.com/users/bilgili/following{/other_user}","gists_url":"https://api.github.com/users/bilgili/gists{/gist_id}","starred_url":"https://api.github.com/users/bilgili/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bilgili/subscriptions","organizations_url":"https://api.github.com/users/bilgili/orgs","repos_url":"https://api.github.com/users/bilgili/repos","events_url":"https://api.github.com/users/bilgili/events{/privacy}","received_events_url":"https://api.github.com/users/bilgili/received_events","type":"User","site_admin":false},"assignees":[{"login":"bilgili","id":1157568,"avatar_url":"https://avatars.githubusercontent.com/u/1157568?v=3","gravatar_id":"","url":"https://api.github.com/users/bilgili","html_url":"https://github.com/bilgili","followers_url":"https://api.github.com/users/bilgili/followers","following_url":"https://api.github.com/users/bilgili/following{/other_user}","gists_url":"https://api.github.com/users/bilgili/gists{/gist_id}","starred_url":"https://api.github.com/users/bilgili/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bilgili/subscriptions","organizations_url":"https://api.github.com/users/bilgili/orgs","repos_url":"https://api.github.com/users/bilgili/repos","events_url":"https://api.github.com/users/bilgili/events{/privacy}","received_events_url":"https://api.github.com/users/bilgili/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/BlueBrain/Livre/pulls/331/commits","review_comments_url":"https://api.github.com/repos/BlueBrain/Livre/pulls/331/comments","review_comment_url":"https://api.github.com/repos/BlueBrain/Livre/pulls/comments{/number}","comments_url":"https://api.github.com/repos/BlueBrain/Livre/issues/331/comments","statuses_url":"https://api.github.com/repos/BlueBrain/Livre/statuses/f020c745cf865f49bd22534f9417c5d5c5738151","head":{"label":"chevtche:master","ref":"master","sha":"f020c745cf865f49bd22534f9417c5d5c5738151","user":{"login":"chevtche","id":10452408,"avatar_url":"https://avatars.githubusercontent.com/u/10452408?v=3","gravatar_id":"","url":"https://api.github.com/users/chevtche","html_url":"https://github.com/chevtche","followers_url":"https://api.github.com/users/chevtche/followers","following_url":"https://api.github.com/users/chevtche/following{/other_user}","gists_url":"https://api.github.com/users/chevtche/gists{/gist_id}","starred_url":"https://api.github.com/users/chevtche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chevtche/subscriptions","organizations_url":"https://api.github.com/users/chevtche/orgs","repos_url":"https://api.github.com/users/chevtche/repos","events_url":"https://api.github.com/users/chevtche/events{/privacy}","received_events_url":"https://api.github.com/users/chevtche/received_events","type":"User","site_admin":false},"repo":{"id":34253801,"name":"Livre","full_name":"chevtche/Livre","owner":{"login":"chevtche","id":10452408,"avatar_url":"https://avatars.githubusercontent.com/u/10452408?v=3","gravatar_id":"","url":"https://api.github.com/users/chevtche","html_url":"https://github.com/chevtche","followers_url":"https://api.github.com/users/chevtche/followers","following_url":"https://api.github.com/users/chevtche/following{/other_user}","gists_url":"https://api.github.com/users/chevtche/gists{/gist_id}","starred_url":"https://api.github.com/users/chevtche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chevtche/subscriptions","organizations_url":"https://api.github.com/users/chevtche/orgs","repos_url":"https://api.github.com/users/chevtche/repos","events_url":"https://api.github.com/users/chevtche/events{/privacy}","received_events_url":"https://api.github.com/users/chevtche/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chevtche/Livre","description":"Largescale Interactive Volume Rendering Engine","fork":true,"url":"https://api.github.com/repos/chevtche/Livre","forks_url":"https://api.github.com/repos/chevtche/Livre/forks","keys_url":"https://api.github.com/repos/chevtche/Livre/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chevtche/Livre/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chevtche/Livre/teams","hooks_url":"https://api.github.com/repos/chevtche/Livre/hooks","issue_events_url":"https://api.github.com/repos/chevtche/Livre/issues/events{/number}","events_url":"https://api.github.com/repos/chevtche/Livre/events","assignees_url":"https://api.github.com/repos/chevtche/Livre/assignees{/user}","branches_url":"https://api.github.com/repos/chevtche/Livre/branches{/branch}","tags_url":"https://api.github.com/repos/chevtche/Livre/tags","blobs_url":"https://api.github.com/repos/chevtche/Livre/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chevtche/Livre/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chevtche/Livre/git/refs{/sha}","trees_url":"https://api.github.com/repos/chevtche/Livre/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chevtche/Livre/statuses/{sha}","languages_url":"https://api.github.com/repos/chevtche/Livre/languages","stargazers_url":"https://api.github.com/repos/chevtche/Livre/stargazers","contributors_url":"https://api.github.com/repos/chevtche/Livre/contributors","subscribers_url":"https://api.github.com/repos/chevtche/Livre/subscribers","subscription_url":"https://api.github.com/repos/chevtche/Livre/subscription","commits_url":"https://api.github.com/repos/chevtche/Livre/commits{/sha}","git_commits_url":"https://api.github.com/repos/chevtche/Livre/git/commits{/sha}","comments_url":"https://api.github.com/repos/chevtche/Livre/comments{/number}","issue_comment_url":"https://api.github.com/repos/chevtche/Livre/issues/comments{/number}","contents_url":"https://api.github.com/repos/chevtche/Livre/contents/{+path}","compare_url":"https://api.github.com/repos/chevtche/Livre/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chevtche/Livre/merges","archive_url":"https://api.github.com/repos/chevtche/Livre/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chevtche/Livre/downloads","issues_url":"https://api.github.com/repos/chevtche/Livre/issues{/number}","pulls_url":"https://api.github.com/repos/chevtche/Livre/pulls{/number}","milestones_url":"https://api.github.com/repos/chevtche/Livre/milestones{/number}","notifications_url":"https://api.github.com/repos/chevtche/Livre/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chevtche/Livre/labels{/name}","releases_url":"https://api.github.com/repos/chevtche/Livre/releases{/id}","deployments_url":"https://api.github.com/repos/chevtche/Livre/deployments","created_at":"2015-04-20T10:22:23Z","updated_at":"2016-03-22T16:31:40Z","pushed_at":"2016-08-31T12:36:50Z","git_url":"git://github.com/chevtche/Livre.git","ssh_url":"git@github.com:chevtche/Livre.git","clone_url":"https://github.com/chevtche/Livre.git","svn_url":"https://github.com/chevtche/Livre","homepage":"https://bluebrain.github.io","size":8596,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"BlueBrain:master","ref":"master","sha":"50e78868e5c238e58d6e51711baf101a7634bec2","user":{"login":"BlueBrain","id":1479142,"avatar_url":"https://avatars.githubusercontent.com/u/1479142?v=3","gravatar_id":"","url":"https://api.github.com/users/BlueBrain","html_url":"https://github.com/BlueBrain","followers_url":"https://api.github.com/users/BlueBrain/followers","following_url":"https://api.github.com/users/BlueBrain/following{/other_user}","gists_url":"https://api.github.com/users/BlueBrain/gists{/gist_id}","starred_url":"https://api.github.com/users/BlueBrain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BlueBrain/subscriptions","organizations_url":"https://api.github.com/users/BlueBrain/orgs","repos_url":"https://api.github.com/users/BlueBrain/repos","events_url":"https://api.github.com/users/BlueBrain/events{/privacy}","received_events_url":"https://api.github.com/users/BlueBrain/received_events","type":"Organization","site_admin":false},"repo":{"id":10625435,"name":"Livre","full_name":"BlueBrain/Livre","owner":{"login":"BlueBrain","id":1479142,"avatar_url":"https://avatars.githubusercontent.com/u/1479142?v=3","gravatar_id":"","url":"https://api.github.com/users/BlueBrain","html_url":"https://github.com/BlueBrain","followers_url":"https://api.github.com/users/BlueBrain/followers","following_url":"https://api.github.com/users/BlueBrain/following{/other_user}","gists_url":"https://api.github.com/users/BlueBrain/gists{/gist_id}","starred_url":"https://api.github.com/users/BlueBrain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BlueBrain/subscriptions","organizations_url":"https://api.github.com/users/BlueBrain/orgs","repos_url":"https://api.github.com/users/BlueBrain/repos","events_url":"https://api.github.com/users/BlueBrain/events{/privacy}","received_events_url":"https://api.github.com/users/BlueBrain/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/BlueBrain/Livre","description":"Large-scale Interactive Volume Rendering Engine","fork":false,"url":"https://api.github.com/repos/BlueBrain/Livre","forks_url":"https://api.github.com/repos/BlueBrain/Livre/forks","keys_url":"https://api.github.com/repos/BlueBrain/Livre/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BlueBrain/Livre/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BlueBrain/Livre/teams","hooks_url":"https://api.github.com/repos/BlueBrain/Livre/hooks","issue_events_url":"https://api.github.com/repos/BlueBrain/Livre/issues/events{/number}","events_url":"https://api.github.com/repos/BlueBrain/Livre/events","assignees_url":"https://api.github.com/repos/BlueBrain/Livre/assignees{/user}","branches_url":"https://api.github.com/repos/BlueBrain/Livre/branches{/branch}","tags_url":"https://api.github.com/repos/BlueBrain/Livre/tags","blobs_url":"https://api.github.com/repos/BlueBrain/Livre/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BlueBrain/Livre/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BlueBrain/Livre/git/refs{/sha}","trees_url":"https://api.github.com/repos/BlueBrain/Livre/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BlueBrain/Livre/statuses/{sha}","languages_url":"https://api.github.com/repos/BlueBrain/Livre/languages","stargazers_url":"https://api.github.com/repos/BlueBrain/Livre/stargazers","contributors_url":"https://api.github.com/repos/BlueBrain/Livre/contributors","subscribers_url":"https://api.github.com/repos/BlueBrain/Livre/subscribers","subscription_url":"https://api.github.com/repos/BlueBrain/Livre/subscription","commits_url":"https://api.github.com/repos/BlueBrain/Livre/commits{/sha}","git_commits_url":"https://api.github.com/repos/BlueBrain/Livre/git/commits{/sha}","comments_url":"https://api.github.com/repos/BlueBrain/Livre/comments{/number}","issue_comment_url":"https://api.github.com/repos/BlueBrain/Livre/issues/comments{/number}","contents_url":"https://api.github.com/repos/BlueBrain/Livre/contents/{+path}","compare_url":"https://api.github.com/repos/BlueBrain/Livre/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BlueBrain/Livre/merges","archive_url":"https://api.github.com/repos/BlueBrain/Livre/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BlueBrain/Livre/downloads","issues_url":"https://api.github.com/repos/BlueBrain/Livre/issues{/number}","pulls_url":"https://api.github.com/repos/BlueBrain/Livre/pulls{/number}","milestones_url":"https://api.github.com/repos/BlueBrain/Livre/milestones{/number}","notifications_url":"https://api.github.com/repos/BlueBrain/Livre/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BlueBrain/Livre/labels{/name}","releases_url":"https://api.github.com/repos/BlueBrain/Livre/releases{/id}","deployments_url":"https://api.github.com/repos/BlueBrain/Livre/deployments","created_at":"2013-06-11T16:13:56Z","updated_at":"2016-07-27T08:30:40Z","pushed_at":"2016-08-31T12:38:01Z","git_url":"git://github.com/BlueBrain/Livre.git","ssh_url":"git@github.com:BlueBrain/Livre.git","clone_url":"https://github.com/BlueBrain/Livre.git","svn_url":"https://github.com/BlueBrain/Livre","homepage":"https://bluebrain.github.io","size":8809,"stargazers_count":11,"watchers_count":11,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":23,"forks":14,"open_issues":23,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/BlueBrain/Livre/pulls/331"},"html":{"href":"https://github.com/BlueBrain/Livre/pull/331"},"issue":{"href":"https://api.github.com/repos/BlueBrain/Livre/issues/331"},"comments":{"href":"https://api.github.com/repos/BlueBrain/Livre/issues/331/comments"},"review_comments":{"href":"https://api.github.com/repos/BlueBrain/Livre/pulls/331/comments"},"review_comment":{"href":"https://api.github.com/repos/BlueBrain/Livre/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/BlueBrain/Livre/pulls/331/commits"},"statuses":{"href":"https://api.github.com/repos/BlueBrain/Livre/statuses/f020c745cf865f49bd22534f9417c5d5c5738151"}}}}
{"actor":{"display_login":"eile"}}