{"action":"created","issue":{"url":"https://api.github.com/repos/emqtt/qmqtt/issues/76","repository_url":"https://api.github.com/repos/emqtt/qmqtt","labels_url":"https://api.github.com/repos/emqtt/qmqtt/issues/76/labels{/name}","comments_url":"https://api.github.com/repos/emqtt/qmqtt/issues/76/comments","events_url":"https://api.github.com/repos/emqtt/qmqtt/issues/76/events","html_url":"https://github.com/emqtt/qmqtt/pull/76","id":173024142,"number":76,"title":"Client now emits connected signal after ConnAck has been received.","user":{"login":"ejvr","id":18499109,"avatar_url":"https://avatars.githubusercontent.com/u/18499109?v=3","gravatar_id":"","url":"https://api.github.com/users/ejvr","html_url":"https://github.com/ejvr","followers_url":"https://api.github.com/users/ejvr/followers","following_url":"https://api.github.com/users/ejvr/following{/other_user}","gists_url":"https://api.github.com/users/ejvr/gists{/gist_id}","starred_url":"https://api.github.com/users/ejvr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ejvr/subscriptions","organizations_url":"https://api.github.com/users/ejvr/orgs","repos_url":"https://api.github.com/users/ejvr/repos","events_url":"https://api.github.com/users/ejvr/events{/privacy}","received_events_url":"https://api.github.com/users/ejvr/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-08-24T18:26:11Z","updated_at":"2016-08-25T10:27:36Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/emqtt/qmqtt/pulls/76","html_url":"https://github.com/emqtt/qmqtt/pull/76","diff_url":"https://github.com/emqtt/qmqtt/pull/76.diff","patch_url":"https://github.com/emqtt/qmqtt/pull/76.patch"},"body":"Without this patch, a race condition exists between client and broker. If the client published a message or subscribed when Client::connected was emitted, the request could arrive before the broker had sent ConnAck (because Client::connected was emitted when the TCP connection had been established and the connection request was sent). This could cause the broker to reject/ignore the request.\r\n"},"comment":{"url":"https://api.github.com/repos/emqtt/qmqtt/issues/comments/242343108","html_url":"https://github.com/emqtt/qmqtt/pull/76#issuecomment-242343108","issue_url":"https://api.github.com/repos/emqtt/qmqtt/issues/76","id":242343108,"user":{"login":"mwallnoefer","id":7541399,"avatar_url":"https://avatars.githubusercontent.com/u/7541399?v=3","gravatar_id":"","url":"https://api.github.com/users/mwallnoefer","html_url":"https://github.com/mwallnoefer","followers_url":"https://api.github.com/users/mwallnoefer/followers","following_url":"https://api.github.com/users/mwallnoefer/following{/other_user}","gists_url":"https://api.github.com/users/mwallnoefer/gists{/gist_id}","starred_url":"https://api.github.com/users/mwallnoefer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwallnoefer/subscriptions","organizations_url":"https://api.github.com/users/mwallnoefer/orgs","repos_url":"https://api.github.com/users/mwallnoefer/repos","events_url":"https://api.github.com/users/mwallnoefer/events{/privacy}","received_events_url":"https://api.github.com/users/mwallnoefer/received_events","type":"User","site_admin":false},"created_at":"2016-08-25T10:27:36Z","updated_at":"2016-08-25T10:27:36Z","body":"You need to repush your own \"ejvr/qmqtt\" branch without the SSL commit, so we can reuse the open pull request.\r\nOtherwise we need to do a cherry-pick, which is more work."}}
{"actor":{"display_login":"mwallnoefer"}}