{"action":"opened","number":1850,"pull_request":{"url":"https://api.github.com/repos/KSP-KOS/KOS/pulls/1850","id":90264783,"html_url":"https://github.com/KSP-KOS/KOS/pull/1850","diff_url":"https://github.com/KSP-KOS/KOS/pull/1850.diff","patch_url":"https://github.com/KSP-KOS/KOS/pull/1850.patch","issue_url":"https://api.github.com/repos/KSP-KOS/KOS/issues/1850","number":1850,"state":"open","locked":false,"title":"CommNet support for KSP 1.2.0","user":{"login":"hvacengi","id":2975036,"avatar_url":"https://avatars.githubusercontent.com/u/2975036?v=3","gravatar_id":"","url":"https://api.github.com/users/hvacengi","html_url":"https://github.com/hvacengi","followers_url":"https://api.github.com/users/hvacengi/followers","following_url":"https://api.github.com/users/hvacengi/following{/other_user}","gists_url":"https://api.github.com/users/hvacengi/gists{/gist_id}","starred_url":"https://api.github.com/users/hvacengi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hvacengi/subscriptions","organizations_url":"https://api.github.com/users/hvacengi/orgs","repos_url":"https://api.github.com/users/hvacengi/repos","events_url":"https://api.github.com/users/hvacengi/events{/privacy}","received_events_url":"https://api.github.com/users/hvacengi/received_events","type":"User","site_admin":false},"body":"An overhaul of the connectivity system to accommodate more abstraction and support CommNet along with RemoteTech for communication enforcement.\r\n\r\nI suggest that any reviewers read through the commit messages as I explained pretty thoroughly what I was changing and why.\r\n\r\nEssentially there is now a `ConnectivityManager` class which exposes static methods to access instances of `IConnectivityManager` which enforce connection.  All other changes were made to centralize all of this logic so that it didn't need to be spread across many classes, nor did it need to be tied to `SharedObjects`.\r\n\r\nA few important notes:\r\n* I included a hack to make things work with \"Require Signal for Control\" enabled with CommNet.  I have not done substatial testing to make sure that this doesn't break control lockout somewhere else in KSP.  In fact, if we would like we can move this logic into it's own \"addon\" dll to make it easy to opt in/out of.  Or we could remove the hack and just say that kOS doesn't support that setting.\r\n* At least one of the two ships you are testing communication between must have a relay antenna.  This is a limitation on the part of KSP, where they do not calculate connections between unloaded vessels that have no relay.  I ran into some fringe cases where it works one direction but not the other, so I set up this logic to try reversing the connection if no connection is shown initially.","created_at":"2016-10-20T19:24:55Z","updated_at":"2016-10-20T19:24:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/KSP-KOS/KOS/pulls/1850/commits","review_comments_url":"https://api.github.com/repos/KSP-KOS/KOS/pulls/1850/comments","review_comment_url":"https://api.github.com/repos/KSP-KOS/KOS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/KSP-KOS/KOS/issues/1850/comments","statuses_url":"https://api.github.com/repos/KSP-KOS/KOS/statuses/10591abf72d87540570f2f0c2298df5f5590958a","head":{"label":"hvacengi:issue-1836-commnet","ref":"issue-1836-commnet","sha":"10591abf72d87540570f2f0c2298df5f5590958a","user":{"login":"hvacengi","id":2975036,"avatar_url":"https://avatars.githubusercontent.com/u/2975036?v=3","gravatar_id":"","url":"https://api.github.com/users/hvacengi","html_url":"https://github.com/hvacengi","followers_url":"https://api.github.com/users/hvacengi/followers","following_url":"https://api.github.com/users/hvacengi/following{/other_user}","gists_url":"https://api.github.com/users/hvacengi/gists{/gist_id}","starred_url":"https://api.github.com/users/hvacengi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hvacengi/subscriptions","organizations_url":"https://api.github.com/users/hvacengi/orgs","repos_url":"https://api.github.com/users/hvacengi/repos","events_url":"https://api.github.com/users/hvacengi/events{/privacy}","received_events_url":"https://api.github.com/users/hvacengi/received_events","type":"User","site_admin":false},"repo":{"id":26549053,"name":"KOS","full_name":"hvacengi/KOS","owner":{"login":"hvacengi","id":2975036,"avatar_url":"https://avatars.githubusercontent.com/u/2975036?v=3","gravatar_id":"","url":"https://api.github.com/users/hvacengi","html_url":"https://github.com/hvacengi","followers_url":"https://api.github.com/users/hvacengi/followers","following_url":"https://api.github.com/users/hvacengi/following{/other_user}","gists_url":"https://api.github.com/users/hvacengi/gists{/gist_id}","starred_url":"https://api.github.com/users/hvacengi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hvacengi/subscriptions","organizations_url":"https://api.github.com/users/hvacengi/orgs","repos_url":"https://api.github.com/users/hvacengi/repos","events_url":"https://api.github.com/users/hvacengi/events{/privacy}","received_events_url":"https://api.github.com/users/hvacengi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hvacengi/KOS","description":"Fully programmable autopilot mod for KSP. Originally By Nivekk","fork":true,"url":"https://api.github.com/repos/hvacengi/KOS","forks_url":"https://api.github.com/repos/hvacengi/KOS/forks","keys_url":"https://api.github.com/repos/hvacengi/KOS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hvacengi/KOS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hvacengi/KOS/teams","hooks_url":"https://api.github.com/repos/hvacengi/KOS/hooks","issue_events_url":"https://api.github.com/repos/hvacengi/KOS/issues/events{/number}","events_url":"https://api.github.com/repos/hvacengi/KOS/events","assignees_url":"https://api.github.com/repos/hvacengi/KOS/assignees{/user}","branches_url":"https://api.github.com/repos/hvacengi/KOS/branches{/branch}","tags_url":"https://api.github.com/repos/hvacengi/KOS/tags","blobs_url":"https://api.github.com/repos/hvacengi/KOS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hvacengi/KOS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hvacengi/KOS/git/refs{/sha}","trees_url":"https://api.github.com/repos/hvacengi/KOS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hvacengi/KOS/statuses/{sha}","languages_url":"https://api.github.com/repos/hvacengi/KOS/languages","stargazers_url":"https://api.github.com/repos/hvacengi/KOS/stargazers","contributors_url":"https://api.github.com/repos/hvacengi/KOS/contributors","subscribers_url":"https://api.github.com/repos/hvacengi/KOS/subscribers","subscription_url":"https://api.github.com/repos/hvacengi/KOS/subscription","commits_url":"https://api.github.com/repos/hvacengi/KOS/commits{/sha}","git_commits_url":"https://api.github.com/repos/hvacengi/KOS/git/commits{/sha}","comments_url":"https://api.github.com/repos/hvacengi/KOS/comments{/number}","issue_comment_url":"https://api.github.com/repos/hvacengi/KOS/issues/comments{/number}","contents_url":"https://api.github.com/repos/hvacengi/KOS/contents/{+path}","compare_url":"https://api.github.com/repos/hvacengi/KOS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hvacengi/KOS/merges","archive_url":"https://api.github.com/repos/hvacengi/KOS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hvacengi/KOS/downloads","issues_url":"https://api.github.com/repos/hvacengi/KOS/issues{/number}","pulls_url":"https://api.github.com/repos/hvacengi/KOS/pulls{/number}","milestones_url":"https://api.github.com/repos/hvacengi/KOS/milestones{/number}","notifications_url":"https://api.github.com/repos/hvacengi/KOS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hvacengi/KOS/labels{/name}","releases_url":"https://api.github.com/repos/hvacengi/KOS/releases{/id}","deployments_url":"https://api.github.com/repos/hvacengi/KOS/deployments","created_at":"2014-11-12T18:06:19Z","updated_at":"2016-01-13T14:20:31Z","pushed_at":"2016-10-20T19:15:35Z","git_url":"git://github.com/hvacengi/KOS.git","ssh_url":"git@github.com:hvacengi/KOS.git","clone_url":"https://github.com/hvacengi/KOS.git","svn_url":"https://github.com/hvacengi/KOS","homepage":null,"size":103563,"stargazers_count":1,"watchers_count":1,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"develop"}},"base":{"label":"KSP-KOS:develop","ref":"develop","sha":"4696559504b4b002742f3c162c8a1651a416bba7","user":{"login":"KSP-KOS","id":6767371,"avatar_url":"https://avatars.githubusercontent.com/u/6767371?v=3","gravatar_id":"","url":"https://api.github.com/users/KSP-KOS","html_url":"https://github.com/KSP-KOS","followers_url":"https://api.github.com/users/KSP-KOS/followers","following_url":"https://api.github.com/users/KSP-KOS/following{/other_user}","gists_url":"https://api.github.com/users/KSP-KOS/gists{/gist_id}","starred_url":"https://api.github.com/users/KSP-KOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KSP-KOS/subscriptions","organizations_url":"https://api.github.com/users/KSP-KOS/orgs","repos_url":"https://api.github.com/users/KSP-KOS/repos","events_url":"https://api.github.com/users/KSP-KOS/events{/privacy}","received_events_url":"https://api.github.com/users/KSP-KOS/received_events","type":"Organization","site_admin":false},"repo":{"id":17217530,"name":"KOS","full_name":"KSP-KOS/KOS","owner":{"login":"KSP-KOS","id":6767371,"avatar_url":"https://avatars.githubusercontent.com/u/6767371?v=3","gravatar_id":"","url":"https://api.github.com/users/KSP-KOS","html_url":"https://github.com/KSP-KOS","followers_url":"https://api.github.com/users/KSP-KOS/followers","following_url":"https://api.github.com/users/KSP-KOS/following{/other_user}","gists_url":"https://api.github.com/users/KSP-KOS/gists{/gist_id}","starred_url":"https://api.github.com/users/KSP-KOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KSP-KOS/subscriptions","organizations_url":"https://api.github.com/users/KSP-KOS/orgs","repos_url":"https://api.github.com/users/KSP-KOS/repos","events_url":"https://api.github.com/users/KSP-KOS/events{/privacy}","received_events_url":"https://api.github.com/users/KSP-KOS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/KSP-KOS/KOS","description":"Fully programmable autopilot mod for KSP. Originally By Nivekk","fork":false,"url":"https://api.github.com/repos/KSP-KOS/KOS","forks_url":"https://api.github.com/repos/KSP-KOS/KOS/forks","keys_url":"https://api.github.com/repos/KSP-KOS/KOS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KSP-KOS/KOS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KSP-KOS/KOS/teams","hooks_url":"https://api.github.com/repos/KSP-KOS/KOS/hooks","issue_events_url":"https://api.github.com/repos/KSP-KOS/KOS/issues/events{/number}","events_url":"https://api.github.com/repos/KSP-KOS/KOS/events","assignees_url":"https://api.github.com/repos/KSP-KOS/KOS/assignees{/user}","branches_url":"https://api.github.com/repos/KSP-KOS/KOS/branches{/branch}","tags_url":"https://api.github.com/repos/KSP-KOS/KOS/tags","blobs_url":"https://api.github.com/repos/KSP-KOS/KOS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KSP-KOS/KOS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KSP-KOS/KOS/git/refs{/sha}","trees_url":"https://api.github.com/repos/KSP-KOS/KOS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KSP-KOS/KOS/statuses/{sha}","languages_url":"https://api.github.com/repos/KSP-KOS/KOS/languages","stargazers_url":"https://api.github.com/repos/KSP-KOS/KOS/stargazers","contributors_url":"https://api.github.com/repos/KSP-KOS/KOS/contributors","subscribers_url":"https://api.github.com/repos/KSP-KOS/KOS/subscribers","subscription_url":"https://api.github.com/repos/KSP-KOS/KOS/subscription","commits_url":"https://api.github.com/repos/KSP-KOS/KOS/commits{/sha}","git_commits_url":"https://api.github.com/repos/KSP-KOS/KOS/git/commits{/sha}","comments_url":"https://api.github.com/repos/KSP-KOS/KOS/comments{/number}","issue_comment_url":"https://api.github.com/repos/KSP-KOS/KOS/issues/comments{/number}","contents_url":"https://api.github.com/repos/KSP-KOS/KOS/contents/{+path}","compare_url":"https://api.github.com/repos/KSP-KOS/KOS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KSP-KOS/KOS/merges","archive_url":"https://api.github.com/repos/KSP-KOS/KOS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KSP-KOS/KOS/downloads","issues_url":"https://api.github.com/repos/KSP-KOS/KOS/issues{/number}","pulls_url":"https://api.github.com/repos/KSP-KOS/KOS/pulls{/number}","milestones_url":"https://api.github.com/repos/KSP-KOS/KOS/milestones{/number}","notifications_url":"https://api.github.com/repos/KSP-KOS/KOS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KSP-KOS/KOS/labels{/name}","releases_url":"https://api.github.com/repos/KSP-KOS/KOS/releases{/id}","deployments_url":"https://api.github.com/repos/KSP-KOS/KOS/deployments","created_at":"2014-02-26T16:43:31Z","updated_at":"2016-10-18T12:32:06Z","pushed_at":"2016-10-20T19:24:55Z","git_url":"git://github.com/KSP-KOS/KOS.git","ssh_url":"git@github.com:KSP-KOS/KOS.git","clone_url":"https://github.com/KSP-KOS/KOS.git","svn_url":"https://github.com/KSP-KOS/KOS","homepage":null,"size":107819,"stargazers_count":228,"watchers_count":228,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":116,"mirror_url":null,"open_issues_count":304,"forks":116,"open_issues":304,"watchers":228,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/KSP-KOS/KOS/pulls/1850"},"html":{"href":"https://github.com/KSP-KOS/KOS/pull/1850"},"issue":{"href":"https://api.github.com/repos/KSP-KOS/KOS/issues/1850"},"comments":{"href":"https://api.github.com/repos/KSP-KOS/KOS/issues/1850/comments"},"review_comments":{"href":"https://api.github.com/repos/KSP-KOS/KOS/pulls/1850/comments"},"review_comment":{"href":"https://api.github.com/repos/KSP-KOS/KOS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/KSP-KOS/KOS/pulls/1850/commits"},"statuses":{"href":"https://api.github.com/repos/KSP-KOS/KOS/statuses/10591abf72d87540570f2f0c2298df5f5590958a"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":8,"additions":1154,"deletions":385,"changed_files":29}}
{"actor":{"display_login":"hvacengi"}}