{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/react-native/issues/6434","repository_url":"https://api.github.com/repos/facebook/react-native","labels_url":"https://api.github.com/repos/facebook/react-native/issues/6434/labels{/name}","comments_url":"https://api.github.com/repos/facebook/react-native/issues/6434/comments","events_url":"https://api.github.com/repos/facebook/react-native/issues/6434/events","html_url":"https://github.com/facebook/react-native/pull/6434","id":140415370,"number":6434,"title":"RefreshControl refreshing prop and doc improvements","user":{"login":"janicduplessis","id":2677334,"avatar_url":"https://avatars.githubusercontent.com/u/2677334?v=3","gravatar_id":"","url":"https://api.github.com/users/janicduplessis","html_url":"https://github.com/janicduplessis","followers_url":"https://api.github.com/users/janicduplessis/followers","following_url":"https://api.github.com/users/janicduplessis/following{/other_user}","gists_url":"https://api.github.com/users/janicduplessis/gists{/gist_id}","starred_url":"https://api.github.com/users/janicduplessis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janicduplessis/subscriptions","organizations_url":"https://api.github.com/users/janicduplessis/orgs","repos_url":"https://api.github.com/users/janicduplessis/repos","events_url":"https://api.github.com/users/janicduplessis/events{/privacy}","received_events_url":"https://api.github.com/users/janicduplessis/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/facebook/react-native/labels/GH%20Review:%20accepted","name":"GH Review: accepted","color":"009800"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2016-03-12T20:41:04Z","updated_at":"2016-03-29T19:49:32Z","closed_at":"2016-03-13T10:04:44Z","pull_request":{"url":"https://api.github.com/repos/facebook/react-native/pulls/6434","html_url":"https://github.com/facebook/react-native/pull/6434","diff_url":"https://github.com/facebook/react-native/pull/6434.diff","patch_url":"https://github.com/facebook/react-native/pull/6434.patch"},"body":"This makes the `refreshing` prop more 'controlled'. Before forgetting to set the refreshing prop in the onRefresh callback would make the js and native `refreshing` prop get out of sync and make the RefreshControl stop refreshing properly (see #5839).\r\n\r\nI also added a simple usage example and a note about the refreshing prop in the doc.\r\n\r\nThere was also a small bug in the doc generation code that made the array of color show as [[object Object]] instead of [color] so I fixed that too.\r\n\r\n** Test plan**\r\nTested using the UIExplorer example on iOS and Android. Not setting the `refreshing` prop to true in the `onRefresh` function should cause the RefreshControl to stop refreshing immediately and continue working properly after.\r\n\r\nCloses #5839"},"comment":{"url":"https://api.github.com/repos/facebook/react-native/issues/comments/203070077","html_url":"https://github.com/facebook/react-native/pull/6434#issuecomment-203070077","issue_url":"https://api.github.com/repos/facebook/react-native/issues/6434","id":203070077,"user":{"login":"facebook-github-bot","id":6422482,"avatar_url":"https://avatars.githubusercontent.com/u/6422482?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook-github-bot","html_url":"https://github.com/facebook-github-bot","followers_url":"https://api.github.com/users/facebook-github-bot/followers","following_url":"https://api.github.com/users/facebook-github-bot/following{/other_user}","gists_url":"https://api.github.com/users/facebook-github-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook-github-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook-github-bot/subscriptions","organizations_url":"https://api.github.com/users/facebook-github-bot/orgs","repos_url":"https://api.github.com/users/facebook-github-bot/repos","events_url":"https://api.github.com/users/facebook-github-bot/events{/privacy}","received_events_url":"https://api.github.com/users/facebook-github-bot/received_events","type":"User","site_admin":false},"created_at":"2016-03-29T19:49:31Z","updated_at":"2016-03-29T19:49:31Z","body":"@janicduplessis updated the pull request."}}