{"push_id":1079014736,"size":3,"distinct_size":3,"ref":"refs/heads/3.22.x","head":"a0dd9770448322189dde29467e54d272f7d03071","before":"f2c5b7b036a47289a069f89bf3e63ede548058d8","commits":[{"sha":"271cbb949ae680487598bc5d873e439ecc26c315","author":{"email":"90effa772b5c8a7a3420e6b7ea56e265888c5743@bugs.koha-community.org","name":"Jonathan Druart"},"message":"Bug 15757: Add one test for GetLoanLength\n\nThe usual call (3 params) of this subroutine was not tested.\n\nSigned-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>\n\nSigned-off-by: Kyle M Hall <kyle@bywatersolutions.com>\n(cherry picked from commit d83aff33c603d1ba4d16de53ad926bd93a09629b)\nSigned-off-by: Julian Maurice <julian.maurice@biblibre.com>","distinct":true,"url":"https://api.github.com/repos/Koha-Community/Koha/commits/271cbb949ae680487598bc5d873e439ecc26c315"},{"sha":"2471a0e3a9f222b756d01492b413232afa60c1c6","author":{"email":"90effa772b5c8a7a3420e6b7ea56e265888c5743@bugs.koha-community.org","name":"Jonathan Druart"},"message":"Bug 15757: Make issuelength default to null instead of 0\n\nWhen editing circ rules, if the Loan period \"issuelength\" is not defined\n(empty string), the default value was 0, not it's inserted in the DB as\nNULL.\n\nTest plan:\n1/ Create or edit a circ rule\n2/ Do not fill the Loan period column\n3/ Save\n=> Without this patch, the value was 0\n=> With this patch it's now an empty string (in the DB it's set to NULL)\n\nSigned-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>\nWorks as described.\nNo errors\n\nSigned-off-by: Kyle M Hall <kyle@bywatersolutions.com>\n(cherry picked from commit d46a664ef6b79f6ceee2c00629f5933b4eaedfc3)\nSigned-off-by: Julian Maurice <julian.maurice@biblibre.com>","distinct":true,"url":"https://api.github.com/repos/Koha-Community/Koha/commits/2471a0e3a9f222b756d01492b413232afa60c1c6"},{"sha":"a0dd9770448322189dde29467e54d272f7d03071","author":{"email":"90effa772b5c8a7a3420e6b7ea56e265888c5743@bugs.koha-community.org","name":"Jonathan Druart"},"message":"Bug 15757: Make GetLoanLength defaults to 0 instead of 21\n\nGetLoanLength arbitrary defaulted to 21. The expected behavior seems to\nbe to default on 0 (loan will be dued today).\n\nIMPORTANT NOTE: This patch will introduce a change in the behaviors for\nconfiguration with a 0 in issuelength. Before this patch, the rule with\na issuelength==0 was skipped, now it's used!\n\nTest plan:\n1/ Do not define any rule: the due date will be today (before this patch\nwas +21 days)\n2/ Define some rules which does not match the patron category, itemtype\nor branchcode: the due date will be today (before this patch was +21\ndays).\n3/ Modify a rule to match the checkout and set issuelength=0: the due\ndate will be today (before this patch, the rule was skipped)\n4/ Modify this rule and set the issuelength to something > 0: the due\ndate will be adjusted (same behavior as before this patch)\n\nSigned-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>\nWorks ok, checked 1-4\nAll test pass\nNo koha-qa errors\n\nSigned-off-by: Kyle M Hall <kyle@bywatersolutions.com>\n(cherry picked from commit 769728015cea465bbb47d27f69077962a8f2429d)\nSigned-off-by: Julian Maurice <julian.maurice@biblibre.com>","distinct":true,"url":"https://api.github.com/repos/Koha-Community/Koha/commits/a0dd9770448322189dde29467e54d272f7d03071"}]}