{"action":"created","issue":{"url":"https://api.github.com/repos/OsnaCS/plantex/issues/190","repository_url":"https://api.github.com/repos/OsnaCS/plantex","labels_url":"https://api.github.com/repos/OsnaCS/plantex/issues/190/labels{/name}","comments_url":"https://api.github.com/repos/OsnaCS/plantex/issues/190/comments","events_url":"https://api.github.com/repos/OsnaCS/plantex/issues/190/events","html_url":"https://github.com/OsnaCS/plantex/pull/190","id":169798455,"number":190,"title":"One vertex buffer to rule them all","user":{"login":"LukasKalbertodt","id":7419664,"avatar_url":"https://avatars.githubusercontent.com/u/7419664?v=3","gravatar_id":"","url":"https://api.github.com/users/LukasKalbertodt","html_url":"https://github.com/LukasKalbertodt","followers_url":"https://api.github.com/users/LukasKalbertodt/followers","following_url":"https://api.github.com/users/LukasKalbertodt/following{/other_user}","gists_url":"https://api.github.com/users/LukasKalbertodt/gists{/gist_id}","starred_url":"https://api.github.com/users/LukasKalbertodt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LukasKalbertodt/subscriptions","organizations_url":"https://api.github.com/users/LukasKalbertodt/orgs","repos_url":"https://api.github.com/users/LukasKalbertodt/repos","events_url":"https://api.github.com/users/LukasKalbertodt/events{/privacy}","received_events_url":"https://api.github.com/users/LukasKalbertodt/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-08-07T14:19:08Z","updated_at":"2016-08-07T21:26:54Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/OsnaCS/plantex/pulls/190","html_url":"https://github.com/OsnaCS/plantex/pull/190","diff_url":"https://github.com/OsnaCS/plantex/pull/190.diff","patch_url":"https://github.com/OsnaCS/plantex/pull/190.patch"},"body":"Instead of using instancing, this PR saves a whole chunk in one vertex and index buffer. This increases the performance of rendering the ground a lot. I lack exact benchmarks, but I hope a few of you could provide such benchmarks. \r\n\r\nWithout rendering shadow or plants, I get between 50 and 60 FPS on my integrated Intel HD Graphics 530. With plants enabled I still get around 50 FPS in biomes with few plants, but FPS drops a lot in forests.\r\n\r\nThere is still a lot of room for improvements, but I figured this is enough for now. \r\n\r\nOh and by the way: I fixed the indexing bug. Or at least *one* big indexing bug."},"comment":{"url":"https://api.github.com/repos/OsnaCS/plantex/issues/comments/238109592","html_url":"https://github.com/OsnaCS/plantex/pull/190#issuecomment-238109592","issue_url":"https://api.github.com/repos/OsnaCS/plantex/issues/190","id":238109592,"user":{"login":"jonas-schievink","id":1786438,"avatar_url":"https://avatars.githubusercontent.com/u/1786438?v=3","gravatar_id":"","url":"https://api.github.com/users/jonas-schievink","html_url":"https://github.com/jonas-schievink","followers_url":"https://api.github.com/users/jonas-schievink/followers","following_url":"https://api.github.com/users/jonas-schievink/following{/other_user}","gists_url":"https://api.github.com/users/jonas-schievink/gists{/gist_id}","starred_url":"https://api.github.com/users/jonas-schievink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonas-schievink/subscriptions","organizations_url":"https://api.github.com/users/jonas-schievink/orgs","repos_url":"https://api.github.com/users/jonas-schievink/repos","events_url":"https://api.github.com/users/jonas-schievink/events{/privacy}","received_events_url":"https://api.github.com/users/jonas-schievink/received_events","type":"User","site_admin":false},"created_at":"2016-08-07T21:26:54Z","updated_at":"2016-08-07T21:26:54Z","body":"The buffer building code is a tad too complex for my liking, but very well documented so looks good to me"}}
{"actor":{"display_login":"jonas-schievink"}}