{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/WinObjC/pulls/comments/77757993","id":77757993,"diff_hunk":"@@ -84,6 +84,7 @@ static float fractionPixels(float pixels) {\n \n static CFIndex _DoWrap(CTTypesetterRef ts, CFRange range, WidthFinderFunc widthFunc, void* widthParam, double offset, CTLineRef* outLine) {","path":"Frameworks/CoreText/CTTypesetter.mm","position":2,"original_position":2,"commit_id":"8191ac8177d3ed2e11782e52671c95c08f2acb2d","original_commit_id":"8191ac8177d3ed2e11782e52671c95c08f2acb2d","user":{"login":"rajsesh-msft","id":15148713,"avatar_url":"https://avatars.githubusercontent.com/u/15148713?v=3","gravatar_id":"","url":"https://api.github.com/users/rajsesh-msft","html_url":"https://github.com/rajsesh-msft","followers_url":"https://api.github.com/users/rajsesh-msft/followers","following_url":"https://api.github.com/users/rajsesh-msft/following{/other_user}","gists_url":"https://api.github.com/users/rajsesh-msft/gists{/gist_id}","starred_url":"https://api.github.com/users/rajsesh-msft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rajsesh-msft/subscriptions","organizations_url":"https://api.github.com/users/rajsesh-msft/orgs","repos_url":"https://api.github.com/users/rajsesh-msft/repos","events_url":"https://api.github.com/users/rajsesh-msft/events{/privacy}","received_events_url":"https://api.github.com/users/rajsesh-msft/received_events","type":"User","site_admin":false},"body":"Why do we still need this method? Presumably for Draw until we move it to DWrite?","created_at":"2016-09-07T04:15:26Z","updated_at":"2016-09-07T04:15:26Z","html_url":"https://github.com/Microsoft/WinObjC/pull/950#discussion_r77757993","pull_request_url":"https://api.github.com/repos/Microsoft/WinObjC/pulls/950","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/WinObjC/pulls/comments/77757993"},"html":{"href":"https://github.com/Microsoft/WinObjC/pull/950#discussion_r77757993"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/WinObjC/pulls/950"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/WinObjC/pulls/950","id":83707612,"html_url":"https://github.com/Microsoft/WinObjC/pull/950","diff_url":"https://github.com/Microsoft/WinObjC/pull/950.diff","patch_url":"https://github.com/Microsoft/WinObjC/pull/950.patch","issue_url":"https://api.github.com/repos/Microsoft/WinObjC/issues/950","number":950,"state":"open","locked":false,"title":"Basic infrastructure that moves metrics calculations in CoreText to use DirectWrite","user":{"login":"mnithish","id":18412940,"avatar_url":"https://avatars.githubusercontent.com/u/18412940?v=3","gravatar_id":"","url":"https://api.github.com/users/mnithish","html_url":"https://github.com/mnithish","followers_url":"https://api.github.com/users/mnithish/followers","following_url":"https://api.github.com/users/mnithish/following{/other_user}","gists_url":"https://api.github.com/users/mnithish/gists{/gist_id}","starred_url":"https://api.github.com/users/mnithish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mnithish/subscriptions","organizations_url":"https://api.github.com/users/mnithish/orgs","repos_url":"https://api.github.com/users/mnithish/repos","events_url":"https://api.github.com/users/mnithish/events{/privacy}","received_events_url":"https://api.github.com/users/mnithish/received_events","type":"User","site_admin":false},"body":"This change contains the fundamental pieces required for CoreText to use DirectWrite. This change regresses some of the functionality that was working before with FreeType and will fixed in the coming iterations","created_at":"2016-09-01T21:09:50Z","updated_at":"2016-09-07T04:15:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f09b200301f594b969712024f26ed4d25a62457c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/WinObjC/pulls/950/commits","review_comments_url":"https://api.github.com/repos/Microsoft/WinObjC/pulls/950/comments","review_comment_url":"https://api.github.com/repos/Microsoft/WinObjC/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/WinObjC/issues/950/comments","statuses_url":"https://api.github.com/repos/Microsoft/WinObjC/statuses/8191ac8177d3ed2e11782e52671c95c08f2acb2d","head":{"label":"mnithish:DWrite","ref":"DWrite","sha":"8191ac8177d3ed2e11782e52671c95c08f2acb2d","user":{"login":"mnithish","id":18412940,"avatar_url":"https://avatars.githubusercontent.com/u/18412940?v=3","gravatar_id":"","url":"https://api.github.com/users/mnithish","html_url":"https://github.com/mnithish","followers_url":"https://api.github.com/users/mnithish/followers","following_url":"https://api.github.com/users/mnithish/following{/other_user}","gists_url":"https://api.github.com/users/mnithish/gists{/gist_id}","starred_url":"https://api.github.com/users/mnithish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mnithish/subscriptions","organizations_url":"https://api.github.com/users/mnithish/orgs","repos_url":"https://api.github.com/users/mnithish/repos","events_url":"https://api.github.com/users/mnithish/events{/privacy}","received_events_url":"https://api.github.com/users/mnithish/received_events","type":"User","site_admin":false},"repo":{"id":62111737,"name":"WinObjC","full_name":"mnithish/WinObjC","owner":{"login":"mnithish","id":18412940,"avatar_url":"https://avatars.githubusercontent.com/u/18412940?v=3","gravatar_id":"","url":"https://api.github.com/users/mnithish","html_url":"https://github.com/mnithish","followers_url":"https://api.github.com/users/mnithish/followers","following_url":"https://api.github.com/users/mnithish/following{/other_user}","gists_url":"https://api.github.com/users/mnithish/gists{/gist_id}","starred_url":"https://api.github.com/users/mnithish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mnithish/subscriptions","organizations_url":"https://api.github.com/users/mnithish/orgs","repos_url":"https://api.github.com/users/mnithish/repos","events_url":"https://api.github.com/users/mnithish/events{/privacy}","received_events_url":"https://api.github.com/users/mnithish/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mnithish/WinObjC","description":"Objective-C for Windows","fork":true,"url":"https://api.github.com/repos/mnithish/WinObjC","forks_url":"https://api.github.com/repos/mnithish/WinObjC/forks","keys_url":"https://api.github.com/repos/mnithish/WinObjC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mnithish/WinObjC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mnithish/WinObjC/teams","hooks_url":"https://api.github.com/repos/mnithish/WinObjC/hooks","issue_events_url":"https://api.github.com/repos/mnithish/WinObjC/issues/events{/number}","events_url":"https://api.github.com/repos/mnithish/WinObjC/events","assignees_url":"https://api.github.com/repos/mnithish/WinObjC/assignees{/user}","branches_url":"https://api.github.com/repos/mnithish/WinObjC/branches{/branch}","tags_url":"https://api.github.com/repos/mnithish/WinObjC/tags","blobs_url":"https://api.github.com/repos/mnithish/WinObjC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mnithish/WinObjC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mnithish/WinObjC/git/refs{/sha}","trees_url":"https://api.github.com/repos/mnithish/WinObjC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mnithish/WinObjC/statuses/{sha}","languages_url":"https://api.github.com/repos/mnithish/WinObjC/languages","stargazers_url":"https://api.github.com/repos/mnithish/WinObjC/stargazers","contributors_url":"https://api.github.com/repos/mnithish/WinObjC/contributors","subscribers_url":"https://api.github.com/repos/mnithish/WinObjC/subscribers","subscription_url":"https://api.github.com/repos/mnithish/WinObjC/subscription","commits_url":"https://api.github.com/repos/mnithish/WinObjC/commits{/sha}","git_commits_url":"https://api.github.com/repos/mnithish/WinObjC/git/commits{/sha}","comments_url":"https://api.github.com/repos/mnithish/WinObjC/comments{/number}","issue_comment_url":"https://api.github.com/repos/mnithish/WinObjC/issues/comments{/number}","contents_url":"https://api.github.com/repos/mnithish/WinObjC/contents/{+path}","compare_url":"https://api.github.com/repos/mnithish/WinObjC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mnithish/WinObjC/merges","archive_url":"https://api.github.com/repos/mnithish/WinObjC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mnithish/WinObjC/downloads","issues_url":"https://api.github.com/repos/mnithish/WinObjC/issues{/number}","pulls_url":"https://api.github.com/repos/mnithish/WinObjC/pulls{/number}","milestones_url":"https://api.github.com/repos/mnithish/WinObjC/milestones{/number}","notifications_url":"https://api.github.com/repos/mnithish/WinObjC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mnithish/WinObjC/labels{/name}","releases_url":"https://api.github.com/repos/mnithish/WinObjC/releases{/id}","deployments_url":"https://api.github.com/repos/mnithish/WinObjC/deployments","created_at":"2016-06-28T05:09:24Z","updated_at":"2016-06-28T05:09:39Z","pushed_at":"2016-09-07T01:43:21Z","git_url":"git://github.com/mnithish/WinObjC.git","ssh_url":"git@github.com:mnithish/WinObjC.git","clone_url":"https://github.com/mnithish/WinObjC.git","svn_url":"https://github.com/mnithish/WinObjC","homepage":"","size":331431,"stargazers_count":0,"watchers_count":0,"language":"Objective-C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:CT-DW","ref":"CT-DW","sha":"1e22e8fd46657b9d0c9774b606349c11bf610881","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":37950166,"name":"WinObjC","full_name":"Microsoft/WinObjC","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/WinObjC","description":"Objective-C for Windows","fork":false,"url":"https://api.github.com/repos/Microsoft/WinObjC","forks_url":"https://api.github.com/repos/Microsoft/WinObjC/forks","keys_url":"https://api.github.com/repos/Microsoft/WinObjC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/WinObjC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/WinObjC/teams","hooks_url":"https://api.github.com/repos/Microsoft/WinObjC/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/WinObjC/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/WinObjC/events","assignees_url":"https://api.github.com/repos/Microsoft/WinObjC/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/WinObjC/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/WinObjC/tags","blobs_url":"https://api.github.com/repos/Microsoft/WinObjC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/WinObjC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/WinObjC/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/WinObjC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/WinObjC/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/WinObjC/languages","stargazers_url":"https://api.github.com/repos/Microsoft/WinObjC/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/WinObjC/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/WinObjC/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/WinObjC/subscription","commits_url":"https://api.github.com/repos/Microsoft/WinObjC/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/WinObjC/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/WinObjC/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/WinObjC/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/WinObjC/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/WinObjC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/WinObjC/merges","archive_url":"https://api.github.com/repos/Microsoft/WinObjC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/WinObjC/downloads","issues_url":"https://api.github.com/repos/Microsoft/WinObjC/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/WinObjC/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/WinObjC/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/WinObjC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/WinObjC/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/WinObjC/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/WinObjC/deployments","created_at":"2015-06-23T23:14:58Z","updated_at":"2016-09-06T08:56:20Z","pushed_at":"2016-09-07T01:43:22Z","git_url":"git://github.com/Microsoft/WinObjC.git","ssh_url":"git@github.com:Microsoft/WinObjC.git","clone_url":"https://github.com/Microsoft/WinObjC.git","svn_url":"https://github.com/Microsoft/WinObjC","homepage":"","size":336122,"stargazers_count":5431,"watchers_count":5431,"language":"Objective-C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":696,"mirror_url":null,"open_issues_count":229,"forks":696,"open_issues":229,"watchers":5431,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/WinObjC/pulls/950"},"html":{"href":"https://github.com/Microsoft/WinObjC/pull/950"},"issue":{"href":"https://api.github.com/repos/Microsoft/WinObjC/issues/950"},"comments":{"href":"https://api.github.com/repos/Microsoft/WinObjC/issues/950/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/WinObjC/pulls/950/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/WinObjC/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/WinObjC/pulls/950/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/WinObjC/statuses/8191ac8177d3ed2e11782e52671c95c08f2acb2d"}}}}
{"actor":{"display_login":"rajsesh-msft"}}