{"action":"opened","issue":{"url":"https://api.github.com/repos/rtcweb-wg/jsep/issues/426","repository_url":"https://api.github.com/repos/rtcweb-wg/jsep","labels_url":"https://api.github.com/repos/rtcweb-wg/jsep/issues/426/labels{/name}","comments_url":"https://api.github.com/repos/rtcweb-wg/jsep/issues/426/comments","events_url":"https://api.github.com/repos/rtcweb-wg/jsep/issues/426/events","html_url":"https://github.com/rtcweb-wg/jsep/issues/426","id":190256828,"number":426,"title":"Editorial / semi-substantive, section 5.2 (Create initial offer)","user":{"login":"alvestrand","id":480893,"avatar_url":"https://avatars.githubusercontent.com/u/480893?v=3","gravatar_id":"","url":"https://api.github.com/users/alvestrand","html_url":"https://github.com/alvestrand","followers_url":"https://api.github.com/users/alvestrand/followers","following_url":"https://api.github.com/users/alvestrand/following{/other_user}","gists_url":"https://api.github.com/users/alvestrand/gists{/gist_id}","starred_url":"https://api.github.com/users/alvestrand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alvestrand/subscriptions","organizations_url":"https://api.github.com/users/alvestrand/orgs","repos_url":"https://api.github.com/users/alvestrand/repos","events_url":"https://api.github.com/users/alvestrand/events{/privacy}","received_events_url":"https://api.github.com/users/alvestrand/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-11-18T07:52:17Z","updated_at":"2016-11-18T07:52:17Z","closed_at":null,"body":"- Section 5.2.1 \"an m= section being recycled\" - first use of term\r\n\"recycled\". Link?\r\n\r\n- Section 5.2.1 CreateOffer \"given that no candidates have yet been\r\ngathered\" - when people remember the pre-gathered candidate pool, this\r\ncan be confusing. Suggest adding a note at the top of this section\r\nsaying that CreateOffer doesn't cause candidate gathering and does not\r\ntake candidates from the pre-gathered pool, and thus, no candidates are\r\navailable at the initial call to CreateOffer. All subsequent references\r\nto \"no candidates have yet been gathered\" in this section should be\r\nreplaced with \"no candidates are available\".\r\n\r\n- Section 5.2.1 bullet 2 (first list) references use of the default\r\ncandidate (which doesn't exist here). Suggest saying \"UDP/TLS/RTP/SAVPF\"\r\nand moving the default candidate language to subsequent offers.\r\n\r\n- Section 5.2.1 CreateOffer - bullet on imageattr - limits on images\r\nthat can be decoded - suggest adding text that this is also included on\r\nrecvonly lines because direction of lines can change.\r\n\r\n- Section 5.2.1 \"The following attributes ... MUST appear only in \"m=\"\r\nsections which either have a unique address or which are associated with\r\nthe bundle-tag\". This is different from BUNDLE 8.1 - they should either\r\nsay the same thing or have a clear explanation of the difference.\r\n\r\n- Section 5.2.1 \"a=fingerprint\" - needs rewriting for the\r\nmultiple-fingerprint-algorithm case (4572bis). Issue already filed?\r\n\r\n- Section 5.2.2 Subsequent offers - is there any reason to allow NOT\r\nincrementing the session-version?\r\n\r\n- Section 5.2.2 The example of rollback doesn't make sense - it works if\r\n\"an offer is created with version N+1\" is replaced with \"an offer is\r\ncreated with version N+1 and installed with SetLocalDescription\"\r\n\r\n- Section 5.2.2 recycling of zero-port m-lines - should it specify that\r\nthe new m= section MUST have a different mid than the replaced m= section?\r\n\r\n- Section 5.2.2 \"the following adjustments are made based on the content\r\nof the corresponding m= section in the current remote description\" -\r\nneeds to be contained by \"if there is a current remote description\"."}}
{"actor":{"display_login":"alvestrand"}}