{"action":"created","issue":{"url":"https://api.github.com/repos/servo/servo/issues/11554","repository_url":"https://api.github.com/repos/servo/servo","labels_url":"https://api.github.com/repos/servo/servo/issues/11554/labels{/name}","comments_url":"https://api.github.com/repos/servo/servo/issues/11554/comments","events_url":"https://api.github.com/repos/servo/servo/issues/11554/events","html_url":"https://github.com/servo/servo/pull/11554","id":158087536,"number":11554,"title":"Support link target attribute","user":{"login":"paulrouget","id":373579,"avatar_url":"https://avatars.githubusercontent.com/u/373579?v=3","gravatar_id":"","url":"https://api.github.com/users/paulrouget","html_url":"https://github.com/paulrouget","followers_url":"https://api.github.com/users/paulrouget/followers","following_url":"https://api.github.com/users/paulrouget/following{/other_user}","gists_url":"https://api.github.com/users/paulrouget/gists{/gist_id}","starred_url":"https://api.github.com/users/paulrouget/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulrouget/subscriptions","organizations_url":"https://api.github.com/users/paulrouget/orgs","repos_url":"https://api.github.com/users/paulrouget/repos","events_url":"https://api.github.com/users/paulrouget/events{/privacy}","received_events_url":"https://api.github.com/users/paulrouget/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/servo/servo/labels/S-awaiting-review","name":"S-awaiting-review","color":"d4c5f9"},{"url":"https://api.github.com/repos/servo/servo/labels/S-tests-failed","name":"S-tests-failed","color":"d4c5f9"}],"state":"open","locked":false,"assignee":{"login":"KiChjang","id":3248587,"avatar_url":"https://avatars.githubusercontent.com/u/3248587?v=3","gravatar_id":"","url":"https://api.github.com/users/KiChjang","html_url":"https://github.com/KiChjang","followers_url":"https://api.github.com/users/KiChjang/followers","following_url":"https://api.github.com/users/KiChjang/following{/other_user}","gists_url":"https://api.github.com/users/KiChjang/gists{/gist_id}","starred_url":"https://api.github.com/users/KiChjang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KiChjang/subscriptions","organizations_url":"https://api.github.com/users/KiChjang/orgs","repos_url":"https://api.github.com/users/KiChjang/repos","events_url":"https://api.github.com/users/KiChjang/events{/privacy}","received_events_url":"https://api.github.com/users/KiChjang/received_events","type":"User","site_admin":false},"milestone":null,"comments":5,"created_at":"2016-06-02T08:39:46Z","updated_at":"2016-06-02T09:27:05Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/servo/servo/pulls/11554","html_url":"https://github.com/servo/servo/pull/11554","diff_url":"https://github.com/servo/servo/pull/11554.diff","patch_url":"https://github.com/servo/servo/pull/11554.patch"},"body":"<!-- Please describe your changes on the following line: -->\r\n\r\n---\r\n<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->\r\n- [x] `./mach build -d` does not report any errors\r\n- [x] `./mach test-tidy` does not report any errors\r\n- [ ] These changes fix #__ (github issue number if applicable).\r\n\r\n<!-- Either: -->\r\n- [x] There are tests for these changes OR\r\n- [ ] These changes do not require tests because _____\r\n\r\n<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"35\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/servo/servo/11554)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/servo/servo/issues/comments/223241000","html_url":"https://github.com/servo/servo/pull/11554#issuecomment-223241000","issue_url":"https://api.github.com/repos/servo/servo/issues/11554","id":223241000,"user":{"login":"highfive","id":5750442,"avatar_url":"https://avatars.githubusercontent.com/u/5750442?v=3","gravatar_id":"","url":"https://api.github.com/users/highfive","html_url":"https://github.com/highfive","followers_url":"https://api.github.com/users/highfive/followers","following_url":"https://api.github.com/users/highfive/following{/other_user}","gists_url":"https://api.github.com/users/highfive/gists{/gist_id}","starred_url":"https://api.github.com/users/highfive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highfive/subscriptions","organizations_url":"https://api.github.com/users/highfive/orgs","repos_url":"https://api.github.com/users/highfive/repos","events_url":"https://api.github.com/users/highfive/events{/privacy}","received_events_url":"https://api.github.com/users/highfive/received_events","type":"User","site_admin":false},"created_at":"2016-06-02T09:27:05Z","updated_at":"2016-06-02T09:27:05Z","body":"      ▶ Unexpected subtest result in /html/dom/interfaces.html:\n      └ PASS [expected FAIL] HTMLAnchorElement interface: attribute target\n    \n      ▶ Unexpected subtest result in /html/dom/interfaces.html:\n      └ PASS [expected FAIL] HTMLAnchorElement interface: document.createElement(&#34;a&#34;) must inherit property &#34;target&#34; with the proper type (0)\n    \n      ▶ Unexpected sub</span><span class=\"stdout\">test result in /html/dom/reflection-text.html:\n      └ PASS [expected FAIL] a.target: typeof IDL attribute\n    \n      ▶ Unexpected subtest result in /html/dom/reflection-text.html:\n      └ PASS [expected FAIL] a.target: IDL get with DOM attribute unset\n    \n      ▶ Unexpected subtest result in /html/dom/reflection-text.html:\n      └ PASS [expected FAIL] a.target: setAttribute() to &#34;&#34; followed by IDL get\n    \n      ▶ Unexpected subtest result in /html/dom/reflection-text.html:\n      └ PASS [expected FAIL] a.target: setAttribute() to &#34; \\\\0\\\\x01\\\\x02\\\\x03\\\\x04\\\\x05\\\\x06\\\\x07 \\\\b\\\\t\\\\n\\\\v\\\\f\\\\r\\\\x0e\\\\x0f \\\\x10\\\\x11\\\\x12\\\\x13\\\\x14\\\\x15\\\\x16\\\\x17 \\\\x18\\\\x19\\\\x1a\\\\x1b\\\\x1c\\\\x1d\\\\x1e\\\\x1f  foo &#34; followed by IDL get\n    \n      ▶ Unexpected subtest result in /html/dom/reflection-text.html:\n      └ PASS [expected FAIL] a.target: setAttribute() to undefined followed by IDL get\n    \n      ▶ Unexpected subtest result in /html/dom/reflection-text.html:\n      └ PASS [expected FAIL] a.target: setAttribute() to 7 followed by IDL get\n    \n      ▶ Unexpected subtest result in /html/dom/reflection-text.html:\n      └ PASS [expected FAIL] a.target: setAttribute() to 1.5 followed by IDL get\n    \n      ▶ Unexpected subtest result in /html/dom/reflection-text.html:\n      └ PASS [expected FAIL] a.target: setAttribute() to true followed by IDL get\n    \n      ▶ Unexpected subtest result in /html/dom/reflection-text.html:\n      └ PASS [expected FAIL] a.target: setAttribute() to false followed by IDL get\n    \n      ▶ Unexpected subtest result in /html/dom/reflection-text.html:\n      └ PASS [expected FAIL] a.target: setAttribute() to object &#34;[object Object]&#34; followed by IDL get\n    \n      ▶ Unexpected subtest result in /html/dom/reflection-text.html:\n      └ PASS [expected FAIL] a.target: setAttribute() to NaN followed by IDL get\n    \n      ▶ Unexpected subtest result in /html/dom/reflection-text.html:\n      └ PASS [expected FAIL] a.target: setAttribute() to Infinity followed by IDL get\n    \n      ▶ Unexpected subtest result in /html/dom/reflection-text.html:\n      └ PASS [expected FAIL] a.target: setAttribute() to -Infinity followed by IDL get\n    \n      ▶ Unexpected subtest result in /html/dom/reflection-text.html:\n      └ PASS [expected FAIL] a.target: setAttribute() to &#34;\\\\0&#34; followed by IDL get\n    \n      ▶ Unexpected subtest result in /html/dom/reflection-text.html:\n      └ PASS [expected FAIL] a.target: setAttribute() to null followed by IDL get\n    \n      ▶ Unexpected subtest result in /html/dom/reflection-text.html:\n      └ PASS [expected FAIL] a.target: setAttribute() to object &#34;test-toString&#34; followed by IDL get\n    \n      ▶ Unexpected subtest result in /html/dom/reflection-text.html:\n      └ PASS [expected FAIL] a.target: setAttribute() to object &#34;test-valueOf&#34; followed by IDL get\n    \n      ▶ Unexpected subtest result in /html/dom/reflection-text.html:\n      └ PASS [expected FAIL] a.target: IDL set to &#34;&#34; followed by getAttribute()\n    \n      ▶ Unexpected subtest result in /html/dom/reflection-text.html:\n      └ PASS [expected FAIL] a.target: IDL set to &#34; \\\\0\\\\x01\\\\x02\\\\x03\\\\x04\\\\x05\\\\x06\\\\x07 \\\\b\\\\t\\\\n\\\\v\\\\f\\\\r\\\\x0e\\\\x0f \\\\x10\\\\x11\\\\x12\\\\x13\\\\x14\\\\x15\\\\x16\\\\x17 \\\\x18\\\\x19\\\\x1a\\\\x1b\\\\x1c\\\\x1d\\\\x1e\\\\x1f  foo &#34; followed by getAttribute()\n    \n      ▶ Unexpected subtest result in /html/dom/reflection-text.html:\n      └ PASS [expected FAIL] a.target: IDL set to undefined followed by getAttribute()\n    \n      ▶ Unexpected subtest result in /html/dom/reflection-text.html:\n      └ PASS [expected FAIL] a.target: IDL set to undefined followed by IDL get\n    \n      ▶ Unexpected subtest result in /html/dom/reflection-text.html:\n      └ PASS [expected FAIL] a.target: IDL set to 7 followed by getAttribute()\n    \n      ▶ Unexpected subtest result in /html/dom/reflection-text.html:\n      └ PASS [expected FAIL] a.target: IDL set to 7 followed by IDL get\n    \n      ▶ Unexpected subtest result in /html/dom/reflection-text.html:\n      └ PASS [expected FAIL] a.target: IDL set to 1.5 followed by getAttribute()\n    \n      ▶ Unexpected subtest result in /html/dom/reflection-text.html:\n      └ PASS [expected FAIL] a.target: IDL set to 1.5 followed by IDL get\n    \n      ▶ Unexpected subtest result in /html/dom/reflection-text.html:\n      └ PASS [expected FAIL] a.target: IDL set to true followed by getAttribute()\n    \n      ▶ Unexpected subtest result in /html/dom/reflection-text.html:\n      └ PASS [expected FAIL] a.target: IDL set to true followed by IDL get\n    \n      ▶ Unexpected subtest result in /html/dom/reflection-text.html:\n      └ PASS [expected FAIL] a.target: IDL set to false followed by getAttribute()\n    \n      ▶ Unexpected subtest result in /html/dom/reflection-text.html:\n      └ PASS [expected FAIL] a.target: IDL set to false followed by IDL get\n    \n      ▶ Unexpected subtest result in /html/dom/reflection-text.html:\n      └ PASS [expected FAIL] a.target: IDL set to object &#34;[object Object]&#34; followed by getAttribute()\n    \n      ▶ Unexpected subtest result in /html/dom/reflection-text.html:\n      └ PASS [expected FAIL] a.target: IDL set to object &#34;[object Object]&#34; followed by IDL get\n    \n      ▶ Unexpected subtest result in /html/dom/reflection-text.html:\n      └ PASS [expected FAIL] a.target: IDL set to NaN followed by getAttribute()\n    \n      ▶ Unexpected subtest result in /html/dom/reflection-text.html:\n      └ PASS [expected FAIL] a.target: IDL set to NaN followed by IDL get\n    \n      ▶ Unexpected subtest result in /html/dom/reflection-text.html:\n      └ PASS [expected FAIL] a.target: IDL set to Infinity followed by getAttribute()\n    \n      ▶ Unexpected subtest result in /html/dom/reflection-text.html:\n      └ PASS [expected FAIL] a.target: IDL set to Infinity followed by IDL get\n    \n      ▶ Unexpected subtest result in /html/dom/reflection-text.html:\n      └ PASS [expected FAIL] a.target: IDL set to -Infinity followed by getAttribute()\n    \n      ▶ Unexpected subtest result in /html/dom/reflection-text.html:\n      └ PASS [expected FAIL] a.target: IDL set to -Infinity followed by IDL get\n    \n      ▶ Unexpected subtest result in /html/dom/reflection-text.html:\n      └ PASS [expected FAIL] a.target: IDL set to &#34;\\\\0&#34; followed by getAttribute()\n    \n      ▶ Unexpected subtest result in /html/dom/reflection-text.html:\n      └ PASS [expected FAIL] a.target: IDL set to null followed by getAttribute()\n    \n      ▶ Unexpected subtest result in /html/dom/reflection-text.html:\n      └ PASS [expected FAIL] a.target: IDL set to null followed by IDL get\n    \n      ▶ Unexpected subtest result in /html/dom/reflection-text.html:\n      └ PASS [expected FAIL] a.target: IDL set to object &#34;test-toString&#34; followed by getAttribute()\n    \n      ▶ Unexpected subtest result in /html/dom/reflection-text.html:\n      └ PASS [expected FAIL] a.target: IDL set to object &#34;test-toString&#34; followed by IDL get\n    \n      ▶ Unexpected subtest result in /html/dom/reflection-text.html:\n      └ PASS [expected FAIL] a.target: IDL set to object &#34;test-valueOf&#34; followed by IDL get\n    "}}
{"actor":{"display_login":"highfive"}}