{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/pulls/comments/67696504","id":67696504,"diff_hunk":"@@ -36,7 +36,8 @@ do\n   /opt/puppet/bin/puppet module install $i --modulepath=/tmp/packer-puppet-masterless/manifests/modules >/dev/null 2>&1\n done\n \n-if [[ ${TEMPLATE} == \"fedora-23\"* ]]; then\n+# Any supported Fedora now needs this\n+if [[ ${TEMPLATE} == \"fedora-2\"* ]]; then","path":"scripts/bootstrap-puppet.sh","position":6,"original_position":6,"commit_id":"b94114ba10ac63326eaa6382ed104609e6524e9d","original_commit_id":"b94114ba10ac63326eaa6382ed104609e6524e9d","user":{"login":"shermdog","id":3383063,"avatar_url":"https://avatars.githubusercontent.com/u/3383063?v=3","gravatar_id":"","url":"https://api.github.com/users/shermdog","html_url":"https://github.com/shermdog","followers_url":"https://api.github.com/users/shermdog/followers","following_url":"https://api.github.com/users/shermdog/following{/other_user}","gists_url":"https://api.github.com/users/shermdog/gists{/gist_id}","starred_url":"https://api.github.com/users/shermdog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shermdog/subscriptions","organizations_url":"https://api.github.com/users/shermdog/orgs","repos_url":"https://api.github.com/users/shermdog/repos","events_url":"https://api.github.com/users/shermdog/events{/privacy}","received_events_url":"https://api.github.com/users/shermdog/received_events","type":"User","site_admin":false},"body":"This is left over from Mike's original PR from the pre-AIO work - i didn't feel like changing it :)","created_at":"2016-06-20T14:15:36Z","updated_at":"2016-06-20T14:15:36Z","html_url":"https://github.com/puppetlabs/puppetlabs-packer/pull/77#discussion_r67696504","pull_request_url":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/pulls/77","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/pulls/comments/67696504"},"html":{"href":"https://github.com/puppetlabs/puppetlabs-packer/pull/77#discussion_r67696504"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/pulls/77"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/pulls/77","id":74272867,"html_url":"https://github.com/puppetlabs/puppetlabs-packer/pull/77","diff_url":"https://github.com/puppetlabs/puppetlabs-packer/pull/77.diff","patch_url":"https://github.com/puppetlabs/puppetlabs-packer/pull/77.patch","issue_url":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/issues/77","number":77,"state":"open","locked":false,"title":"(RE-7330) Update Fedora 24 Gold RC + Use AIO to provision","user":{"login":"shermdog","id":3383063,"avatar_url":"https://avatars.githubusercontent.com/u/3383063?v=3","gravatar_id":"","url":"https://api.github.com/users/shermdog","html_url":"https://github.com/shermdog","followers_url":"https://api.github.com/users/shermdog/followers","following_url":"https://api.github.com/users/shermdog/following{/other_user}","gists_url":"https://api.github.com/users/shermdog/gists{/gist_id}","starred_url":"https://api.github.com/users/shermdog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shermdog/subscriptions","organizations_url":"https://api.github.com/users/shermdog/orgs","repos_url":"https://api.github.com/users/shermdog/repos","events_url":"https://api.github.com/users/shermdog/events{/privacy}","received_events_url":"https://api.github.com/users/shermdog/received_events","type":"User","site_admin":false},"body":"The time has come to use the AIO vs older 3.8 binary.  This is necessary as default providers and library support has changed in modern operating systems, such as DNF and Python3\r\n(Note we'll update this soonish to remove NFS all together and just do the fun stuff locally - better for the community and our sanity).\r\n\r\nAdded headless as monitoring the build over VNC is great for troubleshooting.\r\n\r\nSet target vsphere NIC to vmxnet3 and removed dependency on specifying interface in bootstrap","created_at":"2016-06-17T16:52:57Z","updated_at":"2016-06-20T14:15:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cb05763ea0c6e3d49d0881273b9d385aafad07f5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/pulls/77/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/pulls/77/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/issues/77/comments","statuses_url":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/statuses/b94114ba10ac63326eaa6382ed104609e6524e9d","head":{"label":"shermdog:RE-7330","ref":"RE-7330","sha":"b94114ba10ac63326eaa6382ed104609e6524e9d","user":{"login":"shermdog","id":3383063,"avatar_url":"https://avatars.githubusercontent.com/u/3383063?v=3","gravatar_id":"","url":"https://api.github.com/users/shermdog","html_url":"https://github.com/shermdog","followers_url":"https://api.github.com/users/shermdog/followers","following_url":"https://api.github.com/users/shermdog/following{/other_user}","gists_url":"https://api.github.com/users/shermdog/gists{/gist_id}","starred_url":"https://api.github.com/users/shermdog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shermdog/subscriptions","organizations_url":"https://api.github.com/users/shermdog/orgs","repos_url":"https://api.github.com/users/shermdog/repos","events_url":"https://api.github.com/users/shermdog/events{/privacy}","received_events_url":"https://api.github.com/users/shermdog/received_events","type":"User","site_admin":false},"repo":{"id":52988901,"name":"puppetlabs-packer","full_name":"shermdog/puppetlabs-packer","owner":{"login":"shermdog","id":3383063,"avatar_url":"https://avatars.githubusercontent.com/u/3383063?v=3","gravatar_id":"","url":"https://api.github.com/users/shermdog","html_url":"https://github.com/shermdog","followers_url":"https://api.github.com/users/shermdog/followers","following_url":"https://api.github.com/users/shermdog/following{/other_user}","gists_url":"https://api.github.com/users/shermdog/gists{/gist_id}","starred_url":"https://api.github.com/users/shermdog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shermdog/subscriptions","organizations_url":"https://api.github.com/users/shermdog/orgs","repos_url":"https://api.github.com/users/shermdog/repos","events_url":"https://api.github.com/users/shermdog/events{/privacy}","received_events_url":"https://api.github.com/users/shermdog/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shermdog/puppetlabs-packer","description":"","fork":true,"url":"https://api.github.com/repos/shermdog/puppetlabs-packer","forks_url":"https://api.github.com/repos/shermdog/puppetlabs-packer/forks","keys_url":"https://api.github.com/repos/shermdog/puppetlabs-packer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shermdog/puppetlabs-packer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shermdog/puppetlabs-packer/teams","hooks_url":"https://api.github.com/repos/shermdog/puppetlabs-packer/hooks","issue_events_url":"https://api.github.com/repos/shermdog/puppetlabs-packer/issues/events{/number}","events_url":"https://api.github.com/repos/shermdog/puppetlabs-packer/events","assignees_url":"https://api.github.com/repos/shermdog/puppetlabs-packer/assignees{/user}","branches_url":"https://api.github.com/repos/shermdog/puppetlabs-packer/branches{/branch}","tags_url":"https://api.github.com/repos/shermdog/puppetlabs-packer/tags","blobs_url":"https://api.github.com/repos/shermdog/puppetlabs-packer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shermdog/puppetlabs-packer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shermdog/puppetlabs-packer/git/refs{/sha}","trees_url":"https://api.github.com/repos/shermdog/puppetlabs-packer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shermdog/puppetlabs-packer/statuses/{sha}","languages_url":"https://api.github.com/repos/shermdog/puppetlabs-packer/languages","stargazers_url":"https://api.github.com/repos/shermdog/puppetlabs-packer/stargazers","contributors_url":"https://api.github.com/repos/shermdog/puppetlabs-packer/contributors","subscribers_url":"https://api.github.com/repos/shermdog/puppetlabs-packer/subscribers","subscription_url":"https://api.github.com/repos/shermdog/puppetlabs-packer/subscription","commits_url":"https://api.github.com/repos/shermdog/puppetlabs-packer/commits{/sha}","git_commits_url":"https://api.github.com/repos/shermdog/puppetlabs-packer/git/commits{/sha}","comments_url":"https://api.github.com/repos/shermdog/puppetlabs-packer/comments{/number}","issue_comment_url":"https://api.github.com/repos/shermdog/puppetlabs-packer/issues/comments{/number}","contents_url":"https://api.github.com/repos/shermdog/puppetlabs-packer/contents/{+path}","compare_url":"https://api.github.com/repos/shermdog/puppetlabs-packer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shermdog/puppetlabs-packer/merges","archive_url":"https://api.github.com/repos/shermdog/puppetlabs-packer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shermdog/puppetlabs-packer/downloads","issues_url":"https://api.github.com/repos/shermdog/puppetlabs-packer/issues{/number}","pulls_url":"https://api.github.com/repos/shermdog/puppetlabs-packer/pulls{/number}","milestones_url":"https://api.github.com/repos/shermdog/puppetlabs-packer/milestones{/number}","notifications_url":"https://api.github.com/repos/shermdog/puppetlabs-packer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shermdog/puppetlabs-packer/labels{/name}","releases_url":"https://api.github.com/repos/shermdog/puppetlabs-packer/releases{/id}","deployments_url":"https://api.github.com/repos/shermdog/puppetlabs-packer/deployments","created_at":"2016-03-02T19:10:15Z","updated_at":"2016-03-02T19:10:16Z","pushed_at":"2016-06-17T16:51:43Z","git_url":"git://github.com/shermdog/puppetlabs-packer.git","ssh_url":"git@github.com:shermdog/puppetlabs-packer.git","clone_url":"https://github.com/shermdog/puppetlabs-packer.git","svn_url":"https://github.com/shermdog/puppetlabs-packer","homepage":null,"size":268,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"765c7950b98b1e7944934b494c9a1ad0bdae90aa","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":21011440,"name":"puppetlabs-packer","full_name":"puppetlabs/puppetlabs-packer","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/puppetlabs-packer","description":"","fork":false,"url":"https://api.github.com/repos/puppetlabs/puppetlabs-packer","forks_url":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/forks","keys_url":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/teams","hooks_url":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/events","assignees_url":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/tags","blobs_url":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/subscription","commits_url":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/merges","archive_url":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/downloads","issues_url":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/releases{/id}","deployments_url":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/deployments","created_at":"2014-06-19T18:43:51Z","updated_at":"2016-06-07T12:37:25Z","pushed_at":"2016-06-17T16:52:57Z","git_url":"git://github.com/puppetlabs/puppetlabs-packer.git","ssh_url":"git@github.com:puppetlabs/puppetlabs-packer.git","clone_url":"https://github.com/puppetlabs/puppetlabs-packer.git","svn_url":"https://github.com/puppetlabs/puppetlabs-packer","homepage":null,"size":367,"stargazers_count":40,"watchers_count":40,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":40,"mirror_url":null,"open_issues_count":2,"forks":40,"open_issues":2,"watchers":40,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/pulls/77"},"html":{"href":"https://github.com/puppetlabs/puppetlabs-packer/pull/77"},"issue":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/issues/77"},"comments":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/issues/77/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/pulls/77/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/pulls/77/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/statuses/b94114ba10ac63326eaa6382ed104609e6524e9d"}}}}
{"actor":{"display_login":"shermdog"}}