{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/7169","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/7169/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/7169/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/7169/events","html_url":"https://github.com/nodejs/node/pull/7169","id":158580818,"number":7169,"title":"Backport important Buffer changes to v5.x","user":{"login":"ChALkeR","id":291301,"avatar_url":"https://avatars.githubusercontent.com/u/291301?v=3","gravatar_id":"","url":"https://api.github.com/users/ChALkeR","html_url":"https://github.com/ChALkeR","followers_url":"https://api.github.com/users/ChALkeR/followers","following_url":"https://api.github.com/users/ChALkeR/following{/other_user}","gists_url":"https://api.github.com/users/ChALkeR/gists{/gist_id}","starred_url":"https://api.github.com/users/ChALkeR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChALkeR/subscriptions","organizations_url":"https://api.github.com/users/ChALkeR/orgs","repos_url":"https://api.github.com/users/ChALkeR/repos","events_url":"https://api.github.com/users/ChALkeR/events{/privacy}","received_events_url":"https://api.github.com/users/ChALkeR/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/nodejs/node/labels/buffer","name":"buffer","color":"f7c6c7"},{"url":"https://api.github.com/repos/nodejs/node/labels/semver-minor","name":"semver-minor","color":"fef2c0"},{"url":"https://api.github.com/repos/nodejs/node/labels/v5.x","name":"v5.x","color":"006b75"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-06-05T23:24:36Z","updated_at":"2016-06-05T23:49:02Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/7169","html_url":"https://github.com/nodejs/node/pull/7169","diff_url":"https://github.com/nodejs/node/pull/7169.diff","patch_url":"https://github.com/nodejs/node/pull/7169.patch"},"body":"This backports four `Buffer`-related commits to 5.x\r\n\r\n1. `allocUnsafeSlow` introduction from #5833.\r\n \r\n `Buffer.alloc` and `Buffer.allocUnsafe` are already backported to 5.x, while `Buffer.allosUnsafeSlow` isn't — that could be unexpected by users. The good thing is that `allocUnsafeSlow` (as `SlowBuffer`) is hopefully rarely used.\r\n \r\n This is a backport and was significantly changed from the original commit — it does not modify any existing code or tests, it just adds the new API method and tests for it. No deprecation is introduced in the docs.\r\n\r\n2. `safeguard against accidental kNoZeroFill` — security-related, safeguards against various `kNoZeroFill` errors.\r\n \r\n This landed cleanly.\r\n\r\n3. `ignore negative allocation lengths` from #7051 — security-related.\r\n \r\n This landed cleanly.\r\n\r\n4. `add buffer testcase for resetting kZeroFill` from #7093 — testcase for change (2).\r\n \r\n This landed cleanly.\r\n\r\n/cc @jasnell @trevnorris @bnoordhuis @addaleax \r\n"},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/223845446","html_url":"https://github.com/nodejs/node/pull/7169#issuecomment-223845446","issue_url":"https://api.github.com/repos/nodejs/node/issues/7169","id":223845446,"user":{"login":"ChALkeR","id":291301,"avatar_url":"https://avatars.githubusercontent.com/u/291301?v=3","gravatar_id":"","url":"https://api.github.com/users/ChALkeR","html_url":"https://github.com/ChALkeR","followers_url":"https://api.github.com/users/ChALkeR/followers","following_url":"https://api.github.com/users/ChALkeR/following{/other_user}","gists_url":"https://api.github.com/users/ChALkeR/gists{/gist_id}","starred_url":"https://api.github.com/users/ChALkeR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChALkeR/subscriptions","organizations_url":"https://api.github.com/users/ChALkeR/orgs","repos_url":"https://api.github.com/users/ChALkeR/repos","events_url":"https://api.github.com/users/ChALkeR/events{/privacy}","received_events_url":"https://api.github.com/users/ChALkeR/received_events","type":"User","site_admin":false},"created_at":"2016-06-05T23:49:02Z","updated_at":"2016-06-05T23:49:02Z","body":"Ah, sorry. At least one commit here was actually backported to 5.x, my local copy somewhy didn't get updated. Will rebase in a moment, it will be three commits here =)."}}
{"actor":{"display_login":"ChALkeR"}}