{"action":"opened","number":24,"pull_request":{"url":"https://api.github.com/repos/Beh01der/EasyFlow/pulls/24","id":74216957,"html_url":"https://github.com/Beh01der/EasyFlow/pull/24","diff_url":"https://github.com/Beh01der/EasyFlow/pull/24.diff","patch_url":"https://github.com/Beh01der/EasyFlow/pull/24.patch","issue_url":"https://api.github.com/repos/Beh01der/EasyFlow/issues/24","number":24,"state":"open","locked":false,"title":"Do not swallow interrupts in awaitTermination","user":{"login":"mpontes","id":868456,"avatar_url":"https://avatars.githubusercontent.com/u/868456?v=3","gravatar_id":"","url":"https://api.github.com/users/mpontes","html_url":"https://github.com/mpontes","followers_url":"https://api.github.com/users/mpontes/followers","following_url":"https://api.github.com/users/mpontes/following{/other_user}","gists_url":"https://api.github.com/users/mpontes/gists{/gist_id}","starred_url":"https://api.github.com/users/mpontes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpontes/subscriptions","organizations_url":"https://api.github.com/users/mpontes/orgs","repos_url":"https://api.github.com/users/mpontes/repos","events_url":"https://api.github.com/users/mpontes/events{/privacy}","received_events_url":"https://api.github.com/users/mpontes/received_events","type":"User","site_admin":false},"body":"`awaitTermination` in `StatefulContext` seems like it's about to do the right thing and put back the thread's interrupted bit if it gets interrupted while waiting, but instead it calls the wrong method*. This means that once `awaitTermination`, calling code will have no idea the thread was interrupted.\r\n\r\nThis PR fixes this by putting the thread's interrupt flag back, so calling code can do something with this information if it wants.\r\n\r\n\\* - Regardless of intention, this has to be the wrong method because `Thread.interrupted()` is 100% guaranteed to do nothing  in this case, the thread's interrupted state just got reset as we're catching InterruptedException, `Thread.interrupted()` will just return false and not change anything.","created_at":"2016-06-17T09:55:28Z","updated_at":"2016-06-17T09:55:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Beh01der/EasyFlow/pulls/24/commits","review_comments_url":"https://api.github.com/repos/Beh01der/EasyFlow/pulls/24/comments","review_comment_url":"https://api.github.com/repos/Beh01der/EasyFlow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Beh01der/EasyFlow/issues/24/comments","statuses_url":"https://api.github.com/repos/Beh01der/EasyFlow/statuses/d20b9fcc989561e135ea595aecc6b15c414b4fb7","head":{"label":"mpontes:fix-interrupt-swallowing","ref":"fix-interrupt-swallowing","sha":"d20b9fcc989561e135ea595aecc6b15c414b4fb7","user":{"login":"mpontes","id":868456,"avatar_url":"https://avatars.githubusercontent.com/u/868456?v=3","gravatar_id":"","url":"https://api.github.com/users/mpontes","html_url":"https://github.com/mpontes","followers_url":"https://api.github.com/users/mpontes/followers","following_url":"https://api.github.com/users/mpontes/following{/other_user}","gists_url":"https://api.github.com/users/mpontes/gists{/gist_id}","starred_url":"https://api.github.com/users/mpontes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpontes/subscriptions","organizations_url":"https://api.github.com/users/mpontes/orgs","repos_url":"https://api.github.com/users/mpontes/repos","events_url":"https://api.github.com/users/mpontes/events{/privacy}","received_events_url":"https://api.github.com/users/mpontes/received_events","type":"User","site_admin":false},"repo":{"id":61363116,"name":"EasyFlow","full_name":"mpontes/EasyFlow","owner":{"login":"mpontes","id":868456,"avatar_url":"https://avatars.githubusercontent.com/u/868456?v=3","gravatar_id":"","url":"https://api.github.com/users/mpontes","html_url":"https://github.com/mpontes","followers_url":"https://api.github.com/users/mpontes/followers","following_url":"https://api.github.com/users/mpontes/following{/other_user}","gists_url":"https://api.github.com/users/mpontes/gists{/gist_id}","starred_url":"https://api.github.com/users/mpontes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpontes/subscriptions","organizations_url":"https://api.github.com/users/mpontes/orgs","repos_url":"https://api.github.com/users/mpontes/repos","events_url":"https://api.github.com/users/mpontes/events{/privacy}","received_events_url":"https://api.github.com/users/mpontes/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mpontes/EasyFlow","description":"EasyFlow - Simple and lightweight Finite State Machine for Java","fork":true,"url":"https://api.github.com/repos/mpontes/EasyFlow","forks_url":"https://api.github.com/repos/mpontes/EasyFlow/forks","keys_url":"https://api.github.com/repos/mpontes/EasyFlow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mpontes/EasyFlow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mpontes/EasyFlow/teams","hooks_url":"https://api.github.com/repos/mpontes/EasyFlow/hooks","issue_events_url":"https://api.github.com/repos/mpontes/EasyFlow/issues/events{/number}","events_url":"https://api.github.com/repos/mpontes/EasyFlow/events","assignees_url":"https://api.github.com/repos/mpontes/EasyFlow/assignees{/user}","branches_url":"https://api.github.com/repos/mpontes/EasyFlow/branches{/branch}","tags_url":"https://api.github.com/repos/mpontes/EasyFlow/tags","blobs_url":"https://api.github.com/repos/mpontes/EasyFlow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mpontes/EasyFlow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mpontes/EasyFlow/git/refs{/sha}","trees_url":"https://api.github.com/repos/mpontes/EasyFlow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mpontes/EasyFlow/statuses/{sha}","languages_url":"https://api.github.com/repos/mpontes/EasyFlow/languages","stargazers_url":"https://api.github.com/repos/mpontes/EasyFlow/stargazers","contributors_url":"https://api.github.com/repos/mpontes/EasyFlow/contributors","subscribers_url":"https://api.github.com/repos/mpontes/EasyFlow/subscribers","subscription_url":"https://api.github.com/repos/mpontes/EasyFlow/subscription","commits_url":"https://api.github.com/repos/mpontes/EasyFlow/commits{/sha}","git_commits_url":"https://api.github.com/repos/mpontes/EasyFlow/git/commits{/sha}","comments_url":"https://api.github.com/repos/mpontes/EasyFlow/comments{/number}","issue_comment_url":"https://api.github.com/repos/mpontes/EasyFlow/issues/comments{/number}","contents_url":"https://api.github.com/repos/mpontes/EasyFlow/contents/{+path}","compare_url":"https://api.github.com/repos/mpontes/EasyFlow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mpontes/EasyFlow/merges","archive_url":"https://api.github.com/repos/mpontes/EasyFlow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mpontes/EasyFlow/downloads","issues_url":"https://api.github.com/repos/mpontes/EasyFlow/issues{/number}","pulls_url":"https://api.github.com/repos/mpontes/EasyFlow/pulls{/number}","milestones_url":"https://api.github.com/repos/mpontes/EasyFlow/milestones{/number}","notifications_url":"https://api.github.com/repos/mpontes/EasyFlow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mpontes/EasyFlow/labels{/name}","releases_url":"https://api.github.com/repos/mpontes/EasyFlow/releases{/id}","deployments_url":"https://api.github.com/repos/mpontes/EasyFlow/deployments","created_at":"2016-06-17T09:40:20Z","updated_at":"2016-06-17T09:40:20Z","pushed_at":"2016-06-17T09:41:59Z","git_url":"git://github.com/mpontes/EasyFlow.git","ssh_url":"git@github.com:mpontes/EasyFlow.git","clone_url":"https://github.com/mpontes/EasyFlow.git","svn_url":"https://github.com/mpontes/EasyFlow","homepage":"http://datasymphony.com.au/open-source/easyflow","size":73,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Beh01der:master","ref":"master","sha":"30ff28708e9ad322e778d3d94477c2a95231f73e","user":{"login":"Beh01der","id":3096835,"avatar_url":"https://avatars.githubusercontent.com/u/3096835?v=3","gravatar_id":"","url":"https://api.github.com/users/Beh01der","html_url":"https://github.com/Beh01der","followers_url":"https://api.github.com/users/Beh01der/followers","following_url":"https://api.github.com/users/Beh01der/following{/other_user}","gists_url":"https://api.github.com/users/Beh01der/gists{/gist_id}","starred_url":"https://api.github.com/users/Beh01der/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Beh01der/subscriptions","organizations_url":"https://api.github.com/users/Beh01der/orgs","repos_url":"https://api.github.com/users/Beh01der/repos","events_url":"https://api.github.com/users/Beh01der/events{/privacy}","received_events_url":"https://api.github.com/users/Beh01der/received_events","type":"User","site_admin":false},"repo":{"id":9384432,"name":"EasyFlow","full_name":"Beh01der/EasyFlow","owner":{"login":"Beh01der","id":3096835,"avatar_url":"https://avatars.githubusercontent.com/u/3096835?v=3","gravatar_id":"","url":"https://api.github.com/users/Beh01der","html_url":"https://github.com/Beh01der","followers_url":"https://api.github.com/users/Beh01der/followers","following_url":"https://api.github.com/users/Beh01der/following{/other_user}","gists_url":"https://api.github.com/users/Beh01der/gists{/gist_id}","starred_url":"https://api.github.com/users/Beh01der/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Beh01der/subscriptions","organizations_url":"https://api.github.com/users/Beh01der/orgs","repos_url":"https://api.github.com/users/Beh01der/repos","events_url":"https://api.github.com/users/Beh01der/events{/privacy}","received_events_url":"https://api.github.com/users/Beh01der/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Beh01der/EasyFlow","description":"EasyFlow - Simple and lightweight Finite State Machine for Java","fork":false,"url":"https://api.github.com/repos/Beh01der/EasyFlow","forks_url":"https://api.github.com/repos/Beh01der/EasyFlow/forks","keys_url":"https://api.github.com/repos/Beh01der/EasyFlow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Beh01der/EasyFlow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Beh01der/EasyFlow/teams","hooks_url":"https://api.github.com/repos/Beh01der/EasyFlow/hooks","issue_events_url":"https://api.github.com/repos/Beh01der/EasyFlow/issues/events{/number}","events_url":"https://api.github.com/repos/Beh01der/EasyFlow/events","assignees_url":"https://api.github.com/repos/Beh01der/EasyFlow/assignees{/user}","branches_url":"https://api.github.com/repos/Beh01der/EasyFlow/branches{/branch}","tags_url":"https://api.github.com/repos/Beh01der/EasyFlow/tags","blobs_url":"https://api.github.com/repos/Beh01der/EasyFlow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Beh01der/EasyFlow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Beh01der/EasyFlow/git/refs{/sha}","trees_url":"https://api.github.com/repos/Beh01der/EasyFlow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Beh01der/EasyFlow/statuses/{sha}","languages_url":"https://api.github.com/repos/Beh01der/EasyFlow/languages","stargazers_url":"https://api.github.com/repos/Beh01der/EasyFlow/stargazers","contributors_url":"https://api.github.com/repos/Beh01der/EasyFlow/contributors","subscribers_url":"https://api.github.com/repos/Beh01der/EasyFlow/subscribers","subscription_url":"https://api.github.com/repos/Beh01der/EasyFlow/subscription","commits_url":"https://api.github.com/repos/Beh01der/EasyFlow/commits{/sha}","git_commits_url":"https://api.github.com/repos/Beh01der/EasyFlow/git/commits{/sha}","comments_url":"https://api.github.com/repos/Beh01der/EasyFlow/comments{/number}","issue_comment_url":"https://api.github.com/repos/Beh01der/EasyFlow/issues/comments{/number}","contents_url":"https://api.github.com/repos/Beh01der/EasyFlow/contents/{+path}","compare_url":"https://api.github.com/repos/Beh01der/EasyFlow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Beh01der/EasyFlow/merges","archive_url":"https://api.github.com/repos/Beh01der/EasyFlow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Beh01der/EasyFlow/downloads","issues_url":"https://api.github.com/repos/Beh01der/EasyFlow/issues{/number}","pulls_url":"https://api.github.com/repos/Beh01der/EasyFlow/pulls{/number}","milestones_url":"https://api.github.com/repos/Beh01der/EasyFlow/milestones{/number}","notifications_url":"https://api.github.com/repos/Beh01der/EasyFlow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Beh01der/EasyFlow/labels{/name}","releases_url":"https://api.github.com/repos/Beh01der/EasyFlow/releases{/id}","deployments_url":"https://api.github.com/repos/Beh01der/EasyFlow/deployments","created_at":"2013-04-12T02:00:25Z","updated_at":"2016-06-15T13:09:03Z","pushed_at":"2016-06-17T09:55:28Z","git_url":"git://github.com/Beh01der/EasyFlow.git","ssh_url":"git@github.com:Beh01der/EasyFlow.git","clone_url":"https://github.com/Beh01der/EasyFlow.git","svn_url":"https://github.com/Beh01der/EasyFlow","homepage":"http://datasymphony.com.au/open-source/easyflow","size":498,"stargazers_count":178,"watchers_count":178,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":31,"mirror_url":null,"open_issues_count":7,"forks":31,"open_issues":7,"watchers":178,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Beh01der/EasyFlow/pulls/24"},"html":{"href":"https://github.com/Beh01der/EasyFlow/pull/24"},"issue":{"href":"https://api.github.com/repos/Beh01der/EasyFlow/issues/24"},"comments":{"href":"https://api.github.com/repos/Beh01der/EasyFlow/issues/24/comments"},"review_comments":{"href":"https://api.github.com/repos/Beh01der/EasyFlow/pulls/24/comments"},"review_comment":{"href":"https://api.github.com/repos/Beh01der/EasyFlow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Beh01der/EasyFlow/pulls/24/commits"},"statuses":{"href":"https://api.github.com/repos/Beh01der/EasyFlow/statuses/d20b9fcc989561e135ea595aecc6b15c414b4fb7"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"mpontes"}}