{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/90648769","pull_request_review_id":11167706,"id":90648769,"diff_hunk":"@@ -105,6 +105,23 @@ func EstablishMasterConnection(s *kubeadmapi.NodeConfiguration, clusterInfo *kub\n \treturn establishedConnection, nil\n }\n \n+// check to see if there are other nodes in the cluster with identical node names.\n+func CheckForNodeNameDuplicates(connection *ConnectionDetails) error {\n+\thostName, err := os.Hostname()\n+\tif err != nil {\n+\t\treturn fmt.Errorf(\"<node/bootstrap> failed to get node hostname [%v]\", err)","path":"cmd/kubeadm/app/node/bootstrap.go","position":49,"original_position":49,"commit_id":"a2f6a3e0c95c35ab53bccf436363a20667862fb0","original_commit_id":"a2f6a3e0c95c35ab53bccf436363a20667862fb0","user":{"login":"luxas","id":5442475,"avatar_url":"https://avatars.githubusercontent.com/u/5442475?v=3","gravatar_id":"","url":"https://api.github.com/users/luxas","html_url":"https://github.com/luxas","followers_url":"https://api.github.com/users/luxas/followers","following_url":"https://api.github.com/users/luxas/following{/other_user}","gists_url":"https://api.github.com/users/luxas/gists{/gist_id}","starred_url":"https://api.github.com/users/luxas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luxas/subscriptions","organizations_url":"https://api.github.com/users/luxas/orgs","repos_url":"https://api.github.com/users/luxas/repos","events_url":"https://api.github.com/users/luxas/events{/privacy}","received_events_url":"https://api.github.com/users/luxas/received_events","type":"User","site_admin":false},"body":"you can omit the `<node/bootstrap>` in errors","created_at":"2016-12-02T14:20:41Z","updated_at":"2016-12-02T14:20:41Z","html_url":"https://github.com/kubernetes/kubernetes/pull/37084#discussion_r90648769","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/37084","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/90648769"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/37084#discussion_r90648769"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/37084"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/37084","id":94356467,"html_url":"https://github.com/kubernetes/kubernetes/pull/37084","diff_url":"https://github.com/kubernetes/kubernetes/pull/37084.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/37084.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/37084","number":37084,"state":"open","locked":false,"title":"[kubeadm] Fail fast if there already is a node in the cluster with that name","user":{"login":"kenan435","id":2983320,"avatar_url":"https://avatars.githubusercontent.com/u/2983320?v=3","gravatar_id":"","url":"https://api.github.com/users/kenan435","html_url":"https://github.com/kenan435","followers_url":"https://api.github.com/users/kenan435/followers","following_url":"https://api.github.com/users/kenan435/following{/other_user}","gists_url":"https://api.github.com/users/kenan435/gists{/gist_id}","starred_url":"https://api.github.com/users/kenan435/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kenan435/subscriptions","organizations_url":"https://api.github.com/users/kenan435/orgs","repos_url":"https://api.github.com/users/kenan435/repos","events_url":"https://api.github.com/users/kenan435/events{/privacy}","received_events_url":"https://api.github.com/users/kenan435/received_events","type":"User","site_admin":false},"body":"kubeadm Fail fast if there is another node with the same name already in the cluster. \r\n\r\nFixes #36255\r\n\r\ncc @kubernetes/sig-cluster-federation\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.kubernetes.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.kubernetes.io/reviews/kubernetes/kubernetes/37084)\n<!-- Reviewable:end -->\n","created_at":"2016-11-18T12:50:47Z","updated_at":"2016-12-02T14:24:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"39cc31a3eee36106ad38ba68817cb4117f49115f","assignee":{"login":"errordeveloper","id":251467,"avatar_url":"https://avatars.githubusercontent.com/u/251467?v=3","gravatar_id":"","url":"https://api.github.com/users/errordeveloper","html_url":"https://github.com/errordeveloper","followers_url":"https://api.github.com/users/errordeveloper/followers","following_url":"https://api.github.com/users/errordeveloper/following{/other_user}","gists_url":"https://api.github.com/users/errordeveloper/gists{/gist_id}","starred_url":"https://api.github.com/users/errordeveloper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/errordeveloper/subscriptions","organizations_url":"https://api.github.com/users/errordeveloper/orgs","repos_url":"https://api.github.com/users/errordeveloper/repos","events_url":"https://api.github.com/users/errordeveloper/events{/privacy}","received_events_url":"https://api.github.com/users/errordeveloper/received_events","type":"User","site_admin":false},"assignees":[{"login":"errordeveloper","id":251467,"avatar_url":"https://avatars.githubusercontent.com/u/251467?v=3","gravatar_id":"","url":"https://api.github.com/users/errordeveloper","html_url":"https://github.com/errordeveloper","followers_url":"https://api.github.com/users/errordeveloper/followers","following_url":"https://api.github.com/users/errordeveloper/following{/other_user}","gists_url":"https://api.github.com/users/errordeveloper/gists{/gist_id}","starred_url":"https://api.github.com/users/errordeveloper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/errordeveloper/subscriptions","organizations_url":"https://api.github.com/users/errordeveloper/orgs","repos_url":"https://api.github.com/users/errordeveloper/repos","events_url":"https://api.github.com/users/errordeveloper/events{/privacy}","received_events_url":"https://api.github.com/users/errordeveloper/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/37084/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/37084/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/37084/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/a2f6a3e0c95c35ab53bccf436363a20667862fb0","head":{"label":"kenan435:fail-fast-on-duplicate-node","ref":"fail-fast-on-duplicate-node","sha":"a2f6a3e0c95c35ab53bccf436363a20667862fb0","user":{"login":"kenan435","id":2983320,"avatar_url":"https://avatars.githubusercontent.com/u/2983320?v=3","gravatar_id":"","url":"https://api.github.com/users/kenan435","html_url":"https://github.com/kenan435","followers_url":"https://api.github.com/users/kenan435/followers","following_url":"https://api.github.com/users/kenan435/following{/other_user}","gists_url":"https://api.github.com/users/kenan435/gists{/gist_id}","starred_url":"https://api.github.com/users/kenan435/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kenan435/subscriptions","organizations_url":"https://api.github.com/users/kenan435/orgs","repos_url":"https://api.github.com/users/kenan435/repos","events_url":"https://api.github.com/users/kenan435/events{/privacy}","received_events_url":"https://api.github.com/users/kenan435/received_events","type":"User","site_admin":false},"repo":{"id":70801733,"name":"kubernetes","full_name":"kenan435/kubernetes","owner":{"login":"kenan435","id":2983320,"avatar_url":"https://avatars.githubusercontent.com/u/2983320?v=3","gravatar_id":"","url":"https://api.github.com/users/kenan435","html_url":"https://github.com/kenan435","followers_url":"https://api.github.com/users/kenan435/followers","following_url":"https://api.github.com/users/kenan435/following{/other_user}","gists_url":"https://api.github.com/users/kenan435/gists{/gist_id}","starred_url":"https://api.github.com/users/kenan435/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kenan435/subscriptions","organizations_url":"https://api.github.com/users/kenan435/orgs","repos_url":"https://api.github.com/users/kenan435/repos","events_url":"https://api.github.com/users/kenan435/events{/privacy}","received_events_url":"https://api.github.com/users/kenan435/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kenan435/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":true,"url":"https://api.github.com/repos/kenan435/kubernetes","forks_url":"https://api.github.com/repos/kenan435/kubernetes/forks","keys_url":"https://api.github.com/repos/kenan435/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kenan435/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kenan435/kubernetes/teams","hooks_url":"https://api.github.com/repos/kenan435/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kenan435/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kenan435/kubernetes/events","assignees_url":"https://api.github.com/repos/kenan435/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kenan435/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kenan435/kubernetes/tags","blobs_url":"https://api.github.com/repos/kenan435/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kenan435/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kenan435/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kenan435/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kenan435/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kenan435/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kenan435/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kenan435/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kenan435/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kenan435/kubernetes/subscription","commits_url":"https://api.github.com/repos/kenan435/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kenan435/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kenan435/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kenan435/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kenan435/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kenan435/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kenan435/kubernetes/merges","archive_url":"https://api.github.com/repos/kenan435/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kenan435/kubernetes/downloads","issues_url":"https://api.github.com/repos/kenan435/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kenan435/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kenan435/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kenan435/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kenan435/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kenan435/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kenan435/kubernetes/deployments","created_at":"2016-10-13T11:56:24Z","updated_at":"2016-10-13T11:57:00Z","pushed_at":"2016-12-02T12:59:07Z","git_url":"git://github.com/kenan435/kubernetes.git","ssh_url":"git@github.com:kenan435/kubernetes.git","clone_url":"https://github.com/kenan435/kubernetes.git","svn_url":"https://github.com/kenan435/kubernetes","homepage":"http://kubernetes.io","size":357880,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"251333971ddfa2c449098bb9c578f79926cb7c35","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-12-02T14:16:16Z","pushed_at":"2016-12-02T14:20:00Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":650506,"stargazers_count":18851,"watchers_count":18851,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6256,"mirror_url":null,"open_issues_count":5375,"forks":6256,"open_issues":5375,"watchers":18851,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/37084"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/37084"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/37084"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/37084/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/37084/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/37084/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/a2f6a3e0c95c35ab53bccf436363a20667862fb0"}}}}
{"actor":{"display_login":"luxas"}}