{"action":"created","issue":{"url":"https://api.github.com/repos/ConsenSys/Tokens/issues/7","repository_url":"https://api.github.com/repos/ConsenSys/Tokens","labels_url":"https://api.github.com/repos/ConsenSys/Tokens/issues/7/labels{/name}","comments_url":"https://api.github.com/repos/ConsenSys/Tokens/issues/7/comments","events_url":"https://api.github.com/repos/ConsenSys/Tokens/issues/7/events","html_url":"https://github.com/ConsenSys/Tokens/issues/7","id":134026068,"number":7,"title":"Add throw on fallback function to StandardToken.sol?","user":{"login":"simondlr","id":716965,"avatar_url":"https://avatars.githubusercontent.com/u/716965?v=3","gravatar_id":"","url":"https://api.github.com/users/simondlr","html_url":"https://github.com/simondlr","followers_url":"https://api.github.com/users/simondlr/followers","following_url":"https://api.github.com/users/simondlr/following{/other_user}","gists_url":"https://api.github.com/users/simondlr/gists{/gist_id}","starred_url":"https://api.github.com/users/simondlr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simondlr/subscriptions","organizations_url":"https://api.github.com/users/simondlr/orgs","repos_url":"https://api.github.com/users/simondlr/repos","events_url":"https://api.github.com/users/simondlr/events{/privacy}","received_events_url":"https://api.github.com/users/simondlr/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2016-02-16T16:24:17Z","updated_at":"2016-02-17T17:44:03Z","closed_at":"2016-02-17T17:44:03Z","body":"@alexvandesande standard token has the fallback function implement a throw(), implying that whenever Ether is sent to it, it automatically reverts. This causes the possibility for Ether to get locked up in the contract to not happen. \r\n\r\nSee here: https://gist.github.com/alexvandesande/0d1a998d949e26942212\r\n\r\nQuestion: Should this be in this repo's current standard token code? Only reason why I feel this should not be the case is that one could create an etherbank contract to extend token functionality to Ether itself. But then would be a substantially different one as well.\r\n\r\nSo gut feel, yes. Add it in."},"comment":{"url":"https://api.github.com/repos/ConsenSys/Tokens/issues/comments/185321454","html_url":"https://github.com/ConsenSys/Tokens/issues/7#issuecomment-185321454","issue_url":"https://api.github.com/repos/ConsenSys/Tokens/issues/7","id":185321454,"user":{"login":"simondlr","id":716965,"avatar_url":"https://avatars.githubusercontent.com/u/716965?v=3","gravatar_id":"","url":"https://api.github.com/users/simondlr","html_url":"https://github.com/simondlr","followers_url":"https://api.github.com/users/simondlr/followers","following_url":"https://api.github.com/users/simondlr/following{/other_user}","gists_url":"https://api.github.com/users/simondlr/gists{/gist_id}","starred_url":"https://api.github.com/users/simondlr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simondlr/subscriptions","organizations_url":"https://api.github.com/users/simondlr/orgs","repos_url":"https://api.github.com/users/simondlr/repos","events_url":"https://api.github.com/users/simondlr/events{/privacy}","received_events_url":"https://api.github.com/users/simondlr/received_events","type":"User","site_admin":false},"created_at":"2016-02-17T17:44:03Z","updated_at":"2016-02-17T17:44:03Z","body":"Added in. Wanted to do a more proper test, but estimateGas wasn't behaving like I thought it would (it would be nice if it gave gas costs in the event of exceptions)."}}