{"action":"created","issue":{"url":"https://api.github.com/repos/akhodakivskiy/VimFx/issues/789","repository_url":"https://api.github.com/repos/akhodakivskiy/VimFx","labels_url":"https://api.github.com/repos/akhodakivskiy/VimFx/issues/789/labels{/name}","comments_url":"https://api.github.com/repos/akhodakivskiy/VimFx/issues/789/comments","events_url":"https://api.github.com/repos/akhodakivskiy/VimFx/issues/789/events","html_url":"https://github.com/akhodakivskiy/VimFx/pull/789","id":170990136,"number":789,"title":"Pentadactyl hints","user":{"login":"doy","id":78547,"avatar_url":"https://avatars.githubusercontent.com/u/78547?v=3","gravatar_id":"","url":"https://api.github.com/users/doy","html_url":"https://github.com/doy","followers_url":"https://api.github.com/users/doy/followers","following_url":"https://api.github.com/users/doy/following{/other_user}","gists_url":"https://api.github.com/users/doy/gists{/gist_id}","starred_url":"https://api.github.com/users/doy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doy/subscriptions","organizations_url":"https://api.github.com/users/doy/orgs","repos_url":"https://api.github.com/users/doy/repos","events_url":"https://api.github.com/users/doy/events{/privacy}","received_events_url":"https://api.github.com/users/doy/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-08-13T03:15:01Z","updated_at":"2016-08-13T16:45:18Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/akhodakivskiy/VimFx/pulls/789","html_url":"https://github.com/akhodakivskiy/VimFx/pull/789","diff_url":"https://github.com/akhodakivskiy/VimFx/pull/789.diff","patch_url":"https://github.com/akhodakivskiy/VimFx/pull/789.patch"},"body":"This is an attempt at fixing #340. It's not complete yet (I haven't updated the documentation, squashed commits, etc), but I wanted to get an idea of if this looks plausible, since it's my first time writing CoffeeScript or Firefox plugins.\r\n\r\nSome immediate questions that come to mind:\r\n- I decided to keep it permanently enabled, since it doesn't actually interfere with using hints mode by just typing hint characters (since it prefers matching hint characters to matching the text). Is this reasonable, or would there be too much confusion if someone accidentally typed a key that wasn't a hint char? I'm also fine with putting it behind an option, or as a separate mode entirely.\r\n- Is it reasonable to reuse the `hint_timeout` option for the length of time to suppress key input after a successful match (see the last commit), or should that be its own option?\r\n- I wasn't able to get the test suite to work, since as of Firefox 48, loading unsigned addons is no longer supported, and so I was unable to get the Extension Auto-Installer extension to do anything (I just tested by hand using the \"Load Temporary Add-on\" button in `about:debugging`). Is there another way to run tests?\r\n\r\nI'd also be interested in any other feedback you have. Let me know what you think, and I can get the branch cleaned up once it's ready to merge."},"comment":{"url":"https://api.github.com/repos/akhodakivskiy/VimFx/issues/comments/239630187","html_url":"https://github.com/akhodakivskiy/VimFx/pull/789#issuecomment-239630187","issue_url":"https://api.github.com/repos/akhodakivskiy/VimFx/issues/789","id":239630187,"user":{"login":"doy","id":78547,"avatar_url":"https://avatars.githubusercontent.com/u/78547?v=3","gravatar_id":"","url":"https://api.github.com/users/doy","html_url":"https://github.com/doy","followers_url":"https://api.github.com/users/doy/followers","following_url":"https://api.github.com/users/doy/following{/other_user}","gists_url":"https://api.github.com/users/doy/gists{/gist_id}","starred_url":"https://api.github.com/users/doy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doy/subscriptions","organizations_url":"https://api.github.com/users/doy/orgs","repos_url":"https://api.github.com/users/doy/repos","events_url":"https://api.github.com/users/doy/events{/privacy}","received_events_url":"https://api.github.com/users/doy/received_events","type":"User","site_admin":false},"created_at":"2016-08-13T16:45:18Z","updated_at":"2016-08-13T16:45:18Z","body":"> How close is this implementation compared to Pentadactyl? What changes did you take the liberty to make?\r\n\r\nI didn't intentionally change anything from Pentadactyl, but I'm also not really familiar with the implementation details there, so it's possible I missed something - I just based the implementation on how I remember it working from a user's perspective. I did leave out the option that it had for different styles of text matching, just hardcoding substring matching for now - this could potentially be added in the future if someone cares enough.\r\n\r\n> To run the test suite, all that needs to be done is to compile an .xpi with the tests included in the output. The tests then run each time VimFx bootstraps. Using your workflow, running `gulp xpi --test` instead of `gulp xpi` should do the trick.\r\n\r\nYup, this works, thanks! Looks like all of the existing tests are still passing.\r\n\r\n> It would be annoying if you try to search for text and you open a hint instead.\r\n\r\nWhat do you mean by this? When would this come up while searching for text?"}}
{"actor":{"display_login":"doy"}}