{"action":"created","issue":{"url":"https://api.github.com/repos/trilinos/Trilinos/issues/725","repository_url":"https://api.github.com/repos/trilinos/Trilinos","labels_url":"https://api.github.com/repos/trilinos/Trilinos/issues/725/labels{/name}","comments_url":"https://api.github.com/repos/trilinos/Trilinos/issues/725/comments","events_url":"https://api.github.com/repos/trilinos/Trilinos/issues/725/events","html_url":"https://github.com/trilinos/Trilinos/issues/725","id":184598330,"number":725,"title":"Nalu diffs due to latest Trilinos update","user":{"login":"spdomin","id":8699324,"avatar_url":"https://avatars.githubusercontent.com/u/8699324?v=3","gravatar_id":"","url":"https://api.github.com/users/spdomin","html_url":"https://github.com/spdomin","followers_url":"https://api.github.com/users/spdomin/followers","following_url":"https://api.github.com/users/spdomin/following{/other_user}","gists_url":"https://api.github.com/users/spdomin/gists{/gist_id}","starred_url":"https://api.github.com/users/spdomin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spdomin/subscriptions","organizations_url":"https://api.github.com/users/spdomin/orgs","repos_url":"https://api.github.com/users/spdomin/repos","events_url":"https://api.github.com/users/spdomin/events{/privacy}","received_events_url":"https://api.github.com/users/spdomin/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/trilinos/Trilinos/labels/performance","name":"performance","color":"bfe5bf"},{"url":"https://api.github.com/repos/trilinos/Trilinos/labels/results%20impacting","name":"results impacting","color":"b60205"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":19,"created_at":"2016-10-22T00:59:00Z","updated_at":"2016-10-27T15:12:40Z","closed_at":null,"body":"Bad test suite as of Trilinos SHA1:\r\n\r\ncommit 5320963fbe2ec9aeba1dc62871e4be4f44961970\r\nAuthor: Tobias Wiesner tawiesn@sandia.gov\r\nDate: Wed Oct 19 14:43:41 2016 -0600\r\n\r\nLast good:\r\n\r\nNaluCFD/Nalu SHA1: d2adbe8\r\nTrilinos/master SHA1: 12fd285b28abeb7336a8d4f17913819b9ce7015b\r\n\r\nThis bisect is complicated in that the builds of Trilinos fail either due to configure errors or flat out build issues."},"comment":{"url":"https://api.github.com/repos/trilinos/Trilinos/issues/comments/256670536","html_url":"https://github.com/trilinos/Trilinos/issues/725#issuecomment-256670536","issue_url":"https://api.github.com/repos/trilinos/Trilinos/issues/725","id":256670536,"user":{"login":"tawiesn","id":12903075,"avatar_url":"https://avatars.githubusercontent.com/u/12903075?v=3","gravatar_id":"","url":"https://api.github.com/users/tawiesn","html_url":"https://github.com/tawiesn","followers_url":"https://api.github.com/users/tawiesn/followers","following_url":"https://api.github.com/users/tawiesn/following{/other_user}","gists_url":"https://api.github.com/users/tawiesn/gists{/gist_id}","starred_url":"https://api.github.com/users/tawiesn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tawiesn/subscriptions","organizations_url":"https://api.github.com/users/tawiesn/orgs","repos_url":"https://api.github.com/users/tawiesn/repos","events_url":"https://api.github.com/users/tawiesn/events{/privacy}","received_events_url":"https://api.github.com/users/tawiesn/received_events","type":"User","site_admin":false},"created_at":"2016-10-27T15:12:40Z","updated_at":"2016-10-27T15:12:40Z","body":"I think, the problem is that the Trilinos and the Nalu point of view differ: from a Trilinos point of view, the master branch never was \"broken\". The patch passed all tests and caused no issues within the Trilinos test suite. It also produced correct results on examples where you know the exact solution. However, from a numerical aspect it showed a different behavior and produced different results for some examples which make look it to brake things in Nalu (and maybe other applications, too).\r\nIn my opinion, the only reasonable way to avoid situations like this is, to extend the Trilinos test suite. Maybe not by adding the Nalu tests to the test suite, but by having an internal policy that requires certain (whatever that means) applications tests to pass before checkin in high-risk patches. It's clear that Nalu would not be the only application we have to test, though. From a practical point of view it would be necessary to make it as easy as possible for Trilinos developers to be able to run all these application tests (Nalu, drekar, albany). It's hard enough to have one or two applications installed on our workstations, properly updated, compiled, etc. I do it for the parts of drekar that i have access to. But even there i have days where drekar is broken and i have to wait until it is fixed, fix it on my own or go back in history and check out an older version..."}}
{"actor":{"display_login":"tawiesn"}}