{"action":"created","issue":{"url":"https://api.github.com/repos/greenplum-db/gpos/issues/22","repository_url":"https://api.github.com/repos/greenplum-db/gpos","labels_url":"https://api.github.com/repos/greenplum-db/gpos/issues/22/labels{/name}","comments_url":"https://api.github.com/repos/greenplum-db/gpos/issues/22/comments","events_url":"https://api.github.com/repos/greenplum-db/gpos/issues/22/events","html_url":"https://github.com/greenplum-db/gpos/pull/22","id":151775286,"number":22,"title":"Make smart pointers great again [#118594399] [#118323445]","user":{"login":"d","id":440892,"avatar_url":"https://avatars.githubusercontent.com/u/440892?v=3","gravatar_id":"","url":"https://api.github.com/users/d","html_url":"https://github.com/d","followers_url":"https://api.github.com/users/d/followers","following_url":"https://api.github.com/users/d/following{/other_user}","gists_url":"https://api.github.com/users/d/gists{/gist_id}","starred_url":"https://api.github.com/users/d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d/subscriptions","organizations_url":"https://api.github.com/users/d/orgs","repos_url":"https://api.github.com/users/d/repos","events_url":"https://api.github.com/users/d/events{/privacy}","received_events_url":"https://api.github.com/users/d/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-04-29T01:02:18Z","updated_at":"2016-04-29T01:02:21Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/greenplum-db/gpos/pulls/22","html_url":"https://github.com/greenplum-db/gpos/pull/22","diff_url":"https://github.com/greenplum-db/gpos/pull/22.diff","patch_url":"https://github.com/greenplum-db/gpos/pull/22.patch"},"body":"This patch makes `gpos::CAutoP` and `gpos::CAutoRef` a bit friendlier to developers: when used with wrong template parameter, they blow up at compile time.\r\n\r\nCorrect usage should always use `CAutoP` with **Non** `CRefCount` object, and `CAutoRef` with `CRefCount` object (which has `Release()` method).\r\n\r\nWe also removed the VERY DANGEROUS `reinterpret_cast` in `CAutoRef::~CAutoRef()`, which would corrupt the object.\r\n\r\n@d and @xinzweb "},"comment":{"url":"https://api.github.com/repos/greenplum-db/gpos/issues/comments/215605028","html_url":"https://github.com/greenplum-db/gpos/pull/22#issuecomment-215605028","issue_url":"https://api.github.com/repos/greenplum-db/gpos/issues/22","id":215605028,"user":{"login":"gpdbdreddbot","id":15618396,"avatar_url":"https://avatars.githubusercontent.com/u/15618396?v=3","gravatar_id":"","url":"https://api.github.com/users/gpdbdreddbot","html_url":"https://github.com/gpdbdreddbot","followers_url":"https://api.github.com/users/gpdbdreddbot/followers","following_url":"https://api.github.com/users/gpdbdreddbot/following{/other_user}","gists_url":"https://api.github.com/users/gpdbdreddbot/gists{/gist_id}","starred_url":"https://api.github.com/users/gpdbdreddbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gpdbdreddbot/subscriptions","organizations_url":"https://api.github.com/users/gpdbdreddbot/orgs","repos_url":"https://api.github.com/users/gpdbdreddbot/repos","events_url":"https://api.github.com/users/gpdbdreddbot/events{/privacy}","received_events_url":"https://api.github.com/users/gpdbdreddbot/received_events","type":"User","site_admin":false},"created_at":"2016-04-29T01:02:21Z","updated_at":"2016-04-29T01:02:21Z","body":"Hello d!\n\nThanks for submitting this pull request!\n\nAll pull request authors must have a Contributor License Agreement (CLA) on-file with us. Please sign the appropriate CLA ([individual](http://greenplum.org/contributor_agreements/GPDB_Pivotal_ICLA.pdf) or [corporate](http://greenplum.org/contributor_agreements/GPDB_Pivotal_CCLA.pdf)).\n\nWhen sending signed CLA please provide your github username in case of individual CLA or the list of github usernames that can make pull requests on behalf of your organization.\n\nIf you are confident that you're covered under a Corporate CLA, please make sure you've publicized your membership in the appropriate Github Org, per [these instructions](https://help.github.com/articles/publicizing-or-concealing-organization-membership/).\n"}}