{"action":"created","issue":{"url":"https://api.github.com/repos/tine20/Tine-2.0-Open-Source-Groupware-and-CRM/issues/18","repository_url":"https://api.github.com/repos/tine20/Tine-2.0-Open-Source-Groupware-and-CRM","labels_url":"https://api.github.com/repos/tine20/Tine-2.0-Open-Source-Groupware-and-CRM/issues/18/labels{/name}","comments_url":"https://api.github.com/repos/tine20/Tine-2.0-Open-Source-Groupware-and-CRM/issues/18/comments","events_url":"https://api.github.com/repos/tine20/Tine-2.0-Open-Source-Groupware-and-CRM/issues/18/events","html_url":"https://github.com/tine20/Tine-2.0-Open-Source-Groupware-and-CRM/pull/18","id":196468955,"number":18,"title":"Config switch for SyncToken support","user":{"login":"ingoratsdorf","id":3344778,"avatar_url":"https://avatars.githubusercontent.com/u/3344778?v=3","gravatar_id":"","url":"https://api.github.com/users/ingoratsdorf","html_url":"https://github.com/ingoratsdorf","followers_url":"https://api.github.com/users/ingoratsdorf/followers","following_url":"https://api.github.com/users/ingoratsdorf/following{/other_user}","gists_url":"https://api.github.com/users/ingoratsdorf/gists{/gist_id}","starred_url":"https://api.github.com/users/ingoratsdorf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ingoratsdorf/subscriptions","organizations_url":"https://api.github.com/users/ingoratsdorf/orgs","repos_url":"https://api.github.com/users/ingoratsdorf/repos","events_url":"https://api.github.com/users/ingoratsdorf/events{/privacy}","received_events_url":"https://api.github.com/users/ingoratsdorf/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-12-19T17:05:53Z","updated_at":"2016-12-21T14:08:41Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/tine20/Tine-2.0-Open-Source-Groupware-and-CRM/pulls/18","html_url":"https://github.com/tine20/Tine-2.0-Open-Source-Groupware-and-CRM/pull/18","diff_url":"https://github.com/tine20/Tine-2.0-Open-Source-Groupware-and-CRM/pull/18.diff","patch_url":"https://github.com/tine20/Tine-2.0-Open-Source-Groupware-and-CRM/pull/18.patch"},"body":"Added a config switch Tinebase_Config::WEBDAV_SYNCTOKEN_ENABLED\r\nthat can switch SyncToken support on or off in config.inc.php"},"comment":{"url":"https://api.github.com/repos/tine20/Tine-2.0-Open-Source-Groupware-and-CRM/issues/comments/268531146","html_url":"https://github.com/tine20/Tine-2.0-Open-Source-Groupware-and-CRM/pull/18#issuecomment-268531146","issue_url":"https://api.github.com/repos/tine20/Tine-2.0-Open-Source-Groupware-and-CRM/issues/18","id":268531146,"user":{"login":"pschuele","id":353947,"avatar_url":"https://avatars.githubusercontent.com/u/353947?v=3","gravatar_id":"","url":"https://api.github.com/users/pschuele","html_url":"https://github.com/pschuele","followers_url":"https://api.github.com/users/pschuele/followers","following_url":"https://api.github.com/users/pschuele/following{/other_user}","gists_url":"https://api.github.com/users/pschuele/gists{/gist_id}","starred_url":"https://api.github.com/users/pschuele/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pschuele/subscriptions","organizations_url":"https://api.github.com/users/pschuele/orgs","repos_url":"https://api.github.com/users/pschuele/repos","events_url":"https://api.github.com/users/pschuele/events{/privacy}","received_events_url":"https://api.github.com/users/pschuele/received_events","type":"User","site_admin":false},"created_at":"2016-12-21T14:08:41Z","updated_at":"2016-12-21T14:08:41Z","body":"hi Ingo,\r\n\r\nsome tests fail because they expect activated sync token handling.\r\n\r\ncould you switch the feature on for the tests or make the default = true?\r\n\r\nand I created a mantis issue for this: https://forge.tine20.org/view.php?id=12452\r\n\r\nhere are the tests:\r\n\r\nThere were 3 failures:\r\n\r\n1) Tinebase_WebDav_Plugin_SyncTokenTest::testGetSupportedReportSetForCalendarNode\r\nFailed asserting that an array contains '{DAV:}sync-collection'.\r\n\r\n/usr/local/share/tine20.git/tests/tine20/Tinebase/WebDav/Plugin/SyncTokenTest.php:103\r\n\r\n2) Tinebase_WebDav_Plugin_SyncTokenTest::testPropfindSyncToken\r\nFailed asserting that '<?xml version=\"1.0\" encoding=\"utf-8\"?>\r\n<d:multistatus xmlns:d=\"DAV:\" xmlns:s=\"http://sabredav.org/ns\"><d:response><d:href>/calendars/49e7039370dc7b71c484661f8c0aefd5a3f0d639/142/</d:href><d:propstat><d:prop><d:sync-token/></d:prop><d:status>HTTP/1.1 404 Not Found</d:status></d:propstat></d:response></d:multistatus>\r\n' contains \"<d:sync-token>http://tine20.net/ns/sync/5</d:sync-token></d:prop><d:status>HTTP/1.1 200 OK</d:status></d:propstat></d:response></d:multistatus>\".\r\n\r\n/usr/local/share/tine20.git/tests/tine20/Tinebase/WebDav/Plugin/SyncTokenTest.php:128\r\n\r\n3) Tinebase_WebDav_Plugin_SyncTokenTest::testSyncCollection\r\nFailed asserting that two strings are equal.\r\n--- Expected\r\n+++ Actual\r\n@@ @@\r\n-'HTTP/1.1 207 Multi-Status'\r\n+'HTTP/1.1 403 Forbidden'\r\n\r\n/usr/local/share/tine20.git/tests/tine20/Tinebase/WebDav/Plugin/SyncTokenTest.php:156\r\n\r\nFAILURES!\r\nTests: 2107, Assertions: 12231, Failures: 3, Incomplete: 17, Skipped: 99.\r\n\r\n"}}
{"actor":{"display_login":"pschuele"}}