{"action":"created","comment":{"url":"https://api.github.com/repos/guardian/frontend/pulls/comments/60065557","id":60065557,"diff_hunk":"@@ -53,22 +53,22 @@ object LogbackConfig {\n       try {\n         val rootLogger = LoggerFactory.getLogger(SLFLogger.ROOT_LOGGER_NAME)\n         asLogBack(rootLogger).map { lb =>\n-            lb.info(\"Configuring Logback\")\n-            val context = lb.getLoggerContext\n-            val layout = makeLayout(makeCustomFields(config.customFields))\n-            val bufferSize = 1000\n-            val appender  = makeKinesisAppender(\n-              layout,\n-              context,\n-              KinesisAppenderConfig(\n-                config.stream,\n-                config.region,\n-                config.awsCredentialsProvider,\n-                bufferSize\n-              )\n+          lb.info(\"Configuring Logback\")\n+          val context = lb.getLoggerContext\n+          val layout = makeLayout(makeCustomFields(config.customFields))\n+          val bufferSize = 1000\n+          val appender  = makeKinesisAppender(\n+            layout,\n+            context,\n+            KinesisAppenderConfig(\n+              config.stream,\n+              config.region,\n+              config.awsCredentialsProvider,\n+              bufferSize\n             )\n-            lb.addAppender(appender)\n-            lb.info(\"Configured Logback\")\n+          )\n+          lb.addAppender(appender)\n+          lb.info(\"Configured Logback\")\n         } getOrElse(PlayLogger.info(\"not running using logback\"))","path":"common/app/common/Logback/LogbackConfig.scala","position":35,"original_position":35,"commit_id":"d79be83e3b07ba5d9e03c7232c45182a5d9f3d71","original_commit_id":"d79be83e3b07ba5d9e03c7232c45182a5d9f3d71","user":{"login":"TBonnin","id":233326,"avatar_url":"https://avatars.githubusercontent.com/u/233326?v=3","gravatar_id":"","url":"https://api.github.com/users/TBonnin","html_url":"https://github.com/TBonnin","followers_url":"https://api.github.com/users/TBonnin/followers","following_url":"https://api.github.com/users/TBonnin/following{/other_user}","gists_url":"https://api.github.com/users/TBonnin/gists{/gist_id}","starred_url":"https://api.github.com/users/TBonnin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TBonnin/subscriptions","organizations_url":"https://api.github.com/users/TBonnin/orgs","repos_url":"https://api.github.com/users/TBonnin/repos","events_url":"https://api.github.com/users/TBonnin/events{/privacy}","received_events_url":"https://api.github.com/users/TBonnin/received_events","type":"User","site_admin":false},"body":"There is not change here, only an indentation fix :)","created_at":"2016-04-18T14:16:20Z","updated_at":"2016-04-18T14:16:20Z","html_url":"https://github.com/guardian/frontend/pull/12593#discussion_r60065557","pull_request_url":"https://api.github.com/repos/guardian/frontend/pulls/12593","_links":{"self":{"href":"https://api.github.com/repos/guardian/frontend/pulls/comments/60065557"},"html":{"href":"https://github.com/guardian/frontend/pull/12593#discussion_r60065557"},"pull_request":{"href":"https://api.github.com/repos/guardian/frontend/pulls/12593"}}},"pull_request":{"url":"https://api.github.com/repos/guardian/frontend/pulls/12593","id":66860514,"html_url":"https://github.com/guardian/frontend/pull/12593","diff_url":"https://github.com/guardian/frontend/pull/12593.diff","patch_url":"https://github.com/guardian/frontend/pull/12593.patch","issue_url":"https://api.github.com/repos/guardian/frontend/issues/12593","number":12593,"state":"open","locked":false,"title":"Use isGuaranteedSwitchOn to get value of Logstash-logging switch","user":{"login":"TBonnin","id":233326,"avatar_url":"https://avatars.githubusercontent.com/u/233326?v=3","gravatar_id":"","url":"https://api.github.com/users/TBonnin","html_url":"https://github.com/TBonnin","followers_url":"https://api.github.com/users/TBonnin/followers","following_url":"https://api.github.com/users/TBonnin/following{/other_user}","gists_url":"https://api.github.com/users/TBonnin/gists{/gist_id}","starred_url":"https://api.github.com/users/TBonnin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TBonnin/subscriptions","organizations_url":"https://api.github.com/users/TBonnin/orgs","repos_url":"https://api.github.com/users/TBonnin/repos","events_url":"https://api.github.com/users/TBonnin/events{/privacy}","received_events_url":"https://api.github.com/users/TBonnin/received_events","type":"User","site_admin":false},"body":"## What does this change?\r\nSince the appender configuration is happening very early on in the lifecycle of the app, the switchboard was not read yet and always returned the safe state of the logstash-logging switch (which is off)\r\n\r\nThis PR makes sure the logstash-logging switch value has been read before returning its state.\r\n\r\n## What is the value of this and can you measure success?\r\nMake logging to logstash possible :)\r\n\r\n## Does this affect other platforms - Amp, Apps, etc?\r\nNo\r\n\r\n## Request for comment\r\n@johnduffell @jamespamplin ","created_at":"2016-04-18T14:15:45Z","updated_at":"2016-04-18T14:16:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"598e36d140fc26264a6f192d673aaba34ff03057","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/guardian/frontend/pulls/12593/commits","review_comments_url":"https://api.github.com/repos/guardian/frontend/pulls/12593/comments","review_comment_url":"https://api.github.com/repos/guardian/frontend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/guardian/frontend/issues/12593/comments","statuses_url":"https://api.github.com/repos/guardian/frontend/statuses/d79be83e3b07ba5d9e03c7232c45182a5d9f3d71","head":{"label":"guardian:tbonnin-make-sure-logstash-switch-is-read","ref":"tbonnin-make-sure-logstash-switch-is-read","sha":"d79be83e3b07ba5d9e03c7232c45182a5d9f3d71","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":4370755,"name":"frontend","full_name":"guardian/frontend","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/frontend","description":"Source for theguardian.com","fork":false,"url":"https://api.github.com/repos/guardian/frontend","forks_url":"https://api.github.com/repos/guardian/frontend/forks","keys_url":"https://api.github.com/repos/guardian/frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/frontend/teams","hooks_url":"https://api.github.com/repos/guardian/frontend/hooks","issue_events_url":"https://api.github.com/repos/guardian/frontend/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/frontend/events","assignees_url":"https://api.github.com/repos/guardian/frontend/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/frontend/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/frontend/tags","blobs_url":"https://api.github.com/repos/guardian/frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/frontend/languages","stargazers_url":"https://api.github.com/repos/guardian/frontend/stargazers","contributors_url":"https://api.github.com/repos/guardian/frontend/contributors","subscribers_url":"https://api.github.com/repos/guardian/frontend/subscribers","subscription_url":"https://api.github.com/repos/guardian/frontend/subscription","commits_url":"https://api.github.com/repos/guardian/frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/guardian/frontend/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/frontend/merges","archive_url":"https://api.github.com/repos/guardian/frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/frontend/downloads","issues_url":"https://api.github.com/repos/guardian/frontend/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/frontend/labels{/name}","releases_url":"https://api.github.com/repos/guardian/frontend/releases{/id}","deployments_url":"https://api.github.com/repos/guardian/frontend/deployments","created_at":"2012-05-18T15:39:15Z","updated_at":"2016-04-17T20:00:36Z","pushed_at":"2016-04-18T14:15:46Z","git_url":"git://github.com/guardian/frontend.git","ssh_url":"git@github.com:guardian/frontend.git","clone_url":"https://github.com/guardian/frontend.git","svn_url":"https://github.com/guardian/frontend","homepage":"http://www.theguardian.com","size":470371,"stargazers_count":3154,"watchers_count":3154,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":319,"mirror_url":null,"open_issues_count":53,"forks":319,"open_issues":53,"watchers":3154,"default_branch":"master"}},"base":{"label":"guardian:master","ref":"master","sha":"da19efa34f5b8f17973a3b82bfc62ac6d585e9e1","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":4370755,"name":"frontend","full_name":"guardian/frontend","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/frontend","description":"Source for theguardian.com","fork":false,"url":"https://api.github.com/repos/guardian/frontend","forks_url":"https://api.github.com/repos/guardian/frontend/forks","keys_url":"https://api.github.com/repos/guardian/frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/frontend/teams","hooks_url":"https://api.github.com/repos/guardian/frontend/hooks","issue_events_url":"https://api.github.com/repos/guardian/frontend/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/frontend/events","assignees_url":"https://api.github.com/repos/guardian/frontend/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/frontend/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/frontend/tags","blobs_url":"https://api.github.com/repos/guardian/frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/frontend/languages","stargazers_url":"https://api.github.com/repos/guardian/frontend/stargazers","contributors_url":"https://api.github.com/repos/guardian/frontend/contributors","subscribers_url":"https://api.github.com/repos/guardian/frontend/subscribers","subscription_url":"https://api.github.com/repos/guardian/frontend/subscription","commits_url":"https://api.github.com/repos/guardian/frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/guardian/frontend/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/frontend/merges","archive_url":"https://api.github.com/repos/guardian/frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/frontend/downloads","issues_url":"https://api.github.com/repos/guardian/frontend/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/frontend/labels{/name}","releases_url":"https://api.github.com/repos/guardian/frontend/releases{/id}","deployments_url":"https://api.github.com/repos/guardian/frontend/deployments","created_at":"2012-05-18T15:39:15Z","updated_at":"2016-04-17T20:00:36Z","pushed_at":"2016-04-18T14:15:46Z","git_url":"git://github.com/guardian/frontend.git","ssh_url":"git@github.com:guardian/frontend.git","clone_url":"https://github.com/guardian/frontend.git","svn_url":"https://github.com/guardian/frontend","homepage":"http://www.theguardian.com","size":470371,"stargazers_count":3154,"watchers_count":3154,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":319,"mirror_url":null,"open_issues_count":53,"forks":319,"open_issues":53,"watchers":3154,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/guardian/frontend/pulls/12593"},"html":{"href":"https://github.com/guardian/frontend/pull/12593"},"issue":{"href":"https://api.github.com/repos/guardian/frontend/issues/12593"},"comments":{"href":"https://api.github.com/repos/guardian/frontend/issues/12593/comments"},"review_comments":{"href":"https://api.github.com/repos/guardian/frontend/pulls/12593/comments"},"review_comment":{"href":"https://api.github.com/repos/guardian/frontend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/guardian/frontend/pulls/12593/commits"},"statuses":{"href":"https://api.github.com/repos/guardian/frontend/statuses/d79be83e3b07ba5d9e03c7232c45182a5d9f3d71"}}}}