{"action":"created","comment":{"url":"https://api.github.com/repos/adonisjs/adonis-app/pulls/comments/90515034","pull_request_review_id":11034370,"id":90515034,"diff_hunk":"@@ -4,8 +4,6 @@ APP_KEY=n96M1TPG821EdN4mMIjnGKxGytx9W2UJ\n NODE_ENV=development\n CACHE_VIEWS=false\n SESSION_DRIVER=cookie\n+SESSION_DOMAIN=example.com\n+SESSION_COOKIE=example-session","path":".env.example","position":5,"original_position":5,"commit_id":"f3595733eb17d257ee6c9dec7e75ccdafa5afa0b","original_commit_id":"f3595733eb17d257ee6c9dec7e75ccdafa5afa0b","user":{"login":"ctf0","id":7388088,"avatar_url":"https://avatars.githubusercontent.com/u/7388088?v=3","gravatar_id":"","url":"https://api.github.com/users/ctf0","html_url":"https://github.com/ctf0","followers_url":"https://api.github.com/users/ctf0/followers","following_url":"https://api.github.com/users/ctf0/following{/other_user}","gists_url":"https://api.github.com/users/ctf0/gists{/gist_id}","starred_url":"https://api.github.com/users/ctf0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ctf0/subscriptions","organizations_url":"https://api.github.com/users/ctf0/orgs","repos_url":"https://api.github.com/users/ctf0/repos","events_url":"https://api.github.com/users/ctf0/events{/privacy}","received_events_url":"https://api.github.com/users/ctf0/received_events","type":"User","site_admin":false},"body":"the reason behind `SESSION_COOKIE & SESSION_DOMAIN` is to minimize being effected by any bug that could be used by an attacker.","created_at":"2016-12-01T19:09:31Z","updated_at":"2016-12-01T19:09:31Z","html_url":"https://github.com/adonisjs/adonis-app/pull/46#discussion_r90515034","pull_request_url":"https://api.github.com/repos/adonisjs/adonis-app/pulls/46","_links":{"self":{"href":"https://api.github.com/repos/adonisjs/adonis-app/pulls/comments/90515034"},"html":{"href":"https://github.com/adonisjs/adonis-app/pull/46#discussion_r90515034"},"pull_request":{"href":"https://api.github.com/repos/adonisjs/adonis-app/pulls/46"}}},"pull_request":{"url":"https://api.github.com/repos/adonisjs/adonis-app/pulls/46","id":94529970,"html_url":"https://github.com/adonisjs/adonis-app/pull/46","diff_url":"https://github.com/adonisjs/adonis-app/pull/46.diff","patch_url":"https://github.com/adonisjs/adonis-app/pull/46.patch","issue_url":"https://api.github.com/repos/adonisjs/adonis-app/issues/46","number":46,"state":"open","locked":false,"title":"minor changes to config files","user":{"login":"ctf0","id":7388088,"avatar_url":"https://avatars.githubusercontent.com/u/7388088?v=3","gravatar_id":"","url":"https://api.github.com/users/ctf0","html_url":"https://github.com/ctf0","followers_url":"https://api.github.com/users/ctf0/followers","following_url":"https://api.github.com/users/ctf0/following{/other_user}","gists_url":"https://api.github.com/users/ctf0/gists{/gist_id}","starred_url":"https://api.github.com/users/ctf0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ctf0/subscriptions","organizations_url":"https://api.github.com/users/ctf0/orgs","repos_url":"https://api.github.com/users/ctf0/repos","events_url":"https://api.github.com/users/ctf0/events{/privacy}","received_events_url":"https://api.github.com/users/ctf0/received_events","type":"User","site_admin":false},"body":"1- changed some security settings to make it more secure out-of-the-box\r\n2- changed the data-upload limit for something more reasonable\r\n3- added an env key for `SESSION_DOMAIN` for easier user exp\r\n4- fixed some docs typos and made config files more consistent\r\n5- added `PATCH` verb to **csrf**","created_at":"2016-11-20T19:55:52Z","updated_at":"2016-12-01T19:09:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"741e13d68571f6f88945ab9599379a58d2a4d259","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/adonisjs/adonis-app/pulls/46/commits","review_comments_url":"https://api.github.com/repos/adonisjs/adonis-app/pulls/46/comments","review_comment_url":"https://api.github.com/repos/adonisjs/adonis-app/pulls/comments{/number}","comments_url":"https://api.github.com/repos/adonisjs/adonis-app/issues/46/comments","statuses_url":"https://api.github.com/repos/adonisjs/adonis-app/statuses/f3595733eb17d257ee6c9dec7e75ccdafa5afa0b","head":{"label":"ctf0:develop","ref":"develop","sha":"f3595733eb17d257ee6c9dec7e75ccdafa5afa0b","user":{"login":"ctf0","id":7388088,"avatar_url":"https://avatars.githubusercontent.com/u/7388088?v=3","gravatar_id":"","url":"https://api.github.com/users/ctf0","html_url":"https://github.com/ctf0","followers_url":"https://api.github.com/users/ctf0/followers","following_url":"https://api.github.com/users/ctf0/following{/other_user}","gists_url":"https://api.github.com/users/ctf0/gists{/gist_id}","starred_url":"https://api.github.com/users/ctf0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ctf0/subscriptions","organizations_url":"https://api.github.com/users/ctf0/orgs","repos_url":"https://api.github.com/users/ctf0/repos","events_url":"https://api.github.com/users/ctf0/events{/privacy}","received_events_url":"https://api.github.com/users/ctf0/received_events","type":"User","site_admin":false},"repo":{"id":74295783,"name":"adonis-app","full_name":"ctf0/adonis-app","owner":{"login":"ctf0","id":7388088,"avatar_url":"https://avatars.githubusercontent.com/u/7388088?v=3","gravatar_id":"","url":"https://api.github.com/users/ctf0","html_url":"https://github.com/ctf0","followers_url":"https://api.github.com/users/ctf0/followers","following_url":"https://api.github.com/users/ctf0/following{/other_user}","gists_url":"https://api.github.com/users/ctf0/gists{/gist_id}","starred_url":"https://api.github.com/users/ctf0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ctf0/subscriptions","organizations_url":"https://api.github.com/users/ctf0/orgs","repos_url":"https://api.github.com/users/ctf0/repos","events_url":"https://api.github.com/users/ctf0/events{/privacy}","received_events_url":"https://api.github.com/users/ctf0/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ctf0/adonis-app","description":"Application structure for new adonis app, think of it as scaffolding a new project","fork":true,"url":"https://api.github.com/repos/ctf0/adonis-app","forks_url":"https://api.github.com/repos/ctf0/adonis-app/forks","keys_url":"https://api.github.com/repos/ctf0/adonis-app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ctf0/adonis-app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ctf0/adonis-app/teams","hooks_url":"https://api.github.com/repos/ctf0/adonis-app/hooks","issue_events_url":"https://api.github.com/repos/ctf0/adonis-app/issues/events{/number}","events_url":"https://api.github.com/repos/ctf0/adonis-app/events","assignees_url":"https://api.github.com/repos/ctf0/adonis-app/assignees{/user}","branches_url":"https://api.github.com/repos/ctf0/adonis-app/branches{/branch}","tags_url":"https://api.github.com/repos/ctf0/adonis-app/tags","blobs_url":"https://api.github.com/repos/ctf0/adonis-app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ctf0/adonis-app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ctf0/adonis-app/git/refs{/sha}","trees_url":"https://api.github.com/repos/ctf0/adonis-app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ctf0/adonis-app/statuses/{sha}","languages_url":"https://api.github.com/repos/ctf0/adonis-app/languages","stargazers_url":"https://api.github.com/repos/ctf0/adonis-app/stargazers","contributors_url":"https://api.github.com/repos/ctf0/adonis-app/contributors","subscribers_url":"https://api.github.com/repos/ctf0/adonis-app/subscribers","subscription_url":"https://api.github.com/repos/ctf0/adonis-app/subscription","commits_url":"https://api.github.com/repos/ctf0/adonis-app/commits{/sha}","git_commits_url":"https://api.github.com/repos/ctf0/adonis-app/git/commits{/sha}","comments_url":"https://api.github.com/repos/ctf0/adonis-app/comments{/number}","issue_comment_url":"https://api.github.com/repos/ctf0/adonis-app/issues/comments{/number}","contents_url":"https://api.github.com/repos/ctf0/adonis-app/contents/{+path}","compare_url":"https://api.github.com/repos/ctf0/adonis-app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ctf0/adonis-app/merges","archive_url":"https://api.github.com/repos/ctf0/adonis-app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ctf0/adonis-app/downloads","issues_url":"https://api.github.com/repos/ctf0/adonis-app/issues{/number}","pulls_url":"https://api.github.com/repos/ctf0/adonis-app/pulls{/number}","milestones_url":"https://api.github.com/repos/ctf0/adonis-app/milestones{/number}","notifications_url":"https://api.github.com/repos/ctf0/adonis-app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ctf0/adonis-app/labels{/name}","releases_url":"https://api.github.com/repos/ctf0/adonis-app/releases{/id}","deployments_url":"https://api.github.com/repos/ctf0/adonis-app/deployments","created_at":"2016-11-20T18:59:40Z","updated_at":"2016-11-20T18:59:41Z","pushed_at":"2016-11-29T10:21:33Z","git_url":"git://github.com/ctf0/adonis-app.git","ssh_url":"git@github.com:ctf0/adonis-app.git","clone_url":"https://github.com/ctf0/adonis-app.git","svn_url":"https://github.com/ctf0/adonis-app","homepage":null,"size":161,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"adonisjs:develop","ref":"develop","sha":"91824ec584eba24a8955e949b05669800631e300","user":{"login":"adonisjs","id":13810373,"avatar_url":"https://avatars.githubusercontent.com/u/13810373?v=3","gravatar_id":"","url":"https://api.github.com/users/adonisjs","html_url":"https://github.com/adonisjs","followers_url":"https://api.github.com/users/adonisjs/followers","following_url":"https://api.github.com/users/adonisjs/following{/other_user}","gists_url":"https://api.github.com/users/adonisjs/gists{/gist_id}","starred_url":"https://api.github.com/users/adonisjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adonisjs/subscriptions","organizations_url":"https://api.github.com/users/adonisjs/orgs","repos_url":"https://api.github.com/users/adonisjs/repos","events_url":"https://api.github.com/users/adonisjs/events{/privacy}","received_events_url":"https://api.github.com/users/adonisjs/received_events","type":"Organization","site_admin":false},"repo":{"id":41870442,"name":"adonis-app","full_name":"adonisjs/adonis-app","owner":{"login":"adonisjs","id":13810373,"avatar_url":"https://avatars.githubusercontent.com/u/13810373?v=3","gravatar_id":"","url":"https://api.github.com/users/adonisjs","html_url":"https://github.com/adonisjs","followers_url":"https://api.github.com/users/adonisjs/followers","following_url":"https://api.github.com/users/adonisjs/following{/other_user}","gists_url":"https://api.github.com/users/adonisjs/gists{/gist_id}","starred_url":"https://api.github.com/users/adonisjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adonisjs/subscriptions","organizations_url":"https://api.github.com/users/adonisjs/orgs","repos_url":"https://api.github.com/users/adonisjs/repos","events_url":"https://api.github.com/users/adonisjs/events{/privacy}","received_events_url":"https://api.github.com/users/adonisjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/adonisjs/adonis-app","description":"Application structure for new adonis app, think of it as scaffolding a new project","fork":false,"url":"https://api.github.com/repos/adonisjs/adonis-app","forks_url":"https://api.github.com/repos/adonisjs/adonis-app/forks","keys_url":"https://api.github.com/repos/adonisjs/adonis-app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adonisjs/adonis-app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adonisjs/adonis-app/teams","hooks_url":"https://api.github.com/repos/adonisjs/adonis-app/hooks","issue_events_url":"https://api.github.com/repos/adonisjs/adonis-app/issues/events{/number}","events_url":"https://api.github.com/repos/adonisjs/adonis-app/events","assignees_url":"https://api.github.com/repos/adonisjs/adonis-app/assignees{/user}","branches_url":"https://api.github.com/repos/adonisjs/adonis-app/branches{/branch}","tags_url":"https://api.github.com/repos/adonisjs/adonis-app/tags","blobs_url":"https://api.github.com/repos/adonisjs/adonis-app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adonisjs/adonis-app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adonisjs/adonis-app/git/refs{/sha}","trees_url":"https://api.github.com/repos/adonisjs/adonis-app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adonisjs/adonis-app/statuses/{sha}","languages_url":"https://api.github.com/repos/adonisjs/adonis-app/languages","stargazers_url":"https://api.github.com/repos/adonisjs/adonis-app/stargazers","contributors_url":"https://api.github.com/repos/adonisjs/adonis-app/contributors","subscribers_url":"https://api.github.com/repos/adonisjs/adonis-app/subscribers","subscription_url":"https://api.github.com/repos/adonisjs/adonis-app/subscription","commits_url":"https://api.github.com/repos/adonisjs/adonis-app/commits{/sha}","git_commits_url":"https://api.github.com/repos/adonisjs/adonis-app/git/commits{/sha}","comments_url":"https://api.github.com/repos/adonisjs/adonis-app/comments{/number}","issue_comment_url":"https://api.github.com/repos/adonisjs/adonis-app/issues/comments{/number}","contents_url":"https://api.github.com/repos/adonisjs/adonis-app/contents/{+path}","compare_url":"https://api.github.com/repos/adonisjs/adonis-app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adonisjs/adonis-app/merges","archive_url":"https://api.github.com/repos/adonisjs/adonis-app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adonisjs/adonis-app/downloads","issues_url":"https://api.github.com/repos/adonisjs/adonis-app/issues{/number}","pulls_url":"https://api.github.com/repos/adonisjs/adonis-app/pulls{/number}","milestones_url":"https://api.github.com/repos/adonisjs/adonis-app/milestones{/number}","notifications_url":"https://api.github.com/repos/adonisjs/adonis-app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adonisjs/adonis-app/labels{/name}","releases_url":"https://api.github.com/repos/adonisjs/adonis-app/releases{/id}","deployments_url":"https://api.github.com/repos/adonisjs/adonis-app/deployments","created_at":"2015-09-03T16:23:39Z","updated_at":"2016-11-30T17:44:45Z","pushed_at":"2016-12-01T10:44:13Z","git_url":"git://github.com/adonisjs/adonis-app.git","ssh_url":"git@github.com:adonisjs/adonis-app.git","clone_url":"https://github.com/adonisjs/adonis-app.git","svn_url":"https://github.com/adonisjs/adonis-app","homepage":null,"size":195,"stargazers_count":111,"watchers_count":111,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"open_issues_count":4,"forks":23,"open_issues":4,"watchers":111,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/adonisjs/adonis-app/pulls/46"},"html":{"href":"https://github.com/adonisjs/adonis-app/pull/46"},"issue":{"href":"https://api.github.com/repos/adonisjs/adonis-app/issues/46"},"comments":{"href":"https://api.github.com/repos/adonisjs/adonis-app/issues/46/comments"},"review_comments":{"href":"https://api.github.com/repos/adonisjs/adonis-app/pulls/46/comments"},"review_comment":{"href":"https://api.github.com/repos/adonisjs/adonis-app/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/adonisjs/adonis-app/pulls/46/commits"},"statuses":{"href":"https://api.github.com/repos/adonisjs/adonis-app/statuses/f3595733eb17d257ee6c9dec7e75ccdafa5afa0b"}}}}
{"actor":{"display_login":"ctf0"}}