{"action":"created","comment":{"url":"https://api.github.com/repos/dimagi/commcare-hq/pulls/comments/62572478","id":62572478,"diff_hunk":"@@ -1428,9 +1428,11 @@ def _rows_by_user(self, report_data):\n         last_form_by_user = self.es_last_submissions()\n         for user in self.users_to_iterate:\n             active_cases = int(report_data.active_cases_by_owner.get(user[\"user_id\"].lower(), 0)) + \\\n-                sum([int(report_data.active_cases_by_owner.get(group_id, 0)) for group_id in user[\"group_ids\"]])\n+                sum([int(report_data.active_cases_by_owner.get(group_id, 0)) for group_id in user[\"group_ids\"]]) + \\","path":"corehq/apps/reports/standard/monitoring.py","position":15,"original_position":5,"commit_id":"cfbcfa0ef01d5da07bd14786e53fd96e4134ac84","original_commit_id":"ef583a3932beb524c4b6d0e2042e0cca91cac757","user":{"login":"calellowitz","id":6844721,"avatar_url":"https://avatars.githubusercontent.com/u/6844721?v=3","gravatar_id":"","url":"https://api.github.com/users/calellowitz","html_url":"https://github.com/calellowitz","followers_url":"https://api.github.com/users/calellowitz/followers","following_url":"https://api.github.com/users/calellowitz/following{/other_user}","gists_url":"https://api.github.com/users/calellowitz/gists{/gist_id}","starred_url":"https://api.github.com/users/calellowitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calellowitz/subscriptions","organizations_url":"https://api.github.com/users/calellowitz/orgs","repos_url":"https://api.github.com/users/calellowitz/repos","events_url":"https://api.github.com/users/calellowitz/events{/privacy}","received_events_url":"https://api.github.com/users/calellowitz/received_events","type":"User","site_admin":false},"body":"I left the location cases out of the group rows because I wasnt sure what proper behavior should be. If the row shows the number of cases members of that group have access to, it should include that. If it shows number of cases owned by that group, it probably shouldn't. Since I believe that this doesnt include cases owned by other groups the users are in, only those owned by users and the groups in the report, it felt weird to include those owned by the locations the users are in. Happy to change it if you disagree or clarify if that was not explained well.","created_at":"2016-05-09T21:02:29Z","updated_at":"2016-05-09T21:02:29Z","html_url":"https://github.com/dimagi/commcare-hq/pull/11528#discussion_r62572478","pull_request_url":"https://api.github.com/repos/dimagi/commcare-hq/pulls/11528","_links":{"self":{"href":"https://api.github.com/repos/dimagi/commcare-hq/pulls/comments/62572478"},"html":{"href":"https://github.com/dimagi/commcare-hq/pull/11528#discussion_r62572478"},"pull_request":{"href":"https://api.github.com/repos/dimagi/commcare-hq/pulls/11528"}}},"pull_request":{"url":"https://api.github.com/repos/dimagi/commcare-hq/pulls/11528","id":69176590,"html_url":"https://github.com/dimagi/commcare-hq/pull/11528","diff_url":"https://github.com/dimagi/commcare-hq/pull/11528.diff","patch_url":"https://github.com/dimagi/commcare-hq/pull/11528.patch","issue_url":"https://api.github.com/repos/dimagi/commcare-hq/issues/11528","number":11528,"state":"open","locked":false,"title":"Location case reports","user":{"login":"calellowitz","id":6844721,"avatar_url":"https://avatars.githubusercontent.com/u/6844721?v=3","gravatar_id":"","url":"https://api.github.com/users/calellowitz","html_url":"https://github.com/calellowitz","followers_url":"https://api.github.com/users/calellowitz/followers","following_url":"https://api.github.com/users/calellowitz/following{/other_user}","gists_url":"https://api.github.com/users/calellowitz/gists{/gist_id}","starred_url":"https://api.github.com/users/calellowitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calellowitz/subscriptions","organizations_url":"https://api.github.com/users/calellowitz/orgs","repos_url":"https://api.github.com/users/calellowitz/repos","events_url":"https://api.github.com/users/calellowitz/events{/privacy}","received_events_url":"https://api.github.com/users/calellowitz/received_events","type":"User","site_admin":false},"body":"Full description of problem at http://manage.dimagi.com/default.asp?226192#1140287 but in short worker activity reports dont handle location based case sharing correctly, and there were issues in the sum row for any domain with multiple case sharing groups. I am not sure this is the best way to address the problem but it returns the expected results. Definitely open to feedback about alternate ways.\r\nit looks like @benrudolph touched this code last\r\ninterrupt: @dannyroberts @sravfeyn @kaapstorm \r\ncc: @orangejenny ","created_at":"2016-05-06T16:34:14Z","updated_at":"2016-05-09T21:02:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"94589e5e63e4443873557857fde8541f47bfdbe4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dimagi/commcare-hq/pulls/11528/commits","review_comments_url":"https://api.github.com/repos/dimagi/commcare-hq/pulls/11528/comments","review_comment_url":"https://api.github.com/repos/dimagi/commcare-hq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dimagi/commcare-hq/issues/11528/comments","statuses_url":"https://api.github.com/repos/dimagi/commcare-hq/statuses/cfbcfa0ef01d5da07bd14786e53fd96e4134ac84","head":{"label":"dimagi:location-case-reports","ref":"location-case-reports","sha":"cfbcfa0ef01d5da07bd14786e53fd96e4134ac84","user":{"login":"dimagi","id":94514,"avatar_url":"https://avatars.githubusercontent.com/u/94514?v=3","gravatar_id":"","url":"https://api.github.com/users/dimagi","html_url":"https://github.com/dimagi","followers_url":"https://api.github.com/users/dimagi/followers","following_url":"https://api.github.com/users/dimagi/following{/other_user}","gists_url":"https://api.github.com/users/dimagi/gists{/gist_id}","starred_url":"https://api.github.com/users/dimagi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimagi/subscriptions","organizations_url":"https://api.github.com/users/dimagi/orgs","repos_url":"https://api.github.com/users/dimagi/repos","events_url":"https://api.github.com/users/dimagi/events{/privacy}","received_events_url":"https://api.github.com/users/dimagi/received_events","type":"Organization","site_admin":false},"repo":{"id":247278,"name":"commcare-hq","full_name":"dimagi/commcare-hq","owner":{"login":"dimagi","id":94514,"avatar_url":"https://avatars.githubusercontent.com/u/94514?v=3","gravatar_id":"","url":"https://api.github.com/users/dimagi","html_url":"https://github.com/dimagi","followers_url":"https://api.github.com/users/dimagi/followers","following_url":"https://api.github.com/users/dimagi/following{/other_user}","gists_url":"https://api.github.com/users/dimagi/gists{/gist_id}","starred_url":"https://api.github.com/users/dimagi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimagi/subscriptions","organizations_url":"https://api.github.com/users/dimagi/orgs","repos_url":"https://api.github.com/users/dimagi/repos","events_url":"https://api.github.com/users/dimagi/events{/privacy}","received_events_url":"https://api.github.com/users/dimagi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dimagi/commcare-hq","description":"A server-side tool to help manage community health workers, written in Django","fork":false,"url":"https://api.github.com/repos/dimagi/commcare-hq","forks_url":"https://api.github.com/repos/dimagi/commcare-hq/forks","keys_url":"https://api.github.com/repos/dimagi/commcare-hq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dimagi/commcare-hq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dimagi/commcare-hq/teams","hooks_url":"https://api.github.com/repos/dimagi/commcare-hq/hooks","issue_events_url":"https://api.github.com/repos/dimagi/commcare-hq/issues/events{/number}","events_url":"https://api.github.com/repos/dimagi/commcare-hq/events","assignees_url":"https://api.github.com/repos/dimagi/commcare-hq/assignees{/user}","branches_url":"https://api.github.com/repos/dimagi/commcare-hq/branches{/branch}","tags_url":"https://api.github.com/repos/dimagi/commcare-hq/tags","blobs_url":"https://api.github.com/repos/dimagi/commcare-hq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dimagi/commcare-hq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dimagi/commcare-hq/git/refs{/sha}","trees_url":"https://api.github.com/repos/dimagi/commcare-hq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dimagi/commcare-hq/statuses/{sha}","languages_url":"https://api.github.com/repos/dimagi/commcare-hq/languages","stargazers_url":"https://api.github.com/repos/dimagi/commcare-hq/stargazers","contributors_url":"https://api.github.com/repos/dimagi/commcare-hq/contributors","subscribers_url":"https://api.github.com/repos/dimagi/commcare-hq/subscribers","subscription_url":"https://api.github.com/repos/dimagi/commcare-hq/subscription","commits_url":"https://api.github.com/repos/dimagi/commcare-hq/commits{/sha}","git_commits_url":"https://api.github.com/repos/dimagi/commcare-hq/git/commits{/sha}","comments_url":"https://api.github.com/repos/dimagi/commcare-hq/comments{/number}","issue_comment_url":"https://api.github.com/repos/dimagi/commcare-hq/issues/comments{/number}","contents_url":"https://api.github.com/repos/dimagi/commcare-hq/contents/{+path}","compare_url":"https://api.github.com/repos/dimagi/commcare-hq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dimagi/commcare-hq/merges","archive_url":"https://api.github.com/repos/dimagi/commcare-hq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dimagi/commcare-hq/downloads","issues_url":"https://api.github.com/repos/dimagi/commcare-hq/issues{/number}","pulls_url":"https://api.github.com/repos/dimagi/commcare-hq/pulls{/number}","milestones_url":"https://api.github.com/repos/dimagi/commcare-hq/milestones{/number}","notifications_url":"https://api.github.com/repos/dimagi/commcare-hq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dimagi/commcare-hq/labels{/name}","releases_url":"https://api.github.com/repos/dimagi/commcare-hq/releases{/id}","deployments_url":"https://api.github.com/repos/dimagi/commcare-hq/deployments","created_at":"2009-07-09T17:00:07Z","updated_at":"2016-05-07T22:07:37Z","pushed_at":"2016-05-09T20:57:01Z","git_url":"git://github.com/dimagi/commcare-hq.git","ssh_url":"git@github.com:dimagi/commcare-hq.git","clone_url":"https://github.com/dimagi/commcare-hq.git","svn_url":"https://github.com/dimagi/commcare-hq","homepage":"http://www.commcarehq.org","size":294325,"stargazers_count":70,"watchers_count":70,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":67,"mirror_url":null,"open_issues_count":57,"forks":67,"open_issues":57,"watchers":70,"default_branch":"master"}},"base":{"label":"dimagi:master","ref":"master","sha":"c3f29876e0d5e5d7d143771fc18459b104a6714b","user":{"login":"dimagi","id":94514,"avatar_url":"https://avatars.githubusercontent.com/u/94514?v=3","gravatar_id":"","url":"https://api.github.com/users/dimagi","html_url":"https://github.com/dimagi","followers_url":"https://api.github.com/users/dimagi/followers","following_url":"https://api.github.com/users/dimagi/following{/other_user}","gists_url":"https://api.github.com/users/dimagi/gists{/gist_id}","starred_url":"https://api.github.com/users/dimagi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimagi/subscriptions","organizations_url":"https://api.github.com/users/dimagi/orgs","repos_url":"https://api.github.com/users/dimagi/repos","events_url":"https://api.github.com/users/dimagi/events{/privacy}","received_events_url":"https://api.github.com/users/dimagi/received_events","type":"Organization","site_admin":false},"repo":{"id":247278,"name":"commcare-hq","full_name":"dimagi/commcare-hq","owner":{"login":"dimagi","id":94514,"avatar_url":"https://avatars.githubusercontent.com/u/94514?v=3","gravatar_id":"","url":"https://api.github.com/users/dimagi","html_url":"https://github.com/dimagi","followers_url":"https://api.github.com/users/dimagi/followers","following_url":"https://api.github.com/users/dimagi/following{/other_user}","gists_url":"https://api.github.com/users/dimagi/gists{/gist_id}","starred_url":"https://api.github.com/users/dimagi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimagi/subscriptions","organizations_url":"https://api.github.com/users/dimagi/orgs","repos_url":"https://api.github.com/users/dimagi/repos","events_url":"https://api.github.com/users/dimagi/events{/privacy}","received_events_url":"https://api.github.com/users/dimagi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dimagi/commcare-hq","description":"A server-side tool to help manage community health workers, written in Django","fork":false,"url":"https://api.github.com/repos/dimagi/commcare-hq","forks_url":"https://api.github.com/repos/dimagi/commcare-hq/forks","keys_url":"https://api.github.com/repos/dimagi/commcare-hq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dimagi/commcare-hq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dimagi/commcare-hq/teams","hooks_url":"https://api.github.com/repos/dimagi/commcare-hq/hooks","issue_events_url":"https://api.github.com/repos/dimagi/commcare-hq/issues/events{/number}","events_url":"https://api.github.com/repos/dimagi/commcare-hq/events","assignees_url":"https://api.github.com/repos/dimagi/commcare-hq/assignees{/user}","branches_url":"https://api.github.com/repos/dimagi/commcare-hq/branches{/branch}","tags_url":"https://api.github.com/repos/dimagi/commcare-hq/tags","blobs_url":"https://api.github.com/repos/dimagi/commcare-hq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dimagi/commcare-hq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dimagi/commcare-hq/git/refs{/sha}","trees_url":"https://api.github.com/repos/dimagi/commcare-hq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dimagi/commcare-hq/statuses/{sha}","languages_url":"https://api.github.com/repos/dimagi/commcare-hq/languages","stargazers_url":"https://api.github.com/repos/dimagi/commcare-hq/stargazers","contributors_url":"https://api.github.com/repos/dimagi/commcare-hq/contributors","subscribers_url":"https://api.github.com/repos/dimagi/commcare-hq/subscribers","subscription_url":"https://api.github.com/repos/dimagi/commcare-hq/subscription","commits_url":"https://api.github.com/repos/dimagi/commcare-hq/commits{/sha}","git_commits_url":"https://api.github.com/repos/dimagi/commcare-hq/git/commits{/sha}","comments_url":"https://api.github.com/repos/dimagi/commcare-hq/comments{/number}","issue_comment_url":"https://api.github.com/repos/dimagi/commcare-hq/issues/comments{/number}","contents_url":"https://api.github.com/repos/dimagi/commcare-hq/contents/{+path}","compare_url":"https://api.github.com/repos/dimagi/commcare-hq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dimagi/commcare-hq/merges","archive_url":"https://api.github.com/repos/dimagi/commcare-hq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dimagi/commcare-hq/downloads","issues_url":"https://api.github.com/repos/dimagi/commcare-hq/issues{/number}","pulls_url":"https://api.github.com/repos/dimagi/commcare-hq/pulls{/number}","milestones_url":"https://api.github.com/repos/dimagi/commcare-hq/milestones{/number}","notifications_url":"https://api.github.com/repos/dimagi/commcare-hq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dimagi/commcare-hq/labels{/name}","releases_url":"https://api.github.com/repos/dimagi/commcare-hq/releases{/id}","deployments_url":"https://api.github.com/repos/dimagi/commcare-hq/deployments","created_at":"2009-07-09T17:00:07Z","updated_at":"2016-05-07T22:07:37Z","pushed_at":"2016-05-09T20:57:01Z","git_url":"git://github.com/dimagi/commcare-hq.git","ssh_url":"git@github.com:dimagi/commcare-hq.git","clone_url":"https://github.com/dimagi/commcare-hq.git","svn_url":"https://github.com/dimagi/commcare-hq","homepage":"http://www.commcarehq.org","size":294325,"stargazers_count":70,"watchers_count":70,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":67,"mirror_url":null,"open_issues_count":57,"forks":67,"open_issues":57,"watchers":70,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dimagi/commcare-hq/pulls/11528"},"html":{"href":"https://github.com/dimagi/commcare-hq/pull/11528"},"issue":{"href":"https://api.github.com/repos/dimagi/commcare-hq/issues/11528"},"comments":{"href":"https://api.github.com/repos/dimagi/commcare-hq/issues/11528/comments"},"review_comments":{"href":"https://api.github.com/repos/dimagi/commcare-hq/pulls/11528/comments"},"review_comment":{"href":"https://api.github.com/repos/dimagi/commcare-hq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dimagi/commcare-hq/pulls/11528/commits"},"statuses":{"href":"https://api.github.com/repos/dimagi/commcare-hq/statuses/cfbcfa0ef01d5da07bd14786e53fd96e4134ac84"}}}}