{"action":"created","comment":{"url":"https://api.github.com/repos/mixpanel/mixpanel-iphone/pulls/comments/67258971","id":67258971,"diff_hunk":"@@ -122,4 +122,18 @@ - (UITableView *)parentTableView:(UIView *)cell {\n     return nil; // this view is not within a tableView\n }\n \n+- (BOOL)isEqual:(id)other {","path":"Mixpanel/MPUITableViewBinding.m","position":4,"original_position":4,"commit_id":"7a4ba3e0ee5f117779dd450b6066e5affa7bcf31","original_commit_id":"7a4ba3e0ee5f117779dd450b6066e5affa7bcf31","user":{"login":"patedit","id":1812240,"avatar_url":"https://avatars.githubusercontent.com/u/1812240?v=3","gravatar_id":"","url":"https://api.github.com/users/patedit","html_url":"https://github.com/patedit","followers_url":"https://api.github.com/users/patedit/followers","following_url":"https://api.github.com/users/patedit/following{/other_user}","gists_url":"https://api.github.com/users/patedit/gists{/gist_id}","starred_url":"https://api.github.com/users/patedit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patedit/subscriptions","organizations_url":"https://api.github.com/users/patedit/orgs","repos_url":"https://api.github.com/users/patedit/repos","events_url":"https://api.github.com/users/patedit/events{/privacy}","received_events_url":"https://api.github.com/users/patedit/received_events","type":"User","site_admin":false},"body":"Do you think we need this? It seems to me that it does the same as its super class `isEqual`. ","created_at":"2016-06-15T22:38:33Z","updated_at":"2016-06-15T22:38:33Z","html_url":"https://github.com/mixpanel/mixpanel-iphone/pull/510#discussion_r67258971","pull_request_url":"https://api.github.com/repos/mixpanel/mixpanel-iphone/pulls/510","_links":{"self":{"href":"https://api.github.com/repos/mixpanel/mixpanel-iphone/pulls/comments/67258971"},"html":{"href":"https://github.com/mixpanel/mixpanel-iphone/pull/510#discussion_r67258971"},"pull_request":{"href":"https://api.github.com/repos/mixpanel/mixpanel-iphone/pulls/510"}}},"pull_request":{"url":"https://api.github.com/repos/mixpanel/mixpanel-iphone/pulls/510","id":73994002,"html_url":"https://github.com/mixpanel/mixpanel-iphone/pull/510","diff_url":"https://github.com/mixpanel/mixpanel-iphone/pull/510.diff","patch_url":"https://github.com/mixpanel/mixpanel-iphone/pull/510.patch","issue_url":"https://api.github.com/repos/mixpanel/mixpanel-iphone/issues/510","number":510,"state":"open","locked":false,"title":"Swizzling and codeless fix","user":{"login":"yarneo","id":4066863,"avatar_url":"https://avatars.githubusercontent.com/u/4066863?v=3","gravatar_id":"","url":"https://api.github.com/users/yarneo","html_url":"https://github.com/yarneo","followers_url":"https://api.github.com/users/yarneo/followers","following_url":"https://api.github.com/users/yarneo/following{/other_user}","gists_url":"https://api.github.com/users/yarneo/gists{/gist_id}","starred_url":"https://api.github.com/users/yarneo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yarneo/subscriptions","organizations_url":"https://api.github.com/users/yarneo/orgs","repos_url":"https://api.github.com/users/yarneo/repos","events_url":"https://api.github.com/users/yarneo/events{/privacy}","received_events_url":"https://api.github.com/users/yarneo/received_events","type":"User","site_admin":false},"body":"NSHashSet didn't have a proper comparable, which caused all codeless bindings to keep accumulating with duplicates. Also this caused all codeless events to be unswizzled then re-swizzled all at once. \r\nAlso, codeless events were tracked multiple times each time we got a decide response inside the same session","created_at":"2016-06-15T22:19:30Z","updated_at":"2016-06-15T22:38:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"37d6ab421018fe1304d8e05e8d8045e92b8ea4f3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mixpanel/mixpanel-iphone/pulls/510/commits","review_comments_url":"https://api.github.com/repos/mixpanel/mixpanel-iphone/pulls/510/comments","review_comment_url":"https://api.github.com/repos/mixpanel/mixpanel-iphone/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mixpanel/mixpanel-iphone/issues/510/comments","statuses_url":"https://api.github.com/repos/mixpanel/mixpanel-iphone/statuses/7a4ba3e0ee5f117779dd450b6066e5affa7bcf31","head":{"label":"mixpanel:swizzling-and-codeless-fix","ref":"swizzling-and-codeless-fix","sha":"7a4ba3e0ee5f117779dd450b6066e5affa7bcf31","user":{"login":"mixpanel","id":63653,"avatar_url":"https://avatars.githubusercontent.com/u/63653?v=3","gravatar_id":"","url":"https://api.github.com/users/mixpanel","html_url":"https://github.com/mixpanel","followers_url":"https://api.github.com/users/mixpanel/followers","following_url":"https://api.github.com/users/mixpanel/following{/other_user}","gists_url":"https://api.github.com/users/mixpanel/gists{/gist_id}","starred_url":"https://api.github.com/users/mixpanel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mixpanel/subscriptions","organizations_url":"https://api.github.com/users/mixpanel/orgs","repos_url":"https://api.github.com/users/mixpanel/repos","events_url":"https://api.github.com/users/mixpanel/events{/privacy}","received_events_url":"https://api.github.com/users/mixpanel/received_events","type":"Organization","site_admin":false},"repo":{"id":775069,"name":"mixpanel-iphone","full_name":"mixpanel/mixpanel-iphone","owner":{"login":"mixpanel","id":63653,"avatar_url":"https://avatars.githubusercontent.com/u/63653?v=3","gravatar_id":"","url":"https://api.github.com/users/mixpanel","html_url":"https://github.com/mixpanel","followers_url":"https://api.github.com/users/mixpanel/followers","following_url":"https://api.github.com/users/mixpanel/following{/other_user}","gists_url":"https://api.github.com/users/mixpanel/gists{/gist_id}","starred_url":"https://api.github.com/users/mixpanel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mixpanel/subscriptions","organizations_url":"https://api.github.com/users/mixpanel/orgs","repos_url":"https://api.github.com/users/mixpanel/repos","events_url":"https://api.github.com/users/mixpanel/events{/privacy}","received_events_url":"https://api.github.com/users/mixpanel/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mixpanel/mixpanel-iphone","description":"iPhone tracking library for Mixpanel Analytics","fork":false,"url":"https://api.github.com/repos/mixpanel/mixpanel-iphone","forks_url":"https://api.github.com/repos/mixpanel/mixpanel-iphone/forks","keys_url":"https://api.github.com/repos/mixpanel/mixpanel-iphone/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mixpanel/mixpanel-iphone/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mixpanel/mixpanel-iphone/teams","hooks_url":"https://api.github.com/repos/mixpanel/mixpanel-iphone/hooks","issue_events_url":"https://api.github.com/repos/mixpanel/mixpanel-iphone/issues/events{/number}","events_url":"https://api.github.com/repos/mixpanel/mixpanel-iphone/events","assignees_url":"https://api.github.com/repos/mixpanel/mixpanel-iphone/assignees{/user}","branches_url":"https://api.github.com/repos/mixpanel/mixpanel-iphone/branches{/branch}","tags_url":"https://api.github.com/repos/mixpanel/mixpanel-iphone/tags","blobs_url":"https://api.github.com/repos/mixpanel/mixpanel-iphone/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mixpanel/mixpanel-iphone/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mixpanel/mixpanel-iphone/git/refs{/sha}","trees_url":"https://api.github.com/repos/mixpanel/mixpanel-iphone/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mixpanel/mixpanel-iphone/statuses/{sha}","languages_url":"https://api.github.com/repos/mixpanel/mixpanel-iphone/languages","stargazers_url":"https://api.github.com/repos/mixpanel/mixpanel-iphone/stargazers","contributors_url":"https://api.github.com/repos/mixpanel/mixpanel-iphone/contributors","subscribers_url":"https://api.github.com/repos/mixpanel/mixpanel-iphone/subscribers","subscription_url":"https://api.github.com/repos/mixpanel/mixpanel-iphone/subscription","commits_url":"https://api.github.com/repos/mixpanel/mixpanel-iphone/commits{/sha}","git_commits_url":"https://api.github.com/repos/mixpanel/mixpanel-iphone/git/commits{/sha}","comments_url":"https://api.github.com/repos/mixpanel/mixpanel-iphone/comments{/number}","issue_comment_url":"https://api.github.com/repos/mixpanel/mixpanel-iphone/issues/comments{/number}","contents_url":"https://api.github.com/repos/mixpanel/mixpanel-iphone/contents/{+path}","compare_url":"https://api.github.com/repos/mixpanel/mixpanel-iphone/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mixpanel/mixpanel-iphone/merges","archive_url":"https://api.github.com/repos/mixpanel/mixpanel-iphone/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mixpanel/mixpanel-iphone/downloads","issues_url":"https://api.github.com/repos/mixpanel/mixpanel-iphone/issues{/number}","pulls_url":"https://api.github.com/repos/mixpanel/mixpanel-iphone/pulls{/number}","milestones_url":"https://api.github.com/repos/mixpanel/mixpanel-iphone/milestones{/number}","notifications_url":"https://api.github.com/repos/mixpanel/mixpanel-iphone/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mixpanel/mixpanel-iphone/labels{/name}","releases_url":"https://api.github.com/repos/mixpanel/mixpanel-iphone/releases{/id}","deployments_url":"https://api.github.com/repos/mixpanel/mixpanel-iphone/deployments","created_at":"2010-07-14T17:48:47Z","updated_at":"2016-06-15T09:05:31Z","pushed_at":"2016-06-15T22:19:30Z","git_url":"git://github.com/mixpanel/mixpanel-iphone.git","ssh_url":"git@github.com:mixpanel/mixpanel-iphone.git","clone_url":"https://github.com/mixpanel/mixpanel-iphone.git","svn_url":"https://github.com/mixpanel/mixpanel-iphone","homepage":"http://mixpanel.com","size":8097,"stargazers_count":475,"watchers_count":475,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":359,"mirror_url":null,"open_issues_count":29,"forks":359,"open_issues":29,"watchers":475,"default_branch":"master"}},"base":{"label":"mixpanel:master","ref":"master","sha":"05cdaced4645df69165a9d3ee6fb83782dfc84d1","user":{"login":"mixpanel","id":63653,"avatar_url":"https://avatars.githubusercontent.com/u/63653?v=3","gravatar_id":"","url":"https://api.github.com/users/mixpanel","html_url":"https://github.com/mixpanel","followers_url":"https://api.github.com/users/mixpanel/followers","following_url":"https://api.github.com/users/mixpanel/following{/other_user}","gists_url":"https://api.github.com/users/mixpanel/gists{/gist_id}","starred_url":"https://api.github.com/users/mixpanel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mixpanel/subscriptions","organizations_url":"https://api.github.com/users/mixpanel/orgs","repos_url":"https://api.github.com/users/mixpanel/repos","events_url":"https://api.github.com/users/mixpanel/events{/privacy}","received_events_url":"https://api.github.com/users/mixpanel/received_events","type":"Organization","site_admin":false},"repo":{"id":775069,"name":"mixpanel-iphone","full_name":"mixpanel/mixpanel-iphone","owner":{"login":"mixpanel","id":63653,"avatar_url":"https://avatars.githubusercontent.com/u/63653?v=3","gravatar_id":"","url":"https://api.github.com/users/mixpanel","html_url":"https://github.com/mixpanel","followers_url":"https://api.github.com/users/mixpanel/followers","following_url":"https://api.github.com/users/mixpanel/following{/other_user}","gists_url":"https://api.github.com/users/mixpanel/gists{/gist_id}","starred_url":"https://api.github.com/users/mixpanel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mixpanel/subscriptions","organizations_url":"https://api.github.com/users/mixpanel/orgs","repos_url":"https://api.github.com/users/mixpanel/repos","events_url":"https://api.github.com/users/mixpanel/events{/privacy}","received_events_url":"https://api.github.com/users/mixpanel/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mixpanel/mixpanel-iphone","description":"iPhone tracking library for Mixpanel Analytics","fork":false,"url":"https://api.github.com/repos/mixpanel/mixpanel-iphone","forks_url":"https://api.github.com/repos/mixpanel/mixpanel-iphone/forks","keys_url":"https://api.github.com/repos/mixpanel/mixpanel-iphone/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mixpanel/mixpanel-iphone/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mixpanel/mixpanel-iphone/teams","hooks_url":"https://api.github.com/repos/mixpanel/mixpanel-iphone/hooks","issue_events_url":"https://api.github.com/repos/mixpanel/mixpanel-iphone/issues/events{/number}","events_url":"https://api.github.com/repos/mixpanel/mixpanel-iphone/events","assignees_url":"https://api.github.com/repos/mixpanel/mixpanel-iphone/assignees{/user}","branches_url":"https://api.github.com/repos/mixpanel/mixpanel-iphone/branches{/branch}","tags_url":"https://api.github.com/repos/mixpanel/mixpanel-iphone/tags","blobs_url":"https://api.github.com/repos/mixpanel/mixpanel-iphone/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mixpanel/mixpanel-iphone/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mixpanel/mixpanel-iphone/git/refs{/sha}","trees_url":"https://api.github.com/repos/mixpanel/mixpanel-iphone/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mixpanel/mixpanel-iphone/statuses/{sha}","languages_url":"https://api.github.com/repos/mixpanel/mixpanel-iphone/languages","stargazers_url":"https://api.github.com/repos/mixpanel/mixpanel-iphone/stargazers","contributors_url":"https://api.github.com/repos/mixpanel/mixpanel-iphone/contributors","subscribers_url":"https://api.github.com/repos/mixpanel/mixpanel-iphone/subscribers","subscription_url":"https://api.github.com/repos/mixpanel/mixpanel-iphone/subscription","commits_url":"https://api.github.com/repos/mixpanel/mixpanel-iphone/commits{/sha}","git_commits_url":"https://api.github.com/repos/mixpanel/mixpanel-iphone/git/commits{/sha}","comments_url":"https://api.github.com/repos/mixpanel/mixpanel-iphone/comments{/number}","issue_comment_url":"https://api.github.com/repos/mixpanel/mixpanel-iphone/issues/comments{/number}","contents_url":"https://api.github.com/repos/mixpanel/mixpanel-iphone/contents/{+path}","compare_url":"https://api.github.com/repos/mixpanel/mixpanel-iphone/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mixpanel/mixpanel-iphone/merges","archive_url":"https://api.github.com/repos/mixpanel/mixpanel-iphone/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mixpanel/mixpanel-iphone/downloads","issues_url":"https://api.github.com/repos/mixpanel/mixpanel-iphone/issues{/number}","pulls_url":"https://api.github.com/repos/mixpanel/mixpanel-iphone/pulls{/number}","milestones_url":"https://api.github.com/repos/mixpanel/mixpanel-iphone/milestones{/number}","notifications_url":"https://api.github.com/repos/mixpanel/mixpanel-iphone/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mixpanel/mixpanel-iphone/labels{/name}","releases_url":"https://api.github.com/repos/mixpanel/mixpanel-iphone/releases{/id}","deployments_url":"https://api.github.com/repos/mixpanel/mixpanel-iphone/deployments","created_at":"2010-07-14T17:48:47Z","updated_at":"2016-06-15T09:05:31Z","pushed_at":"2016-06-15T22:19:30Z","git_url":"git://github.com/mixpanel/mixpanel-iphone.git","ssh_url":"git@github.com:mixpanel/mixpanel-iphone.git","clone_url":"https://github.com/mixpanel/mixpanel-iphone.git","svn_url":"https://github.com/mixpanel/mixpanel-iphone","homepage":"http://mixpanel.com","size":8097,"stargazers_count":475,"watchers_count":475,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":359,"mirror_url":null,"open_issues_count":29,"forks":359,"open_issues":29,"watchers":475,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mixpanel/mixpanel-iphone/pulls/510"},"html":{"href":"https://github.com/mixpanel/mixpanel-iphone/pull/510"},"issue":{"href":"https://api.github.com/repos/mixpanel/mixpanel-iphone/issues/510"},"comments":{"href":"https://api.github.com/repos/mixpanel/mixpanel-iphone/issues/510/comments"},"review_comments":{"href":"https://api.github.com/repos/mixpanel/mixpanel-iphone/pulls/510/comments"},"review_comment":{"href":"https://api.github.com/repos/mixpanel/mixpanel-iphone/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mixpanel/mixpanel-iphone/pulls/510/commits"},"statuses":{"href":"https://api.github.com/repos/mixpanel/mixpanel-iphone/statuses/7a4ba3e0ee5f117779dd450b6066e5affa7bcf31"}}}}
{"actor":{"display_login":"patedit"}}