{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments/58821899","id":58821899,"diff_hunk":"@@ -34,3 +34,5 @@\n - include: additional_config.yml\n \n - include: ../openshift-node/config.yml\n+\n+- include: openshift_router.yml","path":"playbooks/common/openshift-cluster/config.yml","position":5,"original_position":5,"commit_id":"b46323bfd3cea95728d448b4982e43f61bfa987b","original_commit_id":"b46323bfd3cea95728d448b4982e43f61bfa987b","user":{"login":"detiber","id":915544,"avatar_url":"https://avatars.githubusercontent.com/u/915544?v=3","gravatar_id":"","url":"https://api.github.com/users/detiber","html_url":"https://github.com/detiber","followers_url":"https://api.github.com/users/detiber/followers","following_url":"https://api.github.com/users/detiber/following{/other_user}","gists_url":"https://api.github.com/users/detiber/gists{/gist_id}","starred_url":"https://api.github.com/users/detiber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/detiber/subscriptions","organizations_url":"https://api.github.com/users/detiber/orgs","repos_url":"https://api.github.com/users/detiber/repos","events_url":"https://api.github.com/users/detiber/events{/privacy}","received_events_url":"https://api.github.com/users/detiber/received_events","type":"User","site_admin":false},"body":"Should this playbook be called openshift_hosted instead?\r\n\r\nI'm also wondering if we should take this opportunity to rename the openshift_router role to openshift_hosted to start the consolidation of the \"hosted\" roles into a openshift_hosted role...","created_at":"2016-04-07T05:49:44Z","updated_at":"2016-04-07T05:49:44Z","html_url":"https://github.com/openshift/openshift-ansible/pull/1705#discussion_r58821899","pull_request_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/1705","_links":{"self":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments/58821899"},"html":{"href":"https://github.com/openshift/openshift-ansible/pull/1705#discussion_r58821899"},"pull_request":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/1705"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/1705","id":65205547,"html_url":"https://github.com/openshift/openshift-ansible/pull/1705","diff_url":"https://github.com/openshift/openshift-ansible/pull/1705.diff","patch_url":"https://github.com/openshift/openshift-ansible/pull/1705.patch","issue_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/1705","number":1705,"state":"open","locked":false,"title":"Add support for creating secure router","user":{"login":"abutcher","id":47003,"avatar_url":"https://avatars.githubusercontent.com/u/47003?v=3","gravatar_id":"","url":"https://api.github.com/users/abutcher","html_url":"https://github.com/abutcher","followers_url":"https://api.github.com/users/abutcher/followers","following_url":"https://api.github.com/users/abutcher/following{/other_user}","gists_url":"https://api.github.com/users/abutcher/gists{/gist_id}","starred_url":"https://api.github.com/users/abutcher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abutcher/subscriptions","organizations_url":"https://api.github.com/users/abutcher/orgs","repos_url":"https://api.github.com/users/abutcher/repos","events_url":"https://api.github.com/users/abutcher/events{/privacy}","received_events_url":"https://api.github.com/users/abutcher/received_events","type":"User","site_admin":false},"body":"* Adds option for specifying an `openshift_router_certificate` cert and key pair.\r\n* Removes dependency on node label variables and retrieves the node list from the API s.t. this role can be applied to any cluster with existing nodes. I've added an openshift_router playbook that occurs after node install to account for this.\r\n* Infrastructure nodes are selected using `openshift_router_selector` which is based on deployment type by default; openshift-enterprise -> \"region=infra\" and online -> \"type=infra\".\r\n\r\nInventory options\r\n```\r\n# OpenShift Router Options\r\n#\r\n# Default selector for the OpenShift Router\r\n# Router will only be created if nodes matching this label are present\r\n#openshift_router_selector='region=infra'\r\n#\r\n# Router certificate (optional)\r\n# Provide local certificate paths which will be deployed\r\n#openshift_router_certificate={\"certfile\": \"/path/to/router.crt\", \"keyfile\": \"/path/to/router.key\"}\r\n```\r\n\r\nExample playbook\r\n```\r\n- name: Create OpenShift Router\r\n  hosts: oo_first_master\r\n  roles:\r\n  - role: openshift_router\r\n    openshift_router_certificate:\r\n      certfile: /path/to/my-router.crt\r\n      keyfile: /path/to/my-router.key\r\n    openshift_router_registry_url: 'registry.access.redhat.com/openshift3/ose-haproxy-router:v3.0.2.0'\r\n    openshift_router_selector: 'type=infra'\r\n```\r\n\r\n@dak1n1 @detiber ptal\r\n","created_at":"2016-04-04T20:14:10Z","updated_at":"2016-04-07T05:49:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c5bad2ecc5222b86ee0467403c761f11f0c2032c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/1705/commits","review_comments_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/1705/comments","review_comment_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/1705/comments","statuses_url":"https://api.github.com/repos/openshift/openshift-ansible/statuses/b46323bfd3cea95728d448b4982e43f61bfa987b","head":{"label":"abutcher:secure-router","ref":"secure-router","sha":"b46323bfd3cea95728d448b4982e43f61bfa987b","user":{"login":"abutcher","id":47003,"avatar_url":"https://avatars.githubusercontent.com/u/47003?v=3","gravatar_id":"","url":"https://api.github.com/users/abutcher","html_url":"https://github.com/abutcher","followers_url":"https://api.github.com/users/abutcher/followers","following_url":"https://api.github.com/users/abutcher/following{/other_user}","gists_url":"https://api.github.com/users/abutcher/gists{/gist_id}","starred_url":"https://api.github.com/users/abutcher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abutcher/subscriptions","organizations_url":"https://api.github.com/users/abutcher/orgs","repos_url":"https://api.github.com/users/abutcher/repos","events_url":"https://api.github.com/users/abutcher/events{/privacy}","received_events_url":"https://api.github.com/users/abutcher/received_events","type":"User","site_admin":false},"repo":{"id":40020725,"name":"openshift-ansible","full_name":"abutcher/openshift-ansible","owner":{"login":"abutcher","id":47003,"avatar_url":"https://avatars.githubusercontent.com/u/47003?v=3","gravatar_id":"","url":"https://api.github.com/users/abutcher","html_url":"https://github.com/abutcher","followers_url":"https://api.github.com/users/abutcher/followers","following_url":"https://api.github.com/users/abutcher/following{/other_user}","gists_url":"https://api.github.com/users/abutcher/gists{/gist_id}","starred_url":"https://api.github.com/users/abutcher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abutcher/subscriptions","organizations_url":"https://api.github.com/users/abutcher/orgs","repos_url":"https://api.github.com/users/abutcher/repos","events_url":"https://api.github.com/users/abutcher/events{/privacy}","received_events_url":"https://api.github.com/users/abutcher/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/abutcher/openshift-ansible","description":"OpenShift Ansible Code","fork":true,"url":"https://api.github.com/repos/abutcher/openshift-ansible","forks_url":"https://api.github.com/repos/abutcher/openshift-ansible/forks","keys_url":"https://api.github.com/repos/abutcher/openshift-ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/abutcher/openshift-ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/abutcher/openshift-ansible/teams","hooks_url":"https://api.github.com/repos/abutcher/openshift-ansible/hooks","issue_events_url":"https://api.github.com/repos/abutcher/openshift-ansible/issues/events{/number}","events_url":"https://api.github.com/repos/abutcher/openshift-ansible/events","assignees_url":"https://api.github.com/repos/abutcher/openshift-ansible/assignees{/user}","branches_url":"https://api.github.com/repos/abutcher/openshift-ansible/branches{/branch}","tags_url":"https://api.github.com/repos/abutcher/openshift-ansible/tags","blobs_url":"https://api.github.com/repos/abutcher/openshift-ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/abutcher/openshift-ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/abutcher/openshift-ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/abutcher/openshift-ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/abutcher/openshift-ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/abutcher/openshift-ansible/languages","stargazers_url":"https://api.github.com/repos/abutcher/openshift-ansible/stargazers","contributors_url":"https://api.github.com/repos/abutcher/openshift-ansible/contributors","subscribers_url":"https://api.github.com/repos/abutcher/openshift-ansible/subscribers","subscription_url":"https://api.github.com/repos/abutcher/openshift-ansible/subscription","commits_url":"https://api.github.com/repos/abutcher/openshift-ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/abutcher/openshift-ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/abutcher/openshift-ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/abutcher/openshift-ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/abutcher/openshift-ansible/contents/{+path}","compare_url":"https://api.github.com/repos/abutcher/openshift-ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/abutcher/openshift-ansible/merges","archive_url":"https://api.github.com/repos/abutcher/openshift-ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/abutcher/openshift-ansible/downloads","issues_url":"https://api.github.com/repos/abutcher/openshift-ansible/issues{/number}","pulls_url":"https://api.github.com/repos/abutcher/openshift-ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/abutcher/openshift-ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/abutcher/openshift-ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/abutcher/openshift-ansible/labels{/name}","releases_url":"https://api.github.com/repos/abutcher/openshift-ansible/releases{/id}","deployments_url":"https://api.github.com/repos/abutcher/openshift-ansible/deployments","created_at":"2015-07-31T19:07:31Z","updated_at":"2016-01-11T17:14:40Z","pushed_at":"2016-04-06T21:26:19Z","git_url":"git://github.com/abutcher/openshift-ansible.git","ssh_url":"git@github.com:abutcher/openshift-ansible.git","clone_url":"https://github.com/abutcher/openshift-ansible.git","svn_url":"https://github.com/abutcher/openshift-ansible","homepage":"","size":4185,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"6bae44332be495310dca9520518bf5d0776ae4c8","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":24109199,"name":"openshift-ansible","full_name":"openshift/openshift-ansible","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/openshift-ansible","description":"OpenShift Ansible Code","fork":false,"url":"https://api.github.com/repos/openshift/openshift-ansible","forks_url":"https://api.github.com/repos/openshift/openshift-ansible/forks","keys_url":"https://api.github.com/repos/openshift/openshift-ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/openshift-ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/openshift-ansible/teams","hooks_url":"https://api.github.com/repos/openshift/openshift-ansible/hooks","issue_events_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/openshift-ansible/events","assignees_url":"https://api.github.com/repos/openshift/openshift-ansible/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/openshift-ansible/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/openshift-ansible/tags","blobs_url":"https://api.github.com/repos/openshift/openshift-ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/openshift-ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/openshift-ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/openshift-ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/openshift-ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/openshift-ansible/languages","stargazers_url":"https://api.github.com/repos/openshift/openshift-ansible/stargazers","contributors_url":"https://api.github.com/repos/openshift/openshift-ansible/contributors","subscribers_url":"https://api.github.com/repos/openshift/openshift-ansible/subscribers","subscription_url":"https://api.github.com/repos/openshift/openshift-ansible/subscription","commits_url":"https://api.github.com/repos/openshift/openshift-ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/openshift-ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/openshift-ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/openshift-ansible/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/openshift-ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/openshift-ansible/merges","archive_url":"https://api.github.com/repos/openshift/openshift-ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/openshift-ansible/downloads","issues_url":"https://api.github.com/repos/openshift/openshift-ansible/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/openshift-ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/openshift-ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/openshift-ansible/labels{/name}","releases_url":"https://api.github.com/repos/openshift/openshift-ansible/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/openshift-ansible/deployments","created_at":"2014-09-16T17:07:51Z","updated_at":"2016-04-05T23:19:46Z","pushed_at":"2016-04-06T21:26:19Z","git_url":"git://github.com/openshift/openshift-ansible.git","ssh_url":"git@github.com:openshift/openshift-ansible.git","clone_url":"https://github.com/openshift/openshift-ansible.git","svn_url":"https://github.com/openshift/openshift-ansible","homepage":"install.openshift.com","size":5714,"stargazers_count":147,"watchers_count":147,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":266,"mirror_url":null,"open_issues_count":281,"forks":266,"open_issues":281,"watchers":147,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/1705"},"html":{"href":"https://github.com/openshift/openshift-ansible/pull/1705"},"issue":{"href":"https://api.github.com/repos/openshift/openshift-ansible/issues/1705"},"comments":{"href":"https://api.github.com/repos/openshift/openshift-ansible/issues/1705/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/1705/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/1705/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/openshift-ansible/statuses/b46323bfd3cea95728d448b4982e43f61bfa987b"}}}}