{"action":"closed","number":2830,"pull_request":{"url":"https://api.github.com/repos/eclipse/che/pulls/2830","id":90024561,"html_url":"https://github.com/eclipse/che/pull/2830","diff_url":"https://github.com/eclipse/che/pull/2830.diff","patch_url":"https://github.com/eclipse/che/pull/2830.patch","issue_url":"https://api.github.com/repos/eclipse/che/issues/2830","number":2830,"state":"closed","locked":false,"title":"Replace Crane with felixfbecker PHP Language Server","user":{"login":"kaloyan-raev","id":468091,"avatar_url":"https://avatars.githubusercontent.com/u/468091?v=3","gravatar_id":"","url":"https://api.github.com/users/kaloyan-raev","html_url":"https://github.com/kaloyan-raev","followers_url":"https://api.github.com/users/kaloyan-raev/followers","following_url":"https://api.github.com/users/kaloyan-raev/following{/other_user}","gists_url":"https://api.github.com/users/kaloyan-raev/gists{/gist_id}","starred_url":"https://api.github.com/users/kaloyan-raev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaloyan-raev/subscriptions","organizations_url":"https://api.github.com/users/kaloyan-raev/orgs","repos_url":"https://api.github.com/users/kaloyan-raev/repos","events_url":"https://api.github.com/users/kaloyan-raev/events{/privacy}","received_events_url":"https://api.github.com/users/kaloyan-raev/received_events","type":"User","site_admin":false},"body":"### What does this PR do?\r\n\r\nReplaces [HvyIndustries/crane](https://github.com/HvyIndustries/crane) with [felixfbecker/php-language-server](https://github.com/felixfbecker/php-language-server) as the PHP language server.\r\n\r\n[felixfbecker/php-language-server](https://github.com/felixfbecker/php-language-server) is implemented in pure PHP, utilizes existing PHP Tools (like PHP Parser, CodeSniffer and phpDocumentor) and already attracts a few PHP developers to contribute.\r\n\r\nThe below attachment must be uploaded to https://codenvy.com/update/repository/public/download/org.eclipse.che.ls.php.binaries\r\nAttachment: [php-language-server.tar.gz](https://github.com/eclipse/che/files/539317/php-language-server.tar.gz)\r\n\r\nThe tarball includes the necessary PHP executable for running the PHP language server. No additional OS packages need to be installed.\r\n\r\n### What issues does this PR fix or reference?\r\n\r\n- PHP support #2590\r\n\r\n### Previous behavior\r\n\r\nThe Crane PHP language server used so far provided only limited code completion and no other capabilities. It was implemented in TypeScript, so it can't reuse existing PHP tools and has much less potential to attract the PHP community for contributions.\r\n\r\n### New behavior\r\n\r\nIn its current state the PHP language server comes with the following capabilities:\r\n\r\n- Code completion\r\n- Syntax validation\r\n- Document formatting\r\n- Document symbols\r\n- Workspace symbols\r\n- Go to definition\r\n- Find references\r\n- Hover support\r\n\r\nSigned-off-by: Kaloyan Raev <kaloyan.r@zend.com>","created_at":"2016-10-19T14:46:15Z","updated_at":"2016-10-26T19:11:24Z","closed_at":"2016-10-26T19:11:24Z","merged_at":"2016-10-26T19:11:23Z","merge_commit_sha":"c0b68129918a7398fded3c48c6ab13790309327b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/che/pulls/2830/commits","review_comments_url":"https://api.github.com/repos/eclipse/che/pulls/2830/comments","review_comment_url":"https://api.github.com/repos/eclipse/che/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/che/issues/2830/comments","statuses_url":"https://api.github.com/repos/eclipse/che/statuses/d69a539361d676cc53e656085f02dea29c84b592","head":{"label":"kaloyan-raev:php-ls","ref":"php-ls","sha":"d69a539361d676cc53e656085f02dea29c84b592","user":{"login":"kaloyan-raev","id":468091,"avatar_url":"https://avatars.githubusercontent.com/u/468091?v=3","gravatar_id":"","url":"https://api.github.com/users/kaloyan-raev","html_url":"https://github.com/kaloyan-raev","followers_url":"https://api.github.com/users/kaloyan-raev/followers","following_url":"https://api.github.com/users/kaloyan-raev/following{/other_user}","gists_url":"https://api.github.com/users/kaloyan-raev/gists{/gist_id}","starred_url":"https://api.github.com/users/kaloyan-raev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaloyan-raev/subscriptions","organizations_url":"https://api.github.com/users/kaloyan-raev/orgs","repos_url":"https://api.github.com/users/kaloyan-raev/repos","events_url":"https://api.github.com/users/kaloyan-raev/events{/privacy}","received_events_url":"https://api.github.com/users/kaloyan-raev/received_events","type":"User","site_admin":false},"repo":{"id":56265032,"name":"che","full_name":"kaloyan-raev/che","owner":{"login":"kaloyan-raev","id":468091,"avatar_url":"https://avatars.githubusercontent.com/u/468091?v=3","gravatar_id":"","url":"https://api.github.com/users/kaloyan-raev","html_url":"https://github.com/kaloyan-raev","followers_url":"https://api.github.com/users/kaloyan-raev/followers","following_url":"https://api.github.com/users/kaloyan-raev/following{/other_user}","gists_url":"https://api.github.com/users/kaloyan-raev/gists{/gist_id}","starred_url":"https://api.github.com/users/kaloyan-raev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaloyan-raev/subscriptions","organizations_url":"https://api.github.com/users/kaloyan-raev/orgs","repos_url":"https://api.github.com/users/kaloyan-raev/repos","events_url":"https://api.github.com/users/kaloyan-raev/events{/privacy}","received_events_url":"https://api.github.com/users/kaloyan-raev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kaloyan-raev/che","description":"Eclipse Che: Next-generation Eclipse IDE.  Open source workspace server and cloud IDE.","fork":true,"url":"https://api.github.com/repos/kaloyan-raev/che","forks_url":"https://api.github.com/repos/kaloyan-raev/che/forks","keys_url":"https://api.github.com/repos/kaloyan-raev/che/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kaloyan-raev/che/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kaloyan-raev/che/teams","hooks_url":"https://api.github.com/repos/kaloyan-raev/che/hooks","issue_events_url":"https://api.github.com/repos/kaloyan-raev/che/issues/events{/number}","events_url":"https://api.github.com/repos/kaloyan-raev/che/events","assignees_url":"https://api.github.com/repos/kaloyan-raev/che/assignees{/user}","branches_url":"https://api.github.com/repos/kaloyan-raev/che/branches{/branch}","tags_url":"https://api.github.com/repos/kaloyan-raev/che/tags","blobs_url":"https://api.github.com/repos/kaloyan-raev/che/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kaloyan-raev/che/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kaloyan-raev/che/git/refs{/sha}","trees_url":"https://api.github.com/repos/kaloyan-raev/che/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kaloyan-raev/che/statuses/{sha}","languages_url":"https://api.github.com/repos/kaloyan-raev/che/languages","stargazers_url":"https://api.github.com/repos/kaloyan-raev/che/stargazers","contributors_url":"https://api.github.com/repos/kaloyan-raev/che/contributors","subscribers_url":"https://api.github.com/repos/kaloyan-raev/che/subscribers","subscription_url":"https://api.github.com/repos/kaloyan-raev/che/subscription","commits_url":"https://api.github.com/repos/kaloyan-raev/che/commits{/sha}","git_commits_url":"https://api.github.com/repos/kaloyan-raev/che/git/commits{/sha}","comments_url":"https://api.github.com/repos/kaloyan-raev/che/comments{/number}","issue_comment_url":"https://api.github.com/repos/kaloyan-raev/che/issues/comments{/number}","contents_url":"https://api.github.com/repos/kaloyan-raev/che/contents/{+path}","compare_url":"https://api.github.com/repos/kaloyan-raev/che/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kaloyan-raev/che/merges","archive_url":"https://api.github.com/repos/kaloyan-raev/che/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kaloyan-raev/che/downloads","issues_url":"https://api.github.com/repos/kaloyan-raev/che/issues{/number}","pulls_url":"https://api.github.com/repos/kaloyan-raev/che/pulls{/number}","milestones_url":"https://api.github.com/repos/kaloyan-raev/che/milestones{/number}","notifications_url":"https://api.github.com/repos/kaloyan-raev/che/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kaloyan-raev/che/labels{/name}","releases_url":"https://api.github.com/repos/kaloyan-raev/che/releases{/id}","deployments_url":"https://api.github.com/repos/kaloyan-raev/che/deployments","created_at":"2016-04-14T19:37:13Z","updated_at":"2016-04-14T19:37:28Z","pushed_at":"2016-10-24T13:12:49Z","git_url":"git://github.com/kaloyan-raev/che.git","ssh_url":"git@github.com:kaloyan-raev/che.git","clone_url":"https://github.com/kaloyan-raev/che.git","svn_url":"https://github.com/kaloyan-raev/che","homepage":"http://eclipse.org/che","size":32877,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"eclipse:master","ref":"master","sha":"94d12dea7bcede8f70e02bc78bb865912478b9c3","user":{"login":"eclipse","id":56974,"avatar_url":"https://avatars.githubusercontent.com/u/56974?v=3","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":32935745,"name":"che","full_name":"eclipse/che","owner":{"login":"eclipse","id":56974,"avatar_url":"https://avatars.githubusercontent.com/u/56974?v=3","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eclipse/che","description":"Eclipse Che: Next-generation Eclipse IDE.  Open source workspace server and cloud IDE.","fork":false,"url":"https://api.github.com/repos/eclipse/che","forks_url":"https://api.github.com/repos/eclipse/che/forks","keys_url":"https://api.github.com/repos/eclipse/che/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/che/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/che/teams","hooks_url":"https://api.github.com/repos/eclipse/che/hooks","issue_events_url":"https://api.github.com/repos/eclipse/che/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/che/events","assignees_url":"https://api.github.com/repos/eclipse/che/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/che/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/che/tags","blobs_url":"https://api.github.com/repos/eclipse/che/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/che/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/che/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/che/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/che/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/che/languages","stargazers_url":"https://api.github.com/repos/eclipse/che/stargazers","contributors_url":"https://api.github.com/repos/eclipse/che/contributors","subscribers_url":"https://api.github.com/repos/eclipse/che/subscribers","subscription_url":"https://api.github.com/repos/eclipse/che/subscription","commits_url":"https://api.github.com/repos/eclipse/che/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/che/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/che/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/che/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/che/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/che/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/che/merges","archive_url":"https://api.github.com/repos/eclipse/che/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/che/downloads","issues_url":"https://api.github.com/repos/eclipse/che/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/che/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/che/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/che/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/che/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/che/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/che/deployments","created_at":"2015-03-26T15:31:01Z","updated_at":"2016-10-26T07:07:16Z","pushed_at":"2016-10-26T19:11:23Z","git_url":"git://github.com/eclipse/che.git","ssh_url":"git@github.com:eclipse/che.git","clone_url":"https://github.com/eclipse/che.git","svn_url":"https://github.com/eclipse/che","homepage":"http://eclipse.org/che","size":54566,"stargazers_count":3272,"watchers_count":3272,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":539,"mirror_url":null,"open_issues_count":362,"forks":539,"open_issues":362,"watchers":3272,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/che/pulls/2830"},"html":{"href":"https://github.com/eclipse/che/pull/2830"},"issue":{"href":"https://api.github.com/repos/eclipse/che/issues/2830"},"comments":{"href":"https://api.github.com/repos/eclipse/che/issues/2830/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/che/pulls/2830/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/che/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/che/pulls/2830/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/che/statuses/d69a539361d676cc53e656085f02dea29c84b592"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"vparfonov","id":1636592,"avatar_url":"https://avatars.githubusercontent.com/u/1636592?v=3","gravatar_id":"","url":"https://api.github.com/users/vparfonov","html_url":"https://github.com/vparfonov","followers_url":"https://api.github.com/users/vparfonov/followers","following_url":"https://api.github.com/users/vparfonov/following{/other_user}","gists_url":"https://api.github.com/users/vparfonov/gists{/gist_id}","starred_url":"https://api.github.com/users/vparfonov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vparfonov/subscriptions","organizations_url":"https://api.github.com/users/vparfonov/orgs","repos_url":"https://api.github.com/users/vparfonov/repos","events_url":"https://api.github.com/users/vparfonov/events{/privacy}","received_events_url":"https://api.github.com/users/vparfonov/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":1,"additions":6,"deletions":110,"changed_files":2}}
{"actor":{"display_login":"vparfonov"}}