{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/msbuild/pulls/comments/87271938","pull_request_review_id":7873665,"id":87271938,"diff_hunk":"@@ -3166,6 +3167,22 @@ Copyright (C) Microsoft Corporation. All rights reserved.\n \n   <!--\n     ============================================================\n+                                        _GenerateCompilerDependencyFile\n+\n+    Generate file with a list of compile source files. This is used to track\n+    incremental build between build execution specifically around addition and\n+    deletions of file globs (e.g. <Compile Include=\"**\\*.cs\" />).\n+    ============================================================\n+    -->\n+  <Target Name=\"_GenerateCompilerDependencyFile\" BeforeTargets=\"CoreCompile\">\n+    <WriteLinesToFile Lines=\"@(Compile->'%(FullPath)')\" File=\"$(IntermediateOutputPath)Compile.deps\" Overwrite=\"True\" WriteOnlyWhenDifferent=\"True\" />","path":"src/XMakeTasks/Microsoft.Common.CurrentVersion.targets","position":20,"original_position":20,"commit_id":"add61d1d98489826746efe875d183b593485232a","original_commit_id":"add61d1d98489826746efe875d183b593485232a","user":{"login":"rainersigwald","id":3347530,"avatar_url":"https://avatars.githubusercontent.com/u/3347530?v=3","gravatar_id":"","url":"https://api.github.com/users/rainersigwald","html_url":"https://github.com/rainersigwald","followers_url":"https://api.github.com/users/rainersigwald/followers","following_url":"https://api.github.com/users/rainersigwald/following{/other_user}","gists_url":"https://api.github.com/users/rainersigwald/gists{/gist_id}","starred_url":"https://api.github.com/users/rainersigwald/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rainersigwald/subscriptions","organizations_url":"https://api.github.com/users/rainersigwald/orgs","repos_url":"https://api.github.com/users/rainersigwald/repos","events_url":"https://api.github.com/users/rainersigwald/events{/privacy}","received_events_url":"https://api.github.com/users/rainersigwald/received_events","type":"User","site_admin":false},"body":"I don't like `.deps`, especially since there's already the `.deps.json` files for .NET Core. Maybe `.CompilerInputs`?","created_at":"2016-11-09T20:33:42Z","updated_at":"2016-11-09T20:33:42Z","html_url":"https://github.com/Microsoft/msbuild/pull/1328#discussion_r87271938","pull_request_url":"https://api.github.com/repos/Microsoft/msbuild/pulls/1328","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/msbuild/pulls/comments/87271938"},"html":{"href":"https://github.com/Microsoft/msbuild/pull/1328#discussion_r87271938"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/msbuild/pulls/1328"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/msbuild/pulls/1328","id":92911256,"html_url":"https://github.com/Microsoft/msbuild/pull/1328","diff_url":"https://github.com/Microsoft/msbuild/pull/1328.diff","patch_url":"https://github.com/Microsoft/msbuild/pull/1328.patch","issue_url":"https://api.github.com/repos/Microsoft/msbuild/issues/1328","number":1328,"state":"open","locked":false,"title":"Improve incremental build in presence of globs","user":{"login":"AndyGerlicher","id":9847849,"avatar_url":"https://avatars.githubusercontent.com/u/9847849?v=3","gravatar_id":"","url":"https://api.github.com/users/AndyGerlicher","html_url":"https://github.com/AndyGerlicher","followers_url":"https://api.github.com/users/AndyGerlicher/followers","following_url":"https://api.github.com/users/AndyGerlicher/following{/other_user}","gists_url":"https://api.github.com/users/AndyGerlicher/gists{/gist_id}","starred_url":"https://api.github.com/users/AndyGerlicher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndyGerlicher/subscriptions","organizations_url":"https://api.github.com/users/AndyGerlicher/orgs","repos_url":"https://api.github.com/users/AndyGerlicher/repos","events_url":"https://api.github.com/users/AndyGerlicher/events{/privacy}","received_events_url":"https://api.github.com/users/AndyGerlicher/received_events","type":"User","site_admin":false},"body":"First iteration, looking for feedback. Filename, where I ended up putting it (Common targets vs Roslyn Core targets, etc.).\r\n\r\n* Fix issue with incremental build with globs.\r\nAdd a target that runs before CoreCompile that will record and store the state of the Compile ItemGroup. This file is added to the CustomAdditionalCompileInputs which is an input to CoreCompile. When this file changes, CoreCompile will run again. This fixes the issue of deleting a file or adding a file with an old timestamp to a glob (e.g. *.cs).\r\n\r\n* Add WriteOnlyWhenDifferent to WriteLinesToFile\r\nAdd option to not write the file when the file would not have changed (preserves the timestamp).\r\n\r\nThe original prototype wrote the file after compile and then subsequent runs could read that before compile and compare the file to the Compile ItemGroup. I went with this approach as it was far simpler and hopefully more elegant, but required a change to WriteLinesToFile to preserve the time stamp when the file doesn't change.","created_at":"2016-11-09T06:27:16Z","updated_at":"2016-11-09T20:47:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9f86e6178230413993f7f334d708c74437c7beab","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/msbuild/pulls/1328/commits","review_comments_url":"https://api.github.com/repos/Microsoft/msbuild/pulls/1328/comments","review_comment_url":"https://api.github.com/repos/Microsoft/msbuild/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/msbuild/issues/1328/comments","statuses_url":"https://api.github.com/repos/Microsoft/msbuild/statuses/add61d1d98489826746efe875d183b593485232a","head":{"label":"AndyGerlicher:cscincrementalglob","ref":"cscincrementalglob","sha":"add61d1d98489826746efe875d183b593485232a","user":{"login":"AndyGerlicher","id":9847849,"avatar_url":"https://avatars.githubusercontent.com/u/9847849?v=3","gravatar_id":"","url":"https://api.github.com/users/AndyGerlicher","html_url":"https://github.com/AndyGerlicher","followers_url":"https://api.github.com/users/AndyGerlicher/followers","following_url":"https://api.github.com/users/AndyGerlicher/following{/other_user}","gists_url":"https://api.github.com/users/AndyGerlicher/gists{/gist_id}","starred_url":"https://api.github.com/users/AndyGerlicher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndyGerlicher/subscriptions","organizations_url":"https://api.github.com/users/AndyGerlicher/orgs","repos_url":"https://api.github.com/users/AndyGerlicher/repos","events_url":"https://api.github.com/users/AndyGerlicher/events{/privacy}","received_events_url":"https://api.github.com/users/AndyGerlicher/received_events","type":"User","site_admin":false},"repo":{"id":32488219,"name":"msbuild","full_name":"AndyGerlicher/msbuild","owner":{"login":"AndyGerlicher","id":9847849,"avatar_url":"https://avatars.githubusercontent.com/u/9847849?v=3","gravatar_id":"","url":"https://api.github.com/users/AndyGerlicher","html_url":"https://github.com/AndyGerlicher","followers_url":"https://api.github.com/users/AndyGerlicher/followers","following_url":"https://api.github.com/users/AndyGerlicher/following{/other_user}","gists_url":"https://api.github.com/users/AndyGerlicher/gists{/gist_id}","starred_url":"https://api.github.com/users/AndyGerlicher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndyGerlicher/subscriptions","organizations_url":"https://api.github.com/users/AndyGerlicher/orgs","repos_url":"https://api.github.com/users/AndyGerlicher/repos","events_url":"https://api.github.com/users/AndyGerlicher/events{/privacy}","received_events_url":"https://api.github.com/users/AndyGerlicher/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AndyGerlicher/msbuild","description":"The Microsoft Build Engine (MSBuild) is the build platform for .NET and Visual Studio.","fork":true,"url":"https://api.github.com/repos/AndyGerlicher/msbuild","forks_url":"https://api.github.com/repos/AndyGerlicher/msbuild/forks","keys_url":"https://api.github.com/repos/AndyGerlicher/msbuild/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AndyGerlicher/msbuild/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AndyGerlicher/msbuild/teams","hooks_url":"https://api.github.com/repos/AndyGerlicher/msbuild/hooks","issue_events_url":"https://api.github.com/repos/AndyGerlicher/msbuild/issues/events{/number}","events_url":"https://api.github.com/repos/AndyGerlicher/msbuild/events","assignees_url":"https://api.github.com/repos/AndyGerlicher/msbuild/assignees{/user}","branches_url":"https://api.github.com/repos/AndyGerlicher/msbuild/branches{/branch}","tags_url":"https://api.github.com/repos/AndyGerlicher/msbuild/tags","blobs_url":"https://api.github.com/repos/AndyGerlicher/msbuild/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AndyGerlicher/msbuild/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AndyGerlicher/msbuild/git/refs{/sha}","trees_url":"https://api.github.com/repos/AndyGerlicher/msbuild/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AndyGerlicher/msbuild/statuses/{sha}","languages_url":"https://api.github.com/repos/AndyGerlicher/msbuild/languages","stargazers_url":"https://api.github.com/repos/AndyGerlicher/msbuild/stargazers","contributors_url":"https://api.github.com/repos/AndyGerlicher/msbuild/contributors","subscribers_url":"https://api.github.com/repos/AndyGerlicher/msbuild/subscribers","subscription_url":"https://api.github.com/repos/AndyGerlicher/msbuild/subscription","commits_url":"https://api.github.com/repos/AndyGerlicher/msbuild/commits{/sha}","git_commits_url":"https://api.github.com/repos/AndyGerlicher/msbuild/git/commits{/sha}","comments_url":"https://api.github.com/repos/AndyGerlicher/msbuild/comments{/number}","issue_comment_url":"https://api.github.com/repos/AndyGerlicher/msbuild/issues/comments{/number}","contents_url":"https://api.github.com/repos/AndyGerlicher/msbuild/contents/{+path}","compare_url":"https://api.github.com/repos/AndyGerlicher/msbuild/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AndyGerlicher/msbuild/merges","archive_url":"https://api.github.com/repos/AndyGerlicher/msbuild/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AndyGerlicher/msbuild/downloads","issues_url":"https://api.github.com/repos/AndyGerlicher/msbuild/issues{/number}","pulls_url":"https://api.github.com/repos/AndyGerlicher/msbuild/pulls{/number}","milestones_url":"https://api.github.com/repos/AndyGerlicher/msbuild/milestones{/number}","notifications_url":"https://api.github.com/repos/AndyGerlicher/msbuild/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AndyGerlicher/msbuild/labels{/name}","releases_url":"https://api.github.com/repos/AndyGerlicher/msbuild/releases{/id}","deployments_url":"https://api.github.com/repos/AndyGerlicher/msbuild/deployments","created_at":"2015-03-18T22:42:33Z","updated_at":"2016-01-14T23:55:33Z","pushed_at":"2016-11-09T06:21:58Z","git_url":"git://github.com/AndyGerlicher/msbuild.git","ssh_url":"git@github.com:AndyGerlicher/msbuild.git","clone_url":"https://github.com/AndyGerlicher/msbuild.git","svn_url":"https://github.com/AndyGerlicher/msbuild","homepage":null,"size":15334,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:xplat","ref":"xplat","sha":"59da91fabe68aa52a856d7dbc9a3a9fecdb6d31a","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":32051890,"name":"msbuild","full_name":"Microsoft/msbuild","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/msbuild","description":"The Microsoft Build Engine (MSBuild) is the build platform for .NET and Visual Studio.","fork":false,"url":"https://api.github.com/repos/Microsoft/msbuild","forks_url":"https://api.github.com/repos/Microsoft/msbuild/forks","keys_url":"https://api.github.com/repos/Microsoft/msbuild/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/msbuild/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/msbuild/teams","hooks_url":"https://api.github.com/repos/Microsoft/msbuild/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/msbuild/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/msbuild/events","assignees_url":"https://api.github.com/repos/Microsoft/msbuild/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/msbuild/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/msbuild/tags","blobs_url":"https://api.github.com/repos/Microsoft/msbuild/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/msbuild/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/msbuild/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/msbuild/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/msbuild/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/msbuild/languages","stargazers_url":"https://api.github.com/repos/Microsoft/msbuild/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/msbuild/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/msbuild/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/msbuild/subscription","commits_url":"https://api.github.com/repos/Microsoft/msbuild/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/msbuild/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/msbuild/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/msbuild/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/msbuild/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/msbuild/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/msbuild/merges","archive_url":"https://api.github.com/repos/Microsoft/msbuild/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/msbuild/downloads","issues_url":"https://api.github.com/repos/Microsoft/msbuild/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/msbuild/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/msbuild/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/msbuild/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/msbuild/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/msbuild/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/msbuild/deployments","created_at":"2015-03-12T02:04:46Z","updated_at":"2016-11-09T07:03:30Z","pushed_at":"2016-11-09T17:40:08Z","git_url":"git://github.com/Microsoft/msbuild.git","ssh_url":"git@github.com:Microsoft/msbuild.git","clone_url":"https://github.com/Microsoft/msbuild.git","svn_url":"https://github.com/Microsoft/msbuild","homepage":null,"size":19328,"stargazers_count":2757,"watchers_count":2757,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":561,"mirror_url":null,"open_issues_count":344,"forks":561,"open_issues":344,"watchers":2757,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/msbuild/pulls/1328"},"html":{"href":"https://github.com/Microsoft/msbuild/pull/1328"},"issue":{"href":"https://api.github.com/repos/Microsoft/msbuild/issues/1328"},"comments":{"href":"https://api.github.com/repos/Microsoft/msbuild/issues/1328/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/msbuild/pulls/1328/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/msbuild/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/msbuild/pulls/1328/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/msbuild/statuses/add61d1d98489826746efe875d183b593485232a"}}}}
{"actor":{"display_login":"rainersigwald"}}