{"action":"created","issue":{"url":"https://api.github.com/repos/mikaelbr/node-notifier/issues/94","repository_url":"https://api.github.com/repos/mikaelbr/node-notifier","labels_url":"https://api.github.com/repos/mikaelbr/node-notifier/issues/94/labels{/name}","comments_url":"https://api.github.com/repos/mikaelbr/node-notifier/issues/94/comments","events_url":"https://api.github.com/repos/mikaelbr/node-notifier/issues/94/events","html_url":"https://github.com/mikaelbr/node-notifier/issues/94","id":129177465,"number":94,"title":"webpack and node-notifier","user":{"login":"jmc420","id":11723529,"avatar_url":"https://avatars.githubusercontent.com/u/11723529?v=3","gravatar_id":"","url":"https://api.github.com/users/jmc420","html_url":"https://github.com/jmc420","followers_url":"https://api.github.com/users/jmc420/followers","following_url":"https://api.github.com/users/jmc420/following{/other_user}","gists_url":"https://api.github.com/users/jmc420/gists{/gist_id}","starred_url":"https://api.github.com/users/jmc420/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmc420/subscriptions","organizations_url":"https://api.github.com/users/jmc420/orgs","repos_url":"https://api.github.com/users/jmc420/repos","events_url":"https://api.github.com/users/jmc420/events{/privacy}","received_events_url":"https://api.github.com/users/jmc420/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/mikaelbr/node-notifier/labels/Bug","name":"Bug","color":"e11d21"},{"url":"https://api.github.com/repos/mikaelbr/node-notifier/labels/Needs%20Review","name":"Needs Review","color":"5319e7"}],"state":"closed","locked":false,"assignee":{"login":"mikaelbr","id":606374,"avatar_url":"https://avatars.githubusercontent.com/u/606374?v=3","gravatar_id":"","url":"https://api.github.com/users/mikaelbr","html_url":"https://github.com/mikaelbr","followers_url":"https://api.github.com/users/mikaelbr/followers","following_url":"https://api.github.com/users/mikaelbr/following{/other_user}","gists_url":"https://api.github.com/users/mikaelbr/gists{/gist_id}","starred_url":"https://api.github.com/users/mikaelbr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikaelbr/subscriptions","organizations_url":"https://api.github.com/users/mikaelbr/orgs","repos_url":"https://api.github.com/users/mikaelbr/repos","events_url":"https://api.github.com/users/mikaelbr/events{/privacy}","received_events_url":"https://api.github.com/users/mikaelbr/received_events","type":"User","site_admin":false},"milestone":null,"comments":14,"created_at":"2016-01-27T15:29:43Z","updated_at":"2016-03-12T17:19:37Z","closed_at":"2016-03-12T17:12:51Z","body":"Hi\r\n\r\nI have been using node-notifier in an electron app and it works fine until I use webpack to concatenate everything into a single file.\r\n\r\nthere are 2 issues:\r\n\r\n1. semver version\r\n\r\nCould you upgrade the version of semver in package.json to \"semver\": \"^5.1.0\".\r\n\r\nUsing the earlier version of semver causes a problem when you use webpack:\r\n\r\nhttps://github.com/webpack/webpack/issues/1942\r\n\r\nI can stop this problem if I locally upgrade the node-notifier semver version.\r\n\r\n2. notifications stop when using webpack version because it calculates the location of teminal-notifier-app incorrectly.\r\n\r\nI guess this is similar to the electron asar problem that you mention in the main README. \r\n\r\nThis line of code:\r\n\r\nnotifier = path.join(__dirname, '../vendor/terminal-notifier.app/Contents/MacOS/terminal-notifier'),\r\n\t  \r\ngets the wrong path. __dirname points to the directory of the webpack bundled js file and so it does not find node_modules/node-notifier/vendor directory correctly. I guess the simplest solution is just to copy the vendor directory into location ../vendor relative to the webpack bundle."},"comment":{"url":"https://api.github.com/repos/mikaelbr/node-notifier/issues/comments/195776762","html_url":"https://github.com/mikaelbr/node-notifier/issues/94#issuecomment-195776762","issue_url":"https://api.github.com/repos/mikaelbr/node-notifier/issues/94","id":195776762,"user":{"login":"jaulz","id":5358638,"avatar_url":"https://avatars.githubusercontent.com/u/5358638?v=3","gravatar_id":"","url":"https://api.github.com/users/jaulz","html_url":"https://github.com/jaulz","followers_url":"https://api.github.com/users/jaulz/followers","following_url":"https://api.github.com/users/jaulz/following{/other_user}","gists_url":"https://api.github.com/users/jaulz/gists{/gist_id}","starred_url":"https://api.github.com/users/jaulz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaulz/subscriptions","organizations_url":"https://api.github.com/users/jaulz/orgs","repos_url":"https://api.github.com/users/jaulz/repos","events_url":"https://api.github.com/users/jaulz/events{/privacy}","received_events_url":"https://api.github.com/users/jaulz/received_events","type":"User","site_admin":false},"created_at":"2016-03-12T17:19:37Z","updated_at":"2016-03-12T17:19:37Z","body":"Yep, many thanks :) "}}