{"action":"created","issue":{"url":"https://api.github.com/repos/xbmc/xbmc/issues/9300","repository_url":"https://api.github.com/repos/xbmc/xbmc","labels_url":"https://api.github.com/repos/xbmc/xbmc/issues/9300/labels{/name}","comments_url":"https://api.github.com/repos/xbmc/xbmc/issues/9300/comments","events_url":"https://api.github.com/repos/xbmc/xbmc/issues/9300/events","html_url":"https://github.com/xbmc/xbmc/pull/9300","id":139335592,"number":9300,"title":"Improvements to AudioLibrary.GetArtists, GetAlbums and GetSongs ","user":{"login":"DaveTBlake","id":13371422,"avatar_url":"https://avatars.githubusercontent.com/u/13371422?v=3","gravatar_id":"","url":"https://api.github.com/users/DaveTBlake","html_url":"https://github.com/DaveTBlake","followers_url":"https://api.github.com/users/DaveTBlake/followers","following_url":"https://api.github.com/users/DaveTBlake/following{/other_user}","gists_url":"https://api.github.com/users/DaveTBlake/gists{/gist_id}","starred_url":"https://api.github.com/users/DaveTBlake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DaveTBlake/subscriptions","organizations_url":"https://api.github.com/users/DaveTBlake/orgs","repos_url":"https://api.github.com/users/DaveTBlake/repos","events_url":"https://api.github.com/users/DaveTBlake/events{/privacy}","received_events_url":"https://api.github.com/users/DaveTBlake/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/xbmc/xbmc/labels/Improvement","name":"Improvement","color":"0b02e1"},{"url":"https://api.github.com/repos/xbmc/xbmc/labels/JSON-RPC%20API%20Change","name":"JSON-RPC API Change","color":"e11d21"},{"url":"https://api.github.com/repos/xbmc/xbmc/labels/Krypton","name":"Krypton","color":"fbca04"},{"url":"https://api.github.com/repos/xbmc/xbmc/labels/Music","name":"Music","color":"009800"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2016-03-08T17:07:59Z","updated_at":"2016-03-10T10:13:22Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/9300","html_url":"https://github.com/xbmc/xbmc/pull/9300","diff_url":"https://github.com/xbmc/xbmc/pull/9300.diff","patch_url":"https://github.com/xbmc/xbmc/pull/9300.patch"},"body":"API improvements to AudioLibrary.GetArtists, GetAlbums and GetSongs. This follows on from  #8015 and the addition of artist roles to the music library, and adresses some flaws that were in the initial API implementation for accessing artist role data.\r\n\r\nIt also attempts to fix some longer standing issues: GetArtists now returns the song genres and genreids of the songs of each artist, and a flag if the artist is an \"album artist\". Thus returning the data values that correspond to the filters. It  makes it clearer in the documentation that the only genre filtering currently offered is song genre (not the artist genre value that can be scraped, stored and displayed but is not used in queries). Extending filtering to all kinds of genre (artist and album) is something for another PR.\r\n\r\n@Montellese you have seen all of this before, so hope that all is well.\r\n@JoeTheFox finally catching up with the iOS remote!\r\n@Tolriq I think this covers the many things you pointed out with roles, but also improves GetArtists generally in the way I said I would. More work to do of course, especially with genre, but this seems enough for one PR."},"comment":{"url":"https://api.github.com/repos/xbmc/xbmc/issues/comments/194773483","html_url":"https://github.com/xbmc/xbmc/pull/9300#issuecomment-194773483","issue_url":"https://api.github.com/repos/xbmc/xbmc/issues/9300","id":194773483,"user":{"login":"Tolriq","id":932609,"avatar_url":"https://avatars.githubusercontent.com/u/932609?v=3","gravatar_id":"","url":"https://api.github.com/users/Tolriq","html_url":"https://github.com/Tolriq","followers_url":"https://api.github.com/users/Tolriq/followers","following_url":"https://api.github.com/users/Tolriq/following{/other_user}","gists_url":"https://api.github.com/users/Tolriq/gists{/gist_id}","starred_url":"https://api.github.com/users/Tolriq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tolriq/subscriptions","organizations_url":"https://api.github.com/users/Tolriq/orgs","repos_url":"https://api.github.com/users/Tolriq/repos","events_url":"https://api.github.com/users/Tolriq/events{/privacy}","received_events_url":"https://api.github.com/users/Tolriq/received_events","type":"User","site_admin":false},"created_at":"2016-03-10T10:13:22Z","updated_at":"2016-03-10T10:13:22Z","body":"Well easy to see in Code ;)\r\n\r\nFunction rename :\r\nhttps://github.com/xbmc/xbmc/pull/9300/files#diff-c5ebd35927606ffb9137e86cb28a4120L114\r\n\r\nPositional parameter changed : \r\nhttps://github.com/xbmc/xbmc/pull/9300/files#diff-1bb266d43e6d1a19799e53fcf6371260L466"}}