{"action":"created","comment":{"url":"https://api.github.com/repos/gramps-project/gramps/pulls/comments/70124585","id":70124585,"diff_hunk":"@@ -781,7 +781,10 @@ def __readahead(self):\n                 # There will normally only be one space between tag and\n                 # line_value, but in case there is more then one, remove extra\n                 # spaces after CONC/CONT processing\n-                data = data[:2] + (data[2].strip(),) + data[3:]\n+                # Also, Gedcom spec says there should be no spaces at end of\n+                # line, however some programs put them there (FTM), so lets","path":"gramps/plugins/lib/libgedcom.py","position":6,"original_position":6,"commit_id":"617569a234ccfb82d47de9c78b9ef46e61c7ea13","original_commit_id":"617569a234ccfb82d47de9c78b9ef46e61c7ea13","user":{"login":"QuLogic","id":302469,"avatar_url":"https://avatars.githubusercontent.com/u/302469?v=3","gravatar_id":"","url":"https://api.github.com/users/QuLogic","html_url":"https://github.com/QuLogic","followers_url":"https://api.github.com/users/QuLogic/followers","following_url":"https://api.github.com/users/QuLogic/following{/other_user}","gists_url":"https://api.github.com/users/QuLogic/gists{/gist_id}","starred_url":"https://api.github.com/users/QuLogic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/QuLogic/subscriptions","organizations_url":"https://api.github.com/users/QuLogic/orgs","repos_url":"https://api.github.com/users/QuLogic/repos","events_url":"https://api.github.com/users/QuLogic/events{/privacy}","received_events_url":"https://api.github.com/users/QuLogic/received_events","type":"User","site_admin":false},"body":"let's","created_at":"2016-07-08T19:01:28Z","updated_at":"2016-07-08T19:01:28Z","html_url":"https://github.com/gramps-project/gramps/pull/191#discussion_r70124585","pull_request_url":"https://api.github.com/repos/gramps-project/gramps/pulls/191","_links":{"self":{"href":"https://api.github.com/repos/gramps-project/gramps/pulls/comments/70124585"},"html":{"href":"https://github.com/gramps-project/gramps/pull/191#discussion_r70124585"},"pull_request":{"href":"https://api.github.com/repos/gramps-project/gramps/pulls/191"}}},"pull_request":{"url":"https://api.github.com/repos/gramps-project/gramps/pulls/191","id":76781968,"html_url":"https://github.com/gramps-project/gramps/pull/191","diff_url":"https://github.com/gramps-project/gramps/pull/191.diff","patch_url":"https://github.com/gramps-project/gramps/pull/191.patch","issue_url":"https://api.github.com/repos/gramps-project/gramps/issues/191","number":191,"state":"open","locked":false,"title":"Bug 9479 Gedcom import loses spaces in text fields from FTM","user":{"login":"prculley","id":18122203,"avatar_url":"https://avatars.githubusercontent.com/u/18122203?v=3","gravatar_id":"","url":"https://api.github.com/users/prculley","html_url":"https://github.com/prculley","followers_url":"https://api.github.com/users/prculley/followers","following_url":"https://api.github.com/users/prculley/following{/other_user}","gists_url":"https://api.github.com/users/prculley/gists{/gist_id}","starred_url":"https://api.github.com/users/prculley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prculley/subscriptions","organizations_url":"https://api.github.com/users/prculley/orgs","repos_url":"https://api.github.com/users/prculley/repos","events_url":"https://api.github.com/users/prculley/events{/privacy}","received_events_url":"https://api.github.com/users/prculley/received_events","type":"User","site_admin":false},"body":"GEDCOM specifies that when using a CONC continuation line, any spaces that fall at the line break should be placed at the front, one space after the 'CONC' tag.\r\nFTM (Family Tree Maker) has historically been doing the opposite; it places spaces at the end of the line, where it is not easily seen in most editors, and where it is in violation of the GEDCOM spec. I've quoted the lines below so the space is clear.\r\n\r\n<pre>  \"2 NOTE The FTM way to do a CONC line with space at end --> \"\r\n  \"3 CONC <--\"\r\n  \"2 NOTE The GEDCOM spec way to do CONC line, with space at beginning -->\"\r\n  \"3 CONC  <--\"\r\n  \"2 NOTE Be nice if we supported FTM way to do CONC so \"\r\n  \"3 CONC users would not have to spell check and edit their whole \"\r\n  \"3 CONC database for these kind of errors.\" </pre>\r\n\r\n\r\nWith Gramps current code, the user end ends up with words run together like this:\r\n<pre>  \"The FTM way to do a CONC line with space at end --><--\"\r\n  \"Be nice if we supported FTM way to do CONC sousers would not have to spell check and edit their wholedatabase for these kind of errors.\"</pre>\r\n\r\nIt is possible to support both the GEDCOM specified way, and FTM way with a minor code patch. I think that this enhancement is very worthwhile.\r\nMy import tests have had a test in place for a while that exposes this, I just had to remove the exception 'imp_test_FTM_CONC.difs' file to make it pass.","created_at":"2016-07-08T16:51:41Z","updated_at":"2016-07-08T19:01:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ac0baccfafd066095ce60e9557bf70586596cdfe","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/gramps-project/gramps/pulls/191/commits","review_comments_url":"https://api.github.com/repos/gramps-project/gramps/pulls/191/comments","review_comment_url":"https://api.github.com/repos/gramps-project/gramps/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gramps-project/gramps/issues/191/comments","statuses_url":"https://api.github.com/repos/gramps-project/gramps/statuses/617569a234ccfb82d47de9c78b9ef46e61c7ea13","head":{"label":"prculley:bug9479","ref":"bug9479","sha":"617569a234ccfb82d47de9c78b9ef46e61c7ea13","user":{"login":"prculley","id":18122203,"avatar_url":"https://avatars.githubusercontent.com/u/18122203?v=3","gravatar_id":"","url":"https://api.github.com/users/prculley","html_url":"https://github.com/prculley","followers_url":"https://api.github.com/users/prculley/followers","following_url":"https://api.github.com/users/prculley/following{/other_user}","gists_url":"https://api.github.com/users/prculley/gists{/gist_id}","starred_url":"https://api.github.com/users/prculley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prculley/subscriptions","organizations_url":"https://api.github.com/users/prculley/orgs","repos_url":"https://api.github.com/users/prculley/repos","events_url":"https://api.github.com/users/prculley/events{/privacy}","received_events_url":"https://api.github.com/users/prculley/received_events","type":"User","site_admin":false},"repo":{"id":58143068,"name":"gramps","full_name":"prculley/gramps","owner":{"login":"prculley","id":18122203,"avatar_url":"https://avatars.githubusercontent.com/u/18122203?v=3","gravatar_id":"","url":"https://api.github.com/users/prculley","html_url":"https://github.com/prculley","followers_url":"https://api.github.com/users/prculley/followers","following_url":"https://api.github.com/users/prculley/following{/other_user}","gists_url":"https://api.github.com/users/prculley/gists{/gist_id}","starred_url":"https://api.github.com/users/prculley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prculley/subscriptions","organizations_url":"https://api.github.com/users/prculley/orgs","repos_url":"https://api.github.com/users/prculley/repos","events_url":"https://api.github.com/users/prculley/events{/privacy}","received_events_url":"https://api.github.com/users/prculley/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/prculley/gramps","description":"Source code for Gramps Genealogical program","fork":true,"url":"https://api.github.com/repos/prculley/gramps","forks_url":"https://api.github.com/repos/prculley/gramps/forks","keys_url":"https://api.github.com/repos/prculley/gramps/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prculley/gramps/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prculley/gramps/teams","hooks_url":"https://api.github.com/repos/prculley/gramps/hooks","issue_events_url":"https://api.github.com/repos/prculley/gramps/issues/events{/number}","events_url":"https://api.github.com/repos/prculley/gramps/events","assignees_url":"https://api.github.com/repos/prculley/gramps/assignees{/user}","branches_url":"https://api.github.com/repos/prculley/gramps/branches{/branch}","tags_url":"https://api.github.com/repos/prculley/gramps/tags","blobs_url":"https://api.github.com/repos/prculley/gramps/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prculley/gramps/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prculley/gramps/git/refs{/sha}","trees_url":"https://api.github.com/repos/prculley/gramps/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prculley/gramps/statuses/{sha}","languages_url":"https://api.github.com/repos/prculley/gramps/languages","stargazers_url":"https://api.github.com/repos/prculley/gramps/stargazers","contributors_url":"https://api.github.com/repos/prculley/gramps/contributors","subscribers_url":"https://api.github.com/repos/prculley/gramps/subscribers","subscription_url":"https://api.github.com/repos/prculley/gramps/subscription","commits_url":"https://api.github.com/repos/prculley/gramps/commits{/sha}","git_commits_url":"https://api.github.com/repos/prculley/gramps/git/commits{/sha}","comments_url":"https://api.github.com/repos/prculley/gramps/comments{/number}","issue_comment_url":"https://api.github.com/repos/prculley/gramps/issues/comments{/number}","contents_url":"https://api.github.com/repos/prculley/gramps/contents/{+path}","compare_url":"https://api.github.com/repos/prculley/gramps/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prculley/gramps/merges","archive_url":"https://api.github.com/repos/prculley/gramps/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prculley/gramps/downloads","issues_url":"https://api.github.com/repos/prculley/gramps/issues{/number}","pulls_url":"https://api.github.com/repos/prculley/gramps/pulls{/number}","milestones_url":"https://api.github.com/repos/prculley/gramps/milestones{/number}","notifications_url":"https://api.github.com/repos/prculley/gramps/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prculley/gramps/labels{/name}","releases_url":"https://api.github.com/repos/prculley/gramps/releases{/id}","deployments_url":"https://api.github.com/repos/prculley/gramps/deployments","created_at":"2016-05-05T15:57:11Z","updated_at":"2016-05-05T15:57:19Z","pushed_at":"2016-07-08T17:02:47Z","git_url":"git://github.com/prculley/gramps.git","ssh_url":"git@github.com:prculley/gramps.git","clone_url":"https://github.com/prculley/gramps.git","svn_url":"https://github.com/prculley/gramps","homepage":"https://gramps-project.org/","size":268824,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gramps-project:master","ref":"master","sha":"4e3706072e0a85ad17ba1c526118ed3205117aef","user":{"login":"gramps-project","id":10428818,"avatar_url":"https://avatars.githubusercontent.com/u/10428818?v=3","gravatar_id":"","url":"https://api.github.com/users/gramps-project","html_url":"https://github.com/gramps-project","followers_url":"https://api.github.com/users/gramps-project/followers","following_url":"https://api.github.com/users/gramps-project/following{/other_user}","gists_url":"https://api.github.com/users/gramps-project/gists{/gist_id}","starred_url":"https://api.github.com/users/gramps-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gramps-project/subscriptions","organizations_url":"https://api.github.com/users/gramps-project/orgs","repos_url":"https://api.github.com/users/gramps-project/repos","events_url":"https://api.github.com/users/gramps-project/events{/privacy}","received_events_url":"https://api.github.com/users/gramps-project/received_events","type":"Organization","site_admin":false},"repo":{"id":28895195,"name":"gramps","full_name":"gramps-project/gramps","owner":{"login":"gramps-project","id":10428818,"avatar_url":"https://avatars.githubusercontent.com/u/10428818?v=3","gravatar_id":"","url":"https://api.github.com/users/gramps-project","html_url":"https://github.com/gramps-project","followers_url":"https://api.github.com/users/gramps-project/followers","following_url":"https://api.github.com/users/gramps-project/following{/other_user}","gists_url":"https://api.github.com/users/gramps-project/gists{/gist_id}","starred_url":"https://api.github.com/users/gramps-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gramps-project/subscriptions","organizations_url":"https://api.github.com/users/gramps-project/orgs","repos_url":"https://api.github.com/users/gramps-project/repos","events_url":"https://api.github.com/users/gramps-project/events{/privacy}","received_events_url":"https://api.github.com/users/gramps-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gramps-project/gramps","description":"Source code for Gramps Genealogical program","fork":false,"url":"https://api.github.com/repos/gramps-project/gramps","forks_url":"https://api.github.com/repos/gramps-project/gramps/forks","keys_url":"https://api.github.com/repos/gramps-project/gramps/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gramps-project/gramps/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gramps-project/gramps/teams","hooks_url":"https://api.github.com/repos/gramps-project/gramps/hooks","issue_events_url":"https://api.github.com/repos/gramps-project/gramps/issues/events{/number}","events_url":"https://api.github.com/repos/gramps-project/gramps/events","assignees_url":"https://api.github.com/repos/gramps-project/gramps/assignees{/user}","branches_url":"https://api.github.com/repos/gramps-project/gramps/branches{/branch}","tags_url":"https://api.github.com/repos/gramps-project/gramps/tags","blobs_url":"https://api.github.com/repos/gramps-project/gramps/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gramps-project/gramps/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gramps-project/gramps/git/refs{/sha}","trees_url":"https://api.github.com/repos/gramps-project/gramps/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gramps-project/gramps/statuses/{sha}","languages_url":"https://api.github.com/repos/gramps-project/gramps/languages","stargazers_url":"https://api.github.com/repos/gramps-project/gramps/stargazers","contributors_url":"https://api.github.com/repos/gramps-project/gramps/contributors","subscribers_url":"https://api.github.com/repos/gramps-project/gramps/subscribers","subscription_url":"https://api.github.com/repos/gramps-project/gramps/subscription","commits_url":"https://api.github.com/repos/gramps-project/gramps/commits{/sha}","git_commits_url":"https://api.github.com/repos/gramps-project/gramps/git/commits{/sha}","comments_url":"https://api.github.com/repos/gramps-project/gramps/comments{/number}","issue_comment_url":"https://api.github.com/repos/gramps-project/gramps/issues/comments{/number}","contents_url":"https://api.github.com/repos/gramps-project/gramps/contents/{+path}","compare_url":"https://api.github.com/repos/gramps-project/gramps/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gramps-project/gramps/merges","archive_url":"https://api.github.com/repos/gramps-project/gramps/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gramps-project/gramps/downloads","issues_url":"https://api.github.com/repos/gramps-project/gramps/issues{/number}","pulls_url":"https://api.github.com/repos/gramps-project/gramps/pulls{/number}","milestones_url":"https://api.github.com/repos/gramps-project/gramps/milestones{/number}","notifications_url":"https://api.github.com/repos/gramps-project/gramps/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gramps-project/gramps/labels{/name}","releases_url":"https://api.github.com/repos/gramps-project/gramps/releases{/id}","deployments_url":"https://api.github.com/repos/gramps-project/gramps/deployments","created_at":"2015-01-07T02:51:48Z","updated_at":"2016-07-08T06:13:24Z","pushed_at":"2016-07-08T17:05:24Z","git_url":"git://github.com/gramps-project/gramps.git","ssh_url":"git@github.com:gramps-project/gramps.git","clone_url":"https://github.com/gramps-project/gramps.git","svn_url":"https://github.com/gramps-project/gramps","homepage":"https://gramps-project.org/","size":291704,"stargazers_count":143,"watchers_count":143,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":64,"mirror_url":null,"open_issues_count":8,"forks":64,"open_issues":8,"watchers":143,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gramps-project/gramps/pulls/191"},"html":{"href":"https://github.com/gramps-project/gramps/pull/191"},"issue":{"href":"https://api.github.com/repos/gramps-project/gramps/issues/191"},"comments":{"href":"https://api.github.com/repos/gramps-project/gramps/issues/191/comments"},"review_comments":{"href":"https://api.github.com/repos/gramps-project/gramps/pulls/191/comments"},"review_comment":{"href":"https://api.github.com/repos/gramps-project/gramps/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gramps-project/gramps/pulls/191/commits"},"statuses":{"href":"https://api.github.com/repos/gramps-project/gramps/statuses/617569a234ccfb82d47de9c78b9ef46e61c7ea13"}}}}
{"actor":{"display_login":"QuLogic"}}