{"action":"created","issue":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/9358","repository_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped","labels_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/9358/labels{/name}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/9358/comments","events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/9358/events","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/9358","id":155023913,"number":9358,"title":"corrected case on showdownjs where \"Converter\" had been assigned the …","user":{"login":"ciel","id":438196,"avatar_url":"https://avatars.githubusercontent.com/u/438196?v=3","gravatar_id":"","url":"https://api.github.com/users/ciel","html_url":"https://github.com/ciel","followers_url":"https://api.github.com/users/ciel/followers","following_url":"https://api.github.com/users/ciel/following{/other_user}","gists_url":"https://api.github.com/users/ciel/gists{/gist_id}","starred_url":"https://api.github.com/users/ciel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ciel/subscriptions","organizations_url":"https://api.github.com/users/ciel/orgs","repos_url":"https://api.github.com/users/ciel/repos","events_url":"https://api.github.com/users/ciel/events{/privacy}","received_events_url":"https://api.github.com/users/ciel/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-05-16T12:55:58Z","updated_at":"2016-05-16T12:56:01Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/9358","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/9358","diff_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/9358.diff","patch_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/9358.patch"},"body":"case 1. Add a new type definition.\r\n- [X] checked compilation succeeds with `--target es6` and `--noImplicitAny` options.\r\n- [X] has correct [naming convention](http://definitelytyped.org/guides/contributing.html#naming-the-file)\r\n- [X] has a [test file](http://definitelytyped.org/guides/contributing.html#tests) with the suffix of  `-tests.ts` or `-tests.tsx`.\r\n\r\ncase 2. Improvement to existing type definition.\r\n- documentation or source code reference which provides context for the suggested changes.  url https://github.com/showdownjs/showdown .\r\n  - it has been reviewed by a DefinitelyTyped member.\r\n\r\nThe typings for `showdownjs` had an incorrect typing; the function `Converter()` was at some point changed to have uppercasing instead of being lowercase, `converter`. This was causing an issue where attempts to run code that was typed correctly would throw errors, and attempts to write code that runs correctly would throw errors with the typescript definitions.\r\n\r\nThe appropriate syntax for the `Converter` function is seen here, taken from the [project's documentation](https://github.com/showdownjs/showdown)\r\n\r\n````\r\nvar converter = new showdown.Converter(),\r\n    text      = '#hello, markdown!',\r\n    html      = converter.makeHtml(text);\r\n````\r\n\r\nThis update has resolved the identifier."},"comment":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/comments/219418176","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/9358#issuecomment-219418176","issue_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/9358","id":219418176,"user":{"login":"dt-bot","id":7585416,"avatar_url":"https://avatars.githubusercontent.com/u/7585416?v=3","gravatar_id":"","url":"https://api.github.com/users/dt-bot","html_url":"https://github.com/dt-bot","followers_url":"https://api.github.com/users/dt-bot/followers","following_url":"https://api.github.com/users/dt-bot/following{/other_user}","gists_url":"https://api.github.com/users/dt-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/dt-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dt-bot/subscriptions","organizations_url":"https://api.github.com/users/dt-bot/orgs","repos_url":"https://api.github.com/users/dt-bot/repos","events_url":"https://api.github.com/users/dt-bot/events{/privacy}","received_events_url":"https://api.github.com/users/dt-bot/received_events","type":"User","site_admin":false},"created_at":"2016-05-16T12:56:00Z","updated_at":"2016-05-16T12:56:00Z","body":"*showdown/showdown.d.ts*\n\nto author (@cbowdon). Could you review this PR?\n:+1: or :-1:?\n\nChecklist\n\n* [ ] pass the Travis CI test?"}}