{"action":"created","comment":{"url":"https://api.github.com/repos/juwai/ansible-role-nodejs/pulls/comments/87130145","pull_request_review_id":7754101,"id":87130145,"diff_hunk":"@@ -19,3 +19,7 @@ nodejs_npm_global_packages: []\n #    version: 0.9.3\n #  # Install the latest stable release of a package.\n #  - name: node-sass\n+\n+# Import the Noesource RPM key by downloading with curl instead of using the rpm_key module directly, and then install the rpm file using curl and the yum module.","path":"defaults/main.yml","position":5,"original_position":5,"commit_id":"68a4f4351ee9b59dd5c7ef156a5d6fb7d26e665c","original_commit_id":"68a4f4351ee9b59dd5c7ef156a5d6fb7d26e665c","user":{"login":"tjoelsson","id":2793514,"avatar_url":"https://avatars.githubusercontent.com/u/2793514?v=3","gravatar_id":"","url":"https://api.github.com/users/tjoelsson","html_url":"https://github.com/tjoelsson","followers_url":"https://api.github.com/users/tjoelsson/followers","following_url":"https://api.github.com/users/tjoelsson/following{/other_user}","gists_url":"https://api.github.com/users/tjoelsson/gists{/gist_id}","starred_url":"https://api.github.com/users/tjoelsson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tjoelsson/subscriptions","organizations_url":"https://api.github.com/users/tjoelsson/orgs","repos_url":"https://api.github.com/users/tjoelsson/repos","events_url":"https://api.github.com/users/tjoelsson/events{/privacy}","received_events_url":"https://api.github.com/users/tjoelsson/received_events","type":"User","site_admin":false},"body":"Nodesource","created_at":"2016-11-09T03:50:05Z","updated_at":"2016-11-09T03:54:24Z","html_url":"https://github.com/juwai/ansible-role-nodejs/pull/1#discussion_r87130145","pull_request_url":"https://api.github.com/repos/juwai/ansible-role-nodejs/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/juwai/ansible-role-nodejs/pulls/comments/87130145"},"html":{"href":"https://github.com/juwai/ansible-role-nodejs/pull/1#discussion_r87130145"},"pull_request":{"href":"https://api.github.com/repos/juwai/ansible-role-nodejs/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/juwai/ansible-role-nodejs/pulls/1","id":92901697,"html_url":"https://github.com/juwai/ansible-role-nodejs/pull/1","diff_url":"https://github.com/juwai/ansible-role-nodejs/pull/1.diff","patch_url":"https://github.com/juwai/ansible-role-nodejs/pull/1.patch","issue_url":"https://api.github.com/repos/juwai/ansible-role-nodejs/issues/1","number":1,"state":"open","locked":false,"title":"Alternative way to install Nodesource repo with curl.","user":{"login":"KixPanganiban","id":2585982,"avatar_url":"https://avatars.githubusercontent.com/u/2585982?v=3","gravatar_id":"","url":"https://api.github.com/users/KixPanganiban","html_url":"https://github.com/KixPanganiban","followers_url":"https://api.github.com/users/KixPanganiban/followers","following_url":"https://api.github.com/users/KixPanganiban/following{/other_user}","gists_url":"https://api.github.com/users/KixPanganiban/gists{/gist_id}","starred_url":"https://api.github.com/users/KixPanganiban/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KixPanganiban/subscriptions","organizations_url":"https://api.github.com/users/KixPanganiban/orgs","repos_url":"https://api.github.com/users/KixPanganiban/repos","events_url":"https://api.github.com/users/KixPanganiban/events{/privacy}","received_events_url":"https://api.github.com/users/KixPanganiban/received_events","type":"User","site_admin":false},"body":"**_Defect_**\r\n\r\n## Summary of changes\r\n\r\n- Introduce alternative way to install Nodesource repo by downloading the needed files (`gpg` key and `rpm` file) with curl, instead of using the `rpm_key` and `yum` Ansible modules directly. This is a workaround to the SNI issue introduced when Nodesource moved to CloudFront.\r\n  - Add `curl_nodesource_rpm` variable (default: `true`) which does the above. If set to `false`, the keyfile and repo files are downloaded directly over HTTPS\r\n\r\n/fyi: @tjoelsson, @mark-juwai: Please review.\r\n","created_at":"2016-11-09T03:44:26Z","updated_at":"2016-11-09T03:54:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"129525ce2cedc8527e259272ccca31d1c95b4abd","assignee":{"login":"tjoelsson","id":2793514,"avatar_url":"https://avatars.githubusercontent.com/u/2793514?v=3","gravatar_id":"","url":"https://api.github.com/users/tjoelsson","html_url":"https://github.com/tjoelsson","followers_url":"https://api.github.com/users/tjoelsson/followers","following_url":"https://api.github.com/users/tjoelsson/following{/other_user}","gists_url":"https://api.github.com/users/tjoelsson/gists{/gist_id}","starred_url":"https://api.github.com/users/tjoelsson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tjoelsson/subscriptions","organizations_url":"https://api.github.com/users/tjoelsson/orgs","repos_url":"https://api.github.com/users/tjoelsson/repos","events_url":"https://api.github.com/users/tjoelsson/events{/privacy}","received_events_url":"https://api.github.com/users/tjoelsson/received_events","type":"User","site_admin":false},"assignees":[{"login":"tjoelsson","id":2793514,"avatar_url":"https://avatars.githubusercontent.com/u/2793514?v=3","gravatar_id":"","url":"https://api.github.com/users/tjoelsson","html_url":"https://github.com/tjoelsson","followers_url":"https://api.github.com/users/tjoelsson/followers","following_url":"https://api.github.com/users/tjoelsson/following{/other_user}","gists_url":"https://api.github.com/users/tjoelsson/gists{/gist_id}","starred_url":"https://api.github.com/users/tjoelsson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tjoelsson/subscriptions","organizations_url":"https://api.github.com/users/tjoelsson/orgs","repos_url":"https://api.github.com/users/tjoelsson/repos","events_url":"https://api.github.com/users/tjoelsson/events{/privacy}","received_events_url":"https://api.github.com/users/tjoelsson/received_events","type":"User","site_admin":false},{"login":"mark-juwai","id":8097976,"avatar_url":"https://avatars.githubusercontent.com/u/8097976?v=3","gravatar_id":"","url":"https://api.github.com/users/mark-juwai","html_url":"https://github.com/mark-juwai","followers_url":"https://api.github.com/users/mark-juwai/followers","following_url":"https://api.github.com/users/mark-juwai/following{/other_user}","gists_url":"https://api.github.com/users/mark-juwai/gists{/gist_id}","starred_url":"https://api.github.com/users/mark-juwai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mark-juwai/subscriptions","organizations_url":"https://api.github.com/users/mark-juwai/orgs","repos_url":"https://api.github.com/users/mark-juwai/repos","events_url":"https://api.github.com/users/mark-juwai/events{/privacy}","received_events_url":"https://api.github.com/users/mark-juwai/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/juwai/ansible-role-nodejs/pulls/1/commits","review_comments_url":"https://api.github.com/repos/juwai/ansible-role-nodejs/pulls/1/comments","review_comment_url":"https://api.github.com/repos/juwai/ansible-role-nodejs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/juwai/ansible-role-nodejs/issues/1/comments","statuses_url":"https://api.github.com/repos/juwai/ansible-role-nodejs/statuses/68a4f4351ee9b59dd5c7ef156a5d6fb7d26e665c","head":{"label":"KixPanganiban:PLAT-226-nodesource-sni-fix","ref":"PLAT-226-nodesource-sni-fix","sha":"68a4f4351ee9b59dd5c7ef156a5d6fb7d26e665c","user":{"login":"KixPanganiban","id":2585982,"avatar_url":"https://avatars.githubusercontent.com/u/2585982?v=3","gravatar_id":"","url":"https://api.github.com/users/KixPanganiban","html_url":"https://github.com/KixPanganiban","followers_url":"https://api.github.com/users/KixPanganiban/followers","following_url":"https://api.github.com/users/KixPanganiban/following{/other_user}","gists_url":"https://api.github.com/users/KixPanganiban/gists{/gist_id}","starred_url":"https://api.github.com/users/KixPanganiban/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KixPanganiban/subscriptions","organizations_url":"https://api.github.com/users/KixPanganiban/orgs","repos_url":"https://api.github.com/users/KixPanganiban/repos","events_url":"https://api.github.com/users/KixPanganiban/events{/privacy}","received_events_url":"https://api.github.com/users/KixPanganiban/received_events","type":"User","site_admin":false},"repo":{"id":73247953,"name":"ansible-role-nodejs","full_name":"KixPanganiban/ansible-role-nodejs","owner":{"login":"KixPanganiban","id":2585982,"avatar_url":"https://avatars.githubusercontent.com/u/2585982?v=3","gravatar_id":"","url":"https://api.github.com/users/KixPanganiban","html_url":"https://github.com/KixPanganiban","followers_url":"https://api.github.com/users/KixPanganiban/followers","following_url":"https://api.github.com/users/KixPanganiban/following{/other_user}","gists_url":"https://api.github.com/users/KixPanganiban/gists{/gist_id}","starred_url":"https://api.github.com/users/KixPanganiban/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KixPanganiban/subscriptions","organizations_url":"https://api.github.com/users/KixPanganiban/orgs","repos_url":"https://api.github.com/users/KixPanganiban/repos","events_url":"https://api.github.com/users/KixPanganiban/events{/privacy}","received_events_url":"https://api.github.com/users/KixPanganiban/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/KixPanganiban/ansible-role-nodejs","description":"Ansible Role - Node.js","fork":true,"url":"https://api.github.com/repos/KixPanganiban/ansible-role-nodejs","forks_url":"https://api.github.com/repos/KixPanganiban/ansible-role-nodejs/forks","keys_url":"https://api.github.com/repos/KixPanganiban/ansible-role-nodejs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KixPanganiban/ansible-role-nodejs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KixPanganiban/ansible-role-nodejs/teams","hooks_url":"https://api.github.com/repos/KixPanganiban/ansible-role-nodejs/hooks","issue_events_url":"https://api.github.com/repos/KixPanganiban/ansible-role-nodejs/issues/events{/number}","events_url":"https://api.github.com/repos/KixPanganiban/ansible-role-nodejs/events","assignees_url":"https://api.github.com/repos/KixPanganiban/ansible-role-nodejs/assignees{/user}","branches_url":"https://api.github.com/repos/KixPanganiban/ansible-role-nodejs/branches{/branch}","tags_url":"https://api.github.com/repos/KixPanganiban/ansible-role-nodejs/tags","blobs_url":"https://api.github.com/repos/KixPanganiban/ansible-role-nodejs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KixPanganiban/ansible-role-nodejs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KixPanganiban/ansible-role-nodejs/git/refs{/sha}","trees_url":"https://api.github.com/repos/KixPanganiban/ansible-role-nodejs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KixPanganiban/ansible-role-nodejs/statuses/{sha}","languages_url":"https://api.github.com/repos/KixPanganiban/ansible-role-nodejs/languages","stargazers_url":"https://api.github.com/repos/KixPanganiban/ansible-role-nodejs/stargazers","contributors_url":"https://api.github.com/repos/KixPanganiban/ansible-role-nodejs/contributors","subscribers_url":"https://api.github.com/repos/KixPanganiban/ansible-role-nodejs/subscribers","subscription_url":"https://api.github.com/repos/KixPanganiban/ansible-role-nodejs/subscription","commits_url":"https://api.github.com/repos/KixPanganiban/ansible-role-nodejs/commits{/sha}","git_commits_url":"https://api.github.com/repos/KixPanganiban/ansible-role-nodejs/git/commits{/sha}","comments_url":"https://api.github.com/repos/KixPanganiban/ansible-role-nodejs/comments{/number}","issue_comment_url":"https://api.github.com/repos/KixPanganiban/ansible-role-nodejs/issues/comments{/number}","contents_url":"https://api.github.com/repos/KixPanganiban/ansible-role-nodejs/contents/{+path}","compare_url":"https://api.github.com/repos/KixPanganiban/ansible-role-nodejs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KixPanganiban/ansible-role-nodejs/merges","archive_url":"https://api.github.com/repos/KixPanganiban/ansible-role-nodejs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KixPanganiban/ansible-role-nodejs/downloads","issues_url":"https://api.github.com/repos/KixPanganiban/ansible-role-nodejs/issues{/number}","pulls_url":"https://api.github.com/repos/KixPanganiban/ansible-role-nodejs/pulls{/number}","milestones_url":"https://api.github.com/repos/KixPanganiban/ansible-role-nodejs/milestones{/number}","notifications_url":"https://api.github.com/repos/KixPanganiban/ansible-role-nodejs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KixPanganiban/ansible-role-nodejs/labels{/name}","releases_url":"https://api.github.com/repos/KixPanganiban/ansible-role-nodejs/releases{/id}","deployments_url":"https://api.github.com/repos/KixPanganiban/ansible-role-nodejs/deployments","created_at":"2016-11-09T03:01:17Z","updated_at":"2016-11-03T23:48:28Z","pushed_at":"2016-11-09T03:28:10Z","git_url":"git://github.com/KixPanganiban/ansible-role-nodejs.git","ssh_url":"git@github.com:KixPanganiban/ansible-role-nodejs.git","clone_url":"https://github.com/KixPanganiban/ansible-role-nodejs.git","svn_url":"https://github.com/KixPanganiban/ansible-role-nodejs","homepage":"https://galaxy.ansible.com/geerlingguy/nodejs/","size":45,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"juwai:master","ref":"master","sha":"64eaeceed713a34e902c77e51451b0525f998217","user":{"login":"juwai","id":5142091,"avatar_url":"https://avatars.githubusercontent.com/u/5142091?v=3","gravatar_id":"","url":"https://api.github.com/users/juwai","html_url":"https://github.com/juwai","followers_url":"https://api.github.com/users/juwai/followers","following_url":"https://api.github.com/users/juwai/following{/other_user}","gists_url":"https://api.github.com/users/juwai/gists{/gist_id}","starred_url":"https://api.github.com/users/juwai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juwai/subscriptions","organizations_url":"https://api.github.com/users/juwai/orgs","repos_url":"https://api.github.com/users/juwai/repos","events_url":"https://api.github.com/users/juwai/events{/privacy}","received_events_url":"https://api.github.com/users/juwai/received_events","type":"Organization","site_admin":false},"repo":{"id":73246330,"name":"ansible-role-nodejs","full_name":"juwai/ansible-role-nodejs","owner":{"login":"juwai","id":5142091,"avatar_url":"https://avatars.githubusercontent.com/u/5142091?v=3","gravatar_id":"","url":"https://api.github.com/users/juwai","html_url":"https://github.com/juwai","followers_url":"https://api.github.com/users/juwai/followers","following_url":"https://api.github.com/users/juwai/following{/other_user}","gists_url":"https://api.github.com/users/juwai/gists{/gist_id}","starred_url":"https://api.github.com/users/juwai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juwai/subscriptions","organizations_url":"https://api.github.com/users/juwai/orgs","repos_url":"https://api.github.com/users/juwai/repos","events_url":"https://api.github.com/users/juwai/events{/privacy}","received_events_url":"https://api.github.com/users/juwai/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/juwai/ansible-role-nodejs","description":"Ansible Role - Node.js","fork":true,"url":"https://api.github.com/repos/juwai/ansible-role-nodejs","forks_url":"https://api.github.com/repos/juwai/ansible-role-nodejs/forks","keys_url":"https://api.github.com/repos/juwai/ansible-role-nodejs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juwai/ansible-role-nodejs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juwai/ansible-role-nodejs/teams","hooks_url":"https://api.github.com/repos/juwai/ansible-role-nodejs/hooks","issue_events_url":"https://api.github.com/repos/juwai/ansible-role-nodejs/issues/events{/number}","events_url":"https://api.github.com/repos/juwai/ansible-role-nodejs/events","assignees_url":"https://api.github.com/repos/juwai/ansible-role-nodejs/assignees{/user}","branches_url":"https://api.github.com/repos/juwai/ansible-role-nodejs/branches{/branch}","tags_url":"https://api.github.com/repos/juwai/ansible-role-nodejs/tags","blobs_url":"https://api.github.com/repos/juwai/ansible-role-nodejs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juwai/ansible-role-nodejs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juwai/ansible-role-nodejs/git/refs{/sha}","trees_url":"https://api.github.com/repos/juwai/ansible-role-nodejs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juwai/ansible-role-nodejs/statuses/{sha}","languages_url":"https://api.github.com/repos/juwai/ansible-role-nodejs/languages","stargazers_url":"https://api.github.com/repos/juwai/ansible-role-nodejs/stargazers","contributors_url":"https://api.github.com/repos/juwai/ansible-role-nodejs/contributors","subscribers_url":"https://api.github.com/repos/juwai/ansible-role-nodejs/subscribers","subscription_url":"https://api.github.com/repos/juwai/ansible-role-nodejs/subscription","commits_url":"https://api.github.com/repos/juwai/ansible-role-nodejs/commits{/sha}","git_commits_url":"https://api.github.com/repos/juwai/ansible-role-nodejs/git/commits{/sha}","comments_url":"https://api.github.com/repos/juwai/ansible-role-nodejs/comments{/number}","issue_comment_url":"https://api.github.com/repos/juwai/ansible-role-nodejs/issues/comments{/number}","contents_url":"https://api.github.com/repos/juwai/ansible-role-nodejs/contents/{+path}","compare_url":"https://api.github.com/repos/juwai/ansible-role-nodejs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juwai/ansible-role-nodejs/merges","archive_url":"https://api.github.com/repos/juwai/ansible-role-nodejs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juwai/ansible-role-nodejs/downloads","issues_url":"https://api.github.com/repos/juwai/ansible-role-nodejs/issues{/number}","pulls_url":"https://api.github.com/repos/juwai/ansible-role-nodejs/pulls{/number}","milestones_url":"https://api.github.com/repos/juwai/ansible-role-nodejs/milestones{/number}","notifications_url":"https://api.github.com/repos/juwai/ansible-role-nodejs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juwai/ansible-role-nodejs/labels{/name}","releases_url":"https://api.github.com/repos/juwai/ansible-role-nodejs/releases{/id}","deployments_url":"https://api.github.com/repos/juwai/ansible-role-nodejs/deployments","created_at":"2016-11-09T02:34:11Z","updated_at":"2016-11-03T23:48:28Z","pushed_at":"2016-11-09T03:44:27Z","git_url":"git://github.com/juwai/ansible-role-nodejs.git","ssh_url":"git@github.com:juwai/ansible-role-nodejs.git","clone_url":"https://github.com/juwai/ansible-role-nodejs.git","svn_url":"https://github.com/juwai/ansible-role-nodejs","homepage":"https://galaxy.ansible.com/geerlingguy/nodejs/","size":45,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/juwai/ansible-role-nodejs/pulls/1"},"html":{"href":"https://github.com/juwai/ansible-role-nodejs/pull/1"},"issue":{"href":"https://api.github.com/repos/juwai/ansible-role-nodejs/issues/1"},"comments":{"href":"https://api.github.com/repos/juwai/ansible-role-nodejs/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/juwai/ansible-role-nodejs/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/juwai/ansible-role-nodejs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/juwai/ansible-role-nodejs/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/juwai/ansible-role-nodejs/statuses/68a4f4351ee9b59dd5c7ef156a5d6fb7d26e665c"}}}}
{"actor":{"display_login":"tjoelsson"}}