{"action":"created","issue":{"url":"https://api.github.com/repos/madebymany/sir-trevor-js/issues/370","repository_url":"https://api.github.com/repos/madebymany/sir-trevor-js","labels_url":"https://api.github.com/repos/madebymany/sir-trevor-js/issues/370/labels{/name}","comments_url":"https://api.github.com/repos/madebymany/sir-trevor-js/issues/370/comments","events_url":"https://api.github.com/repos/madebymany/sir-trevor-js/issues/370/events","html_url":"https://github.com/madebymany/sir-trevor-js/issues/370","id":96767878,"number":370,"title":"Handle failed image upload in image block","user":{"login":"ilyaporopudas","id":574198,"avatar_url":"https://avatars.githubusercontent.com/u/574198?v=3","gravatar_id":"","url":"https://api.github.com/users/ilyaporopudas","html_url":"https://github.com/ilyaporopudas","followers_url":"https://api.github.com/users/ilyaporopudas/followers","following_url":"https://api.github.com/users/ilyaporopudas/following{/other_user}","gists_url":"https://api.github.com/users/ilyaporopudas/gists{/gist_id}","starred_url":"https://api.github.com/users/ilyaporopudas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilyaporopudas/subscriptions","organizations_url":"https://api.github.com/users/ilyaporopudas/orgs","repos_url":"https://api.github.com/users/ilyaporopudas/repos","events_url":"https://api.github.com/users/ilyaporopudas/events{/privacy}","received_events_url":"https://api.github.com/users/ilyaporopudas/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/madebymany/sir-trevor-js/labels/Feature%20Enhancement","name":"Feature Enhancement","color":"207de5"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/madebymany/sir-trevor-js/milestones/9","html_url":"https://github.com/madebymany/sir-trevor-js/milestones/v0.9.0","labels_url":"https://api.github.com/repos/madebymany/sir-trevor-js/milestones/9/labels","id":1859613,"number":9,"title":"v0.9.0","description":"Better data api reliance on form elements","creator":{"login":"raffij","id":28570,"avatar_url":"https://avatars.githubusercontent.com/u/28570?v=3","gravatar_id":"","url":"https://api.github.com/users/raffij","html_url":"https://github.com/raffij","followers_url":"https://api.github.com/users/raffij/followers","following_url":"https://api.github.com/users/raffij/following{/other_user}","gists_url":"https://api.github.com/users/raffij/gists{/gist_id}","starred_url":"https://api.github.com/users/raffij/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raffij/subscriptions","organizations_url":"https://api.github.com/users/raffij/orgs","repos_url":"https://api.github.com/users/raffij/repos","events_url":"https://api.github.com/users/raffij/events{/privacy}","received_events_url":"https://api.github.com/users/raffij/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":0,"state":"open","created_at":"2016-07-01T11:18:19Z","updated_at":"2016-07-12T11:02:54Z","due_on":null,"closed_at":null},"comments":10,"created_at":"2015-07-23T09:11:41Z","updated_at":"2016-09-05T14:31:51Z","closed_at":null,"body":"If a the image upload fails, Sir Trevor will still create an empty image block, which can cause rendering problems."},"comment":{"url":"https://api.github.com/repos/madebymany/sir-trevor-js/issues/comments/244760240","html_url":"https://github.com/madebymany/sir-trevor-js/issues/370#issuecomment-244760240","issue_url":"https://api.github.com/repos/madebymany/sir-trevor-js/issues/370","id":244760240,"user":{"login":"ToBe998","id":12497310,"avatar_url":"https://avatars.githubusercontent.com/u/12497310?v=3","gravatar_id":"","url":"https://api.github.com/users/ToBe998","html_url":"https://github.com/ToBe998","followers_url":"https://api.github.com/users/ToBe998/followers","following_url":"https://api.github.com/users/ToBe998/following{/other_user}","gists_url":"https://api.github.com/users/ToBe998/gists{/gist_id}","starred_url":"https://api.github.com/users/ToBe998/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ToBe998/subscriptions","organizations_url":"https://api.github.com/users/ToBe998/orgs","repos_url":"https://api.github.com/users/ToBe998/repos","events_url":"https://api.github.com/users/ToBe998/events{/privacy}","received_events_url":"https://api.github.com/users/ToBe998/received_events","type":"User","site_admin":false},"created_at":"2016-09-05T14:31:51Z","updated_at":"2016-09-05T14:31:51Z","body":"Just stumbled into this too. It seems that the current image block can no longer detect if an image upload failed in any way. The Promise will always trigger the success method, no matter what the server responded.\r\n\r\nSo, it is completely possible that i read the code wrong, but the image block (and maybe other blocks using the uploader and/or cancellable-promise) is no longer able to react to any problems during upload."}}
{"actor":{"display_login":"ToBe998"}}