{"action":"created","comment":{"url":"https://api.github.com/repos/sandstorm-io/capnproto/pulls/comments/59099265","id":59099265,"diff_hunk":"@@ -169,6 +169,36 @@ struct Node {\n       targetsAnnotation @30 :Bool;\n     }\n   }\n+\n+  struct SourceInfo {\n+    # Information gathered about the original source code from which this node was compiled.\n+    #\n+    # SourceInfo is delivered separately from the nodes themselves in order to make sure it is not\n+    # accidentally included in cases where it is not needed. SourceInfo can be very big and is not\n+    # generally used at runtime. Instead of educating everyone on how to remove it when not needed,\n+    # we choose to deliver it out-of-band such that use cases that *do* need SourceInfo can request\n+    # it explicitly. For example, `CodeGeneratorRequest` delivers a list of `SourceInfo`s in\n+    # parallel with the list of `Node`s.\n+\n+    id @0 :UInt64;\n+    # ID of the node we're describing.\n+\n+    docComment @1 :UInt64;","path":"c++/src/capnp/schema.capnp","position":null,"original_position":18,"commit_id":"dfae9e8b1e4e30379b3af42318ae173cfa0d544b","original_commit_id":"bfb10adcc2888617a850741577fdc6b904b8c1a0","user":{"login":"kentonv","id":4001805,"avatar_url":"https://avatars.githubusercontent.com/u/4001805?v=3","gravatar_id":"","url":"https://api.github.com/users/kentonv","html_url":"https://github.com/kentonv","followers_url":"https://api.github.com/users/kentonv/followers","following_url":"https://api.github.com/users/kentonv/following{/other_user}","gists_url":"https://api.github.com/users/kentonv/gists{/gist_id}","starred_url":"https://api.github.com/users/kentonv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kentonv/subscriptions","organizations_url":"https://api.github.com/users/kentonv/orgs","repos_url":"https://api.github.com/users/kentonv/repos","events_url":"https://api.github.com/users/kentonv/events{/privacy}","received_events_url":"https://api.github.com/users/kentonv/received_events","type":"User","site_admin":false},"body":"fixed","created_at":"2016-04-08T22:45:20Z","updated_at":"2016-04-08T22:45:20Z","html_url":"https://github.com/sandstorm-io/capnproto/pull/311#discussion_r59099265","pull_request_url":"https://api.github.com/repos/sandstorm-io/capnproto/pulls/311","_links":{"self":{"href":"https://api.github.com/repos/sandstorm-io/capnproto/pulls/comments/59099265"},"html":{"href":"https://github.com/sandstorm-io/capnproto/pull/311#discussion_r59099265"},"pull_request":{"href":"https://api.github.com/repos/sandstorm-io/capnproto/pulls/311"}}},"pull_request":{"url":"https://api.github.com/repos/sandstorm-io/capnproto/pulls/311","id":65852072,"html_url":"https://github.com/sandstorm-io/capnproto/pull/311","diff_url":"https://github.com/sandstorm-io/capnproto/pull/311.diff","patch_url":"https://github.com/sandstorm-io/capnproto/pull/311.patch","issue_url":"https://api.github.com/repos/sandstorm-io/capnproto/issues/311","number":311,"state":"open","locked":false,"title":"Declare SourceInfo in schema.capnp as a proposal.","user":{"login":"kentonv","id":4001805,"avatar_url":"https://avatars.githubusercontent.com/u/4001805?v=3","gravatar_id":"","url":"https://api.github.com/users/kentonv","html_url":"https://github.com/kentonv","followers_url":"https://api.github.com/users/kentonv/followers","following_url":"https://api.github.com/users/kentonv/following{/other_user}","gists_url":"https://api.github.com/users/kentonv/gists{/gist_id}","starred_url":"https://api.github.com/users/kentonv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kentonv/subscriptions","organizations_url":"https://api.github.com/users/kentonv/orgs","repos_url":"https://api.github.com/users/kentonv/repos","events_url":"https://api.github.com/users/kentonv/events{/privacy}","received_events_url":"https://api.github.com/users/kentonv/received_events","type":"User","site_admin":false},"body":"@eqvinox This is how I propose we represent doc comments (alternative to #302). We can also use this for things like source code locations (line/column numbers) of declarations.\r\n\r\nThe `SchemaLoader` and `SchemaParser` classes will probably need to be updated to support loading `SourceInfo`s separately and then looking up `SourceInfo` for a particular node.\r\n\r\nUnfortunately I don't have time to work on it right this moment... :/","created_at":"2016-04-08T21:47:46Z","updated_at":"2016-04-08T22:45:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1beda651663952689708a264ac6b75f320711da1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sandstorm-io/capnproto/pulls/311/commits","review_comments_url":"https://api.github.com/repos/sandstorm-io/capnproto/pulls/311/comments","review_comment_url":"https://api.github.com/repos/sandstorm-io/capnproto/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sandstorm-io/capnproto/issues/311/comments","statuses_url":"https://api.github.com/repos/sandstorm-io/capnproto/statuses/dfae9e8b1e4e30379b3af42318ae173cfa0d544b","head":{"label":"sandstorm-io:source-info","ref":"source-info","sha":"dfae9e8b1e4e30379b3af42318ae173cfa0d544b","user":{"login":"sandstorm-io","id":7479094,"avatar_url":"https://avatars.githubusercontent.com/u/7479094?v=3","gravatar_id":"","url":"https://api.github.com/users/sandstorm-io","html_url":"https://github.com/sandstorm-io","followers_url":"https://api.github.com/users/sandstorm-io/followers","following_url":"https://api.github.com/users/sandstorm-io/following{/other_user}","gists_url":"https://api.github.com/users/sandstorm-io/gists{/gist_id}","starred_url":"https://api.github.com/users/sandstorm-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sandstorm-io/subscriptions","organizations_url":"https://api.github.com/users/sandstorm-io/orgs","repos_url":"https://api.github.com/users/sandstorm-io/repos","events_url":"https://api.github.com/users/sandstorm-io/events{/privacy}","received_events_url":"https://api.github.com/users/sandstorm-io/received_events","type":"Organization","site_admin":false},"repo":{"id":9090933,"name":"capnproto","full_name":"sandstorm-io/capnproto","owner":{"login":"sandstorm-io","id":7479094,"avatar_url":"https://avatars.githubusercontent.com/u/7479094?v=3","gravatar_id":"","url":"https://api.github.com/users/sandstorm-io","html_url":"https://github.com/sandstorm-io","followers_url":"https://api.github.com/users/sandstorm-io/followers","following_url":"https://api.github.com/users/sandstorm-io/following{/other_user}","gists_url":"https://api.github.com/users/sandstorm-io/gists{/gist_id}","starred_url":"https://api.github.com/users/sandstorm-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sandstorm-io/subscriptions","organizations_url":"https://api.github.com/users/sandstorm-io/orgs","repos_url":"https://api.github.com/users/sandstorm-io/repos","events_url":"https://api.github.com/users/sandstorm-io/events{/privacy}","received_events_url":"https://api.github.com/users/sandstorm-io/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sandstorm-io/capnproto","description":"Cap'n Proto serialization/RPC system","fork":false,"url":"https://api.github.com/repos/sandstorm-io/capnproto","forks_url":"https://api.github.com/repos/sandstorm-io/capnproto/forks","keys_url":"https://api.github.com/repos/sandstorm-io/capnproto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sandstorm-io/capnproto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sandstorm-io/capnproto/teams","hooks_url":"https://api.github.com/repos/sandstorm-io/capnproto/hooks","issue_events_url":"https://api.github.com/repos/sandstorm-io/capnproto/issues/events{/number}","events_url":"https://api.github.com/repos/sandstorm-io/capnproto/events","assignees_url":"https://api.github.com/repos/sandstorm-io/capnproto/assignees{/user}","branches_url":"https://api.github.com/repos/sandstorm-io/capnproto/branches{/branch}","tags_url":"https://api.github.com/repos/sandstorm-io/capnproto/tags","blobs_url":"https://api.github.com/repos/sandstorm-io/capnproto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sandstorm-io/capnproto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sandstorm-io/capnproto/git/refs{/sha}","trees_url":"https://api.github.com/repos/sandstorm-io/capnproto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sandstorm-io/capnproto/statuses/{sha}","languages_url":"https://api.github.com/repos/sandstorm-io/capnproto/languages","stargazers_url":"https://api.github.com/repos/sandstorm-io/capnproto/stargazers","contributors_url":"https://api.github.com/repos/sandstorm-io/capnproto/contributors","subscribers_url":"https://api.github.com/repos/sandstorm-io/capnproto/subscribers","subscription_url":"https://api.github.com/repos/sandstorm-io/capnproto/subscription","commits_url":"https://api.github.com/repos/sandstorm-io/capnproto/commits{/sha}","git_commits_url":"https://api.github.com/repos/sandstorm-io/capnproto/git/commits{/sha}","comments_url":"https://api.github.com/repos/sandstorm-io/capnproto/comments{/number}","issue_comment_url":"https://api.github.com/repos/sandstorm-io/capnproto/issues/comments{/number}","contents_url":"https://api.github.com/repos/sandstorm-io/capnproto/contents/{+path}","compare_url":"https://api.github.com/repos/sandstorm-io/capnproto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sandstorm-io/capnproto/merges","archive_url":"https://api.github.com/repos/sandstorm-io/capnproto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sandstorm-io/capnproto/downloads","issues_url":"https://api.github.com/repos/sandstorm-io/capnproto/issues{/number}","pulls_url":"https://api.github.com/repos/sandstorm-io/capnproto/pulls{/number}","milestones_url":"https://api.github.com/repos/sandstorm-io/capnproto/milestones{/number}","notifications_url":"https://api.github.com/repos/sandstorm-io/capnproto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sandstorm-io/capnproto/labels{/name}","releases_url":"https://api.github.com/repos/sandstorm-io/capnproto/releases{/id}","deployments_url":"https://api.github.com/repos/sandstorm-io/capnproto/deployments","created_at":"2013-03-29T02:38:48Z","updated_at":"2016-04-08T20:19:33Z","pushed_at":"2016-04-08T22:44:46Z","git_url":"git://github.com/sandstorm-io/capnproto.git","ssh_url":"git@github.com:sandstorm-io/capnproto.git","clone_url":"https://github.com/sandstorm-io/capnproto.git","svn_url":"https://github.com/sandstorm-io/capnproto","homepage":"https://capnproto.org","size":14265,"stargazers_count":3394,"watchers_count":3394,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":284,"mirror_url":null,"open_issues_count":51,"forks":284,"open_issues":51,"watchers":3394,"default_branch":"master"}},"base":{"label":"sandstorm-io:master","ref":"master","sha":"29b2e0c416f77b0d85a6d76eef678178e54e36b6","user":{"login":"sandstorm-io","id":7479094,"avatar_url":"https://avatars.githubusercontent.com/u/7479094?v=3","gravatar_id":"","url":"https://api.github.com/users/sandstorm-io","html_url":"https://github.com/sandstorm-io","followers_url":"https://api.github.com/users/sandstorm-io/followers","following_url":"https://api.github.com/users/sandstorm-io/following{/other_user}","gists_url":"https://api.github.com/users/sandstorm-io/gists{/gist_id}","starred_url":"https://api.github.com/users/sandstorm-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sandstorm-io/subscriptions","organizations_url":"https://api.github.com/users/sandstorm-io/orgs","repos_url":"https://api.github.com/users/sandstorm-io/repos","events_url":"https://api.github.com/users/sandstorm-io/events{/privacy}","received_events_url":"https://api.github.com/users/sandstorm-io/received_events","type":"Organization","site_admin":false},"repo":{"id":9090933,"name":"capnproto","full_name":"sandstorm-io/capnproto","owner":{"login":"sandstorm-io","id":7479094,"avatar_url":"https://avatars.githubusercontent.com/u/7479094?v=3","gravatar_id":"","url":"https://api.github.com/users/sandstorm-io","html_url":"https://github.com/sandstorm-io","followers_url":"https://api.github.com/users/sandstorm-io/followers","following_url":"https://api.github.com/users/sandstorm-io/following{/other_user}","gists_url":"https://api.github.com/users/sandstorm-io/gists{/gist_id}","starred_url":"https://api.github.com/users/sandstorm-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sandstorm-io/subscriptions","organizations_url":"https://api.github.com/users/sandstorm-io/orgs","repos_url":"https://api.github.com/users/sandstorm-io/repos","events_url":"https://api.github.com/users/sandstorm-io/events{/privacy}","received_events_url":"https://api.github.com/users/sandstorm-io/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sandstorm-io/capnproto","description":"Cap'n Proto serialization/RPC system","fork":false,"url":"https://api.github.com/repos/sandstorm-io/capnproto","forks_url":"https://api.github.com/repos/sandstorm-io/capnproto/forks","keys_url":"https://api.github.com/repos/sandstorm-io/capnproto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sandstorm-io/capnproto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sandstorm-io/capnproto/teams","hooks_url":"https://api.github.com/repos/sandstorm-io/capnproto/hooks","issue_events_url":"https://api.github.com/repos/sandstorm-io/capnproto/issues/events{/number}","events_url":"https://api.github.com/repos/sandstorm-io/capnproto/events","assignees_url":"https://api.github.com/repos/sandstorm-io/capnproto/assignees{/user}","branches_url":"https://api.github.com/repos/sandstorm-io/capnproto/branches{/branch}","tags_url":"https://api.github.com/repos/sandstorm-io/capnproto/tags","blobs_url":"https://api.github.com/repos/sandstorm-io/capnproto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sandstorm-io/capnproto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sandstorm-io/capnproto/git/refs{/sha}","trees_url":"https://api.github.com/repos/sandstorm-io/capnproto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sandstorm-io/capnproto/statuses/{sha}","languages_url":"https://api.github.com/repos/sandstorm-io/capnproto/languages","stargazers_url":"https://api.github.com/repos/sandstorm-io/capnproto/stargazers","contributors_url":"https://api.github.com/repos/sandstorm-io/capnproto/contributors","subscribers_url":"https://api.github.com/repos/sandstorm-io/capnproto/subscribers","subscription_url":"https://api.github.com/repos/sandstorm-io/capnproto/subscription","commits_url":"https://api.github.com/repos/sandstorm-io/capnproto/commits{/sha}","git_commits_url":"https://api.github.com/repos/sandstorm-io/capnproto/git/commits{/sha}","comments_url":"https://api.github.com/repos/sandstorm-io/capnproto/comments{/number}","issue_comment_url":"https://api.github.com/repos/sandstorm-io/capnproto/issues/comments{/number}","contents_url":"https://api.github.com/repos/sandstorm-io/capnproto/contents/{+path}","compare_url":"https://api.github.com/repos/sandstorm-io/capnproto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sandstorm-io/capnproto/merges","archive_url":"https://api.github.com/repos/sandstorm-io/capnproto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sandstorm-io/capnproto/downloads","issues_url":"https://api.github.com/repos/sandstorm-io/capnproto/issues{/number}","pulls_url":"https://api.github.com/repos/sandstorm-io/capnproto/pulls{/number}","milestones_url":"https://api.github.com/repos/sandstorm-io/capnproto/milestones{/number}","notifications_url":"https://api.github.com/repos/sandstorm-io/capnproto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sandstorm-io/capnproto/labels{/name}","releases_url":"https://api.github.com/repos/sandstorm-io/capnproto/releases{/id}","deployments_url":"https://api.github.com/repos/sandstorm-io/capnproto/deployments","created_at":"2013-03-29T02:38:48Z","updated_at":"2016-04-08T20:19:33Z","pushed_at":"2016-04-08T22:44:46Z","git_url":"git://github.com/sandstorm-io/capnproto.git","ssh_url":"git@github.com:sandstorm-io/capnproto.git","clone_url":"https://github.com/sandstorm-io/capnproto.git","svn_url":"https://github.com/sandstorm-io/capnproto","homepage":"https://capnproto.org","size":14265,"stargazers_count":3394,"watchers_count":3394,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":284,"mirror_url":null,"open_issues_count":51,"forks":284,"open_issues":51,"watchers":3394,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sandstorm-io/capnproto/pulls/311"},"html":{"href":"https://github.com/sandstorm-io/capnproto/pull/311"},"issue":{"href":"https://api.github.com/repos/sandstorm-io/capnproto/issues/311"},"comments":{"href":"https://api.github.com/repos/sandstorm-io/capnproto/issues/311/comments"},"review_comments":{"href":"https://api.github.com/repos/sandstorm-io/capnproto/pulls/311/comments"},"review_comment":{"href":"https://api.github.com/repos/sandstorm-io/capnproto/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sandstorm-io/capnproto/pulls/311/commits"},"statuses":{"href":"https://api.github.com/repos/sandstorm-io/capnproto/statuses/dfae9e8b1e4e30379b3af42318ae173cfa0d544b"}}}}