{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla-services/autopush/pulls/comments/76846106","id":76846106,"diff_hunk":"@@ -473,7 +476,9 @@ def put(self, api_ver=\"v0\", token=None):\n                           api_ver,\n                           crypto_key_header)\n         d.addCallback(self._process_auth)\n-        d.addCallback(self._token_valid)\n+        d.addCallback(self._token_valid,\n+                      caller=\"%s.%s\" % (self.__module__,\n+                                        self.request.method.lower()))","path":"autopush/endpoint.py","position":49,"original_position":49,"commit_id":"fda50745ea6be322c4286f4ae4fcaaf2d6b8e03d","original_commit_id":"fda50745ea6be322c4286f4ae4fcaaf2d6b8e03d","user":{"login":"bbangert","id":100193,"avatar_url":"https://avatars.githubusercontent.com/u/100193?v=3","gravatar_id":"","url":"https://api.github.com/users/bbangert","html_url":"https://github.com/bbangert","followers_url":"https://api.github.com/users/bbangert/followers","following_url":"https://api.github.com/users/bbangert/following{/other_user}","gists_url":"https://api.github.com/users/bbangert/gists{/gist_id}","starred_url":"https://api.github.com/users/bbangert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbangert/subscriptions","organizations_url":"https://api.github.com/users/bbangert/orgs","repos_url":"https://api.github.com/users/bbangert/repos","events_url":"https://api.github.com/users/bbangert/events{/privacy}","received_events_url":"https://api.github.com/users/bbangert/received_events","type":"User","site_admin":false},"body":"Why the function calls and format subs when we already know exactly where we are and the method?","created_at":"2016-08-30T17:56:13Z","updated_at":"2016-08-30T17:56:13Z","html_url":"https://github.com/mozilla-services/autopush/pull/637#discussion_r76846106","pull_request_url":"https://api.github.com/repos/mozilla-services/autopush/pulls/637","_links":{"self":{"href":"https://api.github.com/repos/mozilla-services/autopush/pulls/comments/76846106"},"html":{"href":"https://github.com/mozilla-services/autopush/pull/637#discussion_r76846106"},"pull_request":{"href":"https://api.github.com/repos/mozilla-services/autopush/pulls/637"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla-services/autopush/pulls/637","id":82955042,"html_url":"https://github.com/mozilla-services/autopush/pull/637","diff_url":"https://github.com/mozilla-services/autopush/pull/637.diff","patch_url":"https://github.com/mozilla-services/autopush/pull/637.patch","issue_url":"https://api.github.com/repos/mozilla-services/autopush/issues/637","number":637,"state":"open","locked":false,"title":"bug: ensure we only use valid data as indexes for dynamodb","user":{"login":"jrconlin","id":35755,"avatar_url":"https://avatars.githubusercontent.com/u/35755?v=3","gravatar_id":"","url":"https://api.github.com/users/jrconlin","html_url":"https://github.com/jrconlin","followers_url":"https://api.github.com/users/jrconlin/followers","following_url":"https://api.github.com/users/jrconlin/following{/other_user}","gists_url":"https://api.github.com/users/jrconlin/gists{/gist_id}","starred_url":"https://api.github.com/users/jrconlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrconlin/subscriptions","organizations_url":"https://api.github.com/users/jrconlin/orgs","repos_url":"https://api.github.com/users/jrconlin/repos","events_url":"https://api.github.com/users/jrconlin/events{/privacy}","received_events_url":"https://api.github.com/users/jrconlin/received_events","type":"User","site_admin":false},"body":"closes #629 \r\n@bbangert @pjenvey r?","created_at":"2016-08-26T21:13:05Z","updated_at":"2016-08-30T17:56:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d57af7c4a7d0b813ee1a4f6fb993f0a6aa9e89e1","assignee":{"login":"pjenvey","id":14639,"avatar_url":"https://avatars.githubusercontent.com/u/14639?v=3","gravatar_id":"","url":"https://api.github.com/users/pjenvey","html_url":"https://github.com/pjenvey","followers_url":"https://api.github.com/users/pjenvey/followers","following_url":"https://api.github.com/users/pjenvey/following{/other_user}","gists_url":"https://api.github.com/users/pjenvey/gists{/gist_id}","starred_url":"https://api.github.com/users/pjenvey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pjenvey/subscriptions","organizations_url":"https://api.github.com/users/pjenvey/orgs","repos_url":"https://api.github.com/users/pjenvey/repos","events_url":"https://api.github.com/users/pjenvey/events{/privacy}","received_events_url":"https://api.github.com/users/pjenvey/received_events","type":"User","site_admin":false},"assignees":[{"login":"pjenvey","id":14639,"avatar_url":"https://avatars.githubusercontent.com/u/14639?v=3","gravatar_id":"","url":"https://api.github.com/users/pjenvey","html_url":"https://github.com/pjenvey","followers_url":"https://api.github.com/users/pjenvey/followers","following_url":"https://api.github.com/users/pjenvey/following{/other_user}","gists_url":"https://api.github.com/users/pjenvey/gists{/gist_id}","starred_url":"https://api.github.com/users/pjenvey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pjenvey/subscriptions","organizations_url":"https://api.github.com/users/pjenvey/orgs","repos_url":"https://api.github.com/users/pjenvey/repos","events_url":"https://api.github.com/users/pjenvey/events{/privacy}","received_events_url":"https://api.github.com/users/pjenvey/received_events","type":"User","site_admin":false},{"login":"bbangert","id":100193,"avatar_url":"https://avatars.githubusercontent.com/u/100193?v=3","gravatar_id":"","url":"https://api.github.com/users/bbangert","html_url":"https://github.com/bbangert","followers_url":"https://api.github.com/users/bbangert/followers","following_url":"https://api.github.com/users/bbangert/following{/other_user}","gists_url":"https://api.github.com/users/bbangert/gists{/gist_id}","starred_url":"https://api.github.com/users/bbangert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbangert/subscriptions","organizations_url":"https://api.github.com/users/bbangert/orgs","repos_url":"https://api.github.com/users/bbangert/repos","events_url":"https://api.github.com/users/bbangert/events{/privacy}","received_events_url":"https://api.github.com/users/bbangert/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla-services/autopush/pulls/637/commits","review_comments_url":"https://api.github.com/repos/mozilla-services/autopush/pulls/637/comments","review_comment_url":"https://api.github.com/repos/mozilla-services/autopush/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla-services/autopush/issues/637/comments","statuses_url":"https://api.github.com/repos/mozilla-services/autopush/statuses/fda50745ea6be322c4286f4ae4fcaaf2d6b8e03d","head":{"label":"mozilla-services:bug/629","ref":"bug/629","sha":"fda50745ea6be322c4286f4ae4fcaaf2d6b8e03d","user":{"login":"mozilla-services","id":1066228,"avatar_url":"https://avatars.githubusercontent.com/u/1066228?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-services","html_url":"https://github.com/mozilla-services","followers_url":"https://api.github.com/users/mozilla-services/followers","following_url":"https://api.github.com/users/mozilla-services/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-services/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-services/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-services/subscriptions","organizations_url":"https://api.github.com/users/mozilla-services/orgs","repos_url":"https://api.github.com/users/mozilla-services/repos","events_url":"https://api.github.com/users/mozilla-services/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-services/received_events","type":"Organization","site_admin":false},"repo":{"id":31746003,"name":"autopush","full_name":"mozilla-services/autopush","owner":{"login":"mozilla-services","id":1066228,"avatar_url":"https://avatars.githubusercontent.com/u/1066228?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-services","html_url":"https://github.com/mozilla-services","followers_url":"https://api.github.com/users/mozilla-services/followers","following_url":"https://api.github.com/users/mozilla-services/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-services/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-services/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-services/subscriptions","organizations_url":"https://api.github.com/users/mozilla-services/orgs","repos_url":"https://api.github.com/users/mozilla-services/repos","events_url":"https://api.github.com/users/mozilla-services/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-services/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-services/autopush","description":"Python Web Push Server used by Mozilla","fork":false,"url":"https://api.github.com/repos/mozilla-services/autopush","forks_url":"https://api.github.com/repos/mozilla-services/autopush/forks","keys_url":"https://api.github.com/repos/mozilla-services/autopush/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-services/autopush/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-services/autopush/teams","hooks_url":"https://api.github.com/repos/mozilla-services/autopush/hooks","issue_events_url":"https://api.github.com/repos/mozilla-services/autopush/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-services/autopush/events","assignees_url":"https://api.github.com/repos/mozilla-services/autopush/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-services/autopush/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-services/autopush/tags","blobs_url":"https://api.github.com/repos/mozilla-services/autopush/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-services/autopush/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-services/autopush/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-services/autopush/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-services/autopush/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-services/autopush/languages","stargazers_url":"https://api.github.com/repos/mozilla-services/autopush/stargazers","contributors_url":"https://api.github.com/repos/mozilla-services/autopush/contributors","subscribers_url":"https://api.github.com/repos/mozilla-services/autopush/subscribers","subscription_url":"https://api.github.com/repos/mozilla-services/autopush/subscription","commits_url":"https://api.github.com/repos/mozilla-services/autopush/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-services/autopush/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-services/autopush/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-services/autopush/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla-services/autopush/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-services/autopush/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-services/autopush/merges","archive_url":"https://api.github.com/repos/mozilla-services/autopush/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-services/autopush/downloads","issues_url":"https://api.github.com/repos/mozilla-services/autopush/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-services/autopush/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-services/autopush/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-services/autopush/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-services/autopush/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-services/autopush/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla-services/autopush/deployments","created_at":"2015-03-06T01:19:24Z","updated_at":"2016-08-15T08:39:18Z","pushed_at":"2016-08-30T17:49:13Z","git_url":"git://github.com/mozilla-services/autopush.git","ssh_url":"git@github.com:mozilla-services/autopush.git","clone_url":"https://github.com/mozilla-services/autopush.git","svn_url":"https://github.com/mozilla-services/autopush","homepage":"https://autopush.readthedocs.io/","size":2413,"stargazers_count":58,"watchers_count":58,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":31,"forks":14,"open_issues":31,"watchers":58,"default_branch":"master"}},"base":{"label":"mozilla-services:master","ref":"master","sha":"3d369bcfa3f57258e8358183099ef139a2ae594e","user":{"login":"mozilla-services","id":1066228,"avatar_url":"https://avatars.githubusercontent.com/u/1066228?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-services","html_url":"https://github.com/mozilla-services","followers_url":"https://api.github.com/users/mozilla-services/followers","following_url":"https://api.github.com/users/mozilla-services/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-services/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-services/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-services/subscriptions","organizations_url":"https://api.github.com/users/mozilla-services/orgs","repos_url":"https://api.github.com/users/mozilla-services/repos","events_url":"https://api.github.com/users/mozilla-services/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-services/received_events","type":"Organization","site_admin":false},"repo":{"id":31746003,"name":"autopush","full_name":"mozilla-services/autopush","owner":{"login":"mozilla-services","id":1066228,"avatar_url":"https://avatars.githubusercontent.com/u/1066228?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-services","html_url":"https://github.com/mozilla-services","followers_url":"https://api.github.com/users/mozilla-services/followers","following_url":"https://api.github.com/users/mozilla-services/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-services/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-services/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-services/subscriptions","organizations_url":"https://api.github.com/users/mozilla-services/orgs","repos_url":"https://api.github.com/users/mozilla-services/repos","events_url":"https://api.github.com/users/mozilla-services/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-services/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-services/autopush","description":"Python Web Push Server used by Mozilla","fork":false,"url":"https://api.github.com/repos/mozilla-services/autopush","forks_url":"https://api.github.com/repos/mozilla-services/autopush/forks","keys_url":"https://api.github.com/repos/mozilla-services/autopush/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-services/autopush/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-services/autopush/teams","hooks_url":"https://api.github.com/repos/mozilla-services/autopush/hooks","issue_events_url":"https://api.github.com/repos/mozilla-services/autopush/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-services/autopush/events","assignees_url":"https://api.github.com/repos/mozilla-services/autopush/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-services/autopush/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-services/autopush/tags","blobs_url":"https://api.github.com/repos/mozilla-services/autopush/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-services/autopush/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-services/autopush/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-services/autopush/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-services/autopush/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-services/autopush/languages","stargazers_url":"https://api.github.com/repos/mozilla-services/autopush/stargazers","contributors_url":"https://api.github.com/repos/mozilla-services/autopush/contributors","subscribers_url":"https://api.github.com/repos/mozilla-services/autopush/subscribers","subscription_url":"https://api.github.com/repos/mozilla-services/autopush/subscription","commits_url":"https://api.github.com/repos/mozilla-services/autopush/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-services/autopush/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-services/autopush/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-services/autopush/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla-services/autopush/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-services/autopush/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-services/autopush/merges","archive_url":"https://api.github.com/repos/mozilla-services/autopush/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-services/autopush/downloads","issues_url":"https://api.github.com/repos/mozilla-services/autopush/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-services/autopush/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-services/autopush/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-services/autopush/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-services/autopush/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-services/autopush/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla-services/autopush/deployments","created_at":"2015-03-06T01:19:24Z","updated_at":"2016-08-15T08:39:18Z","pushed_at":"2016-08-30T17:49:13Z","git_url":"git://github.com/mozilla-services/autopush.git","ssh_url":"git@github.com:mozilla-services/autopush.git","clone_url":"https://github.com/mozilla-services/autopush.git","svn_url":"https://github.com/mozilla-services/autopush","homepage":"https://autopush.readthedocs.io/","size":2413,"stargazers_count":58,"watchers_count":58,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":31,"forks":14,"open_issues":31,"watchers":58,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla-services/autopush/pulls/637"},"html":{"href":"https://github.com/mozilla-services/autopush/pull/637"},"issue":{"href":"https://api.github.com/repos/mozilla-services/autopush/issues/637"},"comments":{"href":"https://api.github.com/repos/mozilla-services/autopush/issues/637/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla-services/autopush/pulls/637/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla-services/autopush/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla-services/autopush/pulls/637/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla-services/autopush/statuses/fda50745ea6be322c4286f4ae4fcaaf2d6b8e03d"}}}}
{"actor":{"display_login":"bbangert"}}