{"action":"created","comment":{"url":"https://api.github.com/repos/niosus/EasyClangComplete/pulls/comments/88777441","pull_request_review_id":9343579,"id":88777441,"diff_hunk":"@@ -0,0 +1,7 @@\n+[run]\n+omit =\n+    /*/tests/*\n+    /*/clang/*\n+\n+[report]\n+ignore_errors = True","path":".coveragerc","position":7,"original_position":7,"commit_id":"6dd4af1823f257d6a5583181ed23e49be1eb2489","original_commit_id":"6dd4af1823f257d6a5583181ed23e49be1eb2489","user":{"login":"niosus","id":1893598,"avatar_url":"https://avatars.githubusercontent.com/u/1893598?v=3","gravatar_id":"","url":"https://api.github.com/users/niosus","html_url":"https://github.com/niosus","followers_url":"https://api.github.com/users/niosus/followers","following_url":"https://api.github.com/users/niosus/following{/other_user}","gists_url":"https://api.github.com/users/niosus/gists{/gist_id}","starred_url":"https://api.github.com/users/niosus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/niosus/subscriptions","organizations_url":"https://api.github.com/users/niosus/orgs","repos_url":"https://api.github.com/users/niosus/repos","events_url":"https://api.github.com/users/niosus/events{/privacy}","received_events_url":"https://api.github.com/users/niosus/received_events","type":"User","site_admin":false},"body":"oh, cool, didn't know this setting was there :+1: ","created_at":"2016-11-19T10:55:18Z","updated_at":"2016-11-19T10:55:18Z","html_url":"https://github.com/niosus/EasyClangComplete/pull/144#discussion_r88777441","pull_request_url":"https://api.github.com/repos/niosus/EasyClangComplete/pulls/144","_links":{"self":{"href":"https://api.github.com/repos/niosus/EasyClangComplete/pulls/comments/88777441"},"html":{"href":"https://github.com/niosus/EasyClangComplete/pull/144#discussion_r88777441"},"pull_request":{"href":"https://api.github.com/repos/niosus/EasyClangComplete/pulls/144"}}},"pull_request":{"url":"https://api.github.com/repos/niosus/EasyClangComplete/pulls/144","id":94277019,"html_url":"https://github.com/niosus/EasyClangComplete/pull/144","diff_url":"https://github.com/niosus/EasyClangComplete/pull/144.diff","patch_url":"https://github.com/niosus/EasyClangComplete/pull/144.patch","issue_url":"https://api.github.com/repos/niosus/EasyClangComplete/issues/144","number":144,"state":"open","locked":false,"title":"[WIP] Storing and generating flags per view ","user":{"login":"niosus","id":1893598,"avatar_url":"https://avatars.githubusercontent.com/u/1893598?v=3","gravatar_id":"","url":"https://api.github.com/users/niosus","html_url":"https://github.com/niosus","followers_url":"https://api.github.com/users/niosus/followers","following_url":"https://api.github.com/users/niosus/following{/other_user}","gists_url":"https://api.github.com/users/niosus/gists{/gist_id}","starred_url":"https://api.github.com/users/niosus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/niosus/subscriptions","organizations_url":"https://api.github.com/users/niosus/orgs","repos_url":"https://api.github.com/users/niosus/repos","events_url":"https://api.github.com/users/niosus/events{/privacy}","received_events_url":"https://api.github.com/users/niosus/received_events","type":"User","site_admin":false},"body":"This is a work in progress pull request. This is by far not a finished work. So far I have done:\r\n\r\n- there is a new module `flags_sources` that will allow to address the flags generation in a polymorphic way\r\n- implemented `compilation_db` flag source that handles loading flags from a compilation database\r\n- implemented `cmake_file` flag source that generates compilation database and uses `compilation_db` to parse it\r\n\r\nThere is a lot of features still missing. The implemented things are NOT run as part of the plugin, just used in unit tests for now. Eventually this will completely replace the flag manager.\r\n\r\nAll flags are generated per view with `get_flags(view_path)` method. \r\n\r\nA general idea is that we store a persistent dictionary for each possible build system that allows us to fetch  already parsed flags when we can do this. Another persistent (static) dictionary stores a found flags source file for a view path. This way we can check if the flag source has changed for a view.\r\n\r\nI am still not sure this is the best idea, but I failed to come up with something more elegant and this seems to serve the purpose.\r\n\r\nI will keep adding more stuff to this pull request in the following weeks. Feel free to comment on the current progress. ","created_at":"2016-11-17T23:53:43Z","updated_at":"2016-11-19T10:55:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3730eebab8aa5d341be74e93662766a188a1236a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/niosus/EasyClangComplete/pulls/144/commits","review_comments_url":"https://api.github.com/repos/niosus/EasyClangComplete/pulls/144/comments","review_comment_url":"https://api.github.com/repos/niosus/EasyClangComplete/pulls/comments{/number}","comments_url":"https://api.github.com/repos/niosus/EasyClangComplete/issues/144/comments","statuses_url":"https://api.github.com/repos/niosus/EasyClangComplete/statuses/6dd4af1823f257d6a5583181ed23e49be1eb2489","head":{"label":"niosus:better_flags","ref":"better_flags","sha":"6dd4af1823f257d6a5583181ed23e49be1eb2489","user":{"login":"niosus","id":1893598,"avatar_url":"https://avatars.githubusercontent.com/u/1893598?v=3","gravatar_id":"","url":"https://api.github.com/users/niosus","html_url":"https://github.com/niosus","followers_url":"https://api.github.com/users/niosus/followers","following_url":"https://api.github.com/users/niosus/following{/other_user}","gists_url":"https://api.github.com/users/niosus/gists{/gist_id}","starred_url":"https://api.github.com/users/niosus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/niosus/subscriptions","organizations_url":"https://api.github.com/users/niosus/orgs","repos_url":"https://api.github.com/users/niosus/repos","events_url":"https://api.github.com/users/niosus/events{/privacy}","received_events_url":"https://api.github.com/users/niosus/received_events","type":"User","site_admin":false},"repo":{"id":53678733,"name":"EasyClangComplete","full_name":"niosus/EasyClangComplete","owner":{"login":"niosus","id":1893598,"avatar_url":"https://avatars.githubusercontent.com/u/1893598?v=3","gravatar_id":"","url":"https://api.github.com/users/niosus","html_url":"https://github.com/niosus","followers_url":"https://api.github.com/users/niosus/followers","following_url":"https://api.github.com/users/niosus/following{/other_user}","gists_url":"https://api.github.com/users/niosus/gists{/gist_id}","starred_url":"https://api.github.com/users/niosus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/niosus/subscriptions","organizations_url":"https://api.github.com/users/niosus/orgs","repos_url":"https://api.github.com/users/niosus/repos","events_url":"https://api.github.com/users/niosus/events{/privacy}","received_events_url":"https://api.github.com/users/niosus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/niosus/EasyClangComplete","description":"Sublime Text 3 plugin that offers auto-completion of C/C++ structure members or class attributes and methods.","fork":false,"url":"https://api.github.com/repos/niosus/EasyClangComplete","forks_url":"https://api.github.com/repos/niosus/EasyClangComplete/forks","keys_url":"https://api.github.com/repos/niosus/EasyClangComplete/keys{/key_id}","collaborators_url":"https://api.github.com/repos/niosus/EasyClangComplete/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/niosus/EasyClangComplete/teams","hooks_url":"https://api.github.com/repos/niosus/EasyClangComplete/hooks","issue_events_url":"https://api.github.com/repos/niosus/EasyClangComplete/issues/events{/number}","events_url":"https://api.github.com/repos/niosus/EasyClangComplete/events","assignees_url":"https://api.github.com/repos/niosus/EasyClangComplete/assignees{/user}","branches_url":"https://api.github.com/repos/niosus/EasyClangComplete/branches{/branch}","tags_url":"https://api.github.com/repos/niosus/EasyClangComplete/tags","blobs_url":"https://api.github.com/repos/niosus/EasyClangComplete/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/niosus/EasyClangComplete/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/niosus/EasyClangComplete/git/refs{/sha}","trees_url":"https://api.github.com/repos/niosus/EasyClangComplete/git/trees{/sha}","statuses_url":"https://api.github.com/repos/niosus/EasyClangComplete/statuses/{sha}","languages_url":"https://api.github.com/repos/niosus/EasyClangComplete/languages","stargazers_url":"https://api.github.com/repos/niosus/EasyClangComplete/stargazers","contributors_url":"https://api.github.com/repos/niosus/EasyClangComplete/contributors","subscribers_url":"https://api.github.com/repos/niosus/EasyClangComplete/subscribers","subscription_url":"https://api.github.com/repos/niosus/EasyClangComplete/subscription","commits_url":"https://api.github.com/repos/niosus/EasyClangComplete/commits{/sha}","git_commits_url":"https://api.github.com/repos/niosus/EasyClangComplete/git/commits{/sha}","comments_url":"https://api.github.com/repos/niosus/EasyClangComplete/comments{/number}","issue_comment_url":"https://api.github.com/repos/niosus/EasyClangComplete/issues/comments{/number}","contents_url":"https://api.github.com/repos/niosus/EasyClangComplete/contents/{+path}","compare_url":"https://api.github.com/repos/niosus/EasyClangComplete/compare/{base}...{head}","merges_url":"https://api.github.com/repos/niosus/EasyClangComplete/merges","archive_url":"https://api.github.com/repos/niosus/EasyClangComplete/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/niosus/EasyClangComplete/downloads","issues_url":"https://api.github.com/repos/niosus/EasyClangComplete/issues{/number}","pulls_url":"https://api.github.com/repos/niosus/EasyClangComplete/pulls{/number}","milestones_url":"https://api.github.com/repos/niosus/EasyClangComplete/milestones{/number}","notifications_url":"https://api.github.com/repos/niosus/EasyClangComplete/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/niosus/EasyClangComplete/labels{/name}","releases_url":"https://api.github.com/repos/niosus/EasyClangComplete/releases{/id}","deployments_url":"https://api.github.com/repos/niosus/EasyClangComplete/deployments","created_at":"2016-03-11T16:00:29Z","updated_at":"2016-11-18T14:35:28Z","pushed_at":"2016-11-18T23:13:53Z","git_url":"git://github.com/niosus/EasyClangComplete.git","ssh_url":"git@github.com:niosus/EasyClangComplete.git","clone_url":"https://github.com/niosus/EasyClangComplete.git","svn_url":"https://github.com/niosus/EasyClangComplete","homepage":null,"size":3735,"stargazers_count":145,"watchers_count":145,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":17,"forks":18,"open_issues":17,"watchers":145,"default_branch":"master"}},"base":{"label":"niosus:master","ref":"master","sha":"df2b59509630ce119400096230b9fedbd7c64ad6","user":{"login":"niosus","id":1893598,"avatar_url":"https://avatars.githubusercontent.com/u/1893598?v=3","gravatar_id":"","url":"https://api.github.com/users/niosus","html_url":"https://github.com/niosus","followers_url":"https://api.github.com/users/niosus/followers","following_url":"https://api.github.com/users/niosus/following{/other_user}","gists_url":"https://api.github.com/users/niosus/gists{/gist_id}","starred_url":"https://api.github.com/users/niosus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/niosus/subscriptions","organizations_url":"https://api.github.com/users/niosus/orgs","repos_url":"https://api.github.com/users/niosus/repos","events_url":"https://api.github.com/users/niosus/events{/privacy}","received_events_url":"https://api.github.com/users/niosus/received_events","type":"User","site_admin":false},"repo":{"id":53678733,"name":"EasyClangComplete","full_name":"niosus/EasyClangComplete","owner":{"login":"niosus","id":1893598,"avatar_url":"https://avatars.githubusercontent.com/u/1893598?v=3","gravatar_id":"","url":"https://api.github.com/users/niosus","html_url":"https://github.com/niosus","followers_url":"https://api.github.com/users/niosus/followers","following_url":"https://api.github.com/users/niosus/following{/other_user}","gists_url":"https://api.github.com/users/niosus/gists{/gist_id}","starred_url":"https://api.github.com/users/niosus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/niosus/subscriptions","organizations_url":"https://api.github.com/users/niosus/orgs","repos_url":"https://api.github.com/users/niosus/repos","events_url":"https://api.github.com/users/niosus/events{/privacy}","received_events_url":"https://api.github.com/users/niosus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/niosus/EasyClangComplete","description":"Sublime Text 3 plugin that offers auto-completion of C/C++ structure members or class attributes and methods.","fork":false,"url":"https://api.github.com/repos/niosus/EasyClangComplete","forks_url":"https://api.github.com/repos/niosus/EasyClangComplete/forks","keys_url":"https://api.github.com/repos/niosus/EasyClangComplete/keys{/key_id}","collaborators_url":"https://api.github.com/repos/niosus/EasyClangComplete/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/niosus/EasyClangComplete/teams","hooks_url":"https://api.github.com/repos/niosus/EasyClangComplete/hooks","issue_events_url":"https://api.github.com/repos/niosus/EasyClangComplete/issues/events{/number}","events_url":"https://api.github.com/repos/niosus/EasyClangComplete/events","assignees_url":"https://api.github.com/repos/niosus/EasyClangComplete/assignees{/user}","branches_url":"https://api.github.com/repos/niosus/EasyClangComplete/branches{/branch}","tags_url":"https://api.github.com/repos/niosus/EasyClangComplete/tags","blobs_url":"https://api.github.com/repos/niosus/EasyClangComplete/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/niosus/EasyClangComplete/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/niosus/EasyClangComplete/git/refs{/sha}","trees_url":"https://api.github.com/repos/niosus/EasyClangComplete/git/trees{/sha}","statuses_url":"https://api.github.com/repos/niosus/EasyClangComplete/statuses/{sha}","languages_url":"https://api.github.com/repos/niosus/EasyClangComplete/languages","stargazers_url":"https://api.github.com/repos/niosus/EasyClangComplete/stargazers","contributors_url":"https://api.github.com/repos/niosus/EasyClangComplete/contributors","subscribers_url":"https://api.github.com/repos/niosus/EasyClangComplete/subscribers","subscription_url":"https://api.github.com/repos/niosus/EasyClangComplete/subscription","commits_url":"https://api.github.com/repos/niosus/EasyClangComplete/commits{/sha}","git_commits_url":"https://api.github.com/repos/niosus/EasyClangComplete/git/commits{/sha}","comments_url":"https://api.github.com/repos/niosus/EasyClangComplete/comments{/number}","issue_comment_url":"https://api.github.com/repos/niosus/EasyClangComplete/issues/comments{/number}","contents_url":"https://api.github.com/repos/niosus/EasyClangComplete/contents/{+path}","compare_url":"https://api.github.com/repos/niosus/EasyClangComplete/compare/{base}...{head}","merges_url":"https://api.github.com/repos/niosus/EasyClangComplete/merges","archive_url":"https://api.github.com/repos/niosus/EasyClangComplete/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/niosus/EasyClangComplete/downloads","issues_url":"https://api.github.com/repos/niosus/EasyClangComplete/issues{/number}","pulls_url":"https://api.github.com/repos/niosus/EasyClangComplete/pulls{/number}","milestones_url":"https://api.github.com/repos/niosus/EasyClangComplete/milestones{/number}","notifications_url":"https://api.github.com/repos/niosus/EasyClangComplete/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/niosus/EasyClangComplete/labels{/name}","releases_url":"https://api.github.com/repos/niosus/EasyClangComplete/releases{/id}","deployments_url":"https://api.github.com/repos/niosus/EasyClangComplete/deployments","created_at":"2016-03-11T16:00:29Z","updated_at":"2016-11-18T14:35:28Z","pushed_at":"2016-11-18T23:13:53Z","git_url":"git://github.com/niosus/EasyClangComplete.git","ssh_url":"git@github.com:niosus/EasyClangComplete.git","clone_url":"https://github.com/niosus/EasyClangComplete.git","svn_url":"https://github.com/niosus/EasyClangComplete","homepage":null,"size":3735,"stargazers_count":145,"watchers_count":145,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":17,"forks":18,"open_issues":17,"watchers":145,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/niosus/EasyClangComplete/pulls/144"},"html":{"href":"https://github.com/niosus/EasyClangComplete/pull/144"},"issue":{"href":"https://api.github.com/repos/niosus/EasyClangComplete/issues/144"},"comments":{"href":"https://api.github.com/repos/niosus/EasyClangComplete/issues/144/comments"},"review_comments":{"href":"https://api.github.com/repos/niosus/EasyClangComplete/pulls/144/comments"},"review_comment":{"href":"https://api.github.com/repos/niosus/EasyClangComplete/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/niosus/EasyClangComplete/pulls/144/commits"},"statuses":{"href":"https://api.github.com/repos/niosus/EasyClangComplete/statuses/6dd4af1823f257d6a5583181ed23e49be1eb2489"}}}}
{"actor":{"display_login":"niosus"}}