{"action":"closed","number":48,"pull_request":{"url":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/pulls/48","id":61375919,"html_url":"https://github.com/jenkinsci/openstack-cloud-plugin/pull/48","diff_url":"https://github.com/jenkinsci/openstack-cloud-plugin/pull/48.diff","patch_url":"https://github.com/jenkinsci/openstack-cloud-plugin/pull/48.patch","issue_url":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/issues/48","number":48,"state":"closed","locked":false,"title":"Fix #39: Allow all slave/machine attributes to be overriden per template","user":{"login":"olivergondza","id":206841,"avatar_url":"https://avatars.githubusercontent.com/u/206841?v=3","gravatar_id":"","url":"https://api.github.com/users/olivergondza","html_url":"https://github.com/olivergondza","followers_url":"https://api.github.com/users/olivergondza/followers","following_url":"https://api.github.com/users/olivergondza/following{/other_user}","gists_url":"https://api.github.com/users/olivergondza/gists{/gist_id}","starred_url":"https://api.github.com/users/olivergondza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olivergondza/subscriptions","organizations_url":"https://api.github.com/users/olivergondza/orgs","repos_url":"https://api.github.com/users/olivergondza/repos","events_url":"https://api.github.com/users/olivergondza/events{/privacy}","received_events_url":"https://api.github.com/users/olivergondza/received_events","type":"User","site_admin":false},"body":"All the machine/slave attributes can be now specified on cloud level to centralize defaults as well as template level to override where needed.\r\n\r\nhttps://github.com/jenkinsci/openstack-cloud-plugin/issues/39\r\n\r\nTODO:\r\n- [x] Validation does not work for nested `SlaveOptions`.\r\n- [x] Validation fails for empty fields with nonempty default.\r\n- [x] Present defaults for select boxes.\r\n- [x] Fix `instanceCap` overriding","created_at":"2016-03-02T09:58:50Z","updated_at":"2016-03-08T12:09:17Z","closed_at":"2016-03-08T12:09:17Z","merged_at":null,"merge_commit_sha":"b3a4e85f9343a5af4a59c3678213fc7b0d15c38c","assignee":{"login":"olivergondza","id":206841,"avatar_url":"https://avatars.githubusercontent.com/u/206841?v=3","gravatar_id":"","url":"https://api.github.com/users/olivergondza","html_url":"https://github.com/olivergondza","followers_url":"https://api.github.com/users/olivergondza/followers","following_url":"https://api.github.com/users/olivergondza/following{/other_user}","gists_url":"https://api.github.com/users/olivergondza/gists{/gist_id}","starred_url":"https://api.github.com/users/olivergondza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olivergondza/subscriptions","organizations_url":"https://api.github.com/users/olivergondza/orgs","repos_url":"https://api.github.com/users/olivergondza/repos","events_url":"https://api.github.com/users/olivergondza/events{/privacy}","received_events_url":"https://api.github.com/users/olivergondza/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/milestones/2","html_url":"https://github.com/jenkinsci/openstack-cloud-plugin/milestones/2.1","labels_url":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/milestones/2/labels","id":1613286,"number":2,"title":"2.1","description":null,"creator":{"login":"olivergondza","id":206841,"avatar_url":"https://avatars.githubusercontent.com/u/206841?v=3","gravatar_id":"","url":"https://api.github.com/users/olivergondza","html_url":"https://github.com/olivergondza","followers_url":"https://api.github.com/users/olivergondza/followers","following_url":"https://api.github.com/users/olivergondza/following{/other_user}","gists_url":"https://api.github.com/users/olivergondza/gists{/gist_id}","starred_url":"https://api.github.com/users/olivergondza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olivergondza/subscriptions","organizations_url":"https://api.github.com/users/olivergondza/orgs","repos_url":"https://api.github.com/users/olivergondza/repos","events_url":"https://api.github.com/users/olivergondza/events{/privacy}","received_events_url":"https://api.github.com/users/olivergondza/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":2,"state":"open","created_at":"2016-02-29T20:48:13Z","updated_at":"2016-03-08T12:09:17Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/pulls/48/commits","review_comments_url":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/pulls/48/comments","review_comment_url":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/issues/48/comments","statuses_url":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/statuses/0dfeb5411506c53409d05066a8de5df24504e3ee","head":{"label":"olivergondza:overrides","ref":"overrides","sha":"0dfeb5411506c53409d05066a8de5df24504e3ee","user":{"login":"olivergondza","id":206841,"avatar_url":"https://avatars.githubusercontent.com/u/206841?v=3","gravatar_id":"","url":"https://api.github.com/users/olivergondza","html_url":"https://github.com/olivergondza","followers_url":"https://api.github.com/users/olivergondza/followers","following_url":"https://api.github.com/users/olivergondza/following{/other_user}","gists_url":"https://api.github.com/users/olivergondza/gists{/gist_id}","starred_url":"https://api.github.com/users/olivergondza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olivergondza/subscriptions","organizations_url":"https://api.github.com/users/olivergondza/orgs","repos_url":"https://api.github.com/users/olivergondza/repos","events_url":"https://api.github.com/users/olivergondza/events{/privacy}","received_events_url":"https://api.github.com/users/olivergondza/received_events","type":"User","site_admin":false},"repo":{"id":36936961,"name":"openstack-cloud-plugin","full_name":"olivergondza/openstack-cloud-plugin","owner":{"login":"olivergondza","id":206841,"avatar_url":"https://avatars.githubusercontent.com/u/206841?v=3","gravatar_id":"","url":"https://api.github.com/users/olivergondza","html_url":"https://github.com/olivergondza","followers_url":"https://api.github.com/users/olivergondza/followers","following_url":"https://api.github.com/users/olivergondza/following{/other_user}","gists_url":"https://api.github.com/users/olivergondza/gists{/gist_id}","starred_url":"https://api.github.com/users/olivergondza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olivergondza/subscriptions","organizations_url":"https://api.github.com/users/olivergondza/orgs","repos_url":"https://api.github.com/users/olivergondza/repos","events_url":"https://api.github.com/users/olivergondza/events{/privacy}","received_events_url":"https://api.github.com/users/olivergondza/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/olivergondza/openstack-cloud-plugin","description":"","fork":true,"url":"https://api.github.com/repos/olivergondza/openstack-cloud-plugin","forks_url":"https://api.github.com/repos/olivergondza/openstack-cloud-plugin/forks","keys_url":"https://api.github.com/repos/olivergondza/openstack-cloud-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/olivergondza/openstack-cloud-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/olivergondza/openstack-cloud-plugin/teams","hooks_url":"https://api.github.com/repos/olivergondza/openstack-cloud-plugin/hooks","issue_events_url":"https://api.github.com/repos/olivergondza/openstack-cloud-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/olivergondza/openstack-cloud-plugin/events","assignees_url":"https://api.github.com/repos/olivergondza/openstack-cloud-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/olivergondza/openstack-cloud-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/olivergondza/openstack-cloud-plugin/tags","blobs_url":"https://api.github.com/repos/olivergondza/openstack-cloud-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/olivergondza/openstack-cloud-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/olivergondza/openstack-cloud-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/olivergondza/openstack-cloud-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/olivergondza/openstack-cloud-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/olivergondza/openstack-cloud-plugin/languages","stargazers_url":"https://api.github.com/repos/olivergondza/openstack-cloud-plugin/stargazers","contributors_url":"https://api.github.com/repos/olivergondza/openstack-cloud-plugin/contributors","subscribers_url":"https://api.github.com/repos/olivergondza/openstack-cloud-plugin/subscribers","subscription_url":"https://api.github.com/repos/olivergondza/openstack-cloud-plugin/subscription","commits_url":"https://api.github.com/repos/olivergondza/openstack-cloud-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/olivergondza/openstack-cloud-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/olivergondza/openstack-cloud-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/olivergondza/openstack-cloud-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/olivergondza/openstack-cloud-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/olivergondza/openstack-cloud-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/olivergondza/openstack-cloud-plugin/merges","archive_url":"https://api.github.com/repos/olivergondza/openstack-cloud-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/olivergondza/openstack-cloud-plugin/downloads","issues_url":"https://api.github.com/repos/olivergondza/openstack-cloud-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/olivergondza/openstack-cloud-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/olivergondza/openstack-cloud-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/olivergondza/openstack-cloud-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/olivergondza/openstack-cloud-plugin/labels{/name}","releases_url":"https://api.github.com/repos/olivergondza/openstack-cloud-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/olivergondza/openstack-cloud-plugin/deployments","created_at":"2015-06-05T14:25:07Z","updated_at":"2015-06-05T14:25:08Z","pushed_at":"2016-03-08T11:52:17Z","git_url":"git://github.com/olivergondza/openstack-cloud-plugin.git","ssh_url":"git@github.com:olivergondza/openstack-cloud-plugin.git","clone_url":"https://github.com/olivergondza/openstack-cloud-plugin.git","svn_url":"https://github.com/olivergondza/openstack-cloud-plugin","homepage":"https://wiki.jenkins-ci.org/display/JENKINS/Openstack+Cloud+Plugin","size":901,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jenkinsci:master","ref":"master","sha":"2c49276ff724fde3faa751921907798ad8ee3e21","user":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"repo":{"id":30764186,"name":"openstack-cloud-plugin","full_name":"jenkinsci/openstack-cloud-plugin","owner":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jenkinsci/openstack-cloud-plugin","description":"","fork":false,"url":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin","forks_url":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/forks","keys_url":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/teams","hooks_url":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/hooks","issue_events_url":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/events","assignees_url":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/tags","blobs_url":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/languages","stargazers_url":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/stargazers","contributors_url":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/contributors","subscribers_url":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/subscribers","subscription_url":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/subscription","commits_url":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/merges","archive_url":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/downloads","issues_url":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/labels{/name}","releases_url":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/deployments","created_at":"2015-02-13T16:13:29Z","updated_at":"2016-02-25T09:18:56Z","pushed_at":"2016-03-08T11:52:17Z","git_url":"git://github.com/jenkinsci/openstack-cloud-plugin.git","ssh_url":"git@github.com:jenkinsci/openstack-cloud-plugin.git","clone_url":"https://github.com/jenkinsci/openstack-cloud-plugin.git","svn_url":"https://github.com/jenkinsci/openstack-cloud-plugin","homepage":"https://wiki.jenkins-ci.org/display/JENKINS/Openstack+Cloud+Plugin","size":881,"stargazers_count":11,"watchers_count":11,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":13,"forks":17,"open_issues":13,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/pulls/48"},"html":{"href":"https://github.com/jenkinsci/openstack-cloud-plugin/pull/48"},"issue":{"href":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/issues/48"},"comments":{"href":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/issues/48/comments"},"review_comments":{"href":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/pulls/48/comments"},"review_comment":{"href":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/pulls/48/commits"},"statuses":{"href":"https://api.github.com/repos/jenkinsci/openstack-cloud-plugin/statuses/0dfeb5411506c53409d05066a8de5df24504e3ee"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"commits":33,"additions":2107,"deletions":631,"changed_files":41}}