{"action":"closed","number":40,"pull_request":{"url":"https://api.github.com/repos/puppetlabs/clj-pcp-client/pulls/40","id":65335713,"html_url":"https://github.com/puppetlabs/clj-pcp-client/pull/40","diff_url":"https://github.com/puppetlabs/clj-pcp-client/pull/40.diff","patch_url":"https://github.com/puppetlabs/clj-pcp-client/pull/40.patch","issue_url":"https://api.github.com/repos/puppetlabs/clj-pcp-client/issues/40","number":40,"state":"closed","locked":false,"title":"(PCP-357) Don't start heartbeat task before connecting","user":{"login":"parisiale","id":7150922,"avatar_url":"https://avatars.githubusercontent.com/u/7150922?v=3","gravatar_id":"","url":"https://api.github.com/users/parisiale","html_url":"https://github.com/parisiale","followers_url":"https://api.github.com/users/parisiale/followers","following_url":"https://api.github.com/users/parisiale/following{/other_user}","gists_url":"https://api.github.com/users/parisiale/gists{/gist_id}","starred_url":"https://api.github.com/users/parisiale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parisiale/subscriptions","organizations_url":"https://api.github.com/users/parisiale/orgs","repos_url":"https://api.github.com/users/parisiale/repos","events_url":"https://api.github.com/users/parisiale/events{/privacy}","received_events_url":"https://api.github.com/users/parisiale/received_events","type":"User","site_admin":false},"body":"Adding the start-heartbeat-task to the Client interface; it will be up\r\nto the client code to actually start the heartbeat task to keep the\r\nWebSocket connection up.\r\n\r\nRemoving the call that starts the heartbeat task right before spawning\r\nthe make-connection thread (in the 'connect' function).","created_at":"2016-04-05T16:35:09Z","updated_at":"2016-04-06T12:46:07Z","closed_at":"2016-04-06T12:46:07Z","merged_at":"2016-04-06T12:46:07Z","merge_commit_sha":"0c56bb7fa555cf59f4d672735d7262add5868b6f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/clj-pcp-client/pulls/40/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/clj-pcp-client/pulls/40/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/clj-pcp-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/clj-pcp-client/issues/40/comments","statuses_url":"https://api.github.com/repos/puppetlabs/clj-pcp-client/statuses/b20c8e07d2c27b2dc0ffb837db6fc2097517a8bd","head":{"label":"parisiale:PCP-357_heartbeat","ref":"PCP-357_heartbeat","sha":"b20c8e07d2c27b2dc0ffb837db6fc2097517a8bd","user":{"login":"parisiale","id":7150922,"avatar_url":"https://avatars.githubusercontent.com/u/7150922?v=3","gravatar_id":"","url":"https://api.github.com/users/parisiale","html_url":"https://github.com/parisiale","followers_url":"https://api.github.com/users/parisiale/followers","following_url":"https://api.github.com/users/parisiale/following{/other_user}","gists_url":"https://api.github.com/users/parisiale/gists{/gist_id}","starred_url":"https://api.github.com/users/parisiale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parisiale/subscriptions","organizations_url":"https://api.github.com/users/parisiale/orgs","repos_url":"https://api.github.com/users/parisiale/repos","events_url":"https://api.github.com/users/parisiale/events{/privacy}","received_events_url":"https://api.github.com/users/parisiale/received_events","type":"User","site_admin":false},"repo":{"id":55523738,"name":"clj-pcp-client","full_name":"parisiale/clj-pcp-client","owner":{"login":"parisiale","id":7150922,"avatar_url":"https://avatars.githubusercontent.com/u/7150922?v=3","gravatar_id":"","url":"https://api.github.com/users/parisiale","html_url":"https://github.com/parisiale","followers_url":"https://api.github.com/users/parisiale/followers","following_url":"https://api.github.com/users/parisiale/following{/other_user}","gists_url":"https://api.github.com/users/parisiale/gists{/gist_id}","starred_url":"https://api.github.com/users/parisiale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parisiale/subscriptions","organizations_url":"https://api.github.com/users/parisiale/orgs","repos_url":"https://api.github.com/users/parisiale/repos","events_url":"https://api.github.com/users/parisiale/events{/privacy}","received_events_url":"https://api.github.com/users/parisiale/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/parisiale/clj-pcp-client","description":"Clojure Client for the Puppet Communications Protocol","fork":true,"url":"https://api.github.com/repos/parisiale/clj-pcp-client","forks_url":"https://api.github.com/repos/parisiale/clj-pcp-client/forks","keys_url":"https://api.github.com/repos/parisiale/clj-pcp-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/parisiale/clj-pcp-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/parisiale/clj-pcp-client/teams","hooks_url":"https://api.github.com/repos/parisiale/clj-pcp-client/hooks","issue_events_url":"https://api.github.com/repos/parisiale/clj-pcp-client/issues/events{/number}","events_url":"https://api.github.com/repos/parisiale/clj-pcp-client/events","assignees_url":"https://api.github.com/repos/parisiale/clj-pcp-client/assignees{/user}","branches_url":"https://api.github.com/repos/parisiale/clj-pcp-client/branches{/branch}","tags_url":"https://api.github.com/repos/parisiale/clj-pcp-client/tags","blobs_url":"https://api.github.com/repos/parisiale/clj-pcp-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/parisiale/clj-pcp-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/parisiale/clj-pcp-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/parisiale/clj-pcp-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/parisiale/clj-pcp-client/statuses/{sha}","languages_url":"https://api.github.com/repos/parisiale/clj-pcp-client/languages","stargazers_url":"https://api.github.com/repos/parisiale/clj-pcp-client/stargazers","contributors_url":"https://api.github.com/repos/parisiale/clj-pcp-client/contributors","subscribers_url":"https://api.github.com/repos/parisiale/clj-pcp-client/subscribers","subscription_url":"https://api.github.com/repos/parisiale/clj-pcp-client/subscription","commits_url":"https://api.github.com/repos/parisiale/clj-pcp-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/parisiale/clj-pcp-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/parisiale/clj-pcp-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/parisiale/clj-pcp-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/parisiale/clj-pcp-client/contents/{+path}","compare_url":"https://api.github.com/repos/parisiale/clj-pcp-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/parisiale/clj-pcp-client/merges","archive_url":"https://api.github.com/repos/parisiale/clj-pcp-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/parisiale/clj-pcp-client/downloads","issues_url":"https://api.github.com/repos/parisiale/clj-pcp-client/issues{/number}","pulls_url":"https://api.github.com/repos/parisiale/clj-pcp-client/pulls{/number}","milestones_url":"https://api.github.com/repos/parisiale/clj-pcp-client/milestones{/number}","notifications_url":"https://api.github.com/repos/parisiale/clj-pcp-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/parisiale/clj-pcp-client/labels{/name}","releases_url":"https://api.github.com/repos/parisiale/clj-pcp-client/releases{/id}","deployments_url":"https://api.github.com/repos/parisiale/clj-pcp-client/deployments","created_at":"2016-04-05T16:25:20Z","updated_at":"2016-04-05T16:25:21Z","pushed_at":"2016-04-06T11:27:37Z","git_url":"git://github.com/parisiale/clj-pcp-client.git","ssh_url":"git@github.com:parisiale/clj-pcp-client.git","clone_url":"https://github.com/parisiale/clj-pcp-client.git","svn_url":"https://github.com/parisiale/clj-pcp-client","homepage":"","size":323,"stargazers_count":0,"watchers_count":0,"language":"Clojure","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"f528a1dcf29ae4e313d98cd1db37508bfb2f59d1","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":32732126,"name":"clj-pcp-client","full_name":"puppetlabs/clj-pcp-client","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/clj-pcp-client","description":"Clojure Client for the Puppet Communications Protocol","fork":false,"url":"https://api.github.com/repos/puppetlabs/clj-pcp-client","forks_url":"https://api.github.com/repos/puppetlabs/clj-pcp-client/forks","keys_url":"https://api.github.com/repos/puppetlabs/clj-pcp-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/clj-pcp-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/clj-pcp-client/teams","hooks_url":"https://api.github.com/repos/puppetlabs/clj-pcp-client/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/clj-pcp-client/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/clj-pcp-client/events","assignees_url":"https://api.github.com/repos/puppetlabs/clj-pcp-client/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/clj-pcp-client/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/clj-pcp-client/tags","blobs_url":"https://api.github.com/repos/puppetlabs/clj-pcp-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/clj-pcp-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/clj-pcp-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/clj-pcp-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/clj-pcp-client/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/clj-pcp-client/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/clj-pcp-client/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/clj-pcp-client/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/clj-pcp-client/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/clj-pcp-client/subscription","commits_url":"https://api.github.com/repos/puppetlabs/clj-pcp-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/clj-pcp-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/clj-pcp-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/clj-pcp-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/clj-pcp-client/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/clj-pcp-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/clj-pcp-client/merges","archive_url":"https://api.github.com/repos/puppetlabs/clj-pcp-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/clj-pcp-client/downloads","issues_url":"https://api.github.com/repos/puppetlabs/clj-pcp-client/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/clj-pcp-client/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/clj-pcp-client/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/clj-pcp-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/clj-pcp-client/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/clj-pcp-client/releases{/id}","deployments_url":"https://api.github.com/repos/puppetlabs/clj-pcp-client/deployments","created_at":"2015-03-23T12:54:24Z","updated_at":"2016-03-15T10:33:17Z","pushed_at":"2016-04-06T12:46:07Z","git_url":"git://github.com/puppetlabs/clj-pcp-client.git","ssh_url":"git@github.com:puppetlabs/clj-pcp-client.git","clone_url":"https://github.com/puppetlabs/clj-pcp-client.git","svn_url":"https://github.com/puppetlabs/clj-pcp-client","homepage":"","size":354,"stargazers_count":0,"watchers_count":0,"language":"Clojure","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":1,"forks":4,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/clj-pcp-client/pulls/40"},"html":{"href":"https://github.com/puppetlabs/clj-pcp-client/pull/40"},"issue":{"href":"https://api.github.com/repos/puppetlabs/clj-pcp-client/issues/40"},"comments":{"href":"https://api.github.com/repos/puppetlabs/clj-pcp-client/issues/40/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/clj-pcp-client/pulls/40/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/clj-pcp-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/clj-pcp-client/pulls/40/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/clj-pcp-client/statuses/b20c8e07d2c27b2dc0ffb837db6fc2097517a8bd"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"mruzicka","id":562920,"avatar_url":"https://avatars.githubusercontent.com/u/562920?v=3","gravatar_id":"","url":"https://api.github.com/users/mruzicka","html_url":"https://github.com/mruzicka","followers_url":"https://api.github.com/users/mruzicka/followers","following_url":"https://api.github.com/users/mruzicka/following{/other_user}","gists_url":"https://api.github.com/users/mruzicka/gists{/gist_id}","starred_url":"https://api.github.com/users/mruzicka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mruzicka/subscriptions","organizations_url":"https://api.github.com/users/mruzicka/orgs","repos_url":"https://api.github.com/users/mruzicka/repos","events_url":"https://api.github.com/users/mruzicka/events{/privacy}","received_events_url":"https://api.github.com/users/mruzicka/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":2,"additions":39,"deletions":8,"changed_files":2}}