{"action":"created","issue":{"url":"https://api.github.com/repos/snoplus/orca/issues/46","repository_url":"https://api.github.com/repos/snoplus/orca","labels_url":"https://api.github.com/repos/snoplus/orca/issues/46/labels{/name}","comments_url":"https://api.github.com/repos/snoplus/orca/issues/46/comments","events_url":"https://api.github.com/repos/snoplus/orca/issues/46/events","html_url":"https://github.com/snoplus/orca/pull/46","id":140513571,"number":46,"title":"HV Monitoring Updates","user":{"login":"BenLand100","id":539327,"avatar_url":"https://avatars.githubusercontent.com/u/539327?v=3","gravatar_id":"","url":"https://api.github.com/users/BenLand100","html_url":"https://github.com/BenLand100","followers_url":"https://api.github.com/users/BenLand100/followers","following_url":"https://api.github.com/users/BenLand100/following{/other_user}","gists_url":"https://api.github.com/users/BenLand100/gists{/gist_id}","starred_url":"https://api.github.com/users/BenLand100/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BenLand100/subscriptions","organizations_url":"https://api.github.com/users/BenLand100/orgs","repos_url":"https://api.github.com/users/BenLand100/repos","events_url":"https://api.github.com/users/BenLand100/events{/privacy}","received_events_url":"https://api.github.com/users/BenLand100/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-03-13T18:33:16Z","updated_at":"2016-05-02T21:17:54Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/snoplus/orca/pulls/46","html_url":"https://github.com/snoplus/orca/pull/46","diff_url":"https://github.com/snoplus/orca/pull/46.diff","patch_url":"https://github.com/snoplus/orca/pull/46.patch"},"body":"Here are the changes discussed in the DAQ workshop. This has been tested on the teststand.\r\n\r\nThe former 'control' thread now lives as long as an XL3 is connected and reads out the HV status every second. In the event of a >100V discrepancy (arbitrary but the same as the ramp discrepancy check) between the setpoint and the readback an alarm will be posted and the new 'Accept Readback'  button (replaces 'Get Status' since this is now automatic) becomes available while all other HV actions are suspended. If the user presses the 'Accept Readback' button, the readout value becomes the setpoint and HV control resumes. If the high voltage recovers on its own (intermittent readout issue) the monitoring thread realizes and resumes control automatically but the operator must still clear the alarm.  \r\n\r\nThere is now a convenient spot in the HV control thread to add any checks of HV status one could imagine (current limits have been requested but not yet implemented). \r\n\r\nAlso, this includes #43. While the panic down will always work, depending on whether or not the XL3 times out and disconnects, Orca will currently either treat the panic down as a discrepancy requiring user intervention before HV control can be resumed (no disconnect) OR will recover automatically (disconnects)."},"comment":{"url":"https://api.github.com/repos/snoplus/orca/issues/comments/216367352","html_url":"https://github.com/snoplus/orca/pull/46#issuecomment-216367352","issue_url":"https://api.github.com/repos/snoplus/orca/issues/46","id":216367352,"user":{"login":"tlatorre-uchicago","id":5834059,"avatar_url":"https://avatars.githubusercontent.com/u/5834059?v=3","gravatar_id":"","url":"https://api.github.com/users/tlatorre-uchicago","html_url":"https://github.com/tlatorre-uchicago","followers_url":"https://api.github.com/users/tlatorre-uchicago/followers","following_url":"https://api.github.com/users/tlatorre-uchicago/following{/other_user}","gists_url":"https://api.github.com/users/tlatorre-uchicago/gists{/gist_id}","starred_url":"https://api.github.com/users/tlatorre-uchicago/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tlatorre-uchicago/subscriptions","organizations_url":"https://api.github.com/users/tlatorre-uchicago/orgs","repos_url":"https://api.github.com/users/tlatorre-uchicago/repos","events_url":"https://api.github.com/users/tlatorre-uchicago/events{/privacy}","received_events_url":"https://api.github.com/users/tlatorre-uchicago/received_events","type":"User","site_admin":false},"created_at":"2016-05-02T21:17:54Z","updated_at":"2016-05-02T21:17:54Z","body":"Also, could you add a comment above the commented out initialized checks explaining why they aren't needed anymore or just delete them?"}}