{"action":"created","issue":{"url":"https://api.github.com/repos/open-watcom/open-watcom-v2/issues/245","repository_url":"https://api.github.com/repos/open-watcom/open-watcom-v2","labels_url":"https://api.github.com/repos/open-watcom/open-watcom-v2/issues/245/labels{/name}","comments_url":"https://api.github.com/repos/open-watcom/open-watcom-v2/issues/245/comments","events_url":"https://api.github.com/repos/open-watcom/open-watcom-v2/issues/245/events","html_url":"https://github.com/open-watcom/open-watcom-v2/pull/245","id":153631322,"number":245,"title":"fix crash on build [fixes #184]","user":{"login":"stsp","id":3295627,"avatar_url":"https://avatars.githubusercontent.com/u/3295627?v=3","gravatar_id":"","url":"https://api.github.com/users/stsp","html_url":"https://github.com/stsp","followers_url":"https://api.github.com/users/stsp/followers","following_url":"https://api.github.com/users/stsp/following{/other_user}","gists_url":"https://api.github.com/users/stsp/gists{/gist_id}","starred_url":"https://api.github.com/users/stsp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stsp/subscriptions","organizations_url":"https://api.github.com/users/stsp/orgs","repos_url":"https://api.github.com/users/stsp/repos","events_url":"https://api.github.com/users/stsp/events{/privacy}","received_events_url":"https://api.github.com/users/stsp/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-05-08T02:41:48Z","updated_at":"2016-05-08T12:03:01Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/open-watcom/open-watcom-v2/pulls/245","html_url":"https://github.com/open-watcom/open-watcom-v2/pull/245","diff_url":"https://github.com/open-watcom/open-watcom-v2/pull/245.diff","patch_url":"https://github.com/open-watcom/open-watcom-v2/pull/245.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/open-watcom/open-watcom-v2/issues/comments/217711918","html_url":"https://github.com/open-watcom/open-watcom-v2/pull/245#issuecomment-217711918","issue_url":"https://api.github.com/repos/open-watcom/open-watcom-v2/issues/245","id":217711918,"user":{"login":"stsp","id":3295627,"avatar_url":"https://avatars.githubusercontent.com/u/3295627?v=3","gravatar_id":"","url":"https://api.github.com/users/stsp","html_url":"https://github.com/stsp","followers_url":"https://api.github.com/users/stsp/followers","following_url":"https://api.github.com/users/stsp/following{/other_user}","gists_url":"https://api.github.com/users/stsp/gists{/gist_id}","starred_url":"https://api.github.com/users/stsp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stsp/subscriptions","organizations_url":"https://api.github.com/users/stsp/orgs","repos_url":"https://api.github.com/users/stsp/repos","events_url":"https://api.github.com/users/stsp/events{/privacy}","received_events_url":"https://api.github.com/users/stsp/received_events","type":"User","site_admin":false},"created_at":"2016-05-08T12:03:01Z","updated_at":"2016-05-08T12:03:01Z","body":"> Fix for bld/plusplus/c/convctl.c need review.\r\n\r\nYes.\r\nLet me clarify what actually happens.\r\nWhen https://github.com/stsp/open-watcom-v2/blob/fix_crash/bld/plusplus/c/convctl.c#L1259\r\nretn = classPtrConversion( a_expr, tgt_type, conversion );\r\nreturns something other than CNV_OK_CV, the \"retn\"\r\nvalue is not fixed-up to CNV_OK. In this case the branch\r\nhttps://github.com/stsp/open-watcom-v2/blob/fix_crash/bld/plusplus/c/convctl.c#L1267\r\ndoes not enter, and \"expr_type\" is left uninitialized.\r\nHowever, it is still used on the branch\r\nhttps://github.com/stsp/open-watcom-v2/blob/fix_crash/bld/plusplus/c/convctl.c#L1291\r\nnamely, here:\r\nhttps://github.com/stsp/open-watcom-v2/blob/fix_crash/bld/plusplus/c/convctl.c#L1300\r\nThen the crash.\r\n\r\nPlease note that there is an alternative code disabled:\r\nhttps://github.com/stsp/open-watcom-v2/blob/fix_crash/bld/plusplus/c/convctl.c#L1237\r\nIt looks safer as it initializes \"expr_type\" in any case,\r\nbut I guess this was considered slow and some \"optimization\"\r\nwas applied instead, that now leads to crash.\r\n\r\nPlease make whatever fix you think necessary.\r\nI only tracked and patched the one particular return\r\nvalue that I observed, but you should know a better fix."}}