{"action":"created","comment":{"url":"https://api.github.com/repos/electron/electron/pulls/comments/90577204","pull_request_review_id":11096860,"id":90577204,"diff_hunk":"@@ -158,4 +161,25 @@ void AtomBindings::Log(const base::string16& message) {\n   std::cout << message << std::flush;\n }\n \n+void AtomBindings::CrashTest() {\n+  Crash();\n+}\n+\n+void AtomBindings::StartCrashReporter(const std::string productName, const std::string companyName, const std::string submitUrl, const std::string tmpPath, const std::map<std::string, std::string>& extra_parameters) {","path":"atom/common/api/atom_bindings.cc","position":null,"original_position":18,"commit_id":"8c856c942edcfd5d112bece95365945eff276633","original_commit_id":"43eeb932bc00fcc842fd018dc7bc12d0f6684444","user":{"login":"ramya-rao-a","id":16890566,"avatar_url":"https://avatars.githubusercontent.com/u/16890566?v=3","gravatar_id":"","url":"https://api.github.com/users/ramya-rao-a","html_url":"https://github.com/ramya-rao-a","followers_url":"https://api.github.com/users/ramya-rao-a/followers","following_url":"https://api.github.com/users/ramya-rao-a/following{/other_user}","gists_url":"https://api.github.com/users/ramya-rao-a/gists{/gist_id}","starred_url":"https://api.github.com/users/ramya-rao-a/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ramya-rao-a/subscriptions","organizations_url":"https://api.github.com/users/ramya-rao-a/orgs","repos_url":"https://api.github.com/users/ramya-rao-a/repos","events_url":"https://api.github.com/users/ramya-rao-a/events{/privacy}","received_events_url":"https://api.github.com/users/ramya-rao-a/received_events","type":"User","site_admin":false},"body":"Fixed","created_at":"2016-12-02T02:21:12Z","updated_at":"2016-12-02T02:21:12Z","html_url":"https://github.com/electron/electron/pull/8109#discussion_r90577204","pull_request_url":"https://api.github.com/repos/electron/electron/pulls/8109","_links":{"self":{"href":"https://api.github.com/repos/electron/electron/pulls/comments/90577204"},"html":{"href":"https://github.com/electron/electron/pull/8109#discussion_r90577204"},"pull_request":{"href":"https://api.github.com/repos/electron/electron/pulls/8109"}}},"pull_request":{"url":"https://api.github.com/repos/electron/electron/pulls/8109","id":96001197,"html_url":"https://github.com/electron/electron/pull/8109","diff_url":"https://github.com/electron/electron/pull/8109.diff","patch_url":"https://github.com/electron/electron/pull/8109.patch","issue_url":"https://api.github.com/repos/electron/electron/issues/8109","number":8109,"state":"open","locked":false,"title":"Expose crash reporter start for child node processes ","user":{"login":"ramya-rao-a","id":16890566,"avatar_url":"https://avatars.githubusercontent.com/u/16890566?v=3","gravatar_id":"","url":"https://api.github.com/users/ramya-rao-a","html_url":"https://github.com/ramya-rao-a","followers_url":"https://api.github.com/users/ramya-rao-a/followers","following_url":"https://api.github.com/users/ramya-rao-a/following{/other_user}","gists_url":"https://api.github.com/users/ramya-rao-a/gists{/gist_id}","starred_url":"https://api.github.com/users/ramya-rao-a/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ramya-rao-a/subscriptions","organizations_url":"https://api.github.com/users/ramya-rao-a/orgs","repos_url":"https://api.github.com/users/ramya-rao-a/repos","events_url":"https://api.github.com/users/ramya-rao-a/events{/privacy}","received_events_url":"https://api.github.com/users/ramya-rao-a/received_events","type":"User","site_admin":false},"body":"@kevinsawicki \r\n\r\nThis is the first draft of the fix (for #7474) that I propose for child node processes to be able to initialize crash reporter. \r\nIt has been tested only in Mac for now, I wanted to get your initial thoughts before I move on to Windows and Linux.\r\n\r\n**Note**: Changes to the files `index.html`, `default_app.js` and the new file `forkedProcess.js` are here only for testing. Will of course remove them from the final draft. ","created_at":"2016-12-01T00:13:09Z","updated_at":"2016-12-02T02:21:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"29749ef054b6ee7004bb46d5c652a3b726a365a8","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/electron/electron/pulls/8109/commits","review_comments_url":"https://api.github.com/repos/electron/electron/pulls/8109/comments","review_comment_url":"https://api.github.com/repos/electron/electron/pulls/comments{/number}","comments_url":"https://api.github.com/repos/electron/electron/issues/8109/comments","statuses_url":"https://api.github.com/repos/electron/electron/statuses/8c856c942edcfd5d112bece95365945eff276633","head":{"label":"ramya-rao-a:crash-for-children","ref":"crash-for-children","sha":"8c856c942edcfd5d112bece95365945eff276633","user":{"login":"ramya-rao-a","id":16890566,"avatar_url":"https://avatars.githubusercontent.com/u/16890566?v=3","gravatar_id":"","url":"https://api.github.com/users/ramya-rao-a","html_url":"https://github.com/ramya-rao-a","followers_url":"https://api.github.com/users/ramya-rao-a/followers","following_url":"https://api.github.com/users/ramya-rao-a/following{/other_user}","gists_url":"https://api.github.com/users/ramya-rao-a/gists{/gist_id}","starred_url":"https://api.github.com/users/ramya-rao-a/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ramya-rao-a/subscriptions","organizations_url":"https://api.github.com/users/ramya-rao-a/orgs","repos_url":"https://api.github.com/users/ramya-rao-a/repos","events_url":"https://api.github.com/users/ramya-rao-a/events{/privacy}","received_events_url":"https://api.github.com/users/ramya-rao-a/received_events","type":"User","site_admin":false},"repo":{"id":74622208,"name":"electron","full_name":"ramya-rao-a/electron","owner":{"login":"ramya-rao-a","id":16890566,"avatar_url":"https://avatars.githubusercontent.com/u/16890566?v=3","gravatar_id":"","url":"https://api.github.com/users/ramya-rao-a","html_url":"https://github.com/ramya-rao-a","followers_url":"https://api.github.com/users/ramya-rao-a/followers","following_url":"https://api.github.com/users/ramya-rao-a/following{/other_user}","gists_url":"https://api.github.com/users/ramya-rao-a/gists{/gist_id}","starred_url":"https://api.github.com/users/ramya-rao-a/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ramya-rao-a/subscriptions","organizations_url":"https://api.github.com/users/ramya-rao-a/orgs","repos_url":"https://api.github.com/users/ramya-rao-a/repos","events_url":"https://api.github.com/users/ramya-rao-a/events{/privacy}","received_events_url":"https://api.github.com/users/ramya-rao-a/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ramya-rao-a/electron","description":"Build cross platform desktop apps with JavaScript, HTML, and CSS","fork":true,"url":"https://api.github.com/repos/ramya-rao-a/electron","forks_url":"https://api.github.com/repos/ramya-rao-a/electron/forks","keys_url":"https://api.github.com/repos/ramya-rao-a/electron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ramya-rao-a/electron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ramya-rao-a/electron/teams","hooks_url":"https://api.github.com/repos/ramya-rao-a/electron/hooks","issue_events_url":"https://api.github.com/repos/ramya-rao-a/electron/issues/events{/number}","events_url":"https://api.github.com/repos/ramya-rao-a/electron/events","assignees_url":"https://api.github.com/repos/ramya-rao-a/electron/assignees{/user}","branches_url":"https://api.github.com/repos/ramya-rao-a/electron/branches{/branch}","tags_url":"https://api.github.com/repos/ramya-rao-a/electron/tags","blobs_url":"https://api.github.com/repos/ramya-rao-a/electron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ramya-rao-a/electron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ramya-rao-a/electron/git/refs{/sha}","trees_url":"https://api.github.com/repos/ramya-rao-a/electron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ramya-rao-a/electron/statuses/{sha}","languages_url":"https://api.github.com/repos/ramya-rao-a/electron/languages","stargazers_url":"https://api.github.com/repos/ramya-rao-a/electron/stargazers","contributors_url":"https://api.github.com/repos/ramya-rao-a/electron/contributors","subscribers_url":"https://api.github.com/repos/ramya-rao-a/electron/subscribers","subscription_url":"https://api.github.com/repos/ramya-rao-a/electron/subscription","commits_url":"https://api.github.com/repos/ramya-rao-a/electron/commits{/sha}","git_commits_url":"https://api.github.com/repos/ramya-rao-a/electron/git/commits{/sha}","comments_url":"https://api.github.com/repos/ramya-rao-a/electron/comments{/number}","issue_comment_url":"https://api.github.com/repos/ramya-rao-a/electron/issues/comments{/number}","contents_url":"https://api.github.com/repos/ramya-rao-a/electron/contents/{+path}","compare_url":"https://api.github.com/repos/ramya-rao-a/electron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ramya-rao-a/electron/merges","archive_url":"https://api.github.com/repos/ramya-rao-a/electron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ramya-rao-a/electron/downloads","issues_url":"https://api.github.com/repos/ramya-rao-a/electron/issues{/number}","pulls_url":"https://api.github.com/repos/ramya-rao-a/electron/pulls{/number}","milestones_url":"https://api.github.com/repos/ramya-rao-a/electron/milestones{/number}","notifications_url":"https://api.github.com/repos/ramya-rao-a/electron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ramya-rao-a/electron/labels{/name}","releases_url":"https://api.github.com/repos/ramya-rao-a/electron/releases{/id}","deployments_url":"https://api.github.com/repos/ramya-rao-a/electron/deployments","created_at":"2016-11-23T23:36:23Z","updated_at":"2016-11-23T23:36:32Z","pushed_at":"2016-12-02T02:19:56Z","git_url":"git://github.com/ramya-rao-a/electron.git","ssh_url":"git@github.com:ramya-rao-a/electron.git","clone_url":"https://github.com/ramya-rao-a/electron.git","svn_url":"https://github.com/ramya-rao-a/electron","homepage":"http://electron.atom.io","size":23485,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"electron:master","ref":"master","sha":"d0643250f717a9e5d9d4869f72fd5437c88e862f","user":{"login":"electron","id":13409222,"avatar_url":"https://avatars.githubusercontent.com/u/13409222?v=3","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"repo":{"id":9384267,"name":"electron","full_name":"electron/electron","owner":{"login":"electron","id":13409222,"avatar_url":"https://avatars.githubusercontent.com/u/13409222?v=3","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/electron/electron","description":"Build cross platform desktop apps with JavaScript, HTML, and CSS","fork":false,"url":"https://api.github.com/repos/electron/electron","forks_url":"https://api.github.com/repos/electron/electron/forks","keys_url":"https://api.github.com/repos/electron/electron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/electron/electron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/electron/electron/teams","hooks_url":"https://api.github.com/repos/electron/electron/hooks","issue_events_url":"https://api.github.com/repos/electron/electron/issues/events{/number}","events_url":"https://api.github.com/repos/electron/electron/events","assignees_url":"https://api.github.com/repos/electron/electron/assignees{/user}","branches_url":"https://api.github.com/repos/electron/electron/branches{/branch}","tags_url":"https://api.github.com/repos/electron/electron/tags","blobs_url":"https://api.github.com/repos/electron/electron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/electron/electron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/electron/electron/git/refs{/sha}","trees_url":"https://api.github.com/repos/electron/electron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/electron/electron/statuses/{sha}","languages_url":"https://api.github.com/repos/electron/electron/languages","stargazers_url":"https://api.github.com/repos/electron/electron/stargazers","contributors_url":"https://api.github.com/repos/electron/electron/contributors","subscribers_url":"https://api.github.com/repos/electron/electron/subscribers","subscription_url":"https://api.github.com/repos/electron/electron/subscription","commits_url":"https://api.github.com/repos/electron/electron/commits{/sha}","git_commits_url":"https://api.github.com/repos/electron/electron/git/commits{/sha}","comments_url":"https://api.github.com/repos/electron/electron/comments{/number}","issue_comment_url":"https://api.github.com/repos/electron/electron/issues/comments{/number}","contents_url":"https://api.github.com/repos/electron/electron/contents/{+path}","compare_url":"https://api.github.com/repos/electron/electron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/electron/electron/merges","archive_url":"https://api.github.com/repos/electron/electron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/electron/electron/downloads","issues_url":"https://api.github.com/repos/electron/electron/issues{/number}","pulls_url":"https://api.github.com/repos/electron/electron/pulls{/number}","milestones_url":"https://api.github.com/repos/electron/electron/milestones{/number}","notifications_url":"https://api.github.com/repos/electron/electron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/electron/electron/labels{/name}","releases_url":"https://api.github.com/repos/electron/electron/releases{/id}","deployments_url":"https://api.github.com/repos/electron/electron/deployments","created_at":"2013-04-12T01:47:36Z","updated_at":"2016-12-02T02:00:53Z","pushed_at":"2016-12-02T02:19:57Z","git_url":"git://github.com/electron/electron.git","ssh_url":"git@github.com:electron/electron.git","clone_url":"https://github.com/electron/electron.git","svn_url":"https://github.com/electron/electron","homepage":"http://electron.atom.io","size":36147,"stargazers_count":38715,"watchers_count":38715,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4533,"mirror_url":null,"open_issues_count":373,"forks":4533,"open_issues":373,"watchers":38715,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/electron/electron/pulls/8109"},"html":{"href":"https://github.com/electron/electron/pull/8109"},"issue":{"href":"https://api.github.com/repos/electron/electron/issues/8109"},"comments":{"href":"https://api.github.com/repos/electron/electron/issues/8109/comments"},"review_comments":{"href":"https://api.github.com/repos/electron/electron/pulls/8109/comments"},"review_comment":{"href":"https://api.github.com/repos/electron/electron/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/electron/electron/pulls/8109/commits"},"statuses":{"href":"https://api.github.com/repos/electron/electron/statuses/8c856c942edcfd5d112bece95365945eff276633"}}}}
{"actor":{"display_login":"ramya-rao-a"}}