{"action":"created","issue":{"url":"https://api.github.com/repos/csete/gqrx/issues/461","repository_url":"https://api.github.com/repos/csete/gqrx","labels_url":"https://api.github.com/repos/csete/gqrx/issues/461/labels{/name}","comments_url":"https://api.github.com/repos/csete/gqrx/issues/461/comments","events_url":"https://api.github.com/repos/csete/gqrx/issues/461/events","html_url":"https://github.com/csete/gqrx/pull/461","id":195346094,"number":461,"title":"Waterfall caching and redrawing","user":{"login":"Cat-Ion","id":443968,"avatar_url":"https://avatars.githubusercontent.com/u/443968?v=3","gravatar_id":"","url":"https://api.github.com/users/Cat-Ion","html_url":"https://github.com/Cat-Ion","followers_url":"https://api.github.com/users/Cat-Ion/followers","following_url":"https://api.github.com/users/Cat-Ion/following{/other_user}","gists_url":"https://api.github.com/users/Cat-Ion/gists{/gist_id}","starred_url":"https://api.github.com/users/Cat-Ion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cat-Ion/subscriptions","organizations_url":"https://api.github.com/users/Cat-Ion/orgs","repos_url":"https://api.github.com/users/Cat-Ion/repos","events_url":"https://api.github.com/users/Cat-Ion/events{/privacy}","received_events_url":"https://api.github.com/users/Cat-Ion/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-12-13T19:31:27Z","updated_at":"2016-12-14T14:59:05Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/csete/gqrx/pulls/461","html_url":"https://github.com/csete/gqrx/pull/461","diff_url":"https://github.com/csete/gqrx/pull/461.diff","patch_url":"https://github.com/csete/gqrx/pull/461.patch"},"body":"I've been doing some work on #393 and it's in a mostly working state. I still don't have a way of limiting used memory right now, but at least the backend part of that should be simple enough. You do get some visual artifacts when moving the waterfall, but that can't be avoided with the 8-bit storage for FFT bins.\r\n\r\nMemory overhead right now is 1 byte per FFT sample, over the height of the waterfall, plus 32 bytes per line.\r\n\r\nI've messed with the plotter class for a bit, mostly by putting draw() into a few smaller functions, and also optimized its drawing function to be much faster, as it was a major bottleneck for the redrawing.\r\n\r\nWhile it probably shouldn't be merged at this stage (still need the max memory stuff), I'd love some feedback and maybe tests by other people."},"comment":{"url":"https://api.github.com/repos/csete/gqrx/issues/comments/267055325","html_url":"https://github.com/csete/gqrx/pull/461#issuecomment-267055325","issue_url":"https://api.github.com/repos/csete/gqrx/issues/461","id":267055325,"user":{"login":"csete","id":306178,"avatar_url":"https://avatars.githubusercontent.com/u/306178?v=3","gravatar_id":"","url":"https://api.github.com/users/csete","html_url":"https://github.com/csete","followers_url":"https://api.github.com/users/csete/followers","following_url":"https://api.github.com/users/csete/following{/other_user}","gists_url":"https://api.github.com/users/csete/gists{/gist_id}","starred_url":"https://api.github.com/users/csete/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csete/subscriptions","organizations_url":"https://api.github.com/users/csete/orgs","repos_url":"https://api.github.com/users/csete/repos","events_url":"https://api.github.com/users/csete/events{/privacy}","received_events_url":"https://api.github.com/users/csete/received_events","type":"User","site_admin":false},"created_at":"2016-12-14T14:59:05Z","updated_at":"2016-12-14T14:59:05Z","body":"Thanks @Cat-Ion -- I will take a look at it, though it'll probably be several weeks before I get a chance. I'm in the middle of moving and my backlog is already very long."}}
{"actor":{"display_login":"csete"}}