{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/pulls/comments/65287446","id":65287446,"diff_hunk":"@@ -0,0 +1,193 @@\n+/*\n+ * Copyright 2016 Google Inc. All Rights Reserved.\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ *       http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+package com.google.apphosting.runtime.jetty9;\n+\n+import java.util.ArrayList;\n+import java.util.Collections;\n+import java.util.Enumeration;\n+import java.util.HashMap;\n+import java.util.List;\n+import java.util.Map;\n+\n+import javax.servlet.ServletContext;\n+import javax.servlet.http.HttpSession;\n+import javax.servlet.http.HttpSessionContext;\n+\n+/**\n+ * A minimal implementation of HttpSession, just sufficient to use attributes within a\n+ * single request.\n+ */\n+public class NoOpSession implements HttpSession {\n+\n+  protected ServletContext context;\n+  protected String clusterId;\n+  protected String nodeId;\n+  protected boolean valid = true;\n+  private final Map<String, Object> attributes = new HashMap<>();\n+\n+  /**\n+   * @param id the identity of the session\n+   * @param nodeId the id of the session qualified with the node workername\n+   * @param context the ServletContext to which the session belongs\n+   */\n+  protected NoOpSession(String id, String nodeId, ServletContext context) {\n+    this.clusterId = id;\n+    this.nodeId = nodeId;\n+    this.context = context;\n+  }\n+\n+  /**\n+   * Finish a request\n+   */\n+  protected void complete() {\n+    attributes.clear();","path":"jetty9-compat-base/src/main/java/com/google/apphosting/runtime/jetty9/NoOpSession.java","position":57,"original_position":57,"commit_id":"928abd8c11fb78984dec03e3afb950efde9cc0cd","original_commit_id":"928abd8c11fb78984dec03e3afb950efde9cc0cd","user":{"login":"aozarov","id":8921691,"avatar_url":"https://avatars.githubusercontent.com/u/8921691?v=3","gravatar_id":"","url":"https://api.github.com/users/aozarov","html_url":"https://github.com/aozarov","followers_url":"https://api.github.com/users/aozarov/followers","following_url":"https://api.github.com/users/aozarov/following{/other_user}","gists_url":"https://api.github.com/users/aozarov/gists{/gist_id}","starred_url":"https://api.github.com/users/aozarov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aozarov/subscriptions","organizations_url":"https://api.github.com/users/aozarov/orgs","repos_url":"https://api.github.com/users/aozarov/repos","events_url":"https://api.github.com/users/aozarov/events{/privacy}","received_events_url":"https://api.github.com/users/aozarov/received_events","type":"User","site_admin":false},"body":"is it safe to call it without synchronized?","created_at":"2016-06-01T00:49:47Z","updated_at":"2016-06-01T00:49:47Z","html_url":"https://github.com/GoogleCloudPlatform/appengine-java-vm-runtime/pull/255#discussion_r65287446","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/pulls/255","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/pulls/comments/65287446"},"html":{"href":"https://github.com/GoogleCloudPlatform/appengine-java-vm-runtime/pull/255#discussion_r65287446"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/pulls/255"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/pulls/255","id":71318885,"html_url":"https://github.com/GoogleCloudPlatform/appengine-java-vm-runtime/pull/255","diff_url":"https://github.com/GoogleCloudPlatform/appengine-java-vm-runtime/pull/255.diff","patch_url":"https://github.com/GoogleCloudPlatform/appengine-java-vm-runtime/pull/255.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/issues/255","number":255,"state":"open","locked":false,"title":"Async support 229","user":{"login":"janbartel","id":342406,"avatar_url":"https://avatars.githubusercontent.com/u/342406?v=3","gravatar_id":"","url":"https://api.github.com/users/janbartel","html_url":"https://github.com/janbartel","followers_url":"https://api.github.com/users/janbartel/followers","following_url":"https://api.github.com/users/janbartel/following{/other_user}","gists_url":"https://api.github.com/users/janbartel/gists{/gist_id}","starred_url":"https://api.github.com/users/janbartel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janbartel/subscriptions","organizations_url":"https://api.github.com/users/janbartel/orgs","repos_url":"https://api.github.com/users/janbartel/repos","events_url":"https://api.github.com/users/janbartel/events{/privacy}","received_events_url":"https://api.github.com/users/janbartel/received_events","type":"User","site_admin":false},"body":"A very minimal session manager for when sessions-enabled=false as per enhancement request #229. ","created_at":"2016-05-25T01:42:39Z","updated_at":"2016-06-01T00:49:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c25d54b18867be6c94be462a5bb23a6fea441290","assignee":{"login":"aozarov","id":8921691,"avatar_url":"https://avatars.githubusercontent.com/u/8921691?v=3","gravatar_id":"","url":"https://api.github.com/users/aozarov","html_url":"https://github.com/aozarov","followers_url":"https://api.github.com/users/aozarov/followers","following_url":"https://api.github.com/users/aozarov/following{/other_user}","gists_url":"https://api.github.com/users/aozarov/gists{/gist_id}","starred_url":"https://api.github.com/users/aozarov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aozarov/subscriptions","organizations_url":"https://api.github.com/users/aozarov/orgs","repos_url":"https://api.github.com/users/aozarov/repos","events_url":"https://api.github.com/users/aozarov/events{/privacy}","received_events_url":"https://api.github.com/users/aozarov/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/pulls/255/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/pulls/255/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/issues/255/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/statuses/928abd8c11fb78984dec03e3afb950efde9cc0cd","head":{"label":"jetty-project:async-support-229","ref":"async-support-229","sha":"928abd8c11fb78984dec03e3afb950efde9cc0cd","user":{"login":"jetty-project","id":903858,"avatar_url":"https://avatars.githubusercontent.com/u/903858?v=3","gravatar_id":"","url":"https://api.github.com/users/jetty-project","html_url":"https://github.com/jetty-project","followers_url":"https://api.github.com/users/jetty-project/followers","following_url":"https://api.github.com/users/jetty-project/following{/other_user}","gists_url":"https://api.github.com/users/jetty-project/gists{/gist_id}","starred_url":"https://api.github.com/users/jetty-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jetty-project/subscriptions","organizations_url":"https://api.github.com/users/jetty-project/orgs","repos_url":"https://api.github.com/users/jetty-project/repos","events_url":"https://api.github.com/users/jetty-project/events{/privacy}","received_events_url":"https://api.github.com/users/jetty-project/received_events","type":"Organization","site_admin":false},"repo":{"id":39987516,"name":"appengine-java-vm-runtime","full_name":"jetty-project/appengine-java-vm-runtime","owner":{"login":"jetty-project","id":903858,"avatar_url":"https://avatars.githubusercontent.com/u/903858?v=3","gravatar_id":"","url":"https://api.github.com/users/jetty-project","html_url":"https://github.com/jetty-project","followers_url":"https://api.github.com/users/jetty-project/followers","following_url":"https://api.github.com/users/jetty-project/following{/other_user}","gists_url":"https://api.github.com/users/jetty-project/gists{/gist_id}","starred_url":"https://api.github.com/users/jetty-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jetty-project/subscriptions","organizations_url":"https://api.github.com/users/jetty-project/orgs","repos_url":"https://api.github.com/users/jetty-project/repos","events_url":"https://api.github.com/users/jetty-project/events{/privacy}","received_events_url":"https://api.github.com/users/jetty-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jetty-project/appengine-java-vm-runtime","description":"","fork":true,"url":"https://api.github.com/repos/jetty-project/appengine-java-vm-runtime","forks_url":"https://api.github.com/repos/jetty-project/appengine-java-vm-runtime/forks","keys_url":"https://api.github.com/repos/jetty-project/appengine-java-vm-runtime/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jetty-project/appengine-java-vm-runtime/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jetty-project/appengine-java-vm-runtime/teams","hooks_url":"https://api.github.com/repos/jetty-project/appengine-java-vm-runtime/hooks","issue_events_url":"https://api.github.com/repos/jetty-project/appengine-java-vm-runtime/issues/events{/number}","events_url":"https://api.github.com/repos/jetty-project/appengine-java-vm-runtime/events","assignees_url":"https://api.github.com/repos/jetty-project/appengine-java-vm-runtime/assignees{/user}","branches_url":"https://api.github.com/repos/jetty-project/appengine-java-vm-runtime/branches{/branch}","tags_url":"https://api.github.com/repos/jetty-project/appengine-java-vm-runtime/tags","blobs_url":"https://api.github.com/repos/jetty-project/appengine-java-vm-runtime/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jetty-project/appengine-java-vm-runtime/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jetty-project/appengine-java-vm-runtime/git/refs{/sha}","trees_url":"https://api.github.com/repos/jetty-project/appengine-java-vm-runtime/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jetty-project/appengine-java-vm-runtime/statuses/{sha}","languages_url":"https://api.github.com/repos/jetty-project/appengine-java-vm-runtime/languages","stargazers_url":"https://api.github.com/repos/jetty-project/appengine-java-vm-runtime/stargazers","contributors_url":"https://api.github.com/repos/jetty-project/appengine-java-vm-runtime/contributors","subscribers_url":"https://api.github.com/repos/jetty-project/appengine-java-vm-runtime/subscribers","subscription_url":"https://api.github.com/repos/jetty-project/appengine-java-vm-runtime/subscription","commits_url":"https://api.github.com/repos/jetty-project/appengine-java-vm-runtime/commits{/sha}","git_commits_url":"https://api.github.com/repos/jetty-project/appengine-java-vm-runtime/git/commits{/sha}","comments_url":"https://api.github.com/repos/jetty-project/appengine-java-vm-runtime/comments{/number}","issue_comment_url":"https://api.github.com/repos/jetty-project/appengine-java-vm-runtime/issues/comments{/number}","contents_url":"https://api.github.com/repos/jetty-project/appengine-java-vm-runtime/contents/{+path}","compare_url":"https://api.github.com/repos/jetty-project/appengine-java-vm-runtime/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jetty-project/appengine-java-vm-runtime/merges","archive_url":"https://api.github.com/repos/jetty-project/appengine-java-vm-runtime/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jetty-project/appengine-java-vm-runtime/downloads","issues_url":"https://api.github.com/repos/jetty-project/appengine-java-vm-runtime/issues{/number}","pulls_url":"https://api.github.com/repos/jetty-project/appengine-java-vm-runtime/pulls{/number}","milestones_url":"https://api.github.com/repos/jetty-project/appengine-java-vm-runtime/milestones{/number}","notifications_url":"https://api.github.com/repos/jetty-project/appengine-java-vm-runtime/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jetty-project/appengine-java-vm-runtime/labels{/name}","releases_url":"https://api.github.com/repos/jetty-project/appengine-java-vm-runtime/releases{/id}","deployments_url":"https://api.github.com/repos/jetty-project/appengine-java-vm-runtime/deployments","created_at":"2015-07-31T05:01:09Z","updated_at":"2016-01-14T03:25:50Z","pushed_at":"2016-05-31T23:58:32Z","git_url":"git://github.com/jetty-project/appengine-java-vm-runtime.git","ssh_url":"git@github.com:jetty-project/appengine-java-vm-runtime.git","clone_url":"https://github.com/jetty-project/appengine-java-vm-runtime.git","svn_url":"https://github.com/jetty-project/appengine-java-vm-runtime","homepage":null,"size":2703,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:async-support","ref":"async-support","sha":"bfadff8ec2fb14f8a390dd5aaf2b73001ebe63b1","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":25889832,"name":"appengine-java-vm-runtime","full_name":"GoogleCloudPlatform/appengine-java-vm-runtime","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/appengine-java-vm-runtime","description":"","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/deployments","created_at":"2014-10-28T20:59:13Z","updated_at":"2016-05-17T19:04:30Z","pushed_at":"2016-05-31T23:58:33Z","git_url":"git://github.com/GoogleCloudPlatform/appengine-java-vm-runtime.git","ssh_url":"git@github.com:GoogleCloudPlatform/appengine-java-vm-runtime.git","clone_url":"https://github.com/GoogleCloudPlatform/appengine-java-vm-runtime.git","svn_url":"https://github.com/GoogleCloudPlatform/appengine-java-vm-runtime","homepage":null,"size":2559,"stargazers_count":45,"watchers_count":45,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"open_issues_count":72,"forks":25,"open_issues":72,"watchers":45,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/pulls/255"},"html":{"href":"https://github.com/GoogleCloudPlatform/appengine-java-vm-runtime/pull/255"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/issues/255"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/issues/255/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/pulls/255/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/pulls/255/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/statuses/928abd8c11fb78984dec03e3afb950efde9cc0cd"}}}}
{"actor":{"display_login":"aozarov"}}