{"action":"created","comment":{"url":"https://api.github.com/repos/daschult/azure-resource-manager-schemas/pulls/comments/65446665","id":65446665,"diff_hunk":"@@ -0,0 +1,40 @@\n+{\n+  \"tests\": [\n+    {\n+      \"name\": \"Publicip tests - minimal resource\",","path":"tests/2016-03-30/Microsoft.Network.PublicIpAddress.tests.json","position":4,"original_position":4,"commit_id":"c1ef4491f01306f9572eb49a12fd8354eee785a7","original_commit_id":"c1ef4491f01306f9572eb49a12fd8354eee785a7","user":{"login":"FrankSiegemund","id":6665143,"avatar_url":"https://avatars.githubusercontent.com/u/6665143?v=3","gravatar_id":"","url":"https://api.github.com/users/FrankSiegemund","html_url":"https://github.com/FrankSiegemund","followers_url":"https://api.github.com/users/FrankSiegemund/followers","following_url":"https://api.github.com/users/FrankSiegemund/following{/other_user}","gists_url":"https://api.github.com/users/FrankSiegemund/gists{/gist_id}","starred_url":"https://api.github.com/users/FrankSiegemund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FrankSiegemund/subscriptions","organizations_url":"https://api.github.com/users/FrankSiegemund/orgs","repos_url":"https://api.github.com/users/FrankSiegemund/repos","events_url":"https://api.github.com/users/FrankSiegemund/events{/privacy}","received_events_url":"https://api.github.com/users/FrankSiegemund/received_events","type":"User","site_admin":false},"body":"Minimal is actually without DNS settings. Can you add one case?","created_at":"2016-06-01T21:30:45Z","updated_at":"2016-06-01T21:30:45Z","html_url":"https://github.com/daschult/azure-resource-manager-schemas/pull/2#discussion_r65446665","pull_request_url":"https://api.github.com/repos/daschult/azure-resource-manager-schemas/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/daschult/azure-resource-manager-schemas/pulls/comments/65446665"},"html":{"href":"https://github.com/daschult/azure-resource-manager-schemas/pull/2#discussion_r65446665"},"pull_request":{"href":"https://api.github.com/repos/daschult/azure-resource-manager-schemas/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/daschult/azure-resource-manager-schemas/pulls/2","id":72117243,"html_url":"https://github.com/daschult/azure-resource-manager-schemas/pull/2","diff_url":"https://github.com/daschult/azure-resource-manager-schemas/pull/2.diff","patch_url":"https://github.com/daschult/azure-resource-manager-schemas/pull/2.patch","issue_url":"https://api.github.com/repos/daschult/azure-resource-manager-schemas/issues/2","number":2,"state":"closed","locked":false,"title":"Add generated network schemas","user":{"login":"DeepakRajendranMsft","id":7852548,"avatar_url":"https://avatars.githubusercontent.com/u/7852548?v=3","gravatar_id":"","url":"https://api.github.com/users/DeepakRajendranMsft","html_url":"https://github.com/DeepakRajendranMsft","followers_url":"https://api.github.com/users/DeepakRajendranMsft/followers","following_url":"https://api.github.com/users/DeepakRajendranMsft/following{/other_user}","gists_url":"https://api.github.com/users/DeepakRajendranMsft/gists{/gist_id}","starred_url":"https://api.github.com/users/DeepakRajendranMsft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DeepakRajendranMsft/subscriptions","organizations_url":"https://api.github.com/users/DeepakRajendranMsft/orgs","repos_url":"https://api.github.com/users/DeepakRajendranMsft/repos","events_url":"https://api.github.com/users/DeepakRajendranMsft/events{/privacy}","received_events_url":"https://api.github.com/users/DeepakRajendranMsft/received_events","type":"User","site_admin":false},"body":"Added network tests.\r\n\r\nThere seems to be something wrong with subnet and pubicip reference tests. There are 10 tests which fail, especially nic tests. these tests succeeded in the existing schema, not sure what is wrong with the generated schema. Other than these failures, it looks good to me. (there is one test which fails with the same error in the existing schema - \"virtal network tests - routetable and nsg resource\")\r\n\r\nIf we can figure out these test failures, we are good to checkin the schema\r\n\r\n  Running test \"nic tests - only subnet\"\r\nError: tv4ValidationResult should not have had any empty missing schemas: [\r\n  \"\",\r\n  \"\"\r\n]\r\nExpected: \"not empty\"\r\nActual:   \"\"\r\n    at Fail (F:\\git\\Azure\\azure-resource-manager-schemas\\tools\\assert.js:10:9)\r\n    at Object.NotEmpty (F:\\git\\Azure\\azure-resource-manager-schemas\\tools\\assert.js:51:5)\r\n    at convertTv4ValidationResult (F:\\git\\Azure\\azure-resource-manager-schemas\\tools\\validateJSON.js\r\n:108:12)\r\n    at Object.validate (F:\\git\\Azure\\azure-resource-manager-schemas\\tools\\validateJSON.js:93:18)\r\n    at F:\\git\\Azure\\azure-resource-manager-schemas\\tools\\runSchemaTests.js:50:30\r\n    at Object.run (F:\\git\\Azure\\azure-resource-manager-schemas\\tools\\test.js:9:5)\r\n    at Object.<anonymous> (F:\\git\\Azure\\azure-resource-manager-schemas\\tools\\runSchemaTests.js:32:10\r\n)\r\n    at Module._compile (module.js:409:26)\r\n    at Object.Module._extensions..js (module.js:416:10)\r\n    at Module.load (module.js:343:32)\r\n  Running test \"nic tests - subnet and publicipAddress\"\r\nError: tv4ValidationResult should not have had any empty missing schemas: [\r\n  \"\",\r\n  \"\"\r\n]\r\nExpected: \"not empty\"\r\nActual:   \"\"\r\n    at Fail (F:\\git\\Azure\\azure-resource-manager-schemas\\tools\\assert.js:10:9)\r\n    at Object.NotEmpty (F:\\git\\Azure\\azure-resource-manager-schemas\\tools\\assert.js:51:5)\r\n    at convertTv4ValidationResult (F:\\git\\Azure\\azure-resource-manager-schemas\\tools\\validateJSON.js\r\n:108:12)\r\n    at Object.validate (F:\\git\\Azure\\azure-resource-manager-schemas\\tools\\validateJSON.js:93:18)\r\n    at F:\\git\\Azure\\azure-resource-manager-schemas\\tools\\runSchemaTests.js:50:30\r\n    at Object.run (F:\\git\\Azure\\azure-resource-manager-schemas\\tools\\test.js:9:5)\r\n    at Object.<anonymous> (F:\\git\\Azure\\azure-resource-manager-schemas\\tools\\runSchemaTests.js:32:10\r\n)\r\n    at Module._compile (module.js:409:26)\r\n    at Object.Module._extensions..js (module.js:416:10)\r\n    at Module.load (module.js:343:32)","created_at":"2016-06-01T03:17:49Z","updated_at":"2016-06-01T21:30:45Z","closed_at":"2016-06-01T18:48:56Z","merged_at":"2016-06-01T18:48:56Z","merge_commit_sha":"7f23b021294c43facbc6b35dc4712719638aeae0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/daschult/azure-resource-manager-schemas/pulls/2/commits","review_comments_url":"https://api.github.com/repos/daschult/azure-resource-manager-schemas/pulls/2/comments","review_comment_url":"https://api.github.com/repos/daschult/azure-resource-manager-schemas/pulls/comments{/number}","comments_url":"https://api.github.com/repos/daschult/azure-resource-manager-schemas/issues/2/comments","statuses_url":"https://api.github.com/repos/daschult/azure-resource-manager-schemas/statuses/c1ef4491f01306f9572eb49a12fd8354eee785a7","head":{"label":"DeepakRajendranMsft:AddGeneratedNetworkSchemas","ref":"AddGeneratedNetworkSchemas","sha":"c1ef4491f01306f9572eb49a12fd8354eee785a7","user":{"login":"DeepakRajendranMsft","id":7852548,"avatar_url":"https://avatars.githubusercontent.com/u/7852548?v=3","gravatar_id":"","url":"https://api.github.com/users/DeepakRajendranMsft","html_url":"https://github.com/DeepakRajendranMsft","followers_url":"https://api.github.com/users/DeepakRajendranMsft/followers","following_url":"https://api.github.com/users/DeepakRajendranMsft/following{/other_user}","gists_url":"https://api.github.com/users/DeepakRajendranMsft/gists{/gist_id}","starred_url":"https://api.github.com/users/DeepakRajendranMsft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DeepakRajendranMsft/subscriptions","organizations_url":"https://api.github.com/users/DeepakRajendranMsft/orgs","repos_url":"https://api.github.com/users/DeepakRajendranMsft/repos","events_url":"https://api.github.com/users/DeepakRajendranMsft/events{/privacy}","received_events_url":"https://api.github.com/users/DeepakRajendranMsft/received_events","type":"User","site_admin":false},"repo":{"id":55009760,"name":"azure-resource-manager-schemas","full_name":"DeepakRajendranMsft/azure-resource-manager-schemas","owner":{"login":"DeepakRajendranMsft","id":7852548,"avatar_url":"https://avatars.githubusercontent.com/u/7852548?v=3","gravatar_id":"","url":"https://api.github.com/users/DeepakRajendranMsft","html_url":"https://github.com/DeepakRajendranMsft","followers_url":"https://api.github.com/users/DeepakRajendranMsft/followers","following_url":"https://api.github.com/users/DeepakRajendranMsft/following{/other_user}","gists_url":"https://api.github.com/users/DeepakRajendranMsft/gists{/gist_id}","starred_url":"https://api.github.com/users/DeepakRajendranMsft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DeepakRajendranMsft/subscriptions","organizations_url":"https://api.github.com/users/DeepakRajendranMsft/orgs","repos_url":"https://api.github.com/users/DeepakRajendranMsft/repos","events_url":"https://api.github.com/users/DeepakRajendranMsft/events{/privacy}","received_events_url":"https://api.github.com/users/DeepakRajendranMsft/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DeepakRajendranMsft/azure-resource-manager-schemas","description":"Schemas used to author and validate Resource Manager Templates","fork":true,"url":"https://api.github.com/repos/DeepakRajendranMsft/azure-resource-manager-schemas","forks_url":"https://api.github.com/repos/DeepakRajendranMsft/azure-resource-manager-schemas/forks","keys_url":"https://api.github.com/repos/DeepakRajendranMsft/azure-resource-manager-schemas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DeepakRajendranMsft/azure-resource-manager-schemas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DeepakRajendranMsft/azure-resource-manager-schemas/teams","hooks_url":"https://api.github.com/repos/DeepakRajendranMsft/azure-resource-manager-schemas/hooks","issue_events_url":"https://api.github.com/repos/DeepakRajendranMsft/azure-resource-manager-schemas/issues/events{/number}","events_url":"https://api.github.com/repos/DeepakRajendranMsft/azure-resource-manager-schemas/events","assignees_url":"https://api.github.com/repos/DeepakRajendranMsft/azure-resource-manager-schemas/assignees{/user}","branches_url":"https://api.github.com/repos/DeepakRajendranMsft/azure-resource-manager-schemas/branches{/branch}","tags_url":"https://api.github.com/repos/DeepakRajendranMsft/azure-resource-manager-schemas/tags","blobs_url":"https://api.github.com/repos/DeepakRajendranMsft/azure-resource-manager-schemas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DeepakRajendranMsft/azure-resource-manager-schemas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DeepakRajendranMsft/azure-resource-manager-schemas/git/refs{/sha}","trees_url":"https://api.github.com/repos/DeepakRajendranMsft/azure-resource-manager-schemas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DeepakRajendranMsft/azure-resource-manager-schemas/statuses/{sha}","languages_url":"https://api.github.com/repos/DeepakRajendranMsft/azure-resource-manager-schemas/languages","stargazers_url":"https://api.github.com/repos/DeepakRajendranMsft/azure-resource-manager-schemas/stargazers","contributors_url":"https://api.github.com/repos/DeepakRajendranMsft/azure-resource-manager-schemas/contributors","subscribers_url":"https://api.github.com/repos/DeepakRajendranMsft/azure-resource-manager-schemas/subscribers","subscription_url":"https://api.github.com/repos/DeepakRajendranMsft/azure-resource-manager-schemas/subscription","commits_url":"https://api.github.com/repos/DeepakRajendranMsft/azure-resource-manager-schemas/commits{/sha}","git_commits_url":"https://api.github.com/repos/DeepakRajendranMsft/azure-resource-manager-schemas/git/commits{/sha}","comments_url":"https://api.github.com/repos/DeepakRajendranMsft/azure-resource-manager-schemas/comments{/number}","issue_comment_url":"https://api.github.com/repos/DeepakRajendranMsft/azure-resource-manager-schemas/issues/comments{/number}","contents_url":"https://api.github.com/repos/DeepakRajendranMsft/azure-resource-manager-schemas/contents/{+path}","compare_url":"https://api.github.com/repos/DeepakRajendranMsft/azure-resource-manager-schemas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DeepakRajendranMsft/azure-resource-manager-schemas/merges","archive_url":"https://api.github.com/repos/DeepakRajendranMsft/azure-resource-manager-schemas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DeepakRajendranMsft/azure-resource-manager-schemas/downloads","issues_url":"https://api.github.com/repos/DeepakRajendranMsft/azure-resource-manager-schemas/issues{/number}","pulls_url":"https://api.github.com/repos/DeepakRajendranMsft/azure-resource-manager-schemas/pulls{/number}","milestones_url":"https://api.github.com/repos/DeepakRajendranMsft/azure-resource-manager-schemas/milestones{/number}","notifications_url":"https://api.github.com/repos/DeepakRajendranMsft/azure-resource-manager-schemas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DeepakRajendranMsft/azure-resource-manager-schemas/labels{/name}","releases_url":"https://api.github.com/repos/DeepakRajendranMsft/azure-resource-manager-schemas/releases{/id}","deployments_url":"https://api.github.com/repos/DeepakRajendranMsft/azure-resource-manager-schemas/deployments","created_at":"2016-03-29T20:53:25Z","updated_at":"2016-03-25T20:28:55Z","pushed_at":"2016-06-01T03:08:15Z","git_url":"git://github.com/DeepakRajendranMsft/azure-resource-manager-schemas.git","ssh_url":"git@github.com:DeepakRajendranMsft/azure-resource-manager-schemas.git","clone_url":"https://github.com/DeepakRajendranMsft/azure-resource-manager-schemas.git","svn_url":"https://github.com/DeepakRajendranMsft/azure-resource-manager-schemas","homepage":null,"size":602,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"daschult:AddGeneratedNetworkSchemas","ref":"AddGeneratedNetworkSchemas","sha":"5f31be9f7f5bafdf6fb93d87d0bbaa1db42cfba7","user":{"login":"daschult","id":7052303,"avatar_url":"https://avatars.githubusercontent.com/u/7052303?v=3","gravatar_id":"","url":"https://api.github.com/users/daschult","html_url":"https://github.com/daschult","followers_url":"https://api.github.com/users/daschult/followers","following_url":"https://api.github.com/users/daschult/following{/other_user}","gists_url":"https://api.github.com/users/daschult/gists{/gist_id}","starred_url":"https://api.github.com/users/daschult/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daschult/subscriptions","organizations_url":"https://api.github.com/users/daschult/orgs","repos_url":"https://api.github.com/users/daschult/repos","events_url":"https://api.github.com/users/daschult/events{/privacy}","received_events_url":"https://api.github.com/users/daschult/received_events","type":"User","site_admin":false},"repo":{"id":43024927,"name":"azure-resource-manager-schemas","full_name":"daschult/azure-resource-manager-schemas","owner":{"login":"daschult","id":7052303,"avatar_url":"https://avatars.githubusercontent.com/u/7052303?v=3","gravatar_id":"","url":"https://api.github.com/users/daschult","html_url":"https://github.com/daschult","followers_url":"https://api.github.com/users/daschult/followers","following_url":"https://api.github.com/users/daschult/following{/other_user}","gists_url":"https://api.github.com/users/daschult/gists{/gist_id}","starred_url":"https://api.github.com/users/daschult/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daschult/subscriptions","organizations_url":"https://api.github.com/users/daschult/orgs","repos_url":"https://api.github.com/users/daschult/repos","events_url":"https://api.github.com/users/daschult/events{/privacy}","received_events_url":"https://api.github.com/users/daschult/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/daschult/azure-resource-manager-schemas","description":"Schemas used to author and validate Resource Manager Templates","fork":true,"url":"https://api.github.com/repos/daschult/azure-resource-manager-schemas","forks_url":"https://api.github.com/repos/daschult/azure-resource-manager-schemas/forks","keys_url":"https://api.github.com/repos/daschult/azure-resource-manager-schemas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/daschult/azure-resource-manager-schemas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/daschult/azure-resource-manager-schemas/teams","hooks_url":"https://api.github.com/repos/daschult/azure-resource-manager-schemas/hooks","issue_events_url":"https://api.github.com/repos/daschult/azure-resource-manager-schemas/issues/events{/number}","events_url":"https://api.github.com/repos/daschult/azure-resource-manager-schemas/events","assignees_url":"https://api.github.com/repos/daschult/azure-resource-manager-schemas/assignees{/user}","branches_url":"https://api.github.com/repos/daschult/azure-resource-manager-schemas/branches{/branch}","tags_url":"https://api.github.com/repos/daschult/azure-resource-manager-schemas/tags","blobs_url":"https://api.github.com/repos/daschult/azure-resource-manager-schemas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/daschult/azure-resource-manager-schemas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/daschult/azure-resource-manager-schemas/git/refs{/sha}","trees_url":"https://api.github.com/repos/daschult/azure-resource-manager-schemas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/daschult/azure-resource-manager-schemas/statuses/{sha}","languages_url":"https://api.github.com/repos/daschult/azure-resource-manager-schemas/languages","stargazers_url":"https://api.github.com/repos/daschult/azure-resource-manager-schemas/stargazers","contributors_url":"https://api.github.com/repos/daschult/azure-resource-manager-schemas/contributors","subscribers_url":"https://api.github.com/repos/daschult/azure-resource-manager-schemas/subscribers","subscription_url":"https://api.github.com/repos/daschult/azure-resource-manager-schemas/subscription","commits_url":"https://api.github.com/repos/daschult/azure-resource-manager-schemas/commits{/sha}","git_commits_url":"https://api.github.com/repos/daschult/azure-resource-manager-schemas/git/commits{/sha}","comments_url":"https://api.github.com/repos/daschult/azure-resource-manager-schemas/comments{/number}","issue_comment_url":"https://api.github.com/repos/daschult/azure-resource-manager-schemas/issues/comments{/number}","contents_url":"https://api.github.com/repos/daschult/azure-resource-manager-schemas/contents/{+path}","compare_url":"https://api.github.com/repos/daschult/azure-resource-manager-schemas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/daschult/azure-resource-manager-schemas/merges","archive_url":"https://api.github.com/repos/daschult/azure-resource-manager-schemas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/daschult/azure-resource-manager-schemas/downloads","issues_url":"https://api.github.com/repos/daschult/azure-resource-manager-schemas/issues{/number}","pulls_url":"https://api.github.com/repos/daschult/azure-resource-manager-schemas/pulls{/number}","milestones_url":"https://api.github.com/repos/daschult/azure-resource-manager-schemas/milestones{/number}","notifications_url":"https://api.github.com/repos/daschult/azure-resource-manager-schemas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/daschult/azure-resource-manager-schemas/labels{/name}","releases_url":"https://api.github.com/repos/daschult/azure-resource-manager-schemas/releases{/id}","deployments_url":"https://api.github.com/repos/daschult/azure-resource-manager-schemas/deployments","created_at":"2015-09-23T20:27:13Z","updated_at":"2016-01-27T18:36:37Z","pushed_at":"2016-06-01T18:48:56Z","git_url":"git://github.com/daschult/azure-resource-manager-schemas.git","ssh_url":"git@github.com:daschult/azure-resource-manager-schemas.git","clone_url":"https://github.com/daschult/azure-resource-manager-schemas.git","svn_url":"https://github.com/daschult/azure-resource-manager-schemas","homepage":null,"size":615,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/daschult/azure-resource-manager-schemas/pulls/2"},"html":{"href":"https://github.com/daschult/azure-resource-manager-schemas/pull/2"},"issue":{"href":"https://api.github.com/repos/daschult/azure-resource-manager-schemas/issues/2"},"comments":{"href":"https://api.github.com/repos/daschult/azure-resource-manager-schemas/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/daschult/azure-resource-manager-schemas/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/daschult/azure-resource-manager-schemas/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/daschult/azure-resource-manager-schemas/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/daschult/azure-resource-manager-schemas/statuses/c1ef4491f01306f9572eb49a12fd8354eee785a7"}}}}
{"actor":{"display_login":"FrankSiegemund"}}