{"action":"closed","number":2184,"pull_request":{"url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/pulls/2184","id":79063446,"html_url":"https://github.com/SalesforceFoundation/Cumulus/pull/2184","diff_url":"https://github.com/SalesforceFoundation/Cumulus/pull/2184.diff","patch_url":"https://github.com/SalesforceFoundation/Cumulus/pull/2184.patch","issue_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/issues/2184","number":2184,"state":"closed","locked":false,"title":"Convert setting to use record type ids instead of names","user":{"login":"dospromptman","id":1058323,"avatar_url":"https://avatars.githubusercontent.com/u/1058323?v=3","gravatar_id":"","url":"https://api.github.com/users/dospromptman","html_url":"https://github.com/dospromptman","followers_url":"https://api.github.com/users/dospromptman/followers","following_url":"https://api.github.com/users/dospromptman/following{/other_user}","gists_url":"https://api.github.com/users/dospromptman/gists{/gist_id}","starred_url":"https://api.github.com/users/dospromptman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dospromptman/subscriptions","organizations_url":"https://api.github.com/users/dospromptman/orgs","repos_url":"https://api.github.com/users/dospromptman/repos","events_url":"https://api.github.com/users/dospromptman/events{/privacy}","received_events_url":"https://api.github.com/users/dospromptman/received_events","type":"User","site_admin":false},"body":"Modify the following custom settings to store record type id, instead of record type name.  This requires changing how the settings are stored (the various STG_Panel* pages and controllers), as well as every location where they are referenced (so that the referencing code expects to receive record type ids instead of names):\r\n\r\nAllocations_Settings__c.Excluded_Opp_RecTypes__c\r\nnpe01__Contacts_And_Orgs_Settings__c.Opp_RecTypes_Excluded_for_Payments__c\r\nnpo02__Households_Settings__c.npo02__Household_Creation_Excluded_Recordtypes__c\r\nnpo02__Households_Settings__c.npo02__Household_OCR_Excluded_Recordtypes__c\r\nnpo02__Households_Settings__c.npo02__Membership_Record_Types__c\r\nnpo02__Households_Settings__c.npo02__Excluded_Account_Opp_Rectypes__c\r\nnpo02__Households_Settings__c.npo02__Excluded_Contact_Opp_Rectypes__c\r\nOpportunity_Naming_Settings__c.Opportunity_Record_Types__c\r\n\r\nThis change is required to allow for localization of record type names in orgs where multiple languages are in use.  Since the record type name was being stored and then converted back to a record type id at runtime, that runtime conversion could fail if the language of the running user differs from the language that the record type names were stored in.  Storing these values as record type id allows NPSP to operate independently of the language of the running user or administrator. See #1693 for more details.\r\n\r\n# Warning\r\n\r\nThis release updates the format in which some NPSP settings are stored, in order to enable organizations with multiple languages to use translated Record Type names.  The following settings have been updated:\r\n\r\n* NPSP Settings > People > Households > Household Object > Household Creation Excluded Record Types\r\n* NPSP Settings > Donations > Opportunity Names > Opportunity Record Types\r\n* NPSP Settings > Donations > Membership > Membership Record Type Names\r\n* NPSP Settings > Donations > Payments > Excluded Opp Record Types\r\n* NPSP Settings > Donations > GAU Allocations > Excluded Opp RecTypes\r\n* NPSP Settings > Donations > Donor Statistics > Opportunity Rollup Record Types > Opp RecTypes Excluded for Account Rollup\r\n* NPSP Settings > Donations > Donor Statistics > Opportunity Rollup Record Types > Opp RecTypes Excluded for Contact Rollup\r\n* NPSP Settings > Donations > Contact Roles > Household Opportunity Contact Roles > Household OCR Excluded Record Types\r\n\r\n Please review these settings on the NPSP Settings page.\r\n\r\n# Info\r\n\r\n# Issues\r\n\r\nFixes #1693 ","created_at":"2016-07-27T17:21:26Z","updated_at":"2016-08-10T23:52:18Z","closed_at":"2016-08-10T23:52:17Z","merged_at":"2016-08-10T23:52:17Z","merge_commit_sha":"d2ad9c7770576afec4b642434c232dcd38d5dc08","assignee":{"login":"njjc","id":1018198,"avatar_url":"https://avatars.githubusercontent.com/u/1018198?v=3","gravatar_id":"","url":"https://api.github.com/users/njjc","html_url":"https://github.com/njjc","followers_url":"https://api.github.com/users/njjc/followers","following_url":"https://api.github.com/users/njjc/following{/other_user}","gists_url":"https://api.github.com/users/njjc/gists{/gist_id}","starred_url":"https://api.github.com/users/njjc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/njjc/subscriptions","organizations_url":"https://api.github.com/users/njjc/orgs","repos_url":"https://api.github.com/users/njjc/repos","events_url":"https://api.github.com/users/njjc/events{/privacy}","received_events_url":"https://api.github.com/users/njjc/received_events","type":"User","site_admin":false},"assignees":[{"login":"njjc","id":1018198,"avatar_url":"https://avatars.githubusercontent.com/u/1018198?v=3","gravatar_id":"","url":"https://api.github.com/users/njjc","html_url":"https://github.com/njjc","followers_url":"https://api.github.com/users/njjc/followers","following_url":"https://api.github.com/users/njjc/following{/other_user}","gists_url":"https://api.github.com/users/njjc/gists{/gist_id}","starred_url":"https://api.github.com/users/njjc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/njjc/subscriptions","organizations_url":"https://api.github.com/users/njjc/orgs","repos_url":"https://api.github.com/users/njjc/repos","events_url":"https://api.github.com/users/njjc/events{/privacy}","received_events_url":"https://api.github.com/users/njjc/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/pulls/2184/commits","review_comments_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/pulls/2184/comments","review_comment_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/issues/2184/comments","statuses_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/statuses/ed49b89ab0b58c7ff067211f810da94548188aa7","head":{"label":"SalesforceFoundation:feature/1693-jbury-multi-language-record-types","ref":"feature/1693-jbury-multi-language-record-types","sha":"ed49b89ab0b58c7ff067211f810da94548188aa7","user":{"login":"SalesforceFoundation","id":972305,"avatar_url":"https://avatars.githubusercontent.com/u/972305?v=3","gravatar_id":"","url":"https://api.github.com/users/SalesforceFoundation","html_url":"https://github.com/SalesforceFoundation","followers_url":"https://api.github.com/users/SalesforceFoundation/followers","following_url":"https://api.github.com/users/SalesforceFoundation/following{/other_user}","gists_url":"https://api.github.com/users/SalesforceFoundation/gists{/gist_id}","starred_url":"https://api.github.com/users/SalesforceFoundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SalesforceFoundation/subscriptions","organizations_url":"https://api.github.com/users/SalesforceFoundation/orgs","repos_url":"https://api.github.com/users/SalesforceFoundation/repos","events_url":"https://api.github.com/users/SalesforceFoundation/events{/privacy}","received_events_url":"https://api.github.com/users/SalesforceFoundation/received_events","type":"Organization","site_admin":false},"repo":{"id":13108586,"name":"Cumulus","full_name":"SalesforceFoundation/Cumulus","owner":{"login":"SalesforceFoundation","id":972305,"avatar_url":"https://avatars.githubusercontent.com/u/972305?v=3","gravatar_id":"","url":"https://api.github.com/users/SalesforceFoundation","html_url":"https://github.com/SalesforceFoundation","followers_url":"https://api.github.com/users/SalesforceFoundation/followers","following_url":"https://api.github.com/users/SalesforceFoundation/following{/other_user}","gists_url":"https://api.github.com/users/SalesforceFoundation/gists{/gist_id}","starred_url":"https://api.github.com/users/SalesforceFoundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SalesforceFoundation/subscriptions","organizations_url":"https://api.github.com/users/SalesforceFoundation/orgs","repos_url":"https://api.github.com/users/SalesforceFoundation/repos","events_url":"https://api.github.com/users/SalesforceFoundation/events{/privacy}","received_events_url":"https://api.github.com/users/SalesforceFoundation/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SalesforceFoundation/Cumulus","description":"The current version of the Salesforce.org Nonprofit Starter Pack","fork":false,"url":"https://api.github.com/repos/SalesforceFoundation/Cumulus","forks_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/forks","keys_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/teams","hooks_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/hooks","issue_events_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/issues/events{/number}","events_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/events","assignees_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/assignees{/user}","branches_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/branches{/branch}","tags_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/tags","blobs_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/git/refs{/sha}","trees_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/statuses/{sha}","languages_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/languages","stargazers_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/stargazers","contributors_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/contributors","subscribers_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/subscribers","subscription_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/subscription","commits_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/commits{/sha}","git_commits_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/git/commits{/sha}","comments_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/comments{/number}","issue_comment_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/issues/comments{/number}","contents_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/contents/{+path}","compare_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/merges","archive_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/downloads","issues_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/issues{/number}","pulls_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/pulls{/number}","milestones_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/milestones{/number}","notifications_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/labels{/name}","releases_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/releases{/id}","deployments_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/deployments","created_at":"2013-09-25T23:56:49Z","updated_at":"2016-08-06T14:20:09Z","pushed_at":"2016-08-10T23:52:17Z","git_url":"git://github.com/SalesforceFoundation/Cumulus.git","ssh_url":"git@github.com:SalesforceFoundation/Cumulus.git","clone_url":"https://github.com/SalesforceFoundation/Cumulus.git","svn_url":"https://github.com/SalesforceFoundation/Cumulus","homepage":"http://www.salesforce.org/help/nonprofitstarterpack","size":62834,"stargazers_count":128,"watchers_count":128,"language":"Apex","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":114,"mirror_url":null,"open_issues_count":271,"forks":114,"open_issues":271,"watchers":128,"default_branch":"dev"}},"base":{"label":"SalesforceFoundation:dev","ref":"dev","sha":"b6ecbbe04a901aaad3f8c046451f4cefde7892c9","user":{"login":"SalesforceFoundation","id":972305,"avatar_url":"https://avatars.githubusercontent.com/u/972305?v=3","gravatar_id":"","url":"https://api.github.com/users/SalesforceFoundation","html_url":"https://github.com/SalesforceFoundation","followers_url":"https://api.github.com/users/SalesforceFoundation/followers","following_url":"https://api.github.com/users/SalesforceFoundation/following{/other_user}","gists_url":"https://api.github.com/users/SalesforceFoundation/gists{/gist_id}","starred_url":"https://api.github.com/users/SalesforceFoundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SalesforceFoundation/subscriptions","organizations_url":"https://api.github.com/users/SalesforceFoundation/orgs","repos_url":"https://api.github.com/users/SalesforceFoundation/repos","events_url":"https://api.github.com/users/SalesforceFoundation/events{/privacy}","received_events_url":"https://api.github.com/users/SalesforceFoundation/received_events","type":"Organization","site_admin":false},"repo":{"id":13108586,"name":"Cumulus","full_name":"SalesforceFoundation/Cumulus","owner":{"login":"SalesforceFoundation","id":972305,"avatar_url":"https://avatars.githubusercontent.com/u/972305?v=3","gravatar_id":"","url":"https://api.github.com/users/SalesforceFoundation","html_url":"https://github.com/SalesforceFoundation","followers_url":"https://api.github.com/users/SalesforceFoundation/followers","following_url":"https://api.github.com/users/SalesforceFoundation/following{/other_user}","gists_url":"https://api.github.com/users/SalesforceFoundation/gists{/gist_id}","starred_url":"https://api.github.com/users/SalesforceFoundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SalesforceFoundation/subscriptions","organizations_url":"https://api.github.com/users/SalesforceFoundation/orgs","repos_url":"https://api.github.com/users/SalesforceFoundation/repos","events_url":"https://api.github.com/users/SalesforceFoundation/events{/privacy}","received_events_url":"https://api.github.com/users/SalesforceFoundation/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SalesforceFoundation/Cumulus","description":"The current version of the Salesforce.org Nonprofit Starter Pack","fork":false,"url":"https://api.github.com/repos/SalesforceFoundation/Cumulus","forks_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/forks","keys_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/teams","hooks_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/hooks","issue_events_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/issues/events{/number}","events_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/events","assignees_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/assignees{/user}","branches_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/branches{/branch}","tags_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/tags","blobs_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/git/refs{/sha}","trees_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/statuses/{sha}","languages_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/languages","stargazers_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/stargazers","contributors_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/contributors","subscribers_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/subscribers","subscription_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/subscription","commits_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/commits{/sha}","git_commits_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/git/commits{/sha}","comments_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/comments{/number}","issue_comment_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/issues/comments{/number}","contents_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/contents/{+path}","compare_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/merges","archive_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/downloads","issues_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/issues{/number}","pulls_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/pulls{/number}","milestones_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/milestones{/number}","notifications_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/labels{/name}","releases_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/releases{/id}","deployments_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/deployments","created_at":"2013-09-25T23:56:49Z","updated_at":"2016-08-06T14:20:09Z","pushed_at":"2016-08-10T23:52:17Z","git_url":"git://github.com/SalesforceFoundation/Cumulus.git","ssh_url":"git@github.com:SalesforceFoundation/Cumulus.git","clone_url":"https://github.com/SalesforceFoundation/Cumulus.git","svn_url":"https://github.com/SalesforceFoundation/Cumulus","homepage":"http://www.salesforce.org/help/nonprofitstarterpack","size":62834,"stargazers_count":128,"watchers_count":128,"language":"Apex","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":114,"mirror_url":null,"open_issues_count":271,"forks":114,"open_issues":271,"watchers":128,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/SalesforceFoundation/Cumulus/pulls/2184"},"html":{"href":"https://github.com/SalesforceFoundation/Cumulus/pull/2184"},"issue":{"href":"https://api.github.com/repos/SalesforceFoundation/Cumulus/issues/2184"},"comments":{"href":"https://api.github.com/repos/SalesforceFoundation/Cumulus/issues/2184/comments"},"review_comments":{"href":"https://api.github.com/repos/SalesforceFoundation/Cumulus/pulls/2184/comments"},"review_comment":{"href":"https://api.github.com/repos/SalesforceFoundation/Cumulus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SalesforceFoundation/Cumulus/pulls/2184/commits"},"statuses":{"href":"https://api.github.com/repos/SalesforceFoundation/Cumulus/statuses/ed49b89ab0b58c7ff067211f810da94548188aa7"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"njjc","id":1018198,"avatar_url":"https://avatars.githubusercontent.com/u/1018198?v=3","gravatar_id":"","url":"https://api.github.com/users/njjc","html_url":"https://github.com/njjc","followers_url":"https://api.github.com/users/njjc/followers","following_url":"https://api.github.com/users/njjc/following{/other_user}","gists_url":"https://api.github.com/users/njjc/gists{/gist_id}","starred_url":"https://api.github.com/users/njjc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/njjc/subscriptions","organizations_url":"https://api.github.com/users/njjc/orgs","repos_url":"https://api.github.com/users/njjc/repos","events_url":"https://api.github.com/users/njjc/events{/privacy}","received_events_url":"https://api.github.com/users/njjc/received_events","type":"User","site_admin":false},"comments":8,"review_comments":0,"commits":9,"additions":1136,"deletions":156,"changed_files":38}}
{"actor":{"display_login":"njjc"}}