{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/71193899","id":71193899,"diff_hunk":"@@ -105,11 +105,14 @@ private[mesos] object MesosSchedulerBackendUtil extends Logging {\n   def addDockerInfo(\n       container: ContainerInfo.Builder,\n       image: String,\n+      forcePullImage: Boolean = false,\n       volumes: Option[List[Volume]] = None,\n       network: Option[ContainerInfo.DockerInfo.Network] = None,","path":"core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerBackendUtil.scala","position":14,"original_position":6,"commit_id":"36b32584bcd8197ecb8e6b8d92954270c735a62f","original_commit_id":"c2d4b7f3d6db53375eebd30d660a9508cfb76b3b","user":{"login":"mgummelt","id":153734,"avatar_url":"https://avatars.githubusercontent.com/u/153734?v=3","gravatar_id":"","url":"https://api.github.com/users/mgummelt","html_url":"https://github.com/mgummelt","followers_url":"https://api.github.com/users/mgummelt/followers","following_url":"https://api.github.com/users/mgummelt/following{/other_user}","gists_url":"https://api.github.com/users/mgummelt/gists{/gist_id}","starred_url":"https://api.github.com/users/mgummelt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgummelt/subscriptions","organizations_url":"https://api.github.com/users/mgummelt/orgs","repos_url":"https://api.github.com/users/mgummelt/repos","events_url":"https://api.github.com/users/mgummelt/events{/privacy}","received_events_url":"https://api.github.com/users/mgummelt/received_events","type":"User","site_admin":false},"body":"Yea, I'm not sure what happened here.  Thanks for pointing it out.  ","created_at":"2016-07-18T17:44:55Z","updated_at":"2016-07-18T17:44:55Z","html_url":"https://github.com/apache/spark/pull/13051#discussion_r71193899","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/13051","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/71193899"},"html":{"href":"https://github.com/apache/spark/pull/13051#discussion_r71193899"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/13051"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/13051","id":69683700,"html_url":"https://github.com/apache/spark/pull/13051","diff_url":"https://github.com/apache/spark/pull/13051.diff","patch_url":"https://github.com/apache/spark/pull/13051.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/13051","number":13051,"state":"open","locked":false,"title":"[SPARK-15271] [MESOS] Allow force pulling executor docker images","user":{"login":"philipphoffmann","id":1279634,"avatar_url":"https://avatars.githubusercontent.com/u/1279634?v=3","gravatar_id":"","url":"https://api.github.com/users/philipphoffmann","html_url":"https://github.com/philipphoffmann","followers_url":"https://api.github.com/users/philipphoffmann/followers","following_url":"https://api.github.com/users/philipphoffmann/following{/other_user}","gists_url":"https://api.github.com/users/philipphoffmann/gists{/gist_id}","starred_url":"https://api.github.com/users/philipphoffmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philipphoffmann/subscriptions","organizations_url":"https://api.github.com/users/philipphoffmann/orgs","repos_url":"https://api.github.com/users/philipphoffmann/repos","events_url":"https://api.github.com/users/philipphoffmann/events{/privacy}","received_events_url":"https://api.github.com/users/philipphoffmann/received_events","type":"User","site_admin":false},"body":"## What changes were proposed in this pull request?\r\n\r\nMesos agents by default will not pull docker images which are cached\r\nlocally already. In order to run Spark executors from mutable tags like\r\n`:latest` this commit introduces a Spark setting\r\n`spark.mesos.executor.docker.forcePullImage`. Setting this flag to\r\ntrue will tell the Mesos agent to force pull the docker image (default is `false` which is consistent with the previous\r\nimplementation and Mesos' default\r\nbehaviour).\r\n\r\n## How was this patch tested?\r\n\r\nI ran a sample application including this change on a Mesos cluster and verified the correct behaviour for both, with and without, force pulling the executor image. As expected the image is being force pulled if the flag is set.","created_at":"2016-05-11T14:39:33Z","updated_at":"2016-07-18T17:44:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a61f726e31582b5c364d54a3f03c23f6d3e7522e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/13051/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/13051/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/13051/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/36b32584bcd8197ecb8e6b8d92954270c735a62f","head":{"label":"philipphoffmann:force-pull-image","ref":"force-pull-image","sha":"36b32584bcd8197ecb8e6b8d92954270c735a62f","user":{"login":"philipphoffmann","id":1279634,"avatar_url":"https://avatars.githubusercontent.com/u/1279634?v=3","gravatar_id":"","url":"https://api.github.com/users/philipphoffmann","html_url":"https://github.com/philipphoffmann","followers_url":"https://api.github.com/users/philipphoffmann/followers","following_url":"https://api.github.com/users/philipphoffmann/following{/other_user}","gists_url":"https://api.github.com/users/philipphoffmann/gists{/gist_id}","starred_url":"https://api.github.com/users/philipphoffmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philipphoffmann/subscriptions","organizations_url":"https://api.github.com/users/philipphoffmann/orgs","repos_url":"https://api.github.com/users/philipphoffmann/repos","events_url":"https://api.github.com/users/philipphoffmann/events{/privacy}","received_events_url":"https://api.github.com/users/philipphoffmann/received_events","type":"User","site_admin":false},"repo":{"id":26526148,"name":"spark","full_name":"philipphoffmann/spark","owner":{"login":"philipphoffmann","id":1279634,"avatar_url":"https://avatars.githubusercontent.com/u/1279634?v=3","gravatar_id":"","url":"https://api.github.com/users/philipphoffmann","html_url":"https://github.com/philipphoffmann","followers_url":"https://api.github.com/users/philipphoffmann/followers","following_url":"https://api.github.com/users/philipphoffmann/following{/other_user}","gists_url":"https://api.github.com/users/philipphoffmann/gists{/gist_id}","starred_url":"https://api.github.com/users/philipphoffmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philipphoffmann/subscriptions","organizations_url":"https://api.github.com/users/philipphoffmann/orgs","repos_url":"https://api.github.com/users/philipphoffmann/repos","events_url":"https://api.github.com/users/philipphoffmann/events{/privacy}","received_events_url":"https://api.github.com/users/philipphoffmann/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/philipphoffmann/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/philipphoffmann/spark","forks_url":"https://api.github.com/repos/philipphoffmann/spark/forks","keys_url":"https://api.github.com/repos/philipphoffmann/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/philipphoffmann/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/philipphoffmann/spark/teams","hooks_url":"https://api.github.com/repos/philipphoffmann/spark/hooks","issue_events_url":"https://api.github.com/repos/philipphoffmann/spark/issues/events{/number}","events_url":"https://api.github.com/repos/philipphoffmann/spark/events","assignees_url":"https://api.github.com/repos/philipphoffmann/spark/assignees{/user}","branches_url":"https://api.github.com/repos/philipphoffmann/spark/branches{/branch}","tags_url":"https://api.github.com/repos/philipphoffmann/spark/tags","blobs_url":"https://api.github.com/repos/philipphoffmann/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/philipphoffmann/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/philipphoffmann/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/philipphoffmann/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/philipphoffmann/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/philipphoffmann/spark/languages","stargazers_url":"https://api.github.com/repos/philipphoffmann/spark/stargazers","contributors_url":"https://api.github.com/repos/philipphoffmann/spark/contributors","subscribers_url":"https://api.github.com/repos/philipphoffmann/spark/subscribers","subscription_url":"https://api.github.com/repos/philipphoffmann/spark/subscription","commits_url":"https://api.github.com/repos/philipphoffmann/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/philipphoffmann/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/philipphoffmann/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/philipphoffmann/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/philipphoffmann/spark/contents/{+path}","compare_url":"https://api.github.com/repos/philipphoffmann/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/philipphoffmann/spark/merges","archive_url":"https://api.github.com/repos/philipphoffmann/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/philipphoffmann/spark/downloads","issues_url":"https://api.github.com/repos/philipphoffmann/spark/issues{/number}","pulls_url":"https://api.github.com/repos/philipphoffmann/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/philipphoffmann/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/philipphoffmann/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/philipphoffmann/spark/labels{/name}","releases_url":"https://api.github.com/repos/philipphoffmann/spark/releases{/id}","deployments_url":"https://api.github.com/repos/philipphoffmann/spark/deployments","created_at":"2014-11-12T08:22:34Z","updated_at":"2014-11-12T07:54:24Z","pushed_at":"2016-07-18T10:50:41Z","git_url":"git://github.com/philipphoffmann/spark.git","ssh_url":"git@github.com:philipphoffmann/spark.git","clone_url":"https://github.com/philipphoffmann/spark.git","svn_url":"https://github.com/philipphoffmann/spark","homepage":null,"size":165083,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"a529fc944209e7255ec5858b33490212884d6c60","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","deployments_url":"https://api.github.com/repos/apache/spark/deployments","created_at":"2014-02-25T08:00:08Z","updated_at":"2016-07-18T17:21:31Z","pushed_at":"2016-07-18T17:07:23Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":501664,"stargazers_count":9325,"watchers_count":9325,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8650,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":440,"forks":8650,"open_issues":440,"watchers":9325,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/13051"},"html":{"href":"https://github.com/apache/spark/pull/13051"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/13051"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/13051/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/13051/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/13051/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/36b32584bcd8197ecb8e6b8d92954270c735a62f"}}}}
{"actor":{"display_login":"mgummelt"}}