{"action":"created","comment":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/comments/88482790","pull_request_review_id":9055483,"id":88482790,"diff_hunk":"@@ -283,8 +283,9 @@ def course_info(request, course_id):\n             # redirect to the dashboard page.\n             if isinstance(access_response, StartDateError):\n                 start_date = strftime_localized(course.start, 'SHORT_DATE')\n-                params = urllib.urlencode({'notlive': start_date})\n-                return redirect('{0}?{1}'.format(reverse('dashboard'), params))\n+                params = QueryDict(mutable=True)\n+                params['notlive'] = start_date\n+                return redirect('{0}?{1}'.format(reverse('dashboard'), params.urlencode()))","path":"lms/djangoapps/courseware/views/views.py","position":26,"original_position":26,"commit_id":"ff9a97008cabfb76bb4e1c3c1a1c857d2b799829","original_commit_id":"ff9a97008cabfb76bb4e1c3c1a1c857d2b799829","user":{"login":"adampalay","id":2748698,"avatar_url":"https://avatars.githubusercontent.com/u/2748698?v=3","gravatar_id":"","url":"https://api.github.com/users/adampalay","html_url":"https://github.com/adampalay","followers_url":"https://api.github.com/users/adampalay/followers","following_url":"https://api.github.com/users/adampalay/following{/other_user}","gists_url":"https://api.github.com/users/adampalay/gists{/gist_id}","starred_url":"https://api.github.com/users/adampalay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adampalay/subscriptions","organizations_url":"https://api.github.com/users/adampalay/orgs","repos_url":"https://api.github.com/users/adampalay/repos","events_url":"https://api.github.com/users/adampalay/events{/privacy}","received_events_url":"https://api.github.com/users/adampalay/received_events","type":"User","site_admin":false},"body":"totally agree, good call","created_at":"2016-11-17T16:00:01Z","updated_at":"2016-11-17T16:00:01Z","html_url":"https://github.com/edx/edx-platform/pull/14006#discussion_r88482790","pull_request_url":"https://api.github.com/repos/edx/edx-platform/pulls/14006","_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments/88482790"},"html":{"href":"https://github.com/edx/edx-platform/pull/14006#discussion_r88482790"},"pull_request":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/14006"}}},"pull_request":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/14006","id":94024188,"html_url":"https://github.com/edx/edx-platform/pull/14006","diff_url":"https://github.com/edx/edx-platform/pull/14006.diff","patch_url":"https://github.com/edx/edx-platform/pull/14006.patch","issue_url":"https://api.github.com/repos/edx/edx-platform/issues/14006","number":14006,"state":"open","locked":false,"title":"use a QueryDict to encode a url param that potentially has unicode (E…","user":{"login":"adampalay","id":2748698,"avatar_url":"https://avatars.githubusercontent.com/u/2748698?v=3","gravatar_id":"","url":"https://api.github.com/users/adampalay","html_url":"https://github.com/adampalay","followers_url":"https://api.github.com/users/adampalay/followers","following_url":"https://api.github.com/users/adampalay/following{/other_user}","gists_url":"https://api.github.com/users/adampalay/gists{/gist_id}","starred_url":"https://api.github.com/users/adampalay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adampalay/subscriptions","organizations_url":"https://api.github.com/users/adampalay/orgs","repos_url":"https://api.github.com/users/adampalay/repos","events_url":"https://api.github.com/users/adampalay/events{/privacy}","received_events_url":"https://api.github.com/users/adampalay/received_events","type":"User","site_admin":false},"body":"…COM-6390)\r\n\r\n## [ECOM-6390](https://openedx.atlassian.net/browse/ECOM-6390)\r\n\r\n### Description\r\n\r\nreplaces `urllib.urlencode` with django's [`QueryDict`](https://docs.djangoproject.com/en/1.10/ref/request-response/#django.http.QueryDict.urlencode) object to handle encoding unicode strings\r\n\r\n### How to Test?\r\n\r\n1. create a course and make sure start date is in the future (should be by default)\r\n2. go to /update_lang/ and type in \"eo\" to get fake \"esperanto\" strings\r\n3. access the course info page with a *student* account: /courses/<course_key>/\r\n\r\n**Sandbox**\r\nI'm having trouble making a sandbox :/. Luckily it's relatively straightforward to reproduce locally\r\n\r\n**Screenshot**\r\nAfter fix: \r\n![unspecified-21](https://cloud.githubusercontent.com/assets/2748698/20360258/09aefc2e-ac01-11e6-96a7-c3def5c81aa5.png)\r\nBefore fix: just 500 error\r\n\r\n### Reviewers\r\nIf you've been tagged for review, please check your corresponding box once you've given the :+1:.\r\n- [ ] Code Review: @Qubad786\r\n- [ ] Code Review: @noraiz-anwar\r\n\r\nFYI: Tag anyone who might be interested in this PR here.\r\n@bderusha adding you as an optional reviewer\r\n\r\n### Post-review\r\n- [ ] Rebase and squash commits","created_at":"2016-11-16T18:36:26Z","updated_at":"2016-11-17T16:00:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"83e2a8f7fa0897e6905d63d61091e63d74e28fb3","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/edx/edx-platform/pulls/14006/commits","review_comments_url":"https://api.github.com/repos/edx/edx-platform/pulls/14006/comments","review_comment_url":"https://api.github.com/repos/edx/edx-platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/edx/edx-platform/issues/14006/comments","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/ff9a97008cabfb76bb4e1c3c1a1c857d2b799829","head":{"label":"edx:adam/fix-date-unicode-issue","ref":"adam/fix-date-unicode-issue","sha":"ff9a97008cabfb76bb4e1c3c1a1c857d2b799829","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":10391073,"name":"edx-platform","full_name":"edx/edx-platform","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-platform","description":"The Open edX platform, the software that powers edX!","fork":false,"url":"https://api.github.com/repos/edx/edx-platform","forks_url":"https://api.github.com/repos/edx/edx-platform/forks","keys_url":"https://api.github.com/repos/edx/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-platform/teams","hooks_url":"https://api.github.com/repos/edx/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-platform/events","assignees_url":"https://api.github.com/repos/edx/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-platform/tags","blobs_url":"https://api.github.com/repos/edx/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-platform/languages","stargazers_url":"https://api.github.com/repos/edx/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-platform/subscription","commits_url":"https://api.github.com/repos/edx/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-platform/merges","archive_url":"https://api.github.com/repos/edx/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-platform/downloads","issues_url":"https://api.github.com/repos/edx/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-platform/releases{/id}","deployments_url":"https://api.github.com/repos/edx/edx-platform/deployments","created_at":"2013-05-30T20:20:38Z","updated_at":"2016-11-16T22:47:18Z","pushed_at":"2016-11-17T15:36:59Z","git_url":"git://github.com/edx/edx-platform.git","ssh_url":"git@github.com:edx/edx-platform.git","clone_url":"https://github.com/edx/edx-platform.git","svn_url":"https://github.com/edx/edx-platform","homepage":"http://open.edx.org/","size":873011,"stargazers_count":2858,"watchers_count":2858,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1700,"mirror_url":null,"open_issues_count":155,"forks":1700,"open_issues":155,"watchers":2858,"default_branch":"master"}},"base":{"label":"edx:master","ref":"master","sha":"062e0506ef96250d5082ff751ac529f055be3461","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":10391073,"name":"edx-platform","full_name":"edx/edx-platform","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-platform","description":"The Open edX platform, the software that powers edX!","fork":false,"url":"https://api.github.com/repos/edx/edx-platform","forks_url":"https://api.github.com/repos/edx/edx-platform/forks","keys_url":"https://api.github.com/repos/edx/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-platform/teams","hooks_url":"https://api.github.com/repos/edx/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-platform/events","assignees_url":"https://api.github.com/repos/edx/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-platform/tags","blobs_url":"https://api.github.com/repos/edx/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-platform/languages","stargazers_url":"https://api.github.com/repos/edx/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-platform/subscription","commits_url":"https://api.github.com/repos/edx/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-platform/merges","archive_url":"https://api.github.com/repos/edx/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-platform/downloads","issues_url":"https://api.github.com/repos/edx/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-platform/releases{/id}","deployments_url":"https://api.github.com/repos/edx/edx-platform/deployments","created_at":"2013-05-30T20:20:38Z","updated_at":"2016-11-16T22:47:18Z","pushed_at":"2016-11-17T15:36:59Z","git_url":"git://github.com/edx/edx-platform.git","ssh_url":"git@github.com:edx/edx-platform.git","clone_url":"https://github.com/edx/edx-platform.git","svn_url":"https://github.com/edx/edx-platform","homepage":"http://open.edx.org/","size":873011,"stargazers_count":2858,"watchers_count":2858,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1700,"mirror_url":null,"open_issues_count":155,"forks":1700,"open_issues":155,"watchers":2858,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/14006"},"html":{"href":"https://github.com/edx/edx-platform/pull/14006"},"issue":{"href":"https://api.github.com/repos/edx/edx-platform/issues/14006"},"comments":{"href":"https://api.github.com/repos/edx/edx-platform/issues/14006/comments"},"review_comments":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/14006/comments"},"review_comment":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/14006/commits"},"statuses":{"href":"https://api.github.com/repos/edx/edx-platform/statuses/ff9a97008cabfb76bb4e1c3c1a1c857d2b799829"}}}}
{"actor":{"display_login":"adampalay"}}