{"action":"closed","number":5209,"pull_request":{"url":"https://api.github.com/repos/Leaflet/Leaflet/pulls/5209","id":98973019,"html_url":"https://github.com/Leaflet/Leaflet/pull/5209","diff_url":"https://github.com/Leaflet/Leaflet/pull/5209.diff","patch_url":"https://github.com/Leaflet/Leaflet/pull/5209.patch","issue_url":"https://api.github.com/repos/Leaflet/Leaflet/issues/5209","number":5209,"state":"closed","locked":false,"title":"adds graceful fallback to clientWidth & clinetHeight in getSize","user":{"login":"ughitsaaron","id":5301535,"avatar_url":"https://avatars.githubusercontent.com/u/5301535?v=3","gravatar_id":"","url":"https://api.github.com/users/ughitsaaron","html_url":"https://github.com/ughitsaaron","followers_url":"https://api.github.com/users/ughitsaaron/followers","following_url":"https://api.github.com/users/ughitsaaron/following{/other_user}","gists_url":"https://api.github.com/users/ughitsaaron/gists{/gist_id}","starred_url":"https://api.github.com/users/ughitsaaron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ughitsaaron/subscriptions","organizations_url":"https://api.github.com/users/ughitsaaron/orgs","repos_url":"https://api.github.com/users/ughitsaaron/repos","events_url":"https://api.github.com/users/ughitsaaron/events{/privacy}","received_events_url":"https://api.github.com/users/ughitsaaron/received_events","type":"User","site_admin":false},"body":"Per #4823 \r\n\r\nIf `clientWidth` or `clientHeight` are undefined (as might be the case in an environment like jsdom), `L.Point` will return a point with `undefined` or `NaN` coordinates. Since `L.Point` always expects a number to be passed in as an argument, clientWidth and clientHeight can fallback to 0 in case they are undefined.\r\n\r\nFor further background, check the issue linked above.","created_at":"2016-12-21T17:26:31Z","updated_at":"2016-12-21T23:36:58Z","closed_at":"2016-12-21T23:36:58Z","merged_at":"2016-12-21T23:36:58Z","merge_commit_sha":"9e5903db405319e462f2d813d0908b2f39493f13","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Leaflet/Leaflet/pulls/5209/commits","review_comments_url":"https://api.github.com/repos/Leaflet/Leaflet/pulls/5209/comments","review_comment_url":"https://api.github.com/repos/Leaflet/Leaflet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Leaflet/Leaflet/issues/5209/comments","statuses_url":"https://api.github.com/repos/Leaflet/Leaflet/statuses/1b3c938ddaf7b013ae1d2b9b59806db506c72997","head":{"label":"ughitsaaron:get-size-fallback","ref":"get-size-fallback","sha":"1b3c938ddaf7b013ae1d2b9b59806db506c72997","user":{"login":"ughitsaaron","id":5301535,"avatar_url":"https://avatars.githubusercontent.com/u/5301535?v=3","gravatar_id":"","url":"https://api.github.com/users/ughitsaaron","html_url":"https://github.com/ughitsaaron","followers_url":"https://api.github.com/users/ughitsaaron/followers","following_url":"https://api.github.com/users/ughitsaaron/following{/other_user}","gists_url":"https://api.github.com/users/ughitsaaron/gists{/gist_id}","starred_url":"https://api.github.com/users/ughitsaaron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ughitsaaron/subscriptions","organizations_url":"https://api.github.com/users/ughitsaaron/orgs","repos_url":"https://api.github.com/users/ughitsaaron/repos","events_url":"https://api.github.com/users/ughitsaaron/events{/privacy}","received_events_url":"https://api.github.com/users/ughitsaaron/received_events","type":"User","site_admin":false},"repo":{"id":77070546,"name":"Leaflet","full_name":"ughitsaaron/Leaflet","owner":{"login":"ughitsaaron","id":5301535,"avatar_url":"https://avatars.githubusercontent.com/u/5301535?v=3","gravatar_id":"","url":"https://api.github.com/users/ughitsaaron","html_url":"https://github.com/ughitsaaron","followers_url":"https://api.github.com/users/ughitsaaron/followers","following_url":"https://api.github.com/users/ughitsaaron/following{/other_user}","gists_url":"https://api.github.com/users/ughitsaaron/gists{/gist_id}","starred_url":"https://api.github.com/users/ughitsaaron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ughitsaaron/subscriptions","organizations_url":"https://api.github.com/users/ughitsaaron/orgs","repos_url":"https://api.github.com/users/ughitsaaron/repos","events_url":"https://api.github.com/users/ughitsaaron/events{/privacy}","received_events_url":"https://api.github.com/users/ughitsaaron/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ughitsaaron/Leaflet","description":" :leaves: JavaScript library for mobile-friendly interactive maps","fork":true,"url":"https://api.github.com/repos/ughitsaaron/Leaflet","forks_url":"https://api.github.com/repos/ughitsaaron/Leaflet/forks","keys_url":"https://api.github.com/repos/ughitsaaron/Leaflet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ughitsaaron/Leaflet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ughitsaaron/Leaflet/teams","hooks_url":"https://api.github.com/repos/ughitsaaron/Leaflet/hooks","issue_events_url":"https://api.github.com/repos/ughitsaaron/Leaflet/issues/events{/number}","events_url":"https://api.github.com/repos/ughitsaaron/Leaflet/events","assignees_url":"https://api.github.com/repos/ughitsaaron/Leaflet/assignees{/user}","branches_url":"https://api.github.com/repos/ughitsaaron/Leaflet/branches{/branch}","tags_url":"https://api.github.com/repos/ughitsaaron/Leaflet/tags","blobs_url":"https://api.github.com/repos/ughitsaaron/Leaflet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ughitsaaron/Leaflet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ughitsaaron/Leaflet/git/refs{/sha}","trees_url":"https://api.github.com/repos/ughitsaaron/Leaflet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ughitsaaron/Leaflet/statuses/{sha}","languages_url":"https://api.github.com/repos/ughitsaaron/Leaflet/languages","stargazers_url":"https://api.github.com/repos/ughitsaaron/Leaflet/stargazers","contributors_url":"https://api.github.com/repos/ughitsaaron/Leaflet/contributors","subscribers_url":"https://api.github.com/repos/ughitsaaron/Leaflet/subscribers","subscription_url":"https://api.github.com/repos/ughitsaaron/Leaflet/subscription","commits_url":"https://api.github.com/repos/ughitsaaron/Leaflet/commits{/sha}","git_commits_url":"https://api.github.com/repos/ughitsaaron/Leaflet/git/commits{/sha}","comments_url":"https://api.github.com/repos/ughitsaaron/Leaflet/comments{/number}","issue_comment_url":"https://api.github.com/repos/ughitsaaron/Leaflet/issues/comments{/number}","contents_url":"https://api.github.com/repos/ughitsaaron/Leaflet/contents/{+path}","compare_url":"https://api.github.com/repos/ughitsaaron/Leaflet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ughitsaaron/Leaflet/merges","archive_url":"https://api.github.com/repos/ughitsaaron/Leaflet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ughitsaaron/Leaflet/downloads","issues_url":"https://api.github.com/repos/ughitsaaron/Leaflet/issues{/number}","pulls_url":"https://api.github.com/repos/ughitsaaron/Leaflet/pulls{/number}","milestones_url":"https://api.github.com/repos/ughitsaaron/Leaflet/milestones{/number}","notifications_url":"https://api.github.com/repos/ughitsaaron/Leaflet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ughitsaaron/Leaflet/labels{/name}","releases_url":"https://api.github.com/repos/ughitsaaron/Leaflet/releases{/id}","deployments_url":"https://api.github.com/repos/ughitsaaron/Leaflet/deployments","created_at":"2016-12-21T17:01:18Z","updated_at":"2016-12-21T17:01:25Z","pushed_at":"2016-12-21T17:18:31Z","git_url":"git://github.com/ughitsaaron/Leaflet.git","ssh_url":"git@github.com:ughitsaaron/Leaflet.git","clone_url":"https://github.com/ughitsaaron/Leaflet.git","svn_url":"https://github.com/ughitsaaron/Leaflet","homepage":"http://leafletjs.com","size":35450,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Leaflet:master","ref":"master","sha":"b8b7281ee8f3e489d8eba67ea10dcae7c7cf1031","user":{"login":"Leaflet","id":2854298,"avatar_url":"https://avatars.githubusercontent.com/u/2854298?v=3","gravatar_id":"","url":"https://api.github.com/users/Leaflet","html_url":"https://github.com/Leaflet","followers_url":"https://api.github.com/users/Leaflet/followers","following_url":"https://api.github.com/users/Leaflet/following{/other_user}","gists_url":"https://api.github.com/users/Leaflet/gists{/gist_id}","starred_url":"https://api.github.com/users/Leaflet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Leaflet/subscriptions","organizations_url":"https://api.github.com/users/Leaflet/orgs","repos_url":"https://api.github.com/users/Leaflet/repos","events_url":"https://api.github.com/users/Leaflet/events{/privacy}","received_events_url":"https://api.github.com/users/Leaflet/received_events","type":"Organization","site_admin":false},"repo":{"id":931135,"name":"Leaflet","full_name":"Leaflet/Leaflet","owner":{"login":"Leaflet","id":2854298,"avatar_url":"https://avatars.githubusercontent.com/u/2854298?v=3","gravatar_id":"","url":"https://api.github.com/users/Leaflet","html_url":"https://github.com/Leaflet","followers_url":"https://api.github.com/users/Leaflet/followers","following_url":"https://api.github.com/users/Leaflet/following{/other_user}","gists_url":"https://api.github.com/users/Leaflet/gists{/gist_id}","starred_url":"https://api.github.com/users/Leaflet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Leaflet/subscriptions","organizations_url":"https://api.github.com/users/Leaflet/orgs","repos_url":"https://api.github.com/users/Leaflet/repos","events_url":"https://api.github.com/users/Leaflet/events{/privacy}","received_events_url":"https://api.github.com/users/Leaflet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Leaflet/Leaflet","description":" :leaves: JavaScript library for mobile-friendly interactive maps","fork":false,"url":"https://api.github.com/repos/Leaflet/Leaflet","forks_url":"https://api.github.com/repos/Leaflet/Leaflet/forks","keys_url":"https://api.github.com/repos/Leaflet/Leaflet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Leaflet/Leaflet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Leaflet/Leaflet/teams","hooks_url":"https://api.github.com/repos/Leaflet/Leaflet/hooks","issue_events_url":"https://api.github.com/repos/Leaflet/Leaflet/issues/events{/number}","events_url":"https://api.github.com/repos/Leaflet/Leaflet/events","assignees_url":"https://api.github.com/repos/Leaflet/Leaflet/assignees{/user}","branches_url":"https://api.github.com/repos/Leaflet/Leaflet/branches{/branch}","tags_url":"https://api.github.com/repos/Leaflet/Leaflet/tags","blobs_url":"https://api.github.com/repos/Leaflet/Leaflet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Leaflet/Leaflet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Leaflet/Leaflet/git/refs{/sha}","trees_url":"https://api.github.com/repos/Leaflet/Leaflet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Leaflet/Leaflet/statuses/{sha}","languages_url":"https://api.github.com/repos/Leaflet/Leaflet/languages","stargazers_url":"https://api.github.com/repos/Leaflet/Leaflet/stargazers","contributors_url":"https://api.github.com/repos/Leaflet/Leaflet/contributors","subscribers_url":"https://api.github.com/repos/Leaflet/Leaflet/subscribers","subscription_url":"https://api.github.com/repos/Leaflet/Leaflet/subscription","commits_url":"https://api.github.com/repos/Leaflet/Leaflet/commits{/sha}","git_commits_url":"https://api.github.com/repos/Leaflet/Leaflet/git/commits{/sha}","comments_url":"https://api.github.com/repos/Leaflet/Leaflet/comments{/number}","issue_comment_url":"https://api.github.com/repos/Leaflet/Leaflet/issues/comments{/number}","contents_url":"https://api.github.com/repos/Leaflet/Leaflet/contents/{+path}","compare_url":"https://api.github.com/repos/Leaflet/Leaflet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Leaflet/Leaflet/merges","archive_url":"https://api.github.com/repos/Leaflet/Leaflet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Leaflet/Leaflet/downloads","issues_url":"https://api.github.com/repos/Leaflet/Leaflet/issues{/number}","pulls_url":"https://api.github.com/repos/Leaflet/Leaflet/pulls{/number}","milestones_url":"https://api.github.com/repos/Leaflet/Leaflet/milestones{/number}","notifications_url":"https://api.github.com/repos/Leaflet/Leaflet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Leaflet/Leaflet/labels{/name}","releases_url":"https://api.github.com/repos/Leaflet/Leaflet/releases{/id}","deployments_url":"https://api.github.com/repos/Leaflet/Leaflet/deployments","created_at":"2010-09-22T16:57:44Z","updated_at":"2016-12-21T23:11:31Z","pushed_at":"2016-12-21T23:36:58Z","git_url":"git://github.com/Leaflet/Leaflet.git","ssh_url":"git@github.com:Leaflet/Leaflet.git","clone_url":"https://github.com/Leaflet/Leaflet.git","svn_url":"https://github.com/Leaflet/Leaflet","homepage":"http://leafletjs.com","size":35462,"stargazers_count":17103,"watchers_count":17103,"language":"JavaScript","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":2895,"mirror_url":null,"open_issues_count":305,"forks":2895,"open_issues":305,"watchers":17103,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Leaflet/Leaflet/pulls/5209"},"html":{"href":"https://github.com/Leaflet/Leaflet/pull/5209"},"issue":{"href":"https://api.github.com/repos/Leaflet/Leaflet/issues/5209"},"comments":{"href":"https://api.github.com/repos/Leaflet/Leaflet/issues/5209/comments"},"review_comments":{"href":"https://api.github.com/repos/Leaflet/Leaflet/pulls/5209/comments"},"review_comment":{"href":"https://api.github.com/repos/Leaflet/Leaflet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Leaflet/Leaflet/pulls/5209/commits"},"statuses":{"href":"https://api.github.com/repos/Leaflet/Leaflet/statuses/1b3c938ddaf7b013ae1d2b9b59806db506c72997"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"mourner","id":25395,"avatar_url":"https://avatars.githubusercontent.com/u/25395?v=3","gravatar_id":"","url":"https://api.github.com/users/mourner","html_url":"https://github.com/mourner","followers_url":"https://api.github.com/users/mourner/followers","following_url":"https://api.github.com/users/mourner/following{/other_user}","gists_url":"https://api.github.com/users/mourner/gists{/gist_id}","starred_url":"https://api.github.com/users/mourner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mourner/subscriptions","organizations_url":"https://api.github.com/users/mourner/orgs","repos_url":"https://api.github.com/users/mourner/repos","events_url":"https://api.github.com/users/mourner/events{/privacy}","received_events_url":"https://api.github.com/users/mourner/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":2,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"mourner"}}