{"comment":{"url":"https://api.github.com/repos/Sycholic/PermissionsEx/comments/19257357","html_url":"https://github.com/Sycholic/PermissionsEx/commit/23bc15b7e75d7a9e8945b4ad3e9d12bf53cd1e3c#commitcomment-19257357","id":19257357,"user":{"login":"mibby","id":3634635,"avatar_url":"https://avatars.githubusercontent.com/u/3634635?v=3","gravatar_id":"","url":"https://api.github.com/users/mibby","html_url":"https://github.com/mibby","followers_url":"https://api.github.com/users/mibby/followers","following_url":"https://api.github.com/users/mibby/following{/other_user}","gists_url":"https://api.github.com/users/mibby/gists{/gist_id}","starred_url":"https://api.github.com/users/mibby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mibby/subscriptions","organizations_url":"https://api.github.com/users/mibby/orgs","repos_url":"https://api.github.com/users/mibby/repos","events_url":"https://api.github.com/users/mibby/events{/privacy}","received_events_url":"https://api.github.com/users/mibby/received_events","type":"User","site_admin":false},"position":null,"line":null,"path":null,"commit_id":"23bc15b7e75d7a9e8945b4ad3e9d12bf53cd1e3c","created_at":"2016-10-02T01:02:24Z","updated_at":"2016-10-02T01:02:24Z","body":"@Sycholic Have you thought about using a jenkins build server to compile dev builds to make testing and obtaining dev versions easier? I compiled your 1.24.x branch as of this commit https://github.com/Sycholic/PermissionsEx/commit/23bc15b7e75d7a9e8945b4ad3e9d12bf53cd1e3c for testing.\r\n\r\nNewer version of my permissions file with user grouping to be used for testing. Let me know when obtained so I can remove the public link please.\r\nhttps://www.dropbox.com/s/fg3ebkxq3nbi59z/permissions.yml?dl=1\r\n\r\nTyping ```/pex user c``` or anything related to looking up a user due to being a non-specific name/UUID crashes the server with my large permissions file.\r\nhttp://paste.ubuntu.com/23262669/\r\n\r\nYou are no longer able to group or lookup users by their UUID. i.e. ```/pex user 291c2d6e-a25d-4179-a11e-3011f9a97b2b group list```. This is possible with the official PEX 1.23.5-SNAPSHOT branch (and something that I do use). Not possible with your branch. It simply just outputs ```User does not match any known names!``` Problem would be related to this specific commit I am commenting on I believe? :P \r\n\r\nOutside of my quick testing, everything _seems_ to be functioning similar to PEX 1.23.5. Nothing else broken as far as I can tell. If you can fix the above UUID grouping/listing issue and give the go-ahead that it is relatively production stable for live testing, I'll put it up on my public server. :)\r\n\r\nHave you also thought about updating the README.md in your fork with a summarized changelog of fixes / optimizations / changes to PEX so others can find out why your fork is better (mainly being a continued development of the plugin) than the primary upstream one? Could include a link to the build server there for dev builds if you ever get one too. :)"}}
{"actor":{"display_login":"mibby"}}