{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/49604594","id":49604594,"diff_hunk":"@@ -340,11 +340,20 @@ win32.basename = function(path, ext) {\n   if (ext !== undefined && typeof ext !== 'string')\n     throw new TypeError('\"ext\" argument must be a string');\n \n-  var f = win32SplitPath(path)[2];\n-  // TODO: make this comparison case-insensitive on windows?\n-  if (ext && f.substr(-1 * ext.length) === ext) {\n-    f = f.substr(0, f.length - ext.length);\n+  let f = win32SplitPath(path)[2];\n+\n+  if (ext) {\n+    let loF = f.toLowerCase();\n+\n+    ext = ext.toLowerCase();\n+\n+    if (loF.substr(-1 * ext.length) === ext) {","path":"lib/path.js","position":15,"original_position":15,"commit_id":"b62b2b02075670e1c90445dd83c9f7003b100d22","original_commit_id":"4febedf56a75d1b9574d1968158ba17b9d1fda98","user":{"login":"tflanagan","id":5559820,"avatar_url":"https://avatars.githubusercontent.com/u/5559820?v=3","gravatar_id":"","url":"https://api.github.com/users/tflanagan","html_url":"https://github.com/tflanagan","followers_url":"https://api.github.com/users/tflanagan/followers","following_url":"https://api.github.com/users/tflanagan/following{/other_user}","gists_url":"https://api.github.com/users/tflanagan/gists{/gist_id}","starred_url":"https://api.github.com/users/tflanagan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tflanagan/subscriptions","organizations_url":"https://api.github.com/users/tflanagan/orgs","repos_url":"https://api.github.com/users/tflanagan/repos","events_url":"https://api.github.com/users/tflanagan/events{/privacy}","received_events_url":"https://api.github.com/users/tflanagan/received_events","type":"User","site_admin":false},"body":"It probably would be :+1:, is there a performance hit?","created_at":"2016-01-13T15:33:37Z","updated_at":"2016-01-13T15:33:37Z","html_url":"https://github.com/nodejs/node/pull/4669#discussion_r49604594","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/4669","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/49604594"},"html":{"href":"https://github.com/nodejs/node/pull/4669#discussion_r49604594"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/4669"}}},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/4669","id":55906103,"html_url":"https://github.com/nodejs/node/pull/4669","diff_url":"https://github.com/nodejs/node/pull/4669.diff","patch_url":"https://github.com/nodejs/node/pull/4669.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/4669","number":4669,"state":"open","locked":false,"title":"lib: fix basename comparison on windows","user":{"login":"tflanagan","id":5559820,"avatar_url":"https://avatars.githubusercontent.com/u/5559820?v=3","gravatar_id":"","url":"https://api.github.com/users/tflanagan","html_url":"https://github.com/tflanagan","followers_url":"https://api.github.com/users/tflanagan/followers","following_url":"https://api.github.com/users/tflanagan/following{/other_user}","gists_url":"https://api.github.com/users/tflanagan/gists{/gist_id}","starred_url":"https://api.github.com/users/tflanagan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tflanagan/subscriptions","organizations_url":"https://api.github.com/users/tflanagan/orgs","repos_url":"https://api.github.com/users/tflanagan/repos","events_url":"https://api.github.com/users/tflanagan/events{/privacy}","received_events_url":"https://api.github.com/users/tflanagan/received_events","type":"User","site_admin":false},"body":"Fixes TODO in lib/path.js ref'd here #4642\r\n\r\n```javascript\r\n var f = win32SplitPath(path)[2];\r\n  // TODO: make this comparison case-insensitive on windows?\r\n  if (ext && f.substr(-1 * ext.length) === ext) {\r\n    f = f.substr(0, f.length - ext.length);\r\n```","created_at":"2016-01-13T14:46:53Z","updated_at":"2016-01-13T15:33:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"28bd154a623f76e202d710e4e0c0b721e51fedcc","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/4669/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/4669/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/4669/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/b62b2b02075670e1c90445dd83c9f7003b100d22","head":{"label":"tflanagan:path-win-fix-comparison","ref":"path-win-fix-comparison","sha":"b62b2b02075670e1c90445dd83c9f7003b100d22","user":{"login":"tflanagan","id":5559820,"avatar_url":"https://avatars.githubusercontent.com/u/5559820?v=3","gravatar_id":"","url":"https://api.github.com/users/tflanagan","html_url":"https://github.com/tflanagan","followers_url":"https://api.github.com/users/tflanagan/followers","following_url":"https://api.github.com/users/tflanagan/following{/other_user}","gists_url":"https://api.github.com/users/tflanagan/gists{/gist_id}","starred_url":"https://api.github.com/users/tflanagan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tflanagan/subscriptions","organizations_url":"https://api.github.com/users/tflanagan/orgs","repos_url":"https://api.github.com/users/tflanagan/repos","events_url":"https://api.github.com/users/tflanagan/events{/privacy}","received_events_url":"https://api.github.com/users/tflanagan/received_events","type":"User","site_admin":false},"repo":{"id":42073701,"name":"node","full_name":"tflanagan/node","owner":{"login":"tflanagan","id":5559820,"avatar_url":"https://avatars.githubusercontent.com/u/5559820?v=3","gravatar_id":"","url":"https://api.github.com/users/tflanagan","html_url":"https://github.com/tflanagan","followers_url":"https://api.github.com/users/tflanagan/followers","following_url":"https://api.github.com/users/tflanagan/following{/other_user}","gists_url":"https://api.github.com/users/tflanagan/gists{/gist_id}","starred_url":"https://api.github.com/users/tflanagan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tflanagan/subscriptions","organizations_url":"https://api.github.com/users/tflanagan/orgs","repos_url":"https://api.github.com/users/tflanagan/repos","events_url":"https://api.github.com/users/tflanagan/events{/privacy}","received_events_url":"https://api.github.com/users/tflanagan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tflanagan/node","description":"✨Future Node.js releases will be from this repo. ✨","fork":true,"url":"https://api.github.com/repos/tflanagan/node","forks_url":"https://api.github.com/repos/tflanagan/node/forks","keys_url":"https://api.github.com/repos/tflanagan/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tflanagan/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tflanagan/node/teams","hooks_url":"https://api.github.com/repos/tflanagan/node/hooks","issue_events_url":"https://api.github.com/repos/tflanagan/node/issues/events{/number}","events_url":"https://api.github.com/repos/tflanagan/node/events","assignees_url":"https://api.github.com/repos/tflanagan/node/assignees{/user}","branches_url":"https://api.github.com/repos/tflanagan/node/branches{/branch}","tags_url":"https://api.github.com/repos/tflanagan/node/tags","blobs_url":"https://api.github.com/repos/tflanagan/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tflanagan/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tflanagan/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/tflanagan/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tflanagan/node/statuses/{sha}","languages_url":"https://api.github.com/repos/tflanagan/node/languages","stargazers_url":"https://api.github.com/repos/tflanagan/node/stargazers","contributors_url":"https://api.github.com/repos/tflanagan/node/contributors","subscribers_url":"https://api.github.com/repos/tflanagan/node/subscribers","subscription_url":"https://api.github.com/repos/tflanagan/node/subscription","commits_url":"https://api.github.com/repos/tflanagan/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/tflanagan/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/tflanagan/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/tflanagan/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/tflanagan/node/contents/{+path}","compare_url":"https://api.github.com/repos/tflanagan/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tflanagan/node/merges","archive_url":"https://api.github.com/repos/tflanagan/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tflanagan/node/downloads","issues_url":"https://api.github.com/repos/tflanagan/node/issues{/number}","pulls_url":"https://api.github.com/repos/tflanagan/node/pulls{/number}","milestones_url":"https://api.github.com/repos/tflanagan/node/milestones{/number}","notifications_url":"https://api.github.com/repos/tflanagan/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tflanagan/node/labels{/name}","releases_url":"https://api.github.com/repos/tflanagan/node/releases{/id}","created_at":"2015-09-07T20:43:19Z","updated_at":"2016-01-12T13:07:24Z","pushed_at":"2016-01-13T15:31:47Z","git_url":"git://github.com/tflanagan/node.git","ssh_url":"git@github.com:tflanagan/node.git","clone_url":"https://github.com/tflanagan/node.git","svn_url":"https://github.com/tflanagan/node","homepage":"https://nodejs.org","size":164918,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"4383acd9f40e17f9457981031ca4e4daca6569bb","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","created_at":"2014-11-26T19:57:11Z","updated_at":"2016-01-13T15:17:16Z","pushed_at":"2016-01-13T15:31:48Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":182059,"stargazers_count":19114,"watchers_count":19114,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2253,"mirror_url":null,"open_issues_count":681,"forks":2253,"open_issues":681,"watchers":19114,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/4669"},"html":{"href":"https://github.com/nodejs/node/pull/4669"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/4669"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/4669/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/4669/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/4669/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/b62b2b02075670e1c90445dd83c9f7003b100d22"}}}}