{"action":"created","comment":{"url":"https://api.github.com/repos/linagora/james-project/pulls/comments/75899261","id":75899261,"diff_hunk":"@@ -1775,6 +1775,212 @@ public void setMessagesShouldReturnAttachmentsWhenMessageHasAttachment() throws\n             .body(secondAttachment + \".isInline\", equalTo(true));\n     }\n \n+    @Test\n+    public void setMessagesShouldReturnAttachmentsWithNonASCIINames() throws Exception {\n+        jmapServer.serverProbe().createMailbox(MailboxConstants.USER_NAMESPACE, username, \"sent\");\n+\n+        Attachment attachment = Attachment.builder()\n+                .bytes(\"attachment\".getBytes(Charsets.UTF_8))\n+                .type(\"application/octet-stream\")\n+                .build();\n+        uploadAttachment(attachment);\n+        Attachment attachment2 = Attachment.builder()\n+                .bytes(\"attachment2\".getBytes(Charsets.UTF_8))\n+                .type(\"application/octet-stream\")\n+                .build();\n+        uploadAttachment(attachment2);\n+        Attachment attachment3 = Attachment.builder()\n+                .bytes(\"attachment3\".getBytes(Charsets.UTF_8))\n+                .type(\"application/octet-stream\")\n+                .build();\n+        uploadAttachment(attachment3);\n+\n+        String messageCreationId = \"creationId\";\n+        String fromAddress = username;\n+        String outboxId = getOutboxId(accessToken);\n+        String requestBody = \"[\" +\n+                \"  [\" +\n+                \"    \\\"setMessages\\\",\"+\n+                \"    {\" +\n+                \"      \\\"create\\\": { \\\"\" + messageCreationId  + \"\\\" : {\" +\n+                \"        \\\"from\\\": { \\\"name\\\": \\\"Me\\\", \\\"email\\\": \\\"\" + fromAddress + \"\\\"},\" +\n+                \"        \\\"to\\\": [{ \\\"name\\\": \\\"BOB\\\", \\\"email\\\": \\\"someone@example.com\\\"}],\" +\n+                \"        \\\"subject\\\": \\\"Message with three attachments with non ASCII name\\\",\" +\n+                \"        \\\"textBody\\\": \\\"Test body\\\",\" +\n+                \"        \\\"mailboxIds\\\": [\\\"\" + outboxId + \"\\\"], \" +\n+                \"        \\\"attachments\\\": [\" +\n+                \"               {\\\"blobId\\\" : \\\"\" + attachment.getAttachmentId().getId() + \"\\\", \" +\n+                \"               \\\"type\\\" : \\\"\" + attachment.getType() + \"\\\", \" +","path":"server/protocols/jmap-integration-testing/jmap-integration-testing-common/src/test/java/org/apache/james/jmap/methods/integration/SetMessagesMethodTest.java","position":39,"original_position":39,"commit_id":"e7b60af48ccc8ec51768f1c05a691f0d937c1dcf","original_commit_id":"a90686fb6f64c49928bb4366e66c2be74c6d5233","user":{"login":"Laura-Royet","id":16225407,"avatar_url":"https://avatars.githubusercontent.com/u/16225407?v=3","gravatar_id":"","url":"https://api.github.com/users/Laura-Royet","html_url":"https://github.com/Laura-Royet","followers_url":"https://api.github.com/users/Laura-Royet/followers","following_url":"https://api.github.com/users/Laura-Royet/following{/other_user}","gists_url":"https://api.github.com/users/Laura-Royet/gists{/gist_id}","starred_url":"https://api.github.com/users/Laura-Royet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Laura-Royet/subscriptions","organizations_url":"https://api.github.com/users/Laura-Royet/orgs","repos_url":"https://api.github.com/users/Laura-Royet/repos","events_url":"https://api.github.com/users/Laura-Royet/events{/privacy}","received_events_url":"https://api.github.com/users/Laura-Royet/received_events","type":"User","site_admin":false},"body":"ok, done","created_at":"2016-08-23T16:11:41Z","updated_at":"2016-08-23T16:11:41Z","html_url":"https://github.com/linagora/james-project/pull/366#discussion_r75899261","pull_request_url":"https://api.github.com/repos/linagora/james-project/pulls/366","_links":{"self":{"href":"https://api.github.com/repos/linagora/james-project/pulls/comments/75899261"},"html":{"href":"https://github.com/linagora/james-project/pull/366#discussion_r75899261"},"pull_request":{"href":"https://api.github.com/repos/linagora/james-project/pulls/366"}}},"pull_request":{"url":"https://api.github.com/repos/linagora/james-project/pulls/366","id":82214867,"html_url":"https://github.com/linagora/james-project/pull/366","diff_url":"https://github.com/linagora/james-project/pull/366.diff","patch_url":"https://github.com/linagora/james-project/pull/366.patch","issue_url":"https://api.github.com/repos/linagora/james-project/issues/366","number":366,"state":"open","locked":false,"title":"James 1814 Encoding issues in filename attachment containing non ASCII characters","user":{"login":"Laura-Royet","id":16225407,"avatar_url":"https://avatars.githubusercontent.com/u/16225407?v=3","gravatar_id":"","url":"https://api.github.com/users/Laura-Royet","html_url":"https://github.com/Laura-Royet","followers_url":"https://api.github.com/users/Laura-Royet/followers","following_url":"https://api.github.com/users/Laura-Royet/following{/other_user}","gists_url":"https://api.github.com/users/Laura-Royet/gists{/gist_id}","starred_url":"https://api.github.com/users/Laura-Royet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Laura-Royet/subscriptions","organizations_url":"https://api.github.com/users/Laura-Royet/orgs","repos_url":"https://api.github.com/users/Laura-Royet/repos","events_url":"https://api.github.com/users/Laura-Royet/events{/privacy}","received_events_url":"https://api.github.com/users/Laura-Royet/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-08-22T15:45:59Z","updated_at":"2016-08-23T16:11:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"24bf96844e0224269c5a28907a49558abf46d23a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/linagora/james-project/pulls/366/commits","review_comments_url":"https://api.github.com/repos/linagora/james-project/pulls/366/comments","review_comment_url":"https://api.github.com/repos/linagora/james-project/pulls/comments{/number}","comments_url":"https://api.github.com/repos/linagora/james-project/issues/366/comments","statuses_url":"https://api.github.com/repos/linagora/james-project/statuses/e7b60af48ccc8ec51768f1c05a691f0d937c1dcf","head":{"label":"Laura-Royet:JAMES-1814","ref":"JAMES-1814","sha":"e7b60af48ccc8ec51768f1c05a691f0d937c1dcf","user":{"login":"Laura-Royet","id":16225407,"avatar_url":"https://avatars.githubusercontent.com/u/16225407?v=3","gravatar_id":"","url":"https://api.github.com/users/Laura-Royet","html_url":"https://github.com/Laura-Royet","followers_url":"https://api.github.com/users/Laura-Royet/followers","following_url":"https://api.github.com/users/Laura-Royet/following{/other_user}","gists_url":"https://api.github.com/users/Laura-Royet/gists{/gist_id}","starred_url":"https://api.github.com/users/Laura-Royet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Laura-Royet/subscriptions","organizations_url":"https://api.github.com/users/Laura-Royet/orgs","repos_url":"https://api.github.com/users/Laura-Royet/repos","events_url":"https://api.github.com/users/Laura-Royet/events{/privacy}","received_events_url":"https://api.github.com/users/Laura-Royet/received_events","type":"User","site_admin":false},"repo":{"id":49267143,"name":"james-project","full_name":"Laura-Royet/james-project","owner":{"login":"Laura-Royet","id":16225407,"avatar_url":"https://avatars.githubusercontent.com/u/16225407?v=3","gravatar_id":"","url":"https://api.github.com/users/Laura-Royet","html_url":"https://github.com/Laura-Royet","followers_url":"https://api.github.com/users/Laura-Royet/followers","following_url":"https://api.github.com/users/Laura-Royet/following{/other_user}","gists_url":"https://api.github.com/users/Laura-Royet/gists{/gist_id}","starred_url":"https://api.github.com/users/Laura-Royet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Laura-Royet/subscriptions","organizations_url":"https://api.github.com/users/Laura-Royet/orgs","repos_url":"https://api.github.com/users/Laura-Royet/repos","events_url":"https://api.github.com/users/Laura-Royet/events{/privacy}","received_events_url":"https://api.github.com/users/Laura-Royet/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Laura-Royet/james-project","description":"Mirror of Apache James Project","fork":true,"url":"https://api.github.com/repos/Laura-Royet/james-project","forks_url":"https://api.github.com/repos/Laura-Royet/james-project/forks","keys_url":"https://api.github.com/repos/Laura-Royet/james-project/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Laura-Royet/james-project/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Laura-Royet/james-project/teams","hooks_url":"https://api.github.com/repos/Laura-Royet/james-project/hooks","issue_events_url":"https://api.github.com/repos/Laura-Royet/james-project/issues/events{/number}","events_url":"https://api.github.com/repos/Laura-Royet/james-project/events","assignees_url":"https://api.github.com/repos/Laura-Royet/james-project/assignees{/user}","branches_url":"https://api.github.com/repos/Laura-Royet/james-project/branches{/branch}","tags_url":"https://api.github.com/repos/Laura-Royet/james-project/tags","blobs_url":"https://api.github.com/repos/Laura-Royet/james-project/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Laura-Royet/james-project/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Laura-Royet/james-project/git/refs{/sha}","trees_url":"https://api.github.com/repos/Laura-Royet/james-project/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Laura-Royet/james-project/statuses/{sha}","languages_url":"https://api.github.com/repos/Laura-Royet/james-project/languages","stargazers_url":"https://api.github.com/repos/Laura-Royet/james-project/stargazers","contributors_url":"https://api.github.com/repos/Laura-Royet/james-project/contributors","subscribers_url":"https://api.github.com/repos/Laura-Royet/james-project/subscribers","subscription_url":"https://api.github.com/repos/Laura-Royet/james-project/subscription","commits_url":"https://api.github.com/repos/Laura-Royet/james-project/commits{/sha}","git_commits_url":"https://api.github.com/repos/Laura-Royet/james-project/git/commits{/sha}","comments_url":"https://api.github.com/repos/Laura-Royet/james-project/comments{/number}","issue_comment_url":"https://api.github.com/repos/Laura-Royet/james-project/issues/comments{/number}","contents_url":"https://api.github.com/repos/Laura-Royet/james-project/contents/{+path}","compare_url":"https://api.github.com/repos/Laura-Royet/james-project/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Laura-Royet/james-project/merges","archive_url":"https://api.github.com/repos/Laura-Royet/james-project/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Laura-Royet/james-project/downloads","issues_url":"https://api.github.com/repos/Laura-Royet/james-project/issues{/number}","pulls_url":"https://api.github.com/repos/Laura-Royet/james-project/pulls{/number}","milestones_url":"https://api.github.com/repos/Laura-Royet/james-project/milestones{/number}","notifications_url":"https://api.github.com/repos/Laura-Royet/james-project/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Laura-Royet/james-project/labels{/name}","releases_url":"https://api.github.com/repos/Laura-Royet/james-project/releases{/id}","deployments_url":"https://api.github.com/repos/Laura-Royet/james-project/deployments","created_at":"2016-01-08T10:56:02Z","updated_at":"2016-01-08T10:56:11Z","pushed_at":"2016-08-22T15:44:09Z","git_url":"git://github.com/Laura-Royet/james-project.git","ssh_url":"git@github.com:Laura-Royet/james-project.git","clone_url":"https://github.com/Laura-Royet/james-project.git","svn_url":"https://github.com/Laura-Royet/james-project","homepage":null,"size":12844,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"linagora:master","ref":"master","sha":"e708298ac25b22c3253fcc2d8bfa14fe9e8c3ae4","user":{"login":"linagora","id":1230365,"avatar_url":"https://avatars.githubusercontent.com/u/1230365?v=3","gravatar_id":"","url":"https://api.github.com/users/linagora","html_url":"https://github.com/linagora","followers_url":"https://api.github.com/users/linagora/followers","following_url":"https://api.github.com/users/linagora/following{/other_user}","gists_url":"https://api.github.com/users/linagora/gists{/gist_id}","starred_url":"https://api.github.com/users/linagora/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linagora/subscriptions","organizations_url":"https://api.github.com/users/linagora/orgs","repos_url":"https://api.github.com/users/linagora/repos","events_url":"https://api.github.com/users/linagora/events{/privacy}","received_events_url":"https://api.github.com/users/linagora/received_events","type":"Organization","site_admin":false},"repo":{"id":39182136,"name":"james-project","full_name":"linagora/james-project","owner":{"login":"linagora","id":1230365,"avatar_url":"https://avatars.githubusercontent.com/u/1230365?v=3","gravatar_id":"","url":"https://api.github.com/users/linagora","html_url":"https://github.com/linagora","followers_url":"https://api.github.com/users/linagora/followers","following_url":"https://api.github.com/users/linagora/following{/other_user}","gists_url":"https://api.github.com/users/linagora/gists{/gist_id}","starred_url":"https://api.github.com/users/linagora/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linagora/subscriptions","organizations_url":"https://api.github.com/users/linagora/orgs","repos_url":"https://api.github.com/users/linagora/repos","events_url":"https://api.github.com/users/linagora/events{/privacy}","received_events_url":"https://api.github.com/users/linagora/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/linagora/james-project","description":"Mirror of Apache James Project","fork":true,"url":"https://api.github.com/repos/linagora/james-project","forks_url":"https://api.github.com/repos/linagora/james-project/forks","keys_url":"https://api.github.com/repos/linagora/james-project/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linagora/james-project/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linagora/james-project/teams","hooks_url":"https://api.github.com/repos/linagora/james-project/hooks","issue_events_url":"https://api.github.com/repos/linagora/james-project/issues/events{/number}","events_url":"https://api.github.com/repos/linagora/james-project/events","assignees_url":"https://api.github.com/repos/linagora/james-project/assignees{/user}","branches_url":"https://api.github.com/repos/linagora/james-project/branches{/branch}","tags_url":"https://api.github.com/repos/linagora/james-project/tags","blobs_url":"https://api.github.com/repos/linagora/james-project/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linagora/james-project/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linagora/james-project/git/refs{/sha}","trees_url":"https://api.github.com/repos/linagora/james-project/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linagora/james-project/statuses/{sha}","languages_url":"https://api.github.com/repos/linagora/james-project/languages","stargazers_url":"https://api.github.com/repos/linagora/james-project/stargazers","contributors_url":"https://api.github.com/repos/linagora/james-project/contributors","subscribers_url":"https://api.github.com/repos/linagora/james-project/subscribers","subscription_url":"https://api.github.com/repos/linagora/james-project/subscription","commits_url":"https://api.github.com/repos/linagora/james-project/commits{/sha}","git_commits_url":"https://api.github.com/repos/linagora/james-project/git/commits{/sha}","comments_url":"https://api.github.com/repos/linagora/james-project/comments{/number}","issue_comment_url":"https://api.github.com/repos/linagora/james-project/issues/comments{/number}","contents_url":"https://api.github.com/repos/linagora/james-project/contents/{+path}","compare_url":"https://api.github.com/repos/linagora/james-project/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linagora/james-project/merges","archive_url":"https://api.github.com/repos/linagora/james-project/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linagora/james-project/downloads","issues_url":"https://api.github.com/repos/linagora/james-project/issues{/number}","pulls_url":"https://api.github.com/repos/linagora/james-project/pulls{/number}","milestones_url":"https://api.github.com/repos/linagora/james-project/milestones{/number}","notifications_url":"https://api.github.com/repos/linagora/james-project/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linagora/james-project/labels{/name}","releases_url":"https://api.github.com/repos/linagora/james-project/releases{/id}","deployments_url":"https://api.github.com/repos/linagora/james-project/deployments","created_at":"2015-07-16T07:04:59Z","updated_at":"2016-07-01T17:37:20Z","pushed_at":"2016-08-22T15:46:00Z","git_url":"git://github.com/linagora/james-project.git","ssh_url":"git@github.com:linagora/james-project.git","clone_url":"https://github.com/linagora/james-project.git","svn_url":"https://github.com/linagora/james-project","homepage":null,"size":15451,"stargazers_count":5,"watchers_count":5,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":21,"forks":8,"open_issues":21,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/linagora/james-project/pulls/366"},"html":{"href":"https://github.com/linagora/james-project/pull/366"},"issue":{"href":"https://api.github.com/repos/linagora/james-project/issues/366"},"comments":{"href":"https://api.github.com/repos/linagora/james-project/issues/366/comments"},"review_comments":{"href":"https://api.github.com/repos/linagora/james-project/pulls/366/comments"},"review_comment":{"href":"https://api.github.com/repos/linagora/james-project/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/linagora/james-project/pulls/366/commits"},"statuses":{"href":"https://api.github.com/repos/linagora/james-project/statuses/e7b60af48ccc8ec51768f1c05a691f0d937c1dcf"}}}}
{"actor":{"display_login":"Laura-Royet"}}