{"action":"created","issue":{"url":"https://api.github.com/repos/gemforce-team/wGemCombiner/issues/30","repository_url":"https://api.github.com/repos/gemforce-team/wGemCombiner","labels_url":"https://api.github.com/repos/gemforce-team/wGemCombiner/issues/30/labels{/name}","comments_url":"https://api.github.com/repos/gemforce-team/wGemCombiner/issues/30/comments","events_url":"https://api.github.com/repos/gemforce-team/wGemCombiner/issues/30/events","html_url":"https://github.com/gemforce-team/wGemCombiner/pull/30","id":140866802,"number":30,"title":"PR from Maikaifren.","user":{"login":"12345ieee","id":4094351,"avatar_url":"https://avatars.githubusercontent.com/u/4094351?v=3","gravatar_id":"","url":"https://api.github.com/users/12345ieee","html_url":"https://github.com/12345ieee","followers_url":"https://api.github.com/users/12345ieee/followers","following_url":"https://api.github.com/users/12345ieee/following{/other_user}","gists_url":"https://api.github.com/users/12345ieee/gists{/gist_id}","starred_url":"https://api.github.com/users/12345ieee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/12345ieee/subscriptions","organizations_url":"https://api.github.com/users/12345ieee/orgs","repos_url":"https://api.github.com/users/12345ieee/repos","events_url":"https://api.github.com/users/12345ieee/events{/privacy}","received_events_url":"https://api.github.com/users/12345ieee/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2016-03-15T04:12:05Z","updated_at":"2016-03-17T01:56:40Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/gemforce-team/wGemCombiner/pulls/30","html_url":"https://github.com/gemforce-team/wGemCombiner/pull/30","diff_url":"https://github.com/gemforce-team/wGemCombiner/pull/30.diff","patch_url":"https://github.com/gemforce-team/wGemCombiner/pull/30.patch"},"body":"This is the code I received from @Makaifren , from issue #29 .\r\nWe'll use this PR to review the changes made and to track new iterations.\r\n\r\n@Makaifren , I also need a good summary message for this commit."},"comment":{"url":"https://api.github.com/repos/gemforce-team/wGemCombiner/issues/comments/197648367","html_url":"https://github.com/gemforce-team/wGemCombiner/pull/30#issuecomment-197648367","issue_url":"https://api.github.com/repos/gemforce-team/wGemCombiner/issues/30","id":197648367,"user":{"login":"12345ieee","id":4094351,"avatar_url":"https://avatars.githubusercontent.com/u/4094351?v=3","gravatar_id":"","url":"https://api.github.com/users/12345ieee","html_url":"https://github.com/12345ieee","followers_url":"https://api.github.com/users/12345ieee/followers","following_url":"https://api.github.com/users/12345ieee/following{/other_user}","gists_url":"https://api.github.com/users/12345ieee/gists{/gist_id}","starred_url":"https://api.github.com/users/12345ieee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/12345ieee/subscriptions","organizations_url":"https://api.github.com/users/12345ieee/orgs","repos_url":"https://api.github.com/users/12345ieee/repos","events_url":"https://api.github.com/users/12345ieee/events{/privacy}","received_events_url":"https://api.github.com/users/12345ieee/received_events","type":"User","site_admin":false},"created_at":"2016-03-17T01:56:40Z","updated_at":"2016-03-17T01:56:40Z","body":"So, I had a skim at the code, I compiled it for @BilboCGL to test, but could not test it myself, due to issues with my system.\r\nI add I could also run it with mono, but haven't tested if it works, yet.\r\n\r\nI'm very impressed with the times @BilboCGL reports, a x2 drop in time needed is great and it's probably the framerate limit itself. Really great work, @Makaifren .\r\nI asked him to test it in harsher conditions, such as 80k monsters, let's see how it fares.\r\n\r\nSome suggestions/things to do.\r\n\r\n* Test on more OSes ( @BilboCGL covered for win10, not sure about @Makaifren )\r\n* Uniform spaces/tabs style (we used tabs till now, tabs will have to stay)\r\n* I'd like to have an explicit window that alerts me if a GC process is not found\r\n* It's not clear if the delay setting is still needed/functional\r\n* We need to get rid of all the extra delay things in the interface that are useless now.\r\n\r\nAnswers to @Makaifren emails:\r\n\r\n1. Don't bother implementing another method, <400 steps is nearly instantaneous anyway. Of course, if you could assure to never fill the queue, getting it to work for big ones could be interesting.\r\n2. Didn't know about the Firefox Flash protected mode (on linux it does not exist), we'll start recommending users to turn it off\r\n3. What bugs in the integrated recipes?\r\n4. A checkbox is pretty easy to do, just drag the checkboxes where you want them and then write the underlying method. The visual programming tab is your friend\r\n5. No use of '9' would be really a great addition, see if you have time.\r\n\r\nIf you want to keep contributing, @Makaifren , I can hook you up with a Steam key (privately), but I recommend you learn how to open a pull request yourself, so you can add your improvements here, where we all can review and discuss them.\r\n\r\n12345ieee out, goodnight.\r\n"}}