{"action":"created","comment":{"url":"https://api.github.com/repos/percona/percona-xtradb-cluster/pulls/comments/70062185","id":70062185,"diff_hunk":"@@ -210,7 +210,16 @@ This variable is used to control whether sole cluster conflicts should be logged\n    :dyn: Yes\n    :default: 131072 (128K) \n \n-This variable is used to control maximum number of rows each writeset can contain. Anything bigger than the specified value will be rejected.\n+**This variable has no effect!**\n+\n+By design,\n+it was supposed to control the maximum number of rows each writeset can contain.\n+However, it is hard to predict the number of rows\n+because of the writeset size limit enforced by :variable:`wsrep_max_ws_size`.\n+\n+Codership decided to not implement the limit by rows for now.\n+Correct behavior may be implemented in a future release.\n+There is a discussion open at https://github.com/codership/mysql-wsrep/issues/257\n ","path":"doc/source/wsrep-system-index.rst","position":15,"original_position":15,"commit_id":"fe55dea633cf68d9ce6dcb8aa69e9eee2fd553a4","original_commit_id":"fe55dea633cf68d9ce6dcb8aa69e9eee2fd553a4","user":{"login":"hrvojem","id":2334261,"avatar_url":"https://avatars.githubusercontent.com/u/2334261?v=3","gravatar_id":"","url":"https://api.github.com/users/hrvojem","html_url":"https://github.com/hrvojem","followers_url":"https://api.github.com/users/hrvojem/followers","following_url":"https://api.github.com/users/hrvojem/following{/other_user}","gists_url":"https://api.github.com/users/hrvojem/gists{/gist_id}","starred_url":"https://api.github.com/users/hrvojem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hrvojem/subscriptions","organizations_url":"https://api.github.com/users/hrvojem/orgs","repos_url":"https://api.github.com/users/hrvojem/repos","events_url":"https://api.github.com/users/hrvojem/events{/privacy}","received_events_url":"https://api.github.com/users/hrvojem/received_events","type":"User","site_admin":false},"body":"Maybe just swap the link with:\r\n`issue #257 <https://github.com/codership/mysql-wsrep/issues/257>`_\r\n","created_at":"2016-07-08T11:47:00Z","updated_at":"2016-07-08T11:47:00Z","html_url":"https://github.com/percona/percona-xtradb-cluster/pull/189#discussion_r70062185","pull_request_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/pulls/189","_links":{"self":{"href":"https://api.github.com/repos/percona/percona-xtradb-cluster/pulls/comments/70062185"},"html":{"href":"https://github.com/percona/percona-xtradb-cluster/pull/189#discussion_r70062185"},"pull_request":{"href":"https://api.github.com/repos/percona/percona-xtradb-cluster/pulls/189"}}},"pull_request":{"url":"https://api.github.com/repos/percona/percona-xtradb-cluster/pulls/189","id":76724662,"html_url":"https://github.com/percona/percona-xtradb-cluster/pull/189","diff_url":"https://github.com/percona/percona-xtradb-cluster/pull/189.diff","patch_url":"https://github.com/percona/percona-xtradb-cluster/pull/189.patch","issue_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/issues/189","number":189,"state":"open","locked":false,"title":"Updated description of wsrep_max_ws_rows stating that it does not work","user":{"login":"azhebel","id":11534933,"avatar_url":"https://avatars.githubusercontent.com/u/11534933?v=3","gravatar_id":"","url":"https://api.github.com/users/azhebel","html_url":"https://github.com/azhebel","followers_url":"https://api.github.com/users/azhebel/followers","following_url":"https://api.github.com/users/azhebel/following{/other_user}","gists_url":"https://api.github.com/users/azhebel/gists{/gist_id}","starred_url":"https://api.github.com/users/azhebel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azhebel/subscriptions","organizations_url":"https://api.github.com/users/azhebel/orgs","repos_url":"https://api.github.com/users/azhebel/repos","events_url":"https://api.github.com/users/azhebel/events{/privacy}","received_events_url":"https://api.github.com/users/azhebel/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-07-08T09:26:29Z","updated_at":"2016-07-08T11:47:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c0c850dbffd77c7eec3680f4b31716d0adf4e453","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/pulls/189/commits","review_comments_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/pulls/189/comments","review_comment_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/pulls/comments{/number}","comments_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/issues/189/comments","statuses_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/statuses/fe55dea633cf68d9ce6dcb8aa69e9eee2fd553a4","head":{"label":"percona:max-ws-rows-doc-56","ref":"max-ws-rows-doc-56","sha":"fe55dea633cf68d9ce6dcb8aa69e9eee2fd553a4","user":{"login":"percona","id":1683025,"avatar_url":"https://avatars.githubusercontent.com/u/1683025?v=3","gravatar_id":"","url":"https://api.github.com/users/percona","html_url":"https://github.com/percona","followers_url":"https://api.github.com/users/percona/followers","following_url":"https://api.github.com/users/percona/following{/other_user}","gists_url":"https://api.github.com/users/percona/gists{/gist_id}","starred_url":"https://api.github.com/users/percona/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/percona/subscriptions","organizations_url":"https://api.github.com/users/percona/orgs","repos_url":"https://api.github.com/users/percona/repos","events_url":"https://api.github.com/users/percona/events{/privacy}","received_events_url":"https://api.github.com/users/percona/received_events","type":"Organization","site_admin":false},"repo":{"id":30753937,"name":"percona-xtradb-cluster","full_name":"percona/percona-xtradb-cluster","owner":{"login":"percona","id":1683025,"avatar_url":"https://avatars.githubusercontent.com/u/1683025?v=3","gravatar_id":"","url":"https://api.github.com/users/percona","html_url":"https://github.com/percona","followers_url":"https://api.github.com/users/percona/followers","following_url":"https://api.github.com/users/percona/following{/other_user}","gists_url":"https://api.github.com/users/percona/gists{/gist_id}","starred_url":"https://api.github.com/users/percona/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/percona/subscriptions","organizations_url":"https://api.github.com/users/percona/orgs","repos_url":"https://api.github.com/users/percona/repos","events_url":"https://api.github.com/users/percona/events{/privacy}","received_events_url":"https://api.github.com/users/percona/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/percona/percona-xtradb-cluster","description":"A High Scalability Solution for MySQL Clustering and High Availability","fork":false,"url":"https://api.github.com/repos/percona/percona-xtradb-cluster","forks_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/forks","keys_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/keys{/key_id}","collaborators_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/teams","hooks_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/hooks","issue_events_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/issues/events{/number}","events_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/events","assignees_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/assignees{/user}","branches_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/branches{/branch}","tags_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/tags","blobs_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/git/refs{/sha}","trees_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/git/trees{/sha}","statuses_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/statuses/{sha}","languages_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/languages","stargazers_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/stargazers","contributors_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/contributors","subscribers_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/subscribers","subscription_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/subscription","commits_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/commits{/sha}","git_commits_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/git/commits{/sha}","comments_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/comments{/number}","issue_comment_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/issues/comments{/number}","contents_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/contents/{+path}","compare_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/compare/{base}...{head}","merges_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/merges","archive_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/downloads","issues_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/issues{/number}","pulls_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/pulls{/number}","milestones_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/milestones{/number}","notifications_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/labels{/name}","releases_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/releases{/id}","deployments_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/deployments","created_at":"2015-02-13T11:39:22Z","updated_at":"2016-07-07T12:05:03Z","pushed_at":"2016-07-08T11:38:01Z","git_url":"git://github.com/percona/percona-xtradb-cluster.git","ssh_url":"git@github.com:percona/percona-xtradb-cluster.git","clone_url":"https://github.com/percona/percona-xtradb-cluster.git","svn_url":"https://github.com/percona/percona-xtradb-cluster","homepage":"http://www.percona.com/software/percona-xtradb-cluster","size":480564,"stargazers_count":45,"watchers_count":45,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":27,"mirror_url":null,"open_issues_count":8,"forks":27,"open_issues":8,"watchers":45,"default_branch":"5.6"}},"base":{"label":"percona:5.6","ref":"5.6","sha":"10a1f1686b545f3db37b16b90ceb33c5f3aa4f50","user":{"login":"percona","id":1683025,"avatar_url":"https://avatars.githubusercontent.com/u/1683025?v=3","gravatar_id":"","url":"https://api.github.com/users/percona","html_url":"https://github.com/percona","followers_url":"https://api.github.com/users/percona/followers","following_url":"https://api.github.com/users/percona/following{/other_user}","gists_url":"https://api.github.com/users/percona/gists{/gist_id}","starred_url":"https://api.github.com/users/percona/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/percona/subscriptions","organizations_url":"https://api.github.com/users/percona/orgs","repos_url":"https://api.github.com/users/percona/repos","events_url":"https://api.github.com/users/percona/events{/privacy}","received_events_url":"https://api.github.com/users/percona/received_events","type":"Organization","site_admin":false},"repo":{"id":30753937,"name":"percona-xtradb-cluster","full_name":"percona/percona-xtradb-cluster","owner":{"login":"percona","id":1683025,"avatar_url":"https://avatars.githubusercontent.com/u/1683025?v=3","gravatar_id":"","url":"https://api.github.com/users/percona","html_url":"https://github.com/percona","followers_url":"https://api.github.com/users/percona/followers","following_url":"https://api.github.com/users/percona/following{/other_user}","gists_url":"https://api.github.com/users/percona/gists{/gist_id}","starred_url":"https://api.github.com/users/percona/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/percona/subscriptions","organizations_url":"https://api.github.com/users/percona/orgs","repos_url":"https://api.github.com/users/percona/repos","events_url":"https://api.github.com/users/percona/events{/privacy}","received_events_url":"https://api.github.com/users/percona/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/percona/percona-xtradb-cluster","description":"A High Scalability Solution for MySQL Clustering and High Availability","fork":false,"url":"https://api.github.com/repos/percona/percona-xtradb-cluster","forks_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/forks","keys_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/keys{/key_id}","collaborators_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/teams","hooks_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/hooks","issue_events_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/issues/events{/number}","events_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/events","assignees_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/assignees{/user}","branches_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/branches{/branch}","tags_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/tags","blobs_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/git/refs{/sha}","trees_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/git/trees{/sha}","statuses_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/statuses/{sha}","languages_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/languages","stargazers_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/stargazers","contributors_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/contributors","subscribers_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/subscribers","subscription_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/subscription","commits_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/commits{/sha}","git_commits_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/git/commits{/sha}","comments_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/comments{/number}","issue_comment_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/issues/comments{/number}","contents_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/contents/{+path}","compare_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/compare/{base}...{head}","merges_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/merges","archive_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/downloads","issues_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/issues{/number}","pulls_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/pulls{/number}","milestones_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/milestones{/number}","notifications_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/labels{/name}","releases_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/releases{/id}","deployments_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/deployments","created_at":"2015-02-13T11:39:22Z","updated_at":"2016-07-07T12:05:03Z","pushed_at":"2016-07-08T11:38:01Z","git_url":"git://github.com/percona/percona-xtradb-cluster.git","ssh_url":"git@github.com:percona/percona-xtradb-cluster.git","clone_url":"https://github.com/percona/percona-xtradb-cluster.git","svn_url":"https://github.com/percona/percona-xtradb-cluster","homepage":"http://www.percona.com/software/percona-xtradb-cluster","size":480564,"stargazers_count":45,"watchers_count":45,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":27,"mirror_url":null,"open_issues_count":8,"forks":27,"open_issues":8,"watchers":45,"default_branch":"5.6"}},"_links":{"self":{"href":"https://api.github.com/repos/percona/percona-xtradb-cluster/pulls/189"},"html":{"href":"https://github.com/percona/percona-xtradb-cluster/pull/189"},"issue":{"href":"https://api.github.com/repos/percona/percona-xtradb-cluster/issues/189"},"comments":{"href":"https://api.github.com/repos/percona/percona-xtradb-cluster/issues/189/comments"},"review_comments":{"href":"https://api.github.com/repos/percona/percona-xtradb-cluster/pulls/189/comments"},"review_comment":{"href":"https://api.github.com/repos/percona/percona-xtradb-cluster/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/percona/percona-xtradb-cluster/pulls/189/commits"},"statuses":{"href":"https://api.github.com/repos/percona/percona-xtradb-cluster/statuses/fe55dea633cf68d9ce6dcb8aa69e9eee2fd553a4"}}}}
{"actor":{"display_login":"hrvojem"}}