{"action":"closed","number":121,"pull_request":{"url":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/pulls/121","id":87787793,"html_url":"https://github.com/pburtchaell/redux-promise-middleware/pull/121","diff_url":"https://github.com/pburtchaell/redux-promise-middleware/pull/121.diff","patch_url":"https://github.com/pburtchaell/redux-promise-middleware/pull/121.patch","issue_url":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/issues/121","number":121,"state":"closed","locked":false,"title":"Allow payloads of `0` or `false`","user":{"login":"randycoulman","id":1406203,"avatar_url":"https://avatars.githubusercontent.com/u/1406203?v=3","gravatar_id":"","url":"https://api.github.com/users/randycoulman","html_url":"https://github.com/randycoulman","followers_url":"https://api.github.com/users/randycoulman/followers","following_url":"https://api.github.com/users/randycoulman/following{/other_user}","gists_url":"https://api.github.com/users/randycoulman/gists{/gist_id}","starred_url":"https://api.github.com/users/randycoulman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/randycoulman/subscriptions","organizations_url":"https://api.github.com/users/randycoulman/orgs","repos_url":"https://api.github.com/users/randycoulman/repos","events_url":"https://api.github.com/users/randycoulman/events{/privacy}","received_events_url":"https://api.github.com/users/randycoulman/received_events","type":"User","site_admin":false},"body":"When a Promise resolves with a value of `0` or `false`, include that value as the `payload` property of the `FULFILLED` action.\n\nThe existing code omits the payload if it is any “falsy” value, which includes `null`, `undefined`, `0`, and `false`.\n\nWith this change, `null` and `undefined` payloads are still omitted, but `0` and `false` payloads are passed along with the `FULFILLED` action.\n\nA slightly more idiomatic check for a `null` or `undefined` payload would be `newPayload == null`, but that is disallowed by the lint configuration.\n\nI’ve added new specs for these cases, but they’re very similar to each other and have a fair bit of duplication with the `null` spec.  I wasn’t sure what you might want to do to clean that up.","created_at":"2016-10-03T20:42:13Z","updated_at":"2016-10-08T16:01:07Z","closed_at":"2016-10-08T16:01:07Z","merged_at":"2016-10-08T16:01:07Z","merge_commit_sha":"34241c3fbef7b2fb86a64df9b07a331e10b72369","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/pulls/121/commits","review_comments_url":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/pulls/121/comments","review_comment_url":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/issues/121/comments","statuses_url":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/statuses/7a8e80ad8373aa03de6e6707d7a548be00a7edb9","head":{"label":"CodingZeal:falsy-payloads","ref":"falsy-payloads","sha":"7a8e80ad8373aa03de6e6707d7a548be00a7edb9","user":{"login":"CodingZeal","id":3019646,"avatar_url":"https://avatars.githubusercontent.com/u/3019646?v=3","gravatar_id":"","url":"https://api.github.com/users/CodingZeal","html_url":"https://github.com/CodingZeal","followers_url":"https://api.github.com/users/CodingZeal/followers","following_url":"https://api.github.com/users/CodingZeal/following{/other_user}","gists_url":"https://api.github.com/users/CodingZeal/gists{/gist_id}","starred_url":"https://api.github.com/users/CodingZeal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CodingZeal/subscriptions","organizations_url":"https://api.github.com/users/CodingZeal/orgs","repos_url":"https://api.github.com/users/CodingZeal/repos","events_url":"https://api.github.com/users/CodingZeal/events{/privacy}","received_events_url":"https://api.github.com/users/CodingZeal/received_events","type":"Organization","site_admin":false},"repo":{"id":69907162,"name":"redux-promise-middleware","full_name":"CodingZeal/redux-promise-middleware","owner":{"login":"CodingZeal","id":3019646,"avatar_url":"https://avatars.githubusercontent.com/u/3019646?v=3","gravatar_id":"","url":"https://api.github.com/users/CodingZeal","html_url":"https://github.com/CodingZeal","followers_url":"https://api.github.com/users/CodingZeal/followers","following_url":"https://api.github.com/users/CodingZeal/following{/other_user}","gists_url":"https://api.github.com/users/CodingZeal/gists{/gist_id}","starred_url":"https://api.github.com/users/CodingZeal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CodingZeal/subscriptions","organizations_url":"https://api.github.com/users/CodingZeal/orgs","repos_url":"https://api.github.com/users/CodingZeal/repos","events_url":"https://api.github.com/users/CodingZeal/events{/privacy}","received_events_url":"https://api.github.com/users/CodingZeal/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CodingZeal/redux-promise-middleware","description":"Redux middleware for resolving and rejecting promises with conditional optimistic updates","fork":true,"url":"https://api.github.com/repos/CodingZeal/redux-promise-middleware","forks_url":"https://api.github.com/repos/CodingZeal/redux-promise-middleware/forks","keys_url":"https://api.github.com/repos/CodingZeal/redux-promise-middleware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CodingZeal/redux-promise-middleware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CodingZeal/redux-promise-middleware/teams","hooks_url":"https://api.github.com/repos/CodingZeal/redux-promise-middleware/hooks","issue_events_url":"https://api.github.com/repos/CodingZeal/redux-promise-middleware/issues/events{/number}","events_url":"https://api.github.com/repos/CodingZeal/redux-promise-middleware/events","assignees_url":"https://api.github.com/repos/CodingZeal/redux-promise-middleware/assignees{/user}","branches_url":"https://api.github.com/repos/CodingZeal/redux-promise-middleware/branches{/branch}","tags_url":"https://api.github.com/repos/CodingZeal/redux-promise-middleware/tags","blobs_url":"https://api.github.com/repos/CodingZeal/redux-promise-middleware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CodingZeal/redux-promise-middleware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CodingZeal/redux-promise-middleware/git/refs{/sha}","trees_url":"https://api.github.com/repos/CodingZeal/redux-promise-middleware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CodingZeal/redux-promise-middleware/statuses/{sha}","languages_url":"https://api.github.com/repos/CodingZeal/redux-promise-middleware/languages","stargazers_url":"https://api.github.com/repos/CodingZeal/redux-promise-middleware/stargazers","contributors_url":"https://api.github.com/repos/CodingZeal/redux-promise-middleware/contributors","subscribers_url":"https://api.github.com/repos/CodingZeal/redux-promise-middleware/subscribers","subscription_url":"https://api.github.com/repos/CodingZeal/redux-promise-middleware/subscription","commits_url":"https://api.github.com/repos/CodingZeal/redux-promise-middleware/commits{/sha}","git_commits_url":"https://api.github.com/repos/CodingZeal/redux-promise-middleware/git/commits{/sha}","comments_url":"https://api.github.com/repos/CodingZeal/redux-promise-middleware/comments{/number}","issue_comment_url":"https://api.github.com/repos/CodingZeal/redux-promise-middleware/issues/comments{/number}","contents_url":"https://api.github.com/repos/CodingZeal/redux-promise-middleware/contents/{+path}","compare_url":"https://api.github.com/repos/CodingZeal/redux-promise-middleware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CodingZeal/redux-promise-middleware/merges","archive_url":"https://api.github.com/repos/CodingZeal/redux-promise-middleware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CodingZeal/redux-promise-middleware/downloads","issues_url":"https://api.github.com/repos/CodingZeal/redux-promise-middleware/issues{/number}","pulls_url":"https://api.github.com/repos/CodingZeal/redux-promise-middleware/pulls{/number}","milestones_url":"https://api.github.com/repos/CodingZeal/redux-promise-middleware/milestones{/number}","notifications_url":"https://api.github.com/repos/CodingZeal/redux-promise-middleware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CodingZeal/redux-promise-middleware/labels{/name}","releases_url":"https://api.github.com/repos/CodingZeal/redux-promise-middleware/releases{/id}","deployments_url":"https://api.github.com/repos/CodingZeal/redux-promise-middleware/deployments","created_at":"2016-10-03T20:13:18Z","updated_at":"2016-10-03T20:13:20Z","pushed_at":"2016-10-08T15:42:37Z","git_url":"git://github.com/CodingZeal/redux-promise-middleware.git","ssh_url":"git@github.com:CodingZeal/redux-promise-middleware.git","clone_url":"https://github.com/CodingZeal/redux-promise-middleware.git","svn_url":"https://github.com/CodingZeal/redux-promise-middleware","homepage":"","size":191,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pburtchaell:master","ref":"master","sha":"58504797c11efde49437d0a56e42c4ccf7330510","user":{"login":"pburtchaell","id":3857324,"avatar_url":"https://avatars.githubusercontent.com/u/3857324?v=3","gravatar_id":"","url":"https://api.github.com/users/pburtchaell","html_url":"https://github.com/pburtchaell","followers_url":"https://api.github.com/users/pburtchaell/followers","following_url":"https://api.github.com/users/pburtchaell/following{/other_user}","gists_url":"https://api.github.com/users/pburtchaell/gists{/gist_id}","starred_url":"https://api.github.com/users/pburtchaell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pburtchaell/subscriptions","organizations_url":"https://api.github.com/users/pburtchaell/orgs","repos_url":"https://api.github.com/users/pburtchaell/repos","events_url":"https://api.github.com/users/pburtchaell/events{/privacy}","received_events_url":"https://api.github.com/users/pburtchaell/received_events","type":"User","site_admin":false},"repo":{"id":38990306,"name":"redux-promise-middleware","full_name":"pburtchaell/redux-promise-middleware","owner":{"login":"pburtchaell","id":3857324,"avatar_url":"https://avatars.githubusercontent.com/u/3857324?v=3","gravatar_id":"","url":"https://api.github.com/users/pburtchaell","html_url":"https://github.com/pburtchaell","followers_url":"https://api.github.com/users/pburtchaell/followers","following_url":"https://api.github.com/users/pburtchaell/following{/other_user}","gists_url":"https://api.github.com/users/pburtchaell/gists{/gist_id}","starred_url":"https://api.github.com/users/pburtchaell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pburtchaell/subscriptions","organizations_url":"https://api.github.com/users/pburtchaell/orgs","repos_url":"https://api.github.com/users/pburtchaell/repos","events_url":"https://api.github.com/users/pburtchaell/events{/privacy}","received_events_url":"https://api.github.com/users/pburtchaell/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pburtchaell/redux-promise-middleware","description":"Redux middleware for resolving and rejecting promises with conditional optimistic updates","fork":false,"url":"https://api.github.com/repos/pburtchaell/redux-promise-middleware","forks_url":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/forks","keys_url":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/teams","hooks_url":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/hooks","issue_events_url":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/issues/events{/number}","events_url":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/events","assignees_url":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/assignees{/user}","branches_url":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/branches{/branch}","tags_url":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/tags","blobs_url":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/git/refs{/sha}","trees_url":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/statuses/{sha}","languages_url":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/languages","stargazers_url":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/stargazers","contributors_url":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/contributors","subscribers_url":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/subscribers","subscription_url":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/subscription","commits_url":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/commits{/sha}","git_commits_url":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/git/commits{/sha}","comments_url":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/comments{/number}","issue_comment_url":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/issues/comments{/number}","contents_url":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/contents/{+path}","compare_url":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/merges","archive_url":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/downloads","issues_url":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/issues{/number}","pulls_url":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/pulls{/number}","milestones_url":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/milestones{/number}","notifications_url":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/labels{/name}","releases_url":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/releases{/id}","deployments_url":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/deployments","created_at":"2015-07-13T03:55:34Z","updated_at":"2016-10-04T19:06:17Z","pushed_at":"2016-10-08T16:01:07Z","git_url":"git://github.com/pburtchaell/redux-promise-middleware.git","ssh_url":"git@github.com:pburtchaell/redux-promise-middleware.git","clone_url":"https://github.com/pburtchaell/redux-promise-middleware.git","svn_url":"https://github.com/pburtchaell/redux-promise-middleware","homepage":"","size":214,"stargazers_count":566,"watchers_count":566,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":58,"mirror_url":null,"open_issues_count":2,"forks":58,"open_issues":2,"watchers":566,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/pulls/121"},"html":{"href":"https://github.com/pburtchaell/redux-promise-middleware/pull/121"},"issue":{"href":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/issues/121"},"comments":{"href":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/issues/121/comments"},"review_comments":{"href":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/pulls/121/comments"},"review_comment":{"href":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/pulls/121/commits"},"statuses":{"href":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/statuses/7a8e80ad8373aa03de6e6707d7a548be00a7edb9"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"pburtchaell","id":3857324,"avatar_url":"https://avatars.githubusercontent.com/u/3857324?v=3","gravatar_id":"","url":"https://api.github.com/users/pburtchaell","html_url":"https://github.com/pburtchaell","followers_url":"https://api.github.com/users/pburtchaell/followers","following_url":"https://api.github.com/users/pburtchaell/following{/other_user}","gists_url":"https://api.github.com/users/pburtchaell/gists{/gist_id}","starred_url":"https://api.github.com/users/pburtchaell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pburtchaell/subscriptions","organizations_url":"https://api.github.com/users/pburtchaell/orgs","repos_url":"https://api.github.com/users/pburtchaell/repos","events_url":"https://api.github.com/users/pburtchaell/events{/privacy}","received_events_url":"https://api.github.com/users/pburtchaell/received_events","type":"User","site_admin":false},"comments":10,"review_comments":0,"commits":1,"additions":114,"deletions":2,"changed_files":2}}
{"actor":{"display_login":"pburtchaell"}}