{"action":"closed","number":7,"pull_request":{"url":"https://api.github.com/repos/tcbrindle/modern-io/pulls/7","id":76268747,"html_url":"https://github.com/tcbrindle/modern-io/pull/7","diff_url":"https://github.com/tcbrindle/modern-io/pull/7.diff","patch_url":"https://github.com/tcbrindle/modern-io/pull/7.patch","issue_url":"https://api.github.com/repos/tcbrindle/modern-io/issues/7","number":7,"state":"closed","locked":false,"title":"Add io::windows::file implementation","user":{"login":"tcbrindle","id":3750068,"avatar_url":"https://avatars.githubusercontent.com/u/3750068?v=3","gravatar_id":"","url":"https://api.github.com/users/tcbrindle","html_url":"https://github.com/tcbrindle","followers_url":"https://api.github.com/users/tcbrindle/followers","following_url":"https://api.github.com/users/tcbrindle/following{/other_user}","gists_url":"https://api.github.com/users/tcbrindle/gists{/gist_id}","starred_url":"https://api.github.com/users/tcbrindle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tcbrindle/subscriptions","organizations_url":"https://api.github.com/users/tcbrindle/orgs","repos_url":"https://api.github.com/users/tcbrindle/repos","events_url":"https://api.github.com/users/tcbrindle/events{/privacy}","received_events_url":"https://api.github.com/users/tcbrindle/received_events","type":"User","site_admin":false},"body":"This implementation uses the Win32 API functions CreateFile(), ReadFile() WriteFile() etc to model the File concept.\n\nIt compiles with MinGW and MSVC/Clang, but not with pure MSVC (more to do with Ranges than anything else I think).\n\nThe MinGW version requires boost::filesystem, and the MSVC version needs boost::string_view, which is now included. Hopefully both of these can go away in time.\n\nThere are also a few other changes to handle all the Posix assumptions we’ve been making to date.","created_at":"2016-07-05T12:54:24Z","updated_at":"2016-07-05T13:24:22Z","closed_at":"2016-07-05T13:24:22Z","merged_at":"2016-07-05T13:24:22Z","merge_commit_sha":"b5777d01a692db7af2ad7424ff46bf1d11cbb6b0","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/tcbrindle/modern-io/pulls/7/commits","review_comments_url":"https://api.github.com/repos/tcbrindle/modern-io/pulls/7/comments","review_comment_url":"https://api.github.com/repos/tcbrindle/modern-io/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tcbrindle/modern-io/issues/7/comments","statuses_url":"https://api.github.com/repos/tcbrindle/modern-io/statuses/558301a09a98e22335abe2e72cfc1795b4617764","head":{"label":"tcbrindle:pr/windows-file","ref":"pr/windows-file","sha":"558301a09a98e22335abe2e72cfc1795b4617764","user":{"login":"tcbrindle","id":3750068,"avatar_url":"https://avatars.githubusercontent.com/u/3750068?v=3","gravatar_id":"","url":"https://api.github.com/users/tcbrindle","html_url":"https://github.com/tcbrindle","followers_url":"https://api.github.com/users/tcbrindle/followers","following_url":"https://api.github.com/users/tcbrindle/following{/other_user}","gists_url":"https://api.github.com/users/tcbrindle/gists{/gist_id}","starred_url":"https://api.github.com/users/tcbrindle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tcbrindle/subscriptions","organizations_url":"https://api.github.com/users/tcbrindle/orgs","repos_url":"https://api.github.com/users/tcbrindle/repos","events_url":"https://api.github.com/users/tcbrindle/events{/privacy}","received_events_url":"https://api.github.com/users/tcbrindle/received_events","type":"User","site_admin":false},"repo":{"id":60670838,"name":"modern-io","full_name":"tcbrindle/modern-io","owner":{"login":"tcbrindle","id":3750068,"avatar_url":"https://avatars.githubusercontent.com/u/3750068?v=3","gravatar_id":"","url":"https://api.github.com/users/tcbrindle","html_url":"https://github.com/tcbrindle","followers_url":"https://api.github.com/users/tcbrindle/followers","following_url":"https://api.github.com/users/tcbrindle/following{/other_user}","gists_url":"https://api.github.com/users/tcbrindle/gists{/gist_id}","starred_url":"https://api.github.com/users/tcbrindle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tcbrindle/subscriptions","organizations_url":"https://api.github.com/users/tcbrindle/orgs","repos_url":"https://api.github.com/users/tcbrindle/repos","events_url":"https://api.github.com/users/tcbrindle/events{/privacy}","received_events_url":"https://api.github.com/users/tcbrindle/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tcbrindle/modern-io","description":"Modern IO library for C++","fork":false,"url":"https://api.github.com/repos/tcbrindle/modern-io","forks_url":"https://api.github.com/repos/tcbrindle/modern-io/forks","keys_url":"https://api.github.com/repos/tcbrindle/modern-io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tcbrindle/modern-io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tcbrindle/modern-io/teams","hooks_url":"https://api.github.com/repos/tcbrindle/modern-io/hooks","issue_events_url":"https://api.github.com/repos/tcbrindle/modern-io/issues/events{/number}","events_url":"https://api.github.com/repos/tcbrindle/modern-io/events","assignees_url":"https://api.github.com/repos/tcbrindle/modern-io/assignees{/user}","branches_url":"https://api.github.com/repos/tcbrindle/modern-io/branches{/branch}","tags_url":"https://api.github.com/repos/tcbrindle/modern-io/tags","blobs_url":"https://api.github.com/repos/tcbrindle/modern-io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tcbrindle/modern-io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tcbrindle/modern-io/git/refs{/sha}","trees_url":"https://api.github.com/repos/tcbrindle/modern-io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tcbrindle/modern-io/statuses/{sha}","languages_url":"https://api.github.com/repos/tcbrindle/modern-io/languages","stargazers_url":"https://api.github.com/repos/tcbrindle/modern-io/stargazers","contributors_url":"https://api.github.com/repos/tcbrindle/modern-io/contributors","subscribers_url":"https://api.github.com/repos/tcbrindle/modern-io/subscribers","subscription_url":"https://api.github.com/repos/tcbrindle/modern-io/subscription","commits_url":"https://api.github.com/repos/tcbrindle/modern-io/commits{/sha}","git_commits_url":"https://api.github.com/repos/tcbrindle/modern-io/git/commits{/sha}","comments_url":"https://api.github.com/repos/tcbrindle/modern-io/comments{/number}","issue_comment_url":"https://api.github.com/repos/tcbrindle/modern-io/issues/comments{/number}","contents_url":"https://api.github.com/repos/tcbrindle/modern-io/contents/{+path}","compare_url":"https://api.github.com/repos/tcbrindle/modern-io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tcbrindle/modern-io/merges","archive_url":"https://api.github.com/repos/tcbrindle/modern-io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tcbrindle/modern-io/downloads","issues_url":"https://api.github.com/repos/tcbrindle/modern-io/issues{/number}","pulls_url":"https://api.github.com/repos/tcbrindle/modern-io/pulls{/number}","milestones_url":"https://api.github.com/repos/tcbrindle/modern-io/milestones{/number}","notifications_url":"https://api.github.com/repos/tcbrindle/modern-io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tcbrindle/modern-io/labels{/name}","releases_url":"https://api.github.com/repos/tcbrindle/modern-io/releases{/id}","deployments_url":"https://api.github.com/repos/tcbrindle/modern-io/deployments","created_at":"2016-06-08T05:27:39Z","updated_at":"2016-06-18T07:10:28Z","pushed_at":"2016-07-05T13:24:22Z","git_url":"git://github.com/tcbrindle/modern-io.git","ssh_url":"git@github.com:tcbrindle/modern-io.git","clone_url":"https://github.com/tcbrindle/modern-io.git","svn_url":"https://github.com/tcbrindle/modern-io","homepage":null,"size":184,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"tcbrindle:master","ref":"master","sha":"12782113fe6d056b998b9c8c174d1459405d2bbf","user":{"login":"tcbrindle","id":3750068,"avatar_url":"https://avatars.githubusercontent.com/u/3750068?v=3","gravatar_id":"","url":"https://api.github.com/users/tcbrindle","html_url":"https://github.com/tcbrindle","followers_url":"https://api.github.com/users/tcbrindle/followers","following_url":"https://api.github.com/users/tcbrindle/following{/other_user}","gists_url":"https://api.github.com/users/tcbrindle/gists{/gist_id}","starred_url":"https://api.github.com/users/tcbrindle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tcbrindle/subscriptions","organizations_url":"https://api.github.com/users/tcbrindle/orgs","repos_url":"https://api.github.com/users/tcbrindle/repos","events_url":"https://api.github.com/users/tcbrindle/events{/privacy}","received_events_url":"https://api.github.com/users/tcbrindle/received_events","type":"User","site_admin":false},"repo":{"id":60670838,"name":"modern-io","full_name":"tcbrindle/modern-io","owner":{"login":"tcbrindle","id":3750068,"avatar_url":"https://avatars.githubusercontent.com/u/3750068?v=3","gravatar_id":"","url":"https://api.github.com/users/tcbrindle","html_url":"https://github.com/tcbrindle","followers_url":"https://api.github.com/users/tcbrindle/followers","following_url":"https://api.github.com/users/tcbrindle/following{/other_user}","gists_url":"https://api.github.com/users/tcbrindle/gists{/gist_id}","starred_url":"https://api.github.com/users/tcbrindle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tcbrindle/subscriptions","organizations_url":"https://api.github.com/users/tcbrindle/orgs","repos_url":"https://api.github.com/users/tcbrindle/repos","events_url":"https://api.github.com/users/tcbrindle/events{/privacy}","received_events_url":"https://api.github.com/users/tcbrindle/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tcbrindle/modern-io","description":"Modern IO library for C++","fork":false,"url":"https://api.github.com/repos/tcbrindle/modern-io","forks_url":"https://api.github.com/repos/tcbrindle/modern-io/forks","keys_url":"https://api.github.com/repos/tcbrindle/modern-io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tcbrindle/modern-io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tcbrindle/modern-io/teams","hooks_url":"https://api.github.com/repos/tcbrindle/modern-io/hooks","issue_events_url":"https://api.github.com/repos/tcbrindle/modern-io/issues/events{/number}","events_url":"https://api.github.com/repos/tcbrindle/modern-io/events","assignees_url":"https://api.github.com/repos/tcbrindle/modern-io/assignees{/user}","branches_url":"https://api.github.com/repos/tcbrindle/modern-io/branches{/branch}","tags_url":"https://api.github.com/repos/tcbrindle/modern-io/tags","blobs_url":"https://api.github.com/repos/tcbrindle/modern-io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tcbrindle/modern-io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tcbrindle/modern-io/git/refs{/sha}","trees_url":"https://api.github.com/repos/tcbrindle/modern-io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tcbrindle/modern-io/statuses/{sha}","languages_url":"https://api.github.com/repos/tcbrindle/modern-io/languages","stargazers_url":"https://api.github.com/repos/tcbrindle/modern-io/stargazers","contributors_url":"https://api.github.com/repos/tcbrindle/modern-io/contributors","subscribers_url":"https://api.github.com/repos/tcbrindle/modern-io/subscribers","subscription_url":"https://api.github.com/repos/tcbrindle/modern-io/subscription","commits_url":"https://api.github.com/repos/tcbrindle/modern-io/commits{/sha}","git_commits_url":"https://api.github.com/repos/tcbrindle/modern-io/git/commits{/sha}","comments_url":"https://api.github.com/repos/tcbrindle/modern-io/comments{/number}","issue_comment_url":"https://api.github.com/repos/tcbrindle/modern-io/issues/comments{/number}","contents_url":"https://api.github.com/repos/tcbrindle/modern-io/contents/{+path}","compare_url":"https://api.github.com/repos/tcbrindle/modern-io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tcbrindle/modern-io/merges","archive_url":"https://api.github.com/repos/tcbrindle/modern-io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tcbrindle/modern-io/downloads","issues_url":"https://api.github.com/repos/tcbrindle/modern-io/issues{/number}","pulls_url":"https://api.github.com/repos/tcbrindle/modern-io/pulls{/number}","milestones_url":"https://api.github.com/repos/tcbrindle/modern-io/milestones{/number}","notifications_url":"https://api.github.com/repos/tcbrindle/modern-io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tcbrindle/modern-io/labels{/name}","releases_url":"https://api.github.com/repos/tcbrindle/modern-io/releases{/id}","deployments_url":"https://api.github.com/repos/tcbrindle/modern-io/deployments","created_at":"2016-06-08T05:27:39Z","updated_at":"2016-06-18T07:10:28Z","pushed_at":"2016-07-05T13:24:22Z","git_url":"git://github.com/tcbrindle/modern-io.git","ssh_url":"git@github.com:tcbrindle/modern-io.git","clone_url":"https://github.com/tcbrindle/modern-io.git","svn_url":"https://github.com/tcbrindle/modern-io","homepage":null,"size":184,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tcbrindle/modern-io/pulls/7"},"html":{"href":"https://github.com/tcbrindle/modern-io/pull/7"},"issue":{"href":"https://api.github.com/repos/tcbrindle/modern-io/issues/7"},"comments":{"href":"https://api.github.com/repos/tcbrindle/modern-io/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/tcbrindle/modern-io/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/tcbrindle/modern-io/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tcbrindle/modern-io/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/tcbrindle/modern-io/statuses/558301a09a98e22335abe2e72cfc1795b4617764"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"tcbrindle","id":3750068,"avatar_url":"https://avatars.githubusercontent.com/u/3750068?v=3","gravatar_id":"","url":"https://api.github.com/users/tcbrindle","html_url":"https://github.com/tcbrindle","followers_url":"https://api.github.com/users/tcbrindle/followers","following_url":"https://api.github.com/users/tcbrindle/following{/other_user}","gists_url":"https://api.github.com/users/tcbrindle/gists{/gist_id}","starred_url":"https://api.github.com/users/tcbrindle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tcbrindle/subscriptions","organizations_url":"https://api.github.com/users/tcbrindle/orgs","repos_url":"https://api.github.com/users/tcbrindle/repos","events_url":"https://api.github.com/users/tcbrindle/events{/privacy}","received_events_url":"https://api.github.com/users/tcbrindle/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":13,"additions":1074,"deletions":39,"changed_files":17}}
{"actor":{"display_login":"tcbrindle"}}