{"action":"created","issue":{"url":"https://api.github.com/repos/gmurt/KernowSoftwareFMX/issues/93","repository_url":"https://api.github.com/repos/gmurt/KernowSoftwareFMX","labels_url":"https://api.github.com/repos/gmurt/KernowSoftwareFMX/issues/93/labels{/name}","comments_url":"https://api.github.com/repos/gmurt/KernowSoftwareFMX/issues/93/comments","events_url":"https://api.github.com/repos/gmurt/KernowSoftwareFMX/issues/93/events","html_url":"https://github.com/gmurt/KernowSoftwareFMX/issues/93","id":158198176,"number":93,"title":"BeforeRowCache","user":{"login":"TetrisSQC","id":11291557,"avatar_url":"https://avatars.githubusercontent.com/u/11291557?v=3","gravatar_id":"","url":"https://api.github.com/users/TetrisSQC","html_url":"https://github.com/TetrisSQC","followers_url":"https://api.github.com/users/TetrisSQC/followers","following_url":"https://api.github.com/users/TetrisSQC/following{/other_user}","gists_url":"https://api.github.com/users/TetrisSQC/gists{/gist_id}","starred_url":"https://api.github.com/users/TetrisSQC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TetrisSQC/subscriptions","organizations_url":"https://api.github.com/users/TetrisSQC/orgs","repos_url":"https://api.github.com/users/TetrisSQC/repos","events_url":"https://api.github.com/users/TetrisSQC/events{/privacy}","received_events_url":"https://api.github.com/users/TetrisSQC/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-06-02T17:39:16Z","updated_at":"2016-06-02T20:33:07Z","closed_at":null,"body":"Hi,\r\n\r\ncould you please put the BeforeRowCache before _FBitmap.Canvas.BeginScene?\r\n\r\n procedure TksTableViewItem.CacheItem(const AForceCache: Boolean = False);\r\nvar\r\n  ARect: TRectF;\r\n  ICount: integer;\r\n  ColumnOffset : Single;\r\n  w,h: integer;\r\n  AScreenScale: Single;\r\nbegin\r\n  if (FUpdating) or (FTableView.UpdateCount > 0) then\r\n    Exit;\r\n  if (FItemRect.Height = 0) or (FItemRect.Width = 0) then\r\n    Exit;\r\n\r\n  if AForceCache then\r\n    ClearCache;\r\n\r\n  if (FCached = True) or (FCaching) then\r\n    Exit;\r\n\r\n  FCaching := True;\r\n\r\n  AScreenScale := GetScreenScale;\r\n\r\n  w := Round(FItemRect.Width * AScreenScale);\r\n  h := Round(FItemRect.Height * AScreenScale);\r\n\r\n  Inc(FOwner.FCachedCount);\r\n  _FBitmap.SetSize(w, h);\r\n\r\n\r\n  ARect := RectF(0, 0, _FBitmap.Width, _FBitmap.Height);\r\n\r\n  if Assigned(FTableView.BeforeRowCache) then\r\n      FTableView.BeforeRowCache(FTableView, _FBitmap.Canvas, Self, ARect);\r\n\r\n  ColumnOffset := ItemRect.Left;\r\n  OffsetRect(FItemRect,-ColumnOffset,0);\r\n  RealignStandardObjects;\r\n\r\n  _FBitmap.Canvas.BeginScene;\r\n...\r\nThe reason is that otherwise you can not update the TksTableViewItem. In my case i update the bitmap and the subtitle text, which won't work.\r\n\r\nChristian\r\n"},"comment":{"url":"https://api.github.com/repos/gmurt/KernowSoftwareFMX/issues/comments/223413322","html_url":"https://github.com/gmurt/KernowSoftwareFMX/issues/93#issuecomment-223413322","issue_url":"https://api.github.com/repos/gmurt/KernowSoftwareFMX/issues/93","id":223413322,"user":{"login":"gmurt","id":1161351,"avatar_url":"https://avatars.githubusercontent.com/u/1161351?v=3","gravatar_id":"","url":"https://api.github.com/users/gmurt","html_url":"https://github.com/gmurt","followers_url":"https://api.github.com/users/gmurt/followers","following_url":"https://api.github.com/users/gmurt/following{/other_user}","gists_url":"https://api.github.com/users/gmurt/gists{/gist_id}","starred_url":"https://api.github.com/users/gmurt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmurt/subscriptions","organizations_url":"https://api.github.com/users/gmurt/orgs","repos_url":"https://api.github.com/users/gmurt/repos","events_url":"https://api.github.com/users/gmurt/events{/privacy}","received_events_url":"https://api.github.com/users/gmurt/received_events","type":"User","site_admin":false},"created_at":"2016-06-02T20:33:07Z","updated_at":"2016-06-02T20:33:07Z","body":"Hi Christian,\r\n\r\nI added the new OnBeginRowCache for this purpose, is this not being called where you need it to be?"}}
{"actor":{"display_login":"gmurt"}}