{"action":"created","comment":{"url":"https://api.github.com/repos/yahoo/elide/pulls/comments/70829071","id":70829071,"diff_hunk":"@@ -90,21 +87,32 @@ public static Pagination parseQueryParams(final MultivaluedMap<String, String> q\n             return DEFAULT_PAGINATION;\n         }\n \n-        boolean isPageBased = pageData.containsKey(PaginationKey.page);\n-        int limit = !pageData.containsKey(PaginationKey.limit) ? DEFAULT_PAGE_SIZE : pageData.get(PaginationKey.limit);\n-        if (limit < 0) {\n-            throw new InvalidValueException(\"page[size] and page[limit] must contain positive values.\");\n-        }\n \n-        if (isPageBased && !pageData.containsKey(PaginationKey.offset)) {\n-            int page = pageData.get(PaginationKey.page);\n-            pageData.put(PaginationKey.offset, (page > 0 ? page - 1 : 0) * limit);\n-        }\n-        if (!pageData.containsKey(PaginationKey.offset)) {\n-            pageData.put(PaginationKey.offset, 0);\n+        if (pageData.containsKey(PaginationKey.limit) || pageData.containsKey(PaginationKey.offset)) {","path":"elide-core/src/main/java/com/yahoo/elide/core/pagination/Pagination.java","position":102,"original_position":102,"commit_id":"d2a73822d7194fe80373a4205f3bd14e5c7c0966","original_commit_id":"d2a73822d7194fe80373a4205f3bd14e5c7c0966","user":{"login":"aklish","id":6979393,"avatar_url":"https://avatars.githubusercontent.com/u/6979393?v=3","gravatar_id":"","url":"https://api.github.com/users/aklish","html_url":"https://github.com/aklish","followers_url":"https://api.github.com/users/aklish/followers","following_url":"https://api.github.com/users/aklish/following{/other_user}","gists_url":"https://api.github.com/users/aklish/gists{/gist_id}","starred_url":"https://api.github.com/users/aklish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aklish/subscriptions","organizations_url":"https://api.github.com/users/aklish/orgs","repos_url":"https://api.github.com/users/aklish/repos","events_url":"https://api.github.com/users/aklish/events{/privacy}","received_events_url":"https://api.github.com/users/aklish/received_events","type":"User","site_admin":false},"body":"Are combinations like limit and size legal?  Should we throw an error when specified?","created_at":"2016-07-14T15:40:45Z","updated_at":"2016-07-14T15:40:45Z","html_url":"https://github.com/yahoo/elide/pull/288#discussion_r70829071","pull_request_url":"https://api.github.com/repos/yahoo/elide/pulls/288","_links":{"self":{"href":"https://api.github.com/repos/yahoo/elide/pulls/comments/70829071"},"html":{"href":"https://github.com/yahoo/elide/pull/288#discussion_r70829071"},"pull_request":{"href":"https://api.github.com/repos/yahoo/elide/pulls/288"}}},"pull_request":{"url":"https://api.github.com/repos/yahoo/elide/pulls/288","id":76821873,"html_url":"https://github.com/yahoo/elide/pull/288","diff_url":"https://github.com/yahoo/elide/pull/288.diff","patch_url":"https://github.com/yahoo/elide/pull/288.patch","issue_url":"https://api.github.com/repos/yahoo/elide/issues/288","number":288,"state":"open","locked":false,"title":"Fixing pagination, sorting and Integration tests","user":{"login":"duseja2","id":4206417,"avatar_url":"https://avatars.githubusercontent.com/u/4206417?v=3","gravatar_id":"","url":"https://api.github.com/users/duseja2","html_url":"https://github.com/duseja2","followers_url":"https://api.github.com/users/duseja2/followers","following_url":"https://api.github.com/users/duseja2/following{/other_user}","gists_url":"https://api.github.com/users/duseja2/gists{/gist_id}","starred_url":"https://api.github.com/users/duseja2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duseja2/subscriptions","organizations_url":"https://api.github.com/users/duseja2/orgs","repos_url":"https://api.github.com/users/duseja2/repos","events_url":"https://api.github.com/users/duseja2/events{/privacy}","received_events_url":"https://api.github.com/users/duseja2/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-07-08T22:15:52Z","updated_at":"2016-07-14T15:40:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5a02c89c0d93b57d5e016a30f597cedb48eb3e6c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/yahoo/elide/pulls/288/commits","review_comments_url":"https://api.github.com/repos/yahoo/elide/pulls/288/comments","review_comment_url":"https://api.github.com/repos/yahoo/elide/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yahoo/elide/issues/288/comments","statuses_url":"https://api.github.com/repos/yahoo/elide/statuses/d2a73822d7194fe80373a4205f3bd14e5c7c0966","head":{"label":"yahoo:fixing_pagination","ref":"fixing_pagination","sha":"d2a73822d7194fe80373a4205f3bd14e5c7c0966","user":{"login":"yahoo","id":16574,"avatar_url":"https://avatars.githubusercontent.com/u/16574?v=3","gravatar_id":"","url":"https://api.github.com/users/yahoo","html_url":"https://github.com/yahoo","followers_url":"https://api.github.com/users/yahoo/followers","following_url":"https://api.github.com/users/yahoo/following{/other_user}","gists_url":"https://api.github.com/users/yahoo/gists{/gist_id}","starred_url":"https://api.github.com/users/yahoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yahoo/subscriptions","organizations_url":"https://api.github.com/users/yahoo/orgs","repos_url":"https://api.github.com/users/yahoo/repos","events_url":"https://api.github.com/users/yahoo/events{/privacy}","received_events_url":"https://api.github.com/users/yahoo/received_events","type":"Organization","site_admin":false},"repo":{"id":44124366,"name":"elide","full_name":"yahoo/elide","owner":{"login":"yahoo","id":16574,"avatar_url":"https://avatars.githubusercontent.com/u/16574?v=3","gravatar_id":"","url":"https://api.github.com/users/yahoo","html_url":"https://github.com/yahoo","followers_url":"https://api.github.com/users/yahoo/followers","following_url":"https://api.github.com/users/yahoo/following{/other_user}","gists_url":"https://api.github.com/users/yahoo/gists{/gist_id}","starred_url":"https://api.github.com/users/yahoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yahoo/subscriptions","organizations_url":"https://api.github.com/users/yahoo/orgs","repos_url":"https://api.github.com/users/yahoo/repos","events_url":"https://api.github.com/users/yahoo/events{/privacy}","received_events_url":"https://api.github.com/users/yahoo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yahoo/elide","description":"Elide is a Java library that lets you stand up a JSON API web service with minimal effort","fork":false,"url":"https://api.github.com/repos/yahoo/elide","forks_url":"https://api.github.com/repos/yahoo/elide/forks","keys_url":"https://api.github.com/repos/yahoo/elide/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yahoo/elide/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yahoo/elide/teams","hooks_url":"https://api.github.com/repos/yahoo/elide/hooks","issue_events_url":"https://api.github.com/repos/yahoo/elide/issues/events{/number}","events_url":"https://api.github.com/repos/yahoo/elide/events","assignees_url":"https://api.github.com/repos/yahoo/elide/assignees{/user}","branches_url":"https://api.github.com/repos/yahoo/elide/branches{/branch}","tags_url":"https://api.github.com/repos/yahoo/elide/tags","blobs_url":"https://api.github.com/repos/yahoo/elide/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yahoo/elide/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yahoo/elide/git/refs{/sha}","trees_url":"https://api.github.com/repos/yahoo/elide/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yahoo/elide/statuses/{sha}","languages_url":"https://api.github.com/repos/yahoo/elide/languages","stargazers_url":"https://api.github.com/repos/yahoo/elide/stargazers","contributors_url":"https://api.github.com/repos/yahoo/elide/contributors","subscribers_url":"https://api.github.com/repos/yahoo/elide/subscribers","subscription_url":"https://api.github.com/repos/yahoo/elide/subscription","commits_url":"https://api.github.com/repos/yahoo/elide/commits{/sha}","git_commits_url":"https://api.github.com/repos/yahoo/elide/git/commits{/sha}","comments_url":"https://api.github.com/repos/yahoo/elide/comments{/number}","issue_comment_url":"https://api.github.com/repos/yahoo/elide/issues/comments{/number}","contents_url":"https://api.github.com/repos/yahoo/elide/contents/{+path}","compare_url":"https://api.github.com/repos/yahoo/elide/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yahoo/elide/merges","archive_url":"https://api.github.com/repos/yahoo/elide/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yahoo/elide/downloads","issues_url":"https://api.github.com/repos/yahoo/elide/issues{/number}","pulls_url":"https://api.github.com/repos/yahoo/elide/pulls{/number}","milestones_url":"https://api.github.com/repos/yahoo/elide/milestones{/number}","notifications_url":"https://api.github.com/repos/yahoo/elide/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yahoo/elide/labels{/name}","releases_url":"https://api.github.com/repos/yahoo/elide/releases{/id}","deployments_url":"https://api.github.com/repos/yahoo/elide/deployments","created_at":"2015-10-12T17:55:01Z","updated_at":"2016-07-07T12:39:09Z","pushed_at":"2016-07-13T22:07:54Z","git_url":"git://github.com/yahoo/elide.git","ssh_url":"git@github.com:yahoo/elide.git","clone_url":"https://github.com/yahoo/elide.git","svn_url":"https://github.com/yahoo/elide","homepage":"http://elide.io/","size":2752,"stargazers_count":122,"watchers_count":122,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":32,"mirror_url":null,"open_issues_count":39,"forks":32,"open_issues":39,"watchers":122,"default_branch":"master"}},"base":{"label":"yahoo:master","ref":"master","sha":"42d1e1ac18071adfba05b62e45c62c456a5125d7","user":{"login":"yahoo","id":16574,"avatar_url":"https://avatars.githubusercontent.com/u/16574?v=3","gravatar_id":"","url":"https://api.github.com/users/yahoo","html_url":"https://github.com/yahoo","followers_url":"https://api.github.com/users/yahoo/followers","following_url":"https://api.github.com/users/yahoo/following{/other_user}","gists_url":"https://api.github.com/users/yahoo/gists{/gist_id}","starred_url":"https://api.github.com/users/yahoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yahoo/subscriptions","organizations_url":"https://api.github.com/users/yahoo/orgs","repos_url":"https://api.github.com/users/yahoo/repos","events_url":"https://api.github.com/users/yahoo/events{/privacy}","received_events_url":"https://api.github.com/users/yahoo/received_events","type":"Organization","site_admin":false},"repo":{"id":44124366,"name":"elide","full_name":"yahoo/elide","owner":{"login":"yahoo","id":16574,"avatar_url":"https://avatars.githubusercontent.com/u/16574?v=3","gravatar_id":"","url":"https://api.github.com/users/yahoo","html_url":"https://github.com/yahoo","followers_url":"https://api.github.com/users/yahoo/followers","following_url":"https://api.github.com/users/yahoo/following{/other_user}","gists_url":"https://api.github.com/users/yahoo/gists{/gist_id}","starred_url":"https://api.github.com/users/yahoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yahoo/subscriptions","organizations_url":"https://api.github.com/users/yahoo/orgs","repos_url":"https://api.github.com/users/yahoo/repos","events_url":"https://api.github.com/users/yahoo/events{/privacy}","received_events_url":"https://api.github.com/users/yahoo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yahoo/elide","description":"Elide is a Java library that lets you stand up a JSON API web service with minimal effort","fork":false,"url":"https://api.github.com/repos/yahoo/elide","forks_url":"https://api.github.com/repos/yahoo/elide/forks","keys_url":"https://api.github.com/repos/yahoo/elide/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yahoo/elide/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yahoo/elide/teams","hooks_url":"https://api.github.com/repos/yahoo/elide/hooks","issue_events_url":"https://api.github.com/repos/yahoo/elide/issues/events{/number}","events_url":"https://api.github.com/repos/yahoo/elide/events","assignees_url":"https://api.github.com/repos/yahoo/elide/assignees{/user}","branches_url":"https://api.github.com/repos/yahoo/elide/branches{/branch}","tags_url":"https://api.github.com/repos/yahoo/elide/tags","blobs_url":"https://api.github.com/repos/yahoo/elide/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yahoo/elide/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yahoo/elide/git/refs{/sha}","trees_url":"https://api.github.com/repos/yahoo/elide/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yahoo/elide/statuses/{sha}","languages_url":"https://api.github.com/repos/yahoo/elide/languages","stargazers_url":"https://api.github.com/repos/yahoo/elide/stargazers","contributors_url":"https://api.github.com/repos/yahoo/elide/contributors","subscribers_url":"https://api.github.com/repos/yahoo/elide/subscribers","subscription_url":"https://api.github.com/repos/yahoo/elide/subscription","commits_url":"https://api.github.com/repos/yahoo/elide/commits{/sha}","git_commits_url":"https://api.github.com/repos/yahoo/elide/git/commits{/sha}","comments_url":"https://api.github.com/repos/yahoo/elide/comments{/number}","issue_comment_url":"https://api.github.com/repos/yahoo/elide/issues/comments{/number}","contents_url":"https://api.github.com/repos/yahoo/elide/contents/{+path}","compare_url":"https://api.github.com/repos/yahoo/elide/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yahoo/elide/merges","archive_url":"https://api.github.com/repos/yahoo/elide/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yahoo/elide/downloads","issues_url":"https://api.github.com/repos/yahoo/elide/issues{/number}","pulls_url":"https://api.github.com/repos/yahoo/elide/pulls{/number}","milestones_url":"https://api.github.com/repos/yahoo/elide/milestones{/number}","notifications_url":"https://api.github.com/repos/yahoo/elide/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yahoo/elide/labels{/name}","releases_url":"https://api.github.com/repos/yahoo/elide/releases{/id}","deployments_url":"https://api.github.com/repos/yahoo/elide/deployments","created_at":"2015-10-12T17:55:01Z","updated_at":"2016-07-07T12:39:09Z","pushed_at":"2016-07-13T22:07:54Z","git_url":"git://github.com/yahoo/elide.git","ssh_url":"git@github.com:yahoo/elide.git","clone_url":"https://github.com/yahoo/elide.git","svn_url":"https://github.com/yahoo/elide","homepage":"http://elide.io/","size":2752,"stargazers_count":122,"watchers_count":122,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":32,"mirror_url":null,"open_issues_count":39,"forks":32,"open_issues":39,"watchers":122,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yahoo/elide/pulls/288"},"html":{"href":"https://github.com/yahoo/elide/pull/288"},"issue":{"href":"https://api.github.com/repos/yahoo/elide/issues/288"},"comments":{"href":"https://api.github.com/repos/yahoo/elide/issues/288/comments"},"review_comments":{"href":"https://api.github.com/repos/yahoo/elide/pulls/288/comments"},"review_comment":{"href":"https://api.github.com/repos/yahoo/elide/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yahoo/elide/pulls/288/commits"},"statuses":{"href":"https://api.github.com/repos/yahoo/elide/statuses/d2a73822d7194fe80373a4205f3bd14e5c7c0966"}}}}
{"actor":{"display_login":"aklish"}}