{"action":"created","issue":{"url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/issues/5295","repository_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS","labels_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/issues/5295/labels{/name}","comments_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/issues/5295/comments","events_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/issues/5295/events","html_url":"https://github.com/wordpress-mobile/WordPress-iOS/pull/5295","id":153122890,"number":5295,"title":"Makes private and improves animatedBox in AbstractPostListViewControl.","user":{"login":"diegoreymendez","id":1836005,"avatar_url":"https://avatars.githubusercontent.com/u/1836005?v=3","gravatar_id":"","url":"https://api.github.com/users/diegoreymendez","html_url":"https://github.com/diegoreymendez","followers_url":"https://api.github.com/users/diegoreymendez/followers","following_url":"https://api.github.com/users/diegoreymendez/following{/other_user}","gists_url":"https://api.github.com/users/diegoreymendez/gists{/gist_id}","starred_url":"https://api.github.com/users/diegoreymendez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diegoreymendez/subscriptions","organizations_url":"https://api.github.com/users/diegoreymendez/orgs","repos_url":"https://api.github.com/users/diegoreymendez/repos","events_url":"https://api.github.com/users/diegoreymendez/events{/privacy}","received_events_url":"https://api.github.com/users/diegoreymendez/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/labels/[Type]%20Cleanup","name":"[Type] Cleanup","color":"0e8a16"}],"state":"open","locked":false,"assignee":{"login":"frosty","id":4780,"avatar_url":"https://avatars.githubusercontent.com/u/4780?v=3","gravatar_id":"","url":"https://api.github.com/users/frosty","html_url":"https://github.com/frosty","followers_url":"https://api.github.com/users/frosty/followers","following_url":"https://api.github.com/users/frosty/following{/other_user}","gists_url":"https://api.github.com/users/frosty/gists{/gist_id}","starred_url":"https://api.github.com/users/frosty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frosty/subscriptions","organizations_url":"https://api.github.com/users/frosty/orgs","repos_url":"https://api.github.com/users/frosty/repos","events_url":"https://api.github.com/users/frosty/events{/privacy}","received_events_url":"https://api.github.com/users/frosty/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/milestones/54","html_url":"https://github.com/wordpress-mobile/WordPress-iOS/milestones/6.3","labels_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/milestones/54/labels","id":1562509,"number":54,"title":"6.3","description":"","creator":{"login":"sendhil","id":437043,"avatar_url":"https://avatars.githubusercontent.com/u/437043?v=3","gravatar_id":"","url":"https://api.github.com/users/sendhil","html_url":"https://github.com/sendhil","followers_url":"https://api.github.com/users/sendhil/followers","following_url":"https://api.github.com/users/sendhil/following{/other_user}","gists_url":"https://api.github.com/users/sendhil/gists{/gist_id}","starred_url":"https://api.github.com/users/sendhil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sendhil/subscriptions","organizations_url":"https://api.github.com/users/sendhil/orgs","repos_url":"https://api.github.com/users/sendhil/repos","events_url":"https://api.github.com/users/sendhil/events{/privacy}","received_events_url":"https://api.github.com/users/sendhil/received_events","type":"User","site_admin":false},"open_issues":18,"closed_issues":67,"state":"open","created_at":"2016-02-04T04:45:27Z","updated_at":"2016-05-11T12:11:38Z","due_on":null,"closed_at":null},"comments":8,"created_at":"2016-05-04T21:48:15Z","updated_at":"2016-05-11T13:37:07Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/pulls/5295","html_url":"https://github.com/wordpress-mobile/WordPress-iOS/pull/5295","diff_url":"https://github.com/wordpress-mobile/WordPress-iOS/pull/5295.diff","patch_url":"https://github.com/wordpress-mobile/WordPress-iOS/pull/5295.patch"},"body":"### Description:\r\n- Improves `animatedBox` in `AbstractPostListViewController` by making it non-optional, and by making it animate.\r\n- Makes `animatedBox` private in `AbstractPostListViewController`.\r\n- Fixes a curious bug in `WPAnimatedBox.m`.\r\n\r\n### Additional info:\r\n\r\nThe way in which `WPAnimatedBox` is being animated now is kinda hackish - since the delay we added is not guaranteed to work.  A refactor to this classes would be better.\r\n\r\nHowever, since the animation not working would be low-impact, I think the solution should be acceptable until I can get around to actually refactoring these classes.\r\n\r\n### To test:\r\n1. Launch the app\r\n2. Go to the list of blogs and pick one\r\n3. Open to the list of pages or posts\r\n4. Pull down the list to refresh and make sure that while loading posts the \r\n\r\n/cc @frosty for review\r\n/fyi @aerych (cos you know this code better)."},"comment":{"url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/issues/comments/218461118","html_url":"https://github.com/wordpress-mobile/WordPress-iOS/pull/5295#issuecomment-218461118","issue_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/issues/5295","id":218461118,"user":{"login":"diegoreymendez","id":1836005,"avatar_url":"https://avatars.githubusercontent.com/u/1836005?v=3","gravatar_id":"","url":"https://api.github.com/users/diegoreymendez","html_url":"https://github.com/diegoreymendez","followers_url":"https://api.github.com/users/diegoreymendez/followers","following_url":"https://api.github.com/users/diegoreymendez/following{/other_user}","gists_url":"https://api.github.com/users/diegoreymendez/gists{/gist_id}","starred_url":"https://api.github.com/users/diegoreymendez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diegoreymendez/subscriptions","organizations_url":"https://api.github.com/users/diegoreymendez/orgs","repos_url":"https://api.github.com/users/diegoreymendez/repos","events_url":"https://api.github.com/users/diegoreymendez/events{/privacy}","received_events_url":"https://api.github.com/users/diegoreymendez/received_events","type":"User","site_admin":false},"created_at":"2016-05-11T13:37:07Z","updated_at":"2016-05-11T13:37:07Z","body":"This PR is ready for another look @frosty.  Very nice finds in your review.  I used your code suggestion as a starting point, but instead of checking if the transform was identity, I'm now enforcing it before the code that follows up."}}