{"action":"created","comment":{"url":"https://api.github.com/repos/dgraph-io/dgraph/pulls/comments/77832232","id":77832232,"diff_hunk":"@@ -71,14 +75,14 @@ func gorocksdb_filterpolicy_create_filter(idx int, cKeys **C.char, cKeysLen *C.s\n \treturn cByteSlice(dst)\n }\n \n-//export gorocksdb_filterpolicy_key_may_match\n-func gorocksdb_filterpolicy_key_may_match(idx int, cKey *C.char, cKeyLen C.size_t, cFilter *C.char, cFilterLen C.size_t) C.uchar {\n+//export rdbc_filterpolicy_key_may_match\n+func rdbc_filterpolicy_key_may_match(idx int, cKey *C.char, cKeyLen C.size_t, cFilter *C.char, cFilterLen C.size_t) C.uchar {\n \tkey := charToByte(cKey, cKeyLen)\n \tfilter := charToByte(cFilter, cFilterLen)\n \treturn boolToChar(filterPolicies[idx].KeyMayMatch(key, filter))\n }\n \n-//export gorocksdb_filterpolicy_name\n-func gorocksdb_filterpolicy_name(idx int) *C.char {\n+//export rdbc_filterpolicy_name\n+func rdbc_filterpolicy_name(idx int) *C.char {","path":"rdb/filter_policy.go","position":40,"original_position":40,"commit_id":"f304c3eede130f56b10edcadfcd78833d2f02fcc","original_commit_id":"f304c3eede130f56b10edcadfcd78833d2f02fcc","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"don't use underscores in Go names; func rdbc_filterpolicy_name should be rdbcFilterpolicyName","created_at":"2016-09-07T14:26:21Z","updated_at":"2016-09-07T14:26:21Z","html_url":"https://github.com/dgraph-io/dgraph/pull/200#discussion_r77832232","pull_request_url":"https://api.github.com/repos/dgraph-io/dgraph/pulls/200","_links":{"self":{"href":"https://api.github.com/repos/dgraph-io/dgraph/pulls/comments/77832232"},"html":{"href":"https://github.com/dgraph-io/dgraph/pull/200#discussion_r77832232"},"pull_request":{"href":"https://api.github.com/repos/dgraph-io/dgraph/pulls/200"}}},"pull_request":{"url":"https://api.github.com/repos/dgraph-io/dgraph/pulls/200","id":84310070,"html_url":"https://github.com/dgraph-io/dgraph/pull/200","diff_url":"https://github.com/dgraph-io/dgraph/pull/200.diff","patch_url":"https://github.com/dgraph-io/dgraph/pull/200.patch","issue_url":"https://api.github.com/repos/dgraph-io/dgraph/issues/200","number":200,"state":"open","locked":false,"title":"Rdbwrap","user":{"login":"jchiu0","id":20329402,"avatar_url":"https://avatars.githubusercontent.com/u/20329402?v=3","gravatar_id":"","url":"https://api.github.com/users/jchiu0","html_url":"https://github.com/jchiu0","followers_url":"https://api.github.com/users/jchiu0/followers","following_url":"https://api.github.com/users/jchiu0/following{/other_user}","gists_url":"https://api.github.com/users/jchiu0/gists{/gist_id}","starred_url":"https://api.github.com/users/jchiu0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jchiu0/subscriptions","organizations_url":"https://api.github.com/users/jchiu0/orgs","repos_url":"https://api.github.com/users/jchiu0/repos","events_url":"https://api.github.com/users/jchiu0/events{/privacy}","received_events_url":"https://api.github.com/users/jchiu0/received_events","type":"User","site_admin":false},"body":"Get rid of rocksdb. I think we can also get rid of Cockroach?\r\n\r\nWould require user to install RocksDB on their own, the usual way. Binaries will work fine. Brew install will work fine.","created_at":"2016-09-07T14:26:12Z","updated_at":"2016-09-07T14:26:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5478245ba6bbe0efb7148e257d06656c3e694f44","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dgraph-io/dgraph/pulls/200/commits","review_comments_url":"https://api.github.com/repos/dgraph-io/dgraph/pulls/200/comments","review_comment_url":"https://api.github.com/repos/dgraph-io/dgraph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dgraph-io/dgraph/issues/200/comments","statuses_url":"https://api.github.com/repos/dgraph-io/dgraph/statuses/f304c3eede130f56b10edcadfcd78833d2f02fcc","head":{"label":"dgraph-io:rdbwrap","ref":"rdbwrap","sha":"f304c3eede130f56b10edcadfcd78833d2f02fcc","user":{"login":"dgraph-io","id":13958706,"avatar_url":"https://avatars.githubusercontent.com/u/13958706?v=3","gravatar_id":"","url":"https://api.github.com/users/dgraph-io","html_url":"https://github.com/dgraph-io","followers_url":"https://api.github.com/users/dgraph-io/followers","following_url":"https://api.github.com/users/dgraph-io/following{/other_user}","gists_url":"https://api.github.com/users/dgraph-io/gists{/gist_id}","starred_url":"https://api.github.com/users/dgraph-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgraph-io/subscriptions","organizations_url":"https://api.github.com/users/dgraph-io/orgs","repos_url":"https://api.github.com/users/dgraph-io/repos","events_url":"https://api.github.com/users/dgraph-io/events{/privacy}","received_events_url":"https://api.github.com/users/dgraph-io/received_events","type":"Organization","site_admin":false},"repo":{"id":41349039,"name":"dgraph","full_name":"dgraph-io/dgraph","owner":{"login":"dgraph-io","id":13958706,"avatar_url":"https://avatars.githubusercontent.com/u/13958706?v=3","gravatar_id":"","url":"https://api.github.com/users/dgraph-io","html_url":"https://github.com/dgraph-io","followers_url":"https://api.github.com/users/dgraph-io/followers","following_url":"https://api.github.com/users/dgraph-io/following{/other_user}","gists_url":"https://api.github.com/users/dgraph-io/gists{/gist_id}","starred_url":"https://api.github.com/users/dgraph-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgraph-io/subscriptions","organizations_url":"https://api.github.com/users/dgraph-io/orgs","repos_url":"https://api.github.com/users/dgraph-io/repos","events_url":"https://api.github.com/users/dgraph-io/events{/privacy}","received_events_url":"https://api.github.com/users/dgraph-io/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dgraph-io/dgraph","description":"Scalable, Distributed, Low Latency Graph Database","fork":false,"url":"https://api.github.com/repos/dgraph-io/dgraph","forks_url":"https://api.github.com/repos/dgraph-io/dgraph/forks","keys_url":"https://api.github.com/repos/dgraph-io/dgraph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dgraph-io/dgraph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dgraph-io/dgraph/teams","hooks_url":"https://api.github.com/repos/dgraph-io/dgraph/hooks","issue_events_url":"https://api.github.com/repos/dgraph-io/dgraph/issues/events{/number}","events_url":"https://api.github.com/repos/dgraph-io/dgraph/events","assignees_url":"https://api.github.com/repos/dgraph-io/dgraph/assignees{/user}","branches_url":"https://api.github.com/repos/dgraph-io/dgraph/branches{/branch}","tags_url":"https://api.github.com/repos/dgraph-io/dgraph/tags","blobs_url":"https://api.github.com/repos/dgraph-io/dgraph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dgraph-io/dgraph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dgraph-io/dgraph/git/refs{/sha}","trees_url":"https://api.github.com/repos/dgraph-io/dgraph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dgraph-io/dgraph/statuses/{sha}","languages_url":"https://api.github.com/repos/dgraph-io/dgraph/languages","stargazers_url":"https://api.github.com/repos/dgraph-io/dgraph/stargazers","contributors_url":"https://api.github.com/repos/dgraph-io/dgraph/contributors","subscribers_url":"https://api.github.com/repos/dgraph-io/dgraph/subscribers","subscription_url":"https://api.github.com/repos/dgraph-io/dgraph/subscription","commits_url":"https://api.github.com/repos/dgraph-io/dgraph/commits{/sha}","git_commits_url":"https://api.github.com/repos/dgraph-io/dgraph/git/commits{/sha}","comments_url":"https://api.github.com/repos/dgraph-io/dgraph/comments{/number}","issue_comment_url":"https://api.github.com/repos/dgraph-io/dgraph/issues/comments{/number}","contents_url":"https://api.github.com/repos/dgraph-io/dgraph/contents/{+path}","compare_url":"https://api.github.com/repos/dgraph-io/dgraph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dgraph-io/dgraph/merges","archive_url":"https://api.github.com/repos/dgraph-io/dgraph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dgraph-io/dgraph/downloads","issues_url":"https://api.github.com/repos/dgraph-io/dgraph/issues{/number}","pulls_url":"https://api.github.com/repos/dgraph-io/dgraph/pulls{/number}","milestones_url":"https://api.github.com/repos/dgraph-io/dgraph/milestones{/number}","notifications_url":"https://api.github.com/repos/dgraph-io/dgraph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dgraph-io/dgraph/labels{/name}","releases_url":"https://api.github.com/repos/dgraph-io/dgraph/releases{/id}","deployments_url":"https://api.github.com/repos/dgraph-io/dgraph/deployments","created_at":"2015-08-25T07:15:56Z","updated_at":"2016-09-07T11:32:20Z","pushed_at":"2016-09-07T14:26:12Z","git_url":"git://github.com/dgraph-io/dgraph.git","ssh_url":"git@github.com:dgraph-io/dgraph.git","clone_url":"https://github.com/dgraph-io/dgraph.git","svn_url":"https://github.com/dgraph-io/dgraph","homepage":"","size":56457,"stargazers_count":1724,"watchers_count":1724,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":79,"mirror_url":null,"open_issues_count":20,"forks":79,"open_issues":20,"watchers":1724,"default_branch":"master"}},"base":{"label":"dgraph-io:master","ref":"master","sha":"5dad80b23ca0caff57daaa45ac4abab3d123e5f8","user":{"login":"dgraph-io","id":13958706,"avatar_url":"https://avatars.githubusercontent.com/u/13958706?v=3","gravatar_id":"","url":"https://api.github.com/users/dgraph-io","html_url":"https://github.com/dgraph-io","followers_url":"https://api.github.com/users/dgraph-io/followers","following_url":"https://api.github.com/users/dgraph-io/following{/other_user}","gists_url":"https://api.github.com/users/dgraph-io/gists{/gist_id}","starred_url":"https://api.github.com/users/dgraph-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgraph-io/subscriptions","organizations_url":"https://api.github.com/users/dgraph-io/orgs","repos_url":"https://api.github.com/users/dgraph-io/repos","events_url":"https://api.github.com/users/dgraph-io/events{/privacy}","received_events_url":"https://api.github.com/users/dgraph-io/received_events","type":"Organization","site_admin":false},"repo":{"id":41349039,"name":"dgraph","full_name":"dgraph-io/dgraph","owner":{"login":"dgraph-io","id":13958706,"avatar_url":"https://avatars.githubusercontent.com/u/13958706?v=3","gravatar_id":"","url":"https://api.github.com/users/dgraph-io","html_url":"https://github.com/dgraph-io","followers_url":"https://api.github.com/users/dgraph-io/followers","following_url":"https://api.github.com/users/dgraph-io/following{/other_user}","gists_url":"https://api.github.com/users/dgraph-io/gists{/gist_id}","starred_url":"https://api.github.com/users/dgraph-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgraph-io/subscriptions","organizations_url":"https://api.github.com/users/dgraph-io/orgs","repos_url":"https://api.github.com/users/dgraph-io/repos","events_url":"https://api.github.com/users/dgraph-io/events{/privacy}","received_events_url":"https://api.github.com/users/dgraph-io/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dgraph-io/dgraph","description":"Scalable, Distributed, Low Latency Graph Database","fork":false,"url":"https://api.github.com/repos/dgraph-io/dgraph","forks_url":"https://api.github.com/repos/dgraph-io/dgraph/forks","keys_url":"https://api.github.com/repos/dgraph-io/dgraph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dgraph-io/dgraph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dgraph-io/dgraph/teams","hooks_url":"https://api.github.com/repos/dgraph-io/dgraph/hooks","issue_events_url":"https://api.github.com/repos/dgraph-io/dgraph/issues/events{/number}","events_url":"https://api.github.com/repos/dgraph-io/dgraph/events","assignees_url":"https://api.github.com/repos/dgraph-io/dgraph/assignees{/user}","branches_url":"https://api.github.com/repos/dgraph-io/dgraph/branches{/branch}","tags_url":"https://api.github.com/repos/dgraph-io/dgraph/tags","blobs_url":"https://api.github.com/repos/dgraph-io/dgraph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dgraph-io/dgraph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dgraph-io/dgraph/git/refs{/sha}","trees_url":"https://api.github.com/repos/dgraph-io/dgraph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dgraph-io/dgraph/statuses/{sha}","languages_url":"https://api.github.com/repos/dgraph-io/dgraph/languages","stargazers_url":"https://api.github.com/repos/dgraph-io/dgraph/stargazers","contributors_url":"https://api.github.com/repos/dgraph-io/dgraph/contributors","subscribers_url":"https://api.github.com/repos/dgraph-io/dgraph/subscribers","subscription_url":"https://api.github.com/repos/dgraph-io/dgraph/subscription","commits_url":"https://api.github.com/repos/dgraph-io/dgraph/commits{/sha}","git_commits_url":"https://api.github.com/repos/dgraph-io/dgraph/git/commits{/sha}","comments_url":"https://api.github.com/repos/dgraph-io/dgraph/comments{/number}","issue_comment_url":"https://api.github.com/repos/dgraph-io/dgraph/issues/comments{/number}","contents_url":"https://api.github.com/repos/dgraph-io/dgraph/contents/{+path}","compare_url":"https://api.github.com/repos/dgraph-io/dgraph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dgraph-io/dgraph/merges","archive_url":"https://api.github.com/repos/dgraph-io/dgraph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dgraph-io/dgraph/downloads","issues_url":"https://api.github.com/repos/dgraph-io/dgraph/issues{/number}","pulls_url":"https://api.github.com/repos/dgraph-io/dgraph/pulls{/number}","milestones_url":"https://api.github.com/repos/dgraph-io/dgraph/milestones{/number}","notifications_url":"https://api.github.com/repos/dgraph-io/dgraph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dgraph-io/dgraph/labels{/name}","releases_url":"https://api.github.com/repos/dgraph-io/dgraph/releases{/id}","deployments_url":"https://api.github.com/repos/dgraph-io/dgraph/deployments","created_at":"2015-08-25T07:15:56Z","updated_at":"2016-09-07T11:32:20Z","pushed_at":"2016-09-07T14:26:12Z","git_url":"git://github.com/dgraph-io/dgraph.git","ssh_url":"git@github.com:dgraph-io/dgraph.git","clone_url":"https://github.com/dgraph-io/dgraph.git","svn_url":"https://github.com/dgraph-io/dgraph","homepage":"","size":56457,"stargazers_count":1724,"watchers_count":1724,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":79,"mirror_url":null,"open_issues_count":20,"forks":79,"open_issues":20,"watchers":1724,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dgraph-io/dgraph/pulls/200"},"html":{"href":"https://github.com/dgraph-io/dgraph/pull/200"},"issue":{"href":"https://api.github.com/repos/dgraph-io/dgraph/issues/200"},"comments":{"href":"https://api.github.com/repos/dgraph-io/dgraph/issues/200/comments"},"review_comments":{"href":"https://api.github.com/repos/dgraph-io/dgraph/pulls/200/comments"},"review_comment":{"href":"https://api.github.com/repos/dgraph-io/dgraph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dgraph-io/dgraph/pulls/200/commits"},"statuses":{"href":"https://api.github.com/repos/dgraph-io/dgraph/statuses/f304c3eede130f56b10edcadfcd78833d2f02fcc"}}}}
{"actor":{"display_login":"houndci-bot"}}