{"action":"created","comment":{"url":"https://api.github.com/repos/Polymer/vulcanize/pulls/comments/81212538","pull_request_review_id":2209477,"id":81212538,"diff_hunk":"@@ -61,6 +92,22 @@ export function generateBundles(depsIndex: TransitiveDependenciesMap):\n }\n \n /**\n+ * Given a collection of bundles and a BundleUrlMapper to generate urls for\n+ * them, produce a BundleManifest.\n+ */\n+export function generateBundleManifest(","path":"src/bundle-manifest.ts","position":52,"original_position":52,"commit_id":"da03d1fd6ebd4dd6a8fd4085dbad3ca7937c0984","original_commit_id":"da03d1fd6ebd4dd6a8fd4085dbad3ca7937c0984","user":{"login":"usergenic","id":578,"avatar_url":"https://avatars.githubusercontent.com/u/578?v=3","gravatar_id":"","url":"https://api.github.com/users/usergenic","html_url":"https://github.com/usergenic","followers_url":"https://api.github.com/users/usergenic/followers","following_url":"https://api.github.com/users/usergenic/following{/other_user}","gists_url":"https://api.github.com/users/usergenic/gists{/gist_id}","starred_url":"https://api.github.com/users/usergenic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/usergenic/subscriptions","organizations_url":"https://api.github.com/users/usergenic/orgs","repos_url":"https://api.github.com/users/usergenic/repos","events_url":"https://api.github.com/users/usergenic/events{/privacy}","received_events_url":"https://api.github.com/users/usergenic/received_events","type":"User","site_admin":false},"body":"I also have old bias against constructor logic, but I think it makes sense to use constructor here.  Its cleaner.","created_at":"2016-09-29T19:09:48Z","updated_at":"2016-09-29T19:09:48Z","html_url":"https://github.com/Polymer/vulcanize/pull/380#discussion_r81212538","pull_request_url":"https://api.github.com/repos/Polymer/vulcanize/pulls/380","_links":{"self":{"href":"https://api.github.com/repos/Polymer/vulcanize/pulls/comments/81212538"},"html":{"href":"https://github.com/Polymer/vulcanize/pull/380#discussion_r81212538"},"pull_request":{"href":"https://api.github.com/repos/Polymer/vulcanize/pulls/380"}}},"pull_request":{"url":"https://api.github.com/repos/Polymer/vulcanize/pulls/380","id":87215471,"html_url":"https://github.com/Polymer/vulcanize/pull/380","diff_url":"https://github.com/Polymer/vulcanize/pull/380.diff","patch_url":"https://github.com/Polymer/vulcanize/pull/380.patch","issue_url":"https://api.github.com/repos/Polymer/vulcanize/issues/380","number":380,"state":"open","locked":false,"title":"Here's the class definition for bundle manifest and the bundle-to-url mapper function.","user":{"login":"usergenic","id":578,"avatar_url":"https://avatars.githubusercontent.com/u/578?v=3","gravatar_id":"","url":"https://api.github.com/users/usergenic","html_url":"https://github.com/usergenic","followers_url":"https://api.github.com/users/usergenic/followers","following_url":"https://api.github.com/users/usergenic/following{/other_user}","gists_url":"https://api.github.com/users/usergenic/gists{/gist_id}","starred_url":"https://api.github.com/users/usergenic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/usergenic/subscriptions","organizations_url":"https://api.github.com/users/usergenic/orgs","repos_url":"https://api.github.com/users/usergenic/repos","events_url":"https://api.github.com/users/usergenic/events{/privacy}","received_events_url":"https://api.github.com/users/usergenic/received_events","type":"User","site_admin":false},"body":"Just wanted to see if this API would work.  It's slightly different than what was proposed in the doc, so I made a separate mini-PR for consideration.","created_at":"2016-09-28T22:42:24Z","updated_at":"2016-09-29T19:09:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c9281bb0ccf25d2a0a6077b53ec243764cf7b741","assignee":{"login":"justinfagnani","id":522948,"avatar_url":"https://avatars.githubusercontent.com/u/522948?v=3","gravatar_id":"","url":"https://api.github.com/users/justinfagnani","html_url":"https://github.com/justinfagnani","followers_url":"https://api.github.com/users/justinfagnani/followers","following_url":"https://api.github.com/users/justinfagnani/following{/other_user}","gists_url":"https://api.github.com/users/justinfagnani/gists{/gist_id}","starred_url":"https://api.github.com/users/justinfagnani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinfagnani/subscriptions","organizations_url":"https://api.github.com/users/justinfagnani/orgs","repos_url":"https://api.github.com/users/justinfagnani/repos","events_url":"https://api.github.com/users/justinfagnani/events{/privacy}","received_events_url":"https://api.github.com/users/justinfagnani/received_events","type":"User","site_admin":false},"assignees":[{"login":"justinfagnani","id":522948,"avatar_url":"https://avatars.githubusercontent.com/u/522948?v=3","gravatar_id":"","url":"https://api.github.com/users/justinfagnani","html_url":"https://github.com/justinfagnani","followers_url":"https://api.github.com/users/justinfagnani/followers","following_url":"https://api.github.com/users/justinfagnani/following{/other_user}","gists_url":"https://api.github.com/users/justinfagnani/gists{/gist_id}","starred_url":"https://api.github.com/users/justinfagnani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinfagnani/subscriptions","organizations_url":"https://api.github.com/users/justinfagnani/orgs","repos_url":"https://api.github.com/users/justinfagnani/repos","events_url":"https://api.github.com/users/justinfagnani/events{/privacy}","received_events_url":"https://api.github.com/users/justinfagnani/received_events","type":"User","site_admin":false},{"login":"garlicnation","id":1105965,"avatar_url":"https://avatars.githubusercontent.com/u/1105965?v=3","gravatar_id":"","url":"https://api.github.com/users/garlicnation","html_url":"https://github.com/garlicnation","followers_url":"https://api.github.com/users/garlicnation/followers","following_url":"https://api.github.com/users/garlicnation/following{/other_user}","gists_url":"https://api.github.com/users/garlicnation/gists{/gist_id}","starred_url":"https://api.github.com/users/garlicnation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garlicnation/subscriptions","organizations_url":"https://api.github.com/users/garlicnation/orgs","repos_url":"https://api.github.com/users/garlicnation/repos","events_url":"https://api.github.com/users/garlicnation/events{/privacy}","received_events_url":"https://api.github.com/users/garlicnation/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Polymer/vulcanize/pulls/380/commits","review_comments_url":"https://api.github.com/repos/Polymer/vulcanize/pulls/380/comments","review_comment_url":"https://api.github.com/repos/Polymer/vulcanize/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Polymer/vulcanize/issues/380/comments","statuses_url":"https://api.github.com/repos/Polymer/vulcanize/statuses/da03d1fd6ebd4dd6a8fd4085dbad3ca7937c0984","head":{"label":"Polymer:bundle-manifest-class","ref":"bundle-manifest-class","sha":"da03d1fd6ebd4dd6a8fd4085dbad3ca7937c0984","user":{"login":"Polymer","id":2159051,"avatar_url":"https://avatars.githubusercontent.com/u/2159051?v=3","gravatar_id":"","url":"https://api.github.com/users/Polymer","html_url":"https://github.com/Polymer","followers_url":"https://api.github.com/users/Polymer/followers","following_url":"https://api.github.com/users/Polymer/following{/other_user}","gists_url":"https://api.github.com/users/Polymer/gists{/gist_id}","starred_url":"https://api.github.com/users/Polymer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Polymer/subscriptions","organizations_url":"https://api.github.com/users/Polymer/orgs","repos_url":"https://api.github.com/users/Polymer/repos","events_url":"https://api.github.com/users/Polymer/events{/privacy}","received_events_url":"https://api.github.com/users/Polymer/received_events","type":"Organization","site_admin":false},"repo":{"id":13599100,"name":"vulcanize","full_name":"Polymer/vulcanize","owner":{"login":"Polymer","id":2159051,"avatar_url":"https://avatars.githubusercontent.com/u/2159051?v=3","gravatar_id":"","url":"https://api.github.com/users/Polymer","html_url":"https://github.com/Polymer","followers_url":"https://api.github.com/users/Polymer/followers","following_url":"https://api.github.com/users/Polymer/following{/other_user}","gists_url":"https://api.github.com/users/Polymer/gists{/gist_id}","starred_url":"https://api.github.com/users/Polymer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Polymer/subscriptions","organizations_url":"https://api.github.com/users/Polymer/orgs","repos_url":"https://api.github.com/users/Polymer/repos","events_url":"https://api.github.com/users/Polymer/events{/privacy}","received_events_url":"https://api.github.com/users/Polymer/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Polymer/vulcanize","description":"Build tool for HTMLImports and Web Components","fork":false,"url":"https://api.github.com/repos/Polymer/vulcanize","forks_url":"https://api.github.com/repos/Polymer/vulcanize/forks","keys_url":"https://api.github.com/repos/Polymer/vulcanize/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Polymer/vulcanize/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Polymer/vulcanize/teams","hooks_url":"https://api.github.com/repos/Polymer/vulcanize/hooks","issue_events_url":"https://api.github.com/repos/Polymer/vulcanize/issues/events{/number}","events_url":"https://api.github.com/repos/Polymer/vulcanize/events","assignees_url":"https://api.github.com/repos/Polymer/vulcanize/assignees{/user}","branches_url":"https://api.github.com/repos/Polymer/vulcanize/branches{/branch}","tags_url":"https://api.github.com/repos/Polymer/vulcanize/tags","blobs_url":"https://api.github.com/repos/Polymer/vulcanize/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Polymer/vulcanize/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Polymer/vulcanize/git/refs{/sha}","trees_url":"https://api.github.com/repos/Polymer/vulcanize/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Polymer/vulcanize/statuses/{sha}","languages_url":"https://api.github.com/repos/Polymer/vulcanize/languages","stargazers_url":"https://api.github.com/repos/Polymer/vulcanize/stargazers","contributors_url":"https://api.github.com/repos/Polymer/vulcanize/contributors","subscribers_url":"https://api.github.com/repos/Polymer/vulcanize/subscribers","subscription_url":"https://api.github.com/repos/Polymer/vulcanize/subscription","commits_url":"https://api.github.com/repos/Polymer/vulcanize/commits{/sha}","git_commits_url":"https://api.github.com/repos/Polymer/vulcanize/git/commits{/sha}","comments_url":"https://api.github.com/repos/Polymer/vulcanize/comments{/number}","issue_comment_url":"https://api.github.com/repos/Polymer/vulcanize/issues/comments{/number}","contents_url":"https://api.github.com/repos/Polymer/vulcanize/contents/{+path}","compare_url":"https://api.github.com/repos/Polymer/vulcanize/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Polymer/vulcanize/merges","archive_url":"https://api.github.com/repos/Polymer/vulcanize/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Polymer/vulcanize/downloads","issues_url":"https://api.github.com/repos/Polymer/vulcanize/issues{/number}","pulls_url":"https://api.github.com/repos/Polymer/vulcanize/pulls{/number}","milestones_url":"https://api.github.com/repos/Polymer/vulcanize/milestones{/number}","notifications_url":"https://api.github.com/repos/Polymer/vulcanize/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Polymer/vulcanize/labels{/name}","releases_url":"https://api.github.com/repos/Polymer/vulcanize/releases{/id}","deployments_url":"https://api.github.com/repos/Polymer/vulcanize/deployments","created_at":"2013-10-15T18:56:20Z","updated_at":"2016-09-26T07:35:18Z","pushed_at":"2016-09-28T22:42:24Z","git_url":"git://github.com/Polymer/vulcanize.git","ssh_url":"git@github.com:Polymer/vulcanize.git","clone_url":"https://github.com/Polymer/vulcanize.git","svn_url":"https://github.com/Polymer/vulcanize","homepage":"","size":1164,"stargazers_count":1113,"watchers_count":1113,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":115,"mirror_url":null,"open_issues_count":85,"forks":115,"open_issues":85,"watchers":1113,"default_branch":"master"}},"base":{"label":"Polymer:bundle-manifest","ref":"bundle-manifest","sha":"0523111e29d17ff0a2d98d40dda64058342ffd10","user":{"login":"Polymer","id":2159051,"avatar_url":"https://avatars.githubusercontent.com/u/2159051?v=3","gravatar_id":"","url":"https://api.github.com/users/Polymer","html_url":"https://github.com/Polymer","followers_url":"https://api.github.com/users/Polymer/followers","following_url":"https://api.github.com/users/Polymer/following{/other_user}","gists_url":"https://api.github.com/users/Polymer/gists{/gist_id}","starred_url":"https://api.github.com/users/Polymer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Polymer/subscriptions","organizations_url":"https://api.github.com/users/Polymer/orgs","repos_url":"https://api.github.com/users/Polymer/repos","events_url":"https://api.github.com/users/Polymer/events{/privacy}","received_events_url":"https://api.github.com/users/Polymer/received_events","type":"Organization","site_admin":false},"repo":{"id":13599100,"name":"vulcanize","full_name":"Polymer/vulcanize","owner":{"login":"Polymer","id":2159051,"avatar_url":"https://avatars.githubusercontent.com/u/2159051?v=3","gravatar_id":"","url":"https://api.github.com/users/Polymer","html_url":"https://github.com/Polymer","followers_url":"https://api.github.com/users/Polymer/followers","following_url":"https://api.github.com/users/Polymer/following{/other_user}","gists_url":"https://api.github.com/users/Polymer/gists{/gist_id}","starred_url":"https://api.github.com/users/Polymer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Polymer/subscriptions","organizations_url":"https://api.github.com/users/Polymer/orgs","repos_url":"https://api.github.com/users/Polymer/repos","events_url":"https://api.github.com/users/Polymer/events{/privacy}","received_events_url":"https://api.github.com/users/Polymer/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Polymer/vulcanize","description":"Build tool for HTMLImports and Web Components","fork":false,"url":"https://api.github.com/repos/Polymer/vulcanize","forks_url":"https://api.github.com/repos/Polymer/vulcanize/forks","keys_url":"https://api.github.com/repos/Polymer/vulcanize/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Polymer/vulcanize/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Polymer/vulcanize/teams","hooks_url":"https://api.github.com/repos/Polymer/vulcanize/hooks","issue_events_url":"https://api.github.com/repos/Polymer/vulcanize/issues/events{/number}","events_url":"https://api.github.com/repos/Polymer/vulcanize/events","assignees_url":"https://api.github.com/repos/Polymer/vulcanize/assignees{/user}","branches_url":"https://api.github.com/repos/Polymer/vulcanize/branches{/branch}","tags_url":"https://api.github.com/repos/Polymer/vulcanize/tags","blobs_url":"https://api.github.com/repos/Polymer/vulcanize/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Polymer/vulcanize/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Polymer/vulcanize/git/refs{/sha}","trees_url":"https://api.github.com/repos/Polymer/vulcanize/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Polymer/vulcanize/statuses/{sha}","languages_url":"https://api.github.com/repos/Polymer/vulcanize/languages","stargazers_url":"https://api.github.com/repos/Polymer/vulcanize/stargazers","contributors_url":"https://api.github.com/repos/Polymer/vulcanize/contributors","subscribers_url":"https://api.github.com/repos/Polymer/vulcanize/subscribers","subscription_url":"https://api.github.com/repos/Polymer/vulcanize/subscription","commits_url":"https://api.github.com/repos/Polymer/vulcanize/commits{/sha}","git_commits_url":"https://api.github.com/repos/Polymer/vulcanize/git/commits{/sha}","comments_url":"https://api.github.com/repos/Polymer/vulcanize/comments{/number}","issue_comment_url":"https://api.github.com/repos/Polymer/vulcanize/issues/comments{/number}","contents_url":"https://api.github.com/repos/Polymer/vulcanize/contents/{+path}","compare_url":"https://api.github.com/repos/Polymer/vulcanize/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Polymer/vulcanize/merges","archive_url":"https://api.github.com/repos/Polymer/vulcanize/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Polymer/vulcanize/downloads","issues_url":"https://api.github.com/repos/Polymer/vulcanize/issues{/number}","pulls_url":"https://api.github.com/repos/Polymer/vulcanize/pulls{/number}","milestones_url":"https://api.github.com/repos/Polymer/vulcanize/milestones{/number}","notifications_url":"https://api.github.com/repos/Polymer/vulcanize/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Polymer/vulcanize/labels{/name}","releases_url":"https://api.github.com/repos/Polymer/vulcanize/releases{/id}","deployments_url":"https://api.github.com/repos/Polymer/vulcanize/deployments","created_at":"2013-10-15T18:56:20Z","updated_at":"2016-09-26T07:35:18Z","pushed_at":"2016-09-28T22:42:24Z","git_url":"git://github.com/Polymer/vulcanize.git","ssh_url":"git@github.com:Polymer/vulcanize.git","clone_url":"https://github.com/Polymer/vulcanize.git","svn_url":"https://github.com/Polymer/vulcanize","homepage":"","size":1164,"stargazers_count":1113,"watchers_count":1113,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":115,"mirror_url":null,"open_issues_count":85,"forks":115,"open_issues":85,"watchers":1113,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Polymer/vulcanize/pulls/380"},"html":{"href":"https://github.com/Polymer/vulcanize/pull/380"},"issue":{"href":"https://api.github.com/repos/Polymer/vulcanize/issues/380"},"comments":{"href":"https://api.github.com/repos/Polymer/vulcanize/issues/380/comments"},"review_comments":{"href":"https://api.github.com/repos/Polymer/vulcanize/pulls/380/comments"},"review_comment":{"href":"https://api.github.com/repos/Polymer/vulcanize/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Polymer/vulcanize/pulls/380/commits"},"statuses":{"href":"https://api.github.com/repos/Polymer/vulcanize/statuses/da03d1fd6ebd4dd6a8fd4085dbad3ca7937c0984"}}}}
{"actor":{"display_login":"usergenic"}}