{"action":"created","comment":{"url":"https://api.github.com/repos/apache/apex-malhar/pulls/comments/90732651","pull_request_review_id":11253588,"id":90732651,"diff_hunk":"@@ -122,8 +123,18 @@ public void setPartitionCount(int requiredPartitions)\n   @Override\n   public void emitTuples()\n   {\n-    scanDirectory();\n-\n+    int fileCt = 0;\n+    while ((!fileQueue.isEmpty()) && (fileCt < MAX_FILE_PER_WINDOW)) {\n+      Path newPath = fileQueue.peek();\n+      String newPathString = newPath.toString();\n+      pendingFiles.add(newPathString);","path":"library/src/main/java/com/datatorrent/lib/io/fs/AbstractThroughputFileInputOperator.java","position":18,"original_position":18,"commit_id":"99090dd843d986beb0febd6f4d644ceba4b47d6b","original_commit_id":"99090dd843d986beb0febd6f4d644ceba4b47d6b","user":{"login":"mattqzhang","id":3394891,"avatar_url":"https://avatars.githubusercontent.com/u/3394891?v=3","gravatar_id":"","url":"https://api.github.com/users/mattqzhang","html_url":"https://github.com/mattqzhang","followers_url":"https://api.github.com/users/mattqzhang/followers","following_url":"https://api.github.com/users/mattqzhang/following{/other_user}","gists_url":"https://api.github.com/users/mattqzhang/gists{/gist_id}","starred_url":"https://api.github.com/users/mattqzhang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattqzhang/subscriptions","organizations_url":"https://api.github.com/users/mattqzhang/orgs","repos_url":"https://api.github.com/users/mattqzhang/repos","events_url":"https://api.github.com/users/mattqzhang/events{/privacy}","received_events_url":"https://api.github.com/users/mattqzhang/received_events","type":"User","site_admin":false},"body":"pendingFiles is serializable and used for recovery and idempotency, while fileQueue is not serialized and need to be recomputed upon failure and replay.  Moreover currently pending files is protected. It may cause regression issue if we change the whole design. ","created_at":"2016-12-02T22:38:03Z","updated_at":"2016-12-02T22:38:03Z","html_url":"https://github.com/apache/apex-malhar/pull/490#discussion_r90732651","pull_request_url":"https://api.github.com/repos/apache/apex-malhar/pulls/490","_links":{"self":{"href":"https://api.github.com/repos/apache/apex-malhar/pulls/comments/90732651"},"html":{"href":"https://github.com/apache/apex-malhar/pull/490#discussion_r90732651"},"pull_request":{"href":"https://api.github.com/repos/apache/apex-malhar/pulls/490"}}},"pull_request":{"url":"https://api.github.com/repos/apache/apex-malhar/pulls/490","id":93217401,"html_url":"https://github.com/apache/apex-malhar/pull/490","diff_url":"https://github.com/apache/apex-malhar/pull/490.diff","patch_url":"https://github.com/apache/apex-malhar/pull/490.patch","issue_url":"https://api.github.com/repos/apache/apex-malhar/issues/490","number":490,"state":"open","locked":false,"title":"APEXMALHAR-2274 Handle large number of files for AbstractFileInputOpe…","user":{"login":"mattqzhang","id":3394891,"avatar_url":"https://avatars.githubusercontent.com/u/3394891?v=3","gravatar_id":"","url":"https://api.github.com/users/mattqzhang","html_url":"https://github.com/mattqzhang","followers_url":"https://api.github.com/users/mattqzhang/followers","following_url":"https://api.github.com/users/mattqzhang/following{/other_user}","gists_url":"https://api.github.com/users/mattqzhang/gists{/gist_id}","starred_url":"https://api.github.com/users/mattqzhang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattqzhang/subscriptions","organizations_url":"https://api.github.com/users/mattqzhang/orgs","repos_url":"https://api.github.com/users/mattqzhang/repos","events_url":"https://api.github.com/users/mattqzhang/events{/privacy}","received_events_url":"https://api.github.com/users/mattqzhang/received_events","type":"User","site_admin":false},"body":"@PramodSSImmaneni Please review","created_at":"2016-11-10T19:44:47Z","updated_at":"2016-12-02T22:38:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"33111929aa5abb7d99ec54a75a12ed0bc45547b8","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/apex-malhar/pulls/490/commits","review_comments_url":"https://api.github.com/repos/apache/apex-malhar/pulls/490/comments","review_comment_url":"https://api.github.com/repos/apache/apex-malhar/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/apex-malhar/issues/490/comments","statuses_url":"https://api.github.com/repos/apache/apex-malhar/statuses/99090dd843d986beb0febd6f4d644ceba4b47d6b","head":{"label":"mattqzhang:APEXMALHAR-2274","ref":"APEXMALHAR-2274","sha":"99090dd843d986beb0febd6f4d644ceba4b47d6b","user":{"login":"mattqzhang","id":3394891,"avatar_url":"https://avatars.githubusercontent.com/u/3394891?v=3","gravatar_id":"","url":"https://api.github.com/users/mattqzhang","html_url":"https://github.com/mattqzhang","followers_url":"https://api.github.com/users/mattqzhang/followers","following_url":"https://api.github.com/users/mattqzhang/following{/other_user}","gists_url":"https://api.github.com/users/mattqzhang/gists{/gist_id}","starred_url":"https://api.github.com/users/mattqzhang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattqzhang/subscriptions","organizations_url":"https://api.github.com/users/mattqzhang/orgs","repos_url":"https://api.github.com/users/mattqzhang/repos","events_url":"https://api.github.com/users/mattqzhang/events{/privacy}","received_events_url":"https://api.github.com/users/mattqzhang/received_events","type":"User","site_admin":false},"repo":{"id":69514020,"name":"apex-malhar","full_name":"mattqzhang/apex-malhar","owner":{"login":"mattqzhang","id":3394891,"avatar_url":"https://avatars.githubusercontent.com/u/3394891?v=3","gravatar_id":"","url":"https://api.github.com/users/mattqzhang","html_url":"https://github.com/mattqzhang","followers_url":"https://api.github.com/users/mattqzhang/followers","following_url":"https://api.github.com/users/mattqzhang/following{/other_user}","gists_url":"https://api.github.com/users/mattqzhang/gists{/gist_id}","starred_url":"https://api.github.com/users/mattqzhang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattqzhang/subscriptions","organizations_url":"https://api.github.com/users/mattqzhang/orgs","repos_url":"https://api.github.com/users/mattqzhang/repos","events_url":"https://api.github.com/users/mattqzhang/events{/privacy}","received_events_url":"https://api.github.com/users/mattqzhang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mattqzhang/apex-malhar","description":"Mirror of Apache Apex malhar","fork":true,"url":"https://api.github.com/repos/mattqzhang/apex-malhar","forks_url":"https://api.github.com/repos/mattqzhang/apex-malhar/forks","keys_url":"https://api.github.com/repos/mattqzhang/apex-malhar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mattqzhang/apex-malhar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mattqzhang/apex-malhar/teams","hooks_url":"https://api.github.com/repos/mattqzhang/apex-malhar/hooks","issue_events_url":"https://api.github.com/repos/mattqzhang/apex-malhar/issues/events{/number}","events_url":"https://api.github.com/repos/mattqzhang/apex-malhar/events","assignees_url":"https://api.github.com/repos/mattqzhang/apex-malhar/assignees{/user}","branches_url":"https://api.github.com/repos/mattqzhang/apex-malhar/branches{/branch}","tags_url":"https://api.github.com/repos/mattqzhang/apex-malhar/tags","blobs_url":"https://api.github.com/repos/mattqzhang/apex-malhar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mattqzhang/apex-malhar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mattqzhang/apex-malhar/git/refs{/sha}","trees_url":"https://api.github.com/repos/mattqzhang/apex-malhar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mattqzhang/apex-malhar/statuses/{sha}","languages_url":"https://api.github.com/repos/mattqzhang/apex-malhar/languages","stargazers_url":"https://api.github.com/repos/mattqzhang/apex-malhar/stargazers","contributors_url":"https://api.github.com/repos/mattqzhang/apex-malhar/contributors","subscribers_url":"https://api.github.com/repos/mattqzhang/apex-malhar/subscribers","subscription_url":"https://api.github.com/repos/mattqzhang/apex-malhar/subscription","commits_url":"https://api.github.com/repos/mattqzhang/apex-malhar/commits{/sha}","git_commits_url":"https://api.github.com/repos/mattqzhang/apex-malhar/git/commits{/sha}","comments_url":"https://api.github.com/repos/mattqzhang/apex-malhar/comments{/number}","issue_comment_url":"https://api.github.com/repos/mattqzhang/apex-malhar/issues/comments{/number}","contents_url":"https://api.github.com/repos/mattqzhang/apex-malhar/contents/{+path}","compare_url":"https://api.github.com/repos/mattqzhang/apex-malhar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mattqzhang/apex-malhar/merges","archive_url":"https://api.github.com/repos/mattqzhang/apex-malhar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mattqzhang/apex-malhar/downloads","issues_url":"https://api.github.com/repos/mattqzhang/apex-malhar/issues{/number}","pulls_url":"https://api.github.com/repos/mattqzhang/apex-malhar/pulls{/number}","milestones_url":"https://api.github.com/repos/mattqzhang/apex-malhar/milestones{/number}","notifications_url":"https://api.github.com/repos/mattqzhang/apex-malhar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mattqzhang/apex-malhar/labels{/name}","releases_url":"https://api.github.com/repos/mattqzhang/apex-malhar/releases{/id}","deployments_url":"https://api.github.com/repos/mattqzhang/apex-malhar/deployments","created_at":"2016-09-29T00:10:59Z","updated_at":"2016-09-29T00:11:07Z","pushed_at":"2016-11-15T23:35:44Z","git_url":"git://github.com/mattqzhang/apex-malhar.git","ssh_url":"git@github.com:mattqzhang/apex-malhar.git","clone_url":"https://github.com/mattqzhang/apex-malhar.git","svn_url":"https://github.com/mattqzhang/apex-malhar","homepage":"","size":87707,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"9db044741a32d466c2df4d1582ca707fcce47402","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":41348334,"name":"apex-malhar","full_name":"apache/apex-malhar","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/apex-malhar","description":"Mirror of Apache Apex malhar","fork":false,"url":"https://api.github.com/repos/apache/apex-malhar","forks_url":"https://api.github.com/repos/apache/apex-malhar/forks","keys_url":"https://api.github.com/repos/apache/apex-malhar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/apex-malhar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/apex-malhar/teams","hooks_url":"https://api.github.com/repos/apache/apex-malhar/hooks","issue_events_url":"https://api.github.com/repos/apache/apex-malhar/issues/events{/number}","events_url":"https://api.github.com/repos/apache/apex-malhar/events","assignees_url":"https://api.github.com/repos/apache/apex-malhar/assignees{/user}","branches_url":"https://api.github.com/repos/apache/apex-malhar/branches{/branch}","tags_url":"https://api.github.com/repos/apache/apex-malhar/tags","blobs_url":"https://api.github.com/repos/apache/apex-malhar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/apex-malhar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/apex-malhar/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/apex-malhar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/apex-malhar/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/apex-malhar/languages","stargazers_url":"https://api.github.com/repos/apache/apex-malhar/stargazers","contributors_url":"https://api.github.com/repos/apache/apex-malhar/contributors","subscribers_url":"https://api.github.com/repos/apache/apex-malhar/subscribers","subscription_url":"https://api.github.com/repos/apache/apex-malhar/subscription","commits_url":"https://api.github.com/repos/apache/apex-malhar/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/apex-malhar/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/apex-malhar/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/apex-malhar/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/apex-malhar/contents/{+path}","compare_url":"https://api.github.com/repos/apache/apex-malhar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/apex-malhar/merges","archive_url":"https://api.github.com/repos/apache/apex-malhar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/apex-malhar/downloads","issues_url":"https://api.github.com/repos/apache/apex-malhar/issues{/number}","pulls_url":"https://api.github.com/repos/apache/apex-malhar/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/apex-malhar/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/apex-malhar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/apex-malhar/labels{/name}","releases_url":"https://api.github.com/repos/apache/apex-malhar/releases{/id}","deployments_url":"https://api.github.com/repos/apache/apex-malhar/deployments","created_at":"2015-08-25T07:00:05Z","updated_at":"2016-12-02T17:17:58Z","pushed_at":"2016-12-02T21:32:49Z","git_url":"git://github.com/apache/apex-malhar.git","ssh_url":"git@github.com:apache/apex-malhar.git","clone_url":"https://github.com/apache/apex-malhar.git","svn_url":"https://github.com/apache/apex-malhar","homepage":"","size":99764,"stargazers_count":69,"watchers_count":69,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":111,"mirror_url":"git://git.apache.org/incubator-apex-malhar.git","open_issues_count":33,"forks":111,"open_issues":33,"watchers":69,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/apex-malhar/pulls/490"},"html":{"href":"https://github.com/apache/apex-malhar/pull/490"},"issue":{"href":"https://api.github.com/repos/apache/apex-malhar/issues/490"},"comments":{"href":"https://api.github.com/repos/apache/apex-malhar/issues/490/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/apex-malhar/pulls/490/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/apex-malhar/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/apex-malhar/pulls/490/commits"},"statuses":{"href":"https://api.github.com/repos/apache/apex-malhar/statuses/99090dd843d986beb0febd6f4d644ceba4b47d6b"}}}}
{"actor":{"display_login":"mattqzhang"}}