{"action":"created","comment":{"url":"https://api.github.com/repos/mirage/mirage-tcpip/pulls/comments/80872400","pull_request_review_id":1894119,"id":80872400,"diff_hunk":"@@ -73,7 +73,6 @@ module Marshal = struct\n   let unsafe_fill ~pseudoheader ~payload t buf options_len =\n     let data_off = (sizeof_tcp / 4) + (options_len / 4) in\n     let buf = Cstruct.sub buf 0 (data_off * 4) in\n-    Cstruct.memset buf 0; (* autopad *)","path":"lib/tcp/tcp_packet.ml","position":4,"original_position":4,"commit_id":"a7d3dbd23fe97450366ccf0c256f29af7e3330eb","original_commit_id":"a7d3dbd23fe97450366ccf0c256f29af7e3330eb","user":{"login":"yomimono","id":4086825,"avatar_url":"https://avatars.githubusercontent.com/u/4086825?v=3","gravatar_id":"","url":"https://api.github.com/users/yomimono","html_url":"https://github.com/yomimono","followers_url":"https://api.github.com/users/yomimono/followers","following_url":"https://api.github.com/users/yomimono/following{/other_user}","gists_url":"https://api.github.com/users/yomimono/gists{/gist_id}","starred_url":"https://api.github.com/users/yomimono/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yomimono/subscriptions","organizations_url":"https://api.github.com/users/yomimono/orgs","repos_url":"https://api.github.com/users/yomimono/repos","events_url":"https://api.github.com/users/yomimono/events{/privacy}","received_events_url":"https://api.github.com/users/yomimono/received_events","type":"User","site_admin":false},"body":"Thanks @magnuss, I missed the link here.","created_at":"2016-09-28T09:08:06Z","updated_at":"2016-09-28T09:08:06Z","html_url":"https://github.com/mirage/mirage-tcpip/pull/250#discussion_r80872400","pull_request_url":"https://api.github.com/repos/mirage/mirage-tcpip/pulls/250","_links":{"self":{"href":"https://api.github.com/repos/mirage/mirage-tcpip/pulls/comments/80872400"},"html":{"href":"https://github.com/mirage/mirage-tcpip/pull/250#discussion_r80872400"},"pull_request":{"href":"https://api.github.com/repos/mirage/mirage-tcpip/pulls/250"}}},"pull_request":{"url":"https://api.github.com/repos/mirage/mirage-tcpip/pulls/250","id":87016412,"html_url":"https://github.com/mirage/mirage-tcpip/pull/250","diff_url":"https://github.com/mirage/mirage-tcpip/pull/250.diff","patch_url":"https://github.com/mirage/mirage-tcpip/pull/250.patch","issue_url":"https://api.github.com/repos/mirage/mirage-tcpip/issues/250","number":250,"state":"open","locked":false,"title":"Fix for #249 - removed redundant memset that was zeroing out all options","user":{"login":"balrajsingh","id":910481,"avatar_url":"https://avatars.githubusercontent.com/u/910481?v=3","gravatar_id":"","url":"https://api.github.com/users/balrajsingh","html_url":"https://github.com/balrajsingh","followers_url":"https://api.github.com/users/balrajsingh/followers","following_url":"https://api.github.com/users/balrajsingh/following{/other_user}","gists_url":"https://api.github.com/users/balrajsingh/gists{/gist_id}","starred_url":"https://api.github.com/users/balrajsingh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balrajsingh/subscriptions","organizations_url":"https://api.github.com/users/balrajsingh/orgs","repos_url":"https://api.github.com/users/balrajsingh/repos","events_url":"https://api.github.com/users/balrajsingh/events{/privacy}","received_events_url":"https://api.github.com/users/balrajsingh/received_events","type":"User","site_admin":false},"body":"Redundant since every header field must be set and is being set (or memoized).","created_at":"2016-09-27T21:33:12Z","updated_at":"2016-09-28T09:08:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"97290f33c7723360219f5e697f572a9d28f30d1e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mirage/mirage-tcpip/pulls/250/commits","review_comments_url":"https://api.github.com/repos/mirage/mirage-tcpip/pulls/250/comments","review_comment_url":"https://api.github.com/repos/mirage/mirage-tcpip/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mirage/mirage-tcpip/issues/250/comments","statuses_url":"https://api.github.com/repos/mirage/mirage-tcpip/statuses/a7d3dbd23fe97450366ccf0c256f29af7e3330eb","head":{"label":"balrajsingh:master","ref":"master","sha":"a7d3dbd23fe97450366ccf0c256f29af7e3330eb","user":{"login":"balrajsingh","id":910481,"avatar_url":"https://avatars.githubusercontent.com/u/910481?v=3","gravatar_id":"","url":"https://api.github.com/users/balrajsingh","html_url":"https://github.com/balrajsingh","followers_url":"https://api.github.com/users/balrajsingh/followers","following_url":"https://api.github.com/users/balrajsingh/following{/other_user}","gists_url":"https://api.github.com/users/balrajsingh/gists{/gist_id}","starred_url":"https://api.github.com/users/balrajsingh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balrajsingh/subscriptions","organizations_url":"https://api.github.com/users/balrajsingh/orgs","repos_url":"https://api.github.com/users/balrajsingh/repos","events_url":"https://api.github.com/users/balrajsingh/events{/privacy}","received_events_url":"https://api.github.com/users/balrajsingh/received_events","type":"User","site_admin":false},"repo":{"id":15686310,"name":"mirage-tcpip","full_name":"balrajsingh/mirage-tcpip","owner":{"login":"balrajsingh","id":910481,"avatar_url":"https://avatars.githubusercontent.com/u/910481?v=3","gravatar_id":"","url":"https://api.github.com/users/balrajsingh","html_url":"https://github.com/balrajsingh","followers_url":"https://api.github.com/users/balrajsingh/followers","following_url":"https://api.github.com/users/balrajsingh/following{/other_user}","gists_url":"https://api.github.com/users/balrajsingh/gists{/gist_id}","starred_url":"https://api.github.com/users/balrajsingh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balrajsingh/subscriptions","organizations_url":"https://api.github.com/users/balrajsingh/orgs","repos_url":"https://api.github.com/users/balrajsingh/repos","events_url":"https://api.github.com/users/balrajsingh/events{/privacy}","received_events_url":"https://api.github.com/users/balrajsingh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/balrajsingh/mirage-tcpip","description":"TCP/IP networking stack in pure OCaml, using the Mirage platform libraries.  Includes Ethernet, DHCP, ARP and TCP/IPv4 support.","fork":true,"url":"https://api.github.com/repos/balrajsingh/mirage-tcpip","forks_url":"https://api.github.com/repos/balrajsingh/mirage-tcpip/forks","keys_url":"https://api.github.com/repos/balrajsingh/mirage-tcpip/keys{/key_id}","collaborators_url":"https://api.github.com/repos/balrajsingh/mirage-tcpip/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/balrajsingh/mirage-tcpip/teams","hooks_url":"https://api.github.com/repos/balrajsingh/mirage-tcpip/hooks","issue_events_url":"https://api.github.com/repos/balrajsingh/mirage-tcpip/issues/events{/number}","events_url":"https://api.github.com/repos/balrajsingh/mirage-tcpip/events","assignees_url":"https://api.github.com/repos/balrajsingh/mirage-tcpip/assignees{/user}","branches_url":"https://api.github.com/repos/balrajsingh/mirage-tcpip/branches{/branch}","tags_url":"https://api.github.com/repos/balrajsingh/mirage-tcpip/tags","blobs_url":"https://api.github.com/repos/balrajsingh/mirage-tcpip/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/balrajsingh/mirage-tcpip/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/balrajsingh/mirage-tcpip/git/refs{/sha}","trees_url":"https://api.github.com/repos/balrajsingh/mirage-tcpip/git/trees{/sha}","statuses_url":"https://api.github.com/repos/balrajsingh/mirage-tcpip/statuses/{sha}","languages_url":"https://api.github.com/repos/balrajsingh/mirage-tcpip/languages","stargazers_url":"https://api.github.com/repos/balrajsingh/mirage-tcpip/stargazers","contributors_url":"https://api.github.com/repos/balrajsingh/mirage-tcpip/contributors","subscribers_url":"https://api.github.com/repos/balrajsingh/mirage-tcpip/subscribers","subscription_url":"https://api.github.com/repos/balrajsingh/mirage-tcpip/subscription","commits_url":"https://api.github.com/repos/balrajsingh/mirage-tcpip/commits{/sha}","git_commits_url":"https://api.github.com/repos/balrajsingh/mirage-tcpip/git/commits{/sha}","comments_url":"https://api.github.com/repos/balrajsingh/mirage-tcpip/comments{/number}","issue_comment_url":"https://api.github.com/repos/balrajsingh/mirage-tcpip/issues/comments{/number}","contents_url":"https://api.github.com/repos/balrajsingh/mirage-tcpip/contents/{+path}","compare_url":"https://api.github.com/repos/balrajsingh/mirage-tcpip/compare/{base}...{head}","merges_url":"https://api.github.com/repos/balrajsingh/mirage-tcpip/merges","archive_url":"https://api.github.com/repos/balrajsingh/mirage-tcpip/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/balrajsingh/mirage-tcpip/downloads","issues_url":"https://api.github.com/repos/balrajsingh/mirage-tcpip/issues{/number}","pulls_url":"https://api.github.com/repos/balrajsingh/mirage-tcpip/pulls{/number}","milestones_url":"https://api.github.com/repos/balrajsingh/mirage-tcpip/milestones{/number}","notifications_url":"https://api.github.com/repos/balrajsingh/mirage-tcpip/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/balrajsingh/mirage-tcpip/labels{/name}","releases_url":"https://api.github.com/repos/balrajsingh/mirage-tcpip/releases{/id}","deployments_url":"https://api.github.com/repos/balrajsingh/mirage-tcpip/deployments","created_at":"2014-01-06T21:44:58Z","updated_at":"2014-09-18T11:20:51Z","pushed_at":"2016-09-27T21:29:59Z","git_url":"git://github.com/balrajsingh/mirage-tcpip.git","ssh_url":"git@github.com:balrajsingh/mirage-tcpip.git","clone_url":"https://github.com/balrajsingh/mirage-tcpip.git","svn_url":"https://github.com/balrajsingh/mirage-tcpip","homepage":"http://www.openmirage.org/","size":1942,"stargazers_count":0,"watchers_count":0,"language":"OCaml","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mirage:master","ref":"master","sha":"2d924b3da58f02716ec9f54866bfdae920e836b8","user":{"login":"mirage","id":131943,"avatar_url":"https://avatars.githubusercontent.com/u/131943?v=3","gravatar_id":"","url":"https://api.github.com/users/mirage","html_url":"https://github.com/mirage","followers_url":"https://api.github.com/users/mirage/followers","following_url":"https://api.github.com/users/mirage/following{/other_user}","gists_url":"https://api.github.com/users/mirage/gists{/gist_id}","starred_url":"https://api.github.com/users/mirage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mirage/subscriptions","organizations_url":"https://api.github.com/users/mirage/orgs","repos_url":"https://api.github.com/users/mirage/repos","events_url":"https://api.github.com/users/mirage/events{/privacy}","received_events_url":"https://api.github.com/users/mirage/received_events","type":"Organization","site_admin":false},"repo":{"id":4724712,"name":"mirage-tcpip","full_name":"mirage/mirage-tcpip","owner":{"login":"mirage","id":131943,"avatar_url":"https://avatars.githubusercontent.com/u/131943?v=3","gravatar_id":"","url":"https://api.github.com/users/mirage","html_url":"https://github.com/mirage","followers_url":"https://api.github.com/users/mirage/followers","following_url":"https://api.github.com/users/mirage/following{/other_user}","gists_url":"https://api.github.com/users/mirage/gists{/gist_id}","starred_url":"https://api.github.com/users/mirage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mirage/subscriptions","organizations_url":"https://api.github.com/users/mirage/orgs","repos_url":"https://api.github.com/users/mirage/repos","events_url":"https://api.github.com/users/mirage/events{/privacy}","received_events_url":"https://api.github.com/users/mirage/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mirage/mirage-tcpip","description":"TCP/IP networking stack in pure OCaml, using the Mirage platform libraries.  Includes Ethernet, DHCP, ARP and TCP/IPv4 support.","fork":false,"url":"https://api.github.com/repos/mirage/mirage-tcpip","forks_url":"https://api.github.com/repos/mirage/mirage-tcpip/forks","keys_url":"https://api.github.com/repos/mirage/mirage-tcpip/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mirage/mirage-tcpip/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mirage/mirage-tcpip/teams","hooks_url":"https://api.github.com/repos/mirage/mirage-tcpip/hooks","issue_events_url":"https://api.github.com/repos/mirage/mirage-tcpip/issues/events{/number}","events_url":"https://api.github.com/repos/mirage/mirage-tcpip/events","assignees_url":"https://api.github.com/repos/mirage/mirage-tcpip/assignees{/user}","branches_url":"https://api.github.com/repos/mirage/mirage-tcpip/branches{/branch}","tags_url":"https://api.github.com/repos/mirage/mirage-tcpip/tags","blobs_url":"https://api.github.com/repos/mirage/mirage-tcpip/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mirage/mirage-tcpip/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mirage/mirage-tcpip/git/refs{/sha}","trees_url":"https://api.github.com/repos/mirage/mirage-tcpip/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mirage/mirage-tcpip/statuses/{sha}","languages_url":"https://api.github.com/repos/mirage/mirage-tcpip/languages","stargazers_url":"https://api.github.com/repos/mirage/mirage-tcpip/stargazers","contributors_url":"https://api.github.com/repos/mirage/mirage-tcpip/contributors","subscribers_url":"https://api.github.com/repos/mirage/mirage-tcpip/subscribers","subscription_url":"https://api.github.com/repos/mirage/mirage-tcpip/subscription","commits_url":"https://api.github.com/repos/mirage/mirage-tcpip/commits{/sha}","git_commits_url":"https://api.github.com/repos/mirage/mirage-tcpip/git/commits{/sha}","comments_url":"https://api.github.com/repos/mirage/mirage-tcpip/comments{/number}","issue_comment_url":"https://api.github.com/repos/mirage/mirage-tcpip/issues/comments{/number}","contents_url":"https://api.github.com/repos/mirage/mirage-tcpip/contents/{+path}","compare_url":"https://api.github.com/repos/mirage/mirage-tcpip/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mirage/mirage-tcpip/merges","archive_url":"https://api.github.com/repos/mirage/mirage-tcpip/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mirage/mirage-tcpip/downloads","issues_url":"https://api.github.com/repos/mirage/mirage-tcpip/issues{/number}","pulls_url":"https://api.github.com/repos/mirage/mirage-tcpip/pulls{/number}","milestones_url":"https://api.github.com/repos/mirage/mirage-tcpip/milestones{/number}","notifications_url":"https://api.github.com/repos/mirage/mirage-tcpip/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mirage/mirage-tcpip/labels{/name}","releases_url":"https://api.github.com/repos/mirage/mirage-tcpip/releases{/id}","deployments_url":"https://api.github.com/repos/mirage/mirage-tcpip/deployments","created_at":"2012-06-20T09:53:17Z","updated_at":"2016-09-21T05:50:15Z","pushed_at":"2016-09-27T21:33:12Z","git_url":"git://github.com/mirage/mirage-tcpip.git","ssh_url":"git@github.com:mirage/mirage-tcpip.git","clone_url":"https://github.com/mirage/mirage-tcpip.git","svn_url":"https://github.com/mirage/mirage-tcpip","homepage":"https://mirage.io","size":2329,"stargazers_count":84,"watchers_count":84,"language":"OCaml","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":42,"mirror_url":null,"open_issues_count":18,"forks":42,"open_issues":18,"watchers":84,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mirage/mirage-tcpip/pulls/250"},"html":{"href":"https://github.com/mirage/mirage-tcpip/pull/250"},"issue":{"href":"https://api.github.com/repos/mirage/mirage-tcpip/issues/250"},"comments":{"href":"https://api.github.com/repos/mirage/mirage-tcpip/issues/250/comments"},"review_comments":{"href":"https://api.github.com/repos/mirage/mirage-tcpip/pulls/250/comments"},"review_comment":{"href":"https://api.github.com/repos/mirage/mirage-tcpip/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mirage/mirage-tcpip/pulls/250/commits"},"statuses":{"href":"https://api.github.com/repos/mirage/mirage-tcpip/statuses/a7d3dbd23fe97450366ccf0c256f29af7e3330eb"}}}}
{"actor":{"display_login":"yomimono"}}