{"action":"created","comment":{"url":"https://api.github.com/repos/simplesamlphp/simplesamlphp/pulls/comments/49851275","id":49851275,"diff_hunk":"@@ -58,6 +58,7 @@\n \n $index = 0;\n $eps = array();\n+$supported_protocols = array();","path":"modules/saml/www/sp/metadata.php","position":4,"original_position":4,"commit_id":"3f46aa47c0a031dbefa96367f2d759b0d3d9e465","original_commit_id":"3f46aa47c0a031dbefa96367f2d759b0d3d9e465","user":{"login":"jaimeperez","id":1942728,"avatar_url":"https://avatars.githubusercontent.com/u/1942728?v=3","gravatar_id":"","url":"https://api.github.com/users/jaimeperez","html_url":"https://github.com/jaimeperez","followers_url":"https://api.github.com/users/jaimeperez/followers","following_url":"https://api.github.com/users/jaimeperez/following{/other_user}","gists_url":"https://api.github.com/users/jaimeperez/gists{/gist_id}","starred_url":"https://api.github.com/users/jaimeperez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaimeperez/subscriptions","organizations_url":"https://api.github.com/users/jaimeperez/orgs","repos_url":"https://api.github.com/users/jaimeperez/repos","events_url":"https://api.github.com/users/jaimeperez/events{/privacy}","received_events_url":"https://api.github.com/users/jaimeperez/received_events","type":"User","site_admin":false},"body":"I think this is the way to go and I really want to see this merged. However, there's a problem with backwards-compatibility. Our rule of thumb is that we try to keep backwards-compatibility always between minor versions (1.14 in this case). Metadata is a specially critical case where backwards-compatibility is essential for interoperability, so we always try to be extra careful with it.\r\n\r\nIn this case, this change would mean different metadata, so I think we need a configuration option to enable this, and set it to keep the current behaviour by default. Then you can switch that option to remove unused protocols depending on your configuration.\r\n\r\nLater on, when we release 2.0, I'd get rid of that option and make this the default behaviour. I wouldn't spend much time on documenting the configuration option therefore.\r\n\r\nHow does that sound?","created_at":"2016-01-15T13:10:58Z","updated_at":"2016-01-15T13:10:58Z","html_url":"https://github.com/simplesamlphp/simplesamlphp/pull/308#discussion_r49851275","pull_request_url":"https://api.github.com/repos/simplesamlphp/simplesamlphp/pulls/308","_links":{"self":{"href":"https://api.github.com/repos/simplesamlphp/simplesamlphp/pulls/comments/49851275"},"html":{"href":"https://github.com/simplesamlphp/simplesamlphp/pull/308#discussion_r49851275"},"pull_request":{"href":"https://api.github.com/repos/simplesamlphp/simplesamlphp/pulls/308"}}},"pull_request":{"url":"https://api.github.com/repos/simplesamlphp/simplesamlphp/pulls/308","id":56140102,"html_url":"https://github.com/simplesamlphp/simplesamlphp/pull/308","diff_url":"https://github.com/simplesamlphp/simplesamlphp/pull/308.diff","patch_url":"https://github.com/simplesamlphp/simplesamlphp/pull/308.patch","issue_url":"https://api.github.com/repos/simplesamlphp/simplesamlphp/issues/308","number":308,"state":"open","locked":false,"title":"support Basic Authorization to web proxy","user":{"login":"restena-sw","id":6346943,"avatar_url":"https://avatars.githubusercontent.com/u/6346943?v=3","gravatar_id":"","url":"https://api.github.com/users/restena-sw","html_url":"https://github.com/restena-sw","followers_url":"https://api.github.com/users/restena-sw/followers","following_url":"https://api.github.com/users/restena-sw/following{/other_user}","gists_url":"https://api.github.com/users/restena-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/restena-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/restena-sw/subscriptions","organizations_url":"https://api.github.com/users/restena-sw/orgs","repos_url":"https://api.github.com/users/restena-sw/repos","events_url":"https://api.github.com/users/restena-sw/events{/privacy}","received_events_url":"https://api.github.com/users/restena-sw/received_events","type":"User","site_admin":false},"body":"as discussed on the mailing list","created_at":"2016-01-15T07:54:31Z","updated_at":"2016-01-15T13:10:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"38b97e5fe8fd9bc84758a93a992efa4a7a4cf390","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/simplesamlphp/simplesamlphp/pulls/308/commits","review_comments_url":"https://api.github.com/repos/simplesamlphp/simplesamlphp/pulls/308/comments","review_comment_url":"https://api.github.com/repos/simplesamlphp/simplesamlphp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/simplesamlphp/simplesamlphp/issues/308/comments","statuses_url":"https://api.github.com/repos/simplesamlphp/simplesamlphp/statuses/3f46aa47c0a031dbefa96367f2d759b0d3d9e465","head":{"label":"restena-sw:simplesamlphp-1.14","ref":"simplesamlphp-1.14","sha":"3f46aa47c0a031dbefa96367f2d759b0d3d9e465","user":{"login":"restena-sw","id":6346943,"avatar_url":"https://avatars.githubusercontent.com/u/6346943?v=3","gravatar_id":"","url":"https://api.github.com/users/restena-sw","html_url":"https://github.com/restena-sw","followers_url":"https://api.github.com/users/restena-sw/followers","following_url":"https://api.github.com/users/restena-sw/following{/other_user}","gists_url":"https://api.github.com/users/restena-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/restena-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/restena-sw/subscriptions","organizations_url":"https://api.github.com/users/restena-sw/orgs","repos_url":"https://api.github.com/users/restena-sw/repos","events_url":"https://api.github.com/users/restena-sw/events{/privacy}","received_events_url":"https://api.github.com/users/restena-sw/received_events","type":"User","site_admin":false},"repo":{"id":49704171,"name":"simplesamlphp","full_name":"restena-sw/simplesamlphp","owner":{"login":"restena-sw","id":6346943,"avatar_url":"https://avatars.githubusercontent.com/u/6346943?v=3","gravatar_id":"","url":"https://api.github.com/users/restena-sw","html_url":"https://github.com/restena-sw","followers_url":"https://api.github.com/users/restena-sw/followers","following_url":"https://api.github.com/users/restena-sw/following{/other_user}","gists_url":"https://api.github.com/users/restena-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/restena-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/restena-sw/subscriptions","organizations_url":"https://api.github.com/users/restena-sw/orgs","repos_url":"https://api.github.com/users/restena-sw/repos","events_url":"https://api.github.com/users/restena-sw/events{/privacy}","received_events_url":"https://api.github.com/users/restena-sw/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/restena-sw/simplesamlphp","description":"SimpleSAMLphp is an award-winning application written in native PHP that deals with authentication.","fork":true,"url":"https://api.github.com/repos/restena-sw/simplesamlphp","forks_url":"https://api.github.com/repos/restena-sw/simplesamlphp/forks","keys_url":"https://api.github.com/repos/restena-sw/simplesamlphp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/restena-sw/simplesamlphp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/restena-sw/simplesamlphp/teams","hooks_url":"https://api.github.com/repos/restena-sw/simplesamlphp/hooks","issue_events_url":"https://api.github.com/repos/restena-sw/simplesamlphp/issues/events{/number}","events_url":"https://api.github.com/repos/restena-sw/simplesamlphp/events","assignees_url":"https://api.github.com/repos/restena-sw/simplesamlphp/assignees{/user}","branches_url":"https://api.github.com/repos/restena-sw/simplesamlphp/branches{/branch}","tags_url":"https://api.github.com/repos/restena-sw/simplesamlphp/tags","blobs_url":"https://api.github.com/repos/restena-sw/simplesamlphp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/restena-sw/simplesamlphp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/restena-sw/simplesamlphp/git/refs{/sha}","trees_url":"https://api.github.com/repos/restena-sw/simplesamlphp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/restena-sw/simplesamlphp/statuses/{sha}","languages_url":"https://api.github.com/repos/restena-sw/simplesamlphp/languages","stargazers_url":"https://api.github.com/repos/restena-sw/simplesamlphp/stargazers","contributors_url":"https://api.github.com/repos/restena-sw/simplesamlphp/contributors","subscribers_url":"https://api.github.com/repos/restena-sw/simplesamlphp/subscribers","subscription_url":"https://api.github.com/repos/restena-sw/simplesamlphp/subscription","commits_url":"https://api.github.com/repos/restena-sw/simplesamlphp/commits{/sha}","git_commits_url":"https://api.github.com/repos/restena-sw/simplesamlphp/git/commits{/sha}","comments_url":"https://api.github.com/repos/restena-sw/simplesamlphp/comments{/number}","issue_comment_url":"https://api.github.com/repos/restena-sw/simplesamlphp/issues/comments{/number}","contents_url":"https://api.github.com/repos/restena-sw/simplesamlphp/contents/{+path}","compare_url":"https://api.github.com/repos/restena-sw/simplesamlphp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/restena-sw/simplesamlphp/merges","archive_url":"https://api.github.com/repos/restena-sw/simplesamlphp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/restena-sw/simplesamlphp/downloads","issues_url":"https://api.github.com/repos/restena-sw/simplesamlphp/issues{/number}","pulls_url":"https://api.github.com/repos/restena-sw/simplesamlphp/pulls{/number}","milestones_url":"https://api.github.com/repos/restena-sw/simplesamlphp/milestones{/number}","notifications_url":"https://api.github.com/repos/restena-sw/simplesamlphp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/restena-sw/simplesamlphp/labels{/name}","releases_url":"https://api.github.com/repos/restena-sw/simplesamlphp/releases{/id}","created_at":"2016-01-15T07:38:54Z","updated_at":"2016-01-15T07:38:55Z","pushed_at":"2016-01-15T08:13:51Z","git_url":"git://github.com/restena-sw/simplesamlphp.git","ssh_url":"git@github.com:restena-sw/simplesamlphp.git","clone_url":"https://github.com/restena-sw/simplesamlphp.git","svn_url":"https://github.com/restena-sw/simplesamlphp","homepage":null,"size":11380,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"simplesamlphp:simplesamlphp-1.14","ref":"simplesamlphp-1.14","sha":"e424efa3d209b6750d39abab18dda4a0365375c2","user":{"login":"simplesamlphp","id":5774640,"avatar_url":"https://avatars.githubusercontent.com/u/5774640?v=3","gravatar_id":"","url":"https://api.github.com/users/simplesamlphp","html_url":"https://github.com/simplesamlphp","followers_url":"https://api.github.com/users/simplesamlphp/followers","following_url":"https://api.github.com/users/simplesamlphp/following{/other_user}","gists_url":"https://api.github.com/users/simplesamlphp/gists{/gist_id}","starred_url":"https://api.github.com/users/simplesamlphp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simplesamlphp/subscriptions","organizations_url":"https://api.github.com/users/simplesamlphp/orgs","repos_url":"https://api.github.com/users/simplesamlphp/repos","events_url":"https://api.github.com/users/simplesamlphp/events{/privacy}","received_events_url":"https://api.github.com/users/simplesamlphp/received_events","type":"Organization","site_admin":false},"repo":{"id":17167136,"name":"simplesamlphp","full_name":"simplesamlphp/simplesamlphp","owner":{"login":"simplesamlphp","id":5774640,"avatar_url":"https://avatars.githubusercontent.com/u/5774640?v=3","gravatar_id":"","url":"https://api.github.com/users/simplesamlphp","html_url":"https://github.com/simplesamlphp","followers_url":"https://api.github.com/users/simplesamlphp/followers","following_url":"https://api.github.com/users/simplesamlphp/following{/other_user}","gists_url":"https://api.github.com/users/simplesamlphp/gists{/gist_id}","starred_url":"https://api.github.com/users/simplesamlphp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simplesamlphp/subscriptions","organizations_url":"https://api.github.com/users/simplesamlphp/orgs","repos_url":"https://api.github.com/users/simplesamlphp/repos","events_url":"https://api.github.com/users/simplesamlphp/events{/privacy}","received_events_url":"https://api.github.com/users/simplesamlphp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/simplesamlphp/simplesamlphp","description":"SimpleSAMLphp is an award-winning application written in native PHP that deals with authentication.","fork":false,"url":"https://api.github.com/repos/simplesamlphp/simplesamlphp","forks_url":"https://api.github.com/repos/simplesamlphp/simplesamlphp/forks","keys_url":"https://api.github.com/repos/simplesamlphp/simplesamlphp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/simplesamlphp/simplesamlphp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/simplesamlphp/simplesamlphp/teams","hooks_url":"https://api.github.com/repos/simplesamlphp/simplesamlphp/hooks","issue_events_url":"https://api.github.com/repos/simplesamlphp/simplesamlphp/issues/events{/number}","events_url":"https://api.github.com/repos/simplesamlphp/simplesamlphp/events","assignees_url":"https://api.github.com/repos/simplesamlphp/simplesamlphp/assignees{/user}","branches_url":"https://api.github.com/repos/simplesamlphp/simplesamlphp/branches{/branch}","tags_url":"https://api.github.com/repos/simplesamlphp/simplesamlphp/tags","blobs_url":"https://api.github.com/repos/simplesamlphp/simplesamlphp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/simplesamlphp/simplesamlphp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/simplesamlphp/simplesamlphp/git/refs{/sha}","trees_url":"https://api.github.com/repos/simplesamlphp/simplesamlphp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/simplesamlphp/simplesamlphp/statuses/{sha}","languages_url":"https://api.github.com/repos/simplesamlphp/simplesamlphp/languages","stargazers_url":"https://api.github.com/repos/simplesamlphp/simplesamlphp/stargazers","contributors_url":"https://api.github.com/repos/simplesamlphp/simplesamlphp/contributors","subscribers_url":"https://api.github.com/repos/simplesamlphp/simplesamlphp/subscribers","subscription_url":"https://api.github.com/repos/simplesamlphp/simplesamlphp/subscription","commits_url":"https://api.github.com/repos/simplesamlphp/simplesamlphp/commits{/sha}","git_commits_url":"https://api.github.com/repos/simplesamlphp/simplesamlphp/git/commits{/sha}","comments_url":"https://api.github.com/repos/simplesamlphp/simplesamlphp/comments{/number}","issue_comment_url":"https://api.github.com/repos/simplesamlphp/simplesamlphp/issues/comments{/number}","contents_url":"https://api.github.com/repos/simplesamlphp/simplesamlphp/contents/{+path}","compare_url":"https://api.github.com/repos/simplesamlphp/simplesamlphp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/simplesamlphp/simplesamlphp/merges","archive_url":"https://api.github.com/repos/simplesamlphp/simplesamlphp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/simplesamlphp/simplesamlphp/downloads","issues_url":"https://api.github.com/repos/simplesamlphp/simplesamlphp/issues{/number}","pulls_url":"https://api.github.com/repos/simplesamlphp/simplesamlphp/pulls{/number}","milestones_url":"https://api.github.com/repos/simplesamlphp/simplesamlphp/milestones{/number}","notifications_url":"https://api.github.com/repos/simplesamlphp/simplesamlphp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/simplesamlphp/simplesamlphp/labels{/name}","releases_url":"https://api.github.com/repos/simplesamlphp/simplesamlphp/releases{/id}","created_at":"2014-02-25T09:01:45Z","updated_at":"2016-01-13T00:59:26Z","pushed_at":"2016-01-15T08:13:52Z","git_url":"git://github.com/simplesamlphp/simplesamlphp.git","ssh_url":"git@github.com:simplesamlphp/simplesamlphp.git","clone_url":"https://github.com/simplesamlphp/simplesamlphp.git","svn_url":"https://github.com/simplesamlphp/simplesamlphp","homepage":null,"size":13405,"stargazers_count":193,"watchers_count":193,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":165,"mirror_url":null,"open_issues_count":86,"forks":165,"open_issues":86,"watchers":193,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/simplesamlphp/simplesamlphp/pulls/308"},"html":{"href":"https://github.com/simplesamlphp/simplesamlphp/pull/308"},"issue":{"href":"https://api.github.com/repos/simplesamlphp/simplesamlphp/issues/308"},"comments":{"href":"https://api.github.com/repos/simplesamlphp/simplesamlphp/issues/308/comments"},"review_comments":{"href":"https://api.github.com/repos/simplesamlphp/simplesamlphp/pulls/308/comments"},"review_comment":{"href":"https://api.github.com/repos/simplesamlphp/simplesamlphp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/simplesamlphp/simplesamlphp/pulls/308/commits"},"statuses":{"href":"https://api.github.com/repos/simplesamlphp/simplesamlphp/statuses/3f46aa47c0a031dbefa96367f2d759b0d3d9e465"}}}}