{"action":"closed","number":2209,"pull_request":{"url":"https://api.github.com/repos/erikras/redux-form/pulls/2209","id":96229878,"html_url":"https://github.com/erikras/redux-form/pull/2209","diff_url":"https://github.com/erikras/redux-form/pull/2209.diff","patch_url":"https://github.com/erikras/redux-form/pull/2209.patch","issue_url":"https://api.github.com/repos/erikras/redux-form/issues/2209","number":2209,"state":"closed","locked":false,"title":"deepEqual fix so it doesn't treat 1 and 1. as equal","user":{"login":"DanialK","id":2878450,"avatar_url":"https://avatars.githubusercontent.com/u/2878450?v=3","gravatar_id":"","url":"https://api.github.com/users/DanialK","html_url":"https://github.com/DanialK","followers_url":"https://api.github.com/users/DanialK/followers","following_url":"https://api.github.com/users/DanialK/following{/other_user}","gists_url":"https://api.github.com/users/DanialK/gists{/gist_id}","starred_url":"https://api.github.com/users/DanialK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanialK/subscriptions","organizations_url":"https://api.github.com/users/DanialK/orgs","repos_url":"https://api.github.com/users/DanialK/repos","events_url":"https://api.github.com/users/DanialK/events{/privacy}","received_events_url":"https://api.github.com/users/DanialK/received_events","type":"User","site_admin":false},"body":"Hello,\r\n\r\nLong story short, in our project we have a NumberField that gets number values (int and float) from the user and keeps them as a valid js number in the store. However, if they want to enter floating points, as soon as they start typing `\".\"` we can't transfer that to a number (as `Number(\"10.\") === 10)` so essentially user won't be able to type `\".\"`) so we have to save it in the redux form state as a string `\"10.\" ` (previously it was a number) till user puts some valid decimal points.\r\n\r\nBut the Field component doesn't re-render because the ConnectedField uses deepEqual in its shouldComponentUpdate and deepEqual is doing `if (obj == other) return true` instead of `if (obj === other) return true` and in JS `(\"1.\" == 1) === true`(I thought we've all read the [JavaScript: The Good Parts](http://shop.oreilly.com/product/9780596517748.do) 😛  just joking you guys are awesome).\r\n\r\nit's a small change and I've added a new test for it in the `deepEqual.spec.js` and everything passes. It would be great if we could merge this asap.\r\n\r\nThank you very much\r\n","created_at":"2016-12-02T06:47:32Z","updated_at":"2016-12-02T09:50:15Z","closed_at":"2016-12-02T09:50:14Z","merged_at":"2016-12-02T09:50:14Z","merge_commit_sha":"37adcbeed35d24a7d02e10ed8267e89992263920","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/erikras/redux-form/pulls/2209/commits","review_comments_url":"https://api.github.com/repos/erikras/redux-form/pulls/2209/comments","review_comment_url":"https://api.github.com/repos/erikras/redux-form/pulls/comments{/number}","comments_url":"https://api.github.com/repos/erikras/redux-form/issues/2209/comments","statuses_url":"https://api.github.com/repos/erikras/redux-form/statuses/d79752a5749bd8e7e2fa11a73158ab3389d3190c","head":{"label":"DanialK:master","ref":"master","sha":"d79752a5749bd8e7e2fa11a73158ab3389d3190c","user":{"login":"DanialK","id":2878450,"avatar_url":"https://avatars.githubusercontent.com/u/2878450?v=3","gravatar_id":"","url":"https://api.github.com/users/DanialK","html_url":"https://github.com/DanialK","followers_url":"https://api.github.com/users/DanialK/followers","following_url":"https://api.github.com/users/DanialK/following{/other_user}","gists_url":"https://api.github.com/users/DanialK/gists{/gist_id}","starred_url":"https://api.github.com/users/DanialK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanialK/subscriptions","organizations_url":"https://api.github.com/users/DanialK/orgs","repos_url":"https://api.github.com/users/DanialK/repos","events_url":"https://api.github.com/users/DanialK/events{/privacy}","received_events_url":"https://api.github.com/users/DanialK/received_events","type":"User","site_admin":false},"repo":{"id":75366793,"name":"redux-form","full_name":"DanialK/redux-form","owner":{"login":"DanialK","id":2878450,"avatar_url":"https://avatars.githubusercontent.com/u/2878450?v=3","gravatar_id":"","url":"https://api.github.com/users/DanialK","html_url":"https://github.com/DanialK","followers_url":"https://api.github.com/users/DanialK/followers","following_url":"https://api.github.com/users/DanialK/following{/other_user}","gists_url":"https://api.github.com/users/DanialK/gists{/gist_id}","starred_url":"https://api.github.com/users/DanialK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanialK/subscriptions","organizations_url":"https://api.github.com/users/DanialK/orgs","repos_url":"https://api.github.com/users/DanialK/repos","events_url":"https://api.github.com/users/DanialK/events{/privacy}","received_events_url":"https://api.github.com/users/DanialK/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DanialK/redux-form","description":"A Higher Order Component using react-redux to keep form state in a Redux store","fork":true,"url":"https://api.github.com/repos/DanialK/redux-form","forks_url":"https://api.github.com/repos/DanialK/redux-form/forks","keys_url":"https://api.github.com/repos/DanialK/redux-form/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DanialK/redux-form/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DanialK/redux-form/teams","hooks_url":"https://api.github.com/repos/DanialK/redux-form/hooks","issue_events_url":"https://api.github.com/repos/DanialK/redux-form/issues/events{/number}","events_url":"https://api.github.com/repos/DanialK/redux-form/events","assignees_url":"https://api.github.com/repos/DanialK/redux-form/assignees{/user}","branches_url":"https://api.github.com/repos/DanialK/redux-form/branches{/branch}","tags_url":"https://api.github.com/repos/DanialK/redux-form/tags","blobs_url":"https://api.github.com/repos/DanialK/redux-form/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DanialK/redux-form/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DanialK/redux-form/git/refs{/sha}","trees_url":"https://api.github.com/repos/DanialK/redux-form/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DanialK/redux-form/statuses/{sha}","languages_url":"https://api.github.com/repos/DanialK/redux-form/languages","stargazers_url":"https://api.github.com/repos/DanialK/redux-form/stargazers","contributors_url":"https://api.github.com/repos/DanialK/redux-form/contributors","subscribers_url":"https://api.github.com/repos/DanialK/redux-form/subscribers","subscription_url":"https://api.github.com/repos/DanialK/redux-form/subscription","commits_url":"https://api.github.com/repos/DanialK/redux-form/commits{/sha}","git_commits_url":"https://api.github.com/repos/DanialK/redux-form/git/commits{/sha}","comments_url":"https://api.github.com/repos/DanialK/redux-form/comments{/number}","issue_comment_url":"https://api.github.com/repos/DanialK/redux-form/issues/comments{/number}","contents_url":"https://api.github.com/repos/DanialK/redux-form/contents/{+path}","compare_url":"https://api.github.com/repos/DanialK/redux-form/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DanialK/redux-form/merges","archive_url":"https://api.github.com/repos/DanialK/redux-form/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DanialK/redux-form/downloads","issues_url":"https://api.github.com/repos/DanialK/redux-form/issues{/number}","pulls_url":"https://api.github.com/repos/DanialK/redux-form/pulls{/number}","milestones_url":"https://api.github.com/repos/DanialK/redux-form/milestones{/number}","notifications_url":"https://api.github.com/repos/DanialK/redux-form/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DanialK/redux-form/labels{/name}","releases_url":"https://api.github.com/repos/DanialK/redux-form/releases{/id}","deployments_url":"https://api.github.com/repos/DanialK/redux-form/deployments","created_at":"2016-12-02T06:17:44Z","updated_at":"2016-12-02T06:17:46Z","pushed_at":"2016-12-02T06:25:59Z","git_url":"git://github.com/DanialK/redux-form.git","ssh_url":"git@github.com:DanialK/redux-form.git","clone_url":"https://github.com/DanialK/redux-form.git","svn_url":"https://github.com/DanialK/redux-form","homepage":"http://redux-form.com","size":121790,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"erikras:master","ref":"master","sha":"ef66e995219be4e291ed94e4adfd926025003a72","user":{"login":"erikras","id":4396759,"avatar_url":"https://avatars.githubusercontent.com/u/4396759?v=3","gravatar_id":"","url":"https://api.github.com/users/erikras","html_url":"https://github.com/erikras","followers_url":"https://api.github.com/users/erikras/followers","following_url":"https://api.github.com/users/erikras/following{/other_user}","gists_url":"https://api.github.com/users/erikras/gists{/gist_id}","starred_url":"https://api.github.com/users/erikras/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikras/subscriptions","organizations_url":"https://api.github.com/users/erikras/orgs","repos_url":"https://api.github.com/users/erikras/repos","events_url":"https://api.github.com/users/erikras/events{/privacy}","received_events_url":"https://api.github.com/users/erikras/received_events","type":"User","site_admin":false},"repo":{"id":40013435,"name":"redux-form","full_name":"erikras/redux-form","owner":{"login":"erikras","id":4396759,"avatar_url":"https://avatars.githubusercontent.com/u/4396759?v=3","gravatar_id":"","url":"https://api.github.com/users/erikras","html_url":"https://github.com/erikras","followers_url":"https://api.github.com/users/erikras/followers","following_url":"https://api.github.com/users/erikras/following{/other_user}","gists_url":"https://api.github.com/users/erikras/gists{/gist_id}","starred_url":"https://api.github.com/users/erikras/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikras/subscriptions","organizations_url":"https://api.github.com/users/erikras/orgs","repos_url":"https://api.github.com/users/erikras/repos","events_url":"https://api.github.com/users/erikras/events{/privacy}","received_events_url":"https://api.github.com/users/erikras/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/erikras/redux-form","description":"A Higher Order Component using react-redux to keep form state in a Redux store","fork":false,"url":"https://api.github.com/repos/erikras/redux-form","forks_url":"https://api.github.com/repos/erikras/redux-form/forks","keys_url":"https://api.github.com/repos/erikras/redux-form/keys{/key_id}","collaborators_url":"https://api.github.com/repos/erikras/redux-form/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/erikras/redux-form/teams","hooks_url":"https://api.github.com/repos/erikras/redux-form/hooks","issue_events_url":"https://api.github.com/repos/erikras/redux-form/issues/events{/number}","events_url":"https://api.github.com/repos/erikras/redux-form/events","assignees_url":"https://api.github.com/repos/erikras/redux-form/assignees{/user}","branches_url":"https://api.github.com/repos/erikras/redux-form/branches{/branch}","tags_url":"https://api.github.com/repos/erikras/redux-form/tags","blobs_url":"https://api.github.com/repos/erikras/redux-form/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/erikras/redux-form/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/erikras/redux-form/git/refs{/sha}","trees_url":"https://api.github.com/repos/erikras/redux-form/git/trees{/sha}","statuses_url":"https://api.github.com/repos/erikras/redux-form/statuses/{sha}","languages_url":"https://api.github.com/repos/erikras/redux-form/languages","stargazers_url":"https://api.github.com/repos/erikras/redux-form/stargazers","contributors_url":"https://api.github.com/repos/erikras/redux-form/contributors","subscribers_url":"https://api.github.com/repos/erikras/redux-form/subscribers","subscription_url":"https://api.github.com/repos/erikras/redux-form/subscription","commits_url":"https://api.github.com/repos/erikras/redux-form/commits{/sha}","git_commits_url":"https://api.github.com/repos/erikras/redux-form/git/commits{/sha}","comments_url":"https://api.github.com/repos/erikras/redux-form/comments{/number}","issue_comment_url":"https://api.github.com/repos/erikras/redux-form/issues/comments{/number}","contents_url":"https://api.github.com/repos/erikras/redux-form/contents/{+path}","compare_url":"https://api.github.com/repos/erikras/redux-form/compare/{base}...{head}","merges_url":"https://api.github.com/repos/erikras/redux-form/merges","archive_url":"https://api.github.com/repos/erikras/redux-form/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/erikras/redux-form/downloads","issues_url":"https://api.github.com/repos/erikras/redux-form/issues{/number}","pulls_url":"https://api.github.com/repos/erikras/redux-form/pulls{/number}","milestones_url":"https://api.github.com/repos/erikras/redux-form/milestones{/number}","notifications_url":"https://api.github.com/repos/erikras/redux-form/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/erikras/redux-form/labels{/name}","releases_url":"https://api.github.com/repos/erikras/redux-form/releases{/id}","deployments_url":"https://api.github.com/repos/erikras/redux-form/deployments","created_at":"2015-07-31T16:07:03Z","updated_at":"2016-12-02T06:52:43Z","pushed_at":"2016-12-02T09:50:14Z","git_url":"git://github.com/erikras/redux-form.git","ssh_url":"git@github.com:erikras/redux-form.git","clone_url":"https://github.com/erikras/redux-form.git","svn_url":"https://github.com/erikras/redux-form","homepage":"http://redux-form.com","size":122884,"stargazers_count":4493,"watchers_count":4493,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":517,"mirror_url":null,"open_issues_count":526,"forks":517,"open_issues":526,"watchers":4493,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/erikras/redux-form/pulls/2209"},"html":{"href":"https://github.com/erikras/redux-form/pull/2209"},"issue":{"href":"https://api.github.com/repos/erikras/redux-form/issues/2209"},"comments":{"href":"https://api.github.com/repos/erikras/redux-form/issues/2209/comments"},"review_comments":{"href":"https://api.github.com/repos/erikras/redux-form/pulls/2209/comments"},"review_comment":{"href":"https://api.github.com/repos/erikras/redux-form/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/erikras/redux-form/pulls/2209/commits"},"statuses":{"href":"https://api.github.com/repos/erikras/redux-form/statuses/d79752a5749bd8e7e2fa11a73158ab3389d3190c"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"erikras","id":4396759,"avatar_url":"https://avatars.githubusercontent.com/u/4396759?v=3","gravatar_id":"","url":"https://api.github.com/users/erikras","html_url":"https://github.com/erikras","followers_url":"https://api.github.com/users/erikras/followers","following_url":"https://api.github.com/users/erikras/following{/other_user}","gists_url":"https://api.github.com/users/erikras/gists{/gist_id}","starred_url":"https://api.github.com/users/erikras/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikras/subscriptions","organizations_url":"https://api.github.com/users/erikras/orgs","repos_url":"https://api.github.com/users/erikras/repos","events_url":"https://api.github.com/users/erikras/events{/privacy}","received_events_url":"https://api.github.com/users/erikras/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":8,"deletions":1,"changed_files":2}}
{"actor":{"display_login":"erikras"}}