{"action":"created","issue":{"url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/issues/458","repository_url":"https://api.github.com/repos/Automattic/woocommerce-connect-client","labels_url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/issues/458/labels{/name}","comments_url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/issues/458/comments","events_url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/issues/458/events","html_url":"https://github.com/Automattic/woocommerce-connect-client/pull/458","id":165311083,"number":458,"title":"[Labels] Address suggestions","user":{"login":"DanReyLop","id":1715800,"avatar_url":"https://avatars.githubusercontent.com/u/1715800?v=3","gravatar_id":"","url":"https://api.github.com/users/DanReyLop","html_url":"https://github.com/DanReyLop","followers_url":"https://api.github.com/users/DanReyLop/followers","following_url":"https://api.github.com/users/DanReyLop/following{/other_user}","gists_url":"https://api.github.com/users/DanReyLop/gists{/gist_id}","starred_url":"https://api.github.com/users/DanReyLop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanReyLop/subscriptions","organizations_url":"https://api.github.com/users/DanReyLop/orgs","repos_url":"https://api.github.com/users/DanReyLop/repos","events_url":"https://api.github.com/users/DanReyLop/events{/privacy}","received_events_url":"https://api.github.com/users/DanReyLop/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/labels/[Status]%20Needs%20Author%20Reply","name":"[Status] Needs Author Reply","color":"eb6420"}],"state":"open","locked":false,"assignee":{"login":"DanReyLop","id":1715800,"avatar_url":"https://avatars.githubusercontent.com/u/1715800?v=3","gravatar_id":"","url":"https://api.github.com/users/DanReyLop","html_url":"https://github.com/DanReyLop","followers_url":"https://api.github.com/users/DanReyLop/followers","following_url":"https://api.github.com/users/DanReyLop/following{/other_user}","gists_url":"https://api.github.com/users/DanReyLop/gists{/gist_id}","starred_url":"https://api.github.com/users/DanReyLop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanReyLop/subscriptions","organizations_url":"https://api.github.com/users/DanReyLop/orgs","repos_url":"https://api.github.com/users/DanReyLop/repos","events_url":"https://api.github.com/users/DanReyLop/events{/privacy}","received_events_url":"https://api.github.com/users/DanReyLop/received_events","type":"User","site_admin":false},"assignees":[{"login":"DanReyLop","id":1715800,"avatar_url":"https://avatars.githubusercontent.com/u/1715800?v=3","gravatar_id":"","url":"https://api.github.com/users/DanReyLop","html_url":"https://github.com/DanReyLop","followers_url":"https://api.github.com/users/DanReyLop/followers","following_url":"https://api.github.com/users/DanReyLop/following{/other_user}","gists_url":"https://api.github.com/users/DanReyLop/gists{/gist_id}","starred_url":"https://api.github.com/users/DanReyLop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanReyLop/subscriptions","organizations_url":"https://api.github.com/users/DanReyLop/orgs","repos_url":"https://api.github.com/users/DanReyLop/repos","events_url":"https://api.github.com/users/DanReyLop/events{/privacy}","received_events_url":"https://api.github.com/users/DanReyLop/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/milestones/6","html_url":"https://github.com/Automattic/woocommerce-connect-client/milestones/Sprint%203%20(7/18-8/5)","labels_url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/milestones/6/labels","id":1875914,"number":6,"title":"Sprint 3 (7/18-8/5)","description":"* Not doing free shipping flow yet\r\n* Label cached in wp-uploads\r\n* Packing solution and rate details in order meta and used in Rates Tab of Label UI\r\n* Label UI will support potential multiple packages for order","creator":{"login":"allendav","id":1595739,"avatar_url":"https://avatars.githubusercontent.com/u/1595739?v=3","gravatar_id":"","url":"https://api.github.com/users/allendav","html_url":"https://github.com/allendav","followers_url":"https://api.github.com/users/allendav/followers","following_url":"https://api.github.com/users/allendav/following{/other_user}","gists_url":"https://api.github.com/users/allendav/gists{/gist_id}","starred_url":"https://api.github.com/users/allendav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allendav/subscriptions","organizations_url":"https://api.github.com/users/allendav/orgs","repos_url":"https://api.github.com/users/allendav/repos","events_url":"https://api.github.com/users/allendav/events{/privacy}","received_events_url":"https://api.github.com/users/allendav/received_events","type":"User","site_admin":false},"open_issues":11,"closed_issues":2,"state":"open","created_at":"2016-07-11T14:08:58Z","updated_at":"2016-07-25T19:53:51Z","due_on":"2016-08-04T22:00:00Z","closed_at":null},"comments":7,"created_at":"2016-07-13T12:43:37Z","updated_at":"2016-07-26T06:22:33Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/pulls/458","html_url":"https://github.com/Automattic/woocommerce-connect-client/pull/458","diff_url":"https://github.com/Automattic/woocommerce-connect-client/pull/458.diff","patch_url":"https://github.com/Automattic/woocommerce-connect-client/pull/458.patch"},"body":"Fixes #439 \r\n\r\nThis PR is big so if you want you can review individual commits.\r\n\r\n* https://github.com/Automattic/woocommerce-connect-client/commit/8eff5da3fc7a15c843197627ccac00a29dd654df has an important change: instead of the server returning just a list of errant fields, for each field it can return an arbitrary object. So, for example, for each field it can return a custom error message, or even indicate the level of severity of that error.\r\n* https://github.com/Automattic/woocommerce-connect-client/commit/afe7fa2f0261f33fc857bf5cdbab2bbf5942a3fe and https://github.com/Automattic/woocommerce-connect-client/commit/6d5ff532c8e3a921df6c862909b338e6cf2e6889 implement the actual address suggestion feature, implemented without caring much for code structure (so you can actually focus on the feature implementation).\r\n* The rest of commits are refactors and clean-ups.\r\n\r\nCurrent state of the UI:\r\n![address_suggestion](https://cloud.githubusercontent.com/assets/1715800/16803475/d874edc4-4906-11e6-9e63-78096219e345.png)\r\n\r\nSee #439 for the expected behaviour.\r\n\r\nInstructions to test (magic sauce):\r\n* The server will accept an address if the address name is `Hawk St`\r\n* If the address name is exactly `Awk St`, the server will _suggest_ to be changed to `Hawk St`\r\n* Any other street name will be a plain validation error. To show the power of the new error fields structure, the server will return a custom error message (`The server doesn't like that address!`)\r\n\r\n@jeffstieler @nabsul @allendav "},"comment":{"url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/issues/comments/235173770","html_url":"https://github.com/Automattic/woocommerce-connect-client/pull/458#issuecomment-235173770","issue_url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/issues/458","id":235173770,"user":{"login":"DanReyLop","id":1715800,"avatar_url":"https://avatars.githubusercontent.com/u/1715800?v=3","gravatar_id":"","url":"https://api.github.com/users/DanReyLop","html_url":"https://github.com/DanReyLop","followers_url":"https://api.github.com/users/DanReyLop/followers","following_url":"https://api.github.com/users/DanReyLop/following{/other_user}","gists_url":"https://api.github.com/users/DanReyLop/gists{/gist_id}","starred_url":"https://api.github.com/users/DanReyLop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanReyLop/subscriptions","organizations_url":"https://api.github.com/users/DanReyLop/orgs","repos_url":"https://api.github.com/users/DanReyLop/repos","events_url":"https://api.github.com/users/DanReyLop/events{/privacy}","received_events_url":"https://api.github.com/users/DanReyLop/received_events","type":"User","site_admin":false},"created_at":"2016-07-26T06:22:33Z","updated_at":"2016-07-26T06:22:33Z","body":"> It seems that once you've entered an origin address and hit next, that even if the label flow is not completed, that origin address should be retained on the merchant's host. Do you agree? Don't need to fix it here, but if you agree, please write a new issue.\r\n\r\n@allendav Already implemented :) See #456 "}}
{"actor":{"display_login":"DanReyLop"}}