{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/9091","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/9091/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/9091/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/9091/events","html_url":"https://github.com/nodejs/node/issues/9091","id":182928631,"number":9091,"title":"Process around new contributors in Node core","user":{"login":"addaleax","id":899444,"avatar_url":"https://avatars.githubusercontent.com/u/899444?v=3","gravatar_id":"","url":"https://api.github.com/users/addaleax","html_url":"https://github.com/addaleax","followers_url":"https://api.github.com/users/addaleax/followers","following_url":"https://api.github.com/users/addaleax/following{/other_user}","gists_url":"https://api.github.com/users/addaleax/gists{/gist_id}","starred_url":"https://api.github.com/users/addaleax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/addaleax/subscriptions","organizations_url":"https://api.github.com/users/addaleax/orgs","repos_url":"https://api.github.com/users/addaleax/repos","events_url":"https://api.github.com/users/addaleax/events{/privacy}","received_events_url":"https://api.github.com/users/addaleax/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/nodejs/node/labels/meta","name":"meta","color":"fef2c0"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2016-10-13T23:23:04Z","updated_at":"2016-10-15T18:13:05Z","closed_at":null,"body":"Hi everyone!\r\n\r\nI’ve been trying to gather some feedback on our collaboration process from talks with other collaborators, in particular relatively fresh ones.\r\n\r\nSo here’s a few things that emerged from that and that I would consider worth mentioning to everybody (and at least as a reminder to myself):\r\n- We are doing a good job at making people feel that contributions to core are a significant accomplishment, including the changes that don’t occur in `lib/` or `src/`. That’s awesome!\r\n- We should be clearer about what kind of changes are necessary to be performed by the author and what kind of changes can be done when landing. Github’s new distinction between Approved/Changes Required might be helpful, but I think it would be good to clarify the distinction every time, especially as the philosophy around this varies noticeably among the group of collaborators.\r\n- Likewise, there is a wide variance among us when it comes to the tone and role we take when approaching PRs and the effort of outsider contributors. We should generally try take on more of a mentoring than a judging role here, and if you don’t feel that you have the ability to be helpful in a given moment, keep in mind that you don’t have to review and answer to everything asap. Having a large and growing group of collaborators means that the work of guiding people’s efforts can be spread out among us!\r\n- Be flexible. As collaborators we are very familiar with all of the guidelines and formalities mutually agreed upon in the project, but outside contributors often are not. Their valuable effort shouldn’t be lost just because we are unwilling to help. If in doubt, trust the collaborator who lands a PR to fix any obvious issues or agreed-upon nits themselves.\r\n- A lot of our `good-first-contribution` issues are not very well-approachable, and we largely lack other proper resources that we can point newcomers to. NodeTodo and the Code + Learn sessions are good steps forward, and they clearly show that there is no scarcity of people who are willing to offer a bit of time and effort.\r\n\r\n(And again, just to be very clear: All of this are things where I’d like to see myself improve, too!)\r\n\r\nI’m going to close this issue in a few days if no significant discussion around anything comes up; in that case, just regard this as a general announcement and maybe something to take to heart. (Also: If you think this should have been posted somewhere else, please tell me. But this seemed like the best way to reach the wider @nodejs/collaborators group)."},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/254001103","html_url":"https://github.com/nodejs/node/issues/9091#issuecomment-254001103","issue_url":"https://api.github.com/repos/nodejs/node/issues/9091","id":254001103,"user":{"login":"bnoordhuis","id":275871,"avatar_url":"https://avatars.githubusercontent.com/u/275871?v=3","gravatar_id":"","url":"https://api.github.com/users/bnoordhuis","html_url":"https://github.com/bnoordhuis","followers_url":"https://api.github.com/users/bnoordhuis/followers","following_url":"https://api.github.com/users/bnoordhuis/following{/other_user}","gists_url":"https://api.github.com/users/bnoordhuis/gists{/gist_id}","starred_url":"https://api.github.com/users/bnoordhuis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bnoordhuis/subscriptions","organizations_url":"https://api.github.com/users/bnoordhuis/orgs","repos_url":"https://api.github.com/users/bnoordhuis/repos","events_url":"https://api.github.com/users/bnoordhuis/events{/privacy}","received_events_url":"https://api.github.com/users/bnoordhuis/received_events","type":"User","site_admin":false},"created_at":"2016-10-15T18:13:05Z","updated_at":"2016-10-15T18:13:05Z","body":"> automating the commit formatting and landing process would be a better option I believe\r\n\r\nHow would that work this side of the Singularity?  Writing up a good commit log is manual labor, no amount of tooling is going to fix that.  If you mean wrapping long lines, I don't think that is what is being discussed here.\r\n\r\n> I interpret comments that start with a variation of \"This has been discussed before\" as roughly equivalent to \"Ugh, this again?!?!\"\r\n\r\nMaybe it's a native/non-native speaker thing but I take such comments on face value, I don't read between the lines.  It's also how I intend it to be taken when I use the phrase myself.\r\n\r\nI don't think I'd use \"everyone is on the same page.\"  I can't quite articulate why but it feels subtly wrong.  Maybe it's because it presumes to speak for everyone involved when it's highly unlikely that everyone was indeed 100% in agreement, and even more unlikely that I know each person's personal beliefs well enough to speak with authority.\r\n\r\nIf you can come up with an alternative that has the word 'consensus' in it, I'll take it! :-)\r\n\r\n> I think something like gathering canned replies for github that can be modified on a case-by-case basis would be awesome, yes!\r\n\r\nI won't stop you but I'm not going to use them.  I hate text templates, they feel impersonal and lazy, and I bet I'm not the only one who feels that way.\r\n\r\nGive me a grumpy maintainer any day, at least you know they cared enough to type up a reply!"}}
{"actor":{"display_login":"bnoordhuis"}}