{"action":"created","issue":{"url":"https://api.github.com/repos/Flipboard/FLAnimatedImage/issues/128","repository_url":"https://api.github.com/repos/Flipboard/FLAnimatedImage","labels_url":"https://api.github.com/repos/Flipboard/FLAnimatedImage/issues/128/labels{/name}","comments_url":"https://api.github.com/repos/Flipboard/FLAnimatedImage/issues/128/comments","events_url":"https://api.github.com/repos/Flipboard/FLAnimatedImage/issues/128/events","html_url":"https://github.com/Flipboard/FLAnimatedImage/pull/128","id":134714866,"number":128,"title":"Fix default run loop mode crash","user":{"login":"kimar","id":126418,"avatar_url":"https://avatars.githubusercontent.com/u/126418?v=3","gravatar_id":"","url":"https://api.github.com/users/kimar","html_url":"https://github.com/kimar","followers_url":"https://api.github.com/users/kimar/followers","following_url":"https://api.github.com/users/kimar/following{/other_user}","gists_url":"https://api.github.com/users/kimar/gists{/gist_id}","starred_url":"https://api.github.com/users/kimar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kimar/subscriptions","organizations_url":"https://api.github.com/users/kimar/orgs","repos_url":"https://api.github.com/users/kimar/repos","events_url":"https://api.github.com/users/kimar/events{/privacy}","received_events_url":"https://api.github.com/users/kimar/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-02-18T22:25:42Z","updated_at":"2016-02-18T22:41:14Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Flipboard/FLAnimatedImage/pulls/128","html_url":"https://github.com/Flipboard/FLAnimatedImage/pull/128","diff_url":"https://github.com/Flipboard/FLAnimatedImage/pull/128.diff","patch_url":"https://github.com/Flipboard/FLAnimatedImage/pull/128.patch"},"body":"We're using FLAnimatedImage together with `NYTPhotoViewer` and are experiencing a crash since FLAnimatedImage v1.0.11.\r\n\r\n![screen shot 2016-02-19 at 9 17 08 am](https://cloud.githubusercontent.com/assets/126418/13160274/8494fd72-d6ea-11e5-91d1-f6a09c3f8d4e.png)\r\n\r\nThis results in breaking changes introduced in the custom runloop feature added in the most recent update. FLAnimatedImage can be successfully instantiated without having the `self.defaultRunLoopMode` being set. I've added a getter to return the `NSDefaultRunLoopMode` if this is the case.\r\n\r\nThis crash appeared just recently because NYTPhotoViewer requires `FLAnimatedImage ~> 1.0.8` so it's updated to 1.0.11 without changing its implementation of FLAnimatedImage. (Which shouldn't be necessary anyway as this FLAnimatedIMage update is just a bugfix release.)"},"comment":{"url":"https://api.github.com/repos/Flipboard/FLAnimatedImage/issues/comments/185962423","html_url":"https://github.com/Flipboard/FLAnimatedImage/pull/128#issuecomment-185962423","issue_url":"https://api.github.com/repos/Flipboard/FLAnimatedImage/issues/128","id":185962423,"user":{"login":"timonus","id":522951,"avatar_url":"https://avatars.githubusercontent.com/u/522951?v=3","gravatar_id":"","url":"https://api.github.com/users/timonus","html_url":"https://github.com/timonus","followers_url":"https://api.github.com/users/timonus/followers","following_url":"https://api.github.com/users/timonus/following{/other_user}","gists_url":"https://api.github.com/users/timonus/gists{/gist_id}","starred_url":"https://api.github.com/users/timonus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timonus/subscriptions","organizations_url":"https://api.github.com/users/timonus/orgs","repos_url":"https://api.github.com/users/timonus/repos","events_url":"https://api.github.com/users/timonus/events{/privacy}","received_events_url":"https://api.github.com/users/timonus/received_events","type":"User","site_admin":false},"created_at":"2016-02-18T22:41:14Z","updated_at":"2016-02-18T22:41:14Z","body":"@kimar I just dropped the changes that warranted https://github.com/atlassian/FLAnimatedImage/commit/40f26764b5baaabaee5105bf9aa610d7b245ecec by force pushing. I should've looked more closely at https://github.com/Flipboard/FLAnimatedImage/pull/127 before merging, thanks for pointing this out. I added an issue to resolve device builds here https://github.com/Flipboard/FLAnimatedImage/issues/129."}}