{"action":"created","issue":{"url":"https://api.github.com/repos/egulias/EmailValidator/issues/89","repository_url":"https://api.github.com/repos/egulias/EmailValidator","labels_url":"https://api.github.com/repos/egulias/EmailValidator/issues/89/labels{/name}","comments_url":"https://api.github.com/repos/egulias/EmailValidator/issues/89/comments","events_url":"https://api.github.com/repos/egulias/EmailValidator/issues/89/events","html_url":"https://github.com/egulias/EmailValidator/pull/89","id":140843192,"number":89,"title":"Adding documentation and consolidating some code for readability","user":{"login":"natechicago","id":2934380,"avatar_url":"https://avatars.githubusercontent.com/u/2934380?v=3","gravatar_id":"","url":"https://api.github.com/users/natechicago","html_url":"https://github.com/natechicago","followers_url":"https://api.github.com/users/natechicago/followers","following_url":"https://api.github.com/users/natechicago/following{/other_user}","gists_url":"https://api.github.com/users/natechicago/gists{/gist_id}","starred_url":"https://api.github.com/users/natechicago/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natechicago/subscriptions","organizations_url":"https://api.github.com/users/natechicago/orgs","repos_url":"https://api.github.com/users/natechicago/repos","events_url":"https://api.github.com/users/natechicago/events{/privacy}","received_events_url":"https://api.github.com/users/natechicago/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-03-15T01:23:41Z","updated_at":"2016-03-15T23:51:56Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/egulias/EmailValidator/pulls/89","html_url":"https://github.com/egulias/EmailValidator/pull/89","diff_url":"https://github.com/egulias/EmailValidator/pull/89.diff","patch_url":"https://github.com/egulias/EmailValidator/pull/89.patch"},"body":"I've added documentation to this class to make it easier for others to understand (at a quick glance) --\r\n - the differences between errors and warnings\r\n - the different categories of warnings\r\n - the exact RFCs that this class validates against (please confirm this list)\r\n\r\nAdditionally, some simple refactorings were applied to make a few parts of the code quicker/easier to read.  They're logically equivalent to the original code, and the tests still pass. "},"comment":{"url":"https://api.github.com/repos/egulias/EmailValidator/issues/comments/197071863","html_url":"https://github.com/egulias/EmailValidator/pull/89#issuecomment-197071863","issue_url":"https://api.github.com/repos/egulias/EmailValidator/issues/89","id":197071863,"user":{"login":"natechicago","id":2934380,"avatar_url":"https://avatars.githubusercontent.com/u/2934380?v=3","gravatar_id":"","url":"https://api.github.com/users/natechicago","html_url":"https://github.com/natechicago","followers_url":"https://api.github.com/users/natechicago/followers","following_url":"https://api.github.com/users/natechicago/following{/other_user}","gists_url":"https://api.github.com/users/natechicago/gists{/gist_id}","starred_url":"https://api.github.com/users/natechicago/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natechicago/subscriptions","organizations_url":"https://api.github.com/users/natechicago/orgs","repos_url":"https://api.github.com/users/natechicago/repos","events_url":"https://api.github.com/users/natechicago/events{/privacy}","received_events_url":"https://api.github.com/users/natechicago/received_events","type":"User","site_admin":false},"created_at":"2016-03-15T23:51:56Z","updated_at":"2016-03-15T23:51:56Z","body":"Thanks for the quick review, and for offering your feedback over in Symfony's 18156.  I'm also in favor of 'proposal 1', so I hope the other commenters will find it acceptable.  I'm going to hold off on making any changes in the corresponding PR until they have a chance to chime in."}}