{"action":"closed","number":5970,"pull_request":{"url":"https://api.github.com/repos/elastic/kibana/pulls/5970","id":56800305,"html_url":"https://github.com/elastic/kibana/pull/5970","diff_url":"https://github.com/elastic/kibana/pull/5970.diff","patch_url":"https://github.com/elastic/kibana/pull/5970.patch","issue_url":"https://api.github.com/repos/elastic/kibana/issues/5970","number":5970,"state":"closed","locked":false,"title":"Add timepicker module to autoload/modules to be included with \"all\"","user":{"login":"tsullivan","id":908371,"avatar_url":"https://avatars.githubusercontent.com/u/908371?v=3","gravatar_id":"","url":"https://api.github.com/users/tsullivan","html_url":"https://github.com/tsullivan","followers_url":"https://api.github.com/users/tsullivan/followers","following_url":"https://api.github.com/users/tsullivan/following{/other_user}","gists_url":"https://api.github.com/users/tsullivan/gists{/gist_id}","starred_url":"https://api.github.com/users/tsullivan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsullivan/subscriptions","organizations_url":"https://api.github.com/users/tsullivan/orgs","repos_url":"https://api.github.com/users/tsullivan/repos","events_url":"https://api.github.com/users/tsullivan/events{/privacy}","received_events_url":"https://api.github.com/users/tsullivan/received_events","type":"User","site_admin":false},"body":"I'm requiring \"all\" modules in my plugin, but the time picker wasn't visible, even though I have `timefilter.enabled = true`. Adding these lines to the list of \"all\" modules fixed the problem.\r\n\r\nI'm not sure why it didn't throw any kind of error before :\\ ","created_at":"2016-01-21T19:55:59Z","updated_at":"2016-01-22T14:42:41Z","closed_at":"2016-01-22T14:42:41Z","merged_at":"2016-01-22T14:42:41Z","merge_commit_sha":"f981bcbe4da545e5437e56296b956c93ceba08a6","assignee":{"login":"spalger","id":1329312,"avatar_url":"https://avatars.githubusercontent.com/u/1329312?v=3","gravatar_id":"","url":"https://api.github.com/users/spalger","html_url":"https://github.com/spalger","followers_url":"https://api.github.com/users/spalger/followers","following_url":"https://api.github.com/users/spalger/following{/other_user}","gists_url":"https://api.github.com/users/spalger/gists{/gist_id}","starred_url":"https://api.github.com/users/spalger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spalger/subscriptions","organizations_url":"https://api.github.com/users/spalger/orgs","repos_url":"https://api.github.com/users/spalger/repos","events_url":"https://api.github.com/users/spalger/events{/privacy}","received_events_url":"https://api.github.com/users/spalger/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/elastic/kibana/pulls/5970/commits","review_comments_url":"https://api.github.com/repos/elastic/kibana/pulls/5970/comments","review_comment_url":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/kibana/issues/5970/comments","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/fca34c09565ff924dbdd0356f2c279401fc5cc0e","head":{"label":"tsullivan:fix-timepicker-toggle-autoload","ref":"fix-timepicker-toggle-autoload","sha":"fca34c09565ff924dbdd0356f2c279401fc5cc0e","user":{"login":"tsullivan","id":908371,"avatar_url":"https://avatars.githubusercontent.com/u/908371?v=3","gravatar_id":"","url":"https://api.github.com/users/tsullivan","html_url":"https://github.com/tsullivan","followers_url":"https://api.github.com/users/tsullivan/followers","following_url":"https://api.github.com/users/tsullivan/following{/other_user}","gists_url":"https://api.github.com/users/tsullivan/gists{/gist_id}","starred_url":"https://api.github.com/users/tsullivan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsullivan/subscriptions","organizations_url":"https://api.github.com/users/tsullivan/orgs","repos_url":"https://api.github.com/users/tsullivan/repos","events_url":"https://api.github.com/users/tsullivan/events{/privacy}","received_events_url":"https://api.github.com/users/tsullivan/received_events","type":"User","site_admin":false},"repo":{"id":42211003,"name":"kibana","full_name":"tsullivan/kibana","owner":{"login":"tsullivan","id":908371,"avatar_url":"https://avatars.githubusercontent.com/u/908371?v=3","gravatar_id":"","url":"https://api.github.com/users/tsullivan","html_url":"https://github.com/tsullivan","followers_url":"https://api.github.com/users/tsullivan/followers","following_url":"https://api.github.com/users/tsullivan/following{/other_user}","gists_url":"https://api.github.com/users/tsullivan/gists{/gist_id}","starred_url":"https://api.github.com/users/tsullivan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsullivan/subscriptions","organizations_url":"https://api.github.com/users/tsullivan/orgs","repos_url":"https://api.github.com/users/tsullivan/repos","events_url":"https://api.github.com/users/tsullivan/events{/privacy}","received_events_url":"https://api.github.com/users/tsullivan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tsullivan/kibana","description":"Kibana","fork":true,"url":"https://api.github.com/repos/tsullivan/kibana","forks_url":"https://api.github.com/repos/tsullivan/kibana/forks","keys_url":"https://api.github.com/repos/tsullivan/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tsullivan/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tsullivan/kibana/teams","hooks_url":"https://api.github.com/repos/tsullivan/kibana/hooks","issue_events_url":"https://api.github.com/repos/tsullivan/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/tsullivan/kibana/events","assignees_url":"https://api.github.com/repos/tsullivan/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/tsullivan/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/tsullivan/kibana/tags","blobs_url":"https://api.github.com/repos/tsullivan/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tsullivan/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tsullivan/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/tsullivan/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tsullivan/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/tsullivan/kibana/languages","stargazers_url":"https://api.github.com/repos/tsullivan/kibana/stargazers","contributors_url":"https://api.github.com/repos/tsullivan/kibana/contributors","subscribers_url":"https://api.github.com/repos/tsullivan/kibana/subscribers","subscription_url":"https://api.github.com/repos/tsullivan/kibana/subscription","commits_url":"https://api.github.com/repos/tsullivan/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/tsullivan/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/tsullivan/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/tsullivan/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/tsullivan/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/tsullivan/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tsullivan/kibana/merges","archive_url":"https://api.github.com/repos/tsullivan/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tsullivan/kibana/downloads","issues_url":"https://api.github.com/repos/tsullivan/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/tsullivan/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/tsullivan/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/tsullivan/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tsullivan/kibana/labels{/name}","releases_url":"https://api.github.com/repos/tsullivan/kibana/releases{/id}","deployments_url":"https://api.github.com/repos/tsullivan/kibana/deployments","created_at":"2015-09-09T23:53:33Z","updated_at":"2016-01-19T18:18:51Z","pushed_at":"2016-01-22T05:20:34Z","git_url":"git://github.com/tsullivan/kibana.git","ssh_url":"git@github.com:tsullivan/kibana.git","clone_url":"https://github.com/tsullivan/kibana.git","svn_url":"https://github.com/tsullivan/kibana","homepage":"https://www.elastic.co/products/kibana","size":85679,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"f028601adfb47398bb1770cae2aa81fb2bddf3b3","user":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":7833168,"name":"kibana","full_name":"elastic/kibana","owner":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/kibana","description":"Kibana","fork":false,"url":"https://api.github.com/repos/elastic/kibana","forks_url":"https://api.github.com/repos/elastic/kibana/forks","keys_url":"https://api.github.com/repos/elastic/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/kibana/teams","hooks_url":"https://api.github.com/repos/elastic/kibana/hooks","issue_events_url":"https://api.github.com/repos/elastic/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/kibana/events","assignees_url":"https://api.github.com/repos/elastic/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/kibana/tags","blobs_url":"https://api.github.com/repos/elastic/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/kibana/languages","stargazers_url":"https://api.github.com/repos/elastic/kibana/stargazers","contributors_url":"https://api.github.com/repos/elastic/kibana/contributors","subscribers_url":"https://api.github.com/repos/elastic/kibana/subscribers","subscription_url":"https://api.github.com/repos/elastic/kibana/subscription","commits_url":"https://api.github.com/repos/elastic/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/kibana/merges","archive_url":"https://api.github.com/repos/elastic/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/kibana/downloads","issues_url":"https://api.github.com/repos/elastic/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/kibana/labels{/name}","releases_url":"https://api.github.com/repos/elastic/kibana/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/kibana/deployments","created_at":"2013-01-26T04:00:59Z","updated_at":"2016-01-22T14:35:52Z","pushed_at":"2016-01-22T14:42:41Z","git_url":"git://github.com/elastic/kibana.git","ssh_url":"git@github.com:elastic/kibana.git","clone_url":"https://github.com/elastic/kibana.git","svn_url":"https://github.com/elastic/kibana","homepage":"https://www.elastic.co/products/kibana","size":98600,"stargazers_count":4719,"watchers_count":4719,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1767,"mirror_url":null,"open_issues_count":791,"forks":1767,"open_issues":791,"watchers":4719,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/kibana/pulls/5970"},"html":{"href":"https://github.com/elastic/kibana/pull/5970"},"issue":{"href":"https://api.github.com/repos/elastic/kibana/issues/5970"},"comments":{"href":"https://api.github.com/repos/elastic/kibana/issues/5970/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/kibana/pulls/5970/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/kibana/pulls/5970/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/kibana/statuses/fca34c09565ff924dbdd0356f2c279401fc5cc0e"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"spalger","id":1329312,"avatar_url":"https://avatars.githubusercontent.com/u/1329312?v=3","gravatar_id":"","url":"https://api.github.com/users/spalger","html_url":"https://github.com/spalger","followers_url":"https://api.github.com/users/spalger/followers","following_url":"https://api.github.com/users/spalger/following{/other_user}","gists_url":"https://api.github.com/users/spalger/gists{/gist_id}","starred_url":"https://api.github.com/users/spalger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spalger/subscriptions","organizations_url":"https://api.github.com/users/spalger/orgs","repos_url":"https://api.github.com/users/spalger/repos","events_url":"https://api.github.com/users/spalger/events{/privacy}","received_events_url":"https://api.github.com/users/spalger/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":1,"deletions":0,"changed_files":1}}