{"action":"created","comment":{"url":"https://api.github.com/repos/liqd/adhocracy3/pulls/comments/49011294","id":49011294,"diff_hunk":"@@ -28,6 +28,14 @@ adhocracy.frontend.template_path = /static/templates\n adhocracy.frontend.rest_url = http://localhost:6541\n # backend behind varnish (default port)\n #adhocracy.frontend.rest_url = http://localhost:8088\n+# Only accept registration requests with valid captcha solutions\n+adhocracy.captcha.required = ${thentos_captcha:required}\n+# Where the frontend sends captcha traffic\n+adhocracy.captcha.backend_url = ${thentos_captcha:backend_url}\n+# Where the backend sends captcha traffic (in development mode, this\n+# is the same as captcha backend; if nginx is dispatching inbound\n+# requests, this is just the frontend url)\n+adhocracy.captcha.frontend_url = ${thentos_captcha:frontend_url}\n # The email address show to users seeking support\n adhocracy.frontend.support_email = support@unconfigured.domain\n # Default frontend locale","path":"etc/frontend_development.ini.in","position":14,"original_position":14,"commit_id":"d65c28e8d4059f9bf34637c43d5fe853ccabd3fa","original_commit_id":"d65c28e8d4059f9bf34637c43d5fe853ccabd3fa","user":{"login":"fisx","id":10210727,"avatar_url":"https://avatars.githubusercontent.com/u/10210727?v=3","gravatar_id":"","url":"https://api.github.com/users/fisx","html_url":"https://github.com/fisx","followers_url":"https://api.github.com/users/fisx/followers","following_url":"https://api.github.com/users/fisx/following{/other_user}","gists_url":"https://api.github.com/users/fisx/gists{/gist_id}","starred_url":"https://api.github.com/users/fisx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fisx/subscriptions","organizations_url":"https://api.github.com/users/fisx/orgs","repos_url":"https://api.github.com/users/fisx/repos","events_url":"https://api.github.com/users/fisx/events{/privacy}","received_events_url":"https://api.github.com/users/fisx/received_events","type":"User","site_admin":false},"body":"i think this is a misunderstanding; see one my other comments from a moment ago for an explanation.  `adhocracy.frontend_url` points to the server that delivers the a3 frontend; the above two urls are for a3 frontend and backend to contact the captcha service, respectively.\r\n\r\ni think the problem with this PR is that we don't really use the new config values anywhere.  i just thought it would be nice to have these values already present from the config when we start changing the a3 frontend / backend.","created_at":"2016-01-06T21:22:51Z","updated_at":"2016-01-06T21:22:51Z","html_url":"https://github.com/liqd/adhocracy3/pull/1950#discussion_r49011294","pull_request_url":"https://api.github.com/repos/liqd/adhocracy3/pulls/1950","_links":{"self":{"href":"https://api.github.com/repos/liqd/adhocracy3/pulls/comments/49011294"},"html":{"href":"https://github.com/liqd/adhocracy3/pull/1950#discussion_r49011294"},"pull_request":{"href":"https://api.github.com/repos/liqd/adhocracy3/pulls/1950"}}},"pull_request":{"url":"https://api.github.com/repos/liqd/adhocracy3/pulls/1950","id":55219921,"html_url":"https://github.com/liqd/adhocracy3/pull/1950","diff_url":"https://github.com/liqd/adhocracy3/pull/1950.diff","patch_url":"https://github.com/liqd/adhocracy3/pull/1950.patch","issue_url":"https://api.github.com/repos/liqd/adhocracy3/issues/1950","number":1950,"state":"open","locked":false,"title":"Configure options for thentos-captcha","user":{"login":"fisx","id":10210727,"avatar_url":"https://avatars.githubusercontent.com/u/10210727?v=3","gravatar_id":"","url":"https://api.github.com/users/fisx","html_url":"https://github.com/fisx","followers_url":"https://api.github.com/users/fisx/followers","following_url":"https://api.github.com/users/fisx/following{/other_user}","gists_url":"https://api.github.com/users/fisx/gists{/gist_id}","starred_url":"https://api.github.com/users/fisx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fisx/subscriptions","organizations_url":"https://api.github.com/users/fisx/orgs","repos_url":"https://api.github.com/users/fisx/repos","events_url":"https://api.github.com/users/fisx/events{/privacy}","received_events_url":"https://api.github.com/users/fisx/received_events","type":"User","site_admin":false},"body":"Introduces config values needed for the thentos-captcha microservice (to be delivered shortly).  The config options can be overwritten in the buildout config and are supposed to be used both by a3 backend and a3 frontend.\r\n\r\nI'm reasonably happy with this code, but I have two questions to the reviewer:\r\n\r\n1. There is a lot of redundancy for just 3 config values.  is there perhaps a way to at least avoid the duplication in development.ini and frontend_development.ini, and only have one? (I think backend and frontend are loading only their respective part.)\r\n2. The flag is a bit redundant, as we could just set the URLs to `None` to switch off captchas.  Do you have a preference there?\r\n\r\nThanks!","created_at":"2016-01-06T14:45:52Z","updated_at":"2016-01-06T21:22:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e4b5620e41793f2f031bd27d587b163bc55af160","assignee":{"login":"joka","id":353982,"avatar_url":"https://avatars.githubusercontent.com/u/353982?v=3","gravatar_id":"","url":"https://api.github.com/users/joka","html_url":"https://github.com/joka","followers_url":"https://api.github.com/users/joka/followers","following_url":"https://api.github.com/users/joka/following{/other_user}","gists_url":"https://api.github.com/users/joka/gists{/gist_id}","starred_url":"https://api.github.com/users/joka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joka/subscriptions","organizations_url":"https://api.github.com/users/joka/orgs","repos_url":"https://api.github.com/users/joka/repos","events_url":"https://api.github.com/users/joka/events{/privacy}","received_events_url":"https://api.github.com/users/joka/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/liqd/adhocracy3/pulls/1950/commits","review_comments_url":"https://api.github.com/repos/liqd/adhocracy3/pulls/1950/comments","review_comment_url":"https://api.github.com/repos/liqd/adhocracy3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/liqd/adhocracy3/issues/1950/comments","statuses_url":"https://api.github.com/repos/liqd/adhocracy3/statuses/d65c28e8d4059f9bf34637c43d5fe853ccabd3fa","head":{"label":"liqd:2016-01-06-mf-captcha-config","ref":"2016-01-06-mf-captcha-config","sha":"d65c28e8d4059f9bf34637c43d5fe853ccabd3fa","user":{"login":"liqd","id":2312088,"avatar_url":"https://avatars.githubusercontent.com/u/2312088?v=3","gravatar_id":"","url":"https://api.github.com/users/liqd","html_url":"https://github.com/liqd","followers_url":"https://api.github.com/users/liqd/followers","following_url":"https://api.github.com/users/liqd/following{/other_user}","gists_url":"https://api.github.com/users/liqd/gists{/gist_id}","starred_url":"https://api.github.com/users/liqd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liqd/subscriptions","organizations_url":"https://api.github.com/users/liqd/orgs","repos_url":"https://api.github.com/users/liqd/repos","events_url":"https://api.github.com/users/liqd/events{/privacy}","received_events_url":"https://api.github.com/users/liqd/received_events","type":"Organization","site_admin":false},"repo":{"id":22982974,"name":"adhocracy3","full_name":"liqd/adhocracy3","owner":{"login":"liqd","id":2312088,"avatar_url":"https://avatars.githubusercontent.com/u/2312088?v=3","gravatar_id":"","url":"https://api.github.com/users/liqd","html_url":"https://github.com/liqd","followers_url":"https://api.github.com/users/liqd/followers","following_url":"https://api.github.com/users/liqd/following{/other_user}","gists_url":"https://api.github.com/users/liqd/gists{/gist_id}","starred_url":"https://api.github.com/users/liqd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liqd/subscriptions","organizations_url":"https://api.github.com/users/liqd/orgs","repos_url":"https://api.github.com/users/liqd/repos","events_url":"https://api.github.com/users/liqd/events{/privacy}","received_events_url":"https://api.github.com/users/liqd/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/liqd/adhocracy3","description":"Adhocracy 3 with customizations for various projects","fork":false,"url":"https://api.github.com/repos/liqd/adhocracy3","forks_url":"https://api.github.com/repos/liqd/adhocracy3/forks","keys_url":"https://api.github.com/repos/liqd/adhocracy3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/liqd/adhocracy3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/liqd/adhocracy3/teams","hooks_url":"https://api.github.com/repos/liqd/adhocracy3/hooks","issue_events_url":"https://api.github.com/repos/liqd/adhocracy3/issues/events{/number}","events_url":"https://api.github.com/repos/liqd/adhocracy3/events","assignees_url":"https://api.github.com/repos/liqd/adhocracy3/assignees{/user}","branches_url":"https://api.github.com/repos/liqd/adhocracy3/branches{/branch}","tags_url":"https://api.github.com/repos/liqd/adhocracy3/tags","blobs_url":"https://api.github.com/repos/liqd/adhocracy3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/liqd/adhocracy3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/liqd/adhocracy3/git/refs{/sha}","trees_url":"https://api.github.com/repos/liqd/adhocracy3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/liqd/adhocracy3/statuses/{sha}","languages_url":"https://api.github.com/repos/liqd/adhocracy3/languages","stargazers_url":"https://api.github.com/repos/liqd/adhocracy3/stargazers","contributors_url":"https://api.github.com/repos/liqd/adhocracy3/contributors","subscribers_url":"https://api.github.com/repos/liqd/adhocracy3/subscribers","subscription_url":"https://api.github.com/repos/liqd/adhocracy3/subscription","commits_url":"https://api.github.com/repos/liqd/adhocracy3/commits{/sha}","git_commits_url":"https://api.github.com/repos/liqd/adhocracy3/git/commits{/sha}","comments_url":"https://api.github.com/repos/liqd/adhocracy3/comments{/number}","issue_comment_url":"https://api.github.com/repos/liqd/adhocracy3/issues/comments{/number}","contents_url":"https://api.github.com/repos/liqd/adhocracy3/contents/{+path}","compare_url":"https://api.github.com/repos/liqd/adhocracy3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/liqd/adhocracy3/merges","archive_url":"https://api.github.com/repos/liqd/adhocracy3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/liqd/adhocracy3/downloads","issues_url":"https://api.github.com/repos/liqd/adhocracy3/issues{/number}","pulls_url":"https://api.github.com/repos/liqd/adhocracy3/pulls{/number}","milestones_url":"https://api.github.com/repos/liqd/adhocracy3/milestones{/number}","notifications_url":"https://api.github.com/repos/liqd/adhocracy3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/liqd/adhocracy3/labels{/name}","releases_url":"https://api.github.com/repos/liqd/adhocracy3/releases{/id}","created_at":"2014-08-15T08:07:57Z","updated_at":"2016-01-06T02:43:49Z","pushed_at":"2016-01-06T17:14:43Z","git_url":"git://github.com/liqd/adhocracy3.git","ssh_url":"git@github.com:liqd/adhocracy3.git","clone_url":"https://github.com/liqd/adhocracy3.git","svn_url":"https://github.com/liqd/adhocracy3","homepage":"","size":20990,"stargazers_count":13,"watchers_count":13,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":88,"forks":8,"open_issues":88,"watchers":13,"default_branch":"master"}},"base":{"label":"liqd:master","ref":"master","sha":"abe01d2f7399d467c489110cf36e6597bbf79b2c","user":{"login":"liqd","id":2312088,"avatar_url":"https://avatars.githubusercontent.com/u/2312088?v=3","gravatar_id":"","url":"https://api.github.com/users/liqd","html_url":"https://github.com/liqd","followers_url":"https://api.github.com/users/liqd/followers","following_url":"https://api.github.com/users/liqd/following{/other_user}","gists_url":"https://api.github.com/users/liqd/gists{/gist_id}","starred_url":"https://api.github.com/users/liqd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liqd/subscriptions","organizations_url":"https://api.github.com/users/liqd/orgs","repos_url":"https://api.github.com/users/liqd/repos","events_url":"https://api.github.com/users/liqd/events{/privacy}","received_events_url":"https://api.github.com/users/liqd/received_events","type":"Organization","site_admin":false},"repo":{"id":22982974,"name":"adhocracy3","full_name":"liqd/adhocracy3","owner":{"login":"liqd","id":2312088,"avatar_url":"https://avatars.githubusercontent.com/u/2312088?v=3","gravatar_id":"","url":"https://api.github.com/users/liqd","html_url":"https://github.com/liqd","followers_url":"https://api.github.com/users/liqd/followers","following_url":"https://api.github.com/users/liqd/following{/other_user}","gists_url":"https://api.github.com/users/liqd/gists{/gist_id}","starred_url":"https://api.github.com/users/liqd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liqd/subscriptions","organizations_url":"https://api.github.com/users/liqd/orgs","repos_url":"https://api.github.com/users/liqd/repos","events_url":"https://api.github.com/users/liqd/events{/privacy}","received_events_url":"https://api.github.com/users/liqd/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/liqd/adhocracy3","description":"Adhocracy 3 with customizations for various projects","fork":false,"url":"https://api.github.com/repos/liqd/adhocracy3","forks_url":"https://api.github.com/repos/liqd/adhocracy3/forks","keys_url":"https://api.github.com/repos/liqd/adhocracy3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/liqd/adhocracy3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/liqd/adhocracy3/teams","hooks_url":"https://api.github.com/repos/liqd/adhocracy3/hooks","issue_events_url":"https://api.github.com/repos/liqd/adhocracy3/issues/events{/number}","events_url":"https://api.github.com/repos/liqd/adhocracy3/events","assignees_url":"https://api.github.com/repos/liqd/adhocracy3/assignees{/user}","branches_url":"https://api.github.com/repos/liqd/adhocracy3/branches{/branch}","tags_url":"https://api.github.com/repos/liqd/adhocracy3/tags","blobs_url":"https://api.github.com/repos/liqd/adhocracy3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/liqd/adhocracy3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/liqd/adhocracy3/git/refs{/sha}","trees_url":"https://api.github.com/repos/liqd/adhocracy3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/liqd/adhocracy3/statuses/{sha}","languages_url":"https://api.github.com/repos/liqd/adhocracy3/languages","stargazers_url":"https://api.github.com/repos/liqd/adhocracy3/stargazers","contributors_url":"https://api.github.com/repos/liqd/adhocracy3/contributors","subscribers_url":"https://api.github.com/repos/liqd/adhocracy3/subscribers","subscription_url":"https://api.github.com/repos/liqd/adhocracy3/subscription","commits_url":"https://api.github.com/repos/liqd/adhocracy3/commits{/sha}","git_commits_url":"https://api.github.com/repos/liqd/adhocracy3/git/commits{/sha}","comments_url":"https://api.github.com/repos/liqd/adhocracy3/comments{/number}","issue_comment_url":"https://api.github.com/repos/liqd/adhocracy3/issues/comments{/number}","contents_url":"https://api.github.com/repos/liqd/adhocracy3/contents/{+path}","compare_url":"https://api.github.com/repos/liqd/adhocracy3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/liqd/adhocracy3/merges","archive_url":"https://api.github.com/repos/liqd/adhocracy3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/liqd/adhocracy3/downloads","issues_url":"https://api.github.com/repos/liqd/adhocracy3/issues{/number}","pulls_url":"https://api.github.com/repos/liqd/adhocracy3/pulls{/number}","milestones_url":"https://api.github.com/repos/liqd/adhocracy3/milestones{/number}","notifications_url":"https://api.github.com/repos/liqd/adhocracy3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/liqd/adhocracy3/labels{/name}","releases_url":"https://api.github.com/repos/liqd/adhocracy3/releases{/id}","created_at":"2014-08-15T08:07:57Z","updated_at":"2016-01-06T02:43:49Z","pushed_at":"2016-01-06T17:14:43Z","git_url":"git://github.com/liqd/adhocracy3.git","ssh_url":"git@github.com:liqd/adhocracy3.git","clone_url":"https://github.com/liqd/adhocracy3.git","svn_url":"https://github.com/liqd/adhocracy3","homepage":"","size":20990,"stargazers_count":13,"watchers_count":13,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":88,"forks":8,"open_issues":88,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/liqd/adhocracy3/pulls/1950"},"html":{"href":"https://github.com/liqd/adhocracy3/pull/1950"},"issue":{"href":"https://api.github.com/repos/liqd/adhocracy3/issues/1950"},"comments":{"href":"https://api.github.com/repos/liqd/adhocracy3/issues/1950/comments"},"review_comments":{"href":"https://api.github.com/repos/liqd/adhocracy3/pulls/1950/comments"},"review_comment":{"href":"https://api.github.com/repos/liqd/adhocracy3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/liqd/adhocracy3/pulls/1950/commits"},"statuses":{"href":"https://api.github.com/repos/liqd/adhocracy3/statuses/d65c28e8d4059f9bf34637c43d5fe853ccabd3fa"}}}}