{"action":"created","issue":{"url":"https://api.github.com/repos/aspnet-contrib/AspNet.Security.OpenIdConnect.Samples/issues/8","labels_url":"https://api.github.com/repos/aspnet-contrib/AspNet.Security.OpenIdConnect.Samples/issues/8/labels{/name}","comments_url":"https://api.github.com/repos/aspnet-contrib/AspNet.Security.OpenIdConnect.Samples/issues/8/comments","events_url":"https://api.github.com/repos/aspnet-contrib/AspNet.Security.OpenIdConnect.Samples/issues/8/events","html_url":"https://github.com/aspnet-contrib/AspNet.Security.OpenIdConnect.Samples/pull/8","id":126658268,"number":8,"title":"Added Cordova sample :","user":{"login":"pierre-weceipt","id":6052793,"avatar_url":"https://avatars.githubusercontent.com/u/6052793?v=3","gravatar_id":"","url":"https://api.github.com/users/pierre-weceipt","html_url":"https://github.com/pierre-weceipt","followers_url":"https://api.github.com/users/pierre-weceipt/followers","following_url":"https://api.github.com/users/pierre-weceipt/following{/other_user}","gists_url":"https://api.github.com/users/pierre-weceipt/gists{/gist_id}","starred_url":"https://api.github.com/users/pierre-weceipt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pierre-weceipt/subscriptions","organizations_url":"https://api.github.com/users/pierre-weceipt/orgs","repos_url":"https://api.github.com/users/pierre-weceipt/repos","events_url":"https://api.github.com/users/pierre-weceipt/events{/privacy}","received_events_url":"https://api.github.com/users/pierre-weceipt/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/aspnet-contrib/AspNet.Security.OpenIdConnect.Samples/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-01-14T13:50:58Z","updated_at":"2016-01-17T21:33:21Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/aspnet-contrib/AspNet.Security.OpenIdConnect.Samples/pulls/8","html_url":"https://github.com/aspnet-contrib/AspNet.Security.OpenIdConnect.Samples/pull/8","diff_url":"https://github.com/aspnet-contrib/AspNet.Security.OpenIdConnect.Samples/pull/8.diff","patch_url":"https://github.com/aspnet-contrib/AspNet.Security.OpenIdConnect.Samples/pull/8.patch"},"body":"The Backend part is the same as MVC.Server, just changed the uri_redirect in startup.cs to target the app.\r\nThe MobileApp is built with Cordova and Ionic."},"comment":{"url":"https://api.github.com/repos/aspnet-contrib/AspNet.Security.OpenIdConnect.Samples/issues/comments/172385464","html_url":"https://github.com/aspnet-contrib/AspNet.Security.OpenIdConnect.Samples/pull/8#issuecomment-172385464","issue_url":"https://api.github.com/repos/aspnet-contrib/AspNet.Security.OpenIdConnect.Samples/issues/8","id":172385464,"user":{"login":"DovydasNavickas","id":7989797,"avatar_url":"https://avatars.githubusercontent.com/u/7989797?v=3","gravatar_id":"","url":"https://api.github.com/users/DovydasNavickas","html_url":"https://github.com/DovydasNavickas","followers_url":"https://api.github.com/users/DovydasNavickas/followers","following_url":"https://api.github.com/users/DovydasNavickas/following{/other_user}","gists_url":"https://api.github.com/users/DovydasNavickas/gists{/gist_id}","starred_url":"https://api.github.com/users/DovydasNavickas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DovydasNavickas/subscriptions","organizations_url":"https://api.github.com/users/DovydasNavickas/orgs","repos_url":"https://api.github.com/users/DovydasNavickas/repos","events_url":"https://api.github.com/users/DovydasNavickas/events{/privacy}","received_events_url":"https://api.github.com/users/DovydasNavickas/received_events","type":"User","site_admin":false},"created_at":"2016-01-17T21:33:21Z","updated_at":"2016-01-17T21:33:21Z","body":"Ooook. I'm not Cordova specialist (i.e. never compiled an app with it), but...\r\nWhat is [this](https://github.com/pierre-weceipt/AspNet.Security.OpenIdConnect.Samples/blob/13965f41bf89f50ef75039b86d30ca432a623a27/samples/Cordova/MobileApp/www/scripts/controllers/authController.js#L7) and [this](https://github.com/pierre-weceipt/AspNet.Security.OpenIdConnect.Samples/blob/13965f41bf89f50ef75039b86d30ca432a623a27/samples/Cordova/MobileApp/www/scripts/controllers/authController.js#L18)?\r\n\r\nAlso, I would move configuration (such as [this](https://github.com/pierre-weceipt/AspNet.Security.OpenIdConnect.Samples/blob/13965f41bf89f50ef75039b86d30ca432a623a27/samples/Cordova/MobileApp/www/scripts/services/authService.js#L4) and [URL from this](https://github.com/pierre-weceipt/AspNet.Security.OpenIdConnect.Samples/blob/13965f41bf89f50ef75039b86d30ca432a623a27/samples/Cordova/MobileApp/www/scripts/services/authService.js#L36)) out into a single file, e.g. `config.js` or sth, because having to change everything throughout the solution is not really helping with clarity.\r\n\r\nA minor thing about different naming case [here](https://github.com/pierre-weceipt/AspNet.Security.OpenIdConnect.Samples/blob/13965f41bf89f50ef75039b86d30ca432a623a27/samples/Cordova/MobileApp/www/scripts/services/authService.js#L34) and [here](https://github.com/pierre-weceipt/AspNet.Security.OpenIdConnect.Samples/blob/13965f41bf89f50ef75039b86d30ca432a623a27/samples/Cordova/MobileApp/www/scripts/services/authService.js#L13)\r\n\r\nAlso [this](https://github.com/pierre-weceipt/AspNet.Security.OpenIdConnect.Samples/blob/13965f41bf89f50ef75039b86d30ca432a623a27/samples/Cordova/MobileApp/www/scripts/services/authService.js#L28-L32) and [this](https://github.com/pierre-weceipt/AspNet.Security.OpenIdConnect.Samples/blob/13965f41bf89f50ef75039b86d30ca432a623a27/samples/Cordova/MobileApp/www/scripts/services/authService.js#L62-L64) should not be in the middle of `authService.js` :smile: \r\n\r\nAnd a mistype in a `libraries` folder name [here](https://github.com/pierre-weceipt/AspNet.Security.OpenIdConnect.Samples/tree/13965f41bf89f50ef75039b86d30ca432a623a27/samples/Cordova/MobileApp/www/scripts) (or is it in French?).\r\n\r\nThen there's a question whether to keep the dummy methods [here](https://github.com/pierre-weceipt/AspNet.Security.OpenIdConnect.Samples/blob/13965f41bf89f50ef75039b86d30ca432a623a27/samples/Cordova/MobileApp/www/scripts/index.js) and a dummy files [here](https://github.com/pierre-weceipt/AspNet.Security.OpenIdConnect.Samples/blob/13965f41bf89f50ef75039b86d30ca432a623a27/samples/Cordova/MobileApp/www/scripts/platformOverrides.js) and [here](https://github.com/pierre-weceipt/AspNet.Security.OpenIdConnect.Samples/tree/13965f41bf89f50ef75039b86d30ca432a623a27/samples/Cordova/MobileApp/www/css). These files with non-English comments do no good for the sample  :)\r\n\r\nAll in all, the sample looks OK and if it works, then there are only these minor things to fix. Apart from that, I'd say having everything written in English (including comments) is the most beneficial if you want to reach most people.\r\n\r\nThank you for the PR! :clap: :smile:"}}