{"action":"created","comment":{"url":"https://api.github.com/repos/openSUSE/libstorage/pulls/comments/74755107","id":74755107,"diff_hunk":"@@ -88,14 +88,23 @@ namespace storage\n     void\n     SystemCmd::init()\n     {\n+        _childStdin = NULL;\n \t_files[0] = _files[1] = NULL;\n-\t_pfds[0].events = _pfds[1].events = POLLIN;\n+\t_pfds[0].events = POLLOUT; // stdin\n+\t_pfds[1].events = POLLIN;  // stdout\n+\t_pfds[2].events = POLLIN;  // stderr","path":"storage/Utils/SystemCmd.cc","position":9,"original_position":9,"commit_id":"d901b4908c9a5a154f81c46cd48d469b7c89544b","original_commit_id":"d901b4908c9a5a154f81c46cd48d469b7c89544b","user":{"login":"shundhammer","id":11538225,"avatar_url":"https://avatars.githubusercontent.com/u/11538225?v=3","gravatar_id":"","url":"https://api.github.com/users/shundhammer","html_url":"https://github.com/shundhammer","followers_url":"https://api.github.com/users/shundhammer/followers","following_url":"https://api.github.com/users/shundhammer/following{/other_user}","gists_url":"https://api.github.com/users/shundhammer/gists{/gist_id}","starred_url":"https://api.github.com/users/shundhammer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shundhammer/subscriptions","organizations_url":"https://api.github.com/users/shundhammer/orgs","repos_url":"https://api.github.com/users/shundhammer/repos","events_url":"https://api.github.com/users/shundhammer/events{/privacy}","received_events_url":"https://api.github.com/users/shundhammer/received_events","type":"User","site_admin":false},"body":"No, that just enables getting notifications when data is available for any of them. The file descriptors still remain separate.","created_at":"2016-08-15T12:37:15Z","updated_at":"2016-08-15T12:37:15Z","html_url":"https://github.com/openSUSE/libstorage/pull/162#discussion_r74755107","pull_request_url":"https://api.github.com/repos/openSUSE/libstorage/pulls/162","_links":{"self":{"href":"https://api.github.com/repos/openSUSE/libstorage/pulls/comments/74755107"},"html":{"href":"https://github.com/openSUSE/libstorage/pull/162#discussion_r74755107"},"pull_request":{"href":"https://api.github.com/repos/openSUSE/libstorage/pulls/162"}}},"pull_request":{"url":"https://api.github.com/repos/openSUSE/libstorage/pulls/162","id":77448905,"html_url":"https://github.com/openSUSE/libstorage/pull/162","diff_url":"https://github.com/openSUSE/libstorage/pull/162.diff","patch_url":"https://github.com/openSUSE/libstorage/pull/162.patch","issue_url":"https://api.github.com/repos/openSUSE/libstorage/issues/162","number":162,"state":"open","locked":false,"title":"SLE-12 SP1: Use stdin, not tmp files for passwords (bsc#986971)","user":{"login":"shundhammer","id":11538225,"avatar_url":"https://avatars.githubusercontent.com/u/11538225?v=3","gravatar_id":"","url":"https://api.github.com/users/shundhammer","html_url":"https://github.com/shundhammer","followers_url":"https://api.github.com/users/shundhammer/followers","following_url":"https://api.github.com/users/shundhammer/following{/other_user}","gists_url":"https://api.github.com/users/shundhammer/gists{/gist_id}","starred_url":"https://api.github.com/users/shundhammer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shundhammer/subscriptions","organizations_url":"https://api.github.com/users/shundhammer/orgs","repos_url":"https://api.github.com/users/shundhammer/repos","events_url":"https://api.github.com/users/shundhammer/events{/privacy}","received_events_url":"https://api.github.com/users/shundhammer/received_events","type":"User","site_admin":false},"body":"Backport to SLE-12 SP1\r\n\r\nThis backport is easy because both affected classes (SystemCmd and Volume) were unchanged between SP1 and SP2, so the diffs for this fix are identical.","created_at":"2016-07-14T12:37:48Z","updated_at":"2016-08-15T12:37:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"71332cc184ad46b8f929e12a96c5a8ed7504271c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/openSUSE/libstorage/pulls/162/commits","review_comments_url":"https://api.github.com/repos/openSUSE/libstorage/pulls/162/comments","review_comment_url":"https://api.github.com/repos/openSUSE/libstorage/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openSUSE/libstorage/issues/162/comments","statuses_url":"https://api.github.com/repos/openSUSE/libstorage/statuses/d901b4908c9a5a154f81c46cd48d469b7c89544b","head":{"label":"shundhammer:huha-pipe-systemcmd-12-SP1","ref":"huha-pipe-systemcmd-12-SP1","sha":"d901b4908c9a5a154f81c46cd48d469b7c89544b","user":{"login":"shundhammer","id":11538225,"avatar_url":"https://avatars.githubusercontent.com/u/11538225?v=3","gravatar_id":"","url":"https://api.github.com/users/shundhammer","html_url":"https://github.com/shundhammer","followers_url":"https://api.github.com/users/shundhammer/followers","following_url":"https://api.github.com/users/shundhammer/following{/other_user}","gists_url":"https://api.github.com/users/shundhammer/gists{/gist_id}","starred_url":"https://api.github.com/users/shundhammer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shundhammer/subscriptions","organizations_url":"https://api.github.com/users/shundhammer/orgs","repos_url":"https://api.github.com/users/shundhammer/repos","events_url":"https://api.github.com/users/shundhammer/events{/privacy}","received_events_url":"https://api.github.com/users/shundhammer/received_events","type":"User","site_admin":false},"repo":{"id":34254722,"name":"libstorage","full_name":"shundhammer/libstorage","owner":{"login":"shundhammer","id":11538225,"avatar_url":"https://avatars.githubusercontent.com/u/11538225?v=3","gravatar_id":"","url":"https://api.github.com/users/shundhammer","html_url":"https://github.com/shundhammer","followers_url":"https://api.github.com/users/shundhammer/followers","following_url":"https://api.github.com/users/shundhammer/following{/other_user}","gists_url":"https://api.github.com/users/shundhammer/gists{/gist_id}","starred_url":"https://api.github.com/users/shundhammer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shundhammer/subscriptions","organizations_url":"https://api.github.com/users/shundhammer/orgs","repos_url":"https://api.github.com/users/shundhammer/repos","events_url":"https://api.github.com/users/shundhammer/events{/privacy}","received_events_url":"https://api.github.com/users/shundhammer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shundhammer/libstorage","description":"Linux storage management library","fork":true,"url":"https://api.github.com/repos/shundhammer/libstorage","forks_url":"https://api.github.com/repos/shundhammer/libstorage/forks","keys_url":"https://api.github.com/repos/shundhammer/libstorage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shundhammer/libstorage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shundhammer/libstorage/teams","hooks_url":"https://api.github.com/repos/shundhammer/libstorage/hooks","issue_events_url":"https://api.github.com/repos/shundhammer/libstorage/issues/events{/number}","events_url":"https://api.github.com/repos/shundhammer/libstorage/events","assignees_url":"https://api.github.com/repos/shundhammer/libstorage/assignees{/user}","branches_url":"https://api.github.com/repos/shundhammer/libstorage/branches{/branch}","tags_url":"https://api.github.com/repos/shundhammer/libstorage/tags","blobs_url":"https://api.github.com/repos/shundhammer/libstorage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shundhammer/libstorage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shundhammer/libstorage/git/refs{/sha}","trees_url":"https://api.github.com/repos/shundhammer/libstorage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shundhammer/libstorage/statuses/{sha}","languages_url":"https://api.github.com/repos/shundhammer/libstorage/languages","stargazers_url":"https://api.github.com/repos/shundhammer/libstorage/stargazers","contributors_url":"https://api.github.com/repos/shundhammer/libstorage/contributors","subscribers_url":"https://api.github.com/repos/shundhammer/libstorage/subscribers","subscription_url":"https://api.github.com/repos/shundhammer/libstorage/subscription","commits_url":"https://api.github.com/repos/shundhammer/libstorage/commits{/sha}","git_commits_url":"https://api.github.com/repos/shundhammer/libstorage/git/commits{/sha}","comments_url":"https://api.github.com/repos/shundhammer/libstorage/comments{/number}","issue_comment_url":"https://api.github.com/repos/shundhammer/libstorage/issues/comments{/number}","contents_url":"https://api.github.com/repos/shundhammer/libstorage/contents/{+path}","compare_url":"https://api.github.com/repos/shundhammer/libstorage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shundhammer/libstorage/merges","archive_url":"https://api.github.com/repos/shundhammer/libstorage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shundhammer/libstorage/downloads","issues_url":"https://api.github.com/repos/shundhammer/libstorage/issues{/number}","pulls_url":"https://api.github.com/repos/shundhammer/libstorage/pulls{/number}","milestones_url":"https://api.github.com/repos/shundhammer/libstorage/milestones{/number}","notifications_url":"https://api.github.com/repos/shundhammer/libstorage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shundhammer/libstorage/labels{/name}","releases_url":"https://api.github.com/repos/shundhammer/libstorage/releases{/id}","deployments_url":"https://api.github.com/repos/shundhammer/libstorage/deployments","created_at":"2015-04-20T10:44:24Z","updated_at":"2016-07-11T12:51:17Z","pushed_at":"2016-07-14T15:54:08Z","git_url":"git://github.com/shundhammer/libstorage.git","ssh_url":"git@github.com:shundhammer/libstorage.git","clone_url":"https://github.com/shundhammer/libstorage.git","svn_url":"https://github.com/shundhammer/libstorage","homepage":null,"size":11863,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openSUSE:SLE-12-SP1-GA","ref":"SLE-12-SP1-GA","sha":"0babb524537109092e9103a0223ebcb83e19fc7f","user":{"login":"openSUSE","id":623819,"avatar_url":"https://avatars.githubusercontent.com/u/623819?v=3","gravatar_id":"","url":"https://api.github.com/users/openSUSE","html_url":"https://github.com/openSUSE","followers_url":"https://api.github.com/users/openSUSE/followers","following_url":"https://api.github.com/users/openSUSE/following{/other_user}","gists_url":"https://api.github.com/users/openSUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/openSUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openSUSE/subscriptions","organizations_url":"https://api.github.com/users/openSUSE/orgs","repos_url":"https://api.github.com/users/openSUSE/repos","events_url":"https://api.github.com/users/openSUSE/events{/privacy}","received_events_url":"https://api.github.com/users/openSUSE/received_events","type":"Organization","site_admin":false},"repo":{"id":4134851,"name":"libstorage","full_name":"openSUSE/libstorage","owner":{"login":"openSUSE","id":623819,"avatar_url":"https://avatars.githubusercontent.com/u/623819?v=3","gravatar_id":"","url":"https://api.github.com/users/openSUSE","html_url":"https://github.com/openSUSE","followers_url":"https://api.github.com/users/openSUSE/followers","following_url":"https://api.github.com/users/openSUSE/following{/other_user}","gists_url":"https://api.github.com/users/openSUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/openSUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openSUSE/subscriptions","organizations_url":"https://api.github.com/users/openSUSE/orgs","repos_url":"https://api.github.com/users/openSUSE/repos","events_url":"https://api.github.com/users/openSUSE/events{/privacy}","received_events_url":"https://api.github.com/users/openSUSE/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openSUSE/libstorage","description":"Linux storage management library","fork":false,"url":"https://api.github.com/repos/openSUSE/libstorage","forks_url":"https://api.github.com/repos/openSUSE/libstorage/forks","keys_url":"https://api.github.com/repos/openSUSE/libstorage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openSUSE/libstorage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openSUSE/libstorage/teams","hooks_url":"https://api.github.com/repos/openSUSE/libstorage/hooks","issue_events_url":"https://api.github.com/repos/openSUSE/libstorage/issues/events{/number}","events_url":"https://api.github.com/repos/openSUSE/libstorage/events","assignees_url":"https://api.github.com/repos/openSUSE/libstorage/assignees{/user}","branches_url":"https://api.github.com/repos/openSUSE/libstorage/branches{/branch}","tags_url":"https://api.github.com/repos/openSUSE/libstorage/tags","blobs_url":"https://api.github.com/repos/openSUSE/libstorage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openSUSE/libstorage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openSUSE/libstorage/git/refs{/sha}","trees_url":"https://api.github.com/repos/openSUSE/libstorage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openSUSE/libstorage/statuses/{sha}","languages_url":"https://api.github.com/repos/openSUSE/libstorage/languages","stargazers_url":"https://api.github.com/repos/openSUSE/libstorage/stargazers","contributors_url":"https://api.github.com/repos/openSUSE/libstorage/contributors","subscribers_url":"https://api.github.com/repos/openSUSE/libstorage/subscribers","subscription_url":"https://api.github.com/repos/openSUSE/libstorage/subscription","commits_url":"https://api.github.com/repos/openSUSE/libstorage/commits{/sha}","git_commits_url":"https://api.github.com/repos/openSUSE/libstorage/git/commits{/sha}","comments_url":"https://api.github.com/repos/openSUSE/libstorage/comments{/number}","issue_comment_url":"https://api.github.com/repos/openSUSE/libstorage/issues/comments{/number}","contents_url":"https://api.github.com/repos/openSUSE/libstorage/contents/{+path}","compare_url":"https://api.github.com/repos/openSUSE/libstorage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openSUSE/libstorage/merges","archive_url":"https://api.github.com/repos/openSUSE/libstorage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openSUSE/libstorage/downloads","issues_url":"https://api.github.com/repos/openSUSE/libstorage/issues{/number}","pulls_url":"https://api.github.com/repos/openSUSE/libstorage/pulls{/number}","milestones_url":"https://api.github.com/repos/openSUSE/libstorage/milestones{/number}","notifications_url":"https://api.github.com/repos/openSUSE/libstorage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openSUSE/libstorage/labels{/name}","releases_url":"https://api.github.com/repos/openSUSE/libstorage/releases{/id}","deployments_url":"https://api.github.com/repos/openSUSE/libstorage/deployments","created_at":"2012-04-25T09:22:59Z","updated_at":"2016-01-19T08:41:51Z","pushed_at":"2016-08-10T09:53:45Z","git_url":"git://github.com/openSUSE/libstorage.git","ssh_url":"git@github.com:openSUSE/libstorage.git","clone_url":"https://github.com/openSUSE/libstorage.git","svn_url":"https://github.com/openSUSE/libstorage","homepage":null,"size":12010,"stargazers_count":5,"watchers_count":5,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":7,"forks":14,"open_issues":7,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openSUSE/libstorage/pulls/162"},"html":{"href":"https://github.com/openSUSE/libstorage/pull/162"},"issue":{"href":"https://api.github.com/repos/openSUSE/libstorage/issues/162"},"comments":{"href":"https://api.github.com/repos/openSUSE/libstorage/issues/162/comments"},"review_comments":{"href":"https://api.github.com/repos/openSUSE/libstorage/pulls/162/comments"},"review_comment":{"href":"https://api.github.com/repos/openSUSE/libstorage/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openSUSE/libstorage/pulls/162/commits"},"statuses":{"href":"https://api.github.com/repos/openSUSE/libstorage/statuses/d901b4908c9a5a154f81c46cd48d469b7c89544b"}}}}
{"actor":{"display_login":"shundhammer"}}