{"action":"created","comment":{"url":"https://api.github.com/repos/gccxml/pygccxml/pulls/comments/55129022","id":55129022,"diff_hunk":"@@ -55,6 +55,65 @@ def test4(self):\n             '::xyz[2][3]' == aaaa_type.decl_string,\n             aaaa_type.decl_string)\n \n+    def test5(self):\n+        code = 'char const arr[4] = {};'\n+        src_reader = parser.source_reader_t(self.config)\n+        global_ns = declarations.get_global_namespace(\n+            src_reader.read_string(code))\n+        arr_type = global_ns.variable('arr').type\n+        if self.config.xml_generator == \"gccxml\":\n+            self.assertTrue(\n+                'char[4] const' == arr_type.decl_string,","path":"unittests/array_bug_tester.py","position":12,"original_position":12,"commit_id":"c1b59010f8d46727eca2825c2eec58ab246fd28d","original_commit_id":"c1b59010f8d46727eca2825c2eec58ab246fd28d","user":{"login":"praetorian20","id":10395685,"avatar_url":"https://avatars.githubusercontent.com/u/10395685?v=3","gravatar_id":"","url":"https://api.github.com/users/praetorian20","html_url":"https://github.com/praetorian20","followers_url":"https://api.github.com/users/praetorian20/followers","following_url":"https://api.github.com/users/praetorian20/following{/other_user}","gists_url":"https://api.github.com/users/praetorian20/gists{/gist_id}","starred_url":"https://api.github.com/users/praetorian20/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/praetorian20/subscriptions","organizations_url":"https://api.github.com/users/praetorian20/orgs","repos_url":"https://api.github.com/users/praetorian20/repos","events_url":"https://api.github.com/users/praetorian20/events{/privacy}","received_events_url":"https://api.github.com/users/praetorian20/received_events","type":"User","site_admin":false},"body":"Does it make sense to you that gccxml is putting the cv-qualifiers on the right of the array declarator in `decl_string`?","created_at":"2016-03-05T22:23:27Z","updated_at":"2016-03-05T22:23:27Z","html_url":"https://github.com/gccxml/pygccxml/pull/35#discussion_r55129022","pull_request_url":"https://api.github.com/repos/gccxml/pygccxml/pulls/35","_links":{"self":{"href":"https://api.github.com/repos/gccxml/pygccxml/pulls/comments/55129022"},"html":{"href":"https://github.com/gccxml/pygccxml/pull/35#discussion_r55129022"},"pull_request":{"href":"https://api.github.com/repos/gccxml/pygccxml/pulls/35"}}},"pull_request":{"url":"https://api.github.com/repos/gccxml/pygccxml/pulls/35","id":61819360,"html_url":"https://github.com/gccxml/pygccxml/pull/35","diff_url":"https://github.com/gccxml/pygccxml/pull/35.diff","patch_url":"https://github.com/gccxml/pygccxml/pull/35.patch","issue_url":"https://api.github.com/repos/gccxml/pygccxml/issues/35","number":35,"state":"open","locked":false,"title":"Fixes for cv-qualified arrays","user":{"login":"praetorian20","id":10395685,"avatar_url":"https://avatars.githubusercontent.com/u/10395685?v=3","gravatar_id":"","url":"https://api.github.com/users/praetorian20","html_url":"https://github.com/praetorian20","followers_url":"https://api.github.com/users/praetorian20/followers","following_url":"https://api.github.com/users/praetorian20/following{/other_user}","gists_url":"https://api.github.com/users/praetorian20/gists{/gist_id}","starred_url":"https://api.github.com/users/praetorian20/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/praetorian20/subscriptions","organizations_url":"https://api.github.com/users/praetorian20/orgs","repos_url":"https://api.github.com/users/praetorian20/repos","events_url":"https://api.github.com/users/praetorian20/events{/privacy}","received_events_url":"https://api.github.com/users/praetorian20/received_events","type":"User","site_admin":false},"body":"I've made changes to some type traits functions to fix detection of cv-qualified arrays. Before these fixes, `is_const` would return `False` for `T const[N]`. The same problem existed for `volatile` too. This bug is causing a pyplusplus unit test to fail.\r\n\r\nTo see how such arrays were not being handled correctly, take only the changes to `unittests/array_bug_tester.py` and `unittests/data/type_traits_castxml.hpp` and run unit tests.\r\n\r\nThe PR is not quite ready for merging yet, there are a couple of things I'd like to clarify. I'll comment on those inline.","created_at":"2016-03-05T18:13:00Z","updated_at":"2016-03-05T22:23:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c792fdc4f2e00055efd7db88751a85f8bf5df51f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/gccxml/pygccxml/pulls/35/commits","review_comments_url":"https://api.github.com/repos/gccxml/pygccxml/pulls/35/comments","review_comment_url":"https://api.github.com/repos/gccxml/pygccxml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gccxml/pygccxml/issues/35/comments","statuses_url":"https://api.github.com/repos/gccxml/pygccxml/statuses/c1b59010f8d46727eca2825c2eec58ab246fd28d","head":{"label":"praetorian20:cv_qual_arrays","ref":"cv_qual_arrays","sha":"c1b59010f8d46727eca2825c2eec58ab246fd28d","user":{"login":"praetorian20","id":10395685,"avatar_url":"https://avatars.githubusercontent.com/u/10395685?v=3","gravatar_id":"","url":"https://api.github.com/users/praetorian20","html_url":"https://github.com/praetorian20","followers_url":"https://api.github.com/users/praetorian20/followers","following_url":"https://api.github.com/users/praetorian20/following{/other_user}","gists_url":"https://api.github.com/users/praetorian20/gists{/gist_id}","starred_url":"https://api.github.com/users/praetorian20/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/praetorian20/subscriptions","organizations_url":"https://api.github.com/users/praetorian20/orgs","repos_url":"https://api.github.com/users/praetorian20/repos","events_url":"https://api.github.com/users/praetorian20/events{/privacy}","received_events_url":"https://api.github.com/users/praetorian20/received_events","type":"User","site_admin":false},"repo":{"id":52937938,"name":"pygccxml","full_name":"praetorian20/pygccxml","owner":{"login":"praetorian20","id":10395685,"avatar_url":"https://avatars.githubusercontent.com/u/10395685?v=3","gravatar_id":"","url":"https://api.github.com/users/praetorian20","html_url":"https://github.com/praetorian20","followers_url":"https://api.github.com/users/praetorian20/followers","following_url":"https://api.github.com/users/praetorian20/following{/other_user}","gists_url":"https://api.github.com/users/praetorian20/gists{/gist_id}","starred_url":"https://api.github.com/users/praetorian20/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/praetorian20/subscriptions","organizations_url":"https://api.github.com/users/praetorian20/orgs","repos_url":"https://api.github.com/users/praetorian20/repos","events_url":"https://api.github.com/users/praetorian20/events{/privacy}","received_events_url":"https://api.github.com/users/praetorian20/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/praetorian20/pygccxml","description":"pygccxml is a specialized XML reader that reads the output from CastXML or GCCXML. It provides a simple framework to navigate C++ declarations, using Python classes.","fork":true,"url":"https://api.github.com/repos/praetorian20/pygccxml","forks_url":"https://api.github.com/repos/praetorian20/pygccxml/forks","keys_url":"https://api.github.com/repos/praetorian20/pygccxml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/praetorian20/pygccxml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/praetorian20/pygccxml/teams","hooks_url":"https://api.github.com/repos/praetorian20/pygccxml/hooks","issue_events_url":"https://api.github.com/repos/praetorian20/pygccxml/issues/events{/number}","events_url":"https://api.github.com/repos/praetorian20/pygccxml/events","assignees_url":"https://api.github.com/repos/praetorian20/pygccxml/assignees{/user}","branches_url":"https://api.github.com/repos/praetorian20/pygccxml/branches{/branch}","tags_url":"https://api.github.com/repos/praetorian20/pygccxml/tags","blobs_url":"https://api.github.com/repos/praetorian20/pygccxml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/praetorian20/pygccxml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/praetorian20/pygccxml/git/refs{/sha}","trees_url":"https://api.github.com/repos/praetorian20/pygccxml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/praetorian20/pygccxml/statuses/{sha}","languages_url":"https://api.github.com/repos/praetorian20/pygccxml/languages","stargazers_url":"https://api.github.com/repos/praetorian20/pygccxml/stargazers","contributors_url":"https://api.github.com/repos/praetorian20/pygccxml/contributors","subscribers_url":"https://api.github.com/repos/praetorian20/pygccxml/subscribers","subscription_url":"https://api.github.com/repos/praetorian20/pygccxml/subscription","commits_url":"https://api.github.com/repos/praetorian20/pygccxml/commits{/sha}","git_commits_url":"https://api.github.com/repos/praetorian20/pygccxml/git/commits{/sha}","comments_url":"https://api.github.com/repos/praetorian20/pygccxml/comments{/number}","issue_comment_url":"https://api.github.com/repos/praetorian20/pygccxml/issues/comments{/number}","contents_url":"https://api.github.com/repos/praetorian20/pygccxml/contents/{+path}","compare_url":"https://api.github.com/repos/praetorian20/pygccxml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/praetorian20/pygccxml/merges","archive_url":"https://api.github.com/repos/praetorian20/pygccxml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/praetorian20/pygccxml/downloads","issues_url":"https://api.github.com/repos/praetorian20/pygccxml/issues{/number}","pulls_url":"https://api.github.com/repos/praetorian20/pygccxml/pulls{/number}","milestones_url":"https://api.github.com/repos/praetorian20/pygccxml/milestones{/number}","notifications_url":"https://api.github.com/repos/praetorian20/pygccxml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/praetorian20/pygccxml/labels{/name}","releases_url":"https://api.github.com/repos/praetorian20/pygccxml/releases{/id}","deployments_url":"https://api.github.com/repos/praetorian20/pygccxml/deployments","created_at":"2016-03-02T05:59:09Z","updated_at":"2016-03-02T05:59:10Z","pushed_at":"2016-03-05T18:09:33Z","git_url":"git://github.com/praetorian20/pygccxml.git","ssh_url":"git@github.com:praetorian20/pygccxml.git","clone_url":"https://github.com/praetorian20/pygccxml.git","svn_url":"https://github.com/praetorian20/pygccxml","homepage":"http://pygccxml.readthedocs.org/en/develop/","size":15427,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"gccxml:develop","ref":"develop","sha":"3b1c87c505fb9f5ad2cd1e63ace1c8cb57777636","user":{"login":"gccxml","id":2700451,"avatar_url":"https://avatars.githubusercontent.com/u/2700451?v=3","gravatar_id":"","url":"https://api.github.com/users/gccxml","html_url":"https://github.com/gccxml","followers_url":"https://api.github.com/users/gccxml/followers","following_url":"https://api.github.com/users/gccxml/following{/other_user}","gists_url":"https://api.github.com/users/gccxml/gists{/gist_id}","starred_url":"https://api.github.com/users/gccxml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gccxml/subscriptions","organizations_url":"https://api.github.com/users/gccxml/orgs","repos_url":"https://api.github.com/users/gccxml/repos","events_url":"https://api.github.com/users/gccxml/events{/privacy}","received_events_url":"https://api.github.com/users/gccxml/received_events","type":"Organization","site_admin":false},"repo":{"id":19743950,"name":"pygccxml","full_name":"gccxml/pygccxml","owner":{"login":"gccxml","id":2700451,"avatar_url":"https://avatars.githubusercontent.com/u/2700451?v=3","gravatar_id":"","url":"https://api.github.com/users/gccxml","html_url":"https://github.com/gccxml","followers_url":"https://api.github.com/users/gccxml/followers","following_url":"https://api.github.com/users/gccxml/following{/other_user}","gists_url":"https://api.github.com/users/gccxml/gists{/gist_id}","starred_url":"https://api.github.com/users/gccxml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gccxml/subscriptions","organizations_url":"https://api.github.com/users/gccxml/orgs","repos_url":"https://api.github.com/users/gccxml/repos","events_url":"https://api.github.com/users/gccxml/events{/privacy}","received_events_url":"https://api.github.com/users/gccxml/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gccxml/pygccxml","description":"pygccxml is a specialized XML reader that reads the output from CastXML or GCCXML. It provides a simple framework to navigate C++ declarations, using Python classes.","fork":false,"url":"https://api.github.com/repos/gccxml/pygccxml","forks_url":"https://api.github.com/repos/gccxml/pygccxml/forks","keys_url":"https://api.github.com/repos/gccxml/pygccxml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gccxml/pygccxml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gccxml/pygccxml/teams","hooks_url":"https://api.github.com/repos/gccxml/pygccxml/hooks","issue_events_url":"https://api.github.com/repos/gccxml/pygccxml/issues/events{/number}","events_url":"https://api.github.com/repos/gccxml/pygccxml/events","assignees_url":"https://api.github.com/repos/gccxml/pygccxml/assignees{/user}","branches_url":"https://api.github.com/repos/gccxml/pygccxml/branches{/branch}","tags_url":"https://api.github.com/repos/gccxml/pygccxml/tags","blobs_url":"https://api.github.com/repos/gccxml/pygccxml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gccxml/pygccxml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gccxml/pygccxml/git/refs{/sha}","trees_url":"https://api.github.com/repos/gccxml/pygccxml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gccxml/pygccxml/statuses/{sha}","languages_url":"https://api.github.com/repos/gccxml/pygccxml/languages","stargazers_url":"https://api.github.com/repos/gccxml/pygccxml/stargazers","contributors_url":"https://api.github.com/repos/gccxml/pygccxml/contributors","subscribers_url":"https://api.github.com/repos/gccxml/pygccxml/subscribers","subscription_url":"https://api.github.com/repos/gccxml/pygccxml/subscription","commits_url":"https://api.github.com/repos/gccxml/pygccxml/commits{/sha}","git_commits_url":"https://api.github.com/repos/gccxml/pygccxml/git/commits{/sha}","comments_url":"https://api.github.com/repos/gccxml/pygccxml/comments{/number}","issue_comment_url":"https://api.github.com/repos/gccxml/pygccxml/issues/comments{/number}","contents_url":"https://api.github.com/repos/gccxml/pygccxml/contents/{+path}","compare_url":"https://api.github.com/repos/gccxml/pygccxml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gccxml/pygccxml/merges","archive_url":"https://api.github.com/repos/gccxml/pygccxml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gccxml/pygccxml/downloads","issues_url":"https://api.github.com/repos/gccxml/pygccxml/issues{/number}","pulls_url":"https://api.github.com/repos/gccxml/pygccxml/pulls{/number}","milestones_url":"https://api.github.com/repos/gccxml/pygccxml/milestones{/number}","notifications_url":"https://api.github.com/repos/gccxml/pygccxml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gccxml/pygccxml/labels{/name}","releases_url":"https://api.github.com/repos/gccxml/pygccxml/releases{/id}","deployments_url":"https://api.github.com/repos/gccxml/pygccxml/deployments","created_at":"2014-05-13T15:12:18Z","updated_at":"2016-01-12T15:37:51Z","pushed_at":"2016-03-05T18:13:01Z","git_url":"git://github.com/gccxml/pygccxml.git","ssh_url":"git@github.com:gccxml/pygccxml.git","clone_url":"https://github.com/gccxml/pygccxml.git","svn_url":"https://github.com/gccxml/pygccxml","homepage":"http://pygccxml.readthedocs.org/en/develop/","size":16167,"stargazers_count":16,"watchers_count":16,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":9,"forks":6,"open_issues":9,"watchers":16,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/gccxml/pygccxml/pulls/35"},"html":{"href":"https://github.com/gccxml/pygccxml/pull/35"},"issue":{"href":"https://api.github.com/repos/gccxml/pygccxml/issues/35"},"comments":{"href":"https://api.github.com/repos/gccxml/pygccxml/issues/35/comments"},"review_comments":{"href":"https://api.github.com/repos/gccxml/pygccxml/pulls/35/comments"},"review_comment":{"href":"https://api.github.com/repos/gccxml/pygccxml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gccxml/pygccxml/pulls/35/commits"},"statuses":{"href":"https://api.github.com/repos/gccxml/pygccxml/statuses/c1b59010f8d46727eca2825c2eec58ab246fd28d"}}}}