{"action":"created","issue":{"url":"https://api.github.com/repos/chef-cookbooks/firewall/issues/116","repository_url":"https://api.github.com/repos/chef-cookbooks/firewall","labels_url":"https://api.github.com/repos/chef-cookbooks/firewall/issues/116/labels{/name}","comments_url":"https://api.github.com/repos/chef-cookbooks/firewall/issues/116/comments","events_url":"https://api.github.com/repos/chef-cookbooks/firewall/issues/116/events","html_url":"https://github.com/chef-cookbooks/firewall/pull/116","id":128841624,"number":116,"title":"Enable to define if it is preferred to apply default windows rules or not","user":{"login":"snkutlu","id":1405454,"avatar_url":"https://avatars.githubusercontent.com/u/1405454?v=3","gravatar_id":"","url":"https://api.github.com/users/snkutlu","html_url":"https://github.com/snkutlu","followers_url":"https://api.github.com/users/snkutlu/followers","following_url":"https://api.github.com/users/snkutlu/following{/other_user}","gists_url":"https://api.github.com/users/snkutlu/gists{/gist_id}","starred_url":"https://api.github.com/users/snkutlu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snkutlu/subscriptions","organizations_url":"https://api.github.com/users/snkutlu/orgs","repos_url":"https://api.github.com/users/snkutlu/repos","events_url":"https://api.github.com/users/snkutlu/events{/privacy}","received_events_url":"https://api.github.com/users/snkutlu/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/chef-cookbooks/firewall/labels/Signed%20CLA","name":"Signed CLA","color":"ededed"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":21,"created_at":"2016-01-26T14:45:43Z","updated_at":"2016-03-17T00:50:44Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/chef-cookbooks/firewall/pulls/116","html_url":"https://github.com/chef-cookbooks/firewall/pull/116","diff_url":"https://github.com/chef-cookbooks/firewall/pull/116.diff","patch_url":"https://github.com/chef-cookbooks/firewall/pull/116.patch"},"body":"Set to true by default which will install the default firewall rules (as it is now)\r\n"},"comment":{"url":"https://api.github.com/repos/chef-cookbooks/firewall/issues/comments/197625284","html_url":"https://github.com/chef-cookbooks/firewall/pull/116#issuecomment-197625284","issue_url":"https://api.github.com/repos/chef-cookbooks/firewall/issues/116","id":197625284,"user":{"login":"snkutlu","id":1405454,"avatar_url":"https://avatars.githubusercontent.com/u/1405454?v=3","gravatar_id":"","url":"https://api.github.com/users/snkutlu","html_url":"https://github.com/snkutlu","followers_url":"https://api.github.com/users/snkutlu/followers","following_url":"https://api.github.com/users/snkutlu/following{/other_user}","gists_url":"https://api.github.com/users/snkutlu/gists{/gist_id}","starred_url":"https://api.github.com/users/snkutlu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snkutlu/subscriptions","organizations_url":"https://api.github.com/users/snkutlu/orgs","repos_url":"https://api.github.com/users/snkutlu/repos","events_url":"https://api.github.com/users/snkutlu/events{/privacy}","received_events_url":"https://api.github.com/users/snkutlu/received_events","type":"User","site_admin":false},"created_at":"2016-03-17T00:50:44Z","updated_at":"2016-03-17T00:50:44Z","body":"@martin3b in the link you provided for DSC, it defines functions to be used for firewall management, and in examples directory, there is one sample on how to use this functions to install default firewall rules\r\n\r\nI did not see the relation with that feature and the link. \r\n\r\nThat feature I am trying to add makes an existing function usage in that recipe (reset!) based on a condition: Does the user want to have default rules or not? \r\n\r\nAs a system administrator, we do not / should not prefer default firewall rules applied to our systems. Security wise, block all then enable what you want is a good approach. \r\n\r\nI am also fine if you want this \"reset!\" function to be completely removed from line 75. Then this will be a breaking change and will not be backward compatible. "}}