{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/treeherder/pulls/comments/88959743","pull_request_review_id":9515119,"id":88959743,"diff_hunk":"@@ -25,33 +25,32 @@\n     </span>\n     <th-result-counts class=\"result-counts\"></th-result-counts>\n     <span class=\"result-set-buttons\">\n-      <span class=\"btn btn-sm btn-resultset cancel-all-jobs-btn\"\n+      <button class=\"btn btn-sm btn-resultset cancel-all-jobs-btn\"\n             tabindex=\"0\" role=\"button\"\n             ng-attr-title=\"{{getCancelJobsTitle(resultset.revision)}}\"\n-            ng-show=\"currentRepo.repository_group.name == 'try' || user.is_staff\"","path":"ui/partials/main/jobs.html","position":8,"original_position":8,"commit_id":"4725670dea26c595095387999e22595012030132","original_commit_id":"4725670dea26c595095387999e22595012030132","user":{"login":"tojon","id":3660661,"avatar_url":"https://avatars.githubusercontent.com/u/3660661?v=3","gravatar_id":"","url":"https://api.github.com/users/tojon","html_url":"https://github.com/tojon","followers_url":"https://api.github.com/users/tojon/followers","following_url":"https://api.github.com/users/tojon/following{/other_user}","gists_url":"https://api.github.com/users/tojon/gists{/gist_id}","starred_url":"https://api.github.com/users/tojon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tojon/subscriptions","organizations_url":"https://api.github.com/users/tojon/orgs","repos_url":"https://api.github.com/users/tojon/repos","events_url":"https://api.github.com/users/tojon/events{/privacy}","received_events_url":"https://api.github.com/users/tojon/received_events","type":"User","site_admin":false},"body":"Just checking this is intentional, vs. previously hiding it. The change makes sense to me given our recent approach for that sort of thing.","created_at":"2016-11-21T18:42:41Z","updated_at":"2016-11-21T18:42:41Z","html_url":"https://github.com/mozilla/treeherder/pull/1990#discussion_r88959743","pull_request_url":"https://api.github.com/repos/mozilla/treeherder/pulls/1990","_links":{"self":{"href":"https://api.github.com/repos/mozilla/treeherder/pulls/comments/88959743"},"html":{"href":"https://github.com/mozilla/treeherder/pull/1990#discussion_r88959743"},"pull_request":{"href":"https://api.github.com/repos/mozilla/treeherder/pulls/1990"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/treeherder/pulls/1990","id":94670173,"html_url":"https://github.com/mozilla/treeherder/pull/1990","diff_url":"https://github.com/mozilla/treeherder/pull/1990.diff","patch_url":"https://github.com/mozilla/treeherder/pull/1990.patch","issue_url":"https://api.github.com/repos/mozilla/treeherder/issues/1990","number":1990,"state":"open","locked":false,"title":"Bug 1319146 - Render resultset buttons as actual buttons, not spans","user":{"login":"wlach","id":20569,"avatar_url":"https://avatars.githubusercontent.com/u/20569?v=3","gravatar_id":"","url":"https://api.github.com/users/wlach","html_url":"https://github.com/wlach","followers_url":"https://api.github.com/users/wlach/followers","following_url":"https://api.github.com/users/wlach/following{/other_user}","gists_url":"https://api.github.com/users/wlach/gists{/gist_id}","starred_url":"https://api.github.com/users/wlach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wlach/subscriptions","organizations_url":"https://api.github.com/users/wlach/orgs","repos_url":"https://api.github.com/users/wlach/repos","events_url":"https://api.github.com/users/wlach/events{/privacy}","received_events_url":"https://api.github.com/users/wlach/received_events","type":"User","site_admin":false},"body":"They were defined as spans which meant:\n\n1. They weren't a proper click target for screen readers\n2. They were still selectable even if disabled (e.g. try to click on cancel as not logged-in user on try).\n\nFixing this is simple, so let's just do it.","created_at":"2016-11-21T18:28:19Z","updated_at":"2016-11-21T18:42:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ad911e25633de27b9433a70976041a4b2b9e5a7a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/treeherder/pulls/1990/commits","review_comments_url":"https://api.github.com/repos/mozilla/treeherder/pulls/1990/comments","review_comment_url":"https://api.github.com/repos/mozilla/treeherder/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/treeherder/issues/1990/comments","statuses_url":"https://api.github.com/repos/mozilla/treeherder/statuses/4725670dea26c595095387999e22595012030132","head":{"label":"wlach:1319146","ref":"1319146","sha":"4725670dea26c595095387999e22595012030132","user":{"login":"wlach","id":20569,"avatar_url":"https://avatars.githubusercontent.com/u/20569?v=3","gravatar_id":"","url":"https://api.github.com/users/wlach","html_url":"https://github.com/wlach","followers_url":"https://api.github.com/users/wlach/followers","following_url":"https://api.github.com/users/wlach/following{/other_user}","gists_url":"https://api.github.com/users/wlach/gists{/gist_id}","starred_url":"https://api.github.com/users/wlach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wlach/subscriptions","organizations_url":"https://api.github.com/users/wlach/orgs","repos_url":"https://api.github.com/users/wlach/repos","events_url":"https://api.github.com/users/wlach/events{/privacy}","received_events_url":"https://api.github.com/users/wlach/received_events","type":"User","site_admin":false},"repo":{"id":25893449,"name":"treeherder","full_name":"wlach/treeherder","owner":{"login":"wlach","id":20569,"avatar_url":"https://avatars.githubusercontent.com/u/20569?v=3","gravatar_id":"","url":"https://api.github.com/users/wlach","html_url":"https://github.com/wlach","followers_url":"https://api.github.com/users/wlach/followers","following_url":"https://api.github.com/users/wlach/following{/other_user}","gists_url":"https://api.github.com/users/wlach/gists{/gist_id}","starred_url":"https://api.github.com/users/wlach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wlach/subscriptions","organizations_url":"https://api.github.com/users/wlach/orgs","repos_url":"https://api.github.com/users/wlach/repos","events_url":"https://api.github.com/users/wlach/events{/privacy}","received_events_url":"https://api.github.com/users/wlach/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wlach/treeherder","description":"The backend of treeherder, a replacement for TBPL. See wiki page for where to file bugs.","fork":true,"url":"https://api.github.com/repos/wlach/treeherder","forks_url":"https://api.github.com/repos/wlach/treeherder/forks","keys_url":"https://api.github.com/repos/wlach/treeherder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wlach/treeherder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wlach/treeherder/teams","hooks_url":"https://api.github.com/repos/wlach/treeherder/hooks","issue_events_url":"https://api.github.com/repos/wlach/treeherder/issues/events{/number}","events_url":"https://api.github.com/repos/wlach/treeherder/events","assignees_url":"https://api.github.com/repos/wlach/treeherder/assignees{/user}","branches_url":"https://api.github.com/repos/wlach/treeherder/branches{/branch}","tags_url":"https://api.github.com/repos/wlach/treeherder/tags","blobs_url":"https://api.github.com/repos/wlach/treeherder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wlach/treeherder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wlach/treeherder/git/refs{/sha}","trees_url":"https://api.github.com/repos/wlach/treeherder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wlach/treeherder/statuses/{sha}","languages_url":"https://api.github.com/repos/wlach/treeherder/languages","stargazers_url":"https://api.github.com/repos/wlach/treeherder/stargazers","contributors_url":"https://api.github.com/repos/wlach/treeherder/contributors","subscribers_url":"https://api.github.com/repos/wlach/treeherder/subscribers","subscription_url":"https://api.github.com/repos/wlach/treeherder/subscription","commits_url":"https://api.github.com/repos/wlach/treeherder/commits{/sha}","git_commits_url":"https://api.github.com/repos/wlach/treeherder/git/commits{/sha}","comments_url":"https://api.github.com/repos/wlach/treeherder/comments{/number}","issue_comment_url":"https://api.github.com/repos/wlach/treeherder/issues/comments{/number}","contents_url":"https://api.github.com/repos/wlach/treeherder/contents/{+path}","compare_url":"https://api.github.com/repos/wlach/treeherder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wlach/treeherder/merges","archive_url":"https://api.github.com/repos/wlach/treeherder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wlach/treeherder/downloads","issues_url":"https://api.github.com/repos/wlach/treeherder/issues{/number}","pulls_url":"https://api.github.com/repos/wlach/treeherder/pulls{/number}","milestones_url":"https://api.github.com/repos/wlach/treeherder/milestones{/number}","notifications_url":"https://api.github.com/repos/wlach/treeherder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wlach/treeherder/labels{/name}","releases_url":"https://api.github.com/repos/wlach/treeherder/releases{/id}","deployments_url":"https://api.github.com/repos/wlach/treeherder/deployments","created_at":"2014-10-28T22:37:53Z","updated_at":"2016-04-04T15:14:01Z","pushed_at":"2016-11-21T18:27:45Z","git_url":"git://github.com/wlach/treeherder.git","ssh_url":"git@github.com:wlach/treeherder.git","clone_url":"https://github.com/wlach/treeherder.git","svn_url":"https://github.com/wlach/treeherder","homepage":"https://wiki.mozilla.org/Auto-tools/Projects/Treeherder","size":53150,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"64dcd973f8c21b730a4624a4d1fa19b8c4bc7c40","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":8463294,"name":"treeherder","full_name":"mozilla/treeherder","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/treeherder","description":"A system for managing CI data for Mozilla projects","fork":false,"url":"https://api.github.com/repos/mozilla/treeherder","forks_url":"https://api.github.com/repos/mozilla/treeherder/forks","keys_url":"https://api.github.com/repos/mozilla/treeherder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/treeherder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/treeherder/teams","hooks_url":"https://api.github.com/repos/mozilla/treeherder/hooks","issue_events_url":"https://api.github.com/repos/mozilla/treeherder/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/treeherder/events","assignees_url":"https://api.github.com/repos/mozilla/treeherder/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/treeherder/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/treeherder/tags","blobs_url":"https://api.github.com/repos/mozilla/treeherder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/treeherder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/treeherder/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/treeherder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/treeherder/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/treeherder/languages","stargazers_url":"https://api.github.com/repos/mozilla/treeherder/stargazers","contributors_url":"https://api.github.com/repos/mozilla/treeherder/contributors","subscribers_url":"https://api.github.com/repos/mozilla/treeherder/subscribers","subscription_url":"https://api.github.com/repos/mozilla/treeherder/subscription","commits_url":"https://api.github.com/repos/mozilla/treeherder/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/treeherder/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/treeherder/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/treeherder/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/treeherder/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/treeherder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/treeherder/merges","archive_url":"https://api.github.com/repos/mozilla/treeherder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/treeherder/downloads","issues_url":"https://api.github.com/repos/mozilla/treeherder/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/treeherder/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/treeherder/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/treeherder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/treeherder/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/treeherder/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/treeherder/deployments","created_at":"2013-02-27T19:17:37Z","updated_at":"2016-11-18T14:52:06Z","pushed_at":"2016-11-21T18:33:21Z","git_url":"git://github.com/mozilla/treeherder.git","ssh_url":"git@github.com:mozilla/treeherder.git","clone_url":"https://github.com/mozilla/treeherder.git","svn_url":"https://github.com/mozilla/treeherder","homepage":"https://wiki.mozilla.org/EngineeringProductivity/Projects/Treeherder","size":402007,"stargazers_count":71,"watchers_count":71,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":122,"mirror_url":null,"open_issues_count":32,"forks":122,"open_issues":32,"watchers":71,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/treeherder/pulls/1990"},"html":{"href":"https://github.com/mozilla/treeherder/pull/1990"},"issue":{"href":"https://api.github.com/repos/mozilla/treeherder/issues/1990"},"comments":{"href":"https://api.github.com/repos/mozilla/treeherder/issues/1990/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/treeherder/pulls/1990/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/treeherder/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/treeherder/pulls/1990/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/treeherder/statuses/4725670dea26c595095387999e22595012030132"}}}}
{"actor":{"display_login":"tojon"}}