{"action":"created","comment":{"url":"https://api.github.com/repos/NGPVAN/developers.ngpvan.com/pulls/comments/74775969","id":74775969,"diff_hunk":"@@ -0,0 +1,9 @@\n+extends ../../app/views/section","path":"docs/van-api/16-designations.jade","position":1,"original_position":1,"commit_id":"fca76945740d36a3d2854ab714691013f557dd50","original_commit_id":"fca76945740d36a3d2854ab714691013f557dd50","user":{"login":"shaisachs","id":910582,"avatar_url":"https://avatars.githubusercontent.com/u/910582?v=3","gravatar_id":"","url":"https://api.github.com/users/shaisachs","html_url":"https://github.com/shaisachs","followers_url":"https://api.github.com/users/shaisachs/followers","following_url":"https://api.github.com/users/shaisachs/following{/other_user}","gists_url":"https://api.github.com/users/shaisachs/gists{/gist_id}","starred_url":"https://api.github.com/users/shaisachs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shaisachs/subscriptions","organizations_url":"https://api.github.com/users/shaisachs/orgs","repos_url":"https://api.github.com/users/shaisachs/repos","events_url":"https://api.github.com/users/shaisachs/events{/privacy}","received_events_url":"https://api.github.com/users/shaisachs/received_events","type":"User","site_admin":false},"body":"Kind of a minor point, but you should change the name to 17-designations because 16 is used in #139","created_at":"2016-08-15T15:07:12Z","updated_at":"2016-08-15T15:07:12Z","html_url":"https://github.com/NGPVAN/developers.ngpvan.com/pull/141#discussion_r74775969","pull_request_url":"https://api.github.com/repos/NGPVAN/developers.ngpvan.com/pulls/141","_links":{"self":{"href":"https://api.github.com/repos/NGPVAN/developers.ngpvan.com/pulls/comments/74775969"},"html":{"href":"https://github.com/NGPVAN/developers.ngpvan.com/pull/141#discussion_r74775969"},"pull_request":{"href":"https://api.github.com/repos/NGPVAN/developers.ngpvan.com/pulls/141"}}},"pull_request":{"url":"https://api.github.com/repos/NGPVAN/developers.ngpvan.com/pulls/141","id":81016133,"html_url":"https://github.com/NGPVAN/developers.ngpvan.com/pull/141","diff_url":"https://github.com/NGPVAN/developers.ngpvan.com/pull/141.diff","patch_url":"https://github.com/NGPVAN/developers.ngpvan.com/pull/141.patch","issue_url":"https://api.github.com/repos/NGPVAN/developers.ngpvan.com/issues/141","number":141,"state":"open","locked":false,"title":"VAN-24797 get designations api","user":{"login":"ojintoad","id":3084796,"avatar_url":"https://avatars.githubusercontent.com/u/3084796?v=3","gravatar_id":"","url":"https://api.github.com/users/ojintoad","html_url":"https://github.com/ojintoad","followers_url":"https://api.github.com/users/ojintoad/followers","following_url":"https://api.github.com/users/ojintoad/following{/other_user}","gists_url":"https://api.github.com/users/ojintoad/gists{/gist_id}","starred_url":"https://api.github.com/users/ojintoad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ojintoad/subscriptions","organizations_url":"https://api.github.com/users/ojintoad/orgs","repos_url":"https://api.github.com/users/ojintoad/repos","events_url":"https://api.github.com/users/ojintoad/events{/privacy}","received_events_url":"https://api.github.com/users/ojintoad/received_events","type":"User","site_admin":false},"body":"[VAN-24797](https://ngpvan.atlassian.net/browse/VAN-24797) first pass\r\n\r\n@shaisachs @NGPVAN/team-sienna @rwinikates\r\n\r\nI noticed that there are pagination options for other endpoints. I don't know if the volume of designations is such that we need to add those for this API.","created_at":"2016-08-11T19:28:23Z","updated_at":"2016-08-15T15:07:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2b9761c7153d1787a11d9fa5bb8cefd57cd9b714","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/NGPVAN/developers.ngpvan.com/pulls/141/commits","review_comments_url":"https://api.github.com/repos/NGPVAN/developers.ngpvan.com/pulls/141/comments","review_comment_url":"https://api.github.com/repos/NGPVAN/developers.ngpvan.com/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NGPVAN/developers.ngpvan.com/issues/141/comments","statuses_url":"https://api.github.com/repos/NGPVAN/developers.ngpvan.com/statuses/fca76945740d36a3d2854ab714691013f557dd50","head":{"label":"NGPVAN:sienna/van-24797-get-designations-api","ref":"sienna/van-24797-get-designations-api","sha":"fca76945740d36a3d2854ab714691013f557dd50","user":{"login":"NGPVAN","id":729820,"avatar_url":"https://avatars.githubusercontent.com/u/729820?v=3","gravatar_id":"","url":"https://api.github.com/users/NGPVAN","html_url":"https://github.com/NGPVAN","followers_url":"https://api.github.com/users/NGPVAN/followers","following_url":"https://api.github.com/users/NGPVAN/following{/other_user}","gists_url":"https://api.github.com/users/NGPVAN/gists{/gist_id}","starred_url":"https://api.github.com/users/NGPVAN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NGPVAN/subscriptions","organizations_url":"https://api.github.com/users/NGPVAN/orgs","repos_url":"https://api.github.com/users/NGPVAN/repos","events_url":"https://api.github.com/users/NGPVAN/events{/privacy}","received_events_url":"https://api.github.com/users/NGPVAN/received_events","type":"Organization","site_admin":false},"repo":{"id":20279291,"name":"developers.ngpvan.com","full_name":"NGPVAN/developers.ngpvan.com","owner":{"login":"NGPVAN","id":729820,"avatar_url":"https://avatars.githubusercontent.com/u/729820?v=3","gravatar_id":"","url":"https://api.github.com/users/NGPVAN","html_url":"https://github.com/NGPVAN","followers_url":"https://api.github.com/users/NGPVAN/followers","following_url":"https://api.github.com/users/NGPVAN/following{/other_user}","gists_url":"https://api.github.com/users/NGPVAN/gists{/gist_id}","starred_url":"https://api.github.com/users/NGPVAN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NGPVAN/subscriptions","organizations_url":"https://api.github.com/users/NGPVAN/orgs","repos_url":"https://api.github.com/users/NGPVAN/repos","events_url":"https://api.github.com/users/NGPVAN/events{/privacy}","received_events_url":"https://api.github.com/users/NGPVAN/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NGPVAN/developers.ngpvan.com","description":"Portal for third party developers","fork":false,"url":"https://api.github.com/repos/NGPVAN/developers.ngpvan.com","forks_url":"https://api.github.com/repos/NGPVAN/developers.ngpvan.com/forks","keys_url":"https://api.github.com/repos/NGPVAN/developers.ngpvan.com/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NGPVAN/developers.ngpvan.com/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NGPVAN/developers.ngpvan.com/teams","hooks_url":"https://api.github.com/repos/NGPVAN/developers.ngpvan.com/hooks","issue_events_url":"https://api.github.com/repos/NGPVAN/developers.ngpvan.com/issues/events{/number}","events_url":"https://api.github.com/repos/NGPVAN/developers.ngpvan.com/events","assignees_url":"https://api.github.com/repos/NGPVAN/developers.ngpvan.com/assignees{/user}","branches_url":"https://api.github.com/repos/NGPVAN/developers.ngpvan.com/branches{/branch}","tags_url":"https://api.github.com/repos/NGPVAN/developers.ngpvan.com/tags","blobs_url":"https://api.github.com/repos/NGPVAN/developers.ngpvan.com/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NGPVAN/developers.ngpvan.com/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NGPVAN/developers.ngpvan.com/git/refs{/sha}","trees_url":"https://api.github.com/repos/NGPVAN/developers.ngpvan.com/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NGPVAN/developers.ngpvan.com/statuses/{sha}","languages_url":"https://api.github.com/repos/NGPVAN/developers.ngpvan.com/languages","stargazers_url":"https://api.github.com/repos/NGPVAN/developers.ngpvan.com/stargazers","contributors_url":"https://api.github.com/repos/NGPVAN/developers.ngpvan.com/contributors","subscribers_url":"https://api.github.com/repos/NGPVAN/developers.ngpvan.com/subscribers","subscription_url":"https://api.github.com/repos/NGPVAN/developers.ngpvan.com/subscription","commits_url":"https://api.github.com/repos/NGPVAN/developers.ngpvan.com/commits{/sha}","git_commits_url":"https://api.github.com/repos/NGPVAN/developers.ngpvan.com/git/commits{/sha}","comments_url":"https://api.github.com/repos/NGPVAN/developers.ngpvan.com/comments{/number}","issue_comment_url":"https://api.github.com/repos/NGPVAN/developers.ngpvan.com/issues/comments{/number}","contents_url":"https://api.github.com/repos/NGPVAN/developers.ngpvan.com/contents/{+path}","compare_url":"https://api.github.com/repos/NGPVAN/developers.ngpvan.com/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NGPVAN/developers.ngpvan.com/merges","archive_url":"https://api.github.com/repos/NGPVAN/developers.ngpvan.com/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NGPVAN/developers.ngpvan.com/downloads","issues_url":"https://api.github.com/repos/NGPVAN/developers.ngpvan.com/issues{/number}","pulls_url":"https://api.github.com/repos/NGPVAN/developers.ngpvan.com/pulls{/number}","milestones_url":"https://api.github.com/repos/NGPVAN/developers.ngpvan.com/milestones{/number}","notifications_url":"https://api.github.com/repos/NGPVAN/developers.ngpvan.com/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NGPVAN/developers.ngpvan.com/labels{/name}","releases_url":"https://api.github.com/repos/NGPVAN/developers.ngpvan.com/releases{/id}","deployments_url":"https://api.github.com/repos/NGPVAN/developers.ngpvan.com/deployments","created_at":"2014-05-29T02:04:42Z","updated_at":"2016-03-16T16:43:04Z","pushed_at":"2016-08-15T14:48:16Z","git_url":"git://github.com/NGPVAN/developers.ngpvan.com.git","ssh_url":"git@github.com:NGPVAN/developers.ngpvan.com.git","clone_url":"https://github.com/NGPVAN/developers.ngpvan.com.git","svn_url":"https://github.com/NGPVAN/developers.ngpvan.com","homepage":"http://developers.ngpvan.com","size":2418,"stargazers_count":4,"watchers_count":4,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":22,"forks":1,"open_issues":22,"watchers":4,"default_branch":"develop"}},"base":{"label":"NGPVAN:develop","ref":"develop","sha":"6f5cae31e92e9641fb282049f7323af9a6031aca","user":{"login":"NGPVAN","id":729820,"avatar_url":"https://avatars.githubusercontent.com/u/729820?v=3","gravatar_id":"","url":"https://api.github.com/users/NGPVAN","html_url":"https://github.com/NGPVAN","followers_url":"https://api.github.com/users/NGPVAN/followers","following_url":"https://api.github.com/users/NGPVAN/following{/other_user}","gists_url":"https://api.github.com/users/NGPVAN/gists{/gist_id}","starred_url":"https://api.github.com/users/NGPVAN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NGPVAN/subscriptions","organizations_url":"https://api.github.com/users/NGPVAN/orgs","repos_url":"https://api.github.com/users/NGPVAN/repos","events_url":"https://api.github.com/users/NGPVAN/events{/privacy}","received_events_url":"https://api.github.com/users/NGPVAN/received_events","type":"Organization","site_admin":false},"repo":{"id":20279291,"name":"developers.ngpvan.com","full_name":"NGPVAN/developers.ngpvan.com","owner":{"login":"NGPVAN","id":729820,"avatar_url":"https://avatars.githubusercontent.com/u/729820?v=3","gravatar_id":"","url":"https://api.github.com/users/NGPVAN","html_url":"https://github.com/NGPVAN","followers_url":"https://api.github.com/users/NGPVAN/followers","following_url":"https://api.github.com/users/NGPVAN/following{/other_user}","gists_url":"https://api.github.com/users/NGPVAN/gists{/gist_id}","starred_url":"https://api.github.com/users/NGPVAN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NGPVAN/subscriptions","organizations_url":"https://api.github.com/users/NGPVAN/orgs","repos_url":"https://api.github.com/users/NGPVAN/repos","events_url":"https://api.github.com/users/NGPVAN/events{/privacy}","received_events_url":"https://api.github.com/users/NGPVAN/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NGPVAN/developers.ngpvan.com","description":"Portal for third party developers","fork":false,"url":"https://api.github.com/repos/NGPVAN/developers.ngpvan.com","forks_url":"https://api.github.com/repos/NGPVAN/developers.ngpvan.com/forks","keys_url":"https://api.github.com/repos/NGPVAN/developers.ngpvan.com/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NGPVAN/developers.ngpvan.com/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NGPVAN/developers.ngpvan.com/teams","hooks_url":"https://api.github.com/repos/NGPVAN/developers.ngpvan.com/hooks","issue_events_url":"https://api.github.com/repos/NGPVAN/developers.ngpvan.com/issues/events{/number}","events_url":"https://api.github.com/repos/NGPVAN/developers.ngpvan.com/events","assignees_url":"https://api.github.com/repos/NGPVAN/developers.ngpvan.com/assignees{/user}","branches_url":"https://api.github.com/repos/NGPVAN/developers.ngpvan.com/branches{/branch}","tags_url":"https://api.github.com/repos/NGPVAN/developers.ngpvan.com/tags","blobs_url":"https://api.github.com/repos/NGPVAN/developers.ngpvan.com/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NGPVAN/developers.ngpvan.com/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NGPVAN/developers.ngpvan.com/git/refs{/sha}","trees_url":"https://api.github.com/repos/NGPVAN/developers.ngpvan.com/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NGPVAN/developers.ngpvan.com/statuses/{sha}","languages_url":"https://api.github.com/repos/NGPVAN/developers.ngpvan.com/languages","stargazers_url":"https://api.github.com/repos/NGPVAN/developers.ngpvan.com/stargazers","contributors_url":"https://api.github.com/repos/NGPVAN/developers.ngpvan.com/contributors","subscribers_url":"https://api.github.com/repos/NGPVAN/developers.ngpvan.com/subscribers","subscription_url":"https://api.github.com/repos/NGPVAN/developers.ngpvan.com/subscription","commits_url":"https://api.github.com/repos/NGPVAN/developers.ngpvan.com/commits{/sha}","git_commits_url":"https://api.github.com/repos/NGPVAN/developers.ngpvan.com/git/commits{/sha}","comments_url":"https://api.github.com/repos/NGPVAN/developers.ngpvan.com/comments{/number}","issue_comment_url":"https://api.github.com/repos/NGPVAN/developers.ngpvan.com/issues/comments{/number}","contents_url":"https://api.github.com/repos/NGPVAN/developers.ngpvan.com/contents/{+path}","compare_url":"https://api.github.com/repos/NGPVAN/developers.ngpvan.com/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NGPVAN/developers.ngpvan.com/merges","archive_url":"https://api.github.com/repos/NGPVAN/developers.ngpvan.com/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NGPVAN/developers.ngpvan.com/downloads","issues_url":"https://api.github.com/repos/NGPVAN/developers.ngpvan.com/issues{/number}","pulls_url":"https://api.github.com/repos/NGPVAN/developers.ngpvan.com/pulls{/number}","milestones_url":"https://api.github.com/repos/NGPVAN/developers.ngpvan.com/milestones{/number}","notifications_url":"https://api.github.com/repos/NGPVAN/developers.ngpvan.com/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NGPVAN/developers.ngpvan.com/labels{/name}","releases_url":"https://api.github.com/repos/NGPVAN/developers.ngpvan.com/releases{/id}","deployments_url":"https://api.github.com/repos/NGPVAN/developers.ngpvan.com/deployments","created_at":"2014-05-29T02:04:42Z","updated_at":"2016-03-16T16:43:04Z","pushed_at":"2016-08-15T14:48:16Z","git_url":"git://github.com/NGPVAN/developers.ngpvan.com.git","ssh_url":"git@github.com:NGPVAN/developers.ngpvan.com.git","clone_url":"https://github.com/NGPVAN/developers.ngpvan.com.git","svn_url":"https://github.com/NGPVAN/developers.ngpvan.com","homepage":"http://developers.ngpvan.com","size":2418,"stargazers_count":4,"watchers_count":4,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":22,"forks":1,"open_issues":22,"watchers":4,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/NGPVAN/developers.ngpvan.com/pulls/141"},"html":{"href":"https://github.com/NGPVAN/developers.ngpvan.com/pull/141"},"issue":{"href":"https://api.github.com/repos/NGPVAN/developers.ngpvan.com/issues/141"},"comments":{"href":"https://api.github.com/repos/NGPVAN/developers.ngpvan.com/issues/141/comments"},"review_comments":{"href":"https://api.github.com/repos/NGPVAN/developers.ngpvan.com/pulls/141/comments"},"review_comment":{"href":"https://api.github.com/repos/NGPVAN/developers.ngpvan.com/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NGPVAN/developers.ngpvan.com/pulls/141/commits"},"statuses":{"href":"https://api.github.com/repos/NGPVAN/developers.ngpvan.com/statuses/fca76945740d36a3d2854ab714691013f557dd50"}}}}
{"actor":{"display_login":"shaisachs"}}