{"action":"created","comment":{"url":"https://api.github.com/repos/servo/servo/pulls/comments/90173572","pull_request_review_id":10695680,"id":90173572,"diff_hunk":"@@ -772,7 +772,11 @@ fn http_redirect_fetch(request: Rc<Request>,\n     };\n \n     // Step 4\n-    // TODO implement return network_error if not HTTP(S)\n+    match location_url.scheme() {\n+        \"http\" => { },\n+        \"https\" => { },\n+        _ => return Response::network_error(NetworkError::Internal(\"Not an HTTPS Scheme\".into()))","path":"components/net/http_loader.rs","position":8,"original_position":8,"commit_id":"6d64461f9465ee05939745488f2a8e5798b239af","original_commit_id":"6d64461f9465ee05939745488f2a8e5798b239af","user":{"login":"KiChjang","id":3248587,"avatar_url":"https://avatars.githubusercontent.com/u/3248587?v=3","gravatar_id":"","url":"https://api.github.com/users/KiChjang","html_url":"https://github.com/KiChjang","followers_url":"https://api.github.com/users/KiChjang/followers","following_url":"https://api.github.com/users/KiChjang/following{/other_user}","gists_url":"https://api.github.com/users/KiChjang/gists{/gist_id}","starred_url":"https://api.github.com/users/KiChjang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KiChjang/subscriptions","organizations_url":"https://api.github.com/users/KiChjang/orgs","repos_url":"https://api.github.com/users/KiChjang/repos","events_url":"https://api.github.com/users/KiChjang/events{/privacy}","received_events_url":"https://api.github.com/users/KiChjang/received_events","type":"User","site_admin":false},"body":"`\"Not an HTTP(S) scheme\"`.","created_at":"2016-11-30T06:04:33Z","updated_at":"2016-11-30T06:07:03Z","html_url":"https://github.com/servo/servo/pull/14420#discussion_r90173572","pull_request_url":"https://api.github.com/repos/servo/servo/pulls/14420","_links":{"self":{"href":"https://api.github.com/repos/servo/servo/pulls/comments/90173572"},"html":{"href":"https://github.com/servo/servo/pull/14420#discussion_r90173572"},"pull_request":{"href":"https://api.github.com/repos/servo/servo/pulls/14420"}}},"pull_request":{"url":"https://api.github.com/repos/servo/servo/pulls/14420","id":95831484,"html_url":"https://github.com/servo/servo/pull/14420","diff_url":"https://github.com/servo/servo/pull/14420.diff","patch_url":"https://github.com/servo/servo/pull/14420.patch","issue_url":"https://api.github.com/repos/servo/servo/issues/14420","number":14420,"state":"open","locked":false,"title":"Made http_redirect_fetch error for non-HTTPS. #14069","user":{"login":"46bit","id":163111,"avatar_url":"https://avatars.githubusercontent.com/u/163111?v=3","gravatar_id":"","url":"https://api.github.com/users/46bit","html_url":"https://github.com/46bit","followers_url":"https://api.github.com/users/46bit/followers","following_url":"https://api.github.com/users/46bit/following{/other_user}","gists_url":"https://api.github.com/users/46bit/gists{/gist_id}","starred_url":"https://api.github.com/users/46bit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/46bit/subscriptions","organizations_url":"https://api.github.com/users/46bit/orgs","repos_url":"https://api.github.com/users/46bit/repos","events_url":"https://api.github.com/users/46bit/events{/privacy}","received_events_url":"https://api.github.com/users/46bit/received_events","type":"User","site_admin":false},"body":"Hi! I'm a newbie looking to resolve #14069.\r\n\r\nThe [existing tests](https://dxr.mozilla.org/servo/source/tests/wpt/web-platform-tests/fetch/api/redirect/redirect-schemes.html) now pass. \r\n\r\n* Should I add \"http\" and \"https\" tests that check for 200 status code? \r\n  * Are there convenient URLs for which I could assume 200?\r\n* I found `NetworkError::SslValidation(ServoUrl, String)`. This isn't about Certificate Validation and I think the `NetworkError::Internal` variant is correct?\r\n\r\nCheers!\r\n\r\n---\r\n<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->\r\n- [X] `./mach build -d` does not report any errors\r\n- [X] `./mach test-tidy` does not report any errors\r\n- [X] These changes fix #14069 (github issue number if applicable).\r\n\r\n<!-- Either: -->\r\n- [X] There are tests for these changes OR\r\n<!-- - [ ] These changes do not require tests because _____ -->\r\n\r\n<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/servo/servo/14420)\r\n<!-- Reviewable:end -->\r\n","created_at":"2016-11-30T05:47:57Z","updated_at":"2016-11-30T06:07:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f61ec73a81e09bef51e1a46831f68a1797b20ed6","assignee":{"login":"KiChjang","id":3248587,"avatar_url":"https://avatars.githubusercontent.com/u/3248587?v=3","gravatar_id":"","url":"https://api.github.com/users/KiChjang","html_url":"https://github.com/KiChjang","followers_url":"https://api.github.com/users/KiChjang/followers","following_url":"https://api.github.com/users/KiChjang/following{/other_user}","gists_url":"https://api.github.com/users/KiChjang/gists{/gist_id}","starred_url":"https://api.github.com/users/KiChjang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KiChjang/subscriptions","organizations_url":"https://api.github.com/users/KiChjang/orgs","repos_url":"https://api.github.com/users/KiChjang/repos","events_url":"https://api.github.com/users/KiChjang/events{/privacy}","received_events_url":"https://api.github.com/users/KiChjang/received_events","type":"User","site_admin":false},"assignees":[{"login":"KiChjang","id":3248587,"avatar_url":"https://avatars.githubusercontent.com/u/3248587?v=3","gravatar_id":"","url":"https://api.github.com/users/KiChjang","html_url":"https://github.com/KiChjang","followers_url":"https://api.github.com/users/KiChjang/followers","following_url":"https://api.github.com/users/KiChjang/following{/other_user}","gists_url":"https://api.github.com/users/KiChjang/gists{/gist_id}","starred_url":"https://api.github.com/users/KiChjang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KiChjang/subscriptions","organizations_url":"https://api.github.com/users/KiChjang/orgs","repos_url":"https://api.github.com/users/KiChjang/repos","events_url":"https://api.github.com/users/KiChjang/events{/privacy}","received_events_url":"https://api.github.com/users/KiChjang/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/servo/servo/pulls/14420/commits","review_comments_url":"https://api.github.com/repos/servo/servo/pulls/14420/comments","review_comment_url":"https://api.github.com/repos/servo/servo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/servo/servo/issues/14420/comments","statuses_url":"https://api.github.com/repos/servo/servo/statuses/6d64461f9465ee05939745488f2a8e5798b239af","head":{"label":"46bit:master","ref":"master","sha":"6d64461f9465ee05939745488f2a8e5798b239af","user":{"login":"46bit","id":163111,"avatar_url":"https://avatars.githubusercontent.com/u/163111?v=3","gravatar_id":"","url":"https://api.github.com/users/46bit","html_url":"https://github.com/46bit","followers_url":"https://api.github.com/users/46bit/followers","following_url":"https://api.github.com/users/46bit/following{/other_user}","gists_url":"https://api.github.com/users/46bit/gists{/gist_id}","starred_url":"https://api.github.com/users/46bit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/46bit/subscriptions","organizations_url":"https://api.github.com/users/46bit/orgs","repos_url":"https://api.github.com/users/46bit/repos","events_url":"https://api.github.com/users/46bit/events{/privacy}","received_events_url":"https://api.github.com/users/46bit/received_events","type":"User","site_admin":false},"repo":{"id":75154265,"name":"servo","full_name":"46bit/servo","owner":{"login":"46bit","id":163111,"avatar_url":"https://avatars.githubusercontent.com/u/163111?v=3","gravatar_id":"","url":"https://api.github.com/users/46bit","html_url":"https://github.com/46bit","followers_url":"https://api.github.com/users/46bit/followers","following_url":"https://api.github.com/users/46bit/following{/other_user}","gists_url":"https://api.github.com/users/46bit/gists{/gist_id}","starred_url":"https://api.github.com/users/46bit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/46bit/subscriptions","organizations_url":"https://api.github.com/users/46bit/orgs","repos_url":"https://api.github.com/users/46bit/repos","events_url":"https://api.github.com/users/46bit/events{/privacy}","received_events_url":"https://api.github.com/users/46bit/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/46bit/servo","description":"The Servo Browser Engine","fork":true,"url":"https://api.github.com/repos/46bit/servo","forks_url":"https://api.github.com/repos/46bit/servo/forks","keys_url":"https://api.github.com/repos/46bit/servo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/46bit/servo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/46bit/servo/teams","hooks_url":"https://api.github.com/repos/46bit/servo/hooks","issue_events_url":"https://api.github.com/repos/46bit/servo/issues/events{/number}","events_url":"https://api.github.com/repos/46bit/servo/events","assignees_url":"https://api.github.com/repos/46bit/servo/assignees{/user}","branches_url":"https://api.github.com/repos/46bit/servo/branches{/branch}","tags_url":"https://api.github.com/repos/46bit/servo/tags","blobs_url":"https://api.github.com/repos/46bit/servo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/46bit/servo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/46bit/servo/git/refs{/sha}","trees_url":"https://api.github.com/repos/46bit/servo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/46bit/servo/statuses/{sha}","languages_url":"https://api.github.com/repos/46bit/servo/languages","stargazers_url":"https://api.github.com/repos/46bit/servo/stargazers","contributors_url":"https://api.github.com/repos/46bit/servo/contributors","subscribers_url":"https://api.github.com/repos/46bit/servo/subscribers","subscription_url":"https://api.github.com/repos/46bit/servo/subscription","commits_url":"https://api.github.com/repos/46bit/servo/commits{/sha}","git_commits_url":"https://api.github.com/repos/46bit/servo/git/commits{/sha}","comments_url":"https://api.github.com/repos/46bit/servo/comments{/number}","issue_comment_url":"https://api.github.com/repos/46bit/servo/issues/comments{/number}","contents_url":"https://api.github.com/repos/46bit/servo/contents/{+path}","compare_url":"https://api.github.com/repos/46bit/servo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/46bit/servo/merges","archive_url":"https://api.github.com/repos/46bit/servo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/46bit/servo/downloads","issues_url":"https://api.github.com/repos/46bit/servo/issues{/number}","pulls_url":"https://api.github.com/repos/46bit/servo/pulls{/number}","milestones_url":"https://api.github.com/repos/46bit/servo/milestones{/number}","notifications_url":"https://api.github.com/repos/46bit/servo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/46bit/servo/labels{/name}","releases_url":"https://api.github.com/repos/46bit/servo/releases{/id}","deployments_url":"https://api.github.com/repos/46bit/servo/deployments","created_at":"2016-11-30T05:23:16Z","updated_at":"2016-11-30T03:37:32Z","pushed_at":"2016-11-30T05:46:14Z","git_url":"git://github.com/46bit/servo.git","ssh_url":"git@github.com:46bit/servo.git","clone_url":"https://github.com/46bit/servo.git","svn_url":"https://github.com/46bit/servo","homepage":"https://servo.org/","size":315591,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"servo:master","ref":"master","sha":"f159b5cb1028bf4d2f75b0b48055fe19a8032f8e","user":{"login":"servo","id":2566135,"avatar_url":"https://avatars.githubusercontent.com/u/2566135?v=3","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"repo":{"id":3390243,"name":"servo","full_name":"servo/servo","owner":{"login":"servo","id":2566135,"avatar_url":"https://avatars.githubusercontent.com/u/2566135?v=3","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/servo/servo","description":"The Servo Browser Engine","fork":false,"url":"https://api.github.com/repos/servo/servo","forks_url":"https://api.github.com/repos/servo/servo/forks","keys_url":"https://api.github.com/repos/servo/servo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/servo/servo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/servo/servo/teams","hooks_url":"https://api.github.com/repos/servo/servo/hooks","issue_events_url":"https://api.github.com/repos/servo/servo/issues/events{/number}","events_url":"https://api.github.com/repos/servo/servo/events","assignees_url":"https://api.github.com/repos/servo/servo/assignees{/user}","branches_url":"https://api.github.com/repos/servo/servo/branches{/branch}","tags_url":"https://api.github.com/repos/servo/servo/tags","blobs_url":"https://api.github.com/repos/servo/servo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/servo/servo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/servo/servo/git/refs{/sha}","trees_url":"https://api.github.com/repos/servo/servo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/servo/servo/statuses/{sha}","languages_url":"https://api.github.com/repos/servo/servo/languages","stargazers_url":"https://api.github.com/repos/servo/servo/stargazers","contributors_url":"https://api.github.com/repos/servo/servo/contributors","subscribers_url":"https://api.github.com/repos/servo/servo/subscribers","subscription_url":"https://api.github.com/repos/servo/servo/subscription","commits_url":"https://api.github.com/repos/servo/servo/commits{/sha}","git_commits_url":"https://api.github.com/repos/servo/servo/git/commits{/sha}","comments_url":"https://api.github.com/repos/servo/servo/comments{/number}","issue_comment_url":"https://api.github.com/repos/servo/servo/issues/comments{/number}","contents_url":"https://api.github.com/repos/servo/servo/contents/{+path}","compare_url":"https://api.github.com/repos/servo/servo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/servo/servo/merges","archive_url":"https://api.github.com/repos/servo/servo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/servo/servo/downloads","issues_url":"https://api.github.com/repos/servo/servo/issues{/number}","pulls_url":"https://api.github.com/repos/servo/servo/pulls{/number}","milestones_url":"https://api.github.com/repos/servo/servo/milestones{/number}","notifications_url":"https://api.github.com/repos/servo/servo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/servo/servo/labels{/name}","releases_url":"https://api.github.com/repos/servo/servo/releases{/id}","deployments_url":"https://api.github.com/repos/servo/servo/deployments","created_at":"2012-02-08T19:07:25Z","updated_at":"2016-11-30T03:37:32Z","pushed_at":"2016-11-30T06:00:47Z","git_url":"git://github.com/servo/servo.git","ssh_url":"git@github.com:servo/servo.git","clone_url":"https://github.com/servo/servo.git","svn_url":"https://github.com/servo/servo","homepage":"https://servo.org/","size":315590,"stargazers_count":8341,"watchers_count":8341,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1374,"mirror_url":null,"open_issues_count":1924,"forks":1374,"open_issues":1924,"watchers":8341,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/servo/servo/pulls/14420"},"html":{"href":"https://github.com/servo/servo/pull/14420"},"issue":{"href":"https://api.github.com/repos/servo/servo/issues/14420"},"comments":{"href":"https://api.github.com/repos/servo/servo/issues/14420/comments"},"review_comments":{"href":"https://api.github.com/repos/servo/servo/pulls/14420/comments"},"review_comment":{"href":"https://api.github.com/repos/servo/servo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/servo/servo/pulls/14420/commits"},"statuses":{"href":"https://api.github.com/repos/servo/servo/statuses/6d64461f9465ee05939745488f2a8e5798b239af"}}}}
{"actor":{"display_login":"KiChjang"}}