{"action":"created","comment":{"url":"https://api.github.com/repos/projectatomic/docker/pulls/comments/66435693","id":66435693,"diff_hunk":"@@ -663,3 +664,55 @@ func (s *DockerRegistriesSuite) TestPushNeedsAuth(c *check.C) {\n \t\tc.Fatalf(\"Wanted %s, got %s\", expected, out)\n \t}\n }\n+\n+func (s *DockerRegistrySuite) TestPushWithSkipSchema2(c *check.C) {\n+\tc.Assert(s.d.StartWithBusybox(\"--skip-schema2-push=true\"), check.IsNil)\n+\n+\trepo := fmt.Sprintf(\"%s/runcom/busybox\", s.reg.url)\n+\tout, err := s.d.Cmd(\"tag\", \"busybox\", repo)\n+\tc.Assert(err, check.IsNil, check.Commentf(out))\n+\n+\tout, err = s.d.Cmd(\"push\", repo)\n+\tc.Assert(err, check.IsNil, check.Commentf(out))\n+\n+\tdigest1 := reference.DigestRegexp.FindString(out)\n+\tc.Assert(len(digest1), checker.GreaterThan, 0, check.Commentf(\"no digest found for pushed manifest\"))\n+\n+\tout, err = s.d.Cmd(\"pull\", repo+\"@\"+digest1)\n+\tc.Assert(err, check.IsNil, check.Commentf(out))\n+\n+\tout, err = s.d.Cmd(\"rmi\", \"-f\", repo+\"@\"+digest1)\n+\tc.Assert(err, check.IsNil, check.Commentf(out))\n+\n+\tc.Assert(s.d.Restart(\"--skip-schema2-push=false\"), check.IsNil)","path":"integration-cli/docker_cli_push_test.go","position":null,"original_position":32,"commit_id":"b0386995bfaa6414f6d4f48295298509db181b70","original_commit_id":"ac956e685f2482781c3fcdfbdd7f96fdbf6ef967","user":{"login":"runcom","id":849915,"avatar_url":"https://avatars.githubusercontent.com/u/849915?v=3","gravatar_id":"","url":"https://api.github.com/users/runcom","html_url":"https://github.com/runcom","followers_url":"https://api.github.com/users/runcom/followers","following_url":"https://api.github.com/users/runcom/following{/other_user}","gists_url":"https://api.github.com/users/runcom/gists{/gist_id}","starred_url":"https://api.github.com/users/runcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/runcom/subscriptions","organizations_url":"https://api.github.com/users/runcom/orgs","repos_url":"https://api.github.com/users/runcom/repos","events_url":"https://api.github.com/users/runcom/events{/privacy}","received_events_url":"https://api.github.com/users/runcom/received_events","type":"User","site_admin":false},"body":"fixed","created_at":"2016-06-09T13:03:00Z","updated_at":"2016-06-09T13:03:00Z","html_url":"https://github.com/projectatomic/docker/pull/169#discussion_r66435693","pull_request_url":"https://api.github.com/repos/projectatomic/docker/pulls/169","_links":{"self":{"href":"https://api.github.com/repos/projectatomic/docker/pulls/comments/66435693"},"html":{"href":"https://github.com/projectatomic/docker/pull/169#discussion_r66435693"},"pull_request":{"href":"https://api.github.com/repos/projectatomic/docker/pulls/169"}}},"pull_request":{"url":"https://api.github.com/repos/projectatomic/docker/pulls/169","id":73174050,"html_url":"https://github.com/projectatomic/docker/pull/169","diff_url":"https://github.com/projectatomic/docker/pull/169.diff","patch_url":"https://github.com/projectatomic/docker/pull/169.patch","issue_url":"https://api.github.com/repos/projectatomic/docker/issues/169","number":169,"state":"open","locked":false,"title":"Allow to skip manifest schema V2 push [rhel7-1.10.3]","user":{"login":"runcom","id":849915,"avatar_url":"https://avatars.githubusercontent.com/u/849915?v=3","gravatar_id":"","url":"https://api.github.com/users/runcom","html_url":"https://github.com/runcom","followers_url":"https://api.github.com/users/runcom/followers","following_url":"https://api.github.com/users/runcom/following{/other_user}","gists_url":"https://api.github.com/users/runcom/gists{/gist_id}","starred_url":"https://api.github.com/users/runcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/runcom/subscriptions","organizations_url":"https://api.github.com/users/runcom/orgs","repos_url":"https://api.github.com/users/runcom/repos","events_url":"https://api.github.com/users/runcom/events{/privacy}","received_events_url":"https://api.github.com/users/runcom/received_events","type":"User","site_admin":false},"body":"Trello card: https://trello.com/c/CJiUnVUm/136-3-docker-1-10-push-force-schema1-manifest-via-daemon-flag\r\n\r\n@miminar @smarterclayton @rhatdan PTAL\r\n\r\nSigned-off-by: Antonio Murdaca <runcom@redhat.com>","created_at":"2016-06-09T08:24:17Z","updated_at":"2016-06-09T13:03:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d743a47d079fae7f7a34fea825abc07ccd88a4b5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/projectatomic/docker/pulls/169/commits","review_comments_url":"https://api.github.com/repos/projectatomic/docker/pulls/169/comments","review_comment_url":"https://api.github.com/repos/projectatomic/docker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/projectatomic/docker/issues/169/comments","statuses_url":"https://api.github.com/repos/projectatomic/docker/statuses/b0386995bfaa6414f6d4f48295298509db181b70","head":{"label":"runcom:skip-schemav2-push","ref":"skip-schemav2-push","sha":"b0386995bfaa6414f6d4f48295298509db181b70","user":{"login":"runcom","id":849915,"avatar_url":"https://avatars.githubusercontent.com/u/849915?v=3","gravatar_id":"","url":"https://api.github.com/users/runcom","html_url":"https://github.com/runcom","followers_url":"https://api.github.com/users/runcom/followers","following_url":"https://api.github.com/users/runcom/following{/other_user}","gists_url":"https://api.github.com/users/runcom/gists{/gist_id}","starred_url":"https://api.github.com/users/runcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/runcom/subscriptions","organizations_url":"https://api.github.com/users/runcom/orgs","repos_url":"https://api.github.com/users/runcom/repos","events_url":"https://api.github.com/users/runcom/events{/privacy}","received_events_url":"https://api.github.com/users/runcom/received_events","type":"User","site_admin":false},"repo":{"id":32636176,"name":"docker","full_name":"runcom/docker","owner":{"login":"runcom","id":849915,"avatar_url":"https://avatars.githubusercontent.com/u/849915?v=3","gravatar_id":"","url":"https://api.github.com/users/runcom","html_url":"https://github.com/runcom","followers_url":"https://api.github.com/users/runcom/followers","following_url":"https://api.github.com/users/runcom/following{/other_user}","gists_url":"https://api.github.com/users/runcom/gists{/gist_id}","starred_url":"https://api.github.com/users/runcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/runcom/subscriptions","organizations_url":"https://api.github.com/users/runcom/orgs","repos_url":"https://api.github.com/users/runcom/repos","events_url":"https://api.github.com/users/runcom/events{/privacy}","received_events_url":"https://api.github.com/users/runcom/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/runcom/docker","description":"Docker - the open-source application container engine","fork":true,"url":"https://api.github.com/repos/runcom/docker","forks_url":"https://api.github.com/repos/runcom/docker/forks","keys_url":"https://api.github.com/repos/runcom/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/runcom/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/runcom/docker/teams","hooks_url":"https://api.github.com/repos/runcom/docker/hooks","issue_events_url":"https://api.github.com/repos/runcom/docker/issues/events{/number}","events_url":"https://api.github.com/repos/runcom/docker/events","assignees_url":"https://api.github.com/repos/runcom/docker/assignees{/user}","branches_url":"https://api.github.com/repos/runcom/docker/branches{/branch}","tags_url":"https://api.github.com/repos/runcom/docker/tags","blobs_url":"https://api.github.com/repos/runcom/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/runcom/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/runcom/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/runcom/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/runcom/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/runcom/docker/languages","stargazers_url":"https://api.github.com/repos/runcom/docker/stargazers","contributors_url":"https://api.github.com/repos/runcom/docker/contributors","subscribers_url":"https://api.github.com/repos/runcom/docker/subscribers","subscription_url":"https://api.github.com/repos/runcom/docker/subscription","commits_url":"https://api.github.com/repos/runcom/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/runcom/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/runcom/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/runcom/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/runcom/docker/contents/{+path}","compare_url":"https://api.github.com/repos/runcom/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/runcom/docker/merges","archive_url":"https://api.github.com/repos/runcom/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/runcom/docker/downloads","issues_url":"https://api.github.com/repos/runcom/docker/issues{/number}","pulls_url":"https://api.github.com/repos/runcom/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/runcom/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/runcom/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/runcom/docker/labels{/name}","releases_url":"https://api.github.com/repos/runcom/docker/releases{/id}","deployments_url":"https://api.github.com/repos/runcom/docker/deployments","created_at":"2015-03-21T14:55:26Z","updated_at":"2016-01-11T15:28:57Z","pushed_at":"2016-06-09T13:02:57Z","git_url":"git://github.com/runcom/docker.git","ssh_url":"git@github.com:runcom/docker.git","clone_url":"https://github.com/runcom/docker.git","svn_url":"https://github.com/runcom/docker","homepage":"http://www.docker.com","size":91814,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"projectatomic:rhel7-1.10.3","ref":"rhel7-1.10.3","sha":"a46c31af70ca8d15521e312ad9ef7085cfe2fd3f","user":{"login":"projectatomic","id":6852258,"avatar_url":"https://avatars.githubusercontent.com/u/6852258?v=3","gravatar_id":"","url":"https://api.github.com/users/projectatomic","html_url":"https://github.com/projectatomic","followers_url":"https://api.github.com/users/projectatomic/followers","following_url":"https://api.github.com/users/projectatomic/following{/other_user}","gists_url":"https://api.github.com/users/projectatomic/gists{/gist_id}","starred_url":"https://api.github.com/users/projectatomic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectatomic/subscriptions","organizations_url":"https://api.github.com/users/projectatomic/orgs","repos_url":"https://api.github.com/users/projectatomic/repos","events_url":"https://api.github.com/users/projectatomic/events{/privacy}","received_events_url":"https://api.github.com/users/projectatomic/received_events","type":"Organization","site_admin":false},"repo":{"id":43688127,"name":"docker","full_name":"projectatomic/docker","owner":{"login":"projectatomic","id":6852258,"avatar_url":"https://avatars.githubusercontent.com/u/6852258?v=3","gravatar_id":"","url":"https://api.github.com/users/projectatomic","html_url":"https://github.com/projectatomic","followers_url":"https://api.github.com/users/projectatomic/followers","following_url":"https://api.github.com/users/projectatomic/following{/other_user}","gists_url":"https://api.github.com/users/projectatomic/gists{/gist_id}","starred_url":"https://api.github.com/users/projectatomic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectatomic/subscriptions","organizations_url":"https://api.github.com/users/projectatomic/orgs","repos_url":"https://api.github.com/users/projectatomic/repos","events_url":"https://api.github.com/users/projectatomic/events{/privacy}","received_events_url":"https://api.github.com/users/projectatomic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/projectatomic/docker","description":"Docker - the open-source application container engine","fork":true,"url":"https://api.github.com/repos/projectatomic/docker","forks_url":"https://api.github.com/repos/projectatomic/docker/forks","keys_url":"https://api.github.com/repos/projectatomic/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/projectatomic/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/projectatomic/docker/teams","hooks_url":"https://api.github.com/repos/projectatomic/docker/hooks","issue_events_url":"https://api.github.com/repos/projectatomic/docker/issues/events{/number}","events_url":"https://api.github.com/repos/projectatomic/docker/events","assignees_url":"https://api.github.com/repos/projectatomic/docker/assignees{/user}","branches_url":"https://api.github.com/repos/projectatomic/docker/branches{/branch}","tags_url":"https://api.github.com/repos/projectatomic/docker/tags","blobs_url":"https://api.github.com/repos/projectatomic/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/projectatomic/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/projectatomic/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/projectatomic/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/projectatomic/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/projectatomic/docker/languages","stargazers_url":"https://api.github.com/repos/projectatomic/docker/stargazers","contributors_url":"https://api.github.com/repos/projectatomic/docker/contributors","subscribers_url":"https://api.github.com/repos/projectatomic/docker/subscribers","subscription_url":"https://api.github.com/repos/projectatomic/docker/subscription","commits_url":"https://api.github.com/repos/projectatomic/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/projectatomic/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/projectatomic/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/projectatomic/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/projectatomic/docker/contents/{+path}","compare_url":"https://api.github.com/repos/projectatomic/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/projectatomic/docker/merges","archive_url":"https://api.github.com/repos/projectatomic/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/projectatomic/docker/downloads","issues_url":"https://api.github.com/repos/projectatomic/docker/issues{/number}","pulls_url":"https://api.github.com/repos/projectatomic/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/projectatomic/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/projectatomic/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/projectatomic/docker/labels{/name}","releases_url":"https://api.github.com/repos/projectatomic/docker/releases{/id}","deployments_url":"https://api.github.com/repos/projectatomic/docker/deployments","created_at":"2015-10-05T14:09:17Z","updated_at":"2016-05-28T09:14:10Z","pushed_at":"2016-06-09T13:02:58Z","git_url":"git://github.com/projectatomic/docker.git","ssh_url":"git@github.com:projectatomic/docker.git","clone_url":"https://github.com/projectatomic/docker.git","svn_url":"https://github.com/projectatomic/docker","homepage":"http://www.docker.com","size":93210,"stargazers_count":9,"watchers_count":9,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":4,"forks":7,"open_issues":4,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/projectatomic/docker/pulls/169"},"html":{"href":"https://github.com/projectatomic/docker/pull/169"},"issue":{"href":"https://api.github.com/repos/projectatomic/docker/issues/169"},"comments":{"href":"https://api.github.com/repos/projectatomic/docker/issues/169/comments"},"review_comments":{"href":"https://api.github.com/repos/projectatomic/docker/pulls/169/comments"},"review_comment":{"href":"https://api.github.com/repos/projectatomic/docker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/projectatomic/docker/pulls/169/commits"},"statuses":{"href":"https://api.github.com/repos/projectatomic/docker/statuses/b0386995bfaa6414f6d4f48295298509db181b70"}}}}
{"actor":{"display_login":"runcom"}}