{"action":"created","comment":{"url":"https://api.github.com/repos/ripple/rippled/pulls/comments/61353747","id":61353747,"diff_hunk":"@@ -40,20 +40,21 @@ namespace ripple {\n static uint8_t SNTPQueryData[48] =\n { 0x1B, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 };\n \n+using namespace std::chrono_literals;\n // NTP query frequency - 4 minutes\n-#define NTP_QUERY_FREQUENCY     (4 * 60)\n+auto constexpr NTP_QUERY_FREQUENCY = 4min;\n \n // NTP minimum interval to query same servers - 3 minutes\n-#define NTP_MIN_QUERY           (3 * 60)\n+auto constexpr  NTP_MIN_QUERY = 3min;","path":"src/ripple/core/impl/SNTPClock.cpp","position":11,"original_position":11,"commit_id":"9bdf92698899587c069012eb1bdcba890d57c630","original_commit_id":"9bdf92698899587c069012eb1bdcba890d57c630","user":{"login":"vinniefalco","id":1503976,"avatar_url":"https://avatars.githubusercontent.com/u/1503976?v=3","gravatar_id":"","url":"https://api.github.com/users/vinniefalco","html_url":"https://github.com/vinniefalco","followers_url":"https://api.github.com/users/vinniefalco/followers","following_url":"https://api.github.com/users/vinniefalco/following{/other_user}","gists_url":"https://api.github.com/users/vinniefalco/gists{/gist_id}","starred_url":"https://api.github.com/users/vinniefalco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vinniefalco/subscriptions","organizations_url":"https://api.github.com/users/vinniefalco/orgs","repos_url":"https://api.github.com/users/vinniefalco/repos","events_url":"https://api.github.com/users/vinniefalco/events{/privacy}","received_events_url":"https://api.github.com/users/vinniefalco/received_events","type":"User","site_admin":false},"body":"That's pretty cool actually\r\n","created_at":"2016-04-27T23:26:18Z","updated_at":"2016-04-27T23:26:18Z","html_url":"https://github.com/ripple/rippled/pull/1666#discussion_r61353747","pull_request_url":"https://api.github.com/repos/ripple/rippled/pulls/1666","_links":{"self":{"href":"https://api.github.com/repos/ripple/rippled/pulls/comments/61353747"},"html":{"href":"https://github.com/ripple/rippled/pull/1666#discussion_r61353747"},"pull_request":{"href":"https://api.github.com/repos/ripple/rippled/pulls/1666"}}},"pull_request":{"url":"https://api.github.com/repos/ripple/rippled/pulls/1666","id":67979320,"html_url":"https://github.com/ripple/rippled/pull/1666","diff_url":"https://github.com/ripple/rippled/pull/1666.diff","patch_url":"https://github.com/ripple/rippled/pull/1666.patch","issue_url":"https://api.github.com/repos/ripple/rippled/issues/1666","number":1666,"state":"open","locked":false,"title":"Migrate off of posix_time and most uses of C time_t.","user":{"login":"HowardHinnant","id":6708789,"avatar_url":"https://avatars.githubusercontent.com/u/6708789?v=3","gravatar_id":"","url":"https://api.github.com/users/HowardHinnant","html_url":"https://github.com/HowardHinnant","followers_url":"https://api.github.com/users/HowardHinnant/followers","following_url":"https://api.github.com/users/HowardHinnant/following{/other_user}","gists_url":"https://api.github.com/users/HowardHinnant/gists{/gist_id}","starred_url":"https://api.github.com/users/HowardHinnant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HowardHinnant/subscriptions","organizations_url":"https://api.github.com/users/HowardHinnant/orgs","repos_url":"https://api.github.com/users/HowardHinnant/repos","events_url":"https://api.github.com/users/HowardHinnant/events{/privacy}","received_events_url":"https://api.github.com/users/HowardHinnant/received_events","type":"User","site_admin":false},"body":"This is just a cleanup P/R.  There should be no change in functionality.  It gets rid of some code we no longer have to maintain.  And it eliminates dependence on `boost::posix_time`.  There is one subtle bug fix in src/ripple/server/impl/JSONRPCUtil.cpp that gets rid of using the non-thread-safe `gmtime` in favor of non-std replacements.\r\n\r\n@ volunteers. :-)\r\n\r\n@vinniefalco ","created_at":"2016-04-27T00:27:18Z","updated_at":"2016-04-27T23:26:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5cf571582e3217469de5dcc969854ccb183e7bf6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ripple/rippled/pulls/1666/commits","review_comments_url":"https://api.github.com/repos/ripple/rippled/pulls/1666/comments","review_comment_url":"https://api.github.com/repos/ripple/rippled/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ripple/rippled/issues/1666/comments","statuses_url":"https://api.github.com/repos/ripple/rippled/statuses/9bdf92698899587c069012eb1bdcba890d57c630","head":{"label":"HowardHinnant:ptime","ref":"ptime","sha":"9bdf92698899587c069012eb1bdcba890d57c630","user":{"login":"HowardHinnant","id":6708789,"avatar_url":"https://avatars.githubusercontent.com/u/6708789?v=3","gravatar_id":"","url":"https://api.github.com/users/HowardHinnant","html_url":"https://github.com/HowardHinnant","followers_url":"https://api.github.com/users/HowardHinnant/followers","following_url":"https://api.github.com/users/HowardHinnant/following{/other_user}","gists_url":"https://api.github.com/users/HowardHinnant/gists{/gist_id}","starred_url":"https://api.github.com/users/HowardHinnant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HowardHinnant/subscriptions","organizations_url":"https://api.github.com/users/HowardHinnant/orgs","repos_url":"https://api.github.com/users/HowardHinnant/repos","events_url":"https://api.github.com/users/HowardHinnant/events{/privacy}","received_events_url":"https://api.github.com/users/HowardHinnant/received_events","type":"User","site_admin":false},"repo":{"id":16925449,"name":"rippled","full_name":"HowardHinnant/rippled","owner":{"login":"HowardHinnant","id":6708789,"avatar_url":"https://avatars.githubusercontent.com/u/6708789?v=3","gravatar_id":"","url":"https://api.github.com/users/HowardHinnant","html_url":"https://github.com/HowardHinnant","followers_url":"https://api.github.com/users/HowardHinnant/followers","following_url":"https://api.github.com/users/HowardHinnant/following{/other_user}","gists_url":"https://api.github.com/users/HowardHinnant/gists{/gist_id}","starred_url":"https://api.github.com/users/HowardHinnant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HowardHinnant/subscriptions","organizations_url":"https://api.github.com/users/HowardHinnant/orgs","repos_url":"https://api.github.com/users/HowardHinnant/repos","events_url":"https://api.github.com/users/HowardHinnant/events{/privacy}","received_events_url":"https://api.github.com/users/HowardHinnant/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/HowardHinnant/rippled","description":"Ripple peer-to-peer network daemon","fork":true,"url":"https://api.github.com/repos/HowardHinnant/rippled","forks_url":"https://api.github.com/repos/HowardHinnant/rippled/forks","keys_url":"https://api.github.com/repos/HowardHinnant/rippled/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HowardHinnant/rippled/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HowardHinnant/rippled/teams","hooks_url":"https://api.github.com/repos/HowardHinnant/rippled/hooks","issue_events_url":"https://api.github.com/repos/HowardHinnant/rippled/issues/events{/number}","events_url":"https://api.github.com/repos/HowardHinnant/rippled/events","assignees_url":"https://api.github.com/repos/HowardHinnant/rippled/assignees{/user}","branches_url":"https://api.github.com/repos/HowardHinnant/rippled/branches{/branch}","tags_url":"https://api.github.com/repos/HowardHinnant/rippled/tags","blobs_url":"https://api.github.com/repos/HowardHinnant/rippled/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HowardHinnant/rippled/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HowardHinnant/rippled/git/refs{/sha}","trees_url":"https://api.github.com/repos/HowardHinnant/rippled/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HowardHinnant/rippled/statuses/{sha}","languages_url":"https://api.github.com/repos/HowardHinnant/rippled/languages","stargazers_url":"https://api.github.com/repos/HowardHinnant/rippled/stargazers","contributors_url":"https://api.github.com/repos/HowardHinnant/rippled/contributors","subscribers_url":"https://api.github.com/repos/HowardHinnant/rippled/subscribers","subscription_url":"https://api.github.com/repos/HowardHinnant/rippled/subscription","commits_url":"https://api.github.com/repos/HowardHinnant/rippled/commits{/sha}","git_commits_url":"https://api.github.com/repos/HowardHinnant/rippled/git/commits{/sha}","comments_url":"https://api.github.com/repos/HowardHinnant/rippled/comments{/number}","issue_comment_url":"https://api.github.com/repos/HowardHinnant/rippled/issues/comments{/number}","contents_url":"https://api.github.com/repos/HowardHinnant/rippled/contents/{+path}","compare_url":"https://api.github.com/repos/HowardHinnant/rippled/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HowardHinnant/rippled/merges","archive_url":"https://api.github.com/repos/HowardHinnant/rippled/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HowardHinnant/rippled/downloads","issues_url":"https://api.github.com/repos/HowardHinnant/rippled/issues{/number}","pulls_url":"https://api.github.com/repos/HowardHinnant/rippled/pulls{/number}","milestones_url":"https://api.github.com/repos/HowardHinnant/rippled/milestones{/number}","notifications_url":"https://api.github.com/repos/HowardHinnant/rippled/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HowardHinnant/rippled/labels{/name}","releases_url":"https://api.github.com/repos/HowardHinnant/rippled/releases{/id}","deployments_url":"https://api.github.com/repos/HowardHinnant/rippled/deployments","created_at":"2014-02-17T20:21:56Z","updated_at":"2015-04-07T16:53:12Z","pushed_at":"2016-04-26T23:33:20Z","git_url":"git://github.com/HowardHinnant/rippled.git","ssh_url":"git@github.com:HowardHinnant/rippled.git","clone_url":"https://github.com/HowardHinnant/rippled.git","svn_url":"https://github.com/HowardHinnant/rippled","homepage":"https://ripple.com","size":64025,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"ripple:develop","ref":"develop","sha":"1c8c3207fe6a29dfa67575503ac489ae516063de","user":{"login":"ripple","id":3165523,"avatar_url":"https://avatars.githubusercontent.com/u/3165523?v=3","gravatar_id":"","url":"https://api.github.com/users/ripple","html_url":"https://github.com/ripple","followers_url":"https://api.github.com/users/ripple/followers","following_url":"https://api.github.com/users/ripple/following{/other_user}","gists_url":"https://api.github.com/users/ripple/gists{/gist_id}","starred_url":"https://api.github.com/users/ripple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ripple/subscriptions","organizations_url":"https://api.github.com/users/ripple/orgs","repos_url":"https://api.github.com/users/ripple/repos","events_url":"https://api.github.com/users/ripple/events{/privacy}","received_events_url":"https://api.github.com/users/ripple/received_events","type":"Organization","site_admin":false},"repo":{"id":2724167,"name":"rippled","full_name":"ripple/rippled","owner":{"login":"ripple","id":3165523,"avatar_url":"https://avatars.githubusercontent.com/u/3165523?v=3","gravatar_id":"","url":"https://api.github.com/users/ripple","html_url":"https://github.com/ripple","followers_url":"https://api.github.com/users/ripple/followers","following_url":"https://api.github.com/users/ripple/following{/other_user}","gists_url":"https://api.github.com/users/ripple/gists{/gist_id}","starred_url":"https://api.github.com/users/ripple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ripple/subscriptions","organizations_url":"https://api.github.com/users/ripple/orgs","repos_url":"https://api.github.com/users/ripple/repos","events_url":"https://api.github.com/users/ripple/events{/privacy}","received_events_url":"https://api.github.com/users/ripple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ripple/rippled","description":"Ripple peer-to-peer network daemon","fork":false,"url":"https://api.github.com/repos/ripple/rippled","forks_url":"https://api.github.com/repos/ripple/rippled/forks","keys_url":"https://api.github.com/repos/ripple/rippled/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ripple/rippled/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ripple/rippled/teams","hooks_url":"https://api.github.com/repos/ripple/rippled/hooks","issue_events_url":"https://api.github.com/repos/ripple/rippled/issues/events{/number}","events_url":"https://api.github.com/repos/ripple/rippled/events","assignees_url":"https://api.github.com/repos/ripple/rippled/assignees{/user}","branches_url":"https://api.github.com/repos/ripple/rippled/branches{/branch}","tags_url":"https://api.github.com/repos/ripple/rippled/tags","blobs_url":"https://api.github.com/repos/ripple/rippled/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ripple/rippled/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ripple/rippled/git/refs{/sha}","trees_url":"https://api.github.com/repos/ripple/rippled/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ripple/rippled/statuses/{sha}","languages_url":"https://api.github.com/repos/ripple/rippled/languages","stargazers_url":"https://api.github.com/repos/ripple/rippled/stargazers","contributors_url":"https://api.github.com/repos/ripple/rippled/contributors","subscribers_url":"https://api.github.com/repos/ripple/rippled/subscribers","subscription_url":"https://api.github.com/repos/ripple/rippled/subscription","commits_url":"https://api.github.com/repos/ripple/rippled/commits{/sha}","git_commits_url":"https://api.github.com/repos/ripple/rippled/git/commits{/sha}","comments_url":"https://api.github.com/repos/ripple/rippled/comments{/number}","issue_comment_url":"https://api.github.com/repos/ripple/rippled/issues/comments{/number}","contents_url":"https://api.github.com/repos/ripple/rippled/contents/{+path}","compare_url":"https://api.github.com/repos/ripple/rippled/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ripple/rippled/merges","archive_url":"https://api.github.com/repos/ripple/rippled/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ripple/rippled/downloads","issues_url":"https://api.github.com/repos/ripple/rippled/issues{/number}","pulls_url":"https://api.github.com/repos/ripple/rippled/pulls{/number}","milestones_url":"https://api.github.com/repos/ripple/rippled/milestones{/number}","notifications_url":"https://api.github.com/repos/ripple/rippled/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ripple/rippled/labels{/name}","releases_url":"https://api.github.com/repos/ripple/rippled/releases{/id}","deployments_url":"https://api.github.com/repos/ripple/rippled/deployments","created_at":"2011-11-07T04:40:15Z","updated_at":"2016-04-27T16:25:37Z","pushed_at":"2016-04-27T22:23:16Z","git_url":"git://github.com/ripple/rippled.git","ssh_url":"git@github.com:ripple/rippled.git","clone_url":"https://github.com/ripple/rippled.git","svn_url":"https://github.com/ripple/rippled","homepage":"https://ripple.com","size":111401,"stargazers_count":1087,"watchers_count":1087,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":329,"mirror_url":null,"open_issues_count":117,"forks":329,"open_issues":117,"watchers":1087,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ripple/rippled/pulls/1666"},"html":{"href":"https://github.com/ripple/rippled/pull/1666"},"issue":{"href":"https://api.github.com/repos/ripple/rippled/issues/1666"},"comments":{"href":"https://api.github.com/repos/ripple/rippled/issues/1666/comments"},"review_comments":{"href":"https://api.github.com/repos/ripple/rippled/pulls/1666/comments"},"review_comment":{"href":"https://api.github.com/repos/ripple/rippled/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ripple/rippled/pulls/1666/commits"},"statuses":{"href":"https://api.github.com/repos/ripple/rippled/statuses/9bdf92698899587c069012eb1bdcba890d57c630"}}}}