{"action":"created","issue":{"url":"https://api.github.com/repos/behance/focss/issues/37","repository_url":"https://api.github.com/repos/behance/focss","labels_url":"https://api.github.com/repos/behance/focss/issues/37/labels{/name}","comments_url":"https://api.github.com/repos/behance/focss/issues/37/comments","events_url":"https://api.github.com/repos/behance/focss/issues/37/events","html_url":"https://github.com/behance/focss/pull/37","id":167890551,"number":37,"title":"Node compatibility","user":{"login":"kaicataldo","id":7041728,"avatar_url":"https://avatars.githubusercontent.com/u/7041728?v=3","gravatar_id":"","url":"https://api.github.com/users/kaicataldo","html_url":"https://github.com/kaicataldo","followers_url":"https://api.github.com/users/kaicataldo/followers","following_url":"https://api.github.com/users/kaicataldo/following{/other_user}","gists_url":"https://api.github.com/users/kaicataldo/gists{/gist_id}","starred_url":"https://api.github.com/users/kaicataldo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaicataldo/subscriptions","organizations_url":"https://api.github.com/users/kaicataldo/orgs","repos_url":"https://api.github.com/users/kaicataldo/repos","events_url":"https://api.github.com/users/kaicataldo/events{/privacy}","received_events_url":"https://api.github.com/users/kaicataldo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-07-27T15:57:16Z","updated_at":"2016-07-27T20:09:45Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/behance/focss/pulls/37","html_url":"https://github.com/behance/focss/pull/37","diff_url":"https://github.com/behance/focss/pull/37.diff","patch_url":"https://github.com/behance/focss/pull/37.patch"},"body":null},"comment":{"url":"https://api.github.com/repos/behance/focss/issues/comments/235704969","html_url":"https://github.com/behance/focss/pull/37#issuecomment-235704969","issue_url":"https://api.github.com/repos/behance/focss/issues/37","id":235704969,"user":{"login":"kaicataldo","id":7041728,"avatar_url":"https://avatars.githubusercontent.com/u/7041728?v=3","gravatar_id":"","url":"https://api.github.com/users/kaicataldo","html_url":"https://github.com/kaicataldo","followers_url":"https://api.github.com/users/kaicataldo/followers","following_url":"https://api.github.com/users/kaicataldo/following{/other_user}","gists_url":"https://api.github.com/users/kaicataldo/gists{/gist_id}","starred_url":"https://api.github.com/users/kaicataldo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaicataldo/subscriptions","organizations_url":"https://api.github.com/users/kaicataldo/orgs","repos_url":"https://api.github.com/users/kaicataldo/repos","events_url":"https://api.github.com/users/kaicataldo/events{/privacy}","received_events_url":"https://api.github.com/users/kaicataldo/received_events","type":"User","site_admin":false},"created_at":"2016-07-27T20:09:45Z","updated_at":"2016-07-27T20:09:45Z","body":"Okay, so rather than the null object pattern, I could also add a check into Engine like: \r\n\r\n```\r\nfunction hasDom() {\r\n  return typeof window !== 'undefined';\r\n}\r\n```\r\n\r\nThen I could use that for all the guards/working around DOM-reliant behavior, including bailing on `process` immediately if Focss doesn't have access to the DOM.\r\n\r\nTwo questions:\r\n * Thoughts on keeping the Style class? Or do you think that should all be inlined into the Engine? I like the separation (easier for me to reason about).\r\n * The other idea @Attamusc and I discussed was not auto-processing on insert when there is state, but that's a breaking change and I felt like that should be a separate issue if we decide to do it."}}
{"actor":{"display_login":"kaicataldo"}}