{"action":"created","issue":{"url":"https://api.github.com/repos/ceolter/ag-grid/issues/1005","repository_url":"https://api.github.com/repos/ceolter/ag-grid","labels_url":"https://api.github.com/repos/ceolter/ag-grid/issues/1005/labels{/name}","comments_url":"https://api.github.com/repos/ceolter/ag-grid/issues/1005/comments","events_url":"https://api.github.com/repos/ceolter/ag-grid/issues/1005/events","html_url":"https://github.com/ceolter/ag-grid/issues/1005","id":164437331,"number":1005,"title":"Request: leave params.value as it is in filterParams cellRenderer","user":{"login":"Mithras","id":2098029,"avatar_url":"https://avatars.githubusercontent.com/u/2098029?v=3","gravatar_id":"","url":"https://api.github.com/users/Mithras","html_url":"https://github.com/Mithras","followers_url":"https://api.github.com/users/Mithras/followers","following_url":"https://api.github.com/users/Mithras/following{/other_user}","gists_url":"https://api.github.com/users/Mithras/gists{/gist_id}","starred_url":"https://api.github.com/users/Mithras/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mithras/subscriptions","organizations_url":"https://api.github.com/users/Mithras/orgs","repos_url":"https://api.github.com/users/Mithras/repos","events_url":"https://api.github.com/users/Mithras/events{/privacy}","received_events_url":"https://api.github.com/users/Mithras/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-07-08T00:38:40Z","updated_at":"2016-07-08T02:26:16Z","closed_at":null,"body":"At the moment params.value is always string in filterParams cellRenderer. That means that you hardly ever can reuse cellRenderer. For example:\r\n```\r\nconst colDef: ColDef = {\r\n    field: \"booleanField\",\r\n    cellRenderer: (params: { value: boolean }) => params.value ? \"Yes\" : \"No\",\r\n    filterParams: { cellRenderer: (params: { value: string }) => params.value === \"true\" ? \"Yes\" : \"No\" }\r\n};\r\n```\r\nand that's how I want it to to be:\r\n```\r\nconst cellRenderer = (params: { value: boolean }) => params.value ? \"Yes\" : \"No\";\r\nconst colDef: ColDef = {\r\n    field: \"booleanField\",\r\n    cellRenderer: cellRenderer,\r\n    filterParams: { cellRenderer: cellRenderer }\r\n};\r\n```\r\n\r\nUsing valueGetter instead is not the same because the column might be editable or whatever."},"comment":{"url":"https://api.github.com/repos/ceolter/ag-grid/issues/comments/231260436","html_url":"https://github.com/ceolter/ag-grid/issues/1005#issuecomment-231260436","issue_url":"https://api.github.com/repos/ceolter/ag-grid/issues/1005","id":231260436,"user":{"login":"tloten","id":19631132,"avatar_url":"https://avatars.githubusercontent.com/u/19631132?v=3","gravatar_id":"","url":"https://api.github.com/users/tloten","html_url":"https://github.com/tloten","followers_url":"https://api.github.com/users/tloten/followers","following_url":"https://api.github.com/users/tloten/following{/other_user}","gists_url":"https://api.github.com/users/tloten/gists{/gist_id}","starred_url":"https://api.github.com/users/tloten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tloten/subscriptions","organizations_url":"https://api.github.com/users/tloten/orgs","repos_url":"https://api.github.com/users/tloten/repos","events_url":"https://api.github.com/users/tloten/events{/privacy}","received_events_url":"https://api.github.com/users/tloten/received_events","type":"User","site_admin":false},"created_at":"2016-07-08T02:26:16Z","updated_at":"2016-07-08T02:26:16Z","body":"This has been bugging me for a while too.\r\nAnother problem with it being a string is that sorting (of the items in the set-filter) is done based on alphanumeric sorting. So numbers will appear like:\r\n`0\r\n1\r\n10\r\n2\r\n20\r\n3`"}}
{"actor":{"display_login":"tloten"}}