{"push_id":1395612673,"size":5,"distinct_size":5,"ref":"refs/heads/serve-favicon","head":"40c05f4d65bf6a9bc20e46ae25ef2e5612abc275","before":"6bdcb9885f08810a312384a0d882fea54284eb50","commits":[{"sha":"48387e4ffdb91e625b69d1707fe08e71b956ccf5","author":{"name":"Katharina Irrgang","email":"12b0b00dd3ffbbbc5cbc62daa47f60debaf19ead@googlemail.com"},"message":"🎨  tidy up static id (owner, internal, external) usages (#7675)\n\nrefs #7494, refs #7495 \r\n\r\nThis PR is an extracted clean up feature of #7495.\r\nWe are using everywhere static id checks (userId === 0 or userId === 1).\r\nThis PR moves the static values into the Base model.\r\nThis makes it 1. way more readable and 2. we can change the id's in a central place.\r\n\r\nI changed the most important occurrences - no tests are touched (yet!).\r\n\r\nThe background is: when changing from auto increment id (number) to ObjectId's (string) we still need to support id 1 and 0, because Ghost relies on these two static id's.\r\nI would like to support using both: 0/1 as string and 0/1 as number.\r\n\r\n1 === owner/internal\r\n0 === external\r\n\r\nAnother important change:\r\nUser Model does not longer define the contextUser method, because i couldn't find a reason?\r\nI looked in Git history, see https://github.com/TryGhost/Ghost/commit/6e482751601b8d23b3a06aec890b79c92eaf4af2","distinct":true,"url":"https://api.github.com/repos/AileenCGN/Ghost/commits/48387e4ffdb91e625b69d1707fe08e71b956ccf5"},{"sha":"b48031fa0e37868eb231a36d5924075eadf1df1a","author":{"name":"Katharina Irrgang","email":"12b0b00dd3ffbbbc5cbc62daa47f60debaf19ead@googlemail.com"},"message":"🎨  unique constraint for permission and role name (#7674)\n\nrefs #7494,  refs #7495 \r\n\r\nI saw tests adding permissions and roles twice. (see screenshots)\r\nThat happened because the setup in the test was mis-used and there is no restriction for static resources to create duplicates.\r\nWith this PR i suggest to make name unique.","distinct":true,"url":"https://api.github.com/repos/AileenCGN/Ghost/commits/b48031fa0e37868eb231a36d5924075eadf1df1a"},{"sha":"6bad58672a716647de2a5e135a233b9c239ca4b4","author":{"name":"Aileen Nowak","email":"ec61a6cb7a401156cfde4ab2650b80834d9091d6@gmail.com"},"message":"first try on favicon\n\n[ci-skip]","distinct":true,"url":"https://api.github.com/repos/AileenCGN/Ghost/commits/6bad58672a716647de2a5e135a233b9c239ca4b4"},{"sha":"0fa149ff4936dab2eb184299095635f56f4e758e","author":{"name":"Aileen Nowak","email":"ec61a6cb7a401156cfde4ab2650b80834d9091d6@gmail.com"},"message":"get custom favicon","distinct":true,"url":"https://api.github.com/repos/AileenCGN/Ghost/commits/0fa149ff4936dab2eb184299095635f56f4e758e"},{"sha":"40c05f4d65bf6a9bc20e46ae25ef2e5612abc275","author":{"name":"Aileen Nowak","email":"ec61a6cb7a401156cfde4ab2650b80834d9091d6@gmail.com"},"message":"make it work","distinct":true,"url":"https://api.github.com/repos/AileenCGN/Ghost/commits/40c05f4d65bf6a9bc20e46ae25ef2e5612abc275"}]}
{"actor":{"display_login":"AileenCGN"}}