{"action":"closed","number":5414,"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/5414","id":60542681,"html_url":"https://github.com/nodejs/node/pull/5414","diff_url":"https://github.com/nodejs/node/pull/5414.diff","patch_url":"https://github.com/nodejs/node/pull/5414.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/5414","number":5414,"state":"closed","locked":false,"title":"doc: note util.isError() @@toStringTag limitations","user":{"login":"cjihrig","id":2512748,"avatar_url":"https://avatars.githubusercontent.com/u/2512748?v=3","gravatar_id":"","url":"https://api.github.com/users/cjihrig","html_url":"https://github.com/cjihrig","followers_url":"https://api.github.com/users/cjihrig/followers","following_url":"https://api.github.com/users/cjihrig/following{/other_user}","gists_url":"https://api.github.com/users/cjihrig/gists{/gist_id}","starred_url":"https://api.github.com/users/cjihrig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjihrig/subscriptions","organizations_url":"https://api.github.com/users/cjihrig/orgs","repos_url":"https://api.github.com/users/cjihrig/repos","events_url":"https://api.github.com/users/cjihrig/events{/privacy}","received_events_url":"https://api.github.com/users/cjihrig/received_events","type":"User","site_admin":false},"body":"### Pull Request check-list\r\n\r\n- [x] Does `make -j8 test` (UNIX) or `vcbuild test nosign` (Windows) pass with\r\n  this change (including linting)?\r\n- [x] Is the commit message formatted according to [CONTRIBUTING.md][0]?\r\n- [x] If this change fixes a bug (or a performance problem), is a regression\r\n  test (or a benchmark) included?\r\n- [x] Is a documentation update included (if this change modifies\r\n  existing APIs, or introduces new ones)?\r\n\r\n### Affected core subsystem(s)\r\n\r\ndoc\r\n\r\n[0]: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#step-3-commit\r\n\r\n### Description of change\r\n\r\n`util.isError()` is the only remaining `util.is*()` method that depends on `Object.prototype.toString()` behavior. This commit notes the limitations of `isError()` related to `@@toStringTag`.\r\n\r\nRefs: https://github.com/nodejs/node/pull/2201","created_at":"2016-02-24T17:05:43Z","updated_at":"2016-02-25T13:40:06Z","closed_at":"2016-02-25T13:40:05Z","merged_at":"2016-02-25T13:40:05Z","merge_commit_sha":"a8ba22b738b9c017793d08bb38422225ac0d163d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/5414/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/5414/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/5414/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/54cbf2826b2e5c6d45bcb7d1a30ab1a4306cfcf6","head":{"label":"cjihrig:iserror","ref":"iserror","sha":"54cbf2826b2e5c6d45bcb7d1a30ab1a4306cfcf6","user":{"login":"cjihrig","id":2512748,"avatar_url":"https://avatars.githubusercontent.com/u/2512748?v=3","gravatar_id":"","url":"https://api.github.com/users/cjihrig","html_url":"https://github.com/cjihrig","followers_url":"https://api.github.com/users/cjihrig/followers","following_url":"https://api.github.com/users/cjihrig/following{/other_user}","gists_url":"https://api.github.com/users/cjihrig/gists{/gist_id}","starred_url":"https://api.github.com/users/cjihrig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjihrig/subscriptions","organizations_url":"https://api.github.com/users/cjihrig/orgs","repos_url":"https://api.github.com/users/cjihrig/repos","events_url":"https://api.github.com/users/cjihrig/events{/privacy}","received_events_url":"https://api.github.com/users/cjihrig/received_events","type":"User","site_admin":false},"repo":{"id":40613511,"name":"node-1","full_name":"cjihrig/node-1","owner":{"login":"cjihrig","id":2512748,"avatar_url":"https://avatars.githubusercontent.com/u/2512748?v=3","gravatar_id":"","url":"https://api.github.com/users/cjihrig","html_url":"https://github.com/cjihrig","followers_url":"https://api.github.com/users/cjihrig/followers","following_url":"https://api.github.com/users/cjihrig/following{/other_user}","gists_url":"https://api.github.com/users/cjihrig/gists{/gist_id}","starred_url":"https://api.github.com/users/cjihrig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjihrig/subscriptions","organizations_url":"https://api.github.com/users/cjihrig/orgs","repos_url":"https://api.github.com/users/cjihrig/repos","events_url":"https://api.github.com/users/cjihrig/events{/privacy}","received_events_url":"https://api.github.com/users/cjihrig/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cjihrig/node-1","description":"Future Node.js releases will be from this repo.","fork":true,"url":"https://api.github.com/repos/cjihrig/node-1","forks_url":"https://api.github.com/repos/cjihrig/node-1/forks","keys_url":"https://api.github.com/repos/cjihrig/node-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cjihrig/node-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cjihrig/node-1/teams","hooks_url":"https://api.github.com/repos/cjihrig/node-1/hooks","issue_events_url":"https://api.github.com/repos/cjihrig/node-1/issues/events{/number}","events_url":"https://api.github.com/repos/cjihrig/node-1/events","assignees_url":"https://api.github.com/repos/cjihrig/node-1/assignees{/user}","branches_url":"https://api.github.com/repos/cjihrig/node-1/branches{/branch}","tags_url":"https://api.github.com/repos/cjihrig/node-1/tags","blobs_url":"https://api.github.com/repos/cjihrig/node-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cjihrig/node-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cjihrig/node-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/cjihrig/node-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cjihrig/node-1/statuses/{sha}","languages_url":"https://api.github.com/repos/cjihrig/node-1/languages","stargazers_url":"https://api.github.com/repos/cjihrig/node-1/stargazers","contributors_url":"https://api.github.com/repos/cjihrig/node-1/contributors","subscribers_url":"https://api.github.com/repos/cjihrig/node-1/subscribers","subscription_url":"https://api.github.com/repos/cjihrig/node-1/subscription","commits_url":"https://api.github.com/repos/cjihrig/node-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/cjihrig/node-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/cjihrig/node-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/cjihrig/node-1/issues/comments{/number}","contents_url":"https://api.github.com/repos/cjihrig/node-1/contents/{+path}","compare_url":"https://api.github.com/repos/cjihrig/node-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cjihrig/node-1/merges","archive_url":"https://api.github.com/repos/cjihrig/node-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cjihrig/node-1/downloads","issues_url":"https://api.github.com/repos/cjihrig/node-1/issues{/number}","pulls_url":"https://api.github.com/repos/cjihrig/node-1/pulls{/number}","milestones_url":"https://api.github.com/repos/cjihrig/node-1/milestones{/number}","notifications_url":"https://api.github.com/repos/cjihrig/node-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cjihrig/node-1/labels{/name}","releases_url":"https://api.github.com/repos/cjihrig/node-1/releases{/id}","deployments_url":"https://api.github.com/repos/cjihrig/node-1/deployments","created_at":"2015-08-12T17:07:21Z","updated_at":"2015-08-12T17:07:25Z","pushed_at":"2016-02-25T13:39:13Z","git_url":"git://github.com/cjihrig/node-1.git","ssh_url":"git@github.com:cjihrig/node-1.git","clone_url":"https://github.com/cjihrig/node-1.git","svn_url":"https://github.com/cjihrig/node-1","homepage":"https://iojs.org","size":174450,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"33e51fe18c82e882fe65f77ab14cbaf0efee4e0f","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2016-02-25T11:50:10Z","pushed_at":"2016-02-25T13:39:43Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":213807,"stargazers_count":20499,"watchers_count":20499,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2556,"mirror_url":null,"open_issues_count":746,"forks":2556,"open_issues":746,"watchers":20499,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/5414"},"html":{"href":"https://github.com/nodejs/node/pull/5414"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/5414"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/5414/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/5414/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/5414/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/54cbf2826b2e5c6d45bcb7d1a30ab1a4306cfcf6"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"cjihrig","id":2512748,"avatar_url":"https://avatars.githubusercontent.com/u/2512748?v=3","gravatar_id":"","url":"https://api.github.com/users/cjihrig","html_url":"https://github.com/cjihrig","followers_url":"https://api.github.com/users/cjihrig/followers","following_url":"https://api.github.com/users/cjihrig/following{/other_user}","gists_url":"https://api.github.com/users/cjihrig/gists{/gist_id}","starred_url":"https://api.github.com/users/cjihrig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjihrig/subscriptions","organizations_url":"https://api.github.com/users/cjihrig/orgs","repos_url":"https://api.github.com/users/cjihrig/repos","events_url":"https://api.github.com/users/cjihrig/events{/privacy}","received_events_url":"https://api.github.com/users/cjihrig/received_events","type":"User","site_admin":false},"comments":1,"review_comments":8,"commits":1,"additions":16,"deletions":0,"changed_files":1}}