{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/60655389","id":60655389,"diff_hunk":"@@ -0,0 +1,111 @@\n+/*\n+ * Licensed to the Apache Software Foundation (ASF) under one or more\n+ * contributor license agreements.  See the NOTICE file distributed with\n+ * this work for additional information regarding copyright ownership.\n+ * The ASF licenses this file to You under the Apache License, Version 2.0\n+ * (the \"License\"); you may not use this file except in compliance with\n+ * the License.  You may obtain a copy of the License at\n+ *\n+ *    http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+package org.apache.spark.sql.execution.command\n+\n+import scala.util.control.NonFatal\n+\n+import org.apache.hadoop.fs.{FileSystem, Path}\n+\n+import org.apache.spark.sql.{Row, SQLContext}\n+import org.apache.spark.sql.catalyst.analysis.EliminateSubqueryAliases\n+import org.apache.spark.sql.catalyst.catalog.{CatalogRelation, CatalogTable}\n+\n+\n+/**\n+ * Analyzes the given table in the current database to generate statistics, which will be\n+ * used in query optimizations.\n+ *\n+ * Right now, it only supports Hive tables and it only updates the size of a Hive table\n+ * in the Hive metastore.\n+ */\n+case class AnalyzeTable(tableName: String) extends RunnableCommand {\n+\n+  override def run(sqlContext: SQLContext): Seq[Row] = {\n+    val sessionState = sqlContext.sessionState\n+    val tableIdent = sessionState.sqlParser.parseTableIdentifier(tableName)\n+    val relation = EliminateSubqueryAliases(sessionState.catalog.lookupRelation(tableIdent))\n+\n+    relation match {\n+      case relation: CatalogRelation =>\n+        val catalogTable: CatalogTable = relation.catalogTable\n+        // This method is mainly based on\n+        // org.apache.hadoop.hive.ql.stats.StatsUtils.getFileSizeForTable(HiveConf, Table)\n+        // in Hive 0.13 (except that we do not use fs.getContentSummary).\n+        // TODO: Generalize statistics collection.\n+        // TODO: Why fs.getContentSummary returns wrong size on Jenkins?\n+        // Can we use fs.getContentSummary in future?\n+        // Seems fs.getContentSummary returns wrong table size on Jenkins. So we use\n+        // countFileSize to count the table size.\n+        val stagingDir = sessionState.conf.getConfString(\"hive.exec.stagingdir\", \".hive-staging\")\n+\n+        def calculateTableSize(fs: FileSystem, path: Path): Long = {\n+          val fileStatus = fs.getFileStatus(path)\n+          val size = if (fileStatus.isDirectory) {\n+            fs.listStatus(path)\n+              .map { status =>\n+                if (!status.getPath.getName.startsWith(stagingDir)) {\n+                  calculateTableSize(fs, status.getPath)\n+                } else {\n+                  0L\n+                }\n+              }.sum\n+          } else {\n+            fileStatus.getLen\n+          }\n+\n+          size\n+        }\n+\n+        val tableParameters = catalogTable.properties\n+        val oldTotalSize = tableParameters.get(\"totalSize\").map(_.toLong).getOrElse(0L)\n+        val newTotalSize =\n+          catalogTable.storage.locationUri.map { p =>\n+            val path = new Path(p)\n+            try {\n+              val fs = path.getFileSystem(sqlContext.sparkContext.hadoopConfiguration)\n+              calculateTableSize(fs, path)\n+            } catch {\n+              case NonFatal(e) =>\n+                logWarning(\n+                  s\"Failed to get the size of table ${catalogTable.identifier.table} in the \" +\n+                    s\"database ${catalogTable.identifier.database} because of ${e.toString}\", e)\n+                0L\n+            }\n+          }.getOrElse(0L)\n+\n+        // Update the Hive metastore if the total size of the table is different than the size\n+        // recorded in the Hive metastore.\n+        // This logic is based on org.apache.hadoop.hive.ql.exec.StatsTask.aggregateStats().\n+        if (newTotalSize > 0 && newTotalSize != oldTotalSize) {\n+          sessionState.catalog.alterTable(\n+            catalogTable.copy(\n+              properties = relation.catalogTable.properties +\n+                (AnalyzeTable.TOTAL_SIZE_FIELD -> newTotalSize.toString)))","path":"sql/core/src/main/scala/org/apache/spark/sql/execution/command/AnalyzeTable.scala","position":98,"original_position":98,"commit_id":"6df11b1b5471f3dde0f9989159e974b46765a7e6","original_commit_id":"6df11b1b5471f3dde0f9989159e974b46765a7e6","user":{"login":"rxin","id":323388,"avatar_url":"https://avatars.githubusercontent.com/u/323388?v=3","gravatar_id":"","url":"https://api.github.com/users/rxin","html_url":"https://github.com/rxin","followers_url":"https://api.github.com/users/rxin/followers","following_url":"https://api.github.com/users/rxin/following{/other_user}","gists_url":"https://api.github.com/users/rxin/gists{/gist_id}","starred_url":"https://api.github.com/users/rxin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rxin/subscriptions","organizations_url":"https://api.github.com/users/rxin/orgs","repos_url":"https://api.github.com/users/rxin/repos","events_url":"https://api.github.com/users/rxin/events{/privacy}","received_events_url":"https://api.github.com/users/rxin/received_events","type":"User","site_admin":false},"body":"this was using some hive constant -- changed to use an internal constant.\r\n","created_at":"2016-04-21T21:07:11Z","updated_at":"2016-04-21T21:07:11Z","html_url":"https://github.com/apache/spark/pull/12584#discussion_r60655389","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/12584","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/60655389"},"html":{"href":"https://github.com/apache/spark/pull/12584#discussion_r60655389"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/12584"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/12584","id":67422022,"html_url":"https://github.com/apache/spark/pull/12584","diff_url":"https://github.com/apache/spark/pull/12584.diff","patch_url":"https://github.com/apache/spark/pull/12584.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/12584","number":12584,"state":"open","locked":false,"title":"[SPARK-14821][SQL] Move analyze table parsing into SparkSqlAstBuilder","user":{"login":"rxin","id":323388,"avatar_url":"https://avatars.githubusercontent.com/u/323388?v=3","gravatar_id":"","url":"https://api.github.com/users/rxin","html_url":"https://github.com/rxin","followers_url":"https://api.github.com/users/rxin/followers","following_url":"https://api.github.com/users/rxin/following{/other_user}","gists_url":"https://api.github.com/users/rxin/gists{/gist_id}","starred_url":"https://api.github.com/users/rxin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rxin/subscriptions","organizations_url":"https://api.github.com/users/rxin/orgs","repos_url":"https://api.github.com/users/rxin/repos","events_url":"https://api.github.com/users/rxin/events{/privacy}","received_events_url":"https://api.github.com/users/rxin/received_events","type":"User","site_admin":false},"body":"## What changes were proposed in this pull request?\r\nThis patch moves analyze table parsing into SparkSqlAstBuilder. Once this and SPARK-14798 go in, we should be able to merge HiveSqlAstBuilder and SparkSqlAstBuilder.\r\n\r\nIn order to avoid extensive refactoring, I created a common trait for CatalogRelation and MetastoreRelation, and match on that. In the future we should probably just consolidate the two into a single thing so we don't need this common trait.\r\n\r\n## How was this patch tested?\r\nUpdated unit tests.\r\n\r\n","created_at":"2016-04-21T21:03:23Z","updated_at":"2016-04-21T21:07:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e09aa1213884607d5da0fca0cb0d443d83b50ca0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/12584/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/12584/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/12584/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/6df11b1b5471f3dde0f9989159e974b46765a7e6","head":{"label":"rxin:SPARK-14821","ref":"SPARK-14821","sha":"6df11b1b5471f3dde0f9989159e974b46765a7e6","user":{"login":"rxin","id":323388,"avatar_url":"https://avatars.githubusercontent.com/u/323388?v=3","gravatar_id":"","url":"https://api.github.com/users/rxin","html_url":"https://github.com/rxin","followers_url":"https://api.github.com/users/rxin/followers","following_url":"https://api.github.com/users/rxin/following{/other_user}","gists_url":"https://api.github.com/users/rxin/gists{/gist_id}","starred_url":"https://api.github.com/users/rxin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rxin/subscriptions","organizations_url":"https://api.github.com/users/rxin/orgs","repos_url":"https://api.github.com/users/rxin/repos","events_url":"https://api.github.com/users/rxin/events{/privacy}","received_events_url":"https://api.github.com/users/rxin/received_events","type":"User","site_admin":false},"repo":{"id":17192644,"name":"spark","full_name":"rxin/spark","owner":{"login":"rxin","id":323388,"avatar_url":"https://avatars.githubusercontent.com/u/323388?v=3","gravatar_id":"","url":"https://api.github.com/users/rxin","html_url":"https://github.com/rxin","followers_url":"https://api.github.com/users/rxin/followers","following_url":"https://api.github.com/users/rxin/following{/other_user}","gists_url":"https://api.github.com/users/rxin/gists{/gist_id}","starred_url":"https://api.github.com/users/rxin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rxin/subscriptions","organizations_url":"https://api.github.com/users/rxin/orgs","repos_url":"https://api.github.com/users/rxin/repos","events_url":"https://api.github.com/users/rxin/events{/privacy}","received_events_url":"https://api.github.com/users/rxin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rxin/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/rxin/spark","forks_url":"https://api.github.com/repos/rxin/spark/forks","keys_url":"https://api.github.com/repos/rxin/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rxin/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rxin/spark/teams","hooks_url":"https://api.github.com/repos/rxin/spark/hooks","issue_events_url":"https://api.github.com/repos/rxin/spark/issues/events{/number}","events_url":"https://api.github.com/repos/rxin/spark/events","assignees_url":"https://api.github.com/repos/rxin/spark/assignees{/user}","branches_url":"https://api.github.com/repos/rxin/spark/branches{/branch}","tags_url":"https://api.github.com/repos/rxin/spark/tags","blobs_url":"https://api.github.com/repos/rxin/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rxin/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rxin/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/rxin/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rxin/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/rxin/spark/languages","stargazers_url":"https://api.github.com/repos/rxin/spark/stargazers","contributors_url":"https://api.github.com/repos/rxin/spark/contributors","subscribers_url":"https://api.github.com/repos/rxin/spark/subscribers","subscription_url":"https://api.github.com/repos/rxin/spark/subscription","commits_url":"https://api.github.com/repos/rxin/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/rxin/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/rxin/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/rxin/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/rxin/spark/contents/{+path}","compare_url":"https://api.github.com/repos/rxin/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rxin/spark/merges","archive_url":"https://api.github.com/repos/rxin/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rxin/spark/downloads","issues_url":"https://api.github.com/repos/rxin/spark/issues{/number}","pulls_url":"https://api.github.com/repos/rxin/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/rxin/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/rxin/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rxin/spark/labels{/name}","releases_url":"https://api.github.com/repos/rxin/spark/releases{/id}","deployments_url":"https://api.github.com/repos/rxin/spark/deployments","created_at":"2014-02-25T23:55:52Z","updated_at":"2016-03-30T14:52:33Z","pushed_at":"2016-04-21T21:06:24Z","git_url":"git://github.com/rxin/spark.git","ssh_url":"git@github.com:rxin/spark.git","clone_url":"https://github.com/rxin/spark.git","svn_url":"https://github.com/rxin/spark","homepage":null,"size":169674,"stargazers_count":4,"watchers_count":4,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":0,"forks":6,"open_issues":0,"watchers":4,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"8e1bb0456db1ad60afa24aa033b574c4a79b9c09","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","deployments_url":"https://api.github.com/repos/apache/spark/deployments","created_at":"2014-02-25T08:00:08Z","updated_at":"2016-04-21T17:39:20Z","pushed_at":"2016-04-21T21:06:25Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":463898,"stargazers_count":8235,"watchers_count":8235,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7613,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":456,"forks":7613,"open_issues":456,"watchers":8235,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/12584"},"html":{"href":"https://github.com/apache/spark/pull/12584"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/12584"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/12584/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/12584/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/12584/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/6df11b1b5471f3dde0f9989159e974b46765a7e6"}}}}