{"action":"closed","number":11329,"pull_request":{"url":"https://api.github.com/repos/JuliaLang/julia/pulls/11329","id":35649566,"html_url":"https://github.com/JuliaLang/julia/pull/11329","diff_url":"https://github.com/JuliaLang/julia/pull/11329.diff","patch_url":"https://github.com/JuliaLang/julia/pull/11329.patch","issue_url":"https://api.github.com/repos/JuliaLang/julia/issues/11329","number":11329,"state":"closed","locked":false,"title":"fix for #11305 \"subl\" option in interactiveutil.jl","user":{"login":"timema","id":2054988,"avatar_url":"https://avatars.githubusercontent.com/u/2054988?v=3","gravatar_id":"","url":"https://api.github.com/users/timema","html_url":"https://github.com/timema","followers_url":"https://api.github.com/users/timema/followers","following_url":"https://api.github.com/users/timema/following{/other_user}","gists_url":"https://api.github.com/users/timema/gists{/gist_id}","starred_url":"https://api.github.com/users/timema/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timema/subscriptions","organizations_url":"https://api.github.com/users/timema/orgs","repos_url":"https://api.github.com/users/timema/repos","events_url":"https://api.github.com/users/timema/events{/privacy}","received_events_url":"https://api.github.com/users/timema/received_events","type":"User","site_admin":false},"body":"I think I figured out a solution to issue #11305 function edit seems to create bad path for sublime text option (i.e. \"subl\") in interactiveutil.jl\r\n\r\nI think I figured it out if I change the path from:\r\nENV[\"JULIA_EDITOR\"]=\"/Applications/Sublime\\ Text.app/Contents/SharedSupport/bin/subl\"\r\nENV[\"JULIA_EDITOR\"]=\"/Applications/Sublime\\\\ Text.app/Contents/SharedSupport/bin/subl\"\r\nedname stays as: \r\n\"/Applications/Sublime\\\\ Text.app/Contents/SharedSupport/bin/subl\" and not \"subl\" as it should while shell_split(edpath) produces the correct:\r\n\"/Applications/Sublime Text.app/Contents/SharedSupport/bin/subl\"\r\n\r\nin order to fix it we need to change:\r\nin 0.3.8 interactiveutil.jl line 34\r\nfrom:   elseif beginswith(edname, \"subl\")\r\nto:       elseif beginswith(edname, \"subl\") || endswith(string(edname),\"subl\")\r\n\r\nand in the latest pre 0.4 from\r\nin 0.3.8 interactiveutil.jl line 36\r\nfrom:   startswith(edname, \"subl\") || edname == \"atom\"\r\nto:      startswith(edname, \"subl\") || edname == \"atom\" || endswith(string(edname),\"subl\")\r\n\r\n\r\nThis is a pull request to change the code for the latest pre 0.4  I am not sure how to make a pull reqest to fix if for the latest 0.3 version.","created_at":"2015-05-18T16:19:28Z","updated_at":"2016-09-13T23:32:00Z","closed_at":"2016-09-13T23:32:00Z","merged_at":null,"merge_commit_sha":"1b46b20b4d025a1ea65397138b0ac5d43cb9533e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/JuliaLang/julia/pulls/11329/commits","review_comments_url":"https://api.github.com/repos/JuliaLang/julia/pulls/11329/comments","review_comment_url":"https://api.github.com/repos/JuliaLang/julia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JuliaLang/julia/issues/11329/comments","statuses_url":"https://api.github.com/repos/JuliaLang/julia/statuses/707280dcfed15e37ad96ec707b3f46ddee2ef9da","head":{"label":"timema:master","ref":"master","sha":"707280dcfed15e37ad96ec707b3f46ddee2ef9da","user":{"login":"timema","id":2054988,"avatar_url":"https://avatars.githubusercontent.com/u/2054988?v=3","gravatar_id":"","url":"https://api.github.com/users/timema","html_url":"https://github.com/timema","followers_url":"https://api.github.com/users/timema/followers","following_url":"https://api.github.com/users/timema/following{/other_user}","gists_url":"https://api.github.com/users/timema/gists{/gist_id}","starred_url":"https://api.github.com/users/timema/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timema/subscriptions","organizations_url":"https://api.github.com/users/timema/orgs","repos_url":"https://api.github.com/users/timema/repos","events_url":"https://api.github.com/users/timema/events{/privacy}","received_events_url":"https://api.github.com/users/timema/received_events","type":"User","site_admin":false},"repo":{"id":35828340,"name":"julia","full_name":"timema/julia","owner":{"login":"timema","id":2054988,"avatar_url":"https://avatars.githubusercontent.com/u/2054988?v=3","gravatar_id":"","url":"https://api.github.com/users/timema","html_url":"https://github.com/timema","followers_url":"https://api.github.com/users/timema/followers","following_url":"https://api.github.com/users/timema/following{/other_user}","gists_url":"https://api.github.com/users/timema/gists{/gist_id}","starred_url":"https://api.github.com/users/timema/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timema/subscriptions","organizations_url":"https://api.github.com/users/timema/orgs","repos_url":"https://api.github.com/users/timema/repos","events_url":"https://api.github.com/users/timema/events{/privacy}","received_events_url":"https://api.github.com/users/timema/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/timema/julia","description":"The Julia Language: A fresh approach to technical computing.","fork":true,"url":"https://api.github.com/repos/timema/julia","forks_url":"https://api.github.com/repos/timema/julia/forks","keys_url":"https://api.github.com/repos/timema/julia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/timema/julia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/timema/julia/teams","hooks_url":"https://api.github.com/repos/timema/julia/hooks","issue_events_url":"https://api.github.com/repos/timema/julia/issues/events{/number}","events_url":"https://api.github.com/repos/timema/julia/events","assignees_url":"https://api.github.com/repos/timema/julia/assignees{/user}","branches_url":"https://api.github.com/repos/timema/julia/branches{/branch}","tags_url":"https://api.github.com/repos/timema/julia/tags","blobs_url":"https://api.github.com/repos/timema/julia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/timema/julia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/timema/julia/git/refs{/sha}","trees_url":"https://api.github.com/repos/timema/julia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/timema/julia/statuses/{sha}","languages_url":"https://api.github.com/repos/timema/julia/languages","stargazers_url":"https://api.github.com/repos/timema/julia/stargazers","contributors_url":"https://api.github.com/repos/timema/julia/contributors","subscribers_url":"https://api.github.com/repos/timema/julia/subscribers","subscription_url":"https://api.github.com/repos/timema/julia/subscription","commits_url":"https://api.github.com/repos/timema/julia/commits{/sha}","git_commits_url":"https://api.github.com/repos/timema/julia/git/commits{/sha}","comments_url":"https://api.github.com/repos/timema/julia/comments{/number}","issue_comment_url":"https://api.github.com/repos/timema/julia/issues/comments{/number}","contents_url":"https://api.github.com/repos/timema/julia/contents/{+path}","compare_url":"https://api.github.com/repos/timema/julia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/timema/julia/merges","archive_url":"https://api.github.com/repos/timema/julia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/timema/julia/downloads","issues_url":"https://api.github.com/repos/timema/julia/issues{/number}","pulls_url":"https://api.github.com/repos/timema/julia/pulls{/number}","milestones_url":"https://api.github.com/repos/timema/julia/milestones{/number}","notifications_url":"https://api.github.com/repos/timema/julia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/timema/julia/labels{/name}","releases_url":"https://api.github.com/repos/timema/julia/releases{/id}","deployments_url":"https://api.github.com/repos/timema/julia/deployments","created_at":"2015-05-18T16:11:41Z","updated_at":"2015-05-18T16:11:49Z","pushed_at":"2015-10-22T20:13:30Z","git_url":"git://github.com/timema/julia.git","ssh_url":"git@github.com:timema/julia.git","clone_url":"https://github.com/timema/julia.git","svn_url":"https://github.com/timema/julia","homepage":"http://julialang.org/","size":71612,"stargazers_count":0,"watchers_count":0,"language":"Julia","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JuliaLang:master","ref":"master","sha":"b122bc7d31eb0c25e9e88c819b9f1d07a803ffa9","user":{"login":"JuliaLang","id":743164,"avatar_url":"https://avatars.githubusercontent.com/u/743164?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"repo":{"id":1644196,"name":"julia","full_name":"JuliaLang/julia","owner":{"login":"JuliaLang","id":743164,"avatar_url":"https://avatars.githubusercontent.com/u/743164?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JuliaLang/julia","description":"The Julia Language: A fresh approach to technical computing.","fork":false,"url":"https://api.github.com/repos/JuliaLang/julia","forks_url":"https://api.github.com/repos/JuliaLang/julia/forks","keys_url":"https://api.github.com/repos/JuliaLang/julia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaLang/julia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaLang/julia/teams","hooks_url":"https://api.github.com/repos/JuliaLang/julia/hooks","issue_events_url":"https://api.github.com/repos/JuliaLang/julia/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaLang/julia/events","assignees_url":"https://api.github.com/repos/JuliaLang/julia/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaLang/julia/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaLang/julia/tags","blobs_url":"https://api.github.com/repos/JuliaLang/julia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaLang/julia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaLang/julia/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaLang/julia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaLang/julia/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaLang/julia/languages","stargazers_url":"https://api.github.com/repos/JuliaLang/julia/stargazers","contributors_url":"https://api.github.com/repos/JuliaLang/julia/contributors","subscribers_url":"https://api.github.com/repos/JuliaLang/julia/subscribers","subscription_url":"https://api.github.com/repos/JuliaLang/julia/subscription","commits_url":"https://api.github.com/repos/JuliaLang/julia/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaLang/julia/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaLang/julia/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaLang/julia/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaLang/julia/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaLang/julia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaLang/julia/merges","archive_url":"https://api.github.com/repos/JuliaLang/julia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaLang/julia/downloads","issues_url":"https://api.github.com/repos/JuliaLang/julia/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaLang/julia/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaLang/julia/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaLang/julia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaLang/julia/labels{/name}","releases_url":"https://api.github.com/repos/JuliaLang/julia/releases{/id}","deployments_url":"https://api.github.com/repos/JuliaLang/julia/deployments","created_at":"2011-04-21T07:01:50Z","updated_at":"2016-09-13T15:53:16Z","pushed_at":"2016-09-13T23:29:00Z","git_url":"git://github.com/JuliaLang/julia.git","ssh_url":"git@github.com:JuliaLang/julia.git","clone_url":"https://github.com/JuliaLang/julia.git","svn_url":"https://github.com/JuliaLang/julia","homepage":"http://julialang.org/","size":421877,"stargazers_count":7499,"watchers_count":7499,"language":"Julia","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1753,"mirror_url":null,"open_issues_count":1997,"forks":1753,"open_issues":1997,"watchers":7499,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/11329"},"html":{"href":"https://github.com/JuliaLang/julia/pull/11329"},"issue":{"href":"https://api.github.com/repos/JuliaLang/julia/issues/11329"},"comments":{"href":"https://api.github.com/repos/JuliaLang/julia/issues/11329/comments"},"review_comments":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/11329/comments"},"review_comment":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/11329/commits"},"statuses":{"href":"https://api.github.com/repos/JuliaLang/julia/statuses/707280dcfed15e37ad96ec707b3f46ddee2ef9da"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":2,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"StefanKarpinski"}}