{"action":"created","issue":{"url":"https://api.github.com/repos/celery/py-amqp/issues/78","repository_url":"https://api.github.com/repos/celery/py-amqp","labels_url":"https://api.github.com/repos/celery/py-amqp/issues/78/labels{/name}","comments_url":"https://api.github.com/repos/celery/py-amqp/issues/78/comments","events_url":"https://api.github.com/repos/celery/py-amqp/issues/78/events","html_url":"https://github.com/celery/py-amqp/pull/78","id":128300430,"number":78,"title":"Prevent a UTF-8 decoder error from breaking Celery","user":{"login":"djsmith42","id":921044,"avatar_url":"https://avatars.githubusercontent.com/u/921044?v=3","gravatar_id":"","url":"https://api.github.com/users/djsmith42","html_url":"https://github.com/djsmith42","followers_url":"https://api.github.com/users/djsmith42/followers","following_url":"https://api.github.com/users/djsmith42/following{/other_user}","gists_url":"https://api.github.com/users/djsmith42/gists{/gist_id}","starred_url":"https://api.github.com/users/djsmith42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djsmith42/subscriptions","organizations_url":"https://api.github.com/users/djsmith42/orgs","repos_url":"https://api.github.com/users/djsmith42/repos","events_url":"https://api.github.com/users/djsmith42/events{/privacy}","received_events_url":"https://api.github.com/users/djsmith42/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2016-01-23T04:48:02Z","updated_at":"2016-05-27T20:28:07Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/celery/py-amqp/pulls/78","html_url":"https://github.com/celery/py-amqp/pull/78","diff_url":"https://github.com/celery/py-amqp/pull/78.diff","patch_url":"https://github.com/celery/py-amqp/pull/78.patch"},"body":"Prior to this commit, a non-UTF8 encoded header string would cause an uncaught\r\nUnicodeDecodeError, which would cause an unrecoverable Celery\r\nerror. Now we will log non-UTF8 header strings (names and values), ignore them, and\r\ncontinue processing.\r\n\r\nCloses https://github.com/celery/celery/issues/2873"},"comment":{"url":"https://api.github.com/repos/celery/py-amqp/issues/comments/222245595","html_url":"https://github.com/celery/py-amqp/pull/78#issuecomment-222245595","issue_url":"https://api.github.com/repos/celery/py-amqp/issues/78","id":222245595,"user":{"login":"djsmith42","id":921044,"avatar_url":"https://avatars.githubusercontent.com/u/921044?v=3","gravatar_id":"","url":"https://api.github.com/users/djsmith42","html_url":"https://github.com/djsmith42","followers_url":"https://api.github.com/users/djsmith42/followers","following_url":"https://api.github.com/users/djsmith42/following{/other_user}","gists_url":"https://api.github.com/users/djsmith42/gists{/gist_id}","starred_url":"https://api.github.com/users/djsmith42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djsmith42/subscriptions","organizations_url":"https://api.github.com/users/djsmith42/orgs","repos_url":"https://api.github.com/users/djsmith42/repos","events_url":"https://api.github.com/users/djsmith42/events{/privacy}","received_events_url":"https://api.github.com/users/djsmith42/received_events","type":"User","site_admin":false},"created_at":"2016-05-27T20:28:07Z","updated_at":"2016-05-27T20:28:07Z","body":"I rebased the latest master (oops, should have merged), but I'm still getting test failures with a similar error. However, now at least half of the tests are passing. The other half'ish are failing like this:\r\n\r\n```\r\n======================================================================\r\nERROR: test_roundtrip (amqp.tests.test_serialization.test_serialization)\r\n----------------------------------------------------------------------\r\nTraceback (most recent call last):\r\n  File \"/home/dsmith/Dev/sandbox/git/py-amqp/amqp/tests/test_serialization.py\", line 61, in test_roundtrip\r\n    datetime(2015, 3, 13, 10, 23),\r\n  File \"/home/dsmith/Dev/sandbox/git/py-amqp/amqp/serialization.py\", line 294, in dumps\r\n    write(pack('>H', int(val)))\r\nTypeError: Struct() argument 1 must be string, not unicode\r\n\r\n======================================================================\r\nERROR: test_table (amqp.tests.test_serialization.test_serialization)\r\n----------------------------------------------------------------------\r\nTraceback (most recent call last):\r\n  File \"/home/dsmith/Dev/sandbox/git/py-amqp/amqp/tests/test_serialization.py\", line 83, in test_table\r\n    loads(b'F', dumps(b'F', [table]))[0][0],\r\n  File \"/home/dsmith/Dev/sandbox/git/py-amqp/amqp/serialization.py\", line 320, in dumps\r\n    _write_table(val or {}, write, bits)\r\n  File \"/home/dsmith/Dev/sandbox/git/py-amqp/amqp/serialization.py\", line 340, in _write_table\r\n    _write_item(v, twrite, bits)\r\n  File \"/home/dsmith/Dev/sandbox/git/py-amqp/amqp/serialization.py\", line 378, in _write_item\r\n    write(pack('>ci', b'I', v))\r\nTypeError: Struct() argument 1 must be string, not unicode\r\n```"}}
{"actor":{"display_login":"djsmith42"}}