{"action":"created","comment":{"url":"https://api.github.com/repos/CGAL/cgal/pulls/comments/90431209","pull_request_review_id":10948568,"id":90431209,"diff_hunk":"@@ -80,27 +80,45 @@ namespace Polygon_mesh_processing {\n \n     template<typename PM\n            , typename FaceRange\n-           , typename HalfedgeOutputIterator>\n+           , typename HalfedgeOutputIterator\n+           , typename NamedParameters>\n     HalfedgeOutputIterator border_halfedges_impl(const FaceRange& faces\n                                                , typename boost::cgal_no_property::type\n                                                , HalfedgeOutputIterator out\n-                                               , const PM& pmesh)\n+                                               , const PM& pmesh\n+                                               , const NamedParameters& /* np */)\n     {\n       return border_halfedges_impl(faces, out, pmesh);\n     }\n \n     template<typename PM\n            , typename FaceRange\n            , typename FaceIndexMap\n-           , typename HalfedgeOutputIterator>\n+           , typename HalfedgeOutputIterator\n+           , typename NamedParameters>\n     HalfedgeOutputIterator border_halfedges_impl(const FaceRange& faces\n                                                , const FaceIndexMap& fmap\n                                                , HalfedgeOutputIterator out\n-                                               , const PM& pmesh)\n+                                               , const PM& pmesh\n+                                               , const NamedParameters& /* np */)\n     {\n       typedef typename boost::graph_traits<PM>::halfedge_descriptor halfedge_descriptor;\n       typedef typename boost::graph_traits<PM>::face_descriptor     face_descriptor;\n \n+      //make a minimal check that it's properly initialized :\n+      //if the 2 first faces have the same id, we know the property map is not initialized\n+      if (boost::is_same<typename GetFaceIndexMap<PM, NamedParameters>::Is_internal_map,\n+                         boost::true_type>::value)\n+      {\n+        typename boost::range_iterator<const FaceRange>::type it = boost::const_begin(faces);\n+        if (get(fmap, *it) == get(fmap, *cpp11::next(it)))","path":"Polygon_mesh_processing/include/CGAL/Polygon_mesh_processing/border.h","position":39,"original_position":39,"commit_id":"bfbba261242cf5f988b91b4cb4506eeddeba00b1","original_commit_id":"bfbba261242cf5f988b91b4cb4506eeddeba00b1","user":{"login":"MaelRL","id":5074170,"avatar_url":"https://avatars.githubusercontent.com/u/5074170?v=3","gravatar_id":"","url":"https://api.github.com/users/MaelRL","html_url":"https://github.com/MaelRL","followers_url":"https://api.github.com/users/MaelRL/followers","following_url":"https://api.github.com/users/MaelRL/following{/other_user}","gists_url":"https://api.github.com/users/MaelRL/gists{/gist_id}","starred_url":"https://api.github.com/users/MaelRL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaelRL/subscriptions","organizations_url":"https://api.github.com/users/MaelRL/orgs","repos_url":"https://api.github.com/users/MaelRL/repos","events_url":"https://api.github.com/users/MaelRL/events{/privacy}","received_events_url":"https://api.github.com/users/MaelRL/received_events","type":"User","site_admin":false},"body":"There are already two checks in the main function `border_halfedges()`:\r\n` if (faces.empty()) return out;`\r\nand\r\n` if (boost::is_same<FIMap, Unset_FIMap>::value || faces.size() == 1)`\r\nwho should handle those cases. Do I repeat them there ?","created_at":"2016-12-01T11:46:34Z","updated_at":"2016-12-01T11:46:34Z","html_url":"https://github.com/CGAL/cgal/pull/1730#discussion_r90431209","pull_request_url":"https://api.github.com/repos/CGAL/cgal/pulls/1730","_links":{"self":{"href":"https://api.github.com/repos/CGAL/cgal/pulls/comments/90431209"},"html":{"href":"https://github.com/CGAL/cgal/pull/1730#discussion_r90431209"},"pull_request":{"href":"https://api.github.com/repos/CGAL/cgal/pulls/1730"}}},"pull_request":{"url":"https://api.github.com/repos/CGAL/cgal/pulls/1730","id":96068753,"html_url":"https://github.com/CGAL/cgal/pull/1730","diff_url":"https://github.com/CGAL/cgal/pull/1730.diff","patch_url":"https://github.com/CGAL/cgal/pull/1730.patch","issue_url":"https://api.github.com/repos/CGAL/cgal/issues/1730","number":1730,"state":"open","locked":false,"title":"Fixed a compilation issue in PMP's border_halfedges()","user":{"login":"MaelRL","id":5074170,"avatar_url":"https://avatars.githubusercontent.com/u/5074170?v=3","gravatar_id":"","url":"https://api.github.com/users/MaelRL","html_url":"https://github.com/MaelRL","followers_url":"https://api.github.com/users/MaelRL/followers","following_url":"https://api.github.com/users/MaelRL/following{/other_user}","gists_url":"https://api.github.com/users/MaelRL/gists{/gist_id}","starred_url":"https://api.github.com/users/MaelRL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaelRL/subscriptions","organizations_url":"https://api.github.com/users/MaelRL/orgs","repos_url":"https://api.github.com/users/MaelRL/repos","events_url":"https://api.github.com/users/MaelRL/events{/privacy}","received_events_url":"https://api.github.com/users/MaelRL/received_events","type":"User","site_admin":false},"body":"This PR fixes a compilation error in `border_halfedges()` of `PMP`, which appeared if a face index map was not provided in named parameters, nor as an internal property map.\r\n\r\nNote that it still requires the Polygon mesh to have a dummy that matches `boost::property_map<PolygonMesh, boost::face_index_t>` otherwise the `property_map_selector` will not compile.","created_at":"2016-12-01T11:11:46Z","updated_at":"2016-12-01T11:46:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c7656ecae8d33f6435bd5ecd94eef73c5f64687c","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/CGAL/cgal/milestones/18","html_url":"https://github.com/CGAL/cgal/milestones/4.10-beta","labels_url":"https://api.github.com/repos/CGAL/cgal/milestones/18/labels","id":1878697,"number":18,"title":"4.10-beta","description":"","creator":{"login":"lrineau","id":5746675,"avatar_url":"https://avatars.githubusercontent.com/u/5746675?v=3","gravatar_id":"","url":"https://api.github.com/users/lrineau","html_url":"https://github.com/lrineau","followers_url":"https://api.github.com/users/lrineau/followers","following_url":"https://api.github.com/users/lrineau/following{/other_user}","gists_url":"https://api.github.com/users/lrineau/gists{/gist_id}","starred_url":"https://api.github.com/users/lrineau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lrineau/subscriptions","organizations_url":"https://api.github.com/users/lrineau/orgs","repos_url":"https://api.github.com/users/lrineau/repos","events_url":"https://api.github.com/users/lrineau/events{/privacy}","received_events_url":"https://api.github.com/users/lrineau/received_events","type":"User","site_admin":false},"open_issues":97,"closed_issues":214,"state":"open","created_at":"2016-07-12T15:28:34Z","updated_at":"2016-12-01T11:20:40Z","due_on":"2017-01-14T23:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/CGAL/cgal/pulls/1730/commits","review_comments_url":"https://api.github.com/repos/CGAL/cgal/pulls/1730/comments","review_comment_url":"https://api.github.com/repos/CGAL/cgal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CGAL/cgal/issues/1730/comments","statuses_url":"https://api.github.com/repos/CGAL/cgal/statuses/bfbba261242cf5f988b91b4cb4506eeddeba00b1","head":{"label":"MaelRL:PMP-Fix_border_halfedges_compilation","ref":"PMP-Fix_border_halfedges_compilation","sha":"bfbba261242cf5f988b91b4cb4506eeddeba00b1","user":{"login":"MaelRL","id":5074170,"avatar_url":"https://avatars.githubusercontent.com/u/5074170?v=3","gravatar_id":"","url":"https://api.github.com/users/MaelRL","html_url":"https://github.com/MaelRL","followers_url":"https://api.github.com/users/MaelRL/followers","following_url":"https://api.github.com/users/MaelRL/following{/other_user}","gists_url":"https://api.github.com/users/MaelRL/gists{/gist_id}","starred_url":"https://api.github.com/users/MaelRL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaelRL/subscriptions","organizations_url":"https://api.github.com/users/MaelRL/orgs","repos_url":"https://api.github.com/users/MaelRL/repos","events_url":"https://api.github.com/users/MaelRL/events{/privacy}","received_events_url":"https://api.github.com/users/MaelRL/received_events","type":"User","site_admin":false},"repo":{"id":43819159,"name":"cgal","full_name":"MaelRL/cgal","owner":{"login":"MaelRL","id":5074170,"avatar_url":"https://avatars.githubusercontent.com/u/5074170?v=3","gravatar_id":"","url":"https://api.github.com/users/MaelRL","html_url":"https://github.com/MaelRL","followers_url":"https://api.github.com/users/MaelRL/followers","following_url":"https://api.github.com/users/MaelRL/following{/other_user}","gists_url":"https://api.github.com/users/MaelRL/gists{/gist_id}","starred_url":"https://api.github.com/users/MaelRL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaelRL/subscriptions","organizations_url":"https://api.github.com/users/MaelRL/orgs","repos_url":"https://api.github.com/users/MaelRL/repos","events_url":"https://api.github.com/users/MaelRL/events{/privacy}","received_events_url":"https://api.github.com/users/MaelRL/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MaelRL/cgal","description":"The public CGAL repository","fork":true,"url":"https://api.github.com/repos/MaelRL/cgal","forks_url":"https://api.github.com/repos/MaelRL/cgal/forks","keys_url":"https://api.github.com/repos/MaelRL/cgal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MaelRL/cgal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MaelRL/cgal/teams","hooks_url":"https://api.github.com/repos/MaelRL/cgal/hooks","issue_events_url":"https://api.github.com/repos/MaelRL/cgal/issues/events{/number}","events_url":"https://api.github.com/repos/MaelRL/cgal/events","assignees_url":"https://api.github.com/repos/MaelRL/cgal/assignees{/user}","branches_url":"https://api.github.com/repos/MaelRL/cgal/branches{/branch}","tags_url":"https://api.github.com/repos/MaelRL/cgal/tags","blobs_url":"https://api.github.com/repos/MaelRL/cgal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MaelRL/cgal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MaelRL/cgal/git/refs{/sha}","trees_url":"https://api.github.com/repos/MaelRL/cgal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MaelRL/cgal/statuses/{sha}","languages_url":"https://api.github.com/repos/MaelRL/cgal/languages","stargazers_url":"https://api.github.com/repos/MaelRL/cgal/stargazers","contributors_url":"https://api.github.com/repos/MaelRL/cgal/contributors","subscribers_url":"https://api.github.com/repos/MaelRL/cgal/subscribers","subscription_url":"https://api.github.com/repos/MaelRL/cgal/subscription","commits_url":"https://api.github.com/repos/MaelRL/cgal/commits{/sha}","git_commits_url":"https://api.github.com/repos/MaelRL/cgal/git/commits{/sha}","comments_url":"https://api.github.com/repos/MaelRL/cgal/comments{/number}","issue_comment_url":"https://api.github.com/repos/MaelRL/cgal/issues/comments{/number}","contents_url":"https://api.github.com/repos/MaelRL/cgal/contents/{+path}","compare_url":"https://api.github.com/repos/MaelRL/cgal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MaelRL/cgal/merges","archive_url":"https://api.github.com/repos/MaelRL/cgal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MaelRL/cgal/downloads","issues_url":"https://api.github.com/repos/MaelRL/cgal/issues{/number}","pulls_url":"https://api.github.com/repos/MaelRL/cgal/pulls{/number}","milestones_url":"https://api.github.com/repos/MaelRL/cgal/milestones{/number}","notifications_url":"https://api.github.com/repos/MaelRL/cgal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MaelRL/cgal/labels{/name}","releases_url":"https://api.github.com/repos/MaelRL/cgal/releases{/id}","deployments_url":"https://api.github.com/repos/MaelRL/cgal/deployments","created_at":"2015-10-07T13:55:24Z","updated_at":"2016-10-21T15:20:37Z","pushed_at":"2016-12-01T11:04:56Z","git_url":"git://github.com/MaelRL/cgal.git","ssh_url":"git@github.com:MaelRL/cgal.git","clone_url":"https://github.com/MaelRL/cgal.git","svn_url":"https://github.com/MaelRL/cgal","homepage":"http://www.cgal.org","size":526828,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"CGAL:master","ref":"master","sha":"b37a948ec54247774ca048c0364d33b58794cf99","user":{"login":"CGAL","id":5746664,"avatar_url":"https://avatars.githubusercontent.com/u/5746664?v=3","gravatar_id":"","url":"https://api.github.com/users/CGAL","html_url":"https://github.com/CGAL","followers_url":"https://api.github.com/users/CGAL/followers","following_url":"https://api.github.com/users/CGAL/following{/other_user}","gists_url":"https://api.github.com/users/CGAL/gists{/gist_id}","starred_url":"https://api.github.com/users/CGAL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CGAL/subscriptions","organizations_url":"https://api.github.com/users/CGAL/orgs","repos_url":"https://api.github.com/users/CGAL/repos","events_url":"https://api.github.com/users/CGAL/events{/privacy}","received_events_url":"https://api.github.com/users/CGAL/received_events","type":"Organization","site_admin":false},"repo":{"id":24677392,"name":"cgal","full_name":"CGAL/cgal","owner":{"login":"CGAL","id":5746664,"avatar_url":"https://avatars.githubusercontent.com/u/5746664?v=3","gravatar_id":"","url":"https://api.github.com/users/CGAL","html_url":"https://github.com/CGAL","followers_url":"https://api.github.com/users/CGAL/followers","following_url":"https://api.github.com/users/CGAL/following{/other_user}","gists_url":"https://api.github.com/users/CGAL/gists{/gist_id}","starred_url":"https://api.github.com/users/CGAL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CGAL/subscriptions","organizations_url":"https://api.github.com/users/CGAL/orgs","repos_url":"https://api.github.com/users/CGAL/repos","events_url":"https://api.github.com/users/CGAL/events{/privacy}","received_events_url":"https://api.github.com/users/CGAL/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CGAL/cgal","description":"The public CGAL repository, see the README below","fork":false,"url":"https://api.github.com/repos/CGAL/cgal","forks_url":"https://api.github.com/repos/CGAL/cgal/forks","keys_url":"https://api.github.com/repos/CGAL/cgal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CGAL/cgal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CGAL/cgal/teams","hooks_url":"https://api.github.com/repos/CGAL/cgal/hooks","issue_events_url":"https://api.github.com/repos/CGAL/cgal/issues/events{/number}","events_url":"https://api.github.com/repos/CGAL/cgal/events","assignees_url":"https://api.github.com/repos/CGAL/cgal/assignees{/user}","branches_url":"https://api.github.com/repos/CGAL/cgal/branches{/branch}","tags_url":"https://api.github.com/repos/CGAL/cgal/tags","blobs_url":"https://api.github.com/repos/CGAL/cgal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CGAL/cgal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CGAL/cgal/git/refs{/sha}","trees_url":"https://api.github.com/repos/CGAL/cgal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CGAL/cgal/statuses/{sha}","languages_url":"https://api.github.com/repos/CGAL/cgal/languages","stargazers_url":"https://api.github.com/repos/CGAL/cgal/stargazers","contributors_url":"https://api.github.com/repos/CGAL/cgal/contributors","subscribers_url":"https://api.github.com/repos/CGAL/cgal/subscribers","subscription_url":"https://api.github.com/repos/CGAL/cgal/subscription","commits_url":"https://api.github.com/repos/CGAL/cgal/commits{/sha}","git_commits_url":"https://api.github.com/repos/CGAL/cgal/git/commits{/sha}","comments_url":"https://api.github.com/repos/CGAL/cgal/comments{/number}","issue_comment_url":"https://api.github.com/repos/CGAL/cgal/issues/comments{/number}","contents_url":"https://api.github.com/repos/CGAL/cgal/contents/{+path}","compare_url":"https://api.github.com/repos/CGAL/cgal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CGAL/cgal/merges","archive_url":"https://api.github.com/repos/CGAL/cgal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CGAL/cgal/downloads","issues_url":"https://api.github.com/repos/CGAL/cgal/issues{/number}","pulls_url":"https://api.github.com/repos/CGAL/cgal/pulls{/number}","milestones_url":"https://api.github.com/repos/CGAL/cgal/milestones{/number}","notifications_url":"https://api.github.com/repos/CGAL/cgal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CGAL/cgal/labels{/name}","releases_url":"https://api.github.com/repos/CGAL/cgal/releases{/id}","deployments_url":"https://api.github.com/repos/CGAL/cgal/deployments","created_at":"2014-10-01T12:22:47Z","updated_at":"2016-11-30T03:04:18Z","pushed_at":"2016-12-01T11:11:46Z","git_url":"git://github.com/CGAL/cgal.git","ssh_url":"git@github.com:CGAL/cgal.git","clone_url":"https://github.com/CGAL/cgal.git","svn_url":"https://github.com/CGAL/cgal","homepage":"https://github.com/CGAL/cgal#readme","size":566018,"stargazers_count":406,"watchers_count":406,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":192,"mirror_url":null,"open_issues_count":197,"forks":192,"open_issues":197,"watchers":406,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CGAL/cgal/pulls/1730"},"html":{"href":"https://github.com/CGAL/cgal/pull/1730"},"issue":{"href":"https://api.github.com/repos/CGAL/cgal/issues/1730"},"comments":{"href":"https://api.github.com/repos/CGAL/cgal/issues/1730/comments"},"review_comments":{"href":"https://api.github.com/repos/CGAL/cgal/pulls/1730/comments"},"review_comment":{"href":"https://api.github.com/repos/CGAL/cgal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CGAL/cgal/pulls/1730/commits"},"statuses":{"href":"https://api.github.com/repos/CGAL/cgal/statuses/bfbba261242cf5f988b91b4cb4506eeddeba00b1"}}}}
{"actor":{"display_login":"MaelRL"}}