{"action":"created","comment":{"url":"https://api.github.com/repos/locationtech/geomesa/pulls/comments/55878815","id":55878815,"diff_hunk":"@@ -128,8 +128,10 @@ class LiveKafkaConsumerFeatureSource(entry: ContentEntry,\n     while (running.get) {\n       queue.take() match {\n         case update: CreateOrUpdate =>\n-          fireEvent(KafkaFeatureEvent.changed(this, update.feature))\n-          featureCache.createOrUpdateFeature(update)\n+          if(query.getFilter.evaluate(update.feature)) {","path":"geomesa-kafka/geomesa-kafka-datastore/src/main/scala/org/locationtech/geomesa/kafka/LiveKafkaConsumerFeatureSource.scala","position":15,"original_position":15,"commit_id":"9769385e7ec4cf5c41ebf490b963d57aa84a330f","original_commit_id":"9769385e7ec4cf5c41ebf490b963d57aa84a330f","user":{"login":"cne1x","id":1149270,"avatar_url":"https://avatars.githubusercontent.com/u/1149270?v=3","gravatar_id":"","url":"https://api.github.com/users/cne1x","html_url":"https://github.com/cne1x","followers_url":"https://api.github.com/users/cne1x/followers","following_url":"https://api.github.com/users/cne1x/following{/other_user}","gists_url":"https://api.github.com/users/cne1x/gists{/gist_id}","starred_url":"https://api.github.com/users/cne1x/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cne1x/subscriptions","organizations_url":"https://api.github.com/users/cne1x/orgs","repos_url":"https://api.github.com/users/cne1x/repos","events_url":"https://api.github.com/users/cne1x/events{/privacy}","received_events_url":"https://api.github.com/users/cne1x/received_events","type":"User","site_admin":false},"body":"Would this same filter check also apply to deletes?","created_at":"2016-03-11T19:47:19Z","updated_at":"2016-03-11T19:47:19Z","html_url":"https://github.com/locationtech/geomesa/pull/833#discussion_r55878815","pull_request_url":"https://api.github.com/repos/locationtech/geomesa/pulls/833","_links":{"self":{"href":"https://api.github.com/repos/locationtech/geomesa/pulls/comments/55878815"},"html":{"href":"https://github.com/locationtech/geomesa/pull/833#discussion_r55878815"},"pull_request":{"href":"https://api.github.com/repos/locationtech/geomesa/pulls/833"}}},"pull_request":{"url":"https://api.github.com/repos/locationtech/geomesa/pulls/833","id":62590808,"html_url":"https://github.com/locationtech/geomesa/pull/833","diff_url":"https://github.com/locationtech/geomesa/pull/833.diff","patch_url":"https://github.com/locationtech/geomesa/pull/833.patch","issue_url":"https://api.github.com/repos/locationtech/geomesa/issues/833","number":833,"state":"open","locked":false,"title":"GEOMESA-1130 Users of KafkaDataStore should be able to specify a filt…","user":{"login":"anthonyccri","id":893732,"avatar_url":"https://avatars.githubusercontent.com/u/893732?v=3","gravatar_id":"","url":"https://api.github.com/users/anthonyccri","html_url":"https://github.com/anthonyccri","followers_url":"https://api.github.com/users/anthonyccri/followers","following_url":"https://api.github.com/users/anthonyccri/following{/other_user}","gists_url":"https://api.github.com/users/anthonyccri/gists{/gist_id}","starred_url":"https://api.github.com/users/anthonyccri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anthonyccri/subscriptions","organizations_url":"https://api.github.com/users/anthonyccri/orgs","repos_url":"https://api.github.com/users/anthonyccri/repos","events_url":"https://api.github.com/users/anthonyccri/events{/privacy}","received_events_url":"https://api.github.com/users/anthonyccri/received_events","type":"User","site_admin":false},"body":"…er when consuming features\r\n\r\n* Added a method to the data store to subscribe to a feature source with\r\n  a filter.\r\n\r\nSigned-off-by: Anthony Fox <anthonyfox@ccri.com>","created_at":"2016-03-11T19:30:49Z","updated_at":"2016-03-11T19:47:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dcfaab9bb7a7e52942afae3601e42e0960307f9b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/locationtech/geomesa/pulls/833/commits","review_comments_url":"https://api.github.com/repos/locationtech/geomesa/pulls/833/comments","review_comment_url":"https://api.github.com/repos/locationtech/geomesa/pulls/comments{/number}","comments_url":"https://api.github.com/repos/locationtech/geomesa/issues/833/comments","statuses_url":"https://api.github.com/repos/locationtech/geomesa/statuses/9769385e7ec4cf5c41ebf490b963d57aa84a330f","head":{"label":"locationtech:fcr_kafka_filters_on_connection","ref":"fcr_kafka_filters_on_connection","sha":"9769385e7ec4cf5c41ebf490b963d57aa84a330f","user":{"login":"locationtech","id":1991411,"avatar_url":"https://avatars.githubusercontent.com/u/1991411?v=3","gravatar_id":"","url":"https://api.github.com/users/locationtech","html_url":"https://github.com/locationtech","followers_url":"https://api.github.com/users/locationtech/followers","following_url":"https://api.github.com/users/locationtech/following{/other_user}","gists_url":"https://api.github.com/users/locationtech/gists{/gist_id}","starred_url":"https://api.github.com/users/locationtech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/locationtech/subscriptions","organizations_url":"https://api.github.com/users/locationtech/orgs","repos_url":"https://api.github.com/users/locationtech/repos","events_url":"https://api.github.com/users/locationtech/events{/privacy}","received_events_url":"https://api.github.com/users/locationtech/received_events","type":"Organization","site_admin":false},"repo":{"id":13226069,"name":"geomesa","full_name":"locationtech/geomesa","owner":{"login":"locationtech","id":1991411,"avatar_url":"https://avatars.githubusercontent.com/u/1991411?v=3","gravatar_id":"","url":"https://api.github.com/users/locationtech","html_url":"https://github.com/locationtech","followers_url":"https://api.github.com/users/locationtech/followers","following_url":"https://api.github.com/users/locationtech/following{/other_user}","gists_url":"https://api.github.com/users/locationtech/gists{/gist_id}","starred_url":"https://api.github.com/users/locationtech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/locationtech/subscriptions","organizations_url":"https://api.github.com/users/locationtech/orgs","repos_url":"https://api.github.com/users/locationtech/repos","events_url":"https://api.github.com/users/locationtech/events{/privacy}","received_events_url":"https://api.github.com/users/locationtech/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/locationtech/geomesa","description":"GeoMesa is a suite of tools for working with big geo-spatial data in a distributed fashion.","fork":false,"url":"https://api.github.com/repos/locationtech/geomesa","forks_url":"https://api.github.com/repos/locationtech/geomesa/forks","keys_url":"https://api.github.com/repos/locationtech/geomesa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/locationtech/geomesa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/locationtech/geomesa/teams","hooks_url":"https://api.github.com/repos/locationtech/geomesa/hooks","issue_events_url":"https://api.github.com/repos/locationtech/geomesa/issues/events{/number}","events_url":"https://api.github.com/repos/locationtech/geomesa/events","assignees_url":"https://api.github.com/repos/locationtech/geomesa/assignees{/user}","branches_url":"https://api.github.com/repos/locationtech/geomesa/branches{/branch}","tags_url":"https://api.github.com/repos/locationtech/geomesa/tags","blobs_url":"https://api.github.com/repos/locationtech/geomesa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/locationtech/geomesa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/locationtech/geomesa/git/refs{/sha}","trees_url":"https://api.github.com/repos/locationtech/geomesa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/locationtech/geomesa/statuses/{sha}","languages_url":"https://api.github.com/repos/locationtech/geomesa/languages","stargazers_url":"https://api.github.com/repos/locationtech/geomesa/stargazers","contributors_url":"https://api.github.com/repos/locationtech/geomesa/contributors","subscribers_url":"https://api.github.com/repos/locationtech/geomesa/subscribers","subscription_url":"https://api.github.com/repos/locationtech/geomesa/subscription","commits_url":"https://api.github.com/repos/locationtech/geomesa/commits{/sha}","git_commits_url":"https://api.github.com/repos/locationtech/geomesa/git/commits{/sha}","comments_url":"https://api.github.com/repos/locationtech/geomesa/comments{/number}","issue_comment_url":"https://api.github.com/repos/locationtech/geomesa/issues/comments{/number}","contents_url":"https://api.github.com/repos/locationtech/geomesa/contents/{+path}","compare_url":"https://api.github.com/repos/locationtech/geomesa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/locationtech/geomesa/merges","archive_url":"https://api.github.com/repos/locationtech/geomesa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/locationtech/geomesa/downloads","issues_url":"https://api.github.com/repos/locationtech/geomesa/issues{/number}","pulls_url":"https://api.github.com/repos/locationtech/geomesa/pulls{/number}","milestones_url":"https://api.github.com/repos/locationtech/geomesa/milestones{/number}","notifications_url":"https://api.github.com/repos/locationtech/geomesa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/locationtech/geomesa/labels{/name}","releases_url":"https://api.github.com/repos/locationtech/geomesa/releases{/id}","deployments_url":"https://api.github.com/repos/locationtech/geomesa/deployments","created_at":"2013-09-30T20:13:46Z","updated_at":"2016-03-10T21:00:17Z","pushed_at":"2016-03-11T19:30:50Z","git_url":"git://github.com/locationtech/geomesa.git","ssh_url":"git@github.com:locationtech/geomesa.git","clone_url":"https://github.com/locationtech/geomesa.git","svn_url":"https://github.com/locationtech/geomesa","homepage":"https://www.locationtech.org/projects/technology.geomesa","size":36350,"stargazers_count":150,"watchers_count":150,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":79,"mirror_url":null,"open_issues_count":6,"forks":79,"open_issues":6,"watchers":150,"default_branch":"master"}},"base":{"label":"locationtech:master","ref":"master","sha":"b433bcbead11e064ffa6d12df2290ec2d0e0eb81","user":{"login":"locationtech","id":1991411,"avatar_url":"https://avatars.githubusercontent.com/u/1991411?v=3","gravatar_id":"","url":"https://api.github.com/users/locationtech","html_url":"https://github.com/locationtech","followers_url":"https://api.github.com/users/locationtech/followers","following_url":"https://api.github.com/users/locationtech/following{/other_user}","gists_url":"https://api.github.com/users/locationtech/gists{/gist_id}","starred_url":"https://api.github.com/users/locationtech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/locationtech/subscriptions","organizations_url":"https://api.github.com/users/locationtech/orgs","repos_url":"https://api.github.com/users/locationtech/repos","events_url":"https://api.github.com/users/locationtech/events{/privacy}","received_events_url":"https://api.github.com/users/locationtech/received_events","type":"Organization","site_admin":false},"repo":{"id":13226069,"name":"geomesa","full_name":"locationtech/geomesa","owner":{"login":"locationtech","id":1991411,"avatar_url":"https://avatars.githubusercontent.com/u/1991411?v=3","gravatar_id":"","url":"https://api.github.com/users/locationtech","html_url":"https://github.com/locationtech","followers_url":"https://api.github.com/users/locationtech/followers","following_url":"https://api.github.com/users/locationtech/following{/other_user}","gists_url":"https://api.github.com/users/locationtech/gists{/gist_id}","starred_url":"https://api.github.com/users/locationtech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/locationtech/subscriptions","organizations_url":"https://api.github.com/users/locationtech/orgs","repos_url":"https://api.github.com/users/locationtech/repos","events_url":"https://api.github.com/users/locationtech/events{/privacy}","received_events_url":"https://api.github.com/users/locationtech/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/locationtech/geomesa","description":"GeoMesa is a suite of tools for working with big geo-spatial data in a distributed fashion.","fork":false,"url":"https://api.github.com/repos/locationtech/geomesa","forks_url":"https://api.github.com/repos/locationtech/geomesa/forks","keys_url":"https://api.github.com/repos/locationtech/geomesa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/locationtech/geomesa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/locationtech/geomesa/teams","hooks_url":"https://api.github.com/repos/locationtech/geomesa/hooks","issue_events_url":"https://api.github.com/repos/locationtech/geomesa/issues/events{/number}","events_url":"https://api.github.com/repos/locationtech/geomesa/events","assignees_url":"https://api.github.com/repos/locationtech/geomesa/assignees{/user}","branches_url":"https://api.github.com/repos/locationtech/geomesa/branches{/branch}","tags_url":"https://api.github.com/repos/locationtech/geomesa/tags","blobs_url":"https://api.github.com/repos/locationtech/geomesa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/locationtech/geomesa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/locationtech/geomesa/git/refs{/sha}","trees_url":"https://api.github.com/repos/locationtech/geomesa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/locationtech/geomesa/statuses/{sha}","languages_url":"https://api.github.com/repos/locationtech/geomesa/languages","stargazers_url":"https://api.github.com/repos/locationtech/geomesa/stargazers","contributors_url":"https://api.github.com/repos/locationtech/geomesa/contributors","subscribers_url":"https://api.github.com/repos/locationtech/geomesa/subscribers","subscription_url":"https://api.github.com/repos/locationtech/geomesa/subscription","commits_url":"https://api.github.com/repos/locationtech/geomesa/commits{/sha}","git_commits_url":"https://api.github.com/repos/locationtech/geomesa/git/commits{/sha}","comments_url":"https://api.github.com/repos/locationtech/geomesa/comments{/number}","issue_comment_url":"https://api.github.com/repos/locationtech/geomesa/issues/comments{/number}","contents_url":"https://api.github.com/repos/locationtech/geomesa/contents/{+path}","compare_url":"https://api.github.com/repos/locationtech/geomesa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/locationtech/geomesa/merges","archive_url":"https://api.github.com/repos/locationtech/geomesa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/locationtech/geomesa/downloads","issues_url":"https://api.github.com/repos/locationtech/geomesa/issues{/number}","pulls_url":"https://api.github.com/repos/locationtech/geomesa/pulls{/number}","milestones_url":"https://api.github.com/repos/locationtech/geomesa/milestones{/number}","notifications_url":"https://api.github.com/repos/locationtech/geomesa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/locationtech/geomesa/labels{/name}","releases_url":"https://api.github.com/repos/locationtech/geomesa/releases{/id}","deployments_url":"https://api.github.com/repos/locationtech/geomesa/deployments","created_at":"2013-09-30T20:13:46Z","updated_at":"2016-03-10T21:00:17Z","pushed_at":"2016-03-11T19:30:50Z","git_url":"git://github.com/locationtech/geomesa.git","ssh_url":"git@github.com:locationtech/geomesa.git","clone_url":"https://github.com/locationtech/geomesa.git","svn_url":"https://github.com/locationtech/geomesa","homepage":"https://www.locationtech.org/projects/technology.geomesa","size":36350,"stargazers_count":150,"watchers_count":150,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":79,"mirror_url":null,"open_issues_count":6,"forks":79,"open_issues":6,"watchers":150,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/locationtech/geomesa/pulls/833"},"html":{"href":"https://github.com/locationtech/geomesa/pull/833"},"issue":{"href":"https://api.github.com/repos/locationtech/geomesa/issues/833"},"comments":{"href":"https://api.github.com/repos/locationtech/geomesa/issues/833/comments"},"review_comments":{"href":"https://api.github.com/repos/locationtech/geomesa/pulls/833/comments"},"review_comment":{"href":"https://api.github.com/repos/locationtech/geomesa/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/locationtech/geomesa/pulls/833/commits"},"statuses":{"href":"https://api.github.com/repos/locationtech/geomesa/statuses/9769385e7ec4cf5c41ebf490b963d57aa84a330f"}}}}