{"action":"created","issue":{"url":"https://api.github.com/repos/babca/python-gsmmodem/issues/1","repository_url":"https://api.github.com/repos/babca/python-gsmmodem","labels_url":"https://api.github.com/repos/babca/python-gsmmodem/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/babca/python-gsmmodem/issues/1/comments","events_url":"https://api.github.com/repos/babca/python-gsmmodem/issues/1/events","html_url":"https://github.com/babca/python-gsmmodem/pull/1","id":172257633,"number":1,"title":"2 Fixes: Support for no callback specified, fix no +CLAC support","user":{"login":"bennyslbs","id":11199591,"avatar_url":"https://avatars.githubusercontent.com/u/11199591?v=3","gravatar_id":"","url":"https://api.github.com/users/bennyslbs","html_url":"https://github.com/bennyslbs","followers_url":"https://api.github.com/users/bennyslbs/followers","following_url":"https://api.github.com/users/bennyslbs/following{/other_user}","gists_url":"https://api.github.com/users/bennyslbs/gists{/gist_id}","starred_url":"https://api.github.com/users/bennyslbs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bennyslbs/subscriptions","organizations_url":"https://api.github.com/users/bennyslbs/orgs","repos_url":"https://api.github.com/users/bennyslbs/repos","events_url":"https://api.github.com/users/bennyslbs/events{/privacy}","received_events_url":"https://api.github.com/users/bennyslbs/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-08-20T06:54:21Z","updated_at":"2016-08-20T14:39:50Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/babca/python-gsmmodem/pulls/1","html_url":"https://github.com/babca/python-gsmmodem/pull/1","diff_url":"https://github.com/babca/python-gsmmodem/pull/1.diff","patch_url":"https://github.com/babca/python-gsmmodem/pull/1.patch"},"body":"I have fixed it at least for my usecase:\r\nSending and receiving SMSes with/without getting SMS Status reports (failed without grapping the status report)\r\nIt is working on SIM800L, don't support +CLAC."},"comment":{"url":"https://api.github.com/repos/babca/python-gsmmodem/issues/comments/241203705","html_url":"https://github.com/babca/python-gsmmodem/pull/1#issuecomment-241203705","issue_url":"https://api.github.com/repos/babca/python-gsmmodem/issues/1","id":241203705,"user":{"login":"bennyslbs","id":11199591,"avatar_url":"https://avatars.githubusercontent.com/u/11199591?v=3","gravatar_id":"","url":"https://api.github.com/users/bennyslbs","html_url":"https://github.com/bennyslbs","followers_url":"https://api.github.com/users/bennyslbs/followers","following_url":"https://api.github.com/users/bennyslbs/following{/other_user}","gists_url":"https://api.github.com/users/bennyslbs/gists{/gist_id}","starred_url":"https://api.github.com/users/bennyslbs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bennyslbs/subscriptions","organizations_url":"https://api.github.com/users/bennyslbs/orgs","repos_url":"https://api.github.com/users/bennyslbs/repos","events_url":"https://api.github.com/users/bennyslbs/events{/privacy}","received_events_url":"https://api.github.com/users/bennyslbs/received_events","type":"User","site_admin":false},"created_at":"2016-08-20T14:39:50Z","updated_at":"2016-08-20T14:39:50Z","body":"Hi @babca \r\n_handleSmsStatusReportTe (function I have created prior to the merge) uses smsStatusReportCallback in the last line without check.\r\n\r\nI have just checked the code, and I think it is the only location where the _placeholderCallback can be called from are from self.incomingCallCallback calls and in my function.\r\n\r\nI think the way with the _placeholderCallback gives that less checks are needed in the code. Further it gives easy access to place a debug message in that function to see when a function is \"missing\".\r\n\r\nIn change from paolo-losi (4ce4081) _placeholderCallback is used in line 136, but method have been removed.\r\n\r\nBr,\r\nBenny\r\n"}}
{"actor":{"display_login":"bennyslbs"}}