{"action":"opened","number":55,"pull_request":{"url":"https://api.github.com/repos/job/aclhound/pulls/55","id":65543302,"html_url":"https://github.com/job/aclhound/pull/55","diff_url":"https://github.com/job/aclhound/pull/55.diff","patch_url":"https://github.com/job/aclhound/pull/55.patch","issue_url":"https://api.github.com/repos/job/aclhound/issues/55","number":55,"state":"open","locked":false,"title":"Fix test docs and feedback","user":{"login":"jzohrab","id":1637133,"avatar_url":"https://avatars.githubusercontent.com/u/1637133?v=3","gravatar_id":"","url":"https://api.github.com/users/jzohrab","html_url":"https://github.com/jzohrab","followers_url":"https://api.github.com/users/jzohrab/followers","following_url":"https://api.github.com/users/jzohrab/following{/other_user}","gists_url":"https://api.github.com/users/jzohrab/gists{/gist_id}","starred_url":"https://api.github.com/users/jzohrab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jzohrab/subscriptions","organizations_url":"https://api.github.com/users/jzohrab/orgs","repos_url":"https://api.github.com/users/jzohrab/repos","events_url":"https://api.github.com/users/jzohrab/events{/privacy}","received_events_url":"https://api.github.com/users/jzohrab/received_events","type":"User","site_admin":false},"body":"Addresses https://github.com/job/aclhound/issues/53\r\n\r\nWhen a fresh project is set up following the instructions at https://github.com/job/aclhound/blob/master/INSTALL-CONFIG.md, the tests currently fail.  The python setup and install have to be done before running the tests for them to actually complete.  This updates the docs so the tests actually run.\r\n\r\nThis PR also makes a small code change: currently, the `tests\\test_regression.py` Capturing() class swallows exception input, making it difficult to diagnose issues; e.g.:\r\n\r\n```\r\n======================================================================\r\nERROR: test_01__build_ios (tests.test_regression.TestAclhound)\r\n----------------------------------------------------------------------\r\nTraceback (most recent call last):\r\n  File \"/Users/jzohrab/Documents/Projects/aclhound/tests/test_regression.py\", line 68, in test_01__build_ios\r\n    u'debug': False, u'jenkins': True})\r\n  File \"/Users/jzohrab/Documents/Projects/aclhound/aclhound/cli.py\", line 215, in __init__\r\n    self._settings = Settings()\r\n  File \"/Users/jzohrab/Documents/Projects/aclhound/aclhound/cli.py\", line 82, in __init__\r\n    sys.exit(2)\r\nSystemExit: 2\r\n```\r\n\r\nThe code change prints out extra information:\r\n\r\n```\r\n======================================================================\r\nFAIL: test_01__build_ios (tests.test_regression.TestAclhound)\r\n----------------------------------------------------------------------\r\nTraceback (most recent call last):\r\n  File \"/Users/jzohrab/Documents/Projects/aclhound/tests/test_regression.py\", line 74, in test_01__build_ios\r\n    self.assertNotIn('ERROR', '\\n'.join(output))\r\nAssertionError: u'ERROR' unexpectedly found in u\"ERROR: Whoops!\\nERROR: ~/.aclhound/ does not exist yet\\nHINT: possible config corruption, delete it and run 'aclhound init'\\nEXCEPTION RAISED\"\r\n    \"\"\"Fail immediately, with the given message.\"\"\"\r\n>>  raise self.failureException('u\\'ERROR\\' unexpectedly found in u\"ERROR: Whoops!\\\\nERROR: ~/.aclhound/ does not exist yet\\\\nHINT: possible config corruption, delete it and run \\'aclhound init\\'\\\\nEXCEPTION RAISED\"')\r\n```\r\n\r\nIt's not *great* but at least it tells a bit more about the error that's happened.\r\n\r\nNote that this is a misconfiguration error, so a user problem rather than a software problem, but a clearer error message doesn't hurt.\r\n\r\nNote: the tests are currently failing, I'll raise another issue for this.","created_at":"2016-04-06T21:58:09Z","updated_at":"2016-04-06T21:58:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/job/aclhound/pulls/55/commits","review_comments_url":"https://api.github.com/repos/job/aclhound/pulls/55/comments","review_comment_url":"https://api.github.com/repos/job/aclhound/pulls/comments{/number}","comments_url":"https://api.github.com/repos/job/aclhound/issues/55/comments","statuses_url":"https://api.github.com/repos/job/aclhound/statuses/566f76602eb0da71b7ff6fd93ddfa34988ce41c9","head":{"label":"jzohrab:fix_test_docs_and_feedback","ref":"fix_test_docs_and_feedback","sha":"566f76602eb0da71b7ff6fd93ddfa34988ce41c9","user":{"login":"jzohrab","id":1637133,"avatar_url":"https://avatars.githubusercontent.com/u/1637133?v=3","gravatar_id":"","url":"https://api.github.com/users/jzohrab","html_url":"https://github.com/jzohrab","followers_url":"https://api.github.com/users/jzohrab/followers","following_url":"https://api.github.com/users/jzohrab/following{/other_user}","gists_url":"https://api.github.com/users/jzohrab/gists{/gist_id}","starred_url":"https://api.github.com/users/jzohrab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jzohrab/subscriptions","organizations_url":"https://api.github.com/users/jzohrab/orgs","repos_url":"https://api.github.com/users/jzohrab/repos","events_url":"https://api.github.com/users/jzohrab/events{/privacy}","received_events_url":"https://api.github.com/users/jzohrab/received_events","type":"User","site_admin":false},"repo":{"id":55640770,"name":"aclhound","full_name":"jzohrab/aclhound","owner":{"login":"jzohrab","id":1637133,"avatar_url":"https://avatars.githubusercontent.com/u/1637133?v=3","gravatar_id":"","url":"https://api.github.com/users/jzohrab","html_url":"https://github.com/jzohrab","followers_url":"https://api.github.com/users/jzohrab/followers","following_url":"https://api.github.com/users/jzohrab/following{/other_user}","gists_url":"https://api.github.com/users/jzohrab/gists{/gist_id}","starred_url":"https://api.github.com/users/jzohrab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jzohrab/subscriptions","organizations_url":"https://api.github.com/users/jzohrab/orgs","repos_url":"https://api.github.com/users/jzohrab/repos","events_url":"https://api.github.com/users/jzohrab/events{/privacy}","received_events_url":"https://api.github.com/users/jzohrab/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jzohrab/aclhound","description":"ACLHound","fork":true,"url":"https://api.github.com/repos/jzohrab/aclhound","forks_url":"https://api.github.com/repos/jzohrab/aclhound/forks","keys_url":"https://api.github.com/repos/jzohrab/aclhound/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jzohrab/aclhound/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jzohrab/aclhound/teams","hooks_url":"https://api.github.com/repos/jzohrab/aclhound/hooks","issue_events_url":"https://api.github.com/repos/jzohrab/aclhound/issues/events{/number}","events_url":"https://api.github.com/repos/jzohrab/aclhound/events","assignees_url":"https://api.github.com/repos/jzohrab/aclhound/assignees{/user}","branches_url":"https://api.github.com/repos/jzohrab/aclhound/branches{/branch}","tags_url":"https://api.github.com/repos/jzohrab/aclhound/tags","blobs_url":"https://api.github.com/repos/jzohrab/aclhound/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jzohrab/aclhound/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jzohrab/aclhound/git/refs{/sha}","trees_url":"https://api.github.com/repos/jzohrab/aclhound/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jzohrab/aclhound/statuses/{sha}","languages_url":"https://api.github.com/repos/jzohrab/aclhound/languages","stargazers_url":"https://api.github.com/repos/jzohrab/aclhound/stargazers","contributors_url":"https://api.github.com/repos/jzohrab/aclhound/contributors","subscribers_url":"https://api.github.com/repos/jzohrab/aclhound/subscribers","subscription_url":"https://api.github.com/repos/jzohrab/aclhound/subscription","commits_url":"https://api.github.com/repos/jzohrab/aclhound/commits{/sha}","git_commits_url":"https://api.github.com/repos/jzohrab/aclhound/git/commits{/sha}","comments_url":"https://api.github.com/repos/jzohrab/aclhound/comments{/number}","issue_comment_url":"https://api.github.com/repos/jzohrab/aclhound/issues/comments{/number}","contents_url":"https://api.github.com/repos/jzohrab/aclhound/contents/{+path}","compare_url":"https://api.github.com/repos/jzohrab/aclhound/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jzohrab/aclhound/merges","archive_url":"https://api.github.com/repos/jzohrab/aclhound/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jzohrab/aclhound/downloads","issues_url":"https://api.github.com/repos/jzohrab/aclhound/issues{/number}","pulls_url":"https://api.github.com/repos/jzohrab/aclhound/pulls{/number}","milestones_url":"https://api.github.com/repos/jzohrab/aclhound/milestones{/number}","notifications_url":"https://api.github.com/repos/jzohrab/aclhound/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jzohrab/aclhound/labels{/name}","releases_url":"https://api.github.com/repos/jzohrab/aclhound/releases{/id}","deployments_url":"https://api.github.com/repos/jzohrab/aclhound/deployments","created_at":"2016-04-06T21:10:08Z","updated_at":"2016-04-06T21:10:09Z","pushed_at":"2016-04-06T21:56:09Z","git_url":"git://github.com/jzohrab/aclhound.git","ssh_url":"git@github.com:jzohrab/aclhound.git","clone_url":"https://github.com/jzohrab/aclhound.git","svn_url":"https://github.com/jzohrab/aclhound","homepage":null,"size":4583,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"job:master","ref":"master","sha":"6d0543442b631df1b045c8520f69cdecf2c6015e","user":{"login":"job","id":153816,"avatar_url":"https://avatars.githubusercontent.com/u/153816?v=3","gravatar_id":"","url":"https://api.github.com/users/job","html_url":"https://github.com/job","followers_url":"https://api.github.com/users/job/followers","following_url":"https://api.github.com/users/job/following{/other_user}","gists_url":"https://api.github.com/users/job/gists{/gist_id}","starred_url":"https://api.github.com/users/job/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/job/subscriptions","organizations_url":"https://api.github.com/users/job/orgs","repos_url":"https://api.github.com/users/job/repos","events_url":"https://api.github.com/users/job/events{/privacy}","received_events_url":"https://api.github.com/users/job/received_events","type":"User","site_admin":false},"repo":{"id":19459138,"name":"aclhound","full_name":"job/aclhound","owner":{"login":"job","id":153816,"avatar_url":"https://avatars.githubusercontent.com/u/153816?v=3","gravatar_id":"","url":"https://api.github.com/users/job","html_url":"https://github.com/job","followers_url":"https://api.github.com/users/job/followers","following_url":"https://api.github.com/users/job/following{/other_user}","gists_url":"https://api.github.com/users/job/gists{/gist_id}","starred_url":"https://api.github.com/users/job/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/job/subscriptions","organizations_url":"https://api.github.com/users/job/orgs","repos_url":"https://api.github.com/users/job/repos","events_url":"https://api.github.com/users/job/events{/privacy}","received_events_url":"https://api.github.com/users/job/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/job/aclhound","description":"ACLHound","fork":false,"url":"https://api.github.com/repos/job/aclhound","forks_url":"https://api.github.com/repos/job/aclhound/forks","keys_url":"https://api.github.com/repos/job/aclhound/keys{/key_id}","collaborators_url":"https://api.github.com/repos/job/aclhound/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/job/aclhound/teams","hooks_url":"https://api.github.com/repos/job/aclhound/hooks","issue_events_url":"https://api.github.com/repos/job/aclhound/issues/events{/number}","events_url":"https://api.github.com/repos/job/aclhound/events","assignees_url":"https://api.github.com/repos/job/aclhound/assignees{/user}","branches_url":"https://api.github.com/repos/job/aclhound/branches{/branch}","tags_url":"https://api.github.com/repos/job/aclhound/tags","blobs_url":"https://api.github.com/repos/job/aclhound/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/job/aclhound/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/job/aclhound/git/refs{/sha}","trees_url":"https://api.github.com/repos/job/aclhound/git/trees{/sha}","statuses_url":"https://api.github.com/repos/job/aclhound/statuses/{sha}","languages_url":"https://api.github.com/repos/job/aclhound/languages","stargazers_url":"https://api.github.com/repos/job/aclhound/stargazers","contributors_url":"https://api.github.com/repos/job/aclhound/contributors","subscribers_url":"https://api.github.com/repos/job/aclhound/subscribers","subscription_url":"https://api.github.com/repos/job/aclhound/subscription","commits_url":"https://api.github.com/repos/job/aclhound/commits{/sha}","git_commits_url":"https://api.github.com/repos/job/aclhound/git/commits{/sha}","comments_url":"https://api.github.com/repos/job/aclhound/comments{/number}","issue_comment_url":"https://api.github.com/repos/job/aclhound/issues/comments{/number}","contents_url":"https://api.github.com/repos/job/aclhound/contents/{+path}","compare_url":"https://api.github.com/repos/job/aclhound/compare/{base}...{head}","merges_url":"https://api.github.com/repos/job/aclhound/merges","archive_url":"https://api.github.com/repos/job/aclhound/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/job/aclhound/downloads","issues_url":"https://api.github.com/repos/job/aclhound/issues{/number}","pulls_url":"https://api.github.com/repos/job/aclhound/pulls{/number}","milestones_url":"https://api.github.com/repos/job/aclhound/milestones{/number}","notifications_url":"https://api.github.com/repos/job/aclhound/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/job/aclhound/labels{/name}","releases_url":"https://api.github.com/repos/job/aclhound/releases{/id}","deployments_url":"https://api.github.com/repos/job/aclhound/deployments","created_at":"2014-05-05T14:43:51Z","updated_at":"2016-04-04T23:25:07Z","pushed_at":"2016-04-06T21:03:21Z","git_url":"git://github.com/job/aclhound.git","ssh_url":"git@github.com:job/aclhound.git","clone_url":"https://github.com/job/aclhound.git","svn_url":"https://github.com/job/aclhound","homepage":null,"size":4584,"stargazers_count":16,"watchers_count":16,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":12,"forks":7,"open_issues":12,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/job/aclhound/pulls/55"},"html":{"href":"https://github.com/job/aclhound/pull/55"},"issue":{"href":"https://api.github.com/repos/job/aclhound/issues/55"},"comments":{"href":"https://api.github.com/repos/job/aclhound/issues/55/comments"},"review_comments":{"href":"https://api.github.com/repos/job/aclhound/pulls/55/comments"},"review_comment":{"href":"https://api.github.com/repos/job/aclhound/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/job/aclhound/pulls/55/commits"},"statuses":{"href":"https://api.github.com/repos/job/aclhound/statuses/566f76602eb0da71b7ff6fd93ddfa34988ce41c9"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":4,"additions":17,"deletions":5,"changed_files":2}}