{"action":"created","comment":{"url":"https://api.github.com/repos/Metrological/WebKitForWayland/pulls/comments/52021838","id":52021838,"diff_hunk":"@@ -1896,12 +2014,49 @@ void AppendPipeline::abort()\n \n GstFlowReturn AppendPipeline::pushNewBuffer(GstBuffer* buffer)\n {\n+    GstFlowReturn result;\n+\n     if (m_abortPending) {\n         m_pendingBuffer = adoptGRef(buffer);\n-        return GST_FLOW_OK;\n+        result = GST_FLOW_OK;\n+    } else {\n+        setAppendStage(AppendPipeline::Ongoing);\n+        TRACE_MEDIA_MESSAGE(\"pushing new buffer %p\", buffer);\n+        result = gst_app_src_push_buffer(GST_APP_SRC(appsrc()), buffer);\n     }\n-    setAppendStage(AppendPipeline::Ongoing);\n-    return gst_app_src_push_buffer(GST_APP_SRC(appsrc()), buffer);\n+\n+    return result;\n+}\n+\n+void AppendPipeline::handleEndOfAppendDataMarkNeeded()\n+{\n+    GstEvent* event = gst_event_new_custom(GST_EVENT_CUSTOM_DOWNSTREAM, gst_structure_new_empty(\"end-of-append-data-mark\"));\n+    m_appendIdMarkedInSrc = guint64(gst_event_get_seqnum(event));","path":"Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerMSE.cpp","position":348,"original_position":348,"commit_id":"e0d312c7ccd892c358c59fb0ba34baa1a3d68e60","original_commit_id":"e0d312c7ccd892c358c59fb0ba34baa1a3d68e60","user":{"login":"philn","id":34114,"avatar_url":"https://avatars.githubusercontent.com/u/34114?v=3","gravatar_id":"","url":"https://api.github.com/users/philn","html_url":"https://github.com/philn","followers_url":"https://api.github.com/users/philn/followers","following_url":"https://api.github.com/users/philn/following{/other_user}","gists_url":"https://api.github.com/users/philn/gists{/gist_id}","starred_url":"https://api.github.com/users/philn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philn/subscriptions","organizations_url":"https://api.github.com/users/philn/orgs","repos_url":"https://api.github.com/users/philn/repos","events_url":"https://api.github.com/users/philn/events{/privacy}","received_events_url":"https://api.github.com/users/philn/received_events","type":"User","site_admin":false},"body":"Please simply make this member a guint32","created_at":"2016-02-05T14:34:17Z","updated_at":"2016-02-05T14:34:17Z","html_url":"https://github.com/Metrological/WebKitForWayland/pull/21#discussion_r52021838","pull_request_url":"https://api.github.com/repos/Metrological/WebKitForWayland/pulls/21","_links":{"self":{"href":"https://api.github.com/repos/Metrological/WebKitForWayland/pulls/comments/52021838"},"html":{"href":"https://github.com/Metrological/WebKitForWayland/pull/21#discussion_r52021838"},"pull_request":{"href":"https://api.github.com/repos/Metrological/WebKitForWayland/pulls/21"}}},"pull_request":{"url":"https://api.github.com/repos/Metrological/WebKitForWayland/pulls/21","id":58434914,"html_url":"https://github.com/Metrological/WebKitForWayland/pull/21","diff_url":"https://github.com/Metrological/WebKitForWayland/pull/21.diff","patch_url":"https://github.com/Metrological/WebKitForWayland/pull/21.patch","issue_url":"https://api.github.com/repos/Metrological/WebKitForWayland/issues/21","number":21,"state":"open","locked":false,"title":"[GStreamer][MSE] Removes the use of timeouts to detect data starve and last sample stages","user":{"login":"calvaris","id":1021526,"avatar_url":"https://avatars.githubusercontent.com/u/1021526?v=3","gravatar_id":"","url":"https://api.github.com/users/calvaris","html_url":"https://github.com/calvaris","followers_url":"https://api.github.com/users/calvaris/followers","following_url":"https://api.github.com/users/calvaris/following{/other_user}","gists_url":"https://api.github.com/users/calvaris/gists{/gist_id}","starred_url":"https://api.github.com/users/calvaris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calvaris/subscriptions","organizations_url":"https://api.github.com/users/calvaris/orgs","repos_url":"https://api.github.com/users/calvaris/repos","events_url":"https://api.github.com/users/calvaris/events{/privacy}","received_events_url":"https://api.github.com/users/calvaris/received_events","type":"User","site_admin":false},"body":"The timeouts were kept and raising an error and an ASSERT to be able to detect any possible regressions in the near future. If this goes were, we can remove the timeouts.\r\n\r\nThis implementation was based on an initial one by @eocanha and I corrected the pending issues.","created_at":"2016-02-05T14:27:52Z","updated_at":"2016-02-05T14:34:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b675a33a48515037d8d6bb25a544630b062723a2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Metrological/WebKitForWayland/pulls/21/commits","review_comments_url":"https://api.github.com/repos/Metrological/WebKitForWayland/pulls/21/comments","review_comment_url":"https://api.github.com/repos/Metrological/WebKitForWayland/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Metrological/WebKitForWayland/issues/21/comments","statuses_url":"https://api.github.com/repos/Metrological/WebKitForWayland/statuses/e0d312c7ccd892c358c59fb0ba34baa1a3d68e60","head":{"label":"Metrological:calvaris/timeouts","ref":"calvaris/timeouts","sha":"e0d312c7ccd892c358c59fb0ba34baa1a3d68e60","user":{"login":"Metrological","id":5675691,"avatar_url":"https://avatars.githubusercontent.com/u/5675691?v=3","gravatar_id":"","url":"https://api.github.com/users/Metrological","html_url":"https://github.com/Metrological","followers_url":"https://api.github.com/users/Metrological/followers","following_url":"https://api.github.com/users/Metrological/following{/other_user}","gists_url":"https://api.github.com/users/Metrological/gists{/gist_id}","starred_url":"https://api.github.com/users/Metrological/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Metrological/subscriptions","organizations_url":"https://api.github.com/users/Metrological/orgs","repos_url":"https://api.github.com/users/Metrological/repos","events_url":"https://api.github.com/users/Metrological/events{/privacy}","received_events_url":"https://api.github.com/users/Metrological/received_events","type":"Organization","site_admin":false},"repo":{"id":28195272,"name":"WebKitForWayland","full_name":"Metrological/WebKitForWayland","owner":{"login":"Metrological","id":5675691,"avatar_url":"https://avatars.githubusercontent.com/u/5675691?v=3","gravatar_id":"","url":"https://api.github.com/users/Metrological","html_url":"https://github.com/Metrological","followers_url":"https://api.github.com/users/Metrological/followers","following_url":"https://api.github.com/users/Metrological/following{/other_user}","gists_url":"https://api.github.com/users/Metrological/gists{/gist_id}","starred_url":"https://api.github.com/users/Metrological/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Metrological/subscriptions","organizations_url":"https://api.github.com/users/Metrological/orgs","repos_url":"https://api.github.com/users/Metrological/repos","events_url":"https://api.github.com/users/Metrological/events{/privacy}","received_events_url":"https://api.github.com/users/Metrological/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Metrological/WebKitForWayland","description":"Unofficial mirror of the WebKit SVN repository","fork":true,"url":"https://api.github.com/repos/Metrological/WebKitForWayland","forks_url":"https://api.github.com/repos/Metrological/WebKitForWayland/forks","keys_url":"https://api.github.com/repos/Metrological/WebKitForWayland/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Metrological/WebKitForWayland/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Metrological/WebKitForWayland/teams","hooks_url":"https://api.github.com/repos/Metrological/WebKitForWayland/hooks","issue_events_url":"https://api.github.com/repos/Metrological/WebKitForWayland/issues/events{/number}","events_url":"https://api.github.com/repos/Metrological/WebKitForWayland/events","assignees_url":"https://api.github.com/repos/Metrological/WebKitForWayland/assignees{/user}","branches_url":"https://api.github.com/repos/Metrological/WebKitForWayland/branches{/branch}","tags_url":"https://api.github.com/repos/Metrological/WebKitForWayland/tags","blobs_url":"https://api.github.com/repos/Metrological/WebKitForWayland/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Metrological/WebKitForWayland/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Metrological/WebKitForWayland/git/refs{/sha}","trees_url":"https://api.github.com/repos/Metrological/WebKitForWayland/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Metrological/WebKitForWayland/statuses/{sha}","languages_url":"https://api.github.com/repos/Metrological/WebKitForWayland/languages","stargazers_url":"https://api.github.com/repos/Metrological/WebKitForWayland/stargazers","contributors_url":"https://api.github.com/repos/Metrological/WebKitForWayland/contributors","subscribers_url":"https://api.github.com/repos/Metrological/WebKitForWayland/subscribers","subscription_url":"https://api.github.com/repos/Metrological/WebKitForWayland/subscription","commits_url":"https://api.github.com/repos/Metrological/WebKitForWayland/commits{/sha}","git_commits_url":"https://api.github.com/repos/Metrological/WebKitForWayland/git/commits{/sha}","comments_url":"https://api.github.com/repos/Metrological/WebKitForWayland/comments{/number}","issue_comment_url":"https://api.github.com/repos/Metrological/WebKitForWayland/issues/comments{/number}","contents_url":"https://api.github.com/repos/Metrological/WebKitForWayland/contents/{+path}","compare_url":"https://api.github.com/repos/Metrological/WebKitForWayland/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Metrological/WebKitForWayland/merges","archive_url":"https://api.github.com/repos/Metrological/WebKitForWayland/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Metrological/WebKitForWayland/downloads","issues_url":"https://api.github.com/repos/Metrological/WebKitForWayland/issues{/number}","pulls_url":"https://api.github.com/repos/Metrological/WebKitForWayland/pulls{/number}","milestones_url":"https://api.github.com/repos/Metrological/WebKitForWayland/milestones{/number}","notifications_url":"https://api.github.com/repos/Metrological/WebKitForWayland/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Metrological/WebKitForWayland/labels{/name}","releases_url":"https://api.github.com/repos/Metrological/WebKitForWayland/releases{/id}","deployments_url":"https://api.github.com/repos/Metrological/WebKitForWayland/deployments","created_at":"2014-12-18T18:08:02Z","updated_at":"2016-01-12T14:38:10Z","pushed_at":"2016-02-05T14:27:52Z","git_url":"git://github.com/Metrological/WebKitForWayland.git","ssh_url":"git@github.com:Metrological/WebKitForWayland.git","clone_url":"https://github.com/Metrological/WebKitForWayland.git","svn_url":"https://github.com/Metrological/WebKitForWayland","homepage":"http://www.webkit.org/","size":6981478,"stargazers_count":6,"watchers_count":6,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":6,"forks":9,"open_issues":6,"watchers":6,"default_branch":"master"}},"base":{"label":"Metrological:master","ref":"master","sha":"08a08b8f165d9cde8e2ba657aabf446278f54535","user":{"login":"Metrological","id":5675691,"avatar_url":"https://avatars.githubusercontent.com/u/5675691?v=3","gravatar_id":"","url":"https://api.github.com/users/Metrological","html_url":"https://github.com/Metrological","followers_url":"https://api.github.com/users/Metrological/followers","following_url":"https://api.github.com/users/Metrological/following{/other_user}","gists_url":"https://api.github.com/users/Metrological/gists{/gist_id}","starred_url":"https://api.github.com/users/Metrological/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Metrological/subscriptions","organizations_url":"https://api.github.com/users/Metrological/orgs","repos_url":"https://api.github.com/users/Metrological/repos","events_url":"https://api.github.com/users/Metrological/events{/privacy}","received_events_url":"https://api.github.com/users/Metrological/received_events","type":"Organization","site_admin":false},"repo":{"id":28195272,"name":"WebKitForWayland","full_name":"Metrological/WebKitForWayland","owner":{"login":"Metrological","id":5675691,"avatar_url":"https://avatars.githubusercontent.com/u/5675691?v=3","gravatar_id":"","url":"https://api.github.com/users/Metrological","html_url":"https://github.com/Metrological","followers_url":"https://api.github.com/users/Metrological/followers","following_url":"https://api.github.com/users/Metrological/following{/other_user}","gists_url":"https://api.github.com/users/Metrological/gists{/gist_id}","starred_url":"https://api.github.com/users/Metrological/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Metrological/subscriptions","organizations_url":"https://api.github.com/users/Metrological/orgs","repos_url":"https://api.github.com/users/Metrological/repos","events_url":"https://api.github.com/users/Metrological/events{/privacy}","received_events_url":"https://api.github.com/users/Metrological/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Metrological/WebKitForWayland","description":"Unofficial mirror of the WebKit SVN repository","fork":true,"url":"https://api.github.com/repos/Metrological/WebKitForWayland","forks_url":"https://api.github.com/repos/Metrological/WebKitForWayland/forks","keys_url":"https://api.github.com/repos/Metrological/WebKitForWayland/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Metrological/WebKitForWayland/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Metrological/WebKitForWayland/teams","hooks_url":"https://api.github.com/repos/Metrological/WebKitForWayland/hooks","issue_events_url":"https://api.github.com/repos/Metrological/WebKitForWayland/issues/events{/number}","events_url":"https://api.github.com/repos/Metrological/WebKitForWayland/events","assignees_url":"https://api.github.com/repos/Metrological/WebKitForWayland/assignees{/user}","branches_url":"https://api.github.com/repos/Metrological/WebKitForWayland/branches{/branch}","tags_url":"https://api.github.com/repos/Metrological/WebKitForWayland/tags","blobs_url":"https://api.github.com/repos/Metrological/WebKitForWayland/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Metrological/WebKitForWayland/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Metrological/WebKitForWayland/git/refs{/sha}","trees_url":"https://api.github.com/repos/Metrological/WebKitForWayland/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Metrological/WebKitForWayland/statuses/{sha}","languages_url":"https://api.github.com/repos/Metrological/WebKitForWayland/languages","stargazers_url":"https://api.github.com/repos/Metrological/WebKitForWayland/stargazers","contributors_url":"https://api.github.com/repos/Metrological/WebKitForWayland/contributors","subscribers_url":"https://api.github.com/repos/Metrological/WebKitForWayland/subscribers","subscription_url":"https://api.github.com/repos/Metrological/WebKitForWayland/subscription","commits_url":"https://api.github.com/repos/Metrological/WebKitForWayland/commits{/sha}","git_commits_url":"https://api.github.com/repos/Metrological/WebKitForWayland/git/commits{/sha}","comments_url":"https://api.github.com/repos/Metrological/WebKitForWayland/comments{/number}","issue_comment_url":"https://api.github.com/repos/Metrological/WebKitForWayland/issues/comments{/number}","contents_url":"https://api.github.com/repos/Metrological/WebKitForWayland/contents/{+path}","compare_url":"https://api.github.com/repos/Metrological/WebKitForWayland/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Metrological/WebKitForWayland/merges","archive_url":"https://api.github.com/repos/Metrological/WebKitForWayland/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Metrological/WebKitForWayland/downloads","issues_url":"https://api.github.com/repos/Metrological/WebKitForWayland/issues{/number}","pulls_url":"https://api.github.com/repos/Metrological/WebKitForWayland/pulls{/number}","milestones_url":"https://api.github.com/repos/Metrological/WebKitForWayland/milestones{/number}","notifications_url":"https://api.github.com/repos/Metrological/WebKitForWayland/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Metrological/WebKitForWayland/labels{/name}","releases_url":"https://api.github.com/repos/Metrological/WebKitForWayland/releases{/id}","deployments_url":"https://api.github.com/repos/Metrological/WebKitForWayland/deployments","created_at":"2014-12-18T18:08:02Z","updated_at":"2016-01-12T14:38:10Z","pushed_at":"2016-02-05T14:27:52Z","git_url":"git://github.com/Metrological/WebKitForWayland.git","ssh_url":"git@github.com:Metrological/WebKitForWayland.git","clone_url":"https://github.com/Metrological/WebKitForWayland.git","svn_url":"https://github.com/Metrological/WebKitForWayland","homepage":"http://www.webkit.org/","size":6981478,"stargazers_count":6,"watchers_count":6,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":6,"forks":9,"open_issues":6,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Metrological/WebKitForWayland/pulls/21"},"html":{"href":"https://github.com/Metrological/WebKitForWayland/pull/21"},"issue":{"href":"https://api.github.com/repos/Metrological/WebKitForWayland/issues/21"},"comments":{"href":"https://api.github.com/repos/Metrological/WebKitForWayland/issues/21/comments"},"review_comments":{"href":"https://api.github.com/repos/Metrological/WebKitForWayland/pulls/21/comments"},"review_comment":{"href":"https://api.github.com/repos/Metrological/WebKitForWayland/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Metrological/WebKitForWayland/pulls/21/commits"},"statuses":{"href":"https://api.github.com/repos/Metrological/WebKitForWayland/statuses/e0d312c7ccd892c358c59fb0ba34baa1a3d68e60"}}}}