{"action":"created","issue":{"url":"https://api.github.com/repos/slog-rs/slog/issues/95","repository_url":"https://api.github.com/repos/slog-rs/slog","labels_url":"https://api.github.com/repos/slog-rs/slog/issues/95/labels{/name}","comments_url":"https://api.github.com/repos/slog-rs/slog/issues/95/comments","events_url":"https://api.github.com/repos/slog-rs/slog/issues/95/events","html_url":"https://github.com/slog-rs/slog/issues/95","id":196404137,"number":95,"title":"Drain on root logger must not require 'static.","user":{"login":"kdy1997","id":18233865,"avatar_url":"https://avatars.githubusercontent.com/u/18233865?v=3","gravatar_id":"","url":"https://api.github.com/users/kdy1997","html_url":"https://github.com/kdy1997","followers_url":"https://api.github.com/users/kdy1997/followers","following_url":"https://api.github.com/users/kdy1997/following{/other_user}","gists_url":"https://api.github.com/users/kdy1997/gists{/gist_id}","starred_url":"https://api.github.com/users/kdy1997/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kdy1997/subscriptions","organizations_url":"https://api.github.com/users/kdy1997/orgs","repos_url":"https://api.github.com/users/kdy1997/repos","events_url":"https://api.github.com/users/kdy1997/events{/privacy}","received_events_url":"https://api.github.com/users/kdy1997/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-12-19T12:37:49Z","updated_at":"2016-12-19T12:49:59Z","closed_at":null,"body":"Logger::root() requires ```drain: 'static```, but it seems unnecessary.\r\n```rust\r\npub struct Logger {\r\n    drain: Arc<Drain<Error=Never>+Send+Sync>,\r\n    values: OwnedKeyValueList,\r\n}\r\n```\r\nLogger struct does not have a same constraint, and no impl depends on 'static\r\nAnd I think `root` must be a root of one logger hierarchy, not root of global.\r\n\r\n\r\n\r\n### Example use case\r\nCurrently, I'm trying to capture logs as string to bypass https://github.com/rust-lang/rust/issues/12309. As it must be done once per #[test] fn, buffer string is not 'static. I can do it via thread_local!, but it's quite hacky as it depends on [bug][1].\r\n\r\n```\r\n---- definition::parser::tests::expansion_order_detection stdout ----\r\n# I want to see logs for the test at here\r\n\r\n```\r\n\r\n\r\n[1]:https://github.com/rust-lang/rust/issues/17954"},"comment":{"url":"https://api.github.com/repos/slog-rs/slog/issues/comments/267956868","html_url":"https://github.com/slog-rs/slog/issues/95#issuecomment-267956868","issue_url":"https://api.github.com/repos/slog-rs/slog/issues/95","id":267956868,"user":{"login":"kdy1997","id":18233865,"avatar_url":"https://avatars.githubusercontent.com/u/18233865?v=3","gravatar_id":"","url":"https://api.github.com/users/kdy1997","html_url":"https://github.com/kdy1997","followers_url":"https://api.github.com/users/kdy1997/followers","following_url":"https://api.github.com/users/kdy1997/following{/other_user}","gists_url":"https://api.github.com/users/kdy1997/gists{/gist_id}","starred_url":"https://api.github.com/users/kdy1997/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kdy1997/subscriptions","organizations_url":"https://api.github.com/users/kdy1997/orgs","repos_url":"https://api.github.com/users/kdy1997/repos","events_url":"https://api.github.com/users/kdy1997/events{/privacy}","received_events_url":"https://api.github.com/users/kdy1997/received_events","type":"User","site_admin":false},"created_at":"2016-12-19T12:49:59Z","updated_at":"2016-12-19T12:49:59Z","body":"I will do it soon, and I want to know if you will merge it to slog.\r\n\r\n(git clone from github is 8kb/s using msys2/windows 10)"}}
{"actor":{"display_login":"kdy1997"}}