{"action":"created","comment":{"url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/pulls/comments/56175617","id":56175617,"diff_hunk":"@@ -0,0 +1,77 @@\n+class MetricsController < ApplicationController\n+  before_action :authorize_prison_request\n+\n+  def index\n+    @start_date = start_date_from_range\n+\n+    if all_time?\n+      counts = all_time_counts\n+    else\n+      counts = weekly_counts(year: @start_date.year,\n+                             week: @start_date.cweek)\n+    end\n+\n+    @dataset = MetricsPresenter.new(*counts)\n+  end\n+\n+  def weekly\n+    @prison = Prison.find(params[:prison])\n+    @date = 1.week.ago.to_date\n+\n+    counts = Counters::CountVisitsByPrisonAndCalendarWeek.\n+             where(prison_name: @prison.name).\n+             where(year: @date.year, week: @date.cweek).\n+             fetch_and_format\n+\n+    overdue_counts = Overdue::CountOverdueVisitsByPrisonAndCalendarWeek.\n+                     where(prison_name: @prison.name).\n+                     where(year: @date.year, week: @date.cweek).\n+                     ordered_counters\n+\n+    percentiles = Percentiles::DistributionByPrisonAndCalendarWeek.\n+                  where(prison_name: @prison.name).\n+                  where(year: @date.year, week: @date.cweek).\n+                  ordered_counters\n+\n+    @dataset = MetricsPresenter.new(counts, overdue_counts, percentiles)\n+  end\n+\n+private\n+\n+  def weekly_counts(year: nil, week: nil)\n+    counts = Counters::CountVisitsByPrisonAndCalendarWeek.\n+             where(year: year, week: week).fetch_and_format\n+\n+    overdue = Overdue::CountOverdueVisitsByPrisonAndCalendarWeek.\n+              where(year: year, week: week).ordered_counters","path":"app/controllers/metrics_controller.rb","position":46,"original_position":46,"commit_id":"4f22aba13973c2c0527c33ecd03723c854bdbc6d","original_commit_id":"4f22aba13973c2c0527c33ecd03723c854bdbc6d","user":{"login":"tatyree","id":20921,"avatar_url":"https://avatars.githubusercontent.com/u/20921?v=3","gravatar_id":"","url":"https://api.github.com/users/tatyree","html_url":"https://github.com/tatyree","followers_url":"https://api.github.com/users/tatyree/followers","following_url":"https://api.github.com/users/tatyree/following{/other_user}","gists_url":"https://api.github.com/users/tatyree/gists{/gist_id}","starred_url":"https://api.github.com/users/tatyree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tatyree/subscriptions","organizations_url":"https://api.github.com/users/tatyree/orgs","repos_url":"https://api.github.com/users/tatyree/repos","events_url":"https://api.github.com/users/tatyree/events{/privacy}","received_events_url":"https://api.github.com/users/tatyree/received_events","type":"User","site_admin":false},"body":"If it's working for you, then great. ordered_counters was mainly meant to be a method to feed fetch_and_format, which in mixed from the various support modules when it isn't being declared explicitly.","created_at":"2016-03-15T14:51:13Z","updated_at":"2016-03-15T14:51:13Z","html_url":"https://github.com/ministryofjustice/prison-visits-2/pull/212#discussion_r56175617","pull_request_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/pulls/212","_links":{"self":{"href":"https://api.github.com/repos/ministryofjustice/prison-visits-2/pulls/comments/56175617"},"html":{"href":"https://github.com/ministryofjustice/prison-visits-2/pull/212#discussion_r56175617"},"pull_request":{"href":"https://api.github.com/repos/ministryofjustice/prison-visits-2/pulls/212"}}},"pull_request":{"url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/pulls/212","id":62905983,"html_url":"https://github.com/ministryofjustice/prison-visits-2/pull/212","diff_url":"https://github.com/ministryofjustice/prison-visits-2/pull/212.diff","patch_url":"https://github.com/ministryofjustice/prison-visits-2/pull/212.patch","issue_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/issues/212","number":212,"state":"open","locked":false,"title":"Metrics UI","user":{"login":"alan","id":6356,"avatar_url":"https://avatars.githubusercontent.com/u/6356?v=3","gravatar_id":"","url":"https://api.github.com/users/alan","html_url":"https://github.com/alan","followers_url":"https://api.github.com/users/alan/followers","following_url":"https://api.github.com/users/alan/following{/other_user}","gists_url":"https://api.github.com/users/alan/gists{/gist_id}","starred_url":"https://api.github.com/users/alan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alan/subscriptions","organizations_url":"https://api.github.com/users/alan/orgs","repos_url":"https://api.github.com/users/alan/repos","events_url":"https://api.github.com/users/alan/events{/privacy}","received_events_url":"https://api.github.com/users/alan/received_events","type":"User","site_admin":false},"body":"WIP","created_at":"2016-03-15T13:36:14Z","updated_at":"2016-03-15T14:51:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b85d69e45d6c7373ec1377655a4a62b3ea35a76f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/pulls/212/commits","review_comments_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/pulls/212/comments","review_comment_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/issues/212/comments","statuses_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/statuses/4f22aba13973c2c0527c33ecd03723c854bdbc6d","head":{"label":"ministryofjustice:metrics-ui","ref":"metrics-ui","sha":"4f22aba13973c2c0527c33ecd03723c854bdbc6d","user":{"login":"ministryofjustice","id":2203574,"avatar_url":"https://avatars.githubusercontent.com/u/2203574?v=3","gravatar_id":"","url":"https://api.github.com/users/ministryofjustice","html_url":"https://github.com/ministryofjustice","followers_url":"https://api.github.com/users/ministryofjustice/followers","following_url":"https://api.github.com/users/ministryofjustice/following{/other_user}","gists_url":"https://api.github.com/users/ministryofjustice/gists{/gist_id}","starred_url":"https://api.github.com/users/ministryofjustice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ministryofjustice/subscriptions","organizations_url":"https://api.github.com/users/ministryofjustice/orgs","repos_url":"https://api.github.com/users/ministryofjustice/repos","events_url":"https://api.github.com/users/ministryofjustice/events{/privacy}","received_events_url":"https://api.github.com/users/ministryofjustice/received_events","type":"Organization","site_admin":false},"repo":{"id":44737633,"name":"prison-visits-2","full_name":"ministryofjustice/prison-visits-2","owner":{"login":"ministryofjustice","id":2203574,"avatar_url":"https://avatars.githubusercontent.com/u/2203574?v=3","gravatar_id":"","url":"https://api.github.com/users/ministryofjustice","html_url":"https://github.com/ministryofjustice","followers_url":"https://api.github.com/users/ministryofjustice/followers","following_url":"https://api.github.com/users/ministryofjustice/following{/other_user}","gists_url":"https://api.github.com/users/ministryofjustice/gists{/gist_id}","starred_url":"https://api.github.com/users/ministryofjustice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ministryofjustice/subscriptions","organizations_url":"https://api.github.com/users/ministryofjustice/orgs","repos_url":"https://api.github.com/users/ministryofjustice/repos","events_url":"https://api.github.com/users/ministryofjustice/events{/privacy}","received_events_url":"https://api.github.com/users/ministryofjustice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ministryofjustice/prison-visits-2","description":"A full ground-up rewrite","fork":false,"url":"https://api.github.com/repos/ministryofjustice/prison-visits-2","forks_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/forks","keys_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/teams","hooks_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/hooks","issue_events_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/issues/events{/number}","events_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/events","assignees_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/assignees{/user}","branches_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/branches{/branch}","tags_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/tags","blobs_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/git/refs{/sha}","trees_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/statuses/{sha}","languages_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/languages","stargazers_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/stargazers","contributors_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/contributors","subscribers_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/subscribers","subscription_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/subscription","commits_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/commits{/sha}","git_commits_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/git/commits{/sha}","comments_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/comments{/number}","issue_comment_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/issues/comments{/number}","contents_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/contents/{+path}","compare_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/merges","archive_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/downloads","issues_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/issues{/number}","pulls_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/pulls{/number}","milestones_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/milestones{/number}","notifications_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/labels{/name}","releases_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/releases{/id}","deployments_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/deployments","created_at":"2015-10-22T10:12:32Z","updated_at":"2016-01-18T22:38:40Z","pushed_at":"2016-03-15T14:47:18Z","git_url":"git://github.com/ministryofjustice/prison-visits-2.git","ssh_url":"git@github.com:ministryofjustice/prison-visits-2.git","clone_url":"https://github.com/ministryofjustice/prison-visits-2.git","svn_url":"https://github.com/ministryofjustice/prison-visits-2","homepage":"","size":1423,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":6,"forks":0,"open_issues":6,"watchers":2,"default_branch":"master"}},"base":{"label":"ministryofjustice:master","ref":"master","sha":"2c9617829b8c94485dbbe4a6ffc91e49d45fb098","user":{"login":"ministryofjustice","id":2203574,"avatar_url":"https://avatars.githubusercontent.com/u/2203574?v=3","gravatar_id":"","url":"https://api.github.com/users/ministryofjustice","html_url":"https://github.com/ministryofjustice","followers_url":"https://api.github.com/users/ministryofjustice/followers","following_url":"https://api.github.com/users/ministryofjustice/following{/other_user}","gists_url":"https://api.github.com/users/ministryofjustice/gists{/gist_id}","starred_url":"https://api.github.com/users/ministryofjustice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ministryofjustice/subscriptions","organizations_url":"https://api.github.com/users/ministryofjustice/orgs","repos_url":"https://api.github.com/users/ministryofjustice/repos","events_url":"https://api.github.com/users/ministryofjustice/events{/privacy}","received_events_url":"https://api.github.com/users/ministryofjustice/received_events","type":"Organization","site_admin":false},"repo":{"id":44737633,"name":"prison-visits-2","full_name":"ministryofjustice/prison-visits-2","owner":{"login":"ministryofjustice","id":2203574,"avatar_url":"https://avatars.githubusercontent.com/u/2203574?v=3","gravatar_id":"","url":"https://api.github.com/users/ministryofjustice","html_url":"https://github.com/ministryofjustice","followers_url":"https://api.github.com/users/ministryofjustice/followers","following_url":"https://api.github.com/users/ministryofjustice/following{/other_user}","gists_url":"https://api.github.com/users/ministryofjustice/gists{/gist_id}","starred_url":"https://api.github.com/users/ministryofjustice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ministryofjustice/subscriptions","organizations_url":"https://api.github.com/users/ministryofjustice/orgs","repos_url":"https://api.github.com/users/ministryofjustice/repos","events_url":"https://api.github.com/users/ministryofjustice/events{/privacy}","received_events_url":"https://api.github.com/users/ministryofjustice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ministryofjustice/prison-visits-2","description":"A full ground-up rewrite","fork":false,"url":"https://api.github.com/repos/ministryofjustice/prison-visits-2","forks_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/forks","keys_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/teams","hooks_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/hooks","issue_events_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/issues/events{/number}","events_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/events","assignees_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/assignees{/user}","branches_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/branches{/branch}","tags_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/tags","blobs_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/git/refs{/sha}","trees_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/statuses/{sha}","languages_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/languages","stargazers_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/stargazers","contributors_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/contributors","subscribers_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/subscribers","subscription_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/subscription","commits_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/commits{/sha}","git_commits_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/git/commits{/sha}","comments_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/comments{/number}","issue_comment_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/issues/comments{/number}","contents_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/contents/{+path}","compare_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/merges","archive_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/downloads","issues_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/issues{/number}","pulls_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/pulls{/number}","milestones_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/milestones{/number}","notifications_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/labels{/name}","releases_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/releases{/id}","deployments_url":"https://api.github.com/repos/ministryofjustice/prison-visits-2/deployments","created_at":"2015-10-22T10:12:32Z","updated_at":"2016-01-18T22:38:40Z","pushed_at":"2016-03-15T14:47:18Z","git_url":"git://github.com/ministryofjustice/prison-visits-2.git","ssh_url":"git@github.com:ministryofjustice/prison-visits-2.git","clone_url":"https://github.com/ministryofjustice/prison-visits-2.git","svn_url":"https://github.com/ministryofjustice/prison-visits-2","homepage":"","size":1423,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":6,"forks":0,"open_issues":6,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ministryofjustice/prison-visits-2/pulls/212"},"html":{"href":"https://github.com/ministryofjustice/prison-visits-2/pull/212"},"issue":{"href":"https://api.github.com/repos/ministryofjustice/prison-visits-2/issues/212"},"comments":{"href":"https://api.github.com/repos/ministryofjustice/prison-visits-2/issues/212/comments"},"review_comments":{"href":"https://api.github.com/repos/ministryofjustice/prison-visits-2/pulls/212/comments"},"review_comment":{"href":"https://api.github.com/repos/ministryofjustice/prison-visits-2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ministryofjustice/prison-visits-2/pulls/212/commits"},"statuses":{"href":"https://api.github.com/repos/ministryofjustice/prison-visits-2/statuses/4f22aba13973c2c0527c33ecd03723c854bdbc6d"}}}}