{"action":"closed","issue":{"url":"https://api.github.com/repos/mantidproject/mantid/issues/16800","repository_url":"https://api.github.com/repos/mantidproject/mantid","labels_url":"https://api.github.com/repos/mantidproject/mantid/issues/16800/labels{/name}","comments_url":"https://api.github.com/repos/mantidproject/mantid/issues/16800/comments","events_url":"https://api.github.com/repos/mantidproject/mantid/issues/16800/events","html_url":"https://github.com/mantidproject/mantid/issues/16800","id":163872467,"number":16800,"title":"Refactor LoadNexusLogs to use PropertyNexus","user":{"login":"FedeMPouzols","id":5257172,"avatar_url":"https://avatars.githubusercontent.com/u/5257172?v=3","gravatar_id":"","url":"https://api.github.com/users/FedeMPouzols","html_url":"https://github.com/FedeMPouzols","followers_url":"https://api.github.com/users/FedeMPouzols/followers","following_url":"https://api.github.com/users/FedeMPouzols/following{/other_user}","gists_url":"https://api.github.com/users/FedeMPouzols/gists{/gist_id}","starred_url":"https://api.github.com/users/FedeMPouzols/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FedeMPouzols/subscriptions","organizations_url":"https://api.github.com/users/FedeMPouzols/orgs","repos_url":"https://api.github.com/users/FedeMPouzols/repos","events_url":"https://api.github.com/users/FedeMPouzols/events{/privacy}","received_events_url":"https://api.github.com/users/FedeMPouzols/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/mantidproject/mantid/labels/Component:%20Framework","name":"Component: Framework","color":"009800"},{"url":"https://api.github.com/repos/mantidproject/mantid/labels/Misc:%20Easy","name":"Misc: Easy","color":"d4c5f9"},{"url":"https://api.github.com/repos/mantidproject/mantid/labels/Misc:%20Maintenance","name":"Misc: Maintenance","color":"d4c5f9"},{"url":"https://api.github.com/repos/mantidproject/mantid/labels/Quality:%20Code%20Quality","name":"Quality: Code Quality","color":"c7def8"}],"state":"closed","locked":false,"assignee":{"login":"PranavBahuguna","id":10980962,"avatar_url":"https://avatars.githubusercontent.com/u/10980962?v=3","gravatar_id":"","url":"https://api.github.com/users/PranavBahuguna","html_url":"https://github.com/PranavBahuguna","followers_url":"https://api.github.com/users/PranavBahuguna/followers","following_url":"https://api.github.com/users/PranavBahuguna/following{/other_user}","gists_url":"https://api.github.com/users/PranavBahuguna/gists{/gist_id}","starred_url":"https://api.github.com/users/PranavBahuguna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PranavBahuguna/subscriptions","organizations_url":"https://api.github.com/users/PranavBahuguna/orgs","repos_url":"https://api.github.com/users/PranavBahuguna/repos","events_url":"https://api.github.com/users/PranavBahuguna/events{/privacy}","received_events_url":"https://api.github.com/users/PranavBahuguna/received_events","type":"User","site_admin":false},"assignees":[{"login":"PranavBahuguna","id":10980962,"avatar_url":"https://avatars.githubusercontent.com/u/10980962?v=3","gravatar_id":"","url":"https://api.github.com/users/PranavBahuguna","html_url":"https://github.com/PranavBahuguna","followers_url":"https://api.github.com/users/PranavBahuguna/followers","following_url":"https://api.github.com/users/PranavBahuguna/following{/other_user}","gists_url":"https://api.github.com/users/PranavBahuguna/gists{/gist_id}","starred_url":"https://api.github.com/users/PranavBahuguna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PranavBahuguna/subscriptions","organizations_url":"https://api.github.com/users/PranavBahuguna/orgs","repos_url":"https://api.github.com/users/PranavBahuguna/repos","events_url":"https://api.github.com/users/PranavBahuguna/events{/privacy}","received_events_url":"https://api.github.com/users/PranavBahuguna/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/mantidproject/mantid/milestones/58","html_url":"https://github.com/mantidproject/mantid/milestones/Release%203.8","labels_url":"https://api.github.com/repos/mantidproject/mantid/milestones/58/labels","id":1505614,"number":58,"title":"Release 3.8","description":"","creator":{"login":"granrothge","id":5910574,"avatar_url":"https://avatars.githubusercontent.com/u/5910574?v=3","gravatar_id":"","url":"https://api.github.com/users/granrothge","html_url":"https://github.com/granrothge","followers_url":"https://api.github.com/users/granrothge/followers","following_url":"https://api.github.com/users/granrothge/following{/other_user}","gists_url":"https://api.github.com/users/granrothge/gists{/gist_id}","starred_url":"https://api.github.com/users/granrothge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/granrothge/subscriptions","organizations_url":"https://api.github.com/users/granrothge/orgs","repos_url":"https://api.github.com/users/granrothge/repos","events_url":"https://api.github.com/users/granrothge/events{/privacy}","received_events_url":"https://api.github.com/users/granrothge/received_events","type":"User","site_admin":false},"open_issues":696,"closed_issues":549,"state":"open","created_at":"2016-01-13T20:00:53Z","updated_at":"2016-08-10T09:03:39Z","due_on":"2016-10-09T23:00:00Z","closed_at":null},"comments":5,"created_at":"2016-07-05T15:01:30Z","updated_at":"2016-08-10T09:03:39Z","closed_at":"2016-08-10T09:03:39Z","body":"[LoadNexusLogs::createTimeSeries](https://github.com/mantidproject/mantid/blob/master/Framework/DataHandling/src/LoadNexusLogs.cpp#L504) looks like a duplicate of  [PropertyNexus::loadProperty](https://github.com/mantidproject/mantid/blob/master/Framework/API/src/PropertyNexus.cpp#L112). As we have  `PropertyNexus`  which encapsulates the loading of property values from NeXus files, including time series, `LoadNexusLogs` could just use `PropertyNexus` to do the loading here. There are other places in the algorithm where scalar values could probably be loaded with `PropertyNexus` as well.\r\n\r\nSee #16345 for a recent refactoring of PropertyNexus.\r\n"}}
{"actor":{"display_login":"PranavBahuguna"}}