{"action":"created","comment":{"url":"https://api.github.com/repos/canonical-ols/talisker-flask-example/pulls/comments/90510005","pull_request_review_id":11029151,"id":90510005,"diff_hunk":"@@ -0,0 +1,36 @@\n+IMAGES_TAG ?= canonicalols/helloworld\n+ENV ?= $(CURDIR)/env\n+K8S_CONFIG_TEMPLATE = helloworld.k8s.yaml.j2\n+K8S_CONFIG = /tmp/helloworld.k8s.yaml\n+\n+\n+$(ENV)/.done:\n+\tvirtualenv --python python3 $(ENV)\n+\t$(ENV)/bin/pip install -r requirements.txt\n+\ttouch $@\n+\n+build-docker: $(ENV)/.done\n+\tBUILD_REVISION=\"$(shell git rev-parse HEAD)\" \\\n+\t\t$(ENV)/bin/python scripts/generate-config Dockerfile.j2 > Dockerfile\n+\tdocker build -t $(IMAGES_TAG) .\n+\n+upload-docker:\n+\t@echo \"Logging into docker..\"\n+\t@docker login -u=\"$(DOCKER_USERNAME)\" -p=\"$(DOCKER_PASSWORD)\"\n+\tdocker push $(IMAGES_TAG)\n+\n+deploy-kubernetes:\n+\tIMAGE_ID=\"$$(docker inspect -f '{{ .Id }}' $(IMAGES_TAG) | awk '{split($$0, a, \":\"); print a[2]}')\" \\\n+\t\tIMAGES_TAG=\"$(IMAGES_TAG)\" \\\n+\t\tBUILD_REVISION=\"$$(docker inspect -f '{{ .Config.Labels.revision }}' $(IMAGES_TAG))\" \\\n+\t\t$(ENV)/bin/python scripts/generate-config $(K8S_CONFIG_TEMPLATE) > $(K8S_CONFIG)","path":"Makefile","position":26,"original_position":26,"commit_id":"8b1b565f29da7fe4adee8134929a38464a23b3b5","original_commit_id":"8b1b565f29da7fe4adee8134929a38464a23b3b5","user":{"login":"caio1982","id":1158947,"avatar_url":"https://avatars.githubusercontent.com/u/1158947?v=3","gravatar_id":"","url":"https://api.github.com/users/caio1982","html_url":"https://github.com/caio1982","followers_url":"https://api.github.com/users/caio1982/followers","following_url":"https://api.github.com/users/caio1982/following{/other_user}","gists_url":"https://api.github.com/users/caio1982/gists{/gist_id}","starred_url":"https://api.github.com/users/caio1982/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caio1982/subscriptions","organizations_url":"https://api.github.com/users/caio1982/orgs","repos_url":"https://api.github.com/users/caio1982/repos","events_url":"https://api.github.com/users/caio1982/events{/privacy}","received_events_url":"https://api.github.com/users/caio1982/received_events","type":"User","site_admin":false},"body":"Let's hope we don't need to append more env vars too often so generate-config will use them in the template, i.e. this looks a bit cluttered but is quite decent for us for now :-)","created_at":"2016-12-01T18:43:51Z","updated_at":"2016-12-01T18:43:52Z","html_url":"https://github.com/canonical-ols/talisker-flask-example/pull/2#discussion_r90510005","pull_request_url":"https://api.github.com/repos/canonical-ols/talisker-flask-example/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/canonical-ols/talisker-flask-example/pulls/comments/90510005"},"html":{"href":"https://github.com/canonical-ols/talisker-flask-example/pull/2#discussion_r90510005"},"pull_request":{"href":"https://api.github.com/repos/canonical-ols/talisker-flask-example/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/canonical-ols/talisker-flask-example/pulls/2","id":96145330,"html_url":"https://github.com/canonical-ols/talisker-flask-example/pull/2","diff_url":"https://github.com/canonical-ols/talisker-flask-example/pull/2.diff","patch_url":"https://github.com/canonical-ols/talisker-flask-example/pull/2.patch","issue_url":"https://api.github.com/repos/canonical-ols/talisker-flask-example/issues/2","number":2,"state":"open","locked":false,"title":"k8s and docker templates","user":{"login":"1stvamp","id":35831,"avatar_url":"https://avatars.githubusercontent.com/u/35831?v=3","gravatar_id":"","url":"https://api.github.com/users/1stvamp","html_url":"https://github.com/1stvamp","followers_url":"https://api.github.com/users/1stvamp/followers","following_url":"https://api.github.com/users/1stvamp/following{/other_user}","gists_url":"https://api.github.com/users/1stvamp/gists{/gist_id}","starred_url":"https://api.github.com/users/1stvamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/1stvamp/subscriptions","organizations_url":"https://api.github.com/users/1stvamp/orgs","repos_url":"https://api.github.com/users/1stvamp/repos","events_url":"https://api.github.com/users/1stvamp/events{/privacy}","received_events_url":"https://api.github.com/users/1stvamp/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-12-01T18:37:30Z","updated_at":"2016-12-01T18:43:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f06cbe978fb9174b09144a9c8f209011e0bdc47e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/canonical-ols/talisker-flask-example/pulls/2/commits","review_comments_url":"https://api.github.com/repos/canonical-ols/talisker-flask-example/pulls/2/comments","review_comment_url":"https://api.github.com/repos/canonical-ols/talisker-flask-example/pulls/comments{/number}","comments_url":"https://api.github.com/repos/canonical-ols/talisker-flask-example/issues/2/comments","statuses_url":"https://api.github.com/repos/canonical-ols/talisker-flask-example/statuses/8b1b565f29da7fe4adee8134929a38464a23b3b5","head":{"label":"canonical-ols:k8s-template","ref":"k8s-template","sha":"8b1b565f29da7fe4adee8134929a38464a23b3b5","user":{"login":"canonical-ols","id":17836138,"avatar_url":"https://avatars.githubusercontent.com/u/17836138?v=3","gravatar_id":"","url":"https://api.github.com/users/canonical-ols","html_url":"https://github.com/canonical-ols","followers_url":"https://api.github.com/users/canonical-ols/followers","following_url":"https://api.github.com/users/canonical-ols/following{/other_user}","gists_url":"https://api.github.com/users/canonical-ols/gists{/gist_id}","starred_url":"https://api.github.com/users/canonical-ols/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/canonical-ols/subscriptions","organizations_url":"https://api.github.com/users/canonical-ols/orgs","repos_url":"https://api.github.com/users/canonical-ols/repos","events_url":"https://api.github.com/users/canonical-ols/events{/privacy}","received_events_url":"https://api.github.com/users/canonical-ols/received_events","type":"Organization","site_admin":false},"repo":{"id":74130048,"name":"talisker-flask-example","full_name":"canonical-ols/talisker-flask-example","owner":{"login":"canonical-ols","id":17836138,"avatar_url":"https://avatars.githubusercontent.com/u/17836138?v=3","gravatar_id":"","url":"https://api.github.com/users/canonical-ols","html_url":"https://github.com/canonical-ols","followers_url":"https://api.github.com/users/canonical-ols/followers","following_url":"https://api.github.com/users/canonical-ols/following{/other_user}","gists_url":"https://api.github.com/users/canonical-ols/gists{/gist_id}","starred_url":"https://api.github.com/users/canonical-ols/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/canonical-ols/subscriptions","organizations_url":"https://api.github.com/users/canonical-ols/orgs","repos_url":"https://api.github.com/users/canonical-ols/repos","events_url":"https://api.github.com/users/canonical-ols/events{/privacy}","received_events_url":"https://api.github.com/users/canonical-ols/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/canonical-ols/talisker-flask-example","description":"An example Flask app using Tallisker","fork":false,"url":"https://api.github.com/repos/canonical-ols/talisker-flask-example","forks_url":"https://api.github.com/repos/canonical-ols/talisker-flask-example/forks","keys_url":"https://api.github.com/repos/canonical-ols/talisker-flask-example/keys{/key_id}","collaborators_url":"https://api.github.com/repos/canonical-ols/talisker-flask-example/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/canonical-ols/talisker-flask-example/teams","hooks_url":"https://api.github.com/repos/canonical-ols/talisker-flask-example/hooks","issue_events_url":"https://api.github.com/repos/canonical-ols/talisker-flask-example/issues/events{/number}","events_url":"https://api.github.com/repos/canonical-ols/talisker-flask-example/events","assignees_url":"https://api.github.com/repos/canonical-ols/talisker-flask-example/assignees{/user}","branches_url":"https://api.github.com/repos/canonical-ols/talisker-flask-example/branches{/branch}","tags_url":"https://api.github.com/repos/canonical-ols/talisker-flask-example/tags","blobs_url":"https://api.github.com/repos/canonical-ols/talisker-flask-example/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/canonical-ols/talisker-flask-example/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/canonical-ols/talisker-flask-example/git/refs{/sha}","trees_url":"https://api.github.com/repos/canonical-ols/talisker-flask-example/git/trees{/sha}","statuses_url":"https://api.github.com/repos/canonical-ols/talisker-flask-example/statuses/{sha}","languages_url":"https://api.github.com/repos/canonical-ols/talisker-flask-example/languages","stargazers_url":"https://api.github.com/repos/canonical-ols/talisker-flask-example/stargazers","contributors_url":"https://api.github.com/repos/canonical-ols/talisker-flask-example/contributors","subscribers_url":"https://api.github.com/repos/canonical-ols/talisker-flask-example/subscribers","subscription_url":"https://api.github.com/repos/canonical-ols/talisker-flask-example/subscription","commits_url":"https://api.github.com/repos/canonical-ols/talisker-flask-example/commits{/sha}","git_commits_url":"https://api.github.com/repos/canonical-ols/talisker-flask-example/git/commits{/sha}","comments_url":"https://api.github.com/repos/canonical-ols/talisker-flask-example/comments{/number}","issue_comment_url":"https://api.github.com/repos/canonical-ols/talisker-flask-example/issues/comments{/number}","contents_url":"https://api.github.com/repos/canonical-ols/talisker-flask-example/contents/{+path}","compare_url":"https://api.github.com/repos/canonical-ols/talisker-flask-example/compare/{base}...{head}","merges_url":"https://api.github.com/repos/canonical-ols/talisker-flask-example/merges","archive_url":"https://api.github.com/repos/canonical-ols/talisker-flask-example/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/canonical-ols/talisker-flask-example/downloads","issues_url":"https://api.github.com/repos/canonical-ols/talisker-flask-example/issues{/number}","pulls_url":"https://api.github.com/repos/canonical-ols/talisker-flask-example/pulls{/number}","milestones_url":"https://api.github.com/repos/canonical-ols/talisker-flask-example/milestones{/number}","notifications_url":"https://api.github.com/repos/canonical-ols/talisker-flask-example/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/canonical-ols/talisker-flask-example/labels{/name}","releases_url":"https://api.github.com/repos/canonical-ols/talisker-flask-example/releases{/id}","deployments_url":"https://api.github.com/repos/canonical-ols/talisker-flask-example/deployments","created_at":"2016-11-18T13:01:17Z","updated_at":"2016-11-21T21:42:07Z","pushed_at":"2016-12-01T18:41:54Z","git_url":"git://github.com/canonical-ols/talisker-flask-example.git","ssh_url":"git@github.com:canonical-ols/talisker-flask-example.git","clone_url":"https://github.com/canonical-ols/talisker-flask-example.git","svn_url":"https://github.com/canonical-ols/talisker-flask-example","homepage":null,"size":66,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"canonical-ols:master","ref":"master","sha":"503fde97cb5fef054d0116d0e109ed00f3b3316a","user":{"login":"canonical-ols","id":17836138,"avatar_url":"https://avatars.githubusercontent.com/u/17836138?v=3","gravatar_id":"","url":"https://api.github.com/users/canonical-ols","html_url":"https://github.com/canonical-ols","followers_url":"https://api.github.com/users/canonical-ols/followers","following_url":"https://api.github.com/users/canonical-ols/following{/other_user}","gists_url":"https://api.github.com/users/canonical-ols/gists{/gist_id}","starred_url":"https://api.github.com/users/canonical-ols/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/canonical-ols/subscriptions","organizations_url":"https://api.github.com/users/canonical-ols/orgs","repos_url":"https://api.github.com/users/canonical-ols/repos","events_url":"https://api.github.com/users/canonical-ols/events{/privacy}","received_events_url":"https://api.github.com/users/canonical-ols/received_events","type":"Organization","site_admin":false},"repo":{"id":74130048,"name":"talisker-flask-example","full_name":"canonical-ols/talisker-flask-example","owner":{"login":"canonical-ols","id":17836138,"avatar_url":"https://avatars.githubusercontent.com/u/17836138?v=3","gravatar_id":"","url":"https://api.github.com/users/canonical-ols","html_url":"https://github.com/canonical-ols","followers_url":"https://api.github.com/users/canonical-ols/followers","following_url":"https://api.github.com/users/canonical-ols/following{/other_user}","gists_url":"https://api.github.com/users/canonical-ols/gists{/gist_id}","starred_url":"https://api.github.com/users/canonical-ols/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/canonical-ols/subscriptions","organizations_url":"https://api.github.com/users/canonical-ols/orgs","repos_url":"https://api.github.com/users/canonical-ols/repos","events_url":"https://api.github.com/users/canonical-ols/events{/privacy}","received_events_url":"https://api.github.com/users/canonical-ols/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/canonical-ols/talisker-flask-example","description":"An example Flask app using Tallisker","fork":false,"url":"https://api.github.com/repos/canonical-ols/talisker-flask-example","forks_url":"https://api.github.com/repos/canonical-ols/talisker-flask-example/forks","keys_url":"https://api.github.com/repos/canonical-ols/talisker-flask-example/keys{/key_id}","collaborators_url":"https://api.github.com/repos/canonical-ols/talisker-flask-example/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/canonical-ols/talisker-flask-example/teams","hooks_url":"https://api.github.com/repos/canonical-ols/talisker-flask-example/hooks","issue_events_url":"https://api.github.com/repos/canonical-ols/talisker-flask-example/issues/events{/number}","events_url":"https://api.github.com/repos/canonical-ols/talisker-flask-example/events","assignees_url":"https://api.github.com/repos/canonical-ols/talisker-flask-example/assignees{/user}","branches_url":"https://api.github.com/repos/canonical-ols/talisker-flask-example/branches{/branch}","tags_url":"https://api.github.com/repos/canonical-ols/talisker-flask-example/tags","blobs_url":"https://api.github.com/repos/canonical-ols/talisker-flask-example/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/canonical-ols/talisker-flask-example/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/canonical-ols/talisker-flask-example/git/refs{/sha}","trees_url":"https://api.github.com/repos/canonical-ols/talisker-flask-example/git/trees{/sha}","statuses_url":"https://api.github.com/repos/canonical-ols/talisker-flask-example/statuses/{sha}","languages_url":"https://api.github.com/repos/canonical-ols/talisker-flask-example/languages","stargazers_url":"https://api.github.com/repos/canonical-ols/talisker-flask-example/stargazers","contributors_url":"https://api.github.com/repos/canonical-ols/talisker-flask-example/contributors","subscribers_url":"https://api.github.com/repos/canonical-ols/talisker-flask-example/subscribers","subscription_url":"https://api.github.com/repos/canonical-ols/talisker-flask-example/subscription","commits_url":"https://api.github.com/repos/canonical-ols/talisker-flask-example/commits{/sha}","git_commits_url":"https://api.github.com/repos/canonical-ols/talisker-flask-example/git/commits{/sha}","comments_url":"https://api.github.com/repos/canonical-ols/talisker-flask-example/comments{/number}","issue_comment_url":"https://api.github.com/repos/canonical-ols/talisker-flask-example/issues/comments{/number}","contents_url":"https://api.github.com/repos/canonical-ols/talisker-flask-example/contents/{+path}","compare_url":"https://api.github.com/repos/canonical-ols/talisker-flask-example/compare/{base}...{head}","merges_url":"https://api.github.com/repos/canonical-ols/talisker-flask-example/merges","archive_url":"https://api.github.com/repos/canonical-ols/talisker-flask-example/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/canonical-ols/talisker-flask-example/downloads","issues_url":"https://api.github.com/repos/canonical-ols/talisker-flask-example/issues{/number}","pulls_url":"https://api.github.com/repos/canonical-ols/talisker-flask-example/pulls{/number}","milestones_url":"https://api.github.com/repos/canonical-ols/talisker-flask-example/milestones{/number}","notifications_url":"https://api.github.com/repos/canonical-ols/talisker-flask-example/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/canonical-ols/talisker-flask-example/labels{/name}","releases_url":"https://api.github.com/repos/canonical-ols/talisker-flask-example/releases{/id}","deployments_url":"https://api.github.com/repos/canonical-ols/talisker-flask-example/deployments","created_at":"2016-11-18T13:01:17Z","updated_at":"2016-11-21T21:42:07Z","pushed_at":"2016-12-01T18:41:54Z","git_url":"git://github.com/canonical-ols/talisker-flask-example.git","ssh_url":"git@github.com:canonical-ols/talisker-flask-example.git","clone_url":"https://github.com/canonical-ols/talisker-flask-example.git","svn_url":"https://github.com/canonical-ols/talisker-flask-example","homepage":null,"size":66,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/canonical-ols/talisker-flask-example/pulls/2"},"html":{"href":"https://github.com/canonical-ols/talisker-flask-example/pull/2"},"issue":{"href":"https://api.github.com/repos/canonical-ols/talisker-flask-example/issues/2"},"comments":{"href":"https://api.github.com/repos/canonical-ols/talisker-flask-example/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/canonical-ols/talisker-flask-example/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/canonical-ols/talisker-flask-example/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/canonical-ols/talisker-flask-example/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/canonical-ols/talisker-flask-example/statuses/8b1b565f29da7fe4adee8134929a38464a23b3b5"}}}}
{"actor":{"display_login":"caio1982"}}