{"action":"created","issue":{"url":"https://api.github.com/repos/puppetlabs/puppet/issues/5195","repository_url":"https://api.github.com/repos/puppetlabs/puppet","labels_url":"https://api.github.com/repos/puppetlabs/puppet/issues/5195/labels{/name}","comments_url":"https://api.github.com/repos/puppetlabs/puppet/issues/5195/comments","events_url":"https://api.github.com/repos/puppetlabs/puppet/issues/5195/events","html_url":"https://github.com/puppetlabs/puppet/pull/5195","id":170777711,"number":5195,"title":"(maint) add tests for installdir and version","user":{"login":"MosesMendoza","id":819133,"avatar_url":"https://avatars.githubusercontent.com/u/819133?v=3","gravatar_id":"","url":"https://api.github.com/users/MosesMendoza","html_url":"https://github.com/MosesMendoza","followers_url":"https://api.github.com/users/MosesMendoza/followers","following_url":"https://api.github.com/users/MosesMendoza/following{/other_user}","gists_url":"https://api.github.com/users/MosesMendoza/gists{/gist_id}","starred_url":"https://api.github.com/users/MosesMendoza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MosesMendoza/subscriptions","organizations_url":"https://api.github.com/users/MosesMendoza/orgs","repos_url":"https://api.github.com/users/MosesMendoza/repos","events_url":"https://api.github.com/users/MosesMendoza/events{/privacy}","received_events_url":"https://api.github.com/users/MosesMendoza/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-08-12T00:37:51Z","updated_at":"2016-08-12T23:37:17Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppet/pulls/5195","html_url":"https://github.com/puppetlabs/puppet/pull/5195","diff_url":"https://github.com/puppetlabs/puppet/pull/5195.diff","patch_url":"https://github.com/puppetlabs/puppet/pull/5195.patch"},"body":"(PA-466) This PR adds a new test to ensure the presence of the version file as laid down by the AIO in accordance with the puppet agent path specification after a recent set of changes to packaging of the AIO impacted the VERSION file creation and a regression was discovered in associated logic. This is added as a new test (as opposed to an additional step in 'ensure_puppet-agent_paths') to take advantage of the benefits of `skip_test` since this test only applies to\r\npackaged artifacts and not git/gem which don't create a VERSION file. \r\n\r\nThis PR also adds a test to ensure the fact env_windows_installdir is present and set to the correct directory. This fact is set via the environment.bat file on Windows installations and recently was impacted by a regression in that file, so a test is warranted. This test is added as its own file as opposed to the 4654_facts_face.rb file because that test seemed in spirit to be testing the functionatlity of `puppet facts` rather than any specific fact, while this test is for an explicit fact. This test is confined to Windows and test runs running from AIO packages (PE/FOSS) as those\r\nenvironments are expected to have sourced a functional environment.bat."},"comment":{"url":"https://api.github.com/repos/puppetlabs/puppet/issues/comments/239584478","html_url":"https://github.com/puppetlabs/puppet/pull/5195#issuecomment-239584478","issue_url":"https://api.github.com/repos/puppetlabs/puppet/issues/5195","id":239584478,"user":{"login":"Iristyle","id":394081,"avatar_url":"https://avatars.githubusercontent.com/u/394081?v=3","gravatar_id":"","url":"https://api.github.com/users/Iristyle","html_url":"https://github.com/Iristyle","followers_url":"https://api.github.com/users/Iristyle/followers","following_url":"https://api.github.com/users/Iristyle/following{/other_user}","gists_url":"https://api.github.com/users/Iristyle/gists{/gist_id}","starred_url":"https://api.github.com/users/Iristyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Iristyle/subscriptions","organizations_url":"https://api.github.com/users/Iristyle/orgs","repos_url":"https://api.github.com/users/Iristyle/repos","events_url":"https://api.github.com/users/Iristyle/events{/privacy}","received_events_url":"https://api.github.com/users/Iristyle/received_events","type":"User","site_admin":false},"created_at":"2016-08-12T23:37:16Z","updated_at":"2016-08-12T23:37:16Z","body":"Aside from the arch part, I think this looks pretty good..."}}
{"actor":{"display_login":"Iristyle"}}