{"action":"closed","number":11547,"pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/11547","id":89952180,"html_url":"https://github.com/ceph/ceph/pull/11547","diff_url":"https://github.com/ceph/ceph/pull/11547.diff","patch_url":"https://github.com/ceph/ceph/pull/11547.patch","issue_url":"https://api.github.com/repos/ceph/ceph/issues/11547","number":11547,"state":"closed","locked":false,"title":"osd/command tell: check pgid at the right time","user":{"login":"javeme","id":9625821,"avatar_url":"https://avatars.githubusercontent.com/u/9625821?v=3","gravatar_id":"","url":"https://api.github.com/users/javeme","html_url":"https://github.com/javeme","followers_url":"https://api.github.com/users/javeme/followers","following_url":"https://api.github.com/users/javeme/following{/other_user}","gists_url":"https://api.github.com/users/javeme/gists{/gist_id}","starred_url":"https://api.github.com/users/javeme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javeme/subscriptions","organizations_url":"https://api.github.com/users/javeme/orgs","repos_url":"https://api.github.com/users/javeme/repos","events_url":"https://api.github.com/users/javeme/events{/privacy}","received_events_url":"https://api.github.com/users/javeme/received_events","type":"User","site_admin":false},"body":"Run a command: \"ceph tell osd.0 query\", and it outputs the following error message:\n  Error EINVAL: unrecognized command! [{\"prefix\": \"query\"}]\n\nIn fact, the command \"query\" exists, but it requires one more input parameter \"pgid\", therefore the following error information will be more appropriate:\n  Error EINVAL: no pgid specified\n\nIn this patch, we check the parameter pgid after recognizing a command (like \"query\" or \"list_missing\"), rather than before it. Just getting and checking pgid [here (Line 5550)](https://github.com/ceph/ceph/pull/11547/commits/3f6736613c830613a1f9bfad6e3c37a1eadeb2f3#diff-fa6c2eba8356ae1442d1bf749beacfdfL5550)  is more appropriate.\n\nSigned-off-by: Javeme javaloveme@gmail.com\n","created_at":"2016-10-19T07:01:58Z","updated_at":"2016-10-31T23:36:17Z","closed_at":"2016-10-31T23:36:17Z","merged_at":"2016-10-31T23:36:17Z","merge_commit_sha":"bf9df72899dfd49ba930c5d4bf277c1b3723c77b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ceph/ceph/pulls/11547/commits","review_comments_url":"https://api.github.com/repos/ceph/ceph/pulls/11547/comments","review_comment_url":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/11547/comments","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/ef14b7b760a4adfd7b0f3fe13b12658f3f2a739f","head":{"label":"javeme:check-pgid","ref":"check-pgid","sha":"ef14b7b760a4adfd7b0f3fe13b12658f3f2a739f","user":{"login":"javeme","id":9625821,"avatar_url":"https://avatars.githubusercontent.com/u/9625821?v=3","gravatar_id":"","url":"https://api.github.com/users/javeme","html_url":"https://github.com/javeme","followers_url":"https://api.github.com/users/javeme/followers","following_url":"https://api.github.com/users/javeme/following{/other_user}","gists_url":"https://api.github.com/users/javeme/gists{/gist_id}","starred_url":"https://api.github.com/users/javeme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javeme/subscriptions","organizations_url":"https://api.github.com/users/javeme/orgs","repos_url":"https://api.github.com/users/javeme/repos","events_url":"https://api.github.com/users/javeme/events{/privacy}","received_events_url":"https://api.github.com/users/javeme/received_events","type":"User","site_admin":false},"repo":{"id":71244376,"name":"ceph","full_name":"javeme/ceph","owner":{"login":"javeme","id":9625821,"avatar_url":"https://avatars.githubusercontent.com/u/9625821?v=3","gravatar_id":"","url":"https://api.github.com/users/javeme","html_url":"https://github.com/javeme","followers_url":"https://api.github.com/users/javeme/followers","following_url":"https://api.github.com/users/javeme/following{/other_user}","gists_url":"https://api.github.com/users/javeme/gists{/gist_id}","starred_url":"https://api.github.com/users/javeme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javeme/subscriptions","organizations_url":"https://api.github.com/users/javeme/orgs","repos_url":"https://api.github.com/users/javeme/repos","events_url":"https://api.github.com/users/javeme/events{/privacy}","received_events_url":"https://api.github.com/users/javeme/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/javeme/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":true,"url":"https://api.github.com/repos/javeme/ceph","forks_url":"https://api.github.com/repos/javeme/ceph/forks","keys_url":"https://api.github.com/repos/javeme/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/javeme/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/javeme/ceph/teams","hooks_url":"https://api.github.com/repos/javeme/ceph/hooks","issue_events_url":"https://api.github.com/repos/javeme/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/javeme/ceph/events","assignees_url":"https://api.github.com/repos/javeme/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/javeme/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/javeme/ceph/tags","blobs_url":"https://api.github.com/repos/javeme/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/javeme/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/javeme/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/javeme/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/javeme/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/javeme/ceph/languages","stargazers_url":"https://api.github.com/repos/javeme/ceph/stargazers","contributors_url":"https://api.github.com/repos/javeme/ceph/contributors","subscribers_url":"https://api.github.com/repos/javeme/ceph/subscribers","subscription_url":"https://api.github.com/repos/javeme/ceph/subscription","commits_url":"https://api.github.com/repos/javeme/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/javeme/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/javeme/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/javeme/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/javeme/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/javeme/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/javeme/ceph/merges","archive_url":"https://api.github.com/repos/javeme/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/javeme/ceph/downloads","issues_url":"https://api.github.com/repos/javeme/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/javeme/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/javeme/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/javeme/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/javeme/ceph/labels{/name}","releases_url":"https://api.github.com/repos/javeme/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/javeme/ceph/deployments","created_at":"2016-10-18T12:10:20Z","updated_at":"2016-10-18T12:10:43Z","pushed_at":"2016-10-21T10:24:39Z","git_url":"git://github.com/javeme/ceph.git","ssh_url":"git@github.com:javeme/ceph.git","clone_url":"https://github.com/javeme/ceph.git","svn_url":"https://github.com/javeme/ceph","homepage":"http://ceph.com","size":184129,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ceph:master","ref":"master","sha":"eb9cf0bda013a2b619bb93b7f0229a095a5ccdaa","user":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":2310495,"name":"ceph","full_name":"ceph/ceph","owner":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ceph/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":false,"url":"https://api.github.com/repos/ceph/ceph","forks_url":"https://api.github.com/repos/ceph/ceph/forks","keys_url":"https://api.github.com/repos/ceph/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph/teams","hooks_url":"https://api.github.com/repos/ceph/ceph/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph/events","assignees_url":"https://api.github.com/repos/ceph/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph/tags","blobs_url":"https://api.github.com/repos/ceph/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph/subscription","commits_url":"https://api.github.com/repos/ceph/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph/merges","archive_url":"https://api.github.com/repos/ceph/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph/downloads","issues_url":"https://api.github.com/repos/ceph/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/ceph/ceph/deployments","created_at":"2011-09-01T21:41:26Z","updated_at":"2016-10-31T20:27:16Z","pushed_at":"2016-10-31T23:36:17Z","git_url":"git://github.com/ceph/ceph.git","ssh_url":"git@github.com:ceph/ceph.git","clone_url":"https://github.com/ceph/ceph.git","svn_url":"https://github.com/ceph/ceph","homepage":"http://ceph.com","size":246952,"stargazers_count":2588,"watchers_count":2588,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1525,"mirror_url":null,"open_issues_count":380,"forks":1525,"open_issues":380,"watchers":2588,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/11547"},"html":{"href":"https://github.com/ceph/ceph/pull/11547"},"issue":{"href":"https://api.github.com/repos/ceph/ceph/issues/11547"},"comments":{"href":"https://api.github.com/repos/ceph/ceph/issues/11547/comments"},"review_comments":{"href":"https://api.github.com/repos/ceph/ceph/pulls/11547/comments"},"review_comment":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ceph/ceph/pulls/11547/commits"},"statuses":{"href":"https://api.github.com/repos/ceph/ceph/statuses/ef14b7b760a4adfd7b0f3fe13b12658f3f2a739f"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"yuriw","id":3876474,"avatar_url":"https://avatars.githubusercontent.com/u/3876474?v=3","gravatar_id":"","url":"https://api.github.com/users/yuriw","html_url":"https://github.com/yuriw","followers_url":"https://api.github.com/users/yuriw/followers","following_url":"https://api.github.com/users/yuriw/following{/other_user}","gists_url":"https://api.github.com/users/yuriw/gists{/gist_id}","starred_url":"https://api.github.com/users/yuriw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuriw/subscriptions","organizations_url":"https://api.github.com/users/yuriw/orgs","repos_url":"https://api.github.com/users/yuriw/repos","events_url":"https://api.github.com/users/yuriw/events{/privacy}","received_events_url":"https://api.github.com/users/yuriw/received_events","type":"User","site_admin":false},"comments":1,"review_comments":2,"commits":1,"additions":4,"deletions":5,"changed_files":1}}
{"actor":{"display_login":"yuriw"}}