{"action":"created","issue":{"url":"https://api.github.com/repos/alphagov/paas-cf/issues/677","repository_url":"https://api.github.com/repos/alphagov/paas-cf","labels_url":"https://api.github.com/repos/alphagov/paas-cf/issues/677/labels{/name}","comments_url":"https://api.github.com/repos/alphagov/paas-cf/issues/677/comments","events_url":"https://api.github.com/repos/alphagov/paas-cf/issues/677/events","html_url":"https://github.com/alphagov/paas-cf/pull/677","id":196453180,"number":677,"title":"[#SUPPORT] Only enable routes drop monitor in dev and prod","user":{"login":"keymon","id":280032,"avatar_url":"https://avatars.githubusercontent.com/u/280032?v=3","gravatar_id":"","url":"https://api.github.com/users/keymon","html_url":"https://github.com/keymon","followers_url":"https://api.github.com/users/keymon/followers","following_url":"https://api.github.com/users/keymon/following{/other_user}","gists_url":"https://api.github.com/users/keymon/gists{/gist_id}","starred_url":"https://api.github.com/users/keymon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keymon/subscriptions","organizations_url":"https://api.github.com/users/keymon/orgs","repos_url":"https://api.github.com/users/keymon/repos","events_url":"https://api.github.com/users/keymon/events{/privacy}","received_events_url":"https://api.github.com/users/keymon/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-12-19T16:13:21Z","updated_at":"2016-12-21T15:20:44Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/alphagov/paas-cf/pulls/677","html_url":"https://github.com/alphagov/paas-cf/pull/677","diff_url":"https://github.com/alphagov/paas-cf/pull/677.diff","patch_url":"https://github.com/alphagov/paas-cf/pull/677.patch"},"body":"What?\r\n-----\r\n\r\nThe `router_routes_drop` monitor get easily triggered when running the tests in environments with little routes, like ci or staging.\r\n\r\nWe do not need to monitor this on those environments, but it is still useful in prod. We can also keep it in dev for testing/development.\r\n\r\n> Note: as we add `count`, it will actually recreate the monitor in prod, because the ID changes (add a .0 suffix). That is fine and expected.\r\n\r\nHow to test?\r\n------------\r\n\r\nYou can apply these monitors in dev like this:\r\n\r\n```\r\nPAAS_CF_DIR=$(pwd)\r\nmkdir /tmp/testing_tf\r\ncd /tmp/testing_tf\r\nln -s ${PAAS_CF_DIR}/terraform/datadog/{datadog.tf,variables.tf,router.tf} .\r\n\r\nterraform apply -var datadog_api_key=$(paas-pass datadog/dev/datadog_api_key) -var datadog_app_key=$(paas-pass datadog/dev/datadog_app_key) -var aws_account=dev  -var env=hector -var-file  ${PAAS_CF_DIR}/terraform/dev.tfvars\r\n```\r\n\r\nYou will see that it creates the monitor.\r\n\r\nNow run with a different vars file:\r\n\r\n```\r\nterraform apply -var datadog_api_key=$(paas-pass datadog/dev/datadog_api_key) -var datadog_app_key=$(paas-pass datadog/dev/datadog_app_key) -var aws_account=dev  -var env=hector -var-file  ${PAAS_CF_DIR}/terraform/ci.tfvars\r\n```\r\n\r\nIt will destroy the old monitor.\r\n\r\nRemember do `terraform destroy`\r\n\r\nWho?\r\n---\r\n\r\nAnyone but @keymon"},"comment":{"url":"https://api.github.com/repos/alphagov/paas-cf/issues/comments/268548557","html_url":"https://github.com/alphagov/paas-cf/pull/677#issuecomment-268548557","issue_url":"https://api.github.com/repos/alphagov/paas-cf/issues/677","id":268548557,"user":{"login":"saliceti","id":8416694,"avatar_url":"https://avatars.githubusercontent.com/u/8416694?v=3","gravatar_id":"","url":"https://api.github.com/users/saliceti","html_url":"https://github.com/saliceti","followers_url":"https://api.github.com/users/saliceti/followers","following_url":"https://api.github.com/users/saliceti/following{/other_user}","gists_url":"https://api.github.com/users/saliceti/gists{/gist_id}","starred_url":"https://api.github.com/users/saliceti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saliceti/subscriptions","organizations_url":"https://api.github.com/users/saliceti/orgs","repos_url":"https://api.github.com/users/saliceti/repos","events_url":"https://api.github.com/users/saliceti/events{/privacy}","received_events_url":"https://api.github.com/users/saliceti/received_events","type":"User","site_admin":false},"created_at":"2016-12-21T15:20:44Z","updated_at":"2016-12-21T15:20:44Z","body":"Can we rename the variable `__datadog_monitor_total__routes_drop__enabled` to `datadog_monitor_total_routes_drop_enabled`?\r\nThis would be more in line with the rest of the style."}}
{"actor":{"display_login":"saliceti"}}