{"action":"created","issue":{"url":"https://api.github.com/repos/apache/accumulo/issues/159","repository_url":"https://api.github.com/repos/apache/accumulo","labels_url":"https://api.github.com/repos/apache/accumulo/issues/159/labels{/name}","comments_url":"https://api.github.com/repos/apache/accumulo/issues/159/comments","events_url":"https://api.github.com/repos/apache/accumulo/issues/159/events","html_url":"https://github.com/apache/accumulo/pull/159","id":180353210,"number":159,"title":"ACCUMULO-1280: many changes for closing iterators","user":{"login":"milleruntime","id":11872539,"avatar_url":"https://avatars.githubusercontent.com/u/11872539?v=3","gravatar_id":"","url":"https://api.github.com/users/milleruntime","html_url":"https://github.com/milleruntime","followers_url":"https://api.github.com/users/milleruntime/followers","following_url":"https://api.github.com/users/milleruntime/following{/other_user}","gists_url":"https://api.github.com/users/milleruntime/gists{/gist_id}","starred_url":"https://api.github.com/users/milleruntime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/milleruntime/subscriptions","organizations_url":"https://api.github.com/users/milleruntime/orgs","repos_url":"https://api.github.com/users/milleruntime/repos","events_url":"https://api.github.com/users/milleruntime/events{/privacy}","received_events_url":"https://api.github.com/users/milleruntime/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-09-30T16:59:15Z","updated_at":"2016-11-16T16:06:32Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/accumulo/pulls/159","html_url":"https://github.com/apache/accumulo/pull/159","diff_url":"https://github.com/apache/accumulo/pull/159.diff","patch_url":"https://github.com/apache/accumulo/pull/159.patch"},"body":"Looking for feedback on first round of changes and if there are more places close can be called.\n- made SortedKeyValueIterator extend AutoCloseable\n- in SKVI - defined default close method so it is not required by implementations\n- in SKVI - defined default closeSafely to allow calling of close in a Java 8 stream\n- implemented close method where Iterator contained a SKVI source\n- modified Scanner and Compactor to utilize AutoCloseable and try-with-resources\n\nTODO: write test to verify close on wrapped iterators will propagate through\n"},"comment":{"url":"https://api.github.com/repos/apache/accumulo/issues/comments/260986872","html_url":"https://github.com/apache/accumulo/pull/159#issuecomment-260986872","issue_url":"https://api.github.com/repos/apache/accumulo/issues/159","id":260986872,"user":{"login":"milleruntime","id":11872539,"avatar_url":"https://avatars.githubusercontent.com/u/11872539?v=3","gravatar_id":"","url":"https://api.github.com/users/milleruntime","html_url":"https://github.com/milleruntime","followers_url":"https://api.github.com/users/milleruntime/followers","following_url":"https://api.github.com/users/milleruntime/following{/other_user}","gists_url":"https://api.github.com/users/milleruntime/gists{/gist_id}","starred_url":"https://api.github.com/users/milleruntime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/milleruntime/subscriptions","organizations_url":"https://api.github.com/users/milleruntime/orgs","repos_url":"https://api.github.com/users/milleruntime/repos","events_url":"https://api.github.com/users/milleruntime/events{/privacy}","received_events_url":"https://api.github.com/users/milleruntime/received_events","type":"User","site_admin":false},"created_at":"2016-11-16T16:06:32Z","updated_at":"2016-11-16T16:06:32Z","body":"After discussing the issues with these changes with @keith-turner we decided to narrow the scope of the close implementation to only be for User Iterators. My attempt at trying to close iterators at the system level was dangerous and unnecessary. There are already mechanisms in place for handling resources at the lower levels. "}}
{"actor":{"display_login":"milleruntime"}}