{"action":"closed","number":693,"pull_request":{"url":"https://api.github.com/repos/cfpb/hmda-platform/pulls/693","id":94839445,"html_url":"https://github.com/cfpb/hmda-platform/pull/693","diff_url":"https://github.com/cfpb/hmda-platform/pull/693.diff","patch_url":"https://github.com/cfpb/hmda-platform/pull/693.patch","issue_url":"https://api.github.com/repos/cfpb/hmda-platform/issues/693","number":693,"state":"closed","locked":false,"title":"Simplify Macro Tests","user":{"login":"kgudel","id":13244336,"avatar_url":"https://avatars.githubusercontent.com/u/13244336?v=3","gravatar_id":"","url":"https://api.github.com/users/kgudel","html_url":"https://github.com/kgudel","followers_url":"https://api.github.com/users/kgudel/followers","following_url":"https://api.github.com/users/kgudel/following{/other_user}","gists_url":"https://api.github.com/users/kgudel/gists{/gist_id}","starred_url":"https://api.github.com/users/kgudel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kgudel/subscriptions","organizations_url":"https://api.github.com/users/kgudel/orgs","repos_url":"https://api.github.com/users/kgudel/repos","events_url":"https://api.github.com/users/kgudel/events{/privacy}","received_events_url":"https://api.github.com/users/kgudel/received_events","type":"User","site_admin":false},"body":"This PR is in response to the fact that many of our macro test suites are essentially the same with only changes to a couple of variables. In order to address this, this PR introduces a new trait `SimpifiedMacroSpec` which contains a function to run the three tests in most macro specs with the only a change to the necessary variables.","created_at":"2016-11-22T15:44:55Z","updated_at":"2016-11-29T13:11:32Z","closed_at":"2016-11-29T13:11:32Z","merged_at":"2016-11-29T13:11:32Z","merge_commit_sha":"0df512c7c2d32167cc37ca8ec0489121501cc9fd","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/cfpb/hmda-platform/pulls/693/commits","review_comments_url":"https://api.github.com/repos/cfpb/hmda-platform/pulls/693/comments","review_comment_url":"https://api.github.com/repos/cfpb/hmda-platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cfpb/hmda-platform/issues/693/comments","statuses_url":"https://api.github.com/repos/cfpb/hmda-platform/statuses/2022a1331891dfbe91c851fcf3ef5eec151f4164","head":{"label":"kgudel:macroTestSimplification","ref":"macroTestSimplification","sha":"2022a1331891dfbe91c851fcf3ef5eec151f4164","user":{"login":"kgudel","id":13244336,"avatar_url":"https://avatars.githubusercontent.com/u/13244336?v=3","gravatar_id":"","url":"https://api.github.com/users/kgudel","html_url":"https://github.com/kgudel","followers_url":"https://api.github.com/users/kgudel/followers","following_url":"https://api.github.com/users/kgudel/following{/other_user}","gists_url":"https://api.github.com/users/kgudel/gists{/gist_id}","starred_url":"https://api.github.com/users/kgudel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kgudel/subscriptions","organizations_url":"https://api.github.com/users/kgudel/orgs","repos_url":"https://api.github.com/users/kgudel/repos","events_url":"https://api.github.com/users/kgudel/events{/privacy}","received_events_url":"https://api.github.com/users/kgudel/received_events","type":"User","site_admin":false},"repo":{"id":57915203,"name":"hmda-platform","full_name":"kgudel/hmda-platform","owner":{"login":"kgudel","id":13244336,"avatar_url":"https://avatars.githubusercontent.com/u/13244336?v=3","gravatar_id":"","url":"https://api.github.com/users/kgudel","html_url":"https://github.com/kgudel","followers_url":"https://api.github.com/users/kgudel/followers","following_url":"https://api.github.com/users/kgudel/following{/other_user}","gists_url":"https://api.github.com/users/kgudel/gists{/gist_id}","starred_url":"https://api.github.com/users/kgudel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kgudel/subscriptions","organizations_url":"https://api.github.com/users/kgudel/orgs","repos_url":"https://api.github.com/users/kgudel/repos","events_url":"https://api.github.com/users/kgudel/events{/privacy}","received_events_url":"https://api.github.com/users/kgudel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kgudel/hmda-platform","description":null,"fork":true,"url":"https://api.github.com/repos/kgudel/hmda-platform","forks_url":"https://api.github.com/repos/kgudel/hmda-platform/forks","keys_url":"https://api.github.com/repos/kgudel/hmda-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kgudel/hmda-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kgudel/hmda-platform/teams","hooks_url":"https://api.github.com/repos/kgudel/hmda-platform/hooks","issue_events_url":"https://api.github.com/repos/kgudel/hmda-platform/issues/events{/number}","events_url":"https://api.github.com/repos/kgudel/hmda-platform/events","assignees_url":"https://api.github.com/repos/kgudel/hmda-platform/assignees{/user}","branches_url":"https://api.github.com/repos/kgudel/hmda-platform/branches{/branch}","tags_url":"https://api.github.com/repos/kgudel/hmda-platform/tags","blobs_url":"https://api.github.com/repos/kgudel/hmda-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kgudel/hmda-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kgudel/hmda-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/kgudel/hmda-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kgudel/hmda-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/kgudel/hmda-platform/languages","stargazers_url":"https://api.github.com/repos/kgudel/hmda-platform/stargazers","contributors_url":"https://api.github.com/repos/kgudel/hmda-platform/contributors","subscribers_url":"https://api.github.com/repos/kgudel/hmda-platform/subscribers","subscription_url":"https://api.github.com/repos/kgudel/hmda-platform/subscription","commits_url":"https://api.github.com/repos/kgudel/hmda-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/kgudel/hmda-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/kgudel/hmda-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/kgudel/hmda-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/kgudel/hmda-platform/contents/{+path}","compare_url":"https://api.github.com/repos/kgudel/hmda-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kgudel/hmda-platform/merges","archive_url":"https://api.github.com/repos/kgudel/hmda-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kgudel/hmda-platform/downloads","issues_url":"https://api.github.com/repos/kgudel/hmda-platform/issues{/number}","pulls_url":"https://api.github.com/repos/kgudel/hmda-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/kgudel/hmda-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/kgudel/hmda-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kgudel/hmda-platform/labels{/name}","releases_url":"https://api.github.com/repos/kgudel/hmda-platform/releases{/id}","deployments_url":"https://api.github.com/repos/kgudel/hmda-platform/deployments","created_at":"2016-05-02T19:22:32Z","updated_at":"2016-05-02T19:22:35Z","pushed_at":"2016-11-29T03:16:01Z","git_url":"git://github.com/kgudel/hmda-platform.git","ssh_url":"git@github.com:kgudel/hmda-platform.git","clone_url":"https://github.com/kgudel/hmda-platform.git","svn_url":"https://github.com/kgudel/hmda-platform","homepage":"","size":11973,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cfpb:master","ref":"master","sha":"507d33defeb681f680f47353c184e58e9898513e","user":{"login":"cfpb","id":1071563,"avatar_url":"https://avatars.githubusercontent.com/u/1071563?v=3","gravatar_id":"","url":"https://api.github.com/users/cfpb","html_url":"https://github.com/cfpb","followers_url":"https://api.github.com/users/cfpb/followers","following_url":"https://api.github.com/users/cfpb/following{/other_user}","gists_url":"https://api.github.com/users/cfpb/gists{/gist_id}","starred_url":"https://api.github.com/users/cfpb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfpb/subscriptions","organizations_url":"https://api.github.com/users/cfpb/orgs","repos_url":"https://api.github.com/users/cfpb/repos","events_url":"https://api.github.com/users/cfpb/events{/privacy}","received_events_url":"https://api.github.com/users/cfpb/received_events","type":"Organization","site_admin":false},"repo":{"id":50141662,"name":"hmda-platform","full_name":"cfpb/hmda-platform","owner":{"login":"cfpb","id":1071563,"avatar_url":"https://avatars.githubusercontent.com/u/1071563?v=3","gravatar_id":"","url":"https://api.github.com/users/cfpb","html_url":"https://github.com/cfpb","followers_url":"https://api.github.com/users/cfpb/followers","following_url":"https://api.github.com/users/cfpb/following{/other_user}","gists_url":"https://api.github.com/users/cfpb/gists{/gist_id}","starred_url":"https://api.github.com/users/cfpb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfpb/subscriptions","organizations_url":"https://api.github.com/users/cfpb/orgs","repos_url":"https://api.github.com/users/cfpb/repos","events_url":"https://api.github.com/users/cfpb/events{/privacy}","received_events_url":"https://api.github.com/users/cfpb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cfpb/hmda-platform","description":null,"fork":false,"url":"https://api.github.com/repos/cfpb/hmda-platform","forks_url":"https://api.github.com/repos/cfpb/hmda-platform/forks","keys_url":"https://api.github.com/repos/cfpb/hmda-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cfpb/hmda-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cfpb/hmda-platform/teams","hooks_url":"https://api.github.com/repos/cfpb/hmda-platform/hooks","issue_events_url":"https://api.github.com/repos/cfpb/hmda-platform/issues/events{/number}","events_url":"https://api.github.com/repos/cfpb/hmda-platform/events","assignees_url":"https://api.github.com/repos/cfpb/hmda-platform/assignees{/user}","branches_url":"https://api.github.com/repos/cfpb/hmda-platform/branches{/branch}","tags_url":"https://api.github.com/repos/cfpb/hmda-platform/tags","blobs_url":"https://api.github.com/repos/cfpb/hmda-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cfpb/hmda-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cfpb/hmda-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/cfpb/hmda-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cfpb/hmda-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/cfpb/hmda-platform/languages","stargazers_url":"https://api.github.com/repos/cfpb/hmda-platform/stargazers","contributors_url":"https://api.github.com/repos/cfpb/hmda-platform/contributors","subscribers_url":"https://api.github.com/repos/cfpb/hmda-platform/subscribers","subscription_url":"https://api.github.com/repos/cfpb/hmda-platform/subscription","commits_url":"https://api.github.com/repos/cfpb/hmda-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/cfpb/hmda-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/cfpb/hmda-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/cfpb/hmda-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/cfpb/hmda-platform/contents/{+path}","compare_url":"https://api.github.com/repos/cfpb/hmda-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cfpb/hmda-platform/merges","archive_url":"https://api.github.com/repos/cfpb/hmda-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cfpb/hmda-platform/downloads","issues_url":"https://api.github.com/repos/cfpb/hmda-platform/issues{/number}","pulls_url":"https://api.github.com/repos/cfpb/hmda-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/cfpb/hmda-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/cfpb/hmda-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cfpb/hmda-platform/labels{/name}","releases_url":"https://api.github.com/repos/cfpb/hmda-platform/releases{/id}","deployments_url":"https://api.github.com/repos/cfpb/hmda-platform/deployments","created_at":"2016-01-21T22:39:17Z","updated_at":"2016-11-04T07:39:54Z","pushed_at":"2016-11-29T13:11:32Z","git_url":"git://github.com/cfpb/hmda-platform.git","ssh_url":"git@github.com:cfpb/hmda-platform.git","clone_url":"https://github.com/cfpb/hmda-platform.git","svn_url":"https://github.com/cfpb/hmda-platform","homepage":"","size":13535,"stargazers_count":6,"watchers_count":6,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":71,"forks":12,"open_issues":71,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cfpb/hmda-platform/pulls/693"},"html":{"href":"https://github.com/cfpb/hmda-platform/pull/693"},"issue":{"href":"https://api.github.com/repos/cfpb/hmda-platform/issues/693"},"comments":{"href":"https://api.github.com/repos/cfpb/hmda-platform/issues/693/comments"},"review_comments":{"href":"https://api.github.com/repos/cfpb/hmda-platform/pulls/693/comments"},"review_comment":{"href":"https://api.github.com/repos/cfpb/hmda-platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cfpb/hmda-platform/pulls/693/commits"},"statuses":{"href":"https://api.github.com/repos/cfpb/hmda-platform/statuses/2022a1331891dfbe91c851fcf3ef5eec151f4164"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"jmarin","id":438146,"avatar_url":"https://avatars.githubusercontent.com/u/438146?v=3","gravatar_id":"","url":"https://api.github.com/users/jmarin","html_url":"https://github.com/jmarin","followers_url":"https://api.github.com/users/jmarin/followers","following_url":"https://api.github.com/users/jmarin/following{/other_user}","gists_url":"https://api.github.com/users/jmarin/gists{/gist_id}","starred_url":"https://api.github.com/users/jmarin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmarin/subscriptions","organizations_url":"https://api.github.com/users/jmarin/orgs","repos_url":"https://api.github.com/users/jmarin/repos","events_url":"https://api.github.com/users/jmarin/events{/privacy}","received_events_url":"https://api.github.com/users/jmarin/received_events","type":"User","site_admin":false},"comments":2,"review_comments":3,"commits":7,"additions":87,"deletions":225,"changed_files":18}}
{"actor":{"display_login":"jmarin"}}