{"action":"created","issue":{"url":"https://api.github.com/repos/angular-ui/ui-router/issues/1079","labels_url":"https://api.github.com/repos/angular-ui/ui-router/issues/1079/labels{/name}","comments_url":"https://api.github.com/repos/angular-ui/ui-router/issues/1079/comments","events_url":"https://api.github.com/repos/angular-ui/ui-router/issues/1079/events","html_url":"https://github.com/angular-ui/ui-router/issues/1079","id":33610424,"number":1079,"title":"Problem with reloadOnSearch: false - change in stateParams doesn't reload ","user":{"login":"OriaLogic","id":7590272,"avatar_url":"https://avatars.githubusercontent.com/u/7590272?v=3","gravatar_id":"","url":"https://api.github.com/users/OriaLogic","html_url":"https://github.com/OriaLogic","followers_url":"https://api.github.com/users/OriaLogic/followers","following_url":"https://api.github.com/users/OriaLogic/following{/other_user}","gists_url":"https://api.github.com/users/OriaLogic/gists{/gist_id}","starred_url":"https://api.github.com/users/OriaLogic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OriaLogic/subscriptions","organizations_url":"https://api.github.com/users/OriaLogic/orgs","repos_url":"https://api.github.com/users/OriaLogic/repos","events_url":"https://api.github.com/users/OriaLogic/events{/privacy}","received_events_url":"https://api.github.com/users/OriaLogic/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/angular-ui/ui-router/labels/bug","name":"bug","color":"eb6420"}],"state":"closed","locked":false,"assignee":{"login":"christopherthielen","id":2053478,"avatar_url":"https://avatars.githubusercontent.com/u/2053478?v=3","gravatar_id":"","url":"https://api.github.com/users/christopherthielen","html_url":"https://github.com/christopherthielen","followers_url":"https://api.github.com/users/christopherthielen/followers","following_url":"https://api.github.com/users/christopherthielen/following{/other_user}","gists_url":"https://api.github.com/users/christopherthielen/gists{/gist_id}","starred_url":"https://api.github.com/users/christopherthielen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christopherthielen/subscriptions","organizations_url":"https://api.github.com/users/christopherthielen/orgs","repos_url":"https://api.github.com/users/christopherthielen/repos","events_url":"https://api.github.com/users/christopherthielen/events{/privacy}","received_events_url":"https://api.github.com/users/christopherthielen/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/angular-ui/ui-router/milestones/11","html_url":"https://github.com/angular-ui/ui-router/milestones/0.2.15","labels_url":"https://api.github.com/repos/angular-ui/ui-router/milestones/11/labels","id":1116809,"number":11,"title":"0.2.15","description":"Fix regressions from in 0.2.14","creator":{"login":"christopherthielen","id":2053478,"avatar_url":"https://avatars.githubusercontent.com/u/2053478?v=3","gravatar_id":"","url":"https://api.github.com/users/christopherthielen","html_url":"https://github.com/christopherthielen","followers_url":"https://api.github.com/users/christopherthielen/followers","following_url":"https://api.github.com/users/christopherthielen/following{/other_user}","gists_url":"https://api.github.com/users/christopherthielen/gists{/gist_id}","starred_url":"https://api.github.com/users/christopherthielen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christopherthielen/subscriptions","organizations_url":"https://api.github.com/users/christopherthielen/orgs","repos_url":"https://api.github.com/users/christopherthielen/repos","events_url":"https://api.github.com/users/christopherthielen/events{/privacy}","received_events_url":"https://api.github.com/users/christopherthielen/received_events","type":"User","site_admin":false},"open_issues":0,"closed_issues":8,"state":"closed","created_at":"2015-05-19T01:13:01Z","updated_at":"2015-05-19T13:06:22Z","due_on":"2015-05-22T05:00:00Z","closed_at":"2015-05-19T13:06:22Z"},"comments":32,"created_at":"2014-05-15T18:12:05Z","updated_at":"2016-01-20T17:29:42Z","closed_at":"2015-05-19T01:11:00Z","body":"Here is my issue:\r\n\r\nI navigate through a list of links, that display different images depending on the date in the search parameters (?from&to). \r\n\r\nThose search parameters should not trigger a state reload. Finally, here is my state declaration:\r\n```javascript\r\nstate('links/:linkId', {\r\n  url: \"/links/linkId?from&to\",\r\n  reloadOnSearch: false,\r\n  templateUrl: ...\r\n  Controller: ...\r\n});\r\n```\r\n\r\nBut then a huge problem shows up! When I try to navigate through my different links, reload doesn't happen anymore, so that I cannot pass from one link to another.\r\n\r\nAfter some digging in the code, I found out that when `reloadOnSearch` equals to false, triggers are always blocked because there's absolutely no checking of whether the changing parameters are search parameters or path parameters.\r\n\r\nSo actually, `reloadOnSearch` doesn't work as intended and should be renamed `reloadOnStateParamsChange`.\r\n\r\nI fixed the issue by checking if the state parameters that changed are search parameters or not, which seems to work fine.\r\n\r\nPlease tell me if I'm mistaking somewhere or if it is relevant, and also if you would be interested in a pull request or a plunkr. \r\n\r\nThanks in advance!"},"comment":{"url":"https://api.github.com/repos/angular-ui/ui-router/issues/comments/173292787","html_url":"https://github.com/angular-ui/ui-router/issues/1079#issuecomment-173292787","issue_url":"https://api.github.com/repos/angular-ui/ui-router/issues/1079","id":173292787,"user":{"login":"drothlis","id":12424,"avatar_url":"https://avatars.githubusercontent.com/u/12424?v=3","gravatar_id":"","url":"https://api.github.com/users/drothlis","html_url":"https://github.com/drothlis","followers_url":"https://api.github.com/users/drothlis/followers","following_url":"https://api.github.com/users/drothlis/following{/other_user}","gists_url":"https://api.github.com/users/drothlis/gists{/gist_id}","starred_url":"https://api.github.com/users/drothlis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drothlis/subscriptions","organizations_url":"https://api.github.com/users/drothlis/orgs","repos_url":"https://api.github.com/users/drothlis/repos","events_url":"https://api.github.com/users/drothlis/events{/privacy}","received_events_url":"https://api.github.com/users/drothlis/received_events","type":"User","site_admin":false},"created_at":"2016-01-20T17:29:42Z","updated_at":"2016-01-20T17:29:42Z","body":"@nateabele, @christopherthielen: Thanks, that's very helpful! :-)"}}