{"action":"created","comment":{"url":"https://api.github.com/repos/eclipse/xtext-extras/pulls/comments/78328706","id":78328706,"diff_hunk":"@@ -212,6 +226,16 @@ public void compile(Iterable<? extends CharSequence> sources, IAcceptor<Result>\n \tpublic void compile(final ResourceSet resourceSet, IAcceptor<Result> acceptor) {\n \t\ttry {\n \t\t\tList<Resource> resourcesToCheck = newArrayList(resourceSet.getResources());\n+\t\t\tif (generatorConfigProvider instanceof GeneratorConfigProvider) {\n+\t\t\t\tGeneratorConfigProvider configProvider = (GeneratorConfigProvider) generatorConfigProvider;\n+\t\t\t\tGeneratorConfig config = generatorConfigProvider.get(null);","path":"org.eclipse.xtext.xbase.testing/src/org/eclipse/xtext/xbase/testing/CompilationTestHelper.java","position":38,"original_position":38,"commit_id":"7e358229d6f5cee004ab9cb0389af49b95a230ed","original_commit_id":"7e358229d6f5cee004ab9cb0389af49b95a230ed","user":{"login":"svenefftinge","id":372735,"avatar_url":"https://avatars.githubusercontent.com/u/372735?v=3","gravatar_id":"","url":"https://api.github.com/users/svenefftinge","html_url":"https://github.com/svenefftinge","followers_url":"https://api.github.com/users/svenefftinge/followers","following_url":"https://api.github.com/users/svenefftinge/following{/other_user}","gists_url":"https://api.github.com/users/svenefftinge/gists{/gist_id}","starred_url":"https://api.github.com/users/svenefftinge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/svenefftinge/subscriptions","organizations_url":"https://api.github.com/users/svenefftinge/orgs","repos_url":"https://api.github.com/users/svenefftinge/repos","events_url":"https://api.github.com/users/svenefftinge/events{/privacy}","received_events_url":"https://api.github.com/users/svenefftinge/received_events","type":"User","site_admin":false},"body":"I'd prefer a constructor call to GeneratorConfig, instead of call the provider with null","created_at":"2016-09-12T08:03:19Z","updated_at":"2016-09-12T08:03:19Z","html_url":"https://github.com/eclipse/xtext-extras/pull/47#discussion_r78328706","pull_request_url":"https://api.github.com/repos/eclipse/xtext-extras/pulls/47","_links":{"self":{"href":"https://api.github.com/repos/eclipse/xtext-extras/pulls/comments/78328706"},"html":{"href":"https://github.com/eclipse/xtext-extras/pull/47#discussion_r78328706"},"pull_request":{"href":"https://api.github.com/repos/eclipse/xtext-extras/pulls/47"}}},"pull_request":{"url":"https://api.github.com/repos/eclipse/xtext-extras/pulls/47","id":83471435,"html_url":"https://github.com/eclipse/xtext-extras/pull/47","diff_url":"https://github.com/eclipse/xtext-extras/pull/47.diff","patch_url":"https://github.com/eclipse/xtext-extras/pull/47.patch","issue_url":"https://api.github.com/repos/eclipse/xtext-extras/issues/47","number":47,"state":"open","locked":false,"title":"46: Make setting Java version in compiler tests easier","user":{"login":"LorenzoBettini","id":1202254,"avatar_url":"https://avatars.githubusercontent.com/u/1202254?v=3","gravatar_id":"","url":"https://api.github.com/users/LorenzoBettini","html_url":"https://github.com/LorenzoBettini","followers_url":"https://api.github.com/users/LorenzoBettini/followers","following_url":"https://api.github.com/users/LorenzoBettini/following{/other_user}","gists_url":"https://api.github.com/users/LorenzoBettini/gists{/gist_id}","starred_url":"https://api.github.com/users/LorenzoBettini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LorenzoBettini/subscriptions","organizations_url":"https://api.github.com/users/LorenzoBettini/orgs","repos_url":"https://api.github.com/users/LorenzoBettini/repos","events_url":"https://api.github.com/users/LorenzoBettini/events{/privacy}","received_events_url":"https://api.github.com/users/LorenzoBettini/received_events","type":"User","site_admin":false},"body":"Closes #46\r\n\r\nTask-Url: #46\r\nSigned-off-by: Lorenzo Bettini <lorenzo.bettini@gmail.com>\r\n","created_at":"2016-08-31T15:09:32Z","updated_at":"2016-09-12T08:03:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d7743cccc847dea26ab0d9767c119807533fffad","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/xtext-extras/pulls/47/commits","review_comments_url":"https://api.github.com/repos/eclipse/xtext-extras/pulls/47/comments","review_comment_url":"https://api.github.com/repos/eclipse/xtext-extras/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/xtext-extras/issues/47/comments","statuses_url":"https://api.github.com/repos/eclipse/xtext-extras/statuses/7e358229d6f5cee004ab9cb0389af49b95a230ed","head":{"label":"eclipse:lb_task_46","ref":"lb_task_46","sha":"7e358229d6f5cee004ab9cb0389af49b95a230ed","user":{"login":"eclipse","id":56974,"avatar_url":"https://avatars.githubusercontent.com/u/56974?v=3","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":60115647,"name":"xtext-extras","full_name":"eclipse/xtext-extras","owner":{"login":"eclipse","id":56974,"avatar_url":"https://avatars.githubusercontent.com/u/56974?v=3","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eclipse/xtext-extras","description":"xtext-extras","fork":false,"url":"https://api.github.com/repos/eclipse/xtext-extras","forks_url":"https://api.github.com/repos/eclipse/xtext-extras/forks","keys_url":"https://api.github.com/repos/eclipse/xtext-extras/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/xtext-extras/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/xtext-extras/teams","hooks_url":"https://api.github.com/repos/eclipse/xtext-extras/hooks","issue_events_url":"https://api.github.com/repos/eclipse/xtext-extras/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/xtext-extras/events","assignees_url":"https://api.github.com/repos/eclipse/xtext-extras/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/xtext-extras/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/xtext-extras/tags","blobs_url":"https://api.github.com/repos/eclipse/xtext-extras/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/xtext-extras/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/xtext-extras/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/xtext-extras/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/xtext-extras/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/xtext-extras/languages","stargazers_url":"https://api.github.com/repos/eclipse/xtext-extras/stargazers","contributors_url":"https://api.github.com/repos/eclipse/xtext-extras/contributors","subscribers_url":"https://api.github.com/repos/eclipse/xtext-extras/subscribers","subscription_url":"https://api.github.com/repos/eclipse/xtext-extras/subscription","commits_url":"https://api.github.com/repos/eclipse/xtext-extras/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/xtext-extras/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/xtext-extras/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/xtext-extras/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/xtext-extras/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/xtext-extras/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/xtext-extras/merges","archive_url":"https://api.github.com/repos/eclipse/xtext-extras/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/xtext-extras/downloads","issues_url":"https://api.github.com/repos/eclipse/xtext-extras/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/xtext-extras/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/xtext-extras/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/xtext-extras/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/xtext-extras/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/xtext-extras/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/xtext-extras/deployments","created_at":"2016-05-31T19:00:27Z","updated_at":"2016-07-11T06:40:32Z","pushed_at":"2016-09-12T07:41:16Z","git_url":"git://github.com/eclipse/xtext-extras.git","ssh_url":"git@github.com:eclipse/xtext-extras.git","clone_url":"https://github.com/eclipse/xtext-extras.git","svn_url":"https://github.com/eclipse/xtext-extras","homepage":null,"size":20321,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":24,"forks":4,"open_issues":24,"watchers":2,"default_branch":"master"}},"base":{"label":"eclipse:master","ref":"master","sha":"bc372d234f71d48d465253e287da37c8feb6d63a","user":{"login":"eclipse","id":56974,"avatar_url":"https://avatars.githubusercontent.com/u/56974?v=3","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":60115647,"name":"xtext-extras","full_name":"eclipse/xtext-extras","owner":{"login":"eclipse","id":56974,"avatar_url":"https://avatars.githubusercontent.com/u/56974?v=3","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eclipse/xtext-extras","description":"xtext-extras","fork":false,"url":"https://api.github.com/repos/eclipse/xtext-extras","forks_url":"https://api.github.com/repos/eclipse/xtext-extras/forks","keys_url":"https://api.github.com/repos/eclipse/xtext-extras/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/xtext-extras/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/xtext-extras/teams","hooks_url":"https://api.github.com/repos/eclipse/xtext-extras/hooks","issue_events_url":"https://api.github.com/repos/eclipse/xtext-extras/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/xtext-extras/events","assignees_url":"https://api.github.com/repos/eclipse/xtext-extras/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/xtext-extras/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/xtext-extras/tags","blobs_url":"https://api.github.com/repos/eclipse/xtext-extras/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/xtext-extras/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/xtext-extras/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/xtext-extras/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/xtext-extras/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/xtext-extras/languages","stargazers_url":"https://api.github.com/repos/eclipse/xtext-extras/stargazers","contributors_url":"https://api.github.com/repos/eclipse/xtext-extras/contributors","subscribers_url":"https://api.github.com/repos/eclipse/xtext-extras/subscribers","subscription_url":"https://api.github.com/repos/eclipse/xtext-extras/subscription","commits_url":"https://api.github.com/repos/eclipse/xtext-extras/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/xtext-extras/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/xtext-extras/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/xtext-extras/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/xtext-extras/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/xtext-extras/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/xtext-extras/merges","archive_url":"https://api.github.com/repos/eclipse/xtext-extras/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/xtext-extras/downloads","issues_url":"https://api.github.com/repos/eclipse/xtext-extras/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/xtext-extras/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/xtext-extras/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/xtext-extras/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/xtext-extras/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/xtext-extras/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/xtext-extras/deployments","created_at":"2016-05-31T19:00:27Z","updated_at":"2016-07-11T06:40:32Z","pushed_at":"2016-09-12T07:41:16Z","git_url":"git://github.com/eclipse/xtext-extras.git","ssh_url":"git@github.com:eclipse/xtext-extras.git","clone_url":"https://github.com/eclipse/xtext-extras.git","svn_url":"https://github.com/eclipse/xtext-extras","homepage":null,"size":20321,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":24,"forks":4,"open_issues":24,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/xtext-extras/pulls/47"},"html":{"href":"https://github.com/eclipse/xtext-extras/pull/47"},"issue":{"href":"https://api.github.com/repos/eclipse/xtext-extras/issues/47"},"comments":{"href":"https://api.github.com/repos/eclipse/xtext-extras/issues/47/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/xtext-extras/pulls/47/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/xtext-extras/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/xtext-extras/pulls/47/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/xtext-extras/statuses/7e358229d6f5cee004ab9cb0389af49b95a230ed"}}}}
{"actor":{"display_login":"svenefftinge"}}