{"action":"created","comment":{"url":"https://api.github.com/repos/gokcehan/lf/pulls/comments/83561335","pull_request_review_id":4397672,"id":83561335,"diff_hunk":"@@ -202,9 +187,14 @@ func (e *CallExpr) eval(app *App, args []string) {\n \t\t\t}","path":"eval.go","position":37,"original_position":37,"commit_id":"664b728ab52a233011adcec758338f80ff19dcfa","original_commit_id":"664b728ab52a233011adcec758338f80ff19dcfa","user":{"login":"KenjiTakahashi","id":431488,"avatar_url":"https://avatars.githubusercontent.com/u/431488?v=3","gravatar_id":"","url":"https://api.github.com/users/KenjiTakahashi","html_url":"https://github.com/KenjiTakahashi","followers_url":"https://api.github.com/users/KenjiTakahashi/followers","following_url":"https://api.github.com/users/KenjiTakahashi/following{/other_user}","gists_url":"https://api.github.com/users/KenjiTakahashi/gists{/gist_id}","starred_url":"https://api.github.com/users/KenjiTakahashi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KenjiTakahashi/subscriptions","organizations_url":"https://api.github.com/users/KenjiTakahashi/orgs","repos_url":"https://api.github.com/users/KenjiTakahashi/repos","events_url":"https://api.github.com/users/KenjiTakahashi/events{/privacy}","received_events_url":"https://api.github.com/users/KenjiTakahashi/received_events","type":"User","site_admin":false},"body":"Unrelated, but shouldn't we be `return`ing in the block above*? If we fail to open the file, the code below might very well panic.\r\n\r\n*) Github does not let me comment on lines beyond the diff, pfft.","created_at":"2016-10-16T22:00:01Z","updated_at":"2016-10-16T22:00:01Z","html_url":"https://github.com/gokcehan/lf/pull/33#discussion_r83561335","pull_request_url":"https://api.github.com/repos/gokcehan/lf/pulls/33","_links":{"self":{"href":"https://api.github.com/repos/gokcehan/lf/pulls/comments/83561335"},"html":{"href":"https://github.com/gokcehan/lf/pull/33#discussion_r83561335"},"pull_request":{"href":"https://api.github.com/repos/gokcehan/lf/pulls/33"}}},"pull_request":{"url":"https://api.github.com/repos/gokcehan/lf/pulls/33","id":89541511,"html_url":"https://github.com/gokcehan/lf/pull/33","diff_url":"https://github.com/gokcehan/lf/pull/33.diff","patch_url":"https://github.com/gokcehan/lf/pull/33.patch","issue_url":"https://api.github.com/repos/gokcehan/lf/issues/33","number":33,"state":"open","locked":false,"title":"Refactor Nav API around symlinks handling (mostly)","user":{"login":"KenjiTakahashi","id":431488,"avatar_url":"https://avatars.githubusercontent.com/u/431488?v=3","gravatar_id":"","url":"https://api.github.com/users/KenjiTakahashi","html_url":"https://github.com/KenjiTakahashi","followers_url":"https://api.github.com/users/KenjiTakahashi/followers","following_url":"https://api.github.com/users/KenjiTakahashi/following{/other_user}","gists_url":"https://api.github.com/users/KenjiTakahashi/gists{/gist_id}","starred_url":"https://api.github.com/users/KenjiTakahashi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KenjiTakahashi/subscriptions","organizations_url":"https://api.github.com/users/KenjiTakahashi/orgs","repos_url":"https://api.github.com/users/KenjiTakahashi/repos","events_url":"https://api.github.com/users/KenjiTakahashi/events{/privacy}","received_events_url":"https://api.github.com/users/KenjiTakahashi/received_events","type":"User","site_admin":false},"body":"The brief summary is in the commit message, I'll elaborate here a bit about some things. There will be some comments inside the code as well.\r\n\r\nAd. 4: At first, I've mentioned that this might get annoying, but it turns out it's not. It's actually less annoying than having to get dir, check it's length, etc.\r\nAd. 7: Like I said, I like it better that way. Implementing an option to get the old behaviour back should be fairly easy, but is unrelated here. Maybe we can track it in #21? Or in other, separate issue.\r\n\r\nI've used Capitalised fields names, but I've noticed (later) that you're using all small letters in most cases. It works, of course, but I tend to think of unexported fields as \"private\". Can change it to small, if you want, no big deal.\r\n\r\nOh, and it seems that one file was not fully `gofmt`'ed. Committed it separately, just sth my `vim` does automatically.\r\n\r\nHopefully I've remembered everything and did not break anything :-).\r\n\r\nFixes #20.\r\nRelates #21.","created_at":"2016-10-16T21:57:52Z","updated_at":"2016-10-16T22:00:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"86fe2a4aa0647a79fc09449f0601012aeae3e1b0","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/gokcehan/lf/pulls/33/commits","review_comments_url":"https://api.github.com/repos/gokcehan/lf/pulls/33/comments","review_comment_url":"https://api.github.com/repos/gokcehan/lf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gokcehan/lf/issues/33/comments","statuses_url":"https://api.github.com/repos/gokcehan/lf/statuses/664b728ab52a233011adcec758338f80ff19dcfa","head":{"label":"KenjiTakahashi:symlink","ref":"symlink","sha":"664b728ab52a233011adcec758338f80ff19dcfa","user":{"login":"KenjiTakahashi","id":431488,"avatar_url":"https://avatars.githubusercontent.com/u/431488?v=3","gravatar_id":"","url":"https://api.github.com/users/KenjiTakahashi","html_url":"https://github.com/KenjiTakahashi","followers_url":"https://api.github.com/users/KenjiTakahashi/followers","following_url":"https://api.github.com/users/KenjiTakahashi/following{/other_user}","gists_url":"https://api.github.com/users/KenjiTakahashi/gists{/gist_id}","starred_url":"https://api.github.com/users/KenjiTakahashi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KenjiTakahashi/subscriptions","organizations_url":"https://api.github.com/users/KenjiTakahashi/orgs","repos_url":"https://api.github.com/users/KenjiTakahashi/repos","events_url":"https://api.github.com/users/KenjiTakahashi/events{/privacy}","received_events_url":"https://api.github.com/users/KenjiTakahashi/received_events","type":"User","site_admin":false},"repo":{"id":66688131,"name":"lf","full_name":"KenjiTakahashi/lf","owner":{"login":"KenjiTakahashi","id":431488,"avatar_url":"https://avatars.githubusercontent.com/u/431488?v=3","gravatar_id":"","url":"https://api.github.com/users/KenjiTakahashi","html_url":"https://github.com/KenjiTakahashi","followers_url":"https://api.github.com/users/KenjiTakahashi/followers","following_url":"https://api.github.com/users/KenjiTakahashi/following{/other_user}","gists_url":"https://api.github.com/users/KenjiTakahashi/gists{/gist_id}","starred_url":"https://api.github.com/users/KenjiTakahashi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KenjiTakahashi/subscriptions","organizations_url":"https://api.github.com/users/KenjiTakahashi/orgs","repos_url":"https://api.github.com/users/KenjiTakahashi/repos","events_url":"https://api.github.com/users/KenjiTakahashi/events{/privacy}","received_events_url":"https://api.github.com/users/KenjiTakahashi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/KenjiTakahashi/lf","description":"A terminal file manager","fork":true,"url":"https://api.github.com/repos/KenjiTakahashi/lf","forks_url":"https://api.github.com/repos/KenjiTakahashi/lf/forks","keys_url":"https://api.github.com/repos/KenjiTakahashi/lf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KenjiTakahashi/lf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KenjiTakahashi/lf/teams","hooks_url":"https://api.github.com/repos/KenjiTakahashi/lf/hooks","issue_events_url":"https://api.github.com/repos/KenjiTakahashi/lf/issues/events{/number}","events_url":"https://api.github.com/repos/KenjiTakahashi/lf/events","assignees_url":"https://api.github.com/repos/KenjiTakahashi/lf/assignees{/user}","branches_url":"https://api.github.com/repos/KenjiTakahashi/lf/branches{/branch}","tags_url":"https://api.github.com/repos/KenjiTakahashi/lf/tags","blobs_url":"https://api.github.com/repos/KenjiTakahashi/lf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KenjiTakahashi/lf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KenjiTakahashi/lf/git/refs{/sha}","trees_url":"https://api.github.com/repos/KenjiTakahashi/lf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KenjiTakahashi/lf/statuses/{sha}","languages_url":"https://api.github.com/repos/KenjiTakahashi/lf/languages","stargazers_url":"https://api.github.com/repos/KenjiTakahashi/lf/stargazers","contributors_url":"https://api.github.com/repos/KenjiTakahashi/lf/contributors","subscribers_url":"https://api.github.com/repos/KenjiTakahashi/lf/subscribers","subscription_url":"https://api.github.com/repos/KenjiTakahashi/lf/subscription","commits_url":"https://api.github.com/repos/KenjiTakahashi/lf/commits{/sha}","git_commits_url":"https://api.github.com/repos/KenjiTakahashi/lf/git/commits{/sha}","comments_url":"https://api.github.com/repos/KenjiTakahashi/lf/comments{/number}","issue_comment_url":"https://api.github.com/repos/KenjiTakahashi/lf/issues/comments{/number}","contents_url":"https://api.github.com/repos/KenjiTakahashi/lf/contents/{+path}","compare_url":"https://api.github.com/repos/KenjiTakahashi/lf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KenjiTakahashi/lf/merges","archive_url":"https://api.github.com/repos/KenjiTakahashi/lf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KenjiTakahashi/lf/downloads","issues_url":"https://api.github.com/repos/KenjiTakahashi/lf/issues{/number}","pulls_url":"https://api.github.com/repos/KenjiTakahashi/lf/pulls{/number}","milestones_url":"https://api.github.com/repos/KenjiTakahashi/lf/milestones{/number}","notifications_url":"https://api.github.com/repos/KenjiTakahashi/lf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KenjiTakahashi/lf/labels{/name}","releases_url":"https://api.github.com/repos/KenjiTakahashi/lf/releases{/id}","deployments_url":"https://api.github.com/repos/KenjiTakahashi/lf/deployments","created_at":"2016-08-27T00:57:32Z","updated_at":"2016-08-27T00:57:32Z","pushed_at":"2016-10-16T21:44:50Z","git_url":"git://github.com/KenjiTakahashi/lf.git","ssh_url":"git@github.com:KenjiTakahashi/lf.git","clone_url":"https://github.com/KenjiTakahashi/lf.git","svn_url":"https://github.com/KenjiTakahashi/lf","homepage":null,"size":125,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gokcehan:master","ref":"master","sha":"d36e27227228cf8009c40d243a3e7e7365f370a1","user":{"login":"gokcehan","id":1835672,"avatar_url":"https://avatars.githubusercontent.com/u/1835672?v=3","gravatar_id":"","url":"https://api.github.com/users/gokcehan","html_url":"https://github.com/gokcehan","followers_url":"https://api.github.com/users/gokcehan/followers","following_url":"https://api.github.com/users/gokcehan/following{/other_user}","gists_url":"https://api.github.com/users/gokcehan/gists{/gist_id}","starred_url":"https://api.github.com/users/gokcehan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gokcehan/subscriptions","organizations_url":"https://api.github.com/users/gokcehan/orgs","repos_url":"https://api.github.com/users/gokcehan/repos","events_url":"https://api.github.com/users/gokcehan/events{/privacy}","received_events_url":"https://api.github.com/users/gokcehan/received_events","type":"User","site_admin":false},"repo":{"id":65616765,"name":"lf","full_name":"gokcehan/lf","owner":{"login":"gokcehan","id":1835672,"avatar_url":"https://avatars.githubusercontent.com/u/1835672?v=3","gravatar_id":"","url":"https://api.github.com/users/gokcehan","html_url":"https://github.com/gokcehan","followers_url":"https://api.github.com/users/gokcehan/followers","following_url":"https://api.github.com/users/gokcehan/following{/other_user}","gists_url":"https://api.github.com/users/gokcehan/gists{/gist_id}","starred_url":"https://api.github.com/users/gokcehan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gokcehan/subscriptions","organizations_url":"https://api.github.com/users/gokcehan/orgs","repos_url":"https://api.github.com/users/gokcehan/repos","events_url":"https://api.github.com/users/gokcehan/events{/privacy}","received_events_url":"https://api.github.com/users/gokcehan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gokcehan/lf","description":"A terminal file manager","fork":false,"url":"https://api.github.com/repos/gokcehan/lf","forks_url":"https://api.github.com/repos/gokcehan/lf/forks","keys_url":"https://api.github.com/repos/gokcehan/lf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gokcehan/lf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gokcehan/lf/teams","hooks_url":"https://api.github.com/repos/gokcehan/lf/hooks","issue_events_url":"https://api.github.com/repos/gokcehan/lf/issues/events{/number}","events_url":"https://api.github.com/repos/gokcehan/lf/events","assignees_url":"https://api.github.com/repos/gokcehan/lf/assignees{/user}","branches_url":"https://api.github.com/repos/gokcehan/lf/branches{/branch}","tags_url":"https://api.github.com/repos/gokcehan/lf/tags","blobs_url":"https://api.github.com/repos/gokcehan/lf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gokcehan/lf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gokcehan/lf/git/refs{/sha}","trees_url":"https://api.github.com/repos/gokcehan/lf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gokcehan/lf/statuses/{sha}","languages_url":"https://api.github.com/repos/gokcehan/lf/languages","stargazers_url":"https://api.github.com/repos/gokcehan/lf/stargazers","contributors_url":"https://api.github.com/repos/gokcehan/lf/contributors","subscribers_url":"https://api.github.com/repos/gokcehan/lf/subscribers","subscription_url":"https://api.github.com/repos/gokcehan/lf/subscription","commits_url":"https://api.github.com/repos/gokcehan/lf/commits{/sha}","git_commits_url":"https://api.github.com/repos/gokcehan/lf/git/commits{/sha}","comments_url":"https://api.github.com/repos/gokcehan/lf/comments{/number}","issue_comment_url":"https://api.github.com/repos/gokcehan/lf/issues/comments{/number}","contents_url":"https://api.github.com/repos/gokcehan/lf/contents/{+path}","compare_url":"https://api.github.com/repos/gokcehan/lf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gokcehan/lf/merges","archive_url":"https://api.github.com/repos/gokcehan/lf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gokcehan/lf/downloads","issues_url":"https://api.github.com/repos/gokcehan/lf/issues{/number}","pulls_url":"https://api.github.com/repos/gokcehan/lf/pulls{/number}","milestones_url":"https://api.github.com/repos/gokcehan/lf/milestones{/number}","notifications_url":"https://api.github.com/repos/gokcehan/lf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gokcehan/lf/labels{/name}","releases_url":"https://api.github.com/repos/gokcehan/lf/releases{/id}","deployments_url":"https://api.github.com/repos/gokcehan/lf/deployments","created_at":"2016-08-13T12:45:44Z","updated_at":"2016-10-15T12:24:37Z","pushed_at":"2016-10-16T21:57:52Z","git_url":"git://github.com/gokcehan/lf.git","ssh_url":"git@github.com:gokcehan/lf.git","clone_url":"https://github.com/gokcehan/lf.git","svn_url":"https://github.com/gokcehan/lf","homepage":"https://godoc.org/github.com/gokcehan/lf","size":128,"stargazers_count":366,"watchers_count":366,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":13,"forks":16,"open_issues":13,"watchers":366,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gokcehan/lf/pulls/33"},"html":{"href":"https://github.com/gokcehan/lf/pull/33"},"issue":{"href":"https://api.github.com/repos/gokcehan/lf/issues/33"},"comments":{"href":"https://api.github.com/repos/gokcehan/lf/issues/33/comments"},"review_comments":{"href":"https://api.github.com/repos/gokcehan/lf/pulls/33/comments"},"review_comment":{"href":"https://api.github.com/repos/gokcehan/lf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gokcehan/lf/pulls/33/commits"},"statuses":{"href":"https://api.github.com/repos/gokcehan/lf/statuses/664b728ab52a233011adcec758338f80ff19dcfa"}}}}
{"actor":{"display_login":"KenjiTakahashi"}}