{"action":"created","comment":{"url":"https://api.github.com/repos/RackHD/on-tasks/pulls/comments/84613921","pull_request_review_id":5380220,"id":84613921,"diff_hunk":"@@ -7,7 +7,8 @@ module.exports = {\n     injectableName: 'Task.Drive.SecureErase',\n     implementsTask: 'Task.Base.SecureErase',\n     options: {\n-        eraseSettings: []\n+        eraseSettings: [],\n+        baseUri: '{{ file.server }}'","path":"lib/task-data/tasks/secure-erase-drive.js","position":6,"original_position":6,"commit_id":"f64f978dbb2351392cf8e01c390d451fba77fde9","original_commit_id":"f64f978dbb2351392cf8e01c390d451fba77fde9","user":{"login":"cgx027","id":2181868,"avatar_url":"https://avatars.githubusercontent.com/u/2181868?v=3","gravatar_id":"","url":"https://api.github.com/users/cgx027","html_url":"https://github.com/cgx027","followers_url":"https://api.github.com/users/cgx027/followers","following_url":"https://api.github.com/users/cgx027/following{/other_user}","gists_url":"https://api.github.com/users/cgx027/gists{/gist_id}","starred_url":"https://api.github.com/users/cgx027/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgx027/subscriptions","organizations_url":"https://api.github.com/users/cgx027/orgs","repos_url":"https://api.github.com/users/cgx027/repos","events_url":"https://api.github.com/users/cgx027/events{/privacy}","received_events_url":"https://api.github.com/users/cgx027/received_events","type":"User","site_admin":false},"body":"In the case where external file server is used, file.server will be the external file server address and the notification will not be sent to correct server. Replace this with api.server sounds more corect. @iceiilin ","created_at":"2016-10-24T02:26:43Z","updated_at":"2016-10-24T02:26:43Z","html_url":"https://github.com/RackHD/on-tasks/pull/364#discussion_r84613921","pull_request_url":"https://api.github.com/repos/RackHD/on-tasks/pulls/364","_links":{"self":{"href":"https://api.github.com/repos/RackHD/on-tasks/pulls/comments/84613921"},"html":{"href":"https://github.com/RackHD/on-tasks/pull/364#discussion_r84613921"},"pull_request":{"href":"https://api.github.com/repos/RackHD/on-tasks/pulls/364"}}},"pull_request":{"url":"https://api.github.com/repos/RackHD/on-tasks/pulls/364","id":90325904,"html_url":"https://github.com/RackHD/on-tasks/pull/364","diff_url":"https://github.com/RackHD/on-tasks/pull/364.diff","patch_url":"https://github.com/RackHD/on-tasks/pull/364.patch","issue_url":"https://api.github.com/repos/RackHD/on-tasks/issues/364","number":364,"state":"open","locked":false,"title":"On tasks changes for secure erase workflow progress","user":{"login":"pengz1","id":13991453,"avatar_url":"https://avatars.githubusercontent.com/u/13991453?v=3","gravatar_id":"","url":"https://api.github.com/users/pengz1","html_url":"https://github.com/pengz1","followers_url":"https://api.github.com/users/pengz1/followers","following_url":"https://api.github.com/users/pengz1/following{/other_user}","gists_url":"https://api.github.com/users/pengz1/gists{/gist_id}","starred_url":"https://api.github.com/users/pengz1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pengz1/subscriptions","organizations_url":"https://api.github.com/users/pengz1/orgs","repos_url":"https://api.github.com/users/pengz1/repos","events_url":"https://api.github.com/users/pengz1/events{/privacy}","received_events_url":"https://api.github.com/users/pengz1/received_events","type":"User","site_admin":false},"body":"Jenkins Depends on: https://github.com/RackHD/on-core/pull/221\r\n\r\nOn-tasks changes for secure erase workflow progress. Includes modification of secure erase job/task changes and some common changes for sending progress events.","created_at":"2016-10-21T05:45:16Z","updated_at":"2016-10-24T02:26:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"067e546f7c9e68440a67341e5e6b5eafac719c0d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/RackHD/on-tasks/pulls/364/commits","review_comments_url":"https://api.github.com/repos/RackHD/on-tasks/pulls/364/comments","review_comment_url":"https://api.github.com/repos/RackHD/on-tasks/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RackHD/on-tasks/issues/364/comments","statuses_url":"https://api.github.com/repos/RackHD/on-tasks/statuses/f64f978dbb2351392cf8e01c390d451fba77fde9","head":{"label":"pengz1:on-tasks-changes-for-workflow-progress","ref":"on-tasks-changes-for-workflow-progress","sha":"f64f978dbb2351392cf8e01c390d451fba77fde9","user":{"login":"pengz1","id":13991453,"avatar_url":"https://avatars.githubusercontent.com/u/13991453?v=3","gravatar_id":"","url":"https://api.github.com/users/pengz1","html_url":"https://github.com/pengz1","followers_url":"https://api.github.com/users/pengz1/followers","following_url":"https://api.github.com/users/pengz1/following{/other_user}","gists_url":"https://api.github.com/users/pengz1/gists{/gist_id}","starred_url":"https://api.github.com/users/pengz1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pengz1/subscriptions","organizations_url":"https://api.github.com/users/pengz1/orgs","repos_url":"https://api.github.com/users/pengz1/repos","events_url":"https://api.github.com/users/pengz1/events{/privacy}","received_events_url":"https://api.github.com/users/pengz1/received_events","type":"User","site_admin":false},"repo":{"id":46105919,"name":"on-tasks","full_name":"pengz1/on-tasks","owner":{"login":"pengz1","id":13991453,"avatar_url":"https://avatars.githubusercontent.com/u/13991453?v=3","gravatar_id":"","url":"https://api.github.com/users/pengz1","html_url":"https://github.com/pengz1","followers_url":"https://api.github.com/users/pengz1/followers","following_url":"https://api.github.com/users/pengz1/following{/other_user}","gists_url":"https://api.github.com/users/pengz1/gists{/gist_id}","starred_url":"https://api.github.com/users/pengz1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pengz1/subscriptions","organizations_url":"https://api.github.com/users/pengz1/orgs","repos_url":"https://api.github.com/users/pengz1/repos","events_url":"https://api.github.com/users/pengz1/events{/privacy}","received_events_url":"https://api.github.com/users/pengz1/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pengz1/on-tasks","description":null,"fork":true,"url":"https://api.github.com/repos/pengz1/on-tasks","forks_url":"https://api.github.com/repos/pengz1/on-tasks/forks","keys_url":"https://api.github.com/repos/pengz1/on-tasks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pengz1/on-tasks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pengz1/on-tasks/teams","hooks_url":"https://api.github.com/repos/pengz1/on-tasks/hooks","issue_events_url":"https://api.github.com/repos/pengz1/on-tasks/issues/events{/number}","events_url":"https://api.github.com/repos/pengz1/on-tasks/events","assignees_url":"https://api.github.com/repos/pengz1/on-tasks/assignees{/user}","branches_url":"https://api.github.com/repos/pengz1/on-tasks/branches{/branch}","tags_url":"https://api.github.com/repos/pengz1/on-tasks/tags","blobs_url":"https://api.github.com/repos/pengz1/on-tasks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pengz1/on-tasks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pengz1/on-tasks/git/refs{/sha}","trees_url":"https://api.github.com/repos/pengz1/on-tasks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pengz1/on-tasks/statuses/{sha}","languages_url":"https://api.github.com/repos/pengz1/on-tasks/languages","stargazers_url":"https://api.github.com/repos/pengz1/on-tasks/stargazers","contributors_url":"https://api.github.com/repos/pengz1/on-tasks/contributors","subscribers_url":"https://api.github.com/repos/pengz1/on-tasks/subscribers","subscription_url":"https://api.github.com/repos/pengz1/on-tasks/subscription","commits_url":"https://api.github.com/repos/pengz1/on-tasks/commits{/sha}","git_commits_url":"https://api.github.com/repos/pengz1/on-tasks/git/commits{/sha}","comments_url":"https://api.github.com/repos/pengz1/on-tasks/comments{/number}","issue_comment_url":"https://api.github.com/repos/pengz1/on-tasks/issues/comments{/number}","contents_url":"https://api.github.com/repos/pengz1/on-tasks/contents/{+path}","compare_url":"https://api.github.com/repos/pengz1/on-tasks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pengz1/on-tasks/merges","archive_url":"https://api.github.com/repos/pengz1/on-tasks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pengz1/on-tasks/downloads","issues_url":"https://api.github.com/repos/pengz1/on-tasks/issues{/number}","pulls_url":"https://api.github.com/repos/pengz1/on-tasks/pulls{/number}","milestones_url":"https://api.github.com/repos/pengz1/on-tasks/milestones{/number}","notifications_url":"https://api.github.com/repos/pengz1/on-tasks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pengz1/on-tasks/labels{/name}","releases_url":"https://api.github.com/repos/pengz1/on-tasks/releases{/id}","deployments_url":"https://api.github.com/repos/pengz1/on-tasks/deployments","created_at":"2015-11-13T07:08:24Z","updated_at":"2016-02-03T07:26:55Z","pushed_at":"2016-10-21T05:35:54Z","git_url":"git://github.com/pengz1/on-tasks.git","ssh_url":"git@github.com:pengz1/on-tasks.git","clone_url":"https://github.com/pengz1/on-tasks.git","svn_url":"https://github.com/pengz1/on-tasks","homepage":null,"size":1894,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"RackHD:master","ref":"master","sha":"2278af1b053a5627a3c5c403f5c6cf0f4144f545","user":{"login":"RackHD","id":13982662,"avatar_url":"https://avatars.githubusercontent.com/u/13982662?v=3","gravatar_id":"","url":"https://api.github.com/users/RackHD","html_url":"https://github.com/RackHD","followers_url":"https://api.github.com/users/RackHD/followers","following_url":"https://api.github.com/users/RackHD/following{/other_user}","gists_url":"https://api.github.com/users/RackHD/gists{/gist_id}","starred_url":"https://api.github.com/users/RackHD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RackHD/subscriptions","organizations_url":"https://api.github.com/users/RackHD/orgs","repos_url":"https://api.github.com/users/RackHD/repos","events_url":"https://api.github.com/users/RackHD/events{/privacy}","received_events_url":"https://api.github.com/users/RackHD/received_events","type":"Organization","site_admin":false},"repo":{"id":41690099,"name":"on-tasks","full_name":"RackHD/on-tasks","owner":{"login":"RackHD","id":13982662,"avatar_url":"https://avatars.githubusercontent.com/u/13982662?v=3","gravatar_id":"","url":"https://api.github.com/users/RackHD","html_url":"https://github.com/RackHD","followers_url":"https://api.github.com/users/RackHD/followers","following_url":"https://api.github.com/users/RackHD/following{/other_user}","gists_url":"https://api.github.com/users/RackHD/gists{/gist_id}","starred_url":"https://api.github.com/users/RackHD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RackHD/subscriptions","organizations_url":"https://api.github.com/users/RackHD/orgs","repos_url":"https://api.github.com/users/RackHD/repos","events_url":"https://api.github.com/users/RackHD/events{/privacy}","received_events_url":"https://api.github.com/users/RackHD/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RackHD/on-tasks","description":null,"fork":false,"url":"https://api.github.com/repos/RackHD/on-tasks","forks_url":"https://api.github.com/repos/RackHD/on-tasks/forks","keys_url":"https://api.github.com/repos/RackHD/on-tasks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RackHD/on-tasks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RackHD/on-tasks/teams","hooks_url":"https://api.github.com/repos/RackHD/on-tasks/hooks","issue_events_url":"https://api.github.com/repos/RackHD/on-tasks/issues/events{/number}","events_url":"https://api.github.com/repos/RackHD/on-tasks/events","assignees_url":"https://api.github.com/repos/RackHD/on-tasks/assignees{/user}","branches_url":"https://api.github.com/repos/RackHD/on-tasks/branches{/branch}","tags_url":"https://api.github.com/repos/RackHD/on-tasks/tags","blobs_url":"https://api.github.com/repos/RackHD/on-tasks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RackHD/on-tasks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RackHD/on-tasks/git/refs{/sha}","trees_url":"https://api.github.com/repos/RackHD/on-tasks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RackHD/on-tasks/statuses/{sha}","languages_url":"https://api.github.com/repos/RackHD/on-tasks/languages","stargazers_url":"https://api.github.com/repos/RackHD/on-tasks/stargazers","contributors_url":"https://api.github.com/repos/RackHD/on-tasks/contributors","subscribers_url":"https://api.github.com/repos/RackHD/on-tasks/subscribers","subscription_url":"https://api.github.com/repos/RackHD/on-tasks/subscription","commits_url":"https://api.github.com/repos/RackHD/on-tasks/commits{/sha}","git_commits_url":"https://api.github.com/repos/RackHD/on-tasks/git/commits{/sha}","comments_url":"https://api.github.com/repos/RackHD/on-tasks/comments{/number}","issue_comment_url":"https://api.github.com/repos/RackHD/on-tasks/issues/comments{/number}","contents_url":"https://api.github.com/repos/RackHD/on-tasks/contents/{+path}","compare_url":"https://api.github.com/repos/RackHD/on-tasks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RackHD/on-tasks/merges","archive_url":"https://api.github.com/repos/RackHD/on-tasks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RackHD/on-tasks/downloads","issues_url":"https://api.github.com/repos/RackHD/on-tasks/issues{/number}","pulls_url":"https://api.github.com/repos/RackHD/on-tasks/pulls{/number}","milestones_url":"https://api.github.com/repos/RackHD/on-tasks/milestones{/number}","notifications_url":"https://api.github.com/repos/RackHD/on-tasks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RackHD/on-tasks/labels{/name}","releases_url":"https://api.github.com/repos/RackHD/on-tasks/releases{/id}","deployments_url":"https://api.github.com/repos/RackHD/on-tasks/deployments","created_at":"2015-08-31T17:29:32Z","updated_at":"2016-10-08T06:20:18Z","pushed_at":"2016-10-21T22:49:25Z","git_url":"git://github.com/RackHD/on-tasks.git","ssh_url":"git@github.com:RackHD/on-tasks.git","clone_url":"https://github.com/RackHD/on-tasks.git","svn_url":"https://github.com/RackHD/on-tasks","homepage":null,"size":2140,"stargazers_count":7,"watchers_count":7,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":53,"mirror_url":null,"open_issues_count":9,"forks":53,"open_issues":9,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RackHD/on-tasks/pulls/364"},"html":{"href":"https://github.com/RackHD/on-tasks/pull/364"},"issue":{"href":"https://api.github.com/repos/RackHD/on-tasks/issues/364"},"comments":{"href":"https://api.github.com/repos/RackHD/on-tasks/issues/364/comments"},"review_comments":{"href":"https://api.github.com/repos/RackHD/on-tasks/pulls/364/comments"},"review_comment":{"href":"https://api.github.com/repos/RackHD/on-tasks/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RackHD/on-tasks/pulls/364/commits"},"statuses":{"href":"https://api.github.com/repos/RackHD/on-tasks/statuses/f64f978dbb2351392cf8e01c390d451fba77fde9"}}}}
{"actor":{"display_login":"cgx027"}}