{"action":"created","issue":{"url":"https://api.github.com/repos/PyFilesystem/pyfilesystem/issues/266","repository_url":"https://api.github.com/repos/PyFilesystem/pyfilesystem","labels_url":"https://api.github.com/repos/PyFilesystem/pyfilesystem/issues/266/labels{/name}","comments_url":"https://api.github.com/repos/PyFilesystem/pyfilesystem/issues/266/comments","events_url":"https://api.github.com/repos/PyFilesystem/pyfilesystem/issues/266/events","html_url":"https://github.com/PyFilesystem/pyfilesystem/pull/266","id":183074855,"number":266,"title":"closes #3665 - Show original exception in error messages.","user":{"login":"sf-dlund","id":22746893,"avatar_url":"https://avatars.githubusercontent.com/u/22746893?v=3","gravatar_id":"","url":"https://api.github.com/users/sf-dlund","html_url":"https://github.com/sf-dlund","followers_url":"https://api.github.com/users/sf-dlund/followers","following_url":"https://api.github.com/users/sf-dlund/following{/other_user}","gists_url":"https://api.github.com/users/sf-dlund/gists{/gist_id}","starred_url":"https://api.github.com/users/sf-dlund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sf-dlund/subscriptions","organizations_url":"https://api.github.com/users/sf-dlund/orgs","repos_url":"https://api.github.com/users/sf-dlund/repos","events_url":"https://api.github.com/users/sf-dlund/events{/privacy}","received_events_url":"https://api.github.com/users/sf-dlund/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-10-14T15:07:57Z","updated_at":"2016-10-14T16:34:12Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/PyFilesystem/pyfilesystem/pulls/266","html_url":"https://github.com/PyFilesystem/pyfilesystem/pull/266","diff_url":"https://github.com/PyFilesystem/pyfilesystem/pull/266.diff","patch_url":"https://github.com/PyFilesystem/pyfilesystem/pull/266.patch"},"body":"Updated init function to include Original Exception attribute as originalExc.\r\n\r\nUpdated individual error classes to display originalExc.\r\n\r\nUpdated convert_os_errors to pass exception type into init function for each error type.\r\n\r\nTested by raising various types of errors within local fs implementation."},"comment":{"url":"https://api.github.com/repos/PyFilesystem/pyfilesystem/issues/comments/253852938","html_url":"https://github.com/PyFilesystem/pyfilesystem/pull/266#issuecomment-253852938","issue_url":"https://api.github.com/repos/PyFilesystem/pyfilesystem/issues/266","id":253852938,"user":{"login":"sf-dlund","id":22746893,"avatar_url":"https://avatars.githubusercontent.com/u/22746893?v=3","gravatar_id":"","url":"https://api.github.com/users/sf-dlund","html_url":"https://github.com/sf-dlund","followers_url":"https://api.github.com/users/sf-dlund/followers","following_url":"https://api.github.com/users/sf-dlund/following{/other_user}","gists_url":"https://api.github.com/users/sf-dlund/gists{/gist_id}","starred_url":"https://api.github.com/users/sf-dlund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sf-dlund/subscriptions","organizations_url":"https://api.github.com/users/sf-dlund/orgs","repos_url":"https://api.github.com/users/sf-dlund/repos","events_url":"https://api.github.com/users/sf-dlund/events{/privacy}","received_events_url":"https://api.github.com/users/sf-dlund/received_events","type":"User","site_admin":false},"created_at":"2016-10-14T16:34:11Z","updated_at":"2016-10-14T16:34:11Z","body":"Thanks for the response.  I actually intended to push to a forked version\nand forgot to change my source.\n\nOn Fri, Oct 14, 2016 at 11:29 AM, Will McGugan <notifications@github.com>\nwrote:\n\n> *@willmcgugan* commented on this pull request.\n>\n> Sorry, I don't think this adds much. I see what you are trying to do. But\n> often the 'original exception' isn't helpful and even misleading. Better to\n> store any exception object in the 'details' parameter.\n> ------------------------------\n>\n> In fs/errors.py\n> <https://github.com/PyFilesystem/pyfilesystem/pull/266#pullrequestreview-4290054>\n> :\n>\n> > @@ -49,30 +49,31 @@ class FSError(Exception):\n>      \"\"\"Base exception class for the FS module.\"\"\"\n>      default_message = \"Unspecified error\"\n>\n> -    def __init__(self,msg=None,details=None):\n> +    def __init__(self, msg=None, details=None, originalExc=None):\n>\n> Parameters should be lower_case_and_underscores\n>\n> —\n> You are receiving this because you authored the thread.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/PyFilesystem/pyfilesystem/pull/266#pullrequestreview-4290054>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/AVsXDSJ9WQslBKyKNuGGLuCzS-iWeroTks5qz5_DgaJpZM4KXHXF>\n> .\n>\n\n\n\n-- \nDavid Lund\n*Developer*\n*SmartFile*\np: 877-336-3453  e: dlund@smartfile.com\na: 1025 N. Senate Ave. Indianapolis, IN 46202\n<https://facebook.com/smartfile>   <https://twitter.com/smartfile>\n<https://linkedin.com/company/smartfile>\n\n<https://www.smartfile.com/email-cta>\n"}}
{"actor":{"display_login":"sf-dlund"}}