{"action":"created","issue":{"url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/issues/1064","repository_url":"https://api.github.com/repos/sonata-project/SonataMediaBundle","labels_url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/issues/1064/labels{/name}","comments_url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/issues/1064/comments","events_url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/issues/1064/events","html_url":"https://github.com/sonata-project/SonataMediaBundle/pull/1064","id":160895344,"number":1064,"title":"Make forms compatible with Symfony3","user":{"login":"ksom","id":4030561,"avatar_url":"https://avatars.githubusercontent.com/u/4030561?v=3","gravatar_id":"","url":"https://api.github.com/users/ksom","html_url":"https://github.com/ksom","followers_url":"https://api.github.com/users/ksom/followers","following_url":"https://api.github.com/users/ksom/following{/other_user}","gists_url":"https://api.github.com/users/ksom/gists{/gist_id}","starred_url":"https://api.github.com/users/ksom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ksom/subscriptions","organizations_url":"https://api.github.com/users/ksom/orgs","repos_url":"https://api.github.com/users/ksom/repos","events_url":"https://api.github.com/users/ksom/events{/privacy}","received_events_url":"https://api.github.com/users/ksom/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/labels/review%20required","name":"review required","color":"d4c5f9"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":9,"created_at":"2016-06-17T14:03:14Z","updated_at":"2016-06-17T17:46:20Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/pulls/1064","html_url":"https://github.com/sonata-project/SonataMediaBundle/pull/1064","diff_url":"https://github.com/sonata-project/SonataMediaBundle/pull/1064.diff","patch_url":"https://github.com/sonata-project/SonataMediaBundle/pull/1064.patch"},"body":"I am targeting `3.x`, because it's the branch that should be compatible with Symfony 3+ but isn't.\r\n\r\n## Changelog\r\n\r\n```markdown\r\n### Added\r\n- Added `isSymfony28` bool private property to cache whether we are using Symfony 2.8+ in:\r\n    - `ApiMediaType`\r\n    - `MediaType`\r\n    - `BaseVideoProvider`\r\n    - `FileProvider`\r\n\r\n### Fixed\r\n- Fixed `ApiMediaType::getParent` compatibility with Symfony3 forms\r\n- Fixed `MediaType::buildForm` compatibility with Symfony3 forms\r\n- Fixed `MediaType::getParent` compatibility with Symfony3 forms\r\n- Fixed `BaseVideoProvider::buildEditForm` compatibility with Symfony3 forms\r\n- Fixed `BaseVideoProvider::buildCreateForm` compatibility with Symfony3 forms\r\n- Fixed `BaseVideoProvider:: buildMediaType` compatibility with Symfony3 forms\r\n- Fixed `FileProvider::buildEditForm` compatibility with Symfony3 forms\r\n- Fixed `FileProvider::buildCreateForm` compatibility with Symfony3 forms\r\n- Fixed `FileProvider::buildMediaType` compatibility with Symfony3 forms\r\n\r\n```\r\n\r\n## Subject\r\n\r\nForms are not compatible with Symfony3 because it is currently using form short name instead of the FQCN. Since Symfony 3.0, you have to `'\\\\Symfony\\\\Component\\\\Form\\\\Extension\\\\Core\\\\Type\\\\TextType'` instead of `'text'`.\r\n\r\nI am also preparing an equivalent PR for SonataCoreBundle (for the `Api*Type`s)."},"comment":{"url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/issues/comments/226835229","html_url":"https://github.com/sonata-project/SonataMediaBundle/pull/1064#issuecomment-226835229","issue_url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/issues/1064","id":226835229,"user":{"login":"Soullivaneuh","id":1698357,"avatar_url":"https://avatars.githubusercontent.com/u/1698357?v=3","gravatar_id":"","url":"https://api.github.com/users/Soullivaneuh","html_url":"https://github.com/Soullivaneuh","followers_url":"https://api.github.com/users/Soullivaneuh/followers","following_url":"https://api.github.com/users/Soullivaneuh/following{/other_user}","gists_url":"https://api.github.com/users/Soullivaneuh/gists{/gist_id}","starred_url":"https://api.github.com/users/Soullivaneuh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Soullivaneuh/subscriptions","organizations_url":"https://api.github.com/users/Soullivaneuh/orgs","repos_url":"https://api.github.com/users/Soullivaneuh/repos","events_url":"https://api.github.com/users/Soullivaneuh/events{/privacy}","received_events_url":"https://api.github.com/users/Soullivaneuh/received_events","type":"User","site_admin":false},"created_at":"2016-06-17T17:46:20Z","updated_at":"2016-06-17T17:46:20Z","body":"Don't use properties at all. :-)"}}
{"actor":{"display_login":"Soullivaneuh"}}