{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/33274","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/33274/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/33274/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/33274/events","html_url":"https://github.com/kubernetes/kubernetes/pull/33274","id":178621388,"number":33274,"title":"Validate empty Service ClusterIP against LB type","user":{"login":"nebril","id":1417888,"avatar_url":"https://avatars.githubusercontent.com/u/1417888?v=3","gravatar_id":"","url":"https://api.github.com/users/nebril","html_url":"https://github.com/nebril","followers_url":"https://api.github.com/users/nebril/followers","following_url":"https://api.github.com/users/nebril/following{/other_user}","gists_url":"https://api.github.com/users/nebril/gists{/gist_id}","starred_url":"https://api.github.com/users/nebril/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nebril/subscriptions","organizations_url":"https://api.github.com/users/nebril/orgs","repos_url":"https://api.github.com/users/nebril/repos","events_url":"https://api.github.com/users/nebril/events{/privacy}","received_events_url":"https://api.github.com/users/nebril/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cla:%20yes","name":"cla: yes","color":"bfe5bf"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/api-change","name":"kind/api-change","color":"c7def8"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note","name":"release-note","color":"c2e0c6"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/S","name":"size/S","color":"77bb00"}],"state":"open","locked":false,"assignee":{"login":"smarterclayton","id":1163175,"avatar_url":"https://avatars.githubusercontent.com/u/1163175?v=3","gravatar_id":"","url":"https://api.github.com/users/smarterclayton","html_url":"https://github.com/smarterclayton","followers_url":"https://api.github.com/users/smarterclayton/followers","following_url":"https://api.github.com/users/smarterclayton/following{/other_user}","gists_url":"https://api.github.com/users/smarterclayton/gists{/gist_id}","starred_url":"https://api.github.com/users/smarterclayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smarterclayton/subscriptions","organizations_url":"https://api.github.com/users/smarterclayton/orgs","repos_url":"https://api.github.com/users/smarterclayton/repos","events_url":"https://api.github.com/users/smarterclayton/events{/privacy}","received_events_url":"https://api.github.com/users/smarterclayton/received_events","type":"User","site_admin":false},"assignees":[{"login":"smarterclayton","id":1163175,"avatar_url":"https://avatars.githubusercontent.com/u/1163175?v=3","gravatar_id":"","url":"https://api.github.com/users/smarterclayton","html_url":"https://github.com/smarterclayton","followers_url":"https://api.github.com/users/smarterclayton/followers","following_url":"https://api.github.com/users/smarterclayton/following{/other_user}","gists_url":"https://api.github.com/users/smarterclayton/gists{/gist_id}","starred_url":"https://api.github.com/users/smarterclayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smarterclayton/subscriptions","organizations_url":"https://api.github.com/users/smarterclayton/orgs","repos_url":"https://api.github.com/users/smarterclayton/repos","events_url":"https://api.github.com/users/smarterclayton/events{/privacy}","received_events_url":"https://api.github.com/users/smarterclayton/received_events","type":"User","site_admin":false}],"milestone":null,"comments":14,"created_at":"2016-09-22T14:12:29Z","updated_at":"2016-09-28T12:46:37Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/33274","html_url":"https://github.com/kubernetes/kubernetes/pull/33274","diff_url":"https://github.com/kubernetes/kubernetes/pull/33274.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/33274.patch"},"body":"**What this PR does / why we need it**: It adds new validation rule for Services, to ensure that creating LoadBalancer type service with cluster IP set to \"None\" fails.\r\n\r\n**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #33036\r\n\r\n**Release note**:\r\n```release-note\r\nCreating LoadBalancer Service with \"None\" ClusterIP is no longer possible\r\n```\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.kubernetes.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.kubernetes.io/reviews/kubernetes/kubernetes/33274)\r\n<!-- Reviewable:end -->\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/250156299","html_url":"https://github.com/kubernetes/kubernetes/pull/33274#issuecomment-250156299","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/33274","id":250156299,"user":{"login":"k8s-ci-robot","id":20407524,"avatar_url":"https://avatars.githubusercontent.com/u/20407524?v=3","gravatar_id":"","url":"https://api.github.com/users/k8s-ci-robot","html_url":"https://github.com/k8s-ci-robot","followers_url":"https://api.github.com/users/k8s-ci-robot/followers","following_url":"https://api.github.com/users/k8s-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-ci-robot/orgs","repos_url":"https://api.github.com/users/k8s-ci-robot/repos","events_url":"https://api.github.com/users/k8s-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2016-09-28T12:46:36Z","updated_at":"2016-09-28T12:46:36Z","body":"Jenkins unit/integration [**failed**](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/33274/kubernetes-pull-test-unit-integration/46921/) for commit 95f4b6aec7b0f04c4eed7e744a1f72aca46ba3d2. [Full PR test history](http://pr-test.k8s.io/33274).\n\nThe magic incantation to run this job again is `@k8s-bot unit test this`. Please help us cut down flakes by linking to an [open flake issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+label:kind/flake+is:open) when you hit one in your PR."}}
{"actor":{"display_login":"k8s-ci-robot"}}