{"action":"created","issue":{"url":"https://api.github.com/repos/jenkinsci/jenkins/issues/2090","repository_url":"https://api.github.com/repos/jenkinsci/jenkins","labels_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/2090/labels{/name}","comments_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/2090/comments","events_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/2090/events","html_url":"https://github.com/jenkinsci/jenkins/pull/2090","id":139225995,"number":2090,"title":"Revert \"Jenkins.getInstance() should be non-null\"","user":{"login":"oleg-nenashev","id":3000480,"avatar_url":"https://avatars.githubusercontent.com/u/3000480?v=3","gravatar_id":"","url":"https://api.github.com/users/oleg-nenashev","html_url":"https://github.com/oleg-nenashev","followers_url":"https://api.github.com/users/oleg-nenashev/followers","following_url":"https://api.github.com/users/oleg-nenashev/following{/other_user}","gists_url":"https://api.github.com/users/oleg-nenashev/gists{/gist_id}","starred_url":"https://api.github.com/users/oleg-nenashev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oleg-nenashev/subscriptions","organizations_url":"https://api.github.com/users/oleg-nenashev/orgs","repos_url":"https://api.github.com/users/oleg-nenashev/repos","events_url":"https://api.github.com/users/oleg-nenashev/events{/privacy}","received_events_url":"https://api.github.com/users/oleg-nenashev/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":27,"created_at":"2016-03-08T09:37:54Z","updated_at":"2016-03-08T18:52:30Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/2090","html_url":"https://github.com/jenkinsci/jenkins/pull/2090","diff_url":"https://github.com/jenkinsci/jenkins/pull/2090.diff","patch_url":"https://github.com/jenkinsci/jenkins/pull/2090.patch"},"body":"This reverts commit bb7c8fcedbcc9b51c5b1bb5b32810af5ac6b1ffb, which has been submitted without a pull request. This is a breaking change, so I propose to revert it. If the submitter feels strongly, he can create a pull request as other Jenkins contributors do.\r\n\r\nhttps://github.com/jenkinsci/jenkins/commit/bb7c8fcedbcc9b51c5b1bb5b32810af5ac6b1ffb\r\nSee the discussion there.\r\n\r\n@jenkinsci/code-reviewers @reviewbybees"},"comment":{"url":"https://api.github.com/repos/jenkinsci/jenkins/issues/comments/193913342","html_url":"https://github.com/jenkinsci/jenkins/pull/2090#issuecomment-193913342","issue_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/2090","id":193913342,"user":{"login":"orrc","id":138615,"avatar_url":"https://avatars.githubusercontent.com/u/138615?v=3","gravatar_id":"","url":"https://api.github.com/users/orrc","html_url":"https://github.com/orrc","followers_url":"https://api.github.com/users/orrc/followers","following_url":"https://api.github.com/users/orrc/following{/other_user}","gists_url":"https://api.github.com/users/orrc/gists{/gist_id}","starred_url":"https://api.github.com/users/orrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orrc/subscriptions","organizations_url":"https://api.github.com/users/orrc/orgs","repos_url":"https://api.github.com/users/orrc/repos","events_url":"https://api.github.com/users/orrc/events{/privacy}","received_events_url":"https://api.github.com/users/orrc/received_events","type":"User","site_admin":false},"created_at":"2016-03-08T18:52:30Z","updated_at":"2016-03-08T18:52:30Z","body":"> Nobody in the community is expected to make sole decisions and to push changes without letting the community to review the changes. It may become a strict policy when @orrc finishes the proposal\r\n\r\n@oleg-nenashev I fulfilled my action item for that meeting (the proposal wasn't mine to begin with), but it hasn't been followed up so far in a later meeting.\r\nFWIW, I do support what I think is the non-controversial stance of requiring PRs for core code changes.\r\n\r\n(Semi on-topic: I have a fairly vague feeling that I was at some point guilty of trying to access `Jenkins.getInstance()` from a `Callable` in a plugin — so I imagine there are instances of that out there)"}}