{"action":"created","comment":{"url":"https://api.github.com/repos/hapijs/good-squeeze/pulls/comments/78907912","id":78907912,"diff_hunk":"@@ -65,7 +88,11 @@ class Squeeze extends Stream.Transform {\n             let result = false;\n             for (let i = 0; i < tags.length; ++i) {\n                 const eventTag = tags[i];\n-                result = result || subEventTags.indexOf(eventTag) > -1;\n+                // As soon as an exclude tag matches, exclude the log entry\n+                if (subEventTags.exclude.indexOf(eventTag) > -1) {\n+                    return false;\n+                }\n+                result = result || subEventTags.include.indexOf(eventTag) > -1 || subEventTags.include.length === 0;","path":"lib/squeeze.js","position":76,"original_position":76,"commit_id":"b29229a5e6e914a700780621eba2fb80e15c87e2","original_commit_id":"51828c31da7fa830139eb7cd17dc0ceb1449ef2c","user":{"login":"benleen","id":2865406,"avatar_url":"https://avatars.githubusercontent.com/u/2865406?v=3","gravatar_id":"","url":"https://api.github.com/users/benleen","html_url":"https://github.com/benleen","followers_url":"https://api.github.com/users/benleen/followers","following_url":"https://api.github.com/users/benleen/following{/other_user}","gists_url":"https://api.github.com/users/benleen/gists{/gist_id}","starred_url":"https://api.github.com/users/benleen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benleen/subscriptions","organizations_url":"https://api.github.com/users/benleen/orgs","repos_url":"https://api.github.com/users/benleen/repos","events_url":"https://api.github.com/users/benleen/events{/privacy}","received_events_url":"https://api.github.com/users/benleen/received_events","type":"User","site_admin":false},"body":"Yes, this is consistent with how the previous 'include' string array was being interpreted:\r\nhttps://github.com/hapijs/good-squeeze/blob/master/lib/squeeze.js#L59","created_at":"2016-09-15T07:58:28Z","updated_at":"2016-09-15T07:58:28Z","html_url":"https://github.com/hapijs/good-squeeze/pull/16#discussion_r78907912","pull_request_url":"https://api.github.com/repos/hapijs/good-squeeze/pulls/16","_links":{"self":{"href":"https://api.github.com/repos/hapijs/good-squeeze/pulls/comments/78907912"},"html":{"href":"https://github.com/hapijs/good-squeeze/pull/16#discussion_r78907912"},"pull_request":{"href":"https://api.github.com/repos/hapijs/good-squeeze/pulls/16"}}},"pull_request":{"url":"https://api.github.com/repos/hapijs/good-squeeze/pulls/16","id":85199847,"html_url":"https://github.com/hapijs/good-squeeze/pull/16","diff_url":"https://github.com/hapijs/good-squeeze/pull/16.diff","patch_url":"https://github.com/hapijs/good-squeeze/pull/16.patch","issue_url":"https://api.github.com/repos/hapijs/good-squeeze/issues/16","number":16,"state":"open","locked":false,"title":"Added feature to exclude entries from being logged (e.g. sensitive data)","user":{"login":"benleen","id":2865406,"avatar_url":"https://avatars.githubusercontent.com/u/2865406?v=3","gravatar_id":"","url":"https://api.github.com/users/benleen","html_url":"https://github.com/benleen","followers_url":"https://api.github.com/users/benleen/followers","following_url":"https://api.github.com/users/benleen/following{/other_user}","gists_url":"https://api.github.com/users/benleen/gists{/gist_id}","starred_url":"https://api.github.com/users/benleen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benleen/subscriptions","organizations_url":"https://api.github.com/users/benleen/orgs","repos_url":"https://api.github.com/users/benleen/repos","events_url":"https://api.github.com/users/benleen/events{/privacy}","received_events_url":"https://api.github.com/users/benleen/received_events","type":"User","site_admin":false},"body":"Hey arb! Had discussed this with @Marsup a while back:\r\n\r\nAdditional feature to exclude log entries from making it through to being logged.","created_at":"2016-09-14T10:05:06Z","updated_at":"2016-09-15T07:58:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"651e91731332aa7c9e2a4c78276d1b2f86287ca1","assignee":{"login":"arb","id":1591483,"avatar_url":"https://avatars.githubusercontent.com/u/1591483?v=3","gravatar_id":"","url":"https://api.github.com/users/arb","html_url":"https://github.com/arb","followers_url":"https://api.github.com/users/arb/followers","following_url":"https://api.github.com/users/arb/following{/other_user}","gists_url":"https://api.github.com/users/arb/gists{/gist_id}","starred_url":"https://api.github.com/users/arb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arb/subscriptions","organizations_url":"https://api.github.com/users/arb/orgs","repos_url":"https://api.github.com/users/arb/repos","events_url":"https://api.github.com/users/arb/events{/privacy}","received_events_url":"https://api.github.com/users/arb/received_events","type":"User","site_admin":false},"assignees":[{"login":"arb","id":1591483,"avatar_url":"https://avatars.githubusercontent.com/u/1591483?v=3","gravatar_id":"","url":"https://api.github.com/users/arb","html_url":"https://github.com/arb","followers_url":"https://api.github.com/users/arb/followers","following_url":"https://api.github.com/users/arb/following{/other_user}","gists_url":"https://api.github.com/users/arb/gists{/gist_id}","starred_url":"https://api.github.com/users/arb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arb/subscriptions","organizations_url":"https://api.github.com/users/arb/orgs","repos_url":"https://api.github.com/users/arb/repos","events_url":"https://api.github.com/users/arb/events{/privacy}","received_events_url":"https://api.github.com/users/arb/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/hapijs/good-squeeze/milestones/8","html_url":"https://github.com/hapijs/good-squeeze/milestones/4.1.0","labels_url":"https://api.github.com/repos/hapijs/good-squeeze/milestones/8/labels","id":1827818,"number":8,"title":"4.1.0","description":"","creator":{"login":"arb","id":1591483,"avatar_url":"https://avatars.githubusercontent.com/u/1591483?v=3","gravatar_id":"","url":"https://api.github.com/users/arb","html_url":"https://github.com/arb","followers_url":"https://api.github.com/users/arb/followers","following_url":"https://api.github.com/users/arb/following{/other_user}","gists_url":"https://api.github.com/users/arb/gists{/gist_id}","starred_url":"https://api.github.com/users/arb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arb/subscriptions","organizations_url":"https://api.github.com/users/arb/orgs","repos_url":"https://api.github.com/users/arb/repos","events_url":"https://api.github.com/users/arb/events{/privacy}","received_events_url":"https://api.github.com/users/arb/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":0,"state":"open","created_at":"2016-06-14T23:07:07Z","updated_at":"2016-09-14T15:20:55Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/hapijs/good-squeeze/pulls/16/commits","review_comments_url":"https://api.github.com/repos/hapijs/good-squeeze/pulls/16/comments","review_comment_url":"https://api.github.com/repos/hapijs/good-squeeze/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hapijs/good-squeeze/issues/16/comments","statuses_url":"https://api.github.com/repos/hapijs/good-squeeze/statuses/b29229a5e6e914a700780621eba2fb80e15c87e2","head":{"label":"benleen:exclude-include","ref":"exclude-include","sha":"b29229a5e6e914a700780621eba2fb80e15c87e2","user":{"login":"benleen","id":2865406,"avatar_url":"https://avatars.githubusercontent.com/u/2865406?v=3","gravatar_id":"","url":"https://api.github.com/users/benleen","html_url":"https://github.com/benleen","followers_url":"https://api.github.com/users/benleen/followers","following_url":"https://api.github.com/users/benleen/following{/other_user}","gists_url":"https://api.github.com/users/benleen/gists{/gist_id}","starred_url":"https://api.github.com/users/benleen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benleen/subscriptions","organizations_url":"https://api.github.com/users/benleen/orgs","repos_url":"https://api.github.com/users/benleen/repos","events_url":"https://api.github.com/users/benleen/events{/privacy}","received_events_url":"https://api.github.com/users/benleen/received_events","type":"User","site_admin":false},"repo":{"id":63339528,"name":"good-squeeze","full_name":"benleen/good-squeeze","owner":{"login":"benleen","id":2865406,"avatar_url":"https://avatars.githubusercontent.com/u/2865406?v=3","gravatar_id":"","url":"https://api.github.com/users/benleen","html_url":"https://github.com/benleen","followers_url":"https://api.github.com/users/benleen/followers","following_url":"https://api.github.com/users/benleen/following{/other_user}","gists_url":"https://api.github.com/users/benleen/gists{/gist_id}","starred_url":"https://api.github.com/users/benleen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benleen/subscriptions","organizations_url":"https://api.github.com/users/benleen/orgs","repos_url":"https://api.github.com/users/benleen/repos","events_url":"https://api.github.com/users/benleen/events{/privacy}","received_events_url":"https://api.github.com/users/benleen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/benleen/good-squeeze","description":"Simple transform stream for event filtering with good.","fork":true,"url":"https://api.github.com/repos/benleen/good-squeeze","forks_url":"https://api.github.com/repos/benleen/good-squeeze/forks","keys_url":"https://api.github.com/repos/benleen/good-squeeze/keys{/key_id}","collaborators_url":"https://api.github.com/repos/benleen/good-squeeze/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/benleen/good-squeeze/teams","hooks_url":"https://api.github.com/repos/benleen/good-squeeze/hooks","issue_events_url":"https://api.github.com/repos/benleen/good-squeeze/issues/events{/number}","events_url":"https://api.github.com/repos/benleen/good-squeeze/events","assignees_url":"https://api.github.com/repos/benleen/good-squeeze/assignees{/user}","branches_url":"https://api.github.com/repos/benleen/good-squeeze/branches{/branch}","tags_url":"https://api.github.com/repos/benleen/good-squeeze/tags","blobs_url":"https://api.github.com/repos/benleen/good-squeeze/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/benleen/good-squeeze/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/benleen/good-squeeze/git/refs{/sha}","trees_url":"https://api.github.com/repos/benleen/good-squeeze/git/trees{/sha}","statuses_url":"https://api.github.com/repos/benleen/good-squeeze/statuses/{sha}","languages_url":"https://api.github.com/repos/benleen/good-squeeze/languages","stargazers_url":"https://api.github.com/repos/benleen/good-squeeze/stargazers","contributors_url":"https://api.github.com/repos/benleen/good-squeeze/contributors","subscribers_url":"https://api.github.com/repos/benleen/good-squeeze/subscribers","subscription_url":"https://api.github.com/repos/benleen/good-squeeze/subscription","commits_url":"https://api.github.com/repos/benleen/good-squeeze/commits{/sha}","git_commits_url":"https://api.github.com/repos/benleen/good-squeeze/git/commits{/sha}","comments_url":"https://api.github.com/repos/benleen/good-squeeze/comments{/number}","issue_comment_url":"https://api.github.com/repos/benleen/good-squeeze/issues/comments{/number}","contents_url":"https://api.github.com/repos/benleen/good-squeeze/contents/{+path}","compare_url":"https://api.github.com/repos/benleen/good-squeeze/compare/{base}...{head}","merges_url":"https://api.github.com/repos/benleen/good-squeeze/merges","archive_url":"https://api.github.com/repos/benleen/good-squeeze/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/benleen/good-squeeze/downloads","issues_url":"https://api.github.com/repos/benleen/good-squeeze/issues{/number}","pulls_url":"https://api.github.com/repos/benleen/good-squeeze/pulls{/number}","milestones_url":"https://api.github.com/repos/benleen/good-squeeze/milestones{/number}","notifications_url":"https://api.github.com/repos/benleen/good-squeeze/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/benleen/good-squeeze/labels{/name}","releases_url":"https://api.github.com/repos/benleen/good-squeeze/releases{/id}","deployments_url":"https://api.github.com/repos/benleen/good-squeeze/deployments","created_at":"2016-07-14T13:37:07Z","updated_at":"2016-07-14T13:37:08Z","pushed_at":"2016-09-15T07:50:04Z","git_url":"git://github.com/benleen/good-squeeze.git","ssh_url":"git@github.com:benleen/good-squeeze.git","clone_url":"https://github.com/benleen/good-squeeze.git","svn_url":"https://github.com/benleen/good-squeeze","homepage":null,"size":35,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hapijs:master","ref":"master","sha":"fa3639da70c2ce29cd5058958d76953d5b8b27ab","user":{"login":"hapijs","id":3774533,"avatar_url":"https://avatars.githubusercontent.com/u/3774533?v=3","gravatar_id":"","url":"https://api.github.com/users/hapijs","html_url":"https://github.com/hapijs","followers_url":"https://api.github.com/users/hapijs/followers","following_url":"https://api.github.com/users/hapijs/following{/other_user}","gists_url":"https://api.github.com/users/hapijs/gists{/gist_id}","starred_url":"https://api.github.com/users/hapijs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hapijs/subscriptions","organizations_url":"https://api.github.com/users/hapijs/orgs","repos_url":"https://api.github.com/users/hapijs/repos","events_url":"https://api.github.com/users/hapijs/events{/privacy}","received_events_url":"https://api.github.com/users/hapijs/received_events","type":"Organization","site_admin":false},"repo":{"id":29483421,"name":"good-squeeze","full_name":"hapijs/good-squeeze","owner":{"login":"hapijs","id":3774533,"avatar_url":"https://avatars.githubusercontent.com/u/3774533?v=3","gravatar_id":"","url":"https://api.github.com/users/hapijs","html_url":"https://github.com/hapijs","followers_url":"https://api.github.com/users/hapijs/followers","following_url":"https://api.github.com/users/hapijs/following{/other_user}","gists_url":"https://api.github.com/users/hapijs/gists{/gist_id}","starred_url":"https://api.github.com/users/hapijs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hapijs/subscriptions","organizations_url":"https://api.github.com/users/hapijs/orgs","repos_url":"https://api.github.com/users/hapijs/repos","events_url":"https://api.github.com/users/hapijs/events{/privacy}","received_events_url":"https://api.github.com/users/hapijs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hapijs/good-squeeze","description":"Simple transform stream for event filtering with good.","fork":false,"url":"https://api.github.com/repos/hapijs/good-squeeze","forks_url":"https://api.github.com/repos/hapijs/good-squeeze/forks","keys_url":"https://api.github.com/repos/hapijs/good-squeeze/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hapijs/good-squeeze/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hapijs/good-squeeze/teams","hooks_url":"https://api.github.com/repos/hapijs/good-squeeze/hooks","issue_events_url":"https://api.github.com/repos/hapijs/good-squeeze/issues/events{/number}","events_url":"https://api.github.com/repos/hapijs/good-squeeze/events","assignees_url":"https://api.github.com/repos/hapijs/good-squeeze/assignees{/user}","branches_url":"https://api.github.com/repos/hapijs/good-squeeze/branches{/branch}","tags_url":"https://api.github.com/repos/hapijs/good-squeeze/tags","blobs_url":"https://api.github.com/repos/hapijs/good-squeeze/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hapijs/good-squeeze/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hapijs/good-squeeze/git/refs{/sha}","trees_url":"https://api.github.com/repos/hapijs/good-squeeze/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hapijs/good-squeeze/statuses/{sha}","languages_url":"https://api.github.com/repos/hapijs/good-squeeze/languages","stargazers_url":"https://api.github.com/repos/hapijs/good-squeeze/stargazers","contributors_url":"https://api.github.com/repos/hapijs/good-squeeze/contributors","subscribers_url":"https://api.github.com/repos/hapijs/good-squeeze/subscribers","subscription_url":"https://api.github.com/repos/hapijs/good-squeeze/subscription","commits_url":"https://api.github.com/repos/hapijs/good-squeeze/commits{/sha}","git_commits_url":"https://api.github.com/repos/hapijs/good-squeeze/git/commits{/sha}","comments_url":"https://api.github.com/repos/hapijs/good-squeeze/comments{/number}","issue_comment_url":"https://api.github.com/repos/hapijs/good-squeeze/issues/comments{/number}","contents_url":"https://api.github.com/repos/hapijs/good-squeeze/contents/{+path}","compare_url":"https://api.github.com/repos/hapijs/good-squeeze/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hapijs/good-squeeze/merges","archive_url":"https://api.github.com/repos/hapijs/good-squeeze/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hapijs/good-squeeze/downloads","issues_url":"https://api.github.com/repos/hapijs/good-squeeze/issues{/number}","pulls_url":"https://api.github.com/repos/hapijs/good-squeeze/pulls{/number}","milestones_url":"https://api.github.com/repos/hapijs/good-squeeze/milestones{/number}","notifications_url":"https://api.github.com/repos/hapijs/good-squeeze/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hapijs/good-squeeze/labels{/name}","releases_url":"https://api.github.com/repos/hapijs/good-squeeze/releases{/id}","deployments_url":"https://api.github.com/repos/hapijs/good-squeeze/deployments","created_at":"2015-01-19T17:50:14Z","updated_at":"2016-07-22T02:17:00Z","pushed_at":"2016-09-15T07:50:04Z","git_url":"git://github.com/hapijs/good-squeeze.git","ssh_url":"git@github.com:hapijs/good-squeeze.git","clone_url":"https://github.com/hapijs/good-squeeze.git","svn_url":"https://github.com/hapijs/good-squeeze","homepage":null,"size":28,"stargazers_count":17,"watchers_count":17,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":1,"forks":6,"open_issues":1,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hapijs/good-squeeze/pulls/16"},"html":{"href":"https://github.com/hapijs/good-squeeze/pull/16"},"issue":{"href":"https://api.github.com/repos/hapijs/good-squeeze/issues/16"},"comments":{"href":"https://api.github.com/repos/hapijs/good-squeeze/issues/16/comments"},"review_comments":{"href":"https://api.github.com/repos/hapijs/good-squeeze/pulls/16/comments"},"review_comment":{"href":"https://api.github.com/repos/hapijs/good-squeeze/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hapijs/good-squeeze/pulls/16/commits"},"statuses":{"href":"https://api.github.com/repos/hapijs/good-squeeze/statuses/b29229a5e6e914a700780621eba2fb80e15c87e2"}}}}
{"actor":{"display_login":"benleen"}}