{"action":"created","issue":{"url":"https://api.github.com/repos/hashicorp/terraform/issues/5460","repository_url":"https://api.github.com/repos/hashicorp/terraform","labels_url":"https://api.github.com/repos/hashicorp/terraform/issues/5460/labels{/name}","comments_url":"https://api.github.com/repos/hashicorp/terraform/issues/5460/comments","events_url":"https://api.github.com/repos/hashicorp/terraform/issues/5460/events","html_url":"https://github.com/hashicorp/terraform/pull/5460","id":138537928,"number":5460,"title":"helper/resource: restore retval of resource.Retry on timeout","user":{"login":"phinze","id":37534,"avatar_url":"https://avatars.githubusercontent.com/u/37534?v=3","gravatar_id":"","url":"https://api.github.com/users/phinze","html_url":"https://github.com/phinze","followers_url":"https://api.github.com/users/phinze/followers","following_url":"https://api.github.com/users/phinze/following{/other_user}","gists_url":"https://api.github.com/users/phinze/gists{/gist_id}","starred_url":"https://api.github.com/users/phinze/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phinze/subscriptions","organizations_url":"https://api.github.com/users/phinze/orgs","repos_url":"https://api.github.com/users/phinze/repos","events_url":"https://api.github.com/users/phinze/events{/privacy}","received_events_url":"https://api.github.com/users/phinze/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/hashicorp/terraform/labels/core","name":"core","color":"cccccc"},{"url":"https://api.github.com/repos/hashicorp/terraform/labels/enhancement","name":"enhancement","color":"d4c5f9"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-03-04T17:45:06Z","updated_at":"2016-03-06T09:06:09Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/hashicorp/terraform/pulls/5460","html_url":"https://github.com/hashicorp/terraform/pull/5460","diff_url":"https://github.com/hashicorp/terraform/pull/5460.diff","patch_url":"https://github.com/hashicorp/terraform/pull/5460.patch"},"body":"In #4700 while fixing a data race I made an incorrect assumption about\r\nthe return value of StateChangeConf, and ended up changing the behavior\r\nin the timeout case to always return:\r\n\r\n> timeout while waiting for state to become '[success]'\r\n\r\nWhen it used to capture the \"most recent error\" from the function\r\nitself.\r\n\r\nIt's much more useful to see that error bubbling up, so here we revert\r\nto pulling it out of the function as we did before, and we protect\r\nagainst the data race with a good old fashioned mutex."},"comment":{"url":"https://api.github.com/repos/hashicorp/terraform/issues/comments/192842012","html_url":"https://github.com/hashicorp/terraform/pull/5460#issuecomment-192842012","issue_url":"https://api.github.com/repos/hashicorp/terraform/issues/5460","id":192842012,"user":{"login":"brikis98","id":711908,"avatar_url":"https://avatars.githubusercontent.com/u/711908?v=3","gravatar_id":"","url":"https://api.github.com/users/brikis98","html_url":"https://github.com/brikis98","followers_url":"https://api.github.com/users/brikis98/followers","following_url":"https://api.github.com/users/brikis98/following{/other_user}","gists_url":"https://api.github.com/users/brikis98/gists{/gist_id}","starred_url":"https://api.github.com/users/brikis98/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brikis98/subscriptions","organizations_url":"https://api.github.com/users/brikis98/orgs","repos_url":"https://api.github.com/users/brikis98/repos","events_url":"https://api.github.com/users/brikis98/events{/privacy}","received_events_url":"https://api.github.com/users/brikis98/received_events","type":"User","site_admin":false},"created_at":"2016-03-06T09:06:09Z","updated_at":"2016-03-06T09:06:09Z","body":"Is there any workaround for the `timeout while waiting for state to become '[success]'` error until this is merged and released?"}}