{"action":"created","issue":{"url":"https://api.github.com/repos/ceph/ceph/issues/7338","repository_url":"https://api.github.com/repos/ceph/ceph","labels_url":"https://api.github.com/repos/ceph/ceph/issues/7338/labels{/name}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/7338/comments","events_url":"https://api.github.com/repos/ceph/ceph/issues/7338/events","html_url":"https://github.com/ceph/ceph/pull/7338","id":128365016,"number":7338,"title":"Lua object class support","user":{"login":"noahdesu","id":242417,"avatar_url":"https://avatars.githubusercontent.com/u/242417?v=3","gravatar_id":"","url":"https://api.github.com/users/noahdesu","html_url":"https://github.com/noahdesu","followers_url":"https://api.github.com/users/noahdesu/followers","following_url":"https://api.github.com/users/noahdesu/following{/other_user}","gists_url":"https://api.github.com/users/noahdesu/gists{/gist_id}","starred_url":"https://api.github.com/users/noahdesu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noahdesu/subscriptions","organizations_url":"https://api.github.com/users/noahdesu/orgs","repos_url":"https://api.github.com/users/noahdesu/repos","events_url":"https://api.github.com/users/noahdesu/events{/privacy}","received_events_url":"https://api.github.com/users/noahdesu/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ceph/ceph/labels/core","name":"core","color":"0052cc"},{"url":"https://api.github.com/repos/ceph/ceph/labels/feature","name":"feature","color":"009800"},{"url":"https://api.github.com/repos/ceph/ceph/labels/needs-integration-qa","name":"needs-integration-qa","color":"006b75"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":39,"created_at":"2016-01-24T01:19:29Z","updated_at":"2016-08-09T20:42:10Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/7338","html_url":"https://github.com/ceph/ceph/pull/7338","diff_url":"https://github.com/ceph/ceph/pull/7338.diff","patch_url":"https://github.com/ceph/ceph/pull/7338.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/ceph/ceph/issues/comments/238684514","html_url":"https://github.com/ceph/ceph/pull/7338#issuecomment-238684514","issue_url":"https://api.github.com/repos/ceph/ceph/issues/7338","id":238684514,"user":{"login":"noahdesu","id":242417,"avatar_url":"https://avatars.githubusercontent.com/u/242417?v=3","gravatar_id":"","url":"https://api.github.com/users/noahdesu","html_url":"https://github.com/noahdesu","followers_url":"https://api.github.com/users/noahdesu/followers","following_url":"https://api.github.com/users/noahdesu/following{/other_user}","gists_url":"https://api.github.com/users/noahdesu/gists{/gist_id}","starred_url":"https://api.github.com/users/noahdesu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noahdesu/subscriptions","organizations_url":"https://api.github.com/users/noahdesu/orgs","repos_url":"https://api.github.com/users/noahdesu/repos","events_url":"https://api.github.com/users/noahdesu/events{/privacy}","received_events_url":"https://api.github.com/users/noahdesu/received_events","type":"User","site_admin":false},"created_at":"2016-08-09T20:42:10Z","updated_at":"2016-08-09T20:42:10Z","body":"@tchaikov I think I misread your comment. I understand the global impact of the `BUILD_SHARED_LIBS` variable. I was asking about patching it indirectly: that variable is set in `lua/cmake/dist.cmake` which contains stuff related to installation and packaging---cmake boilerplate that we do not depend on, including shared library building which doesn't matter since we build lua as  a static library. So I disabled the entire inclusion of `lua/cmake/dist.cmake`, including the `BUILD_SHARED_LIBS` global library. This file also sets numerous cmake variables, so we don't need to worry about them clobbering other settings either."}}
{"actor":{"display_login":"noahdesu"}}