{"action":"created","comment":{"url":"https://api.github.com/repos/FAForever/fa/pulls/comments/67623607","id":67623607,"diff_hunk":"@@ -1580,30 +1576,22 @@ local function TryLaunch(skipNoObserversCheck)\n             return\n         end\n \n-        if anyOtherObservers then\n-            if skipNoObserversCheck then\n-                -- we send the observer list before kicking the players, in case they are not registered as observer\n-                -- and won't disconnect correctly before the game launch.","path":"lua/ui/lobby/lobby.lua","position":18,"original_position":18,"commit_id":"802410728f1ab1caf239230a9c0547a93f54f204","original_commit_id":"802410728f1ab1caf239230a9c0547a93f54f204","user":{"login":"Crotalus","id":254972,"avatar_url":"https://avatars.githubusercontent.com/u/254972?v=3","gravatar_id":"","url":"https://api.github.com/users/Crotalus","html_url":"https://github.com/Crotalus","followers_url":"https://api.github.com/users/Crotalus/followers","following_url":"https://api.github.com/users/Crotalus/following{/other_user}","gists_url":"https://api.github.com/users/Crotalus/gists{/gist_id}","starred_url":"https://api.github.com/users/Crotalus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Crotalus/subscriptions","organizations_url":"https://api.github.com/users/Crotalus/orgs","repos_url":"https://api.github.com/users/Crotalus/repos","events_url":"https://api.github.com/users/Crotalus/events{/privacy}","received_events_url":"https://api.github.com/users/Crotalus/received_events","type":"User","site_admin":false},"body":"`sendObserversList` was removed with e3a5cd7c53d498b4db2a748b7f20b360544f6788 so current version probably pukes around here.","created_at":"2016-06-19T20:51:05Z","updated_at":"2016-06-19T20:51:05Z","html_url":"https://github.com/FAForever/fa/pull/1285#discussion_r67623607","pull_request_url":"https://api.github.com/repos/FAForever/fa/pulls/1285","_links":{"self":{"href":"https://api.github.com/repos/FAForever/fa/pulls/comments/67623607"},"html":{"href":"https://github.com/FAForever/fa/pull/1285#discussion_r67623607"},"pull_request":{"href":"https://api.github.com/repos/FAForever/fa/pulls/1285"}}},"pull_request":{"url":"https://api.github.com/repos/FAForever/fa/pulls/1285","id":70348198,"html_url":"https://github.com/FAForever/fa/pull/1285","diff_url":"https://github.com/FAForever/fa/pull/1285.diff","patch_url":"https://github.com/FAForever/fa/pull/1285.patch","issue_url":"https://api.github.com/repos/FAForever/fa/issues/1285","number":1285,"state":"open","locked":false,"title":"Kick observers before checking connection issues","user":{"login":"Crotalus","id":254972,"avatar_url":"https://avatars.githubusercontent.com/u/254972?v=3","gravatar_id":"","url":"https://api.github.com/users/Crotalus","html_url":"https://github.com/Crotalus","followers_url":"https://api.github.com/users/Crotalus/followers","following_url":"https://api.github.com/users/Crotalus/following{/other_user}","gists_url":"https://api.github.com/users/Crotalus/gists{/gist_id}","starred_url":"https://api.github.com/users/Crotalus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Crotalus/subscriptions","organizations_url":"https://api.github.com/users/Crotalus/orgs","repos_url":"https://api.github.com/users/Crotalus/repos","events_url":"https://api.github.com/users/Crotalus/events{/privacy}","received_events_url":"https://api.github.com/users/Crotalus/received_events","type":"User","site_admin":false},"body":"Otherwise the host need to manually kick observers with connection issues before able to launch the game.","created_at":"2016-05-17T12:30:25Z","updated_at":"2016-06-19T20:51:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"42257f572f0c8b6584fee2a70d0f2efb0c7f8858","assignee":null,"milestone":{"url":"https://api.github.com/repos/FAForever/fa/milestones/11","html_url":"https://github.com/FAForever/fa/milestones/3656","labels_url":"https://api.github.com/repos/FAForever/fa/milestones/11/labels","id":1193550,"number":11,"title":"3656","description":"","creator":{"login":"Sheeo","id":37968,"avatar_url":"https://avatars.githubusercontent.com/u/37968?v=3","gravatar_id":"","url":"https://api.github.com/users/Sheeo","html_url":"https://github.com/Sheeo","followers_url":"https://api.github.com/users/Sheeo/followers","following_url":"https://api.github.com/users/Sheeo/following{/other_user}","gists_url":"https://api.github.com/users/Sheeo/gists{/gist_id}","starred_url":"https://api.github.com/users/Sheeo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sheeo/subscriptions","organizations_url":"https://api.github.com/users/Sheeo/orgs","repos_url":"https://api.github.com/users/Sheeo/repos","events_url":"https://api.github.com/users/Sheeo/events{/privacy}","received_events_url":"https://api.github.com/users/Sheeo/received_events","type":"User","site_admin":false},"open_issues":32,"closed_issues":20,"state":"open","created_at":"2015-07-05T10:46:17Z","updated_at":"2016-06-12T05:18:40Z","due_on":"2016-06-12T22:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/FAForever/fa/pulls/1285/commits","review_comments_url":"https://api.github.com/repos/FAForever/fa/pulls/1285/comments","review_comment_url":"https://api.github.com/repos/FAForever/fa/pulls/comments{/number}","comments_url":"https://api.github.com/repos/FAForever/fa/issues/1285/comments","statuses_url":"https://api.github.com/repos/FAForever/fa/statuses/802410728f1ab1caf239230a9c0547a93f54f204","head":{"label":"Crotalus:kick-observers-pre-launch","ref":"kick-observers-pre-launch","sha":"802410728f1ab1caf239230a9c0547a93f54f204","user":{"login":"Crotalus","id":254972,"avatar_url":"https://avatars.githubusercontent.com/u/254972?v=3","gravatar_id":"","url":"https://api.github.com/users/Crotalus","html_url":"https://github.com/Crotalus","followers_url":"https://api.github.com/users/Crotalus/followers","following_url":"https://api.github.com/users/Crotalus/following{/other_user}","gists_url":"https://api.github.com/users/Crotalus/gists{/gist_id}","starred_url":"https://api.github.com/users/Crotalus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Crotalus/subscriptions","organizations_url":"https://api.github.com/users/Crotalus/orgs","repos_url":"https://api.github.com/users/Crotalus/repos","events_url":"https://api.github.com/users/Crotalus/events{/privacy}","received_events_url":"https://api.github.com/users/Crotalus/received_events","type":"User","site_admin":false},"repo":{"id":24535673,"name":"fa","full_name":"Crotalus/fa","owner":{"login":"Crotalus","id":254972,"avatar_url":"https://avatars.githubusercontent.com/u/254972?v=3","gravatar_id":"","url":"https://api.github.com/users/Crotalus","html_url":"https://github.com/Crotalus","followers_url":"https://api.github.com/users/Crotalus/followers","following_url":"https://api.github.com/users/Crotalus/following{/other_user}","gists_url":"https://api.github.com/users/Crotalus/gists{/gist_id}","starred_url":"https://api.github.com/users/Crotalus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Crotalus/subscriptions","organizations_url":"https://api.github.com/users/Crotalus/orgs","repos_url":"https://api.github.com/users/Crotalus/repos","events_url":"https://api.github.com/users/Crotalus/events{/privacy}","received_events_url":"https://api.github.com/users/Crotalus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Crotalus/fa","description":"Lua code for FAF","fork":true,"url":"https://api.github.com/repos/Crotalus/fa","forks_url":"https://api.github.com/repos/Crotalus/fa/forks","keys_url":"https://api.github.com/repos/Crotalus/fa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Crotalus/fa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Crotalus/fa/teams","hooks_url":"https://api.github.com/repos/Crotalus/fa/hooks","issue_events_url":"https://api.github.com/repos/Crotalus/fa/issues/events{/number}","events_url":"https://api.github.com/repos/Crotalus/fa/events","assignees_url":"https://api.github.com/repos/Crotalus/fa/assignees{/user}","branches_url":"https://api.github.com/repos/Crotalus/fa/branches{/branch}","tags_url":"https://api.github.com/repos/Crotalus/fa/tags","blobs_url":"https://api.github.com/repos/Crotalus/fa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Crotalus/fa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Crotalus/fa/git/refs{/sha}","trees_url":"https://api.github.com/repos/Crotalus/fa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Crotalus/fa/statuses/{sha}","languages_url":"https://api.github.com/repos/Crotalus/fa/languages","stargazers_url":"https://api.github.com/repos/Crotalus/fa/stargazers","contributors_url":"https://api.github.com/repos/Crotalus/fa/contributors","subscribers_url":"https://api.github.com/repos/Crotalus/fa/subscribers","subscription_url":"https://api.github.com/repos/Crotalus/fa/subscription","commits_url":"https://api.github.com/repos/Crotalus/fa/commits{/sha}","git_commits_url":"https://api.github.com/repos/Crotalus/fa/git/commits{/sha}","comments_url":"https://api.github.com/repos/Crotalus/fa/comments{/number}","issue_comment_url":"https://api.github.com/repos/Crotalus/fa/issues/comments{/number}","contents_url":"https://api.github.com/repos/Crotalus/fa/contents/{+path}","compare_url":"https://api.github.com/repos/Crotalus/fa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Crotalus/fa/merges","archive_url":"https://api.github.com/repos/Crotalus/fa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Crotalus/fa/downloads","issues_url":"https://api.github.com/repos/Crotalus/fa/issues{/number}","pulls_url":"https://api.github.com/repos/Crotalus/fa/pulls{/number}","milestones_url":"https://api.github.com/repos/Crotalus/fa/milestones{/number}","notifications_url":"https://api.github.com/repos/Crotalus/fa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Crotalus/fa/labels{/name}","releases_url":"https://api.github.com/repos/Crotalus/fa/releases{/id}","deployments_url":"https://api.github.com/repos/Crotalus/fa/deployments","created_at":"2014-09-27T15:44:04Z","updated_at":"2016-05-15T22:41:39Z","pushed_at":"2016-06-17T06:40:04Z","git_url":"git://github.com/Crotalus/fa.git","ssh_url":"git@github.com:Crotalus/fa.git","clone_url":"https://github.com/Crotalus/fa.git","svn_url":"https://github.com/Crotalus/fa","homepage":"","size":104726,"stargazers_count":0,"watchers_count":0,"language":"Lua","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"FAForever:develop","ref":"develop","sha":"130e59468265b6a4cd567509bf8ea19ef93df4cd","user":{"login":"FAForever","id":8887184,"avatar_url":"https://avatars.githubusercontent.com/u/8887184?v=3","gravatar_id":"","url":"https://api.github.com/users/FAForever","html_url":"https://github.com/FAForever","followers_url":"https://api.github.com/users/FAForever/followers","following_url":"https://api.github.com/users/FAForever/following{/other_user}","gists_url":"https://api.github.com/users/FAForever/gists{/gist_id}","starred_url":"https://api.github.com/users/FAForever/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FAForever/subscriptions","organizations_url":"https://api.github.com/users/FAForever/orgs","repos_url":"https://api.github.com/users/FAForever/repos","events_url":"https://api.github.com/users/FAForever/events{/privacy}","received_events_url":"https://api.github.com/users/FAForever/received_events","type":"Organization","site_admin":false},"repo":{"id":24403473,"name":"fa","full_name":"FAForever/fa","owner":{"login":"FAForever","id":8887184,"avatar_url":"https://avatars.githubusercontent.com/u/8887184?v=3","gravatar_id":"","url":"https://api.github.com/users/FAForever","html_url":"https://github.com/FAForever","followers_url":"https://api.github.com/users/FAForever/followers","following_url":"https://api.github.com/users/FAForever/following{/other_user}","gists_url":"https://api.github.com/users/FAForever/gists{/gist_id}","starred_url":"https://api.github.com/users/FAForever/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FAForever/subscriptions","organizations_url":"https://api.github.com/users/FAForever/orgs","repos_url":"https://api.github.com/users/FAForever/repos","events_url":"https://api.github.com/users/FAForever/events{/privacy}","received_events_url":"https://api.github.com/users/FAForever/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/FAForever/fa","description":"Lua code for FAF","fork":false,"url":"https://api.github.com/repos/FAForever/fa","forks_url":"https://api.github.com/repos/FAForever/fa/forks","keys_url":"https://api.github.com/repos/FAForever/fa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FAForever/fa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FAForever/fa/teams","hooks_url":"https://api.github.com/repos/FAForever/fa/hooks","issue_events_url":"https://api.github.com/repos/FAForever/fa/issues/events{/number}","events_url":"https://api.github.com/repos/FAForever/fa/events","assignees_url":"https://api.github.com/repos/FAForever/fa/assignees{/user}","branches_url":"https://api.github.com/repos/FAForever/fa/branches{/branch}","tags_url":"https://api.github.com/repos/FAForever/fa/tags","blobs_url":"https://api.github.com/repos/FAForever/fa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FAForever/fa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FAForever/fa/git/refs{/sha}","trees_url":"https://api.github.com/repos/FAForever/fa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FAForever/fa/statuses/{sha}","languages_url":"https://api.github.com/repos/FAForever/fa/languages","stargazers_url":"https://api.github.com/repos/FAForever/fa/stargazers","contributors_url":"https://api.github.com/repos/FAForever/fa/contributors","subscribers_url":"https://api.github.com/repos/FAForever/fa/subscribers","subscription_url":"https://api.github.com/repos/FAForever/fa/subscription","commits_url":"https://api.github.com/repos/FAForever/fa/commits{/sha}","git_commits_url":"https://api.github.com/repos/FAForever/fa/git/commits{/sha}","comments_url":"https://api.github.com/repos/FAForever/fa/comments{/number}","issue_comment_url":"https://api.github.com/repos/FAForever/fa/issues/comments{/number}","contents_url":"https://api.github.com/repos/FAForever/fa/contents/{+path}","compare_url":"https://api.github.com/repos/FAForever/fa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FAForever/fa/merges","archive_url":"https://api.github.com/repos/FAForever/fa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FAForever/fa/downloads","issues_url":"https://api.github.com/repos/FAForever/fa/issues{/number}","pulls_url":"https://api.github.com/repos/FAForever/fa/pulls{/number}","milestones_url":"https://api.github.com/repos/FAForever/fa/milestones{/number}","notifications_url":"https://api.github.com/repos/FAForever/fa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FAForever/fa/labels{/name}","releases_url":"https://api.github.com/repos/FAForever/fa/releases{/id}","deployments_url":"https://api.github.com/repos/FAForever/fa/deployments","created_at":"2014-09-24T06:34:12Z","updated_at":"2016-05-10T19:02:05Z","pushed_at":"2016-06-18T19:50:00Z","git_url":"git://github.com/FAForever/fa.git","ssh_url":"git@github.com:FAForever/fa.git","clone_url":"https://github.com/FAForever/fa.git","svn_url":"https://github.com/FAForever/fa","homepage":"","size":114781,"stargazers_count":36,"watchers_count":36,"language":"Lua","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":52,"mirror_url":null,"open_issues_count":207,"forks":52,"open_issues":207,"watchers":36,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/FAForever/fa/pulls/1285"},"html":{"href":"https://github.com/FAForever/fa/pull/1285"},"issue":{"href":"https://api.github.com/repos/FAForever/fa/issues/1285"},"comments":{"href":"https://api.github.com/repos/FAForever/fa/issues/1285/comments"},"review_comments":{"href":"https://api.github.com/repos/FAForever/fa/pulls/1285/comments"},"review_comment":{"href":"https://api.github.com/repos/FAForever/fa/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/FAForever/fa/pulls/1285/commits"},"statuses":{"href":"https://api.github.com/repos/FAForever/fa/statuses/802410728f1ab1caf239230a9c0547a93f54f204"}}}}
{"actor":{"display_login":"Crotalus"}}