{"action":"closed","number":131,"pull_request":{"url":"https://api.github.com/repos/donejs/bitballs/pulls/131","id":62094571,"html_url":"https://github.com/donejs/bitballs/pull/131","diff_url":"https://github.com/donejs/bitballs/pull/131.diff","patch_url":"https://github.com/donejs/bitballs/pull/131.patch","issue_url":"https://api.github.com/repos/donejs/bitballs/issues/131","number":131,"state":"closed","locked":false,"title":"Fix arguments affected by call signature change","user":{"login":"akagomez","id":82166,"avatar_url":"https://avatars.githubusercontent.com/u/82166?v=3","gravatar_id":"","url":"https://api.github.com/users/akagomez","html_url":"https://github.com/akagomez","followers_url":"https://api.github.com/users/akagomez/followers","following_url":"https://api.github.com/users/akagomez/following{/other_user}","gists_url":"https://api.github.com/users/akagomez/gists{/gist_id}","starred_url":"https://api.github.com/users/akagomez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akagomez/subscriptions","organizations_url":"https://api.github.com/users/akagomez/orgs","repos_url":"https://api.github.com/users/akagomez/repos","events_url":"https://api.github.com/users/akagomez/events{/privacy}","received_events_url":"https://api.github.com/users/akagomez/received_events","type":"User","site_admin":false},"body":"A last minute call signature change caused the `event` argument to be undefined, resulting in `event.stopPropagation` not getting called. \r\n\r\nBy changing the call signature the event isn't propagated - meaning `gotoTimeMinus5` isn't called - the player isn't seeked in issue #126 and the error isn't thrown in issue #130. \r\n\r\nCloses #126, #130","created_at":"2016-03-08T16:17:41Z","updated_at":"2016-03-10T01:50:35Z","closed_at":"2016-03-10T01:50:35Z","merged_at":"2016-03-10T01:50:35Z","merge_commit_sha":"a19290c2cadf6c93c09782deae671c1922ee1083","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/donejs/bitballs/pulls/131/commits","review_comments_url":"https://api.github.com/repos/donejs/bitballs/pulls/131/comments","review_comment_url":"https://api.github.com/repos/donejs/bitballs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/donejs/bitballs/issues/131/comments","statuses_url":"https://api.github.com/repos/donejs/bitballs/statuses/d7edf125b389d959cb8d36e2162d314e152fa461","head":{"label":"donejs:126-prevent-seek-to-on-delete","ref":"126-prevent-seek-to-on-delete","sha":"d7edf125b389d959cb8d36e2162d314e152fa461","user":{"login":"donejs","id":8229389,"avatar_url":"https://avatars.githubusercontent.com/u/8229389?v=3","gravatar_id":"","url":"https://api.github.com/users/donejs","html_url":"https://github.com/donejs","followers_url":"https://api.github.com/users/donejs/followers","following_url":"https://api.github.com/users/donejs/following{/other_user}","gists_url":"https://api.github.com/users/donejs/gists{/gist_id}","starred_url":"https://api.github.com/users/donejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/donejs/subscriptions","organizations_url":"https://api.github.com/users/donejs/orgs","repos_url":"https://api.github.com/users/donejs/repos","events_url":"https://api.github.com/users/donejs/events{/privacy}","received_events_url":"https://api.github.com/users/donejs/received_events","type":"Organization","site_admin":false},"repo":{"id":39485259,"name":"bitballs","full_name":"donejs/bitballs","owner":{"login":"donejs","id":8229389,"avatar_url":"https://avatars.githubusercontent.com/u/8229389?v=3","gravatar_id":"","url":"https://api.github.com/users/donejs","html_url":"https://github.com/donejs","followers_url":"https://api.github.com/users/donejs/followers","following_url":"https://api.github.com/users/donejs/following{/other_user}","gists_url":"https://api.github.com/users/donejs/gists{/gist_id}","starred_url":"https://api.github.com/users/donejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/donejs/subscriptions","organizations_url":"https://api.github.com/users/donejs/orgs","repos_url":"https://api.github.com/users/donejs/repos","events_url":"https://api.github.com/users/donejs/events{/privacy}","received_events_url":"https://api.github.com/users/donejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/donejs/bitballs","description":"A basketball tourney application.","fork":false,"url":"https://api.github.com/repos/donejs/bitballs","forks_url":"https://api.github.com/repos/donejs/bitballs/forks","keys_url":"https://api.github.com/repos/donejs/bitballs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/donejs/bitballs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/donejs/bitballs/teams","hooks_url":"https://api.github.com/repos/donejs/bitballs/hooks","issue_events_url":"https://api.github.com/repos/donejs/bitballs/issues/events{/number}","events_url":"https://api.github.com/repos/donejs/bitballs/events","assignees_url":"https://api.github.com/repos/donejs/bitballs/assignees{/user}","branches_url":"https://api.github.com/repos/donejs/bitballs/branches{/branch}","tags_url":"https://api.github.com/repos/donejs/bitballs/tags","blobs_url":"https://api.github.com/repos/donejs/bitballs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/donejs/bitballs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/donejs/bitballs/git/refs{/sha}","trees_url":"https://api.github.com/repos/donejs/bitballs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/donejs/bitballs/statuses/{sha}","languages_url":"https://api.github.com/repos/donejs/bitballs/languages","stargazers_url":"https://api.github.com/repos/donejs/bitballs/stargazers","contributors_url":"https://api.github.com/repos/donejs/bitballs/contributors","subscribers_url":"https://api.github.com/repos/donejs/bitballs/subscribers","subscription_url":"https://api.github.com/repos/donejs/bitballs/subscription","commits_url":"https://api.github.com/repos/donejs/bitballs/commits{/sha}","git_commits_url":"https://api.github.com/repos/donejs/bitballs/git/commits{/sha}","comments_url":"https://api.github.com/repos/donejs/bitballs/comments{/number}","issue_comment_url":"https://api.github.com/repos/donejs/bitballs/issues/comments{/number}","contents_url":"https://api.github.com/repos/donejs/bitballs/contents/{+path}","compare_url":"https://api.github.com/repos/donejs/bitballs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/donejs/bitballs/merges","archive_url":"https://api.github.com/repos/donejs/bitballs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/donejs/bitballs/downloads","issues_url":"https://api.github.com/repos/donejs/bitballs/issues{/number}","pulls_url":"https://api.github.com/repos/donejs/bitballs/pulls{/number}","milestones_url":"https://api.github.com/repos/donejs/bitballs/milestones{/number}","notifications_url":"https://api.github.com/repos/donejs/bitballs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/donejs/bitballs/labels{/name}","releases_url":"https://api.github.com/repos/donejs/bitballs/releases{/id}","deployments_url":"https://api.github.com/repos/donejs/bitballs/deployments","created_at":"2015-07-22T04:18:47Z","updated_at":"2016-01-28T15:22:40Z","pushed_at":"2016-03-10T01:50:35Z","git_url":"git://github.com/donejs/bitballs.git","ssh_url":"git@github.com:donejs/bitballs.git","clone_url":"https://github.com/donejs/bitballs.git","svn_url":"https://github.com/donejs/bitballs","homepage":null,"size":6188,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":32,"forks":1,"open_issues":32,"watchers":1,"default_branch":"master"}},"base":{"label":"donejs:staging","ref":"staging","sha":"d50a28d01989318450385fad8370b0659e3c6443","user":{"login":"donejs","id":8229389,"avatar_url":"https://avatars.githubusercontent.com/u/8229389?v=3","gravatar_id":"","url":"https://api.github.com/users/donejs","html_url":"https://github.com/donejs","followers_url":"https://api.github.com/users/donejs/followers","following_url":"https://api.github.com/users/donejs/following{/other_user}","gists_url":"https://api.github.com/users/donejs/gists{/gist_id}","starred_url":"https://api.github.com/users/donejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/donejs/subscriptions","organizations_url":"https://api.github.com/users/donejs/orgs","repos_url":"https://api.github.com/users/donejs/repos","events_url":"https://api.github.com/users/donejs/events{/privacy}","received_events_url":"https://api.github.com/users/donejs/received_events","type":"Organization","site_admin":false},"repo":{"id":39485259,"name":"bitballs","full_name":"donejs/bitballs","owner":{"login":"donejs","id":8229389,"avatar_url":"https://avatars.githubusercontent.com/u/8229389?v=3","gravatar_id":"","url":"https://api.github.com/users/donejs","html_url":"https://github.com/donejs","followers_url":"https://api.github.com/users/donejs/followers","following_url":"https://api.github.com/users/donejs/following{/other_user}","gists_url":"https://api.github.com/users/donejs/gists{/gist_id}","starred_url":"https://api.github.com/users/donejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/donejs/subscriptions","organizations_url":"https://api.github.com/users/donejs/orgs","repos_url":"https://api.github.com/users/donejs/repos","events_url":"https://api.github.com/users/donejs/events{/privacy}","received_events_url":"https://api.github.com/users/donejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/donejs/bitballs","description":"A basketball tourney application.","fork":false,"url":"https://api.github.com/repos/donejs/bitballs","forks_url":"https://api.github.com/repos/donejs/bitballs/forks","keys_url":"https://api.github.com/repos/donejs/bitballs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/donejs/bitballs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/donejs/bitballs/teams","hooks_url":"https://api.github.com/repos/donejs/bitballs/hooks","issue_events_url":"https://api.github.com/repos/donejs/bitballs/issues/events{/number}","events_url":"https://api.github.com/repos/donejs/bitballs/events","assignees_url":"https://api.github.com/repos/donejs/bitballs/assignees{/user}","branches_url":"https://api.github.com/repos/donejs/bitballs/branches{/branch}","tags_url":"https://api.github.com/repos/donejs/bitballs/tags","blobs_url":"https://api.github.com/repos/donejs/bitballs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/donejs/bitballs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/donejs/bitballs/git/refs{/sha}","trees_url":"https://api.github.com/repos/donejs/bitballs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/donejs/bitballs/statuses/{sha}","languages_url":"https://api.github.com/repos/donejs/bitballs/languages","stargazers_url":"https://api.github.com/repos/donejs/bitballs/stargazers","contributors_url":"https://api.github.com/repos/donejs/bitballs/contributors","subscribers_url":"https://api.github.com/repos/donejs/bitballs/subscribers","subscription_url":"https://api.github.com/repos/donejs/bitballs/subscription","commits_url":"https://api.github.com/repos/donejs/bitballs/commits{/sha}","git_commits_url":"https://api.github.com/repos/donejs/bitballs/git/commits{/sha}","comments_url":"https://api.github.com/repos/donejs/bitballs/comments{/number}","issue_comment_url":"https://api.github.com/repos/donejs/bitballs/issues/comments{/number}","contents_url":"https://api.github.com/repos/donejs/bitballs/contents/{+path}","compare_url":"https://api.github.com/repos/donejs/bitballs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/donejs/bitballs/merges","archive_url":"https://api.github.com/repos/donejs/bitballs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/donejs/bitballs/downloads","issues_url":"https://api.github.com/repos/donejs/bitballs/issues{/number}","pulls_url":"https://api.github.com/repos/donejs/bitballs/pulls{/number}","milestones_url":"https://api.github.com/repos/donejs/bitballs/milestones{/number}","notifications_url":"https://api.github.com/repos/donejs/bitballs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/donejs/bitballs/labels{/name}","releases_url":"https://api.github.com/repos/donejs/bitballs/releases{/id}","deployments_url":"https://api.github.com/repos/donejs/bitballs/deployments","created_at":"2015-07-22T04:18:47Z","updated_at":"2016-01-28T15:22:40Z","pushed_at":"2016-03-10T01:50:35Z","git_url":"git://github.com/donejs/bitballs.git","ssh_url":"git@github.com:donejs/bitballs.git","clone_url":"https://github.com/donejs/bitballs.git","svn_url":"https://github.com/donejs/bitballs","homepage":null,"size":6188,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":32,"forks":1,"open_issues":32,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/donejs/bitballs/pulls/131"},"html":{"href":"https://github.com/donejs/bitballs/pull/131"},"issue":{"href":"https://api.github.com/repos/donejs/bitballs/issues/131"},"comments":{"href":"https://api.github.com/repos/donejs/bitballs/issues/131/comments"},"review_comments":{"href":"https://api.github.com/repos/donejs/bitballs/pulls/131/comments"},"review_comment":{"href":"https://api.github.com/repos/donejs/bitballs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/donejs/bitballs/pulls/131/commits"},"statuses":{"href":"https://api.github.com/repos/donejs/bitballs/statuses/d7edf125b389d959cb8d36e2162d314e152fa461"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"justinbmeyer","id":78602,"avatar_url":"https://avatars.githubusercontent.com/u/78602?v=3","gravatar_id":"","url":"https://api.github.com/users/justinbmeyer","html_url":"https://github.com/justinbmeyer","followers_url":"https://api.github.com/users/justinbmeyer/followers","following_url":"https://api.github.com/users/justinbmeyer/following{/other_user}","gists_url":"https://api.github.com/users/justinbmeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/justinbmeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinbmeyer/subscriptions","organizations_url":"https://api.github.com/users/justinbmeyer/orgs","repos_url":"https://api.github.com/users/justinbmeyer/repos","events_url":"https://api.github.com/users/justinbmeyer/events{/privacy}","received_events_url":"https://api.github.com/users/justinbmeyer/received_events","type":"User","site_admin":false},"comments":0,"review_comments":1,"commits":2,"additions":34,"deletions":1,"changed_files":2}}