{"action":"created","comment":{"url":"https://api.github.com/repos/cBioPortal/cbioportal/pulls/comments/80136728","id":80136728,"diff_hunk":"@@ -57,10 +57,16 @@ public static int addSampleProfile(int sampleId, int geneticProfileId) throws Da\n             if (!sampleExistsInGeneticProfile(sampleId, geneticProfileId)) {\n                 con = JdbcUtil.getDbConnection(DaoSampleProfile.class);\n                 pstmt = con.prepareStatement\n-                        (\"INSERT INTO sample_profile (`SAMPLE_ID`, `GENETIC_PROFILE_ID`) \"\n-                                + \"VALUES (?,?)\");\n+                        (\"INSERT INTO sample_profile (`SAMPLE_ID`, `GENETIC_PROFILE_ID`, `PANEL_ID`) \"\n+                                + \"VALUES (?,?,?)\");\n                 pstmt.setInt(1, sampleId);\n                 pstmt.setInt(2, geneticProfileId);\n+                if (panelId != null) {\n+                    pstmt.setInt(3, panelId);\n+                }","path":"core/src/main/java/org/mskcc/cbio/portal/dao/DaoSampleProfile.java","position":21,"original_position":21,"commit_id":"098d55795b435caeeb9c240d6c883458ed8dcf80","original_commit_id":"ff6deded1084af54a9a727f443195d769485ba91","user":{"login":"sheridancbio","id":7747489,"avatar_url":"https://avatars.githubusercontent.com/u/7747489?v=3","gravatar_id":"","url":"https://api.github.com/users/sheridancbio","html_url":"https://github.com/sheridancbio","followers_url":"https://api.github.com/users/sheridancbio/followers","following_url":"https://api.github.com/users/sheridancbio/following{/other_user}","gists_url":"https://api.github.com/users/sheridancbio/gists{/gist_id}","starred_url":"https://api.github.com/users/sheridancbio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sheridancbio/subscriptions","organizations_url":"https://api.github.com/users/sheridancbio/orgs","repos_url":"https://api.github.com/users/sheridancbio/repos","events_url":"https://api.github.com/users/sheridancbio/events{/privacy}","received_events_url":"https://api.github.com/users/sheridancbio/received_events","type":"User","site_admin":false},"body":"my style preference: \"} else {\" on one line (several repeats of this below)","created_at":"2016-09-22T21:07:22Z","updated_at":"2016-09-22T21:34:54Z","html_url":"https://github.com/cBioPortal/cbioportal/pull/1700#discussion_r80136728","pull_request_url":"https://api.github.com/repos/cBioPortal/cbioportal/pulls/1700","_links":{"self":{"href":"https://api.github.com/repos/cBioPortal/cbioportal/pulls/comments/80136728"},"html":{"href":"https://github.com/cBioPortal/cbioportal/pull/1700#discussion_r80136728"},"pull_request":{"href":"https://api.github.com/repos/cBioPortal/cbioportal/pulls/1700"}}},"pull_request":{"url":"https://api.github.com/repos/cBioPortal/cbioportal/pulls/1700","id":86402986,"html_url":"https://github.com/cBioPortal/cbioportal/pull/1700","diff_url":"https://github.com/cBioPortal/cbioportal/pull/1700.diff","patch_url":"https://github.com/cBioPortal/cbioportal/pull/1700.patch","issue_url":"https://api.github.com/repos/cBioPortal/cbioportal/issues/1700","number":1700,"state":"open","locked":false,"title":"Small changes to gene panel implementation","user":{"login":"zheins","id":10240498,"avatar_url":"https://avatars.githubusercontent.com/u/10240498?v=3","gravatar_id":"","url":"https://api.github.com/users/zheins","html_url":"https://github.com/zheins","followers_url":"https://api.github.com/users/zheins/followers","following_url":"https://api.github.com/users/zheins/following{/other_user}","gists_url":"https://api.github.com/users/zheins/gists{/gist_id}","starred_url":"https://api.github.com/users/zheins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zheins/subscriptions","organizations_url":"https://api.github.com/users/zheins/orgs","repos_url":"https://api.github.com/users/zheins/repos","events_url":"https://api.github.com/users/zheins/events{/privacy}","received_events_url":"https://api.github.com/users/zheins/received_events","type":"User","site_admin":false},"body":"# What? Why?\r\nUse existing sample_profile table for gene panel mapping instead of making the new table. Add controller tests for gene panel.\r\n\r\n# Checks\r\n- [ ] Runs on Heroku.\r\n- [x] Follows [7 rules of great commit messages](http://chris.beams.io/posts/git-commit/). For most PRs a single commit should suffice, in some cases multiple topical commits can be useful. During review it is ok to see tiny commits (e.g. Fix reviewer comments), but right before the code gets merged to master or rc branch, any such commits should be squashed since they are useless to the other developers. Definitely avoid [merge commits, use rebase instead.](http://nathanleclaire.com/blog/2014/09/14/dont-be-scared-of-git-rebase/)\r\n- [x] Follows the [Google Style Guide](https://github.com/google/styleguide).\r\n- [x] Make sure your commit messages end with a Signed-off-by string (this line\r\n  can be automatically added by git if you run the `git-commit` command with\r\n  the `-s` option)\r\n- [x] If this is a feature, the PR is to rc. If this is a bug fix, the PR is to\r\n  hotfix.\r\n\r\n# Notify reviewers\r\n@fedde-s \r\n@sheridancbio \r\n\r\n","created_at":"2016-09-22T19:53:03Z","updated_at":"2016-09-22T21:34:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e64e6c28ed2256b69c8782aa07e63d5460866eab","assignee":{"login":"sheridancbio","id":7747489,"avatar_url":"https://avatars.githubusercontent.com/u/7747489?v=3","gravatar_id":"","url":"https://api.github.com/users/sheridancbio","html_url":"https://github.com/sheridancbio","followers_url":"https://api.github.com/users/sheridancbio/followers","following_url":"https://api.github.com/users/sheridancbio/following{/other_user}","gists_url":"https://api.github.com/users/sheridancbio/gists{/gist_id}","starred_url":"https://api.github.com/users/sheridancbio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sheridancbio/subscriptions","organizations_url":"https://api.github.com/users/sheridancbio/orgs","repos_url":"https://api.github.com/users/sheridancbio/repos","events_url":"https://api.github.com/users/sheridancbio/events{/privacy}","received_events_url":"https://api.github.com/users/sheridancbio/received_events","type":"User","site_admin":false},"assignees":[{"login":"sheridancbio","id":7747489,"avatar_url":"https://avatars.githubusercontent.com/u/7747489?v=3","gravatar_id":"","url":"https://api.github.com/users/sheridancbio","html_url":"https://github.com/sheridancbio","followers_url":"https://api.github.com/users/sheridancbio/followers","following_url":"https://api.github.com/users/sheridancbio/following{/other_user}","gists_url":"https://api.github.com/users/sheridancbio/gists{/gist_id}","starred_url":"https://api.github.com/users/sheridancbio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sheridancbio/subscriptions","organizations_url":"https://api.github.com/users/sheridancbio/orgs","repos_url":"https://api.github.com/users/sheridancbio/repos","events_url":"https://api.github.com/users/sheridancbio/events{/privacy}","received_events_url":"https://api.github.com/users/sheridancbio/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/cBioPortal/cbioportal/pulls/1700/commits","review_comments_url":"https://api.github.com/repos/cBioPortal/cbioportal/pulls/1700/comments","review_comment_url":"https://api.github.com/repos/cBioPortal/cbioportal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cBioPortal/cbioportal/issues/1700/comments","statuses_url":"https://api.github.com/repos/cBioPortal/cbioportal/statuses/098d55795b435caeeb9c240d6c883458ed8dcf80","head":{"label":"zheins:gp-update","ref":"gp-update","sha":"098d55795b435caeeb9c240d6c883458ed8dcf80","user":{"login":"zheins","id":10240498,"avatar_url":"https://avatars.githubusercontent.com/u/10240498?v=3","gravatar_id":"","url":"https://api.github.com/users/zheins","html_url":"https://github.com/zheins","followers_url":"https://api.github.com/users/zheins/followers","following_url":"https://api.github.com/users/zheins/following{/other_user}","gists_url":"https://api.github.com/users/zheins/gists{/gist_id}","starred_url":"https://api.github.com/users/zheins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zheins/subscriptions","organizations_url":"https://api.github.com/users/zheins/orgs","repos_url":"https://api.github.com/users/zheins/repos","events_url":"https://api.github.com/users/zheins/events{/privacy}","received_events_url":"https://api.github.com/users/zheins/received_events","type":"User","site_admin":false},"repo":{"id":43025720,"name":"cbioportal","full_name":"zheins/cbioportal","owner":{"login":"zheins","id":10240498,"avatar_url":"https://avatars.githubusercontent.com/u/10240498?v=3","gravatar_id":"","url":"https://api.github.com/users/zheins","html_url":"https://github.com/zheins","followers_url":"https://api.github.com/users/zheins/followers","following_url":"https://api.github.com/users/zheins/following{/other_user}","gists_url":"https://api.github.com/users/zheins/gists{/gist_id}","starred_url":"https://api.github.com/users/zheins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zheins/subscriptions","organizations_url":"https://api.github.com/users/zheins/orgs","repos_url":"https://api.github.com/users/zheins/repos","events_url":"https://api.github.com/users/zheins/events{/privacy}","received_events_url":"https://api.github.com/users/zheins/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zheins/cbioportal","description":"","fork":true,"url":"https://api.github.com/repos/zheins/cbioportal","forks_url":"https://api.github.com/repos/zheins/cbioportal/forks","keys_url":"https://api.github.com/repos/zheins/cbioportal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zheins/cbioportal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zheins/cbioportal/teams","hooks_url":"https://api.github.com/repos/zheins/cbioportal/hooks","issue_events_url":"https://api.github.com/repos/zheins/cbioportal/issues/events{/number}","events_url":"https://api.github.com/repos/zheins/cbioportal/events","assignees_url":"https://api.github.com/repos/zheins/cbioportal/assignees{/user}","branches_url":"https://api.github.com/repos/zheins/cbioportal/branches{/branch}","tags_url":"https://api.github.com/repos/zheins/cbioportal/tags","blobs_url":"https://api.github.com/repos/zheins/cbioportal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zheins/cbioportal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zheins/cbioportal/git/refs{/sha}","trees_url":"https://api.github.com/repos/zheins/cbioportal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zheins/cbioportal/statuses/{sha}","languages_url":"https://api.github.com/repos/zheins/cbioportal/languages","stargazers_url":"https://api.github.com/repos/zheins/cbioportal/stargazers","contributors_url":"https://api.github.com/repos/zheins/cbioportal/contributors","subscribers_url":"https://api.github.com/repos/zheins/cbioportal/subscribers","subscription_url":"https://api.github.com/repos/zheins/cbioportal/subscription","commits_url":"https://api.github.com/repos/zheins/cbioportal/commits{/sha}","git_commits_url":"https://api.github.com/repos/zheins/cbioportal/git/commits{/sha}","comments_url":"https://api.github.com/repos/zheins/cbioportal/comments{/number}","issue_comment_url":"https://api.github.com/repos/zheins/cbioportal/issues/comments{/number}","contents_url":"https://api.github.com/repos/zheins/cbioportal/contents/{+path}","compare_url":"https://api.github.com/repos/zheins/cbioportal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zheins/cbioportal/merges","archive_url":"https://api.github.com/repos/zheins/cbioportal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zheins/cbioportal/downloads","issues_url":"https://api.github.com/repos/zheins/cbioportal/issues{/number}","pulls_url":"https://api.github.com/repos/zheins/cbioportal/pulls{/number}","milestones_url":"https://api.github.com/repos/zheins/cbioportal/milestones{/number}","notifications_url":"https://api.github.com/repos/zheins/cbioportal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zheins/cbioportal/labels{/name}","releases_url":"https://api.github.com/repos/zheins/cbioportal/releases{/id}","deployments_url":"https://api.github.com/repos/zheins/cbioportal/deployments","created_at":"2015-09-23T20:43:29Z","updated_at":"2015-09-23T20:43:45Z","pushed_at":"2016-09-22T21:29:42Z","git_url":"git://github.com/zheins/cbioportal.git","ssh_url":"git@github.com:zheins/cbioportal.git","clone_url":"https://github.com/zheins/cbioportal.git","svn_url":"https://github.com/zheins/cbioportal","homepage":null,"size":173936,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cBioPortal:rc","ref":"rc","sha":"f2d1f5dfb952c4fefef4550e26c73f1a67da2fa0","user":{"login":"cBioPortal","id":9876251,"avatar_url":"https://avatars.githubusercontent.com/u/9876251?v=3","gravatar_id":"","url":"https://api.github.com/users/cBioPortal","html_url":"https://github.com/cBioPortal","followers_url":"https://api.github.com/users/cBioPortal/followers","following_url":"https://api.github.com/users/cBioPortal/following{/other_user}","gists_url":"https://api.github.com/users/cBioPortal/gists{/gist_id}","starred_url":"https://api.github.com/users/cBioPortal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cBioPortal/subscriptions","organizations_url":"https://api.github.com/users/cBioPortal/orgs","repos_url":"https://api.github.com/users/cBioPortal/repos","events_url":"https://api.github.com/users/cBioPortal/events{/privacy}","received_events_url":"https://api.github.com/users/cBioPortal/received_events","type":"Organization","site_admin":false},"repo":{"id":32481543,"name":"cbioportal","full_name":"cBioPortal/cbioportal","owner":{"login":"cBioPortal","id":9876251,"avatar_url":"https://avatars.githubusercontent.com/u/9876251?v=3","gravatar_id":"","url":"https://api.github.com/users/cBioPortal","html_url":"https://github.com/cBioPortal","followers_url":"https://api.github.com/users/cBioPortal/followers","following_url":"https://api.github.com/users/cBioPortal/following{/other_user}","gists_url":"https://api.github.com/users/cBioPortal/gists{/gist_id}","starred_url":"https://api.github.com/users/cBioPortal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cBioPortal/subscriptions","organizations_url":"https://api.github.com/users/cBioPortal/orgs","repos_url":"https://api.github.com/users/cBioPortal/repos","events_url":"https://api.github.com/users/cBioPortal/events{/privacy}","received_events_url":"https://api.github.com/users/cBioPortal/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cBioPortal/cbioportal","description":"cBioPortal for Cancer Genomics","fork":false,"url":"https://api.github.com/repos/cBioPortal/cbioportal","forks_url":"https://api.github.com/repos/cBioPortal/cbioportal/forks","keys_url":"https://api.github.com/repos/cBioPortal/cbioportal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cBioPortal/cbioportal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cBioPortal/cbioportal/teams","hooks_url":"https://api.github.com/repos/cBioPortal/cbioportal/hooks","issue_events_url":"https://api.github.com/repos/cBioPortal/cbioportal/issues/events{/number}","events_url":"https://api.github.com/repos/cBioPortal/cbioportal/events","assignees_url":"https://api.github.com/repos/cBioPortal/cbioportal/assignees{/user}","branches_url":"https://api.github.com/repos/cBioPortal/cbioportal/branches{/branch}","tags_url":"https://api.github.com/repos/cBioPortal/cbioportal/tags","blobs_url":"https://api.github.com/repos/cBioPortal/cbioportal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cBioPortal/cbioportal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cBioPortal/cbioportal/git/refs{/sha}","trees_url":"https://api.github.com/repos/cBioPortal/cbioportal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cBioPortal/cbioportal/statuses/{sha}","languages_url":"https://api.github.com/repos/cBioPortal/cbioportal/languages","stargazers_url":"https://api.github.com/repos/cBioPortal/cbioportal/stargazers","contributors_url":"https://api.github.com/repos/cBioPortal/cbioportal/contributors","subscribers_url":"https://api.github.com/repos/cBioPortal/cbioportal/subscribers","subscription_url":"https://api.github.com/repos/cBioPortal/cbioportal/subscription","commits_url":"https://api.github.com/repos/cBioPortal/cbioportal/commits{/sha}","git_commits_url":"https://api.github.com/repos/cBioPortal/cbioportal/git/commits{/sha}","comments_url":"https://api.github.com/repos/cBioPortal/cbioportal/comments{/number}","issue_comment_url":"https://api.github.com/repos/cBioPortal/cbioportal/issues/comments{/number}","contents_url":"https://api.github.com/repos/cBioPortal/cbioportal/contents/{+path}","compare_url":"https://api.github.com/repos/cBioPortal/cbioportal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cBioPortal/cbioportal/merges","archive_url":"https://api.github.com/repos/cBioPortal/cbioportal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cBioPortal/cbioportal/downloads","issues_url":"https://api.github.com/repos/cBioPortal/cbioportal/issues{/number}","pulls_url":"https://api.github.com/repos/cBioPortal/cbioportal/pulls{/number}","milestones_url":"https://api.github.com/repos/cBioPortal/cbioportal/milestones{/number}","notifications_url":"https://api.github.com/repos/cBioPortal/cbioportal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cBioPortal/cbioportal/labels{/name}","releases_url":"https://api.github.com/repos/cBioPortal/cbioportal/releases{/id}","deployments_url":"https://api.github.com/repos/cBioPortal/cbioportal/deployments","created_at":"2015-03-18T20:09:09Z","updated_at":"2016-09-22T09:32:47Z","pushed_at":"2016-09-22T21:30:40Z","git_url":"git://github.com/cBioPortal/cbioportal.git","ssh_url":"git@github.com:cBioPortal/cbioportal.git","clone_url":"https://github.com/cBioPortal/cbioportal.git","svn_url":"https://github.com/cBioPortal/cbioportal","homepage":"http://cbioportal.org","size":257764,"stargazers_count":77,"watchers_count":77,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":109,"mirror_url":null,"open_issues_count":305,"forks":109,"open_issues":305,"watchers":77,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cBioPortal/cbioportal/pulls/1700"},"html":{"href":"https://github.com/cBioPortal/cbioportal/pull/1700"},"issue":{"href":"https://api.github.com/repos/cBioPortal/cbioportal/issues/1700"},"comments":{"href":"https://api.github.com/repos/cBioPortal/cbioportal/issues/1700/comments"},"review_comments":{"href":"https://api.github.com/repos/cBioPortal/cbioportal/pulls/1700/comments"},"review_comment":{"href":"https://api.github.com/repos/cBioPortal/cbioportal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cBioPortal/cbioportal/pulls/1700/commits"},"statuses":{"href":"https://api.github.com/repos/cBioPortal/cbioportal/statuses/098d55795b435caeeb9c240d6c883458ed8dcf80"}}}}
{"actor":{"display_login":"sheridancbio"}}