{"action":"created","comment":{"url":"https://api.github.com/repos/amplab/tachyon/pulls/comments/48857843","id":48857843,"diff_hunk":"@@ -1783,62 +1795,66 @@ private void setStateFromEntry(SetStateEntry entry) throws FileDoesNotExistExcep\n   }\n \n   /**\n-   * Checks user's permission on a path.\n+   * Checks user's permission on a path. If the path is invalid, it should bypass the\n+   * {@link InvalidPathException} and the logic at operation will handle it.\n    *\n    * @param action requested {@link FileSystemAction} by user\n    * @param path the path to check permission on\n    * @param checkParent indicates whether to check its parent\n    * @throws AccessControlException if permission checking fails\n-   * @throws InvalidPathException if the path is invalid\n    */\n-  private void checkPermission(FileSystemAction action, TachyonURI path,\n-      boolean checkParent) throws AccessControlException, InvalidPathException {\n+  private void checkPermission(FileSystemAction action, TachyonURI path, boolean checkParent)\n+      throws AccessControlException {\n     // bypasses permission checking if security is not enabled.\n     if (!SecurityUtils.isSecurityEnabled(MasterContext.getConf())) {\n       return;\n     }\n \n-    // collects inodes info on the path\n-    List<Inode> inodes = mInodeTree.collectInodes(path);\n-    List<FileInfo> fileInfos = new ArrayList<FileInfo>();\n-    for (Inode inode : inodes) {\n-      fileInfos.add(inode.generateClientFileInfo(mInodeTree.getPath(inode).toString()));\n-    }\n+    try {\n+      // collects inodes info on the path\n+      List<Inode> inodes = mInodeTree.collectInodes(path);\n+      List<FileInfo> fileInfos = new ArrayList<FileInfo>();\n+      for (Inode inode : inodes) {\n+        fileInfos.add(inode.generateClientFileInfo(mInodeTree.getPath(inode).toString()));\n+      }\n \n-    String[] pathComponents = PathUtils.getPathComponents(path.getPath());\n-    if (pathComponents.length < fileInfos.size()) {\n-      throw new InvalidPathException(ExceptionMessage.PATH_INVALID.getMessage(path.getPath()));\n-    }\n+      String[] pathComponents = PathUtils.getPathComponents(path.getPath());\n+      if (pathComponents.length < fileInfos.size()) {\n+        throw new InvalidPathException(ExceptionMessage.PATH_INVALID.getMessage(path.getPath()));","path":"servers/src/main/java/tachyon/master/file/FileSystemMaster.java","position":165,"original_position":165,"commit_id":"7bd84e2a871ecb35dc08ae1f36319fa2457956bf","original_commit_id":"7bd84e2a871ecb35dc08ae1f36319fa2457956bf","user":{"login":"jsimsa","id":1072079,"avatar_url":"https://avatars.githubusercontent.com/u/1072079?v=3","gravatar_id":"","url":"https://api.github.com/users/jsimsa","html_url":"https://github.com/jsimsa","followers_url":"https://api.github.com/users/jsimsa/followers","following_url":"https://api.github.com/users/jsimsa/following{/other_user}","gists_url":"https://api.github.com/users/jsimsa/gists{/gist_id}","starred_url":"https://api.github.com/users/jsimsa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsimsa/subscriptions","organizations_url":"https://api.github.com/users/jsimsa/orgs","repos_url":"https://api.github.com/users/jsimsa/repos","events_url":"https://api.github.com/users/jsimsa/events{/privacy}","received_events_url":"https://api.github.com/users/jsimsa/received_events","type":"User","site_admin":false},"body":"can any other part of the try block throw the InvalidPathException? if not, remove the try block and just log the warning here and return","created_at":"2016-01-05T15:44:14Z","updated_at":"2016-01-05T15:44:14Z","html_url":"https://github.com/amplab/tachyon/pull/2392#discussion_r48857843","pull_request_url":"https://api.github.com/repos/amplab/tachyon/pulls/2392","_links":{"self":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/comments/48857843"},"html":{"href":"https://github.com/amplab/tachyon/pull/2392#discussion_r48857843"},"pull_request":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/2392"}}},"pull_request":{"url":"https://api.github.com/repos/amplab/tachyon/pulls/2392","id":55050477,"html_url":"https://github.com/amplab/tachyon/pull/2392","diff_url":"https://github.com/amplab/tachyon/pull/2392.diff","patch_url":"https://github.com/amplab/tachyon/pull/2392.patch","issue_url":"https://api.github.com/repos/amplab/tachyon/issues/2392","number":2392,"state":"open","locked":false,"title":"[TACHYON-1420] Check - Check Tachyon specfic operations in Master side","user":{"login":"sundapeng","id":3818001,"avatar_url":"https://avatars.githubusercontent.com/u/3818001?v=3","gravatar_id":"","url":"https://api.github.com/users/sundapeng","html_url":"https://github.com/sundapeng","followers_url":"https://api.github.com/users/sundapeng/followers","following_url":"https://api.github.com/users/sundapeng/following{/other_user}","gists_url":"https://api.github.com/users/sundapeng/gists{/gist_id}","starred_url":"https://api.github.com/users/sundapeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sundapeng/subscriptions","organizations_url":"https://api.github.com/users/sundapeng/orgs","repos_url":"https://api.github.com/users/sundapeng/repos","events_url":"https://api.github.com/users/sundapeng/events{/privacy}","received_events_url":"https://api.github.com/users/sundapeng/received_events","type":"User","site_admin":false},"body":"https://tachyon.atlassian.net/browse/TACHYON-1420\r\n\r\nThis pull request is adding permission check for setState, completeFile, free, loadMetadata, mount, unmount.\r\n\r\n@apc999 , @jsimsa , @yupeng9, @dongche ","created_at":"2016-01-05T03:14:31Z","updated_at":"2016-01-05T15:44:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6b9629361a9c644bf62e2909471170e6e8160021","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/amplab/tachyon/pulls/2392/commits","review_comments_url":"https://api.github.com/repos/amplab/tachyon/pulls/2392/comments","review_comment_url":"https://api.github.com/repos/amplab/tachyon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/amplab/tachyon/issues/2392/comments","statuses_url":"https://api.github.com/repos/amplab/tachyon/statuses/7bd84e2a871ecb35dc08ae1f36319fa2457956bf","head":{"label":"sundapeng:TACHYON-1420","ref":"TACHYON-1420","sha":"7bd84e2a871ecb35dc08ae1f36319fa2457956bf","user":{"login":"sundapeng","id":3818001,"avatar_url":"https://avatars.githubusercontent.com/u/3818001?v=3","gravatar_id":"","url":"https://api.github.com/users/sundapeng","html_url":"https://github.com/sundapeng","followers_url":"https://api.github.com/users/sundapeng/followers","following_url":"https://api.github.com/users/sundapeng/following{/other_user}","gists_url":"https://api.github.com/users/sundapeng/gists{/gist_id}","starred_url":"https://api.github.com/users/sundapeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sundapeng/subscriptions","organizations_url":"https://api.github.com/users/sundapeng/orgs","repos_url":"https://api.github.com/users/sundapeng/repos","events_url":"https://api.github.com/users/sundapeng/events{/privacy}","received_events_url":"https://api.github.com/users/sundapeng/received_events","type":"User","site_admin":false},"repo":{"id":39428718,"name":"tachyon","full_name":"sundapeng/tachyon","owner":{"login":"sundapeng","id":3818001,"avatar_url":"https://avatars.githubusercontent.com/u/3818001?v=3","gravatar_id":"","url":"https://api.github.com/users/sundapeng","html_url":"https://github.com/sundapeng","followers_url":"https://api.github.com/users/sundapeng/followers","following_url":"https://api.github.com/users/sundapeng/following{/other_user}","gists_url":"https://api.github.com/users/sundapeng/gists{/gist_id}","starred_url":"https://api.github.com/users/sundapeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sundapeng/subscriptions","organizations_url":"https://api.github.com/users/sundapeng/orgs","repos_url":"https://api.github.com/users/sundapeng/repos","events_url":"https://api.github.com/users/sundapeng/events{/privacy}","received_events_url":"https://api.github.com/users/sundapeng/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sundapeng/tachyon","description":" A Reliable Memory Centric Distributed Storage System","fork":true,"url":"https://api.github.com/repos/sundapeng/tachyon","forks_url":"https://api.github.com/repos/sundapeng/tachyon/forks","keys_url":"https://api.github.com/repos/sundapeng/tachyon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sundapeng/tachyon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sundapeng/tachyon/teams","hooks_url":"https://api.github.com/repos/sundapeng/tachyon/hooks","issue_events_url":"https://api.github.com/repos/sundapeng/tachyon/issues/events{/number}","events_url":"https://api.github.com/repos/sundapeng/tachyon/events","assignees_url":"https://api.github.com/repos/sundapeng/tachyon/assignees{/user}","branches_url":"https://api.github.com/repos/sundapeng/tachyon/branches{/branch}","tags_url":"https://api.github.com/repos/sundapeng/tachyon/tags","blobs_url":"https://api.github.com/repos/sundapeng/tachyon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sundapeng/tachyon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sundapeng/tachyon/git/refs{/sha}","trees_url":"https://api.github.com/repos/sundapeng/tachyon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sundapeng/tachyon/statuses/{sha}","languages_url":"https://api.github.com/repos/sundapeng/tachyon/languages","stargazers_url":"https://api.github.com/repos/sundapeng/tachyon/stargazers","contributors_url":"https://api.github.com/repos/sundapeng/tachyon/contributors","subscribers_url":"https://api.github.com/repos/sundapeng/tachyon/subscribers","subscription_url":"https://api.github.com/repos/sundapeng/tachyon/subscription","commits_url":"https://api.github.com/repos/sundapeng/tachyon/commits{/sha}","git_commits_url":"https://api.github.com/repos/sundapeng/tachyon/git/commits{/sha}","comments_url":"https://api.github.com/repos/sundapeng/tachyon/comments{/number}","issue_comment_url":"https://api.github.com/repos/sundapeng/tachyon/issues/comments{/number}","contents_url":"https://api.github.com/repos/sundapeng/tachyon/contents/{+path}","compare_url":"https://api.github.com/repos/sundapeng/tachyon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sundapeng/tachyon/merges","archive_url":"https://api.github.com/repos/sundapeng/tachyon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sundapeng/tachyon/downloads","issues_url":"https://api.github.com/repos/sundapeng/tachyon/issues{/number}","pulls_url":"https://api.github.com/repos/sundapeng/tachyon/pulls{/number}","milestones_url":"https://api.github.com/repos/sundapeng/tachyon/milestones{/number}","notifications_url":"https://api.github.com/repos/sundapeng/tachyon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sundapeng/tachyon/labels{/name}","releases_url":"https://api.github.com/repos/sundapeng/tachyon/releases{/id}","created_at":"2015-07-21T06:40:32Z","updated_at":"2015-07-21T06:40:34Z","pushed_at":"2016-01-05T03:09:56Z","git_url":"git://github.com/sundapeng/tachyon.git","ssh_url":"git@github.com:sundapeng/tachyon.git","clone_url":"https://github.com/sundapeng/tachyon.git","svn_url":"https://github.com/sundapeng/tachyon","homepage":"http://tachyon-project.org","size":33936,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"amplab:authorization","ref":"authorization","sha":"2c23111c6bf5bb3507cafec7ab8f10eabb72d8d1","user":{"login":"amplab","id":1438454,"avatar_url":"https://avatars.githubusercontent.com/u/1438454?v=3","gravatar_id":"","url":"https://api.github.com/users/amplab","html_url":"https://github.com/amplab","followers_url":"https://api.github.com/users/amplab/followers","following_url":"https://api.github.com/users/amplab/following{/other_user}","gists_url":"https://api.github.com/users/amplab/gists{/gist_id}","starred_url":"https://api.github.com/users/amplab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amplab/subscriptions","organizations_url":"https://api.github.com/users/amplab/orgs","repos_url":"https://api.github.com/users/amplab/repos","events_url":"https://api.github.com/users/amplab/events{/privacy}","received_events_url":"https://api.github.com/users/amplab/received_events","type":"Organization","site_admin":false},"repo":{"id":7276954,"name":"tachyon","full_name":"amplab/tachyon","owner":{"login":"amplab","id":1438454,"avatar_url":"https://avatars.githubusercontent.com/u/1438454?v=3","gravatar_id":"","url":"https://api.github.com/users/amplab","html_url":"https://github.com/amplab","followers_url":"https://api.github.com/users/amplab/followers","following_url":"https://api.github.com/users/amplab/following{/other_user}","gists_url":"https://api.github.com/users/amplab/gists{/gist_id}","starred_url":"https://api.github.com/users/amplab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amplab/subscriptions","organizations_url":"https://api.github.com/users/amplab/orgs","repos_url":"https://api.github.com/users/amplab/repos","events_url":"https://api.github.com/users/amplab/events{/privacy}","received_events_url":"https://api.github.com/users/amplab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/amplab/tachyon","description":"Memory Centric Reliable Distributed Storage","fork":false,"url":"https://api.github.com/repos/amplab/tachyon","forks_url":"https://api.github.com/repos/amplab/tachyon/forks","keys_url":"https://api.github.com/repos/amplab/tachyon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/amplab/tachyon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/amplab/tachyon/teams","hooks_url":"https://api.github.com/repos/amplab/tachyon/hooks","issue_events_url":"https://api.github.com/repos/amplab/tachyon/issues/events{/number}","events_url":"https://api.github.com/repos/amplab/tachyon/events","assignees_url":"https://api.github.com/repos/amplab/tachyon/assignees{/user}","branches_url":"https://api.github.com/repos/amplab/tachyon/branches{/branch}","tags_url":"https://api.github.com/repos/amplab/tachyon/tags","blobs_url":"https://api.github.com/repos/amplab/tachyon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/amplab/tachyon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/amplab/tachyon/git/refs{/sha}","trees_url":"https://api.github.com/repos/amplab/tachyon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/amplab/tachyon/statuses/{sha}","languages_url":"https://api.github.com/repos/amplab/tachyon/languages","stargazers_url":"https://api.github.com/repos/amplab/tachyon/stargazers","contributors_url":"https://api.github.com/repos/amplab/tachyon/contributors","subscribers_url":"https://api.github.com/repos/amplab/tachyon/subscribers","subscription_url":"https://api.github.com/repos/amplab/tachyon/subscription","commits_url":"https://api.github.com/repos/amplab/tachyon/commits{/sha}","git_commits_url":"https://api.github.com/repos/amplab/tachyon/git/commits{/sha}","comments_url":"https://api.github.com/repos/amplab/tachyon/comments{/number}","issue_comment_url":"https://api.github.com/repos/amplab/tachyon/issues/comments{/number}","contents_url":"https://api.github.com/repos/amplab/tachyon/contents/{+path}","compare_url":"https://api.github.com/repos/amplab/tachyon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/amplab/tachyon/merges","archive_url":"https://api.github.com/repos/amplab/tachyon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/amplab/tachyon/downloads","issues_url":"https://api.github.com/repos/amplab/tachyon/issues{/number}","pulls_url":"https://api.github.com/repos/amplab/tachyon/pulls{/number}","milestones_url":"https://api.github.com/repos/amplab/tachyon/milestones{/number}","notifications_url":"https://api.github.com/repos/amplab/tachyon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/amplab/tachyon/labels{/name}","releases_url":"https://api.github.com/repos/amplab/tachyon/releases{/id}","created_at":"2012-12-21T17:43:46Z","updated_at":"2016-01-05T12:33:12Z","pushed_at":"2016-01-05T15:13:28Z","git_url":"git://github.com/amplab/tachyon.git","ssh_url":"git@github.com:amplab/tachyon.git","clone_url":"https://github.com/amplab/tachyon.git","svn_url":"https://github.com/amplab/tachyon","homepage":"http://tachyon-project.org","size":42994,"stargazers_count":1850,"watchers_count":1850,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":732,"mirror_url":null,"open_issues_count":32,"forks":732,"open_issues":32,"watchers":1850,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/2392"},"html":{"href":"https://github.com/amplab/tachyon/pull/2392"},"issue":{"href":"https://api.github.com/repos/amplab/tachyon/issues/2392"},"comments":{"href":"https://api.github.com/repos/amplab/tachyon/issues/2392/comments"},"review_comments":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/2392/comments"},"review_comment":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/2392/commits"},"statuses":{"href":"https://api.github.com/repos/amplab/tachyon/statuses/7bd84e2a871ecb35dc08ae1f36319fa2457956bf"}}}}