{"action":"created","issue":{"url":"https://api.github.com/repos/b2evolution/b2evolution/issues/32","repository_url":"https://api.github.com/repos/b2evolution/b2evolution","labels_url":"https://api.github.com/repos/b2evolution/b2evolution/issues/32/labels{/name}","comments_url":"https://api.github.com/repos/b2evolution/b2evolution/issues/32/comments","events_url":"https://api.github.com/repos/b2evolution/b2evolution/issues/32/events","html_url":"https://github.com/b2evolution/b2evolution/issues/32","id":175135283,"number":32,"title":"Plugin class uses pass-by-reference signatures","user":{"login":"blueyed","id":9766,"avatar_url":"https://avatars.githubusercontent.com/u/9766?v=3","gravatar_id":"","url":"https://api.github.com/users/blueyed","html_url":"https://github.com/blueyed","followers_url":"https://api.github.com/users/blueyed/followers","following_url":"https://api.github.com/users/blueyed/following{/other_user}","gists_url":"https://api.github.com/users/blueyed/gists{/gist_id}","starred_url":"https://api.github.com/users/blueyed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blueyed/subscriptions","organizations_url":"https://api.github.com/users/blueyed/orgs","repos_url":"https://api.github.com/users/blueyed/repos","events_url":"https://api.github.com/users/blueyed/events{/privacy}","received_events_url":"https://api.github.com/users/blueyed/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/b2evolution/b2evolution/labels/question","name":"question","color":"cc317c"}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-09-05T23:08:53Z","updated_at":"2016-09-06T10:01:43Z","closed_at":"2016-09-06T10:01:43Z","body":"I have been notified that one of my old plugin throws E_STRICT errors by now:\r\n\r\n> Strict Standards: Declaration of captcha_img_plugin::GetDefaultSettings() should be compatible with Plugin::GetDefaultSettings(&$params) in …\r\n\r\nBut adhering to this does not work, since then you get a fatal error:\r\n\r\n> Fatal error: Call-time pass-by-reference has been removed\r\n\r\nSo while you apparently tend to not enable strict errors, some users do.\r\n\r\nI think the fix would be to adjust the function declaration in the `Plugin` base class."},"comment":{"url":"https://api.github.com/repos/b2evolution/b2evolution/issues/comments/244905708","html_url":"https://github.com/b2evolution/b2evolution/issues/32#issuecomment-244905708","issue_url":"https://api.github.com/repos/b2evolution/b2evolution/issues/32","id":244905708,"user":{"login":"blueyed","id":9766,"avatar_url":"https://avatars.githubusercontent.com/u/9766?v=3","gravatar_id":"","url":"https://api.github.com/users/blueyed","html_url":"https://github.com/blueyed","followers_url":"https://api.github.com/users/blueyed/followers","following_url":"https://api.github.com/users/blueyed/following{/other_user}","gists_url":"https://api.github.com/users/blueyed/gists{/gist_id}","starred_url":"https://api.github.com/users/blueyed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blueyed/subscriptions","organizations_url":"https://api.github.com/users/blueyed/orgs","repos_url":"https://api.github.com/users/blueyed/repos","events_url":"https://api.github.com/users/blueyed/events{/privacy}","received_events_url":"https://api.github.com/users/blueyed/received_events","type":"User","site_admin":false},"created_at":"2016-09-06T10:01:43Z","updated_at":"2016-09-06T10:01:43Z","body":"I am not getting it, but a user that changed the deriving plugin's function definition to e.g. `GetDefaultSettings(&params)` (IIRC, the important part is also using the \"&params\" here, like in the Plugin class, which triggers the strict warning).\r\n\r\nBut then this should also happen with e.g. https://github.com/b2evolution/b2evolution/blob/master/plugins/cookie_consent_plugin/_cookie_consent.plugin.php#L50.\r\n\r\nSo probably he did not modify the plugin correctly, and I confused pass-by-reference with pass-by-value.\r\nThe plugin is https://sourceforge.net/p/evocms-plugins/code/HEAD/tree/captcha_img_plugin/trunk/_captcha_img.plugin.php btw.\r\n\r\nClosing for now.  Sorry for the noise.\r\n\r\nApparently the plugin "}}
{"actor":{"display_login":"blueyed"}}