{"action":"created","comment":{"url":"https://api.github.com/repos/vmware/vic/pulls/comments/74103044","id":74103044,"diff_hunk":"@@ -63,16 +65,22 @@ type ImageStore struct {\n \tparents *parentM\n }\n \n-func NewImageStore(ctx context.Context, s *session.Session) (*ImageStore, error) {\n+func NewImageStore(ctx context.Context, s *session.Session, u *url.URL) (*ImageStore, error) {\n \tdm, err := disk.NewDiskManager(ctx, s)\n \tif err != nil {\n \t\treturn nil, err\n \t}\n \n-\t// Currently using the datastore associated with the session which is not\n-\t// ideal.  This should be passed in via the config.  The datastore need not\n-\t// be the same datastore used for the rest of the system.\n-\tds, err := datastore.NewHelper(ctx, s, s.Datastore, StorageParentDir)\n+\tdatastores, err := s.Finder.DatastoreList(ctx, u.Host)\n+\tif err != nil {\n+\t\t// TODO: real error beyond whatever DatastoreList returns","path":"lib/portlayer/storage/vsphere/image.go","position":33,"original_position":33,"commit_id":"14745435b2a97c901dd843602841c3ba4ec72c0e","original_commit_id":"229693b5020b1313b864b43b49d4b38db0ea7b57","user":{"login":"fdawg4l","id":4296242,"avatar_url":"https://avatars.githubusercontent.com/u/4296242?v=3","gravatar_id":"","url":"https://api.github.com/users/fdawg4l","html_url":"https://github.com/fdawg4l","followers_url":"https://api.github.com/users/fdawg4l/followers","following_url":"https://api.github.com/users/fdawg4l/following{/other_user}","gists_url":"https://api.github.com/users/fdawg4l/gists{/gist_id}","starred_url":"https://api.github.com/users/fdawg4l/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fdawg4l/subscriptions","organizations_url":"https://api.github.com/users/fdawg4l/orgs","repos_url":"https://api.github.com/users/fdawg4l/repos","events_url":"https://api.github.com/users/fdawg4l/events{/privacy}","received_events_url":"https://api.github.com/users/fdawg4l/received_events","type":"User","site_admin":false},"body":"What's to spot?  If error, return error.  Seems fine, no?","created_at":"2016-08-09T17:20:09Z","updated_at":"2016-08-09T17:20:09Z","html_url":"https://github.com/vmware/vic/pull/1678#discussion_r74103044","pull_request_url":"https://api.github.com/repos/vmware/vic/pulls/1678","_links":{"self":{"href":"https://api.github.com/repos/vmware/vic/pulls/comments/74103044"},"html":{"href":"https://github.com/vmware/vic/pull/1678#discussion_r74103044"},"pull_request":{"href":"https://api.github.com/repos/vmware/vic/pulls/1678"}}},"pull_request":{"url":"https://api.github.com/repos/vmware/vic/pulls/1678","id":78910176,"html_url":"https://github.com/vmware/vic/pull/1678","diff_url":"https://github.com/vmware/vic/pull/1678.diff","patch_url":"https://github.com/vmware/vic/pull/1678.patch","issue_url":"https://api.github.com/repos/vmware/vic/issues/1678","number":1678,"state":"open","locked":false,"title":"Allow custom image store paths","user":{"login":"gigawhitlocks","id":3743903,"avatar_url":"https://avatars.githubusercontent.com/u/3743903?v=3","gravatar_id":"","url":"https://api.github.com/users/gigawhitlocks","html_url":"https://github.com/gigawhitlocks","followers_url":"https://api.github.com/users/gigawhitlocks/followers","following_url":"https://api.github.com/users/gigawhitlocks/following{/other_user}","gists_url":"https://api.github.com/users/gigawhitlocks/gists{/gist_id}","starred_url":"https://api.github.com/users/gigawhitlocks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gigawhitlocks/subscriptions","organizations_url":"https://api.github.com/users/gigawhitlocks/orgs","repos_url":"https://api.github.com/users/gigawhitlocks/repos","events_url":"https://api.github.com/users/gigawhitlocks/events{/privacy}","received_events_url":"https://api.github.com/users/gigawhitlocks/received_events","type":"User","site_admin":false},"body":"Creating a new PR because this one is more expansive. Previous reviewers ( @hmahmood @emlin @fdawg4l ) may wish to take another gander.\r\n\r\nThis modifies the portlayer as well as vic-machine to allow custom image store locations. If one is not provided, a directory called images/ inside of the normal vch storage directory (where the ISOs go) is used\r\n\r\nDuring delete, only the final directory in the path is removed -- during create, the path is created if it does not exist.\r\n\r\nComments more than welcome. Emma I expect you specifically to have some input about some functions / variables I've renamed.\r\n\r\nAddresses the last of the functionality described in #1210 ","created_at":"2016-07-26T19:25:57Z","updated_at":"2016-08-09T17:20:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fec25aca97ce59a1405ec3fe6a569b5219035a42","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/vmware/vic/pulls/1678/commits","review_comments_url":"https://api.github.com/repos/vmware/vic/pulls/1678/comments","review_comment_url":"https://api.github.com/repos/vmware/vic/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vmware/vic/issues/1678/comments","statuses_url":"https://api.github.com/repos/vmware/vic/statuses/14745435b2a97c901dd843602841c3ba4ec72c0e","head":{"label":"gigawhitlocks:imagestore-directory","ref":"imagestore-directory","sha":"14745435b2a97c901dd843602841c3ba4ec72c0e","user":{"login":"gigawhitlocks","id":3743903,"avatar_url":"https://avatars.githubusercontent.com/u/3743903?v=3","gravatar_id":"","url":"https://api.github.com/users/gigawhitlocks","html_url":"https://github.com/gigawhitlocks","followers_url":"https://api.github.com/users/gigawhitlocks/followers","following_url":"https://api.github.com/users/gigawhitlocks/following{/other_user}","gists_url":"https://api.github.com/users/gigawhitlocks/gists{/gist_id}","starred_url":"https://api.github.com/users/gigawhitlocks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gigawhitlocks/subscriptions","organizations_url":"https://api.github.com/users/gigawhitlocks/orgs","repos_url":"https://api.github.com/users/gigawhitlocks/repos","events_url":"https://api.github.com/users/gigawhitlocks/events{/privacy}","received_events_url":"https://api.github.com/users/gigawhitlocks/received_events","type":"User","site_admin":false},"repo":{"id":55534993,"name":"vic","full_name":"gigawhitlocks/vic","owner":{"login":"gigawhitlocks","id":3743903,"avatar_url":"https://avatars.githubusercontent.com/u/3743903?v=3","gravatar_id":"","url":"https://api.github.com/users/gigawhitlocks","html_url":"https://github.com/gigawhitlocks","followers_url":"https://api.github.com/users/gigawhitlocks/followers","following_url":"https://api.github.com/users/gigawhitlocks/following{/other_user}","gists_url":"https://api.github.com/users/gigawhitlocks/gists{/gist_id}","starred_url":"https://api.github.com/users/gigawhitlocks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gigawhitlocks/subscriptions","organizations_url":"https://api.github.com/users/gigawhitlocks/orgs","repos_url":"https://api.github.com/users/gigawhitlocks/repos","events_url":"https://api.github.com/users/gigawhitlocks/events{/privacy}","received_events_url":"https://api.github.com/users/gigawhitlocks/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gigawhitlocks/vic","description":"Integrated containers on vSphere","fork":true,"url":"https://api.github.com/repos/gigawhitlocks/vic","forks_url":"https://api.github.com/repos/gigawhitlocks/vic/forks","keys_url":"https://api.github.com/repos/gigawhitlocks/vic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gigawhitlocks/vic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gigawhitlocks/vic/teams","hooks_url":"https://api.github.com/repos/gigawhitlocks/vic/hooks","issue_events_url":"https://api.github.com/repos/gigawhitlocks/vic/issues/events{/number}","events_url":"https://api.github.com/repos/gigawhitlocks/vic/events","assignees_url":"https://api.github.com/repos/gigawhitlocks/vic/assignees{/user}","branches_url":"https://api.github.com/repos/gigawhitlocks/vic/branches{/branch}","tags_url":"https://api.github.com/repos/gigawhitlocks/vic/tags","blobs_url":"https://api.github.com/repos/gigawhitlocks/vic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gigawhitlocks/vic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gigawhitlocks/vic/git/refs{/sha}","trees_url":"https://api.github.com/repos/gigawhitlocks/vic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gigawhitlocks/vic/statuses/{sha}","languages_url":"https://api.github.com/repos/gigawhitlocks/vic/languages","stargazers_url":"https://api.github.com/repos/gigawhitlocks/vic/stargazers","contributors_url":"https://api.github.com/repos/gigawhitlocks/vic/contributors","subscribers_url":"https://api.github.com/repos/gigawhitlocks/vic/subscribers","subscription_url":"https://api.github.com/repos/gigawhitlocks/vic/subscription","commits_url":"https://api.github.com/repos/gigawhitlocks/vic/commits{/sha}","git_commits_url":"https://api.github.com/repos/gigawhitlocks/vic/git/commits{/sha}","comments_url":"https://api.github.com/repos/gigawhitlocks/vic/comments{/number}","issue_comment_url":"https://api.github.com/repos/gigawhitlocks/vic/issues/comments{/number}","contents_url":"https://api.github.com/repos/gigawhitlocks/vic/contents/{+path}","compare_url":"https://api.github.com/repos/gigawhitlocks/vic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gigawhitlocks/vic/merges","archive_url":"https://api.github.com/repos/gigawhitlocks/vic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gigawhitlocks/vic/downloads","issues_url":"https://api.github.com/repos/gigawhitlocks/vic/issues{/number}","pulls_url":"https://api.github.com/repos/gigawhitlocks/vic/pulls{/number}","milestones_url":"https://api.github.com/repos/gigawhitlocks/vic/milestones{/number}","notifications_url":"https://api.github.com/repos/gigawhitlocks/vic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gigawhitlocks/vic/labels{/name}","releases_url":"https://api.github.com/repos/gigawhitlocks/vic/releases{/id}","deployments_url":"https://api.github.com/repos/gigawhitlocks/vic/deployments","created_at":"2016-04-05T18:57:06Z","updated_at":"2016-04-05T18:57:13Z","pushed_at":"2016-08-09T17:11:30Z","git_url":"git://github.com/gigawhitlocks/vic.git","ssh_url":"git@github.com:gigawhitlocks/vic.git","clone_url":"https://github.com/gigawhitlocks/vic.git","svn_url":"https://github.com/gigawhitlocks/vic","homepage":null,"size":33307,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"vmware:master","ref":"master","sha":"6b716a9931b30bbe6b3b7a945ad76db53285b7a1","user":{"login":"vmware","id":473334,"avatar_url":"https://avatars.githubusercontent.com/u/473334?v=3","gravatar_id":"","url":"https://api.github.com/users/vmware","html_url":"https://github.com/vmware","followers_url":"https://api.github.com/users/vmware/followers","following_url":"https://api.github.com/users/vmware/following{/other_user}","gists_url":"https://api.github.com/users/vmware/gists{/gist_id}","starred_url":"https://api.github.com/users/vmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmware/subscriptions","organizations_url":"https://api.github.com/users/vmware/orgs","repos_url":"https://api.github.com/users/vmware/repos","events_url":"https://api.github.com/users/vmware/events{/privacy}","received_events_url":"https://api.github.com/users/vmware/received_events","type":"Organization","site_admin":false},"repo":{"id":49597898,"name":"vic","full_name":"vmware/vic","owner":{"login":"vmware","id":473334,"avatar_url":"https://avatars.githubusercontent.com/u/473334?v=3","gravatar_id":"","url":"https://api.github.com/users/vmware","html_url":"https://github.com/vmware","followers_url":"https://api.github.com/users/vmware/followers","following_url":"https://api.github.com/users/vmware/following{/other_user}","gists_url":"https://api.github.com/users/vmware/gists{/gist_id}","starred_url":"https://api.github.com/users/vmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmware/subscriptions","organizations_url":"https://api.github.com/users/vmware/orgs","repos_url":"https://api.github.com/users/vmware/repos","events_url":"https://api.github.com/users/vmware/events{/privacy}","received_events_url":"https://api.github.com/users/vmware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vmware/vic","description":"Integrated containers on vSphere","fork":false,"url":"https://api.github.com/repos/vmware/vic","forks_url":"https://api.github.com/repos/vmware/vic/forks","keys_url":"https://api.github.com/repos/vmware/vic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vmware/vic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vmware/vic/teams","hooks_url":"https://api.github.com/repos/vmware/vic/hooks","issue_events_url":"https://api.github.com/repos/vmware/vic/issues/events{/number}","events_url":"https://api.github.com/repos/vmware/vic/events","assignees_url":"https://api.github.com/repos/vmware/vic/assignees{/user}","branches_url":"https://api.github.com/repos/vmware/vic/branches{/branch}","tags_url":"https://api.github.com/repos/vmware/vic/tags","blobs_url":"https://api.github.com/repos/vmware/vic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vmware/vic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vmware/vic/git/refs{/sha}","trees_url":"https://api.github.com/repos/vmware/vic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vmware/vic/statuses/{sha}","languages_url":"https://api.github.com/repos/vmware/vic/languages","stargazers_url":"https://api.github.com/repos/vmware/vic/stargazers","contributors_url":"https://api.github.com/repos/vmware/vic/contributors","subscribers_url":"https://api.github.com/repos/vmware/vic/subscribers","subscription_url":"https://api.github.com/repos/vmware/vic/subscription","commits_url":"https://api.github.com/repos/vmware/vic/commits{/sha}","git_commits_url":"https://api.github.com/repos/vmware/vic/git/commits{/sha}","comments_url":"https://api.github.com/repos/vmware/vic/comments{/number}","issue_comment_url":"https://api.github.com/repos/vmware/vic/issues/comments{/number}","contents_url":"https://api.github.com/repos/vmware/vic/contents/{+path}","compare_url":"https://api.github.com/repos/vmware/vic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vmware/vic/merges","archive_url":"https://api.github.com/repos/vmware/vic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vmware/vic/downloads","issues_url":"https://api.github.com/repos/vmware/vic/issues{/number}","pulls_url":"https://api.github.com/repos/vmware/vic/pulls{/number}","milestones_url":"https://api.github.com/repos/vmware/vic/milestones{/number}","notifications_url":"https://api.github.com/repos/vmware/vic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vmware/vic/labels{/name}","releases_url":"https://api.github.com/repos/vmware/vic/releases{/id}","deployments_url":"https://api.github.com/repos/vmware/vic/deployments","created_at":"2016-01-13T19:53:57Z","updated_at":"2016-08-05T22:38:36Z","pushed_at":"2016-08-09T17:11:30Z","git_url":"git://github.com/vmware/vic.git","ssh_url":"git@github.com:vmware/vic.git","clone_url":"https://github.com/vmware/vic.git","svn_url":"https://github.com/vmware/vic","homepage":null,"size":74900,"stargazers_count":109,"watchers_count":109,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":39,"mirror_url":null,"open_issues_count":485,"forks":39,"open_issues":485,"watchers":109,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vmware/vic/pulls/1678"},"html":{"href":"https://github.com/vmware/vic/pull/1678"},"issue":{"href":"https://api.github.com/repos/vmware/vic/issues/1678"},"comments":{"href":"https://api.github.com/repos/vmware/vic/issues/1678/comments"},"review_comments":{"href":"https://api.github.com/repos/vmware/vic/pulls/1678/comments"},"review_comment":{"href":"https://api.github.com/repos/vmware/vic/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vmware/vic/pulls/1678/commits"},"statuses":{"href":"https://api.github.com/repos/vmware/vic/statuses/14745435b2a97c901dd843602841c3ba4ec72c0e"}}}}
{"actor":{"display_login":"fdawg4l"}}