{"action":"closed","number":19277,"pull_request":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/19277","id":93495347,"html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/19277","diff_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/19277.diff","patch_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/19277.patch","issue_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/19277","number":19277,"state":"closed","locked":false,"title":"Visual Studio 2015 compile warning/error workarounds","user":{"login":"figment","id":1208954,"avatar_url":"https://avatars.githubusercontent.com/u/1208954?v=3","gravatar_id":"","url":"https://api.github.com/users/figment","html_url":"https://github.com/figment","followers_url":"https://api.github.com/users/figment/followers","following_url":"https://api.github.com/users/figment/following{/other_user}","gists_url":"https://api.github.com/users/figment/gists{/gist_id}","starred_url":"https://api.github.com/users/figment/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/figment/subscriptions","organizations_url":"https://api.github.com/users/figment/orgs","repos_url":"https://api.github.com/users/figment/repos","events_url":"https://api.github.com/users/figment/events{/privacy}","received_events_url":"https://api.github.com/users/figment/received_events","type":"User","site_admin":false},"body":"This is the list of Visual Studio 2015 changes I made to get CDDA to compile with fewer warnings and errors.  Several are warnings that might compile like double to float casts or use bad operators like + on booleans.\r\n\r\nMajor issues were the read file function casting with bind not automatically sorting out which version of the override to use.   I removed some Dynamic Array work since that seems to have changed recently so that dynamically sized stack allocated arrays are not used any more.  Though I worry about my_MAPSIZE vs MAPSIZE potential differences which could in theory lead to buffer overflows.\r\n\r\nI changes some include locations related to SDL2 because the source libraries do not actually use that folder convention so I don't believe this project should require moving files around just so that SDL2 is prefixed.\r\n\r\nMy headers/binaries used for WinDepends folder can be found in the release notes at https://github.com/figment/Cataclysm-DDA/releases/tag/0.C-figment-v1.\r\n","created_at":"2016-11-14T00:59:47Z","updated_at":"2016-12-22T05:26:33Z","closed_at":"2016-12-22T05:26:33Z","merged_at":"2016-12-22T05:26:33Z","merge_commit_sha":"4831cbf8b033d73a407136fa5adb76af563da9f8","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/19277/commits","review_comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/19277/comments","review_comment_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/19277/comments","statuses_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/4831cbf8b033d73a407136fa5adb76af563da9f8","head":{"label":"figment:msvc-2015","ref":"msvc-2015","sha":"4831cbf8b033d73a407136fa5adb76af563da9f8","user":{"login":"figment","id":1208954,"avatar_url":"https://avatars.githubusercontent.com/u/1208954?v=3","gravatar_id":"","url":"https://api.github.com/users/figment","html_url":"https://github.com/figment","followers_url":"https://api.github.com/users/figment/followers","following_url":"https://api.github.com/users/figment/following{/other_user}","gists_url":"https://api.github.com/users/figment/gists{/gist_id}","starred_url":"https://api.github.com/users/figment/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/figment/subscriptions","organizations_url":"https://api.github.com/users/figment/orgs","repos_url":"https://api.github.com/users/figment/repos","events_url":"https://api.github.com/users/figment/events{/privacy}","received_events_url":"https://api.github.com/users/figment/received_events","type":"User","site_admin":false},"repo":{"id":24012036,"name":"Cataclysm-DDA","full_name":"figment/Cataclysm-DDA","owner":{"login":"figment","id":1208954,"avatar_url":"https://avatars.githubusercontent.com/u/1208954?v=3","gravatar_id":"","url":"https://api.github.com/users/figment","html_url":"https://github.com/figment","followers_url":"https://api.github.com/users/figment/followers","following_url":"https://api.github.com/users/figment/following{/other_user}","gists_url":"https://api.github.com/users/figment/gists{/gist_id}","starred_url":"https://api.github.com/users/figment/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/figment/subscriptions","organizations_url":"https://api.github.com/users/figment/orgs","repos_url":"https://api.github.com/users/figment/repos","events_url":"https://api.github.com/users/figment/events{/privacy}","received_events_url":"https://api.github.com/users/figment/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/figment/Cataclysm-DDA","description":"Cataclysm - Dark Days Ahead. A fork/variant of Cataclysm Roguelike by Whales.","fork":true,"url":"https://api.github.com/repos/figment/Cataclysm-DDA","forks_url":"https://api.github.com/repos/figment/Cataclysm-DDA/forks","keys_url":"https://api.github.com/repos/figment/Cataclysm-DDA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/figment/Cataclysm-DDA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/figment/Cataclysm-DDA/teams","hooks_url":"https://api.github.com/repos/figment/Cataclysm-DDA/hooks","issue_events_url":"https://api.github.com/repos/figment/Cataclysm-DDA/issues/events{/number}","events_url":"https://api.github.com/repos/figment/Cataclysm-DDA/events","assignees_url":"https://api.github.com/repos/figment/Cataclysm-DDA/assignees{/user}","branches_url":"https://api.github.com/repos/figment/Cataclysm-DDA/branches{/branch}","tags_url":"https://api.github.com/repos/figment/Cataclysm-DDA/tags","blobs_url":"https://api.github.com/repos/figment/Cataclysm-DDA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/figment/Cataclysm-DDA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/figment/Cataclysm-DDA/git/refs{/sha}","trees_url":"https://api.github.com/repos/figment/Cataclysm-DDA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/figment/Cataclysm-DDA/statuses/{sha}","languages_url":"https://api.github.com/repos/figment/Cataclysm-DDA/languages","stargazers_url":"https://api.github.com/repos/figment/Cataclysm-DDA/stargazers","contributors_url":"https://api.github.com/repos/figment/Cataclysm-DDA/contributors","subscribers_url":"https://api.github.com/repos/figment/Cataclysm-DDA/subscribers","subscription_url":"https://api.github.com/repos/figment/Cataclysm-DDA/subscription","commits_url":"https://api.github.com/repos/figment/Cataclysm-DDA/commits{/sha}","git_commits_url":"https://api.github.com/repos/figment/Cataclysm-DDA/git/commits{/sha}","comments_url":"https://api.github.com/repos/figment/Cataclysm-DDA/comments{/number}","issue_comment_url":"https://api.github.com/repos/figment/Cataclysm-DDA/issues/comments{/number}","contents_url":"https://api.github.com/repos/figment/Cataclysm-DDA/contents/{+path}","compare_url":"https://api.github.com/repos/figment/Cataclysm-DDA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/figment/Cataclysm-DDA/merges","archive_url":"https://api.github.com/repos/figment/Cataclysm-DDA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/figment/Cataclysm-DDA/downloads","issues_url":"https://api.github.com/repos/figment/Cataclysm-DDA/issues{/number}","pulls_url":"https://api.github.com/repos/figment/Cataclysm-DDA/pulls{/number}","milestones_url":"https://api.github.com/repos/figment/Cataclysm-DDA/milestones{/number}","notifications_url":"https://api.github.com/repos/figment/Cataclysm-DDA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/figment/Cataclysm-DDA/labels{/name}","releases_url":"https://api.github.com/repos/figment/Cataclysm-DDA/releases{/id}","deployments_url":"https://api.github.com/repos/figment/Cataclysm-DDA/deployments","created_at":"2014-09-14T02:51:42Z","updated_at":"2016-11-13T23:22:35Z","pushed_at":"2016-11-14T00:50:27Z","git_url":"git://github.com/figment/Cataclysm-DDA.git","ssh_url":"git@github.com:figment/Cataclysm-DDA.git","clone_url":"https://github.com/figment/Cataclysm-DDA.git","svn_url":"https://github.com/figment/Cataclysm-DDA","homepage":"http://en.cataclysmdda.com/","size":813471,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"msvc-2015"}},"base":{"label":"CleverRaven:master","ref":"master","sha":"3c7d0943fef5dc8308ad7360e3fb13a89e96e21e","user":{"login":"CleverRaven","id":4367009,"avatar_url":"https://avatars.githubusercontent.com/u/4367009?v=3","gravatar_id":"","url":"https://api.github.com/users/CleverRaven","html_url":"https://github.com/CleverRaven","followers_url":"https://api.github.com/users/CleverRaven/followers","following_url":"https://api.github.com/users/CleverRaven/following{/other_user}","gists_url":"https://api.github.com/users/CleverRaven/gists{/gist_id}","starred_url":"https://api.github.com/users/CleverRaven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CleverRaven/subscriptions","organizations_url":"https://api.github.com/users/CleverRaven/orgs","repos_url":"https://api.github.com/users/CleverRaven/repos","events_url":"https://api.github.com/users/CleverRaven/events{/privacy}","received_events_url":"https://api.github.com/users/CleverRaven/received_events","type":"Organization","site_admin":false},"repo":{"id":5973855,"name":"Cataclysm-DDA","full_name":"CleverRaven/Cataclysm-DDA","owner":{"login":"CleverRaven","id":4367009,"avatar_url":"https://avatars.githubusercontent.com/u/4367009?v=3","gravatar_id":"","url":"https://api.github.com/users/CleverRaven","html_url":"https://github.com/CleverRaven","followers_url":"https://api.github.com/users/CleverRaven/followers","following_url":"https://api.github.com/users/CleverRaven/following{/other_user}","gists_url":"https://api.github.com/users/CleverRaven/gists{/gist_id}","starred_url":"https://api.github.com/users/CleverRaven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CleverRaven/subscriptions","organizations_url":"https://api.github.com/users/CleverRaven/orgs","repos_url":"https://api.github.com/users/CleverRaven/repos","events_url":"https://api.github.com/users/CleverRaven/events{/privacy}","received_events_url":"https://api.github.com/users/CleverRaven/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CleverRaven/Cataclysm-DDA","description":"Cataclysm - Dark Days Ahead. A fork/variant of Cataclysm Roguelike by Whales.","fork":false,"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA","forks_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/forks","keys_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/teams","hooks_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/hooks","issue_events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/events{/number}","events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/events","assignees_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/assignees{/user}","branches_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/branches{/branch}","tags_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/tags","blobs_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/refs{/sha}","trees_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/{sha}","languages_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/languages","stargazers_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/stargazers","contributors_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/contributors","subscribers_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/subscribers","subscription_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/subscription","commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/commits{/sha}","git_commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/commits{/sha}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/comments{/number}","issue_comment_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/comments{/number}","contents_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/contents/{+path}","compare_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/merges","archive_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/downloads","issues_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues{/number}","pulls_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls{/number}","milestones_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/milestones{/number}","notifications_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/labels{/name}","releases_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/releases{/id}","deployments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/deployments","created_at":"2012-09-26T22:57:43Z","updated_at":"2016-12-21T12:50:11Z","pushed_at":"2016-12-22T05:26:31Z","git_url":"git://github.com/CleverRaven/Cataclysm-DDA.git","ssh_url":"git@github.com:CleverRaven/Cataclysm-DDA.git","clone_url":"https://github.com/CleverRaven/Cataclysm-DDA.git","svn_url":"https://github.com/CleverRaven/Cataclysm-DDA","homepage":"http://en.cataclysmdda.com/","size":830057,"stargazers_count":1217,"watchers_count":1217,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1006,"mirror_url":null,"open_issues_count":954,"forks":1006,"open_issues":954,"watchers":1217,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/19277"},"html":{"href":"https://github.com/CleverRaven/Cataclysm-DDA/pull/19277"},"issue":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/19277"},"comments":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/19277/comments"},"review_comments":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/19277/comments"},"review_comment":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/19277/commits"},"statuses":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/4831cbf8b033d73a407136fa5adb76af563da9f8"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"kevingranade","id":860276,"avatar_url":"https://avatars.githubusercontent.com/u/860276?v=3","gravatar_id":"","url":"https://api.github.com/users/kevingranade","html_url":"https://github.com/kevingranade","followers_url":"https://api.github.com/users/kevingranade/followers","following_url":"https://api.github.com/users/kevingranade/following{/other_user}","gists_url":"https://api.github.com/users/kevingranade/gists{/gist_id}","starred_url":"https://api.github.com/users/kevingranade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevingranade/subscriptions","organizations_url":"https://api.github.com/users/kevingranade/orgs","repos_url":"https://api.github.com/users/kevingranade/repos","events_url":"https://api.github.com/users/kevingranade/events{/privacy}","received_events_url":"https://api.github.com/users/kevingranade/received_events","type":"User","site_admin":false},"comments":2,"review_comments":3,"commits":1,"additions":114,"deletions":54,"changed_files":22}}
{"actor":{"display_login":"kevingranade"}}