{"action":"created","comment":{"url":"https://api.github.com/repos/Ensembles/ert/pulls/comments/87857675","pull_request_review_id":8441581,"id":87857675,"diff_hunk":"@@ -44,18 +45,27 @@ class Surface(BaseCClass):\n     _isqrt        = GeoPrototype(\"void   geo_surface_isqrt( surface )\")\n \n     \n-    def __init__(self, filename):\n+    def __init__(self, filename=None, ny=None, xinc=None, yinc=None,\n+                                      xstart=None, ystart=None,\n+                                      nx=None, angle=None, internal_z=None):\n         \"\"\"\n         This will load a irap surface from file. The surface should\n         consist of a header and a set z values.\n         \"\"\"\n-        if os.path.isfile( filename ):\n-            c_ptr = self._alloc(filename , True)\n-            super(Surface , self).__init__(c_ptr)\n+        if filename is not None:\n+            filename = str(filename)","path":"python/python/ert/geo/surface.py","position":60,"original_position":24,"commit_id":"07bca0a895d5130bc97ce30b3002bd9ab1c0f476","original_commit_id":"1af6780a166cac43a16e93162b2231504c02305b","user":{"login":"joakim-hove","id":1321665,"avatar_url":"https://avatars.githubusercontent.com/u/1321665?v=3","gravatar_id":"","url":"https://api.github.com/users/joakim-hove","html_url":"https://github.com/joakim-hove","followers_url":"https://api.github.com/users/joakim-hove/followers","following_url":"https://api.github.com/users/joakim-hove/following{/other_user}","gists_url":"https://api.github.com/users/joakim-hove/gists{/gist_id}","starred_url":"https://api.github.com/users/joakim-hove/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joakim-hove/subscriptions","organizations_url":"https://api.github.com/users/joakim-hove/orgs","repos_url":"https://api.github.com/users/joakim-hove/repos","events_url":"https://api.github.com/users/joakim-hove/events{/privacy}","received_events_url":"https://api.github.com/users/joakim-hove/received_events","type":"User","site_admin":false},"body":"The `internal_z` should in 99/100 cases be `True`. At least it should default to `True` - alternatively it could even be hardcoded as `internal_z = True` inside the method.","created_at":"2016-11-14T18:07:49Z","updated_at":"2016-11-14T18:09:55Z","html_url":"https://github.com/Ensembles/ert/pull/1308#discussion_r87857675","pull_request_url":"https://api.github.com/repos/Ensembles/ert/pulls/1308","_links":{"self":{"href":"https://api.github.com/repos/Ensembles/ert/pulls/comments/87857675"},"html":{"href":"https://github.com/Ensembles/ert/pull/1308#discussion_r87857675"},"pull_request":{"href":"https://api.github.com/repos/Ensembles/ert/pulls/1308"}}},"pull_request":{"url":"https://api.github.com/repos/Ensembles/ert/pulls/1308","id":93596381,"html_url":"https://github.com/Ensembles/ert/pull/1308","diff_url":"https://github.com/Ensembles/ert/pull/1308.diff","patch_url":"https://github.com/Ensembles/ert/pull/1308.patch","issue_url":"https://api.github.com/repos/Ensembles/ert/issues/1308","number":1308,"state":"open","locked":false,"title":"Added geo_surface_alloc_new in libgeometry","user":{"login":"pgdr","id":17569537,"avatar_url":"https://avatars.githubusercontent.com/u/17569537?v=3","gravatar_id":"","url":"https://api.github.com/users/pgdr","html_url":"https://github.com/pgdr","followers_url":"https://api.github.com/users/pgdr/followers","following_url":"https://api.github.com/users/pgdr/following{/other_user}","gists_url":"https://api.github.com/users/pgdr/gists{/gist_id}","starred_url":"https://api.github.com/users/pgdr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pgdr/subscriptions","organizations_url":"https://api.github.com/users/pgdr/orgs","repos_url":"https://api.github.com/users/pgdr/repos","events_url":"https://api.github.com/users/pgdr/events{/privacy}","received_events_url":"https://api.github.com/users/pgdr/received_events","type":"User","site_admin":false},"body":"* added function `geo_surface_alloc_new` allowing creating empty surface\r\n* added corresponding mapping in `surface.py`\r\n* added tests for creating new surfaces\r\n\r\n_(Internal ERT-1107)_","created_at":"2016-11-14T16:15:17Z","updated_at":"2016-11-14T18:09:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fef37d0a3ddfe5c0170fe424f260e690f90abe62","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Ensembles/ert/pulls/1308/commits","review_comments_url":"https://api.github.com/repos/Ensembles/ert/pulls/1308/comments","review_comment_url":"https://api.github.com/repos/Ensembles/ert/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Ensembles/ert/issues/1308/comments","statuses_url":"https://api.github.com/repos/Ensembles/ert/statuses/07bca0a895d5130bc97ce30b3002bd9ab1c0f476","head":{"label":"pgdr:geo-surface-from-scratch","ref":"geo-surface-from-scratch","sha":"07bca0a895d5130bc97ce30b3002bd9ab1c0f476","user":{"login":"pgdr","id":17569537,"avatar_url":"https://avatars.githubusercontent.com/u/17569537?v=3","gravatar_id":"","url":"https://api.github.com/users/pgdr","html_url":"https://github.com/pgdr","followers_url":"https://api.github.com/users/pgdr/followers","following_url":"https://api.github.com/users/pgdr/following{/other_user}","gists_url":"https://api.github.com/users/pgdr/gists{/gist_id}","starred_url":"https://api.github.com/users/pgdr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pgdr/subscriptions","organizations_url":"https://api.github.com/users/pgdr/orgs","repos_url":"https://api.github.com/users/pgdr/repos","events_url":"https://api.github.com/users/pgdr/events{/privacy}","received_events_url":"https://api.github.com/users/pgdr/received_events","type":"User","site_admin":false},"repo":{"id":56774820,"name":"ert","full_name":"pgdr/ert","owner":{"login":"pgdr","id":17569537,"avatar_url":"https://avatars.githubusercontent.com/u/17569537?v=3","gravatar_id":"","url":"https://api.github.com/users/pgdr","html_url":"https://github.com/pgdr","followers_url":"https://api.github.com/users/pgdr/followers","following_url":"https://api.github.com/users/pgdr/following{/other_user}","gists_url":"https://api.github.com/users/pgdr/gists{/gist_id}","starred_url":"https://api.github.com/users/pgdr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pgdr/subscriptions","organizations_url":"https://api.github.com/users/pgdr/orgs","repos_url":"https://api.github.com/users/pgdr/repos","events_url":"https://api.github.com/users/pgdr/events{/privacy}","received_events_url":"https://api.github.com/users/pgdr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pgdr/ert","description":"ert","fork":true,"url":"https://api.github.com/repos/pgdr/ert","forks_url":"https://api.github.com/repos/pgdr/ert/forks","keys_url":"https://api.github.com/repos/pgdr/ert/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pgdr/ert/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pgdr/ert/teams","hooks_url":"https://api.github.com/repos/pgdr/ert/hooks","issue_events_url":"https://api.github.com/repos/pgdr/ert/issues/events{/number}","events_url":"https://api.github.com/repos/pgdr/ert/events","assignees_url":"https://api.github.com/repos/pgdr/ert/assignees{/user}","branches_url":"https://api.github.com/repos/pgdr/ert/branches{/branch}","tags_url":"https://api.github.com/repos/pgdr/ert/tags","blobs_url":"https://api.github.com/repos/pgdr/ert/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pgdr/ert/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pgdr/ert/git/refs{/sha}","trees_url":"https://api.github.com/repos/pgdr/ert/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pgdr/ert/statuses/{sha}","languages_url":"https://api.github.com/repos/pgdr/ert/languages","stargazers_url":"https://api.github.com/repos/pgdr/ert/stargazers","contributors_url":"https://api.github.com/repos/pgdr/ert/contributors","subscribers_url":"https://api.github.com/repos/pgdr/ert/subscribers","subscription_url":"https://api.github.com/repos/pgdr/ert/subscription","commits_url":"https://api.github.com/repos/pgdr/ert/commits{/sha}","git_commits_url":"https://api.github.com/repos/pgdr/ert/git/commits{/sha}","comments_url":"https://api.github.com/repos/pgdr/ert/comments{/number}","issue_comment_url":"https://api.github.com/repos/pgdr/ert/issues/comments{/number}","contents_url":"https://api.github.com/repos/pgdr/ert/contents/{+path}","compare_url":"https://api.github.com/repos/pgdr/ert/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pgdr/ert/merges","archive_url":"https://api.github.com/repos/pgdr/ert/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pgdr/ert/downloads","issues_url":"https://api.github.com/repos/pgdr/ert/issues{/number}","pulls_url":"https://api.github.com/repos/pgdr/ert/pulls{/number}","milestones_url":"https://api.github.com/repos/pgdr/ert/milestones{/number}","notifications_url":"https://api.github.com/repos/pgdr/ert/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pgdr/ert/labels{/name}","releases_url":"https://api.github.com/repos/pgdr/ert/releases{/id}","deployments_url":"https://api.github.com/repos/pgdr/ert/deployments","created_at":"2016-04-21T13:10:39Z","updated_at":"2016-04-21T13:10:46Z","pushed_at":"2016-11-14T16:20:34Z","git_url":"git://github.com/pgdr/ert.git","ssh_url":"git@github.com:pgdr/ert.git","clone_url":"https://github.com/pgdr/ert.git","svn_url":"https://github.com/pgdr/ert","homepage":null,"size":31319,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Ensembles:master","ref":"master","sha":"df0acf291ddfe2e1b634bc15cf78686b94317f6e","user":{"login":"Ensembles","id":2589271,"avatar_url":"https://avatars.githubusercontent.com/u/2589271?v=3","gravatar_id":"","url":"https://api.github.com/users/Ensembles","html_url":"https://github.com/Ensembles","followers_url":"https://api.github.com/users/Ensembles/followers","following_url":"https://api.github.com/users/Ensembles/following{/other_user}","gists_url":"https://api.github.com/users/Ensembles/gists{/gist_id}","starred_url":"https://api.github.com/users/Ensembles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ensembles/subscriptions","organizations_url":"https://api.github.com/users/Ensembles/orgs","repos_url":"https://api.github.com/users/Ensembles/repos","events_url":"https://api.github.com/users/Ensembles/events{/privacy}","received_events_url":"https://api.github.com/users/Ensembles/received_events","type":"Organization","site_admin":false},"repo":{"id":6267670,"name":"ert","full_name":"Ensembles/ert","owner":{"login":"Ensembles","id":2589271,"avatar_url":"https://avatars.githubusercontent.com/u/2589271?v=3","gravatar_id":"","url":"https://api.github.com/users/Ensembles","html_url":"https://github.com/Ensembles","followers_url":"https://api.github.com/users/Ensembles/followers","following_url":"https://api.github.com/users/Ensembles/following{/other_user}","gists_url":"https://api.github.com/users/Ensembles/gists{/gist_id}","starred_url":"https://api.github.com/users/Ensembles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ensembles/subscriptions","organizations_url":"https://api.github.com/users/Ensembles/orgs","repos_url":"https://api.github.com/users/Ensembles/repos","events_url":"https://api.github.com/users/Ensembles/events{/privacy}","received_events_url":"https://api.github.com/users/Ensembles/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Ensembles/ert","description":"ERT is a software initially developed by Statoil which main feature is to handle several ECLIPSE simulations in an Ensemble setting.","fork":false,"url":"https://api.github.com/repos/Ensembles/ert","forks_url":"https://api.github.com/repos/Ensembles/ert/forks","keys_url":"https://api.github.com/repos/Ensembles/ert/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ensembles/ert/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ensembles/ert/teams","hooks_url":"https://api.github.com/repos/Ensembles/ert/hooks","issue_events_url":"https://api.github.com/repos/Ensembles/ert/issues/events{/number}","events_url":"https://api.github.com/repos/Ensembles/ert/events","assignees_url":"https://api.github.com/repos/Ensembles/ert/assignees{/user}","branches_url":"https://api.github.com/repos/Ensembles/ert/branches{/branch}","tags_url":"https://api.github.com/repos/Ensembles/ert/tags","blobs_url":"https://api.github.com/repos/Ensembles/ert/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ensembles/ert/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ensembles/ert/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ensembles/ert/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ensembles/ert/statuses/{sha}","languages_url":"https://api.github.com/repos/Ensembles/ert/languages","stargazers_url":"https://api.github.com/repos/Ensembles/ert/stargazers","contributors_url":"https://api.github.com/repos/Ensembles/ert/contributors","subscribers_url":"https://api.github.com/repos/Ensembles/ert/subscribers","subscription_url":"https://api.github.com/repos/Ensembles/ert/subscription","commits_url":"https://api.github.com/repos/Ensembles/ert/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ensembles/ert/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ensembles/ert/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ensembles/ert/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ensembles/ert/contents/{+path}","compare_url":"https://api.github.com/repos/Ensembles/ert/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ensembles/ert/merges","archive_url":"https://api.github.com/repos/Ensembles/ert/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ensembles/ert/downloads","issues_url":"https://api.github.com/repos/Ensembles/ert/issues{/number}","pulls_url":"https://api.github.com/repos/Ensembles/ert/pulls{/number}","milestones_url":"https://api.github.com/repos/Ensembles/ert/milestones{/number}","notifications_url":"https://api.github.com/repos/Ensembles/ert/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ensembles/ert/labels{/name}","releases_url":"https://api.github.com/repos/Ensembles/ert/releases{/id}","deployments_url":"https://api.github.com/repos/Ensembles/ert/deployments","created_at":"2012-10-17T19:53:34Z","updated_at":"2016-10-30T07:29:33Z","pushed_at":"2016-11-14T16:20:35Z","git_url":"git://github.com/Ensembles/ert.git","ssh_url":"git@github.com:Ensembles/ert.git","clone_url":"https://github.com/Ensembles/ert.git","svn_url":"https://github.com/Ensembles/ert","homepage":"http://ert.nr.no/ert","size":37584,"stargazers_count":17,"watchers_count":17,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":47,"mirror_url":null,"open_issues_count":14,"forks":47,"open_issues":14,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Ensembles/ert/pulls/1308"},"html":{"href":"https://github.com/Ensembles/ert/pull/1308"},"issue":{"href":"https://api.github.com/repos/Ensembles/ert/issues/1308"},"comments":{"href":"https://api.github.com/repos/Ensembles/ert/issues/1308/comments"},"review_comments":{"href":"https://api.github.com/repos/Ensembles/ert/pulls/1308/comments"},"review_comment":{"href":"https://api.github.com/repos/Ensembles/ert/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Ensembles/ert/pulls/1308/commits"},"statuses":{"href":"https://api.github.com/repos/Ensembles/ert/statuses/07bca0a895d5130bc97ce30b3002bd9ab1c0f476"}}}}
{"actor":{"display_login":"joakim-hove"}}