{"action":"created","issue":{"url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/issues/314","repository_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy","labels_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/issues/314/labels{/name}","comments_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/issues/314/comments","events_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/issues/314/events","html_url":"https://github.com/theforeman/puppet-foreman_proxy/pull/314","id":194531212,"number":314,"title":"Fixes #17631 - Validate realms/puppetrun providers","user":{"login":"dLobatog","id":598891,"avatar_url":"https://avatars.githubusercontent.com/u/598891?v=3","gravatar_id":"","url":"https://api.github.com/users/dLobatog","html_url":"https://github.com/dLobatog","followers_url":"https://api.github.com/users/dLobatog/followers","following_url":"https://api.github.com/users/dLobatog/following{/other_user}","gists_url":"https://api.github.com/users/dLobatog/gists{/gist_id}","starred_url":"https://api.github.com/users/dLobatog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dLobatog/subscriptions","organizations_url":"https://api.github.com/users/dLobatog/orgs","repos_url":"https://api.github.com/users/dLobatog/repos","events_url":"https://api.github.com/users/dLobatog/events{/privacy}","received_events_url":"https://api.github.com/users/dLobatog/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2016-12-09T07:31:22Z","updated_at":"2016-12-12T10:02:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/pulls/314","html_url":"https://github.com/theforeman/puppet-foreman_proxy/pull/314","diff_url":"https://github.com/theforeman/puppet-foreman_proxy/pull/314.diff","patch_url":"https://github.com/theforeman/puppet-foreman_proxy/pull/314.patch"},"body":"This commit adds checks for the dhcp/dns/realms providers so that they\r\nhave to be compliant with a certain regex in order to be accepted as\r\nparameters.\r\n\r\n---- \r\n\r\nI know the values can come from plugins, and we effectively have no way of validating that the value doesn't come from a plugin. My argument is that in that case, the providers that come from plugins should be added to this repo to add the validation. \r\n\r\nOtherwise if you install a new plugin that provides a provider you manage the configuration yourself. It's nothing new, we already do this with the BMC provider (it's validated prior to this PR)\r\n\r\nI can see how people can get frustrated by having their entire installation (if the proxy fails, the installation fails) aborted for getting such a minor thing wrong."},"comment":{"url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/issues/comments/266388016","html_url":"https://github.com/theforeman/puppet-foreman_proxy/pull/314#issuecomment-266388016","issue_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/issues/314","id":266388016,"user":{"login":"dLobatog","id":598891,"avatar_url":"https://avatars.githubusercontent.com/u/598891?v=3","gravatar_id":"","url":"https://api.github.com/users/dLobatog","html_url":"https://github.com/dLobatog","followers_url":"https://api.github.com/users/dLobatog/followers","following_url":"https://api.github.com/users/dLobatog/following{/other_user}","gists_url":"https://api.github.com/users/dLobatog/gists{/gist_id}","starred_url":"https://api.github.com/users/dLobatog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dLobatog/subscriptions","organizations_url":"https://api.github.com/users/dLobatog/orgs","repos_url":"https://api.github.com/users/dLobatog/repos","events_url":"https://api.github.com/users/dLobatog/events{/privacy}","received_events_url":"https://api.github.com/users/dLobatog/received_events","type":"User","site_admin":false},"created_at":"2016-12-12T10:02:48Z","updated_at":"2016-12-12T10:02:48Z","body":"Moved it to 17631, related to the previous issue. I'll tell the original reporter in BZ "}}
{"actor":{"display_login":"dLobatog"}}