{"action":"created","comment":{"url":"https://api.github.com/repos/glossier/solidus_retail/pulls/comments/77068169","id":77068169,"diff_hunk":"@@ -0,0 +1,45 @@\n+require 'spec_helper'\n+\n+require_relative '../../lib/active_merchant/billing/gateways/shopify.rb'\n+\n+describe ShopifyVoider do\n+  let(:transaction_id) { '0xDEADBEEF' }\n+  let(:order_id) { 'order_id' }\n+  let(:transaction_amount) { 1 }\n+  let(:transaction) { double(:transaction, amount: transaction_amount, id: transaction_id) }\n+  let(:refunder_instance) { double('refunder_instance', perform: true) }\n+\n+  before do\n+    allow(ShopifyAPI::Transaction).to receive(:find).and_return(transaction)\n+  end\n+\n+  subject { described_class.new(transaction_id, order_id) }\n+\n+  context '.initialize' do\n+    it 'successfully does it\\'s thing' do\n+      expect(subject).to be_truthy\n+    end\n+  end\n+\n+  context '.perform' do\n+    before do\n+      allow(ShopifyRefunder).to receive(:new).and_return(refunder_instance)\n+    end\n+\n+    context 'when the shopify transaction is not found' do\n+      before do\n+        allow(ShopifyAPI::Transaction).to receive(:find).and_return(nil)\n+      end\n+\n+      it 'throws an error' do\n+        cause = ->{ subject.perform }\n+        expect(&cause).to raise_error(ActiveMerchant::Billing::ShopifyGateway::TransactionNotFoundError)\n+      end\n+    end\n+\n+    it 'calls the shopify refunder' do\n+      expect(refunder_instance).to receive(:perform)","path":"spec/services/shopify_voider_spec.rb","position":null,"original_position":41,"commit_id":"80ff5004b534ccfda98763f5331227db65c36b73","original_commit_id":"68075199d490f344b8c1c2c74d7a8e4499ad828b","user":{"login":"cabouffard","id":1725061,"avatar_url":"https://avatars.githubusercontent.com/u/1725061?v=3","gravatar_id":"","url":"https://api.github.com/users/cabouffard","html_url":"https://github.com/cabouffard","followers_url":"https://api.github.com/users/cabouffard/followers","following_url":"https://api.github.com/users/cabouffard/following{/other_user}","gists_url":"https://api.github.com/users/cabouffard/gists{/gist_id}","starred_url":"https://api.github.com/users/cabouffard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cabouffard/subscriptions","organizations_url":"https://api.github.com/users/cabouffard/orgs","repos_url":"https://api.github.com/users/cabouffard/repos","events_url":"https://api.github.com/users/cabouffard/events{/privacy}","received_events_url":"https://api.github.com/users/cabouffard/received_events","type":"User","site_admin":false},"body":"I am unsure about that comment, I'd like to dicuss to either of you, if you ever have the chance. \r\n\r\nI wrote a big paragraph but I had trouble zoning on what I was trying to explain.","created_at":"2016-08-31T20:36:48Z","updated_at":"2016-08-31T20:36:48Z","html_url":"https://github.com/glossier/solidus_retail/pull/4#discussion_r77068169","pull_request_url":"https://api.github.com/repos/glossier/solidus_retail/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/glossier/solidus_retail/pulls/comments/77068169"},"html":{"href":"https://github.com/glossier/solidus_retail/pull/4#discussion_r77068169"},"pull_request":{"href":"https://api.github.com/repos/glossier/solidus_retail/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/glossier/solidus_retail/pulls/4","id":82917275,"html_url":"https://github.com/glossier/solidus_retail/pull/4","diff_url":"https://github.com/glossier/solidus_retail/pull/4.diff","patch_url":"https://github.com/glossier/solidus_retail/pull/4.patch","issue_url":"https://api.github.com/repos/glossier/solidus_retail/issues/4","number":4,"state":"open","locked":false,"title":"Obviates Forks of Gem Dependencies","user":{"login":"DanielWright","id":642817,"avatar_url":"https://avatars.githubusercontent.com/u/642817?v=3","gravatar_id":"","url":"https://api.github.com/users/DanielWright","html_url":"https://github.com/DanielWright","followers_url":"https://api.github.com/users/DanielWright/followers","following_url":"https://api.github.com/users/DanielWright/following{/other_user}","gists_url":"https://api.github.com/users/DanielWright/gists{/gist_id}","starred_url":"https://api.github.com/users/DanielWright/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanielWright/subscriptions","organizations_url":"https://api.github.com/users/DanielWright/orgs","repos_url":"https://api.github.com/users/DanielWright/repos","events_url":"https://api.github.com/users/DanielWright/events{/privacy}","received_events_url":"https://api.github.com/users/DanielWright/received_events","type":"User","site_admin":false},"body":"Using custom forks of gems introduces a lot of maintainability headaches down the road. The juice isn't worth the squeeze: it's simple enough to include the AM and Solidus gateway implementations directly within our gem.\r\n\r\nThis PR proposes to do so, as well as consolidating all gem dependencies in the gemspec.\r\n\r\nOne complication: @cabouffard's AM gateway was test-driven with Test::Unit. The unit and integration tests will need to be ported to RSpec before this PR can be considered for merge.\r\n\r\n- [x] Remove dependencies on forked gems\r\n- [x] Consolidate all gem dependencies in the gemspec\r\n- [x] Integrate ActiveMerchant and Solidus gateways\r\n- [x] Maintain test coverage","created_at":"2016-08-26T16:33:58Z","updated_at":"2016-08-31T20:36:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f4eb648502086b7329c12cd24e2c516a5efc51d0","assignee":{"login":"DanielWright","id":642817,"avatar_url":"https://avatars.githubusercontent.com/u/642817?v=3","gravatar_id":"","url":"https://api.github.com/users/DanielWright","html_url":"https://github.com/DanielWright","followers_url":"https://api.github.com/users/DanielWright/followers","following_url":"https://api.github.com/users/DanielWright/following{/other_user}","gists_url":"https://api.github.com/users/DanielWright/gists{/gist_id}","starred_url":"https://api.github.com/users/DanielWright/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanielWright/subscriptions","organizations_url":"https://api.github.com/users/DanielWright/orgs","repos_url":"https://api.github.com/users/DanielWright/repos","events_url":"https://api.github.com/users/DanielWright/events{/privacy}","received_events_url":"https://api.github.com/users/DanielWright/received_events","type":"User","site_admin":false},"assignees":[{"login":"DanielWright","id":642817,"avatar_url":"https://avatars.githubusercontent.com/u/642817?v=3","gravatar_id":"","url":"https://api.github.com/users/DanielWright","html_url":"https://github.com/DanielWright","followers_url":"https://api.github.com/users/DanielWright/followers","following_url":"https://api.github.com/users/DanielWright/following{/other_user}","gists_url":"https://api.github.com/users/DanielWright/gists{/gist_id}","starred_url":"https://api.github.com/users/DanielWright/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanielWright/subscriptions","organizations_url":"https://api.github.com/users/DanielWright/orgs","repos_url":"https://api.github.com/users/DanielWright/repos","events_url":"https://api.github.com/users/DanielWright/events{/privacy}","received_events_url":"https://api.github.com/users/DanielWright/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/glossier/solidus_retail/pulls/4/commits","review_comments_url":"https://api.github.com/repos/glossier/solidus_retail/pulls/4/comments","review_comment_url":"https://api.github.com/repos/glossier/solidus_retail/pulls/comments{/number}","comments_url":"https://api.github.com/repos/glossier/solidus_retail/issues/4/comments","statuses_url":"https://api.github.com/repos/glossier/solidus_retail/statuses/80ff5004b534ccfda98763f5331227db65c36b73","head":{"label":"glossier:aug22-no-forks","ref":"aug22-no-forks","sha":"80ff5004b534ccfda98763f5331227db65c36b73","user":{"login":"glossier","id":13021459,"avatar_url":"https://avatars.githubusercontent.com/u/13021459?v=3","gravatar_id":"","url":"https://api.github.com/users/glossier","html_url":"https://github.com/glossier","followers_url":"https://api.github.com/users/glossier/followers","following_url":"https://api.github.com/users/glossier/following{/other_user}","gists_url":"https://api.github.com/users/glossier/gists{/gist_id}","starred_url":"https://api.github.com/users/glossier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glossier/subscriptions","organizations_url":"https://api.github.com/users/glossier/orgs","repos_url":"https://api.github.com/users/glossier/repos","events_url":"https://api.github.com/users/glossier/events{/privacy}","received_events_url":"https://api.github.com/users/glossier/received_events","type":"Organization","site_admin":false},"repo":{"id":65317430,"name":"solidus_retail","full_name":"glossier/solidus_retail","owner":{"login":"glossier","id":13021459,"avatar_url":"https://avatars.githubusercontent.com/u/13021459?v=3","gravatar_id":"","url":"https://api.github.com/users/glossier","html_url":"https://github.com/glossier","followers_url":"https://api.github.com/users/glossier/followers","following_url":"https://api.github.com/users/glossier/following{/other_user}","gists_url":"https://api.github.com/users/glossier/gists{/gist_id}","starred_url":"https://api.github.com/users/glossier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glossier/subscriptions","organizations_url":"https://api.github.com/users/glossier/orgs","repos_url":"https://api.github.com/users/glossier/repos","events_url":"https://api.github.com/users/glossier/events{/privacy}","received_events_url":"https://api.github.com/users/glossier/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/glossier/solidus_retail","description":"Solidus Extension to Support Retail Operations","fork":false,"url":"https://api.github.com/repos/glossier/solidus_retail","forks_url":"https://api.github.com/repos/glossier/solidus_retail/forks","keys_url":"https://api.github.com/repos/glossier/solidus_retail/keys{/key_id}","collaborators_url":"https://api.github.com/repos/glossier/solidus_retail/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/glossier/solidus_retail/teams","hooks_url":"https://api.github.com/repos/glossier/solidus_retail/hooks","issue_events_url":"https://api.github.com/repos/glossier/solidus_retail/issues/events{/number}","events_url":"https://api.github.com/repos/glossier/solidus_retail/events","assignees_url":"https://api.github.com/repos/glossier/solidus_retail/assignees{/user}","branches_url":"https://api.github.com/repos/glossier/solidus_retail/branches{/branch}","tags_url":"https://api.github.com/repos/glossier/solidus_retail/tags","blobs_url":"https://api.github.com/repos/glossier/solidus_retail/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/glossier/solidus_retail/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/glossier/solidus_retail/git/refs{/sha}","trees_url":"https://api.github.com/repos/glossier/solidus_retail/git/trees{/sha}","statuses_url":"https://api.github.com/repos/glossier/solidus_retail/statuses/{sha}","languages_url":"https://api.github.com/repos/glossier/solidus_retail/languages","stargazers_url":"https://api.github.com/repos/glossier/solidus_retail/stargazers","contributors_url":"https://api.github.com/repos/glossier/solidus_retail/contributors","subscribers_url":"https://api.github.com/repos/glossier/solidus_retail/subscribers","subscription_url":"https://api.github.com/repos/glossier/solidus_retail/subscription","commits_url":"https://api.github.com/repos/glossier/solidus_retail/commits{/sha}","git_commits_url":"https://api.github.com/repos/glossier/solidus_retail/git/commits{/sha}","comments_url":"https://api.github.com/repos/glossier/solidus_retail/comments{/number}","issue_comment_url":"https://api.github.com/repos/glossier/solidus_retail/issues/comments{/number}","contents_url":"https://api.github.com/repos/glossier/solidus_retail/contents/{+path}","compare_url":"https://api.github.com/repos/glossier/solidus_retail/compare/{base}...{head}","merges_url":"https://api.github.com/repos/glossier/solidus_retail/merges","archive_url":"https://api.github.com/repos/glossier/solidus_retail/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/glossier/solidus_retail/downloads","issues_url":"https://api.github.com/repos/glossier/solidus_retail/issues{/number}","pulls_url":"https://api.github.com/repos/glossier/solidus_retail/pulls{/number}","milestones_url":"https://api.github.com/repos/glossier/solidus_retail/milestones{/number}","notifications_url":"https://api.github.com/repos/glossier/solidus_retail/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/glossier/solidus_retail/labels{/name}","releases_url":"https://api.github.com/repos/glossier/solidus_retail/releases{/id}","deployments_url":"https://api.github.com/repos/glossier/solidus_retail/deployments","created_at":"2016-08-09T18:08:51Z","updated_at":"2016-08-09T18:55:10Z","pushed_at":"2016-08-31T20:04:31Z","git_url":"git://github.com/glossier/solidus_retail.git","ssh_url":"git@github.com:glossier/solidus_retail.git","clone_url":"https://github.com/glossier/solidus_retail.git","svn_url":"https://github.com/glossier/solidus_retail","homepage":null,"size":148,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":8,"forks":0,"open_issues":8,"watchers":0,"default_branch":"master"}},"base":{"label":"glossier:feature/shopify/gateway-implementation","ref":"feature/shopify/gateway-implementation","sha":"7092503cc4bd2c8d65fdb22ac0f2f59ff78ddfe1","user":{"login":"glossier","id":13021459,"avatar_url":"https://avatars.githubusercontent.com/u/13021459?v=3","gravatar_id":"","url":"https://api.github.com/users/glossier","html_url":"https://github.com/glossier","followers_url":"https://api.github.com/users/glossier/followers","following_url":"https://api.github.com/users/glossier/following{/other_user}","gists_url":"https://api.github.com/users/glossier/gists{/gist_id}","starred_url":"https://api.github.com/users/glossier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glossier/subscriptions","organizations_url":"https://api.github.com/users/glossier/orgs","repos_url":"https://api.github.com/users/glossier/repos","events_url":"https://api.github.com/users/glossier/events{/privacy}","received_events_url":"https://api.github.com/users/glossier/received_events","type":"Organization","site_admin":false},"repo":{"id":65317430,"name":"solidus_retail","full_name":"glossier/solidus_retail","owner":{"login":"glossier","id":13021459,"avatar_url":"https://avatars.githubusercontent.com/u/13021459?v=3","gravatar_id":"","url":"https://api.github.com/users/glossier","html_url":"https://github.com/glossier","followers_url":"https://api.github.com/users/glossier/followers","following_url":"https://api.github.com/users/glossier/following{/other_user}","gists_url":"https://api.github.com/users/glossier/gists{/gist_id}","starred_url":"https://api.github.com/users/glossier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glossier/subscriptions","organizations_url":"https://api.github.com/users/glossier/orgs","repos_url":"https://api.github.com/users/glossier/repos","events_url":"https://api.github.com/users/glossier/events{/privacy}","received_events_url":"https://api.github.com/users/glossier/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/glossier/solidus_retail","description":"Solidus Extension to Support Retail Operations","fork":false,"url":"https://api.github.com/repos/glossier/solidus_retail","forks_url":"https://api.github.com/repos/glossier/solidus_retail/forks","keys_url":"https://api.github.com/repos/glossier/solidus_retail/keys{/key_id}","collaborators_url":"https://api.github.com/repos/glossier/solidus_retail/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/glossier/solidus_retail/teams","hooks_url":"https://api.github.com/repos/glossier/solidus_retail/hooks","issue_events_url":"https://api.github.com/repos/glossier/solidus_retail/issues/events{/number}","events_url":"https://api.github.com/repos/glossier/solidus_retail/events","assignees_url":"https://api.github.com/repos/glossier/solidus_retail/assignees{/user}","branches_url":"https://api.github.com/repos/glossier/solidus_retail/branches{/branch}","tags_url":"https://api.github.com/repos/glossier/solidus_retail/tags","blobs_url":"https://api.github.com/repos/glossier/solidus_retail/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/glossier/solidus_retail/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/glossier/solidus_retail/git/refs{/sha}","trees_url":"https://api.github.com/repos/glossier/solidus_retail/git/trees{/sha}","statuses_url":"https://api.github.com/repos/glossier/solidus_retail/statuses/{sha}","languages_url":"https://api.github.com/repos/glossier/solidus_retail/languages","stargazers_url":"https://api.github.com/repos/glossier/solidus_retail/stargazers","contributors_url":"https://api.github.com/repos/glossier/solidus_retail/contributors","subscribers_url":"https://api.github.com/repos/glossier/solidus_retail/subscribers","subscription_url":"https://api.github.com/repos/glossier/solidus_retail/subscription","commits_url":"https://api.github.com/repos/glossier/solidus_retail/commits{/sha}","git_commits_url":"https://api.github.com/repos/glossier/solidus_retail/git/commits{/sha}","comments_url":"https://api.github.com/repos/glossier/solidus_retail/comments{/number}","issue_comment_url":"https://api.github.com/repos/glossier/solidus_retail/issues/comments{/number}","contents_url":"https://api.github.com/repos/glossier/solidus_retail/contents/{+path}","compare_url":"https://api.github.com/repos/glossier/solidus_retail/compare/{base}...{head}","merges_url":"https://api.github.com/repos/glossier/solidus_retail/merges","archive_url":"https://api.github.com/repos/glossier/solidus_retail/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/glossier/solidus_retail/downloads","issues_url":"https://api.github.com/repos/glossier/solidus_retail/issues{/number}","pulls_url":"https://api.github.com/repos/glossier/solidus_retail/pulls{/number}","milestones_url":"https://api.github.com/repos/glossier/solidus_retail/milestones{/number}","notifications_url":"https://api.github.com/repos/glossier/solidus_retail/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/glossier/solidus_retail/labels{/name}","releases_url":"https://api.github.com/repos/glossier/solidus_retail/releases{/id}","deployments_url":"https://api.github.com/repos/glossier/solidus_retail/deployments","created_at":"2016-08-09T18:08:51Z","updated_at":"2016-08-09T18:55:10Z","pushed_at":"2016-08-31T20:04:31Z","git_url":"git://github.com/glossier/solidus_retail.git","ssh_url":"git@github.com:glossier/solidus_retail.git","clone_url":"https://github.com/glossier/solidus_retail.git","svn_url":"https://github.com/glossier/solidus_retail","homepage":null,"size":148,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":8,"forks":0,"open_issues":8,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/glossier/solidus_retail/pulls/4"},"html":{"href":"https://github.com/glossier/solidus_retail/pull/4"},"issue":{"href":"https://api.github.com/repos/glossier/solidus_retail/issues/4"},"comments":{"href":"https://api.github.com/repos/glossier/solidus_retail/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/glossier/solidus_retail/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/glossier/solidus_retail/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/glossier/solidus_retail/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/glossier/solidus_retail/statuses/80ff5004b534ccfda98763f5331227db65c36b73"}}}}
{"actor":{"display_login":"cabouffard"}}