{"action":"created","comment":{"url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/pulls/comments/91652994","pull_request_review_id":12163524,"id":91652994,"diff_hunk":"@@ -49,16 +50,40 @@ iarc7_msgs::OrientationThrottleStamped QuadVelocityController::update(const ros:\n         last_time_ = time;\n     }\n     double time_delta = (time - last_time_).toSec();\n+\n     last_time_ = time;\n \n     // Update all the PID loops\n-    double throttle_output = throttle_pid_.update(velocities.z, time_delta);\n-    double pitch_output    = pitch_pid_.update(velocities.x, time_delta);\n-    double roll_output     = roll_pid_.update(-velocities.y, time_delta);\n-    double yaw_output      = yaw_pid_.update(velocities.y, time_delta);\n+    double throttle_output;\n+    double pitch_output;\n+    double roll_output;\n+    double yaw_output;\n+\n+    bool success = throttle_pid_.update(velocities.z, time_delta, throttle_output);\n+    if (!success) {","path":"src/QuadVelocityController.cpp","position":62,"original_position":28,"commit_id":"ce90c338f2586614fc46843f7feb7f88e9cf3ebc","original_commit_id":"ce90c338f2586614fc46843f7feb7f88e9cf3ebc","user":{"login":"aftersomemath","id":6125615,"avatar_url":"https://avatars.githubusercontent.com/u/6125615?v=3","gravatar_id":"","url":"https://api.github.com/users/aftersomemath","html_url":"https://github.com/aftersomemath","followers_url":"https://api.github.com/users/aftersomemath/followers","following_url":"https://api.github.com/users/aftersomemath/following{/other_user}","gists_url":"https://api.github.com/users/aftersomemath/gists{/gist_id}","starred_url":"https://api.github.com/users/aftersomemath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aftersomemath/subscriptions","organizations_url":"https://api.github.com/users/aftersomemath/orgs","repos_url":"https://api.github.com/users/aftersomemath/repos","events_url":"https://api.github.com/users/aftersomemath/events{/privacy}","received_events_url":"https://api.github.com/users/aftersomemath/received_events","type":"User","site_admin":false},"body":"Yes, there's a small chance it provides more debugging information come to think of it.","created_at":"2016-12-09T03:08:49Z","updated_at":"2016-12-09T03:08:49Z","html_url":"https://github.com/Pitt-RAS/iarc7_motion/pull/9#discussion_r91652994","pull_request_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/pulls/9","_links":{"self":{"href":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/pulls/comments/91652994"},"html":{"href":"https://github.com/Pitt-RAS/iarc7_motion/pull/9#discussion_r91652994"},"pull_request":{"href":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/pulls/9"}}},"pull_request":{"url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/pulls/9","id":96863501,"html_url":"https://github.com/Pitt-RAS/iarc7_motion/pull/9","diff_url":"https://github.com/Pitt-RAS/iarc7_motion/pull/9.diff","patch_url":"https://github.com/Pitt-RAS/iarc7_motion/pull/9.patch","issue_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/issues/9","number":9,"state":"open","locked":false,"title":"Low level motion integration test","user":{"login":"amiller27","id":4535296,"avatar_url":"https://avatars.githubusercontent.com/u/4535296?v=3","gravatar_id":"","url":"https://api.github.com/users/amiller27","html_url":"https://github.com/amiller27","followers_url":"https://api.github.com/users/amiller27/followers","following_url":"https://api.github.com/users/amiller27/following{/other_user}","gists_url":"https://api.github.com/users/amiller27/gists{/gist_id}","starred_url":"https://api.github.com/users/amiller27/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amiller27/subscriptions","organizations_url":"https://api.github.com/users/amiller27/orgs","repos_url":"https://api.github.com/users/amiller27/repos","events_url":"https://api.github.com/users/amiller27/events{/privacy}","received_events_url":"https://api.github.com/users/amiller27/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-12-07T06:00:18Z","updated_at":"2016-12-09T03:08:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0bc0c8e6980019fb68c38b3c807168eb13961f7d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/pulls/9/commits","review_comments_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/pulls/9/comments","review_comment_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/issues/9/comments","statuses_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/statuses/ce90c338f2586614fc46843f7feb7f88e9cf3ebc","head":{"label":"Pitt-RAS:low-level-motion-integration-test","ref":"low-level-motion-integration-test","sha":"ce90c338f2586614fc46843f7feb7f88e9cf3ebc","user":{"login":"Pitt-RAS","id":15024509,"avatar_url":"https://avatars.githubusercontent.com/u/15024509?v=3","gravatar_id":"","url":"https://api.github.com/users/Pitt-RAS","html_url":"https://github.com/Pitt-RAS","followers_url":"https://api.github.com/users/Pitt-RAS/followers","following_url":"https://api.github.com/users/Pitt-RAS/following{/other_user}","gists_url":"https://api.github.com/users/Pitt-RAS/gists{/gist_id}","starred_url":"https://api.github.com/users/Pitt-RAS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pitt-RAS/subscriptions","organizations_url":"https://api.github.com/users/Pitt-RAS/orgs","repos_url":"https://api.github.com/users/Pitt-RAS/repos","events_url":"https://api.github.com/users/Pitt-RAS/events{/privacy}","received_events_url":"https://api.github.com/users/Pitt-RAS/received_events","type":"Organization","site_admin":false},"repo":{"id":67438943,"name":"iarc7_motion","full_name":"Pitt-RAS/iarc7_motion","owner":{"login":"Pitt-RAS","id":15024509,"avatar_url":"https://avatars.githubusercontent.com/u/15024509?v=3","gravatar_id":"","url":"https://api.github.com/users/Pitt-RAS","html_url":"https://github.com/Pitt-RAS","followers_url":"https://api.github.com/users/Pitt-RAS/followers","following_url":"https://api.github.com/users/Pitt-RAS/following{/other_user}","gists_url":"https://api.github.com/users/Pitt-RAS/gists{/gist_id}","starred_url":"https://api.github.com/users/Pitt-RAS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pitt-RAS/subscriptions","organizations_url":"https://api.github.com/users/Pitt-RAS/orgs","repos_url":"https://api.github.com/users/Pitt-RAS/repos","events_url":"https://api.github.com/users/Pitt-RAS/events{/privacy}","received_events_url":"https://api.github.com/users/Pitt-RAS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Pitt-RAS/iarc7_motion","description":null,"fork":false,"url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion","forks_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/forks","keys_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/teams","hooks_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/hooks","issue_events_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/issues/events{/number}","events_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/events","assignees_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/assignees{/user}","branches_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/branches{/branch}","tags_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/tags","blobs_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/git/refs{/sha}","trees_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/statuses/{sha}","languages_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/languages","stargazers_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/stargazers","contributors_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/contributors","subscribers_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/subscribers","subscription_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/subscription","commits_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/commits{/sha}","git_commits_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/git/commits{/sha}","comments_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/comments{/number}","issue_comment_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/issues/comments{/number}","contents_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/contents/{+path}","compare_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/merges","archive_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/downloads","issues_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/issues{/number}","pulls_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/pulls{/number}","milestones_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/milestones{/number}","notifications_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/labels{/name}","releases_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/releases{/id}","deployments_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/deployments","created_at":"2016-09-05T17:23:18Z","updated_at":"2016-11-28T21:02:14Z","pushed_at":"2016-12-09T02:40:57Z","git_url":"git://github.com/Pitt-RAS/iarc7_motion.git","ssh_url":"git@github.com:Pitt-RAS/iarc7_motion.git","clone_url":"https://github.com/Pitt-RAS/iarc7_motion.git","svn_url":"https://github.com/Pitt-RAS/iarc7_motion","homepage":null,"size":98,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"Pitt-RAS:master","ref":"master","sha":"192722a471ccd30977d65a531171daee216296de","user":{"login":"Pitt-RAS","id":15024509,"avatar_url":"https://avatars.githubusercontent.com/u/15024509?v=3","gravatar_id":"","url":"https://api.github.com/users/Pitt-RAS","html_url":"https://github.com/Pitt-RAS","followers_url":"https://api.github.com/users/Pitt-RAS/followers","following_url":"https://api.github.com/users/Pitt-RAS/following{/other_user}","gists_url":"https://api.github.com/users/Pitt-RAS/gists{/gist_id}","starred_url":"https://api.github.com/users/Pitt-RAS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pitt-RAS/subscriptions","organizations_url":"https://api.github.com/users/Pitt-RAS/orgs","repos_url":"https://api.github.com/users/Pitt-RAS/repos","events_url":"https://api.github.com/users/Pitt-RAS/events{/privacy}","received_events_url":"https://api.github.com/users/Pitt-RAS/received_events","type":"Organization","site_admin":false},"repo":{"id":67438943,"name":"iarc7_motion","full_name":"Pitt-RAS/iarc7_motion","owner":{"login":"Pitt-RAS","id":15024509,"avatar_url":"https://avatars.githubusercontent.com/u/15024509?v=3","gravatar_id":"","url":"https://api.github.com/users/Pitt-RAS","html_url":"https://github.com/Pitt-RAS","followers_url":"https://api.github.com/users/Pitt-RAS/followers","following_url":"https://api.github.com/users/Pitt-RAS/following{/other_user}","gists_url":"https://api.github.com/users/Pitt-RAS/gists{/gist_id}","starred_url":"https://api.github.com/users/Pitt-RAS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pitt-RAS/subscriptions","organizations_url":"https://api.github.com/users/Pitt-RAS/orgs","repos_url":"https://api.github.com/users/Pitt-RAS/repos","events_url":"https://api.github.com/users/Pitt-RAS/events{/privacy}","received_events_url":"https://api.github.com/users/Pitt-RAS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Pitt-RAS/iarc7_motion","description":null,"fork":false,"url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion","forks_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/forks","keys_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/teams","hooks_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/hooks","issue_events_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/issues/events{/number}","events_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/events","assignees_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/assignees{/user}","branches_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/branches{/branch}","tags_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/tags","blobs_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/git/refs{/sha}","trees_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/statuses/{sha}","languages_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/languages","stargazers_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/stargazers","contributors_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/contributors","subscribers_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/subscribers","subscription_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/subscription","commits_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/commits{/sha}","git_commits_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/git/commits{/sha}","comments_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/comments{/number}","issue_comment_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/issues/comments{/number}","contents_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/contents/{+path}","compare_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/merges","archive_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/downloads","issues_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/issues{/number}","pulls_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/pulls{/number}","milestones_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/milestones{/number}","notifications_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/labels{/name}","releases_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/releases{/id}","deployments_url":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/deployments","created_at":"2016-09-05T17:23:18Z","updated_at":"2016-11-28T21:02:14Z","pushed_at":"2016-12-09T02:40:57Z","git_url":"git://github.com/Pitt-RAS/iarc7_motion.git","ssh_url":"git@github.com:Pitt-RAS/iarc7_motion.git","clone_url":"https://github.com/Pitt-RAS/iarc7_motion.git","svn_url":"https://github.com/Pitt-RAS/iarc7_motion","homepage":null,"size":98,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/pulls/9"},"html":{"href":"https://github.com/Pitt-RAS/iarc7_motion/pull/9"},"issue":{"href":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/issues/9"},"comments":{"href":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/Pitt-RAS/iarc7_motion/statuses/ce90c338f2586614fc46843f7feb7f88e9cf3ebc"}}}}
{"actor":{"display_login":"aftersomemath"}}