{"action":"created","comment":{"url":"https://api.github.com/repos/firehol/netdata/pulls/comments/90835019","pull_request_review_id":11349053,"id":90835019,"diff_hunk":"@@ -144,26 +170,27 @@ int do_proc_softirqs(int update_every, unsigned long long dt) {\n                 for(l = 0; l < lines ;l++) {\n                     struct interrupt *irr = irrindex(irrs, l, cpus);\n                     if(unlikely(!irr->used)) continue;\n-                    core_sum += irr->value[c];\n+                    core_sum += irr->cpu[c].value;\n                 }\n                 if(unlikely(core_sum == 0)) continue; // try next core","path":"src/proc_softirqs.c","position":134,"original_position":134,"commit_id":"409bd68b429f730ba73a750bb6c1bef5f38f6dd8","original_commit_id":"409bd68b429f730ba73a750bb6c1bef5f38f6dd8","user":{"login":"rlefevre","id":5399281,"avatar_url":"https://avatars.githubusercontent.com/u/5399281?v=3","gravatar_id":"","url":"https://api.github.com/users/rlefevre","html_url":"https://github.com/rlefevre","followers_url":"https://api.github.com/users/rlefevre/followers","following_url":"https://api.github.com/users/rlefevre/following{/other_user}","gists_url":"https://api.github.com/users/rlefevre/gists{/gist_id}","starred_url":"https://api.github.com/users/rlefevre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rlefevre/subscriptions","organizations_url":"https://api.github.com/users/rlefevre/orgs","repos_url":"https://api.github.com/users/rlefevre/repos","events_url":"https://api.github.com/users/rlefevre/events{/privacy}","received_events_url":"https://api.github.com/users/rlefevre/received_events","type":"User","site_admin":false},"body":"Unrelated, but why is this test only in `src/proc_softirqs` and not in `src/proc_interrupts`?","created_at":"2016-12-05T10:15:07Z","updated_at":"2016-12-05T10:15:07Z","html_url":"https://github.com/firehol/netdata/pull/1304#discussion_r90835019","pull_request_url":"https://api.github.com/repos/firehol/netdata/pulls/1304","_links":{"self":{"href":"https://api.github.com/repos/firehol/netdata/pulls/comments/90835019"},"html":{"href":"https://github.com/firehol/netdata/pull/1304#discussion_r90835019"},"pull_request":{"href":"https://api.github.com/repos/firehol/netdata/pulls/1304"}}},"pull_request":{"url":"https://api.github.com/repos/firehol/netdata/pulls/1304","id":95921815,"html_url":"https://github.com/firehol/netdata/pull/1304","diff_url":"https://github.com/firehol/netdata/pull/1304.diff","patch_url":"https://github.com/firehol/netdata/pull/1304.patch","issue_url":"https://api.github.com/repos/firehol/netdata/issues/1304","number":1304,"state":"open","locked":false,"title":"handle added/removed interrupts or softirqs","user":{"login":"rlefevre","id":5399281,"avatar_url":"https://avatars.githubusercontent.com/u/5399281?v=3","gravatar_id":"","url":"https://api.github.com/users/rlefevre","html_url":"https://github.com/rlefevre","followers_url":"https://api.github.com/users/rlefevre/followers","following_url":"https://api.github.com/users/rlefevre/following{/other_user}","gists_url":"https://api.github.com/users/rlefevre/gists{/gist_id}","starred_url":"https://api.github.com/users/rlefevre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rlefevre/subscriptions","organizations_url":"https://api.github.com/users/rlefevre/orgs","repos_url":"https://api.github.com/users/rlefevre/repos","events_url":"https://api.github.com/users/rlefevre/events{/privacy}","received_events_url":"https://api.github.com/users/rlefevre/received_events","type":"User","site_admin":false},"body":"Hi,\r\n\r\nOn one of our systems, some interrupts appear after netdata start, leading to lots of\r\n\r\n    Cannot find dimension with id 'xxx' on stats 'system.interrupts' (system.interrupts)\"\r\n\r\nerror logs at each do_proc_interrupts() execution.\r\n\r\nThanks\r\n\r\n","created_at":"2016-11-30T16:12:59Z","updated_at":"2016-12-05T10:15:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7065f85385469a48e376c863366139e3fef33b4a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/firehol/netdata/pulls/1304/commits","review_comments_url":"https://api.github.com/repos/firehol/netdata/pulls/1304/comments","review_comment_url":"https://api.github.com/repos/firehol/netdata/pulls/comments{/number}","comments_url":"https://api.github.com/repos/firehol/netdata/issues/1304/comments","statuses_url":"https://api.github.com/repos/firehol/netdata/statuses/409bd68b429f730ba73a750bb6c1bef5f38f6dd8","head":{"label":"rlefevre:unknown-interrupts","ref":"unknown-interrupts","sha":"409bd68b429f730ba73a750bb6c1bef5f38f6dd8","user":{"login":"rlefevre","id":5399281,"avatar_url":"https://avatars.githubusercontent.com/u/5399281?v=3","gravatar_id":"","url":"https://api.github.com/users/rlefevre","html_url":"https://github.com/rlefevre","followers_url":"https://api.github.com/users/rlefevre/followers","following_url":"https://api.github.com/users/rlefevre/following{/other_user}","gists_url":"https://api.github.com/users/rlefevre/gists{/gist_id}","starred_url":"https://api.github.com/users/rlefevre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rlefevre/subscriptions","organizations_url":"https://api.github.com/users/rlefevre/orgs","repos_url":"https://api.github.com/users/rlefevre/repos","events_url":"https://api.github.com/users/rlefevre/events{/privacy}","received_events_url":"https://api.github.com/users/rlefevre/received_events","type":"User","site_admin":false},"repo":{"id":75199373,"name":"netdata","full_name":"rlefevre/netdata","owner":{"login":"rlefevre","id":5399281,"avatar_url":"https://avatars.githubusercontent.com/u/5399281?v=3","gravatar_id":"","url":"https://api.github.com/users/rlefevre","html_url":"https://github.com/rlefevre","followers_url":"https://api.github.com/users/rlefevre/followers","following_url":"https://api.github.com/users/rlefevre/following{/other_user}","gists_url":"https://api.github.com/users/rlefevre/gists{/gist_id}","starred_url":"https://api.github.com/users/rlefevre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rlefevre/subscriptions","organizations_url":"https://api.github.com/users/rlefevre/orgs","repos_url":"https://api.github.com/users/rlefevre/repos","events_url":"https://api.github.com/users/rlefevre/events{/privacy}","received_events_url":"https://api.github.com/users/rlefevre/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rlefevre/netdata","description":"Real-time performance monitoring, done right!","fork":true,"url":"https://api.github.com/repos/rlefevre/netdata","forks_url":"https://api.github.com/repos/rlefevre/netdata/forks","keys_url":"https://api.github.com/repos/rlefevre/netdata/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rlefevre/netdata/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rlefevre/netdata/teams","hooks_url":"https://api.github.com/repos/rlefevre/netdata/hooks","issue_events_url":"https://api.github.com/repos/rlefevre/netdata/issues/events{/number}","events_url":"https://api.github.com/repos/rlefevre/netdata/events","assignees_url":"https://api.github.com/repos/rlefevre/netdata/assignees{/user}","branches_url":"https://api.github.com/repos/rlefevre/netdata/branches{/branch}","tags_url":"https://api.github.com/repos/rlefevre/netdata/tags","blobs_url":"https://api.github.com/repos/rlefevre/netdata/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rlefevre/netdata/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rlefevre/netdata/git/refs{/sha}","trees_url":"https://api.github.com/repos/rlefevre/netdata/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rlefevre/netdata/statuses/{sha}","languages_url":"https://api.github.com/repos/rlefevre/netdata/languages","stargazers_url":"https://api.github.com/repos/rlefevre/netdata/stargazers","contributors_url":"https://api.github.com/repos/rlefevre/netdata/contributors","subscribers_url":"https://api.github.com/repos/rlefevre/netdata/subscribers","subscription_url":"https://api.github.com/repos/rlefevre/netdata/subscription","commits_url":"https://api.github.com/repos/rlefevre/netdata/commits{/sha}","git_commits_url":"https://api.github.com/repos/rlefevre/netdata/git/commits{/sha}","comments_url":"https://api.github.com/repos/rlefevre/netdata/comments{/number}","issue_comment_url":"https://api.github.com/repos/rlefevre/netdata/issues/comments{/number}","contents_url":"https://api.github.com/repos/rlefevre/netdata/contents/{+path}","compare_url":"https://api.github.com/repos/rlefevre/netdata/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rlefevre/netdata/merges","archive_url":"https://api.github.com/repos/rlefevre/netdata/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rlefevre/netdata/downloads","issues_url":"https://api.github.com/repos/rlefevre/netdata/issues{/number}","pulls_url":"https://api.github.com/repos/rlefevre/netdata/pulls{/number}","milestones_url":"https://api.github.com/repos/rlefevre/netdata/milestones{/number}","notifications_url":"https://api.github.com/repos/rlefevre/netdata/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rlefevre/netdata/labels{/name}","releases_url":"https://api.github.com/repos/rlefevre/netdata/releases{/id}","deployments_url":"https://api.github.com/repos/rlefevre/netdata/deployments","created_at":"2016-11-30T15:20:16Z","updated_at":"2016-11-30T15:20:19Z","pushed_at":"2016-12-05T09:13:31Z","git_url":"git://github.com/rlefevre/netdata.git","ssh_url":"git@github.com:rlefevre/netdata.git","clone_url":"https://github.com/rlefevre/netdata.git","svn_url":"https://github.com/rlefevre/netdata","homepage":"http://my-netdata.io","size":8367,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"firehol:master","ref":"master","sha":"5c61ba04b4df60119f4f691a57feea52d0af10cd","user":{"login":"firehol","id":9442231,"avatar_url":"https://avatars.githubusercontent.com/u/9442231?v=3","gravatar_id":"","url":"https://api.github.com/users/firehol","html_url":"https://github.com/firehol","followers_url":"https://api.github.com/users/firehol/followers","following_url":"https://api.github.com/users/firehol/following{/other_user}","gists_url":"https://api.github.com/users/firehol/gists{/gist_id}","starred_url":"https://api.github.com/users/firehol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firehol/subscriptions","organizations_url":"https://api.github.com/users/firehol/orgs","repos_url":"https://api.github.com/users/firehol/repos","events_url":"https://api.github.com/users/firehol/events{/privacy}","received_events_url":"https://api.github.com/users/firehol/received_events","type":"Organization","site_admin":false},"repo":{"id":10744183,"name":"netdata","full_name":"firehol/netdata","owner":{"login":"firehol","id":9442231,"avatar_url":"https://avatars.githubusercontent.com/u/9442231?v=3","gravatar_id":"","url":"https://api.github.com/users/firehol","html_url":"https://github.com/firehol","followers_url":"https://api.github.com/users/firehol/followers","following_url":"https://api.github.com/users/firehol/following{/other_user}","gists_url":"https://api.github.com/users/firehol/gists{/gist_id}","starred_url":"https://api.github.com/users/firehol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firehol/subscriptions","organizations_url":"https://api.github.com/users/firehol/orgs","repos_url":"https://api.github.com/users/firehol/repos","events_url":"https://api.github.com/users/firehol/events{/privacy}","received_events_url":"https://api.github.com/users/firehol/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/firehol/netdata","description":"Real-time performance monitoring, done right!","fork":false,"url":"https://api.github.com/repos/firehol/netdata","forks_url":"https://api.github.com/repos/firehol/netdata/forks","keys_url":"https://api.github.com/repos/firehol/netdata/keys{/key_id}","collaborators_url":"https://api.github.com/repos/firehol/netdata/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/firehol/netdata/teams","hooks_url":"https://api.github.com/repos/firehol/netdata/hooks","issue_events_url":"https://api.github.com/repos/firehol/netdata/issues/events{/number}","events_url":"https://api.github.com/repos/firehol/netdata/events","assignees_url":"https://api.github.com/repos/firehol/netdata/assignees{/user}","branches_url":"https://api.github.com/repos/firehol/netdata/branches{/branch}","tags_url":"https://api.github.com/repos/firehol/netdata/tags","blobs_url":"https://api.github.com/repos/firehol/netdata/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/firehol/netdata/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/firehol/netdata/git/refs{/sha}","trees_url":"https://api.github.com/repos/firehol/netdata/git/trees{/sha}","statuses_url":"https://api.github.com/repos/firehol/netdata/statuses/{sha}","languages_url":"https://api.github.com/repos/firehol/netdata/languages","stargazers_url":"https://api.github.com/repos/firehol/netdata/stargazers","contributors_url":"https://api.github.com/repos/firehol/netdata/contributors","subscribers_url":"https://api.github.com/repos/firehol/netdata/subscribers","subscription_url":"https://api.github.com/repos/firehol/netdata/subscription","commits_url":"https://api.github.com/repos/firehol/netdata/commits{/sha}","git_commits_url":"https://api.github.com/repos/firehol/netdata/git/commits{/sha}","comments_url":"https://api.github.com/repos/firehol/netdata/comments{/number}","issue_comment_url":"https://api.github.com/repos/firehol/netdata/issues/comments{/number}","contents_url":"https://api.github.com/repos/firehol/netdata/contents/{+path}","compare_url":"https://api.github.com/repos/firehol/netdata/compare/{base}...{head}","merges_url":"https://api.github.com/repos/firehol/netdata/merges","archive_url":"https://api.github.com/repos/firehol/netdata/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/firehol/netdata/downloads","issues_url":"https://api.github.com/repos/firehol/netdata/issues{/number}","pulls_url":"https://api.github.com/repos/firehol/netdata/pulls{/number}","milestones_url":"https://api.github.com/repos/firehol/netdata/milestones{/number}","notifications_url":"https://api.github.com/repos/firehol/netdata/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/firehol/netdata/labels{/name}","releases_url":"https://api.github.com/repos/firehol/netdata/releases{/id}","deployments_url":"https://api.github.com/repos/firehol/netdata/deployments","created_at":"2013-06-17T18:39:10Z","updated_at":"2016-12-05T09:31:51Z","pushed_at":"2016-12-05T09:13:32Z","git_url":"git://github.com/firehol/netdata.git","ssh_url":"git@github.com:firehol/netdata.git","clone_url":"https://github.com/firehol/netdata.git","svn_url":"https://github.com/firehol/netdata","homepage":"http://my-netdata.io","size":10016,"stargazers_count":16042,"watchers_count":16042,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1203,"mirror_url":null,"open_issues_count":192,"forks":1203,"open_issues":192,"watchers":16042,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/firehol/netdata/pulls/1304"},"html":{"href":"https://github.com/firehol/netdata/pull/1304"},"issue":{"href":"https://api.github.com/repos/firehol/netdata/issues/1304"},"comments":{"href":"https://api.github.com/repos/firehol/netdata/issues/1304/comments"},"review_comments":{"href":"https://api.github.com/repos/firehol/netdata/pulls/1304/comments"},"review_comment":{"href":"https://api.github.com/repos/firehol/netdata/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/firehol/netdata/pulls/1304/commits"},"statuses":{"href":"https://api.github.com/repos/firehol/netdata/statuses/409bd68b429f730ba73a750bb6c1bef5f38f6dd8"}}}}
{"actor":{"display_login":"rlefevre"}}