{"action":"opened","number":2436,"pull_request":{"url":"https://api.github.com/repos/ansible/ansible-modules-extras/pulls/2436","id":74024396,"html_url":"https://github.com/ansible/ansible-modules-extras/pull/2436","diff_url":"https://github.com/ansible/ansible-modules-extras/pull/2436.diff","patch_url":"https://github.com/ansible/ansible-modules-extras/pull/2436.patch","issue_url":"https://api.github.com/repos/ansible/ansible-modules-extras/issues/2436","number":2436,"state":"open","locked":false,"title":"win_regedit; fixes dword changed error 2273, improved error handling; and adds  example showing quotes around reg paths containing spaces following https://github.com/ansible/ansible-modules-extras/issues/2340","user":{"login":"jhawkesworth","id":8440323,"avatar_url":"https://avatars.githubusercontent.com/u/8440323?v=3","gravatar_id":"","url":"https://api.github.com/users/jhawkesworth","html_url":"https://github.com/jhawkesworth","followers_url":"https://api.github.com/users/jhawkesworth/followers","following_url":"https://api.github.com/users/jhawkesworth/following{/other_user}","gists_url":"https://api.github.com/users/jhawkesworth/gists{/gist_id}","starred_url":"https://api.github.com/users/jhawkesworth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhawkesworth/subscriptions","organizations_url":"https://api.github.com/users/jhawkesworth/orgs","repos_url":"https://api.github.com/users/jhawkesworth/repos","events_url":"https://api.github.com/users/jhawkesworth/events{/privacy}","received_events_url":"https://api.github.com/users/jhawkesworth/received_events","type":"User","site_admin":false},"body":"##### ISSUE TYPE\r\n<!--- Pick one below and delete the rest: -->\r\n - Bugfix Pull Request\r\n\r\n##### COMPONENT NAME\r\n<!--- Name of the plugin/module/task -->\r\nwin_regedit\r\n##### ANSIBLE VERSION\r\n<!--- Paste verbatim output from “ansible --version” between quotes below -->\r\n```\r\nansible 2.2.0 (more-regedit-tests 0a0b44baeb) last updated 2016/06/16 06:13:34 (GMT +100)\r\n  lib/ansible/modules/core: (detached HEAD 138430f116) last updated 2016/06/12 06:32:34 (GMT +100)\r\n  lib/ansible/modules/extras: (regedit_fixes bc3e6e0e90) last updated 2016/06/16 06:21:00 (GMT +100)\r\n  config file = \r\n  configured module search path = Default w/o overrides\r\n\r\n```\r\n\r\n##### SUMMARY\r\n<!--- Describe the change, including rationale and design decisions -->\r\nAn earlier change I made broke change detection for dword registry data type, as reported in #2273.  I think this fix should be preferred to #2273 as this one does not then break the binary registry data type change detection.\r\n\r\nAlso this PR adds a check to ensure the registry key is in the powershell ps-drive format following #2412\r\nand replaces the ' .GetType().Name -eq '  comparisons with more idiomatic '-is' tests (following conversation with @nitzmahone \r\n\r\nAlso I added an example of managing a registry path that contains spaces, so that module users know to quote them in order to avoid failures when the module is re-run, following on from #2340 (which the issue creator has now closed).\r\n\r\n<!---\r\nIf you are fixing an existing issue, please include \"Fixes #nnnn\" in your commit\r\nmessage and your description; but you should still explain what the change does.\r\n-->\r\n\r\n<!--- Paste verbatim command output below, e.g. before and after your change -->\r\n```\r\nI will create a separate PR for the integration tests that exercise the new behavior and link to this PR.\r\n```\r\n\r\n","created_at":"2016-06-16T05:33:58Z","updated_at":"2016-06-16T05:33:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ansible/ansible-modules-extras/pulls/2436/commits","review_comments_url":"https://api.github.com/repos/ansible/ansible-modules-extras/pulls/2436/comments","review_comment_url":"https://api.github.com/repos/ansible/ansible-modules-extras/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ansible/ansible-modules-extras/issues/2436/comments","statuses_url":"https://api.github.com/repos/ansible/ansible-modules-extras/statuses/bc3e6e0e9039ecf38f7794747f0333f6e01c3e97","head":{"label":"jhawkesworth:regedit_fixes","ref":"regedit_fixes","sha":"bc3e6e0e9039ecf38f7794747f0333f6e01c3e97","user":{"login":"jhawkesworth","id":8440323,"avatar_url":"https://avatars.githubusercontent.com/u/8440323?v=3","gravatar_id":"","url":"https://api.github.com/users/jhawkesworth","html_url":"https://github.com/jhawkesworth","followers_url":"https://api.github.com/users/jhawkesworth/followers","following_url":"https://api.github.com/users/jhawkesworth/following{/other_user}","gists_url":"https://api.github.com/users/jhawkesworth/gists{/gist_id}","starred_url":"https://api.github.com/users/jhawkesworth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhawkesworth/subscriptions","organizations_url":"https://api.github.com/users/jhawkesworth/orgs","repos_url":"https://api.github.com/users/jhawkesworth/repos","events_url":"https://api.github.com/users/jhawkesworth/events{/privacy}","received_events_url":"https://api.github.com/users/jhawkesworth/received_events","type":"User","site_admin":false},"repo":{"id":26905261,"name":"ansible-modules-extras","full_name":"jhawkesworth/ansible-modules-extras","owner":{"login":"jhawkesworth","id":8440323,"avatar_url":"https://avatars.githubusercontent.com/u/8440323?v=3","gravatar_id":"","url":"https://api.github.com/users/jhawkesworth","html_url":"https://github.com/jhawkesworth","followers_url":"https://api.github.com/users/jhawkesworth/followers","following_url":"https://api.github.com/users/jhawkesworth/following{/other_user}","gists_url":"https://api.github.com/users/jhawkesworth/gists{/gist_id}","starred_url":"https://api.github.com/users/jhawkesworth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhawkesworth/subscriptions","organizations_url":"https://api.github.com/users/jhawkesworth/orgs","repos_url":"https://api.github.com/users/jhawkesworth/repos","events_url":"https://api.github.com/users/jhawkesworth/events{/privacy}","received_events_url":"https://api.github.com/users/jhawkesworth/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jhawkesworth/ansible-modules-extras","description":"Ansible extra modules - these modules ship with ansible","fork":true,"url":"https://api.github.com/repos/jhawkesworth/ansible-modules-extras","forks_url":"https://api.github.com/repos/jhawkesworth/ansible-modules-extras/forks","keys_url":"https://api.github.com/repos/jhawkesworth/ansible-modules-extras/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jhawkesworth/ansible-modules-extras/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jhawkesworth/ansible-modules-extras/teams","hooks_url":"https://api.github.com/repos/jhawkesworth/ansible-modules-extras/hooks","issue_events_url":"https://api.github.com/repos/jhawkesworth/ansible-modules-extras/issues/events{/number}","events_url":"https://api.github.com/repos/jhawkesworth/ansible-modules-extras/events","assignees_url":"https://api.github.com/repos/jhawkesworth/ansible-modules-extras/assignees{/user}","branches_url":"https://api.github.com/repos/jhawkesworth/ansible-modules-extras/branches{/branch}","tags_url":"https://api.github.com/repos/jhawkesworth/ansible-modules-extras/tags","blobs_url":"https://api.github.com/repos/jhawkesworth/ansible-modules-extras/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jhawkesworth/ansible-modules-extras/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jhawkesworth/ansible-modules-extras/git/refs{/sha}","trees_url":"https://api.github.com/repos/jhawkesworth/ansible-modules-extras/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jhawkesworth/ansible-modules-extras/statuses/{sha}","languages_url":"https://api.github.com/repos/jhawkesworth/ansible-modules-extras/languages","stargazers_url":"https://api.github.com/repos/jhawkesworth/ansible-modules-extras/stargazers","contributors_url":"https://api.github.com/repos/jhawkesworth/ansible-modules-extras/contributors","subscribers_url":"https://api.github.com/repos/jhawkesworth/ansible-modules-extras/subscribers","subscription_url":"https://api.github.com/repos/jhawkesworth/ansible-modules-extras/subscription","commits_url":"https://api.github.com/repos/jhawkesworth/ansible-modules-extras/commits{/sha}","git_commits_url":"https://api.github.com/repos/jhawkesworth/ansible-modules-extras/git/commits{/sha}","comments_url":"https://api.github.com/repos/jhawkesworth/ansible-modules-extras/comments{/number}","issue_comment_url":"https://api.github.com/repos/jhawkesworth/ansible-modules-extras/issues/comments{/number}","contents_url":"https://api.github.com/repos/jhawkesworth/ansible-modules-extras/contents/{+path}","compare_url":"https://api.github.com/repos/jhawkesworth/ansible-modules-extras/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jhawkesworth/ansible-modules-extras/merges","archive_url":"https://api.github.com/repos/jhawkesworth/ansible-modules-extras/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jhawkesworth/ansible-modules-extras/downloads","issues_url":"https://api.github.com/repos/jhawkesworth/ansible-modules-extras/issues{/number}","pulls_url":"https://api.github.com/repos/jhawkesworth/ansible-modules-extras/pulls{/number}","milestones_url":"https://api.github.com/repos/jhawkesworth/ansible-modules-extras/milestones{/number}","notifications_url":"https://api.github.com/repos/jhawkesworth/ansible-modules-extras/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jhawkesworth/ansible-modules-extras/labels{/name}","releases_url":"https://api.github.com/repos/jhawkesworth/ansible-modules-extras/releases{/id}","deployments_url":"https://api.github.com/repos/jhawkesworth/ansible-modules-extras/deployments","created_at":"2014-11-20T09:32:22Z","updated_at":"2016-02-09T08:29:54Z","pushed_at":"2016-06-16T05:21:21Z","git_url":"git://github.com/jhawkesworth/ansible-modules-extras.git","ssh_url":"git@github.com:jhawkesworth/ansible-modules-extras.git","clone_url":"https://github.com/jhawkesworth/ansible-modules-extras.git","svn_url":"https://github.com/jhawkesworth/ansible-modules-extras","homepage":"","size":7268,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"devel"}},"base":{"label":"ansible:devel","ref":"devel","sha":"eed9d601b5b727586e16f3afa5824031dfbc88df","user":{"login":"ansible","id":1507452,"avatar_url":"https://avatars.githubusercontent.com/u/1507452?v=3","gravatar_id":"","url":"https://api.github.com/users/ansible","html_url":"https://github.com/ansible","followers_url":"https://api.github.com/users/ansible/followers","following_url":"https://api.github.com/users/ansible/following{/other_user}","gists_url":"https://api.github.com/users/ansible/gists{/gist_id}","starred_url":"https://api.github.com/users/ansible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansible/subscriptions","organizations_url":"https://api.github.com/users/ansible/orgs","repos_url":"https://api.github.com/users/ansible/repos","events_url":"https://api.github.com/users/ansible/events{/privacy}","received_events_url":"https://api.github.com/users/ansible/received_events","type":"Organization","site_admin":false},"repo":{"id":24474138,"name":"ansible-modules-extras","full_name":"ansible/ansible-modules-extras","owner":{"login":"ansible","id":1507452,"avatar_url":"https://avatars.githubusercontent.com/u/1507452?v=3","gravatar_id":"","url":"https://api.github.com/users/ansible","html_url":"https://github.com/ansible","followers_url":"https://api.github.com/users/ansible/followers","following_url":"https://api.github.com/users/ansible/following{/other_user}","gists_url":"https://api.github.com/users/ansible/gists{/gist_id}","starred_url":"https://api.github.com/users/ansible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansible/subscriptions","organizations_url":"https://api.github.com/users/ansible/orgs","repos_url":"https://api.github.com/users/ansible/repos","events_url":"https://api.github.com/users/ansible/events{/privacy}","received_events_url":"https://api.github.com/users/ansible/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ansible/ansible-modules-extras","description":"Ansible extra modules - these modules ship with ansible","fork":false,"url":"https://api.github.com/repos/ansible/ansible-modules-extras","forks_url":"https://api.github.com/repos/ansible/ansible-modules-extras/forks","keys_url":"https://api.github.com/repos/ansible/ansible-modules-extras/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ansible/ansible-modules-extras/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ansible/ansible-modules-extras/teams","hooks_url":"https://api.github.com/repos/ansible/ansible-modules-extras/hooks","issue_events_url":"https://api.github.com/repos/ansible/ansible-modules-extras/issues/events{/number}","events_url":"https://api.github.com/repos/ansible/ansible-modules-extras/events","assignees_url":"https://api.github.com/repos/ansible/ansible-modules-extras/assignees{/user}","branches_url":"https://api.github.com/repos/ansible/ansible-modules-extras/branches{/branch}","tags_url":"https://api.github.com/repos/ansible/ansible-modules-extras/tags","blobs_url":"https://api.github.com/repos/ansible/ansible-modules-extras/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ansible/ansible-modules-extras/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ansible/ansible-modules-extras/git/refs{/sha}","trees_url":"https://api.github.com/repos/ansible/ansible-modules-extras/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ansible/ansible-modules-extras/statuses/{sha}","languages_url":"https://api.github.com/repos/ansible/ansible-modules-extras/languages","stargazers_url":"https://api.github.com/repos/ansible/ansible-modules-extras/stargazers","contributors_url":"https://api.github.com/repos/ansible/ansible-modules-extras/contributors","subscribers_url":"https://api.github.com/repos/ansible/ansible-modules-extras/subscribers","subscription_url":"https://api.github.com/repos/ansible/ansible-modules-extras/subscription","commits_url":"https://api.github.com/repos/ansible/ansible-modules-extras/commits{/sha}","git_commits_url":"https://api.github.com/repos/ansible/ansible-modules-extras/git/commits{/sha}","comments_url":"https://api.github.com/repos/ansible/ansible-modules-extras/comments{/number}","issue_comment_url":"https://api.github.com/repos/ansible/ansible-modules-extras/issues/comments{/number}","contents_url":"https://api.github.com/repos/ansible/ansible-modules-extras/contents/{+path}","compare_url":"https://api.github.com/repos/ansible/ansible-modules-extras/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ansible/ansible-modules-extras/merges","archive_url":"https://api.github.com/repos/ansible/ansible-modules-extras/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ansible/ansible-modules-extras/downloads","issues_url":"https://api.github.com/repos/ansible/ansible-modules-extras/issues{/number}","pulls_url":"https://api.github.com/repos/ansible/ansible-modules-extras/pulls{/number}","milestones_url":"https://api.github.com/repos/ansible/ansible-modules-extras/milestones{/number}","notifications_url":"https://api.github.com/repos/ansible/ansible-modules-extras/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ansible/ansible-modules-extras/labels{/name}","releases_url":"https://api.github.com/repos/ansible/ansible-modules-extras/releases{/id}","deployments_url":"https://api.github.com/repos/ansible/ansible-modules-extras/deployments","created_at":"2014-09-25T20:28:42Z","updated_at":"2016-06-15T17:04:45Z","pushed_at":"2016-06-16T05:33:58Z","git_url":"git://github.com/ansible/ansible-modules-extras.git","ssh_url":"git@github.com:ansible/ansible-modules-extras.git","clone_url":"https://github.com/ansible/ansible-modules-extras.git","svn_url":"https://github.com/ansible/ansible-modules-extras","homepage":"","size":44699,"stargazers_count":608,"watchers_count":608,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1271,"mirror_url":null,"open_issues_count":619,"forks":1271,"open_issues":619,"watchers":608,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/ansible/ansible-modules-extras/pulls/2436"},"html":{"href":"https://github.com/ansible/ansible-modules-extras/pull/2436"},"issue":{"href":"https://api.github.com/repos/ansible/ansible-modules-extras/issues/2436"},"comments":{"href":"https://api.github.com/repos/ansible/ansible-modules-extras/issues/2436/comments"},"review_comments":{"href":"https://api.github.com/repos/ansible/ansible-modules-extras/pulls/2436/comments"},"review_comment":{"href":"https://api.github.com/repos/ansible/ansible-modules-extras/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ansible/ansible-modules-extras/pulls/2436/commits"},"statuses":{"href":"https://api.github.com/repos/ansible/ansible-modules-extras/statuses/bc3e6e0e9039ecf38f7794747f0333f6e01c3e97"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":18,"deletions":6,"changed_files":2}}
{"actor":{"display_login":"jhawkesworth"}}