{"action":"created","comment":{"url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments/80966332","pull_request_review_id":1982094,"id":80966332,"diff_hunk":"@@ -2984,15 +2984,16 @@ inline void appendErr3(MemoryBuffer &reply, unsigned e, int code, const char *er\n     reply.append(e);\n     reply.append(msg.str());\n }\n-inline void appendCmdErr(MemoryBuffer &reply, unsigned e, int code, const char *errMsg)\n+inline void appendCmdErr(MemoryBuffer &reply, RemoteFileCommandType e, int code, const char *errMsg)\n {\n     StringBuffer msg;\n     msg.appendf(\"ERROR: %s(%d) '%s'\", getRFCText(e), code, errMsg?errMsg:\"\");\n     // RFCOpenIO needs remapping to non-zero for client to know its an error\n     // perhaps we should use code here instead of e ?\n-    if ((RemoteFileCommandType)e == RFCopenIO)\n-        e = RFSERR_OpenFailed;\n-    reply.append(e);\n+    unsigned err = e;\n+    if ((RemoteFileCommandType)err == RFCopenIO)","path":"common/remote/sockfile.cpp","position":null,"original_position":24,"commit_id":"ac6be63b64eda4735ec7991b5cdaaa178c7639da","original_commit_id":"ac6be63b64eda4735ec7991b5cdaaa178c7639da","user":{"login":"mckellyln","id":5116200,"avatar_url":"https://avatars.githubusercontent.com/u/5116200?v=3","gravatar_id":"","url":"https://api.github.com/users/mckellyln","html_url":"https://github.com/mckellyln","followers_url":"https://api.github.com/users/mckellyln/followers","following_url":"https://api.github.com/users/mckellyln/following{/other_user}","gists_url":"https://api.github.com/users/mckellyln/gists{/gist_id}","starred_url":"https://api.github.com/users/mckellyln/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mckellyln/subscriptions","organizations_url":"https://api.github.com/users/mckellyln/orgs","repos_url":"https://api.github.com/users/mckellyln/repos","events_url":"https://api.github.com/users/mckellyln/events{/privacy}","received_events_url":"https://api.github.com/users/mckellyln/received_events","type":"User","site_admin":false},"body":"ok, will do","created_at":"2016-09-28T16:59:26Z","updated_at":"2016-09-28T16:59:26Z","html_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/9182#discussion_r80966332","pull_request_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/9182","_links":{"self":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments/80966332"},"html":{"href":"https://github.com/hpcc-systems/HPCC-Platform/pull/9182#discussion_r80966332"},"pull_request":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/9182"}}},"pull_request":{"url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/9182","id":87000305,"html_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/9182","diff_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/9182.diff","patch_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/9182.patch","issue_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/9182","number":9182,"state":"open","locked":false,"title":"HPCC-16271 Dafilesrv copyfile exception crash","user":{"login":"mckellyln","id":5116200,"avatar_url":"https://avatars.githubusercontent.com/u/5116200?v=3","gravatar_id":"","url":"https://api.github.com/users/mckellyln","html_url":"https://github.com/mckellyln","followers_url":"https://api.github.com/users/mckellyln/followers","following_url":"https://api.github.com/users/mckellyln/following{/other_user}","gists_url":"https://api.github.com/users/mckellyln/gists{/gist_id}","starred_url":"https://api.github.com/users/mckellyln/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mckellyln/subscriptions","organizations_url":"https://api.github.com/users/mckellyln/orgs","repos_url":"https://api.github.com/users/mckellyln/repos","events_url":"https://api.github.com/users/mckellyln/events{/privacy}","received_events_url":"https://api.github.com/users/mckellyln/received_events","type":"User","site_admin":false},"body":"Note this problem only occurs with version 5.4.10 because issue is solved with https://track.hpccsystems.com/browse/HPCC-14888 (https://github.com/hpcc-systems/HPCC-Platform/pull/8192) that went into version 5.6.0\r\n\r\nThis update extends the solution to return a more correct error string that matches the error value passed in.\r\n\r\nSigned-off-by: Mark Kelly <mark.kelly@lexisnexis.com>","created_at":"2016-09-27T19:57:37Z","updated_at":"2016-09-28T16:59:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"33ae43a6c9bbfed509e8abe8a5e8b13755a8c3a8","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/9182/commits","review_comments_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/9182/comments","review_comment_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/9182/comments","statuses_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/statuses/ac6be63b64eda4735ec7991b5cdaaa178c7639da","head":{"label":"mckellyln:hpcc-16271b","ref":"hpcc-16271b","sha":"ac6be63b64eda4735ec7991b5cdaaa178c7639da","user":{"login":"mckellyln","id":5116200,"avatar_url":"https://avatars.githubusercontent.com/u/5116200?v=3","gravatar_id":"","url":"https://api.github.com/users/mckellyln","html_url":"https://github.com/mckellyln","followers_url":"https://api.github.com/users/mckellyln/followers","following_url":"https://api.github.com/users/mckellyln/following{/other_user}","gists_url":"https://api.github.com/users/mckellyln/gists{/gist_id}","starred_url":"https://api.github.com/users/mckellyln/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mckellyln/subscriptions","organizations_url":"https://api.github.com/users/mckellyln/orgs","repos_url":"https://api.github.com/users/mckellyln/repos","events_url":"https://api.github.com/users/mckellyln/events{/privacy}","received_events_url":"https://api.github.com/users/mckellyln/received_events","type":"User","site_admin":false},"repo":{"id":12089496,"name":"HPCC-Platform","full_name":"mckellyln/HPCC-Platform","owner":{"login":"mckellyln","id":5116200,"avatar_url":"https://avatars.githubusercontent.com/u/5116200?v=3","gravatar_id":"","url":"https://api.github.com/users/mckellyln","html_url":"https://github.com/mckellyln","followers_url":"https://api.github.com/users/mckellyln/followers","following_url":"https://api.github.com/users/mckellyln/following{/other_user}","gists_url":"https://api.github.com/users/mckellyln/gists{/gist_id}","starred_url":"https://api.github.com/users/mckellyln/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mckellyln/subscriptions","organizations_url":"https://api.github.com/users/mckellyln/orgs","repos_url":"https://api.github.com/users/mckellyln/repos","events_url":"https://api.github.com/users/mckellyln/events{/privacy}","received_events_url":"https://api.github.com/users/mckellyln/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mckellyln/HPCC-Platform","description":"IMPORTANT - Issue tracking has been migrated to JIRA - use your github ID and password reset mechanism to log in","fork":true,"url":"https://api.github.com/repos/mckellyln/HPCC-Platform","forks_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/forks","keys_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/teams","hooks_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/hooks","issue_events_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/issues/events{/number}","events_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/events","assignees_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/assignees{/user}","branches_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/branches{/branch}","tags_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/tags","blobs_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/statuses/{sha}","languages_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/languages","stargazers_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/stargazers","contributors_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/contributors","subscribers_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/subscribers","subscription_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/subscription","commits_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/contents/{+path}","compare_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/merges","archive_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/downloads","issues_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/issues{/number}","pulls_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/pulls{/number}","milestones_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/milestones{/number}","notifications_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/labels{/name}","releases_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/releases{/id}","deployments_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/deployments","created_at":"2013-08-13T18:39:30Z","updated_at":"2015-05-06T15:40:27Z","pushed_at":"2016-09-28T16:40:18Z","git_url":"git://github.com/mckellyln/HPCC-Platform.git","ssh_url":"git@github.com:mckellyln/HPCC-Platform.git","clone_url":"https://github.com/mckellyln/HPCC-Platform.git","svn_url":"https://github.com/mckellyln/HPCC-Platform","homepage":"track.hpccsystems.com","size":154655,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hpcc-systems:master","ref":"master","sha":"24b7587cc75d95c63a66ac29970921a4a32a5d67","user":{"login":"hpcc-systems","id":900867,"avatar_url":"https://avatars.githubusercontent.com/u/900867?v=3","gravatar_id":"","url":"https://api.github.com/users/hpcc-systems","html_url":"https://github.com/hpcc-systems","followers_url":"https://api.github.com/users/hpcc-systems/followers","following_url":"https://api.github.com/users/hpcc-systems/following{/other_user}","gists_url":"https://api.github.com/users/hpcc-systems/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcc-systems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcc-systems/subscriptions","organizations_url":"https://api.github.com/users/hpcc-systems/orgs","repos_url":"https://api.github.com/users/hpcc-systems/repos","events_url":"https://api.github.com/users/hpcc-systems/events{/privacy}","received_events_url":"https://api.github.com/users/hpcc-systems/received_events","type":"Organization","site_admin":false},"repo":{"id":2030681,"name":"HPCC-Platform","full_name":"hpcc-systems/HPCC-Platform","owner":{"login":"hpcc-systems","id":900867,"avatar_url":"https://avatars.githubusercontent.com/u/900867?v=3","gravatar_id":"","url":"https://api.github.com/users/hpcc-systems","html_url":"https://github.com/hpcc-systems","followers_url":"https://api.github.com/users/hpcc-systems/followers","following_url":"https://api.github.com/users/hpcc-systems/following{/other_user}","gists_url":"https://api.github.com/users/hpcc-systems/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcc-systems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcc-systems/subscriptions","organizations_url":"https://api.github.com/users/hpcc-systems/orgs","repos_url":"https://api.github.com/users/hpcc-systems/repos","events_url":"https://api.github.com/users/hpcc-systems/events{/privacy}","received_events_url":"https://api.github.com/users/hpcc-systems/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hpcc-systems/HPCC-Platform","description":"HPCC Systems (High Performance Computing Cluster) is an open source, massive parallel-processing computing platform for big data processing and analytics.","fork":false,"url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform","forks_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/forks","keys_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/teams","hooks_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/hooks","issue_events_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/events{/number}","events_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/events","assignees_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/assignees{/user}","branches_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/branches{/branch}","tags_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/tags","blobs_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/statuses/{sha}","languages_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/languages","stargazers_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/stargazers","contributors_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/contributors","subscribers_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/subscribers","subscription_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/subscription","commits_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/contents/{+path}","compare_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/merges","archive_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/downloads","issues_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues{/number}","pulls_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls{/number}","milestones_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/milestones{/number}","notifications_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/labels{/name}","releases_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/releases{/id}","deployments_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/deployments","created_at":"2011-07-11T14:29:51Z","updated_at":"2016-09-28T09:54:22Z","pushed_at":"2016-09-28T16:56:04Z","git_url":"git://github.com/hpcc-systems/HPCC-Platform.git","ssh_url":"git@github.com:hpcc-systems/HPCC-Platform.git","clone_url":"https://github.com/hpcc-systems/HPCC-Platform.git","svn_url":"https://github.com/hpcc-systems/HPCC-Platform","homepage":"http://hpccsystems.com","size":184109,"stargazers_count":288,"watchers_count":288,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":153,"mirror_url":null,"open_issues_count":424,"forks":153,"open_issues":424,"watchers":288,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/9182"},"html":{"href":"https://github.com/hpcc-systems/HPCC-Platform/pull/9182"},"issue":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/9182"},"comments":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/9182/comments"},"review_comments":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/9182/comments"},"review_comment":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/9182/commits"},"statuses":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/statuses/ac6be63b64eda4735ec7991b5cdaaa178c7639da"}}}}
{"actor":{"display_login":"mckellyln"}}