{"action":"created","issue":{"url":"https://api.github.com/repos/docker/docker/issues/27951","repository_url":"https://api.github.com/repos/docker/docker","labels_url":"https://api.github.com/repos/docker/docker/issues/27951/labels{/name}","comments_url":"https://api.github.com/repos/docker/docker/issues/27951/comments","events_url":"https://api.github.com/repos/docker/docker/issues/27951/events","html_url":"https://github.com/docker/docker/pull/27951","id":186554932,"number":27951,"title":"daemon: always dump stack to file","user":{"login":"LK4D4","id":101445,"avatar_url":"https://avatars.githubusercontent.com/u/101445?v=3","gravatar_id":"","url":"https://api.github.com/users/LK4D4","html_url":"https://github.com/LK4D4","followers_url":"https://api.github.com/users/LK4D4/followers","following_url":"https://api.github.com/users/LK4D4/following{/other_user}","gists_url":"https://api.github.com/users/LK4D4/gists{/gist_id}","starred_url":"https://api.github.com/users/LK4D4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LK4D4/subscriptions","organizations_url":"https://api.github.com/users/LK4D4/orgs","repos_url":"https://api.github.com/users/LK4D4/repos","events_url":"https://api.github.com/users/LK4D4/events{/privacy}","received_events_url":"https://api.github.com/users/LK4D4/received_events","type":"User","site_admin":false},"labels":[{"id":175374554,"url":"https://api.github.com/repos/docker/docker/labels/status/0-triage","name":"status/0-triage","color":"EEEEEE","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-11-01T14:56:21Z","updated_at":"2016-11-01T14:56:45Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/27951","html_url":"https://github.com/docker/docker/pull/27951","diff_url":"https://github.com/docker/docker/pull/27951.diff","patch_url":"https://github.com/docker/docker/pull/27951.patch"},"body":"<!--\r\nPlease make sure you've read and understood our contributing guidelines;\r\nhttps://github.com/docker/docker/blob/master/CONTRIBUTING.md\r\n\r\n** Make sure all your commits include a signature generated with `git commit -s` **\r\n\r\nFor additional information on our contributing process, read our contributing\r\nguide https://docs.docker.com/opensource/code/\r\n\r\nIf this is a bug fix, make sure your description includes \"fixes #xxxx\", or\r\n\"closes #xxxx\"\r\n\r\nPlease provide the following information:\r\n-->\r\n\r\n**- What I did**\r\nDumping to log is unusable in 90% of cases and inspecting file is much\r\nmore convenient.\r\nSo, I've changed the code to dump of goroutine traces is always written to file.\r\n**- How I did it**\r\nChanged signature of `DumpStacks` so it returns path where the stack is written and error. Removed all logging from there.\r\n**- How to verify it**\r\nSend `SIGUSR1` to daemon, in logs, there will be something like:\r\n```\r\nINFO[0013] goroutine stacks written to /var/lib/docker/goroutine-stacks.log\r\n```\r\n**- Description for the changelog**\r\nNever dump goroutine stack to log, only to file\r\n\r\n\r\n**- A picture of a cute animal (not mandatory but encouraged)**\r\n![cat](http://i.imgur.com/4oXNmAZ.jpg)\r\n\r\nSigned-off-by: Alexander Morozov <lk4d4@docker.com>"},"comment":{"url":"https://api.github.com/repos/docker/docker/issues/comments/257588141","html_url":"https://github.com/docker/docker/pull/27951#issuecomment-257588141","issue_url":"https://api.github.com/repos/docker/docker/issues/27951","id":257588141,"user":{"login":"LK4D4","id":101445,"avatar_url":"https://avatars.githubusercontent.com/u/101445?v=3","gravatar_id":"","url":"https://api.github.com/users/LK4D4","html_url":"https://github.com/LK4D4","followers_url":"https://api.github.com/users/LK4D4/followers","following_url":"https://api.github.com/users/LK4D4/following{/other_user}","gists_url":"https://api.github.com/users/LK4D4/gists{/gist_id}","starred_url":"https://api.github.com/users/LK4D4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LK4D4/subscriptions","organizations_url":"https://api.github.com/users/LK4D4/orgs","repos_url":"https://api.github.com/users/LK4D4/repos","events_url":"https://api.github.com/users/LK4D4/events{/privacy}","received_events_url":"https://api.github.com/users/LK4D4/received_events","type":"User","site_admin":false},"created_at":"2016-11-01T14:56:44Z","updated_at":"2016-11-01T14:56:44Z","body":"ping @aaronlehmann "}}
{"actor":{"display_login":"LK4D4"}}