{"action":"created","issue":{"url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/issues/414","repository_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow","labels_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/issues/414/labels{/name}","comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/issues/414/comments","events_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/issues/414/events","html_url":"https://github.com/spring-cloud/spring-cloud-dataflow/pull/414","id":134256829,"number":414,"title":"Add additional env vars to deployed module","user":{"login":"dsyer","id":124075,"avatar_url":"https://avatars.githubusercontent.com/u/124075?v=3","gravatar_id":"","url":"https://api.github.com/users/dsyer","html_url":"https://github.com/dsyer","followers_url":"https://api.github.com/users/dsyer/followers","following_url":"https://api.github.com/users/dsyer/following{/other_user}","gists_url":"https://api.github.com/users/dsyer/gists{/gist_id}","starred_url":"https://api.github.com/users/dsyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsyer/subscriptions","organizations_url":"https://api.github.com/users/dsyer/orgs","repos_url":"https://api.github.com/users/dsyer/repos","events_url":"https://api.github.com/users/dsyer/events{/privacy}","received_events_url":"https://api.github.com/users/dsyer/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/labels/in%20pr","name":"in pr","color":"006b75"}],"state":"open","locked":false,"assignee":{"login":"markpollack","id":247466,"avatar_url":"https://avatars.githubusercontent.com/u/247466?v=3","gravatar_id":"","url":"https://api.github.com/users/markpollack","html_url":"https://github.com/markpollack","followers_url":"https://api.github.com/users/markpollack/followers","following_url":"https://api.github.com/users/markpollack/following{/other_user}","gists_url":"https://api.github.com/users/markpollack/gists{/gist_id}","starred_url":"https://api.github.com/users/markpollack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markpollack/subscriptions","organizations_url":"https://api.github.com/users/markpollack/orgs","repos_url":"https://api.github.com/users/markpollack/repos","events_url":"https://api.github.com/users/markpollack/events{/privacy}","received_events_url":"https://api.github.com/users/markpollack/received_events","type":"User","site_admin":false},"milestone":null,"comments":7,"created_at":"2016-02-17T11:39:11Z","updated_at":"2016-03-02T13:34:35Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls/414","html_url":"https://github.com/spring-cloud/spring-cloud-dataflow/pull/414","diff_url":"https://github.com/spring-cloud/spring-cloud-dataflow/pull/414.diff","patch_url":"https://github.com/spring-cloud/spring-cloud-dataflow/pull/414.patch"},"body":"User can specify additional command line args like this in the\r\nlocal deployer app:\r\n\r\n```\r\ndeployer:\r\n  local:\r\n    sharedArgs:\r\n      includes: org.springframework.cloud:spring-cloud-starter-config:1.1.0.BUILD-SNAPSHOT\r\n      spring.application.name: ${module.label}\r\n      spring.cloud.config.uri: http://localhost:8888\r\n```\r\n\r\nThen all modules are launched with \"includes\" on the classpath\r\nand enough information to bootstrap the config client.\r\n\r\nThe \"includes\" is a feature of the module launcher, and it is a\r\ncomma separated list, so we have to be careful to merge\r\nmodule and deployment specific arguments with the same name."},"comment":{"url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/issues/comments/191239723","html_url":"https://github.com/spring-cloud/spring-cloud-dataflow/pull/414#issuecomment-191239723","issue_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/issues/414","id":191239723,"user":{"login":"ericbottard","id":313494,"avatar_url":"https://avatars.githubusercontent.com/u/313494?v=3","gravatar_id":"","url":"https://api.github.com/users/ericbottard","html_url":"https://github.com/ericbottard","followers_url":"https://api.github.com/users/ericbottard/followers","following_url":"https://api.github.com/users/ericbottard/following{/other_user}","gists_url":"https://api.github.com/users/ericbottard/gists{/gist_id}","starred_url":"https://api.github.com/users/ericbottard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericbottard/subscriptions","organizations_url":"https://api.github.com/users/ericbottard/orgs","repos_url":"https://api.github.com/users/ericbottard/repos","events_url":"https://api.github.com/users/ericbottard/events{/privacy}","received_events_url":"https://api.github.com/users/ericbottard/received_events","type":"User","site_admin":false},"created_at":"2016-03-02T13:34:35Z","updated_at":"2016-03-02T13:34:35Z","body":"Irrespective of whether we merge this as-is or not, could we consider adding this functionality to _any_ deployer (_i.e._ not make the keys deployer.**local**.sharedArgs but just deployer.sharedArgs)"}}