{"action":"created","comment":{"url":"https://api.github.com/repos/swarrot/swarrot/pulls/comments/65190182","id":65190182,"diff_hunk":"@@ -93,4 +80,29 @@ public function setDefaultOptions(OptionsResolver $resolver)\n             ));\n         }\n     }\n+\n+    /**\n+     * @param Throwable|Exception  $exception","path":"src/Swarrot/Processor/Ack/AckProcessor.php","position":null,"original_position":33,"commit_id":"84df882fa3cf57735f4910aa819cb2dc7ccd19b9","original_commit_id":"94328888a1f0562eb4b36db4a62922c20e93cc19","user":{"login":"MattKetmo","id":334996,"avatar_url":"https://avatars.githubusercontent.com/u/334996?v=3","gravatar_id":"","url":"https://api.github.com/users/MattKetmo","html_url":"https://github.com/MattKetmo","followers_url":"https://api.github.com/users/MattKetmo/followers","following_url":"https://api.github.com/users/MattKetmo/following{/other_user}","gists_url":"https://api.github.com/users/MattKetmo/gists{/gist_id}","starred_url":"https://api.github.com/users/MattKetmo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MattKetmo/subscriptions","organizations_url":"https://api.github.com/users/MattKetmo/orgs","repos_url":"https://api.github.com/users/MattKetmo/repos","events_url":"https://api.github.com/users/MattKetmo/events{/privacy}","received_events_url":"https://api.github.com/users/MattKetmo/received_events","type":"User","site_admin":false},"body":"Fixed","created_at":"2016-05-31T14:20:21Z","updated_at":"2016-05-31T14:20:21Z","html_url":"https://github.com/swarrot/swarrot/pull/129#discussion_r65190182","pull_request_url":"https://api.github.com/repos/swarrot/swarrot/pulls/129","_links":{"self":{"href":"https://api.github.com/repos/swarrot/swarrot/pulls/comments/65190182"},"html":{"href":"https://github.com/swarrot/swarrot/pull/129#discussion_r65190182"},"pull_request":{"href":"https://api.github.com/repos/swarrot/swarrot/pulls/129"}}},"pull_request":{"url":"https://api.github.com/repos/swarrot/swarrot/pulls/129","id":71911058,"html_url":"https://github.com/swarrot/swarrot/pull/129","diff_url":"https://github.com/swarrot/swarrot/pull/129.diff","patch_url":"https://github.com/swarrot/swarrot/pull/129.patch","issue_url":"https://api.github.com/repos/swarrot/swarrot/issues/129","number":129,"state":"open","locked":false,"title":"Catch PHP7 Throwable","user":{"login":"MattKetmo","id":334996,"avatar_url":"https://avatars.githubusercontent.com/u/334996?v=3","gravatar_id":"","url":"https://api.github.com/users/MattKetmo","html_url":"https://github.com/MattKetmo","followers_url":"https://api.github.com/users/MattKetmo/followers","following_url":"https://api.github.com/users/MattKetmo/following{/other_user}","gists_url":"https://api.github.com/users/MattKetmo/gists{/gist_id}","starred_url":"https://api.github.com/users/MattKetmo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MattKetmo/subscriptions","organizations_url":"https://api.github.com/users/MattKetmo/orgs","repos_url":"https://api.github.com/users/MattKetmo/repos","events_url":"https://api.github.com/users/MattKetmo/events{/privacy}","received_events_url":"https://api.github.com/users/MattKetmo/received_events","type":"User","site_admin":false},"body":"Catching Throwable helps to catch a larger range of errors since PHP 7 (and avoid a worker to break while it's running).\r\n\r\nHere I duplicated the `catch \\Exception` block in order to keep the compatibility with PHP 5.\r\n\r\nNote that this logic must be applied in other places:\r\n- AckProcessor\r\n- InstantRetryProcessor\r\n- NewRelicProcessor\r\n- RetryProcessor (need merging #113 first)","created_at":"2016-05-30T14:47:11Z","updated_at":"2016-05-31T14:20:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dac99ace4ae7ddeae73bb4a0f8f7c1e75534c019","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/swarrot/swarrot/pulls/129/commits","review_comments_url":"https://api.github.com/repos/swarrot/swarrot/pulls/129/comments","review_comment_url":"https://api.github.com/repos/swarrot/swarrot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/swarrot/swarrot/issues/129/comments","statuses_url":"https://api.github.com/repos/swarrot/swarrot/statuses/84df882fa3cf57735f4910aa819cb2dc7ccd19b9","head":{"label":"MattKetmo:throwable","ref":"throwable","sha":"84df882fa3cf57735f4910aa819cb2dc7ccd19b9","user":{"login":"MattKetmo","id":334996,"avatar_url":"https://avatars.githubusercontent.com/u/334996?v=3","gravatar_id":"","url":"https://api.github.com/users/MattKetmo","html_url":"https://github.com/MattKetmo","followers_url":"https://api.github.com/users/MattKetmo/followers","following_url":"https://api.github.com/users/MattKetmo/following{/other_user}","gists_url":"https://api.github.com/users/MattKetmo/gists{/gist_id}","starred_url":"https://api.github.com/users/MattKetmo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MattKetmo/subscriptions","organizations_url":"https://api.github.com/users/MattKetmo/orgs","repos_url":"https://api.github.com/users/MattKetmo/repos","events_url":"https://api.github.com/users/MattKetmo/events{/privacy}","received_events_url":"https://api.github.com/users/MattKetmo/received_events","type":"User","site_admin":false},"repo":{"id":37329567,"name":"swarrot","full_name":"MattKetmo/swarrot","owner":{"login":"MattKetmo","id":334996,"avatar_url":"https://avatars.githubusercontent.com/u/334996?v=3","gravatar_id":"","url":"https://api.github.com/users/MattKetmo","html_url":"https://github.com/MattKetmo","followers_url":"https://api.github.com/users/MattKetmo/followers","following_url":"https://api.github.com/users/MattKetmo/following{/other_user}","gists_url":"https://api.github.com/users/MattKetmo/gists{/gist_id}","starred_url":"https://api.github.com/users/MattKetmo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MattKetmo/subscriptions","organizations_url":"https://api.github.com/users/MattKetmo/orgs","repos_url":"https://api.github.com/users/MattKetmo/repos","events_url":"https://api.github.com/users/MattKetmo/events{/privacy}","received_events_url":"https://api.github.com/users/MattKetmo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MattKetmo/swarrot","description":"A lib to consume message from any Broker","fork":true,"url":"https://api.github.com/repos/MattKetmo/swarrot","forks_url":"https://api.github.com/repos/MattKetmo/swarrot/forks","keys_url":"https://api.github.com/repos/MattKetmo/swarrot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MattKetmo/swarrot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MattKetmo/swarrot/teams","hooks_url":"https://api.github.com/repos/MattKetmo/swarrot/hooks","issue_events_url":"https://api.github.com/repos/MattKetmo/swarrot/issues/events{/number}","events_url":"https://api.github.com/repos/MattKetmo/swarrot/events","assignees_url":"https://api.github.com/repos/MattKetmo/swarrot/assignees{/user}","branches_url":"https://api.github.com/repos/MattKetmo/swarrot/branches{/branch}","tags_url":"https://api.github.com/repos/MattKetmo/swarrot/tags","blobs_url":"https://api.github.com/repos/MattKetmo/swarrot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MattKetmo/swarrot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MattKetmo/swarrot/git/refs{/sha}","trees_url":"https://api.github.com/repos/MattKetmo/swarrot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MattKetmo/swarrot/statuses/{sha}","languages_url":"https://api.github.com/repos/MattKetmo/swarrot/languages","stargazers_url":"https://api.github.com/repos/MattKetmo/swarrot/stargazers","contributors_url":"https://api.github.com/repos/MattKetmo/swarrot/contributors","subscribers_url":"https://api.github.com/repos/MattKetmo/swarrot/subscribers","subscription_url":"https://api.github.com/repos/MattKetmo/swarrot/subscription","commits_url":"https://api.github.com/repos/MattKetmo/swarrot/commits{/sha}","git_commits_url":"https://api.github.com/repos/MattKetmo/swarrot/git/commits{/sha}","comments_url":"https://api.github.com/repos/MattKetmo/swarrot/comments{/number}","issue_comment_url":"https://api.github.com/repos/MattKetmo/swarrot/issues/comments{/number}","contents_url":"https://api.github.com/repos/MattKetmo/swarrot/contents/{+path}","compare_url":"https://api.github.com/repos/MattKetmo/swarrot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MattKetmo/swarrot/merges","archive_url":"https://api.github.com/repos/MattKetmo/swarrot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MattKetmo/swarrot/downloads","issues_url":"https://api.github.com/repos/MattKetmo/swarrot/issues{/number}","pulls_url":"https://api.github.com/repos/MattKetmo/swarrot/pulls{/number}","milestones_url":"https://api.github.com/repos/MattKetmo/swarrot/milestones{/number}","notifications_url":"https://api.github.com/repos/MattKetmo/swarrot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MattKetmo/swarrot/labels{/name}","releases_url":"https://api.github.com/repos/MattKetmo/swarrot/releases{/id}","deployments_url":"https://api.github.com/repos/MattKetmo/swarrot/deployments","created_at":"2015-06-12T15:27:22Z","updated_at":"2015-06-12T15:27:22Z","pushed_at":"2016-05-31T14:20:11Z","git_url":"git://github.com/MattKetmo/swarrot.git","ssh_url":"git@github.com:MattKetmo/swarrot.git","clone_url":"https://github.com/MattKetmo/swarrot.git","svn_url":"https://github.com/MattKetmo/swarrot","homepage":"","size":311,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"swarrot:master","ref":"master","sha":"e9be56f6a2bfb5ffd2ba0f3da2deebcd6eff3263","user":{"login":"swarrot","id":6749375,"avatar_url":"https://avatars.githubusercontent.com/u/6749375?v=3","gravatar_id":"","url":"https://api.github.com/users/swarrot","html_url":"https://github.com/swarrot","followers_url":"https://api.github.com/users/swarrot/followers","following_url":"https://api.github.com/users/swarrot/following{/other_user}","gists_url":"https://api.github.com/users/swarrot/gists{/gist_id}","starred_url":"https://api.github.com/users/swarrot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swarrot/subscriptions","organizations_url":"https://api.github.com/users/swarrot/orgs","repos_url":"https://api.github.com/users/swarrot/repos","events_url":"https://api.github.com/users/swarrot/events{/privacy}","received_events_url":"https://api.github.com/users/swarrot/received_events","type":"Organization","site_admin":false},"repo":{"id":17061305,"name":"swarrot","full_name":"swarrot/swarrot","owner":{"login":"swarrot","id":6749375,"avatar_url":"https://avatars.githubusercontent.com/u/6749375?v=3","gravatar_id":"","url":"https://api.github.com/users/swarrot","html_url":"https://github.com/swarrot","followers_url":"https://api.github.com/users/swarrot/followers","following_url":"https://api.github.com/users/swarrot/following{/other_user}","gists_url":"https://api.github.com/users/swarrot/gists{/gist_id}","starred_url":"https://api.github.com/users/swarrot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swarrot/subscriptions","organizations_url":"https://api.github.com/users/swarrot/orgs","repos_url":"https://api.github.com/users/swarrot/repos","events_url":"https://api.github.com/users/swarrot/events{/privacy}","received_events_url":"https://api.github.com/users/swarrot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/swarrot/swarrot","description":"A lib to consume message from any Broker","fork":false,"url":"https://api.github.com/repos/swarrot/swarrot","forks_url":"https://api.github.com/repos/swarrot/swarrot/forks","keys_url":"https://api.github.com/repos/swarrot/swarrot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/swarrot/swarrot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/swarrot/swarrot/teams","hooks_url":"https://api.github.com/repos/swarrot/swarrot/hooks","issue_events_url":"https://api.github.com/repos/swarrot/swarrot/issues/events{/number}","events_url":"https://api.github.com/repos/swarrot/swarrot/events","assignees_url":"https://api.github.com/repos/swarrot/swarrot/assignees{/user}","branches_url":"https://api.github.com/repos/swarrot/swarrot/branches{/branch}","tags_url":"https://api.github.com/repos/swarrot/swarrot/tags","blobs_url":"https://api.github.com/repos/swarrot/swarrot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/swarrot/swarrot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/swarrot/swarrot/git/refs{/sha}","trees_url":"https://api.github.com/repos/swarrot/swarrot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/swarrot/swarrot/statuses/{sha}","languages_url":"https://api.github.com/repos/swarrot/swarrot/languages","stargazers_url":"https://api.github.com/repos/swarrot/swarrot/stargazers","contributors_url":"https://api.github.com/repos/swarrot/swarrot/contributors","subscribers_url":"https://api.github.com/repos/swarrot/swarrot/subscribers","subscription_url":"https://api.github.com/repos/swarrot/swarrot/subscription","commits_url":"https://api.github.com/repos/swarrot/swarrot/commits{/sha}","git_commits_url":"https://api.github.com/repos/swarrot/swarrot/git/commits{/sha}","comments_url":"https://api.github.com/repos/swarrot/swarrot/comments{/number}","issue_comment_url":"https://api.github.com/repos/swarrot/swarrot/issues/comments{/number}","contents_url":"https://api.github.com/repos/swarrot/swarrot/contents/{+path}","compare_url":"https://api.github.com/repos/swarrot/swarrot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/swarrot/swarrot/merges","archive_url":"https://api.github.com/repos/swarrot/swarrot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/swarrot/swarrot/downloads","issues_url":"https://api.github.com/repos/swarrot/swarrot/issues{/number}","pulls_url":"https://api.github.com/repos/swarrot/swarrot/pulls{/number}","milestones_url":"https://api.github.com/repos/swarrot/swarrot/milestones{/number}","notifications_url":"https://api.github.com/repos/swarrot/swarrot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/swarrot/swarrot/labels{/name}","releases_url":"https://api.github.com/repos/swarrot/swarrot/releases{/id}","deployments_url":"https://api.github.com/repos/swarrot/swarrot/deployments","created_at":"2014-02-21T15:57:54Z","updated_at":"2016-05-30T18:46:44Z","pushed_at":"2016-05-31T14:20:12Z","git_url":"git://github.com/swarrot/swarrot.git","ssh_url":"git@github.com:swarrot/swarrot.git","clone_url":"https://github.com/swarrot/swarrot.git","svn_url":"https://github.com/swarrot/swarrot","homepage":"","size":367,"stargazers_count":168,"watchers_count":168,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":40,"mirror_url":null,"open_issues_count":7,"forks":40,"open_issues":7,"watchers":168,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/swarrot/swarrot/pulls/129"},"html":{"href":"https://github.com/swarrot/swarrot/pull/129"},"issue":{"href":"https://api.github.com/repos/swarrot/swarrot/issues/129"},"comments":{"href":"https://api.github.com/repos/swarrot/swarrot/issues/129/comments"},"review_comments":{"href":"https://api.github.com/repos/swarrot/swarrot/pulls/129/comments"},"review_comment":{"href":"https://api.github.com/repos/swarrot/swarrot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/swarrot/swarrot/pulls/129/commits"},"statuses":{"href":"https://api.github.com/repos/swarrot/swarrot/statuses/84df882fa3cf57735f4910aa819cb2dc7ccd19b9"}}}}
{"actor":{"display_login":"MattKetmo"}}