{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/contrib/pulls/comments/74854869","id":74854869,"diff_hunk":"@@ -0,0 +1,111 @@\n+/*\n+Copyright 2016 The Kubernetes Authors All rights reserved.\n+\n+Licensed under the Apache License, Version 2.0 (the \"License\");\n+you may not use this file except in compliance with the License.\n+You may obtain a copy of the License at\n+\n+    http://www.apache.org/licenses/LICENSE-2.0\n+\n+Unless required by applicable law or agreed to in writing, software\n+distributed under the License is distributed on an \"AS IS\" BASIS,\n+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+See the License for the specific language governing permissions and\n+limitations under the License.\n+*/\n+\n+package mungers\n+\n+import (\n+\t\"reflect\"\n+\t\"runtime\"\n+\t\"testing\"\n+\n+\t\"k8s.io/kubernetes/pkg/util/sets\"\n+)\n+\n+var (\n+\taliasYaml = `\n+aliases:\n+  team/t1:\n+    - u1\n+    - u2`\n+\n+\taliasRecursiveYaml = `\n+aliases:\n+  team/t1:\n+    - u1\n+    - u2\n+  team/t2:\n+    - team/t1\n+    - u3`\n+\n+\taliasRecursiveLoopYaml = `\n+aliases:","path":"mungegithub/mungers/blunderbuss_test.go","position":44,"original_position":44,"commit_id":"6a870eb16365c6bea01f9e770114217a3493fc25","original_commit_id":"6a870eb16365c6bea01f9e770114217a3493fc25","user":{"login":"pwittrock","id":7882754,"avatar_url":"https://avatars.githubusercontent.com/u/7882754?v=3","gravatar_id":"","url":"https://api.github.com/users/pwittrock","html_url":"https://github.com/pwittrock","followers_url":"https://api.github.com/users/pwittrock/followers","following_url":"https://api.github.com/users/pwittrock/following{/other_user}","gists_url":"https://api.github.com/users/pwittrock/gists{/gist_id}","starred_url":"https://api.github.com/users/pwittrock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pwittrock/subscriptions","organizations_url":"https://api.github.com/users/pwittrock/orgs","repos_url":"https://api.github.com/users/pwittrock/repos","events_url":"https://api.github.com/users/pwittrock/events{/privacy}","received_events_url":"https://api.github.com/users/pwittrock/received_events","type":"User","site_admin":false},"body":"Where is the recursion here?","created_at":"2016-08-15T23:36:16Z","updated_at":"2016-08-15T23:36:16Z","html_url":"https://github.com/kubernetes/contrib/pull/1536#discussion_r74854869","pull_request_url":"https://api.github.com/repos/kubernetes/contrib/pulls/1536","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/contrib/pulls/comments/74854869"},"html":{"href":"https://github.com/kubernetes/contrib/pull/1536#discussion_r74854869"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/contrib/pulls/1536"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/contrib/pulls/1536","id":81223506,"html_url":"https://github.com/kubernetes/contrib/pull/1536","diff_url":"https://github.com/kubernetes/contrib/pull/1536.diff","patch_url":"https://github.com/kubernetes/contrib/pull/1536.patch","issue_url":"https://api.github.com/repos/kubernetes/contrib/issues/1536","number":1536,"state":"open","locked":false,"title":"Specifying aliases in OWNERs files","user":{"login":"foxish","id":906471,"avatar_url":"https://avatars.githubusercontent.com/u/906471?v=3","gravatar_id":"","url":"https://api.github.com/users/foxish","html_url":"https://github.com/foxish","followers_url":"https://api.github.com/users/foxish/followers","following_url":"https://api.github.com/users/foxish/following{/other_user}","gists_url":"https://api.github.com/users/foxish/gists{/gist_id}","starred_url":"https://api.github.com/users/foxish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/foxish/subscriptions","organizations_url":"https://api.github.com/users/foxish/orgs","repos_url":"https://api.github.com/users/foxish/repos","events_url":"https://api.github.com/users/foxish/events{/privacy}","received_events_url":"https://api.github.com/users/foxish/received_events","type":"User","site_admin":false},"body":"--alias-file option can specify team aliases of the following kind:\r\n\r\n```\r\naliases:\r\n  team/t1:\r\n    - team/t2\r\n    - u2\r\n  team/t2:\r\n    - team/t3\r\n    - u3\r\n  team/t3:\r\n    - u4\r\n```\r\n\r\nThis should let us use OWNERs files better with an extra level of indirection.\r\nThings that need further thought:\r\n\r\n1. Do we want to support nested team definitions like above? (If yes, what do we do if there are cyclic loops?)\r\n2. Should the yaml file containing aliases be within the repository, or be globally consistent and supplied to mungegithub at the time of invocation?","created_at":"2016-08-13T19:01:26Z","updated_at":"2016-08-15T23:36:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7c911a4e1b4620059e4dfd681fa93d8b11deec76","assignee":{"login":"pwittrock","id":7882754,"avatar_url":"https://avatars.githubusercontent.com/u/7882754?v=3","gravatar_id":"","url":"https://api.github.com/users/pwittrock","html_url":"https://github.com/pwittrock","followers_url":"https://api.github.com/users/pwittrock/followers","following_url":"https://api.github.com/users/pwittrock/following{/other_user}","gists_url":"https://api.github.com/users/pwittrock/gists{/gist_id}","starred_url":"https://api.github.com/users/pwittrock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pwittrock/subscriptions","organizations_url":"https://api.github.com/users/pwittrock/orgs","repos_url":"https://api.github.com/users/pwittrock/repos","events_url":"https://api.github.com/users/pwittrock/events{/privacy}","received_events_url":"https://api.github.com/users/pwittrock/received_events","type":"User","site_admin":false},"assignees":[{"login":"pwittrock","id":7882754,"avatar_url":"https://avatars.githubusercontent.com/u/7882754?v=3","gravatar_id":"","url":"https://api.github.com/users/pwittrock","html_url":"https://github.com/pwittrock","followers_url":"https://api.github.com/users/pwittrock/followers","following_url":"https://api.github.com/users/pwittrock/following{/other_user}","gists_url":"https://api.github.com/users/pwittrock/gists{/gist_id}","starred_url":"https://api.github.com/users/pwittrock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pwittrock/subscriptions","organizations_url":"https://api.github.com/users/pwittrock/orgs","repos_url":"https://api.github.com/users/pwittrock/repos","events_url":"https://api.github.com/users/pwittrock/events{/privacy}","received_events_url":"https://api.github.com/users/pwittrock/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/contrib/pulls/1536/commits","review_comments_url":"https://api.github.com/repos/kubernetes/contrib/pulls/1536/comments","review_comment_url":"https://api.github.com/repos/kubernetes/contrib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/contrib/issues/1536/comments","statuses_url":"https://api.github.com/repos/kubernetes/contrib/statuses/6a870eb16365c6bea01f9e770114217a3493fc25","head":{"label":"foxish:alias-owners","ref":"alias-owners","sha":"6a870eb16365c6bea01f9e770114217a3493fc25","user":{"login":"foxish","id":906471,"avatar_url":"https://avatars.githubusercontent.com/u/906471?v=3","gravatar_id":"","url":"https://api.github.com/users/foxish","html_url":"https://github.com/foxish","followers_url":"https://api.github.com/users/foxish/followers","following_url":"https://api.github.com/users/foxish/following{/other_user}","gists_url":"https://api.github.com/users/foxish/gists{/gist_id}","starred_url":"https://api.github.com/users/foxish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/foxish/subscriptions","organizations_url":"https://api.github.com/users/foxish/orgs","repos_url":"https://api.github.com/users/foxish/repos","events_url":"https://api.github.com/users/foxish/events{/privacy}","received_events_url":"https://api.github.com/users/foxish/received_events","type":"User","site_admin":false},"repo":{"id":62414944,"name":"contrib","full_name":"foxish/contrib","owner":{"login":"foxish","id":906471,"avatar_url":"https://avatars.githubusercontent.com/u/906471?v=3","gravatar_id":"","url":"https://api.github.com/users/foxish","html_url":"https://github.com/foxish","followers_url":"https://api.github.com/users/foxish/followers","following_url":"https://api.github.com/users/foxish/following{/other_user}","gists_url":"https://api.github.com/users/foxish/gists{/gist_id}","starred_url":"https://api.github.com/users/foxish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/foxish/subscriptions","organizations_url":"https://api.github.com/users/foxish/orgs","repos_url":"https://api.github.com/users/foxish/repos","events_url":"https://api.github.com/users/foxish/events{/privacy}","received_events_url":"https://api.github.com/users/foxish/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/foxish/contrib","description":"This is a place for various components in the Kubernetes ecosystem that aren't part of the Kubernetes core. Consider creating a new repo instead.","fork":true,"url":"https://api.github.com/repos/foxish/contrib","forks_url":"https://api.github.com/repos/foxish/contrib/forks","keys_url":"https://api.github.com/repos/foxish/contrib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/foxish/contrib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/foxish/contrib/teams","hooks_url":"https://api.github.com/repos/foxish/contrib/hooks","issue_events_url":"https://api.github.com/repos/foxish/contrib/issues/events{/number}","events_url":"https://api.github.com/repos/foxish/contrib/events","assignees_url":"https://api.github.com/repos/foxish/contrib/assignees{/user}","branches_url":"https://api.github.com/repos/foxish/contrib/branches{/branch}","tags_url":"https://api.github.com/repos/foxish/contrib/tags","blobs_url":"https://api.github.com/repos/foxish/contrib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/foxish/contrib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/foxish/contrib/git/refs{/sha}","trees_url":"https://api.github.com/repos/foxish/contrib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/foxish/contrib/statuses/{sha}","languages_url":"https://api.github.com/repos/foxish/contrib/languages","stargazers_url":"https://api.github.com/repos/foxish/contrib/stargazers","contributors_url":"https://api.github.com/repos/foxish/contrib/contributors","subscribers_url":"https://api.github.com/repos/foxish/contrib/subscribers","subscription_url":"https://api.github.com/repos/foxish/contrib/subscription","commits_url":"https://api.github.com/repos/foxish/contrib/commits{/sha}","git_commits_url":"https://api.github.com/repos/foxish/contrib/git/commits{/sha}","comments_url":"https://api.github.com/repos/foxish/contrib/comments{/number}","issue_comment_url":"https://api.github.com/repos/foxish/contrib/issues/comments{/number}","contents_url":"https://api.github.com/repos/foxish/contrib/contents/{+path}","compare_url":"https://api.github.com/repos/foxish/contrib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/foxish/contrib/merges","archive_url":"https://api.github.com/repos/foxish/contrib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/foxish/contrib/downloads","issues_url":"https://api.github.com/repos/foxish/contrib/issues{/number}","pulls_url":"https://api.github.com/repos/foxish/contrib/pulls{/number}","milestones_url":"https://api.github.com/repos/foxish/contrib/milestones{/number}","notifications_url":"https://api.github.com/repos/foxish/contrib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/foxish/contrib/labels{/name}","releases_url":"https://api.github.com/repos/foxish/contrib/releases{/id}","deployments_url":"https://api.github.com/repos/foxish/contrib/deployments","created_at":"2016-07-01T19:19:18Z","updated_at":"2016-07-01T19:19:21Z","pushed_at":"2016-08-15T15:43:10Z","git_url":"git://github.com/foxish/contrib.git","ssh_url":"git@github.com:foxish/contrib.git","clone_url":"https://github.com/foxish/contrib.git","svn_url":"https://github.com/foxish/contrib","homepage":"","size":30497,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"a1e47e321e9b9c23aff67a7295418c06ec92a86f","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":40686014,"name":"contrib","full_name":"kubernetes/contrib","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/contrib","description":"This is a place for various components in the Kubernetes ecosystem that aren't part of the Kubernetes core. Consider creating a new repo instead.","fork":false,"url":"https://api.github.com/repos/kubernetes/contrib","forks_url":"https://api.github.com/repos/kubernetes/contrib/forks","keys_url":"https://api.github.com/repos/kubernetes/contrib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/contrib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/contrib/teams","hooks_url":"https://api.github.com/repos/kubernetes/contrib/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/contrib/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/contrib/events","assignees_url":"https://api.github.com/repos/kubernetes/contrib/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/contrib/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/contrib/tags","blobs_url":"https://api.github.com/repos/kubernetes/contrib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/contrib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/contrib/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/contrib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/contrib/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/contrib/languages","stargazers_url":"https://api.github.com/repos/kubernetes/contrib/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/contrib/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/contrib/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/contrib/subscription","commits_url":"https://api.github.com/repos/kubernetes/contrib/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/contrib/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/contrib/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/contrib/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/contrib/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/contrib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/contrib/merges","archive_url":"https://api.github.com/repos/kubernetes/contrib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/contrib/downloads","issues_url":"https://api.github.com/repos/kubernetes/contrib/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/contrib/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/contrib/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/contrib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/contrib/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/contrib/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/contrib/deployments","created_at":"2015-08-13T23:18:26Z","updated_at":"2016-08-15T10:24:22Z","pushed_at":"2016-08-15T23:24:07Z","git_url":"git://github.com/kubernetes/contrib.git","ssh_url":"git@github.com:kubernetes/contrib.git","clone_url":"https://github.com/kubernetes/contrib.git","svn_url":"https://github.com/kubernetes/contrib","homepage":"","size":69315,"stargazers_count":426,"watchers_count":426,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":412,"mirror_url":null,"open_issues_count":271,"forks":412,"open_issues":271,"watchers":426,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/contrib/pulls/1536"},"html":{"href":"https://github.com/kubernetes/contrib/pull/1536"},"issue":{"href":"https://api.github.com/repos/kubernetes/contrib/issues/1536"},"comments":{"href":"https://api.github.com/repos/kubernetes/contrib/issues/1536/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/contrib/pulls/1536/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/contrib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/contrib/pulls/1536/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/contrib/statuses/6a870eb16365c6bea01f9e770114217a3493fc25"}}}}
{"actor":{"display_login":"pwittrock"}}