{"push_id":1201658331,"size":1,"distinct_size":1,"ref":"refs/heads/dont-raise-unknown-http-method-low-in-stack","head":"4d345cdbf11017318e6be1153443b8558314b7cc","before":"c8fb90654a86e50b9ffd384f1fe5482ec530387d","commits":[{"sha":"4d345cdbf11017318e6be1153443b8558314b7cc","author":{"name":"Grey Baker","email":"3b9a22b598e0b0686f4e1009088178fe2bd62ecd@gmail.com"},"message":"Don't raise ActionController::UnknownHttpMethod from ActionDispatch::Static\n\nThe `ActionDispatch::Static` middleware is used low down in the stack to serve\nstatic assets before doing much processing. Since it's called from so low in\nthe stack, we don't have access to the request ID at this point, and generally\nwon't have any exception handling defined (by default `ShowExceptions` is added\nto the stack quite a bit higher and relies on logging and request ID).\n\nBefore https://github.com/rails/rails/commit/8f27d6036a2ddc3cb7a7ad98afa2666ec163c2c3\nthis middleware would ignore unknown HTTP methods, and an exception about these\nwould be raised higher in the stack. After that commit, however, that exception\nwill be raised here.\n\nIf we want to keep `ActionDispatch::Static` so low in the stack (I think we do)\nwe should suppress the `ActionController::UnknownHttpMethod` exception here,\nand instead let it be raised higher up the stack, once we've had a chance to\ndefine exception handling behaviour.\n\nThis PR updates `ActionDispatch::Static` so it passes `Rack::Request` objects to\n`ActionDispatch::FileHandler`, which won't raise an\n`ActionController::UnknownHttpMethod` error. If an unknown method is\npassed, it should exception higher in the stack instead, once we've had a\nchance to define exception handling behaviour.`","distinct":true,"url":"https://api.github.com/repos/greysteil/rails/commits/4d345cdbf11017318e6be1153443b8558314b7cc"}]}
{"actor":{"display_login":"greysteil"}}