{"action":"created","issue":{"url":"https://api.github.com/repos/mapbox/node-pre-gyp/issues/246","repository_url":"https://api.github.com/repos/mapbox/node-pre-gyp","labels_url":"https://api.github.com/repos/mapbox/node-pre-gyp/issues/246/labels{/name}","comments_url":"https://api.github.com/repos/mapbox/node-pre-gyp/issues/246/comments","events_url":"https://api.github.com/repos/mapbox/node-pre-gyp/issues/246/events","html_url":"https://github.com/mapbox/node-pre-gyp/pull/246","id":185296981,"number":246,"title":"replace request with request/core","user":{"login":"mscdex","id":54666,"avatar_url":"https://avatars.githubusercontent.com/u/54666?v=3","gravatar_id":"","url":"https://api.github.com/users/mscdex","html_url":"https://github.com/mscdex","followers_url":"https://api.github.com/users/mscdex/followers","following_url":"https://api.github.com/users/mscdex/following{/other_user}","gists_url":"https://api.github.com/users/mscdex/gists{/gist_id}","starred_url":"https://api.github.com/users/mscdex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mscdex/subscriptions","organizations_url":"https://api.github.com/users/mscdex/orgs","repos_url":"https://api.github.com/users/mscdex/repos","events_url":"https://api.github.com/users/mscdex/events{/privacy}","received_events_url":"https://api.github.com/users/mscdex/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-10-26T04:53:50Z","updated_at":"2016-10-26T14:21:37Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mapbox/node-pre-gyp/pulls/246","html_url":"https://github.com/mapbox/node-pre-gyp/pull/246","diff_url":"https://github.com/mapbox/node-pre-gyp/pull/246.diff","patch_url":"https://github.com/mapbox/node-pre-gyp/pull/246.patch"},"body":"Changing from `request` to `request/core` cuts this module's current total dependency size from 8.8MB to 4.1MB."},"comment":{"url":"https://api.github.com/repos/mapbox/node-pre-gyp/issues/comments/256362419","html_url":"https://github.com/mapbox/node-pre-gyp/pull/246#issuecomment-256362419","issue_url":"https://api.github.com/repos/mapbox/node-pre-gyp/issues/246","id":256362419,"user":{"login":"reconbot","id":25966,"avatar_url":"https://avatars.githubusercontent.com/u/25966?v=3","gravatar_id":"","url":"https://api.github.com/users/reconbot","html_url":"https://github.com/reconbot","followers_url":"https://api.github.com/users/reconbot/followers","following_url":"https://api.github.com/users/reconbot/following{/other_user}","gists_url":"https://api.github.com/users/reconbot/gists{/gist_id}","starred_url":"https://api.github.com/users/reconbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reconbot/subscriptions","organizations_url":"https://api.github.com/users/reconbot/orgs","repos_url":"https://api.github.com/users/reconbot/repos","events_url":"https://api.github.com/users/reconbot/events{/privacy}","received_events_url":"https://api.github.com/users/reconbot/received_events","type":"User","site_admin":false},"created_at":"2016-10-26T14:21:37Z","updated_at":"2016-10-26T14:21:37Z","body":"I like this PR it allows us to continue to support node 0.10 and 0.12 and give everyone a smaller packages size. `got` requires 4+.\r\n\r\nA note on sizes however, the size of the modules is one thing, the total node_modules folder matters more as that includes all the deps. Using `du -sck node_modules` and removing the node modules folder every time;\r\n\r\nPlease verify my work because this goes against what I'd expect. Testing with npm3 and node4\r\n\r\n- `request/core` 27Mb (28,132k)\r\n- `got` 27Mb (27,892k)\r\n- `master` 27Mb (27,348k)\r\n\r\nSo all our changes increase overall install size?! "}}
{"actor":{"display_login":"reconbot"}}