{"action":"created","comment":{"url":"https://api.github.com/repos/cakephp/cakephp-codesniffer/pulls/comments/94270189","pull_request_review_id":14801121,"id":94270189,"diff_hunk":"@@ -28,5 +28,29 @@\n         \"psr-4\": {\n             \"CakePHP\\\\\": \"CakePHP\"\n         }\n+    },\n+    \"scripts\": {\n+        \"increaseSeverity\": \"sed -i '' 's/<severity>0<\\\\/severity>/<!--<severity>0<\\\\/severity>-->/' CakePHP/ruleset.xml\",\n+        \"includeTestsDirectory\": \"sed -i '' 's/<exclude-pattern>\\\\*\\\\/tests\\\\/\\\\*<\\\\/exclude-pattern>/<!--<exclude-pattern>\\\\*\\\\/tests\\\\/\\\\*<\\\\/exclude-pattern>-->/' CakePHP/ruleset.xml\",\n+        \"resetRuleset\": [\n+            \"sed -i '' 's/<!--<severity>0<\\\\/severity>-->/<severity>0<\\\\/severity>/' CakePHP/ruleset.xml\",\n+            \"sed -i '' 's/<!--<exclude-pattern>\\\\*\\\\/tests\\\\/\\\\*<\\\\/exclude-pattern>-->/<exclude-pattern>\\\\*\\\\/tests\\\\/\\\\*<\\\\/exclude-pattern>/' CakePHP/ruleset.xml\"\n+        ],\n+        \"addStandard\" : \"phpcs --config-set installed_paths $(pwd)\",\n+        \"test\": [\n+          \"@increaseSeverity\",\n+          \"phpunit\",\n+          \"@resetRuleset\"\n+        ],\n+        \"cs-check\": [\n+            \"@addStandard\",","path":"composer.json","position":19,"original_position":19,"commit_id":"c1e104d397e84f36abb91b4b6cd6c99d8564a259","original_commit_id":"c1e104d397e84f36abb91b4b6cd6c99d8564a259","user":{"login":"antograssiot","id":4977112,"avatar_url":"https://avatars.githubusercontent.com/u/4977112?v=3","gravatar_id":"","url":"https://api.github.com/users/antograssiot","html_url":"https://github.com/antograssiot","followers_url":"https://api.github.com/users/antograssiot/followers","following_url":"https://api.github.com/users/antograssiot/following{/other_user}","gists_url":"https://api.github.com/users/antograssiot/gists{/gist_id}","starred_url":"https://api.github.com/users/antograssiot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antograssiot/subscriptions","organizations_url":"https://api.github.com/users/antograssiot/orgs","repos_url":"https://api.github.com/users/antograssiot/repos","events_url":"https://api.github.com/users/antograssiot/events{/privacy}","received_events_url":"https://api.github.com/users/antograssiot/received_events","type":"User","site_admin":false},"body":"I'might not sure for the standard size it is already installed on my machine. Redefiningredients it doesn't hurt I think. Regarding the ruleset it was jut that for this report, given how the tests are written I wanted to stick with all the rules or the CS check but I can remove it (will need to be updated in the Travis config)","created_at":"2016-12-31T06:56:00Z","updated_at":"2016-12-31T06:56:00Z","html_url":"https://github.com/cakephp/cakephp-codesniffer/pull/181#discussion_r94270189","pull_request_url":"https://api.github.com/repos/cakephp/cakephp-codesniffer/pulls/181","_links":{"self":{"href":"https://api.github.com/repos/cakephp/cakephp-codesniffer/pulls/comments/94270189"},"html":{"href":"https://github.com/cakephp/cakephp-codesniffer/pull/181#discussion_r94270189"},"pull_request":{"href":"https://api.github.com/repos/cakephp/cakephp-codesniffer/pulls/181"}}},"pull_request":{"url":"https://api.github.com/repos/cakephp/cakephp-codesniffer/pulls/181","id":99799367,"html_url":"https://github.com/cakephp/cakephp-codesniffer/pull/181","diff_url":"https://github.com/cakephp/cakephp-codesniffer/pull/181.diff","patch_url":"https://github.com/cakephp/cakephp-codesniffer/pull/181.patch","issue_url":"https://api.github.com/repos/cakephp/cakephp-codesniffer/issues/181","number":181,"state":"open","locked":false,"title":"Relax more rules and add Composer scripts","user":{"login":"antograssiot","id":4977112,"avatar_url":"https://avatars.githubusercontent.com/u/4977112?v=3","gravatar_id":"","url":"https://api.github.com/users/antograssiot","html_url":"https://github.com/antograssiot","followers_url":"https://api.github.com/users/antograssiot/followers","following_url":"https://api.github.com/users/antograssiot/following{/other_user}","gists_url":"https://api.github.com/users/antograssiot/gists{/gist_id}","starred_url":"https://api.github.com/users/antograssiot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antograssiot/subscriptions","organizations_url":"https://api.github.com/users/antograssiot/orgs","repos_url":"https://api.github.com/users/antograssiot/repos","events_url":"https://api.github.com/users/antograssiot/events{/privacy}","received_events_url":"https://api.github.com/users/antograssiot/received_events","type":"User","site_admin":false},"body":"I've pointed some more rules that needed to be relaxed since we are using Zend NamingConvention Sniff while running the CS against Cakephp core.\r\n\r\n@ADmad I've added Composer scripts has discussed, I hope that this is it what you had in mind more or less.","created_at":"2016-12-31T06:45:47Z","updated_at":"2016-12-31T06:56:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4e9c50dc11598e573e964287ea9ec6894db39b9e","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/cakephp/cakephp-codesniffer/milestones/3","html_url":"https://github.com/cakephp/cakephp-codesniffer/milestone/3","labels_url":"https://api.github.com/repos/cakephp/cakephp-codesniffer/milestones/3/labels","id":1967873,"number":3,"title":"3.x","description":"","creator":{"login":"antograssiot","id":4977112,"avatar_url":"https://avatars.githubusercontent.com/u/4977112?v=3","gravatar_id":"","url":"https://api.github.com/users/antograssiot","html_url":"https://github.com/antograssiot","followers_url":"https://api.github.com/users/antograssiot/followers","following_url":"https://api.github.com/users/antograssiot/following{/other_user}","gists_url":"https://api.github.com/users/antograssiot/gists{/gist_id}","starred_url":"https://api.github.com/users/antograssiot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antograssiot/subscriptions","organizations_url":"https://api.github.com/users/antograssiot/orgs","repos_url":"https://api.github.com/users/antograssiot/repos","events_url":"https://api.github.com/users/antograssiot/events{/privacy}","received_events_url":"https://api.github.com/users/antograssiot/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":4,"state":"open","created_at":"2016-08-28T08:03:03Z","updated_at":"2016-12-31T06:47:32Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/cakephp/cakephp-codesniffer/pulls/181/commits","review_comments_url":"https://api.github.com/repos/cakephp/cakephp-codesniffer/pulls/181/comments","review_comment_url":"https://api.github.com/repos/cakephp/cakephp-codesniffer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cakephp/cakephp-codesniffer/issues/181/comments","statuses_url":"https://api.github.com/repos/cakephp/cakephp-codesniffer/statuses/c1e104d397e84f36abb91b4b6cd6c99d8564a259","head":{"label":"cakephp:composer-scripts","ref":"composer-scripts","sha":"c1e104d397e84f36abb91b4b6cd6c99d8564a259","user":{"login":"cakephp","id":23666,"avatar_url":"https://avatars.githubusercontent.com/u/23666?v=3","gravatar_id":"","url":"https://api.github.com/users/cakephp","html_url":"https://github.com/cakephp","followers_url":"https://api.github.com/users/cakephp/followers","following_url":"https://api.github.com/users/cakephp/following{/other_user}","gists_url":"https://api.github.com/users/cakephp/gists{/gist_id}","starred_url":"https://api.github.com/users/cakephp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cakephp/subscriptions","organizations_url":"https://api.github.com/users/cakephp/orgs","repos_url":"https://api.github.com/users/cakephp/repos","events_url":"https://api.github.com/users/cakephp/events{/privacy}","received_events_url":"https://api.github.com/users/cakephp/received_events","type":"Organization","site_admin":false},"repo":{"id":3634443,"name":"cakephp-codesniffer","full_name":"cakephp/cakephp-codesniffer","owner":{"login":"cakephp","id":23666,"avatar_url":"https://avatars.githubusercontent.com/u/23666?v=3","gravatar_id":"","url":"https://api.github.com/users/cakephp","html_url":"https://github.com/cakephp","followers_url":"https://api.github.com/users/cakephp/followers","following_url":"https://api.github.com/users/cakephp/following{/other_user}","gists_url":"https://api.github.com/users/cakephp/gists{/gist_id}","starred_url":"https://api.github.com/users/cakephp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cakephp/subscriptions","organizations_url":"https://api.github.com/users/cakephp/orgs","repos_url":"https://api.github.com/users/cakephp/repos","events_url":"https://api.github.com/users/cakephp/events{/privacy}","received_events_url":"https://api.github.com/users/cakephp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cakephp/cakephp-codesniffer","description":"CakePHP Code Sniffer","fork":false,"url":"https://api.github.com/repos/cakephp/cakephp-codesniffer","forks_url":"https://api.github.com/repos/cakephp/cakephp-codesniffer/forks","keys_url":"https://api.github.com/repos/cakephp/cakephp-codesniffer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cakephp/cakephp-codesniffer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cakephp/cakephp-codesniffer/teams","hooks_url":"https://api.github.com/repos/cakephp/cakephp-codesniffer/hooks","issue_events_url":"https://api.github.com/repos/cakephp/cakephp-codesniffer/issues/events{/number}","events_url":"https://api.github.com/repos/cakephp/cakephp-codesniffer/events","assignees_url":"https://api.github.com/repos/cakephp/cakephp-codesniffer/assignees{/user}","branches_url":"https://api.github.com/repos/cakephp/cakephp-codesniffer/branches{/branch}","tags_url":"https://api.github.com/repos/cakephp/cakephp-codesniffer/tags","blobs_url":"https://api.github.com/repos/cakephp/cakephp-codesniffer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cakephp/cakephp-codesniffer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cakephp/cakephp-codesniffer/git/refs{/sha}","trees_url":"https://api.github.com/repos/cakephp/cakephp-codesniffer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cakephp/cakephp-codesniffer/statuses/{sha}","languages_url":"https://api.github.com/repos/cakephp/cakephp-codesniffer/languages","stargazers_url":"https://api.github.com/repos/cakephp/cakephp-codesniffer/stargazers","contributors_url":"https://api.github.com/repos/cakephp/cakephp-codesniffer/contributors","subscribers_url":"https://api.github.com/repos/cakephp/cakephp-codesniffer/subscribers","subscription_url":"https://api.github.com/repos/cakephp/cakephp-codesniffer/subscription","commits_url":"https://api.github.com/repos/cakephp/cakephp-codesniffer/commits{/sha}","git_commits_url":"https://api.github.com/repos/cakephp/cakephp-codesniffer/git/commits{/sha}","comments_url":"https://api.github.com/repos/cakephp/cakephp-codesniffer/comments{/number}","issue_comment_url":"https://api.github.com/repos/cakephp/cakephp-codesniffer/issues/comments{/number}","contents_url":"https://api.github.com/repos/cakephp/cakephp-codesniffer/contents/{+path}","compare_url":"https://api.github.com/repos/cakephp/cakephp-codesniffer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cakephp/cakephp-codesniffer/merges","archive_url":"https://api.github.com/repos/cakephp/cakephp-codesniffer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cakephp/cakephp-codesniffer/downloads","issues_url":"https://api.github.com/repos/cakephp/cakephp-codesniffer/issues{/number}","pulls_url":"https://api.github.com/repos/cakephp/cakephp-codesniffer/pulls{/number}","milestones_url":"https://api.github.com/repos/cakephp/cakephp-codesniffer/milestones{/number}","notifications_url":"https://api.github.com/repos/cakephp/cakephp-codesniffer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cakephp/cakephp-codesniffer/labels{/name}","releases_url":"https://api.github.com/repos/cakephp/cakephp-codesniffer/releases{/id}","deployments_url":"https://api.github.com/repos/cakephp/cakephp-codesniffer/deployments","created_at":"2012-03-06T04:10:38Z","updated_at":"2016-10-23T21:06:44Z","pushed_at":"2016-12-31T06:51:47Z","git_url":"git://github.com/cakephp/cakephp-codesniffer.git","ssh_url":"git@github.com:cakephp/cakephp-codesniffer.git","clone_url":"https://github.com/cakephp/cakephp-codesniffer.git","svn_url":"https://github.com/cakephp/cakephp-codesniffer","homepage":"http://cakephp.org","size":495,"stargazers_count":170,"watchers_count":170,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":70,"mirror_url":null,"open_issues_count":5,"forks":70,"open_issues":5,"watchers":170,"default_branch":"master"}},"base":{"label":"cakephp:3.0","ref":"3.0","sha":"19a56c0f39e577a4303878483d47ec49655d7abe","user":{"login":"cakephp","id":23666,"avatar_url":"https://avatars.githubusercontent.com/u/23666?v=3","gravatar_id":"","url":"https://api.github.com/users/cakephp","html_url":"https://github.com/cakephp","followers_url":"https://api.github.com/users/cakephp/followers","following_url":"https://api.github.com/users/cakephp/following{/other_user}","gists_url":"https://api.github.com/users/cakephp/gists{/gist_id}","starred_url":"https://api.github.com/users/cakephp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cakephp/subscriptions","organizations_url":"https://api.github.com/users/cakephp/orgs","repos_url":"https://api.github.com/users/cakephp/repos","events_url":"https://api.github.com/users/cakephp/events{/privacy}","received_events_url":"https://api.github.com/users/cakephp/received_events","type":"Organization","site_admin":false},"repo":{"id":3634443,"name":"cakephp-codesniffer","full_name":"cakephp/cakephp-codesniffer","owner":{"login":"cakephp","id":23666,"avatar_url":"https://avatars.githubusercontent.com/u/23666?v=3","gravatar_id":"","url":"https://api.github.com/users/cakephp","html_url":"https://github.com/cakephp","followers_url":"https://api.github.com/users/cakephp/followers","following_url":"https://api.github.com/users/cakephp/following{/other_user}","gists_url":"https://api.github.com/users/cakephp/gists{/gist_id}","starred_url":"https://api.github.com/users/cakephp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cakephp/subscriptions","organizations_url":"https://api.github.com/users/cakephp/orgs","repos_url":"https://api.github.com/users/cakephp/repos","events_url":"https://api.github.com/users/cakephp/events{/privacy}","received_events_url":"https://api.github.com/users/cakephp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cakephp/cakephp-codesniffer","description":"CakePHP Code Sniffer","fork":false,"url":"https://api.github.com/repos/cakephp/cakephp-codesniffer","forks_url":"https://api.github.com/repos/cakephp/cakephp-codesniffer/forks","keys_url":"https://api.github.com/repos/cakephp/cakephp-codesniffer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cakephp/cakephp-codesniffer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cakephp/cakephp-codesniffer/teams","hooks_url":"https://api.github.com/repos/cakephp/cakephp-codesniffer/hooks","issue_events_url":"https://api.github.com/repos/cakephp/cakephp-codesniffer/issues/events{/number}","events_url":"https://api.github.com/repos/cakephp/cakephp-codesniffer/events","assignees_url":"https://api.github.com/repos/cakephp/cakephp-codesniffer/assignees{/user}","branches_url":"https://api.github.com/repos/cakephp/cakephp-codesniffer/branches{/branch}","tags_url":"https://api.github.com/repos/cakephp/cakephp-codesniffer/tags","blobs_url":"https://api.github.com/repos/cakephp/cakephp-codesniffer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cakephp/cakephp-codesniffer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cakephp/cakephp-codesniffer/git/refs{/sha}","trees_url":"https://api.github.com/repos/cakephp/cakephp-codesniffer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cakephp/cakephp-codesniffer/statuses/{sha}","languages_url":"https://api.github.com/repos/cakephp/cakephp-codesniffer/languages","stargazers_url":"https://api.github.com/repos/cakephp/cakephp-codesniffer/stargazers","contributors_url":"https://api.github.com/repos/cakephp/cakephp-codesniffer/contributors","subscribers_url":"https://api.github.com/repos/cakephp/cakephp-codesniffer/subscribers","subscription_url":"https://api.github.com/repos/cakephp/cakephp-codesniffer/subscription","commits_url":"https://api.github.com/repos/cakephp/cakephp-codesniffer/commits{/sha}","git_commits_url":"https://api.github.com/repos/cakephp/cakephp-codesniffer/git/commits{/sha}","comments_url":"https://api.github.com/repos/cakephp/cakephp-codesniffer/comments{/number}","issue_comment_url":"https://api.github.com/repos/cakephp/cakephp-codesniffer/issues/comments{/number}","contents_url":"https://api.github.com/repos/cakephp/cakephp-codesniffer/contents/{+path}","compare_url":"https://api.github.com/repos/cakephp/cakephp-codesniffer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cakephp/cakephp-codesniffer/merges","archive_url":"https://api.github.com/repos/cakephp/cakephp-codesniffer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cakephp/cakephp-codesniffer/downloads","issues_url":"https://api.github.com/repos/cakephp/cakephp-codesniffer/issues{/number}","pulls_url":"https://api.github.com/repos/cakephp/cakephp-codesniffer/pulls{/number}","milestones_url":"https://api.github.com/repos/cakephp/cakephp-codesniffer/milestones{/number}","notifications_url":"https://api.github.com/repos/cakephp/cakephp-codesniffer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cakephp/cakephp-codesniffer/labels{/name}","releases_url":"https://api.github.com/repos/cakephp/cakephp-codesniffer/releases{/id}","deployments_url":"https://api.github.com/repos/cakephp/cakephp-codesniffer/deployments","created_at":"2012-03-06T04:10:38Z","updated_at":"2016-10-23T21:06:44Z","pushed_at":"2016-12-31T06:51:47Z","git_url":"git://github.com/cakephp/cakephp-codesniffer.git","ssh_url":"git@github.com:cakephp/cakephp-codesniffer.git","clone_url":"https://github.com/cakephp/cakephp-codesniffer.git","svn_url":"https://github.com/cakephp/cakephp-codesniffer","homepage":"http://cakephp.org","size":495,"stargazers_count":170,"watchers_count":170,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":70,"mirror_url":null,"open_issues_count":5,"forks":70,"open_issues":5,"watchers":170,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cakephp/cakephp-codesniffer/pulls/181"},"html":{"href":"https://github.com/cakephp/cakephp-codesniffer/pull/181"},"issue":{"href":"https://api.github.com/repos/cakephp/cakephp-codesniffer/issues/181"},"comments":{"href":"https://api.github.com/repos/cakephp/cakephp-codesniffer/issues/181/comments"},"review_comments":{"href":"https://api.github.com/repos/cakephp/cakephp-codesniffer/pulls/181/comments"},"review_comment":{"href":"https://api.github.com/repos/cakephp/cakephp-codesniffer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cakephp/cakephp-codesniffer/pulls/181/commits"},"statuses":{"href":"https://api.github.com/repos/cakephp/cakephp-codesniffer/statuses/c1e104d397e84f36abb91b4b6cd6c99d8564a259"}}}}
{"actor":{"display_login":"antograssiot"}}