{"action":"closed","issue":{"url":"https://api.github.com/repos/router5/router5-history/issues/8","repository_url":"https://api.github.com/repos/router5/router5-history","labels_url":"https://api.github.com/repos/router5/router5-history/issues/8/labels{/name}","comments_url":"https://api.github.com/repos/router5/router5-history/issues/8/comments","events_url":"https://api.github.com/repos/router5/router5-history/issues/8/events","html_url":"https://github.com/router5/router5-history/issues/8","id":170163403,"number":8,"title":"History back to 404 route bug","user":{"login":"hellosmithy","id":866604,"avatar_url":"https://avatars.githubusercontent.com/u/866604?v=3","gravatar_id":"","url":"https://api.github.com/users/hellosmithy","html_url":"https://github.com/hellosmithy","followers_url":"https://api.github.com/users/hellosmithy/followers","following_url":"https://api.github.com/users/hellosmithy/following{/other_user}","gists_url":"https://api.github.com/users/hellosmithy/gists{/gist_id}","starred_url":"https://api.github.com/users/hellosmithy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hellosmithy/subscriptions","organizations_url":"https://api.github.com/users/hellosmithy/orgs","repos_url":"https://api.github.com/users/hellosmithy/repos","events_url":"https://api.github.com/users/hellosmithy/events{/privacy}","received_events_url":"https://api.github.com/users/hellosmithy/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-08-09T13:18:01Z","updated_at":"2016-09-05T10:16:20Z","closed_at":"2016-09-05T10:16:20Z","body":"If `defaultRoute` is left undefined/null in the router config and 404 pages are handled by checking for a `transitionError.code` of `\"ROUTE_NOT_FOUND\"` and rendering a custom 404 view there is a bug when you transition away from the 404 catch-all route to a valid route, then transition back to the 404 page with the  browser back button.\r\n\r\nDoing so triggers an `onPopState` in router5-history which in turn calls `router.navigate` with an undefined `defaultRoute` value here: https://github.com/router5/router5-history/blob/master/modules/index.js#L32.\r\n\r\nThis causes the `route-node` package to choke on `routeName.split('.')` here: https://github.com/troch/route-node/blob/master/modules/RouteNode.js#L112.\r\n\r\nA quick fix is to define `defaultRoute` as an empty string but this doesn't seem correct behaviour."}}
{"actor":{"display_login":"troch"}}