{"action":"opened","number":4964,"pull_request":{"url":"https://api.github.com/repos/ten24/slatwall/pulls/4964","id":91059433,"html_url":"https://github.com/ten24/slatwall/pull/4964","diff_url":"https://github.com/ten24/slatwall/pull/4964.diff","patch_url":"https://github.com/ten24/slatwall/pull/4964.patch","issue_url":"https://api.github.com/repos/ten24/slatwall/issues/4964","number":4964,"state":"open","locked":false,"title":"updates to fix issue deleting orderitems.","user":{"login":"ian-a-hickey","id":10375721,"avatar_url":"https://avatars.githubusercontent.com/u/10375721?v=3","gravatar_id":"","url":"https://api.github.com/users/ian-a-hickey","html_url":"https://github.com/ian-a-hickey","followers_url":"https://api.github.com/users/ian-a-hickey/followers","following_url":"https://api.github.com/users/ian-a-hickey/following{/other_user}","gists_url":"https://api.github.com/users/ian-a-hickey/gists{/gist_id}","starred_url":"https://api.github.com/users/ian-a-hickey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ian-a-hickey/subscriptions","organizations_url":"https://api.github.com/users/ian-a-hickey/orgs","repos_url":"https://api.github.com/users/ian-a-hickey/repos","events_url":"https://api.github.com/users/ian-a-hickey/events{/privacy}","received_events_url":"https://api.github.com/users/ian-a-hickey/received_events","type":"User","site_admin":false},"body":"Because orderfulfillment has a calculated property that is a relationship rather than a simple property (to selectedShippingMethodOption), entitymerge needed to be added to flushORMSession to get the entity back onto the session after the initial flush.\r\n\r\nOnce that was fixed, a constraint was being thrown from orderFulfillment to shippingMethodOptionID. I fixed that by (after trying javacast null on orderFulfillment side and the other way around) adding a DAO method to remove the id from orderFulfillment. With that working, removing orderItems works again.\r\n\r\nThanks for the help Sumit.","created_at":"2016-10-26T18:20:17Z","updated_at":"2016-10-26T18:20:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6b6c4e248f1625a34d94ebd3a94a61a8fd9c421f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ten24/slatwall/pulls/4964/commits","review_comments_url":"https://api.github.com/repos/ten24/slatwall/pulls/4964/comments","review_comment_url":"https://api.github.com/repos/ten24/slatwall/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ten24/slatwall/issues/4964/comments","statuses_url":"https://api.github.com/repos/ten24/slatwall/statuses/44fe7d12f84d30440d27a8e48d25fa49d986261d","head":{"label":"ten24:hotfix-ih-delete-orderfulfillment","ref":"hotfix-ih-delete-orderfulfillment","sha":"44fe7d12f84d30440d27a8e48d25fa49d986261d","user":{"login":"ten24","id":615272,"avatar_url":"https://avatars.githubusercontent.com/u/615272?v=3","gravatar_id":"","url":"https://api.github.com/users/ten24","html_url":"https://github.com/ten24","followers_url":"https://api.github.com/users/ten24/followers","following_url":"https://api.github.com/users/ten24/following{/other_user}","gists_url":"https://api.github.com/users/ten24/gists{/gist_id}","starred_url":"https://api.github.com/users/ten24/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ten24/subscriptions","organizations_url":"https://api.github.com/users/ten24/orgs","repos_url":"https://api.github.com/users/ten24/repos","events_url":"https://api.github.com/users/ten24/events{/privacy}","received_events_url":"https://api.github.com/users/ten24/received_events","type":"Organization","site_admin":false},"repo":{"id":1483572,"name":"slatwall","full_name":"ten24/slatwall","owner":{"login":"ten24","id":615272,"avatar_url":"https://avatars.githubusercontent.com/u/615272?v=3","gravatar_id":"","url":"https://api.github.com/users/ten24","html_url":"https://github.com/ten24","followers_url":"https://api.github.com/users/ten24/followers","following_url":"https://api.github.com/users/ten24/following{/other_user}","gists_url":"https://api.github.com/users/ten24/gists{/gist_id}","starred_url":"https://api.github.com/users/ten24/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ten24/subscriptions","organizations_url":"https://api.github.com/users/ten24/orgs","repos_url":"https://api.github.com/users/ten24/repos","events_url":"https://api.github.com/users/ten24/events{/privacy}","received_events_url":"https://api.github.com/users/ten24/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ten24/slatwall","description":"Slatwall - An Open Source Commerce Platform","fork":false,"url":"https://api.github.com/repos/ten24/slatwall","forks_url":"https://api.github.com/repos/ten24/slatwall/forks","keys_url":"https://api.github.com/repos/ten24/slatwall/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ten24/slatwall/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ten24/slatwall/teams","hooks_url":"https://api.github.com/repos/ten24/slatwall/hooks","issue_events_url":"https://api.github.com/repos/ten24/slatwall/issues/events{/number}","events_url":"https://api.github.com/repos/ten24/slatwall/events","assignees_url":"https://api.github.com/repos/ten24/slatwall/assignees{/user}","branches_url":"https://api.github.com/repos/ten24/slatwall/branches{/branch}","tags_url":"https://api.github.com/repos/ten24/slatwall/tags","blobs_url":"https://api.github.com/repos/ten24/slatwall/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ten24/slatwall/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ten24/slatwall/git/refs{/sha}","trees_url":"https://api.github.com/repos/ten24/slatwall/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ten24/slatwall/statuses/{sha}","languages_url":"https://api.github.com/repos/ten24/slatwall/languages","stargazers_url":"https://api.github.com/repos/ten24/slatwall/stargazers","contributors_url":"https://api.github.com/repos/ten24/slatwall/contributors","subscribers_url":"https://api.github.com/repos/ten24/slatwall/subscribers","subscription_url":"https://api.github.com/repos/ten24/slatwall/subscription","commits_url":"https://api.github.com/repos/ten24/slatwall/commits{/sha}","git_commits_url":"https://api.github.com/repos/ten24/slatwall/git/commits{/sha}","comments_url":"https://api.github.com/repos/ten24/slatwall/comments{/number}","issue_comment_url":"https://api.github.com/repos/ten24/slatwall/issues/comments{/number}","contents_url":"https://api.github.com/repos/ten24/slatwall/contents/{+path}","compare_url":"https://api.github.com/repos/ten24/slatwall/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ten24/slatwall/merges","archive_url":"https://api.github.com/repos/ten24/slatwall/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ten24/slatwall/downloads","issues_url":"https://api.github.com/repos/ten24/slatwall/issues{/number}","pulls_url":"https://api.github.com/repos/ten24/slatwall/pulls{/number}","milestones_url":"https://api.github.com/repos/ten24/slatwall/milestones{/number}","notifications_url":"https://api.github.com/repos/ten24/slatwall/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ten24/slatwall/labels{/name}","releases_url":"https://api.github.com/repos/ten24/slatwall/releases{/id}","deployments_url":"https://api.github.com/repos/ten24/slatwall/deployments","created_at":"2011-03-15T16:58:28Z","updated_at":"2016-10-24T14:56:35Z","pushed_at":"2016-10-26T18:20:17Z","git_url":"git://github.com/ten24/slatwall.git","ssh_url":"git@github.com:ten24/slatwall.git","clone_url":"https://github.com/ten24/slatwall.git","svn_url":"https://github.com/ten24/slatwall","homepage":"http://www.slatwallcommerce.com","size":161243,"stargazers_count":104,"watchers_count":104,"language":"ColdFusion","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":67,"mirror_url":null,"open_issues_count":290,"forks":67,"open_issues":290,"watchers":104,"default_branch":"master"}},"base":{"label":"ten24:hotfix","ref":"hotfix","sha":"8a44f1f78924aa81fcdac52cd942c13a18761cab","user":{"login":"ten24","id":615272,"avatar_url":"https://avatars.githubusercontent.com/u/615272?v=3","gravatar_id":"","url":"https://api.github.com/users/ten24","html_url":"https://github.com/ten24","followers_url":"https://api.github.com/users/ten24/followers","following_url":"https://api.github.com/users/ten24/following{/other_user}","gists_url":"https://api.github.com/users/ten24/gists{/gist_id}","starred_url":"https://api.github.com/users/ten24/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ten24/subscriptions","organizations_url":"https://api.github.com/users/ten24/orgs","repos_url":"https://api.github.com/users/ten24/repos","events_url":"https://api.github.com/users/ten24/events{/privacy}","received_events_url":"https://api.github.com/users/ten24/received_events","type":"Organization","site_admin":false},"repo":{"id":1483572,"name":"slatwall","full_name":"ten24/slatwall","owner":{"login":"ten24","id":615272,"avatar_url":"https://avatars.githubusercontent.com/u/615272?v=3","gravatar_id":"","url":"https://api.github.com/users/ten24","html_url":"https://github.com/ten24","followers_url":"https://api.github.com/users/ten24/followers","following_url":"https://api.github.com/users/ten24/following{/other_user}","gists_url":"https://api.github.com/users/ten24/gists{/gist_id}","starred_url":"https://api.github.com/users/ten24/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ten24/subscriptions","organizations_url":"https://api.github.com/users/ten24/orgs","repos_url":"https://api.github.com/users/ten24/repos","events_url":"https://api.github.com/users/ten24/events{/privacy}","received_events_url":"https://api.github.com/users/ten24/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ten24/slatwall","description":"Slatwall - An Open Source Commerce Platform","fork":false,"url":"https://api.github.com/repos/ten24/slatwall","forks_url":"https://api.github.com/repos/ten24/slatwall/forks","keys_url":"https://api.github.com/repos/ten24/slatwall/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ten24/slatwall/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ten24/slatwall/teams","hooks_url":"https://api.github.com/repos/ten24/slatwall/hooks","issue_events_url":"https://api.github.com/repos/ten24/slatwall/issues/events{/number}","events_url":"https://api.github.com/repos/ten24/slatwall/events","assignees_url":"https://api.github.com/repos/ten24/slatwall/assignees{/user}","branches_url":"https://api.github.com/repos/ten24/slatwall/branches{/branch}","tags_url":"https://api.github.com/repos/ten24/slatwall/tags","blobs_url":"https://api.github.com/repos/ten24/slatwall/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ten24/slatwall/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ten24/slatwall/git/refs{/sha}","trees_url":"https://api.github.com/repos/ten24/slatwall/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ten24/slatwall/statuses/{sha}","languages_url":"https://api.github.com/repos/ten24/slatwall/languages","stargazers_url":"https://api.github.com/repos/ten24/slatwall/stargazers","contributors_url":"https://api.github.com/repos/ten24/slatwall/contributors","subscribers_url":"https://api.github.com/repos/ten24/slatwall/subscribers","subscription_url":"https://api.github.com/repos/ten24/slatwall/subscription","commits_url":"https://api.github.com/repos/ten24/slatwall/commits{/sha}","git_commits_url":"https://api.github.com/repos/ten24/slatwall/git/commits{/sha}","comments_url":"https://api.github.com/repos/ten24/slatwall/comments{/number}","issue_comment_url":"https://api.github.com/repos/ten24/slatwall/issues/comments{/number}","contents_url":"https://api.github.com/repos/ten24/slatwall/contents/{+path}","compare_url":"https://api.github.com/repos/ten24/slatwall/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ten24/slatwall/merges","archive_url":"https://api.github.com/repos/ten24/slatwall/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ten24/slatwall/downloads","issues_url":"https://api.github.com/repos/ten24/slatwall/issues{/number}","pulls_url":"https://api.github.com/repos/ten24/slatwall/pulls{/number}","milestones_url":"https://api.github.com/repos/ten24/slatwall/milestones{/number}","notifications_url":"https://api.github.com/repos/ten24/slatwall/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ten24/slatwall/labels{/name}","releases_url":"https://api.github.com/repos/ten24/slatwall/releases{/id}","deployments_url":"https://api.github.com/repos/ten24/slatwall/deployments","created_at":"2011-03-15T16:58:28Z","updated_at":"2016-10-24T14:56:35Z","pushed_at":"2016-10-26T18:20:17Z","git_url":"git://github.com/ten24/slatwall.git","ssh_url":"git@github.com:ten24/slatwall.git","clone_url":"https://github.com/ten24/slatwall.git","svn_url":"https://github.com/ten24/slatwall","homepage":"http://www.slatwallcommerce.com","size":161243,"stargazers_count":104,"watchers_count":104,"language":"ColdFusion","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":67,"mirror_url":null,"open_issues_count":290,"forks":67,"open_issues":290,"watchers":104,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ten24/slatwall/pulls/4964"},"html":{"href":"https://github.com/ten24/slatwall/pull/4964"},"issue":{"href":"https://api.github.com/repos/ten24/slatwall/issues/4964"},"comments":{"href":"https://api.github.com/repos/ten24/slatwall/issues/4964/comments"},"review_comments":{"href":"https://api.github.com/repos/ten24/slatwall/pulls/4964/comments"},"review_comment":{"href":"https://api.github.com/repos/ten24/slatwall/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ten24/slatwall/pulls/4964/commits"},"statuses":{"href":"https://api.github.com/repos/ten24/slatwall/statuses/44fe7d12f84d30440d27a8e48d25fa49d986261d"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":20,"deletions":1,"changed_files":3}}
{"actor":{"display_login":"ian-a-hickey"}}