{"action":"created","comment":{"url":"https://api.github.com/repos/signalfx/collectd-haproxy/pulls/comments/55596525","id":55596525,"diff_hunk":"@@ -18,44 +18,44 @@\n RECV_SIZE = 1024\n METRIC_TYPES = {\n     'MaxConn': ('max_connections', 'gauge'),\n-    'CumConns': ('connections', 'counter'),\n-    'CumReq': ('requests', 'counter'),\n+    'CumConns': ('connections', 'derive'),","path":"haproxy.py","position":6,"original_position":6,"commit_id":"d6f8d18a197679f877e7274fa61ca161d5df3dd5","original_commit_id":"d6f8d18a197679f877e7274fa61ca161d5df3dd5","user":{"login":"vzhabiuks","id":17709461,"avatar_url":"https://avatars.githubusercontent.com/u/17709461?v=3","gravatar_id":"","url":"https://api.github.com/users/vzhabiuks","html_url":"https://github.com/vzhabiuks","followers_url":"https://api.github.com/users/vzhabiuks/followers","following_url":"https://api.github.com/users/vzhabiuks/following{/other_user}","gists_url":"https://api.github.com/users/vzhabiuks/gists{/gist_id}","starred_url":"https://api.github.com/users/vzhabiuks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vzhabiuks/subscriptions","organizations_url":"https://api.github.com/users/vzhabiuks/orgs","repos_url":"https://api.github.com/users/vzhabiuks/repos","events_url":"https://api.github.com/users/vzhabiuks/events{/privacy}","received_events_url":"https://api.github.com/users/vzhabiuks/received_events","type":"User","site_admin":false},"body":"Hi Christoph\r\nCould you explain why did you use derive types instead of counter?","created_at":"2016-03-09T21:53:04Z","updated_at":"2016-03-09T21:53:04Z","html_url":"https://github.com/signalfx/collectd-haproxy/pull/2#discussion_r55596525","pull_request_url":"https://api.github.com/repos/signalfx/collectd-haproxy/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/signalfx/collectd-haproxy/pulls/comments/55596525"},"html":{"href":"https://github.com/signalfx/collectd-haproxy/pull/2#discussion_r55596525"},"pull_request":{"href":"https://api.github.com/repos/signalfx/collectd-haproxy/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/signalfx/collectd-haproxy/pulls/2","id":51093101,"html_url":"https://github.com/signalfx/collectd-haproxy/pull/2","diff_url":"https://github.com/signalfx/collectd-haproxy/pull/2.diff","patch_url":"https://github.com/signalfx/collectd-haproxy/pull/2.patch","issue_url":"https://api.github.com/repos/signalfx/collectd-haproxy/issues/2","number":2,"state":"open","locked":false,"title":"case-insenstive matching (for newer haproxy version) and proper collectd types","user":{"login":"tux21b","id":125986,"avatar_url":"https://avatars.githubusercontent.com/u/125986?v=3","gravatar_id":"","url":"https://api.github.com/users/tux21b","html_url":"https://github.com/tux21b","followers_url":"https://api.github.com/users/tux21b/followers","following_url":"https://api.github.com/users/tux21b/following{/other_user}","gists_url":"https://api.github.com/users/tux21b/gists{/gist_id}","starred_url":"https://api.github.com/users/tux21b/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tux21b/subscriptions","organizations_url":"https://api.github.com/users/tux21b/orgs","repos_url":"https://api.github.com/users/tux21b/repos","events_url":"https://api.github.com/users/tux21b/events{/privacy}","received_events_url":"https://api.github.com/users/tux21b/received_events","type":"User","site_admin":false},"body":"We had to make some trivial fixes for our setup. \"MaxConn\", \"MaxPipes\", etc. is now called \"Maxconn\", \"Maxpipes\", ... in haproxy and therefore the script wasn't able to find those values anymore. This patch converts all keys to lowercase internally for matching purposes.\r\n\r\nAlso, we had to change the collectd types from counter to derive (gouge:0:u) to handle haproxy restarts correctly.\r\n\r\nFeel free to contact us if you have any questions.","created_at":"2015-11-18T14:48:43Z","updated_at":"2016-03-09T21:53:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"687190f3eaf33b1b5dc8577926fb7a6d523f7c9b","assignee":{"login":"mdubbyap","id":12699625,"avatar_url":"https://avatars.githubusercontent.com/u/12699625?v=3","gravatar_id":"","url":"https://api.github.com/users/mdubbyap","html_url":"https://github.com/mdubbyap","followers_url":"https://api.github.com/users/mdubbyap/followers","following_url":"https://api.github.com/users/mdubbyap/following{/other_user}","gists_url":"https://api.github.com/users/mdubbyap/gists{/gist_id}","starred_url":"https://api.github.com/users/mdubbyap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdubbyap/subscriptions","organizations_url":"https://api.github.com/users/mdubbyap/orgs","repos_url":"https://api.github.com/users/mdubbyap/repos","events_url":"https://api.github.com/users/mdubbyap/events{/privacy}","received_events_url":"https://api.github.com/users/mdubbyap/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/signalfx/collectd-haproxy/pulls/2/commits","review_comments_url":"https://api.github.com/repos/signalfx/collectd-haproxy/pulls/2/comments","review_comment_url":"https://api.github.com/repos/signalfx/collectd-haproxy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/signalfx/collectd-haproxy/issues/2/comments","statuses_url":"https://api.github.com/repos/signalfx/collectd-haproxy/statuses/d6f8d18a197679f877e7274fa61ca161d5df3dd5","head":{"label":"mgit-at:master","ref":"master","sha":"d6f8d18a197679f877e7274fa61ca161d5df3dd5","user":{"login":"mgit-at","id":11403713,"avatar_url":"https://avatars.githubusercontent.com/u/11403713?v=3","gravatar_id":"","url":"https://api.github.com/users/mgit-at","html_url":"https://github.com/mgit-at","followers_url":"https://api.github.com/users/mgit-at/followers","following_url":"https://api.github.com/users/mgit-at/following{/other_user}","gists_url":"https://api.github.com/users/mgit-at/gists{/gist_id}","starred_url":"https://api.github.com/users/mgit-at/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgit-at/subscriptions","organizations_url":"https://api.github.com/users/mgit-at/orgs","repos_url":"https://api.github.com/users/mgit-at/repos","events_url":"https://api.github.com/users/mgit-at/events{/privacy}","received_events_url":"https://api.github.com/users/mgit-at/received_events","type":"Organization","site_admin":false},"repo":{"id":46354004,"name":"collectd-haproxy","full_name":"mgit-at/collectd-haproxy","owner":{"login":"mgit-at","id":11403713,"avatar_url":"https://avatars.githubusercontent.com/u/11403713?v=3","gravatar_id":"","url":"https://api.github.com/users/mgit-at","html_url":"https://github.com/mgit-at","followers_url":"https://api.github.com/users/mgit-at/followers","following_url":"https://api.github.com/users/mgit-at/following{/other_user}","gists_url":"https://api.github.com/users/mgit-at/gists{/gist_id}","starred_url":"https://api.github.com/users/mgit-at/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgit-at/subscriptions","organizations_url":"https://api.github.com/users/mgit-at/orgs","repos_url":"https://api.github.com/users/mgit-at/repos","events_url":"https://api.github.com/users/mgit-at/events{/privacy}","received_events_url":"https://api.github.com/users/mgit-at/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mgit-at/collectd-haproxy","description":"A collectd plugin to collect statistics from HAProxy","fork":true,"url":"https://api.github.com/repos/mgit-at/collectd-haproxy","forks_url":"https://api.github.com/repos/mgit-at/collectd-haproxy/forks","keys_url":"https://api.github.com/repos/mgit-at/collectd-haproxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mgit-at/collectd-haproxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mgit-at/collectd-haproxy/teams","hooks_url":"https://api.github.com/repos/mgit-at/collectd-haproxy/hooks","issue_events_url":"https://api.github.com/repos/mgit-at/collectd-haproxy/issues/events{/number}","events_url":"https://api.github.com/repos/mgit-at/collectd-haproxy/events","assignees_url":"https://api.github.com/repos/mgit-at/collectd-haproxy/assignees{/user}","branches_url":"https://api.github.com/repos/mgit-at/collectd-haproxy/branches{/branch}","tags_url":"https://api.github.com/repos/mgit-at/collectd-haproxy/tags","blobs_url":"https://api.github.com/repos/mgit-at/collectd-haproxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mgit-at/collectd-haproxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mgit-at/collectd-haproxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/mgit-at/collectd-haproxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mgit-at/collectd-haproxy/statuses/{sha}","languages_url":"https://api.github.com/repos/mgit-at/collectd-haproxy/languages","stargazers_url":"https://api.github.com/repos/mgit-at/collectd-haproxy/stargazers","contributors_url":"https://api.github.com/repos/mgit-at/collectd-haproxy/contributors","subscribers_url":"https://api.github.com/repos/mgit-at/collectd-haproxy/subscribers","subscription_url":"https://api.github.com/repos/mgit-at/collectd-haproxy/subscription","commits_url":"https://api.github.com/repos/mgit-at/collectd-haproxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/mgit-at/collectd-haproxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/mgit-at/collectd-haproxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/mgit-at/collectd-haproxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/mgit-at/collectd-haproxy/contents/{+path}","compare_url":"https://api.github.com/repos/mgit-at/collectd-haproxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mgit-at/collectd-haproxy/merges","archive_url":"https://api.github.com/repos/mgit-at/collectd-haproxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mgit-at/collectd-haproxy/downloads","issues_url":"https://api.github.com/repos/mgit-at/collectd-haproxy/issues{/number}","pulls_url":"https://api.github.com/repos/mgit-at/collectd-haproxy/pulls{/number}","milestones_url":"https://api.github.com/repos/mgit-at/collectd-haproxy/milestones{/number}","notifications_url":"https://api.github.com/repos/mgit-at/collectd-haproxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mgit-at/collectd-haproxy/labels{/name}","releases_url":"https://api.github.com/repos/mgit-at/collectd-haproxy/releases{/id}","deployments_url":"https://api.github.com/repos/mgit-at/collectd-haproxy/deployments","created_at":"2015-11-17T14:56:43Z","updated_at":"2015-11-17T14:56:43Z","pushed_at":"2015-11-17T15:04:56Z","git_url":"git://github.com/mgit-at/collectd-haproxy.git","ssh_url":"git@github.com:mgit-at/collectd-haproxy.git","clone_url":"https://github.com/mgit-at/collectd-haproxy.git","svn_url":"https://github.com/mgit-at/collectd-haproxy","homepage":"","size":9,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"signalfx:master","ref":"master","sha":"d890690fc9b313c13f8a8c003cee16c3ca2f4cfa","user":{"login":"signalfx","id":8184587,"avatar_url":"https://avatars.githubusercontent.com/u/8184587?v=3","gravatar_id":"","url":"https://api.github.com/users/signalfx","html_url":"https://github.com/signalfx","followers_url":"https://api.github.com/users/signalfx/followers","following_url":"https://api.github.com/users/signalfx/following{/other_user}","gists_url":"https://api.github.com/users/signalfx/gists{/gist_id}","starred_url":"https://api.github.com/users/signalfx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/signalfx/subscriptions","organizations_url":"https://api.github.com/users/signalfx/orgs","repos_url":"https://api.github.com/users/signalfx/repos","events_url":"https://api.github.com/users/signalfx/events{/privacy}","received_events_url":"https://api.github.com/users/signalfx/received_events","type":"Organization","site_admin":false},"repo":{"id":40140442,"name":"collectd-haproxy","full_name":"signalfx/collectd-haproxy","owner":{"login":"signalfx","id":8184587,"avatar_url":"https://avatars.githubusercontent.com/u/8184587?v=3","gravatar_id":"","url":"https://api.github.com/users/signalfx","html_url":"https://github.com/signalfx","followers_url":"https://api.github.com/users/signalfx/followers","following_url":"https://api.github.com/users/signalfx/following{/other_user}","gists_url":"https://api.github.com/users/signalfx/gists{/gist_id}","starred_url":"https://api.github.com/users/signalfx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/signalfx/subscriptions","organizations_url":"https://api.github.com/users/signalfx/orgs","repos_url":"https://api.github.com/users/signalfx/repos","events_url":"https://api.github.com/users/signalfx/events{/privacy}","received_events_url":"https://api.github.com/users/signalfx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/signalfx/collectd-haproxy","description":"A collectd plugin to collect statistics from HAProxy","fork":true,"url":"https://api.github.com/repos/signalfx/collectd-haproxy","forks_url":"https://api.github.com/repos/signalfx/collectd-haproxy/forks","keys_url":"https://api.github.com/repos/signalfx/collectd-haproxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/signalfx/collectd-haproxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/signalfx/collectd-haproxy/teams","hooks_url":"https://api.github.com/repos/signalfx/collectd-haproxy/hooks","issue_events_url":"https://api.github.com/repos/signalfx/collectd-haproxy/issues/events{/number}","events_url":"https://api.github.com/repos/signalfx/collectd-haproxy/events","assignees_url":"https://api.github.com/repos/signalfx/collectd-haproxy/assignees{/user}","branches_url":"https://api.github.com/repos/signalfx/collectd-haproxy/branches{/branch}","tags_url":"https://api.github.com/repos/signalfx/collectd-haproxy/tags","blobs_url":"https://api.github.com/repos/signalfx/collectd-haproxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/signalfx/collectd-haproxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/signalfx/collectd-haproxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/signalfx/collectd-haproxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/signalfx/collectd-haproxy/statuses/{sha}","languages_url":"https://api.github.com/repos/signalfx/collectd-haproxy/languages","stargazers_url":"https://api.github.com/repos/signalfx/collectd-haproxy/stargazers","contributors_url":"https://api.github.com/repos/signalfx/collectd-haproxy/contributors","subscribers_url":"https://api.github.com/repos/signalfx/collectd-haproxy/subscribers","subscription_url":"https://api.github.com/repos/signalfx/collectd-haproxy/subscription","commits_url":"https://api.github.com/repos/signalfx/collectd-haproxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/signalfx/collectd-haproxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/signalfx/collectd-haproxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/signalfx/collectd-haproxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/signalfx/collectd-haproxy/contents/{+path}","compare_url":"https://api.github.com/repos/signalfx/collectd-haproxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/signalfx/collectd-haproxy/merges","archive_url":"https://api.github.com/repos/signalfx/collectd-haproxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/signalfx/collectd-haproxy/downloads","issues_url":"https://api.github.com/repos/signalfx/collectd-haproxy/issues{/number}","pulls_url":"https://api.github.com/repos/signalfx/collectd-haproxy/pulls{/number}","milestones_url":"https://api.github.com/repos/signalfx/collectd-haproxy/milestones{/number}","notifications_url":"https://api.github.com/repos/signalfx/collectd-haproxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/signalfx/collectd-haproxy/labels{/name}","releases_url":"https://api.github.com/repos/signalfx/collectd-haproxy/releases{/id}","deployments_url":"https://api.github.com/repos/signalfx/collectd-haproxy/deployments","created_at":"2015-08-03T18:12:53Z","updated_at":"2016-01-11T13:18:02Z","pushed_at":"2016-01-27T02:15:38Z","git_url":"git://github.com/signalfx/collectd-haproxy.git","ssh_url":"git@github.com:signalfx/collectd-haproxy.git","clone_url":"https://github.com/signalfx/collectd-haproxy.git","svn_url":"https://github.com/signalfx/collectd-haproxy","homepage":"","size":128,"stargazers_count":4,"watchers_count":4,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":3,"forks":5,"open_issues":3,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/signalfx/collectd-haproxy/pulls/2"},"html":{"href":"https://github.com/signalfx/collectd-haproxy/pull/2"},"issue":{"href":"https://api.github.com/repos/signalfx/collectd-haproxy/issues/2"},"comments":{"href":"https://api.github.com/repos/signalfx/collectd-haproxy/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/signalfx/collectd-haproxy/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/signalfx/collectd-haproxy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/signalfx/collectd-haproxy/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/signalfx/collectd-haproxy/statuses/d6f8d18a197679f877e7274fa61ca161d5df3dd5"}}}}