{"action":"created","issue":{"url":"https://api.github.com/repos/chipKIT32/chipKIT-core/issues/193","repository_url":"https://api.github.com/repos/chipKIT32/chipKIT-core","labels_url":"https://api.github.com/repos/chipKIT32/chipKIT-core/issues/193/labels{/name}","comments_url":"https://api.github.com/repos/chipKIT32/chipKIT-core/issues/193/comments","events_url":"https://api.github.com/repos/chipKIT32/chipKIT-core/issues/193/events","html_url":"https://github.com/chipKIT32/chipKIT-core/pull/193","id":138882060,"number":193,"title":"Combined fixes: SPI, WInterrupt, wiring","user":{"login":"xxxajk","id":3876044,"avatar_url":"https://avatars.githubusercontent.com/u/3876044?v=3","gravatar_id":"","url":"https://api.github.com/users/xxxajk","html_url":"https://github.com/xxxajk","followers_url":"https://api.github.com/users/xxxajk/followers","following_url":"https://api.github.com/users/xxxajk/following{/other_user}","gists_url":"https://api.github.com/users/xxxajk/gists{/gist_id}","starred_url":"https://api.github.com/users/xxxajk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xxxajk/subscriptions","organizations_url":"https://api.github.com/users/xxxajk/orgs","repos_url":"https://api.github.com/users/xxxajk/repos","events_url":"https://api.github.com/users/xxxajk/events{/privacy}","received_events_url":"https://api.github.com/users/xxxajk/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":17,"created_at":"2016-03-07T04:15:16Z","updated_at":"2016-03-14T01:13:17Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/chipKIT32/chipKIT-core/pulls/193","html_url":"https://github.com/chipKIT32/chipKIT-core/pull/193","diff_url":"https://github.com/chipKIT32/chipKIT-core/pull/193.diff","patch_url":"https://github.com/chipKIT32/chipKIT-core/pull/193.patch"},"body":"This patch set incorporates the following enhancements and bugfixes:\r\n\r\n1: External interrupts can now work with HIGH and LOW states via emulation.\r\n2. wiring corrected the CHANGE FALLING RISING definitions. \r\n3: SPI library now is properly atomic.\r\n4: variants uC32 and UNO32, added missing definitions, \r\n"},"comment":{"url":"https://api.github.com/repos/chipKIT32/chipKIT-core/issues/comments/196093742","html_url":"https://github.com/chipKIT32/chipKIT-core/pull/193#issuecomment-196093742","issue_url":"https://api.github.com/repos/chipKIT32/chipKIT-core/issues/193","id":196093742,"user":{"login":"EmbeddedMan","id":450056,"avatar_url":"https://avatars.githubusercontent.com/u/450056?v=3","gravatar_id":"","url":"https://api.github.com/users/EmbeddedMan","html_url":"https://github.com/EmbeddedMan","followers_url":"https://api.github.com/users/EmbeddedMan/followers","following_url":"https://api.github.com/users/EmbeddedMan/following{/other_user}","gists_url":"https://api.github.com/users/EmbeddedMan/gists{/gist_id}","starred_url":"https://api.github.com/users/EmbeddedMan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EmbeddedMan/subscriptions","organizations_url":"https://api.github.com/users/EmbeddedMan/orgs","repos_url":"https://api.github.com/users/EmbeddedMan/repos","events_url":"https://api.github.com/users/EmbeddedMan/events{/privacy}","received_events_url":"https://api.github.com/users/EmbeddedMan/received_events","type":"User","site_admin":false},"created_at":"2016-03-14T01:13:17Z","updated_at":"2016-03-14T01:13:17Z","body":"Sure - we'll have no problem getting people to agree on that one Andrew.\n:-| At work I insist that people use 2 spaces instead of tabs, although\nmuch of the code we get from vendors uses 3 spaces instead of a tab, so it\nall has to be reformatted. Honestly, I can't imagine using 8 spaces per tab\n- with just 4 indent levels, you're already 32 spaces in!\n\nOn Sun, Mar 13, 2016 at 8:02 PM, Andrew Kroll <notifications@github.com>\nwrote:\n\n> Most of it tends to be intertwined. IRQ and SPI transaction code in\n> particular are interdependent, so proceed with great care if you want\n> separate chunks to work independently. Normally I would have done several\n> smaller PRs, but sometimes one big chunk is the way to go.\n>\n> <rant>\n> On another note, indirectly related... who is the moron instructor teaching\n> people that tabs are 4 spaces? I see this horrid practice pop up over the\n> last 5 to 10 years, and it really makes code hard to follow. Even K&R say\n> 8. 8 space tabs has been since the invention of the typewriter. Research\n> this yourself if you wish, there is an actual scientific reason for it-- it\n> makes things easy to read.\n> Is there any chance that a reformat would be accepted? I'm willing to do\n> this.\n> </rant>\n> On Mar 13, 2016 8:51 PM, \"Brian Schmalz\" <notifications@github.com> wrote:\n>\n> > Hey, I just wanted to say thank you to everybody for putting in so much\n> > effort on this PR. I really like the direction the discussion took. I\n> have\n> > not had time yet to go over all of the technical details presented here,\n> > but I plan to this week. Likely I'll ask that it be split into a few\n> > smaller PRs that have separate purposes. More to follow soon-\n> >\n> > —\n> > Reply to this email directly or view it on GitHub\n> > <\n> https://github.com/chipKIT32/chipKIT-core/pull/193#issuecomment-196091362>\n> > .\n>\n> >\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/chipKIT32/chipKIT-core/pull/193#issuecomment-196092832>\n> .\n>\n"}}