{"action":"created","comment":{"url":"https://api.github.com/repos/Harvard-ATG/media_management_api/pulls/comments/82000748","pull_request_review_id":2938831,"id":82000748,"diff_hunk":"@@ -240,7 +245,7 @@ def __init__(self, manifest, canvas_id):\n         self.resource = None\n \n     def add_image(self, image):\n-        self.resource = IIIFImageResource(self.manifest, image['id'], image['url'], image['is_link'])\n+        self.resource = IIIFImageResource(self.manifest, self.id, image['url'], image['is_link'])","path":"media_service/iiif.py","position":26,"original_position":26,"commit_id":"d0546d126833e6a910bee505af07d8f002c71c2c","original_commit_id":"d0546d126833e6a910bee505af07d8f002c71c2c","user":{"login":"arthurian","id":1165361,"avatar_url":"https://avatars.githubusercontent.com/u/1165361?v=3","gravatar_id":"","url":"https://api.github.com/users/arthurian","html_url":"https://github.com/arthurian","followers_url":"https://api.github.com/users/arthurian/followers","following_url":"https://api.github.com/users/arthurian/following{/other_user}","gists_url":"https://api.github.com/users/arthurian/gists{/gist_id}","starred_url":"https://api.github.com/users/arthurian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arthurian/subscriptions","organizations_url":"https://api.github.com/users/arthurian/orgs","repos_url":"https://api.github.com/users/arthurian/repos","events_url":"https://api.github.com/users/arthurian/events{/privacy}","received_events_url":"https://api.github.com/users/arthurian/received_events","type":"User","site_admin":false},"body":"Yes, you're correct. Structuring it so that we only ever have one image per canvas means that Mirador will only really function as a slide viewer. It's possible that down the line we might have to change this decision and make it more flexible.","created_at":"2016-10-05T15:30:16Z","updated_at":"2016-10-05T15:30:17Z","html_url":"https://github.com/Harvard-ATG/media_management_api/pull/24#discussion_r82000748","pull_request_url":"https://api.github.com/repos/Harvard-ATG/media_management_api/pulls/24","_links":{"self":{"href":"https://api.github.com/repos/Harvard-ATG/media_management_api/pulls/comments/82000748"},"html":{"href":"https://github.com/Harvard-ATG/media_management_api/pull/24#discussion_r82000748"},"pull_request":{"href":"https://api.github.com/repos/Harvard-ATG/media_management_api/pulls/24"}}},"pull_request":{"url":"https://api.github.com/repos/Harvard-ATG/media_management_api/pulls/24","id":87790962,"html_url":"https://github.com/Harvard-ATG/media_management_api/pull/24","diff_url":"https://github.com/Harvard-ATG/media_management_api/pull/24.diff","patch_url":"https://github.com/Harvard-ATG/media_management_api/pull/24.patch","issue_url":"https://api.github.com/repos/Harvard-ATG/media_management_api/issues/24","number":24,"state":"open","locked":false,"title":"bugfix/iiif-canvas-uniqueness","user":{"login":"arthurian","id":1165361,"avatar_url":"https://avatars.githubusercontent.com/u/1165361?v=3","gravatar_id":"","url":"https://api.github.com/users/arthurian","html_url":"https://github.com/arthurian","followers_url":"https://api.github.com/users/arthurian/followers","following_url":"https://api.github.com/users/arthurian/following{/other_user}","gists_url":"https://api.github.com/users/arthurian/gists{/gist_id}","starred_url":"https://api.github.com/users/arthurian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arthurian/subscriptions","organizations_url":"https://api.github.com/users/arthurian/orgs","repos_url":"https://api.github.com/users/arthurian/repos","events_url":"https://api.github.com/users/arthurian/events{/privacy}","received_events_url":"https://api.github.com/users/arthurian/received_events","type":"User","site_admin":false},"body":"This fixes an issue where instructors added duplicate images to collections in the Media Manager, which caused Mirador to not work properly (navigating between images in the collection). Every canvas in the IIIF manifest must have a unique canvas ID in order for Mirador to work properly, so this PR ensures uniqueness by qualifying the canvas object IDs with an index.\r\n\r\n@elliottyates Review?\r\n\r\n---\r\n[ATGU-549](https://jira.huit.harvard.edu/browse/ATGU-549)","created_at":"2016-10-03T21:00:27Z","updated_at":"2016-10-05T15:30:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"25d4d516bb8f7dcb16b6308d59dedba40f2034da","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Harvard-ATG/media_management_api/pulls/24/commits","review_comments_url":"https://api.github.com/repos/Harvard-ATG/media_management_api/pulls/24/comments","review_comment_url":"https://api.github.com/repos/Harvard-ATG/media_management_api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Harvard-ATG/media_management_api/issues/24/comments","statuses_url":"https://api.github.com/repos/Harvard-ATG/media_management_api/statuses/d0546d126833e6a910bee505af07d8f002c71c2c","head":{"label":"Harvard-ATG:bugfix/iiif-canvas-uniqueness","ref":"bugfix/iiif-canvas-uniqueness","sha":"d0546d126833e6a910bee505af07d8f002c71c2c","user":{"login":"Harvard-ATG","id":2099831,"avatar_url":"https://avatars.githubusercontent.com/u/2099831?v=3","gravatar_id":"","url":"https://api.github.com/users/Harvard-ATG","html_url":"https://github.com/Harvard-ATG","followers_url":"https://api.github.com/users/Harvard-ATG/followers","following_url":"https://api.github.com/users/Harvard-ATG/following{/other_user}","gists_url":"https://api.github.com/users/Harvard-ATG/gists{/gist_id}","starred_url":"https://api.github.com/users/Harvard-ATG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Harvard-ATG/subscriptions","organizations_url":"https://api.github.com/users/Harvard-ATG/orgs","repos_url":"https://api.github.com/users/Harvard-ATG/repos","events_url":"https://api.github.com/users/Harvard-ATG/events{/privacy}","received_events_url":"https://api.github.com/users/Harvard-ATG/received_events","type":"Organization","site_admin":false},"repo":{"id":47143850,"name":"media_management_api","full_name":"Harvard-ATG/media_management_api","owner":{"login":"Harvard-ATG","id":2099831,"avatar_url":"https://avatars.githubusercontent.com/u/2099831?v=3","gravatar_id":"","url":"https://api.github.com/users/Harvard-ATG","html_url":"https://github.com/Harvard-ATG","followers_url":"https://api.github.com/users/Harvard-ATG/followers","following_url":"https://api.github.com/users/Harvard-ATG/following{/other_user}","gists_url":"https://api.github.com/users/Harvard-ATG/gists{/gist_id}","starred_url":"https://api.github.com/users/Harvard-ATG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Harvard-ATG/subscriptions","organizations_url":"https://api.github.com/users/Harvard-ATG/orgs","repos_url":"https://api.github.com/users/Harvard-ATG/repos","events_url":"https://api.github.com/users/Harvard-ATG/events{/privacy}","received_events_url":"https://api.github.com/users/Harvard-ATG/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Harvard-ATG/media_management_api","description":"Media Management API","fork":false,"url":"https://api.github.com/repos/Harvard-ATG/media_management_api","forks_url":"https://api.github.com/repos/Harvard-ATG/media_management_api/forks","keys_url":"https://api.github.com/repos/Harvard-ATG/media_management_api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Harvard-ATG/media_management_api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Harvard-ATG/media_management_api/teams","hooks_url":"https://api.github.com/repos/Harvard-ATG/media_management_api/hooks","issue_events_url":"https://api.github.com/repos/Harvard-ATG/media_management_api/issues/events{/number}","events_url":"https://api.github.com/repos/Harvard-ATG/media_management_api/events","assignees_url":"https://api.github.com/repos/Harvard-ATG/media_management_api/assignees{/user}","branches_url":"https://api.github.com/repos/Harvard-ATG/media_management_api/branches{/branch}","tags_url":"https://api.github.com/repos/Harvard-ATG/media_management_api/tags","blobs_url":"https://api.github.com/repos/Harvard-ATG/media_management_api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Harvard-ATG/media_management_api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Harvard-ATG/media_management_api/git/refs{/sha}","trees_url":"https://api.github.com/repos/Harvard-ATG/media_management_api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Harvard-ATG/media_management_api/statuses/{sha}","languages_url":"https://api.github.com/repos/Harvard-ATG/media_management_api/languages","stargazers_url":"https://api.github.com/repos/Harvard-ATG/media_management_api/stargazers","contributors_url":"https://api.github.com/repos/Harvard-ATG/media_management_api/contributors","subscribers_url":"https://api.github.com/repos/Harvard-ATG/media_management_api/subscribers","subscription_url":"https://api.github.com/repos/Harvard-ATG/media_management_api/subscription","commits_url":"https://api.github.com/repos/Harvard-ATG/media_management_api/commits{/sha}","git_commits_url":"https://api.github.com/repos/Harvard-ATG/media_management_api/git/commits{/sha}","comments_url":"https://api.github.com/repos/Harvard-ATG/media_management_api/comments{/number}","issue_comment_url":"https://api.github.com/repos/Harvard-ATG/media_management_api/issues/comments{/number}","contents_url":"https://api.github.com/repos/Harvard-ATG/media_management_api/contents/{+path}","compare_url":"https://api.github.com/repos/Harvard-ATG/media_management_api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Harvard-ATG/media_management_api/merges","archive_url":"https://api.github.com/repos/Harvard-ATG/media_management_api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Harvard-ATG/media_management_api/downloads","issues_url":"https://api.github.com/repos/Harvard-ATG/media_management_api/issues{/number}","pulls_url":"https://api.github.com/repos/Harvard-ATG/media_management_api/pulls{/number}","milestones_url":"https://api.github.com/repos/Harvard-ATG/media_management_api/milestones{/number}","notifications_url":"https://api.github.com/repos/Harvard-ATG/media_management_api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Harvard-ATG/media_management_api/labels{/name}","releases_url":"https://api.github.com/repos/Harvard-ATG/media_management_api/releases{/id}","deployments_url":"https://api.github.com/repos/Harvard-ATG/media_management_api/deployments","created_at":"2015-11-30T20:23:54Z","updated_at":"2016-01-11T17:11:56Z","pushed_at":"2016-10-05T15:10:44Z","git_url":"git://github.com/Harvard-ATG/media_management_api.git","ssh_url":"git@github.com:Harvard-ATG/media_management_api.git","clone_url":"https://github.com/Harvard-ATG/media_management_api.git","svn_url":"https://github.com/Harvard-ATG/media_management_api","homepage":"","size":139,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":0,"default_branch":"master"}},"base":{"label":"Harvard-ATG:master","ref":"master","sha":"9d64ff73c0a56af9af306f226a4fcc71b3d9c3a5","user":{"login":"Harvard-ATG","id":2099831,"avatar_url":"https://avatars.githubusercontent.com/u/2099831?v=3","gravatar_id":"","url":"https://api.github.com/users/Harvard-ATG","html_url":"https://github.com/Harvard-ATG","followers_url":"https://api.github.com/users/Harvard-ATG/followers","following_url":"https://api.github.com/users/Harvard-ATG/following{/other_user}","gists_url":"https://api.github.com/users/Harvard-ATG/gists{/gist_id}","starred_url":"https://api.github.com/users/Harvard-ATG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Harvard-ATG/subscriptions","organizations_url":"https://api.github.com/users/Harvard-ATG/orgs","repos_url":"https://api.github.com/users/Harvard-ATG/repos","events_url":"https://api.github.com/users/Harvard-ATG/events{/privacy}","received_events_url":"https://api.github.com/users/Harvard-ATG/received_events","type":"Organization","site_admin":false},"repo":{"id":47143850,"name":"media_management_api","full_name":"Harvard-ATG/media_management_api","owner":{"login":"Harvard-ATG","id":2099831,"avatar_url":"https://avatars.githubusercontent.com/u/2099831?v=3","gravatar_id":"","url":"https://api.github.com/users/Harvard-ATG","html_url":"https://github.com/Harvard-ATG","followers_url":"https://api.github.com/users/Harvard-ATG/followers","following_url":"https://api.github.com/users/Harvard-ATG/following{/other_user}","gists_url":"https://api.github.com/users/Harvard-ATG/gists{/gist_id}","starred_url":"https://api.github.com/users/Harvard-ATG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Harvard-ATG/subscriptions","organizations_url":"https://api.github.com/users/Harvard-ATG/orgs","repos_url":"https://api.github.com/users/Harvard-ATG/repos","events_url":"https://api.github.com/users/Harvard-ATG/events{/privacy}","received_events_url":"https://api.github.com/users/Harvard-ATG/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Harvard-ATG/media_management_api","description":"Media Management API","fork":false,"url":"https://api.github.com/repos/Harvard-ATG/media_management_api","forks_url":"https://api.github.com/repos/Harvard-ATG/media_management_api/forks","keys_url":"https://api.github.com/repos/Harvard-ATG/media_management_api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Harvard-ATG/media_management_api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Harvard-ATG/media_management_api/teams","hooks_url":"https://api.github.com/repos/Harvard-ATG/media_management_api/hooks","issue_events_url":"https://api.github.com/repos/Harvard-ATG/media_management_api/issues/events{/number}","events_url":"https://api.github.com/repos/Harvard-ATG/media_management_api/events","assignees_url":"https://api.github.com/repos/Harvard-ATG/media_management_api/assignees{/user}","branches_url":"https://api.github.com/repos/Harvard-ATG/media_management_api/branches{/branch}","tags_url":"https://api.github.com/repos/Harvard-ATG/media_management_api/tags","blobs_url":"https://api.github.com/repos/Harvard-ATG/media_management_api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Harvard-ATG/media_management_api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Harvard-ATG/media_management_api/git/refs{/sha}","trees_url":"https://api.github.com/repos/Harvard-ATG/media_management_api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Harvard-ATG/media_management_api/statuses/{sha}","languages_url":"https://api.github.com/repos/Harvard-ATG/media_management_api/languages","stargazers_url":"https://api.github.com/repos/Harvard-ATG/media_management_api/stargazers","contributors_url":"https://api.github.com/repos/Harvard-ATG/media_management_api/contributors","subscribers_url":"https://api.github.com/repos/Harvard-ATG/media_management_api/subscribers","subscription_url":"https://api.github.com/repos/Harvard-ATG/media_management_api/subscription","commits_url":"https://api.github.com/repos/Harvard-ATG/media_management_api/commits{/sha}","git_commits_url":"https://api.github.com/repos/Harvard-ATG/media_management_api/git/commits{/sha}","comments_url":"https://api.github.com/repos/Harvard-ATG/media_management_api/comments{/number}","issue_comment_url":"https://api.github.com/repos/Harvard-ATG/media_management_api/issues/comments{/number}","contents_url":"https://api.github.com/repos/Harvard-ATG/media_management_api/contents/{+path}","compare_url":"https://api.github.com/repos/Harvard-ATG/media_management_api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Harvard-ATG/media_management_api/merges","archive_url":"https://api.github.com/repos/Harvard-ATG/media_management_api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Harvard-ATG/media_management_api/downloads","issues_url":"https://api.github.com/repos/Harvard-ATG/media_management_api/issues{/number}","pulls_url":"https://api.github.com/repos/Harvard-ATG/media_management_api/pulls{/number}","milestones_url":"https://api.github.com/repos/Harvard-ATG/media_management_api/milestones{/number}","notifications_url":"https://api.github.com/repos/Harvard-ATG/media_management_api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Harvard-ATG/media_management_api/labels{/name}","releases_url":"https://api.github.com/repos/Harvard-ATG/media_management_api/releases{/id}","deployments_url":"https://api.github.com/repos/Harvard-ATG/media_management_api/deployments","created_at":"2015-11-30T20:23:54Z","updated_at":"2016-01-11T17:11:56Z","pushed_at":"2016-10-05T15:10:44Z","git_url":"git://github.com/Harvard-ATG/media_management_api.git","ssh_url":"git@github.com:Harvard-ATG/media_management_api.git","clone_url":"https://github.com/Harvard-ATG/media_management_api.git","svn_url":"https://github.com/Harvard-ATG/media_management_api","homepage":"","size":139,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Harvard-ATG/media_management_api/pulls/24"},"html":{"href":"https://github.com/Harvard-ATG/media_management_api/pull/24"},"issue":{"href":"https://api.github.com/repos/Harvard-ATG/media_management_api/issues/24"},"comments":{"href":"https://api.github.com/repos/Harvard-ATG/media_management_api/issues/24/comments"},"review_comments":{"href":"https://api.github.com/repos/Harvard-ATG/media_management_api/pulls/24/comments"},"review_comment":{"href":"https://api.github.com/repos/Harvard-ATG/media_management_api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Harvard-ATG/media_management_api/pulls/24/commits"},"statuses":{"href":"https://api.github.com/repos/Harvard-ATG/media_management_api/statuses/d0546d126833e6a910bee505af07d8f002c71c2c"}}}}
{"actor":{"display_login":"arthurian"}}