{"action":"created","comment":{"url":"https://api.github.com/repos/eclipsesource/jsonforms/pulls/comments/69923525","id":69923525,"diff_hunk":"@@ -166,11 +166,19 @@ export interface JsonFormsDirectiveScope extends ng.IScope {\n     data: any;\n }\n \n+const formTemplate = `\n+<div>\n+    <form role='form' class='jsf-form rounded'></form>\n+</div>`;\n \n-export class JsonFormsDirective implements ng.IDirective {\n \n+export class JsonFormsDirective implements ng.IDirective {\n+    static $inject = ['$templateCache'];\n+    constructor($templateCache: ng.ITemplateCacheService) {\n+        $templateCache.put('form.html', formTemplate);","path":"src/components/form/form-directive.ts","position":30,"original_position":30,"commit_id":"16ce4150a841d4c4dfe69990e6dce52eb362a49a","original_commit_id":"16ce4150a841d4c4dfe69990e6dce52eb362a49a","user":{"login":"eneufeld","id":1176277,"avatar_url":"https://avatars.githubusercontent.com/u/1176277?v=3","gravatar_id":"","url":"https://api.github.com/users/eneufeld","html_url":"https://github.com/eneufeld","followers_url":"https://api.github.com/users/eneufeld/followers","following_url":"https://api.github.com/users/eneufeld/following{/other_user}","gists_url":"https://api.github.com/users/eneufeld/gists{/gist_id}","starred_url":"https://api.github.com/users/eneufeld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eneufeld/subscriptions","organizations_url":"https://api.github.com/users/eneufeld/orgs","repos_url":"https://api.github.com/users/eneufeld/repos","events_url":"https://api.github.com/users/eneufeld/events{/privacy}","received_events_url":"https://api.github.com/users/eneufeld/received_events","type":"User","site_admin":false},"body":"why not do this in a run block, just like in all other cases?","created_at":"2016-07-07T15:04:21Z","updated_at":"2016-07-07T15:04:21Z","html_url":"https://github.com/eclipsesource/jsonforms/pull/289#discussion_r69923525","pull_request_url":"https://api.github.com/repos/eclipsesource/jsonforms/pulls/289","_links":{"self":{"href":"https://api.github.com/repos/eclipsesource/jsonforms/pulls/comments/69923525"},"html":{"href":"https://github.com/eclipsesource/jsonforms/pull/289#discussion_r69923525"},"pull_request":{"href":"https://api.github.com/repos/eclipsesource/jsonforms/pulls/289"}}},"pull_request":{"url":"https://api.github.com/repos/eclipsesource/jsonforms/pulls/289","id":76610109,"html_url":"https://github.com/eclipsesource/jsonforms/pull/289","diff_url":"https://github.com/eclipsesource/jsonforms/pull/289.diff","patch_url":"https://github.com/eclipsesource/jsonforms/pull/289.patch","issue_url":"https://api.github.com/repos/eclipsesource/jsonforms/issues/289","number":289,"state":"open","locked":false,"title":"Configure typings for external use","user":{"login":"edgarmueller","id":711092,"avatar_url":"https://avatars.githubusercontent.com/u/711092?v=3","gravatar_id":"","url":"https://api.github.com/users/edgarmueller","html_url":"https://github.com/edgarmueller","followers_url":"https://api.github.com/users/edgarmueller/followers","following_url":"https://api.github.com/users/edgarmueller/following{/other_user}","gists_url":"https://api.github.com/users/edgarmueller/gists{/gist_id}","starred_url":"https://api.github.com/users/edgarmueller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edgarmueller/subscriptions","organizations_url":"https://api.github.com/users/edgarmueller/orgs","repos_url":"https://api.github.com/users/edgarmueller/repos","events_url":"https://api.github.com/users/edgarmueller/events{/privacy}","received_events_url":"https://api.github.com/users/edgarmueller/received_events","type":"User","site_admin":false},"body":"Export typings and put generated source into root folder (also update .gitignore).  This enables API consumers to do imports a-la `import { ... } from \"jsonforms\"`.\r\n\r\nI'm not sure whether all required types/values are exported but I'd add those opportunistically.","created_at":"2016-07-07T14:57:41Z","updated_at":"2016-07-07T15:04:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4e28a8d3b88af020220418775036e20985e4fcf6","assignee":{"login":"eneufeld","id":1176277,"avatar_url":"https://avatars.githubusercontent.com/u/1176277?v=3","gravatar_id":"","url":"https://api.github.com/users/eneufeld","html_url":"https://github.com/eneufeld","followers_url":"https://api.github.com/users/eneufeld/followers","following_url":"https://api.github.com/users/eneufeld/following{/other_user}","gists_url":"https://api.github.com/users/eneufeld/gists{/gist_id}","starred_url":"https://api.github.com/users/eneufeld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eneufeld/subscriptions","organizations_url":"https://api.github.com/users/eneufeld/orgs","repos_url":"https://api.github.com/users/eneufeld/repos","events_url":"https://api.github.com/users/eneufeld/events{/privacy}","received_events_url":"https://api.github.com/users/eneufeld/received_events","type":"User","site_admin":false},"assignees":[{"login":"eneufeld","id":1176277,"avatar_url":"https://avatars.githubusercontent.com/u/1176277?v=3","gravatar_id":"","url":"https://api.github.com/users/eneufeld","html_url":"https://github.com/eneufeld","followers_url":"https://api.github.com/users/eneufeld/followers","following_url":"https://api.github.com/users/eneufeld/following{/other_user}","gists_url":"https://api.github.com/users/eneufeld/gists{/gist_id}","starred_url":"https://api.github.com/users/eneufeld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eneufeld/subscriptions","organizations_url":"https://api.github.com/users/eneufeld/orgs","repos_url":"https://api.github.com/users/eneufeld/repos","events_url":"https://api.github.com/users/eneufeld/events{/privacy}","received_events_url":"https://api.github.com/users/eneufeld/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/eclipsesource/jsonforms/milestones/7","html_url":"https://github.com/eclipsesource/jsonforms/milestones/1.0.0","labels_url":"https://api.github.com/repos/eclipsesource/jsonforms/milestones/7/labels","id":1846870,"number":7,"title":"1.0.0","description":"","creator":{"login":"edgarmueller","id":711092,"avatar_url":"https://avatars.githubusercontent.com/u/711092?v=3","gravatar_id":"","url":"https://api.github.com/users/edgarmueller","html_url":"https://github.com/edgarmueller","followers_url":"https://api.github.com/users/edgarmueller/followers","following_url":"https://api.github.com/users/edgarmueller/following{/other_user}","gists_url":"https://api.github.com/users/edgarmueller/gists{/gist_id}","starred_url":"https://api.github.com/users/edgarmueller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edgarmueller/subscriptions","organizations_url":"https://api.github.com/users/edgarmueller/orgs","repos_url":"https://api.github.com/users/edgarmueller/repos","events_url":"https://api.github.com/users/edgarmueller/events{/privacy}","received_events_url":"https://api.github.com/users/edgarmueller/received_events","type":"User","site_admin":false},"open_issues":8,"closed_issues":3,"state":"open","created_at":"2016-06-24T09:21:04Z","updated_at":"2016-07-07T14:57:57Z","due_on":"2016-07-28T22:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/eclipsesource/jsonforms/pulls/289/commits","review_comments_url":"https://api.github.com/repos/eclipsesource/jsonforms/pulls/289/comments","review_comment_url":"https://api.github.com/repos/eclipsesource/jsonforms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipsesource/jsonforms/issues/289/comments","statuses_url":"https://api.github.com/repos/eclipsesource/jsonforms/statuses/16ce4150a841d4c4dfe69990e6dce52eb362a49a","head":{"label":"edgarmueller:master","ref":"master","sha":"16ce4150a841d4c4dfe69990e6dce52eb362a49a","user":{"login":"edgarmueller","id":711092,"avatar_url":"https://avatars.githubusercontent.com/u/711092?v=3","gravatar_id":"","url":"https://api.github.com/users/edgarmueller","html_url":"https://github.com/edgarmueller","followers_url":"https://api.github.com/users/edgarmueller/followers","following_url":"https://api.github.com/users/edgarmueller/following{/other_user}","gists_url":"https://api.github.com/users/edgarmueller/gists{/gist_id}","starred_url":"https://api.github.com/users/edgarmueller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edgarmueller/subscriptions","organizations_url":"https://api.github.com/users/edgarmueller/orgs","repos_url":"https://api.github.com/users/edgarmueller/repos","events_url":"https://api.github.com/users/edgarmueller/events{/privacy}","received_events_url":"https://api.github.com/users/edgarmueller/received_events","type":"User","site_admin":false},"repo":{"id":31428304,"name":"jsonforms","full_name":"edgarmueller/jsonforms","owner":{"login":"edgarmueller","id":711092,"avatar_url":"https://avatars.githubusercontent.com/u/711092?v=3","gravatar_id":"","url":"https://api.github.com/users/edgarmueller","html_url":"https://github.com/edgarmueller","followers_url":"https://api.github.com/users/edgarmueller/followers","following_url":"https://api.github.com/users/edgarmueller/following{/other_user}","gists_url":"https://api.github.com/users/edgarmueller/gists{/gist_id}","starred_url":"https://api.github.com/users/edgarmueller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edgarmueller/subscriptions","organizations_url":"https://api.github.com/users/edgarmueller/orgs","repos_url":"https://api.github.com/users/edgarmueller/repos","events_url":"https://api.github.com/users/edgarmueller/events{/privacy}","received_events_url":"https://api.github.com/users/edgarmueller/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/edgarmueller/jsonforms","description":"AngularJS-based forms for JSON data.","fork":true,"url":"https://api.github.com/repos/edgarmueller/jsonforms","forks_url":"https://api.github.com/repos/edgarmueller/jsonforms/forks","keys_url":"https://api.github.com/repos/edgarmueller/jsonforms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edgarmueller/jsonforms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edgarmueller/jsonforms/teams","hooks_url":"https://api.github.com/repos/edgarmueller/jsonforms/hooks","issue_events_url":"https://api.github.com/repos/edgarmueller/jsonforms/issues/events{/number}","events_url":"https://api.github.com/repos/edgarmueller/jsonforms/events","assignees_url":"https://api.github.com/repos/edgarmueller/jsonforms/assignees{/user}","branches_url":"https://api.github.com/repos/edgarmueller/jsonforms/branches{/branch}","tags_url":"https://api.github.com/repos/edgarmueller/jsonforms/tags","blobs_url":"https://api.github.com/repos/edgarmueller/jsonforms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edgarmueller/jsonforms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edgarmueller/jsonforms/git/refs{/sha}","trees_url":"https://api.github.com/repos/edgarmueller/jsonforms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edgarmueller/jsonforms/statuses/{sha}","languages_url":"https://api.github.com/repos/edgarmueller/jsonforms/languages","stargazers_url":"https://api.github.com/repos/edgarmueller/jsonforms/stargazers","contributors_url":"https://api.github.com/repos/edgarmueller/jsonforms/contributors","subscribers_url":"https://api.github.com/repos/edgarmueller/jsonforms/subscribers","subscription_url":"https://api.github.com/repos/edgarmueller/jsonforms/subscription","commits_url":"https://api.github.com/repos/edgarmueller/jsonforms/commits{/sha}","git_commits_url":"https://api.github.com/repos/edgarmueller/jsonforms/git/commits{/sha}","comments_url":"https://api.github.com/repos/edgarmueller/jsonforms/comments{/number}","issue_comment_url":"https://api.github.com/repos/edgarmueller/jsonforms/issues/comments{/number}","contents_url":"https://api.github.com/repos/edgarmueller/jsonforms/contents/{+path}","compare_url":"https://api.github.com/repos/edgarmueller/jsonforms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edgarmueller/jsonforms/merges","archive_url":"https://api.github.com/repos/edgarmueller/jsonforms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edgarmueller/jsonforms/downloads","issues_url":"https://api.github.com/repos/edgarmueller/jsonforms/issues{/number}","pulls_url":"https://api.github.com/repos/edgarmueller/jsonforms/pulls{/number}","milestones_url":"https://api.github.com/repos/edgarmueller/jsonforms/milestones{/number}","notifications_url":"https://api.github.com/repos/edgarmueller/jsonforms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edgarmueller/jsonforms/labels{/name}","releases_url":"https://api.github.com/repos/edgarmueller/jsonforms/releases{/id}","deployments_url":"https://api.github.com/repos/edgarmueller/jsonforms/deployments","created_at":"2015-02-27T16:30:18Z","updated_at":"2016-04-19T13:14:09Z","pushed_at":"2016-07-07T14:51:46Z","git_url":"git://github.com/edgarmueller/jsonforms.git","ssh_url":"git@github.com:edgarmueller/jsonforms.git","clone_url":"https://github.com/edgarmueller/jsonforms.git","svn_url":"https://github.com/edgarmueller/jsonforms","homepage":null,"size":25692,"stargazers_count":1,"watchers_count":1,"language":"CSS","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"eclipsesource:master","ref":"master","sha":"47bcf5604a3194fa45741ea227d3f4d04045bcb8","user":{"login":"eclipsesource","id":525860,"avatar_url":"https://avatars.githubusercontent.com/u/525860?v=3","gravatar_id":"","url":"https://api.github.com/users/eclipsesource","html_url":"https://github.com/eclipsesource","followers_url":"https://api.github.com/users/eclipsesource/followers","following_url":"https://api.github.com/users/eclipsesource/following{/other_user}","gists_url":"https://api.github.com/users/eclipsesource/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipsesource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipsesource/subscriptions","organizations_url":"https://api.github.com/users/eclipsesource/orgs","repos_url":"https://api.github.com/users/eclipsesource/repos","events_url":"https://api.github.com/users/eclipsesource/events{/privacy}","received_events_url":"https://api.github.com/users/eclipsesource/received_events","type":"Organization","site_admin":false},"repo":{"id":30751591,"name":"jsonforms","full_name":"eclipsesource/jsonforms","owner":{"login":"eclipsesource","id":525860,"avatar_url":"https://avatars.githubusercontent.com/u/525860?v=3","gravatar_id":"","url":"https://api.github.com/users/eclipsesource","html_url":"https://github.com/eclipsesource","followers_url":"https://api.github.com/users/eclipsesource/followers","following_url":"https://api.github.com/users/eclipsesource/following{/other_user}","gists_url":"https://api.github.com/users/eclipsesource/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipsesource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipsesource/subscriptions","organizations_url":"https://api.github.com/users/eclipsesource/orgs","repos_url":"https://api.github.com/users/eclipsesource/repos","events_url":"https://api.github.com/users/eclipsesource/events{/privacy}","received_events_url":"https://api.github.com/users/eclipsesource/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eclipsesource/jsonforms","description":"AngularJS-based forms for JSON data.","fork":false,"url":"https://api.github.com/repos/eclipsesource/jsonforms","forks_url":"https://api.github.com/repos/eclipsesource/jsonforms/forks","keys_url":"https://api.github.com/repos/eclipsesource/jsonforms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipsesource/jsonforms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipsesource/jsonforms/teams","hooks_url":"https://api.github.com/repos/eclipsesource/jsonforms/hooks","issue_events_url":"https://api.github.com/repos/eclipsesource/jsonforms/issues/events{/number}","events_url":"https://api.github.com/repos/eclipsesource/jsonforms/events","assignees_url":"https://api.github.com/repos/eclipsesource/jsonforms/assignees{/user}","branches_url":"https://api.github.com/repos/eclipsesource/jsonforms/branches{/branch}","tags_url":"https://api.github.com/repos/eclipsesource/jsonforms/tags","blobs_url":"https://api.github.com/repos/eclipsesource/jsonforms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipsesource/jsonforms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipsesource/jsonforms/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipsesource/jsonforms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipsesource/jsonforms/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipsesource/jsonforms/languages","stargazers_url":"https://api.github.com/repos/eclipsesource/jsonforms/stargazers","contributors_url":"https://api.github.com/repos/eclipsesource/jsonforms/contributors","subscribers_url":"https://api.github.com/repos/eclipsesource/jsonforms/subscribers","subscription_url":"https://api.github.com/repos/eclipsesource/jsonforms/subscription","commits_url":"https://api.github.com/repos/eclipsesource/jsonforms/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipsesource/jsonforms/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipsesource/jsonforms/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipsesource/jsonforms/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipsesource/jsonforms/contents/{+path}","compare_url":"https://api.github.com/repos/eclipsesource/jsonforms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipsesource/jsonforms/merges","archive_url":"https://api.github.com/repos/eclipsesource/jsonforms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipsesource/jsonforms/downloads","issues_url":"https://api.github.com/repos/eclipsesource/jsonforms/issues{/number}","pulls_url":"https://api.github.com/repos/eclipsesource/jsonforms/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipsesource/jsonforms/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipsesource/jsonforms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipsesource/jsonforms/labels{/name}","releases_url":"https://api.github.com/repos/eclipsesource/jsonforms/releases{/id}","deployments_url":"https://api.github.com/repos/eclipsesource/jsonforms/deployments","created_at":"2015-02-13T10:24:06Z","updated_at":"2016-06-27T10:19:16Z","pushed_at":"2016-07-07T14:57:42Z","git_url":"git://github.com/eclipsesource/jsonforms.git","ssh_url":"git@github.com:eclipsesource/jsonforms.git","clone_url":"https://github.com/eclipsesource/jsonforms.git","svn_url":"https://github.com/eclipsesource/jsonforms","homepage":null,"size":32046,"stargazers_count":26,"watchers_count":26,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":13,"mirror_url":null,"open_issues_count":31,"forks":13,"open_issues":31,"watchers":26,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipsesource/jsonforms/pulls/289"},"html":{"href":"https://github.com/eclipsesource/jsonforms/pull/289"},"issue":{"href":"https://api.github.com/repos/eclipsesource/jsonforms/issues/289"},"comments":{"href":"https://api.github.com/repos/eclipsesource/jsonforms/issues/289/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipsesource/jsonforms/pulls/289/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipsesource/jsonforms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipsesource/jsonforms/pulls/289/commits"},"statuses":{"href":"https://api.github.com/repos/eclipsesource/jsonforms/statuses/16ce4150a841d4c4dfe69990e6dce52eb362a49a"}}}}
{"actor":{"display_login":"eneufeld"}}