{"action":"created","issue":{"url":"https://api.github.com/repos/Unvanquished/Unvanquished/issues/954","repository_url":"https://api.github.com/repos/Unvanquished/Unvanquished","labels_url":"https://api.github.com/repos/Unvanquished/Unvanquished/issues/954/labels{/name}","comments_url":"https://api.github.com/repos/Unvanquished/Unvanquished/issues/954/comments","events_url":"https://api.github.com/repos/Unvanquished/Unvanquished/issues/954/events","html_url":"https://github.com/Unvanquished/Unvanquished/pull/954","id":167236150,"number":954,"title":"Placed daemon-engine in submodule","user":{"login":"Elzair","id":2352818,"avatar_url":"https://avatars.githubusercontent.com/u/2352818?v=3","gravatar_id":"","url":"https://api.github.com/users/Elzair","html_url":"https://github.com/Elzair","followers_url":"https://api.github.com/users/Elzair/followers","following_url":"https://api.github.com/users/Elzair/following{/other_user}","gists_url":"https://api.github.com/users/Elzair/gists{/gist_id}","starred_url":"https://api.github.com/users/Elzair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Elzair/subscriptions","organizations_url":"https://api.github.com/users/Elzair/orgs","repos_url":"https://api.github.com/users/Elzair/repos","events_url":"https://api.github.com/users/Elzair/events{/privacy}","received_events_url":"https://api.github.com/users/Elzair/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":11,"created_at":"2016-07-24T14:31:46Z","updated_at":"2016-07-29T06:56:35Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Unvanquished/Unvanquished/pulls/954","html_url":"https://github.com/Unvanquished/Unvanquished/pull/954","diff_url":"https://github.com/Unvanquished/Unvanquished/pull/954.diff","patch_url":"https://github.com/Unvanquished/Unvanquished/pull/954.patch"},"body":"Since the daemon engine is now being used for multiple projects (such as Xonotic), I think it would be best to place it in its own repository. I used `git filter-branch` to create a repository containing only the commits pertinent to the _daemon_ subdirectory, removed the _daemon_ subdirectory, and added the [new repository](https://github.com/Elzair/daemon-engine) as a submodule under the subdirectory _daemon_. (**NOTE:** Since the _.gitignore_ ignores any files named \"daemon\", I changed the name to \"daemon-engine\"). I also removed the submodules _daemon/libs/breakpad_ and _daemon/libs/recastnavigation_ from the repository and added them to the engine repository.\r\n\r\nI tested the new system on Arch Linux x86_64. It built okay except for the following part.\r\n\r\n`[ 99%] Linking CXX executable cgame-native-exe\r\nCMakeFiles/cgame-native-exe.dir/src/cgame/rocket/rocket.cpp.o: In function `Rocket::Core::Lua::LuaType<Rocket::Core::Lua::Cvar>::thunk(lua_State*)':\r\nrocket.cpp:(.text._ZN6Rocket4Core3Lua7LuaTypeINS1_4CvarEE5thunkEP9lua_State[_ZN6Rocket4Core3Lua7LuaTypeINS1_4CvarEE5thunkEP9lua_State]+0x29): undefined reference to `lua_rotate'\r\nrocket.cpp:(.text._ZN6Rocket4Core3Lua7LuaTypeINS1_4CvarEE5thunkEP9lua_State[_ZN6Rocket4Core3Lua7LuaTypeINS1_4CvarEE5thunkEP9lua_State]+0x6e): undefined reference to `lua_rotate'\r\nCMakeFiles/cgame-native-exe.dir/src/cgame/rocket/rocket.cpp.o: In function `Rocket::Core::Lua::LuaType<Rocket::Core::Lua::Cmd>::thunk(lua_State*)':\r\nrocket.cpp:(.text._ZN6Rocket4Core3Lua7LuaTypeINS1_3CmdEE5thunkEP9lua_State[_ZN6Rocket4Core3Lua7LuaTypeINS1_3CmdEE5thunkEP9lua_State]+0x29): undefined reference to `lua_rotate'\r\nrocket.cpp:(.text._ZN6Rocket4Core3Lua7LuaTypeINS1_3CmdEE5thunkEP9lua_State[_ZN6Rocket4Core3Lua7LuaTypeINS1_3CmdEE5thunkEP9lua_State]+0x6e): undefined reference to `lua_rotate'\r\nCMakeFiles/cgame-native-exe.dir/src/cgame/rocket/rocket.cpp.o: In function `Rocket::Core::Lua::LuaType<Rocket::Core::Lua::Events>::thunk(lua_State*)':\r\nrocket.cpp:(.text._ZN6Rocket4Core3Lua7LuaTypeINS1_6EventsEE5thunkEP9lua_State[_ZN6Rocket4Core3Lua7LuaTypeINS1_6EventsEE5thunkEP9lua_State]+0x29): undefined reference to `lua_rotate'\r\nCMakeFiles/cgame-native-exe.dir/src/cgame/rocket/rocket.cpp.o:rocket.cpp:(.text._ZN6Rocket4Core3Lua7LuaTypeINS1_6EventsEE5thunkEP9lua_State[_ZN6Rocket4Core3Lua7LuaTypeINS1_6EventsEE5thunkEP9lua_State]+0x6e): more undefined references to `lua_rotate' follow\r\ncollect2: error: ld returned 1 exit status\r\nmake[2]: *** [CMakeFiles/cgame-native-exe.dir/build.make:2105: cgame-native-exe] Error 1\r\nmake[1]: *** [CMakeFiles/Makefile2:317: CMakeFiles/cgame-native-exe.dir/all] Error 2\r\n[ 99%] Built target cgame-nacl\r\n`\r\n\r\nI ran the game, and it seemed to work just fine.\r\n\r\n**P.S.** Instead of forking my daemon-engine repository, feel free to upload your own (changing git submodules, of course), and I will fork off of it for future development.\r\n\r\n**UPDATE:** Since _daemon/cmake/DaemonCBSE.cmake_ would automatically setup git submodules, I added code in the toplevel _CMakeLists.txt_ that will do likewise."},"comment":{"url":"https://api.github.com/repos/Unvanquished/Unvanquished/issues/comments/236108660","html_url":"https://github.com/Unvanquished/Unvanquished/pull/954#issuecomment-236108660","issue_url":"https://api.github.com/repos/Unvanquished/Unvanquished/issues/954","id":236108660,"user":{"login":"Viech","id":3780206,"avatar_url":"https://avatars.githubusercontent.com/u/3780206?v=3","gravatar_id":"","url":"https://api.github.com/users/Viech","html_url":"https://github.com/Viech","followers_url":"https://api.github.com/users/Viech/followers","following_url":"https://api.github.com/users/Viech/following{/other_user}","gists_url":"https://api.github.com/users/Viech/gists{/gist_id}","starred_url":"https://api.github.com/users/Viech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Viech/subscriptions","organizations_url":"https://api.github.com/users/Viech/orgs","repos_url":"https://api.github.com/users/Viech/repos","events_url":"https://api.github.com/users/Viech/events{/privacy}","received_events_url":"https://api.github.com/users/Viech/received_events","type":"User","site_admin":false},"created_at":"2016-07-29T06:56:35Z","updated_at":"2016-07-29T06:56:35Z","body":"@Kangz and @Amanieu any input on this?"}}
{"actor":{"display_login":"Viech"}}