{"action":"created","issue":{"url":"https://api.github.com/repos/pull-stream/pull-stream/issues/76","repository_url":"https://api.github.com/repos/pull-stream/pull-stream","labels_url":"https://api.github.com/repos/pull-stream/pull-stream/issues/76/labels{/name}","comments_url":"https://api.github.com/repos/pull-stream/pull-stream/issues/76/comments","events_url":"https://api.github.com/repos/pull-stream/pull-stream/issues/76/events","html_url":"https://github.com/pull-stream/pull-stream/issues/76","id":183266094,"number":76,"title":"Should a source stream expect to be called without a callback?","user":{"login":"tjconcept","id":801895,"avatar_url":"https://avatars.githubusercontent.com/u/801895?v=3","gravatar_id":"","url":"https://api.github.com/users/tjconcept","html_url":"https://github.com/tjconcept","followers_url":"https://api.github.com/users/tjconcept/followers","following_url":"https://api.github.com/users/tjconcept/following{/other_user}","gists_url":"https://api.github.com/users/tjconcept/gists{/gist_id}","starred_url":"https://api.github.com/users/tjconcept/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tjconcept/subscriptions","organizations_url":"https://api.github.com/users/tjconcept/orgs","repos_url":"https://api.github.com/users/tjconcept/repos","events_url":"https://api.github.com/users/tjconcept/events{/privacy}","received_events_url":"https://api.github.com/users/tjconcept/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-10-16T13:06:08Z","updated_at":"2016-10-17T20:33:34Z","closed_at":null,"body":"I was just wondering... Comparing this code:\r\n\r\nhttps://github.com/pull-stream/pull-stream/blob/master/sources/values.js#L7\r\nhttps://github.com/pull-stream/pull-stream/blob/master/sources/infinite.js#L5\r\nhttps://github.com/pull-stream/pull-stream/blob/master/util/abort-cb.js\r\n\r\n\"values\" and \"infinite\" both produce source streams, right? Why does only one of them check for the existence of `cb` (the \"abort-cb\" utility does not)?\r\n\r\nMy intuitive guess is that you need to check for existence, because you would like to allow someone doing `cb(true)` to abort mission."},"comment":{"url":"https://api.github.com/repos/pull-stream/pull-stream/issues/comments/254325217","html_url":"https://github.com/pull-stream/pull-stream/issues/76#issuecomment-254325217","issue_url":"https://api.github.com/repos/pull-stream/pull-stream/issues/76","id":254325217,"user":{"login":"tjconcept","id":801895,"avatar_url":"https://avatars.githubusercontent.com/u/801895?v=3","gravatar_id":"","url":"https://api.github.com/users/tjconcept","html_url":"https://github.com/tjconcept","followers_url":"https://api.github.com/users/tjconcept/followers","following_url":"https://api.github.com/users/tjconcept/following{/other_user}","gists_url":"https://api.github.com/users/tjconcept/gists{/gist_id}","starred_url":"https://api.github.com/users/tjconcept/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tjconcept/subscriptions","organizations_url":"https://api.github.com/users/tjconcept/orgs","repos_url":"https://api.github.com/users/tjconcept/repos","events_url":"https://api.github.com/users/tjconcept/events{/privacy}","received_events_url":"https://api.github.com/users/tjconcept/received_events","type":"User","site_admin":false},"created_at":"2016-10-17T20:33:34Z","updated_at":"2016-10-17T20:33:34Z","body":"Thanks, makes sense. Is it an inconsistency in this library then? I think I'd prefer to have the check to avoid coming up with noops when aborting from a sink."}}
{"actor":{"display_login":"tjconcept"}}