{"action":"created","comment":{"url":"https://api.github.com/repos/lxc/lxd/pulls/comments/61167441","id":61167441,"diff_hunk":"@@ -184,16 +184,21 @@ func deviceTaskBalance(d *Daemon) {\n \t// Get effective cpus list - those are all guaranteed to be online\n \teffectiveCpus, err := cGroupGet(\"cpuset\", \"/\", \"cpuset.effective_cpus\")\n \tif err != nil {\n-\t\tshared.Log.Error(\"Error reading host's cpuset.effective_cpus\")\n-\t\treturn\n+\t\t// Older kernel - use cpuset.cpus\n+\t\tshared.Log.Warn(\"Failed reading host's cpuset.effective_cpus, falling back to cpuset.cpus\")","path":"lxd/devices.go","position":7,"original_position":7,"commit_id":"9e852bc662a8c612d9fdb28c72d0e4ce4b1bbb11","original_commit_id":"9e852bc662a8c612d9fdb28c72d0e4ce4b1bbb11","user":{"login":"stgraber","id":2230599,"avatar_url":"https://avatars.githubusercontent.com/u/2230599?v=3","gravatar_id":"","url":"https://api.github.com/users/stgraber","html_url":"https://github.com/stgraber","followers_url":"https://api.github.com/users/stgraber/followers","following_url":"https://api.github.com/users/stgraber/following{/other_user}","gists_url":"https://api.github.com/users/stgraber/gists{/gist_id}","starred_url":"https://api.github.com/users/stgraber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stgraber/subscriptions","organizations_url":"https://api.github.com/users/stgraber/orgs","repos_url":"https://api.github.com/users/stgraber/repos","events_url":"https://api.github.com/users/stgraber/events{/privacy}","received_events_url":"https://api.github.com/users/stgraber/received_events","type":"User","site_admin":false},"body":"We do have similar detection code in the daemon init function which then sets global variables.\r\nNot sure whether it's warranted in this case though, there is no loss of functionality by having us do the fallback.","created_at":"2016-04-26T21:25:53Z","updated_at":"2016-04-26T21:25:53Z","html_url":"https://github.com/lxc/lxd/pull/1949#discussion_r61167441","pull_request_url":"https://api.github.com/repos/lxc/lxd/pulls/1949","_links":{"self":{"href":"https://api.github.com/repos/lxc/lxd/pulls/comments/61167441"},"html":{"href":"https://github.com/lxc/lxd/pull/1949#discussion_r61167441"},"pull_request":{"href":"https://api.github.com/repos/lxc/lxd/pulls/1949"}}},"pull_request":{"url":"https://api.github.com/repos/lxc/lxd/pulls/1949","id":67957965,"html_url":"https://github.com/lxc/lxd/pull/1949","diff_url":"https://github.com/lxc/lxd/pull/1949.diff","patch_url":"https://github.com/lxc/lxd/pull/1949.patch","issue_url":"https://api.github.com/repos/lxc/lxd/issues/1949","number":1949,"state":"open","locked":false,"title":"cpuset: fall back to cpuset.cpus on older kernels","user":{"login":"hallyn","id":1359441,"avatar_url":"https://avatars.githubusercontent.com/u/1359441?v=3","gravatar_id":"","url":"https://api.github.com/users/hallyn","html_url":"https://github.com/hallyn","followers_url":"https://api.github.com/users/hallyn/followers","following_url":"https://api.github.com/users/hallyn/following{/other_user}","gists_url":"https://api.github.com/users/hallyn/gists{/gist_id}","starred_url":"https://api.github.com/users/hallyn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hallyn/subscriptions","organizations_url":"https://api.github.com/users/hallyn/orgs","repos_url":"https://api.github.com/users/hallyn/repos","events_url":"https://api.github.com/users/hallyn/events{/privacy}","received_events_url":"https://api.github.com/users/hallyn/received_events","type":"User","site_admin":false},"body":"cpuset.effective_cpus is better because it does not include cpus which\r\nwe cannot use.  But it is not available on older kernels.  In that\r\ncase fall back to using cpuset.cpus and hoping for the best.\r\n\r\nCloses #1929\r\n\r\nSigned-off-by: Serge Hallyn <serge.hallyn@ubuntu.com>","created_at":"2016-04-26T21:04:24Z","updated_at":"2016-04-26T21:25:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f43556fb29032ed80bc553abcc5098258960ecee","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/lxc/lxd/pulls/1949/commits","review_comments_url":"https://api.github.com/repos/lxc/lxd/pulls/1949/comments","review_comment_url":"https://api.github.com/repos/lxc/lxd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lxc/lxd/issues/1949/comments","statuses_url":"https://api.github.com/repos/lxc/lxd/statuses/9e852bc662a8c612d9fdb28c72d0e4ce4b1bbb11","head":{"label":"hallyn:2016-04-26/cpuset","ref":"2016-04-26/cpuset","sha":"9e852bc662a8c612d9fdb28c72d0e4ce4b1bbb11","user":{"login":"hallyn","id":1359441,"avatar_url":"https://avatars.githubusercontent.com/u/1359441?v=3","gravatar_id":"","url":"https://api.github.com/users/hallyn","html_url":"https://github.com/hallyn","followers_url":"https://api.github.com/users/hallyn/followers","following_url":"https://api.github.com/users/hallyn/following{/other_user}","gists_url":"https://api.github.com/users/hallyn/gists{/gist_id}","starred_url":"https://api.github.com/users/hallyn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hallyn/subscriptions","organizations_url":"https://api.github.com/users/hallyn/orgs","repos_url":"https://api.github.com/users/hallyn/repos","events_url":"https://api.github.com/users/hallyn/events{/privacy}","received_events_url":"https://api.github.com/users/hallyn/received_events","type":"User","site_admin":false},"repo":{"id":26297086,"name":"lxd","full_name":"hallyn/lxd","owner":{"login":"hallyn","id":1359441,"avatar_url":"https://avatars.githubusercontent.com/u/1359441?v=3","gravatar_id":"","url":"https://api.github.com/users/hallyn","html_url":"https://github.com/hallyn","followers_url":"https://api.github.com/users/hallyn/followers","following_url":"https://api.github.com/users/hallyn/following{/other_user}","gists_url":"https://api.github.com/users/hallyn/gists{/gist_id}","starred_url":"https://api.github.com/users/hallyn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hallyn/subscriptions","organizations_url":"https://api.github.com/users/hallyn/orgs","repos_url":"https://api.github.com/users/hallyn/repos","events_url":"https://api.github.com/users/hallyn/events{/privacy}","received_events_url":"https://api.github.com/users/hallyn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hallyn/lxd","description":"lxd (pronounced lex-dee) is a REST API, command line tool and OpenStack plugin based on liblxc","fork":true,"url":"https://api.github.com/repos/hallyn/lxd","forks_url":"https://api.github.com/repos/hallyn/lxd/forks","keys_url":"https://api.github.com/repos/hallyn/lxd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hallyn/lxd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hallyn/lxd/teams","hooks_url":"https://api.github.com/repos/hallyn/lxd/hooks","issue_events_url":"https://api.github.com/repos/hallyn/lxd/issues/events{/number}","events_url":"https://api.github.com/repos/hallyn/lxd/events","assignees_url":"https://api.github.com/repos/hallyn/lxd/assignees{/user}","branches_url":"https://api.github.com/repos/hallyn/lxd/branches{/branch}","tags_url":"https://api.github.com/repos/hallyn/lxd/tags","blobs_url":"https://api.github.com/repos/hallyn/lxd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hallyn/lxd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hallyn/lxd/git/refs{/sha}","trees_url":"https://api.github.com/repos/hallyn/lxd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hallyn/lxd/statuses/{sha}","languages_url":"https://api.github.com/repos/hallyn/lxd/languages","stargazers_url":"https://api.github.com/repos/hallyn/lxd/stargazers","contributors_url":"https://api.github.com/repos/hallyn/lxd/contributors","subscribers_url":"https://api.github.com/repos/hallyn/lxd/subscribers","subscription_url":"https://api.github.com/repos/hallyn/lxd/subscription","commits_url":"https://api.github.com/repos/hallyn/lxd/commits{/sha}","git_commits_url":"https://api.github.com/repos/hallyn/lxd/git/commits{/sha}","comments_url":"https://api.github.com/repos/hallyn/lxd/comments{/number}","issue_comment_url":"https://api.github.com/repos/hallyn/lxd/issues/comments{/number}","contents_url":"https://api.github.com/repos/hallyn/lxd/contents/{+path}","compare_url":"https://api.github.com/repos/hallyn/lxd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hallyn/lxd/merges","archive_url":"https://api.github.com/repos/hallyn/lxd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hallyn/lxd/downloads","issues_url":"https://api.github.com/repos/hallyn/lxd/issues{/number}","pulls_url":"https://api.github.com/repos/hallyn/lxd/pulls{/number}","milestones_url":"https://api.github.com/repos/hallyn/lxd/milestones{/number}","notifications_url":"https://api.github.com/repos/hallyn/lxd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hallyn/lxd/labels{/name}","releases_url":"https://api.github.com/repos/hallyn/lxd/releases{/id}","deployments_url":"https://api.github.com/repos/hallyn/lxd/deployments","created_at":"2014-11-07T00:48:12Z","updated_at":"2015-07-02T21:56:05Z","pushed_at":"2016-04-26T21:02:30Z","git_url":"git://github.com/hallyn/lxd.git","ssh_url":"git@github.com:hallyn/lxd.git","clone_url":"https://github.com/hallyn/lxd.git","svn_url":"https://github.com/hallyn/lxd","homepage":"https://linuxcontainers.org","size":5854,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"lxc:master","ref":"master","sha":"b706f838124236f66847fd5a917372adf0615326","user":{"login":"lxc","id":2301756,"avatar_url":"https://avatars.githubusercontent.com/u/2301756?v=3","gravatar_id":"","url":"https://api.github.com/users/lxc","html_url":"https://github.com/lxc","followers_url":"https://api.github.com/users/lxc/followers","following_url":"https://api.github.com/users/lxc/following{/other_user}","gists_url":"https://api.github.com/users/lxc/gists{/gist_id}","starred_url":"https://api.github.com/users/lxc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lxc/subscriptions","organizations_url":"https://api.github.com/users/lxc/orgs","repos_url":"https://api.github.com/users/lxc/repos","events_url":"https://api.github.com/users/lxc/events{/privacy}","received_events_url":"https://api.github.com/users/lxc/received_events","type":"Organization","site_admin":false},"repo":{"id":26192117,"name":"lxd","full_name":"lxc/lxd","owner":{"login":"lxc","id":2301756,"avatar_url":"https://avatars.githubusercontent.com/u/2301756?v=3","gravatar_id":"","url":"https://api.github.com/users/lxc","html_url":"https://github.com/lxc","followers_url":"https://api.github.com/users/lxc/followers","following_url":"https://api.github.com/users/lxc/following{/other_user}","gists_url":"https://api.github.com/users/lxc/gists{/gist_id}","starred_url":"https://api.github.com/users/lxc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lxc/subscriptions","organizations_url":"https://api.github.com/users/lxc/orgs","repos_url":"https://api.github.com/users/lxc/repos","events_url":"https://api.github.com/users/lxc/events{/privacy}","received_events_url":"https://api.github.com/users/lxc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lxc/lxd","description":"Daemon based on liblxc offering a REST API to manage containers","fork":false,"url":"https://api.github.com/repos/lxc/lxd","forks_url":"https://api.github.com/repos/lxc/lxd/forks","keys_url":"https://api.github.com/repos/lxc/lxd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lxc/lxd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lxc/lxd/teams","hooks_url":"https://api.github.com/repos/lxc/lxd/hooks","issue_events_url":"https://api.github.com/repos/lxc/lxd/issues/events{/number}","events_url":"https://api.github.com/repos/lxc/lxd/events","assignees_url":"https://api.github.com/repos/lxc/lxd/assignees{/user}","branches_url":"https://api.github.com/repos/lxc/lxd/branches{/branch}","tags_url":"https://api.github.com/repos/lxc/lxd/tags","blobs_url":"https://api.github.com/repos/lxc/lxd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lxc/lxd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lxc/lxd/git/refs{/sha}","trees_url":"https://api.github.com/repos/lxc/lxd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lxc/lxd/statuses/{sha}","languages_url":"https://api.github.com/repos/lxc/lxd/languages","stargazers_url":"https://api.github.com/repos/lxc/lxd/stargazers","contributors_url":"https://api.github.com/repos/lxc/lxd/contributors","subscribers_url":"https://api.github.com/repos/lxc/lxd/subscribers","subscription_url":"https://api.github.com/repos/lxc/lxd/subscription","commits_url":"https://api.github.com/repos/lxc/lxd/commits{/sha}","git_commits_url":"https://api.github.com/repos/lxc/lxd/git/commits{/sha}","comments_url":"https://api.github.com/repos/lxc/lxd/comments{/number}","issue_comment_url":"https://api.github.com/repos/lxc/lxd/issues/comments{/number}","contents_url":"https://api.github.com/repos/lxc/lxd/contents/{+path}","compare_url":"https://api.github.com/repos/lxc/lxd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lxc/lxd/merges","archive_url":"https://api.github.com/repos/lxc/lxd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lxc/lxd/downloads","issues_url":"https://api.github.com/repos/lxc/lxd/issues{/number}","pulls_url":"https://api.github.com/repos/lxc/lxd/pulls{/number}","milestones_url":"https://api.github.com/repos/lxc/lxd/milestones{/number}","notifications_url":"https://api.github.com/repos/lxc/lxd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lxc/lxd/labels{/name}","releases_url":"https://api.github.com/repos/lxc/lxd/releases{/id}","deployments_url":"https://api.github.com/repos/lxc/lxd/deployments","created_at":"2014-11-04T22:40:52Z","updated_at":"2016-04-26T19:10:03Z","pushed_at":"2016-04-26T21:24:38Z","git_url":"git://github.com/lxc/lxd.git","ssh_url":"git@github.com:lxc/lxd.git","clone_url":"https://github.com/lxc/lxd.git","svn_url":"https://github.com/lxc/lxd","homepage":"https://linuxcontainers.org/lxd","size":7343,"stargazers_count":934,"watchers_count":934,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":168,"mirror_url":null,"open_issues_count":63,"forks":168,"open_issues":63,"watchers":934,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lxc/lxd/pulls/1949"},"html":{"href":"https://github.com/lxc/lxd/pull/1949"},"issue":{"href":"https://api.github.com/repos/lxc/lxd/issues/1949"},"comments":{"href":"https://api.github.com/repos/lxc/lxd/issues/1949/comments"},"review_comments":{"href":"https://api.github.com/repos/lxc/lxd/pulls/1949/comments"},"review_comment":{"href":"https://api.github.com/repos/lxc/lxd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lxc/lxd/pulls/1949/commits"},"statuses":{"href":"https://api.github.com/repos/lxc/lxd/statuses/9e852bc662a8c612d9fdb28c72d0e4ce4b1bbb11"}}}}