{"action":"created","comment":{"url":"https://api.github.com/repos/kennethreitz/requests/pulls/comments/84634748","pull_request_review_id":5399051,"id":84634748,"diff_hunk":"@@ -1466,6 +1466,18 @@ def test_environment_comes_after_session(self, httpbin):\n         with pytest.raises(KeyError):\n             proxies['http']\n \n+    def test_merge_environment_settings_verify(self):\n+        \"\"\"Assert CA environment settings are merged as expected when missing\"\"\"\n+        session = requests.Session()\n+        assert session.trust_env is True\n+        assert session.verify is True\n+        assert 'REQUESTS_CA_BUNDLE' not in os.environ\n+        assert 'CURL_CA_BUNDLE' not in os.environ","path":"tests/test_requests.py","position":10,"original_position":10,"commit_id":"f75e608a53ecd7fc1e5631aea03102e56dd9f2d0","original_commit_id":"f75e608a53ecd7fc1e5631aea03102e56dd9f2d0","user":{"login":"Lukasa","id":1382556,"avatar_url":"https://avatars.githubusercontent.com/u/1382556?v=3","gravatar_id":"","url":"https://api.github.com/users/Lukasa","html_url":"https://github.com/Lukasa","followers_url":"https://api.github.com/users/Lukasa/followers","following_url":"https://api.github.com/users/Lukasa/following{/other_user}","gists_url":"https://api.github.com/users/Lukasa/gists{/gist_id}","starred_url":"https://api.github.com/users/Lukasa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lukasa/subscriptions","organizations_url":"https://api.github.com/users/Lukasa/orgs","repos_url":"https://api.github.com/users/Lukasa/repos","events_url":"https://api.github.com/users/Lukasa/events{/privacy}","received_events_url":"https://api.github.com/users/Lukasa/received_events","type":"User","site_admin":false},"body":"This test needs to be adjusted slightly to patch the environment to make these things true. Otherwise this test will fail on machines where the user has set these environment variables on purpose.","created_at":"2016-10-24T07:49:27Z","updated_at":"2016-10-24T07:49:27Z","html_url":"https://github.com/kennethreitz/requests/pull/3634#discussion_r84634748","pull_request_url":"https://api.github.com/repos/kennethreitz/requests/pulls/3634","_links":{"self":{"href":"https://api.github.com/repos/kennethreitz/requests/pulls/comments/84634748"},"html":{"href":"https://github.com/kennethreitz/requests/pull/3634#discussion_r84634748"},"pull_request":{"href":"https://api.github.com/repos/kennethreitz/requests/pulls/3634"}}},"pull_request":{"url":"https://api.github.com/repos/kennethreitz/requests/pulls/3634","id":90520007,"html_url":"https://github.com/kennethreitz/requests/pull/3634","diff_url":"https://github.com/kennethreitz/requests/pull/3634.diff","patch_url":"https://github.com/kennethreitz/requests/pull/3634.patch","issue_url":"https://api.github.com/repos/kennethreitz/requests/issues/3634","number":3634,"state":"open","locked":false,"title":"Keep ``verify`` setting when no CA_BUNDLE variable exists","user":{"login":"jeremycline","id":1977525,"avatar_url":"https://avatars.githubusercontent.com/u/1977525?v=3","gravatar_id":"","url":"https://api.github.com/users/jeremycline","html_url":"https://github.com/jeremycline","followers_url":"https://api.github.com/users/jeremycline/followers","following_url":"https://api.github.com/users/jeremycline/following{/other_user}","gists_url":"https://api.github.com/users/jeremycline/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremycline/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremycline/subscriptions","organizations_url":"https://api.github.com/users/jeremycline/orgs","repos_url":"https://api.github.com/users/jeremycline/repos","events_url":"https://api.github.com/users/jeremycline/events{/privacy}","received_events_url":"https://api.github.com/users/jeremycline/received_events","type":"User","site_admin":false},"body":"If the ``trust_env`` flag is set on a session and ``verify`` is ``True``\r\nor ``None``, the environment is checked for ``CURL_CA_BUNDLE`` and\r\n``REQUESTS_CA_BUNDLE``. Before this patch, if neither existed,\r\n``verify`` would always be set to ``None`` rather than ``True`` when it\r\nwas originally ``True``.\r\n\r\nI found this while working on a patch for https://github.com/kennethreitz/requests/issues/3633.","created_at":"2016-10-23T16:07:44Z","updated_at":"2016-10-24T07:49:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"897bf6628c4c608d3a6fdba5cd65ad86bd61491e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/kennethreitz/requests/pulls/3634/commits","review_comments_url":"https://api.github.com/repos/kennethreitz/requests/pulls/3634/comments","review_comment_url":"https://api.github.com/repos/kennethreitz/requests/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kennethreitz/requests/issues/3634/comments","statuses_url":"https://api.github.com/repos/kennethreitz/requests/statuses/f75e608a53ecd7fc1e5631aea03102e56dd9f2d0","head":{"label":"jeremycline:verify-by-default","ref":"verify-by-default","sha":"f75e608a53ecd7fc1e5631aea03102e56dd9f2d0","user":{"login":"jeremycline","id":1977525,"avatar_url":"https://avatars.githubusercontent.com/u/1977525?v=3","gravatar_id":"","url":"https://api.github.com/users/jeremycline","html_url":"https://github.com/jeremycline","followers_url":"https://api.github.com/users/jeremycline/followers","following_url":"https://api.github.com/users/jeremycline/following{/other_user}","gists_url":"https://api.github.com/users/jeremycline/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremycline/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremycline/subscriptions","organizations_url":"https://api.github.com/users/jeremycline/orgs","repos_url":"https://api.github.com/users/jeremycline/repos","events_url":"https://api.github.com/users/jeremycline/events{/privacy}","received_events_url":"https://api.github.com/users/jeremycline/received_events","type":"User","site_admin":false},"repo":{"id":54759241,"name":"requests","full_name":"jeremycline/requests","owner":{"login":"jeremycline","id":1977525,"avatar_url":"https://avatars.githubusercontent.com/u/1977525?v=3","gravatar_id":"","url":"https://api.github.com/users/jeremycline","html_url":"https://github.com/jeremycline","followers_url":"https://api.github.com/users/jeremycline/followers","following_url":"https://api.github.com/users/jeremycline/following{/other_user}","gists_url":"https://api.github.com/users/jeremycline/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremycline/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremycline/subscriptions","organizations_url":"https://api.github.com/users/jeremycline/orgs","repos_url":"https://api.github.com/users/jeremycline/repos","events_url":"https://api.github.com/users/jeremycline/events{/privacy}","received_events_url":"https://api.github.com/users/jeremycline/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jeremycline/requests","description":"Python HTTP Requests for Humans™","fork":true,"url":"https://api.github.com/repos/jeremycline/requests","forks_url":"https://api.github.com/repos/jeremycline/requests/forks","keys_url":"https://api.github.com/repos/jeremycline/requests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jeremycline/requests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jeremycline/requests/teams","hooks_url":"https://api.github.com/repos/jeremycline/requests/hooks","issue_events_url":"https://api.github.com/repos/jeremycline/requests/issues/events{/number}","events_url":"https://api.github.com/repos/jeremycline/requests/events","assignees_url":"https://api.github.com/repos/jeremycline/requests/assignees{/user}","branches_url":"https://api.github.com/repos/jeremycline/requests/branches{/branch}","tags_url":"https://api.github.com/repos/jeremycline/requests/tags","blobs_url":"https://api.github.com/repos/jeremycline/requests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jeremycline/requests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jeremycline/requests/git/refs{/sha}","trees_url":"https://api.github.com/repos/jeremycline/requests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jeremycline/requests/statuses/{sha}","languages_url":"https://api.github.com/repos/jeremycline/requests/languages","stargazers_url":"https://api.github.com/repos/jeremycline/requests/stargazers","contributors_url":"https://api.github.com/repos/jeremycline/requests/contributors","subscribers_url":"https://api.github.com/repos/jeremycline/requests/subscribers","subscription_url":"https://api.github.com/repos/jeremycline/requests/subscription","commits_url":"https://api.github.com/repos/jeremycline/requests/commits{/sha}","git_commits_url":"https://api.github.com/repos/jeremycline/requests/git/commits{/sha}","comments_url":"https://api.github.com/repos/jeremycline/requests/comments{/number}","issue_comment_url":"https://api.github.com/repos/jeremycline/requests/issues/comments{/number}","contents_url":"https://api.github.com/repos/jeremycline/requests/contents/{+path}","compare_url":"https://api.github.com/repos/jeremycline/requests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jeremycline/requests/merges","archive_url":"https://api.github.com/repos/jeremycline/requests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jeremycline/requests/downloads","issues_url":"https://api.github.com/repos/jeremycline/requests/issues{/number}","pulls_url":"https://api.github.com/repos/jeremycline/requests/pulls{/number}","milestones_url":"https://api.github.com/repos/jeremycline/requests/milestones{/number}","notifications_url":"https://api.github.com/repos/jeremycline/requests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jeremycline/requests/labels{/name}","releases_url":"https://api.github.com/repos/jeremycline/requests/releases{/id}","deployments_url":"https://api.github.com/repos/jeremycline/requests/deployments","created_at":"2016-03-26T02:45:59Z","updated_at":"2016-03-26T02:46:03Z","pushed_at":"2016-10-23T16:05:34Z","git_url":"git://github.com/jeremycline/requests.git","ssh_url":"git@github.com:jeremycline/requests.git","clone_url":"https://github.com/jeremycline/requests.git","svn_url":"https://github.com/jeremycline/requests","homepage":"python-requests.org","size":4981,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kennethreitz:proposed/3.0.0","ref":"proposed/3.0.0","sha":"5a41febce249e7b74eb37ba7914998ff08321c38","user":{"login":"kennethreitz","id":119893,"avatar_url":"https://avatars.githubusercontent.com/u/119893?v=3","gravatar_id":"","url":"https://api.github.com/users/kennethreitz","html_url":"https://github.com/kennethreitz","followers_url":"https://api.github.com/users/kennethreitz/followers","following_url":"https://api.github.com/users/kennethreitz/following{/other_user}","gists_url":"https://api.github.com/users/kennethreitz/gists{/gist_id}","starred_url":"https://api.github.com/users/kennethreitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kennethreitz/subscriptions","organizations_url":"https://api.github.com/users/kennethreitz/orgs","repos_url":"https://api.github.com/users/kennethreitz/repos","events_url":"https://api.github.com/users/kennethreitz/events{/privacy}","received_events_url":"https://api.github.com/users/kennethreitz/received_events","type":"User","site_admin":false},"repo":{"id":1362490,"name":"requests","full_name":"kennethreitz/requests","owner":{"login":"kennethreitz","id":119893,"avatar_url":"https://avatars.githubusercontent.com/u/119893?v=3","gravatar_id":"","url":"https://api.github.com/users/kennethreitz","html_url":"https://github.com/kennethreitz","followers_url":"https://api.github.com/users/kennethreitz/followers","following_url":"https://api.github.com/users/kennethreitz/following{/other_user}","gists_url":"https://api.github.com/users/kennethreitz/gists{/gist_id}","starred_url":"https://api.github.com/users/kennethreitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kennethreitz/subscriptions","organizations_url":"https://api.github.com/users/kennethreitz/orgs","repos_url":"https://api.github.com/users/kennethreitz/repos","events_url":"https://api.github.com/users/kennethreitz/events{/privacy}","received_events_url":"https://api.github.com/users/kennethreitz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kennethreitz/requests","description":"Python HTTP Requests for Humans™","fork":false,"url":"https://api.github.com/repos/kennethreitz/requests","forks_url":"https://api.github.com/repos/kennethreitz/requests/forks","keys_url":"https://api.github.com/repos/kennethreitz/requests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kennethreitz/requests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kennethreitz/requests/teams","hooks_url":"https://api.github.com/repos/kennethreitz/requests/hooks","issue_events_url":"https://api.github.com/repos/kennethreitz/requests/issues/events{/number}","events_url":"https://api.github.com/repos/kennethreitz/requests/events","assignees_url":"https://api.github.com/repos/kennethreitz/requests/assignees{/user}","branches_url":"https://api.github.com/repos/kennethreitz/requests/branches{/branch}","tags_url":"https://api.github.com/repos/kennethreitz/requests/tags","blobs_url":"https://api.github.com/repos/kennethreitz/requests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kennethreitz/requests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kennethreitz/requests/git/refs{/sha}","trees_url":"https://api.github.com/repos/kennethreitz/requests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kennethreitz/requests/statuses/{sha}","languages_url":"https://api.github.com/repos/kennethreitz/requests/languages","stargazers_url":"https://api.github.com/repos/kennethreitz/requests/stargazers","contributors_url":"https://api.github.com/repos/kennethreitz/requests/contributors","subscribers_url":"https://api.github.com/repos/kennethreitz/requests/subscribers","subscription_url":"https://api.github.com/repos/kennethreitz/requests/subscription","commits_url":"https://api.github.com/repos/kennethreitz/requests/commits{/sha}","git_commits_url":"https://api.github.com/repos/kennethreitz/requests/git/commits{/sha}","comments_url":"https://api.github.com/repos/kennethreitz/requests/comments{/number}","issue_comment_url":"https://api.github.com/repos/kennethreitz/requests/issues/comments{/number}","contents_url":"https://api.github.com/repos/kennethreitz/requests/contents/{+path}","compare_url":"https://api.github.com/repos/kennethreitz/requests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kennethreitz/requests/merges","archive_url":"https://api.github.com/repos/kennethreitz/requests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kennethreitz/requests/downloads","issues_url":"https://api.github.com/repos/kennethreitz/requests/issues{/number}","pulls_url":"https://api.github.com/repos/kennethreitz/requests/pulls{/number}","milestones_url":"https://api.github.com/repos/kennethreitz/requests/milestones{/number}","notifications_url":"https://api.github.com/repos/kennethreitz/requests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kennethreitz/requests/labels{/name}","releases_url":"https://api.github.com/repos/kennethreitz/requests/releases{/id}","deployments_url":"https://api.github.com/repos/kennethreitz/requests/deployments","created_at":"2011-02-13T18:38:17Z","updated_at":"2016-10-24T07:12:16Z","pushed_at":"2016-10-23T16:07:44Z","git_url":"git://github.com/kennethreitz/requests.git","ssh_url":"git@github.com:kennethreitz/requests.git","clone_url":"https://github.com/kennethreitz/requests.git","svn_url":"https://github.com/kennethreitz/requests","homepage":"python-requests.org","size":9782,"stargazers_count":21475,"watchers_count":21475,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3818,"mirror_url":null,"open_issues_count":97,"forks":3818,"open_issues":97,"watchers":21475,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kennethreitz/requests/pulls/3634"},"html":{"href":"https://github.com/kennethreitz/requests/pull/3634"},"issue":{"href":"https://api.github.com/repos/kennethreitz/requests/issues/3634"},"comments":{"href":"https://api.github.com/repos/kennethreitz/requests/issues/3634/comments"},"review_comments":{"href":"https://api.github.com/repos/kennethreitz/requests/pulls/3634/comments"},"review_comment":{"href":"https://api.github.com/repos/kennethreitz/requests/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kennethreitz/requests/pulls/3634/commits"},"statuses":{"href":"https://api.github.com/repos/kennethreitz/requests/statuses/f75e608a53ecd7fc1e5631aea03102e56dd9f2d0"}}}}
{"actor":{"display_login":"Lukasa"}}