{"action":"opened","number":295,"pull_request":{"url":"https://api.github.com/repos/boutproject/BOUT-dev/pulls/295","id":88811079,"html_url":"https://github.com/boutproject/BOUT-dev/pull/295","diff_url":"https://github.com/boutproject/BOUT-dev/pull/295.diff","patch_url":"https://github.com/boutproject/BOUT-dev/pull/295.patch","issue_url":"https://api.github.com/repos/boutproject/BOUT-dev/issues/295","number":295,"state":"open","locked":false,"title":"datafile: replace returns with throw, if neccessary","user":{"login":"dschwoerer","id":5637662,"avatar_url":"https://avatars.githubusercontent.com/u/5637662?v=3","gravatar_id":"","url":"https://api.github.com/users/dschwoerer","html_url":"https://github.com/dschwoerer","followers_url":"https://api.github.com/users/dschwoerer/followers","following_url":"https://api.github.com/users/dschwoerer/following{/other_user}","gists_url":"https://api.github.com/users/dschwoerer/gists{/gist_id}","starred_url":"https://api.github.com/users/dschwoerer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dschwoerer/subscriptions","organizations_url":"https://api.github.com/users/dschwoerer/orgs","repos_url":"https://api.github.com/users/dschwoerer/repos","events_url":"https://api.github.com/users/dschwoerer/events{/privacy}","received_events_url":"https://api.github.com/users/dschwoerer/received_events","type":"User","site_admin":false},"body":"Instead of silently ignoring errors - throw an exception.\r\n\r\nIf you now want to try to open a file, but don't care if it succeeds, you have to use the try statement.\r\n\r\nI guess we could/should remove the return type (bool) on all these functions, as they always return true (which was quite confusing for me, as in c you would expect an non-zero return type (aka true) if an error occurred ...","created_at":"2016-10-11T10:53:39Z","updated_at":"2016-10-11T10:53:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"341ae65984901495399c597440ecbf0984b362d7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/boutproject/BOUT-dev/pulls/295/commits","review_comments_url":"https://api.github.com/repos/boutproject/BOUT-dev/pulls/295/comments","review_comment_url":"https://api.github.com/repos/boutproject/BOUT-dev/pulls/comments{/number}","comments_url":"https://api.github.com/repos/boutproject/BOUT-dev/issues/295/comments","statuses_url":"https://api.github.com/repos/boutproject/BOUT-dev/statuses/adb385cb313afa889a1e10916d1aa3aabf621837","head":{"label":"dschwoerer:master-datafile-throwing","ref":"master-datafile-throwing","sha":"adb385cb313afa889a1e10916d1aa3aabf621837","user":{"login":"dschwoerer","id":5637662,"avatar_url":"https://avatars.githubusercontent.com/u/5637662?v=3","gravatar_id":"","url":"https://api.github.com/users/dschwoerer","html_url":"https://github.com/dschwoerer","followers_url":"https://api.github.com/users/dschwoerer/followers","following_url":"https://api.github.com/users/dschwoerer/following{/other_user}","gists_url":"https://api.github.com/users/dschwoerer/gists{/gist_id}","starred_url":"https://api.github.com/users/dschwoerer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dschwoerer/subscriptions","organizations_url":"https://api.github.com/users/dschwoerer/orgs","repos_url":"https://api.github.com/users/dschwoerer/repos","events_url":"https://api.github.com/users/dschwoerer/events{/privacy}","received_events_url":"https://api.github.com/users/dschwoerer/received_events","type":"User","site_admin":false},"repo":{"id":40190526,"name":"BOUT-dev","full_name":"dschwoerer/BOUT-dev","owner":{"login":"dschwoerer","id":5637662,"avatar_url":"https://avatars.githubusercontent.com/u/5637662?v=3","gravatar_id":"","url":"https://api.github.com/users/dschwoerer","html_url":"https://github.com/dschwoerer","followers_url":"https://api.github.com/users/dschwoerer/followers","following_url":"https://api.github.com/users/dschwoerer/following{/other_user}","gists_url":"https://api.github.com/users/dschwoerer/gists{/gist_id}","starred_url":"https://api.github.com/users/dschwoerer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dschwoerer/subscriptions","organizations_url":"https://api.github.com/users/dschwoerer/orgs","repos_url":"https://api.github.com/users/dschwoerer/repos","events_url":"https://api.github.com/users/dschwoerer/events{/privacy}","received_events_url":"https://api.github.com/users/dschwoerer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dschwoerer/BOUT-dev","description":"Development (unstable) branch of BOUT++","fork":true,"url":"https://api.github.com/repos/dschwoerer/BOUT-dev","forks_url":"https://api.github.com/repos/dschwoerer/BOUT-dev/forks","keys_url":"https://api.github.com/repos/dschwoerer/BOUT-dev/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dschwoerer/BOUT-dev/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dschwoerer/BOUT-dev/teams","hooks_url":"https://api.github.com/repos/dschwoerer/BOUT-dev/hooks","issue_events_url":"https://api.github.com/repos/dschwoerer/BOUT-dev/issues/events{/number}","events_url":"https://api.github.com/repos/dschwoerer/BOUT-dev/events","assignees_url":"https://api.github.com/repos/dschwoerer/BOUT-dev/assignees{/user}","branches_url":"https://api.github.com/repos/dschwoerer/BOUT-dev/branches{/branch}","tags_url":"https://api.github.com/repos/dschwoerer/BOUT-dev/tags","blobs_url":"https://api.github.com/repos/dschwoerer/BOUT-dev/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dschwoerer/BOUT-dev/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dschwoerer/BOUT-dev/git/refs{/sha}","trees_url":"https://api.github.com/repos/dschwoerer/BOUT-dev/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dschwoerer/BOUT-dev/statuses/{sha}","languages_url":"https://api.github.com/repos/dschwoerer/BOUT-dev/languages","stargazers_url":"https://api.github.com/repos/dschwoerer/BOUT-dev/stargazers","contributors_url":"https://api.github.com/repos/dschwoerer/BOUT-dev/contributors","subscribers_url":"https://api.github.com/repos/dschwoerer/BOUT-dev/subscribers","subscription_url":"https://api.github.com/repos/dschwoerer/BOUT-dev/subscription","commits_url":"https://api.github.com/repos/dschwoerer/BOUT-dev/commits{/sha}","git_commits_url":"https://api.github.com/repos/dschwoerer/BOUT-dev/git/commits{/sha}","comments_url":"https://api.github.com/repos/dschwoerer/BOUT-dev/comments{/number}","issue_comment_url":"https://api.github.com/repos/dschwoerer/BOUT-dev/issues/comments{/number}","contents_url":"https://api.github.com/repos/dschwoerer/BOUT-dev/contents/{+path}","compare_url":"https://api.github.com/repos/dschwoerer/BOUT-dev/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dschwoerer/BOUT-dev/merges","archive_url":"https://api.github.com/repos/dschwoerer/BOUT-dev/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dschwoerer/BOUT-dev/downloads","issues_url":"https://api.github.com/repos/dschwoerer/BOUT-dev/issues{/number}","pulls_url":"https://api.github.com/repos/dschwoerer/BOUT-dev/pulls{/number}","milestones_url":"https://api.github.com/repos/dschwoerer/BOUT-dev/milestones{/number}","notifications_url":"https://api.github.com/repos/dschwoerer/BOUT-dev/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dschwoerer/BOUT-dev/labels{/name}","releases_url":"https://api.github.com/repos/dschwoerer/BOUT-dev/releases{/id}","deployments_url":"https://api.github.com/repos/dschwoerer/BOUT-dev/deployments","created_at":"2015-08-04T14:45:05Z","updated_at":"2016-01-11T19:02:04Z","pushed_at":"2016-10-11T10:49:11Z","git_url":"git://github.com/dschwoerer/BOUT-dev.git","ssh_url":"git@github.com:dschwoerer/BOUT-dev.git","clone_url":"https://github.com/dschwoerer/BOUT-dev.git","svn_url":"https://github.com/dschwoerer/BOUT-dev","homepage":null,"size":25888,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"boutproject:master","ref":"master","sha":"8057d754f03929c000a49045c41cef4b4f75d38e","user":{"login":"boutproject","id":5280238,"avatar_url":"https://avatars.githubusercontent.com/u/5280238?v=3","gravatar_id":"","url":"https://api.github.com/users/boutproject","html_url":"https://github.com/boutproject","followers_url":"https://api.github.com/users/boutproject/followers","following_url":"https://api.github.com/users/boutproject/following{/other_user}","gists_url":"https://api.github.com/users/boutproject/gists{/gist_id}","starred_url":"https://api.github.com/users/boutproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boutproject/subscriptions","organizations_url":"https://api.github.com/users/boutproject/orgs","repos_url":"https://api.github.com/users/boutproject/repos","events_url":"https://api.github.com/users/boutproject/events{/privacy}","received_events_url":"https://api.github.com/users/boutproject/received_events","type":"Organization","site_admin":false},"repo":{"id":12783634,"name":"BOUT-dev","full_name":"boutproject/BOUT-dev","owner":{"login":"boutproject","id":5280238,"avatar_url":"https://avatars.githubusercontent.com/u/5280238?v=3","gravatar_id":"","url":"https://api.github.com/users/boutproject","html_url":"https://github.com/boutproject","followers_url":"https://api.github.com/users/boutproject/followers","following_url":"https://api.github.com/users/boutproject/following{/other_user}","gists_url":"https://api.github.com/users/boutproject/gists{/gist_id}","starred_url":"https://api.github.com/users/boutproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boutproject/subscriptions","organizations_url":"https://api.github.com/users/boutproject/orgs","repos_url":"https://api.github.com/users/boutproject/repos","events_url":"https://api.github.com/users/boutproject/events{/privacy}","received_events_url":"https://api.github.com/users/boutproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/boutproject/BOUT-dev","description":"Development (unstable) branch of BOUT++","fork":false,"url":"https://api.github.com/repos/boutproject/BOUT-dev","forks_url":"https://api.github.com/repos/boutproject/BOUT-dev/forks","keys_url":"https://api.github.com/repos/boutproject/BOUT-dev/keys{/key_id}","collaborators_url":"https://api.github.com/repos/boutproject/BOUT-dev/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/boutproject/BOUT-dev/teams","hooks_url":"https://api.github.com/repos/boutproject/BOUT-dev/hooks","issue_events_url":"https://api.github.com/repos/boutproject/BOUT-dev/issues/events{/number}","events_url":"https://api.github.com/repos/boutproject/BOUT-dev/events","assignees_url":"https://api.github.com/repos/boutproject/BOUT-dev/assignees{/user}","branches_url":"https://api.github.com/repos/boutproject/BOUT-dev/branches{/branch}","tags_url":"https://api.github.com/repos/boutproject/BOUT-dev/tags","blobs_url":"https://api.github.com/repos/boutproject/BOUT-dev/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/boutproject/BOUT-dev/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/boutproject/BOUT-dev/git/refs{/sha}","trees_url":"https://api.github.com/repos/boutproject/BOUT-dev/git/trees{/sha}","statuses_url":"https://api.github.com/repos/boutproject/BOUT-dev/statuses/{sha}","languages_url":"https://api.github.com/repos/boutproject/BOUT-dev/languages","stargazers_url":"https://api.github.com/repos/boutproject/BOUT-dev/stargazers","contributors_url":"https://api.github.com/repos/boutproject/BOUT-dev/contributors","subscribers_url":"https://api.github.com/repos/boutproject/BOUT-dev/subscribers","subscription_url":"https://api.github.com/repos/boutproject/BOUT-dev/subscription","commits_url":"https://api.github.com/repos/boutproject/BOUT-dev/commits{/sha}","git_commits_url":"https://api.github.com/repos/boutproject/BOUT-dev/git/commits{/sha}","comments_url":"https://api.github.com/repos/boutproject/BOUT-dev/comments{/number}","issue_comment_url":"https://api.github.com/repos/boutproject/BOUT-dev/issues/comments{/number}","contents_url":"https://api.github.com/repos/boutproject/BOUT-dev/contents/{+path}","compare_url":"https://api.github.com/repos/boutproject/BOUT-dev/compare/{base}...{head}","merges_url":"https://api.github.com/repos/boutproject/BOUT-dev/merges","archive_url":"https://api.github.com/repos/boutproject/BOUT-dev/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/boutproject/BOUT-dev/downloads","issues_url":"https://api.github.com/repos/boutproject/BOUT-dev/issues{/number}","pulls_url":"https://api.github.com/repos/boutproject/BOUT-dev/pulls{/number}","milestones_url":"https://api.github.com/repos/boutproject/BOUT-dev/milestones{/number}","notifications_url":"https://api.github.com/repos/boutproject/BOUT-dev/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/boutproject/BOUT-dev/labels{/name}","releases_url":"https://api.github.com/repos/boutproject/BOUT-dev/releases{/id}","deployments_url":"https://api.github.com/repos/boutproject/BOUT-dev/deployments","created_at":"2013-09-12T12:57:55Z","updated_at":"2016-09-26T15:41:19Z","pushed_at":"2016-10-11T10:53:40Z","git_url":"git://github.com/boutproject/BOUT-dev.git","ssh_url":"git@github.com:boutproject/BOUT-dev.git","clone_url":"https://github.com/boutproject/BOUT-dev.git","svn_url":"https://github.com/boutproject/BOUT-dev","homepage":null,"size":32972,"stargazers_count":10,"watchers_count":10,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":94,"forks":18,"open_issues":94,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/boutproject/BOUT-dev/pulls/295"},"html":{"href":"https://github.com/boutproject/BOUT-dev/pull/295"},"issue":{"href":"https://api.github.com/repos/boutproject/BOUT-dev/issues/295"},"comments":{"href":"https://api.github.com/repos/boutproject/BOUT-dev/issues/295/comments"},"review_comments":{"href":"https://api.github.com/repos/boutproject/BOUT-dev/pulls/295/comments"},"review_comment":{"href":"https://api.github.com/repos/boutproject/BOUT-dev/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/boutproject/BOUT-dev/pulls/295/commits"},"statuses":{"href":"https://api.github.com/repos/boutproject/BOUT-dev/statuses/adb385cb313afa889a1e10916d1aa3aabf621837"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":34,"deletions":20,"changed_files":1}}
{"actor":{"display_login":"dschwoerer"}}