{"action":"created","issue":{"url":"https://api.github.com/repos/HIPS/autograd/issues/114","repository_url":"https://api.github.com/repos/HIPS/autograd","labels_url":"https://api.github.com/repos/HIPS/autograd/issues/114/labels{/name}","comments_url":"https://api.github.com/repos/HIPS/autograd/issues/114/comments","events_url":"https://api.github.com/repos/HIPS/autograd/issues/114/events","html_url":"https://github.com/HIPS/autograd/pull/114","id":158341176,"number":114,"title":"Broadcasting einsum() and matmul()","user":{"login":"yukoba","id":194666,"avatar_url":"https://avatars.githubusercontent.com/u/194666?v=3","gravatar_id":"","url":"https://api.github.com/users/yukoba","html_url":"https://github.com/yukoba","followers_url":"https://api.github.com/users/yukoba/followers","following_url":"https://api.github.com/users/yukoba/following{/other_user}","gists_url":"https://api.github.com/users/yukoba/gists{/gist_id}","starred_url":"https://api.github.com/users/yukoba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yukoba/subscriptions","organizations_url":"https://api.github.com/users/yukoba/orgs","repos_url":"https://api.github.com/users/yukoba/repos","events_url":"https://api.github.com/users/yukoba/events{/privacy}","received_events_url":"https://api.github.com/users/yukoba/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2016-06-03T10:50:22Z","updated_at":"2016-06-03T20:29:40Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/HIPS/autograd/pulls/114","html_url":"https://github.com/HIPS/autograd/pull/114","diff_url":"https://github.com/HIPS/autograd/pull/114.diff","patch_url":"https://github.com/HIPS/autograd/pull/114.patch"},"body":"I solved https://github.com/HIPS/autograd/issues/112"},"comment":{"url":"https://api.github.com/repos/HIPS/autograd/issues/comments/223686549","html_url":"https://github.com/HIPS/autograd/pull/114#issuecomment-223686549","issue_url":"https://api.github.com/repos/HIPS/autograd/issues/114","id":223686549,"user":{"login":"mattjj","id":1458824,"avatar_url":"https://avatars.githubusercontent.com/u/1458824?v=3","gravatar_id":"","url":"https://api.github.com/users/mattjj","html_url":"https://github.com/mattjj","followers_url":"https://api.github.com/users/mattjj/followers","following_url":"https://api.github.com/users/mattjj/following{/other_user}","gists_url":"https://api.github.com/users/mattjj/gists{/gist_id}","starred_url":"https://api.github.com/users/mattjj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattjj/subscriptions","organizations_url":"https://api.github.com/users/mattjj/orgs","repos_url":"https://api.github.com/users/mattjj/repos","events_url":"https://api.github.com/users/mattjj/events{/privacy}","received_events_url":"https://api.github.com/users/mattjj/received_events","type":"User","site_admin":false},"created_at":"2016-06-03T20:29:40Z","updated_at":"2016-06-03T20:29:40Z","body":"My understanding was that the version of einsum in the master branch doesn't support broadcasting at all (that is, it doesn't support ellipses in the string argument), and in that case it makes sense that the master branch wouldn't pass the above `test_einsum_ellipses_multidim` test. My understanding is that this PR is about adding support for broadcasting (i.e. support for the ellipsis), and so this seems like the right place to make that test pass.\r\n\r\nIf I understand your message correctly, it sounds like some tests with broadcasting over multiple dimensions do work, so the bug isn't that broadcasting over multiple dimensions never works. Do you know what kinds of tests fail here? That is, why does this test work\r\n\r\n```python\r\ndef test_einsum_matmult_broadcast_2(): combo_check(np.einsum, [1, 2], ['...ij,...jk->...ik'],\r\n                                                   [R(2, 3), R(2, 2, 2, 3)],\r\n                                                   [R(3, 4), R(2, 2, 3, 4)])\r\n```\r\n\r\nbut this one fails\r\n\r\n```\r\ndef test_einsum_ellipses_multidim():\r\n    combo_check(np.einsum, [1, 2], ['i...,i->...'], [R(2, 2, 2)], [R(2)])\r\n```\r\n\r\nLet me know if I'm mistaken about anything I said above."}}
{"actor":{"display_login":"mattjj"}}