{"action":"closed","number":14654,"pull_request":{"url":"https://api.github.com/repos/JuliaLang/julia/pulls/14654","id":55765353,"html_url":"https://github.com/JuliaLang/julia/pull/14654","diff_url":"https://github.com/JuliaLang/julia/pull/14654.diff","patch_url":"https://github.com/JuliaLang/julia/pull/14654.patch","issue_url":"https://api.github.com/repos/JuliaLang/julia/issues/14654","number":14654,"state":"closed","locked":false,"title":"Simplify and fix primes and primesmask [fixes #14652]","user":{"login":"pabloferz","id":8410335,"avatar_url":"https://avatars.githubusercontent.com/u/8410335?v=3","gravatar_id":"","url":"https://api.github.com/users/pabloferz","html_url":"https://github.com/pabloferz","followers_url":"https://api.github.com/users/pabloferz/followers","following_url":"https://api.github.com/users/pabloferz/following{/other_user}","gists_url":"https://api.github.com/users/pabloferz/gists{/gist_id}","starred_url":"https://api.github.com/users/pabloferz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pabloferz/subscriptions","organizations_url":"https://api.github.com/users/pabloferz/orgs","repos_url":"https://api.github.com/users/pabloferz/repos","events_url":"https://api.github.com/users/pabloferz/events{/privacy}","received_events_url":"https://api.github.com/users/pabloferz/received_events","type":"User","site_admin":false},"body":"This simplifies the code to compute `primes` and `primesmask` given that there was no significant speed difference between the to existing methods. Also [fixes #14652].\r\n\r\nMoreover, there's no need to add new tests for this as the current tests cover the issue via the new definitions.","created_at":"2016-01-12T14:35:44Z","updated_at":"2016-01-14T11:02:13Z","closed_at":"2016-01-14T11:02:13Z","merged_at":"2016-01-14T11:02:13Z","merge_commit_sha":"573c1f38bd98a111265ff2af47b9815751034b06","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/JuliaLang/julia/pulls/14654/commits","review_comments_url":"https://api.github.com/repos/JuliaLang/julia/pulls/14654/comments","review_comment_url":"https://api.github.com/repos/JuliaLang/julia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JuliaLang/julia/issues/14654/comments","statuses_url":"https://api.github.com/repos/JuliaLang/julia/statuses/4bd5c19bb0efc4ded0de048e8eb9e3c7e7258e0e","head":{"label":"pabloferz:pz/primes","ref":"pz/primes","sha":"4bd5c19bb0efc4ded0de048e8eb9e3c7e7258e0e","user":{"login":"pabloferz","id":8410335,"avatar_url":"https://avatars.githubusercontent.com/u/8410335?v=3","gravatar_id":"","url":"https://api.github.com/users/pabloferz","html_url":"https://github.com/pabloferz","followers_url":"https://api.github.com/users/pabloferz/followers","following_url":"https://api.github.com/users/pabloferz/following{/other_user}","gists_url":"https://api.github.com/users/pabloferz/gists{/gist_id}","starred_url":"https://api.github.com/users/pabloferz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pabloferz/subscriptions","organizations_url":"https://api.github.com/users/pabloferz/orgs","repos_url":"https://api.github.com/users/pabloferz/repos","events_url":"https://api.github.com/users/pabloferz/events{/privacy}","received_events_url":"https://api.github.com/users/pabloferz/received_events","type":"User","site_admin":false},"repo":{"id":36888587,"name":"julia","full_name":"pabloferz/julia","owner":{"login":"pabloferz","id":8410335,"avatar_url":"https://avatars.githubusercontent.com/u/8410335?v=3","gravatar_id":"","url":"https://api.github.com/users/pabloferz","html_url":"https://github.com/pabloferz","followers_url":"https://api.github.com/users/pabloferz/followers","following_url":"https://api.github.com/users/pabloferz/following{/other_user}","gists_url":"https://api.github.com/users/pabloferz/gists{/gist_id}","starred_url":"https://api.github.com/users/pabloferz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pabloferz/subscriptions","organizations_url":"https://api.github.com/users/pabloferz/orgs","repos_url":"https://api.github.com/users/pabloferz/repos","events_url":"https://api.github.com/users/pabloferz/events{/privacy}","received_events_url":"https://api.github.com/users/pabloferz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pabloferz/julia","description":"The Julia Language: A fresh approach to technical computing.","fork":true,"url":"https://api.github.com/repos/pabloferz/julia","forks_url":"https://api.github.com/repos/pabloferz/julia/forks","keys_url":"https://api.github.com/repos/pabloferz/julia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pabloferz/julia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pabloferz/julia/teams","hooks_url":"https://api.github.com/repos/pabloferz/julia/hooks","issue_events_url":"https://api.github.com/repos/pabloferz/julia/issues/events{/number}","events_url":"https://api.github.com/repos/pabloferz/julia/events","assignees_url":"https://api.github.com/repos/pabloferz/julia/assignees{/user}","branches_url":"https://api.github.com/repos/pabloferz/julia/branches{/branch}","tags_url":"https://api.github.com/repos/pabloferz/julia/tags","blobs_url":"https://api.github.com/repos/pabloferz/julia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pabloferz/julia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pabloferz/julia/git/refs{/sha}","trees_url":"https://api.github.com/repos/pabloferz/julia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pabloferz/julia/statuses/{sha}","languages_url":"https://api.github.com/repos/pabloferz/julia/languages","stargazers_url":"https://api.github.com/repos/pabloferz/julia/stargazers","contributors_url":"https://api.github.com/repos/pabloferz/julia/contributors","subscribers_url":"https://api.github.com/repos/pabloferz/julia/subscribers","subscription_url":"https://api.github.com/repos/pabloferz/julia/subscription","commits_url":"https://api.github.com/repos/pabloferz/julia/commits{/sha}","git_commits_url":"https://api.github.com/repos/pabloferz/julia/git/commits{/sha}","comments_url":"https://api.github.com/repos/pabloferz/julia/comments{/number}","issue_comment_url":"https://api.github.com/repos/pabloferz/julia/issues/comments{/number}","contents_url":"https://api.github.com/repos/pabloferz/julia/contents/{+path}","compare_url":"https://api.github.com/repos/pabloferz/julia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pabloferz/julia/merges","archive_url":"https://api.github.com/repos/pabloferz/julia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pabloferz/julia/downloads","issues_url":"https://api.github.com/repos/pabloferz/julia/issues{/number}","pulls_url":"https://api.github.com/repos/pabloferz/julia/pulls{/number}","milestones_url":"https://api.github.com/repos/pabloferz/julia/milestones{/number}","notifications_url":"https://api.github.com/repos/pabloferz/julia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pabloferz/julia/labels{/name}","releases_url":"https://api.github.com/repos/pabloferz/julia/releases{/id}","created_at":"2015-06-04T18:40:41Z","updated_at":"2016-01-12T10:40:47Z","pushed_at":"2016-01-13T14:59:30Z","git_url":"git://github.com/pabloferz/julia.git","ssh_url":"git@github.com:pabloferz/julia.git","clone_url":"https://github.com/pabloferz/julia.git","svn_url":"https://github.com/pabloferz/julia","homepage":"http://julialang.org/","size":93170,"stargazers_count":0,"watchers_count":0,"language":"Julia","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JuliaLang:master","ref":"master","sha":"cf3259fce03c9cc3ab48a2952f7d23bb0db1b6e6","user":{"login":"JuliaLang","id":743164,"avatar_url":"https://avatars.githubusercontent.com/u/743164?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"repo":{"id":1644196,"name":"julia","full_name":"JuliaLang/julia","owner":{"login":"JuliaLang","id":743164,"avatar_url":"https://avatars.githubusercontent.com/u/743164?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JuliaLang/julia","description":"The Julia Language: A fresh approach to technical computing.","fork":false,"url":"https://api.github.com/repos/JuliaLang/julia","forks_url":"https://api.github.com/repos/JuliaLang/julia/forks","keys_url":"https://api.github.com/repos/JuliaLang/julia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaLang/julia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaLang/julia/teams","hooks_url":"https://api.github.com/repos/JuliaLang/julia/hooks","issue_events_url":"https://api.github.com/repos/JuliaLang/julia/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaLang/julia/events","assignees_url":"https://api.github.com/repos/JuliaLang/julia/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaLang/julia/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaLang/julia/tags","blobs_url":"https://api.github.com/repos/JuliaLang/julia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaLang/julia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaLang/julia/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaLang/julia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaLang/julia/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaLang/julia/languages","stargazers_url":"https://api.github.com/repos/JuliaLang/julia/stargazers","contributors_url":"https://api.github.com/repos/JuliaLang/julia/contributors","subscribers_url":"https://api.github.com/repos/JuliaLang/julia/subscribers","subscription_url":"https://api.github.com/repos/JuliaLang/julia/subscription","commits_url":"https://api.github.com/repos/JuliaLang/julia/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaLang/julia/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaLang/julia/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaLang/julia/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaLang/julia/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaLang/julia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaLang/julia/merges","archive_url":"https://api.github.com/repos/JuliaLang/julia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaLang/julia/downloads","issues_url":"https://api.github.com/repos/JuliaLang/julia/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaLang/julia/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaLang/julia/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaLang/julia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaLang/julia/labels{/name}","releases_url":"https://api.github.com/repos/JuliaLang/julia/releases{/id}","created_at":"2011-04-21T07:01:50Z","updated_at":"2016-01-14T07:31:17Z","pushed_at":"2016-01-14T11:02:14Z","git_url":"git://github.com/JuliaLang/julia.git","ssh_url":"git@github.com:JuliaLang/julia.git","clone_url":"https://github.com/JuliaLang/julia.git","svn_url":"https://github.com/JuliaLang/julia","homepage":"http://julialang.org/","size":118727,"stargazers_count":6588,"watchers_count":6588,"language":"Julia","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1469,"mirror_url":null,"open_issues_count":1585,"forks":1469,"open_issues":1585,"watchers":6588,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/14654"},"html":{"href":"https://github.com/JuliaLang/julia/pull/14654"},"issue":{"href":"https://api.github.com/repos/JuliaLang/julia/issues/14654"},"comments":{"href":"https://api.github.com/repos/JuliaLang/julia/issues/14654/comments"},"review_comments":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/14654/comments"},"review_comment":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/14654/commits"},"statuses":{"href":"https://api.github.com/repos/JuliaLang/julia/statuses/4bd5c19bb0efc4ded0de048e8eb9e3c7e7258e0e"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"tkelman","id":5934628,"avatar_url":"https://avatars.githubusercontent.com/u/5934628?v=3","gravatar_id":"","url":"https://api.github.com/users/tkelman","html_url":"https://github.com/tkelman","followers_url":"https://api.github.com/users/tkelman/followers","following_url":"https://api.github.com/users/tkelman/following{/other_user}","gists_url":"https://api.github.com/users/tkelman/gists{/gist_id}","starred_url":"https://api.github.com/users/tkelman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkelman/subscriptions","organizations_url":"https://api.github.com/users/tkelman/orgs","repos_url":"https://api.github.com/users/tkelman/repos","events_url":"https://api.github.com/users/tkelman/events{/privacy}","received_events_url":"https://api.github.com/users/tkelman/received_events","type":"User","site_admin":false},"comments":8,"review_comments":0,"commits":1,"additions":19,"deletions":41,"changed_files":1}}