{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/azure-rest-api-specs/pulls/comments/83474894","pull_request_review_id":4316752,"id":83474894,"diff_hunk":"@@ -0,0 +1,118 @@\n+# Resource definitions \n+\n+## V1 version\n+If V1 version of Resource is needed, please add the following in the `definitions` section of swagger spec.\n+\n+```\n+\t\"Resource\": {\n+          \"properties\": {\n+            \"id\": {\n+              \"readOnly\": true,\n+              \"type\": \"string\",\n+              \"description\": \"Resource Id\"\n+            },\n+            \"name\": {\n+              \"readOnly\": true,\n+              \"type\": \"string\",\n+              \"description\": \"Resource name\"\n+            },\n+            \"type\": {\n+              \"readOnly\": true,\n+              \"type\": \"string\",\n+              \"description\": \"Resource type\"\n+            },\n+            \"location\": {\n+              \"type\": \"string\",\n+              \"description\": \"Resource location\"\n+            },\n+            \"tags\": {\n+              \"type\": \"object\",\n+              \"additionalProperties\": {\n+                \"type\": \"string\"\n+              },\n+              \"description\": \"Resource tags\"\n+            }\n+          },\n+          \"required\": [\n+            \"location\"\n+          ],\n+          \"x-ms-azure-resource\": true\n+        }\n+```\n+\n+## V2 version\n+If V2 version of Resource is needed, please add the following in the `definitions` section of swagger spec.","path":"documentation/resource-definitions.md","position":44,"original_position":44,"commit_id":"e6ee62444c9dff18da84446310ffe3deacdb115c","original_commit_id":"151cbb5bc724634fe1f2f077eab354c7a20bb8bf","user":{"login":"johanste","id":15110018,"avatar_url":"https://avatars.githubusercontent.com/u/15110018?v=3","gravatar_id":"","url":"https://api.github.com/users/johanste","html_url":"https://github.com/johanste","followers_url":"https://api.github.com/users/johanste/followers","following_url":"https://api.github.com/users/johanste/following{/other_user}","gists_url":"https://api.github.com/users/johanste/gists{/gist_id}","starred_url":"https://api.github.com/users/johanste/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johanste/subscriptions","organizations_url":"https://api.github.com/users/johanste/orgs","repos_url":"https://api.github.com/users/johanste/repos","events_url":"https://api.github.com/users/johanste/events{/privacy}","received_events_url":"https://api.github.com/users/johanste/received_events","type":"User","site_admin":false},"body":"Is there an expectation to annotate a V2 resource with x-ms-azure-resource (or x-ms-azure-resource-v2 or similar)?","created_at":"2016-10-14T18:17:38Z","updated_at":"2016-10-14T18:18:40Z","html_url":"https://github.com/Azure/azure-rest-api-specs/pull/587#discussion_r83474894","pull_request_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/pulls/587","_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-rest-api-specs/pulls/comments/83474894"},"html":{"href":"https://github.com/Azure/azure-rest-api-specs/pull/587#discussion_r83474894"},"pull_request":{"href":"https://api.github.com/repos/Azure/azure-rest-api-specs/pulls/587"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/azure-rest-api-specs/pulls/587","id":88339470,"html_url":"https://github.com/Azure/azure-rest-api-specs/pull/587","diff_url":"https://github.com/Azure/azure-rest-api-specs/pull/587.diff","patch_url":"https://github.com/Azure/azure-rest-api-specs/pull/587.patch","issue_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/issues/587","number":587,"state":"open","locked":false,"title":"[Documentation]: Added more recommended patterns ","user":{"login":"kirthik","id":1267650,"avatar_url":"https://avatars.githubusercontent.com/u/1267650?v=3","gravatar_id":"","url":"https://api.github.com/users/kirthik","html_url":"https://github.com/kirthik","followers_url":"https://api.github.com/users/kirthik/followers","following_url":"https://api.github.com/users/kirthik/following{/other_user}","gists_url":"https://api.github.com/users/kirthik/gists{/gist_id}","starred_url":"https://api.github.com/users/kirthik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kirthik/subscriptions","organizations_url":"https://api.github.com/users/kirthik/orgs","repos_url":"https://api.github.com/users/kirthik/repos","events_url":"https://api.github.com/users/kirthik/events{/privacy}","received_events_url":"https://api.github.com/users/kirthik/received_events","type":"User","site_admin":false},"body":"This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process. \r\n\r\n### PR information\r\n- [x] The title of the PR is clear and informative.\r\n- [x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, [see this page](../documentation/cleaning-up-commits.md).\r\n- [x] Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.\r\n- [ ] If applicable, the PR references the bug/issue that it fixes.\r\n- [ ] Swagger files are correctly named (e.g. the `api-version` in the path should match the `api-version` in the spec).\r\n\r\n### Quality of Swagger\r\n- [ ] I have read the [contribution guidelines](./CONTRIBUTING.md).\r\n- [ ] My spec meets the review criteria:\r\n  - [ ] The spec conforms to the [Swagger 2.0 specification](https://github.com/OAI/OpenAPI-Specification/blob/master/versions/2.0.md).\r\n  - [ ] Validation errors from the [Linter extension for VS Code](../documentation/linter.md) have all been fixed for this spec. (**Note:** for large, previously checked in specs, there will likely be many errors shown. Please contact our team so we can set a timeframe for fixing these errors if your PR is not going to address them).\r\n  - [ ] The spec follows the patterns described in the [Swagger good patterns](../documentation/swagger-good-patterns.md) document unless the service API makes this impossible.\r\n","created_at":"2016-10-06T20:56:30Z","updated_at":"2016-10-14T18:18:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d5709bec184e178a6611ab690f5f075be416b0a9","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/pulls/587/commits","review_comments_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/pulls/587/comments","review_comment_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/issues/587/comments","statuses_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/statuses/e6ee62444c9dff18da84446310ffe3deacdb115c","head":{"label":"kirthik:master","ref":"master","sha":"e6ee62444c9dff18da84446310ffe3deacdb115c","user":{"login":"kirthik","id":1267650,"avatar_url":"https://avatars.githubusercontent.com/u/1267650?v=3","gravatar_id":"","url":"https://api.github.com/users/kirthik","html_url":"https://github.com/kirthik","followers_url":"https://api.github.com/users/kirthik/followers","following_url":"https://api.github.com/users/kirthik/following{/other_user}","gists_url":"https://api.github.com/users/kirthik/gists{/gist_id}","starred_url":"https://api.github.com/users/kirthik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kirthik/subscriptions","organizations_url":"https://api.github.com/users/kirthik/orgs","repos_url":"https://api.github.com/users/kirthik/repos","events_url":"https://api.github.com/users/kirthik/events{/privacy}","received_events_url":"https://api.github.com/users/kirthik/received_events","type":"User","site_admin":false},"repo":{"id":66035245,"name":"azure-rest-api-specs","full_name":"kirthik/azure-rest-api-specs","owner":{"login":"kirthik","id":1267650,"avatar_url":"https://avatars.githubusercontent.com/u/1267650?v=3","gravatar_id":"","url":"https://api.github.com/users/kirthik","html_url":"https://github.com/kirthik","followers_url":"https://api.github.com/users/kirthik/followers","following_url":"https://api.github.com/users/kirthik/following{/other_user}","gists_url":"https://api.github.com/users/kirthik/gists{/gist_id}","starred_url":"https://api.github.com/users/kirthik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kirthik/subscriptions","organizations_url":"https://api.github.com/users/kirthik/orgs","repos_url":"https://api.github.com/users/kirthik/repos","events_url":"https://api.github.com/users/kirthik/events{/privacy}","received_events_url":"https://api.github.com/users/kirthik/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kirthik/azure-rest-api-specs","description":"The source for REST API specifications for Microsoft Azure.","fork":true,"url":"https://api.github.com/repos/kirthik/azure-rest-api-specs","forks_url":"https://api.github.com/repos/kirthik/azure-rest-api-specs/forks","keys_url":"https://api.github.com/repos/kirthik/azure-rest-api-specs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kirthik/azure-rest-api-specs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kirthik/azure-rest-api-specs/teams","hooks_url":"https://api.github.com/repos/kirthik/azure-rest-api-specs/hooks","issue_events_url":"https://api.github.com/repos/kirthik/azure-rest-api-specs/issues/events{/number}","events_url":"https://api.github.com/repos/kirthik/azure-rest-api-specs/events","assignees_url":"https://api.github.com/repos/kirthik/azure-rest-api-specs/assignees{/user}","branches_url":"https://api.github.com/repos/kirthik/azure-rest-api-specs/branches{/branch}","tags_url":"https://api.github.com/repos/kirthik/azure-rest-api-specs/tags","blobs_url":"https://api.github.com/repos/kirthik/azure-rest-api-specs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kirthik/azure-rest-api-specs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kirthik/azure-rest-api-specs/git/refs{/sha}","trees_url":"https://api.github.com/repos/kirthik/azure-rest-api-specs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kirthik/azure-rest-api-specs/statuses/{sha}","languages_url":"https://api.github.com/repos/kirthik/azure-rest-api-specs/languages","stargazers_url":"https://api.github.com/repos/kirthik/azure-rest-api-specs/stargazers","contributors_url":"https://api.github.com/repos/kirthik/azure-rest-api-specs/contributors","subscribers_url":"https://api.github.com/repos/kirthik/azure-rest-api-specs/subscribers","subscription_url":"https://api.github.com/repos/kirthik/azure-rest-api-specs/subscription","commits_url":"https://api.github.com/repos/kirthik/azure-rest-api-specs/commits{/sha}","git_commits_url":"https://api.github.com/repos/kirthik/azure-rest-api-specs/git/commits{/sha}","comments_url":"https://api.github.com/repos/kirthik/azure-rest-api-specs/comments{/number}","issue_comment_url":"https://api.github.com/repos/kirthik/azure-rest-api-specs/issues/comments{/number}","contents_url":"https://api.github.com/repos/kirthik/azure-rest-api-specs/contents/{+path}","compare_url":"https://api.github.com/repos/kirthik/azure-rest-api-specs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kirthik/azure-rest-api-specs/merges","archive_url":"https://api.github.com/repos/kirthik/azure-rest-api-specs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kirthik/azure-rest-api-specs/downloads","issues_url":"https://api.github.com/repos/kirthik/azure-rest-api-specs/issues{/number}","pulls_url":"https://api.github.com/repos/kirthik/azure-rest-api-specs/pulls{/number}","milestones_url":"https://api.github.com/repos/kirthik/azure-rest-api-specs/milestones{/number}","notifications_url":"https://api.github.com/repos/kirthik/azure-rest-api-specs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kirthik/azure-rest-api-specs/labels{/name}","releases_url":"https://api.github.com/repos/kirthik/azure-rest-api-specs/releases{/id}","deployments_url":"https://api.github.com/repos/kirthik/azure-rest-api-specs/deployments","created_at":"2016-08-18T22:38:25Z","updated_at":"2016-08-18T22:38:27Z","pushed_at":"2016-10-14T18:15:33Z","git_url":"git://github.com/kirthik/azure-rest-api-specs.git","ssh_url":"git@github.com:kirthik/azure-rest-api-specs.git","clone_url":"https://github.com/kirthik/azure-rest-api-specs.git","svn_url":"https://github.com/kirthik/azure-rest-api-specs","homepage":"","size":4420,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Azure:master","ref":"master","sha":"3a2eb470be8f2ceb7195d5c3eb7372fec806df20","user":{"login":"Azure","id":6844498,"avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=3","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":39093389,"name":"azure-rest-api-specs","full_name":"Azure/azure-rest-api-specs","owner":{"login":"Azure","id":6844498,"avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=3","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/azure-rest-api-specs","description":"The source for REST API specifications for Microsoft Azure.","fork":false,"url":"https://api.github.com/repos/Azure/azure-rest-api-specs","forks_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/forks","keys_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/teams","hooks_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/events","assignees_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/tags","blobs_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/subscription","commits_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/merges","archive_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/downloads","issues_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/deployments","created_at":"2015-07-14T18:37:13Z","updated_at":"2016-10-11T19:31:27Z","pushed_at":"2016-10-14T18:15:34Z","git_url":"git://github.com/Azure/azure-rest-api-specs.git","ssh_url":"git@github.com:Azure/azure-rest-api-specs.git","clone_url":"https://github.com/Azure/azure-rest-api-specs.git","svn_url":"https://github.com/Azure/azure-rest-api-specs","homepage":"","size":5578,"stargazers_count":92,"watchers_count":92,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":175,"mirror_url":null,"open_issues_count":96,"forks":175,"open_issues":96,"watchers":92,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-rest-api-specs/pulls/587"},"html":{"href":"https://github.com/Azure/azure-rest-api-specs/pull/587"},"issue":{"href":"https://api.github.com/repos/Azure/azure-rest-api-specs/issues/587"},"comments":{"href":"https://api.github.com/repos/Azure/azure-rest-api-specs/issues/587/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/azure-rest-api-specs/pulls/587/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/azure-rest-api-specs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/azure-rest-api-specs/pulls/587/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/azure-rest-api-specs/statuses/e6ee62444c9dff18da84446310ffe3deacdb115c"}}}}
{"actor":{"display_login":"johanste"}}