{"action":"created","comment":{"url":"https://api.github.com/repos/ceph/ceph-installer/pulls/comments/55219566","id":55219566,"diff_hunk":"@@ -102,6 +102,20 @@ def test_redhat_storage_is_false(self):\n         }\n         assert result == expected\n \n+    def test_redhat_use_cdn_is_true(self):\n+        data = dict(redhat_storage=True, redhat_use_cdn=True)\n+        result = util.get_install_extra_vars(data)\n+        assert \"ceph_stable_rh_storage\" in result\n+        assert \"ceph_stable_rh_storage_cdn_install\" in result\n+\n+    def test_redhat_use_cdn_is_false(self):\n+        data = dict(redhat_storage=True, redhat_use_cdn=False)\n+        result = util.get_install_extra_vars(data)\n+        assert \"ceph_stable_rh_storage\" in result\n+        assert \"ceph_origin\" in result","path":"ceph_installer/tests/test_util.py","position":14,"original_position":14,"commit_id":"a387d8c55d8d03119ed0f13c049cac68cb6eafa2","original_commit_id":"a387d8c55d8d03119ed0f13c049cac68cb6eafa2","user":{"login":"alfredodeza","id":317847,"avatar_url":"https://avatars.githubusercontent.com/u/317847?v=3","gravatar_id":"","url":"https://api.github.com/users/alfredodeza","html_url":"https://github.com/alfredodeza","followers_url":"https://api.github.com/users/alfredodeza/followers","following_url":"https://api.github.com/users/alfredodeza/following{/other_user}","gists_url":"https://api.github.com/users/alfredodeza/gists{/gist_id}","starred_url":"https://api.github.com/users/alfredodeza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alfredodeza/subscriptions","organizations_url":"https://api.github.com/users/alfredodeza/orgs","repos_url":"https://api.github.com/users/alfredodeza/repos","events_url":"https://api.github.com/users/alfredodeza/events{/privacy}","received_events_url":"https://api.github.com/users/alfredodeza/received_events","type":"User","site_admin":false},"body":"if `ceph_origin` should be in here, wouldn't the opposite be correct for the other test? Maybe this warrants a separate test for this value","created_at":"2016-03-07T15:34:04Z","updated_at":"2016-03-07T15:34:04Z","html_url":"https://github.com/ceph/ceph-installer/pull/109#discussion_r55219566","pull_request_url":"https://api.github.com/repos/ceph/ceph-installer/pulls/109","_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph-installer/pulls/comments/55219566"},"html":{"href":"https://github.com/ceph/ceph-installer/pull/109#discussion_r55219566"},"pull_request":{"href":"https://api.github.com/repos/ceph/ceph-installer/pulls/109"}}},"pull_request":{"url":"https://api.github.com/repos/ceph/ceph-installer/pulls/109","id":61932464,"html_url":"https://github.com/ceph/ceph-installer/pull/109","diff_url":"https://github.com/ceph/ceph-installer/pull/109.diff","patch_url":"https://github.com/ceph/ceph-installer/pull/109.patch","issue_url":"https://api.github.com/repos/ceph/ceph-installer/issues/109","number":109,"state":"open","locked":false,"title":"install RHCS from distro provided packages","user":{"login":"andrewschoen","id":20618,"avatar_url":"https://avatars.githubusercontent.com/u/20618?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewschoen","html_url":"https://github.com/andrewschoen","followers_url":"https://api.github.com/users/andrewschoen/followers","following_url":"https://api.github.com/users/andrewschoen/following{/other_user}","gists_url":"https://api.github.com/users/andrewschoen/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewschoen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewschoen/subscriptions","organizations_url":"https://api.github.com/users/andrewschoen/orgs","repos_url":"https://api.github.com/users/andrewschoen/repos","events_url":"https://api.github.com/users/andrewschoen/events{/privacy}","received_events_url":"https://api.github.com/users/andrewschoen/received_events","type":"User","site_admin":false},"body":"This could be used if the administrator manually placed yum repos or\r\nif the node has been pre-registered with Satellite.\r\n\r\nFixes: https://bugzilla.redhat.com/show_bug.cgi?id=1314455","created_at":"2016-03-07T15:29:00Z","updated_at":"2016-03-07T15:34:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"10cb3ce237688f2fba4df5662d8640a8582a7521","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ceph/ceph-installer/pulls/109/commits","review_comments_url":"https://api.github.com/repos/ceph/ceph-installer/pulls/109/comments","review_comment_url":"https://api.github.com/repos/ceph/ceph-installer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ceph/ceph-installer/issues/109/comments","statuses_url":"https://api.github.com/repos/ceph/ceph-installer/statuses/a387d8c55d8d03119ed0f13c049cac68cb6eafa2","head":{"label":"ceph:distro-rhcs","ref":"distro-rhcs","sha":"a387d8c55d8d03119ed0f13c049cac68cb6eafa2","user":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":35046025,"name":"ceph-installer","full_name":"ceph/ceph-installer","owner":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ceph/ceph-installer","description":"A service to provision Ceph clusters","fork":false,"url":"https://api.github.com/repos/ceph/ceph-installer","forks_url":"https://api.github.com/repos/ceph/ceph-installer/forks","keys_url":"https://api.github.com/repos/ceph/ceph-installer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph-installer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph-installer/teams","hooks_url":"https://api.github.com/repos/ceph/ceph-installer/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph-installer/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph-installer/events","assignees_url":"https://api.github.com/repos/ceph/ceph-installer/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph-installer/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph-installer/tags","blobs_url":"https://api.github.com/repos/ceph/ceph-installer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph-installer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph-installer/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph-installer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph-installer/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph-installer/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph-installer/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph-installer/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph-installer/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph-installer/subscription","commits_url":"https://api.github.com/repos/ceph/ceph-installer/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph-installer/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph-installer/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph-installer/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/ceph-installer/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph-installer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph-installer/merges","archive_url":"https://api.github.com/repos/ceph/ceph-installer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph-installer/downloads","issues_url":"https://api.github.com/repos/ceph/ceph-installer/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph-installer/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph-installer/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph-installer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph-installer/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph-installer/releases{/id}","deployments_url":"https://api.github.com/repos/ceph/ceph-installer/deployments","created_at":"2015-05-04T16:29:10Z","updated_at":"2016-02-27T13:15:36Z","pushed_at":"2016-03-07T15:29:00Z","git_url":"git://github.com/ceph/ceph-installer.git","ssh_url":"git@github.com:ceph/ceph-installer.git","clone_url":"https://github.com/ceph/ceph-installer.git","svn_url":"https://github.com/ceph/ceph-installer","homepage":"","size":291,"stargazers_count":5,"watchers_count":5,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":8,"forks":2,"open_issues":8,"watchers":5,"default_branch":"master"}},"base":{"label":"ceph:master","ref":"master","sha":"b3e3c68ce82453171963c39f6de3dead53c4ee1c","user":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":35046025,"name":"ceph-installer","full_name":"ceph/ceph-installer","owner":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ceph/ceph-installer","description":"A service to provision Ceph clusters","fork":false,"url":"https://api.github.com/repos/ceph/ceph-installer","forks_url":"https://api.github.com/repos/ceph/ceph-installer/forks","keys_url":"https://api.github.com/repos/ceph/ceph-installer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph-installer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph-installer/teams","hooks_url":"https://api.github.com/repos/ceph/ceph-installer/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph-installer/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph-installer/events","assignees_url":"https://api.github.com/repos/ceph/ceph-installer/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph-installer/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph-installer/tags","blobs_url":"https://api.github.com/repos/ceph/ceph-installer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph-installer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph-installer/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph-installer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph-installer/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph-installer/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph-installer/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph-installer/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph-installer/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph-installer/subscription","commits_url":"https://api.github.com/repos/ceph/ceph-installer/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph-installer/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph-installer/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph-installer/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/ceph-installer/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph-installer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph-installer/merges","archive_url":"https://api.github.com/repos/ceph/ceph-installer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph-installer/downloads","issues_url":"https://api.github.com/repos/ceph/ceph-installer/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph-installer/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph-installer/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph-installer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph-installer/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph-installer/releases{/id}","deployments_url":"https://api.github.com/repos/ceph/ceph-installer/deployments","created_at":"2015-05-04T16:29:10Z","updated_at":"2016-02-27T13:15:36Z","pushed_at":"2016-03-07T15:29:00Z","git_url":"git://github.com/ceph/ceph-installer.git","ssh_url":"git@github.com:ceph/ceph-installer.git","clone_url":"https://github.com/ceph/ceph-installer.git","svn_url":"https://github.com/ceph/ceph-installer","homepage":"","size":291,"stargazers_count":5,"watchers_count":5,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":8,"forks":2,"open_issues":8,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph-installer/pulls/109"},"html":{"href":"https://github.com/ceph/ceph-installer/pull/109"},"issue":{"href":"https://api.github.com/repos/ceph/ceph-installer/issues/109"},"comments":{"href":"https://api.github.com/repos/ceph/ceph-installer/issues/109/comments"},"review_comments":{"href":"https://api.github.com/repos/ceph/ceph-installer/pulls/109/comments"},"review_comment":{"href":"https://api.github.com/repos/ceph/ceph-installer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ceph/ceph-installer/pulls/109/commits"},"statuses":{"href":"https://api.github.com/repos/ceph/ceph-installer/statuses/a387d8c55d8d03119ed0f13c049cac68cb6eafa2"}}}}