{"action":"created","issue":{"url":"https://api.github.com/repos/jrean/laravel-user-verification/issues/68","repository_url":"https://api.github.com/repos/jrean/laravel-user-verification","labels_url":"https://api.github.com/repos/jrean/laravel-user-verification/issues/68/labels{/name}","comments_url":"https://api.github.com/repos/jrean/laravel-user-verification/issues/68/comments","events_url":"https://api.github.com/repos/jrean/laravel-user-verification/issues/68/events","html_url":"https://github.com/jrean/laravel-user-verification/pull/68","id":177763163,"number":68,"title":"Provide resend route","user":{"login":"lukasoppermann","id":813754,"avatar_url":"https://avatars.githubusercontent.com/u/813754?v=3","gravatar_id":"","url":"https://api.github.com/users/lukasoppermann","html_url":"https://github.com/lukasoppermann","followers_url":"https://api.github.com/users/lukasoppermann/followers","following_url":"https://api.github.com/users/lukasoppermann/following{/other_user}","gists_url":"https://api.github.com/users/lukasoppermann/gists{/gist_id}","starred_url":"https://api.github.com/users/lukasoppermann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukasoppermann/subscriptions","organizations_url":"https://api.github.com/users/lukasoppermann/orgs","repos_url":"https://api.github.com/users/lukasoppermann/repos","events_url":"https://api.github.com/users/lukasoppermann/events{/privacy}","received_events_url":"https://api.github.com/users/lukasoppermann/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-09-19T11:42:02Z","updated_at":"2016-09-27T16:52:16Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/jrean/laravel-user-verification/pulls/68","html_url":"https://github.com/jrean/laravel-user-verification/pull/68","diff_url":"https://github.com/jrean/laravel-user-verification/pull/68.diff","patch_url":"https://github.com/jrean/laravel-user-verification/pull/68.patch"},"body":"Hey @jrean,\r\n\r\nthis PR for #51 is not completely done yet, but maybe you can already test it in any case.\r\n\r\n### Concerns / todos:\r\n- b/c break for people who rely on the routes from the package to the RegisterController\r\n- Controller needs to be publishable & overwritable to customize things like `redirectIfVerified` (publish not implemented, overwrite not tested yet)\r\n  - this should be moved to a config file though\r\n\r\n### Discussion\r\n- Are you fine with doing a `redirect back();` which might include an `error` flash message? Should we namespace the flash message? Like `user-verification-error`.\r\n- I implemented it using a `post` with a `user_id` which makes sense for me, as it is a kind of `post` action and this allows us to use the resend route also for e.g. for an admin resending a link to a user by triggering a post request with another users user_id\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/jrean/laravel-user-verification/issues/comments/249926145","html_url":"https://github.com/jrean/laravel-user-verification/pull/68#issuecomment-249926145","issue_url":"https://api.github.com/repos/jrean/laravel-user-verification/issues/68","id":249926145,"user":{"login":"jrean","id":5646128,"avatar_url":"https://avatars.githubusercontent.com/u/5646128?v=3","gravatar_id":"","url":"https://api.github.com/users/jrean","html_url":"https://github.com/jrean","followers_url":"https://api.github.com/users/jrean/followers","following_url":"https://api.github.com/users/jrean/following{/other_user}","gists_url":"https://api.github.com/users/jrean/gists{/gist_id}","starred_url":"https://api.github.com/users/jrean/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrean/subscriptions","organizations_url":"https://api.github.com/users/jrean/orgs","repos_url":"https://api.github.com/users/jrean/repos","events_url":"https://api.github.com/users/jrean/events{/privacy}","received_events_url":"https://api.github.com/users/jrean/received_events","type":"User","site_admin":false},"created_at":"2016-09-27T16:52:16Z","updated_at":"2016-09-27T16:52:16Z","body":"Luka, I'm reviewing the code. I need more time before merging.\r\nI need to discuss with you the \"Resend\" functionality you implemented.\r\nThe flow of this package is (to me)\r\n\r\n- 1) User Registers (user may be logged in or not after that step)\r\n- 2) Verification token is generated and stored\r\n- 3) Verification token is sent by e-mail\r\n- 4) Token (user) is verified\r\n- 5) User is set as verified\r\n\r\nThe correct question is WHEN a \"re-send\" option may be needed.\r\n- Number 3) fails. Something went wrong. An error page may be displayed and offers a button to re-launch the process. But how? If the user is logged in, easy. But what if the user is not logged in (part of an app specifications)? User should be asked to provide his e-mail address and some checks should be performed (or not) ... What is the user enters an e-mail which is not his e-mail or which is not registered...\r\n\r\n- Number 4) fails. Same as number 3)\r\n\r\n- An admin wants manually to re-launch the process of verification for 1 or many users...\r\n\r\nHence why (I remember now) why I didn't implement this functionality into the past releases. To me it is not part of the package but should be implemented by the end users of this package. This package was designed to provide the shell of a user verification.\r\n\r\nI really need to think twice about this (again).\r\n\r\nSo far, I agree with you by creating a Controller and extracting everything into it.\r\nI working on it now.\r\n\r\nInto the controller you provided:\r\n\r\nYou added at the top\r\n\r\n```\r\nuse Jrean\\UserVerification\\Traits\\RedirectsUsers;\r\n```\r\n\r\nBut you didn't include the `use` statement it into the `class` itself.\r\nIs it a mistake?\r\n\r\nPlease share you thoughts again."}}
{"actor":{"display_login":"jrean"}}