{"action":"created","comment":{"url":"https://api.github.com/repos/PX4/Firmware/pulls/comments/90755263","pull_request_review_id":11275101,"id":90755263,"diff_hunk":"@@ -1040,6 +1040,63 @@ MulticopterAttitudeControl::task_main()\n \t\t\t\t\t_controller_status_pub = orb_advertise(ORB_ID(mc_att_ctrl_status), &_controller_status);\n \t\t\t\t}\n \t\t\t}\n+\n+\t\t\tif (_v_control_mode.flag_control_termination_enabled) {","path":"src/modules/mc_att_control/mc_att_control_main.cpp","position":5,"original_position":5,"commit_id":"803acc57fc0e9ab6ea9037f9d798281b1dc20004","original_commit_id":"803acc57fc0e9ab6ea9037f9d798281b1dc20004","user":{"login":"julianoes","id":1419688,"avatar_url":"https://avatars.githubusercontent.com/u/1419688?v=3","gravatar_id":"","url":"https://api.github.com/users/julianoes","html_url":"https://github.com/julianoes","followers_url":"https://api.github.com/users/julianoes/followers","following_url":"https://api.github.com/users/julianoes/following{/other_user}","gists_url":"https://api.github.com/users/julianoes/gists{/gist_id}","starred_url":"https://api.github.com/users/julianoes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julianoes/subscriptions","organizations_url":"https://api.github.com/users/julianoes/orgs","repos_url":"https://api.github.com/users/julianoes/repos","events_url":"https://api.github.com/users/julianoes/events{/privacy}","received_events_url":"https://api.github.com/users/julianoes/received_events","type":"User","site_admin":false},"body":"Shouldn't this be taken care off in the drivers instead of the controllers?","created_at":"2016-12-03T11:03:22Z","updated_at":"2016-12-03T11:12:25Z","html_url":"https://github.com/PX4/Firmware/pull/5863#discussion_r90755263","pull_request_url":"https://api.github.com/repos/PX4/Firmware/pulls/5863","_links":{"self":{"href":"https://api.github.com/repos/PX4/Firmware/pulls/comments/90755263"},"html":{"href":"https://github.com/PX4/Firmware/pull/5863#discussion_r90755263"},"pull_request":{"href":"https://api.github.com/repos/PX4/Firmware/pulls/5863"}}},"pull_request":{"url":"https://api.github.com/repos/PX4/Firmware/pulls/5863","id":93728881,"html_url":"https://github.com/PX4/Firmware/pull/5863","diff_url":"https://github.com/PX4/Firmware/pull/5863.diff","patch_url":"https://github.com/PX4/Firmware/pull/5863.patch","issue_url":"https://api.github.com/repos/PX4/Firmware/issues/5863","number":5863,"state":"open","locked":false,"title":"Feature/First iteration on MC failsafe","user":{"login":"anton-matosov","id":3339485,"avatar_url":"https://avatars.githubusercontent.com/u/3339485?v=3","gravatar_id":"","url":"https://api.github.com/users/anton-matosov","html_url":"https://github.com/anton-matosov","followers_url":"https://api.github.com/users/anton-matosov/followers","following_url":"https://api.github.com/users/anton-matosov/following{/other_user}","gists_url":"https://api.github.com/users/anton-matosov/gists{/gist_id}","starred_url":"https://api.github.com/users/anton-matosov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anton-matosov/subscriptions","organizations_url":"https://api.github.com/users/anton-matosov/orgs","repos_url":"https://api.github.com/users/anton-matosov/repos","events_url":"https://api.github.com/users/anton-matosov/events{/privacy}","received_events_url":"https://api.github.com/users/anton-matosov/received_events","type":"User","site_admin":false},"body":"Add failsafe tune\r\nFix LED blinking for Pixracer \r\nPass rc_loss_mode instead of simple bool flag\r\nAdd setting of failsafe PWM outputs in case of force_failsafe ","created_at":"2016-11-15T09:29:27Z","updated_at":"2016-12-03T11:12:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"91e9ed00347649156e214e4dd94ca6fae3d5065c","assignee":{"login":"kd0aij","id":2300221,"avatar_url":"https://avatars.githubusercontent.com/u/2300221?v=3","gravatar_id":"","url":"https://api.github.com/users/kd0aij","html_url":"https://github.com/kd0aij","followers_url":"https://api.github.com/users/kd0aij/followers","following_url":"https://api.github.com/users/kd0aij/following{/other_user}","gists_url":"https://api.github.com/users/kd0aij/gists{/gist_id}","starred_url":"https://api.github.com/users/kd0aij/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kd0aij/subscriptions","organizations_url":"https://api.github.com/users/kd0aij/orgs","repos_url":"https://api.github.com/users/kd0aij/repos","events_url":"https://api.github.com/users/kd0aij/events{/privacy}","received_events_url":"https://api.github.com/users/kd0aij/received_events","type":"User","site_admin":false},"assignees":[{"login":"kd0aij","id":2300221,"avatar_url":"https://avatars.githubusercontent.com/u/2300221?v=3","gravatar_id":"","url":"https://api.github.com/users/kd0aij","html_url":"https://github.com/kd0aij","followers_url":"https://api.github.com/users/kd0aij/followers","following_url":"https://api.github.com/users/kd0aij/following{/other_user}","gists_url":"https://api.github.com/users/kd0aij/gists{/gist_id}","starred_url":"https://api.github.com/users/kd0aij/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kd0aij/subscriptions","organizations_url":"https://api.github.com/users/kd0aij/orgs","repos_url":"https://api.github.com/users/kd0aij/repos","events_url":"https://api.github.com/users/kd0aij/events{/privacy}","received_events_url":"https://api.github.com/users/kd0aij/received_events","type":"User","site_admin":false},{"login":"MaEtUgR","id":4668506,"avatar_url":"https://avatars.githubusercontent.com/u/4668506?v=3","gravatar_id":"","url":"https://api.github.com/users/MaEtUgR","html_url":"https://github.com/MaEtUgR","followers_url":"https://api.github.com/users/MaEtUgR/followers","following_url":"https://api.github.com/users/MaEtUgR/following{/other_user}","gists_url":"https://api.github.com/users/MaEtUgR/gists{/gist_id}","starred_url":"https://api.github.com/users/MaEtUgR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaEtUgR/subscriptions","organizations_url":"https://api.github.com/users/MaEtUgR/orgs","repos_url":"https://api.github.com/users/MaEtUgR/repos","events_url":"https://api.github.com/users/MaEtUgR/events{/privacy}","received_events_url":"https://api.github.com/users/MaEtUgR/received_events","type":"User","site_admin":false},{"login":"tumbili","id":7610489,"avatar_url":"https://avatars.githubusercontent.com/u/7610489?v=3","gravatar_id":"","url":"https://api.github.com/users/tumbili","html_url":"https://github.com/tumbili","followers_url":"https://api.github.com/users/tumbili/followers","following_url":"https://api.github.com/users/tumbili/following{/other_user}","gists_url":"https://api.github.com/users/tumbili/gists{/gist_id}","starred_url":"https://api.github.com/users/tumbili/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tumbili/subscriptions","organizations_url":"https://api.github.com/users/tumbili/orgs","repos_url":"https://api.github.com/users/tumbili/repos","events_url":"https://api.github.com/users/tumbili/events{/privacy}","received_events_url":"https://api.github.com/users/tumbili/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/PX4/Firmware/milestones/22","html_url":"https://github.com/PX4/Firmware/milestones/Release%20v1.6.0","labels_url":"https://api.github.com/repos/PX4/Firmware/milestones/22/labels","id":1812723,"number":22,"title":"Release v1.6.0","description":"The main novelty of this release is a massive NuttX update adding support for STM32F7 and fault logging.","creator":{"login":"LorenzMeier","id":1208119,"avatar_url":"https://avatars.githubusercontent.com/u/1208119?v=3","gravatar_id":"","url":"https://api.github.com/users/LorenzMeier","html_url":"https://github.com/LorenzMeier","followers_url":"https://api.github.com/users/LorenzMeier/followers","following_url":"https://api.github.com/users/LorenzMeier/following{/other_user}","gists_url":"https://api.github.com/users/LorenzMeier/gists{/gist_id}","starred_url":"https://api.github.com/users/LorenzMeier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LorenzMeier/subscriptions","organizations_url":"https://api.github.com/users/LorenzMeier/orgs","repos_url":"https://api.github.com/users/LorenzMeier/repos","events_url":"https://api.github.com/users/LorenzMeier/events{/privacy}","received_events_url":"https://api.github.com/users/LorenzMeier/received_events","type":"User","site_admin":false},"open_issues":54,"closed_issues":4,"state":"open","created_at":"2016-06-07T06:51:16Z","updated_at":"2016-12-03T10:17:56Z","due_on":"2017-02-15T00:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/PX4/Firmware/pulls/5863/commits","review_comments_url":"https://api.github.com/repos/PX4/Firmware/pulls/5863/comments","review_comment_url":"https://api.github.com/repos/PX4/Firmware/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PX4/Firmware/issues/5863/comments","statuses_url":"https://api.github.com/repos/PX4/Firmware/statuses/803acc57fc0e9ab6ea9037f9d798281b1dc20004","head":{"label":"anton-matosov:feature/MC-Failsafe-part1","ref":"feature/MC-Failsafe-part1","sha":"803acc57fc0e9ab6ea9037f9d798281b1dc20004","user":{"login":"anton-matosov","id":3339485,"avatar_url":"https://avatars.githubusercontent.com/u/3339485?v=3","gravatar_id":"","url":"https://api.github.com/users/anton-matosov","html_url":"https://github.com/anton-matosov","followers_url":"https://api.github.com/users/anton-matosov/followers","following_url":"https://api.github.com/users/anton-matosov/following{/other_user}","gists_url":"https://api.github.com/users/anton-matosov/gists{/gist_id}","starred_url":"https://api.github.com/users/anton-matosov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anton-matosov/subscriptions","organizations_url":"https://api.github.com/users/anton-matosov/orgs","repos_url":"https://api.github.com/users/anton-matosov/repos","events_url":"https://api.github.com/users/anton-matosov/events{/privacy}","received_events_url":"https://api.github.com/users/anton-matosov/received_events","type":"User","site_admin":false},"repo":{"id":24786074,"name":"PX4Firmware","full_name":"anton-matosov/PX4Firmware","owner":{"login":"anton-matosov","id":3339485,"avatar_url":"https://avatars.githubusercontent.com/u/3339485?v=3","gravatar_id":"","url":"https://api.github.com/users/anton-matosov","html_url":"https://github.com/anton-matosov","followers_url":"https://api.github.com/users/anton-matosov/followers","following_url":"https://api.github.com/users/anton-matosov/following{/other_user}","gists_url":"https://api.github.com/users/anton-matosov/gists{/gist_id}","starred_url":"https://api.github.com/users/anton-matosov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anton-matosov/subscriptions","organizations_url":"https://api.github.com/users/anton-matosov/orgs","repos_url":"https://api.github.com/users/anton-matosov/repos","events_url":"https://api.github.com/users/anton-matosov/events{/privacy}","received_events_url":"https://api.github.com/users/anton-matosov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/anton-matosov/PX4Firmware","description":"PX4 Firmware for PX4FMU autopilot and PX4IO servo / failsafe board","fork":true,"url":"https://api.github.com/repos/anton-matosov/PX4Firmware","forks_url":"https://api.github.com/repos/anton-matosov/PX4Firmware/forks","keys_url":"https://api.github.com/repos/anton-matosov/PX4Firmware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/anton-matosov/PX4Firmware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/anton-matosov/PX4Firmware/teams","hooks_url":"https://api.github.com/repos/anton-matosov/PX4Firmware/hooks","issue_events_url":"https://api.github.com/repos/anton-matosov/PX4Firmware/issues/events{/number}","events_url":"https://api.github.com/repos/anton-matosov/PX4Firmware/events","assignees_url":"https://api.github.com/repos/anton-matosov/PX4Firmware/assignees{/user}","branches_url":"https://api.github.com/repos/anton-matosov/PX4Firmware/branches{/branch}","tags_url":"https://api.github.com/repos/anton-matosov/PX4Firmware/tags","blobs_url":"https://api.github.com/repos/anton-matosov/PX4Firmware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/anton-matosov/PX4Firmware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/anton-matosov/PX4Firmware/git/refs{/sha}","trees_url":"https://api.github.com/repos/anton-matosov/PX4Firmware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/anton-matosov/PX4Firmware/statuses/{sha}","languages_url":"https://api.github.com/repos/anton-matosov/PX4Firmware/languages","stargazers_url":"https://api.github.com/repos/anton-matosov/PX4Firmware/stargazers","contributors_url":"https://api.github.com/repos/anton-matosov/PX4Firmware/contributors","subscribers_url":"https://api.github.com/repos/anton-matosov/PX4Firmware/subscribers","subscription_url":"https://api.github.com/repos/anton-matosov/PX4Firmware/subscription","commits_url":"https://api.github.com/repos/anton-matosov/PX4Firmware/commits{/sha}","git_commits_url":"https://api.github.com/repos/anton-matosov/PX4Firmware/git/commits{/sha}","comments_url":"https://api.github.com/repos/anton-matosov/PX4Firmware/comments{/number}","issue_comment_url":"https://api.github.com/repos/anton-matosov/PX4Firmware/issues/comments{/number}","contents_url":"https://api.github.com/repos/anton-matosov/PX4Firmware/contents/{+path}","compare_url":"https://api.github.com/repos/anton-matosov/PX4Firmware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/anton-matosov/PX4Firmware/merges","archive_url":"https://api.github.com/repos/anton-matosov/PX4Firmware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/anton-matosov/PX4Firmware/downloads","issues_url":"https://api.github.com/repos/anton-matosov/PX4Firmware/issues{/number}","pulls_url":"https://api.github.com/repos/anton-matosov/PX4Firmware/pulls{/number}","milestones_url":"https://api.github.com/repos/anton-matosov/PX4Firmware/milestones{/number}","notifications_url":"https://api.github.com/repos/anton-matosov/PX4Firmware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/anton-matosov/PX4Firmware/labels{/name}","releases_url":"https://api.github.com/repos/anton-matosov/PX4Firmware/releases{/id}","deployments_url":"https://api.github.com/repos/anton-matosov/PX4Firmware/deployments","created_at":"2014-10-04T09:33:40Z","updated_at":"2015-03-15T23:54:06Z","pushed_at":"2016-12-03T10:23:39Z","git_url":"git://github.com/anton-matosov/PX4Firmware.git","ssh_url":"git@github.com:anton-matosov/PX4Firmware.git","clone_url":"https://github.com/anton-matosov/PX4Firmware.git","svn_url":"https://github.com/anton-matosov/PX4Firmware","homepage":"https://pixhawk.ethz.ch/px4/","size":83379,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PX4:master","ref":"master","sha":"64657900de1b306c509aeeb704ef897a00aa4183","user":{"login":"PX4","id":2096014,"avatar_url":"https://avatars.githubusercontent.com/u/2096014?v=3","gravatar_id":"","url":"https://api.github.com/users/PX4","html_url":"https://github.com/PX4","followers_url":"https://api.github.com/users/PX4/followers","following_url":"https://api.github.com/users/PX4/following{/other_user}","gists_url":"https://api.github.com/users/PX4/gists{/gist_id}","starred_url":"https://api.github.com/users/PX4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PX4/subscriptions","organizations_url":"https://api.github.com/users/PX4/orgs","repos_url":"https://api.github.com/users/PX4/repos","events_url":"https://api.github.com/users/PX4/events{/privacy}","received_events_url":"https://api.github.com/users/PX4/received_events","type":"Organization","site_admin":false},"repo":{"id":5298790,"name":"Firmware","full_name":"PX4/Firmware","owner":{"login":"PX4","id":2096014,"avatar_url":"https://avatars.githubusercontent.com/u/2096014?v=3","gravatar_id":"","url":"https://api.github.com/users/PX4","html_url":"https://github.com/PX4","followers_url":"https://api.github.com/users/PX4/followers","following_url":"https://api.github.com/users/PX4/following{/other_user}","gists_url":"https://api.github.com/users/PX4/gists{/gist_id}","starred_url":"https://api.github.com/users/PX4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PX4/subscriptions","organizations_url":"https://api.github.com/users/PX4/orgs","repos_url":"https://api.github.com/users/PX4/repos","events_url":"https://api.github.com/users/PX4/events{/privacy}","received_events_url":"https://api.github.com/users/PX4/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PX4/Firmware","description":"PX4 Pro Autopilot Software","fork":false,"url":"https://api.github.com/repos/PX4/Firmware","forks_url":"https://api.github.com/repos/PX4/Firmware/forks","keys_url":"https://api.github.com/repos/PX4/Firmware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PX4/Firmware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PX4/Firmware/teams","hooks_url":"https://api.github.com/repos/PX4/Firmware/hooks","issue_events_url":"https://api.github.com/repos/PX4/Firmware/issues/events{/number}","events_url":"https://api.github.com/repos/PX4/Firmware/events","assignees_url":"https://api.github.com/repos/PX4/Firmware/assignees{/user}","branches_url":"https://api.github.com/repos/PX4/Firmware/branches{/branch}","tags_url":"https://api.github.com/repos/PX4/Firmware/tags","blobs_url":"https://api.github.com/repos/PX4/Firmware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PX4/Firmware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PX4/Firmware/git/refs{/sha}","trees_url":"https://api.github.com/repos/PX4/Firmware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PX4/Firmware/statuses/{sha}","languages_url":"https://api.github.com/repos/PX4/Firmware/languages","stargazers_url":"https://api.github.com/repos/PX4/Firmware/stargazers","contributors_url":"https://api.github.com/repos/PX4/Firmware/contributors","subscribers_url":"https://api.github.com/repos/PX4/Firmware/subscribers","subscription_url":"https://api.github.com/repos/PX4/Firmware/subscription","commits_url":"https://api.github.com/repos/PX4/Firmware/commits{/sha}","git_commits_url":"https://api.github.com/repos/PX4/Firmware/git/commits{/sha}","comments_url":"https://api.github.com/repos/PX4/Firmware/comments{/number}","issue_comment_url":"https://api.github.com/repos/PX4/Firmware/issues/comments{/number}","contents_url":"https://api.github.com/repos/PX4/Firmware/contents/{+path}","compare_url":"https://api.github.com/repos/PX4/Firmware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PX4/Firmware/merges","archive_url":"https://api.github.com/repos/PX4/Firmware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PX4/Firmware/downloads","issues_url":"https://api.github.com/repos/PX4/Firmware/issues{/number}","pulls_url":"https://api.github.com/repos/PX4/Firmware/pulls{/number}","milestones_url":"https://api.github.com/repos/PX4/Firmware/milestones{/number}","notifications_url":"https://api.github.com/repos/PX4/Firmware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PX4/Firmware/labels{/name}","releases_url":"https://api.github.com/repos/PX4/Firmware/releases{/id}","deployments_url":"https://api.github.com/repos/PX4/Firmware/deployments","created_at":"2012-08-04T21:19:36Z","updated_at":"2016-12-03T04:44:41Z","pushed_at":"2016-12-03T10:23:40Z","git_url":"git://github.com/PX4/Firmware.git","ssh_url":"git@github.com:PX4/Firmware.git","clone_url":"https://github.com/PX4/Firmware.git","svn_url":"https://github.com/PX4/Firmware","homepage":"http://px4.io","size":219655,"stargazers_count":835,"watchers_count":835,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2842,"mirror_url":null,"open_issues_count":430,"forks":2842,"open_issues":430,"watchers":835,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PX4/Firmware/pulls/5863"},"html":{"href":"https://github.com/PX4/Firmware/pull/5863"},"issue":{"href":"https://api.github.com/repos/PX4/Firmware/issues/5863"},"comments":{"href":"https://api.github.com/repos/PX4/Firmware/issues/5863/comments"},"review_comments":{"href":"https://api.github.com/repos/PX4/Firmware/pulls/5863/comments"},"review_comment":{"href":"https://api.github.com/repos/PX4/Firmware/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PX4/Firmware/pulls/5863/commits"},"statuses":{"href":"https://api.github.com/repos/PX4/Firmware/statuses/803acc57fc0e9ab6ea9037f9d798281b1dc20004"}}}}
{"actor":{"display_login":"julianoes"}}