{"action":"created","issue":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/6848","repository_url":"https://api.github.com/repos/scikit-learn/scikit-learn","labels_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/6848/labels{/name}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/6848/comments","events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/6848/events","html_url":"https://github.com/scikit-learn/scikit-learn/issues/6848","id":157955030,"number":6848,"title":"LDA predict probability bug","user":{"login":"agamemnonc","id":7148165,"avatar_url":"https://avatars.githubusercontent.com/u/7148165?v=3","gravatar_id":"","url":"https://api.github.com/users/agamemnonc","html_url":"https://github.com/agamemnonc","followers_url":"https://api.github.com/users/agamemnonc/followers","following_url":"https://api.github.com/users/agamemnonc/following{/other_user}","gists_url":"https://api.github.com/users/agamemnonc/gists{/gist_id}","starred_url":"https://api.github.com/users/agamemnonc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agamemnonc/subscriptions","organizations_url":"https://api.github.com/users/agamemnonc/orgs","repos_url":"https://api.github.com/users/agamemnonc/repos","events_url":"https://api.github.com/users/agamemnonc/events{/privacy}","received_events_url":"https://api.github.com/users/agamemnonc/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/labels/Bug","name":"Bug","color":"e10c02"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/milestones/18","html_url":"https://github.com/scikit-learn/scikit-learn/milestones/0.18","labels_url":"https://api.github.com/repos/scikit-learn/scikit-learn/milestones/18/labels","id":1314892,"number":18,"title":"0.18","description":"","creator":{"login":"amueller","id":449558,"avatar_url":"https://avatars.githubusercontent.com/u/449558?v=3","gravatar_id":"","url":"https://api.github.com/users/amueller","html_url":"https://github.com/amueller","followers_url":"https://api.github.com/users/amueller/followers","following_url":"https://api.github.com/users/amueller/following{/other_user}","gists_url":"https://api.github.com/users/amueller/gists{/gist_id}","starred_url":"https://api.github.com/users/amueller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amueller/subscriptions","organizations_url":"https://api.github.com/users/amueller/orgs","repos_url":"https://api.github.com/users/amueller/repos","events_url":"https://api.github.com/users/amueller/events{/privacy}","received_events_url":"https://api.github.com/users/amueller/received_events","type":"User","site_admin":false},"open_issues":43,"closed_issues":16,"state":"open","created_at":"2015-09-20T02:17:00Z","updated_at":"2016-07-17T20:48:28Z","due_on":"2016-02-29T08:00:00Z","closed_at":null},"comments":3,"created_at":"2016-06-01T16:48:08Z","updated_at":"2016-07-18T22:39:16Z","closed_at":null,"body":"I am pretty confident there is a bug introduced in commit\r\n7c1101d7c26ba0b77184cce9c0b9be79adb526de\r\n\r\nConcretely, line 518 of the current version \r\nhttps://github.com/scikit-learn/scikit-learn/blob/master/sklearn/discriminant_analysis.py\r\nshould be removed as it yields wrong results. \r\n\r\nThere is no reason why constant 1 should be added to the computed probability after exponentiation and before inversion. \r\n\r\nTo verify this, I have run a one-to-one comparison between the outcome of the method and MATLAB's builtin LDA classifier on the Iris dataset. Only after removal of line 518, results match (up to a tolerance).\r\n\r\nIf everyone agrees on that, I am happy to submit a PR."},"comment":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/comments/233480544","html_url":"https://github.com/scikit-learn/scikit-learn/issues/6848#issuecomment-233480544","issue_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/6848","id":233480544,"user":{"login":"cristinacaputo","id":7228080,"avatar_url":"https://avatars.githubusercontent.com/u/7228080?v=3","gravatar_id":"","url":"https://api.github.com/users/cristinacaputo","html_url":"https://github.com/cristinacaputo","followers_url":"https://api.github.com/users/cristinacaputo/followers","following_url":"https://api.github.com/users/cristinacaputo/following{/other_user}","gists_url":"https://api.github.com/users/cristinacaputo/gists{/gist_id}","starred_url":"https://api.github.com/users/cristinacaputo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cristinacaputo/subscriptions","organizations_url":"https://api.github.com/users/cristinacaputo/orgs","repos_url":"https://api.github.com/users/cristinacaputo/repos","events_url":"https://api.github.com/users/cristinacaputo/events{/privacy}","received_events_url":"https://api.github.com/users/cristinacaputo/received_events","type":"User","site_admin":false},"created_at":"2016-07-18T22:39:16Z","updated_at":"2016-07-18T22:39:16Z","body":"Great. I appreciate your info. This is very helpful. Can you send me your output for a couple of more values? In particular, 23 and 101? Thanks a lot. "}}
{"actor":{"display_login":"cristinacaputo"}}