{"action":"created","issue":{"url":"https://api.github.com/repos/docker/docker/issues/27473","repository_url":"https://api.github.com/repos/docker/docker","labels_url":"https://api.github.com/repos/docker/docker/issues/27473/labels{/name}","comments_url":"https://api.github.com/repos/docker/docker/issues/27473/comments","events_url":"https://api.github.com/repos/docker/docker/issues/27473/events","html_url":"https://github.com/docker/docker/pull/27473","id":183575075,"number":27473,"title":"Bugfix systemd docker daemon conflicting with daemon.json","user":{"login":"samrocketman","id":875669,"avatar_url":"https://avatars.githubusercontent.com/u/875669?v=3","gravatar_id":"","url":"https://api.github.com/users/samrocketman","html_url":"https://github.com/samrocketman","followers_url":"https://api.github.com/users/samrocketman/followers","following_url":"https://api.github.com/users/samrocketman/following{/other_user}","gists_url":"https://api.github.com/users/samrocketman/gists{/gist_id}","starred_url":"https://api.github.com/users/samrocketman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samrocketman/subscriptions","organizations_url":"https://api.github.com/users/samrocketman/orgs","repos_url":"https://api.github.com/users/samrocketman/repos","events_url":"https://api.github.com/users/samrocketman/events{/privacy}","received_events_url":"https://api.github.com/users/samrocketman/received_events","type":"User","site_admin":false},"labels":[{"id":175374554,"url":"https://api.github.com/repos/docker/docker/labels/status/0-triage","name":"status/0-triage","color":"EEEEEE","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2016-10-18T02:29:10Z","updated_at":"2016-11-03T23:54:37Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/27473","html_url":"https://github.com/docker/docker/pull/27473","diff_url":"https://github.com/docker/docker/pull/27473.diff","patch_url":"https://github.com/docker/docker/pull/27473.patch"},"body":"<!--\nPlease make sure you've read and understood our contributing guidelines;\nhttps://github.com/docker/docker/blob/master/CONTRIBUTING.md\n\n** Make sure all your commits include a signature generated with `git commit -s` **\n\nFor additional information on our contributing process, read our contributing\nguide https://docs.docker.com/opensource/code/\n\nIf this is a bug fix, make sure your description includes \"fixes #xxxx\", or\n\"closes #xxxx\"\n\nPlease provide the following information:\n-->\n\n**\\- What I did**\n\nOn Ubuntu package:\n\n```\n# apt-cache show docker.io\nPackage: docker.io\nPriority: optional\nSection: universe/admin\nInstalled-Size: 54232\nMaintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>\nOriginal-Maintainer: Paul Tagliamonte <paultag@debian.org>\nArchitecture: amd64\nVersion: 1.12.1-0ubuntu13~16.04.1\nReplaces: docker (<< 1.5~)\nDepends: adduser, containerd (>= 0.2.3~), iptables, runc (>= 1.0.0~rc1~), init-system-helpers (>= 1.18~), lsb-base (>= 4.1+Debian11ubuntu7), libapparmor1 (>= 2.6~devel), libc6 (>= 2.14), libdevmapper1.02.1 (>= 2:1.02.97)\nRecommends: ca-certificates, cgroupfs-mount | cgroup-lite, git, ubuntu-fan, xz-utils, apparmor\nSuggests: aufs-tools, btrfs-tools, debootstrap, docker-doc, rinse, zfs-fuse | zfsutils\nBreaks: docker (<< 1.5~)\nFilename: pool/universe/d/docker.io/docker.io_1.12.1-0ubuntu13~16.04.1_amd64.deb\nSize: 10581186\nMD5sum: 08676d065c43fc6bcb450cf52c782ed5\nSHA1: 8f51b8c7b0fbc3eb879e13a76286cbe13b096d34\nSHA256: 0987a665d090d90b0096fbdcab7d18316cad6a1754dbc70f56ab74c36ba53c51\n...\n```\n\nI created `/etc/default/daemon.json` with the contents.\n\n``` json\n{\n    \"hosts\": [\"tcp://127.0.0.1:2700\"],\n    \"tlsverify\": true,\n    \"tlscacert\": \"/etc/docker/ca.pem\",\n    \"tlscert\": \"/etc/docker/cert.pem\",\n    \"tlskey\": \"/etc/docker/key.pem\"\n}\n```\n\nStarting the docker daemon (`systemctl start docker.service`) causes the error\n\n> unable to configure the Docker daemon with file\n> /etc/docker/daemon.json: the following directives are specified both as\n> a flag and in the configuration file: hosts: (from flag: [fd://], from\n> file: [tcp://127.0.0.1:2700])\n\n**\\- How I did it**\n\nPatch the `docker.service` and the error goes away.\n\n**\\- How to verify it**\n1. Install the above mentioned `docker.io` package in Ubuntu 16.04.\n2. Patch `/lib/systemd/system/docker.service` with the changes in this PR.\n3. Restart the daemon and it should succeed.\n4. Configure the hosts field of `/etc/docker/daemon.json`.  Restart and watch restart success.\n\n**\\- Description for the changelog**\n\n> systemd: fix conflicting hosts option between docker.service and daemon.json\n\n![cute cat](https://s-media-cache-ak0.pinimg.com/originals/c2/9e/8b/c29e8ba60e752a81cc9e82265f97c66a.jpg)\n\nfixes #22339\n"},"comment":{"url":"https://api.github.com/repos/docker/docker/issues/comments/258308914","html_url":"https://github.com/docker/docker/pull/27473#issuecomment-258308914","issue_url":"https://api.github.com/repos/docker/docker/issues/27473","id":258308914,"user":{"login":"thaJeztah","id":1804568,"avatar_url":"https://avatars.githubusercontent.com/u/1804568?v=3","gravatar_id":"","url":"https://api.github.com/users/thaJeztah","html_url":"https://github.com/thaJeztah","followers_url":"https://api.github.com/users/thaJeztah/followers","following_url":"https://api.github.com/users/thaJeztah/following{/other_user}","gists_url":"https://api.github.com/users/thaJeztah/gists{/gist_id}","starred_url":"https://api.github.com/users/thaJeztah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thaJeztah/subscriptions","organizations_url":"https://api.github.com/users/thaJeztah/orgs","repos_url":"https://api.github.com/users/thaJeztah/repos","events_url":"https://api.github.com/users/thaJeztah/events{/privacy}","received_events_url":"https://api.github.com/users/thaJeztah/received_events","type":"User","site_admin":false},"created_at":"2016-11-03T23:54:36Z","updated_at":"2016-11-03T23:54:36Z","body":"@LK4D4 this is about removing socket activation from all systemd unit files, but there was no consensus yet if that's a good thing to do\r\n\r\nping @tonistiigi "}}
{"actor":{"display_login":"thaJeztah"}}