{"action":"created","comment":{"url":"https://api.github.com/repos/guardian/identity-admin/pulls/comments/50686414","id":50686414,"diff_hunk":"@@ -0,0 +1,44 @@\n+package services\n+\n+import auth.GroupsValidationFailed\n+import com.gu.googleauth.UserIdentity\n+import model.AdminIdentity\n+import org.scalatest.{ParallelTestExecution, Matchers, FlatSpec}\n+import org.scalatest.concurrent.{AsyncAssertions, ScalaFutures}\n+\n+import scala.concurrent.Future\n+import scalaz.{-\\/, \\/-}\n+\n+import scala.concurrent.ExecutionContext.Implicits.global\n+\n+class GoogleGroups$Test extends FlatSpec with Matchers with ScalaFutures with ParallelTestExecution with AsyncAssertions {\n+\n+  val identity = UserIdentity(\"sub\",\"test.com\",\"firstName\",\"lastName\",1234,None)\n+  val adminIdentity = AdminIdentity(identity)\n+  val requiredGroups = Set(\"validGroup\")\n+\n+  behavior of \"GoogleGroups$Test\"","path":"test/services/GoogleGroups$Test.scala","position":20,"original_position":20,"commit_id":"5ef3fc8247c7e3aedb4c03e25063864837e41d83","original_commit_id":"5ef3fc8247c7e3aedb4c03e25063864837e41d83","user":{"login":"danmassie","id":1684649,"avatar_url":"https://avatars.githubusercontent.com/u/1684649?v=3","gravatar_id":"","url":"https://api.github.com/users/danmassie","html_url":"https://github.com/danmassie","followers_url":"https://api.github.com/users/danmassie/followers","following_url":"https://api.github.com/users/danmassie/following{/other_user}","gists_url":"https://api.github.com/users/danmassie/gists{/gist_id}","starred_url":"https://api.github.com/users/danmassie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danmassie/subscriptions","organizations_url":"https://api.github.com/users/danmassie/orgs","repos_url":"https://api.github.com/users/danmassie/repos","events_url":"https://api.github.com/users/danmassie/events{/privacy}","received_events_url":"https://api.github.com/users/danmassie/received_events","type":"User","site_admin":false},"body":"$ in name again","created_at":"2016-01-25T12:14:27Z","updated_at":"2016-01-25T12:14:27Z","html_url":"https://github.com/guardian/identity-admin/pull/124#discussion_r50686414","pull_request_url":"https://api.github.com/repos/guardian/identity-admin/pulls/124","_links":{"self":{"href":"https://api.github.com/repos/guardian/identity-admin/pulls/comments/50686414"},"html":{"href":"https://github.com/guardian/identity-admin/pull/124#discussion_r50686414"},"pull_request":{"href":"https://api.github.com/repos/guardian/identity-admin/pulls/124"}}},"pull_request":{"url":"https://api.github.com/repos/guardian/identity-admin/pulls/124","id":55614750,"html_url":"https://github.com/guardian/identity-admin/pull/124","diff_url":"https://github.com/guardian/identity-admin/pull/124.diff","patch_url":"https://github.com/guardian/identity-admin/pull/124.patch","issue_url":"https://api.github.com/repos/guardian/identity-admin/issues/124","number":124,"state":"open","locked":false,"title":"Add hd check","user":{"login":"emma-p","id":2373681,"avatar_url":"https://avatars.githubusercontent.com/u/2373681?v=3","gravatar_id":"","url":"https://api.github.com/users/emma-p","html_url":"https://github.com/emma-p","followers_url":"https://api.github.com/users/emma-p/followers","following_url":"https://api.github.com/users/emma-p/following{/other_user}","gists_url":"https://api.github.com/users/emma-p/gists{/gist_id}","starred_url":"https://api.github.com/users/emma-p/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emma-p/subscriptions","organizations_url":"https://api.github.com/users/emma-p/orgs","repos_url":"https://api.github.com/users/emma-p/repos","events_url":"https://api.github.com/users/emma-p/events{/privacy}","received_events_url":"https://api.github.com/users/emma-p/received_events","type":"User","site_admin":false},"body":"- Validates that the returned user's email address matches the domain we are expecting (see https://developers.google.com/identity/protocols/OpenIDConnect?hl=en#hd-param)\r\n- Improve login controller and authentication services to make them more testable\r\n- Adds tests","created_at":"2016-01-11T12:08:39Z","updated_at":"2016-01-25T12:14:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"54a34c0ffac6c85afe8911cb82d9763bf6444595","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/guardian/identity-admin/pulls/124/commits","review_comments_url":"https://api.github.com/repos/guardian/identity-admin/pulls/124/comments","review_comment_url":"https://api.github.com/repos/guardian/identity-admin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/guardian/identity-admin/issues/124/comments","statuses_url":"https://api.github.com/repos/guardian/identity-admin/statuses/5ef3fc8247c7e3aedb4c03e25063864837e41d83","head":{"label":"guardian:add-hd-check","ref":"add-hd-check","sha":"5ef3fc8247c7e3aedb4c03e25063864837e41d83","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":42711981,"name":"identity-admin","full_name":"guardian/identity-admin","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/identity-admin","description":"","fork":false,"url":"https://api.github.com/repos/guardian/identity-admin","forks_url":"https://api.github.com/repos/guardian/identity-admin/forks","keys_url":"https://api.github.com/repos/guardian/identity-admin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/identity-admin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/identity-admin/teams","hooks_url":"https://api.github.com/repos/guardian/identity-admin/hooks","issue_events_url":"https://api.github.com/repos/guardian/identity-admin/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/identity-admin/events","assignees_url":"https://api.github.com/repos/guardian/identity-admin/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/identity-admin/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/identity-admin/tags","blobs_url":"https://api.github.com/repos/guardian/identity-admin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/identity-admin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/identity-admin/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/identity-admin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/identity-admin/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/identity-admin/languages","stargazers_url":"https://api.github.com/repos/guardian/identity-admin/stargazers","contributors_url":"https://api.github.com/repos/guardian/identity-admin/contributors","subscribers_url":"https://api.github.com/repos/guardian/identity-admin/subscribers","subscription_url":"https://api.github.com/repos/guardian/identity-admin/subscription","commits_url":"https://api.github.com/repos/guardian/identity-admin/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/identity-admin/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/identity-admin/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/identity-admin/issues/comments{/number}","contents_url":"https://api.github.com/repos/guardian/identity-admin/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/identity-admin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/identity-admin/merges","archive_url":"https://api.github.com/repos/guardian/identity-admin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/identity-admin/downloads","issues_url":"https://api.github.com/repos/guardian/identity-admin/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/identity-admin/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/identity-admin/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/identity-admin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/identity-admin/labels{/name}","releases_url":"https://api.github.com/repos/guardian/identity-admin/releases{/id}","deployments_url":"https://api.github.com/repos/guardian/identity-admin/deployments","created_at":"2015-09-18T09:23:08Z","updated_at":"2016-01-11T10:39:16Z","pushed_at":"2016-01-25T11:28:53Z","git_url":"git://github.com/guardian/identity-admin.git","ssh_url":"git@github.com:guardian/identity-admin.git","clone_url":"https://github.com/guardian/identity-admin.git","svn_url":"https://github.com/guardian/identity-admin","homepage":null,"size":1497,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"guardian:master","ref":"master","sha":"3add0a5ee5bd156960a6a8b86923dc901098fb91","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":42711981,"name":"identity-admin","full_name":"guardian/identity-admin","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/identity-admin","description":"","fork":false,"url":"https://api.github.com/repos/guardian/identity-admin","forks_url":"https://api.github.com/repos/guardian/identity-admin/forks","keys_url":"https://api.github.com/repos/guardian/identity-admin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/identity-admin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/identity-admin/teams","hooks_url":"https://api.github.com/repos/guardian/identity-admin/hooks","issue_events_url":"https://api.github.com/repos/guardian/identity-admin/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/identity-admin/events","assignees_url":"https://api.github.com/repos/guardian/identity-admin/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/identity-admin/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/identity-admin/tags","blobs_url":"https://api.github.com/repos/guardian/identity-admin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/identity-admin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/identity-admin/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/identity-admin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/identity-admin/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/identity-admin/languages","stargazers_url":"https://api.github.com/repos/guardian/identity-admin/stargazers","contributors_url":"https://api.github.com/repos/guardian/identity-admin/contributors","subscribers_url":"https://api.github.com/repos/guardian/identity-admin/subscribers","subscription_url":"https://api.github.com/repos/guardian/identity-admin/subscription","commits_url":"https://api.github.com/repos/guardian/identity-admin/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/identity-admin/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/identity-admin/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/identity-admin/issues/comments{/number}","contents_url":"https://api.github.com/repos/guardian/identity-admin/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/identity-admin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/identity-admin/merges","archive_url":"https://api.github.com/repos/guardian/identity-admin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/identity-admin/downloads","issues_url":"https://api.github.com/repos/guardian/identity-admin/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/identity-admin/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/identity-admin/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/identity-admin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/identity-admin/labels{/name}","releases_url":"https://api.github.com/repos/guardian/identity-admin/releases{/id}","deployments_url":"https://api.github.com/repos/guardian/identity-admin/deployments","created_at":"2015-09-18T09:23:08Z","updated_at":"2016-01-11T10:39:16Z","pushed_at":"2016-01-25T11:28:53Z","git_url":"git://github.com/guardian/identity-admin.git","ssh_url":"git@github.com:guardian/identity-admin.git","clone_url":"https://github.com/guardian/identity-admin.git","svn_url":"https://github.com/guardian/identity-admin","homepage":null,"size":1497,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/guardian/identity-admin/pulls/124"},"html":{"href":"https://github.com/guardian/identity-admin/pull/124"},"issue":{"href":"https://api.github.com/repos/guardian/identity-admin/issues/124"},"comments":{"href":"https://api.github.com/repos/guardian/identity-admin/issues/124/comments"},"review_comments":{"href":"https://api.github.com/repos/guardian/identity-admin/pulls/124/comments"},"review_comment":{"href":"https://api.github.com/repos/guardian/identity-admin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/guardian/identity-admin/pulls/124/commits"},"statuses":{"href":"https://api.github.com/repos/guardian/identity-admin/statuses/5ef3fc8247c7e3aedb4c03e25063864837e41d83"}}}}