{"action":"created","issue":{"url":"https://api.github.com/repos/mantidproject/mantid/issues/10270","repository_url":"https://api.github.com/repos/mantidproject/mantid","labels_url":"https://api.github.com/repos/mantidproject/mantid/issues/10270/labels{/name}","comments_url":"https://api.github.com/repos/mantidproject/mantid/issues/10270/comments","events_url":"https://api.github.com/repos/mantidproject/mantid/issues/10270/events","html_url":"https://github.com/mantidproject/mantid/issues/10270","id":84718972,"number":10270,"title":"In InstrumentDefinitionParser: use of atoi and boost::lexical_cast consistent","user":{"login":"Anders-Markvardsen","id":1135476,"avatar_url":"https://avatars.githubusercontent.com/u/1135476?v=3","gravatar_id":"","url":"https://api.github.com/users/Anders-Markvardsen","html_url":"https://github.com/Anders-Markvardsen","followers_url":"https://api.github.com/users/Anders-Markvardsen/followers","following_url":"https://api.github.com/users/Anders-Markvardsen/following{/other_user}","gists_url":"https://api.github.com/users/Anders-Markvardsen/gists{/gist_id}","starred_url":"https://api.github.com/users/Anders-Markvardsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Anders-Markvardsen/subscriptions","organizations_url":"https://api.github.com/users/Anders-Markvardsen/orgs","repos_url":"https://api.github.com/users/Anders-Markvardsen/repos","events_url":"https://api.github.com/users/Anders-Markvardsen/events{/privacy}","received_events_url":"https://api.github.com/users/Anders-Markvardsen/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/mantidproject/mantid/labels/Component:%20Framework","name":"Component: Framework","color":"009800"},{"url":"https://api.github.com/repos/mantidproject/mantid/labels/Misc:%20Archived","name":"Misc: Archived","color":"5319e7"},{"url":"https://api.github.com/repos/mantidproject/mantid/labels/Misc:%20Maintenance","name":"Misc: Maintenance","color":"d4c5f9"},{"url":"https://api.github.com/repos/mantidproject/mantid/labels/Priority:%20Low","name":"Priority: Low","color":"f7d0d0"}],"state":"closed","locked":false,"assignee":{"login":"FedeMPouzols","id":5257172,"avatar_url":"https://avatars.githubusercontent.com/u/5257172?v=3","gravatar_id":"","url":"https://api.github.com/users/FedeMPouzols","html_url":"https://github.com/FedeMPouzols","followers_url":"https://api.github.com/users/FedeMPouzols/followers","following_url":"https://api.github.com/users/FedeMPouzols/following{/other_user}","gists_url":"https://api.github.com/users/FedeMPouzols/gists{/gist_id}","starred_url":"https://api.github.com/users/FedeMPouzols/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FedeMPouzols/subscriptions","organizations_url":"https://api.github.com/users/FedeMPouzols/orgs","repos_url":"https://api.github.com/users/FedeMPouzols/repos","events_url":"https://api.github.com/users/FedeMPouzols/events{/privacy}","received_events_url":"https://api.github.com/users/FedeMPouzols/received_events","type":"User","site_admin":false},"milestone":null,"comments":2,"created_at":"2014-05-08T08:32:39Z","updated_at":"2016-02-16T09:27:38Z","closed_at":"2016-02-16T09:27:38Z","body":"This issue was originally [TRAC 9427](http://trac.mantidproject.org/mantid/ticket/9427)\n\n\nThis ticket is blocked by : \n - [X] [TRAC9406](http://trac.mantidproject.org/mantid/ticket/9406)\n\nOriginally atoi and atof used to convert string to int and double. \n\nAt recently boost::lexical_cast used, which is generally recommended over using atoi and atof, although as was found it http://trac.mantidproject.org/mantid/ticket/9406 boost::lexical_cast does not strip for spaces.\n\nThis ticket is proposed to translate all atoi and atof to boost::lexical_cast. \n\nIn doing this it has to be checked that the performance of loading IDF does not increase (or only increase very little). \n\nOne way of implementing this is to add a private method getStripedAttValue() which returns a string that can be passed to boost::lexical_cast\n\n\n - - - - \nKeywords: Maintenance\n "},"comment":{"url":"https://api.github.com/repos/mantidproject/mantid/issues/comments/184595115","html_url":"https://github.com/mantidproject/mantid/issues/10270#issuecomment-184595115","issue_url":"https://api.github.com/repos/mantidproject/mantid/issues/10270","id":184595115,"user":{"login":"FedeMPouzols","id":5257172,"avatar_url":"https://avatars.githubusercontent.com/u/5257172?v=3","gravatar_id":"","url":"https://api.github.com/users/FedeMPouzols","html_url":"https://github.com/FedeMPouzols","followers_url":"https://api.github.com/users/FedeMPouzols/followers","following_url":"https://api.github.com/users/FedeMPouzols/following{/other_user}","gists_url":"https://api.github.com/users/FedeMPouzols/gists{/gist_id}","starred_url":"https://api.github.com/users/FedeMPouzols/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FedeMPouzols/subscriptions","organizations_url":"https://api.github.com/users/FedeMPouzols/orgs","repos_url":"https://api.github.com/users/FedeMPouzols/repos","events_url":"https://api.github.com/users/FedeMPouzols/events{/privacy}","received_events_url":"https://api.github.com/users/FedeMPouzols/received_events","type":"User","site_admin":false},"created_at":"2016-02-16T09:27:38Z","updated_at":"2016-02-16T09:27:38Z","body":"Archiving this, as many tests turned out to be very sensitive to numerical differences between lexical_cast and atoi/atof.\r\nLow benefit given the amount of higher priority issues.\r\nNew geometry being planned which would deprecate this code.\r\n"}}