{"action":"created","comment":{"url":"https://api.github.com/repos/efficient/cuckoofilter/pulls/comments/91433109","pull_request_review_id":11941144,"id":91433109,"diff_hunk":"@@ -0,0 +1,20 @@\n+// Generating random data\n+\n+#pragma once\n+\n+#include <algorithm>\n+#include <cstdint>\n+#include <functional>\n+#include <random>\n+#include <vector>\n+\n+\n+::std::vector<::std::uint64_t> GenerateRandom64(::std::size_t count) {\n+  ::std::vector<::std::uint64_t> result(count);\n+  ::std::random_device random;\n+  auto genrand = [&random]() {\n+    return random() + (static_cast<::std::uint64_t>(random()) << 32);\n+  };","path":"benchmarks/random.h","position":17,"original_position":17,"commit_id":"bf6d295dc01d84f04a29a719876e70ee13ba4267","original_commit_id":"65aa12aab157efcd22c4638169010d595d6a8d25","user":{"login":"jbapple-cloudera","id":13907602,"avatar_url":"https://avatars.githubusercontent.com/u/13907602?v=3","gravatar_id":"","url":"https://api.github.com/users/jbapple-cloudera","html_url":"https://github.com/jbapple-cloudera","followers_url":"https://api.github.com/users/jbapple-cloudera/followers","following_url":"https://api.github.com/users/jbapple-cloudera/following{/other_user}","gists_url":"https://api.github.com/users/jbapple-cloudera/gists{/gist_id}","starred_url":"https://api.github.com/users/jbapple-cloudera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbapple-cloudera/subscriptions","organizations_url":"https://api.github.com/users/jbapple-cloudera/orgs","repos_url":"https://api.github.com/users/jbapple-cloudera/repos","events_url":"https://api.github.com/users/jbapple-cloudera/events{/privacy}","received_events_url":"https://api.github.com/users/jbapple-cloudera/received_events","type":"User","site_admin":false},"body":"It produces different results.\r\n\r\nFor the standard library implementation I have installed, default_random is a linear congruential generator; the comments call it \"The classic Minimum Standard rand0 of Lewis, Goodman, and Miller.\" That cuts the false positive rates in half. I believe this is due to my use of the multiply-shift hash function. For a similar example, see Patrascu and Thorup's \"The Power of Simple Tabulation Hashing\", Figure 2: https://people.csail.mit.edu/mip/papers/charhash/charhash.pdf. It shows that multiply shift behaves better on structured input with some seeds, and much worse with other seeds.","created_at":"2016-12-08T02:47:02Z","updated_at":"2016-12-08T02:47:02Z","html_url":"https://github.com/efficient/cuckoofilter/pull/8#discussion_r91433109","pull_request_url":"https://api.github.com/repos/efficient/cuckoofilter/pulls/8","_links":{"self":{"href":"https://api.github.com/repos/efficient/cuckoofilter/pulls/comments/91433109"},"html":{"href":"https://github.com/efficient/cuckoofilter/pull/8#discussion_r91433109"},"pull_request":{"href":"https://api.github.com/repos/efficient/cuckoofilter/pulls/8"}}},"pull_request":{"url":"https://api.github.com/repos/efficient/cuckoofilter/pulls/8","id":96411261,"html_url":"https://github.com/efficient/cuckoofilter/pull/8","diff_url":"https://github.com/efficient/cuckoofilter/pull/8.diff","patch_url":"https://github.com/efficient/cuckoofilter/pull/8.patch","issue_url":"https://api.github.com/repos/efficient/cuckoofilter/issues/8","number":8,"state":"open","locked":false,"title":"A start at reproducing the benchmarks from the CoNEXT'14 paper","user":{"login":"jbapple-cloudera","id":13907602,"avatar_url":"https://avatars.githubusercontent.com/u/13907602?v=3","gravatar_id":"","url":"https://api.github.com/users/jbapple-cloudera","html_url":"https://github.com/jbapple-cloudera","followers_url":"https://api.github.com/users/jbapple-cloudera/followers","following_url":"https://api.github.com/users/jbapple-cloudera/following{/other_user}","gists_url":"https://api.github.com/users/jbapple-cloudera/gists{/gist_id}","starred_url":"https://api.github.com/users/jbapple-cloudera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbapple-cloudera/subscriptions","organizations_url":"https://api.github.com/users/jbapple-cloudera/orgs","repos_url":"https://api.github.com/users/jbapple-cloudera/repos","events_url":"https://api.github.com/users/jbapple-cloudera/events{/privacy}","received_events_url":"https://api.github.com/users/jbapple-cloudera/received_events","type":"User","site_admin":false},"body":"The benchmarking code from \"Cuckoo Filter: Practically Better Than Bloom\", by Fan et al. was apparently lost years ago.\r\n\r\nThis PR reproduces some of the benchmarks. At this point it includes only benchmarks for the cuckoo filters, not ones for traditional Bloom filters, blocked Bloom filters, Quotient filters, and d-left counting Bloom filters, which were in the paper. The particular implementations of those other filters tested in the CoNEXT'14 paper are not in this repo.","created_at":"2016-12-03T21:26:00Z","updated_at":"2016-12-08T02:47:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"986911f90070b2617c652c0fab5c6aa9a383945a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/efficient/cuckoofilter/pulls/8/commits","review_comments_url":"https://api.github.com/repos/efficient/cuckoofilter/pulls/8/comments","review_comment_url":"https://api.github.com/repos/efficient/cuckoofilter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/efficient/cuckoofilter/issues/8/comments","statuses_url":"https://api.github.com/repos/efficient/cuckoofilter/statuses/bf6d295dc01d84f04a29a719876e70ee13ba4267","head":{"label":"jbapple-cloudera:benchmarks","ref":"benchmarks","sha":"bf6d295dc01d84f04a29a719876e70ee13ba4267","user":{"login":"jbapple-cloudera","id":13907602,"avatar_url":"https://avatars.githubusercontent.com/u/13907602?v=3","gravatar_id":"","url":"https://api.github.com/users/jbapple-cloudera","html_url":"https://github.com/jbapple-cloudera","followers_url":"https://api.github.com/users/jbapple-cloudera/followers","following_url":"https://api.github.com/users/jbapple-cloudera/following{/other_user}","gists_url":"https://api.github.com/users/jbapple-cloudera/gists{/gist_id}","starred_url":"https://api.github.com/users/jbapple-cloudera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbapple-cloudera/subscriptions","organizations_url":"https://api.github.com/users/jbapple-cloudera/orgs","repos_url":"https://api.github.com/users/jbapple-cloudera/repos","events_url":"https://api.github.com/users/jbapple-cloudera/events{/privacy}","received_events_url":"https://api.github.com/users/jbapple-cloudera/received_events","type":"User","site_admin":false},"repo":{"id":75495709,"name":"cuckoofilter","full_name":"jbapple-cloudera/cuckoofilter","owner":{"login":"jbapple-cloudera","id":13907602,"avatar_url":"https://avatars.githubusercontent.com/u/13907602?v=3","gravatar_id":"","url":"https://api.github.com/users/jbapple-cloudera","html_url":"https://github.com/jbapple-cloudera","followers_url":"https://api.github.com/users/jbapple-cloudera/followers","following_url":"https://api.github.com/users/jbapple-cloudera/following{/other_user}","gists_url":"https://api.github.com/users/jbapple-cloudera/gists{/gist_id}","starred_url":"https://api.github.com/users/jbapple-cloudera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbapple-cloudera/subscriptions","organizations_url":"https://api.github.com/users/jbapple-cloudera/orgs","repos_url":"https://api.github.com/users/jbapple-cloudera/repos","events_url":"https://api.github.com/users/jbapple-cloudera/events{/privacy}","received_events_url":"https://api.github.com/users/jbapple-cloudera/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jbapple-cloudera/cuckoofilter","description":null,"fork":true,"url":"https://api.github.com/repos/jbapple-cloudera/cuckoofilter","forks_url":"https://api.github.com/repos/jbapple-cloudera/cuckoofilter/forks","keys_url":"https://api.github.com/repos/jbapple-cloudera/cuckoofilter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jbapple-cloudera/cuckoofilter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jbapple-cloudera/cuckoofilter/teams","hooks_url":"https://api.github.com/repos/jbapple-cloudera/cuckoofilter/hooks","issue_events_url":"https://api.github.com/repos/jbapple-cloudera/cuckoofilter/issues/events{/number}","events_url":"https://api.github.com/repos/jbapple-cloudera/cuckoofilter/events","assignees_url":"https://api.github.com/repos/jbapple-cloudera/cuckoofilter/assignees{/user}","branches_url":"https://api.github.com/repos/jbapple-cloudera/cuckoofilter/branches{/branch}","tags_url":"https://api.github.com/repos/jbapple-cloudera/cuckoofilter/tags","blobs_url":"https://api.github.com/repos/jbapple-cloudera/cuckoofilter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jbapple-cloudera/cuckoofilter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jbapple-cloudera/cuckoofilter/git/refs{/sha}","trees_url":"https://api.github.com/repos/jbapple-cloudera/cuckoofilter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jbapple-cloudera/cuckoofilter/statuses/{sha}","languages_url":"https://api.github.com/repos/jbapple-cloudera/cuckoofilter/languages","stargazers_url":"https://api.github.com/repos/jbapple-cloudera/cuckoofilter/stargazers","contributors_url":"https://api.github.com/repos/jbapple-cloudera/cuckoofilter/contributors","subscribers_url":"https://api.github.com/repos/jbapple-cloudera/cuckoofilter/subscribers","subscription_url":"https://api.github.com/repos/jbapple-cloudera/cuckoofilter/subscription","commits_url":"https://api.github.com/repos/jbapple-cloudera/cuckoofilter/commits{/sha}","git_commits_url":"https://api.github.com/repos/jbapple-cloudera/cuckoofilter/git/commits{/sha}","comments_url":"https://api.github.com/repos/jbapple-cloudera/cuckoofilter/comments{/number}","issue_comment_url":"https://api.github.com/repos/jbapple-cloudera/cuckoofilter/issues/comments{/number}","contents_url":"https://api.github.com/repos/jbapple-cloudera/cuckoofilter/contents/{+path}","compare_url":"https://api.github.com/repos/jbapple-cloudera/cuckoofilter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jbapple-cloudera/cuckoofilter/merges","archive_url":"https://api.github.com/repos/jbapple-cloudera/cuckoofilter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jbapple-cloudera/cuckoofilter/downloads","issues_url":"https://api.github.com/repos/jbapple-cloudera/cuckoofilter/issues{/number}","pulls_url":"https://api.github.com/repos/jbapple-cloudera/cuckoofilter/pulls{/number}","milestones_url":"https://api.github.com/repos/jbapple-cloudera/cuckoofilter/milestones{/number}","notifications_url":"https://api.github.com/repos/jbapple-cloudera/cuckoofilter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jbapple-cloudera/cuckoofilter/labels{/name}","releases_url":"https://api.github.com/repos/jbapple-cloudera/cuckoofilter/releases{/id}","deployments_url":"https://api.github.com/repos/jbapple-cloudera/cuckoofilter/deployments","created_at":"2016-12-03T19:33:54Z","updated_at":"2016-12-03T19:33:55Z","pushed_at":"2016-12-06T23:57:08Z","git_url":"git://github.com/jbapple-cloudera/cuckoofilter.git","ssh_url":"git@github.com:jbapple-cloudera/cuckoofilter.git","clone_url":"https://github.com/jbapple-cloudera/cuckoofilter.git","svn_url":"https://github.com/jbapple-cloudera/cuckoofilter","homepage":null,"size":62,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"efficient:master","ref":"master","sha":"40fe2131338ac8a1334c27a08ab03ea4ba066d71","user":{"login":"efficient","id":1855015,"avatar_url":"https://avatars.githubusercontent.com/u/1855015?v=3","gravatar_id":"","url":"https://api.github.com/users/efficient","html_url":"https://github.com/efficient","followers_url":"https://api.github.com/users/efficient/followers","following_url":"https://api.github.com/users/efficient/following{/other_user}","gists_url":"https://api.github.com/users/efficient/gists{/gist_id}","starred_url":"https://api.github.com/users/efficient/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/efficient/subscriptions","organizations_url":"https://api.github.com/users/efficient/orgs","repos_url":"https://api.github.com/users/efficient/repos","events_url":"https://api.github.com/users/efficient/events{/privacy}","received_events_url":"https://api.github.com/users/efficient/received_events","type":"Organization","site_admin":false},"repo":{"id":10274721,"name":"cuckoofilter","full_name":"efficient/cuckoofilter","owner":{"login":"efficient","id":1855015,"avatar_url":"https://avatars.githubusercontent.com/u/1855015?v=3","gravatar_id":"","url":"https://api.github.com/users/efficient","html_url":"https://github.com/efficient","followers_url":"https://api.github.com/users/efficient/followers","following_url":"https://api.github.com/users/efficient/following{/other_user}","gists_url":"https://api.github.com/users/efficient/gists{/gist_id}","starred_url":"https://api.github.com/users/efficient/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/efficient/subscriptions","organizations_url":"https://api.github.com/users/efficient/orgs","repos_url":"https://api.github.com/users/efficient/repos","events_url":"https://api.github.com/users/efficient/events{/privacy}","received_events_url":"https://api.github.com/users/efficient/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/efficient/cuckoofilter","description":null,"fork":false,"url":"https://api.github.com/repos/efficient/cuckoofilter","forks_url":"https://api.github.com/repos/efficient/cuckoofilter/forks","keys_url":"https://api.github.com/repos/efficient/cuckoofilter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/efficient/cuckoofilter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/efficient/cuckoofilter/teams","hooks_url":"https://api.github.com/repos/efficient/cuckoofilter/hooks","issue_events_url":"https://api.github.com/repos/efficient/cuckoofilter/issues/events{/number}","events_url":"https://api.github.com/repos/efficient/cuckoofilter/events","assignees_url":"https://api.github.com/repos/efficient/cuckoofilter/assignees{/user}","branches_url":"https://api.github.com/repos/efficient/cuckoofilter/branches{/branch}","tags_url":"https://api.github.com/repos/efficient/cuckoofilter/tags","blobs_url":"https://api.github.com/repos/efficient/cuckoofilter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/efficient/cuckoofilter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/efficient/cuckoofilter/git/refs{/sha}","trees_url":"https://api.github.com/repos/efficient/cuckoofilter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/efficient/cuckoofilter/statuses/{sha}","languages_url":"https://api.github.com/repos/efficient/cuckoofilter/languages","stargazers_url":"https://api.github.com/repos/efficient/cuckoofilter/stargazers","contributors_url":"https://api.github.com/repos/efficient/cuckoofilter/contributors","subscribers_url":"https://api.github.com/repos/efficient/cuckoofilter/subscribers","subscription_url":"https://api.github.com/repos/efficient/cuckoofilter/subscription","commits_url":"https://api.github.com/repos/efficient/cuckoofilter/commits{/sha}","git_commits_url":"https://api.github.com/repos/efficient/cuckoofilter/git/commits{/sha}","comments_url":"https://api.github.com/repos/efficient/cuckoofilter/comments{/number}","issue_comment_url":"https://api.github.com/repos/efficient/cuckoofilter/issues/comments{/number}","contents_url":"https://api.github.com/repos/efficient/cuckoofilter/contents/{+path}","compare_url":"https://api.github.com/repos/efficient/cuckoofilter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/efficient/cuckoofilter/merges","archive_url":"https://api.github.com/repos/efficient/cuckoofilter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/efficient/cuckoofilter/downloads","issues_url":"https://api.github.com/repos/efficient/cuckoofilter/issues{/number}","pulls_url":"https://api.github.com/repos/efficient/cuckoofilter/pulls{/number}","milestones_url":"https://api.github.com/repos/efficient/cuckoofilter/milestones{/number}","notifications_url":"https://api.github.com/repos/efficient/cuckoofilter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/efficient/cuckoofilter/labels{/name}","releases_url":"https://api.github.com/repos/efficient/cuckoofilter/releases{/id}","deployments_url":"https://api.github.com/repos/efficient/cuckoofilter/deployments","created_at":"2013-05-24T20:44:58Z","updated_at":"2016-12-07T17:26:43Z","pushed_at":"2016-12-06T23:57:09Z","git_url":"git://github.com/efficient/cuckoofilter.git","ssh_url":"git@github.com:efficient/cuckoofilter.git","clone_url":"https://github.com/efficient/cuckoofilter.git","svn_url":"https://github.com/efficient/cuckoofilter","homepage":null,"size":58,"stargazers_count":339,"watchers_count":339,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":44,"mirror_url":null,"open_issues_count":5,"forks":44,"open_issues":5,"watchers":339,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/efficient/cuckoofilter/pulls/8"},"html":{"href":"https://github.com/efficient/cuckoofilter/pull/8"},"issue":{"href":"https://api.github.com/repos/efficient/cuckoofilter/issues/8"},"comments":{"href":"https://api.github.com/repos/efficient/cuckoofilter/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/efficient/cuckoofilter/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/efficient/cuckoofilter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/efficient/cuckoofilter/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/efficient/cuckoofilter/statuses/bf6d295dc01d84f04a29a719876e70ee13ba4267"}}}}
{"actor":{"display_login":"jbapple-cloudera"}}