{"action":"created","comment":{"url":"https://api.github.com/repos/voxpupuli/puppet-jira/pulls/comments/93741059","pull_request_review_id":14274662,"id":93741059,"diff_hunk":"@@ -0,0 +1,28 @@\n+#!/bin/sh\n+# This file is managed by Puppet\n+#\n+# This file should be identical to 'check-java.sh' in the Jira 7.0.4 standalone\n+# tarball, with 2 exceptions: 'grep \"java version\"' has been changed\n+# to 'grep \"version\"' in order to allow JIRA to run on OpenJDK, and the","path":"templates/check-java.sh.erb","position":6,"original_position":6,"commit_id":"f9be3156f5a5a269b027f3eae0037d3f16f6462a","original_commit_id":"f9be3156f5a5a269b027f3eae0037d3f16f6462a","user":{"login":"juniorsysadmin","id":6457128,"avatar_url":"https://avatars.githubusercontent.com/u/6457128?v=3","gravatar_id":"","url":"https://api.github.com/users/juniorsysadmin","html_url":"https://github.com/juniorsysadmin","followers_url":"https://api.github.com/users/juniorsysadmin/followers","following_url":"https://api.github.com/users/juniorsysadmin/following{/other_user}","gists_url":"https://api.github.com/users/juniorsysadmin/gists{/gist_id}","starred_url":"https://api.github.com/users/juniorsysadmin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juniorsysadmin/subscriptions","organizations_url":"https://api.github.com/users/juniorsysadmin/orgs","repos_url":"https://api.github.com/users/juniorsysadmin/repos","events_url":"https://api.github.com/users/juniorsysadmin/events{/privacy}","received_events_url":"https://api.github.com/users/juniorsysadmin/received_events","type":"User","site_admin":false},"body":"You might think of it as a bit a nitpick, but referring back to the earlier discussion I still think the grep command should be left exactly like the one in the tarball. That way:\r\n- You stick a modified version of the template with the modified grep command in say my_sites/templates/jira/check-java.sh.erb in your module directory (1)\r\n- You pass in an argument as a parameter to this module of ```script_check_java_template => 'my_sites/jira/check-java.sh.erb'```\r\n- Everyone else using this module by default gets the same file as the one that's in the upstream tarball\r\n- Anyone looking at this template sees that we're just taking what is upstream and not doing something which seems weird\r\n- Noone comes along and questions why there is a reference to OpenJDK in the code\r\n\r\nEverything else in the PR looks okay.\r\n\r\n(1) The my_sites directory in your module directory used to be the 'standard' folder name for the folder containing all of your modified templates. Not sure if there is a more catchy name for it now","created_at":"2016-12-23T08:43:31Z","updated_at":"2016-12-23T08:44:35Z","html_url":"https://github.com/voxpupuli/puppet-jira/pull/192#discussion_r93741059","pull_request_url":"https://api.github.com/repos/voxpupuli/puppet-jira/pulls/192","_links":{"self":{"href":"https://api.github.com/repos/voxpupuli/puppet-jira/pulls/comments/93741059"},"html":{"href":"https://github.com/voxpupuli/puppet-jira/pull/192#discussion_r93741059"},"pull_request":{"href":"https://api.github.com/repos/voxpupuli/puppet-jira/pulls/192"}}},"pull_request":{"url":"https://api.github.com/repos/voxpupuli/puppet-jira/pulls/192","id":96799621,"html_url":"https://github.com/voxpupuli/puppet-jira/pull/192","diff_url":"https://github.com/voxpupuli/puppet-jira/pull/192.diff","patch_url":"https://github.com/voxpupuli/puppet-jira/pull/192.patch","issue_url":"https://api.github.com/repos/voxpupuli/puppet-jira/issues/192","number":192,"state":"open","locked":false,"title":"Allow JIRA to run in OpenJDK","user":{"login":"bramwelt","id":324567,"avatar_url":"https://avatars.githubusercontent.com/u/324567?v=3","gravatar_id":"","url":"https://api.github.com/users/bramwelt","html_url":"https://github.com/bramwelt","followers_url":"https://api.github.com/users/bramwelt/followers","following_url":"https://api.github.com/users/bramwelt/following{/other_user}","gists_url":"https://api.github.com/users/bramwelt/gists{/gist_id}","starred_url":"https://api.github.com/users/bramwelt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bramwelt/subscriptions","organizations_url":"https://api.github.com/users/bramwelt/orgs","repos_url":"https://api.github.com/users/bramwelt/repos","events_url":"https://api.github.com/users/bramwelt/events{/privacy}","received_events_url":"https://api.github.com/users/bramwelt/received_events","type":"User","site_admin":false},"body":"The script which checks for Java assumes Oracle Java, and thus wrongly\r\nchecks the version string output to be prefixed with 'java' and not\r\n'openjdk'. This change removes the check for JIRA 7 and up.\r\n\r\nSigned-off-by: Trevor Bramwell <tbramwell@linuxfoundation.org>","created_at":"2016-12-06T20:36:54Z","updated_at":"2016-12-23T08:44:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"207693e2333acfa600abeee656b78f64f74b608d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/voxpupuli/puppet-jira/pulls/192/commits","review_comments_url":"https://api.github.com/repos/voxpupuli/puppet-jira/pulls/192/comments","review_comment_url":"https://api.github.com/repos/voxpupuli/puppet-jira/pulls/comments{/number}","comments_url":"https://api.github.com/repos/voxpupuli/puppet-jira/issues/192/comments","statuses_url":"https://api.github.com/repos/voxpupuli/puppet-jira/statuses/f9be3156f5a5a269b027f3eae0037d3f16f6462a","head":{"label":"bramwelt:openjdk-support","ref":"openjdk-support","sha":"f9be3156f5a5a269b027f3eae0037d3f16f6462a","user":{"login":"bramwelt","id":324567,"avatar_url":"https://avatars.githubusercontent.com/u/324567?v=3","gravatar_id":"","url":"https://api.github.com/users/bramwelt","html_url":"https://github.com/bramwelt","followers_url":"https://api.github.com/users/bramwelt/followers","following_url":"https://api.github.com/users/bramwelt/following{/other_user}","gists_url":"https://api.github.com/users/bramwelt/gists{/gist_id}","starred_url":"https://api.github.com/users/bramwelt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bramwelt/subscriptions","organizations_url":"https://api.github.com/users/bramwelt/orgs","repos_url":"https://api.github.com/users/bramwelt/repos","events_url":"https://api.github.com/users/bramwelt/events{/privacy}","received_events_url":"https://api.github.com/users/bramwelt/received_events","type":"User","site_admin":false},"repo":{"id":47708948,"name":"puppet-jira","full_name":"bramwelt/puppet-jira","owner":{"login":"bramwelt","id":324567,"avatar_url":"https://avatars.githubusercontent.com/u/324567?v=3","gravatar_id":"","url":"https://api.github.com/users/bramwelt","html_url":"https://github.com/bramwelt","followers_url":"https://api.github.com/users/bramwelt/followers","following_url":"https://api.github.com/users/bramwelt/following{/other_user}","gists_url":"https://api.github.com/users/bramwelt/gists{/gist_id}","starred_url":"https://api.github.com/users/bramwelt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bramwelt/subscriptions","organizations_url":"https://api.github.com/users/bramwelt/orgs","repos_url":"https://api.github.com/users/bramwelt/repos","events_url":"https://api.github.com/users/bramwelt/events{/privacy}","received_events_url":"https://api.github.com/users/bramwelt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bramwelt/puppet-jira","description":"Atlassian JIRA Puppet Module","fork":true,"url":"https://api.github.com/repos/bramwelt/puppet-jira","forks_url":"https://api.github.com/repos/bramwelt/puppet-jira/forks","keys_url":"https://api.github.com/repos/bramwelt/puppet-jira/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bramwelt/puppet-jira/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bramwelt/puppet-jira/teams","hooks_url":"https://api.github.com/repos/bramwelt/puppet-jira/hooks","issue_events_url":"https://api.github.com/repos/bramwelt/puppet-jira/issues/events{/number}","events_url":"https://api.github.com/repos/bramwelt/puppet-jira/events","assignees_url":"https://api.github.com/repos/bramwelt/puppet-jira/assignees{/user}","branches_url":"https://api.github.com/repos/bramwelt/puppet-jira/branches{/branch}","tags_url":"https://api.github.com/repos/bramwelt/puppet-jira/tags","blobs_url":"https://api.github.com/repos/bramwelt/puppet-jira/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bramwelt/puppet-jira/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bramwelt/puppet-jira/git/refs{/sha}","trees_url":"https://api.github.com/repos/bramwelt/puppet-jira/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bramwelt/puppet-jira/statuses/{sha}","languages_url":"https://api.github.com/repos/bramwelt/puppet-jira/languages","stargazers_url":"https://api.github.com/repos/bramwelt/puppet-jira/stargazers","contributors_url":"https://api.github.com/repos/bramwelt/puppet-jira/contributors","subscribers_url":"https://api.github.com/repos/bramwelt/puppet-jira/subscribers","subscription_url":"https://api.github.com/repos/bramwelt/puppet-jira/subscription","commits_url":"https://api.github.com/repos/bramwelt/puppet-jira/commits{/sha}","git_commits_url":"https://api.github.com/repos/bramwelt/puppet-jira/git/commits{/sha}","comments_url":"https://api.github.com/repos/bramwelt/puppet-jira/comments{/number}","issue_comment_url":"https://api.github.com/repos/bramwelt/puppet-jira/issues/comments{/number}","contents_url":"https://api.github.com/repos/bramwelt/puppet-jira/contents/{+path}","compare_url":"https://api.github.com/repos/bramwelt/puppet-jira/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bramwelt/puppet-jira/merges","archive_url":"https://api.github.com/repos/bramwelt/puppet-jira/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bramwelt/puppet-jira/downloads","issues_url":"https://api.github.com/repos/bramwelt/puppet-jira/issues{/number}","pulls_url":"https://api.github.com/repos/bramwelt/puppet-jira/pulls{/number}","milestones_url":"https://api.github.com/repos/bramwelt/puppet-jira/milestones{/number}","notifications_url":"https://api.github.com/repos/bramwelt/puppet-jira/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bramwelt/puppet-jira/labels{/name}","releases_url":"https://api.github.com/repos/bramwelt/puppet-jira/releases{/id}","deployments_url":"https://api.github.com/repos/bramwelt/puppet-jira/deployments","created_at":"2015-12-09T17:56:12Z","updated_at":"2016-12-06T19:21:57Z","pushed_at":"2016-12-21T20:08:52Z","git_url":"git://github.com/bramwelt/puppet-jira.git","ssh_url":"git@github.com:bramwelt/puppet-jira.git","clone_url":"https://github.com/bramwelt/puppet-jira.git","svn_url":"https://github.com/bramwelt/puppet-jira","homepage":null,"size":389,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"voxpupuli:master","ref":"master","sha":"902dfb5a2ade141074d75de14dc22af640904247","user":{"login":"voxpupuli","id":8693967,"avatar_url":"https://avatars.githubusercontent.com/u/8693967?v=3","gravatar_id":"","url":"https://api.github.com/users/voxpupuli","html_url":"https://github.com/voxpupuli","followers_url":"https://api.github.com/users/voxpupuli/followers","following_url":"https://api.github.com/users/voxpupuli/following{/other_user}","gists_url":"https://api.github.com/users/voxpupuli/gists{/gist_id}","starred_url":"https://api.github.com/users/voxpupuli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/voxpupuli/subscriptions","organizations_url":"https://api.github.com/users/voxpupuli/orgs","repos_url":"https://api.github.com/users/voxpupuli/repos","events_url":"https://api.github.com/users/voxpupuli/events{/privacy}","received_events_url":"https://api.github.com/users/voxpupuli/received_events","type":"Organization","site_admin":false},"repo":{"id":5254138,"name":"puppet-jira","full_name":"voxpupuli/puppet-jira","owner":{"login":"voxpupuli","id":8693967,"avatar_url":"https://avatars.githubusercontent.com/u/8693967?v=3","gravatar_id":"","url":"https://api.github.com/users/voxpupuli","html_url":"https://github.com/voxpupuli","followers_url":"https://api.github.com/users/voxpupuli/followers","following_url":"https://api.github.com/users/voxpupuli/following{/other_user}","gists_url":"https://api.github.com/users/voxpupuli/gists{/gist_id}","starred_url":"https://api.github.com/users/voxpupuli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/voxpupuli/subscriptions","organizations_url":"https://api.github.com/users/voxpupuli/orgs","repos_url":"https://api.github.com/users/voxpupuli/repos","events_url":"https://api.github.com/users/voxpupuli/events{/privacy}","received_events_url":"https://api.github.com/users/voxpupuli/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/voxpupuli/puppet-jira","description":"Atlassian JIRA Puppet Module","fork":false,"url":"https://api.github.com/repos/voxpupuli/puppet-jira","forks_url":"https://api.github.com/repos/voxpupuli/puppet-jira/forks","keys_url":"https://api.github.com/repos/voxpupuli/puppet-jira/keys{/key_id}","collaborators_url":"https://api.github.com/repos/voxpupuli/puppet-jira/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/voxpupuli/puppet-jira/teams","hooks_url":"https://api.github.com/repos/voxpupuli/puppet-jira/hooks","issue_events_url":"https://api.github.com/repos/voxpupuli/puppet-jira/issues/events{/number}","events_url":"https://api.github.com/repos/voxpupuli/puppet-jira/events","assignees_url":"https://api.github.com/repos/voxpupuli/puppet-jira/assignees{/user}","branches_url":"https://api.github.com/repos/voxpupuli/puppet-jira/branches{/branch}","tags_url":"https://api.github.com/repos/voxpupuli/puppet-jira/tags","blobs_url":"https://api.github.com/repos/voxpupuli/puppet-jira/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/voxpupuli/puppet-jira/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/voxpupuli/puppet-jira/git/refs{/sha}","trees_url":"https://api.github.com/repos/voxpupuli/puppet-jira/git/trees{/sha}","statuses_url":"https://api.github.com/repos/voxpupuli/puppet-jira/statuses/{sha}","languages_url":"https://api.github.com/repos/voxpupuli/puppet-jira/languages","stargazers_url":"https://api.github.com/repos/voxpupuli/puppet-jira/stargazers","contributors_url":"https://api.github.com/repos/voxpupuli/puppet-jira/contributors","subscribers_url":"https://api.github.com/repos/voxpupuli/puppet-jira/subscribers","subscription_url":"https://api.github.com/repos/voxpupuli/puppet-jira/subscription","commits_url":"https://api.github.com/repos/voxpupuli/puppet-jira/commits{/sha}","git_commits_url":"https://api.github.com/repos/voxpupuli/puppet-jira/git/commits{/sha}","comments_url":"https://api.github.com/repos/voxpupuli/puppet-jira/comments{/number}","issue_comment_url":"https://api.github.com/repos/voxpupuli/puppet-jira/issues/comments{/number}","contents_url":"https://api.github.com/repos/voxpupuli/puppet-jira/contents/{+path}","compare_url":"https://api.github.com/repos/voxpupuli/puppet-jira/compare/{base}...{head}","merges_url":"https://api.github.com/repos/voxpupuli/puppet-jira/merges","archive_url":"https://api.github.com/repos/voxpupuli/puppet-jira/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/voxpupuli/puppet-jira/downloads","issues_url":"https://api.github.com/repos/voxpupuli/puppet-jira/issues{/number}","pulls_url":"https://api.github.com/repos/voxpupuli/puppet-jira/pulls{/number}","milestones_url":"https://api.github.com/repos/voxpupuli/puppet-jira/milestones{/number}","notifications_url":"https://api.github.com/repos/voxpupuli/puppet-jira/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/voxpupuli/puppet-jira/labels{/name}","releases_url":"https://api.github.com/repos/voxpupuli/puppet-jira/releases{/id}","deployments_url":"https://api.github.com/repos/voxpupuli/puppet-jira/deployments","created_at":"2012-08-01T02:30:57Z","updated_at":"2016-12-03T12:32:38Z","pushed_at":"2016-12-21T20:08:54Z","git_url":"git://github.com/voxpupuli/puppet-jira.git","ssh_url":"git@github.com:voxpupuli/puppet-jira.git","clone_url":"https://github.com/voxpupuli/puppet-jira.git","svn_url":"https://github.com/voxpupuli/puppet-jira","homepage":null,"size":377,"stargazers_count":54,"watchers_count":54,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":94,"mirror_url":null,"open_issues_count":28,"forks":94,"open_issues":28,"watchers":54,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/voxpupuli/puppet-jira/pulls/192"},"html":{"href":"https://github.com/voxpupuli/puppet-jira/pull/192"},"issue":{"href":"https://api.github.com/repos/voxpupuli/puppet-jira/issues/192"},"comments":{"href":"https://api.github.com/repos/voxpupuli/puppet-jira/issues/192/comments"},"review_comments":{"href":"https://api.github.com/repos/voxpupuli/puppet-jira/pulls/192/comments"},"review_comment":{"href":"https://api.github.com/repos/voxpupuli/puppet-jira/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/voxpupuli/puppet-jira/pulls/192/commits"},"statuses":{"href":"https://api.github.com/repos/voxpupuli/puppet-jira/statuses/f9be3156f5a5a269b027f3eae0037d3f16f6462a"}}}}
{"actor":{"display_login":"juniorsysadmin"}}