{"push_id":1191283160,"size":1,"distinct_size":1,"ref":"refs/heads/swarm-secrets-by-default","head":"2283df06108bf1b128c79d24c4b9182346b761ec","before":"fed3ce3e1668a1b9ddab0d6f410e043e4f8ba1b1","commits":[{"sha":"2283df06108bf1b128c79d24c4b9182346b761ec","author":{"name":"Aaron Lehmann","email":"ab01047e91402f1a4542861b1076cf31bcc38777@docker.com"},"message":"Generate a swarm joining secret if none is specified\n\nThe current behavior of `docker swarm init` is to set up a swarm that\nhas no secret for joining, and does not require manual acceptance for\nworkers. Since workers may sometimes receive sensitive data such as pull\ncredentials, it makes sense to harden the defaults.\n\nThis change makes `docker swarm init` generate a random secret if none\nis provided, and print it to the terminal. This secret will be needed to\njoin workers or managers to the swarm. In addition to improving access\ncontrol to the cluster, this setup removes an avenue for\ndenial-of-service attacks, since the secret is necessary to even create\nan entry in the node list.\n\n`docker swarm init --secret \"\"` will set up a swarm without a secret,\nmatching the old behavior. `docker swarm update --secret \"\"` removes the\nautomatically generated secret after `docker swarm init`.\n\nCloses #23785\n\nSigned-off-by: Aaron Lehmann <aaron.lehmann@docker.com>","distinct":true,"url":"https://api.github.com/repos/aaronlehmann/docker/commits/2283df06108bf1b128c79d24c4b9182346b761ec"}]}
{"actor":{"display_login":"aaronlehmann"}}