{"action":"created","comment":{"url":"https://api.github.com/repos/contiv/netplugin/pulls/comments/50606728","id":50606728,"diff_hunk":"@@ -401,3 +402,14 @@ func dumpList(ctx *cli.Context, list []map[string]interface{}) {\n \tos.Stdout.Write(content)\n \tos.Stdout.WriteString(\"\\n\")\n }\n+\n+func showVersion(ctx *cli.Context) {","path":"netctl/netctl.go","position":13,"original_position":13,"commit_id":"08c489615e6c898edd1a5a7ef2f2507b4d021fc0","original_commit_id":"54cc6389435ae35500a9d7611f08da38a430b932","user":{"login":"jainvipin","id":9005681,"avatar_url":"https://avatars.githubusercontent.com/u/9005681?v=3","gravatar_id":"","url":"https://api.github.com/users/jainvipin","html_url":"https://github.com/jainvipin","followers_url":"https://api.github.com/users/jainvipin/followers","following_url":"https://api.github.com/users/jainvipin/following{/other_user}","gists_url":"https://api.github.com/users/jainvipin/gists{/gist_id}","starred_url":"https://api.github.com/users/jainvipin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jainvipin/subscriptions","organizations_url":"https://api.github.com/users/jainvipin/orgs","repos_url":"https://api.github.com/users/jainvipin/repos","events_url":"https://api.github.com/users/jainvipin/events{/privacy}","received_events_url":"https://api.github.com/users/jainvipin/received_events","type":"User","site_admin":false},"body":"@mapuri - no worries; appreciate your diligence...\r\n\r\n> Last question, what would we miss if for 0.1 release we were to let user issue netmaster --version command on the host where netmaster is running? Is it just the ease of issuing the command from any host?\r\n\r\nIt is the assurance to the user that even if he uses 0.1 version of netmaster/netctl, we can flag the mismatch regardless of the versions of binary used here. I am of course assuming that there is no guarantee that person has root access to the host where he could run `netmaster -version` to know this, rather the user only has REST access to the netmaster to manipulate/query it.\r\n\r\n","created_at":"2016-01-22T23:49:36Z","updated_at":"2016-01-22T23:49:36Z","html_url":"https://github.com/contiv/netplugin/pull/243#discussion_r50606728","pull_request_url":"https://api.github.com/repos/contiv/netplugin/pulls/243","_links":{"self":{"href":"https://api.github.com/repos/contiv/netplugin/pulls/comments/50606728"},"html":{"href":"https://github.com/contiv/netplugin/pull/243#discussion_r50606728"},"pull_request":{"href":"https://api.github.com/repos/contiv/netplugin/pulls/243"}}},"pull_request":{"url":"https://api.github.com/repos/contiv/netplugin/pulls/243","id":56558894,"html_url":"https://github.com/contiv/netplugin/pull/243","diff_url":"https://github.com/contiv/netplugin/pull/243.diff","patch_url":"https://github.com/contiv/netplugin/pull/243.patch","issue_url":"https://api.github.com/repos/contiv/netplugin/issues/243","number":243,"state":"open","locked":false,"title":"add versioning to netplugin binaries","user":{"login":"jainvipin","id":9005681,"avatar_url":"https://avatars.githubusercontent.com/u/9005681?v=3","gravatar_id":"","url":"https://api.github.com/users/jainvipin","html_url":"https://github.com/jainvipin","followers_url":"https://api.github.com/users/jainvipin/followers","following_url":"https://api.github.com/users/jainvipin/following{/other_user}","gists_url":"https://api.github.com/users/jainvipin/gists{/gist_id}","starred_url":"https://api.github.com/users/jainvipin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jainvipin/subscriptions","organizations_url":"https://api.github.com/users/jainvipin/orgs","repos_url":"https://api.github.com/users/jainvipin/repos","events_url":"https://api.github.com/users/jainvipin/events{/privacy}","received_events_url":"https://api.github.com/users/jainvipin/received_events","type":"User","site_admin":false},"body":"first cut changes; let's review, this...\r\n\r\nFew things to note:\r\n- I don't see much of a reason to do unit testing for two little functions in version/version.go - please tell me if I am off\r\n- The more important unit-test is really the one that tests the REST endpoint to netmaster fetching the version info. I will work on doing unit test after @shaleman is done with checking in changes for doing netmaster unit tests using rest apis \r\n- I omitted showing netplugin version in `netctl version`, then what if the netplugin versions are different on different hosts? Besides, `netplugin -version` command can show that on individual hosts.\r\n- `netplugin -version` shows some junk upfront, @unclejack has opened an issue for this, let's track it there.\r\n\r\n","created_at":"2016-01-20T03:11:35Z","updated_at":"2016-01-22T23:49:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aa79dc41a97deb44366c1307384db84a66f3a9c0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/contiv/netplugin/pulls/243/commits","review_comments_url":"https://api.github.com/repos/contiv/netplugin/pulls/243/comments","review_comment_url":"https://api.github.com/repos/contiv/netplugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/contiv/netplugin/issues/243/comments","statuses_url":"https://api.github.com/repos/contiv/netplugin/statuses/08c489615e6c898edd1a5a7ef2f2507b4d021fc0","head":{"label":"contiv:version","ref":"version","sha":"08c489615e6c898edd1a5a7ef2f2507b4d021fc0","user":{"login":"contiv","id":10272443,"avatar_url":"https://avatars.githubusercontent.com/u/10272443?v=3","gravatar_id":"","url":"https://api.github.com/users/contiv","html_url":"https://github.com/contiv","followers_url":"https://api.github.com/users/contiv/followers","following_url":"https://api.github.com/users/contiv/following{/other_user}","gists_url":"https://api.github.com/users/contiv/gists{/gist_id}","starred_url":"https://api.github.com/users/contiv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/contiv/subscriptions","organizations_url":"https://api.github.com/users/contiv/orgs","repos_url":"https://api.github.com/users/contiv/repos","events_url":"https://api.github.com/users/contiv/events{/privacy}","received_events_url":"https://api.github.com/users/contiv/received_events","type":"Organization","site_admin":false},"repo":{"id":28353322,"name":"netplugin","full_name":"contiv/netplugin","owner":{"login":"contiv","id":10272443,"avatar_url":"https://avatars.githubusercontent.com/u/10272443?v=3","gravatar_id":"","url":"https://api.github.com/users/contiv","html_url":"https://github.com/contiv","followers_url":"https://api.github.com/users/contiv/followers","following_url":"https://api.github.com/users/contiv/following{/other_user}","gists_url":"https://api.github.com/users/contiv/gists{/gist_id}","starred_url":"https://api.github.com/users/contiv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/contiv/subscriptions","organizations_url":"https://api.github.com/users/contiv/orgs","repos_url":"https://api.github.com/users/contiv/repos","events_url":"https://api.github.com/users/contiv/events{/privacy}","received_events_url":"https://api.github.com/users/contiv/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/contiv/netplugin","description":"Container networking for various use cases","fork":false,"url":"https://api.github.com/repos/contiv/netplugin","forks_url":"https://api.github.com/repos/contiv/netplugin/forks","keys_url":"https://api.github.com/repos/contiv/netplugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/contiv/netplugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/contiv/netplugin/teams","hooks_url":"https://api.github.com/repos/contiv/netplugin/hooks","issue_events_url":"https://api.github.com/repos/contiv/netplugin/issues/events{/number}","events_url":"https://api.github.com/repos/contiv/netplugin/events","assignees_url":"https://api.github.com/repos/contiv/netplugin/assignees{/user}","branches_url":"https://api.github.com/repos/contiv/netplugin/branches{/branch}","tags_url":"https://api.github.com/repos/contiv/netplugin/tags","blobs_url":"https://api.github.com/repos/contiv/netplugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/contiv/netplugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/contiv/netplugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/contiv/netplugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/contiv/netplugin/statuses/{sha}","languages_url":"https://api.github.com/repos/contiv/netplugin/languages","stargazers_url":"https://api.github.com/repos/contiv/netplugin/stargazers","contributors_url":"https://api.github.com/repos/contiv/netplugin/contributors","subscribers_url":"https://api.github.com/repos/contiv/netplugin/subscribers","subscription_url":"https://api.github.com/repos/contiv/netplugin/subscription","commits_url":"https://api.github.com/repos/contiv/netplugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/contiv/netplugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/contiv/netplugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/contiv/netplugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/contiv/netplugin/contents/{+path}","compare_url":"https://api.github.com/repos/contiv/netplugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/contiv/netplugin/merges","archive_url":"https://api.github.com/repos/contiv/netplugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/contiv/netplugin/downloads","issues_url":"https://api.github.com/repos/contiv/netplugin/issues{/number}","pulls_url":"https://api.github.com/repos/contiv/netplugin/pulls{/number}","milestones_url":"https://api.github.com/repos/contiv/netplugin/milestones{/number}","notifications_url":"https://api.github.com/repos/contiv/netplugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/contiv/netplugin/labels{/name}","releases_url":"https://api.github.com/repos/contiv/netplugin/releases{/id}","deployments_url":"https://api.github.com/repos/contiv/netplugin/deployments","created_at":"2014-12-22T18:45:21Z","updated_at":"2016-01-21T17:28:26Z","pushed_at":"2016-01-22T20:15:22Z","git_url":"git://github.com/contiv/netplugin.git","ssh_url":"git@github.com:contiv/netplugin.git","clone_url":"https://github.com/contiv/netplugin.git","svn_url":"https://github.com/contiv/netplugin","homepage":"","size":13533,"stargazers_count":57,"watchers_count":57,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":32,"mirror_url":null,"open_issues_count":46,"forks":32,"open_issues":46,"watchers":57,"default_branch":"master"}},"base":{"label":"contiv:master","ref":"master","sha":"dfaa2f913515279019511e051fef05c543f4a93c","user":{"login":"contiv","id":10272443,"avatar_url":"https://avatars.githubusercontent.com/u/10272443?v=3","gravatar_id":"","url":"https://api.github.com/users/contiv","html_url":"https://github.com/contiv","followers_url":"https://api.github.com/users/contiv/followers","following_url":"https://api.github.com/users/contiv/following{/other_user}","gists_url":"https://api.github.com/users/contiv/gists{/gist_id}","starred_url":"https://api.github.com/users/contiv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/contiv/subscriptions","organizations_url":"https://api.github.com/users/contiv/orgs","repos_url":"https://api.github.com/users/contiv/repos","events_url":"https://api.github.com/users/contiv/events{/privacy}","received_events_url":"https://api.github.com/users/contiv/received_events","type":"Organization","site_admin":false},"repo":{"id":28353322,"name":"netplugin","full_name":"contiv/netplugin","owner":{"login":"contiv","id":10272443,"avatar_url":"https://avatars.githubusercontent.com/u/10272443?v=3","gravatar_id":"","url":"https://api.github.com/users/contiv","html_url":"https://github.com/contiv","followers_url":"https://api.github.com/users/contiv/followers","following_url":"https://api.github.com/users/contiv/following{/other_user}","gists_url":"https://api.github.com/users/contiv/gists{/gist_id}","starred_url":"https://api.github.com/users/contiv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/contiv/subscriptions","organizations_url":"https://api.github.com/users/contiv/orgs","repos_url":"https://api.github.com/users/contiv/repos","events_url":"https://api.github.com/users/contiv/events{/privacy}","received_events_url":"https://api.github.com/users/contiv/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/contiv/netplugin","description":"Container networking for various use cases","fork":false,"url":"https://api.github.com/repos/contiv/netplugin","forks_url":"https://api.github.com/repos/contiv/netplugin/forks","keys_url":"https://api.github.com/repos/contiv/netplugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/contiv/netplugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/contiv/netplugin/teams","hooks_url":"https://api.github.com/repos/contiv/netplugin/hooks","issue_events_url":"https://api.github.com/repos/contiv/netplugin/issues/events{/number}","events_url":"https://api.github.com/repos/contiv/netplugin/events","assignees_url":"https://api.github.com/repos/contiv/netplugin/assignees{/user}","branches_url":"https://api.github.com/repos/contiv/netplugin/branches{/branch}","tags_url":"https://api.github.com/repos/contiv/netplugin/tags","blobs_url":"https://api.github.com/repos/contiv/netplugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/contiv/netplugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/contiv/netplugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/contiv/netplugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/contiv/netplugin/statuses/{sha}","languages_url":"https://api.github.com/repos/contiv/netplugin/languages","stargazers_url":"https://api.github.com/repos/contiv/netplugin/stargazers","contributors_url":"https://api.github.com/repos/contiv/netplugin/contributors","subscribers_url":"https://api.github.com/repos/contiv/netplugin/subscribers","subscription_url":"https://api.github.com/repos/contiv/netplugin/subscription","commits_url":"https://api.github.com/repos/contiv/netplugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/contiv/netplugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/contiv/netplugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/contiv/netplugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/contiv/netplugin/contents/{+path}","compare_url":"https://api.github.com/repos/contiv/netplugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/contiv/netplugin/merges","archive_url":"https://api.github.com/repos/contiv/netplugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/contiv/netplugin/downloads","issues_url":"https://api.github.com/repos/contiv/netplugin/issues{/number}","pulls_url":"https://api.github.com/repos/contiv/netplugin/pulls{/number}","milestones_url":"https://api.github.com/repos/contiv/netplugin/milestones{/number}","notifications_url":"https://api.github.com/repos/contiv/netplugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/contiv/netplugin/labels{/name}","releases_url":"https://api.github.com/repos/contiv/netplugin/releases{/id}","deployments_url":"https://api.github.com/repos/contiv/netplugin/deployments","created_at":"2014-12-22T18:45:21Z","updated_at":"2016-01-21T17:28:26Z","pushed_at":"2016-01-22T20:15:22Z","git_url":"git://github.com/contiv/netplugin.git","ssh_url":"git@github.com:contiv/netplugin.git","clone_url":"https://github.com/contiv/netplugin.git","svn_url":"https://github.com/contiv/netplugin","homepage":"","size":13533,"stargazers_count":57,"watchers_count":57,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":32,"mirror_url":null,"open_issues_count":46,"forks":32,"open_issues":46,"watchers":57,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/contiv/netplugin/pulls/243"},"html":{"href":"https://github.com/contiv/netplugin/pull/243"},"issue":{"href":"https://api.github.com/repos/contiv/netplugin/issues/243"},"comments":{"href":"https://api.github.com/repos/contiv/netplugin/issues/243/comments"},"review_comments":{"href":"https://api.github.com/repos/contiv/netplugin/pulls/243/comments"},"review_comment":{"href":"https://api.github.com/repos/contiv/netplugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/contiv/netplugin/pulls/243/commits"},"statuses":{"href":"https://api.github.com/repos/contiv/netplugin/statuses/08c489615e6c898edd1a5a7ef2f2507b4d021fc0"}}}}