{"action":"created","comment":{"url":"https://api.github.com/repos/eclipse/omr/pulls/comments/80388490","id":80388490,"diff_hunk":"@@ -5109,6 +5147,21 @@ TR_S390Peephole::perform()\n                }\n             break;\n             }\n+\n+         case TR::InstOpCode::LHI:\n+            {\n+            // This optimization is disabled by default because there exist cases in which we cannot determine whether this transformation\n+            // is functionally valid or not. The issue resides in the various runtime patching sequences using the LHI instruction as a\n+            // runtime patch point for an offset. One concrete example can be found in the virtual dispatch sequence for unresolved calls\n+            // on 31-bit platforms where an LHI instruction is used and is patched at runtime.\n+            //\n+            // TODO: To enable this optimization we need to implement an API which marks instructions that will be patched at runtime and","path":"compiler/z/codegen/OMRCodeGenerator.cpp","position":57,"original_position":57,"commit_id":"d7312f97b3b9cbeed25beca1d9fe4513fe556980","original_commit_id":"d7312f97b3b9cbeed25beca1d9fe4513fe556980","user":{"login":"fjeremic","id":16259104,"avatar_url":"https://avatars.githubusercontent.com/u/16259104?v=3","gravatar_id":"","url":"https://api.github.com/users/fjeremic","html_url":"https://github.com/fjeremic","followers_url":"https://api.github.com/users/fjeremic/followers","following_url":"https://api.github.com/users/fjeremic/following{/other_user}","gists_url":"https://api.github.com/users/fjeremic/gists{/gist_id}","starred_url":"https://api.github.com/users/fjeremic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fjeremic/subscriptions","organizations_url":"https://api.github.com/users/fjeremic/orgs","repos_url":"https://api.github.com/users/fjeremic/repos","events_url":"https://api.github.com/users/fjeremic/events{/privacy}","received_events_url":"https://api.github.com/users/fjeremic/received_events","type":"User","site_admin":false},"body":"Done in #255.","created_at":"2016-09-25T18:29:25Z","updated_at":"2016-09-25T18:29:25Z","html_url":"https://github.com/eclipse/omr/pull/242#discussion_r80388490","pull_request_url":"https://api.github.com/repos/eclipse/omr/pulls/242","_links":{"self":{"href":"https://api.github.com/repos/eclipse/omr/pulls/comments/80388490"},"html":{"href":"https://github.com/eclipse/omr/pull/242#discussion_r80388490"},"pull_request":{"href":"https://api.github.com/repos/eclipse/omr/pulls/242"}}},"pull_request":{"url":"https://api.github.com/repos/eclipse/omr/pulls/242","id":86529765,"html_url":"https://github.com/eclipse/omr/pull/242","diff_url":"https://github.com/eclipse/omr/pull/242.diff","patch_url":"https://github.com/eclipse/omr/pull/242.patch","issue_url":"https://api.github.com/repos/eclipse/omr/issues/242","number":242,"state":"open","locked":false,"title":"Register store zero peephole","user":{"login":"fjeremic","id":16259104,"avatar_url":"https://avatars.githubusercontent.com/u/16259104?v=3","gravatar_id":"","url":"https://api.github.com/users/fjeremic","html_url":"https://github.com/fjeremic","followers_url":"https://api.github.com/users/fjeremic/followers","following_url":"https://api.github.com/users/fjeremic/following{/other_user}","gists_url":"https://api.github.com/users/fjeremic/gists{/gist_id}","starred_url":"https://api.github.com/users/fjeremic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fjeremic/subscriptions","organizations_url":"https://api.github.com/users/fjeremic/orgs","repos_url":"https://api.github.com/users/fjeremic/repos","events_url":"https://api.github.com/users/fjeremic/events{/privacy}","received_events_url":"https://api.github.com/users/fjeremic/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-09-23T15:10:12Z","updated_at":"2016-09-25T18:29:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"443f1880f13cb5491e230f6e56f1d06cffae28d3","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/omr/pulls/242/commits","review_comments_url":"https://api.github.com/repos/eclipse/omr/pulls/242/comments","review_comment_url":"https://api.github.com/repos/eclipse/omr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/omr/issues/242/comments","statuses_url":"https://api.github.com/repos/eclipse/omr/statuses/d7312f97b3b9cbeed25beca1d9fe4513fe556980","head":{"label":"fjeremic:Register-Store-Zero-Peephole","ref":"Register-Store-Zero-Peephole","sha":"d7312f97b3b9cbeed25beca1d9fe4513fe556980","user":{"login":"fjeremic","id":16259104,"avatar_url":"https://avatars.githubusercontent.com/u/16259104?v=3","gravatar_id":"","url":"https://api.github.com/users/fjeremic","html_url":"https://github.com/fjeremic","followers_url":"https://api.github.com/users/fjeremic/followers","following_url":"https://api.github.com/users/fjeremic/following{/other_user}","gists_url":"https://api.github.com/users/fjeremic/gists{/gist_id}","starred_url":"https://api.github.com/users/fjeremic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fjeremic/subscriptions","organizations_url":"https://api.github.com/users/fjeremic/orgs","repos_url":"https://api.github.com/users/fjeremic/repos","events_url":"https://api.github.com/users/fjeremic/events{/privacy}","received_events_url":"https://api.github.com/users/fjeremic/received_events","type":"User","site_admin":false},"repo":{"id":68636127,"name":"omr","full_name":"fjeremic/omr","owner":{"login":"fjeremic","id":16259104,"avatar_url":"https://avatars.githubusercontent.com/u/16259104?v=3","gravatar_id":"","url":"https://api.github.com/users/fjeremic","html_url":"https://github.com/fjeremic","followers_url":"https://api.github.com/users/fjeremic/followers","following_url":"https://api.github.com/users/fjeremic/following{/other_user}","gists_url":"https://api.github.com/users/fjeremic/gists{/gist_id}","starred_url":"https://api.github.com/users/fjeremic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fjeremic/subscriptions","organizations_url":"https://api.github.com/users/fjeremic/orgs","repos_url":"https://api.github.com/users/fjeremic/repos","events_url":"https://api.github.com/users/fjeremic/events{/privacy}","received_events_url":"https://api.github.com/users/fjeremic/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fjeremic/omr","description":"Cross platform components for building reliable, high performance language runtimes","fork":true,"url":"https://api.github.com/repos/fjeremic/omr","forks_url":"https://api.github.com/repos/fjeremic/omr/forks","keys_url":"https://api.github.com/repos/fjeremic/omr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fjeremic/omr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fjeremic/omr/teams","hooks_url":"https://api.github.com/repos/fjeremic/omr/hooks","issue_events_url":"https://api.github.com/repos/fjeremic/omr/issues/events{/number}","events_url":"https://api.github.com/repos/fjeremic/omr/events","assignees_url":"https://api.github.com/repos/fjeremic/omr/assignees{/user}","branches_url":"https://api.github.com/repos/fjeremic/omr/branches{/branch}","tags_url":"https://api.github.com/repos/fjeremic/omr/tags","blobs_url":"https://api.github.com/repos/fjeremic/omr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fjeremic/omr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fjeremic/omr/git/refs{/sha}","trees_url":"https://api.github.com/repos/fjeremic/omr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fjeremic/omr/statuses/{sha}","languages_url":"https://api.github.com/repos/fjeremic/omr/languages","stargazers_url":"https://api.github.com/repos/fjeremic/omr/stargazers","contributors_url":"https://api.github.com/repos/fjeremic/omr/contributors","subscribers_url":"https://api.github.com/repos/fjeremic/omr/subscribers","subscription_url":"https://api.github.com/repos/fjeremic/omr/subscription","commits_url":"https://api.github.com/repos/fjeremic/omr/commits{/sha}","git_commits_url":"https://api.github.com/repos/fjeremic/omr/git/commits{/sha}","comments_url":"https://api.github.com/repos/fjeremic/omr/comments{/number}","issue_comment_url":"https://api.github.com/repos/fjeremic/omr/issues/comments{/number}","contents_url":"https://api.github.com/repos/fjeremic/omr/contents/{+path}","compare_url":"https://api.github.com/repos/fjeremic/omr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fjeremic/omr/merges","archive_url":"https://api.github.com/repos/fjeremic/omr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fjeremic/omr/downloads","issues_url":"https://api.github.com/repos/fjeremic/omr/issues{/number}","pulls_url":"https://api.github.com/repos/fjeremic/omr/pulls{/number}","milestones_url":"https://api.github.com/repos/fjeremic/omr/milestones{/number}","notifications_url":"https://api.github.com/repos/fjeremic/omr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fjeremic/omr/labels{/name}","releases_url":"https://api.github.com/repos/fjeremic/omr/releases{/id}","deployments_url":"https://api.github.com/repos/fjeremic/omr/deployments","created_at":"2016-09-19T18:53:42Z","updated_at":"2016-09-19T18:53:49Z","pushed_at":"2016-09-25T18:15:55Z","git_url":"git://github.com/fjeremic/omr.git","ssh_url":"git@github.com:fjeremic/omr.git","clone_url":"https://github.com/fjeremic/omr.git","svn_url":"https://github.com/fjeremic/omr","homepage":"","size":8824,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"eclipse:master","ref":"master","sha":"02e32b5a6e43723e2b71520214886a03a8ad4e8a","user":{"login":"eclipse","id":56974,"avatar_url":"https://avatars.githubusercontent.com/u/56974?v=3","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":53077478,"name":"omr","full_name":"eclipse/omr","owner":{"login":"eclipse","id":56974,"avatar_url":"https://avatars.githubusercontent.com/u/56974?v=3","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eclipse/omr","description":"Cross platform components for building reliable, high performance language runtimes","fork":false,"url":"https://api.github.com/repos/eclipse/omr","forks_url":"https://api.github.com/repos/eclipse/omr/forks","keys_url":"https://api.github.com/repos/eclipse/omr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/omr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/omr/teams","hooks_url":"https://api.github.com/repos/eclipse/omr/hooks","issue_events_url":"https://api.github.com/repos/eclipse/omr/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/omr/events","assignees_url":"https://api.github.com/repos/eclipse/omr/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/omr/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/omr/tags","blobs_url":"https://api.github.com/repos/eclipse/omr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/omr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/omr/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/omr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/omr/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/omr/languages","stargazers_url":"https://api.github.com/repos/eclipse/omr/stargazers","contributors_url":"https://api.github.com/repos/eclipse/omr/contributors","subscribers_url":"https://api.github.com/repos/eclipse/omr/subscribers","subscription_url":"https://api.github.com/repos/eclipse/omr/subscription","commits_url":"https://api.github.com/repos/eclipse/omr/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/omr/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/omr/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/omr/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/omr/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/omr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/omr/merges","archive_url":"https://api.github.com/repos/eclipse/omr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/omr/downloads","issues_url":"https://api.github.com/repos/eclipse/omr/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/omr/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/omr/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/omr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/omr/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/omr/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/omr/deployments","created_at":"2016-03-03T19:34:17Z","updated_at":"2016-09-25T16:49:08Z","pushed_at":"2016-09-24T00:24:28Z","git_url":"git://github.com/eclipse/omr.git","ssh_url":"git@github.com:eclipse/omr.git","clone_url":"https://github.com/eclipse/omr.git","svn_url":"https://github.com/eclipse/omr","homepage":"","size":9004,"stargazers_count":225,"watchers_count":225,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":75,"mirror_url":null,"open_issues_count":51,"forks":75,"open_issues":51,"watchers":225,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/omr/pulls/242"},"html":{"href":"https://github.com/eclipse/omr/pull/242"},"issue":{"href":"https://api.github.com/repos/eclipse/omr/issues/242"},"comments":{"href":"https://api.github.com/repos/eclipse/omr/issues/242/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/omr/pulls/242/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/omr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/omr/pulls/242/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/omr/statuses/d7312f97b3b9cbeed25beca1d9fe4513fe556980"}}}}
{"actor":{"display_login":"fjeremic"}}