{"action":"opened","number":4,"pull_request":{"url":"https://api.github.com/repos/dduvnjak/puppet-jmeter/pulls/4","id":73389429,"html_url":"https://github.com/dduvnjak/puppet-jmeter/pull/4","diff_url":"https://github.com/dduvnjak/puppet-jmeter/pull/4.diff","patch_url":"https://github.com/dduvnjak/puppet-jmeter/pull/4.patch","issue_url":"https://api.github.com/repos/dduvnjak/puppet-jmeter/issues/4","number":4,"state":"open","locked":false,"title":"using best practise for installing packages","user":{"login":"MarkGoldsmith1987","id":8806637,"avatar_url":"https://avatars.githubusercontent.com/u/8806637?v=3","gravatar_id":"","url":"https://api.github.com/users/MarkGoldsmith1987","html_url":"https://github.com/MarkGoldsmith1987","followers_url":"https://api.github.com/users/MarkGoldsmith1987/followers","following_url":"https://api.github.com/users/MarkGoldsmith1987/following{/other_user}","gists_url":"https://api.github.com/users/MarkGoldsmith1987/gists{/gist_id}","starred_url":"https://api.github.com/users/MarkGoldsmith1987/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarkGoldsmith1987/subscriptions","organizations_url":"https://api.github.com/users/MarkGoldsmith1987/orgs","repos_url":"https://api.github.com/users/MarkGoldsmith1987/repos","events_url":"https://api.github.com/users/MarkGoldsmith1987/events{/privacy}","received_events_url":"https://api.github.com/users/MarkGoldsmith1987/received_events","type":"User","site_admin":false},"body":"You shouldn't just use a package resource when installing a package, unless that package is unique for the application being installed in the module.\r\n\r\nFor things like unzip, people may have installed this in other modules being run on the same host and therefore they get a duplicate resource definition.\r\n\r\nI've updated the packages to use the ensure_resource function which gets around this problem and only attempts to install the package if it doesn't already exist. Note this function requires the puppetlabs-stdlibs module","created_at":"2016-06-10T15:13:32Z","updated_at":"2016-06-10T15:13:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dduvnjak/puppet-jmeter/pulls/4/commits","review_comments_url":"https://api.github.com/repos/dduvnjak/puppet-jmeter/pulls/4/comments","review_comment_url":"https://api.github.com/repos/dduvnjak/puppet-jmeter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dduvnjak/puppet-jmeter/issues/4/comments","statuses_url":"https://api.github.com/repos/dduvnjak/puppet-jmeter/statuses/8d4619c622f68d046f4a57a4cc6af6082943e10c","head":{"label":"MarkGoldsmith1987:master","ref":"master","sha":"8d4619c622f68d046f4a57a4cc6af6082943e10c","user":{"login":"MarkGoldsmith1987","id":8806637,"avatar_url":"https://avatars.githubusercontent.com/u/8806637?v=3","gravatar_id":"","url":"https://api.github.com/users/MarkGoldsmith1987","html_url":"https://github.com/MarkGoldsmith1987","followers_url":"https://api.github.com/users/MarkGoldsmith1987/followers","following_url":"https://api.github.com/users/MarkGoldsmith1987/following{/other_user}","gists_url":"https://api.github.com/users/MarkGoldsmith1987/gists{/gist_id}","starred_url":"https://api.github.com/users/MarkGoldsmith1987/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarkGoldsmith1987/subscriptions","organizations_url":"https://api.github.com/users/MarkGoldsmith1987/orgs","repos_url":"https://api.github.com/users/MarkGoldsmith1987/repos","events_url":"https://api.github.com/users/MarkGoldsmith1987/events{/privacy}","received_events_url":"https://api.github.com/users/MarkGoldsmith1987/received_events","type":"User","site_admin":false},"repo":{"id":60854439,"name":"puppet-jmeter","full_name":"MarkGoldsmith1987/puppet-jmeter","owner":{"login":"MarkGoldsmith1987","id":8806637,"avatar_url":"https://avatars.githubusercontent.com/u/8806637?v=3","gravatar_id":"","url":"https://api.github.com/users/MarkGoldsmith1987","html_url":"https://github.com/MarkGoldsmith1987","followers_url":"https://api.github.com/users/MarkGoldsmith1987/followers","following_url":"https://api.github.com/users/MarkGoldsmith1987/following{/other_user}","gists_url":"https://api.github.com/users/MarkGoldsmith1987/gists{/gist_id}","starred_url":"https://api.github.com/users/MarkGoldsmith1987/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarkGoldsmith1987/subscriptions","organizations_url":"https://api.github.com/users/MarkGoldsmith1987/orgs","repos_url":"https://api.github.com/users/MarkGoldsmith1987/repos","events_url":"https://api.github.com/users/MarkGoldsmith1987/events{/privacy}","received_events_url":"https://api.github.com/users/MarkGoldsmith1987/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MarkGoldsmith1987/puppet-jmeter","description":"","fork":true,"url":"https://api.github.com/repos/MarkGoldsmith1987/puppet-jmeter","forks_url":"https://api.github.com/repos/MarkGoldsmith1987/puppet-jmeter/forks","keys_url":"https://api.github.com/repos/MarkGoldsmith1987/puppet-jmeter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MarkGoldsmith1987/puppet-jmeter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MarkGoldsmith1987/puppet-jmeter/teams","hooks_url":"https://api.github.com/repos/MarkGoldsmith1987/puppet-jmeter/hooks","issue_events_url":"https://api.github.com/repos/MarkGoldsmith1987/puppet-jmeter/issues/events{/number}","events_url":"https://api.github.com/repos/MarkGoldsmith1987/puppet-jmeter/events","assignees_url":"https://api.github.com/repos/MarkGoldsmith1987/puppet-jmeter/assignees{/user}","branches_url":"https://api.github.com/repos/MarkGoldsmith1987/puppet-jmeter/branches{/branch}","tags_url":"https://api.github.com/repos/MarkGoldsmith1987/puppet-jmeter/tags","blobs_url":"https://api.github.com/repos/MarkGoldsmith1987/puppet-jmeter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MarkGoldsmith1987/puppet-jmeter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MarkGoldsmith1987/puppet-jmeter/git/refs{/sha}","trees_url":"https://api.github.com/repos/MarkGoldsmith1987/puppet-jmeter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MarkGoldsmith1987/puppet-jmeter/statuses/{sha}","languages_url":"https://api.github.com/repos/MarkGoldsmith1987/puppet-jmeter/languages","stargazers_url":"https://api.github.com/repos/MarkGoldsmith1987/puppet-jmeter/stargazers","contributors_url":"https://api.github.com/repos/MarkGoldsmith1987/puppet-jmeter/contributors","subscribers_url":"https://api.github.com/repos/MarkGoldsmith1987/puppet-jmeter/subscribers","subscription_url":"https://api.github.com/repos/MarkGoldsmith1987/puppet-jmeter/subscription","commits_url":"https://api.github.com/repos/MarkGoldsmith1987/puppet-jmeter/commits{/sha}","git_commits_url":"https://api.github.com/repos/MarkGoldsmith1987/puppet-jmeter/git/commits{/sha}","comments_url":"https://api.github.com/repos/MarkGoldsmith1987/puppet-jmeter/comments{/number}","issue_comment_url":"https://api.github.com/repos/MarkGoldsmith1987/puppet-jmeter/issues/comments{/number}","contents_url":"https://api.github.com/repos/MarkGoldsmith1987/puppet-jmeter/contents/{+path}","compare_url":"https://api.github.com/repos/MarkGoldsmith1987/puppet-jmeter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MarkGoldsmith1987/puppet-jmeter/merges","archive_url":"https://api.github.com/repos/MarkGoldsmith1987/puppet-jmeter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MarkGoldsmith1987/puppet-jmeter/downloads","issues_url":"https://api.github.com/repos/MarkGoldsmith1987/puppet-jmeter/issues{/number}","pulls_url":"https://api.github.com/repos/MarkGoldsmith1987/puppet-jmeter/pulls{/number}","milestones_url":"https://api.github.com/repos/MarkGoldsmith1987/puppet-jmeter/milestones{/number}","notifications_url":"https://api.github.com/repos/MarkGoldsmith1987/puppet-jmeter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MarkGoldsmith1987/puppet-jmeter/labels{/name}","releases_url":"https://api.github.com/repos/MarkGoldsmith1987/puppet-jmeter/releases{/id}","deployments_url":"https://api.github.com/repos/MarkGoldsmith1987/puppet-jmeter/deployments","created_at":"2016-06-10T14:36:29Z","updated_at":"2016-06-10T14:36:30Z","pushed_at":"2016-06-10T14:55:50Z","git_url":"git://github.com/MarkGoldsmith1987/puppet-jmeter.git","ssh_url":"git@github.com:MarkGoldsmith1987/puppet-jmeter.git","clone_url":"https://github.com/MarkGoldsmith1987/puppet-jmeter.git","svn_url":"https://github.com/MarkGoldsmith1987/puppet-jmeter","homepage":null,"size":28,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dduvnjak:master","ref":"master","sha":"edd59599139036e6f5ad0cfcca2d3bd8864ea377","user":{"login":"dduvnjak","id":1423435,"avatar_url":"https://avatars.githubusercontent.com/u/1423435?v=3","gravatar_id":"","url":"https://api.github.com/users/dduvnjak","html_url":"https://github.com/dduvnjak","followers_url":"https://api.github.com/users/dduvnjak/followers","following_url":"https://api.github.com/users/dduvnjak/following{/other_user}","gists_url":"https://api.github.com/users/dduvnjak/gists{/gist_id}","starred_url":"https://api.github.com/users/dduvnjak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dduvnjak/subscriptions","organizations_url":"https://api.github.com/users/dduvnjak/orgs","repos_url":"https://api.github.com/users/dduvnjak/repos","events_url":"https://api.github.com/users/dduvnjak/events{/privacy}","received_events_url":"https://api.github.com/users/dduvnjak/received_events","type":"User","site_admin":false},"repo":{"id":10050172,"name":"puppet-jmeter","full_name":"dduvnjak/puppet-jmeter","owner":{"login":"dduvnjak","id":1423435,"avatar_url":"https://avatars.githubusercontent.com/u/1423435?v=3","gravatar_id":"","url":"https://api.github.com/users/dduvnjak","html_url":"https://github.com/dduvnjak","followers_url":"https://api.github.com/users/dduvnjak/followers","following_url":"https://api.github.com/users/dduvnjak/following{/other_user}","gists_url":"https://api.github.com/users/dduvnjak/gists{/gist_id}","starred_url":"https://api.github.com/users/dduvnjak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dduvnjak/subscriptions","organizations_url":"https://api.github.com/users/dduvnjak/orgs","repos_url":"https://api.github.com/users/dduvnjak/repos","events_url":"https://api.github.com/users/dduvnjak/events{/privacy}","received_events_url":"https://api.github.com/users/dduvnjak/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dduvnjak/puppet-jmeter","description":"","fork":true,"url":"https://api.github.com/repos/dduvnjak/puppet-jmeter","forks_url":"https://api.github.com/repos/dduvnjak/puppet-jmeter/forks","keys_url":"https://api.github.com/repos/dduvnjak/puppet-jmeter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dduvnjak/puppet-jmeter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dduvnjak/puppet-jmeter/teams","hooks_url":"https://api.github.com/repos/dduvnjak/puppet-jmeter/hooks","issue_events_url":"https://api.github.com/repos/dduvnjak/puppet-jmeter/issues/events{/number}","events_url":"https://api.github.com/repos/dduvnjak/puppet-jmeter/events","assignees_url":"https://api.github.com/repos/dduvnjak/puppet-jmeter/assignees{/user}","branches_url":"https://api.github.com/repos/dduvnjak/puppet-jmeter/branches{/branch}","tags_url":"https://api.github.com/repos/dduvnjak/puppet-jmeter/tags","blobs_url":"https://api.github.com/repos/dduvnjak/puppet-jmeter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dduvnjak/puppet-jmeter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dduvnjak/puppet-jmeter/git/refs{/sha}","trees_url":"https://api.github.com/repos/dduvnjak/puppet-jmeter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dduvnjak/puppet-jmeter/statuses/{sha}","languages_url":"https://api.github.com/repos/dduvnjak/puppet-jmeter/languages","stargazers_url":"https://api.github.com/repos/dduvnjak/puppet-jmeter/stargazers","contributors_url":"https://api.github.com/repos/dduvnjak/puppet-jmeter/contributors","subscribers_url":"https://api.github.com/repos/dduvnjak/puppet-jmeter/subscribers","subscription_url":"https://api.github.com/repos/dduvnjak/puppet-jmeter/subscription","commits_url":"https://api.github.com/repos/dduvnjak/puppet-jmeter/commits{/sha}","git_commits_url":"https://api.github.com/repos/dduvnjak/puppet-jmeter/git/commits{/sha}","comments_url":"https://api.github.com/repos/dduvnjak/puppet-jmeter/comments{/number}","issue_comment_url":"https://api.github.com/repos/dduvnjak/puppet-jmeter/issues/comments{/number}","contents_url":"https://api.github.com/repos/dduvnjak/puppet-jmeter/contents/{+path}","compare_url":"https://api.github.com/repos/dduvnjak/puppet-jmeter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dduvnjak/puppet-jmeter/merges","archive_url":"https://api.github.com/repos/dduvnjak/puppet-jmeter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dduvnjak/puppet-jmeter/downloads","issues_url":"https://api.github.com/repos/dduvnjak/puppet-jmeter/issues{/number}","pulls_url":"https://api.github.com/repos/dduvnjak/puppet-jmeter/pulls{/number}","milestones_url":"https://api.github.com/repos/dduvnjak/puppet-jmeter/milestones{/number}","notifications_url":"https://api.github.com/repos/dduvnjak/puppet-jmeter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dduvnjak/puppet-jmeter/labels{/name}","releases_url":"https://api.github.com/repos/dduvnjak/puppet-jmeter/releases{/id}","deployments_url":"https://api.github.com/repos/dduvnjak/puppet-jmeter/deployments","created_at":"2013-05-14T08:00:03Z","updated_at":"2015-06-04T14:16:02Z","pushed_at":"2016-06-10T15:13:32Z","git_url":"git://github.com/dduvnjak/puppet-jmeter.git","ssh_url":"git@github.com:dduvnjak/puppet-jmeter.git","clone_url":"https://github.com/dduvnjak/puppet-jmeter.git","svn_url":"https://github.com/dduvnjak/puppet-jmeter","homepage":null,"size":27,"stargazers_count":2,"watchers_count":2,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":1,"forks":13,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dduvnjak/puppet-jmeter/pulls/4"},"html":{"href":"https://github.com/dduvnjak/puppet-jmeter/pull/4"},"issue":{"href":"https://api.github.com/repos/dduvnjak/puppet-jmeter/issues/4"},"comments":{"href":"https://api.github.com/repos/dduvnjak/puppet-jmeter/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/dduvnjak/puppet-jmeter/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/dduvnjak/puppet-jmeter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dduvnjak/puppet-jmeter/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/dduvnjak/puppet-jmeter/statuses/8d4619c622f68d046f4a57a4cc6af6082943e10c"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":11,"changed_files":1}}
{"actor":{"display_login":"MarkGoldsmith1987"}}