{"action":"created","issue":{"url":"https://api.github.com/repos/cmangos/mangos-classic/issues/116","repository_url":"https://api.github.com/repos/cmangos/mangos-classic","labels_url":"https://api.github.com/repos/cmangos/mangos-classic/issues/116/labels{/name}","comments_url":"https://api.github.com/repos/cmangos/mangos-classic/issues/116/comments","events_url":"https://api.github.com/repos/cmangos/mangos-classic/issues/116/events","html_url":"https://github.com/cmangos/mangos-classic/pull/116","id":148535334,"number":116,"title":"Pet fixup round 1 (Pet.cpp, SpellEffects.cpp)","user":{"login":"Phatcat","id":1907820,"avatar_url":"https://avatars.githubusercontent.com/u/1907820?v=3","gravatar_id":"","url":"https://api.github.com/users/Phatcat","html_url":"https://github.com/Phatcat","followers_url":"https://api.github.com/users/Phatcat/followers","following_url":"https://api.github.com/users/Phatcat/following{/other_user}","gists_url":"https://api.github.com/users/Phatcat/gists{/gist_id}","starred_url":"https://api.github.com/users/Phatcat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Phatcat/subscriptions","organizations_url":"https://api.github.com/users/Phatcat/orgs","repos_url":"https://api.github.com/users/Phatcat/repos","events_url":"https://api.github.com/users/Phatcat/events{/privacy}","received_events_url":"https://api.github.com/users/Phatcat/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2016-04-15T02:14:49Z","updated_at":"2016-04-20T07:54:07Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cmangos/mangos-classic/pulls/116","html_url":"https://github.com/cmangos/mangos-classic/pull/116","diff_url":"https://github.com/cmangos/mangos-classic/pull/116.diff","patch_url":"https://github.com/cmangos/mangos-classic/pull/116.patch"},"body":"Should apply the correct health and mana to guardians according to the db table entries instead of basing them off a static formula.\r\n\r\nThe reason for this fix is in part to correct the Silithid Swarm summons, which a couple of mobs in Tanaris casts. The Silithid Swarms should only have 1 hp, as they are when being summoned on spawn. but when being summoned in fight, they are being set as guardians, and by that have a different amount of hp, one that does not seem fair nor blizzlike at all.\r\n\r\nTo reproduce the issue I am talking about teleport to Tanaris, go to the Noxious Lair area, pick a fight with a Swarmer and get ready.\r\n\r\nThis fix appropriately sets any guardians health and mana to whatever it is listed to be in the database.\r\n\r\n\r\n*Update:\r\nCommit 2: the second commit removes the custom formulas for health (if pet level info is not in db) and damage, and instead bases health, mana and damage off of the db entries.\r\nThe only reason for changing SpellEffects is because guardians are by default ALWAYS summoned as the level of the caster, which is not how it's supposed to function when a creature summons a guardian.\r\n\r\n*Update 2:\r\nSquashed into a single commit.\r\n\r\n*Update 3:\r\nAdded a few changes in a new commit.\r\n\r\n*Update 4:\r\nCorrected all summons, meaning that all pets, guardians, whatever, have correct levels. this goes for hunter pets as well."},"comment":{"url":"https://api.github.com/repos/cmangos/mangos-classic/issues/comments/212309478","html_url":"https://github.com/cmangos/mangos-classic/pull/116#issuecomment-212309478","issue_url":"https://api.github.com/repos/cmangos/mangos-classic/issues/116","id":212309478,"user":{"login":"Phatcat","id":1907820,"avatar_url":"https://avatars.githubusercontent.com/u/1907820?v=3","gravatar_id":"","url":"https://api.github.com/users/Phatcat","html_url":"https://github.com/Phatcat","followers_url":"https://api.github.com/users/Phatcat/followers","following_url":"https://api.github.com/users/Phatcat/following{/other_user}","gists_url":"https://api.github.com/users/Phatcat/gists{/gist_id}","starred_url":"https://api.github.com/users/Phatcat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Phatcat/subscriptions","organizations_url":"https://api.github.com/users/Phatcat/orgs","repos_url":"https://api.github.com/users/Phatcat/repos","events_url":"https://api.github.com/users/Phatcat/events{/privacy}","received_events_url":"https://api.github.com/users/Phatcat/received_events","type":"User","site_admin":false},"created_at":"2016-04-20T07:54:07Z","updated_at":"2016-04-20T07:54:07Z","body":"Yeah... I think I'm working on pets."}}