{"action":"created","issue":{"url":"https://api.github.com/repos/openSUSE/snapper/issues/221","repository_url":"https://api.github.com/repos/openSUSE/snapper","labels_url":"https://api.github.com/repos/openSUSE/snapper/issues/221/labels{/name}","comments_url":"https://api.github.com/repos/openSUSE/snapper/issues/221/comments","events_url":"https://api.github.com/repos/openSUSE/snapper/issues/221/events","html_url":"https://github.com/openSUSE/snapper/pull/221","id":127788552,"number":221,"title":"Fix dbus interface methods types.","user":{"login":"p2004a","id":2212599,"avatar_url":"https://avatars.githubusercontent.com/u/2212599?v=3","gravatar_id":"","url":"https://api.github.com/users/p2004a","html_url":"https://github.com/p2004a","followers_url":"https://api.github.com/users/p2004a/followers","following_url":"https://api.github.com/users/p2004a/following{/other_user}","gists_url":"https://api.github.com/users/p2004a/gists{/gist_id}","starred_url":"https://api.github.com/users/p2004a/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/p2004a/subscriptions","organizations_url":"https://api.github.com/users/p2004a/orgs","repos_url":"https://api.github.com/users/p2004a/repos","events_url":"https://api.github.com/users/p2004a/events{/privacy}","received_events_url":"https://api.github.com/users/p2004a/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-01-20T21:32:46Z","updated_at":"2016-02-19T18:13:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/openSUSE/snapper/pulls/221","html_url":"https://github.com/openSUSE/snapper/pull/221","diff_url":"https://github.com/openSUSE/snapper/pull/221.diff","patch_url":"https://github.com/openSUSE/snapper/pull/221.patch"},"body":"The XML in Introspect method doesn't contain correct information about a few methods.\r\n\r\n- ListConfigs, ListSnapshots, ListSnapshotsAtTime, GetFiles don't return variadic but raw value (not packed inside variadic).\r\n- MountSnapshot, GetMountPoint didn't contain information about return type.\r\n- CreateComparison declared that it returns num of files but implementation didn't return anything.\r\n\r\nI tried to add a unit/real test that will validate the interface types but I couldn't mock objects that Client class is using and I can't run snapperd without interfring with snapper currently installed in the system.\r\n\r\nI was testing in sandboxed installation using this scripts: https://gist.github.com/p2004a/9762b22c3edeb0f5d18a (pydbus library validates the return types etc.)"},"comment":{"url":"https://api.github.com/repos/openSUSE/snapper/issues/comments/186341201","html_url":"https://github.com/openSUSE/snapper/pull/221#issuecomment-186341201","issue_url":"https://api.github.com/repos/openSUSE/snapper/issues/221","id":186341201,"user":{"login":"p2004a","id":2212599,"avatar_url":"https://avatars.githubusercontent.com/u/2212599?v=3","gravatar_id":"","url":"https://api.github.com/users/p2004a","html_url":"https://github.com/p2004a","followers_url":"https://api.github.com/users/p2004a/followers","following_url":"https://api.github.com/users/p2004a/following{/other_user}","gists_url":"https://api.github.com/users/p2004a/gists{/gist_id}","starred_url":"https://api.github.com/users/p2004a/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/p2004a/subscriptions","organizations_url":"https://api.github.com/users/p2004a/orgs","repos_url":"https://api.github.com/users/p2004a/repos","events_url":"https://api.github.com/users/p2004a/events{/privacy}","received_events_url":"https://api.github.com/users/p2004a/received_events","type":"User","site_admin":false},"created_at":"2016-02-19T18:13:48Z","updated_at":"2016-02-19T18:13:48Z","body":"Done."}}