{"action":"created","comment":{"url":"https://api.github.com/repos/smoketurner/dropwizard-zipkin/pulls/comments/81978063","pull_request_review_id":2917645,"id":81978063,"diff_hunk":"@@ -69,17 +70,17 @@ public void setTopic(String topic) {\n      */\n     @Override\n     public Brave build(@Nonnull final Environment environment) {\n-        final SpanCollectorMetricsHandler metricsHandler = new DropwizardSpanCollectorMetricsHandler(\n+        final ReporterMetrics metricsHandler = new DropwizardReporterMetrics(\n                 environment.metrics());\n \n-        final KafkaSpanCollector.Config kafkaConfig = KafkaSpanCollector.Config\n-                .builder(bootstrapServers).topic(topic).build();\n-        final SpanCollector spanCollector = KafkaSpanCollector\n-                .create(kafkaConfig, metricsHandler);\n+        final KafkaSender sender = KafkaSender.builder()\n+                .bootstrapServers(bootstrapServers).topic(topic).build();\n+        final AsyncReporter<Span> reporter = AsyncReporter.builder(sender)","path":"zipkin-core/src/main/java/com/smoketurner/dropwizard/zipkin/KafkaZipkinFactory.java","position":31,"original_position":31,"commit_id":"23f9958b146a29e8e9c902d1452ef01ab7a81243","original_commit_id":"23f9958b146a29e8e9c902d1452ef01ab7a81243","user":{"login":"adriancole","id":64215,"avatar_url":"https://avatars.githubusercontent.com/u/64215?v=3","gravatar_id":"","url":"https://api.github.com/users/adriancole","html_url":"https://github.com/adriancole","followers_url":"https://api.github.com/users/adriancole/followers","following_url":"https://api.github.com/users/adriancole/following{/other_user}","gists_url":"https://api.github.com/users/adriancole/gists{/gist_id}","starred_url":"https://api.github.com/users/adriancole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adriancole/subscriptions","organizations_url":"https://api.github.com/users/adriancole/orgs","repos_url":"https://api.github.com/users/adriancole/repos","events_url":"https://api.github.com/users/adriancole/events{/privacy}","received_events_url":"https://api.github.com/users/adriancole/received_events","type":"User","site_admin":false},"body":"note sender and also AsyncReporter are closeable (individually: close reporter before sender). also, if there's any \"post construct\" phase, you could call reporter.check() on it","created_at":"2016-10-05T13:58:51Z","updated_at":"2016-10-05T14:01:52Z","html_url":"https://github.com/smoketurner/dropwizard-zipkin/pull/12#discussion_r81978063","pull_request_url":"https://api.github.com/repos/smoketurner/dropwizard-zipkin/pulls/12","_links":{"self":{"href":"https://api.github.com/repos/smoketurner/dropwizard-zipkin/pulls/comments/81978063"},"html":{"href":"https://github.com/smoketurner/dropwizard-zipkin/pull/12#discussion_r81978063"},"pull_request":{"href":"https://api.github.com/repos/smoketurner/dropwizard-zipkin/pulls/12"}}},"pull_request":{"url":"https://api.github.com/repos/smoketurner/dropwizard-zipkin/pulls/12","id":88081751,"html_url":"https://github.com/smoketurner/dropwizard-zipkin/pull/12","diff_url":"https://github.com/smoketurner/dropwizard-zipkin/pull/12.diff","patch_url":"https://github.com/smoketurner/dropwizard-zipkin/pull/12.patch","issue_url":"https://api.github.com/repos/smoketurner/dropwizard-zipkin/issues/12","number":12,"state":"open","locked":false,"title":"Upgrade to zipkin 3.14.0 and replace SpanCollector with Reporter","user":{"login":"jplock","id":49093,"avatar_url":"https://avatars.githubusercontent.com/u/49093?v=3","gravatar_id":"","url":"https://api.github.com/users/jplock","html_url":"https://github.com/jplock","followers_url":"https://api.github.com/users/jplock/followers","following_url":"https://api.github.com/users/jplock/following{/other_user}","gists_url":"https://api.github.com/users/jplock/gists{/gist_id}","starred_url":"https://api.github.com/users/jplock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jplock/subscriptions","organizations_url":"https://api.github.com/users/jplock/orgs","repos_url":"https://api.github.com/users/jplock/repos","events_url":"https://api.github.com/users/jplock/events{/privacy}","received_events_url":"https://api.github.com/users/jplock/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-10-05T13:51:30Z","updated_at":"2016-10-05T14:01:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"02507967fe2c263e7f34dfe46ee2a84b3d6a0955","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/smoketurner/dropwizard-zipkin/pulls/12/commits","review_comments_url":"https://api.github.com/repos/smoketurner/dropwizard-zipkin/pulls/12/comments","review_comment_url":"https://api.github.com/repos/smoketurner/dropwizard-zipkin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/smoketurner/dropwizard-zipkin/issues/12/comments","statuses_url":"https://api.github.com/repos/smoketurner/dropwizard-zipkin/statuses/23f9958b146a29e8e9c902d1452ef01ab7a81243","head":{"label":"smoketurner:jp-reporters","ref":"jp-reporters","sha":"23f9958b146a29e8e9c902d1452ef01ab7a81243","user":{"login":"smoketurner","id":8753311,"avatar_url":"https://avatars.githubusercontent.com/u/8753311?v=3","gravatar_id":"","url":"https://api.github.com/users/smoketurner","html_url":"https://github.com/smoketurner","followers_url":"https://api.github.com/users/smoketurner/followers","following_url":"https://api.github.com/users/smoketurner/following{/other_user}","gists_url":"https://api.github.com/users/smoketurner/gists{/gist_id}","starred_url":"https://api.github.com/users/smoketurner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smoketurner/subscriptions","organizations_url":"https://api.github.com/users/smoketurner/orgs","repos_url":"https://api.github.com/users/smoketurner/repos","events_url":"https://api.github.com/users/smoketurner/events{/privacy}","received_events_url":"https://api.github.com/users/smoketurner/received_events","type":"Organization","site_admin":false},"repo":{"id":51269282,"name":"dropwizard-zipkin","full_name":"smoketurner/dropwizard-zipkin","owner":{"login":"smoketurner","id":8753311,"avatar_url":"https://avatars.githubusercontent.com/u/8753311?v=3","gravatar_id":"","url":"https://api.github.com/users/smoketurner","html_url":"https://github.com/smoketurner","followers_url":"https://api.github.com/users/smoketurner/followers","following_url":"https://api.github.com/users/smoketurner/following{/other_user}","gists_url":"https://api.github.com/users/smoketurner/gists{/gist_id}","starred_url":"https://api.github.com/users/smoketurner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smoketurner/subscriptions","organizations_url":"https://api.github.com/users/smoketurner/orgs","repos_url":"https://api.github.com/users/smoketurner/repos","events_url":"https://api.github.com/users/smoketurner/events{/privacy}","received_events_url":"https://api.github.com/users/smoketurner/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/smoketurner/dropwizard-zipkin","description":"Dropwizard Zipkin Bundle","fork":false,"url":"https://api.github.com/repos/smoketurner/dropwizard-zipkin","forks_url":"https://api.github.com/repos/smoketurner/dropwizard-zipkin/forks","keys_url":"https://api.github.com/repos/smoketurner/dropwizard-zipkin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smoketurner/dropwizard-zipkin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smoketurner/dropwizard-zipkin/teams","hooks_url":"https://api.github.com/repos/smoketurner/dropwizard-zipkin/hooks","issue_events_url":"https://api.github.com/repos/smoketurner/dropwizard-zipkin/issues/events{/number}","events_url":"https://api.github.com/repos/smoketurner/dropwizard-zipkin/events","assignees_url":"https://api.github.com/repos/smoketurner/dropwizard-zipkin/assignees{/user}","branches_url":"https://api.github.com/repos/smoketurner/dropwizard-zipkin/branches{/branch}","tags_url":"https://api.github.com/repos/smoketurner/dropwizard-zipkin/tags","blobs_url":"https://api.github.com/repos/smoketurner/dropwizard-zipkin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smoketurner/dropwizard-zipkin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smoketurner/dropwizard-zipkin/git/refs{/sha}","trees_url":"https://api.github.com/repos/smoketurner/dropwizard-zipkin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smoketurner/dropwizard-zipkin/statuses/{sha}","languages_url":"https://api.github.com/repos/smoketurner/dropwizard-zipkin/languages","stargazers_url":"https://api.github.com/repos/smoketurner/dropwizard-zipkin/stargazers","contributors_url":"https://api.github.com/repos/smoketurner/dropwizard-zipkin/contributors","subscribers_url":"https://api.github.com/repos/smoketurner/dropwizard-zipkin/subscribers","subscription_url":"https://api.github.com/repos/smoketurner/dropwizard-zipkin/subscription","commits_url":"https://api.github.com/repos/smoketurner/dropwizard-zipkin/commits{/sha}","git_commits_url":"https://api.github.com/repos/smoketurner/dropwizard-zipkin/git/commits{/sha}","comments_url":"https://api.github.com/repos/smoketurner/dropwizard-zipkin/comments{/number}","issue_comment_url":"https://api.github.com/repos/smoketurner/dropwizard-zipkin/issues/comments{/number}","contents_url":"https://api.github.com/repos/smoketurner/dropwizard-zipkin/contents/{+path}","compare_url":"https://api.github.com/repos/smoketurner/dropwizard-zipkin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smoketurner/dropwizard-zipkin/merges","archive_url":"https://api.github.com/repos/smoketurner/dropwizard-zipkin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smoketurner/dropwizard-zipkin/downloads","issues_url":"https://api.github.com/repos/smoketurner/dropwizard-zipkin/issues{/number}","pulls_url":"https://api.github.com/repos/smoketurner/dropwizard-zipkin/pulls{/number}","milestones_url":"https://api.github.com/repos/smoketurner/dropwizard-zipkin/milestones{/number}","notifications_url":"https://api.github.com/repos/smoketurner/dropwizard-zipkin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smoketurner/dropwizard-zipkin/labels{/name}","releases_url":"https://api.github.com/repos/smoketurner/dropwizard-zipkin/releases{/id}","deployments_url":"https://api.github.com/repos/smoketurner/dropwizard-zipkin/deployments","created_at":"2016-02-07T22:19:54Z","updated_at":"2016-09-29T22:00:21Z","pushed_at":"2016-10-05T13:51:30Z","git_url":"git://github.com/smoketurner/dropwizard-zipkin.git","ssh_url":"git@github.com:smoketurner/dropwizard-zipkin.git","clone_url":"https://github.com/smoketurner/dropwizard-zipkin.git","svn_url":"https://github.com/smoketurner/dropwizard-zipkin","homepage":"http://smoketurner.github.io/dropwizard-zipkin/1.0.2-2/","size":1878,"stargazers_count":19,"watchers_count":19,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":6,"mirror_url":null,"open_issues_count":2,"forks":6,"open_issues":2,"watchers":19,"default_branch":"master"}},"base":{"label":"smoketurner:master","ref":"master","sha":"6b3e6b745ad77a754ffc4149fa3b6e8c9760bf18","user":{"login":"smoketurner","id":8753311,"avatar_url":"https://avatars.githubusercontent.com/u/8753311?v=3","gravatar_id":"","url":"https://api.github.com/users/smoketurner","html_url":"https://github.com/smoketurner","followers_url":"https://api.github.com/users/smoketurner/followers","following_url":"https://api.github.com/users/smoketurner/following{/other_user}","gists_url":"https://api.github.com/users/smoketurner/gists{/gist_id}","starred_url":"https://api.github.com/users/smoketurner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smoketurner/subscriptions","organizations_url":"https://api.github.com/users/smoketurner/orgs","repos_url":"https://api.github.com/users/smoketurner/repos","events_url":"https://api.github.com/users/smoketurner/events{/privacy}","received_events_url":"https://api.github.com/users/smoketurner/received_events","type":"Organization","site_admin":false},"repo":{"id":51269282,"name":"dropwizard-zipkin","full_name":"smoketurner/dropwizard-zipkin","owner":{"login":"smoketurner","id":8753311,"avatar_url":"https://avatars.githubusercontent.com/u/8753311?v=3","gravatar_id":"","url":"https://api.github.com/users/smoketurner","html_url":"https://github.com/smoketurner","followers_url":"https://api.github.com/users/smoketurner/followers","following_url":"https://api.github.com/users/smoketurner/following{/other_user}","gists_url":"https://api.github.com/users/smoketurner/gists{/gist_id}","starred_url":"https://api.github.com/users/smoketurner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smoketurner/subscriptions","organizations_url":"https://api.github.com/users/smoketurner/orgs","repos_url":"https://api.github.com/users/smoketurner/repos","events_url":"https://api.github.com/users/smoketurner/events{/privacy}","received_events_url":"https://api.github.com/users/smoketurner/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/smoketurner/dropwizard-zipkin","description":"Dropwizard Zipkin Bundle","fork":false,"url":"https://api.github.com/repos/smoketurner/dropwizard-zipkin","forks_url":"https://api.github.com/repos/smoketurner/dropwizard-zipkin/forks","keys_url":"https://api.github.com/repos/smoketurner/dropwizard-zipkin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smoketurner/dropwizard-zipkin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smoketurner/dropwizard-zipkin/teams","hooks_url":"https://api.github.com/repos/smoketurner/dropwizard-zipkin/hooks","issue_events_url":"https://api.github.com/repos/smoketurner/dropwizard-zipkin/issues/events{/number}","events_url":"https://api.github.com/repos/smoketurner/dropwizard-zipkin/events","assignees_url":"https://api.github.com/repos/smoketurner/dropwizard-zipkin/assignees{/user}","branches_url":"https://api.github.com/repos/smoketurner/dropwizard-zipkin/branches{/branch}","tags_url":"https://api.github.com/repos/smoketurner/dropwizard-zipkin/tags","blobs_url":"https://api.github.com/repos/smoketurner/dropwizard-zipkin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smoketurner/dropwizard-zipkin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smoketurner/dropwizard-zipkin/git/refs{/sha}","trees_url":"https://api.github.com/repos/smoketurner/dropwizard-zipkin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smoketurner/dropwizard-zipkin/statuses/{sha}","languages_url":"https://api.github.com/repos/smoketurner/dropwizard-zipkin/languages","stargazers_url":"https://api.github.com/repos/smoketurner/dropwizard-zipkin/stargazers","contributors_url":"https://api.github.com/repos/smoketurner/dropwizard-zipkin/contributors","subscribers_url":"https://api.github.com/repos/smoketurner/dropwizard-zipkin/subscribers","subscription_url":"https://api.github.com/repos/smoketurner/dropwizard-zipkin/subscription","commits_url":"https://api.github.com/repos/smoketurner/dropwizard-zipkin/commits{/sha}","git_commits_url":"https://api.github.com/repos/smoketurner/dropwizard-zipkin/git/commits{/sha}","comments_url":"https://api.github.com/repos/smoketurner/dropwizard-zipkin/comments{/number}","issue_comment_url":"https://api.github.com/repos/smoketurner/dropwizard-zipkin/issues/comments{/number}","contents_url":"https://api.github.com/repos/smoketurner/dropwizard-zipkin/contents/{+path}","compare_url":"https://api.github.com/repos/smoketurner/dropwizard-zipkin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smoketurner/dropwizard-zipkin/merges","archive_url":"https://api.github.com/repos/smoketurner/dropwizard-zipkin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smoketurner/dropwizard-zipkin/downloads","issues_url":"https://api.github.com/repos/smoketurner/dropwizard-zipkin/issues{/number}","pulls_url":"https://api.github.com/repos/smoketurner/dropwizard-zipkin/pulls{/number}","milestones_url":"https://api.github.com/repos/smoketurner/dropwizard-zipkin/milestones{/number}","notifications_url":"https://api.github.com/repos/smoketurner/dropwizard-zipkin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smoketurner/dropwizard-zipkin/labels{/name}","releases_url":"https://api.github.com/repos/smoketurner/dropwizard-zipkin/releases{/id}","deployments_url":"https://api.github.com/repos/smoketurner/dropwizard-zipkin/deployments","created_at":"2016-02-07T22:19:54Z","updated_at":"2016-09-29T22:00:21Z","pushed_at":"2016-10-05T13:51:30Z","git_url":"git://github.com/smoketurner/dropwizard-zipkin.git","ssh_url":"git@github.com:smoketurner/dropwizard-zipkin.git","clone_url":"https://github.com/smoketurner/dropwizard-zipkin.git","svn_url":"https://github.com/smoketurner/dropwizard-zipkin","homepage":"http://smoketurner.github.io/dropwizard-zipkin/1.0.2-2/","size":1878,"stargazers_count":19,"watchers_count":19,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":6,"mirror_url":null,"open_issues_count":2,"forks":6,"open_issues":2,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/smoketurner/dropwizard-zipkin/pulls/12"},"html":{"href":"https://github.com/smoketurner/dropwizard-zipkin/pull/12"},"issue":{"href":"https://api.github.com/repos/smoketurner/dropwizard-zipkin/issues/12"},"comments":{"href":"https://api.github.com/repos/smoketurner/dropwizard-zipkin/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/smoketurner/dropwizard-zipkin/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/smoketurner/dropwizard-zipkin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/smoketurner/dropwizard-zipkin/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/smoketurner/dropwizard-zipkin/statuses/23f9958b146a29e8e9c902d1452ef01ab7a81243"}}}}
{"actor":{"display_login":"adriancole"}}