{"action":"created","comment":{"url":"https://api.github.com/repos/tendermint/tendermint/pulls/comments/61655464","id":61655464,"diff_hunk":"@@ -500,6 +500,16 @@ OUTER_LOOP:\n \t\t\t}\n \t\t}\n \n+\t\t// if the peer lags by one, but it has all the pieces,\n+\t\t// there may have been a double signing,\n+\t\t// so send a random vote from last commit\n+\t\tif prs.Height != 0 && rs.Height == prs.Height+1 {\n+\t\t\tif ps.PickSendVoteAny(rs.LastCommit) {\n+\t\t\t\tlog.Info(\"Picked random rs.LastCommit to send because peer still lags but has all votes\")\n+\t\t\t}\n+\t\t\t// don't continue OUTER_LOOP","path":"consensus/reactor.go","position":24,"original_position":24,"commit_id":"8025b056403c3996659baac62c2b2f0485b15da2","original_commit_id":"8025b056403c3996659baac62c2b2f0485b15da2","user":{"login":"jaekwon","id":53785,"avatar_url":"https://avatars.githubusercontent.com/u/53785?v=3","gravatar_id":"","url":"https://api.github.com/users/jaekwon","html_url":"https://github.com/jaekwon","followers_url":"https://api.github.com/users/jaekwon/followers","following_url":"https://api.github.com/users/jaekwon/following{/other_user}","gists_url":"https://api.github.com/users/jaekwon/gists{/gist_id}","starred_url":"https://api.github.com/users/jaekwon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaekwon/subscriptions","organizations_url":"https://api.github.com/users/jaekwon/orgs","repos_url":"https://api.github.com/users/jaekwon/repos","events_url":"https://api.github.com/users/jaekwon/events{/privacy}","received_events_url":"https://api.github.com/users/jaekwon/received_events","type":"User","site_admin":false},"body":"why not continue OUTER_LOOP?","created_at":"2016-04-29T22:57:44Z","updated_at":"2016-04-29T22:57:44Z","html_url":"https://github.com/tendermint/tendermint/pull/210#discussion_r61655464","pull_request_url":"https://api.github.com/repos/tendermint/tendermint/pulls/210","_links":{"self":{"href":"https://api.github.com/repos/tendermint/tendermint/pulls/comments/61655464"},"html":{"href":"https://github.com/tendermint/tendermint/pull/210#discussion_r61655464"},"pull_request":{"href":"https://api.github.com/repos/tendermint/tendermint/pulls/210"}}},"pull_request":{"url":"https://api.github.com/repos/tendermint/tendermint/pulls/210","id":67116220,"html_url":"https://github.com/tendermint/tendermint/pull/210","diff_url":"https://github.com/tendermint/tendermint/pull/210.diff","patch_url":"https://github.com/tendermint/tendermint/pull/210.patch","issue_url":"https://api.github.com/repos/tendermint/tendermint/issues/210","number":210,"state":"open","locked":false,"title":"Bft fix","user":{"login":"ebuchman","id":2300911,"avatar_url":"https://avatars.githubusercontent.com/u/2300911?v=3","gravatar_id":"","url":"https://api.github.com/users/ebuchman","html_url":"https://github.com/ebuchman","followers_url":"https://api.github.com/users/ebuchman/followers","following_url":"https://api.github.com/users/ebuchman/following{/other_user}","gists_url":"https://api.github.com/users/ebuchman/gists{/gist_id}","starred_url":"https://api.github.com/users/ebuchman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebuchman/subscriptions","organizations_url":"https://api.github.com/users/ebuchman/orgs","repos_url":"https://api.github.com/users/ebuchman/repos","events_url":"https://api.github.com/users/ebuchman/events{/privacy}","received_events_url":"https://api.github.com/users/ebuchman/received_events","type":"User","site_admin":false},"body":"Fix bug where consensus may halt if there is a byzantine voter. \r\nSince we only keep a bit array of our peer's votes, if a validator publishes two conflicting votes,\r\npeers might only see one, while there's supposed to be consensus on the other. \r\nThe fix here is naiive: if the peer has votes from all validators but isn't moving to the next round, send a random vote.\r\nA more involved solution would be to track the actual block hash each peer has received votes for, and use that to send the missing vote in the gossip routine.\r\n\r\nThis bug was uncovered by implementing byzantine behaviour, as seen in https://github.com/tendermint/tendermint/commit/94e591ee1cdddd925838db91b42fa93fc9a701bc (branch https://github.com/tendermint/tendermint/tree/byzantine)","created_at":"2016-04-20T01:34:19Z","updated_at":"2016-04-29T22:57:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3d54b6d2282e614e5ba9f279ccf2b147a17cbb1d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/tendermint/tendermint/pulls/210/commits","review_comments_url":"https://api.github.com/repos/tendermint/tendermint/pulls/210/comments","review_comment_url":"https://api.github.com/repos/tendermint/tendermint/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tendermint/tendermint/issues/210/comments","statuses_url":"https://api.github.com/repos/tendermint/tendermint/statuses/8025b056403c3996659baac62c2b2f0485b15da2","head":{"label":"tendermint:bft_fix","ref":"bft_fix","sha":"8025b056403c3996659baac62c2b2f0485b15da2","user":{"login":"tendermint","id":7572940,"avatar_url":"https://avatars.githubusercontent.com/u/7572940?v=3","gravatar_id":"","url":"https://api.github.com/users/tendermint","html_url":"https://github.com/tendermint","followers_url":"https://api.github.com/users/tendermint/followers","following_url":"https://api.github.com/users/tendermint/following{/other_user}","gists_url":"https://api.github.com/users/tendermint/gists{/gist_id}","starred_url":"https://api.github.com/users/tendermint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tendermint/subscriptions","organizations_url":"https://api.github.com/users/tendermint/orgs","repos_url":"https://api.github.com/users/tendermint/repos","events_url":"https://api.github.com/users/tendermint/events{/privacy}","received_events_url":"https://api.github.com/users/tendermint/received_events","type":"Organization","site_admin":false},"repo":{"id":19799491,"name":"tendermint","full_name":"tendermint/tendermint","owner":{"login":"tendermint","id":7572940,"avatar_url":"https://avatars.githubusercontent.com/u/7572940?v=3","gravatar_id":"","url":"https://api.github.com/users/tendermint","html_url":"https://github.com/tendermint","followers_url":"https://api.github.com/users/tendermint/followers","following_url":"https://api.github.com/users/tendermint/following{/other_user}","gists_url":"https://api.github.com/users/tendermint/gists{/gist_id}","starred_url":"https://api.github.com/users/tendermint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tendermint/subscriptions","organizations_url":"https://api.github.com/users/tendermint/orgs","repos_url":"https://api.github.com/users/tendermint/repos","events_url":"https://api.github.com/users/tendermint/events{/privacy}","received_events_url":"https://api.github.com/users/tendermint/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tendermint/tendermint","description":"Tendermint in Go","fork":false,"url":"https://api.github.com/repos/tendermint/tendermint","forks_url":"https://api.github.com/repos/tendermint/tendermint/forks","keys_url":"https://api.github.com/repos/tendermint/tendermint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tendermint/tendermint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tendermint/tendermint/teams","hooks_url":"https://api.github.com/repos/tendermint/tendermint/hooks","issue_events_url":"https://api.github.com/repos/tendermint/tendermint/issues/events{/number}","events_url":"https://api.github.com/repos/tendermint/tendermint/events","assignees_url":"https://api.github.com/repos/tendermint/tendermint/assignees{/user}","branches_url":"https://api.github.com/repos/tendermint/tendermint/branches{/branch}","tags_url":"https://api.github.com/repos/tendermint/tendermint/tags","blobs_url":"https://api.github.com/repos/tendermint/tendermint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tendermint/tendermint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tendermint/tendermint/git/refs{/sha}","trees_url":"https://api.github.com/repos/tendermint/tendermint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tendermint/tendermint/statuses/{sha}","languages_url":"https://api.github.com/repos/tendermint/tendermint/languages","stargazers_url":"https://api.github.com/repos/tendermint/tendermint/stargazers","contributors_url":"https://api.github.com/repos/tendermint/tendermint/contributors","subscribers_url":"https://api.github.com/repos/tendermint/tendermint/subscribers","subscription_url":"https://api.github.com/repos/tendermint/tendermint/subscription","commits_url":"https://api.github.com/repos/tendermint/tendermint/commits{/sha}","git_commits_url":"https://api.github.com/repos/tendermint/tendermint/git/commits{/sha}","comments_url":"https://api.github.com/repos/tendermint/tendermint/comments{/number}","issue_comment_url":"https://api.github.com/repos/tendermint/tendermint/issues/comments{/number}","contents_url":"https://api.github.com/repos/tendermint/tendermint/contents/{+path}","compare_url":"https://api.github.com/repos/tendermint/tendermint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tendermint/tendermint/merges","archive_url":"https://api.github.com/repos/tendermint/tendermint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tendermint/tendermint/downloads","issues_url":"https://api.github.com/repos/tendermint/tendermint/issues{/number}","pulls_url":"https://api.github.com/repos/tendermint/tendermint/pulls{/number}","milestones_url":"https://api.github.com/repos/tendermint/tendermint/milestones{/number}","notifications_url":"https://api.github.com/repos/tendermint/tendermint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tendermint/tendermint/labels{/name}","releases_url":"https://api.github.com/repos/tendermint/tendermint/releases{/id}","deployments_url":"https://api.github.com/repos/tendermint/tendermint/deployments","created_at":"2014-05-14T23:21:35Z","updated_at":"2016-04-28T02:41:01Z","pushed_at":"2016-04-29T22:33:01Z","git_url":"git://github.com/tendermint/tendermint.git","ssh_url":"git@github.com:tendermint/tendermint.git","clone_url":"https://github.com/tendermint/tendermint.git","svn_url":"https://github.com/tendermint/tendermint","homepage":"http://tendermint.com/","size":5255,"stargazers_count":231,"watchers_count":231,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":32,"mirror_url":null,"open_issues_count":32,"forks":32,"open_issues":32,"watchers":231,"default_branch":"master"}},"base":{"label":"tendermint:master","ref":"master","sha":"0df4a723e9d189db26577a2a7b17652e8f1fd2f4","user":{"login":"tendermint","id":7572940,"avatar_url":"https://avatars.githubusercontent.com/u/7572940?v=3","gravatar_id":"","url":"https://api.github.com/users/tendermint","html_url":"https://github.com/tendermint","followers_url":"https://api.github.com/users/tendermint/followers","following_url":"https://api.github.com/users/tendermint/following{/other_user}","gists_url":"https://api.github.com/users/tendermint/gists{/gist_id}","starred_url":"https://api.github.com/users/tendermint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tendermint/subscriptions","organizations_url":"https://api.github.com/users/tendermint/orgs","repos_url":"https://api.github.com/users/tendermint/repos","events_url":"https://api.github.com/users/tendermint/events{/privacy}","received_events_url":"https://api.github.com/users/tendermint/received_events","type":"Organization","site_admin":false},"repo":{"id":19799491,"name":"tendermint","full_name":"tendermint/tendermint","owner":{"login":"tendermint","id":7572940,"avatar_url":"https://avatars.githubusercontent.com/u/7572940?v=3","gravatar_id":"","url":"https://api.github.com/users/tendermint","html_url":"https://github.com/tendermint","followers_url":"https://api.github.com/users/tendermint/followers","following_url":"https://api.github.com/users/tendermint/following{/other_user}","gists_url":"https://api.github.com/users/tendermint/gists{/gist_id}","starred_url":"https://api.github.com/users/tendermint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tendermint/subscriptions","organizations_url":"https://api.github.com/users/tendermint/orgs","repos_url":"https://api.github.com/users/tendermint/repos","events_url":"https://api.github.com/users/tendermint/events{/privacy}","received_events_url":"https://api.github.com/users/tendermint/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tendermint/tendermint","description":"Tendermint in Go","fork":false,"url":"https://api.github.com/repos/tendermint/tendermint","forks_url":"https://api.github.com/repos/tendermint/tendermint/forks","keys_url":"https://api.github.com/repos/tendermint/tendermint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tendermint/tendermint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tendermint/tendermint/teams","hooks_url":"https://api.github.com/repos/tendermint/tendermint/hooks","issue_events_url":"https://api.github.com/repos/tendermint/tendermint/issues/events{/number}","events_url":"https://api.github.com/repos/tendermint/tendermint/events","assignees_url":"https://api.github.com/repos/tendermint/tendermint/assignees{/user}","branches_url":"https://api.github.com/repos/tendermint/tendermint/branches{/branch}","tags_url":"https://api.github.com/repos/tendermint/tendermint/tags","blobs_url":"https://api.github.com/repos/tendermint/tendermint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tendermint/tendermint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tendermint/tendermint/git/refs{/sha}","trees_url":"https://api.github.com/repos/tendermint/tendermint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tendermint/tendermint/statuses/{sha}","languages_url":"https://api.github.com/repos/tendermint/tendermint/languages","stargazers_url":"https://api.github.com/repos/tendermint/tendermint/stargazers","contributors_url":"https://api.github.com/repos/tendermint/tendermint/contributors","subscribers_url":"https://api.github.com/repos/tendermint/tendermint/subscribers","subscription_url":"https://api.github.com/repos/tendermint/tendermint/subscription","commits_url":"https://api.github.com/repos/tendermint/tendermint/commits{/sha}","git_commits_url":"https://api.github.com/repos/tendermint/tendermint/git/commits{/sha}","comments_url":"https://api.github.com/repos/tendermint/tendermint/comments{/number}","issue_comment_url":"https://api.github.com/repos/tendermint/tendermint/issues/comments{/number}","contents_url":"https://api.github.com/repos/tendermint/tendermint/contents/{+path}","compare_url":"https://api.github.com/repos/tendermint/tendermint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tendermint/tendermint/merges","archive_url":"https://api.github.com/repos/tendermint/tendermint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tendermint/tendermint/downloads","issues_url":"https://api.github.com/repos/tendermint/tendermint/issues{/number}","pulls_url":"https://api.github.com/repos/tendermint/tendermint/pulls{/number}","milestones_url":"https://api.github.com/repos/tendermint/tendermint/milestones{/number}","notifications_url":"https://api.github.com/repos/tendermint/tendermint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tendermint/tendermint/labels{/name}","releases_url":"https://api.github.com/repos/tendermint/tendermint/releases{/id}","deployments_url":"https://api.github.com/repos/tendermint/tendermint/deployments","created_at":"2014-05-14T23:21:35Z","updated_at":"2016-04-28T02:41:01Z","pushed_at":"2016-04-29T22:33:01Z","git_url":"git://github.com/tendermint/tendermint.git","ssh_url":"git@github.com:tendermint/tendermint.git","clone_url":"https://github.com/tendermint/tendermint.git","svn_url":"https://github.com/tendermint/tendermint","homepage":"http://tendermint.com/","size":5255,"stargazers_count":231,"watchers_count":231,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":32,"mirror_url":null,"open_issues_count":32,"forks":32,"open_issues":32,"watchers":231,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tendermint/tendermint/pulls/210"},"html":{"href":"https://github.com/tendermint/tendermint/pull/210"},"issue":{"href":"https://api.github.com/repos/tendermint/tendermint/issues/210"},"comments":{"href":"https://api.github.com/repos/tendermint/tendermint/issues/210/comments"},"review_comments":{"href":"https://api.github.com/repos/tendermint/tendermint/pulls/210/comments"},"review_comment":{"href":"https://api.github.com/repos/tendermint/tendermint/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tendermint/tendermint/pulls/210/commits"},"statuses":{"href":"https://api.github.com/repos/tendermint/tendermint/statuses/8025b056403c3996659baac62c2b2f0485b15da2"}}}}