{"action":"created","comment":{"url":"https://api.github.com/repos/ripple/rippled/pulls/comments/73940264","id":73940264,"diff_hunk":"@@ -31,14 +32,11 @@\n \n namespace ripple {\n \n-// NIKB NOTE: This function is only used by strUnHex (std::string const& strSrc)\n-// which results in a pointless copy from std::string into std::vector. Should\n-// we just scrap this function altogether?\n-int strUnHex (std::string& strDst, std::string const& strSrc)\n+std::pair<Blob, bool> strUnHex (std::string const& strSrc)","path":"src/ripple/basics/impl/StringUtilities.cpp","position":16,"original_position":16,"commit_id":"48cca3668a74d4c6866732561ad3583ac4f56b89","original_commit_id":"48cca3668a74d4c6866732561ad3583ac4f56b89","user":{"login":"nbougalis","id":5085415,"avatar_url":"https://avatars.githubusercontent.com/u/5085415?v=3","gravatar_id":"","url":"https://api.github.com/users/nbougalis","html_url":"https://github.com/nbougalis","followers_url":"https://api.github.com/users/nbougalis/followers","following_url":"https://api.github.com/users/nbougalis/following{/other_user}","gists_url":"https://api.github.com/users/nbougalis/gists{/gist_id}","starred_url":"https://api.github.com/users/nbougalis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nbougalis/subscriptions","organizations_url":"https://api.github.com/users/nbougalis/orgs","repos_url":"https://api.github.com/users/nbougalis/repos","events_url":"https://api.github.com/users/nbougalis/events{/privacy}","received_events_url":"https://api.github.com/users/nbougalis/received_events","type":"User","site_admin":false},"body":"Should we just scrap this function (and its encoder) and go with `boost::hex` and `boost::unhex`? Here's the [documentation](http://www.boost.org/doc/libs/1_61_0/libs/algorithm/doc/html/the_boost_algorithm_library/Misc/hex.html), but it's a header-only library which we already use and reduces the code that we need to write.\r\n","created_at":"2016-08-08T19:42:15Z","updated_at":"2016-08-08T19:42:15Z","html_url":"https://github.com/ripple/rippled/pull/1803#discussion_r73940264","pull_request_url":"https://api.github.com/repos/ripple/rippled/pulls/1803","_links":{"self":{"href":"https://api.github.com/repos/ripple/rippled/pulls/comments/73940264"},"html":{"href":"https://github.com/ripple/rippled/pull/1803#discussion_r73940264"},"pull_request":{"href":"https://api.github.com/repos/ripple/rippled/pulls/1803"}}},"pull_request":{"url":"https://api.github.com/repos/ripple/rippled/pulls/1803","id":80290424,"html_url":"https://github.com/ripple/rippled/pull/1803","diff_url":"https://github.com/ripple/rippled/pull/1803.diff","patch_url":"https://github.com/ripple/rippled/pull/1803.patch","issue_url":"https://api.github.com/repos/ripple/rippled/issues/1803","number":1803,"state":"open","locked":false,"title":"refactor uses of strCopy (RIPD-1256)","user":{"login":"mellery451","id":463430,"avatar_url":"https://avatars.githubusercontent.com/u/463430?v=3","gravatar_id":"","url":"https://api.github.com/users/mellery451","html_url":"https://github.com/mellery451","followers_url":"https://api.github.com/users/mellery451/followers","following_url":"https://api.github.com/users/mellery451/following{/other_user}","gists_url":"https://api.github.com/users/mellery451/gists{/gist_id}","starred_url":"https://api.github.com/users/mellery451/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mellery451/subscriptions","organizations_url":"https://api.github.com/users/mellery451/orgs","repos_url":"https://api.github.com/users/mellery451/repos","events_url":"https://api.github.com/users/mellery451/events{/privacy}","received_events_url":"https://api.github.com/users/mellery451/received_events","type":"User","site_admin":false},"body":"Details\r\n-------\r\n\r\nstrCopy is for making Blobs from string and vice-versa. It's used\r\nsparsely in the code and can be replaced with Slice. Some of the SHAMap\r\nnode interfaces were changed to use Slice instead of Blob, which should\r\neliminate a copy. Followed code-comment-suggestion by NIKB to merge the two strUnHex methods.","created_at":"2016-08-05T18:56:01Z","updated_at":"2016-08-08T19:42:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"17c11a90bf6f6b106873e11b4c47f5e2dcdcab0e","assignee":{"login":"vinniefalco","id":1503976,"avatar_url":"https://avatars.githubusercontent.com/u/1503976?v=3","gravatar_id":"","url":"https://api.github.com/users/vinniefalco","html_url":"https://github.com/vinniefalco","followers_url":"https://api.github.com/users/vinniefalco/followers","following_url":"https://api.github.com/users/vinniefalco/following{/other_user}","gists_url":"https://api.github.com/users/vinniefalco/gists{/gist_id}","starred_url":"https://api.github.com/users/vinniefalco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vinniefalco/subscriptions","organizations_url":"https://api.github.com/users/vinniefalco/orgs","repos_url":"https://api.github.com/users/vinniefalco/repos","events_url":"https://api.github.com/users/vinniefalco/events{/privacy}","received_events_url":"https://api.github.com/users/vinniefalco/received_events","type":"User","site_admin":false},"assignees":[{"login":"vinniefalco","id":1503976,"avatar_url":"https://avatars.githubusercontent.com/u/1503976?v=3","gravatar_id":"","url":"https://api.github.com/users/vinniefalco","html_url":"https://github.com/vinniefalco","followers_url":"https://api.github.com/users/vinniefalco/followers","following_url":"https://api.github.com/users/vinniefalco/following{/other_user}","gists_url":"https://api.github.com/users/vinniefalco/gists{/gist_id}","starred_url":"https://api.github.com/users/vinniefalco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vinniefalco/subscriptions","organizations_url":"https://api.github.com/users/vinniefalco/orgs","repos_url":"https://api.github.com/users/vinniefalco/repos","events_url":"https://api.github.com/users/vinniefalco/events{/privacy}","received_events_url":"https://api.github.com/users/vinniefalco/received_events","type":"User","site_admin":false},{"login":"nbougalis","id":5085415,"avatar_url":"https://avatars.githubusercontent.com/u/5085415?v=3","gravatar_id":"","url":"https://api.github.com/users/nbougalis","html_url":"https://github.com/nbougalis","followers_url":"https://api.github.com/users/nbougalis/followers","following_url":"https://api.github.com/users/nbougalis/following{/other_user}","gists_url":"https://api.github.com/users/nbougalis/gists{/gist_id}","starred_url":"https://api.github.com/users/nbougalis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nbougalis/subscriptions","organizations_url":"https://api.github.com/users/nbougalis/orgs","repos_url":"https://api.github.com/users/nbougalis/repos","events_url":"https://api.github.com/users/nbougalis/events{/privacy}","received_events_url":"https://api.github.com/users/nbougalis/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ripple/rippled/pulls/1803/commits","review_comments_url":"https://api.github.com/repos/ripple/rippled/pulls/1803/comments","review_comment_url":"https://api.github.com/repos/ripple/rippled/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ripple/rippled/issues/1803/comments","statuses_url":"https://api.github.com/repos/ripple/rippled/statuses/48cca3668a74d4c6866732561ad3583ac4f56b89","head":{"label":"mellery451:refactor_strcopy","ref":"refactor_strcopy","sha":"48cca3668a74d4c6866732561ad3583ac4f56b89","user":{"login":"mellery451","id":463430,"avatar_url":"https://avatars.githubusercontent.com/u/463430?v=3","gravatar_id":"","url":"https://api.github.com/users/mellery451","html_url":"https://github.com/mellery451","followers_url":"https://api.github.com/users/mellery451/followers","following_url":"https://api.github.com/users/mellery451/following{/other_user}","gists_url":"https://api.github.com/users/mellery451/gists{/gist_id}","starred_url":"https://api.github.com/users/mellery451/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mellery451/subscriptions","organizations_url":"https://api.github.com/users/mellery451/orgs","repos_url":"https://api.github.com/users/mellery451/repos","events_url":"https://api.github.com/users/mellery451/events{/privacy}","received_events_url":"https://api.github.com/users/mellery451/received_events","type":"User","site_admin":false},"repo":{"id":63169724,"name":"rippled","full_name":"mellery451/rippled","owner":{"login":"mellery451","id":463430,"avatar_url":"https://avatars.githubusercontent.com/u/463430?v=3","gravatar_id":"","url":"https://api.github.com/users/mellery451","html_url":"https://github.com/mellery451","followers_url":"https://api.github.com/users/mellery451/followers","following_url":"https://api.github.com/users/mellery451/following{/other_user}","gists_url":"https://api.github.com/users/mellery451/gists{/gist_id}","starred_url":"https://api.github.com/users/mellery451/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mellery451/subscriptions","organizations_url":"https://api.github.com/users/mellery451/orgs","repos_url":"https://api.github.com/users/mellery451/repos","events_url":"https://api.github.com/users/mellery451/events{/privacy}","received_events_url":"https://api.github.com/users/mellery451/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mellery451/rippled","description":"Ripple peer-to-peer network daemon","fork":true,"url":"https://api.github.com/repos/mellery451/rippled","forks_url":"https://api.github.com/repos/mellery451/rippled/forks","keys_url":"https://api.github.com/repos/mellery451/rippled/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mellery451/rippled/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mellery451/rippled/teams","hooks_url":"https://api.github.com/repos/mellery451/rippled/hooks","issue_events_url":"https://api.github.com/repos/mellery451/rippled/issues/events{/number}","events_url":"https://api.github.com/repos/mellery451/rippled/events","assignees_url":"https://api.github.com/repos/mellery451/rippled/assignees{/user}","branches_url":"https://api.github.com/repos/mellery451/rippled/branches{/branch}","tags_url":"https://api.github.com/repos/mellery451/rippled/tags","blobs_url":"https://api.github.com/repos/mellery451/rippled/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mellery451/rippled/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mellery451/rippled/git/refs{/sha}","trees_url":"https://api.github.com/repos/mellery451/rippled/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mellery451/rippled/statuses/{sha}","languages_url":"https://api.github.com/repos/mellery451/rippled/languages","stargazers_url":"https://api.github.com/repos/mellery451/rippled/stargazers","contributors_url":"https://api.github.com/repos/mellery451/rippled/contributors","subscribers_url":"https://api.github.com/repos/mellery451/rippled/subscribers","subscription_url":"https://api.github.com/repos/mellery451/rippled/subscription","commits_url":"https://api.github.com/repos/mellery451/rippled/commits{/sha}","git_commits_url":"https://api.github.com/repos/mellery451/rippled/git/commits{/sha}","comments_url":"https://api.github.com/repos/mellery451/rippled/comments{/number}","issue_comment_url":"https://api.github.com/repos/mellery451/rippled/issues/comments{/number}","contents_url":"https://api.github.com/repos/mellery451/rippled/contents/{+path}","compare_url":"https://api.github.com/repos/mellery451/rippled/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mellery451/rippled/merges","archive_url":"https://api.github.com/repos/mellery451/rippled/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mellery451/rippled/downloads","issues_url":"https://api.github.com/repos/mellery451/rippled/issues{/number}","pulls_url":"https://api.github.com/repos/mellery451/rippled/pulls{/number}","milestones_url":"https://api.github.com/repos/mellery451/rippled/milestones{/number}","notifications_url":"https://api.github.com/repos/mellery451/rippled/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mellery451/rippled/labels{/name}","releases_url":"https://api.github.com/repos/mellery451/rippled/releases{/id}","deployments_url":"https://api.github.com/repos/mellery451/rippled/deployments","created_at":"2016-07-12T15:29:01Z","updated_at":"2016-07-12T15:29:12Z","pushed_at":"2016-08-05T19:09:17Z","git_url":"git://github.com/mellery451/rippled.git","ssh_url":"git@github.com:mellery451/rippled.git","clone_url":"https://github.com/mellery451/rippled.git","svn_url":"https://github.com/mellery451/rippled","homepage":"https://ripple.com","size":59721,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"ripple:develop","ref":"develop","sha":"2ca18670d212b0559cc64bcbc0ce3f6905177733","user":{"login":"ripple","id":3165523,"avatar_url":"https://avatars.githubusercontent.com/u/3165523?v=3","gravatar_id":"","url":"https://api.github.com/users/ripple","html_url":"https://github.com/ripple","followers_url":"https://api.github.com/users/ripple/followers","following_url":"https://api.github.com/users/ripple/following{/other_user}","gists_url":"https://api.github.com/users/ripple/gists{/gist_id}","starred_url":"https://api.github.com/users/ripple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ripple/subscriptions","organizations_url":"https://api.github.com/users/ripple/orgs","repos_url":"https://api.github.com/users/ripple/repos","events_url":"https://api.github.com/users/ripple/events{/privacy}","received_events_url":"https://api.github.com/users/ripple/received_events","type":"Organization","site_admin":false},"repo":{"id":2724167,"name":"rippled","full_name":"ripple/rippled","owner":{"login":"ripple","id":3165523,"avatar_url":"https://avatars.githubusercontent.com/u/3165523?v=3","gravatar_id":"","url":"https://api.github.com/users/ripple","html_url":"https://github.com/ripple","followers_url":"https://api.github.com/users/ripple/followers","following_url":"https://api.github.com/users/ripple/following{/other_user}","gists_url":"https://api.github.com/users/ripple/gists{/gist_id}","starred_url":"https://api.github.com/users/ripple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ripple/subscriptions","organizations_url":"https://api.github.com/users/ripple/orgs","repos_url":"https://api.github.com/users/ripple/repos","events_url":"https://api.github.com/users/ripple/events{/privacy}","received_events_url":"https://api.github.com/users/ripple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ripple/rippled","description":"Ripple peer-to-peer network daemon","fork":false,"url":"https://api.github.com/repos/ripple/rippled","forks_url":"https://api.github.com/repos/ripple/rippled/forks","keys_url":"https://api.github.com/repos/ripple/rippled/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ripple/rippled/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ripple/rippled/teams","hooks_url":"https://api.github.com/repos/ripple/rippled/hooks","issue_events_url":"https://api.github.com/repos/ripple/rippled/issues/events{/number}","events_url":"https://api.github.com/repos/ripple/rippled/events","assignees_url":"https://api.github.com/repos/ripple/rippled/assignees{/user}","branches_url":"https://api.github.com/repos/ripple/rippled/branches{/branch}","tags_url":"https://api.github.com/repos/ripple/rippled/tags","blobs_url":"https://api.github.com/repos/ripple/rippled/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ripple/rippled/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ripple/rippled/git/refs{/sha}","trees_url":"https://api.github.com/repos/ripple/rippled/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ripple/rippled/statuses/{sha}","languages_url":"https://api.github.com/repos/ripple/rippled/languages","stargazers_url":"https://api.github.com/repos/ripple/rippled/stargazers","contributors_url":"https://api.github.com/repos/ripple/rippled/contributors","subscribers_url":"https://api.github.com/repos/ripple/rippled/subscribers","subscription_url":"https://api.github.com/repos/ripple/rippled/subscription","commits_url":"https://api.github.com/repos/ripple/rippled/commits{/sha}","git_commits_url":"https://api.github.com/repos/ripple/rippled/git/commits{/sha}","comments_url":"https://api.github.com/repos/ripple/rippled/comments{/number}","issue_comment_url":"https://api.github.com/repos/ripple/rippled/issues/comments{/number}","contents_url":"https://api.github.com/repos/ripple/rippled/contents/{+path}","compare_url":"https://api.github.com/repos/ripple/rippled/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ripple/rippled/merges","archive_url":"https://api.github.com/repos/ripple/rippled/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ripple/rippled/downloads","issues_url":"https://api.github.com/repos/ripple/rippled/issues{/number}","pulls_url":"https://api.github.com/repos/ripple/rippled/pulls{/number}","milestones_url":"https://api.github.com/repos/ripple/rippled/milestones{/number}","notifications_url":"https://api.github.com/repos/ripple/rippled/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ripple/rippled/labels{/name}","releases_url":"https://api.github.com/repos/ripple/rippled/releases{/id}","deployments_url":"https://api.github.com/repos/ripple/rippled/deployments","created_at":"2011-11-07T04:40:15Z","updated_at":"2016-08-05T04:31:36Z","pushed_at":"2016-08-08T18:01:45Z","git_url":"git://github.com/ripple/rippled.git","ssh_url":"git@github.com:ripple/rippled.git","clone_url":"https://github.com/ripple/rippled.git","svn_url":"https://github.com/ripple/rippled","homepage":"https://ripple.com","size":113052,"stargazers_count":1120,"watchers_count":1120,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":338,"mirror_url":null,"open_issues_count":119,"forks":338,"open_issues":119,"watchers":1120,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ripple/rippled/pulls/1803"},"html":{"href":"https://github.com/ripple/rippled/pull/1803"},"issue":{"href":"https://api.github.com/repos/ripple/rippled/issues/1803"},"comments":{"href":"https://api.github.com/repos/ripple/rippled/issues/1803/comments"},"review_comments":{"href":"https://api.github.com/repos/ripple/rippled/pulls/1803/comments"},"review_comment":{"href":"https://api.github.com/repos/ripple/rippled/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ripple/rippled/pulls/1803/commits"},"statuses":{"href":"https://api.github.com/repos/ripple/rippled/statuses/48cca3668a74d4c6866732561ad3583ac4f56b89"}}}}
{"actor":{"display_login":"nbougalis"}}