{"action":"created","comment":{"url":"https://api.github.com/repos/convox/rack/pulls/comments/63298869","id":63298869,"diff_hunk":"@@ -6,3 +6,5 @@ web:\n   ports:\n     - 80:4000\n     - 443:4001\n+  volumes:","path":"cmd/convox/templates/init/rails/docker-compose.yml","position":4,"original_position":4,"commit_id":"7e9d47089f490d75b8f509a8a186efe1435e83e2","original_commit_id":"7e9d47089f490d75b8f509a8a186efe1435e83e2","user":{"login":"ddollar","id":3308,"avatar_url":"https://avatars.githubusercontent.com/u/3308?v=3","gravatar_id":"","url":"https://api.github.com/users/ddollar","html_url":"https://github.com/ddollar","followers_url":"https://api.github.com/users/ddollar/followers","following_url":"https://api.github.com/users/ddollar/following{/other_user}","gists_url":"https://api.github.com/users/ddollar/gists{/gist_id}","starred_url":"https://api.github.com/users/ddollar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ddollar/subscriptions","organizations_url":"https://api.github.com/users/ddollar/orgs","repos_url":"https://api.github.com/users/ddollar/repos","events_url":"https://api.github.com/users/ddollar/events{/privacy}","received_events_url":"https://api.github.com/users/ddollar/received_events","type":"User","site_admin":false},"body":"They aren't hardcoded into images as they can be overwritten with a future COPY. They are just good defaults that the large majority of users should not need to tweak. For those that do we can provide a method to go power mode. ","created_at":"2016-05-15T22:14:20Z","updated_at":"2016-05-15T22:14:20Z","html_url":"https://github.com/convox/rack/pull/635#discussion_r63298869","pull_request_url":"https://api.github.com/repos/convox/rack/pulls/635","_links":{"self":{"href":"https://api.github.com/repos/convox/rack/pulls/comments/63298869"},"html":{"href":"https://github.com/convox/rack/pull/635#discussion_r63298869"},"pull_request":{"href":"https://api.github.com/repos/convox/rack/pulls/635"}}},"pull_request":{"url":"https://api.github.com/repos/convox/rack/pulls/635","id":70109125,"html_url":"https://github.com/convox/rack/pull/635","diff_url":"https://github.com/convox/rack/pull/635.diff","patch_url":"https://github.com/convox/rack/pull/635.patch","issue_url":"https://api.github.com/repos/convox/rack/issues/635","number":635,"state":"open","locked":false,"title":"Rails init","user":{"login":"mattmanning","id":44615,"avatar_url":"https://avatars.githubusercontent.com/u/44615?v=3","gravatar_id":"","url":"https://api.github.com/users/mattmanning","html_url":"https://github.com/mattmanning","followers_url":"https://api.github.com/users/mattmanning/followers","following_url":"https://api.github.com/users/mattmanning/following{/other_user}","gists_url":"https://api.github.com/users/mattmanning/gists{/gist_id}","starred_url":"https://api.github.com/users/mattmanning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattmanning/subscriptions","organizations_url":"https://api.github.com/users/mattmanning/orgs","repos_url":"https://api.github.com/users/mattmanning/repos","events_url":"https://api.github.com/users/mattmanning/events{/privacy}","received_events_url":"https://api.github.com/users/mattmanning/received_events","type":"User","site_admin":false},"body":"This PR contains some changes to `convox init` to make getting started with Rails a little smoother.\r\n\r\n* The generated `docker-compose.yml` not includes a `.:/app` volume mount\r\n* `bin/web` is generated and removes `tmp/pids/server.pid` before starting Rails to avoid errors\r\n*  `.dockerignore` and `config/initializers/convox.rb` are generated\r\n\r\n## Release Playbook\r\n- [ ] Rebase against master\r\n- [ ] Release branch ()\r\n- [ ] Pass CI ()\r\n- [ ] Code review\r\n- [ ] Merge into master\r\n- [ ] Release master ()\r\n- [ ] Pass CI ()\r\n- [ ] Update staging rack\r\n- [ ] Edit [Rack release record](https://github.com/convox/rack/releases) and/or update [docs](https://github.com/convox/convox.github.io)\r\n- [ ] Publish release\r\n- [ ] Release CLI\r\n","created_at":"2016-05-15T01:30:25Z","updated_at":"2016-05-15T22:14:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cc3f6b824f5f0f33712b346e2b3194fe483b4bad","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/convox/rack/pulls/635/commits","review_comments_url":"https://api.github.com/repos/convox/rack/pulls/635/comments","review_comment_url":"https://api.github.com/repos/convox/rack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/convox/rack/issues/635/comments","statuses_url":"https://api.github.com/repos/convox/rack/statuses/7e9d47089f490d75b8f509a8a186efe1435e83e2","head":{"label":"convox:rails-init","ref":"rails-init","sha":"7e9d47089f490d75b8f509a8a186efe1435e83e2","user":{"login":"convox","id":10547780,"avatar_url":"https://avatars.githubusercontent.com/u/10547780?v=3","gravatar_id":"","url":"https://api.github.com/users/convox","html_url":"https://github.com/convox","followers_url":"https://api.github.com/users/convox/followers","following_url":"https://api.github.com/users/convox/following{/other_user}","gists_url":"https://api.github.com/users/convox/gists{/gist_id}","starred_url":"https://api.github.com/users/convox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/convox/subscriptions","organizations_url":"https://api.github.com/users/convox/orgs","repos_url":"https://api.github.com/users/convox/repos","events_url":"https://api.github.com/users/convox/events{/privacy}","received_events_url":"https://api.github.com/users/convox/received_events","type":"Organization","site_admin":false},"repo":{"id":42454540,"name":"rack","full_name":"convox/rack","owner":{"login":"convox","id":10547780,"avatar_url":"https://avatars.githubusercontent.com/u/10547780?v=3","gravatar_id":"","url":"https://api.github.com/users/convox","html_url":"https://github.com/convox","followers_url":"https://api.github.com/users/convox/followers","following_url":"https://api.github.com/users/convox/following{/other_user}","gists_url":"https://api.github.com/users/convox/gists{/gist_id}","starred_url":"https://api.github.com/users/convox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/convox/subscriptions","organizations_url":"https://api.github.com/users/convox/orgs","repos_url":"https://api.github.com/users/convox/repos","events_url":"https://api.github.com/users/convox/events{/privacy}","received_events_url":"https://api.github.com/users/convox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/convox/rack","description":"Open-source PaaS on AWS","fork":false,"url":"https://api.github.com/repos/convox/rack","forks_url":"https://api.github.com/repos/convox/rack/forks","keys_url":"https://api.github.com/repos/convox/rack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/convox/rack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/convox/rack/teams","hooks_url":"https://api.github.com/repos/convox/rack/hooks","issue_events_url":"https://api.github.com/repos/convox/rack/issues/events{/number}","events_url":"https://api.github.com/repos/convox/rack/events","assignees_url":"https://api.github.com/repos/convox/rack/assignees{/user}","branches_url":"https://api.github.com/repos/convox/rack/branches{/branch}","tags_url":"https://api.github.com/repos/convox/rack/tags","blobs_url":"https://api.github.com/repos/convox/rack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/convox/rack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/convox/rack/git/refs{/sha}","trees_url":"https://api.github.com/repos/convox/rack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/convox/rack/statuses/{sha}","languages_url":"https://api.github.com/repos/convox/rack/languages","stargazers_url":"https://api.github.com/repos/convox/rack/stargazers","contributors_url":"https://api.github.com/repos/convox/rack/contributors","subscribers_url":"https://api.github.com/repos/convox/rack/subscribers","subscription_url":"https://api.github.com/repos/convox/rack/subscription","commits_url":"https://api.github.com/repos/convox/rack/commits{/sha}","git_commits_url":"https://api.github.com/repos/convox/rack/git/commits{/sha}","comments_url":"https://api.github.com/repos/convox/rack/comments{/number}","issue_comment_url":"https://api.github.com/repos/convox/rack/issues/comments{/number}","contents_url":"https://api.github.com/repos/convox/rack/contents/{+path}","compare_url":"https://api.github.com/repos/convox/rack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/convox/rack/merges","archive_url":"https://api.github.com/repos/convox/rack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/convox/rack/downloads","issues_url":"https://api.github.com/repos/convox/rack/issues{/number}","pulls_url":"https://api.github.com/repos/convox/rack/pulls{/number}","milestones_url":"https://api.github.com/repos/convox/rack/milestones{/number}","notifications_url":"https://api.github.com/repos/convox/rack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/convox/rack/labels{/name}","releases_url":"https://api.github.com/repos/convox/rack/releases{/id}","deployments_url":"https://api.github.com/repos/convox/rack/deployments","created_at":"2015-09-14T14:41:30Z","updated_at":"2016-05-15T20:40:02Z","pushed_at":"2016-05-15T08:20:39Z","git_url":"git://github.com/convox/rack.git","ssh_url":"git@github.com:convox/rack.git","clone_url":"https://github.com/convox/rack.git","svn_url":"https://github.com/convox/rack","homepage":"https://convox.com","size":47628,"stargazers_count":1121,"watchers_count":1121,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":71,"mirror_url":null,"open_issues_count":106,"forks":71,"open_issues":106,"watchers":1121,"default_branch":"master"}},"base":{"label":"convox:master","ref":"master","sha":"301fa806a6dbf43fcec8015e5a773ea11723a760","user":{"login":"convox","id":10547780,"avatar_url":"https://avatars.githubusercontent.com/u/10547780?v=3","gravatar_id":"","url":"https://api.github.com/users/convox","html_url":"https://github.com/convox","followers_url":"https://api.github.com/users/convox/followers","following_url":"https://api.github.com/users/convox/following{/other_user}","gists_url":"https://api.github.com/users/convox/gists{/gist_id}","starred_url":"https://api.github.com/users/convox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/convox/subscriptions","organizations_url":"https://api.github.com/users/convox/orgs","repos_url":"https://api.github.com/users/convox/repos","events_url":"https://api.github.com/users/convox/events{/privacy}","received_events_url":"https://api.github.com/users/convox/received_events","type":"Organization","site_admin":false},"repo":{"id":42454540,"name":"rack","full_name":"convox/rack","owner":{"login":"convox","id":10547780,"avatar_url":"https://avatars.githubusercontent.com/u/10547780?v=3","gravatar_id":"","url":"https://api.github.com/users/convox","html_url":"https://github.com/convox","followers_url":"https://api.github.com/users/convox/followers","following_url":"https://api.github.com/users/convox/following{/other_user}","gists_url":"https://api.github.com/users/convox/gists{/gist_id}","starred_url":"https://api.github.com/users/convox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/convox/subscriptions","organizations_url":"https://api.github.com/users/convox/orgs","repos_url":"https://api.github.com/users/convox/repos","events_url":"https://api.github.com/users/convox/events{/privacy}","received_events_url":"https://api.github.com/users/convox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/convox/rack","description":"Open-source PaaS on AWS","fork":false,"url":"https://api.github.com/repos/convox/rack","forks_url":"https://api.github.com/repos/convox/rack/forks","keys_url":"https://api.github.com/repos/convox/rack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/convox/rack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/convox/rack/teams","hooks_url":"https://api.github.com/repos/convox/rack/hooks","issue_events_url":"https://api.github.com/repos/convox/rack/issues/events{/number}","events_url":"https://api.github.com/repos/convox/rack/events","assignees_url":"https://api.github.com/repos/convox/rack/assignees{/user}","branches_url":"https://api.github.com/repos/convox/rack/branches{/branch}","tags_url":"https://api.github.com/repos/convox/rack/tags","blobs_url":"https://api.github.com/repos/convox/rack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/convox/rack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/convox/rack/git/refs{/sha}","trees_url":"https://api.github.com/repos/convox/rack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/convox/rack/statuses/{sha}","languages_url":"https://api.github.com/repos/convox/rack/languages","stargazers_url":"https://api.github.com/repos/convox/rack/stargazers","contributors_url":"https://api.github.com/repos/convox/rack/contributors","subscribers_url":"https://api.github.com/repos/convox/rack/subscribers","subscription_url":"https://api.github.com/repos/convox/rack/subscription","commits_url":"https://api.github.com/repos/convox/rack/commits{/sha}","git_commits_url":"https://api.github.com/repos/convox/rack/git/commits{/sha}","comments_url":"https://api.github.com/repos/convox/rack/comments{/number}","issue_comment_url":"https://api.github.com/repos/convox/rack/issues/comments{/number}","contents_url":"https://api.github.com/repos/convox/rack/contents/{+path}","compare_url":"https://api.github.com/repos/convox/rack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/convox/rack/merges","archive_url":"https://api.github.com/repos/convox/rack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/convox/rack/downloads","issues_url":"https://api.github.com/repos/convox/rack/issues{/number}","pulls_url":"https://api.github.com/repos/convox/rack/pulls{/number}","milestones_url":"https://api.github.com/repos/convox/rack/milestones{/number}","notifications_url":"https://api.github.com/repos/convox/rack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/convox/rack/labels{/name}","releases_url":"https://api.github.com/repos/convox/rack/releases{/id}","deployments_url":"https://api.github.com/repos/convox/rack/deployments","created_at":"2015-09-14T14:41:30Z","updated_at":"2016-05-15T20:40:02Z","pushed_at":"2016-05-15T08:20:39Z","git_url":"git://github.com/convox/rack.git","ssh_url":"git@github.com:convox/rack.git","clone_url":"https://github.com/convox/rack.git","svn_url":"https://github.com/convox/rack","homepage":"https://convox.com","size":47628,"stargazers_count":1121,"watchers_count":1121,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":71,"mirror_url":null,"open_issues_count":106,"forks":71,"open_issues":106,"watchers":1121,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/convox/rack/pulls/635"},"html":{"href":"https://github.com/convox/rack/pull/635"},"issue":{"href":"https://api.github.com/repos/convox/rack/issues/635"},"comments":{"href":"https://api.github.com/repos/convox/rack/issues/635/comments"},"review_comments":{"href":"https://api.github.com/repos/convox/rack/pulls/635/comments"},"review_comment":{"href":"https://api.github.com/repos/convox/rack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/convox/rack/pulls/635/commits"},"statuses":{"href":"https://api.github.com/repos/convox/rack/statuses/7e9d47089f490d75b8f509a8a186efe1435e83e2"}}}}