{"action":"closed","number":53,"pull_request":{"url":"https://api.github.com/repos/openzipkin/zipkin-js/pulls/53","id":89010350,"html_url":"https://github.com/openzipkin/zipkin-js/pull/53","diff_url":"https://github.com/openzipkin/zipkin-js/pull/53.diff","patch_url":"https://github.com/openzipkin/zipkin-js/pull/53.patch","issue_url":"https://api.github.com/repos/openzipkin/zipkin-js/issues/53","number":53,"state":"closed","locked":false,"title":"Adds remoteServiceName which maps to the ServerAddr binary annotation","user":{"login":"adriancole","id":64215,"avatar_url":"https://avatars.githubusercontent.com/u/64215?v=3","gravatar_id":"","url":"https://api.github.com/users/adriancole","html_url":"https://github.com/adriancole","followers_url":"https://api.github.com/users/adriancole/followers","following_url":"https://api.github.com/users/adriancole/following{/other_user}","gists_url":"https://api.github.com/users/adriancole/gists{/gist_id}","starred_url":"https://api.github.com/users/adriancole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adriancole/subscriptions","organizations_url":"https://api.github.com/users/adriancole/orgs","repos_url":"https://api.github.com/users/adriancole/repos","events_url":"https://api.github.com/users/adriancole/events{/privacy}","received_events_url":"https://api.github.com/users/adriancole/received_events","type":"User","site_admin":false},"body":"The ServerAddr(\"sa\") annotation is used to indicate the server. This is\r\nused for uninstrumented clients, such as redis. When used properly, the\r\nZipkin dependencies graph will show those who call into such services.\r\n\r\nThis adds an option `remoteServiceName` which hints the name of the\r\npeer. Where possible, other endpoint information such as host and port\r\nare added.\r\n\r\nFixes #52","created_at":"2016-10-12T12:55:05Z","updated_at":"2016-10-12T14:38:18Z","closed_at":"2016-10-12T14:38:18Z","merged_at":"2016-10-12T14:38:18Z","merge_commit_sha":"3c2b12f3875ad856d7039dc5ada0c5dfbb1ae431","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/openzipkin/zipkin-js/pulls/53/commits","review_comments_url":"https://api.github.com/repos/openzipkin/zipkin-js/pulls/53/comments","review_comment_url":"https://api.github.com/repos/openzipkin/zipkin-js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openzipkin/zipkin-js/issues/53/comments","statuses_url":"https://api.github.com/repos/openzipkin/zipkin-js/statuses/11bdd30851c0e920dc01211ca37727fad62533ac","head":{"label":"openzipkin:sa","ref":"sa","sha":"11bdd30851c0e920dc01211ca37727fad62533ac","user":{"login":"openzipkin","id":11860887,"avatar_url":"https://avatars.githubusercontent.com/u/11860887?v=3","gravatar_id":"","url":"https://api.github.com/users/openzipkin","html_url":"https://github.com/openzipkin","followers_url":"https://api.github.com/users/openzipkin/followers","following_url":"https://api.github.com/users/openzipkin/following{/other_user}","gists_url":"https://api.github.com/users/openzipkin/gists{/gist_id}","starred_url":"https://api.github.com/users/openzipkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openzipkin/subscriptions","organizations_url":"https://api.github.com/users/openzipkin/orgs","repos_url":"https://api.github.com/users/openzipkin/repos","events_url":"https://api.github.com/users/openzipkin/events{/privacy}","received_events_url":"https://api.github.com/users/openzipkin/received_events","type":"Organization","site_admin":false},"repo":{"id":58535548,"name":"zipkin-js","full_name":"openzipkin/zipkin-js","owner":{"login":"openzipkin","id":11860887,"avatar_url":"https://avatars.githubusercontent.com/u/11860887?v=3","gravatar_id":"","url":"https://api.github.com/users/openzipkin","html_url":"https://github.com/openzipkin","followers_url":"https://api.github.com/users/openzipkin/followers","following_url":"https://api.github.com/users/openzipkin/following{/other_user}","gists_url":"https://api.github.com/users/openzipkin/gists{/gist_id}","starred_url":"https://api.github.com/users/openzipkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openzipkin/subscriptions","organizations_url":"https://api.github.com/users/openzipkin/orgs","repos_url":"https://api.github.com/users/openzipkin/repos","events_url":"https://api.github.com/users/openzipkin/events{/privacy}","received_events_url":"https://api.github.com/users/openzipkin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openzipkin/zipkin-js","description":"Zipkin instrumentation for Node.js and browsers","fork":false,"url":"https://api.github.com/repos/openzipkin/zipkin-js","forks_url":"https://api.github.com/repos/openzipkin/zipkin-js/forks","keys_url":"https://api.github.com/repos/openzipkin/zipkin-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openzipkin/zipkin-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openzipkin/zipkin-js/teams","hooks_url":"https://api.github.com/repos/openzipkin/zipkin-js/hooks","issue_events_url":"https://api.github.com/repos/openzipkin/zipkin-js/issues/events{/number}","events_url":"https://api.github.com/repos/openzipkin/zipkin-js/events","assignees_url":"https://api.github.com/repos/openzipkin/zipkin-js/assignees{/user}","branches_url":"https://api.github.com/repos/openzipkin/zipkin-js/branches{/branch}","tags_url":"https://api.github.com/repos/openzipkin/zipkin-js/tags","blobs_url":"https://api.github.com/repos/openzipkin/zipkin-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openzipkin/zipkin-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openzipkin/zipkin-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/openzipkin/zipkin-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openzipkin/zipkin-js/statuses/{sha}","languages_url":"https://api.github.com/repos/openzipkin/zipkin-js/languages","stargazers_url":"https://api.github.com/repos/openzipkin/zipkin-js/stargazers","contributors_url":"https://api.github.com/repos/openzipkin/zipkin-js/contributors","subscribers_url":"https://api.github.com/repos/openzipkin/zipkin-js/subscribers","subscription_url":"https://api.github.com/repos/openzipkin/zipkin-js/subscription","commits_url":"https://api.github.com/repos/openzipkin/zipkin-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/openzipkin/zipkin-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/openzipkin/zipkin-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/openzipkin/zipkin-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/openzipkin/zipkin-js/contents/{+path}","compare_url":"https://api.github.com/repos/openzipkin/zipkin-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openzipkin/zipkin-js/merges","archive_url":"https://api.github.com/repos/openzipkin/zipkin-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openzipkin/zipkin-js/downloads","issues_url":"https://api.github.com/repos/openzipkin/zipkin-js/issues{/number}","pulls_url":"https://api.github.com/repos/openzipkin/zipkin-js/pulls{/number}","milestones_url":"https://api.github.com/repos/openzipkin/zipkin-js/milestones{/number}","notifications_url":"https://api.github.com/repos/openzipkin/zipkin-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openzipkin/zipkin-js/labels{/name}","releases_url":"https://api.github.com/repos/openzipkin/zipkin-js/releases{/id}","deployments_url":"https://api.github.com/repos/openzipkin/zipkin-js/deployments","created_at":"2016-05-11T10:28:12Z","updated_at":"2016-10-12T04:57:18Z","pushed_at":"2016-10-12T14:38:18Z","git_url":"git://github.com/openzipkin/zipkin-js.git","ssh_url":"git@github.com:openzipkin/zipkin-js.git","clone_url":"https://github.com/openzipkin/zipkin-js.git","svn_url":"https://github.com/openzipkin/zipkin-js","homepage":"","size":165,"stargazers_count":34,"watchers_count":34,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":12,"forks":15,"open_issues":12,"watchers":34,"default_branch":"master"}},"base":{"label":"openzipkin:master","ref":"master","sha":"30ccdd096bce985861fe6f38b744d868da6d20b5","user":{"login":"openzipkin","id":11860887,"avatar_url":"https://avatars.githubusercontent.com/u/11860887?v=3","gravatar_id":"","url":"https://api.github.com/users/openzipkin","html_url":"https://github.com/openzipkin","followers_url":"https://api.github.com/users/openzipkin/followers","following_url":"https://api.github.com/users/openzipkin/following{/other_user}","gists_url":"https://api.github.com/users/openzipkin/gists{/gist_id}","starred_url":"https://api.github.com/users/openzipkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openzipkin/subscriptions","organizations_url":"https://api.github.com/users/openzipkin/orgs","repos_url":"https://api.github.com/users/openzipkin/repos","events_url":"https://api.github.com/users/openzipkin/events{/privacy}","received_events_url":"https://api.github.com/users/openzipkin/received_events","type":"Organization","site_admin":false},"repo":{"id":58535548,"name":"zipkin-js","full_name":"openzipkin/zipkin-js","owner":{"login":"openzipkin","id":11860887,"avatar_url":"https://avatars.githubusercontent.com/u/11860887?v=3","gravatar_id":"","url":"https://api.github.com/users/openzipkin","html_url":"https://github.com/openzipkin","followers_url":"https://api.github.com/users/openzipkin/followers","following_url":"https://api.github.com/users/openzipkin/following{/other_user}","gists_url":"https://api.github.com/users/openzipkin/gists{/gist_id}","starred_url":"https://api.github.com/users/openzipkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openzipkin/subscriptions","organizations_url":"https://api.github.com/users/openzipkin/orgs","repos_url":"https://api.github.com/users/openzipkin/repos","events_url":"https://api.github.com/users/openzipkin/events{/privacy}","received_events_url":"https://api.github.com/users/openzipkin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openzipkin/zipkin-js","description":"Zipkin instrumentation for Node.js and browsers","fork":false,"url":"https://api.github.com/repos/openzipkin/zipkin-js","forks_url":"https://api.github.com/repos/openzipkin/zipkin-js/forks","keys_url":"https://api.github.com/repos/openzipkin/zipkin-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openzipkin/zipkin-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openzipkin/zipkin-js/teams","hooks_url":"https://api.github.com/repos/openzipkin/zipkin-js/hooks","issue_events_url":"https://api.github.com/repos/openzipkin/zipkin-js/issues/events{/number}","events_url":"https://api.github.com/repos/openzipkin/zipkin-js/events","assignees_url":"https://api.github.com/repos/openzipkin/zipkin-js/assignees{/user}","branches_url":"https://api.github.com/repos/openzipkin/zipkin-js/branches{/branch}","tags_url":"https://api.github.com/repos/openzipkin/zipkin-js/tags","blobs_url":"https://api.github.com/repos/openzipkin/zipkin-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openzipkin/zipkin-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openzipkin/zipkin-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/openzipkin/zipkin-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openzipkin/zipkin-js/statuses/{sha}","languages_url":"https://api.github.com/repos/openzipkin/zipkin-js/languages","stargazers_url":"https://api.github.com/repos/openzipkin/zipkin-js/stargazers","contributors_url":"https://api.github.com/repos/openzipkin/zipkin-js/contributors","subscribers_url":"https://api.github.com/repos/openzipkin/zipkin-js/subscribers","subscription_url":"https://api.github.com/repos/openzipkin/zipkin-js/subscription","commits_url":"https://api.github.com/repos/openzipkin/zipkin-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/openzipkin/zipkin-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/openzipkin/zipkin-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/openzipkin/zipkin-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/openzipkin/zipkin-js/contents/{+path}","compare_url":"https://api.github.com/repos/openzipkin/zipkin-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openzipkin/zipkin-js/merges","archive_url":"https://api.github.com/repos/openzipkin/zipkin-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openzipkin/zipkin-js/downloads","issues_url":"https://api.github.com/repos/openzipkin/zipkin-js/issues{/number}","pulls_url":"https://api.github.com/repos/openzipkin/zipkin-js/pulls{/number}","milestones_url":"https://api.github.com/repos/openzipkin/zipkin-js/milestones{/number}","notifications_url":"https://api.github.com/repos/openzipkin/zipkin-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openzipkin/zipkin-js/labels{/name}","releases_url":"https://api.github.com/repos/openzipkin/zipkin-js/releases{/id}","deployments_url":"https://api.github.com/repos/openzipkin/zipkin-js/deployments","created_at":"2016-05-11T10:28:12Z","updated_at":"2016-10-12T04:57:18Z","pushed_at":"2016-10-12T14:38:18Z","git_url":"git://github.com/openzipkin/zipkin-js.git","ssh_url":"git@github.com:openzipkin/zipkin-js.git","clone_url":"https://github.com/openzipkin/zipkin-js.git","svn_url":"https://github.com/openzipkin/zipkin-js","homepage":"","size":165,"stargazers_count":34,"watchers_count":34,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":12,"forks":15,"open_issues":12,"watchers":34,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openzipkin/zipkin-js/pulls/53"},"html":{"href":"https://github.com/openzipkin/zipkin-js/pull/53"},"issue":{"href":"https://api.github.com/repos/openzipkin/zipkin-js/issues/53"},"comments":{"href":"https://api.github.com/repos/openzipkin/zipkin-js/issues/53/comments"},"review_comments":{"href":"https://api.github.com/repos/openzipkin/zipkin-js/pulls/53/comments"},"review_comment":{"href":"https://api.github.com/repos/openzipkin/zipkin-js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openzipkin/zipkin-js/pulls/53/commits"},"statuses":{"href":"https://api.github.com/repos/openzipkin/zipkin-js/statuses/11bdd30851c0e920dc01211ca37727fad62533ac"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"adriancole","id":64215,"avatar_url":"https://avatars.githubusercontent.com/u/64215?v=3","gravatar_id":"","url":"https://api.github.com/users/adriancole","html_url":"https://github.com/adriancole","followers_url":"https://api.github.com/users/adriancole/followers","following_url":"https://api.github.com/users/adriancole/following{/other_user}","gists_url":"https://api.github.com/users/adriancole/gists{/gist_id}","starred_url":"https://api.github.com/users/adriancole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adriancole/subscriptions","organizations_url":"https://api.github.com/users/adriancole/orgs","repos_url":"https://api.github.com/users/adriancole/repos","events_url":"https://api.github.com/users/adriancole/events{/privacy}","received_events_url":"https://api.github.com/users/adriancole/received_events","type":"User","site_admin":false},"comments":3,"review_comments":1,"commits":1,"additions":233,"deletions":41,"changed_files":17}}
{"actor":{"display_login":"adriancole"}}