{"action":"created","comment":{"url":"https://api.github.com/repos/RackHD/on-core/pulls/comments/52471245","id":52471245,"diff_hunk":"@@ -5,112 +6,255 @@\n \n describe('Connection', function () {\n     var Connection;\n+    var amqp, sandbox = sinon.sandbox.create();\n+\n+    helper.before(function(context) {\n+        context.Core = {\n+            start: sandbox.stub().resolves(),\n+            stop: sandbox.stub().resolves()\n+        };\n \n-    helper.before();\n+        context.amqp = function() {\n+            this.createConnection = sandbox.stub();\n+        };\n+        \n+        return [\n+            helper.di.simpleWrapper(context.Core, 'Services.Core' ),\n+            helper.di.simpleWrapper(context.amqp, 'amqp' )\n+        ]","path":"spec/lib/common/connection-spec.js","position":25,"original_position":25,"commit_id":"69bda749c1a846db365603a09f6b9bbbfc564c99","original_commit_id":"69bda749c1a846db365603a09f6b9bbbfc564c99","user":{"login":"houndci","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"User","site_admin":false},"body":"Missing semicolon.","created_at":"2016-02-10T15:23:25Z","updated_at":"2016-02-10T15:23:25Z","html_url":"https://github.com/RackHD/on-core/pull/83#discussion_r52471245","pull_request_url":"https://api.github.com/repos/RackHD/on-core/pulls/83","_links":{"self":{"href":"https://api.github.com/repos/RackHD/on-core/pulls/comments/52471245"},"html":{"href":"https://github.com/RackHD/on-core/pull/83#discussion_r52471245"},"pull_request":{"href":"https://api.github.com/repos/RackHD/on-core/pulls/83"}}},"pull_request":{"url":"https://api.github.com/repos/RackHD/on-core/pulls/83","id":58905166,"html_url":"https://github.com/RackHD/on-core/pull/83","diff_url":"https://github.com/RackHD/on-core/pull/83.diff","patch_url":"https://github.com/RackHD/on-core/pull/83.patch","issue_url":"https://api.github.com/repos/RackHD/on-core/issues/83","number":83,"state":"open","locked":false,"title":"on-core refactor unit tests","user":{"login":"uppalk1","id":14128586,"avatar_url":"https://avatars.githubusercontent.com/u/14128586?v=3","gravatar_id":"","url":"https://api.github.com/users/uppalk1","html_url":"https://github.com/uppalk1","followers_url":"https://api.github.com/users/uppalk1/followers","following_url":"https://api.github.com/users/uppalk1/following{/other_user}","gists_url":"https://api.github.com/users/uppalk1/gists{/gist_id}","starred_url":"https://api.github.com/users/uppalk1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uppalk1/subscriptions","organizations_url":"https://api.github.com/users/uppalk1/orgs","repos_url":"https://api.github.com/users/uppalk1/repos","events_url":"https://api.github.com/users/uppalk1/events{/privacy}","received_events_url":"https://api.github.com/users/uppalk1/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-02-10T15:22:51Z","updated_at":"2016-02-10T15:23:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"07d116779f031fc2c067e6472e903b90294fecda","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/RackHD/on-core/pulls/83/commits","review_comments_url":"https://api.github.com/repos/RackHD/on-core/pulls/83/comments","review_comment_url":"https://api.github.com/repos/RackHD/on-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RackHD/on-core/issues/83/comments","statuses_url":"https://api.github.com/repos/RackHD/on-core/statuses/69bda749c1a846db365603a09f6b9bbbfc564c99","head":{"label":"uppalk1:kranti-on-core-refactor1","ref":"kranti-on-core-refactor1","sha":"69bda749c1a846db365603a09f6b9bbbfc564c99","user":{"login":"uppalk1","id":14128586,"avatar_url":"https://avatars.githubusercontent.com/u/14128586?v=3","gravatar_id":"","url":"https://api.github.com/users/uppalk1","html_url":"https://github.com/uppalk1","followers_url":"https://api.github.com/users/uppalk1/followers","following_url":"https://api.github.com/users/uppalk1/following{/other_user}","gists_url":"https://api.github.com/users/uppalk1/gists{/gist_id}","starred_url":"https://api.github.com/users/uppalk1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uppalk1/subscriptions","organizations_url":"https://api.github.com/users/uppalk1/orgs","repos_url":"https://api.github.com/users/uppalk1/repos","events_url":"https://api.github.com/users/uppalk1/events{/privacy}","received_events_url":"https://api.github.com/users/uppalk1/received_events","type":"User","site_admin":false},"repo":{"id":50112963,"name":"on-core","full_name":"uppalk1/on-core","owner":{"login":"uppalk1","id":14128586,"avatar_url":"https://avatars.githubusercontent.com/u/14128586?v=3","gravatar_id":"","url":"https://api.github.com/users/uppalk1","html_url":"https://github.com/uppalk1","followers_url":"https://api.github.com/users/uppalk1/followers","following_url":"https://api.github.com/users/uppalk1/following{/other_user}","gists_url":"https://api.github.com/users/uppalk1/gists{/gist_id}","starred_url":"https://api.github.com/users/uppalk1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uppalk1/subscriptions","organizations_url":"https://api.github.com/users/uppalk1/orgs","repos_url":"https://api.github.com/users/uppalk1/repos","events_url":"https://api.github.com/users/uppalk1/events{/privacy}","received_events_url":"https://api.github.com/users/uppalk1/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/uppalk1/on-core","description":"","fork":true,"url":"https://api.github.com/repos/uppalk1/on-core","forks_url":"https://api.github.com/repos/uppalk1/on-core/forks","keys_url":"https://api.github.com/repos/uppalk1/on-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uppalk1/on-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uppalk1/on-core/teams","hooks_url":"https://api.github.com/repos/uppalk1/on-core/hooks","issue_events_url":"https://api.github.com/repos/uppalk1/on-core/issues/events{/number}","events_url":"https://api.github.com/repos/uppalk1/on-core/events","assignees_url":"https://api.github.com/repos/uppalk1/on-core/assignees{/user}","branches_url":"https://api.github.com/repos/uppalk1/on-core/branches{/branch}","tags_url":"https://api.github.com/repos/uppalk1/on-core/tags","blobs_url":"https://api.github.com/repos/uppalk1/on-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uppalk1/on-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uppalk1/on-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/uppalk1/on-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uppalk1/on-core/statuses/{sha}","languages_url":"https://api.github.com/repos/uppalk1/on-core/languages","stargazers_url":"https://api.github.com/repos/uppalk1/on-core/stargazers","contributors_url":"https://api.github.com/repos/uppalk1/on-core/contributors","subscribers_url":"https://api.github.com/repos/uppalk1/on-core/subscribers","subscription_url":"https://api.github.com/repos/uppalk1/on-core/subscription","commits_url":"https://api.github.com/repos/uppalk1/on-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/uppalk1/on-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/uppalk1/on-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/uppalk1/on-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/uppalk1/on-core/contents/{+path}","compare_url":"https://api.github.com/repos/uppalk1/on-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uppalk1/on-core/merges","archive_url":"https://api.github.com/repos/uppalk1/on-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uppalk1/on-core/downloads","issues_url":"https://api.github.com/repos/uppalk1/on-core/issues{/number}","pulls_url":"https://api.github.com/repos/uppalk1/on-core/pulls{/number}","milestones_url":"https://api.github.com/repos/uppalk1/on-core/milestones{/number}","notifications_url":"https://api.github.com/repos/uppalk1/on-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uppalk1/on-core/labels{/name}","releases_url":"https://api.github.com/repos/uppalk1/on-core/releases{/id}","deployments_url":"https://api.github.com/repos/uppalk1/on-core/deployments","created_at":"2016-01-21T14:29:08Z","updated_at":"2016-01-21T14:29:08Z","pushed_at":"2016-02-10T14:57:53Z","git_url":"git://github.com/uppalk1/on-core.git","ssh_url":"git@github.com:uppalk1/on-core.git","clone_url":"https://github.com/uppalk1/on-core.git","svn_url":"https://github.com/uppalk1/on-core","homepage":null,"size":803,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"RackHD:master","ref":"master","sha":"ea389bb25bdd6c890880442730481d78ac6ad052","user":{"login":"RackHD","id":13982662,"avatar_url":"https://avatars.githubusercontent.com/u/13982662?v=3","gravatar_id":"","url":"https://api.github.com/users/RackHD","html_url":"https://github.com/RackHD","followers_url":"https://api.github.com/users/RackHD/followers","following_url":"https://api.github.com/users/RackHD/following{/other_user}","gists_url":"https://api.github.com/users/RackHD/gists{/gist_id}","starred_url":"https://api.github.com/users/RackHD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RackHD/subscriptions","organizations_url":"https://api.github.com/users/RackHD/orgs","repos_url":"https://api.github.com/users/RackHD/repos","events_url":"https://api.github.com/users/RackHD/events{/privacy}","received_events_url":"https://api.github.com/users/RackHD/received_events","type":"Organization","site_admin":false},"repo":{"id":41690044,"name":"on-core","full_name":"RackHD/on-core","owner":{"login":"RackHD","id":13982662,"avatar_url":"https://avatars.githubusercontent.com/u/13982662?v=3","gravatar_id":"","url":"https://api.github.com/users/RackHD","html_url":"https://github.com/RackHD","followers_url":"https://api.github.com/users/RackHD/followers","following_url":"https://api.github.com/users/RackHD/following{/other_user}","gists_url":"https://api.github.com/users/RackHD/gists{/gist_id}","starred_url":"https://api.github.com/users/RackHD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RackHD/subscriptions","organizations_url":"https://api.github.com/users/RackHD/orgs","repos_url":"https://api.github.com/users/RackHD/repos","events_url":"https://api.github.com/users/RackHD/events{/privacy}","received_events_url":"https://api.github.com/users/RackHD/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RackHD/on-core","description":"","fork":false,"url":"https://api.github.com/repos/RackHD/on-core","forks_url":"https://api.github.com/repos/RackHD/on-core/forks","keys_url":"https://api.github.com/repos/RackHD/on-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RackHD/on-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RackHD/on-core/teams","hooks_url":"https://api.github.com/repos/RackHD/on-core/hooks","issue_events_url":"https://api.github.com/repos/RackHD/on-core/issues/events{/number}","events_url":"https://api.github.com/repos/RackHD/on-core/events","assignees_url":"https://api.github.com/repos/RackHD/on-core/assignees{/user}","branches_url":"https://api.github.com/repos/RackHD/on-core/branches{/branch}","tags_url":"https://api.github.com/repos/RackHD/on-core/tags","blobs_url":"https://api.github.com/repos/RackHD/on-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RackHD/on-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RackHD/on-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/RackHD/on-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RackHD/on-core/statuses/{sha}","languages_url":"https://api.github.com/repos/RackHD/on-core/languages","stargazers_url":"https://api.github.com/repos/RackHD/on-core/stargazers","contributors_url":"https://api.github.com/repos/RackHD/on-core/contributors","subscribers_url":"https://api.github.com/repos/RackHD/on-core/subscribers","subscription_url":"https://api.github.com/repos/RackHD/on-core/subscription","commits_url":"https://api.github.com/repos/RackHD/on-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/RackHD/on-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/RackHD/on-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/RackHD/on-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/RackHD/on-core/contents/{+path}","compare_url":"https://api.github.com/repos/RackHD/on-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RackHD/on-core/merges","archive_url":"https://api.github.com/repos/RackHD/on-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RackHD/on-core/downloads","issues_url":"https://api.github.com/repos/RackHD/on-core/issues{/number}","pulls_url":"https://api.github.com/repos/RackHD/on-core/pulls{/number}","milestones_url":"https://api.github.com/repos/RackHD/on-core/milestones{/number}","notifications_url":"https://api.github.com/repos/RackHD/on-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RackHD/on-core/labels{/name}","releases_url":"https://api.github.com/repos/RackHD/on-core/releases{/id}","deployments_url":"https://api.github.com/repos/RackHD/on-core/deployments","created_at":"2015-08-31T17:28:32Z","updated_at":"2016-01-31T09:01:09Z","pushed_at":"2016-02-10T15:22:52Z","git_url":"git://github.com/RackHD/on-core.git","ssh_url":"git@github.com:RackHD/on-core.git","clone_url":"https://github.com/RackHD/on-core.git","svn_url":"https://github.com/RackHD/on-core","homepage":null,"size":883,"stargazers_count":9,"watchers_count":9,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":25,"mirror_url":null,"open_issues_count":4,"forks":25,"open_issues":4,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RackHD/on-core/pulls/83"},"html":{"href":"https://github.com/RackHD/on-core/pull/83"},"issue":{"href":"https://api.github.com/repos/RackHD/on-core/issues/83"},"comments":{"href":"https://api.github.com/repos/RackHD/on-core/issues/83/comments"},"review_comments":{"href":"https://api.github.com/repos/RackHD/on-core/pulls/83/comments"},"review_comment":{"href":"https://api.github.com/repos/RackHD/on-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RackHD/on-core/pulls/83/commits"},"statuses":{"href":"https://api.github.com/repos/RackHD/on-core/statuses/69bda749c1a846db365603a09f6b9bbbfc564c99"}}}}