{"action":"closed","number":260,"pull_request":{"url":"https://api.github.com/repos/Shopify/shopify_app/pulls/260","id":71922856,"html_url":"https://github.com/Shopify/shopify_app/pull/260","diff_url":"https://github.com/Shopify/shopify_app/pull/260.diff","patch_url":"https://github.com/Shopify/shopify_app/pull/260.patch","issue_url":"https://api.github.com/repos/Shopify/shopify_app/issues/260","number":260,"state":"closed","locked":false,"title":"Make it possible to override shopify_token validation","user":{"login":"cyprusad","id":289908,"avatar_url":"https://avatars.githubusercontent.com/u/289908?v=3","gravatar_id":"","url":"https://api.github.com/users/cyprusad","html_url":"https://github.com/cyprusad","followers_url":"https://api.github.com/users/cyprusad/followers","following_url":"https://api.github.com/users/cyprusad/following{/other_user}","gists_url":"https://api.github.com/users/cyprusad/gists{/gist_id}","starred_url":"https://api.github.com/users/cyprusad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyprusad/subscriptions","organizations_url":"https://api.github.com/users/cyprusad/orgs","repos_url":"https://api.github.com/users/cyprusad/repos","events_url":"https://api.github.com/users/cyprusad/events{/privacy}","received_events_url":"https://api.github.com/users/cyprusad/received_events","type":"User","site_admin":false},"body":"I have run into a situation where I wanted to create Shop records that didn't have `shopify_token` created  just yet. Turns out I cannot save a record without them, because the `validates presence: true` condition needs to be satisfied.\r\n\r\nThis change will check if token **needs** to exist by exposing a class method.\r\n\r\nPlease review: @kevinhughes27 @j-mutter ","created_at":"2016-05-30T16:51:59Z","updated_at":"2016-05-30T17:07:06Z","closed_at":"2016-05-30T17:07:06Z","merged_at":null,"merge_commit_sha":"60b33547e4e793154bcbd243c1c51e86a5ddac69","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Shopify/shopify_app/pulls/260/commits","review_comments_url":"https://api.github.com/repos/Shopify/shopify_app/pulls/260/comments","review_comment_url":"https://api.github.com/repos/Shopify/shopify_app/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Shopify/shopify_app/issues/260/comments","statuses_url":"https://api.github.com/repos/Shopify/shopify_app/statuses/3c66abf1f54f871b474006b4e6d25628af286904","head":{"label":"Shopify:optional-token-validation-on-shop","ref":"optional-token-validation-on-shop","sha":"3c66abf1f54f871b474006b4e6d25628af286904","user":{"login":"Shopify","id":8085,"avatar_url":"https://avatars.githubusercontent.com/u/8085?v=3","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"repo":{"id":61203,"name":"shopify_app","full_name":"Shopify/shopify_app","owner":{"login":"Shopify","id":8085,"avatar_url":"https://avatars.githubusercontent.com/u/8085?v=3","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Shopify/shopify_app","description":"Adds a full Shopify API Application environment to your application","fork":false,"url":"https://api.github.com/repos/Shopify/shopify_app","forks_url":"https://api.github.com/repos/Shopify/shopify_app/forks","keys_url":"https://api.github.com/repos/Shopify/shopify_app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Shopify/shopify_app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Shopify/shopify_app/teams","hooks_url":"https://api.github.com/repos/Shopify/shopify_app/hooks","issue_events_url":"https://api.github.com/repos/Shopify/shopify_app/issues/events{/number}","events_url":"https://api.github.com/repos/Shopify/shopify_app/events","assignees_url":"https://api.github.com/repos/Shopify/shopify_app/assignees{/user}","branches_url":"https://api.github.com/repos/Shopify/shopify_app/branches{/branch}","tags_url":"https://api.github.com/repos/Shopify/shopify_app/tags","blobs_url":"https://api.github.com/repos/Shopify/shopify_app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Shopify/shopify_app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Shopify/shopify_app/git/refs{/sha}","trees_url":"https://api.github.com/repos/Shopify/shopify_app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Shopify/shopify_app/statuses/{sha}","languages_url":"https://api.github.com/repos/Shopify/shopify_app/languages","stargazers_url":"https://api.github.com/repos/Shopify/shopify_app/stargazers","contributors_url":"https://api.github.com/repos/Shopify/shopify_app/contributors","subscribers_url":"https://api.github.com/repos/Shopify/shopify_app/subscribers","subscription_url":"https://api.github.com/repos/Shopify/shopify_app/subscription","commits_url":"https://api.github.com/repos/Shopify/shopify_app/commits{/sha}","git_commits_url":"https://api.github.com/repos/Shopify/shopify_app/git/commits{/sha}","comments_url":"https://api.github.com/repos/Shopify/shopify_app/comments{/number}","issue_comment_url":"https://api.github.com/repos/Shopify/shopify_app/issues/comments{/number}","contents_url":"https://api.github.com/repos/Shopify/shopify_app/contents/{+path}","compare_url":"https://api.github.com/repos/Shopify/shopify_app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Shopify/shopify_app/merges","archive_url":"https://api.github.com/repos/Shopify/shopify_app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Shopify/shopify_app/downloads","issues_url":"https://api.github.com/repos/Shopify/shopify_app/issues{/number}","pulls_url":"https://api.github.com/repos/Shopify/shopify_app/pulls{/number}","milestones_url":"https://api.github.com/repos/Shopify/shopify_app/milestones{/number}","notifications_url":"https://api.github.com/repos/Shopify/shopify_app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Shopify/shopify_app/labels{/name}","releases_url":"https://api.github.com/repos/Shopify/shopify_app/releases{/id}","deployments_url":"https://api.github.com/repos/Shopify/shopify_app/deployments","created_at":"2008-10-09T15:10:52Z","updated_at":"2016-05-28T03:42:57Z","pushed_at":"2016-05-30T16:52:00Z","git_url":"git://github.com/Shopify/shopify_app.git","ssh_url":"git@github.com:Shopify/shopify_app.git","clone_url":"https://github.com/Shopify/shopify_app.git","svn_url":"https://github.com/Shopify/shopify_app","homepage":"http://shopify.github.io/shopify_app","size":1297,"stargazers_count":405,"watchers_count":405,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":149,"mirror_url":null,"open_issues_count":14,"forks":149,"open_issues":14,"watchers":405,"default_branch":"master"}},"base":{"label":"Shopify:master","ref":"master","sha":"9165b2eb8af41e90d139e7462ad5d95a82a7b3cc","user":{"login":"Shopify","id":8085,"avatar_url":"https://avatars.githubusercontent.com/u/8085?v=3","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"repo":{"id":61203,"name":"shopify_app","full_name":"Shopify/shopify_app","owner":{"login":"Shopify","id":8085,"avatar_url":"https://avatars.githubusercontent.com/u/8085?v=3","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Shopify/shopify_app","description":"Adds a full Shopify API Application environment to your application","fork":false,"url":"https://api.github.com/repos/Shopify/shopify_app","forks_url":"https://api.github.com/repos/Shopify/shopify_app/forks","keys_url":"https://api.github.com/repos/Shopify/shopify_app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Shopify/shopify_app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Shopify/shopify_app/teams","hooks_url":"https://api.github.com/repos/Shopify/shopify_app/hooks","issue_events_url":"https://api.github.com/repos/Shopify/shopify_app/issues/events{/number}","events_url":"https://api.github.com/repos/Shopify/shopify_app/events","assignees_url":"https://api.github.com/repos/Shopify/shopify_app/assignees{/user}","branches_url":"https://api.github.com/repos/Shopify/shopify_app/branches{/branch}","tags_url":"https://api.github.com/repos/Shopify/shopify_app/tags","blobs_url":"https://api.github.com/repos/Shopify/shopify_app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Shopify/shopify_app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Shopify/shopify_app/git/refs{/sha}","trees_url":"https://api.github.com/repos/Shopify/shopify_app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Shopify/shopify_app/statuses/{sha}","languages_url":"https://api.github.com/repos/Shopify/shopify_app/languages","stargazers_url":"https://api.github.com/repos/Shopify/shopify_app/stargazers","contributors_url":"https://api.github.com/repos/Shopify/shopify_app/contributors","subscribers_url":"https://api.github.com/repos/Shopify/shopify_app/subscribers","subscription_url":"https://api.github.com/repos/Shopify/shopify_app/subscription","commits_url":"https://api.github.com/repos/Shopify/shopify_app/commits{/sha}","git_commits_url":"https://api.github.com/repos/Shopify/shopify_app/git/commits{/sha}","comments_url":"https://api.github.com/repos/Shopify/shopify_app/comments{/number}","issue_comment_url":"https://api.github.com/repos/Shopify/shopify_app/issues/comments{/number}","contents_url":"https://api.github.com/repos/Shopify/shopify_app/contents/{+path}","compare_url":"https://api.github.com/repos/Shopify/shopify_app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Shopify/shopify_app/merges","archive_url":"https://api.github.com/repos/Shopify/shopify_app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Shopify/shopify_app/downloads","issues_url":"https://api.github.com/repos/Shopify/shopify_app/issues{/number}","pulls_url":"https://api.github.com/repos/Shopify/shopify_app/pulls{/number}","milestones_url":"https://api.github.com/repos/Shopify/shopify_app/milestones{/number}","notifications_url":"https://api.github.com/repos/Shopify/shopify_app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Shopify/shopify_app/labels{/name}","releases_url":"https://api.github.com/repos/Shopify/shopify_app/releases{/id}","deployments_url":"https://api.github.com/repos/Shopify/shopify_app/deployments","created_at":"2008-10-09T15:10:52Z","updated_at":"2016-05-28T03:42:57Z","pushed_at":"2016-05-30T16:52:00Z","git_url":"git://github.com/Shopify/shopify_app.git","ssh_url":"git@github.com:Shopify/shopify_app.git","clone_url":"https://github.com/Shopify/shopify_app.git","svn_url":"https://github.com/Shopify/shopify_app","homepage":"http://shopify.github.io/shopify_app","size":1297,"stargazers_count":405,"watchers_count":405,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":149,"mirror_url":null,"open_issues_count":14,"forks":149,"open_issues":14,"watchers":405,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Shopify/shopify_app/pulls/260"},"html":{"href":"https://github.com/Shopify/shopify_app/pull/260"},"issue":{"href":"https://api.github.com/repos/Shopify/shopify_app/issues/260"},"comments":{"href":"https://api.github.com/repos/Shopify/shopify_app/issues/260/comments"},"review_comments":{"href":"https://api.github.com/repos/Shopify/shopify_app/pulls/260/comments"},"review_comment":{"href":"https://api.github.com/repos/Shopify/shopify_app/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Shopify/shopify_app/pulls/260/commits"},"statuses":{"href":"https://api.github.com/repos/Shopify/shopify_app/statuses/3c66abf1f54f871b474006b4e6d25628af286904"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":2,"commits":1,"additions":9,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"cyprusad"}}