{"push_id":1163277000,"size":18,"distinct_size":0,"ref":"refs/heads/master","head":"2526da34556f7d7faaf28a09ec2770274bf65106","before":"c4052d2e8680fc088b66bfb47a5258c7e3901990","commits":[{"sha":"c553628964a2a3743c9ecc6074a422ace2c085f4","author":{"name":"Saleem Abdulrasool","email":"8f7dc4f98448b846b9688d3b02be7b55b820b960@compnerd.org"},"message":"Use `sizeof` for buffer lengths in snprintf\n\nRather than duplicating the constant value, use the `sizeof` operator to have\nthe value propogate from the static buffer allocation.  Any standards conforming\nimplementation of `snprintf` will null-terminate the output unless the buffer is\nNULL (a zero-sized buffer is passed to the call).  On Windows, where this is not\nthe case, the function is named `_snprintf` which ensures that we do not\naccidentally end up with the incorrect behaviour.","distinct":false,"url":"https://api.github.com/repos/austinzheng/swift/commits/c553628964a2a3743c9ecc6074a422ace2c085f4"},{"sha":"e3c2c863d1261106a3100672585afd07f9f51cb0","author":{"name":"Saleem Abdulrasool","email":"8f7dc4f98448b846b9688d3b02be7b55b820b960@compnerd.org"},"message":"stdlib: define `WIN32_LEAN_AND_MEAN` and `NOMINMAX`\n\n`WIN32_LEAN_AND_MEAN` prevents \"rarely-used\" headers from being pulled in.  This\nsignificantly reduced preprocessor pressure, speeding up compile.  It also\nreduces the amount of cruft pulled in by the Windows.h.\n\n`NOMINMAX` ensures that the `min` and `max` macros are not defined.  These\nmacros collide with the use of `min` and `max` from C++ in certain cases: e.g.\n`std::limits<T>`.","distinct":false,"url":"https://api.github.com/repos/austinzheng/swift/commits/e3c2c863d1261106a3100672585afd07f9f51cb0"},{"sha":"8e9734081694e71bea5db925a881b4ae33ea0db2","author":{"name":"Slava Pestov","email":"9e16c7b0af09ed5751f270a67048f3177998c735@apple.com"},"message":"Fix a compiler_crasher test to not depend on specific diagnostics","distinct":false,"url":"https://api.github.com/repos/austinzheng/swift/commits/8e9734081694e71bea5db925a881b4ae33ea0db2"},{"sha":"1c4f5f52ec2dbb50eb0b1aea9e93b66ff6efb642","author":{"name":"Slava Pestov","email":"9e16c7b0af09ed5751f270a67048f3177998c735@apple.com"},"message":"Sema: Fix documentation comment warning","distinct":false,"url":"https://api.github.com/repos/austinzheng/swift/commits/1c4f5f52ec2dbb50eb0b1aea9e93b66ff6efb642"},{"sha":"48fe73f36eeb35758419c1bc1ad45de366f15bb1","author":{"name":"Slava Pestov","email":"9e16c7b0af09ed5751f270a67048f3177998c735@apple.com"},"message":"AST: Tighten up assertions when constructing SILFunctionTypes\n\nIt looks like at one point they could contain the protocol Self\narchetype, but not anymore.","distinct":false,"url":"https://api.github.com/repos/austinzheng/swift/commits/48fe73f36eeb35758419c1bc1ad45de366f15bb1"},{"sha":"448fa67cf8f35e5041497877d0dfbb75324c0f65","author":{"name":"Slava Pestov","email":"9e16c7b0af09ed5751f270a67048f3177998c735@apple.com"},"message":"AST: BoundGenericType should inherit recursive properties from its parent\n\nI don't think this caused any problems until now, but it will\ncome up once the parent type can itself be a BoundGenericType,\nbecause then we need to inherit recursive properties from the\ngeneric arguments.","distinct":false,"url":"https://api.github.com/repos/austinzheng/swift/commits/448fa67cf8f35e5041497877d0dfbb75324c0f65"},{"sha":"5aa22f3d8986b8a9bbb8e2cb28e0e5647bb587de","author":{"name":"Slava Pestov","email":"9e16c7b0af09ed5751f270a67048f3177998c735@apple.com"},"message":"AST: Add some assertions, NFC\n\nEasier to debug if we crash when constructing an invalid Requirement\nrather than later on when we try to do something with it.","distinct":false,"url":"https://api.github.com/repos/austinzheng/swift/commits/5aa22f3d8986b8a9bbb8e2cb28e0e5647bb587de"},{"sha":"92d5bd2404fe88836c067c4b6f6b1185905b6e71","author":{"name":"Slava Pestov","email":"9e16c7b0af09ed5751f270a67048f3177998c735@apple.com"},"message":"Sema: Fix when opening type with minOpeningDepth != 0\n\nThis fixes a regression from my previous patch fixing some issues\nwith nested generic functions:\n\n<https://github.com/apple/swift/commit/bbefeb2fc531d3a939cc8bf832e973a455caa094>","distinct":false,"url":"https://api.github.com/repos/austinzheng/swift/commits/92d5bd2404fe88836c067c4b6f6b1185905b6e71"},{"sha":"e5f0cf93a9dd012e8b59fd639c933b160434d647","author":{"name":"Slava Pestov","email":"9e16c7b0af09ed5751f270a67048f3177998c735@apple.com"},"message":"Sema: Pass down NL_OnlyTypes in a couple more places","distinct":false,"url":"https://api.github.com/repos/austinzheng/swift/commits/e5f0cf93a9dd012e8b59fd639c933b160434d647"},{"sha":"bb6521b9b62a0927becd2e36b0f66f27bef4fc19","author":{"name":"Slava Pestov","email":"9e16c7b0af09ed5751f270a67048f3177998c735@apple.com"},"message":"Sema: Improve a circularity-breaking hack\n\nThe old check was problematic because it would sometimes return\nErrorType from accessing the generic parameters of a type that was\nin the process of having its generic signature validated.\n\nInstead fix the root cause of the circularity, which was recursion\nthrough resolveType() when resolving a type's inheritance clause.\n\nTo fix it, let's just not walk adopted protocols when looking up\nthe superclass of a class. Inheriting from an associated type does\nnot seem very useful, and will probably be hard to get right in\nthe general case.\n\nI wasn't able to reduce a useful test case, but this patch prevents\ncompiler_crashers regressions with some other changes I'm working on.","distinct":false,"url":"https://api.github.com/repos/austinzheng/swift/commits/bb6521b9b62a0927becd2e36b0f66f27bef4fc19"},{"sha":"769a5a2048e976abffbe0c925f7b8e1e762f4aa7","author":{"name":"Slava Pestov","email":"9e16c7b0af09ed5751f270a67048f3177998c735@apple.com"},"message":"Sema: Small cleanups\n\nMostly NFC, but note that DeclContext::getDeclaredInterfaceType()\nreturns Type() for invalid extensions, whereas the older way\nof going through getAsNominalTypeOrNominalTypeExtensionContext()\nwould crash because we'd call getDeclaredInterfaceType() on a\nnull decl.","distinct":false,"url":"https://api.github.com/repos/austinzheng/swift/commits/769a5a2048e976abffbe0c925f7b8e1e762f4aa7"},{"sha":"f5290293e27e348be1110cf39530d55b1a98f2f0","author":{"name":"Slava Pestov","email":"9e16c7b0af09ed5751f270a67048f3177998c735@apple.com"},"message":"Sema: Fix memory corruption in another circularity check\n\nThere was a potential memory corruption issue if the decl was\nalready determined to be part of a cycle by the time we call\nthis function. In this case, we would walk off the end of\nan empty vector.\n\nStart with a non-empty path vector and assert that it is\nnon-empty to avoid this.\n\nI don't have a test for this either, again it fixes regressions\nfrom a future patch here.","distinct":false,"url":"https://api.github.com/repos/austinzheng/swift/commits/f5290293e27e348be1110cf39530d55b1a98f2f0"},{"sha":"4446bc06921e9041bc3fa3f5a8fda7713cd5451a","author":{"name":"Slava Pestov","email":"9e16c7b0af09ed5751f270a67048f3177998c735@apple.com"},"message":"Sema: Use FoldingSetNode for ProtocolType\n\nThere was a weirdness with ProtocolType::get() that was causing me grief\nwhile trying to refactor getDeclaredType() and related code in another\npatch.\n\nInstead of caching the result like we do elsewhere, this would directly\nstore the new type into the ProtocolDecl. This is smelly, so let's not\ndo that.","distinct":false,"url":"https://api.github.com/repos/austinzheng/swift/commits/4446bc06921e9041bc3fa3f5a8fda7713cd5451a"},{"sha":"f6fff1bcefb75d6e71968a0e88f33648278b3ff3","author":{"name":"Slava Pestov","email":"9e16c7b0af09ed5751f270a67048f3177998c735@apple.com"},"message":"Sema: Split off openFunctionType() from openType()\n\n- Change openGeneric() to take two DeclContexts, one is the generic\n  context for the signature and the second is the generic context\n  containing the declaration being opened\n\n- This allows us to clean up the logic around skipProtocolSelfRequirement;\n  instead of testing both the DeclContext and its parent, we know\n  exactly what DeclContext to test. Also, use the right Self type here,\n  instead of always using (0, 0)\n\n- Now that we have the right DeclContexts handy, we can move the\n  getGenericTypeContextDepth() call into openGeneric(), simplifying\n  callers\n\n- Now that openType() no longer opens generic signatures, it takes fewer\n  parameters","distinct":false,"url":"https://api.github.com/repos/austinzheng/swift/commits/f6fff1bcefb75d6e71968a0e88f33648278b3ff3"},{"sha":"bc968c699a8d697dee75ab84eb6cbc4e868a7bd2","author":{"name":"Slava Pestov","email":"9e16c7b0af09ed5751f270a67048f3177998c735@apple.com"},"message":"Sema: Nuke getGenericTypeContextDepth()\n\nNow that ConstraintSystem::openGeneric() is the only remaining\ncaller of this function, inline it in there and open-code the\nlogic.\n\nAlso, add a hack for opening nominal types contained inside\nprotocol types. This is invalid, but we should not crash, so\nbind the type variable for the protocol 'Self' type to the\n'Self' archetype, since it will not be equated with anything\notherwise.","distinct":false,"url":"https://api.github.com/repos/austinzheng/swift/commits/bc968c699a8d697dee75ab84eb6cbc4e868a7bd2"},{"sha":"85d2167cc658f0695b1bd2ce367c54a2e40d846d","author":{"name":"swift-ci","email":"ba4463bdeeb747bfa14a6c06d0b8d74a99982bde@users.noreply.github.com"},"message":"Merge pull request #3036 from compnerd/win32-lean-and-mean","distinct":false,"url":"https://api.github.com/repos/austinzheng/swift/commits/85d2167cc658f0695b1bd2ce367c54a2e40d846d"},{"sha":"7aced279841c58f7c1e4e0c565ca3015b48b46af","author":{"name":"Slava Pestov","email":"229a86a05141b782cb3778d172c6e19213391e62@gmail.com"},"message":"Merge pull request #3045 from slavapestov/open-type-cleanup\n\nSema: Open type cleanup","distinct":false,"url":"https://api.github.com/repos/austinzheng/swift/commits/7aced279841c58f7c1e4e0c565ca3015b48b46af"},{"sha":"2526da34556f7d7faaf28a09ec2770274bf65106","author":{"name":"Dmitri Gribenko","email":"1d361ada365e4964f49a61228b2eb80f416328e4@gmail.com"},"message":"Merge pull request #3037 from compnerd/buffer-lengths\n\nUse `sizeof` for buffer lengths in snprintf","distinct":false,"url":"https://api.github.com/repos/austinzheng/swift/commits/2526da34556f7d7faaf28a09ec2770274bf65106"}]}
{"actor":{"display_login":"austinzheng"}}