{"action":"created","comment":{"url":"https://api.github.com/repos/tomahawk-player/tomahawk/pulls/comments/63961740","id":63961740,"diff_hunk":"@@ -206,22 +206,13 @@ DownloadJob::download()\n {\n     if ( m_state == Running )\n         return true;\n+\n     setState( Running );\n \n-    if ( m_result->resolvedByCollection() )\n-    {\n-        Tomahawk::ScriptCollection* collection = qobject_cast<Tomahawk::ScriptCollection*>( m_result->resolvedByCollection().data() );\n-        if ( collection )\n-        {\n-            QVariantMap arguments;\n-            arguments[ \"url\" ] = m_format.url;\n+    Tomahawk::ScriptJob *job = m_result->resolvedBy()->getDownloadUrl( m_result, m_format );","path":"src/libtomahawk/DownloadJob.cpp","position":14,"original_position":14,"commit_id":"abc00b47586701bb8d77883d97c6964b8d90f40d","original_commit_id":"abc00b47586701bb8d77883d97c6964b8d90f40d","user":{"login":"dschmidt","id":448487,"avatar_url":"https://avatars.githubusercontent.com/u/448487?v=3","gravatar_id":"","url":"https://api.github.com/users/dschmidt","html_url":"https://github.com/dschmidt","followers_url":"https://api.github.com/users/dschmidt/followers","following_url":"https://api.github.com/users/dschmidt/following{/other_user}","gists_url":"https://api.github.com/users/dschmidt/gists{/gist_id}","starred_url":"https://api.github.com/users/dschmidt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dschmidt/subscriptions","organizations_url":"https://api.github.com/users/dschmidt/orgs","repos_url":"https://api.github.com/users/dschmidt/repos","events_url":"https://api.github.com/users/dschmidt/events{/privacy}","received_events_url":"https://api.github.com/users/dschmidt/received_events","type":"User","site_admin":false},"body":"I think you need to check for resolvedBy() not being null","created_at":"2016-05-19T22:01:20Z","updated_at":"2016-05-19T22:01:20Z","html_url":"https://github.com/tomahawk-player/tomahawk/pull/507#discussion_r63961740","pull_request_url":"https://api.github.com/repos/tomahawk-player/tomahawk/pulls/507","_links":{"self":{"href":"https://api.github.com/repos/tomahawk-player/tomahawk/pulls/comments/63961740"},"html":{"href":"https://github.com/tomahawk-player/tomahawk/pull/507#discussion_r63961740"},"pull_request":{"href":"https://api.github.com/repos/tomahawk-player/tomahawk/pulls/507"}}},"pull_request":{"url":"https://api.github.com/repos/tomahawk-player/tomahawk/pulls/507","id":69355365,"html_url":"https://github.com/tomahawk-player/tomahawk/pull/507","diff_url":"https://github.com/tomahawk-player/tomahawk/pull/507.diff","patch_url":"https://github.com/tomahawk-player/tomahawk/pull/507.patch","issue_url":"https://api.github.com/repos/tomahawk-player/tomahawk/issues/507","number":507,"state":"open","locked":false,"title":"Allow downloads from a non-collection resolver","user":{"login":"mickael9","id":341358,"avatar_url":"https://avatars.githubusercontent.com/u/341358?v=3","gravatar_id":"","url":"https://api.github.com/users/mickael9","html_url":"https://github.com/mickael9","followers_url":"https://api.github.com/users/mickael9/followers","following_url":"https://api.github.com/users/mickael9/following{/other_user}","gists_url":"https://api.github.com/users/mickael9/gists{/gist_id}","starred_url":"https://api.github.com/users/mickael9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mickael9/subscriptions","organizations_url":"https://api.github.com/users/mickael9/orgs","repos_url":"https://api.github.com/users/mickael9/repos","events_url":"https://api.github.com/users/mickael9/events{/privacy}","received_events_url":"https://api.github.com/users/mickael9/received_events","type":"User","site_admin":false},"body":"I noticed downloads don't work when results come from a regular (non-collection) resolver, so here is a small fix for that.","created_at":"2016-05-09T14:36:46Z","updated_at":"2016-05-19T22:01:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6e78b7a1b49fbdd806c813fa249276c95e90956d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/tomahawk-player/tomahawk/pulls/507/commits","review_comments_url":"https://api.github.com/repos/tomahawk-player/tomahawk/pulls/507/comments","review_comment_url":"https://api.github.com/repos/tomahawk-player/tomahawk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tomahawk-player/tomahawk/issues/507/comments","statuses_url":"https://api.github.com/repos/tomahawk-player/tomahawk/statuses/abc00b47586701bb8d77883d97c6964b8d90f40d","head":{"label":"mickael9:mickael9-patch-1","ref":"mickael9-patch-1","sha":"abc00b47586701bb8d77883d97c6964b8d90f40d","user":{"login":"mickael9","id":341358,"avatar_url":"https://avatars.githubusercontent.com/u/341358?v=3","gravatar_id":"","url":"https://api.github.com/users/mickael9","html_url":"https://github.com/mickael9","followers_url":"https://api.github.com/users/mickael9/followers","following_url":"https://api.github.com/users/mickael9/following{/other_user}","gists_url":"https://api.github.com/users/mickael9/gists{/gist_id}","starred_url":"https://api.github.com/users/mickael9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mickael9/subscriptions","organizations_url":"https://api.github.com/users/mickael9/orgs","repos_url":"https://api.github.com/users/mickael9/repos","events_url":"https://api.github.com/users/mickael9/events{/privacy}","received_events_url":"https://api.github.com/users/mickael9/received_events","type":"User","site_admin":false},"repo":{"id":58346489,"name":"tomahawk","full_name":"mickael9/tomahawk","owner":{"login":"mickael9","id":341358,"avatar_url":"https://avatars.githubusercontent.com/u/341358?v=3","gravatar_id":"","url":"https://api.github.com/users/mickael9","html_url":"https://github.com/mickael9","followers_url":"https://api.github.com/users/mickael9/followers","following_url":"https://api.github.com/users/mickael9/following{/other_user}","gists_url":"https://api.github.com/users/mickael9/gists{/gist_id}","starred_url":"https://api.github.com/users/mickael9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mickael9/subscriptions","organizations_url":"https://api.github.com/users/mickael9/orgs","repos_url":"https://api.github.com/users/mickael9/repos","events_url":"https://api.github.com/users/mickael9/events{/privacy}","received_events_url":"https://api.github.com/users/mickael9/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mickael9/tomahawk","description":"Tomahawk, the multi-source music player","fork":true,"url":"https://api.github.com/repos/mickael9/tomahawk","forks_url":"https://api.github.com/repos/mickael9/tomahawk/forks","keys_url":"https://api.github.com/repos/mickael9/tomahawk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mickael9/tomahawk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mickael9/tomahawk/teams","hooks_url":"https://api.github.com/repos/mickael9/tomahawk/hooks","issue_events_url":"https://api.github.com/repos/mickael9/tomahawk/issues/events{/number}","events_url":"https://api.github.com/repos/mickael9/tomahawk/events","assignees_url":"https://api.github.com/repos/mickael9/tomahawk/assignees{/user}","branches_url":"https://api.github.com/repos/mickael9/tomahawk/branches{/branch}","tags_url":"https://api.github.com/repos/mickael9/tomahawk/tags","blobs_url":"https://api.github.com/repos/mickael9/tomahawk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mickael9/tomahawk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mickael9/tomahawk/git/refs{/sha}","trees_url":"https://api.github.com/repos/mickael9/tomahawk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mickael9/tomahawk/statuses/{sha}","languages_url":"https://api.github.com/repos/mickael9/tomahawk/languages","stargazers_url":"https://api.github.com/repos/mickael9/tomahawk/stargazers","contributors_url":"https://api.github.com/repos/mickael9/tomahawk/contributors","subscribers_url":"https://api.github.com/repos/mickael9/tomahawk/subscribers","subscription_url":"https://api.github.com/repos/mickael9/tomahawk/subscription","commits_url":"https://api.github.com/repos/mickael9/tomahawk/commits{/sha}","git_commits_url":"https://api.github.com/repos/mickael9/tomahawk/git/commits{/sha}","comments_url":"https://api.github.com/repos/mickael9/tomahawk/comments{/number}","issue_comment_url":"https://api.github.com/repos/mickael9/tomahawk/issues/comments{/number}","contents_url":"https://api.github.com/repos/mickael9/tomahawk/contents/{+path}","compare_url":"https://api.github.com/repos/mickael9/tomahawk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mickael9/tomahawk/merges","archive_url":"https://api.github.com/repos/mickael9/tomahawk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mickael9/tomahawk/downloads","issues_url":"https://api.github.com/repos/mickael9/tomahawk/issues{/number}","pulls_url":"https://api.github.com/repos/mickael9/tomahawk/pulls{/number}","milestones_url":"https://api.github.com/repos/mickael9/tomahawk/milestones{/number}","notifications_url":"https://api.github.com/repos/mickael9/tomahawk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mickael9/tomahawk/labels{/name}","releases_url":"https://api.github.com/repos/mickael9/tomahawk/releases{/id}","deployments_url":"https://api.github.com/repos/mickael9/tomahawk/deployments","created_at":"2016-05-09T03:40:25Z","updated_at":"2016-05-09T03:40:30Z","pushed_at":"2016-05-19T20:14:35Z","git_url":"git://github.com/mickael9/tomahawk.git","ssh_url":"git@github.com:mickael9/tomahawk.git","clone_url":"https://github.com/mickael9/tomahawk.git","svn_url":"https://github.com/mickael9/tomahawk","homepage":"http://tomahawk-player.org","size":128519,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tomahawk-player:master","ref":"master","sha":"77e9b69679ede50a6f9f0325a0dd910b5af59cd3","user":{"login":"tomahawk-player","id":440844,"avatar_url":"https://avatars.githubusercontent.com/u/440844?v=3","gravatar_id":"","url":"https://api.github.com/users/tomahawk-player","html_url":"https://github.com/tomahawk-player","followers_url":"https://api.github.com/users/tomahawk-player/followers","following_url":"https://api.github.com/users/tomahawk-player/following{/other_user}","gists_url":"https://api.github.com/users/tomahawk-player/gists{/gist_id}","starred_url":"https://api.github.com/users/tomahawk-player/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomahawk-player/subscriptions","organizations_url":"https://api.github.com/users/tomahawk-player/orgs","repos_url":"https://api.github.com/users/tomahawk-player/repos","events_url":"https://api.github.com/users/tomahawk-player/events{/privacy}","received_events_url":"https://api.github.com/users/tomahawk-player/received_events","type":"Organization","site_admin":false},"repo":{"id":990035,"name":"tomahawk","full_name":"tomahawk-player/tomahawk","owner":{"login":"tomahawk-player","id":440844,"avatar_url":"https://avatars.githubusercontent.com/u/440844?v=3","gravatar_id":"","url":"https://api.github.com/users/tomahawk-player","html_url":"https://github.com/tomahawk-player","followers_url":"https://api.github.com/users/tomahawk-player/followers","following_url":"https://api.github.com/users/tomahawk-player/following{/other_user}","gists_url":"https://api.github.com/users/tomahawk-player/gists{/gist_id}","starred_url":"https://api.github.com/users/tomahawk-player/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomahawk-player/subscriptions","organizations_url":"https://api.github.com/users/tomahawk-player/orgs","repos_url":"https://api.github.com/users/tomahawk-player/repos","events_url":"https://api.github.com/users/tomahawk-player/events{/privacy}","received_events_url":"https://api.github.com/users/tomahawk-player/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tomahawk-player/tomahawk","description":"Tomahawk, the multi-source music player","fork":false,"url":"https://api.github.com/repos/tomahawk-player/tomahawk","forks_url":"https://api.github.com/repos/tomahawk-player/tomahawk/forks","keys_url":"https://api.github.com/repos/tomahawk-player/tomahawk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tomahawk-player/tomahawk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tomahawk-player/tomahawk/teams","hooks_url":"https://api.github.com/repos/tomahawk-player/tomahawk/hooks","issue_events_url":"https://api.github.com/repos/tomahawk-player/tomahawk/issues/events{/number}","events_url":"https://api.github.com/repos/tomahawk-player/tomahawk/events","assignees_url":"https://api.github.com/repos/tomahawk-player/tomahawk/assignees{/user}","branches_url":"https://api.github.com/repos/tomahawk-player/tomahawk/branches{/branch}","tags_url":"https://api.github.com/repos/tomahawk-player/tomahawk/tags","blobs_url":"https://api.github.com/repos/tomahawk-player/tomahawk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tomahawk-player/tomahawk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tomahawk-player/tomahawk/git/refs{/sha}","trees_url":"https://api.github.com/repos/tomahawk-player/tomahawk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tomahawk-player/tomahawk/statuses/{sha}","languages_url":"https://api.github.com/repos/tomahawk-player/tomahawk/languages","stargazers_url":"https://api.github.com/repos/tomahawk-player/tomahawk/stargazers","contributors_url":"https://api.github.com/repos/tomahawk-player/tomahawk/contributors","subscribers_url":"https://api.github.com/repos/tomahawk-player/tomahawk/subscribers","subscription_url":"https://api.github.com/repos/tomahawk-player/tomahawk/subscription","commits_url":"https://api.github.com/repos/tomahawk-player/tomahawk/commits{/sha}","git_commits_url":"https://api.github.com/repos/tomahawk-player/tomahawk/git/commits{/sha}","comments_url":"https://api.github.com/repos/tomahawk-player/tomahawk/comments{/number}","issue_comment_url":"https://api.github.com/repos/tomahawk-player/tomahawk/issues/comments{/number}","contents_url":"https://api.github.com/repos/tomahawk-player/tomahawk/contents/{+path}","compare_url":"https://api.github.com/repos/tomahawk-player/tomahawk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tomahawk-player/tomahawk/merges","archive_url":"https://api.github.com/repos/tomahawk-player/tomahawk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tomahawk-player/tomahawk/downloads","issues_url":"https://api.github.com/repos/tomahawk-player/tomahawk/issues{/number}","pulls_url":"https://api.github.com/repos/tomahawk-player/tomahawk/pulls{/number}","milestones_url":"https://api.github.com/repos/tomahawk-player/tomahawk/milestones{/number}","notifications_url":"https://api.github.com/repos/tomahawk-player/tomahawk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tomahawk-player/tomahawk/labels{/name}","releases_url":"https://api.github.com/repos/tomahawk-player/tomahawk/releases{/id}","deployments_url":"https://api.github.com/repos/tomahawk-player/tomahawk/deployments","created_at":"2010-10-15T14:21:17Z","updated_at":"2016-05-19T14:32:22Z","pushed_at":"2016-05-19T20:14:36Z","git_url":"git://github.com/tomahawk-player/tomahawk.git","ssh_url":"git@github.com:tomahawk-player/tomahawk.git","clone_url":"https://github.com/tomahawk-player/tomahawk.git","svn_url":"https://github.com/tomahawk-player/tomahawk","homepage":"http://tomahawk-player.org","size":137864,"stargazers_count":1544,"watchers_count":1544,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":290,"mirror_url":null,"open_issues_count":109,"forks":290,"open_issues":109,"watchers":1544,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tomahawk-player/tomahawk/pulls/507"},"html":{"href":"https://github.com/tomahawk-player/tomahawk/pull/507"},"issue":{"href":"https://api.github.com/repos/tomahawk-player/tomahawk/issues/507"},"comments":{"href":"https://api.github.com/repos/tomahawk-player/tomahawk/issues/507/comments"},"review_comments":{"href":"https://api.github.com/repos/tomahawk-player/tomahawk/pulls/507/comments"},"review_comment":{"href":"https://api.github.com/repos/tomahawk-player/tomahawk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tomahawk-player/tomahawk/pulls/507/commits"},"statuses":{"href":"https://api.github.com/repos/tomahawk-player/tomahawk/statuses/abc00b47586701bb8d77883d97c6964b8d90f40d"}}}}
{"actor":{"display_login":"dschmidt"}}