{"action":"created","comment":{"url":"https://api.github.com/repos/docker/swarmkit/pulls/comments/78469737","id":78469737,"diff_hunk":"@@ -0,0 +1,182 @@\n+#!/usr/bin/env python","path":"covertest.py","position":1,"original_position":1,"commit_id":"5f1d812e207800eec38ec6eb6c19218b0221857f","original_commit_id":"5f1d812e207800eec38ec6eb6c19218b0221857f","user":{"login":"stevvooe","id":120601,"avatar_url":"https://avatars.githubusercontent.com/u/120601?v=3","gravatar_id":"","url":"https://api.github.com/users/stevvooe","html_url":"https://github.com/stevvooe","followers_url":"https://api.github.com/users/stevvooe/followers","following_url":"https://api.github.com/users/stevvooe/following{/other_user}","gists_url":"https://api.github.com/users/stevvooe/gists{/gist_id}","starred_url":"https://api.github.com/users/stevvooe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevvooe/subscriptions","organizations_url":"https://api.github.com/users/stevvooe/orgs","repos_url":"https://api.github.com/users/stevvooe/repos","events_url":"https://api.github.com/users/stevvooe/events{/privacy}","received_events_url":"https://api.github.com/users/stevvooe/received_events","type":"User","site_admin":false},"body":"Was this written for this project or copied from elsewhere? Do we really want to start requiring python for this to work?\r\n\r\nI only see this as future technical debt.","created_at":"2016-09-12T22:52:19Z","updated_at":"2016-09-12T22:52:19Z","html_url":"https://github.com/docker/swarmkit/pull/1470#discussion_r78469737","pull_request_url":"https://api.github.com/repos/docker/swarmkit/pulls/1470","_links":{"self":{"href":"https://api.github.com/repos/docker/swarmkit/pulls/comments/78469737"},"html":{"href":"https://github.com/docker/swarmkit/pull/1470#discussion_r78469737"},"pull_request":{"href":"https://api.github.com/repos/docker/swarmkit/pulls/1470"}}},"pull_request":{"url":"https://api.github.com/repos/docker/swarmkit/pulls/1470","id":83188078,"html_url":"https://github.com/docker/swarmkit/pull/1470","diff_url":"https://github.com/docker/swarmkit/pull/1470.diff","patch_url":"https://github.com/docker/swarmkit/pull/1470.patch","issue_url":"https://api.github.com/repos/docker/swarmkit/issues/1470","number":1470,"state":"open","locked":false,"title":"minor codecov change","user":{"login":"cyli","id":223200,"avatar_url":"https://avatars.githubusercontent.com/u/223200?v=3","gravatar_id":"","url":"https://api.github.com/users/cyli","html_url":"https://github.com/cyli","followers_url":"https://api.github.com/users/cyli/followers","following_url":"https://api.github.com/users/cyli/following{/other_user}","gists_url":"https://api.github.com/users/cyli/gists{/gist_id}","starred_url":"https://api.github.com/users/cyli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyli/subscriptions","organizations_url":"https://api.github.com/users/cyli/orgs","repos_url":"https://api.github.com/users/cyli/repos","events_url":"https://api.github.com/users/cyli/events{/privacy}","received_events_url":"https://api.github.com/users/cyli/received_events","type":"User","site_admin":false},"body":"When testing a package, generate code coverage for dependencies of the package as well, so this hopefully reflects a more accurate view of what is and isn't covered.\r\n\r\nhttps://codecov.io/gh/docker/swarmkit/tree/36081de17b5612b844538d5eb9166eb5828c55b7 reflects more files than https://codecov.io/github/docker/swarmkit","created_at":"2016-08-29T23:59:36Z","updated_at":"2016-09-12T22:52:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4f6ae6aa3d4e81d7dc6579267fcb87986106b994","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/docker/swarmkit/pulls/1470/commits","review_comments_url":"https://api.github.com/repos/docker/swarmkit/pulls/1470/comments","review_comment_url":"https://api.github.com/repos/docker/swarmkit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/swarmkit/issues/1470/comments","statuses_url":"https://api.github.com/repos/docker/swarmkit/statuses/5f1d812e207800eec38ec6eb6c19218b0221857f","head":{"label":"cyli:more-accurate-codecov","ref":"more-accurate-codecov","sha":"5f1d812e207800eec38ec6eb6c19218b0221857f","user":{"login":"cyli","id":223200,"avatar_url":"https://avatars.githubusercontent.com/u/223200?v=3","gravatar_id":"","url":"https://api.github.com/users/cyli","html_url":"https://github.com/cyli","followers_url":"https://api.github.com/users/cyli/followers","following_url":"https://api.github.com/users/cyli/following{/other_user}","gists_url":"https://api.github.com/users/cyli/gists{/gist_id}","starred_url":"https://api.github.com/users/cyli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyli/subscriptions","organizations_url":"https://api.github.com/users/cyli/orgs","repos_url":"https://api.github.com/users/cyli/repos","events_url":"https://api.github.com/users/cyli/events{/privacy}","received_events_url":"https://api.github.com/users/cyli/received_events","type":"User","site_admin":false},"repo":{"id":66887622,"name":"swarmkit","full_name":"cyli/swarmkit","owner":{"login":"cyli","id":223200,"avatar_url":"https://avatars.githubusercontent.com/u/223200?v=3","gravatar_id":"","url":"https://api.github.com/users/cyli","html_url":"https://github.com/cyli","followers_url":"https://api.github.com/users/cyli/followers","following_url":"https://api.github.com/users/cyli/following{/other_user}","gists_url":"https://api.github.com/users/cyli/gists{/gist_id}","starred_url":"https://api.github.com/users/cyli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyli/subscriptions","organizations_url":"https://api.github.com/users/cyli/orgs","repos_url":"https://api.github.com/users/cyli/repos","events_url":"https://api.github.com/users/cyli/events{/privacy}","received_events_url":"https://api.github.com/users/cyli/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cyli/swarmkit","description":"A toolkit for orchestrating distributed systems at any scale. It includes primitives for node discovery, raft-based consensus, task scheduling and more.","fork":true,"url":"https://api.github.com/repos/cyli/swarmkit","forks_url":"https://api.github.com/repos/cyli/swarmkit/forks","keys_url":"https://api.github.com/repos/cyli/swarmkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cyli/swarmkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cyli/swarmkit/teams","hooks_url":"https://api.github.com/repos/cyli/swarmkit/hooks","issue_events_url":"https://api.github.com/repos/cyli/swarmkit/issues/events{/number}","events_url":"https://api.github.com/repos/cyli/swarmkit/events","assignees_url":"https://api.github.com/repos/cyli/swarmkit/assignees{/user}","branches_url":"https://api.github.com/repos/cyli/swarmkit/branches{/branch}","tags_url":"https://api.github.com/repos/cyli/swarmkit/tags","blobs_url":"https://api.github.com/repos/cyli/swarmkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cyli/swarmkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cyli/swarmkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/cyli/swarmkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cyli/swarmkit/statuses/{sha}","languages_url":"https://api.github.com/repos/cyli/swarmkit/languages","stargazers_url":"https://api.github.com/repos/cyli/swarmkit/stargazers","contributors_url":"https://api.github.com/repos/cyli/swarmkit/contributors","subscribers_url":"https://api.github.com/repos/cyli/swarmkit/subscribers","subscription_url":"https://api.github.com/repos/cyli/swarmkit/subscription","commits_url":"https://api.github.com/repos/cyli/swarmkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/cyli/swarmkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/cyli/swarmkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/cyli/swarmkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/cyli/swarmkit/contents/{+path}","compare_url":"https://api.github.com/repos/cyli/swarmkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cyli/swarmkit/merges","archive_url":"https://api.github.com/repos/cyli/swarmkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cyli/swarmkit/downloads","issues_url":"https://api.github.com/repos/cyli/swarmkit/issues{/number}","pulls_url":"https://api.github.com/repos/cyli/swarmkit/pulls{/number}","milestones_url":"https://api.github.com/repos/cyli/swarmkit/milestones{/number}","notifications_url":"https://api.github.com/repos/cyli/swarmkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cyli/swarmkit/labels{/name}","releases_url":"https://api.github.com/repos/cyli/swarmkit/releases{/id}","deployments_url":"https://api.github.com/repos/cyli/swarmkit/deployments","created_at":"2016-08-29T23:13:03Z","updated_at":"2016-08-29T23:13:05Z","pushed_at":"2016-09-10T01:10:54Z","git_url":"git://github.com/cyli/swarmkit.git","ssh_url":"git@github.com:cyli/swarmkit.git","clone_url":"https://github.com/cyli/swarmkit.git","svn_url":"https://github.com/cyli/swarmkit","homepage":"","size":9941,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"3cf210e7bc31d4079334be11a58366f1361f3bdc","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":51556828,"name":"swarmkit","full_name":"docker/swarmkit","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/swarmkit","description":"A toolkit for orchestrating distributed systems at any scale. It includes primitives for node discovery, raft-based consensus, task scheduling and more.","fork":false,"url":"https://api.github.com/repos/docker/swarmkit","forks_url":"https://api.github.com/repos/docker/swarmkit/forks","keys_url":"https://api.github.com/repos/docker/swarmkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/swarmkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/swarmkit/teams","hooks_url":"https://api.github.com/repos/docker/swarmkit/hooks","issue_events_url":"https://api.github.com/repos/docker/swarmkit/issues/events{/number}","events_url":"https://api.github.com/repos/docker/swarmkit/events","assignees_url":"https://api.github.com/repos/docker/swarmkit/assignees{/user}","branches_url":"https://api.github.com/repos/docker/swarmkit/branches{/branch}","tags_url":"https://api.github.com/repos/docker/swarmkit/tags","blobs_url":"https://api.github.com/repos/docker/swarmkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/swarmkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/swarmkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/swarmkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/swarmkit/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/swarmkit/languages","stargazers_url":"https://api.github.com/repos/docker/swarmkit/stargazers","contributors_url":"https://api.github.com/repos/docker/swarmkit/contributors","subscribers_url":"https://api.github.com/repos/docker/swarmkit/subscribers","subscription_url":"https://api.github.com/repos/docker/swarmkit/subscription","commits_url":"https://api.github.com/repos/docker/swarmkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/swarmkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/swarmkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/swarmkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/swarmkit/contents/{+path}","compare_url":"https://api.github.com/repos/docker/swarmkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/swarmkit/merges","archive_url":"https://api.github.com/repos/docker/swarmkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/swarmkit/downloads","issues_url":"https://api.github.com/repos/docker/swarmkit/issues{/number}","pulls_url":"https://api.github.com/repos/docker/swarmkit/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/swarmkit/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/swarmkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/swarmkit/labels{/name}","releases_url":"https://api.github.com/repos/docker/swarmkit/releases{/id}","deployments_url":"https://api.github.com/repos/docker/swarmkit/deployments","created_at":"2016-02-12T00:02:15Z","updated_at":"2016-09-12T21:46:20Z","pushed_at":"2016-09-12T22:42:14Z","git_url":"git://github.com/docker/swarmkit.git","ssh_url":"git@github.com:docker/swarmkit.git","clone_url":"https://github.com/docker/swarmkit.git","svn_url":"https://github.com/docker/swarmkit","homepage":"","size":20997,"stargazers_count":932,"watchers_count":932,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":175,"mirror_url":null,"open_issues_count":182,"forks":175,"open_issues":182,"watchers":932,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/swarmkit/pulls/1470"},"html":{"href":"https://github.com/docker/swarmkit/pull/1470"},"issue":{"href":"https://api.github.com/repos/docker/swarmkit/issues/1470"},"comments":{"href":"https://api.github.com/repos/docker/swarmkit/issues/1470/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/swarmkit/pulls/1470/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/swarmkit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/swarmkit/pulls/1470/commits"},"statuses":{"href":"https://api.github.com/repos/docker/swarmkit/statuses/5f1d812e207800eec38ec6eb6c19218b0221857f"}}}}
{"actor":{"display_login":"stevvooe"}}