{"action":"created","comment":{"url":"https://api.github.com/repos/fireeye/flare-floss/pulls/comments/59487097","id":59487097,"diff_hunk":"@@ -333,15 +333,14 @@ def print_stack_strings(extracted_strings, n=4, quiet=False):\n             if len(ss.s) >= n:\n                 print(\"%s\" % (ss.s))\n     else:\n-        extracted_strings = list(extracted_strings)\n-        count = len(filter(lambda s: len(s.s) >= 4, extracted_strings))\n-        print(\"FLOSS extracted %d stack strings\" % (count))\n-        print(\"Function:   Frame offset  String:  \")\n-        print(\"----------  ------------  -------\")\n+        extracted_strings = list(filter(lambda s: len(s.s) >= n, extracted_strings))\n+        count = len(extracted_strings)\n \n-        for ss in extracted_strings:\n-            if len(ss.s) >= n:\n-                print(\"0x%08x  0x%04x    %s\" % (ss.fva, ss.frame_offset, ss.s))\n+        print(\"FLOSS extracted %d stack strings\" % (count))\n+        print(tabulate.tabulate(\n+            [(\"0x%X\" % (s.fva,), \"0x%X\" % (s.frame_offset,), s.s) for s in extracted_strings],","path":"floss/main.py","position":105,"original_position":105,"commit_id":"9f2ab9369c712ffd3d4795a784fd1a48fdeff8f9","original_commit_id":"9f2ab9369c712ffd3d4795a784fd1a48fdeff8f9","user":{"login":"williballenthin","id":156560,"avatar_url":"https://avatars.githubusercontent.com/u/156560?v=3","gravatar_id":"","url":"https://api.github.com/users/williballenthin","html_url":"https://github.com/williballenthin","followers_url":"https://api.github.com/users/williballenthin/followers","following_url":"https://api.github.com/users/williballenthin/following{/other_user}","gists_url":"https://api.github.com/users/williballenthin/gists{/gist_id}","starred_url":"https://api.github.com/users/williballenthin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/williballenthin/subscriptions","organizations_url":"https://api.github.com/users/williballenthin/orgs","repos_url":"https://api.github.com/users/williballenthin/repos","events_url":"https://api.github.com/users/williballenthin/events{/privacy}","received_events_url":"https://api.github.com/users/williballenthin/received_events","type":"User","site_admin":false},"body":"this is even worse...","created_at":"2016-04-13T03:03:38Z","updated_at":"2016-04-13T03:03:38Z","html_url":"https://github.com/fireeye/flare-floss/pull/70#discussion_r59487097","pull_request_url":"https://api.github.com/repos/fireeye/flare-floss/pulls/70","_links":{"self":{"href":"https://api.github.com/repos/fireeye/flare-floss/pulls/comments/59487097"},"html":{"href":"https://github.com/fireeye/flare-floss/pull/70#discussion_r59487097"},"pull_request":{"href":"https://api.github.com/repos/fireeye/flare-floss/pulls/70"}}},"pull_request":{"url":"https://api.github.com/repos/fireeye/flare-floss/pulls/70","id":66259395,"html_url":"https://github.com/fireeye/flare-floss/pull/70","diff_url":"https://github.com/fireeye/flare-floss/pull/70.diff","patch_url":"https://github.com/fireeye/flare-floss/pull/70.patch","issue_url":"https://api.github.com/repos/fireeye/flare-floss/issues/70","number":70,"state":"open","locked":false,"title":"main: use tabulate package to format tables.","user":{"login":"williballenthin","id":156560,"avatar_url":"https://avatars.githubusercontent.com/u/156560?v=3","gravatar_id":"","url":"https://api.github.com/users/williballenthin","html_url":"https://github.com/williballenthin","followers_url":"https://api.github.com/users/williballenthin/followers","following_url":"https://api.github.com/users/williballenthin/following{/other_user}","gists_url":"https://api.github.com/users/williballenthin/gists{/gist_id}","starred_url":"https://api.github.com/users/williballenthin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/williballenthin/subscriptions","organizations_url":"https://api.github.com/users/williballenthin/orgs","repos_url":"https://api.github.com/users/williballenthin/repos","events_url":"https://api.github.com/users/williballenthin/events{/privacy}","received_events_url":"https://api.github.com/users/williballenthin/received_events","type":"User","site_admin":false},"body":"output looks basically the same, but the column sizes dynamically change based on what data is put in them.\r\n\r\ncloses #65.","created_at":"2016-04-13T03:02:25Z","updated_at":"2016-04-13T03:03:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"45753a4ff7c30c90155762abf40d0a745432bb53","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/fireeye/flare-floss/pulls/70/commits","review_comments_url":"https://api.github.com/repos/fireeye/flare-floss/pulls/70/comments","review_comment_url":"https://api.github.com/repos/fireeye/flare-floss/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fireeye/flare-floss/issues/70/comments","statuses_url":"https://api.github.com/repos/fireeye/flare-floss/statuses/9f2ab9369c712ffd3d4795a784fd1a48fdeff8f9","head":{"label":"fireeye:bug/table-alignment","ref":"bug/table-alignment","sha":"9f2ab9369c712ffd3d4795a784fd1a48fdeff8f9","user":{"login":"fireeye","id":4984788,"avatar_url":"https://avatars.githubusercontent.com/u/4984788?v=3","gravatar_id":"","url":"https://api.github.com/users/fireeye","html_url":"https://github.com/fireeye","followers_url":"https://api.github.com/users/fireeye/followers","following_url":"https://api.github.com/users/fireeye/following{/other_user}","gists_url":"https://api.github.com/users/fireeye/gists{/gist_id}","starred_url":"https://api.github.com/users/fireeye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fireeye/subscriptions","organizations_url":"https://api.github.com/users/fireeye/orgs","repos_url":"https://api.github.com/users/fireeye/repos","events_url":"https://api.github.com/users/fireeye/events{/privacy}","received_events_url":"https://api.github.com/users/fireeye/received_events","type":"Organization","site_admin":false},"repo":{"id":52993349,"name":"flare-floss","full_name":"fireeye/flare-floss","owner":{"login":"fireeye","id":4984788,"avatar_url":"https://avatars.githubusercontent.com/u/4984788?v=3","gravatar_id":"","url":"https://api.github.com/users/fireeye","html_url":"https://github.com/fireeye","followers_url":"https://api.github.com/users/fireeye/followers","following_url":"https://api.github.com/users/fireeye/following{/other_user}","gists_url":"https://api.github.com/users/fireeye/gists{/gist_id}","starred_url":"https://api.github.com/users/fireeye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fireeye/subscriptions","organizations_url":"https://api.github.com/users/fireeye/orgs","repos_url":"https://api.github.com/users/fireeye/repos","events_url":"https://api.github.com/users/fireeye/events{/privacy}","received_events_url":"https://api.github.com/users/fireeye/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fireeye/flare-floss","description":"","fork":false,"url":"https://api.github.com/repos/fireeye/flare-floss","forks_url":"https://api.github.com/repos/fireeye/flare-floss/forks","keys_url":"https://api.github.com/repos/fireeye/flare-floss/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fireeye/flare-floss/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fireeye/flare-floss/teams","hooks_url":"https://api.github.com/repos/fireeye/flare-floss/hooks","issue_events_url":"https://api.github.com/repos/fireeye/flare-floss/issues/events{/number}","events_url":"https://api.github.com/repos/fireeye/flare-floss/events","assignees_url":"https://api.github.com/repos/fireeye/flare-floss/assignees{/user}","branches_url":"https://api.github.com/repos/fireeye/flare-floss/branches{/branch}","tags_url":"https://api.github.com/repos/fireeye/flare-floss/tags","blobs_url":"https://api.github.com/repos/fireeye/flare-floss/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fireeye/flare-floss/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fireeye/flare-floss/git/refs{/sha}","trees_url":"https://api.github.com/repos/fireeye/flare-floss/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fireeye/flare-floss/statuses/{sha}","languages_url":"https://api.github.com/repos/fireeye/flare-floss/languages","stargazers_url":"https://api.github.com/repos/fireeye/flare-floss/stargazers","contributors_url":"https://api.github.com/repos/fireeye/flare-floss/contributors","subscribers_url":"https://api.github.com/repos/fireeye/flare-floss/subscribers","subscription_url":"https://api.github.com/repos/fireeye/flare-floss/subscription","commits_url":"https://api.github.com/repos/fireeye/flare-floss/commits{/sha}","git_commits_url":"https://api.github.com/repos/fireeye/flare-floss/git/commits{/sha}","comments_url":"https://api.github.com/repos/fireeye/flare-floss/comments{/number}","issue_comment_url":"https://api.github.com/repos/fireeye/flare-floss/issues/comments{/number}","contents_url":"https://api.github.com/repos/fireeye/flare-floss/contents/{+path}","compare_url":"https://api.github.com/repos/fireeye/flare-floss/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fireeye/flare-floss/merges","archive_url":"https://api.github.com/repos/fireeye/flare-floss/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fireeye/flare-floss/downloads","issues_url":"https://api.github.com/repos/fireeye/flare-floss/issues{/number}","pulls_url":"https://api.github.com/repos/fireeye/flare-floss/pulls{/number}","milestones_url":"https://api.github.com/repos/fireeye/flare-floss/milestones{/number}","notifications_url":"https://api.github.com/repos/fireeye/flare-floss/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fireeye/flare-floss/labels{/name}","releases_url":"https://api.github.com/repos/fireeye/flare-floss/releases{/id}","deployments_url":"https://api.github.com/repos/fireeye/flare-floss/deployments","created_at":"2016-03-02T20:16:10Z","updated_at":"2016-04-12T11:13:16Z","pushed_at":"2016-04-13T03:02:27Z","git_url":"git://github.com/fireeye/flare-floss.git","ssh_url":"git@github.com:fireeye/flare-floss.git","clone_url":"https://github.com/fireeye/flare-floss.git","svn_url":"https://github.com/fireeye/flare-floss","homepage":null,"size":208,"stargazers_count":61,"watchers_count":61,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":19,"forks":13,"open_issues":19,"watchers":61,"default_branch":"master"}},"base":{"label":"fireeye:master","ref":"master","sha":"f0ab2fc16d273cf8de3f2ee8de1c22754f8cce7a","user":{"login":"fireeye","id":4984788,"avatar_url":"https://avatars.githubusercontent.com/u/4984788?v=3","gravatar_id":"","url":"https://api.github.com/users/fireeye","html_url":"https://github.com/fireeye","followers_url":"https://api.github.com/users/fireeye/followers","following_url":"https://api.github.com/users/fireeye/following{/other_user}","gists_url":"https://api.github.com/users/fireeye/gists{/gist_id}","starred_url":"https://api.github.com/users/fireeye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fireeye/subscriptions","organizations_url":"https://api.github.com/users/fireeye/orgs","repos_url":"https://api.github.com/users/fireeye/repos","events_url":"https://api.github.com/users/fireeye/events{/privacy}","received_events_url":"https://api.github.com/users/fireeye/received_events","type":"Organization","site_admin":false},"repo":{"id":52993349,"name":"flare-floss","full_name":"fireeye/flare-floss","owner":{"login":"fireeye","id":4984788,"avatar_url":"https://avatars.githubusercontent.com/u/4984788?v=3","gravatar_id":"","url":"https://api.github.com/users/fireeye","html_url":"https://github.com/fireeye","followers_url":"https://api.github.com/users/fireeye/followers","following_url":"https://api.github.com/users/fireeye/following{/other_user}","gists_url":"https://api.github.com/users/fireeye/gists{/gist_id}","starred_url":"https://api.github.com/users/fireeye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fireeye/subscriptions","organizations_url":"https://api.github.com/users/fireeye/orgs","repos_url":"https://api.github.com/users/fireeye/repos","events_url":"https://api.github.com/users/fireeye/events{/privacy}","received_events_url":"https://api.github.com/users/fireeye/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fireeye/flare-floss","description":"","fork":false,"url":"https://api.github.com/repos/fireeye/flare-floss","forks_url":"https://api.github.com/repos/fireeye/flare-floss/forks","keys_url":"https://api.github.com/repos/fireeye/flare-floss/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fireeye/flare-floss/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fireeye/flare-floss/teams","hooks_url":"https://api.github.com/repos/fireeye/flare-floss/hooks","issue_events_url":"https://api.github.com/repos/fireeye/flare-floss/issues/events{/number}","events_url":"https://api.github.com/repos/fireeye/flare-floss/events","assignees_url":"https://api.github.com/repos/fireeye/flare-floss/assignees{/user}","branches_url":"https://api.github.com/repos/fireeye/flare-floss/branches{/branch}","tags_url":"https://api.github.com/repos/fireeye/flare-floss/tags","blobs_url":"https://api.github.com/repos/fireeye/flare-floss/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fireeye/flare-floss/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fireeye/flare-floss/git/refs{/sha}","trees_url":"https://api.github.com/repos/fireeye/flare-floss/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fireeye/flare-floss/statuses/{sha}","languages_url":"https://api.github.com/repos/fireeye/flare-floss/languages","stargazers_url":"https://api.github.com/repos/fireeye/flare-floss/stargazers","contributors_url":"https://api.github.com/repos/fireeye/flare-floss/contributors","subscribers_url":"https://api.github.com/repos/fireeye/flare-floss/subscribers","subscription_url":"https://api.github.com/repos/fireeye/flare-floss/subscription","commits_url":"https://api.github.com/repos/fireeye/flare-floss/commits{/sha}","git_commits_url":"https://api.github.com/repos/fireeye/flare-floss/git/commits{/sha}","comments_url":"https://api.github.com/repos/fireeye/flare-floss/comments{/number}","issue_comment_url":"https://api.github.com/repos/fireeye/flare-floss/issues/comments{/number}","contents_url":"https://api.github.com/repos/fireeye/flare-floss/contents/{+path}","compare_url":"https://api.github.com/repos/fireeye/flare-floss/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fireeye/flare-floss/merges","archive_url":"https://api.github.com/repos/fireeye/flare-floss/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fireeye/flare-floss/downloads","issues_url":"https://api.github.com/repos/fireeye/flare-floss/issues{/number}","pulls_url":"https://api.github.com/repos/fireeye/flare-floss/pulls{/number}","milestones_url":"https://api.github.com/repos/fireeye/flare-floss/milestones{/number}","notifications_url":"https://api.github.com/repos/fireeye/flare-floss/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fireeye/flare-floss/labels{/name}","releases_url":"https://api.github.com/repos/fireeye/flare-floss/releases{/id}","deployments_url":"https://api.github.com/repos/fireeye/flare-floss/deployments","created_at":"2016-03-02T20:16:10Z","updated_at":"2016-04-12T11:13:16Z","pushed_at":"2016-04-13T03:02:27Z","git_url":"git://github.com/fireeye/flare-floss.git","ssh_url":"git@github.com:fireeye/flare-floss.git","clone_url":"https://github.com/fireeye/flare-floss.git","svn_url":"https://github.com/fireeye/flare-floss","homepage":null,"size":208,"stargazers_count":61,"watchers_count":61,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":19,"forks":13,"open_issues":19,"watchers":61,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fireeye/flare-floss/pulls/70"},"html":{"href":"https://github.com/fireeye/flare-floss/pull/70"},"issue":{"href":"https://api.github.com/repos/fireeye/flare-floss/issues/70"},"comments":{"href":"https://api.github.com/repos/fireeye/flare-floss/issues/70/comments"},"review_comments":{"href":"https://api.github.com/repos/fireeye/flare-floss/pulls/70/comments"},"review_comment":{"href":"https://api.github.com/repos/fireeye/flare-floss/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fireeye/flare-floss/pulls/70/commits"},"statuses":{"href":"https://api.github.com/repos/fireeye/flare-floss/statuses/9f2ab9369c712ffd3d4795a784fd1a48fdeff8f9"}}}}