{"action":"created","issue":{"url":"https://api.github.com/repos/PX4/Firmware/issues/4690","repository_url":"https://api.github.com/repos/PX4/Firmware","labels_url":"https://api.github.com/repos/PX4/Firmware/issues/4690/labels{/name}","comments_url":"https://api.github.com/repos/PX4/Firmware/issues/4690/comments","events_url":"https://api.github.com/repos/PX4/Firmware/issues/4690/events","html_url":"https://github.com/PX4/Firmware/pull/4690","id":157453554,"number":4690,"title":"Snapdragon MPU9250 rotation support","user":{"login":"mhkabir","id":5557676,"avatar_url":"https://avatars.githubusercontent.com/u/5557676?v=3","gravatar_id":"","url":"https://api.github.com/users/mhkabir","html_url":"https://github.com/mhkabir","followers_url":"https://api.github.com/users/mhkabir/followers","following_url":"https://api.github.com/users/mhkabir/following{/other_user}","gists_url":"https://api.github.com/users/mhkabir/gists{/gist_id}","starred_url":"https://api.github.com/users/mhkabir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhkabir/subscriptions","organizations_url":"https://api.github.com/users/mhkabir/orgs","repos_url":"https://api.github.com/users/mhkabir/repos","events_url":"https://api.github.com/users/mhkabir/events{/privacy}","received_events_url":"https://api.github.com/users/mhkabir/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":11,"created_at":"2016-05-30T08:15:16Z","updated_at":"2016-05-31T16:38:25Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/PX4/Firmware/pulls/4690","html_url":"https://github.com/PX4/Firmware/pull/4690","diff_url":"https://github.com/PX4/Firmware/pull/4690.diff","patch_url":"https://github.com/PX4/Firmware/pull/4690.patch"},"body":"@julianoes @LorenzMeier \r\n\r\nThis PR : \r\n* Fixes Snapdragon build after a slew of changes from this week broke it.\r\n* Renames ```rc_in_pwm_out``` to ```snapdragon_io``` (I prefer the more concise name). Also fixes broken build due to incomplete renaming in the last PR.\r\n* Works around missing dprintf in QuRT. Fixes build.\r\n* Adds sensor rotation support to MPU9250 wrapper to make supporting P1/P2 Flight boards possible. ( #4652 )\r\n\r\nTODO : \r\n* Mag rotation support (for HMC5883 and AK mag in MPU9250)\r\n* Automagically detect P1/P2 boards and set rotations. (@mcharleb @jywilson Any suggestions?)\r\n\r\nI haven't added rotations support to the mag driver yet. I can do this if required, but there are hacks in the driver to make it consistent with the 3dr gps, and I'd need to check how we can deal with transitional support. Let me know if we need rotation support in the mag driver at this stage. \r\n\r\nI was planning to add it for the AK mag in the 9250 after #4651 is merged. Please merge this PR before #4651."},"comment":{"url":"https://api.github.com/repos/PX4/Firmware/issues/comments/222746314","html_url":"https://github.com/PX4/Firmware/pull/4690#issuecomment-222746314","issue_url":"https://api.github.com/repos/PX4/Firmware/issues/4690","id":222746314,"user":{"login":"julianoes","id":1419688,"avatar_url":"https://avatars.githubusercontent.com/u/1419688?v=3","gravatar_id":"","url":"https://api.github.com/users/julianoes","html_url":"https://github.com/julianoes","followers_url":"https://api.github.com/users/julianoes/followers","following_url":"https://api.github.com/users/julianoes/following{/other_user}","gists_url":"https://api.github.com/users/julianoes/gists{/gist_id}","starred_url":"https://api.github.com/users/julianoes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julianoes/subscriptions","organizations_url":"https://api.github.com/users/julianoes/orgs","repos_url":"https://api.github.com/users/julianoes/repos","events_url":"https://api.github.com/users/julianoes/events{/privacy}","received_events_url":"https://api.github.com/users/julianoes/received_events","type":"User","site_admin":false},"created_at":"2016-05-31T16:38:25Z","updated_at":"2016-05-31T16:38:25Z","body":"@mhkabir I just wanted to merge this and realized that the rotation is done in sensors.cpp and not in the drivers."}}
{"actor":{"display_login":"julianoes"}}