{"action":"created","issue":{"url":"https://api.github.com/repos/libp2p/go-libp2p/issues/83","repository_url":"https://api.github.com/repos/libp2p/go-libp2p","labels_url":"https://api.github.com/repos/libp2p/go-libp2p/issues/83/labels{/name}","comments_url":"https://api.github.com/repos/libp2p/go-libp2p/issues/83/comments","events_url":"https://api.github.com/repos/libp2p/go-libp2p/issues/83/events","html_url":"https://github.com/libp2p/go-libp2p/issues/83","id":170222684,"number":83,"title":"Hit >80% code coverage on all libp2p packages","user":{"login":"whyrusleeping","id":1243164,"avatar_url":"https://avatars.githubusercontent.com/u/1243164?v=3","gravatar_id":"","url":"https://api.github.com/users/whyrusleeping","html_url":"https://github.com/whyrusleeping","followers_url":"https://api.github.com/users/whyrusleeping/followers","following_url":"https://api.github.com/users/whyrusleeping/following{/other_user}","gists_url":"https://api.github.com/users/whyrusleeping/gists{/gist_id}","starred_url":"https://api.github.com/users/whyrusleeping/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whyrusleeping/subscriptions","organizations_url":"https://api.github.com/users/whyrusleeping/orgs","repos_url":"https://api.github.com/users/whyrusleeping/repos","events_url":"https://api.github.com/users/whyrusleeping/events{/privacy}","received_events_url":"https://api.github.com/users/whyrusleeping/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/libp2p/go-libp2p/labels/difficulty:easy","name":"difficulty:easy","color":"bfe5bf"},{"url":"https://api.github.com/repos/libp2p/go-libp2p/labels/help%20wanted","name":"help wanted","color":"0e8a16"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-08-09T17:20:59Z","updated_at":"2016-08-17T14:05:25Z","closed_at":null,"body":"Similar to https://github.com/ipfs/go-ipfs/issues/3053 we want to have *really good* test coverage on libp2p. Its the core on which ipfs and other future applications rest, and if libp2p doesn't work, the apps on top of it don't stand much of a chance. Here is a list of all the libp2p package (in this repo and outside of this repo) that we need to have coverage for:\r\n\r\n- [ ] github.com/ipfs/go-libp2p/p2p/discovery\r\n- [ ] github.com/ipfs/go-libp2p/p2p/host\r\n- [ ] github.com/ipfs/go-libp2p/p2p/host/basic\r\n- [ ] github.com/ipfs/go-libp2p/p2p/host/routed\r\n- [ ] github.com/ipfs/go-libp2p/p2p/metrics\r\n- [ ] github.com/ipfs/go-libp2p/p2p/metrics/conn\r\n- [ ] github.com/ipfs/go-libp2p/p2p/metrics/stream\r\n- [ ] github.com/ipfs/go-libp2p/p2p/nat\r\n- [ ] github.com/ipfs/go-libp2p/p2p/net\r\n- [ ] github.com/ipfs/go-libp2p/p2p/net/conn\r\n- [ ] github.com/ipfs/go-libp2p/p2p/net/conreq\r\n- [ ] github.com/ipfs/go-libp2p/p2p/net/filter\r\n- [ ] github.com/ipfs/go-libp2p/p2p/net/mock\r\n- [ ] github.com/ipfs/go-libp2p/p2p/net/swarm\r\n- [ ] github.com/ipfs/go-libp2p/p2p/net/swarm/addr\r\n- [ ] github.com/ipfs/go-libp2p/p2p/protocol\r\n- [ ] github.com/ipfs/go-libp2p/p2p/protocol/identify\r\n- [ ] github.com/ipfs/go-libp2p/p2p/protocol/ping\r\n- [ ] github.com/ipfs/go-libp2p/p2p/protocol/relay\r\n- [ ] github.com/ipfs/go-libp2p/p2p/test/backpressure\r\n- [ ] github.com/ipfs/go-libp2p/p2p/test/reconnects\r\n- [ ] github.com/ipfs/go-libp2p/p2p/test/util\r\n- [ ] github.com/ipfs/go-libp2p/testutil\r\n- [ ] github.com/ipfs/go-libp2p/testutil/ci\r\n- [ ] github.com/ipfs/go-libp2p/testutil/ci/jenkins\r\n- [ ] github.com/ipfs/go-libp2p/testutil/ci/travis\r\n- [ ] github.com/ipfs/go-libp2p-peerstore\r\n- [ ] github.com/ipfs/go-libp2p-peer\r\n- [ ] github.com/ipfs/go-libp2p-loggables\r\n- [ ] github.com/ipfs/go-libp2p-crypto\r\n- [ ] github.com/ipfs/go-libp2p-secio\r\n- [ ] github.com/ipfs/go-libp2p-transport\r\n"},"comment":{"url":"https://api.github.com/repos/libp2p/go-libp2p/issues/comments/240421460","html_url":"https://github.com/libp2p/go-libp2p/issues/83#issuecomment-240421460","issue_url":"https://api.github.com/repos/libp2p/go-libp2p/issues/83","id":240421460,"user":{"login":"zjiekai","id":1871071,"avatar_url":"https://avatars.githubusercontent.com/u/1871071?v=3","gravatar_id":"","url":"https://api.github.com/users/zjiekai","html_url":"https://github.com/zjiekai","followers_url":"https://api.github.com/users/zjiekai/followers","following_url":"https://api.github.com/users/zjiekai/following{/other_user}","gists_url":"https://api.github.com/users/zjiekai/gists{/gist_id}","starred_url":"https://api.github.com/users/zjiekai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zjiekai/subscriptions","organizations_url":"https://api.github.com/users/zjiekai/orgs","repos_url":"https://api.github.com/users/zjiekai/repos","events_url":"https://api.github.com/users/zjiekai/events{/privacy}","received_events_url":"https://api.github.com/users/zjiekai/received_events","type":"User","site_admin":false},"created_at":"2016-08-17T14:05:24Z","updated_at":"2016-08-17T14:05:24Z","body":"Hi, I'm trying to run test.\r\n\r\nIn the code package imports are prefixed with `github.com/libp2p/go-libp2p`. Why not `github.com/libp2p/go-libp2p`? What am I missing?\r\n\r\nHere is what I am referring to https://github.com/libp2p/go-libp2p/blob/master/p2p/discovery/mdns.go#L18"}}
{"actor":{"display_login":"zjiekai"}}