{"action":"created","comment":{"url":"https://api.github.com/repos/chef/inspec/pulls/comments/78334426","id":78334426,"diff_hunk":"@@ -31,25 +31,43 @@ def self.resolve(dependencies, vendor_index, working_dir, backend)\n       new.resolve(reqs)\n     end\n \n-    def resolve(deps, top_level = true, seen_items = {}, path_string = '')\n+    def detect_duplicates(deps, top_level, path_string)\n+      seen_items_local = []\n+      deps.each do |dep|\n+        if seen_items_local.include?(dep.name)\n+          problem_cookbook = if top_level\n+                               'the inspec.yml for this profile.'\n+                             else\n+                               \"the dependency information for #{path_string.split(' ').last}\"\n+                             end\n+          fail Inspec::DuplicateDep, \"The dependency #{dep.name} is listed twice in #{problem_cookbook}\"","path":"lib/inspec/dependencies/resolver.rb","position":14,"original_position":14,"commit_id":"50ac8523a6eca47f48f0ab67c70ce70a7e451cde","original_commit_id":"50ac8523a6eca47f48f0ab67c70ce70a7e451cde","user":{"login":"stevendanna","id":852371,"avatar_url":"https://avatars.githubusercontent.com/u/852371?v=3","gravatar_id":"","url":"https://api.github.com/users/stevendanna","html_url":"https://github.com/stevendanna","followers_url":"https://api.github.com/users/stevendanna/followers","following_url":"https://api.github.com/users/stevendanna/following{/other_user}","gists_url":"https://api.github.com/users/stevendanna/gists{/gist_id}","starred_url":"https://api.github.com/users/stevendanna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevendanna/subscriptions","organizations_url":"https://api.github.com/users/stevendanna/orgs","repos_url":"https://api.github.com/users/stevendanna/repos","events_url":"https://api.github.com/users/stevendanna/events{/privacy}","received_events_url":"https://api.github.com/users/stevendanna/received_events","type":"User","site_admin":false},"body":"There is a test that ensures we detect duplicates:\r\n\r\nhttps://github.com/chef/inspec/pull/1038/files#diff-a1477bbe856a2707fce873a5096df630R28\r\n\r\nDo you think we should test the content of the error message as well?","created_at":"2016-09-12T08:46:25Z","updated_at":"2016-09-12T08:46:25Z","html_url":"https://github.com/chef/inspec/pull/1038#discussion_r78334426","pull_request_url":"https://api.github.com/repos/chef/inspec/pulls/1038","_links":{"self":{"href":"https://api.github.com/repos/chef/inspec/pulls/comments/78334426"},"html":{"href":"https://github.com/chef/inspec/pull/1038#discussion_r78334426"},"pull_request":{"href":"https://api.github.com/repos/chef/inspec/pulls/1038"}}},"pull_request":{"url":"https://api.github.com/repos/chef/inspec/pulls/1038","id":84643293,"html_url":"https://github.com/chef/inspec/pull/1038","diff_url":"https://github.com/chef/inspec/pull/1038.diff","patch_url":"https://github.com/chef/inspec/pull/1038.patch","issue_url":"https://api.github.com/repos/chef/inspec/issues/1038","number":1038,"state":"open","locked":false,"title":"Improve duplicate and cycle detection in resolver","user":{"login":"stevendanna","id":852371,"avatar_url":"https://avatars.githubusercontent.com/u/852371?v=3","gravatar_id":"","url":"https://api.github.com/users/stevendanna","html_url":"https://github.com/stevendanna","followers_url":"https://api.github.com/users/stevendanna/followers","following_url":"https://api.github.com/users/stevendanna/following{/other_user}","gists_url":"https://api.github.com/users/stevendanna/gists{/gist_id}","starred_url":"https://api.github.com/users/stevendanna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevendanna/subscriptions","organizations_url":"https://api.github.com/users/stevendanna/orgs","repos_url":"https://api.github.com/users/stevendanna/repos","events_url":"https://api.github.com/users/stevendanna/events{/privacy}","received_events_url":"https://api.github.com/users/stevendanna/received_events","type":"User","site_admin":false},"body":"Signed-off-by: Steven Danna <steve@chef.io>","created_at":"2016-09-09T12:36:48Z","updated_at":"2016-09-12T08:46:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"daffaf2fb1d864e95a76da6350e2d0dcde469313","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/chef/inspec/pulls/1038/commits","review_comments_url":"https://api.github.com/repos/chef/inspec/pulls/1038/comments","review_comment_url":"https://api.github.com/repos/chef/inspec/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chef/inspec/issues/1038/comments","statuses_url":"https://api.github.com/repos/chef/inspec/statuses/50ac8523a6eca47f48f0ab67c70ce70a7e451cde","head":{"label":"chef:ssd/dup-detect","ref":"ssd/dup-detect","sha":"50ac8523a6eca47f48f0ab67c70ce70a7e451cde","user":{"login":"chef","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?v=3","gravatar_id":"","url":"https://api.github.com/users/chef","html_url":"https://github.com/chef","followers_url":"https://api.github.com/users/chef/followers","following_url":"https://api.github.com/users/chef/following{/other_user}","gists_url":"https://api.github.com/users/chef/gists{/gist_id}","starred_url":"https://api.github.com/users/chef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef/subscriptions","organizations_url":"https://api.github.com/users/chef/orgs","repos_url":"https://api.github.com/users/chef/repos","events_url":"https://api.github.com/users/chef/events{/privacy}","received_events_url":"https://api.github.com/users/chef/received_events","type":"Organization","site_admin":false},"repo":{"id":41571541,"name":"inspec","full_name":"chef/inspec","owner":{"login":"chef","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?v=3","gravatar_id":"","url":"https://api.github.com/users/chef","html_url":"https://github.com/chef","followers_url":"https://api.github.com/users/chef/followers","following_url":"https://api.github.com/users/chef/following{/other_user}","gists_url":"https://api.github.com/users/chef/gists{/gist_id}","starred_url":"https://api.github.com/users/chef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef/subscriptions","organizations_url":"https://api.github.com/users/chef/orgs","repos_url":"https://api.github.com/users/chef/repos","events_url":"https://api.github.com/users/chef/events{/privacy}","received_events_url":"https://api.github.com/users/chef/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chef/inspec","description":"InSpec: Auditing and Testing Framework","fork":false,"url":"https://api.github.com/repos/chef/inspec","forks_url":"https://api.github.com/repos/chef/inspec/forks","keys_url":"https://api.github.com/repos/chef/inspec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chef/inspec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chef/inspec/teams","hooks_url":"https://api.github.com/repos/chef/inspec/hooks","issue_events_url":"https://api.github.com/repos/chef/inspec/issues/events{/number}","events_url":"https://api.github.com/repos/chef/inspec/events","assignees_url":"https://api.github.com/repos/chef/inspec/assignees{/user}","branches_url":"https://api.github.com/repos/chef/inspec/branches{/branch}","tags_url":"https://api.github.com/repos/chef/inspec/tags","blobs_url":"https://api.github.com/repos/chef/inspec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chef/inspec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chef/inspec/git/refs{/sha}","trees_url":"https://api.github.com/repos/chef/inspec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chef/inspec/statuses/{sha}","languages_url":"https://api.github.com/repos/chef/inspec/languages","stargazers_url":"https://api.github.com/repos/chef/inspec/stargazers","contributors_url":"https://api.github.com/repos/chef/inspec/contributors","subscribers_url":"https://api.github.com/repos/chef/inspec/subscribers","subscription_url":"https://api.github.com/repos/chef/inspec/subscription","commits_url":"https://api.github.com/repos/chef/inspec/commits{/sha}","git_commits_url":"https://api.github.com/repos/chef/inspec/git/commits{/sha}","comments_url":"https://api.github.com/repos/chef/inspec/comments{/number}","issue_comment_url":"https://api.github.com/repos/chef/inspec/issues/comments{/number}","contents_url":"https://api.github.com/repos/chef/inspec/contents/{+path}","compare_url":"https://api.github.com/repos/chef/inspec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chef/inspec/merges","archive_url":"https://api.github.com/repos/chef/inspec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chef/inspec/downloads","issues_url":"https://api.github.com/repos/chef/inspec/issues{/number}","pulls_url":"https://api.github.com/repos/chef/inspec/pulls{/number}","milestones_url":"https://api.github.com/repos/chef/inspec/milestones{/number}","notifications_url":"https://api.github.com/repos/chef/inspec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chef/inspec/labels{/name}","releases_url":"https://api.github.com/repos/chef/inspec/releases{/id}","deployments_url":"https://api.github.com/repos/chef/inspec/deployments","created_at":"2015-08-28T22:16:01Z","updated_at":"2016-09-07T01:33:56Z","pushed_at":"2016-09-12T08:25:56Z","git_url":"git://github.com/chef/inspec.git","ssh_url":"git@github.com:chef/inspec.git","clone_url":"https://github.com/chef/inspec.git","svn_url":"https://github.com/chef/inspec","homepage":"","size":3883,"stargazers_count":423,"watchers_count":423,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":78,"mirror_url":null,"open_issues_count":182,"forks":78,"open_issues":182,"watchers":423,"default_branch":"master"}},"base":{"label":"chef:master","ref":"master","sha":"1c10d7fbb42cb2b29775a64441597cee3474536f","user":{"login":"chef","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?v=3","gravatar_id":"","url":"https://api.github.com/users/chef","html_url":"https://github.com/chef","followers_url":"https://api.github.com/users/chef/followers","following_url":"https://api.github.com/users/chef/following{/other_user}","gists_url":"https://api.github.com/users/chef/gists{/gist_id}","starred_url":"https://api.github.com/users/chef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef/subscriptions","organizations_url":"https://api.github.com/users/chef/orgs","repos_url":"https://api.github.com/users/chef/repos","events_url":"https://api.github.com/users/chef/events{/privacy}","received_events_url":"https://api.github.com/users/chef/received_events","type":"Organization","site_admin":false},"repo":{"id":41571541,"name":"inspec","full_name":"chef/inspec","owner":{"login":"chef","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?v=3","gravatar_id":"","url":"https://api.github.com/users/chef","html_url":"https://github.com/chef","followers_url":"https://api.github.com/users/chef/followers","following_url":"https://api.github.com/users/chef/following{/other_user}","gists_url":"https://api.github.com/users/chef/gists{/gist_id}","starred_url":"https://api.github.com/users/chef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef/subscriptions","organizations_url":"https://api.github.com/users/chef/orgs","repos_url":"https://api.github.com/users/chef/repos","events_url":"https://api.github.com/users/chef/events{/privacy}","received_events_url":"https://api.github.com/users/chef/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chef/inspec","description":"InSpec: Auditing and Testing Framework","fork":false,"url":"https://api.github.com/repos/chef/inspec","forks_url":"https://api.github.com/repos/chef/inspec/forks","keys_url":"https://api.github.com/repos/chef/inspec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chef/inspec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chef/inspec/teams","hooks_url":"https://api.github.com/repos/chef/inspec/hooks","issue_events_url":"https://api.github.com/repos/chef/inspec/issues/events{/number}","events_url":"https://api.github.com/repos/chef/inspec/events","assignees_url":"https://api.github.com/repos/chef/inspec/assignees{/user}","branches_url":"https://api.github.com/repos/chef/inspec/branches{/branch}","tags_url":"https://api.github.com/repos/chef/inspec/tags","blobs_url":"https://api.github.com/repos/chef/inspec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chef/inspec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chef/inspec/git/refs{/sha}","trees_url":"https://api.github.com/repos/chef/inspec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chef/inspec/statuses/{sha}","languages_url":"https://api.github.com/repos/chef/inspec/languages","stargazers_url":"https://api.github.com/repos/chef/inspec/stargazers","contributors_url":"https://api.github.com/repos/chef/inspec/contributors","subscribers_url":"https://api.github.com/repos/chef/inspec/subscribers","subscription_url":"https://api.github.com/repos/chef/inspec/subscription","commits_url":"https://api.github.com/repos/chef/inspec/commits{/sha}","git_commits_url":"https://api.github.com/repos/chef/inspec/git/commits{/sha}","comments_url":"https://api.github.com/repos/chef/inspec/comments{/number}","issue_comment_url":"https://api.github.com/repos/chef/inspec/issues/comments{/number}","contents_url":"https://api.github.com/repos/chef/inspec/contents/{+path}","compare_url":"https://api.github.com/repos/chef/inspec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chef/inspec/merges","archive_url":"https://api.github.com/repos/chef/inspec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chef/inspec/downloads","issues_url":"https://api.github.com/repos/chef/inspec/issues{/number}","pulls_url":"https://api.github.com/repos/chef/inspec/pulls{/number}","milestones_url":"https://api.github.com/repos/chef/inspec/milestones{/number}","notifications_url":"https://api.github.com/repos/chef/inspec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chef/inspec/labels{/name}","releases_url":"https://api.github.com/repos/chef/inspec/releases{/id}","deployments_url":"https://api.github.com/repos/chef/inspec/deployments","created_at":"2015-08-28T22:16:01Z","updated_at":"2016-09-07T01:33:56Z","pushed_at":"2016-09-12T08:25:56Z","git_url":"git://github.com/chef/inspec.git","ssh_url":"git@github.com:chef/inspec.git","clone_url":"https://github.com/chef/inspec.git","svn_url":"https://github.com/chef/inspec","homepage":"","size":3883,"stargazers_count":423,"watchers_count":423,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":78,"mirror_url":null,"open_issues_count":182,"forks":78,"open_issues":182,"watchers":423,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/chef/inspec/pulls/1038"},"html":{"href":"https://github.com/chef/inspec/pull/1038"},"issue":{"href":"https://api.github.com/repos/chef/inspec/issues/1038"},"comments":{"href":"https://api.github.com/repos/chef/inspec/issues/1038/comments"},"review_comments":{"href":"https://api.github.com/repos/chef/inspec/pulls/1038/comments"},"review_comment":{"href":"https://api.github.com/repos/chef/inspec/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chef/inspec/pulls/1038/commits"},"statuses":{"href":"https://api.github.com/repos/chef/inspec/statuses/50ac8523a6eca47f48f0ab67c70ce70a7e451cde"}}}}
{"actor":{"display_login":"stevendanna"}}