{"action":"created","comment":{"url":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/comments/66139057","id":66139057,"diff_hunk":"@@ -76,12 +78,10 @@\n #\t\t'-I'+Configuration.current.variables[\"LIBDISPATCH_SOURCE_DIR\"],\n #\t\t'-I'+Configuration.current.variables[\"LIBDISPATCH_BUILD_DIR\"]+'/src'\n #\t])\n-#\tfoundation.LDFLAGS += '-ldispatch -L'+Configuration.current.variables[\"LIBDISPATCH_BUILD_DIR\"]+'/src/.libs '\n+#\tfoundation.LDFLAGS += '-ldispatch -L'+Configuration.current.variables[\"LIBDISPATCH_BUILD_DIR\"]+'/src/.libs -rpath \\$$ORIGIN '\n \n foundation.SWIFTCFLAGS = \" \".join(swift_cflags)\n \n-foundation.LDFLAGS += '-lpthread -ldl -lm -lswiftCore -lxml2 '","path":"build.py","position":18,"original_position":18,"commit_id":"6fa453f0608dd4172ddeac6ecdef0b2e47b03f6f","original_commit_id":"6fa453f0608dd4172ddeac6ecdef0b2e47b03f6f","user":{"login":"phausler","id":278470,"avatar_url":"https://avatars.githubusercontent.com/u/278470?v=3","gravatar_id":"","url":"https://api.github.com/users/phausler","html_url":"https://github.com/phausler","followers_url":"https://api.github.com/users/phausler/followers","following_url":"https://api.github.com/users/phausler/following{/other_user}","gists_url":"https://api.github.com/users/phausler/gists{/gist_id}","starred_url":"https://api.github.com/users/phausler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phausler/subscriptions","organizations_url":"https://api.github.com/users/phausler/orgs","repos_url":"https://api.github.com/users/phausler/repos","events_url":"https://api.github.com/users/phausler/events{/privacy}","received_events_url":"https://api.github.com/users/phausler/received_events","type":"User","site_admin":false},"body":"Why was this set of flags removed?","created_at":"2016-06-07T19:45:06Z","updated_at":"2016-06-07T19:45:06Z","html_url":"https://github.com/apple/swift-corelibs-foundation/pull/405#discussion_r66139057","pull_request_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/405","_links":{"self":{"href":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/comments/66139057"},"html":{"href":"https://github.com/apple/swift-corelibs-foundation/pull/405#discussion_r66139057"},"pull_request":{"href":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/405"}}},"pull_request":{"url":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/405","id":72631345,"html_url":"https://github.com/apple/swift-corelibs-foundation/pull/405","diff_url":"https://github.com/apple/swift-corelibs-foundation/pull/405.diff","patch_url":"https://github.com/apple/swift-corelibs-foundation/pull/405.patch","issue_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/issues/405","number":405,"state":"open","locked":false,"title":"Add rpath of ORIGIN on Linux in order to pick up libdispatch","user":{"login":"seabaylea","id":11974522,"avatar_url":"https://avatars.githubusercontent.com/u/11974522?v=3","gravatar_id":"","url":"https://api.github.com/users/seabaylea","html_url":"https://github.com/seabaylea","followers_url":"https://api.github.com/users/seabaylea/followers","following_url":"https://api.github.com/users/seabaylea/following{/other_user}","gists_url":"https://api.github.com/users/seabaylea/gists{/gist_id}","starred_url":"https://api.github.com/users/seabaylea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seabaylea/subscriptions","organizations_url":"https://api.github.com/users/seabaylea/orgs","repos_url":"https://api.github.com/users/seabaylea/repos","events_url":"https://api.github.com/users/seabaylea/events{/privacy}","received_events_url":"https://api.github.com/users/seabaylea/received_events","type":"User","site_admin":false},"body":"When Dispatch is added into the toolchain it adds the libdispatch library into the `/usr/lib/swift/linux` directory, which is where the other libraries such as libFoundation are located.\r\n\r\nApplications built using `swiftc` have `/usr/lib/swift/linux` added to their library search path, so anything using Dispatch directly can find the library at runtime and runs correctly. The Foundation library however doesn't, so fails to find Dispatch at runtime if its not added to the LD_LIBRARY_PATH.\r\n\r\nThis PR adds a RPATH of ORIGIN to the Foundation library so that it can link to Dispatch at runtime without the need for the path to be explicitly set using LD_LIBRARY_PATH.","created_at":"2016-06-05T14:53:57Z","updated_at":"2016-06-07T19:45:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"86bca21ea8f9d8edbdd8fd106ec048fbee7b2135","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/405/commits","review_comments_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/405/comments","review_comment_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/issues/405/comments","statuses_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/statuses/6fa453f0608dd4172ddeac6ecdef0b2e47b03f6f","head":{"label":"seabaylea:foundation-origin","ref":"foundation-origin","sha":"6fa453f0608dd4172ddeac6ecdef0b2e47b03f6f","user":{"login":"seabaylea","id":11974522,"avatar_url":"https://avatars.githubusercontent.com/u/11974522?v=3","gravatar_id":"","url":"https://api.github.com/users/seabaylea","html_url":"https://github.com/seabaylea","followers_url":"https://api.github.com/users/seabaylea/followers","following_url":"https://api.github.com/users/seabaylea/following{/other_user}","gists_url":"https://api.github.com/users/seabaylea/gists{/gist_id}","starred_url":"https://api.github.com/users/seabaylea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seabaylea/subscriptions","organizations_url":"https://api.github.com/users/seabaylea/orgs","repos_url":"https://api.github.com/users/seabaylea/repos","events_url":"https://api.github.com/users/seabaylea/events{/privacy}","received_events_url":"https://api.github.com/users/seabaylea/received_events","type":"User","site_admin":false},"repo":{"id":51076787,"name":"swift-corelibs-foundation","full_name":"seabaylea/swift-corelibs-foundation","owner":{"login":"seabaylea","id":11974522,"avatar_url":"https://avatars.githubusercontent.com/u/11974522?v=3","gravatar_id":"","url":"https://api.github.com/users/seabaylea","html_url":"https://github.com/seabaylea","followers_url":"https://api.github.com/users/seabaylea/followers","following_url":"https://api.github.com/users/seabaylea/following{/other_user}","gists_url":"https://api.github.com/users/seabaylea/gists{/gist_id}","starred_url":"https://api.github.com/users/seabaylea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seabaylea/subscriptions","organizations_url":"https://api.github.com/users/seabaylea/orgs","repos_url":"https://api.github.com/users/seabaylea/repos","events_url":"https://api.github.com/users/seabaylea/events{/privacy}","received_events_url":"https://api.github.com/users/seabaylea/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/seabaylea/swift-corelibs-foundation","description":"The Foundation Project, providing core utilities, internationalization, and OS independence","fork":true,"url":"https://api.github.com/repos/seabaylea/swift-corelibs-foundation","forks_url":"https://api.github.com/repos/seabaylea/swift-corelibs-foundation/forks","keys_url":"https://api.github.com/repos/seabaylea/swift-corelibs-foundation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/seabaylea/swift-corelibs-foundation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/seabaylea/swift-corelibs-foundation/teams","hooks_url":"https://api.github.com/repos/seabaylea/swift-corelibs-foundation/hooks","issue_events_url":"https://api.github.com/repos/seabaylea/swift-corelibs-foundation/issues/events{/number}","events_url":"https://api.github.com/repos/seabaylea/swift-corelibs-foundation/events","assignees_url":"https://api.github.com/repos/seabaylea/swift-corelibs-foundation/assignees{/user}","branches_url":"https://api.github.com/repos/seabaylea/swift-corelibs-foundation/branches{/branch}","tags_url":"https://api.github.com/repos/seabaylea/swift-corelibs-foundation/tags","blobs_url":"https://api.github.com/repos/seabaylea/swift-corelibs-foundation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/seabaylea/swift-corelibs-foundation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/seabaylea/swift-corelibs-foundation/git/refs{/sha}","trees_url":"https://api.github.com/repos/seabaylea/swift-corelibs-foundation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/seabaylea/swift-corelibs-foundation/statuses/{sha}","languages_url":"https://api.github.com/repos/seabaylea/swift-corelibs-foundation/languages","stargazers_url":"https://api.github.com/repos/seabaylea/swift-corelibs-foundation/stargazers","contributors_url":"https://api.github.com/repos/seabaylea/swift-corelibs-foundation/contributors","subscribers_url":"https://api.github.com/repos/seabaylea/swift-corelibs-foundation/subscribers","subscription_url":"https://api.github.com/repos/seabaylea/swift-corelibs-foundation/subscription","commits_url":"https://api.github.com/repos/seabaylea/swift-corelibs-foundation/commits{/sha}","git_commits_url":"https://api.github.com/repos/seabaylea/swift-corelibs-foundation/git/commits{/sha}","comments_url":"https://api.github.com/repos/seabaylea/swift-corelibs-foundation/comments{/number}","issue_comment_url":"https://api.github.com/repos/seabaylea/swift-corelibs-foundation/issues/comments{/number}","contents_url":"https://api.github.com/repos/seabaylea/swift-corelibs-foundation/contents/{+path}","compare_url":"https://api.github.com/repos/seabaylea/swift-corelibs-foundation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/seabaylea/swift-corelibs-foundation/merges","archive_url":"https://api.github.com/repos/seabaylea/swift-corelibs-foundation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/seabaylea/swift-corelibs-foundation/downloads","issues_url":"https://api.github.com/repos/seabaylea/swift-corelibs-foundation/issues{/number}","pulls_url":"https://api.github.com/repos/seabaylea/swift-corelibs-foundation/pulls{/number}","milestones_url":"https://api.github.com/repos/seabaylea/swift-corelibs-foundation/milestones{/number}","notifications_url":"https://api.github.com/repos/seabaylea/swift-corelibs-foundation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/seabaylea/swift-corelibs-foundation/labels{/name}","releases_url":"https://api.github.com/repos/seabaylea/swift-corelibs-foundation/releases{/id}","deployments_url":"https://api.github.com/repos/seabaylea/swift-corelibs-foundation/deployments","created_at":"2016-02-04T13:12:13Z","updated_at":"2016-02-04T13:12:17Z","pushed_at":"2016-06-05T14:00:42Z","git_url":"git://github.com/seabaylea/swift-corelibs-foundation.git","ssh_url":"git@github.com:seabaylea/swift-corelibs-foundation.git","clone_url":"https://github.com/seabaylea/swift-corelibs-foundation.git","svn_url":"https://github.com/seabaylea/swift-corelibs-foundation","homepage":"swift.org","size":5326,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apple:master","ref":"master","sha":"841c60416619a7647f2dfdb29c85b191ff5a3059","user":{"login":"apple","id":10639145,"avatar_url":"https://avatars.githubusercontent.com/u/10639145?v=3","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":45863890,"name":"swift-corelibs-foundation","full_name":"apple/swift-corelibs-foundation","owner":{"login":"apple","id":10639145,"avatar_url":"https://avatars.githubusercontent.com/u/10639145?v=3","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apple/swift-corelibs-foundation","description":"The Foundation Project, providing core utilities, internationalization, and OS independence","fork":false,"url":"https://api.github.com/repos/apple/swift-corelibs-foundation","forks_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/forks","keys_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/teams","hooks_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/hooks","issue_events_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/events","assignees_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/tags","blobs_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/languages","stargazers_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/stargazers","contributors_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/contributors","subscribers_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/subscribers","subscription_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/subscription","commits_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/merges","archive_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/downloads","issues_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/deployments","created_at":"2015-11-09T20:12:23Z","updated_at":"2016-06-07T17:11:20Z","pushed_at":"2016-06-07T08:46:16Z","git_url":"git://github.com/apple/swift-corelibs-foundation.git","ssh_url":"git@github.com:apple/swift-corelibs-foundation.git","clone_url":"https://github.com/apple/swift-corelibs-foundation.git","svn_url":"https://github.com/apple/swift-corelibs-foundation","homepage":"swift.org","size":6200,"stargazers_count":1907,"watchers_count":1907,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":380,"mirror_url":null,"open_issues_count":36,"forks":380,"open_issues":36,"watchers":1907,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/405"},"html":{"href":"https://github.com/apple/swift-corelibs-foundation/pull/405"},"issue":{"href":"https://api.github.com/repos/apple/swift-corelibs-foundation/issues/405"},"comments":{"href":"https://api.github.com/repos/apple/swift-corelibs-foundation/issues/405/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/405/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/405/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift-corelibs-foundation/statuses/6fa453f0608dd4172ddeac6ecdef0b2e47b03f6f"}}}}
{"actor":{"display_login":"phausler"}}