{"action":"opened","number":104,"pull_request":{"url":"https://api.github.com/repos/miguelcobain/ember-leaflet/pulls/104","id":88497509,"html_url":"https://github.com/miguelcobain/ember-leaflet/pull/104","diff_url":"https://github.com/miguelcobain/ember-leaflet/pull/104.diff","patch_url":"https://github.com/miguelcobain/ember-leaflet/pull/104.patch","issue_url":"https://api.github.com/repos/miguelcobain/ember-leaflet/issues/104","number":104,"state":"open","locked":false,"title":"[DNM] Fastbootification","user":{"login":"dbouwman","id":119129,"avatar_url":"https://avatars.githubusercontent.com/u/119129?v=3","gravatar_id":"","url":"https://api.github.com/users/dbouwman","html_url":"https://github.com/dbouwman","followers_url":"https://api.github.com/users/dbouwman/followers","following_url":"https://api.github.com/users/dbouwman/following{/other_user}","gists_url":"https://api.github.com/users/dbouwman/gists{/gist_id}","starred_url":"https://api.github.com/users/dbouwman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbouwman/subscriptions","organizations_url":"https://api.github.com/users/dbouwman/orgs","repos_url":"https://api.github.com/users/dbouwman/repos","events_url":"https://api.github.com/users/dbouwman/events{/privacy}","received_events_url":"https://api.github.com/users/dbouwman/received_events","type":"User","site_admin":false},"body":"This is a first swipe at making this addon compatible with fastboot. I'm not confident this is ready to merge yet - details below...\r\n\r\nI basically followed the [Fastboot Addon Author Guide](https://www.ember-fastboot.com/docs/addon-author-guide), and managed to get:\r\n\r\na) `ember fastboot --serve-assets` to run w/o errors related to L being undefined.\r\n\r\nb) A simple example map works once the page is loaded in the browser.\r\n\r\nMy need was a demo showing Fastboot + Ember Engines, so I can say that this does work, but various Engine related hacks were needed in both the Engine Addon that was consuming this `ember-leaflet`, and the Ember App hosting the Engine.\r\n\r\n### Caveats \r\n- I have not tried this in a simple vanilla ember app with fastboot, but I expect it will work.\r\n- I have not tried this in a simple ember app without fastboot - again, I expect it will work.\r\n\r\nI will check into both cases next week, but wanted to get this up for others to check out over the weekend if they are so inclined.","created_at":"2016-10-07T19:49:52Z","updated_at":"2016-10-07T19:49:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/miguelcobain/ember-leaflet/pulls/104/commits","review_comments_url":"https://api.github.com/repos/miguelcobain/ember-leaflet/pulls/104/comments","review_comment_url":"https://api.github.com/repos/miguelcobain/ember-leaflet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/miguelcobain/ember-leaflet/issues/104/comments","statuses_url":"https://api.github.com/repos/miguelcobain/ember-leaflet/statuses/dcd7166f3de6d81294b08777344d8422b95d2119","head":{"label":"dbouwman:fastboot-support","ref":"fastboot-support","sha":"dcd7166f3de6d81294b08777344d8422b95d2119","user":{"login":"dbouwman","id":119129,"avatar_url":"https://avatars.githubusercontent.com/u/119129?v=3","gravatar_id":"","url":"https://api.github.com/users/dbouwman","html_url":"https://github.com/dbouwman","followers_url":"https://api.github.com/users/dbouwman/followers","following_url":"https://api.github.com/users/dbouwman/following{/other_user}","gists_url":"https://api.github.com/users/dbouwman/gists{/gist_id}","starred_url":"https://api.github.com/users/dbouwman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbouwman/subscriptions","organizations_url":"https://api.github.com/users/dbouwman/orgs","repos_url":"https://api.github.com/users/dbouwman/repos","events_url":"https://api.github.com/users/dbouwman/events{/privacy}","received_events_url":"https://api.github.com/users/dbouwman/received_events","type":"User","site_admin":false},"repo":{"id":70214104,"name":"ember-leaflet","full_name":"dbouwman/ember-leaflet","owner":{"login":"dbouwman","id":119129,"avatar_url":"https://avatars.githubusercontent.com/u/119129?v=3","gravatar_id":"","url":"https://api.github.com/users/dbouwman","html_url":"https://github.com/dbouwman","followers_url":"https://api.github.com/users/dbouwman/followers","following_url":"https://api.github.com/users/dbouwman/following{/other_user}","gists_url":"https://api.github.com/users/dbouwman/gists{/gist_id}","starred_url":"https://api.github.com/users/dbouwman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbouwman/subscriptions","organizations_url":"https://api.github.com/users/dbouwman/orgs","repos_url":"https://api.github.com/users/dbouwman/repos","events_url":"https://api.github.com/users/dbouwman/events{/privacy}","received_events_url":"https://api.github.com/users/dbouwman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dbouwman/ember-leaflet","description":":fire: :leaves: Easy and declarative mapping for ember","fork":true,"url":"https://api.github.com/repos/dbouwman/ember-leaflet","forks_url":"https://api.github.com/repos/dbouwman/ember-leaflet/forks","keys_url":"https://api.github.com/repos/dbouwman/ember-leaflet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dbouwman/ember-leaflet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dbouwman/ember-leaflet/teams","hooks_url":"https://api.github.com/repos/dbouwman/ember-leaflet/hooks","issue_events_url":"https://api.github.com/repos/dbouwman/ember-leaflet/issues/events{/number}","events_url":"https://api.github.com/repos/dbouwman/ember-leaflet/events","assignees_url":"https://api.github.com/repos/dbouwman/ember-leaflet/assignees{/user}","branches_url":"https://api.github.com/repos/dbouwman/ember-leaflet/branches{/branch}","tags_url":"https://api.github.com/repos/dbouwman/ember-leaflet/tags","blobs_url":"https://api.github.com/repos/dbouwman/ember-leaflet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dbouwman/ember-leaflet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dbouwman/ember-leaflet/git/refs{/sha}","trees_url":"https://api.github.com/repos/dbouwman/ember-leaflet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dbouwman/ember-leaflet/statuses/{sha}","languages_url":"https://api.github.com/repos/dbouwman/ember-leaflet/languages","stargazers_url":"https://api.github.com/repos/dbouwman/ember-leaflet/stargazers","contributors_url":"https://api.github.com/repos/dbouwman/ember-leaflet/contributors","subscribers_url":"https://api.github.com/repos/dbouwman/ember-leaflet/subscribers","subscription_url":"https://api.github.com/repos/dbouwman/ember-leaflet/subscription","commits_url":"https://api.github.com/repos/dbouwman/ember-leaflet/commits{/sha}","git_commits_url":"https://api.github.com/repos/dbouwman/ember-leaflet/git/commits{/sha}","comments_url":"https://api.github.com/repos/dbouwman/ember-leaflet/comments{/number}","issue_comment_url":"https://api.github.com/repos/dbouwman/ember-leaflet/issues/comments{/number}","contents_url":"https://api.github.com/repos/dbouwman/ember-leaflet/contents/{+path}","compare_url":"https://api.github.com/repos/dbouwman/ember-leaflet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dbouwman/ember-leaflet/merges","archive_url":"https://api.github.com/repos/dbouwman/ember-leaflet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dbouwman/ember-leaflet/downloads","issues_url":"https://api.github.com/repos/dbouwman/ember-leaflet/issues{/number}","pulls_url":"https://api.github.com/repos/dbouwman/ember-leaflet/pulls{/number}","milestones_url":"https://api.github.com/repos/dbouwman/ember-leaflet/milestones{/number}","notifications_url":"https://api.github.com/repos/dbouwman/ember-leaflet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dbouwman/ember-leaflet/labels{/name}","releases_url":"https://api.github.com/repos/dbouwman/ember-leaflet/releases{/id}","deployments_url":"https://api.github.com/repos/dbouwman/ember-leaflet/deployments","created_at":"2016-10-07T03:59:28Z","updated_at":"2016-10-07T03:59:29Z","pushed_at":"2016-10-07T19:41:34Z","git_url":"git://github.com/dbouwman/ember-leaflet.git","ssh_url":"git@github.com:dbouwman/ember-leaflet.git","clone_url":"https://github.com/dbouwman/ember-leaflet.git","svn_url":"https://github.com/dbouwman/ember-leaflet","homepage":"http://www.ember-leaflet.com/","size":332,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"miguelcobain:master","ref":"master","sha":"0bb60d0ee63f37908e8a99061a6a6e5d94e745d1","user":{"login":"miguelcobain","id":631691,"avatar_url":"https://avatars.githubusercontent.com/u/631691?v=3","gravatar_id":"","url":"https://api.github.com/users/miguelcobain","html_url":"https://github.com/miguelcobain","followers_url":"https://api.github.com/users/miguelcobain/followers","following_url":"https://api.github.com/users/miguelcobain/following{/other_user}","gists_url":"https://api.github.com/users/miguelcobain/gists{/gist_id}","starred_url":"https://api.github.com/users/miguelcobain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miguelcobain/subscriptions","organizations_url":"https://api.github.com/users/miguelcobain/orgs","repos_url":"https://api.github.com/users/miguelcobain/repos","events_url":"https://api.github.com/users/miguelcobain/events{/privacy}","received_events_url":"https://api.github.com/users/miguelcobain/received_events","type":"User","site_admin":false},"repo":{"id":43352523,"name":"ember-leaflet","full_name":"miguelcobain/ember-leaflet","owner":{"login":"miguelcobain","id":631691,"avatar_url":"https://avatars.githubusercontent.com/u/631691?v=3","gravatar_id":"","url":"https://api.github.com/users/miguelcobain","html_url":"https://github.com/miguelcobain","followers_url":"https://api.github.com/users/miguelcobain/followers","following_url":"https://api.github.com/users/miguelcobain/following{/other_user}","gists_url":"https://api.github.com/users/miguelcobain/gists{/gist_id}","starred_url":"https://api.github.com/users/miguelcobain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miguelcobain/subscriptions","organizations_url":"https://api.github.com/users/miguelcobain/orgs","repos_url":"https://api.github.com/users/miguelcobain/repos","events_url":"https://api.github.com/users/miguelcobain/events{/privacy}","received_events_url":"https://api.github.com/users/miguelcobain/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/miguelcobain/ember-leaflet","description":":fire: :leaves: Easy and declarative mapping for ember","fork":false,"url":"https://api.github.com/repos/miguelcobain/ember-leaflet","forks_url":"https://api.github.com/repos/miguelcobain/ember-leaflet/forks","keys_url":"https://api.github.com/repos/miguelcobain/ember-leaflet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/miguelcobain/ember-leaflet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/miguelcobain/ember-leaflet/teams","hooks_url":"https://api.github.com/repos/miguelcobain/ember-leaflet/hooks","issue_events_url":"https://api.github.com/repos/miguelcobain/ember-leaflet/issues/events{/number}","events_url":"https://api.github.com/repos/miguelcobain/ember-leaflet/events","assignees_url":"https://api.github.com/repos/miguelcobain/ember-leaflet/assignees{/user}","branches_url":"https://api.github.com/repos/miguelcobain/ember-leaflet/branches{/branch}","tags_url":"https://api.github.com/repos/miguelcobain/ember-leaflet/tags","blobs_url":"https://api.github.com/repos/miguelcobain/ember-leaflet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/miguelcobain/ember-leaflet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/miguelcobain/ember-leaflet/git/refs{/sha}","trees_url":"https://api.github.com/repos/miguelcobain/ember-leaflet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/miguelcobain/ember-leaflet/statuses/{sha}","languages_url":"https://api.github.com/repos/miguelcobain/ember-leaflet/languages","stargazers_url":"https://api.github.com/repos/miguelcobain/ember-leaflet/stargazers","contributors_url":"https://api.github.com/repos/miguelcobain/ember-leaflet/contributors","subscribers_url":"https://api.github.com/repos/miguelcobain/ember-leaflet/subscribers","subscription_url":"https://api.github.com/repos/miguelcobain/ember-leaflet/subscription","commits_url":"https://api.github.com/repos/miguelcobain/ember-leaflet/commits{/sha}","git_commits_url":"https://api.github.com/repos/miguelcobain/ember-leaflet/git/commits{/sha}","comments_url":"https://api.github.com/repos/miguelcobain/ember-leaflet/comments{/number}","issue_comment_url":"https://api.github.com/repos/miguelcobain/ember-leaflet/issues/comments{/number}","contents_url":"https://api.github.com/repos/miguelcobain/ember-leaflet/contents/{+path}","compare_url":"https://api.github.com/repos/miguelcobain/ember-leaflet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/miguelcobain/ember-leaflet/merges","archive_url":"https://api.github.com/repos/miguelcobain/ember-leaflet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/miguelcobain/ember-leaflet/downloads","issues_url":"https://api.github.com/repos/miguelcobain/ember-leaflet/issues{/number}","pulls_url":"https://api.github.com/repos/miguelcobain/ember-leaflet/pulls{/number}","milestones_url":"https://api.github.com/repos/miguelcobain/ember-leaflet/milestones{/number}","notifications_url":"https://api.github.com/repos/miguelcobain/ember-leaflet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/miguelcobain/ember-leaflet/labels{/name}","releases_url":"https://api.github.com/repos/miguelcobain/ember-leaflet/releases{/id}","deployments_url":"https://api.github.com/repos/miguelcobain/ember-leaflet/deployments","created_at":"2015-09-29T07:43:23Z","updated_at":"2016-10-03T18:49:43Z","pushed_at":"2016-10-05T19:40:46Z","git_url":"git://github.com/miguelcobain/ember-leaflet.git","ssh_url":"git@github.com:miguelcobain/ember-leaflet.git","clone_url":"https://github.com/miguelcobain/ember-leaflet.git","svn_url":"https://github.com/miguelcobain/ember-leaflet","homepage":"http://www.ember-leaflet.com/","size":332,"stargazers_count":114,"watchers_count":114,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":30,"mirror_url":null,"open_issues_count":12,"forks":30,"open_issues":12,"watchers":114,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/miguelcobain/ember-leaflet/pulls/104"},"html":{"href":"https://github.com/miguelcobain/ember-leaflet/pull/104"},"issue":{"href":"https://api.github.com/repos/miguelcobain/ember-leaflet/issues/104"},"comments":{"href":"https://api.github.com/repos/miguelcobain/ember-leaflet/issues/104/comments"},"review_comments":{"href":"https://api.github.com/repos/miguelcobain/ember-leaflet/pulls/104/comments"},"review_comment":{"href":"https://api.github.com/repos/miguelcobain/ember-leaflet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/miguelcobain/ember-leaflet/pulls/104/commits"},"statuses":{"href":"https://api.github.com/repos/miguelcobain/ember-leaflet/statuses/dcd7166f3de6d81294b08777344d8422b95d2119"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":51,"deletions":23,"changed_files":20}}
{"actor":{"display_login":"dbouwman"}}