{"action":"created","issue":{"url":"https://api.github.com/repos/playframework/playframework/issues/6552","repository_url":"https://api.github.com/repos/playframework/playframework","labels_url":"https://api.github.com/repos/playframework/playframework/issues/6552/labels{/name}","comments_url":"https://api.github.com/repos/playframework/playframework/issues/6552/comments","events_url":"https://api.github.com/repos/playframework/playframework/issues/6552/events","html_url":"https://github.com/playframework/playframework/pull/6552","id":176628560,"number":6552,"title":"Assets-Controller bug fixes (see description): fixes #6144","user":{"login":"domdorn","id":100349,"avatar_url":"https://avatars.githubusercontent.com/u/100349?v=3","gravatar_id":"","url":"https://api.github.com/users/domdorn","html_url":"https://github.com/domdorn","followers_url":"https://api.github.com/users/domdorn/followers","following_url":"https://api.github.com/users/domdorn/following{/other_user}","gists_url":"https://api.github.com/users/domdorn/gists{/gist_id}","starred_url":"https://api.github.com/users/domdorn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/domdorn/subscriptions","organizations_url":"https://api.github.com/users/domdorn/orgs","repos_url":"https://api.github.com/users/domdorn/repos","events_url":"https://api.github.com/users/domdorn/events{/privacy}","received_events_url":"https://api.github.com/users/domdorn/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":14,"created_at":"2016-09-13T12:34:28Z","updated_at":"2016-10-18T21:25:35Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/playframework/playframework/pulls/6552","html_url":"https://github.com/playframework/playframework/pull/6552","diff_url":"https://github.com/playframework/playframework/pull/6552.diff","patch_url":"https://github.com/playframework/playframework/pull/6552.patch"},"body":"## Purpose\r\nThe assets controller has a few flaws in its current implementation. \r\nThis PR is supposed to fix those flaws and adds new tests to further harden the\r\nAssets-Controller implementation\r\n\r\nThis commit fixes the following: \r\n\r\n- try to infer the ETAG/Digest from the filename if no digest file exists\r\n -> 6f7dc7a4eb8d1b529ab33e9ddbd7ea220fc01308-vendor.js will have ETAG 6f7dc7a4eb8d1b529ab33e9ddbd7ea220fc01308 infered from its name. \r\n\r\n- correctly calculate the GZIP url also if a digested version exists\r\n -> previously, if a digest file existed, the incorrect gzip version was used. \r\n\r\n- correctly infer digest from filename \r\n -> previously the filename itself was used incorrectly, e.g. main.js digest was itself \"main.js\" instead of \"\"\r\n- If digested file is requested and found, serve it instead of barefile\r\n -> if we have 6f7dc7a4eb8d1b529ab33e9ddbd7ea220fc01308-main.js serve it instead of main.js\r\n- if a file with a different digest (e.g. from a previous version of the assets) is requested, check if it is available and serve it eventually\r\n- if a asset is requested without a digest (e.g. just \"vendor.js\"), see if we have a digest for it and serve the digested version with correct ETAG"},"comment":{"url":"https://api.github.com/repos/playframework/playframework/issues/comments/254644085","html_url":"https://github.com/playframework/playframework/pull/6552#issuecomment-254644085","issue_url":"https://api.github.com/repos/playframework/playframework/issues/6552","id":254644085,"user":{"login":"shkhln","id":4892265,"avatar_url":"https://avatars.githubusercontent.com/u/4892265?v=3","gravatar_id":"","url":"https://api.github.com/users/shkhln","html_url":"https://github.com/shkhln","followers_url":"https://api.github.com/users/shkhln/followers","following_url":"https://api.github.com/users/shkhln/following{/other_user}","gists_url":"https://api.github.com/users/shkhln/gists{/gist_id}","starred_url":"https://api.github.com/users/shkhln/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shkhln/subscriptions","organizations_url":"https://api.github.com/users/shkhln/orgs","repos_url":"https://api.github.com/users/shkhln/repos","events_url":"https://api.github.com/users/shkhln/events{/privacy}","received_events_url":"https://api.github.com/users/shkhln/received_events","type":"User","site_admin":false},"created_at":"2016-10-18T21:25:35Z","updated_at":"2016-10-18T21:25:35Z","body":"No, there is no need to make it configurable. Keep that behavior if you like it.\r\n\r\nIn my opinion it's better (for code complexity and readability reasons) to treat digested and non-digested files as totally separate files with no relation to each other. It makes sense to me, because that's like typical web server already works. If there is some logic in asset controller that can't easily replicated with, say, nginx config, then maybe there is too much logic."}}
{"actor":{"display_login":"shkhln"}}