{"action":"created","comment":{"url":"https://api.github.com/repos/hmc-cs111-fall2016/practice-scala/pulls/comments/81291701","pull_request_review_id":2272759,"id":81291701,"diff_hunk":"@@ -113,9 +99,7 @@ object Collections {\n    * As always, use either build-in functions, or roll your own way via a\n    * pattern match or some other method.\n    */\n-  def oddElements(iList: List[Int]): List[Int] = {\n-    error(\"fix me\")\n-  }\n+  def oddElements(iList: List[Int]): List[Int] = iList.foldRight(List(): List[Int])({(l,acc) => if (l % 2 != 0)  l::acc else acc })","path":"src/main/scala/exercises/06_Collections.scala","position":81,"original_position":81,"commit_id":"acf098bd5e4a37bf7777707fadbd9253dc28c128","original_commit_id":"acf098bd5e4a37bf7777707fadbd9253dc28c128","user":{"login":"farhanatt","id":21352602,"avatar_url":"https://avatars.githubusercontent.com/u/21352602?v=3","gravatar_id":"","url":"https://api.github.com/users/farhanatt","html_url":"https://github.com/farhanatt","followers_url":"https://api.github.com/users/farhanatt/followers","following_url":"https://api.github.com/users/farhanatt/following{/other_user}","gists_url":"https://api.github.com/users/farhanatt/gists{/gist_id}","starred_url":"https://api.github.com/users/farhanatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/farhanatt/subscriptions","organizations_url":"https://api.github.com/users/farhanatt/orgs","repos_url":"https://api.github.com/users/farhanatt/repos","events_url":"https://api.github.com/users/farhanatt/events{/privacy}","received_events_url":"https://api.github.com/users/farhanatt/received_events","type":"User","site_admin":false},"body":"I chose to use `filter` for this one, which results in a slightly shorter implementation.  Why did you decide to use `foldRight` instead of `fold` or `foldLeft` though?  To me, it would be more intuitive to use `foldLeft` and append to the end of the empty list.  I know I had trouble and spent unnecessary time figuring out how to append to the end of the list. Was this also possibly your motivation for using `foldRight`?","created_at":"2016-09-30T07:43:47Z","updated_at":"2016-09-30T07:45:22Z","html_url":"https://github.com/hmc-cs111-fall2016/practice-scala/pull/7#discussion_r81291701","pull_request_url":"https://api.github.com/repos/hmc-cs111-fall2016/practice-scala/pulls/7","_links":{"self":{"href":"https://api.github.com/repos/hmc-cs111-fall2016/practice-scala/pulls/comments/81291701"},"html":{"href":"https://github.com/hmc-cs111-fall2016/practice-scala/pull/7#discussion_r81291701"},"pull_request":{"href":"https://api.github.com/repos/hmc-cs111-fall2016/practice-scala/pulls/7"}}},"pull_request":{"url":"https://api.github.com/repos/hmc-cs111-fall2016/practice-scala/pulls/7","id":87239240,"html_url":"https://github.com/hmc-cs111-fall2016/practice-scala/pull/7","diff_url":"https://github.com/hmc-cs111-fall2016/practice-scala/pull/7.diff","patch_url":"https://github.com/hmc-cs111-fall2016/practice-scala/pull/7.patch","issue_url":"https://api.github.com/repos/hmc-cs111-fall2016/practice-scala/issues/7","number":7,"state":"open","locked":false,"title":"Ross Wollman","user":{"login":"rwoll-hmc","id":21327633,"avatar_url":"https://avatars.githubusercontent.com/u/21327633?v=3","gravatar_id":"","url":"https://api.github.com/users/rwoll-hmc","html_url":"https://github.com/rwoll-hmc","followers_url":"https://api.github.com/users/rwoll-hmc/followers","following_url":"https://api.github.com/users/rwoll-hmc/following{/other_user}","gists_url":"https://api.github.com/users/rwoll-hmc/gists{/gist_id}","starred_url":"https://api.github.com/users/rwoll-hmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwoll-hmc/subscriptions","organizations_url":"https://api.github.com/users/rwoll-hmc/orgs","repos_url":"https://api.github.com/users/rwoll-hmc/repos","events_url":"https://api.github.com/users/rwoll-hmc/events{/privacy}","received_events_url":"https://api.github.com/users/rwoll-hmc/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-09-29T03:09:17Z","updated_at":"2016-09-30T07:45:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"177b9d732f21caa5bd300c375287e2ba80d5e565","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/hmc-cs111-fall2016/practice-scala/pulls/7/commits","review_comments_url":"https://api.github.com/repos/hmc-cs111-fall2016/practice-scala/pulls/7/comments","review_comment_url":"https://api.github.com/repos/hmc-cs111-fall2016/practice-scala/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hmc-cs111-fall2016/practice-scala/issues/7/comments","statuses_url":"https://api.github.com/repos/hmc-cs111-fall2016/practice-scala/statuses/acf098bd5e4a37bf7777707fadbd9253dc28c128","head":{"label":"rwoll-hmc:master","ref":"master","sha":"acf098bd5e4a37bf7777707fadbd9253dc28c128","user":{"login":"rwoll-hmc","id":21327633,"avatar_url":"https://avatars.githubusercontent.com/u/21327633?v=3","gravatar_id":"","url":"https://api.github.com/users/rwoll-hmc","html_url":"https://github.com/rwoll-hmc","followers_url":"https://api.github.com/users/rwoll-hmc/followers","following_url":"https://api.github.com/users/rwoll-hmc/following{/other_user}","gists_url":"https://api.github.com/users/rwoll-hmc/gists{/gist_id}","starred_url":"https://api.github.com/users/rwoll-hmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwoll-hmc/subscriptions","organizations_url":"https://api.github.com/users/rwoll-hmc/orgs","repos_url":"https://api.github.com/users/rwoll-hmc/repos","events_url":"https://api.github.com/users/rwoll-hmc/events{/privacy}","received_events_url":"https://api.github.com/users/rwoll-hmc/received_events","type":"User","site_admin":false},"repo":{"id":69509929,"name":"practice-scala","full_name":"rwoll-hmc/practice-scala","owner":{"login":"rwoll-hmc","id":21327633,"avatar_url":"https://avatars.githubusercontent.com/u/21327633?v=3","gravatar_id":"","url":"https://api.github.com/users/rwoll-hmc","html_url":"https://github.com/rwoll-hmc","followers_url":"https://api.github.com/users/rwoll-hmc/followers","following_url":"https://api.github.com/users/rwoll-hmc/following{/other_user}","gists_url":"https://api.github.com/users/rwoll-hmc/gists{/gist_id}","starred_url":"https://api.github.com/users/rwoll-hmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwoll-hmc/subscriptions","organizations_url":"https://api.github.com/users/rwoll-hmc/orgs","repos_url":"https://api.github.com/users/rwoll-hmc/repos","events_url":"https://api.github.com/users/rwoll-hmc/events{/privacy}","received_events_url":"https://api.github.com/users/rwoll-hmc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rwoll-hmc/practice-scala","description":null,"fork":true,"url":"https://api.github.com/repos/rwoll-hmc/practice-scala","forks_url":"https://api.github.com/repos/rwoll-hmc/practice-scala/forks","keys_url":"https://api.github.com/repos/rwoll-hmc/practice-scala/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rwoll-hmc/practice-scala/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rwoll-hmc/practice-scala/teams","hooks_url":"https://api.github.com/repos/rwoll-hmc/practice-scala/hooks","issue_events_url":"https://api.github.com/repos/rwoll-hmc/practice-scala/issues/events{/number}","events_url":"https://api.github.com/repos/rwoll-hmc/practice-scala/events","assignees_url":"https://api.github.com/repos/rwoll-hmc/practice-scala/assignees{/user}","branches_url":"https://api.github.com/repos/rwoll-hmc/practice-scala/branches{/branch}","tags_url":"https://api.github.com/repos/rwoll-hmc/practice-scala/tags","blobs_url":"https://api.github.com/repos/rwoll-hmc/practice-scala/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rwoll-hmc/practice-scala/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rwoll-hmc/practice-scala/git/refs{/sha}","trees_url":"https://api.github.com/repos/rwoll-hmc/practice-scala/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rwoll-hmc/practice-scala/statuses/{sha}","languages_url":"https://api.github.com/repos/rwoll-hmc/practice-scala/languages","stargazers_url":"https://api.github.com/repos/rwoll-hmc/practice-scala/stargazers","contributors_url":"https://api.github.com/repos/rwoll-hmc/practice-scala/contributors","subscribers_url":"https://api.github.com/repos/rwoll-hmc/practice-scala/subscribers","subscription_url":"https://api.github.com/repos/rwoll-hmc/practice-scala/subscription","commits_url":"https://api.github.com/repos/rwoll-hmc/practice-scala/commits{/sha}","git_commits_url":"https://api.github.com/repos/rwoll-hmc/practice-scala/git/commits{/sha}","comments_url":"https://api.github.com/repos/rwoll-hmc/practice-scala/comments{/number}","issue_comment_url":"https://api.github.com/repos/rwoll-hmc/practice-scala/issues/comments{/number}","contents_url":"https://api.github.com/repos/rwoll-hmc/practice-scala/contents/{+path}","compare_url":"https://api.github.com/repos/rwoll-hmc/practice-scala/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rwoll-hmc/practice-scala/merges","archive_url":"https://api.github.com/repos/rwoll-hmc/practice-scala/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rwoll-hmc/practice-scala/downloads","issues_url":"https://api.github.com/repos/rwoll-hmc/practice-scala/issues{/number}","pulls_url":"https://api.github.com/repos/rwoll-hmc/practice-scala/pulls{/number}","milestones_url":"https://api.github.com/repos/rwoll-hmc/practice-scala/milestones{/number}","notifications_url":"https://api.github.com/repos/rwoll-hmc/practice-scala/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rwoll-hmc/practice-scala/labels{/name}","releases_url":"https://api.github.com/repos/rwoll-hmc/practice-scala/releases{/id}","deployments_url":"https://api.github.com/repos/rwoll-hmc/practice-scala/deployments","created_at":"2016-09-28T22:48:54Z","updated_at":"2016-09-28T22:48:55Z","pushed_at":"2016-09-29T03:08:37Z","git_url":"git://github.com/rwoll-hmc/practice-scala.git","ssh_url":"git@github.com:rwoll-hmc/practice-scala.git","clone_url":"https://github.com/rwoll-hmc/practice-scala.git","svn_url":"https://github.com/rwoll-hmc/practice-scala","homepage":null,"size":28,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hmc-cs111-fall2016:master","ref":"master","sha":"2dc8f2ed9b3d815a55a37c1d19876b964f19aaa7","user":{"login":"hmc-cs111-fall2016","id":20343278,"avatar_url":"https://avatars.githubusercontent.com/u/20343278?v=3","gravatar_id":"","url":"https://api.github.com/users/hmc-cs111-fall2016","html_url":"https://github.com/hmc-cs111-fall2016","followers_url":"https://api.github.com/users/hmc-cs111-fall2016/followers","following_url":"https://api.github.com/users/hmc-cs111-fall2016/following{/other_user}","gists_url":"https://api.github.com/users/hmc-cs111-fall2016/gists{/gist_id}","starred_url":"https://api.github.com/users/hmc-cs111-fall2016/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmc-cs111-fall2016/subscriptions","organizations_url":"https://api.github.com/users/hmc-cs111-fall2016/orgs","repos_url":"https://api.github.com/users/hmc-cs111-fall2016/repos","events_url":"https://api.github.com/users/hmc-cs111-fall2016/events{/privacy}","received_events_url":"https://api.github.com/users/hmc-cs111-fall2016/received_events","type":"Organization","site_admin":false},"repo":{"id":68844626,"name":"practice-scala","full_name":"hmc-cs111-fall2016/practice-scala","owner":{"login":"hmc-cs111-fall2016","id":20343278,"avatar_url":"https://avatars.githubusercontent.com/u/20343278?v=3","gravatar_id":"","url":"https://api.github.com/users/hmc-cs111-fall2016","html_url":"https://github.com/hmc-cs111-fall2016","followers_url":"https://api.github.com/users/hmc-cs111-fall2016/followers","following_url":"https://api.github.com/users/hmc-cs111-fall2016/following{/other_user}","gists_url":"https://api.github.com/users/hmc-cs111-fall2016/gists{/gist_id}","starred_url":"https://api.github.com/users/hmc-cs111-fall2016/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmc-cs111-fall2016/subscriptions","organizations_url":"https://api.github.com/users/hmc-cs111-fall2016/orgs","repos_url":"https://api.github.com/users/hmc-cs111-fall2016/repos","events_url":"https://api.github.com/users/hmc-cs111-fall2016/events{/privacy}","received_events_url":"https://api.github.com/users/hmc-cs111-fall2016/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hmc-cs111-fall2016/practice-scala","description":null,"fork":false,"url":"https://api.github.com/repos/hmc-cs111-fall2016/practice-scala","forks_url":"https://api.github.com/repos/hmc-cs111-fall2016/practice-scala/forks","keys_url":"https://api.github.com/repos/hmc-cs111-fall2016/practice-scala/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hmc-cs111-fall2016/practice-scala/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hmc-cs111-fall2016/practice-scala/teams","hooks_url":"https://api.github.com/repos/hmc-cs111-fall2016/practice-scala/hooks","issue_events_url":"https://api.github.com/repos/hmc-cs111-fall2016/practice-scala/issues/events{/number}","events_url":"https://api.github.com/repos/hmc-cs111-fall2016/practice-scala/events","assignees_url":"https://api.github.com/repos/hmc-cs111-fall2016/practice-scala/assignees{/user}","branches_url":"https://api.github.com/repos/hmc-cs111-fall2016/practice-scala/branches{/branch}","tags_url":"https://api.github.com/repos/hmc-cs111-fall2016/practice-scala/tags","blobs_url":"https://api.github.com/repos/hmc-cs111-fall2016/practice-scala/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hmc-cs111-fall2016/practice-scala/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hmc-cs111-fall2016/practice-scala/git/refs{/sha}","trees_url":"https://api.github.com/repos/hmc-cs111-fall2016/practice-scala/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hmc-cs111-fall2016/practice-scala/statuses/{sha}","languages_url":"https://api.github.com/repos/hmc-cs111-fall2016/practice-scala/languages","stargazers_url":"https://api.github.com/repos/hmc-cs111-fall2016/practice-scala/stargazers","contributors_url":"https://api.github.com/repos/hmc-cs111-fall2016/practice-scala/contributors","subscribers_url":"https://api.github.com/repos/hmc-cs111-fall2016/practice-scala/subscribers","subscription_url":"https://api.github.com/repos/hmc-cs111-fall2016/practice-scala/subscription","commits_url":"https://api.github.com/repos/hmc-cs111-fall2016/practice-scala/commits{/sha}","git_commits_url":"https://api.github.com/repos/hmc-cs111-fall2016/practice-scala/git/commits{/sha}","comments_url":"https://api.github.com/repos/hmc-cs111-fall2016/practice-scala/comments{/number}","issue_comment_url":"https://api.github.com/repos/hmc-cs111-fall2016/practice-scala/issues/comments{/number}","contents_url":"https://api.github.com/repos/hmc-cs111-fall2016/practice-scala/contents/{+path}","compare_url":"https://api.github.com/repos/hmc-cs111-fall2016/practice-scala/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hmc-cs111-fall2016/practice-scala/merges","archive_url":"https://api.github.com/repos/hmc-cs111-fall2016/practice-scala/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hmc-cs111-fall2016/practice-scala/downloads","issues_url":"https://api.github.com/repos/hmc-cs111-fall2016/practice-scala/issues{/number}","pulls_url":"https://api.github.com/repos/hmc-cs111-fall2016/practice-scala/pulls{/number}","milestones_url":"https://api.github.com/repos/hmc-cs111-fall2016/practice-scala/milestones{/number}","notifications_url":"https://api.github.com/repos/hmc-cs111-fall2016/practice-scala/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hmc-cs111-fall2016/practice-scala/labels{/name}","releases_url":"https://api.github.com/repos/hmc-cs111-fall2016/practice-scala/releases{/id}","deployments_url":"https://api.github.com/repos/hmc-cs111-fall2016/practice-scala/deployments","created_at":"2016-09-21T18:09:18Z","updated_at":"2016-09-21T18:17:49Z","pushed_at":"2016-09-29T08:35:48Z","git_url":"git://github.com/hmc-cs111-fall2016/practice-scala.git","ssh_url":"git@github.com:hmc-cs111-fall2016/practice-scala.git","clone_url":"https://github.com/hmc-cs111-fall2016/practice-scala.git","svn_url":"https://github.com/hmc-cs111-fall2016/practice-scala","homepage":null,"size":35,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":17,"forks":18,"open_issues":17,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hmc-cs111-fall2016/practice-scala/pulls/7"},"html":{"href":"https://github.com/hmc-cs111-fall2016/practice-scala/pull/7"},"issue":{"href":"https://api.github.com/repos/hmc-cs111-fall2016/practice-scala/issues/7"},"comments":{"href":"https://api.github.com/repos/hmc-cs111-fall2016/practice-scala/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/hmc-cs111-fall2016/practice-scala/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/hmc-cs111-fall2016/practice-scala/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hmc-cs111-fall2016/practice-scala/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/hmc-cs111-fall2016/practice-scala/statuses/acf098bd5e4a37bf7777707fadbd9253dc28c128"}}}}
{"actor":{"display_login":"farhanatt"}}