{"action":"created","issue":{"url":"https://api.github.com/repos/pkp/pkp-lib/issues/1099","repository_url":"https://api.github.com/repos/pkp/pkp-lib","labels_url":"https://api.github.com/repos/pkp/pkp-lib/issues/1099/labels{/name}","comments_url":"https://api.github.com/repos/pkp/pkp-lib/issues/1099/comments","events_url":"https://api.github.com/repos/pkp/pkp-lib/issues/1099/events","html_url":"https://github.com/pkp/pkp-lib/issues/1099","id":129263021,"number":1099,"title":"[OMP] some emails have placeholders unreplaced","user":{"login":"crism","id":1933900,"avatar_url":"https://avatars.githubusercontent.com/u/1933900?v=3","gravatar_id":"","url":"https://api.github.com/users/crism","html_url":"https://github.com/crism","followers_url":"https://api.github.com/users/crism/followers","following_url":"https://api.github.com/users/crism/following{/other_user}","gists_url":"https://api.github.com/users/crism/gists{/gist_id}","starred_url":"https://api.github.com/users/crism/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crism/subscriptions","organizations_url":"https://api.github.com/users/crism/orgs","repos_url":"https://api.github.com/users/crism/repos","events_url":"https://api.github.com/users/crism/events{/privacy}","received_events_url":"https://api.github.com/users/crism/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/pkp/pkp-lib/labels/Open%20Monograph%20Press","name":"Open Monograph Press","color":"a2c6dc"}],"state":"closed","locked":false,"assignee":{"login":"asmecher","id":200411,"avatar_url":"https://avatars.githubusercontent.com/u/200411?v=3","gravatar_id":"","url":"https://api.github.com/users/asmecher","html_url":"https://github.com/asmecher","followers_url":"https://api.github.com/users/asmecher/followers","following_url":"https://api.github.com/users/asmecher/following{/other_user}","gists_url":"https://api.github.com/users/asmecher/gists{/gist_id}","starred_url":"https://api.github.com/users/asmecher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asmecher/subscriptions","organizations_url":"https://api.github.com/users/asmecher/orgs","repos_url":"https://api.github.com/users/asmecher/repos","events_url":"https://api.github.com/users/asmecher/events{/privacy}","received_events_url":"https://api.github.com/users/asmecher/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/pkp/pkp-lib/milestones/4","html_url":"https://github.com/pkp/pkp-lib/milestones/OMP%201.2","labels_url":"https://api.github.com/repos/pkp/pkp-lib/milestones/4/labels","id":892323,"number":4,"title":"OMP 1.2","description":"OMP 1.2 is a major revision of OMP building on the stable OMP 1.1.1 branch but adding numerous new features and changes, including Javascript library upgrades, a move to Composer for dependency management, and more.","creator":{"login":"asmecher","id":200411,"avatar_url":"https://avatars.githubusercontent.com/u/200411?v=3","gravatar_id":"","url":"https://api.github.com/users/asmecher","html_url":"https://github.com/asmecher","followers_url":"https://api.github.com/users/asmecher/followers","following_url":"https://api.github.com/users/asmecher/following{/other_user}","gists_url":"https://api.github.com/users/asmecher/gists{/gist_id}","starred_url":"https://api.github.com/users/asmecher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asmecher/subscriptions","organizations_url":"https://api.github.com/users/asmecher/orgs","repos_url":"https://api.github.com/users/asmecher/repos","events_url":"https://api.github.com/users/asmecher/events{/privacy}","received_events_url":"https://api.github.com/users/asmecher/received_events","type":"User","site_admin":false},"open_issues":25,"closed_issues":87,"state":"open","created_at":"2014-12-04T23:55:42Z","updated_at":"2016-02-02T20:17:22Z","due_on":null,"closed_at":null},"comments":3,"created_at":"2016-01-27T20:42:14Z","updated_at":"2016-02-02T20:17:22Z","closed_at":"2016-02-02T20:17:22Z","body":"For example, when thanking a reviewer, the reviewer receives this email:\r\n```\r\nThe following message is being delivered on behalf of {$contextName}.\r\n\r\n________________________________________________________________________\r\n\r\n\r\n{$reviewerName}:\r\n \r\n Thank you for completing the review of the submission,\r\n\"{$submissionTitle},\" for {$contextName}. We appreciate your contribution to\r\nthe quality of the work that we publish.\r\n \r\n {$editorialContactSignature} \r\n ________________________________________________________________________\r\n {$contextName}\r\n\r\n\r\n\r\n________________________________________________________________________\r\n\r\n{$contextName}\r\n```\r\nIt appears that `ThankReviewerForm\\execute()` never performs substitution on the body of the email. I’m not sure whether `execute()` should be changed, or if the call should be replaced by `send()`."},"comment":{"url":"https://api.github.com/repos/pkp/pkp-lib/issues/comments/178800056","html_url":"https://github.com/pkp/pkp-lib/issues/1099#issuecomment-178800056","issue_url":"https://api.github.com/repos/pkp/pkp-lib/issues/1099","id":178800056,"user":{"login":"asmecher","id":200411,"avatar_url":"https://avatars.githubusercontent.com/u/200411?v=3","gravatar_id":"","url":"https://api.github.com/users/asmecher","html_url":"https://github.com/asmecher","followers_url":"https://api.github.com/users/asmecher/followers","following_url":"https://api.github.com/users/asmecher/following{/other_user}","gists_url":"https://api.github.com/users/asmecher/gists{/gist_id}","starred_url":"https://api.github.com/users/asmecher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asmecher/subscriptions","organizations_url":"https://api.github.com/users/asmecher/orgs","repos_url":"https://api.github.com/users/asmecher/repos","events_url":"https://api.github.com/users/asmecher/events{/privacy}","received_events_url":"https://api.github.com/users/asmecher/received_events","type":"User","site_admin":false},"created_at":"2016-02-02T20:17:22Z","updated_at":"2016-02-02T20:17:22Z","body":"OK! We'll be testing emails over the next couple of weeks, too -- they haven't received much attention. Please file anything else you spot separately. Thanks for contributing!"}}