{"action":"closed","number":30,"pull_request":{"url":"https://api.github.com/repos/redbooth/percona_migrator/pulls/30","id":67647745,"html_url":"https://github.com/redbooth/percona_migrator/pull/30","diff_url":"https://github.com/redbooth/percona_migrator/pull/30.diff","patch_url":"https://github.com/redbooth/percona_migrator/pull/30.patch","issue_url":"https://api.github.com/repos/redbooth/percona_migrator/issues/30","number":30,"state":"closed","locked":false,"title":"Support for Rails 4.0","user":{"login":"sauloperez","id":762088,"avatar_url":"https://avatars.githubusercontent.com/u/762088?v=3","gravatar_id":"","url":"https://api.github.com/users/sauloperez","html_url":"https://github.com/sauloperez","followers_url":"https://api.github.com/users/sauloperez/followers","following_url":"https://api.github.com/users/sauloperez/following{/other_user}","gists_url":"https://api.github.com/users/sauloperez/gists{/gist_id}","starred_url":"https://api.github.com/users/sauloperez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sauloperez/subscriptions","organizations_url":"https://api.github.com/users/sauloperez/orgs","repos_url":"https://api.github.com/users/sauloperez/repos","events_url":"https://api.github.com/users/sauloperez/events{/privacy}","received_events_url":"https://api.github.com/users/sauloperez/received_events","type":"User","site_admin":false},"body":"First, I set up Appraisal to allow running the specs against a Rails-4.0-compatible version. Apparently though, might be tricky to support both 3 and 4 versions with the same codebase and so having a branch per version could be better. In that case, there is no need for Appraisal.\n## Found issues\n- [x] #exec_insert allows :pk and :sequence_name as optional params\n- [x] #new_column allows :extra as optional param\n- [x] #select's return value must respond to #columns\n- [x] Column classes specs have to be TZ agnostic\n- [x] #select_one, #select_value accept `:binds` as optional argument. Not used in MySQL; no prepared statements...\n- [x] #remove_column now uses ALTER TABLE syntax. But nothing done; we didn't implement it.\n- [x] new #rename_index(index_name, new_index_name)\n- [x] new #change_column_null(table_name, column_name, null, default = nil). Not doc in migration.rb\n- [x] new #add_reference(table_name, ref_name, options = {})\n- [x] new #remove_reference(table_name, ref_name, options = {})\n- [x] new #set_field_encoding(field_name)\n- [x] new #add_timestamps(table_name)\n- [x] new #remove_timestamps(table_name)\n- [x] new #rename_table(table_name, new_name)\n- [x] new #rename_column(table_name, column_name, new_column_name)\n","created_at":"2016-04-24T19:48:20Z","updated_at":"2016-11-29T12:30:14Z","closed_at":"2016-11-29T12:30:14Z","merged_at":"2016-11-29T12:30:14Z","merge_commit_sha":"bacf615f614ac04a2be952a9d65a74a754368ab0","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/redbooth/percona_migrator/pulls/30/commits","review_comments_url":"https://api.github.com/repos/redbooth/percona_migrator/pulls/30/comments","review_comment_url":"https://api.github.com/repos/redbooth/percona_migrator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/redbooth/percona_migrator/issues/30/comments","statuses_url":"https://api.github.com/repos/redbooth/percona_migrator/statuses/ca8055087365186bc891ebf0acc59b34c777193a","head":{"label":"redbooth:rails-4","ref":"rails-4","sha":"ca8055087365186bc891ebf0acc59b34c777193a","user":{"login":"redbooth","id":7304334,"avatar_url":"https://avatars.githubusercontent.com/u/7304334?v=3","gravatar_id":"","url":"https://api.github.com/users/redbooth","html_url":"https://github.com/redbooth","followers_url":"https://api.github.com/users/redbooth/followers","following_url":"https://api.github.com/users/redbooth/following{/other_user}","gists_url":"https://api.github.com/users/redbooth/gists{/gist_id}","starred_url":"https://api.github.com/users/redbooth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redbooth/subscriptions","organizations_url":"https://api.github.com/users/redbooth/orgs","repos_url":"https://api.github.com/users/redbooth/repos","events_url":"https://api.github.com/users/redbooth/events{/privacy}","received_events_url":"https://api.github.com/users/redbooth/received_events","type":"Organization","site_admin":false},"repo":{"id":47969607,"name":"percona_migrator","full_name":"redbooth/percona_migrator","owner":{"login":"redbooth","id":7304334,"avatar_url":"https://avatars.githubusercontent.com/u/7304334?v=3","gravatar_id":"","url":"https://api.github.com/users/redbooth","html_url":"https://github.com/redbooth","followers_url":"https://api.github.com/users/redbooth/followers","following_url":"https://api.github.com/users/redbooth/following{/other_user}","gists_url":"https://api.github.com/users/redbooth/gists{/gist_id}","starred_url":"https://api.github.com/users/redbooth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redbooth/subscriptions","organizations_url":"https://api.github.com/users/redbooth/orgs","repos_url":"https://api.github.com/users/redbooth/repos","events_url":"https://api.github.com/users/redbooth/events{/privacy}","received_events_url":"https://api.github.com/users/redbooth/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/redbooth/percona_migrator","description":"Percona's pt-online-schema-change runner for ActiveRecord migrations","fork":false,"url":"https://api.github.com/repos/redbooth/percona_migrator","forks_url":"https://api.github.com/repos/redbooth/percona_migrator/forks","keys_url":"https://api.github.com/repos/redbooth/percona_migrator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/redbooth/percona_migrator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/redbooth/percona_migrator/teams","hooks_url":"https://api.github.com/repos/redbooth/percona_migrator/hooks","issue_events_url":"https://api.github.com/repos/redbooth/percona_migrator/issues/events{/number}","events_url":"https://api.github.com/repos/redbooth/percona_migrator/events","assignees_url":"https://api.github.com/repos/redbooth/percona_migrator/assignees{/user}","branches_url":"https://api.github.com/repos/redbooth/percona_migrator/branches{/branch}","tags_url":"https://api.github.com/repos/redbooth/percona_migrator/tags","blobs_url":"https://api.github.com/repos/redbooth/percona_migrator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/redbooth/percona_migrator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/redbooth/percona_migrator/git/refs{/sha}","trees_url":"https://api.github.com/repos/redbooth/percona_migrator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/redbooth/percona_migrator/statuses/{sha}","languages_url":"https://api.github.com/repos/redbooth/percona_migrator/languages","stargazers_url":"https://api.github.com/repos/redbooth/percona_migrator/stargazers","contributors_url":"https://api.github.com/repos/redbooth/percona_migrator/contributors","subscribers_url":"https://api.github.com/repos/redbooth/percona_migrator/subscribers","subscription_url":"https://api.github.com/repos/redbooth/percona_migrator/subscription","commits_url":"https://api.github.com/repos/redbooth/percona_migrator/commits{/sha}","git_commits_url":"https://api.github.com/repos/redbooth/percona_migrator/git/commits{/sha}","comments_url":"https://api.github.com/repos/redbooth/percona_migrator/comments{/number}","issue_comment_url":"https://api.github.com/repos/redbooth/percona_migrator/issues/comments{/number}","contents_url":"https://api.github.com/repos/redbooth/percona_migrator/contents/{+path}","compare_url":"https://api.github.com/repos/redbooth/percona_migrator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/redbooth/percona_migrator/merges","archive_url":"https://api.github.com/repos/redbooth/percona_migrator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/redbooth/percona_migrator/downloads","issues_url":"https://api.github.com/repos/redbooth/percona_migrator/issues{/number}","pulls_url":"https://api.github.com/repos/redbooth/percona_migrator/pulls{/number}","milestones_url":"https://api.github.com/repos/redbooth/percona_migrator/milestones{/number}","notifications_url":"https://api.github.com/repos/redbooth/percona_migrator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/redbooth/percona_migrator/labels{/name}","releases_url":"https://api.github.com/repos/redbooth/percona_migrator/releases{/id}","deployments_url":"https://api.github.com/repos/redbooth/percona_migrator/deployments","created_at":"2015-12-14T11:00:12Z","updated_at":"2016-11-24T09:16:55Z","pushed_at":"2016-11-29T12:30:15Z","git_url":"git://github.com/redbooth/percona_migrator.git","ssh_url":"git@github.com:redbooth/percona_migrator.git","clone_url":"https://github.com/redbooth/percona_migrator.git","svn_url":"https://github.com/redbooth/percona_migrator","homepage":"","size":243,"stargazers_count":7,"watchers_count":7,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":0,"forks":3,"open_issues":0,"watchers":7,"default_branch":"master"}},"base":{"label":"redbooth:master","ref":"master","sha":"3ea96c46302d483011c8b8ad1271a6c39dafa3f4","user":{"login":"redbooth","id":7304334,"avatar_url":"https://avatars.githubusercontent.com/u/7304334?v=3","gravatar_id":"","url":"https://api.github.com/users/redbooth","html_url":"https://github.com/redbooth","followers_url":"https://api.github.com/users/redbooth/followers","following_url":"https://api.github.com/users/redbooth/following{/other_user}","gists_url":"https://api.github.com/users/redbooth/gists{/gist_id}","starred_url":"https://api.github.com/users/redbooth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redbooth/subscriptions","organizations_url":"https://api.github.com/users/redbooth/orgs","repos_url":"https://api.github.com/users/redbooth/repos","events_url":"https://api.github.com/users/redbooth/events{/privacy}","received_events_url":"https://api.github.com/users/redbooth/received_events","type":"Organization","site_admin":false},"repo":{"id":47969607,"name":"percona_migrator","full_name":"redbooth/percona_migrator","owner":{"login":"redbooth","id":7304334,"avatar_url":"https://avatars.githubusercontent.com/u/7304334?v=3","gravatar_id":"","url":"https://api.github.com/users/redbooth","html_url":"https://github.com/redbooth","followers_url":"https://api.github.com/users/redbooth/followers","following_url":"https://api.github.com/users/redbooth/following{/other_user}","gists_url":"https://api.github.com/users/redbooth/gists{/gist_id}","starred_url":"https://api.github.com/users/redbooth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redbooth/subscriptions","organizations_url":"https://api.github.com/users/redbooth/orgs","repos_url":"https://api.github.com/users/redbooth/repos","events_url":"https://api.github.com/users/redbooth/events{/privacy}","received_events_url":"https://api.github.com/users/redbooth/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/redbooth/percona_migrator","description":"Percona's pt-online-schema-change runner for ActiveRecord migrations","fork":false,"url":"https://api.github.com/repos/redbooth/percona_migrator","forks_url":"https://api.github.com/repos/redbooth/percona_migrator/forks","keys_url":"https://api.github.com/repos/redbooth/percona_migrator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/redbooth/percona_migrator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/redbooth/percona_migrator/teams","hooks_url":"https://api.github.com/repos/redbooth/percona_migrator/hooks","issue_events_url":"https://api.github.com/repos/redbooth/percona_migrator/issues/events{/number}","events_url":"https://api.github.com/repos/redbooth/percona_migrator/events","assignees_url":"https://api.github.com/repos/redbooth/percona_migrator/assignees{/user}","branches_url":"https://api.github.com/repos/redbooth/percona_migrator/branches{/branch}","tags_url":"https://api.github.com/repos/redbooth/percona_migrator/tags","blobs_url":"https://api.github.com/repos/redbooth/percona_migrator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/redbooth/percona_migrator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/redbooth/percona_migrator/git/refs{/sha}","trees_url":"https://api.github.com/repos/redbooth/percona_migrator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/redbooth/percona_migrator/statuses/{sha}","languages_url":"https://api.github.com/repos/redbooth/percona_migrator/languages","stargazers_url":"https://api.github.com/repos/redbooth/percona_migrator/stargazers","contributors_url":"https://api.github.com/repos/redbooth/percona_migrator/contributors","subscribers_url":"https://api.github.com/repos/redbooth/percona_migrator/subscribers","subscription_url":"https://api.github.com/repos/redbooth/percona_migrator/subscription","commits_url":"https://api.github.com/repos/redbooth/percona_migrator/commits{/sha}","git_commits_url":"https://api.github.com/repos/redbooth/percona_migrator/git/commits{/sha}","comments_url":"https://api.github.com/repos/redbooth/percona_migrator/comments{/number}","issue_comment_url":"https://api.github.com/repos/redbooth/percona_migrator/issues/comments{/number}","contents_url":"https://api.github.com/repos/redbooth/percona_migrator/contents/{+path}","compare_url":"https://api.github.com/repos/redbooth/percona_migrator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/redbooth/percona_migrator/merges","archive_url":"https://api.github.com/repos/redbooth/percona_migrator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/redbooth/percona_migrator/downloads","issues_url":"https://api.github.com/repos/redbooth/percona_migrator/issues{/number}","pulls_url":"https://api.github.com/repos/redbooth/percona_migrator/pulls{/number}","milestones_url":"https://api.github.com/repos/redbooth/percona_migrator/milestones{/number}","notifications_url":"https://api.github.com/repos/redbooth/percona_migrator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/redbooth/percona_migrator/labels{/name}","releases_url":"https://api.github.com/repos/redbooth/percona_migrator/releases{/id}","deployments_url":"https://api.github.com/repos/redbooth/percona_migrator/deployments","created_at":"2015-12-14T11:00:12Z","updated_at":"2016-11-24T09:16:55Z","pushed_at":"2016-11-29T12:30:15Z","git_url":"git://github.com/redbooth/percona_migrator.git","ssh_url":"git@github.com:redbooth/percona_migrator.git","clone_url":"https://github.com/redbooth/percona_migrator.git","svn_url":"https://github.com/redbooth/percona_migrator","homepage":"","size":243,"stargazers_count":7,"watchers_count":7,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":0,"forks":3,"open_issues":0,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/redbooth/percona_migrator/pulls/30"},"html":{"href":"https://github.com/redbooth/percona_migrator/pull/30"},"issue":{"href":"https://api.github.com/repos/redbooth/percona_migrator/issues/30"},"comments":{"href":"https://api.github.com/repos/redbooth/percona_migrator/issues/30/comments"},"review_comments":{"href":"https://api.github.com/repos/redbooth/percona_migrator/pulls/30/comments"},"review_comment":{"href":"https://api.github.com/repos/redbooth/percona_migrator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/redbooth/percona_migrator/pulls/30/commits"},"statuses":{"href":"https://api.github.com/repos/redbooth/percona_migrator/statuses/ca8055087365186bc891ebf0acc59b34c777193a"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"franciscoj","id":186087,"avatar_url":"https://avatars.githubusercontent.com/u/186087?v=3","gravatar_id":"","url":"https://api.github.com/users/franciscoj","html_url":"https://github.com/franciscoj","followers_url":"https://api.github.com/users/franciscoj/followers","following_url":"https://api.github.com/users/franciscoj/following{/other_user}","gists_url":"https://api.github.com/users/franciscoj/gists{/gist_id}","starred_url":"https://api.github.com/users/franciscoj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/franciscoj/subscriptions","organizations_url":"https://api.github.com/users/franciscoj/orgs","repos_url":"https://api.github.com/users/franciscoj/repos","events_url":"https://api.github.com/users/franciscoj/events{/privacy}","received_events_url":"https://api.github.com/users/franciscoj/received_events","type":"User","site_admin":false},"comments":4,"review_comments":11,"commits":25,"additions":446,"deletions":86,"changed_files":23}}
{"actor":{"display_login":"franciscoj"}}