{"action":"created","comment":{"url":"https://api.github.com/repos/pymedusa/SickRage/pulls/comments/70207413","id":70207413,"diff_hunk":"@@ -0,0 +1,116 @@\n+# coding=utf-8\n+\"\"\"Guessit name parser tests.\"\"\"\n+\n+from __future__ import unicode_literals\n+\n+import os\n+import unittest\n+from io import open","path":"tests/guessit_tests.py","position":8,"original_position":8,"commit_id":"435f341bce21934e77f25d20dabbe8062b96c03d","original_commit_id":"435f341bce21934e77f25d20dabbe8062b96c03d","user":{"login":"p0psicles","id":1331394,"avatar_url":"https://avatars.githubusercontent.com/u/1331394?v=3","gravatar_id":"","url":"https://api.github.com/users/p0psicles","html_url":"https://github.com/p0psicles","followers_url":"https://api.github.com/users/p0psicles/followers","following_url":"https://api.github.com/users/p0psicles/following{/other_user}","gists_url":"https://api.github.com/users/p0psicles/gists{/gist_id}","starred_url":"https://api.github.com/users/p0psicles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/p0psicles/subscriptions","organizations_url":"https://api.github.com/users/p0psicles/orgs","repos_url":"https://api.github.com/users/p0psicles/repos","events_url":"https://api.github.com/users/p0psicles/events{/privacy}","received_events_url":"https://api.github.com/users/p0psicles/received_events","type":"User","site_admin":false},"body":"you can do from io import open as io_open\r\n","created_at":"2016-07-11T06:34:53Z","updated_at":"2016-07-11T06:34:53Z","html_url":"https://github.com/pymedusa/SickRage/pull/714#discussion_r70207413","pull_request_url":"https://api.github.com/repos/pymedusa/SickRage/pulls/714","_links":{"self":{"href":"https://api.github.com/repos/pymedusa/SickRage/pulls/comments/70207413"},"html":{"href":"https://github.com/pymedusa/SickRage/pull/714#discussion_r70207413"},"pull_request":{"href":"https://api.github.com/repos/pymedusa/SickRage/pulls/714"}}},"pull_request":{"url":"https://api.github.com/repos/pymedusa/SickRage/pulls/714","id":75238114,"html_url":"https://github.com/pymedusa/SickRage/pull/714","diff_url":"https://github.com/pymedusa/SickRage/pull/714.diff","patch_url":"https://github.com/pymedusa/SickRage/pull/714.patch","issue_url":"https://api.github.com/repos/pymedusa/SickRage/issues/714","number":714,"state":"open","locked":false,"title":"Guessit name parser implementation","user":{"login":"ratoaq2","id":9292886,"avatar_url":"https://avatars.githubusercontent.com/u/9292886?v=3","gravatar_id":"","url":"https://api.github.com/users/ratoaq2","html_url":"https://github.com/ratoaq2","followers_url":"https://api.github.com/users/ratoaq2/followers","following_url":"https://api.github.com/users/ratoaq2/following{/other_user}","gists_url":"https://api.github.com/users/ratoaq2/gists{/gist_id}","starred_url":"https://api.github.com/users/ratoaq2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ratoaq2/subscriptions","organizations_url":"https://api.github.com/users/ratoaq2/orgs","repos_url":"https://api.github.com/users/ratoaq2/repos","events_url":"https://api.github.com/users/ratoaq2/events{/privacy}","received_events_url":"https://api.github.com/users/ratoaq2/received_events","type":"User","site_admin":false},"body":"- **NameParser**: flag `use_guessit` that enables guessit name parser (default `true` on this branch). Setting it to false will keep the current parser without any change.\r\n- **GuessitNameParser**: This should be the new API and it should be really small and straightforward. Right now, it plugs in our own `rules` and it calls `guessit.guess(..)` with the correct parameters and adapt the response property names to the same ones `NameParseResult` has. I'm planning to move the `expected_titles` and `expected_groups` out of this file to a yaml file. But this list should always be short and simple. Another idea is to use the shows library to collect all shows that has numbers (since these are the problematic ones) and add them to `expected_titles`. Add all shows names is a valid option as well.\r\n- **rules/properties.py**: Additional property matches that guessit doesn't support (SATRip, BDMux, etc)\r\n- **rules/rulespy**: Manipulate `matches`. I wrote some instructions and guidelines to always have each rule simple and maintainable. Some rules are fixes/workarounds for guessit bugs. I have flagged them with each issue url, so we can remove then when guessit is fixed.\r\n- **Tests**: I have created a simple unit test that executes against an yaml file. For each regex in regexes.py and each rule in our rules.py, I added an entry in this yaml file, so they will work will regression tests. There are positive and negative test cases.\r\n","created_at":"2016-06-26T19:20:07Z","updated_at":"2016-07-11T06:34:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3be3c7ac507f182e2995ca4d54fa7242d79b9600","assignee":{"login":"ratoaq2","id":9292886,"avatar_url":"https://avatars.githubusercontent.com/u/9292886?v=3","gravatar_id":"","url":"https://api.github.com/users/ratoaq2","html_url":"https://github.com/ratoaq2","followers_url":"https://api.github.com/users/ratoaq2/followers","following_url":"https://api.github.com/users/ratoaq2/following{/other_user}","gists_url":"https://api.github.com/users/ratoaq2/gists{/gist_id}","starred_url":"https://api.github.com/users/ratoaq2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ratoaq2/subscriptions","organizations_url":"https://api.github.com/users/ratoaq2/orgs","repos_url":"https://api.github.com/users/ratoaq2/repos","events_url":"https://api.github.com/users/ratoaq2/events{/privacy}","received_events_url":"https://api.github.com/users/ratoaq2/received_events","type":"User","site_admin":false},"assignees":[{"login":"ratoaq2","id":9292886,"avatar_url":"https://avatars.githubusercontent.com/u/9292886?v=3","gravatar_id":"","url":"https://api.github.com/users/ratoaq2","html_url":"https://github.com/ratoaq2","followers_url":"https://api.github.com/users/ratoaq2/followers","following_url":"https://api.github.com/users/ratoaq2/following{/other_user}","gists_url":"https://api.github.com/users/ratoaq2/gists{/gist_id}","starred_url":"https://api.github.com/users/ratoaq2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ratoaq2/subscriptions","organizations_url":"https://api.github.com/users/ratoaq2/orgs","repos_url":"https://api.github.com/users/ratoaq2/repos","events_url":"https://api.github.com/users/ratoaq2/events{/privacy}","received_events_url":"https://api.github.com/users/ratoaq2/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/pymedusa/SickRage/milestones/9","html_url":"https://github.com/pymedusa/SickRage/milestones/0.1.3","labels_url":"https://api.github.com/repos/pymedusa/SickRage/milestones/9/labels","id":1821680,"number":9,"title":"0.1.3","description":null,"creator":{"login":"p0psicles","id":1331394,"avatar_url":"https://avatars.githubusercontent.com/u/1331394?v=3","gravatar_id":"","url":"https://api.github.com/users/p0psicles","html_url":"https://github.com/p0psicles","followers_url":"https://api.github.com/users/p0psicles/followers","following_url":"https://api.github.com/users/p0psicles/following{/other_user}","gists_url":"https://api.github.com/users/p0psicles/gists{/gist_id}","starred_url":"https://api.github.com/users/p0psicles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/p0psicles/subscriptions","organizations_url":"https://api.github.com/users/p0psicles/orgs","repos_url":"https://api.github.com/users/p0psicles/repos","events_url":"https://api.github.com/users/p0psicles/events{/privacy}","received_events_url":"https://api.github.com/users/p0psicles/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":1,"state":"open","created_at":"2016-06-11T19:14:08Z","updated_at":"2016-07-08T10:19:53Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/pymedusa/SickRage/pulls/714/commits","review_comments_url":"https://api.github.com/repos/pymedusa/SickRage/pulls/714/comments","review_comment_url":"https://api.github.com/repos/pymedusa/SickRage/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pymedusa/SickRage/issues/714/comments","statuses_url":"https://api.github.com/repos/pymedusa/SickRage/statuses/435f341bce21934e77f25d20dabbe8062b96c03d","head":{"label":"pymedusa:guessit2","ref":"guessit2","sha":"435f341bce21934e77f25d20dabbe8062b96c03d","user":{"login":"pymedusa","id":16712498,"avatar_url":"https://avatars.githubusercontent.com/u/16712498?v=3","gravatar_id":"","url":"https://api.github.com/users/pymedusa","html_url":"https://github.com/pymedusa","followers_url":"https://api.github.com/users/pymedusa/followers","following_url":"https://api.github.com/users/pymedusa/following{/other_user}","gists_url":"https://api.github.com/users/pymedusa/gists{/gist_id}","starred_url":"https://api.github.com/users/pymedusa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pymedusa/subscriptions","organizations_url":"https://api.github.com/users/pymedusa/orgs","repos_url":"https://api.github.com/users/pymedusa/repos","events_url":"https://api.github.com/users/pymedusa/events{/privacy}","received_events_url":"https://api.github.com/users/pymedusa/received_events","type":"Organization","site_admin":false},"repo":{"id":52334681,"name":"SickRage","full_name":"pymedusa/SickRage","owner":{"login":"pymedusa","id":16712498,"avatar_url":"https://avatars.githubusercontent.com/u/16712498?v=3","gravatar_id":"","url":"https://api.github.com/users/pymedusa","html_url":"https://github.com/pymedusa","followers_url":"https://api.github.com/users/pymedusa/followers","following_url":"https://api.github.com/users/pymedusa/following{/other_user}","gists_url":"https://api.github.com/users/pymedusa/gists{/gist_id}","starred_url":"https://api.github.com/users/pymedusa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pymedusa/subscriptions","organizations_url":"https://api.github.com/users/pymedusa/orgs","repos_url":"https://api.github.com/users/pymedusa/repos","events_url":"https://api.github.com/users/pymedusa/events{/privacy}","received_events_url":"https://api.github.com/users/pymedusa/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pymedusa/SickRage","description":"Now with the most wanted feature: **Manual Search**. You can choose what to download! IRC: #pymedusa","fork":false,"url":"https://api.github.com/repos/pymedusa/SickRage","forks_url":"https://api.github.com/repos/pymedusa/SickRage/forks","keys_url":"https://api.github.com/repos/pymedusa/SickRage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pymedusa/SickRage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pymedusa/SickRage/teams","hooks_url":"https://api.github.com/repos/pymedusa/SickRage/hooks","issue_events_url":"https://api.github.com/repos/pymedusa/SickRage/issues/events{/number}","events_url":"https://api.github.com/repos/pymedusa/SickRage/events","assignees_url":"https://api.github.com/repos/pymedusa/SickRage/assignees{/user}","branches_url":"https://api.github.com/repos/pymedusa/SickRage/branches{/branch}","tags_url":"https://api.github.com/repos/pymedusa/SickRage/tags","blobs_url":"https://api.github.com/repos/pymedusa/SickRage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pymedusa/SickRage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pymedusa/SickRage/git/refs{/sha}","trees_url":"https://api.github.com/repos/pymedusa/SickRage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pymedusa/SickRage/statuses/{sha}","languages_url":"https://api.github.com/repos/pymedusa/SickRage/languages","stargazers_url":"https://api.github.com/repos/pymedusa/SickRage/stargazers","contributors_url":"https://api.github.com/repos/pymedusa/SickRage/contributors","subscribers_url":"https://api.github.com/repos/pymedusa/SickRage/subscribers","subscription_url":"https://api.github.com/repos/pymedusa/SickRage/subscription","commits_url":"https://api.github.com/repos/pymedusa/SickRage/commits{/sha}","git_commits_url":"https://api.github.com/repos/pymedusa/SickRage/git/commits{/sha}","comments_url":"https://api.github.com/repos/pymedusa/SickRage/comments{/number}","issue_comment_url":"https://api.github.com/repos/pymedusa/SickRage/issues/comments{/number}","contents_url":"https://api.github.com/repos/pymedusa/SickRage/contents/{+path}","compare_url":"https://api.github.com/repos/pymedusa/SickRage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pymedusa/SickRage/merges","archive_url":"https://api.github.com/repos/pymedusa/SickRage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pymedusa/SickRage/downloads","issues_url":"https://api.github.com/repos/pymedusa/SickRage/issues{/number}","pulls_url":"https://api.github.com/repos/pymedusa/SickRage/pulls{/number}","milestones_url":"https://api.github.com/repos/pymedusa/SickRage/milestones{/number}","notifications_url":"https://api.github.com/repos/pymedusa/SickRage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pymedusa/SickRage/labels{/name}","releases_url":"https://api.github.com/repos/pymedusa/SickRage/releases{/id}","deployments_url":"https://api.github.com/repos/pymedusa/SickRage/deployments","created_at":"2016-02-23T06:02:11Z","updated_at":"2016-06-16T06:16:28Z","pushed_at":"2016-07-11T06:12:00Z","git_url":"git://github.com/pymedusa/SickRage.git","ssh_url":"git@github.com:pymedusa/SickRage.git","clone_url":"https://github.com/pymedusa/SickRage.git","svn_url":"https://github.com/pymedusa/SickRage","homepage":"","size":56991,"stargazers_count":12,"watchers_count":12,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":84,"forks":9,"open_issues":84,"watchers":12,"default_branch":"master"}},"base":{"label":"pymedusa:develop","ref":"develop","sha":"b980026c684c8f603e4bdcff253434041ad6da56","user":{"login":"pymedusa","id":16712498,"avatar_url":"https://avatars.githubusercontent.com/u/16712498?v=3","gravatar_id":"","url":"https://api.github.com/users/pymedusa","html_url":"https://github.com/pymedusa","followers_url":"https://api.github.com/users/pymedusa/followers","following_url":"https://api.github.com/users/pymedusa/following{/other_user}","gists_url":"https://api.github.com/users/pymedusa/gists{/gist_id}","starred_url":"https://api.github.com/users/pymedusa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pymedusa/subscriptions","organizations_url":"https://api.github.com/users/pymedusa/orgs","repos_url":"https://api.github.com/users/pymedusa/repos","events_url":"https://api.github.com/users/pymedusa/events{/privacy}","received_events_url":"https://api.github.com/users/pymedusa/received_events","type":"Organization","site_admin":false},"repo":{"id":52334681,"name":"SickRage","full_name":"pymedusa/SickRage","owner":{"login":"pymedusa","id":16712498,"avatar_url":"https://avatars.githubusercontent.com/u/16712498?v=3","gravatar_id":"","url":"https://api.github.com/users/pymedusa","html_url":"https://github.com/pymedusa","followers_url":"https://api.github.com/users/pymedusa/followers","following_url":"https://api.github.com/users/pymedusa/following{/other_user}","gists_url":"https://api.github.com/users/pymedusa/gists{/gist_id}","starred_url":"https://api.github.com/users/pymedusa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pymedusa/subscriptions","organizations_url":"https://api.github.com/users/pymedusa/orgs","repos_url":"https://api.github.com/users/pymedusa/repos","events_url":"https://api.github.com/users/pymedusa/events{/privacy}","received_events_url":"https://api.github.com/users/pymedusa/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pymedusa/SickRage","description":"Now with the most wanted feature: **Manual Search**. You can choose what to download! IRC: #pymedusa","fork":false,"url":"https://api.github.com/repos/pymedusa/SickRage","forks_url":"https://api.github.com/repos/pymedusa/SickRage/forks","keys_url":"https://api.github.com/repos/pymedusa/SickRage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pymedusa/SickRage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pymedusa/SickRage/teams","hooks_url":"https://api.github.com/repos/pymedusa/SickRage/hooks","issue_events_url":"https://api.github.com/repos/pymedusa/SickRage/issues/events{/number}","events_url":"https://api.github.com/repos/pymedusa/SickRage/events","assignees_url":"https://api.github.com/repos/pymedusa/SickRage/assignees{/user}","branches_url":"https://api.github.com/repos/pymedusa/SickRage/branches{/branch}","tags_url":"https://api.github.com/repos/pymedusa/SickRage/tags","blobs_url":"https://api.github.com/repos/pymedusa/SickRage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pymedusa/SickRage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pymedusa/SickRage/git/refs{/sha}","trees_url":"https://api.github.com/repos/pymedusa/SickRage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pymedusa/SickRage/statuses/{sha}","languages_url":"https://api.github.com/repos/pymedusa/SickRage/languages","stargazers_url":"https://api.github.com/repos/pymedusa/SickRage/stargazers","contributors_url":"https://api.github.com/repos/pymedusa/SickRage/contributors","subscribers_url":"https://api.github.com/repos/pymedusa/SickRage/subscribers","subscription_url":"https://api.github.com/repos/pymedusa/SickRage/subscription","commits_url":"https://api.github.com/repos/pymedusa/SickRage/commits{/sha}","git_commits_url":"https://api.github.com/repos/pymedusa/SickRage/git/commits{/sha}","comments_url":"https://api.github.com/repos/pymedusa/SickRage/comments{/number}","issue_comment_url":"https://api.github.com/repos/pymedusa/SickRage/issues/comments{/number}","contents_url":"https://api.github.com/repos/pymedusa/SickRage/contents/{+path}","compare_url":"https://api.github.com/repos/pymedusa/SickRage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pymedusa/SickRage/merges","archive_url":"https://api.github.com/repos/pymedusa/SickRage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pymedusa/SickRage/downloads","issues_url":"https://api.github.com/repos/pymedusa/SickRage/issues{/number}","pulls_url":"https://api.github.com/repos/pymedusa/SickRage/pulls{/number}","milestones_url":"https://api.github.com/repos/pymedusa/SickRage/milestones{/number}","notifications_url":"https://api.github.com/repos/pymedusa/SickRage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pymedusa/SickRage/labels{/name}","releases_url":"https://api.github.com/repos/pymedusa/SickRage/releases{/id}","deployments_url":"https://api.github.com/repos/pymedusa/SickRage/deployments","created_at":"2016-02-23T06:02:11Z","updated_at":"2016-06-16T06:16:28Z","pushed_at":"2016-07-11T06:12:00Z","git_url":"git://github.com/pymedusa/SickRage.git","ssh_url":"git@github.com:pymedusa/SickRage.git","clone_url":"https://github.com/pymedusa/SickRage.git","svn_url":"https://github.com/pymedusa/SickRage","homepage":"","size":56991,"stargazers_count":12,"watchers_count":12,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":84,"forks":9,"open_issues":84,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pymedusa/SickRage/pulls/714"},"html":{"href":"https://github.com/pymedusa/SickRage/pull/714"},"issue":{"href":"https://api.github.com/repos/pymedusa/SickRage/issues/714"},"comments":{"href":"https://api.github.com/repos/pymedusa/SickRage/issues/714/comments"},"review_comments":{"href":"https://api.github.com/repos/pymedusa/SickRage/pulls/714/comments"},"review_comment":{"href":"https://api.github.com/repos/pymedusa/SickRage/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pymedusa/SickRage/pulls/714/commits"},"statuses":{"href":"https://api.github.com/repos/pymedusa/SickRage/statuses/435f341bce21934e77f25d20dabbe8062b96c03d"}}}}
{"actor":{"display_login":"p0psicles"}}