{"action":"created","issue":{"url":"https://api.github.com/repos/bazelbuild/rules_scala/issues/29","repository_url":"https://api.github.com/repos/bazelbuild/rules_scala","labels_url":"https://api.github.com/repos/bazelbuild/rules_scala/issues/29/labels{/name}","comments_url":"https://api.github.com/repos/bazelbuild/rules_scala/issues/29/comments","events_url":"https://api.github.com/repos/bazelbuild/rules_scala/issues/29/events","html_url":"https://github.com/bazelbuild/rules_scala/pull/29","id":147916279,"number":29,"title":"WIP - DO NOT MERGE - Add scrooge support","user":{"login":"jcoveney","id":830087,"avatar_url":"https://avatars.githubusercontent.com/u/830087?v=3","gravatar_id":"","url":"https://api.github.com/users/jcoveney","html_url":"https://github.com/jcoveney","followers_url":"https://api.github.com/users/jcoveney/followers","following_url":"https://api.github.com/users/jcoveney/following{/other_user}","gists_url":"https://api.github.com/users/jcoveney/gists{/gist_id}","starred_url":"https://api.github.com/users/jcoveney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcoveney/subscriptions","organizations_url":"https://api.github.com/users/jcoveney/orgs","repos_url":"https://api.github.com/users/jcoveney/repos","events_url":"https://api.github.com/users/jcoveney/events{/privacy}","received_events_url":"https://api.github.com/users/jcoveney/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/bazelbuild/rules_scala/labels/cla:%20no","name":"cla: no","color":"e11d21"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2016-04-13T01:07:10Z","updated_at":"2016-04-13T19:42:43Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/bazelbuild/rules_scala/pulls/29","html_url":"https://github.com/bazelbuild/rules_scala/pull/29","diff_url":"https://github.com/bazelbuild/rules_scala/pull/29.diff","patch_url":"https://github.com/bazelbuild/rules_scala/pull/29.patch"},"body":"Ok, there is a LOT to be desired here... there are a ton of TODOS\r\n\r\nBUT IT WORKS\r\n\r\nI currently have a project which has two thrift files which depend on each other, BUILDS for them, and then a scala_library which depends on that and the thrifts...it builds. My guess is right now transitive stuff will not work.\r\n\r\nSo my immediate first goal is to make a test directory with some thrifts and some stuff that depends on them, to make sure that transitive stuff works properly.\r\n\r\nAfter that is just...making it less crazy. I really, really need the guidance of people who have done this... I will put a microscope to everything I did, but I'm finding the \"throw structs around with attributes! oh some attributes are missing!\" to really resist abstraction and promote hacks...\r\n\r\nBut it works :) so I will do the above, hopefully refactor with guidance and time, and then will try it on one of our internal repositories.\r\n\r\nOne thing that I would like to put off, though, is moving it into different files etc. Right now I want to just make sure that we get the flow of everything down properly."},"comment":{"url":"https://api.github.com/repos/bazelbuild/rules_scala/issues/comments/209617680","html_url":"https://github.com/bazelbuild/rules_scala/pull/29#issuecomment-209617680","issue_url":"https://api.github.com/repos/bazelbuild/rules_scala/issues/29","id":209617680,"user":{"login":"jcoveney","id":830087,"avatar_url":"https://avatars.githubusercontent.com/u/830087?v=3","gravatar_id":"","url":"https://api.github.com/users/jcoveney","html_url":"https://github.com/jcoveney","followers_url":"https://api.github.com/users/jcoveney/followers","following_url":"https://api.github.com/users/jcoveney/following{/other_user}","gists_url":"https://api.github.com/users/jcoveney/gists{/gist_id}","starred_url":"https://api.github.com/users/jcoveney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcoveney/subscriptions","organizations_url":"https://api.github.com/users/jcoveney/orgs","repos_url":"https://api.github.com/users/jcoveney/repos","events_url":"https://api.github.com/users/jcoveney/events{/privacy}","received_events_url":"https://api.github.com/users/jcoveney/received_events","type":"User","site_admin":false},"created_at":"2016-04-13T19:42:43Z","updated_at":"2016-04-13T19:42:43Z","body":"Ah, hm. On further thought, not sure if that will work. Gonna mull on it and explore code..."}}