{"action":"created","comment":{"url":"https://api.github.com/repos/01org/cc-oci-runtime/pulls/comments/80067845","id":80067845,"diff_hunk":"@@ -0,0 +1,127 @@\n+#!/bin/sh\n+#  This file is part of cc-oci-runtime.\n+#\n+#  Copyright (C) 2016 Intel Corporation\n+#\n+#  This program is free software; you can redistribute it and/or\n+#  modify it under the terms of the GNU General Public License\n+#  as published by the Free Software Foundation; either version 2\n+#  of the License, or (at your option) any later version.\n+#\n+#  This program is distributed in the hope that it will be useful,\n+#  but WITHOUT ANY WARRANTY; without even the implied warranty of\n+#  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the\n+#  GNU General Public License for more details.\n+#\n+#  You should have received a copy of the GNU General Public License\n+#  along with this program; if not, write to the Free Software\n+#  Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.\n+#\n+\n+# Description: Script to create a bundle directory that can be made\n+#   into a full OCI bundle when a \"config.json\" file is created within it.\n+#\n+# On success, this script will create the directory specified as a\n+# bundle directory. This directory can be used as an OCI bundle once it\n+# has had a \"config.json\" file added to it. The directory created will\n+# contain a sub-directory called \"rootfs\" (which is the canonical path to\n+# the rootfs specified by an OCI bundle).\n+#\n+# See the following for further details:\n+#\n+# - https://github.com/opencontainers/runtime-spec/blob/master/bundle.md\n+\n+# Name of a small docker image that create_rootfs() uses\n+# to make a chroot directory.\n+docker_image=\"busybox\"","path":"data/make-bundle-dir.sh","position":36,"original_position":36,"commit_id":"3fe5ffbf2a3db91392980b8d4a8f2be4e33b5823","original_commit_id":"3fe5ffbf2a3db91392980b8d4a8f2be4e33b5823","user":{"login":"devimc","id":13009432,"avatar_url":"https://avatars.githubusercontent.com/u/13009432?v=3","gravatar_id":"","url":"https://api.github.com/users/devimc","html_url":"https://github.com/devimc","followers_url":"https://api.github.com/users/devimc/followers","following_url":"https://api.github.com/users/devimc/following{/other_user}","gists_url":"https://api.github.com/users/devimc/gists{/gist_id}","starred_url":"https://api.github.com/users/devimc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devimc/subscriptions","organizations_url":"https://api.github.com/users/devimc/orgs","repos_url":"https://api.github.com/users/devimc/repos","events_url":"https://api.github.com/users/devimc/events{/privacy}","received_events_url":"https://api.github.com/users/devimc/received_events","type":"User","site_admin":false},"body":":+1: ","created_at":"2016-09-22T15:28:48Z","updated_at":"2016-09-22T15:28:48Z","html_url":"https://github.com/01org/cc-oci-runtime/pull/272#discussion_r80067845","pull_request_url":"https://api.github.com/repos/01org/cc-oci-runtime/pulls/272","_links":{"self":{"href":"https://api.github.com/repos/01org/cc-oci-runtime/pulls/comments/80067845"},"html":{"href":"https://github.com/01org/cc-oci-runtime/pull/272#discussion_r80067845"},"pull_request":{"href":"https://api.github.com/repos/01org/cc-oci-runtime/pulls/272"}}},"pull_request":{"url":"https://api.github.com/repos/01org/cc-oci-runtime/pulls/272","id":85822781,"html_url":"https://github.com/01org/cc-oci-runtime/pull/272","diff_url":"https://github.com/01org/cc-oci-runtime/pull/272.diff","patch_url":"https://github.com/01org/cc-oci-runtime/pull/272.patch","issue_url":"https://api.github.com/repos/01org/cc-oci-runtime/issues/272","number":272,"state":"open","locked":false,"title":"Create rootfs for tests","user":{"login":"jodh-intel","id":20315601,"avatar_url":"https://avatars.githubusercontent.com/u/20315601?v=3","gravatar_id":"","url":"https://api.github.com/users/jodh-intel","html_url":"https://github.com/jodh-intel","followers_url":"https://api.github.com/users/jodh-intel/followers","following_url":"https://api.github.com/users/jodh-intel/following{/other_user}","gists_url":"https://api.github.com/users/jodh-intel/gists{/gist_id}","starred_url":"https://api.github.com/users/jodh-intel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jodh-intel/subscriptions","organizations_url":"https://api.github.com/users/jodh-intel/orgs","repos_url":"https://api.github.com/users/jodh-intel/repos","events_url":"https://api.github.com/users/jodh-intel/events{/privacy}","received_events_url":"https://api.github.com/users/jodh-intel/received_events","type":"User","site_admin":false},"body":"This is quite a tricky problem. The solution I've come up with is a slight abuse of `configure`: it would be better to have the bundle creation and deletion handled in `Makefile.am` but that would require the makefile to handle the generation of `tests/functional/common.bash.in`. That's possible, but gets rather complicated given the number of tests and options required to be checked. Note also that neither the tests themselves nor `tests/functional/common.bash.in` can handle the bundle creation/deletion since that would result in the bundle being created 'n' times, not just once.\r\n\r\nFixes #265.","created_at":"2016-09-19T16:09:16Z","updated_at":"2016-09-22T15:28:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a71d19f56cc84e066c8db44fe6feb32c2e551e3d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/01org/cc-oci-runtime/pulls/272/commits","review_comments_url":"https://api.github.com/repos/01org/cc-oci-runtime/pulls/272/comments","review_comment_url":"https://api.github.com/repos/01org/cc-oci-runtime/pulls/comments{/number}","comments_url":"https://api.github.com/repos/01org/cc-oci-runtime/issues/272/comments","statuses_url":"https://api.github.com/repos/01org/cc-oci-runtime/statuses/3fe5ffbf2a3db91392980b8d4a8f2be4e33b5823","head":{"label":"jodh-intel:create-rootfs-for-tests","ref":"create-rootfs-for-tests","sha":"3fe5ffbf2a3db91392980b8d4a8f2be4e33b5823","user":{"login":"jodh-intel","id":20315601,"avatar_url":"https://avatars.githubusercontent.com/u/20315601?v=3","gravatar_id":"","url":"https://api.github.com/users/jodh-intel","html_url":"https://github.com/jodh-intel","followers_url":"https://api.github.com/users/jodh-intel/followers","following_url":"https://api.github.com/users/jodh-intel/following{/other_user}","gists_url":"https://api.github.com/users/jodh-intel/gists{/gist_id}","starred_url":"https://api.github.com/users/jodh-intel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jodh-intel/subscriptions","organizations_url":"https://api.github.com/users/jodh-intel/orgs","repos_url":"https://api.github.com/users/jodh-intel/repos","events_url":"https://api.github.com/users/jodh-intel/events{/privacy}","received_events_url":"https://api.github.com/users/jodh-intel/received_events","type":"User","site_admin":false},"repo":{"id":65009909,"name":"cc-oci-runtime","full_name":"jodh-intel/cc-oci-runtime","owner":{"login":"jodh-intel","id":20315601,"avatar_url":"https://avatars.githubusercontent.com/u/20315601?v=3","gravatar_id":"","url":"https://api.github.com/users/jodh-intel","html_url":"https://github.com/jodh-intel","followers_url":"https://api.github.com/users/jodh-intel/followers","following_url":"https://api.github.com/users/jodh-intel/following{/other_user}","gists_url":"https://api.github.com/users/jodh-intel/gists{/gist_id}","starred_url":"https://api.github.com/users/jodh-intel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jodh-intel/subscriptions","organizations_url":"https://api.github.com/users/jodh-intel/orgs","repos_url":"https://api.github.com/users/jodh-intel/repos","events_url":"https://api.github.com/users/jodh-intel/events{/privacy}","received_events_url":"https://api.github.com/users/jodh-intel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jodh-intel/cc-oci-runtime","description":"OCI (Open Containers Initiative) compatible runtime","fork":true,"url":"https://api.github.com/repos/jodh-intel/cc-oci-runtime","forks_url":"https://api.github.com/repos/jodh-intel/cc-oci-runtime/forks","keys_url":"https://api.github.com/repos/jodh-intel/cc-oci-runtime/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jodh-intel/cc-oci-runtime/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jodh-intel/cc-oci-runtime/teams","hooks_url":"https://api.github.com/repos/jodh-intel/cc-oci-runtime/hooks","issue_events_url":"https://api.github.com/repos/jodh-intel/cc-oci-runtime/issues/events{/number}","events_url":"https://api.github.com/repos/jodh-intel/cc-oci-runtime/events","assignees_url":"https://api.github.com/repos/jodh-intel/cc-oci-runtime/assignees{/user}","branches_url":"https://api.github.com/repos/jodh-intel/cc-oci-runtime/branches{/branch}","tags_url":"https://api.github.com/repos/jodh-intel/cc-oci-runtime/tags","blobs_url":"https://api.github.com/repos/jodh-intel/cc-oci-runtime/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jodh-intel/cc-oci-runtime/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jodh-intel/cc-oci-runtime/git/refs{/sha}","trees_url":"https://api.github.com/repos/jodh-intel/cc-oci-runtime/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jodh-intel/cc-oci-runtime/statuses/{sha}","languages_url":"https://api.github.com/repos/jodh-intel/cc-oci-runtime/languages","stargazers_url":"https://api.github.com/repos/jodh-intel/cc-oci-runtime/stargazers","contributors_url":"https://api.github.com/repos/jodh-intel/cc-oci-runtime/contributors","subscribers_url":"https://api.github.com/repos/jodh-intel/cc-oci-runtime/subscribers","subscription_url":"https://api.github.com/repos/jodh-intel/cc-oci-runtime/subscription","commits_url":"https://api.github.com/repos/jodh-intel/cc-oci-runtime/commits{/sha}","git_commits_url":"https://api.github.com/repos/jodh-intel/cc-oci-runtime/git/commits{/sha}","comments_url":"https://api.github.com/repos/jodh-intel/cc-oci-runtime/comments{/number}","issue_comment_url":"https://api.github.com/repos/jodh-intel/cc-oci-runtime/issues/comments{/number}","contents_url":"https://api.github.com/repos/jodh-intel/cc-oci-runtime/contents/{+path}","compare_url":"https://api.github.com/repos/jodh-intel/cc-oci-runtime/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jodh-intel/cc-oci-runtime/merges","archive_url":"https://api.github.com/repos/jodh-intel/cc-oci-runtime/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jodh-intel/cc-oci-runtime/downloads","issues_url":"https://api.github.com/repos/jodh-intel/cc-oci-runtime/issues{/number}","pulls_url":"https://api.github.com/repos/jodh-intel/cc-oci-runtime/pulls{/number}","milestones_url":"https://api.github.com/repos/jodh-intel/cc-oci-runtime/milestones{/number}","notifications_url":"https://api.github.com/repos/jodh-intel/cc-oci-runtime/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jodh-intel/cc-oci-runtime/labels{/name}","releases_url":"https://api.github.com/repos/jodh-intel/cc-oci-runtime/releases{/id}","deployments_url":"https://api.github.com/repos/jodh-intel/cc-oci-runtime/deployments","created_at":"2016-08-05T10:16:46Z","updated_at":"2016-08-05T10:16:48Z","pushed_at":"2016-09-22T09:32:59Z","git_url":"git://github.com/jodh-intel/cc-oci-runtime.git","ssh_url":"git@github.com:jodh-intel/cc-oci-runtime.git","clone_url":"https://github.com/jodh-intel/cc-oci-runtime.git","svn_url":"https://github.com/jodh-intel/cc-oci-runtime","homepage":"","size":1010,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"01org:master","ref":"master","sha":"8efc909698625fbdb6eb133ffe0f5094cd6dd151","user":{"login":"01org","id":1635439,"avatar_url":"https://avatars.githubusercontent.com/u/1635439?v=3","gravatar_id":"","url":"https://api.github.com/users/01org","html_url":"https://github.com/01org","followers_url":"https://api.github.com/users/01org/followers","following_url":"https://api.github.com/users/01org/following{/other_user}","gists_url":"https://api.github.com/users/01org/gists{/gist_id}","starred_url":"https://api.github.com/users/01org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/01org/subscriptions","organizations_url":"https://api.github.com/users/01org/orgs","repos_url":"https://api.github.com/users/01org/repos","events_url":"https://api.github.com/users/01org/events{/privacy}","received_events_url":"https://api.github.com/users/01org/received_events","type":"Organization","site_admin":false},"repo":{"id":62701840,"name":"cc-oci-runtime","full_name":"01org/cc-oci-runtime","owner":{"login":"01org","id":1635439,"avatar_url":"https://avatars.githubusercontent.com/u/1635439?v=3","gravatar_id":"","url":"https://api.github.com/users/01org","html_url":"https://github.com/01org","followers_url":"https://api.github.com/users/01org/followers","following_url":"https://api.github.com/users/01org/following{/other_user}","gists_url":"https://api.github.com/users/01org/gists{/gist_id}","starred_url":"https://api.github.com/users/01org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/01org/subscriptions","organizations_url":"https://api.github.com/users/01org/orgs","repos_url":"https://api.github.com/users/01org/repos","events_url":"https://api.github.com/users/01org/events{/privacy}","received_events_url":"https://api.github.com/users/01org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/01org/cc-oci-runtime","description":"OCI (Open Containers Initiative) compatible runtime for Intel® Architecture","fork":false,"url":"https://api.github.com/repos/01org/cc-oci-runtime","forks_url":"https://api.github.com/repos/01org/cc-oci-runtime/forks","keys_url":"https://api.github.com/repos/01org/cc-oci-runtime/keys{/key_id}","collaborators_url":"https://api.github.com/repos/01org/cc-oci-runtime/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/01org/cc-oci-runtime/teams","hooks_url":"https://api.github.com/repos/01org/cc-oci-runtime/hooks","issue_events_url":"https://api.github.com/repos/01org/cc-oci-runtime/issues/events{/number}","events_url":"https://api.github.com/repos/01org/cc-oci-runtime/events","assignees_url":"https://api.github.com/repos/01org/cc-oci-runtime/assignees{/user}","branches_url":"https://api.github.com/repos/01org/cc-oci-runtime/branches{/branch}","tags_url":"https://api.github.com/repos/01org/cc-oci-runtime/tags","blobs_url":"https://api.github.com/repos/01org/cc-oci-runtime/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/01org/cc-oci-runtime/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/01org/cc-oci-runtime/git/refs{/sha}","trees_url":"https://api.github.com/repos/01org/cc-oci-runtime/git/trees{/sha}","statuses_url":"https://api.github.com/repos/01org/cc-oci-runtime/statuses/{sha}","languages_url":"https://api.github.com/repos/01org/cc-oci-runtime/languages","stargazers_url":"https://api.github.com/repos/01org/cc-oci-runtime/stargazers","contributors_url":"https://api.github.com/repos/01org/cc-oci-runtime/contributors","subscribers_url":"https://api.github.com/repos/01org/cc-oci-runtime/subscribers","subscription_url":"https://api.github.com/repos/01org/cc-oci-runtime/subscription","commits_url":"https://api.github.com/repos/01org/cc-oci-runtime/commits{/sha}","git_commits_url":"https://api.github.com/repos/01org/cc-oci-runtime/git/commits{/sha}","comments_url":"https://api.github.com/repos/01org/cc-oci-runtime/comments{/number}","issue_comment_url":"https://api.github.com/repos/01org/cc-oci-runtime/issues/comments{/number}","contents_url":"https://api.github.com/repos/01org/cc-oci-runtime/contents/{+path}","compare_url":"https://api.github.com/repos/01org/cc-oci-runtime/compare/{base}...{head}","merges_url":"https://api.github.com/repos/01org/cc-oci-runtime/merges","archive_url":"https://api.github.com/repos/01org/cc-oci-runtime/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/01org/cc-oci-runtime/downloads","issues_url":"https://api.github.com/repos/01org/cc-oci-runtime/issues{/number}","pulls_url":"https://api.github.com/repos/01org/cc-oci-runtime/pulls{/number}","milestones_url":"https://api.github.com/repos/01org/cc-oci-runtime/milestones{/number}","notifications_url":"https://api.github.com/repos/01org/cc-oci-runtime/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/01org/cc-oci-runtime/labels{/name}","releases_url":"https://api.github.com/repos/01org/cc-oci-runtime/releases{/id}","deployments_url":"https://api.github.com/repos/01org/cc-oci-runtime/deployments","created_at":"2016-07-06T07:48:26Z","updated_at":"2016-09-11T03:10:34Z","pushed_at":"2016-09-22T10:38:24Z","git_url":"git://github.com/01org/cc-oci-runtime.git","ssh_url":"git@github.com:01org/cc-oci-runtime.git","clone_url":"https://github.com/01org/cc-oci-runtime.git","svn_url":"https://github.com/01org/cc-oci-runtime","homepage":"","size":1029,"stargazers_count":16,"watchers_count":16,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":85,"forks":13,"open_issues":85,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/01org/cc-oci-runtime/pulls/272"},"html":{"href":"https://github.com/01org/cc-oci-runtime/pull/272"},"issue":{"href":"https://api.github.com/repos/01org/cc-oci-runtime/issues/272"},"comments":{"href":"https://api.github.com/repos/01org/cc-oci-runtime/issues/272/comments"},"review_comments":{"href":"https://api.github.com/repos/01org/cc-oci-runtime/pulls/272/comments"},"review_comment":{"href":"https://api.github.com/repos/01org/cc-oci-runtime/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/01org/cc-oci-runtime/pulls/272/commits"},"statuses":{"href":"https://api.github.com/repos/01org/cc-oci-runtime/statuses/3fe5ffbf2a3db91392980b8d4a8f2be4e33b5823"}}}}
{"actor":{"display_login":"devimc"}}