{"action":"created","comment":{"url":"https://api.github.com/repos/stasm/alfred/pulls/comments/80679601","pull_request_review_id":1717883,"id":80679601,"diff_hunk":"@@ -1,18 +1,16 @@\n import React, { Component } from 'react';\n+import { connect } from 'react-redux';\n+import * as actions from '../actions';\n \n import Inbox from '../components/inbox/Inbox';\n import { API_URL } from '../../config';\n-import { makeUpdate, get, post } from '../utils';\n+import { makeUpdate, post } from '../utils';\n \n-export default class InboxContainer extends Component {\n+class InboxContainer extends Component {\n   constructor(props) {\n     super(props);\n \n-    const { author } = this.props.params;\n-\n     this.state = {","path":"www/src/app/views/InboxContainer.js","position":17,"original_position":17,"commit_id":"19e44c0ab2c2bb129a2e85eef22c3146c393f3f3","original_commit_id":"19e44c0ab2c2bb129a2e85eef22c3146c393f3f3","user":{"login":"stasm","id":265818,"avatar_url":"https://avatars.githubusercontent.com/u/265818?v=3","gravatar_id":"","url":"https://api.github.com/users/stasm","html_url":"https://github.com/stasm","followers_url":"https://api.github.com/users/stasm/followers","following_url":"https://api.github.com/users/stasm/following{/other_user}","gists_url":"https://api.github.com/users/stasm/gists{/gist_id}","starred_url":"https://api.github.com/users/stasm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stasm/subscriptions","organizations_url":"https://api.github.com/users/stasm/orgs","repos_url":"https://api.github.com/users/stasm/repos","events_url":"https://api.github.com/users/stasm/events{/privacy}","received_events_url":"https://api.github.com/users/stasm/received_events","type":"User","site_admin":false},"body":"Should we continue to use `this.state` and `this.setState` next to using Redux?  Do you mean this as a temporary measure to split the migration into smaller chunks?","created_at":"2016-09-27T12:27:52Z","updated_at":"2016-09-27T12:53:48Z","html_url":"https://github.com/stasm/alfred/pull/21#discussion_r80679601","pull_request_url":"https://api.github.com/repos/stasm/alfred/pulls/21","_links":{"self":{"href":"https://api.github.com/repos/stasm/alfred/pulls/comments/80679601"},"html":{"href":"https://github.com/stasm/alfred/pull/21#discussion_r80679601"},"pull_request":{"href":"https://api.github.com/repos/stasm/alfred/pulls/21"}}},"pull_request":{"url":"https://api.github.com/repos/stasm/alfred/pulls/21","id":86865335,"html_url":"https://github.com/stasm/alfred/pull/21","diff_url":"https://github.com/stasm/alfred/pull/21.diff","patch_url":"https://github.com/stasm/alfred/pull/21.patch","issue_url":"https://api.github.com/repos/stasm/alfred/issues/21","number":21,"state":"open","locked":false,"title":"adding redux","user":{"login":"hkasemir","id":10947914,"avatar_url":"https://avatars.githubusercontent.com/u/10947914?v=3","gravatar_id":"","url":"https://api.github.com/users/hkasemir","html_url":"https://github.com/hkasemir","followers_url":"https://api.github.com/users/hkasemir/followers","following_url":"https://api.github.com/users/hkasemir/following{/other_user}","gists_url":"https://api.github.com/users/hkasemir/gists{/gist_id}","starred_url":"https://api.github.com/users/hkasemir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hkasemir/subscriptions","organizations_url":"https://api.github.com/users/hkasemir/orgs","repos_url":"https://api.github.com/users/hkasemir/repos","events_url":"https://api.github.com/users/hkasemir/events{/privacy}","received_events_url":"https://api.github.com/users/hkasemir/received_events","type":"User","site_admin":false},"body":"Re: https://github.com/stasm/alfred/issues/20\r\nOk, take a look - I've added some basic capability and restructuring for redux - still clearly lots of work to do :) Handing over to you to take if you wish, or if you'd prefer to leave comments, that's also good. \r\n\r\nbasics: \r\n- I recommend putting all api requests in the `alfred-api-service.js` and turning these into async actions. All actions can be mapped to props through the `mapDispatchToProps` function, making the api requests run and set the redux state with their results.\r\n- I took a shot at the basic state structure, but feel free to modify this as you see fit. I'm not fully clear on the way you're ideally setting this up.\r\n\r\nI was struggling a little with getting the reports/updates created properly in the dev environment, so hopefully it works for you, as I was kind of guessing on a couple things.","created_at":"2016-09-27T05:43:29Z","updated_at":"2016-09-27T12:53:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ef212cf7a16892caf19ecb0aefc78c321f29e554","assignee":{"login":"stasm","id":265818,"avatar_url":"https://avatars.githubusercontent.com/u/265818?v=3","gravatar_id":"","url":"https://api.github.com/users/stasm","html_url":"https://github.com/stasm","followers_url":"https://api.github.com/users/stasm/followers","following_url":"https://api.github.com/users/stasm/following{/other_user}","gists_url":"https://api.github.com/users/stasm/gists{/gist_id}","starred_url":"https://api.github.com/users/stasm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stasm/subscriptions","organizations_url":"https://api.github.com/users/stasm/orgs","repos_url":"https://api.github.com/users/stasm/repos","events_url":"https://api.github.com/users/stasm/events{/privacy}","received_events_url":"https://api.github.com/users/stasm/received_events","type":"User","site_admin":false},"assignees":[{"login":"stasm","id":265818,"avatar_url":"https://avatars.githubusercontent.com/u/265818?v=3","gravatar_id":"","url":"https://api.github.com/users/stasm","html_url":"https://github.com/stasm","followers_url":"https://api.github.com/users/stasm/followers","following_url":"https://api.github.com/users/stasm/following{/other_user}","gists_url":"https://api.github.com/users/stasm/gists{/gist_id}","starred_url":"https://api.github.com/users/stasm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stasm/subscriptions","organizations_url":"https://api.github.com/users/stasm/orgs","repos_url":"https://api.github.com/users/stasm/repos","events_url":"https://api.github.com/users/stasm/events{/privacy}","received_events_url":"https://api.github.com/users/stasm/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/stasm/alfred/pulls/21/commits","review_comments_url":"https://api.github.com/repos/stasm/alfred/pulls/21/comments","review_comment_url":"https://api.github.com/repos/stasm/alfred/pulls/comments{/number}","comments_url":"https://api.github.com/repos/stasm/alfred/issues/21/comments","statuses_url":"https://api.github.com/repos/stasm/alfred/statuses/19e44c0ab2c2bb129a2e85eef22c3146c393f3f3","head":{"label":"hkasemir:hkasemir/add-redux","ref":"hkasemir/add-redux","sha":"19e44c0ab2c2bb129a2e85eef22c3146c393f3f3","user":{"login":"hkasemir","id":10947914,"avatar_url":"https://avatars.githubusercontent.com/u/10947914?v=3","gravatar_id":"","url":"https://api.github.com/users/hkasemir","html_url":"https://github.com/hkasemir","followers_url":"https://api.github.com/users/hkasemir/followers","following_url":"https://api.github.com/users/hkasemir/following{/other_user}","gists_url":"https://api.github.com/users/hkasemir/gists{/gist_id}","starred_url":"https://api.github.com/users/hkasemir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hkasemir/subscriptions","organizations_url":"https://api.github.com/users/hkasemir/orgs","repos_url":"https://api.github.com/users/hkasemir/repos","events_url":"https://api.github.com/users/hkasemir/events{/privacy}","received_events_url":"https://api.github.com/users/hkasemir/received_events","type":"User","site_admin":false},"repo":{"id":69129637,"name":"alfred","full_name":"hkasemir/alfred","owner":{"login":"hkasemir","id":10947914,"avatar_url":"https://avatars.githubusercontent.com/u/10947914?v=3","gravatar_id":"","url":"https://api.github.com/users/hkasemir","html_url":"https://github.com/hkasemir","followers_url":"https://api.github.com/users/hkasemir/followers","following_url":"https://api.github.com/users/hkasemir/following{/other_user}","gists_url":"https://api.github.com/users/hkasemir/gists{/gist_id}","starred_url":"https://api.github.com/users/hkasemir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hkasemir/subscriptions","organizations_url":"https://api.github.com/users/hkasemir/orgs","repos_url":"https://api.github.com/users/hkasemir/repos","events_url":"https://api.github.com/users/hkasemir/events{/privacy}","received_events_url":"https://api.github.com/users/hkasemir/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hkasemir/alfred","description":"Alfred is an IRC bot and a status board. It automatically tracks wiki pages  and Bugzilla, and listens to IRC conversations.","fork":true,"url":"https://api.github.com/repos/hkasemir/alfred","forks_url":"https://api.github.com/repos/hkasemir/alfred/forks","keys_url":"https://api.github.com/repos/hkasemir/alfred/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hkasemir/alfred/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hkasemir/alfred/teams","hooks_url":"https://api.github.com/repos/hkasemir/alfred/hooks","issue_events_url":"https://api.github.com/repos/hkasemir/alfred/issues/events{/number}","events_url":"https://api.github.com/repos/hkasemir/alfred/events","assignees_url":"https://api.github.com/repos/hkasemir/alfred/assignees{/user}","branches_url":"https://api.github.com/repos/hkasemir/alfred/branches{/branch}","tags_url":"https://api.github.com/repos/hkasemir/alfred/tags","blobs_url":"https://api.github.com/repos/hkasemir/alfred/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hkasemir/alfred/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hkasemir/alfred/git/refs{/sha}","trees_url":"https://api.github.com/repos/hkasemir/alfred/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hkasemir/alfred/statuses/{sha}","languages_url":"https://api.github.com/repos/hkasemir/alfred/languages","stargazers_url":"https://api.github.com/repos/hkasemir/alfred/stargazers","contributors_url":"https://api.github.com/repos/hkasemir/alfred/contributors","subscribers_url":"https://api.github.com/repos/hkasemir/alfred/subscribers","subscription_url":"https://api.github.com/repos/hkasemir/alfred/subscription","commits_url":"https://api.github.com/repos/hkasemir/alfred/commits{/sha}","git_commits_url":"https://api.github.com/repos/hkasemir/alfred/git/commits{/sha}","comments_url":"https://api.github.com/repos/hkasemir/alfred/comments{/number}","issue_comment_url":"https://api.github.com/repos/hkasemir/alfred/issues/comments{/number}","contents_url":"https://api.github.com/repos/hkasemir/alfred/contents/{+path}","compare_url":"https://api.github.com/repos/hkasemir/alfred/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hkasemir/alfred/merges","archive_url":"https://api.github.com/repos/hkasemir/alfred/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hkasemir/alfred/downloads","issues_url":"https://api.github.com/repos/hkasemir/alfred/issues{/number}","pulls_url":"https://api.github.com/repos/hkasemir/alfred/pulls{/number}","milestones_url":"https://api.github.com/repos/hkasemir/alfred/milestones{/number}","notifications_url":"https://api.github.com/repos/hkasemir/alfred/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hkasemir/alfred/labels{/name}","releases_url":"https://api.github.com/repos/hkasemir/alfred/releases{/id}","deployments_url":"https://api.github.com/repos/hkasemir/alfred/deployments","created_at":"2016-09-24T21:54:21Z","updated_at":"2016-09-24T21:54:22Z","pushed_at":"2016-09-27T05:35:50Z","git_url":"git://github.com/hkasemir/alfred.git","ssh_url":"git@github.com:hkasemir/alfred.git","clone_url":"https://github.com/hkasemir/alfred.git","svn_url":"https://github.com/hkasemir/alfred","homepage":null,"size":131,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"stasm:master","ref":"master","sha":"68f92e23bef3a28d07d6b6b2149506a628f7d563","user":{"login":"stasm","id":265818,"avatar_url":"https://avatars.githubusercontent.com/u/265818?v=3","gravatar_id":"","url":"https://api.github.com/users/stasm","html_url":"https://github.com/stasm","followers_url":"https://api.github.com/users/stasm/followers","following_url":"https://api.github.com/users/stasm/following{/other_user}","gists_url":"https://api.github.com/users/stasm/gists{/gist_id}","starred_url":"https://api.github.com/users/stasm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stasm/subscriptions","organizations_url":"https://api.github.com/users/stasm/orgs","repos_url":"https://api.github.com/users/stasm/repos","events_url":"https://api.github.com/users/stasm/events{/privacy}","received_events_url":"https://api.github.com/users/stasm/received_events","type":"User","site_admin":false},"repo":{"id":68011892,"name":"alfred","full_name":"stasm/alfred","owner":{"login":"stasm","id":265818,"avatar_url":"https://avatars.githubusercontent.com/u/265818?v=3","gravatar_id":"","url":"https://api.github.com/users/stasm","html_url":"https://github.com/stasm","followers_url":"https://api.github.com/users/stasm/followers","following_url":"https://api.github.com/users/stasm/following{/other_user}","gists_url":"https://api.github.com/users/stasm/gists{/gist_id}","starred_url":"https://api.github.com/users/stasm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stasm/subscriptions","organizations_url":"https://api.github.com/users/stasm/orgs","repos_url":"https://api.github.com/users/stasm/repos","events_url":"https://api.github.com/users/stasm/events{/privacy}","received_events_url":"https://api.github.com/users/stasm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stasm/alfred","description":"Alfred is an IRC bot and a status board. It automatically tracks wiki pages  and Bugzilla, and listens to IRC conversations.","fork":false,"url":"https://api.github.com/repos/stasm/alfred","forks_url":"https://api.github.com/repos/stasm/alfred/forks","keys_url":"https://api.github.com/repos/stasm/alfred/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stasm/alfred/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stasm/alfred/teams","hooks_url":"https://api.github.com/repos/stasm/alfred/hooks","issue_events_url":"https://api.github.com/repos/stasm/alfred/issues/events{/number}","events_url":"https://api.github.com/repos/stasm/alfred/events","assignees_url":"https://api.github.com/repos/stasm/alfred/assignees{/user}","branches_url":"https://api.github.com/repos/stasm/alfred/branches{/branch}","tags_url":"https://api.github.com/repos/stasm/alfred/tags","blobs_url":"https://api.github.com/repos/stasm/alfred/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stasm/alfred/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stasm/alfred/git/refs{/sha}","trees_url":"https://api.github.com/repos/stasm/alfred/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stasm/alfred/statuses/{sha}","languages_url":"https://api.github.com/repos/stasm/alfred/languages","stargazers_url":"https://api.github.com/repos/stasm/alfred/stargazers","contributors_url":"https://api.github.com/repos/stasm/alfred/contributors","subscribers_url":"https://api.github.com/repos/stasm/alfred/subscribers","subscription_url":"https://api.github.com/repos/stasm/alfred/subscription","commits_url":"https://api.github.com/repos/stasm/alfred/commits{/sha}","git_commits_url":"https://api.github.com/repos/stasm/alfred/git/commits{/sha}","comments_url":"https://api.github.com/repos/stasm/alfred/comments{/number}","issue_comment_url":"https://api.github.com/repos/stasm/alfred/issues/comments{/number}","contents_url":"https://api.github.com/repos/stasm/alfred/contents/{+path}","compare_url":"https://api.github.com/repos/stasm/alfred/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stasm/alfred/merges","archive_url":"https://api.github.com/repos/stasm/alfred/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stasm/alfred/downloads","issues_url":"https://api.github.com/repos/stasm/alfred/issues{/number}","pulls_url":"https://api.github.com/repos/stasm/alfred/pulls{/number}","milestones_url":"https://api.github.com/repos/stasm/alfred/milestones{/number}","notifications_url":"https://api.github.com/repos/stasm/alfred/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stasm/alfred/labels{/name}","releases_url":"https://api.github.com/repos/stasm/alfred/releases{/id}","deployments_url":"https://api.github.com/repos/stasm/alfred/deployments","created_at":"2016-09-12T13:35:59Z","updated_at":"2016-09-15T10:24:56Z","pushed_at":"2016-09-27T05:43:29Z","git_url":"git://github.com/stasm/alfred.git","ssh_url":"git@github.com:stasm/alfred.git","clone_url":"https://github.com/stasm/alfred.git","svn_url":"https://github.com/stasm/alfred","homepage":null,"size":126,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":12,"forks":2,"open_issues":12,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/stasm/alfred/pulls/21"},"html":{"href":"https://github.com/stasm/alfred/pull/21"},"issue":{"href":"https://api.github.com/repos/stasm/alfred/issues/21"},"comments":{"href":"https://api.github.com/repos/stasm/alfred/issues/21/comments"},"review_comments":{"href":"https://api.github.com/repos/stasm/alfred/pulls/21/comments"},"review_comment":{"href":"https://api.github.com/repos/stasm/alfred/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/stasm/alfred/pulls/21/commits"},"statuses":{"href":"https://api.github.com/repos/stasm/alfred/statuses/19e44c0ab2c2bb129a2e85eef22c3146c393f3f3"}}}}
{"actor":{"display_login":"stasm"}}