{"action":"created","comment":{"url":"https://api.github.com/repos/idan/oauthlib/pulls/comments/93250126","pull_request_review_id":13772743,"id":93250126,"diff_hunk":"@@ -366,13 +363,23 @@ def validate_token_request(self, request):\n                 'request': request,\n         })\n \n+        self._run_custom_validators(request, request_info,\n+                            self._auth_validators_run_after_standard_ones,\n+                            self._token_validators_run_after_standard_ones)\n+\n+        return request.scopes, request_info\n+\n+\n+    def _run_custom_validators(self,\n+                               request,\n+                               request_info,\n+                               auth_validators,\n+                               token_validators):\n         # For implicit grant, auth_validators and token_validators are\n         # basically equivalent since the token is returned from the\n         # authorization endpoint.\n-        for validator in chain(self._auth_validators_run_after_standard_ones,\n-                               self._token_validators_run_after_standard_ones):\n+        for validator in chain(auth_validators, token_validators):\n             result = validator(request)\n             if result is not None:\n                 request_info.update(result)\n-\n-        return request.scopes, request_info\n+        return request_info","path":"oauthlib/oauth2/rfc6749/grant_types/implicit.py","position":null,"original_position":47,"commit_id":"16907d5418cd3be4f116da2c32d55bacf7167c92","original_commit_id":"16907d5418cd3be4f116da2c32d55bacf7167c92","user":{"login":"kevin-brown","id":1991850,"avatar_url":"https://avatars.githubusercontent.com/u/1991850?v=3","gravatar_id":"","url":"https://api.github.com/users/kevin-brown","html_url":"https://github.com/kevin-brown","followers_url":"https://api.github.com/users/kevin-brown/followers","following_url":"https://api.github.com/users/kevin-brown/following{/other_user}","gists_url":"https://api.github.com/users/kevin-brown/gists{/gist_id}","starred_url":"https://api.github.com/users/kevin-brown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevin-brown/subscriptions","organizations_url":"https://api.github.com/users/kevin-brown/orgs","repos_url":"https://api.github.com/users/kevin-brown/repos","events_url":"https://api.github.com/users/kevin-brown/events{/privacy}","received_events_url":"https://api.github.com/users/kevin-brown/received_events","type":"User","site_admin":false},"body":"This method returns `request_info`, but this return value is not used in any of the places where it is called.","created_at":"2016-12-20T14:43:24Z","updated_at":"2016-12-20T14:43:24Z","html_url":"https://github.com/idan/oauthlib/pull/449#discussion_r93250126","pull_request_url":"https://api.github.com/repos/idan/oauthlib/pulls/449","_links":{"self":{"href":"https://api.github.com/repos/idan/oauthlib/pulls/comments/93250126"},"html":{"href":"https://github.com/idan/oauthlib/pull/449#discussion_r93250126"},"pull_request":{"href":"https://api.github.com/repos/idan/oauthlib/pulls/449"}}},"pull_request":{"url":"https://api.github.com/repos/idan/oauthlib/pulls/449","id":94630855,"html_url":"https://github.com/idan/oauthlib/pull/449","diff_url":"https://github.com/idan/oauthlib/pull/449.diff","patch_url":"https://github.com/idan/oauthlib/pull/449.patch","issue_url":"https://api.github.com/repos/idan/oauthlib/issues/449","number":449,"state":"open","locked":false,"title":"Improve validator registration","user":{"login":"bjmc","id":328557,"avatar_url":"https://avatars.githubusercontent.com/u/328557?v=3","gravatar_id":"","url":"https://api.github.com/users/bjmc","html_url":"https://github.com/bjmc","followers_url":"https://api.github.com/users/bjmc/followers","following_url":"https://api.github.com/users/bjmc/following{/other_user}","gists_url":"https://api.github.com/users/bjmc/gists{/gist_id}","starred_url":"https://api.github.com/users/bjmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjmc/subscriptions","organizations_url":"https://api.github.com/users/bjmc/orgs","repos_url":"https://api.github.com/users/bjmc/repos","events_url":"https://api.github.com/users/bjmc/events{/privacy}","received_events_url":"https://api.github.com/users/bjmc/received_events","type":"User","site_admin":false},"body":"This changeset is an attempt to improve and standardize the validator registration hooks introduced with the OpenIDConnect changes.\r\n\r\n- Moves custom validator registration up onto the `GrantTypeBase` class and removes those methods from the subclass grants.\r\n- DRYs up the OpenIDConnect grant type classes to be more of thin proxies onto the standard OAuth2 grant classes.\r\n- Adds the ability to register validators that run either before or after the standard validation methods.\r\n- Adds custom validator invocations to `ClientCredentialsGrant`, `RefreshTokenGrant` and `ResourceOwnerPasswordCredentialsGrant`.\r\n- Adds tests for custom validators.","created_at":"2016-11-21T14:59:24Z","updated_at":"2016-12-20T14:43:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b2f9fa2a759c0c36c861c9eb9e2b396433aa5a5a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/idan/oauthlib/pulls/449/commits","review_comments_url":"https://api.github.com/repos/idan/oauthlib/pulls/449/comments","review_comment_url":"https://api.github.com/repos/idan/oauthlib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/idan/oauthlib/issues/449/comments","statuses_url":"https://api.github.com/repos/idan/oauthlib/statuses/16907d5418cd3be4f116da2c32d55bacf7167c92","head":{"label":"bjmc:improve_validator_registration","ref":"improve_validator_registration","sha":"16907d5418cd3be4f116da2c32d55bacf7167c92","user":{"login":"bjmc","id":328557,"avatar_url":"https://avatars.githubusercontent.com/u/328557?v=3","gravatar_id":"","url":"https://api.github.com/users/bjmc","html_url":"https://github.com/bjmc","followers_url":"https://api.github.com/users/bjmc/followers","following_url":"https://api.github.com/users/bjmc/following{/other_user}","gists_url":"https://api.github.com/users/bjmc/gists{/gist_id}","starred_url":"https://api.github.com/users/bjmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjmc/subscriptions","organizations_url":"https://api.github.com/users/bjmc/orgs","repos_url":"https://api.github.com/users/bjmc/repos","events_url":"https://api.github.com/users/bjmc/events{/privacy}","received_events_url":"https://api.github.com/users/bjmc/received_events","type":"User","site_admin":false},"repo":{"id":37828961,"name":"oauthlib","full_name":"bjmc/oauthlib","owner":{"login":"bjmc","id":328557,"avatar_url":"https://avatars.githubusercontent.com/u/328557?v=3","gravatar_id":"","url":"https://api.github.com/users/bjmc","html_url":"https://github.com/bjmc","followers_url":"https://api.github.com/users/bjmc/followers","following_url":"https://api.github.com/users/bjmc/following{/other_user}","gists_url":"https://api.github.com/users/bjmc/gists{/gist_id}","starred_url":"https://api.github.com/users/bjmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjmc/subscriptions","organizations_url":"https://api.github.com/users/bjmc/orgs","repos_url":"https://api.github.com/users/bjmc/repos","events_url":"https://api.github.com/users/bjmc/events{/privacy}","received_events_url":"https://api.github.com/users/bjmc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bjmc/oauthlib","description":"A generic, spec-compliant, thorough implementation of the OAuth request-signing logic","fork":true,"url":"https://api.github.com/repos/bjmc/oauthlib","forks_url":"https://api.github.com/repos/bjmc/oauthlib/forks","keys_url":"https://api.github.com/repos/bjmc/oauthlib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bjmc/oauthlib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bjmc/oauthlib/teams","hooks_url":"https://api.github.com/repos/bjmc/oauthlib/hooks","issue_events_url":"https://api.github.com/repos/bjmc/oauthlib/issues/events{/number}","events_url":"https://api.github.com/repos/bjmc/oauthlib/events","assignees_url":"https://api.github.com/repos/bjmc/oauthlib/assignees{/user}","branches_url":"https://api.github.com/repos/bjmc/oauthlib/branches{/branch}","tags_url":"https://api.github.com/repos/bjmc/oauthlib/tags","blobs_url":"https://api.github.com/repos/bjmc/oauthlib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bjmc/oauthlib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bjmc/oauthlib/git/refs{/sha}","trees_url":"https://api.github.com/repos/bjmc/oauthlib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bjmc/oauthlib/statuses/{sha}","languages_url":"https://api.github.com/repos/bjmc/oauthlib/languages","stargazers_url":"https://api.github.com/repos/bjmc/oauthlib/stargazers","contributors_url":"https://api.github.com/repos/bjmc/oauthlib/contributors","subscribers_url":"https://api.github.com/repos/bjmc/oauthlib/subscribers","subscription_url":"https://api.github.com/repos/bjmc/oauthlib/subscription","commits_url":"https://api.github.com/repos/bjmc/oauthlib/commits{/sha}","git_commits_url":"https://api.github.com/repos/bjmc/oauthlib/git/commits{/sha}","comments_url":"https://api.github.com/repos/bjmc/oauthlib/comments{/number}","issue_comment_url":"https://api.github.com/repos/bjmc/oauthlib/issues/comments{/number}","contents_url":"https://api.github.com/repos/bjmc/oauthlib/contents/{+path}","compare_url":"https://api.github.com/repos/bjmc/oauthlib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bjmc/oauthlib/merges","archive_url":"https://api.github.com/repos/bjmc/oauthlib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bjmc/oauthlib/downloads","issues_url":"https://api.github.com/repos/bjmc/oauthlib/issues{/number}","pulls_url":"https://api.github.com/repos/bjmc/oauthlib/pulls{/number}","milestones_url":"https://api.github.com/repos/bjmc/oauthlib/milestones{/number}","notifications_url":"https://api.github.com/repos/bjmc/oauthlib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bjmc/oauthlib/labels{/name}","releases_url":"https://api.github.com/repos/bjmc/oauthlib/releases{/id}","deployments_url":"https://api.github.com/repos/bjmc/oauthlib/deployments","created_at":"2015-06-21T22:39:05Z","updated_at":"2016-11-03T22:49:30Z","pushed_at":"2016-12-20T11:15:54Z","git_url":"git://github.com/bjmc/oauthlib.git","ssh_url":"git@github.com:bjmc/oauthlib.git","clone_url":"https://github.com/bjmc/oauthlib.git","svn_url":"https://github.com/bjmc/oauthlib","homepage":"","size":1666,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"idan:master","ref":"master","sha":"67f973ff7f98bb3d892a33eda67ba1dab3bddead","user":{"login":"idan","id":22723,"avatar_url":"https://avatars.githubusercontent.com/u/22723?v=3","gravatar_id":"","url":"https://api.github.com/users/idan","html_url":"https://github.com/idan","followers_url":"https://api.github.com/users/idan/followers","following_url":"https://api.github.com/users/idan/following{/other_user}","gists_url":"https://api.github.com/users/idan/gists{/gist_id}","starred_url":"https://api.github.com/users/idan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/idan/subscriptions","organizations_url":"https://api.github.com/users/idan/orgs","repos_url":"https://api.github.com/users/idan/repos","events_url":"https://api.github.com/users/idan/events{/privacy}","received_events_url":"https://api.github.com/users/idan/received_events","type":"User","site_admin":false},"repo":{"id":2811323,"name":"oauthlib","full_name":"idan/oauthlib","owner":{"login":"idan","id":22723,"avatar_url":"https://avatars.githubusercontent.com/u/22723?v=3","gravatar_id":"","url":"https://api.github.com/users/idan","html_url":"https://github.com/idan","followers_url":"https://api.github.com/users/idan/followers","following_url":"https://api.github.com/users/idan/following{/other_user}","gists_url":"https://api.github.com/users/idan/gists{/gist_id}","starred_url":"https://api.github.com/users/idan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/idan/subscriptions","organizations_url":"https://api.github.com/users/idan/orgs","repos_url":"https://api.github.com/users/idan/repos","events_url":"https://api.github.com/users/idan/events{/privacy}","received_events_url":"https://api.github.com/users/idan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/idan/oauthlib","description":"A generic, spec-compliant, thorough implementation of the OAuth request-signing logic","fork":false,"url":"https://api.github.com/repos/idan/oauthlib","forks_url":"https://api.github.com/repos/idan/oauthlib/forks","keys_url":"https://api.github.com/repos/idan/oauthlib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/idan/oauthlib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/idan/oauthlib/teams","hooks_url":"https://api.github.com/repos/idan/oauthlib/hooks","issue_events_url":"https://api.github.com/repos/idan/oauthlib/issues/events{/number}","events_url":"https://api.github.com/repos/idan/oauthlib/events","assignees_url":"https://api.github.com/repos/idan/oauthlib/assignees{/user}","branches_url":"https://api.github.com/repos/idan/oauthlib/branches{/branch}","tags_url":"https://api.github.com/repos/idan/oauthlib/tags","blobs_url":"https://api.github.com/repos/idan/oauthlib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/idan/oauthlib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/idan/oauthlib/git/refs{/sha}","trees_url":"https://api.github.com/repos/idan/oauthlib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/idan/oauthlib/statuses/{sha}","languages_url":"https://api.github.com/repos/idan/oauthlib/languages","stargazers_url":"https://api.github.com/repos/idan/oauthlib/stargazers","contributors_url":"https://api.github.com/repos/idan/oauthlib/contributors","subscribers_url":"https://api.github.com/repos/idan/oauthlib/subscribers","subscription_url":"https://api.github.com/repos/idan/oauthlib/subscription","commits_url":"https://api.github.com/repos/idan/oauthlib/commits{/sha}","git_commits_url":"https://api.github.com/repos/idan/oauthlib/git/commits{/sha}","comments_url":"https://api.github.com/repos/idan/oauthlib/comments{/number}","issue_comment_url":"https://api.github.com/repos/idan/oauthlib/issues/comments{/number}","contents_url":"https://api.github.com/repos/idan/oauthlib/contents/{+path}","compare_url":"https://api.github.com/repos/idan/oauthlib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/idan/oauthlib/merges","archive_url":"https://api.github.com/repos/idan/oauthlib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/idan/oauthlib/downloads","issues_url":"https://api.github.com/repos/idan/oauthlib/issues{/number}","pulls_url":"https://api.github.com/repos/idan/oauthlib/pulls{/number}","milestones_url":"https://api.github.com/repos/idan/oauthlib/milestones{/number}","notifications_url":"https://api.github.com/repos/idan/oauthlib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/idan/oauthlib/labels{/name}","releases_url":"https://api.github.com/repos/idan/oauthlib/releases{/id}","deployments_url":"https://api.github.com/repos/idan/oauthlib/deployments","created_at":"2011-11-19T23:08:51Z","updated_at":"2016-12-20T02:32:50Z","pushed_at":"2016-12-20T11:15:56Z","git_url":"git://github.com/idan/oauthlib.git","ssh_url":"git@github.com:idan/oauthlib.git","clone_url":"https://github.com/idan/oauthlib.git","svn_url":"https://github.com/idan/oauthlib","homepage":"","size":2528,"stargazers_count":1275,"watchers_count":1275,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":280,"mirror_url":null,"open_issues_count":70,"forks":280,"open_issues":70,"watchers":1275,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/idan/oauthlib/pulls/449"},"html":{"href":"https://github.com/idan/oauthlib/pull/449"},"issue":{"href":"https://api.github.com/repos/idan/oauthlib/issues/449"},"comments":{"href":"https://api.github.com/repos/idan/oauthlib/issues/449/comments"},"review_comments":{"href":"https://api.github.com/repos/idan/oauthlib/pulls/449/comments"},"review_comment":{"href":"https://api.github.com/repos/idan/oauthlib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/idan/oauthlib/pulls/449/commits"},"statuses":{"href":"https://api.github.com/repos/idan/oauthlib/statuses/16907d5418cd3be4f116da2c32d55bacf7167c92"}}}}
{"actor":{"display_login":"kevin-brown"}}