{"action":"opened","issue":{"url":"https://api.github.com/repos/hoxu/encrb/issues/2","repository_url":"https://api.github.com/repos/hoxu/encrb","labels_url":"https://api.github.com/repos/hoxu/encrb/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/hoxu/encrb/issues/2/comments","events_url":"https://api.github.com/repos/hoxu/encrb/issues/2/events","html_url":"https://github.com/hoxu/encrb/issues/2","id":140120419,"number":2,"title":"propagate exit status on failed rsync","user":{"login":"pauldreik","id":3541498,"avatar_url":"https://avatars.githubusercontent.com/u/3541498?v=3","gravatar_id":"","url":"https://api.github.com/users/pauldreik","html_url":"https://github.com/pauldreik","followers_url":"https://api.github.com/users/pauldreik/followers","following_url":"https://api.github.com/users/pauldreik/following{/other_user}","gists_url":"https://api.github.com/users/pauldreik/gists{/gist_id}","starred_url":"https://api.github.com/users/pauldreik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pauldreik/subscriptions","organizations_url":"https://api.github.com/users/pauldreik/orgs","repos_url":"https://api.github.com/users/pauldreik/repos","events_url":"https://api.github.com/users/pauldreik/events{/privacy}","received_events_url":"https://api.github.com/users/pauldreik/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2016-03-11T08:24:14Z","updated_at":"2016-03-11T08:24:14Z","closed_at":null,"body":"Hi,\r\nI have successfully been using encrb for quite some time now, it works greate. However, I just encountered a temporary dns problem with missing host name. This is what rsync said on stderr:\r\n\r\n> ssh: Could not resolve hostname example.com: Name or service not known\r\n> rsync: connection unexpectedly closed (0 bytes received so far) [sender]\r\n> rsync error: unexplained error (code 255) at io.c(226) [sender=3.1.1]\r\n\r\nand I believe the exit status of rsync in this case is nonzero. However, the encrb script does not seem to propagate that return status to its own return status. The relevant line of code is this one:\r\n`subprocess.call(['rsync', '-a .....`\r\n\r\nThe consequence of this is that my crontab entry running encrb reports the synchronization as successful, even if it wasn't. \r\n\r\nCan you please make sure encrb signals to its user when it encountered a problem?\r\n\r\nThanks,\r\nPaul"}}