{"action":"created","comment":{"url":"https://api.github.com/repos/Wikia/app/pulls/comments/64236536","id":64236536,"diff_hunk":"@@ -176,8 +176,17 @@ function execute( $par ){\n \t\t\t\t\t);\n \t\t\t\t\t$idToTitle = array();\n \t\t\t\t\t$ids = array_unique($ids);\n-\t\t\t\t\t$queryString = \"SELECT page_id, page_namespace, page_title FROM $TABLE_PREFIX\".\"page WHERE page_id IN (\".implode(\",\", $ids).\")\";\n-\t\t\t\t\t$res2 = $dbr->query($queryString);\n+\n+\t\t\t\t\t$res2 = $dbr->select(\n+\t\t\t\t\t\t\"page\",\n+\t\t\t\t\t\t[\n+\t\t\t\t\t\t\t\"page_id\",\n+\t\t\t\t\t\t\t\"page_namespace\",\n+\t\t\t\t\t\t\t\"page_title\"\n+\t\t\t\t\t\t],\n+\t\t\t\t\t\t\"page_id IN (\".implode(\",\", $ids).\")\",","path":"extensions/3rdparty/LyricWiki/Special_LinksToRedirects.php","position":142,"original_position":14,"commit_id":"18514e019bf6fc5fa8e05c68404f9f5285db51db","original_commit_id":"18514e019bf6fc5fa8e05c68404f9f5285db51db","user":{"login":"SeanColombo","id":237336,"avatar_url":"https://avatars.githubusercontent.com/u/237336?v=3","gravatar_id":"","url":"https://api.github.com/users/SeanColombo","html_url":"https://github.com/SeanColombo","followers_url":"https://api.github.com/users/SeanColombo/followers","following_url":"https://api.github.com/users/SeanColombo/following{/other_user}","gists_url":"https://api.github.com/users/SeanColombo/gists{/gist_id}","starred_url":"https://api.github.com/users/SeanColombo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SeanColombo/subscriptions","organizations_url":"https://api.github.com/users/SeanColombo/orgs","repos_url":"https://api.github.com/users/SeanColombo/repos","events_url":"https://api.github.com/users/SeanColombo/events{/privacy}","received_events_url":"https://api.github.com/users/SeanColombo/received_events","type":"User","site_admin":false},"body":"Changed in latest commit on branch.","created_at":"2016-05-23T14:54:37Z","updated_at":"2016-05-23T14:54:37Z","html_url":"https://github.com/Wikia/app/pull/10415#discussion_r64236536","pull_request_url":"https://api.github.com/repos/Wikia/app/pulls/10415","_links":{"self":{"href":"https://api.github.com/repos/Wikia/app/pulls/comments/64236536"},"html":{"href":"https://github.com/Wikia/app/pull/10415#discussion_r64236536"},"pull_request":{"href":"https://api.github.com/repos/Wikia/app/pulls/10415"}}},"pull_request":{"url":"https://api.github.com/repos/Wikia/app/pulls/10415","id":69275493,"html_url":"https://github.com/Wikia/app/pull/10415","diff_url":"https://github.com/Wikia/app/pull/10415.diff","patch_url":"https://github.com/Wikia/app/pull/10415.patch","issue_url":"https://api.github.com/repos/Wikia/app/issues/10415","number":10415,"state":"open","locked":false,"title":"Lyr 262","user":{"login":"SeanColombo","id":237336,"avatar_url":"https://avatars.githubusercontent.com/u/237336?v=3","gravatar_id":"","url":"https://api.github.com/users/SeanColombo","html_url":"https://github.com/SeanColombo","followers_url":"https://api.github.com/users/SeanColombo/followers","following_url":"https://api.github.com/users/SeanColombo/following{/other_user}","gists_url":"https://api.github.com/users/SeanColombo/gists{/gist_id}","starred_url":"https://api.github.com/users/SeanColombo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SeanColombo/subscriptions","organizations_url":"https://api.github.com/users/SeanColombo/orgs","repos_url":"https://api.github.com/users/SeanColombo/repos","events_url":"https://api.github.com/users/SeanColombo/events{/privacy}","received_events_url":"https://api.github.com/users/SeanColombo/received_events","type":"User","site_admin":false},"body":"Modernized the LyricWiki extensions not to use mysql_ anywhere. There were some chunks of commented-out code I just swapped to mysqli_ (note the \"i\") but in general I switched them to using MediaWiki's database objects.\r\n\r\nAlso, extracted the common code from Soap search failures and Mobile search failures to share a base-class SearchFailuresSpecialPage so that the code only needs to be maintained in one spot.\r\n\r\nTested these on my devbox and all looks good. Strangely, in production with current code, no data shows up... the tables appear to be there in production dbs, so hopefully when we push, these updates will make some of this visible again.\r\n\r\nIn production, Special:LinksToRedirects and Special:ArtistRedirects have regressed to basically being blank and this is likely hurting SEO. Will be good to keep an eye on LW traffic a couple of weeks after this change to see if it results in an improvement.","created_at":"2016-05-08T18:24:13Z","updated_at":"2016-05-23T14:54:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fa7bc4f6235afd3d9025395e798a7b0834144529","assignee":{"login":"macbre","id":1929317,"avatar_url":"https://avatars.githubusercontent.com/u/1929317?v=3","gravatar_id":"","url":"https://api.github.com/users/macbre","html_url":"https://github.com/macbre","followers_url":"https://api.github.com/users/macbre/followers","following_url":"https://api.github.com/users/macbre/following{/other_user}","gists_url":"https://api.github.com/users/macbre/gists{/gist_id}","starred_url":"https://api.github.com/users/macbre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/macbre/subscriptions","organizations_url":"https://api.github.com/users/macbre/orgs","repos_url":"https://api.github.com/users/macbre/repos","events_url":"https://api.github.com/users/macbre/events{/privacy}","received_events_url":"https://api.github.com/users/macbre/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/Wikia/app/pulls/10415/commits","review_comments_url":"https://api.github.com/repos/Wikia/app/pulls/10415/comments","review_comment_url":"https://api.github.com/repos/Wikia/app/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Wikia/app/issues/10415/comments","statuses_url":"https://api.github.com/repos/Wikia/app/statuses/18514e019bf6fc5fa8e05c68404f9f5285db51db","head":{"label":"Wikia:LYR-262","ref":"LYR-262","sha":"18514e019bf6fc5fa8e05c68404f9f5285db51db","user":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"repo":{"id":5532313,"name":"app","full_name":"Wikia/app","owner":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Wikia/app","description":"Wikia Application Code","fork":false,"url":"https://api.github.com/repos/Wikia/app","forks_url":"https://api.github.com/repos/Wikia/app/forks","keys_url":"https://api.github.com/repos/Wikia/app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Wikia/app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Wikia/app/teams","hooks_url":"https://api.github.com/repos/Wikia/app/hooks","issue_events_url":"https://api.github.com/repos/Wikia/app/issues/events{/number}","events_url":"https://api.github.com/repos/Wikia/app/events","assignees_url":"https://api.github.com/repos/Wikia/app/assignees{/user}","branches_url":"https://api.github.com/repos/Wikia/app/branches{/branch}","tags_url":"https://api.github.com/repos/Wikia/app/tags","blobs_url":"https://api.github.com/repos/Wikia/app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Wikia/app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Wikia/app/git/refs{/sha}","trees_url":"https://api.github.com/repos/Wikia/app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Wikia/app/statuses/{sha}","languages_url":"https://api.github.com/repos/Wikia/app/languages","stargazers_url":"https://api.github.com/repos/Wikia/app/stargazers","contributors_url":"https://api.github.com/repos/Wikia/app/contributors","subscribers_url":"https://api.github.com/repos/Wikia/app/subscribers","subscription_url":"https://api.github.com/repos/Wikia/app/subscription","commits_url":"https://api.github.com/repos/Wikia/app/commits{/sha}","git_commits_url":"https://api.github.com/repos/Wikia/app/git/commits{/sha}","comments_url":"https://api.github.com/repos/Wikia/app/comments{/number}","issue_comment_url":"https://api.github.com/repos/Wikia/app/issues/comments{/number}","contents_url":"https://api.github.com/repos/Wikia/app/contents/{+path}","compare_url":"https://api.github.com/repos/Wikia/app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Wikia/app/merges","archive_url":"https://api.github.com/repos/Wikia/app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Wikia/app/downloads","issues_url":"https://api.github.com/repos/Wikia/app/issues{/number}","pulls_url":"https://api.github.com/repos/Wikia/app/pulls{/number}","milestones_url":"https://api.github.com/repos/Wikia/app/milestones{/number}","notifications_url":"https://api.github.com/repos/Wikia/app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Wikia/app/labels{/name}","releases_url":"https://api.github.com/repos/Wikia/app/releases{/id}","deployments_url":"https://api.github.com/repos/Wikia/app/deployments","created_at":"2012-08-23T20:55:58Z","updated_at":"2016-05-23T13:53:39Z","pushed_at":"2016-05-23T14:38:47Z","git_url":"git://github.com/Wikia/app.git","ssh_url":"git@github.com:Wikia/app.git","clone_url":"https://github.com/Wikia/app.git","svn_url":"https://github.com/Wikia/app","homepage":"http://dev.wikia.com","size":2335093,"stargazers_count":97,"watchers_count":97,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":80,"mirror_url":null,"open_issues_count":90,"forks":80,"open_issues":90,"watchers":97,"default_branch":"dev"}},"base":{"label":"Wikia:dev","ref":"dev","sha":"afea63c52abba070839715b97cd6db2c2525fab9","user":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"repo":{"id":5532313,"name":"app","full_name":"Wikia/app","owner":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Wikia/app","description":"Wikia Application Code","fork":false,"url":"https://api.github.com/repos/Wikia/app","forks_url":"https://api.github.com/repos/Wikia/app/forks","keys_url":"https://api.github.com/repos/Wikia/app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Wikia/app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Wikia/app/teams","hooks_url":"https://api.github.com/repos/Wikia/app/hooks","issue_events_url":"https://api.github.com/repos/Wikia/app/issues/events{/number}","events_url":"https://api.github.com/repos/Wikia/app/events","assignees_url":"https://api.github.com/repos/Wikia/app/assignees{/user}","branches_url":"https://api.github.com/repos/Wikia/app/branches{/branch}","tags_url":"https://api.github.com/repos/Wikia/app/tags","blobs_url":"https://api.github.com/repos/Wikia/app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Wikia/app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Wikia/app/git/refs{/sha}","trees_url":"https://api.github.com/repos/Wikia/app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Wikia/app/statuses/{sha}","languages_url":"https://api.github.com/repos/Wikia/app/languages","stargazers_url":"https://api.github.com/repos/Wikia/app/stargazers","contributors_url":"https://api.github.com/repos/Wikia/app/contributors","subscribers_url":"https://api.github.com/repos/Wikia/app/subscribers","subscription_url":"https://api.github.com/repos/Wikia/app/subscription","commits_url":"https://api.github.com/repos/Wikia/app/commits{/sha}","git_commits_url":"https://api.github.com/repos/Wikia/app/git/commits{/sha}","comments_url":"https://api.github.com/repos/Wikia/app/comments{/number}","issue_comment_url":"https://api.github.com/repos/Wikia/app/issues/comments{/number}","contents_url":"https://api.github.com/repos/Wikia/app/contents/{+path}","compare_url":"https://api.github.com/repos/Wikia/app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Wikia/app/merges","archive_url":"https://api.github.com/repos/Wikia/app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Wikia/app/downloads","issues_url":"https://api.github.com/repos/Wikia/app/issues{/number}","pulls_url":"https://api.github.com/repos/Wikia/app/pulls{/number}","milestones_url":"https://api.github.com/repos/Wikia/app/milestones{/number}","notifications_url":"https://api.github.com/repos/Wikia/app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Wikia/app/labels{/name}","releases_url":"https://api.github.com/repos/Wikia/app/releases{/id}","deployments_url":"https://api.github.com/repos/Wikia/app/deployments","created_at":"2012-08-23T20:55:58Z","updated_at":"2016-05-23T13:53:39Z","pushed_at":"2016-05-23T14:38:47Z","git_url":"git://github.com/Wikia/app.git","ssh_url":"git@github.com:Wikia/app.git","clone_url":"https://github.com/Wikia/app.git","svn_url":"https://github.com/Wikia/app","homepage":"http://dev.wikia.com","size":2335093,"stargazers_count":97,"watchers_count":97,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":80,"mirror_url":null,"open_issues_count":90,"forks":80,"open_issues":90,"watchers":97,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/Wikia/app/pulls/10415"},"html":{"href":"https://github.com/Wikia/app/pull/10415"},"issue":{"href":"https://api.github.com/repos/Wikia/app/issues/10415"},"comments":{"href":"https://api.github.com/repos/Wikia/app/issues/10415/comments"},"review_comments":{"href":"https://api.github.com/repos/Wikia/app/pulls/10415/comments"},"review_comment":{"href":"https://api.github.com/repos/Wikia/app/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Wikia/app/pulls/10415/commits"},"statuses":{"href":"https://api.github.com/repos/Wikia/app/statuses/18514e019bf6fc5fa8e05c68404f9f5285db51db"}}}}
{"actor":{"display_login":"SeanColombo"}}