{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/59930618","id":59930618,"diff_hunk":"@@ -248,12 +249,12 @@ internal void GenerateSupportedTypes(Type[] types, TypeBuilder serializerContrac\n                     continue;\n                 if (!type.GetTypeInfo().IsPublic && !type.GetTypeInfo().IsNestedPublic)\n                     continue;\n-                if (uniqueTypes[type] != null)\n+                if (uniqueTypes.Contains(type))\n                     continue;\n                 // DDB172141: Wrong generated CS for serializer of List<string> type\n                 if (type.GetTypeInfo().IsGenericType || type.GetTypeInfo().ContainsGenericParameters)\n                     continue;\n-                uniqueTypes[type] = type;\n+                uniqueTypes.Add(type);","path":"src/System.Xml.XmlSerializer/src/System/Xml/Serialization/XmlSerializationILGen.cs","position":71,"original_position":71,"commit_id":"56b215c7e19a2d672ca464fb01bd1956e55140da","original_commit_id":"56b215c7e19a2d672ca464fb01bd1956e55140da","user":{"login":"justinvp","id":710598,"avatar_url":"https://avatars.githubusercontent.com/u/710598?v=3","gravatar_id":"","url":"https://api.github.com/users/justinvp","html_url":"https://github.com/justinvp","followers_url":"https://api.github.com/users/justinvp/followers","following_url":"https://api.github.com/users/justinvp/following{/other_user}","gists_url":"https://api.github.com/users/justinvp/gists{/gist_id}","starred_url":"https://api.github.com/users/justinvp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinvp/subscriptions","organizations_url":"https://api.github.com/users/justinvp/orgs","repos_url":"https://api.github.com/users/justinvp/repos","events_url":"https://api.github.com/users/justinvp/events{/privacy}","received_events_url":"https://api.github.com/users/justinvp/received_events","type":"User","site_admin":false},"body":"Nit: Same comment about using single call to `HashSet<T>.Add` instead of `Contains` & `Add`.","created_at":"2016-04-15T19:44:45Z","updated_at":"2016-04-15T19:44:45Z","html_url":"https://github.com/dotnet/corefx/pull/7765#discussion_r59930618","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/7765","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/59930618"},"html":{"href":"https://github.com/dotnet/corefx/pull/7765#discussion_r59930618"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/7765"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/7765","id":66574247,"html_url":"https://github.com/dotnet/corefx/pull/7765","diff_url":"https://github.com/dotnet/corefx/pull/7765.diff","patch_url":"https://github.com/dotnet/corefx/pull/7765.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/7765","number":7765,"state":"open","locked":false,"title":"Remove nongeneric collections shim from serialization","user":{"login":"khdang","id":10590707,"avatar_url":"https://avatars.githubusercontent.com/u/10590707?v=3","gravatar_id":"","url":"https://api.github.com/users/khdang","html_url":"https://github.com/khdang","followers_url":"https://api.github.com/users/khdang/followers","following_url":"https://api.github.com/users/khdang/following{/other_user}","gists_url":"https://api.github.com/users/khdang/gists{/gist_id}","starred_url":"https://api.github.com/users/khdang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khdang/subscriptions","organizations_url":"https://api.github.com/users/khdang/orgs","repos_url":"https://api.github.com/users/khdang/repos","events_url":"https://api.github.com/users/khdang/events{/privacy}","received_events_url":"https://api.github.com/users/khdang/received_events","type":"User","site_admin":false},"body":"Remove non-generic collections ```ArrayList``` and ```InternalHashtable``` and use ArrayList and generic dictionary instead. There should be no change in behavior.\r\n\r\ncc: @shmao @zhenlan @SGuyGe\r\n\r\nFix #7699 ","created_at":"2016-04-15T00:21:41Z","updated_at":"2016-04-15T19:44:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ff74192e6cec5d67f852ad730d058c0d7d23a054","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/7765/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/7765/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/7765/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/56b215c7e19a2d672ca464fb01bd1956e55140da","head":{"label":"khdang:remove_collections_shim_serialization","ref":"remove_collections_shim_serialization","sha":"56b215c7e19a2d672ca464fb01bd1956e55140da","user":{"login":"khdang","id":10590707,"avatar_url":"https://avatars.githubusercontent.com/u/10590707?v=3","gravatar_id":"","url":"https://api.github.com/users/khdang","html_url":"https://github.com/khdang","followers_url":"https://api.github.com/users/khdang/followers","following_url":"https://api.github.com/users/khdang/following{/other_user}","gists_url":"https://api.github.com/users/khdang/gists{/gist_id}","starred_url":"https://api.github.com/users/khdang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khdang/subscriptions","organizations_url":"https://api.github.com/users/khdang/orgs","repos_url":"https://api.github.com/users/khdang/repos","events_url":"https://api.github.com/users/khdang/events{/privacy}","received_events_url":"https://api.github.com/users/khdang/received_events","type":"User","site_admin":false},"repo":{"id":33624190,"name":"corefx","full_name":"khdang/corefx","owner":{"login":"khdang","id":10590707,"avatar_url":"https://avatars.githubusercontent.com/u/10590707?v=3","gravatar_id":"","url":"https://api.github.com/users/khdang","html_url":"https://github.com/khdang","followers_url":"https://api.github.com/users/khdang/followers","following_url":"https://api.github.com/users/khdang/following{/other_user}","gists_url":"https://api.github.com/users/khdang/gists{/gist_id}","starred_url":"https://api.github.com/users/khdang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khdang/subscriptions","organizations_url":"https://api.github.com/users/khdang/orgs","repos_url":"https://api.github.com/users/khdang/repos","events_url":"https://api.github.com/users/khdang/events{/privacy}","received_events_url":"https://api.github.com/users/khdang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/khdang/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":true,"url":"https://api.github.com/repos/khdang/corefx","forks_url":"https://api.github.com/repos/khdang/corefx/forks","keys_url":"https://api.github.com/repos/khdang/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/khdang/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/khdang/corefx/teams","hooks_url":"https://api.github.com/repos/khdang/corefx/hooks","issue_events_url":"https://api.github.com/repos/khdang/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/khdang/corefx/events","assignees_url":"https://api.github.com/repos/khdang/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/khdang/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/khdang/corefx/tags","blobs_url":"https://api.github.com/repos/khdang/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/khdang/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/khdang/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/khdang/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/khdang/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/khdang/corefx/languages","stargazers_url":"https://api.github.com/repos/khdang/corefx/stargazers","contributors_url":"https://api.github.com/repos/khdang/corefx/contributors","subscribers_url":"https://api.github.com/repos/khdang/corefx/subscribers","subscription_url":"https://api.github.com/repos/khdang/corefx/subscription","commits_url":"https://api.github.com/repos/khdang/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/khdang/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/khdang/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/khdang/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/khdang/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/khdang/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/khdang/corefx/merges","archive_url":"https://api.github.com/repos/khdang/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/khdang/corefx/downloads","issues_url":"https://api.github.com/repos/khdang/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/khdang/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/khdang/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/khdang/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/khdang/corefx/labels{/name}","releases_url":"https://api.github.com/repos/khdang/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/khdang/corefx/deployments","created_at":"2015-04-08T18:20:35Z","updated_at":"2016-02-10T22:31:56Z","pushed_at":"2016-04-15T19:16:59Z","git_url":"git://github.com/khdang/corefx.git","ssh_url":"git@github.com:khdang/corefx.git","clone_url":"https://github.com/khdang/corefx.git","svn_url":"https://github.com/khdang/corefx","homepage":"","size":64156,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"41ed002acfbf26ae743b96a9f01342f37ba265bc","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/corefx/deployments","created_at":"2014-11-06T23:42:48Z","updated_at":"2016-04-15T16:11:00Z","pushed_at":"2016-04-15T19:18:24Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"http://dotnet.github.io/","size":86954,"stargazers_count":9500,"watchers_count":9500,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2256,"mirror_url":null,"open_issues_count":934,"forks":2256,"open_issues":934,"watchers":9500,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/7765"},"html":{"href":"https://github.com/dotnet/corefx/pull/7765"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/7765"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/7765/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/7765/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/7765/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/56b215c7e19a2d672ca464fb01bd1956e55140da"}}}}