{"action":"closed","number":53,"pull_request":{"url":"https://api.github.com/repos/Teiid-Designer/vdb-bench/pulls/53","id":97951570,"html_url":"https://github.com/Teiid-Designer/vdb-bench/pull/53","diff_url":"https://github.com/Teiid-Designer/vdb-bench/pull/53.diff","patch_url":"https://github.com/Teiid-Designer/vdb-bench/pull/53.patch","issue_url":"https://api.github.com/repos/Teiid-Designer/vdb-bench/issues/53","number":53,"state":"closed","locked":false,"title":"Changes the position of the help icon","user":{"login":"phantomjinx","id":1634180,"avatar_url":"https://avatars.githubusercontent.com/u/1634180?v=3","gravatar_id":"","url":"https://api.github.com/users/phantomjinx","html_url":"https://github.com/phantomjinx","followers_url":"https://api.github.com/users/phantomjinx/followers","following_url":"https://api.github.com/users/phantomjinx/following{/other_user}","gists_url":"https://api.github.com/users/phantomjinx/gists{/gist_id}","starred_url":"https://api.github.com/users/phantomjinx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phantomjinx/subscriptions","organizations_url":"https://api.github.com/users/phantomjinx/orgs","repos_url":"https://api.github.com/users/phantomjinx/repos","events_url":"https://api.github.com/users/phantomjinx/events{/privacy}","received_events_url":"https://api.github.com/users/phantomjinx/received_events","type":"User","site_admin":false},"body":"This seeks to address the issues previously discussed. Please review and get back to me with thoughts.\r\n\r\nScreenGrab: http://phantomjinx.co.uk/stuff/ds-summary-help-icon-move.png\r\n\r\n* dataservice-main.html\r\n * Adds the page-help-icon to the data-service main container and uses an\r\n   absolute position to enforce its right-hand side position.\r\n * Only 1 entry of the page-help-icon helps keep it consistent across all\r\n   the pages\r\n * Separates the title from the help icon but includes the title here for\r\n   ensuring each page is again consistent\r\n\r\n* dataservicePageController\r\n * When getting the page title, if there is a custom title then use that,\r\n   otherwise return the standard title. This allows the existing behaviour\r\n   of appending the dataservice id to the end of the title\r\n * On changing the page, delete the custom title\r\n\r\n* dsPageService\r\n * Adds standard helpIds into page metadata\r\n * Provides setter for custom helpIds should it be required\r\n * Provides setter for custom title should it be required\r\n\r\n* svcSourceCloneController.js\r\n* dsCloneController.js\r\n* dsEditController.js\r\n* dsTestController.js\r\n * Adds a custom title on loading of the page\r\n\r\n* HelpService\r\n * Slightly off-topic to rest of commit but avoids an infinite loop. If a\r\n   page is not found then the getHelpPageUrl() calls itself with the\r\n   PAGE-NOT-FOUND key. Unfortunately, this is not found so the function is\r\n   stuck infinitely calling itself.","created_at":"2016-12-14T13:27:01Z","updated_at":"2016-12-19T16:00:09Z","closed_at":"2016-12-19T16:00:09Z","merged_at":"2016-12-19T16:00:09Z","merge_commit_sha":"b388f73c6df67dd65ce034374f9e34240c56b09a","assignee":{"login":"tejones","id":560417,"avatar_url":"https://avatars.githubusercontent.com/u/560417?v=3","gravatar_id":"","url":"https://api.github.com/users/tejones","html_url":"https://github.com/tejones","followers_url":"https://api.github.com/users/tejones/followers","following_url":"https://api.github.com/users/tejones/following{/other_user}","gists_url":"https://api.github.com/users/tejones/gists{/gist_id}","starred_url":"https://api.github.com/users/tejones/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tejones/subscriptions","organizations_url":"https://api.github.com/users/tejones/orgs","repos_url":"https://api.github.com/users/tejones/repos","events_url":"https://api.github.com/users/tejones/events{/privacy}","received_events_url":"https://api.github.com/users/tejones/received_events","type":"User","site_admin":false},"assignees":[{"login":"tejones","id":560417,"avatar_url":"https://avatars.githubusercontent.com/u/560417?v=3","gravatar_id":"","url":"https://api.github.com/users/tejones","html_url":"https://github.com/tejones","followers_url":"https://api.github.com/users/tejones/followers","following_url":"https://api.github.com/users/tejones/following{/other_user}","gists_url":"https://api.github.com/users/tejones/gists{/gist_id}","starred_url":"https://api.github.com/users/tejones/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tejones/subscriptions","organizations_url":"https://api.github.com/users/tejones/orgs","repos_url":"https://api.github.com/users/tejones/repos","events_url":"https://api.github.com/users/tejones/events{/privacy}","received_events_url":"https://api.github.com/users/tejones/received_events","type":"User","site_admin":false},{"login":"blafond","id":560654,"avatar_url":"https://avatars.githubusercontent.com/u/560654?v=3","gravatar_id":"","url":"https://api.github.com/users/blafond","html_url":"https://github.com/blafond","followers_url":"https://api.github.com/users/blafond/followers","following_url":"https://api.github.com/users/blafond/following{/other_user}","gists_url":"https://api.github.com/users/blafond/gists{/gist_id}","starred_url":"https://api.github.com/users/blafond/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blafond/subscriptions","organizations_url":"https://api.github.com/users/blafond/orgs","repos_url":"https://api.github.com/users/blafond/repos","events_url":"https://api.github.com/users/blafond/events{/privacy}","received_events_url":"https://api.github.com/users/blafond/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Teiid-Designer/vdb-bench/pulls/53/commits","review_comments_url":"https://api.github.com/repos/Teiid-Designer/vdb-bench/pulls/53/comments","review_comment_url":"https://api.github.com/repos/Teiid-Designer/vdb-bench/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Teiid-Designer/vdb-bench/issues/53/comments","statuses_url":"https://api.github.com/repos/Teiid-Designer/vdb-bench/statuses/71fb93e06e98243d0471982a8fe9b9ea7a15f5d4","head":{"label":"phantomjinx:master","ref":"master","sha":"71fb93e06e98243d0471982a8fe9b9ea7a15f5d4","user":{"login":"phantomjinx","id":1634180,"avatar_url":"https://avatars.githubusercontent.com/u/1634180?v=3","gravatar_id":"","url":"https://api.github.com/users/phantomjinx","html_url":"https://github.com/phantomjinx","followers_url":"https://api.github.com/users/phantomjinx/followers","following_url":"https://api.github.com/users/phantomjinx/following{/other_user}","gists_url":"https://api.github.com/users/phantomjinx/gists{/gist_id}","starred_url":"https://api.github.com/users/phantomjinx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phantomjinx/subscriptions","organizations_url":"https://api.github.com/users/phantomjinx/orgs","repos_url":"https://api.github.com/users/phantomjinx/repos","events_url":"https://api.github.com/users/phantomjinx/events{/privacy}","received_events_url":"https://api.github.com/users/phantomjinx/received_events","type":"User","site_admin":false},"repo":{"id":39897412,"name":"vdb-bench","full_name":"phantomjinx/vdb-bench","owner":{"login":"phantomjinx","id":1634180,"avatar_url":"https://avatars.githubusercontent.com/u/1634180?v=3","gravatar_id":"","url":"https://api.github.com/users/phantomjinx","html_url":"https://github.com/phantomjinx","followers_url":"https://api.github.com/users/phantomjinx/followers","following_url":"https://api.github.com/users/phantomjinx/following{/other_user}","gists_url":"https://api.github.com/users/phantomjinx/gists{/gist_id}","starred_url":"https://api.github.com/users/phantomjinx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phantomjinx/subscriptions","organizations_url":"https://api.github.com/users/phantomjinx/orgs","repos_url":"https://api.github.com/users/phantomjinx/repos","events_url":"https://api.github.com/users/phantomjinx/events{/privacy}","received_events_url":"https://api.github.com/users/phantomjinx/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/phantomjinx/vdb-bench","description":"The workbench client for working on vdbs using the komodo engine","fork":true,"url":"https://api.github.com/repos/phantomjinx/vdb-bench","forks_url":"https://api.github.com/repos/phantomjinx/vdb-bench/forks","keys_url":"https://api.github.com/repos/phantomjinx/vdb-bench/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phantomjinx/vdb-bench/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phantomjinx/vdb-bench/teams","hooks_url":"https://api.github.com/repos/phantomjinx/vdb-bench/hooks","issue_events_url":"https://api.github.com/repos/phantomjinx/vdb-bench/issues/events{/number}","events_url":"https://api.github.com/repos/phantomjinx/vdb-bench/events","assignees_url":"https://api.github.com/repos/phantomjinx/vdb-bench/assignees{/user}","branches_url":"https://api.github.com/repos/phantomjinx/vdb-bench/branches{/branch}","tags_url":"https://api.github.com/repos/phantomjinx/vdb-bench/tags","blobs_url":"https://api.github.com/repos/phantomjinx/vdb-bench/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phantomjinx/vdb-bench/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phantomjinx/vdb-bench/git/refs{/sha}","trees_url":"https://api.github.com/repos/phantomjinx/vdb-bench/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phantomjinx/vdb-bench/statuses/{sha}","languages_url":"https://api.github.com/repos/phantomjinx/vdb-bench/languages","stargazers_url":"https://api.github.com/repos/phantomjinx/vdb-bench/stargazers","contributors_url":"https://api.github.com/repos/phantomjinx/vdb-bench/contributors","subscribers_url":"https://api.github.com/repos/phantomjinx/vdb-bench/subscribers","subscription_url":"https://api.github.com/repos/phantomjinx/vdb-bench/subscription","commits_url":"https://api.github.com/repos/phantomjinx/vdb-bench/commits{/sha}","git_commits_url":"https://api.github.com/repos/phantomjinx/vdb-bench/git/commits{/sha}","comments_url":"https://api.github.com/repos/phantomjinx/vdb-bench/comments{/number}","issue_comment_url":"https://api.github.com/repos/phantomjinx/vdb-bench/issues/comments{/number}","contents_url":"https://api.github.com/repos/phantomjinx/vdb-bench/contents/{+path}","compare_url":"https://api.github.com/repos/phantomjinx/vdb-bench/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phantomjinx/vdb-bench/merges","archive_url":"https://api.github.com/repos/phantomjinx/vdb-bench/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phantomjinx/vdb-bench/downloads","issues_url":"https://api.github.com/repos/phantomjinx/vdb-bench/issues{/number}","pulls_url":"https://api.github.com/repos/phantomjinx/vdb-bench/pulls{/number}","milestones_url":"https://api.github.com/repos/phantomjinx/vdb-bench/milestones{/number}","notifications_url":"https://api.github.com/repos/phantomjinx/vdb-bench/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phantomjinx/vdb-bench/labels{/name}","releases_url":"https://api.github.com/repos/phantomjinx/vdb-bench/releases{/id}","deployments_url":"https://api.github.com/repos/phantomjinx/vdb-bench/deployments","created_at":"2015-07-29T14:18:09Z","updated_at":"2016-02-08T16:04:04Z","pushed_at":"2016-12-16T22:50:37Z","git_url":"git://github.com/phantomjinx/vdb-bench.git","ssh_url":"git@github.com:phantomjinx/vdb-bench.git","clone_url":"https://github.com/phantomjinx/vdb-bench.git","svn_url":"https://github.com/phantomjinx/vdb-bench","homepage":null,"size":1568,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Teiid-Designer:master","ref":"master","sha":"f1c9564b8a9271bfbe05e92dbf68ace7f53a25f9","user":{"login":"Teiid-Designer","id":1641911,"avatar_url":"https://avatars.githubusercontent.com/u/1641911?v=3","gravatar_id":"","url":"https://api.github.com/users/Teiid-Designer","html_url":"https://github.com/Teiid-Designer","followers_url":"https://api.github.com/users/Teiid-Designer/followers","following_url":"https://api.github.com/users/Teiid-Designer/following{/other_user}","gists_url":"https://api.github.com/users/Teiid-Designer/gists{/gist_id}","starred_url":"https://api.github.com/users/Teiid-Designer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Teiid-Designer/subscriptions","organizations_url":"https://api.github.com/users/Teiid-Designer/orgs","repos_url":"https://api.github.com/users/Teiid-Designer/repos","events_url":"https://api.github.com/users/Teiid-Designer/events{/privacy}","received_events_url":"https://api.github.com/users/Teiid-Designer/received_events","type":"Organization","site_admin":false},"repo":{"id":39570025,"name":"vdb-bench","full_name":"Teiid-Designer/vdb-bench","owner":{"login":"Teiid-Designer","id":1641911,"avatar_url":"https://avatars.githubusercontent.com/u/1641911?v=3","gravatar_id":"","url":"https://api.github.com/users/Teiid-Designer","html_url":"https://github.com/Teiid-Designer","followers_url":"https://api.github.com/users/Teiid-Designer/followers","following_url":"https://api.github.com/users/Teiid-Designer/following{/other_user}","gists_url":"https://api.github.com/users/Teiid-Designer/gists{/gist_id}","starred_url":"https://api.github.com/users/Teiid-Designer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Teiid-Designer/subscriptions","organizations_url":"https://api.github.com/users/Teiid-Designer/orgs","repos_url":"https://api.github.com/users/Teiid-Designer/repos","events_url":"https://api.github.com/users/Teiid-Designer/events{/privacy}","received_events_url":"https://api.github.com/users/Teiid-Designer/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Teiid-Designer/vdb-bench","description":"The workbench client for working on vdbs using the komodo engine","fork":false,"url":"https://api.github.com/repos/Teiid-Designer/vdb-bench","forks_url":"https://api.github.com/repos/Teiid-Designer/vdb-bench/forks","keys_url":"https://api.github.com/repos/Teiid-Designer/vdb-bench/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Teiid-Designer/vdb-bench/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Teiid-Designer/vdb-bench/teams","hooks_url":"https://api.github.com/repos/Teiid-Designer/vdb-bench/hooks","issue_events_url":"https://api.github.com/repos/Teiid-Designer/vdb-bench/issues/events{/number}","events_url":"https://api.github.com/repos/Teiid-Designer/vdb-bench/events","assignees_url":"https://api.github.com/repos/Teiid-Designer/vdb-bench/assignees{/user}","branches_url":"https://api.github.com/repos/Teiid-Designer/vdb-bench/branches{/branch}","tags_url":"https://api.github.com/repos/Teiid-Designer/vdb-bench/tags","blobs_url":"https://api.github.com/repos/Teiid-Designer/vdb-bench/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Teiid-Designer/vdb-bench/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Teiid-Designer/vdb-bench/git/refs{/sha}","trees_url":"https://api.github.com/repos/Teiid-Designer/vdb-bench/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Teiid-Designer/vdb-bench/statuses/{sha}","languages_url":"https://api.github.com/repos/Teiid-Designer/vdb-bench/languages","stargazers_url":"https://api.github.com/repos/Teiid-Designer/vdb-bench/stargazers","contributors_url":"https://api.github.com/repos/Teiid-Designer/vdb-bench/contributors","subscribers_url":"https://api.github.com/repos/Teiid-Designer/vdb-bench/subscribers","subscription_url":"https://api.github.com/repos/Teiid-Designer/vdb-bench/subscription","commits_url":"https://api.github.com/repos/Teiid-Designer/vdb-bench/commits{/sha}","git_commits_url":"https://api.github.com/repos/Teiid-Designer/vdb-bench/git/commits{/sha}","comments_url":"https://api.github.com/repos/Teiid-Designer/vdb-bench/comments{/number}","issue_comment_url":"https://api.github.com/repos/Teiid-Designer/vdb-bench/issues/comments{/number}","contents_url":"https://api.github.com/repos/Teiid-Designer/vdb-bench/contents/{+path}","compare_url":"https://api.github.com/repos/Teiid-Designer/vdb-bench/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Teiid-Designer/vdb-bench/merges","archive_url":"https://api.github.com/repos/Teiid-Designer/vdb-bench/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Teiid-Designer/vdb-bench/downloads","issues_url":"https://api.github.com/repos/Teiid-Designer/vdb-bench/issues{/number}","pulls_url":"https://api.github.com/repos/Teiid-Designer/vdb-bench/pulls{/number}","milestones_url":"https://api.github.com/repos/Teiid-Designer/vdb-bench/milestones{/number}","notifications_url":"https://api.github.com/repos/Teiid-Designer/vdb-bench/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Teiid-Designer/vdb-bench/labels{/name}","releases_url":"https://api.github.com/repos/Teiid-Designer/vdb-bench/releases{/id}","deployments_url":"https://api.github.com/repos/Teiid-Designer/vdb-bench/deployments","created_at":"2015-07-23T13:49:55Z","updated_at":"2016-12-06T14:50:41Z","pushed_at":"2016-12-19T16:00:09Z","git_url":"git://github.com/Teiid-Designer/vdb-bench.git","ssh_url":"git@github.com:Teiid-Designer/vdb-bench.git","clone_url":"https://github.com/Teiid-Designer/vdb-bench.git","svn_url":"https://github.com/Teiid-Designer/vdb-bench","homepage":null,"size":1538,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6,"mirror_url":null,"open_issues_count":0,"forks":6,"open_issues":0,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Teiid-Designer/vdb-bench/pulls/53"},"html":{"href":"https://github.com/Teiid-Designer/vdb-bench/pull/53"},"issue":{"href":"https://api.github.com/repos/Teiid-Designer/vdb-bench/issues/53"},"comments":{"href":"https://api.github.com/repos/Teiid-Designer/vdb-bench/issues/53/comments"},"review_comments":{"href":"https://api.github.com/repos/Teiid-Designer/vdb-bench/pulls/53/comments"},"review_comment":{"href":"https://api.github.com/repos/Teiid-Designer/vdb-bench/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Teiid-Designer/vdb-bench/pulls/53/commits"},"statuses":{"href":"https://api.github.com/repos/Teiid-Designer/vdb-bench/statuses/71fb93e06e98243d0471982a8fe9b9ea7a15f5d4"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"tejones","id":560417,"avatar_url":"https://avatars.githubusercontent.com/u/560417?v=3","gravatar_id":"","url":"https://api.github.com/users/tejones","html_url":"https://github.com/tejones","followers_url":"https://api.github.com/users/tejones/followers","following_url":"https://api.github.com/users/tejones/following{/other_user}","gists_url":"https://api.github.com/users/tejones/gists{/gist_id}","starred_url":"https://api.github.com/users/tejones/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tejones/subscriptions","organizations_url":"https://api.github.com/users/tejones/orgs","repos_url":"https://api.github.com/users/tejones/repos","events_url":"https://api.github.com/users/tejones/events{/privacy}","received_events_url":"https://api.github.com/users/tejones/received_events","type":"User","site_admin":false},"comments":10,"review_comments":0,"commits":1,"additions":245,"deletions":195,"changed_files":31}}
{"actor":{"display_login":"tejones"}}