{"action":"created","comment":{"url":"https://api.github.com/repos/quantopian/zipline/pulls/comments/53230565","id":53230565,"diff_hunk":"@@ -528,6 +528,16 @@ def _spot_col(self, colname):\n     def get_last_traded_dt(self, asset, day):\n         volumes = self._spot_col('volume')\n         search_day = day\n+\n+        if search_day >= asset.end_date:\n+            # move to the last day before the asset end date\n+            try:\n+                search_day = self._calendar[\n+                    self._calendar.get_loc(asset.end_date) - 1","path":"zipline/data/us_equity_pricing.py","position":9,"original_position":9,"commit_id":"6017fe564bbf5b84282f6c416b6236d30ba7b6e4","original_commit_id":"4fbc1ef979f01468fe47d37a21d3f7c2a4f3a638","user":{"login":"jbredeche","id":487622,"avatar_url":"https://avatars.githubusercontent.com/u/487622?v=3","gravatar_id":"","url":"https://api.github.com/users/jbredeche","html_url":"https://github.com/jbredeche","followers_url":"https://api.github.com/users/jbredeche/followers","following_url":"https://api.github.com/users/jbredeche/following{/other_user}","gists_url":"https://api.github.com/users/jbredeche/gists{/gist_id}","starred_url":"https://api.github.com/users/jbredeche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbredeche/subscriptions","organizations_url":"https://api.github.com/users/jbredeche/orgs","repos_url":"https://api.github.com/users/jbredeche/repos","events_url":"https://api.github.com/users/jbredeche/events{/privacy}","received_events_url":"https://api.github.com/users/jbredeche/received_events","type":"User","site_admin":false},"body":"I rewrote that chunk of code, agreed with @ssanderson that the try/except was too broad.  Now, we simply go back to the last trading day before the asset end date, if needed.\r\n\r\n```\r\n        if day >= asset.end_date:\r\n            # go back to one day before the asset ended\r\n            search_day = self._calendar[\r\n                self._calendar.get_loc(asset.end_date) - 1\r\n            ]\r\n        else:\r\n            search_day = day\r\n```","created_at":"2016-02-17T21:00:48Z","updated_at":"2016-02-17T21:00:48Z","html_url":"https://github.com/quantopian/zipline/pull/1000#discussion_r53230565","pull_request_url":"https://api.github.com/repos/quantopian/zipline/pulls/1000","_links":{"self":{"href":"https://api.github.com/repos/quantopian/zipline/pulls/comments/53230565"},"html":{"href":"https://github.com/quantopian/zipline/pull/1000#discussion_r53230565"},"pull_request":{"href":"https://api.github.com/repos/quantopian/zipline/pulls/1000"}}},"pull_request":{"url":"https://api.github.com/repos/quantopian/zipline/pulls/1000","id":59586616,"html_url":"https://github.com/quantopian/zipline/pull/1000","diff_url":"https://github.com/quantopian/zipline/pull/1000.diff","patch_url":"https://github.com/quantopian/zipline/pull/1000.patch","issue_url":"https://api.github.com/repos/quantopian/zipline/issues/1000","number":1000,"state":"open","locked":false,"title":"Introduces new API for accessing price data:","user":{"login":"jbredeche","id":487622,"avatar_url":"https://avatars.githubusercontent.com/u/487622?v=3","gravatar_id":"","url":"https://api.github.com/users/jbredeche","html_url":"https://github.com/jbredeche","followers_url":"https://api.github.com/users/jbredeche/followers","following_url":"https://api.github.com/users/jbredeche/following{/other_user}","gists_url":"https://api.github.com/users/jbredeche/gists{/gist_id}","starred_url":"https://api.github.com/users/jbredeche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbredeche/subscriptions","organizations_url":"https://api.github.com/users/jbredeche/orgs","repos_url":"https://api.github.com/users/jbredeche/repos","events_url":"https://api.github.com/users/jbredeche/events{/privacy}","received_events_url":"https://api.github.com/users/jbredeche/received_events","type":"User","site_admin":false},"body":"data.get_spot_value\r\ndata.can_trade\r\ndata.is_stale\r\ndata.history","created_at":"2016-02-17T02:12:12Z","updated_at":"2016-02-17T21:00:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7d4d39bfd5af4c9a6badda2daf75292e29b44b6c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/quantopian/zipline/pulls/1000/commits","review_comments_url":"https://api.github.com/repos/quantopian/zipline/pulls/1000/comments","review_comment_url":"https://api.github.com/repos/quantopian/zipline/pulls/comments{/number}","comments_url":"https://api.github.com/repos/quantopian/zipline/issues/1000/comments","statuses_url":"https://api.github.com/repos/quantopian/zipline/statuses/6017fe564bbf5b84282f6c416b6236d30ba7b6e4","head":{"label":"quantopian:new-data-api","ref":"new-data-api","sha":"6017fe564bbf5b84282f6c416b6236d30ba7b6e4","user":{"login":"quantopian","id":1393215,"avatar_url":"https://avatars.githubusercontent.com/u/1393215?v=3","gravatar_id":"","url":"https://api.github.com/users/quantopian","html_url":"https://github.com/quantopian","followers_url":"https://api.github.com/users/quantopian/followers","following_url":"https://api.github.com/users/quantopian/following{/other_user}","gists_url":"https://api.github.com/users/quantopian/gists{/gist_id}","starred_url":"https://api.github.com/users/quantopian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quantopian/subscriptions","organizations_url":"https://api.github.com/users/quantopian/orgs","repos_url":"https://api.github.com/users/quantopian/repos","events_url":"https://api.github.com/users/quantopian/events{/privacy}","received_events_url":"https://api.github.com/users/quantopian/received_events","type":"Organization","site_admin":false},"repo":{"id":6297520,"name":"zipline","full_name":"quantopian/zipline","owner":{"login":"quantopian","id":1393215,"avatar_url":"https://avatars.githubusercontent.com/u/1393215?v=3","gravatar_id":"","url":"https://api.github.com/users/quantopian","html_url":"https://github.com/quantopian","followers_url":"https://api.github.com/users/quantopian/followers","following_url":"https://api.github.com/users/quantopian/following{/other_user}","gists_url":"https://api.github.com/users/quantopian/gists{/gist_id}","starred_url":"https://api.github.com/users/quantopian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quantopian/subscriptions","organizations_url":"https://api.github.com/users/quantopian/orgs","repos_url":"https://api.github.com/users/quantopian/repos","events_url":"https://api.github.com/users/quantopian/events{/privacy}","received_events_url":"https://api.github.com/users/quantopian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/quantopian/zipline","description":"Zipline, a Pythonic Algorithmic Trading Library","fork":false,"url":"https://api.github.com/repos/quantopian/zipline","forks_url":"https://api.github.com/repos/quantopian/zipline/forks","keys_url":"https://api.github.com/repos/quantopian/zipline/keys{/key_id}","collaborators_url":"https://api.github.com/repos/quantopian/zipline/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/quantopian/zipline/teams","hooks_url":"https://api.github.com/repos/quantopian/zipline/hooks","issue_events_url":"https://api.github.com/repos/quantopian/zipline/issues/events{/number}","events_url":"https://api.github.com/repos/quantopian/zipline/events","assignees_url":"https://api.github.com/repos/quantopian/zipline/assignees{/user}","branches_url":"https://api.github.com/repos/quantopian/zipline/branches{/branch}","tags_url":"https://api.github.com/repos/quantopian/zipline/tags","blobs_url":"https://api.github.com/repos/quantopian/zipline/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/quantopian/zipline/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/quantopian/zipline/git/refs{/sha}","trees_url":"https://api.github.com/repos/quantopian/zipline/git/trees{/sha}","statuses_url":"https://api.github.com/repos/quantopian/zipline/statuses/{sha}","languages_url":"https://api.github.com/repos/quantopian/zipline/languages","stargazers_url":"https://api.github.com/repos/quantopian/zipline/stargazers","contributors_url":"https://api.github.com/repos/quantopian/zipline/contributors","subscribers_url":"https://api.github.com/repos/quantopian/zipline/subscribers","subscription_url":"https://api.github.com/repos/quantopian/zipline/subscription","commits_url":"https://api.github.com/repos/quantopian/zipline/commits{/sha}","git_commits_url":"https://api.github.com/repos/quantopian/zipline/git/commits{/sha}","comments_url":"https://api.github.com/repos/quantopian/zipline/comments{/number}","issue_comment_url":"https://api.github.com/repos/quantopian/zipline/issues/comments{/number}","contents_url":"https://api.github.com/repos/quantopian/zipline/contents/{+path}","compare_url":"https://api.github.com/repos/quantopian/zipline/compare/{base}...{head}","merges_url":"https://api.github.com/repos/quantopian/zipline/merges","archive_url":"https://api.github.com/repos/quantopian/zipline/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/quantopian/zipline/downloads","issues_url":"https://api.github.com/repos/quantopian/zipline/issues{/number}","pulls_url":"https://api.github.com/repos/quantopian/zipline/pulls{/number}","milestones_url":"https://api.github.com/repos/quantopian/zipline/milestones{/number}","notifications_url":"https://api.github.com/repos/quantopian/zipline/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/quantopian/zipline/labels{/name}","releases_url":"https://api.github.com/repos/quantopian/zipline/releases{/id}","deployments_url":"https://api.github.com/repos/quantopian/zipline/deployments","created_at":"2012-10-19T15:50:29Z","updated_at":"2016-02-17T17:28:00Z","pushed_at":"2016-02-17T19:30:23Z","git_url":"git://github.com/quantopian/zipline.git","ssh_url":"git@github.com:quantopian/zipline.git","clone_url":"https://github.com/quantopian/zipline.git","svn_url":"https://github.com/quantopian/zipline","homepage":"","size":15198,"stargazers_count":2903,"watchers_count":2903,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":843,"mirror_url":null,"open_issues_count":158,"forks":843,"open_issues":158,"watchers":2903,"default_branch":"master"}},"base":{"label":"quantopian:lazy-mainline","ref":"lazy-mainline","sha":"2da28f8408cba8429606bcbf67989d6df22e4310","user":{"login":"quantopian","id":1393215,"avatar_url":"https://avatars.githubusercontent.com/u/1393215?v=3","gravatar_id":"","url":"https://api.github.com/users/quantopian","html_url":"https://github.com/quantopian","followers_url":"https://api.github.com/users/quantopian/followers","following_url":"https://api.github.com/users/quantopian/following{/other_user}","gists_url":"https://api.github.com/users/quantopian/gists{/gist_id}","starred_url":"https://api.github.com/users/quantopian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quantopian/subscriptions","organizations_url":"https://api.github.com/users/quantopian/orgs","repos_url":"https://api.github.com/users/quantopian/repos","events_url":"https://api.github.com/users/quantopian/events{/privacy}","received_events_url":"https://api.github.com/users/quantopian/received_events","type":"Organization","site_admin":false},"repo":{"id":6297520,"name":"zipline","full_name":"quantopian/zipline","owner":{"login":"quantopian","id":1393215,"avatar_url":"https://avatars.githubusercontent.com/u/1393215?v=3","gravatar_id":"","url":"https://api.github.com/users/quantopian","html_url":"https://github.com/quantopian","followers_url":"https://api.github.com/users/quantopian/followers","following_url":"https://api.github.com/users/quantopian/following{/other_user}","gists_url":"https://api.github.com/users/quantopian/gists{/gist_id}","starred_url":"https://api.github.com/users/quantopian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quantopian/subscriptions","organizations_url":"https://api.github.com/users/quantopian/orgs","repos_url":"https://api.github.com/users/quantopian/repos","events_url":"https://api.github.com/users/quantopian/events{/privacy}","received_events_url":"https://api.github.com/users/quantopian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/quantopian/zipline","description":"Zipline, a Pythonic Algorithmic Trading Library","fork":false,"url":"https://api.github.com/repos/quantopian/zipline","forks_url":"https://api.github.com/repos/quantopian/zipline/forks","keys_url":"https://api.github.com/repos/quantopian/zipline/keys{/key_id}","collaborators_url":"https://api.github.com/repos/quantopian/zipline/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/quantopian/zipline/teams","hooks_url":"https://api.github.com/repos/quantopian/zipline/hooks","issue_events_url":"https://api.github.com/repos/quantopian/zipline/issues/events{/number}","events_url":"https://api.github.com/repos/quantopian/zipline/events","assignees_url":"https://api.github.com/repos/quantopian/zipline/assignees{/user}","branches_url":"https://api.github.com/repos/quantopian/zipline/branches{/branch}","tags_url":"https://api.github.com/repos/quantopian/zipline/tags","blobs_url":"https://api.github.com/repos/quantopian/zipline/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/quantopian/zipline/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/quantopian/zipline/git/refs{/sha}","trees_url":"https://api.github.com/repos/quantopian/zipline/git/trees{/sha}","statuses_url":"https://api.github.com/repos/quantopian/zipline/statuses/{sha}","languages_url":"https://api.github.com/repos/quantopian/zipline/languages","stargazers_url":"https://api.github.com/repos/quantopian/zipline/stargazers","contributors_url":"https://api.github.com/repos/quantopian/zipline/contributors","subscribers_url":"https://api.github.com/repos/quantopian/zipline/subscribers","subscription_url":"https://api.github.com/repos/quantopian/zipline/subscription","commits_url":"https://api.github.com/repos/quantopian/zipline/commits{/sha}","git_commits_url":"https://api.github.com/repos/quantopian/zipline/git/commits{/sha}","comments_url":"https://api.github.com/repos/quantopian/zipline/comments{/number}","issue_comment_url":"https://api.github.com/repos/quantopian/zipline/issues/comments{/number}","contents_url":"https://api.github.com/repos/quantopian/zipline/contents/{+path}","compare_url":"https://api.github.com/repos/quantopian/zipline/compare/{base}...{head}","merges_url":"https://api.github.com/repos/quantopian/zipline/merges","archive_url":"https://api.github.com/repos/quantopian/zipline/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/quantopian/zipline/downloads","issues_url":"https://api.github.com/repos/quantopian/zipline/issues{/number}","pulls_url":"https://api.github.com/repos/quantopian/zipline/pulls{/number}","milestones_url":"https://api.github.com/repos/quantopian/zipline/milestones{/number}","notifications_url":"https://api.github.com/repos/quantopian/zipline/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/quantopian/zipline/labels{/name}","releases_url":"https://api.github.com/repos/quantopian/zipline/releases{/id}","deployments_url":"https://api.github.com/repos/quantopian/zipline/deployments","created_at":"2012-10-19T15:50:29Z","updated_at":"2016-02-17T17:28:00Z","pushed_at":"2016-02-17T19:30:23Z","git_url":"git://github.com/quantopian/zipline.git","ssh_url":"git@github.com:quantopian/zipline.git","clone_url":"https://github.com/quantopian/zipline.git","svn_url":"https://github.com/quantopian/zipline","homepage":"","size":15198,"stargazers_count":2903,"watchers_count":2903,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":843,"mirror_url":null,"open_issues_count":158,"forks":843,"open_issues":158,"watchers":2903,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/quantopian/zipline/pulls/1000"},"html":{"href":"https://github.com/quantopian/zipline/pull/1000"},"issue":{"href":"https://api.github.com/repos/quantopian/zipline/issues/1000"},"comments":{"href":"https://api.github.com/repos/quantopian/zipline/issues/1000/comments"},"review_comments":{"href":"https://api.github.com/repos/quantopian/zipline/pulls/1000/comments"},"review_comment":{"href":"https://api.github.com/repos/quantopian/zipline/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/quantopian/zipline/pulls/1000/commits"},"statuses":{"href":"https://api.github.com/repos/quantopian/zipline/statuses/6017fe564bbf5b84282f6c416b6236d30ba7b6e4"}}}}