{"action":"created","issue":{"url":"https://api.github.com/repos/wesnoth/wesnoth/issues/644","repository_url":"https://api.github.com/repos/wesnoth/wesnoth","labels_url":"https://api.github.com/repos/wesnoth/wesnoth/issues/644/labels{/name}","comments_url":"https://api.github.com/repos/wesnoth/wesnoth/issues/644/comments","events_url":"https://api.github.com/repos/wesnoth/wesnoth/issues/644/events","html_url":"https://github.com/wesnoth/wesnoth/pull/644","id":146466296,"number":644,"title":"Unit name generator using context-free grammar","user":{"login":"Dugy","id":7074334,"avatar_url":"https://avatars.githubusercontent.com/u/7074334?v=3","gravatar_id":"","url":"https://api.github.com/users/Dugy","html_url":"https://github.com/Dugy","followers_url":"https://api.github.com/users/Dugy/followers","following_url":"https://api.github.com/users/Dugy/following{/other_user}","gists_url":"https://api.github.com/users/Dugy/gists{/gist_id}","starred_url":"https://api.github.com/users/Dugy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dugy/subscriptions","organizations_url":"https://api.github.com/users/Dugy/orgs","repos_url":"https://api.github.com/users/Dugy/repos","events_url":"https://api.github.com/users/Dugy/events{/privacy}","received_events_url":"https://api.github.com/users/Dugy/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":10,"created_at":"2016-04-06T23:35:28Z","updated_at":"2016-04-07T14:36:21Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/wesnoth/wesnoth/pulls/644","html_url":"https://github.com/wesnoth/wesnoth/pull/644","diff_url":"https://github.com/wesnoth/wesnoth/pull/644.diff","patch_url":"https://github.com/wesnoth/wesnoth/pull/644.patch"},"body":"Added a new way to generate unit names, using rules of a context-free grammar. It is much more configurable than the current system, so it's possible to prevent extremely long or otherwise funny and awkward names. If it can't find its entries in the race definition, it falls back to the old Markov chains."},"comment":{"url":"https://api.github.com/repos/wesnoth/wesnoth/issues/comments/206934310","html_url":"https://github.com/wesnoth/wesnoth/pull/644#issuecomment-206934310","issue_url":"https://api.github.com/repos/wesnoth/wesnoth/issues/644","id":206934310,"user":{"login":"CelticMinstrel","id":578731,"avatar_url":"https://avatars.githubusercontent.com/u/578731?v=3","gravatar_id":"","url":"https://api.github.com/users/CelticMinstrel","html_url":"https://github.com/CelticMinstrel","followers_url":"https://api.github.com/users/CelticMinstrel/followers","following_url":"https://api.github.com/users/CelticMinstrel/following{/other_user}","gists_url":"https://api.github.com/users/CelticMinstrel/gists{/gist_id}","starred_url":"https://api.github.com/users/CelticMinstrel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CelticMinstrel/subscriptions","organizations_url":"https://api.github.com/users/CelticMinstrel/orgs","repos_url":"https://api.github.com/users/CelticMinstrel/repos","events_url":"https://api.github.com/users/CelticMinstrel/events{/privacy}","received_events_url":"https://api.github.com/users/CelticMinstrel/received_events","type":"User","site_admin":false},"created_at":"2016-04-07T14:36:21Z","updated_at":"2016-04-07T14:36:21Z","body":"Well, formulas (like FormulaAI or formula= in SUF) are usually enclosed in quotes, not angled brackets, so not all non-WML source code appears in angled brackets. I guess it's okay if it stays this way; using a different char is just my personal preference.\r\n\r\nI don't personally see a problem with requiring preprocessor checks for addons used in both versions, but your argument about the implication of the \"male_names\" key does make sense... though it kinda applie to the Markov generator too to a lesser extent (it's a list of names, but isn't used like a simple list)."}}