{"action":"created","issue":{"url":"https://api.github.com/repos/craffel/mir_eval/issues/207","repository_url":"https://api.github.com/repos/craffel/mir_eval","labels_url":"https://api.github.com/repos/craffel/mir_eval/issues/207/labels{/name}","comments_url":"https://api.github.com/repos/craffel/mir_eval/issues/207/comments","events_url":"https://api.github.com/repos/craffel/mir_eval/issues/207/events","html_url":"https://github.com/craffel/mir_eval/pull/207","id":164107332,"number":207,"title":"Bss eval images","user":{"login":"ErikJohnsonCU","id":6766142,"avatar_url":"https://avatars.githubusercontent.com/u/6766142?v=3","gravatar_id":"","url":"https://api.github.com/users/ErikJohnsonCU","html_url":"https://github.com/ErikJohnsonCU","followers_url":"https://api.github.com/users/ErikJohnsonCU/followers","following_url":"https://api.github.com/users/ErikJohnsonCU/following{/other_user}","gists_url":"https://api.github.com/users/ErikJohnsonCU/gists{/gist_id}","starred_url":"https://api.github.com/users/ErikJohnsonCU/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ErikJohnsonCU/subscriptions","organizations_url":"https://api.github.com/users/ErikJohnsonCU/orgs","repos_url":"https://api.github.com/users/ErikJohnsonCU/repos","events_url":"https://api.github.com/users/ErikJohnsonCU/events{/privacy}","received_events_url":"https://api.github.com/users/ErikJohnsonCU/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":18,"created_at":"2016-07-06T15:41:41Z","updated_at":"2016-07-20T07:29:12Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/craffel/mir_eval/pulls/207","html_url":"https://github.com/craffel/mir_eval/pull/207","diff_url":"https://github.com/craffel/mir_eval/pull/207.diff","patch_url":"https://github.com/craffel/mir_eval/pull/207.patch"},"body":"## Images Separation Evaluation\r\n\r\nA function has been added in `separation.py` (`bss_eval_images`) that allows for image separation evaluation as discussed in #68. This implementation is identical to that of the `BSS_eval` MATLAB implementation.\r\n\r\n## Implementation Testing\r\n\r\nIn order to validate the consistency of `bss_eval_images` with that of the MATLAB implementation, comparison testing has been performed. This comparison testing is available for anyone wishing to test it [here](https://github.com/ErikJohnsonCU/mir_eval_images_compare) (please let me know if there are any issues installing/running it!).\r\n\r\n## Regression Testing\r\n\r\nA suite of tests have been added to `test_separation.py` for regression testing. These tests follow the same style as for `bss_eval_sources` and `bss_eval_sources_framewise` and the `output0*.json` files have been updated accordingly. Generation of dual channel audio is done by expanding both references and estimates to the correct number of channels and then manipulating the estimates in order to generate non-identical channels (see the `__generate_multichannel` function in `test_separation.py`).\r\n\r\n**All feedback is welcome!**"},"comment":{"url":"https://api.github.com/repos/craffel/mir_eval/issues/comments/233864928","html_url":"https://github.com/craffel/mir_eval/pull/207#issuecomment-233864928","issue_url":"https://api.github.com/repos/craffel/mir_eval/issues/207","id":233864928,"user":{"login":"ErikJohnsonCU","id":6766142,"avatar_url":"https://avatars.githubusercontent.com/u/6766142?v=3","gravatar_id":"","url":"https://api.github.com/users/ErikJohnsonCU","html_url":"https://github.com/ErikJohnsonCU","followers_url":"https://api.github.com/users/ErikJohnsonCU/followers","following_url":"https://api.github.com/users/ErikJohnsonCU/following{/other_user}","gists_url":"https://api.github.com/users/ErikJohnsonCU/gists{/gist_id}","starred_url":"https://api.github.com/users/ErikJohnsonCU/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ErikJohnsonCU/subscriptions","organizations_url":"https://api.github.com/users/ErikJohnsonCU/orgs","repos_url":"https://api.github.com/users/ErikJohnsonCU/repos","events_url":"https://api.github.com/users/ErikJohnsonCU/events{/privacy}","received_events_url":"https://api.github.com/users/ErikJohnsonCU/received_events","type":"User","site_admin":false},"created_at":"2016-07-20T07:29:11Z","updated_at":"2016-07-20T07:29:11Z","body":"Yep, ready for code review!"}}
{"actor":{"display_login":"ErikJohnsonCU"}}