{"action":"closed","number":131,"pull_request":{"url":"https://api.github.com/repos/exebetche/vlsub/pulls/131","id":76827265,"html_url":"https://github.com/exebetche/vlsub/pull/131","diff_url":"https://github.com/exebetche/vlsub/pull/131.diff","patch_url":"https://github.com/exebetche/vlsub/pull/131.patch","issue_url":"https://api.github.com/repos/exebetche/vlsub/issues/131","number":131,"state":"closed","locked":false,"title":"fixes exebetche/vlc#71 and fixes exebetche/vlc#121","user":{"login":"Aigrefin","id":8188216,"avatar_url":"https://avatars.githubusercontent.com/u/8188216?v=3","gravatar_id":"","url":"https://api.github.com/users/Aigrefin","html_url":"https://github.com/Aigrefin","followers_url":"https://api.github.com/users/Aigrefin/followers","following_url":"https://api.github.com/users/Aigrefin/following{/other_user}","gists_url":"https://api.github.com/users/Aigrefin/gists{/gist_id}","starred_url":"https://api.github.com/users/Aigrefin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Aigrefin/subscriptions","organizations_url":"https://api.github.com/users/Aigrefin/orgs","repos_url":"https://api.github.com/users/Aigrefin/repos","events_url":"https://api.github.com/users/Aigrefin/events{/privacy}","received_events_url":"https://api.github.com/users/Aigrefin/received_events","type":"User","site_admin":false},"body":"I don't know the implementation of vlc, but from what I observed :\r\n- when you use the extension menu and extension has never been opened, it opens the extension\r\n- when you use the extension menu and extension is currently opened, it closes the extension\r\n\r\nAccording to the logs :\r\n- when you close the extension with the extension menu, a signal like this one is sent : Extension thread end: 'VLsub 0.9.13'\r\n- when you close the extension with the default close button (top of the window), a signal like this one is sent : Extension thread end: 'VLsub 0.9.13'\r\n- when you close the extension with the custom \"close\" button at the bottom, no signal is sent\r\n\r\nTherefore, the bug happens as follow :\r\n- when you use the extension menu and extension has never been opened, it opens the extension\r\n- when you close the extension with the custom \"close\" button at the bottom, no signal is sent\r\n- when you use the extension menu and extension is currently opened, it closes the extension --> instead of opening it like the user wants to, because the signal wasn't sent when we clicked on the \"close\" button\r\n\r\nNote that the close function triggers this signal, and the deactivate function doesn't.\r\n\r\nTo fix this bug, the close button is now bound to the vlc global close function instead of the vlc global deactivate function.","created_at":"2016-07-08T23:15:30Z","updated_at":"2016-07-09T17:24:51Z","closed_at":"2016-07-09T17:24:51Z","merged_at":null,"merge_commit_sha":"b35d5ba10a284aadcf3582f9a39878940fa64f37","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/exebetche/vlsub/pulls/131/commits","review_comments_url":"https://api.github.com/repos/exebetche/vlsub/pulls/131/comments","review_comment_url":"https://api.github.com/repos/exebetche/vlsub/pulls/comments{/number}","comments_url":"https://api.github.com/repos/exebetche/vlsub/issues/131/comments","statuses_url":"https://api.github.com/repos/exebetche/vlsub/statuses/c9ec5141be3de4a8fa47db1b344bc5f40b12a3ed","head":{"label":"Aigrefin:patch-2","ref":"patch-2","sha":"c9ec5141be3de4a8fa47db1b344bc5f40b12a3ed","user":{"login":"Aigrefin","id":8188216,"avatar_url":"https://avatars.githubusercontent.com/u/8188216?v=3","gravatar_id":"","url":"https://api.github.com/users/Aigrefin","html_url":"https://github.com/Aigrefin","followers_url":"https://api.github.com/users/Aigrefin/followers","following_url":"https://api.github.com/users/Aigrefin/following{/other_user}","gists_url":"https://api.github.com/users/Aigrefin/gists{/gist_id}","starred_url":"https://api.github.com/users/Aigrefin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Aigrefin/subscriptions","organizations_url":"https://api.github.com/users/Aigrefin/orgs","repos_url":"https://api.github.com/users/Aigrefin/repos","events_url":"https://api.github.com/users/Aigrefin/events{/privacy}","received_events_url":"https://api.github.com/users/Aigrefin/received_events","type":"User","site_admin":false},"repo":{"id":62899053,"name":"vlsub","full_name":"Aigrefin/vlsub","owner":{"login":"Aigrefin","id":8188216,"avatar_url":"https://avatars.githubusercontent.com/u/8188216?v=3","gravatar_id":"","url":"https://api.github.com/users/Aigrefin","html_url":"https://github.com/Aigrefin","followers_url":"https://api.github.com/users/Aigrefin/followers","following_url":"https://api.github.com/users/Aigrefin/following{/other_user}","gists_url":"https://api.github.com/users/Aigrefin/gists{/gist_id}","starred_url":"https://api.github.com/users/Aigrefin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Aigrefin/subscriptions","organizations_url":"https://api.github.com/users/Aigrefin/orgs","repos_url":"https://api.github.com/users/Aigrefin/repos","events_url":"https://api.github.com/users/Aigrefin/events{/privacy}","received_events_url":"https://api.github.com/users/Aigrefin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Aigrefin/vlsub","description":"VLC extension to download subtitles from opensubtitles.org","fork":true,"url":"https://api.github.com/repos/Aigrefin/vlsub","forks_url":"https://api.github.com/repos/Aigrefin/vlsub/forks","keys_url":"https://api.github.com/repos/Aigrefin/vlsub/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Aigrefin/vlsub/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Aigrefin/vlsub/teams","hooks_url":"https://api.github.com/repos/Aigrefin/vlsub/hooks","issue_events_url":"https://api.github.com/repos/Aigrefin/vlsub/issues/events{/number}","events_url":"https://api.github.com/repos/Aigrefin/vlsub/events","assignees_url":"https://api.github.com/repos/Aigrefin/vlsub/assignees{/user}","branches_url":"https://api.github.com/repos/Aigrefin/vlsub/branches{/branch}","tags_url":"https://api.github.com/repos/Aigrefin/vlsub/tags","blobs_url":"https://api.github.com/repos/Aigrefin/vlsub/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Aigrefin/vlsub/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Aigrefin/vlsub/git/refs{/sha}","trees_url":"https://api.github.com/repos/Aigrefin/vlsub/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Aigrefin/vlsub/statuses/{sha}","languages_url":"https://api.github.com/repos/Aigrefin/vlsub/languages","stargazers_url":"https://api.github.com/repos/Aigrefin/vlsub/stargazers","contributors_url":"https://api.github.com/repos/Aigrefin/vlsub/contributors","subscribers_url":"https://api.github.com/repos/Aigrefin/vlsub/subscribers","subscription_url":"https://api.github.com/repos/Aigrefin/vlsub/subscription","commits_url":"https://api.github.com/repos/Aigrefin/vlsub/commits{/sha}","git_commits_url":"https://api.github.com/repos/Aigrefin/vlsub/git/commits{/sha}","comments_url":"https://api.github.com/repos/Aigrefin/vlsub/comments{/number}","issue_comment_url":"https://api.github.com/repos/Aigrefin/vlsub/issues/comments{/number}","contents_url":"https://api.github.com/repos/Aigrefin/vlsub/contents/{+path}","compare_url":"https://api.github.com/repos/Aigrefin/vlsub/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Aigrefin/vlsub/merges","archive_url":"https://api.github.com/repos/Aigrefin/vlsub/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Aigrefin/vlsub/downloads","issues_url":"https://api.github.com/repos/Aigrefin/vlsub/issues{/number}","pulls_url":"https://api.github.com/repos/Aigrefin/vlsub/pulls{/number}","milestones_url":"https://api.github.com/repos/Aigrefin/vlsub/milestones{/number}","notifications_url":"https://api.github.com/repos/Aigrefin/vlsub/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Aigrefin/vlsub/labels{/name}","releases_url":"https://api.github.com/repos/Aigrefin/vlsub/releases{/id}","deployments_url":"https://api.github.com/repos/Aigrefin/vlsub/deployments","created_at":"2016-07-08T15:35:36Z","updated_at":"2016-07-08T15:35:37Z","pushed_at":"2016-07-09T13:57:20Z","git_url":"git://github.com/Aigrefin/vlsub.git","ssh_url":"git@github.com:Aigrefin/vlsub.git","clone_url":"https://github.com/Aigrefin/vlsub.git","svn_url":"https://github.com/Aigrefin/vlsub","homepage":"","size":248,"stargazers_count":0,"watchers_count":0,"language":"Lua","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"exebetche:master","ref":"master","sha":"0869d1ee80ccfcb3dc9ec8df6374ba2a77138021","user":{"login":"exebetche","id":1370539,"avatar_url":"https://avatars.githubusercontent.com/u/1370539?v=3","gravatar_id":"","url":"https://api.github.com/users/exebetche","html_url":"https://github.com/exebetche","followers_url":"https://api.github.com/users/exebetche/followers","following_url":"https://api.github.com/users/exebetche/following{/other_user}","gists_url":"https://api.github.com/users/exebetche/gists{/gist_id}","starred_url":"https://api.github.com/users/exebetche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exebetche/subscriptions","organizations_url":"https://api.github.com/users/exebetche/orgs","repos_url":"https://api.github.com/users/exebetche/repos","events_url":"https://api.github.com/users/exebetche/events{/privacy}","received_events_url":"https://api.github.com/users/exebetche/received_events","type":"User","site_admin":false},"repo":{"id":3245755,"name":"vlsub","full_name":"exebetche/vlsub","owner":{"login":"exebetche","id":1370539,"avatar_url":"https://avatars.githubusercontent.com/u/1370539?v=3","gravatar_id":"","url":"https://api.github.com/users/exebetche","html_url":"https://github.com/exebetche","followers_url":"https://api.github.com/users/exebetche/followers","following_url":"https://api.github.com/users/exebetche/following{/other_user}","gists_url":"https://api.github.com/users/exebetche/gists{/gist_id}","starred_url":"https://api.github.com/users/exebetche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exebetche/subscriptions","organizations_url":"https://api.github.com/users/exebetche/orgs","repos_url":"https://api.github.com/users/exebetche/repos","events_url":"https://api.github.com/users/exebetche/events{/privacy}","received_events_url":"https://api.github.com/users/exebetche/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/exebetche/vlsub","description":"VLC extension to download subtitles from opensubtitles.org","fork":false,"url":"https://api.github.com/repos/exebetche/vlsub","forks_url":"https://api.github.com/repos/exebetche/vlsub/forks","keys_url":"https://api.github.com/repos/exebetche/vlsub/keys{/key_id}","collaborators_url":"https://api.github.com/repos/exebetche/vlsub/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/exebetche/vlsub/teams","hooks_url":"https://api.github.com/repos/exebetche/vlsub/hooks","issue_events_url":"https://api.github.com/repos/exebetche/vlsub/issues/events{/number}","events_url":"https://api.github.com/repos/exebetche/vlsub/events","assignees_url":"https://api.github.com/repos/exebetche/vlsub/assignees{/user}","branches_url":"https://api.github.com/repos/exebetche/vlsub/branches{/branch}","tags_url":"https://api.github.com/repos/exebetche/vlsub/tags","blobs_url":"https://api.github.com/repos/exebetche/vlsub/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/exebetche/vlsub/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/exebetche/vlsub/git/refs{/sha}","trees_url":"https://api.github.com/repos/exebetche/vlsub/git/trees{/sha}","statuses_url":"https://api.github.com/repos/exebetche/vlsub/statuses/{sha}","languages_url":"https://api.github.com/repos/exebetche/vlsub/languages","stargazers_url":"https://api.github.com/repos/exebetche/vlsub/stargazers","contributors_url":"https://api.github.com/repos/exebetche/vlsub/contributors","subscribers_url":"https://api.github.com/repos/exebetche/vlsub/subscribers","subscription_url":"https://api.github.com/repos/exebetche/vlsub/subscription","commits_url":"https://api.github.com/repos/exebetche/vlsub/commits{/sha}","git_commits_url":"https://api.github.com/repos/exebetche/vlsub/git/commits{/sha}","comments_url":"https://api.github.com/repos/exebetche/vlsub/comments{/number}","issue_comment_url":"https://api.github.com/repos/exebetche/vlsub/issues/comments{/number}","contents_url":"https://api.github.com/repos/exebetche/vlsub/contents/{+path}","compare_url":"https://api.github.com/repos/exebetche/vlsub/compare/{base}...{head}","merges_url":"https://api.github.com/repos/exebetche/vlsub/merges","archive_url":"https://api.github.com/repos/exebetche/vlsub/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/exebetche/vlsub/downloads","issues_url":"https://api.github.com/repos/exebetche/vlsub/issues{/number}","pulls_url":"https://api.github.com/repos/exebetche/vlsub/pulls{/number}","milestones_url":"https://api.github.com/repos/exebetche/vlsub/milestones{/number}","notifications_url":"https://api.github.com/repos/exebetche/vlsub/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/exebetche/vlsub/labels{/name}","releases_url":"https://api.github.com/repos/exebetche/vlsub/releases{/id}","deployments_url":"https://api.github.com/repos/exebetche/vlsub/deployments","created_at":"2012-01-23T10:36:11Z","updated_at":"2016-07-07T23:09:33Z","pushed_at":"2016-07-09T17:23:26Z","git_url":"git://github.com/exebetche/vlsub.git","ssh_url":"git@github.com:exebetche/vlsub.git","clone_url":"https://github.com/exebetche/vlsub.git","svn_url":"https://github.com/exebetche/vlsub","homepage":"","size":476,"stargazers_count":606,"watchers_count":606,"language":"Lua","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":182,"mirror_url":null,"open_issues_count":33,"forks":182,"open_issues":33,"watchers":606,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/exebetche/vlsub/pulls/131"},"html":{"href":"https://github.com/exebetche/vlsub/pull/131"},"issue":{"href":"https://api.github.com/repos/exebetche/vlsub/issues/131"},"comments":{"href":"https://api.github.com/repos/exebetche/vlsub/issues/131/comments"},"review_comments":{"href":"https://api.github.com/repos/exebetche/vlsub/pulls/131/comments"},"review_comment":{"href":"https://api.github.com/repos/exebetche/vlsub/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/exebetche/vlsub/pulls/131/commits"},"statuses":{"href":"https://api.github.com/repos/exebetche/vlsub/statuses/c9ec5141be3de4a8fa47db1b344bc5f40b12a3ed"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"exebetche"}}