{"action":"created","comment":{"url":"https://api.github.com/repos/CanalTP/navitia/pulls/comments/53932948","id":53932948,"diff_hunk":"@@ -161,6 +162,15 @@ struct FrameFusioHandler : public GenericHandler {\n         \"frame_start_date\", \"frame_end_date\"}; }\n };\n \n+struct DatasetFusioHandler : public GenericHandler {\n+    DatasetFusioHandler(GtfsData& gdata, CsvReader& reader) : GenericHandler(gdata, reader) {}\n+    int id_c, contributor_c, start_date_c, end_date_c, type_c, desc_c, system_c;\n+    void init(Data&);\n+    void handle_line(Data& data, const csv_row& row, bool is_first_line);\n+    const std::vector<std::string> required_headers() const { return {\"dataset_id\", \"contributor_id\",","path":"source/ed/connectors/fusio_parser.h","position":26,"original_position":26,"commit_id":"9b3f58c639c4401859a2834eb461072a5d445451","original_commit_id":"9b3f58c639c4401859a2834eb461072a5d445451","user":{"login":"antoine-de","id":3987698,"avatar_url":"https://avatars.githubusercontent.com/u/3987698?v=3","gravatar_id":"","url":"https://api.github.com/users/antoine-de","html_url":"https://github.com/antoine-de","followers_url":"https://api.github.com/users/antoine-de/followers","following_url":"https://api.github.com/users/antoine-de/following{/other_user}","gists_url":"https://api.github.com/users/antoine-de/gists{/gist_id}","starred_url":"https://api.github.com/users/antoine-de/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antoine-de/subscriptions","organizations_url":"https://api.github.com/users/antoine-de/orgs","repos_url":"https://api.github.com/users/antoine-de/repos","events_url":"https://api.github.com/users/antoine-de/events{/privacy}","received_events_url":"https://api.github.com/users/antoine-de/received_events","type":"User","site_admin":false},"body":"I think it's easier to only use the DatasetFusioHandler and remove the FrameFusioHandler no ?","created_at":"2016-02-24T12:47:52Z","updated_at":"2016-02-24T12:47:52Z","html_url":"https://github.com/CanalTP/navitia/pull/1430#discussion_r53932948","pull_request_url":"https://api.github.com/repos/CanalTP/navitia/pulls/1430","_links":{"self":{"href":"https://api.github.com/repos/CanalTP/navitia/pulls/comments/53932948"},"html":{"href":"https://github.com/CanalTP/navitia/pull/1430#discussion_r53932948"},"pull_request":{"href":"https://api.github.com/repos/CanalTP/navitia/pulls/1430"}}},"pull_request":{"url":"https://api.github.com/repos/CanalTP/navitia/pulls/1430","id":60485102,"html_url":"https://github.com/CanalTP/navitia/pull/1430","diff_url":"https://github.com/CanalTP/navitia/pull/1430.diff","patch_url":"https://github.com/CanalTP/navitia/pull/1430.patch","issue_url":"https://api.github.com/repos/CanalTP/navitia/issues/1430","number":1430,"state":"open","locked":false,"title":"ed, kraken: Rename frame in ed and kraken","user":{"login":"kadhikari","id":5418640,"avatar_url":"https://avatars.githubusercontent.com/u/5418640?v=3","gravatar_id":"","url":"https://api.github.com/users/kadhikari","html_url":"https://github.com/kadhikari","followers_url":"https://api.github.com/users/kadhikari/followers","following_url":"https://api.github.com/users/kadhikari/following{/other_user}","gists_url":"https://api.github.com/users/kadhikari/gists{/gist_id}","starred_url":"https://api.github.com/users/kadhikari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kadhikari/subscriptions","organizations_url":"https://api.github.com/users/kadhikari/orgs","repos_url":"https://api.github.com/users/kadhikari/repos","events_url":"https://api.github.com/users/kadhikari/events{/privacy}","received_events_url":"https://api.github.com/users/kadhikari/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-02-24T10:14:35Z","updated_at":"2016-02-24T12:47:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fb5a98945071bb59fce836f454796c272918a48a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/CanalTP/navitia/pulls/1430/commits","review_comments_url":"https://api.github.com/repos/CanalTP/navitia/pulls/1430/comments","review_comment_url":"https://api.github.com/repos/CanalTP/navitia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CanalTP/navitia/issues/1430/comments","statuses_url":"https://api.github.com/repos/CanalTP/navitia/statuses/9b3f58c639c4401859a2834eb461072a5d445451","head":{"label":"kadhikari:rename_frame_in_ed_and_kraken","ref":"rename_frame_in_ed_and_kraken","sha":"9b3f58c639c4401859a2834eb461072a5d445451","user":{"login":"kadhikari","id":5418640,"avatar_url":"https://avatars.githubusercontent.com/u/5418640?v=3","gravatar_id":"","url":"https://api.github.com/users/kadhikari","html_url":"https://github.com/kadhikari","followers_url":"https://api.github.com/users/kadhikari/followers","following_url":"https://api.github.com/users/kadhikari/following{/other_user}","gists_url":"https://api.github.com/users/kadhikari/gists{/gist_id}","starred_url":"https://api.github.com/users/kadhikari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kadhikari/subscriptions","organizations_url":"https://api.github.com/users/kadhikari/orgs","repos_url":"https://api.github.com/users/kadhikari/repos","events_url":"https://api.github.com/users/kadhikari/events{/privacy}","received_events_url":"https://api.github.com/users/kadhikari/received_events","type":"User","site_admin":false},"repo":{"id":19244848,"name":"navitia","full_name":"kadhikari/navitia","owner":{"login":"kadhikari","id":5418640,"avatar_url":"https://avatars.githubusercontent.com/u/5418640?v=3","gravatar_id":"","url":"https://api.github.com/users/kadhikari","html_url":"https://github.com/kadhikari","followers_url":"https://api.github.com/users/kadhikari/followers","following_url":"https://api.github.com/users/kadhikari/following{/other_user}","gists_url":"https://api.github.com/users/kadhikari/gists{/gist_id}","starred_url":"https://api.github.com/users/kadhikari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kadhikari/subscriptions","organizations_url":"https://api.github.com/users/kadhikari/orgs","repos_url":"https://api.github.com/users/kadhikari/repos","events_url":"https://api.github.com/users/kadhikari/events{/privacy}","received_events_url":"https://api.github.com/users/kadhikari/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kadhikari/navitia","description":"A multi-modal journey planner REST API","fork":true,"url":"https://api.github.com/repos/kadhikari/navitia","forks_url":"https://api.github.com/repos/kadhikari/navitia/forks","keys_url":"https://api.github.com/repos/kadhikari/navitia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kadhikari/navitia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kadhikari/navitia/teams","hooks_url":"https://api.github.com/repos/kadhikari/navitia/hooks","issue_events_url":"https://api.github.com/repos/kadhikari/navitia/issues/events{/number}","events_url":"https://api.github.com/repos/kadhikari/navitia/events","assignees_url":"https://api.github.com/repos/kadhikari/navitia/assignees{/user}","branches_url":"https://api.github.com/repos/kadhikari/navitia/branches{/branch}","tags_url":"https://api.github.com/repos/kadhikari/navitia/tags","blobs_url":"https://api.github.com/repos/kadhikari/navitia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kadhikari/navitia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kadhikari/navitia/git/refs{/sha}","trees_url":"https://api.github.com/repos/kadhikari/navitia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kadhikari/navitia/statuses/{sha}","languages_url":"https://api.github.com/repos/kadhikari/navitia/languages","stargazers_url":"https://api.github.com/repos/kadhikari/navitia/stargazers","contributors_url":"https://api.github.com/repos/kadhikari/navitia/contributors","subscribers_url":"https://api.github.com/repos/kadhikari/navitia/subscribers","subscription_url":"https://api.github.com/repos/kadhikari/navitia/subscription","commits_url":"https://api.github.com/repos/kadhikari/navitia/commits{/sha}","git_commits_url":"https://api.github.com/repos/kadhikari/navitia/git/commits{/sha}","comments_url":"https://api.github.com/repos/kadhikari/navitia/comments{/number}","issue_comment_url":"https://api.github.com/repos/kadhikari/navitia/issues/comments{/number}","contents_url":"https://api.github.com/repos/kadhikari/navitia/contents/{+path}","compare_url":"https://api.github.com/repos/kadhikari/navitia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kadhikari/navitia/merges","archive_url":"https://api.github.com/repos/kadhikari/navitia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kadhikari/navitia/downloads","issues_url":"https://api.github.com/repos/kadhikari/navitia/issues{/number}","pulls_url":"https://api.github.com/repos/kadhikari/navitia/pulls{/number}","milestones_url":"https://api.github.com/repos/kadhikari/navitia/milestones{/number}","notifications_url":"https://api.github.com/repos/kadhikari/navitia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kadhikari/navitia/labels{/name}","releases_url":"https://api.github.com/repos/kadhikari/navitia/releases{/id}","deployments_url":"https://api.github.com/repos/kadhikari/navitia/deployments","created_at":"2014-04-28T16:04:39Z","updated_at":"2014-06-16T14:50:58Z","pushed_at":"2016-02-24T10:13:52Z","git_url":"git://github.com/kadhikari/navitia.git","ssh_url":"git@github.com:kadhikari/navitia.git","clone_url":"https://github.com/kadhikari/navitia.git","svn_url":"https://github.com/kadhikari/navitia","homepage":"http://www.navitia.io/","size":28236,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"CanalTP:dev","ref":"dev","sha":"87fb0c0e82f1f74fc7aca4a2e8314c29c81024df","user":{"login":"CanalTP","id":2743985,"avatar_url":"https://avatars.githubusercontent.com/u/2743985?v=3","gravatar_id":"","url":"https://api.github.com/users/CanalTP","html_url":"https://github.com/CanalTP","followers_url":"https://api.github.com/users/CanalTP/followers","following_url":"https://api.github.com/users/CanalTP/following{/other_user}","gists_url":"https://api.github.com/users/CanalTP/gists{/gist_id}","starred_url":"https://api.github.com/users/CanalTP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CanalTP/subscriptions","organizations_url":"https://api.github.com/users/CanalTP/orgs","repos_url":"https://api.github.com/users/CanalTP/repos","events_url":"https://api.github.com/users/CanalTP/events{/privacy}","received_events_url":"https://api.github.com/users/CanalTP/received_events","type":"Organization","site_admin":false},"repo":{"id":10797333,"name":"navitia","full_name":"CanalTP/navitia","owner":{"login":"CanalTP","id":2743985,"avatar_url":"https://avatars.githubusercontent.com/u/2743985?v=3","gravatar_id":"","url":"https://api.github.com/users/CanalTP","html_url":"https://github.com/CanalTP","followers_url":"https://api.github.com/users/CanalTP/followers","following_url":"https://api.github.com/users/CanalTP/following{/other_user}","gists_url":"https://api.github.com/users/CanalTP/gists{/gist_id}","starred_url":"https://api.github.com/users/CanalTP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CanalTP/subscriptions","organizations_url":"https://api.github.com/users/CanalTP/orgs","repos_url":"https://api.github.com/users/CanalTP/repos","events_url":"https://api.github.com/users/CanalTP/events{/privacy}","received_events_url":"https://api.github.com/users/CanalTP/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CanalTP/navitia","description":"The open source software to build responsive stuff with locomotion","fork":false,"url":"https://api.github.com/repos/CanalTP/navitia","forks_url":"https://api.github.com/repos/CanalTP/navitia/forks","keys_url":"https://api.github.com/repos/CanalTP/navitia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CanalTP/navitia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CanalTP/navitia/teams","hooks_url":"https://api.github.com/repos/CanalTP/navitia/hooks","issue_events_url":"https://api.github.com/repos/CanalTP/navitia/issues/events{/number}","events_url":"https://api.github.com/repos/CanalTP/navitia/events","assignees_url":"https://api.github.com/repos/CanalTP/navitia/assignees{/user}","branches_url":"https://api.github.com/repos/CanalTP/navitia/branches{/branch}","tags_url":"https://api.github.com/repos/CanalTP/navitia/tags","blobs_url":"https://api.github.com/repos/CanalTP/navitia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CanalTP/navitia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CanalTP/navitia/git/refs{/sha}","trees_url":"https://api.github.com/repos/CanalTP/navitia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CanalTP/navitia/statuses/{sha}","languages_url":"https://api.github.com/repos/CanalTP/navitia/languages","stargazers_url":"https://api.github.com/repos/CanalTP/navitia/stargazers","contributors_url":"https://api.github.com/repos/CanalTP/navitia/contributors","subscribers_url":"https://api.github.com/repos/CanalTP/navitia/subscribers","subscription_url":"https://api.github.com/repos/CanalTP/navitia/subscription","commits_url":"https://api.github.com/repos/CanalTP/navitia/commits{/sha}","git_commits_url":"https://api.github.com/repos/CanalTP/navitia/git/commits{/sha}","comments_url":"https://api.github.com/repos/CanalTP/navitia/comments{/number}","issue_comment_url":"https://api.github.com/repos/CanalTP/navitia/issues/comments{/number}","contents_url":"https://api.github.com/repos/CanalTP/navitia/contents/{+path}","compare_url":"https://api.github.com/repos/CanalTP/navitia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CanalTP/navitia/merges","archive_url":"https://api.github.com/repos/CanalTP/navitia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CanalTP/navitia/downloads","issues_url":"https://api.github.com/repos/CanalTP/navitia/issues{/number}","pulls_url":"https://api.github.com/repos/CanalTP/navitia/pulls{/number}","milestones_url":"https://api.github.com/repos/CanalTP/navitia/milestones{/number}","notifications_url":"https://api.github.com/repos/CanalTP/navitia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CanalTP/navitia/labels{/name}","releases_url":"https://api.github.com/repos/CanalTP/navitia/releases{/id}","deployments_url":"https://api.github.com/repos/CanalTP/navitia/deployments","created_at":"2013-06-19T15:34:30Z","updated_at":"2016-02-20T01:23:02Z","pushed_at":"2016-02-24T10:15:47Z","git_url":"git://github.com/CanalTP/navitia.git","ssh_url":"git@github.com:CanalTP/navitia.git","clone_url":"https://github.com/CanalTP/navitia.git","svn_url":"https://github.com/CanalTP/navitia","homepage":"http://www.navitia.io","size":33300,"stargazers_count":146,"watchers_count":146,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":52,"mirror_url":null,"open_issues_count":18,"forks":52,"open_issues":18,"watchers":146,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/CanalTP/navitia/pulls/1430"},"html":{"href":"https://github.com/CanalTP/navitia/pull/1430"},"issue":{"href":"https://api.github.com/repos/CanalTP/navitia/issues/1430"},"comments":{"href":"https://api.github.com/repos/CanalTP/navitia/issues/1430/comments"},"review_comments":{"href":"https://api.github.com/repos/CanalTP/navitia/pulls/1430/comments"},"review_comment":{"href":"https://api.github.com/repos/CanalTP/navitia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CanalTP/navitia/pulls/1430/commits"},"statuses":{"href":"https://api.github.com/repos/CanalTP/navitia/statuses/9b3f58c639c4401859a2834eb461072a5d445451"}}}}