{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/5822","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/5822/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/5822/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/5822/events","html_url":"https://github.com/nodejs/node/pull/5822","id":142376605,"number":5822,"title":"events: make eventNames() use Reflect.ownKeys()","user":{"login":"lpinca","id":1443911,"avatar_url":"https://avatars.githubusercontent.com/u/1443911?v=3","gravatar_id":"","url":"https://api.github.com/users/lpinca","html_url":"https://github.com/lpinca","followers_url":"https://api.github.com/users/lpinca/followers","following_url":"https://api.github.com/users/lpinca/following{/other_user}","gists_url":"https://api.github.com/users/lpinca/gists{/gist_id}","starred_url":"https://api.github.com/users/lpinca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lpinca/subscriptions","organizations_url":"https://api.github.com/users/lpinca/orgs","repos_url":"https://api.github.com/users/lpinca/repos","events_url":"https://api.github.com/users/lpinca/events{/privacy}","received_events_url":"https://api.github.com/users/lpinca/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/nodejs/node/labels/dont-land-on-v4.x","name":"dont-land-on-v4.x","color":"fad8c7"},{"url":"https://api.github.com/repos/nodejs/node/labels/events","name":"events","color":"bfdadc"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":23,"created_at":"2016-03-21T15:06:28Z","updated_at":"2016-04-20T17:41:52Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/5822","html_url":"https://github.com/nodejs/node/pull/5822","diff_url":"https://github.com/nodejs/node/pull/5822.diff","patch_url":"https://github.com/nodejs/node/pull/5822.patch"},"body":"### Pull Request check-list\r\n\r\n_Please make sure to review and check all of these items:_\r\n\r\n- [x] Does `make -j8 test` (UNIX) or `vcbuild test nosign` (Windows) pass with\r\n  this change (including linting)?\r\n- [x] Is the commit message formatted according to CONTRIBUTING.md?\r\n- [ ] If this change fixes a bug (or a performance problem), is a regression\r\n  test (or a benchmark) included?\r\n- [ ] Is a documentation update included (if this change modifies\r\n  existing APIs, or introduces new ones)?\r\n\r\n### Affected core subsystem(s)\r\n\r\nevents\r\n\r\n### Description of change\r\n\r\nUse [`Reflect.ownKeys()`](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Reflect/ownKeys) instead of [`Object.keys()`](https://developer.mozilla.org/en/docs/Web/JavaScript/Reference/Global_Objects/Object/keys) and [`Object.getOwnPropertySymbols()`](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/getOwnPropertySymbols)."},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/212530944","html_url":"https://github.com/nodejs/node/pull/5822#issuecomment-212530944","issue_url":"https://api.github.com/repos/nodejs/node/issues/5822","id":212530944,"user":{"login":"jasnell","id":439929,"avatar_url":"https://avatars.githubusercontent.com/u/439929?v=3","gravatar_id":"","url":"https://api.github.com/users/jasnell","html_url":"https://github.com/jasnell","followers_url":"https://api.github.com/users/jasnell/followers","following_url":"https://api.github.com/users/jasnell/following{/other_user}","gists_url":"https://api.github.com/users/jasnell/gists{/gist_id}","starred_url":"https://api.github.com/users/jasnell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasnell/subscriptions","organizations_url":"https://api.github.com/users/jasnell/orgs","repos_url":"https://api.github.com/users/jasnell/repos","events_url":"https://api.github.com/users/jasnell/events{/privacy}","received_events_url":"https://api.github.com/users/jasnell/received_events","type":"User","site_admin":false},"created_at":"2016-04-20T17:41:52Z","updated_at":"2016-04-20T17:41:52Z","body":"Given the discussion I'm inclined to leave the code as it is currently and revisiting this later if necessary. As a new API, this is not yet in broad use yet, as such, the perf impact is going to be hard to measure. Let's hold off and let this circulate in the ecosystem a bit longer before deciding if/how/when to optimize it."}}