{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/71809174","id":71809174,"diff_hunk":"@@ -330,6 +335,13 @@ type operationExecutor struct {\n \t// pendingOperations keeps track of pending attach and detach operations so\n \t// multiple operations are not started on the same volume\n \tpendingOperations nestedpendingoperations.NestedPendingOperations\n+\n+\t// recorder is used to record events in the API server\n+\trecorder record.EventRecorder\n+\n+\t// represents a volume that should be attached to this node and\n+\t// mounted to the PodName.\n+\tvolumeToMount VolumeToMount","path":"pkg/volume/util/operationexecutor/operation_executor.go","position":36,"original_position":36,"commit_id":"978d4095dca3f2ad2480b5e1b4ea6564929e1d07","original_commit_id":"978d4095dca3f2ad2480b5e1b4ea6564929e1d07","user":{"login":"saad-ali","id":10052848,"avatar_url":"https://avatars.githubusercontent.com/u/10052848?v=3","gravatar_id":"","url":"https://api.github.com/users/saad-ali","html_url":"https://github.com/saad-ali","followers_url":"https://api.github.com/users/saad-ali/followers","following_url":"https://api.github.com/users/saad-ali/following{/other_user}","gists_url":"https://api.github.com/users/saad-ali/gists{/gist_id}","starred_url":"https://api.github.com/users/saad-ali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saad-ali/subscriptions","organizations_url":"https://api.github.com/users/saad-ali/orgs","repos_url":"https://api.github.com/users/saad-ali/repos","events_url":"https://api.github.com/users/saad-ali/events{/privacy}","received_events_url":"https://api.github.com/users/saad-ali/received_events","type":"User","site_admin":false},"body":"I don't understand why this was added here. And I don't see where it is populated.","created_at":"2016-07-22T00:03:28Z","updated_at":"2016-07-22T00:03:28Z","html_url":"https://github.com/kubernetes/kubernetes/pull/27778#discussion_r71809174","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/27778","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/71809174"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/27778#discussion_r71809174"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/27778"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/27778","id":74642305,"html_url":"https://github.com/kubernetes/kubernetes/pull/27778","diff_url":"https://github.com/kubernetes/kubernetes/pull/27778.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/27778.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/27778","number":27778,"state":"open","locked":false,"title":"Add Events for operation_executor to show status of mounts, failed/successful to show in describe events","user":{"login":"screeley44","id":6773375,"avatar_url":"https://avatars.githubusercontent.com/u/6773375?v=3","gravatar_id":"","url":"https://api.github.com/users/screeley44","html_url":"https://github.com/screeley44","followers_url":"https://api.github.com/users/screeley44/followers","following_url":"https://api.github.com/users/screeley44/following{/other_user}","gists_url":"https://api.github.com/users/screeley44/gists{/gist_id}","starred_url":"https://api.github.com/users/screeley44/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/screeley44/subscriptions","organizations_url":"https://api.github.com/users/screeley44/orgs","repos_url":"https://api.github.com/users/screeley44/repos","events_url":"https://api.github.com/users/screeley44/events{/privacy}","received_events_url":"https://api.github.com/users/screeley44/received_events","type":"User","site_admin":false},"body":"Fixes #27590 \r\n@saad-ali @pmorie @erinboyd\r\n\r\nAfter talking with @pmorie last week about the above issue, I decided to poke around and see if I could remedy.  The refactoring broke my previous UXP merged PR's that correctly showed failed mount errors in the describe events.  However, Not sure I implemented correctly, but it tested out and seems to be working, let me know what I missed or if this is not the correct approach.\r\n\r\n```\r\nEvents:\r\n  FirstSeen\tLastSeen\tCount\tFrom\t\t\tSubobjectPath\tType\t\tReason\t\tMessage\r\n  ---------\t--------\t-----\t----\t\t\t-------------\t--------\t------\t\t-------\r\n  2m\t\t2m\t\t1\t{default-scheduler }\t\t\tNormal\t\tScheduled\tSuccessfully assigned nfs-bb-pod1 to 127.0.0.1\r\n  44s\t\t44s\t\t1\t{kubelet 127.0.0.1}\t\t\tWarning\t\tFailedMount\tUnable to mount volumes for pod \"nfs-bb-pod1_default(a94f64f1-37c9-11e6-9aa5-52540073d346)\": timeout expired waiting for volumes to attach/mount for pod \"nfs-bb-pod1\"/\"default\". list of unattached/unmounted volumes=[nfsvol]\r\n  44s\t\t44s\t\t1\t{kubelet 127.0.0.1}\t\t\tWarning\t\tFailedSync\tError syncing pod, skipping: timeout expired waiting for volumes to attach/mount for pod \"nfs-bb-pod1\"/\"default\". list of unattached/unmounted volumes=[nfsvol]\r\n  38s\t\t38s\t\t1\t{kubelet }\t\t\t\tWarning\t\tFailedMount\tUnable to mount volumes for pod \"a94f64f1-37c9-11e6-9aa5-52540073d346\": Mount failed: exit status 32\r\nMounting arguments: nfs1.rhs:/opt/data99 /var/lib/kubelet/pods/a94f64f1-37c9-11e6-9aa5-52540073d346/volumes/kubernetes.io~nfs/nfsvol nfs []\r\nOutput: mount.nfs: Connection timed out\r\n\r\nResolution hint: Check and make sure the NFS Server exists (ensure that correct IPAddress/Hostname was given) and is available/reachable.\r\nAlso make sure firewall ports are open on both client and NFS Server (2049 v4 and 2049, 20048 and 111 for v3).\r\nUse commands telnet <nfs server> <port> and showmount <nfs server> to help test connectivity.\r\n```","created_at":"2016-06-21T16:19:53Z","updated_at":"2016-07-22T00:03:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8c7c65bdd3129805ce4bafdffba7540b574f799a","assignee":{"login":"saad-ali","id":10052848,"avatar_url":"https://avatars.githubusercontent.com/u/10052848?v=3","gravatar_id":"","url":"https://api.github.com/users/saad-ali","html_url":"https://github.com/saad-ali","followers_url":"https://api.github.com/users/saad-ali/followers","following_url":"https://api.github.com/users/saad-ali/following{/other_user}","gists_url":"https://api.github.com/users/saad-ali/gists{/gist_id}","starred_url":"https://api.github.com/users/saad-ali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saad-ali/subscriptions","organizations_url":"https://api.github.com/users/saad-ali/orgs","repos_url":"https://api.github.com/users/saad-ali/repos","events_url":"https://api.github.com/users/saad-ali/events{/privacy}","received_events_url":"https://api.github.com/users/saad-ali/received_events","type":"User","site_admin":false},"assignees":[{"login":"saad-ali","id":10052848,"avatar_url":"https://avatars.githubusercontent.com/u/10052848?v=3","gravatar_id":"","url":"https://api.github.com/users/saad-ali","html_url":"https://github.com/saad-ali","followers_url":"https://api.github.com/users/saad-ali/followers","following_url":"https://api.github.com/users/saad-ali/following{/other_user}","gists_url":"https://api.github.com/users/saad-ali/gists{/gist_id}","starred_url":"https://api.github.com/users/saad-ali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saad-ali/subscriptions","organizations_url":"https://api.github.com/users/saad-ali/orgs","repos_url":"https://api.github.com/users/saad-ali/repos","events_url":"https://api.github.com/users/saad-ali/events{/privacy}","received_events_url":"https://api.github.com/users/saad-ali/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/22","html_url":"https://github.com/kubernetes/kubernetes/milestones/v1.4","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/22/labels","id":1777384,"number":22,"title":"v1.4","description":"","creator":{"login":"bgrant0607","id":7725777,"avatar_url":"https://avatars.githubusercontent.com/u/7725777?v=3","gravatar_id":"","url":"https://api.github.com/users/bgrant0607","html_url":"https://github.com/bgrant0607","followers_url":"https://api.github.com/users/bgrant0607/followers","following_url":"https://api.github.com/users/bgrant0607/following{/other_user}","gists_url":"https://api.github.com/users/bgrant0607/gists{/gist_id}","starred_url":"https://api.github.com/users/bgrant0607/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgrant0607/subscriptions","organizations_url":"https://api.github.com/users/bgrant0607/orgs","repos_url":"https://api.github.com/users/bgrant0607/repos","events_url":"https://api.github.com/users/bgrant0607/events{/privacy}","received_events_url":"https://api.github.com/users/bgrant0607/received_events","type":"User","site_admin":false},"open_issues":148,"closed_issues":67,"state":"open","created_at":"2016-05-19T18:50:19Z","updated_at":"2016-07-21T22:33:42Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/27778/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/27778/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/27778/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/978d4095dca3f2ad2480b5e1b4ea6564929e1d07","head":{"label":"screeley44:k8-vol-executor","ref":"k8-vol-executor","sha":"978d4095dca3f2ad2480b5e1b4ea6564929e1d07","user":{"login":"screeley44","id":6773375,"avatar_url":"https://avatars.githubusercontent.com/u/6773375?v=3","gravatar_id":"","url":"https://api.github.com/users/screeley44","html_url":"https://github.com/screeley44","followers_url":"https://api.github.com/users/screeley44/followers","following_url":"https://api.github.com/users/screeley44/following{/other_user}","gists_url":"https://api.github.com/users/screeley44/gists{/gist_id}","starred_url":"https://api.github.com/users/screeley44/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/screeley44/subscriptions","organizations_url":"https://api.github.com/users/screeley44/orgs","repos_url":"https://api.github.com/users/screeley44/repos","events_url":"https://api.github.com/users/screeley44/events{/privacy}","received_events_url":"https://api.github.com/users/screeley44/received_events","type":"User","site_admin":false},"repo":{"id":31073694,"name":"kubernetes","full_name":"screeley44/kubernetes","owner":{"login":"screeley44","id":6773375,"avatar_url":"https://avatars.githubusercontent.com/u/6773375?v=3","gravatar_id":"","url":"https://api.github.com/users/screeley44","html_url":"https://github.com/screeley44","followers_url":"https://api.github.com/users/screeley44/followers","following_url":"https://api.github.com/users/screeley44/following{/other_user}","gists_url":"https://api.github.com/users/screeley44/gists{/gist_id}","starred_url":"https://api.github.com/users/screeley44/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/screeley44/subscriptions","organizations_url":"https://api.github.com/users/screeley44/orgs","repos_url":"https://api.github.com/users/screeley44/repos","events_url":"https://api.github.com/users/screeley44/events{/privacy}","received_events_url":"https://api.github.com/users/screeley44/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/screeley44/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/screeley44/kubernetes","forks_url":"https://api.github.com/repos/screeley44/kubernetes/forks","keys_url":"https://api.github.com/repos/screeley44/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/screeley44/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/screeley44/kubernetes/teams","hooks_url":"https://api.github.com/repos/screeley44/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/screeley44/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/screeley44/kubernetes/events","assignees_url":"https://api.github.com/repos/screeley44/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/screeley44/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/screeley44/kubernetes/tags","blobs_url":"https://api.github.com/repos/screeley44/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/screeley44/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/screeley44/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/screeley44/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/screeley44/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/screeley44/kubernetes/languages","stargazers_url":"https://api.github.com/repos/screeley44/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/screeley44/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/screeley44/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/screeley44/kubernetes/subscription","commits_url":"https://api.github.com/repos/screeley44/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/screeley44/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/screeley44/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/screeley44/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/screeley44/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/screeley44/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/screeley44/kubernetes/merges","archive_url":"https://api.github.com/repos/screeley44/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/screeley44/kubernetes/downloads","issues_url":"https://api.github.com/repos/screeley44/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/screeley44/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/screeley44/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/screeley44/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/screeley44/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/screeley44/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/screeley44/kubernetes/deployments","created_at":"2015-02-20T16:34:03Z","updated_at":"2016-03-14T18:36:58Z","pushed_at":"2016-07-21T22:32:48Z","git_url":"git://github.com/screeley44/kubernetes.git","ssh_url":"git@github.com:screeley44/kubernetes.git","clone_url":"https://github.com/screeley44/kubernetes.git","svn_url":"https://github.com/screeley44/kubernetes","homepage":"http://kubernetes.io","size":277011,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"8780b45a0486ea53e2bae58bbb6bd7c8a1cbc42c","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-07-21T23:45:46Z","pushed_at":"2016-07-22T00:01:13Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":495565,"stargazers_count":15656,"watchers_count":15656,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4940,"mirror_url":null,"open_issues_count":3956,"forks":4940,"open_issues":3956,"watchers":15656,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/27778"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/27778"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/27778"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/27778/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/27778/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/27778/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/978d4095dca3f2ad2480b5e1b4ea6564929e1d07"}}}}
{"actor":{"display_login":"saad-ali"}}