{"action":"created","comment":{"url":"https://api.github.com/repos/OCA/account-financial-reporting/pulls/comments/52015728","id":52015728,"diff_hunk":"@@ -190,17 +171,17 @@ def render_comparison(self, lang_id, value, base_value,\n                 return self._render_num(\n                     lang_id,\n                     value - base_value,\n-                    self.divider, self.dp, self.suffix, sign='+')\n+                    self.divider, self.dp, '', self.suffix, sign='+')","path":"mis_builder/models/mis_builder.py","position":74,"original_position":74,"commit_id":"b3c2c9c12d5df32b049b526cdbba223013d22736","original_commit_id":"b3c2c9c12d5df32b049b526cdbba223013d22736","user":{"login":"sbidoul","id":692075,"avatar_url":"https://avatars.githubusercontent.com/u/692075?v=3","gravatar_id":"","url":"https://api.github.com/users/sbidoul","html_url":"https://github.com/sbidoul","followers_url":"https://api.github.com/users/sbidoul/followers","following_url":"https://api.github.com/users/sbidoul/following{/other_user}","gists_url":"https://api.github.com/users/sbidoul/gists{/gist_id}","starred_url":"https://api.github.com/users/sbidoul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbidoul/subscriptions","organizations_url":"https://api.github.com/users/sbidoul/orgs","repos_url":"https://api.github.com/users/sbidoul/repos","events_url":"https://api.github.com/users/sbidoul/events{/privacy}","received_events_url":"https://api.github.com/users/sbidoul/received_events","type":"User","site_admin":false},"body":"But in this specific comparison, it does make sense to keep the prefix. It's the case where we show the absolute difference: dollar minus dollar is still dollar.","created_at":"2016-02-05T13:34:50Z","updated_at":"2016-02-05T13:34:50Z","html_url":"https://github.com/OCA/account-financial-reporting/pull/145#discussion_r52015728","pull_request_url":"https://api.github.com/repos/OCA/account-financial-reporting/pulls/145","_links":{"self":{"href":"https://api.github.com/repos/OCA/account-financial-reporting/pulls/comments/52015728"},"html":{"href":"https://github.com/OCA/account-financial-reporting/pull/145#discussion_r52015728"},"pull_request":{"href":"https://api.github.com/repos/OCA/account-financial-reporting/pulls/145"}}},"pull_request":{"url":"https://api.github.com/repos/OCA/account-financial-reporting/pulls/145","id":53255808,"html_url":"https://github.com/OCA/account-financial-reporting/pull/145","diff_url":"https://github.com/OCA/account-financial-reporting/pull/145.diff","patch_url":"https://github.com/OCA/account-financial-reporting/pull/145.patch","issue_url":"https://api.github.com/repos/OCA/account-financial-reporting/issues/145","number":145,"state":"open","locked":false,"title":"[mis_builder] add prefixes","user":{"login":"jbeficent","id":7683926,"avatar_url":"https://avatars.githubusercontent.com/u/7683926?v=3","gravatar_id":"","url":"https://api.github.com/users/jbeficent","html_url":"https://github.com/jbeficent","followers_url":"https://api.github.com/users/jbeficent/followers","following_url":"https://api.github.com/users/jbeficent/following{/other_user}","gists_url":"https://api.github.com/users/jbeficent/gists{/gist_id}","starred_url":"https://api.github.com/users/jbeficent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbeficent/subscriptions","organizations_url":"https://api.github.com/users/jbeficent/orgs","repos_url":"https://api.github.com/users/jbeficent/repos","events_url":"https://api.github.com/users/jbeficent/events{/privacy}","received_events_url":"https://api.github.com/users/jbeficent/received_events","type":"User","site_admin":false},"body":"This PR adds a new field to the MIS Report template, to the KPI section, called 'suffix'.\r\n\r\nThe typical use case will be for companies that operate in currencies such as $, where the sign is indicated as a prefix of the value. Note that with negative numbers the prefix goes as -$100, not as $-100.\r\n\r\nimage\r\n![image](https://cloud.githubusercontent.com/assets/7683926/11716023/1f881ad4-9f47-11e5-885d-d04ec7e30102.png)\r\n\r\n![image](https://cloud.githubusercontent.com/assets/7683926/11716028/26e3fece-9f47-11e5-8bfc-c763d38ae132.png)\r\n\r\n![image](https://cloud.githubusercontent.com/assets/7683926/11716031/2c42ee84-9f47-11e5-872c-8871b65e2db8.png)\r\n","created_at":"2015-12-10T13:06:20Z","updated_at":"2016-02-05T13:34:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"30b34fc3e1fbeb9035fded3b3797434bac514813","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/OCA/account-financial-reporting/pulls/145/commits","review_comments_url":"https://api.github.com/repos/OCA/account-financial-reporting/pulls/145/comments","review_comment_url":"https://api.github.com/repos/OCA/account-financial-reporting/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OCA/account-financial-reporting/issues/145/comments","statuses_url":"https://api.github.com/repos/OCA/account-financial-reporting/statuses/b3c2c9c12d5df32b049b526cdbba223013d22736","head":{"label":"Eficent:8.0-prefix","ref":"8.0-prefix","sha":"b3c2c9c12d5df32b049b526cdbba223013d22736","user":{"login":"Eficent","id":7718403,"avatar_url":"https://avatars.githubusercontent.com/u/7718403?v=3","gravatar_id":"","url":"https://api.github.com/users/Eficent","html_url":"https://github.com/Eficent","followers_url":"https://api.github.com/users/Eficent/followers","following_url":"https://api.github.com/users/Eficent/following{/other_user}","gists_url":"https://api.github.com/users/Eficent/gists{/gist_id}","starred_url":"https://api.github.com/users/Eficent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Eficent/subscriptions","organizations_url":"https://api.github.com/users/Eficent/orgs","repos_url":"https://api.github.com/users/Eficent/repos","events_url":"https://api.github.com/users/Eficent/events{/privacy}","received_events_url":"https://api.github.com/users/Eficent/received_events","type":"Organization","site_admin":false},"repo":{"id":47761636,"name":"account-financial-reporting","full_name":"Eficent/account-financial-reporting","owner":{"login":"Eficent","id":7718403,"avatar_url":"https://avatars.githubusercontent.com/u/7718403?v=3","gravatar_id":"","url":"https://api.github.com/users/Eficent","html_url":"https://github.com/Eficent","followers_url":"https://api.github.com/users/Eficent/followers","following_url":"https://api.github.com/users/Eficent/following{/other_user}","gists_url":"https://api.github.com/users/Eficent/gists{/gist_id}","starred_url":"https://api.github.com/users/Eficent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Eficent/subscriptions","organizations_url":"https://api.github.com/users/Eficent/orgs","repos_url":"https://api.github.com/users/Eficent/repos","events_url":"https://api.github.com/users/Eficent/events{/privacy}","received_events_url":"https://api.github.com/users/Eficent/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Eficent/account-financial-reporting","description":"Financial reports for Odoo","fork":true,"url":"https://api.github.com/repos/Eficent/account-financial-reporting","forks_url":"https://api.github.com/repos/Eficent/account-financial-reporting/forks","keys_url":"https://api.github.com/repos/Eficent/account-financial-reporting/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Eficent/account-financial-reporting/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Eficent/account-financial-reporting/teams","hooks_url":"https://api.github.com/repos/Eficent/account-financial-reporting/hooks","issue_events_url":"https://api.github.com/repos/Eficent/account-financial-reporting/issues/events{/number}","events_url":"https://api.github.com/repos/Eficent/account-financial-reporting/events","assignees_url":"https://api.github.com/repos/Eficent/account-financial-reporting/assignees{/user}","branches_url":"https://api.github.com/repos/Eficent/account-financial-reporting/branches{/branch}","tags_url":"https://api.github.com/repos/Eficent/account-financial-reporting/tags","blobs_url":"https://api.github.com/repos/Eficent/account-financial-reporting/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Eficent/account-financial-reporting/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Eficent/account-financial-reporting/git/refs{/sha}","trees_url":"https://api.github.com/repos/Eficent/account-financial-reporting/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Eficent/account-financial-reporting/statuses/{sha}","languages_url":"https://api.github.com/repos/Eficent/account-financial-reporting/languages","stargazers_url":"https://api.github.com/repos/Eficent/account-financial-reporting/stargazers","contributors_url":"https://api.github.com/repos/Eficent/account-financial-reporting/contributors","subscribers_url":"https://api.github.com/repos/Eficent/account-financial-reporting/subscribers","subscription_url":"https://api.github.com/repos/Eficent/account-financial-reporting/subscription","commits_url":"https://api.github.com/repos/Eficent/account-financial-reporting/commits{/sha}","git_commits_url":"https://api.github.com/repos/Eficent/account-financial-reporting/git/commits{/sha}","comments_url":"https://api.github.com/repos/Eficent/account-financial-reporting/comments{/number}","issue_comment_url":"https://api.github.com/repos/Eficent/account-financial-reporting/issues/comments{/number}","contents_url":"https://api.github.com/repos/Eficent/account-financial-reporting/contents/{+path}","compare_url":"https://api.github.com/repos/Eficent/account-financial-reporting/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Eficent/account-financial-reporting/merges","archive_url":"https://api.github.com/repos/Eficent/account-financial-reporting/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Eficent/account-financial-reporting/downloads","issues_url":"https://api.github.com/repos/Eficent/account-financial-reporting/issues{/number}","pulls_url":"https://api.github.com/repos/Eficent/account-financial-reporting/pulls{/number}","milestones_url":"https://api.github.com/repos/Eficent/account-financial-reporting/milestones{/number}","notifications_url":"https://api.github.com/repos/Eficent/account-financial-reporting/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Eficent/account-financial-reporting/labels{/name}","releases_url":"https://api.github.com/repos/Eficent/account-financial-reporting/releases{/id}","deployments_url":"https://api.github.com/repos/Eficent/account-financial-reporting/deployments","created_at":"2015-12-10T12:55:50Z","updated_at":"2015-12-10T12:55:51Z","pushed_at":"2016-02-05T13:33:00Z","git_url":"git://github.com/Eficent/account-financial-reporting.git","ssh_url":"git@github.com:Eficent/account-financial-reporting.git","clone_url":"https://github.com/Eficent/account-financial-reporting.git","svn_url":"https://github.com/Eficent/account-financial-reporting","homepage":"http://community.odoo.com","size":4094,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"9.0"}},"base":{"label":"OCA:8.0","ref":"8.0","sha":"c9c941dc295f56ed52c724cc70d0f4f48dd0d715","user":{"login":"OCA","id":7600578,"avatar_url":"https://avatars.githubusercontent.com/u/7600578?v=3","gravatar_id":"","url":"https://api.github.com/users/OCA","html_url":"https://github.com/OCA","followers_url":"https://api.github.com/users/OCA/followers","following_url":"https://api.github.com/users/OCA/following{/other_user}","gists_url":"https://api.github.com/users/OCA/gists{/gist_id}","starred_url":"https://api.github.com/users/OCA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OCA/subscriptions","organizations_url":"https://api.github.com/users/OCA/orgs","repos_url":"https://api.github.com/users/OCA/repos","events_url":"https://api.github.com/users/OCA/events{/privacy}","received_events_url":"https://api.github.com/users/OCA/received_events","type":"Organization","site_admin":false},"repo":{"id":21203040,"name":"account-financial-reporting","full_name":"OCA/account-financial-reporting","owner":{"login":"OCA","id":7600578,"avatar_url":"https://avatars.githubusercontent.com/u/7600578?v=3","gravatar_id":"","url":"https://api.github.com/users/OCA","html_url":"https://github.com/OCA","followers_url":"https://api.github.com/users/OCA/followers","following_url":"https://api.github.com/users/OCA/following{/other_user}","gists_url":"https://api.github.com/users/OCA/gists{/gist_id}","starred_url":"https://api.github.com/users/OCA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OCA/subscriptions","organizations_url":"https://api.github.com/users/OCA/orgs","repos_url":"https://api.github.com/users/OCA/repos","events_url":"https://api.github.com/users/OCA/events{/privacy}","received_events_url":"https://api.github.com/users/OCA/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OCA/account-financial-reporting","description":"Financial reports for Odoo","fork":false,"url":"https://api.github.com/repos/OCA/account-financial-reporting","forks_url":"https://api.github.com/repos/OCA/account-financial-reporting/forks","keys_url":"https://api.github.com/repos/OCA/account-financial-reporting/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OCA/account-financial-reporting/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OCA/account-financial-reporting/teams","hooks_url":"https://api.github.com/repos/OCA/account-financial-reporting/hooks","issue_events_url":"https://api.github.com/repos/OCA/account-financial-reporting/issues/events{/number}","events_url":"https://api.github.com/repos/OCA/account-financial-reporting/events","assignees_url":"https://api.github.com/repos/OCA/account-financial-reporting/assignees{/user}","branches_url":"https://api.github.com/repos/OCA/account-financial-reporting/branches{/branch}","tags_url":"https://api.github.com/repos/OCA/account-financial-reporting/tags","blobs_url":"https://api.github.com/repos/OCA/account-financial-reporting/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OCA/account-financial-reporting/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OCA/account-financial-reporting/git/refs{/sha}","trees_url":"https://api.github.com/repos/OCA/account-financial-reporting/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OCA/account-financial-reporting/statuses/{sha}","languages_url":"https://api.github.com/repos/OCA/account-financial-reporting/languages","stargazers_url":"https://api.github.com/repos/OCA/account-financial-reporting/stargazers","contributors_url":"https://api.github.com/repos/OCA/account-financial-reporting/contributors","subscribers_url":"https://api.github.com/repos/OCA/account-financial-reporting/subscribers","subscription_url":"https://api.github.com/repos/OCA/account-financial-reporting/subscription","commits_url":"https://api.github.com/repos/OCA/account-financial-reporting/commits{/sha}","git_commits_url":"https://api.github.com/repos/OCA/account-financial-reporting/git/commits{/sha}","comments_url":"https://api.github.com/repos/OCA/account-financial-reporting/comments{/number}","issue_comment_url":"https://api.github.com/repos/OCA/account-financial-reporting/issues/comments{/number}","contents_url":"https://api.github.com/repos/OCA/account-financial-reporting/contents/{+path}","compare_url":"https://api.github.com/repos/OCA/account-financial-reporting/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OCA/account-financial-reporting/merges","archive_url":"https://api.github.com/repos/OCA/account-financial-reporting/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OCA/account-financial-reporting/downloads","issues_url":"https://api.github.com/repos/OCA/account-financial-reporting/issues{/number}","pulls_url":"https://api.github.com/repos/OCA/account-financial-reporting/pulls{/number}","milestones_url":"https://api.github.com/repos/OCA/account-financial-reporting/milestones{/number}","notifications_url":"https://api.github.com/repos/OCA/account-financial-reporting/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OCA/account-financial-reporting/labels{/name}","releases_url":"https://api.github.com/repos/OCA/account-financial-reporting/releases{/id}","deployments_url":"https://api.github.com/repos/OCA/account-financial-reporting/deployments","created_at":"2014-06-25T12:53:30Z","updated_at":"2016-01-01T08:43:01Z","pushed_at":"2016-02-05T13:33:00Z","git_url":"git://github.com/OCA/account-financial-reporting.git","ssh_url":"git@github.com:OCA/account-financial-reporting.git","clone_url":"https://github.com/OCA/account-financial-reporting.git","svn_url":"https://github.com/OCA/account-financial-reporting","homepage":"http://community.odoo.com","size":5933,"stargazers_count":25,"watchers_count":25,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":116,"mirror_url":null,"open_issues_count":63,"forks":116,"open_issues":63,"watchers":25,"default_branch":"9.0"}},"_links":{"self":{"href":"https://api.github.com/repos/OCA/account-financial-reporting/pulls/145"},"html":{"href":"https://github.com/OCA/account-financial-reporting/pull/145"},"issue":{"href":"https://api.github.com/repos/OCA/account-financial-reporting/issues/145"},"comments":{"href":"https://api.github.com/repos/OCA/account-financial-reporting/issues/145/comments"},"review_comments":{"href":"https://api.github.com/repos/OCA/account-financial-reporting/pulls/145/comments"},"review_comment":{"href":"https://api.github.com/repos/OCA/account-financial-reporting/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OCA/account-financial-reporting/pulls/145/commits"},"statuses":{"href":"https://api.github.com/repos/OCA/account-financial-reporting/statuses/b3c2c9c12d5df32b049b526cdbba223013d22736"}}}}