{"action":"created","issue":{"url":"https://api.github.com/repos/OpenRA/OpenRA/issues/10111","repository_url":"https://api.github.com/repos/OpenRA/OpenRA","labels_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/10111/labels{/name}","comments_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/10111/comments","events_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/10111/events","html_url":"https://github.com/OpenRA/OpenRA/issues/10111","id":118920032,"number":10111,"title":"Animations tick inside rendering functions","user":{"login":"RoosterDragon","id":3399086,"avatar_url":"https://avatars.githubusercontent.com/u/3399086?v=3","gravatar_id":"","url":"https://api.github.com/users/RoosterDragon","html_url":"https://github.com/RoosterDragon","followers_url":"https://api.github.com/users/RoosterDragon/followers","following_url":"https://api.github.com/users/RoosterDragon/following{/other_user}","gists_url":"https://api.github.com/users/RoosterDragon/gists{/gist_id}","starred_url":"https://api.github.com/users/RoosterDragon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RoosterDragon/subscriptions","organizations_url":"https://api.github.com/users/RoosterDragon/orgs","repos_url":"https://api.github.com/users/RoosterDragon/repos","events_url":"https://api.github.com/users/RoosterDragon/events{/privacy}","received_events_url":"https://api.github.com/users/RoosterDragon/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/OpenRA/OpenRA/labels/Bug","name":"Bug","color":"d7e102"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-11-25T20:38:44Z","updated_at":"2016-02-19T09:21:52Z","closed_at":null,"body":"Some areas call Animation.Tick from inside rendering functions instead of tick functions. This means the animation is tied to the framerate rather than the world time. This may lead to some animations becoming out of sync with the apparent world state.\r\n\r\nOffending callsites are:\r\n* [WithDecoration](https://github.com/OpenRA/OpenRA/blob/da1485dab7e168be004f51bcf73046d5692822ef/OpenRA.Mods.Common/Traits/Render/WithDecoration.cs#L167)\r\n* [WithParachute](https://github.com/OpenRA/OpenRA/blob/da1485dab7e168be004f51bcf73046d5692822ef/OpenRA.Mods.Common/Traits/Render/WithParachute.cs#L149)\r\n* [Carryall](https://github.com/OpenRA/OpenRA/blob/da1485dab7e168be004f51bcf73046d5692822ef/OpenRA.Mods.D2k/Traits/Carryall.cs#L208)\r\n\r\n<bountysource-plugin>\r\n---\r\nWant to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/28613678-animations-tick-inside-rendering-functions?utm_campaign=plugin&utm_content=tracker%2F36085&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F36085&utm_medium=issues&utm_source=github).\r\n</bountysource-plugin>"},"comment":{"url":"https://api.github.com/repos/OpenRA/OpenRA/issues/comments/186127385","html_url":"https://github.com/OpenRA/OpenRA/issues/10111#issuecomment-186127385","issue_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/10111","id":186127385,"user":{"login":"teees","id":15243958,"avatar_url":"https://avatars.githubusercontent.com/u/15243958?v=3","gravatar_id":"","url":"https://api.github.com/users/teees","html_url":"https://github.com/teees","followers_url":"https://api.github.com/users/teees/followers","following_url":"https://api.github.com/users/teees/following{/other_user}","gists_url":"https://api.github.com/users/teees/gists{/gist_id}","starred_url":"https://api.github.com/users/teees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teees/subscriptions","organizations_url":"https://api.github.com/users/teees/orgs","repos_url":"https://api.github.com/users/teees/repos","events_url":"https://api.github.com/users/teees/events{/privacy}","received_events_url":"https://api.github.com/users/teees/received_events","type":"User","site_admin":false},"created_at":"2016-02-19T09:21:52Z","updated_at":"2016-02-19T09:21:52Z","body":"#10775 fixes this for Carryalls"}}