{"action":"created","issue":{"url":"https://api.github.com/repos/servo/servo/issues/12637","repository_url":"https://api.github.com/repos/servo/servo","labels_url":"https://api.github.com/repos/servo/servo/issues/12637/labels{/name}","comments_url":"https://api.github.com/repos/servo/servo/issues/12637/comments","events_url":"https://api.github.com/repos/servo/servo/issues/12637/events","html_url":"https://github.com/servo/servo/pull/12637","id":168190510,"number":12637,"title":"Replaced mutex in constellation logging by a reentrant mutex.","user":{"login":"asajeffrey","id":403333,"avatar_url":"https://avatars.githubusercontent.com/u/403333?v=3","gravatar_id":"","url":"https://api.github.com/users/asajeffrey","html_url":"https://github.com/asajeffrey","followers_url":"https://api.github.com/users/asajeffrey/followers","following_url":"https://api.github.com/users/asajeffrey/following{/other_user}","gists_url":"https://api.github.com/users/asajeffrey/gists{/gist_id}","starred_url":"https://api.github.com/users/asajeffrey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asajeffrey/subscriptions","organizations_url":"https://api.github.com/users/asajeffrey/orgs","repos_url":"https://api.github.com/users/asajeffrey/repos","events_url":"https://api.github.com/users/asajeffrey/events{/privacy}","received_events_url":"https://api.github.com/users/asajeffrey/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/servo/servo/labels/A-constellation","name":"A-constellation","color":"d7e102"},{"url":"https://api.github.com/repos/servo/servo/labels/I-panic","name":"I-panic","color":"e10c02"},{"url":"https://api.github.com/repos/servo/servo/labels/S-awaiting-merge","name":"S-awaiting-merge","color":"d4c5f9"}],"state":"open","locked":false,"assignee":{"login":"emilio","id":1323194,"avatar_url":"https://avatars.githubusercontent.com/u/1323194?v=3","gravatar_id":"","url":"https://api.github.com/users/emilio","html_url":"https://github.com/emilio","followers_url":"https://api.github.com/users/emilio/followers","following_url":"https://api.github.com/users/emilio/following{/other_user}","gists_url":"https://api.github.com/users/emilio/gists{/gist_id}","starred_url":"https://api.github.com/users/emilio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emilio/subscriptions","organizations_url":"https://api.github.com/users/emilio/orgs","repos_url":"https://api.github.com/users/emilio/repos","events_url":"https://api.github.com/users/emilio/events{/privacy}","received_events_url":"https://api.github.com/users/emilio/received_events","type":"User","site_admin":false},"assignees":[{"login":"emilio","id":1323194,"avatar_url":"https://avatars.githubusercontent.com/u/1323194?v=3","gravatar_id":"","url":"https://api.github.com/users/emilio","html_url":"https://github.com/emilio","followers_url":"https://api.github.com/users/emilio/followers","following_url":"https://api.github.com/users/emilio/following{/other_user}","gists_url":"https://api.github.com/users/emilio/gists{/gist_id}","starred_url":"https://api.github.com/users/emilio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emilio/subscriptions","organizations_url":"https://api.github.com/users/emilio/orgs","repos_url":"https://api.github.com/users/emilio/repos","events_url":"https://api.github.com/users/emilio/events{/privacy}","received_events_url":"https://api.github.com/users/emilio/received_events","type":"User","site_admin":false}],"milestone":null,"comments":16,"created_at":"2016-07-28T20:36:46Z","updated_at":"2016-07-29T18:53:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/servo/servo/pulls/12637","html_url":"https://github.com/servo/servo/pull/12637","diff_url":"https://github.com/servo/servo/pull/12637.diff","patch_url":"https://github.com/servo/servo/pull/12637.patch"},"body":"<!-- Please describe your changes on the following line: -->\r\n\r\nThe double-panic in #12553 may be caused by using a non-reentrant lock, which panics on reetry. This PR adds a reentrant lock type (slightly annoyingly, the implementation in std isn't exported) and uses it for logging. cc @jdm\r\n\r\n---\r\n<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->\r\n- [X] `./mach build -d` does not report any errors\r\n- [X] `./mach test-tidy` does not report any errors\r\n- [X] These changes fix #12619.\r\n- [X] These changes do not require tests because they are designed to remove a class of intermittents.\r\n\r\n<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/servo/servo/12637)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/servo/servo/issues/comments/236264053","html_url":"https://github.com/servo/servo/pull/12637#issuecomment-236264053","issue_url":"https://api.github.com/repos/servo/servo/issues/12637","id":236264053,"user":{"login":"bors-servo","id":4368172,"avatar_url":"https://avatars.githubusercontent.com/u/4368172?v=3","gravatar_id":"","url":"https://api.github.com/users/bors-servo","html_url":"https://github.com/bors-servo","followers_url":"https://api.github.com/users/bors-servo/followers","following_url":"https://api.github.com/users/bors-servo/following{/other_user}","gists_url":"https://api.github.com/users/bors-servo/gists{/gist_id}","starred_url":"https://api.github.com/users/bors-servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bors-servo/subscriptions","organizations_url":"https://api.github.com/users/bors-servo/orgs","repos_url":"https://api.github.com/users/bors-servo/repos","events_url":"https://api.github.com/users/bors-servo/events{/privacy}","received_events_url":"https://api.github.com/users/bors-servo/received_events","type":"User","site_admin":false},"created_at":"2016-07-29T18:53:11Z","updated_at":"2016-07-29T18:53:11Z","body":":sunny: Test successful - [arm32](http://build.servo.org/builders/arm32/builds/2228), [arm64](http://build.servo.org/builders/arm64/builds/2231), [linux-dev](http://build.servo.org/builders/linux-dev/builds/2278), [linux-rel](http://build.servo.org/builders/linux-rel/builds/2404), [mac-dev-unit](http://build.servo.org/builders/mac-dev-unit/builds/2310), [mac-rel-css](http://build.servo.org/builders/mac-rel-css/builds/2293), [mac-rel-wpt](http://build.servo.org/builders/mac-rel-wpt/builds/2367), [windows-dev](http://build.servo.org/builders/windows-dev/builds/176)"}}
{"actor":{"display_login":"bors-servo"}}