{"action":"created","issue":{"url":"https://api.github.com/repos/vega/vega-parser/issues/7","repository_url":"https://api.github.com/repos/vega/vega-parser","labels_url":"https://api.github.com/repos/vega/vega-parser/issues/7/labels{/name}","comments_url":"https://api.github.com/repos/vega/vega-parser/issues/7/comments","events_url":"https://api.github.com/repos/vega/vega-parser/issues/7/events","html_url":"https://github.com/vega/vega-parser/pull/7","id":193851770,"number":7,"title":"Expression functions for Vega-Lite selection predicates","user":{"login":"arvind","id":42262,"avatar_url":"https://avatars.githubusercontent.com/u/42262?v=3","gravatar_id":"","url":"https://api.github.com/users/arvind","html_url":"https://github.com/arvind","followers_url":"https://api.github.com/users/arvind/followers","following_url":"https://api.github.com/users/arvind/following{/other_user}","gists_url":"https://api.github.com/users/arvind/gists{/gist_id}","starred_url":"https://api.github.com/users/arvind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arvind/subscriptions","organizations_url":"https://api.github.com/users/arvind/orgs","repos_url":"https://api.github.com/users/arvind/repos","events_url":"https://api.github.com/users/arvind/events{/privacy}","received_events_url":"https://api.github.com/users/arvind/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"jheer","id":202799,"avatar_url":"https://avatars.githubusercontent.com/u/202799?v=3","gravatar_id":"","url":"https://api.github.com/users/jheer","html_url":"https://github.com/jheer","followers_url":"https://api.github.com/users/jheer/followers","following_url":"https://api.github.com/users/jheer/following{/other_user}","gists_url":"https://api.github.com/users/jheer/gists{/gist_id}","starred_url":"https://api.github.com/users/jheer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jheer/subscriptions","organizations_url":"https://api.github.com/users/jheer/orgs","repos_url":"https://api.github.com/users/jheer/repos","events_url":"https://api.github.com/users/jheer/events{/privacy}","received_events_url":"https://api.github.com/users/jheer/received_events","type":"User","site_admin":false},"assignees":[{"login":"jheer","id":202799,"avatar_url":"https://avatars.githubusercontent.com/u/202799?v=3","gravatar_id":"","url":"https://api.github.com/users/jheer","html_url":"https://github.com/jheer","followers_url":"https://api.github.com/users/jheer/followers","following_url":"https://api.github.com/users/jheer/following{/other_user}","gists_url":"https://api.github.com/users/jheer/gists{/gist_id}","starred_url":"https://api.github.com/users/jheer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jheer/subscriptions","organizations_url":"https://api.github.com/users/jheer/orgs","repos_url":"https://api.github.com/users/jheer/repos","events_url":"https://api.github.com/users/jheer/events{/privacy}","received_events_url":"https://api.github.com/users/jheer/received_events","type":"User","site_admin":false}],"milestone":null,"comments":4,"created_at":"2016-12-06T18:42:55Z","updated_at":"2016-12-24T07:13:13Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/vega/vega-parser/pulls/7","html_url":"https://github.com/vega/vega-parser/pull/7","diff_url":"https://github.com/vega/vega-parser/pull/7.diff","patch_url":"https://github.com/vega/vega-parser/pull/7.patch"},"body":"This is a work-in-progress PR to initiate code review on my approach before I go too far down the wrong path. \r\n\r\n**Changes Proposed**\r\n* `lookupRef` `TupleIndex` operators stored and annotated as `lookup` (alongside `index` for `indataRef`). \r\n* An `inIntervalSelection(name, unit, datum, resolve)` expression function to test for inclusion within a Vega-Lite interval selection. \r\n* An `inPointSelection(name, unit, datum, fields, resolve)` expression function to test for inclusion within a Vega-Lite point (single/multi) selection.\r\n\r\n**Questions**\r\n1. The indenting style of `codegen.js` is non-standard to me (function bodies indented by 4 rather than 2, and closing braces indented by 2 rather than being flush against the header). I wanted to double check this was intentional, as it repeatedly confused my text editor.\r\n2. I was not able to find any test cases for functions defined in `codegen.js`? Seems worth investing some time here given the increased surface area of this module and the higher-level dependencies?"},"comment":{"url":"https://api.github.com/repos/vega/vega-parser/issues/comments/269072808","html_url":"https://github.com/vega/vega-parser/pull/7#issuecomment-269072808","issue_url":"https://api.github.com/repos/vega/vega-parser/issues/7","id":269072808,"user":{"login":"arvind","id":42262,"avatar_url":"https://avatars.githubusercontent.com/u/42262?v=3","gravatar_id":"","url":"https://api.github.com/users/arvind","html_url":"https://github.com/arvind","followers_url":"https://api.github.com/users/arvind/followers","following_url":"https://api.github.com/users/arvind/following{/other_user}","gists_url":"https://api.github.com/users/arvind/gists{/gist_id}","starred_url":"https://api.github.com/users/arvind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arvind/subscriptions","organizations_url":"https://api.github.com/users/arvind/orgs","repos_url":"https://api.github.com/users/arvind/repos","events_url":"https://api.github.com/users/arvind/events{/privacy}","received_events_url":"https://api.github.com/users/arvind/received_events","type":"User","site_admin":false},"created_at":"2016-12-24T07:13:13Z","updated_at":"2016-12-24T07:13:13Z","body":"With the second example, I also noticed a couple of issues with event propagation and I'm unsure if it is expected behaviour or not:\r\n\r\n1. If the event trigger for the `cell` signal is switched to `@cell:mousedown` (instead of the current `mousemove`), and you click a symbol mark, the signal value remains `null` rather than updating with the symbol's group item. \r\n2. The event trigger for the `multi_key` signal includes a manual filter to filter for marks named `circle`. However, if I switch it to use the selector syntax (`\"type\": \"@circle:click\"`), the signal is no longer updated. "}}
{"actor":{"display_login":"arvind"}}