{"action":"created","issue":{"url":"https://api.github.com/repos/swcarpentry/r-novice-gapminder/issues/120","repository_url":"https://api.github.com/repos/swcarpentry/r-novice-gapminder","labels_url":"https://api.github.com/repos/swcarpentry/r-novice-gapminder/issues/120/labels{/name}","comments_url":"https://api.github.com/repos/swcarpentry/r-novice-gapminder/issues/120/comments","events_url":"https://api.github.com/repos/swcarpentry/r-novice-gapminder/issues/120/events","html_url":"https://github.com/swcarpentry/r-novice-gapminder/issues/120","id":156857328,"number":120,"title":"`if` syntax is used in lesson 07-functions before lesson 10-control-flow","user":{"login":"stevenhwu","id":1005078,"avatar_url":"https://avatars.githubusercontent.com/u/1005078?v=3","gravatar_id":"","url":"https://api.github.com/users/stevenhwu","html_url":"https://github.com/stevenhwu","followers_url":"https://api.github.com/users/stevenhwu/followers","following_url":"https://api.github.com/users/stevenhwu/following{/other_user}","gists_url":"https://api.github.com/users/stevenhwu/gists{/gist_id}","starred_url":"https://api.github.com/users/stevenhwu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevenhwu/subscriptions","organizations_url":"https://api.github.com/users/stevenhwu/orgs","repos_url":"https://api.github.com/users/stevenhwu/repos","events_url":"https://api.github.com/users/stevenhwu/events{/privacy}","received_events_url":"https://api.github.com/users/stevenhwu/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/swcarpentry/r-novice-gapminder/milestones/1","html_url":"https://github.com/swcarpentry/r-novice-gapminder/milestones/Version%205.4","labels_url":"https://api.github.com/repos/swcarpentry/r-novice-gapminder/milestones/1/labels","id":1740330,"number":1,"title":"Version 5.4","description":"Issues and PRs to resolve for Version 5.4 release.","creator":{"login":"naupaka","id":1428071,"avatar_url":"https://avatars.githubusercontent.com/u/1428071?v=3","gravatar_id":"","url":"https://api.github.com/users/naupaka","html_url":"https://github.com/naupaka","followers_url":"https://api.github.com/users/naupaka/followers","following_url":"https://api.github.com/users/naupaka/following{/other_user}","gists_url":"https://api.github.com/users/naupaka/gists{/gist_id}","starred_url":"https://api.github.com/users/naupaka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/naupaka/subscriptions","organizations_url":"https://api.github.com/users/naupaka/orgs","repos_url":"https://api.github.com/users/naupaka/repos","events_url":"https://api.github.com/users/naupaka/events{/privacy}","received_events_url":"https://api.github.com/users/naupaka/received_events","type":"User","site_admin":false},"open_issues":10,"closed_issues":7,"state":"open","created_at":"2016-04-30T23:02:07Z","updated_at":"2016-06-13T17:08:10Z","due_on":"2016-06-14T04:00:00Z","closed_at":null},"comments":2,"created_at":"2016-05-25T21:43:25Z","updated_at":"2016-06-13T17:23:11Z","closed_at":null,"body":"Based on the current order, lesson `07-functions` will be covered before `10-control-flow`.\r\nHowever, in the second half of the lesson, the `if` statement is used in the function, which is not properly introduced until lesson `10-control-flow`\r\n```\r\ncalcGDP <- function(dat, year=NULL, country=NULL) {\r\n  if(!is.null(year)) {\r\n    dat <- dat[dat$year %in% year, ]\r\n  }\r\n  ...\r\n```\r\nIt might make more sense to switch the order around. There are several ways to get around this, here are just a few of them;\r\n- Design a different example without `if`\r\n- Switch lesson 7 and 10\r\n- Introduce `if`, follow by functions, then `for`\r\n- Revisit functions after `if` and `for`."},"comment":{"url":"https://api.github.com/repos/swcarpentry/r-novice-gapminder/issues/comments/225649518","html_url":"https://github.com/swcarpentry/r-novice-gapminder/issues/120#issuecomment-225649518","issue_url":"https://api.github.com/repos/swcarpentry/r-novice-gapminder/issues/120","id":225649518,"user":{"login":"marcsze","id":14898468,"avatar_url":"https://avatars.githubusercontent.com/u/14898468?v=3","gravatar_id":"","url":"https://api.github.com/users/marcsze","html_url":"https://github.com/marcsze","followers_url":"https://api.github.com/users/marcsze/followers","following_url":"https://api.github.com/users/marcsze/following{/other_user}","gists_url":"https://api.github.com/users/marcsze/gists{/gist_id}","starred_url":"https://api.github.com/users/marcsze/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcsze/subscriptions","organizations_url":"https://api.github.com/users/marcsze/orgs","repos_url":"https://api.github.com/users/marcsze/repos","events_url":"https://api.github.com/users/marcsze/events{/privacy}","received_events_url":"https://api.github.com/users/marcsze/received_events","type":"User","site_admin":false},"created_at":"2016-06-13T17:23:11Z","updated_at":"2016-06-13T17:23:11Z","body":"Umich is taking a shot at this issue"}}
{"actor":{"display_login":"marcsze"}}