{"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/pulls/comments/89495251","pull_request_review_id":10040159,"id":89495251,"diff_hunk":"@@ -0,0 +1,8 @@\n+.deleteTab {","path":"client/app/components/dialog-editor-tabs/_dialog-editor-tabs.scss","position":1,"original_position":1,"commit_id":"fc0ab8ca818ddb23517c0ed0fa057d5d1feb4dc0","original_commit_id":"fc0ab8ca818ddb23517c0ed0fa057d5d1feb4dc0","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Selector `deleteTab` should be written in lowercase with hyphens","created_at":"2016-11-24T13:13:40Z","updated_at":"2016-11-24T13:13:40Z","html_url":"https://github.com/ManageIQ/manageiq-ui-service/pull/54#discussion_r89495251","pull_request_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/pulls/54","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/pulls/comments/89495251"},"html":{"href":"https://github.com/ManageIQ/manageiq-ui-service/pull/54#discussion_r89495251"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/pulls/54"}}},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/pulls/54","id":70951237,"html_url":"https://github.com/ManageIQ/manageiq-ui-service/pull/54","diff_url":"https://github.com/ManageIQ/manageiq-ui-service/pull/54.diff","patch_url":"https://github.com/ManageIQ/manageiq-ui-service/pull/54.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/issues/54","number":54,"state":"open","locked":false,"title":"[WIP] Dialog Editor","user":{"login":"romanblanco","id":1187051,"avatar_url":"https://avatars.githubusercontent.com/u/1187051?v=3","gravatar_id":"","url":"https://api.github.com/users/romanblanco","html_url":"https://github.com/romanblanco","followers_url":"https://api.github.com/users/romanblanco/followers","following_url":"https://api.github.com/users/romanblanco/following{/other_user}","gists_url":"https://api.github.com/users/romanblanco/gists{/gist_id}","starred_url":"https://api.github.com/users/romanblanco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romanblanco/subscriptions","organizations_url":"https://api.github.com/users/romanblanco/orgs","repos_url":"https://api.github.com/users/romanblanco/repos","events_url":"https://api.github.com/users/romanblanco/events{/privacy}","received_events_url":"https://api.github.com/users/romanblanco/received_events","type":"User","site_admin":false},"body":"**TODO**: \n- _required_:\n  - [x] specs\n  - [x] edit values in placeholders\n  - [x] edit tab name & description\n  - [x] edit box name & description\n  - [x] saving changes is not yet possible due to missing support in API\n    - [x] add _Create_ button to list state\n    - [x] add _Delete_ button to detail state\n    - [x] add _Save_ button to edit state\n  - [ ] remove `[devel]`, `[tmp]` and `[WIP]` tags from commits\n\n---\n- _optional (could be done in next PR)_:\n  - [x] tabs in component detail modal\n  -  correct breadcrumbs on edit state (they are reditecting to list instead of detail\n  - [x] dislpay arrows on dialog elements only on mouse hover\n  -  edit default values outside of modal\n  -  `?` edit labels by double click\n  -  drag&drop between boxes (`?` + new element to remove elements by dragging them to it)\n  -  detect position for dragged element (now it adds to the end)\n  -  handler icon for sorting\n  - [x] `?` rename related components to use same prefix\n  -  more consistent method names (_remove_ / _delete_, etc.)\n  -  undo removal of tabs/boxes\n  -  gray out date/datetime control, if one of them are already present in the dialog\n  -  move buttons _Create tab_ and _Create box_ to Toolbox\n  - display to which services is dialog connected in Detail state\n  - disable editing of datepicker in preview\n  - hints for inputs\n  - validate inputs\n  - automatically set `name` from `label` (This name => this_name)\n  - set default values (bootstrap stwitch with no value looks weird)\n","created_at":"2016-05-21T14:44:55Z","updated_at":"2016-11-24T13:13:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"346c1b82ca6077600f526ba22a6c5377f6ebff99","assignee":{"login":"chriskacerguis","id":2414647,"avatar_url":"https://avatars.githubusercontent.com/u/2414647?v=3","gravatar_id":"","url":"https://api.github.com/users/chriskacerguis","html_url":"https://github.com/chriskacerguis","followers_url":"https://api.github.com/users/chriskacerguis/followers","following_url":"https://api.github.com/users/chriskacerguis/following{/other_user}","gists_url":"https://api.github.com/users/chriskacerguis/gists{/gist_id}","starred_url":"https://api.github.com/users/chriskacerguis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chriskacerguis/subscriptions","organizations_url":"https://api.github.com/users/chriskacerguis/orgs","repos_url":"https://api.github.com/users/chriskacerguis/repos","events_url":"https://api.github.com/users/chriskacerguis/events{/privacy}","received_events_url":"https://api.github.com/users/chriskacerguis/received_events","type":"User","site_admin":false},"assignees":[{"login":"chriskacerguis","id":2414647,"avatar_url":"https://avatars.githubusercontent.com/u/2414647?v=3","gravatar_id":"","url":"https://api.github.com/users/chriskacerguis","html_url":"https://github.com/chriskacerguis","followers_url":"https://api.github.com/users/chriskacerguis/followers","following_url":"https://api.github.com/users/chriskacerguis/following{/other_user}","gists_url":"https://api.github.com/users/chriskacerguis/gists{/gist_id}","starred_url":"https://api.github.com/users/chriskacerguis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chriskacerguis/subscriptions","organizations_url":"https://api.github.com/users/chriskacerguis/orgs","repos_url":"https://api.github.com/users/chriskacerguis/repos","events_url":"https://api.github.com/users/chriskacerguis/events{/privacy}","received_events_url":"https://api.github.com/users/chriskacerguis/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/pulls/54/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/pulls/54/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/issues/54/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/statuses/fc0ab8ca818ddb23517c0ed0fa057d5d1feb4dc0","head":{"label":"romanblanco:dialog_editor","ref":"dialog_editor","sha":"fc0ab8ca818ddb23517c0ed0fa057d5d1feb4dc0","user":{"login":"romanblanco","id":1187051,"avatar_url":"https://avatars.githubusercontent.com/u/1187051?v=3","gravatar_id":"","url":"https://api.github.com/users/romanblanco","html_url":"https://github.com/romanblanco","followers_url":"https://api.github.com/users/romanblanco/followers","following_url":"https://api.github.com/users/romanblanco/following{/other_user}","gists_url":"https://api.github.com/users/romanblanco/gists{/gist_id}","starred_url":"https://api.github.com/users/romanblanco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romanblanco/subscriptions","organizations_url":"https://api.github.com/users/romanblanco/orgs","repos_url":"https://api.github.com/users/romanblanco/repos","events_url":"https://api.github.com/users/romanblanco/events{/privacy}","received_events_url":"https://api.github.com/users/romanblanco/received_events","type":"User","site_admin":false},"repo":{"id":51579605,"name":"manageiq-ui-service","full_name":"romanblanco/manageiq-ui-service","owner":{"login":"romanblanco","id":1187051,"avatar_url":"https://avatars.githubusercontent.com/u/1187051?v=3","gravatar_id":"","url":"https://api.github.com/users/romanblanco","html_url":"https://github.com/romanblanco","followers_url":"https://api.github.com/users/romanblanco/followers","following_url":"https://api.github.com/users/romanblanco/following{/other_user}","gists_url":"https://api.github.com/users/romanblanco/gists{/gist_id}","starred_url":"https://api.github.com/users/romanblanco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romanblanco/subscriptions","organizations_url":"https://api.github.com/users/romanblanco/orgs","repos_url":"https://api.github.com/users/romanblanco/repos","events_url":"https://api.github.com/users/romanblanco/events{/privacy}","received_events_url":"https://api.github.com/users/romanblanco/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/romanblanco/manageiq-ui-service","description":"Self service UI for ManageIQ","fork":true,"url":"https://api.github.com/repos/romanblanco/manageiq-ui-service","forks_url":"https://api.github.com/repos/romanblanco/manageiq-ui-service/forks","keys_url":"https://api.github.com/repos/romanblanco/manageiq-ui-service/keys{/key_id}","collaborators_url":"https://api.github.com/repos/romanblanco/manageiq-ui-service/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/romanblanco/manageiq-ui-service/teams","hooks_url":"https://api.github.com/repos/romanblanco/manageiq-ui-service/hooks","issue_events_url":"https://api.github.com/repos/romanblanco/manageiq-ui-service/issues/events{/number}","events_url":"https://api.github.com/repos/romanblanco/manageiq-ui-service/events","assignees_url":"https://api.github.com/repos/romanblanco/manageiq-ui-service/assignees{/user}","branches_url":"https://api.github.com/repos/romanblanco/manageiq-ui-service/branches{/branch}","tags_url":"https://api.github.com/repos/romanblanco/manageiq-ui-service/tags","blobs_url":"https://api.github.com/repos/romanblanco/manageiq-ui-service/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/romanblanco/manageiq-ui-service/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/romanblanco/manageiq-ui-service/git/refs{/sha}","trees_url":"https://api.github.com/repos/romanblanco/manageiq-ui-service/git/trees{/sha}","statuses_url":"https://api.github.com/repos/romanblanco/manageiq-ui-service/statuses/{sha}","languages_url":"https://api.github.com/repos/romanblanco/manageiq-ui-service/languages","stargazers_url":"https://api.github.com/repos/romanblanco/manageiq-ui-service/stargazers","contributors_url":"https://api.github.com/repos/romanblanco/manageiq-ui-service/contributors","subscribers_url":"https://api.github.com/repos/romanblanco/manageiq-ui-service/subscribers","subscription_url":"https://api.github.com/repos/romanblanco/manageiq-ui-service/subscription","commits_url":"https://api.github.com/repos/romanblanco/manageiq-ui-service/commits{/sha}","git_commits_url":"https://api.github.com/repos/romanblanco/manageiq-ui-service/git/commits{/sha}","comments_url":"https://api.github.com/repos/romanblanco/manageiq-ui-service/comments{/number}","issue_comment_url":"https://api.github.com/repos/romanblanco/manageiq-ui-service/issues/comments{/number}","contents_url":"https://api.github.com/repos/romanblanco/manageiq-ui-service/contents/{+path}","compare_url":"https://api.github.com/repos/romanblanco/manageiq-ui-service/compare/{base}...{head}","merges_url":"https://api.github.com/repos/romanblanco/manageiq-ui-service/merges","archive_url":"https://api.github.com/repos/romanblanco/manageiq-ui-service/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/romanblanco/manageiq-ui-service/downloads","issues_url":"https://api.github.com/repos/romanblanco/manageiq-ui-service/issues{/number}","pulls_url":"https://api.github.com/repos/romanblanco/manageiq-ui-service/pulls{/number}","milestones_url":"https://api.github.com/repos/romanblanco/manageiq-ui-service/milestones{/number}","notifications_url":"https://api.github.com/repos/romanblanco/manageiq-ui-service/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/romanblanco/manageiq-ui-service/labels{/name}","releases_url":"https://api.github.com/repos/romanblanco/manageiq-ui-service/releases{/id}","deployments_url":"https://api.github.com/repos/romanblanco/manageiq-ui-service/deployments","created_at":"2016-02-12T10:04:01Z","updated_at":"2016-11-06T22:00:50Z","pushed_at":"2016-11-24T13:13:28Z","git_url":"git://github.com/romanblanco/manageiq-ui-service.git","ssh_url":"git@github.com:romanblanco/manageiq-ui-service.git","clone_url":"https://github.com/romanblanco/manageiq-ui-service.git","svn_url":"https://github.com/romanblanco/manageiq-ui-service","homepage":"","size":3740,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"581c3db70a44464b5d37f61ec9cc46cc83ed155a","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":51539656,"name":"manageiq-ui-service","full_name":"ManageIQ/manageiq-ui-service","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq-ui-service","description":"Service UI for ManageIQ","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service","forks_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/releases{/id}","deployments_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/deployments","created_at":"2016-02-11T19:17:13Z","updated_at":"2016-11-24T01:36:43Z","pushed_at":"2016-11-24T13:13:29Z","git_url":"git://github.com/ManageIQ/manageiq-ui-service.git","ssh_url":"git@github.com:ManageIQ/manageiq-ui-service.git","clone_url":"https://github.com/ManageIQ/manageiq-ui-service.git","svn_url":"https://github.com/ManageIQ/manageiq-ui-service","homepage":"","size":4226,"stargazers_count":9,"watchers_count":9,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":34,"mirror_url":null,"open_issues_count":3,"forks":34,"open_issues":3,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/pulls/54"},"html":{"href":"https://github.com/ManageIQ/manageiq-ui-service/pull/54"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/issues/54"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/issues/54/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/pulls/54/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/pulls/54/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/statuses/fc0ab8ca818ddb23517c0ed0fa057d5d1feb4dc0"}}}}
{"actor":{"display_login":"houndci-bot"}}