{"action":"created","comment":{"url":"https://api.github.com/repos/neos/Neos.Cqrs/pulls/comments/87159100","pull_request_review_id":7781331,"id":87159100,"diff_hunk":"@@ -42,8 +42,8 @@\n     public static function reconstituteFromEventStream(string $identifier, EventStream $stream)\n     {\n         $instance = new static($identifier);\n-        foreach ($stream as $eventWithMetadata) {\n-            $instance->apply($eventWithMetadata->getEvent());\n+        foreach ($stream as $eventTransport) {\n+            $instance->apply($eventTransport->getEvent());","path":"Classes/Domain/AbstractEventSourcedAggregateRoot.php","position":7,"original_position":7,"commit_id":"5d6aa6863c31f06af1737e9ba60f60af05d20103","original_commit_id":"62a75337d5d94d4fec9ea1d6d96ad8b1cb823638","user":{"login":"dfeyer","id":221173,"avatar_url":"https://avatars.githubusercontent.com/u/221173?v=3","gravatar_id":"","url":"https://api.github.com/users/dfeyer","html_url":"https://github.com/dfeyer","followers_url":"https://api.github.com/users/dfeyer/followers","following_url":"https://api.github.com/users/dfeyer/following{/other_user}","gists_url":"https://api.github.com/users/dfeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/dfeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dfeyer/subscriptions","organizations_url":"https://api.github.com/users/dfeyer/orgs","repos_url":"https://api.github.com/users/dfeyer/repos","events_url":"https://api.github.com/users/dfeyer/events{/privacy}","received_events_url":"https://api.github.com/users/dfeyer/received_events","type":"User","site_admin":false},"body":"In many C# or JAVA implementation, they call this kind of object Enveloppe even more abstract. From my POV the name should say what the object does, without going into too much details. And the implementation need to be consistent ... if we need to transport event with metadata data we should stick to this object all the time. ","created_at":"2016-11-09T09:42:32Z","updated_at":"2016-11-09T09:42:32Z","html_url":"https://github.com/neos/Neos.Cqrs/pull/95#discussion_r87159100","pull_request_url":"https://api.github.com/repos/neos/Neos.Cqrs/pulls/95","_links":{"self":{"href":"https://api.github.com/repos/neos/Neos.Cqrs/pulls/comments/87159100"},"html":{"href":"https://github.com/neos/Neos.Cqrs/pull/95#discussion_r87159100"},"pull_request":{"href":"https://api.github.com/repos/neos/Neos.Cqrs/pulls/95"}}},"pull_request":{"url":"https://api.github.com/repos/neos/Neos.Cqrs/pulls/95","id":92616606,"html_url":"https://github.com/neos/Neos.Cqrs/pull/95","diff_url":"https://github.com/neos/Neos.Cqrs/pull/95.diff","patch_url":"https://github.com/neos/Neos.Cqrs/pull/95.patch","issue_url":"https://api.github.com/repos/neos/Neos.Cqrs/issues/95","number":95,"state":"open","locked":false,"title":"FEATURE: Allow enrichment of event metadata","user":{"login":"bwaidelich","id":307571,"avatar_url":"https://avatars.githubusercontent.com/u/307571?v=3","gravatar_id":"","url":"https://api.github.com/users/bwaidelich","html_url":"https://github.com/bwaidelich","followers_url":"https://api.github.com/users/bwaidelich/followers","following_url":"https://api.github.com/users/bwaidelich/following{/other_user}","gists_url":"https://api.github.com/users/bwaidelich/gists{/gist_id}","starred_url":"https://api.github.com/users/bwaidelich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bwaidelich/subscriptions","organizations_url":"https://api.github.com/users/bwaidelich/orgs","repos_url":"https://api.github.com/users/bwaidelich/repos","events_url":"https://api.github.com/users/bwaidelich/events{/privacy}","received_events_url":"https://api.github.com/users/bwaidelich/received_events","type":"User","site_admin":false},"body":"Usage::\r\n\r\n    $dispatcher = $bootstrap->getSignalSlotDispatcher();\r\n    $dispatcher->connect(EventPublisher::class, 'publishEvent', function(EventInterface $event, array &$metadata) use ($bootstrap) {\r\n        $requestHandler = $bootstrap->getActiveRequestHandler();\r\n        if (!$requestHandler instanceof HttpRequestHandlerInterface) {\r\n            return;\r\n        }\r\n        $request = $requestHandler->getHttpRequest();\r\n        $metadata['ipAddress'] = $request->getClientIpAddress();\r\n    });\r\n\r\nWIP","created_at":"2016-11-07T16:30:58Z","updated_at":"2016-11-09T09:42:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"432142ef7b98d40c74a3ea93c2814f7ba42e12a8","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/neos/Neos.Cqrs/pulls/95/commits","review_comments_url":"https://api.github.com/repos/neos/Neos.Cqrs/pulls/95/comments","review_comment_url":"https://api.github.com/repos/neos/Neos.Cqrs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/neos/Neos.Cqrs/issues/95/comments","statuses_url":"https://api.github.com/repos/neos/Neos.Cqrs/statuses/5d6aa6863c31f06af1737e9ba60f60af05d20103","head":{"label":"bwaidelich:88-metadata-enrichment","ref":"88-metadata-enrichment","sha":"5d6aa6863c31f06af1737e9ba60f60af05d20103","user":{"login":"bwaidelich","id":307571,"avatar_url":"https://avatars.githubusercontent.com/u/307571?v=3","gravatar_id":"","url":"https://api.github.com/users/bwaidelich","html_url":"https://github.com/bwaidelich","followers_url":"https://api.github.com/users/bwaidelich/followers","following_url":"https://api.github.com/users/bwaidelich/following{/other_user}","gists_url":"https://api.github.com/users/bwaidelich/gists{/gist_id}","starred_url":"https://api.github.com/users/bwaidelich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bwaidelich/subscriptions","organizations_url":"https://api.github.com/users/bwaidelich/orgs","repos_url":"https://api.github.com/users/bwaidelich/repos","events_url":"https://api.github.com/users/bwaidelich/events{/privacy}","received_events_url":"https://api.github.com/users/bwaidelich/received_events","type":"User","site_admin":false},"repo":{"id":69946151,"name":"Neos.Cqrs","full_name":"bwaidelich/Neos.Cqrs","owner":{"login":"bwaidelich","id":307571,"avatar_url":"https://avatars.githubusercontent.com/u/307571?v=3","gravatar_id":"","url":"https://api.github.com/users/bwaidelich","html_url":"https://github.com/bwaidelich","followers_url":"https://api.github.com/users/bwaidelich/followers","following_url":"https://api.github.com/users/bwaidelich/following{/other_user}","gists_url":"https://api.github.com/users/bwaidelich/gists{/gist_id}","starred_url":"https://api.github.com/users/bwaidelich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bwaidelich/subscriptions","organizations_url":"https://api.github.com/users/bwaidelich/orgs","repos_url":"https://api.github.com/users/bwaidelich/repos","events_url":"https://api.github.com/users/bwaidelich/events{/privacy}","received_events_url":"https://api.github.com/users/bwaidelich/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bwaidelich/Neos.Cqrs","description":null,"fork":true,"url":"https://api.github.com/repos/bwaidelich/Neos.Cqrs","forks_url":"https://api.github.com/repos/bwaidelich/Neos.Cqrs/forks","keys_url":"https://api.github.com/repos/bwaidelich/Neos.Cqrs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bwaidelich/Neos.Cqrs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bwaidelich/Neos.Cqrs/teams","hooks_url":"https://api.github.com/repos/bwaidelich/Neos.Cqrs/hooks","issue_events_url":"https://api.github.com/repos/bwaidelich/Neos.Cqrs/issues/events{/number}","events_url":"https://api.github.com/repos/bwaidelich/Neos.Cqrs/events","assignees_url":"https://api.github.com/repos/bwaidelich/Neos.Cqrs/assignees{/user}","branches_url":"https://api.github.com/repos/bwaidelich/Neos.Cqrs/branches{/branch}","tags_url":"https://api.github.com/repos/bwaidelich/Neos.Cqrs/tags","blobs_url":"https://api.github.com/repos/bwaidelich/Neos.Cqrs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bwaidelich/Neos.Cqrs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bwaidelich/Neos.Cqrs/git/refs{/sha}","trees_url":"https://api.github.com/repos/bwaidelich/Neos.Cqrs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bwaidelich/Neos.Cqrs/statuses/{sha}","languages_url":"https://api.github.com/repos/bwaidelich/Neos.Cqrs/languages","stargazers_url":"https://api.github.com/repos/bwaidelich/Neos.Cqrs/stargazers","contributors_url":"https://api.github.com/repos/bwaidelich/Neos.Cqrs/contributors","subscribers_url":"https://api.github.com/repos/bwaidelich/Neos.Cqrs/subscribers","subscription_url":"https://api.github.com/repos/bwaidelich/Neos.Cqrs/subscription","commits_url":"https://api.github.com/repos/bwaidelich/Neos.Cqrs/commits{/sha}","git_commits_url":"https://api.github.com/repos/bwaidelich/Neos.Cqrs/git/commits{/sha}","comments_url":"https://api.github.com/repos/bwaidelich/Neos.Cqrs/comments{/number}","issue_comment_url":"https://api.github.com/repos/bwaidelich/Neos.Cqrs/issues/comments{/number}","contents_url":"https://api.github.com/repos/bwaidelich/Neos.Cqrs/contents/{+path}","compare_url":"https://api.github.com/repos/bwaidelich/Neos.Cqrs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bwaidelich/Neos.Cqrs/merges","archive_url":"https://api.github.com/repos/bwaidelich/Neos.Cqrs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bwaidelich/Neos.Cqrs/downloads","issues_url":"https://api.github.com/repos/bwaidelich/Neos.Cqrs/issues{/number}","pulls_url":"https://api.github.com/repos/bwaidelich/Neos.Cqrs/pulls{/number}","milestones_url":"https://api.github.com/repos/bwaidelich/Neos.Cqrs/milestones{/number}","notifications_url":"https://api.github.com/repos/bwaidelich/Neos.Cqrs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bwaidelich/Neos.Cqrs/labels{/name}","releases_url":"https://api.github.com/repos/bwaidelich/Neos.Cqrs/releases{/id}","deployments_url":"https://api.github.com/repos/bwaidelich/Neos.Cqrs/deployments","created_at":"2016-10-04T08:20:56Z","updated_at":"2016-10-04T08:20:57Z","pushed_at":"2016-11-08T21:24:59Z","git_url":"git://github.com/bwaidelich/Neos.Cqrs.git","ssh_url":"git@github.com:bwaidelich/Neos.Cqrs.git","clone_url":"https://github.com/bwaidelich/Neos.Cqrs.git","svn_url":"https://github.com/bwaidelich/Neos.Cqrs","homepage":null,"size":291,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"neos:master","ref":"master","sha":"6dd14edbb20e655b96078fc0f463034569cec3db","user":{"login":"neos","id":11575267,"avatar_url":"https://avatars.githubusercontent.com/u/11575267?v=3","gravatar_id":"","url":"https://api.github.com/users/neos","html_url":"https://github.com/neos","followers_url":"https://api.github.com/users/neos/followers","following_url":"https://api.github.com/users/neos/following{/other_user}","gists_url":"https://api.github.com/users/neos/gists{/gist_id}","starred_url":"https://api.github.com/users/neos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neos/subscriptions","organizations_url":"https://api.github.com/users/neos/orgs","repos_url":"https://api.github.com/users/neos/repos","events_url":"https://api.github.com/users/neos/events{/privacy}","received_events_url":"https://api.github.com/users/neos/received_events","type":"Organization","site_admin":false},"repo":{"id":67050550,"name":"Neos.Cqrs","full_name":"neos/Neos.Cqrs","owner":{"login":"neos","id":11575267,"avatar_url":"https://avatars.githubusercontent.com/u/11575267?v=3","gravatar_id":"","url":"https://api.github.com/users/neos","html_url":"https://github.com/neos","followers_url":"https://api.github.com/users/neos/followers","following_url":"https://api.github.com/users/neos/following{/other_user}","gists_url":"https://api.github.com/users/neos/gists{/gist_id}","starred_url":"https://api.github.com/users/neos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neos/subscriptions","organizations_url":"https://api.github.com/users/neos/orgs","repos_url":"https://api.github.com/users/neos/repos","events_url":"https://api.github.com/users/neos/events{/privacy}","received_events_url":"https://api.github.com/users/neos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/neos/Neos.Cqrs","description":null,"fork":false,"url":"https://api.github.com/repos/neos/Neos.Cqrs","forks_url":"https://api.github.com/repos/neos/Neos.Cqrs/forks","keys_url":"https://api.github.com/repos/neos/Neos.Cqrs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neos/Neos.Cqrs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neos/Neos.Cqrs/teams","hooks_url":"https://api.github.com/repos/neos/Neos.Cqrs/hooks","issue_events_url":"https://api.github.com/repos/neos/Neos.Cqrs/issues/events{/number}","events_url":"https://api.github.com/repos/neos/Neos.Cqrs/events","assignees_url":"https://api.github.com/repos/neos/Neos.Cqrs/assignees{/user}","branches_url":"https://api.github.com/repos/neos/Neos.Cqrs/branches{/branch}","tags_url":"https://api.github.com/repos/neos/Neos.Cqrs/tags","blobs_url":"https://api.github.com/repos/neos/Neos.Cqrs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neos/Neos.Cqrs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neos/Neos.Cqrs/git/refs{/sha}","trees_url":"https://api.github.com/repos/neos/Neos.Cqrs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neos/Neos.Cqrs/statuses/{sha}","languages_url":"https://api.github.com/repos/neos/Neos.Cqrs/languages","stargazers_url":"https://api.github.com/repos/neos/Neos.Cqrs/stargazers","contributors_url":"https://api.github.com/repos/neos/Neos.Cqrs/contributors","subscribers_url":"https://api.github.com/repos/neos/Neos.Cqrs/subscribers","subscription_url":"https://api.github.com/repos/neos/Neos.Cqrs/subscription","commits_url":"https://api.github.com/repos/neos/Neos.Cqrs/commits{/sha}","git_commits_url":"https://api.github.com/repos/neos/Neos.Cqrs/git/commits{/sha}","comments_url":"https://api.github.com/repos/neos/Neos.Cqrs/comments{/number}","issue_comment_url":"https://api.github.com/repos/neos/Neos.Cqrs/issues/comments{/number}","contents_url":"https://api.github.com/repos/neos/Neos.Cqrs/contents/{+path}","compare_url":"https://api.github.com/repos/neos/Neos.Cqrs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neos/Neos.Cqrs/merges","archive_url":"https://api.github.com/repos/neos/Neos.Cqrs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neos/Neos.Cqrs/downloads","issues_url":"https://api.github.com/repos/neos/Neos.Cqrs/issues{/number}","pulls_url":"https://api.github.com/repos/neos/Neos.Cqrs/pulls{/number}","milestones_url":"https://api.github.com/repos/neos/Neos.Cqrs/milestones{/number}","notifications_url":"https://api.github.com/repos/neos/Neos.Cqrs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neos/Neos.Cqrs/labels{/name}","releases_url":"https://api.github.com/repos/neos/Neos.Cqrs/releases{/id}","deployments_url":"https://api.github.com/repos/neos/Neos.Cqrs/deployments","created_at":"2016-08-31T15:33:57Z","updated_at":"2016-10-26T11:48:29Z","pushed_at":"2016-11-08T21:24:59Z","git_url":"git://github.com/neos/Neos.Cqrs.git","ssh_url":"git@github.com:neos/Neos.Cqrs.git","clone_url":"https://github.com/neos/Neos.Cqrs.git","svn_url":"https://github.com/neos/Neos.Cqrs","homepage":null,"size":316,"stargazers_count":4,"watchers_count":4,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":19,"forks":6,"open_issues":19,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/neos/Neos.Cqrs/pulls/95"},"html":{"href":"https://github.com/neos/Neos.Cqrs/pull/95"},"issue":{"href":"https://api.github.com/repos/neos/Neos.Cqrs/issues/95"},"comments":{"href":"https://api.github.com/repos/neos/Neos.Cqrs/issues/95/comments"},"review_comments":{"href":"https://api.github.com/repos/neos/Neos.Cqrs/pulls/95/comments"},"review_comment":{"href":"https://api.github.com/repos/neos/Neos.Cqrs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/neos/Neos.Cqrs/pulls/95/commits"},"statuses":{"href":"https://api.github.com/repos/neos/Neos.Cqrs/statuses/5d6aa6863c31f06af1737e9ba60f60af05d20103"}}}}
{"actor":{"display_login":"dfeyer"}}