{"action":"closed","number":1683,"pull_request":{"url":"https://api.github.com/repos/apache/kafka/pulls/1683","id":79384837,"html_url":"https://github.com/apache/kafka/pull/1683","diff_url":"https://github.com/apache/kafka/pull/1683.diff","patch_url":"https://github.com/apache/kafka/pull/1683.patch","issue_url":"https://api.github.com/repos/apache/kafka/issues/1683","number":1683,"state":"closed","locked":false,"title":"KAFKA-2063: Add possibility to bound fetch response size","user":{"login":"nepal","id":791273,"avatar_url":"https://avatars.githubusercontent.com/u/791273?v=3","gravatar_id":"","url":"https://api.github.com/users/nepal","html_url":"https://github.com/nepal","followers_url":"https://api.github.com/users/nepal/followers","following_url":"https://api.github.com/users/nepal/following{/other_user}","gists_url":"https://api.github.com/users/nepal/gists{/gist_id}","starred_url":"https://api.github.com/users/nepal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nepal/subscriptions","organizations_url":"https://api.github.com/users/nepal/orgs","repos_url":"https://api.github.com/users/nepal/repos","events_url":"https://api.github.com/users/nepal/events{/privacy}","received_events_url":"https://api.github.com/users/nepal/received_events","type":"User","site_admin":false},"body":"Details are:\r\n\r\n1. Protocol is extended with new version of FetchRequest with extra parameter limit_bytes.\r\n2. New config setting fetch.limit.bytes is added. It is set to zero by default (which means \"no limit\"), so we preserve old behaviour by default\r\n3. When broker receives FetchRequest with limit_bytes != 0, it performs random shuffle of partitions before reading is started. This way we can ensure that no starvation can happen for \"slow\" partitions\r\n4. For each partition we read up to max_bytes requested for this partition, even if current value of limit_bytes is greater than zero but less than max_bytes. This way we can properly handle case when next message in given partition is larger than current value of limit_bytes.\r\n\r\n \r\n     ","created_at":"2016-07-29T16:11:45Z","updated_at":"2016-08-30T13:41:56Z","closed_at":"2016-08-30T13:41:56Z","merged_at":null,"merge_commit_sha":"985a37e52b36ef89d52ef43d7cf742a3650e474b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/kafka/pulls/1683/commits","review_comments_url":"https://api.github.com/repos/apache/kafka/pulls/1683/comments","review_comment_url":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/kafka/issues/1683/comments","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/aa2e32b23fb581b162062614295b8f2cb5406e93","head":{"label":"nepal:fetch-request-add-limit","ref":"fetch-request-add-limit","sha":"aa2e32b23fb581b162062614295b8f2cb5406e93","user":{"login":"nepal","id":791273,"avatar_url":"https://avatars.githubusercontent.com/u/791273?v=3","gravatar_id":"","url":"https://api.github.com/users/nepal","html_url":"https://github.com/nepal","followers_url":"https://api.github.com/users/nepal/followers","following_url":"https://api.github.com/users/nepal/following{/other_user}","gists_url":"https://api.github.com/users/nepal/gists{/gist_id}","starred_url":"https://api.github.com/users/nepal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nepal/subscriptions","organizations_url":"https://api.github.com/users/nepal/orgs","repos_url":"https://api.github.com/users/nepal/repos","events_url":"https://api.github.com/users/nepal/events{/privacy}","received_events_url":"https://api.github.com/users/nepal/received_events","type":"User","site_admin":false},"repo":{"id":63328335,"name":"kafka","full_name":"nepal/kafka","owner":{"login":"nepal","id":791273,"avatar_url":"https://avatars.githubusercontent.com/u/791273?v=3","gravatar_id":"","url":"https://api.github.com/users/nepal","html_url":"https://github.com/nepal","followers_url":"https://api.github.com/users/nepal/followers","following_url":"https://api.github.com/users/nepal/following{/other_user}","gists_url":"https://api.github.com/users/nepal/gists{/gist_id}","starred_url":"https://api.github.com/users/nepal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nepal/subscriptions","organizations_url":"https://api.github.com/users/nepal/orgs","repos_url":"https://api.github.com/users/nepal/repos","events_url":"https://api.github.com/users/nepal/events{/privacy}","received_events_url":"https://api.github.com/users/nepal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nepal/kafka","description":"Mirror of Apache Kafka","fork":true,"url":"https://api.github.com/repos/nepal/kafka","forks_url":"https://api.github.com/repos/nepal/kafka/forks","keys_url":"https://api.github.com/repos/nepal/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nepal/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nepal/kafka/teams","hooks_url":"https://api.github.com/repos/nepal/kafka/hooks","issue_events_url":"https://api.github.com/repos/nepal/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/nepal/kafka/events","assignees_url":"https://api.github.com/repos/nepal/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/nepal/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/nepal/kafka/tags","blobs_url":"https://api.github.com/repos/nepal/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nepal/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nepal/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/nepal/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nepal/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/nepal/kafka/languages","stargazers_url":"https://api.github.com/repos/nepal/kafka/stargazers","contributors_url":"https://api.github.com/repos/nepal/kafka/contributors","subscribers_url":"https://api.github.com/repos/nepal/kafka/subscribers","subscription_url":"https://api.github.com/repos/nepal/kafka/subscription","commits_url":"https://api.github.com/repos/nepal/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/nepal/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/nepal/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/nepal/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/nepal/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/nepal/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nepal/kafka/merges","archive_url":"https://api.github.com/repos/nepal/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nepal/kafka/downloads","issues_url":"https://api.github.com/repos/nepal/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/nepal/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/nepal/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/nepal/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nepal/kafka/labels{/name}","releases_url":"https://api.github.com/repos/nepal/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/nepal/kafka/deployments","created_at":"2016-07-14T10:46:35Z","updated_at":"2016-07-14T10:46:40Z","pushed_at":"2016-08-15T12:49:00Z","git_url":"git://github.com/nepal/kafka.git","ssh_url":"git@github.com:nepal/kafka.git","clone_url":"https://github.com/nepal/kafka.git","svn_url":"https://github.com/nepal/kafka","homepage":null,"size":31941,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"trunk"}},"base":{"label":"apache:trunk","ref":"trunk","sha":"e49b3aee6b25b9b26275849c693d5dec41d6cf68","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":2211243,"name":"kafka","full_name":"apache/kafka","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/kafka","description":"Mirror of Apache Kafka","fork":false,"url":"https://api.github.com/repos/apache/kafka","forks_url":"https://api.github.com/repos/apache/kafka/forks","keys_url":"https://api.github.com/repos/apache/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/kafka/teams","hooks_url":"https://api.github.com/repos/apache/kafka/hooks","issue_events_url":"https://api.github.com/repos/apache/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/apache/kafka/events","assignees_url":"https://api.github.com/repos/apache/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/apache/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/apache/kafka/tags","blobs_url":"https://api.github.com/repos/apache/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/kafka/languages","stargazers_url":"https://api.github.com/repos/apache/kafka/stargazers","contributors_url":"https://api.github.com/repos/apache/kafka/contributors","subscribers_url":"https://api.github.com/repos/apache/kafka/subscribers","subscription_url":"https://api.github.com/repos/apache/kafka/subscription","commits_url":"https://api.github.com/repos/apache/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/apache/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/kafka/merges","archive_url":"https://api.github.com/repos/apache/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/kafka/downloads","issues_url":"https://api.github.com/repos/apache/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/apache/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/kafka/labels{/name}","releases_url":"https://api.github.com/repos/apache/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/apache/kafka/deployments","created_at":"2011-08-15T18:06:16Z","updated_at":"2016-08-30T08:23:54Z","pushed_at":"2016-08-30T13:37:35Z","git_url":"git://github.com/apache/kafka.git","ssh_url":"git@github.com:apache/kafka.git","clone_url":"https://github.com/apache/kafka.git","svn_url":"https://github.com/apache/kafka","homepage":null,"size":46558,"stargazers_count":3683,"watchers_count":3683,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2279,"mirror_url":"git://git.apache.org/kafka.git","open_issues_count":236,"forks":2279,"open_issues":236,"watchers":3683,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/1683"},"html":{"href":"https://github.com/apache/kafka/pull/1683"},"issue":{"href":"https://api.github.com/repos/apache/kafka/issues/1683"},"comments":{"href":"https://api.github.com/repos/apache/kafka/issues/1683/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/kafka/pulls/1683/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/kafka/pulls/1683/commits"},"statuses":{"href":"https://api.github.com/repos/apache/kafka/statuses/aa2e32b23fb581b162062614295b8f2cb5406e93"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":2,"review_comments":0,"commits":1,"additions":127,"deletions":22,"changed_files":19}}
{"actor":{"display_login":"nepal"}}