{"action":"created","comment":{"url":"https://api.github.com/repos/tux3/qTox/pulls/comments/72907358","id":72907358,"diff_hunk":"@@ -44,34 +57,42 @@ class IndexedList\n     {\n         return v.begin();\n     }\n+\n     inline const_iterator begin() const\n     {\n         return v.begin();\n     }\n+\n     inline const_iterator cbegin() const\n     {\n         return v.cbegin();\n     }\n+\n     inline iterator end()\n     {\n         return v.end();\n     }\n+\n     inline const_iterator end() const\n     {\n-        return v.end();\n+        return v.cend();","path":"src/core/indexedlist.h","position":68,"original_position":68,"commit_id":"b946fade5bb1406abdd7e6d3718811f0772ef0ec","original_commit_id":"b946fade5bb1406abdd7e6d3718811f0772ef0ec","user":{"login":"Diadlo","id":6306608,"avatar_url":"https://avatars.githubusercontent.com/u/6306608?v=3","gravatar_id":"","url":"https://api.github.com/users/Diadlo","html_url":"https://github.com/Diadlo","followers_url":"https://api.github.com/users/Diadlo/followers","following_url":"https://api.github.com/users/Diadlo/following{/other_user}","gists_url":"https://api.github.com/users/Diadlo/gists{/gist_id}","starred_url":"https://api.github.com/users/Diadlo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Diadlo/subscriptions","organizations_url":"https://api.github.com/users/Diadlo/orgs","repos_url":"https://api.github.com/users/Diadlo/repos","events_url":"https://api.github.com/users/Diadlo/events{/privacy}","received_events_url":"https://api.github.com/users/Diadlo/received_events","type":"User","site_admin":false},"body":"Because it's const context","created_at":"2016-07-31T17:11:26Z","updated_at":"2016-07-31T17:11:26Z","html_url":"https://github.com/tux3/qTox/pull/3380#discussion_r72907358","pull_request_url":"https://api.github.com/repos/tux3/qTox/pulls/3380","_links":{"self":{"href":"https://api.github.com/repos/tux3/qTox/pulls/comments/72907358"},"html":{"href":"https://github.com/tux3/qTox/pull/3380#discussion_r72907358"},"pull_request":{"href":"https://api.github.com/repos/tux3/qTox/pulls/3380"}}},"pull_request":{"url":"https://api.github.com/repos/tux3/qTox/pulls/3380","id":73496906,"html_url":"https://github.com/tux3/qTox/pull/3380","diff_url":"https://github.com/tux3/qTox/pull/3380.diff","patch_url":"https://github.com/tux3/qTox/pull/3380.patch","issue_url":"https://api.github.com/repos/tux3/qTox/issues/3380","number":3380,"state":"open","locked":false,"title":"fix serious type conversion warnings","user":{"login":"antis81","id":440517,"avatar_url":"https://avatars.githubusercontent.com/u/440517?v=3","gravatar_id":"","url":"https://api.github.com/users/antis81","html_url":"https://github.com/antis81","followers_url":"https://api.github.com/users/antis81/followers","following_url":"https://api.github.com/users/antis81/following{/other_user}","gists_url":"https://api.github.com/users/antis81/gists{/gist_id}","starred_url":"https://api.github.com/users/antis81/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antis81/subscriptions","organizations_url":"https://api.github.com/users/antis81/orgs","repos_url":"https://api.github.com/users/antis81/repos","events_url":"https://api.github.com/users/antis81/events{/privacy}","received_events_url":"https://api.github.com/users/antis81/received_events","type":"User","site_admin":false},"body":"The used var types in the qTox Settings class require some cleanup. For some weeks (months?) now, LLVM's static code analysis is available in Qt Creator and helps a bit. It moans about lots of missing type casts, which is also an indicator, that those types do not match well and need to be changed.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/tux3/qtox/3380)\n<!-- Reviewable:end -->\n","created_at":"2016-06-12T13:52:24Z","updated_at":"2016-07-31T17:11:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1a8985f8e210315862915bff226925135eac24e7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/tux3/qTox/pulls/3380/commits","review_comments_url":"https://api.github.com/repos/tux3/qTox/pulls/3380/comments","review_comment_url":"https://api.github.com/repos/tux3/qTox/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tux3/qTox/issues/3380/comments","statuses_url":"https://api.github.com/repos/tux3/qTox/statuses/b946fade5bb1406abdd7e6d3718811f0772ef0ec","head":{"label":"antis81:refactor/settings","ref":"refactor/settings","sha":"b946fade5bb1406abdd7e6d3718811f0772ef0ec","user":{"login":"antis81","id":440517,"avatar_url":"https://avatars.githubusercontent.com/u/440517?v=3","gravatar_id":"","url":"https://api.github.com/users/antis81","html_url":"https://github.com/antis81","followers_url":"https://api.github.com/users/antis81/followers","following_url":"https://api.github.com/users/antis81/following{/other_user}","gists_url":"https://api.github.com/users/antis81/gists{/gist_id}","starred_url":"https://api.github.com/users/antis81/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antis81/subscriptions","organizations_url":"https://api.github.com/users/antis81/orgs","repos_url":"https://api.github.com/users/antis81/repos","events_url":"https://api.github.com/users/antis81/events{/privacy}","received_events_url":"https://api.github.com/users/antis81/received_events","type":"User","site_admin":false},"repo":{"id":40208997,"name":"qTox","full_name":"antis81/qTox","owner":{"login":"antis81","id":440517,"avatar_url":"https://avatars.githubusercontent.com/u/440517?v=3","gravatar_id":"","url":"https://api.github.com/users/antis81","html_url":"https://github.com/antis81","followers_url":"https://api.github.com/users/antis81/followers","following_url":"https://api.github.com/users/antis81/following{/other_user}","gists_url":"https://api.github.com/users/antis81/gists{/gist_id}","starred_url":"https://api.github.com/users/antis81/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antis81/subscriptions","organizations_url":"https://api.github.com/users/antis81/orgs","repos_url":"https://api.github.com/users/antis81/repos","events_url":"https://api.github.com/users/antis81/events{/privacy}","received_events_url":"https://api.github.com/users/antis81/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/antis81/qTox","description":"Powerful Tox client that follows the Tox design guidelines.","fork":true,"url":"https://api.github.com/repos/antis81/qTox","forks_url":"https://api.github.com/repos/antis81/qTox/forks","keys_url":"https://api.github.com/repos/antis81/qTox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/antis81/qTox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/antis81/qTox/teams","hooks_url":"https://api.github.com/repos/antis81/qTox/hooks","issue_events_url":"https://api.github.com/repos/antis81/qTox/issues/events{/number}","events_url":"https://api.github.com/repos/antis81/qTox/events","assignees_url":"https://api.github.com/repos/antis81/qTox/assignees{/user}","branches_url":"https://api.github.com/repos/antis81/qTox/branches{/branch}","tags_url":"https://api.github.com/repos/antis81/qTox/tags","blobs_url":"https://api.github.com/repos/antis81/qTox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/antis81/qTox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/antis81/qTox/git/refs{/sha}","trees_url":"https://api.github.com/repos/antis81/qTox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/antis81/qTox/statuses/{sha}","languages_url":"https://api.github.com/repos/antis81/qTox/languages","stargazers_url":"https://api.github.com/repos/antis81/qTox/stargazers","contributors_url":"https://api.github.com/repos/antis81/qTox/contributors","subscribers_url":"https://api.github.com/repos/antis81/qTox/subscribers","subscription_url":"https://api.github.com/repos/antis81/qTox/subscription","commits_url":"https://api.github.com/repos/antis81/qTox/commits{/sha}","git_commits_url":"https://api.github.com/repos/antis81/qTox/git/commits{/sha}","comments_url":"https://api.github.com/repos/antis81/qTox/comments{/number}","issue_comment_url":"https://api.github.com/repos/antis81/qTox/issues/comments{/number}","contents_url":"https://api.github.com/repos/antis81/qTox/contents/{+path}","compare_url":"https://api.github.com/repos/antis81/qTox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/antis81/qTox/merges","archive_url":"https://api.github.com/repos/antis81/qTox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/antis81/qTox/downloads","issues_url":"https://api.github.com/repos/antis81/qTox/issues{/number}","pulls_url":"https://api.github.com/repos/antis81/qTox/pulls{/number}","milestones_url":"https://api.github.com/repos/antis81/qTox/milestones{/number}","notifications_url":"https://api.github.com/repos/antis81/qTox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/antis81/qTox/labels{/name}","releases_url":"https://api.github.com/repos/antis81/qTox/releases{/id}","deployments_url":"https://api.github.com/repos/antis81/qTox/deployments","created_at":"2015-08-04T21:03:49Z","updated_at":"2015-09-26T06:45:21Z","pushed_at":"2016-07-31T12:32:26Z","git_url":"git://github.com/antis81/qTox.git","ssh_url":"git@github.com:antis81/qTox.git","clone_url":"https://github.com/antis81/qTox.git","svn_url":"https://github.com/antis81/qTox","homepage":"http://utoxisfinished.info","size":21491,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tux3:master","ref":"master","sha":"a556762c54de5f4acbcf2f37c84cd7bb7b3b1afa","user":{"login":"tux3","id":5155966,"avatar_url":"https://avatars.githubusercontent.com/u/5155966?v=3","gravatar_id":"","url":"https://api.github.com/users/tux3","html_url":"https://github.com/tux3","followers_url":"https://api.github.com/users/tux3/followers","following_url":"https://api.github.com/users/tux3/following{/other_user}","gists_url":"https://api.github.com/users/tux3/gists{/gist_id}","starred_url":"https://api.github.com/users/tux3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tux3/subscriptions","organizations_url":"https://api.github.com/users/tux3/orgs","repos_url":"https://api.github.com/users/tux3/repos","events_url":"https://api.github.com/users/tux3/events{/privacy}","received_events_url":"https://api.github.com/users/tux3/received_events","type":"User","site_admin":false},"repo":{"id":21179164,"name":"qTox","full_name":"tux3/qTox","owner":{"login":"tux3","id":5155966,"avatar_url":"https://avatars.githubusercontent.com/u/5155966?v=3","gravatar_id":"","url":"https://api.github.com/users/tux3","html_url":"https://github.com/tux3","followers_url":"https://api.github.com/users/tux3/followers","following_url":"https://api.github.com/users/tux3/following{/other_user}","gists_url":"https://api.github.com/users/tux3/gists{/gist_id}","starred_url":"https://api.github.com/users/tux3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tux3/subscriptions","organizations_url":"https://api.github.com/users/tux3/orgs","repos_url":"https://api.github.com/users/tux3/repos","events_url":"https://api.github.com/users/tux3/events{/privacy}","received_events_url":"https://api.github.com/users/tux3/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tux3/qTox","description":"Powerful Tox chat client that follows the Tox design guidelines.","fork":false,"url":"https://api.github.com/repos/tux3/qTox","forks_url":"https://api.github.com/repos/tux3/qTox/forks","keys_url":"https://api.github.com/repos/tux3/qTox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tux3/qTox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tux3/qTox/teams","hooks_url":"https://api.github.com/repos/tux3/qTox/hooks","issue_events_url":"https://api.github.com/repos/tux3/qTox/issues/events{/number}","events_url":"https://api.github.com/repos/tux3/qTox/events","assignees_url":"https://api.github.com/repos/tux3/qTox/assignees{/user}","branches_url":"https://api.github.com/repos/tux3/qTox/branches{/branch}","tags_url":"https://api.github.com/repos/tux3/qTox/tags","blobs_url":"https://api.github.com/repos/tux3/qTox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tux3/qTox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tux3/qTox/git/refs{/sha}","trees_url":"https://api.github.com/repos/tux3/qTox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tux3/qTox/statuses/{sha}","languages_url":"https://api.github.com/repos/tux3/qTox/languages","stargazers_url":"https://api.github.com/repos/tux3/qTox/stargazers","contributors_url":"https://api.github.com/repos/tux3/qTox/contributors","subscribers_url":"https://api.github.com/repos/tux3/qTox/subscribers","subscription_url":"https://api.github.com/repos/tux3/qTox/subscription","commits_url":"https://api.github.com/repos/tux3/qTox/commits{/sha}","git_commits_url":"https://api.github.com/repos/tux3/qTox/git/commits{/sha}","comments_url":"https://api.github.com/repos/tux3/qTox/comments{/number}","issue_comment_url":"https://api.github.com/repos/tux3/qTox/issues/comments{/number}","contents_url":"https://api.github.com/repos/tux3/qTox/contents/{+path}","compare_url":"https://api.github.com/repos/tux3/qTox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tux3/qTox/merges","archive_url":"https://api.github.com/repos/tux3/qTox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tux3/qTox/downloads","issues_url":"https://api.github.com/repos/tux3/qTox/issues{/number}","pulls_url":"https://api.github.com/repos/tux3/qTox/pulls{/number}","milestones_url":"https://api.github.com/repos/tux3/qTox/milestones{/number}","notifications_url":"https://api.github.com/repos/tux3/qTox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tux3/qTox/labels{/name}","releases_url":"https://api.github.com/repos/tux3/qTox/releases{/id}","deployments_url":"https://api.github.com/repos/tux3/qTox/deployments","created_at":"2014-06-24T20:09:04Z","updated_at":"2016-07-30T10:07:36Z","pushed_at":"2016-07-31T16:17:34Z","git_url":"git://github.com/tux3/qTox.git","ssh_url":"git@github.com:tux3/qTox.git","clone_url":"https://github.com/tux3/qTox.git","svn_url":"https://github.com/tux3/qTox","homepage":"https://qtox.github.io/","size":26764,"stargazers_count":1018,"watchers_count":1018,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":298,"mirror_url":null,"open_issues_count":498,"forks":298,"open_issues":498,"watchers":1018,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tux3/qTox/pulls/3380"},"html":{"href":"https://github.com/tux3/qTox/pull/3380"},"issue":{"href":"https://api.github.com/repos/tux3/qTox/issues/3380"},"comments":{"href":"https://api.github.com/repos/tux3/qTox/issues/3380/comments"},"review_comments":{"href":"https://api.github.com/repos/tux3/qTox/pulls/3380/comments"},"review_comment":{"href":"https://api.github.com/repos/tux3/qTox/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tux3/qTox/pulls/3380/commits"},"statuses":{"href":"https://api.github.com/repos/tux3/qTox/statuses/b946fade5bb1406abdd7e6d3718811f0772ef0ec"}}}}
{"actor":{"display_login":"Diadlo"}}