{"action":"created","comment":{"url":"https://api.github.com/repos/coreos/rkt/pulls/comments/90233646","pull_request_review_id":10755031,"id":90233646,"diff_hunk":"@@ -1187,3 +1189,29 @@ func (p *Pod) AppExitCode(appName string) (int, error) {\n \tstatusFile := filepath.Join(stage1RootfsPath, \"/rkt/status/\", appName)\n \treturn p.readIntFromFile(statusFile)\n }\n+\n+// ManifestExclusiveLock gets an exclusive lock on only the pod manifest.\n+// This is used in the app sandbox - since the pod is already running, we\n+// won't be able to get an exclusive lock on the pod itself.\n+func (p *Pod) ExclusiveManifestLock() error {\n+\tl, err := lock.ExclusiveLock(common.PodManifestLockPath(p.Path()), lock.RegFile)","path":"pkg/pod/pods.go","position":18,"original_position":18,"commit_id":"225e91b2ee99bacec2ddfe8c656e0573a63b7e9a","original_commit_id":"225e91b2ee99bacec2ddfe8c656e0573a63b7e9a","user":{"login":"s-urbaniak","id":375856,"avatar_url":"https://avatars.githubusercontent.com/u/375856?v=3","gravatar_id":"","url":"https://api.github.com/users/s-urbaniak","html_url":"https://github.com/s-urbaniak","followers_url":"https://api.github.com/users/s-urbaniak/followers","following_url":"https://api.github.com/users/s-urbaniak/following{/other_user}","gists_url":"https://api.github.com/users/s-urbaniak/gists{/gist_id}","starred_url":"https://api.github.com/users/s-urbaniak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s-urbaniak/subscriptions","organizations_url":"https://api.github.com/users/s-urbaniak/orgs","repos_url":"https://api.github.com/users/s-urbaniak/repos","events_url":"https://api.github.com/users/s-urbaniak/events{/privacy}","received_events_url":"https://api.github.com/users/s-urbaniak/received_events","type":"User","site_admin":false},"body":"Does it make sense to make this method reentrant?!","created_at":"2016-11-30T13:43:50Z","updated_at":"2016-11-30T13:44:26Z","html_url":"https://github.com/coreos/rkt/pull/3426#discussion_r90233646","pull_request_url":"https://api.github.com/repos/coreos/rkt/pulls/3426","_links":{"self":{"href":"https://api.github.com/repos/coreos/rkt/pulls/comments/90233646"},"html":{"href":"https://github.com/coreos/rkt/pull/3426#discussion_r90233646"},"pull_request":{"href":"https://api.github.com/repos/coreos/rkt/pulls/3426"}}},"pull_request":{"url":"https://api.github.com/repos/coreos/rkt/pulls/3426","id":95735734,"html_url":"https://github.com/coreos/rkt/pull/3426","diff_url":"https://github.com/coreos/rkt/pull/3426.diff","patch_url":"https://github.com/coreos/rkt/pull/3426.patch","issue_url":"https://api.github.com/repos/coreos/rkt/issues/3426","number":3426,"state":"open","locked":false,"title":"stage0: remove usage of stage1 code","user":{"login":"squeed","id":551378,"avatar_url":"https://avatars.githubusercontent.com/u/551378?v=3","gravatar_id":"","url":"https://api.github.com/users/squeed","html_url":"https://github.com/squeed","followers_url":"https://api.github.com/users/squeed/followers","following_url":"https://api.github.com/users/squeed/following{/other_user}","gists_url":"https://api.github.com/users/squeed/gists{/gist_id}","starred_url":"https://api.github.com/users/squeed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/squeed/subscriptions","organizations_url":"https://api.github.com/users/squeed/orgs","repos_url":"https://api.github.com/users/squeed/repos","events_url":"https://api.github.com/users/squeed/events{/privacy}","received_events_url":"https://api.github.com/users/squeed/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-11-29T17:14:32Z","updated_at":"2016-11-30T13:48:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"264110f0903706f345429c679bb424afc49dc23c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/coreos/rkt/pulls/3426/commits","review_comments_url":"https://api.github.com/repos/coreos/rkt/pulls/3426/comments","review_comment_url":"https://api.github.com/repos/coreos/rkt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coreos/rkt/issues/3426/comments","statuses_url":"https://api.github.com/repos/coreos/rkt/statuses/225e91b2ee99bacec2ddfe8c656e0573a63b7e9a","head":{"label":"squeed:runtime-params","ref":"runtime-params","sha":"225e91b2ee99bacec2ddfe8c656e0573a63b7e9a","user":{"login":"squeed","id":551378,"avatar_url":"https://avatars.githubusercontent.com/u/551378?v=3","gravatar_id":"","url":"https://api.github.com/users/squeed","html_url":"https://github.com/squeed","followers_url":"https://api.github.com/users/squeed/followers","following_url":"https://api.github.com/users/squeed/following{/other_user}","gists_url":"https://api.github.com/users/squeed/gists{/gist_id}","starred_url":"https://api.github.com/users/squeed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/squeed/subscriptions","organizations_url":"https://api.github.com/users/squeed/orgs","repos_url":"https://api.github.com/users/squeed/repos","events_url":"https://api.github.com/users/squeed/events{/privacy}","received_events_url":"https://api.github.com/users/squeed/received_events","type":"User","site_admin":false},"repo":{"id":62400350,"name":"rkt","full_name":"squeed/rkt","owner":{"login":"squeed","id":551378,"avatar_url":"https://avatars.githubusercontent.com/u/551378?v=3","gravatar_id":"","url":"https://api.github.com/users/squeed","html_url":"https://github.com/squeed","followers_url":"https://api.github.com/users/squeed/followers","following_url":"https://api.github.com/users/squeed/following{/other_user}","gists_url":"https://api.github.com/users/squeed/gists{/gist_id}","starred_url":"https://api.github.com/users/squeed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/squeed/subscriptions","organizations_url":"https://api.github.com/users/squeed/orgs","repos_url":"https://api.github.com/users/squeed/repos","events_url":"https://api.github.com/users/squeed/events{/privacy}","received_events_url":"https://api.github.com/users/squeed/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/squeed/rkt","description":"rkt is an App Container runtime for Linux","fork":true,"url":"https://api.github.com/repos/squeed/rkt","forks_url":"https://api.github.com/repos/squeed/rkt/forks","keys_url":"https://api.github.com/repos/squeed/rkt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/squeed/rkt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/squeed/rkt/teams","hooks_url":"https://api.github.com/repos/squeed/rkt/hooks","issue_events_url":"https://api.github.com/repos/squeed/rkt/issues/events{/number}","events_url":"https://api.github.com/repos/squeed/rkt/events","assignees_url":"https://api.github.com/repos/squeed/rkt/assignees{/user}","branches_url":"https://api.github.com/repos/squeed/rkt/branches{/branch}","tags_url":"https://api.github.com/repos/squeed/rkt/tags","blobs_url":"https://api.github.com/repos/squeed/rkt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/squeed/rkt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/squeed/rkt/git/refs{/sha}","trees_url":"https://api.github.com/repos/squeed/rkt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/squeed/rkt/statuses/{sha}","languages_url":"https://api.github.com/repos/squeed/rkt/languages","stargazers_url":"https://api.github.com/repos/squeed/rkt/stargazers","contributors_url":"https://api.github.com/repos/squeed/rkt/contributors","subscribers_url":"https://api.github.com/repos/squeed/rkt/subscribers","subscription_url":"https://api.github.com/repos/squeed/rkt/subscription","commits_url":"https://api.github.com/repos/squeed/rkt/commits{/sha}","git_commits_url":"https://api.github.com/repos/squeed/rkt/git/commits{/sha}","comments_url":"https://api.github.com/repos/squeed/rkt/comments{/number}","issue_comment_url":"https://api.github.com/repos/squeed/rkt/issues/comments{/number}","contents_url":"https://api.github.com/repos/squeed/rkt/contents/{+path}","compare_url":"https://api.github.com/repos/squeed/rkt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/squeed/rkt/merges","archive_url":"https://api.github.com/repos/squeed/rkt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/squeed/rkt/downloads","issues_url":"https://api.github.com/repos/squeed/rkt/issues{/number}","pulls_url":"https://api.github.com/repos/squeed/rkt/pulls{/number}","milestones_url":"https://api.github.com/repos/squeed/rkt/milestones{/number}","notifications_url":"https://api.github.com/repos/squeed/rkt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/squeed/rkt/labels{/name}","releases_url":"https://api.github.com/repos/squeed/rkt/releases{/id}","deployments_url":"https://api.github.com/repos/squeed/rkt/deployments","created_at":"2016-07-01T14:54:23Z","updated_at":"2016-07-01T14:54:25Z","pushed_at":"2016-11-30T13:32:09Z","git_url":"git://github.com/squeed/rkt.git","ssh_url":"git@github.com:squeed/rkt.git","clone_url":"https://github.com/squeed/rkt.git","svn_url":"https://github.com/squeed/rkt","homepage":"","size":24401,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"coreos:master","ref":"master","sha":"913892eae2d5050b9ebd0605bf54b9cb7467929b","user":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"repo":{"id":26509369,"name":"rkt","full_name":"coreos/rkt","owner":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coreos/rkt","description":"rkt is a container engine for Linux designed to be composable, secure, and built on standards","fork":false,"url":"https://api.github.com/repos/coreos/rkt","forks_url":"https://api.github.com/repos/coreos/rkt/forks","keys_url":"https://api.github.com/repos/coreos/rkt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coreos/rkt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coreos/rkt/teams","hooks_url":"https://api.github.com/repos/coreos/rkt/hooks","issue_events_url":"https://api.github.com/repos/coreos/rkt/issues/events{/number}","events_url":"https://api.github.com/repos/coreos/rkt/events","assignees_url":"https://api.github.com/repos/coreos/rkt/assignees{/user}","branches_url":"https://api.github.com/repos/coreos/rkt/branches{/branch}","tags_url":"https://api.github.com/repos/coreos/rkt/tags","blobs_url":"https://api.github.com/repos/coreos/rkt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coreos/rkt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coreos/rkt/git/refs{/sha}","trees_url":"https://api.github.com/repos/coreos/rkt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coreos/rkt/statuses/{sha}","languages_url":"https://api.github.com/repos/coreos/rkt/languages","stargazers_url":"https://api.github.com/repos/coreos/rkt/stargazers","contributors_url":"https://api.github.com/repos/coreos/rkt/contributors","subscribers_url":"https://api.github.com/repos/coreos/rkt/subscribers","subscription_url":"https://api.github.com/repos/coreos/rkt/subscription","commits_url":"https://api.github.com/repos/coreos/rkt/commits{/sha}","git_commits_url":"https://api.github.com/repos/coreos/rkt/git/commits{/sha}","comments_url":"https://api.github.com/repos/coreos/rkt/comments{/number}","issue_comment_url":"https://api.github.com/repos/coreos/rkt/issues/comments{/number}","contents_url":"https://api.github.com/repos/coreos/rkt/contents/{+path}","compare_url":"https://api.github.com/repos/coreos/rkt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coreos/rkt/merges","archive_url":"https://api.github.com/repos/coreos/rkt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coreos/rkt/downloads","issues_url":"https://api.github.com/repos/coreos/rkt/issues{/number}","pulls_url":"https://api.github.com/repos/coreos/rkt/pulls{/number}","milestones_url":"https://api.github.com/repos/coreos/rkt/milestones{/number}","notifications_url":"https://api.github.com/repos/coreos/rkt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coreos/rkt/labels{/name}","releases_url":"https://api.github.com/repos/coreos/rkt/releases{/id}","deployments_url":"https://api.github.com/repos/coreos/rkt/deployments","created_at":"2014-11-11T23:13:18Z","updated_at":"2016-11-30T09:59:42Z","pushed_at":"2016-11-30T13:31:54Z","git_url":"git://github.com/coreos/rkt.git","ssh_url":"git@github.com:coreos/rkt.git","clone_url":"https://github.com/coreos/rkt.git","svn_url":"https://github.com/coreos/rkt","homepage":"","size":35471,"stargazers_count":6473,"watchers_count":6473,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":631,"mirror_url":null,"open_issues_count":400,"forks":631,"open_issues":400,"watchers":6473,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coreos/rkt/pulls/3426"},"html":{"href":"https://github.com/coreos/rkt/pull/3426"},"issue":{"href":"https://api.github.com/repos/coreos/rkt/issues/3426"},"comments":{"href":"https://api.github.com/repos/coreos/rkt/issues/3426/comments"},"review_comments":{"href":"https://api.github.com/repos/coreos/rkt/pulls/3426/comments"},"review_comment":{"href":"https://api.github.com/repos/coreos/rkt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coreos/rkt/pulls/3426/commits"},"statuses":{"href":"https://api.github.com/repos/coreos/rkt/statuses/225e91b2ee99bacec2ddfe8c656e0573a63b7e9a"}}}}
{"actor":{"display_login":"s-urbaniak"}}