{"push_id":1192168729,"size":1,"distinct_size":1,"ref":"refs/heads/master","head":"239ecba6156f4e179b09107953638f7c8d8db09e","before":"f535de9edcfbf3450ffb673e914c2481d47e5323","commits":[{"sha":"239ecba6156f4e179b09107953638f7c8d8db09e","author":{"name":"michaelpg","email":"937611375b124a227e9ed60fdc75c4cf45bc400a@chromium.org"},"message":"MD Settings: step 1 of modular, testable Settings transitions\n\nSettings animations, Settings UI, and the routing/navigation are all\ntightly coupled. The animations are complicated[1], fragile and hard\nto test; as a result, they constantly become janky. It's also hard to\nadd polish or write new transitions.\n\nStep 1: simple wrappers around web animations.\n* settings.animation.Animation adds a |finished| Promise which Chrome hasn't\n  implemented natively yet.\n\nStep 2: interface for grouping animations to start/stop together.\n* settings.animation.AnimationGroup is an abstract animation or group of\n  animations which can succeed or be cancelled, immediately or asynchronously.\n  This is just a nice interface around patterns we are using throughout\n  material WebUI.\n\nExample usage: http://pastebin.com/GZegDqLh\n\nA router doesn't have to keep track of the state of animations:\nhttp://pastebin.com/YwCzmXFv\n\nStep 3 is to port existing animations by wrapping them in AnimationGroup,\n       removing the weird TransitionBehavior, and writing tests.\nStep 4 is to rework the router to make use of AnimationGroup Promises.\nStep 5 (optional nice-to-have) is to separate navigation from routing\n       so navigation events can be queued, canceled and reversed more smoothly.\n\nBUG=589681\nR=dbeam@chromium.org\nCQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation\n\n[1] https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/settings_page/main_page_behavior.js?q=main_page_behavior.js&sq=package:chromium&dr&l=43-78\n\nReview-Url: https://codereview.chromium.org/2072643002\nCr-Commit-Position: refs/heads/master@{#404097}","distinct":true,"url":"https://api.github.com/repos/dstockwell/chromium/commits/239ecba6156f4e179b09107953638f7c8d8db09e"}]}
{"actor":{"display_login":"dstockwell"}}