{"action":"created","comment":{"url":"https://api.github.com/repos/mogilefs-moji/moji/pulls/comments/73282625","id":73282625,"diff_hunk":"@@ -80,40 +81,62 @@ public void flush() throws IOException {\n   @Override\n   public void close() throws IOException {\n     log.debug(\"Close called on {}\", this);\n-    long size = -1L;\n+\n     try {\n+      // Step 1. finish data writing to store node","path":"src/main/java/fm/last/moji/impl/FileUploadOutputStream.java","position":15,"original_position":15,"commit_id":"b15d57a2475f7e23617eb9932e985a544d30e0f9","original_commit_id":"b15d57a2475f7e23617eb9932e985a544d30e0f9","user":{"login":"hrchu","id":3183314,"avatar_url":"https://avatars.githubusercontent.com/u/3183314?v=3","gravatar_id":"","url":"https://api.github.com/users/hrchu","html_url":"https://github.com/hrchu","followers_url":"https://api.github.com/users/hrchu/followers","following_url":"https://api.github.com/users/hrchu/following{/other_user}","gists_url":"https://api.github.com/users/hrchu/gists{/gist_id}","starred_url":"https://api.github.com/users/hrchu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hrchu/subscriptions","organizations_url":"https://api.github.com/users/hrchu/orgs","repos_url":"https://api.github.com/users/hrchu/repos","events_url":"https://api.github.com/users/hrchu/events{/privacy}","received_events_url":"https://api.github.com/users/hrchu/received_events","type":"User","site_admin":false},"body":"Nice advice. I will do it.","created_at":"2016-08-03T05:29:47Z","updated_at":"2016-08-03T05:29:47Z","html_url":"https://github.com/mogilefs-moji/moji/pull/24#discussion_r73282625","pull_request_url":"https://api.github.com/repos/mogilefs-moji/moji/pulls/24","_links":{"self":{"href":"https://api.github.com/repos/mogilefs-moji/moji/pulls/comments/73282625"},"html":{"href":"https://github.com/mogilefs-moji/moji/pull/24#discussion_r73282625"},"pull_request":{"href":"https://api.github.com/repos/mogilefs-moji/moji/pulls/24"}}},"pull_request":{"url":"https://api.github.com/repos/mogilefs-moji/moji/pulls/24","id":72001780,"html_url":"https://github.com/mogilefs-moji/moji/pull/24","diff_url":"https://github.com/mogilefs-moji/moji/pull/24.diff","patch_url":"https://github.com/mogilefs-moji/moji/pull/24.patch","issue_url":"https://api.github.com/repos/mogilefs-moji/moji/issues/24","number":24,"state":"open","locked":false,"title":"Improve close upload stream error handing","user":{"login":"hrchu","id":3183314,"avatar_url":"https://avatars.githubusercontent.com/u/3183314?v=3","gravatar_id":"","url":"https://api.github.com/users/hrchu","html_url":"https://github.com/hrchu","followers_url":"https://api.github.com/users/hrchu/followers","following_url":"https://api.github.com/users/hrchu/following{/other_user}","gists_url":"https://api.github.com/users/hrchu/gists{/gist_id}","starred_url":"https://api.github.com/users/hrchu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hrchu/subscriptions","organizations_url":"https://api.github.com/users/hrchu/orgs","repos_url":"https://api.github.com/users/hrchu/repos","events_url":"https://api.github.com/users/hrchu/events{/privacy}","received_events_url":"https://api.github.com/users/hrchu/received_events","type":"User","site_admin":false},"body":" - Do not send meaningless create_close to tracker when upload to store node is failed.\r\n - When create_close is failed, retry it again.","created_at":"2016-05-31T11:48:30Z","updated_at":"2016-08-03T05:29:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d1e98df48b4ed73f8e27ef3b0b08afbaa7465f69","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mogilefs-moji/moji/pulls/24/commits","review_comments_url":"https://api.github.com/repos/mogilefs-moji/moji/pulls/24/comments","review_comment_url":"https://api.github.com/repos/mogilefs-moji/moji/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mogilefs-moji/moji/issues/24/comments","statuses_url":"https://api.github.com/repos/mogilefs-moji/moji/statuses/b15d57a2475f7e23617eb9932e985a544d30e0f9","head":{"label":"mogilefs-moji:improveCloseUploadStreamErrorHandling","ref":"improveCloseUploadStreamErrorHandling","sha":"b15d57a2475f7e23617eb9932e985a544d30e0f9","user":{"login":"mogilefs-moji","id":13795644,"avatar_url":"https://avatars.githubusercontent.com/u/13795644?v=3","gravatar_id":"","url":"https://api.github.com/users/mogilefs-moji","html_url":"https://github.com/mogilefs-moji","followers_url":"https://api.github.com/users/mogilefs-moji/followers","following_url":"https://api.github.com/users/mogilefs-moji/following{/other_user}","gists_url":"https://api.github.com/users/mogilefs-moji/gists{/gist_id}","starred_url":"https://api.github.com/users/mogilefs-moji/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mogilefs-moji/subscriptions","organizations_url":"https://api.github.com/users/mogilefs-moji/orgs","repos_url":"https://api.github.com/users/mogilefs-moji/repos","events_url":"https://api.github.com/users/mogilefs-moji/events{/privacy}","received_events_url":"https://api.github.com/users/mogilefs-moji/received_events","type":"Organization","site_admin":false},"repo":{"id":2303255,"name":"moji","full_name":"mogilefs-moji/moji","owner":{"login":"mogilefs-moji","id":13795644,"avatar_url":"https://avatars.githubusercontent.com/u/13795644?v=3","gravatar_id":"","url":"https://api.github.com/users/mogilefs-moji","html_url":"https://github.com/mogilefs-moji","followers_url":"https://api.github.com/users/mogilefs-moji/followers","following_url":"https://api.github.com/users/mogilefs-moji/following{/other_user}","gists_url":"https://api.github.com/users/mogilefs-moji/gists{/gist_id}","starred_url":"https://api.github.com/users/mogilefs-moji/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mogilefs-moji/subscriptions","organizations_url":"https://api.github.com/users/mogilefs-moji/orgs","repos_url":"https://api.github.com/users/mogilefs-moji/repos","events_url":"https://api.github.com/users/mogilefs-moji/events{/privacy}","received_events_url":"https://api.github.com/users/mogilefs-moji/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mogilefs-moji/moji","description":"A file-like MogileFS client for Java","fork":false,"url":"https://api.github.com/repos/mogilefs-moji/moji","forks_url":"https://api.github.com/repos/mogilefs-moji/moji/forks","keys_url":"https://api.github.com/repos/mogilefs-moji/moji/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mogilefs-moji/moji/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mogilefs-moji/moji/teams","hooks_url":"https://api.github.com/repos/mogilefs-moji/moji/hooks","issue_events_url":"https://api.github.com/repos/mogilefs-moji/moji/issues/events{/number}","events_url":"https://api.github.com/repos/mogilefs-moji/moji/events","assignees_url":"https://api.github.com/repos/mogilefs-moji/moji/assignees{/user}","branches_url":"https://api.github.com/repos/mogilefs-moji/moji/branches{/branch}","tags_url":"https://api.github.com/repos/mogilefs-moji/moji/tags","blobs_url":"https://api.github.com/repos/mogilefs-moji/moji/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mogilefs-moji/moji/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mogilefs-moji/moji/git/refs{/sha}","trees_url":"https://api.github.com/repos/mogilefs-moji/moji/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mogilefs-moji/moji/statuses/{sha}","languages_url":"https://api.github.com/repos/mogilefs-moji/moji/languages","stargazers_url":"https://api.github.com/repos/mogilefs-moji/moji/stargazers","contributors_url":"https://api.github.com/repos/mogilefs-moji/moji/contributors","subscribers_url":"https://api.github.com/repos/mogilefs-moji/moji/subscribers","subscription_url":"https://api.github.com/repos/mogilefs-moji/moji/subscription","commits_url":"https://api.github.com/repos/mogilefs-moji/moji/commits{/sha}","git_commits_url":"https://api.github.com/repos/mogilefs-moji/moji/git/commits{/sha}","comments_url":"https://api.github.com/repos/mogilefs-moji/moji/comments{/number}","issue_comment_url":"https://api.github.com/repos/mogilefs-moji/moji/issues/comments{/number}","contents_url":"https://api.github.com/repos/mogilefs-moji/moji/contents/{+path}","compare_url":"https://api.github.com/repos/mogilefs-moji/moji/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mogilefs-moji/moji/merges","archive_url":"https://api.github.com/repos/mogilefs-moji/moji/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mogilefs-moji/moji/downloads","issues_url":"https://api.github.com/repos/mogilefs-moji/moji/issues{/number}","pulls_url":"https://api.github.com/repos/mogilefs-moji/moji/pulls{/number}","milestones_url":"https://api.github.com/repos/mogilefs-moji/moji/milestones{/number}","notifications_url":"https://api.github.com/repos/mogilefs-moji/moji/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mogilefs-moji/moji/labels{/name}","releases_url":"https://api.github.com/repos/mogilefs-moji/moji/releases{/id}","deployments_url":"https://api.github.com/repos/mogilefs-moji/moji/deployments","created_at":"2011-08-31T18:29:11Z","updated_at":"2016-05-31T00:37:21Z","pushed_at":"2016-06-15T09:12:51Z","git_url":"git://github.com/mogilefs-moji/moji.git","ssh_url":"git@github.com:mogilefs-moji/moji.git","clone_url":"https://github.com/mogilefs-moji/moji.git","svn_url":"https://github.com/mogilefs-moji/moji","homepage":"","size":382,"stargazers_count":18,"watchers_count":18,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":5,"forks":13,"open_issues":5,"watchers":18,"default_branch":"master"}},"base":{"label":"mogilefs-moji:master","ref":"master","sha":"531857e34f3f8212ddebcd487dea79ee41d1b336","user":{"login":"mogilefs-moji","id":13795644,"avatar_url":"https://avatars.githubusercontent.com/u/13795644?v=3","gravatar_id":"","url":"https://api.github.com/users/mogilefs-moji","html_url":"https://github.com/mogilefs-moji","followers_url":"https://api.github.com/users/mogilefs-moji/followers","following_url":"https://api.github.com/users/mogilefs-moji/following{/other_user}","gists_url":"https://api.github.com/users/mogilefs-moji/gists{/gist_id}","starred_url":"https://api.github.com/users/mogilefs-moji/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mogilefs-moji/subscriptions","organizations_url":"https://api.github.com/users/mogilefs-moji/orgs","repos_url":"https://api.github.com/users/mogilefs-moji/repos","events_url":"https://api.github.com/users/mogilefs-moji/events{/privacy}","received_events_url":"https://api.github.com/users/mogilefs-moji/received_events","type":"Organization","site_admin":false},"repo":{"id":2303255,"name":"moji","full_name":"mogilefs-moji/moji","owner":{"login":"mogilefs-moji","id":13795644,"avatar_url":"https://avatars.githubusercontent.com/u/13795644?v=3","gravatar_id":"","url":"https://api.github.com/users/mogilefs-moji","html_url":"https://github.com/mogilefs-moji","followers_url":"https://api.github.com/users/mogilefs-moji/followers","following_url":"https://api.github.com/users/mogilefs-moji/following{/other_user}","gists_url":"https://api.github.com/users/mogilefs-moji/gists{/gist_id}","starred_url":"https://api.github.com/users/mogilefs-moji/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mogilefs-moji/subscriptions","organizations_url":"https://api.github.com/users/mogilefs-moji/orgs","repos_url":"https://api.github.com/users/mogilefs-moji/repos","events_url":"https://api.github.com/users/mogilefs-moji/events{/privacy}","received_events_url":"https://api.github.com/users/mogilefs-moji/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mogilefs-moji/moji","description":"A file-like MogileFS client for Java","fork":false,"url":"https://api.github.com/repos/mogilefs-moji/moji","forks_url":"https://api.github.com/repos/mogilefs-moji/moji/forks","keys_url":"https://api.github.com/repos/mogilefs-moji/moji/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mogilefs-moji/moji/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mogilefs-moji/moji/teams","hooks_url":"https://api.github.com/repos/mogilefs-moji/moji/hooks","issue_events_url":"https://api.github.com/repos/mogilefs-moji/moji/issues/events{/number}","events_url":"https://api.github.com/repos/mogilefs-moji/moji/events","assignees_url":"https://api.github.com/repos/mogilefs-moji/moji/assignees{/user}","branches_url":"https://api.github.com/repos/mogilefs-moji/moji/branches{/branch}","tags_url":"https://api.github.com/repos/mogilefs-moji/moji/tags","blobs_url":"https://api.github.com/repos/mogilefs-moji/moji/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mogilefs-moji/moji/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mogilefs-moji/moji/git/refs{/sha}","trees_url":"https://api.github.com/repos/mogilefs-moji/moji/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mogilefs-moji/moji/statuses/{sha}","languages_url":"https://api.github.com/repos/mogilefs-moji/moji/languages","stargazers_url":"https://api.github.com/repos/mogilefs-moji/moji/stargazers","contributors_url":"https://api.github.com/repos/mogilefs-moji/moji/contributors","subscribers_url":"https://api.github.com/repos/mogilefs-moji/moji/subscribers","subscription_url":"https://api.github.com/repos/mogilefs-moji/moji/subscription","commits_url":"https://api.github.com/repos/mogilefs-moji/moji/commits{/sha}","git_commits_url":"https://api.github.com/repos/mogilefs-moji/moji/git/commits{/sha}","comments_url":"https://api.github.com/repos/mogilefs-moji/moji/comments{/number}","issue_comment_url":"https://api.github.com/repos/mogilefs-moji/moji/issues/comments{/number}","contents_url":"https://api.github.com/repos/mogilefs-moji/moji/contents/{+path}","compare_url":"https://api.github.com/repos/mogilefs-moji/moji/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mogilefs-moji/moji/merges","archive_url":"https://api.github.com/repos/mogilefs-moji/moji/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mogilefs-moji/moji/downloads","issues_url":"https://api.github.com/repos/mogilefs-moji/moji/issues{/number}","pulls_url":"https://api.github.com/repos/mogilefs-moji/moji/pulls{/number}","milestones_url":"https://api.github.com/repos/mogilefs-moji/moji/milestones{/number}","notifications_url":"https://api.github.com/repos/mogilefs-moji/moji/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mogilefs-moji/moji/labels{/name}","releases_url":"https://api.github.com/repos/mogilefs-moji/moji/releases{/id}","deployments_url":"https://api.github.com/repos/mogilefs-moji/moji/deployments","created_at":"2011-08-31T18:29:11Z","updated_at":"2016-05-31T00:37:21Z","pushed_at":"2016-06-15T09:12:51Z","git_url":"git://github.com/mogilefs-moji/moji.git","ssh_url":"git@github.com:mogilefs-moji/moji.git","clone_url":"https://github.com/mogilefs-moji/moji.git","svn_url":"https://github.com/mogilefs-moji/moji","homepage":"","size":382,"stargazers_count":18,"watchers_count":18,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":5,"forks":13,"open_issues":5,"watchers":18,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mogilefs-moji/moji/pulls/24"},"html":{"href":"https://github.com/mogilefs-moji/moji/pull/24"},"issue":{"href":"https://api.github.com/repos/mogilefs-moji/moji/issues/24"},"comments":{"href":"https://api.github.com/repos/mogilefs-moji/moji/issues/24/comments"},"review_comments":{"href":"https://api.github.com/repos/mogilefs-moji/moji/pulls/24/comments"},"review_comment":{"href":"https://api.github.com/repos/mogilefs-moji/moji/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mogilefs-moji/moji/pulls/24/commits"},"statuses":{"href":"https://api.github.com/repos/mogilefs-moji/moji/statuses/b15d57a2475f7e23617eb9932e985a544d30e0f9"}}}}
{"actor":{"display_login":"hrchu"}}