{"action":"created","comment":{"url":"https://api.github.com/repos/NuGet/NuGet.Client/pulls/comments/66657316","id":66657316,"diff_hunk":"@@ -1221,5 +1221,125 @@ public class NuGetUpdateCommandTests\n                 Assert.True(content1.Contains(@\"<HintPath>..\\..\\\" + customPackageFolderName + @\"\\a.2.0.0\\lib\\net45\\file.dll</HintPath>\"));\n             }\n         }\n+\n+        [Fact]\n+        public async Task UpdateCommand_Success_Native_JS_Projects()\n+        {\n+            using (var packagesSourceDirectory = TestFileSystemUtility.CreateRandomTestFolder())\n+            using (var solutionDirectory = TestFileSystemUtility.CreateRandomTestFolder())\n+            using (var workingPath = TestFileSystemUtility.CreateRandomTestFolder())\n+            {\n+                var projectDirectory1 = Path.Combine(solutionDirectory, \"proj1\");\n+                var projectDirectory2 = Path.Combine(solutionDirectory, \"proj2\");\n+                var packagesDirectory = Path.Combine(solutionDirectory, \"packages\");\n+\n+                var a1 = new PackageIdentity(\"A\", new NuGetVersion(\"1.0.0\"));\n+                var a2 = new PackageIdentity(\"A\", new NuGetVersion(\"2.0.0\"));\n+\n+                var b1 = new PackageIdentity(\"B\", new NuGetVersion(\"1.0.0\"));\n+                var b2 = new PackageIdentity(\"B\", new NuGetVersion(\"2.0.0\"));\n+\n+                var a1Package = Util.CreateTestPackage(\n+                    a1.Id,\n+                    a1.Version.ToString(),\n+                    packagesSourceDirectory,\n+                    new List<NuGetFramework>() { },\n+                    \"test.txt\");\n+\n+                var a2Package = Util.CreateTestPackage(\n+                    a2.Id,\n+                    a2.Version.ToString(),\n+                    packagesSourceDirectory,\n+                    new List<NuGetFramework>() { },\n+                    \"test.txt\");\n+\n+                var b1Package = Util.CreateTestPackage(\n+                    b1.Id,\n+                    b1.Version.ToString(),\n+                    packagesSourceDirectory,\n+                    new List<NuGetFramework>() { },\n+                    \"test.txt\");\n+\n+                var b2Package = Util.CreateTestPackage(\n+                    b2.Id,\n+                    b2.Version.ToString(),\n+                    packagesSourceDirectory,\n+                    new List<NuGetFramework>() { },\n+                    \"test.txt\");\n+\n+                Directory.CreateDirectory(projectDirectory1);\n+\n+                Util.CreateFile(\n+                    projectDirectory1,\n+                    \"proj1.jsproj\",\n+                    Util.CreateProjFileContent(contentFiles: new[] { \"test.txt\" }));\n+\n+                Directory.CreateDirectory(projectDirectory2);\n+\n+                Util.CreateFile(\n+                    projectDirectory2,\n+                    \"proj2.vcxproj\",\n+                    Util.CreateProjFileContent(contentFiles: new[] { \"test.txt\" }));\n+\n+                Util.CreateFile(solutionDirectory, \"a.sln\",\n+                    Util.CreateSolutionFileContent());\n+\n+                var projectFile1 = Path.Combine(projectDirectory1, \"proj1.jsproj\");\n+                var projectFile2 = Path.Combine(projectDirectory2, \"proj2.vcxproj\");\n+                var solutionFile = Path.Combine(solutionDirectory, \"a.sln\");\n+\n+                var testNuGetProjectContext = new TestNuGetProjectContext();\n+                var msbuildDirectory = MsBuildUtility.GetMsbuildDirectory(\"14.0\", null);\n+                var projectSystem1 = new MSBuildProjectSystem(msbuildDirectory, projectFile1, testNuGetProjectContext);\n+                var projectSystem2 = new MSBuildProjectSystem(msbuildDirectory, projectFile2, testNuGetProjectContext);\n+                var msBuildProject1 = new MSBuildNuGetProject(projectSystem1, packagesDirectory, projectDirectory1);\n+                var msBuildProject2 = new MSBuildNuGetProject(projectSystem2, packagesDirectory, projectDirectory2);\n+\n+                using (var stream = File.OpenRead(a1Package))\n+                {\n+                    var downloadResult = new DownloadResourceResult(stream);\n+                    await msBuildProject1.InstallPackageAsync(\n+                        a1,\n+                        downloadResult,\n+                        testNuGetProjectContext,\n+                        CancellationToken.None);\n+                }\n+\n+                using (var stream = File.OpenRead(b1Package))\n+                {\n+                    var downloadResult = new DownloadResourceResult(stream);\n+                    await msBuildProject2.InstallPackageAsync(\n+                        b1,\n+                        downloadResult,\n+                        testNuGetProjectContext,\n+                        CancellationToken.None);\n+                }\n+\n+                projectSystem1.Save();\n+                projectSystem2.Save();\n+\n+                var args = new[]\n+                {\n+                    \"update\",\n+                    solutionFile,\n+                    \"-Source\",\n+                    packagesSourceDirectory\n+                };\n+\n+                var r = CommandRunner.Run(\n+                    Util.GetNuGetExePath(),\n+                    workingPath,\n+                    string.Join(\" \", args),\n+                    waitForExit: true);\n+\n+                Assert.True(r.Item1 == 0, \"Output is \" + r.Item2 + \". Error is \" + r.Item3);\n+\n+                var content1 = File.ReadAllText(projectFile1);\n+                Assert.True(content1.Contains(@\"<Content Include=\"\"test.txt\"\" />\"));","path":"test/NuGet.Clients.Tests/NuGet.CommandLine.Test/NuGetUpdateCommandTests.cs","position":118,"original_position":118,"commit_id":"1347859004956dac97025597143ee67bc53434a7","original_commit_id":"1347859004956dac97025597143ee67bc53434a7","user":{"login":"alpaix","id":8239356,"avatar_url":"https://avatars.githubusercontent.com/u/8239356?v=3","gravatar_id":"","url":"https://api.github.com/users/alpaix","html_url":"https://github.com/alpaix","followers_url":"https://api.github.com/users/alpaix/followers","following_url":"https://api.github.com/users/alpaix/following{/other_user}","gists_url":"https://api.github.com/users/alpaix/gists{/gist_id}","starred_url":"https://api.github.com/users/alpaix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alpaix/subscriptions","organizations_url":"https://api.github.com/users/alpaix/orgs","repos_url":"https://api.github.com/users/alpaix/repos","events_url":"https://api.github.com/users/alpaix/events{/privacy}","received_events_url":"https://api.github.com/users/alpaix/received_events","type":"User","site_admin":false},"body":"`Assert.Contains`","created_at":"2016-06-10T18:11:09Z","updated_at":"2016-06-10T18:11:09Z","html_url":"https://github.com/NuGet/NuGet.Client/pull/662#discussion_r66657316","pull_request_url":"https://api.github.com/repos/NuGet/NuGet.Client/pulls/662","_links":{"self":{"href":"https://api.github.com/repos/NuGet/NuGet.Client/pulls/comments/66657316"},"html":{"href":"https://github.com/NuGet/NuGet.Client/pull/662#discussion_r66657316"},"pull_request":{"href":"https://api.github.com/repos/NuGet/NuGet.Client/pulls/662"}}},"pull_request":{"url":"https://api.github.com/repos/NuGet/NuGet.Client/pulls/662","id":73139660,"html_url":"https://github.com/NuGet/NuGet.Client/pull/662","diff_url":"https://github.com/NuGet/NuGet.Client/pull/662.diff","patch_url":"https://github.com/NuGet/NuGet.Client/pull/662.patch","issue_url":"https://api.github.com/repos/NuGet/NuGet.Client/issues/662","number":662,"state":"open","locked":false,"title":"Setting right TFM when running nuget.exe update for native or js projects","user":{"login":"jainaashish","id":18219758,"avatar_url":"https://avatars.githubusercontent.com/u/18219758?v=3","gravatar_id":"","url":"https://api.github.com/users/jainaashish","html_url":"https://github.com/jainaashish","followers_url":"https://api.github.com/users/jainaashish/followers","following_url":"https://api.github.com/users/jainaashish/following{/other_user}","gists_url":"https://api.github.com/users/jainaashish/gists{/gist_id}","starred_url":"https://api.github.com/users/jainaashish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jainaashish/subscriptions","organizations_url":"https://api.github.com/users/jainaashish/orgs","repos_url":"https://api.github.com/users/jainaashish/repos","events_url":"https://api.github.com/users/jainaashish/events{/privacy}","received_events_url":"https://api.github.com/users/jainaashish/received_events","type":"User","site_admin":false},"body":"Setting right TFM when running nuget.exe update for native or js projects. And using project extension to figure out project type like 'vcxproj' for c++ and 'jsproj' for javascript since msbuild projects don't have Project.Kind property.\r\n\r\nFix https://github.com/NuGet/Home/issues/1291","created_at":"2016-06-08T23:56:08Z","updated_at":"2016-06-10T18:11:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d8800aa07125286b7770b2385a33058a43b2b330","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/NuGet/NuGet.Client/pulls/662/commits","review_comments_url":"https://api.github.com/repos/NuGet/NuGet.Client/pulls/662/comments","review_comment_url":"https://api.github.com/repos/NuGet/NuGet.Client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NuGet/NuGet.Client/issues/662/comments","statuses_url":"https://api.github.com/repos/NuGet/NuGet.Client/statuses/1347859004956dac97025597143ee67bc53434a7","head":{"label":"NuGet:jainaashish/Issue1291","ref":"jainaashish/Issue1291","sha":"1347859004956dac97025597143ee67bc53434a7","user":{"login":"NuGet","id":968310,"avatar_url":"https://avatars.githubusercontent.com/u/968310?v=3","gravatar_id":"","url":"https://api.github.com/users/NuGet","html_url":"https://github.com/NuGet","followers_url":"https://api.github.com/users/NuGet/followers","following_url":"https://api.github.com/users/NuGet/following{/other_user}","gists_url":"https://api.github.com/users/NuGet/gists{/gist_id}","starred_url":"https://api.github.com/users/NuGet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NuGet/subscriptions","organizations_url":"https://api.github.com/users/NuGet/orgs","repos_url":"https://api.github.com/users/NuGet/repos","events_url":"https://api.github.com/users/NuGet/events{/privacy}","received_events_url":"https://api.github.com/users/NuGet/received_events","type":"Organization","site_admin":false},"repo":{"id":19330736,"name":"NuGet.Client","full_name":"NuGet/NuGet.Client","owner":{"login":"NuGet","id":968310,"avatar_url":"https://avatars.githubusercontent.com/u/968310?v=3","gravatar_id":"","url":"https://api.github.com/users/NuGet","html_url":"https://github.com/NuGet","followers_url":"https://api.github.com/users/NuGet/followers","following_url":"https://api.github.com/users/NuGet/following{/other_user}","gists_url":"https://api.github.com/users/NuGet/gists{/gist_id}","starred_url":"https://api.github.com/users/NuGet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NuGet/subscriptions","organizations_url":"https://api.github.com/users/NuGet/orgs","repos_url":"https://api.github.com/users/NuGet/repos","events_url":"https://api.github.com/users/NuGet/events{/privacy}","received_events_url":"https://api.github.com/users/NuGet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NuGet/NuGet.Client","description":"Core client libraries for NuGet Services","fork":false,"url":"https://api.github.com/repos/NuGet/NuGet.Client","forks_url":"https://api.github.com/repos/NuGet/NuGet.Client/forks","keys_url":"https://api.github.com/repos/NuGet/NuGet.Client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NuGet/NuGet.Client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NuGet/NuGet.Client/teams","hooks_url":"https://api.github.com/repos/NuGet/NuGet.Client/hooks","issue_events_url":"https://api.github.com/repos/NuGet/NuGet.Client/issues/events{/number}","events_url":"https://api.github.com/repos/NuGet/NuGet.Client/events","assignees_url":"https://api.github.com/repos/NuGet/NuGet.Client/assignees{/user}","branches_url":"https://api.github.com/repos/NuGet/NuGet.Client/branches{/branch}","tags_url":"https://api.github.com/repos/NuGet/NuGet.Client/tags","blobs_url":"https://api.github.com/repos/NuGet/NuGet.Client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NuGet/NuGet.Client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NuGet/NuGet.Client/git/refs{/sha}","trees_url":"https://api.github.com/repos/NuGet/NuGet.Client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NuGet/NuGet.Client/statuses/{sha}","languages_url":"https://api.github.com/repos/NuGet/NuGet.Client/languages","stargazers_url":"https://api.github.com/repos/NuGet/NuGet.Client/stargazers","contributors_url":"https://api.github.com/repos/NuGet/NuGet.Client/contributors","subscribers_url":"https://api.github.com/repos/NuGet/NuGet.Client/subscribers","subscription_url":"https://api.github.com/repos/NuGet/NuGet.Client/subscription","commits_url":"https://api.github.com/repos/NuGet/NuGet.Client/commits{/sha}","git_commits_url":"https://api.github.com/repos/NuGet/NuGet.Client/git/commits{/sha}","comments_url":"https://api.github.com/repos/NuGet/NuGet.Client/comments{/number}","issue_comment_url":"https://api.github.com/repos/NuGet/NuGet.Client/issues/comments{/number}","contents_url":"https://api.github.com/repos/NuGet/NuGet.Client/contents/{+path}","compare_url":"https://api.github.com/repos/NuGet/NuGet.Client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NuGet/NuGet.Client/merges","archive_url":"https://api.github.com/repos/NuGet/NuGet.Client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NuGet/NuGet.Client/downloads","issues_url":"https://api.github.com/repos/NuGet/NuGet.Client/issues{/number}","pulls_url":"https://api.github.com/repos/NuGet/NuGet.Client/pulls{/number}","milestones_url":"https://api.github.com/repos/NuGet/NuGet.Client/milestones{/number}","notifications_url":"https://api.github.com/repos/NuGet/NuGet.Client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NuGet/NuGet.Client/labels{/name}","releases_url":"https://api.github.com/repos/NuGet/NuGet.Client/releases{/id}","deployments_url":"https://api.github.com/repos/NuGet/NuGet.Client/deployments","created_at":"2014-04-30T23:46:11Z","updated_at":"2016-06-02T21:01:40Z","pushed_at":"2016-06-10T18:05:15Z","git_url":"git://github.com/NuGet/NuGet.Client.git","ssh_url":"git@github.com:NuGet/NuGet.Client.git","clone_url":"https://github.com/NuGet/NuGet.Client.git","svn_url":"https://github.com/NuGet/NuGet.Client","homepage":null,"size":25468,"stargazers_count":68,"watchers_count":68,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":96,"mirror_url":null,"open_issues_count":26,"forks":96,"open_issues":26,"watchers":68,"default_branch":"dev"}},"base":{"label":"NuGet:dev","ref":"dev","sha":"1a0368ab3d0fd44388f0d7563de734260b7815fd","user":{"login":"NuGet","id":968310,"avatar_url":"https://avatars.githubusercontent.com/u/968310?v=3","gravatar_id":"","url":"https://api.github.com/users/NuGet","html_url":"https://github.com/NuGet","followers_url":"https://api.github.com/users/NuGet/followers","following_url":"https://api.github.com/users/NuGet/following{/other_user}","gists_url":"https://api.github.com/users/NuGet/gists{/gist_id}","starred_url":"https://api.github.com/users/NuGet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NuGet/subscriptions","organizations_url":"https://api.github.com/users/NuGet/orgs","repos_url":"https://api.github.com/users/NuGet/repos","events_url":"https://api.github.com/users/NuGet/events{/privacy}","received_events_url":"https://api.github.com/users/NuGet/received_events","type":"Organization","site_admin":false},"repo":{"id":19330736,"name":"NuGet.Client","full_name":"NuGet/NuGet.Client","owner":{"login":"NuGet","id":968310,"avatar_url":"https://avatars.githubusercontent.com/u/968310?v=3","gravatar_id":"","url":"https://api.github.com/users/NuGet","html_url":"https://github.com/NuGet","followers_url":"https://api.github.com/users/NuGet/followers","following_url":"https://api.github.com/users/NuGet/following{/other_user}","gists_url":"https://api.github.com/users/NuGet/gists{/gist_id}","starred_url":"https://api.github.com/users/NuGet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NuGet/subscriptions","organizations_url":"https://api.github.com/users/NuGet/orgs","repos_url":"https://api.github.com/users/NuGet/repos","events_url":"https://api.github.com/users/NuGet/events{/privacy}","received_events_url":"https://api.github.com/users/NuGet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NuGet/NuGet.Client","description":"Core client libraries for NuGet Services","fork":false,"url":"https://api.github.com/repos/NuGet/NuGet.Client","forks_url":"https://api.github.com/repos/NuGet/NuGet.Client/forks","keys_url":"https://api.github.com/repos/NuGet/NuGet.Client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NuGet/NuGet.Client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NuGet/NuGet.Client/teams","hooks_url":"https://api.github.com/repos/NuGet/NuGet.Client/hooks","issue_events_url":"https://api.github.com/repos/NuGet/NuGet.Client/issues/events{/number}","events_url":"https://api.github.com/repos/NuGet/NuGet.Client/events","assignees_url":"https://api.github.com/repos/NuGet/NuGet.Client/assignees{/user}","branches_url":"https://api.github.com/repos/NuGet/NuGet.Client/branches{/branch}","tags_url":"https://api.github.com/repos/NuGet/NuGet.Client/tags","blobs_url":"https://api.github.com/repos/NuGet/NuGet.Client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NuGet/NuGet.Client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NuGet/NuGet.Client/git/refs{/sha}","trees_url":"https://api.github.com/repos/NuGet/NuGet.Client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NuGet/NuGet.Client/statuses/{sha}","languages_url":"https://api.github.com/repos/NuGet/NuGet.Client/languages","stargazers_url":"https://api.github.com/repos/NuGet/NuGet.Client/stargazers","contributors_url":"https://api.github.com/repos/NuGet/NuGet.Client/contributors","subscribers_url":"https://api.github.com/repos/NuGet/NuGet.Client/subscribers","subscription_url":"https://api.github.com/repos/NuGet/NuGet.Client/subscription","commits_url":"https://api.github.com/repos/NuGet/NuGet.Client/commits{/sha}","git_commits_url":"https://api.github.com/repos/NuGet/NuGet.Client/git/commits{/sha}","comments_url":"https://api.github.com/repos/NuGet/NuGet.Client/comments{/number}","issue_comment_url":"https://api.github.com/repos/NuGet/NuGet.Client/issues/comments{/number}","contents_url":"https://api.github.com/repos/NuGet/NuGet.Client/contents/{+path}","compare_url":"https://api.github.com/repos/NuGet/NuGet.Client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NuGet/NuGet.Client/merges","archive_url":"https://api.github.com/repos/NuGet/NuGet.Client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NuGet/NuGet.Client/downloads","issues_url":"https://api.github.com/repos/NuGet/NuGet.Client/issues{/number}","pulls_url":"https://api.github.com/repos/NuGet/NuGet.Client/pulls{/number}","milestones_url":"https://api.github.com/repos/NuGet/NuGet.Client/milestones{/number}","notifications_url":"https://api.github.com/repos/NuGet/NuGet.Client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NuGet/NuGet.Client/labels{/name}","releases_url":"https://api.github.com/repos/NuGet/NuGet.Client/releases{/id}","deployments_url":"https://api.github.com/repos/NuGet/NuGet.Client/deployments","created_at":"2014-04-30T23:46:11Z","updated_at":"2016-06-02T21:01:40Z","pushed_at":"2016-06-10T18:05:15Z","git_url":"git://github.com/NuGet/NuGet.Client.git","ssh_url":"git@github.com:NuGet/NuGet.Client.git","clone_url":"https://github.com/NuGet/NuGet.Client.git","svn_url":"https://github.com/NuGet/NuGet.Client","homepage":null,"size":25468,"stargazers_count":68,"watchers_count":68,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":96,"mirror_url":null,"open_issues_count":26,"forks":96,"open_issues":26,"watchers":68,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/NuGet/NuGet.Client/pulls/662"},"html":{"href":"https://github.com/NuGet/NuGet.Client/pull/662"},"issue":{"href":"https://api.github.com/repos/NuGet/NuGet.Client/issues/662"},"comments":{"href":"https://api.github.com/repos/NuGet/NuGet.Client/issues/662/comments"},"review_comments":{"href":"https://api.github.com/repos/NuGet/NuGet.Client/pulls/662/comments"},"review_comment":{"href":"https://api.github.com/repos/NuGet/NuGet.Client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NuGet/NuGet.Client/pulls/662/commits"},"statuses":{"href":"https://api.github.com/repos/NuGet/NuGet.Client/statuses/1347859004956dac97025597143ee67bc53434a7"}}}}
{"actor":{"display_login":"alpaix"}}