{"action":"closed","number":48,"pull_request":{"url":"https://api.github.com/repos/PhpUnitsOfMeasure/php-units-of-measure/pulls/48","id":44121053,"html_url":"https://github.com/PhpUnitsOfMeasure/php-units-of-measure/pull/48","diff_url":"https://github.com/PhpUnitsOfMeasure/php-units-of-measure/pull/48.diff","patch_url":"https://github.com/PhpUnitsOfMeasure/php-units-of-measure/pull/48.patch","issue_url":"https://api.github.com/repos/PhpUnitsOfMeasure/php-units-of-measure/issues/48","number":48,"state":"closed","locked":false,"title":"PhysicalQuantity interface change","user":{"login":"tlode","id":6391305,"avatar_url":"https://avatars.githubusercontent.com/u/6391305?v=3","gravatar_id":"","url":"https://api.github.com/users/tlode","html_url":"https://github.com/tlode","followers_url":"https://api.github.com/users/tlode/followers","following_url":"https://api.github.com/users/tlode/following{/other_user}","gists_url":"https://api.github.com/users/tlode/gists{/gist_id}","starred_url":"https://api.github.com/users/tlode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tlode/subscriptions","organizations_url":"https://api.github.com/users/tlode/orgs","repos_url":"https://api.github.com/users/tlode/repos","events_url":"https://api.github.com/users/tlode/events{/privacy}","received_events_url":"https://api.github.com/users/tlode/received_events","type":"User","site_admin":false},"body":"Inspired from issue #35 (2.+ 3.) this PR proposes changes to the interface of PhysicalQuantity\r\n\r\nThe interface `PhysicalQuantityInterface` is renamed into `PhysicalQuantity`, which emphasizes more on being a type rather than being an interface (e.g. when being used in type hints).\r\n\r\nMethods `PhysicalQuantity::toUnit()` and `PhysicalQuantity::toNativeUnit()` now return new PhysicalQuantity instances.\r\n\r\nThis PR also adds the missing scalar getter methods `getValue()` and `getUnit()`, which return the original value and the unit when the instance was created. Therefor the static method `AbstractPhysicalQuantity::getUnit()` has to be renamed to `getUnitByNameOrAlias`.\r\n\r\nFinally, removes the non-existant submodule \"vagrant\" `https://github.com/triplepoint/quick-vagrant.git`.\r\n\r\n","created_at":"2015-09-03T15:27:59Z","updated_at":"2016-07-24T22:39:31Z","closed_at":"2016-07-24T22:39:31Z","merged_at":null,"merge_commit_sha":"66b5716cd9941ccc925a1aaf2af8e51dd18493bf","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/PhpUnitsOfMeasure/php-units-of-measure/pulls/48/commits","review_comments_url":"https://api.github.com/repos/PhpUnitsOfMeasure/php-units-of-measure/pulls/48/comments","review_comment_url":"https://api.github.com/repos/PhpUnitsOfMeasure/php-units-of-measure/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PhpUnitsOfMeasure/php-units-of-measure/issues/48/comments","statuses_url":"https://api.github.com/repos/PhpUnitsOfMeasure/php-units-of-measure/statuses/445bcb546e952a1f0f6a825a3bde1307ab07444b","head":{"label":"tlode:feature/value-object","ref":"feature/value-object","sha":"445bcb546e952a1f0f6a825a3bde1307ab07444b","user":{"login":"tlode","id":6391305,"avatar_url":"https://avatars.githubusercontent.com/u/6391305?v=3","gravatar_id":"","url":"https://api.github.com/users/tlode","html_url":"https://github.com/tlode","followers_url":"https://api.github.com/users/tlode/followers","following_url":"https://api.github.com/users/tlode/following{/other_user}","gists_url":"https://api.github.com/users/tlode/gists{/gist_id}","starred_url":"https://api.github.com/users/tlode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tlode/subscriptions","organizations_url":"https://api.github.com/users/tlode/orgs","repos_url":"https://api.github.com/users/tlode/repos","events_url":"https://api.github.com/users/tlode/events{/privacy}","received_events_url":"https://api.github.com/users/tlode/received_events","type":"User","site_admin":false},"repo":{"id":37813888,"name":"php-units-of-measure","full_name":"tlode/php-units-of-measure","owner":{"login":"tlode","id":6391305,"avatar_url":"https://avatars.githubusercontent.com/u/6391305?v=3","gravatar_id":"","url":"https://api.github.com/users/tlode","html_url":"https://github.com/tlode","followers_url":"https://api.github.com/users/tlode/followers","following_url":"https://api.github.com/users/tlode/following{/other_user}","gists_url":"https://api.github.com/users/tlode/gists{/gist_id}","starred_url":"https://api.github.com/users/tlode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tlode/subscriptions","organizations_url":"https://api.github.com/users/tlode/orgs","repos_url":"https://api.github.com/users/tlode/repos","events_url":"https://api.github.com/users/tlode/events{/privacy}","received_events_url":"https://api.github.com/users/tlode/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tlode/php-units-of-measure","description":"A library for handling physical quantities and the units of measure in which they're represented.","fork":true,"url":"https://api.github.com/repos/tlode/php-units-of-measure","forks_url":"https://api.github.com/repos/tlode/php-units-of-measure/forks","keys_url":"https://api.github.com/repos/tlode/php-units-of-measure/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tlode/php-units-of-measure/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tlode/php-units-of-measure/teams","hooks_url":"https://api.github.com/repos/tlode/php-units-of-measure/hooks","issue_events_url":"https://api.github.com/repos/tlode/php-units-of-measure/issues/events{/number}","events_url":"https://api.github.com/repos/tlode/php-units-of-measure/events","assignees_url":"https://api.github.com/repos/tlode/php-units-of-measure/assignees{/user}","branches_url":"https://api.github.com/repos/tlode/php-units-of-measure/branches{/branch}","tags_url":"https://api.github.com/repos/tlode/php-units-of-measure/tags","blobs_url":"https://api.github.com/repos/tlode/php-units-of-measure/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tlode/php-units-of-measure/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tlode/php-units-of-measure/git/refs{/sha}","trees_url":"https://api.github.com/repos/tlode/php-units-of-measure/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tlode/php-units-of-measure/statuses/{sha}","languages_url":"https://api.github.com/repos/tlode/php-units-of-measure/languages","stargazers_url":"https://api.github.com/repos/tlode/php-units-of-measure/stargazers","contributors_url":"https://api.github.com/repos/tlode/php-units-of-measure/contributors","subscribers_url":"https://api.github.com/repos/tlode/php-units-of-measure/subscribers","subscription_url":"https://api.github.com/repos/tlode/php-units-of-measure/subscription","commits_url":"https://api.github.com/repos/tlode/php-units-of-measure/commits{/sha}","git_commits_url":"https://api.github.com/repos/tlode/php-units-of-measure/git/commits{/sha}","comments_url":"https://api.github.com/repos/tlode/php-units-of-measure/comments{/number}","issue_comment_url":"https://api.github.com/repos/tlode/php-units-of-measure/issues/comments{/number}","contents_url":"https://api.github.com/repos/tlode/php-units-of-measure/contents/{+path}","compare_url":"https://api.github.com/repos/tlode/php-units-of-measure/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tlode/php-units-of-measure/merges","archive_url":"https://api.github.com/repos/tlode/php-units-of-measure/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tlode/php-units-of-measure/downloads","issues_url":"https://api.github.com/repos/tlode/php-units-of-measure/issues{/number}","pulls_url":"https://api.github.com/repos/tlode/php-units-of-measure/pulls{/number}","milestones_url":"https://api.github.com/repos/tlode/php-units-of-measure/milestones{/number}","notifications_url":"https://api.github.com/repos/tlode/php-units-of-measure/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tlode/php-units-of-measure/labels{/name}","releases_url":"https://api.github.com/repos/tlode/php-units-of-measure/releases{/id}","deployments_url":"https://api.github.com/repos/tlode/php-units-of-measure/deployments","created_at":"2015-06-21T15:25:59Z","updated_at":"2016-02-01T09:39:26Z","pushed_at":"2016-02-25T20:29:40Z","git_url":"git://github.com/tlode/php-units-of-measure.git","ssh_url":"git@github.com:tlode/php-units-of-measure.git","clone_url":"https://github.com/tlode/php-units-of-measure.git","svn_url":"https://github.com/tlode/php-units-of-measure","homepage":"","size":305,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"PhpUnitsOfMeasure:develop","ref":"develop","sha":"7c332566d9f384ae58b1be93c2f76913d2530812","user":{"login":"PhpUnitsOfMeasure","id":11444274,"avatar_url":"https://avatars.githubusercontent.com/u/11444274?v=3","gravatar_id":"","url":"https://api.github.com/users/PhpUnitsOfMeasure","html_url":"https://github.com/PhpUnitsOfMeasure","followers_url":"https://api.github.com/users/PhpUnitsOfMeasure/followers","following_url":"https://api.github.com/users/PhpUnitsOfMeasure/following{/other_user}","gists_url":"https://api.github.com/users/PhpUnitsOfMeasure/gists{/gist_id}","starred_url":"https://api.github.com/users/PhpUnitsOfMeasure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PhpUnitsOfMeasure/subscriptions","organizations_url":"https://api.github.com/users/PhpUnitsOfMeasure/orgs","repos_url":"https://api.github.com/users/PhpUnitsOfMeasure/repos","events_url":"https://api.github.com/users/PhpUnitsOfMeasure/events{/privacy}","received_events_url":"https://api.github.com/users/PhpUnitsOfMeasure/received_events","type":"Organization","site_admin":false},"repo":{"id":8383871,"name":"php-units-of-measure","full_name":"PhpUnitsOfMeasure/php-units-of-measure","owner":{"login":"PhpUnitsOfMeasure","id":11444274,"avatar_url":"https://avatars.githubusercontent.com/u/11444274?v=3","gravatar_id":"","url":"https://api.github.com/users/PhpUnitsOfMeasure","html_url":"https://github.com/PhpUnitsOfMeasure","followers_url":"https://api.github.com/users/PhpUnitsOfMeasure/followers","following_url":"https://api.github.com/users/PhpUnitsOfMeasure/following{/other_user}","gists_url":"https://api.github.com/users/PhpUnitsOfMeasure/gists{/gist_id}","starred_url":"https://api.github.com/users/PhpUnitsOfMeasure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PhpUnitsOfMeasure/subscriptions","organizations_url":"https://api.github.com/users/PhpUnitsOfMeasure/orgs","repos_url":"https://api.github.com/users/PhpUnitsOfMeasure/repos","events_url":"https://api.github.com/users/PhpUnitsOfMeasure/events{/privacy}","received_events_url":"https://api.github.com/users/PhpUnitsOfMeasure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PhpUnitsOfMeasure/php-units-of-measure","description":"A library for handling physical quantities and the units of measure in which they're represented.","fork":false,"url":"https://api.github.com/repos/PhpUnitsOfMeasure/php-units-of-measure","forks_url":"https://api.github.com/repos/PhpUnitsOfMeasure/php-units-of-measure/forks","keys_url":"https://api.github.com/repos/PhpUnitsOfMeasure/php-units-of-measure/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PhpUnitsOfMeasure/php-units-of-measure/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PhpUnitsOfMeasure/php-units-of-measure/teams","hooks_url":"https://api.github.com/repos/PhpUnitsOfMeasure/php-units-of-measure/hooks","issue_events_url":"https://api.github.com/repos/PhpUnitsOfMeasure/php-units-of-measure/issues/events{/number}","events_url":"https://api.github.com/repos/PhpUnitsOfMeasure/php-units-of-measure/events","assignees_url":"https://api.github.com/repos/PhpUnitsOfMeasure/php-units-of-measure/assignees{/user}","branches_url":"https://api.github.com/repos/PhpUnitsOfMeasure/php-units-of-measure/branches{/branch}","tags_url":"https://api.github.com/repos/PhpUnitsOfMeasure/php-units-of-measure/tags","blobs_url":"https://api.github.com/repos/PhpUnitsOfMeasure/php-units-of-measure/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PhpUnitsOfMeasure/php-units-of-measure/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PhpUnitsOfMeasure/php-units-of-measure/git/refs{/sha}","trees_url":"https://api.github.com/repos/PhpUnitsOfMeasure/php-units-of-measure/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PhpUnitsOfMeasure/php-units-of-measure/statuses/{sha}","languages_url":"https://api.github.com/repos/PhpUnitsOfMeasure/php-units-of-measure/languages","stargazers_url":"https://api.github.com/repos/PhpUnitsOfMeasure/php-units-of-measure/stargazers","contributors_url":"https://api.github.com/repos/PhpUnitsOfMeasure/php-units-of-measure/contributors","subscribers_url":"https://api.github.com/repos/PhpUnitsOfMeasure/php-units-of-measure/subscribers","subscription_url":"https://api.github.com/repos/PhpUnitsOfMeasure/php-units-of-measure/subscription","commits_url":"https://api.github.com/repos/PhpUnitsOfMeasure/php-units-of-measure/commits{/sha}","git_commits_url":"https://api.github.com/repos/PhpUnitsOfMeasure/php-units-of-measure/git/commits{/sha}","comments_url":"https://api.github.com/repos/PhpUnitsOfMeasure/php-units-of-measure/comments{/number}","issue_comment_url":"https://api.github.com/repos/PhpUnitsOfMeasure/php-units-of-measure/issues/comments{/number}","contents_url":"https://api.github.com/repos/PhpUnitsOfMeasure/php-units-of-measure/contents/{+path}","compare_url":"https://api.github.com/repos/PhpUnitsOfMeasure/php-units-of-measure/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PhpUnitsOfMeasure/php-units-of-measure/merges","archive_url":"https://api.github.com/repos/PhpUnitsOfMeasure/php-units-of-measure/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PhpUnitsOfMeasure/php-units-of-measure/downloads","issues_url":"https://api.github.com/repos/PhpUnitsOfMeasure/php-units-of-measure/issues{/number}","pulls_url":"https://api.github.com/repos/PhpUnitsOfMeasure/php-units-of-measure/pulls{/number}","milestones_url":"https://api.github.com/repos/PhpUnitsOfMeasure/php-units-of-measure/milestones{/number}","notifications_url":"https://api.github.com/repos/PhpUnitsOfMeasure/php-units-of-measure/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PhpUnitsOfMeasure/php-units-of-measure/labels{/name}","releases_url":"https://api.github.com/repos/PhpUnitsOfMeasure/php-units-of-measure/releases{/id}","deployments_url":"https://api.github.com/repos/PhpUnitsOfMeasure/php-units-of-measure/deployments","created_at":"2013-02-23T23:52:08Z","updated_at":"2016-07-21T23:56:23Z","pushed_at":"2016-07-24T22:39:31Z","git_url":"git://github.com/PhpUnitsOfMeasure/php-units-of-measure.git","ssh_url":"git@github.com:PhpUnitsOfMeasure/php-units-of-measure.git","clone_url":"https://github.com/PhpUnitsOfMeasure/php-units-of-measure.git","svn_url":"https://github.com/PhpUnitsOfMeasure/php-units-of-measure","homepage":"","size":256,"stargazers_count":118,"watchers_count":118,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":42,"mirror_url":null,"open_issues_count":10,"forks":42,"open_issues":10,"watchers":118,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PhpUnitsOfMeasure/php-units-of-measure/pulls/48"},"html":{"href":"https://github.com/PhpUnitsOfMeasure/php-units-of-measure/pull/48"},"issue":{"href":"https://api.github.com/repos/PhpUnitsOfMeasure/php-units-of-measure/issues/48"},"comments":{"href":"https://api.github.com/repos/PhpUnitsOfMeasure/php-units-of-measure/issues/48/comments"},"review_comments":{"href":"https://api.github.com/repos/PhpUnitsOfMeasure/php-units-of-measure/pulls/48/comments"},"review_comment":{"href":"https://api.github.com/repos/PhpUnitsOfMeasure/php-units-of-measure/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PhpUnitsOfMeasure/php-units-of-measure/pulls/48/commits"},"statuses":{"href":"https://api.github.com/repos/PhpUnitsOfMeasure/php-units-of-measure/statuses/445bcb546e952a1f0f6a825a3bde1307ab07444b"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":1,"review_comments":0,"commits":9,"additions":373,"deletions":83,"changed_files":19}}
{"actor":{"display_login":"triplepoint"}}