{"action":"created","comment":{"url":"https://api.github.com/repos/cloudfoundry-incubator/routing-release/pulls/comments/87105822","pull_request_review_id":7731467,"id":87105822,"diff_hunk":"@@ -108,3 +108,7 @@ properties:\n   routing_api.lock_retry_interval:\n     description: \"interval to wait before retrying a failed lock acquisition\"\n     default: \"5s\"\n+\n+  routing_api.listen_ip:\n+    description: \"IP for routing api to listen on\"\n+    default: \"0.0.0.0\"","path":"jobs/routing-api/spec","position":7,"original_position":7,"commit_id":"a143730fb3eb9cedbe644e213780a7237ba34227","original_commit_id":"a143730fb3eb9cedbe644e213780a7237ba34227","user":{"login":"shalako","id":156568,"avatar_url":"https://avatars.githubusercontent.com/u/156568?v=3","gravatar_id":"","url":"https://api.github.com/users/shalako","html_url":"https://github.com/shalako","followers_url":"https://api.github.com/users/shalako/followers","following_url":"https://api.github.com/users/shalako/following{/other_user}","gists_url":"https://api.github.com/users/shalako/gists{/gist_id}","starred_url":"https://api.github.com/users/shalako/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shalako/subscriptions","organizations_url":"https://api.github.com/users/shalako/orgs","repos_url":"https://api.github.com/users/shalako/repos","events_url":"https://api.github.com/users/shalako/events{/privacy}","received_events_url":"https://api.github.com/users/shalako/received_events","type":"User","site_admin":false},"body":"Why is the default for this property different from the default for `haproxy.health_check_ip`?","created_at":"2016-11-08T23:14:56Z","updated_at":"2016-11-08T23:14:56Z","html_url":"https://github.com/cloudfoundry-incubator/routing-release/pull/54#discussion_r87105822","pull_request_url":"https://api.github.com/repos/cloudfoundry-incubator/routing-release/pulls/54","_links":{"self":{"href":"https://api.github.com/repos/cloudfoundry-incubator/routing-release/pulls/comments/87105822"},"html":{"href":"https://github.com/cloudfoundry-incubator/routing-release/pull/54#discussion_r87105822"},"pull_request":{"href":"https://api.github.com/repos/cloudfoundry-incubator/routing-release/pulls/54"}}},"pull_request":{"url":"https://api.github.com/repos/cloudfoundry-incubator/routing-release/pulls/54","id":92796024,"html_url":"https://github.com/cloudfoundry-incubator/routing-release/pull/54","diff_url":"https://github.com/cloudfoundry-incubator/routing-release/pull/54.diff","patch_url":"https://github.com/cloudfoundry-incubator/routing-release/pull/54.patch","issue_url":"https://api.github.com/repos/cloudfoundry-incubator/routing-release/issues/54","number":54,"state":"open","locked":false,"title":"Make tcp-router heathcheck ip and routing-api listen ip configurable","user":{"login":"mdelillo","id":6590106,"avatar_url":"https://avatars.githubusercontent.com/u/6590106?v=3","gravatar_id":"","url":"https://api.github.com/users/mdelillo","html_url":"https://github.com/mdelillo","followers_url":"https://api.github.com/users/mdelillo/followers","following_url":"https://api.github.com/users/mdelillo/following{/other_user}","gists_url":"https://api.github.com/users/mdelillo/gists{/gist_id}","starred_url":"https://api.github.com/users/mdelillo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdelillo/subscriptions","organizations_url":"https://api.github.com/users/mdelillo/orgs","repos_url":"https://api.github.com/users/mdelillo/repos","events_url":"https://api.github.com/users/mdelillo/events{/privacy}","received_events_url":"https://api.github.com/users/mdelillo/received_events","type":"User","site_admin":false},"body":"This allows haproxy and routing-api to bind to specific interfaces (i.e. localhost) instead of all interfaces.\r\n\r\nCorresponding routing-api PR: https://github.com/cloudfoundry-incubator/routing-api/pull/9\r\n\r\n@mdelillo @aemengo ","created_at":"2016-11-08T15:11:49Z","updated_at":"2016-11-08T23:14:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"93ebed2074e0beef275ab136fd3d2ebc5c2f3a99","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/cloudfoundry-incubator/routing-release/pulls/54/commits","review_comments_url":"https://api.github.com/repos/cloudfoundry-incubator/routing-release/pulls/54/comments","review_comment_url":"https://api.github.com/repos/cloudfoundry-incubator/routing-release/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cloudfoundry-incubator/routing-release/issues/54/comments","statuses_url":"https://api.github.com/repos/cloudfoundry-incubator/routing-release/statuses/a143730fb3eb9cedbe644e213780a7237ba34227","head":{"label":"pcfdev-forks:configurable-ips","ref":"configurable-ips","sha":"a143730fb3eb9cedbe644e213780a7237ba34227","user":{"login":"pcfdev-forks","id":18557471,"avatar_url":"https://avatars.githubusercontent.com/u/18557471?v=3","gravatar_id":"","url":"https://api.github.com/users/pcfdev-forks","html_url":"https://github.com/pcfdev-forks","followers_url":"https://api.github.com/users/pcfdev-forks/followers","following_url":"https://api.github.com/users/pcfdev-forks/following{/other_user}","gists_url":"https://api.github.com/users/pcfdev-forks/gists{/gist_id}","starred_url":"https://api.github.com/users/pcfdev-forks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pcfdev-forks/subscriptions","organizations_url":"https://api.github.com/users/pcfdev-forks/orgs","repos_url":"https://api.github.com/users/pcfdev-forks/repos","events_url":"https://api.github.com/users/pcfdev-forks/events{/privacy}","received_events_url":"https://api.github.com/users/pcfdev-forks/received_events","type":"Organization","site_admin":false},"repo":{"id":72135930,"name":"routing-release","full_name":"pcfdev-forks/routing-release","owner":{"login":"pcfdev-forks","id":18557471,"avatar_url":"https://avatars.githubusercontent.com/u/18557471?v=3","gravatar_id":"","url":"https://api.github.com/users/pcfdev-forks","html_url":"https://github.com/pcfdev-forks","followers_url":"https://api.github.com/users/pcfdev-forks/followers","following_url":"https://api.github.com/users/pcfdev-forks/following{/other_user}","gists_url":"https://api.github.com/users/pcfdev-forks/gists{/gist_id}","starred_url":"https://api.github.com/users/pcfdev-forks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pcfdev-forks/subscriptions","organizations_url":"https://api.github.com/users/pcfdev-forks/orgs","repos_url":"https://api.github.com/users/pcfdev-forks/repos","events_url":"https://api.github.com/users/pcfdev-forks/events{/privacy}","received_events_url":"https://api.github.com/users/pcfdev-forks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pcfdev-forks/routing-release","description":"This is BOSH release for cloud foundry routers","fork":true,"url":"https://api.github.com/repos/pcfdev-forks/routing-release","forks_url":"https://api.github.com/repos/pcfdev-forks/routing-release/forks","keys_url":"https://api.github.com/repos/pcfdev-forks/routing-release/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pcfdev-forks/routing-release/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pcfdev-forks/routing-release/teams","hooks_url":"https://api.github.com/repos/pcfdev-forks/routing-release/hooks","issue_events_url":"https://api.github.com/repos/pcfdev-forks/routing-release/issues/events{/number}","events_url":"https://api.github.com/repos/pcfdev-forks/routing-release/events","assignees_url":"https://api.github.com/repos/pcfdev-forks/routing-release/assignees{/user}","branches_url":"https://api.github.com/repos/pcfdev-forks/routing-release/branches{/branch}","tags_url":"https://api.github.com/repos/pcfdev-forks/routing-release/tags","blobs_url":"https://api.github.com/repos/pcfdev-forks/routing-release/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pcfdev-forks/routing-release/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pcfdev-forks/routing-release/git/refs{/sha}","trees_url":"https://api.github.com/repos/pcfdev-forks/routing-release/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pcfdev-forks/routing-release/statuses/{sha}","languages_url":"https://api.github.com/repos/pcfdev-forks/routing-release/languages","stargazers_url":"https://api.github.com/repos/pcfdev-forks/routing-release/stargazers","contributors_url":"https://api.github.com/repos/pcfdev-forks/routing-release/contributors","subscribers_url":"https://api.github.com/repos/pcfdev-forks/routing-release/subscribers","subscription_url":"https://api.github.com/repos/pcfdev-forks/routing-release/subscription","commits_url":"https://api.github.com/repos/pcfdev-forks/routing-release/commits{/sha}","git_commits_url":"https://api.github.com/repos/pcfdev-forks/routing-release/git/commits{/sha}","comments_url":"https://api.github.com/repos/pcfdev-forks/routing-release/comments{/number}","issue_comment_url":"https://api.github.com/repos/pcfdev-forks/routing-release/issues/comments{/number}","contents_url":"https://api.github.com/repos/pcfdev-forks/routing-release/contents/{+path}","compare_url":"https://api.github.com/repos/pcfdev-forks/routing-release/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pcfdev-forks/routing-release/merges","archive_url":"https://api.github.com/repos/pcfdev-forks/routing-release/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pcfdev-forks/routing-release/downloads","issues_url":"https://api.github.com/repos/pcfdev-forks/routing-release/issues{/number}","pulls_url":"https://api.github.com/repos/pcfdev-forks/routing-release/pulls{/number}","milestones_url":"https://api.github.com/repos/pcfdev-forks/routing-release/milestones{/number}","notifications_url":"https://api.github.com/repos/pcfdev-forks/routing-release/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pcfdev-forks/routing-release/labels{/name}","releases_url":"https://api.github.com/repos/pcfdev-forks/routing-release/releases{/id}","deployments_url":"https://api.github.com/repos/pcfdev-forks/routing-release/deployments","created_at":"2016-10-27T18:20:43Z","updated_at":"2016-10-27T18:20:44Z","pushed_at":"2016-11-08T15:10:56Z","git_url":"git://github.com/pcfdev-forks/routing-release.git","ssh_url":"git@github.com:pcfdev-forks/routing-release.git","clone_url":"https://github.com/pcfdev-forks/routing-release.git","svn_url":"https://github.com/pcfdev-forks/routing-release","homepage":null,"size":1140,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"cloudfoundry-incubator:develop","ref":"develop","sha":"182feea3911d21cb440fa41610e917711a1d74ba","user":{"login":"cloudfoundry-incubator","id":5680605,"avatar_url":"https://avatars.githubusercontent.com/u/5680605?v=3","gravatar_id":"","url":"https://api.github.com/users/cloudfoundry-incubator","html_url":"https://github.com/cloudfoundry-incubator","followers_url":"https://api.github.com/users/cloudfoundry-incubator/followers","following_url":"https://api.github.com/users/cloudfoundry-incubator/following{/other_user}","gists_url":"https://api.github.com/users/cloudfoundry-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudfoundry-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudfoundry-incubator/subscriptions","organizations_url":"https://api.github.com/users/cloudfoundry-incubator/orgs","repos_url":"https://api.github.com/users/cloudfoundry-incubator/repos","events_url":"https://api.github.com/users/cloudfoundry-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/cloudfoundry-incubator/received_events","type":"Organization","site_admin":false},"repo":{"id":36821001,"name":"routing-release","full_name":"cloudfoundry-incubator/routing-release","owner":{"login":"cloudfoundry-incubator","id":5680605,"avatar_url":"https://avatars.githubusercontent.com/u/5680605?v=3","gravatar_id":"","url":"https://api.github.com/users/cloudfoundry-incubator","html_url":"https://github.com/cloudfoundry-incubator","followers_url":"https://api.github.com/users/cloudfoundry-incubator/followers","following_url":"https://api.github.com/users/cloudfoundry-incubator/following{/other_user}","gists_url":"https://api.github.com/users/cloudfoundry-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudfoundry-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudfoundry-incubator/subscriptions","organizations_url":"https://api.github.com/users/cloudfoundry-incubator/orgs","repos_url":"https://api.github.com/users/cloudfoundry-incubator/repos","events_url":"https://api.github.com/users/cloudfoundry-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/cloudfoundry-incubator/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cloudfoundry-incubator/routing-release","description":"This is BOSH release for cloud foundry routers","fork":false,"url":"https://api.github.com/repos/cloudfoundry-incubator/routing-release","forks_url":"https://api.github.com/repos/cloudfoundry-incubator/routing-release/forks","keys_url":"https://api.github.com/repos/cloudfoundry-incubator/routing-release/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cloudfoundry-incubator/routing-release/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cloudfoundry-incubator/routing-release/teams","hooks_url":"https://api.github.com/repos/cloudfoundry-incubator/routing-release/hooks","issue_events_url":"https://api.github.com/repos/cloudfoundry-incubator/routing-release/issues/events{/number}","events_url":"https://api.github.com/repos/cloudfoundry-incubator/routing-release/events","assignees_url":"https://api.github.com/repos/cloudfoundry-incubator/routing-release/assignees{/user}","branches_url":"https://api.github.com/repos/cloudfoundry-incubator/routing-release/branches{/branch}","tags_url":"https://api.github.com/repos/cloudfoundry-incubator/routing-release/tags","blobs_url":"https://api.github.com/repos/cloudfoundry-incubator/routing-release/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cloudfoundry-incubator/routing-release/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cloudfoundry-incubator/routing-release/git/refs{/sha}","trees_url":"https://api.github.com/repos/cloudfoundry-incubator/routing-release/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cloudfoundry-incubator/routing-release/statuses/{sha}","languages_url":"https://api.github.com/repos/cloudfoundry-incubator/routing-release/languages","stargazers_url":"https://api.github.com/repos/cloudfoundry-incubator/routing-release/stargazers","contributors_url":"https://api.github.com/repos/cloudfoundry-incubator/routing-release/contributors","subscribers_url":"https://api.github.com/repos/cloudfoundry-incubator/routing-release/subscribers","subscription_url":"https://api.github.com/repos/cloudfoundry-incubator/routing-release/subscription","commits_url":"https://api.github.com/repos/cloudfoundry-incubator/routing-release/commits{/sha}","git_commits_url":"https://api.github.com/repos/cloudfoundry-incubator/routing-release/git/commits{/sha}","comments_url":"https://api.github.com/repos/cloudfoundry-incubator/routing-release/comments{/number}","issue_comment_url":"https://api.github.com/repos/cloudfoundry-incubator/routing-release/issues/comments{/number}","contents_url":"https://api.github.com/repos/cloudfoundry-incubator/routing-release/contents/{+path}","compare_url":"https://api.github.com/repos/cloudfoundry-incubator/routing-release/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cloudfoundry-incubator/routing-release/merges","archive_url":"https://api.github.com/repos/cloudfoundry-incubator/routing-release/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cloudfoundry-incubator/routing-release/downloads","issues_url":"https://api.github.com/repos/cloudfoundry-incubator/routing-release/issues{/number}","pulls_url":"https://api.github.com/repos/cloudfoundry-incubator/routing-release/pulls{/number}","milestones_url":"https://api.github.com/repos/cloudfoundry-incubator/routing-release/milestones{/number}","notifications_url":"https://api.github.com/repos/cloudfoundry-incubator/routing-release/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cloudfoundry-incubator/routing-release/labels{/name}","releases_url":"https://api.github.com/repos/cloudfoundry-incubator/routing-release/releases{/id}","deployments_url":"https://api.github.com/repos/cloudfoundry-incubator/routing-release/deployments","created_at":"2015-06-03T18:01:54Z","updated_at":"2016-10-26T23:38:10Z","pushed_at":"2016-11-08T23:06:55Z","git_url":"git://github.com/cloudfoundry-incubator/routing-release.git","ssh_url":"git@github.com:cloudfoundry-incubator/routing-release.git","clone_url":"https://github.com/cloudfoundry-incubator/routing-release.git","svn_url":"https://github.com/cloudfoundry-incubator/routing-release","homepage":null,"size":1165,"stargazers_count":12,"watchers_count":12,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"open_issues_count":5,"forks":23,"open_issues":5,"watchers":12,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/cloudfoundry-incubator/routing-release/pulls/54"},"html":{"href":"https://github.com/cloudfoundry-incubator/routing-release/pull/54"},"issue":{"href":"https://api.github.com/repos/cloudfoundry-incubator/routing-release/issues/54"},"comments":{"href":"https://api.github.com/repos/cloudfoundry-incubator/routing-release/issues/54/comments"},"review_comments":{"href":"https://api.github.com/repos/cloudfoundry-incubator/routing-release/pulls/54/comments"},"review_comment":{"href":"https://api.github.com/repos/cloudfoundry-incubator/routing-release/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cloudfoundry-incubator/routing-release/pulls/54/commits"},"statuses":{"href":"https://api.github.com/repos/cloudfoundry-incubator/routing-release/statuses/a143730fb3eb9cedbe644e213780a7237ba34227"}}}}
{"actor":{"display_login":"shalako"}}