{"action":"created","issue":{"url":"https://api.github.com/repos/voxpupuli/puppet-nginx/issues/881","repository_url":"https://api.github.com/repos/voxpupuli/puppet-nginx","labels_url":"https://api.github.com/repos/voxpupuli/puppet-nginx/issues/881/labels{/name}","comments_url":"https://api.github.com/repos/voxpupuli/puppet-nginx/issues/881/comments","events_url":"https://api.github.com/repos/voxpupuli/puppet-nginx/issues/881/events","html_url":"https://github.com/voxpupuli/puppet-nginx/pull/881","id":178701809,"number":881,"title":"Add additional config variables with default values (update of #693)","user":{"login":"wyardley","id":10714426,"avatar_url":"https://avatars.githubusercontent.com/u/10714426?v=3","gravatar_id":"","url":"https://api.github.com/users/wyardley","html_url":"https://github.com/wyardley","followers_url":"https://api.github.com/users/wyardley/followers","following_url":"https://api.github.com/users/wyardley/following{/other_user}","gists_url":"https://api.github.com/users/wyardley/gists{/gist_id}","starred_url":"https://api.github.com/users/wyardley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wyardley/subscriptions","organizations_url":"https://api.github.com/users/wyardley/orgs","repos_url":"https://api.github.com/users/wyardley/repos","events_url":"https://api.github.com/users/wyardley/events{/privacy}","received_events_url":"https://api.github.com/users/wyardley/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-09-22T19:39:26Z","updated_at":"2016-10-23T00:05:48Z","closed_at":"2016-09-29T21:48:22Z","pull_request":{"url":"https://api.github.com/repos/voxpupuli/puppet-nginx/pulls/881","html_url":"https://github.com/voxpupuli/puppet-nginx/pull/881","diff_url":"https://github.com/voxpupuli/puppet-nginx/pull/881.diff","patch_url":"https://github.com/voxpupuli/puppet-nginx/pull/881.patch"},"body":"This is a rework of @victorgp's #693 that rebases against current master, and adds tests for the new parameters (the two reasons that PR seems to have been stalled).\r\n\r\nI also removed what appear to be a few duplicate tests (let me know if I'm wrong), and realigned dashes in one section of the docs, though mostly tried not to change too much formatting.\r\n\r\nI squashed his and my commits, though left attribution for @victorgp's original commit. I don't think I can commit back to the PR since I'm not in the org, but let me know if that's the preferred way to do it (vs. submitting a new PR).\r\n\r\nI tried to follow the existing conventions, but It would be great if someone could review my changes to the tests, as well as review the formatting and ordering of directives within nginx.conf."},"comment":{"url":"https://api.github.com/repos/voxpupuli/puppet-nginx/issues/comments/255561425","html_url":"https://github.com/voxpupuli/puppet-nginx/pull/881#issuecomment-255561425","issue_url":"https://api.github.com/repos/voxpupuli/puppet-nginx/issues/881","id":255561425,"user":{"login":"wyardley","id":10714426,"avatar_url":"https://avatars.githubusercontent.com/u/10714426?v=3","gravatar_id":"","url":"https://api.github.com/users/wyardley","html_url":"https://github.com/wyardley","followers_url":"https://api.github.com/users/wyardley/followers","following_url":"https://api.github.com/users/wyardley/following{/other_user}","gists_url":"https://api.github.com/users/wyardley/gists{/gist_id}","starred_url":"https://api.github.com/users/wyardley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wyardley/subscriptions","organizations_url":"https://api.github.com/users/wyardley/orgs","repos_url":"https://api.github.com/users/wyardley/repos","events_url":"https://api.github.com/users/wyardley/events{/privacy}","received_events_url":"https://api.github.com/users/wyardley/received_events","type":"User","site_admin":false},"created_at":"2016-10-23T00:05:48Z","updated_at":"2016-10-23T00:05:48Z","body":"@pschichtel: We have a few PRs in progress that should go out first, but shooting to cut a Forge release pretty soon. It'll be a big one, with a few breaking changes.\r\n\r\nHoping to get this out within the next week or so."}}
{"actor":{"display_login":"wyardley"}}