{"action":"created","comment":{"url":"https://api.github.com/repos/v0dro/daru/pulls/comments/64993372","id":64993372,"diff_hunk":"@@ -112,33 +112,17 @@ def from_plaintext path, fields\n       # Create DataFrame by specifying rows as an Array of Arrays or Array of\n       # Daru::Vector objects.\n       def rows source, opts={}\n-        first = source.first\n-\n         raise SizeError, 'All vectors must have same length' \\\n-          unless source.all? { |v| v.size == first.size }\n-\n-        index = []\n-        opts[:order] ||=\n-          case first\n-          when Daru::Vector # assume that all are Vectors\n-            # FIXME: Not sure, why index is set from vectors","path":"lib/daru/dataframe.rb","position":22,"original_position":22,"commit_id":"ba6611f9ec16a28569370ab159a702e768376a01","original_commit_id":"ba6611f9ec16a28569370ab159a702e768376a01","user":{"login":"v0dro","id":2629909,"avatar_url":"https://avatars.githubusercontent.com/u/2629909?v=3","gravatar_id":"","url":"https://api.github.com/users/v0dro","html_url":"https://github.com/v0dro","followers_url":"https://api.github.com/users/v0dro/followers","following_url":"https://api.github.com/users/v0dro/following{/other_user}","gists_url":"https://api.github.com/users/v0dro/gists{/gist_id}","starred_url":"https://api.github.com/users/v0dro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/v0dro/subscriptions","organizations_url":"https://api.github.com/users/v0dro/orgs","repos_url":"https://api.github.com/users/v0dro/repos","events_url":"https://api.github.com/users/v0dro/events{/privacy}","received_events_url":"https://api.github.com/users/v0dro/received_events","type":"User","site_admin":false},"body":"The `:order` provided by the user should over ride the indexes pointed to by the Vectors. The `||=` in that case should not be there.","created_at":"2016-05-28T20:04:26Z","updated_at":"2016-05-28T20:04:26Z","html_url":"https://github.com/v0dro/daru/pull/123#discussion_r64993372","pull_request_url":"https://api.github.com/repos/v0dro/daru/pulls/123","_links":{"self":{"href":"https://api.github.com/repos/v0dro/daru/pulls/comments/64993372"},"html":{"href":"https://github.com/v0dro/daru/pull/123#discussion_r64993372"},"pull_request":{"href":"https://api.github.com/repos/v0dro/daru/pulls/123"}}},"pull_request":{"url":"https://api.github.com/repos/v0dro/daru/pulls/123","id":69556759,"html_url":"https://github.com/v0dro/daru/pull/123","diff_url":"https://github.com/v0dro/daru/pull/123.diff","patch_url":"https://github.com/v0dro/daru/pull/123.patch","issue_url":"https://api.github.com/repos/v0dro/daru/issues/123","number":123,"state":"open","locked":false,"title":"Large codebase refactoring","user":{"login":"zverok","id":129656,"avatar_url":"https://avatars.githubusercontent.com/u/129656?v=3","gravatar_id":"","url":"https://api.github.com/users/zverok","html_url":"https://github.com/zverok","followers_url":"https://api.github.com/users/zverok/followers","following_url":"https://api.github.com/users/zverok/following{/other_user}","gists_url":"https://api.github.com/users/zverok/gists{/gist_id}","starred_url":"https://api.github.com/users/zverok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zverok/subscriptions","organizations_url":"https://api.github.com/users/zverok/orgs","repos_url":"https://api.github.com/users/zverok/repos","events_url":"https://api.github.com/users/zverok/events{/privacy}","received_events_url":"https://api.github.com/users/zverok/received_events","type":"User","site_admin":false},"body":"**Warning!** This is definitely work-in-progress (and in early stages of it!). Pull request is created so @v0dro and others could observe the progress, comment and tell their preferences on code style.\r\n\r\nTarget of this pull request is to refactor daru codebase (**without** any changes in functionality, except maybe for small service methods additions) so that it conform to some pretty strict code quality metrics, both trivial (like method length/module length) and semantic (like perceived complexity and assignment branch condition size), with other eventual cleanups here and there.\r\n\r\nAlso, as a part of this pull request I propose (but can revoke this proposal) to update minimal Ruby version requirement to 2.1, which is lowest of currently supported versions, and unlike 2.0, provides proper handling of keyword arguments.\r\n\r\nSo, you can read through it, or ignore it for now :) I'll tell when I am finished!","created_at":"2016-05-10T18:43:15Z","updated_at":"2016-05-28T20:04:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0a9e72b75d0e6c2c7d90f5eb55ed8135e6933488","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/v0dro/daru/pulls/123/commits","review_comments_url":"https://api.github.com/repos/v0dro/daru/pulls/123/comments","review_comment_url":"https://api.github.com/repos/v0dro/daru/pulls/comments{/number}","comments_url":"https://api.github.com/repos/v0dro/daru/issues/123/comments","statuses_url":"https://api.github.com/repos/v0dro/daru/statuses/ba6611f9ec16a28569370ab159a702e768376a01","head":{"label":"zverok:rubocop2-refactor","ref":"rubocop2-refactor","sha":"ba6611f9ec16a28569370ab159a702e768376a01","user":{"login":"zverok","id":129656,"avatar_url":"https://avatars.githubusercontent.com/u/129656?v=3","gravatar_id":"","url":"https://api.github.com/users/zverok","html_url":"https://github.com/zverok","followers_url":"https://api.github.com/users/zverok/followers","following_url":"https://api.github.com/users/zverok/following{/other_user}","gists_url":"https://api.github.com/users/zverok/gists{/gist_id}","starred_url":"https://api.github.com/users/zverok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zverok/subscriptions","organizations_url":"https://api.github.com/users/zverok/orgs","repos_url":"https://api.github.com/users/zverok/repos","events_url":"https://api.github.com/users/zverok/events{/privacy}","received_events_url":"https://api.github.com/users/zverok/received_events","type":"User","site_admin":false},"repo":{"id":58209934,"name":"daru","full_name":"zverok/daru","owner":{"login":"zverok","id":129656,"avatar_url":"https://avatars.githubusercontent.com/u/129656?v=3","gravatar_id":"","url":"https://api.github.com/users/zverok","html_url":"https://github.com/zverok","followers_url":"https://api.github.com/users/zverok/followers","following_url":"https://api.github.com/users/zverok/following{/other_user}","gists_url":"https://api.github.com/users/zverok/gists{/gist_id}","starred_url":"https://api.github.com/users/zverok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zverok/subscriptions","organizations_url":"https://api.github.com/users/zverok/orgs","repos_url":"https://api.github.com/users/zverok/repos","events_url":"https://api.github.com/users/zverok/events{/privacy}","received_events_url":"https://api.github.com/users/zverok/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zverok/daru","description":"Data Analysis in RUby","fork":true,"url":"https://api.github.com/repos/zverok/daru","forks_url":"https://api.github.com/repos/zverok/daru/forks","keys_url":"https://api.github.com/repos/zverok/daru/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zverok/daru/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zverok/daru/teams","hooks_url":"https://api.github.com/repos/zverok/daru/hooks","issue_events_url":"https://api.github.com/repos/zverok/daru/issues/events{/number}","events_url":"https://api.github.com/repos/zverok/daru/events","assignees_url":"https://api.github.com/repos/zverok/daru/assignees{/user}","branches_url":"https://api.github.com/repos/zverok/daru/branches{/branch}","tags_url":"https://api.github.com/repos/zverok/daru/tags","blobs_url":"https://api.github.com/repos/zverok/daru/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zverok/daru/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zverok/daru/git/refs{/sha}","trees_url":"https://api.github.com/repos/zverok/daru/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zverok/daru/statuses/{sha}","languages_url":"https://api.github.com/repos/zverok/daru/languages","stargazers_url":"https://api.github.com/repos/zverok/daru/stargazers","contributors_url":"https://api.github.com/repos/zverok/daru/contributors","subscribers_url":"https://api.github.com/repos/zverok/daru/subscribers","subscription_url":"https://api.github.com/repos/zverok/daru/subscription","commits_url":"https://api.github.com/repos/zverok/daru/commits{/sha}","git_commits_url":"https://api.github.com/repos/zverok/daru/git/commits{/sha}","comments_url":"https://api.github.com/repos/zverok/daru/comments{/number}","issue_comment_url":"https://api.github.com/repos/zverok/daru/issues/comments{/number}","contents_url":"https://api.github.com/repos/zverok/daru/contents/{+path}","compare_url":"https://api.github.com/repos/zverok/daru/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zverok/daru/merges","archive_url":"https://api.github.com/repos/zverok/daru/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zverok/daru/downloads","issues_url":"https://api.github.com/repos/zverok/daru/issues{/number}","pulls_url":"https://api.github.com/repos/zverok/daru/pulls{/number}","milestones_url":"https://api.github.com/repos/zverok/daru/milestones{/number}","notifications_url":"https://api.github.com/repos/zverok/daru/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zverok/daru/labels{/name}","releases_url":"https://api.github.com/repos/zverok/daru/releases{/id}","deployments_url":"https://api.github.com/repos/zverok/daru/deployments","created_at":"2016-05-06T13:40:34Z","updated_at":"2016-05-06T13:40:35Z","pushed_at":"2016-05-27T06:28:11Z","git_url":"git://github.com/zverok/daru.git","ssh_url":"git@github.com:zverok/daru.git","clone_url":"https://github.com/zverok/daru.git","svn_url":"https://github.com/zverok/daru","homepage":null,"size":3348,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"v0dro:master","ref":"master","sha":"2ee4c4c1d0a3d8a11316e569b55967bd601771e5","user":{"login":"v0dro","id":2629909,"avatar_url":"https://avatars.githubusercontent.com/u/2629909?v=3","gravatar_id":"","url":"https://api.github.com/users/v0dro","html_url":"https://github.com/v0dro","followers_url":"https://api.github.com/users/v0dro/followers","following_url":"https://api.github.com/users/v0dro/following{/other_user}","gists_url":"https://api.github.com/users/v0dro/gists{/gist_id}","starred_url":"https://api.github.com/users/v0dro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/v0dro/subscriptions","organizations_url":"https://api.github.com/users/v0dro/orgs","repos_url":"https://api.github.com/users/v0dro/repos","events_url":"https://api.github.com/users/v0dro/events{/privacy}","received_events_url":"https://api.github.com/users/v0dro/received_events","type":"User","site_admin":false},"repo":{"id":24784998,"name":"daru","full_name":"v0dro/daru","owner":{"login":"v0dro","id":2629909,"avatar_url":"https://avatars.githubusercontent.com/u/2629909?v=3","gravatar_id":"","url":"https://api.github.com/users/v0dro","html_url":"https://github.com/v0dro","followers_url":"https://api.github.com/users/v0dro/followers","following_url":"https://api.github.com/users/v0dro/following{/other_user}","gists_url":"https://api.github.com/users/v0dro/gists{/gist_id}","starred_url":"https://api.github.com/users/v0dro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/v0dro/subscriptions","organizations_url":"https://api.github.com/users/v0dro/orgs","repos_url":"https://api.github.com/users/v0dro/repos","events_url":"https://api.github.com/users/v0dro/events{/privacy}","received_events_url":"https://api.github.com/users/v0dro/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/v0dro/daru","description":"Data Analysis in RUby","fork":false,"url":"https://api.github.com/repos/v0dro/daru","forks_url":"https://api.github.com/repos/v0dro/daru/forks","keys_url":"https://api.github.com/repos/v0dro/daru/keys{/key_id}","collaborators_url":"https://api.github.com/repos/v0dro/daru/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/v0dro/daru/teams","hooks_url":"https://api.github.com/repos/v0dro/daru/hooks","issue_events_url":"https://api.github.com/repos/v0dro/daru/issues/events{/number}","events_url":"https://api.github.com/repos/v0dro/daru/events","assignees_url":"https://api.github.com/repos/v0dro/daru/assignees{/user}","branches_url":"https://api.github.com/repos/v0dro/daru/branches{/branch}","tags_url":"https://api.github.com/repos/v0dro/daru/tags","blobs_url":"https://api.github.com/repos/v0dro/daru/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/v0dro/daru/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/v0dro/daru/git/refs{/sha}","trees_url":"https://api.github.com/repos/v0dro/daru/git/trees{/sha}","statuses_url":"https://api.github.com/repos/v0dro/daru/statuses/{sha}","languages_url":"https://api.github.com/repos/v0dro/daru/languages","stargazers_url":"https://api.github.com/repos/v0dro/daru/stargazers","contributors_url":"https://api.github.com/repos/v0dro/daru/contributors","subscribers_url":"https://api.github.com/repos/v0dro/daru/subscribers","subscription_url":"https://api.github.com/repos/v0dro/daru/subscription","commits_url":"https://api.github.com/repos/v0dro/daru/commits{/sha}","git_commits_url":"https://api.github.com/repos/v0dro/daru/git/commits{/sha}","comments_url":"https://api.github.com/repos/v0dro/daru/comments{/number}","issue_comment_url":"https://api.github.com/repos/v0dro/daru/issues/comments{/number}","contents_url":"https://api.github.com/repos/v0dro/daru/contents/{+path}","compare_url":"https://api.github.com/repos/v0dro/daru/compare/{base}...{head}","merges_url":"https://api.github.com/repos/v0dro/daru/merges","archive_url":"https://api.github.com/repos/v0dro/daru/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/v0dro/daru/downloads","issues_url":"https://api.github.com/repos/v0dro/daru/issues{/number}","pulls_url":"https://api.github.com/repos/v0dro/daru/pulls{/number}","milestones_url":"https://api.github.com/repos/v0dro/daru/milestones{/number}","notifications_url":"https://api.github.com/repos/v0dro/daru/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/v0dro/daru/labels{/name}","releases_url":"https://api.github.com/repos/v0dro/daru/releases{/id}","deployments_url":"https://api.github.com/repos/v0dro/daru/deployments","created_at":"2014-10-04T08:23:21Z","updated_at":"2016-05-26T14:55:03Z","pushed_at":"2016-05-28T19:20:44Z","git_url":"git://github.com/v0dro/daru.git","ssh_url":"git@github.com:v0dro/daru.git","clone_url":"https://github.com/v0dro/daru.git","svn_url":"https://github.com/v0dro/daru","homepage":null,"size":3632,"stargazers_count":112,"watchers_count":112,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":32,"mirror_url":null,"open_issues_count":27,"forks":32,"open_issues":27,"watchers":112,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/v0dro/daru/pulls/123"},"html":{"href":"https://github.com/v0dro/daru/pull/123"},"issue":{"href":"https://api.github.com/repos/v0dro/daru/issues/123"},"comments":{"href":"https://api.github.com/repos/v0dro/daru/issues/123/comments"},"review_comments":{"href":"https://api.github.com/repos/v0dro/daru/pulls/123/comments"},"review_comment":{"href":"https://api.github.com/repos/v0dro/daru/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/v0dro/daru/pulls/123/commits"},"statuses":{"href":"https://api.github.com/repos/v0dro/daru/statuses/ba6611f9ec16a28569370ab159a702e768376a01"}}}}
{"actor":{"display_login":"v0dro"}}