{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/origin-aggregated-logging/pulls/comments/84294744","pull_request_review_id":5080763,"id":84294744,"diff_hunk":"@@ -0,0 +1,63 @@\n+# Modifications to Fluentd Metadata Retrieval Proposal\n+\n+##Motivation\n+In the current design (v3.4) of the EFK stack, there is a Fluentd pod deployed to each Openshift node. Fluentd is responsible for reading container logs, adding pod metadata (e.g. labels, namespace) to individual log entries, and sending the logs to the Elasticsearch cluster. The pod metadata is sourced by watching the Openshift API server for Pod information via the [Kubernetes Metadata Filter](https://github.com/fabric8io/fluent-plugin-kubernetes_metadata_filter)[2]. Testing at larger scales of Openshift clusters has shown issues where Fluentd is unable to connect to the API server because it is limited by the **maxRequestsInFlight** configuration setting [1].  This results in logs not being shipped to the aggregator and thus being unavailable.\n+\n+##Proposal - Short Term (3.4)\n+1. Leave the value as-is and note that it must be adjusted to account for # of nodes plus some headroom (swag @ 10%?).\n+1. Increase the default to our current maximum supported node count, plus some headroom.\n+1. Increasing maxRequestsInflight upstream","path":"docs/proposals/fluentd-limit-requests-to-apiserver.md","position":18,"original_position":9,"commit_id":"31338982427a99922beba8b97af422a737eaa4b8","original_commit_id":"4cbab7e0cd625098829f672989044b2938b5db3b","user":{"login":"jcantrill","id":4548408,"avatar_url":"https://avatars.githubusercontent.com/u/4548408?v=3","gravatar_id":"","url":"https://api.github.com/users/jcantrill","html_url":"https://github.com/jcantrill","followers_url":"https://api.github.com/users/jcantrill/followers","following_url":"https://api.github.com/users/jcantrill/following{/other_user}","gists_url":"https://api.github.com/users/jcantrill/gists{/gist_id}","starred_url":"https://api.github.com/users/jcantrill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcantrill/subscriptions","organizations_url":"https://api.github.com/users/jcantrill/orgs","repos_url":"https://api.github.com/users/jcantrill/repos","events_url":"https://api.github.com/users/jcantrill/events{/privacy}","received_events_url":"https://api.github.com/users/jcantrill/received_events","type":"User","site_admin":false},"body":"+1","created_at":"2016-10-20T14:28:43Z","updated_at":"2016-10-20T14:28:44Z","html_url":"https://github.com/openshift/origin-aggregated-logging/pull/254#discussion_r84294744","pull_request_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/pulls/254","_links":{"self":{"href":"https://api.github.com/repos/openshift/origin-aggregated-logging/pulls/comments/84294744"},"html":{"href":"https://github.com/openshift/origin-aggregated-logging/pull/254#discussion_r84294744"},"pull_request":{"href":"https://api.github.com/repos/openshift/origin-aggregated-logging/pulls/254"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/origin-aggregated-logging/pulls/254","id":89410426,"html_url":"https://github.com/openshift/origin-aggregated-logging/pull/254","diff_url":"https://github.com/openshift/origin-aggregated-logging/pull/254.diff","patch_url":"https://github.com/openshift/origin-aggregated-logging/pull/254.patch","issue_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/issues/254","number":254,"state":"open","locked":false,"title":"Fluend Deployment Modifications Proposal","user":{"login":"jcantrill","id":4548408,"avatar_url":"https://avatars.githubusercontent.com/u/4548408?v=3","gravatar_id":"","url":"https://api.github.com/users/jcantrill","html_url":"https://github.com/jcantrill","followers_url":"https://api.github.com/users/jcantrill/followers","following_url":"https://api.github.com/users/jcantrill/following{/other_user}","gists_url":"https://api.github.com/users/jcantrill/gists{/gist_id}","starred_url":"https://api.github.com/users/jcantrill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcantrill/subscriptions","organizations_url":"https://api.github.com/users/jcantrill/orgs","repos_url":"https://api.github.com/users/jcantrill/repos","events_url":"https://api.github.com/users/jcantrill/events{/privacy}","received_events_url":"https://api.github.com/users/jcantrill/received_events","type":"User","site_admin":false},"body":"Github issue as requested from https://bugzilla.redhat.com/show_bug.cgi?id=1384626#c4  This is a work in progress.  Please comment accordingly:\r\n\r\ncc: @ewolinetz @richm @sosiouxme @smarterclayton @lukas-vlcek @pweil- @timothysc @jeremyeder @rflorenc @portante","created_at":"2016-10-14T16:00:53Z","updated_at":"2016-10-20T14:28:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7a466a50089b1d308371b77cd9a90bd22e803431","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/pulls/254/commits","review_comments_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/pulls/254/comments","review_comment_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/issues/254/comments","statuses_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/statuses/31338982427a99922beba8b97af422a737eaa4b8","head":{"label":"jcantrill:fluentd_mod_proposal","ref":"fluentd_mod_proposal","sha":"31338982427a99922beba8b97af422a737eaa4b8","user":{"login":"jcantrill","id":4548408,"avatar_url":"https://avatars.githubusercontent.com/u/4548408?v=3","gravatar_id":"","url":"https://api.github.com/users/jcantrill","html_url":"https://github.com/jcantrill","followers_url":"https://api.github.com/users/jcantrill/followers","following_url":"https://api.github.com/users/jcantrill/following{/other_user}","gists_url":"https://api.github.com/users/jcantrill/gists{/gist_id}","starred_url":"https://api.github.com/users/jcantrill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcantrill/subscriptions","organizations_url":"https://api.github.com/users/jcantrill/orgs","repos_url":"https://api.github.com/users/jcantrill/repos","events_url":"https://api.github.com/users/jcantrill/events{/privacy}","received_events_url":"https://api.github.com/users/jcantrill/received_events","type":"User","site_admin":false},"repo":{"id":42534471,"name":"origin-aggregated-logging","full_name":"jcantrill/origin-aggregated-logging","owner":{"login":"jcantrill","id":4548408,"avatar_url":"https://avatars.githubusercontent.com/u/4548408?v=3","gravatar_id":"","url":"https://api.github.com/users/jcantrill","html_url":"https://github.com/jcantrill","followers_url":"https://api.github.com/users/jcantrill/followers","following_url":"https://api.github.com/users/jcantrill/following{/other_user}","gists_url":"https://api.github.com/users/jcantrill/gists{/gist_id}","starred_url":"https://api.github.com/users/jcantrill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcantrill/subscriptions","organizations_url":"https://api.github.com/users/jcantrill/orgs","repos_url":"https://api.github.com/users/jcantrill/repos","events_url":"https://api.github.com/users/jcantrill/events{/privacy}","received_events_url":"https://api.github.com/users/jcantrill/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jcantrill/origin-aggregated-logging","description":null,"fork":true,"url":"https://api.github.com/repos/jcantrill/origin-aggregated-logging","forks_url":"https://api.github.com/repos/jcantrill/origin-aggregated-logging/forks","keys_url":"https://api.github.com/repos/jcantrill/origin-aggregated-logging/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jcantrill/origin-aggregated-logging/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jcantrill/origin-aggregated-logging/teams","hooks_url":"https://api.github.com/repos/jcantrill/origin-aggregated-logging/hooks","issue_events_url":"https://api.github.com/repos/jcantrill/origin-aggregated-logging/issues/events{/number}","events_url":"https://api.github.com/repos/jcantrill/origin-aggregated-logging/events","assignees_url":"https://api.github.com/repos/jcantrill/origin-aggregated-logging/assignees{/user}","branches_url":"https://api.github.com/repos/jcantrill/origin-aggregated-logging/branches{/branch}","tags_url":"https://api.github.com/repos/jcantrill/origin-aggregated-logging/tags","blobs_url":"https://api.github.com/repos/jcantrill/origin-aggregated-logging/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jcantrill/origin-aggregated-logging/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jcantrill/origin-aggregated-logging/git/refs{/sha}","trees_url":"https://api.github.com/repos/jcantrill/origin-aggregated-logging/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jcantrill/origin-aggregated-logging/statuses/{sha}","languages_url":"https://api.github.com/repos/jcantrill/origin-aggregated-logging/languages","stargazers_url":"https://api.github.com/repos/jcantrill/origin-aggregated-logging/stargazers","contributors_url":"https://api.github.com/repos/jcantrill/origin-aggregated-logging/contributors","subscribers_url":"https://api.github.com/repos/jcantrill/origin-aggregated-logging/subscribers","subscription_url":"https://api.github.com/repos/jcantrill/origin-aggregated-logging/subscription","commits_url":"https://api.github.com/repos/jcantrill/origin-aggregated-logging/commits{/sha}","git_commits_url":"https://api.github.com/repos/jcantrill/origin-aggregated-logging/git/commits{/sha}","comments_url":"https://api.github.com/repos/jcantrill/origin-aggregated-logging/comments{/number}","issue_comment_url":"https://api.github.com/repos/jcantrill/origin-aggregated-logging/issues/comments{/number}","contents_url":"https://api.github.com/repos/jcantrill/origin-aggregated-logging/contents/{+path}","compare_url":"https://api.github.com/repos/jcantrill/origin-aggregated-logging/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jcantrill/origin-aggregated-logging/merges","archive_url":"https://api.github.com/repos/jcantrill/origin-aggregated-logging/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jcantrill/origin-aggregated-logging/downloads","issues_url":"https://api.github.com/repos/jcantrill/origin-aggregated-logging/issues{/number}","pulls_url":"https://api.github.com/repos/jcantrill/origin-aggregated-logging/pulls{/number}","milestones_url":"https://api.github.com/repos/jcantrill/origin-aggregated-logging/milestones{/number}","notifications_url":"https://api.github.com/repos/jcantrill/origin-aggregated-logging/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jcantrill/origin-aggregated-logging/labels{/name}","releases_url":"https://api.github.com/repos/jcantrill/origin-aggregated-logging/releases{/id}","deployments_url":"https://api.github.com/repos/jcantrill/origin-aggregated-logging/deployments","created_at":"2015-09-15T17:17:48Z","updated_at":"2016-04-05T19:26:33Z","pushed_at":"2016-10-17T18:48:23Z","git_url":"git://github.com/jcantrill/origin-aggregated-logging.git","ssh_url":"git@github.com:jcantrill/origin-aggregated-logging.git","clone_url":"https://github.com/jcantrill/origin-aggregated-logging.git","svn_url":"https://github.com/jcantrill/origin-aggregated-logging","homepage":null,"size":745,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"f4049fa3bdb505cd22d7d39bde7fcf8c4536621b","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":42467822,"name":"origin-aggregated-logging","full_name":"openshift/origin-aggregated-logging","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin-aggregated-logging","description":null,"fork":false,"url":"https://api.github.com/repos/openshift/origin-aggregated-logging","forks_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/forks","keys_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/teams","hooks_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/events","assignees_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/tags","blobs_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/languages","stargazers_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/subscription","commits_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/merges","archive_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/downloads","issues_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/deployments","created_at":"2015-09-14T18:14:19Z","updated_at":"2016-07-08T19:02:43Z","pushed_at":"2016-10-20T14:10:11Z","git_url":"git://github.com/openshift/origin-aggregated-logging.git","ssh_url":"git@github.com:openshift/origin-aggregated-logging.git","clone_url":"https://github.com/openshift/origin-aggregated-logging.git","svn_url":"https://github.com/openshift/origin-aggregated-logging","homepage":null,"size":8828,"stargazers_count":9,"watchers_count":9,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":37,"mirror_url":null,"open_issues_count":34,"forks":37,"open_issues":34,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin-aggregated-logging/pulls/254"},"html":{"href":"https://github.com/openshift/origin-aggregated-logging/pull/254"},"issue":{"href":"https://api.github.com/repos/openshift/origin-aggregated-logging/issues/254"},"comments":{"href":"https://api.github.com/repos/openshift/origin-aggregated-logging/issues/254/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin-aggregated-logging/pulls/254/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin-aggregated-logging/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin-aggregated-logging/pulls/254/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin-aggregated-logging/statuses/31338982427a99922beba8b97af422a737eaa4b8"}}}}
{"actor":{"display_login":"jcantrill"}}