{"action":"created","comment":{"url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments/51129905","id":51129905,"diff_hunk":"@@ -168,6 +168,8 @@\n     @Deprecated\n     public static final String PROP_ENABLE_JMX_DETAILED = GroupProperty.ENABLE_JMX_DETAILED.getName();\n     @Deprecated\n+    public static final String PROP_JMX_UPDATE_INTERVAL_SECONDS = GroupProperty.JMX_UPDATE_INTERVAL_SECONDS.getName();\n+    @Deprecated","path":"hazelcast/src/main/java/com/hazelcast/instance/GroupProperties.java","position":5,"original_position":5,"commit_id":"91bc29024272353db6755e4735d677916719989e","original_commit_id":"91bc29024272353db6755e4735d677916719989e","user":{"login":"emrahkocaman","id":2887123,"avatar_url":"https://avatars.githubusercontent.com/u/2887123?v=3","gravatar_id":"","url":"https://api.github.com/users/emrahkocaman","html_url":"https://github.com/emrahkocaman","followers_url":"https://api.github.com/users/emrahkocaman/followers","following_url":"https://api.github.com/users/emrahkocaman/following{/other_user}","gists_url":"https://api.github.com/users/emrahkocaman/gists{/gist_id}","starred_url":"https://api.github.com/users/emrahkocaman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emrahkocaman/subscriptions","organizations_url":"https://api.github.com/users/emrahkocaman/orgs","repos_url":"https://api.github.com/users/emrahkocaman/repos","events_url":"https://api.github.com/users/emrahkocaman/events{/privacy}","received_events_url":"https://api.github.com/users/emrahkocaman/received_events","type":"User","site_admin":false},"body":"Adding an already deprecated field seems odd to me. Isn't adding it to only `GroupProperty` enough?","created_at":"2016-01-28T14:41:13Z","updated_at":"2016-01-28T14:41:13Z","html_url":"https://github.com/hazelcast/hazelcast/pull/7420#discussion_r51129905","pull_request_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/7420","_links":{"self":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments/51129905"},"html":{"href":"https://github.com/hazelcast/hazelcast/pull/7420#discussion_r51129905"},"pull_request":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/7420"}}},"pull_request":{"url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/7420","id":57509827,"html_url":"https://github.com/hazelcast/hazelcast/pull/7420","diff_url":"https://github.com/hazelcast/hazelcast/pull/7420.diff","patch_url":"https://github.com/hazelcast/hazelcast/pull/7420.patch","issue_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/7420","number":7420,"state":"open","locked":false,"title":"JMX Enhencements","user":{"login":"muratayan","id":4989547,"avatar_url":"https://avatars.githubusercontent.com/u/4989547?v=3","gravatar_id":"","url":"https://api.github.com/users/muratayan","html_url":"https://github.com/muratayan","followers_url":"https://api.github.com/users/muratayan/followers","following_url":"https://api.github.com/users/muratayan/following{/other_user}","gists_url":"https://api.github.com/users/muratayan/gists{/gist_id}","starred_url":"https://api.github.com/users/muratayan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muratayan/subscriptions","organizations_url":"https://api.github.com/users/muratayan/orgs","repos_url":"https://api.github.com/users/muratayan/repos","events_url":"https://api.github.com/users/muratayan/events{/privacy}","received_events_url":"https://api.github.com/users/muratayan/received_events","type":"User","site_admin":false},"body":"Gets rid of the JMX stat collecting overhead. Stats are created for given distributed object type for once in given interval. Before it was every time there was a method call.\r\n\r\nLogic reviewed and approved here: https://github.com/hazelcast/hazelcast/pull/7327\r\n\r\nPlease comment on compatibility.","created_at":"2016-01-28T14:34:36Z","updated_at":"2016-01-28T14:41:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a98b1532547118f86bdf7063e73b8848fda64a6f","assignee":null,"milestone":{"url":"https://api.github.com/repos/hazelcast/hazelcast/milestones/72","html_url":"https://github.com/hazelcast/hazelcast/milestones/3.6.1","labels_url":"https://api.github.com/repos/hazelcast/hazelcast/milestones/72/labels","id":1453344,"number":72,"title":"3.6.1","description":null,"creator":{"login":"alparslanavci","id":7557235,"avatar_url":"https://avatars.githubusercontent.com/u/7557235?v=3","gravatar_id":"","url":"https://api.github.com/users/alparslanavci","html_url":"https://github.com/alparslanavci","followers_url":"https://api.github.com/users/alparslanavci/followers","following_url":"https://api.github.com/users/alparslanavci/following{/other_user}","gists_url":"https://api.github.com/users/alparslanavci/gists{/gist_id}","starred_url":"https://api.github.com/users/alparslanavci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alparslanavci/subscriptions","organizations_url":"https://api.github.com/users/alparslanavci/orgs","repos_url":"https://api.github.com/users/alparslanavci/repos","events_url":"https://api.github.com/users/alparslanavci/events{/privacy}","received_events_url":"https://api.github.com/users/alparslanavci/received_events","type":"User","site_admin":false},"open_issues":33,"closed_issues":24,"state":"open","created_at":"2015-12-10T08:08:10Z","updated_at":"2016-01-28T14:34:36Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/7420/commits","review_comments_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/7420/comments","review_comment_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/7420/comments","statuses_url":"https://api.github.com/repos/hazelcast/hazelcast/statuses/91bc29024272353db6755e4735d677916719989e","head":{"label":"muratayan:feature/3.x/JMXEnhencement","ref":"feature/3.x/JMXEnhencement","sha":"91bc29024272353db6755e4735d677916719989e","user":{"login":"muratayan","id":4989547,"avatar_url":"https://avatars.githubusercontent.com/u/4989547?v=3","gravatar_id":"","url":"https://api.github.com/users/muratayan","html_url":"https://github.com/muratayan","followers_url":"https://api.github.com/users/muratayan/followers","following_url":"https://api.github.com/users/muratayan/following{/other_user}","gists_url":"https://api.github.com/users/muratayan/gists{/gist_id}","starred_url":"https://api.github.com/users/muratayan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muratayan/subscriptions","organizations_url":"https://api.github.com/users/muratayan/orgs","repos_url":"https://api.github.com/users/muratayan/repos","events_url":"https://api.github.com/users/muratayan/events{/privacy}","received_events_url":"https://api.github.com/users/muratayan/received_events","type":"User","site_admin":false},"repo":{"id":30235927,"name":"hazelcast","full_name":"muratayan/hazelcast","owner":{"login":"muratayan","id":4989547,"avatar_url":"https://avatars.githubusercontent.com/u/4989547?v=3","gravatar_id":"","url":"https://api.github.com/users/muratayan","html_url":"https://github.com/muratayan","followers_url":"https://api.github.com/users/muratayan/followers","following_url":"https://api.github.com/users/muratayan/following{/other_user}","gists_url":"https://api.github.com/users/muratayan/gists{/gist_id}","starred_url":"https://api.github.com/users/muratayan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muratayan/subscriptions","organizations_url":"https://api.github.com/users/muratayan/orgs","repos_url":"https://api.github.com/users/muratayan/repos","events_url":"https://api.github.com/users/muratayan/events{/privacy}","received_events_url":"https://api.github.com/users/muratayan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/muratayan/hazelcast","description":"Open Source In-Memory Data Grid","fork":true,"url":"https://api.github.com/repos/muratayan/hazelcast","forks_url":"https://api.github.com/repos/muratayan/hazelcast/forks","keys_url":"https://api.github.com/repos/muratayan/hazelcast/keys{/key_id}","collaborators_url":"https://api.github.com/repos/muratayan/hazelcast/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/muratayan/hazelcast/teams","hooks_url":"https://api.github.com/repos/muratayan/hazelcast/hooks","issue_events_url":"https://api.github.com/repos/muratayan/hazelcast/issues/events{/number}","events_url":"https://api.github.com/repos/muratayan/hazelcast/events","assignees_url":"https://api.github.com/repos/muratayan/hazelcast/assignees{/user}","branches_url":"https://api.github.com/repos/muratayan/hazelcast/branches{/branch}","tags_url":"https://api.github.com/repos/muratayan/hazelcast/tags","blobs_url":"https://api.github.com/repos/muratayan/hazelcast/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/muratayan/hazelcast/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/muratayan/hazelcast/git/refs{/sha}","trees_url":"https://api.github.com/repos/muratayan/hazelcast/git/trees{/sha}","statuses_url":"https://api.github.com/repos/muratayan/hazelcast/statuses/{sha}","languages_url":"https://api.github.com/repos/muratayan/hazelcast/languages","stargazers_url":"https://api.github.com/repos/muratayan/hazelcast/stargazers","contributors_url":"https://api.github.com/repos/muratayan/hazelcast/contributors","subscribers_url":"https://api.github.com/repos/muratayan/hazelcast/subscribers","subscription_url":"https://api.github.com/repos/muratayan/hazelcast/subscription","commits_url":"https://api.github.com/repos/muratayan/hazelcast/commits{/sha}","git_commits_url":"https://api.github.com/repos/muratayan/hazelcast/git/commits{/sha}","comments_url":"https://api.github.com/repos/muratayan/hazelcast/comments{/number}","issue_comment_url":"https://api.github.com/repos/muratayan/hazelcast/issues/comments{/number}","contents_url":"https://api.github.com/repos/muratayan/hazelcast/contents/{+path}","compare_url":"https://api.github.com/repos/muratayan/hazelcast/compare/{base}...{head}","merges_url":"https://api.github.com/repos/muratayan/hazelcast/merges","archive_url":"https://api.github.com/repos/muratayan/hazelcast/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/muratayan/hazelcast/downloads","issues_url":"https://api.github.com/repos/muratayan/hazelcast/issues{/number}","pulls_url":"https://api.github.com/repos/muratayan/hazelcast/pulls{/number}","milestones_url":"https://api.github.com/repos/muratayan/hazelcast/milestones{/number}","notifications_url":"https://api.github.com/repos/muratayan/hazelcast/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/muratayan/hazelcast/labels{/name}","releases_url":"https://api.github.com/repos/muratayan/hazelcast/releases{/id}","deployments_url":"https://api.github.com/repos/muratayan/hazelcast/deployments","created_at":"2015-02-03T09:47:46Z","updated_at":"2015-04-28T09:32:31Z","pushed_at":"2016-01-28T14:36:34Z","git_url":"git://github.com/muratayan/hazelcast.git","ssh_url":"git@github.com:muratayan/hazelcast.git","clone_url":"https://github.com/muratayan/hazelcast.git","svn_url":"https://github.com/muratayan/hazelcast","homepage":"www.hazelcast.com","size":83894,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hazelcast:maintenance-3.x","ref":"maintenance-3.x","sha":"90a7fb07d808f943846505c27374aecac9089f6e","user":{"login":"hazelcast","id":1453152,"avatar_url":"https://avatars.githubusercontent.com/u/1453152?v=3","gravatar_id":"","url":"https://api.github.com/users/hazelcast","html_url":"https://github.com/hazelcast","followers_url":"https://api.github.com/users/hazelcast/followers","following_url":"https://api.github.com/users/hazelcast/following{/other_user}","gists_url":"https://api.github.com/users/hazelcast/gists{/gist_id}","starred_url":"https://api.github.com/users/hazelcast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hazelcast/subscriptions","organizations_url":"https://api.github.com/users/hazelcast/orgs","repos_url":"https://api.github.com/users/hazelcast/repos","events_url":"https://api.github.com/users/hazelcast/events{/privacy}","received_events_url":"https://api.github.com/users/hazelcast/received_events","type":"Organization","site_admin":false},"repo":{"id":3786237,"name":"hazelcast","full_name":"hazelcast/hazelcast","owner":{"login":"hazelcast","id":1453152,"avatar_url":"https://avatars.githubusercontent.com/u/1453152?v=3","gravatar_id":"","url":"https://api.github.com/users/hazelcast","html_url":"https://github.com/hazelcast","followers_url":"https://api.github.com/users/hazelcast/followers","following_url":"https://api.github.com/users/hazelcast/following{/other_user}","gists_url":"https://api.github.com/users/hazelcast/gists{/gist_id}","starred_url":"https://api.github.com/users/hazelcast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hazelcast/subscriptions","organizations_url":"https://api.github.com/users/hazelcast/orgs","repos_url":"https://api.github.com/users/hazelcast/repos","events_url":"https://api.github.com/users/hazelcast/events{/privacy}","received_events_url":"https://api.github.com/users/hazelcast/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hazelcast/hazelcast","description":"Open Source In-Memory Data Grid","fork":false,"url":"https://api.github.com/repos/hazelcast/hazelcast","forks_url":"https://api.github.com/repos/hazelcast/hazelcast/forks","keys_url":"https://api.github.com/repos/hazelcast/hazelcast/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hazelcast/hazelcast/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hazelcast/hazelcast/teams","hooks_url":"https://api.github.com/repos/hazelcast/hazelcast/hooks","issue_events_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/events{/number}","events_url":"https://api.github.com/repos/hazelcast/hazelcast/events","assignees_url":"https://api.github.com/repos/hazelcast/hazelcast/assignees{/user}","branches_url":"https://api.github.com/repos/hazelcast/hazelcast/branches{/branch}","tags_url":"https://api.github.com/repos/hazelcast/hazelcast/tags","blobs_url":"https://api.github.com/repos/hazelcast/hazelcast/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hazelcast/hazelcast/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hazelcast/hazelcast/git/refs{/sha}","trees_url":"https://api.github.com/repos/hazelcast/hazelcast/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hazelcast/hazelcast/statuses/{sha}","languages_url":"https://api.github.com/repos/hazelcast/hazelcast/languages","stargazers_url":"https://api.github.com/repos/hazelcast/hazelcast/stargazers","contributors_url":"https://api.github.com/repos/hazelcast/hazelcast/contributors","subscribers_url":"https://api.github.com/repos/hazelcast/hazelcast/subscribers","subscription_url":"https://api.github.com/repos/hazelcast/hazelcast/subscription","commits_url":"https://api.github.com/repos/hazelcast/hazelcast/commits{/sha}","git_commits_url":"https://api.github.com/repos/hazelcast/hazelcast/git/commits{/sha}","comments_url":"https://api.github.com/repos/hazelcast/hazelcast/comments{/number}","issue_comment_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/comments{/number}","contents_url":"https://api.github.com/repos/hazelcast/hazelcast/contents/{+path}","compare_url":"https://api.github.com/repos/hazelcast/hazelcast/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hazelcast/hazelcast/merges","archive_url":"https://api.github.com/repos/hazelcast/hazelcast/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hazelcast/hazelcast/downloads","issues_url":"https://api.github.com/repos/hazelcast/hazelcast/issues{/number}","pulls_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls{/number}","milestones_url":"https://api.github.com/repos/hazelcast/hazelcast/milestones{/number}","notifications_url":"https://api.github.com/repos/hazelcast/hazelcast/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hazelcast/hazelcast/labels{/name}","releases_url":"https://api.github.com/repos/hazelcast/hazelcast/releases{/id}","deployments_url":"https://api.github.com/repos/hazelcast/hazelcast/deployments","created_at":"2012-03-21T12:25:18Z","updated_at":"2016-01-28T10:10:28Z","pushed_at":"2016-01-28T14:36:34Z","git_url":"git://github.com/hazelcast/hazelcast.git","ssh_url":"git@github.com:hazelcast/hazelcast.git","clone_url":"https://github.com/hazelcast/hazelcast.git","svn_url":"https://github.com/hazelcast/hazelcast","homepage":"www.hazelcast.com","size":96697,"stargazers_count":1401,"watchers_count":1401,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":682,"mirror_url":null,"open_issues_count":532,"forks":682,"open_issues":532,"watchers":1401,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/7420"},"html":{"href":"https://github.com/hazelcast/hazelcast/pull/7420"},"issue":{"href":"https://api.github.com/repos/hazelcast/hazelcast/issues/7420"},"comments":{"href":"https://api.github.com/repos/hazelcast/hazelcast/issues/7420/comments"},"review_comments":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/7420/comments"},"review_comment":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/7420/commits"},"statuses":{"href":"https://api.github.com/repos/hazelcast/hazelcast/statuses/91bc29024272353db6755e4735d677916719989e"}}}}