{"action":"created","issue":{"url":"https://api.github.com/repos/velikanov/SwiftPasscodeLock/issues/22","repository_url":"https://api.github.com/repos/velikanov/SwiftPasscodeLock","labels_url":"https://api.github.com/repos/velikanov/SwiftPasscodeLock/issues/22/labels{/name}","comments_url":"https://api.github.com/repos/velikanov/SwiftPasscodeLock/issues/22/comments","events_url":"https://api.github.com/repos/velikanov/SwiftPasscodeLock/issues/22/events","html_url":"https://github.com/velikanov/SwiftPasscodeLock/pull/22","id":154952591,"number":22,"title":"Fixed a security issue","user":{"login":"happylance","id":4953175,"avatar_url":"https://avatars.githubusercontent.com/u/4953175?v=3","gravatar_id":"","url":"https://api.github.com/users/happylance","html_url":"https://github.com/happylance","followers_url":"https://api.github.com/users/happylance/followers","following_url":"https://api.github.com/users/happylance/following{/other_user}","gists_url":"https://api.github.com/users/happylance/gists{/gist_id}","starred_url":"https://api.github.com/users/happylance/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/happylance/subscriptions","organizations_url":"https://api.github.com/users/happylance/orgs","repos_url":"https://api.github.com/users/happylance/repos","events_url":"https://api.github.com/users/happylance/events{/privacy}","received_events_url":"https://api.github.com/users/happylance/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":10,"created_at":"2016-05-16T03:07:50Z","updated_at":"2016-06-12T14:51:05Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/velikanov/SwiftPasscodeLock/pulls/22","html_url":"https://github.com/velikanov/SwiftPasscodeLock/pull/22","diff_url":"https://github.com/velikanov/SwiftPasscodeLock/pull/22.diff","patch_url":"https://github.com/velikanov/SwiftPasscodeLock/pull/22.patch"},"body":"Previously, `inccorectPasscodeAttempts` was reset to 0 after kill and restart. So an attacker can bypass the `maximumInccorectPasscodeAttempts` setting by killing and restarting the app after trying a different password again and again."},"comment":{"url":"https://api.github.com/repos/velikanov/SwiftPasscodeLock/issues/comments/225439091","html_url":"https://github.com/velikanov/SwiftPasscodeLock/pull/22#issuecomment-225439091","issue_url":"https://api.github.com/repos/velikanov/SwiftPasscodeLock/issues/22","id":225439091,"user":{"login":"happylance","id":4953175,"avatar_url":"https://avatars.githubusercontent.com/u/4953175?v=3","gravatar_id":"","url":"https://api.github.com/users/happylance","html_url":"https://github.com/happylance","followers_url":"https://api.github.com/users/happylance/followers","following_url":"https://api.github.com/users/happylance/following{/other_user}","gists_url":"https://api.github.com/users/happylance/gists{/gist_id}","starred_url":"https://api.github.com/users/happylance/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/happylance/subscriptions","organizations_url":"https://api.github.com/users/happylance/orgs","repos_url":"https://api.github.com/users/happylance/repos","events_url":"https://api.github.com/users/happylance/events{/privacy}","received_events_url":"https://api.github.com/users/happylance/received_events","type":"User","site_admin":false},"created_at":"2016-06-12T14:51:05Z","updated_at":"2016-06-12T14:51:05Z","body":"I think it is better to handle `incorrectPasscodeAttempts` correctly within this library so that it will be easier to use. You can add it in PR #27."}}
{"actor":{"display_login":"happylance"}}