{"action":"created","comment":{"url":"https://api.github.com/repos/angular/angular/pulls/comments/64678193","id":64678193,"diff_hunk":"@@ -486,7 +486,7 @@ export class CompileTemplateMetadata {\n     styleUrls?: string[],\n     ngContentSelectors?: string[]\n   } = {}) {\n-    this.encapsulation = isPresent(encapsulation) ? encapsulation : ViewEncapsulation.Emulated;\n+    this.encapsulation = isPresent(encapsulation) ? encapsulation : ViewEncapsulation.UseDefault;","path":"modules/@angular/compiler/src/compile_metadata.ts","position":5,"original_position":5,"commit_id":"d60344f990b56e3aaf9660b42b0b150a788098af","original_commit_id":"d60344f990b56e3aaf9660b42b0b150a788098af","user":{"login":"tbosch","id":690815,"avatar_url":"https://avatars.githubusercontent.com/u/690815?v=3","gravatar_id":"","url":"https://api.github.com/users/tbosch","html_url":"https://github.com/tbosch","followers_url":"https://api.github.com/users/tbosch/followers","following_url":"https://api.github.com/users/tbosch/following{/other_user}","gists_url":"https://api.github.com/users/tbosch/gists{/gist_id}","starred_url":"https://api.github.com/users/tbosch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbosch/subscriptions","organizations_url":"https://api.github.com/users/tbosch/orgs","repos_url":"https://api.github.com/users/tbosch/repos","events_url":"https://api.github.com/users/tbosch/events{/privacy}","received_events_url":"https://api.github.com/users/tbosch/received_events","type":"User","site_admin":false},"body":"There is no need to introduce a new `ViewEncapsulation` enum value. We should add a new field to `CompilerConfig` with the default ViewEncapsulation, read it and set it when calling `new CompileTemplateMetadata` in `directive_normalizer.ts`.","created_at":"2016-05-26T01:05:04Z","updated_at":"2016-05-26T01:05:04Z","html_url":"https://github.com/angular/angular/pull/7883#discussion_r64678193","pull_request_url":"https://api.github.com/repos/angular/angular/pulls/7883","_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/comments/64678193"},"html":{"href":"https://github.com/angular/angular/pull/7883#discussion_r64678193"},"pull_request":{"href":"https://api.github.com/repos/angular/angular/pulls/7883"}}},"pull_request":{"url":"https://api.github.com/repos/angular/angular/pulls/7883","id":65036083,"html_url":"https://github.com/angular/angular/pull/7883","diff_url":"https://github.com/angular/angular/pull/7883.diff","patch_url":"https://github.com/angular/angular/pull/7883.patch","issue_url":"https://api.github.com/repos/angular/angular/issues/7883","number":7883,"state":"open","locked":false,"title":"feat(ViewEncapsulation): default ViewEncapsulation to configurable","user":{"login":"laco0416","id":1529180,"avatar_url":"https://avatars.githubusercontent.com/u/1529180?v=3","gravatar_id":"","url":"https://api.github.com/users/laco0416","html_url":"https://github.com/laco0416","followers_url":"https://api.github.com/users/laco0416/followers","following_url":"https://api.github.com/users/laco0416/following{/other_user}","gists_url":"https://api.github.com/users/laco0416/gists{/gist_id}","starred_url":"https://api.github.com/users/laco0416/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laco0416/subscriptions","organizations_url":"https://api.github.com/users/laco0416/orgs","repos_url":"https://api.github.com/users/laco0416/repos","events_url":"https://api.github.com/users/laco0416/events{/privacy}","received_events_url":"https://api.github.com/users/laco0416/received_events","type":"User","site_admin":false},"body":"* **Please check if the PR fulfills these requirements**\r\n- [x] The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit-message-format\r\n- [x] Tests for the changes have been added (for bug fixes / features)\r\n- [x] Docs have been added / updated (for bug fixes / features)\r\n\r\n\r\n* **What kind of change does this PR introduce?** (Bug fix, feature, docs update, ...)\r\n\r\nNew feature\r\n\r\n* **What is the current behavior?** (You can also link to an open issue here)\r\n\r\nDefault encapsulation is ViewEncapsulation.Emulated. this is not configurable.\r\n\r\n* **What is the new behavior (if this is a feature change)?**\r\n\r\nAdd a DI token; `DEFAULT_VIEW_ENCAPSULATION` to overwrite default encapsulation.\r\n\r\n```\r\nprovide(DEFAULT_VIEW_ENCAPSULATION, {useValue: ViewEncapsulation.None})\r\n```\r\n\r\n* **Does this PR introduce a breaking change?** (What changes might users need to make in their application due to this PR?)\r\n\r\nNo\r\n\r\n* **Other information**:\r\n\r\n","created_at":"2016-04-02T11:56:07Z","updated_at":"2016-05-26T01:05:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ceaa116fee23a27e0c3de8a84c902ad8da583749","assignee":{"login":"tbosch","id":690815,"avatar_url":"https://avatars.githubusercontent.com/u/690815?v=3","gravatar_id":"","url":"https://api.github.com/users/tbosch","html_url":"https://github.com/tbosch","followers_url":"https://api.github.com/users/tbosch/followers","following_url":"https://api.github.com/users/tbosch/following{/other_user}","gists_url":"https://api.github.com/users/tbosch/gists{/gist_id}","starred_url":"https://api.github.com/users/tbosch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbosch/subscriptions","organizations_url":"https://api.github.com/users/tbosch/orgs","repos_url":"https://api.github.com/users/tbosch/repos","events_url":"https://api.github.com/users/tbosch/events{/privacy}","received_events_url":"https://api.github.com/users/tbosch/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/angular/angular/pulls/7883/commits","review_comments_url":"https://api.github.com/repos/angular/angular/pulls/7883/comments","review_comment_url":"https://api.github.com/repos/angular/angular/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/angular/issues/7883/comments","statuses_url":"https://api.github.com/repos/angular/angular/statuses/d60344f990b56e3aaf9660b42b0b150a788098af","head":{"label":"laco0416:laco-default-view-encapsulation","ref":"laco-default-view-encapsulation","sha":"d60344f990b56e3aaf9660b42b0b150a788098af","user":{"login":"laco0416","id":1529180,"avatar_url":"https://avatars.githubusercontent.com/u/1529180?v=3","gravatar_id":"","url":"https://api.github.com/users/laco0416","html_url":"https://github.com/laco0416","followers_url":"https://api.github.com/users/laco0416/followers","following_url":"https://api.github.com/users/laco0416/following{/other_user}","gists_url":"https://api.github.com/users/laco0416/gists{/gist_id}","starred_url":"https://api.github.com/users/laco0416/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laco0416/subscriptions","organizations_url":"https://api.github.com/users/laco0416/orgs","repos_url":"https://api.github.com/users/laco0416/repos","events_url":"https://api.github.com/users/laco0416/events{/privacy}","received_events_url":"https://api.github.com/users/laco0416/received_events","type":"User","site_admin":false},"repo":{"id":49241823,"name":"angular","full_name":"laco0416/angular","owner":{"login":"laco0416","id":1529180,"avatar_url":"https://avatars.githubusercontent.com/u/1529180?v=3","gravatar_id":"","url":"https://api.github.com/users/laco0416","html_url":"https://github.com/laco0416","followers_url":"https://api.github.com/users/laco0416/followers","following_url":"https://api.github.com/users/laco0416/following{/other_user}","gists_url":"https://api.github.com/users/laco0416/gists{/gist_id}","starred_url":"https://api.github.com/users/laco0416/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laco0416/subscriptions","organizations_url":"https://api.github.com/users/laco0416/orgs","repos_url":"https://api.github.com/users/laco0416/repos","events_url":"https://api.github.com/users/laco0416/events{/privacy}","received_events_url":"https://api.github.com/users/laco0416/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/laco0416/angular","description":"A fork to contribute","fork":true,"url":"https://api.github.com/repos/laco0416/angular","forks_url":"https://api.github.com/repos/laco0416/angular/forks","keys_url":"https://api.github.com/repos/laco0416/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/laco0416/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/laco0416/angular/teams","hooks_url":"https://api.github.com/repos/laco0416/angular/hooks","issue_events_url":"https://api.github.com/repos/laco0416/angular/issues/events{/number}","events_url":"https://api.github.com/repos/laco0416/angular/events","assignees_url":"https://api.github.com/repos/laco0416/angular/assignees{/user}","branches_url":"https://api.github.com/repos/laco0416/angular/branches{/branch}","tags_url":"https://api.github.com/repos/laco0416/angular/tags","blobs_url":"https://api.github.com/repos/laco0416/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/laco0416/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/laco0416/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/laco0416/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/laco0416/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/laco0416/angular/languages","stargazers_url":"https://api.github.com/repos/laco0416/angular/stargazers","contributors_url":"https://api.github.com/repos/laco0416/angular/contributors","subscribers_url":"https://api.github.com/repos/laco0416/angular/subscribers","subscription_url":"https://api.github.com/repos/laco0416/angular/subscription","commits_url":"https://api.github.com/repos/laco0416/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/laco0416/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/laco0416/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/laco0416/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/laco0416/angular/contents/{+path}","compare_url":"https://api.github.com/repos/laco0416/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/laco0416/angular/merges","archive_url":"https://api.github.com/repos/laco0416/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/laco0416/angular/downloads","issues_url":"https://api.github.com/repos/laco0416/angular/issues{/number}","pulls_url":"https://api.github.com/repos/laco0416/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/laco0416/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/laco0416/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/laco0416/angular/labels{/name}","releases_url":"https://api.github.com/repos/laco0416/angular/releases{/id}","deployments_url":"https://api.github.com/repos/laco0416/angular/deployments","created_at":"2016-01-08T01:38:43Z","updated_at":"2016-04-15T15:44:30Z","pushed_at":"2016-05-20T06:53:30Z","git_url":"git://github.com/laco0416/angular.git","ssh_url":"git@github.com:laco0416/angular.git","clone_url":"https://github.com/laco0416/angular.git","svn_url":"https://github.com/laco0416/angular","homepage":"https://angular.io","size":249336,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"595bcdd1ac922fcdc52e50e057d8d85fc0a704d3","user":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":24195339,"name":"angular","full_name":"angular/angular","owner":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/angular","description":"","fork":false,"url":"https://api.github.com/repos/angular/angular","forks_url":"https://api.github.com/repos/angular/angular/forks","keys_url":"https://api.github.com/repos/angular/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/angular/teams","hooks_url":"https://api.github.com/repos/angular/angular/hooks","issue_events_url":"https://api.github.com/repos/angular/angular/issues/events{/number}","events_url":"https://api.github.com/repos/angular/angular/events","assignees_url":"https://api.github.com/repos/angular/angular/assignees{/user}","branches_url":"https://api.github.com/repos/angular/angular/branches{/branch}","tags_url":"https://api.github.com/repos/angular/angular/tags","blobs_url":"https://api.github.com/repos/angular/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/angular/languages","stargazers_url":"https://api.github.com/repos/angular/angular/stargazers","contributors_url":"https://api.github.com/repos/angular/angular/contributors","subscribers_url":"https://api.github.com/repos/angular/angular/subscribers","subscription_url":"https://api.github.com/repos/angular/angular/subscription","commits_url":"https://api.github.com/repos/angular/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/angular/contents/{+path}","compare_url":"https://api.github.com/repos/angular/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/angular/merges","archive_url":"https://api.github.com/repos/angular/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/angular/downloads","issues_url":"https://api.github.com/repos/angular/angular/issues{/number}","pulls_url":"https://api.github.com/repos/angular/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/angular/labels{/name}","releases_url":"https://api.github.com/repos/angular/angular/releases{/id}","deployments_url":"https://api.github.com/repos/angular/angular/deployments","created_at":"2014-09-18T16:12:01Z","updated_at":"2016-05-25T21:50:17Z","pushed_at":"2016-05-26T00:53:22Z","git_url":"git://github.com/angular/angular.git","ssh_url":"git@github.com:angular/angular.git","clone_url":"https://github.com/angular/angular.git","svn_url":"https://github.com/angular/angular","homepage":"https://angular.io","size":597928,"stargazers_count":12213,"watchers_count":12213,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3188,"mirror_url":null,"open_issues_count":1540,"forks":3188,"open_issues":1540,"watchers":12213,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/7883"},"html":{"href":"https://github.com/angular/angular/pull/7883"},"issue":{"href":"https://api.github.com/repos/angular/angular/issues/7883"},"comments":{"href":"https://api.github.com/repos/angular/angular/issues/7883/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/angular/pulls/7883/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/angular/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/angular/pulls/7883/commits"},"statuses":{"href":"https://api.github.com/repos/angular/angular/statuses/d60344f990b56e3aaf9660b42b0b150a788098af"}}}}
{"actor":{"display_login":"tbosch"}}