{"action":"created","issue":{"url":"https://api.github.com/repos/zurb/inky-rb/issues/19","repository_url":"https://api.github.com/repos/zurb/inky-rb","labels_url":"https://api.github.com/repos/zurb/inky-rb/issues/19/labels{/name}","comments_url":"https://api.github.com/repos/zurb/inky-rb/issues/19/comments","events_url":"https://api.github.com/repos/zurb/inky-rb/issues/19/events","html_url":"https://github.com/zurb/inky-rb/pull/19","id":167499831,"number":19,"title":"Nokogiri","user":{"login":"francirp","id":2815976,"avatar_url":"https://avatars.githubusercontent.com/u/2815976?v=3","gravatar_id":"","url":"https://api.github.com/users/francirp","html_url":"https://github.com/francirp","followers_url":"https://api.github.com/users/francirp/followers","following_url":"https://api.github.com/users/francirp/following{/other_user}","gists_url":"https://api.github.com/users/francirp/gists{/gist_id}","starred_url":"https://api.github.com/users/francirp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/francirp/subscriptions","organizations_url":"https://api.github.com/users/francirp/orgs","repos_url":"https://api.github.com/users/francirp/repos","events_url":"https://api.github.com/users/francirp/events{/privacy}","received_events_url":"https://api.github.com/users/francirp/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2016-07-26T01:08:03Z","updated_at":"2016-10-08T03:01:31Z","closed_at":"2016-07-28T04:12:43Z","pull_request":{"url":"https://api.github.com/repos/zurb/inky-rb/pulls/19","html_url":"https://github.com/zurb/inky-rb/pull/19","diff_url":"https://github.com/zurb/inky-rb/pull/19.diff","patch_url":"https://github.com/zurb/inky-rb/pull/19.patch"},"body":"@kball throwing this back over the fence to you for your review. The tests are passing with Nokogiri installed and things seem to be running at a much faster clip. I think we're getting a 10x speed bump or possibly more.\r\n\r\nI'm concerned that I may have missed something here that doesn't have a test. I wasn't able to really verify that all situations are tested, so if you could please review all the code in the gem I would appreciate that."},"comment":{"url":"https://api.github.com/repos/zurb/inky-rb/issues/comments/252398627","html_url":"https://github.com/zurb/inky-rb/pull/19#issuecomment-252398627","issue_url":"https://api.github.com/repos/zurb/inky-rb/issues/19","id":252398627,"user":{"login":"marcandre","id":33770,"avatar_url":"https://avatars.githubusercontent.com/u/33770?v=3","gravatar_id":"","url":"https://api.github.com/users/marcandre","html_url":"https://github.com/marcandre","followers_url":"https://api.github.com/users/marcandre/followers","following_url":"https://api.github.com/users/marcandre/following{/other_user}","gists_url":"https://api.github.com/users/marcandre/gists{/gist_id}","starred_url":"https://api.github.com/users/marcandre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcandre/subscriptions","organizations_url":"https://api.github.com/users/marcandre/orgs","repos_url":"https://api.github.com/users/marcandre/repos","events_url":"https://api.github.com/users/marcandre/events{/privacy}","received_events_url":"https://api.github.com/users/marcandre/received_events","type":"User","site_admin":false},"created_at":"2016-10-08T03:01:31Z","updated_at":"2016-10-08T03:01:31Z","body":"@brncal Unless I'm missing something, we need to switch the whole thing to parsing HTML instead of XML.\r\n\r\nThis PR introduced a bug whereby it outputs a `<?xml version=\"1.0\"?>` tag at the beginning of the output (and the modified test shows this clearly...). That tag should not be there!\r\n\r\nFixes in PR #34"}}
{"actor":{"display_login":"marcandre"}}