{"action":"created","issue":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/10241","repository_url":"https://api.github.com/repos/ManageIQ/manageiq","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/10241/labels{/name}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/10241/comments","events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/10241/events","html_url":"https://github.com/ManageIQ/manageiq/pull/10241","id":169220155,"number":10241,"title":"Remove appliance console service group","user":{"login":"carbonin","id":12697904,"avatar_url":"https://avatars.githubusercontent.com/u/12697904?v=3","gravatar_id":"","url":"https://api.github.com/users/carbonin","html_url":"https://github.com/carbonin","followers_url":"https://api.github.com/users/carbonin/followers","following_url":"https://api.github.com/users/carbonin/following{/other_user}","gists_url":"https://api.github.com/users/carbonin/gists{/gist_id}","starred_url":"https://api.github.com/users/carbonin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carbonin/subscriptions","organizations_url":"https://api.github.com/users/carbonin/orgs","repos_url":"https://api.github.com/users/carbonin/repos","events_url":"https://api.github.com/users/carbonin/events{/privacy}","received_events_url":"https://api.github.com/users/carbonin/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/core","name":"core","color":"5319e7"},{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/technical%20debt","name":"technical debt","color":"eb6420"}],"state":"open","locked":false,"assignee":{"login":"gtanzillo","id":76593,"avatar_url":"https://avatars.githubusercontent.com/u/76593?v=3","gravatar_id":"","url":"https://api.github.com/users/gtanzillo","html_url":"https://github.com/gtanzillo","followers_url":"https://api.github.com/users/gtanzillo/followers","following_url":"https://api.github.com/users/gtanzillo/following{/other_user}","gists_url":"https://api.github.com/users/gtanzillo/gists{/gist_id}","starred_url":"https://api.github.com/users/gtanzillo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gtanzillo/subscriptions","organizations_url":"https://api.github.com/users/gtanzillo/orgs","repos_url":"https://api.github.com/users/gtanzillo/repos","events_url":"https://api.github.com/users/gtanzillo/events{/privacy}","received_events_url":"https://api.github.com/users/gtanzillo/received_events","type":"User","site_admin":false},"assignees":[{"login":"gtanzillo","id":76593,"avatar_url":"https://avatars.githubusercontent.com/u/76593?v=3","gravatar_id":"","url":"https://api.github.com/users/gtanzillo","html_url":"https://github.com/gtanzillo","followers_url":"https://api.github.com/users/gtanzillo/followers","following_url":"https://api.github.com/users/gtanzillo/following{/other_user}","gists_url":"https://api.github.com/users/gtanzillo/gists{/gist_id}","starred_url":"https://api.github.com/users/gtanzillo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gtanzillo/subscriptions","organizations_url":"https://api.github.com/users/gtanzillo/orgs","repos_url":"https://api.github.com/users/gtanzillo/repos","events_url":"https://api.github.com/users/gtanzillo/events{/privacy}","received_events_url":"https://api.github.com/users/gtanzillo/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2016-08-03T19:59:44Z","updated_at":"2016-08-03T21:26:32Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/10241","html_url":"https://github.com/ManageIQ/manageiq/pull/10241","diff_url":"https://github.com/ManageIQ/manageiq/pull/10241.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/10241.patch"},"body":"This class is no longer needed.\r\n\r\nMany of the services it was enabling/starting are already enabled in the kickstart and will be started when the appliance boots.\r\n\r\nWe no longer need to worry about detaching the services we start because systemd tracks forked processes correctly.\r\n\r\nAfter removing the services that were enabled in the kickstart, the only thing left in `ServiceGroup` was postgres which we were already starting when it was necessary (in `InternalDatabaseConfiguration`) and `evmserverd` which (for some reason) we were also already starting in `DatabaseConfiguration#post_activation`.\r\n\r\nThis allowed me to just enable postgres when `InternalDatabaseConfiguration#start_postgres` starts it and then allow `InternalDatabaseConfiguration` to inherit `#post_activation` from `DatabaseConfiguration` which will start `evmserverd` after everything is finished.\r\n\r\n@jrafanie please review\r\n"},"comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments/237379480","html_url":"https://github.com/ManageIQ/manageiq/pull/10241#issuecomment-237379480","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/10241","id":237379480,"user":{"login":"miq-bot","id":7806257,"avatar_url":"https://avatars.githubusercontent.com/u/7806257?v=3","gravatar_id":"","url":"https://api.github.com/users/miq-bot","html_url":"https://github.com/miq-bot","followers_url":"https://api.github.com/users/miq-bot/followers","following_url":"https://api.github.com/users/miq-bot/following{/other_user}","gists_url":"https://api.github.com/users/miq-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/miq-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miq-bot/subscriptions","organizations_url":"https://api.github.com/users/miq-bot/orgs","repos_url":"https://api.github.com/users/miq-bot/repos","events_url":"https://api.github.com/users/miq-bot/events{/privacy}","received_events_url":"https://api.github.com/users/miq-bot/received_events","type":"User","site_admin":false},"created_at":"2016-08-03T21:26:32Z","updated_at":"2016-08-03T21:26:32Z","body":"<rubocop />Checked commits https://github.com/carbonin/manageiq/compare/fe4aaf00769c5d7eccb959250b827c9cf3dd1402~...e61a0b6183e98c53a260e19266086bbcde9c74f2 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1\n5 files checked, 0 offenses detected\nEverything looks good. :cake:\n"}}
{"actor":{"display_login":"miq-bot"}}