{"action":"created","comment":{"url":"https://api.github.com/repos/minio/minio/pulls/comments/69862813","id":69862813,"diff_hunk":"@@ -52,16 +55,36 @@ func TestParseRequestRange(t *testing.T) {\n \t}\n \n \t// Test invalid range strings.\n-\tinvalidRangeStrings := []string{\"\", \"2-5\", \"bytes= 2-5\", \"bytes=2 - 5\", \"bytes=0-0,-1\", \"bytes=5-2\", \"bytes=2-5 \", \"bytes=2--5\"}\n+\tinvalidRangeStrings := []string{\n+\t\t\"bytes=8\",\n+\t\t\"bytes=5-2\",\n+\t\t\"bytes=+2-5\",\n+\t\t\"bytes=2-+5\",\n+\t\t\"bytes=2--5\",\n+\t\t\"bytes=-\",\n+\t\t\"\",\n+\t\t\"2-5\",\n+\t\t\"bytes = 2-5\",\n+\t\t\"bytes=2 - 5\",\n+\t\t\"bytes=0-0,-1\",\n+\t\t\"bytes=2-5 \",\n+\t}\n \tfor _, rangeString := range invalidRangeStrings {\n \t\tif _, err := parseRequestRange(rangeString, 10); err == nil {\n \t\t\tt.Fatalf(\"expected: an error, got: <nil>\")\n \t\t}","path":"httprange_test.go","position":34,"original_position":34,"commit_id":"22fe3f0f1023a33f069ed402d7f4da73aad209ba","original_commit_id":"22fe3f0f1023a33f069ed402d7f4da73aad209ba","user":{"login":"hackintoshrao","id":2609511,"avatar_url":"https://avatars.githubusercontent.com/u/2609511?v=3","gravatar_id":"","url":"https://api.github.com/users/hackintoshrao","html_url":"https://github.com/hackintoshrao","followers_url":"https://api.github.com/users/hackintoshrao/followers","following_url":"https://api.github.com/users/hackintoshrao/following{/other_user}","gists_url":"https://api.github.com/users/hackintoshrao/gists{/gist_id}","starred_url":"https://api.github.com/users/hackintoshrao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hackintoshrao/subscriptions","organizations_url":"https://api.github.com/users/hackintoshrao/orgs","repos_url":"https://api.github.com/users/hackintoshrao/repos","events_url":"https://api.github.com/users/hackintoshrao/events{/privacy}","received_events_url":"https://api.github.com/users/hackintoshrao/received_events","type":"User","site_admin":false},"body":"Can the error message also be asserted. ","created_at":"2016-07-07T07:36:44Z","updated_at":"2016-07-07T07:36:44Z","html_url":"https://github.com/minio/minio/pull/2122#discussion_r69862813","pull_request_url":"https://api.github.com/repos/minio/minio/pulls/2122","_links":{"self":{"href":"https://api.github.com/repos/minio/minio/pulls/comments/69862813"},"html":{"href":"https://github.com/minio/minio/pull/2122#discussion_r69862813"},"pull_request":{"href":"https://api.github.com/repos/minio/minio/pulls/2122"}}},"pull_request":{"url":"https://api.github.com/repos/minio/minio/pulls/2122","id":76550058,"html_url":"https://github.com/minio/minio/pull/2122","diff_url":"https://github.com/minio/minio/pull/2122.diff","patch_url":"https://github.com/minio/minio/pull/2122.patch","issue_url":"https://api.github.com/repos/minio/minio/issues/2122","number":2122,"state":"open","locked":false,"title":"http: handle possible range requests properly.","user":{"login":"balamurugana","id":629407,"avatar_url":"https://avatars.githubusercontent.com/u/629407?v=3","gravatar_id":"","url":"https://api.github.com/users/balamurugana","html_url":"https://github.com/balamurugana","followers_url":"https://api.github.com/users/balamurugana/followers","following_url":"https://api.github.com/users/balamurugana/following{/other_user}","gists_url":"https://api.github.com/users/balamurugana/gists{/gist_id}","starred_url":"https://api.github.com/users/balamurugana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balamurugana/subscriptions","organizations_url":"https://api.github.com/users/balamurugana/orgs","repos_url":"https://api.github.com/users/balamurugana/repos","events_url":"https://api.github.com/users/balamurugana/events{/privacy}","received_events_url":"https://api.github.com/users/balamurugana/received_events","type":"User","site_admin":false},"body":"Previously range string is not validated against various combination\r\nof values.  This patch fixes the issue.\r\n\r\nFixes #2118","created_at":"2016-07-07T07:26:59Z","updated_at":"2016-07-07T07:36:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4bf6703a0b7b1f1b9bc018e43acadec5fb6511ac","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/minio/minio/pulls/2122/commits","review_comments_url":"https://api.github.com/repos/minio/minio/pulls/2122/comments","review_comment_url":"https://api.github.com/repos/minio/minio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/minio/minio/issues/2122/comments","statuses_url":"https://api.github.com/repos/minio/minio/statuses/22fe3f0f1023a33f069ed402d7f4da73aad209ba","head":{"label":"balamurugana:devel","ref":"devel","sha":"22fe3f0f1023a33f069ed402d7f4da73aad209ba","user":{"login":"balamurugana","id":629407,"avatar_url":"https://avatars.githubusercontent.com/u/629407?v=3","gravatar_id":"","url":"https://api.github.com/users/balamurugana","html_url":"https://github.com/balamurugana","followers_url":"https://api.github.com/users/balamurugana/followers","following_url":"https://api.github.com/users/balamurugana/following{/other_user}","gists_url":"https://api.github.com/users/balamurugana/gists{/gist_id}","starred_url":"https://api.github.com/users/balamurugana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balamurugana/subscriptions","organizations_url":"https://api.github.com/users/balamurugana/orgs","repos_url":"https://api.github.com/users/balamurugana/repos","events_url":"https://api.github.com/users/balamurugana/events{/privacy}","received_events_url":"https://api.github.com/users/balamurugana/received_events","type":"User","site_admin":false},"repo":{"id":47154966,"name":"minio","full_name":"balamurugana/minio","owner":{"login":"balamurugana","id":629407,"avatar_url":"https://avatars.githubusercontent.com/u/629407?v=3","gravatar_id":"","url":"https://api.github.com/users/balamurugana","html_url":"https://github.com/balamurugana","followers_url":"https://api.github.com/users/balamurugana/followers","following_url":"https://api.github.com/users/balamurugana/following{/other_user}","gists_url":"https://api.github.com/users/balamurugana/gists{/gist_id}","starred_url":"https://api.github.com/users/balamurugana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balamurugana/subscriptions","organizations_url":"https://api.github.com/users/balamurugana/orgs","repos_url":"https://api.github.com/users/balamurugana/repos","events_url":"https://api.github.com/users/balamurugana/events{/privacy}","received_events_url":"https://api.github.com/users/balamurugana/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/balamurugana/minio","description":"Cloud Storage Server for Micro Services.","fork":true,"url":"https://api.github.com/repos/balamurugana/minio","forks_url":"https://api.github.com/repos/balamurugana/minio/forks","keys_url":"https://api.github.com/repos/balamurugana/minio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/balamurugana/minio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/balamurugana/minio/teams","hooks_url":"https://api.github.com/repos/balamurugana/minio/hooks","issue_events_url":"https://api.github.com/repos/balamurugana/minio/issues/events{/number}","events_url":"https://api.github.com/repos/balamurugana/minio/events","assignees_url":"https://api.github.com/repos/balamurugana/minio/assignees{/user}","branches_url":"https://api.github.com/repos/balamurugana/minio/branches{/branch}","tags_url":"https://api.github.com/repos/balamurugana/minio/tags","blobs_url":"https://api.github.com/repos/balamurugana/minio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/balamurugana/minio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/balamurugana/minio/git/refs{/sha}","trees_url":"https://api.github.com/repos/balamurugana/minio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/balamurugana/minio/statuses/{sha}","languages_url":"https://api.github.com/repos/balamurugana/minio/languages","stargazers_url":"https://api.github.com/repos/balamurugana/minio/stargazers","contributors_url":"https://api.github.com/repos/balamurugana/minio/contributors","subscribers_url":"https://api.github.com/repos/balamurugana/minio/subscribers","subscription_url":"https://api.github.com/repos/balamurugana/minio/subscription","commits_url":"https://api.github.com/repos/balamurugana/minio/commits{/sha}","git_commits_url":"https://api.github.com/repos/balamurugana/minio/git/commits{/sha}","comments_url":"https://api.github.com/repos/balamurugana/minio/comments{/number}","issue_comment_url":"https://api.github.com/repos/balamurugana/minio/issues/comments{/number}","contents_url":"https://api.github.com/repos/balamurugana/minio/contents/{+path}","compare_url":"https://api.github.com/repos/balamurugana/minio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/balamurugana/minio/merges","archive_url":"https://api.github.com/repos/balamurugana/minio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/balamurugana/minio/downloads","issues_url":"https://api.github.com/repos/balamurugana/minio/issues{/number}","pulls_url":"https://api.github.com/repos/balamurugana/minio/pulls{/number}","milestones_url":"https://api.github.com/repos/balamurugana/minio/milestones{/number}","notifications_url":"https://api.github.com/repos/balamurugana/minio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/balamurugana/minio/labels{/name}","releases_url":"https://api.github.com/repos/balamurugana/minio/releases{/id}","deployments_url":"https://api.github.com/repos/balamurugana/minio/deployments","created_at":"2015-12-01T00:34:25Z","updated_at":"2016-01-27T01:05:16Z","pushed_at":"2016-07-07T07:26:49Z","git_url":"git://github.com/balamurugana/minio.git","ssh_url":"git@github.com:balamurugana/minio.git","clone_url":"https://github.com/balamurugana/minio.git","svn_url":"https://github.com/balamurugana/minio","homepage":"","size":14101,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"minio:master","ref":"master","sha":"169c72cdab14ac0f993161f6ed97e8462eccfb97","user":{"login":"minio","id":695951,"avatar_url":"https://avatars.githubusercontent.com/u/695951?v=3","gravatar_id":"","url":"https://api.github.com/users/minio","html_url":"https://github.com/minio","followers_url":"https://api.github.com/users/minio/followers","following_url":"https://api.github.com/users/minio/following{/other_user}","gists_url":"https://api.github.com/users/minio/gists{/gist_id}","starred_url":"https://api.github.com/users/minio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minio/subscriptions","organizations_url":"https://api.github.com/users/minio/orgs","repos_url":"https://api.github.com/users/minio/repos","events_url":"https://api.github.com/users/minio/events{/privacy}","received_events_url":"https://api.github.com/users/minio/received_events","type":"Organization","site_admin":false},"repo":{"id":29261473,"name":"minio","full_name":"minio/minio","owner":{"login":"minio","id":695951,"avatar_url":"https://avatars.githubusercontent.com/u/695951?v=3","gravatar_id":"","url":"https://api.github.com/users/minio","html_url":"https://github.com/minio","followers_url":"https://api.github.com/users/minio/followers","following_url":"https://api.github.com/users/minio/following{/other_user}","gists_url":"https://api.github.com/users/minio/gists{/gist_id}","starred_url":"https://api.github.com/users/minio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minio/subscriptions","organizations_url":"https://api.github.com/users/minio/orgs","repos_url":"https://api.github.com/users/minio/repos","events_url":"https://api.github.com/users/minio/events{/privacy}","received_events_url":"https://api.github.com/users/minio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/minio/minio","description":"Minio is an object storage server compatible with Amazon S3 and licensed under Apache 2.0 License","fork":false,"url":"https://api.github.com/repos/minio/minio","forks_url":"https://api.github.com/repos/minio/minio/forks","keys_url":"https://api.github.com/repos/minio/minio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/minio/minio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/minio/minio/teams","hooks_url":"https://api.github.com/repos/minio/minio/hooks","issue_events_url":"https://api.github.com/repos/minio/minio/issues/events{/number}","events_url":"https://api.github.com/repos/minio/minio/events","assignees_url":"https://api.github.com/repos/minio/minio/assignees{/user}","branches_url":"https://api.github.com/repos/minio/minio/branches{/branch}","tags_url":"https://api.github.com/repos/minio/minio/tags","blobs_url":"https://api.github.com/repos/minio/minio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/minio/minio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/minio/minio/git/refs{/sha}","trees_url":"https://api.github.com/repos/minio/minio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/minio/minio/statuses/{sha}","languages_url":"https://api.github.com/repos/minio/minio/languages","stargazers_url":"https://api.github.com/repos/minio/minio/stargazers","contributors_url":"https://api.github.com/repos/minio/minio/contributors","subscribers_url":"https://api.github.com/repos/minio/minio/subscribers","subscription_url":"https://api.github.com/repos/minio/minio/subscription","commits_url":"https://api.github.com/repos/minio/minio/commits{/sha}","git_commits_url":"https://api.github.com/repos/minio/minio/git/commits{/sha}","comments_url":"https://api.github.com/repos/minio/minio/comments{/number}","issue_comment_url":"https://api.github.com/repos/minio/minio/issues/comments{/number}","contents_url":"https://api.github.com/repos/minio/minio/contents/{+path}","compare_url":"https://api.github.com/repos/minio/minio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/minio/minio/merges","archive_url":"https://api.github.com/repos/minio/minio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/minio/minio/downloads","issues_url":"https://api.github.com/repos/minio/minio/issues{/number}","pulls_url":"https://api.github.com/repos/minio/minio/pulls{/number}","milestones_url":"https://api.github.com/repos/minio/minio/milestones{/number}","notifications_url":"https://api.github.com/repos/minio/minio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/minio/minio/labels{/name}","releases_url":"https://api.github.com/repos/minio/minio/releases{/id}","deployments_url":"https://api.github.com/repos/minio/minio/deployments","created_at":"2015-01-14T19:23:58Z","updated_at":"2016-07-07T07:13:08Z","pushed_at":"2016-07-07T07:26:59Z","git_url":"git://github.com/minio/minio.git","ssh_url":"git@github.com:minio/minio.git","clone_url":"https://github.com/minio/minio.git","svn_url":"https://github.com/minio/minio","homepage":"https://minio.io/downloads/","size":15247,"stargazers_count":1502,"watchers_count":1502,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":140,"mirror_url":null,"open_issues_count":60,"forks":140,"open_issues":60,"watchers":1502,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/minio/minio/pulls/2122"},"html":{"href":"https://github.com/minio/minio/pull/2122"},"issue":{"href":"https://api.github.com/repos/minio/minio/issues/2122"},"comments":{"href":"https://api.github.com/repos/minio/minio/issues/2122/comments"},"review_comments":{"href":"https://api.github.com/repos/minio/minio/pulls/2122/comments"},"review_comment":{"href":"https://api.github.com/repos/minio/minio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/minio/minio/pulls/2122/commits"},"statuses":{"href":"https://api.github.com/repos/minio/minio/statuses/22fe3f0f1023a33f069ed402d7f4da73aad209ba"}}}}
{"actor":{"display_login":"hackintoshrao"}}