{"action":"created","issue":{"url":"https://api.github.com/repos/linux-test-project/ltp/issues/94","repository_url":"https://api.github.com/repos/linux-test-project/ltp","labels_url":"https://api.github.com/repos/linux-test-project/ltp/issues/94/labels{/name}","comments_url":"https://api.github.com/repos/linux-test-project/ltp/issues/94/comments","events_url":"https://api.github.com/repos/linux-test-project/ltp/issues/94/events","html_url":"https://github.com/linux-test-project/ltp/pull/94","id":175705491,"number":94,"title":"Three testcase fixes","user":{"login":"chenhuacai","id":21258802,"avatar_url":"https://avatars.githubusercontent.com/u/21258802?v=3","gravatar_id":"","url":"https://api.github.com/users/chenhuacai","html_url":"https://github.com/chenhuacai","followers_url":"https://api.github.com/users/chenhuacai/followers","following_url":"https://api.github.com/users/chenhuacai/following{/other_user}","gists_url":"https://api.github.com/users/chenhuacai/gists{/gist_id}","starred_url":"https://api.github.com/users/chenhuacai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chenhuacai/subscriptions","organizations_url":"https://api.github.com/users/chenhuacai/orgs","repos_url":"https://api.github.com/users/chenhuacai/repos","events_url":"https://api.github.com/users/chenhuacai/events{/privacy}","received_events_url":"https://api.github.com/users/chenhuacai/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-09-08T09:23:23Z","updated_at":"2016-10-11T14:26:22Z","closed_at":"2016-10-04T14:02:03Z","pull_request":{"url":"https://api.github.com/repos/linux-test-project/ltp/pulls/94","html_url":"https://github.com/linux-test-project/ltp/pull/94","diff_url":"https://github.com/linux-test-project/ltp/pull/94.diff","patch_url":"https://github.com/linux-test-project/ltp/pull/94.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/linux-test-project/ltp/issues/comments/252932536","html_url":"https://github.com/linux-test-project/ltp/pull/94#issuecomment-252932536","issue_url":"https://api.github.com/repos/linux-test-project/ltp/issues/94","id":252932536,"user":{"login":"metan-ucw","id":1465701,"avatar_url":"https://avatars.githubusercontent.com/u/1465701?v=3","gravatar_id":"","url":"https://api.github.com/users/metan-ucw","html_url":"https://github.com/metan-ucw","followers_url":"https://api.github.com/users/metan-ucw/followers","following_url":"https://api.github.com/users/metan-ucw/following{/other_user}","gists_url":"https://api.github.com/users/metan-ucw/gists{/gist_id}","starred_url":"https://api.github.com/users/metan-ucw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metan-ucw/subscriptions","organizations_url":"https://api.github.com/users/metan-ucw/orgs","repos_url":"https://api.github.com/users/metan-ucw/repos","events_url":"https://api.github.com/users/metan-ucw/events{/privacy}","received_events_url":"https://api.github.com/users/metan-ucw/received_events","type":"User","site_admin":false},"created_at":"2016-10-11T14:26:22Z","updated_at":"2016-10-11T14:26:22Z","body":"> > *@metan-ucw* commented on this pull request.\n> > ------------------------------\n> >\n> > In testscripts/test_fs_bind.sh\n> > <https://github.com/linux-test-project/ltp/pull/94#pullrequestreview-2716967>\n> > :\n> >\n> > > @@ -498,6 +498,7 @@ main()\n> >  \t\t\t((TST_COUNT++))\n> >  \t\tdone\n> >  \tdone\n> > +\trm -rf \"${resdir}\"\n> >  \trm -rf \"${sandbox}\"\n> >  \treturn 0\n> >\n> >\n> > The testscript actually leaves the logs there in case that something went\n> > wrong, deleting the directory at the test end is wrong thing to do.\n> >\n> > Also I don't understand why deleting $resdir that is located in\n> > ${LTPROOT}/results/fs_bind can\n> > cause problem with deleting the ${TMPDIR}/sandbox. Can you please\n> > elaborate on that?\n> >\n> Hi, Cyril,\n> \n> Suppose that we run test_fs_bind.sh repeatedly: If we don't remove ${resdir}\n> at the first time, then at the second time save_sandbox() will return with\n> \"stale catalog...\" and do_break is set to 1, then run_test() will return\n> without umount ${sandbox}, and at the end, remove ${sandbox} fails.\n\nStill deleting debugging logs at the end of the testscript run is\nwrong.\n\nIdeally the script should be cleaned up and rewritten not to leave any\nfiles behind. And also cleanup correctly if the test exits with an error\nin the middle of initialization. Looking at the script the easiest\nsolution may be figure out what the script is supposed to test and start\nfrom a scratch.\n\n-- \nCyril Hrubis\nchrubis@suse.cz\n"}}
{"actor":{"display_login":"metan-ucw"}}