{"action":"created","comment":{"url":"https://api.github.com/repos/nim-lang/Nim/pulls/comments/71376313","id":71376313,"diff_hunk":"@@ -410,6 +410,45 @@ when defined(Windows) and not defined(useNimRtl):\n       copyMem(addr(result[L]), cstring(x), x.len+1) # copy \\0\n       inc(L, x.len+1)\n \n+  proc envToWideCString(env: StringTableRef): WideCString =\n+    # newWideCString stops on \\0 characters, so we have to\n+    # convert every pair separately.\n+    const wcharSize = 2\n+    var rows = newSeq[tuple[str: WideCString, len: int]]()","path":"lib/pure/osproc.nim","position":17,"original_position":17,"commit_id":"5f773bf478b57af7cdb56a895feec610908ffdeb","original_commit_id":"5f773bf478b57af7cdb56a895feec610908ffdeb","user":{"login":"Araq","id":287816,"avatar_url":"https://avatars.githubusercontent.com/u/287816?v=3","gravatar_id":"","url":"https://api.github.com/users/Araq","html_url":"https://github.com/Araq","followers_url":"https://api.github.com/users/Araq/followers","following_url":"https://api.github.com/users/Araq/following{/other_user}","gists_url":"https://api.github.com/users/Araq/gists{/gist_id}","starred_url":"https://api.github.com/users/Araq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Araq/subscriptions","organizations_url":"https://api.github.com/users/Araq/orgs","repos_url":"https://api.github.com/users/Araq/repos","events_url":"https://api.github.com/users/Araq/events{/privacy}","received_events_url":"https://api.github.com/users/Araq/received_events","type":"User","site_admin":false},"body":"This temporary seq is not required.","created_at":"2016-07-19T16:41:54Z","updated_at":"2016-07-19T16:41:54Z","html_url":"https://github.com/nim-lang/Nim/pull/4500#discussion_r71376313","pull_request_url":"https://api.github.com/repos/nim-lang/Nim/pulls/4500","_links":{"self":{"href":"https://api.github.com/repos/nim-lang/Nim/pulls/comments/71376313"},"html":{"href":"https://github.com/nim-lang/Nim/pull/4500#discussion_r71376313"},"pull_request":{"href":"https://api.github.com/repos/nim-lang/Nim/pulls/4500"}}},"pull_request":{"url":"https://api.github.com/repos/nim-lang/Nim/pulls/4500","id":77925177,"html_url":"https://github.com/nim-lang/Nim/pull/4500","diff_url":"https://github.com/nim-lang/Nim/pull/4500.diff","patch_url":"https://github.com/nim-lang/Nim/pull/4500.patch","issue_url":"https://api.github.com/repos/nim-lang/Nim/issues/4500","number":4500,"state":"open","locked":false,"title":"Fix passing environment in startProcess (win)","user":{"login":"nigredo-tori","id":5962285,"avatar_url":"https://avatars.githubusercontent.com/u/5962285?v=3","gravatar_id":"","url":"https://api.github.com/users/nigredo-tori","html_url":"https://github.com/nigredo-tori","followers_url":"https://api.github.com/users/nigredo-tori/followers","following_url":"https://api.github.com/users/nigredo-tori/following{/other_user}","gists_url":"https://api.github.com/users/nigredo-tori/gists{/gist_id}","starred_url":"https://api.github.com/users/nigredo-tori/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nigredo-tori/subscriptions","organizations_url":"https://api.github.com/users/nigredo-tori/orgs","repos_url":"https://api.github.com/users/nigredo-tori/repos","events_url":"https://api.github.com/users/nigredo-tori/events{/privacy}","received_events_url":"https://api.github.com/users/nigredo-tori/received_events","type":"User","site_admin":false},"body":"Previous implementation used newWideCString, which doesn't\r\nhandle strings with \\0 characters.\r\n\r\nFixes #4499 .","created_at":"2016-07-19T06:43:53Z","updated_at":"2016-07-19T16:41:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"41ed3d81e956e2d30a3a02a87fb5ed4a1a4dabe6","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/nim-lang/Nim/pulls/4500/commits","review_comments_url":"https://api.github.com/repos/nim-lang/Nim/pulls/4500/comments","review_comment_url":"https://api.github.com/repos/nim-lang/Nim/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nim-lang/Nim/issues/4500/comments","statuses_url":"https://api.github.com/repos/nim-lang/Nim/statuses/5f773bf478b57af7cdb56a895feec610908ffdeb","head":{"label":"nigredo-tori:fix-osproc-env","ref":"fix-osproc-env","sha":"5f773bf478b57af7cdb56a895feec610908ffdeb","user":{"login":"nigredo-tori","id":5962285,"avatar_url":"https://avatars.githubusercontent.com/u/5962285?v=3","gravatar_id":"","url":"https://api.github.com/users/nigredo-tori","html_url":"https://github.com/nigredo-tori","followers_url":"https://api.github.com/users/nigredo-tori/followers","following_url":"https://api.github.com/users/nigredo-tori/following{/other_user}","gists_url":"https://api.github.com/users/nigredo-tori/gists{/gist_id}","starred_url":"https://api.github.com/users/nigredo-tori/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nigredo-tori/subscriptions","organizations_url":"https://api.github.com/users/nigredo-tori/orgs","repos_url":"https://api.github.com/users/nigredo-tori/repos","events_url":"https://api.github.com/users/nigredo-tori/events{/privacy}","received_events_url":"https://api.github.com/users/nigredo-tori/received_events","type":"User","site_admin":false},"repo":{"id":62991893,"name":"Nim","full_name":"nigredo-tori/Nim","owner":{"login":"nigredo-tori","id":5962285,"avatar_url":"https://avatars.githubusercontent.com/u/5962285?v=3","gravatar_id":"","url":"https://api.github.com/users/nigredo-tori","html_url":"https://github.com/nigredo-tori","followers_url":"https://api.github.com/users/nigredo-tori/followers","following_url":"https://api.github.com/users/nigredo-tori/following{/other_user}","gists_url":"https://api.github.com/users/nigredo-tori/gists{/gist_id}","starred_url":"https://api.github.com/users/nigredo-tori/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nigredo-tori/subscriptions","organizations_url":"https://api.github.com/users/nigredo-tori/orgs","repos_url":"https://api.github.com/users/nigredo-tori/repos","events_url":"https://api.github.com/users/nigredo-tori/events{/privacy}","received_events_url":"https://api.github.com/users/nigredo-tori/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nigredo-tori/Nim","description":"Nim (formerly known as \"Nimrod\") is a compiled, garbage-collected systems programming language which has an excellent productivity/performance ratio. Nim's design focuses on efficiency, expressiveness, elegance (in the order of priority).","fork":true,"url":"https://api.github.com/repos/nigredo-tori/Nim","forks_url":"https://api.github.com/repos/nigredo-tori/Nim/forks","keys_url":"https://api.github.com/repos/nigredo-tori/Nim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nigredo-tori/Nim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nigredo-tori/Nim/teams","hooks_url":"https://api.github.com/repos/nigredo-tori/Nim/hooks","issue_events_url":"https://api.github.com/repos/nigredo-tori/Nim/issues/events{/number}","events_url":"https://api.github.com/repos/nigredo-tori/Nim/events","assignees_url":"https://api.github.com/repos/nigredo-tori/Nim/assignees{/user}","branches_url":"https://api.github.com/repos/nigredo-tori/Nim/branches{/branch}","tags_url":"https://api.github.com/repos/nigredo-tori/Nim/tags","blobs_url":"https://api.github.com/repos/nigredo-tori/Nim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nigredo-tori/Nim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nigredo-tori/Nim/git/refs{/sha}","trees_url":"https://api.github.com/repos/nigredo-tori/Nim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nigredo-tori/Nim/statuses/{sha}","languages_url":"https://api.github.com/repos/nigredo-tori/Nim/languages","stargazers_url":"https://api.github.com/repos/nigredo-tori/Nim/stargazers","contributors_url":"https://api.github.com/repos/nigredo-tori/Nim/contributors","subscribers_url":"https://api.github.com/repos/nigredo-tori/Nim/subscribers","subscription_url":"https://api.github.com/repos/nigredo-tori/Nim/subscription","commits_url":"https://api.github.com/repos/nigredo-tori/Nim/commits{/sha}","git_commits_url":"https://api.github.com/repos/nigredo-tori/Nim/git/commits{/sha}","comments_url":"https://api.github.com/repos/nigredo-tori/Nim/comments{/number}","issue_comment_url":"https://api.github.com/repos/nigredo-tori/Nim/issues/comments{/number}","contents_url":"https://api.github.com/repos/nigredo-tori/Nim/contents/{+path}","compare_url":"https://api.github.com/repos/nigredo-tori/Nim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nigredo-tori/Nim/merges","archive_url":"https://api.github.com/repos/nigredo-tori/Nim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nigredo-tori/Nim/downloads","issues_url":"https://api.github.com/repos/nigredo-tori/Nim/issues{/number}","pulls_url":"https://api.github.com/repos/nigredo-tori/Nim/pulls{/number}","milestones_url":"https://api.github.com/repos/nigredo-tori/Nim/milestones{/number}","notifications_url":"https://api.github.com/repos/nigredo-tori/Nim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nigredo-tori/Nim/labels{/name}","releases_url":"https://api.github.com/repos/nigredo-tori/Nim/releases{/id}","deployments_url":"https://api.github.com/repos/nigredo-tori/Nim/deployments","created_at":"2016-07-10T09:39:38Z","updated_at":"2016-07-10T09:39:43Z","pushed_at":"2016-07-19T06:33:15Z","git_url":"git://github.com/nigredo-tori/Nim.git","ssh_url":"git@github.com:nigredo-tori/Nim.git","clone_url":"https://github.com/nigredo-tori/Nim.git","svn_url":"https://github.com/nigredo-tori/Nim","homepage":"http://nim-lang.org/","size":42263,"stargazers_count":0,"watchers_count":0,"language":"Nimrod","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"devel"}},"base":{"label":"nim-lang:devel","ref":"devel","sha":"358f582939ed09ccb43ce9f00d4e14741606cb36","user":{"login":"nim-lang","id":603863,"avatar_url":"https://avatars.githubusercontent.com/u/603863?v=3","gravatar_id":"","url":"https://api.github.com/users/nim-lang","html_url":"https://github.com/nim-lang","followers_url":"https://api.github.com/users/nim-lang/followers","following_url":"https://api.github.com/users/nim-lang/following{/other_user}","gists_url":"https://api.github.com/users/nim-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/nim-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nim-lang/subscriptions","organizations_url":"https://api.github.com/users/nim-lang/orgs","repos_url":"https://api.github.com/users/nim-lang/repos","events_url":"https://api.github.com/users/nim-lang/events{/privacy}","received_events_url":"https://api.github.com/users/nim-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":842037,"name":"Nim","full_name":"nim-lang/Nim","owner":{"login":"nim-lang","id":603863,"avatar_url":"https://avatars.githubusercontent.com/u/603863?v=3","gravatar_id":"","url":"https://api.github.com/users/nim-lang","html_url":"https://github.com/nim-lang","followers_url":"https://api.github.com/users/nim-lang/followers","following_url":"https://api.github.com/users/nim-lang/following{/other_user}","gists_url":"https://api.github.com/users/nim-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/nim-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nim-lang/subscriptions","organizations_url":"https://api.github.com/users/nim-lang/orgs","repos_url":"https://api.github.com/users/nim-lang/repos","events_url":"https://api.github.com/users/nim-lang/events{/privacy}","received_events_url":"https://api.github.com/users/nim-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nim-lang/Nim","description":"Nim (formerly known as \"Nimrod\") is a compiled, garbage-collected systems programming language which has an excellent productivity/performance ratio. Nim's design focuses on efficiency, expressiveness, elegance (in the order of priority).","fork":false,"url":"https://api.github.com/repos/nim-lang/Nim","forks_url":"https://api.github.com/repos/nim-lang/Nim/forks","keys_url":"https://api.github.com/repos/nim-lang/Nim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nim-lang/Nim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nim-lang/Nim/teams","hooks_url":"https://api.github.com/repos/nim-lang/Nim/hooks","issue_events_url":"https://api.github.com/repos/nim-lang/Nim/issues/events{/number}","events_url":"https://api.github.com/repos/nim-lang/Nim/events","assignees_url":"https://api.github.com/repos/nim-lang/Nim/assignees{/user}","branches_url":"https://api.github.com/repos/nim-lang/Nim/branches{/branch}","tags_url":"https://api.github.com/repos/nim-lang/Nim/tags","blobs_url":"https://api.github.com/repos/nim-lang/Nim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nim-lang/Nim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nim-lang/Nim/git/refs{/sha}","trees_url":"https://api.github.com/repos/nim-lang/Nim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nim-lang/Nim/statuses/{sha}","languages_url":"https://api.github.com/repos/nim-lang/Nim/languages","stargazers_url":"https://api.github.com/repos/nim-lang/Nim/stargazers","contributors_url":"https://api.github.com/repos/nim-lang/Nim/contributors","subscribers_url":"https://api.github.com/repos/nim-lang/Nim/subscribers","subscription_url":"https://api.github.com/repos/nim-lang/Nim/subscription","commits_url":"https://api.github.com/repos/nim-lang/Nim/commits{/sha}","git_commits_url":"https://api.github.com/repos/nim-lang/Nim/git/commits{/sha}","comments_url":"https://api.github.com/repos/nim-lang/Nim/comments{/number}","issue_comment_url":"https://api.github.com/repos/nim-lang/Nim/issues/comments{/number}","contents_url":"https://api.github.com/repos/nim-lang/Nim/contents/{+path}","compare_url":"https://api.github.com/repos/nim-lang/Nim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nim-lang/Nim/merges","archive_url":"https://api.github.com/repos/nim-lang/Nim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nim-lang/Nim/downloads","issues_url":"https://api.github.com/repos/nim-lang/Nim/issues{/number}","pulls_url":"https://api.github.com/repos/nim-lang/Nim/pulls{/number}","milestones_url":"https://api.github.com/repos/nim-lang/Nim/milestones{/number}","notifications_url":"https://api.github.com/repos/nim-lang/Nim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nim-lang/Nim/labels{/name}","releases_url":"https://api.github.com/repos/nim-lang/Nim/releases{/id}","deployments_url":"https://api.github.com/repos/nim-lang/Nim/deployments","created_at":"2010-08-16T20:38:58Z","updated_at":"2016-07-19T16:08:53Z","pushed_at":"2016-07-19T13:40:50Z","git_url":"git://github.com/nim-lang/Nim.git","ssh_url":"git@github.com:nim-lang/Nim.git","clone_url":"https://github.com/nim-lang/Nim.git","svn_url":"https://github.com/nim-lang/Nim","homepage":"http://nim-lang.org/","size":353325,"stargazers_count":2974,"watchers_count":2974,"language":"Nimrod","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":407,"mirror_url":null,"open_issues_count":768,"forks":407,"open_issues":768,"watchers":2974,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/nim-lang/Nim/pulls/4500"},"html":{"href":"https://github.com/nim-lang/Nim/pull/4500"},"issue":{"href":"https://api.github.com/repos/nim-lang/Nim/issues/4500"},"comments":{"href":"https://api.github.com/repos/nim-lang/Nim/issues/4500/comments"},"review_comments":{"href":"https://api.github.com/repos/nim-lang/Nim/pulls/4500/comments"},"review_comment":{"href":"https://api.github.com/repos/nim-lang/Nim/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nim-lang/Nim/pulls/4500/commits"},"statuses":{"href":"https://api.github.com/repos/nim-lang/Nim/statuses/5f773bf478b57af7cdb56a895feec610908ffdeb"}}}}
{"actor":{"display_login":"Araq"}}