{"action":"created","issue":{"url":"https://api.github.com/repos/shelljs/shelljs/issues/362","repository_url":"https://api.github.com/repos/shelljs/shelljs","labels_url":"https://api.github.com/repos/shelljs/shelljs/issues/362/labels{/name}","comments_url":"https://api.github.com/repos/shelljs/shelljs/issues/362/comments","events_url":"https://api.github.com/repos/shelljs/shelljs/issues/362/events","html_url":"https://github.com/shelljs/shelljs/pull/362","id":134183067,"number":362,"title":"fix(verbose): verbose-style logging is consistent","user":{"login":"nfischer","id":5801521,"avatar_url":"https://avatars.githubusercontent.com/u/5801521?v=3","gravatar_id":"","url":"https://api.github.com/users/nfischer","html_url":"https://github.com/nfischer","followers_url":"https://api.github.com/users/nfischer/followers","following_url":"https://api.github.com/users/nfischer/following{/other_user}","gists_url":"https://api.github.com/users/nfischer/gists{/gist_id}","starred_url":"https://api.github.com/users/nfischer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nfischer/subscriptions","organizations_url":"https://api.github.com/users/nfischer/orgs","repos_url":"https://api.github.com/users/nfischer/repos","events_url":"https://api.github.com/users/nfischer/events{/privacy}","received_events_url":"https://api.github.com/users/nfischer/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/shelljs/shelljs/labels/fix","name":"fix","color":"fc2929"},{"url":"https://api.github.com/repos/shelljs/shelljs/labels/medium%20priority","name":"medium priority","color":"fbca04"}],"state":"open","locked":false,"assignee":{"login":"ariporad","id":1817508,"avatar_url":"https://avatars.githubusercontent.com/u/1817508?v=3","gravatar_id":"","url":"https://api.github.com/users/ariporad","html_url":"https://github.com/ariporad","followers_url":"https://api.github.com/users/ariporad/followers","following_url":"https://api.github.com/users/ariporad/following{/other_user}","gists_url":"https://api.github.com/users/ariporad/gists{/gist_id}","starred_url":"https://api.github.com/users/ariporad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ariporad/subscriptions","organizations_url":"https://api.github.com/users/ariporad/orgs","repos_url":"https://api.github.com/users/ariporad/repos","events_url":"https://api.github.com/users/ariporad/events{/privacy}","received_events_url":"https://api.github.com/users/ariporad/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/shelljs/shelljs/milestones/3","html_url":"https://github.com/shelljs/shelljs/milestones/v0.7.0","labels_url":"https://api.github.com/repos/shelljs/shelljs/milestones/3/labels","id":1555794,"number":3,"title":"v0.7.0","description":"","creator":{"login":"ariporad","id":1817508,"avatar_url":"https://avatars.githubusercontent.com/u/1817508?v=3","gravatar_id":"","url":"https://api.github.com/users/ariporad","html_url":"https://github.com/ariporad","followers_url":"https://api.github.com/users/ariporad/followers","following_url":"https://api.github.com/users/ariporad/following{/other_user}","gists_url":"https://api.github.com/users/ariporad/gists{/gist_id}","starred_url":"https://api.github.com/users/ariporad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ariporad/subscriptions","organizations_url":"https://api.github.com/users/ariporad/orgs","repos_url":"https://api.github.com/users/ariporad/repos","events_url":"https://api.github.com/users/ariporad/events{/privacy}","received_events_url":"https://api.github.com/users/ariporad/received_events","type":"User","site_admin":false},"open_issues":16,"closed_issues":17,"state":"open","created_at":"2016-02-01T14:48:26Z","updated_at":"2016-02-17T05:27:15Z","due_on":null,"closed_at":null},"comments":2,"created_at":"2016-02-17T05:27:15Z","updated_at":"2016-02-17T20:06:17Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/shelljs/shelljs/pulls/362","html_url":"https://github.com/shelljs/shelljs/pull/362","diff_url":"https://github.com/shelljs/shelljs/pull/362.diff","patch_url":"https://github.com/shelljs/shelljs/pull/362.patch"},"body":"This fixes a couple issues with `config.verbose` logging, and some related things.\r\n\r\n - `set('-v')` previously didn't log `echo()` commands because those weren't `common.wrap`'ed\r\n - `echo()` is now wrapped, but is designed to still allow echoing strings that start with \"-\" (ex. \"-1*3+5\") (see issue #20)\r\n - `echo()` still does not glob. This is because 1. globbing isn't that useful for `echo()` in my opinion, and 2. echo is frequently used enough that it should have good performance by default\r\n - internal errors are now outputted to stderr instead of stdout\r\n - `set('-v')`-style logging goes to stderr, not stdout. This resembles Bash's behavior with `set -v`\r\n\r\nThe way this is implemented, `echo()` still doesn't support any options, but we may want to consider allowing for that in the future (`-n` comes to mind). It'd be pretty easy to add support for that option once this is merged.\r\n\r\nAlso, it simplifies things if `echo()` is wrapped, since it ensures that commands like `echo(pwd())` still work the same, even if #360 lands."},"comment":{"url":"https://api.github.com/repos/shelljs/shelljs/issues/comments/185380660","html_url":"https://github.com/shelljs/shelljs/pull/362#issuecomment-185380660","issue_url":"https://api.github.com/repos/shelljs/shelljs/issues/362","id":185380660,"user":{"login":"nfischer","id":5801521,"avatar_url":"https://avatars.githubusercontent.com/u/5801521?v=3","gravatar_id":"","url":"https://api.github.com/users/nfischer","html_url":"https://github.com/nfischer","followers_url":"https://api.github.com/users/nfischer/followers","following_url":"https://api.github.com/users/nfischer/following{/other_user}","gists_url":"https://api.github.com/users/nfischer/gists{/gist_id}","starred_url":"https://api.github.com/users/nfischer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nfischer/subscriptions","organizations_url":"https://api.github.com/users/nfischer/orgs","repos_url":"https://api.github.com/users/nfischer/repos","events_url":"https://api.github.com/users/nfischer/events{/privacy}","received_events_url":"https://api.github.com/users/nfischer/received_events","type":"User","site_admin":false},"created_at":"2016-02-17T20:06:16Z","updated_at":"2016-02-17T20:06:16Z","body":"@ariporad I fixed one of the tests to check that echo is logged (it previously allowed it not to be logged, since it wasn't wrapped)"}}