{"action":"created","comment":{"url":"https://api.github.com/repos/python-diamond/Diamond/pulls/comments/60833791","id":60833791,"diff_hunk":"@@ -88,60 +88,12 @@ def convertb(self, value, source, offset=1):\n         else:\n             source(value * pow(1024, offset))\n \n-    def kilobit(self, value=None):","path":"src/diamond/convertor.py","position":91,"original_position":91,"commit_id":"6041171d899ea1ee3878c6961aa91effa7602266","original_commit_id":"6041171d899ea1ee3878c6961aa91effa7602266","user":{"login":"jaingaurav","id":84372,"avatar_url":"https://avatars.githubusercontent.com/u/84372?v=3","gravatar_id":"","url":"https://api.github.com/users/jaingaurav","html_url":"https://github.com/jaingaurav","followers_url":"https://api.github.com/users/jaingaurav/followers","following_url":"https://api.github.com/users/jaingaurav/following{/other_user}","gists_url":"https://api.github.com/users/jaingaurav/gists{/gist_id}","starred_url":"https://api.github.com/users/jaingaurav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaingaurav/subscriptions","organizations_url":"https://api.github.com/users/jaingaurav/orgs","repos_url":"https://api.github.com/users/jaingaurav/repos","events_url":"https://api.github.com/users/jaingaurav/events{/privacy}","received_events_url":"https://api.github.com/users/jaingaurav/received_events","type":"User","site_admin":false},"body":"Are you sure these aren't referenced externally anywhere by some collectors?","created_at":"2016-04-23T19:41:34Z","updated_at":"2016-04-23T19:41:34Z","html_url":"https://github.com/python-diamond/Diamond/pull/439#discussion_r60833791","pull_request_url":"https://api.github.com/repos/python-diamond/Diamond/pulls/439","_links":{"self":{"href":"https://api.github.com/repos/python-diamond/Diamond/pulls/comments/60833791"},"html":{"href":"https://github.com/python-diamond/Diamond/pull/439#discussion_r60833791"},"pull_request":{"href":"https://api.github.com/repos/python-diamond/Diamond/pulls/439"}}},"pull_request":{"url":"https://api.github.com/repos/python-diamond/Diamond/pulls/439","id":63568999,"html_url":"https://github.com/python-diamond/Diamond/pull/439","diff_url":"https://github.com/python-diamond/Diamond/pull/439.diff","patch_url":"https://github.com/python-diamond/Diamond/pull/439.patch","issue_url":"https://api.github.com/repos/python-diamond/Diamond/issues/439","number":439,"state":"open","locked":false,"title":"Made code more DRY","user":{"login":"tusharmakkar08","id":2357025,"avatar_url":"https://avatars.githubusercontent.com/u/2357025?v=3","gravatar_id":"","url":"https://api.github.com/users/tusharmakkar08","html_url":"https://github.com/tusharmakkar08","followers_url":"https://api.github.com/users/tusharmakkar08/followers","following_url":"https://api.github.com/users/tusharmakkar08/following{/other_user}","gists_url":"https://api.github.com/users/tusharmakkar08/gists{/gist_id}","starred_url":"https://api.github.com/users/tusharmakkar08/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tusharmakkar08/subscriptions","organizations_url":"https://api.github.com/users/tusharmakkar08/orgs","repos_url":"https://api.github.com/users/tusharmakkar08/repos","events_url":"https://api.github.com/users/tusharmakkar08/events{/privacy}","received_events_url":"https://api.github.com/users/tusharmakkar08/received_events","type":"User","site_admin":false},"body":"Abstracted out the functionality and hence reducing number of \"if's\" in the code.","created_at":"2016-03-21T14:09:25Z","updated_at":"2016-04-23T19:41:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f0019076c9720b24c35f02e04fbbf6fc38b426ca","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/python-diamond/Diamond/pulls/439/commits","review_comments_url":"https://api.github.com/repos/python-diamond/Diamond/pulls/439/comments","review_comment_url":"https://api.github.com/repos/python-diamond/Diamond/pulls/comments{/number}","comments_url":"https://api.github.com/repos/python-diamond/Diamond/issues/439/comments","statuses_url":"https://api.github.com/repos/python-diamond/Diamond/statuses/6041171d899ea1ee3878c6961aa91effa7602266","head":{"label":"tusharmakkar08:master","ref":"master","sha":"6041171d899ea1ee3878c6961aa91effa7602266","user":{"login":"tusharmakkar08","id":2357025,"avatar_url":"https://avatars.githubusercontent.com/u/2357025?v=3","gravatar_id":"","url":"https://api.github.com/users/tusharmakkar08","html_url":"https://github.com/tusharmakkar08","followers_url":"https://api.github.com/users/tusharmakkar08/followers","following_url":"https://api.github.com/users/tusharmakkar08/following{/other_user}","gists_url":"https://api.github.com/users/tusharmakkar08/gists{/gist_id}","starred_url":"https://api.github.com/users/tusharmakkar08/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tusharmakkar08/subscriptions","organizations_url":"https://api.github.com/users/tusharmakkar08/orgs","repos_url":"https://api.github.com/users/tusharmakkar08/repos","events_url":"https://api.github.com/users/tusharmakkar08/events{/privacy}","received_events_url":"https://api.github.com/users/tusharmakkar08/received_events","type":"User","site_admin":false},"repo":{"id":54030779,"name":"Diamond","full_name":"tusharmakkar08/Diamond","owner":{"login":"tusharmakkar08","id":2357025,"avatar_url":"https://avatars.githubusercontent.com/u/2357025?v=3","gravatar_id":"","url":"https://api.github.com/users/tusharmakkar08","html_url":"https://github.com/tusharmakkar08","followers_url":"https://api.github.com/users/tusharmakkar08/followers","following_url":"https://api.github.com/users/tusharmakkar08/following{/other_user}","gists_url":"https://api.github.com/users/tusharmakkar08/gists{/gist_id}","starred_url":"https://api.github.com/users/tusharmakkar08/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tusharmakkar08/subscriptions","organizations_url":"https://api.github.com/users/tusharmakkar08/orgs","repos_url":"https://api.github.com/users/tusharmakkar08/repos","events_url":"https://api.github.com/users/tusharmakkar08/events{/privacy}","received_events_url":"https://api.github.com/users/tusharmakkar08/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tusharmakkar08/Diamond","description":"Diamond is a python daemon that collects system metrics and publishes them to Graphite (and others). It is capable of collecting cpu, memory, network, i/o, load and disk metrics. Additionally, it features an API for implementing custom collectors for gathering metrics from almost any source.","fork":true,"url":"https://api.github.com/repos/tusharmakkar08/Diamond","forks_url":"https://api.github.com/repos/tusharmakkar08/Diamond/forks","keys_url":"https://api.github.com/repos/tusharmakkar08/Diamond/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tusharmakkar08/Diamond/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tusharmakkar08/Diamond/teams","hooks_url":"https://api.github.com/repos/tusharmakkar08/Diamond/hooks","issue_events_url":"https://api.github.com/repos/tusharmakkar08/Diamond/issues/events{/number}","events_url":"https://api.github.com/repos/tusharmakkar08/Diamond/events","assignees_url":"https://api.github.com/repos/tusharmakkar08/Diamond/assignees{/user}","branches_url":"https://api.github.com/repos/tusharmakkar08/Diamond/branches{/branch}","tags_url":"https://api.github.com/repos/tusharmakkar08/Diamond/tags","blobs_url":"https://api.github.com/repos/tusharmakkar08/Diamond/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tusharmakkar08/Diamond/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tusharmakkar08/Diamond/git/refs{/sha}","trees_url":"https://api.github.com/repos/tusharmakkar08/Diamond/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tusharmakkar08/Diamond/statuses/{sha}","languages_url":"https://api.github.com/repos/tusharmakkar08/Diamond/languages","stargazers_url":"https://api.github.com/repos/tusharmakkar08/Diamond/stargazers","contributors_url":"https://api.github.com/repos/tusharmakkar08/Diamond/contributors","subscribers_url":"https://api.github.com/repos/tusharmakkar08/Diamond/subscribers","subscription_url":"https://api.github.com/repos/tusharmakkar08/Diamond/subscription","commits_url":"https://api.github.com/repos/tusharmakkar08/Diamond/commits{/sha}","git_commits_url":"https://api.github.com/repos/tusharmakkar08/Diamond/git/commits{/sha}","comments_url":"https://api.github.com/repos/tusharmakkar08/Diamond/comments{/number}","issue_comment_url":"https://api.github.com/repos/tusharmakkar08/Diamond/issues/comments{/number}","contents_url":"https://api.github.com/repos/tusharmakkar08/Diamond/contents/{+path}","compare_url":"https://api.github.com/repos/tusharmakkar08/Diamond/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tusharmakkar08/Diamond/merges","archive_url":"https://api.github.com/repos/tusharmakkar08/Diamond/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tusharmakkar08/Diamond/downloads","issues_url":"https://api.github.com/repos/tusharmakkar08/Diamond/issues{/number}","pulls_url":"https://api.github.com/repos/tusharmakkar08/Diamond/pulls{/number}","milestones_url":"https://api.github.com/repos/tusharmakkar08/Diamond/milestones{/number}","notifications_url":"https://api.github.com/repos/tusharmakkar08/Diamond/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tusharmakkar08/Diamond/labels{/name}","releases_url":"https://api.github.com/repos/tusharmakkar08/Diamond/releases{/id}","deployments_url":"https://api.github.com/repos/tusharmakkar08/Diamond/deployments","created_at":"2016-03-16T12:41:02Z","updated_at":"2016-03-16T12:41:04Z","pushed_at":"2016-03-21T14:14:05Z","git_url":"git://github.com/tusharmakkar08/Diamond.git","ssh_url":"git@github.com:tusharmakkar08/Diamond.git","clone_url":"https://github.com/tusharmakkar08/Diamond.git","svn_url":"https://github.com/tusharmakkar08/Diamond","homepage":"http://diamond.readthedocs.org/","size":3181,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"python-diamond:master","ref":"master","sha":"0fda1835308255e3ac4b287724340baf16b27bb1","user":{"login":"python-diamond","id":5668086,"avatar_url":"https://avatars.githubusercontent.com/u/5668086?v=3","gravatar_id":"","url":"https://api.github.com/users/python-diamond","html_url":"https://github.com/python-diamond","followers_url":"https://api.github.com/users/python-diamond/followers","following_url":"https://api.github.com/users/python-diamond/following{/other_user}","gists_url":"https://api.github.com/users/python-diamond/gists{/gist_id}","starred_url":"https://api.github.com/users/python-diamond/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/python-diamond/subscriptions","organizations_url":"https://api.github.com/users/python-diamond/orgs","repos_url":"https://api.github.com/users/python-diamond/repos","events_url":"https://api.github.com/users/python-diamond/events{/privacy}","received_events_url":"https://api.github.com/users/python-diamond/received_events","type":"Organization","site_admin":false},"repo":{"id":13512018,"name":"Diamond","full_name":"python-diamond/Diamond","owner":{"login":"python-diamond","id":5668086,"avatar_url":"https://avatars.githubusercontent.com/u/5668086?v=3","gravatar_id":"","url":"https://api.github.com/users/python-diamond","html_url":"https://github.com/python-diamond","followers_url":"https://api.github.com/users/python-diamond/followers","following_url":"https://api.github.com/users/python-diamond/following{/other_user}","gists_url":"https://api.github.com/users/python-diamond/gists{/gist_id}","starred_url":"https://api.github.com/users/python-diamond/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/python-diamond/subscriptions","organizations_url":"https://api.github.com/users/python-diamond/orgs","repos_url":"https://api.github.com/users/python-diamond/repos","events_url":"https://api.github.com/users/python-diamond/events{/privacy}","received_events_url":"https://api.github.com/users/python-diamond/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/python-diamond/Diamond","description":"Diamond is a python daemon that collects system metrics and publishes them to Graphite (and others). It is capable of collecting cpu, memory, network, i/o, load and disk metrics. Additionally, it features an API for implementing custom collectors for gathering metrics from almost any source.","fork":false,"url":"https://api.github.com/repos/python-diamond/Diamond","forks_url":"https://api.github.com/repos/python-diamond/Diamond/forks","keys_url":"https://api.github.com/repos/python-diamond/Diamond/keys{/key_id}","collaborators_url":"https://api.github.com/repos/python-diamond/Diamond/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/python-diamond/Diamond/teams","hooks_url":"https://api.github.com/repos/python-diamond/Diamond/hooks","issue_events_url":"https://api.github.com/repos/python-diamond/Diamond/issues/events{/number}","events_url":"https://api.github.com/repos/python-diamond/Diamond/events","assignees_url":"https://api.github.com/repos/python-diamond/Diamond/assignees{/user}","branches_url":"https://api.github.com/repos/python-diamond/Diamond/branches{/branch}","tags_url":"https://api.github.com/repos/python-diamond/Diamond/tags","blobs_url":"https://api.github.com/repos/python-diamond/Diamond/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/python-diamond/Diamond/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/python-diamond/Diamond/git/refs{/sha}","trees_url":"https://api.github.com/repos/python-diamond/Diamond/git/trees{/sha}","statuses_url":"https://api.github.com/repos/python-diamond/Diamond/statuses/{sha}","languages_url":"https://api.github.com/repos/python-diamond/Diamond/languages","stargazers_url":"https://api.github.com/repos/python-diamond/Diamond/stargazers","contributors_url":"https://api.github.com/repos/python-diamond/Diamond/contributors","subscribers_url":"https://api.github.com/repos/python-diamond/Diamond/subscribers","subscription_url":"https://api.github.com/repos/python-diamond/Diamond/subscription","commits_url":"https://api.github.com/repos/python-diamond/Diamond/commits{/sha}","git_commits_url":"https://api.github.com/repos/python-diamond/Diamond/git/commits{/sha}","comments_url":"https://api.github.com/repos/python-diamond/Diamond/comments{/number}","issue_comment_url":"https://api.github.com/repos/python-diamond/Diamond/issues/comments{/number}","contents_url":"https://api.github.com/repos/python-diamond/Diamond/contents/{+path}","compare_url":"https://api.github.com/repos/python-diamond/Diamond/compare/{base}...{head}","merges_url":"https://api.github.com/repos/python-diamond/Diamond/merges","archive_url":"https://api.github.com/repos/python-diamond/Diamond/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/python-diamond/Diamond/downloads","issues_url":"https://api.github.com/repos/python-diamond/Diamond/issues{/number}","pulls_url":"https://api.github.com/repos/python-diamond/Diamond/pulls{/number}","milestones_url":"https://api.github.com/repos/python-diamond/Diamond/milestones{/number}","notifications_url":"https://api.github.com/repos/python-diamond/Diamond/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/python-diamond/Diamond/labels{/name}","releases_url":"https://api.github.com/repos/python-diamond/Diamond/releases{/id}","deployments_url":"https://api.github.com/repos/python-diamond/Diamond/deployments","created_at":"2013-10-11T23:32:13Z","updated_at":"2016-04-22T18:22:43Z","pushed_at":"2016-04-21T22:50:24Z","git_url":"git://github.com/python-diamond/Diamond.git","ssh_url":"git@github.com:python-diamond/Diamond.git","clone_url":"https://github.com/python-diamond/Diamond.git","svn_url":"https://github.com/python-diamond/Diamond","homepage":"http://diamond.readthedocs.org/","size":3998,"stargazers_count":534,"watchers_count":534,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":283,"mirror_url":null,"open_issues_count":200,"forks":283,"open_issues":200,"watchers":534,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/python-diamond/Diamond/pulls/439"},"html":{"href":"https://github.com/python-diamond/Diamond/pull/439"},"issue":{"href":"https://api.github.com/repos/python-diamond/Diamond/issues/439"},"comments":{"href":"https://api.github.com/repos/python-diamond/Diamond/issues/439/comments"},"review_comments":{"href":"https://api.github.com/repos/python-diamond/Diamond/pulls/439/comments"},"review_comment":{"href":"https://api.github.com/repos/python-diamond/Diamond/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/python-diamond/Diamond/pulls/439/commits"},"statuses":{"href":"https://api.github.com/repos/python-diamond/Diamond/statuses/6041171d899ea1ee3878c6961aa91effa7602266"}}}}