{"action":"created","comment":{"url":"https://api.github.com/repos/farkam135/GoIV/pulls/comments/79031523","id":79031523,"diff_hunk":"@@ -842,7 +842,14 @@ private void moveOverlayUpOrDownToMatchAppraisalBox() {\n             return;\n         }\n \n-        moveOverlay(appraisalBox.getVisibility() == View.VISIBLE);\n+        if (inputBox.getVisibility() == View.VISIBLE) {\n+            boolean appraisalExpanded = appraisalBox.getVisibility() == View.VISIBLE;\n+            moveOverlay(appraisalExpanded);\n+        } else { //always move overlay down if not on input screen. Appraisal box cant be open if user is not in\n+            // input screen\n+            moveOverlay(false);\n+        }\n+","path":"app/src/main/java/com/kamron/pogoiv/Pokefly.java","position":12,"original_position":12,"commit_id":"2697692ab1dbb90315ab04aa98bb60469c3a60de","original_commit_id":"2697692ab1dbb90315ab04aa98bb60469c3a60de","user":{"login":"Blaisorblade","id":289960,"avatar_url":"https://avatars.githubusercontent.com/u/289960?v=3","gravatar_id":"","url":"https://api.github.com/users/Blaisorblade","html_url":"https://github.com/Blaisorblade","followers_url":"https://api.github.com/users/Blaisorblade/followers","following_url":"https://api.github.com/users/Blaisorblade/following{/other_user}","gists_url":"https://api.github.com/users/Blaisorblade/gists{/gist_id}","starred_url":"https://api.github.com/users/Blaisorblade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Blaisorblade/subscriptions","organizations_url":"https://api.github.com/users/Blaisorblade/orgs","repos_url":"https://api.github.com/users/Blaisorblade/repos","events_url":"https://api.github.com/users/Blaisorblade/events{/privacy}","received_events_url":"https://api.github.com/users/Blaisorblade/received_events","type":"User","site_admin":false},"body":"Nope, because `&&` is short-circuiting — the second would be tested only if the first is true. It's just more concise.","created_at":"2016-09-15T18:31:09Z","updated_at":"2016-09-15T18:31:09Z","html_url":"https://github.com/farkam135/GoIV/pull/415#discussion_r79031523","pull_request_url":"https://api.github.com/repos/farkam135/GoIV/pulls/415","_links":{"self":{"href":"https://api.github.com/repos/farkam135/GoIV/pulls/comments/79031523"},"html":{"href":"https://github.com/farkam135/GoIV/pull/415#discussion_r79031523"},"pull_request":{"href":"https://api.github.com/repos/farkam135/GoIV/pulls/415"}}},"pull_request":{"url":"https://api.github.com/repos/farkam135/GoIV/pulls/415","id":85445174,"html_url":"https://github.com/farkam135/GoIV/pull/415","diff_url":"https://github.com/farkam135/GoIV/pull/415.diff","patch_url":"https://github.com/farkam135/GoIV/pull/415.patch","issue_url":"https://api.github.com/repos/farkam135/GoIV/issues/415","number":415,"state":"open","locked":false,"title":"Overlay gravity only top if on input screen","user":{"login":"nahojjjen","id":8545451,"avatar_url":"https://avatars.githubusercontent.com/u/8545451?v=3","gravatar_id":"","url":"https://api.github.com/users/nahojjjen","html_url":"https://github.com/nahojjjen","followers_url":"https://api.github.com/users/nahojjjen/followers","following_url":"https://api.github.com/users/nahojjjen/following{/other_user}","gists_url":"https://api.github.com/users/nahojjjen/gists{/gist_id}","starred_url":"https://api.github.com/users/nahojjjen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nahojjjen/subscriptions","organizations_url":"https://api.github.com/users/nahojjjen/orgs","repos_url":"https://api.github.com/users/nahojjjen/repos","events_url":"https://api.github.com/users/nahojjjen/events{/privacy}","received_events_url":"https://api.github.com/users/nahojjjen/received_events","type":"User","site_admin":false},"body":"This commit makes the moveOverlayUpOrDownToMatchAppraisalBox method\r\nalways move the overlay down if the user is not on the input screen, as\r\nit's not possible to end up in a situation where the appraisal box is\r\nboth intended to be expanded and not exist.\r\n\r\nFixes #406 ","created_at":"2016-09-15T17:23:50Z","updated_at":"2016-09-15T18:31:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6bfc014532c58cdb9c5d26392b65fdffec45f4a8","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/farkam135/GoIV/milestones/3","html_url":"https://github.com/farkam135/GoIV/milestones/3.2.0","labels_url":"https://api.github.com/repos/farkam135/GoIV/milestones/3/labels","id":1970801,"number":3,"title":"3.2.0","description":"Potentially, about stabilization. (See #296)","creator":{"login":"Blaisorblade","id":289960,"avatar_url":"https://avatars.githubusercontent.com/u/289960?v=3","gravatar_id":"","url":"https://api.github.com/users/Blaisorblade","html_url":"https://github.com/Blaisorblade","followers_url":"https://api.github.com/users/Blaisorblade/followers","following_url":"https://api.github.com/users/Blaisorblade/following{/other_user}","gists_url":"https://api.github.com/users/Blaisorblade/gists{/gist_id}","starred_url":"https://api.github.com/users/Blaisorblade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Blaisorblade/subscriptions","organizations_url":"https://api.github.com/users/Blaisorblade/orgs","repos_url":"https://api.github.com/users/Blaisorblade/repos","events_url":"https://api.github.com/users/Blaisorblade/events{/privacy}","received_events_url":"https://api.github.com/users/Blaisorblade/received_events","type":"User","site_admin":false},"open_issues":13,"closed_issues":24,"state":"open","created_at":"2016-08-29T21:26:17Z","updated_at":"2016-09-15T17:58:17Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/farkam135/GoIV/pulls/415/commits","review_comments_url":"https://api.github.com/repos/farkam135/GoIV/pulls/415/comments","review_comment_url":"https://api.github.com/repos/farkam135/GoIV/pulls/comments{/number}","comments_url":"https://api.github.com/repos/farkam135/GoIV/issues/415/comments","statuses_url":"https://api.github.com/repos/farkam135/GoIV/statuses/2697692ab1dbb90315ab04aa98bb60469c3a60de","head":{"label":"farkam135:fixGravityIssue","ref":"fixGravityIssue","sha":"2697692ab1dbb90315ab04aa98bb60469c3a60de","user":{"login":"farkam135","id":9362480,"avatar_url":"https://avatars.githubusercontent.com/u/9362480?v=3","gravatar_id":"","url":"https://api.github.com/users/farkam135","html_url":"https://github.com/farkam135","followers_url":"https://api.github.com/users/farkam135/followers","following_url":"https://api.github.com/users/farkam135/following{/other_user}","gists_url":"https://api.github.com/users/farkam135/gists{/gist_id}","starred_url":"https://api.github.com/users/farkam135/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/farkam135/subscriptions","organizations_url":"https://api.github.com/users/farkam135/orgs","repos_url":"https://api.github.com/users/farkam135/repos","events_url":"https://api.github.com/users/farkam135/events{/privacy}","received_events_url":"https://api.github.com/users/farkam135/received_events","type":"User","site_admin":false},"repo":{"id":65773643,"name":"GoIV","full_name":"farkam135/GoIV","owner":{"login":"farkam135","id":9362480,"avatar_url":"https://avatars.githubusercontent.com/u/9362480?v=3","gravatar_id":"","url":"https://api.github.com/users/farkam135","html_url":"https://github.com/farkam135","followers_url":"https://api.github.com/users/farkam135/followers","following_url":"https://api.github.com/users/farkam135/following{/other_user}","gists_url":"https://api.github.com/users/farkam135/gists{/gist_id}","starred_url":"https://api.github.com/users/farkam135/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/farkam135/subscriptions","organizations_url":"https://api.github.com/users/farkam135/orgs","repos_url":"https://api.github.com/users/farkam135/repos","events_url":"https://api.github.com/users/farkam135/events{/privacy}","received_events_url":"https://api.github.com/users/farkam135/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/farkam135/GoIV","description":null,"fork":false,"url":"https://api.github.com/repos/farkam135/GoIV","forks_url":"https://api.github.com/repos/farkam135/GoIV/forks","keys_url":"https://api.github.com/repos/farkam135/GoIV/keys{/key_id}","collaborators_url":"https://api.github.com/repos/farkam135/GoIV/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/farkam135/GoIV/teams","hooks_url":"https://api.github.com/repos/farkam135/GoIV/hooks","issue_events_url":"https://api.github.com/repos/farkam135/GoIV/issues/events{/number}","events_url":"https://api.github.com/repos/farkam135/GoIV/events","assignees_url":"https://api.github.com/repos/farkam135/GoIV/assignees{/user}","branches_url":"https://api.github.com/repos/farkam135/GoIV/branches{/branch}","tags_url":"https://api.github.com/repos/farkam135/GoIV/tags","blobs_url":"https://api.github.com/repos/farkam135/GoIV/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/farkam135/GoIV/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/farkam135/GoIV/git/refs{/sha}","trees_url":"https://api.github.com/repos/farkam135/GoIV/git/trees{/sha}","statuses_url":"https://api.github.com/repos/farkam135/GoIV/statuses/{sha}","languages_url":"https://api.github.com/repos/farkam135/GoIV/languages","stargazers_url":"https://api.github.com/repos/farkam135/GoIV/stargazers","contributors_url":"https://api.github.com/repos/farkam135/GoIV/contributors","subscribers_url":"https://api.github.com/repos/farkam135/GoIV/subscribers","subscription_url":"https://api.github.com/repos/farkam135/GoIV/subscription","commits_url":"https://api.github.com/repos/farkam135/GoIV/commits{/sha}","git_commits_url":"https://api.github.com/repos/farkam135/GoIV/git/commits{/sha}","comments_url":"https://api.github.com/repos/farkam135/GoIV/comments{/number}","issue_comment_url":"https://api.github.com/repos/farkam135/GoIV/issues/comments{/number}","contents_url":"https://api.github.com/repos/farkam135/GoIV/contents/{+path}","compare_url":"https://api.github.com/repos/farkam135/GoIV/compare/{base}...{head}","merges_url":"https://api.github.com/repos/farkam135/GoIV/merges","archive_url":"https://api.github.com/repos/farkam135/GoIV/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/farkam135/GoIV/downloads","issues_url":"https://api.github.com/repos/farkam135/GoIV/issues{/number}","pulls_url":"https://api.github.com/repos/farkam135/GoIV/pulls{/number}","milestones_url":"https://api.github.com/repos/farkam135/GoIV/milestones{/number}","notifications_url":"https://api.github.com/repos/farkam135/GoIV/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/farkam135/GoIV/labels{/name}","releases_url":"https://api.github.com/repos/farkam135/GoIV/releases{/id}","deployments_url":"https://api.github.com/repos/farkam135/GoIV/deployments","created_at":"2016-08-16T00:15:18Z","updated_at":"2016-09-15T16:24:08Z","pushed_at":"2016-09-15T18:22:29Z","git_url":"git://github.com/farkam135/GoIV.git","ssh_url":"git@github.com:farkam135/GoIV.git","clone_url":"https://github.com/farkam135/GoIV.git","svn_url":"https://github.com/farkam135/GoIV","homepage":"https://www.reddit.com/r/goiv","size":72801,"stargazers_count":223,"watchers_count":223,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":90,"mirror_url":null,"open_issues_count":43,"forks":90,"open_issues":43,"watchers":223,"default_branch":"master"}},"base":{"label":"farkam135:master","ref":"master","sha":"a59947400b5592e52ebe860075181967b771e921","user":{"login":"farkam135","id":9362480,"avatar_url":"https://avatars.githubusercontent.com/u/9362480?v=3","gravatar_id":"","url":"https://api.github.com/users/farkam135","html_url":"https://github.com/farkam135","followers_url":"https://api.github.com/users/farkam135/followers","following_url":"https://api.github.com/users/farkam135/following{/other_user}","gists_url":"https://api.github.com/users/farkam135/gists{/gist_id}","starred_url":"https://api.github.com/users/farkam135/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/farkam135/subscriptions","organizations_url":"https://api.github.com/users/farkam135/orgs","repos_url":"https://api.github.com/users/farkam135/repos","events_url":"https://api.github.com/users/farkam135/events{/privacy}","received_events_url":"https://api.github.com/users/farkam135/received_events","type":"User","site_admin":false},"repo":{"id":65773643,"name":"GoIV","full_name":"farkam135/GoIV","owner":{"login":"farkam135","id":9362480,"avatar_url":"https://avatars.githubusercontent.com/u/9362480?v=3","gravatar_id":"","url":"https://api.github.com/users/farkam135","html_url":"https://github.com/farkam135","followers_url":"https://api.github.com/users/farkam135/followers","following_url":"https://api.github.com/users/farkam135/following{/other_user}","gists_url":"https://api.github.com/users/farkam135/gists{/gist_id}","starred_url":"https://api.github.com/users/farkam135/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/farkam135/subscriptions","organizations_url":"https://api.github.com/users/farkam135/orgs","repos_url":"https://api.github.com/users/farkam135/repos","events_url":"https://api.github.com/users/farkam135/events{/privacy}","received_events_url":"https://api.github.com/users/farkam135/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/farkam135/GoIV","description":null,"fork":false,"url":"https://api.github.com/repos/farkam135/GoIV","forks_url":"https://api.github.com/repos/farkam135/GoIV/forks","keys_url":"https://api.github.com/repos/farkam135/GoIV/keys{/key_id}","collaborators_url":"https://api.github.com/repos/farkam135/GoIV/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/farkam135/GoIV/teams","hooks_url":"https://api.github.com/repos/farkam135/GoIV/hooks","issue_events_url":"https://api.github.com/repos/farkam135/GoIV/issues/events{/number}","events_url":"https://api.github.com/repos/farkam135/GoIV/events","assignees_url":"https://api.github.com/repos/farkam135/GoIV/assignees{/user}","branches_url":"https://api.github.com/repos/farkam135/GoIV/branches{/branch}","tags_url":"https://api.github.com/repos/farkam135/GoIV/tags","blobs_url":"https://api.github.com/repos/farkam135/GoIV/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/farkam135/GoIV/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/farkam135/GoIV/git/refs{/sha}","trees_url":"https://api.github.com/repos/farkam135/GoIV/git/trees{/sha}","statuses_url":"https://api.github.com/repos/farkam135/GoIV/statuses/{sha}","languages_url":"https://api.github.com/repos/farkam135/GoIV/languages","stargazers_url":"https://api.github.com/repos/farkam135/GoIV/stargazers","contributors_url":"https://api.github.com/repos/farkam135/GoIV/contributors","subscribers_url":"https://api.github.com/repos/farkam135/GoIV/subscribers","subscription_url":"https://api.github.com/repos/farkam135/GoIV/subscription","commits_url":"https://api.github.com/repos/farkam135/GoIV/commits{/sha}","git_commits_url":"https://api.github.com/repos/farkam135/GoIV/git/commits{/sha}","comments_url":"https://api.github.com/repos/farkam135/GoIV/comments{/number}","issue_comment_url":"https://api.github.com/repos/farkam135/GoIV/issues/comments{/number}","contents_url":"https://api.github.com/repos/farkam135/GoIV/contents/{+path}","compare_url":"https://api.github.com/repos/farkam135/GoIV/compare/{base}...{head}","merges_url":"https://api.github.com/repos/farkam135/GoIV/merges","archive_url":"https://api.github.com/repos/farkam135/GoIV/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/farkam135/GoIV/downloads","issues_url":"https://api.github.com/repos/farkam135/GoIV/issues{/number}","pulls_url":"https://api.github.com/repos/farkam135/GoIV/pulls{/number}","milestones_url":"https://api.github.com/repos/farkam135/GoIV/milestones{/number}","notifications_url":"https://api.github.com/repos/farkam135/GoIV/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/farkam135/GoIV/labels{/name}","releases_url":"https://api.github.com/repos/farkam135/GoIV/releases{/id}","deployments_url":"https://api.github.com/repos/farkam135/GoIV/deployments","created_at":"2016-08-16T00:15:18Z","updated_at":"2016-09-15T16:24:08Z","pushed_at":"2016-09-15T18:22:29Z","git_url":"git://github.com/farkam135/GoIV.git","ssh_url":"git@github.com:farkam135/GoIV.git","clone_url":"https://github.com/farkam135/GoIV.git","svn_url":"https://github.com/farkam135/GoIV","homepage":"https://www.reddit.com/r/goiv","size":72801,"stargazers_count":223,"watchers_count":223,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":90,"mirror_url":null,"open_issues_count":43,"forks":90,"open_issues":43,"watchers":223,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/farkam135/GoIV/pulls/415"},"html":{"href":"https://github.com/farkam135/GoIV/pull/415"},"issue":{"href":"https://api.github.com/repos/farkam135/GoIV/issues/415"},"comments":{"href":"https://api.github.com/repos/farkam135/GoIV/issues/415/comments"},"review_comments":{"href":"https://api.github.com/repos/farkam135/GoIV/pulls/415/comments"},"review_comment":{"href":"https://api.github.com/repos/farkam135/GoIV/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/farkam135/GoIV/pulls/415/commits"},"statuses":{"href":"https://api.github.com/repos/farkam135/GoIV/statuses/2697692ab1dbb90315ab04aa98bb60469c3a60de"}}}}
{"actor":{"display_login":"Blaisorblade"}}