{"action":"created","issue":{"url":"https://api.github.com/repos/jgx65/hierfstat/issues/13","repository_url":"https://api.github.com/repos/jgx65/hierfstat","labels_url":"https://api.github.com/repos/jgx65/hierfstat/issues/13/labels{/name}","comments_url":"https://api.github.com/repos/jgx65/hierfstat/issues/13/comments","events_url":"https://api.github.com/repos/jgx65/hierfstat/issues/13/events","html_url":"https://github.com/jgx65/hierfstat/pull/13","id":136522801,"number":13,"title":"modifications to genind2hierfstat","user":{"login":"EricArcher","id":4854603,"avatar_url":"https://avatars.githubusercontent.com/u/4854603?v=3","gravatar_id":"","url":"https://api.github.com/users/EricArcher","html_url":"https://github.com/EricArcher","followers_url":"https://api.github.com/users/EricArcher/followers","following_url":"https://api.github.com/users/EricArcher/following{/other_user}","gists_url":"https://api.github.com/users/EricArcher/gists{/gist_id}","starred_url":"https://api.github.com/users/EricArcher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EricArcher/subscriptions","organizations_url":"https://api.github.com/users/EricArcher/orgs","repos_url":"https://api.github.com/users/EricArcher/repos","events_url":"https://api.github.com/users/EricArcher/events{/privacy}","received_events_url":"https://api.github.com/users/EricArcher/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-02-25T21:50:45Z","updated_at":"2016-02-29T15:54:06Z","closed_at":"2016-02-26T11:20:11Z","pull_request":{"url":"https://api.github.com/repos/jgx65/hierfstat/pulls/13","html_url":"https://github.com/jgx65/hierfstat/pull/13","diff_url":"https://github.com/jgx65/hierfstat/pull/13.diff","patch_url":"https://github.com/jgx65/hierfstat/pull/13.patch"},"body":"In converting alleles named like \"1_1\", \"3_13\", etc, the previous code was using lapply(x, as.integer) which returned NA (can't convert to integer) for all alleles, so I made some modifications in the function:\r\n\r\n- changed final conversion to convert any non-nucleotide set of loci to integers using factor conversion.\r\n- changed nucleotide conversion to convert based on factors (cleans up iterative calls to gsub)\r\n- removed error if non-integers or non-nucleotides are present since all types should be convertable now.\r\n- removed creation of 'diploid' logical (wasn't being used)\r\n- made alleles.name based on unique values rather than call to table and names of result"},"comment":{"url":"https://api.github.com/repos/jgx65/hierfstat/issues/comments/190266547","html_url":"https://github.com/jgx65/hierfstat/pull/13#issuecomment-190266547","issue_url":"https://api.github.com/repos/jgx65/hierfstat/issues/13","id":190266547,"user":{"login":"jgx65","id":7137242,"avatar_url":"https://avatars.githubusercontent.com/u/7137242?v=3","gravatar_id":"","url":"https://api.github.com/users/jgx65","html_url":"https://github.com/jgx65","followers_url":"https://api.github.com/users/jgx65/followers","following_url":"https://api.github.com/users/jgx65/following{/other_user}","gists_url":"https://api.github.com/users/jgx65/gists{/gist_id}","starred_url":"https://api.github.com/users/jgx65/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgx65/subscriptions","organizations_url":"https://api.github.com/users/jgx65/orgs","repos_url":"https://api.github.com/users/jgx65/repos","events_url":"https://api.github.com/users/jgx65/events{/privacy}","received_events_url":"https://api.github.com/users/jgx65/received_events","type":"User","site_admin":false},"created_at":"2016-02-29T15:54:06Z","updated_at":"2016-02-29T15:54:06Z","body":"Great, thanks Eric, I've added you to the contributors. "}}