{"action":"created","comment":{"url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/comments/90120970","pull_request_review_id":10643236,"id":90120970,"diff_hunk":"@@ -3035,6 +3037,40 @@ Print verbose information about the stream and the time required to perform the\n \n .sp\n .ne 2\n+.mk\n+.na\n+\\fB-o\\fR \\fIproperty\\fR=\\fIvalue\\fR\n+.ad\n+.sp .6\n+.RS 4n\n+Sets the specified property as if the command \\fBzfs set\\fR \\fIproperty\\fR=\\fIvalue\\fR was invoked at the same time the received dataset was created from the non-incremental send stream or updated from the incremental send stream.","path":"man/man8/zfs.8","position":50,"original_position":50,"commit_id":"6c0f4a594c87a83a0168a48c118ffc208102c1db","original_commit_id":"6c0f4a594c87a83a0168a48c118ffc208102c1db","user":{"login":"ahrens","id":799124,"avatar_url":"https://avatars.githubusercontent.com/u/799124?v=3","gravatar_id":"","url":"https://api.github.com/users/ahrens","html_url":"https://github.com/ahrens","followers_url":"https://api.github.com/users/ahrens/followers","following_url":"https://api.github.com/users/ahrens/following{/other_user}","gists_url":"https://api.github.com/users/ahrens/gists{/gist_id}","starred_url":"https://api.github.com/users/ahrens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahrens/subscriptions","organizations_url":"https://api.github.com/users/ahrens/orgs","repos_url":"https://api.github.com/users/ahrens/repos","events_url":"https://api.github.com/users/ahrens/events{/privacy}","received_events_url":"https://api.github.com/users/ahrens/received_events","type":"User","site_admin":false},"body":"You might add: When receiving a stream from `zfs send -R`, causes the property to be inherited by all descendant datasets, as through `zfs inherit property` was run on any descendant datasets that have this property set on the sending system.","created_at":"2016-11-29T21:43:41Z","updated_at":"2016-11-29T21:43:41Z","html_url":"https://github.com/zfsonlinux/zfs/pull/5349#discussion_r90120970","pull_request_url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/5349","_links":{"self":{"href":"https://api.github.com/repos/zfsonlinux/zfs/pulls/comments/90120970"},"html":{"href":"https://github.com/zfsonlinux/zfs/pull/5349#discussion_r90120970"},"pull_request":{"href":"https://api.github.com/repos/zfsonlinux/zfs/pulls/5349"}}},"pull_request":{"url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/5349","id":91491077,"html_url":"https://github.com/zfsonlinux/zfs/pull/5349","diff_url":"https://github.com/zfsonlinux/zfs/pull/5349.diff","patch_url":"https://github.com/zfsonlinux/zfs/pull/5349.patch","issue_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/5349","number":5349,"state":"open","locked":false,"title":"Add support for property overrides (-o|-x) in zfs receive","user":{"login":"loli10K","id":4585738,"avatar_url":"https://avatars.githubusercontent.com/u/4585738?v=3","gravatar_id":"","url":"https://api.github.com/users/loli10K","html_url":"https://github.com/loli10K","followers_url":"https://api.github.com/users/loli10K/followers","following_url":"https://api.github.com/users/loli10K/following{/other_user}","gists_url":"https://api.github.com/users/loli10K/gists{/gist_id}","starred_url":"https://api.github.com/users/loli10K/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loli10K/subscriptions","organizations_url":"https://api.github.com/users/loli10K/orgs","repos_url":"https://api.github.com/users/loli10K/repos","events_url":"https://api.github.com/users/loli10K/events{/privacy}","received_events_url":"https://api.github.com/users/loli10K/received_events","type":"User","site_admin":false},"body":"Some notes:\n- `zfs recv -l` (dataset limit)  and `zfs recv -o path/to/ds@property=value` | `-x path/to/dataset@property` were left out because ... reasons. Also they are different from the already existing implementation. We could probably do this later if we really want to.\n- the man page was ported from previous PR https://github.com/zfsonlinux/zfs/pull/1867 (almost) as it is, considering the fact is very, very much similar to the Solaris man page ... i could use some help with a different wording if needed.\n- i skipped the `zoned` part of the previous patch because i don't get it (https://github.com/zfsonlinux/zfs/pull/1867/files#diff-66bd524398bcd2ac70d90925ab6d8073R2999) ... do we really need this check when performing a receive? IIRC we don't use `zoned` in Linux (not yet), but maybe other implementations could benefit from this if done properly so i don't want to just remove it and call it a day.\n- i think we need to check which properties can be actually overridden to avoid issues up the stack ... `zfs recv -o normalization=formC tank/recv` doesn't fail with errors but doesn't set the property either: where and how would we check for this kind of properties? zfs command? libzfs?\n- `zfs recv -o property=value` just sets `property` on the received ancestor ... this works differently than Solaris, where also a zfs inherit seems to be forced on every received dataset in the hierarchy which ... i don't really like TBH. Maybe we should also provide an explicit option to do it?\n- the test script is probably a mess, i could really use some help there.\n","created_at":"2016-10-29T14:46:40Z","updated_at":"2016-11-29T21:52:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"59f9fbc4a7fc572b2850705a8a310ba3e7c7cc2a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/5349/commits","review_comments_url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/5349/comments","review_comment_url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/5349/comments","statuses_url":"https://api.github.com/repos/zfsonlinux/zfs/statuses/6c0f4a594c87a83a0168a48c118ffc208102c1db","head":{"label":"loli10K:issue-1350","ref":"issue-1350","sha":"6c0f4a594c87a83a0168a48c118ffc208102c1db","user":{"login":"loli10K","id":4585738,"avatar_url":"https://avatars.githubusercontent.com/u/4585738?v=3","gravatar_id":"","url":"https://api.github.com/users/loli10K","html_url":"https://github.com/loli10K","followers_url":"https://api.github.com/users/loli10K/followers","following_url":"https://api.github.com/users/loli10K/following{/other_user}","gists_url":"https://api.github.com/users/loli10K/gists{/gist_id}","starred_url":"https://api.github.com/users/loli10K/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loli10K/subscriptions","organizations_url":"https://api.github.com/users/loli10K/orgs","repos_url":"https://api.github.com/users/loli10K/repos","events_url":"https://api.github.com/users/loli10K/events{/privacy}","received_events_url":"https://api.github.com/users/loli10K/received_events","type":"User","site_admin":false},"repo":{"id":67621699,"name":"zfs","full_name":"loli10K/zfs","owner":{"login":"loli10K","id":4585738,"avatar_url":"https://avatars.githubusercontent.com/u/4585738?v=3","gravatar_id":"","url":"https://api.github.com/users/loli10K","html_url":"https://github.com/loli10K","followers_url":"https://api.github.com/users/loli10K/followers","following_url":"https://api.github.com/users/loli10K/following{/other_user}","gists_url":"https://api.github.com/users/loli10K/gists{/gist_id}","starred_url":"https://api.github.com/users/loli10K/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loli10K/subscriptions","organizations_url":"https://api.github.com/users/loli10K/orgs","repos_url":"https://api.github.com/users/loli10K/repos","events_url":"https://api.github.com/users/loli10K/events{/privacy}","received_events_url":"https://api.github.com/users/loli10K/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/loli10K/zfs","description":"ZFS on Linux - the official OpenZFS implementation for Linux.","fork":true,"url":"https://api.github.com/repos/loli10K/zfs","forks_url":"https://api.github.com/repos/loli10K/zfs/forks","keys_url":"https://api.github.com/repos/loli10K/zfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/loli10K/zfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/loli10K/zfs/teams","hooks_url":"https://api.github.com/repos/loli10K/zfs/hooks","issue_events_url":"https://api.github.com/repos/loli10K/zfs/issues/events{/number}","events_url":"https://api.github.com/repos/loli10K/zfs/events","assignees_url":"https://api.github.com/repos/loli10K/zfs/assignees{/user}","branches_url":"https://api.github.com/repos/loli10K/zfs/branches{/branch}","tags_url":"https://api.github.com/repos/loli10K/zfs/tags","blobs_url":"https://api.github.com/repos/loli10K/zfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/loli10K/zfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/loli10K/zfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/loli10K/zfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/loli10K/zfs/statuses/{sha}","languages_url":"https://api.github.com/repos/loli10K/zfs/languages","stargazers_url":"https://api.github.com/repos/loli10K/zfs/stargazers","contributors_url":"https://api.github.com/repos/loli10K/zfs/contributors","subscribers_url":"https://api.github.com/repos/loli10K/zfs/subscribers","subscription_url":"https://api.github.com/repos/loli10K/zfs/subscription","commits_url":"https://api.github.com/repos/loli10K/zfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/loli10K/zfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/loli10K/zfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/loli10K/zfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/loli10K/zfs/contents/{+path}","compare_url":"https://api.github.com/repos/loli10K/zfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/loli10K/zfs/merges","archive_url":"https://api.github.com/repos/loli10K/zfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/loli10K/zfs/downloads","issues_url":"https://api.github.com/repos/loli10K/zfs/issues{/number}","pulls_url":"https://api.github.com/repos/loli10K/zfs/pulls{/number}","milestones_url":"https://api.github.com/repos/loli10K/zfs/milestones{/number}","notifications_url":"https://api.github.com/repos/loli10K/zfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/loli10K/zfs/labels{/name}","releases_url":"https://api.github.com/repos/loli10K/zfs/releases{/id}","deployments_url":"https://api.github.com/repos/loli10K/zfs/deployments","created_at":"2016-09-07T15:51:11Z","updated_at":"2016-09-07T15:51:18Z","pushed_at":"2016-11-26T11:26:03Z","git_url":"git://github.com/loli10K/zfs.git","ssh_url":"git@github.com:loli10K/zfs.git","clone_url":"https://github.com/loli10K/zfs.git","svn_url":"https://github.com/loli10K/zfs","homepage":"http://zfsonlinux.org/","size":33908,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zfsonlinux:master","ref":"master","sha":"0df15db98f185c948239c236c9e51d7ce14adb71","user":{"login":"zfsonlinux","id":575083,"avatar_url":"https://avatars.githubusercontent.com/u/575083?v=3","gravatar_id":"","url":"https://api.github.com/users/zfsonlinux","html_url":"https://github.com/zfsonlinux","followers_url":"https://api.github.com/users/zfsonlinux/followers","following_url":"https://api.github.com/users/zfsonlinux/following{/other_user}","gists_url":"https://api.github.com/users/zfsonlinux/gists{/gist_id}","starred_url":"https://api.github.com/users/zfsonlinux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zfsonlinux/subscriptions","organizations_url":"https://api.github.com/users/zfsonlinux/orgs","repos_url":"https://api.github.com/users/zfsonlinux/repos","events_url":"https://api.github.com/users/zfsonlinux/events{/privacy}","received_events_url":"https://api.github.com/users/zfsonlinux/received_events","type":"Organization","site_admin":false},"repo":{"id":437011,"name":"zfs","full_name":"zfsonlinux/zfs","owner":{"login":"zfsonlinux","id":575083,"avatar_url":"https://avatars.githubusercontent.com/u/575083?v=3","gravatar_id":"","url":"https://api.github.com/users/zfsonlinux","html_url":"https://github.com/zfsonlinux","followers_url":"https://api.github.com/users/zfsonlinux/followers","following_url":"https://api.github.com/users/zfsonlinux/following{/other_user}","gists_url":"https://api.github.com/users/zfsonlinux/gists{/gist_id}","starred_url":"https://api.github.com/users/zfsonlinux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zfsonlinux/subscriptions","organizations_url":"https://api.github.com/users/zfsonlinux/orgs","repos_url":"https://api.github.com/users/zfsonlinux/repos","events_url":"https://api.github.com/users/zfsonlinux/events{/privacy}","received_events_url":"https://api.github.com/users/zfsonlinux/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zfsonlinux/zfs","description":"ZFS on Linux - the official OpenZFS implementation for Linux.","fork":false,"url":"https://api.github.com/repos/zfsonlinux/zfs","forks_url":"https://api.github.com/repos/zfsonlinux/zfs/forks","keys_url":"https://api.github.com/repos/zfsonlinux/zfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zfsonlinux/zfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zfsonlinux/zfs/teams","hooks_url":"https://api.github.com/repos/zfsonlinux/zfs/hooks","issue_events_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/events{/number}","events_url":"https://api.github.com/repos/zfsonlinux/zfs/events","assignees_url":"https://api.github.com/repos/zfsonlinux/zfs/assignees{/user}","branches_url":"https://api.github.com/repos/zfsonlinux/zfs/branches{/branch}","tags_url":"https://api.github.com/repos/zfsonlinux/zfs/tags","blobs_url":"https://api.github.com/repos/zfsonlinux/zfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zfsonlinux/zfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zfsonlinux/zfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/zfsonlinux/zfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zfsonlinux/zfs/statuses/{sha}","languages_url":"https://api.github.com/repos/zfsonlinux/zfs/languages","stargazers_url":"https://api.github.com/repos/zfsonlinux/zfs/stargazers","contributors_url":"https://api.github.com/repos/zfsonlinux/zfs/contributors","subscribers_url":"https://api.github.com/repos/zfsonlinux/zfs/subscribers","subscription_url":"https://api.github.com/repos/zfsonlinux/zfs/subscription","commits_url":"https://api.github.com/repos/zfsonlinux/zfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/zfsonlinux/zfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/zfsonlinux/zfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/zfsonlinux/zfs/contents/{+path}","compare_url":"https://api.github.com/repos/zfsonlinux/zfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zfsonlinux/zfs/merges","archive_url":"https://api.github.com/repos/zfsonlinux/zfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zfsonlinux/zfs/downloads","issues_url":"https://api.github.com/repos/zfsonlinux/zfs/issues{/number}","pulls_url":"https://api.github.com/repos/zfsonlinux/zfs/pulls{/number}","milestones_url":"https://api.github.com/repos/zfsonlinux/zfs/milestones{/number}","notifications_url":"https://api.github.com/repos/zfsonlinux/zfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zfsonlinux/zfs/labels{/name}","releases_url":"https://api.github.com/repos/zfsonlinux/zfs/releases{/id}","deployments_url":"https://api.github.com/repos/zfsonlinux/zfs/deployments","created_at":"2009-12-14T20:20:34Z","updated_at":"2016-11-29T07:37:35Z","pushed_at":"2016-11-29T21:47:06Z","git_url":"git://github.com/zfsonlinux/zfs.git","ssh_url":"git@github.com:zfsonlinux/zfs.git","clone_url":"https://github.com/zfsonlinux/zfs.git","svn_url":"https://github.com/zfsonlinux/zfs","homepage":"http://zfsonlinux.org/","size":62363,"stargazers_count":2127,"watchers_count":2127,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":530,"mirror_url":null,"open_issues_count":856,"forks":530,"open_issues":856,"watchers":2127,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zfsonlinux/zfs/pulls/5349"},"html":{"href":"https://github.com/zfsonlinux/zfs/pull/5349"},"issue":{"href":"https://api.github.com/repos/zfsonlinux/zfs/issues/5349"},"comments":{"href":"https://api.github.com/repos/zfsonlinux/zfs/issues/5349/comments"},"review_comments":{"href":"https://api.github.com/repos/zfsonlinux/zfs/pulls/5349/comments"},"review_comment":{"href":"https://api.github.com/repos/zfsonlinux/zfs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zfsonlinux/zfs/pulls/5349/commits"},"statuses":{"href":"https://api.github.com/repos/zfsonlinux/zfs/statuses/6c0f4a594c87a83a0168a48c118ffc208102c1db"}}}}
{"actor":{"display_login":"ahrens"}}