{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments/85652141","pull_request_review_id":6357452,"id":85652141,"diff_hunk":"@@ -24,66 +24,117 @@\n import org.elasticsearch.common.io.stream.StreamOutput;\n \n import java.io.IOException;\n-import java.util.Locale;\n+import java.util.Objects;\n \n /**\n- * The type of a script, more specifically where it gets loaded from:\n- * - provided dynamically at request time\n- * - loaded from an index\n- * - loaded from file\n+ * ScriptType represents the way a script is stored and retrieved from the {@link ScriptService}.\n+ * It's also used to by {@link ScriptSettings} and {@link ScriptModes} to determine whether or not\n+ * a {@link Script} is allowed to be executed based on both default and user-defined settings.\n  */\n public enum ScriptType {\n \n-    INLINE(0, \"inline\", \"inline\", false),\n-    STORED(1, \"id\", \"stored\", false),\n-    FILE(2, \"file\", \"file\", true);\n+    /**\n+     * INLINE scripts are specified in numerous queries and compiled on-the-fly.\n+     * They will be cached based on the lang and code of the script.\n+     * They are turned off by default for security purposes.","path":"core/src/main/java/org/elasticsearch/script/ScriptType.java","position":24,"original_position":24,"commit_id":"c6aea819d14becb0241c303bdff7fa95dc819f73","original_commit_id":"c6aea819d14becb0241c303bdff7fa95dc819f73","user":{"login":"nik9000","id":215970,"avatar_url":"https://avatars.githubusercontent.com/u/215970?v=3","gravatar_id":"","url":"https://api.github.com/users/nik9000","html_url":"https://github.com/nik9000","followers_url":"https://api.github.com/users/nik9000/followers","following_url":"https://api.github.com/users/nik9000/following{/other_user}","gists_url":"https://api.github.com/users/nik9000/gists{/gist_id}","starred_url":"https://api.github.com/users/nik9000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nik9000/subscriptions","organizations_url":"https://api.github.com/users/nik9000/orgs","repos_url":"https://api.github.com/users/nik9000/repos","events_url":"https://api.github.com/users/nik9000/events{/privacy}","received_events_url":"https://api.github.com/users/nik9000/received_events","type":"User","site_admin":false},"body":"They are turned off for groovy by default because it is insecure but they are on by default for painless and mustache.","created_at":"2016-10-30T02:58:45Z","updated_at":"2016-10-30T02:58:45Z","html_url":"https://github.com/elastic/elasticsearch/pull/21179#discussion_r85652141","pull_request_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/21179","_links":{"self":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments/85652141"},"html":{"href":"https://github.com/elastic/elasticsearch/pull/21179#discussion_r85652141"},"pull_request":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/21179"}}},"pull_request":{"url":"https://api.github.com/repos/elastic/elasticsearch/pulls/21179","id":91427195,"html_url":"https://github.com/elastic/elasticsearch/pull/21179","diff_url":"https://github.com/elastic/elasticsearch/pull/21179.diff","patch_url":"https://github.com/elastic/elasticsearch/pull/21179.patch","issue_url":"https://api.github.com/repos/elastic/elasticsearch/issues/21179","number":21179,"state":"open","locked":false,"title":"Cleanup ScriptType","user":{"login":"jdconrad","id":2126764,"avatar_url":"https://avatars.githubusercontent.com/u/2126764?v=3","gravatar_id":"","url":"https://api.github.com/users/jdconrad","html_url":"https://github.com/jdconrad","followers_url":"https://api.github.com/users/jdconrad/followers","following_url":"https://api.github.com/users/jdconrad/following{/other_user}","gists_url":"https://api.github.com/users/jdconrad/gists{/gist_id}","starred_url":"https://api.github.com/users/jdconrad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdconrad/subscriptions","organizations_url":"https://api.github.com/users/jdconrad/orgs","repos_url":"https://api.github.com/users/jdconrad/repos","events_url":"https://api.github.com/users/jdconrad/events{/privacy}","received_events_url":"https://api.github.com/users/jdconrad/received_events","type":"User","site_admin":false},"body":"Refactored ScriptType to clean up some of the variable and method names.  Added more documentation.  Deprecated the 'in' ParseField in favor of 'stored' to match the indexed scripts being replaced by stored scripts.","created_at":"2016-10-28T18:16:30Z","updated_at":"2016-10-30T02:58:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cbb8c13dea6e1415b528d874f75a6543df5db599","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/21179/commits","review_comments_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/21179/comments","review_comment_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/elasticsearch/issues/21179/comments","statuses_url":"https://api.github.com/repos/elastic/elasticsearch/statuses/c6aea819d14becb0241c303bdff7fa95dc819f73","head":{"label":"jdconrad:splittypes","ref":"splittypes","sha":"c6aea819d14becb0241c303bdff7fa95dc819f73","user":{"login":"jdconrad","id":2126764,"avatar_url":"https://avatars.githubusercontent.com/u/2126764?v=3","gravatar_id":"","url":"https://api.github.com/users/jdconrad","html_url":"https://github.com/jdconrad","followers_url":"https://api.github.com/users/jdconrad/followers","following_url":"https://api.github.com/users/jdconrad/following{/other_user}","gists_url":"https://api.github.com/users/jdconrad/gists{/gist_id}","starred_url":"https://api.github.com/users/jdconrad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdconrad/subscriptions","organizations_url":"https://api.github.com/users/jdconrad/orgs","repos_url":"https://api.github.com/users/jdconrad/repos","events_url":"https://api.github.com/users/jdconrad/events{/privacy}","received_events_url":"https://api.github.com/users/jdconrad/received_events","type":"User","site_admin":false},"repo":{"id":33491776,"name":"elasticsearch","full_name":"jdconrad/elasticsearch","owner":{"login":"jdconrad","id":2126764,"avatar_url":"https://avatars.githubusercontent.com/u/2126764?v=3","gravatar_id":"","url":"https://api.github.com/users/jdconrad","html_url":"https://github.com/jdconrad","followers_url":"https://api.github.com/users/jdconrad/followers","following_url":"https://api.github.com/users/jdconrad/following{/other_user}","gists_url":"https://api.github.com/users/jdconrad/gists{/gist_id}","starred_url":"https://api.github.com/users/jdconrad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdconrad/subscriptions","organizations_url":"https://api.github.com/users/jdconrad/orgs","repos_url":"https://api.github.com/users/jdconrad/repos","events_url":"https://api.github.com/users/jdconrad/events{/privacy}","received_events_url":"https://api.github.com/users/jdconrad/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jdconrad/elasticsearch","description":"Open Source, Distributed, RESTful Search Engine","fork":true,"url":"https://api.github.com/repos/jdconrad/elasticsearch","forks_url":"https://api.github.com/repos/jdconrad/elasticsearch/forks","keys_url":"https://api.github.com/repos/jdconrad/elasticsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jdconrad/elasticsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jdconrad/elasticsearch/teams","hooks_url":"https://api.github.com/repos/jdconrad/elasticsearch/hooks","issue_events_url":"https://api.github.com/repos/jdconrad/elasticsearch/issues/events{/number}","events_url":"https://api.github.com/repos/jdconrad/elasticsearch/events","assignees_url":"https://api.github.com/repos/jdconrad/elasticsearch/assignees{/user}","branches_url":"https://api.github.com/repos/jdconrad/elasticsearch/branches{/branch}","tags_url":"https://api.github.com/repos/jdconrad/elasticsearch/tags","blobs_url":"https://api.github.com/repos/jdconrad/elasticsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jdconrad/elasticsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jdconrad/elasticsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/jdconrad/elasticsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jdconrad/elasticsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/jdconrad/elasticsearch/languages","stargazers_url":"https://api.github.com/repos/jdconrad/elasticsearch/stargazers","contributors_url":"https://api.github.com/repos/jdconrad/elasticsearch/contributors","subscribers_url":"https://api.github.com/repos/jdconrad/elasticsearch/subscribers","subscription_url":"https://api.github.com/repos/jdconrad/elasticsearch/subscription","commits_url":"https://api.github.com/repos/jdconrad/elasticsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/jdconrad/elasticsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/jdconrad/elasticsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/jdconrad/elasticsearch/issues/comments{/number}","contents_url":"https://api.github.com/repos/jdconrad/elasticsearch/contents/{+path}","compare_url":"https://api.github.com/repos/jdconrad/elasticsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jdconrad/elasticsearch/merges","archive_url":"https://api.github.com/repos/jdconrad/elasticsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jdconrad/elasticsearch/downloads","issues_url":"https://api.github.com/repos/jdconrad/elasticsearch/issues{/number}","pulls_url":"https://api.github.com/repos/jdconrad/elasticsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/jdconrad/elasticsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/jdconrad/elasticsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jdconrad/elasticsearch/labels{/name}","releases_url":"https://api.github.com/repos/jdconrad/elasticsearch/releases{/id}","deployments_url":"https://api.github.com/repos/jdconrad/elasticsearch/deployments","created_at":"2015-04-06T16:19:42Z","updated_at":"2016-01-19T17:54:08Z","pushed_at":"2016-10-28T18:13:01Z","git_url":"git://github.com/jdconrad/elasticsearch.git","ssh_url":"git@github.com:jdconrad/elasticsearch.git","clone_url":"https://github.com/jdconrad/elasticsearch.git","svn_url":"https://github.com/jdconrad/elasticsearch","homepage":"http://elasticsearch.org","size":224440,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"267a7b427b044efada3fb4c94aa1c495b83842dc","user":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":507775,"name":"elasticsearch","full_name":"elastic/elasticsearch","owner":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/elasticsearch","description":"Open Source, Distributed, RESTful Search Engine","fork":false,"url":"https://api.github.com/repos/elastic/elasticsearch","forks_url":"https://api.github.com/repos/elastic/elasticsearch/forks","keys_url":"https://api.github.com/repos/elastic/elasticsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/elasticsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/elasticsearch/teams","hooks_url":"https://api.github.com/repos/elastic/elasticsearch/hooks","issue_events_url":"https://api.github.com/repos/elastic/elasticsearch/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/elasticsearch/events","assignees_url":"https://api.github.com/repos/elastic/elasticsearch/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/elasticsearch/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/elasticsearch/tags","blobs_url":"https://api.github.com/repos/elastic/elasticsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/elasticsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/elasticsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/elasticsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/elasticsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/elasticsearch/languages","stargazers_url":"https://api.github.com/repos/elastic/elasticsearch/stargazers","contributors_url":"https://api.github.com/repos/elastic/elasticsearch/contributors","subscribers_url":"https://api.github.com/repos/elastic/elasticsearch/subscribers","subscription_url":"https://api.github.com/repos/elastic/elasticsearch/subscription","commits_url":"https://api.github.com/repos/elastic/elasticsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/elasticsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/elasticsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/elasticsearch/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/elasticsearch/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/elasticsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/elasticsearch/merges","archive_url":"https://api.github.com/repos/elastic/elasticsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/elasticsearch/downloads","issues_url":"https://api.github.com/repos/elastic/elasticsearch/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/elasticsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/elasticsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/elasticsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/elasticsearch/labels{/name}","releases_url":"https://api.github.com/repos/elastic/elasticsearch/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/elasticsearch/deployments","created_at":"2010-02-08T13:20:56Z","updated_at":"2016-10-30T02:30:39Z","pushed_at":"2016-10-30T02:33:22Z","git_url":"git://github.com/elastic/elasticsearch.git","ssh_url":"git@github.com:elastic/elasticsearch.git","clone_url":"https://github.com/elastic/elasticsearch.git","svn_url":"https://github.com/elastic/elasticsearch","homepage":"https://www.elastic.co/products/elasticsearch","size":365773,"stargazers_count":19056,"watchers_count":19056,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6515,"mirror_url":null,"open_issues_count":1152,"forks":6515,"open_issues":1152,"watchers":19056,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/21179"},"html":{"href":"https://github.com/elastic/elasticsearch/pull/21179"},"issue":{"href":"https://api.github.com/repos/elastic/elasticsearch/issues/21179"},"comments":{"href":"https://api.github.com/repos/elastic/elasticsearch/issues/21179/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/21179/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/21179/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/elasticsearch/statuses/c6aea819d14becb0241c303bdff7fa95dc819f73"}}}}
{"actor":{"display_login":"nik9000"}}