{"action":"closed","issue":{"url":"https://api.github.com/repos/clappr/clappr/issues/1068","repository_url":"https://api.github.com/repos/clappr/clappr","labels_url":"https://api.github.com/repos/clappr/clappr/issues/1068/labels{/name}","comments_url":"https://api.github.com/repos/clappr/clappr/issues/1068/comments","events_url":"https://api.github.com/repos/clappr/clappr/issues/1068/events","html_url":"https://github.com/clappr/clappr/issues/1068","id":164088659,"number":1068,"title":"Clappr hlsjs options are being overridden","user":{"login":"shaharmor","id":10861920,"avatar_url":"https://avatars.githubusercontent.com/u/10861920?v=3","gravatar_id":"","url":"https://api.github.com/users/shaharmor","html_url":"https://github.com/shaharmor","followers_url":"https://api.github.com/users/shaharmor/followers","following_url":"https://api.github.com/users/shaharmor/following{/other_user}","gists_url":"https://api.github.com/users/shaharmor/gists{/gist_id}","starred_url":"https://api.github.com/users/shaharmor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shaharmor/subscriptions","organizations_url":"https://api.github.com/users/shaharmor/orgs","repos_url":"https://api.github.com/users/shaharmor/repos","events_url":"https://api.github.com/users/shaharmor/events{/privacy}","received_events_url":"https://api.github.com/users/shaharmor/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/clappr/clappr/labels/bug","name":"bug","color":"fc2929"}],"state":"closed","locked":false,"assignee":{"login":"towerz","id":989801,"avatar_url":"https://avatars.githubusercontent.com/u/989801?v=3","gravatar_id":"","url":"https://api.github.com/users/towerz","html_url":"https://github.com/towerz","followers_url":"https://api.github.com/users/towerz/followers","following_url":"https://api.github.com/users/towerz/following{/other_user}","gists_url":"https://api.github.com/users/towerz/gists{/gist_id}","starred_url":"https://api.github.com/users/towerz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/towerz/subscriptions","organizations_url":"https://api.github.com/users/towerz/orgs","repos_url":"https://api.github.com/users/towerz/repos","events_url":"https://api.github.com/users/towerz/events{/privacy}","received_events_url":"https://api.github.com/users/towerz/received_events","type":"User","site_admin":false},"assignees":[{"login":"towerz","id":989801,"avatar_url":"https://avatars.githubusercontent.com/u/989801?v=3","gravatar_id":"","url":"https://api.github.com/users/towerz","html_url":"https://github.com/towerz","followers_url":"https://api.github.com/users/towerz/followers","following_url":"https://api.github.com/users/towerz/following{/other_user}","gists_url":"https://api.github.com/users/towerz/gists{/gist_id}","starred_url":"https://api.github.com/users/towerz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/towerz/subscriptions","organizations_url":"https://api.github.com/users/towerz/orgs","repos_url":"https://api.github.com/users/towerz/repos","events_url":"https://api.github.com/users/towerz/events{/privacy}","received_events_url":"https://api.github.com/users/towerz/received_events","type":"User","site_admin":false}],"milestone":null,"comments":25,"created_at":"2016-07-06T14:25:49Z","updated_at":"2016-07-28T22:00:25Z","closed_at":"2016-07-28T22:00:25Z","body":"**Clappr Version**: 0.2.58\r\n\r\n**Steps to reproduce**:\r\n* try to override hlsjs config like this:\r\n```js\r\nvar player = new Clappr.Player({\r\n  source: '' // w/e  \r\n  hlsjsConfig: {\r\n    debug: true // or any other config\r\n  },\r\n  autoPlay: false // if this is true, _setupHls will be called before overriding the config so it will still work\r\n});\r\n```\r\n* see that hls.js logs are not enabled\r\n\r\nDid you try to reproduce this issue at http://cdn.clappr.io/? no\r\n\r\nThe issue is because after this commit: https://github.com/clappr/clappr/commit/88c87836da24a4af7f378cd9dd736ef20f358bb5 the config was changed from `hlsjsConfig` to `playback`, which in its own OK, but this line: https://github.com/clappr/clappr/blob/master/src/components/container_factory/container_factory.js#L57 \r\noverrides the `options` object **by ref** and changes its `playback` property which takes over all the config...\r\n\r\nNote: this will not happen when autoplay is true because this line: https://github.com/clappr/clappr/blob/0dc74b6dc9f39d42c887f11e8347eb7927a6ba08/src/playbacks/hls/hls.js#L52\r\nwill make it play before overriding the config\r\n"}}
{"actor":{"display_login":"towerz"}}