{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/comments/51774827","id":51774827,"diff_hunk":"@@ -20,6 +20,7 @@\n #define RT_ERROR_MSG_UNUSED_ENTRY\n #endif\n \n+// NOTE: The VBSERR macros should not be changed due to legacy dependencies outside of Chakra.","path":"lib/Parser/rterrors.h","position":4,"original_position":4,"commit_id":"5f7e0f39b7d91f5ca5467fd5e6de96273855800f","original_commit_id":"5f7e0f39b7d91f5ca5467fd5e6de96273855800f","user":{"login":"dilijev","id":494055,"avatar_url":"https://avatars.githubusercontent.com/u/494055?v=3","gravatar_id":"","url":"https://api.github.com/users/dilijev","html_url":"https://github.com/dilijev","followers_url":"https://api.github.com/users/dilijev/followers","following_url":"https://api.github.com/users/dilijev/following{/other_user}","gists_url":"https://api.github.com/users/dilijev/gists{/gist_id}","starred_url":"https://api.github.com/users/dilijev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dilijev/subscriptions","organizations_url":"https://api.github.com/users/dilijev/orgs","repos_url":"https://api.github.com/users/dilijev/repos","events_url":"https://api.github.com/users/dilijev/events{/privacy}","received_events_url":"https://api.github.com/users/dilijev/received_events","type":"User","site_admin":false},"body":"Changing the naming is really the only issue here.\r\n\r\nWhat should definitely not be changed is the definitions (numbers, messages, and so on). They are depended upon in a way which is definitely too risky to change.\r\n\r\nOther projects with a dependency on the actual names as they are is less of a concern (since this file itself is apparently only referenced within Chakra), but it would be nice to keep the names as they are for quality of life when they go looking through the code (including our code) for instances of those macros named as they are.","created_at":"2016-02-03T19:38:35Z","updated_at":"2016-02-03T19:38:35Z","html_url":"https://github.com/Microsoft/ChakraCore/pull/214#discussion_r51774827","pull_request_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/214","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/comments/51774827"},"html":{"href":"https://github.com/Microsoft/ChakraCore/pull/214#discussion_r51774827"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/214"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/214","id":57433657,"html_url":"https://github.com/Microsoft/ChakraCore/pull/214","diff_url":"https://github.com/Microsoft/ChakraCore/pull/214.diff","patch_url":"https://github.com/Microsoft/ChakraCore/pull/214.patch","issue_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/214","number":214,"state":"open","locked":false,"title":"Include a note about why VBSERR macros in lib/Parser/rterrors.h should not be \"cleaned up\".","user":{"login":"dilijev","id":494055,"avatar_url":"https://avatars.githubusercontent.com/u/494055?v=3","gravatar_id":"","url":"https://api.github.com/users/dilijev","html_url":"https://github.com/dilijev","followers_url":"https://api.github.com/users/dilijev/followers","following_url":"https://api.github.com/users/dilijev/following{/other_user}","gists_url":"https://api.github.com/users/dilijev/gists{/gist_id}","starred_url":"https://api.github.com/users/dilijev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dilijev/subscriptions","organizations_url":"https://api.github.com/users/dilijev/orgs","repos_url":"https://api.github.com/users/dilijev/repos","events_url":"https://api.github.com/users/dilijev/events{/privacy}","received_events_url":"https://api.github.com/users/dilijev/received_events","type":"User","site_admin":false},"body":"Investigation revealed that these values are depended-on as-is in other projects outside of Chakra, so we should not change their names or values.\r\n\r\nAdded a note to remind future maintainers about this.\r\n\r\nReviewed by @tcare\r\n\r\n<!-- Reviewable:start -->\r\n[<img src=\"https://reviewable.io/review_button.svg\" height=\"40\" alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/microsoft/chakracore/214)\r\n<!-- Reviewable:end -->\r\n","created_at":"2016-01-27T22:30:18Z","updated_at":"2016-02-03T19:38:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4f86bd7a65fa1fbfb4ff714ec3f9c6b1214b5e9b","assignee":{"login":"tcare","id":707073,"avatar_url":"https://avatars.githubusercontent.com/u/707073?v=3","gravatar_id":"","url":"https://api.github.com/users/tcare","html_url":"https://github.com/tcare","followers_url":"https://api.github.com/users/tcare/followers","following_url":"https://api.github.com/users/tcare/following{/other_user}","gists_url":"https://api.github.com/users/tcare/gists{/gist_id}","starred_url":"https://api.github.com/users/tcare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tcare/subscriptions","organizations_url":"https://api.github.com/users/tcare/orgs","repos_url":"https://api.github.com/users/tcare/repos","events_url":"https://api.github.com/users/tcare/events{/privacy}","received_events_url":"https://api.github.com/users/tcare/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/214/commits","review_comments_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/214/comments","review_comment_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/214/comments","statuses_url":"https://api.github.com/repos/Microsoft/ChakraCore/statuses/5f7e0f39b7d91f5ca5467fd5e6de96273855800f","head":{"label":"dilijev:clean","ref":"clean","sha":"5f7e0f39b7d91f5ca5467fd5e6de96273855800f","user":{"login":"dilijev","id":494055,"avatar_url":"https://avatars.githubusercontent.com/u/494055?v=3","gravatar_id":"","url":"https://api.github.com/users/dilijev","html_url":"https://github.com/dilijev","followers_url":"https://api.github.com/users/dilijev/followers","following_url":"https://api.github.com/users/dilijev/following{/other_user}","gists_url":"https://api.github.com/users/dilijev/gists{/gist_id}","starred_url":"https://api.github.com/users/dilijev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dilijev/subscriptions","organizations_url":"https://api.github.com/users/dilijev/orgs","repos_url":"https://api.github.com/users/dilijev/repos","events_url":"https://api.github.com/users/dilijev/events{/privacy}","received_events_url":"https://api.github.com/users/dilijev/received_events","type":"User","site_admin":false},"repo":{"id":49591788,"name":"ChakraCore","full_name":"dilijev/ChakraCore","owner":{"login":"dilijev","id":494055,"avatar_url":"https://avatars.githubusercontent.com/u/494055?v=3","gravatar_id":"","url":"https://api.github.com/users/dilijev","html_url":"https://github.com/dilijev","followers_url":"https://api.github.com/users/dilijev/followers","following_url":"https://api.github.com/users/dilijev/following{/other_user}","gists_url":"https://api.github.com/users/dilijev/gists{/gist_id}","starred_url":"https://api.github.com/users/dilijev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dilijev/subscriptions","organizations_url":"https://api.github.com/users/dilijev/orgs","repos_url":"https://api.github.com/users/dilijev/repos","events_url":"https://api.github.com/users/dilijev/events{/privacy}","received_events_url":"https://api.github.com/users/dilijev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dilijev/ChakraCore","description":"ChakraCore is the core part of the Chakra Javascript engine that powers Microsoft Edge","fork":true,"url":"https://api.github.com/repos/dilijev/ChakraCore","forks_url":"https://api.github.com/repos/dilijev/ChakraCore/forks","keys_url":"https://api.github.com/repos/dilijev/ChakraCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dilijev/ChakraCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dilijev/ChakraCore/teams","hooks_url":"https://api.github.com/repos/dilijev/ChakraCore/hooks","issue_events_url":"https://api.github.com/repos/dilijev/ChakraCore/issues/events{/number}","events_url":"https://api.github.com/repos/dilijev/ChakraCore/events","assignees_url":"https://api.github.com/repos/dilijev/ChakraCore/assignees{/user}","branches_url":"https://api.github.com/repos/dilijev/ChakraCore/branches{/branch}","tags_url":"https://api.github.com/repos/dilijev/ChakraCore/tags","blobs_url":"https://api.github.com/repos/dilijev/ChakraCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dilijev/ChakraCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dilijev/ChakraCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/dilijev/ChakraCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dilijev/ChakraCore/statuses/{sha}","languages_url":"https://api.github.com/repos/dilijev/ChakraCore/languages","stargazers_url":"https://api.github.com/repos/dilijev/ChakraCore/stargazers","contributors_url":"https://api.github.com/repos/dilijev/ChakraCore/contributors","subscribers_url":"https://api.github.com/repos/dilijev/ChakraCore/subscribers","subscription_url":"https://api.github.com/repos/dilijev/ChakraCore/subscription","commits_url":"https://api.github.com/repos/dilijev/ChakraCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/dilijev/ChakraCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/dilijev/ChakraCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/dilijev/ChakraCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/dilijev/ChakraCore/contents/{+path}","compare_url":"https://api.github.com/repos/dilijev/ChakraCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dilijev/ChakraCore/merges","archive_url":"https://api.github.com/repos/dilijev/ChakraCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dilijev/ChakraCore/downloads","issues_url":"https://api.github.com/repos/dilijev/ChakraCore/issues{/number}","pulls_url":"https://api.github.com/repos/dilijev/ChakraCore/pulls{/number}","milestones_url":"https://api.github.com/repos/dilijev/ChakraCore/milestones{/number}","notifications_url":"https://api.github.com/repos/dilijev/ChakraCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dilijev/ChakraCore/labels{/name}","releases_url":"https://api.github.com/repos/dilijev/ChakraCore/releases{/id}","deployments_url":"https://api.github.com/repos/dilijev/ChakraCore/deployments","created_at":"2016-01-13T18:02:44Z","updated_at":"2016-01-14T00:12:11Z","pushed_at":"2016-02-03T02:40:53Z","git_url":"git://github.com/dilijev/ChakraCore.git","ssh_url":"git@github.com:dilijev/ChakraCore.git","clone_url":"https://github.com/dilijev/ChakraCore.git","svn_url":"https://github.com/dilijev/ChakraCore","homepage":null,"size":16927,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"e98a0a589ba9113d5bf7d5e5334aeefce19c7f2e","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":49086513,"name":"ChakraCore","full_name":"Microsoft/ChakraCore","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/ChakraCore","description":"ChakraCore is the core part of the Chakra Javascript engine that powers Microsoft Edge","fork":false,"url":"https://api.github.com/repos/Microsoft/ChakraCore","forks_url":"https://api.github.com/repos/Microsoft/ChakraCore/forks","keys_url":"https://api.github.com/repos/Microsoft/ChakraCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/ChakraCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/ChakraCore/teams","hooks_url":"https://api.github.com/repos/Microsoft/ChakraCore/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/ChakraCore/events","assignees_url":"https://api.github.com/repos/Microsoft/ChakraCore/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/ChakraCore/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/ChakraCore/tags","blobs_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/ChakraCore/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/ChakraCore/languages","stargazers_url":"https://api.github.com/repos/Microsoft/ChakraCore/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/ChakraCore/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/ChakraCore/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/ChakraCore/subscription","commits_url":"https://api.github.com/repos/Microsoft/ChakraCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/ChakraCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/ChakraCore/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/ChakraCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/ChakraCore/merges","archive_url":"https://api.github.com/repos/Microsoft/ChakraCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/ChakraCore/downloads","issues_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/ChakraCore/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/ChakraCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/ChakraCore/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/ChakraCore/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/ChakraCore/deployments","created_at":"2016-01-05T19:05:31Z","updated_at":"2016-02-03T18:40:11Z","pushed_at":"2016-02-03T19:17:58Z","git_url":"git://github.com/Microsoft/ChakraCore.git","ssh_url":"git@github.com:Microsoft/ChakraCore.git","clone_url":"https://github.com/Microsoft/ChakraCore.git","svn_url":"https://github.com/Microsoft/ChakraCore","homepage":null,"size":18684,"stargazers_count":4781,"watchers_count":4781,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":466,"mirror_url":null,"open_issues_count":67,"forks":466,"open_issues":67,"watchers":4781,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/214"},"html":{"href":"https://github.com/Microsoft/ChakraCore/pull/214"},"issue":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/issues/214"},"comments":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/issues/214/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/214/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/214/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/statuses/5f7e0f39b7d91f5ca5467fd5e6de96273855800f"}}}}