{"action":"created","issue":{"url":"https://api.github.com/repos/JuliaLang/julia/issues/16554","repository_url":"https://api.github.com/repos/JuliaLang/julia","labels_url":"https://api.github.com/repos/JuliaLang/julia/issues/16554/labels{/name}","comments_url":"https://api.github.com/repos/JuliaLang/julia/issues/16554/comments","events_url":"https://api.github.com/repos/JuliaLang/julia/issues/16554/events","html_url":"https://github.com/JuliaLang/julia/pull/16554","id":156491421,"number":16554,"title":"use julia's ishermitian instead of CHOLMOD's in sparse factorize","user":{"login":"KristofferC","id":1282691,"avatar_url":"https://avatars.githubusercontent.com/u/1282691?v=3","gravatar_id":"","url":"https://api.github.com/users/KristofferC","html_url":"https://github.com/KristofferC","followers_url":"https://api.github.com/users/KristofferC/followers","following_url":"https://api.github.com/users/KristofferC/following{/other_user}","gists_url":"https://api.github.com/users/KristofferC/gists{/gist_id}","starred_url":"https://api.github.com/users/KristofferC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KristofferC/subscriptions","organizations_url":"https://api.github.com/users/KristofferC/orgs","repos_url":"https://api.github.com/users/KristofferC/repos","events_url":"https://api.github.com/users/KristofferC/events{/privacy}","received_events_url":"https://api.github.com/users/KristofferC/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-05-24T12:11:28Z","updated_at":"2016-05-24T12:28:20Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/JuliaLang/julia/pulls/16554","html_url":"https://github.com/JuliaLang/julia/pull/16554","diff_url":"https://github.com/JuliaLang/julia/pull/16554.diff","patch_url":"https://github.com/JuliaLang/julia/pull/16554.patch"},"body":"No point in coupling this file and CHOLMOD when we have a julia implementation of `ishermitian`. This is also faster. Not that it matters compared to the time in factorizing the matrix."},"comment":{"url":"https://api.github.com/repos/JuliaLang/julia/issues/comments/221253242","html_url":"https://github.com/JuliaLang/julia/pull/16554#issuecomment-221253242","issue_url":"https://api.github.com/repos/JuliaLang/julia/issues/16554","id":221253242,"user":{"login":"andreasnoack","id":505001,"avatar_url":"https://avatars.githubusercontent.com/u/505001?v=3","gravatar_id":"","url":"https://api.github.com/users/andreasnoack","html_url":"https://github.com/andreasnoack","followers_url":"https://api.github.com/users/andreasnoack/followers","following_url":"https://api.github.com/users/andreasnoack/following{/other_user}","gists_url":"https://api.github.com/users/andreasnoack/gists{/gist_id}","starred_url":"https://api.github.com/users/andreasnoack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreasnoack/subscriptions","organizations_url":"https://api.github.com/users/andreasnoack/orgs","repos_url":"https://api.github.com/users/andreasnoack/repos","events_url":"https://api.github.com/users/andreasnoack/events{/privacy}","received_events_url":"https://api.github.com/users/andreasnoack/received_events","type":"User","site_admin":false},"created_at":"2016-05-24T12:28:20Z","updated_at":"2016-05-24T12:28:20Z","body":"The `Sparse` constructor checks for symmetry/Hermitianity on construction so this would trigger two checks. It should be fine if you wrap the matrix in the `Hermitian` type, i.e. `cholfact(Hermitian(A))`. That would bypass the second check."}}
{"actor":{"display_login":"andreasnoack"}}