{"action":"created","comment":{"url":"https://api.github.com/repos/sascha/DrawerController/pulls/comments/80920643","pull_request_review_id":1938489,"id":80920643,"diff_hunk":"@@ -1511,42 +1511,37 @@ public class DrawerController: UIViewController, UIGestureRecognizerDelegate {\n         return possibleOpenGestureModes\n     }\n     \n-    func isPointContainedWithinNavigationRect(point: CGPoint) -> Bool {\n-        var navigationBarRect = CGRectNull\n+    func isPointContainedWithinNavigationRect(_ point: CGPoint) -> Bool {\n+        var navigationBarRect = CGRect.null\n         \n         if let centerViewController = self.centerViewController {\n-            if centerViewController.isKindOfClass(UINavigationController) {\n+            if centerViewController.isKind(of: UINavigationController.self) {\n                 let navBar = (self.centerViewController as! UINavigationController).navigationBar\n-                navigationBarRect = navBar.convertRect(navBar.bounds, toView: self.childControllerContainerView)\n-                navigationBarRect = CGRectIntersection(navigationBarRect, self.childControllerContainerView.bounds)\n+                navigationBarRect = navBar.convert(navBar.bounds, to: self.childControllerContainerView)\n+                navigationBarRect = navigationBarRect.intersection(self.childControllerContainerView.bounds)\n             }\n         }\n         \n-        return CGRectContainsPoint(navigationBarRect, point)\n+        return navigationBarRect.contains(point)\n     }\n     \n-    func isPointContainedWithinCenterViewContentRect(point: CGPoint) -> Bool {\n+    func isPointContainedWithinCenterViewContentRect(_ point: CGPoint) -> Bool {\n         var centerViewContentRect = self.centerContainerView.frame\n-        centerViewContentRect = CGRectIntersection(centerViewContentRect, self.childControllerContainerView.bounds)\n+        centerViewContentRect = centerViewContentRect.intersection(self.childControllerContainerView.bounds)\n         \n-        return CGRectContainsPoint(centerViewContentRect, point) && self.isPointContainedWithinNavigationRect(point) == false\n+        return centerViewContentRect.contains(point) && self.isPointContainedWithinNavigationRect(point) == false\n     }\n     \n-    func isPointContainedWithinLeftBezelRect(point: CGPoint) -> Bool {\n-        var leftBezelRect = CGRectNull\n-        var tempRect = CGRectNull\n+    func isPointContainedWithinLeftBezelRect(_ point: CGPoint) -> Bool {\n+        let leftBezelRect = CGRect.null\n+        _ = childControllerContainerView.bounds.divided(atDistance: bezelRange, from: .minXEdge)\n         \n-        CGRectDivide(self.childControllerContainerView.bounds, &leftBezelRect, &tempRect, bezelRange, .MinXEdge)\n-        \n-        return CGRectContainsPoint(leftBezelRect, point) && self.isPointContainedWithinCenterViewContentRect(point)\n+        return leftBezelRect.contains(point) && self.isPointContainedWithinCenterViewContentRect(point)\n     }\n     \n-    func isPointContainedWithinRightBezelRect(point: CGPoint) -> Bool {\n-        var rightBezelRect = CGRectNull\n-        var tempRect = CGRectNull\n-        \n-        CGRectDivide(self.childControllerContainerView.bounds, &rightBezelRect, &tempRect, bezelRange, .MaxXEdge)\n-        \n-        return CGRectContainsPoint(rightBezelRect, point) && self.isPointContainedWithinCenterViewContentRect(point)\n+    func isPointContainedWithinRightBezelRect(_ point: CGPoint) -> Bool {\n+        let rightBezelRect = CGRect.null","path":"DrawerController/DrawerController.swift","position":1441,"original_position":1441,"commit_id":"e12c6e7c0c5847aabb09d63c5ab586b617aac0c3","original_commit_id":"e12c6e7c0c5847aabb09d63c5ab586b617aac0c3","user":{"login":"UweMeier","id":2063218,"avatar_url":"https://avatars.githubusercontent.com/u/2063218?v=3","gravatar_id":"","url":"https://api.github.com/users/UweMeier","html_url":"https://github.com/UweMeier","followers_url":"https://api.github.com/users/UweMeier/followers","following_url":"https://api.github.com/users/UweMeier/following{/other_user}","gists_url":"https://api.github.com/users/UweMeier/gists{/gist_id}","starred_url":"https://api.github.com/users/UweMeier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UweMeier/subscriptions","organizations_url":"https://api.github.com/users/UweMeier/orgs","repos_url":"https://api.github.com/users/UweMeier/repos","events_url":"https://api.github.com/users/UweMeier/events{/privacy}","received_events_url":"https://api.github.com/users/UweMeier/received_events","type":"User","site_admin":false},"body":"shouldn't it rather be:\r\n`var rightBezelRect = CGRect.null`\r\n`(rightBezelRect, _) = self.childControllerContainerView.bounds.divided(atDistance: bezelRange, from: .maxXEdge)`","created_at":"2016-09-28T13:53:55Z","updated_at":"2016-09-28T13:53:55Z","html_url":"https://github.com/sascha/DrawerController/pull/65#discussion_r80920643","pull_request_url":"https://api.github.com/repos/sascha/DrawerController/pulls/65","_links":{"self":{"href":"https://api.github.com/repos/sascha/DrawerController/pulls/comments/80920643"},"html":{"href":"https://github.com/sascha/DrawerController/pull/65#discussion_r80920643"},"pull_request":{"href":"https://api.github.com/repos/sascha/DrawerController/pulls/65"}}},"pull_request":{"url":"https://api.github.com/repos/sascha/DrawerController/pulls/65","id":85678119,"html_url":"https://github.com/sascha/DrawerController/pull/65","diff_url":"https://github.com/sascha/DrawerController/pull/65.diff","patch_url":"https://github.com/sascha/DrawerController/pull/65.patch","issue_url":"https://api.github.com/repos/sascha/DrawerController/issues/65","number":65,"state":"open","locked":false,"title":"update for swift3.0","user":{"login":"rigelxu","id":2800818,"avatar_url":"https://avatars.githubusercontent.com/u/2800818?v=3","gravatar_id":"","url":"https://api.github.com/users/rigelxu","html_url":"https://github.com/rigelxu","followers_url":"https://api.github.com/users/rigelxu/followers","following_url":"https://api.github.com/users/rigelxu/following{/other_user}","gists_url":"https://api.github.com/users/rigelxu/gists{/gist_id}","starred_url":"https://api.github.com/users/rigelxu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rigelxu/subscriptions","organizations_url":"https://api.github.com/users/rigelxu/orgs","repos_url":"https://api.github.com/users/rigelxu/repos","events_url":"https://api.github.com/users/rigelxu/events{/privacy}","received_events_url":"https://api.github.com/users/rigelxu/received_events","type":"User","site_admin":false},"body":"I'm using your ‘DrawerController’，please update to swift3.0,thanks.","created_at":"2016-09-17T15:52:34Z","updated_at":"2016-09-28T13:54:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aaf1cc62056aeba564ccd2358b06b386b2ec00b7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/sascha/DrawerController/pulls/65/commits","review_comments_url":"https://api.github.com/repos/sascha/DrawerController/pulls/65/comments","review_comment_url":"https://api.github.com/repos/sascha/DrawerController/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sascha/DrawerController/issues/65/comments","statuses_url":"https://api.github.com/repos/sascha/DrawerController/statuses/e12c6e7c0c5847aabb09d63c5ab586b617aac0c3","head":{"label":"rigelxu:master","ref":"master","sha":"e12c6e7c0c5847aabb09d63c5ab586b617aac0c3","user":{"login":"rigelxu","id":2800818,"avatar_url":"https://avatars.githubusercontent.com/u/2800818?v=3","gravatar_id":"","url":"https://api.github.com/users/rigelxu","html_url":"https://github.com/rigelxu","followers_url":"https://api.github.com/users/rigelxu/followers","following_url":"https://api.github.com/users/rigelxu/following{/other_user}","gists_url":"https://api.github.com/users/rigelxu/gists{/gist_id}","starred_url":"https://api.github.com/users/rigelxu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rigelxu/subscriptions","organizations_url":"https://api.github.com/users/rigelxu/orgs","repos_url":"https://api.github.com/users/rigelxu/repos","events_url":"https://api.github.com/users/rigelxu/events{/privacy}","received_events_url":"https://api.github.com/users/rigelxu/received_events","type":"User","site_admin":false},"repo":{"id":68459620,"name":"DrawerController","full_name":"rigelxu/DrawerController","owner":{"login":"rigelxu","id":2800818,"avatar_url":"https://avatars.githubusercontent.com/u/2800818?v=3","gravatar_id":"","url":"https://api.github.com/users/rigelxu","html_url":"https://github.com/rigelxu","followers_url":"https://api.github.com/users/rigelxu/followers","following_url":"https://api.github.com/users/rigelxu/following{/other_user}","gists_url":"https://api.github.com/users/rigelxu/gists{/gist_id}","starred_url":"https://api.github.com/users/rigelxu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rigelxu/subscriptions","organizations_url":"https://api.github.com/users/rigelxu/orgs","repos_url":"https://api.github.com/users/rigelxu/repos","events_url":"https://api.github.com/users/rigelxu/events{/privacy}","received_events_url":"https://api.github.com/users/rigelxu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rigelxu/DrawerController","description":"A lightweight, easy to use, Side Drawer Navigation Controller in Swift (based on MMDrawerController)","fork":true,"url":"https://api.github.com/repos/rigelxu/DrawerController","forks_url":"https://api.github.com/repos/rigelxu/DrawerController/forks","keys_url":"https://api.github.com/repos/rigelxu/DrawerController/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rigelxu/DrawerController/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rigelxu/DrawerController/teams","hooks_url":"https://api.github.com/repos/rigelxu/DrawerController/hooks","issue_events_url":"https://api.github.com/repos/rigelxu/DrawerController/issues/events{/number}","events_url":"https://api.github.com/repos/rigelxu/DrawerController/events","assignees_url":"https://api.github.com/repos/rigelxu/DrawerController/assignees{/user}","branches_url":"https://api.github.com/repos/rigelxu/DrawerController/branches{/branch}","tags_url":"https://api.github.com/repos/rigelxu/DrawerController/tags","blobs_url":"https://api.github.com/repos/rigelxu/DrawerController/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rigelxu/DrawerController/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rigelxu/DrawerController/git/refs{/sha}","trees_url":"https://api.github.com/repos/rigelxu/DrawerController/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rigelxu/DrawerController/statuses/{sha}","languages_url":"https://api.github.com/repos/rigelxu/DrawerController/languages","stargazers_url":"https://api.github.com/repos/rigelxu/DrawerController/stargazers","contributors_url":"https://api.github.com/repos/rigelxu/DrawerController/contributors","subscribers_url":"https://api.github.com/repos/rigelxu/DrawerController/subscribers","subscription_url":"https://api.github.com/repos/rigelxu/DrawerController/subscription","commits_url":"https://api.github.com/repos/rigelxu/DrawerController/commits{/sha}","git_commits_url":"https://api.github.com/repos/rigelxu/DrawerController/git/commits{/sha}","comments_url":"https://api.github.com/repos/rigelxu/DrawerController/comments{/number}","issue_comment_url":"https://api.github.com/repos/rigelxu/DrawerController/issues/comments{/number}","contents_url":"https://api.github.com/repos/rigelxu/DrawerController/contents/{+path}","compare_url":"https://api.github.com/repos/rigelxu/DrawerController/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rigelxu/DrawerController/merges","archive_url":"https://api.github.com/repos/rigelxu/DrawerController/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rigelxu/DrawerController/downloads","issues_url":"https://api.github.com/repos/rigelxu/DrawerController/issues{/number}","pulls_url":"https://api.github.com/repos/rigelxu/DrawerController/pulls{/number}","milestones_url":"https://api.github.com/repos/rigelxu/DrawerController/milestones{/number}","notifications_url":"https://api.github.com/repos/rigelxu/DrawerController/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rigelxu/DrawerController/labels{/name}","releases_url":"https://api.github.com/repos/rigelxu/DrawerController/releases{/id}","deployments_url":"https://api.github.com/repos/rigelxu/DrawerController/deployments","created_at":"2016-09-17T15:13:46Z","updated_at":"2016-09-17T15:13:47Z","pushed_at":"2016-09-17T15:19:39Z","git_url":"git://github.com/rigelxu/DrawerController.git","ssh_url":"git@github.com:rigelxu/DrawerController.git","clone_url":"https://github.com/rigelxu/DrawerController.git","svn_url":"https://github.com/rigelxu/DrawerController","homepage":"","size":206,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sascha:master","ref":"master","sha":"276ab02c2915ad270310b15b32ddd7d5fa525e21","user":{"login":"sascha","id":895505,"avatar_url":"https://avatars.githubusercontent.com/u/895505?v=3","gravatar_id":"","url":"https://api.github.com/users/sascha","html_url":"https://github.com/sascha","followers_url":"https://api.github.com/users/sascha/followers","following_url":"https://api.github.com/users/sascha/following{/other_user}","gists_url":"https://api.github.com/users/sascha/gists{/gist_id}","starred_url":"https://api.github.com/users/sascha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sascha/subscriptions","organizations_url":"https://api.github.com/users/sascha/orgs","repos_url":"https://api.github.com/users/sascha/repos","events_url":"https://api.github.com/users/sascha/events{/privacy}","received_events_url":"https://api.github.com/users/sascha/received_events","type":"User","site_admin":false},"repo":{"id":24009438,"name":"DrawerController","full_name":"sascha/DrawerController","owner":{"login":"sascha","id":895505,"avatar_url":"https://avatars.githubusercontent.com/u/895505?v=3","gravatar_id":"","url":"https://api.github.com/users/sascha","html_url":"https://github.com/sascha","followers_url":"https://api.github.com/users/sascha/followers","following_url":"https://api.github.com/users/sascha/following{/other_user}","gists_url":"https://api.github.com/users/sascha/gists{/gist_id}","starred_url":"https://api.github.com/users/sascha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sascha/subscriptions","organizations_url":"https://api.github.com/users/sascha/orgs","repos_url":"https://api.github.com/users/sascha/repos","events_url":"https://api.github.com/users/sascha/events{/privacy}","received_events_url":"https://api.github.com/users/sascha/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sascha/DrawerController","description":"A lightweight, easy to use, Side Drawer Navigation Controller in Swift (based on MMDrawerController)","fork":false,"url":"https://api.github.com/repos/sascha/DrawerController","forks_url":"https://api.github.com/repos/sascha/DrawerController/forks","keys_url":"https://api.github.com/repos/sascha/DrawerController/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sascha/DrawerController/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sascha/DrawerController/teams","hooks_url":"https://api.github.com/repos/sascha/DrawerController/hooks","issue_events_url":"https://api.github.com/repos/sascha/DrawerController/issues/events{/number}","events_url":"https://api.github.com/repos/sascha/DrawerController/events","assignees_url":"https://api.github.com/repos/sascha/DrawerController/assignees{/user}","branches_url":"https://api.github.com/repos/sascha/DrawerController/branches{/branch}","tags_url":"https://api.github.com/repos/sascha/DrawerController/tags","blobs_url":"https://api.github.com/repos/sascha/DrawerController/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sascha/DrawerController/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sascha/DrawerController/git/refs{/sha}","trees_url":"https://api.github.com/repos/sascha/DrawerController/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sascha/DrawerController/statuses/{sha}","languages_url":"https://api.github.com/repos/sascha/DrawerController/languages","stargazers_url":"https://api.github.com/repos/sascha/DrawerController/stargazers","contributors_url":"https://api.github.com/repos/sascha/DrawerController/contributors","subscribers_url":"https://api.github.com/repos/sascha/DrawerController/subscribers","subscription_url":"https://api.github.com/repos/sascha/DrawerController/subscription","commits_url":"https://api.github.com/repos/sascha/DrawerController/commits{/sha}","git_commits_url":"https://api.github.com/repos/sascha/DrawerController/git/commits{/sha}","comments_url":"https://api.github.com/repos/sascha/DrawerController/comments{/number}","issue_comment_url":"https://api.github.com/repos/sascha/DrawerController/issues/comments{/number}","contents_url":"https://api.github.com/repos/sascha/DrawerController/contents/{+path}","compare_url":"https://api.github.com/repos/sascha/DrawerController/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sascha/DrawerController/merges","archive_url":"https://api.github.com/repos/sascha/DrawerController/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sascha/DrawerController/downloads","issues_url":"https://api.github.com/repos/sascha/DrawerController/issues{/number}","pulls_url":"https://api.github.com/repos/sascha/DrawerController/pulls{/number}","milestones_url":"https://api.github.com/repos/sascha/DrawerController/milestones{/number}","notifications_url":"https://api.github.com/repos/sascha/DrawerController/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sascha/DrawerController/labels{/name}","releases_url":"https://api.github.com/repos/sascha/DrawerController/releases{/id}","deployments_url":"https://api.github.com/repos/sascha/DrawerController/deployments","created_at":"2014-09-14T00:07:48Z","updated_at":"2016-09-26T03:41:56Z","pushed_at":"2016-09-17T15:52:34Z","git_url":"git://github.com/sascha/DrawerController.git","ssh_url":"git@github.com:sascha/DrawerController.git","clone_url":"https://github.com/sascha/DrawerController.git","svn_url":"https://github.com/sascha/DrawerController","homepage":"","size":298,"stargazers_count":311,"watchers_count":311,"language":"Swift","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":90,"mirror_url":null,"open_issues_count":9,"forks":90,"open_issues":9,"watchers":311,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sascha/DrawerController/pulls/65"},"html":{"href":"https://github.com/sascha/DrawerController/pull/65"},"issue":{"href":"https://api.github.com/repos/sascha/DrawerController/issues/65"},"comments":{"href":"https://api.github.com/repos/sascha/DrawerController/issues/65/comments"},"review_comments":{"href":"https://api.github.com/repos/sascha/DrawerController/pulls/65/comments"},"review_comment":{"href":"https://api.github.com/repos/sascha/DrawerController/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sascha/DrawerController/pulls/65/commits"},"statuses":{"href":"https://api.github.com/repos/sascha/DrawerController/statuses/e12c6e7c0c5847aabb09d63c5ab586b617aac0c3"}}}}
{"actor":{"display_login":"UweMeier"}}