{"action":"created","comment":{"url":"https://api.github.com/repos/KnpLabs/php-github-api/pulls/comments/68899974","id":68899974,"diff_hunk":"@@ -77,32 +89,68 @@ class Client\n      * @var array\n      */\n     private $options = array(\n-        'base_url'    => 'https://api.github.com/',\n-\n-        'user_agent'  => 'php-github-api (http://github.com/KnpLabs/php-github-api)',\n-        'timeout'     => 10,\n-\n-        'api_limit'   => 5000,\n         'api_version' => 'v3',\n-\n-        'cache_dir'   => null\n     );\n \n     /**\n-     * The Buzz instance used to communicate with GitHub.\n+     * The object that sends HTTP messages\n      *\n      * @var HttpClient\n      */\n     private $httpClient;\n \n     /**\n+     * A HTTP client with all our plugins\n+     *\n+     * @var PluginClient\n+     */\n+    private $pluginClient;\n+\n+    /**\n+     * @var MessageFactory\\\n+     */\n+    private $messageFactory;\n+\n+    /**\n+     * @var Plugin[]\n+     */\n+    private $plugins = array();","path":"lib/Github/Client.php","position":61,"original_position":61,"commit_id":"d830fd404b1297eb082d6d2956be7f7ab75d2cb8","original_commit_id":"d830fd404b1297eb082d6d2956be7f7ab75d2cb8","user":{"login":"cursedcoder","id":899452,"avatar_url":"https://avatars.githubusercontent.com/u/899452?v=3","gravatar_id":"","url":"https://api.github.com/users/cursedcoder","html_url":"https://github.com/cursedcoder","followers_url":"https://api.github.com/users/cursedcoder/followers","following_url":"https://api.github.com/users/cursedcoder/following{/other_user}","gists_url":"https://api.github.com/users/cursedcoder/gists{/gist_id}","starred_url":"https://api.github.com/users/cursedcoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cursedcoder/subscriptions","organizations_url":"https://api.github.com/users/cursedcoder/orgs","repos_url":"https://api.github.com/users/cursedcoder/repos","events_url":"https://api.github.com/users/cursedcoder/events{/privacy}","received_events_url":"https://api.github.com/users/cursedcoder/received_events","type":"User","site_admin":false},"body":"let's use short syntax `private $plugins = [];`","created_at":"2016-06-29T07:52:16Z","updated_at":"2016-06-29T07:52:16Z","html_url":"https://github.com/KnpLabs/php-github-api/pull/389#discussion_r68899974","pull_request_url":"https://api.github.com/repos/KnpLabs/php-github-api/pulls/389","_links":{"self":{"href":"https://api.github.com/repos/KnpLabs/php-github-api/pulls/comments/68899974"},"html":{"href":"https://github.com/KnpLabs/php-github-api/pull/389#discussion_r68899974"},"pull_request":{"href":"https://api.github.com/repos/KnpLabs/php-github-api/pulls/389"}}},"pull_request":{"url":"https://api.github.com/repos/KnpLabs/php-github-api/pulls/389","id":73497130,"html_url":"https://github.com/KnpLabs/php-github-api/pull/389","diff_url":"https://github.com/KnpLabs/php-github-api/pull/389.diff","patch_url":"https://github.com/KnpLabs/php-github-api/pull/389.patch","issue_url":"https://api.github.com/repos/KnpLabs/php-github-api/issues/389","number":389,"state":"open","locked":false,"title":"Decouple from Guzzle","user":{"login":"Nyholm","id":1275206,"avatar_url":"https://avatars.githubusercontent.com/u/1275206?v=3","gravatar_id":"","url":"https://api.github.com/users/Nyholm","html_url":"https://github.com/Nyholm","followers_url":"https://api.github.com/users/Nyholm/followers","following_url":"https://api.github.com/users/Nyholm/following{/other_user}","gists_url":"https://api.github.com/users/Nyholm/gists{/gist_id}","starred_url":"https://api.github.com/users/Nyholm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nyholm/subscriptions","organizations_url":"https://api.github.com/users/Nyholm/orgs","repos_url":"https://api.github.com/users/Nyholm/repos","events_url":"https://api.github.com/users/Nyholm/events{/privacy}","received_events_url":"https://api.github.com/users/Nyholm/received_events","type":"User","site_admin":false},"body":"This PR replaces #352. We do not want to be coupled to Guzzle, instead we want to use an abstraction layer so the end user can choose what HTTP message implementation to use.\r\n\r\nThis PR removes all our HTTP layer and replaces it with Httplug and custom plugins. I struggled for a while to make this PR backwards compatible but the code got too complicated and would have left us with an abstraction for an abstraction. \r\n\r\nQuestion to the maintainers: \r\nDo you like this change? Should I continue with this PR and complete the TODOs?\r\n\r\n# TODO\r\n* [ ] Add some more docs about HTTP plug in the readme. \r\n* [ ] Make sure existing docs are up to date\r\n* [x] Make sure the tests passes","created_at":"2016-06-12T14:02:31Z","updated_at":"2016-06-29T07:52:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"36baee54894314ea4e51d5e522b339e1b775b678","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/KnpLabs/php-github-api/pulls/389/commits","review_comments_url":"https://api.github.com/repos/KnpLabs/php-github-api/pulls/389/comments","review_comment_url":"https://api.github.com/repos/KnpLabs/php-github-api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/KnpLabs/php-github-api/issues/389/comments","statuses_url":"https://api.github.com/repos/KnpLabs/php-github-api/statuses/d830fd404b1297eb082d6d2956be7f7ab75d2cb8","head":{"label":"Nyholm:httplug","ref":"httplug","sha":"d830fd404b1297eb082d6d2956be7f7ab75d2cb8","user":{"login":"Nyholm","id":1275206,"avatar_url":"https://avatars.githubusercontent.com/u/1275206?v=3","gravatar_id":"","url":"https://api.github.com/users/Nyholm","html_url":"https://github.com/Nyholm","followers_url":"https://api.github.com/users/Nyholm/followers","following_url":"https://api.github.com/users/Nyholm/following{/other_user}","gists_url":"https://api.github.com/users/Nyholm/gists{/gist_id}","starred_url":"https://api.github.com/users/Nyholm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nyholm/subscriptions","organizations_url":"https://api.github.com/users/Nyholm/orgs","repos_url":"https://api.github.com/users/Nyholm/repos","events_url":"https://api.github.com/users/Nyholm/events{/privacy}","received_events_url":"https://api.github.com/users/Nyholm/received_events","type":"User","site_admin":false},"repo":{"id":21824690,"name":"php-github-api","full_name":"Nyholm/php-github-api","owner":{"login":"Nyholm","id":1275206,"avatar_url":"https://avatars.githubusercontent.com/u/1275206?v=3","gravatar_id":"","url":"https://api.github.com/users/Nyholm","html_url":"https://github.com/Nyholm","followers_url":"https://api.github.com/users/Nyholm/followers","following_url":"https://api.github.com/users/Nyholm/following{/other_user}","gists_url":"https://api.github.com/users/Nyholm/gists{/gist_id}","starred_url":"https://api.github.com/users/Nyholm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nyholm/subscriptions","organizations_url":"https://api.github.com/users/Nyholm/orgs","repos_url":"https://api.github.com/users/Nyholm/repos","events_url":"https://api.github.com/users/Nyholm/events{/privacy}","received_events_url":"https://api.github.com/users/Nyholm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Nyholm/php-github-api","description":"A simple PHP GitHub API client, Object Oriented, tested and documented. For 5.3+.","fork":true,"url":"https://api.github.com/repos/Nyholm/php-github-api","forks_url":"https://api.github.com/repos/Nyholm/php-github-api/forks","keys_url":"https://api.github.com/repos/Nyholm/php-github-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Nyholm/php-github-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Nyholm/php-github-api/teams","hooks_url":"https://api.github.com/repos/Nyholm/php-github-api/hooks","issue_events_url":"https://api.github.com/repos/Nyholm/php-github-api/issues/events{/number}","events_url":"https://api.github.com/repos/Nyholm/php-github-api/events","assignees_url":"https://api.github.com/repos/Nyholm/php-github-api/assignees{/user}","branches_url":"https://api.github.com/repos/Nyholm/php-github-api/branches{/branch}","tags_url":"https://api.github.com/repos/Nyholm/php-github-api/tags","blobs_url":"https://api.github.com/repos/Nyholm/php-github-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Nyholm/php-github-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Nyholm/php-github-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/Nyholm/php-github-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Nyholm/php-github-api/statuses/{sha}","languages_url":"https://api.github.com/repos/Nyholm/php-github-api/languages","stargazers_url":"https://api.github.com/repos/Nyholm/php-github-api/stargazers","contributors_url":"https://api.github.com/repos/Nyholm/php-github-api/contributors","subscribers_url":"https://api.github.com/repos/Nyholm/php-github-api/subscribers","subscription_url":"https://api.github.com/repos/Nyholm/php-github-api/subscription","commits_url":"https://api.github.com/repos/Nyholm/php-github-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/Nyholm/php-github-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/Nyholm/php-github-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/Nyholm/php-github-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/Nyholm/php-github-api/contents/{+path}","compare_url":"https://api.github.com/repos/Nyholm/php-github-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Nyholm/php-github-api/merges","archive_url":"https://api.github.com/repos/Nyholm/php-github-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Nyholm/php-github-api/downloads","issues_url":"https://api.github.com/repos/Nyholm/php-github-api/issues{/number}","pulls_url":"https://api.github.com/repos/Nyholm/php-github-api/pulls{/number}","milestones_url":"https://api.github.com/repos/Nyholm/php-github-api/milestones{/number}","notifications_url":"https://api.github.com/repos/Nyholm/php-github-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Nyholm/php-github-api/labels{/name}","releases_url":"https://api.github.com/repos/Nyholm/php-github-api/releases{/id}","deployments_url":"https://api.github.com/repos/Nyholm/php-github-api/deployments","created_at":"2014-07-14T15:24:45Z","updated_at":"2014-07-14T15:25:12Z","pushed_at":"2016-06-26T20:35:52Z","git_url":"git://github.com/Nyholm/php-github-api.git","ssh_url":"git@github.com:Nyholm/php-github-api.git","clone_url":"https://github.com/Nyholm/php-github-api.git","svn_url":"https://github.com/Nyholm/php-github-api","homepage":"","size":1059,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"KnpLabs:master","ref":"master","sha":"da5451d149f7eb3b6b63e74421cce58b33e5e2f9","user":{"login":"KnpLabs","id":202732,"avatar_url":"https://avatars.githubusercontent.com/u/202732?v=3","gravatar_id":"","url":"https://api.github.com/users/KnpLabs","html_url":"https://github.com/KnpLabs","followers_url":"https://api.github.com/users/KnpLabs/followers","following_url":"https://api.github.com/users/KnpLabs/following{/other_user}","gists_url":"https://api.github.com/users/KnpLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/KnpLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KnpLabs/subscriptions","organizations_url":"https://api.github.com/users/KnpLabs/orgs","repos_url":"https://api.github.com/users/KnpLabs/repos","events_url":"https://api.github.com/users/KnpLabs/events{/privacy}","received_events_url":"https://api.github.com/users/KnpLabs/received_events","type":"Organization","site_admin":false},"repo":{"id":3948501,"name":"php-github-api","full_name":"KnpLabs/php-github-api","owner":{"login":"KnpLabs","id":202732,"avatar_url":"https://avatars.githubusercontent.com/u/202732?v=3","gravatar_id":"","url":"https://api.github.com/users/KnpLabs","html_url":"https://github.com/KnpLabs","followers_url":"https://api.github.com/users/KnpLabs/followers","following_url":"https://api.github.com/users/KnpLabs/following{/other_user}","gists_url":"https://api.github.com/users/KnpLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/KnpLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KnpLabs/subscriptions","organizations_url":"https://api.github.com/users/KnpLabs/orgs","repos_url":"https://api.github.com/users/KnpLabs/repos","events_url":"https://api.github.com/users/KnpLabs/events{/privacy}","received_events_url":"https://api.github.com/users/KnpLabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/KnpLabs/php-github-api","description":"A simple PHP GitHub API client, Object Oriented, tested and documented. For 5.3+.","fork":false,"url":"https://api.github.com/repos/KnpLabs/php-github-api","forks_url":"https://api.github.com/repos/KnpLabs/php-github-api/forks","keys_url":"https://api.github.com/repos/KnpLabs/php-github-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KnpLabs/php-github-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KnpLabs/php-github-api/teams","hooks_url":"https://api.github.com/repos/KnpLabs/php-github-api/hooks","issue_events_url":"https://api.github.com/repos/KnpLabs/php-github-api/issues/events{/number}","events_url":"https://api.github.com/repos/KnpLabs/php-github-api/events","assignees_url":"https://api.github.com/repos/KnpLabs/php-github-api/assignees{/user}","branches_url":"https://api.github.com/repos/KnpLabs/php-github-api/branches{/branch}","tags_url":"https://api.github.com/repos/KnpLabs/php-github-api/tags","blobs_url":"https://api.github.com/repos/KnpLabs/php-github-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KnpLabs/php-github-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KnpLabs/php-github-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/KnpLabs/php-github-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KnpLabs/php-github-api/statuses/{sha}","languages_url":"https://api.github.com/repos/KnpLabs/php-github-api/languages","stargazers_url":"https://api.github.com/repos/KnpLabs/php-github-api/stargazers","contributors_url":"https://api.github.com/repos/KnpLabs/php-github-api/contributors","subscribers_url":"https://api.github.com/repos/KnpLabs/php-github-api/subscribers","subscription_url":"https://api.github.com/repos/KnpLabs/php-github-api/subscription","commits_url":"https://api.github.com/repos/KnpLabs/php-github-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/KnpLabs/php-github-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/KnpLabs/php-github-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/KnpLabs/php-github-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/KnpLabs/php-github-api/contents/{+path}","compare_url":"https://api.github.com/repos/KnpLabs/php-github-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KnpLabs/php-github-api/merges","archive_url":"https://api.github.com/repos/KnpLabs/php-github-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KnpLabs/php-github-api/downloads","issues_url":"https://api.github.com/repos/KnpLabs/php-github-api/issues{/number}","pulls_url":"https://api.github.com/repos/KnpLabs/php-github-api/pulls{/number}","milestones_url":"https://api.github.com/repos/KnpLabs/php-github-api/milestones{/number}","notifications_url":"https://api.github.com/repos/KnpLabs/php-github-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KnpLabs/php-github-api/labels{/name}","releases_url":"https://api.github.com/repos/KnpLabs/php-github-api/releases{/id}","deployments_url":"https://api.github.com/repos/KnpLabs/php-github-api/deployments","created_at":"2012-04-06T09:44:28Z","updated_at":"2016-06-28T20:39:04Z","pushed_at":"2016-06-26T23:23:39Z","git_url":"git://github.com/KnpLabs/php-github-api.git","ssh_url":"git@github.com:KnpLabs/php-github-api.git","clone_url":"https://github.com/KnpLabs/php-github-api.git","svn_url":"https://github.com/KnpLabs/php-github-api","homepage":"","size":2041,"stargazers_count":866,"watchers_count":866,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":316,"mirror_url":null,"open_issues_count":38,"forks":316,"open_issues":38,"watchers":866,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/KnpLabs/php-github-api/pulls/389"},"html":{"href":"https://github.com/KnpLabs/php-github-api/pull/389"},"issue":{"href":"https://api.github.com/repos/KnpLabs/php-github-api/issues/389"},"comments":{"href":"https://api.github.com/repos/KnpLabs/php-github-api/issues/389/comments"},"review_comments":{"href":"https://api.github.com/repos/KnpLabs/php-github-api/pulls/389/comments"},"review_comment":{"href":"https://api.github.com/repos/KnpLabs/php-github-api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/KnpLabs/php-github-api/pulls/389/commits"},"statuses":{"href":"https://api.github.com/repos/KnpLabs/php-github-api/statuses/d830fd404b1297eb082d6d2956be7f7ab75d2cb8"}}}}
{"actor":{"display_login":"cursedcoder"}}