{"action":"created","comment":{"url":"https://api.github.com/repos/Theano/Theano/pulls/comments/86790520","pull_request_review_id":7429461,"id":86790520,"diff_hunk":"@@ -1733,6 +1733,7 @@ def infer_shape(self, node, shapes):\n         return [rval]\n \n     def R_op(self, inputs, eval_points):\n+        raise ValueError","path":"theano/tensor/basic.py","position":null,"original_position":4,"commit_id":"8003d6b47b116c57344c42e694312397e52e446c","original_commit_id":"8003d6b47b116c57344c42e694312397e52e446c","user":{"login":"sygi","id":495380,"avatar_url":"https://avatars.githubusercontent.com/u/495380?v=3","gravatar_id":"","url":"https://api.github.com/users/sygi","html_url":"https://github.com/sygi","followers_url":"https://api.github.com/users/sygi/followers","following_url":"https://api.github.com/users/sygi/following{/other_user}","gists_url":"https://api.github.com/users/sygi/gists{/gist_id}","starred_url":"https://api.github.com/users/sygi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sygi/subscriptions","organizations_url":"https://api.github.com/users/sygi/orgs","repos_url":"https://api.github.com/users/sygi/repos","events_url":"https://api.github.com/users/sygi/events{/privacy}","received_events_url":"https://api.github.com/users/sygi/received_events","type":"User","site_admin":false},"body":"What about this line? I was getting errors that argmax is nondifferentiable yet not raises when I was testing without it.","created_at":"2016-11-07T14:54:36Z","updated_at":"2016-11-07T14:54:36Z","html_url":"https://github.com/Theano/Theano/pull/5155#discussion_r86790520","pull_request_url":"https://api.github.com/repos/Theano/Theano/pulls/5155","_links":{"self":{"href":"https://api.github.com/repos/Theano/Theano/pulls/comments/86790520"},"html":{"href":"https://github.com/Theano/Theano/pull/5155#discussion_r86790520"},"pull_request":{"href":"https://api.github.com/repos/Theano/Theano/pulls/5155"}}},"pull_request":{"url":"https://api.github.com/repos/Theano/Theano/pulls/5155","id":91519734,"html_url":"https://github.com/Theano/Theano/pull/5155","diff_url":"https://github.com/Theano/Theano/pull/5155.diff","patch_url":"https://github.com/Theano/Theano/pull/5155.patch","issue_url":"https://api.github.com/repos/Theano/Theano/issues/5155","number":5155,"state":"open","locked":false,"title":"Option to evaluate part of the max-and-argmax on cpu","user":{"login":"sygi","id":495380,"avatar_url":"https://avatars.githubusercontent.com/u/495380?v=3","gravatar_id":"","url":"https://api.github.com/users/sygi","html_url":"https://github.com/sygi","followers_url":"https://api.github.com/users/sygi/followers","following_url":"https://api.github.com/users/sygi/following{/other_user}","gists_url":"https://api.github.com/users/sygi/gists{/gist_id}","starred_url":"https://api.github.com/users/sygi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sygi/subscriptions","organizations_url":"https://api.github.com/users/sygi/orgs","repos_url":"https://api.github.com/users/sygi/repos","events_url":"https://api.github.com/users/sygi/events{/privacy}","received_events_url":"https://api.github.com/users/sygi/received_events","type":"User","site_admin":false},"body":"Is it a good idea to try to access the already computed indices instead of calculating the max in the case of `eval_max=True` and `eval_argmax=True`?\n\nFixes #5147.\n","created_at":"2016-10-30T12:09:53Z","updated_at":"2016-11-07T14:54:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fb2e5b65abad10f90bdf95c38c13d138e11fee04","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Theano/Theano/pulls/5155/commits","review_comments_url":"https://api.github.com/repos/Theano/Theano/pulls/5155/comments","review_comment_url":"https://api.github.com/repos/Theano/Theano/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Theano/Theano/issues/5155/comments","statuses_url":"https://api.github.com/repos/Theano/Theano/statuses/8003d6b47b116c57344c42e694312397e52e446c","head":{"label":"sygi:argmax-only-cpu","ref":"argmax-only-cpu","sha":"8003d6b47b116c57344c42e694312397e52e446c","user":{"login":"sygi","id":495380,"avatar_url":"https://avatars.githubusercontent.com/u/495380?v=3","gravatar_id":"","url":"https://api.github.com/users/sygi","html_url":"https://github.com/sygi","followers_url":"https://api.github.com/users/sygi/followers","following_url":"https://api.github.com/users/sygi/following{/other_user}","gists_url":"https://api.github.com/users/sygi/gists{/gist_id}","starred_url":"https://api.github.com/users/sygi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sygi/subscriptions","organizations_url":"https://api.github.com/users/sygi/orgs","repos_url":"https://api.github.com/users/sygi/repos","events_url":"https://api.github.com/users/sygi/events{/privacy}","received_events_url":"https://api.github.com/users/sygi/received_events","type":"User","site_admin":false},"repo":{"id":51503991,"name":"Theano","full_name":"sygi/Theano","owner":{"login":"sygi","id":495380,"avatar_url":"https://avatars.githubusercontent.com/u/495380?v=3","gravatar_id":"","url":"https://api.github.com/users/sygi","html_url":"https://github.com/sygi","followers_url":"https://api.github.com/users/sygi/followers","following_url":"https://api.github.com/users/sygi/following{/other_user}","gists_url":"https://api.github.com/users/sygi/gists{/gist_id}","starred_url":"https://api.github.com/users/sygi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sygi/subscriptions","organizations_url":"https://api.github.com/users/sygi/orgs","repos_url":"https://api.github.com/users/sygi/repos","events_url":"https://api.github.com/users/sygi/events{/privacy}","received_events_url":"https://api.github.com/users/sygi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sygi/Theano","description":"Theano is a Python library that allows you to define, optimize, and evaluate mathematical expressions involving multi-dimensional arrays efficiently. It can use GPUs and perform efficient symbolic differentiation.","fork":true,"url":"https://api.github.com/repos/sygi/Theano","forks_url":"https://api.github.com/repos/sygi/Theano/forks","keys_url":"https://api.github.com/repos/sygi/Theano/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sygi/Theano/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sygi/Theano/teams","hooks_url":"https://api.github.com/repos/sygi/Theano/hooks","issue_events_url":"https://api.github.com/repos/sygi/Theano/issues/events{/number}","events_url":"https://api.github.com/repos/sygi/Theano/events","assignees_url":"https://api.github.com/repos/sygi/Theano/assignees{/user}","branches_url":"https://api.github.com/repos/sygi/Theano/branches{/branch}","tags_url":"https://api.github.com/repos/sygi/Theano/tags","blobs_url":"https://api.github.com/repos/sygi/Theano/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sygi/Theano/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sygi/Theano/git/refs{/sha}","trees_url":"https://api.github.com/repos/sygi/Theano/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sygi/Theano/statuses/{sha}","languages_url":"https://api.github.com/repos/sygi/Theano/languages","stargazers_url":"https://api.github.com/repos/sygi/Theano/stargazers","contributors_url":"https://api.github.com/repos/sygi/Theano/contributors","subscribers_url":"https://api.github.com/repos/sygi/Theano/subscribers","subscription_url":"https://api.github.com/repos/sygi/Theano/subscription","commits_url":"https://api.github.com/repos/sygi/Theano/commits{/sha}","git_commits_url":"https://api.github.com/repos/sygi/Theano/git/commits{/sha}","comments_url":"https://api.github.com/repos/sygi/Theano/comments{/number}","issue_comment_url":"https://api.github.com/repos/sygi/Theano/issues/comments{/number}","contents_url":"https://api.github.com/repos/sygi/Theano/contents/{+path}","compare_url":"https://api.github.com/repos/sygi/Theano/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sygi/Theano/merges","archive_url":"https://api.github.com/repos/sygi/Theano/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sygi/Theano/downloads","issues_url":"https://api.github.com/repos/sygi/Theano/issues{/number}","pulls_url":"https://api.github.com/repos/sygi/Theano/pulls{/number}","milestones_url":"https://api.github.com/repos/sygi/Theano/milestones{/number}","notifications_url":"https://api.github.com/repos/sygi/Theano/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sygi/Theano/labels{/name}","releases_url":"https://api.github.com/repos/sygi/Theano/releases{/id}","deployments_url":"https://api.github.com/repos/sygi/Theano/deployments","created_at":"2016-02-11T09:05:13Z","updated_at":"2016-02-11T09:05:17Z","pushed_at":"2016-11-05T13:17:39Z","git_url":"git://github.com/sygi/Theano.git","ssh_url":"git@github.com:sygi/Theano.git","clone_url":"https://github.com/sygi/Theano.git","svn_url":"https://github.com/sygi/Theano","homepage":"http://www.deeplearning.net/software/theano","size":60129,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Theano:master","ref":"master","sha":"205adfa40cb7718362d3af4c4d8023f0cc2ce39a","user":{"login":"Theano","id":970517,"avatar_url":"https://avatars.githubusercontent.com/u/970517?v=3","gravatar_id":"","url":"https://api.github.com/users/Theano","html_url":"https://github.com/Theano","followers_url":"https://api.github.com/users/Theano/followers","following_url":"https://api.github.com/users/Theano/following{/other_user}","gists_url":"https://api.github.com/users/Theano/gists{/gist_id}","starred_url":"https://api.github.com/users/Theano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Theano/subscriptions","organizations_url":"https://api.github.com/users/Theano/orgs","repos_url":"https://api.github.com/users/Theano/repos","events_url":"https://api.github.com/users/Theano/events{/privacy}","received_events_url":"https://api.github.com/users/Theano/received_events","type":"Organization","site_admin":false},"repo":{"id":2183193,"name":"Theano","full_name":"Theano/Theano","owner":{"login":"Theano","id":970517,"avatar_url":"https://avatars.githubusercontent.com/u/970517?v=3","gravatar_id":"","url":"https://api.github.com/users/Theano","html_url":"https://github.com/Theano","followers_url":"https://api.github.com/users/Theano/followers","following_url":"https://api.github.com/users/Theano/following{/other_user}","gists_url":"https://api.github.com/users/Theano/gists{/gist_id}","starred_url":"https://api.github.com/users/Theano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Theano/subscriptions","organizations_url":"https://api.github.com/users/Theano/orgs","repos_url":"https://api.github.com/users/Theano/repos","events_url":"https://api.github.com/users/Theano/events{/privacy}","received_events_url":"https://api.github.com/users/Theano/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Theano/Theano","description":"Theano is a Python library that allows you to define, optimize, and evaluate mathematical expressions involving multi-dimensional arrays efficiently. It can use GPUs and perform efficient symbolic differentiation.","fork":false,"url":"https://api.github.com/repos/Theano/Theano","forks_url":"https://api.github.com/repos/Theano/Theano/forks","keys_url":"https://api.github.com/repos/Theano/Theano/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Theano/Theano/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Theano/Theano/teams","hooks_url":"https://api.github.com/repos/Theano/Theano/hooks","issue_events_url":"https://api.github.com/repos/Theano/Theano/issues/events{/number}","events_url":"https://api.github.com/repos/Theano/Theano/events","assignees_url":"https://api.github.com/repos/Theano/Theano/assignees{/user}","branches_url":"https://api.github.com/repos/Theano/Theano/branches{/branch}","tags_url":"https://api.github.com/repos/Theano/Theano/tags","blobs_url":"https://api.github.com/repos/Theano/Theano/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Theano/Theano/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Theano/Theano/git/refs{/sha}","trees_url":"https://api.github.com/repos/Theano/Theano/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Theano/Theano/statuses/{sha}","languages_url":"https://api.github.com/repos/Theano/Theano/languages","stargazers_url":"https://api.github.com/repos/Theano/Theano/stargazers","contributors_url":"https://api.github.com/repos/Theano/Theano/contributors","subscribers_url":"https://api.github.com/repos/Theano/Theano/subscribers","subscription_url":"https://api.github.com/repos/Theano/Theano/subscription","commits_url":"https://api.github.com/repos/Theano/Theano/commits{/sha}","git_commits_url":"https://api.github.com/repos/Theano/Theano/git/commits{/sha}","comments_url":"https://api.github.com/repos/Theano/Theano/comments{/number}","issue_comment_url":"https://api.github.com/repos/Theano/Theano/issues/comments{/number}","contents_url":"https://api.github.com/repos/Theano/Theano/contents/{+path}","compare_url":"https://api.github.com/repos/Theano/Theano/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Theano/Theano/merges","archive_url":"https://api.github.com/repos/Theano/Theano/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Theano/Theano/downloads","issues_url":"https://api.github.com/repos/Theano/Theano/issues{/number}","pulls_url":"https://api.github.com/repos/Theano/Theano/pulls{/number}","milestones_url":"https://api.github.com/repos/Theano/Theano/milestones{/number}","notifications_url":"https://api.github.com/repos/Theano/Theano/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Theano/Theano/labels{/name}","releases_url":"https://api.github.com/repos/Theano/Theano/releases{/id}","deployments_url":"https://api.github.com/repos/Theano/Theano/deployments","created_at":"2011-08-10T03:48:06Z","updated_at":"2016-11-07T13:39:41Z","pushed_at":"2016-11-07T14:16:17Z","git_url":"git://github.com/Theano/Theano.git","ssh_url":"git@github.com:Theano/Theano.git","clone_url":"https://github.com/Theano/Theano.git","svn_url":"https://github.com/Theano/Theano","homepage":"http://www.deeplearning.net/software/theano","size":80259,"stargazers_count":4916,"watchers_count":4916,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1741,"mirror_url":null,"open_issues_count":724,"forks":1741,"open_issues":724,"watchers":4916,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Theano/Theano/pulls/5155"},"html":{"href":"https://github.com/Theano/Theano/pull/5155"},"issue":{"href":"https://api.github.com/repos/Theano/Theano/issues/5155"},"comments":{"href":"https://api.github.com/repos/Theano/Theano/issues/5155/comments"},"review_comments":{"href":"https://api.github.com/repos/Theano/Theano/pulls/5155/comments"},"review_comment":{"href":"https://api.github.com/repos/Theano/Theano/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Theano/Theano/pulls/5155/commits"},"statuses":{"href":"https://api.github.com/repos/Theano/Theano/statuses/8003d6b47b116c57344c42e694312397e52e446c"}}}}
{"actor":{"display_login":"sygi"}}