{"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/80590082","id":80590082,"diff_hunk":"@@ -435,7 +435,7 @@\n           :auto_select_single: false\n           :description: Name\n           :required_method: :validate_placement\n-          :required: true\n+          :required: false","path":"product/dialogs/miq_dialogs/miq_provision_vmware_dialogs_template.yaml","position":null,"original_position":5,"commit_id":"6d38ccc75d2b4423baedbc4e80a00543f21ded2a","original_commit_id":"2845e4868c3e217c47315accaac2cf626db2591a","user":{"login":"agrare","id":12851112,"avatar_url":"https://avatars.githubusercontent.com/u/12851112?v=3","gravatar_id":"","url":"https://api.github.com/users/agrare","html_url":"https://github.com/agrare","followers_url":"https://api.github.com/users/agrare/followers","following_url":"https://api.github.com/users/agrare/following{/other_user}","gists_url":"https://api.github.com/users/agrare/gists{/gist_id}","starred_url":"https://api.github.com/users/agrare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agrare/subscriptions","organizations_url":"https://api.github.com/users/agrare/orgs","repos_url":"https://api.github.com/users/agrare/repos","events_url":"https://api.github.com/users/agrare/events{/privacy}","received_events_url":"https://api.github.com/users/agrare/received_events","type":"User","site_admin":false},"body":"Yeah my misunderstanding didn't realize it was for local dev, removed.","created_at":"2016-09-26T22:45:23Z","updated_at":"2016-09-26T22:45:24Z","html_url":"https://github.com/ManageIQ/manageiq/pull/11437#discussion_r80590082","pull_request_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/11437","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/80590082"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/11437#discussion_r80590082"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/11437"}}},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/11437","id":86256753,"html_url":"https://github.com/ManageIQ/manageiq/pull/11437","diff_url":"https://github.com/ManageIQ/manageiq/pull/11437.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/11437.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/11437","number":11437,"state":"open","locked":false,"title":"Allow VMware provision without needing to specify a host","user":{"login":"agrare","id":12851112,"avatar_url":"https://avatars.githubusercontent.com/u/12851112?v=3","gravatar_id":"","url":"https://api.github.com/users/agrare","html_url":"https://github.com/agrare","followers_url":"https://api.github.com/users/agrare/followers","following_url":"https://api.github.com/users/agrare/following{/other_user}","gists_url":"https://api.github.com/users/agrare/gists{/gist_id}","starred_url":"https://api.github.com/users/agrare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agrare/subscriptions","organizations_url":"https://api.github.com/users/agrare/orgs","repos_url":"https://api.github.com/users/agrare/repos","events_url":"https://api.github.com/users/agrare/events{/privacy}","received_events_url":"https://api.github.com/users/agrare/received_events","type":"User","site_admin":false},"body":"This will allow a user to provision a VM to a VMware DRS-enabled cluster without having to specify a specific host.  This aligns MIQ provision workflow with the VMware cloning workflow when you have a DRS cluster.\r\n\r\n- [x] Lookup a host in the cluster to find the right storage ems_ref (https://github.com/ManageIQ/manageiq/blob/master/app/models/manageiq/providers/vmware/infra_manager/provision/cloning.rb#L113)\r\n\r\n- [x] Be able to use VDS switches/portgroups without having to lookup by host ems_ref (https://github.com/ManageIQ/manageiq/blob/master/app/models/manageiq/providers/vmware/infra_manager/provision/configuration/network.rb#L83)\r\n\r\n- [ ] Add validation to require a host if the selected cluster doesn't have DRS enabled\r\n\r\n- [ ] Add validation to require either a host or a cluster\r\n\r\nhttps://bugzilla.redhat.com/show_bug.cgi?id=1377975","created_at":"2016-09-21T23:05:01Z","updated_at":"2016-09-26T22:45:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0a3d3b929272d843214e2df052410055bc177d0e","assignee":{"login":"gmcculloug","id":2591569,"avatar_url":"https://avatars.githubusercontent.com/u/2591569?v=3","gravatar_id":"","url":"https://api.github.com/users/gmcculloug","html_url":"https://github.com/gmcculloug","followers_url":"https://api.github.com/users/gmcculloug/followers","following_url":"https://api.github.com/users/gmcculloug/following{/other_user}","gists_url":"https://api.github.com/users/gmcculloug/gists{/gist_id}","starred_url":"https://api.github.com/users/gmcculloug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmcculloug/subscriptions","organizations_url":"https://api.github.com/users/gmcculloug/orgs","repos_url":"https://api.github.com/users/gmcculloug/repos","events_url":"https://api.github.com/users/gmcculloug/events{/privacy}","received_events_url":"https://api.github.com/users/gmcculloug/received_events","type":"User","site_admin":false},"assignees":[{"login":"gmcculloug","id":2591569,"avatar_url":"https://avatars.githubusercontent.com/u/2591569?v=3","gravatar_id":"","url":"https://api.github.com/users/gmcculloug","html_url":"https://github.com/gmcculloug","followers_url":"https://api.github.com/users/gmcculloug/followers","following_url":"https://api.github.com/users/gmcculloug/following{/other_user}","gists_url":"https://api.github.com/users/gmcculloug/gists{/gist_id}","starred_url":"https://api.github.com/users/gmcculloug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmcculloug/subscriptions","organizations_url":"https://api.github.com/users/gmcculloug/orgs","repos_url":"https://api.github.com/users/gmcculloug/repos","events_url":"https://api.github.com/users/gmcculloug/events{/privacy}","received_events_url":"https://api.github.com/users/gmcculloug/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/11437/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/11437/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/11437/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/6d38ccc75d2b4423baedbc4e80a00543f21ded2a","head":{"label":"agrare:vmware_infra_provision_no_host","ref":"vmware_infra_provision_no_host","sha":"6d38ccc75d2b4423baedbc4e80a00543f21ded2a","user":{"login":"agrare","id":12851112,"avatar_url":"https://avatars.githubusercontent.com/u/12851112?v=3","gravatar_id":"","url":"https://api.github.com/users/agrare","html_url":"https://github.com/agrare","followers_url":"https://api.github.com/users/agrare/followers","following_url":"https://api.github.com/users/agrare/following{/other_user}","gists_url":"https://api.github.com/users/agrare/gists{/gist_id}","starred_url":"https://api.github.com/users/agrare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agrare/subscriptions","organizations_url":"https://api.github.com/users/agrare/orgs","repos_url":"https://api.github.com/users/agrare/repos","events_url":"https://api.github.com/users/agrare/events{/privacy}","received_events_url":"https://api.github.com/users/agrare/received_events","type":"User","site_admin":false},"repo":{"id":42064030,"name":"manageiq","full_name":"agrare/manageiq","owner":{"login":"agrare","id":12851112,"avatar_url":"https://avatars.githubusercontent.com/u/12851112?v=3","gravatar_id":"","url":"https://api.github.com/users/agrare","html_url":"https://github.com/agrare","followers_url":"https://api.github.com/users/agrare/followers","following_url":"https://api.github.com/users/agrare/following{/other_user}","gists_url":"https://api.github.com/users/agrare/gists{/gist_id}","starred_url":"https://api.github.com/users/agrare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agrare/subscriptions","organizations_url":"https://api.github.com/users/agrare/orgs","repos_url":"https://api.github.com/users/agrare/repos","events_url":"https://api.github.com/users/agrare/events{/privacy}","received_events_url":"https://api.github.com/users/agrare/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/agrare/manageiq","description":"ManageIQ Cloud Management Platform","fork":true,"url":"https://api.github.com/repos/agrare/manageiq","forks_url":"https://api.github.com/repos/agrare/manageiq/forks","keys_url":"https://api.github.com/repos/agrare/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/agrare/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/agrare/manageiq/teams","hooks_url":"https://api.github.com/repos/agrare/manageiq/hooks","issue_events_url":"https://api.github.com/repos/agrare/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/agrare/manageiq/events","assignees_url":"https://api.github.com/repos/agrare/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/agrare/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/agrare/manageiq/tags","blobs_url":"https://api.github.com/repos/agrare/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/agrare/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/agrare/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/agrare/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/agrare/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/agrare/manageiq/languages","stargazers_url":"https://api.github.com/repos/agrare/manageiq/stargazers","contributors_url":"https://api.github.com/repos/agrare/manageiq/contributors","subscribers_url":"https://api.github.com/repos/agrare/manageiq/subscribers","subscription_url":"https://api.github.com/repos/agrare/manageiq/subscription","commits_url":"https://api.github.com/repos/agrare/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/agrare/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/agrare/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/agrare/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/agrare/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/agrare/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/agrare/manageiq/merges","archive_url":"https://api.github.com/repos/agrare/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/agrare/manageiq/downloads","issues_url":"https://api.github.com/repos/agrare/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/agrare/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/agrare/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/agrare/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/agrare/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/agrare/manageiq/releases{/id}","deployments_url":"https://api.github.com/repos/agrare/manageiq/deployments","created_at":"2015-09-07T16:40:33Z","updated_at":"2016-02-08T20:35:54Z","pushed_at":"2016-09-26T22:44:40Z","git_url":"git://github.com/agrare/manageiq.git","ssh_url":"git@github.com:agrare/manageiq.git","clone_url":"https://github.com/agrare/manageiq.git","svn_url":"https://github.com/agrare/manageiq","homepage":"manageiq.org","size":187266,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"c73122c72b122c7a672bb7cb5965dc6ee1bc5cbb","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":20789757,"name":"manageiq","full_name":"ManageIQ/manageiq","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq","description":"ManageIQ Open-Source Management Platform","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq","forks_url":"https://api.github.com/repos/ManageIQ/manageiq/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq/releases{/id}","deployments_url":"https://api.github.com/repos/ManageIQ/manageiq/deployments","created_at":"2014-06-13T02:31:26Z","updated_at":"2016-09-26T11:44:17Z","pushed_at":"2016-09-26T22:44:42Z","git_url":"git://github.com/ManageIQ/manageiq.git","ssh_url":"git@github.com:ManageIQ/manageiq.git","clone_url":"https://github.com/ManageIQ/manageiq.git","svn_url":"https://github.com/ManageIQ/manageiq","homepage":"manageiq.org","size":205735,"stargazers_count":330,"watchers_count":330,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":350,"mirror_url":null,"open_issues_count":851,"forks":350,"open_issues":851,"watchers":330,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/11437"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/11437"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/11437"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/11437/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/11437/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/11437/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq/statuses/6d38ccc75d2b4423baedbc4e80a00543f21ded2a"}}}}
{"actor":{"display_login":"agrare"}}