{"push_id":1455516598,"size":2,"distinct_size":2,"ref":"refs/heads/master","head":"a5305812ae73daa4e0d46bdadd6dcf8404eaab6f","before":"ec2da622445072c4f8e9cf387e0b07b4d8d648a1","commits":[{"sha":"06362416af9ce487bbdf09a30bd7773806939ac2","author":{"name":"eocanha@igalia.com","email":"4913cc2b4f3f620d569fa169400c774de848a8c3@igalia.com"},"message":"[GStreamer][MSE] Fix player private selection when MSE is enabled\nhttps://bugs.webkit.org/show_bug.cgi?id=164116\n\nReviewed by Philippe Normand.\n\nCovered by existing tests.\n\n* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:\n(WebCore::MediaPlayerPrivateGStreamer::load):\n* platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp:\n(WebCore::MediaPlayerPrivateGStreamerMSE::load):\n\n\ngit-svn-id: http://svn.webkit.org/repository/webkit/trunk@209796 268f45cc-cd09-0410-ab3c-d52691b4dbfc","distinct":true,"url":"https://api.github.com/repos/WebKit/webkit/commits/06362416af9ce487bbdf09a30bd7773806939ac2"},{"sha":"a5305812ae73daa4e0d46bdadd6dcf8404eaab6f","author":{"name":"eocanha@igalia.com","email":"4913cc2b4f3f620d569fa169400c774de848a8c3@igalia.com"},"message":"REGRESSION(r207879-207891): [GStreamer] Introduced many layout test failures and crashes, bots exiting early\nhttps://bugs.webkit.org/show_bug.cgi?id=164022\n\nReviewed by Xabier Rodriguez-Calvar.\n\nSource/WebCore:\n\nCovered by existing tests.\n\n* page/Settings.cpp:\nAdded new setting to disable GStreamer players, so the selection of\nMockMediaPlayerMediaSource can be forced for some tests, just like\nit's already being done for the AVFoundation player in Mac.\n(WebCore::Settings::setGStreamerEnabled):\n* page/Settings.h:\n(WebCore::Settings::isGStreamerEnabled):\n* platform/graphics/MediaPlayer.cpp:\n(WebCore::buildMediaEnginesVector):\nDon't register GStreamer players when they're disabled.\n* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:\n(WebCore::MediaPlayerPrivateGStreamer::durationMediaTime):\nUse doubles instead of floats.\n* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:\nUse doubles instead of floats for m_durationAtEOS.\n* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:\nDon't reset m_sample on videoSink drain, it causes too many problems.\n(WebCore::MediaPlayerPrivateGStreamerBase::createVideoSink):\n* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:\nRemoved unused methods.\n* platform/graphics/gstreamer/VideoSinkGStreamer.cpp:\nKeep releasing m_sample on drain, but don't report the event\nexternally via signal anymore. The base player private isn't\nlistening to it anymore.\n(webkitVideoSinkEvent):\n(webkit_video_sink_class_init):\n* platform/graphics/gstreamer/mse/AppendPipeline.cpp:\n(WebCore::AppendPipeline::parseDemuxerSrcPadCaps):\nCheck if the demuxer caps correspond to a supported codec.\n(WebCore::AppendPipeline::didReceiveInitializationSegment):\nEmpty m_track is now legal and means unsupported codec.\n(WebCore::AppendPipeline::connectDemuxerSrcPadToAppsinkFromAnyThread):\nWarn about more than one stream, but \"support\" it by ignoring it using\na black hole probe.\n(WebCore::AppendPipeline::connectDemuxerSrcPadToAppsink):\nAlso report the duration when it's detected for the first time. Invalid\nstream types now mean that unsupported codecs have been detected.\nComplete init segment processing in that case.\n(WebCore::AppendPipeline::disconnectDemuxerSrcPadFromAppsinkFromAnyThread):\nDisconnect black hole probe.\n(WebCore::appendPipelineDemuxerBlackHolePadProbe): Ignore buffers.\n(WebCore::appendPipelineDemuxerPadRemoved): New parameter used.\n* platform/graphics/gstreamer/mse/AppendPipeline.h:\n* platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp:\n(WebCore::MediaPlayerPrivateGStreamerMSE::supportsCodecs):\nCheck supported codecs by matching against wildcard expressions.\n(WebCore::MediaPlayerPrivateGStreamerMSE::supportsType):\nCheck for supported codecs.\n* platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.h:\nNew supportsCodecs() method.\n* platform/graphics/gstreamer/mse/MediaSourceClientGStreamerMSE.cpp:\n(WebCore::MediaSourceClientGStreamerMSE::resetParserState):\nImplemented parser resetting by aborting the AppendPipeline.\n* platform/graphics/gstreamer/mse/MediaSourceClientGStreamerMSE.h:\nAdded resetParserState().\n* platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.cpp:\n(WebCore::SourceBufferPrivateGStreamer::resetParserState):\nImplemented it.\n* testing/Internals.cpp:\n(WebCore::Internals::initializeMockMediaSource):\nDisable the GStreamer players when initializing the mock media source,\nlike it's already done for the AVFoundation player to force the\nselection of MockMediaPlayerMediaSource.\n\nSource/WebKit2:\n\n* Shared/WebPreferencesDefinitions.h:\nNew GStreamerEnabled preference, defaults to true.\n* WebProcess/WebPage/WebPage.cpp: Ditto.\n(WebKit::WebPage::updatePreferences):\n\nSource/WTF:\n\n* wtf/glib/GLibUtilities.h:\nAdded new macros to convert gulong to/from gpointer.\n\nTools:\n\n* Scripts/webkitperl/FeatureList.pm:\n  Re-enable MEDIA_SOURCE for the GTK+ port.\n\nLayoutTests:\n\n* media/media-source/media-source-resize-expected.txt:\nExpect the resize event.\n* media/media-source/media-source-resize.html:\nThe test now succeeds no matter if the dimension is reported after\nprocessing the init-segment (GTK+ case) or after the media segment\nis processed (Mac case).\n* platform/gtk/TestExpectations:\nReenabled all the media/media-source tests except one.\n* platform/gtk/media/media-source/media-source-resize-expected.txt:\nCopied from LayoutTests/media/media-source/media-source-resize-expected.txt.\nThe right dimensions are received earlier than in Mac.\n\n\ngit-svn-id: http://svn.webkit.org/repository/webkit/trunk@209797 268f45cc-cd09-0410-ab3c-d52691b4dbfc","distinct":true,"url":"https://api.github.com/repos/WebKit/webkit/commits/a5305812ae73daa4e0d46bdadd6dcf8404eaab6f"}]}
{"actor":{"display_login":"hubot"}}