{"action":"created","issue":{"url":"https://api.github.com/repos/CookPete/react-player/issues/65","repository_url":"https://api.github.com/repos/CookPete/react-player","labels_url":"https://api.github.com/repos/CookPete/react-player/issues/65/labels{/name}","comments_url":"https://api.github.com/repos/CookPete/react-player/issues/65/comments","events_url":"https://api.github.com/repos/CookPete/react-player/issues/65/events","html_url":"https://github.com/CookPete/react-player/pull/65","id":155956327,"number":65,"title":"SoundCloud to extend FilePlayer (and get rid of sc sdk)","user":{"login":"denisflorkin","id":10850995,"avatar_url":"https://avatars.githubusercontent.com/u/10850995?v=3","gravatar_id":"","url":"https://api.github.com/users/denisflorkin","html_url":"https://github.com/denisflorkin","followers_url":"https://api.github.com/users/denisflorkin/followers","following_url":"https://api.github.com/users/denisflorkin/following{/other_user}","gists_url":"https://api.github.com/users/denisflorkin/gists{/gist_id}","starred_url":"https://api.github.com/users/denisflorkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/denisflorkin/subscriptions","organizations_url":"https://api.github.com/users/denisflorkin/orgs","repos_url":"https://api.github.com/users/denisflorkin/repos","events_url":"https://api.github.com/users/denisflorkin/events{/privacy}","received_events_url":"https://api.github.com/users/denisflorkin/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-05-20T12:52:15Z","updated_at":"2016-05-21T16:18:11Z","closed_at":"2016-05-21T16:18:11Z","pull_request":{"url":"https://api.github.com/repos/CookPete/react-player/pulls/65","html_url":"https://github.com/CookPete/react-player/pull/65","diff_url":"https://github.com/CookPete/react-player/pull/65.diff","patch_url":"https://github.com/CookPete/react-player/pull/65.patch"},"body":"Hello, from @CookPete suggestion I finally got somewhere with removing the need for sc sdk and removing most of the code from `SoundCloud`. The test passes (although only in chrome as I still haven't resolved my test env. issue...)\r\n\r\nOne weird thing is that I can get the sc stream into a `<audio>` but it does not work, and it works like a charm in a `<video>` I'm missing something somewhere...\r\n\r\nAnyway not sure if My PR is really helping or if it's more a cry for a free lessons on react and classical inheritance....\r\n\r\n\r\n\r\nAnyway here it is :)\r\n"},"comment":{"url":"https://api.github.com/repos/CookPete/react-player/issues/comments/220786541","html_url":"https://github.com/CookPete/react-player/pull/65#issuecomment-220786541","issue_url":"https://api.github.com/repos/CookPete/react-player/issues/65","id":220786541,"user":{"login":"CookPete","id":1926029,"avatar_url":"https://avatars.githubusercontent.com/u/1926029?v=3","gravatar_id":"","url":"https://api.github.com/users/CookPete","html_url":"https://github.com/CookPete","followers_url":"https://api.github.com/users/CookPete/followers","following_url":"https://api.github.com/users/CookPete/following{/other_user}","gists_url":"https://api.github.com/users/CookPete/gists{/gist_id}","starred_url":"https://api.github.com/users/CookPete/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CookPete/subscriptions","organizations_url":"https://api.github.com/users/CookPete/orgs","repos_url":"https://api.github.com/users/CookPete/repos","events_url":"https://api.github.com/users/CookPete/events{/privacy}","received_events_url":"https://api.github.com/users/CookPete/received_events","type":"User","site_admin":false},"created_at":"2016-05-21T16:18:11Z","updated_at":"2016-05-21T16:18:11Z","body":"https://github.com/CookPete/react-player/commit/5393343a231ef4905271023c3e50a62fb8bec72e is merged now so I'll close this off. Thanks for the PR!"}}
{"actor":{"display_login":"CookPete"}}