{"action":"created","issue":{"url":"https://api.github.com/repos/ovr/phpsa/issues/139","repository_url":"https://api.github.com/repos/ovr/phpsa","labels_url":"https://api.github.com/repos/ovr/phpsa/issues/139/labels{/name}","comments_url":"https://api.github.com/repos/ovr/phpsa/issues/139/comments","events_url":"https://api.github.com/repos/ovr/phpsa/issues/139/events","html_url":"https://github.com/ovr/phpsa/pull/139","id":177593212,"number":139,"title":"Allow analyzers to be configured","user":{"login":"K-Phoen","id":66958,"avatar_url":"https://avatars.githubusercontent.com/u/66958?v=3","gravatar_id":"","url":"https://api.github.com/users/K-Phoen","html_url":"https://github.com/K-Phoen","followers_url":"https://api.github.com/users/K-Phoen/followers","following_url":"https://api.github.com/users/K-Phoen/following{/other_user}","gists_url":"https://api.github.com/users/K-Phoen/gists{/gist_id}","starred_url":"https://api.github.com/users/K-Phoen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/K-Phoen/subscriptions","organizations_url":"https://api.github.com/users/K-Phoen/orgs","repos_url":"https://api.github.com/users/K-Phoen/repos","events_url":"https://api.github.com/users/K-Phoen/events{/privacy}","received_events_url":"https://api.github.com/users/K-Phoen/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2016-09-17T17:29:38Z","updated_at":"2016-09-22T17:50:56Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ovr/phpsa/pulls/139","html_url":"https://github.com/ovr/phpsa/pull/139","diff_url":"https://github.com/ovr/phpsa/pull/139.diff","patch_url":"https://github.com/ovr/phpsa/pull/139.patch"},"body":"I implemented a simple way to make analyzers configurable.\r\n\r\nThey can define their own configuration, that will be merged in the global one. This configuration is used to determine if the analyzer pass is enabled or not. When the analyzer is instantiated, its configuration is injected through the constructor.\r\n\r\nI also added a new command to dump the default configuration: `./bin/phpsa config:dump-reference`\r\n\r\nWDYT?"},"comment":{"url":"https://api.github.com/repos/ovr/phpsa/issues/comments/248977360","html_url":"https://github.com/ovr/phpsa/pull/139#issuecomment-248977360","issue_url":"https://api.github.com/repos/ovr/phpsa/issues/139","id":248977360,"user":{"login":"K-Phoen","id":66958,"avatar_url":"https://avatars.githubusercontent.com/u/66958?v=3","gravatar_id":"","url":"https://api.github.com/users/K-Phoen","html_url":"https://github.com/K-Phoen","followers_url":"https://api.github.com/users/K-Phoen/followers","following_url":"https://api.github.com/users/K-Phoen/following{/other_user}","gists_url":"https://api.github.com/users/K-Phoen/gists{/gist_id}","starred_url":"https://api.github.com/users/K-Phoen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/K-Phoen/subscriptions","organizations_url":"https://api.github.com/users/K-Phoen/orgs","repos_url":"https://api.github.com/users/K-Phoen/repos","events_url":"https://api.github.com/users/K-Phoen/events{/privacy}","received_events_url":"https://api.github.com/users/K-Phoen/received_events","type":"User","site_admin":false},"created_at":"2016-09-22T17:50:56Z","updated_at":"2016-09-22T17:50:56Z","body":"You're right, but to me, that looks more like a coincidence ;)\r\nIn an analyzer, I expect the context to hold compilation-related context such as the variable accessible from the current scope, this kind of stuff. Accessing the global configuration through it seem a bit weird to me (and it breaks Demeter's law btw)."}}
{"actor":{"display_login":"K-Phoen"}}