{"action":"created","issue":{"url":"https://api.github.com/repos/mrjbq7/ta-lib/issues/108","repository_url":"https://api.github.com/repos/mrjbq7/ta-lib","labels_url":"https://api.github.com/repos/mrjbq7/ta-lib/issues/108/labels{/name}","comments_url":"https://api.github.com/repos/mrjbq7/ta-lib/issues/108/comments","events_url":"https://api.github.com/repos/mrjbq7/ta-lib/issues/108/events","html_url":"https://github.com/mrjbq7/ta-lib/pull/108","id":168012462,"number":108,"title":"Fix the build issue on Windows 8.1. The ta-lib-0.4.0-msvc.zip is unzi…","user":{"login":"ForrestFeng","id":5875631,"avatar_url":"https://avatars.githubusercontent.com/u/5875631?v=3","gravatar_id":"","url":"https://api.github.com/users/ForrestFeng","html_url":"https://github.com/ForrestFeng","followers_url":"https://api.github.com/users/ForrestFeng/followers","following_url":"https://api.github.com/users/ForrestFeng/following{/other_user}","gists_url":"https://api.github.com/users/ForrestFeng/gists{/gist_id}","starred_url":"https://api.github.com/users/ForrestFeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ForrestFeng/subscriptions","organizations_url":"https://api.github.com/users/ForrestFeng/orgs","repos_url":"https://api.github.com/users/ForrestFeng/repos","events_url":"https://api.github.com/users/ForrestFeng/events{/privacy}","received_events_url":"https://api.github.com/users/ForrestFeng/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-07-28T04:39:08Z","updated_at":"2016-07-28T11:33:06Z","closed_at":"2016-07-28T11:33:06Z","pull_request":{"url":"https://api.github.com/repos/mrjbq7/ta-lib/pulls/108","html_url":"https://github.com/mrjbq7/ta-lib/pull/108","diff_url":"https://github.com/mrjbq7/ta-lib/pull/108.diff","patch_url":"https://github.com/mrjbq7/ta-lib/pull/108.patch"},"body":"…ped to C:\\ta-lib correctly and I have VS2015 installsed\r\n\r\nRecreate steps:\r\n----------------------------------------\r\n1. Install python with Miniconda3-latest-Windows-x86.exe\r\n2. Run \"conda insatll numpy\" to install numpy package\r\n3. Run \"python setup.py install\" to install talib\r\n\r\ngot the following error:\r\n-----------------------------------------\r\n$ python setup.py install\r\nrunning install\r\nrunning build\r\nrunning build_py\r\nrunning build_ext\r\nbuilding 'talib.stream' extension\r\nC:\\Program Files (x86)\\Microsoft Visual Studio 14.0\\VC\\BIN\\cl.exe /c /nologo /Ox /W3 /GL /DNDEBUG /MD -IC:\\Miniconda3\r\n\\lib\\site-packages\\numpy\\core\\include -Ic:\\ta-lib\\c\\include -IC:\\Miniconda3\\include -IC:\\Miniconda3\\include \"-IC:\\Pro\r\ngram Files (x86)\\Microsoft Visual Studio 14.0\\VC\\INCLUDE\" \"-IC:\\Program Files (x86)\\Microsoft Visual Studio 14.0\\VC\\A\r\nTLMFC\\INCLUDE\" \"-IC:\\Program Files (x86)\\Windows Kits\\10\\include\\10.0.10586.0\\ucrt\" \"-IC:\\Program Files (x86)\\Windows\r\n Kits\\NETFXSDK\\4.6.1\\include\\um\" \"-IC:\\Program Files (x86)\\Windows Kits\\10\\include\\10.0.10586.0\\shared\" \"-IC:\\Program\r\n Files (x86)\\Windows Kits\\10\\include\\10.0.10586.0\\um\" \"-IC:\\Program Files (x86)\\Windows Kits\\10\\include\\10.0.10586.0\\\r\nwinrt\" /Tctalib/stream.c /Fobuild\\temp.win32-3.5\\Release\\talib/stream.obj\r\nstream.c\r\nc:\\miniconda3\\lib\\site-packages\\numpy\\core\\include\\numpy\\npy_1_7_deprecated_api.h(12) : Warning Msg: Using deprecated\r\n NumPy API, disable it by #defining NPY_NO_DEPRECATED_API NPY_1_7_API_VERSION\r\ntalib/stream.c(276): fatal error C1083: Cannot open include file: 'ta-lib/ta_defs.h': No such file or directory\r\nerror: command 'C:\\\\Program Files (x86)\\\\Microsoft Visual Studio 14.0\\\\VC\\\\BIN\\\\cl.exe' failed with exit status 2\r\n\r\nFix\r\n---------------------------------------------\r\nThe folder of c:\\ta-lib\\c\\include is in the hearder file search path. And the  ta_defs.h header is there.\r\nThe error is that the  #include \"ta-lib/ta_defs.h\" had redundent path of ta-lib/. After removing it the build error is away."},"comment":{"url":"https://api.github.com/repos/mrjbq7/ta-lib/issues/comments/235870083","html_url":"https://github.com/mrjbq7/ta-lib/pull/108#issuecomment-235870083","issue_url":"https://api.github.com/repos/mrjbq7/ta-lib/issues/108","id":235870083,"user":{"login":"ForrestFeng","id":5875631,"avatar_url":"https://avatars.githubusercontent.com/u/5875631?v=3","gravatar_id":"","url":"https://api.github.com/users/ForrestFeng","html_url":"https://github.com/ForrestFeng","followers_url":"https://api.github.com/users/ForrestFeng/followers","following_url":"https://api.github.com/users/ForrestFeng/following{/other_user}","gists_url":"https://api.github.com/users/ForrestFeng/gists{/gist_id}","starred_url":"https://api.github.com/users/ForrestFeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ForrestFeng/subscriptions","organizations_url":"https://api.github.com/users/ForrestFeng/orgs","repos_url":"https://api.github.com/users/ForrestFeng/repos","events_url":"https://api.github.com/users/ForrestFeng/events{/privacy}","received_events_url":"https://api.github.com/users/ForrestFeng/received_events","type":"User","site_admin":false},"created_at":"2016-07-28T11:33:06Z","updated_at":"2016-07-28T11:33:06Z","body":"This commit may not fix the build issue on Windows permanently.  There should be a better way to fix the header file cannot be found issue."}}
{"actor":{"display_login":"ForrestFeng"}}