{"action":"created","issue":{"url":"https://api.github.com/repos/python-hyper/hpack/issues/69","repository_url":"https://api.github.com/repos/python-hyper/hpack","labels_url":"https://api.github.com/repos/python-hyper/hpack/issues/69/labels{/name}","comments_url":"https://api.github.com/repos/python-hyper/hpack/issues/69/comments","events_url":"https://api.github.com/repos/python-hyper/hpack/issues/69/events","html_url":"https://github.com/python-hyper/hpack/pull/69","id":181945044,"number":69,"title":"Test dynamic table shrinks correctly","user":{"login":"dshafik","id":58074,"avatar_url":"https://avatars.githubusercontent.com/u/58074?v=3","gravatar_id":"","url":"https://api.github.com/users/dshafik","html_url":"https://github.com/dshafik","followers_url":"https://api.github.com/users/dshafik/followers","following_url":"https://api.github.com/users/dshafik/following{/other_user}","gists_url":"https://api.github.com/users/dshafik/gists{/gist_id}","starred_url":"https://api.github.com/users/dshafik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dshafik/subscriptions","organizations_url":"https://api.github.com/users/dshafik/orgs","repos_url":"https://api.github.com/users/dshafik/repos","events_url":"https://api.github.com/users/dshafik/events{/privacy}","received_events_url":"https://api.github.com/users/dshafik/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"SethMichaelLarson","id":18519037,"avatar_url":"https://avatars.githubusercontent.com/u/18519037?v=3","gravatar_id":"","url":"https://api.github.com/users/SethMichaelLarson","html_url":"https://github.com/SethMichaelLarson","followers_url":"https://api.github.com/users/SethMichaelLarson/followers","following_url":"https://api.github.com/users/SethMichaelLarson/following{/other_user}","gists_url":"https://api.github.com/users/SethMichaelLarson/gists{/gist_id}","starred_url":"https://api.github.com/users/SethMichaelLarson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SethMichaelLarson/subscriptions","organizations_url":"https://api.github.com/users/SethMichaelLarson/orgs","repos_url":"https://api.github.com/users/SethMichaelLarson/repos","events_url":"https://api.github.com/users/SethMichaelLarson/events{/privacy}","received_events_url":"https://api.github.com/users/SethMichaelLarson/received_events","type":"User","site_admin":false},"assignees":[{"login":"SethMichaelLarson","id":18519037,"avatar_url":"https://avatars.githubusercontent.com/u/18519037?v=3","gravatar_id":"","url":"https://api.github.com/users/SethMichaelLarson","html_url":"https://github.com/SethMichaelLarson","followers_url":"https://api.github.com/users/SethMichaelLarson/followers","following_url":"https://api.github.com/users/SethMichaelLarson/following{/other_user}","gists_url":"https://api.github.com/users/SethMichaelLarson/gists{/gist_id}","starred_url":"https://api.github.com/users/SethMichaelLarson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SethMichaelLarson/subscriptions","organizations_url":"https://api.github.com/users/SethMichaelLarson/orgs","repos_url":"https://api.github.com/users/SethMichaelLarson/repos","events_url":"https://api.github.com/users/SethMichaelLarson/events{/privacy}","received_events_url":"https://api.github.com/users/SethMichaelLarson/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2016-10-10T06:37:25Z","updated_at":"2016-10-11T20:03:00Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/python-hyper/hpack/pulls/69","html_url":"https://github.com/python-hyper/hpack/pull/69","diff_url":"https://github.com/python-hyper/hpack/pull/69.diff","patch_url":"https://github.com/python-hyper/hpack/pull/69.patch"},"body":"- Test that it correctly resizes the `dynamic_entries` to the largest size that will fit the new `max_size`, and sets the `_current_size` accordingly\r\n- Some `b'TestValue'` and `b'TestName'` values were switched"},"comment":{"url":"https://api.github.com/repos/python-hyper/hpack/issues/comments/253028948","html_url":"https://github.com/python-hyper/hpack/pull/69#issuecomment-253028948","issue_url":"https://api.github.com/repos/python-hyper/hpack/issues/69","id":253028948,"user":{"login":"SethMichaelLarson","id":18519037,"avatar_url":"https://avatars.githubusercontent.com/u/18519037?v=3","gravatar_id":"","url":"https://api.github.com/users/SethMichaelLarson","html_url":"https://github.com/SethMichaelLarson","followers_url":"https://api.github.com/users/SethMichaelLarson/followers","following_url":"https://api.github.com/users/SethMichaelLarson/following{/other_user}","gists_url":"https://api.github.com/users/SethMichaelLarson/gists{/gist_id}","starred_url":"https://api.github.com/users/SethMichaelLarson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SethMichaelLarson/subscriptions","organizations_url":"https://api.github.com/users/SethMichaelLarson/orgs","repos_url":"https://api.github.com/users/SethMichaelLarson/repos","events_url":"https://api.github.com/users/SethMichaelLarson/events{/privacy}","received_events_url":"https://api.github.com/users/SethMichaelLarson/received_events","type":"User","site_admin":false},"created_at":"2016-10-11T20:03:00Z","updated_at":"2016-10-11T20:03:00Z","body":"@dshafik @Lukasa I've found the problem, it is in your code you use the attribute `max_size` where the attribute is actually `maxsize`. Change that and you should see the table shrink properly. I still agree with adding this test for shrinking though."}}
{"actor":{"display_login":"SethMichaelLarson"}}