{"action":"created","issue":{"url":"https://api.github.com/repos/cake-build/cake/issues/1125","repository_url":"https://api.github.com/repos/cake-build/cake","labels_url":"https://api.github.com/repos/cake-build/cake/issues/1125/labels{/name}","comments_url":"https://api.github.com/repos/cake-build/cake/issues/1125/comments","events_url":"https://api.github.com/repos/cake-build/cake/issues/1125/events","html_url":"https://github.com/cake-build/cake/pull/1125","id":167660712,"number":1125,"title":"GH1112: Refactor AppVeyorProvider to be a Tool<TSettings>-based tool","user":{"login":"agc93","id":1369269,"avatar_url":"https://avatars.githubusercontent.com/u/1369269?v=3","gravatar_id":"","url":"https://api.github.com/users/agc93","html_url":"https://github.com/agc93","followers_url":"https://api.github.com/users/agc93/followers","following_url":"https://api.github.com/users/agc93/following{/other_user}","gists_url":"https://api.github.com/users/agc93/gists{/gist_id}","starred_url":"https://api.github.com/users/agc93/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agc93/subscriptions","organizations_url":"https://api.github.com/users/agc93/orgs","repos_url":"https://api.github.com/users/agc93/repos","events_url":"https://api.github.com/users/agc93/events{/privacy}","received_events_url":"https://api.github.com/users/agc93/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/cake-build/cake/labels/cla-signed","name":"cla-signed","color":"207de5"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2016-07-26T17:08:06Z","updated_at":"2016-07-27T20:17:55Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cake-build/cake/pulls/1125","html_url":"https://github.com/cake-build/cake/pull/1125","diff_url":"https://github.com/cake-build/cake/pull/1125.diff","patch_url":"https://github.com/cake-build/cake/pull/1125.patch"},"body":"This resolves #1112 which was raised in response to #1097 .\r\n\r\nThis is \"minimum required\" refactoring of `AppVeyorProvider` to correctly inherit from `Tool<TSettings>` mostly to enable correct exit code handling etc.\r\n\r\nI have also removed the constructor tests since those null checks are now happening in the base class.\r\n\r\nLet me know if any changes need to be made, or if you'd prefer to wait and do a more holistic refactoring.\r\n"},"comment":{"url":"https://api.github.com/repos/cake-build/cake/issues/comments/235707277","html_url":"https://github.com/cake-build/cake/pull/1125#issuecomment-235707277","issue_url":"https://api.github.com/repos/cake-build/cake/issues/1125","id":235707277,"user":{"login":"gep13","id":1271146,"avatar_url":"https://avatars.githubusercontent.com/u/1271146?v=3","gravatar_id":"","url":"https://api.github.com/users/gep13","html_url":"https://github.com/gep13","followers_url":"https://api.github.com/users/gep13/followers","following_url":"https://api.github.com/users/gep13/following{/other_user}","gists_url":"https://api.github.com/users/gep13/gists{/gist_id}","starred_url":"https://api.github.com/users/gep13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gep13/subscriptions","organizations_url":"https://api.github.com/users/gep13/orgs","repos_url":"https://api.github.com/users/gep13/repos","events_url":"https://api.github.com/users/gep13/events{/privacy}","received_events_url":"https://api.github.com/users/gep13/received_events","type":"User","site_admin":false},"created_at":"2016-07-27T20:17:55Z","updated_at":"2016-07-27T20:17:55Z","body":"@philo there already is an AppVeyor addin which further extends the DSL for AppVeyor:\r\n\r\nhttps://github.com/Redth/Cake.AppVeyor"}}
{"actor":{"display_login":"gep13"}}