{"action":"created","comment":{"url":"https://api.github.com/repos/Mierdin/todd/pulls/comments/63117510","id":63117510,"diff_hunk":"@@ -1,5 +1,4 @@\n *temp*\n-assets/","path":".gitignore","position":2,"original_position":2,"commit_id":"d451b31ecbb8154646180e52c0d3bfb9903df362","original_commit_id":"d451b31ecbb8154646180e52c0d3bfb9903df362","user":{"login":"vcabbage","id":10789027,"avatar_url":"https://avatars.githubusercontent.com/u/10789027?v=3","gravatar_id":"","url":"https://api.github.com/users/vcabbage","html_url":"https://github.com/vcabbage","followers_url":"https://api.github.com/users/vcabbage/followers","following_url":"https://api.github.com/users/vcabbage/following{/other_user}","gists_url":"https://api.github.com/users/vcabbage/gists{/gist_id}","starred_url":"https://api.github.com/users/vcabbage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vcabbage/subscriptions","organizations_url":"https://api.github.com/users/vcabbage/orgs","repos_url":"https://api.github.com/users/vcabbage/repos","events_url":"https://api.github.com/users/vcabbage/events{/privacy}","received_events_url":"https://api.github.com/users/vcabbage/received_events","type":"User","site_admin":false},"body":">I want to preserve that bit that allows someone to pop a new one in the directory on the server and have it get served once todd-server is restarted.\r\n\r\nThat's where I'm confused. In [assets.go](https://github.com/Mierdin/todd/blob/9fdd982f36bd474d18501ff4bad7d8d03ad6a5e4/server/assets.go), it never reads and hashes files that already exist in the directories, so it would never instruct the agents to download them, right?","created_at":"2016-05-13T00:14:21Z","updated_at":"2016-05-13T00:14:21Z","html_url":"https://github.com/Mierdin/todd/pull/22#discussion_r63117510","pull_request_url":"https://api.github.com/repos/Mierdin/todd/pulls/22","_links":{"self":{"href":"https://api.github.com/repos/Mierdin/todd/pulls/comments/63117510"},"html":{"href":"https://github.com/Mierdin/todd/pull/22#discussion_r63117510"},"pull_request":{"href":"https://api.github.com/repos/Mierdin/todd/pulls/22"}}},"pull_request":{"url":"https://api.github.com/repos/Mierdin/todd/pulls/22","id":69253386,"html_url":"https://github.com/Mierdin/todd/pull/22","diff_url":"https://github.com/Mierdin/todd/pull/22.diff","patch_url":"https://github.com/Mierdin/todd/pull/22.patch","issue_url":"https://api.github.com/repos/Mierdin/todd/issues/22","number":22,"state":"open","locked":false,"title":"Simplify getting started with ToDD","user":{"login":"vcabbage","id":10789027,"avatar_url":"https://avatars.githubusercontent.com/u/10789027?v=3","gravatar_id":"","url":"https://api.github.com/users/vcabbage","html_url":"https://github.com/vcabbage","followers_url":"https://api.github.com/users/vcabbage/followers","following_url":"https://api.github.com/users/vcabbage/following{/other_user}","gists_url":"https://api.github.com/users/vcabbage/gists{/gist_id}","starred_url":"https://api.github.com/users/vcabbage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vcabbage/subscriptions","organizations_url":"https://api.github.com/users/vcabbage/orgs","repos_url":"https://api.github.com/users/vcabbage/repos","events_url":"https://api.github.com/users/vcabbage/events{/privacy}","received_events_url":"https://api.github.com/users/vcabbage/received_events","type":"User","site_admin":false},"body":"Re: our conversation at Interop. I made some changes to make it somewhat easier to get started testing ToDD. I figured it would be easiest to open a PR and discuss the changes here. I'm happy to revert any changes you don't want.\r\n\r\nThis depends on vendoring changes in #21.\r\n\r\nA simple environment can be run with the following commands:\r\n```\r\n# vagrant up\r\n[ lots of output]\r\n# vagrant ssh\r\n# make start\r\n[ lots of output]\r\n# todd agents\r\nUUID\t\tEXPIRES\tADDR\t\tFACT SUMMARY\t\tCOLLECTOR SUMMARY\r\n0fe5a7b3d9c0\t17s\t172.18.0.9\tHostname, Addresses\tget_addresses, get_hostname\r\nfcee5456cdda\t16s\t172.18.0.7\tAddresses, Hostname\tget_addresses, get_hostname\r\n98e8c8bb1e8b\t17s\t172.18.0.8\tAddresses, Hostname\tget_addresses, get_hostname\r\n```\r\n\r\n* Makes ToDD \"go gettable\". `go get github.com/Mierdin/todd/...`\r\n  pulls code and builds binaries into `$GOPATH/bin`.\r\n* Removed (what I believe to be) no longer necessary build steps in\r\n  Makefile.\r\n* Check-in assets. Assets being part of the code it is typical to check\r\n  them into git. Required to make ToDD \"go gettable\". Added `make\r\n  update_assets` command.\r\n* Added `make start` command to start a simple ToDD environment in\r\n* docker.\r\n* Modified Vagrantfile to mount code directly into GOPATH to simplify\r\n  dev. Code can be changed on host and rebuilt in Vagrant with\r\n  `go install ./...`, `make install`, or `make start`.\r\n* Moved main packages into `cmd/[cmd name]`. This is a common structure\r\n  and results in `go get ./...` installing binaries with the correct\r\n  names.\r\n* Updated `server/assets.go` to serve files from assets package directly\r\n  rather than extracting to filesystem.\r\n* Modified `etc/{agent,server}.cfg` to use localhost rather than\r\n  hardcoded IPs.\r\n* `scripts/ansible-todd-dev.yml` updates:\r\n  * Changed the deprecated `sudo` to `become`/`become_user`.\r\n  * Updated gover to 1.6.2.\r\n  * Added gosha256 var to verify go download.\r\n  * Linked `etc/` to `/etc/todd` so that changes on the host are\r\n    available in vagrant VM.\r\n  * Modified paths and permissions so that sudo is not required to build\r\n    or run ToDD.\r\n  * Added `scripts/` to PATH.\r\n  * Modified `.profile` so that `vagrant ssh` will take users directly\r\n    to `$GOPATH/src/github.com/Mierdin/todd`.\r\n  * Updated `scripts/start-containers.sh` to allow specifying number of\r\n    agents and config files as arguments. Added extra logic to prevent\r\n    error messages when containers don't exist or when on Linux and not\r\n    using docker-machine.","created_at":"2016-05-07T21:17:56Z","updated_at":"2016-05-13T00:14:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b91be088e79c3ac0de014e87ce305354f6d602d2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Mierdin/todd/pulls/22/commits","review_comments_url":"https://api.github.com/repos/Mierdin/todd/pulls/22/comments","review_comment_url":"https://api.github.com/repos/Mierdin/todd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Mierdin/todd/issues/22/comments","statuses_url":"https://api.github.com/repos/Mierdin/todd/statuses/d451b31ecbb8154646180e52c0d3bfb9903df362","head":{"label":"vcabbage:simplify-dev-test2","ref":"simplify-dev-test2","sha":"d451b31ecbb8154646180e52c0d3bfb9903df362","user":{"login":"vcabbage","id":10789027,"avatar_url":"https://avatars.githubusercontent.com/u/10789027?v=3","gravatar_id":"","url":"https://api.github.com/users/vcabbage","html_url":"https://github.com/vcabbage","followers_url":"https://api.github.com/users/vcabbage/followers","following_url":"https://api.github.com/users/vcabbage/following{/other_user}","gists_url":"https://api.github.com/users/vcabbage/gists{/gist_id}","starred_url":"https://api.github.com/users/vcabbage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vcabbage/subscriptions","organizations_url":"https://api.github.com/users/vcabbage/orgs","repos_url":"https://api.github.com/users/vcabbage/repos","events_url":"https://api.github.com/users/vcabbage/events{/privacy}","received_events_url":"https://api.github.com/users/vcabbage/received_events","type":"User","site_admin":false},"repo":{"id":53991243,"name":"todd","full_name":"vcabbage/todd","owner":{"login":"vcabbage","id":10789027,"avatar_url":"https://avatars.githubusercontent.com/u/10789027?v=3","gravatar_id":"","url":"https://api.github.com/users/vcabbage","html_url":"https://github.com/vcabbage","followers_url":"https://api.github.com/users/vcabbage/followers","following_url":"https://api.github.com/users/vcabbage/following{/other_user}","gists_url":"https://api.github.com/users/vcabbage/gists{/gist_id}","starred_url":"https://api.github.com/users/vcabbage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vcabbage/subscriptions","organizations_url":"https://api.github.com/users/vcabbage/orgs","repos_url":"https://api.github.com/users/vcabbage/repos","events_url":"https://api.github.com/users/vcabbage/events{/privacy}","received_events_url":"https://api.github.com/users/vcabbage/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vcabbage/todd","description":"A highly extensible framework for distributed capacity and connectivity testing (Testing on Demand....Distributed!)","fork":true,"url":"https://api.github.com/repos/vcabbage/todd","forks_url":"https://api.github.com/repos/vcabbage/todd/forks","keys_url":"https://api.github.com/repos/vcabbage/todd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vcabbage/todd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vcabbage/todd/teams","hooks_url":"https://api.github.com/repos/vcabbage/todd/hooks","issue_events_url":"https://api.github.com/repos/vcabbage/todd/issues/events{/number}","events_url":"https://api.github.com/repos/vcabbage/todd/events","assignees_url":"https://api.github.com/repos/vcabbage/todd/assignees{/user}","branches_url":"https://api.github.com/repos/vcabbage/todd/branches{/branch}","tags_url":"https://api.github.com/repos/vcabbage/todd/tags","blobs_url":"https://api.github.com/repos/vcabbage/todd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vcabbage/todd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vcabbage/todd/git/refs{/sha}","trees_url":"https://api.github.com/repos/vcabbage/todd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vcabbage/todd/statuses/{sha}","languages_url":"https://api.github.com/repos/vcabbage/todd/languages","stargazers_url":"https://api.github.com/repos/vcabbage/todd/stargazers","contributors_url":"https://api.github.com/repos/vcabbage/todd/contributors","subscribers_url":"https://api.github.com/repos/vcabbage/todd/subscribers","subscription_url":"https://api.github.com/repos/vcabbage/todd/subscription","commits_url":"https://api.github.com/repos/vcabbage/todd/commits{/sha}","git_commits_url":"https://api.github.com/repos/vcabbage/todd/git/commits{/sha}","comments_url":"https://api.github.com/repos/vcabbage/todd/comments{/number}","issue_comment_url":"https://api.github.com/repos/vcabbage/todd/issues/comments{/number}","contents_url":"https://api.github.com/repos/vcabbage/todd/contents/{+path}","compare_url":"https://api.github.com/repos/vcabbage/todd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vcabbage/todd/merges","archive_url":"https://api.github.com/repos/vcabbage/todd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vcabbage/todd/downloads","issues_url":"https://api.github.com/repos/vcabbage/todd/issues{/number}","pulls_url":"https://api.github.com/repos/vcabbage/todd/pulls{/number}","milestones_url":"https://api.github.com/repos/vcabbage/todd/milestones{/number}","notifications_url":"https://api.github.com/repos/vcabbage/todd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vcabbage/todd/labels{/name}","releases_url":"https://api.github.com/repos/vcabbage/todd/releases{/id}","deployments_url":"https://api.github.com/repos/vcabbage/todd/deployments","created_at":"2016-03-16T01:32:26Z","updated_at":"2016-03-16T01:32:27Z","pushed_at":"2016-05-09T23:37:38Z","git_url":"git://github.com/vcabbage/todd.git","ssh_url":"git@github.com:vcabbage/todd.git","clone_url":"https://github.com/vcabbage/todd.git","svn_url":"https://github.com/vcabbage/todd","homepage":null,"size":8463,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Mierdin:master","ref":"master","sha":"136a77ecfc156f3e50570793a72e73edc2b6f808","user":{"login":"Mierdin","id":4230395,"avatar_url":"https://avatars.githubusercontent.com/u/4230395?v=3","gravatar_id":"","url":"https://api.github.com/users/Mierdin","html_url":"https://github.com/Mierdin","followers_url":"https://api.github.com/users/Mierdin/followers","following_url":"https://api.github.com/users/Mierdin/following{/other_user}","gists_url":"https://api.github.com/users/Mierdin/gists{/gist_id}","starred_url":"https://api.github.com/users/Mierdin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mierdin/subscriptions","organizations_url":"https://api.github.com/users/Mierdin/orgs","repos_url":"https://api.github.com/users/Mierdin/repos","events_url":"https://api.github.com/users/Mierdin/events{/privacy}","received_events_url":"https://api.github.com/users/Mierdin/received_events","type":"User","site_admin":false},"repo":{"id":53824369,"name":"todd","full_name":"Mierdin/todd","owner":{"login":"Mierdin","id":4230395,"avatar_url":"https://avatars.githubusercontent.com/u/4230395?v=3","gravatar_id":"","url":"https://api.github.com/users/Mierdin","html_url":"https://github.com/Mierdin","followers_url":"https://api.github.com/users/Mierdin/followers","following_url":"https://api.github.com/users/Mierdin/following{/other_user}","gists_url":"https://api.github.com/users/Mierdin/gists{/gist_id}","starred_url":"https://api.github.com/users/Mierdin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mierdin/subscriptions","organizations_url":"https://api.github.com/users/Mierdin/orgs","repos_url":"https://api.github.com/users/Mierdin/repos","events_url":"https://api.github.com/users/Mierdin/events{/privacy}","received_events_url":"https://api.github.com/users/Mierdin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Mierdin/todd","description":"A highly extensible framework for distributed capacity and connectivity testing (Testing on Demand....Distributed!)","fork":false,"url":"https://api.github.com/repos/Mierdin/todd","forks_url":"https://api.github.com/repos/Mierdin/todd/forks","keys_url":"https://api.github.com/repos/Mierdin/todd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Mierdin/todd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Mierdin/todd/teams","hooks_url":"https://api.github.com/repos/Mierdin/todd/hooks","issue_events_url":"https://api.github.com/repos/Mierdin/todd/issues/events{/number}","events_url":"https://api.github.com/repos/Mierdin/todd/events","assignees_url":"https://api.github.com/repos/Mierdin/todd/assignees{/user}","branches_url":"https://api.github.com/repos/Mierdin/todd/branches{/branch}","tags_url":"https://api.github.com/repos/Mierdin/todd/tags","blobs_url":"https://api.github.com/repos/Mierdin/todd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Mierdin/todd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Mierdin/todd/git/refs{/sha}","trees_url":"https://api.github.com/repos/Mierdin/todd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Mierdin/todd/statuses/{sha}","languages_url":"https://api.github.com/repos/Mierdin/todd/languages","stargazers_url":"https://api.github.com/repos/Mierdin/todd/stargazers","contributors_url":"https://api.github.com/repos/Mierdin/todd/contributors","subscribers_url":"https://api.github.com/repos/Mierdin/todd/subscribers","subscription_url":"https://api.github.com/repos/Mierdin/todd/subscription","commits_url":"https://api.github.com/repos/Mierdin/todd/commits{/sha}","git_commits_url":"https://api.github.com/repos/Mierdin/todd/git/commits{/sha}","comments_url":"https://api.github.com/repos/Mierdin/todd/comments{/number}","issue_comment_url":"https://api.github.com/repos/Mierdin/todd/issues/comments{/number}","contents_url":"https://api.github.com/repos/Mierdin/todd/contents/{+path}","compare_url":"https://api.github.com/repos/Mierdin/todd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Mierdin/todd/merges","archive_url":"https://api.github.com/repos/Mierdin/todd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Mierdin/todd/downloads","issues_url":"https://api.github.com/repos/Mierdin/todd/issues{/number}","pulls_url":"https://api.github.com/repos/Mierdin/todd/pulls{/number}","milestones_url":"https://api.github.com/repos/Mierdin/todd/milestones{/number}","notifications_url":"https://api.github.com/repos/Mierdin/todd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Mierdin/todd/labels{/name}","releases_url":"https://api.github.com/repos/Mierdin/todd/releases{/id}","deployments_url":"https://api.github.com/repos/Mierdin/todd/deployments","created_at":"2016-03-14T03:32:32Z","updated_at":"2016-05-10T11:18:25Z","pushed_at":"2016-05-12T05:34:54Z","git_url":"git://github.com/Mierdin/todd.git","ssh_url":"git@github.com:Mierdin/todd.git","clone_url":"https://github.com/Mierdin/todd.git","svn_url":"https://github.com/Mierdin/todd","homepage":null,"size":8475,"stargazers_count":68,"watchers_count":68,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":11,"mirror_url":null,"open_issues_count":9,"forks":11,"open_issues":9,"watchers":68,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Mierdin/todd/pulls/22"},"html":{"href":"https://github.com/Mierdin/todd/pull/22"},"issue":{"href":"https://api.github.com/repos/Mierdin/todd/issues/22"},"comments":{"href":"https://api.github.com/repos/Mierdin/todd/issues/22/comments"},"review_comments":{"href":"https://api.github.com/repos/Mierdin/todd/pulls/22/comments"},"review_comment":{"href":"https://api.github.com/repos/Mierdin/todd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Mierdin/todd/pulls/22/commits"},"statuses":{"href":"https://api.github.com/repos/Mierdin/todd/statuses/d451b31ecbb8154646180e52c0d3bfb9903df362"}}}}