{"action":"created","comment":{"url":"https://api.github.com/repos/pypa/pip/pulls/comments/51957292","id":51957292,"diff_hunk":"@@ -396,6 +396,36 @@ def test_manual_abi_dm_flags(self):\n         self.abi_tag_unicode('dm', {'Py_DEBUG': True, 'WITH_PYMALLOC': True})\n \n \n+class TestManylinux1Tags(object):\n+\n+    @patch('pip.pep425tags.get_platform', lambda: 'linux_x86_64')\n+    @patch('pip.pep425tags.have_compatible_glibc', lambda foo, bar: True)\n+    @patch('sys.maxunicode', 0x10FFFF)\n+    def test_manylinux1_1(self):\n+        \"\"\"\n+        Test that manylinux1 is enabled on wide unicode linux_x86_64\n+        \"\"\"\n+        assert pep425tags.is_manylinux1_compatible() is True\n+\n+    @patch('pip.pep425tags.get_platform', lambda: 'linux_x86_64')\n+    @patch('pip.pep425tags.have_compatible_glibc', lambda foo, bar: True)\n+    @patch('sys.maxunicode', 0xFFFF)\n+    def test_manylinux1_2(self):\n+        \"\"\"\n+        Test that manylinux1 is disabled on narrow unicode builds\n+        \"\"\"\n+        assert pep425tags.is_manylinux1_compatible() is False","path":"tests/unit/test_wheel.py","position":22,"original_position":22,"commit_id":"3dc019a9af473758f4ce70d842a3abd990640d8a","original_commit_id":"3dc019a9af473758f4ce70d842a3abd990640d8a","user":{"login":"rmcgibbo","id":641278,"avatar_url":"https://avatars.githubusercontent.com/u/641278?v=3","gravatar_id":"","url":"https://api.github.com/users/rmcgibbo","html_url":"https://github.com/rmcgibbo","followers_url":"https://api.github.com/users/rmcgibbo/followers","following_url":"https://api.github.com/users/rmcgibbo/following{/other_user}","gists_url":"https://api.github.com/users/rmcgibbo/gists{/gist_id}","starred_url":"https://api.github.com/users/rmcgibbo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmcgibbo/subscriptions","organizations_url":"https://api.github.com/users/rmcgibbo/orgs","repos_url":"https://api.github.com/users/rmcgibbo/repos","events_url":"https://api.github.com/users/rmcgibbo/events{/privacy}","received_events_url":"https://api.github.com/users/rmcgibbo/received_events","type":"User","site_admin":false},"body":"Cool, if you prefer it that way I'm happy to change it.","created_at":"2016-02-04T23:47:13Z","updated_at":"2016-02-04T23:47:13Z","html_url":"https://github.com/pypa/pip/pull/3446#discussion_r51957292","pull_request_url":"https://api.github.com/repos/pypa/pip/pulls/3446","_links":{"self":{"href":"https://api.github.com/repos/pypa/pip/pulls/comments/51957292"},"html":{"href":"https://github.com/pypa/pip/pull/3446#discussion_r51957292"},"pull_request":{"href":"https://api.github.com/repos/pypa/pip/pulls/3446"}}},"pull_request":{"url":"https://api.github.com/repos/pypa/pip/pulls/3446","id":57956098,"html_url":"https://github.com/pypa/pip/pull/3446","diff_url":"https://github.com/pypa/pip/pull/3446.diff","patch_url":"https://github.com/pypa/pip/pull/3446.patch","issue_url":"https://api.github.com/repos/pypa/pip/issues/3446","number":3446,"state":"open","locked":false,"title":"Implement PEP 513","user":{"login":"rmcgibbo","id":641278,"avatar_url":"https://avatars.githubusercontent.com/u/641278?v=3","gravatar_id":"","url":"https://api.github.com/users/rmcgibbo","html_url":"https://github.com/rmcgibbo","followers_url":"https://api.github.com/users/rmcgibbo/followers","following_url":"https://api.github.com/users/rmcgibbo/following{/other_user}","gists_url":"https://api.github.com/users/rmcgibbo/gists{/gist_id}","starred_url":"https://api.github.com/users/rmcgibbo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmcgibbo/subscriptions","organizations_url":"https://api.github.com/users/rmcgibbo/orgs","repos_url":"https://api.github.com/users/rmcgibbo/repos","events_url":"https://api.github.com/users/rmcgibbo/events{/privacy}","received_events_url":"https://api.github.com/users/rmcgibbo/received_events","type":"User","site_admin":false},"body":"This PR implements PEP 513 (the `manylinux1` PEP approved on distutils-sig last week). The code was written mostly in the PEP by @njsmith. It's implemented as an extra part of `pep425tags.get_supported` that, when running on Linux, checks if the current machine is manylinux1 compatible if so, adds it to the returned list of supported tags.\r\n\r\n<!-- Reviewable:start -->\r\n[<img src=\"https://reviewable.io/review_button.svg\" height=\"40\" alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/pypa/pip/3446)\r\n<!-- Reviewable:end -->\r\n","created_at":"2016-02-02T08:48:26Z","updated_at":"2016-02-04T23:47:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9f14981bc9c16177912f0a2dccf0246c926491f9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/pypa/pip/pulls/3446/commits","review_comments_url":"https://api.github.com/repos/pypa/pip/pulls/3446/comments","review_comment_url":"https://api.github.com/repos/pypa/pip/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pypa/pip/issues/3446/comments","statuses_url":"https://api.github.com/repos/pypa/pip/statuses/3dc019a9af473758f4ce70d842a3abd990640d8a","head":{"label":"rmcgibbo:pep-513","ref":"pep-513","sha":"3dc019a9af473758f4ce70d842a3abd990640d8a","user":{"login":"rmcgibbo","id":641278,"avatar_url":"https://avatars.githubusercontent.com/u/641278?v=3","gravatar_id":"","url":"https://api.github.com/users/rmcgibbo","html_url":"https://github.com/rmcgibbo","followers_url":"https://api.github.com/users/rmcgibbo/followers","following_url":"https://api.github.com/users/rmcgibbo/following{/other_user}","gists_url":"https://api.github.com/users/rmcgibbo/gists{/gist_id}","starred_url":"https://api.github.com/users/rmcgibbo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmcgibbo/subscriptions","organizations_url":"https://api.github.com/users/rmcgibbo/orgs","repos_url":"https://api.github.com/users/rmcgibbo/repos","events_url":"https://api.github.com/users/rmcgibbo/events{/privacy}","received_events_url":"https://api.github.com/users/rmcgibbo/received_events","type":"User","site_admin":false},"repo":{"id":45711913,"name":"pip","full_name":"rmcgibbo/pip","owner":{"login":"rmcgibbo","id":641278,"avatar_url":"https://avatars.githubusercontent.com/u/641278?v=3","gravatar_id":"","url":"https://api.github.com/users/rmcgibbo","html_url":"https://github.com/rmcgibbo","followers_url":"https://api.github.com/users/rmcgibbo/followers","following_url":"https://api.github.com/users/rmcgibbo/following{/other_user}","gists_url":"https://api.github.com/users/rmcgibbo/gists{/gist_id}","starred_url":"https://api.github.com/users/rmcgibbo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmcgibbo/subscriptions","organizations_url":"https://api.github.com/users/rmcgibbo/orgs","repos_url":"https://api.github.com/users/rmcgibbo/repos","events_url":"https://api.github.com/users/rmcgibbo/events{/privacy}","received_events_url":"https://api.github.com/users/rmcgibbo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rmcgibbo/pip","description":"The PyPA recommended tool for installing Python packages","fork":true,"url":"https://api.github.com/repos/rmcgibbo/pip","forks_url":"https://api.github.com/repos/rmcgibbo/pip/forks","keys_url":"https://api.github.com/repos/rmcgibbo/pip/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rmcgibbo/pip/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rmcgibbo/pip/teams","hooks_url":"https://api.github.com/repos/rmcgibbo/pip/hooks","issue_events_url":"https://api.github.com/repos/rmcgibbo/pip/issues/events{/number}","events_url":"https://api.github.com/repos/rmcgibbo/pip/events","assignees_url":"https://api.github.com/repos/rmcgibbo/pip/assignees{/user}","branches_url":"https://api.github.com/repos/rmcgibbo/pip/branches{/branch}","tags_url":"https://api.github.com/repos/rmcgibbo/pip/tags","blobs_url":"https://api.github.com/repos/rmcgibbo/pip/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rmcgibbo/pip/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rmcgibbo/pip/git/refs{/sha}","trees_url":"https://api.github.com/repos/rmcgibbo/pip/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rmcgibbo/pip/statuses/{sha}","languages_url":"https://api.github.com/repos/rmcgibbo/pip/languages","stargazers_url":"https://api.github.com/repos/rmcgibbo/pip/stargazers","contributors_url":"https://api.github.com/repos/rmcgibbo/pip/contributors","subscribers_url":"https://api.github.com/repos/rmcgibbo/pip/subscribers","subscription_url":"https://api.github.com/repos/rmcgibbo/pip/subscription","commits_url":"https://api.github.com/repos/rmcgibbo/pip/commits{/sha}","git_commits_url":"https://api.github.com/repos/rmcgibbo/pip/git/commits{/sha}","comments_url":"https://api.github.com/repos/rmcgibbo/pip/comments{/number}","issue_comment_url":"https://api.github.com/repos/rmcgibbo/pip/issues/comments{/number}","contents_url":"https://api.github.com/repos/rmcgibbo/pip/contents/{+path}","compare_url":"https://api.github.com/repos/rmcgibbo/pip/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rmcgibbo/pip/merges","archive_url":"https://api.github.com/repos/rmcgibbo/pip/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rmcgibbo/pip/downloads","issues_url":"https://api.github.com/repos/rmcgibbo/pip/issues{/number}","pulls_url":"https://api.github.com/repos/rmcgibbo/pip/pulls{/number}","milestones_url":"https://api.github.com/repos/rmcgibbo/pip/milestones{/number}","notifications_url":"https://api.github.com/repos/rmcgibbo/pip/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rmcgibbo/pip/labels{/name}","releases_url":"https://api.github.com/repos/rmcgibbo/pip/releases{/id}","deployments_url":"https://api.github.com/repos/rmcgibbo/pip/deployments","created_at":"2015-11-06T22:41:21Z","updated_at":"2015-11-06T22:41:25Z","pushed_at":"2016-02-04T04:17:28Z","git_url":"git://github.com/rmcgibbo/pip.git","ssh_url":"git@github.com:rmcgibbo/pip.git","clone_url":"https://github.com/rmcgibbo/pip.git","svn_url":"https://github.com/rmcgibbo/pip","homepage":"https://pip.pypa.io/","size":41404,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"pypa:develop","ref":"develop","sha":"a421676ec4d9bcd3f8e243e8abf55b0f900a0f66","user":{"login":"pypa","id":647025,"avatar_url":"https://avatars.githubusercontent.com/u/647025?v=3","gravatar_id":"","url":"https://api.github.com/users/pypa","html_url":"https://github.com/pypa","followers_url":"https://api.github.com/users/pypa/followers","following_url":"https://api.github.com/users/pypa/following{/other_user}","gists_url":"https://api.github.com/users/pypa/gists{/gist_id}","starred_url":"https://api.github.com/users/pypa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pypa/subscriptions","organizations_url":"https://api.github.com/users/pypa/orgs","repos_url":"https://api.github.com/users/pypa/repos","events_url":"https://api.github.com/users/pypa/events{/privacy}","received_events_url":"https://api.github.com/users/pypa/received_events","type":"Organization","site_admin":false},"repo":{"id":1446467,"name":"pip","full_name":"pypa/pip","owner":{"login":"pypa","id":647025,"avatar_url":"https://avatars.githubusercontent.com/u/647025?v=3","gravatar_id":"","url":"https://api.github.com/users/pypa","html_url":"https://github.com/pypa","followers_url":"https://api.github.com/users/pypa/followers","following_url":"https://api.github.com/users/pypa/following{/other_user}","gists_url":"https://api.github.com/users/pypa/gists{/gist_id}","starred_url":"https://api.github.com/users/pypa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pypa/subscriptions","organizations_url":"https://api.github.com/users/pypa/orgs","repos_url":"https://api.github.com/users/pypa/repos","events_url":"https://api.github.com/users/pypa/events{/privacy}","received_events_url":"https://api.github.com/users/pypa/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pypa/pip","description":"The PyPA recommended tool for installing Python packages","fork":false,"url":"https://api.github.com/repos/pypa/pip","forks_url":"https://api.github.com/repos/pypa/pip/forks","keys_url":"https://api.github.com/repos/pypa/pip/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pypa/pip/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pypa/pip/teams","hooks_url":"https://api.github.com/repos/pypa/pip/hooks","issue_events_url":"https://api.github.com/repos/pypa/pip/issues/events{/number}","events_url":"https://api.github.com/repos/pypa/pip/events","assignees_url":"https://api.github.com/repos/pypa/pip/assignees{/user}","branches_url":"https://api.github.com/repos/pypa/pip/branches{/branch}","tags_url":"https://api.github.com/repos/pypa/pip/tags","blobs_url":"https://api.github.com/repos/pypa/pip/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pypa/pip/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pypa/pip/git/refs{/sha}","trees_url":"https://api.github.com/repos/pypa/pip/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pypa/pip/statuses/{sha}","languages_url":"https://api.github.com/repos/pypa/pip/languages","stargazers_url":"https://api.github.com/repos/pypa/pip/stargazers","contributors_url":"https://api.github.com/repos/pypa/pip/contributors","subscribers_url":"https://api.github.com/repos/pypa/pip/subscribers","subscription_url":"https://api.github.com/repos/pypa/pip/subscription","commits_url":"https://api.github.com/repos/pypa/pip/commits{/sha}","git_commits_url":"https://api.github.com/repos/pypa/pip/git/commits{/sha}","comments_url":"https://api.github.com/repos/pypa/pip/comments{/number}","issue_comment_url":"https://api.github.com/repos/pypa/pip/issues/comments{/number}","contents_url":"https://api.github.com/repos/pypa/pip/contents/{+path}","compare_url":"https://api.github.com/repos/pypa/pip/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pypa/pip/merges","archive_url":"https://api.github.com/repos/pypa/pip/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pypa/pip/downloads","issues_url":"https://api.github.com/repos/pypa/pip/issues{/number}","pulls_url":"https://api.github.com/repos/pypa/pip/pulls{/number}","milestones_url":"https://api.github.com/repos/pypa/pip/milestones{/number}","notifications_url":"https://api.github.com/repos/pypa/pip/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pypa/pip/labels{/name}","releases_url":"https://api.github.com/repos/pypa/pip/releases{/id}","deployments_url":"https://api.github.com/repos/pypa/pip/deployments","created_at":"2011-03-06T14:30:46Z","updated_at":"2016-02-04T20:12:37Z","pushed_at":"2016-02-04T04:17:32Z","git_url":"git://github.com/pypa/pip.git","ssh_url":"git@github.com:pypa/pip.git","clone_url":"https://github.com/pypa/pip.git","svn_url":"https://github.com/pypa/pip","homepage":"https://pip.pypa.io/","size":50991,"stargazers_count":2608,"watchers_count":2608,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1014,"mirror_url":null,"open_issues_count":642,"forks":1014,"open_issues":642,"watchers":2608,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/pypa/pip/pulls/3446"},"html":{"href":"https://github.com/pypa/pip/pull/3446"},"issue":{"href":"https://api.github.com/repos/pypa/pip/issues/3446"},"comments":{"href":"https://api.github.com/repos/pypa/pip/issues/3446/comments"},"review_comments":{"href":"https://api.github.com/repos/pypa/pip/pulls/3446/comments"},"review_comment":{"href":"https://api.github.com/repos/pypa/pip/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pypa/pip/pulls/3446/commits"},"statuses":{"href":"https://api.github.com/repos/pypa/pip/statuses/3dc019a9af473758f4ce70d842a3abd990640d8a"}}}}