{"action":"created","issue":{"url":"https://api.github.com/repos/DoSomething/phoenix/issues/7140","repository_url":"https://api.github.com/repos/DoSomething/phoenix","labels_url":"https://api.github.com/repos/DoSomething/phoenix/issues/7140/labels{/name}","comments_url":"https://api.github.com/repos/DoSomething/phoenix/issues/7140/comments","events_url":"https://api.github.com/repos/DoSomething/phoenix/issues/7140/events","html_url":"https://github.com/DoSomething/phoenix/pull/7140","id":184282072,"number":7140,"title":"Update to latest Drupal 7 release... maybe.","user":{"login":"DFurnes","id":583202,"avatar_url":"https://avatars.githubusercontent.com/u/583202?v=3","gravatar_id":"","url":"https://api.github.com/users/DFurnes","html_url":"https://github.com/DFurnes","followers_url":"https://api.github.com/users/DFurnes/followers","following_url":"https://api.github.com/users/DFurnes/following{/other_user}","gists_url":"https://api.github.com/users/DFurnes/gists{/gist_id}","starred_url":"https://api.github.com/users/DFurnes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DFurnes/subscriptions","organizations_url":"https://api.github.com/users/DFurnes/orgs","repos_url":"https://api.github.com/users/DFurnes/repos","events_url":"https://api.github.com/users/DFurnes/events{/privacy}","received_events_url":"https://api.github.com/users/DFurnes/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-10-20T16:45:30Z","updated_at":"2016-10-20T17:32:04Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/DoSomething/phoenix/pulls/7140","html_url":"https://github.com/DoSomething/phoenix/pull/7140","diff_url":"https://github.com/DoSomething/phoenix/pull/7140.diff","patch_url":"https://github.com/DoSomething/phoenix/pull/7140.patch"},"body":"#### What's this PR do?\r\nThis pull request updates to the latest Drupal 7 release. This release includes [a fix for those ugly \"session destroy\" errors](https://www.drupal.org/node/2638016) that were showing up on staging, and presumably some other PHP 7 fixes according to the comments in that discussion.\r\n\r\n#### How should this be reviewed?\r\nIt should build and not have those errors after you build.  🐛🔨\r\n\r\n#### Any background context you want to provide?\r\nI am currently seeing some nasty Drush errors :fearful: when testing this on my local and trying to pull the staging database. ~~The build itself works as expected~~ No everything is broken, see build errors below. I get the same errors when trying to build on the dev branch, though, so maybe it's just an unrelated problem on my end.\r\n\r\n```\r\ndosomething@dev:/var/www/dev.dosomething.org$ ds pull stage --db\r\nDropping local DB\r\nDo you really want to drop all tables in the database dosomething? (y/n): y\r\nPulling down db from staging\r\nThe external command could not be executed due to an application error.                                                                                               [error]\r\nIllegal string offset 'site' backend.inc:1032                                                                                                                         [warning]\r\n                                                                             [error]ey).\r\n, code: 255)\r\nError: no database record could be found for source @ds.staging      \r\n```\r\n\r\n#### Relevant tickets\r\nFixes 🐛💦.\r\n\r\n#### Checklist\r\n- [ ] Documentation added for new features/changed endpoints.\r\n- [ ] Tested on staging.\r\n- [ ] Pinged a PM if this is a larger PR that would benefit from some additional testing love\r\n- [ ] Post a message in #phoenix if this includes something that causes a rebuild!  "},"comment":{"url":"https://api.github.com/repos/DoSomething/phoenix/issues/comments/255173612","html_url":"https://github.com/DoSomething/phoenix/pull/7140#issuecomment-255173612","issue_url":"https://api.github.com/repos/DoSomething/phoenix/issues/7140","id":255173612,"user":{"login":"angaither","id":645205,"avatar_url":"https://avatars.githubusercontent.com/u/645205?v=3","gravatar_id":"","url":"https://api.github.com/users/angaither","html_url":"https://github.com/angaither","followers_url":"https://api.github.com/users/angaither/followers","following_url":"https://api.github.com/users/angaither/following{/other_user}","gists_url":"https://api.github.com/users/angaither/gists{/gist_id}","starred_url":"https://api.github.com/users/angaither/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angaither/subscriptions","organizations_url":"https://api.github.com/users/angaither/orgs","repos_url":"https://api.github.com/users/angaither/repos","events_url":"https://api.github.com/users/angaither/events{/privacy}","received_events_url":"https://api.github.com/users/angaither/received_events","type":"User","site_admin":false},"created_at":"2016-10-20T17:32:04Z","updated_at":"2016-10-20T17:32:04Z","body":"@DFurnes I will try a build on the dev branch before pulling this update. "}}
{"actor":{"display_login":"angaither"}}