{"action":"created","comment":{"url":"https://api.github.com/repos/pingcap/tidb-tools/pulls/comments/77435937","id":77435937,"diff_hunk":"@@ -488,7 +656,56 @@ func (s *Syncer) printStatus() {\n \t}\n }\n \n-func (s *Syncer) executeSQL(db *sql.DB, sqls []string, args [][]interface{}) error {\n+func (s *Syncer) querySQL(db *sql.DB, sqls []string, args [][]interface{}, retry bool) ([]*sql.Rows, error) {","path":"syncer/syncer.go","position":260,"original_position":260,"commit_id":"f9a6cf68b66db4808395437f639b617c10336b2a","original_commit_id":"f9a6cf68b66db4808395437f639b617c10336b2a","user":{"login":"qiuyesuifeng","id":1953644,"avatar_url":"https://avatars.githubusercontent.com/u/1953644?v=3","gravatar_id":"","url":"https://api.github.com/users/qiuyesuifeng","html_url":"https://github.com/qiuyesuifeng","followers_url":"https://api.github.com/users/qiuyesuifeng/followers","following_url":"https://api.github.com/users/qiuyesuifeng/following{/other_user}","gists_url":"https://api.github.com/users/qiuyesuifeng/gists{/gist_id}","starred_url":"https://api.github.com/users/qiuyesuifeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qiuyesuifeng/subscriptions","organizations_url":"https://api.github.com/users/qiuyesuifeng/orgs","repos_url":"https://api.github.com/users/qiuyesuifeng/repos","events_url":"https://api.github.com/users/qiuyesuifeng/events{/privacy}","received_events_url":"https://api.github.com/users/qiuyesuifeng/received_events","type":"User","site_admin":false},"body":"Actually i want to combine executeSQL and querySQL in one function, but seems we have not supported tx.Query well, so i remain this variable here for a later clean up.","created_at":"2016-09-03T12:03:09Z","updated_at":"2016-09-03T12:03:09Z","html_url":"https://github.com/pingcap/tidb-tools/pull/6#discussion_r77435937","pull_request_url":"https://api.github.com/repos/pingcap/tidb-tools/pulls/6","_links":{"self":{"href":"https://api.github.com/repos/pingcap/tidb-tools/pulls/comments/77435937"},"html":{"href":"https://github.com/pingcap/tidb-tools/pull/6#discussion_r77435937"},"pull_request":{"href":"https://api.github.com/repos/pingcap/tidb-tools/pulls/6"}}},"pull_request":{"url":"https://api.github.com/repos/pingcap/tidb-tools/pulls/6","id":83889338,"html_url":"https://github.com/pingcap/tidb-tools/pull/6","diff_url":"https://github.com/pingcap/tidb-tools/pull/6.diff","patch_url":"https://github.com/pingcap/tidb-tools/pull/6.patch","issue_url":"https://api.github.com/repos/pingcap/tidb-tools/issues/6","number":6,"state":"open","locked":false,"title":"syncer: add tidb connection retry support.","user":{"login":"qiuyesuifeng","id":1953644,"avatar_url":"https://avatars.githubusercontent.com/u/1953644?v=3","gravatar_id":"","url":"https://api.github.com/users/qiuyesuifeng","html_url":"https://github.com/qiuyesuifeng","followers_url":"https://api.github.com/users/qiuyesuifeng/followers","following_url":"https://api.github.com/users/qiuyesuifeng/following{/other_user}","gists_url":"https://api.github.com/users/qiuyesuifeng/gists{/gist_id}","starred_url":"https://api.github.com/users/qiuyesuifeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qiuyesuifeng/subscriptions","organizations_url":"https://api.github.com/users/qiuyesuifeng/orgs","repos_url":"https://api.github.com/users/qiuyesuifeng/repos","events_url":"https://api.github.com/users/qiuyesuifeng/events{/privacy}","received_events_url":"https://api.github.com/users/qiuyesuifeng/received_events","type":"User","site_admin":false},"body":"@siddontang @shenli \r\nPTAL","created_at":"2016-09-03T07:55:50Z","updated_at":"2016-09-03T12:03:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"782f6b7fb8ebc550ec8ae98e2af61c98032793f1","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/pingcap/tidb-tools/pulls/6/commits","review_comments_url":"https://api.github.com/repos/pingcap/tidb-tools/pulls/6/comments","review_comment_url":"https://api.github.com/repos/pingcap/tidb-tools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pingcap/tidb-tools/issues/6/comments","statuses_url":"https://api.github.com/repos/pingcap/tidb-tools/statuses/f9a6cf68b66db4808395437f639b617c10336b2a","head":{"label":"pingcap:qiuyesuifeng/conn-retry","ref":"qiuyesuifeng/conn-retry","sha":"f9a6cf68b66db4808395437f639b617c10336b2a","user":{"login":"pingcap","id":11855343,"avatar_url":"https://avatars.githubusercontent.com/u/11855343?v=3","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"repo":{"id":64638071,"name":"tidb-tools","full_name":"pingcap/tidb-tools","owner":{"login":"pingcap","id":11855343,"avatar_url":"https://avatars.githubusercontent.com/u/11855343?v=3","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pingcap/tidb-tools","description":null,"fork":false,"url":"https://api.github.com/repos/pingcap/tidb-tools","forks_url":"https://api.github.com/repos/pingcap/tidb-tools/forks","keys_url":"https://api.github.com/repos/pingcap/tidb-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pingcap/tidb-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pingcap/tidb-tools/teams","hooks_url":"https://api.github.com/repos/pingcap/tidb-tools/hooks","issue_events_url":"https://api.github.com/repos/pingcap/tidb-tools/issues/events{/number}","events_url":"https://api.github.com/repos/pingcap/tidb-tools/events","assignees_url":"https://api.github.com/repos/pingcap/tidb-tools/assignees{/user}","branches_url":"https://api.github.com/repos/pingcap/tidb-tools/branches{/branch}","tags_url":"https://api.github.com/repos/pingcap/tidb-tools/tags","blobs_url":"https://api.github.com/repos/pingcap/tidb-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pingcap/tidb-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pingcap/tidb-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/pingcap/tidb-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pingcap/tidb-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/pingcap/tidb-tools/languages","stargazers_url":"https://api.github.com/repos/pingcap/tidb-tools/stargazers","contributors_url":"https://api.github.com/repos/pingcap/tidb-tools/contributors","subscribers_url":"https://api.github.com/repos/pingcap/tidb-tools/subscribers","subscription_url":"https://api.github.com/repos/pingcap/tidb-tools/subscription","commits_url":"https://api.github.com/repos/pingcap/tidb-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/pingcap/tidb-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/pingcap/tidb-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/pingcap/tidb-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/pingcap/tidb-tools/contents/{+path}","compare_url":"https://api.github.com/repos/pingcap/tidb-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pingcap/tidb-tools/merges","archive_url":"https://api.github.com/repos/pingcap/tidb-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pingcap/tidb-tools/downloads","issues_url":"https://api.github.com/repos/pingcap/tidb-tools/issues{/number}","pulls_url":"https://api.github.com/repos/pingcap/tidb-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/pingcap/tidb-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/pingcap/tidb-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pingcap/tidb-tools/labels{/name}","releases_url":"https://api.github.com/repos/pingcap/tidb-tools/releases{/id}","deployments_url":"https://api.github.com/repos/pingcap/tidb-tools/deployments","created_at":"2016-08-01T05:20:53Z","updated_at":"2016-09-03T02:14:32Z","pushed_at":"2016-09-03T07:55:51Z","git_url":"git://github.com/pingcap/tidb-tools.git","ssh_url":"git@github.com:pingcap/tidb-tools.git","clone_url":"https://github.com/pingcap/tidb-tools.git","svn_url":"https://github.com/pingcap/tidb-tools","homepage":null,"size":131,"stargazers_count":2,"watchers_count":2,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":2,"default_branch":"master"}},"base":{"label":"pingcap:qiuyesuifeng/parallel-sync","ref":"qiuyesuifeng/parallel-sync","sha":"6880c22d4d2ba2cd5dbc9dd2b5446262adf6a998","user":{"login":"pingcap","id":11855343,"avatar_url":"https://avatars.githubusercontent.com/u/11855343?v=3","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"repo":{"id":64638071,"name":"tidb-tools","full_name":"pingcap/tidb-tools","owner":{"login":"pingcap","id":11855343,"avatar_url":"https://avatars.githubusercontent.com/u/11855343?v=3","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pingcap/tidb-tools","description":null,"fork":false,"url":"https://api.github.com/repos/pingcap/tidb-tools","forks_url":"https://api.github.com/repos/pingcap/tidb-tools/forks","keys_url":"https://api.github.com/repos/pingcap/tidb-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pingcap/tidb-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pingcap/tidb-tools/teams","hooks_url":"https://api.github.com/repos/pingcap/tidb-tools/hooks","issue_events_url":"https://api.github.com/repos/pingcap/tidb-tools/issues/events{/number}","events_url":"https://api.github.com/repos/pingcap/tidb-tools/events","assignees_url":"https://api.github.com/repos/pingcap/tidb-tools/assignees{/user}","branches_url":"https://api.github.com/repos/pingcap/tidb-tools/branches{/branch}","tags_url":"https://api.github.com/repos/pingcap/tidb-tools/tags","blobs_url":"https://api.github.com/repos/pingcap/tidb-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pingcap/tidb-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pingcap/tidb-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/pingcap/tidb-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pingcap/tidb-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/pingcap/tidb-tools/languages","stargazers_url":"https://api.github.com/repos/pingcap/tidb-tools/stargazers","contributors_url":"https://api.github.com/repos/pingcap/tidb-tools/contributors","subscribers_url":"https://api.github.com/repos/pingcap/tidb-tools/subscribers","subscription_url":"https://api.github.com/repos/pingcap/tidb-tools/subscription","commits_url":"https://api.github.com/repos/pingcap/tidb-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/pingcap/tidb-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/pingcap/tidb-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/pingcap/tidb-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/pingcap/tidb-tools/contents/{+path}","compare_url":"https://api.github.com/repos/pingcap/tidb-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pingcap/tidb-tools/merges","archive_url":"https://api.github.com/repos/pingcap/tidb-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pingcap/tidb-tools/downloads","issues_url":"https://api.github.com/repos/pingcap/tidb-tools/issues{/number}","pulls_url":"https://api.github.com/repos/pingcap/tidb-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/pingcap/tidb-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/pingcap/tidb-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pingcap/tidb-tools/labels{/name}","releases_url":"https://api.github.com/repos/pingcap/tidb-tools/releases{/id}","deployments_url":"https://api.github.com/repos/pingcap/tidb-tools/deployments","created_at":"2016-08-01T05:20:53Z","updated_at":"2016-09-03T02:14:32Z","pushed_at":"2016-09-03T07:55:51Z","git_url":"git://github.com/pingcap/tidb-tools.git","ssh_url":"git@github.com:pingcap/tidb-tools.git","clone_url":"https://github.com/pingcap/tidb-tools.git","svn_url":"https://github.com/pingcap/tidb-tools","homepage":null,"size":131,"stargazers_count":2,"watchers_count":2,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pingcap/tidb-tools/pulls/6"},"html":{"href":"https://github.com/pingcap/tidb-tools/pull/6"},"issue":{"href":"https://api.github.com/repos/pingcap/tidb-tools/issues/6"},"comments":{"href":"https://api.github.com/repos/pingcap/tidb-tools/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/pingcap/tidb-tools/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/pingcap/tidb-tools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pingcap/tidb-tools/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/pingcap/tidb-tools/statuses/f9a6cf68b66db4808395437f639b617c10336b2a"}}}}
{"actor":{"display_login":"qiuyesuifeng"}}