{"action":"closed","number":317,"pull_request":{"url":"https://api.github.com/repos/tildeio/glimmer/pulls/317","id":85587121,"html_url":"https://github.com/tildeio/glimmer/pull/317","diff_url":"https://github.com/tildeio/glimmer/pull/317.diff","patch_url":"https://github.com/tildeio/glimmer/pull/317.patch","issue_url":"https://api.github.com/repos/tildeio/glimmer/issues/317","number":317,"state":"closed","locked":false,"title":"Fix issue with components that have multiple yields.","user":{"login":"rwjblue","id":12637,"avatar_url":"https://avatars.githubusercontent.com/u/12637?v=3","gravatar_id":"","url":"https://api.github.com/users/rwjblue","html_url":"https://github.com/rwjblue","followers_url":"https://api.github.com/users/rwjblue/followers","following_url":"https://api.github.com/users/rwjblue/following{/other_user}","gists_url":"https://api.github.com/users/rwjblue/gists{/gist_id}","starred_url":"https://api.github.com/users/rwjblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwjblue/subscriptions","organizations_url":"https://api.github.com/users/rwjblue/orgs","repos_url":"https://api.github.com/users/rwjblue/repos","events_url":"https://api.github.com/users/rwjblue/events{/privacy}","received_events_url":"https://api.github.com/users/rwjblue/received_events","type":"User","site_admin":false},"body":"Previously, we assumed that only `{{#each` needed to deal with \"multiple\" yields, but in reality any component can also yield many times also.\r\n\r\nThis moves the `pushChildScope` / `popScope` up out of `EachSyntax` into the main `InlineBlockCompiler`.\r\n\r\nIn theory, we don't need to do this for *every* block with block params (i.e. `{{#with` will never need this), so we could move these operations to only be for `{{#each` and component invocation with block params.  I'm happy to work on that with direction on where the addition `pushChildScope` / `popScope` needs to go for component statements.\r\n\r\nRelated to https://github.com/emberjs/ember.js/issues/14284 and https://github.com/emberjs/ember.js/pull/14285.","created_at":"2016-09-16T14:53:06Z","updated_at":"2016-09-16T18:02:09Z","closed_at":"2016-09-16T18:02:09Z","merged_at":"2016-09-16T18:02:08Z","merge_commit_sha":"6f231a015d0a6c3c4741dc2b3e24beba7f244951","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/tildeio/glimmer/pulls/317/commits","review_comments_url":"https://api.github.com/repos/tildeio/glimmer/pulls/317/comments","review_comment_url":"https://api.github.com/repos/tildeio/glimmer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tildeio/glimmer/issues/317/comments","statuses_url":"https://api.github.com/repos/tildeio/glimmer/statuses/c593c5abe7d43afa29b751885de2d30411684e08","head":{"label":"rwjblue:multiple-yield-scope","ref":"multiple-yield-scope","sha":"c593c5abe7d43afa29b751885de2d30411684e08","user":{"login":"rwjblue","id":12637,"avatar_url":"https://avatars.githubusercontent.com/u/12637?v=3","gravatar_id":"","url":"https://api.github.com/users/rwjblue","html_url":"https://github.com/rwjblue","followers_url":"https://api.github.com/users/rwjblue/followers","following_url":"https://api.github.com/users/rwjblue/following{/other_user}","gists_url":"https://api.github.com/users/rwjblue/gists{/gist_id}","starred_url":"https://api.github.com/users/rwjblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwjblue/subscriptions","organizations_url":"https://api.github.com/users/rwjblue/orgs","repos_url":"https://api.github.com/users/rwjblue/repos","events_url":"https://api.github.com/users/rwjblue/events{/privacy}","received_events_url":"https://api.github.com/users/rwjblue/received_events","type":"User","site_admin":false},"repo":{"id":46897851,"name":"glimmer","full_name":"rwjblue/glimmer","owner":{"login":"rwjblue","id":12637,"avatar_url":"https://avatars.githubusercontent.com/u/12637?v=3","gravatar_id":"","url":"https://api.github.com/users/rwjblue","html_url":"https://github.com/rwjblue","followers_url":"https://api.github.com/users/rwjblue/followers","following_url":"https://api.github.com/users/rwjblue/following{/other_user}","gists_url":"https://api.github.com/users/rwjblue/gists{/gist_id}","starred_url":"https://api.github.com/users/rwjblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwjblue/subscriptions","organizations_url":"https://api.github.com/users/rwjblue/orgs","repos_url":"https://api.github.com/users/rwjblue/repos","events_url":"https://api.github.com/users/rwjblue/events{/privacy}","received_events_url":"https://api.github.com/users/rwjblue/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rwjblue/glimmer","description":"","fork":true,"url":"https://api.github.com/repos/rwjblue/glimmer","forks_url":"https://api.github.com/repos/rwjblue/glimmer/forks","keys_url":"https://api.github.com/repos/rwjblue/glimmer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rwjblue/glimmer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rwjblue/glimmer/teams","hooks_url":"https://api.github.com/repos/rwjblue/glimmer/hooks","issue_events_url":"https://api.github.com/repos/rwjblue/glimmer/issues/events{/number}","events_url":"https://api.github.com/repos/rwjblue/glimmer/events","assignees_url":"https://api.github.com/repos/rwjblue/glimmer/assignees{/user}","branches_url":"https://api.github.com/repos/rwjblue/glimmer/branches{/branch}","tags_url":"https://api.github.com/repos/rwjblue/glimmer/tags","blobs_url":"https://api.github.com/repos/rwjblue/glimmer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rwjblue/glimmer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rwjblue/glimmer/git/refs{/sha}","trees_url":"https://api.github.com/repos/rwjblue/glimmer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rwjblue/glimmer/statuses/{sha}","languages_url":"https://api.github.com/repos/rwjblue/glimmer/languages","stargazers_url":"https://api.github.com/repos/rwjblue/glimmer/stargazers","contributors_url":"https://api.github.com/repos/rwjblue/glimmer/contributors","subscribers_url":"https://api.github.com/repos/rwjblue/glimmer/subscribers","subscription_url":"https://api.github.com/repos/rwjblue/glimmer/subscription","commits_url":"https://api.github.com/repos/rwjblue/glimmer/commits{/sha}","git_commits_url":"https://api.github.com/repos/rwjblue/glimmer/git/commits{/sha}","comments_url":"https://api.github.com/repos/rwjblue/glimmer/comments{/number}","issue_comment_url":"https://api.github.com/repos/rwjblue/glimmer/issues/comments{/number}","contents_url":"https://api.github.com/repos/rwjblue/glimmer/contents/{+path}","compare_url":"https://api.github.com/repos/rwjblue/glimmer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rwjblue/glimmer/merges","archive_url":"https://api.github.com/repos/rwjblue/glimmer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rwjblue/glimmer/downloads","issues_url":"https://api.github.com/repos/rwjblue/glimmer/issues{/number}","pulls_url":"https://api.github.com/repos/rwjblue/glimmer/pulls{/number}","milestones_url":"https://api.github.com/repos/rwjblue/glimmer/milestones{/number}","notifications_url":"https://api.github.com/repos/rwjblue/glimmer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rwjblue/glimmer/labels{/name}","releases_url":"https://api.github.com/repos/rwjblue/glimmer/releases{/id}","deployments_url":"https://api.github.com/repos/rwjblue/glimmer/deployments","created_at":"2015-11-26T01:46:51Z","updated_at":"2015-11-26T03:19:55Z","pushed_at":"2016-09-16T14:51:15Z","git_url":"git://github.com/rwjblue/glimmer.git","ssh_url":"git@github.com:rwjblue/glimmer.git","clone_url":"https://github.com/rwjblue/glimmer.git","svn_url":"https://github.com/rwjblue/glimmer","homepage":null,"size":3891,"stargazers_count":1,"watchers_count":1,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"tildeio:master","ref":"master","sha":"547e8a29b6aed8bf27aa847d2ee1b781d26fe5de","user":{"login":"tildeio","id":1355851,"avatar_url":"https://avatars.githubusercontent.com/u/1355851?v=3","gravatar_id":"","url":"https://api.github.com/users/tildeio","html_url":"https://github.com/tildeio","followers_url":"https://api.github.com/users/tildeio/followers","following_url":"https://api.github.com/users/tildeio/following{/other_user}","gists_url":"https://api.github.com/users/tildeio/gists{/gist_id}","starred_url":"https://api.github.com/users/tildeio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tildeio/subscriptions","organizations_url":"https://api.github.com/users/tildeio/orgs","repos_url":"https://api.github.com/users/tildeio/repos","events_url":"https://api.github.com/users/tildeio/events{/privacy}","received_events_url":"https://api.github.com/users/tildeio/received_events","type":"Organization","site_admin":false},"repo":{"id":42467001,"name":"glimmer","full_name":"tildeio/glimmer","owner":{"login":"tildeio","id":1355851,"avatar_url":"https://avatars.githubusercontent.com/u/1355851?v=3","gravatar_id":"","url":"https://api.github.com/users/tildeio","html_url":"https://github.com/tildeio","followers_url":"https://api.github.com/users/tildeio/followers","following_url":"https://api.github.com/users/tildeio/following{/other_user}","gists_url":"https://api.github.com/users/tildeio/gists{/gist_id}","starred_url":"https://api.github.com/users/tildeio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tildeio/subscriptions","organizations_url":"https://api.github.com/users/tildeio/orgs","repos_url":"https://api.github.com/users/tildeio/repos","events_url":"https://api.github.com/users/tildeio/events{/privacy}","received_events_url":"https://api.github.com/users/tildeio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tildeio/glimmer","description":"","fork":false,"url":"https://api.github.com/repos/tildeio/glimmer","forks_url":"https://api.github.com/repos/tildeio/glimmer/forks","keys_url":"https://api.github.com/repos/tildeio/glimmer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tildeio/glimmer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tildeio/glimmer/teams","hooks_url":"https://api.github.com/repos/tildeio/glimmer/hooks","issue_events_url":"https://api.github.com/repos/tildeio/glimmer/issues/events{/number}","events_url":"https://api.github.com/repos/tildeio/glimmer/events","assignees_url":"https://api.github.com/repos/tildeio/glimmer/assignees{/user}","branches_url":"https://api.github.com/repos/tildeio/glimmer/branches{/branch}","tags_url":"https://api.github.com/repos/tildeio/glimmer/tags","blobs_url":"https://api.github.com/repos/tildeio/glimmer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tildeio/glimmer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tildeio/glimmer/git/refs{/sha}","trees_url":"https://api.github.com/repos/tildeio/glimmer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tildeio/glimmer/statuses/{sha}","languages_url":"https://api.github.com/repos/tildeio/glimmer/languages","stargazers_url":"https://api.github.com/repos/tildeio/glimmer/stargazers","contributors_url":"https://api.github.com/repos/tildeio/glimmer/contributors","subscribers_url":"https://api.github.com/repos/tildeio/glimmer/subscribers","subscription_url":"https://api.github.com/repos/tildeio/glimmer/subscription","commits_url":"https://api.github.com/repos/tildeio/glimmer/commits{/sha}","git_commits_url":"https://api.github.com/repos/tildeio/glimmer/git/commits{/sha}","comments_url":"https://api.github.com/repos/tildeio/glimmer/comments{/number}","issue_comment_url":"https://api.github.com/repos/tildeio/glimmer/issues/comments{/number}","contents_url":"https://api.github.com/repos/tildeio/glimmer/contents/{+path}","compare_url":"https://api.github.com/repos/tildeio/glimmer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tildeio/glimmer/merges","archive_url":"https://api.github.com/repos/tildeio/glimmer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tildeio/glimmer/downloads","issues_url":"https://api.github.com/repos/tildeio/glimmer/issues{/number}","pulls_url":"https://api.github.com/repos/tildeio/glimmer/pulls{/number}","milestones_url":"https://api.github.com/repos/tildeio/glimmer/milestones{/number}","notifications_url":"https://api.github.com/repos/tildeio/glimmer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tildeio/glimmer/labels{/name}","releases_url":"https://api.github.com/repos/tildeio/glimmer/releases{/id}","deployments_url":"https://api.github.com/repos/tildeio/glimmer/deployments","created_at":"2015-09-14T17:59:26Z","updated_at":"2016-09-16T11:58:02Z","pushed_at":"2016-09-16T18:02:09Z","git_url":"git://github.com/tildeio/glimmer.git","ssh_url":"git@github.com:tildeio/glimmer.git","clone_url":"https://github.com/tildeio/glimmer.git","svn_url":"https://github.com/tildeio/glimmer","homepage":null,"size":4258,"stargazers_count":286,"watchers_count":286,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":47,"mirror_url":null,"open_issues_count":31,"forks":47,"open_issues":31,"watchers":286,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tildeio/glimmer/pulls/317"},"html":{"href":"https://github.com/tildeio/glimmer/pull/317"},"issue":{"href":"https://api.github.com/repos/tildeio/glimmer/issues/317"},"comments":{"href":"https://api.github.com/repos/tildeio/glimmer/issues/317/comments"},"review_comments":{"href":"https://api.github.com/repos/tildeio/glimmer/pulls/317/comments"},"review_comment":{"href":"https://api.github.com/repos/tildeio/glimmer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tildeio/glimmer/pulls/317/commits"},"statuses":{"href":"https://api.github.com/repos/tildeio/glimmer/statuses/c593c5abe7d43afa29b751885de2d30411684e08"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"rwjblue","id":12637,"avatar_url":"https://avatars.githubusercontent.com/u/12637?v=3","gravatar_id":"","url":"https://api.github.com/users/rwjblue","html_url":"https://github.com/rwjblue","followers_url":"https://api.github.com/users/rwjblue/followers","following_url":"https://api.github.com/users/rwjblue/following{/other_user}","gists_url":"https://api.github.com/users/rwjblue/gists{/gist_id}","starred_url":"https://api.github.com/users/rwjblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwjblue/subscriptions","organizations_url":"https://api.github.com/users/rwjblue/orgs","repos_url":"https://api.github.com/users/rwjblue/repos","events_url":"https://api.github.com/users/rwjblue/events{/privacy}","received_events_url":"https://api.github.com/users/rwjblue/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":2,"additions":27,"deletions":11,"changed_files":3}}
{"actor":{"display_login":"rwjblue"}}