{"action":"created","issue":{"url":"https://api.github.com/repos/brainlessdeveloper/spot.js/issues/1","repository_url":"https://api.github.com/repos/brainlessdeveloper/spot.js","labels_url":"https://api.github.com/repos/brainlessdeveloper/spot.js/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/brainlessdeveloper/spot.js/issues/1/comments","events_url":"https://api.github.com/repos/brainlessdeveloper/spot.js/issues/1/events","html_url":"https://github.com/brainlessdeveloper/spot.js/pull/1","id":151048209,"number":1,"title":"Adding a bunch of performance improvements","user":{"login":"TheIronDeveloper","id":364028,"avatar_url":"https://avatars.githubusercontent.com/u/364028?v=3","gravatar_id":"","url":"https://api.github.com/users/TheIronDeveloper","html_url":"https://github.com/TheIronDeveloper","followers_url":"https://api.github.com/users/TheIronDeveloper/followers","following_url":"https://api.github.com/users/TheIronDeveloper/following{/other_user}","gists_url":"https://api.github.com/users/TheIronDeveloper/gists{/gist_id}","starred_url":"https://api.github.com/users/TheIronDeveloper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheIronDeveloper/subscriptions","organizations_url":"https://api.github.com/users/TheIronDeveloper/orgs","repos_url":"https://api.github.com/users/TheIronDeveloper/repos","events_url":"https://api.github.com/users/TheIronDeveloper/events{/privacy}","received_events_url":"https://api.github.com/users/TheIronDeveloper/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-04-26T06:00:40Z","updated_at":"2016-04-26T07:33:38Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/brainlessdeveloper/spot.js/pulls/1","html_url":"https://github.com/brainlessdeveloper/spot.js/pull/1","diff_url":"https://github.com/brainlessdeveloper/spot.js/pull/1.diff","patch_url":"https://github.com/brainlessdeveloper/spot.js/pull/1.patch"},"body":"This commit adds a series of improvements, either by making the\r\ncode (slightly) smaller, or by storing function calls and lookups\r\nas termporary variables.\r\n\r\nI also removed the transition on the `.spot` element, since that\r\nwas making the overall look-and-feel of the shadow movement slower.\r\n\r\nI made `showIndicators` default to falsey rather than truthy, since\r\nit seemed more like a development-debug tool and not really something\r\ndesired with a finished product.\r\n\r\nI changed several of the events that were `onmousemove` to\r\n`addEventListener`, matching closer to the listeners `load`, `resize`,\r\nand `scroll`.\r\n\r\nI also changed the mousemove events, removing the anonymous function\r\nwrapper (which is more costly) and replacing with the single `initiateSpot`\r\nevent function.\r\n\r\nI also removed a bunch of unused variables."},"comment":{"url":"https://api.github.com/repos/brainlessdeveloper/spot.js/issues/comments/214654228","html_url":"https://github.com/brainlessdeveloper/spot.js/pull/1#issuecomment-214654228","issue_url":"https://api.github.com/repos/brainlessdeveloper/spot.js/issues/1","id":214654228,"user":{"login":"brainlessdeveloper","id":16181067,"avatar_url":"https://avatars.githubusercontent.com/u/16181067?v=3","gravatar_id":"","url":"https://api.github.com/users/brainlessdeveloper","html_url":"https://github.com/brainlessdeveloper","followers_url":"https://api.github.com/users/brainlessdeveloper/followers","following_url":"https://api.github.com/users/brainlessdeveloper/following{/other_user}","gists_url":"https://api.github.com/users/brainlessdeveloper/gists{/gist_id}","starred_url":"https://api.github.com/users/brainlessdeveloper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brainlessdeveloper/subscriptions","organizations_url":"https://api.github.com/users/brainlessdeveloper/orgs","repos_url":"https://api.github.com/users/brainlessdeveloper/repos","events_url":"https://api.github.com/users/brainlessdeveloper/events{/privacy}","received_events_url":"https://api.github.com/users/brainlessdeveloper/received_events","type":"User","site_admin":false},"created_at":"2016-04-26T07:33:38Z","updated_at":"2016-04-26T07:33:38Z","body":"Thank you for the effort! I'll check this out thoroughly when I get home from work. Yesterday I started a new branch on my computer and I'm actually re-designing the whole code to work like this:\r\n\r\n1. User adds script to html file (without any options).\r\n2. User can add effect-specific CSS classes to elements, such as spot-shadow, spot-rotate, or spot-area.\r\n\r\nI'm thinking of a command pattern and dynamically creating objects for each element on the page that needs to be \"spotted\".\r\n\r\nI think your commit will help me create the new structure too."}}