{"action":"created","issue":{"url":"https://api.github.com/repos/hawtio/hawtio-kubernetes/issues/110","repository_url":"https://api.github.com/repos/hawtio/hawtio-kubernetes","labels_url":"https://api.github.com/repos/hawtio/hawtio-kubernetes/issues/110/labels{/name}","comments_url":"https://api.github.com/repos/hawtio/hawtio-kubernetes/issues/110/comments","events_url":"https://api.github.com/repos/hawtio/hawtio-kubernetes/issues/110/events","html_url":"https://github.com/hawtio/hawtio-kubernetes/pull/110","id":157178331,"number":110,"title":"Fixed CRUD operations on secrets","user":{"login":"nicolaferraro","id":4151857,"avatar_url":"https://avatars.githubusercontent.com/u/4151857?v=3","gravatar_id":"","url":"https://api.github.com/users/nicolaferraro","html_url":"https://github.com/nicolaferraro","followers_url":"https://api.github.com/users/nicolaferraro/followers","following_url":"https://api.github.com/users/nicolaferraro/following{/other_user}","gists_url":"https://api.github.com/users/nicolaferraro/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolaferraro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolaferraro/subscriptions","organizations_url":"https://api.github.com/users/nicolaferraro/orgs","repos_url":"https://api.github.com/users/nicolaferraro/repos","events_url":"https://api.github.com/users/nicolaferraro/events{/privacy}","received_events_url":"https://api.github.com/users/nicolaferraro/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-05-27T10:37:21Z","updated_at":"2016-05-27T10:43:45Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/hawtio/hawtio-kubernetes/pulls/110","html_url":"https://github.com/hawtio/hawtio-kubernetes/pull/110","diff_url":"https://github.com/hawtio/hawtio-kubernetes/pull/110.diff","patch_url":"https://github.com/hawtio/hawtio-kubernetes/pull/110.patch"},"body":"Taking the suggestions at https://github.com/fabric8io/fabric8-console/issues/96, I fixed the screens that allow making CRUD operations on secrets.\r\n\r\nWhat I made:\r\n- access to a secret defaults to read-only mode\r\n- added the edit button as in the pods screen\r\n- cancel and save now are enabled and disabled correctly\r\n- added button to go back to the list\r\n- added delete button (with confirmation)\r\n\r\nI tested the following workflows:\r\n- from the list of secrets -> edit\r\n- from the list of secrets -> add\r\n- from the list of secrets -> edit then delete\r\n- from application settings -> create secret -> save/back\r\n\r\nI don't know if there are other user flows related to secrets."},"comment":{"url":"https://api.github.com/repos/hawtio/hawtio-kubernetes/issues/comments/222116471","html_url":"https://github.com/hawtio/hawtio-kubernetes/pull/110#issuecomment-222116471","issue_url":"https://api.github.com/repos/hawtio/hawtio-kubernetes/issues/110","id":222116471,"user":{"login":"jstrachan","id":30140,"avatar_url":"https://avatars.githubusercontent.com/u/30140?v=3","gravatar_id":"","url":"https://api.github.com/users/jstrachan","html_url":"https://github.com/jstrachan","followers_url":"https://api.github.com/users/jstrachan/followers","following_url":"https://api.github.com/users/jstrachan/following{/other_user}","gists_url":"https://api.github.com/users/jstrachan/gists{/gist_id}","starred_url":"https://api.github.com/users/jstrachan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jstrachan/subscriptions","organizations_url":"https://api.github.com/users/jstrachan/orgs","repos_url":"https://api.github.com/users/jstrachan/repos","events_url":"https://api.github.com/users/jstrachan/events{/privacy}","received_events_url":"https://api.github.com/users/jstrachan/received_events","type":"User","site_admin":false},"created_at":"2016-05-27T10:43:44Z","updated_at":"2016-05-27T10:43:44Z","body":"[merge]"}}
{"actor":{"display_login":"jstrachan"}}