{"action":"closed","number":3656,"pull_request":{"url":"https://api.github.com/repos/vuejs/vue/pulls/3656","id":84766795,"html_url":"https://github.com/vuejs/vue/pull/3656","diff_url":"https://github.com/vuejs/vue/pull/3656.diff","patch_url":"https://github.com/vuejs/vue/pull/3656.patch","issue_url":"https://api.github.com/repos/vuejs/vue/issues/3656","number":3656,"state":"closed","locked":false,"title":"Add undefined check for instance methods","user":{"login":"Kingdaro","id":19603573,"avatar_url":"https://avatars.githubusercontent.com/u/19603573?v=3","gravatar_id":"","url":"https://api.github.com/users/Kingdaro","html_url":"https://github.com/Kingdaro","followers_url":"https://api.github.com/users/Kingdaro/followers","following_url":"https://api.github.com/users/Kingdaro/following{/other_user}","gists_url":"https://api.github.com/users/Kingdaro/gists{/gist_id}","starred_url":"https://api.github.com/users/Kingdaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kingdaro/subscriptions","organizations_url":"https://api.github.com/users/Kingdaro/orgs","repos_url":"https://api.github.com/users/Kingdaro/repos","events_url":"https://api.github.com/users/Kingdaro/events{/privacy}","received_events_url":"https://api.github.com/users/Kingdaro/received_events","type":"User","site_admin":false},"body":"Adding an undefined property to `methods` on vue components leads to a very ambiguous error message: `Uncaught TypeError: Cannot read property 'length' of undefined`\r\n\r\nExample:\r\n```js\r\nimport stuff from './stuff'\r\n\r\nexport default {\r\n  template: '...',\r\n  methods: {\r\n    someMethod: stuff.someMetod // typo!!!\r\n  }\r\n}\r\n```\r\nIt's an easy mistake to make. This checks for undefined properties and warns if it finds one.","created_at":"2016-09-10T20:25:14Z","updated_at":"2016-09-11T14:54:47Z","closed_at":"2016-09-11T14:54:47Z","merged_at":"2016-09-11T14:54:47Z","merge_commit_sha":"724a59348fa2036d5184ce65bef211d24440ee11","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/vuejs/vue/pulls/3656/commits","review_comments_url":"https://api.github.com/repos/vuejs/vue/pulls/3656/comments","review_comment_url":"https://api.github.com/repos/vuejs/vue/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vuejs/vue/issues/3656/comments","statuses_url":"https://api.github.com/repos/vuejs/vue/statuses/236fdc30c79dd4d35b755e353bf2a586a494dd09","head":{"label":"Kingdaro:kingdaro-init-methods-fix","ref":"kingdaro-init-methods-fix","sha":"236fdc30c79dd4d35b755e353bf2a586a494dd09","user":{"login":"Kingdaro","id":19603573,"avatar_url":"https://avatars.githubusercontent.com/u/19603573?v=3","gravatar_id":"","url":"https://api.github.com/users/Kingdaro","html_url":"https://github.com/Kingdaro","followers_url":"https://api.github.com/users/Kingdaro/followers","following_url":"https://api.github.com/users/Kingdaro/following{/other_user}","gists_url":"https://api.github.com/users/Kingdaro/gists{/gist_id}","starred_url":"https://api.github.com/users/Kingdaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kingdaro/subscriptions","organizations_url":"https://api.github.com/users/Kingdaro/orgs","repos_url":"https://api.github.com/users/Kingdaro/repos","events_url":"https://api.github.com/users/Kingdaro/events{/privacy}","received_events_url":"https://api.github.com/users/Kingdaro/received_events","type":"User","site_admin":false},"repo":{"id":67892114,"name":"vue","full_name":"Kingdaro/vue","owner":{"login":"Kingdaro","id":19603573,"avatar_url":"https://avatars.githubusercontent.com/u/19603573?v=3","gravatar_id":"","url":"https://api.github.com/users/Kingdaro","html_url":"https://github.com/Kingdaro","followers_url":"https://api.github.com/users/Kingdaro/followers","following_url":"https://api.github.com/users/Kingdaro/following{/other_user}","gists_url":"https://api.github.com/users/Kingdaro/gists{/gist_id}","starred_url":"https://api.github.com/users/Kingdaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kingdaro/subscriptions","organizations_url":"https://api.github.com/users/Kingdaro/orgs","repos_url":"https://api.github.com/users/Kingdaro/repos","events_url":"https://api.github.com/users/Kingdaro/events{/privacy}","received_events_url":"https://api.github.com/users/Kingdaro/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Kingdaro/vue","description":"Simple yet powerful library for building modern web interfaces.","fork":true,"url":"https://api.github.com/repos/Kingdaro/vue","forks_url":"https://api.github.com/repos/Kingdaro/vue/forks","keys_url":"https://api.github.com/repos/Kingdaro/vue/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Kingdaro/vue/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Kingdaro/vue/teams","hooks_url":"https://api.github.com/repos/Kingdaro/vue/hooks","issue_events_url":"https://api.github.com/repos/Kingdaro/vue/issues/events{/number}","events_url":"https://api.github.com/repos/Kingdaro/vue/events","assignees_url":"https://api.github.com/repos/Kingdaro/vue/assignees{/user}","branches_url":"https://api.github.com/repos/Kingdaro/vue/branches{/branch}","tags_url":"https://api.github.com/repos/Kingdaro/vue/tags","blobs_url":"https://api.github.com/repos/Kingdaro/vue/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Kingdaro/vue/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Kingdaro/vue/git/refs{/sha}","trees_url":"https://api.github.com/repos/Kingdaro/vue/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Kingdaro/vue/statuses/{sha}","languages_url":"https://api.github.com/repos/Kingdaro/vue/languages","stargazers_url":"https://api.github.com/repos/Kingdaro/vue/stargazers","contributors_url":"https://api.github.com/repos/Kingdaro/vue/contributors","subscribers_url":"https://api.github.com/repos/Kingdaro/vue/subscribers","subscription_url":"https://api.github.com/repos/Kingdaro/vue/subscription","commits_url":"https://api.github.com/repos/Kingdaro/vue/commits{/sha}","git_commits_url":"https://api.github.com/repos/Kingdaro/vue/git/commits{/sha}","comments_url":"https://api.github.com/repos/Kingdaro/vue/comments{/number}","issue_comment_url":"https://api.github.com/repos/Kingdaro/vue/issues/comments{/number}","contents_url":"https://api.github.com/repos/Kingdaro/vue/contents/{+path}","compare_url":"https://api.github.com/repos/Kingdaro/vue/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Kingdaro/vue/merges","archive_url":"https://api.github.com/repos/Kingdaro/vue/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Kingdaro/vue/downloads","issues_url":"https://api.github.com/repos/Kingdaro/vue/issues{/number}","pulls_url":"https://api.github.com/repos/Kingdaro/vue/pulls{/number}","milestones_url":"https://api.github.com/repos/Kingdaro/vue/milestones{/number}","notifications_url":"https://api.github.com/repos/Kingdaro/vue/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Kingdaro/vue/labels{/name}","releases_url":"https://api.github.com/repos/Kingdaro/vue/releases{/id}","deployments_url":"https://api.github.com/repos/Kingdaro/vue/deployments","created_at":"2016-09-10T20:09:44Z","updated_at":"2016-09-10T20:09:49Z","pushed_at":"2016-09-11T13:14:26Z","git_url":"git://github.com/Kingdaro/vue.git","ssh_url":"git@github.com:Kingdaro/vue.git","clone_url":"https://github.com/Kingdaro/vue.git","svn_url":"https://github.com/Kingdaro/vue","homepage":"http://vuejs.org","size":13840,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"vuejs:next","ref":"next","sha":"673dec6040bcfc510866761b38439b9d34dd91f7","user":{"login":"vuejs","id":6128107,"avatar_url":"https://avatars.githubusercontent.com/u/6128107?v=3","gravatar_id":"","url":"https://api.github.com/users/vuejs","html_url":"https://github.com/vuejs","followers_url":"https://api.github.com/users/vuejs/followers","following_url":"https://api.github.com/users/vuejs/following{/other_user}","gists_url":"https://api.github.com/users/vuejs/gists{/gist_id}","starred_url":"https://api.github.com/users/vuejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vuejs/subscriptions","organizations_url":"https://api.github.com/users/vuejs/orgs","repos_url":"https://api.github.com/users/vuejs/repos","events_url":"https://api.github.com/users/vuejs/events{/privacy}","received_events_url":"https://api.github.com/users/vuejs/received_events","type":"Organization","site_admin":false},"repo":{"id":11730342,"name":"vue","full_name":"vuejs/vue","owner":{"login":"vuejs","id":6128107,"avatar_url":"https://avatars.githubusercontent.com/u/6128107?v=3","gravatar_id":"","url":"https://api.github.com/users/vuejs","html_url":"https://github.com/vuejs","followers_url":"https://api.github.com/users/vuejs/followers","following_url":"https://api.github.com/users/vuejs/following{/other_user}","gists_url":"https://api.github.com/users/vuejs/gists{/gist_id}","starred_url":"https://api.github.com/users/vuejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vuejs/subscriptions","organizations_url":"https://api.github.com/users/vuejs/orgs","repos_url":"https://api.github.com/users/vuejs/repos","events_url":"https://api.github.com/users/vuejs/events{/privacy}","received_events_url":"https://api.github.com/users/vuejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vuejs/vue","description":"Simple yet powerful library for building modern web interfaces.","fork":false,"url":"https://api.github.com/repos/vuejs/vue","forks_url":"https://api.github.com/repos/vuejs/vue/forks","keys_url":"https://api.github.com/repos/vuejs/vue/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vuejs/vue/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vuejs/vue/teams","hooks_url":"https://api.github.com/repos/vuejs/vue/hooks","issue_events_url":"https://api.github.com/repos/vuejs/vue/issues/events{/number}","events_url":"https://api.github.com/repos/vuejs/vue/events","assignees_url":"https://api.github.com/repos/vuejs/vue/assignees{/user}","branches_url":"https://api.github.com/repos/vuejs/vue/branches{/branch}","tags_url":"https://api.github.com/repos/vuejs/vue/tags","blobs_url":"https://api.github.com/repos/vuejs/vue/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vuejs/vue/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vuejs/vue/git/refs{/sha}","trees_url":"https://api.github.com/repos/vuejs/vue/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vuejs/vue/statuses/{sha}","languages_url":"https://api.github.com/repos/vuejs/vue/languages","stargazers_url":"https://api.github.com/repos/vuejs/vue/stargazers","contributors_url":"https://api.github.com/repos/vuejs/vue/contributors","subscribers_url":"https://api.github.com/repos/vuejs/vue/subscribers","subscription_url":"https://api.github.com/repos/vuejs/vue/subscription","commits_url":"https://api.github.com/repos/vuejs/vue/commits{/sha}","git_commits_url":"https://api.github.com/repos/vuejs/vue/git/commits{/sha}","comments_url":"https://api.github.com/repos/vuejs/vue/comments{/number}","issue_comment_url":"https://api.github.com/repos/vuejs/vue/issues/comments{/number}","contents_url":"https://api.github.com/repos/vuejs/vue/contents/{+path}","compare_url":"https://api.github.com/repos/vuejs/vue/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vuejs/vue/merges","archive_url":"https://api.github.com/repos/vuejs/vue/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vuejs/vue/downloads","issues_url":"https://api.github.com/repos/vuejs/vue/issues{/number}","pulls_url":"https://api.github.com/repos/vuejs/vue/pulls{/number}","milestones_url":"https://api.github.com/repos/vuejs/vue/milestones{/number}","notifications_url":"https://api.github.com/repos/vuejs/vue/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vuejs/vue/labels{/name}","releases_url":"https://api.github.com/repos/vuejs/vue/releases{/id}","deployments_url":"https://api.github.com/repos/vuejs/vue/deployments","created_at":"2013-07-29T03:24:51Z","updated_at":"2016-09-11T14:41:33Z","pushed_at":"2016-09-11T14:54:47Z","git_url":"git://github.com/vuejs/vue.git","ssh_url":"git@github.com:vuejs/vue.git","clone_url":"https://github.com/vuejs/vue.git","svn_url":"https://github.com/vuejs/vue","homepage":"http://vuejs.org","size":19368,"stargazers_count":26822,"watchers_count":26822,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2971,"mirror_url":null,"open_issues_count":42,"forks":2971,"open_issues":42,"watchers":26822,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/vuejs/vue/pulls/3656"},"html":{"href":"https://github.com/vuejs/vue/pull/3656"},"issue":{"href":"https://api.github.com/repos/vuejs/vue/issues/3656"},"comments":{"href":"https://api.github.com/repos/vuejs/vue/issues/3656/comments"},"review_comments":{"href":"https://api.github.com/repos/vuejs/vue/pulls/3656/comments"},"review_comment":{"href":"https://api.github.com/repos/vuejs/vue/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vuejs/vue/pulls/3656/commits"},"statuses":{"href":"https://api.github.com/repos/vuejs/vue/statuses/236fdc30c79dd4d35b755e353bf2a586a494dd09"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"yyx990803","id":499550,"avatar_url":"https://avatars.githubusercontent.com/u/499550?v=3","gravatar_id":"","url":"https://api.github.com/users/yyx990803","html_url":"https://github.com/yyx990803","followers_url":"https://api.github.com/users/yyx990803/followers","following_url":"https://api.github.com/users/yyx990803/following{/other_user}","gists_url":"https://api.github.com/users/yyx990803/gists{/gist_id}","starred_url":"https://api.github.com/users/yyx990803/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yyx990803/subscriptions","organizations_url":"https://api.github.com/users/yyx990803/orgs","repos_url":"https://api.github.com/users/yyx990803/repos","events_url":"https://api.github.com/users/yyx990803/events{/privacy}","received_events_url":"https://api.github.com/users/yyx990803/received_events","type":"User","site_admin":false},"comments":0,"review_comments":2,"commits":3,"additions":5,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"yyx990803"}}