{"action":"created","comment":{"url":"https://api.github.com/repos/caskdata/cdap/pulls/comments/79093301","id":79093301,"diff_hunk":"@@ -0,0 +1,127 @@\n+/*\n+ * Copyright © 2016 Cask Data, Inc.\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\"); you may not\n+ * use this file except in compliance with the License. You may obtain a copy of\n+ * the License at\n+ *\n+ * http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT\n+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the\n+ * License for the specific language governing permissions and limitations under\n+ * the License.\n+ */\n+\n+package co.cask.cdap.route.store;\n+\n+import co.cask.cdap.api.Transactional;\n+import co.cask.cdap.api.TxRunnable;\n+import co.cask.cdap.api.common.Bytes;\n+import co.cask.cdap.api.data.DatasetContext;\n+import co.cask.cdap.api.dataset.DatasetManagementException;\n+import co.cask.cdap.api.dataset.DatasetProperties;\n+import co.cask.cdap.api.dataset.lib.KeyValueTable;\n+import co.cask.cdap.common.NotFoundException;\n+import co.cask.cdap.common.service.ServiceDiscoverable;\n+import co.cask.cdap.data.dataset.SystemDatasetInstantiator;\n+import co.cask.cdap.data2.datafabric.dataset.DatasetsUtil;\n+import co.cask.cdap.data2.dataset2.DatasetFramework;\n+import co.cask.cdap.data2.dataset2.MultiThreadDatasetCache;\n+import co.cask.cdap.data2.transaction.Transactions;\n+import co.cask.cdap.data2.transaction.TxCallable;\n+import co.cask.cdap.internal.guava.reflect.TypeToken;\n+import co.cask.cdap.proto.id.DatasetId;\n+import co.cask.cdap.proto.id.NamespaceId;\n+import co.cask.cdap.proto.id.ProgramId;\n+import com.google.common.collect.ImmutableMap;\n+import com.google.gson.Gson;\n+import com.google.inject.Inject;\n+import org.apache.tephra.RetryStrategies;\n+import org.apache.tephra.TransactionFailureException;\n+import org.apache.tephra.TransactionSystemClient;\n+\n+import java.io.IOException;\n+import java.lang.reflect.Type;\n+import java.util.Map;\n+\n+/**\n+ * RouteStore where the routes are stored in a table for persistence. This is intended for use in SDK mode\n+ * where performance is not a big issue but we still need persistence of configuration routes across restarts.\n+ */\n+public class LocalRouteStore implements RouteStore  {\n+  private static final Gson GSON = new Gson();\n+  private static final Type MAP_STRING_INTEGER_TYPE = new TypeToken<Map<String, Integer>>() { }.getType();\n+  private static final DatasetId ROUTE_STORE_DATASET_INSTANCE_ID = NamespaceId.SYSTEM.dataset(\"routestore\");\n+\n+  private final DatasetFramework datasetFramework;\n+  private final Transactional transactional;\n+\n+  @Inject\n+  public LocalRouteStore(DatasetFramework datasetFramework, TransactionSystemClient txClient) {\n+    this.datasetFramework = datasetFramework;\n+    this.transactional = Transactions.createTransactionalWithRetry(\n+      Transactions.createTransactional(new MultiThreadDatasetCache(\n+        new SystemDatasetInstantiator(datasetFramework), txClient,\n+        NamespaceId.SYSTEM, ImmutableMap.<String, String>of(), null, null)), RetryStrategies.retryOnConflict(20, 100));\n+  }\n+\n+  private KeyValueTable getRouteTable(DatasetContext context) throws IOException, DatasetManagementException {\n+    return DatasetsUtil.getOrCreateDataset(context, datasetFramework, ROUTE_STORE_DATASET_INSTANCE_ID,\n+                                           KeyValueTable.class.getName(), DatasetProperties.EMPTY);\n+  }\n+\n+  @Override\n+  public void store(final ProgramId serviceId, final RouteConfig routeConfig) {\n+    try {\n+      transactional.execute(new TxRunnable() {\n+        @Override\n+        public void run(DatasetContext context) throws Exception {\n+          getRouteTable(context).write(ServiceDiscoverable.getName(serviceId), GSON.toJson(routeConfig.getRoutes()));\n+        }\n+      });\n+    } catch (TransactionFailureException ex) {\n+      throw Transactions.propagate(ex);\n+    }\n+  }\n+\n+  @Override\n+  public void delete(final ProgramId serviceId) throws NotFoundException {\n+    try {\n+      transactional.execute(new TxRunnable() {\n+        @Override\n+        public void run(DatasetContext context) throws Exception {\n+          byte[] key = Bytes.toBytes(ServiceDiscoverable.getName(serviceId));\n+          KeyValueTable kvTable = getRouteTable(context);\n+          if (kvTable.read(key) == null) {\n+            throw new NotFoundException(String.format(\"Route Config for Service %s was not found.\", serviceId));\n+          }\n+          kvTable.delete(key);\n+        }\n+      });\n+    } catch (TransactionFailureException e) {\n+      throw Transactions.propagate(e, NotFoundException.class);\n+    }\n+  }\n+\n+  @Override\n+  public RouteConfig fetch(final ProgramId serviceId) throws NotFoundException {\n+    try {\n+      return Transactions.execute(transactional, new TxCallable<RouteConfig>() {\n+        @Override\n+        public RouteConfig call(DatasetContext context) throws Exception {\n+          byte[] value = getRouteTable(context).read(ServiceDiscoverable.getName(serviceId));\n+          if (value == null || value.length == 0) {","path":"cdap-app-fabric/src/main/java/co/cask/cdap/route/store/LocalRouteStore.java","position":115,"original_position":115,"commit_id":"cecc63ec34db9ca0f4b285f3791406059469ba2e","original_commit_id":"cecc63ec34db9ca0f4b285f3791406059469ba2e","user":{"login":"anwar6953","id":2440977,"avatar_url":"https://avatars.githubusercontent.com/u/2440977?v=3","gravatar_id":"","url":"https://api.github.com/users/anwar6953","html_url":"https://github.com/anwar6953","followers_url":"https://api.github.com/users/anwar6953/followers","following_url":"https://api.github.com/users/anwar6953/following{/other_user}","gists_url":"https://api.github.com/users/anwar6953/gists{/gist_id}","starred_url":"https://api.github.com/users/anwar6953/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anwar6953/subscriptions","organizations_url":"https://api.github.com/users/anwar6953/orgs","repos_url":"https://api.github.com/users/anwar6953/repos","events_url":"https://api.github.com/users/anwar6953/events{/privacy}","received_events_url":"https://api.github.com/users/anwar6953/received_events","type":"User","site_admin":false},"body":"Why does this method check for length == 0, but the above methods don't?","created_at":"2016-09-16T01:12:48Z","updated_at":"2016-09-16T01:13:56Z","html_url":"https://github.com/caskdata/cdap/pull/6744#discussion_r79093301","pull_request_url":"https://api.github.com/repos/caskdata/cdap/pulls/6744","_links":{"self":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/comments/79093301"},"html":{"href":"https://github.com/caskdata/cdap/pull/6744#discussion_r79093301"},"pull_request":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/6744"}}},"pull_request":{"url":"https://api.github.com/repos/caskdata/cdap/pulls/6744","id":85502088,"html_url":"https://github.com/caskdata/cdap/pull/6744","diff_url":"https://github.com/caskdata/cdap/pull/6744.diff","patch_url":"https://github.com/caskdata/cdap/pull/6744.patch","issue_url":"https://api.github.com/repos/caskdata/cdap/issues/6744","number":6744,"state":"open","locked":false,"title":"CDAP-7268 CDAP-7269 REST Endpoint to store/retrieve config in RouteStore","user":{"login":"gokulavasan","id":558459,"avatar_url":"https://avatars.githubusercontent.com/u/558459?v=3","gravatar_id":"","url":"https://api.github.com/users/gokulavasan","html_url":"https://github.com/gokulavasan","followers_url":"https://api.github.com/users/gokulavasan/followers","following_url":"https://api.github.com/users/gokulavasan/following{/other_user}","gists_url":"https://api.github.com/users/gokulavasan/gists{/gist_id}","starred_url":"https://api.github.com/users/gokulavasan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gokulavasan/subscriptions","organizations_url":"https://api.github.com/users/gokulavasan/orgs","repos_url":"https://api.github.com/users/gokulavasan/repos","events_url":"https://api.github.com/users/gokulavasan/events{/privacy}","received_events_url":"https://api.github.com/users/gokulavasan/received_events","type":"User","site_admin":false},"body":"JIRAs:\r\nhttps://issues.cask.co/browse/CDAP-7268\r\nhttps://issues.cask.co/browse/CDAP-7269\r\nhttps://issues.cask.co/browse/CDAP-7272\r\n\r\nBuild:\r\nhttp://builds.cask.co/browse/CDAP-RUT171-1\r\n\r\nSummary:\r\ni) Introduce RouteStore interface which provides methods to store, retrieve, delete route configurations for user services\r\nii) LocalRouteStore -> stores the routes in a KVTable. \r\niii) ZKRouteStore -> stores the routes in ZK\r\niv) Changes to ProgramLifecycleHttpHandler to add three endpoints to get/put/delete routes.\r\nv) Routes have to be a map of string to integers and the values should add up to 100.\r\n\r\n\r\n","created_at":"2016-09-16T00:13:16Z","updated_at":"2016-09-16T01:13:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"af2cb54c674be3f968046db24326118d9fe7e689","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/caskdata/cdap/pulls/6744/commits","review_comments_url":"https://api.github.com/repos/caskdata/cdap/pulls/6744/comments","review_comment_url":"https://api.github.com/repos/caskdata/cdap/pulls/comments{/number}","comments_url":"https://api.github.com/repos/caskdata/cdap/issues/6744/comments","statuses_url":"https://api.github.com/repos/caskdata/cdap/statuses/cecc63ec34db9ca0f4b285f3791406059469ba2e","head":{"label":"caskdata:fix/cdap-7268","ref":"fix/cdap-7268","sha":"cecc63ec34db9ca0f4b285f3791406059469ba2e","user":{"login":"caskdata","id":8123023,"avatar_url":"https://avatars.githubusercontent.com/u/8123023?v=3","gravatar_id":"","url":"https://api.github.com/users/caskdata","html_url":"https://github.com/caskdata","followers_url":"https://api.github.com/users/caskdata/followers","following_url":"https://api.github.com/users/caskdata/following{/other_user}","gists_url":"https://api.github.com/users/caskdata/gists{/gist_id}","starred_url":"https://api.github.com/users/caskdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caskdata/subscriptions","organizations_url":"https://api.github.com/users/caskdata/orgs","repos_url":"https://api.github.com/users/caskdata/repos","events_url":"https://api.github.com/users/caskdata/events{/privacy}","received_events_url":"https://api.github.com/users/caskdata/received_events","type":"Organization","site_admin":false},"repo":{"id":22542759,"name":"cdap","full_name":"caskdata/cdap","owner":{"login":"caskdata","id":8123023,"avatar_url":"https://avatars.githubusercontent.com/u/8123023?v=3","gravatar_id":"","url":"https://api.github.com/users/caskdata","html_url":"https://github.com/caskdata","followers_url":"https://api.github.com/users/caskdata/followers","following_url":"https://api.github.com/users/caskdata/following{/other_user}","gists_url":"https://api.github.com/users/caskdata/gists{/gist_id}","starred_url":"https://api.github.com/users/caskdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caskdata/subscriptions","organizations_url":"https://api.github.com/users/caskdata/orgs","repos_url":"https://api.github.com/users/caskdata/repos","events_url":"https://api.github.com/users/caskdata/events{/privacy}","received_events_url":"https://api.github.com/users/caskdata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/caskdata/cdap","description":"Cask Data Application Platform (CDAP)","fork":false,"url":"https://api.github.com/repos/caskdata/cdap","forks_url":"https://api.github.com/repos/caskdata/cdap/forks","keys_url":"https://api.github.com/repos/caskdata/cdap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/caskdata/cdap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/caskdata/cdap/teams","hooks_url":"https://api.github.com/repos/caskdata/cdap/hooks","issue_events_url":"https://api.github.com/repos/caskdata/cdap/issues/events{/number}","events_url":"https://api.github.com/repos/caskdata/cdap/events","assignees_url":"https://api.github.com/repos/caskdata/cdap/assignees{/user}","branches_url":"https://api.github.com/repos/caskdata/cdap/branches{/branch}","tags_url":"https://api.github.com/repos/caskdata/cdap/tags","blobs_url":"https://api.github.com/repos/caskdata/cdap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/caskdata/cdap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/caskdata/cdap/git/refs{/sha}","trees_url":"https://api.github.com/repos/caskdata/cdap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/caskdata/cdap/statuses/{sha}","languages_url":"https://api.github.com/repos/caskdata/cdap/languages","stargazers_url":"https://api.github.com/repos/caskdata/cdap/stargazers","contributors_url":"https://api.github.com/repos/caskdata/cdap/contributors","subscribers_url":"https://api.github.com/repos/caskdata/cdap/subscribers","subscription_url":"https://api.github.com/repos/caskdata/cdap/subscription","commits_url":"https://api.github.com/repos/caskdata/cdap/commits{/sha}","git_commits_url":"https://api.github.com/repos/caskdata/cdap/git/commits{/sha}","comments_url":"https://api.github.com/repos/caskdata/cdap/comments{/number}","issue_comment_url":"https://api.github.com/repos/caskdata/cdap/issues/comments{/number}","contents_url":"https://api.github.com/repos/caskdata/cdap/contents/{+path}","compare_url":"https://api.github.com/repos/caskdata/cdap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/caskdata/cdap/merges","archive_url":"https://api.github.com/repos/caskdata/cdap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/caskdata/cdap/downloads","issues_url":"https://api.github.com/repos/caskdata/cdap/issues{/number}","pulls_url":"https://api.github.com/repos/caskdata/cdap/pulls{/number}","milestones_url":"https://api.github.com/repos/caskdata/cdap/milestones{/number}","notifications_url":"https://api.github.com/repos/caskdata/cdap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/caskdata/cdap/labels{/name}","releases_url":"https://api.github.com/repos/caskdata/cdap/releases{/id}","deployments_url":"https://api.github.com/repos/caskdata/cdap/deployments","created_at":"2014-08-02T09:00:10Z","updated_at":"2016-09-12T03:52:20Z","pushed_at":"2016-09-16T00:54:15Z","git_url":"git://github.com/caskdata/cdap.git","ssh_url":"git@github.com:caskdata/cdap.git","clone_url":"https://github.com/caskdata/cdap.git","svn_url":"https://github.com/caskdata/cdap","homepage":"http://cdap.io","size":651085,"stargazers_count":136,"watchers_count":136,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":53,"mirror_url":null,"open_issues_count":11,"forks":53,"open_issues":11,"watchers":136,"default_branch":"develop"}},"base":{"label":"caskdata:release/3.6","ref":"release/3.6","sha":"68e65c49d011ca9545650abad720b1c743fb981d","user":{"login":"caskdata","id":8123023,"avatar_url":"https://avatars.githubusercontent.com/u/8123023?v=3","gravatar_id":"","url":"https://api.github.com/users/caskdata","html_url":"https://github.com/caskdata","followers_url":"https://api.github.com/users/caskdata/followers","following_url":"https://api.github.com/users/caskdata/following{/other_user}","gists_url":"https://api.github.com/users/caskdata/gists{/gist_id}","starred_url":"https://api.github.com/users/caskdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caskdata/subscriptions","organizations_url":"https://api.github.com/users/caskdata/orgs","repos_url":"https://api.github.com/users/caskdata/repos","events_url":"https://api.github.com/users/caskdata/events{/privacy}","received_events_url":"https://api.github.com/users/caskdata/received_events","type":"Organization","site_admin":false},"repo":{"id":22542759,"name":"cdap","full_name":"caskdata/cdap","owner":{"login":"caskdata","id":8123023,"avatar_url":"https://avatars.githubusercontent.com/u/8123023?v=3","gravatar_id":"","url":"https://api.github.com/users/caskdata","html_url":"https://github.com/caskdata","followers_url":"https://api.github.com/users/caskdata/followers","following_url":"https://api.github.com/users/caskdata/following{/other_user}","gists_url":"https://api.github.com/users/caskdata/gists{/gist_id}","starred_url":"https://api.github.com/users/caskdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caskdata/subscriptions","organizations_url":"https://api.github.com/users/caskdata/orgs","repos_url":"https://api.github.com/users/caskdata/repos","events_url":"https://api.github.com/users/caskdata/events{/privacy}","received_events_url":"https://api.github.com/users/caskdata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/caskdata/cdap","description":"Cask Data Application Platform (CDAP)","fork":false,"url":"https://api.github.com/repos/caskdata/cdap","forks_url":"https://api.github.com/repos/caskdata/cdap/forks","keys_url":"https://api.github.com/repos/caskdata/cdap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/caskdata/cdap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/caskdata/cdap/teams","hooks_url":"https://api.github.com/repos/caskdata/cdap/hooks","issue_events_url":"https://api.github.com/repos/caskdata/cdap/issues/events{/number}","events_url":"https://api.github.com/repos/caskdata/cdap/events","assignees_url":"https://api.github.com/repos/caskdata/cdap/assignees{/user}","branches_url":"https://api.github.com/repos/caskdata/cdap/branches{/branch}","tags_url":"https://api.github.com/repos/caskdata/cdap/tags","blobs_url":"https://api.github.com/repos/caskdata/cdap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/caskdata/cdap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/caskdata/cdap/git/refs{/sha}","trees_url":"https://api.github.com/repos/caskdata/cdap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/caskdata/cdap/statuses/{sha}","languages_url":"https://api.github.com/repos/caskdata/cdap/languages","stargazers_url":"https://api.github.com/repos/caskdata/cdap/stargazers","contributors_url":"https://api.github.com/repos/caskdata/cdap/contributors","subscribers_url":"https://api.github.com/repos/caskdata/cdap/subscribers","subscription_url":"https://api.github.com/repos/caskdata/cdap/subscription","commits_url":"https://api.github.com/repos/caskdata/cdap/commits{/sha}","git_commits_url":"https://api.github.com/repos/caskdata/cdap/git/commits{/sha}","comments_url":"https://api.github.com/repos/caskdata/cdap/comments{/number}","issue_comment_url":"https://api.github.com/repos/caskdata/cdap/issues/comments{/number}","contents_url":"https://api.github.com/repos/caskdata/cdap/contents/{+path}","compare_url":"https://api.github.com/repos/caskdata/cdap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/caskdata/cdap/merges","archive_url":"https://api.github.com/repos/caskdata/cdap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/caskdata/cdap/downloads","issues_url":"https://api.github.com/repos/caskdata/cdap/issues{/number}","pulls_url":"https://api.github.com/repos/caskdata/cdap/pulls{/number}","milestones_url":"https://api.github.com/repos/caskdata/cdap/milestones{/number}","notifications_url":"https://api.github.com/repos/caskdata/cdap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/caskdata/cdap/labels{/name}","releases_url":"https://api.github.com/repos/caskdata/cdap/releases{/id}","deployments_url":"https://api.github.com/repos/caskdata/cdap/deployments","created_at":"2014-08-02T09:00:10Z","updated_at":"2016-09-12T03:52:20Z","pushed_at":"2016-09-16T00:54:15Z","git_url":"git://github.com/caskdata/cdap.git","ssh_url":"git@github.com:caskdata/cdap.git","clone_url":"https://github.com/caskdata/cdap.git","svn_url":"https://github.com/caskdata/cdap","homepage":"http://cdap.io","size":651085,"stargazers_count":136,"watchers_count":136,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":53,"mirror_url":null,"open_issues_count":11,"forks":53,"open_issues":11,"watchers":136,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/6744"},"html":{"href":"https://github.com/caskdata/cdap/pull/6744"},"issue":{"href":"https://api.github.com/repos/caskdata/cdap/issues/6744"},"comments":{"href":"https://api.github.com/repos/caskdata/cdap/issues/6744/comments"},"review_comments":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/6744/comments"},"review_comment":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/6744/commits"},"statuses":{"href":"https://api.github.com/repos/caskdata/cdap/statuses/cecc63ec34db9ca0f4b285f3791406059469ba2e"}}}}
{"actor":{"display_login":"anwar6953"}}