{"action":"created","comment":{"url":"https://api.github.com/repos/yast/yast-network/pulls/comments/59339955","id":59339955,"diff_hunk":"@@ -2336,6 +2336,8 @@ def createS390Device(rule)\n     #  @param [Array] list of hashes describing interfaces in AY profile\n     #  @return [Array] list of hashes for udev rules\n     def createUdevFromIfaceName(interfaces)\n+      return [] if !interfaces || interfaces.empty?","path":"src/modules/LanItems.rb","position":4,"original_position":4,"commit_id":"2fa7778c48862f47f854892477abdc8fd8a0f5ff","original_commit_id":"2fa7778c48862f47f854892477abdc8fd8a0f5ff","user":{"login":"kobliha","id":463995,"avatar_url":"https://avatars.githubusercontent.com/u/463995?v=3","gravatar_id":"","url":"https://api.github.com/users/kobliha","html_url":"https://github.com/kobliha","followers_url":"https://api.github.com/users/kobliha/followers","following_url":"https://api.github.com/users/kobliha/following{/other_user}","gists_url":"https://api.github.com/users/kobliha/gists{/gist_id}","starred_url":"https://api.github.com/users/kobliha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kobliha/subscriptions","organizations_url":"https://api.github.com/users/kobliha/orgs","repos_url":"https://api.github.com/users/kobliha/repos","events_url":"https://api.github.com/users/kobliha/events{/privacy}","received_events_url":"https://api.github.com/users/kobliha/received_events","type":"User","site_admin":false},"body":"It's the fastest exit from the method, which easy to understand and independent on the rest of the code even in the future","created_at":"2016-04-12T08:37:17Z","updated_at":"2016-04-12T08:37:17Z","html_url":"https://github.com/yast/yast-network/pull/396#discussion_r59339955","pull_request_url":"https://api.github.com/repos/yast/yast-network/pulls/396","_links":{"self":{"href":"https://api.github.com/repos/yast/yast-network/pulls/comments/59339955"},"html":{"href":"https://github.com/yast/yast-network/pull/396#discussion_r59339955"},"pull_request":{"href":"https://api.github.com/repos/yast/yast-network/pulls/396"}}},"pull_request":{"url":"https://api.github.com/repos/yast/yast-network/pulls/396","id":66115894,"html_url":"https://github.com/yast/yast-network/pull/396","diff_url":"https://github.com/yast/yast-network/pull/396.diff","patch_url":"https://github.com/yast/yast-network/pull/396.patch","issue_url":"https://api.github.com/repos/yast/yast-network/issues/396","number":396,"state":"closed","locked":false,"title":"Fixed internal error found by AY integration tests","user":{"login":"mchf","id":1579239,"avatar_url":"https://avatars.githubusercontent.com/u/1579239?v=3","gravatar_id":"","url":"https://api.github.com/users/mchf","html_url":"https://github.com/mchf","followers_url":"https://api.github.com/users/mchf/followers","following_url":"https://api.github.com/users/mchf/following{/other_user}","gists_url":"https://api.github.com/users/mchf/gists{/gist_id}","starred_url":"https://api.github.com/users/mchf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mchf/subscriptions","organizations_url":"https://api.github.com/users/mchf/orgs","repos_url":"https://api.github.com/users/mchf/repos","events_url":"https://api.github.com/users/mchf/events{/privacy}","received_events_url":"https://api.github.com/users/mchf/received_events","type":"User","site_admin":false},"body":"bnc#974910\r\n\r\nadditional info:\r\n![boot4](https://cloud.githubusercontent.com/assets/1579239/14453993/61c777ca-0098-11e6-881e-76ab55fa976c.jpeg)\r\n","created_at":"2016-04-12T08:06:33Z","updated_at":"2016-04-12T08:37:17Z","closed_at":"2016-04-12T08:22:35Z","merged_at":"2016-04-12T08:22:35Z","merge_commit_sha":"f1f280e864554fe221184dbdb3ec11a18f2e8ce6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/yast/yast-network/pulls/396/commits","review_comments_url":"https://api.github.com/repos/yast/yast-network/pulls/396/comments","review_comment_url":"https://api.github.com/repos/yast/yast-network/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yast/yast-network/issues/396/comments","statuses_url":"https://api.github.com/repos/yast/yast-network/statuses/2fa7778c48862f47f854892477abdc8fd8a0f5ff","head":{"label":"mchf:master","ref":"master","sha":"2fa7778c48862f47f854892477abdc8fd8a0f5ff","user":{"login":"mchf","id":1579239,"avatar_url":"https://avatars.githubusercontent.com/u/1579239?v=3","gravatar_id":"","url":"https://api.github.com/users/mchf","html_url":"https://github.com/mchf","followers_url":"https://api.github.com/users/mchf/followers","following_url":"https://api.github.com/users/mchf/following{/other_user}","gists_url":"https://api.github.com/users/mchf/gists{/gist_id}","starred_url":"https://api.github.com/users/mchf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mchf/subscriptions","organizations_url":"https://api.github.com/users/mchf/orgs","repos_url":"https://api.github.com/users/mchf/repos","events_url":"https://api.github.com/users/mchf/events{/privacy}","received_events_url":"https://api.github.com/users/mchf/received_events","type":"User","site_admin":false},"repo":{"id":4748313,"name":"yast-network","full_name":"mchf/yast-network","owner":{"login":"mchf","id":1579239,"avatar_url":"https://avatars.githubusercontent.com/u/1579239?v=3","gravatar_id":"","url":"https://api.github.com/users/mchf","html_url":"https://github.com/mchf","followers_url":"https://api.github.com/users/mchf/followers","following_url":"https://api.github.com/users/mchf/following{/other_user}","gists_url":"https://api.github.com/users/mchf/gists{/gist_id}","starred_url":"https://api.github.com/users/mchf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mchf/subscriptions","organizations_url":"https://api.github.com/users/mchf/orgs","repos_url":"https://api.github.com/users/mchf/repos","events_url":"https://api.github.com/users/mchf/events{/privacy}","received_events_url":"https://api.github.com/users/mchf/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mchf/yast-network","description":"YaST module network","fork":true,"url":"https://api.github.com/repos/mchf/yast-network","forks_url":"https://api.github.com/repos/mchf/yast-network/forks","keys_url":"https://api.github.com/repos/mchf/yast-network/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mchf/yast-network/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mchf/yast-network/teams","hooks_url":"https://api.github.com/repos/mchf/yast-network/hooks","issue_events_url":"https://api.github.com/repos/mchf/yast-network/issues/events{/number}","events_url":"https://api.github.com/repos/mchf/yast-network/events","assignees_url":"https://api.github.com/repos/mchf/yast-network/assignees{/user}","branches_url":"https://api.github.com/repos/mchf/yast-network/branches{/branch}","tags_url":"https://api.github.com/repos/mchf/yast-network/tags","blobs_url":"https://api.github.com/repos/mchf/yast-network/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mchf/yast-network/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mchf/yast-network/git/refs{/sha}","trees_url":"https://api.github.com/repos/mchf/yast-network/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mchf/yast-network/statuses/{sha}","languages_url":"https://api.github.com/repos/mchf/yast-network/languages","stargazers_url":"https://api.github.com/repos/mchf/yast-network/stargazers","contributors_url":"https://api.github.com/repos/mchf/yast-network/contributors","subscribers_url":"https://api.github.com/repos/mchf/yast-network/subscribers","subscription_url":"https://api.github.com/repos/mchf/yast-network/subscription","commits_url":"https://api.github.com/repos/mchf/yast-network/commits{/sha}","git_commits_url":"https://api.github.com/repos/mchf/yast-network/git/commits{/sha}","comments_url":"https://api.github.com/repos/mchf/yast-network/comments{/number}","issue_comment_url":"https://api.github.com/repos/mchf/yast-network/issues/comments{/number}","contents_url":"https://api.github.com/repos/mchf/yast-network/contents/{+path}","compare_url":"https://api.github.com/repos/mchf/yast-network/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mchf/yast-network/merges","archive_url":"https://api.github.com/repos/mchf/yast-network/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mchf/yast-network/downloads","issues_url":"https://api.github.com/repos/mchf/yast-network/issues{/number}","pulls_url":"https://api.github.com/repos/mchf/yast-network/pulls{/number}","milestones_url":"https://api.github.com/repos/mchf/yast-network/milestones{/number}","notifications_url":"https://api.github.com/repos/mchf/yast-network/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mchf/yast-network/labels{/name}","releases_url":"https://api.github.com/repos/mchf/yast-network/releases{/id}","deployments_url":"https://api.github.com/repos/mchf/yast-network/deployments","created_at":"2012-06-22T06:44:13Z","updated_at":"2015-05-06T13:22:26Z","pushed_at":"2016-04-12T08:05:14Z","git_url":"git://github.com/mchf/yast-network.git","ssh_url":"git@github.com:mchf/yast-network.git","clone_url":"https://github.com/mchf/yast-network.git","svn_url":"https://github.com/mchf/yast-network","homepage":"http://en.opensuse.org/Portal:YaST","size":24428,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"yast:master","ref":"master","sha":"6f1aa6a18d15ac77a61597cbe5330611aace786f","user":{"login":"yast","id":909990,"avatar_url":"https://avatars.githubusercontent.com/u/909990?v=3","gravatar_id":"","url":"https://api.github.com/users/yast","html_url":"https://github.com/yast","followers_url":"https://api.github.com/users/yast/followers","following_url":"https://api.github.com/users/yast/following{/other_user}","gists_url":"https://api.github.com/users/yast/gists{/gist_id}","starred_url":"https://api.github.com/users/yast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yast/subscriptions","organizations_url":"https://api.github.com/users/yast/orgs","repos_url":"https://api.github.com/users/yast/repos","events_url":"https://api.github.com/users/yast/events{/privacy}","received_events_url":"https://api.github.com/users/yast/received_events","type":"Organization","site_admin":false},"repo":{"id":4368160,"name":"yast-network","full_name":"yast/yast-network","owner":{"login":"yast","id":909990,"avatar_url":"https://avatars.githubusercontent.com/u/909990?v=3","gravatar_id":"","url":"https://api.github.com/users/yast","html_url":"https://github.com/yast","followers_url":"https://api.github.com/users/yast/followers","following_url":"https://api.github.com/users/yast/following{/other_user}","gists_url":"https://api.github.com/users/yast/gists{/gist_id}","starred_url":"https://api.github.com/users/yast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yast/subscriptions","organizations_url":"https://api.github.com/users/yast/orgs","repos_url":"https://api.github.com/users/yast/repos","events_url":"https://api.github.com/users/yast/events{/privacy}","received_events_url":"https://api.github.com/users/yast/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yast/yast-network","description":"YaST module network","fork":false,"url":"https://api.github.com/repos/yast/yast-network","forks_url":"https://api.github.com/repos/yast/yast-network/forks","keys_url":"https://api.github.com/repos/yast/yast-network/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yast/yast-network/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yast/yast-network/teams","hooks_url":"https://api.github.com/repos/yast/yast-network/hooks","issue_events_url":"https://api.github.com/repos/yast/yast-network/issues/events{/number}","events_url":"https://api.github.com/repos/yast/yast-network/events","assignees_url":"https://api.github.com/repos/yast/yast-network/assignees{/user}","branches_url":"https://api.github.com/repos/yast/yast-network/branches{/branch}","tags_url":"https://api.github.com/repos/yast/yast-network/tags","blobs_url":"https://api.github.com/repos/yast/yast-network/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yast/yast-network/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yast/yast-network/git/refs{/sha}","trees_url":"https://api.github.com/repos/yast/yast-network/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yast/yast-network/statuses/{sha}","languages_url":"https://api.github.com/repos/yast/yast-network/languages","stargazers_url":"https://api.github.com/repos/yast/yast-network/stargazers","contributors_url":"https://api.github.com/repos/yast/yast-network/contributors","subscribers_url":"https://api.github.com/repos/yast/yast-network/subscribers","subscription_url":"https://api.github.com/repos/yast/yast-network/subscription","commits_url":"https://api.github.com/repos/yast/yast-network/commits{/sha}","git_commits_url":"https://api.github.com/repos/yast/yast-network/git/commits{/sha}","comments_url":"https://api.github.com/repos/yast/yast-network/comments{/number}","issue_comment_url":"https://api.github.com/repos/yast/yast-network/issues/comments{/number}","contents_url":"https://api.github.com/repos/yast/yast-network/contents/{+path}","compare_url":"https://api.github.com/repos/yast/yast-network/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yast/yast-network/merges","archive_url":"https://api.github.com/repos/yast/yast-network/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yast/yast-network/downloads","issues_url":"https://api.github.com/repos/yast/yast-network/issues{/number}","pulls_url":"https://api.github.com/repos/yast/yast-network/pulls{/number}","milestones_url":"https://api.github.com/repos/yast/yast-network/milestones{/number}","notifications_url":"https://api.github.com/repos/yast/yast-network/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yast/yast-network/labels{/name}","releases_url":"https://api.github.com/repos/yast/yast-network/releases{/id}","deployments_url":"https://api.github.com/repos/yast/yast-network/deployments","created_at":"2012-05-18T10:24:50Z","updated_at":"2016-02-18T10:00:30Z","pushed_at":"2016-04-12T08:22:35Z","git_url":"git://github.com/yast/yast-network.git","ssh_url":"git@github.com:yast/yast-network.git","clone_url":"https://github.com/yast/yast-network.git","svn_url":"https://github.com/yast/yast-network","homepage":"http://en.opensuse.org/Portal:YaST","size":24537,"stargazers_count":6,"watchers_count":6,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":2,"forks":19,"open_issues":2,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yast/yast-network/pulls/396"},"html":{"href":"https://github.com/yast/yast-network/pull/396"},"issue":{"href":"https://api.github.com/repos/yast/yast-network/issues/396"},"comments":{"href":"https://api.github.com/repos/yast/yast-network/issues/396/comments"},"review_comments":{"href":"https://api.github.com/repos/yast/yast-network/pulls/396/comments"},"review_comment":{"href":"https://api.github.com/repos/yast/yast-network/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yast/yast-network/pulls/396/commits"},"statuses":{"href":"https://api.github.com/repos/yast/yast-network/statuses/2fa7778c48862f47f854892477abdc8fd8a0f5ff"}}}}