{"action":"closed","number":56,"pull_request":{"url":"https://api.github.com/repos/citruspi/Spotify-Notifications/pulls/56","id":47343493,"html_url":"https://github.com/citruspi/Spotify-Notifications/pull/56","diff_url":"https://github.com/citruspi/Spotify-Notifications/pull/56.diff","patch_url":"https://github.com/citruspi/Spotify-Notifications/pull/56.patch","issue_url":"https://api.github.com/repos/citruspi/Spotify-Notifications/issues/56","number":56,"state":"closed","locked":false,"title":"Revamped Preferences UI, tidied code","user":{"login":"sebj","id":379991,"avatar_url":"https://avatars.githubusercontent.com/u/379991?v=3","gravatar_id":"","url":"https://api.github.com/users/sebj","html_url":"https://github.com/sebj","followers_url":"https://api.github.com/users/sebj/followers","following_url":"https://api.github.com/users/sebj/following{/other_user}","gists_url":"https://api.github.com/users/sebj/gists{/gist_id}","starred_url":"https://api.github.com/users/sebj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebj/subscriptions","organizations_url":"https://api.github.com/users/sebj/orgs","repos_url":"https://api.github.com/users/sebj/repos","events_url":"https://api.github.com/users/sebj/events{/privacy}","received_events_url":"https://api.github.com/users/sebj/received_events","type":"User","site_admin":false},"body":"Nice work on Spotify Notifications, I've been using it for a while and found it very useful! (I don't know why Spotify still doesn't have native Mac notifications..)\r\n\r\n*Changes:*\r\n\r\n**UI:**\r\nI replaced the strange combo boxes in the Preferences window with checkboxes, and organised the window better:\r\n![Imgur Preview](http://i.imgur.com/IaPLPfT.png)\r\n\r\nA small addition is the ability to skip the current song (hover on notification to show button), like with iTunes:\r\n![Regular notification](http://i.imgur.com/3DXUyyA.png)\r\n![Hover on notification](http://imgur.com/nTvIvZC.png)\r\n\r\n**Code:**\r\nAs for code, preferences are now updated and kept in sync via bindings, rather than manually calling methods/updating when the user clicks.\r\n\r\nCode's a bit more concise/tidy by using dot-syntax; removing unnecessary `@synthesize` lines; defining a few shared keys for storing preferences in `SharedKeys.h` instead of repeating strings in code (with the possibility of mistakes); and marking code sections with `#pragma mark - Section Name` for easier navigation.\r\n\r\nThis uses #27, and solves #18, #23 and #53.","created_at":"2015-10-10T11:09:18Z","updated_at":"2016-09-30T10:53:50Z","closed_at":"2016-09-30T10:53:50Z","merged_at":"2016-09-30T10:53:50Z","merge_commit_sha":"f25869da74876ff147e2266312c628b9dbf69da7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/citruspi/Spotify-Notifications/pulls/56/commits","review_comments_url":"https://api.github.com/repos/citruspi/Spotify-Notifications/pulls/56/comments","review_comment_url":"https://api.github.com/repos/citruspi/Spotify-Notifications/pulls/comments{/number}","comments_url":"https://api.github.com/repos/citruspi/Spotify-Notifications/issues/56/comments","statuses_url":"https://api.github.com/repos/citruspi/Spotify-Notifications/statuses/b40274d8e35ded899b6817c197a25b3870e07a1a","head":{"label":"sebj:0.5.X","ref":"0.5.X","sha":"b40274d8e35ded899b6817c197a25b3870e07a1a","user":{"login":"sebj","id":379991,"avatar_url":"https://avatars.githubusercontent.com/u/379991?v=3","gravatar_id":"","url":"https://api.github.com/users/sebj","html_url":"https://github.com/sebj","followers_url":"https://api.github.com/users/sebj/followers","following_url":"https://api.github.com/users/sebj/following{/other_user}","gists_url":"https://api.github.com/users/sebj/gists{/gist_id}","starred_url":"https://api.github.com/users/sebj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebj/subscriptions","organizations_url":"https://api.github.com/users/sebj/orgs","repos_url":"https://api.github.com/users/sebj/repos","events_url":"https://api.github.com/users/sebj/events{/privacy}","received_events_url":"https://api.github.com/users/sebj/received_events","type":"User","site_admin":false},"repo":{"id":44004776,"name":"Spotify-Notifications","full_name":"sebj/Spotify-Notifications","owner":{"login":"sebj","id":379991,"avatar_url":"https://avatars.githubusercontent.com/u/379991?v=3","gravatar_id":"","url":"https://api.github.com/users/sebj","html_url":"https://github.com/sebj","followers_url":"https://api.github.com/users/sebj/followers","following_url":"https://api.github.com/users/sebj/following{/other_user}","gists_url":"https://api.github.com/users/sebj/gists{/gist_id}","starred_url":"https://api.github.com/users/sebj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebj/subscriptions","organizations_url":"https://api.github.com/users/sebj/orgs","repos_url":"https://api.github.com/users/sebj/repos","events_url":"https://api.github.com/users/sebj/events{/privacy}","received_events_url":"https://api.github.com/users/sebj/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sebj/Spotify-Notifications","description":"Bridging Spotify and OS X Notification Center","fork":true,"url":"https://api.github.com/repos/sebj/Spotify-Notifications","forks_url":"https://api.github.com/repos/sebj/Spotify-Notifications/forks","keys_url":"https://api.github.com/repos/sebj/Spotify-Notifications/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sebj/Spotify-Notifications/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sebj/Spotify-Notifications/teams","hooks_url":"https://api.github.com/repos/sebj/Spotify-Notifications/hooks","issue_events_url":"https://api.github.com/repos/sebj/Spotify-Notifications/issues/events{/number}","events_url":"https://api.github.com/repos/sebj/Spotify-Notifications/events","assignees_url":"https://api.github.com/repos/sebj/Spotify-Notifications/assignees{/user}","branches_url":"https://api.github.com/repos/sebj/Spotify-Notifications/branches{/branch}","tags_url":"https://api.github.com/repos/sebj/Spotify-Notifications/tags","blobs_url":"https://api.github.com/repos/sebj/Spotify-Notifications/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sebj/Spotify-Notifications/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sebj/Spotify-Notifications/git/refs{/sha}","trees_url":"https://api.github.com/repos/sebj/Spotify-Notifications/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sebj/Spotify-Notifications/statuses/{sha}","languages_url":"https://api.github.com/repos/sebj/Spotify-Notifications/languages","stargazers_url":"https://api.github.com/repos/sebj/Spotify-Notifications/stargazers","contributors_url":"https://api.github.com/repos/sebj/Spotify-Notifications/contributors","subscribers_url":"https://api.github.com/repos/sebj/Spotify-Notifications/subscribers","subscription_url":"https://api.github.com/repos/sebj/Spotify-Notifications/subscription","commits_url":"https://api.github.com/repos/sebj/Spotify-Notifications/commits{/sha}","git_commits_url":"https://api.github.com/repos/sebj/Spotify-Notifications/git/commits{/sha}","comments_url":"https://api.github.com/repos/sebj/Spotify-Notifications/comments{/number}","issue_comment_url":"https://api.github.com/repos/sebj/Spotify-Notifications/issues/comments{/number}","contents_url":"https://api.github.com/repos/sebj/Spotify-Notifications/contents/{+path}","compare_url":"https://api.github.com/repos/sebj/Spotify-Notifications/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sebj/Spotify-Notifications/merges","archive_url":"https://api.github.com/repos/sebj/Spotify-Notifications/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sebj/Spotify-Notifications/downloads","issues_url":"https://api.github.com/repos/sebj/Spotify-Notifications/issues{/number}","pulls_url":"https://api.github.com/repos/sebj/Spotify-Notifications/pulls{/number}","milestones_url":"https://api.github.com/repos/sebj/Spotify-Notifications/milestones{/number}","notifications_url":"https://api.github.com/repos/sebj/Spotify-Notifications/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sebj/Spotify-Notifications/labels{/name}","releases_url":"https://api.github.com/repos/sebj/Spotify-Notifications/releases{/id}","deployments_url":"https://api.github.com/repos/sebj/Spotify-Notifications/deployments","created_at":"2015-10-10T09:44:41Z","updated_at":"2016-06-18T14:24:48Z","pushed_at":"2016-09-30T10:50:23Z","git_url":"git://github.com/sebj/Spotify-Notifications.git","ssh_url":"git@github.com:sebj/Spotify-Notifications.git","clone_url":"https://github.com/sebj/Spotify-Notifications.git","svn_url":"https://github.com/sebj/Spotify-Notifications","homepage":"spotify-notifications.citruspi.io","size":1714,"stargazers_count":1,"watchers_count":1,"language":"Swift","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"citruspi:0.5.X","ref":"0.5.X","sha":"6da515f1bf352ad0c2917ad9450420f1befd6a3a","user":{"login":"citruspi","id":2125849,"avatar_url":"https://avatars.githubusercontent.com/u/2125849?v=3","gravatar_id":"","url":"https://api.github.com/users/citruspi","html_url":"https://github.com/citruspi","followers_url":"https://api.github.com/users/citruspi/followers","following_url":"https://api.github.com/users/citruspi/following{/other_user}","gists_url":"https://api.github.com/users/citruspi/gists{/gist_id}","starred_url":"https://api.github.com/users/citruspi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/citruspi/subscriptions","organizations_url":"https://api.github.com/users/citruspi/orgs","repos_url":"https://api.github.com/users/citruspi/repos","events_url":"https://api.github.com/users/citruspi/events{/privacy}","received_events_url":"https://api.github.com/users/citruspi/received_events","type":"User","site_admin":false},"repo":{"id":9270240,"name":"Spotify-Notifications","full_name":"citruspi/Spotify-Notifications","owner":{"login":"citruspi","id":2125849,"avatar_url":"https://avatars.githubusercontent.com/u/2125849?v=3","gravatar_id":"","url":"https://api.github.com/users/citruspi","html_url":"https://github.com/citruspi","followers_url":"https://api.github.com/users/citruspi/followers","following_url":"https://api.github.com/users/citruspi/following{/other_user}","gists_url":"https://api.github.com/users/citruspi/gists{/gist_id}","starred_url":"https://api.github.com/users/citruspi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/citruspi/subscriptions","organizations_url":"https://api.github.com/users/citruspi/orgs","repos_url":"https://api.github.com/users/citruspi/repos","events_url":"https://api.github.com/users/citruspi/events{/privacy}","received_events_url":"https://api.github.com/users/citruspi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/citruspi/Spotify-Notifications","description":"Bridging Spotify and OS X Notification Center","fork":false,"url":"https://api.github.com/repos/citruspi/Spotify-Notifications","forks_url":"https://api.github.com/repos/citruspi/Spotify-Notifications/forks","keys_url":"https://api.github.com/repos/citruspi/Spotify-Notifications/keys{/key_id}","collaborators_url":"https://api.github.com/repos/citruspi/Spotify-Notifications/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/citruspi/Spotify-Notifications/teams","hooks_url":"https://api.github.com/repos/citruspi/Spotify-Notifications/hooks","issue_events_url":"https://api.github.com/repos/citruspi/Spotify-Notifications/issues/events{/number}","events_url":"https://api.github.com/repos/citruspi/Spotify-Notifications/events","assignees_url":"https://api.github.com/repos/citruspi/Spotify-Notifications/assignees{/user}","branches_url":"https://api.github.com/repos/citruspi/Spotify-Notifications/branches{/branch}","tags_url":"https://api.github.com/repos/citruspi/Spotify-Notifications/tags","blobs_url":"https://api.github.com/repos/citruspi/Spotify-Notifications/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/citruspi/Spotify-Notifications/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/citruspi/Spotify-Notifications/git/refs{/sha}","trees_url":"https://api.github.com/repos/citruspi/Spotify-Notifications/git/trees{/sha}","statuses_url":"https://api.github.com/repos/citruspi/Spotify-Notifications/statuses/{sha}","languages_url":"https://api.github.com/repos/citruspi/Spotify-Notifications/languages","stargazers_url":"https://api.github.com/repos/citruspi/Spotify-Notifications/stargazers","contributors_url":"https://api.github.com/repos/citruspi/Spotify-Notifications/contributors","subscribers_url":"https://api.github.com/repos/citruspi/Spotify-Notifications/subscribers","subscription_url":"https://api.github.com/repos/citruspi/Spotify-Notifications/subscription","commits_url":"https://api.github.com/repos/citruspi/Spotify-Notifications/commits{/sha}","git_commits_url":"https://api.github.com/repos/citruspi/Spotify-Notifications/git/commits{/sha}","comments_url":"https://api.github.com/repos/citruspi/Spotify-Notifications/comments{/number}","issue_comment_url":"https://api.github.com/repos/citruspi/Spotify-Notifications/issues/comments{/number}","contents_url":"https://api.github.com/repos/citruspi/Spotify-Notifications/contents/{+path}","compare_url":"https://api.github.com/repos/citruspi/Spotify-Notifications/compare/{base}...{head}","merges_url":"https://api.github.com/repos/citruspi/Spotify-Notifications/merges","archive_url":"https://api.github.com/repos/citruspi/Spotify-Notifications/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/citruspi/Spotify-Notifications/downloads","issues_url":"https://api.github.com/repos/citruspi/Spotify-Notifications/issues{/number}","pulls_url":"https://api.github.com/repos/citruspi/Spotify-Notifications/pulls{/number}","milestones_url":"https://api.github.com/repos/citruspi/Spotify-Notifications/milestones{/number}","notifications_url":"https://api.github.com/repos/citruspi/Spotify-Notifications/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/citruspi/Spotify-Notifications/labels{/name}","releases_url":"https://api.github.com/repos/citruspi/Spotify-Notifications/releases{/id}","deployments_url":"https://api.github.com/repos/citruspi/Spotify-Notifications/deployments","created_at":"2013-04-07T02:44:06Z","updated_at":"2016-09-24T16:37:19Z","pushed_at":"2016-09-30T10:53:50Z","git_url":"git://github.com/citruspi/Spotify-Notifications.git","ssh_url":"git@github.com:citruspi/Spotify-Notifications.git","clone_url":"https://github.com/citruspi/Spotify-Notifications.git","svn_url":"https://github.com/citruspi/Spotify-Notifications","homepage":"spotify-notifications.citruspi.io","size":2152,"stargazers_count":363,"watchers_count":363,"language":"Swift","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":38,"mirror_url":null,"open_issues_count":25,"forks":38,"open_issues":25,"watchers":363,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/citruspi/Spotify-Notifications/pulls/56"},"html":{"href":"https://github.com/citruspi/Spotify-Notifications/pull/56"},"issue":{"href":"https://api.github.com/repos/citruspi/Spotify-Notifications/issues/56"},"comments":{"href":"https://api.github.com/repos/citruspi/Spotify-Notifications/issues/56/comments"},"review_comments":{"href":"https://api.github.com/repos/citruspi/Spotify-Notifications/pulls/56/comments"},"review_comment":{"href":"https://api.github.com/repos/citruspi/Spotify-Notifications/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/citruspi/Spotify-Notifications/pulls/56/commits"},"statuses":{"href":"https://api.github.com/repos/citruspi/Spotify-Notifications/statuses/b40274d8e35ded899b6817c197a25b3870e07a1a"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"sebj","id":379991,"avatar_url":"https://avatars.githubusercontent.com/u/379991?v=3","gravatar_id":"","url":"https://api.github.com/users/sebj","html_url":"https://github.com/sebj","followers_url":"https://api.github.com/users/sebj/followers","following_url":"https://api.github.com/users/sebj/following{/other_user}","gists_url":"https://api.github.com/users/sebj/gists{/gist_id}","starred_url":"https://api.github.com/users/sebj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebj/subscriptions","organizations_url":"https://api.github.com/users/sebj/orgs","repos_url":"https://api.github.com/users/sebj/repos","events_url":"https://api.github.com/users/sebj/events{/privacy}","received_events_url":"https://api.github.com/users/sebj/received_events","type":"User","site_admin":false},"comments":9,"review_comments":0,"commits":18,"additions":868,"deletions":2169,"changed_files":50}}
{"actor":{"display_login":"sebj"}}