{"action":"created","issue":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/11006","repository_url":"https://api.github.com/repos/ManageIQ/manageiq","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/11006/labels{/name}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/11006/comments","events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/11006/events","html_url":"https://github.com/ManageIQ/manageiq/pull/11006","id":175057301,"number":11006,"title":"Fixed length checking issue","user":{"login":"romanblanco","id":1187051,"avatar_url":"https://avatars.githubusercontent.com/u/1187051?v=3","gravatar_id":"","url":"https://api.github.com/users/romanblanco","html_url":"https://github.com/romanblanco","followers_url":"https://api.github.com/users/romanblanco/followers","following_url":"https://api.github.com/users/romanblanco/following{/other_user}","gists_url":"https://api.github.com/users/romanblanco/gists{/gist_id}","starred_url":"https://api.github.com/users/romanblanco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romanblanco/subscriptions","organizations_url":"https://api.github.com/users/romanblanco/orgs","repos_url":"https://api.github.com/users/romanblanco/repos","events_url":"https://api.github.com/users/romanblanco/events{/privacy}","received_events_url":"https://api.github.com/users/romanblanco/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/bug","name":"bug","color":"fc2929"},{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/provisioning","name":"provisioning","color":"5319e7"},{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/ui","name":"ui","color":"5319e7"}],"state":"open","locked":false,"assignee":{"login":"dclarizio","id":3433754,"avatar_url":"https://avatars.githubusercontent.com/u/3433754?v=3","gravatar_id":"","url":"https://api.github.com/users/dclarizio","html_url":"https://github.com/dclarizio","followers_url":"https://api.github.com/users/dclarizio/followers","following_url":"https://api.github.com/users/dclarizio/following{/other_user}","gists_url":"https://api.github.com/users/dclarizio/gists{/gist_id}","starred_url":"https://api.github.com/users/dclarizio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dclarizio/subscriptions","organizations_url":"https://api.github.com/users/dclarizio/orgs","repos_url":"https://api.github.com/users/dclarizio/repos","events_url":"https://api.github.com/users/dclarizio/events{/privacy}","received_events_url":"https://api.github.com/users/dclarizio/received_events","type":"User","site_admin":false},"assignees":[{"login":"dclarizio","id":3433754,"avatar_url":"https://avatars.githubusercontent.com/u/3433754?v=3","gravatar_id":"","url":"https://api.github.com/users/dclarizio","html_url":"https://github.com/dclarizio","followers_url":"https://api.github.com/users/dclarizio/followers","following_url":"https://api.github.com/users/dclarizio/following{/other_user}","gists_url":"https://api.github.com/users/dclarizio/gists{/gist_id}","starred_url":"https://api.github.com/users/dclarizio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dclarizio/subscriptions","organizations_url":"https://api.github.com/users/dclarizio/orgs","repos_url":"https://api.github.com/users/dclarizio/repos","events_url":"https://api.github.com/users/dclarizio/events{/privacy}","received_events_url":"https://api.github.com/users/dclarizio/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2016-09-05T12:03:59Z","updated_at":"2016-09-05T15:06:52Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/11006","html_url":"https://github.com/ManageIQ/manageiq/pull/11006","diff_url":"https://github.com/ManageIQ/manageiq/pull/11006.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/11006.patch"},"body":"I've ran into issue while provisioning VM. When I started typing to the textarea, the issue notification appeared.\r\n\r\n![screencapture-localhost-3000-vm_infra-explorer-1473074876643](https://cloud.githubusercontent.com/assets/1187051/18247066/5f356210-7370-11e6-95c7-35fc21007d82.png)\r\n\r\nAfter fixing issue from JS side, I've noticed, that text length is checked, but there is no max length set, so in the PR I'm fixing two kinds of problem:\r\n\r\n- content of `$('#' + counter)[0]` that was `undefined`, and was causing JS error\r\n- making sure that `:maxlength` is always set.\r\n\r\nI'm not sure, what is the proper maxlength for textareas in *Provision VM* page though. `MAX_NAME_LEN` constant allows `255` characters.\r\n\r\n@h-kataria @dclarizio do you have any idea, if this solution is correct? \r\n\r\nSteps for Testing/QA\r\n--------------------\r\nTry to fill *Notes* while provisioning VMs. There should be no error in JS console\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments/244767636","html_url":"https://github.com/ManageIQ/manageiq/pull/11006#issuecomment-244767636","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/11006","id":244767636,"user":{"login":"miq-bot","id":7806257,"avatar_url":"https://avatars.githubusercontent.com/u/7806257?v=3","gravatar_id":"","url":"https://api.github.com/users/miq-bot","html_url":"https://github.com/miq-bot","followers_url":"https://api.github.com/users/miq-bot/followers","following_url":"https://api.github.com/users/miq-bot/following{/other_user}","gists_url":"https://api.github.com/users/miq-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/miq-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miq-bot/subscriptions","organizations_url":"https://api.github.com/users/miq-bot/orgs","repos_url":"https://api.github.com/users/miq-bot/repos","events_url":"https://api.github.com/users/miq-bot/events{/privacy}","received_events_url":"https://api.github.com/users/miq-bot/received_events","type":"User","site_admin":false},"created_at":"2016-09-05T15:06:52Z","updated_at":"2016-09-05T15:06:52Z","body":"<rubocop />Checked commit https://github.com/romanblanco/manageiq/commit/881ec9b00676e14081eb96e4a8b637a1b7662770 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1\n1 file checked, 0 offenses detected\nEverything looks good. :+1:\n"}}
{"actor":{"display_login":"miq-bot"}}