{"action":"created","comment":{"url":"https://api.github.com/repos/Homebrew/homebrew/pulls/comments/51241345","id":51241345,"diff_hunk":"@@ -1111,6 +1112,19 @@ def check_tmpdir\n         \"TMPDIR #{tmpdir.inspect} doesn't exist.\" unless tmpdir.nil? || File.directory?(tmpdir)\n       end\n \n+      def check_tmpdir_executable\n+        Tempfile.open(\"homebrew_check_tmpdir_executable\", HOMEBREW_TEMP) do |f|\n+          f.write \"#!/bin/sh\\necho hi\\n\"\n+          f.chmod 0700\n+          unless system f.path then <<-EOS.undent\n+          The directory #{HOMEBREW_TEMP} does not permit executing programs.\n+          It is likely mounted \\\"noexec\\\". Please add the following to your ~/.bashrc:\n+            export HOMEBREW_TEMP=~/tmp\n+          EOS\n+          end","path":"Library/Homebrew/diagnostic.rb","position":21,"original_position":21,"commit_id":"754e9d217d76dbda961ee9b665b20cc6fd5e00bf","original_commit_id":"754e9d217d76dbda961ee9b665b20cc6fd5e00bf","user":{"login":"UniqMartin","id":11892150,"avatar_url":"https://avatars.githubusercontent.com/u/11892150?v=3","gravatar_id":"","url":"https://api.github.com/users/UniqMartin","html_url":"https://github.com/UniqMartin","followers_url":"https://api.github.com/users/UniqMartin/followers","following_url":"https://api.github.com/users/UniqMartin/following{/other_user}","gists_url":"https://api.github.com/users/UniqMartin/gists{/gist_id}","starred_url":"https://api.github.com/users/UniqMartin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UniqMartin/subscriptions","organizations_url":"https://api.github.com/users/UniqMartin/orgs","repos_url":"https://api.github.com/users/UniqMartin/repos","events_url":"https://api.github.com/users/UniqMartin/events{/privacy}","received_events_url":"https://api.github.com/users/UniqMartin/received_events","type":"User","site_admin":false},"body":"This is purely stylistic, but it would be nice to reformat this as:\r\n\r\n```ruby\r\nunless system(f.path)\r\n  <<-EOS.undent\r\n    The directory #{HOMEBREW_TEMP} does not permit executing programs.\r\n    It is likely mounted \"noexec\". Please add the following to your ~/.bashrc:\r\n      export HOMEBREW_TEMP=~/tmp\r\n  EOS\r\nend\r\n```","created_at":"2016-01-29T09:39:08Z","updated_at":"2016-01-29T09:39:08Z","html_url":"https://github.com/Homebrew/homebrew/pull/48562#discussion_r51241345","pull_request_url":"https://api.github.com/repos/Homebrew/homebrew/pulls/48562","_links":{"self":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/comments/51241345"},"html":{"href":"https://github.com/Homebrew/homebrew/pull/48562#discussion_r51241345"},"pull_request":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/48562"}}},"pull_request":{"url":"https://api.github.com/repos/Homebrew/homebrew/pulls/48562","id":57557446,"html_url":"https://github.com/Homebrew/homebrew/pull/48562","diff_url":"https://github.com/Homebrew/homebrew/pull/48562.diff","patch_url":"https://github.com/Homebrew/homebrew/pull/48562.patch","issue_url":"https://api.github.com/repos/Homebrew/homebrew/issues/48562","number":48562,"state":"open","locked":false,"title":"doctor: Add check_tmpdir_executable","user":{"login":"sjackman","id":291551,"avatar_url":"https://avatars.githubusercontent.com/u/291551?v=3","gravatar_id":"","url":"https://api.github.com/users/sjackman","html_url":"https://github.com/sjackman","followers_url":"https://api.github.com/users/sjackman/followers","following_url":"https://api.github.com/users/sjackman/following{/other_user}","gists_url":"https://api.github.com/users/sjackman/gists{/gist_id}","starred_url":"https://api.github.com/users/sjackman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjackman/subscriptions","organizations_url":"https://api.github.com/users/sjackman/orgs","repos_url":"https://api.github.com/users/sjackman/repos","events_url":"https://api.github.com/users/sjackman/events{/privacy}","received_events_url":"https://api.github.com/users/sjackman/received_events","type":"User","site_admin":false},"body":"Check that programs in HOMEBREW_TEMP may be executed.\r\nVolumes mounted \"noexec\" do not permit executing programs.\r\n\r\nSee Linuxbrew/linuxbrew#759\r\n\r\nThe issue of a temp directory that does not permit execution has come up in Linuxbrew a couple of times. I believe Mac OS also supports non-executable volumes.\r\nSee `noexec` in https://developer.apple.com/library/mac/documentation/Darwin/Reference/ManPages/man8/mount.8.html","created_at":"2016-01-28T20:04:19Z","updated_at":"2016-01-29T09:39:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e9a59bd25db11114617c43086cca8a9c21be3e99","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Homebrew/homebrew/pulls/48562/commits","review_comments_url":"https://api.github.com/repos/Homebrew/homebrew/pulls/48562/comments","review_comment_url":"https://api.github.com/repos/Homebrew/homebrew/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Homebrew/homebrew/issues/48562/comments","statuses_url":"https://api.github.com/repos/Homebrew/homebrew/statuses/754e9d217d76dbda961ee9b665b20cc6fd5e00bf","head":{"label":"sjackman:check_tmpdir_executable","ref":"check_tmpdir_executable","sha":"754e9d217d76dbda961ee9b665b20cc6fd5e00bf","user":{"login":"sjackman","id":291551,"avatar_url":"https://avatars.githubusercontent.com/u/291551?v=3","gravatar_id":"","url":"https://api.github.com/users/sjackman","html_url":"https://github.com/sjackman","followers_url":"https://api.github.com/users/sjackman/followers","following_url":"https://api.github.com/users/sjackman/following{/other_user}","gists_url":"https://api.github.com/users/sjackman/gists{/gist_id}","starred_url":"https://api.github.com/users/sjackman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjackman/subscriptions","organizations_url":"https://api.github.com/users/sjackman/orgs","repos_url":"https://api.github.com/users/sjackman/repos","events_url":"https://api.github.com/users/sjackman/events{/privacy}","received_events_url":"https://api.github.com/users/sjackman/received_events","type":"User","site_admin":false},"repo":{"id":3446251,"name":"homebrew","full_name":"sjackman/homebrew","owner":{"login":"sjackman","id":291551,"avatar_url":"https://avatars.githubusercontent.com/u/291551?v=3","gravatar_id":"","url":"https://api.github.com/users/sjackman","html_url":"https://github.com/sjackman","followers_url":"https://api.github.com/users/sjackman/followers","following_url":"https://api.github.com/users/sjackman/following{/other_user}","gists_url":"https://api.github.com/users/sjackman/gists{/gist_id}","starred_url":"https://api.github.com/users/sjackman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjackman/subscriptions","organizations_url":"https://api.github.com/users/sjackman/orgs","repos_url":"https://api.github.com/users/sjackman/repos","events_url":"https://api.github.com/users/sjackman/events{/privacy}","received_events_url":"https://api.github.com/users/sjackman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sjackman/homebrew","description":"The missing package manager for OS X.","fork":true,"url":"https://api.github.com/repos/sjackman/homebrew","forks_url":"https://api.github.com/repos/sjackman/homebrew/forks","keys_url":"https://api.github.com/repos/sjackman/homebrew/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sjackman/homebrew/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sjackman/homebrew/teams","hooks_url":"https://api.github.com/repos/sjackman/homebrew/hooks","issue_events_url":"https://api.github.com/repos/sjackman/homebrew/issues/events{/number}","events_url":"https://api.github.com/repos/sjackman/homebrew/events","assignees_url":"https://api.github.com/repos/sjackman/homebrew/assignees{/user}","branches_url":"https://api.github.com/repos/sjackman/homebrew/branches{/branch}","tags_url":"https://api.github.com/repos/sjackman/homebrew/tags","blobs_url":"https://api.github.com/repos/sjackman/homebrew/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sjackman/homebrew/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sjackman/homebrew/git/refs{/sha}","trees_url":"https://api.github.com/repos/sjackman/homebrew/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sjackman/homebrew/statuses/{sha}","languages_url":"https://api.github.com/repos/sjackman/homebrew/languages","stargazers_url":"https://api.github.com/repos/sjackman/homebrew/stargazers","contributors_url":"https://api.github.com/repos/sjackman/homebrew/contributors","subscribers_url":"https://api.github.com/repos/sjackman/homebrew/subscribers","subscription_url":"https://api.github.com/repos/sjackman/homebrew/subscription","commits_url":"https://api.github.com/repos/sjackman/homebrew/commits{/sha}","git_commits_url":"https://api.github.com/repos/sjackman/homebrew/git/commits{/sha}","comments_url":"https://api.github.com/repos/sjackman/homebrew/comments{/number}","issue_comment_url":"https://api.github.com/repos/sjackman/homebrew/issues/comments{/number}","contents_url":"https://api.github.com/repos/sjackman/homebrew/contents/{+path}","compare_url":"https://api.github.com/repos/sjackman/homebrew/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sjackman/homebrew/merges","archive_url":"https://api.github.com/repos/sjackman/homebrew/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sjackman/homebrew/downloads","issues_url":"https://api.github.com/repos/sjackman/homebrew/issues{/number}","pulls_url":"https://api.github.com/repos/sjackman/homebrew/pulls{/number}","milestones_url":"https://api.github.com/repos/sjackman/homebrew/milestones{/number}","notifications_url":"https://api.github.com/repos/sjackman/homebrew/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sjackman/homebrew/labels{/name}","releases_url":"https://api.github.com/repos/sjackman/homebrew/releases{/id}","deployments_url":"https://api.github.com/repos/sjackman/homebrew/deployments","created_at":"2012-02-15T03:14:08Z","updated_at":"2015-04-01T19:28:52Z","pushed_at":"2016-01-29T06:31:05Z","git_url":"git://github.com/sjackman/homebrew.git","ssh_url":"git@github.com:sjackman/homebrew.git","clone_url":"https://github.com/sjackman/homebrew.git","svn_url":"https://github.com/sjackman/homebrew","homepage":"http://mxcl.github.com/homebrew","size":75848,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"Homebrew:master","ref":"master","sha":"67b879e327440d21c662e0ffa7f58b64908198cb","user":{"login":"Homebrew","id":1503512,"avatar_url":"https://avatars.githubusercontent.com/u/1503512?v=3","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"repo":{"id":206084,"name":"homebrew","full_name":"Homebrew/homebrew","owner":{"login":"Homebrew","id":1503512,"avatar_url":"https://avatars.githubusercontent.com/u/1503512?v=3","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Homebrew/homebrew","description":":beer: The missing package manager for OS X.","fork":false,"url":"https://api.github.com/repos/Homebrew/homebrew","forks_url":"https://api.github.com/repos/Homebrew/homebrew/forks","keys_url":"https://api.github.com/repos/Homebrew/homebrew/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Homebrew/homebrew/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Homebrew/homebrew/teams","hooks_url":"https://api.github.com/repos/Homebrew/homebrew/hooks","issue_events_url":"https://api.github.com/repos/Homebrew/homebrew/issues/events{/number}","events_url":"https://api.github.com/repos/Homebrew/homebrew/events","assignees_url":"https://api.github.com/repos/Homebrew/homebrew/assignees{/user}","branches_url":"https://api.github.com/repos/Homebrew/homebrew/branches{/branch}","tags_url":"https://api.github.com/repos/Homebrew/homebrew/tags","blobs_url":"https://api.github.com/repos/Homebrew/homebrew/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Homebrew/homebrew/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Homebrew/homebrew/git/refs{/sha}","trees_url":"https://api.github.com/repos/Homebrew/homebrew/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Homebrew/homebrew/statuses/{sha}","languages_url":"https://api.github.com/repos/Homebrew/homebrew/languages","stargazers_url":"https://api.github.com/repos/Homebrew/homebrew/stargazers","contributors_url":"https://api.github.com/repos/Homebrew/homebrew/contributors","subscribers_url":"https://api.github.com/repos/Homebrew/homebrew/subscribers","subscription_url":"https://api.github.com/repos/Homebrew/homebrew/subscription","commits_url":"https://api.github.com/repos/Homebrew/homebrew/commits{/sha}","git_commits_url":"https://api.github.com/repos/Homebrew/homebrew/git/commits{/sha}","comments_url":"https://api.github.com/repos/Homebrew/homebrew/comments{/number}","issue_comment_url":"https://api.github.com/repos/Homebrew/homebrew/issues/comments{/number}","contents_url":"https://api.github.com/repos/Homebrew/homebrew/contents/{+path}","compare_url":"https://api.github.com/repos/Homebrew/homebrew/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Homebrew/homebrew/merges","archive_url":"https://api.github.com/repos/Homebrew/homebrew/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Homebrew/homebrew/downloads","issues_url":"https://api.github.com/repos/Homebrew/homebrew/issues{/number}","pulls_url":"https://api.github.com/repos/Homebrew/homebrew/pulls{/number}","milestones_url":"https://api.github.com/repos/Homebrew/homebrew/milestones{/number}","notifications_url":"https://api.github.com/repos/Homebrew/homebrew/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Homebrew/homebrew/labels{/name}","releases_url":"https://api.github.com/repos/Homebrew/homebrew/releases{/id}","deployments_url":"https://api.github.com/repos/Homebrew/homebrew/deployments","created_at":"2009-05-20T19:38:37Z","updated_at":"2016-01-29T09:26:14Z","pushed_at":"2016-01-29T08:39:52Z","git_url":"git://github.com/Homebrew/homebrew.git","ssh_url":"git@github.com:Homebrew/homebrew.git","clone_url":"https://github.com/Homebrew/homebrew.git","svn_url":"https://github.com/Homebrew/homebrew","homepage":"http://brew.sh","size":1417047,"stargazers_count":28766,"watchers_count":28766,"language":"Ruby","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":14196,"mirror_url":null,"open_issues_count":461,"forks":14196,"open_issues":461,"watchers":28766,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/48562"},"html":{"href":"https://github.com/Homebrew/homebrew/pull/48562"},"issue":{"href":"https://api.github.com/repos/Homebrew/homebrew/issues/48562"},"comments":{"href":"https://api.github.com/repos/Homebrew/homebrew/issues/48562/comments"},"review_comments":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/48562/comments"},"review_comment":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/48562/commits"},"statuses":{"href":"https://api.github.com/repos/Homebrew/homebrew/statuses/754e9d217d76dbda961ee9b665b20cc6fd5e00bf"}}}}