{"action":"created","comment":{"url":"https://api.github.com/repos/HBPVIS/ZeroBuf/pulls/comments/84246600","pull_request_review_id":5034854,"id":84246600,"diff_hunk":"@@ -166,24 +185,24 @@ def write_declaration(self, file):\n         else:\n             file.write(NEXTLINE + self.declaration())\n \n-    def write_implementation(self, file, classname, extra_op = \"\"):\n+    def write_implementation(self, file, classname=None, extra_op = \"\"):\n         if not self.split_implementation:\n             return\n \n         impl_function = re.sub(r\" final$\", \"\", self.function) # remove ' final' keyword\n         impl_function = re.sub(r\" = [0-9\\.f]+ \", \" \", impl_function) # remove default params\n \n         if self.ret_val: # '{}'-less body\n-            file.write(\"\\n\" + self.ret_val + \" \" + classname +\n-                       \"::\" + impl_function +\n-                       \"\\n{\" +\n-                       NEXTLINE + self.body)\n+            file.write('\\n{0} {1}{2}\\n{{{3}{4}'.format(self.ret_val,","path":"bin/zerobufCxx.py","position":50,"original_position":50,"commit_id":"47597b3e10fece825d41a1f9e8c53885e5240621","original_commit_id":"47597b3e10fece825d41a1f9e8c53885e5240621","user":{"login":"tribal-tec","id":701401,"avatar_url":"https://avatars.githubusercontent.com/u/701401?v=3","gravatar_id":"","url":"https://api.github.com/users/tribal-tec","html_url":"https://github.com/tribal-tec","followers_url":"https://api.github.com/users/tribal-tec/followers","following_url":"https://api.github.com/users/tribal-tec/following{/other_user}","gists_url":"https://api.github.com/users/tribal-tec/gists{/gist_id}","starred_url":"https://api.github.com/users/tribal-tec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tribal-tec/subscriptions","organizations_url":"https://api.github.com/users/tribal-tec/orgs","repos_url":"https://api.github.com/users/tribal-tec/repos","events_url":"https://api.github.com/users/tribal-tec/events{/privacy}","received_events_url":"https://api.github.com/users/tribal-tec/received_events","type":"User","site_admin":false},"body":"Yes, because .format() replaces all {<number>} placeholders","created_at":"2016-10-20T09:42:37Z","updated_at":"2016-10-20T09:42:37Z","html_url":"https://github.com/HBPVIS/ZeroBuf/pull/65#discussion_r84246600","pull_request_url":"https://api.github.com/repos/HBPVIS/ZeroBuf/pulls/65","_links":{"self":{"href":"https://api.github.com/repos/HBPVIS/ZeroBuf/pulls/comments/84246600"},"html":{"href":"https://github.com/HBPVIS/ZeroBuf/pull/65#discussion_r84246600"},"pull_request":{"href":"https://api.github.com/repos/HBPVIS/ZeroBuf/pulls/65"}}},"pull_request":{"url":"https://api.github.com/repos/HBPVIS/ZeroBuf/pulls/65","id":90158504,"html_url":"https://github.com/HBPVIS/ZeroBuf/pull/65","diff_url":"https://github.com/HBPVIS/ZeroBuf/pull/65.diff","patch_url":"https://github.com/HBPVIS/ZeroBuf/pull/65.patch","issue_url":"https://api.github.com/repos/HBPVIS/ZeroBuf/issues/65","number":65,"state":"open","locked":false,"title":"Implement servus::Serializable::getSchema()","user":{"login":"tribal-tec","id":701401,"avatar_url":"https://avatars.githubusercontent.com/u/701401?v=3","gravatar_id":"","url":"https://api.github.com/users/tribal-tec","html_url":"https://github.com/tribal-tec","followers_url":"https://api.github.com/users/tribal-tec/followers","following_url":"https://api.github.com/users/tribal-tec/following{/other_user}","gists_url":"https://api.github.com/users/tribal-tec/gists{/gist_id}","starred_url":"https://api.github.com/users/tribal-tec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tribal-tec/subscriptions","organizations_url":"https://api.github.com/users/tribal-tec/orgs","repos_url":"https://api.github.com/users/tribal-tec/repos","events_url":"https://api.github.com/users/tribal-tec/events{/privacy}","received_events_url":"https://api.github.com/users/tribal-tec/received_events","type":"User","site_admin":false},"body":"* emit JSON schema from FBS in zerobufCxx.py\n* create enum class for enums instead of 'old' enums; breaks existing enum names\n* fix wrong JSON value for empty arrays (was 'null', is '[]' now)","created_at":"2016-10-20T08:58:10Z","updated_at":"2016-10-20T09:42:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c268b907ac81cbdd49c786ae0c66aeec73f8a06e","assignee":{"login":"eile","id":354947,"avatar_url":"https://avatars.githubusercontent.com/u/354947?v=3","gravatar_id":"","url":"https://api.github.com/users/eile","html_url":"https://github.com/eile","followers_url":"https://api.github.com/users/eile/followers","following_url":"https://api.github.com/users/eile/following{/other_user}","gists_url":"https://api.github.com/users/eile/gists{/gist_id}","starred_url":"https://api.github.com/users/eile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eile/subscriptions","organizations_url":"https://api.github.com/users/eile/orgs","repos_url":"https://api.github.com/users/eile/repos","events_url":"https://api.github.com/users/eile/events{/privacy}","received_events_url":"https://api.github.com/users/eile/received_events","type":"User","site_admin":false},"assignees":[{"login":"eile","id":354947,"avatar_url":"https://avatars.githubusercontent.com/u/354947?v=3","gravatar_id":"","url":"https://api.github.com/users/eile","html_url":"https://github.com/eile","followers_url":"https://api.github.com/users/eile/followers","following_url":"https://api.github.com/users/eile/following{/other_user}","gists_url":"https://api.github.com/users/eile/gists{/gist_id}","starred_url":"https://api.github.com/users/eile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eile/subscriptions","organizations_url":"https://api.github.com/users/eile/orgs","repos_url":"https://api.github.com/users/eile/repos","events_url":"https://api.github.com/users/eile/events{/privacy}","received_events_url":"https://api.github.com/users/eile/received_events","type":"User","site_admin":false},{"login":"hernando","id":791427,"avatar_url":"https://avatars.githubusercontent.com/u/791427?v=3","gravatar_id":"","url":"https://api.github.com/users/hernando","html_url":"https://github.com/hernando","followers_url":"https://api.github.com/users/hernando/followers","following_url":"https://api.github.com/users/hernando/following{/other_user}","gists_url":"https://api.github.com/users/hernando/gists{/gist_id}","starred_url":"https://api.github.com/users/hernando/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hernando/subscriptions","organizations_url":"https://api.github.com/users/hernando/orgs","repos_url":"https://api.github.com/users/hernando/repos","events_url":"https://api.github.com/users/hernando/events{/privacy}","received_events_url":"https://api.github.com/users/hernando/received_events","type":"User","site_admin":false},{"login":"rdumusc","id":5166658,"avatar_url":"https://avatars.githubusercontent.com/u/5166658?v=3","gravatar_id":"","url":"https://api.github.com/users/rdumusc","html_url":"https://github.com/rdumusc","followers_url":"https://api.github.com/users/rdumusc/followers","following_url":"https://api.github.com/users/rdumusc/following{/other_user}","gists_url":"https://api.github.com/users/rdumusc/gists{/gist_id}","starred_url":"https://api.github.com/users/rdumusc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdumusc/subscriptions","organizations_url":"https://api.github.com/users/rdumusc/orgs","repos_url":"https://api.github.com/users/rdumusc/repos","events_url":"https://api.github.com/users/rdumusc/events{/privacy}","received_events_url":"https://api.github.com/users/rdumusc/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/HBPVIS/ZeroBuf/pulls/65/commits","review_comments_url":"https://api.github.com/repos/HBPVIS/ZeroBuf/pulls/65/comments","review_comment_url":"https://api.github.com/repos/HBPVIS/ZeroBuf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/HBPVIS/ZeroBuf/issues/65/comments","statuses_url":"https://api.github.com/repos/HBPVIS/ZeroBuf/statuses/47597b3e10fece825d41a1f9e8c53885e5240621","head":{"label":"tribal-tec:master","ref":"master","sha":"47597b3e10fece825d41a1f9e8c53885e5240621","user":{"login":"tribal-tec","id":701401,"avatar_url":"https://avatars.githubusercontent.com/u/701401?v=3","gravatar_id":"","url":"https://api.github.com/users/tribal-tec","html_url":"https://github.com/tribal-tec","followers_url":"https://api.github.com/users/tribal-tec/followers","following_url":"https://api.github.com/users/tribal-tec/following{/other_user}","gists_url":"https://api.github.com/users/tribal-tec/gists{/gist_id}","starred_url":"https://api.github.com/users/tribal-tec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tribal-tec/subscriptions","organizations_url":"https://api.github.com/users/tribal-tec/orgs","repos_url":"https://api.github.com/users/tribal-tec/repos","events_url":"https://api.github.com/users/tribal-tec/events{/privacy}","received_events_url":"https://api.github.com/users/tribal-tec/received_events","type":"User","site_admin":false},"repo":{"id":39784582,"name":"ZeroBuf","full_name":"tribal-tec/ZeroBuf","owner":{"login":"tribal-tec","id":701401,"avatar_url":"https://avatars.githubusercontent.com/u/701401?v=3","gravatar_id":"","url":"https://api.github.com/users/tribal-tec","html_url":"https://github.com/tribal-tec","followers_url":"https://api.github.com/users/tribal-tec/followers","following_url":"https://api.github.com/users/tribal-tec/following{/other_user}","gists_url":"https://api.github.com/users/tribal-tec/gists{/gist_id}","starred_url":"https://api.github.com/users/tribal-tec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tribal-tec/subscriptions","organizations_url":"https://api.github.com/users/tribal-tec/orgs","repos_url":"https://api.github.com/users/tribal-tec/repos","events_url":"https://api.github.com/users/tribal-tec/events{/privacy}","received_events_url":"https://api.github.com/users/tribal-tec/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tribal-tec/ZeroBuf","description":"Zerocopy protocol buffers","fork":true,"url":"https://api.github.com/repos/tribal-tec/ZeroBuf","forks_url":"https://api.github.com/repos/tribal-tec/ZeroBuf/forks","keys_url":"https://api.github.com/repos/tribal-tec/ZeroBuf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tribal-tec/ZeroBuf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tribal-tec/ZeroBuf/teams","hooks_url":"https://api.github.com/repos/tribal-tec/ZeroBuf/hooks","issue_events_url":"https://api.github.com/repos/tribal-tec/ZeroBuf/issues/events{/number}","events_url":"https://api.github.com/repos/tribal-tec/ZeroBuf/events","assignees_url":"https://api.github.com/repos/tribal-tec/ZeroBuf/assignees{/user}","branches_url":"https://api.github.com/repos/tribal-tec/ZeroBuf/branches{/branch}","tags_url":"https://api.github.com/repos/tribal-tec/ZeroBuf/tags","blobs_url":"https://api.github.com/repos/tribal-tec/ZeroBuf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tribal-tec/ZeroBuf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tribal-tec/ZeroBuf/git/refs{/sha}","trees_url":"https://api.github.com/repos/tribal-tec/ZeroBuf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tribal-tec/ZeroBuf/statuses/{sha}","languages_url":"https://api.github.com/repos/tribal-tec/ZeroBuf/languages","stargazers_url":"https://api.github.com/repos/tribal-tec/ZeroBuf/stargazers","contributors_url":"https://api.github.com/repos/tribal-tec/ZeroBuf/contributors","subscribers_url":"https://api.github.com/repos/tribal-tec/ZeroBuf/subscribers","subscription_url":"https://api.github.com/repos/tribal-tec/ZeroBuf/subscription","commits_url":"https://api.github.com/repos/tribal-tec/ZeroBuf/commits{/sha}","git_commits_url":"https://api.github.com/repos/tribal-tec/ZeroBuf/git/commits{/sha}","comments_url":"https://api.github.com/repos/tribal-tec/ZeroBuf/comments{/number}","issue_comment_url":"https://api.github.com/repos/tribal-tec/ZeroBuf/issues/comments{/number}","contents_url":"https://api.github.com/repos/tribal-tec/ZeroBuf/contents/{+path}","compare_url":"https://api.github.com/repos/tribal-tec/ZeroBuf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tribal-tec/ZeroBuf/merges","archive_url":"https://api.github.com/repos/tribal-tec/ZeroBuf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tribal-tec/ZeroBuf/downloads","issues_url":"https://api.github.com/repos/tribal-tec/ZeroBuf/issues{/number}","pulls_url":"https://api.github.com/repos/tribal-tec/ZeroBuf/pulls{/number}","milestones_url":"https://api.github.com/repos/tribal-tec/ZeroBuf/milestones{/number}","notifications_url":"https://api.github.com/repos/tribal-tec/ZeroBuf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tribal-tec/ZeroBuf/labels{/name}","releases_url":"https://api.github.com/repos/tribal-tec/ZeroBuf/releases{/id}","deployments_url":"https://api.github.com/repos/tribal-tec/ZeroBuf/deployments","created_at":"2015-07-27T16:13:43Z","updated_at":"2016-01-11T10:00:20Z","pushed_at":"2016-10-20T08:58:07Z","git_url":"git://github.com/tribal-tec/ZeroBuf.git","ssh_url":"git@github.com:tribal-tec/ZeroBuf.git","clone_url":"https://github.com/tribal-tec/ZeroBuf.git","svn_url":"https://github.com/tribal-tec/ZeroBuf","homepage":null,"size":1501,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"HBPVIS:master","ref":"master","sha":"346c1b5a355542ed084600460b96f67f347797e9","user":{"login":"HBPVIS","id":7261238,"avatar_url":"https://avatars.githubusercontent.com/u/7261238?v=3","gravatar_id":"","url":"https://api.github.com/users/HBPVIS","html_url":"https://github.com/HBPVIS","followers_url":"https://api.github.com/users/HBPVIS/followers","following_url":"https://api.github.com/users/HBPVIS/following{/other_user}","gists_url":"https://api.github.com/users/HBPVIS/gists{/gist_id}","starred_url":"https://api.github.com/users/HBPVIS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HBPVIS/subscriptions","organizations_url":"https://api.github.com/users/HBPVIS/orgs","repos_url":"https://api.github.com/users/HBPVIS/repos","events_url":"https://api.github.com/users/HBPVIS/events{/privacy}","received_events_url":"https://api.github.com/users/HBPVIS/received_events","type":"Organization","site_admin":false},"repo":{"id":39505367,"name":"ZeroBuf","full_name":"HBPVIS/ZeroBuf","owner":{"login":"HBPVIS","id":7261238,"avatar_url":"https://avatars.githubusercontent.com/u/7261238?v=3","gravatar_id":"","url":"https://api.github.com/users/HBPVIS","html_url":"https://github.com/HBPVIS","followers_url":"https://api.github.com/users/HBPVIS/followers","following_url":"https://api.github.com/users/HBPVIS/following{/other_user}","gists_url":"https://api.github.com/users/HBPVIS/gists{/gist_id}","starred_url":"https://api.github.com/users/HBPVIS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HBPVIS/subscriptions","organizations_url":"https://api.github.com/users/HBPVIS/orgs","repos_url":"https://api.github.com/users/HBPVIS/repos","events_url":"https://api.github.com/users/HBPVIS/events{/privacy}","received_events_url":"https://api.github.com/users/HBPVIS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HBPVIS/ZeroBuf","description":"zero-copy, zero-serialize, zero-hassle protocol buffers","fork":false,"url":"https://api.github.com/repos/HBPVIS/ZeroBuf","forks_url":"https://api.github.com/repos/HBPVIS/ZeroBuf/forks","keys_url":"https://api.github.com/repos/HBPVIS/ZeroBuf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HBPVIS/ZeroBuf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HBPVIS/ZeroBuf/teams","hooks_url":"https://api.github.com/repos/HBPVIS/ZeroBuf/hooks","issue_events_url":"https://api.github.com/repos/HBPVIS/ZeroBuf/issues/events{/number}","events_url":"https://api.github.com/repos/HBPVIS/ZeroBuf/events","assignees_url":"https://api.github.com/repos/HBPVIS/ZeroBuf/assignees{/user}","branches_url":"https://api.github.com/repos/HBPVIS/ZeroBuf/branches{/branch}","tags_url":"https://api.github.com/repos/HBPVIS/ZeroBuf/tags","blobs_url":"https://api.github.com/repos/HBPVIS/ZeroBuf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HBPVIS/ZeroBuf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HBPVIS/ZeroBuf/git/refs{/sha}","trees_url":"https://api.github.com/repos/HBPVIS/ZeroBuf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HBPVIS/ZeroBuf/statuses/{sha}","languages_url":"https://api.github.com/repos/HBPVIS/ZeroBuf/languages","stargazers_url":"https://api.github.com/repos/HBPVIS/ZeroBuf/stargazers","contributors_url":"https://api.github.com/repos/HBPVIS/ZeroBuf/contributors","subscribers_url":"https://api.github.com/repos/HBPVIS/ZeroBuf/subscribers","subscription_url":"https://api.github.com/repos/HBPVIS/ZeroBuf/subscription","commits_url":"https://api.github.com/repos/HBPVIS/ZeroBuf/commits{/sha}","git_commits_url":"https://api.github.com/repos/HBPVIS/ZeroBuf/git/commits{/sha}","comments_url":"https://api.github.com/repos/HBPVIS/ZeroBuf/comments{/number}","issue_comment_url":"https://api.github.com/repos/HBPVIS/ZeroBuf/issues/comments{/number}","contents_url":"https://api.github.com/repos/HBPVIS/ZeroBuf/contents/{+path}","compare_url":"https://api.github.com/repos/HBPVIS/ZeroBuf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HBPVIS/ZeroBuf/merges","archive_url":"https://api.github.com/repos/HBPVIS/ZeroBuf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HBPVIS/ZeroBuf/downloads","issues_url":"https://api.github.com/repos/HBPVIS/ZeroBuf/issues{/number}","pulls_url":"https://api.github.com/repos/HBPVIS/ZeroBuf/pulls{/number}","milestones_url":"https://api.github.com/repos/HBPVIS/ZeroBuf/milestones{/number}","notifications_url":"https://api.github.com/repos/HBPVIS/ZeroBuf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HBPVIS/ZeroBuf/labels{/name}","releases_url":"https://api.github.com/repos/HBPVIS/ZeroBuf/releases{/id}","deployments_url":"https://api.github.com/repos/HBPVIS/ZeroBuf/deployments","created_at":"2015-07-22T12:41:50Z","updated_at":"2016-10-17T06:33:51Z","pushed_at":"2016-10-20T08:58:10Z","git_url":"git://github.com/HBPVIS/ZeroBuf.git","ssh_url":"git@github.com:HBPVIS/ZeroBuf.git","clone_url":"https://github.com/HBPVIS/ZeroBuf.git","svn_url":"https://github.com/HBPVIS/ZeroBuf","homepage":"http://hbpvis.github.io/","size":1447,"stargazers_count":5,"watchers_count":5,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":2,"forks":13,"open_issues":2,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/HBPVIS/ZeroBuf/pulls/65"},"html":{"href":"https://github.com/HBPVIS/ZeroBuf/pull/65"},"issue":{"href":"https://api.github.com/repos/HBPVIS/ZeroBuf/issues/65"},"comments":{"href":"https://api.github.com/repos/HBPVIS/ZeroBuf/issues/65/comments"},"review_comments":{"href":"https://api.github.com/repos/HBPVIS/ZeroBuf/pulls/65/comments"},"review_comment":{"href":"https://api.github.com/repos/HBPVIS/ZeroBuf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/HBPVIS/ZeroBuf/pulls/65/commits"},"statuses":{"href":"https://api.github.com/repos/HBPVIS/ZeroBuf/statuses/47597b3e10fece825d41a1f9e8c53885e5240621"}}}}
{"actor":{"display_login":"tribal-tec"}}