{"action":"created","comment":{"url":"https://api.github.com/repos/angular/angular.io/pulls/comments/86248256","pull_request_review_id":6915905,"id":86248256,"diff_hunk":"@@ -92,6 +95,79 @@ a#i18n-attribute\n   The Angular extraction tool preserves both the _meaning_ and the _description_ in the translation source file\n   to facilitiate contextually-specific translations.\n \n+  As an alternative, if you want to translate some content without having to create a new element, you can use a `<ng-container>`\n+  which doesn't get renderered in the DOM:\n+\n++makeExample('cb-i18n/ts/app/app.component.html', 'i18n-ng-container', 'app/app.component.html')(format=\".\")\n+\n+:marked\n+  You can also use a comment to get the same result:\n+\n++makeExample('cb-i18n/ts/app/app.component.html', 'i18n-with-comment', 'app/app.component.html')(format=\".\")\n+\n+a#translating-attributes\n+:marked\n+  ## Translating attributes with _i18n-x_\n+  Now you add an image to your html and since you are concerned with a11y, you add an `alt` tag to it:\n+\n++makeExample('cb-i18n/ts/app/app.component.1.html', 'i18n-alt', 'app/app.component.html')(format=\".\")\n+\n+:marked\n+  Such attribute needs to be translated as well, and `Angular` provides you another attribute: `i18n-x` where you replace","path":"public/docs/ts/latest/cookbook/i18n.jade","position":51,"original_position":51,"commit_id":"8410291238552b219115c84c3a34adae3656b292","original_commit_id":"8410291238552b219115c84c3a34adae3656b292","user":{"login":"vicb","id":248818,"avatar_url":"https://avatars.githubusercontent.com/u/248818?v=3","gravatar_id":"","url":"https://api.github.com/users/vicb","html_url":"https://github.com/vicb","followers_url":"https://api.github.com/users/vicb/followers","following_url":"https://api.github.com/users/vicb/following{/other_user}","gists_url":"https://api.github.com/users/vicb/gists{/gist_id}","starred_url":"https://api.github.com/users/vicb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vicb/subscriptions","organizations_url":"https://api.github.com/users/vicb/orgs","repos_url":"https://api.github.com/users/vicb/repos","events_url":"https://api.github.com/users/vicb/events{/privacy}","received_events_url":"https://api.github.com/users/vicb/received_events","type":"User","site_admin":false},"body":"where `x` is the name of ...","created_at":"2016-11-02T21:36:22Z","updated_at":"2016-11-02T21:36:22Z","html_url":"https://github.com/angular/angular.io/pull/2740#discussion_r86248256","pull_request_url":"https://api.github.com/repos/angular/angular.io/pulls/2740","_links":{"self":{"href":"https://api.github.com/repos/angular/angular.io/pulls/comments/86248256"},"html":{"href":"https://github.com/angular/angular.io/pull/2740#discussion_r86248256"},"pull_request":{"href":"https://api.github.com/repos/angular/angular.io/pulls/2740"}}},"pull_request":{"url":"https://api.github.com/repos/angular/angular.io/pulls/2740","id":92059307,"html_url":"https://github.com/angular/angular.io/pull/2740","diff_url":"https://github.com/angular/angular.io/pull/2740.diff","patch_url":"https://github.com/angular/angular.io/pull/2740.patch","issue_url":"https://api.github.com/repos/angular/angular.io/issues/2740","number":2740,"state":"open","locked":false,"title":"docs(i18n): add new features","user":{"login":"Foxandxss","id":1087957,"avatar_url":"https://avatars.githubusercontent.com/u/1087957?v=3","gravatar_id":"","url":"https://api.github.com/users/Foxandxss","html_url":"https://github.com/Foxandxss","followers_url":"https://api.github.com/users/Foxandxss/followers","following_url":"https://api.github.com/users/Foxandxss/following{/other_user}","gists_url":"https://api.github.com/users/Foxandxss/gists{/gist_id}","starred_url":"https://api.github.com/users/Foxandxss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Foxandxss/subscriptions","organizations_url":"https://api.github.com/users/Foxandxss/orgs","repos_url":"https://api.github.com/users/Foxandxss/repos","events_url":"https://api.github.com/users/Foxandxss/events{/privacy}","received_events_url":"https://api.github.com/users/Foxandxss/received_events","type":"User","site_admin":false},"body":"@vicb please review that everything I said about ICU and CLDR are correct.\r\n\r\nI ignored the plural/select with markup until https://github.com/angular/angular/issues/12636 is resolved.\r\n\r\nThere is an alert that starts with \"repeat the extraction process ...\" I don't know where to put it :/\r\n\r\nAnd there are a few links that would be nice to add, somewhere:\r\n\r\nhttp://cldr.unicode.org/index/cldr-spec/plural-rules\r\nhttp://www.unicode.org/cldr/charts/29/supplemental/language_plural_rules.html\r\nhttp://userguide.icu-project.org/formatparse/messages","created_at":"2016-11-02T21:29:30Z","updated_at":"2016-11-02T21:36:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e5843a168cd862363ce8c6c0e54a4d76861b594a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/angular/angular.io/pulls/2740/commits","review_comments_url":"https://api.github.com/repos/angular/angular.io/pulls/2740/comments","review_comment_url":"https://api.github.com/repos/angular/angular.io/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/angular.io/issues/2740/comments","statuses_url":"https://api.github.com/repos/angular/angular.io/statuses/8410291238552b219115c84c3a34adae3656b292","head":{"label":"IdeaBlade:i18n-new-features","ref":"i18n-new-features","sha":"8410291238552b219115c84c3a34adae3656b292","user":{"login":"IdeaBlade","id":1630193,"avatar_url":"https://avatars.githubusercontent.com/u/1630193?v=3","gravatar_id":"","url":"https://api.github.com/users/IdeaBlade","html_url":"https://github.com/IdeaBlade","followers_url":"https://api.github.com/users/IdeaBlade/followers","following_url":"https://api.github.com/users/IdeaBlade/following{/other_user}","gists_url":"https://api.github.com/users/IdeaBlade/gists{/gist_id}","starred_url":"https://api.github.com/users/IdeaBlade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IdeaBlade/subscriptions","organizations_url":"https://api.github.com/users/IdeaBlade/orgs","repos_url":"https://api.github.com/users/IdeaBlade/repos","events_url":"https://api.github.com/users/IdeaBlade/events{/privacy}","received_events_url":"https://api.github.com/users/IdeaBlade/received_events","type":"Organization","site_admin":false},"repo":{"id":40154922,"name":"angular.io","full_name":"IdeaBlade/angular.io","owner":{"login":"IdeaBlade","id":1630193,"avatar_url":"https://avatars.githubusercontent.com/u/1630193?v=3","gravatar_id":"","url":"https://api.github.com/users/IdeaBlade","html_url":"https://github.com/IdeaBlade","followers_url":"https://api.github.com/users/IdeaBlade/followers","following_url":"https://api.github.com/users/IdeaBlade/following{/other_user}","gists_url":"https://api.github.com/users/IdeaBlade/gists{/gist_id}","starred_url":"https://api.github.com/users/IdeaBlade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IdeaBlade/subscriptions","organizations_url":"https://api.github.com/users/IdeaBlade/orgs","repos_url":"https://api.github.com/users/IdeaBlade/repos","events_url":"https://api.github.com/users/IdeaBlade/events{/privacy}","received_events_url":"https://api.github.com/users/IdeaBlade/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/IdeaBlade/angular.io","description":"Website for Angular 2","fork":true,"url":"https://api.github.com/repos/IdeaBlade/angular.io","forks_url":"https://api.github.com/repos/IdeaBlade/angular.io/forks","keys_url":"https://api.github.com/repos/IdeaBlade/angular.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/IdeaBlade/angular.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/IdeaBlade/angular.io/teams","hooks_url":"https://api.github.com/repos/IdeaBlade/angular.io/hooks","issue_events_url":"https://api.github.com/repos/IdeaBlade/angular.io/issues/events{/number}","events_url":"https://api.github.com/repos/IdeaBlade/angular.io/events","assignees_url":"https://api.github.com/repos/IdeaBlade/angular.io/assignees{/user}","branches_url":"https://api.github.com/repos/IdeaBlade/angular.io/branches{/branch}","tags_url":"https://api.github.com/repos/IdeaBlade/angular.io/tags","blobs_url":"https://api.github.com/repos/IdeaBlade/angular.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/IdeaBlade/angular.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/IdeaBlade/angular.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/IdeaBlade/angular.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/IdeaBlade/angular.io/statuses/{sha}","languages_url":"https://api.github.com/repos/IdeaBlade/angular.io/languages","stargazers_url":"https://api.github.com/repos/IdeaBlade/angular.io/stargazers","contributors_url":"https://api.github.com/repos/IdeaBlade/angular.io/contributors","subscribers_url":"https://api.github.com/repos/IdeaBlade/angular.io/subscribers","subscription_url":"https://api.github.com/repos/IdeaBlade/angular.io/subscription","commits_url":"https://api.github.com/repos/IdeaBlade/angular.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/IdeaBlade/angular.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/IdeaBlade/angular.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/IdeaBlade/angular.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/IdeaBlade/angular.io/contents/{+path}","compare_url":"https://api.github.com/repos/IdeaBlade/angular.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/IdeaBlade/angular.io/merges","archive_url":"https://api.github.com/repos/IdeaBlade/angular.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/IdeaBlade/angular.io/downloads","issues_url":"https://api.github.com/repos/IdeaBlade/angular.io/issues{/number}","pulls_url":"https://api.github.com/repos/IdeaBlade/angular.io/pulls{/number}","milestones_url":"https://api.github.com/repos/IdeaBlade/angular.io/milestones{/number}","notifications_url":"https://api.github.com/repos/IdeaBlade/angular.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/IdeaBlade/angular.io/labels{/name}","releases_url":"https://api.github.com/repos/IdeaBlade/angular.io/releases{/id}","deployments_url":"https://api.github.com/repos/IdeaBlade/angular.io/deployments","created_at":"2015-08-04T00:40:19Z","updated_at":"2016-10-23T07:56:38Z","pushed_at":"2016-11-02T21:26:05Z","git_url":"git://github.com/IdeaBlade/angular.io.git","ssh_url":"git@github.com:IdeaBlade/angular.io.git","clone_url":"https://github.com/IdeaBlade/angular.io.git","svn_url":"https://github.com/IdeaBlade/angular.io","homepage":"https://angular.io","size":49303,"stargazers_count":6,"watchers_count":6,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":0,"forks":7,"open_issues":0,"watchers":6,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"f837330eaffda0a00e51295895336b88661d6d3e","user":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":31985425,"name":"angular.io","full_name":"angular/angular.io","owner":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/angular.io","description":"Website for Angular 2","fork":false,"url":"https://api.github.com/repos/angular/angular.io","forks_url":"https://api.github.com/repos/angular/angular.io/forks","keys_url":"https://api.github.com/repos/angular/angular.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/angular.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/angular.io/teams","hooks_url":"https://api.github.com/repos/angular/angular.io/hooks","issue_events_url":"https://api.github.com/repos/angular/angular.io/issues/events{/number}","events_url":"https://api.github.com/repos/angular/angular.io/events","assignees_url":"https://api.github.com/repos/angular/angular.io/assignees{/user}","branches_url":"https://api.github.com/repos/angular/angular.io/branches{/branch}","tags_url":"https://api.github.com/repos/angular/angular.io/tags","blobs_url":"https://api.github.com/repos/angular/angular.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/angular.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/angular.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/angular.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/angular.io/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/angular.io/languages","stargazers_url":"https://api.github.com/repos/angular/angular.io/stargazers","contributors_url":"https://api.github.com/repos/angular/angular.io/contributors","subscribers_url":"https://api.github.com/repos/angular/angular.io/subscribers","subscription_url":"https://api.github.com/repos/angular/angular.io/subscription","commits_url":"https://api.github.com/repos/angular/angular.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/angular.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/angular.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/angular.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/angular.io/contents/{+path}","compare_url":"https://api.github.com/repos/angular/angular.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/angular.io/merges","archive_url":"https://api.github.com/repos/angular/angular.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/angular.io/downloads","issues_url":"https://api.github.com/repos/angular/angular.io/issues{/number}","pulls_url":"https://api.github.com/repos/angular/angular.io/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/angular.io/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/angular.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/angular.io/labels{/name}","releases_url":"https://api.github.com/repos/angular/angular.io/releases{/id}","deployments_url":"https://api.github.com/repos/angular/angular.io/deployments","created_at":"2015-03-10T22:32:34Z","updated_at":"2016-11-02T16:20:38Z","pushed_at":"2016-11-02T21:29:30Z","git_url":"git://github.com/angular/angular.io.git","ssh_url":"git@github.com:angular/angular.io.git","clone_url":"https://github.com/angular/angular.io.git","svn_url":"https://github.com/angular/angular.io","homepage":"https://angular.io","size":55198,"stargazers_count":690,"watchers_count":690,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":823,"mirror_url":null,"open_issues_count":276,"forks":823,"open_issues":276,"watchers":690,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/angular.io/pulls/2740"},"html":{"href":"https://github.com/angular/angular.io/pull/2740"},"issue":{"href":"https://api.github.com/repos/angular/angular.io/issues/2740"},"comments":{"href":"https://api.github.com/repos/angular/angular.io/issues/2740/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/angular.io/pulls/2740/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/angular.io/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/angular.io/pulls/2740/commits"},"statuses":{"href":"https://api.github.com/repos/angular/angular.io/statuses/8410291238552b219115c84c3a34adae3656b292"}}}}
{"actor":{"display_login":"vicb"}}