{"action":"created","comment":{"url":"https://api.github.com/repos/alexandrebarachant/pyRiemann/pulls/comments/69290103","id":69290103,"diff_hunk":"@@ -206,17 +206,21 @@ class XdawnCovariances(BaseEstimator, TransformerMixin):\n     \"\"\"\n \n     def __init__(self, nfilter=4, applyfilters=True, classes=None,\n-                 estimator='scm', xdawn_estimator='scm'):\n+                 estimator='scm', xdawn_estimator='scm', baseline_cov=None):\n         \"\"\"Init.\"\"\"\n         self.applyfilters = applyfilters\n         self.estimator = estimator\n         self.xdawn_estimator = xdawn_estimator\n         self.classes = classes\n         self.nfilter = nfilter\n+        self.baseline_cov = baseline_cov\n \n     def fit(self, X, y):\n+        # FIXME self.Xd should be init at XdawnCovariances.__init__ and be\n+        # replaced as param not attribute","path":"pyriemann/estimation.py","position":16,"original_position":16,"commit_id":"353b65cf4308f3e34d38cddc5cf25f8d160e88d7","original_commit_id":"353b65cf4308f3e34d38cddc5cf25f8d160e88d7","user":{"login":"alexandrebarachant","id":2145718,"avatar_url":"https://avatars.githubusercontent.com/u/2145718?v=3","gravatar_id":"","url":"https://api.github.com/users/alexandrebarachant","html_url":"https://github.com/alexandrebarachant","followers_url":"https://api.github.com/users/alexandrebarachant/followers","following_url":"https://api.github.com/users/alexandrebarachant/following{/other_user}","gists_url":"https://api.github.com/users/alexandrebarachant/gists{/gist_id}","starred_url":"https://api.github.com/users/alexandrebarachant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexandrebarachant/subscriptions","organizations_url":"https://api.github.com/users/alexandrebarachant/orgs","repos_url":"https://api.github.com/users/alexandrebarachant/repos","events_url":"https://api.github.com/users/alexandrebarachant/events{/privacy}","received_events_url":"https://api.github.com/users/alexandrebarachant/received_events","type":"User","site_admin":false},"body":"I think in encountered problem when object are initialized in the init. it caused issues for `deepcopy()` of the object in scikit-learn pipeline. it's something to check because it's all over the place in the toolbox.","created_at":"2016-07-01T12:12:40Z","updated_at":"2016-07-01T12:12:40Z","html_url":"https://github.com/alexandrebarachant/pyRiemann/pull/27#discussion_r69290103","pull_request_url":"https://api.github.com/repos/alexandrebarachant/pyRiemann/pulls/27","_links":{"self":{"href":"https://api.github.com/repos/alexandrebarachant/pyRiemann/pulls/comments/69290103"},"html":{"href":"https://github.com/alexandrebarachant/pyRiemann/pull/27#discussion_r69290103"},"pull_request":{"href":"https://api.github.com/repos/alexandrebarachant/pyRiemann/pulls/27"}}},"pull_request":{"url":"https://api.github.com/repos/alexandrebarachant/pyRiemann/pulls/27","id":75946187,"html_url":"https://github.com/alexandrebarachant/pyRiemann/pull/27","diff_url":"https://github.com/alexandrebarachant/pyRiemann/pull/27.diff","patch_url":"https://github.com/alexandrebarachant/pyRiemann/pull/27.patch","issue_url":"https://api.github.com/repos/alexandrebarachant/pyRiemann/issues/27","number":27,"state":"open","locked":false,"title":"ENH: allow precomputed baseline covariance","user":{"login":"kingjr","id":4881164,"avatar_url":"https://avatars.githubusercontent.com/u/4881164?v=3","gravatar_id":"","url":"https://api.github.com/users/kingjr","html_url":"https://github.com/kingjr","followers_url":"https://api.github.com/users/kingjr/followers","following_url":"https://api.github.com/users/kingjr/following{/other_user}","gists_url":"https://api.github.com/users/kingjr/gists{/gist_id}","starred_url":"https://api.github.com/users/kingjr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kingjr/subscriptions","organizations_url":"https://api.github.com/users/kingjr/orgs","repos_url":"https://api.github.com/users/kingjr/repos","events_url":"https://api.github.com/users/kingjr/events{/privacy}","received_events_url":"https://api.github.com/users/kingjr/received_events","type":"User","site_admin":false},"body":"Here is what I was suggesting to compute the \"baseline\" cov with unlabeled data.\r\n\r\nLTKWYT","created_at":"2016-07-01T08:44:25Z","updated_at":"2016-07-01T12:12:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"970ac6d07bbf033a1a4203b8a91870d349f91264","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/alexandrebarachant/pyRiemann/pulls/27/commits","review_comments_url":"https://api.github.com/repos/alexandrebarachant/pyRiemann/pulls/27/comments","review_comment_url":"https://api.github.com/repos/alexandrebarachant/pyRiemann/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alexandrebarachant/pyRiemann/issues/27/comments","statuses_url":"https://api.github.com/repos/alexandrebarachant/pyRiemann/statuses/353b65cf4308f3e34d38cddc5cf25f8d160e88d7","head":{"label":"kingjr:xdawn_precov","ref":"xdawn_precov","sha":"353b65cf4308f3e34d38cddc5cf25f8d160e88d7","user":{"login":"kingjr","id":4881164,"avatar_url":"https://avatars.githubusercontent.com/u/4881164?v=3","gravatar_id":"","url":"https://api.github.com/users/kingjr","html_url":"https://github.com/kingjr","followers_url":"https://api.github.com/users/kingjr/followers","following_url":"https://api.github.com/users/kingjr/following{/other_user}","gists_url":"https://api.github.com/users/kingjr/gists{/gist_id}","starred_url":"https://api.github.com/users/kingjr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kingjr/subscriptions","organizations_url":"https://api.github.com/users/kingjr/orgs","repos_url":"https://api.github.com/users/kingjr/repos","events_url":"https://api.github.com/users/kingjr/events{/privacy}","received_events_url":"https://api.github.com/users/kingjr/received_events","type":"User","site_admin":false},"repo":{"id":37619335,"name":"pyRiemann","full_name":"kingjr/pyRiemann","owner":{"login":"kingjr","id":4881164,"avatar_url":"https://avatars.githubusercontent.com/u/4881164?v=3","gravatar_id":"","url":"https://api.github.com/users/kingjr","html_url":"https://github.com/kingjr","followers_url":"https://api.github.com/users/kingjr/followers","following_url":"https://api.github.com/users/kingjr/following{/other_user}","gists_url":"https://api.github.com/users/kingjr/gists{/gist_id}","starred_url":"https://api.github.com/users/kingjr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kingjr/subscriptions","organizations_url":"https://api.github.com/users/kingjr/orgs","repos_url":"https://api.github.com/users/kingjr/repos","events_url":"https://api.github.com/users/kingjr/events{/privacy}","received_events_url":"https://api.github.com/users/kingjr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kingjr/pyRiemann","description":"Python package for covariance matrices manipulation and Biosignal classification","fork":true,"url":"https://api.github.com/repos/kingjr/pyRiemann","forks_url":"https://api.github.com/repos/kingjr/pyRiemann/forks","keys_url":"https://api.github.com/repos/kingjr/pyRiemann/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kingjr/pyRiemann/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kingjr/pyRiemann/teams","hooks_url":"https://api.github.com/repos/kingjr/pyRiemann/hooks","issue_events_url":"https://api.github.com/repos/kingjr/pyRiemann/issues/events{/number}","events_url":"https://api.github.com/repos/kingjr/pyRiemann/events","assignees_url":"https://api.github.com/repos/kingjr/pyRiemann/assignees{/user}","branches_url":"https://api.github.com/repos/kingjr/pyRiemann/branches{/branch}","tags_url":"https://api.github.com/repos/kingjr/pyRiemann/tags","blobs_url":"https://api.github.com/repos/kingjr/pyRiemann/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kingjr/pyRiemann/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kingjr/pyRiemann/git/refs{/sha}","trees_url":"https://api.github.com/repos/kingjr/pyRiemann/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kingjr/pyRiemann/statuses/{sha}","languages_url":"https://api.github.com/repos/kingjr/pyRiemann/languages","stargazers_url":"https://api.github.com/repos/kingjr/pyRiemann/stargazers","contributors_url":"https://api.github.com/repos/kingjr/pyRiemann/contributors","subscribers_url":"https://api.github.com/repos/kingjr/pyRiemann/subscribers","subscription_url":"https://api.github.com/repos/kingjr/pyRiemann/subscription","commits_url":"https://api.github.com/repos/kingjr/pyRiemann/commits{/sha}","git_commits_url":"https://api.github.com/repos/kingjr/pyRiemann/git/commits{/sha}","comments_url":"https://api.github.com/repos/kingjr/pyRiemann/comments{/number}","issue_comment_url":"https://api.github.com/repos/kingjr/pyRiemann/issues/comments{/number}","contents_url":"https://api.github.com/repos/kingjr/pyRiemann/contents/{+path}","compare_url":"https://api.github.com/repos/kingjr/pyRiemann/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kingjr/pyRiemann/merges","archive_url":"https://api.github.com/repos/kingjr/pyRiemann/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kingjr/pyRiemann/downloads","issues_url":"https://api.github.com/repos/kingjr/pyRiemann/issues{/number}","pulls_url":"https://api.github.com/repos/kingjr/pyRiemann/pulls{/number}","milestones_url":"https://api.github.com/repos/kingjr/pyRiemann/milestones{/number}","notifications_url":"https://api.github.com/repos/kingjr/pyRiemann/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kingjr/pyRiemann/labels{/name}","releases_url":"https://api.github.com/repos/kingjr/pyRiemann/releases{/id}","deployments_url":"https://api.github.com/repos/kingjr/pyRiemann/deployments","created_at":"2015-06-17T20:34:05Z","updated_at":"2015-06-17T20:34:05Z","pushed_at":"2016-07-01T12:03:22Z","git_url":"git://github.com/kingjr/pyRiemann.git","ssh_url":"git@github.com:kingjr/pyRiemann.git","clone_url":"https://github.com/kingjr/pyRiemann.git","svn_url":"https://github.com/kingjr/pyRiemann","homepage":null,"size":221,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"alexandrebarachant:master","ref":"master","sha":"dcec9cd896786481e0182e4e9b93056edb114cf6","user":{"login":"alexandrebarachant","id":2145718,"avatar_url":"https://avatars.githubusercontent.com/u/2145718?v=3","gravatar_id":"","url":"https://api.github.com/users/alexandrebarachant","html_url":"https://github.com/alexandrebarachant","followers_url":"https://api.github.com/users/alexandrebarachant/followers","following_url":"https://api.github.com/users/alexandrebarachant/following{/other_user}","gists_url":"https://api.github.com/users/alexandrebarachant/gists{/gist_id}","starred_url":"https://api.github.com/users/alexandrebarachant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexandrebarachant/subscriptions","organizations_url":"https://api.github.com/users/alexandrebarachant/orgs","repos_url":"https://api.github.com/users/alexandrebarachant/repos","events_url":"https://api.github.com/users/alexandrebarachant/events{/privacy}","received_events_url":"https://api.github.com/users/alexandrebarachant/received_events","type":"User","site_admin":false},"repo":{"id":34213430,"name":"pyRiemann","full_name":"alexandrebarachant/pyRiemann","owner":{"login":"alexandrebarachant","id":2145718,"avatar_url":"https://avatars.githubusercontent.com/u/2145718?v=3","gravatar_id":"","url":"https://api.github.com/users/alexandrebarachant","html_url":"https://github.com/alexandrebarachant","followers_url":"https://api.github.com/users/alexandrebarachant/followers","following_url":"https://api.github.com/users/alexandrebarachant/following{/other_user}","gists_url":"https://api.github.com/users/alexandrebarachant/gists{/gist_id}","starred_url":"https://api.github.com/users/alexandrebarachant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexandrebarachant/subscriptions","organizations_url":"https://api.github.com/users/alexandrebarachant/orgs","repos_url":"https://api.github.com/users/alexandrebarachant/repos","events_url":"https://api.github.com/users/alexandrebarachant/events{/privacy}","received_events_url":"https://api.github.com/users/alexandrebarachant/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alexandrebarachant/pyRiemann","description":"Python package for covariance matrices manipulation and Biosignal classification","fork":false,"url":"https://api.github.com/repos/alexandrebarachant/pyRiemann","forks_url":"https://api.github.com/repos/alexandrebarachant/pyRiemann/forks","keys_url":"https://api.github.com/repos/alexandrebarachant/pyRiemann/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alexandrebarachant/pyRiemann/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alexandrebarachant/pyRiemann/teams","hooks_url":"https://api.github.com/repos/alexandrebarachant/pyRiemann/hooks","issue_events_url":"https://api.github.com/repos/alexandrebarachant/pyRiemann/issues/events{/number}","events_url":"https://api.github.com/repos/alexandrebarachant/pyRiemann/events","assignees_url":"https://api.github.com/repos/alexandrebarachant/pyRiemann/assignees{/user}","branches_url":"https://api.github.com/repos/alexandrebarachant/pyRiemann/branches{/branch}","tags_url":"https://api.github.com/repos/alexandrebarachant/pyRiemann/tags","blobs_url":"https://api.github.com/repos/alexandrebarachant/pyRiemann/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alexandrebarachant/pyRiemann/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alexandrebarachant/pyRiemann/git/refs{/sha}","trees_url":"https://api.github.com/repos/alexandrebarachant/pyRiemann/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alexandrebarachant/pyRiemann/statuses/{sha}","languages_url":"https://api.github.com/repos/alexandrebarachant/pyRiemann/languages","stargazers_url":"https://api.github.com/repos/alexandrebarachant/pyRiemann/stargazers","contributors_url":"https://api.github.com/repos/alexandrebarachant/pyRiemann/contributors","subscribers_url":"https://api.github.com/repos/alexandrebarachant/pyRiemann/subscribers","subscription_url":"https://api.github.com/repos/alexandrebarachant/pyRiemann/subscription","commits_url":"https://api.github.com/repos/alexandrebarachant/pyRiemann/commits{/sha}","git_commits_url":"https://api.github.com/repos/alexandrebarachant/pyRiemann/git/commits{/sha}","comments_url":"https://api.github.com/repos/alexandrebarachant/pyRiemann/comments{/number}","issue_comment_url":"https://api.github.com/repos/alexandrebarachant/pyRiemann/issues/comments{/number}","contents_url":"https://api.github.com/repos/alexandrebarachant/pyRiemann/contents/{+path}","compare_url":"https://api.github.com/repos/alexandrebarachant/pyRiemann/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alexandrebarachant/pyRiemann/merges","archive_url":"https://api.github.com/repos/alexandrebarachant/pyRiemann/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alexandrebarachant/pyRiemann/downloads","issues_url":"https://api.github.com/repos/alexandrebarachant/pyRiemann/issues{/number}","pulls_url":"https://api.github.com/repos/alexandrebarachant/pyRiemann/pulls{/number}","milestones_url":"https://api.github.com/repos/alexandrebarachant/pyRiemann/milestones{/number}","notifications_url":"https://api.github.com/repos/alexandrebarachant/pyRiemann/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alexandrebarachant/pyRiemann/labels{/name}","releases_url":"https://api.github.com/repos/alexandrebarachant/pyRiemann/releases{/id}","deployments_url":"https://api.github.com/repos/alexandrebarachant/pyRiemann/deployments","created_at":"2015-04-19T16:01:44Z","updated_at":"2016-06-28T18:43:53Z","pushed_at":"2016-07-01T12:03:23Z","git_url":"git://github.com/alexandrebarachant/pyRiemann.git","ssh_url":"git@github.com:alexandrebarachant/pyRiemann.git","clone_url":"https://github.com/alexandrebarachant/pyRiemann.git","svn_url":"https://github.com/alexandrebarachant/pyRiemann","homepage":null,"size":221,"stargazers_count":36,"watchers_count":36,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":4,"forks":11,"open_issues":4,"watchers":36,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alexandrebarachant/pyRiemann/pulls/27"},"html":{"href":"https://github.com/alexandrebarachant/pyRiemann/pull/27"},"issue":{"href":"https://api.github.com/repos/alexandrebarachant/pyRiemann/issues/27"},"comments":{"href":"https://api.github.com/repos/alexandrebarachant/pyRiemann/issues/27/comments"},"review_comments":{"href":"https://api.github.com/repos/alexandrebarachant/pyRiemann/pulls/27/comments"},"review_comment":{"href":"https://api.github.com/repos/alexandrebarachant/pyRiemann/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alexandrebarachant/pyRiemann/pulls/27/commits"},"statuses":{"href":"https://api.github.com/repos/alexandrebarachant/pyRiemann/statuses/353b65cf4308f3e34d38cddc5cf25f8d160e88d7"}}}}
{"actor":{"display_login":"alexandrebarachant"}}